Publish DEPS for Chromium 67.0.3396.59

• DEPS[diff]

Incrementing VERSION to 67.0.3396.59

[email protected]

Change-Id: I692d442cefd08f30f1b0affe6e6b0fa9de517bb4
Reviewed-on: https://chromium-review.googlesource.com/1070792
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#690}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Fix stuck download notification.

In an attempt to make the UX more responsive, we had previously added
code to update the notification update quickly in response to a user
gesture.  However if our persistence layers get out of sync, this can
lead to a sticky notification that can't be removed/can start a
foreground service in the background.

This change makes the optimization still happen, but removes the check
to disable state updating until the backend gets back to the front end.
This way the front end's persistence layer will be updated even if the
backend has no knowledge of the item and does not reply.

BUG=845713

(cherry picked from commit 899ae164b3da5968045157d278614815f85c76f5)

Change-Id: Idcfb6a4068cb3c09536464ed944d45f7a9530762
Reviewed-on: https://chromium-review.googlesource.com/1069771
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560900}
Reviewed-on: https://chromium-review.googlesource.com/1070754
Cr-Commit-Position: refs/branch-heads/3396@{#689}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java[diff]

Chrome OS: Close outstanding notifications on shutdown

Previously we used the deprecated NotificationUiService::CancelAll
via BrowserCloseManager to do this. That used the MessageCenter
singleton directly, which worked with in-process Ash but not oop Ash.
By listening for profile shutdown in the NotificationPlatformBridge, we
can accomplish the same thing and it works in oop Ash as well.

This is a roundabout way of fixing the bug, which AFAICT is a race
between the Profile object shutting down and Ash asynchronously (via
mojo) notifying of a notification toast closing. I couldn't figure out
how to trigger this race, hence no direct test.

[email protected]

(cherry picked from commit 48b4285e027e0750756c491610a0c988054ffebf)

Bug: 842705
Change-Id: I5913bcb3077450433e26ba6cc7397e17211bc9a6
Reviewed-on: https://chromium-review.googlesource.com/1058491
Reviewed-by: Yoshiki Iguchi <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559175}
Reviewed-on: https://chromium-review.googlesource.com/1070531
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#688}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/browser_process_impl.cc[diff]
• chrome/browser/notifications/message_center_notifications_browsertest.cc[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos.cc[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos.h[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos_browsertest.cc[Added - diff]
• chrome/test/BUILD.gn[diff]

[AF] Updates the save CC prompt message on mobile

Updates the prompt message on mobile to take into account the
AutofillUpstreamUpdatePromptExplanation experiment similar to Desktop

[email protected]

(cherry picked from commit 2c9d3a0a6361d0a048d4cef03359b6a8caaca691)

Bug: 844472
Change-Id: I24bbabbb1af5f1d559196b6dccca5e600aff13ad
Reviewed-on: https://chromium-review.googlesource.com/1066212
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Mathieu Perreault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559933}
Reviewed-on: https://chromium-review.googlesource.com/1070484
Cr-Commit-Position: refs/branch-heads/3396@{#687}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc[diff]

Fix a crash in BackgroundTaskSchedulerJobService.

On Android M, JobScheduler.cancel() may throw NullpointerException on
the IBinder for the underlying job scheduler service. There is no much
things can be fixed in Chrome layer, so try catch this exception to
avoid crash caused by Android.

[email protected]

(cherry picked from commit 085650f592682504751be2646800f3f0b3af35be)

Bug: 842353
Change-Id: Ibfc2d763a93a52e3f85e1c26df1123402a689154
Reviewed-on: https://chromium-review.googlesource.com/1062943
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559793}
Reviewed-on: https://chromium-review.googlesource.com/1070481
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#686}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerJobService.java[diff]

[Nav Experiment] Skip native error if URL is blocked by content filter.

Cherrypick to refs/branch-heads/3396.

When a URL is blocked due to Restrictions settings, WKWebView triggers
|webView:didFailProvisionalNavigation| and automatically triggers a
second navigation that loads an error page. Without this change, Chrome
injects an extra navigation entry for displaying native error, which
shows up after the system "Access Restricted" error.

Bug: 831381,793317
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaafcc8f1c5abde120ad10d0794832ab09abeec6d
Reviewed-on: https://chromium-review.googlesource.com/1012470
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Danyao Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550898}(cherry picked from commit 2233628f5f5b32c7b458428f8d5cfbd0a18be82e)
Reviewed-on: https://chromium-review.googlesource.com/1070408
Reviewed-by: Danyao Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#685}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/web/public/web_kit_constants.h[diff]
• ios/web/web_state/ui/crw_web_controller.mm[diff]

Incrementing VERSION to 67.0.3396.58

[email protected]

Change-Id: I1aae3e946298085383a5054db4c9002a4fc5e12b
Reviewed-on: https://chromium-review.googlesource.com/1069004
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#684}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Incrementing VERSION to 67.0.3396.57

[email protected]

Change-Id: Ia3230340dcda579fb322dce75ddf55456afd1ba3
Reviewed-on: https://chromium-review.googlesource.com/1069847
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#683}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Incrementing VERSION to 67.0.3396.56

[email protected]

Change-Id: Ib62d4b5526070cb3c6fea67a752895566ee8c378
Reviewed-on: https://chromium-review.googlesource.com/1069610
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#682}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Handle web modal dialogs being unexpectedly closed by -[NSWindow close].

These dialogs have no titlebar, so it should be "impossible" for this
to occur, but crashes in https://crbug.com/825809 suggest it can.
Possibly it happens via code injection or a third party tool.

Add handling and test coverage.

Bug: 825809
Change-Id: Ic856de62ae15ee82ac1346ba6098f2c48daf6d19
Reviewed-on: https://chromium-review.googlesource.com/1068569
Commit-Queue: Sidney San Martín <[email protected]>
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560544}(cherry picked from commit 9905c3ff1cc0bf4d604601d8d167599a8946b21f)
Reviewed-on: https://chromium-review.googlesource.com/1067650
Cr-Commit-Position: refs/branch-heads/3396@{#681}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm[diff]
• chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm[diff]

Limit MSAA to 4x on Android devices

These devices tend to be hi-dpi, and low-power. 8x MSAA has also been
seen to trigger various bugs, and impacts performance on some devices.

Bug: 797243, 730303
Change-Id: I41f1ef387009f1f63dff82ecb1f3737d3a0c22aa
Reviewed-on: https://chromium-review.googlesource.com/1013279
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Kai Ninomiya <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550873}(cherry picked from commit 687cb227f2d9a18d632a2657773b0a52889b1c49)
Reviewed-on: https://chromium-review.googlesource.com/1069422
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#680}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• gpu/config/gpu_driver_bug_list.json[diff]

[Nav Experiment] Allow back/forward navigation to WebUI URL.

Cherry-pick to refs/branch-heads/3396.

This is to handle an edge case where on the second back navigation to a
WebUI URL from a web URL, |backForwardList.currentItem.URL| becomes the
WebUI URL instead of the placeholder URL. This is incorrectly classified
as a renderer-initiated app-specific load. The early exit causes no
NavigationContext to be created, which leads to nullptr deferences in
|webView:didCommitNavigation| and |webView:didFinishNavigation|.

Also added nullptr checks for NavigationContext in general.

[email protected]

Bug: 838585,818813
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1e2225adac2cc639e4f6a51bdcb4dece03d96648
Reviewed-on: https://chromium-review.googlesource.com/1044875
Commit-Queue: Danyao Wang <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556489}(cherry picked from commit 4ebe29d3d16d74fea153a8bfa01af0985a3d03de)
Reviewed-on: https://chromium-review.googlesource.com/1069372
Reviewed-by: Danyao Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#679}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/chrome/browser/ui/webui/web_ui_egtest.mm[diff]
• ios/web/web_state/ui/crw_web_controller.mm[diff]

Downloads : Fixed NPE

Added a protection against a crash occuring during clicking of menu items
in Download home. The possible reason could be that DownloadItemView can
have a null |mItem| until a onBindViewHolder call is received from the
RecyclerView after the creation through onCreateViewHolder. Hence we
should have null checks inside the DownloadItemView against |mItem|.

Bug: 834918
Change-Id: I76b8a08465da575b9ce364859f827ea3ff053bb5
Reviewed-on: https://chromium-review.googlesource.com/1058369
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558567}(cherry picked from commit e00f4dc4bd361540c7f9facc32702e9efa655a3a)
Reviewed-on: https://chromium-review.googlesource.com/1069310
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#678}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java[diff]

gles2_cmd_decoder: Allow GL_BGRA_EXT in CopyTexImage2D

The GL_EXT_texture_format_BGRA8888 only calls out two entry points
that accept the new GL_BGRA_EXT internalformat:

    Accepted by the <format> and <internalformat> parameters of TexImage2D
    and the <format> parameter of TexSubImage2D:

        GL_BGRA_EXT                                     0x80E1

Some drivers seem to silently allow the format in CopyTexImage2D, but
others throw GL_INVALID_ENUM.  We allow this for clients, by taking
the existing TexImage2D+TexCopySubImage path when internalformat is
GL_BGRA_EXT.

Bug: 834006
Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3
Reviewed-on: https://chromium-review.googlesource.com/1036467
Commit-Queue: Kristian H. Kristensen <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555264}(cherry picked from commit f1fde8494e5740945e9a7e50fb86e296a09ea1ad)
Reviewed-on: https://chromium-review.googlesource.com/1067716
Reviewed-by: Kristian H. Kristensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#677}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• gpu/command_buffer/service/gles2_cmd_decoder.cc[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc[diff]

[Media Controls] Propagate unhandled overlay play button click events

This CL allows click events on the overlay play button to be
propagated if they do not cause a play/pause. This fixes an issue where
sites that dismissed menus on tap would fail since they would not be
able to see the event being fired.

Bug: 841207
Change-Id: Ib045bb81acc259f932b6adcad1875b5408957f4f
Reviewed-on: https://chromium-review.googlesource.com/1067514
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560375}(cherry picked from commit 259b9dd2958a439531dca094106cb3f2d06e332e)
Reviewed-on: https://chromium-review.googlesource.com/1067740
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#676}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/media/controls/click-on-side-of-overlay-play-button-is-propagated.html[Added - diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_button_panel_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_button_panel_element.h[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc[diff]

[Merge M67] app_launcher: Fix race condition creating OEM folder.

This fixes one more race condition for OEM folder creation where it is
created on demand on ash side first. This also fixes issue when OEM
folder may appear in ash as normal folder. Plus does refactoring by
discarding passing redundant oem_folder_id.

[email protected]

(cherry picked from commit 4decb912159aee0557f3170703ce1bde01951d51)

Test: Manually
Bug: 839024
Change-Id: I3844e8fbf24fc12c806f25f7c87973eebe167d02
Reviewed-on: https://chromium-review.googlesource.com/1060166
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559122}
Reviewed-on: https://chromium-review.googlesource.com/1066464
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#675}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/app_list/app_list_controller_impl.cc[diff]
• ash/app_list/app_list_controller_impl.h[diff]
• ash/app_list/model/app_list_folder_item.cc[diff]
• ash/app_list/model/app_list_folder_item.h[diff]
• ash/app_list/model/app_list_model.cc[diff]
• ash/app_list/model/app_list_model_unittest.cc[diff]
• ash/public/interfaces/app_list.mojom[diff]
• chrome/browser/ui/app_list/app_list_model_updater.h[diff]
• chrome/browser/ui/app_list/app_list_syncable_service.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_model_updater.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_model_updater.h[diff]
• chrome/browser/ui/app_list/test/fake_app_list_model_updater.cc[diff]
• chrome/browser/ui/app_list/test/fake_app_list_model_updater.h[diff]
• ui/app_list/test/app_list_test_model.cc[diff]
• ui/app_list/test/app_list_test_model.h[diff]
• ui/app_list/views/folder_header_view_unittest.cc[diff]

Merge to M67: Add policy to control app install event logging

Rather than sharing a policy with ARC++ status reporting, this
should be controlled by its own policy.

TBR: [email protected]

(cherry picked from commit d4d93a771895e2998dcde22205bf2fcd48af85c2)

Bug: 843590
Test: AppInstallEventLogManagerWrapperTest
Change-Id: I06910add1cca28f44cf21a57c3eca909a9c88f7c
Reviewed-on: https://chromium-review.googlesource.com/1061532
Commit-Queue: Bartosz Fabianowski <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559626}
Reviewed-on: https://chromium-review.googlesource.com/1065814
Reviewed-by: Bartosz Fabianowski <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#674}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/policy/app_install_event_log_manager_wrapper.cc[diff]
• chrome/browser/chromeos/policy/app_install_event_log_manager_wrapper.h[diff]
• chrome/browser/chromeos/policy/app_install_event_log_manager_wrapper_unittest.cc[diff]
• chrome/browser/policy/configuration_policy_handler_list_factory.cc[diff]
• chrome/browser/prefs/browser_prefs.cc[diff]
• chrome/common/pref_names.cc[diff]
• chrome/common/pref_names.h[diff]
• chrome/test/data/policy/policy_test_cases.json[diff]
• components/policy/resources/policy_templates.json[diff]
• tools/metrics/histograms/enums.xml[diff]

MHTML serialization needs to handle remote frames in <object> tag.

[email protected]

(cherry picked from commit b623dcf4da0f889b9964c564cc5792c334b9e74e)

Bug: 842411
Change-Id: Ie0205e6e801048c1316ca46da4a4993fd1e009f4
Reviewed-on: https://chromium-review.googlesource.com/1060470
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559618}
Reviewed-on: https://chromium-review.googlesource.com/1068509
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#673}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/download/save_page_browsertest.cc[diff]
• chrome/test/data/save_page/cross-site-object.htm[Added - diff]
• chrome/test/data/save_page/svg.svg[diff]
• testing/buildbot/filters/mash.browser_tests.filter[diff]
• third_party/blink/renderer/core/exported/web_frame_serializer.cc[diff]

Incrementing VERSION to 67.0.3396.55

[email protected]

Change-Id: I4dded8534392c2005d4d4cecb8b39c954429c98d
Reviewed-on: https://chromium-review.googlesource.com/1067962
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#672}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Merge to M67: Remove frame traversal in TextFinder::UpdateFindMatchRects().

Since find-in-page now works on a per-frame basis in the renderer, TextFinder
should not be doing any frame traversal. This also fixes a crash where
TextFinder attempted to access a remote frame during this traversal.

Bug: 840790
Change-Id: If14a17ab8e75c3de56985d53ef4700d3831df3ae
Reviewed-on: https://chromium-review.googlesource.com/1058133
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558917}(cherry picked from commit 44c3d02af75b7c03dc585fab91d9c029cc8528f3)
Reviewed-on: https://chromium-review.googlesource.com/1067950
Cr-Commit-Position: refs/branch-heads/3396@{#671}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/editing/finder/text_finder.cc[diff]
• third_party/blink/renderer/core/editing/finder/text_finder.h[diff]

Merge to M67: Fix CursorManager crash on Android.

Tooltips aren't used on Android, and neither are CursorManagers. This CL
removes a CursorManager null-dereference in
RenderWidgetHostViewChildFrame that occurs on Android.

Bug: 842410
Change-Id: I737d7c4ab6a5befda660a9df5598469ac2802fe6
Reviewed-on: https://chromium-review.googlesource.com/1057993
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559054}(cherry picked from commit dc521ff9228af3d93e206fca9cd149acf392e839)
Reviewed-on: https://chromium-review.googlesource.com/1067952
Cr-Commit-Position: refs/branch-heads/3396@{#670}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/render_widget_host_view_child_frame.cc[diff]

Merge to M67: Return empty hit-test result when the local main frame is not valid.

When we do async hit-testing for OOPIF, we can be trying to do
hit-testing when the local main frame is not valid anymore. Add null
check for that and return empty hit-test result in that case; it would
then be handled in RenderWidgetInputHandler::GetFrameSinkIdAtPoint [1].

[1] https://cs.chromium.org/chromium/src/content/renderer/input/render_widget_input_handler.cc?type=cs&g=0&l=194

Bug: 842458
Change-Id: Ic6a90de54840973a8262ea88472ae9d295c6f773
Reviewed-on: https://chromium-review.googlesource.com/1058343
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Ria Jiang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558794}(cherry picked from commit b344dd9cf8f51d1051774f79e789185798a81afe)
Reviewed-on: https://chromium-review.googlesource.com/1067951
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#669}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/exported/web_view_impl.cc[diff]

Updating XTBs based on .GRDs from branch 3396

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8a485d0c772c59ce78cd48374f43f2813f993912
Reviewed-on: https://chromium-review.googlesource.com/1068099
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#668}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/components/strings/ash_components_strings_fa.xtb[diff]
• ash/components/strings/ash_components_strings_mr.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_iw.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_pl.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_es.xtb[diff]
• chrome/app/resources/generated_resources_fa.xtb[diff]
• chrome/app/resources/generated_resources_iw.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_zh-TW.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb[diff]
• components/policy/resources/policy_templates_id.xtb[diff]
• components/strings/components_strings_iw.xtb[diff]
• components/strings/components_strings_pl.xtb[diff]
• ui/strings/translations/ui_strings_fa.xtb[diff]

Fix Linux proxy settings retrieval.

Only the environment variables were being consulted and not the desktop environment's settings.

[email protected]

(cherry picked from commit cd032fb6004648637d75ac7e3c8677c7e2612811)

Bug: 843942
Change-Id: I22c850717565b219f8ac0dc7566085cccc81af08
Reviewed-on: https://chromium-review.googlesource.com/1066562
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560054}
Reviewed-on: https://chromium-review.googlesource.com/1067789
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#667}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• net/proxy_resolution/proxy_config_service_linux.cc[diff]
• net/proxy_resolution/proxy_config_service_linux.h[diff]

Update shelf visibility when display configuration changes.

Shelf is supposed to be hidden on secondary diaplay on lock and login
screens. To reporduce the bug external display needs to be set as primary
screen and then attached while on lock screen. In that case external
monitor is first added as secondary and later set as primary. Shelf
visibility was not updated for the new secondary disply after the primary
display was changed.

Similar bug was also present for login screen. To fix it removing the early
return from ShelfLayoutManager::UpdateVisibilityState was needed. The issue
that required early return is already fixed.

[email protected]

(cherry picked from commit 8af5e106aa826f15b44303af358312d3a7e35c96)

Bug: 824504
Change-Id: I2e3b8e9d6427e3496e72651ba4be1bab538fe25c
Reviewed-on: https://chromium-review.googlesource.com/1052488
Commit-Queue: Aga Wronska <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559922}
Reviewed-on: https://chromium-review.googlesource.com/1067492
Reviewed-by: Aga Wronska <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#666}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/shelf/shelf_controller.cc[diff]
• ash/shelf/shelf_layout_manager.cc[diff]
• ash/shelf/shelf_layout_manager.h[diff]
• ash/shelf/shelf_unittest.cc[diff]

Make renderer use random initial RequestID (instead of 0).

We speculate that some RDH_INVALID_REQUEST_ID kills are caused by having
a renderer process restarted after a crash reuse the same RequestID as
the renderer process from before the crash.  This CL changes the initial
RequestID used by a renderer - before this CL it was always initialized
to 0, after this CL it will be initialized to a random number.  After
this CL the probability of using the same RequestID after restarting a
crashed renderer should drop.

The range of the initial, random RequestID is chosen so that
- The likelyhood of hitting a duplicate is low.
- The work required to overflow the RequestID remains high.

[email protected]

(cherry picked from commit 3538dd4e99019f0c737de06b52477722a5c26c73)

Bug: 614281
Change-Id: I48d21cda1efa3a3e6559726d7fa776bdbb4b05dd
Reviewed-on: https://chromium-review.googlesource.com/1064312
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559629}
Reviewed-on: https://chromium-review.googlesource.com/1067736
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#665}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/renderer/loader/resource_dispatcher.cc[diff]

Merge to M67: Prevent OOPIF resize events from firing after load

OOPIFs will fire resize event handlers immediately after load, because
of the event being triggered in WebFrameWidgetImpl::Resize when the
frame's initial size information is received. This breaks some embedded
frames who assume that it will fire only when the frame actually
changes size.

Bug: 826457
Change-Id: I73de6ff8a81e94a1fd4ad9f7ff6d9ce4df755d7d
Reviewed-on: https://chromium-review.googlesource.com/1064825
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Ken Buchanan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559747}
Reviewed-on: https://chromium-review.googlesource.com/1067486
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#664}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/site_per_process_browsertest.cc[diff]
• content/test/data/page_with_resize_handler.html[Added - diff]
• third_party/blink/renderer/core/frame/web_frame_widget_impl.cc[diff]

Add DigiCert Yeti to Trusted CT Logs

[67 merge] The following CT Logs have passed their monitoring period an are being
added as trusted Logs in Chrome:

DigiCert Yeti2018, Yeti2019, Yeti2020, Yeti2021, Yeti2022

[email protected]
[email protected]

(cherry picked from commit 4508ef53b34e90e445e60dda8fd45f50e89d84dc)

Bug: 796333
Change-Id: I83f7238ed90f2e370c7cf1fe196b6f48862f7d10
Reviewed-on: https://chromium-review.googlesource.com/1058686
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559734}
Reviewed-on: https://chromium-review.googlesource.com/1067509
Reviewed-by: Andrew Whalley <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#663}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• net/data/ssl/certificate_transparency/log_list.json[diff]

[IndexedDB] Fixing early destruction of connection during forceclose

Patch is as small as possible for merging.

Bug: 842990
Change-Id: I9968ffee1bf3279e61e1ec13e4d541f713caf12f
Reviewed-on: https://chromium-review.googlesource.com/1062935
Commit-Queue: Daniel Murphy <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559383}(cherry picked from commit 28044cb7ef4488e7278c2b80f0e3a2c3707d03b6)
Reviewed-on: https://chromium-review.googlesource.com/1067057
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#662}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/indexed_db/indexed_db_database.cc[diff]
• content/browser/indexed_db/indexed_db_transaction.cc[diff]
• content/browser/indexed_db/indexed_db_transaction.h[diff]

Avoid the spare renderer on low-memory devices

[email protected]

(cherry picked from commit 9836bd6629206bbb3f18ef59cf133f22ac6c74e7)

Bug: 843775
Change-Id: I60add18fa51dbdfd61b80c904ce36315b2085f18
Reviewed-on: https://chromium-review.googlesource.com/1065062
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560137}
Reviewed-on: https://chromium-review.googlesource.com/1066089
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#661}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/render_process_host_impl.cc[diff]

[M-67] Make TouchOptimizedUi disabled by default

On M-67, this feature will be enabled only for tablet
devices.

BUG=842291

Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1
Reviewed-on: https://chromium-review.googlesource.com/1066803
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#660}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/base/material_design/material_design_controller.cc[diff]

Surface synchronization: Prevent LatencyInfo from accumulating across surfaces

The LatencyInfo vector in CompositorFrameMetadata can accumulate without bound
when allocating new surfaces. In order to track latency, we carry LatencyInfo
objects across surfaces. The new surface grabs the LatencyInfo objects from
the previous surface.

We used to check if the new Surface has too many LatencyInfos and if not,
grab all LatencyInfos from the previous Surface and we don't check again.
The previous Surface might have a large number of LatencyInfo objects
accumulated, and will accumulate further with every new surface allocated
for a given FrameSink.

The fix is to verify the LatencyInfo vector AFTER taking the items from
the previous surface.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6814fd3657b7b0a9e9d275013e661b176095e740
Bug: 834421, 672962
Reviewed-on: https://chromium-review.googlesource.com/1064810
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559668}(cherry picked from commit d1564e4226387f17c349e4d8a20cbd3ff8a08dc5)
Reviewed-on: https://chromium-review.googlesource.com/1067056
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#659}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/viz/service/frame_sinks/surface_synchronization_unittest.cc[diff]
• components/viz/service/surfaces/surface.cc[diff]
• components/viz/test/compositor_frame_helpers.cc[diff]
• components/viz/test/compositor_frame_helpers.h[diff]

ozone: Use modifiers for modeset buffers

Modesetting with an x-tiled buffer and then pageflipping to y-tiled
buffers on 3 different crtcs is allowed to fail and indeed does on
APL devices.

This CL makes sure the modeset buffers are allocated with the same
modifiers we allocate buffers for the buffer queue.

Bug: 819692
Test: pyro with 2 external monitors
Change-Id: I392cfecbf598b096947af55c793148933ee83025
Reviewed-on: https://chromium-review.googlesource.com/1054447
Commit-Queue: Daniele Castagna <[email protected]>
Reviewed-by: Kristian H. Kristensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557700}(cherry picked from commit 7745e347500159727d17a3c8c901621da7fb06de)
Reviewed-on: https://chromium-review.googlesource.com/1067032
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#658}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/ozone/platform/drm/gpu/drm_overlay_validator.cc[diff]
• ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc[diff]
• ui/ozone/platform/drm/gpu/drm_thread.cc[diff]
• ui/ozone/platform/drm/gpu/drm_window_unittest.cc[diff]
• ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc[diff]
• ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.h[diff]
• ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc[diff]
• ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h[diff]
• ui/ozone/platform/drm/gpu/scanout_buffer.h[diff]
• ui/ozone/platform/drm/gpu/screen_manager.cc[diff]
• ui/ozone/platform/drm/gpu/screen_manager_unittest.cc[diff]

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

Bug: 831167
Change-Id: Id681e95e7d6d5ff4e417ec4bf19adbf2f4d74656
Reviewed-on: https://chromium-review.googlesource.com/1065676
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#657}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc[diff]

Opus: Make sure HB_gain is not NaN

Crashdumps indicate that HB_gain can become NaN. When the gain is
applied to the input signal all samples become NaN, which causes the
crashes described in chromium:826914.

Changes:
- Check if HB_gain becomes NaN and then set it to 1 (no high-band
attenuation).

If this CL does not fix the issue it should be reverted.
If this CL does fix the issue we should investigate further.

[email protected]

(cherry picked from commit bb4347a94920a5e30e036633c9140c9b7471bff1)

Bug: chromium:826914
Change-Id: Idfcee178715180faf57a3d26918e941b99a09071
Reviewed-on: https://chromium-review.googlesource.com/1061499
Reviewed-by: Felicia Lim <[email protected]>
Reviewed-by: Henrik Andreasson <[email protected]>
Commit-Queue: Gustaf Ullberg <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559432}
Reviewed-on: https://chromium-review.googlesource.com/1065916
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#656}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/opus/README.chromium[diff]
• third_party/opus/src/src/opus_encoder.c[diff]

[ForeignObject] Don't allow <foreignObject> to composite in SPv1 mode.

This reduces the instance of broken content due to the fundamental
compositing bug.

Bug: 844538

[email protected]

(cherry picked from commit 1112dc78a874f228a78a7ab4d484e32e46f360f1)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie8841d3cccf58d4b7760366bb6537cfdb3c55d82
Reviewed-on: https://chromium-review.googlesource.com/1066403
Reviewed-by: Tien-Ren Chen <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560094}
Reviewed-on: https://chromium-review.googlesource.com/1067238
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#655}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited-expected.html[Added - diff]
• third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited.html[Added - diff]
• third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc[diff]

Incrementing VERSION to 67.0.3396.54

[email protected]

Change-Id: I3238a470c4729095319319ee86b0cf8a016c9c8e
Reviewed-on: https://chromium-review.googlesource.com/1067104
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#654}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Incrementing VERSION to 67.0.3396.53

[email protected]

Change-Id: Iea3229d34d88513e626ffd377fa6ac9e0b1a7bd1
Reviewed-on: https://chromium-review.googlesource.com/1067093
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#653}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Disable Google Analytics in the File Manager

This is a small fix that disables Google Analytics in the File Manager
by removing the call to resolve the callback. Calling the Deferred
object in any way causes an XHR request that causes the file picker to
turn white, so not calling it leaves the Filter unresolved which means
the Analytics server is never contacted (and hence the bug doesn't
happen).

Tbr: [email protected]
Bug: 842880,844280
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie525a88689985d2df1028fc1ba87f954fe158caf
Reviewed-on: https://chromium-review.googlesource.com/1065530
Commit-Queue: Sasha Morrissey <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559818}(cherry picked from commit 25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64)
Reviewed-on: https://chromium-review.googlesource.com/1065692
Reviewed-by: Sasha Morrissey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#652}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/file_manager/file_manager_jstest.cc[diff]
• ui/file_manager/file_manager/common/js/metrics.js[diff]

Incrementing VERSION to 67.0.3396.52

[email protected]

Change-Id: If158996c770412216a358d4b330ddbb84b25e7ba
Reviewed-on: https://chromium-review.googlesource.com/1066893
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#651}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

[Omnibox] fix to OmniboxTextView to improve CharTypedToRepaintLatency

This Cl potentially fixes a regression in CharTypedToRepaintLatency UMA
by restoring a shortcut for one line (non-wrapping) answers.

Change-Id: I93d264610f73dfab9db10c81c4ba198adab14c90
Reviewed-on: https://chromium-review.googlesource.com/1014412
Commit-Queue: Dave Schuyler <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#551220}(cherry picked from commit 50b5f88ff4598c87d34b11658ee62d9c5f4840e6)
Reviewed-on: https://chromium-review.googlesource.com/1066870
Reviewed-by: Dave Schuyler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#650}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/views/omnibox/omnibox_text_view.cc[diff]
• chrome/browser/ui/views/omnibox/omnibox_text_view.h[diff]

[M67 merge] Fix regression for intent picker UI

IntentPickerBubbleView is not saving the user's preference when they
decide to "Stay in Chrome" + "Remember my choice". This is a regression
that appeared in M67.

This CL specials case AppType::INVALID to handle saving user's
preference, previously proposed to add a new AppType::NATIVE_CHROME but
that sounds wrong given this enum lists non-cros app sources.

Besides that we need to make sure that the preference is communicated
to ARC via AddPreferredPackage and honored within ArcNavigationThrottle,
this can be achieved by adding a new enum PreferredPlatform that will
help DidLaunchPreferredArcApp to be more explicit.

(cherry picked from commit I383a926ae613ffe48f4dcd3a478ac124aefe4947)

Bug: 841971
Test: Build.
Change-Id: I405f2202b94e666768f9770e1e2edd0fbc9ec224
Reviewed-on: https://chromium-review.googlesource.com/1066597
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#649}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h[diff]
• chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc[diff]
• chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h[diff]

M67 merge: cros: Fix Shortcut Viewer labels for non-Qwerty layout

Currently for non-Qwerty keyboard layout, Shortcut Viewer returns
incorrect keys. This cl fixes the bug by creating a reverse mapping from
dom_code to {dom_key, key_code}.

[email protected],[email protected]

Bug: 841670
Test: manually.
Change-Id: Ib75bf84b34c0b03bf5501fab0586db8e750478bc
Reviewed-on: https://chromium-review.googlesource.com/1058080
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Kevin Schoedel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559200}(cherry picked from commit e5495df1a9e81b3f87bd652929d71feb379a7a8d)
Reviewed-on: https://chromium-review.googlesource.com/1066333
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#648}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc[diff]
• ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc[diff]
• ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.h[diff]
• ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc[diff]

specify the initial bounds for exo::ShellSurface

[email protected]

(cherry picked from commit 17c449d11bf1440e414bb66a6168ad599219034a)

Bug: b/77472684
Change-Id: I23a9d55eb778cc9e3e38babcf77efdbd5fcfb699
Reviewed-on: https://chromium-review.googlesource.com/1008402
Commit-Queue: Jun Mukai <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550696}
Reviewed-on: https://chromium-review.googlesource.com/1066671
Reviewed-by: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#647}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/exo/BUILD.gn[diff]
• components/exo/client_controlled_shell_surface.cc[diff]
• components/exo/client_controlled_shell_surface_unittest.cc[diff]
• components/exo/shell_surface_base.h[diff]

Chrome OS: Fix crash with auto connect notifier.

Also add checks to StubNotificationDisplayService test util class to
catch this in the future (checks match NotificationDisplayServiceImpl
production code).

[email protected]

(cherry picked from commit e03299eab652bf51b73541f8bd52178c913f6439)

Bug: 843692
Change-Id: Iebb64687dadf6eb50bffea80e946e8dd3336bac9
Reviewed-on: https://chromium-review.googlesource.com/1062653
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559307}
Reviewed-on: https://chromium-review.googlesource.com/1066499
Cr-Commit-Position: refs/branch-heads/3396@{#646}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/notifications/stub_notification_display_service.cc[diff]
• chrome/browser/ui/ash/auto_connect_notifier.cc[diff]

[ForeignObject] Hit test foreignObject PaintLayers during normal flow tree walk

Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1060333,
hit testing needs to look at content under <foreignObject> during normal-flow
painting.

This CL also includes a revert of some of the code in these CLs:
https://chromium-review.googlesource.com/c/chromium/src/+/974568
https://chromium-review.googlesource.com/c/chromium/src/+/1055788

Tests were left, as was code in GeometryMapper, which may have other applications
in optimizing hit testing elsewhere.

Bug:842668

[email protected]

(cherry picked from commit c183d574e98671f43fab8445c6904d28065a64a5)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iba38221cd47db4eb146b6c556ce76c9205785ea1
Reviewed-on: https://chromium-review.googlesource.com/1062960
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559752}
Reviewed-on: https://chromium-review.googlesource.com/1066455
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#645}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/layout/layout_object.cc[diff]
• third_party/blink/renderer/core/layout/layout_object.h[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_container.cc[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.cc[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.h[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_root.cc[diff]
• third_party/blink/renderer/core/layout/svg/svg_layout_support.cc[diff]
• third_party/blink/renderer/core/layout/svg/svg_layout_support.h[diff]
• third_party/blink/renderer/core/paint/paint_layer.cc[diff]
• third_party/blink/renderer/core/paint/paint_layer.h[diff]
• third_party/blink/renderer/core/paint/paint_layer_painter.cc[diff]

Re-land: [ForeignObject] Paint foreign objects during the foreground phase of normal-flow

This reverts commit c9bd830453b2fb8dd5ac8f1a99ca01e3ead52df8.

[email protected], [email protected]

(cherry picked from commit 9aad3d0744f18ac3179315266a44b82087860cc6)

Bug: 842668
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0a81342c4d545c41af1ce48d442c26dd89f34902
Reviewed-on: https://chromium-review.googlesource.com/1064732
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559702}
Reviewed-on: https://chromium-review.googlesource.com/1066452
Cr-Commit-Position: refs/branch-heads/3396@{#644}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/external/wpt/svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/svg/extensibility/foreignObject/foreign-object-paints-before-rect.html[Added - diff]
• third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/transform-foreign-object-expected.txt[diff]
• third_party/WebKit/LayoutTests/paint/invalidation/svg/transform-foreign-object-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/svg/zoom-foreignObject-expected.png[Added - diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.h[diff]
• third_party/blink/renderer/core/paint/README.md[diff]
• third_party/blink/renderer/core/paint/box_painter.cc[diff]
• third_party/blink/renderer/core/paint/paint_layer_painter.cc[diff]
• third_party/blink/renderer/core/paint/svg_container_painter.cc[diff]
• third_party/blink/renderer/core/paint/svg_foreign_object_painter.cc[diff]
• third_party/blink/renderer/core/paint/svg_foreign_object_painter.h[diff]
• third_party/blink/renderer/platform/graphics/paint/cull_rect.h[diff]

Remove preload from BottomSheetController

The preload functionality causes more problems than it solves. Content
that wants to delay loading until the sheet is opened can do so using
events provided by the BottomSheetObserver. This fixes a race
condition in EoC that would cause the sheet to peek before being
requested.

[email protected]

(cherry picked from commit 4cade243ff8535fcbb772e063a77468d6e18e37e)

Bug: 834923,843267
Change-Id: If5c35e22a502e42f6bc591784b4fb8343e713eff
Reviewed-on: https://chromium-review.googlesource.com/1060353
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559173}
Reviewed-on: https://chromium-review.googlesource.com/1066316
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#643}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsCoordinator.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsMediator.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetController.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java[diff]

Skip ScopedMakeCurrent if context IsCurrent().

ui::ScopedMakeCurrent can crash during stub destruction, so we skip
it if the (shared) context is already current.

Bug: 839605
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifaa73ecc84bb335b1e154f38139a41b6ee37cdb9
Reviewed-on: https://chromium-review.googlesource.com/1055879
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558033}(cherry picked from commit b137b49a6d891520bae4babd2a2faac2a482d702)
Reviewed-on: https://chromium-review.googlesource.com/1066152
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#642}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• media/gpu/android/surface_texture_gl_owner.cc[diff]

Return color to the microphone tab indicator.

BUG=843075
[email protected]

Change-Id: Iccb161d3d584cf434ae20b5ec91134b04996c999
Reviewed-on: https://chromium-review.googlesource.com/1062411
Reviewed-by: Sidney San Martín <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559268}(cherry picked from commit 6680bbcc64b208500b1fc8c21cb22aa8805ad686)
Reviewed-on: https://chromium-review.googlesource.com/1066114
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#641}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm[diff]
• chrome/browser/ui/cocoa/tabs/tab_view.h[diff]
• chrome/browser/ui/cocoa/tabs/tab_view.mm[diff]

Android: Fix OS's large font setting not being respected

[email protected]

(cherry picked from commit 79f2c11e512e01b101356b733afda3ef32fce5a7)

Bug: 834191
Change-Id: I3a0d79f4d281e426d41951080eb4551b646aab92
Reviewed-on: https://chromium-review.googlesource.com/1054731
Commit-Queue: agrieve <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557927}
Reviewed-on: https://chromium-review.googlesource.com/1066170
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#640}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java[diff]

[Modern] Fixes inconsistent suggestion view layouts for RTL

The delete button's size is always accounted for when
  laying out suggestion views

Adds padding to the omnibox text when voice search is disabled for RTL

See crbug link for photos.

[email protected]

Bug: 833342
Change-Id: I2b35be70d4296abf7eae318d5dccea4d0201c91f
Reviewed-on: https://chromium-review.googlesource.com/1054201
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Daniel Park <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559196}(cherry picked from commit be361679741d438622661563385216230b7db437)
Reviewed-on: https://chromium-review.googlesource.com/1066071
Cr-Commit-Position: refs/branch-heads/3396@{#639}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/res/layout/new_tab_page_layout.xml[diff]
• chrome/android/java/res/values/dimens.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java[diff]

Use ListPopupWindow when Android version < N

There are devices that have problem with the new implementation of
DropdownPopupWindow on Android M. At this point, it looks to be too
late to find a proper solution that we can merge back to 67. Therefore,
I change the condition so that all devices < N use the old
implementation of DropdownPopupWindow based on ListPopupWindow.

Bug: 838736
Change-Id: Idfe1c00f609e1a911e09381401eff344131e28d0
Reviewed-on: https://chromium-review.googlesource.com/1055477
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558420}(cherry picked from commit c2f78d17249bb8fe0b8ec074379c77eed10975a3)
Reviewed-on: https://chromium-review.googlesource.com/1066070
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#638}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java[diff]

[Custom Tabs] Handle InflateException for RemoteViews bottom bar.

This follows the best practice outlined in the whitepaper at
https://youtu.be/lrHJhKEtQEI.

Bug: 839648
Change-Id: Ic578859515ae2e1fdd13bf7966c544fe2490ffcf
Reviewed-on: https://chromium-review.googlesource.com/1051244
Commit-Queue: Bernhard Bauer <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557836}(cherry picked from commit 3c635e89030dc460a7fe03766eb968dfe4ca66fa)
Reviewed-on: https://chromium-review.googlesource.com/1065891
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#637}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java[diff]

[M67] Handle null FILE* in CompressAndSaveBitmap

This might be causing the crashes seen in the associated bug. In any
case, it is a good idea to handle the failure, because the reasons why
that FILE* can be null are beyond Chrome's control.

Bug: 838639
Change-Id: I700266840c1447c0b999aa91a361bfba3ff2710b
Reviewed-on: https://chromium-review.googlesource.com/1060057
Commit-Queue: Vaclav Brozek <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559194}(cherry picked from commit 6abe484c9ba102324b9d92f27dfeb3a7e05034bc)
Reviewed-on: https://chromium-review.googlesource.com/1065930
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#636}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/web_contents/web_contents_android.cc[diff]

Fix failing test in ModuleEventSinkImpl

Tbr: [email protected]
Bug: 839572
Change-Id: Iaf2a127be786efa2ce195f5b952aaecd0f1a9e74
Reviewed-on: https://chromium-review.googlesource.com/1043155
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555891}(cherry picked from commit f28e1c437fc0236bba7fd3336e57cac1bdc01748)
Reviewed-on: https://chromium-review.googlesource.com/1065570
Cr-Commit-Position: refs/branch-heads/3396@{#635}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc[diff]

Retrieve module information on a background task in ModuleEventSinkImpl

Retrieving this information requires IPC to the remote process, which
is blocking and thus must not be done on the UI thread.

But the ModuleEventSinkImpl instance must still live on the UI thread,
because thats where the RenderProcessHost instance lives. The
RenderProcessHost must be accessed to get the handle to the remote
process inside the ModuleEventSinkImpl::Create() factory function.

To make the process handle available from the background task, it is
now duplicated and passed to the task via the PostTaskWithTraits()
call.

This is a cherry-pick of
https://chromium-review.googlesource.com/c/chromium/src/+/1058339
on branch 3396.

Tbr: [email protected]
Bug: 832286
Change-Id: Ia56499dfec96cfb0cc32863233b3265133a31034
Reviewed-on: https://chromium-review.googlesource.com/1065251
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#634}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chrome_browser_main_win.cc[diff]
• chrome/browser/chrome_content_browser_client.cc[diff]
• chrome/browser/conflicts/module_event_sink_impl_win.cc[diff]
• chrome/browser/conflicts/module_event_sink_impl_win.h[diff]
• chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc[diff]

[Merge to M67] Reland "Revive WorkerThreadableLoader for sync XHR again"

[email protected]

This reverts commit 4b00991ee27817b60b2a142261bd1d89ca253615.

Reason for revert: It is easy to fix the test failure.

Original change's description:
> Revert "Revive WorkerThreadableLoader for sync XHR again"
>
> This reverts commit 14b1861dc42443535a48b97c09126f1f59cd4088.
>
> Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html:
>
> FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n"
>
> Original change's description:
> > Revive WorkerThreadableLoader for sync XHR again
> >
> > The cl "5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c" which made ThreadableLoader
> > use DocumentThreadableLoader for sync loading from worker thread had broken
> > existing site. https://crbug.com/840348
> >
> > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't
> > support CORS after redirect.
> >
> > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously()
> > support it. So This CL revives WorkerThreadableLoader for sync XHR.
> >
> > Bug: 840348, 706331
> > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537
> > Reviewed-on: https://chromium-review.googlesource.com/1060793
> > Commit-Queue: Tsuyoshi Horo <[email protected]>
> > Reviewed-by: Kinuko Yasuda <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#559023}
>
> [email protected],[email protected]
>
> Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 840348, 706331
> Reviewed-on: https://chromium-review.googlesource.com/1061894
> Reviewed-by: Łukasz Anforowicz <[email protected]>
> Commit-Queue: Łukasz Anforowicz <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#559101}

[email protected],[email protected],[email protected]

(cherry picked from commit b1e172c8d0e85286f9025f291c3fc3e719bc30ff)

Change-Id: I6d078b4124defec2f9d7514b95eed00ff6f685f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 840348, 706331
Reviewed-on: https://chromium-review.googlesource.com/1061435
Commit-Queue: Tsuyoshi Horo <[email protected]>
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559107}
Reviewed-on: https://chromium-review.googlesource.com/1064652
Cr-Commit-Position: refs/branch-heads/3396@{#633}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt[diff]
• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt[diff]
• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/sync-cors-after-redirect-on-worker-worker.js[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html[Added - diff]
• third_party/blink/renderer/core/loader/threadable_loader.cc[diff]

Incrementing VERSION to 67.0.3396.51

[email protected]

Change-Id: Id83e37970a42807dbda199bb23d2c5ca729daa94
Reviewed-on: https://chromium-review.googlesource.com/1064920
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#632}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Merge M67: Update Flash plugin metadata versions to latest version.

https://helpx.adobe.com/security/products/flash-player/apsb18-16.html

BUG=412078
[email protected]

(cherry picked from commit 2e16f1a05975a96e4e19ec97374bb4a7b0c0c8e0)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d26a113f5d32e8fbbaab006b160065146954f4e
Reviewed-on: https://chromium-review.googlesource.com/1065075
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559710}
Reviewed-on: https://chromium-review.googlesource.com/1064474
Cr-Commit-Position: refs/branch-heads/3396@{#631}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/resources/plugin_metadata/plugins_linux.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_mac.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_win.json[diff]

[Merge M67] app_launcher: Prevent empty folders in app list.

Fix issue when in some cases (usually reproducible on next user login)
folders are rendered blank.

[email protected]

(cherry picked from commit 65c26bd27a6315ed72e179b8a338f35572cf440c)

Test: Locally
Bug: 838750
Change-Id: I9249204c9416ad4a27d1754c308ffb5aa5a85453
Reviewed-on: https://chromium-review.googlesource.com/1045518
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556260}
Reviewed-on: https://chromium-review.googlesource.com/1064893
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#630}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/app_list/app_list_controller_impl.cc[diff]

Set the Incompatible Applications Help URL via field trial param

Bug: 717696
Change-Id: I454fe19234a10f0665399cc5f3cae0d4abe1d471
Reviewed-on: https://chromium-review.googlesource.com/1011408
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550777}(cherry picked from commit f456bf440c225e8452675700265c5079de491a11)
Reviewed-on: https://chromium-review.googlesource.com/1065151
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#629}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc[diff]

Fixed normalization of certificate subject for in-file certificates

Bug: 819793
Change-Id: Ic42c128ba5f30208332f17100d24a61ee320c3db
Reviewed-on: https://chromium-review.googlesource.com/1012190
Reviewed-by: Chris Hamilton <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550677}(cherry picked from commit 09b6721be468564b084ce2647de8082c1cc88c26)
Reviewed-on: https://chromium-review.googlesource.com/1065150
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#628}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/conflicts/module_info_util_win.cc[diff]
• chrome/browser/conflicts/module_info_util_win.h[diff]
• chrome/browser/conflicts/module_info_util_win_unittest.cc[diff]

[Merge to M67]Focus on power button menu when it is invoked.

[email protected]

Focus on power button menu instead of "Power off" item when menu is opened.
This is used to make sure PowerButtonMenuView can still handle the key events
when menu is opened. Since we still need ESCAPE to dismiss the menu and TAB or
direction keys to navigate between menu items.

(cherry picked from commit b013458806a073a78d15d153763f2655daea91df)

Bug: 842336
Change-Id: I4d951e6d520dd28e88362c85e25ef156a1252f30
Reviewed-on: https://chromium-review.googlesource.com/1056294
Commit-Queue: Min Chen <[email protected]>
Reviewed-by: Qiang Xu <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558493}
Reviewed-on: https://chromium-review.googlesource.com/1064547
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#627}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/system/power/power_button_controller.cc[diff]
• ash/system/power/power_button_controller_unittest.cc[diff]
• ash/system/power/power_button_menu_view.cc[diff]

Fixing getBottomBrowserControlsHeight() typo

I introduced a typo when landing:
https://chromium-review.googlesource.com/c/chromium/src/+/1041218.
This CL fixes that typo.

Bug: 840398
Change-Id: I69d638e7e0e3284518dd198bb2ad455417c7cc2a
Reviewed-on: https://chromium-review.googlesource.com/1048171
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556875}(cherry picked from commit 535ef248ffed6b0f89b97a9974166a04fc1ed015)
Reviewed-on: https://chromium-review.googlesource.com/1063065
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#626}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java[diff]

Merge "Correct extension API permission ID order for kEnterpriseReportingPrivate" to 67.

Change the order to match the enum.xml.

[email protected]

(cherry picked from commit 10b0efd3ec717635143eb07ef6bbb39655e189a5)

Bug: 843141
Change-Id: Ib8bf9be16aaf7a5d1f9369762bd966fb8c06b5a8
Reviewed-on: https://chromium-review.googlesource.com/1059579
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558733}
Reviewed-on: https://chromium-review.googlesource.com/1064722
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#625}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• extensions/common/permissions/api_permission.h[diff]

Make download.default_directory read only in settingsPrivate

[email protected]

(cherry picked from commit 4a95aa30d879ea1a8a4ad34f6557c38bc222c542)

Bug: 836362
Change-Id: I677cffed597ce6dc50247916055bd3182d4a206e
Reviewed-on: https://chromium-review.googlesource.com/1041567
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558802}
Reviewed-on: https://chromium-review.googlesource.com/1064743
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#624}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/extensions/api/settings_private/prefs_util.cc[diff]
• chrome/test/data/extensions/api_test/settings_private/test.js[diff]

[tools/perf] Option --output-deps outputs deps to a json file

Bug: 834659
Change-Id: I5df0bc9b923c7a780de896f71cc68443902de12b
Reviewed-on: https://chromium-review.googlesource.com/1031991
Reviewed-by: Ned Nguyen <[email protected]>
Commit-Queue: Vovo Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#554325}(cherry picked from commit e8323033c5ff5755abe6e45ba05060c5a5d90111)
Reviewed-on: https://chromium-review.googlesource.com/1061653
Cr-Commit-Position: refs/branch-heads/3396@{#623}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• tools/perf/fetch_benchmark_deps.py[diff]
• tools/perf/fetch_benchmark_deps_unittest.py[diff]

[Media Controls] Only act as audio element when controls are enabled

This CL prevents video tags from acting as audio tags when the controls
are not enabled. This fixes a bug where video tags with only audio were
showing the audio controls background despite the controls being
hidden.

Bug: 843101
Change-Id: Ic7bb98b198a6ec7c497d233d40d673d7cfa7e44e
Reviewed-on: https://chromium-review.googlesource.com/1062225
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559218}(cherry picked from commit 00c3cffbbeff11db315ac4d74bb274558a9f26d6)
Reviewed-on: https://chromium-review.googlesource.com/1064472
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#622}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/media/controls/video-does-not-act-as-audio-tag-with-controls-hidden.html[Added - diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.cc[diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.h[diff]

Fix a crash due to NullPointerException

This NullPointerException should be really rare. There is a fix on
the way, for now we just catch the exception to prevent crash.

[email protected]

(cherry picked from commit fafa35cb9b4463b6cac89a61990b8e388488e8eb)

Bug: 842059
Change-Id: Ie130d887d303e7f08504b8c783ae43b87ed31ccf
Reviewed-on: https://chromium-review.googlesource.com/1057427
Reviewed-by: Amirhossein Simjour <[email protected]>
Commit-Queue: Biao She <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558398}
Reviewed-on: https://chromium-review.googlesource.com/1063993
Reviewed-by: Biao She <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#621}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java[diff]

ReadableStreamBytesConsumer should check read results

ReadableStreamBytesConsumer expected that the results from
ReadableStreamReaderDefaultRead should be Promise<Object> because that
is provided from ReadableStream provided by blink, but it's possible to
inject arbitrary values with the promise assimilation.

This CL adds additional checks for such injection.

[email protected]

(cherry picked from commit 7712d138374a92c4d2f3b05cdc86d1a7a523702b)

Bug: 840320
Change-Id: I7b3c6a8bfcf563dd860b133ff0295dd7a5d5fea5
Reviewed-on: https://chromium-review.googlesource.com/1049413
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556751}
Reviewed-on: https://chromium-review.googlesource.com/1062992
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#620}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-stream-with-broken-then.any.js[Added - diff]
• third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer.cc[diff]

Incrementing VERSION to 67.0.3396.50

[email protected]

Change-Id: I703ad5a8e04655c2fccfa8cf1479d208d8b059a2
Reviewed-on: https://chromium-review.googlesource.com/1062814
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#619}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

[Merge to M67]Chrome OS bluetooth filtering

1. For LE devices check the service UUID to determine if it supports HID
or security key, and whitelist those who does.
2. For classic and dual mode devices, whitelist devices which have
non-empty name because device could have an unknown or even known type and
still also provide audio/HID functionality.

(cherry picked from commit 81c120ab94da8c089f9c44d81d72065f06f68868)

Bug: 831218
TBR: [email protected], [email protected]
Change-Id: Id7e5a8ae418c45212773fa846555721ea88cb18a
Reviewed-on: https://chromium-review.googlesource.com/1033965
Reviewed-by: Rahul Chaturvedi <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Xiaoyin Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557390}
Reviewed-on: https://chromium-review.googlesource.com/1063109
Reviewed-by: Xiaoyin Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#618}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/system/bluetooth/tray_bluetooth_helper_unittest.cc[diff]
• device/bluetooth/chromeos/bluetooth_utils.cc[diff]

Fix crash due to invalid Window entry on Mac

A few users have invalid Window entries in TabRestoreServiceHelper when
deleting history. These entries are created when individual tabs are
restored from a closed window. This is only possible on Mac.
It is fixed by adjusting the selected_tab_index after a deletion.

Bug: 840508
Change-Id: I429d117df8cf06ee1613220112901590f129d529
Reviewed-on: https://chromium-review.googlesource.com/1049976
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558744}(cherry picked from commit 2f7f86fca7f7c06fa0a64f236d79f258bd33c954)
Reviewed-on: https://chromium-review.googlesource.com/1062845
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#617}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/sessions/tab_restore_browsertest.cc[diff]
• components/sessions/core/tab_restore_service_helper.cc[diff]

Correctly update notification delegate for Chrome OS mojo notifications.

When a notification was updated (same ID, new properties), the
appearance --- title, image, etc. --- was updated, but the old delegate
wasn't replaced with the new delegate. Fix that and add a test.

[email protected]

(cherry picked from commit 070b773c468f3aeed645334f53850175512e8b08)

Bug: 840105
Change-Id: I83fd7453f13c41adf96a417e3945a85933a9e1a3
Reviewed-on: https://chromium-review.googlesource.com/1056091
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558315}
Reviewed-on: https://chromium-review.googlesource.com/1062651
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#616}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/notifications/chrome_ash_message_center_client.cc[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos.cc[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos_unittest.cc[Added - diff]
• chrome/test/BUILD.gn[diff]

M67: Printing: Read the color setting from the system dialog on Windows.

BUG=843212
[email protected]

(cherry picked from commit 0c4f392def5d8c7c77cdf8a9c20385be3ef2f4f9)

Change-Id: Iab38833fabfe1c6729c76419d50e39cfe7eb098a
Reviewed-on: https://chromium-review.googlesource.com/1060384
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558875}
Reviewed-on: https://chromium-review.googlesource.com/1062187
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#615}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• printing/print_settings_initializer_win.cc[diff]
• printing/printing_context_win_unittest.cc[diff]

Refresh Rect bounds when WindowCoordinate < 0

When the View is partially outside of the Window, the rectangle
bounds should be recalculated with the assumption that the View
is started from the edges.
This will make sure that Autofill popup shows up on top/bottom
of the correct input field, when input fields doesn't fit inside
the Window.

Bug: 828759
Change-Id: I253fc9febe93e90058f95923a18cdfe5363d2186
Reviewed-on: https://chromium-review.googlesource.com/1044529
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557953}(cherry picked from commit 4abbf57b822cd7ca226fda78c510b9e435e3bc90)
Reviewed-on: https://chromium-review.googlesource.com/1061985
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#614}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/android/java/src/org/chromium/ui/widget/ViewRectProvider.java[diff]

[tools/perf] Add option --output-deps to output deps to stdout

The output is used by CrOS autotest telemetry_runner to upload
dependencies to DUT.

Bug: 834659
Change-Id: I5845fa293e07b35bdcb27030da7fc87ca5b61505
Reviewed-on: https://chromium-review.googlesource.com/1025612
Commit-Queue: Achuith Bhandarkar <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#553559}(cherry picked from commit e6b675d6797927ddcf9378edd53f55d5bd48d591)
Reviewed-on: https://chromium-review.googlesource.com/1059067
Cr-Commit-Position: refs/branch-heads/3396@{#613}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• tools/perf/fetch_benchmark_deps.py[diff]
• tools/perf/fetch_benchmark_deps_unittest.py[diff]

Incrementing VERSION to 67.0.3396.49

[email protected]

Change-Id: Ia8578c6d9cc4d1298dd2df039d59098826b0a92e
Reviewed-on: https://chromium-review.googlesource.com/1060309
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#612}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Stop progress indicator if download is replaced.

[email protected]

(cherry picked from commit 44d4d2b99af0b76adc1c9678b70fc3f89805727e)

Bug: 842781
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I001fbaf3d100e173252aacde7b3cc4f28e28fa31
Reviewed-on: https://chromium-review.googlesource.com/1058378
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558699}
Reviewed-on: https://chromium-review.googlesource.com/1060079
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#611}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/chrome/browser/download/download_manager_tab_helper.mm[diff]
• ios/chrome/browser/download/download_manager_tab_helper_unittest.mm[diff]

Disable Display Zoom by default on M67

This patch disables display zoom by default on M67 to find a better user
experience during the transition and also to prevent the breaking of any
kiosk stations.

Bug: 839458
Change-Id: I367f27d7904d380a295d9435077ab379db25bb94
Component: Display zoom, flag
Reviewed-on: https://chromium-review.googlesource.com/1056215
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#610}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/display/display_switches.cc[diff]

Crash on unexpected URL change.

[email protected]

(cherry picked from commit ba1815a412382038e41adc189134fcb1b75784aa)

Bug: 841105
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4471a98cdef13e54b790ebcd565d59c67dba8bfd
Reviewed-on: https://chromium-review.googlesource.com/1054196
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558760}
Reviewed-on: https://chromium-review.googlesource.com/1060377
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#609}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/web/features.mm[diff]
• ios/web/public/features.h[diff]
• ios/web/web_state/ui/crw_web_controller.mm[diff]

Incrementing VERSION to 67.0.3396.48

[email protected]

Change-Id: I1b489dcd64c23d34d317616326f8dd2e8ca837d8
Reviewed-on: https://chromium-review.googlesource.com/1060259
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#608}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Revert: [RLS] Ignore fixed when applying root scroll offset for interest rect

This patch reverts [1] because we have a more general solution in [2].
In addition, through manual code inspection, we found [1] has a bug for
OOPIF because mapping to nullptr goes through remote frames whereas we
only intend to map to the local root. The test from [1] has not been
reverted.

[1] https://chromium.googlesource.com/chromium/src/+/cfebac612b10fdf961dca9df2bb28581577a612a
[2] https://chromium.googlesource.com/chromium/src/+/edc066c316b24fb3dea226ae6c1c5c1fdee062c3

[email protected]

(cherry picked from commit 82613a3b2625b939526277ac44e2e3bd20cdd424)

Bug: 838111
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0810c0eacb492ac413d31c041e97fce6ad23932b
Reviewed-on: https://chromium-review.googlesource.com/1058673
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558587}
Reviewed-on: https://chromium-review.googlesource.com/1060354
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#607}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/layout/layout_view.cc[diff]
• third_party/blink/renderer/core/layout/layout_view.h[diff]
• third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc[diff]

Updating XTBs based on .GRDs from branch 3396

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8c441dd8fcf2bfa0f53d1ca8266e824778bb0426
Reviewed-on: https://chromium-review.googlesource.com/1060274
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#606}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/strings/ash_strings_bn.xtb[diff]
• ash/strings/ash_strings_pt-BR.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_zh-CN.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bn.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb[diff]
• components/policy/resources/policy_templates_bn.xtb[diff]
• components/policy/resources/policy_templates_mr.xtb[diff]
• components/strings/components_strings_bn.xtb[diff]
• components/strings/components_strings_kn.xtb[diff]
• content/app/strings/translations/content_strings_bn.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_bn.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_mr.xtb[diff]
• remoting/resources/remoting_strings_bn.xtb[diff]
• ui/accessibility/extensions/strings/accessibility_extensions_strings_bn.xtb[diff]
• ui/strings/translations/ui_strings_pt-BR.xtb[diff]

[EoC] Use full favicon URL instead of encrypted docid

BUG=833873

Original-Change-Id: I3f00d9258e7b2167c0cadaa41fed2506409b9496
Original-Reviewed-on: https://chromium-review.googlesource.com/1053794
Original-Reviewed-by: Nicolas Zea <[email protected]>
Original-Commit-Queue: Theresa <[email protected]>
Original-Cr-Commit-Position: refs/heads/master@{#557631}
Change-Id: I88d6cb3b98cbf9881c10152ece25dbf8b09bfec4
Reviewed-on: https://chromium-review.googlesource.com/1060114
Reviewed-by: Nicolas Zea <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#605}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/ntp_snippets/contextual/cluster.cc[diff]
• components/ntp_snippets/contextual/contextual_content_suggestions_service_proxy.cc[diff]
• components/ntp_snippets/contextual/contextual_content_suggestions_service_proxy.h[diff]
• components/ntp_snippets/contextual/contextual_suggestion.cc[diff]
• components/ntp_snippets/contextual/contextual_suggestion.h[diff]
• components/ntp_snippets/contextual/contextual_suggestions_fetch.cc[diff]
• components/ntp_snippets/contextual/proto/get_pivots_response.proto[diff]

Apply fixed-position scroll offset if the containing block is ancestor.

An earlier patch (commit e931d2aecb4d72946962e57e7e1586668071b504)
changed code in MapToVisualRectInAncestorSpace to omit fixed-position
scroll in cases where the containing block was the LayoutView and
a counter-scroll would have been applied in the LayoutView anyway.
This fixed a bug in which a clip was applied in-between in the
wrong space.

The CL introduced a bug, however, in the case when the LayoutView
was the desired ancestor passed to MapToVisualRectInAncestorSpace.
In this case we should apply the counter scroll in LayoutView, because
the results of MapToVisualRectInAncestorSpace are in the unscrolled
space of the LayoutView.

Note that
LayoutBox::MapToVisualRectInAncestorSpace already has code to
skip fixed-position scroll and clip if container == ancestor,
independent of the above commit.

Bug:841194

[email protected]

(cherry picked from commit edc066c316b24fb3dea226ae6c1c5c1fdee062c3)

Change-Id: Ia05894dd94bdb3b0503cbb155728b0ef074b0227
Reviewed-on: https://chromium-review.googlesource.com/1058039
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558473}
Reviewed-on: https://chromium-review.googlesource.com/1060030
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#604}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/layout/layout_box.cc[diff]
• third_party/blink/renderer/core/layout/visual_rect_mapping_test.cc[diff]

Only update remote frame viewport intersection when paint is clean.

Cherry-picked from:

https://chromium-review.googlesource.com/1056491

BUG=842368
[email protected]

Change-Id: Iaa8f60bc76d98bf1e12a21f0179f8243a0f0cff7
Reviewed-on: https://chromium-review.googlesource.com/1059934
Reviewed-by: Stefan Zager <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#603}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/frame/remote_frame_view.cc[diff]

Revert "Views: Turn on InkDropMasks for Windows."

This reverts commit a6de7e84dde8bd13f511bb5c09acb5a0eb8a747a.

Reason for revert: Makes extension popups blurry with non-integral
scale factors.

Bug: 824963

Original change's description:
> Views: Turn on InkDropMasks for Windows.
>
> It seems to "just work".
>
> Tested on:
>  - Windows 10
>  - Windows 10 with --disable-gpu
>  - Windows 7
>  - Windows 7 Classic mode (Aero disabled)
>
> Bug: 713359
> Change-Id: I04466aab7e978ad51e5e579488e29789cda9ab72
> Reviewed-on: https://chromium-review.googlesource.com/961552
> Commit-Queue: Tommy Li <[email protected]>
> Reviewed-by: Mohsen Izadi <[email protected]>
> Reviewed-by: Trent Apted <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#543785}

[email protected],[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 713359
Change-Id: I854e2315e5cd73c7aca67f0d7d226cb67102ff32
Reviewed-on: https://chromium-review.googlesource.com/1058289
Commit-Queue: Trent Apted <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558526}(cherry picked from commit 13549a45248294edd44aaac6000ffd74887e1e94)
Reviewed-on: https://chromium-review.googlesource.com/1059736
Cr-Commit-Position: refs/branch-heads/3396@{#602}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/views/animation/ink_drop_host_view.cc[diff]
• ui/views/controls/native/native_view_host_aura.cc[diff]

latency-info: Add a speculative fix.

Add a speculative fix in SurfaceAggregator::Aggregate() to make sure it
doesn't accumulate too many LatencyInfo objects.

BUG=834421

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifd41d901050a954279b642cab972ca6ec6d560e2
Reviewed-on: https://chromium-review.googlesource.com/1053793
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Fady Samuel <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557992}(cherry picked from commit 92e0446435896425805d05af8a91072263223d68)
Reviewed-on: https://chromium-review.googlesource.com/1058288
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#601}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/viz/service/display/surface_aggregator.cc[diff]

Incrementing VERSION to 67.0.3396.47

[email protected]

Change-Id: Iebea1d978ed2d5029df01f5376f5e8b515e6ed4e
Reviewed-on: https://chromium-review.googlesource.com/1058767
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#600}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Store magnification scale in pref

- Store magnification scale in pref when it's changed by touch
  operation.
- This fixes an issue that magnification scale changed by touch
  operation is not available from chrome.settingsPrivate API.

Bug: 832587
Test: none
Change-Id: I20af159ce49bf081a4cbf5919d9b5f34484b7a7a
Reviewed-on: https://chromium-review.googlesource.com/1021003
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#552624}(cherry picked from commit 985417b8d1af4c3a48c606a457009c5cfd2fb14a)
Reviewed-on: https://chromium-review.googlesource.com/1058647
Reviewed-by: Yuki Awano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#599}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/magnifier/magnification_controller.cc[diff]

[ForeignObject PaintLayer] Fix <foreignObject> hit testing under simple SVG clip-path.

Now that <foreignObject> gets a PaintLayer, hit testing no longer works correctly
in the presence of a non-rectangular SVG clip path. This is because SVG children elements
which are not <foreignObject> cannot have a PaintLayer, and PaintLayer is the only way
hit testing currently knows how to account for clip-path.

Fix this for "simple" clip-paths by adding a method to perform hit test clipping
on the clip paint property tree. It works by checking all clips and clip-paths
stored on the clip paint property tree between the local and ancestor points
(in this use-case the ancestor is the containing PaintLayer), applying transforms
as necessary.

Non-"simple" clip paths (defined as SVG clip paths which have more than 42 edges
or having text) are not fixed by this CL. The former condition could be handled in the
future by adding a ClipPathForHitTesting to ClipPaintPropertyNode which stores the
clip-path beyond 42 edges.

Bug:833076

[email protected]

(cherry picked from commit e718b946295929125f8c3283f9c94338e1eb4224)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iabbce97d412fe38a4b775739517d28628ef67964
Reviewed-on: https://chromium-review.googlesource.com/1055788
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558049}
Reviewed-on: https://chromium-review.googlesource.com/1058371
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#598}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object_test.cc[diff]
• third_party/blink/renderer/core/paint/paint_layer.cc[diff]
• third_party/blink/renderer/platform/graphics/paint/geometry_mapper.cc[diff]
• third_party/blink/renderer/platform/graphics/paint/geometry_mapper.h[diff]
• third_party/blink/renderer/platform/graphics/paint/geometry_mapper_test.cc[diff]

Check IsDetached() in ImageDocumentParser::AppendBytes()

It is suspicious that GetDocument() can be nullptr in
ImageDocumentParser::AppendBytes().
This CL adds an IsDetached() check there, just like
DecodedDataDocumentParser::AppendBytes() does.

Bug: 826198
Change-Id: I297fe5bbe609a380ce8a175529d1216a88d1c1ee
Reviewed-on: https://chromium-review.googlesource.com/1050697
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557244}(cherry picked from commit 6ed800438a7d678b14ed09b983d7f439031b8896)
Reviewed-on: https://chromium-review.googlesource.com/1058287
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#597}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/html/image_document.cc[diff]

Updating XTBs based on .GRDs from branch 3396

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7aaff6fd5988789a18347f0e53c741d94dc2737a
Reviewed-on: https://chromium-review.googlesource.com/1058171
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#596}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/strings/ash_strings_ca.xtb[diff]
• ash/strings/ash_strings_mr.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_hi.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_pt-BR.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_mr.xtb[diff]
• components/policy/resources/policy_templates_mr.xtb[diff]
• ios/chrome/app/strings/resources/ios_chromium_strings_mr.xtb[diff]
• ios/chrome/app/strings/resources/ios_google_chrome_strings_mr.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_mr.xtb[diff]
• remoting/resources/remoting_strings_hi.xtb[diff]

Revert child allocation in M67.

This reverts commit 760b946849da9bd7a638418a762712f678a2e017.

In M67 we hit a bug where a child allocation might not be
presented unless it also has a resize event. This reverts
child allocation and returns to a well-tested state.

Bug: 840036
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I17546bb8ccd01318be6e88aa69bbeef3d3ade56a
Reviewed-on: https://chromium-review.googlesource.com/1058124
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#595}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/viz/common/surfaces/child_local_surface_id_allocator.cc[diff]
• components/viz/common/surfaces/parent_local_surface_id_allocator.cc[diff]
• content/browser/frame_host/render_widget_host_view_guest.cc[diff]
• content/browser/frame_host/render_widget_host_view_guest.h[diff]
• content/browser/renderer_host/browser_compositor_view_mac.h[diff]
• content/browser/renderer_host/browser_compositor_view_mac.mm[diff]
• content/browser/renderer_host/render_widget_host_delegate.h[diff]
• content/browser/renderer_host/render_widget_host_impl.cc[diff]
• content/browser/renderer_host/render_widget_host_impl.h[diff]
• content/browser/renderer_host/render_widget_host_view_aura.cc[diff]
• content/browser/renderer_host/render_widget_host_view_aura.h[diff]
• content/browser/renderer_host/render_widget_host_view_aura_unittest.cc[diff]
• content/browser/renderer_host/render_widget_host_view_base.cc[diff]
• content/browser/renderer_host/render_widget_host_view_base.h[diff]
• content/browser/renderer_host/render_widget_host_view_child_frame.cc[diff]
• content/browser/renderer_host/render_widget_host_view_child_frame.h[diff]
• content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc[diff]
• content/browser/renderer_host/render_widget_host_view_mac.h[diff]
• content/browser/renderer_host/render_widget_host_view_mac.mm[diff]
• content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc[diff]
• content/browser/web_contents/web_contents_impl.cc[diff]
• content/browser/web_contents/web_contents_impl.h[diff]
• content/common/view_messages.h[diff]
• content/renderer/render_view_impl.cc[diff]
• content/renderer/render_widget.cc[diff]
• content/renderer/render_widget.h[diff]
• content/renderer/render_widget_unittest.cc[diff]
• content/test/mock_render_widget_host_delegate.cc[diff]
• content/test/mock_render_widget_host_delegate.h[diff]
• ui/aura/local/window_port_local.cc[diff]
• ui/aura/local/window_port_local.h[diff]
• ui/aura/mus/window_port_mus.cc[diff]
• ui/aura/mus/window_port_mus.h[diff]
• ui/aura/window.cc[diff]
• ui/aura/window.h[diff]
• ui/aura/window_port.h[diff]
• ui/aura/window_port_for_shutdown.cc[diff]
• ui/aura/window_port_for_shutdown.h[diff]

Fix text selection inside web view

With the #context-menu-element-post-message flag enabled, the requestID
is returned as part of the response even if no image or link element was
found under the user’s touch. The request ID needs to be removed from
the response dictionary because the CRWContextMenuController assumes an
element was found if the dictionary is not empty.

[email protected]

(cherry picked from commit 328a95790a39c57abfa780782f5d7474c540795d)

Bug: 838611
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie800f113f1f88649a1164e5f017683bc510c10da
Reviewed-on: https://chromium-review.googlesource.com/1040674
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556230}
Reviewed-on: https://chromium-review.googlesource.com/1058040
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#594}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/chrome/browser/context_menu/context_menu_egtest.mm[diff]
• ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm[diff]
• ios/chrome/browser/ui/history/history_ui_egtest.mm[diff]
• ios/chrome/browser/ui/toolbar/toolbar_egtest.mm[diff]
• ios/chrome/test/earl_grey/chrome_matchers.h[diff]
• ios/chrome/test/earl_grey/chrome_matchers.mm[diff]
• ios/web/web_state/context_menu_params_utils.h[diff]
• ios/web/web_state/context_menu_params_utils.mm[diff]
• ios/web/web_state/context_menu_params_utils_unittest.mm[diff]
• ios/web/web_state/ui/crw_context_menu_controller.mm[diff]

Autoplay: Force enable on desktop for Web Audio

Force enable on desktop for Web Audio.

BUG=841933

Change-Id: I29a5257973c777c84c046576518e970d7cb0d2ba
Reviewed-on: https://chromium-review.googlesource.com/1054433
Commit-Queue: Becca Hughes <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Raymond Toy <[email protected]>
Cr-Original-Cr-Commit-Position: refs/heads/master@{#557945}
Cr-Commit-Position: refs/branch-heads/3396@{#593}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/TestExpectations[diff]
• third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/webaudio-iframe-no-gesture.html[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/webaudio-iframe-with-gesture.html[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/media/autoplay/webaudio-autoplay-iframe-no-gesture.html[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/media/autoplay/webaudio-autoplay-iframe-with-gesture.html[Added - diff]
• third_party/WebKit/LayoutTests/media/autoplay/webaudio-autoplay-no-gesture.html[Added - diff]
• third_party/blink/renderer/modules/webaudio/base_audio_context.cc[diff]

[Merge to M-67] Fix a crash in tablet mode web prefs overriding

A navigation entry may have not been committed yet for
the page. We will exclude it from tablet mode web prefs
overriding.

[email protected]
BUG=841461

(cherry picked from commit f2788a37aa5ab205204f25e4f3e3fb6b7659c904)

Change-Id: Ic5cf268edd42127ca6161f4663ec0efc29c64b96
Reviewed-on: https://chromium-review.googlesource.com/1054575
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557748}
Reviewed-on: https://chromium-review.googlesource.com/1057957
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#592}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/chrome_content_browser_client_chromeos_part.cc[diff]

[RLS] Don't include scroll offset for unclipped absolute bounding boxes of PaintLayers.

[email protected]

(cherry picked from commit 7e3ce87568c3a2338775ededa458e273605da216)

Bug: 838811
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I98804e49d7b50d7f192e54806a00669dc843a1ae
Reviewed-on: https://chromium-review.googlesource.com/1048970
Commit-Queue: Tien-Ren Chen <[email protected]>
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557280}
Reviewed-on: https://chromium-review.googlesource.com/1057952
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#591}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/BUILD.gn[diff]
• third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc[diff]
• third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater_test.cc[diff]
• third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc[diff]
• third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc[Added - diff]
• third_party/blink/renderer/core/paint/paint_layer.h[diff]

IntersectionGeometry correctly clip fixed position elements in OOPIFs

IntersectionGeometry::ClipToRoot() incorrectly clips elements with
position:fixed when the element is in an iframe and root layer
scrolling is enabled.

This patch corrects the problem by mapping the intersection_rect_ all
the way to the out-of-process root viewport.

Bug: 840821
Change-Id: Ia418f3da3950b6ed29a0ecd85601c2cd358456fe
Reviewed-on: https://chromium-review.googlesource.com/1053840
Commit-Queue: Ken Buchanan <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557954}(cherry picked from commit f9673ee39996a1aba3a048ba92de6660fa218240)
Reviewed-on: https://chromium-review.googlesource.com/1057768
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#590}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/http/tests/intersection-observer/cross-origin-iframe-with-fixed-position-element.html[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/iframe-with-fixed-position-element.html[Added - diff]
• third_party/blink/renderer/core/layout/intersection_geometry.cc[diff]

Do not use extra space for WebAPK installation on Android J and K

[email protected]

Bug: 839964
Change-Id: I4fe48a721a878be716cc3fd2cc38fcf9ac3075a4
Reviewed-on: https://chromium-review.googlesource.com/1044953
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Ran Ji <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556204}(cherry picked from commit 11edd3405625d391169ccbbebb9b0a9dfb198941)
Reviewed-on: https://chromium-review.googlesource.com/1057691
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#589}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java[diff]

Fix inline settings toggle crash.

ToggleInlineSettings assumed |settings_row_| to exist. However, it
wasn't always the case.

TEST=manual
BUG=829240
[email protected]

Change-Id: I0a95bf830f616fd7c380fdf19009da00f53ba3b3
Reviewed-on: https://chromium-review.googlesource.com/1053933
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557941}(cherry picked from commit b7c6d92241abb531fea5fd8ecae508d1c77befeb)
Reviewed-on: https://chromium-review.googlesource.com/1057847
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#588}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/message_center/views/notification_view_md.cc[diff]

Split the Sync Session.TotalDuration metrics

Create WithAccount and WithoutAccount versions of NotOptedInToSync and
OptedInToSync.

This will help us learn what percentage of users have an LST for DICe,
and will tell us how much time users spend in permanent auth error states for
sync.

BUG=839048

Change-Id: I64b5e6b1466d3b6723f2fc2491f6254f6e14e067
Reviewed-on: https://chromium-review.googlesource.com/1051808
Commit-Queue: Florian Uunk <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557899}(cherry picked from commit cc5d9e7ec093aa1fcab9d2a376c64fb4dda6c75e)
Reviewed-on: https://chromium-review.googlesource.com/1056531
Cr-Commit-Position: refs/branch-heads/3396@{#587}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/metrics/desktop_session_duration/desktop_profile_session_durations_service.cc[diff]
• chrome/browser/metrics/desktop_session_duration/desktop_profile_session_durations_service.h[diff]
• chrome/browser/metrics/desktop_session_duration/desktop_profile_session_durations_service_factory.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

scheduler: Collect a task's thread_time into correct UKM field

thread_time was previously overriding the wall time, but should actually
be reported in a separate UKM field.

Bug: 842112
Change-Id: If772b5276c0629a4184006bb5382939d9281d3d7
Reviewed-on: https://chromium-review.googlesource.com/1054011
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557860}(cherry picked from commit 2794e1b22391a55780ef2c6d1734ef970fc7acc8)
Reviewed-on: https://chromium-review.googlesource.com/1057248
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#586}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc[diff]

Update modifiers when buttons is set in MouseEvent

NACL expects modifiers to contain buttons information.
So we need to also set that information not only in
buttons field but also modifiers.

Bug: 839539, 839303
Change-Id: Ib859a2e071984be4625f0a42094982c7513ae5ae
Reviewed-on: https://chromium-review.googlesource.com/1052171
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Ella Ge <[email protected]>
Commit-Queue: Navid Zolghadr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557657}(cherry picked from commit 2306a9caf973ef319f5a53356568434159643675)
Reviewed-on: https://chromium-review.googlesource.com/1057688
Reviewed-by: Navid Zolghadr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#585}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/events/mouse_event.cc[diff]
• third_party/blink/renderer/core/exported/web_plugin_container_test.cc[diff]

[DevTools] Do not assume we were attached to OOPIF

[email protected]

(cherry picked from commit 02d4be3f1bd83ac873240b3ce182beb6475e6859)

Bug: 836511
Change-Id: I9ac2c9613235758f47b7b44d9b5f8c46b5a35734
Reviewed-on: https://chromium-review.googlesource.com/1048843
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556979}
Reviewed-on: https://chromium-review.googlesource.com/1057359
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#584}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/devtools/protocol/target_auto_attacher.cc[diff]

Fix crash on ArcNotificationView#IsCloseButtonFocused

This crash is caused because it refers the control buttons view which
may be null. This CL adds a null-check.

Also this refactors related code with IsCloseButtonFocused and
RequestFocusOnCloseButton. These methods do same thing among child classes
so that no need to be virtaul.

[email protected]

(cherry picked from commit cdda1da1392591ea4aaf01b24be0802bdef85214)

Bug: 836523
Test: none
Change-Id: I2f10d77b0772cc3bca51048473352daed5317589
Reviewed-on: https://chromium-review.googlesource.com/1037064
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555431}
Reviewed-on: https://chromium-review.googlesource.com/1056451
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#583}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/arc/notification/arc_notification_content_view.cc[diff]
• ui/arc/notification/arc_notification_content_view.h[diff]
• ui/arc/notification/arc_notification_view.cc[diff]
• ui/arc/notification/arc_notification_view.h[diff]
• ui/message_center/views/message_view.cc[diff]
• ui/message_center/views/message_view.h[diff]
• ui/message_center/views/notification_view.cc[diff]
• ui/message_center/views/notification_view.h[diff]
• ui/message_center/views/notification_view_md.cc[diff]
• ui/message_center/views/notification_view_md.h[diff]

media/test/data: Update video thumbnail MD5 sum

CL:1023615 wrongly deletes md5sum for intel platforms
Reupdate to add the md5sum.

BUG=chromium:827032
TEST=video_VideoDecodeAccelerator on eve

Change-Id: I2d8ee3b7517f997721741d4b532596c2fbf0641e
Reviewed-on: https://chromium-review.googlesource.com/1037044
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555162}(cherry picked from commit 40443c69032869b89d2e97ce08b56ebc5c2f96d5)
Reviewed-on: https://chromium-review.googlesource.com/1043845
Reviewed-by: Pawel Osciak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#582}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• media/test/data/test-25fps.h264.md5[diff]

Incrementing VERSION to 67.0.3396.46

[email protected]

Change-Id: I0a857f5acf20cfd2f4d2c1a9fc98f1d3aaf8831a
Reviewed-on: https://chromium-review.googlesource.com/1056828
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#581}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Incrementing VERSION to 67.0.3396.45

[email protected]

Change-Id: I1a2eac99ce02b6adca24ec81f170dff44d61a867
Reviewed-on: https://chromium-review.googlesource.com/1056020
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#580}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Incrementing VERSION to 67.0.3396.44

[email protected]

Change-Id: I7e2f02af1b154c5e71b2d665898a49b4ab90140e
Reviewed-on: https://chromium-review.googlesource.com/1056011
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#579}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Unhandle DM_POINTERHITTEST if WindowEventTarget is null.

LegacyRenderWidgetHostHWND's WindowEventTarget is null in some cases.
In these cases, we should not pass it to DirectManipulation.
In this patch, we add a null check before pass DM_POINTERHITTEST to
DirectManipulation API so DirectManipulationHelper should not receive
null WindowEventTarget. We also check WindowEventTarget before using
to prevent crash if Windows send unanticipated OnContentUpdated().

Because we don't set the pointer to DirectManipulation, events will
fallback to wheel events.

Bug: 839338
Change-Id: I94e9f6faea420536a264d292422b566d7ce5eac8
Reviewed-on: https://chromium-review.googlesource.com/1047196
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Jianpeng Chao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557389}(cherry picked from commit 778e2aaeb090e52d28ad8b3296c218e2b4bb2578)
Reviewed-on: https://chromium-review.googlesource.com/1056268
Reviewed-by: Jianpeng Chao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#578}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/base/win/direct_manipulation.cc[diff]

Set WindowEventTarget when DirectManipulationHelper create

Currently, we only set WindowEventTarget to DirectManipulationHelper
when receive DM_POINTERHITTEST. But the crash shows OnContentUpdate
may come before DM_POINTERHITTEST. To prevent the crash we set the
WindowEventTarget when DirectManipulationHelper create.

Bug: 839338
Change-Id: I2921277178771f9124a37325a8dff47196500322
Reviewed-on: https://chromium-review.googlesource.com/1042381
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Jianpeng Chao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555904}(cherry picked from commit 6016f8b03db8be3ff25b632696a5f3739e43bd42)
Reviewed-on: https://chromium-review.googlesource.com/1056267
Reviewed-by: Jianpeng Chao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#577}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/legacy_render_widget_host_win.cc[diff]
• ui/base/win/direct_manipulation.cc[diff]
• ui/base/win/direct_manipulation.h[diff]

[CrOS Tether] Do not perform host scans while the device is locked.

EasyUnlock tries to create Bluetooth connections at the lock screen, and
when both Instant Tethering and EasyUnlock try to create a Bluetooth
connection to the same device at the same time, they can cause
instability. By eliminating the possibility of this conflict, we work
around this issue.

Note that a full-fledged fix for this problem is in the works; see
https://crbug.com/752273.

[email protected]

(cherry picked from commit e602d3a83ceaaa2d8e66e8282fc78fb7f9474df6)

Bug: 839522
Change-Id: I468515579ca46cabf279e11531ca489a71eb3255
Reviewed-on: https://chromium-review.googlesource.com/1045254
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: James Hawkins <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556282}
Reviewed-on: https://chromium-review.googlesource.com/1056204
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#576}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chromeos/components/tether/host_scan_scheduler_impl.cc[diff]
• chromeos/components/tether/host_scan_scheduler_impl.h[diff]
• chromeos/components/tether/host_scan_scheduler_impl_unittest.cc[diff]

Increase rendering UKM sampling period to 30 seconds.

At a 1-second aggregation period, the UKM team reports
that there is too much data being collected, which
causes too much user bandwidth.

See internal b/79071304.

[email protected]

(cherry picked from commit 79f554bc2d62df9ffcac3ad7e9460c9acfdae9f4)

Bug: 841527
Change-Id: I9553b56a0b8b2b32229c7ee11586640c4f0a0a6f
Reviewed-on: https://chromium-review.googlesource.com/1050938
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557097}
Reviewed-on: https://chromium-review.googlesource.com/1056154
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#575}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/frame/local_frame_view.cc[diff]

VR: Disable VR on standalone VR devices.

[email protected]

(cherry picked from commit f948761ec35e6848119751f0bc6c901b2acb76bc)

Bug: 841850
Change-Id: I0249210c8fe387a3732715be2650ce9aea5af800
Reviewed-on: https://chromium-review.googlesource.com/1054211
Reviewed-by: Biao She <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557623}
Reviewed-on: https://chromium-review.googlesource.com/1055735
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#574}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java[diff]

Always restore FullscreenManager offsets when exiting VR

When exiting VR on chrome://crash (sad tab), the renderer doesn't send
any control offset updates, and resetting the overrides to the control
offsets for VR restores the hidden control values, so we need to tell
the controls to show explicitly.

Also fixes initialization when opening a new tab while in VR...

[email protected]

(cherry picked from commit 57552aeb19797ad3871b842224caa2ca5dad2703)

Bug: 837807
Change-Id: I14df5479156dc6ac981f845529f8c13aadbd15ac
Reviewed-on: https://chromium-review.googlesource.com/1052892
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557592}
Reviewed-on: https://chromium-review.googlesource.com/1055900
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#573}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java[diff]

Actually call setPositionsForTab when in VR...

In https://chromium-review.googlesource.com/c/chromium/src/+/1042500 I
missed a commit which added a crucial line :)

[email protected], [email protected]

(cherry picked from commit 3208e469223036763c7dcb2b288b8fb0efbae7e7)

Bug: 837807
Change-Id: Ibc8f4f69e86ba16cfcff223c72b64481d9289549
Reviewed-on: https://chromium-review.googlesource.com/1044754
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556161}
Reviewed-on: https://chromium-review.googlesource.com/1055897
Cr-Commit-Position: refs/branch-heads/3396@{#572}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java[diff]

Ensure initial top controls gets propagated when in VR for new RWHVA.

In some cases the Metadata for a RWHVA is set before VR code calls
SetIsInVr on the RWHVA, so we miss the initial top controls update.

(The only reason we care about VR-ness when updating the frame metadata
is that sending the initial top controls update breaks interstitials)

[email protected]

(cherry picked from commit 0f149108b4dbfaae84eb390718c44a9ddfb727af)

Bug: 837807
Change-Id: Ic108fa324725e7c126c9f721c27e4c5f99521af6
Reviewed-on: https://chromium-review.googlesource.com/1042500
Reviewed-by: Bo <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555918}
Reviewed-on: https://chromium-review.googlesource.com/1055895
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#571}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java[diff]
• content/browser/renderer_host/render_widget_host_view_android.cc[diff]
• content/browser/renderer_host/render_widget_host_view_android.h[diff]

(merge)Increase minimum width of tab on touchable chrome

Merging to M67
This patch increases the minimum width of the tab from 68px to 160 px.

Bug: 826380
Change-Id: I3aa3e96b09784bec3ed4e6b647f57785e7bac128
Component: Tabs, layout constant
Reviewed-on: https://chromium-review.googlesource.com/1044495
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556116}(cherry picked from commit ae41c8fddbe5a4b332772f8241fedb50b17fc065)
Reviewed-on: https://chromium-review.googlesource.com/1055709
Reviewed-by: Malay Keshav <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#570}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/layout_constants.cc[diff]

Chrome Android PhotoPicker: Catch OOM in DecoderHost.

Bug: 839981, 656015
Change-Id: I086a8c448c4192317538d4994ccceb65ba20ef0a
Reviewed-on: https://chromium-review.googlesource.com/1050249
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557213}(cherry picked from commit 5867568755a0564e78625ec57be31ffc42bcef1b)
Reviewed-on: https://chromium-review.googlesource.com/1054013
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#569}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceHost.java[diff]
• tools/metrics/histograms/histograms.xml[diff]

Quota: Revert "should/must remain available" changes on low-end devices

Chrome has a "should remain available" disk space threshold; when less
than this amount is free, the effective quota for each origin drops to
0 so new writes will fail. This is present to avoid Chrome being
responsible for filling the disk which generally makes devices
unhappy. Similarly, Chrome has a "must remain available" threshold at
which point data starts being evicted - keeping the device functional,
but potentially losing user data.

In r538818 and r539735 in M66 the thresholds were changed from 10% and
1% to a fixed 2GB and 1GB respectively, to reduce the amount reserved
on high-end devices - 10% of a 1TB machine is a lot! But this did not
account for the impact on low end devices, e.g. 16GB or even 8GB,
where the reserve substantially increased, reducing the usability of
Chrome.

Change the algorithm to use min(fixed, ratio) where fixed values
remain 2GB/1GB and the ratios revert back to 10%/1%, restoring the
previous availability on storage on low end devices.

Bug: 838816
Change-Id: I7d60ae614d6be7a99cfaaa29f2aac9ce25ce861e
Reviewed-on: https://chromium-review.googlesource.com/1039879
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555600}(cherry picked from commit 73b18e372a83137f1198a350973225c4c145ceb6)
Reviewed-on: https://chromium-review.googlesource.com/1055708
Reviewed-by: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#568}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• storage/browser/quota/quota_settings.cc[diff]

Merge of DevTools: fix mismatch between DOMNode childNodeCount and children

Expanding an ElementsTreeElement used to immediately set a
populated flag to true before requesting getChildNodes().
If a ChildNodeCountUpdated event arrives before the children
are set, we may call updateModifiedParentNode() and try to
create visibleChildren when they are null, breaking the tree.

This CL moves the place where 'populated' is set, so that
updateModifiedParentNode() does not update tree children
before they are available.

Bug: 829884
Change-Id: Id68e71fb7a58336d781207b298a53354af3e5cfc
Reviewed-on: https://chromium-review.googlesource.com/1049113
Commit-Queue: Erik Luo <[email protected]>
Reviewed-by: Andrey Lushnikov <[email protected]>
Reviewed-by: Joel Einbinder <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557132}(cherry picked from commit 2e5ad0a88b7d04fe1aac8b2fd0c26b2d3475e4c2)
Reviewed-on: https://chromium-review.googlesource.com/1055707
Reviewed-by: Erik Luo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#567}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-child-node-count-mismatch-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-child-node-count-mismatch.js[Added - diff]
• third_party/blink/renderer/devtools/front_end/elements/ElementsTreeElement.js[diff]
• third_party/blink/renderer/devtools/front_end/elements/ElementsTreeOutline.js[diff]

Fix CHECK that relies on external sync sessions data

Tab sync entities are expected to have a valid |tab_id| field over the
sync protocol, but clients should not crash if the received data is
corrupt, e.g. committed by a buggy client.

Prior to this patch, foreign sessions received in SessionsSyncManager,
processed via UpdateTrackerWithSpecifics(), could trigger a CHECK
failure in SyncedSessionTracker::GetTab().

Bug: 840876
Change-Id: Ie59cfb9c24934695a1b7b6187dbad48451f8c8ea
Reviewed-on: https://chromium-review.googlesource.com/1051233
Reviewed-by: Jan Krcal <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557124}(cherry picked from commit 64d2239bfb602c7e7177cde2a0d27f30d5d82d8b)
Reviewed-on: https://chromium-review.googlesource.com/1055427
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#566}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/sync_sessions/synced_session_tracker.cc[diff]
• components/sync_sessions/synced_session_tracker_unittest.cc[diff]

Revert "Do not skip password forms with multiple inputs with the same name."

This reverts of https://chromium-review.googlesource.com/c/chromium/src/+/886707.

The reason: it breaks Password Manager on almost any sites where
there are simultaneously fields with ids and without ids. Fixing this properly is
too difficult and risky for merging. And anyway processing of fields with empty
ids will be much improved in https://crbug.com/831123

Bug: 839376, 803215

[email protected]

(cherry picked from commit 017745bc613504f1823d5cb1a0d5591a79e53f67)

Change-Id: I91b535161335844266b0559b0ac21ecaf27faddc
Reviewed-on: https://chromium-review.googlesource.com/1049926
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556791}
Reviewed-on: https://chromium-review.googlesource.com/1055387
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#565}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/renderer/autofill/password_autofill_agent_browsertest.cc[diff]
• components/autofill/content/renderer/password_autofill_agent.cc[diff]

Reland: Fix hosted app crash when started in tablet mode

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1029882
with debug linkage fixed.

Original description:
The code was written with the expectation that
HostedAppButtonContainer::StartTitlebarAnimation()
is called before
HostedAppButtonContainer::OnImmersiveRevealStarted().

This is not the case when in tablet mode and results
in crashes.

This CL updates HostedAppButtonContainer to allow these
methods to be called in either order.

[email protected]

(cherry picked from commit 34207ba5a7d39fde67a355c55a576ccd4939e34a)

Bug: 836482
Change-Id: Ia862c8bfccf448322cb878892e70b38eb68818e4
Reviewed-on: https://chromium-review.googlesource.com/1045955
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556695}
Reviewed-on: https://chromium-review.googlesource.com/1055228
Reviewed-by: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#564}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/public/cpp/immersive/immersive_fullscreen_controller_test_api.cc[diff]
• chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc[diff]
• chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h[diff]
• chrome/browser/ui/views/frame/hosted_app_button_container.cc[diff]
• chrome/browser/ui/views/frame/hosted_app_button_container.h[diff]
• chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc[diff]

Fix desktop views notification blocking.

When notifications more than 3 are created on desktop notification
at once, they should be shown in the order after timeouts.
https://crrev.com/c/967094 worked fine on Chrome OS, but didnt' work
on desktop chrome, because MessageCenterImpl::MarkSinglePopupAsShown
takes different codepaths by ifdef-ing OS_CHROMEOS. To fix this,
we have to always call DoUpdate in OnNotificationRemoved.

TEST=chrome --disable-features=NativeNotifications with
extension attached in #0 of https://crbug.com/837119
BUG=837119
[email protected]

Change-Id: Ie287045fe702736fcc449a6df1b3f7ed2b077abf
Reviewed-on: https://chromium-review.googlesource.com/1049989
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557404}(cherry picked from commit 62ea842e987a1885b5115d137dd3f07f975007da)
Reviewed-on: https://chromium-review.googlesource.com/1053930
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#563}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/message_center/views/message_popup_collection.cc[diff]

Incrementing VERSION to 67.0.3396.43

[email protected]

Change-Id: I96c9bb8af2b5e3bbe704691247926e972c9ed476
Reviewed-on: https://chromium-review.googlesource.com/1054948
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#562}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Ensure that libusb_context outlives libusb_device

When destroying the UsbServiceImpl its reference to the libusb_context
object is released before the list of UsbDeviceImpls owned by its parent
class. Each UsbDeviceImpl has both a reference to the libusb_context and
an individual libusb_device but because of the order in which these are
declared the libusb_context reference is released first. This patch
reverses the order of these fields so that the libusb_context outlives
all libusb_device references.

Bug: 838947
Change-Id: Ife26033b30bcba164ade30a66cc3e153faa7c876
Reviewed-on: https://chromium-review.googlesource.com/1048610
Reviewed-by: Matt Reynolds <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556866}(cherry picked from commit 4caa90ed4f82092371250393d5716065823a1ccf)
Reviewed-on: https://chromium-review.googlesource.com/1054204
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#561}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• device/usb/usb_device_impl.cc[diff]
• device/usb/usb_device_impl.h[diff]
• device/usb/usb_service_impl.h[diff]

Don't allocate new LocalSurfaceId for the first navigation

Don't allocate a new id for the first navigation. The browser might
have already embedded the old surface so if the renderer doesn't submit
to the old surface there will be a flash.

[email protected]

(cherry picked from commit 39a1111b6cf57987d92b01848170c05e38e4d20f)

Bug: 834449
Change-Id: Ie9e79dba0b8afcfb43929c8264cc7e3c2c4a0792
Reviewed-on: https://chromium-review.googlesource.com/1048118
Reviewed-by: Fady Samuel <[email protected]>
Commit-Queue: Saman Sami <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556988}
Reviewed-on: https://chromium-review.googlesource.com/1054406
Reviewed-by: Saman Sami <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#560}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/browser_compositor_view_mac.h[diff]
• content/browser/renderer_host/browser_compositor_view_mac.mm[diff]
• content/browser/renderer_host/render_widget_host_view_aura.cc[diff]
• content/browser/renderer_host/render_widget_host_view_aura.h[diff]
• content/browser/renderer_host/render_widget_host_view_aura_unittest.cc[diff]

Merge to release branch M67: Network Service: Change back how the |is_main_frame| value is obtained

This CL merges the following CL to M67 branch:
https://chromium-review.googlesource.com/c/chromium/src/+/1050935

The previous merge CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1054171
was reverted due to compile failure:
https://chromium-review.googlesource.com/c/chromium/src/+/1054347

This CL fixed the compile failure by adding |resource_type| parameter to the
NetworkServiceClient::OnAuthRequired() mojo interface.

[email protected], [email protected], [email protected]

Bug: 840176
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I07d246aac10af5c99838a80aea09a67d661977f0
Reviewed-on: https://chromium-review.googlesource.com/1054498
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#559}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/loader/resource_dispatcher_host_impl.cc[diff]
• content/browser/network_service_client.cc[diff]
• content/browser/network_service_client.h[diff]
• services/network/public/mojom/network_service.mojom[diff]
• services/network/url_loader.cc[diff]

Stop CVC popup in VR

When in VR, CVC popup does not show properly, so there is no support
for server side credit cards.
GetCreditCardSuggestions in autofill_manager is updated to support a flag
to decide whether the server side cards should be included or not.

When in VR, we set the flag (include_server_cards) to false and don't show
suggestions for server side cards.

Bug: 831751

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I86b6a87ba88109d01ef84a6622096118f9970486
Reviewed-on: https://chromium-review.googlesource.com/1031200
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556446}(cherry picked from commit d3b7ba4a4b1b3fc51f8fb60c545b386e3912c57b)
Reviewed-on: https://chromium-review.googlesource.com/1054203
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#558}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• android_webview/browser/aw_autofill_client.cc[diff]
• android_webview/browser/aw_autofill_client.h[diff]
• chrome/browser/autofill/android/personal_data_manager_android.cc[diff]
• chrome/browser/ui/autofill/chrome_autofill_client.cc[diff]
• chrome/browser/ui/autofill/chrome_autofill_client.h[diff]
• components/autofill/core/browser/autofill_client.h[diff]
• components/autofill/core/browser/autofill_manager.cc[diff]
• components/autofill/core/browser/personal_data_manager.cc[diff]
• components/autofill/core/browser/personal_data_manager.h[diff]
• components/autofill/core/browser/personal_data_manager_unittest.cc[diff]
• components/autofill/core/browser/test_autofill_client.cc[diff]
• components/autofill/core/browser/test_autofill_client.h[diff]
• components/payments/content/payment_request_state.cc[diff]
• ios/chrome/browser/payments/payment_request.mm[diff]
• ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h[diff]
• ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm[diff]
• ios/web_view/internal/autofill/web_view_autofill_client_ios.h[diff]
• ios/web_view/internal/autofill/web_view_autofill_client_ios.mm[diff]

Don't reset the deadline in DelegatedFrameHost if size hasn't changed

We should only reset the deadline when ui is resizing because OS is
guttering us anyways. In other cases use the real deadline.

[email protected]

(cherry picked from commit 52e45765d50a03b7833097e09446e287e26c94c1)

Bug: 834449, 672962
Change-Id: I95a29e3cf8a508d0d1cd614df79c0e12183f1487
Reviewed-on: https://chromium-review.googlesource.com/1048206
Reviewed-by: Fady Samuel <[email protected]>
Commit-Queue: Saman Sami <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556600}
Reviewed-on: https://chromium-review.googlesource.com/1054496
Reviewed-by: Saman Sami <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#557}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/delegated_frame_host.cc[diff]

Scroll support for hosted dialogs in VR

Now that VR supports html <select>, we should send scroll events
to dialogs.

[email protected]

(cherry picked from commit 480d1516022c82afad0696259a94dee364a61890)

Bug: 836292
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288
Reviewed-on: https://chromium-review.googlesource.com/1028584
Commit-Queue: Amirhossein Simjour <[email protected]>
Reviewed-by: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555454}
Reviewed-on: https://chromium-review.googlesource.com/1054490
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#556}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/android/vr/vr_dialog.cc[diff]
• chrome/browser/android/vr/vr_dialog.h[diff]
• chrome/browser/vr/content_input_delegate.cc[diff]
• chrome/browser/vr/content_input_delegate.h[diff]

Web Locks API: Ensure shared/exclusive sets are rebuilt after a release

The code contained an optimization to skip rebuilding sets of held
shared/granted locks if there was no pending request. This was not
valid, since a request could come in later and rely on the sets to
correctly determine if the lock was grantable.

Bug: 840994
Change-Id: I64218cfaebe4ff7b46f133665a94378c66d0e738
Reviewed-on: https://chromium-review.googlesource.com/1050807
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Joshua Bell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557257}(cherry picked from commit 0e021fc6edcf6e71152f8959fa324d6cc0f5ce8d)
Reviewed-on: https://chromium-review.googlesource.com/1054351
Reviewed-by: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#555}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/locks/lock_manager.cc[diff]
• third_party/WebKit/LayoutTests/http/tests/locks/ifAvailable.html[diff]

Update query in omnibox search icon.

Uses an updated asset for the query in omnibox magnifying glass to match
the size of the security icon.

Bug:836043

Change-Id: Ia84817af01373fbcfc3f07656ce0ee77a0f553e0
Reviewed-on: https://chromium-review.googlesource.com/1040534
Commit-Queue: Troy Hildebrandt <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Maria Khomenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556583}(cherry picked from commit 18fa555020d39dd0e6975c4d32cf5c80010d9172)
Reviewed-on: https://chromium-review.googlesource.com/1054348
Reviewed-by: Troy Hildebrandt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#554}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/res/drawable-hdpi/omnibox_search.png[Added - diff]
• chrome/android/java/res/drawable-mdpi/omnibox_search.png[Added - diff]
• chrome/android/java/res/drawable-xhdpi/omnibox_search.png[Added - diff]
• chrome/android/java/res/drawable-xxhdpi/omnibox_search.png[Added - diff]
• chrome/android/java/res/drawable-xxxhdpi/omnibox_search.png[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java[diff]

Don't show AppBanner while in VR.

Note that this doesn't handle the case where the banner is already open
when entering VR. That's complicated and I'm not going to try to merge
a fix for that back to M67.

(This CL is targeted for M67)

[email protected]

(cherry picked from commit 1bf8f8002c2d816bad3bead3d0617db18f3b4b09)

Bug: 840811
Change-Id: I9e4daba4baeed7aeb8f5b841fdb7acb1f7872ff7
Reviewed-on: https://chromium-review.googlesource.com/1052211
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557248}
Reviewed-on: https://chromium-review.googlesource.com/1054381
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#553}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java[diff]

Revert "Merge to release branch M67: Network Service: Change back how the |is_main_frame| value is obtained"

This reverts commit 7d0f75aee8f7e6f77c3725dde5d95d3e774d2d2c.

Reason for revert: The merge fails to compile.

Original change's description:
> Merge to release branch M67: Network Service: Change back how the |is_main_frame| value is obtained
> 
> This CL merges the following CL to M67 branch:
> https://chromium-review.googlesource.com/c/chromium/src/+/1050935
> 
> [email protected], [email protected]
> 
> Bug: 840176
> Change-Id: Ic5342dbbc560e569761434030134fef41086d8a8
> Reviewed-on: https://chromium-review.googlesource.com/1054171
> Reviewed-by: Jun Cai <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3396@{#548}
> Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

[email protected],[email protected]

Change-Id: Id9cc68a628ec12db6f0c1819a54e726acccd35cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 840176
Reviewed-on: https://chromium-review.googlesource.com/1054347
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#552}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/loader/resource_dispatcher_host_impl.cc[diff]
• content/browser/network_service_client.cc[diff]

DevTools: follow up to r548569, complete the tethering transition.

[email protected]

(cherry picked from commit 0fd6912160ccc39e038b04b748dc39b6e3e81fe3)

Bug: 837446
Change-Id: I8e2d61e50fe9bf800a1577642a458791fb777057
Reviewed-on: https://chromium-review.googlesource.com/1048401
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Pavel Feldman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557242}
Reviewed-on: https://chromium-review.googlesource.com/1054259
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#551}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/devtools/device/port_forwarding_controller.cc[diff]

DevTools: do not handle active panel shortcuts unless panel has focus.

[email protected]

(cherry picked from commit ec3529b434fdde061f924b8e3a93f4f1a386f8c6)

Bug: 835656
Change-Id: I9b0692917facb673fc01c9974430d1e66fcd7742
Reviewed-on: https://chromium-review.googlesource.com/1048031
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Pavel Feldman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556559}
Reviewed-on: https://chromium-review.googlesource.com/1054257
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#550}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/devtools/front_end/main/Main.js[diff]

Handle more html/js polyglots in CORB confirmation sniffing.

Cross-Origin Read Blocking (CORB) tries to protect certain resource
types (e.g. text/html).  To be resilient against HTTP responses
mislabeled with an incorrect Content-Type, CORB sniffs the response body
to confirm if it truly is the protected type.

Before this CL the confirmation sniffing logic blocked resources that
are both a valid html and a valid javascript.  Blocking of such
resources is undesirable, because it is disruptive to existing websites
that use such polyglot responses in <script> tags.

After this CL, CORB sniffer takes into account the
https://www.ecma-international.org/ecma-262/8.0/index.html#prod-annexB-SingleLineHTMLCloseComment
rule which means that the sniffing doesn't resume immediately after
"-->" characters, but instead also consumes all the characters until the
first line terminator.

Bug: 839945
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7c8221acc2013adffe8095d188ae22e1c6a2fdab
Reviewed-on: https://chromium-review.googlesource.com/1047851
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557018}
Reviewed-on: https://chromium-review.googlesource.com/1054192
Cr-Commit-Position: refs/branch-heads/3396@{#549}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/loader/cross_site_document_blocking_browsertest.cc[diff]
• content/browser/loader/cross_site_document_resource_handler_unittest.cc[diff]
• content/test/data/site_isolation/js-html-polyglot2.html[Added - diff]
• services/network/cross_origin_read_blocking.cc[diff]
• services/network/cross_origin_read_blocking_explainer.md[diff]
• services/network/cross_origin_read_blocking_unittest.cc[diff]
• third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/html-js-polyglot.js[diff]
• third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/html-js-polyglot2.js[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/fetch/corb/resources/html-js-polyglot2.js.headers[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/fetch/corb/script-html-js-polyglot.sub.html[diff]

Merge to release branch M67: Network Service: Change back how the |is_main_frame| value is obtained

This CL merges the following CL to M67 branch:
https://chromium-review.googlesource.com/c/chromium/src/+/1050935

[email protected], [email protected]

Bug: 840176
Change-Id: Ic5342dbbc560e569761434030134fef41086d8a8
Reviewed-on: https://chromium-review.googlesource.com/1054171
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#548}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/loader/resource_dispatcher_host_impl.cc[diff]
• content/browser/network_service_client.cc[diff]

Revert "Removed rdar://35063950 workaround for iOS 11.3."

rdar://35063950 is not fixed and workaround is still needed.

[email protected]

(cherry picked from commit 967e1009de96fd906c00c1a29e2ddaa30a597ada)

Bug: 840426
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I033a508aadc0dad25bc2b70b0db5527a5800e4c5
Reviewed-on: https://chromium-review.googlesource.com/1048566
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556670}
Reviewed-on: https://chromium-review.googlesource.com/1054169
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#547}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/web/web_state/ui/crw_web_controller.mm[diff]

DataReductionProxy: Change the default warmup url.

Also, change the expected HTTP response code from 204 to a
list containing 3 codes (200, 404,and a 3rd one
configurable via field trial experiment).

Change-Id: I403841d93b9f7c8f9096e827ac67116658b15c82
Bug: 839628
Reviewed-on: https://chromium-review.googlesource.com/1043269
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556159}(cherry picked from commit 096f65d3dc040df32c8591b2ae9241e86a806d7c)
Reviewed-on: https://chromium-review.googlesource.com/1054114
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#546}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/data_reduction_proxy/core/browser/warmup_url_fetcher.cc[diff]
• components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc[diff]
• components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc[diff]
• components/data_reduction_proxy/core/common/data_reduction_proxy_params.h[diff]
• components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc[diff]

[RLS] Ignore fixed when applying root scroll offset for interest rect

This patch fixes a regression from [1] where
MapToVisualRectInAncestorSpaceInternal was changed to not apply a
counterscroll offset for fixed position descendants. Interest rect
calculations incorrectly relied on this behavior.

MapToVisualRectInAncestorSpace is exclusive of the clip and scroll on
the ancestor object. To account for this, the interest rect logic would
call MapToVisualRectInAncestorSpace and then apply the root clip and
scroll offset, but this is not correct if there are fixed-position
children.

This patch updates the callsite to MapToVisualRectInAncestorSpace to
map to nullptr instead of the root view which will include the layout
view's clip and scroll.

[1] http://crrev.com/e931d2aecb

Bug: 838111, 831380, 840504
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I14b023279ef58e0123febae367a2ea0c67733c50
Reviewed-on: https://chromium-review.googlesource.com/1047193
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557066}(cherry picked from commit cfebac612b10fdf961dca9df2bb28581577a612a)
Reviewed-on: https://chromium-review.googlesource.com/1054110
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#545}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/layout/layout_object.h[diff]
• third_party/blink/renderer/core/layout/layout_view.cc[diff]
• third_party/blink/renderer/core/layout/layout_view.h[diff]
• third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc[diff]
• third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc[diff]

Use a message loop of type UI on the main thread of video-capture service

AVFoundation calls made by the video-capture service on its main thread
require a CFRunLoop which is provided by a UI message loop.
This fixes a number of regressions related to detection of plugged/unplugged
devices that appeared when the default message loops on Mac were changed from
CFRunLoop to Default.

Bug: 834581
Change-Id: If565f400e52407c2f71e32f93e9472556051bad1
Reviewed-on: https://chromium-review.googlesource.com/1049931
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557202}(cherry picked from commit 191635e56f362891dd7ee750598679e3eb27cab6)
Reviewed-on: https://chromium-review.googlesource.com/1053967
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#544}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/BUILD.gn[diff]
• chrome/browser/DEPS[diff]
• chrome/browser/chrome_content_browser_client.cc[diff]