Publish DEPS for Chromium 66.0.3359.67
Incrementing VERSION to 66.0.3359.67
[email protected]
Change-Id: Ic00334974227eafde211f7cb40fa48bc2d1273e3
Reviewed-on: https://chromium-review.googlesource.com/982952
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#477}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Updating XTBs based on .GRDs from branch 3359
[email protected]
Change-Id: I55a5ef9fab4e33ed3b6e2e30a62d4a1a58326e48
Reviewed-on: https://chromium-review.googlesource.com/982408
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#476}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.66
[email protected]
Change-Id: Id260a5fa1a504be1d35fab4d009bd3f438df51b8
Reviewed-on: https://chromium-review.googlesource.com/982793
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#475}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Revert "Clean up kAutofillCreditCardBankNameDisplay flag"
This reverts commit e363dc219abb57a818406fffcad3bb30555dab4c.
Reason for revert: Not convinced metrics are good; performing flag holdback
Original change's description:
> Clean up kAutofillCreditCardBankNameDisplay flag
>
> Bug: 812710
> Change-Id: I4344c258668c5017a0a145e487ca2eb526bd49bc
> Reviewed-on: https://chromium-review.googlesource.com/923281
> Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
> Reviewed-by: Robert Kaplow <[email protected]>
> Commit-Queue: Jared Saul <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#537368}
[email protected], [email protected], [email protected], [email protected]
(cherry picked from commit ae93aa1ca751f10fc35bde299e68124ca347d9a0)
Bug: 812710
Change-Id: I0f15c86af76e686ef4ab55a0313831461503d758
Reviewed-on: https://chromium-review.googlesource.com/974342
Reviewed-by: Mathieu Perreault <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545544}
Reviewed-on: https://chromium-review.googlesource.com/982602
Cr-Commit-Position: refs/branch-heads/3359@{#474}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Surface synchronization: Fix autoresize invariants violation
Auto-resize could cause a surface invariants violation in the following
case:
1. RenderWidget issues an auto-resize of size A1.
2. RenderWidget allocates a sequence number and tells RenderWidgetHostImpl about size A1.
3. RenderWidgetHostImpl gives RenderWidget a LocalSurfaceId for size A1.
4. RenderWidget tells the compositor about size A1 and LocalSurfaceId A1.
5. RenderWidget issues an auto-resize of size B (clears the LocalSurfaceId in the compositor).
6. RenderWidget issues an auto-resize of size A2 (same as A1).
7. RenderWidget allocates a sequence number and tells RenderWidgetHostImpl about size A2.
8. RenderWidget issues an auto-resize of size C (clears the LocalSurfaceId in the compositor).
9. RenderWidgetHostImpl gives RenderWidget a LocalSurfaceId for size A2 (same as A1).
10. RenderWidget tells the compositor about size C and LocalSurfaceId A1/A2.
11. BOOM! Surface Invariants Violation! cc is using LocalSurfaceId A1 for both size A1 and C!
This is a typical ABA style problem because on Mac we will not allocate a new LocalSurfaceId
unless the size actually changes. This CL solves the problem by allocating a new sequence
number every time the size changes from the perspective of the renderer, that way we can
map each LocalSurfaceId to a particular resize despite resize throttling happening.
Bug: 672962
TBR: [email protected]
Change-Id: I6e7c0ccef3e2a478a5cc2544533487696374d672
Reviewed-on: https://chromium-review.googlesource.com/976809
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545831}(cherry picked from commit da839bb4f3eee1d12b744c7e8d13b35c7671ef56)
Reviewed-on: https://chromium-review.googlesource.com/982552
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#473}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Updating XTBs based on .GRDs from branch 3359
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I66868cb3c27b78f8ba35ffbaa112e598578b9d40
Reviewed-on: https://chromium-review.googlesource.com/982540
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#472}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add missing members to FrameReplicationState struct traits (Merge to M66)
Not having FrameReplicationState::has_received_user_gesture in the
struct traits caused it to not propagate through IPCs properly, and
was caught by a couple of autoplay layout test failures, which had
been failing with site isolation enabled. Thanks to mustaq@ for the
analysis that led to the discovery of this bug.
FrameReplicationState::active_sandbox_flags was similarly missing from
the struct traits, so that member is fixed as well.
[email protected]
(cherry picked from commit cac9faa992309767ed7f2a8c873fe9cc26e36e98)
Bug: 794631
Change-Id: I3ebdb51ff887b79c18c4a7c593fac33bb3333a0d
Reviewed-on: https://chromium-review.googlesource.com/981306
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545969}
Reviewed-on: https://chromium-review.googlesource.com/982510
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#471}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.65
[email protected]
Change-Id: I3e3dc1f8ce981d3b4832948344b8fdc571629910
Reviewed-on: https://chromium-review.googlesource.com/981938
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#470}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Reland "Fix SearchActivityLocationBarLayout URL overlap."
This is a reland of 8589feac37995355407352aa8a8acef301c8822f
Original change's description:
> Fix SearchActivityLocationBarLayout URL overlap.
>
> Since SearchActivityLocationBarLayout built off of LocationBarLayout,
> it looked fine on tablets but the URL text/buttons overlap problem still
> existed for phone. This is caused by a discrepancy in the LayoutParams
> used for calculating the URL bar margin between the different location
> bar layouts.
>
> This CL makes #getUrlContainerMarginEnd generic so we can use
> LinearLayout.LayoutParams where necessary instead of
> FrameLayout.LayoutParams. It also adds #getUrlContainerViewsForMargin,
> and puts the onus on LocationBarTablet to override this and provide its
> unique set of views to be taken into account for margin calculation.
>
> Tested on tablet and phone, in browser and search widget, no more
> overlap (including with voice icon always showing in omnibox on phone)
>
> [email protected]
>
> (cherry picked from commit bdef0435815b99df9b368f2c5a02a6eafc34d31d)
>
> Bug: 822136
> Change-Id: I73915be984d96e5e4613601b5f6b75ef82afff61
> Reviewed-on: https://chromium-review.googlesource.com/966597
> Reviewed-by: Maria Khomenko <[email protected]>
> Reviewed-by: Matthew Jones <[email protected]>
> Commit-Queue: Troy Hildebrandt <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#544874}
> Reviewed-on: https://chromium-review.googlesource.com/978834
> Cr-Commit-Position: refs/branch-heads/3359@{#428}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Bug: 822136
Change-Id: I8e0240139202983ce71aefa95f0242eb9e1c32ec
Reviewed-on: https://chromium-review.googlesource.com/982416
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#469}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix CookieCreationTimeManager crash
The reason for the crash is the thread inconsistency of dereferencing
the weakptr of the CookieCreationTimeManager object
Removed weakptr, as it appears that it's not needed at all.
Bug: 813779, 820384
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iff614621b09b92ae5fa9a41ad90a2e390a1ce6b1
Reviewed-on: https://chromium-review.googlesource.com/976095
Commit-Queue: Mohammad Refaat <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545561}(cherry picked from commit 62b0ee43e0793030ba05c35fbefd398f1776aca1)
Reviewed-on: https://chromium-review.googlesource.com/982412
Cr-Commit-Position: refs/branch-heads/3359@{#468}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Revert "Fix SearchActivityLocationBarLayout URL overlap."
This reverts commit f95a76e2a3f44c1a290a5657be2a368a60ed2482.
Reason for revert: 826423
Original change's description:
> Fix SearchActivityLocationBarLayout URL overlap.
>
> Since SearchActivityLocationBarLayout built off of LocationBarLayout,
> it looked fine on tablets but the URL text/buttons overlap problem still
> existed for phone. This is caused by a discrepancy in the LayoutParams
> used for calculating the URL bar margin between the different location
> bar layouts.
>
> This CL makes #getUrlContainerMarginEnd generic so we can use
> LinearLayout.LayoutParams where necessary instead of
> FrameLayout.LayoutParams. It also adds #getUrlContainerViewsForMargin,
> and puts the onus on LocationBarTablet to override this and provide its
> unique set of views to be taken into account for margin calculation.
>
> Tested on tablet and phone, in browser and search widget, no more
> overlap (including with voice icon always showing in omnibox on phone)
>
> [email protected]
>
> (cherry picked from commit bdef0435815b99df9b368f2c5a02a6eafc34d31d)
>
> Bug: 822136
> Change-Id: I73915be984d96e5e4613601b5f6b75ef82afff61
> Reviewed-on: https://chromium-review.googlesource.com/966597
> Reviewed-by: Maria Khomenko <[email protected]>
> Reviewed-by: Matthew Jones <[email protected]>
> Commit-Queue: Troy Hildebrandt <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#544874}
> Reviewed-on: https://chromium-review.googlesource.com/978834
> Cr-Commit-Position: refs/branch-heads/3359@{#428}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 822136, 826423
Change-Id: I17157180dc2e61f9984c8173bf151cd829d99e05
Reviewed-on: https://chromium-review.googlesource.com/982414
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#467}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add feature flag for enabling pdf compositor service
The added feature flag enables us to do experiments on stable channel
before the upcoming full launch of oopif printing along with site
isolation feature.
BUG=824867
(cherry picked from commit 790e7a85773ebdd4e2f2a25409a5eb4bda8c964d)
Change-Id: I90323fc82e9f545112911f33cf6f8dcb60be91ea
Reviewed-on: https://chromium-review.googlesource.com/976814
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Wei Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545329}
Reviewed-on: https://chromium-review.googlesource.com/982354
Reviewed-by: Wei Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#466}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[css-flexbox] Resolve min-width:auto on table item to min preferred size.
Edge and Firefox seem to let table flex items use the sizing algorithm
of the table extensively, and are therefore generally broken when it
comes to flexing tables. We, on the other hand, let the flex sizing
algorithm be in charge of sizing tables, so that flexing actually works.
However, this causes tables with a specified main size of less than the
minimum intrinsic logical width of the table to shrink below their
minimum intrinsic logical width, a situation that's generally unwanted
for tables.
Amend by ignoring the specified main size when resolving min-width:auto
on table items. Also ignore max-width/max-height. Just use the
preferred minimum logical width.
Bug: 821832
Change-Id: I78ca0c8e0041ea69bb606ff72d340bb3f5f9bb96
Reviewed-on: https://chromium-review.googlesource.com/964203
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545777}(cherry picked from commit fdc7d6d5aaa66bff1edaf37b8b7bb17ca0ba39c0)
Reviewed-on: https://chromium-review.googlesource.com/980855
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#465}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Roll libxml to 7a1bd7f6497ac33a9023d556f6f47a48f01deac0
M-66 Cherry-pick
TBR=[email protected]
Bug: 790944,820163,793715,796804,799707,823345
Change-Id: I6daa6aedd8ccff792b99c228d85800dbd2dd3ec2
Reviewed-on: https://chromium-review.googlesource.com/973467
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545458}(cherry picked from commit f01ade19f2ee3e7037bb57acb46e3bd6d45a0380)
Reviewed-on: https://chromium-review.googlesource.com/981755
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#464}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix Browser Actions crash on showing share dialog for preLMR1 device
Browser Actons crashes on preLMR1 devices when showing the share dialog.
This is because on preLMR1, share dialog is a Android dialog. When
dialog is shown, its attached activity is destroy.
To fix it, BrowserActionActivity would not be closed if share option is
selected on preLMR1 devices. The activity would be closed when an item
is selected form the dialog.
Bug: 821631
NOTRY=true
NOPRESUBMIT=true
[email protected]
(cherry picked from commit e298107ebddf086a82494b17a6bee4b047e371cb)
Change-Id: Ie40120e9aab2b7b45cc84dc532888c02611e5ec6
Original-Reviewed-on: https://chromium-review.googlesource.com/969715
Commit-Queue: Lei Tian <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545188}
Reviewed-on: https://chromium-review.googlesource.com/978479
Cr-Commit-Position: refs/branch-heads/3359@{#463}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[Merge] Make touch handles relative to scrolling contents
Selection bounds are sent from Blink to CC as part of a commit cycle so
that we can draw touch handles for it. Currently, the selection bounds
are relative to the main graphics layer of a CompositedLayerMapping. In
the case of a scroller, this will be its clip rect - rather than its
scrolling contents layer. Unfortunately, this means that scrolling on
the compositor isn't applied as part of the ToScreen transformation on
the selection bounds so scrolling wont update the selection bounds
location until another Blink commit. This went unnoticed until now
because the root layer was not considered a scroller. The page would
paint into a document-sized layer and the compositor would provide extra
scrolling layers to handle frame scrolling. In this configuration, the
ToScreen transformation from the root layer does include the scroll
offset.
Now that root layer scrolling has been turned on, frame scrolling works
much the same as other scrollers. Thus, this shortcoming is seen on
frame scrolling also.
The solution in this CL is to move the selection bounds rect to be
relative to the scrolling contents layer - if one exists. The ToScreen
transformation done in CC will correctly compensate for any scroll
offset applied in the compositor and touch selection handles stick to
the selection as its scrolled. For the CC side, see
ComputeViewportSelectionBound in layer_tree_impl.cc
Reland Note: This patch makes the RenderedPositionTests run with mock
scrollbars.
Merge Note: RuntimeEnabledFeaturesTestHelpers.h was renamed after
branch.
[email protected]
(cherry picked from commit 2940d405c166a3700bd21ea77055f339f4bd403a)
Bug: 812048
Change-Id: If404af9e42197f82bcbc9899c37d8fa4f78d6143
Reviewed-on: https://chromium-review.googlesource.com/967001
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#543803}(cherry picked from commit 6fb0fe3f2c3d3c703b800694623b4f51ae10f717)
Reviewed-on: https://chromium-review.googlesource.com/981014
Cr-Original-Commit-Position: refs/branch-heads/3359@{#449}
Cr-Original-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Reviewed-on: https://chromium-review.googlesource.com/982008
Cr-Commit-Position: refs/branch-heads/3359@{#462}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix text corruption when inline settings of notification are closed.
This CL changes the timing of enabling subpixel rendering to the end of
the animation in order to fix the text corruption.
BUG=824612
TEST=manual
[email protected]
(cherry picked from commit f5f5098559ec513c93b3e43e9379990c156da4ac)
Change-Id: Ib9737c049a4bff8f902a43d3f30913fb641d5e77
Reviewed-on: https://chromium-review.googlesource.com/974802
Reviewed-by: Tetsui Ohkubo <[email protected]>
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Megumi Hattori <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545372}
Reviewed-on: https://chromium-review.googlesource.com/981855
Cr-Commit-Position: refs/branch-heads/3359@{#461}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[iOS] Only verify error code when link tapping fails.
The behavior of TapWebViewElementWithId() for links that close a
WebState is flaky on both simulator and device, regardless of whether
the Phase 1 UI Reboot flag is enabled. This CL updates
FullscreenTestCase.testShowHeaderWhenChildTabCloses to check for the
error code only if the link tap is unsuccessful.
Note that the closure of the Tab and the visibility of the toolbar is
still verified after this occurs, so the test will still catch
fullscreen regressions after this change.
Bug: 812664
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia56293763e185eeb615a5f734aa9a3a473f0b424
Reviewed-on: https://chromium-review.googlesource.com/974791
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545713}(cherry picked from commit b4383a791f180a25c3ef5952233e4f13bd2e33af)
Reviewed-on: https://chromium-review.googlesource.com/981613
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#460}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.64
[email protected]
Change-Id: I2be5199a522e83c0a1cb87573490e6aaa37422a2
Reviewed-on: https://chromium-review.googlesource.com/981496
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#459}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.63
[email protected]
Change-Id: I4ec3e3ff949fbd80487586eb9218d384d1f59213
Reviewed-on: https://chromium-review.googlesource.com/980707
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#458}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix 32 vs 64 bit size issues in eu-strip
Perhaps counterintuitively, Elf64_Word is 32 bits. Don't use it to
manipulate file sizes.
BUG=780860
Change-Id: I0a80e10b46400dcd0e0e43061755494267d67a06
Reviewed-on: https://chromium-review.googlesource.com/954326
Commit-Queue: Michael Moss <[email protected]>
Reviewed-by: Michael Moss <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544032}(cherry picked from commit 838c26134e90bc05a425a58d3eb05b431ddfe9b7)
Reviewed-on: https://chromium-review.googlesource.com/981632
Reviewed-by: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#457}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Revert "[Reland] Make touch handles relative to scrolling contents"
This reverts commit 2940d405c166a3700bd21ea77055f339f4bd403a.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [Reland] Make touch handles relative to scrolling contents
>
> Selection bounds are sent from Blink to CC as part of a commit cycle so
> that we can draw touch handles for it. Currently, the selection bounds
> are relative to the main graphics layer of a CompositedLayerMapping. In
> the case of a scroller, this will be its clip rect - rather than its
> scrolling contents layer. Unfortunately, this means that scrolling on
> the compositor isn't applied as part of the ToScreen transformation on
> the selection bounds so scrolling wont update the selection bounds
> location until another Blink commit. This went unnoticed until now
> because the root layer was not considered a scroller. The page would
> paint into a document-sized layer and the compositor would provide extra
> scrolling layers to handle frame scrolling. In this configuration, the
> ToScreen transformation from the root layer does include the scroll
> offset.
>
> Now that root layer scrolling has been turned on, frame scrolling works
> much the same as other scrollers. Thus, this shortcoming is seen on
> frame scrolling also.
>
> The solution in this CL is to move the selection bounds rect to be
> relative to the scrolling contents layer - if one exists. The ToScreen
> transformation done in CC will correctly compensate for any scroll
> offset applied in the compositor and touch selection handles stick to
> the selection as its scrolled. For the CC side, see
> ComputeViewportSelectionBound in layer_tree_impl.cc
>
> Reland Note: This patch makes the RenderedPositionTests run with mock
> scrollbars.
>
> [email protected]
>
> Bug: 812048
> Change-Id: Ib9eacd14b75b71b4e0d4f0a9b57416800f9dfb91
> Reviewed-on: https://chromium-review.googlesource.com/967001
> Reviewed-by: David Bokan <[email protected]>
> Commit-Queue: David Bokan <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#543803}(cherry picked from commit 6fb0fe3f2c3d3c703b800694623b4f51ae10f717)
> Reviewed-on: https://chromium-review.googlesource.com/981014
> Cr-Commit-Position: refs/branch-heads/3359@{#449}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[email protected]
Change-Id: I2a9cf3c6a3749475b5f47d93bdbe2472ad1faa52
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 812048
Reviewed-on: https://chromium-review.googlesource.com/981155
Reviewed-by: Estelle Yomba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#456}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Handle a null email in AccountSigninView
...by replacing it with an empty string. This happens automatically in
TextView#setText(), but must be now also done explicitly when putting it
into |mTextViewToMetadataMap|.
This CL only remedies the crash, does not yet attempt to investigate the
issue which seems to have existed before the crash was introduced.
See the linked bug for more details.
NOTE: This CL is based on dc43ce71947d14ebfb68e291d11d9c95f6d15e8a which
landed on trunk. However, the method which this CL patches is in
a different file on M67 trunk than it is on M66 branch. Drover seems
unsuitable for resolving inter-file conflicts, so the change has been
patched in on the branch manually.
[email protected]
Bug: 821908
Change-Id: I9e585156e87e64dd5aaa5ecffcc3b44aae3117f0
Reviewed-on: https://chromium-review.googlesource.com/981135
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#455}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[PE] Add ToInt() for logical padding top and bottom for LayoutTableCell
This reverts the logic for logical top/bottom paddings to be the same
as before https://chromium-review.googlesource.com/619603. The logical
top/bottom paddings are truncated like what we do for other table
layouts.
We still keep subpixels for logical left/right paddings to ensure
correct logical width calculation. This is still the same as before
https://chromium-review.googlesource.com/619603.
[email protected]
(cherry picked from commit 80a959a1273c3f91bed6c9a1696312456f6a5b07)
Bug: 823824
Change-Id: Icb617bf5771d1726f767207853f4adc8275731dc
Reviewed-on: https://chromium-review.googlesource.com/974315
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545225}
Reviewed-on: https://chromium-review.googlesource.com/981293
Cr-Commit-Position: refs/branch-heads/3359@{#454}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.62
[email protected]
Change-Id: Ib59cbee0683df165eb1ff163eba82b65ea9761ad
Reviewed-on: https://chromium-review.googlesource.com/981238
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#453}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Composite theme tab background images against default frame color.
This ensures the background images drawn by Tab will not be transparent even if
they are transparent in the original theme. Tab assumes its background is fully
opaque, so that subpixel AA is guaranteed to work.
BUG=819865
TEST=Install theme in bug comment 25, verify background tab text is readable
Change-Id: If75228398b9ae05b275e530c3900b087a5f94139
Reviewed-on: https://chromium-review.googlesource.com/969835
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544403}(cherry picked from commit d0fdb25b296f5aa7440891800c6fcc919331a169)
Reviewed-on: https://chromium-review.googlesource.com/980897
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#452}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[DevTools] Do not reference detached frames from console messages
[email protected], [email protected]
(cherry picked from commit e2c261615e02cfa6404853891b6db310f53bf3d5)
Bug: 805882
Change-Id: Iac5ecc118ddfcc05c0e3de39e13af4e080744031
Reviewed-on: https://chromium-review.googlesource.com/971166
Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544471}
Reviewed-on: https://chromium-review.googlesource.com/981393
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#451}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Avoid shutdown hang in DiscoveryNetworkMonitor
It has been observed that getifaddrs may hang during Chrome shutdown
(most likely only Chrome OS shutdown). This change adds the
CONTINUE_ON_SHUTDOWN trait to the network query tasks posted by
DiscoveryNetworkMonitor so shutdown won't hang.
Bug: 814822
Change-Id: If2273a1612ead7e94142f9684c9a6a04b272cf10
Reviewed-on: https://chromium-review.googlesource.com/976045
Reviewed-by: mark a. foltz <[email protected]>
Commit-Queue: Brandon Tolsch <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545244}(cherry picked from commit 454e04a8da1a8325166a6aa7dbad6f96e8965d5f)
Reviewed-on: https://chromium-review.googlesource.com/981087
Cr-Commit-Position: refs/branch-heads/3359@{#450}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[Reland] Make touch handles relative to scrolling contents
Selection bounds are sent from Blink to CC as part of a commit cycle so
that we can draw touch handles for it. Currently, the selection bounds
are relative to the main graphics layer of a CompositedLayerMapping. In
the case of a scroller, this will be its clip rect - rather than its
scrolling contents layer. Unfortunately, this means that scrolling on
the compositor isn't applied as part of the ToScreen transformation on
the selection bounds so scrolling wont update the selection bounds
location until another Blink commit. This went unnoticed until now
because the root layer was not considered a scroller. The page would
paint into a document-sized layer and the compositor would provide extra
scrolling layers to handle frame scrolling. In this configuration, the
ToScreen transformation from the root layer does include the scroll
offset.
Now that root layer scrolling has been turned on, frame scrolling works
much the same as other scrollers. Thus, this shortcoming is seen on
frame scrolling also.
The solution in this CL is to move the selection bounds rect to be
relative to the scrolling contents layer - if one exists. The ToScreen
transformation done in CC will correctly compensate for any scroll
offset applied in the compositor and touch selection handles stick to
the selection as its scrolled. For the CC side, see
ComputeViewportSelectionBound in layer_tree_impl.cc
Reland Note: This patch makes the RenderedPositionTests run with mock
scrollbars.
[email protected]
Bug: 812048
Change-Id: Ib9eacd14b75b71b4e0d4f0a9b57416800f9dfb91
Reviewed-on: https://chromium-review.googlesource.com/967001
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543803}(cherry picked from commit 6fb0fe3f2c3d3c703b800694623b4f51ae10f717)
Reviewed-on: https://chromium-review.googlesource.com/981014
Cr-Commit-Position: refs/branch-heads/3359@{#449}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Disallow file: URL type sniffing for apps that target P.
WebView was exempted from the change in
https://chromium-review.googlesource.com/853036 to disallow MIME type
sniffing for file: URLs as existing apps rely on this. Check the
application target API level and disallow it for apps that target P or
later.
[email protected]
(cherry picked from commit b6e210a40d04c74aa2bc7dfee2d4f56da8b47e2a)
Bug: 808137
Change-Id: I12378d914caa006c4c9fe321fd4007e990ff95fd
Reviewed-on: https://chromium-review.googlesource.com/911754
Reviewed-by: Tobias Sargeant <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544409}
Reviewed-on: https://chromium-review.googlesource.com/980955
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#448}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[Payments] Do not update UI if it is null
This could happen when show has not been called,
[email protected]
(cherry picked from commit 610ee35516eef9064496111adbe4114fe0e4a226)
Bug: 721362
Change-Id: I1bae92bbf87c9ccc63326d4d1ffd7c798cb4aadc
Reviewed-on: https://chromium-review.googlesource.com/968708
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Ganggui Tang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544042}
Reviewed-on: https://chromium-review.googlesource.com/981129
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#447}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Roll SwiftShader 680bcf5..b04881b
https://swiftshader.googlesource.com/SwiftShader.git/+log/680bcf5..b04881b
BUG=820461
[email protected]
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia3f6ba3223f08c852304b4c9bb08f079642a0cea
Reviewed-on: https://chromium-review.googlesource.com/980597
Reviewed-by: Alexis Hétu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#446}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.61
[email protected]
Change-Id: I1b82a1f583331115552b138992414f2d343ff60b
Reviewed-on: https://chromium-review.googlesource.com/980598
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#445}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Use OOPIF printing for extension/app pages
Some extension/app pages are hosted by guest views, which means they
have nested web contents. This CL checks nested web contents and always
use the outer contents to handle print requests so the entire content
can be printed correctly.
BUG=819583, 447941
Change-Id: I6b45f4867d13cf5141476a7e748e8c0e5d3b0996
Reviewed-on: https://chromium-review.googlesource.com/969949
Commit-Queue: Wei Li <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545077}(cherry picked from commit 5c0b4d1a198bfc165b82ab21e2748dc7b9ea1af4)
Reviewed-on: https://chromium-review.googlesource.com/981085
Reviewed-by: Wei Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#444}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Synchronize access to the AutomationControllerDelegate
The OnFocusChangedEvent() and OnAutomationEvent() methods can be invoked
concurrently. This means that accesses to member variables must be
synchronized using a lock.
Bug: 819792
Change-Id: I22c08d820b0cb877e52e1cb3bb6cd7c5b316dd62
Reviewed-on: https://chromium-review.googlesource.com/971863
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545202}(cherry picked from commit 2862ec0766a231717843687ae7316739d455b890)
Reviewed-on: https://chromium-review.googlesource.com/980895
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#443}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Reland "[3p-Conflicts] Fix whitelisting of modules with matching cert's subject"
This is a reland of fdf8f25c66658ea5a60e7856f9fdfcfaabb1acc1
Original change's description:
> [3p-Conflicts] Fix whitelisting of modules with matching cert's subject
>
> A previous CL was meant to whitelist modules whose cert's subject
> matches the cert's subject of the executable, but the code was added in
> the wrong file.
>
> Move the check from ModuleListFilter where it doesn't belong and move it
> to the ProblematicProgramsUpdater class.
>
> Also added a unit test to make sure the issue is really fixed.
>
> Bug: 819793
> Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6
> Reviewed-on: https://chromium-review.googlesource.com/969601
> Commit-Queue: Patrick Monette <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#545128}
Tbr: [email protected]
Bug: 819793
Change-Id: I67ba5cc75c7d7a0822c79d8e84dfec6cd69b919b
Reviewed-on: https://chromium-review.googlesource.com/976181
Reviewed-by: Patrick Monette <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545158}(cherry picked from commit 4ffc3b1a16173e7899c6c3716452006f7e73a8a7)
Reviewed-on: https://chromium-review.googlesource.com/981084
Cr-Commit-Position: refs/branch-heads/3359@{#442}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Reland "Wire-up the ThirdPartyBlocking group policy"
This is a reland of a54726ff975e09efe95d241091a32954bdd58468
Original change's description:
> Wire-up the ThirdPartyBlocking group policy
>
> To make this happen, the ProblematicProgramsUpdater class needed a
> refactoring. This is because we do not support dynamic refresh of the
> group policy, so its value needed to be cached somehow (as it can still
> change during runtime).
>
> Now, the presence of the ThirdPartyConflictsManager indicates if the
> feature is enabled or not.
>
> Bug: 822399
> Change-Id: Ia9b0b5e52df2c777b343ccc3e524ee17a1ab0e57
> Reviewed-on: https://chromium-review.googlesource.com/964785
> Commit-Queue: Patrick Monette <[email protected]>
> Reviewed-by: Jochen Eisinger <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#544439}
TBR: [email protected], [email protected]
Bug: 822399
Change-Id: Ic9236dc69b3c89d882894c24bd7d172f110dc27a
Reviewed-on: https://chromium-review.googlesource.com/971921
Reviewed-by: Patrick Monette <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544579}(cherry picked from commit aff8f1f817acad3b3d80418cae2391f13dcf9217)
Reviewed-on: https://chromium-review.googlesource.com/981152
Cr-Commit-Position: refs/branch-heads/3359@{#441}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Merge "Fix the conflict between ForceBrowserSignin and ForceEphemeralProfiles policy."
When Chrome clean up ephemeral profiles during launch, create a new profile
if all profiles are deleted and last used profile is guest profile.
Bug: 823890
Change-Id: I64ff6b6230d73df9b97839b0d896fa56710b41e5
Reviewed-on: https://chromium-review.googlesource.com/974123
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545104}(cherry picked from commit b052808737e66eb0f25c296b17ed24725a1002ac)
Reviewed-on: https://chromium-review.googlesource.com/980894
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#440}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Proxy config: Correctly set autoconfiguration URL
This CL:
* Delays setting Proxy.Type to PAC unless a PAC value is set.
* Sets proxyModified_ = true otherwise so that the type is not
overridden on an update.
* Focus the appropriate input field when the proxy type changes.
[email protected]
(cherry picked from commit 1986382b3a837039086e2e77effd890062fe0883)
Bug: 822670
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e9a68fc8982d2286e144e57dfe14dc61fa84b1b
Reviewed-on: https://chromium-review.googlesource.com/974119
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544955}
Reviewed-on: https://chromium-review.googlesource.com/981078
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#439}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Network config: Only call automaticChanged_ on user action
Currently setting automatic_ may trigger automaticChanged_ before
ipConfig_ is set, causing unexpected behavior. We should only trigger
the automaticChanged_ function on user action.
[email protected]
(cherry picked from commit b69bc652e78052d674228215cf1f59a015dfe4b8)
Bug: 823525
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id653bb88bb20b22abd9c85d8c1417b2b8355f5ca
Reviewed-on: https://chromium-review.googlesource.com/974510
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544954}
Reviewed-on: https://chromium-review.googlesource.com/981077
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#438}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Updating XTBs based on .GRDs from branch 3359
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I90e26f07b3740e22df1967921a721eb8e5745205
Reviewed-on: https://chromium-review.googlesource.com/981051
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#437}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.60
[email protected]
Change-Id: I1b9f0480a814bc1a4c4905398f00a0cc98c53c4f
Reviewed-on: https://chromium-review.googlesource.com/980696
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#436}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add browser back accelerator to app list
Changes:
Treat browser back as esc key to navigate back in app list.
BUG=819668
[email protected]
Change-Id: Iccccfe8b424570643c851a73d191e86f66271ced
Reviewed-on: https://chromium-review.googlesource.com/978546
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545576}(cherry picked from commit fdb18c53d0ac7fb87d0f3058cf6a183f432c3ca4)
Reviewed-on: https://chromium-review.googlesource.com/980893
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#435}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}m66 merge: cros: sync unminimized state when attaching state if necessary
changes:
When attaching state, if previous state is unminimized but the stored
window state is minimized, we should sync the state to unminimized state,
which is determined by pre-minimized window show state.
[email protected]
(cherry picked from commit 74e2582a9fd6ad68fe0136c353bef26b93f16b72)
Bug: 823469, 783310, 811352
Test: manual test and added test coverage
Change-Id: I32a4e119e12ebefa015713ac535768880d8b4832
Reviewed-on: https://chromium-review.googlesource.com/969621
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Qiang Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545295}
Reviewed-on: https://chromium-review.googlesource.com/980824
Reviewed-by: Qiang Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#434}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Disable sync consent for non-Gaia users
Now it is displayed for Active Directory users even though sync does not
work for them.
BUG=chromium:814777
TEST=manual
Change-Id: I34ca96cc84f6a630947d9224b954522fface1af1
Reviewed-on: https://chromium-review.googlesource.com/970912
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544891}(cherry picked from commit 000236dec2ccd6ab458fb2bfb307907b2a611ef4)
Reviewed-on: https://chromium-review.googlesource.com/980992
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#433}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}m66 merge: cros: do not clear kPreMinimizedShowStateKey in tablet mode
changes:
Do not clear kPreMinimizedShowStateKey in tablet mode, instead let it
persist before/after tablet mode.
[email protected]
(cherry picked from commit 526cc33b6e631f8b02daac102a91111462143914)
Bug: 823175, 783310
Test: manual test and added test coverage.
Change-Id: Icec1675da9c7d1b5b955ae5c05a71d96547afeee
Reviewed-on: https://chromium-review.googlesource.com/969455
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Qiang Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544789}
Reviewed-on: https://chromium-review.googlesource.com/980794
Reviewed-by: Qiang Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#432}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}m66 merge: cros: do not update caption buttons on minimized window
changes:
Toggle tablet mode is set to update caption buttons to update size
button visibility. In minimized state, frame is not maximized or
fullscreen, thus the size button will be set to MAXIMIZE button not
RESTORE button. This CL avoids such update when window is minimized.
[email protected]
(cherry picked from commit 97524c138aa402ef7fcf06834c37173edde481fc)
Bug: 822890, 783310
Test: manual test and added test coverage
Change-Id: Id35db6dcfbc79e6783caf8706fb83d25402f9c21
Reviewed-on: https://chromium-review.googlesource.com/967414
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Qiang Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545133}
Reviewed-on: https://chromium-review.googlesource.com/980822
Reviewed-by: Qiang Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#431}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Reland "Cache brand code on Windows."
This reverts commit b93f6ee55444118d4dcb237591a5786dbe374e87.
Reason for revert: Reverting showed the relevant metrics regressed, so this change did have the expected improvement.
Original change's description:
> Revert "Cache brand code on Windows."
>
> This reverts commit 9dd1ef42a8a33c5ba09ec645150f580724979b36.
>
> Reason for revert: Latest canary data did not have expected recovery on Omnibox.CharTypedToRepaintLatency and had a regression on Omnibox.CharTypedToRepaintLatency.ToPaint. Reverting to see if that movement is related to this CL or whether there were other changes in the meanwhile.
>
> Original change's description:
> > Cache brand code on Windows.
> >
> > Querying the registry is expensive and contributes to start up time,
> > omnibox query time and idle. Since the brand code is not expected to
> > change on Windows during the course of a session, this CL caches
> > the value, so that future queries are free.
> >
> > This should restore the Omnibox perf that regressed by
> > https://chromium-review.googlesource.com/c/chromium/src/+/824363
> > and also improve perf elsewhere since the caching is now done at
> > a lower level than that change. Since this is expensive only on
> > Windows, the caching is done in the Windows codepath only.
> >
> > Bug: 816698, 806130
> > Change-Id: I458fad29f18b1b1ff2d55b9334ae733fa448eec9
> > Reviewed-on: https://chromium-review.googlesource.com/947522
> > Commit-Queue: Alexei Svitkine <[email protected]>
> > Reviewed-by: Peter Kasting <[email protected]>
> > Reviewed-by: Greg Thompson <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#541009}
>
> [email protected],[email protected],[email protected]
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 816698, 806130
> Change-Id: I09e12c17011f72f25ecb369ca3075e2067013f8a
> Reviewed-on: https://chromium-review.googlesource.com/958012
> Reviewed-by: Alexei Svitkine <[email protected]>
> Commit-Queue: Alexei Svitkine <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#542506}
[email protected], [email protected], [email protected]
(cherry picked from commit cfd298773e9c7e294dea2c643796544e4fcc228e)
Bug: 816698, 806130
Change-Id: Id70bcaa6be1e91240010e74990dd2bd81d673258
Reviewed-on: https://chromium-review.googlesource.com/973581
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544723}
Reviewed-on: https://chromium-review.googlesource.com/980820
Cr-Commit-Position: refs/branch-heads/3359@{#430}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Revert "Encapsulate dismissal cleanup within SettingsNavigationController"
This reverts commit 44aa3a7f98d39d4e8c4defaaaf89d5a341a3885c.
Reason for revert: Causes crbug.com/819999
Original change's description:
> Encapsulate dismissal cleanup within SettingsNavigationController
>
> Bug: 782943
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: If5ebc06503448526b57f42ea6543b5373efe2c90
> Reviewed-on: https://chromium-review.googlesource.com/826024
> Reviewed-by: Mark Cogan <[email protected]>
> Reviewed-by: edchin <[email protected]>
> Commit-Queue: Peter Laurens <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#525372}
[email protected], [email protected], [email protected], [email protected]
(cherry picked from commit 5fe0eef0bea61f01c639a215a2f32efc3537866e)
Bug: 782943
Change-Id: If7daa3faaa515430e5354c9fe0c4654840094696
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/966961
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: edchin <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543826}
Reviewed-on: https://chromium-review.googlesource.com/980916
Cr-Commit-Position: refs/branch-heads/3359@{#429}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix SearchActivityLocationBarLayout URL overlap.
Since SearchActivityLocationBarLayout built off of LocationBarLayout,
it looked fine on tablets but the URL text/buttons overlap problem still
existed for phone. This is caused by a discrepancy in the LayoutParams
used for calculating the URL bar margin between the different location
bar layouts.
This CL makes #getUrlContainerMarginEnd generic so we can use
LinearLayout.LayoutParams where necessary instead of
FrameLayout.LayoutParams. It also adds #getUrlContainerViewsForMargin,
and puts the onus on LocationBarTablet to override this and provide its
unique set of views to be taken into account for margin calculation.
Tested on tablet and phone, in browser and search widget, no more
overlap (including with voice icon always showing in omnibox on phone)
[email protected]
(cherry picked from commit bdef0435815b99df9b368f2c5a02a6eafc34d31d)
Bug: 822136
Change-Id: I73915be984d96e5e4613601b5f6b75ef82afff61
Reviewed-on: https://chromium-review.googlesource.com/966597
Reviewed-by: Maria Khomenko <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Troy Hildebrandt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544874}
Reviewed-on: https://chromium-review.googlesource.com/978834
Cr-Commit-Position: refs/branch-heads/3359@{#428}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[NTP OptOut] Make expand icon right aligned on the screen
+ Make expand icon right aligned for the expandable header with 16dp
right padding
[email protected]
Bug: 821462
Change-Id: I17f24f891013479c3297e062e5e72f04c1257115
Reviewed-on: https://chromium-review.googlesource.com/960925
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Becky Zhou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543258}(cherry picked from commit 5f11e9ed2f06bef9bb64718cfd36918fa47dcc9a)
Reviewed-on: https://chromium-review.googlesource.com/980892
Reviewed-by: Becky Zhou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#427}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Update widget favicon on any FaviconProvider callback
The previous implementation uses a temporary folder to fetch favicon
then move it to the current icon folder.
Should any favicon arrive out of a normal fetch operation, an empty
temporary folder replace the normal one.
As |favicon_provider fetchFaviconAttributesForURL:completion:| can call
completion multiple times (once for the cached icon, once for the newly
fetched one) , this implementation is not reliable.
Change logic removing temporary folder.
All icons are saved in the icon folder.
When a new list is received, icons that correspond to no URL in the list
are deleted.
Whenever a new icon is received, it replaces the previous one.
Bug: 818204
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaf51c4336e55cbc9d1d0093faa6a70d470b66a4d
Reviewed-on: https://chromium-review.googlesource.com/970472
Commit-Queue: Olivier Robin <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544660}(cherry picked from commit fae0a74cddbda921bb57b22c37dbf5525d4d5da2)
Reviewed-on: https://chromium-review.googlesource.com/980754
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#426}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Record gms core version during Chrome startup
The gms core version is used to determine if a crash happens due to gms
core update. This change will save the previous and current gms core version
during startup. When a crash happens, it compares the two versions and report
the crash if the two versions are same (which means gms core is not updated
and it's a real crash)
Bug: 785306
Change-Id: I18ab68d7b1c1e227f82645fba5e742ad1da0f4a0
Reviewed-on: https://chromium-review.googlesource.com/971407
Commit-Queue: Ran Ji <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544896}(cherry picked from commit b5891adf8cad16879a81ebca68c654a3778d7f77)
Reviewed-on: https://chromium-review.googlesource.com/980573
Cr-Commit-Position: refs/branch-heads/3359@{#425}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix Print Preview to System dialog bug
Update PrintJob::pdf_page_mapping_ so that PDF pages not in the
user's selection are ignored instead of causing the print job to be
cancelled.
Also remove some comments that are significantly outdated, and
caused confusion while investigating the bug.
Bug: 823876
Change-Id: Id6c1c3acb67c4d460cffa937f7a9b87eda402a88
Reviewed-on: https://chromium-review.googlesource.com/974042
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545173}(cherry picked from commit 190d38b53a6294ca5ecb795e70520e585ed2128c)
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/980572
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#424}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}SVG child of html element can not act as display:contents.
SVG elements like <g> do not generate a box when styled as
display:contents in an SVG context. However, when they are children of
HTML elements, they should not generate boxes, and not act as
display:contents.
If treated as display:contents, text child nodes would have SVG text
boxes generated for them causing crashes.
Bug: 820779, 820834
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1ec7e3af158daa9d56160123cc3c25f6ee3eda62
Reviewed-on: https://chromium-review.googlesource.com/958912
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542752}(cherry picked from commit aa7d638bd0956c1c3eb2faf814a18f850bc0d2c7)
Reviewed-on: https://chromium-review.googlesource.com/980112
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#423}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Restore cross-origin reporting to the XSS Auditor.
[email protected]
(cherry picked from commit 71f7b2b768f7edafdd46553e0c42376ddc96f117)
Bug: 811440, 823624
Change-Id: I51253d721b30255f8270eacb67d5bcf629f90da1
Reviewed-on: https://chromium-review.googlesource.com/949046
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541173}
Reviewed-on: https://chromium-review.googlesource.com/979654
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#422}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add null-check of notification view on right-clicking
If the notification view is invalid state, FindVisibleNotificationById
may returns null and it caused the crash. This CL fixes it.
[email protected]
(cherry picked from commit 9bf1f026927f07b0100d60a184a4026b9633f8a2)
Bug: 824039
Test: None
Change-Id: I0ebc0ddd0cd77c9af235bef07a92fe635135e96c
Reviewed-on: https://chromium-review.googlesource.com/974665
Reviewed-by: Tetsui Ohkubo <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545020}
Reviewed-on: https://chromium-review.googlesource.com/979742
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#421}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.59
[email protected]
Change-Id: I631b44d271a81f0c4bf280c35d8d1795938496fe
Reviewed-on: https://chromium-review.googlesource.com/979457
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#420}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.58
[email protected]
Change-Id: I970059c5eccd70bd047306221a256ecf484c5c63
Reviewed-on: https://chromium-review.googlesource.com/979139
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#419}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Let `about:blank#ref` also be classified as initial empty document.
Before this CL, content::FrameTreeNode used to classify only the literal
`about:blank` as the URL corresponding to the initial empty document.
However, navigations from the initial empty document to URLs such as
`about:blank#ref` are same-document and therefore re-use the initial
empty document, so committing any such same-document navigations should
not be considered "real loads" by FrameTreeNode (given they are not
considered "real loads" by Blink).
This CL changes FrameTreeNode::SetCurrentURL() to use !IsAboutBlank() to
determine whether the first real load is currently taking place in a
frame, that is, whether it is a first time a URL is being committed that
is not the initial empty document (modulo an optional #fragment).
Bug: 821022, 729021
Change-Id: I040a11f58bf27174e0c450377f8cd81a7abeac70
Reviewed-on: https://chromium-review.googlesource.com/958925
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542645}(cherry picked from commit c8a7cccf6d7bd53821b7e860446d3768ff0aaa91)
Reviewed-on: https://chromium-review.googlesource.com/979652
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#418}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.57
[email protected]
Change-Id: I73c1c583c3cfb50840a601a494dc2b9e4a57c7a5
Reviewed-on: https://chromium-review.googlesource.com/979456
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#417}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.56
[email protected]
Change-Id: Iba1a2169b91f0c23f0fcf854e2aa9b6af625a0a9
Reviewed-on: https://chromium-review.googlesource.com/979555
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#416}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}M66 Merge: cros: Display alternative string if no dom_key mapping found in KSV
KeycodeConverter::DomKeyToKeyString cannot show correct string if the
dom_key has no mapping. This cl handles this corner case to display
alternative string in Keyboard Shortcut Helper (KSV).
[email protected]
Bug: 824495
Test: On device with Swedish keyboard layout.
Change-Id: I3c54941b89ce34244c8b69d4a905cb1ddbdffb11
Reviewed-on: https://chromium-review.googlesource.com/974474
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#545636}(cherry picked from commit 084cdb25dac3ebc36caba5f851b778863bb17038)
Reviewed-on: https://chromium-review.googlesource.com/979412
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#415}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.55
[email protected]
Change-Id: If00ef67ba8f0876d4fcc614882763c208e25ed4c
Reviewed-on: https://chromium-review.googlesource.com/979197
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#414}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.54
[email protected]
Change-Id: Ib5051fa9d2a46ba91822ab555dd4d1af52259aa8
Reviewed-on: https://chromium-review.googlesource.com/979272
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#413}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Let an MD download shelf item be dragged without bringing its window to the front.
Bug: 822416
Change-Id: Ic3331be8d13982075e06b11031e6cbe147c68927
Reviewed-on: https://chromium-review.googlesource.com/969950
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544478}(cherry picked from commit 37046981bdfd58a262a2b7f1295eab70c22f1331)
Reviewed-on: https://chromium-review.googlesource.com/979172
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#412}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}macOS Sandbox: Add timezone subpath to profile.
This CL allows access to the entire timezone folder subpath, as macOS
has changed the layout of the timezone data on disk.
Bug: 818249
Change-Id: Ied9b81977e0453616b72e74da86d4d67c211785b
Reviewed-on: https://chromium-review.googlesource.com/969617
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Greg Kerr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544197}(cherry picked from commit 3d6ecf141a0157cfd83844aef94630b2a6de8284)
Reviewed-on: https://chromium-review.googlesource.com/978591
Reviewed-by: Greg Kerr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#411}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Enable Credit Card Autofill Touch Bar
(cherry picked from commit 3ebc484035ac2802820dd76ae9d488f567700508)
Bug: 792276
Change-Id: I406f6ccee9df505b2ba7bf6c7585160a6b56173a
Reviewed-on: https://chromium-review.googlesource.com/969943
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Sarah Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544396}
Reviewed-on: https://chromium-review.googlesource.com/978939
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#410}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Check validity of WorkletGlobalScope in AudioWorkletHandler::Process()
When the page is reloaded rapidly and repeatedly, the
AudioWorkletGlobalScope gets destroyed in rare occasions while the
worker thread is still running.
This adds a check in AudioWorkletHandler::Process() so the
AudioWorkletNode can bypass and output silence when there is no
WorkletGlobalScope anymore. This is harmless because it only can happen
when the tab is reloaded or shut down.
[email protected]
(cherry picked from commit 539f04926d24675b80d041dfdc59e18f1596b992)
Bug: 822725, 822701
Test: The repro case did not crash during 1 hour run.
Change-Id: I98ff8aa77644cf354c801800171fa45e0ed8ee75
Reviewed-on: https://chromium-review.googlesource.com/967156
Commit-Queue: Hongchan Choi <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Raymond Toy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544486}
Reviewed-on: https://chromium-review.googlesource.com/978848
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#409}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Merge: Wait for animated wallpaper changes to finish before suspending displays
PowerEventObserver delays display suspend until lock screen UI is shown
and compositors submit enough frames to know the UI changes have reached
displays.
This does not account for wallpaper changes due to screen lock:
* On screen lock, the active wallpaper will be changed with its blurred
version.
* If screen lock changes the active user (e.g. if the screen is locked
from the secondary user), the wallpaper will change to the new
active user's blurred wallpaper.
Given that PowerEventObserver does not ensure wallpaper switch is done
before it stops drawing to the display, the first frame shown on the
device resume might still contain the UI from before wallpaper change.
This changes PowerEventObserver to additionally wait for any active
wallpaper changes (which can be detected by checking
WallpaperWidgetController::IsAnimating - set while wallpaper widget is
being changed) to finish before it starts waiting for compositor frames
to get composited, thus ensuring the correct wallpaper is set when the
display/compositing is suspended.
Adds the following methods to WallpaperWidgetController:
* AddPendingAnimationEndCallback - to provide a way for
PowerEventObserver to get notified when the pending wallpaper change
completes
* EndPendingAnimation which can be used to force immediate wallpaper
change when device starts suspending (and prevents suspend flow from
being blocked on unnecessarily waiting for new wallpaper animation)
BUG=820436,803762
[email protected]
(cherry picked from commit c7dbb870ac431aa1767e2e0c9a68106502f0571e)
Change-Id: Iad2074280ebba740b95c50b9d60a028bf5a0d45c
Reviewed-on: https://chromium-review.googlesource.com/956757
Reviewed-by: Dan Erat <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542945}
Reviewed-on: https://chromium-review.googlesource.com/978842
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#408}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Remove pointer lock tests from merged CL.
These tests depend on changes made after the branch.
[email protected]
Bug: 825317
Change-Id: Ibb38fe21cd5692992ffb3dd3f6fc2c4c9ccc549a
Reviewed-on: https://chromium-review.googlesource.com/978672
Reviewed-by: Lucas Gadani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#407}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Respect primary user DevTools policy.
If DevTools are disabled for primary profile,
they shouldn't be opened for all other profiles as well.
Bug: 817943
Change-Id: I3b83abf3a43f74f0003980bfcfcf4cd256b73d8f
Reviewed-on: https://chromium-review.googlesource.com/957047
Commit-Queue: Sergey Poromov <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543419}(cherry picked from commit ead71c7d5089cb5765d1f2dbf3e16ed509eb62ff)
Reviewed-on: https://chromium-review.googlesource.com/978681
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#406}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[Download notifications] Fix sticky notification on P.
When small files are downloaded on Pixel 2 running Android P, the call
to stop the foreground is called to closely to the call to start the
foreground, resulting in a race condition that causes the notification
to continue to be pinned to the foreground and remain sticky. This issue
has been reported to the Android notifications team, but this CL
provides a workaround that waits a few milliseconds after the foreground
has started before stoppping it.
[email protected]
(cherry picked from commit d29aaee1e875a8ceb0f17f248df3a38d4afc7df6)
Bug: b/74236718
Change-Id: I6f24cb5e8b84b4c3f6868c00aa4ce1797141ea87
Reviewed-on: https://chromium-review.googlesource.com/969752
Commit-Queue: Joy Ming <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544798}
Reviewed-on: https://chromium-review.googlesource.com/978654
Reviewed-by: Joy Ming <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#405}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Expand null pointer coverage in DefaultBrowserInfo
Cover another case of PackageManager.resolveActivity() and preemptively
catch the Android API PackageManager.queryIntentActivities().
BUG=795934
[email protected]
Change-Id: I5705dbee325b5a9cabebe01cd6e18ddf711bf8e7
Reviewed-on: https://chromium-review.googlesource.com/972345
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544933}(cherry picked from commit fa0031d87fd58189b7e341b7b7be793fbd296347)
Reviewed-on: https://chromium-review.googlesource.com/978582
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#404}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Defocus the omnibox when switching tabs.
CL 905511 introduced a bug where previously BVC was defocusing the
omnibox by sending selectedTabChanged to the toolbar, but this was
broken.
Since the location bar now directly observes the webstate with its
mediator, use this to defocus omnibox when the webstate changes.
Bug: 813944
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibc67faaae115032e0a3c6e6b5e3879d7e52f8f0f
Reviewed-on: https://chromium-review.googlesource.com/960663
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542817}(cherry picked from commit d21e3816b10d22501455fea1468d56df514ea442)
Reviewed-on: https://chromium-review.googlesource.com/978187
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#403}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}M66 Merge: cros: Fix one key error in KSV.
This cl fixes one key error in Keyboard Shortcut Viewer (KSV).
[email protected]
Bug: 823939
Test: manual test.
Change-Id: Iffbed74601548e5980ec36bfbdc51c30d9b3304b
Reviewed-on: https://chromium-review.googlesource.com/972167
Reviewed-by: Qiang Xu <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544600}(cherry picked from commit 1e8a681519729bd5dee443ad2576d2b895aa0773)
Reviewed-on: https://chromium-review.googlesource.com/978454
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#402}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Stop disabling web usage if closing incognito tabs
It is not necessary to disable web usage when clearing
off-the-record browsing data (as the WebKit bug is not
exercised in that case).
Bug: 821753
Change-Id: I62b011ac182f8e8b7107109a23ac8102da44e574
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/970466
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544357}(cherry picked from commit 7d6ceb1e0f8e3dd28ac71d70988a687ceadbc5e3)
Reviewed-on: https://chromium-review.googlesource.com/978249
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#401}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add mechanism to test inner WebContents from a content_browsertest.
Write a test of mouse_lock_widget_ cleanup. Fix WebContentsImpl so that it passes.
Bug: 820593, 821187
Change-Id: I99cd6b8c728f7e4501205574db8d17b206f2856e
Reviewed-on: https://chromium-review.googlesource.com/957479
Commit-Queue: Nick Carter <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Lucas Gadani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542865}(cherry picked from commit d73635b06b597ee7ef97b416e734025a48d37fc3)
Reviewed-on: https://chromium-review.googlesource.com/978482
Cr-Commit-Position: refs/branch-heads/3359@{#400}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Unlock mouse when hiding widget.
(cherry picked from commit dd328daaa91ac6329aef5144bce2dedd36cac710)
Bug: 822690
Change-Id: I593a80ad739cbb39c5090a47cfbcb2872622785a
Reviewed-on: https://chromium-review.googlesource.com/969456
Reviewed-by: Nick Carter <[email protected]>
Commit-Queue: Lucas Gadani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544191}
Reviewed-on: https://chromium-review.googlesource.com/978501
Reviewed-by: Lucas Gadani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#399}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[iOS] Adding sentinel error histogram
Adding an histogram to log the error while creating the sentinel file.
Manual cherry-pick from https://chromium-review.googlesource.com/c/chromium/src/+/969261 to branch 3359.
[email protected],[email protected],[email protected]
Bug: 822806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I35606d6a2d497e10e2a0e1d2bc88192f570bb810
Reviewed-on: https://chromium-review.googlesource.com/978168
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#398}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}DevTools: check Host header for being IP or localhost when connecting over RDP.
[email protected]
(cherry picked from commit ba1513223e47b62ed53b61518b7f7b82ad1d8ccd)
Bug: 813540
Change-Id: I9338aa2475c15090b8a60729be25502eb866efb7
Reviewed-on: https://chromium-review.googlesource.com/952522
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Pavel Feldman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541547}
Reviewed-on: https://chromium-review.googlesource.com/978444
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#397}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Merge restoring the help icon after password search
This merges the functionality below and uses the local waiting function
instead of the global one which was introduced in a different CL but has
equal meaning.
Original message:
If the screen space doesn't suffice for multiple action bar icons, the
help icon will be pushed to the Overflow menu which is what happens when
a search is triggered.
Even after the search is closed, the item wasn't moved back but stayed
in the overflow menu. With this CL, we ensure that the help icon stays
in the action bar if sufficient space is available.
(cherry picked from commit fb1c49885f68ffa9f23cb22e8130355c453b5c4a)
Bug: 821687, 824908
Change-Id: Ib89ddcf85e389db2311a4054b94e3edf0b38e226
Reviewed-on: https://chromium-review.googlesource.com/962425
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Friedrich Horschig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543334}
Reviewed-on: https://chromium-review.googlesource.com/977924
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#396}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Enforce early release of storage image in CanvasAsyncBlobCreator dtor
[email protected], [email protected]
(cherry picked from commit 8fe039154b1c022e97ea9a7bbb1169b23ca483f7)
Bug: 823260
Change-Id: I9851d6ff38c36c16edbdfa1cb715957e8e6e3eed
Reviewed-on: https://chromium-review.googlesource.com/973554
Reviewed-by: Mohammad Reza Zakerinasab <[email protected]>
Commit-Queue: Mohammad Reza Zakerinasab <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544807}
Reviewed-on: https://chromium-review.googlesource.com/977889
Cr-Commit-Position: refs/branch-heads/3359@{#395}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Revert "[iOS] Adding sentinel error histogram"
This reverts commit fdc27917d77732d07d228e2fa9ffd155c6e820a5.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [iOS] Adding sentinel error histogram
>
> Adding an histogram to log the error while creating the sentinel file.
>
> [email protected]
>
> (cherry picked from commit 46c04be311f3f2885f0ad4e135cf985a2c019926)
>
> Bug: 822806
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I5eff6df7986837fde5cb168cb3adb3b198e5afd8
> Reviewed-on: https://chromium-review.googlesource.com/969261
> Reviewed-by: Gayane Petrosyan <[email protected]>
> Reviewed-by: Mark Mentovai <[email protected]>
> Reviewed-by: Peter Lee <[email protected]>
> Commit-Queue: Jérôme Lebel <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#544776}
> Reviewed-on: https://chromium-review.googlesource.com/978204
> Reviewed-by: Jérôme Lebel <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3359@{#393}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I517bb4d38bf9a7677b5f0b2af993762e0e98111b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/977972
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#394}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[iOS] Adding sentinel error histogram
Adding an histogram to log the error while creating the sentinel file.
[email protected]
(cherry picked from commit 46c04be311f3f2885f0ad4e135cf985a2c019926)
Bug: 822806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5eff6df7986837fde5cb168cb3adb3b198e5afd8
Reviewed-on: https://chromium-review.googlesource.com/969261
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544776}
Reviewed-on: https://chromium-review.googlesource.com/978204
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#393}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}v8binding: Makes ResizeObserver ActiveScriptWrappable.
Right after the target Element gets detached from the document tree,
the last size change event is dispatched to ResizeObserver. At this
moment, the target Element is already detached from the document and
we cannot rely on the wrapper-tracing path of:
Document --> Element --> ElementRareData --> ResizeObserver
So, we need another path to perform the wrapper-tracing for
ResizeObserver.
This patch makes ResizeObserver ActiveScriptWrappable, so that the
following path of wrapper-tracing will be available:
V8 wrapper of ResizeObserver --> blink::ResizeObserver
I confirmed that this patch fixes the crash issue at a certain
website.
FYI: You find some discussion at https://crrev.com/c/960482 .
Bug: 815058
Change-Id: I43c4695304f7f54b819f0c2dfbc4a5a8cf9df8f7
Reviewed-on: https://chromium-review.googlesource.com/964075
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Aleks Totic <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543997}(cherry picked from commit d96d89c6730a1248607195c8726f410e34644c45)
Reviewed-on: https://chromium-review.googlesource.com/977364
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#392}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}MTP: Fix corruption of source file path of copy operation.
Source file's path was passed by a pointer to string, but the string can
be destroyed since OpenFileDescriptor() runs asynchronously.
When it is destroyed, finding source file fails then copy fails.
This CL fixes it by passing a copy of FilePath.
Bug: 810119
Test: Manually tested following the bug description.
Change-Id: I1be1b9375ac601a66996ce2fa179e36a95cc4dd4
Reviewed-on: https://chromium-review.googlesource.com/970981
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Naoki Fukino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544764}(cherry picked from commit 76a76b644f6c53e8296f42bdcae69858118b5c1d)
Reviewed-on: https://chromium-review.googlesource.com/977187
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#391}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}oopif: Fix synthesized mouse enter/exit events.
SendMouseEnterOrLeaveEvents() expects the input-event to be in the
root-view's coordinate space. But it was actually receiving the event in
the target view's coordinate space. As a result, the synthesized mouse
move/exit events were being sent to the view's with the wrong
coordinates. This change fixes that, by making sure the input-event is
still in the root-view's coordinate space when it goes to
SendMouseEnterOrLeaveEvents().
BUG=822905
Change-Id: I802c079ea57dabc47184763aad0cfb7026afdb2e
Reviewed-on: https://chromium-review.googlesource.com/972671
Reviewed-by: Ria Jiang <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544744}(cherry picked from commit 1e28344079a3a94167f6e21e0448bc4593c012a8)
Reviewed-on: https://chromium-review.googlesource.com/977121
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#390}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Chrome OS OOBE: Add bindings for the sync settings screen.
This Cl adds support for "Review sync settings" checkbox.
[email protected]
(cherry picked from commit 36c7ca6219379bf6e17c5b711aa7065cfa89c812)
Bug: 794371
Change-Id: I3b0bd9b7319c0409bef569ab1eab05e071255d75
Reviewed-on: https://chromium-review.googlesource.com/966977
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544588}
Reviewed-on: https://chromium-review.googlesource.com/977058
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#389}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.53
[email protected]
Change-Id: I92b89e63ff0c5cda41bba8bffc97d4ea26123384
Reviewed-on: https://chromium-review.googlesource.com/977281
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#388}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.52
[email protected]
Change-Id: I5401dd200c7d89a5fc03187cf2af33b32be7d817
Reviewed-on: https://chromium-review.googlesource.com/977261
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#387}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix crash on calling WebContentsAccessibility
The reported crash indicates that WebContentsAccessibility.fromWebContents()
is being called when mWebContents is null. This CL ensures the API won't be
called if mWebContents is already nulled out. Also handled ImeAdapter case
for similar, potential issue.
[email protected]
Bug: 821692
Change-Id: I8c2dd3e443394e1f3d100b46596f830326de2f8f
Reviewed-on: https://chromium-review.googlesource.com/965303
Reviewed-by: Bo <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544224}(cherry picked from commit 9e38374522c3764db410d3edaedd2dfb89f09fdc)
Reviewed-on: https://chromium-review.googlesource.com/977241
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#386}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[Merge to 3359] Allow display:none iframes to have children during printing.
Although it is not spec compliant, many websites intentionally call
Window.print() on display:none iframes.
Bug: 819327
Change-Id: I02c2b8c9dad0cb6c8c4601c6104986aceb469bba
Reviewed-on: https://chromium-review.googlesource.com/964610
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543734}(cherry picked from commit cf1960fc5c3a6e81b9d1325328e828d2bb01179a)
Reviewed-on: https://chromium-review.googlesource.com/976442
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#385}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix blank tabs after eviction.
This CL fixes a race whereby tabs can be blank after frame eviction.
There was an ordering problem, where a late CompositorFrame from the
evicted frame would cause a Surface to be resurrected and then
immediately re-evicted. The second eviction would fail because
CompositorFrameSinkSupport didn't know the surface had been resurrected
yet.
Also change tests to use mock version of FrameSinkManagerClient to
test eviction in the same call stack as activation.
[email protected]
(cherry picked from commit df985d6aede925cb81021f1fc285955f060451b8)
Bug: 821855
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iddc0f6826956ccd89e25f8fca9513d237874894b
Reviewed-on: https://chromium-review.googlesource.com/971642
Commit-Queue: kylechar <[email protected]>
Reviewed-by: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544575}
Reviewed-on: https://chromium-review.googlesource.com/976532
Reviewed-by: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#384}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.51
[email protected]
Change-Id: Ic4f6b3c4a321fe4949fde6a26ba1fbdb2392be9b
Reviewed-on: https://chromium-review.googlesource.com/976530
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#383}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Revert "Restore help icon after password search"
This reverts commit 0cbe3b9d4be14ce62734e0d0d1273e1b0968d28b.
Reason for revert: Missing ViewGroup import in test. crbug.com/824908
Original change's description:
> Restore help icon after password search
>
> If the screen space doesn't suffice for multiple action bar icons, the
> help icon will be pushed to the Overflow menu which is what happens when
> a search is triggered.
> Even after the search is closed, the item wasn't moved back but stayed
> in the overflow menu. With this CL, we ensure that the help icon stays
> in the action bar if sufficient space is available.
>
> Bug: 821687
> Change-Id: Icb438f9988f9114f563e920ddc95f27ebdac5434
> Reviewed-on: https://chromium-review.googlesource.com/962425
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Friedrich Horschig <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#543334}(cherry picked from commit fb1c49885f68ffa9f23cb22e8130355c453b5c4a)
> Reviewed-on: https://chromium-review.googlesource.com/974383
> Reviewed-by: Friedrich Horschig <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3359@{#377}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[email protected]
Change-Id: I6d68af4c9bea50b36f61babcfb3005b07b4142e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821687
Reviewed-on: https://chromium-review.googlesource.com/976421
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#382}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Update page visibility for subframes using swapped-out RenderViews (Merge to M66)
When a main frame transitions from a local to remote frame, the
RFHM::CommitPending() changes the corresponding RenderView from active
to swapped out, and it also sends a ViewMsg_WasHidden to the
corresponding RenderWidget, which updates visibility state on
blink::Page to hidden.
Later, if that swapped-out RenderView is used by a subframe (e.g.,
when A window.opens B(A2), that subframe is A2), BeginMainFrame for
the subframe would go down an incorrect path because it would think
that the Page is hidden, preventing the subframe from painting.
This CL ensures that before we show the subframe, we update Page
visibility in the subframe's process.
[email protected]
(cherry picked from commit b13f850c7ed32867ae9fd93cfe3fe72b8cb4da0b)
Bug: 638375
Change-Id: I0893f0c6e58798b641ec8e76b28566a92fe2070f
Reviewed-on: https://chromium-review.googlesource.com/966988
Reviewed-by: Lucas Gadani <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544425}
Reviewed-on: https://chromium-review.googlesource.com/976334
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#381}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.50
[email protected]
Change-Id: I8192eb3cedea2db55658f7a4f15009d38e2567ca
Reviewed-on: https://chromium-review.googlesource.com/976043
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#380}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Vertically center action buttons on Custom Tab toolbar.
If the custom action icon is particularly small or the toolbar
particularly tall, it would otherwise appear top-aligned.
Bug: 819600
Change-Id: I7dede3da471d4b51b8ce0c290a53397092cd514b
Reviewed-on: https://chromium-review.googlesource.com/955642
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Bernhard Bauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541803}(cherry picked from commit 94562a50ac26c4ce45baf89e351dc6f82eff4a52)
Reviewed-on: https://chromium-review.googlesource.com/975141
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#379}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add missing import statement in CustomTabActivity
Change-Id: I8f326c11fad5efc59d1fc1543e3c10bf812f5337
Reviewed-on: https://chromium-review.googlesource.com/974405
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#378}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Restore help icon after password search
If the screen space doesn't suffice for multiple action bar icons, the
help icon will be pushed to the Overflow menu which is what happens when
a search is triggered.
Even after the search is closed, the item wasn't moved back but stayed
in the overflow menu. With this CL, we ensure that the help icon stays
in the action bar if sufficient space is available.
Bug: 821687
Change-Id: Icb438f9988f9114f563e920ddc95f27ebdac5434
Reviewed-on: https://chromium-review.googlesource.com/962425
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Friedrich Horschig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543334}(cherry picked from commit fb1c49885f68ffa9f23cb22e8130355c453b5c4a)
Reviewed-on: https://chromium-review.googlesource.com/974383
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#377}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[M66] service worker: Jumbo + RenderViewHostTestEnabler fixes.
This merges the following CLs from bug 813749. The net changes are:
* Fix Jumbo build by renaming PostMessage to PostMessageToServiceWorker
* Fix unit tests by using RenderViewHostTestEnabler
[ServiceWorker] Fix jumbo+Win compilation error related to 'PostMessage'
PostMessage is a macro in Windows and depending on whether Windows
headers have been included or not, PostMessage will either be treated as
PostMessage or PostMessageW.
However, our previous CL
https://chromium-review.googlesource.com/c/chromium/src/+/933867
introduced a method just named as 'PostMessage', this caused some
compile/link errors on Windows platform.
This CL renames the method to 'PostMessageToServiceWorker' to fix this.
BUG=772713,813749
[email protected] for mechanical renaming in the mojom file
Change-Id: I16241052e3deb8ba4a5fbb777037eca9904c6279
Reviewed-on: https://chromium-review.googlesource.com/959688
Commit-Queue: Han Leon <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#542741}
(cherry picked from commit 29f8841c033d4293a362d9123fefc880d7844bf2)
[ServiceWorker] Prepare a RenderViewHostTestEnabler to create Test* instead of real one
This is to fix the 2 unit tests on CFI builds:
ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient
ServiceWorkerHandleTest.DispatchExtendableMessageEvent_Fail
BUG=820620,772713,813749
Change-Id: Iaf4a6f4a464fe97a44f63bf2ca5a1a2e04400b9b
Reviewed-on: https://chromium-review.googlesource.com/958126
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Commit-Queue: Han Leon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#542712}
(cherry picked from commit 733a5fa4ef949b7e3357122ffcd58c17eb172c68)
Fix jumbo+Win compilation error related to the PostMessage macro
PostMessage is a macro in Windows and depending on whether Windows
headers have been included or not, PostMessage will either be
treated as PostMessage or PostMessageW. We use a special header
windows_types.h to ensure that the macro is always defined
so that there will be no compilation or linking issues missing
either PostMessage or PostMessageW objects.
Bug: 772713,813749
[email protected]
(cherry picked from commit c24cb7fb7bc50d9bcdabfe9e82670a418b438039)
Change-Id: I0012774f347ef2e257bc87b4492f58c7be464f78
Reviewed-on: https://chromium-review.googlesource.com/957028
Reviewed-by: Daniel Bratell <[email protected]>
Commit-Queue: Daniel Bratell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542092}
Reviewed-on: https://chromium-review.googlesource.com/974724
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#376}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.49
[email protected]
Change-Id: I673396f446709b72062dc30f900b7c714b890ba7
Reviewed-on: https://chromium-review.googlesource.com/974742
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#375}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.48
[email protected]
Change-Id: I5fde33dff81e61af532f585f30e415f61b712da9
Reviewed-on: https://chromium-review.googlesource.com/974707
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#374}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Network config: Unset AutoConnect by default
[email protected]
(cherry picked from commit c8f6e70a44ec23c7ea5f44af85085cbf50d99ff7)
Bug: 819148
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc7a6a4c695c4a6b53989689c245fa704b6b3204
Reviewed-on: https://chromium-review.googlesource.com/973920
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544906}
Reviewed-on: https://chromium-review.googlesource.com/974130
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#373}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Update PendingStateUpdater member variable for loss of network
PendingStateUpdater.requests_pending_another_download_ should also
be updated to false whenever a request is marked as pending network.
This is needed because the network may have been lost when
RequestCoordinator was not trying to offline a page. This change
prevents pending requests from being stuck as "Waiting for network..."
when a request is picked for offlining.
Bug: 817702
Change-Id: I963ba634c60c47093bdc4aa59a39c14a505ee891
Reviewed-on: https://chromium-review.googlesource.com/945279
Reviewed-by: Cathy Li <[email protected]>
Commit-Queue: Candice Sy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540590}(cherry picked from commit 9c44f70ba71ac34627a109afc1b12d5de3db67f2)
Reviewed-on: https://chromium-review.googlesource.com/974127
Cr-Commit-Position: refs/branch-heads/3359@{#372}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Updating XTBs based on .GRDs from branch 3359
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icf5df89bb7dd8f7598f841af1e30c984c6484d74
Reviewed-on: https://chromium-review.googlesource.com/974477
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#371}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Close AndroidOverlay client to prevent leaked mojo routers.
Previously, DialogOverlayImpl did not close the overlay client when
cleaning up. This caused the mojo router in |mClient| to be closed
only when the client was GC'd, and issued warnings in logcat.
Now, DialogOverlayImpl closes |mClient| properly.
AndroidOverlayProviderImpl also closes the client if it fails before
providing the client to a DialogOverlayImpl.
Bug: 822798
Change-Id: I57657b4e1bc77e07e79a1182c5467e243d947002
Reviewed-on: https://chromium-review.googlesource.com/966868
Reviewed-by: Bo <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543770}(cherry picked from commit d1414246cfe6782f2906c186021526fbf69cee75)
Reviewed-on: https://chromium-review.googlesource.com/974088
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#370}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}arc: Fix PS and Kiosk restart.
Return true for public accounts and ARC kiosks filesystem compatibility
check as they might have only ext4.
Without this check it fails to start after browser crash as
compatibility info is stored in RAM.
Bug: 812594
Test: Trybots, new unittest.
Change-Id: Ia73b25f6d087f6076b3bdbdc13b3a0262d31b13d
Reviewed-on: https://chromium-review.googlesource.com/968843
Commit-Queue: Sergey Poromov <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544434}(cherry picked from commit 3fd13565e23c7325cbd0f5a387ccd8419908abda)
Reviewed-on: https://chromium-review.googlesource.com/974381
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#369}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}M66 backport: cros: Speculative fix for shutdown crash in SetShelfBehaviorsFromPrefs
ShelfController outlives TabletModeController. However, it looks like
Shell destruction can trigger display layout changes, which are
observed by ShelfController. These may be dependent on screen rotation
animation state, and hence are hard to repro.
Add a null check to avoid the crash, since this is simple and safe to
backport. A followup CL will clean up the shutdown ordering.
Bug: 817522
Change-Id: I7d02faf6179768457e56dff8bfdf2a74c8701b4c
Reviewed-on: https://chromium-review.googlesource.com/966785
Reviewed-by: Weidong Guo <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543748}(cherry picked from commit 46feb7378144d7123e22fbe87f485f7b33fba841)
Reviewed-on: https://chromium-review.googlesource.com/974204
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#368}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Update BasicNativePage default color for modern
BUG=823206
Change-Id: I90280a4048c90a0dbce9bafe590de4c6e13c14a8
Reviewed-on: https://chromium-review.googlesource.com/969287
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544215}(cherry picked from commit 3a230167d44364da565dc0778ae2e593622fc24e)
Reviewed-on: https://chromium-review.googlesource.com/974341
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#367}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[Chrome Modern] Updates colors for recent tabs page background
Other visual changes coming in later CLs
Bug: 820648
Change-Id: I1ac47a4f45af906cf1ba53f3304dd2d55bc1c684
Reviewed-on: https://chromium-review.googlesource.com/959145
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544159}(cherry picked from commit dd308ef25e3dc2c8ee7d19b9171e59f42a95b0e5)
Reviewed-on: https://chromium-review.googlesource.com/974203
Cr-Commit-Position: refs/branch-heads/3359@{#366}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Add uma to log space status when installing WebAPK
Change-Id: Ibae84f3215ae29e2154df538f4ff7e86f72118b5
Reviewed-on: https://chromium-review.googlesource.com/959750
Commit-Queue: Ran Ji <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543003}(cherry picked from commit ebf30557b76f27757dbdaa1a03e7104fd7ce29c5)
Reviewed-on: https://chromium-review.googlesource.com/974202
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#365}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[merge to m66] Flush pending OrderingBarrier in PpapiCommandBufferProxy::EnsureWorkVisible
The semantics of EnsureWorkVisible are that it is expected to validate any
OrderingBarrier or Flush that was called prior to it. This is necessary so that
GenSyncTokenCHROMIUM correctly generates validated sync tokens.
Bug: 797137
Change-Id: I2b012328b79ea038eb02f82c19d5faf239aa43b2
Reviewed-on: https://chromium-review.googlesource.com/970164
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544314}(cherry picked from commit 6d842dc59de7b259298e68d4b3ce73f7e058767d)
Reviewed-on: https://chromium-review.googlesource.com/972503
Reviewed-by: Josafat Garcia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#364}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Updating XTBs based on .GRDs from branch 3359
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I588cf2320e2ca43b9e0639adea2c1ee67893f37e
Reviewed-on: https://chromium-review.googlesource.com/973583
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#363}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Reland "[merge M66] Update Safe Browsing Related Policy"
This is a reland of b0b91c73f09a4fc78e6fd15432f6590259a4daa0
Changes:
1. revert string changes, only keep version change
2. Remove details of related policies from policy_test_cases.json
Original change's description:
> [merge M66] Update Safe Browsing Related Policy
>
> 1. Move all safe browsing realted policy to M67
> 2. Add password form guideline to PasswordProtectionLoginURLs and
> PasswordProtectionChangePasswordURL settings
> 3. Fix type "SAML"
>
> [email protected]
>
> (cherry picked from commit 94d037e89e0435217f58cb9a9ec4bcbfbef6265f)
>
> Bug: 804490
> Change-Id: Ib35bf249eed1e9bd1f1aa03835f5c6ec627af8aa
> Reviewed-on: https://chromium-review.googlesource.com/959042
> Reviewed-by: Julian Pastarmov <[email protected]>
> Reviewed-by: Nathan Parker <[email protected]>
> Commit-Queue: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#542655}
> Reviewed-on: https://chromium-review.googlesource.com/967946
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3359@{#299}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Bug: 804490
Change-Id: I5667044057b56317a92418a06facdbb8694be16d
Reviewed-on: https://chromium-review.googlesource.com/972521
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#362}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Fix variable typo in CustomTabIntentDataProvider.getButtonParamsForId()
Also, get the correct child to update in
CustomTabToolbar.updateCustomActionButton().
Bug: b/73160522, 822277
Change-Id: Ia77234d6023a1049d506684bda3aaaa7e96cd405
Reviewed-on: https://chromium-review.googlesource.com/964444
Commit-Queue: Bernhard Bauer <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#543660}(cherry picked from commit 7d8451ab014022fe060be72b2d568a57f87a0479)
Reviewed-on: https://chromium-review.googlesource.com/973523
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#361}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}[md-settings] Clarify Password Saving and Autofill Toggles
This change clarifies the wording around the password saving and
autofill toggles.
Bug: 822465
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I91b31fe61cd0754239f7908e8c04c7e69b72f670
Reviewed-on: https://chromium-review.googlesource.com/970541
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#544661}(cherry picked from commit 52f6eb4221430b6248fd5a59bec53bfef9fdd9a7)
Reviewed-on: https://chromium-review.googlesource.com/973621
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#360}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}Incrementing VERSION to 66.0.3359.47
[email protected]
Change-Id: Ic59c058f1deba30729630d9ece599d427d1c35c4
Reviewed-on: https://chromium-review.googlesource.com/972612
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#359}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
