Publish DEPS for Chromium 66.0.3359.10
Incrementing VERSION to 66.0.3359.10
[email protected]
Change-Id: Ia48cb2d80fbd53bb68bbab9cb31e594ba1bce855
Reviewed-on: https://chromium-review.googlesource.com/950324
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#26}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Fix use-after-free in SpdySessionPool::FindAvailableSession()
Reference to a WeakPtr was to a WeakPtr that was deleted in
certain cases. Fixed by just making a copy.
Bug: 817866
Change-Id: I9fae68d018c4178a8224b3e79ab44c8a1282be87
Reviewed-on: https://chromium-review.googlesource.com/943983
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Paul Jensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540305}(cherry picked from commit f5e3b1bf7967c8e37cb1fbf7e2acf04ea3d28778)
Reviewed-on: https://chromium-review.googlesource.com/950382
Reviewed-by: Paul Jensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#25}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[Merge to M66] Cros splitscreen: Use window transform during resizing.
It's possible that during resizing, the desired resizing bounds for the snapped window is smaller
then the minimum bounds. In this case, we use window transform to apply a translation on the window
to make it visaully be placed outside of the workspace area. The transform will be reset after the
resizing.
Bug: 725683, 817557
[email protected]
(cherry picked from commit 71efa62ae94340a4eb92cc6e5f1e6786809b141e)
Change-Id: I9cf4056a30a417a2afe29d16fe6a8f80268d64b8
Reviewed-on: https://chromium-review.googlesource.com/944721
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540953}
Reviewed-on: https://chromium-review.googlesource.com/950005
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#24}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[Merge to M66] Revert "Handle WebContents occlusion on aura."
This reverts commit 63c0797380c87f558c2d06c00673d1abc044aba3.
Reason for revert: This is causing crbug.com/818010 and crbug.com/817957.
Original change's description:
> Handle WebContents occlusion on aura.
>
> With this CL, when a WebContents is occluded on aura:
> - WebContents::GetVisibility returns OCCLUDED
> - RenderWidgetHostImpl::WasHidden is called on all
> RenderWidgetHostImpls that belong to the WebContents.
> That allows:
> - Changing the priority of renderer processes to background.
> - Not rendering frames unnecessarily.
>
> Bug: 668690
> Change-Id: Ie1c86d271276576a6b5c7adfb11bd0e42d5d491e
> Reviewed-on: https://chromium-review.googlesource.com/937820
> Reviewed-by: Peter Beverloo <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Dominick Ng <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Commit-Queue: François Doray <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#540149}
[email protected],[email protected],[email protected],[email protected],[email protected]
(cherry picked from commit 04a802475fdedf795b626b2e9635e5a93644d376)
Bug: 668690
Change-Id: Id58705c66157cb18be220cc59b29a50fd3b14d95
Reviewed-on: https://chromium-review.googlesource.com/947802
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540735}
Reviewed-on: https://chromium-review.googlesource.com/950140
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#23}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Add a post-crash startup tab when problem applications are detected
Bug: 717696
Change-Id: Ie79bd758246052c462dee4b3a99e504fcaa005c0
Reviewed-on: https://chromium-review.googlesource.com/935743
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540564}(cherry picked from commit 8437799fd0c000728a4a4bfa3fc548d968cf22d0)
Reviewed-on: https://chromium-review.googlesource.com/950202
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#22}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Reland "Add the LaunchUninstallFlow() function"
This is a reland of 5e06564abe4c3b49a41b35f9379df9f6106c4cc1
Original change's description:
> Add the LaunchUninstallFlow() function
>
> This function uses automation to automatically write the name of a
> program into the search box of the Apps & Features page.
>
> Bug: 717696
> Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907
> Reviewed-on: https://chromium-review.googlesource.com/907590
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Commit-Queue: Patrick Monette <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#540209}
TBR: [email protected], [email protected]
Bug: 717696
Change-Id: I9048a36c52113311496abe5d2d5d1ac3fe3c79fc
Reviewed-on: https://chromium-review.googlesource.com/944202
Reviewed-by: Patrick Monette <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540296}(cherry picked from commit 10fd49ae901ae6f0e2b3ee735729839995164b60)
Reviewed-on: https://chromium-review.googlesource.com/950182
Cr-Commit-Position: refs/branch-heads/3359@{#21}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[Merge to M66] Amend "Enable Sole integration by default"
The enabling bit is saved in SharedPref, so change that as well.
[email protected]
Bug: 818236
Change-Id: Idbbdf97d01e452d18db6b172cc709caa521146a7
Reviewed-on: https://chromium-review.googlesource.com/946881
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540658}(cherry picked from commit 219101ecc0143651567d49340e80fb5b3e756b40)
Reviewed-on: https://chromium-review.googlesource.com/950002
Cr-Commit-Position: refs/branch-heads/3359@{#20}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[Merge to M66] Enable Sole integration by default
[email protected]
Bug: 818236
Change-Id: Ib7e74015c6cebb368bf9efdf8307ed13c1db8e4f
Reviewed-on: https://chromium-review.googlesource.com/946649
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540603}(cherry picked from commit d269a1bbd03b84714e09499cabcaa483423b30fb)
Reviewed-on: https://chromium-review.googlesource.com/949982
Cr-Commit-Position: refs/branch-heads/3359@{#19}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
ONC: Allow VPN.OpenVPN.UserAuthenticationType to be unspecified
Currently if a policy does not specify UserAuthenticationType,
Password and OTP will be stripped from merged ONC. Insead we
should allow both if unspecified.
[email protected]
(cherry picked from commit 1a36c69b9784a29b6b84cd735a99ab1ead285d44)
Bug: 817617
Change-Id: I2c4a47fb5aa0faaba10d4a76e53bb54671e7f450
Reviewed-on: https://chromium-review.googlesource.com/944617
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540669}
Reviewed-on: https://chromium-review.googlesource.com/949976
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#18}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Network config: Explicitly show save or connect
Using the configured and saved state of a network to determine whether
to show 'Save' or 'Connect' was not always correct; instead let the UI
determine which button to show.
Also includes a minor improvement to the error messaging.
[email protected]
(cherry picked from commit 6cf247600f9ac97acde5ccf81c9634c1144ee0a0)
Bug: 814939
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifb9a854826a3e4f45c17cb22ef03ed6b23c6f58c
Reviewed-on: https://chromium-review.googlesource.com/943922
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540624}
Reviewed-on: https://chromium-review.googlesource.com/949967
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#17}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Partial revert of Network List: Fix edge case
Bug was introduced here:
https://chromium-review.googlesource.com/920790
Change introducing the bug was not actually related to the fix
in that CL.
[email protected]
(cherry picked from commit bb670e0da6d028a0eec7b0a1b7b8e9c753cbfd53)
Bug: 817706
Change-Id: I9e73f05fe66745b1b7651333a6d715c682018a1a
Reviewed-on: https://chromium-review.googlesource.com/944161
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540536}
Reviewed-on: https://chromium-review.googlesource.com/949965
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#16}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[Mac] Remove the "Exit Fullscreen" Touch Bar Button
(cherry picked from commit f2ae6ac5bd18c9a3615c60a474617638704fe329)
Bug: 818055
Change-Id: Ia0f8ee535c45ede4047e02f068def70e538b8524
Reviewed-on: https://chromium-review.googlesource.com/946740
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Sarah Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540648}
Reviewed-on: https://chromium-review.googlesource.com/949566
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#15}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
m66 merge: cros: ensure 26 DIPs window visibility for setting arc window bounds
changes:
When arc window is moved to a workspace, ensure 26 DIPs window
visibility.
[email protected]
[email protected]
(cherry picked from commit 968c8d22567e239273e50c3f7b63287df5099d49)
Bug: 806094
Test: device test and added test coverage
Change-Id: I498d468d0e1767f62426f6e896992aaee33eeb83
Reviewed-on: https://chromium-review.googlesource.com/930661
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Qiang Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540630}
Reviewed-on: https://chromium-review.googlesource.com/949411
Reviewed-by: Qiang Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#14}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Revert "Extensions: Navigate to default chrome page on extension unload"
This reverts commit 4d546d6ecc0e621a0d08f804a9e25c4427055740.
Reason for revert: this patch caused a bug where we leave extraneous
windows around when coming out of sleep.
[email protected], [email protected] (c/b/ui/browser - clean revert)
(cherry picked from commit f16ef54406c24f856c79546dcef4937ce580b696)
Bug: 818351
Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd
Reviewed-on: https://chromium-review.googlesource.com/947473
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540720}
Reviewed-on: https://chromium-review.googlesource.com/949307
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#13}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Merge to M66: Fix compatibility between Select-to-Speak and large mouse cursor.
The event rewriter needs to allow mouse movement events to pass even
when those events are used by Select-to-Speak. It should only cancel
mouse click events used by Select-to-Speak.
Another solution would be to re-write all used "drag" events to be
simply "move" events, which may reduce the likelyhood that these
events will be used by any other part of Chrome / Chrome OS besides
Select-to-Speak and drawing the mouse.
This bug also impacted some devices (like snappy) even without
large mouse cursor on.
Note: The additional "drag" and "move" events were manually tested
and do not appear to cause any behavior problems on tabs, the
launcher, system windows, etc.
[email protected]
Bug: 818329
Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c
Reviewed-on: https://chromium-review.googlesource.com/947210
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540714}(cherry picked from commit 8f6ebbb1d897c9ead6e241195f8604b412bb4b17)
Reviewed-on: https://chromium-review.googlesource.com/949079
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#12}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Use HitTestQuery to transform locations in RWHInputEventRouter.
Currently in RenderWidgetHostInputEventRouter, we use
TransformPointToCoordSpaceForView [1] to transform locations, which uses
SurfaceHittest in normal chrome. We don't want to use SurfaceHittest in
normal chrome and can't use SurfaceHittest in OOP-D.
This CL changes to use HitTestQuery::TransformLocationForTarget instead.
[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_base.h?l=328
Bug: 811928
Test: site-per-process-hit-test-browsertests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie2ea51f0c12e17612aca17e322b592cdbdce5614
Reviewed-on: https://chromium-review.googlesource.com/917205
Commit-Queue: Ria Jiang <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540387}(cherry picked from commit 56501686b916ffce0338aa6330ede842b0517b40)
Reviewed-on: https://chromium-review.googlesource.com/949078
Reviewed-by: Ria Jiang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#11}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[Merge to M66] Cros splitscreen: Ignore the window bounds change transition transform if the window is in overview mode.
[email protected]
(cherry picked from commit 30048681898250b814d7aff35b3d2d93fefb26c1)
Bug: 817557
Change-Id: Ibb1a048261a97fb9265e9b4330b3bbf9f21a65c8
Reviewed-on: https://chromium-review.googlesource.com/942090
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540386}
Reviewed-on: https://chromium-review.googlesource.com/947926
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#10}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.9
[email protected]
Change-Id: I86b735348a7946412b26225bd0a48a8c14cb3e2c
Reviewed-on: https://chromium-review.googlesource.com/947840
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#9}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.8
[email protected]
Change-Id: Ica075166dde668c0fa2027e1653df619010969d1
Reviewed-on: https://chromium-review.googlesource.com/947774
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#8}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.7
[email protected]
Change-Id: I4cd2dee0d349c4a1b657ad9fc37532cd137f84b9
Reviewed-on: https://chromium-review.googlesource.com/947772
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#7}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.6
[email protected]
Change-Id: I13d8061ab6f6fcbf371b1fd7d9183f4532d5dc6d
Reviewed-on: https://chromium-review.googlesource.com/947832
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#6}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.5
[email protected]
Change-Id: Iacec3122524d5afbee94336f9eb918fdcbcd53fe
Reviewed-on: https://chromium-review.googlesource.com/947831
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#5}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.4
[email protected]
Change-Id: I8f09d04365d5e69ea46b242035d3befd85850188
Reviewed-on: https://chromium-review.googlesource.com/947862
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#4}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.3
[email protected]
Change-Id: I6e7b6c85ee8cb56800908acf382581da63638f5c
Reviewed-on: https://chromium-review.googlesource.com/947743
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#3}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.2
[email protected]
Change-Id: Ib15c0a5aeb49f1134f0984dbecbaf4f9185e04ac
Reviewed-on: https://chromium-review.googlesource.com/945449
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#2}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
Incrementing VERSION to 66.0.3359.1
[email protected]
Change-Id: I30a5d107b3fa0b3189a292ec7ccc2d89fe855136
Reviewed-on: https://chromium-review.googlesource.com/945490
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#1}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[remoting host] Simplify capture scheduling logic
This removes an unnecessary section from
WebrtcFrameSchedulerSimple::ScheduleNextFrame()
to address review comments on
https://chromium-review.googlesource.com/940449
and potentially improves performance and b/w utilization.
Bug: 816727
Change-Id: I76aaf326a48f985880ea7ff4ba4e16cc246862b3
Reviewed-on: https://chromium-review.googlesource.com/942484
Reviewed-by: Zijie He <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540276}
Add two histograms to collect data on number of queued packets
when packets go out of order.
Bug: 817496
Change-Id: Id0d0a987bd46664ab68ba04fe7134b4d19fee8e8
Reviewed-on: https://chromium-review.googlesource.com/941388
Commit-Queue: Zhongyi Shi <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540275}
cros: revise to use one shortcut for window movement
changes:
Base CL is: crrev.com/c/738826.
UI review prefer one shortcut for this feature. So we are using
"Search+Alt+m". Instead of allowing user specify moving direction, we
just move window incrementally in sorted display id list and in a cycle
manner.
Bug: 778438
Test: tested on device and test coverage
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I35f946fd26885c0b435c437ef4dc766169989f8f
Reviewed-on: https://chromium-review.googlesource.com/942001
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Qiang Xu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540274}
Add SafeBrowsingExtendedReportingEnabled policy for SBER pref.
This results in significant overlap with the existing
SafeBrowsingExtendedReportingOptInAllowed policy, which is being deprecated here.
We continue to support SBEROptInAllowed as a legacy preference until it the
associated policy is deprecated, but we also need the pref for WebView.
Bug: 798808
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d0f32dff4575196a0d6b3e7120c3a76ff165751
Reviewed-on: https://chromium-review.googlesource.com/888859
Commit-Queue: Luke Z <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540273}
Add VR VoiceSearch UKM
Adding a UKM metric to track whether a page was specifically requested
via voice search.
Bug: 808584
Change-Id: Id20c93ccf3c193e9559a2fbf5bcb87987e08fc1e
Reviewed-on: https://chromium-review.googlesource.com/940605
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Reviewed-by: Bill Orr <[email protected]>
Commit-Queue: Anna Offenwanger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540272}
Remove mesa packages from install-build-deps
The mesa packages were originally added because of an issue with installing
libgbm-dev on Saucy. The CL description is inlined below:
------------------------------------------------------------------------
commit: 419a9a64b69f1d113c28d1e78c7117adf510aa95
Author: [email protected] <[email protected]@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 19 18:26:18 2014 +0000
Fix installation of libgbm-dev package in install-build-deps.sh
crrev.com/106633002 has recently introduced a dependency on libgbm-dev.
Unfortunatelly, this package is a bit more trickier to install, for the
following reason: it depends on mesa-glx and, conversely to most of the
other packages, only one version of mesa (w.r.t backports) can exist in
the system. Google's workstations are configured to use the -lts-saucy
version of mesa. The right package in this case is libgbm-dev-lts-saucy
and attempting to install just libgbm-dev ends up in a failure.
This change fixes install-build-deps.sh, installing the matching version
of libgbm-dev (w.r.t libgl1-mesa-glx), falling back to libgbm-dev.
------------------------------------------------------------------------
Currently, this is causing issues on Googler's machines (see chrome-linux
mailing list). Since the Saucy days are over, just depend on libgbm-dev
directly. Tested on Ubuntu Trusty, Ubuntu Xenial, Debian Stretch, and Debian
Testing.
R=dpranke
Change-Id: I43568ab8b8c66c2aa6cd394c67f2cf90d6d1762c
Reviewed-on: https://chromium-review.googlesource.com/944047
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540271}
Collect metrics in HitTestAggregator and HitTestQuery.
Collect Event.VizHitTest.AggregateTime, Event.VizHitTest.HitTestRegions,
Event.VizHitTest.TargetTime and Event.VizHitTest.TransformTime.
Bug: 817673
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaae1009aa74f679a2e40c56f62e24a6fb3422be4
Reviewed-on: https://chromium-review.googlesource.com/942604
Commit-Queue: Ria Jiang <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540270}
Add lint rule for LayoutTests/SmokeTests and fix it
The new lint rule checks for non-existence and duplicate items.
Updated LayoutTests/SmokeTests for tests that have been moved or
deleted.
Change-Id: I3de74e519d36c08871af872d3a439ba28fe1bdc2
Reviewed-on: https://chromium-review.googlesource.com/942606
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Robert Ma <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540269}
[CI] Add ClipRect stream operator for debugging
ClipRect has a ToString function but did not have a stream operator
defined. This patch adds operator<<(..., ClipRect) which enables:
ClipRect clip_rect;
LOG(INFO) << "Clip rect: " << clip_rect;
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f34867fb50dd71c76779223ac7871e5e77dc568
Reviewed-on: https://chromium-review.googlesource.com/943679
Commit-Queue: Philip Rogers <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540268}
Include name of mojo interface in double-bind DCHECK
Bug: 817873
Change-Id: Ib22851d80508d65e5f9fa651af8dc629da17ddd4
Reviewed-on: https://chromium-review.googlesource.com/943830
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540267}
Use LifecycleUnits for tab discarding.
TabManager discards tabs, but also ARC processes.
LifecycleUnit is an abstraction to help us having one
code path for all discards.
Bug: 775644
Change-Id: I4d2e89a710afe097cc2d6222a6c156f57c774144
Reviewed-on: https://chromium-review.googlesource.com/842306
Commit-Queue: François Doray <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Reviewed-by: Sébastien Marchand <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540266}
Add use counters for EnableDtlsSrtp constraint
These will be turned into deprecation warnings when we
start deprecating SDES crypto and the constraint.
Bug: 804275
Change-Id: I0c5763406b9f4bd32890708e34a132ad6553a929
Reviewed-on: https://chromium-review.googlesource.com/941955
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540265}
Fix browser tests that use host_resolver() and navigate in SetUpOnMainThread with the network service.
These currently silently fail, as we only sync the host_resolver() rules after SetUpOnMainThread returns. Improve this by watching the main window's WebContents for navigations and syncing the rules immediately.
This won't cover all corner cases, i.e. if a test navigates a new tab or window. However it should cover the majority of cases.
Bug: 729848
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie14daf47582d187f6d4aa6bf0a36885997fee6c8
Reviewed-on: https://chromium-review.googlesource.com/940165
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540264}
Remove net/tools/get_server_time
This CL removes net/tools/get_server_time now that
//components/network_time_tracker is using a different mechanism
(x-cup-server-proof). This utility is no longer
relevant.
Bug: 801668
Change-Id: I0bc75a9d21244a0c3bbe0ed50da2783e7169c61c
Reviewed-on: https://chromium-review.googlesource.com/943343
Reviewed-by: Ryan Sleevi <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Helen Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540263}
Upgrade VR test APKs to 1.13
Regular upgrade to the newest public release of the VR APKs.
Change-Id: I3f6aa68192fc35d52cdfb946c8c1e197c06ecfdd
Reviewed-on: https://chromium-review.googlesource.com/942227
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540262}
Fix crash with P2P Sharing flag on.
Currently turning on the P2P sharing flag can lead to a crash in two
ways while trying to set up the file for sharing. This patch checks
for a null file path, and returns instead of crashing if we do not
have a file path.
The two cases leading to this will be addressed separately.
In the first case, we might end up with a null file path. This can
happen if we are sharing a content URI, which does not have an
associated file. The proper fix is to re-share the content URI.
https://crbug.com/817608 is tracking the proper fix.
In the second case, (https://crbug.com/817611), we are trying to share
from a private directory. We need to detect the attempt to share from
a private directory and prevent it. This will largely be mitigated
when we implement the planned upgrade task to move all offline pages
out of the private directory and into a public location, but we still
need to fix the bug in case a file fails the upgrade.
Change-Id: Iec2453b6051e9e535450214d27b02a696499b4cf
Bug: 758690
Change-Id: Iec2453b6051e9e535450214d27b02a696499b4cf
Reviewed-on: https://chromium-review.googlesource.com/937842
Commit-Queue: Peter Williamson <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Reviewed-by: Carlos Knippschild <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540261}
Revert "Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a"
This reverts commit 58866fc90d4115660ccf046b5e47fbfc35490880.
Reason for revert: broke the build -- https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63495
Original change's description:
> Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a
>
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
> end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
> kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
> again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
> resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add UploadReport to manage database resources during
> upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
> symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
> implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
> CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
> ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
> functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
> Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
> source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
> from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
> ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
> ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
> test
> c69ba3d52783 non-win: Add
> Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> cd3afe616e63 Linux: Pull and use clang toolchain in third_party
> 8e80a575d15f Linux: Pull a sysroot if pulling a local clang
> fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
> a869ae18d256 Workaround for death test failure when in threadsafe mode
> on Mac
> 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
> 9affa2a0e72d Optionally stub out the libcurl-based implementation of
> HTTPTransport
> dec23bef5769 win gn: reintroduce flags to disable warnings
> 746ce1a63703 Roll mini_chromium to 987bde8
> 493e29bc3df0 win: Use correct format specifier
> a45e88602b90 Skip ELF notes with a p_vaddr of zero
> 71d90608828d Add Linux trybots to CQ
>
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
>
> Bug: crashpad:30
> Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
> Reviewed-on: https://chromium-review.googlesource.com/941512
> Reviewed-by: Sigurður Ásgeirsson <[email protected]>
> Reviewed-by: Mark Mentovai <[email protected]>
> Commit-Queue: Joshua Peraza <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#540253}
[email protected],[email protected],[email protected]
Change-Id: I0f0866b62d41f53b702d17681b6540c766db98b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/944122
Reviewed-by: Xi Cheng <[email protected]>
Commit-Queue: Xi Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540260}
Improve behavior on Android when dragging to close tab
Currently, if you're in the Android tab picker and you're dragging to close a
tab, but your finger hits the other stack, we treat this as if you immediately
lifted your finger once it hit the other stack. This feels kind of weird and
jarring.
This CL fixes the behavior so the tab keeps getting dragged until you actually
lift your finger.
Bug: 817885
Change-Id: I5ea113d28dccfa33b29c33575f0b6e29f9dfb9ef
Reviewed-on: https://chromium-review.googlesource.com/935667
Commit-Queue: Ryan Landay <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540259}
[css-typed-om] Fix computed value of an interpolated transform.
Previously we did not handle the case of computing the value of an
interpolated transform, which occurs when we interpolate between
two different transform types containing percentages.
The correct result is currently not spec'd [1], so this patch fixes this
by just returning "none" in this case.
[1] https://github.com/w3c/css-houdini-drafts/issues/425
Bug: 816803
Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6
Reviewed-on: https://chromium-review.googlesource.com/942595
Reviewed-by: nainar <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540258}
Reporting: Use BACKGROUND_SYNC permission to control uploads
We now use the BACKGROUND_SYNC permission to decide whether or not to
upload reports for a particular origin. Note that as currently written,
we don't use this permission to decide whether to *collect* the reports,
only whether to *send* them. Whether or not to collect is controlled
by the site's cookie settings.
Bug: 704259
Change-Id: I059019ab85106c26f4d156e9f5d61e2f8b8fa757
Reviewed-on: https://chromium-review.googlesource.com/937572
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Douglas Creager <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540257}
[Local Screen Casting] Exit fullscreen when presentation display is removed
While presenting to a local display, if we remove the display with a
fullscreen presentation, the presentation can move to the display with
the controlling window while still being fullscreen and cover the
controlling window. This CL makes the presentation window exit
fullscreen in such cases.
Bug: 805139
Change-Id: I02c4234d95ee9477683550fdad454e1aee6b460b
Reviewed-on: https://chromium-review.googlesource.com/902889
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540256}
Add Mac-specific expectations for three web-animation WPT tests
These tests originally passed the CQ mac bots because they are allowed
to crash due to http://crbug.com/816534 , and the CQ mac bot runs with
DCHECK enabled. Unfortunately however that hide the fact that on
non-DCHECK macs, the test has different output.
Bug: 772014
Change-Id: I4bbaeb853426ad48488111a667a6caf4ba7284f6
Reviewed-on: https://chromium-review.googlesource.com/939670
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540255}
Add Nimbus and Argon to Trusted CT Logs
The following CT Logs have passed their monitoring period and
are being added as trusted Logs in Chrome:
Google Argon2018, Argon2019, Argon2020, Argon2021
Cloudflare Nimbus2018, Nimbus2019, Nimbus2020, Nimbus2021
Bug: 756814, 756817, 756818, 756819, 780654, 780655, 780656, 780657
Change-Id: I6b8671db0dc7ba34b666345049934ed3e2b5705a
Reviewed-on: https://chromium-review.googlesource.com/942688
Reviewed-by: Ryan Sleevi <[email protected]>
Commit-Queue: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540254}
Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a
14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add UploadReport to manage database resources during
upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
test
c69ba3d52783 non-win: Add
Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
cd3afe616e63 Linux: Pull and use clang toolchain in third_party
8e80a575d15f Linux: Pull a sysroot if pulling a local clang
fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
a869ae18d256 Workaround for death test failure when in threadsafe mode
on Mac
8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
9affa2a0e72d Optionally stub out the libcurl-based implementation of
HTTPTransport
dec23bef5769 win gn: reintroduce flags to disable warnings
746ce1a63703 Roll mini_chromium to 987bde8
493e29bc3df0 win: Use correct format specifier
a45e88602b90 Skip ELF notes with a p_vaddr of zero
71d90608828d Add Linux trybots to CQ
Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.
Bug: crashpad:30
Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
Reviewed-on: https://chromium-review.googlesource.com/941512
Reviewed-by: Sigurður Ásgeirsson <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Joshua Peraza <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540253}
Sampling Heap Profiler: Replace count with total in sample record
Turned out the rounding made to calculate count could add significant
errors to the samples on regular allocation patterns. The patch
replaces count with the total value attributed to the sample.
BUG=803276
Change-Id: I2f40ad403275817696330d502dadfd76657a552a
Reviewed-on: https://chromium-review.googlesource.com/941734
Commit-Queue: Alexei Filippov <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540252}
add CrosDisplayConnection to assistant
Bug: 807015
Test: None
Change-Id: I6b9ae265f6105dc7160f041b7e752785180889f3
Reviewed-on: https://chromium-review.googlesource.com/941389
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Muyuan Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540251}
Docked Magnifier: Fix High Contrast mode
Before this CL, high contrast was applied to the contents of
the viewport twice (once on the copied contents, and another
since the viewport is a child of the root layer), resulting
in undoing its effect.
This CL updates the "inverted" status of the viewport layer.
BUG=817431
TEST=Added test coverage.
Change-Id: I4d946e5ae22f1232db74fecf7b32311073124055
Reviewed-on: https://chromium-review.googlesource.com/942602
Commit-Queue: Ahmed Fakhry <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540250}
Rebaseline pixel layout tests for Mac 10.13
These are tests failing because of image (and image+text) diff.
Steps:
1. Tried on mac10.13_blink_rel.
2. Filtered out image & image+text failures.
3. Rebaselined these tests on Mac ports *only* (otherwise, many Win &
Linux expectations would be modified unwarrantedly).
4. Added back all the flaky expectations (these tests were not flaky in
this single job, which doesn't mean they are not flaky).
Lastly, a bunch of failure expectations associated with issue 701047 were
automatically removed by rebaseline-cl. After examination of the new
baselines, it seems the issue is indeed gone ("m" and "w" display correctly
on Mac 10.12 now).
Bug: 774301, 701047
Change-Id: I649a7973ca24752ae23f5f10bd82f0cf1c6901e9
Reviewed-on: https://chromium-review.googlesource.com/899783
Commit-Queue: Robert Ma <[email protected]>
Reviewed-by: Quinten Yearsley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540249}
Disable OSKOverscroll test
This test is failing on the Nougat bot. Since the feature is unshipped
and currently unowned, it's best to just disable for now. We'll block
the feature bug on reenabling it.
Bug: 773076
Change-Id: I30d019267116fcae937e86f5f514f2a260829dc4
Reviewed-on: https://chromium-review.googlesource.com/943246
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540248}
Roll src/third_party/pdfium/ 198792b7e..71cdd20e9 (3 commits)
https://pdfium.googlesource.com/pdfium.git/+log/198792b7e860..71cdd20e9d74
$ git log 198792b7e..71cdd20e9 --date=short --no-merges --format='%ad %ae %s'
2018-03-01 rharrison Disable XFA tests without embedded fonts
2018-03-01 thestig Add a test for FPDFImageObj_GetBitmap() with a JBIG image.
2018-03-01 thestig Break up CFX_DIBSource::ConvertBuffer().
Created with:
roll-dep src/third_party/pdfium
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iba02fd7b624598f40cf91a2f9b8a71f9750fbd6d
Reviewed-on: https://chromium-review.googlesource.com/943604
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540247}
[Picture in Picture] Disable context menu PIP command.
This is temporary while PIP is being wired up and worked to be more
stable through the media controls entry point.
The menu item is not removed because we intend to continue using it
and it is currently hidden behind a flag.
BUG: 817598
Change-Id: I9156d81b40dd6c97e19c6eef3f5fbbe13e350639
Reviewed-on: https://chromium-review.googlesource.com/942305
Commit-Queue: apacible <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540246}
Marked some context menu EG tests as flaky.
Bug: 817810
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib6b945dd2a15cee871affab13dade50d1b06149e
Reviewed-on: https://chromium-review.googlesource.com/943726
Reviewed-by: Yuke Liao <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540245}
Reenable TwoClientPasswordsSyncTest.DeleteAll
It was disabled years ago and seems to be passing consistently now.
Bug: 111399
Change-Id: I5c2095c101d6dc20891d7787d9e360f3c48d2f77
Reviewed-on: https://chromium-review.googlesource.com/943063
Reviewed-by: Pavel Yatsuk <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540244}
Clone osk_display_manager.h/cc to on_screen_keyboard_display_manager_tab_tip
For ease of review copy the files over. A follow up patch
(https://chromium-review.googlesource.com/c/chromium/src/+/941911) will be
made to actually change the implementation. Presubmit skipped so this is
exactly just a copy file otherwise it errors out on the banned functions
used in this file. (Fixed in followup)
BUG=817501
NOPRESUBMIT=true
Change-Id: I71caaca96f8b722717632d32f8c4187fc0ebaf7d
Reviewed-on: https://chromium-review.googlesource.com/943342
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540243}
[DIAL] Added a DialURLFetcher to handle Dial related HTTP requests
DeviceDescriptionFetcher and DialAppInfoFetcher have some common code.
Create a DialURLFetcher class to get rid of some duplications.
The common URLFetcher class can also be used to launch and stop Dial
apps when we implement DIAL launch at browser side.
Bug: 816628
Change-Id: I26bdfbbf7e2d59a68e3bf5aeaba8b6e3664bf430
Reviewed-on: https://chromium-review.googlesource.com/938158
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Commit-Queue: Bin Zhao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540242}
Replace base::MakeUnique with std::make_unique.
base/memory/ptr_util.h includes will be cleaned up later.
Generated by:
git grep -l base::MakeUnique | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'
git grep -l MakeUnique< base | xargs perl -pi -e 's/MakeUnique</std::make_unique</'
Presubmit bypassed due to unrelated existing errors in touched lines.
Bug: 755727
No-Presubmit: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iedc5caf5bc04e119dadd0e3e8cc5c4dbf2fddc80
Reviewed-on: https://chromium-review.googlesource.com/943728
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540241}
Forward user gesture for cross-process postMessage.
This CL adds user gesture plumbing to cross-process postMessage, so
that when a frame sends a postMessage to a cross-process frame while
processing a user gesture, the target frame's onmessage handler can
utilize that user gesture as well.
For now, the plumbing is only for one bit, has_user_gesture, which is
restricted so that it can be forwarded at most once. This prevents
unbounded forwarding of a user gesture via OOPIFs.
This solution is temporary and should eventually be superceded by one
of the following approaches:
- Browser process starts tracking user gestures and enforcing
constraints like at-most-one-popup-per-gesture. This plumbing
should then pass a user gesture ID instead of a bool.
- UserActivation V2 ships (see https://crbug.com/696617). This should
allow us to remove this plumbing altogether.
Bug: 161068
Change-Id: Ib7de03bb51470f6ff924d2e178b26e80b597321d
Reviewed-on: https://chromium-review.googlesource.com/915101
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540240}
Add a response started callback to SimpleURLLoader
Adding a callback to SimpleURLLoader to get notified when the request
started, i.e. when the headers are available.
Bug: 817458
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1b53ba5b64a4c1cc406d03638f733a177ec863be
Reviewed-on: https://chromium-review.googlesource.com/941881
Commit-Queue: Jay Civelli <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540239}
[TTS] Update logging of Ranker prediction.
Splits the Ranker predition UMA logging to always log the prediction
regardless of whether the UI was shown.
BUG=
Change-Id: I6593e3163113ea7201d71b587cbd7f2552ba085b
Reviewed-on: https://chromium-review.googlesource.com/942058
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540238}
Experimentally removing MSAA workaround for perf bot
The perf bot perf.chromium-rel-mac12 has alerted on a ~50% slowdown in
http___webglsamples.org_dynamic-cubemap_dynamic-cubemap.html .
In the regression range was my seemingly closely
related CL: https://crrev.com/c/923103
But that commit should improve performance, not regress it.
So this CL adds an exception to the workaround in 923103, so that
that workaround does not apply on perf.chromium-rel-mac12.
This should help determine whether my CL really caused a regression.
I'm expecting this CL to cause a regression in
http___kenrussell.github.io_webgl-animometer_Animometer_tests_3d_webgl.html
(undoing the recent improvement caused by 923103).
Bug: 815154
Change-Id: I335133a127bb7cfcb92ba29065641dfd55b63166
Reviewed-on: https://chromium-review.googlesource.com/938844
Commit-Queue: Kai Ninomiya <[email protected]>
Reviewed-by: Kai Ninomiya <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540237}
bluetooth: web: test: Simulate advertisements
This change adds a SimulateAdvertisementReceived function to the
FakeCentral interface. The design for this class is detailed in the
following document:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg
BUG=719826
Change-Id: I618dc68c967e6d9942f99f1807da6fb1985cd676
Reviewed-on: https://chromium-review.googlesource.com/916554
Reviewed-by: Oliver Chang <[email protected]>
Reviewed-by: Giovanni Ortuño Urquidi <[email protected]>
Reviewed-by: Conley Owens <[email protected]>
Commit-Queue: Ovidio Henriquez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540236}
Replace pow with exp/exp2 in BiquadFilter routines
The general pow function is pretty expensive when computing 10^x and
2^x. Replace it with the more specific exp and exp2 functions.
This is only done for the routines for the BiquadFilterNode.
Using https://jsfiddle.net/8vo0gbav/1/ (with dezipper = true to use
setTargetAtTime) as a test, perf top on my Z840 machine said:
+ 29.01% 28.98% __ieee754_pow_sse2
+ 22.65% 22.61% __exp1
With this CL, the same test reports
+ 17.15% 17.12% __expf_finite
This isn't enough to make the test case use less than 100% CPU, but
audio with glitches is now heard.
Two tests needed to have the thresholds modified. Apparently there's
a difference in round-off between exp and pow for this change to
change the results slightly.
Bug: 813504
Change-Id: I7c517c558bbb54c344f10dc3c057d21404679995
Reviewed-on: https://chromium-review.googlesource.com/942091
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540235}
Disable a parallel download browser test on Android.
This CL disables ParallelDownloadTest.ResumptionLastSliceUnfinished on
Android.
[email protected], [email protected]
Bug: 817801
Change-Id: Icb2ce3a43d00ee1e74a005b2af91cea6045f3694
Reviewed-on: https://chromium-review.googlesource.com/943802
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540234}
[Apps Docs]ARC redirect
App documentation contains outdated information on ARC.
This redirects those docs to updated Android documentation.
Removed articles from the TOC.
Bug: None
Change-Id: I25f6f928ac704a5d357f0e8acab1f427521f84b3
Reviewed-on: https://chromium-review.googlesource.com/943823
Commit-Queue: Crystal Lambert <[email protected]>
Reviewed-by: Meggin Kearney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540233}
Marked ContextMenuJsTest.LinkOfImage as flaky on device.
Bug: 796418
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I77cefa817abceed2dc9485e1d753facec9430523
Reviewed-on: https://chromium-review.googlesource.com/943730
Reviewed-by: Yuke Liao <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540232}
customtabs: Add a detached request mechanism for leapfrog.
This CL adds a new class DetachedResourceRequest intended to be used from
CustomTabs. When an intent is processed, a calling app can trigger a parallel
request proceeding in the background.
This is only the native implemenation, based on SimpleURLLoader. As such, since
this feature is only triggered from Java code, there is no caller in chrome/
yet, only tests.
Change-Id: I8a8d6bdca6ff65554769c3f0344e23dc2dcaf43b
Bug: 816837
Reviewed-on: https://chromium-review.googlesource.com/934271
Commit-Queue: Benoit L <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540231}
[PE] Respect hit test clip behavior throughout PaintLayer::HitTestLayer
Hit tests can ignore clips and PaintLayer::HitTestLayer partially
honored this setting but did not pass it along when computing clip
rects for each layer fragment.
Bug: 817186
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icedf0470dfb06bb68f7f3c11a26a9a475262ac74
Reviewed-on: https://chromium-review.googlesource.com/942471
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540230}
Revert "Add the LaunchUninstallFlow() function"
This reverts commit 5e06564abe4c3b49a41b35f9379df9f6106c4cc1.
Reason for revert: broke the build -- https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/27596
Original change's description:
> Add the LaunchUninstallFlow() function
>
> This function uses automation to automatically write the name of a
> program into the search box of the Apps & Features page.
>
> Bug: 717696
> Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907
> Reviewed-on: https://chromium-review.googlesource.com/907590
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Commit-Queue: Patrick Monette <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#540209}
[email protected],[email protected],[email protected],[email protected]
Change-Id: Ifed25f3097f9b6091f40524cb12278f9f22c8915
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717696
Reviewed-on: https://chromium-review.googlesource.com/943961
Reviewed-by: Xi Cheng <[email protected]>
Commit-Queue: Xi Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540229}
Fixing deps issue with one builbot tester
[email protected]
Change-Id: I8ab27cd1bf46467b4a7a25c87f3aef33eb10f9eb
Reviewed-on: https://chromium-review.googlesource.com/943724
Reviewed-by: Emily Hanley <[email protected]>
Commit-Queue: Emily Hanley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540228}
Rename buildflag_headers for consistency
This renames most of components. There are still a couple left, but
this patch started getting big.
Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.
BUG=814485
TEST=covered by build
[email protected]
Change-Id: I321403895df9ddc988491c70a78507ec51434783
Reviewed-on: https://chromium-review.googlesource.com/943600
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540227}
[root-layer-scrolls] Fix android fullscreen video
Android uses an "overlay" composited video layer when a video is
fullscreened. This layer is parented to the PaintLayerCompositor's
root_content_layer and the actual content (LayoutView) is detached.
With root-layer-scrolling enabled, PLC doesn't create a
root_content_layer and the top-most GraphicsLayer in PLC is that of the
LayoutView. This CL connects the video layer to the PLC's parent
instead. This is currently the outer viewport scroll layer. We also need
to make sure painting starts from the child of this layer, rather than
the PLC's root layer since the video layer is no longer connected to the
root. This doesn't matter for the video itself, however, the media
player controls need to be painted from Blink.
These changes exposed some brittleness in the compositor and the Android
fullscreen video layout tests were hitting the DCHECK in
ScrollbarLayerImplBase::CanScrollOrientation. This is because the
viewport scrollbars use the outer/layout viewport as their ElementId but
are owned by the inner/visual viewport. So when we disconnect the PLC's
content layers, we remove the ScrollNode in the compositor but the
visual viewport and its scrollbar layers live on. The rest of this patch
changes the visual viewport scrollbars to use the visual viewport's
element id.
TEST=virtual/android/fullscreen/video-scrolled-iframe.html,
virtual/android/fullscreen/video-controls-timeline.html,
virtual/android/fullscreen/full-screen-iframe-allowed-video.html
Bug: 711468,811024
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic1c52e1853f14842ee3ae19119476b8945ecae17
Reviewed-on: https://chromium-review.googlesource.com/923397
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540226}
Fix destruction order issue in cast graphics unit test.
Order of destruction in the system gestures test is incorrect, as
discovered by msan.
Bug: b/73738898
Test: Unit test
Change-Id: Ib3f787e0a7e462d7ccbad2f70c1b35d595e58140
Reviewed-on: https://chromium-review.googlesource.com/943704
Commit-Queue: Ryan Daum <[email protected]>
Reviewed-by: Sergey Volk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540225}
Fix a bug in element.scrollIntoView() for OOPIFs
The initial patch [1] landing the feature was passing the wrong rectangle
to scroll to the LocalFrameView of the LocalRoot inside OOPIF process.
The passed rectangle did not include the scroll offset of the
LocalFrameView of the LocalFrameRoot.
This CL fixes the problem and modifies the original test so that
bounding client rectangle of each <iframe> in a nested <iframe>
scenario are precisely tested.
[1]- https://chromium-review.googlesource.com/c/chromium/src/+/679319
Bug: 810291
Change-Id: Id8859dd9dc70f0bb25519a0c812f7b7a078a9922
Reviewed-on: https://chromium-review.googlesource.com/914871
Commit-Queue: Ehsan Karamad <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540224}
Roll src/third_party/catapult/ 279fcf542..bbedc54bc (1 commit)
https://chromium.googlesource.com/catapult.git/+log/279fcf542e09..bbedc54bc5cf
$ git log 279fcf542..bbedc54bc --date=short --no-merges --format='%ad %ae %s'
2018-03-01 perezju [Dashboard API] Include owner and updated in /bugs API response
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I8ef6701d5a6b13e6416e9a30faecfa42cb65e49a
Reviewed-on: https://chromium-review.googlesource.com/943601
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540223}
Add a chrome://flags for features::kEnableVizHitTestDrawQuad.
Bug: 804888
Change-Id: Icea95fd20113ff05ab916a3f2e69607eee2cfe5d
Reviewed-on: https://chromium-review.googlesource.com/942053
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Commit-Queue: Ria Jiang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540222}
cros: add persistent window mixed mirror mode test case
Bug: 805046
Test: covered by tests
Change-Id: Iad3ab2364eb5c034e1d78c5160918d9c10fe9c31
Reviewed-on: https://chromium-review.googlesource.com/942345
Commit-Queue: Qiang Xu <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540221}
[Dice] Avoid presenting accounts filtered by policy in sign-in promos.
This CLs filters out accounts that do not match pattern RestrictSigninToPattern.
Bug: 807799
Change-Id: I2bf581315883166502920c3e86e9e6e9dabcf120
Reviewed-on: https://chromium-review.googlesource.com/928401
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540220}
Media Capabilities: enable decoding API by default.
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aXYvQ01tMhw
Bug: 690364
Change-Id: I3357e97e437069012554b60b0ae527a7b9998606
Reviewed-on: https://chromium-review.googlesource.com/943502
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540219}
CookieMonster: remove testonly SetCookieWithCreationTimeForTesting
... since it's easy for test fixture to provide based on public API.
This reduced SetCookieWithCreationTimeAndOptions down to a single caller,
so fold it in and simplify it a little bit.
Bug: 731236
Change-Id: Ib5acd742ddb6aea7d26dff4952f800826bf5f1e2
Reviewed-on: https://chromium-review.googlesource.com/940142
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Maks Orlovich <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540218}
VR: Set keyboard_api pointer to null to prevent DCHECK failure
Change-Id: Id158c8cb4327a6aa795dd6bdeb14439fa6ef4704
Reviewed-on: https://chromium-review.googlesource.com/943680
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Yash Malik <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540217}
Add VR browsing WPR benchmark
Adds a new VR browsing Telemetry benchmark using WPR archives. It
re-uses the URL list and WPR archive from the memory.top_10_mobile
benchmark since they're reasonable sites that users of the VR browser
might visit.
Bug: 808597
Change-Id: I37a2a9ba14cdf2887125564d1cf1f653940fed6d
Reviewed-on: https://chromium-review.googlesource.com/942086
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540216}
Avoid std::move for string which is later read
Bug: 775415
Change-Id: I0f88d37212866ba343e26b63d955cb7ad4a744b0
Reviewed-on: https://chromium-review.googlesource.com/943421
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Elad Alon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540215}
seccomp: Permit getrusage RUSAGE_THREAD.
RUSAGE_SELF is already allowed for process-wide rusage, so per-thread
should be permitted as well.
Bug: 812250
Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: I5e8a3203875238296cd96a861b70feff115bc97e
Reviewed-on: https://chromium-review.googlesource.com/941592
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540214}
VR: Bind the geolocation service mojo interface once
There doesn't seem to be a reason to re-bind every frame, and it takes
300 us of CPU time to do so.
BUG=
R=vollick
Change-Id: I487cf7e9268396bb71fe3317c6b27edf72a59bdf
Reviewed-on: https://chromium-review.googlesource.com/943347
Reviewed-by: Ian Vollick <[email protected]>
Commit-Queue: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540213}
Web Animations: use WTF::Optional for Progress()
Previously nullable values in the animations code were tracked by
storing nulls as quiet_NaN() and using std::isnan as a null-detector.
It is much more explicit to store such values using WTF::Optional, which
forces code to consider whether or not the offset exists.
Bug: 791086
Change-Id: Iad5e53456c40859bb7e3322c0cb6152b01f376e2
Reviewed-on: https://chromium-review.googlesource.com/939748
Commit-Queue: Stephen McGruer <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540212}
Roll src/third_party/angle/ 98e6a5f7b..d6fef528f (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/98e6a5f7b0ae..d6fef528fcfc
$ git log 98e6a5f7b..d6fef528f --date=short --no-merges --format='%ad %ae %s'
2018-03-01 oetuaho Shorten mangled names of types
Created with:
roll-dep src/third_party/angle
The AutoRoll server is located here: https://angle-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I94b61a390ee85fe6c7bc340d0af5d7e2dd4472fd
Reviewed-on: https://chromium-review.googlesource.com/943592
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540211}
Added committed interstitials for Supervised User
With committed interstitials on, supervised user interstitials are now
displayed using the new codepath. For this, supervised user throttle was
modified so it cancels the navigation with the interstitial HTML.
Browser tests were also modified so they test the committed
interstitials cases too.
Will be done on future CLs (and disabled tests requiring this will be
re-enabled):
-Adding bindings for interstitials to request permission or go back.
-Handling the case where the URL list changes and we have to block the
current page.
-Migrate everything off of base::Callback.
Bug: 780032
Change-Id: I53af29c43cc9d905b078c308021562830c05f47e
Reviewed-on: https://chromium-review.googlesource.com/940459
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540210}
Add the LaunchUninstallFlow() function
This function uses automation to automatically write the name of a
program into the search box of the Apps & Features page.
Bug: 717696
Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907
Reviewed-on: https://chromium-review.googlesource.com/907590
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540209}
Docked Magnifier: Hook up zoom in/out shortcuts
This CL makes the existing shortcuts affect whatever
magnifier is currently enabled. This was also an
opportunity to unify some scale related code.
BUG=817490
TEST=Added test coverage
Change-Id: I366ee56629d09ae22c725b034bfc410077fe52ab
Reviewed-on: https://chromium-review.googlesource.com/942052
Commit-Queue: Ahmed Fakhry <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540208}
Moved tracing back to being its own service
With the direction both tracing and resource_coordinator has taken, there's no
actual shared code between the two; this undoes the original move from //services/tracing.
Mainly a mechanical move, except for starting up as an independent service.
Change-Id: I093015c419166655b2015f7eddf4477983a16af9
Reviewed-on: https://chromium-review.googlesource.com/939659
Commit-Queue: oysteine <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Ehsan Chiniforooshan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540207}
Unify USE_PARTITION_ALLOC usage across base.
Change-Id: Ia0632c8b4fb4e3ba2daf9461f1ee11443db4efd8
Reviewed-on: https://chromium-review.googlesource.com/942028
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Ross McIlroy <[email protected]>
Commit-Queue: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540206}
Fix a null Frame* in form_tracker.
The nullptr was added in a past refactoring before
UserActivationV2 was ready. Test failures with v2
enabled exposed the problem.
Bug: 816527
Change-Id: Ia94fb85831c9ca312d45695e10cb0701c836153a
Reviewed-on: https://chromium-review.googlesource.com/937659
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540205}
Move ZipFileInstaller from chrome/ to extensions/
Moving ZipFileInstaller from chrome/ to extensions/ and changing it to
take a callback instead of directly installing the unpacked
extension/theme.
Providing a method in chrome/ to create a callback that does the
installation (previous behavior).
This CL is in preparation for using the Unzipper service to install
extensions, as some of the logic performed by the utility handler code
will be moved to this class and we'll be shared with the CrxInstaller
class.
Note that the zipfile_installer_unittest could not yet be moved to
extensions/, it will be done later (see crbug.com/817131).
Bug: 799220
Change-Id: I9ae6f13e5e9a0af4c111119952fd8915ff3dcfd3
Reviewed-on: https://chromium-review.googlesource.com/939842
Commit-Queue: Jay Civelli <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540204}
Temporarily Disable ExtensionPopup Views for Mac
This change will be reverted after the M66 branch point.
ExtensionPopup Views will need some harmonization work to bring it up to
parity with some behavior provided by Mac.
BUG=728174
Change-Id: Ia01160117c9dbda10e57d4f4b5a4fe706a39f36c
Reviewed-on: https://chromium-review.googlesource.com/941883
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540203}
Don't save username/password when blacklisting a site.
It happens when the form is prefilled when detected by the password manager.
Bug: 817754
Change-Id: Ia6c8ecd2257950aa34b3fedf796a9696c71cf4fb
Reviewed-on: https://chromium-review.googlesource.com/943503
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540202}
Replace base::MakeUnique with std::make_unique in chrome/browser/.
base/memory/ptr_util.h includes will be cleaned up later.
Generated by:
git grep -l base::MakeUnique chrome/browser/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'
Presubmit bypassed due to unrelated existing errors in touched lines.
Bug: 755727
No-Presubmit: true
Change-Id: Ib4480069b2a369566e6ae4a3d426a0797f5984bb
Reviewed-on: https://chromium-review.googlesource.com/943461
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540201}
[IOS Password Manager] Async suggestions retrieval.
When a password form is added dynamically (i.e. with JavaScript after finishing of a page load)
IOS Password Manager may learn about existing of this form only after user clicking on
some field in this form. On CL https://chromium-review.googlesource.com/c/chromium/src/+/601969
it was implemented retrieving credentials from the Password Store as soon as the user clicked
on dynamically added form and then credentials are autofilled. But fill on account select is not
available until the user makes another interaction with the form (for example start typing of
username). That's suboptimal user experience, it would be good to propose fill on
account select immediately as soon as the user clicks the first time in the form.
This CL implements async suggestion response to Autofill framework in the same way as it's
already implemented in Autofill:
1.When checkIfSuggestionsAvailableForForm (password_controller.mm) is called, and it's
found that credentials haven't been retrieved yet for this page, the callback is saved
untile response from the Password Store is received.
2.It's implemented that Password Store response is propagated to PasswordController even if case
when there are no credentials saved for this page in order to inform Autofill framework that
no suggestions are available.
Bug: 708597, 709011, 708634
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idecc3e621100f3e1b0a3803ce944c4cc116fc3a4
Reviewed-on: https://chromium-review.googlesource.com/921961
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540200}
XSDB: Block most response headers in addition to the response body.
After this CL, CrossSiteDocumentResourceHandler won't call
|next_handler_|'s OnResponseStarted until it has made the allow-vs-block
decision. Until that time network::ResourceResponse (which among other
things include the response headers) is stored temporarily in a
CrossSiteDocumentResourceHandler's field.
Postponing the call to next handler's OnResponseStarted confuses
MimeSniffingResourceHandler (which does the same thing to its downstream
handlers, but doesn't expect this treatment from its upstream handler).
The CL works around that by changing the relative order of the handlers
(after CL, MimeSniffingResourceHandler is before
CrossSiteDocumentResourceHandler). This change requires that
the first CrossSiteDocumentResourceHandler::OnWillRead always allocates
a |local_buffer_|, because MimeSniffingResourceHandler will make the
first call to OnWillRead before letting CrossSiteDocumentResourceHandler
determine |should_block_based_on_headers_| by calling OnResponseStarted.
This CL adds CrossSiteDocumentResourceHandler unit tests that also cover
MimeSniffingResourceHandler in the stream of resource handlers. The new
tests help ensure that CrossSiteDocumentResourceHandler interoperates
well with MimeSniffingResourceHandler (wrt call order and also the
sniffed mime type). OTOH, the old tests are retained, because driving
CrossSiteDocumentResourceHandler more directly allows the tests to make
more assumptions about the internal state and make more test assertions
(e.g. assert that downstream buffer differs until the block-or-allow
decision is made).
Bug: 808205
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I304df0b40c71dd212a469b6b3cc4c13bed533fb0
Reviewed-on: https://chromium-review.googlesource.com/907323
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Nick Carter <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540199}
webui: Delete md_pin_keyboard.
Remove md_pin_keyboard.html/js. It shares a lot of common code with
cr_components/chromeos/quick_unlock/pin_keyboard.html.
Modify cr_comp../c/qu/pin_keyboard to take a bunch of mixins and vars,
so the settings keyboard and lock keyboard can keep their respective
styles.
Test: manual
Bug: 809828
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I618c5325fe374c590b6e232675e77a06435d2604
Reviewed-on: https://chromium-review.googlesource.com/930480
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540198}
Stop emitting "resident_set_bytes" in memory-infra traces.
Now that we emit private memory footprint, the former number is not
particularly meaningful.
Bug: 815328
Change-Id: I85cb76b08ef85073179b5c334c16d4775667b8e6
Reviewed-on: https://chromium-review.googlesource.com/940144
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Primiano Tucci <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540197}
cros:Fix DCHECK failure when dragging in a folder
In the new applist folders we re-use various components.
In AppsGridView we had a bool that was used to determine if we
should show suggested apps, but the bool did not check to see if
the AppsGridView was being used inside a folder.
This was causing a DCHECK failure because row was being computed as -1
when there were 2 items in a folder and a folder item is dragged to the
first position.
Bug: 817475
Change-Id: Ie50583e947f9b9b6ba37a536ae327f935531d35e
Reviewed-on: https://chromium-review.googlesource.com/941546
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540196}
Roll src/third_party/pdfium/ 9002cd8cb..198792b7e (1 commit)
https://pdfium.googlesource.com/pdfium.git/+log/9002cd8cb5c9..198792b7e860
$ git log 9002cd8cb..198792b7e --date=short --no-merges --format='%ad %ae %s'
2018-03-01 thestig Fix some nits in CFX_DIBSource::CloneConvert().
Created with:
roll-dep src/third_party/pdfium
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I11dcd89b441046fc2187787900934d004e20603b
Reviewed-on: https://chromium-review.googlesource.com/943245
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540195}
macOS V2 Sandbox: Correct ordering of seatbelt IPC.
This CL establishes the correct ordering of the IPC which transmits the
seatbelt profile to the child process. It must first map the FD into the
child process, while launching the child process, and only send the
profile once the child process is launched.
Bug: 816824,801889
Change-Id: I453e307cc8f9a7416011ecc4eb101e702b11bca0
Reviewed-on: https://chromium-review.googlesource.com/939986
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Greg Kerr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540194}
[CI] Sink invalidation out of LayoutSVGResource*::RemoveClientFromCache
This splits the various RemoveClientFromCache implementations into two
parts:
1) removal of cached data from the resource, and
2) invalidation of the client.
This avoids triggering invalidations as a side-effect of cache-
invalidation, and separates concerns to help future refactorings. This
also means that resources that perform no caching, or no per-client
caching, need not override RemoveClientFromCache, but can use a default
implementation.
Since a kParentOnlyInvalidation argument to MarkClientForInvalidation is
a no-op, it is removed in the relevant code-paths.
LayoutSVGResourceContainer::MarkClientForInvalidation is made static to
enable its use outside resource containers themselves.
RemoveClientFromCache gets a new semantic in that it returns a bool
indicating if anything was cached for the client (this is currently
needed for invalidation of clients of filters.)
Bug: 769774
Change-Id: I8deeaef8fdd46e6dcc171100e8d6394df483e232
Reviewed-on: https://chromium-review.googlesource.com/941332
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540193}
Split the url mocks into a separate library
Change-Id: I3bbbf936cce2d57dd918d64e8b406dd1b9f9c201
Reviewed-on: https://chromium-review.googlesource.com/943524
Commit-Queue: Alex Clarke <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540192}
Add network traffic annotation to CloudPrintProxyBackend.
Network traffic annotation is added for credential update of Cloud Print
Proxy Backend.
Bug: 656607
Change-Id: I0dab745bfa4efae24d6091f99b2ac1090d230f33
Reviewed-on: https://chromium-review.googlesource.com/926011
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: Scott Byer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540191}
[animation-worklet] Correctly expose EffectProxy is worklet scope
Fix an issue in AnimationWorkletGlobalScope binding generation where
EffectProxy was not being exposed in that scope.
It also adds a test to verify all the interfaces that are exposed in
the animation worklet global scope under origin trial.
The test is relying on console.log and expectation file which is
why I decided to not write it as a testharness based test.
Bug: 811922
Change-Id: If13d3797f908d3f0a3945480e22c6e63cad9f76e
Reviewed-on: https://chromium-review.googlesource.com/935702
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Jason Chase <[email protected]>
Commit-Queue: Majid Valipour <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540190}
Update feature policy header in proxies on nav
The Feature-Policy HTTP header was not being properly replicated when
set in a frame for which proxies already exist. This change fixes the
problem by ensuring that the header is sent to RenderFrameProxy objects
and properly updated there after a nagivation commits.
Bug: 814887
Change-Id: I8dc5bcd3b0af28c36183d467ff5b886062dc41a3
Reviewed-on: https://chromium-review.googlesource.com/940422
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540189}
Change the toolbar's SearchIcon with search engine
This CL updates the the Search Icon used in the toolbar to focus the
omnibox based on the default search engine for the application.
Bug: 816843
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib40e76ed7e8837f8c1150252b9a169e822b93363
Reviewed-on: https://chromium-review.googlesource.com/943067
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540188}
[vr] Extrapolate before ending scroll gestures.
Adds a new "post scroll" state in which we extrapolate briefly before
ending a scroll.
Bug: 817173
Change-Id: I9ce00d4e958c7535e8ab42edf14a1261ab805956
Reviewed-on: https://chromium-review.googlesource.com/941365
Commit-Queue: Ian Vollick <[email protected]>
Reviewed-by: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540187}
Add Saman as a Viz OWNER
Saman has been contributing high quality CLs to Viz for a long time.
Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia1143cd79817c3eea0b589690ac822505481da5e
Reviewed-on: https://chromium-review.googlesource.com/943593
Reviewed-by: Saman Sami <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540186}
[subresource_filter] Fix devtools toggle with site isolation
Multiple PageHandlers can be created with isolating subframes. This
breaks the devtools toggle which expects a single PageHandler for the
main frame.
This CL adds a bit to the PageHandler which classifies whether it is
for the main frame. If it is not, then it cannot change the filtering
toggle.
Bug: 813197
Change-Id: I7698985822f5ee159399bd1d37884436c5278d0b
Reviewed-on: https://chromium-review.googlesource.com/939602
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540185}
Safe Browsing Whitelist for Enterprise
If enterprise policy specified the SafeBrowsingWhitelistDomains,
Chrome should trust URLs in these domains.
This CL covers:
1. Safe Browsing will not check for dangerous resources if their
URLs match these domains (a.k.a no SB interstitial shown)
Note that, we don't plan to skip SSL error checking even if domains
are whitelisted.
2. Safe Browsing's password protection service will not check
for password reuse if the page URL matches these domains.
Changes in download protection, client phishing/malware detection,
incident reporting, ads sampling will be in separate CLs.
Bug: 811454
Change-Id: Ia439642ed1d68890ace4b8049aaec187158e2f5c
Reviewed-on: https://chromium-review.googlesource.com/927531
Reviewed-by: Pavel Yatsuk <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540184}
Port dev tools WebUI from URLFetcher to SimpleURLLoader
This needed to be done at some point. The motivation here was to fix an
extensions WebRequest API test with the Network Service enabled.
This also plumbs through a signal so extensions API test JS code can
detect whether Network Service is enabled. This is used to support
conditional expectations in WebRequest tests since the test-only
event behavior may differ slightly between Network Service and old
networking.
Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I009061f038eb3171721fe7645444695a77f3cfd3
Reviewed-on: https://chromium-review.googlesource.com/940447
Commit-Queue: Ken Rockot <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540183}
[remoteobjects] Convert JavaScript null and undefined to Java types.
A fairly direct copy of CoerceJavaScriptNullOrUndefinedToJavaValue.
Bug: 794320
Change-Id: I6d057198262f589334d100800da63151280a38ce
Reviewed-on: https://chromium-review.googlesource.com/941902
Reviewed-by: Bo <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540182}
WebUI: turn off flaky cr-action-menu test
TBR: dpapad
Bug: 812947
Change-Id: Ib7193b8859e2a105d4d802b267f4fce6775e7a42
Reviewed-on: https://chromium-review.googlesource.com/942883
Commit-Queue: Scott Chen <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540181}
[remoteobjects] Convert JavaScript strings to Java types.
A fairly direct copy of CoerceJavaScriptStringToJavaValue.
Bug: 794320
Change-Id: I4e7cbd020fe9702d59c84a32e0e986f970feace1
Reviewed-on: https://chromium-review.googlesource.com/941788
Reviewed-by: Bo <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540180}
Move MockPermissionManager into //content/public/test
This lets us use it in tests under //chrome/browser.
Bug: 704259
Change-Id: Ic814dd88e5a676e13a0b9629fc422ec70df4f6cd
Reviewed-on: https://chromium-review.googlesource.com/941642
Commit-Queue: Douglas Creager <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540179}
Adjust toolbar's blur effect
This CL adjusts the blur effect used by the toolbar to the one requested
in crbug.com/807778.
It also adjust the color of the tools menu button to match the one from
the other buttons.
Bug: 807284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia03bacf8563cf4b0f9a33a1b4e57dff47b67bfbc
Reviewed-on: https://chromium-review.googlesource.com/941441
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540178}
[remoteobjects] Convert JavaScript booleans to Java types.
A fairly direct copy of CoerceJavaScriptBooleanToJavaValue
Bug: 794320
Change-Id: Ifac567f8b5d300a89d4057e47bb45a28863e715f
Reviewed-on: https://chromium-review.googlesource.com/940346
Reviewed-by: Bo <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540177}
Improve handling of frame reloads in getUserMedia()
This mainly serves as a test for https://crbug.com/816323, but also
removes two DCHECKs that were wrong.
This CL also removes UserMediaProcessor::RequestInfo::HasPendingSources()
since it was used just for implementing two DCHECKs, one of which is no
longer valid due to other recent changes.
No behavior change is intended.
Bug: 816597, 816323
Change-Id: Icfddae5f9a9709e9702f696cb70f289697bdcb6b
Reviewed-on: https://chromium-review.googlesource.com/938041
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540176}
Fix errorprone UseCorrectAssertInTests warnings
Fix errorprone UseCorrectAssertInTests warnings and make
sure it is treated as error after this CL.
http://errorprone.info/bugpattern/UseCorrectAssertInTests
Bug: 803482
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic337a2e0313986961af4390c38bfa47bfdb46325
Reviewed-on: https://chromium-review.googlesource.com/938642
Reviewed-by: Rouslan Solomakhin <[email protected]>
Reviewed-by: Tao Bai <[email protected]>
Reviewed-by: Helen Li <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Rob Buis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540175}
Perform various SETTINGS-related clean-ups.
1. Rename SpdySettingsIds --> SpdyKnownSettingsId.
2. Add a "using SpdySettingsId = uint16_t" statement, and replace
where appropriate (e.g., raw on-the-wire values; should be a
non-functional change),
3. Perform minor refactoring of the utility method for converting
a SETTINGS ID to a string.
This is a first step to additional support for unknown SETTINGS IDs.
Also perform some minor lint clean-ups to appease `git cl lint`, including
string and base::StringPiece --> SpdyString(Piece) (note that the original
error was to include <string>), adding #includes, and fixing line lengths.
This CL lands server change 186360913 by diannahu.
BUG=488484
Change-Id: I99c7efea92e11e355255e54ee70f4a8d1d6496b4
Reviewed-on: https://chromium-review.googlesource.com/938603
Commit-Queue: Dianna Hu <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540174}
Make SitePerProcessInternalsHitTestBrowserTest multi-scale.
Modify this text fixture to parameterize it over multiple device scale
factors.
Bug: 680606
Change-Id: I247afdf39ab9e640c711372ca6d07c66897d6bbd
Reviewed-on: https://chromium-review.googlesource.com/943341
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540173}
Uprev the NTDDI version to Windows 10 RS1
The InputPane APIs first appeared in RS1 version. RS2 or later SDK
is required to build Chrome so changing the version shouldn't be a
problem.
BUG=817501
Change-Id: I1ed1f4a630ffe1d913dee47c03ad4fd45f3c6759
Reviewed-on: https://chromium-review.googlesource.com/941913
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540172}
Re-enable a test in the GCMClientImplTest
This test was disabled almost four years ago for unknown reasons and
passes fine on my machine. Let's see if the bots agree.
https://codereview.chromium.org/209293002
Change-Id: Id62e8c362b7b73861697ad1a82c0189471f60080
Reviewed-on: https://chromium-review.googlesource.com/891188
Reviewed-by: Anita Woodruff <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540171}
Revert "Surface synchronization: Don't evict surface on DelegatedFrameHost::WasResized"
This reverts commit cef2d52eafe822dc3e70df90e832224c95b310cb.
Reason for revert: It's just plain wrong. It broke some viz tests and
it caused the breakage in 817771. We probably want an EvictLastActivatedSurfaces({framesinks}); API instead.
Original change's description:
> Surface synchronization: Don't evict surface on DelegatedFrameHost::WasResized
>
> If we evict a surface before the previous CompositorFrame activates with it
> as a fallback, then we will attempt to add an invalid reference and we may
> end up with missing surfaces in surface aggregator. This CL combats the issue
> by avoiding evicting frames during resize.
>
> We will still only update the primary surface ID if the tab is not hidden,
> and we will clear the fallback surface ID if the tab is hidden.
>
> Bug: 813157, 672962
> Change-Id: Ie0b408af503ec9fefdcccc5fb0607cf015734052
> Reviewed-on: https://chromium-review.googlesource.com/938678
> Reviewed-by: Saman Sami <[email protected]>
> Commit-Queue: Fady Samuel <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539639}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 813157, 672962
Change-Id: If7a78d81d23e646bb52f1d1f666613c6e54af383
Reviewed-on: https://chromium-review.googlesource.com/943161
Reviewed-by: Fady Samuel <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540170}
Fix accessible relations in Views
Ensure that setting relationships in Views plumbs through information
into accessibility API.
Bug: None
Change-Id: I01d6c9e1924046a5465e2a83ff0e22d6170ad8a0
Reviewed-on: https://chromium-review.googlesource.com/922766
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540169}
[Android WebView] Remove unused getTracingControllerOnUiThread glue code
Downstream glue layer patch crrev.com/i/579513 has landed, so
the old upstream getTracingController code is not used anymore
and can be removed.
BUG=781249,808023
[email protected]
Change-Id: I398087a0df8e652528c79de1a2ce16fa99a9423b
Reviewed-on: https://chromium-review.googlesource.com/943441
Reviewed-by: Tim Volodine <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540168}
Re-enable fixed viz_content_unittests
Some viz_content_unittests have been fixed, re-enabling them.
[email protected]
TEST=RenderWidgetHostTest.FrameToken_RendererCrash,
RenderWidgetHostTest.NewContentRenderingTimeout,
RenderWidgetHostTest.SwapCompositorFrameWithBadSourceId
Bug: 760320
Change-Id: Ib52cd12d381575a134893d1d2d6f4b51021b4428
Reviewed-on: https://chromium-review.googlesource.com/943462
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540167}
scrollTo and scrollBy should land on snap points.
According to spec,
https://drafts.csswg.org/css-scroll-snap-1/#scroll-types,
programmatically scrolling such as scrollTo and scrollBy should land on
snap points.
Bug: 803606
Change-Id: I1e70d88f31a2b2f93c92cc063adf653ed923adeb
Reviewed-on: https://chromium-review.googlesource.com/889936
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Sandra Sun <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540166}
[USS] Fully turn on Typed URL for USS
Turned on Typed URL for USS by default, and remove typed URL syncable
service. Also remove profile_sync_service_typed_url_unittest.cc.
Background: profile sync service tests are existing before
integration tests, and now integration tests covered most of them, so
delete profile_sync_service_typed_url_unittest.cc here.
Bug: 81368
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7f53f8b73f09b2b25a7202dff59689b699796965
Reviewed-on: https://chromium-review.googlesource.com/928097
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Pavel Yatsuk <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540165}
Supersize: Switch overhead symbols to padding-only
Overhead should be tracked but these symbols are not actionable. Making
them padding-only removes them from size diffs.
Bug: 814078
Change-Id: I68991f54d4ee990c7bd675c4dd0f22e5337eb9f4
Reviewed-on: https://chromium-review.googlesource.com/941587
Commit-Queue: Peter Wen <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540164}
[omnibox] Add button to tab switch suggestions
Feature change which adds a button to tab switch suggestions (under a
flag). Currently the flag does nothing but let the user evaluate it.
In a subsequent change, the button will invert the selection logic
such that <enter> will navigate, <shift-enter> will switch and the
button will switch.
Bug: 780835
Change-Id: I4453598f95db22fed8cc0bde50ef6d9788a205b2
Reviewed-on: https://chromium-review.googlesource.com/919247
Commit-Queue: Kevin Bailey <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540163}
[SchedulerWorkerPoolImpl] Introduce WaitForNWorkersCleanedUpForTesting()
And use it instead of flaky sleep timings in tests that exercise the
reclaim timeout.
Bonus: this speeds up these tests from ~1500ms to ~500ms in the normal case.
[email protected], [email protected]
Bug: 735701, 803900
Change-Id: I3b271fda6c7b42033ac7b3c128e8663e80acebb3
Reviewed-on: https://chromium-review.googlesource.com/937505
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540162}
Reland "Supersize: Fix pak spurious deltas"
Original CL: https://crrev.com/c/938122
Fix:
- Division by zero when there is no uncompressed pak files.
[email protected]
Bug: 814078,817534
Change-Id: Id3198a84dce95074d13ca20afe4caec45631b0cc
Reviewed-on: https://chromium-review.googlesource.com/943221
Reviewed-by: Peter Wen <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540161}
headless: Add browser test for animated GIFs.
The new test verifies that animated GIFs don't produce CompositorFrames
for animate_only BeginFrames and that their animation is aligned with
virtual time progression.
Also replaces use of --enable-surface-synchronization flag with Feature
and adds a trace event for impl-side invalidations to cc::Scheduler.
Bug: 646774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I24f5a3ab14588f787b3dd571223b4737574929d8
Reviewed-on: https://chromium-review.googlesource.com/941562
Reviewed-by: Fady Samuel <[email protected]>
Reviewed-by: Khushal <[email protected]>
Reviewed-by: Alex Clarke <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540160}
Running multiple shards of benchmarks on the continous build
Change-Id: Ie32821761795bdaaffe3d6a2c0bf6054bd436230
Reviewed-on: https://chromium-review.googlesource.com/931926
Commit-Queue: Emily Hanley <[email protected]>
Reviewed-by: Ashley Enstad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540159}
Remove On/Off status indicator from the Passwords button in Settings
Bug:817785
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id735d1bd561de497e351d0482fa0e21b3c874359
Reviewed-on: https://chromium-review.googlesource.com/943106
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540158}
Update Viz FYI Filters
More tests have been fixed, re-enabling on FYI to start to verify no flakes.
[email protected]
TEST=viz_content_browsertests, viz_browser_tests
Bug: 760181
Change-Id: I3d27ff8372fbe10b46efeb074f2bf07d60e14f43
Reviewed-on: https://chromium-review.googlesource.com/943243
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540157}
Update the V8 version for Chromium branch 66.
This is a roll-back to v8 6.6.346. This is the most stable candidate out of the latest Canaries.
If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.
When in doubt please try to contact the committer and reviewers of this CL before reverting it.
[email protected]
NOTRY=true
Change-Id: I9ca1490f7d5f647abd7788acd3ff385f64d1acc5
Reviewed-on: https://chromium-review.googlesource.com/942902
Commit-Queue: Michael Hablich <[email protected]>
Reviewed-by: Michael Hablich <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540156}
Add use counters for DTMF features we will deprecate
These counters measure non-standard features, except
for the "dtmf" attribute which measures the standard feature
that is replacing a non-standard feature (createDTMFSender).
Bug: 812587
Change-Id: Iffd97a87fbc81a3c9b6f9a8afbd3c775220da1d1
Reviewed-on: https://chromium-review.googlesource.com/941802
Commit-Queue: Harald Alvestrand <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540155}
[SchedulerWorkerPoolImpl] Make sure workers do not cleanup during WaitForWorkersIdle*().
While auditing the code I noticed that this was a problem: if a worker
cleans up while waiting for n workers to be idle, the idle stack will
shrink and this condition may never be reached.
This prevents this completely for WaitForAllWorkersIdleForTesting() and
greatly reduces the likelihood for WaitForWorkersIdleForTesting(n).
WaitForAllWorkersIdleForTesting() is safe because "n" is obtained under
the lock. Whereas an external call to WaitForWorkersIdleForTesting(n)
could wait on a worker which was already detached. But in practice
if the reclaim timeout is long enough and the main thread invokes this
immediately after unblocking a test task and waiting for it to resolve,
the race would require the main thread to be preempted for the full
reclaim timeout for no reason which seems highly unlikely.
Audited current usage and added a comment as such.
[email protected], [email protected]
Bug: 816170, 735701
Change-Id: Ie7b4fd81c04f53cc9597ebc02a25b39d4f1d658f
Reviewed-on: https://chromium-review.googlesource.com/937361
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540154}
Oilpan: Limit trace depth for VisitPersistents
Limit trace depth for VisitPersistents so we don't trace most of the object graph in one go.
Bug: 757440
Change-Id: Ib43956d4b6f128169ada158e849f6e9668591378
Reviewed-on: https://chromium-review.googlesource.com/937421
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540153}
Apply constructed stylesheets CSSOM changes
This change is the continuation of crrev.com/c/925763. With this change,
CSSOM changes to constructed stylesheets are reflected on all TreeScopes
where the style is applied to.
Spec draft: https://wicg.github.io/construct-stylesheets/#dom-cssstylesheet-cssstylesheet
Bug: 807560
Change-Id: I1cddeea9dc346aa238fa4d0aabe233397166e2a5
Reviewed-on: https://chromium-review.googlesource.com/938872
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540152}
Make CrossSite* browser tests work with the network service
This CL replaces the usage of a ResourceDispatcherHostDelegate in
CrossSite* content_browsertests by TestNavigationManagers. It also moves
the remaining CrossSiteResourceHandlerTest into the
CrossSiteTransferTests.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie10a45ce406471d4286fbc893e870cb044c4c4ac
Reviewed-on: https://chromium-review.googlesource.com/922182
Commit-Queue: Camille Lamy <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540151}
WatchTime: add field recording whether a player was autoplay iniated.
This is done by keeping track of whether a playback was autoplay
initiated when starting and always returning this value to the
WatchTimeReporter.
Bug: 814268
Change-Id: Id34b73047df7a68ee8bb19d6f25285930a85d60e
Reviewed-on: https://chromium-review.googlesource.com/923984
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540150}
Handle WebContents occlusion on aura.
With this CL, when a WebContents is occluded on aura:
- WebContents::GetVisibility returns OCCLUDED
- RenderWidgetHostImpl::WasHidden is called on all
RenderWidgetHostImpls that belong to the WebContents.
That allows:
- Changing the priority of renderer processes to background.
- Not rendering frames unnecessarily.
Bug: 668690
Change-Id: Ie1c86d271276576a6b5c7adfb11bd0e42d5d491e
Reviewed-on: https://chromium-review.googlesource.com/937820
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540149}
Add annotation to PeerConnectionFactory.
Network traffic annotation is added to
content/renderer/media/webrtc/peer_connection_dependency_factory.cc
Bug: 656607
Change-Id: Ie88c13b8ab6f28e7604f48d134c231b16ab18a61
Reviewed-on: https://chromium-review.googlesource.com/934127
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: Taylor Brandstetter <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540148}
Make LayerTreeHost::SetViewportSizeAndScale set painted DSF
The device_scale_factor_ and painted_device_scale_factor_
members of LayerTreeHost are mutually exclusive -- a tree
will either use one or the other (and leave the unused member
as 1). Prior to this cleanup we would call SetDeviceScaleFactor
or SetPaintedDeviceScaleFactor to update these variables.
Add a LayerTreeSettings member to select the device scale factor
mode, and make LayerTreeHost::SetViewportSizeAndScale update
the specified variable.
Remove the remaining calls to SetPaintedDeviceScaleFactor (from
Android's compositor) and remove the function.
Remove RenderWidgetCompositor::SetDeviceScaleFactor, and several
related WebKit functions that called this. The call was only
necessary to work around a bug where we did not specify the
"original" (aka "non-emulated") device scale factor in
RenderWidget::UpdateCompositorSurface non-IsUseZoomForDSFEnabled
mode.
R=dgozman,piman,fsamuel
TBR=pdr (for public/)
Bug: 805774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I233727da320b14b041bb48515da3cfb0d2be1ea4
Reviewed-on: https://chromium-review.googlesource.com/938958
Commit-Queue: ccameron <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540147}
Add display compositor thread to thread_times metrics
The VizDisplayCompositor feature moves the display compositor off the
browser main thread and into the GPU process on a dedicated thread. Make
sure that the display compositor thread is recorded separately in the
thread_times benchmark and counted as part of the fast path total.
Bug: 778749
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ic18c3564ecf5e192f2dcf1e2e272dac3c99d8873
Reviewed-on: https://chromium-review.googlesource.com/937398
Commit-Queue: kylechar <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Reviewed-by: Brian Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540146}
Add fontLoaded event to dev tools protocol CSS domain.
This event notifies the dev tools client when a web font has successfully
loaded. Event information includes the font-family, src, and other font
properties, as well as the resolved platform font family name.
[email protected]
Bug: 803226
Change-Id: I2bb399ce1c08b0a397f8eb94d95aa85556ebb2c1
Reviewed-on: https://chromium-review.googlesource.com/905829
Commit-Queue: Dominik Röttsches <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540145}
Re-introduce new Clear Browsing Data UI
Partial manual revert of https://crrev.com/c/903245 to accomodate
the refactoring done in ios/chrome/browser/browsing_data.
Notable changes:
- removed class IOSBrowsingDataCounterFactory that was used
purely for namespacing a static function and instead used
a free function in an anonymous namespace
- use BrowsingDataRemoverObserver to watch for removal of
browsing data instead of using subscription with the old
global CallbackList
- introduced chrome://flags#new-clear-browsing-data-ui
flags (backed by a feature) to enable or disable the
new UI
- fix presubmit checks by converting uses of base::Bind to
base::Bind{Repeating,Once}
- re-enabled disabled tests
Bug: 760084
Change-Id: I18a59144f2ba461e096d1e009261a2e717e463b7
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/939624
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540144}
Don't return blacklisted credentials via CM API.
Previously navigator.credentials.get() would return a blacklisted credential like a normal password. It's a problem if due to another bug the username isn't empty.
Bug: 817754
Change-Id: I51f79e8399f0566438ce203cb9338bd5e4dc5f0d
Reviewed-on: https://chromium-review.googlesource.com/942921
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540143}
Handle the Unicode NBSP character in SyncConfirmationUI
The SyncConfirmationUI class passes a set of strings to the
chrome://sync-confirmation WebUI. The strings relevant to consent
recording are then extracted from HTML and passed back to the C++ side,
to SyncConfirmationHandler.
At the same time, SyncConfirmationUI passes a copy of these strings
directly to SyncConfirmationHandler to verify that they weren't altered.
This assertion failed for string translations that contain the Unicode
NBSP symbol. This symbol was serialized into HTML as " ", and so
the set of strings passed to SyncConfirmationHandler from
chrome://sync-confirmation no longer matched those passed directly.
Bug: 816862,781765
Change-Id: Icb3e2cb35326ba72e8aa340dc1d73a77d0ea2c59
Reviewed-on: https://chromium-review.googlesource.com/942321
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540142}
chrome://dino improve hybrid device support
Change the way touch is detected, so we listen to touch events
regardless of device. The touch controller is added at the
point the game is started with touch.
This caters for hybrid devices, where the game could be started by
keyboard or touch.
Bug: 784279
Change-Id: Ie173825dbc4353a38444f864b39108d8e38e92c0
Reviewed-on: https://chromium-review.googlesource.com/939478
Reviewed-by: Julia Tuttle <[email protected]>
Commit-Queue: Edward Jung <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540141}
Revert "Record visible load time metric for images"
This reverts commit a1d023d3d3ca0c6c1484872285f542d6e8eb5d1e.
Reason for revert: Causes large battery usage regression on Go devices.
Original change's description:
> Record visible load time metric for images
>
> This metric tracks how long the user has to wait for a visible image to
> load completely. This metric will help understand how much delay does
> lazyload of images incurs users.
>
> Bug: 812684
> Change-Id: Ic97c9a192254a2b64d9f2427d8694d6e36759db9
> Reviewed-on: https://chromium-review.googlesource.com/831530
> Commit-Queue: rajendrant <[email protected]>
> Reviewed-by: Robert Kaplow <[email protected]>
> Reviewed-by: Scott Little <[email protected]>
> Reviewed-by: Fredrik Söderquist <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539221}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 812684
Bug: 816944
Change-Id: I000e532a22150dc600b3e49337a8507cdeace504
Reviewed-on: https://chromium-review.googlesource.com/942861
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Commit-Queue: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540140}
Settings[DICE]: a11y fixes
Bug: 814995, 814996
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0537d1b713e5b781995bb6dc1ee958b53e4e3bc9
Reviewed-on: https://chromium-review.googlesource.com/935746
Reviewed-by: Hector Carmona <[email protected]>
Commit-Queue: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540139}
Blink Scheduler: Trace some states in toplevel category.
Backgrounding, audio playing, keep-active mode, and process type
are fairly important states of the renderer.
Change-Id: Idde31df06b4f046ce1cd5692390b1dccbf56da85
Reviewed-on: https://chromium-review.googlesource.com/939963
Commit-Queue: Greg Kraynov <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540138}
Disable flaky ash unittest under mash
[email protected]
Bug: 817327
Change-Id: I5ffb15a717f732db5543cd682ac54b443b663a80
Reviewed-on: https://chromium-review.googlesource.com/942906
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540137}
Disable WebViewInteractiveTest.KeyboardFocusSimple on MacOSX.
[email protected]
Bug: 817066
Change-Id: I940c9a93ac05e3e2245fa7bafc42cd812d03a514
Reviewed-on: https://chromium-review.googlesource.com/942903
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540136}
Introduce task_scheduler.flow category.
This extracts task_scheduler.flow from toplevel.flow. toplevel.flow has
way too many events at the moment and is essentially unusable (results
in massive traces which are slow to visualize).
Unfortunately the tracing macros result in a static variable
that assumes the category never changes (INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO).
As such the code in task_annotator.cc cannot be reused to log events
to a provided category. Instead TaskAnnotator now supports nullptr to
disable trace events and TaskScheduler adds its own trace flow events.
Bonus: restricted the scope of the TRACE_EVENT_FLAG_FLOW_IN events
such that the event "receiving the task" precedes TaskAnnotator::RunTask
instead of overlapping with it. This will make flow arrows line up
nicer.
[email protected], [email protected]
Bug: 811035
Change-Id: I1b4042c225486df0caf6c242f1f111291b2a1101
Reviewed-on: https://chromium-review.googlesource.com/939177
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540135}
Allow extension URLs in UKM.
Extensions are covered by a different setting under sync. If that
setting is enabled then extension:// urls can be included in UKM
information. This only works if the broader system has consent.
Bug: 810766
Change-Id: Id0ba274ee4bceafe4521ce1f2f1060533cccc2ac
Reviewed-on: https://chromium-review.googlesource.com/911591
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Bryan McQuade <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540134}
quic_framer.cc: Fix MSVC warning about signed/unsigned mismatch in comparison
num_ack_blocks is a uint8_t, so "num_ack_blocks - 1" would have type int, causing
MSVC to warn.
TBR=rch
Bug: 817722
Change-Id: I4d9cbc0cf266dc00174ab73f66d80e56fc007ad2
Reviewed-on: https://chromium-review.googlesource.com/941945
Commit-Queue: Hans Wennborg <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540133}
Roll src/third_party/catapult/ b019720d0..279fcf542 (7 commits)
https://chromium.googlesource.com/catapult.git/+log/b019720d08b2..279fcf542e09
$ git log b019720d0..279fcf542 --date=short --no-merges --format='%ad %ae %s'
2018-03-01 perezju Revert "[Telemetry] Remove PageTestResults.failures getter"
2018-02-28 perezju Reland "[Telemetry] Simplify code for --browser=exact on Android"
2018-02-28 eakuefner [TBMv2] Allow nulls to be stably stringified
2018-02-28 eakuefner [Telemetry] Don't populate benchmark_descriptions if not set
2018-02-28 eakuefner [TBMv2] Factor mergeHistograms out in merge_histograms_cmdline
2018-02-27 eakuefner [Telemetry] Remove PageTestResults.failures getter
2018-02-28 eakuefner [Dashboard] Remove spurious print in add_histograms_queue
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I6dd7aaf71029d8ff15086e2d59eb8588c19d7710
Reviewed-on: https://chromium-review.googlesource.com/942801
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540132}
Make SelectionAdjuster to handle collapsed selection correctly
This patch makes |SelectionAdjuster| not to call |SetAsBackwardSelection()|
of |SelectionTemplate::Builder| with logically collapsed range because
|SetAsBackwardSelection()| expects |range.end > range.start|.
Note: |EphemeralRange| constructor checks |start <= end|
Note: logically collapsed range means |Position::CompareTo(other)| for start
and end positions returns 0, e.g. "abc"@0 and before "abc".
This patch is a preparation of the patch[1].
[1] http://crrev.com/c/939142 Utilize selection_test() to
editing/selection/select-across-readonly-input-[1-5].html
Change-Id: I6e39b69aa9b0975255d262f9346506d22f800dad
Reviewed-on: https://chromium-review.googlesource.com/938871
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540131}
Add experimental support for the native macOS echo canceller
This CL adds platform support for the native echo canceller available in macOS 10.12+, as well as a way to enable it through a runtime flag or Origin Trial.
A native echo canceller has the opportunity to perform better than a general one in that it can be tuned for the hardware platform in question. In this case, it's also closer to the hardware, so it's less likely to be affected by IPC glitches.
Intent to Implement discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kEld5OudUOM
Bug: chromium:776327
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia828ae2b9e6503ca814de4154dee96c63b838e1d
Reviewed-on: https://chromium-review.googlesource.com/941321
Commit-Queue: Oskar Sundbom <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Tommi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540130}
Remove BaseTimerMethodPointer
This CL moves RepeatingTimer and OneShotTimer to Timer by removing
BaseTimerMethodPointer, which is a middle level class.
Bug: 817344
Change-Id: I33ff580694a7359332ca4fcdc39b9d58c1d091b6
Reviewed-on: https://chromium-review.googlesource.com/940903
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Taiju Tsuiki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540129}
headless/viz: Prepare headless for viz compatibility.
Viz doesn't really support WebContentsObserver::DidReceiveCompositorFrame. As our
use of this for headless isn't really necessary in full-pipe + surface-sync mode
(now our supported configuration), this patch removes this use along with related
DevTools parameters / events.
Also refactors CompositorController / VirtualTimeController's
StartDeferrer: CompositorController is now able to defer both start and
resume of virtual time. This way, it knows for certain that all other
tasks have completed the current virtual time pause and that virtual
time is about to resume.
Tests still fail with --enable-features=VizDisplayCompositor, probably because
viz's support for software compositing isn't fully ready yet.
Bug: 786067
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iba775e4ef7ed77d7d7bf9837d6971be70a53cedb
Reviewed-on: https://chromium-review.googlesource.com/934723
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Alex Clarke <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540128}
[signin] Fix sync confirmation dialog for mac.
Same fix as CL https://chromium-review.googlesource.com/934244 but for Mac.
Bug: 814555
Change-Id: Ie4e04b8f1b586daee5a8b4a876d023ab1d09896a
Reviewed-on: https://chromium-review.googlesource.com/939393
Commit-Queue: Scott Chen <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540127}
Remove Android Tango related code.
BUG=674440
Change-Id: Ie33ae36877d56987bb3b1ea366558a6afb677a8f
Reviewed-on: https://chromium-review.googlesource.com/940301
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Aleksandar Stojiljkovic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540126}
Wallet Sync: Add metrics for added/removed cards and addresses
This adds UMA histograms to record the number of Wallet credit cards
and addresses that were added and removed during each Sync cycle (i.e.
during startup, and whenever we receive an update from the server).
Bug: 816831
Change-Id: I6673e1737f79dea9669b3a96f0ae9164645ea8da
Reviewed-on: https://chromium-review.googlesource.com/937710
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540125}
Use LoadIfNecessary instead of Tab -view
In PreloadController, use NavigationManager::LoadIfNecessary
instead of calling Tab -view to force the navigation.
Bug: 705819
Change-Id: If7814ebd60e1100f56bcb15d817f1d8ec04be1b2
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/941330
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540124}
Automated Commit: Committing new LKGM version 10448.0.0 for chromeos.
[email protected]
Change-Id: Ibe9c43518045a8ef7e9034c22f551b9a9f77133e
Reviewed-on: https://chromium-review.googlesource.com/941829
Reviewed-by: ChromeOS Commit Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540123}
Fix MediaObserver notifications in MediaStreamManager.
This CL fixes the stream type used to notify MediaObserver about
cancelled MediaStream requests.
Before this CL, NUM_MEDIA_TYPES was used as stream type to indicate
that all stream types should be cancelled.
However, the MediaObserver end does not interpret NUM_MEDIA_TYPES this
way and the request to update the UI is ignored.
This CL sends a separate notification for each stream type so that the
UI actually gets updated for all stream types in use.
Bug: 816033
Change-Id: Ib7d3b3046d1dd0976627f8ab38abf086eacc9405
Reviewed-on: https://chromium-review.googlesource.com/939630
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540122}
Import wpt@0d843d4cf1a8424884d43ead98c2528f9c6110c5
Using wpt-import in Chromium 0113f1b856e0b8e5b80f2f5eca725f96eba3efca.
With Chromium commits locally applied on WPT:
1f9508a413 "[css-layout-api] Populate children, and pass into layout() function"
Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13031
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-text/line-break
[email protected]
No-Export: true
Change-Id: I3e16bd64e4dae71440017bdf93f5eaada0aaa4b8
Reviewed-on: https://chromium-review.googlesource.com/941827
Commit-Queue: Blink WPT Bot <[email protected]>
Reviewed-by: Blink WPT Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540121}
For Puppeteer add Browser.getCommandLine
This lets Pupeteer in deterministic mode check if the browser was launched with
--headless and --deterministic-fetch. This is required for Puppeteer.connect
to work in deterministic mode and without checking the command line arguments
it's likely a hard failure mode to detect.
Change-Id: Ifdbf7e9ba7897217cd27918ae95a7ecc10b9da9c
Reviewed-on: https://chromium-review.googlesource.com/939472
Commit-Queue: Alex Clarke <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540120}
[SchedulerWorkerPoolImpl] Remove DisallowWorkerCleanupForTesting().
Since cleanup was made thread-safe in r539095 (and disallowing
synchronized on |lock_| in r538388):
This was now only needed during JoinForTesting() to ensure
workers in |workers_copy| didn't decide to cleanup during join. As such,
always ban cleanup during join and remove the API to control that bit.
[email protected], [email protected]
Bug: 810464
Change-Id: I46edfcc7e37f3a5cb54320b0c38cad5d567c8eb7
Reviewed-on: https://chromium-review.googlesource.com/937264
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540119}
Use per-frame task runners at WebDataConsumerHandleImpl::handle_watcher_
This CL also fixes WebDataConsumerHandle and its children classes.
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.
Bug: 780785, 786332
Change-Id: Ia0ab834c52614190a49d74b177f07b2f3b3193e0
Reviewed-on: https://chromium-review.googlesource.com/934381
Commit-Queue: Hajime Hoshi <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540118}
[Dice] Fix height of the DiceSiginButton text
This CL sets the minimum height of the button
text in the DiceSigninButton to ensure enough
spacing.
See specs related to minimum text height in
https://bugs.chromium.org/p/chromium/issues/detail?id=814809#c11
Bug: 814809
Change-Id: I8c02feb88ec51103df204185d46dfc674fb26e06
Reviewed-on: https://chromium-review.googlesource.com/941942
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540117}
Update V8 to version 6.6.355.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0638561d..fd158bc4
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: I2ea88940591337761c1e5a037672baca70a12f75
Reviewed-on: https://chromium-review.googlesource.com/942264
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540116}
Update WATCHLIST for blink_common
[email protected]
Change-Id: Ie389c62271a75872439dfe72369c4518bee8c3cd
Reviewed-on: https://chromium-review.googlesource.com/942288
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540115}
[MDC roll] Roll Material Components to 9de3fbdb9d71fdb0f643f5320a7331854651b592
TBR=smut
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I020053012b5097dbb555d50879e7c802b3d3f534
Reviewed-on: https://chromium-review.googlesource.com/942268
Commit-Queue: iOS Autoroller <[email protected]>
Reviewed-by: iOS Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540114}
Add mastiz@ as owner of sync
As per ownership handover, and now that I feel comfortable enough with
the codebase.
Bug: None
Change-Id: Ib96afc8e4d8a45681f8124b68758c10646b6da71
Reviewed-on: https://chromium-review.googlesource.com/940137
Reviewed-by: Nicolas Zea (slow) <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540113}
Implement smart bounded text navigation
Currently:
- in multi-line text fields (i.e. text areas and content editables), Search now gets used in the same way as Chrome OS's default mappings
- examples: Search+RIght invokes "end", Search+Ctrl+Right = control+end, etc
- single lined text fields are unaffected
- this new mapping also applies to Google Docs
After this change:
- search+up/down, search+left/right will exit the editable if selection is on the first or last line of the editable (respectively)
Bug: 801590
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I991eb74d77120b2f2479a78b1b1658b31f354d85
Reviewed-on: https://chromium-review.googlesource.com/895244
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540112}
Rename editing/deleting/25322-1.html to delete_after_block_image.html
This patch renames "25322-1.html" to "delete_after_block_image.html" to provide
a hint what this test file verifies for improving code health.
This patch is a follow-up of the patch[1].
[1] http://crrev.com/c/940726 Rewrite editing/deleting/25322-[1-5].html to
utilize selection_test()
[email protected]
Change-Id: Ia08e0225107eca945e01f84d4480f02e4f5cfd8f
Reviewed-on: https://chromium-review.googlesource.com/942599
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540111}
Reenable TwoClientApp[s|List]SyncTest.StartWithDifferentApps
These were disabled in 2014/2015 and seem to be passing locally.
Let's reenable and see what breaks.
Bug: 434438
Change-Id: I88ca33ea242716d47b25508685cd09b3c68f0749
Reviewed-on: https://chromium-review.googlesource.com/941216
Reviewed-by: Pavel Yatsuk <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540110}
Reenable 2 TwoClientBookmarksSyncTests
Namely SC_MovingBMsFromBMBarToBMFolder and SC_MovingBMsFromBMFoldToBMBar.
These were disabled back in 2014, and seem to be consistently passing now
(when run locally). Let's reenable them and see what happens.
Bug: 412169
Change-Id: I41ff880f3ce382692e87ce7782bc3176d70a1aaf
Reviewed-on: https://chromium-review.googlesource.com/941447
Reviewed-by: Pavel Yatsuk <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540109}
Reenable TwoClientSessionsSyncTest.SingleClientEnabledEncryptionAndChanged
This test has been disabled back in 2015, and it now seems to pass
consistently when run locally. Let's reenable it and see what happens.
Bug: 420979
Change-Id: Iacd55f5d80dc28764686868a7826119b77e262e7
Reviewed-on: https://chromium-review.googlesource.com/941228
Reviewed-by: Pavel Yatsuk <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540108}
Rename url function in util.js.
This CL renames a global function named url, which will conflict with
mojo namespaces in crrev.com/c/936349.
Bug: 632206
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I96908ac1adfcae0a565350e50f206ab1da1539be
Reviewed-on: https://chromium-review.googlesource.com/937007
Commit-Queue: calamity <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540107}
Changed std::find() to ContainsValue() in src/ash/*
Bug: 561800
Change-Id: I77a9513fab04bcc8117f47424b4ec49f13e5b8c5
Reviewed-on: https://chromium-review.googlesource.com/940709
Reviewed-by: srirama chandra sekhar <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Commit-Queue: srirama chandra sekhar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540106}
Rename 5126166.html to delete_selection_ends_inside_empty_table_cell.html
This patch renames "5126166.html"
to "delete_selection_ends_inside_empty_table_cell.html" to provide hint
about what this test file verifies.
See also: crrev.com/c/907712
Change-Id: Ie1bc7d0645d5f0ce4dd61762feb41c359d26b149
Reviewed-on: https://chromium-review.googlesource.com/942127
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540105}
Mark media-src-suspend-before-have-metadata.html as flaky
TBR: [email protected]
Bug: 817705
Change-Id: Ib8ee6bc048b39aadd1ac3dc69fd4aadb1176ec49
Reviewed-on: https://chromium-review.googlesource.com/942596
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540104}
Import wpt@66ffd921b533a3da766797aad016820ee90ca465
Using wpt-import in Chromium 25c1dd7ac3f592b3d913964104ca60c5a12ec4d2.
With Chromium commits locally applied on WPT:
1f9508a413 "[css-layout-api] Populate children, and pass into layout() function"
48dc8954a1 "[css-typed-om] Ensure properties works with css-wide keywords / var refs"
Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13030
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
TBR=kereliuk
No-Export: true
Change-Id: I6dca0bdd5eece650c89e91fa1524f4a41274f438
Reviewed-on: https://chromium-review.googlesource.com/942265
Commit-Queue: Blink WPT Bot <[email protected]>
Reviewed-by: Blink WPT Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540103}
Remove the "severe" upgrade annoyance level.
It seems that this has never been used.
BUG=511300
Change-Id: If8c07c5b8a713873742e1b8e628b4f718cdda5ff
Reviewed-on: https://chromium-review.googlesource.com/939962
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Sarah Chan <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540102}
Roll src/third_party/skia/ ba7a16519..9e8a59490 (11 commits)
https://skia.googlesource.com/skia.git/+log/ba7a16519468..9e8a59490531
$ git log ba7a16519..9e8a59490 --date=short --no-merges --format='%ad %ae %s'
2018-02-28 scroggo Support pngs with incorrect CMF bytes
2018-02-28 benjaminwagner Upgrade the Radeon GPU drivers.
2018-02-28 benjaminwagner Revert "Upgrade IntelIris540 Win10 GPU driver."
2018-02-28 benjaminwagner Switch remaining Win10 Skolo bots to new Windows image.
2018-02-28 caryclark make SkDestinationSurfaceColorMode private
2018-02-28 jvanverth Fall back to blurs for unsupported DrawShadow cases
2018-02-28 halcanary SkPDF: encode metadata strings correctly
2018-02-28 egdaniel Respect disable driver correctness workaround flag in Vulkan
2018-02-22 jvanverth Remove deprecated drawShadow interfaces
2018-02-27 ethannicholas Update certain instrinsic calls in SkSL SPIR-V gen to not mix vectors and scalars.
2018-02-27 benjaminwagner Upgrade IntelIris540 Win10 GPU driver.
Created with:
roll-dep src/third_party/skia
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I286a8af78d4ba525fb55095db781ffff7fe0c40f
Reviewed-on: https://chromium-review.googlesource.com/941985
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540101}
Move DispatchClipboardEvent() to EditorCommand.cpp
Editor::DispatchClipboardEvent() is only called in EditorCommand.cpp,
Move it to make |Editor| class simpler for improving code health.
Bug: 672405
Signed-off-by: Zhuoyu Qian <[email protected]>
Change-Id: Id7f8647cbd3eaa7d101ce46dae1f56b42b08edc0
Reviewed-on: https://chromium-review.googlesource.com/940785
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540100}
Cookie Store: Extract change notifications to separate classes.
Currently, CookieStore implementations are responsible for storing
cookies and dispatching notifications when the cookies they store
change. The dispatch logic is non-trivial, and will grow to support the
Async Cookies API (see the associated bug), so it deserves its own
class.
This CL splits off the change notification dispatch as follows:
* CookieStore -> CookieChangeDispatcher
* CookieMonster -> CookieMonsterChangeDispatcher
* AwCookieStoreWrapper -> AwCookieStoreChangeDispatcherWrapper
* CookieStoreIOS -> CookieChangeDispatcherIOS
Due to complexities and upcoming refactoring in the iOS CookieStore
implementations, the existing implementation is not split up. Instead,
CookieChangeDispatcherIOS is a proxy that directs AddCallback*() calls
to CookieStoreIOS. The other CookieStore implementations (CookieMonster,
AwCookieStoreWrapper) have the change notification dispatch code moved
into the ChangeDispatcher classes.
This CL also changes the listener registration APIs to pass
base::Callbacks by value instead of passing them by reference, per
https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md
This CL is large, but only does renames / code moving / minor cleanups.
It opens up the way for a small (but dense) CL that will revamp the
notification dispatch logic.
Bug: 729800
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie56b036419a85f7802c6b1d4bb2c935b58232374
Reviewed-on: https://chromium-review.googlesource.com/919159
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Randy Smith <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Mohammad Refaat <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540099}
Revert "AppShell: Support reloading"
This reverts commit 65478d123ddee27fc9cdcc29621a3e299d2562ee.
Reason for revert: Caused build failure on Mac
https://ci.chromium.org/buildbot/chromium/Mac/38768
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FMac%2F38768%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
Undefined symbols for architecture x86_64:
"extensions::ShellNativeAppWindowAura::ShellNativeAppWindowAura(extensions::AppWindow*, extensions::AppWindow::CreateParams const&)", referenced from:
extensions::(anonymous namespace)::TestAppWindowClient::CreateNativeAppWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams*) in shell_extension_loader_unittest.o
"extensions::ShellTestBaseAura::SetUp()", referenced from:
extensions::ShellExtensionLoaderTest::SetUp() in shell_extension_loader_unittest.o
"extensions::ShellTestBaseAura::ShellTestBaseAura()", referenced from:
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_Extension_Test>::CreateTest() in shell_extension_loader_unittest.o
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_AppLaunch_Test>::CreateTest() in shell_extension_loader_unittest.o
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test>::CreateTest() in shell_extension_loader_unittest.o
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_NotFound_Test>::CreateTest() in shell_extension_loader_unittest.o
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_ReloadFailure_Test>::CreateTest() in shell_extension_loader_unittest.o
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_LoadAfterReloadFailure_Test>::CreateTest() in shell_extension_loader_unittest.o
testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_LoadDisabledExtension_Test>::CreateTest() in shell_extension_loader_unittest.o
...
"extensions::ShellTestBaseAura::~ShellTestBaseAura()", referenced from:
extensions::ShellExtensionLoaderTest_Extension_Test::~ShellExtensionLoaderTest_Extension_Test() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_Extension_Test::~ShellExtensionLoaderTest_Extension_Test() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_AppLaunch_Test::~ShellExtensionLoaderTest_AppLaunch_Test() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_AppLaunch_Test::~ShellExtensionLoaderTest_AppLaunch_Test() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::~ShellExtensionLoaderTest_AppLaunchAndReload_Test() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::~ShellExtensionLoaderTest_AppLaunchAndReload_Test() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_NotFound_Test::~ShellExtensionLoaderTest_NotFound_Test() in shell_extension_loader_unittest.o
...
"extensions::ShellTestBaseAura::TearDown()", referenced from:
extensions::ShellExtensionLoaderTest::TearDown() in shell_extension_loader_unittest.o
"extensions::ShellTestBaseAura::InitAppWindow(extensions::AppWindow*, gfx::Rect const&)", referenced from:
extensions::ShellExtensionLoaderTest_AppLaunch_Test::TestBody() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::TestBody() in shell_extension_loader_unittest.o
extensions::ShellExtensionLoaderTest_ReloadFailure_Test::TestBody() in shell_extension_loader_unittest.o
ld: symbol(s) not found for architecture x86_64
Original change's description:
> AppShell: Support reloading
>
> Implement reloading in ExtensionLoader. Uses keep-alives while apps are
> reloading. A future CL will observe these keep-alives to keep app_shell open
> during reload.
>
> Bug: 762642
> Change-Id: Ia20b81378d1aeab4ace119d9d2a8b44c2461fdcf
> Reviewed-on: https://chromium-review.googlesource.com/912694
> Commit-Queue: Michael Giuffrida <[email protected]>
> Reviewed-by: Devlin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#540079}
[email protected],[email protected]
Change-Id: I2db08946671be6eb37fd3f4d658573b87dd3c1b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762642
Reviewed-on: https://chromium-review.googlesource.com/942701
Reviewed-by: Tsuyoshi Horo <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540098}
Fix flakiness in AutomationApiTest.DesktopHitTestIframe
At least one issue was that the loadComplete event was sometimes being
received on a frame with an empty url.
Bug: 808343,622387
Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce
Reviewed-on: https://chromium-review.googlesource.com/938495
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540097}
Fix condition for downloading content_shell_fonts.
These fonts are used on android too.
Change-Id: I0280f681579c2c227f4da4534a194cd04d53000d
Reviewed-on: https://chromium-review.googlesource.com/937207
Commit-Queue: Alexander Semashko <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540096}
Implement fetch() abort
- Add an optional |signal| property to RequestInit
- Add a |signal| property to Request, chained from RequestInit's signal
- Create a chained AbortSignal in Request clone()
- Add an Abort() method to FetchManager::Loader
- Add an AbortSignal parameter to FetchManager::Fetch()
- Add an AbortSignal member to FetchManager::Loader and BodyStreamBuffer
The implementation closely follows the Fetch standard, particularly the
initialisationn of |signal| in the Request constructor:
https://fetch.spec.whatwg.org/#request-class and the signal-related
steps in the fetch method: https://fetch.spec.whatwg.org/#fetch-method.
The AbortSignal member of BodyStreamBuffer is only set for Response
objects. It is not meaningful for Request objects. In addition, it is
not set when a Response is created from a stream, as there is no
associated Request that JS code could use to abort the response.
The design doc is at
https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit.
The Intent to Ship thread is at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ.
Known issues: when abort is signaled between a body access method like
arrayBuffer() being called and the returned promise resolving, the
promise will reject with a TypeError rather than an AbortError.
See http://crbug.com/817687.
BUG=750599
Change-Id: I19dfb311f55fcdc566b07449ef2c61ef7be301c7
Reviewed-on: https://chromium-review.googlesource.com/934542
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540095}
accLocation should return unclipped bounds.
See bug for motivation. Adds separate AXPlatformNodeDelegate interfaces
for clipped and unclipped for maximum code clarity.
Note that we still want clipped bounds around for hit testing.
Bug: 810762
Change-Id: I1b08977e9753fb918b6a4b41f152a238caae12e3
Reviewed-on: https://chromium-review.googlesource.com/938024
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540094}
Roll Fuchsia SDK to 9d4016533477903c796470e7ab46c2e1dad31761.
- Removes sys/resource.h, requiring some additional conditionals around
includes of that header under OS_POSIX.
- Improves the system PRNG implementation to reduce the potential for
lock contention.
TBR: scottmg
Bug: 707030, 801353, 809660, 738275, 817241, 817586
Change-Id: I4e01a0b23ad66c060ac7a6776a45329775117886
Reviewed-on: https://chromium-review.googlesource.com/942685
Reviewed-by: Wez <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540093}
Check if GetResourceLoadTiming is null in GenerateResourceTiming
Bug: 773591
Change-Id: Id49125101500155aa291fb7d3d13ff6ae2e4889d
Reviewed-on: https://chromium-review.googlesource.com/940285
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540092}
Roll AFDO from 66.0.3357.0_rc-r1 to 66.0.3358.0_rc-r1
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iccc5b7e77827613fa56a15a9f9e9ea16390ee347
Reviewed-on: https://chromium-review.googlesource.com/942691
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540091}
Expose --top-chrome-md=touch-optimized in chrome://flags on Linux/CrOS.
Bug: 801582
Change-Id: Ib2afbbeee9fb45137d7942159ef517d3c769f13b
Reviewed-on: https://chromium-review.googlesource.com/942584
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540090}
[auto] Update FlagExpectations for LayoutNG
Following bot results are included.
3996 4000 4001
11 new text rendering differences and 1 improved JS test result are
rebaselined after manual reviews, included in this patch.
113 lines were removed and 44 lines were deflaked by consecutive
results since 3964.
[email protected]
NOTRY=true
Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I10496a02c0ad4abc37e40716f15bed833f3b6211
Reviewed-on: https://chromium-review.googlesource.com/940365
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540089}
Re-enable DumpAccessibilityTreeTest.AccessibilityAriaValueMin and Max
Bug: 622387
Change-Id: I68252a1dbfa88eae8e5c4c7801dcbf9cf8f507fe
Tbr: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/938159
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Alice Boxhall <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540088}
Remove set noparent from linux installer
[email protected],[email protected],[email protected]
Change-Id: Idaeee1d4eb957b6685c5c10a4fdc18716d841c3c
Reviewed-on: https://chromium-review.googlesource.com/940131
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540087}
Remove set noparent from chromeos files
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Iecd1aafb445ea058a583c1161b71a4369a199a48
Reviewed-on: https://chromium-review.googlesource.com/939788
Reviewed-by: Zentaro Kavanagh <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540086}
Remove set noparent from nacl test data
in accordance with https://cs.chromium.org/chromium/src/docs/code_reviews.md?l=198
[email protected],[email protected]
Change-Id: I60ccf24402c0ef5a2c3713aa07e9847228a6630a
Reviewed-on: https://chromium-review.googlesource.com/939789
Commit-Queue: Jochen Eisinger <[email protected]>
Reviewed-by: Mark Seaborn <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540085}
Remove empty build/slave directory
[email protected]
Change-Id: If69ba9ea2ae4b692878de80587c64e244c12dd09
Reviewed-on: https://chromium-review.googlesource.com/941141
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540084}
[LayoutNG] Rebaseline 510 spaces/tabs/newlines-only differences
Test runner distinguishes such tests and writes the result into the
'text_mismatch' field of json. Following values are included in this
rebaseline.
spaces and tabs only
newlines only
spaces, tabs and newlines only
from:
https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/3996/layout-test-results/results.html
[email protected], [email protected]
NOTRY=true
Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I2aea5b5d016575db009d8a87f2f2e6200a6a5717
Reviewed-on: https://chromium-review.googlesource.com/942646
Reviewed-by: Xiaocheng Hu <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540083}
[Extensions Bindings] Check context validity in port messaging
Check whether the context is valid before dispatching a message from
a GinPort (the native representation of a runtime.Port object in the
Extension API). Add a unittest for the same.
Bug: 812363
Change-Id: If985250fb8d2631bda50b803f95c6a6d30cd8fc5
Reviewed-on: https://chromium-review.googlesource.com/933105
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540082}
[Extensions] Update a bunch of tests to manifest v2
We should (finally) remove support for manifest v1. One of the last
significant dependencies is that a lot of our tests aren't manifest v2
yet.
This CL updates the majority of manifest.json files under
chrome/test/data/extensions. This CL only modifies files that update
cleanly (i.e., no other test updates necessary). A separate CL will
address those.
Bug: 816679
Change-Id: I0ae5a47efd9929c5db2c74d58e4d04de7099ef1c
Reviewed-on: https://chromium-review.googlesource.com/938261
Reviewed-by: Karan Bhatia <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540081}
BUILD.gn and DEPS changes for WebKit/common -> WebKit/public/{mojom,common} migration
Remaining BUILD.gn and DEPS changes.
The new targets are currently configured as following:
- //third_party/WebKit/public/common -- former common:blink_common
- //third_party/WebKit/public/mojom -- former common:mojo_bindings
- //third_party/WebKit/public/mojom:mojom_platform -- former common:mojo_platform_bindings
I chose target names that look common in other directories, while there can be some
other alternatives, e.g. WebKit/public/common can be WebKit/public:common (like other
public:foo targets), but turning WebKit/public/mojom into WebKit/public:mojom in the
same way would be too confusing as we still have WebKit/public:mojo_bindings.
[email protected],[email protected],[email protected],[email protected],[email protected]
Bug: 809983
Change-Id: I3028e0f2aeb34a9efe23508dd58a36f50c6f8f82
Reviewed-on: https://chromium-review.googlesource.com/940042
Commit-Queue: Kinuko Yasuda <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540080}
AppShell: Support reloading
Implement reloading in ExtensionLoader. Uses keep-alives while apps are
reloading. A future CL will observe these keep-alives to keep app_shell open
during reload.
Bug: 762642
Change-Id: Ia20b81378d1aeab4ace119d9d2a8b44c2461fdcf
Reviewed-on: https://chromium-review.googlesource.com/912694
Commit-Queue: Michael Giuffrida <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540079}
[Power ML] Record number of key, mouse and touch events in the past hour.
This cl also logs time-since-last-touch in UKM. Previously we treat touch events
as mouse events. In this cl, we break them into two.
Bug: 784232
Change-Id: I30f1a2a22f4df7bd39e2b07bebfb4f74b8db9967
Reviewed-on: https://chromium-review.googlesource.com/940724
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Jia Meng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540078}
v8binding: Implements V8PersistentCallbackInterface.
As same as callback function (V8PersistentCallback*Function*),
this patch implements V8PersistentCallback*Interface* in the
completely same way. (Also see https://crrev.com/c/931561 .)
Following patches will changes CallbackInterfaceBase to use
wrapper-tracing instead of v8::Persistent, and then everything
will look the same as callback function.
Note that V8PersistentCallbackInterface is not yet actually
used in this patch.
Bug: 778580
Change-Id: I08b70f5756d7a9128d8bff2a7a86c0b5cc4244a4
Reviewed-on: https://chromium-review.googlesource.com/940786
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540077}
Roll src/third_party/boringssl/src 672f6fc24..8df8e6420
https://boringssl.googlesource.com/boringssl/+log/672f6fc2486745d0cabc3aaeb4e0a3cd13b37b12..8df8e64205d0f8334ee4d403306bfcd4287004b0
BUG=none
Change-Id: Id6f34f24ddd54b27ed9b92ee83566d98163dcf05
Reviewed-on: https://chromium-review.googlesource.com/942311
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540076}
Suppress noisy event generator events
- other attribute changes fire a lot causing ChromeVox to repeatedly speak. For example, if ChromeVox has its focus on a paragraph, and the page keeps changing attributes on the paragraph, we will echo the paragraph repeatedly.
- suppress meaningingful attribute changes when they are as a result of an action.
They should be picked up by more meaningful events e.g. focus or occur on a future message (which would no longer be an action).
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id6cf71dce8f417680c6e489385b38f9f8aa616f3
Reviewed-on: https://chromium-review.googlesource.com/941021
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540075}
Implement basic Crostini install flow UI
This patch implements the basic Crostini install flow UI, for now just
a dialog with an install and cancel button. The message strings are
just placeholders. As the actual install is not ready yet, naturally
the install button doesn't do anything.
BUG=813699
Change-Id: I89b36e0a773e1b6968dd250719202ec2fc45afe9
Reviewed-on: https://chromium-review.googlesource.com/930503
Commit-Queue: Timothy Loh <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Reviewed-by: calamity <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540074}
Restore local subframe size after printing
During refactoring of SetPrinting() in LocalFrame, for local subframes,
we accidentally forgot to call EndPrinting to restore its size. Fix it
and set correct expectation for unit test.
BUG=817285
Change-Id: I5187f9646cc9ed13a21f7093b33e2afa3bed88a4
Reviewed-on: https://chromium-review.googlesource.com/941885
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Wei Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540073}
Update V8 to version 6.6.354.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e5131a07..0638561d
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: I50f3bcfabc83a94623669a979764aed4315d76d3
Reviewed-on: https://chromium-review.googlesource.com/941917
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540072}
Expand the notification at the top of the message center
This CL adds auto-expanding of notification at the top of the message
center. If the notification at top is expandable and never
manually-expanded-or-collapsed, the message center expands it
automatically.
And This Cl also implements the manually-expanded-or-collapsed flag on
ARC notifications, which has been already implemented for non-ARC
notification.
Bug: 810656
Test: manual test
Change-Id: I50fe1d15271ad8d38f889b65a6dcccc8d82ff403
Reviewed-on: https://chromium-review.googlesource.com/915642
Commit-Queue: Yoshiki Iguchi <[email protected]>
Reviewed-by: Eliot Courtney <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540071}
OOPIF: Fix crash on showing a validation message.
PageOverlay::Update() crashed due to null frame_impl_->FrameWidget() on
showing a validation message on the email input below:
# main document
<body>
...
<iframe src="origin different from the main document">
#document
<body>
<iframe src="origin same as the first iframe">
#document
<body>
<form>
<input type=email> ***
<input type=submit>
</form>
</body>
</iframe>
</body>
</iframe>
</body>
PageOverlay::Update() uses LocalRootFrameWidget() instead of FrameWidget().
Bug: 807004
Change-Id: I311c2c736fabb2ba97860a3e411266928deb30f5
Reviewed-on: https://chromium-review.googlesource.com/940781
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540070}
Mark mediasource-config-change-mp4-v-bitrate.html [ Failure Pass Timeout ]
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=mediasource-config-change-mp4-v-bitrate.html
TBR: [email protected]
Bug: 807110
Change-Id: Id44cc9fa07e779f03c74866b41399795dcaca7cf
Reviewed-on: https://chromium-review.googlesource.com/942125
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540069}
splitview: Animate phantom windows p3.
Preserve round edges after animation. Calculates the bounds after animation
and applies identity transform.
Test: manual
Bug: 808283
Change-Id: I8370f63983bf3fd568d7cb5712e7cd09e380edeb
Reviewed-on: https://chromium-review.googlesource.com/940568
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540068}
Remove icon from attestation permission request.
This is a last-minute change requested by UI team.
TBR=srahim
Bug: 793985
Change-Id: Ied38eeb3a89f9dd0b1c93686fb7ede182621da6d
Reviewed-on: https://chromium-review.googlesource.com/942054
Reviewed-by: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540067}
[css-typed-om] Implement correct ordering for StylePropertyMaps.
The correct ordering of properties depends on the type of style map:
- Computed: css properties first, then vendor prefixed ones, then
custom properties. Within each category, sort by code point.
- Inline: same order as the CSSStyleDeclaration.
- Declared: same order as the CSSRule.
Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly
Bug: 545318
Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625
Reviewed-on: https://chromium-review.googlesource.com/940381
Commit-Queue: Darren Shen <[email protected]>
Reviewed-by: nainar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540066}
instrumented_libraries: improve run_docker.sh
Mount chromium src dir instead of only the output directory so that
paths are more consistent (for e.g. symbolization).
[email protected]
Bug: 751218
Change-Id: I25baceb53a63c6fdd1f422dff364036d49f29afa
Reviewed-on: https://chromium-review.googlesource.com/942124
Commit-Queue: Oliver Chang <[email protected]>
Reviewed-by: Oliver Chang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540065}
Import wpt@b73c5d44e35f6510e200aad2242b2f4e70c607c1
Using wpt-import in Chromium ccdfae76f513794f564ee6fdcd82c5d097376cc6.
With Chromium commits locally applied on WPT:
1f9508a413 "[css-layout-api] Populate children, and pass into layout() function"
Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13023
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected], [email protected]:
external/wpt/infrastructure
[email protected], [email protected], [email protected]:
external/wpt/payment-handler
[email protected], [email protected]:
external/wpt/referrer-policy
[email protected]:
external/wpt/encrypted-media
[email protected]:
external/wpt/resources
[email protected]:
external/wpt/mixed-content
[email protected], [email protected]:
external/wpt/subresource-integrity
TBR=kereliuk
No-Export: true
Change-Id: Ie15945959e7850f8abed3439de0a2e3ddc768df4
Reviewed-on: https://chromium-review.googlesource.com/942142
Commit-Queue: Blink WPT Bot <[email protected]>
Reviewed-by: Blink WPT Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540064}
Supports JP106 keyboard for VDI web apps.
Currently the input_method_chromeos_unittest.cc is mistakenly excluded in ui_base_unittests, by this cl:
https://chromium-review.googlesource.com/c/chromium/src/+/632636
So, this cl includes the tests back again and clean up the compiling errors.
This cl also adds some unit tests in InputMethodChromeOSKeyEventTest to cover the logic for JP106 keys.
This cl doesn't remove the similar logic in ash::ImeController. It will be removed after a couple of milestones.
Bug: 816341
Change-Id: Id3d8b7dd2b8a70632af21cb16220fe7fbd09e9b5
Reviewed-on: https://chromium-review.googlesource.com/936923
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: James Su <[email protected]>
Commit-Queue: Shu Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540063}
Rename editing/selection/select-across-readonly-input-1.html to mouse/
This patch moves "select-across-readonly-input-1.html" to "mouse/" for test file
categorization and use "_" instead of "-" to follow chromium file name
convention for improving code health.
This is a follow-up of the patch[1].
[1] http://crrev.com/c/939142 Utilize selection_test() to
editing/selection/select-across-readonly-input-[1-5].html
[email protected]
Change-Id: I7b96216f62464d632a44ea36119262011f2bdf71
Reviewed-on: https://chromium-review.googlesource.com/942644
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540062}
Sampling Heap Profiler: Add manual sampling precision tests.
BUG=803276
Change-Id: I158e90500532d0bd6a2d8c84670d86f229448a37
Reviewed-on: https://chromium-review.googlesource.com/940667
Commit-Queue: Alexei Filippov <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540061}
Chrome OS OOBE: Improve a11y in Advanced options screen.
This CL adds native <button> elements to make screen more accessible.
Bug: 805490
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6ef14545ac7ef6484afe83c3e58166c2c3aea6fc
Reviewed-on: https://chromium-review.googlesource.com/941509
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540060}
Roll src-internal/ 5bfc0fc20..988621f08 (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5bfc0fc20a0f..988621f08f6d
$ git log 5bfc0fc20..988621f08 --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src-internal
The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I1a9b457ca7b388568b2095fc5d9d59ae5d0ca1e5
Reviewed-on: https://chromium-review.googlesource.com/942461
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540059}
Roll src/third_party/angle/ d444255a7..98e6a5f7b (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/d444255a779b..98e6a5f7b0ae
$ git log d444255a7..98e6a5f7b --date=short --no-merges --format='%ad %ae %s'
2018-02-28 fjhenigman Add missing #include.
Created with:
roll-dep src/third_party/angle
BUG=none
The AutoRoll server is located here: https://angle-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I5dcb28194182f8e13adf8e9f075667e94db018b6
Reviewed-on: https://chromium-review.googlesource.com/942184
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540058}
Roll src/third_party/chromite/ 92e338611..7ed5549cf (4 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/92e338611b65..7ed5549cfa7b
$ git log 92e338611..7ed5549cf --date=short --no-merges --format='%ad %ae %s'
2018-02-23 shinyak Add goma canary builder
2018-02-12 phobbs cidb: Method for fetching latest build requests
2018-02-23 yunlian Re-Enable thinlto on caroline and terra release builds.
2018-02-24 nxia Revert "Move sysmon to vpython"
Created with:
roll-dep src/third_party/chromite
[email protected]
Bug: 762650
Change-Id: Ib236b8d6402c33002bdb6d02b4b7be77edcd72ec
Reviewed-on: https://chromium-review.googlesource.com/941794
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Achuith Bhandarkar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540057}
[CRD iOS] Add a report-this button to the session reconnect field
So that user can send a feedback after they failed to connect.
Screenshot:
https://drive.google.com/file/d/1up_qZS9fd1FC4OdbpgWzJuhheGj6qUNL/view?usp=sharing
Change-Id: I44244ad5129e0b6ad222a040e714b8c7cf69c755
Reviewed-on: https://chromium-review.googlesource.com/940772
Commit-Queue: Yuwei Huang <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540056}
[css-typed-om] Ensure properties works with css-wide keywords / var refs
There are two things that should always be supported with any property:
- css-wide keywords like 'initial'
- var refs like 'var(--A)'
This patch adds tests to ensure that this works for all the different
types of properties. Unfortunately, supporting this in shorthands
is quite difficult (we get shorthands as strings, so to reify them
we have to parse, but we can't parse in reification) so we'll leave
that for the future.
Bug: 816722
Change-Id: I1d344b73d011db81cfc3880be54823302534fd36
Reviewed-on: https://chromium-review.googlesource.com/942121
Commit-Queue: Darren Shen <[email protected]>
Reviewed-by: nainar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540055}
Use screen bounds in AXWindowObjWrapper
Bug: 816828
Test: verify that touch typing works again in ChromeVox
Change-Id: I56e273aeaf225cf38d53efcc7ffff3eca6cf5387
Reviewed-on: https://chromium-review.googlesource.com/940814
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540054}
Mark console-group-similar.js as flaky on Windows
TBR: [email protected]
Bug: 817678
Change-Id: I0c9aec842b49210503d38f25aacb42824412ec2b
Reviewed-on: https://chromium-review.googlesource.com/942643
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540053}
Retag idle SpdySessions when streams are requested with different socket tags
This change should alleviate a problem with socket tagging and HTTP/2:
HTTP/2 sessions (SpdySessions) when idle still continue to occupy a socket
pool slot which counts towards the 6-connections-per-host limit. This means
that when six requests with different socket tags are made to the same host,
they will max out the connections-per-host allotment, and a seventh request
will block until one of the HTTP/2 sessions hits the idle timeout and closes.
This isn't a problem for HTTP/1 because we can retag an idle socket and
reuse it to service a new request with a different socket tag.
This isn't a problem for QUIC because there isn't such a
6-connections-per-host limit.
This change allows an idle SpdySession to be retagged with a new socket tag
so that it can be used to service a new request. The following things
happen during this retagging:
1. The underlying socket is tagged with the new socket tag.
2. The SpdySession's SpdySessionKey's socket tag is updated to the new tag.
3. The SpdySessionPool's pool maps are updated to the new session's tag.
Pointers to SpdySessions are handed out to SpdyHttpStreams in advance of the
SpdyHttpStream initiating a SpdyStreamRequest. The SpdySession could have
its socket tag changed during this interval between when the SpdySession
pointer is handed out to the SpdyHttpStream and when the SpdyHttpStream
initiates the SpdyStreamRequest. To avoid SpdyStreamRequests being
initiated on SpdySessions with changed tags, this change includes the
desired tag in the SpdyStreamRequest.StartRequest() call arguments so it
can be checked against the SpdySession's current tag. In reality the
chance of this mismatch is negligible because SpdyStreamRequests are
initiated immediately after the SpdySession is created (see how
HttpNetworkTransaction calls InitializeStream() immediately after creating
the stream), but it's still mitigated. Once InitializeStream() is called,
the SpdySession will no longer be considered idle, so its socket tag
cannot be changed.
Bug: 520198
Change-Id: I6bfc4a9d0802dda924c13806a6d863cfb1e2b3f9
Reviewed-on: https://chromium-review.googlesource.com/938772
Commit-Queue: Paul Jensen <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540052}
Add missing exe_and_shlib_deps dependency to dump_syms target.
Required for libc++ on Windows.
Bug: 801780
Change-Id: I06d9ca131cb7ce09475ae3a302210ad9fcbae711
Reviewed-on: https://chromium-review.googlesource.com/941990
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Peter Collingbourne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540051}
Let caps lock on Virtual keyboard system wide
Bug: 493599
Change-Id: Id568aec3981ad3e97ccea53395822ab26a706922
Reviewed-on: https://chromium-review.googlesource.com/896662
Reviewed-by: Yuichiro Hanada <[email protected]>
Reviewed-by: Shu Chen <[email protected]>
Commit-Queue: Jianzhou Feng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540050}
arc: Add session events to app install log.
This adds events LOGIN/LOGOUT/SUSPEND/RESUME to app install log.
These events are added to each active app install.
Bug: b/73277923
Test: manual
Change-Id: I19878d2f99bd9e41a6a7cc10be379ffe9b546b0e
Reviewed-on: https://chromium-review.googlesource.com/938491
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Bartosz Fabianowski <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540049}
Mark virtual/threaded/..../timeline-recalculate-styles.js flaky for all platforms
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=timeline-recalculate-styles.js
TBR: [email protected]
Bug: 798592
Change-Id: I265d38dea942da1db9f91e607f05813308e10c20
Reviewed-on: https://chromium-review.googlesource.com/942641
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540048}
cros: Add a11y to read out KSV item view.
This cl adds the a11y to read out item view in Keyboard Shortcut
Viewer (KSV). Chromevox will read the category, description, and
shortcut text in order.
Bug: 757261, 768932
Test: tested on device.
Change-Id: I33b7d1c4b75ba31e6d1d4697ce491f85459a6480
Reviewed-on: https://chromium-review.googlesource.com/939845
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540047}
Make clipboard events composed.
This corresponds to the upstream spec change on
https://github.com/w3c/clipboard-apis/pull/62
Note that synthetic events are not affected by the change.
To generate copy/cut/paste events, document.execCommand() is
used for Blink, but cannot be used for web platform tests.
Bug: 802009
Change-Id: I00df77269708458b9a6820323a1f511b7c75e513
Reviewed-on: https://chromium-review.googlesource.com/923671
Reviewed-by: Hayato Ito <[email protected]>
Reviewed-by: Gary Kacmarcik <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Takayoshi Kochi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540046}
cc: No impl-side invalidations for animate_only BeginFrames.
If the BeginFrame was animate_only, it does not need visual output so
avoid performing unnecessary invalidations.
[email protected], [email protected]
BUG: 817601
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I974fd21ae6db7931972cd2b7742605d51ca63716
Reviewed-on: https://chromium-review.googlesource.com/942038
Reviewed-by: Brian Anderson <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540045}
Add OomIntervention to fieldtrial_testing_config
For beta/stable experiments.
Bug: 764481
Change-Id: I6de8ad2a11e10762a55f8adea6a4aaad2aac2e96
Reviewed-on: https://chromium-review.googlesource.com/942282
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540044}
Sampling Heap Profiler: Do not try to symbolize stacks on platforms other than Linux
The symbolization is not supported there anyway.
BUG=803276
Change-Id: I2e0a6663f11dc1f3563e7c087929d592bc5e495b
Reviewed-on: https://chromium-review.googlesource.com/942201
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540043}
chromeos: Removes user_id from Window Service
Supporting user_id adds quite a bit of complexity, and given there is
no plan in the future to support it in ash I'm nuking it.
BUG=none
TEST=none
[email protected]
Change-Id: If22c74081f02611af84ef7589472833e3f73bfce
Reviewed-on: https://chromium-review.googlesource.com/940807
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540042}
Updating trunk VERSION from 3358.0 to 3359.0
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: I96a232d58b09e64c89531cf906c7dff53d4bc8b1
Reviewed-on: https://chromium-review.googlesource.com/941918
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540041}
Roll src/native_client/ 8ad151597..d52121fcf (1 commit)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/8ad1515975c0..d52121fcfeda
$ git log 8ad151597..d52121fcf --date=short --no-merges --format='%ad %ae %s'
2018-02-22 bratell Fixing a broken include guard
Created with:
roll-dep src/native_client
The AutoRoll server is located here: https://nacl-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ib51270f78e773944d8197f2d0e3533a5c83924eb
Reviewed-on: https://chromium-review.googlesource.com/941965
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540040}
[css-typed-om] Implement serialization for CSSUnsupportedStyleValues.
This patch implements serialization for CSSUnsupportedStyleValue.
The spec requires that:
- CSSStyleValues that are parsed from string should serialize to the
given string.
- CSSStyleValues that are obtained from CSSOM should serialize according
to [1] (although this is mostly the same as CSSOM serialization).
To implement both, we put a String on CSSStyleValue (the base class)
to store its serialization. This is only used by the subclass
CSSUnsupportedStyleValue. When we create a CSSUnsupportedStyleValue,
we set the serialization correctly depending on if it's from a string
or CSSOM. CSSUnsupportedStyleValue.toString() just outputs the stored
string.
It turns out that the string on CSSStyleValue can completely replace
its CSSValue. Instead of wrapping a CSSValue, which is fragile when
passed around arbitrarily, we simply parse the stored string whenever
we need to convert to a CSSValue. This actually was the original
design, but we changed it because we thought styleMap.set cannot
invoke parsing. Since we resolved to not expose styleMap.set to
worklets, we are allowed to parse and this is a much more robust
solution.
Serialization for shorthands requires different logic depending on
if it's a computed shorthand or a specified shorthand. This meant
that we had to create a new method for getting the serialization
and override it for different property maps.
We don't need CSSUnsupportedShorthandValue anymore, since we can
can just use CSSUnsupportedStyleValue.
[1] https://drafts.css-houdini.org/css-typed-om-1/#cssom-serialization
Bug: 816722
Change-Id: Ia236f72467e414a2eb380f00ddb196db06f8d8b6
Reviewed-on: https://chromium-review.googlesource.com/940283
Commit-Queue: Darren Shen <[email protected]>
Reviewed-by: nainar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540039}
[MDC roll] Roll Material Components to abaadb64154e898b60e93fb01e62e1f8f4cd19d9
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2303878f20eba1c374cd40ef45b74b6d79e2c8e5
Reviewed-on: https://chromium-review.googlesource.com/942089
Commit-Queue: Peter Lee <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540038}
Remove the usage of GeolocationContext in unittest of geolocationServiceImpl.
The unittest of GeolocationServiceImpl shouldn't include geolocation_context.h.
Instead, we add the ScopedGeolocationOverrider in it.
BUG=800659
Change-Id: I3597a9134eb79cd4354f14cc2e14ec95a716bf02
Reviewed-on: https://chromium-review.googlesource.com/911993
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Commit-Queue: Ke He <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540037}
Enable AudioWorklet by default
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dEsseBBMbs4/rvdT2wK4BQAJ
The following links were tested with the release build of this CL:
https://googlechromelabs.github.io/web-audio-samples/audio-worklet/
https://www.webaudiomodules.org/wamsynths/
https://wasabi.i3s.unice.fr/pedalboard/
http://faust.grame.fr/news/2017/12/12/benchmark-tools.html
https://node.charlieroberts.cricket/playground/
Bug: 816549
Test: all existing AudioWorklet layout tests are passing.
Change-Id: Ia211ab0a62a757e0bdce3acc0d98d6b0b89ce034
Reviewed-on: https://chromium-review.googlesource.com/938162
Reviewed-by: Raymond Toy <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540036}
cros splitscreen: Adjust the snapped window position according to the new
screen orientation.
We changed the default portrait screen orientation in a previous cl
(https://chromium-review.googlesource.com/c/chromium/src/+/877441).
This cl adjusts the splitscreen snapped windows' position in portrait
orientation according to the change.
Bug: 814408
Change-Id: I805a7eed6763b71ed7e534dd27b7b30a5768852e
Reviewed-on: https://chromium-review.googlesource.com/932321
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: min c <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540035}
[ios] TabGridMediator intial implementation
Bug: 804496, 804528
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I993e764eabd2bde4d54ee4c42ddacced3cd316b0
Reviewed-on: https://chromium-review.googlesource.com/942230
Commit-Queue: edchin <[email protected]>
Reviewed-by: edchin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540034}
app_list: create mojo interfaces for mash AppList.
This commit does the following things:
- create interfaces for the app list's ash-chrome communication;
- implement AppListController in ash;
- implement AppListClient in chrome;
To make changes as simple as possible, this commit:
- does not change the behavior of the current app list;
- implements AppListClient and AppListController but actually does
not uses them.
Bug: 733662
Change-Id: Id38cd4ba2eeab149b150e2a4fcf4c56b28a1f535
Reviewed-on: https://chromium-review.googlesource.com/914208
Commit-Queue: Jiaquan He <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540033}
Remove two-line class from Reset/Clean up computer trigger
Extra space should have been removed by crrev.com/c/938623.
Bug: 816666
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a4f6c82008de0fa842f29eba04cf1d54e689299
Reviewed-on: https://chromium-review.googlesource.com/940181
Commit-Queue: Fabio Tirelo <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540032}
Implement CenteredRect and DrawQuadGeometryWithAA
Simplify the creation of centered rect and the draw with antialiasing.
BUG=None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I16bae88dc09d81bb390a4dc7a051de16e0efefd1
Reviewed-on: https://chromium-review.googlesource.com/940173
Reviewed-by: enne <[email protected]>
Commit-Queue: Xing Xu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540031}
Disable WidgetTestInteractive.TouchNoActivateWindow
Test appears to be flaky for some reason. Disable it for now. Will
debug tomorrow.
[email protected]
BUG=817531
Change-Id: Iae5c6e7d4f10d8f89b252bb7338a79b94d26c83a
Reviewed-on: https://chromium-review.googlesource.com/942380
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540030}
webui: Move c/b/r/chromeos/quick_unlock/pin_keyboard to cr_components.
Test: trybots, manual with --show-webui-lock --show-non-md-login
Bug: 809828
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic84f094cb9820f79df4703024b951460b1cde46b
Reviewed-on: https://chromium-review.googlesource.com/905986
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540029}
Disable mailto handler which was crashing tests.
Bug: crbug.com/817537
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If6b86f75a22b500a95fa8d41035328099179222f
Reviewed-on: https://chromium-review.googlesource.com/942488
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Daniel Blakemore <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540028}
Set the default RSSI multiplier to a value less than 1.0
Setting the default RSSI multiplier to a value less than 1.0
allows network quality estimator (NQE) to query signal strength
and index cached network quality by signal strength.
Bug: 817102
Change-Id: Ia507f381660ead29cfff8263415618f14e44eeb4
Reviewed-on: https://chromium-review.googlesource.com/940274
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540027}
win: Pass /Brepro to the compiler when using LLD.
With link.exe this isn't always safe (/incremental relies on the mtime
timestamp stored in the .obj file, and there's no easy way to query if
/incremental is used), but with lld it should be.
Looking at `dumpbin /headers test.obj | findstr "time date stamp"`,
cl.exe seems to write a hash of the output to the time date stamp,
while clang-cl always seems to write 0 with /Brepro.
Bug: 330260
Change-Id: I1fd64d0f0678468bc73c672cb84a5a2d878e2e82
Reviewed-on: https://chromium-review.googlesource.com/941905
Reviewed-by: Reid Kleckner <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540026}
[Go] Skip updating compositing reasons if style has not changed.
Bug: 811449
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I261236e488d36e1e575c0ad74450d3431ce34984
Reviewed-on: https://chromium-review.googlesource.com/924691
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: vmpstr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540025}
DevTools: extend console value truncation beyond strings
Console currently truncates super long strings and renders a
'show more' button to see the full value.
This CL extends the same logic to other value-formatted types,
including 'regexp' and 'symbol'. Doing so also makes 'bigint'
easy to include in the future.
Bug: none
Change-Id: I6e4f607c13e143a8fcecc241aac10866456c0ec3
Reviewed-on: https://chromium-review.googlesource.com/940808
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Erik Luo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540024}
[Chromecast] Support hiding apps on Aura platforms
Bug: internal b/73180055
Test: manual
Change-Id: I9f71dad20016c746c2cec2f09371c54f79799f99
Reviewed-on: https://chromium-review.googlesource.com/930224
Commit-Queue: James West <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540023}
overview: Do not animate in header of tablet mode maximized windows.
Their headers are hidden already, so do not need to animate them in when
entering overview.
Test: manual
Bug: 812004
Change-Id: If3528f2e4296d626ca817bb826dac2473d32fa5d
Reviewed-on: https://chromium-review.googlesource.com/941781
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540022}
[SPv175] Use the parent of css clip as clip state of a composited layer
We need to apply the css clip in the composited layer.
Bug: 815113
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I347481df0bf820ed5b2e5c8f33d32b9fbd4dc0c4
Reviewed-on: https://chromium-review.googlesource.com/941542
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540021}
instrumented_libraries: add a trusty Docker image for local testing.
Bug: 751218
Change-Id: Id760369ef0ed63576c959d689c7bd6bfe2c21d5a
Reviewed-on: https://chromium-review.googlesource.com/938545
Reviewed-by: Abhishek Arya <[email protected]>
Reviewed-by: Evgeniy Stepanov <[email protected]>
Commit-Queue: Oliver Chang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540020}
Add *.bak to git ignore file
[email protected]
Change-Id: Ic28bc49db53dcb1b40054750129df8a7d856888c
Reviewed-on: https://chromium-review.googlesource.com/940127
Commit-Queue: Yngve Pettersen <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540019}
Only replicate the frame's size to the browser process.
Instead of replicating the entire frame rect, which also contains
the frame's position, this patch changes it to replicate only the
frame's size. This should reduce the number of IPCs sent from the
renderer to the browser, especially while scrolling.
The frame's size is needed by the browser process when spawning
an out-of-process iframe.
Bug: 812294
Change-Id: I05aaf42880824abedac9c1cc655cc5c53390925b
Reviewed-on: https://chromium-review.googlesource.com/938651
Commit-Queue: Lucas Gadani <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540018}
Move BrowserActivationWaiter to interactive utils
Tests use BrowserActivationWaiter to wait for a browser window to become
the active window. If multiple browser tests are run in parallel,
another window could become activated after
BrowserActivationWaiter::WaitForActivation() returns, or could prevent
the window from being activated at all.
For these reasons, only browser tests in interactive_ui_tests should use
BrowserActivationWaiter. This requires moving PopupBlockerBrowserTest
into interactive_ui_tests, which should reduce the flakiness of its tests.
Change-Id: I10fa1068538408d43f510bb2f3738e35ab9a0ddf
Reviewed-on: https://chromium-review.googlesource.com/927351
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540017}
Roll src/third_party/pdfium/ 53f555a61..9002cd8cb (1 commit)
https://pdfium.googlesource.com/pdfium.git/+log/53f555a619bf..9002cd8cb5c9
$ git log 53f555a61..9002cd8cb --date=short --no-merges --format='%ad %ae %s'
2018-02-28 rharrison Add simple XFA test for entering text into TextEdit
Created with:
roll-dep src/third_party/pdfium
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I2b05041524e80295c868a886185087ea659c88ec
Reviewed-on: https://chromium-review.googlesource.com/941886
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540016}
MD Extensions: adding extension name to tooltip for preferences enforced by extensions
Bug: 803736
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I029e6586db207fb64b3b9ec104fa8275b7129335
Reviewed-on: https://chromium-review.googlesource.com/938314
Commit-Queue: Esmael El-Moslimany <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540015}
MSE: Prevent UnmarkEOS from undoing PARSE_ERROR or SHUTDOWN
If a previous parse error's ReportError_Locked(...) error has not yet reached
HTMLMediaElement due to thread hopping delays (through media thread via
pipeline_impl), then another appendBuffer operation on one of that
HTMLMediaElement's MediaSource's SourceBuffers could race that error state.
This change prevents such a race from resetting the ChunkDemuxer's |state_|
from PARSE_ERROR to INITIALIZED in UnmarkEndOfStream. Note that the
MediaSource's append error algorithm (including marking end of stream with a
decode error) would have already been done synchronously. allowing subsequent
ignoring of a racing UnmarkEndOfStream call. Eventually, the media element
will have a non-null error attribute, preventing further attempts at
appendBuffer on those SourceBuffers. This change lets the SourceBuffers fail
any racing appendBuffer that occurs in the interim, preventing conditions that
sometimes led to running a null ChunkDemuxer |init_cb_|.
BUG=786975,815207,816407
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id76d6ccd9a03c63637c65b8bd492ab382175f0f4
Reviewed-on: https://chromium-review.googlesource.com/942237
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Matthew Wolenetz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540014}
[WebView Tracing API] Initialize AwTracingController on startup on UI thread
Properly init AwTracingController on the UI thread at startup,
so that it can be used in the downstream glue layer.
BUG=808023,781249
Change-Id: Iff81218aacccdb72913e197d6bd90b6323880db1
Reviewed-on: https://chromium-review.googlesource.com/941804
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540013}
Revert "Make future changes to PrefetchItemState elements safer."
This reverts commit 0cd76beff3456cedf8808166adc191b2169d8789.
Reason for revert: Caused ios build failure
https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/53845
In file included from ../../components/offline_pages/core/prefetch/finalize_dismissed_url_suggestion_task.cc:5:
../../components/offline_pages/core/prefetch/finalize_dismissed_url_suggestion_task.h:27:7: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
PrefetchItemState::NEW_REQUEST,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Original change's description:
> Make future changes to PrefetchItemState elements safer.
>
> Introduce new code patterns to improve the likeliness that future
> changes to the elements of PrefetchItemState will be properly handled.
>
> A new |kOrderedPrefetchItemStates| complements the enum definition by
> providing the full listing of existing states. A new test also checks
> that changes to the enum are reflected in this listing.
>
> The implementation of GetAllStatesExcept was updated to use this
> official state list and accept a collection of states to filter from its
> result. New calls to this function were also added from tests where
> created a local listing of arbitrary states, what should guarantee that
> new or changed state values would have to be dealt with.
>
> Finally uses of `default` in switch blocks for PrefetchItemState were
> replaced with the full listing of all possible states so that build
> errors would guide the proper handling of all states.
>
> Bug: 701939
> Change-Id: I2f303c6922795f509f8046000fdd286c5e0affa9
> Reviewed-on: https://chromium-review.googlesource.com/937944
> Commit-Queue: Carlos Knippschild <[email protected]>
> Reviewed-by: Justin DeWitt <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539995}
[email protected],[email protected],[email protected]
Change-Id: I316e8d748221f616579d814c6f560cb6e5d2fdb8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 701939
Reviewed-on: https://chromium-review.googlesource.com/942561
Reviewed-by: Tsuyoshi Horo <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540012}
GN: Make sure print function flushes stdout to avoid output delays
caused by buffered pipes.
[email protected]
Change-Id: I02d459726488e8aeb126d34bcddd73b885833a98
Reviewed-on: https://chromium-review.googlesource.com/941207
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Yngve Pettersen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540011}
Add 2 files to unrar BUILD.gn and fix warnings.
Bug: 750327
Change-Id: Id420ee35a51108ed9b42495a2eeef79a9fb7e783
Reviewed-on: https://chromium-review.googlesource.com/942238
Commit-Queue: Varun Khaneja <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540010}
[Chromecast] Use transparent background for Cast extension
Bug: internal b/73652640
Test: Build cast_shell, run extension and verify transperency.
Change-Id: Iefdbaf75658d05f901abbfba9cd1ea2c8c27b711
Reviewed-on: https://chromium-review.googlesource.com/940805
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Sean Topping <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540009}
Add title and fix message on session timer system notification.
According to MD notification mock, all the notifications should show an
title. However, the session timer system notification (the notification
of TraySessionLengthLimit) does not have a title. In addtion, the
message of the notification should be changed to the same one as the
mock one. This CL adds the title and fixes the message on the
notification.
Mock: go/cros-md-notification-mock
Screenshot: http://screen/AGxhe6foPeK
BUG=813708
TEST=ash_unittests
Change-Id: I03c7dfddd7df6f369e35caa433710540b2c56d65
Reviewed-on: https://chromium-review.googlesource.com/937003
Commit-Queue: Megumi Hattori <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540008}
Chrome OS OOBE: Fix initialization of aria-label attributes.
This Cl fixes a bunch of places where aria-labels were incorrectly initialized
from pilymer as aria-label= instead of aria-label$= .
Bug: 817528
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie5788dfe864cee20c175e2e4dd40325b1dcc80bd
Reviewed-on: https://chromium-review.googlesource.com/942083
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540007}
Update to disablement of HostedAppTest.ShouldShowLocationBarForHTTPApp/*
Only disable on Win and macOS (not flaky on other platforms), and update
comments.
Bug: 814400, 815246
Tbr: [email protected]
Change-Id: If31ac6e85a346d5938071b5fcd8862d1bf21081a
Reviewed-on: https://chromium-review.googlesource.com/940643
Commit-Queue: Matt Giuca <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540006}
Chrome OS: remove user type notification for child users.
Bug: 813923
Change-Id: Ibf3f07c2f98922bb85023dc601dbf213ff91379b
Reviewed-on: https://chromium-review.googlesource.com/938577
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540005}
Limit the size of input to parse_proxy_bypass_rules_fuzzer to 512 bytes.
Clusterfuzz is currently sending inputs in excess of 814 KB, which results in a correct but slow execution (times out).
Given the simple grammar of proxy bypass rules, 512 bytes is more than enough to explore it.
Bug: 813619
Change-Id: I1415a1a15bb2996b6698b96b9cdef856a4988110
Reviewed-on: https://chromium-review.googlesource.com/942098
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Abhishek Arya <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540004}
Unify Android version and channel info
Android has 2 mechanisms for getting the channel: in Java, there's
ChromeVersionConstants, which is generated at build-time using
chrome/VERSION and the $android_channel GN variable. In native, there's
channel_android.cc, which determines channel at run-time from the
package name. Replace the native side with a JNI call to get the Java
constant, to avoid requiring the package name.
WebView needs channel and version info as well as Chrome, so move that
info from ChromeVersionConstants into a new VersionConstants base class
in version_info/. WebView currently adds channel info to UMA data, and
plans to use channel and major version for downloading Finch seeds.
Move Android-specific parts of version_info/ into version_info/android/.
Remove remnants of the "work" channel, which were missed by commit
0d9dc4f2c7aa6c2d41354ddc9650ebada1ca6a83.
BUG=733857
Change-Id: I61c952862e907ae666f910f4d386e712f6a52f2e
Reviewed-on: https://chromium-review.googlesource.com/927212
Commit-Queue: Paul Miller <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540003}
[ios] Removes the launch screen when showing the tab switcher.
This was accidentally dropped during a rebase of
https://chromium-review.googlesource.com/c/chromium/src/+/920521/4.
BUG=803758,813712
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic60756a3a0cef504ceb9506461be8cf16b0a26c2
Reviewed-on: https://chromium-review.googlesource.com/941908
Reviewed-by: edchin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540002}
Invoke the passed callback of setMode() surely.
Currently we don't call the passed callback of
virtualKeyboardPrivate.setMode() when the virtual keyboard is already
hidden.
We should invoke the passed callback immediately if the virtual
keyboard is hidden because the container type is changed immediately.
Bug: 810253
Test: Modified an unit test and followed the steps described in the linked bug.
Change-Id: Icae6a31fbd1ad11699d43cdc5cea03a4070484c9
Reviewed-on: https://chromium-review.googlesource.com/941281
Reviewed-by: Blake O'Hare <[email protected]>
Commit-Queue: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540001}
Update V8 to version 6.6.351.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d5002715..e5131a07
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: Ifa85cdb509c4395e70037a774f6f078965c66e2c
Reviewed-on: https://chromium-review.googlesource.com/941922
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540000}
Docked Magnifier: Confine mouse cursor outside the viewport
We observed that users who need this feature get very confused and
lost when the mouse cursor goes into the magnifier viewport. This
CL makes it work as expected by confining the cursor outside the
viewport.
BUG=815208
TEST=Added test coverage
Change-Id: If93ea59a2d0cca7f48f9da47dd28dc395c25bc85
Reviewed-on: https://chromium-review.googlesource.com/940261
Reviewed-by: kylechar <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539999}
Disable framebusting intervention for M66.
Will reenable on trunk after the M66 branch point passes. M67 is the new target.
Bug: 624061
Change-Id: Ied8563bbc21d3df3182a80aa5f5d1706ed0224d4
[email protected],[email protected],[email protected]
Change-Id: Ied8563bbc21d3df3182a80aa5f5d1706ed0224d4
Reviewed-on: https://chromium-review.googlesource.com/941615
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539998}
Update Root Window Bounds After Rotation
Properly update the root window bounds after updating the
root transform.
Previously, the call to window()->SetTransform() would update the
transform, but it would not call UpdateRootWindowSizeInPixels(). The
call to this function is what updates the root window bounds rect with
the new transform after it is set.
Using the translation + rotation transforms, if the base
WindowTreeHost::UpdaterootWindowSizeInPixels() function is used,
you end up with bounds represented by a rect with it's own origin
not actually at (0,0). For example, with a rotation of 270 degrees
applied to a 600x1024 display, you end up with bounds represented
as a rect with its origin at (-1, 508) and its other corner at (1228, 1228)
in the device-independent coordinates.
By overriding this function in CastWindowTreeHost,
after the new transform is applied to the root window
bounds, these bounds are shifted back so that their
origin is at (0,0).
This allows located events to properly check whether or not
they are contained within the root window.
BUG=None
TEST=Check touch events on displays with rotation applied.
Change-Id: Ib5c5ec2ab9d82cd2f589bc6301e4b7b6dd712c5c
Reviewed-on: https://chromium-review.googlesource.com/941728
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Alex Sakhartchouk <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Cody Peterson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539997}
Treat compositing/scroll-with-inner-clip.html as flaky
Bug: 817668
TBR: [email protected]
Change-Id: I3014686dd916acf90c4f970714d7e1206c1672b1
Reviewed-on: https://chromium-review.googlesource.com/942501
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539996}
Make future changes to PrefetchItemState elements safer.
Introduce new code patterns to improve the likeliness that future
changes to the elements of PrefetchItemState will be properly handled.
A new |kOrderedPrefetchItemStates| complements the enum definition by
providing the full listing of existing states. A new test also checks
that changes to the enum are reflected in this listing.
The implementation of GetAllStatesExcept was updated to use this
official state list and accept a collection of states to filter from its
result. New calls to this function were also added from tests where
created a local listing of arbitrary states, what should guarantee that
new or changed state values would have to be dealt with.
Finally uses of `default` in switch blocks for PrefetchItemState were
replaced with the full listing of all possible states so that build
errors would guide the proper handling of all states.
Bug: 701939
Change-Id: I2f303c6922795f509f8046000fdd286c5e0affa9
Reviewed-on: https://chromium-review.googlesource.com/937944
Commit-Queue: Carlos Knippschild <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539995}
Fix captureVisibleTab function.
Previously OnCaptureFailure could be called just after CaptureAsync call
in case, when view actually was absent. That led to 2 calls of
SendResponse. Extension functions are designed to receive 1 response
on each call, so 2 calls is bad behavior.
Now web capture clients behavior fixed.
[email protected], [email protected]
Change-Id: I2ce195aaa3698d9c38ca2fa0e3735e6f9555f873
Reviewed-on: https://chromium-review.googlesource.com/930762
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539994}
Origin Trial for Web Locks API
Bug: 161072
Change-Id: I00c00e649c4248349e24f7a2d9cf2d4de25294ff
Reviewed-on: https://chromium-review.googlesource.com/940334
Reviewed-by: Jason Chase <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539993}
[css-typed-om] Implement shorthands for StylePropertyMap.set/delete.
This patch implements shorthands for stylemap.set/delete. When we
receive an UnsupportedShorthandProperty, we should get the CSSValues
out of them and set them on the style map.
We leave parsing of shorthand values for a future patch.
Bug: 816722
Change-Id: Iebd0b33f89b1d8872bea5d3f80d1dde71d72bc45
Reviewed-on: https://chromium-review.googlesource.com/938684
Commit-Queue: Darren Shen <[email protected]>
Reviewed-by: nainar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539992}
Chrome OS OOBE: Change illustration when switching to tablet mode.
This CL adds setTabletModeState sceen object method and event flow to
update this status in runtime. Also illustration on the OOBE screen now
depends on the device status.
Bug: 792719
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I13a5dfb55630fe6b8debb022ca4a04529acdff52
Reviewed-on: https://chromium-review.googlesource.com/939049
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539991}
Remove Chrome Home NTP concept
Remove BottomSheetNewTabController and related logic
BUG=814528
Change-Id: If02ad59bebdd6daeb45821807bfa11716cf2b361
Reviewed-on: https://chromium-review.googlesource.com/910007
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539990}
[vr] Make content, omnibox semi-transparent when native dialog shows
Also adds an opacity animation for showing and hiding the dialog.
Bug: 815003
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I41648642627bba712e0d4106bcaba536d0480e45
Reviewed-on: https://chromium-review.googlesource.com/941547
Reviewed-by: Christopher Grant <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539989}
Fix some moved tests in SmokeTests
https://crrev.com/c/766652 moved some tests in paint/invalidation into
subdirectories. The corresponding entries in SmokeTests weren't updated
accordingly, causing these tests not running on Android. This CL fixes
this issue.
Change-Id: I24e7941b5ee26a9a9071cff5757ac3368907d6fc
Reviewed-on: https://chromium-review.googlesource.com/941823
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539988}
[CRD iOS] Pass FeedbackData to HelpAndFeedback
This CL passes feedback data created from ChromotingSession to the
HelpAndFeedback instance, so that it can be later attached to the
feedback report.
This CL is coupled with an internal CL:
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/578187
Bug: 814863
Change-Id: I83c41ec7850ab5bd6852e54438ab120aab65656c
Reviewed-on: https://chromium-review.googlesource.com/940265
Commit-Queue: Yuwei Huang <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539987}
Rewrite editing/deleting/25322-[1-5].html to utilize selection_test()
This patch changes "editing/deleting/25322-[1-5].html" to utilize
|selection_test()| and put them into "25322-1.html", since these tests use
similar test input, for ease of maintenance.
Following-patch will rename "25322-1.html" to "delete_after_block_image.html".
Note: This patch is a preparation of the patch[1].
[1] http://crrev.com/c/938871 Make SelectionAdjuster to handle collapsed
selection correctly
Bug: 679977
Change-Id: I918ba66f7a7f899467eaf7a05255a1ca414fd658
Reviewed-on: https://chromium-review.googlesource.com/940726
Reviewed-by: Yoichi Osato <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539986}
Working around selection quirks.
Selection can be messy if it goes across multiple types of containers.
This change is meant to make Select-to-Speak more robust to different
types of selections, and adds a lot of tests to help keep STS from
regressing in the future.
There are still several odd selection cases known that are not solved,
and any other strange selection tests would be appreciated.
There are also some small logic changes in select_to_speak function
to process selected nodes better.
Bug: 803160
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I015a58bae245bc5cab0f1f79b3c758d7456e1b37
Reviewed-on: https://chromium-review.googlesource.com/879091
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539985}
VR: Fix wrong Activity being resumed sometimes when cancelling animation
Android task stacks are a confusing mess. For some reason starting the
animation cancel activity in its own task stack is leading to a less-
recent CTA instance being resumed instead of the CCT that invoked the
animation cancel.
We can fix this by not starting the animation cancel in a new task
stack.
Bug: 817476, 817503
Change-Id: I99fe4583c02c9c5c2333697166e6e4081ad4f818
Reviewed-on: https://chromium-review.googlesource.com/941912
Reviewed-by: Yash Malik <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539984}
Add support for VR browsing assets in benchmarks
Adds code to the VR Telemetry benchmarks to support the copying of the
VR browsing assets that are normally downloaded via component updater
onto the device before each story run. This allows the assets to be used
without actually downloading anything.
Bug: 808465
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I320c14e16eb411dd0bf29c57a330e3825fe4dcd6
Reviewed-on: https://chromium-review.googlesource.com/938398
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539983}
Add navigations histograms in the ResourceHandler.
Here "ResourceHandler" refers to the NavigationResourceHandler or the
MojoAsyncResourceHandler depending on whether NavigationMojoResponse is
enabled or not.
It adds two histograms:
* Navigation.ResourceHandler.ResponseStartedUntilProceedWithResponse
* Navigation.ResourceHandder.ProceedWithResponseUntilStartLoadingResponseBody.
It records the time delta between these 3 events.
1) OnResponseStarted().
2) ProceedWithResponse().
3) OnReadCompleted() is called for the first time.
Bug: 705744
Change-Id: I10e26016df13b9f9a7c0687774986f8775ce59c3
Reviewed-on: https://chromium-review.googlesource.com/937516
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539982}
Revert "Reland "[Chromecast] Update mixer unittests""
This reverts commit 07c7facb93a04628a09a4be8a8badc5e7f9eb94d.
Reason for revert: Caused build error
https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64%20Cast%20Audio/5780
../../chromecast/media/cma/backend/stream_mixer_unittest.cc:423:13: error: unused function 'DeathRegex' [-Werror,-Wunused-function]
std::string DeathRegex(const std::string& regex) {
^
1 error generated.
Original change's description:
> Reland "[Chromecast] Update mixer unittests"
>
> This reverts commit d0ca87de96f2177cceaa8b9d77065062b510577f.
>
> Added ifdef guard for death tests.
>
> Bug: internal b/71559266
> Change-Id: I204a00d7a1759a4a18407f5162843366e9229da5
> Reviewed-on: https://chromium-review.googlesource.com/941789
> Reviewed-by: Scott Graham <[email protected]>
> Reviewed-by: Luke Halliwell <[email protected]>
> Commit-Queue: Kenneth MacKay <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539976}
[email protected],[email protected],[email protected]
Change-Id: I05ba642b66d4bb1e2f1eb8fe8e86c705b361a9a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: internal b/71559266
Reviewed-on: https://chromium-review.googlesource.com/942422
Reviewed-by: Tsuyoshi Horo <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539981}
[tab-under] Only check the popup condition at start
Currently, tab-unders require that the tab has opened a popup since
the last user gesture in the tab. However, we check this condition
on every navigation redirect, which is wrong.
For example:
1. Navigate to a.com
2. Start a navigation without a user gesture to b.com
3. Open a popup
4. Navigation from (2) redirects and should not be blocked.
This is fixed by checking the popup condition once at the start
of the navigation.
This CL also makes a couple of `bool` members const.
Bug: 817514
Change-Id: I9ddcd383fa299d8d560889b2d0e393114b5afa96
Reviewed-on: https://chromium-review.googlesource.com/941923
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539980}
[Payments] Use url.mojom.Url for stricter type check
Bug: 812297
Change-Id: Ifb855b4e52ed3fde171569a017fa856cad5cc2dd
Reviewed-on: https://chromium-review.googlesource.com/940324
Commit-Queue: Ganggui Tang <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539979}
[Chromecast] Reactive intent handling in CWCA.
Added some features to reactive framework to make this smooth.
This is one step to refactoring CastWebContentsActivity and
adjacent classes to be testable. The ultimate goal is to express
the logic of CastWebContentsActivity and other classes in terms
of observable events, with the Activity, Service, and Fragment
classes being thin adapters from Android API events to reactive
Observables. That will let us cleanly separate concerns in the
behavior classes and mount them in lightweight, potentially non-
Robolectric test fixtures.
Bug: Internal b/36777136
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: Iacdeb0084e34d99193fc2733c2dbd42d9560b16a
Reviewed-on: https://chromium-review.googlesource.com/929892
Commit-Queue: Simeon Anfinrud <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539978}
Don't use modern snackbar on tablets
We use a narrow snackbar on tablets, so a different background asset is
needed to show shadows on all edges of the white snackbar.
For now, don't use the modern snackbar on tablets.
BUG=817518
Change-Id: I49bb4f6a14cf804e719d433db9f26192a52a9495
Reviewed-on: https://chromium-review.googlesource.com/941506
Reviewed-by: Becky Zhou <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539977}
Reland "[Chromecast] Update mixer unittests"
This reverts commit d0ca87de96f2177cceaa8b9d77065062b510577f.
Added ifdef guard for death tests.
Bug: internal b/71559266
Change-Id: I204a00d7a1759a4a18407f5162843366e9229da5
Reviewed-on: https://chromium-review.googlesource.com/941789
Reviewed-by: Scott Graham <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539976}
AW: comment to explain StaticFieldLeak warning
No change to behavior, this only adds a comment.
This adds a comment explaining why we're going to ignore the
StaticFieldLeak lint warning. There is no real leak because the task
doesn't run for a long time.
Bug: 804422
Test: N/A
Change-Id: I5a70a04a4eb5eed748f20a2396ea8dad3b86770c
Reviewed-on: https://chromium-review.googlesource.com/942029
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539975}
[vr] Make sure Display.getRealMetrics() is only used on API Level 17+
Bug: 762588
Change-Id: I73723544788847a2209155eec756c7573dfe7b1d
Reviewed-on: https://chromium-review.googlesource.com/788891
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539974}
[ChromeDriver] Release ChromeDriver version 2.36
Change-Id: I5ae7c91a864a9c760965d38296ae5dbf4cf3fbec
Reviewed-on: https://chromium-review.googlesource.com/940166
Reviewed-by: Jonathon Kereliuk <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539973}
Adding Search Engines - Remove Unnecessary Empty Keyword Guard
Bug: 726044
Change-Id: Id607c942778e89fc4c1e89b372196a5c711ce51b
Reviewed-on: https://chromium-review.googlesource.com/940820
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539972}
Revert "Supersize: Fix pak spurious deltas"
This reverts commit 6d411ef0a77d65ece6166fd5c411983a8548f467.
Reason for revert: Failed perf builders with division by zero
Original change's description:
> Supersize: Fix pak spurious deltas
>
> Previously we recorded the exact pak compression ratios in .size files.
> This results in minor changes to 1k+ unrelated symbols due to changes in
> compression. Use a mostly accurate static constant instead to make .size
> files comparable across runs.
>
> Bug: 814078
> Change-Id: I63c78379898ef02885ae86e0b95df95d51965918
> Reviewed-on: https://chromium-review.googlesource.com/938122
> Reviewed-by: agrieve <[email protected]>
> Commit-Queue: Peter Wen <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539252}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 814078,817534
Change-Id: I5cd4a6375e1f318c3559801da95a850f5ffcf4fa
Reviewed-on: https://chromium-review.googlesource.com/942061
Reviewed-by: Peter Wen <[email protected]>
Commit-Queue: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539971}
Fix dangling reference into font data hashtable
It's unlikely that pruning the cache will resize the hash table,
but this makes a copy of the scoped_refptr just in case.
[email protected]
BUG=812600
Change-Id: I5a6256b9079e9c7f36249cadbb679189f0248afd
Reviewed-on: https://chromium-review.googlesource.com/852531
Reviewed-by: Hans Wennborg <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Reid Kleckner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539970}
Revert "Extension API: Move easyUnlockPrivate API to be CrOS-only."
This reverts commit 878a6bb6de52ada7ae31116f934dfbb26a527750.
Reason for revert: Caused build error
https://ci.chromium.org/buildbot/chromium/Linux%20x64/59639
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59639%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
In file included from ../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc:6:
../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate.h:12:10: fatal error: 'chrome/common/extensions/api/easy_unlock_private.h' file not found
#include "chrome/common/extensions/api/easy_unlock_private.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Original change's description:
> Extension API: Move easyUnlockPrivate API to be CrOS-only.
>
> This is true in practice and is the next step in making SmartLock
> CrOS-only.
>
> Bug: 817115
> Test: Existing tests
> Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5
> Reviewed-on: https://chromium-review.googlesource.com/940538
> Reviewed-by: Karan Bhatia <[email protected]>
> Reviewed-by: Toni Barzic <[email protected]>
> Commit-Queue: James Hawkins <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539965}
[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ib5425ec7d3c9283a6fcb776a11c6a1a2f6b61efe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817115
Reviewed-on: https://chromium-review.googlesource.com/942421
Reviewed-by: Tsuyoshi Horo <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539969}
Pass /guard:cf,nolongjmp to lld now that it has some support for it.
Bug: 693709
Change-Id: I4e846d36fac5ca170c47c8e20906b0cf2715fbf5
Reviewed-on: https://chromium-review.googlesource.com/941904
Reviewed-by: Reid Kleckner <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539968}
Fix broken R class searching in file:///android_res/
The removal of GetApplicationContext accidentally removed the parameter
used to try shorter versions of the package name if the R class isn't
found in the original package name, reintroducing crbug.com/599869 that
this logic was written to fix. Put the package name parameter back so
that stripping off elements of the package name actually has an effect.
Bug: 599869
Change-Id: Iad5e0174052b1362c8fe7e86089655e3fd60b847
Reviewed-on: https://chromium-review.googlesource.com/941591
Reviewed-by: Bo <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539967}
Landing Recent QUIC changes until 6:15 AM, Feb 25, 2018 UTC-5
Turn on FLAGS_quic_reloadable_flag_quic_use_write_index.
Increase acceptable time delta from 1 min to 2 mins.
Merge internal change: 186930823
https://chromium-review.googlesource.com/c/chromium/src/+/937681
Deprecate FLAGS_quic_reloadable_flag_quic_fix_sequencer_buffer_block_count2.
Merge internal change: 186669590
https://chromium-review.googlesource.com/c/chromium/src/+/937661
In QuicDispatcher: - Rename 'client_address' to 'peer_address' when it makes sense, i.e. if a variable named 'client_address' may not contain the actual client address, it is renamed to 'peer_address'. - For symmetry, rename 'server_address' to 'self_address'.
Merge internal change: 186664180
https://chromium-review.googlesource.com/c/chromium/src/+/937587/1
Use QuicMakeUnique when initializing an unqiue_ptr.
Merge internal change: 186475749
https://chromium-review.googlesource.com/c/chromium/src/+/937565/1
Replace FLAGS_quic_reloadable_flag_quic_enable_version_42 with FLAGS_quic_reloadable_flag_quic_enable_version_42_2.
Merge internal change: 186384559
https://chromium-review.googlesource.com/c/chromium/src/+/937586/1
Remove unused Randomize() function from quic_http_frame_decoder_state_test_util.
Merge internal change: 186374471
https://chromium-review.googlesource.com/c/chromium/src/+/937564/1
In QUIC, let session unblock stream in UpdateSendWindowOffset. So that in QuicStream::OnCanWrite, we can directly return after stream retransmits lost data. Protected by existing FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2.
Also add DCHECK after stream's OnCanWrite to make sure that if a stream has buffered data and it is not stream flow control blocked, it must be in the session's write blocked list.
Merge internal change: 186305642
https://chromium-review.googlesource.com/c/chromium/src/+/937584/1
In QUIC, framer incrementally report ack ranges to the connection, also stop appending timestamps in ack frame. Protected by FLAGS_quic_reloadable_flags_quic_incremental_ack_frame.
Merge internal change: 185827616
https://chromium-review.googlesource.com/c/chromium/src/+/937561/1
Change-Id: I0299a5c489eabd0ce47a21af9ba0093631c21b2c
Reviewed-on: https://chromium-review.googlesource.com/941586
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Fan Yang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539966}
Extension API: Move easyUnlockPrivate API to be CrOS-only.
This is true in practice and is the next step in making SmartLock
CrOS-only.
Bug: 817115
Test: Existing tests
Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5
Reviewed-on: https://chromium-review.googlesource.com/940538
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: James Hawkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539965}
[Dice] Use first name for sync promo in settings
Instead of using the full name in the settings
sync promo, only the first name should be used.
This CL fixes this.
Bug: 810865
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib707abeebe65f8d5b02cfa94dca75c00596997e7
Reviewed-on: https://chromium-review.googlesource.com/941202
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539964}
Add Windows Release CI builders to buildbucket
Adds the compile builder, and the tester.
Bug: 790710, 790644
Change-Id: Ie7184a94b0ec7e518aa65a96432880529c1920c7
Reviewed-on: https://chromium-review.googlesource.com/940423
Reviewed-by: Andrii Shyshkalov <[email protected]>
Commit-Queue: Stephen Martinis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539963}
Client initiated resize
* Start resizing upon resize request from client.
* Client can start drag only if
1) mouse is pressed on the shell surface.
2) gesture is on progress.
This CL includes a fix for potential issue when
the drag to resize/move was requested when the mouse/touch
drag wasn't in progress.
BUG: b/72918846
TEST: covered by unit test
Change-Id: Id32f9da7a2c718fdaef1cb0e4a4adb3b99cbd7f8
Reviewed-on: https://chromium-review.googlesource.com/938498
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539962}
viz: Only Create SyncQueryCollect in SkiaRenderer Optionally
Trying to access GL will crash vulkan build. Only create sync queries
when it can be used.
R=enne
Bug: 644851
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ibffe46608195541ab094aae9de4161871c1ab2b1
Reviewed-on: https://chromium-review.googlesource.com/941383
Reviewed-by: Peng Huang <[email protected]>
Reviewed-by: enne <[email protected]>
Commit-Queue: weiliangc <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539961}
Add new icons for fullscreen and docked magnifiers
Bug: 806169
Change-Id: Ibd56a9c4d281b2826901cceb07d5f84e7a6ab1c8
Reviewed-on: https://chromium-review.googlesource.com/941411
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539960}
ScrollableArea rects need to be in coords of LocalRoot's Document.
This CL corrects a bug where, in the case of an OOPIF, the
ScrollableArea rects are computed in the coordinate space of
the main frame, when they need to be in the coordinates of
the LocalRoot's Document in order that the compositor, which
is owned by the LocalRoot, can deal with them properly.
The manifestation of the bug required a non-fast-scrollable
rect to be recomputed after its localroot container was scrolled.
In that case the coords change due to the scroll, when they
shouldn't.
This CL also updates Internals::nonFastScrollableRects() to
work for OOPIF frames, and it adds code to force recalculation
of the rects, otherwise it might be unable to detect if this
change gets regressed (since scrolling is not sufficient to
make the non-fast-scrollable rects change, something must also
trigger their recalculation after the scroll).
Bug: 807683, 680606
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iccb7a694f43e98265e1bfde3d334efe51d64a59a
Reviewed-on: https://chromium-review.googlesource.com/922421
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539959}
Add device DMToken for affiliated user's policy requests.
Device DMToken will be included in user policy fetch
for affiliated users.
In order to do it even for the initial policy fetch,
server will provide |user_affiliation_ids| in user
registration response and they will be used to
check affiliation with the device.
BUG=810336
Change-Id: I89f83807be88bb47160381e8320912dfd638c787
Reviewed-on: https://chromium-review.googlesource.com/907568
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Drew Wilson <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Commit-Queue: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539958}
[remoting host] Rate-limit capturer to 30FPS
For WebRTC-enabled connections, ensure capturer is not scheduled more
often than 30FPS, to limit CPU usage.
Bug: 816727
Change-Id: If2efd9de0749848f209fad7ed1926be108f402c3
Reviewed-on: https://chromium-review.googlesource.com/940449
Reviewed-by: Zijie He <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539957}
Reland "Update Google Update COM interface definitions in google_update_idl.idl."
This is a reland of 21489fa99e78a80547d9e537f7cda88cf604e328.
Original change's description:
> Update Google Update COM interface definitions in google_update_idl.idl.
>
> This update is required for work that is underway related to management
> of Chrome browsers for enterprise users.
>
> The google_update_idl.idl file was originally provided by the Google
> Update team. It has been modified as described in the README.chromium
> file in this CL.
>
> The change was tested with Chrome-branded builds with target_cpu set to
> "x86" and "x64". I followed these steps to make sure that this change
> does not break Chrome updates.
>
> 1. Manully set the version of Chrome in src/chrome/VERSION to a version
> prior to that which is currently served on the Dev channel.
> 2. Compile with is_chrome_branded=true and target_cpu set to one of
> "x86" or "x64".
> 3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit
> Win10 machine.
> 4. Navigate to chrome://help and make sure that the update process works
> as expected.
>
> Bug: 796270
> Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3
> Reviewed-on: https://chromium-review.googlesource.com/924474
> Commit-Queue: Ali Tofigh <[email protected]>
> Reviewed-by: Will Harris <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539457}
Bug: 796270
Change-Id: I13c1fd5446ca8278ba43f57181fa5994e89608a8
Reviewed-on: https://chromium-review.googlesource.com/939656
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Ali Tofigh <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539956}
Have GestureScrollBegin ACK consider local child frames.
Consider a page with a nested iframe such that the main frame is
navigated to site A, the outer iframe is site B, and the inner iframe
is site B. With Site Isolation, the outer iframe is an OOPIF and the
inner frame is local to said OOPIF.
When attempting to scroll in the inner iframe,
ScrollManager::HandleGestureScrollBegin for the outer frame passes
the event along to its local child, but ignores the return value
which indicates whether the child has a non-empty scroll chain. It goes
on to create a scroll chain for the outer frame and bases the event
ACK on that. Hence, if a local child frame is scrollable in a given
direction, but the OOPIF containing it isn't, then the GSB will be
acknowledged as unconsumed which will cause the browser to bubble
scroll to an ancestor of the OOPIF.
We now use the return value for the local child to inform the GSB
ACK. In order to do this, we also no longer unconditionally add the
document element for a local subframe to the scroll chain.
Bug: 807683
Change-Id: I4cd76888f8362e14aa660d7727dfcb0d24323a40
Reviewed-on: https://chromium-review.googlesource.com/939522
Commit-Queue: Kevin McNee <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539955}
Use ThreadProfiler for browser process profiling
Converts the browser process profiling to use the ThreadProfiler
abstraction. This simplifies the browser process profiling
implementation and removes all users of the the current continuous
profiling implementation, allowing it to be cleaned up.
This also alters the way continuous profiling is done in the browser
process, from taking samples at 1Hz continuously to taking samples at
10Hz for 30 seconds during 2% of execution time. This will reduce
the number of samples by 80%.
Bug: 808588
Change-Id: I2925dc75b27aaab093b4ea99ae5e8dabfa2b273c
Reviewed-on: https://chromium-review.googlesource.com/941730
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Mike Wittman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539954}
Enable Delta Anti-Aliasing and Rebaseline
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibb10f26a84f8fe3854f2d9dc76ae73ed64bb2b22
Reviewed-on: https://chromium-review.googlesource.com/923767
Reviewed-by: Brandon Jones <[email protected]>
Reviewed-by: Florin Malita <[email protected]>
Commit-Queue: Yuqian Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539953}
Query support for EME_CODEC_COMMON_VP9
The new VP9 profile 2 string format gets mapped to EME_CODEC_COMMON_VP9 in
key_systems.cc.
Bug: internal b/73148168
Bug: internal b/70520890
Test: Play secure vp9 profile 2 content
Change-Id: I32c0e319113db70e2bdfd2afc8e131e3470b3fe0
Reviewed-on: https://chromium-review.googlesource.com/940610
Reviewed-by: Xiaohan Wang <[email protected]>
Reviewed-by: Sergey Volk <[email protected]>
Commit-Queue: Sandeep Vijayasekar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539952}
Change Mac Translate Bubble options menu to a Cocoa menu
This CL also enables the MacViews translate bubble when
--secondary-ui-md is enabled.
Bug: 814477
Change-Id: I107edf4fcbfde529b60433873c8e785a4fdbc2bf
Reviewed-on: https://chromium-review.googlesource.com/939521
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Rachel Blum <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: anthonyvd <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539951}
Supersize: Add more OWNERS
NOTRY=true
Bug: None
Change-Id: I40ae8bda58079de746b2947dca0b41b70afb2d9a
Reviewed-on: https://chromium-review.googlesource.com/941921
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539950}
Revert "Add 32-bit version of libappindicator3-1"
This reverts commit 6e3fb99a7265b2481b9570344de4669f4c26a14c.
Reason for revert: install-build-deps.sh brocken:
The following packages have unmet dependencies:
libappindicator3-1 : Conflicts: libappindicator3-1:i386 but 12.10.1+13.10.20130920-0ubuntu4.1 is to be installed
libappindicator3-1:i386 : Depends: libindicator3-7:i386 (>= 0.4.90) but it is not going to be installed
Conflicts: libappindicator3-1 but 12.10.1+13.10.20130920-0ubuntu4.1 is to be installed
E: Unable to correct problems, you have held broken packages.
Original change's description:
> Add 32-bit version of libappindicator3-1
>
> When doing a 32-bit build on a 64-bit system, the 32-bit version of the
> library is not available. This CL should fix that.
>
> Bug: 799144
> Change-Id: I40c6d16d708db102eb4da90ded7bc336cb9f9b09
> Reviewed-on: https://chromium-review.googlesource.com/940196
> Reviewed-by: Dirk Pranke <[email protected]>
> Commit-Queue: Tim Brown <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539851}
[email protected],[email protected]
Change-Id: Ic6ee1c67eb9c8a5cd438b7f0bc86fbea18125b46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 799144
Reviewed-on: https://chromium-review.googlesource.com/941614
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Dmytro Golovchenko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539949}
Undrain CQ.
But leave doc for troopers in case this is needed again in the future.
[email protected]
Bug: 817498
Change-Id: I46c33c17752f52394bb96cbd3d7bbbe944f89a17
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/942240
Commit-Queue: Andrii Shyshkalov <[email protected]>
Reviewed-by: Jao-ke Chin-Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539948}
Click to Open PDF: Add to fieldtrial_testing_config.json
Bug: 737787
Change-Id: Ib967821fd071f718d72e9a300809d33070e9729c
Reviewed-on: https://chromium-review.googlesource.com/938957
Reviewed-by: Anthony LaForge <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539947}
Add metrics for password export on Android, part 2
This CL adds PasswordManager.ExportedPasswordsPerUserInCSV to the code
for exporting passwords from Android settings.
More details about the metrics are in the design doc [1].
(Remaining TODO for metrics, not addressed here: user actions.)
[1]
https://docs.google.com/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit?ts=5a313898#heading=h.chwovfmlf7pk
Bug: 788701
Change-Id: I844f7506590d505b1d2e4671e21f5d363d73a2e7
Reviewed-on: https://chromium-review.googlesource.com/926527
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539946}
Network Error Logging: Create stub Delegate.
This will eventually be used to parse JSON using data_decoder.
Bug: 810142
Change-Id: Ie0395104c64c24eee2df568be337bb251f500241
Reviewed-on: https://chromium-review.googlesource.com/919621
Commit-Queue: Julia Tuttle <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539945}
Disable WebViewInteractiveTest.KeyboardFocusWindowCycle on MacOSX.
[email protected]
Bug: 817067
Change-Id: I3fd386ed4d6f718bf1de6deef73bf9247b9767e5
Reviewed-on: https://chromium-review.googlesource.com/941588
Reviewed-by: James MacLean <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539944}
mac_chromium_compile_rel_ng is being upgraded to Mac 10.13.3.
[email protected]
Bug: 816721, 817494
Change-Id: Ic39f00a60a246ab39e0547108a8ae3f057640220
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/941962
Reviewed-by: Ryan Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539943}
Drain CQ for all CLs submitted to CQ after 12pm today.
No CLs submitted after that time to CQ will be procesed until
this CL is reverted.
[email protected], [email protected]
Bug: 817498
Change-Id: I9e0f8a542cff370013d46166f12d5e81b3c1c58c
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/941967
Reviewed-by: Jao-ke Chin-Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539942}
Roll src/third_party/catapult/ e544456fc..b019720d0 (1 commit)
https://chromium.googlesource.com/catapult.git/+log/e544456fc734..b019720d08b2
$ git log e544456fc..b019720d0 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 bsheedy Make PushProfile set security context
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: If13ca8dc2bec52943bdd4cd992996364f83ba259
Reviewed-on: https://chromium-review.googlesource.com/941729
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539941}
[Coverage] Support running code coverage tool on iOS platform
This CL supports running the code coverage tool on iOS platform and
removes the ios/tools/coverage.
Bug: 814608
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I135c9505a7f2aadc9cd71ca5f6b3893776aed116
Reviewed-on: https://chromium-review.googlesource.com/935195
Commit-Queue: Yuke Liao <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Abhishek Arya <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539940}
[CrOS Tether] Delay host scans slightly after unlock.
This helps to avoid bad interactions between Instant Tethering and
EasyUnlock Bluetooth channels.
Bug: 763604, 672263
Change-Id: I6ecca447d8f7719c6c9c7263950c2c20799eeac7
Reviewed-on: https://chromium-review.googlesource.com/941583
Commit-Queue: Ryan Hansberry <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539939}
Click to Open PDF: Fix button misalignment for long PDF filenames
Bug: 737787, 817390
Change-Id: I789a31b49ff5c648520b84e08d63838e0324d58c
Reviewed-on: https://chromium-review.googlesource.com/941404
Commit-Queue: Anthony LaForge <[email protected]>
Reviewed-by: Anthony LaForge <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539938}
Revert "bindings: Prepare V8ContextSnapshot on Android"
This reverts commit 31b8b4658644400222e359db415fb241c511ab76.
Reason for revert: Breaks downstream apk merging (https://crbug.com/817288)
Original change's description:
> bindings: Prepare V8ContextSnapshot on Android
>
> This CL makes it possible to create and use V8 context snapshot
> files on Android, if a developer puts "use_v8_context_snapshot=true"
>
> The V8 context snapshot feature is currently supported and enabled on
> Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment
> showed 20% reduction of time to create V8 contexts.
> On local Android machine, this feature shows 50% time recution.
>
> Beside it, in order to enable the feature on cross-build platforms
> like Android, we have to build Blink twice.
> So this CL does not flip the flag |use_v8_context_snapshot|.
>
> FYI, some numbers with the feature are written in the next CL;
> https://chromium-review.googlesource.com/c/chromium/src/+/923623
>
>
> TBR=rockot
>
> Bug: 764576
> Change-Id: I7ee8a26d350b65b196854fc9209a52fb607b580d
> Reviewed-on: https://chromium-review.googlesource.com/923683
> Reviewed-by: Cait Phillips <[email protected]>
> Reviewed-by: Xiaohan Wang <[email protected]>
> Reviewed-by: Mike West <[email protected]>
> Reviewed-by: Tommy Nyquist <[email protected]>
> Reviewed-by: Kinuko Yasuda <[email protected]>
> Reviewed-by: Tao Bai <[email protected]>
> Reviewed-by: Ross McIlroy <[email protected]>
> Reviewed-by: Kentaro Hara <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539558}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ifc644f2fdffbbdad3607e6eb0e867f283e80ff68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 764576, 817288
Reviewed-on: https://chromium-review.googlesource.com/941387
Commit-Queue: Eric Stevenson <[email protected]>
Reviewed-by: Eric Stevenson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539937}
Web Locks API: Add feature measure usage via histograms
Introduce basic feature usage tracking via the [Measure] IDL
annotations, and add the API entry points to the appropriate enums.
Bug: 161072
Change-Id: I56957fb943fbe4c6fb6c9ac589e15a6b747798f3
Reviewed-on: https://chromium-review.googlesource.com/940189
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539936}
[Android] Ensure reauth on every password export
Chrome on Android only allows the user to export passwords if that
user is able to reauthenticate by unlocking the device. Once this
reauth challenge is passed, Chrome remembers that for 60 seconds, so
that the user does not need to reauthenticate again if they pause
Chrome momentarily when exporting is in progress.
However, the privacy review of the export feature explicitly requested
that to start the export, the user always needs to reauthenticate, no
matter how recent the last successful reauth was.
Therefore this CL ensures that on every start of export (but not on
resuming Chrome while the export is in progress), the user is
reauthenticated.
The CL also changes a helper method in the tests, because many tests
so far made use of the fact that faking the last-reauth-timestamp
evaded triggering the reauthentication.
Bug: 812227
Change-Id: Ibb30b94261fad8a383d94f5c52d41cbc77a55cb8
Reviewed-on: https://chromium-review.googlesource.com/941231
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539935}
VR: Disable autofill suggestion in VR
This CL builds on comments from:
https://chromium-review.googlesource.com/c/chromium/src/+/934621
Bug: 808456
Change-Id: I02cbee03f1b7f4214b43fe655453b8057a680cdb
Reviewed-on: https://chromium-review.googlesource.com/940461
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Yash Malik <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539934}
[oilpan] Add verification build time flag
Adds build infra for a new heap verification mode that
can be enabled with the gn arg:
enable_blink_heap_verificaton = true
Bug: chromium:757440
Change-Id: I77d6ca4064b51c672b00267d21c4b5cf1f0998c6
Reviewed-on: https://chromium-review.googlesource.com/941222
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539933}
Change the title of the Save Passwords Settings page to Passwords
Since the Settings > Save Passwords view will contain a button for password export as well,
it should be renamed to the more general "Passwords".
Bug:789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2ea88a88a7bfa989384cb302681bc37649d5aa72
Reviewed-on: https://chromium-review.googlesource.com/911798
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Menglu Huang <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539932}
Combine WebView's services
Combine the crash_receiver_service and variations_service processes into
a single webview_service process. This will save memory when crash and
variations services are used simultaneously.
Combine the crash/ and variations/ Java code into a single services/
directory.
Create ServiceInit.java for common initialization code and to ensure
ContextUtils.initApplicationContext() is called only once per service
process lifetime.
BUG=733857
Change-Id: I2588344d3d08d64f37cdd61d70d916438e32bcc4
Reviewed-on: https://chromium-review.googlesource.com/935902
Commit-Queue: Paul Miller <[email protected]>
Reviewed-by: Gustav Sennton <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539931}
Change HitTestQuery to operate in floating point and add short circuit.
1. Changed HitTestQuery to operate in floating point for precision and
updated tests.
2. Re-enabled SitePerProcessNonIntegerScaleFactorHitTestBrowserTest.
MouseClickWithNonIntegerScaleFactor for viz hit-test.
3. Previously, SitePerProcessNonIntegerScaleFactorHitTestBrowserTest.
MouseClickWithNonIntegerScaleFactor/0 actually went into the short
circuit block (when there's only one RenderWidgetHostView) for non-viz
hit-test, so it was not testing targeting. Added
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest.
NestedSurfaceHitTestTest to test targeting for non-integer DSF.
4. Moved short circuit block to be for both viz hit-test and non-viz
hit-test (tested MouseClickWithNonIntegerScaleFactor for viz hit-test
before adding this short circuit).
Bug: 816746
Test: site_per_process_hit_test_browsertests viz_unittests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0bbefff2d1ca0367fa28c17df586f63d7a925114
Reviewed-on: https://chromium-review.googlesource.com/938964
Commit-Queue: Ria Jiang <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539930}
Roll src/third_party/skia/ dabef9ddd..ba7a16519 (3 commits)
https://skia.googlesource.com/skia.git/+log/dabef9dddd4f..ba7a16519468
$ git log dabef9ddd..ba7a16519 --date=short --no-merges --format='%ad %ae %s'
2018-02-28 robertphillips Revert "Revert "Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)"""
2018-02-28 robertphillips Revert "Clean up GrDrawOpAtlas"
2018-02-28 robertphillips Revert "Fission GrAtlasGlyphCache in two"
Created with:
roll-dep src/third_party/skia
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I32d34d286a2635b9b955d10ffea6c4aedb833184
Reviewed-on: https://chromium-review.googlesource.com/941727
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539929}
[css-layout-api] Populate children, and pass into layout() function
This introduces the LayoutChild API surface, (which only has a styleMap
accessor currently).
Each LayoutBox which is a child of a LayoutCustom will hold onto a
LayoutChild object, acting as the script interface for the web
developer.
Bug: 726125
Change-Id: Iecdb01a38c0712dcda063b485c4207bde59f3995
Reviewed-on: https://chromium-review.googlesource.com/933092
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539928}
Show paint records when DCHECK_IS_ON() in various dumps
Previously they were guarded by #ifndef NDEBUG because paint record
dumping was only available in debug build.
Now still guard by DCHECK_IS_ON() so that we won't build them into
official releases.
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I22886cd7a7fc1ef34069944534c6be79af63f757
Reviewed-on: https://chromium-review.googlesource.com/941419
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539927}
Update V8 to version 6.6.346.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/86431ec7..d5002715
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: Ib990bd878e290a756843288c26145e1f8bc81fd3
Reviewed-on: https://chromium-review.googlesource.com/940345
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539926}
Adds new PreviewsDecider method to check URL against blacklist/whitelist
New interface method PreviewsDecider::IsURLAllowedForPreview() checks
a URL against the local blacklist and optimization hints whitelist if
applicable. This reduced check is now used on the committed URL for
NoScript (refactor from using ShouldAllowPreviewAtEct() at commit time).
This reduces the preview logging cruft that the current commit time
check adds.
Bug: 816964
Change-Id: I2e81d06d3397cd3f3f7727f658ee8818c22e122c
Reviewed-on: https://chromium-review.googlesource.com/922459
Reviewed-by: Peter Williamson <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Doug Arnett <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539925}
Add command line flag for turning on (local) WebRTC event logging
Add a command line flag to enable (local) WebRTC event logging.
The flag takes as argument the directory into which the logs
will be saved.
If the flag is used, enabling/disabling (local) WebRTC event
logging from chrome://webrtc-internals will not be possible. The
only way to change that is to restart the browser without the
command line flag.
As a drive-by, this CL removes an unnecessary check for
WebRtcEventLogManager nullness, by making sure it would not be
null in unit tests, regardless of timing.
Bug: 815199
Change-Id: Ib8c732546c30645be823f1bdb6ad7fca8d423d26
Reviewed-on: https://chromium-review.googlesource.com/941322
Commit-Queue: Elad Alon <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539924}
[Perf] Port remaining results.failures usages to had_failures
Bug: catapult:#4229
Change-Id: I2c7f90eac3f99178ea7729f3bfa14a44120d621f
Reviewed-on: https://chromium-review.googlesource.com/940267
Commit-Queue: Ethan Kuefner <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539923}
Document the discrete time constant formula
Add comments to show how to get the discrete time constant value for
the formula for setTargetAtTime.
No code changes at all.
Change-Id: I6af196475671e030c665e5a968c18579bc8f7e83
Reviewed-on: https://chromium-review.googlesource.com/940455
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539922}
[RLS] Mark text-editor-formatter.js as not timing out on Win
text-editor-formatter.js is no longer timing out on windows:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Feditor%2Ftext-editor-formatter.js
While slow, the slowest run is 5s which is equal to the slowest mac
run. This patch removes the timeout expectation.
Bug: 781428
Change-Id: I707171e7a32224dc915570e692d33bf86d08d120
Reviewed-on: https://chromium-review.googlesource.com/941409
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539921}
Move Ozone X11 files into ui/ozone/platform/x11
This CL moves implementation files for Ozone X11 into a more appropriate
location in ui/ozone/platform/x11, instead of ui/platform_window/x11.
Bug: 707406
Change-Id: If5673cc5283bb523eb5b8b1a8aa4d0b97133ea94
Reviewed-on: https://chromium-review.googlesource.com/941481
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539920}
Remove the content-length member variable from SaveFileResourceHandler
The content-length related member variables occurring in a few classes
(SaveFileResourceHandler and SaveItem) is not used. Removing it. Also
now passing the correct content-description (it was always empty).
A few minor clean-ups as well.
This work is in preparation of changing that code to use the network
service.
Bug: 816644
Change-Id: I14f999fc3ce5b0bb77ecf9e1d35311ef7704db8a
Reviewed-on: https://chromium-review.googlesource.com/938386
Commit-Queue: Jay Civelli <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539919}
Report more components to Crash and UMA
1. Report more components. A component ID is copied from
https://omahaconsole.corp.google.com
2. Reorder items in component_map to be consistent with protobuf.
BUG=b:73814897
TEST=chrome compiles.
Change-Id: Ia24c7a8cb63e7e42c6aa0ca2655d51b5d4e9e3b5
Reviewed-on: https://chromium-review.googlesource.com/939849
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Xiaochu Liu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539918}
Do not suppress pointercancel event when dnd
When long press on a draggable item to start dragging with touch,
we should receive a touchcancel event.
This CL changes it to not suppress pointercancel event when doing
drag and drop.
Bug: 708278
Change-Id: I754cf86dfce37f33164b797edb1f8a05acb82c9b
Reviewed-on: https://chromium-review.googlesource.com/939649
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539917}
[css-tables] Test that tables have box-sizing:border-box by default
Legacy layout erroneously sets box-sizing:border-box on non-table
elements that have display:table when the element has a specified %
height. Only <table> elements should have box-sizing:border-box.
Bug: 598134
Change-Id: I66a4a6380ca60a88516a63d3df84faabd709d4c0
Reviewed-on: https://chromium-review.googlesource.com/940561
Commit-Queue: David Grogan <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539916}
Ensure asynchronous reply from MojoAudioOutputIPC.
AudioOutputDevice currently expects all responses to be asynchronous,
and this change also simplifies the code a bit.
Bug: 816348
Change-Id: I66d51184f2553043578dda17a5cb7aeebb809a20
Reviewed-on: https://chromium-review.googlesource.com/937721
Commit-Queue: Max Morin <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539915}
Add an option to the JSON parser to set a lower maximum recursion depth.
Bug: 489301
Change-Id: I268767b48fae92c492165744e1f15389b082a33b
Reviewed-on: https://chromium-review.googlesource.com/938752
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539914}
Omnibox UI Experiments: Steady State elisions - fix double-click-select.
Fix double-click word select for steady state elisions.
This bug is caused by the fact that we change the text in response to
a double-click on the second mousedown. That confuses the double click
word select logic, which saves the range into a member variable.
There's no way for the selection controller to get the correct selected
word except for us to inject an offset into it...
Bug: 797354
Change-Id: I464d405920de7dfcbc317ed9ecbe8b664b920f8d
Reviewed-on: https://chromium-review.googlesource.com/940603
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539913}
Obsolete the DataUse.MessageSize.<ServiceName> histograms
DataUse.MessageSize.<ServiceName> histogram is recorded for each service.
This histogram is used sparingly. Since there are more services, this
per service histogram is not needed.
Bug: 732638
Change-Id: I0d6a54ec4037da6692d8a5dcb7a537641aa111c1
Reviewed-on: https://chromium-review.googlesource.com/742690
Commit-Queue: rajendrant <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539912}
preload=metadata loads a little instead of none
Change the multibuffer code to preload 1/32th of the normal preload
when "preload=metadata" is used. This should work around problems
that occur because WMPI says we have enough data while the demuxer
may still be filling buffers.
For a lot of videos, this means we'll be preloading 64k.
Bug: 814328
Change-Id: Iae6945d63bf8298975eb51eda22b16189c7658df
Reviewed-on: https://chromium-review.googlesource.com/937997
Commit-Queue: Fredrik Hubinette <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539911}
[LayoutNG] Implement height calculation quirk
Spec: https://quirks.spec.whatwg.org/#the-percentage-height-calculation-quirk
It is bug compatible with Legacy. Two test results are interesting:
external/wpt/quirks/percentage-height-calculation.html
Here we pass/fail same tests except for one extra pass, and one extra fail.
Failure is <table>, due to invalidation
fast/block/basic/quirk-percent-height-table-cell.html
This is an overconstrained <td>. I think that NG rendering is correct, and it
matches FF.
Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I572571428c98fbd95abfea7539ca0ab6d16bbc06
Reviewed-on: https://chromium-review.googlesource.com/940335
Commit-Queue: Aleks Totic <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539910}
Support reading command line options for non-rooted devices for testing
This CL add a new flag "Enable command line on non-rooted devices" to
chrome://flags. If changed, it will set a flag in Chrome SharedPreferences.
And when CommandLineInitUtil starts, it checks whether an alternative
command line file could be used when:
1. The current build is "eng" or "userdebug" or
2. adb is enable and this is the debug app or
3. The flag is enable in SharedPreferences.
Bug: 784947
Change-Id: I0ee0d2eadbc8b2f1b49b5e5959f7e72f8feda80d
Reviewed-on: https://chromium-review.googlesource.com/861285
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Lei Tian <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539909}
[css-layout-api] Change FilteredComputedStyleMap to Prepopulated.
This changes the filtered computed-style-map to being pre-populated.
This shouldn't have any performance difference for the paint api, but
should have increased performance for the layout api.
Additionally this allows style for anonymous boxes to exist. Before we
always had a Node->ComputedStyleMap, however with the layout api it is
possible for access the style for an anonymous box.
Bug: 726125
Change-Id: I2820001f158ac0938a277af491a05f1a72b8c734
Reviewed-on: https://chromium-review.googlesource.com/937905
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539908}
Fix parsing form data binary data.
FormDataParserMultipart contract says that "*OCTET" part of body is read
and passed as string of bytes. In case header has filename, octet part
is ignored - store filename instead.
Actual code doesn't implement it. It led to situation when octet data
were read and were put as string to base::Value. That led to DCHECK as far
as string value must be utf-8 string.
The same problem occurs with FormDataParserUrlEncoded, where encoded part
can be as utf-8 string or binary data.
Bug: 813561
Change-Id: I453e5767e44334535253d1bd3fa4e857c2d3a3ff
Reviewed-on: https://chromium-review.googlesource.com/910848
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539907}
[NTP OptOut] Add metrics to record click actions and expanded state
Bug: 810433
Change-Id: I59aa22cefec747e16993e7f747a02087b80f6aac
Reviewed-on: https://chromium-review.googlesource.com/935684
Commit-Queue: Becky Zhou <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539906}
Introduce Tracked/HostChildURLLoaderFactoryBundle for Workers and frames with opener
This CL:
1. Introduce |Tracked/HostChildURLLoaderFactoryBundle| to track
and post updates to cloned bundles in the event of Network
Service crash.
2. Add browser tests to make sure WebWorkers and frames from
'window.open()' can load URL after crash.
Related Discussions:
https://groups.google.com/a/chromium.org/forum/#!topic/network-service-dev/iWk6Dt9_GA0
Bug: 780956
Change-Id: I3d0b585757e957949d9c4816799ffaa19045ac97
Reviewed-on: https://chromium-review.googlesource.com/912276
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Chong Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539905}
[Chromecast] Do not recreate intent receiver in start
CastWebContentsComponent.start() is called everytime when saying "OKG,
play next" before the media app is stopped by a voice command. Because
we lose the reference to the old intent receiver, the
old one has no chance to unregister from LocalBroadcastManager, which
would cause memory leak.
Change-Id: Ie16fb82c220c48c5410cf57a6d829b2984880d95
Bug: b/73789608
Test: cast_shell_junit_tests
Reviewed-on: https://chromium-review.googlesource.com/933581
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Zhiheng(Vincent) Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539904}
Reland of NetworkService: Implement URLLoader::OnAuthRequired
The initial upload patch of this CL is the same as:
https://chromium-review.googlesource.com/c/chromium/src/+/877512
This reland CL addresses comments at:
https://chromium-review.googlesource.com/c/chromium/src/+/877512/19
The initial upload patch of this CL uses empty credential to indicate
that URLRequest::CancelAuth() needs to be called, which is incorrect
because empty credentials are valid. The latest patch of this CL
contains the fix for this issue.
[email protected], [email protected]
Bug: 783990
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifdbab56badaf3e13b5f15f5aa0d31cfb764325c6
Reviewed-on: https://chromium-review.googlesource.com/938960
Commit-Queue: Jun Cai <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539903}
Add traffic annotation to required arguments to SpdyStream.
Network traffic annotation tag is added to
SpdyStreamRequest::StartRequest and is kept with the stream for all
subsequent socket writes.
Bug: 656607
Change-Id: Id106621ec54af003d174ea875564b049bc8f0e4a
Reviewed-on: https://chromium-review.googlesource.com/936481
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539902}
cros: Add test to lock to ensure password field is read only after submit
Bug: 808486
Change-Id: Icb5491be8b04afa9935147f64c43a08877e34a73
Reviewed-on: https://chromium-review.googlesource.com/900306
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539901}
Refine condition when setTargetAtTime has converged
The function HasSetTargetConverged was too restrictive and would
continue to say the setTargetAtTime event was not converged even
though the increment was so small as make no change in the value.
Thus, adjust the criteria so that if the increment is too small to
affect the value, consider the event has having converged.
There's also a bug in HandleAllEventsInThePast where setTargetAtTime
has converged and we've updated the default value but the timeline
would return the old default value instead of the new converged
default value.
A couple of tests needed to be updated due to the change in the
convergence criterion.
Ran the test https://jsfiddle.net/8vo0gbav/52/ and the CPU now no
longer goes to 100% as it did without this change.
Bug: 813504
Change-Id: I506b31289b5b40380147d231d8b2ea41785d6600
Reviewed-on: https://chromium-review.googlesource.com/940273
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539900}
[ChromeDriver] Save PDB file from Windows build
As the preliminary step to resolve issue chromedriver:2222, modify
the build script to archive the PDB file from each Windows build.
Bug: chromedriver:2222
Change-Id: Ic8641eae20349ff436e0d1ec7ded1968fd97d4a6
Reviewed-on: https://chromium-review.googlesource.com/940169
Reviewed-by: Jonathon Kereliuk <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539899}
Add VR vpython wheels
Adds entrys to .vpython for peakutils and scipy. These are used by the
VR latency test.
Bug: 816641
Change-Id: Ia9a76166c6014cde0bec4fa648fdd270a83089c7
Reviewed-on: https://chromium-review.googlesource.com/940333
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539898}
Update TODO Issue number
[email protected]
Bug: 709181, 817382
Change-Id: Ic64c1c3a0971c24efe459515c720cc6248205195
Reviewed-on: https://chromium-review.googlesource.com/941363
Reviewed-by: Miguel Casas <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539897}
Network config: Only set AutoConnect to false
Setting 'AutoConnect' to true during configuration causes Shill to
attempt to connect immediately after configuration which breaks
the notification logic. By default Shill will set AutoConenct to
true on the first successful connect if not explicitly set to false.
This also adds yet more / better logging.
Bug: 809902
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibace61a761b7adf7b5c87e8db93d54d3b3942a48
Reviewed-on: https://chromium-review.googlesource.com/940338
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539896}
[webauthn] Initial add of isUserVerifyingPlatformAuthenticatorAvailable.
This method is for relying parties to determine whether they can create
a new credential using a user-verifying platform authenticator.
Bug: 803842
Change-Id: I523e61612bf5a13841473cca83be12d2b83767d0
Reviewed-on: https://chromium-review.googlesource.com/910036
Commit-Queue: Kim Paulhamus <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539895}
[ChromeDriver] Fix OOPIF handling on Android
When dispatching mouse events to an OOPIF on android, the coordinates
need to be relative to browser windows, while on desktop they are
relative to the frame.
Change-Id: I2953e42457b4ac3395edcf4db53f2c8780047260
Reviewed-on: https://chromium-review.googlesource.com/941401
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539894}
[ChromeDriver] Fix OOPIF test flakiness on Windows
The OOPIF test is flaky on Windows due to issue chromedriver:2198,
which causes ChromeDriver not waiting for frames to fully load.
This CL adds a workaround to that issue.
Change-Id: I87c37a4c756b8a836d7d3861addb54e8bd03e853
Reviewed-on: https://chromium-review.googlesource.com/939905
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Caleb Rouleau <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539893}
[LayoutNG] Fix DCHECK by early return if no results
Bug: 740993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I38981d061a410067921984516eb9f1894762e8ca
Reviewed-on: https://chromium-review.googlesource.com/940563
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Aleks Totic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539892}
Roll src/third_party/skia/ db1e5c647..dabef9ddd (23 commits)
https://skia.googlesource.com/skia.git/+log/db1e5c6474c1..dabef9dddd4f
$ git log db1e5c647..dabef9ddd --date=short --no-merges --format='%ad %ae %s'
2018-02-27 benjaminwagner Omit Chromecast test that seems to OOM.
2018-02-28 robertphillips Revert "Move atlas manager creation to GrContext derived classes"
2018-02-28 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 360098d5c..2f3a0dc5c (3 commits)
2018-02-27 bsalomon Refactor GrCaps::renderTargetWritePixelsSupported to support for some GL workarounds
2018-02-27 robertphillips Move atlas manager creation to GrContext derived classes
2018-02-27 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ e496333d5..40a19927b (1 commit)
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 06a87ec83..360098d5c (3 commits)
2018-02-27 robertphillips Fission GrAtlasGlyphCache in two
2018-02-27 benjaminwagner Switch Win10 ShuttleC bots to new Windows image.
2018-02-27 benjaminwagner Switch Win10 AlphaR2 bots to new Windows image.
2018-02-27 reed date recent version bump for path serialization
2018-02-27 reed fix crasher in path-->region
2018-02-17 halcanary SkQP: optionally build make_universal_apk with debug on.
2018-02-27 egdaniel Fix unit tests that were causes vulkan unitialized memory warnings in validation
2018-02-27 egdaniel Make sure we add render target mem barriers after any last second copies
2018-02-26 benjaminwagner Upgrade Win Intel Haswell/Broadwell GPU drivers.
2018-02-27 mtklein prepare Google3 for the return of SkOpts_hsw.cpp
2018-02-27 caryclark avoid divide in pathopsquad
2018-02-27 caryclark updated includes
2018-02-27 kjlubick Tweak API fuzzers to run better in libfuzzer
2018-02-27 caryclark work on skimageinfo
2018-02-26 reed keep points as floats until after clipping
2018-02-27 reed limit crash small steps in 1dpatheffect
Created with:
roll-dep src/third_party/skia
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I902377fffe8d387bc76eadc3aa694f69a9bf4046
Reviewed-on: https://chromium-review.googlesource.com/941381
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539891}
Roll src/third_party/angle/ 2f3a0dc5c..d444255a7 (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/2f3a0dc5cbc2..d444255a779b
$ git log 2f3a0dc5c..d444255a7 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 jmadill Refactor signal utils into Observer pattern.
Created with:
roll-dep src/third_party/angle
The AutoRoll server is located here: https://angle-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ic541c0a41284df331e8a29982a0d707347ebd146
Reviewed-on: https://chromium-review.googlesource.com/941403
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539890}
[Cronet] Move test assets from android/test to common test.
Bug: 786559
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5819eab242ec2864d9bdc261868871179e80c8a3
Reviewed-on: https://chromium-review.googlesource.com/906951
Reviewed-by: Helen Li <[email protected]>
Commit-Queue: Misha Efimov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539889}
[ChromeDriver] Tests are disabled for Android Chromium
The following tests are failing on Android Chromium build bot.
Tests are disabled.
Some of these tests are flaky.
Bug: chromedriver:2286
Change-Id: I44a7fa01a4e2d909d78f2749a8f7f5ecdf8c34e5
Reviewed-on: https://chromium-review.googlesource.com/941420
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Artur Khachatryan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539888}
Roll src/third_party/catapult/ c0485e380..e544456fc (1 commit)
https://chromium.googlesource.com/catapult.git/+log/c0485e380759..e544456fc734
$ git log c0485e380..e544456fc --date=short --no-merges --format='%ad %ae %s'
2018-02-28 perezju [soundwave] Store alerts data on local sqlite database
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I307a32cc35cd565844fb01efc82920db814011d3
Reviewed-on: https://chromium-review.googlesource.com/941408
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539887}
Revert "[Chromecast] Update mixer unittests"
This reverts commit 070d31f1089509cf6140ddd96058e8ef1e9ed96c.
Change-Id: I680c372a0e0dce7e24f889bf1a461db26329ed6d
Reviewed-on: https://chromium-review.googlesource.com/941602
Reviewed-by: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539886}
[Android settings] Call password settings "Passwords"
Based on a UI review decision (go/pppme), the title of the passwords
settings on Android should be just "Passwords", instead of the dated
"Save passwords" -- the settings page offers much more than the
ability to switch password manager on or off.
This CL splits the string used for the settings title and for the
switch of the "save passwords" preference. It changes the former to
"Passwords" and keeps the latter "Save passwords".
Screenshots: https://crbug.com/788660#c4
Bug: 788660
Change-Id: I699b753932c379f971b13ada69470f807627ea7a
Reviewed-on: https://chromium-review.googlesource.com/941215
Commit-Queue: Vaclav Brozek <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539885}
Add confine bounds code for Ozone X11.
This CL implements ConfineCursorToBounds() for Ozone X11. By default we
don't want to confine bounds on Ozone X11, because it makes development
painful, so only if --ash-constrain-pointer-to-root is passed in.
This requires some changes to AshWindowTreeHost to move the check for if
we want to confine cursor into a place that an AshWindowTreeHost can
check it every time ConfineCursorToRootWindow() is called.
Bug: 771212
Change-Id: I3092c808e44d6f6c56c995ecd3e8547ba3b4a1cd
Reviewed-on: https://chromium-review.googlesource.com/940276
Commit-Queue: kylechar <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539884}
Revert "Fix crash in media picker and add test."
This reverts commit f8ad1b8866a0eacaa27ee56b57af573ac118e76f.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=811780
Original change's description:
> Fix crash in media picker and add test.
>
> In media picker dialog on Mac, when sharing tab,
> when selected tab is deleted, there was no "Share" buttun state update
> (which should disable it). That caused crash, report was auto uploaded
> from Chrome Canary 66.0.3334.0:
>
> Bug: 807811
> Change-Id: I6cf29087b5cf0926b03b2c27e404fe0d57edcf21
> Reviewed-on: https://chromium-review.googlesource.com/895529
> Commit-Queue: Trent Apted <[email protected]>
> Reviewed-by: Trent Apted <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#533887}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 807811
Change-Id: Ie4064ef9aed08716fce50a79eb036b28cb7f7ba9
Reviewed-on: https://chromium-review.googlesource.com/941541
Reviewed-by: George Zhou <[email protected]>
Commit-Queue: Niklas Enbom <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539883}
remove 'floor's from WebMouseEvent constructor
This cl removes 'floor's from a WebMouseEvent constructor.
They are missed in previous changes.
We don't need these floor since we already already remove other
trunctions and use float value for WebMouseEvent coordinates.
Bug: 456625
Change-Id: Ia1439ee2323369d0272649d5e98f632cfbdcf183
Reviewed-on: https://chromium-review.googlesource.com/940440
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539882}
Fix Mac button order in Translate bubble.
This CL exposes DialogClientView's kIsOkButtonOnLeftSide constant in
views::PlatformStyle and uses it in the views:: implementation of
TranslateBubble to provide the proper button order in the bubble.
Bug: 814477
Change-Id: I2e4c9576fba01bd270310db7d483eb6a6327b192
Reviewed-on: https://chromium-review.googlesource.com/937884
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: anthonyvd <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539881}
Record data savings percent at startup
Records the data savings percentage at Chrome startup for data saver enabled users
who have browsed at least 10MB. Positive and negative savings are recorded in
separate histograms.
Bug: 813258
Change-Id: If764b59e72583aa495fcb604c771540aa1785287
Reviewed-on: https://chromium-review.googlesource.com/935665
Commit-Queue: rajendrant <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539880}
[SPv175] Ensure border radius clip mask layer contents are not scrolled.
This patch ensures that when we paint the mask layer that is generated
as a result of an inner border radius clip, we use the transform from
LocalBorderBoxProperties, which does not include the scroll offset
from the scrolled contents.
[email protected], [email protected]
Bug: 814664
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4ba134134dda367e6ddc9d7005a6ff8ae7003426
Reviewed-on: https://chromium-review.googlesource.com/938319
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: vmpstr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539879}
[Chromecast] Update mixer unittests
BUG= internal b/71559266
Change-Id: I2750dd2e4b8eb012c7035ebb144aab6613538550
Reviewed-on: https://chromium-review.googlesource.com/937805
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539878}
Clear flags in CancelableTaskTracker::TryCancelAll
This makes TryCancelAll() additionally clear the flags map and
invalidate any weak pointers, so that HasTrackedTasks() will return
false immediately after calling TryCancelAll() (aligning calling
TryCancelAll more with destroying the CancelableTaskTracker).
This also updates the unit tests to account for this.
Bug: 817054
Change-Id: I5d65847c2d230ed832d372f3980b847770638126
Reviewed-on: https://chromium-review.googlesource.com/939733
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539877}
Reporting: Use new format for Report-To header
The format of the Report-To header recently changed so that endpoint
groups are the top-level element, instead of individual endpoints.
Bug: 704259
Change-Id: I7534c46abbbb86c367931ffc060972ac36b1084b
Reviewed-on: https://chromium-review.googlesource.com/914687
Commit-Queue: Douglas Creager <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Julia Tuttle <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539876}
Store current componentsData in currentComponentsData
This will be exposed in Javascript on the about://components page so
that tests can easily query component related information.
BUG=810436
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1c53a8919ce5ba47a81ae887052629ba2aaf8c05
Reviewed-on: https://chromium-review.googlesource.com/939869
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Reviewed-by: Caleb Rouleau <[email protected]>
Commit-Queue: Xiaohan Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539875}
[iOS WebView autofill] Get IdentityManager for recording BrowserState
This CL is a small followup to
https://chromium-review.googlesource.com/c/chromium/src/+/930335. That
CL missed changing IdentityManagerFactory to supply the IdentityManager
instance for the recording BrowserState rather than the current one.
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icef1ad5ae99e32768b9d1d25e1619df1efa81fe9
Reviewed-on: https://chromium-review.googlesource.com/939622
Reviewed-by: John Wu <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539874}
[RLS] Rebaseline dom-snapshot-getSnapshot.js
This test had an expected result for the first layout node having
width = 785 which is 800 - scrollbar width of 15. This size now
excludes the scrollbar width both with and without root layer
scrolling.
Bug: 417782
Change-Id: If1b941963d84e9df8e8afccd3cbadd87a2bb2605
Reviewed-on: https://chromium-review.googlesource.com/940666
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539873}
Fix MediaStreamDeviceObserver name in content_renderer_manifest.json
This was renamed from MediaStreamDispatcher in https://crrev.com/c/786593.
Bug: 817214
Change-Id: If3aac97652afbcf08c2ece7beb81a22534d58501
Reviewed-on: https://chromium-review.googlesource.com/941204
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539872}
[MIPS][tcmalloc] Fix mipsel compile errors
tcmalloc is using very old version of linux_syscall_support.h
The following mipsel related changes are pulled from lss project:
https://chromiumcodereview.appspot.com/10067027
https://codereview.chromium.org/13846002
https://codereview.chromium.org/913723002/
https://codereview.chromium.org/836473006
Bug: 810356, 794147
Change-Id: I79c3c77a5b81eb84902aa82b72656a776053de1e
Reviewed-on: https://chromium-review.googlesource.com/909216
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539871}
Releae WebRTCInternals::select_file_dialog_ when dialog dismissed
Before this fix, the DCHECK on line 370 was hit.
Bug: 817376
Change-Id: Ifd97fcb29e64f0ba3368521ae6e7bd37effc99c6
Reviewed-on: https://chromium-review.googlesource.com/941443
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Elad Alon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539870}
Docked Magnifier: Convert switch to Feature
As we are getting ready to launch this feature, this CL
converts the Docked Magnifier switch to a base::Feature
which is enabled by default.
BUG=709824
Change-Id: I3f94149d16d864584a393db8f40a290d911acf7f
Reviewed-on: https://chromium-review.googlesource.com/940441
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539869}
Import wpt@58777966260d8f1a6c5347bc7a531596543e6e80
Using wpt-import in Chromium ab7770e4fcdbbd19c8d01ec97a9c141e05ce78d8.
Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13020
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
TBR=kereliuk
No-Export: true
Change-Id: Ie89e049cceaa07348ddda6c7eaaddcdc4341e782
Reviewed-on: https://chromium-review.googlesource.com/940591
Commit-Queue: Blink WPT Bot <[email protected]>
Reviewed-by: Blink WPT Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539868}
Run appropriate part of LocationBarLayoutTest's setup in a UI thread.
K/L/M tablet testers are failing because LocationBarTablet goes through
a code path that asserts running on UI thread. This CL ensures we run
the offending call in the test's #setUp method on the UI thread.
Bug: 817029
Change-Id: I54f91961d61e316bd61c84b59738c0892024e58c
Reviewed-on: https://chromium-review.googlesource.com/939999
Reviewed-by: Maria Khomenko <[email protected]>
Commit-Queue: Troy Hildebrandt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539867}
[Dice] Change sync error view in user menu
The sync error view in user menu is changed to
match the new mocks which can be found here:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr69mkGC_U_qcI187SvCwUkwM
Screenshot of the new view:
https://drive.google.com/file/d/1BK10ADCLqBE4Q-lXbbYYNAd9AV2BNYiq/view?usp=sharing
Bug: 813497
Change-Id: I0a4e0590cadc8f3dec05221992c86341578fb60e
Reviewed-on: https://chromium-review.googlesource.com/934510
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539866}
Revert "Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e"
This reverts commit 8e57bc6978ba451dcd8eefa8629bff2965d0e998.
Reason for revert: Broke the build -- https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20(dbg)/129796
Original change's description:
> Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e
>
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
> end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
> kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
> again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
> resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add UploadReport to manage database resources during
> upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
> symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
> implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
> CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
> ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
> functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
> Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
> source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
> from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
> ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
> ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
> test
> c69ba3d52783 non-win: Add
> Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
>
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
>
> Bug: crashpad:30
> Change-Id: Ibb9e8eafdd3f310e933bd7dab812254efed1b2be
> Reviewed-on: https://chromium-review.googlesource.com/935486
> Reviewed-by: Mark Mentovai <[email protected]>
> Reviewed-by: Sigurður Ásgeirsson <[email protected]>
> Commit-Queue: Joshua Peraza <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539856}
[email protected],[email protected],[email protected]
Change-Id: Ice1d4a445c2625a3403f0ea6371065db45d7b706
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/941386
Reviewed-by: Xi Cheng <[email protected]>
Commit-Queue: Xi Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539865}
🔧 Mark android_deps READMEs security critical for APK dependencies
Bug: 787005
Change-Id: I3ca8398b856a610a17f2d2c9a03901b58dbb5f65
Reviewed-on: https://chromium-review.googlesource.com/941445
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Nicolas Dossou-Gbété <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539864}
[RLS] Remove virtual/.../visibility-image-layers-dynamic expectations
This patch removes the virtual/threaded baselines for:
virtual/threaded/compositing/visibility/visibility-image-layers-dynamic.html
Bug: 417782
Change-Id: Id3dabaec9d3ea8b979d1f17941758529aa4a4176
Reviewed-on: https://chromium-review.googlesource.com/938979
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539863}
[RLS] Rebaseline iframe-scaling-with-scroll and scrollRevealButton
This patch rebaselines two tests for minor rounding differences
that were introduced with root layer scrolling:
fast/overflow/scrollRevealButton.html
fast/frames/iframe-scaling-with-scroll.html
Bug: 417782
Change-Id: Ic76981c6bd28db6d5be71474d961760b13140b93
Reviewed-on: https://chromium-review.googlesource.com/940638
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539862}
[NTP OptOut] Add accessibility text and fix "learn more" link
+ Add expand/collapse description to the expandable header
+ Fix "learn more" link not showing on restart because remote
suggestions are disabled
Bug: 813136, 813872
Change-Id: I3d527582629ef8d3bd9cf8f28876ca476cd2b959
Reviewed-on: https://chromium-review.googlesource.com/935285
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Becky Zhou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539861}
Marked FindLinkImageAtPointForRelativeUrl as flaky.
Bug: 817385
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia4d71b62e3d6fa5dc1e7f5ae8a918c5a1af2c2cd
Reviewed-on: https://chromium-review.googlesource.com/941405
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539860}
Replace ChromeAnimation instances in SimpleAnimationLayout
This change replaces all of the usages of ChromeAnimation in the
SimpleAnimationLayout with CompositorAnimators. For simplicity
all of the properties used by this layout have been converted into
FloatPropery.
BUG=750381
Change-Id: I9ecf38725e8081926a0b85cab4ebea8905ed35a6
Reviewed-on: https://chromium-review.googlesource.com/833177
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539859}
Revert "Revert "webauthn: support the appid extension.""
This reverts commit 7df8cfae4fb4949f4949d7c3ad9411fbb50b0175. Originally
it broke because r539572 landed between the trybot runs and commit and
broke it. Original commit message:
webauthn: support the appid extension.
This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.
The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.
I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.
[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] https://github.com/w3c/webauthn/issues/803
Bug: none
Change-Id: Ie68e349af9b00de4fc986bfb1516e9650c61ef0b
Reviewed-on: https://chromium-review.googlesource.com/940524
Reviewed-by: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539858}
Converts Android-specific cookie accesses to Mojo.
Converts all instances of access to net::CookieStore over to
network::mojom::CookieManager.
Addressed the uses of cookie store in the following android-specific files:
- chrome/browser/android/cookies
- chrome/browser/android/profiles
Bug: 792672
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icdbacc17b7bee4cf191994fda3639865cbf31b01
Reviewed-on: https://chromium-review.googlesource.com/903307
Commit-Queue: Pritam Nikam <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Randy Smith <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539857}
Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e
14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add UploadReport to manage database resources during
upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
test
c69ba3d52783 non-win: Add
Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.
Bug: crashpad:30
Change-Id: Ibb9e8eafdd3f310e933bd7dab812254efed1b2be
Reviewed-on: https://chromium-review.googlesource.com/935486
Reviewed-by: Mark Mentovai <[email protected]>
Reviewed-by: Sigurður Ásgeirsson <[email protected]>
Commit-Queue: Joshua Peraza <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539856}
[Zucchini] Upload debug symbols to unsigned staging
In order to better debug any crashes of zucchini.exe this change adds
debug symbols to the Chrome symbols archive on unsigned staging.
Bug: 729154
Change-Id: I6ece17e8bedcb53801dc9f3e981d92186a759314
Reviewed-on: https://chromium-review.googlesource.com/940083
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539855}
[Zucchini] Add support to setup.exe for Zucchini patches
Adds support to setup.exe to both upgrade itself and chrome.7z through
Zucchini patches when "use_zucchini = true" as a gn arg.
Zucchini patches are NOT created at this time! This is primarily for
experimentation with the release infra. A security review will be
conducted before launch.
This has been successfully tested using Zucchini-based versions of
chrome_updater.exe for the following cases:
Patchers
| setup.exe | chrome.7z |
-------------------------
| Courgette | Courgette | Default (can also be used for downgrades)
| Courgette | Zucchini | Upgrade: once enabled
| Zucchini | Zucchini | Target Default
| Zucchini | Courgette | Downgrade: in the event of issues
Child Changes:
- setup.rc PATCHERTYPE:
https://chromium-review.googlesource.com/937400
- BUILD.gn zucchini.exe:
https://chromium-review.googlesource.com/937396
Bug: 729154
Change-Id: Iec2e514a8b8a5ee311fe210505ac2b31c0418f54
Reviewed-on: https://chromium-review.googlesource.com/916553
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Samuel Huang <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539854}
Added X-GoogleUpdate-Updater and X-GoogleUpdate-AppId headers to CUS.
As part of the ddos mitigations, implemented all three ddos headers in
the component updater. The base::Optional implementation of the
feature is removed. Instead, the headers are passed using a map of
string to string.
There is an unrelated error handling change to invoke the callback if
for some reason, the caller is passing in no component id in the Update call.
Bug: 813193
Change-Id: I26e86564c13c0a5991027a6612dcdefbf991bfab
Reviewed-on: https://chromium-review.googlesource.com/938636
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539853}
Always use libappindicator if available
This is in effect a temporary fix to always use libappindicator (when
available, but we have deb/rpm dependency on the lib, so it should
always be available), whilst I fix the dependency issue we have on the
build bots which would allow me to add a hard dependency and clean up
the code.
Bug: 799144, 797332 , 419673
Change-Id: Id64a452029b00ec8d86f0d35d319bebcfd8bf99e
Reviewed-on: https://chromium-review.googlesource.com/939732
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Tim Brown <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539852}
Add 32-bit version of libappindicator3-1
When doing a 32-bit build on a 64-bit system, the 32-bit version of the
library is not available. This CL should fix that.
Bug: 799144
Change-Id: I40c6d16d708db102eb4da90ded7bc336cb9f9b09
Reviewed-on: https://chromium-review.googlesource.com/940196
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Tim Brown <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539851}
Roll src/third_party/googletest/src/ 7d15497f7..fe1144246 (5 commits)
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7d15497f7538..fe1144246e7e
$ git log 7d15497f7..fe1144246 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 zhangxy988 Add documentation for VariantWith.
2018-02-27 misterg gmock merging -2
2018-02-27 zhangxy988 Add matcher for std::variant.
2018-01-24 pcc Use _CPPUNWIND instead of _HAS_EXCEPTIONS with MSVC.
2018-01-25 pcc Pass -EHs-c- to disable exceptions with MSVC.
Created with:
roll-dep src/third_party/googletest/src
Bug: 813219, 801780
Change-Id: I50f91ea85c1f118b18820450fbff18716d63b61a
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official
Reviewed-on: https://chromium-review.googlesource.com/941061
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539850}
Put OffscreenCanvas under a new flag
OffscreenCanvas will now be turned on when Experimental Web Platform Features
is enabled, instead of being turned on when Experimental Canvas Features flag
is enabled.
Bug: 803941
TBR: [email protected],[email protected]
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idaefadc28f631f0997af5378a0950912faf8aec4
Reviewed-on: https://chromium-review.googlesource.com/937811
Commit-Queue: Olivia Lai <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539849}
Don't update export button if export flag is disabled
This CL fixes a bug that causes a crash when the export feature is disabled.
Bug: 789122, 814574
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I19bca436ff86cb93b7b2fea786e8e4dfcb9dd4b9
Reviewed-on: https://chromium-review.googlesource.com/941123
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539848}
Quota: Increase temporary storage pool on Chrome OS
Per origin quota for storage APIs (Indexed DB, Cache API, etc) is
allocated out of a "temporary pool", the maximum amount of storage
that Chrome will use on a given device. Historically, this value has
been 1/3 of disk space, based on the heuristic that the web should be
ephemeral and not dominate the device's storage vs. native
applications and content.
Since Chrome OS is web-centric (most apps are web apps, etc) the
fraction significantly limits how much web apps can store on the
device. Bump the number to 2/3. We may increase it further in the
future.
Bug: 817128
Change-Id: I0fa9eb44f6526c9f8112e2c727c396dcd37af92f
Reviewed-on: https://chromium-review.googlesource.com/940434
Commit-Queue: Joshua Bell <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539847}
Remove unnecessary linear layout from main.xml
This change removes a linear layout from main.xml that only has a
single child. The one child has been moved to be a child of the root.
BUG=816715
Change-Id: I96f1ce26f19c56c9ff69587504bc9a8c6d46c326
Reviewed-on: https://chromium-review.googlesource.com/939650
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539846}
Extension API: Move screenLockPrivate API to be CrOS-only.
This is true in practice. This change is the first in a series of
changes to make SmartLock only available on CrOS.
[email protected], [email protected]
Bug: 817115
Test: Existing tests
Change-Id: Idc0e414730d8efb4b36d36071362625e700675e1
Reviewed-on: https://chromium-review.googlesource.com/940448
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: James Hawkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539845}
Initialize TtsPlatformImpl on background thread
TtsPlatformImpl#initialize() calls TextToSpeech#isLanguageAvailable for
each of the installed locales. This call can result in certain calls to
the platform which end up doing I/O tasks. Since this method is run on
the UI thread, it causes those I/O tasks to be performed on the UI
thread as well.
This change fixes that issue by ensuring that that method is called on a
background thread, and only the calls necessary to run on the UI thread
run on it.
Bug: 813669
Test: Manually verified that skipped frames are no longer reported
Change-Id: If092b23eeed35b5384daa5f045c09fb8eda63281
Reviewed-on: https://chromium-review.googlesource.com/925822
Commit-Queue: Bernhard Bauer <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539844}
Revert "Revert "Print with dead subframes for pdf composition""
This reverts commit 2093bb8f1a80cdafbf24832d8662dbabaa92311a.
Reason for revert: The last flaky test shown in crbug.com/817068 is before the fix https://chromium.googlesource.com/chromium/src.git/+/788c11139b869d1fc5b82cbbd238af2fd543535e. According to flaky dashboard, there is no test failure from these browser tests after the fix landed. So it should be good to stay.
Original change's description:
> Revert "Print with dead subframes for pdf composition"
>
> This reverts commit d20c01231eb8acf9d38bc3aa37a108f2cee5f8d2.
>
> Reason for revert: The SubframeUnavailableBeforePrint test added in this CL is flaky (see crbug.com/817068).
>
> Original change's description:
> > Print with dead subframes for pdf composition
> >
> > Handle two cases with dead subframes for pdf composition:
> > -- When a web page has a dead subframe prior to printing, we need to
> > detect the liveness of the subframe, and avoid requesting printing for
> > such frame;
> > -- If after we request printing a subframe, the subframe dies, we add
> > monitoring for render frame's closed event to check whether it is one
> > of our pending ones. If so, notify pdf compositor service about that.
> >
> > We add an interface in pdf compositor service to be notified about
> > the frame's unavailability for either of the above cases.
> >
> > In this CL, we also add a map to record the subframes that are already
> > printed and use it to avoid printing the same ones repeatedly.
> >
> > BUG=814086
> >
> > Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0
> > Reviewed-on: https://chromium-review.googlesource.com/932018
> > Commit-Queue: Wei Li <[email protected]>
> > Reviewed-by: Daniel Cheng <[email protected]>
> > Reviewed-by: Lei Zhang <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#539291}
>
> [email protected],[email protected],[email protected]
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> [email protected]
>
> Bug: 814086
> Change-Id: I2062517c3f955523618be23a52ad507c4da3de90
> Reviewed-on: https://chromium-review.googlesource.com/941201
> Commit-Queue: Colin Blundell <[email protected]>
> Reviewed-by: Colin Blundell <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539818}
[email protected],[email protected],[email protected],[email protected]
Change-Id: Iab653dd94f117956059bf950a4c54fd133270c07
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814086
Reviewed-on: https://chromium-review.googlesource.com/941501
Reviewed-by: Wei Li <[email protected]>
Commit-Queue: Wei Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539843}
Launch 20180123 translate ranker model.
Bug: 786245
Change-Id: I7b20bd9f27c9790548877fa580066c5f2d7a14f8
Reviewed-on: https://chromium-review.googlesource.com/940332
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Philippe Hamel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539842}
Oilpan: Emit write barrier on collection backing assignment
Collection backings use raw pointers instead of Member so we need manual write barriers.
This CL emits a write barrier on collection backing assignment, and disables promptly free for any marked backings, as they may already be registered in the marking CallbackStack.
Bug: 757440
Change-Id: I56f676808bfa94f468594541f979161b8feb773e
Reviewed-on: https://chromium-review.googlesource.com/931141
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539841}
[Notifications] Respect content image kill switch via mojo
- Previously this flag was enforced in ValidateNotificationResources in
NotificationMessageFilter, in case of a compromised renderer which
didn't respect the NotificationContentImage feature flag.
- This patch ensures we continue to enforce this flag for notifications
which take the new mojo code path.
[email protected]
Bug: 796990, 796991
Change-Id: Ic048757c8a2f3c5b063e4987da3a00347335927d
Reviewed-on: https://chromium-review.googlesource.com/930965
Commit-Queue: Anita Woodruff <[email protected]>
Reviewed-by: Oliver Chang <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539840}
[LayoutNG] Fix safe-to-break offset and its use at start of wrapped lines
This patch fixes safe-to-break offset vector in ShapeResult:
1. Fixed before the first glyph of each run to be safe-to-break.
2. Fixed before the last glyph of each run not to force safe-to-break.
3. Fixed non-cluster boundaries were off by one.
Also related, two fixes are made to NGLineBreaker:
1. When the whole item can fit, it does not consider when the start of
the item is not safe-to-break. The optimized code path was removed
to fix this. If this seems to hit performance, we can bring it back
with safe-to-break support.
2. Add |start_should_be_safe| argument to ShapingLineBreaker to make
the start of wrapped line safe-to-break, but not the middle of a
wrapped line (i.e., when there are previous items.)
HarfBuzzShaperTest.SafeToBreakLatinDiscretionaryLigatures was fixed
to match to what HarfBuzz returns as HB_GLYPH_FLAG_UNSAFE_TO_BREAK.
This change causes a crash in
fast/inline/absolute-positioned-inline-in-centred-block.html
This is from an issue in HarfBuzzShaper, tracked in issue 817271.
Bug: 816614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id55ea10f0b6f879981e3725b7cac027b39f3f213
Reviewed-on: https://chromium-review.googlesource.com/939942
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539839}
[PE] Pixel snap fragment clips
Noticed while enabling AA for clips (in general.) This should prevent
regressing a few multicol tests when enabling AA clips.
Bug: 814876
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I06ad3aa535e7ba0781f0f78fb80e43d8b68d70e4
Reviewed-on: https://chromium-review.googlesource.com/937518
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539838}
[SPv175] Add mask effect node for masked SVG roots.
Previously, this would crash.
Bug: 811269
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I672a77ef521537b2306ab174064c1af3e90df982
Reviewed-on: https://chromium-review.googlesource.com/938748
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539837}
Handle BrowserBack to close the window in built-in media players.
Android apps are closed by BrowserBack key on Chrome OS.
To make the built-in app's behavior consistent and keep the app alive, we close
the built-in media players on BrowserBack.
Bug: 807521
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic5097216bc83f6fd78db6f7d9155b0705b2eea3b
Reviewed-on: https://chromium-review.googlesource.com/940784
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Commit-Queue: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539836}
Android: Make ContentShell.apk handle View intents
This is required for apk_operations.py to know which Activity to send
an intent to for the "launch" command.
This also adds a --nokill flag to apk_operations.py, which will allow
URLs to be sent to apks without the application being restarted (due to
the call to set-debug-app).
Change-Id: I9a326a2999afc3e3cf9d143462c2c3bc8d9a480f
Reviewed-on: https://chromium-review.googlesource.com/940762
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539835}
Use IdentityManagerFactory::GetFor*() as static methods
Followup to review comment on
https://chromium-review.googlesource.com/c/chromium/src/+/928654.
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib2c5b3a86929491272399df515638e813b65db25
Reviewed-on: https://chromium-review.googlesource.com/939462
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539834}
[oilpan] Destroy linear allocation area before marking
Bug: chromium:757440
Change-Id: I7ae80b85a64245346d9b7a41aea351b80c86b4b9
Reviewed-on: https://chromium-review.googlesource.com/941221
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539833}
[Android]: Pass serialised passwords from native as a byte array
Chrome passwords settings on Android allow the user to export
passwords. The Java settings code asks the C++ code to serialise and
send over the passwords. The serialised result is in UTF-8 within C++
but gets converted into UTF-16 for Java and then back to UTF-8 on
writing to a cache file.
This CL changes the data type from String to byte array on Java side.
This eliminates the converstion to UTF-16 and back.
Note 1: This was pointed out in
https://chromium-review.googlesource.com/c/chromium/src/+/926527/2/chrome/browser/android/password_ui_view_android.cc#222.
Note 2: This might get further simplified if https://crbug.com/817293
gets implemented, but that's not happening in M66.
Bug: 788701
Change-Id: I0799b2c5f6d7e43e9b7449322d300fb9e9d82c54
Reviewed-on: https://chromium-review.googlesource.com/940226
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539832}
[Benchmarks] Add a smoke test mode for benchmarks
Benchmarks are executed as part of ChOps's smoke tests.
These smoke tests are also run on debug build, which is much slower.
This results in the smoke test framework's perception that Speedometer2
is hanging and thus crashes with a timeout.
Now there is the option to do something different in a benchmark in
case it is run as a smoke test.
[email protected]
Bug=792495
Change-Id: I338c39ba3377738e4e52f1869702d444bb266221
Reviewed-on: https://chromium-review.googlesource.com/941227
Commit-Queue: Michael Hablich <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539831}
Disable runtime feature CompositeOpaqueFixedPosition
This patch fixed the missing part from the previous patch
https://crrev.com/c/939585 to completely disable the feature.
Bug: 814673
Change-Id: Id14a32351d6153221aabf36dec506533ad07b437
Reviewed-on: https://chromium-review.googlesource.com/941262
Commit-Queue: Yi Gu <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539830}
Ensure autorelease pool is drained between tests
The testing::Test fixture (used by TEST macro) does not drain the
autorelease pool after a test. PlatformTest should be used.
Add a PRESUBMIT check that neither TEST nor testing::Test is used
in iOS Objective-C++ test files. Files are assumed to be iOS if
either their base name match '\bios\b' or one of the component in
the path is 'ios'.
Expand MockInputApi to filter files in mocks of AffectedFiles and
AffectedSourceFiles function, adding missing mocked functions too.
Fix unit tests that were failing after the filtering is correctly
implemented.
Bug: none
Change-Id: I0af99b6658b8e15888dfcfb94345eb879ab9fd37
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/937204
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539829}
Roll src/third_party/catapult/ 371be98a6..c0485e380 (1 commit)
https://chromium.googlesource.com/catapult.git/+log/371be98a6bf6..c0485e380759
$ git log 371be98a6..c0485e380 --date=short --no-merges --format='%ad %ae %s'
2018-02-28 nednguyen Remove [page_set] argument in help string message of benchmark run command
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I6b24cf58cacee3faaab8b47cda35dbfa57720ee4
Reviewed-on: https://chromium-review.googlesource.com/941263
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539828}
predictors: Remove ResourcePrefetchPredictor
The ResourcePrefetchPredictor isn't going to be used in the near future.
Bug: 816545
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e15bef529e5f0b13a09275b8fe7b385ec8215ba
Reviewed-on: https://chromium-review.googlesource.com/939171
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Benoit L <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Alexandr Ilin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539827}
[Dice] Make sync illustration in user menu non-accessible
This CL makes the sync illustration in the user menu
non accessible so it is not read by VoiceOver.
Bug: 814995
Change-Id: I280cd359fc389afdeed03bf914b1e8a5cc741bee
Reviewed-on: https://chromium-review.googlesource.com/934507
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539826}
Add metrics for password export on iOS (part 2)
This adds the remaining metric:
- PasswordManager.ExportedPasswordsPerUserInCSV
Bug: 789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I913bedb9f3e716db6f7ac78975344f994ae02016
Reviewed-on: https://chromium-review.googlesource.com/939166
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539825}
Make sure that xmpp targets depend on Chrome's rtc::TaskQueue implementation
Bug: none
Change-Id: Ie3adc12610b37a5021038664ab691c100e3fb652
Reviewed-on: https://chromium-review.googlesource.com/940224
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Tommi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539824}
[gin] Do not create a new object on every background task posted from v8.
Bug: 817330
Change-Id: Ifb402ed997f4c2b4d96e1b4124ee518b8700f69a
Reviewed-on: https://chromium-review.googlesource.com/940140
Reviewed-by: Ross McIlroy <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539823}
[Dice] Add accessible name to dropdown arrow
This CL adds an accessible name to the
"Sync with another account" dropdown arrow in
the contextual promos.
Bug: 814986
Change-Id: Icb43e48a398178d30cd7517b1aba2c1efa697492
Reviewed-on: https://chromium-review.googlesource.com/939397
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539822}
[scheduler] Address after-commit comments in patch 886364.
- Added TODO to move PageVisibilityState into core/.
- Pass weakptr in OnWorkerSchedulerCreated instead of adding a method to
get a weakptr.
- Remove some leftover code.
[email protected],[email protected]
BUG=776416
Change-Id: I1d6705fe59d878f316809cf73ce6f61c8bfe77b6
Reviewed-on: https://chromium-review.googlesource.com/939469
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539821}
Don't show the progress bar on iPad
This CL doesn't show the progress bar during the loading of the page on
iPad.
Bug: 813073
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I94c2ca6b28906220aeaf7affca702bd36e49b0d8
Reviewed-on: https://chromium-review.googlesource.com/941223
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539820}
Roll src/third_party/catapult/ 7a160b6bb..371be98a6 (1 commit)
https://chromium.googlesource.com/catapult.git/+log/7a160b6bb44a..371be98a6bf6
$ git log 7a160b6bb..371be98a6 --date=short --no-merges --format='%ad %ae %s'
2018-02-28 nednguyen Remove perf profilers in Telemetry
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I6aa5eade1047c6e079c448a7041b41171929b88f
Reviewed-on: https://chromium-review.googlesource.com/941181
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539819}
Revert "Print with dead subframes for pdf composition"
This reverts commit d20c01231eb8acf9d38bc3aa37a108f2cee5f8d2.
Reason for revert: The SubframeUnavailableBeforePrint test added in this CL is flaky (see crbug.com/817068).
Original change's description:
> Print with dead subframes for pdf composition
>
> Handle two cases with dead subframes for pdf composition:
> -- When a web page has a dead subframe prior to printing, we need to
> detect the liveness of the subframe, and avoid requesting printing for
> such frame;
> -- If after we request printing a subframe, the subframe dies, we add
> monitoring for render frame's closed event to check whether it is one
> of our pending ones. If so, notify pdf compositor service about that.
>
> We add an interface in pdf compositor service to be notified about
> the frame's unavailability for either of the above cases.
>
> In this CL, we also add a map to record the subframes that are already
> printed and use it to avoid printing the same ones repeatedly.
>
> BUG=814086
>
> Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0
> Reviewed-on: https://chromium-review.googlesource.com/932018
> Commit-Queue: Wei Li <[email protected]>
> Reviewed-by: Daniel Cheng <[email protected]>
> Reviewed-by: Lei Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539291}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
[email protected]
Bug: 814086
Change-Id: I2062517c3f955523618be23a52ad507c4da3de90
Reviewed-on: https://chromium-review.googlesource.com/941201
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539818}
Move file quarantine implementation to components
The implementation is currently in content/ and used by download and pepper.
Download code is being moved to components/.
This CL moves the quarantine implemetation to components/ so it
can be shared between content/ and components/
BUG=803135
Change-Id: Id68afca113891abb8475b6b64f5854be28b0ca3e
Reviewed-on: https://chromium-review.googlesource.com/933287
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539817}
Remove set noparent from chrome/app/nibs
[email protected]
Change-Id: I53c11336429d7c0f3b42c3bb16b3906dfa54ad40
Reviewed-on: https://chromium-review.googlesource.com/939786
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539816}
[Cronet] Rename cronet_impl_common_java target to avoid overlap
Rename the android_library target so it doesn't overlap the
similarly named library in the cronet/ output directory.
This is an attempt to avoid some weird compile flakes where
a class file from one cronet_impl_common_java.jar somehow
ended up in the other cronet_impl_common_java.jar.
Bug: 816981
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia2f431dd7c2793ca5498fd5696cb2f613ef9f6af
Reviewed-on: https://chromium-review.googlesource.com/940586
Reviewed-by: Misha Efimov <[email protected]>
Commit-Queue: Paul Jensen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539815}
cygprofile: Improve orderfile comparison.
This CL adds the "fractional average distance" to examine ordering stability.
Also makes it compatible with orderfiles with symbols.
For instance, for a regular roll:
$ tools/cygprofile/compare_orderfiles.py --from-commit f9062ad5c6383ae959f1c80d20099375a2be745e
[...]
Symbols count:
first: 417918
second: 418657
New symbols = 1004
Removed symbols = 265
Average fractional distance = 0.15%
And a significant one:
$ ./tools/cygprofile/compare_orderfiles.py --from-commit 4c1e7a85c8bac01731203990fd4b66a7b5b19dd9
[...]
Symbols count:
first: 428730
second: 190074
New symbols = 16952
Removed symbols = 255608
Average fractional distance = 26.53%
Note that the distance is insensitive to the relative sizes of the
orderfiles, only to the relative ordering of the intersection.
Change-Id: I188684ef7a0bb545e6a55bc335d432dd6690a203
Reviewed-on: https://chromium-review.googlesource.com/876088
Commit-Queue: Benoit L <[email protected]>
Reviewed-by: Matthew Cary <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539814}
[ios] Update most visited tile style for refresh.
Adds new tile background image and reading list circle.
Bug: 805636
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I46dfca56ea4ebdb682ee688aa5b1b8aa88bf4f73
Reviewed-on: https://chromium-review.googlesource.com/936084
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539813}
Fix use-after-free in AudioOutputDevice.
How did this ever work ¯\_(ツ)_/¯.
Bug: 816348
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2fc1767e6c9cf910241938ca85c03bc503039d07
Reviewed-on: https://chromium-review.googlesource.com/937515
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Max Morin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539812}
[auto] Update FlagExpectations for LayoutNG
Following bot results are included.
3967 3969 3971 3973 3974 3975 3976 3980 3985 3989 3992 3993 3987
1 lines were removed and 21 lines were deflaked by consecutive results
since 3926.
[email protected]
NOTRY=true
Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I955aedc83f4d71f5ac4b9f52decde6b7508a7766
Reviewed-on: https://chromium-review.googlesource.com/938689
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539811}
Merge LegacyToolbarCoordinator and ToolbarCoordinator
This CL merges the LegacyToolbarCoordinator in the ToolbarCoordinator.
Bug: 809785
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I444edfa36c23986323fb3ec686c29d4e3c25ba87
Reviewed-on: https://chromium-review.googlesource.com/931441
Commit-Queue: Gauthier Ambard <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539810}
Update the size of the toolbar
This CL updates the size of the toolbars to match the requirements.
The requirements are described in: crbug.com/807778.
Bug: 807284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icabb8adc10d9b6e4828e83e0b94260612ca334b9
Reviewed-on: https://chromium-review.googlesource.com/939480
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539809}
Oilpan: Move MarkAsUnswept from before marking to after
When incremental marking is enabled, new pages are allocated while marking. By moving the MarkAsUnswept from before marking to after, this simplifies swept flag management. This is because pre sweep all pages become unswept.
This CL also adjusts ObjectPayloadSizeForTesting for this change.
Change-Id: Ic5ea315a2cfd2c65e8d8f08e55b1d202fbeb5915
Reviewed-on: https://chromium-review.googlesource.com/938887
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539808}
Media Engagement: record the number of "isHigh" status changes.
These changes are sent over with UKM data and wiped when local data are
wiped.
Bug: 814351
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I189a430e46fb2a68af34aa7d4b237adad45d781a
Reviewed-on: https://chromium-review.googlesource.com/931471
Commit-Queue: Mounir Lamouri <[email protected]>
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539807}
Add cross-site tab capture test, and fix an OnFrameDamaged() assumption.
Adds a browser test to confirm that tab capture grabs all content and
content updates when cross-site render process isolation is turned on.
The addition of this test revealed a pre-existing bug where the consumer
would not get a video frame for updated content. This happened whenever
OnFrameDamaged() was being called before OnBeginFrame() (which can
happen when Surfaces are changed).
Bug: 808718
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic965ece20d4c40eb65cdb78452148283935e5184
Reviewed-on: https://chromium-review.googlesource.com/936661
Reviewed-by: Xiangjun Zhang <[email protected]>
Commit-Queue: Yuri Wiitala <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539806}
Settings: merge two test-sync-browser-proxy implementations
Bug: 815018
Change-Id: I4acef1831cee5f32b6f2b307c5d695e7f3177cb9
Reviewed-on: https://chromium-review.googlesource.com/939180
Commit-Queue: Scott Chen <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539805}
Support getCapabilities() for audio and video sources other than getUserMedia()
This CL adds support for audio and video properties in MediaStreamTrack.getCapabilities()
for audio and video sources other than getUserMedia().
Bug: 293292
Change-Id: I14569ad829b80ade60ea52f371edc0bffd282583
Reviewed-on: https://chromium-review.googlesource.com/934481
Commit-Queue: Chandan Padhi <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539804}
[Dice] Use first name for signin/sync promo
For the personalized sync promo in the user menu
and the contextual promos "Sync as <FIRST>"
should be displayed instead of "Sync as <FIRST> <LAST>".
This CL fixes this.
Bug: 810865
Change-Id: Idf3f40b9f9a7ecac8dff4d2ab293cafda8399249
Reviewed-on: https://chromium-review.googlesource.com/939396
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539803}
Record the signin/sync consent on Android.
Specifically, record the resource IDs of the strings the user saw
and clicked on when giving consent for Chrome Sync on Android.
See detailed explanation in this (internal) doc:
https://docs.google.com/document/d/1Psl9VJ4Dbc1Dh5bXCTa85OF1_DE3viTTHYwybu3V6Uk/edit#bookmark=id.6zygb41dn9vl
Bug: 781765
Change-Id: I55c04b7c206602d892dcfff34c47b79876000608
Reviewed-on: https://chromium-review.googlesource.com/880861
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539802}
[Dice] Fix account selector bug in contextual promos
This CL fixes a bug in the accounts submenu of the
contextual promos to start sync with the correct
account.
Change-Id: Ib1dd02e66d900172bec38be6ee0449335fe77449
Reviewed-on: https://chromium-review.googlesource.com/941144
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539801}
Corrected reused include guards
If the same include guard is used twice, it becomes impossible
to include both those headers in the same translation unit and
that can be hard to debug and understand. This patch renames
some include guards that have the same names (copy/paste) as
existing include guards.
Found while working on a PRESUBMIT test for include guards. It will
not warn for these things, but it was easy to add that test locally.
There are another few thousand files that have wrongly named
include guards. Left as an exercise to the reader.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic7ba08558d3fbae0d3bee843f3092d472f8c643b
Reviewed-on: https://chromium-review.googlesource.com/937712
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Daniel Bratell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539800}
Reduce flakiness scope for DepthCapture tests to specific device
BUG=737410
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id977164b8acf715c0601b27bc70b54bf5d01d6a6
Reviewed-on: https://chromium-review.googlesource.com/940221
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Aleksandar Stojiljkovic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539799}
Ensure autorelease pool is drained between tests
The testing::Test fixture (used by TEST macro) does not drain the
autorelease pool after a test. PlatformTest should be used.
Bug: none
Change-Id: I7b33f0c53bc57fb8f2266bc58eb578d71da642b4
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/940132
Commit-Queue: Olivier Robin <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539798}
[css-ui] Use "Ahem" instead of "ahem" in tests
"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on css-ui WPT tests.
BUG=724392,796733
Change-Id: I956e939790319ec956164f34af8c72f109c528ef
Reviewed-on: https://chromium-review.googlesource.com/940133
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Manuel Rego Casasnovas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539797}
[signin] Add SigninManager::FromSigninManagerBase
This CL adds a convenience static function to hide casting of a
SigninManagerBase instance to its corresponding SigninManager instance.
This function follows in the grand tradition of
Profile::FromBrowserContext.
This CL also switches all applicable callsites to use the new function
and removes unnecessary static_casts to SigninManagerBase that are
scattered around the codebase.
Note that there are some static_casts that cannot be switched: the ones
in the various SigninManagerFactory instances. These are casting from
KeyedService* rather than SigninManagerBase*.
[email protected]
Change-Id: Ib150071b11a1558f96d06f184a83775acc8b088b
Reviewed-on: https://chromium-review.googlesource.com/939400
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539796}
Added a base::Feature command line switch for specifying a clock-drift setup
This CL adds a command line switch based on base::Feature to allow the user
to explicitly specify when the setup used is such that the audio playout and
capture are done on different clocks (has clock-drift).
Bug: chromium:816742
Change-Id: I8a8e15ef479062a0ab30878ef3bde5b5c1f52d6e
Reviewed-on: https://chromium-review.googlesource.com/938921
Commit-Queue: Per Åhgren <[email protected]>
Reviewed-by: Nick Carter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539795}
[PE] Make SVGGeometryElement handle 'pathLength' mutations
Since the 'pathLength' attribute moved to SVGGeometryElement, so should
the attribute mutation handling.
Bug: 815170
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I04bc19988f80f3c3fe4810897e3003403c6997c6
Reviewed-on: https://chromium-review.googlesource.com/939625
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539794}
Revert "[MacViews] Shim |ShowModalDialog| for Polychrome"
This reverts commit 1a37b1651971b41c71ba51040bee38a51584697c.
Reason for revert: Causing components_unittests to fail compile due to missing definition of the static function. See https://bugs.chromium.org/p/chromium/issues/detail?id=817302#c1 for more details.
Original change's description:
> [MacViews] Shim |ShowModalDialog| for Polychrome
>
> Since "ViewsBrowserWindows" is a Chrome feature, this CL follows
> CreateNativeWebModalManager in declaring a function in components
> and defining it in c/b/ui/cocoa.
>
> Background:
> Polychrome is an intermediate step to shipping MacViews browser.
> Currently, switching between Cocoa browser and MacViews browser requires
> a buildflag. Polychrome builds both Cocoa and MacViews into the same
> binary and allows switching between them based on a feature flag.
> More details at crbug.com/802257
>
> As Cocoa and (much of) Views were not typically built together,
> some symbols were reused. With Polychrome, these are duplicate symbols.
> This CL resolves the issue by renaming the Cocoa symbols, and then
> shimming them for the (regular, not Polychrome) Cocoa build.
>
> Bug: 808017
> Change-Id: I9bf1845aa22305928aafd74884793f0fa86afe56
> Reviewed-on: https://chromium-review.googlesource.com/929942
> Reviewed-by: Mike Wittman <[email protected]>
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Commit-Queue: Leonard Grey <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#538832}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 808017
Change-Id: I523fee5108b570a8e36bb5f5bc91a3896c916742
Reviewed-on: https://chromium-review.googlesource.com/941161
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539793}
Update V8 to version 6.6.343.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dfa786d6..86431ec7
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: Icfcfb83a3161245f68acebc3bbff2b4d18668159
Reviewed-on: https://chromium-review.googlesource.com/940485
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539792}
Jumbo build fix: wincrypt.h and openssl clash
wincrypt.h and OpenSSL headers define the same macros (until
a later version of OpenSSL at least) so therefore we need to
include crypto/wincrypt_shim.h instead which hides the clashing
macros.
[email protected]
Bug: 746957
Change-Id: I629859f8e381ccadfdf9b6d811330bd8fc35be95
Reviewed-on: https://chromium-review.googlesource.com/940225
Reviewed-by: Daniel Bratell <[email protected]>
Commit-Queue: Daniel Bratell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539791}
Enable CodeCacheAfterExecute by default.
CodeCacheAfterExecute is on a finch experiment since 3 weeks and
the results from the finch trial show a 20-40% reduction in
javascript compilation time [1].
[1]:https://docs.google.com/document/d/1Y-a1XcpImrCMCMLJosNiMfjtIjP9zL_upUGlJzeowSo/edit?usp=sharing
Bug: chromium:808007, chromium:783124
Change-Id: Idb0264a81eebc23b12cad71a7dfcdb2a9c0edae7
Reviewed-on: https://chromium-review.googlesource.com/939385
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Mythri Alle <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539790}
Cleanup TaskSchedulerWorkerPoolHistogramTest.NumTasks*Cleanup tests.
TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeCleanup still depends
on cleanup timing, I'll try to remove those dependencies in a follow-up.
[email protected], [email protected]
Bug: 816170
Change-Id: I2cca331d18ee8f3ca384493bd3584c68240c445e
Reviewed-on: https://chromium-review.googlesource.com/936626
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539789}
Import wpt@cc52c7e80c940a475adc28142285082f2c973ed6
Using wpt-import in Chromium e7d579a80a306a09fd0735967304e495069efc04.
Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13005
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-text/line-break
TBR=kereliuk
No-Export: true
Change-Id: I04ebc58e38a8649bf783f3fc6e7f90fde3b51508
Reviewed-on: https://chromium-review.googlesource.com/940486
Commit-Queue: Blink WPT Bot <[email protected]>
Reviewed-by: Blink WPT Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539788}
Remove an unused forward decl in //base/timer/timer.h
Tbr: [email protected]
Change-Id: Iac44f0b08ffef83322e9811fe4bc65cab11ce1c1
Reviewed-on: https://chromium-review.googlesource.com/940706
Commit-Queue: Taiju Tsuiki <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539787}
[oilpan] ListHashSetNode: Avoid marking in Trace method
Instead just forward to the Trace method of this visitor which will call
ListHashSetNode::Trace after marking the node.
Bug: chromium:802273
Change-Id: Ic13090edead2e26c94ce0f0157e3d3f6d1effcb3
Reviewed-on: https://chromium-review.googlesource.com/939823
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539786}
Have explicit send-all-mounts in VolumeMounter
This change add a method to request Chrome to send all existing mount
points. This method is called everytime vold is reseting.
Bug: 64500663
Change-Id: If10577a3d40ebd240a2ad242f703a28ecd3c363e
Reviewed-on: https://chromium-review.googlesource.com/938683
Commit-Queue: Risan <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Reviewed-by: Mattias Nissler <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539785}
Disable flaky ChromeVisibilityObserverBrowserTest.VisibilityTest
There are no obvious recent changes to have turned this test flaky. The
best hypothesis that I have is that something in the changes in
https://codereview.chromium.org/2939943004 was problematic, although
in that case it's unclear why it would only start turning up now.
[email protected]
Bug: 817172
Change-Id: Ic0665e7d8d606b5ecb01d11f641bcfe2ec82a1ab
Reviewed-on: https://chromium-review.googlesource.com/941121
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539784}
[css-typed-om] Return transform components for computed transform.
ComputedStylePropertyMap should return computed values. For 'transform',
that's "as specified, but relative lengths converted to absolute" [1].
This means we need to return the individual transform components like
'translate3d'.
Currently there's no code to do this, so we have to roll our own.
[1] https://drafts.csswg.org/css-transforms-1/#propdef-transform
Bug: 816803
Change-Id: I64305512fa0d0ce32ba86ea2b14595b551ff1c8d
Reviewed-on: https://chromium-review.googlesource.com/938885
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539783}
Do not spawn multiple ExportWarningDialogFragment
So far, SavePasswordsPreferences always assumed that onResume is only
called after Chrome is killed. However, it can also be called when it
is just paused. In that case, and if the export warning is shown,
onResume should not cause another export warning dialog to pop up.
Also, if Chrome is resumed after a long time, the reauthentication for
exporting should not be conisdered valid any more.
Therefore, this CL adds a member variable keeping a reference to the
export warning dialog inside SavePasswordsPreferences. During
onResume, it uses the variable to dismiss the dialog if the
reauthentication is no longer valid. The CL also makes
SavePasswordsPreferences skip creating the warning dialog in case it
already exists and is functional.
(Note: if Chrome is resumed after being killed, the warning dialog
will be re-created by Android, but not functional. In that case it
dismisses itself and SavePasswordsPreferences need to re-create it
properly. This is not changed in this CL.)
Bug: 815156
Change-Id: I5e6372cbde1e7e5d1e333fd06206f99618907eb6
Reviewed-on: https://chromium-review.googlesource.com/939471
Commit-Queue: Vaclav Brozek <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539782}
Reland "Fix wrong password saving when loging to facebook."
This is a reland of ccaa8bf97edd3288a57330ff0d772bd48e08f8b3.
Original change's description:
> Fix wrong password saving when loging to facebook.
>
> Facebook.com may perform |SameDocumentNavigation| on login form submit.
> User password will be saved even if it is wrong.
>
> The changeset disables trigger on action changes.
>
> Change-Id: I4103661fb9649280862229248f329da23dcc8912
> Bug: 808917
> Reviewed-on: https://chromium-review.googlesource.com/897638
> Reviewed-by: Jochen Eisinger <[email protected]>
> Reviewed-by: Dominic Battré <[email protected]>
> Commit-Queue: Иван Афанасьев <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539110}
Bug: 808917
Change-Id: I098cde3361288d60d083649f25ceec8265140f7a
Reviewed-on: https://chromium-review.googlesource.com/940122
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Иван Афанасьев <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539781}
[css-multicol] Use "Ahem" instead of "ahem" in tests
"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on WPT tests.
BUG=724392,794136
Change-Id: I55ce2ee7ed36b2708da571f52256716e97a072cb
Reviewed-on: https://chromium-review.googlesource.com/940921
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Manuel Rego Casasnovas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539780}
[Password Manager] Introduce chrome.passwordsPrivate.cancelExportPasswords()
The export progress UI offers a cancellation action. Cancelling should
stop writing to the disk and undo any content which was already written.
This CL introduces the chrome.passwordsPrivate function
cancelExportPasswords() which forwards the user's request to cancel to
the browser.
The API proposal for the export functions of passwordsPrivate is
https://docs.google.com/document/d/1WtsbdTnWpZUMlL6q9mqdO_bY8QZi-JSrJV9RkZysNpQ/edit#
I have updated it with the cancel function.
Bug: 811779
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I095af1029bdda7dc45e8623b77acad4464e80310
Reviewed-on: https://chromium-review.googlesource.com/924058
Commit-Queue: Christos Froussios <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539779}
getCapabilities() should not have range properties without valid values
This CL ensures that MediaStreamTrack.getCapabilities() does not have
range properties if they don't have a valid range.
Bug: 293292
Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d
Reviewed-on: https://chromium-review.googlesource.com/938983
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539778}
Add metrics for password export on iOS (part 1)
This CL adds the following metrics:
- PasswordManager.ExportPasswordsToCSVResult
- PasswordManager.TimeReadingExportedPasswords
Metrics still to be added in following CLs:
- PasswordManager.ExportedPasswordsPerUserInCSV
Bug: 789122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5e92c93f07888e0e3fc7c7468de5543755e6834d
Reviewed-on: https://chromium-review.googlesource.com/912131
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539777}
Fix a bug of <fieldset disabled> detection logic.
HTMLFormControlElement::UpdateAncestorDisabledState() checked if the
highest <legend> is the first <legend> child of the highest disabled
<fieldset>. It should check <lengend> child of every disabled fieldset
ancestors.
Bug: 817181
Change-Id: I8f7dedd8089757d9eae726de359b0efe47cf9f44
Reviewed-on: https://chromium-review.googlesource.com/940644
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539776}
[CI] Referencify MarkForLayoutAndParentResourceInvalidation
Cleanup some (now) unnecessary explicit 'this' dereferences as well.
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I49238bf7b32760e5a05f6b6ce41557d34423ea45
Reviewed-on: https://chromium-review.googlesource.com/931508
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539775}
Files app: Handle BrowserBack to minimize the app window.
Android apps are closed by BrowserBack key on Chrome OS.
To make the built-in app's behavior consistent and keep the app alive, we
minimize the app window on BrowserBack.
Bug: 807521
Test: Manually tested
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib4883b75791721baf1b2ff814d4e5047a0dfe726
Reviewed-on: https://chromium-review.googlesource.com/940743
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Commit-Queue: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539774}
Sessions Sync: Remove special handling for chrome://newtab/#open_tabs
The NTP hasn't had an "open tabs" page in years. Time to get rid of this.
TBRing trivial test-only changes in app_menu_controller_unittest.mm and
recent_tabs_sub_menu_model_unittest.cc.
[email protected]
Bug: none
Change-Id: Ib4d901ef6cfe67ab546016cc09dfcc2d9673572c
Reviewed-on: https://chromium-review.googlesource.com/939395
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539773}
Add a static_assert to ban non-ref-counted raw-pointer receiver on base::Bind
base::Bind used to fail if a raw pointer to a non-ref-counted object is
passed as a receiver. Though that is an expected failure, its error
was hard to read. This CL adds a static_assert for the failing case
for better error message.
Change-Id: I7057fbfaa0c24530f3b9e28b4362f4b8637cd1be
Reviewed-on: https://chromium-review.googlesource.com/923661
Commit-Queue: Taiju Tsuiki <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539772}
ARC a11y: fixes a few text field attributes
- any node with the editable boolean property should automatically be considered a text field
- ChromeVox expects to see |url| on a root automation node
- clarify what gets used as an accessible name
- give each ax tree source an id
Change-Id: I073808c797da55f9b54c3732cc8bb7a22da6a7c6
Reviewed-on: https://chromium-review.googlesource.com/936429
Reviewed-by: Yuki Awano <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539771}
[Autofill] Remove unneeded deps on //components/signin
After recent refactorings, //components/autofill no longer uses
//components/signin. This CL rips out dead includes, APIs, and
dependencies.
[email protected]
Bug: 809435, 809927
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If5289bd88003f9e58f1ce404870fd47b0fffa2e3
Reviewed-on: https://chromium-review.googlesource.com/916197
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539770}
Change RTCRtpSender.dtmf to call sender directly
This makes the "dtmf" attribute of RTCRtpSender link
directly to the sender-based DTMF sender in the WebRTC
layer, without going through the track.
Bug: 814214
Change-Id: I5b04a64a7e9105ef4a8ed5e826eb812ea43ea8ac
Reviewed-on: https://chromium-review.googlesource.com/936765
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539769}
Roll src/third_party/angle/ 640fa5dc3..2f3a0dc5c (2 commits)
https://chromium.googlesource.com/angle/angle.git/+log/640fa5dc3f95..2f3a0dc5cbc2
$ git log 640fa5dc3..2f3a0dc5c --date=short --no-merges --format='%ad %ae %s'
2018-02-27 yunchao.he Report INVALID_VALUE if width/height of invalidateSubFramebuffer is negative.
2018-01-28 fjhenigman Vulkan: use correct vertex stride.
Created with:
roll-dep src/third_party/angle
The AutoRoll server is located here: https://angle-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ic0ff3ef53cc68f84b7700721927da6c1826edc5b
Reviewed-on: https://chromium-review.googlesource.com/940817
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539768}
OOR-CORS: drop |skip_service_worker| argument from IsNoCORSAllowedContext
Today, the Service Worker spec explicitly defines that requests from
all plugins should not be handled by Service Workers, and actually
Blink and Pepper set |skip_service_worker| to true, that means
|skip_service_worker| is always true for |kRequestContextPlugin|.
So, now we can simply remove |skip_service_worker| argument from
IsNoCORSAllowedContext, and return always true for
|kRequestContextPlugin|.
Bug: 803766
Change-Id: I1a421895190bd981439ad0eb02fdc776c9a77c10
Reviewed-on: https://chromium-review.googlesource.com/930611
Reviewed-by: Takeshi Yoshino <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539767}
OOR-CORS: revise PreflightCache unit tests
This patch modifies PreflightCache to provide two separate methods
to count cached origins and entries for better testing.
This change allows me to remove many comments that are not necessary
for readable code.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I04dc60034f705847e93d27d63ad1cb9fc3a70e97
Reviewed-on: https://chromium-review.googlesource.com/936824
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Takeshi Yoshino <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539766}
Move FirstRectForRange() to VisibleUnits.
Move FirstRectForRange() to VisibleUnits, make |Editor| class simpler
for improving code health.
BUG=672405
Signed-off-by: Zhuoyu Qian <[email protected]>
Change-Id: Iaca3148ba5a6f186a7870ede3ef59e0ddf4078bd
Reviewed-on: https://chromium-review.googlesource.com/938888
Reviewed-by: Yoshifumi Inoue <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539765}
Update WebView's bottom padding for the toolbar
This CL updates the bottom padding of the WebView to reflect the toolbar
presence at the bottom of the screen. It allows the WebView to resize
such as its frame is only the visible portion of the page.
Its frame is updated to follow the updates of the toolbar during
fullscreen, in the same way as it is done for the top toolbar.
Bug: 812232
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib52f47664399d23857115a4b1c01961803d038af
Reviewed-on: https://chromium-review.googlesource.com/931466
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539764}
Roll src/third_party/googletest/src/ 7a2563a51..7d15497f7 (41 commits)
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7a2563a51456..7d15497f7538
This is a reland of https://crrev.com/c/900544 which was reverted
because it broke net_unittests on Windows Debug builds
https://crbug.com/810347. The reland bumps Google Test past
https://github.com/google/googletest/pull/1450 which contains a fix for
the net_unittest breakage.
$ git log 7a2563a51..7d15497f7 --date=short --no-merges --format='%ad %ae %s'
2018-02-23 pwnall Switch default death test style back to "fast".
2018-02-26 misterg merging unittests - 5
2018-02-23 misterg merging unitests - check 4
2018-02-23 misterg merging unitests, check
2018-02-23 misterg merging unittests - 2
2018-02-23 misterg merging unitests
2018-02-23 anders.sundman Removed trailing comma in enum
2018-02-23 cirnotoss TEST() arguments are invalid in an example
2018-02-22 misterg merges
2018-02-19 costan Fix unused function warning on Mac OS.
2018-02-13 misterg cleanup, merges
2018-02-13 misterg cleanup/merges
2018-02-13 misterg merging, cleaning up
2018-02-13 misterg merges
2018-02-13 misterg cxxx11
2018-02-13 misterg clang warnings
2018-02-13 misterg clang warnings
2018-02-13 misterg https://travis-ci.org/google/googletest/jobs/340995238
2018-02-13 misterg clang warning 'https://travis-ci.org/google/googletest/jobs/340987201'
2018-02-13 misterg clang warning https://travis-ci.org/google/googletest/jobs/340978022
2018-02-13 misterg merges
2018-02-12 misterg moving JoinAsTuple to internal
2018-02-09 costan Fix std::iscntrl use in gtest-printers.cc
2018-02-12 misterg Merging, coniniue
2018-02-09 misterg merging
2018-02-09 misterg merges
2018-02-09 misterg merges
2018-02-07 troy.holsapple Fixed typos
2018-02-03 sokolov Add ability to throw from ASSERT
2018-02-06 gennadiycivil Include MSVC14 on PRs as well
2018-01-31 misterg Merges and also adding new bazel build mode
2018-01-30 misterg Code merges
2018-01-30 misterg Ability to optionally depend on Abseil plus upstream of 183716547
2018-01-26 misterg Adding tests to googlemock bazel
2018-01-26 misterg Code merges
2018-01-26 lidaobing Update Documentation.md
2018-01-25 stefano.soffia.it Fix test build issue with GCC7.2.
2018-01-25 gennadiycivil Update README.md
2018-01-25 gennadiycivil Remove Visual Studio 10,11,12 from build matrix
2018-01-24 misterg placating gcc and its overzeauls size comparison warnings
2018-01-24 misterg upstream cl 182543808
Created with:
roll-dep src/third_party/googletest/src
Bug: 813219
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official
Change-Id: Ie27a86d27a865bbf076a5aa1a4931b85bc5fceb2
Reviewed-on: https://chromium-review.googlesource.com/923205
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539763}
Safely dismiss ExportWarningDialogFragment
The ExportWarningDialogFragment should be able to be safely dismissed
even if it was not fully initialized. The fragment can be shown on
re-creation of Chrome by Android, in which case it does not get
initialized, and dismisses itself for that very reason. However, the
current onDismiss procedure tries to call back to a handler obtained
during initialization.
This CL makes that calling back optional, only for cases when the
handler is already set.
Bug: 816377
Change-Id: Ib9e1b498e7dbb14afc31634a48829782cb4b020b
Reviewed-on: https://chromium-review.googlesource.com/939461
Reviewed-by: Finnur Thorarinsson <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539762}
Fix test when browser window is not active while test running
It expects platform_util::IsWindowActive() before subcribe to renderer events
and it isn't necessary so for example at local execution or simulatesly running
several tests. Thus it should set window active and it is interactive ui test.
Change-Id: Ia2bfd487fc1fe33aee1c35e0bbee342b72ef6fe2
Reviewed-on: https://chromium-review.googlesource.com/936541
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Boris Yusupov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539761}
Import wpt@8c4cf0026a8c041c8e9efb8d0f5553a2a0eff008
Using wpt-import in Chromium 468d0c82092a0c5e54c6f24ffdf19496a14de4a3.
Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13004
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected], [email protected]:
external/wpt/streams
[email protected], [email protected]:
external/wpt/payment-request
[email protected]:
external/wpt/workers
TBR=kereliuk
No-Export: true
Change-Id: I229ea142767665c14eb3c9fb1123a40f9f4f0676
Reviewed-on: https://chromium-review.googlesource.com/940881
Commit-Queue: Blink WPT Bot <[email protected]>
Reviewed-by: Blink WPT Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539760}
ArcVolumeMounter: Send all mounts in UI Thread
As noticed by hashimoto@ and lhchavez@ in ag/938683, we actually need to perform this
in UI Thread instead of blocking pools. We are still posting the task to
a thread to keep the non-blocking I/O behaviour.
Bug: chromium:816816
Change-Id: I607f515e335bb48e074caa60a67835074d179558
Reviewed-on: https://chromium-review.googlesource.com/939065
Commit-Queue: Risan <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539759}
v8binding: Re-implements V8PersistentCallbackFunction.
Following https://crrev.com/c/928783 , refactors
V8PersistentCallbackFunction<T>.
Major improvements:
- V8PersistentCallbackFunction<T> is no longer a subclass of
T. There will be no unintentional conversion between
wrapper-tracing version and v8::Persistent version.
- WrapPersistent(T*) = delete;
where T is wrapper-tracing versions of callback functions.
There will be no misuse of WrapPersistent for wrapper-
tracing versions.
Bug: 779036, 810701
Change-Id: I7b83caa2b064b70e338892c873b1eb258d2a9c99
Reviewed-on: https://chromium-review.googlesource.com/931561
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539758}
Fix performance regression in AXEventGenerator
The reverse relation maps are maps from each attribute, to
a map from destination id to a set of source ids, like this:
map<attr, map<int, set<int>>>
AXEventGenerator::FireRelationSourceEvents used const auto
in two places where it should have used const auto&, resulting
in making two temporary copies of every entry in the map for
each node in the tree.
Tested manually using chrome://tracing. Without
FireRelationSourceEvents at all, loading one Wikipedia page
took ~100 ms. With FireRelationSourceEvents, it took 28,000 ms.
With this fix it took ~115 ms, so FireRelationSourceEvents is
now adding just a small, acceptable amount of overhead. We could
optimize it further if needed.
Bug: 817133
Change-Id: Ib02968593ed5c9533fb72adae4eba32faea3e61f
Reviewed-on: https://chromium-review.googlesource.com/940815
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539757}
Roll back Fuchsia SDK temporarily.
The most recent SDK roll has broken an IPC file-descriptor passing test,
which appears to be due to a mismatch between the semantics of
fdio_transfer_fd() and fdio_create_fd().
TBR: scottmg
Bug: 817241
Change-Id: I020425fa1a948c67f8cd8cdb2b0b64cd052c7479
Reviewed-on: https://chromium-review.googlesource.com/940164
Reviewed-by: Wez <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539756}
Fix ArcAccessibilityHelperBridgeTest.NotificationEventArriveFirst
Bug: 817264
Test: ArcAccessibilityHelperBridgeTest.NotificationEventArriveFirst
Change-Id: Id9c90466a335680355ac83fc6d8b70a387c53b99
Reviewed-on: https://chromium-review.googlesource.com/940902
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539755}
Add an aura property for window corner radius. Propagate to mus.
Fix a bug in Mash where a root window would be given two shadows:
one each process. The one in the browser process would be clipped
to the root window bounds, so is only visible when the window has
rounded corners.
The corner radius is currently only used for window server shadows.
(E.g. it's not used in aura::Window::HitTest()).
Bug: 811859, 801583
Change-Id: I260b0ff71e01181952d0ef4dfbfebd8ae95133b5
Reviewed-on: https://chromium-review.googlesource.com/925943
Commit-Queue: Trent Apted <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539754}
Add network traffic annotation to QuicChromiumPacketWriter.
Network traffic annotation tag is added to:
QuicChromiumPacketWriter::WritePacketToSocketImpl()
Bug: 656607
Change-Id: I97a40e772f70a23fc2503fe5a9dc3e62cc14d963
Reviewed-on: https://chromium-review.googlesource.com/934129
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539753}
Complete migration to virtual PeerConnectionObserver destructor.
Completes migration introduced here:
https://chromium-review.googlesource.com/c/chromium/src/+/839867
Bug: webrtc:8662
Change-Id: I6eac81b115192809f07fb4bff40d4a4567b02002
Reviewed-on: https://chromium-review.googlesource.com/939383
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Sami Kalliomäki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539752}
Roll src/third_party/webrtc/ 8cb344acf..12c8110e8 (1 commit)
https://webrtc.googlesource.com/src.git/+log/8cb344acfdb1..12c8110e8c71
$ git log 8cb344acf..12c8110e8 --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src/third_party/webrtc
BUG=None
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
[email protected]
Change-Id: I27d9d05b16496742be11cf178c0ca2721415ed9d
Reviewed-on: https://chromium-review.googlesource.com/939766
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539751}
[Autofill] Move CreditCardSaveManager away from using IdentityProvider
CreditCardSaveManager uses IdentityProvider to get the "active username."
In practice it is always a ProfileIdentityProvider instance that is
passed in (cf. crbug.com/809435), and the active username in that
context is the email address of the primary (authenticated) account.
As we are looking to eliminate ProfileIdentityProvider, this CL relpaces
CreditCardSaveManager's usage with equivalent usage of IdentityManager.
Bug: 809435, 809927
Change-Id: I12fe0523c7297495b362d4360d056b7208b0077f
Reviewed-on: https://chromium-review.googlesource.com/915945
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539750}
Floating keyboard: Change the screen orientation positioning heuristic
Previously, this would anchor the keyboard to the closest edge of the
screen in both the X and Y directions. When the screen orientation or
screen size changes, it would maintain the same pixel distance from
each of those sides. When the keyboard is intentionally anchored in a
corner, this works out great, but when the keyboard is centered along
an edge of the screen, this creates unexpected results since the
distribution of padding on either side of the keyboard has changed
significantly.
This simplifies the logic to simply maintain the ratio of padding on
either side of the keyboard in each direction (referred to in the code
as `[left_|top_]padding_allotment_ratio`. This records the percent of
the available padding that appears to the left or above the keyboard.
This ratio is maintained across screen size changes.
Updated unit test, which lacked non-corner test cases.
Bug: 817226
Change-Id: I13e424f436aaa62cf8aa77626fa27985cbdf24a2
Reviewed-on: https://chromium-review.googlesource.com/940745
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Blake O'Hare <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539749}
[css-text] Use "Ahem" instead of "ahem" for fonts in tests
Using the lowercase version causes flakiness on Windows
(see crbug.com/724392).
BUG=817030
Change-Id: Ic4bdea7d40f0c2e96d6669430b3cce7a296e8d55
Reviewed-on: https://chromium-review.googlesource.com/940123
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Manuel Rego Casasnovas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539748}
Automated Commit: Committing new LKGM version 10445.0.0 for chromeos.
[email protected]
Change-Id: I7e815eca71e93704646fcc2727fe6d5402cb3b37
Reviewed-on: https://chromium-review.googlesource.com/940484
Reviewed-by: ChromeOS Commit Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539747}
Use the shared instance of base::Default{,Tick}Clock in tether/
This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.
After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.
Bug: 789079
Change-Id: Ia356ea3386b1452a76ea6858f50e0a7944a2b63e
Reviewed-on: https://chromium-review.googlesource.com/937043
Commit-Queue: Taiju Tsuiki <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539746}
ARC a11y: static text nodes can be clickable
Test: in Skype, click the 'next button' text view. Verify screen transitions appropriately.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic3fcfa4c29091e16674a08b2707c0ec867e01b1a
Reviewed-on: https://chromium-review.googlesource.com/938566
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539745}
[WebView Autofill] Support all formless form
Support autofill all formless form by disable feature kAutofillRestrictUnownedFieldsToFormlessCheckout.
Bug: 816949
Change-Id: Ic5640f78ea97a956c37ccc6c86c2ca09242869d1
Reviewed-on: https://chromium-review.googlesource.com/939641
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Tao Bai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539744}
Use Material Design colors for UI icons.
This changes icons generated with use of SetImageFromVectorIcon or
DeriveDefaultIconColor to generate #757575 from a black related text
color. The use of alpha in SetImageFromVectorIcon is changed to result
in #9E9E9E for disabled icons when used to generate icons for black
text.
Some of the favicons are changed to have a MD-blue icon as part of
WebUI branding.
Bug: chromium:774563
Change-Id: I978b1cba4d33a06e834f0ff7d74d3dbc6a305b57
Reviewed-on: https://chromium-review.googlesource.com/752028
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539743}
Roll AFDO from 66.0.3356.0_rc-r1 to 66.0.3357.0_rc-r1
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iaa28926e238fe43adb5034e0e8336188150e0258
Reviewed-on: https://chromium-review.googlesource.com/939906
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539742}
Utilize selection_test() to editing/selection/select-across-readonly-input-[1-5].html
This patch changes "editing/selection/select-across-readonly-input-[1-5].html"
to utilize |selection_test()| to avoid using pixel expectations and unifies into
"select-across-readonly-input-1.html" since these tests are similar, for ease of
maintenance.
This patch is a preparation of the patch[1].
Note: Following patch will move "select-across-readonly-input-1.html" to
"mouse/select_across_readonly_input.html".
[1] http://crrev.com/c/930841 Sanitize computed start and end positions
Bug: 679977
Change-Id: Ife701bd528f817f86d3fa2487903bec12659fb00
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/939142
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539741}
Update V8 to version 6.6.342.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e4486f8c..dfa786d6
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: I0116202d36ab7dcb94b8b602eabc1d83664f6a24
Reviewed-on: https://chromium-review.googlesource.com/940587
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539740}
OOR-CORS: Port WebCORSPreflightResultCache to network service
This patch implements network::cors::PreflightCache and replaces
existing blink::WebCORSPreflightResultCache. Thin wrapper functions
for DocumentThreadableLoader are placed in CORS, but these will be
removed once OOR-CORS efforts are done.
Bug: 803766
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I78d5c7832e7d104e6ebd7c775220a9add8fe3e49
Reviewed-on: https://chromium-review.googlesource.com/921561
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Takeshi Yoshino <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539739}
Cleans up <Component>Export.h and adds header comments.
Adds a summary about PLATFORM_EXPORT, etc., and improves
implementation a bit (e.g. COMPILER_MSVC is preferred to
_MSC_VER).
Change-Id: I114a064a19b4c77ea57810af51c533d8882f13c1
Reviewed-on: https://chromium-review.googlesource.com/939322
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539738}
[3P-Conflicts] Rename Incompatible Software to Incompatible Applications
Change the usage of "Software" to "Applications in for the third-party
conflicts warning subpage of the settings.
Bug: 717696
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id6ec26d7690d4946e62426b10916e589cc9c5d19
Reviewed-on: https://chromium-review.googlesource.com/940426
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539737}
Migrate Copy(),Cut() to Execute{Copy,Cut}() in EditorCommand.
Editor::Copy() is called by ExecuteCopy() and Editor::Cut() is called
by ExecuteCut() in EditorCommand.cpp. Move them to make |Editor| class
simpler for improving code health.
Bug: 672405
Signed-off-by: Zhuoyu Qian <[email protected]>
Change-Id: Ie1ad23ea7b1691dd119b6e476897ce97482f1a2c
Reviewed-on: https://chromium-review.googlesource.com/933741
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539736}
Quota: Refine "should/must remain available" thresholds
Chrome has a "should remain available" disk space threshold; when less
than this amount is free, the effective quota for each origin drops to
0 so new writes will fail. This is present to avoid Chrome being
responsible for filling the disk which generally makes devices
unhappy. Similarly, Chrome has a "must remain available" threshold at
which point data starts being evicted - keeping the device functional,
but potentially losing user data.
The thresholds were set as a percentage of the disk size, but after
further consultation these are changed to absolute values (2GB for
"should" and 1GB for "must") to make the behavior more predictable and
to ensure more space on low end devices to accomodate e.g. app
updates.
Bug: 802027,817128
Change-Id: I3a081d4e17d0e5ad74fb4e877f919f0cc1bec5b2
Reviewed-on: https://chromium-review.googlesource.com/940185
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539735}
Simply PrefetchURLLoader{Service,Factory} with dispatch_context
Use the binding_set's dispatch_context to attach frame_tree_node_id info
to the binding itself, so that we don't need to create separate objects
for each frame's factory.
[email protected]
Bug: 803776
Change-Id: I3a564ae2c75a82a82c4cbb720788f52137552f92
Reviewed-on: https://chromium-review.googlesource.com/937521
Commit-Queue: Kinuko Yasuda <[email protected]>
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539734}
ProfileChooserView: Fix SetSubtitleElideBehavior() crash.
Sometimes, a profile will be signed in, but have no email / username attached.
This causes a crash when trying to elide an empty email. Temporarily fix the
crash by checking that the username is not empty before eliding it.
Bug: 815047
Change-Id: Ia150453fc6cce5b759c88755ca16a861c32faf86
Reviewed-on: https://chromium-review.googlesource.com/936982
Commit-Queue: Patti <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539733}
v8binding: Makes callback interface's operations return v8::Maybe.
Following the same way as callback function, callback interface's
operations also return v8::Maybe so that the callsites can handle
both of the return value and an exception.
Bug: 778580
Change-Id: Id58bc69fe1eae00db29ac55b7f700c957f8038eb
Reviewed-on: https://chromium-review.googlesource.com/939227
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539732}
Only use label_source when kAutofillSkipComparingInferredLabels enabled.
To avoid regression, we should only use label_source when
kAutofillSkipComparingInferredLabels enabled.
Bug: 755410
Change-Id: Ie9f28430b10a650b7049491c79093e1630438dc9
Reviewed-on: https://chromium-review.googlesource.com/938765
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Tao Bai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539731}
Simplify ChromeResourceDispatcherHostDelegate::ShouldInterceptResourceAsStream to remove unneeded code path.
When writing the equivalient network service code path (cl 910315), Yuzhu found we didn't need the path that's taken when a plugin path is provided. The code also always calls StreamsPrivateAPI when this method returns true.
I've tested with the PDF plugin and it works with these changes. The docs extension doesn't seem to work in Chromium builds with and without this change.
Bug: 705114
Change-Id: I37434b506326e4ad6a3a07e5e3c8653be3489f73
Reviewed-on: https://chromium-review.googlesource.com/939857
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539730}
Implement Permission Delegation behind a flag
This implements permission delegation which means that only top-level frames
can directly request permission. Top level frames can delegate access to
iframes using feature policy. If a cross-origin iframe has access delegated
and makes a permission request, a prompt may be displayed with the origin of
the top level frame.
Implementation-wise this CL translates the requesting origin of a permission
request into the top-level origin for the purpose of permission checks. Feature
policy checks will ensure that only cross-origin iframes that have been
explicitly granted access will have the opportunity to request permission.
Bug: 802945
Change-Id: Ic4091ceebb7c32d7e7cfe7b293889ee037eece07
Reviewed-on: https://chromium-review.googlesource.com/737390
Reviewed-by: Finnur Thorarinsson <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Commit-Queue: Raymes Khoury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539729}
Enable oopif printing for isolate origins
Use pdf compositor service for printing when isolate-origins flag
or feature is enabled. Also add a browser test to make sure our
feature will not be broken.
Change-Id: Idbf1f48b1f3ba28b5d6475d625e18f22efece76d
Reviewed-on: https://chromium-review.googlesource.com/940280
Commit-Queue: Wei Li <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539728}
Mark more css-text WPT tests as flaky
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external/wpt/css/css-text/
Bug: 816868
Change-Id: Ie3d6bc7760df163d873d6b5ddd30a41d3ea6f729
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/940702
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539727}
Move screen magnification focus to another display with touch
- Move screen magnification focus to another display with touch event.
- To write a test case, this CL changes EventGenerator.GestureTapAt to
work with multi displays.
Bug: 789476
Test: MagnificationControllerTest.MoveToSecondDisplayWithTouch
Change-Id: I5d7715a817664ded96774d4b04183d83bb633e5b
Reviewed-on: https://chromium-review.googlesource.com/917931
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539726}
chromeos: Add RecentEventsCounter.
RecentEventsCounter is a class to count recent events.
It will be used by the Power Management and Screen Brightness
projects to count the number of mouse and other events in the
last hour.
Bug: 784232
Change-Id: I38ad8065039c4b1bd13e40332e566628ed544cb1
Reviewed-on: https://chromium-review.googlesource.com/934002
Reviewed-by: Jia Meng <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Commit-Queue: Paul Dyson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539725}
Use the shared instance of base::Default{,Tick}Clock in ash/ and ui/
This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.
After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.
Bug: 789079
Change-Id: I20ed19cc13da1b9f078b71e9e39f23b7c5d1b0de
Reviewed-on: https://chromium-review.googlesource.com/936947
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Taiju Tsuiki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539724}
Mark animation-type tests as [Pass Crash Failure]
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=animation-types
Bug: 816534
Change-Id: Ibc56622bda32588099e02c1f4121c380c42787c5
TBR: smcgruer@
Reviewed-on: https://chromium-review.googlesource.com/940825
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539723}
DrawOcclusion: Add metrics on DrawQuad size to understand users better
DrawOcclusion finch trial has been enabled for 1 week now and DrawOcclusion
running time of 99th percentile is 5 times more than 95th percentile. We
believe that this is because the increasing number of drawquads that need
to go through the expensive complex transform. In this patch I added a
new metrics Compositing.Display.Draw.Quads.Area.With.Complex.Transform to
understand better those DrawQuads size.
Bug: 672929
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9ab3e5a29976d8c7f3239c45a43f0fb2895d69a3
Reviewed-on: https://chromium-review.googlesource.com/935683
Commit-Queue: Yi Xu <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539722}
cros: Implement md-style EULA security settings screen
Given the simplicity of this page, it's inlined with the EULA screen.
Based on the mock goo.gl/YegUvx, the screen is no longer a small
overlay as the non-md style, so did not combine the md/non-md together
in the same file like other screens.
Bug: 714169
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifffd4c2d5b47d4b22e6283d6985df2842c83adf6
Reviewed-on: https://chromium-review.googlesource.com/936477
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539721}
Print Preview Componentization: Add highlighting for advanced settings
Bug: 773928, 812092
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6a77a773cc1eecf91b8847c46e83626215d2b0b5
Reviewed-on: https://chromium-review.googlesource.com/927831
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539720}
[CRD iOS] Changing the app initializer interface
Replaced the old +initializeApp interface with +onAppWillLaunch and
+onAppDidLaunch and call them inside AppDelegate, as it's generally not
recommended to put initialization code in main function.
This CL must not be checked in before internal CL:
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/563823
BUG=808757
Change-Id: Ie19e33e64c522a045c895853b867347af876b26e
Reviewed-on: https://chromium-review.googlesource.com/905389
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539719}
Surface synchronization: Fix BrowserPluginGuest surface invariants violations
This CL fixes a few surface invariants violations in BrowserPluginGuest that
were causing flaky tests.
1. We were using ScreenInfo from BrowserPluginGuest to the child renderer before
we've grabbed a LocalSurfaceId from the parent. This results in surface
invariants violations occasionally.
2. There is extension code that races with content code to resize the guest.
This results in surface invariants violations. The solution is to ignore
extension code requests and only resize from content. OOPIF-based
BrowserPluginGuest already does this. Do it for the old code path too.
Bug: 672962, 814040, 791154
TBR: [email protected] (for render_widget_host_view_guest.cc) I used to own that but it moved :(
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib5783dee73ce525004f9e9b06c74a8d703e7157b
Reviewed-on: https://chromium-review.googlesource.com/932964
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539718}
mus+viz: Update mirroring and unified mode todos
[email protected]
Bug: 764472, 806318
Change-Id: Ife275bdd5eb1aed5f0a8d2117d7796e1a3e1e4cd
Reviewed-on: https://chromium-review.googlesource.com/940780
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539717}
Add traffic annotation to QuicChromiumClientSession.
Network traffic annotation is added to:
QuicChromiumClientSession::CreateIncomingDynamicStream.
Bug: 656607
Change-Id: I307300c5ec33197bb7e29a40187234dcf82b7b94
Reviewed-on: https://chromium-review.googlesource.com/934182
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539716}
Add 'no-missing-error' switch to network traffic annotation auditor.
An optional 'no-missing-error' switch is added to Network Traffic
Annotation Auditor.
If provided, auditor would not issue error in cases that an annotation
is missing. This would be useful on platforms that still do not fully
cover annotations and auditor is just run to check existing ones.
Bug: 690323
Change-Id: I5b74d5c86b12c1a85fdeaba7bc71381c6b6451dc
Reviewed-on: https://chromium-review.googlesource.com/930761
Commit-Queue: Ramin Halavati <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539715}
Enable the feature that allows regions to be used as UI language.
The logic was implemented here: crrev.com/c/838726.
We allow the user to choose any regional variation of a locale as their
UI language, but the fallback to the actual locale in every place where
the locale is needed (not in settings).
This feature is visible in ChromeOS and Windows only.
Bug: 390966
Change-Id: I0a5064b896364f437c5cfb537e5892ef32540d50
Reviewed-on: https://chromium-review.googlesource.com/936886
Commit-Queue: Claudio M <[email protected]>
Reviewed-by: Michael Martis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539714}
[ServiceWorker] Use null ServiceWorkerClientInfoPtr for an invalid info
Rather than a non-null ServiceWorkerClientInfoPtr with an empty client
uuid, this CL starts to use a null ServiceWorkerClientInfoPtr to
indicate an invalid client info.
BUG=772793
Change-Id: I753dd87da32053e68eb6dfec104463694312e65b
Reviewed-on: https://chromium-review.googlesource.com/930665
Commit-Queue: Han Leon <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539713}
Roll src/third_party/webrtc/ 9f79a92e2..8cb344acf (26 commits)
https://webrtc.googlesource.com/src.git/+log/9f79a92e2642..8cb344acfdb1
$ git log 9f79a92e2..8cb344acf --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src/third_party/webrtc
BUG=None,None
The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
[email protected]
Change-Id: I46b090243d06b68030d6f5a1452b0d54866065ee
Reviewed-on: https://chromium-review.googlesource.com/940801
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539712}
Mark flexbox-writing-mode tests flaky on all platforms
These tests are flak not only on Linux but also on Mac and Win.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=flexbox-writing-mode&testType=webkit_layout_tests
Bug: 467127
TBR: cbiesinger@
Change-Id: I18d81207a5b8321e5da158dc1819e89211efcb42
Reviewed-on: https://chromium-review.googlesource.com/940821
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539711}
Removed all bot exclusions and modifications for mojo_unittests
Also increased the default timeout for mojo_unittests
to 300 seconds so that overrides are not necessary.
Bug: 813209
Change-Id: Ifdec6a33d3271c38739b976efde319fcca3b9500
Reviewed-on: https://chromium-review.googlesource.com/936050
Commit-Queue: Oksana Zhuravlova <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539710}
Add EV to DigiCert Roots
Enabling EV for 5 out of 7 requested Root CAs. Remaining CAs will be
EV enabled if/when DigiCert fixes their test sites to validate changes.
Bug: crbug.com/791870
Change-Id: I0f1bf50383b2bbcaa7179d0c72ee80530ae7033b
Reviewed-on: https://chromium-review.googlesource.com/939730
Reviewed-by: Ryan Sleevi <[email protected]>
Commit-Queue: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539709}
Add test to check that StylePropertyMap sorts in increasing code-point order
Change-Id: I86933692bff974d3a640cef4ea47b602c88e92a1
Reviewed-on: https://chromium-review.googlesource.com/940723
Reviewed-by: Darren Shen <[email protected]>
Commit-Queue: nainar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539708}
desktop-pwas: Introduce experimental link capturing flag
Currently, link capturing is enabled by the EnableDesktopPWAWindowing
feature, but in the future, it will be disabled unless you also have
this flag turned on.
Bug: 814102
Change-Id: Ia13f48d38d963d8a2b93b327cb9866213390cd19
Reviewed-on: https://chromium-review.googlesource.com/936524
Commit-Queue: Giovanni Ortuño Urquidi <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539707}
Move TabManager UKMs into TabActivityWatcher
This consolidates logging for TabManager.Background.ForegroundedOrClosed
and TabManager.TabLifetime into TabActivityWatcher, which already
handles TabManager.TabMetrics logging.
This corrects several cases where ForegroundedOrClosed is logged
inappropriately and adds some tests for these UKMs.
Bug: 791362,783989
Change-Id: I1f1b15a300df5d1c7cdf54267844f8cfbd31c7e3
Reviewed-on: https://chromium-review.googlesource.com/929009
Commit-Queue: Michael Giuffrida <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539706}
Reland of -g0 for slow android try builder
This is re-land of
https://chromium-review.googlesource.com/c/chromium/src/+/892187
But only focus on android_n5x_swarming_rel builder not to drop debug info in other builder unintentionally.
Bug: 794423
Change-Id: Iaedcefdee04f3f63152c212dcd4a6bc36174b954
Reviewed-on: https://chromium-review.googlesource.com/939207
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539705}
Cookie Store: Remove GetCookiesWithOptionsAsync.
CookieStore::GetCookiesWithOptionsAsync is conceptually a convenience
method on top of CookieStore::GetCookieListWithOptionsAsync, and is only
used in Android-specific code and in tests. CookieStore is a fairly
low-level abstract interface with many implementations, so convenience
methods are fairly expensive. The usage of GetCookieListWithOptionsAsync
is not high enough to be worth its cost.
This CL removes the method, and rewrites the relevant tests to use
GetCookieListWithOptionsAsync, so they cover the code that's actually
used in production. In order to avoid changing Android WebView APIs,
this CL uses CookieStore::BuildCookieLine in conjunction with
CookieStore::GetCookieListWithOptionsAsync.
This approach introduces a potential behavior change in
MediaResourceGetterImpl. Previously, the GetCookies implementation
invoked CookieStore::GetAllCookiesForURLAsync to obtain a
net::CookieList that was passed to ContentBrowserClient::AllowGetCookie,
and then invoked CookieStore::GetCookiesWithOptionsAsync to obtain a
std::string that was passed to the GetCookies' callback. The new
implementation uses CanonicalCookie::BuildCookieLine to convert the
net::CookieList seen by AllowGetCookie to a std::string that is passed
to GetCookies' callback. This means that AllowGetCookie will definitely
operate on the same data that is passed to GetCookies' callback.
Bug: 729800, 588081
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I56c9bfa5e8bf9d6b627d752e5b4962029577d122
Reviewed-on: https://chromium-review.googlesource.com/936790
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Randy Smith <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539704}
Updating trunk VERSION from 3357.0 to 3358.0
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: Ia4cd3355300111e1e4ddeaed0bf784b75eb484d9
Reviewed-on: https://chromium-review.googlesource.com/940682
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539703}
[omnibox] Better checking of passing null TemplateURLService
Many unit tests pass a null TemplateURLService* to the Omnibox
functions. These functions should be able to handle that. This CL
represents a pass through those functions, making sure that they
either handle a null pointer, or DCHECK.
It also includes a few minor fixes found along the way.
Bug: 804470
Change-Id: I2e575121d167b0620cd95881466dbd4d47679ade
Reviewed-on: https://chromium-review.googlesource.com/937394
Commit-Queue: Kevin Bailey <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539702}
Disable PauseForPendingResizeOrRepaints in AutoResize
In RenderWidgetHostImpl::OnResizeOrRepaintACK, we post a task to
base::ThreadTaskRunnerHandle::Get().
During resize, in RenderWidgetHostImpl::PauseForPendingResizeOrRepaints,
we pump a nested run loop on ui::WindowResizeHelperMac::task_runner,
which will not run this message.
This ends up causing the message to be received at an unexpected or
delayed time. Avoid this by disallowing PauseForPendingResizeOrRepaints
for AutoResize.
In principle the task could be posted to the WindowResizeHelperMac task
runner, but it's hard to be certain that that would not introduce bugs.
Bug: 816421
Change-Id: Iaf8bdcc99e4b40d41e2a9590e4436d07c450d403
Reviewed-on: https://chromium-review.googlesource.com/940444
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539701}
[Android Webapps]: Use minimal-UI CCT fallback more often
This CL fixes several bugs:
Bug #1: We currently launch a blank CCT when a user navigates from a page which
is in the WebAPK's scope to a PDF which is outside of the WebAPK's scope.
Bug #2: We currently launch a CCT when a navigation occurs via JavaScript when
the WebAPK is in the background. Launching the CCT causes the WebAPK to
move back to the foreground (and is annoying to the user).
This CL:
- Deletes WebappInterceptNavigationDelegate in favor to moving the logic to
ExternalNavigationHandler. (This enables deleting the POST hack logic in
WebappInterceptNavigationDelegate#shouldOpenInCustomTab()).
- This CL changes the CCT to launch only as result of PageTransition#LINK
BUG=797793
Change-Id: I25cde15b588d9ce5dcac9d4cd107ee9af584465b
Reviewed-on: https://chromium-review.googlesource.com/844956
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Piotr Swigon <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Maria Khomenko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539700}
Revise AudioWorkletNode IDL (AudioWorkletProcessorState, onprocessorerror)
Spec PR: https://github.com/WebAudio/web-audio-api/pull/1509
1. Remove AudioWorkletProcessorState from the implementation.
2. Add `onprocessorerror` to AudioWorkletNode IDL.
3. Modify the existing test for AudioWorkletProcessorState
to test onprocessorerror handler.
Bug: 816542
Test: http/tests/webaudio/audio-worklet/audio-worklet-node-onerror.html
Change-Id: I96280c7dbed5cdf2d608633e4ddb9c94e9b4f6e7
Reviewed-on: https://chromium-review.googlesource.com/937986
Reviewed-by: Raymond Toy <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539699}
[reland] Add allow_reentrancy parameter to ObserverList
Certain client code wants to make sure that no loop is
performed while looping to avoid unexpected behaivor.
Use this new parameter to check this condition in debug build & unit tests.
Introduced ReentrantObserverList (which is currently same as defualt)
to replace the ones that indeed have to be reentrant in a separate CL.
BUG=812109
TEST=Covered by unittests
Reviewed-on: https://chromium-review.googlesource.com/915441
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Wez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537949}
Change-Id: Id4e3d04802f247491b39585219482648733b2563
Reviewed-on: https://chromium-review.googlesource.com/939530
Cr-Commit-Position: refs/heads/master@{#539698}
Update V8 to version 6.6.336.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/687fceb2..e4486f8c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: I72ef83ab972b82d2fadb8932dcd38c3135a2cf03
Reviewed-on: https://chromium-review.googlesource.com/939741
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539697}
Fix tab dragging outside of window with touch events.
Fix a regression in dragging a tab outside of the window. The hit test
that was added to check that we were inside the HT_CLIENT bounds worked
correctly for the profile, min/max buttons but not for items in the tab
strip. The WM_MOUSE compatiblity events need to be dispatched to make
this drag of the tab work.
The hit test was actually added because it solved a problem with the
profile avatar button and the window getting dismissed. The WM_TOUCH path
solves it in a slightly different way incrementing touch_down_contexts
and returns MA_NOACTIVATE if there are any touch down contexts active. Use
this same way with WM_POINTER for touch.
BUG=812508,816391
Change-Id: Iacc874ab164866567e8c0cde14c2a1803f2081e2
Reviewed-on: https://chromium-review.googlesource.com/938221
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539696}
Make the Docked and Fullscreen magnifiers mutually exclusive
This CL implements a quick way to make the two magnifiers
mutually exclusive. The fullscreen magnifier code requires
some involved refactoring that is planned to be done shortly
after.
BUG=709824
TEST=ash_unittests --enable-features=Mus --gtest_filter=DockedMagnifierTest.MutuallyExclusiveMagnifiers
Change-Id: If68662450df9b443e1cbe3d2a66af3409cc3d7bd
Reviewed-on: https://chromium-review.googlesource.com/940635
Commit-Queue: Ahmed Fakhry <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539695}
ARC a11y: audit screen 13 webviews
- Android Chrome exposes name on paragraphs; this doesn't happen on desktop Chrome, so we never needed to look for it. Made the change to the paragraph output rule.
- webView roles gets used by Android Chrome. We programmatically enable the desktop webView node via a mandatory child tree id. Android Chrome has no such attributes as the tree is loaded automatically. Unmap this role to avoid crashing.
Test: navigate screen 13 (webviews) of the TalkBack test apk. Verify no crashes occur and that all elements get described.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icc7ded9c9634ae947312cfe9a6f5ea36908ff530
Reviewed-on: https://chromium-review.googlesource.com/930180
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539694}
Rename traits in //services/device.
This change renames *_struct_traits_* to *_mojom_traits_* in
//services/device.
BUG=806965
Change-Id: Ib80b7c3d8e88408712952bb497ded2551e48539e
Reviewed-on: https://chromium-review.googlesource.com/936434
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Ke He <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539693}
Jumbo: Fix a build error
A build error occurs while building webkit_unit_tests with jumbo build.
It has occured since https://chromium-review.googlesource.com/932121.
Perhaps Jumbo build doesn't seem to distinguish anonymous namespaces.
So, there is name conflicts during merging two tests. Basically, we need
to improve the logic of the jumbo build, but this is breaking build
currently. So, makes the variables have unique names temporarily to
avoid name conflicts.
Bug: none
Change-Id: Ie4a62b80dfe988639333f1a8c9081c06a9f8bc29
Reviewed-on: https://chromium-review.googlesource.com/940641
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539692}
Roll src/third_party/depot_tools/ 9cb8fad0b..d0de9616e (1 commit)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9cb8fad0b349..d0de9616e5bb
$ git log 9cb8fad0b..d0de9616e --date=short --no-merges --format='%ad %ae %s'
2018-02-27 iannucci [cipd] Bump cipd version to ae28364c740acff97ae118adcb2808b6cb5129c5.
Created with:
roll-dep src/third_party/depot_tools
The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I3c39b788773d3602dcf1f24682fa8f3a2f5e326d
Reviewed-on: https://chromium-review.googlesource.com/940664
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539691}
[Blobs] Grow files when creating a blob from stream.
Rather than creating a new file, extend existing files until they reach
their max size when streaming to a blob on disk.
Bug: 754493
Change-Id: Icce67682011c9d0e31fbdc1ef0f180bc46b74b9e
Reviewed-on: https://chromium-review.googlesource.com/938671
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539690}
[Chromecast] Remove unused parameter in metrics client.
The CastService* in CastMetricsServiceClient::Initialize is
unused.
Bug: Internal b/25950068
Test: build cast_shell
Change-Id: I41a28fff3d51f05fb3a5e3752e12bc9adc80b781
Reviewed-on: https://chromium-review.googlesource.com/940539
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: Simeon Anfinrud <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539689}
Allow selecting text in Accessibility pane
Bug: 816965
Change-Id: Ia06f31cc10a5843cb4dd5fb2f93c9e8e6ecf0b57
Reviewed-on: https://chromium-review.googlesource.com/939001
Commit-Queue: Alice Boxhall <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539688}
[Power ML] Log key, mouse and touch events to ukm.
This cl implements the functionality of logging these features to ukm. A later
cl will extract these features.
Bug: 784232
Change-Id: I3017aa218f1df46d24975a35796ce0b3874884f7
Reviewed-on: https://chromium-review.googlesource.com/937145
Commit-Queue: Jia Meng <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539687}
Use FindElementAtPoint inside CRWContextMenuController.
Bug: 228355
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie375b54b3859cd93629b466b0ffd23c788b1d39f
Reviewed-on: https://chromium-review.googlesource.com/918407
Reviewed-by: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539686}
Remove third_party/mt19937ar.
Replace with std::mt19937 from C++11, which is now available
for all builds.
No functional changes, which is verified by existing variations
unit tests.
Bug: 816440
Change-Id: I03437494948283f26b7f2f2b089f3f89440601ba
Reviewed-on: https://chromium-review.googlesource.com/937381
Reviewed-by: Yuri Wiitala <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539685}
Update find bar button's state properly
Find paste board can be updated by current browser or
other browsers/applications.
1. By Current Browser(When suppressPboardUpdateActions_ is true):
We shouldn't en/disable buttons because it will be updated later based
on results. Otherwise, flickering happens(bug 815105).
2. By Others(When suppressPboardUpdateAcitons_ is false):
We should en/disable buttons based on text length, not on result.
prepopulateText() already does this, so revert the previous
patch. Why the bug 739735 happnend before was that we call
clearFindResultsForCurrentBrowser() after prepopulateText().
Therfore swapping their order can resolve the bug.
Bug: 815105, 739735
Change-Id: I85dc12e151fb7087a3bfab1aaf2b5d8acc3ee6b1
Reviewed-on: https://chromium-review.googlesource.com/936943
Commit-Queue: SangWoo Ko <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539684}
Trim Search Engine keywords
This leaves original user input (from chrome://settings/searchEngines)
untouched but effectively fixes a bug in which a user accidentally
leaves a leading space while editing via Chrome's Settings UI and
functionally breaks that search engine (typing \s + keyword doesn't work
as far as I can tell).
Bug: 817132
Change-Id: I7e34927fafc853b056e6a721e7f4e903e3652d4d
Reviewed-on: https://chromium-review.googlesource.com/940454
Commit-Queue: Dan Beam (no longer on Chrome) <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539683}
Remove the concept of cadence overage for video renderering.
In retrospect, this doesn't make a lot of sense. This was originally
added with http://crrev.com/329987 to combat drift in the cadence
sequence, but in practice it just makes things worse AFAICT.
Everything it does seems covered by the reset of the cadence sequence
once the cadence frame is ignored. If implemented correctly it may
take longer to reach the drift reset, but again practically it just
seems to introduce instability to the sequence.
E.g., for 60fps sequences with a cadence of [1] the drift reset was
overrendering a previous frame to reset drift back to 0; but the
overage would then be attached the current frame and cause the
next frame to be skipped, even though it would be a valid choice
next pass.
I've checked a few 24fps, 30fps, and 60fps sequences and all of
them drop less frames and appear smoother without the overage
system, so lets delete it!
BUG=801245
TEST=updated unittests, will watch a/v analysis dashboards.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1a8499e0f4b78210c0acfb6f5f95969d21fc937e
Reviewed-on: https://chromium-review.googlesource.com/940041
Commit-Queue: Dale Curtis <[email protected]>
Reviewed-by: Qiang Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539682}
Fix condition for concurrent link on linux_chromium_rel_ng builder
This is follow up of
https://chromium-review.googlesource.com/938883
This is for increase the number concurrent link on buildbot, does the same thing with below CL.
https://chromium-review.googlesource.com/891043
Bug: 794423
Change-Id: I2272cf8be22235b26f12568ccb6d5f55059538a5
Reviewed-on: https://chromium-review.googlesource.com/938688
Commit-Queue: Takuto Ikuta <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539681}
[Refactor] Centralize methods for converting java.util.List to primitive array
This CL centralizes methods for converting java.util.List to a primitive array
in org.chromium.base.CollectionUtil
Change-Id: I56a4424b76cffdf47b9d21b78cf28ec86831f7c5
Reviewed-on: https://chromium-review.googlesource.com/936608
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539680}
cros: Do not hide the thumbnail in wallpaper attribution
Fixed a regression caused by
https://chromium-review.googlesource.com/c/chromium/src/+/887963
[email protected]
Bug: 816861
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice884ea96f6dcb7ea306f7b513c0631adb089e1a
Reviewed-on: https://chromium-review.googlesource.com/939740
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539679}
protobuf: cherry-pick upstream commit 3ba21cd5f
Bug: 801780
Change-Id: I8d0b9b9cf3b978c8f804f42237b06b866c36d2f4
Reviewed-on: https://chromium-review.googlesource.com/939875
Reviewed-by: Adam Michalik <[email protected]>
Commit-Queue: Peter Collingbourne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539678}
Fuchsia: install binaries and dependencies using package/blob system.
This solution deploys and runs applications using Fuchsia's package
infrastructure. Files are copied into the blobstore as hashed blobs
and executed from a signed and packaged manifest file.
Also:
* Disable Fuchsia layout tests. The Fuchsia deployment script
for layout tests needs to be tweaked before it can run with packages.
* Add an extra verbose '-vv' switch to cut down on 'scp -v' chatter.
* Add a getter to Target to check if the target was freshly booted.
Bug: 798851,778467
Change-Id: Idf061a3b78844bf63b6c8e0c1a01e99db62f3e20
Reviewed-on: https://chromium-review.googlesource.com/935741
Commit-Queue: Kevin Marshall <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539677}
CWVTranslationController unit tests for delegate callbacks.
Follow up CLs to test remaining public API.
Bug: 770983
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5c01436f3c98c8cfb4d46217a9862904508ea80e
Reviewed-on: https://chromium-review.googlesource.com/939993
Commit-Queue: John Wu <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539676}
[CrOS Tether] Ensure that uWeave "connection close" packet is sent.
The "connection close" packet previously was not always sent when
disconnecting. Because GATT connections are stateless, this caused the
remote device to become out of sync because the remote device was not
aware that the connection had been closed out by the Chromebook.
This led to some issues with connections which expected the wrong uWeave
packet counter and rejecting connections.
Bug: 763604, 672263
Change-Id: I5755de9f0b3957ce574277a4f11053eef3267171
Reviewed-on: https://chromium-review.googlesource.com/940279
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Jeremy Klein <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539675}
Reland cc: Ensure correct scaling for non-lazy images in GPU cache.
This reverts commit 4c1f61ac59a284ef92af29b01b4a9c561c33a56d. The test
was using unitialized memory which broke the MSAN bots. This patch fixes
that.
[email protected], [email protected]
Bug: 815045
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3d15d740dceba3a6cc90f3d9374514d403164ab7
Reviewed-on: https://chromium-review.googlesource.com/939539
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539674}
Move Some Functions of EditingUtilities to EditingCommandsUtilities.
Functions IsInline() and DeletionInputTypeFromTextGranularity() are
used by editing commands only. Move them to
EditingCommandsUtilities.{cpp,h} for better code structure.
Bug: 802922
Signed-off-by: Zhuoyu Qian <[email protected]>
Change-Id: Ic9901e53d21d45ad74f2652b365efa68f5de9d92
Reviewed-on: https://chromium-review.googlesource.com/939209
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539673}
Put CSSUnsetValue into the blink::cssvalue namespace.
This is part of the gradual process of putting all types that derive
from CSSValue into blink::cssvalue:: namespace.
Bug: 667961
Signed-off-by: Zhuoyu Qian <[email protected]>
Change-Id: Idbe048f2563c9e47fe5db56fe3e4b27b1a376a4b
Reviewed-on: https://chromium-review.googlesource.com/938884
Reviewed-by: Stuart Langley <[email protected]>
Reviewed-by: nainar <[email protected]>
Commit-Queue: nainar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539672}
[RLS] Rebaseline http/tests/misc/acid3.html
This test just needed a rebaseline to include the following in the
layer tree dump: "scrollWidth 1 scrollHeight 8".
Bug: 417782
Change-Id: Idf3b6ba590a16bd352308e75653e6a448459319f
Reviewed-on: https://chromium-review.googlesource.com/939022
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539671}
[MacViews] Add BiDi to the Textfield Context Menu
Added the Bidirection submenu to the MacViews textfield context menu
Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/923548
This is a reland of https://codereview.chromium.org/2164483006
Bug: 617436
Change-Id: I8de831e72373de6583161df792472eeb29f37a5b
Reviewed-on: https://chromium-review.googlesource.com/929668
Commit-Queue: Sarah Chan <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539670}
[ClipboardHost] Blob creation now has a living storage context
Bug: 798266
Change-Id: If8614217018e1b8689d9f747b80726682586e3b4
Reviewed-on: https://chromium-review.googlesource.com/939720
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539669}
Settings: Network config: refresh properties after configure
After network properties are configured they need to be
refreshed so that the 'Connectable' (and other) properties
are updated.
BUG=814939
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I586e08671ecd77f91c5084f3b726012d9c447c7f
Reviewed-on: https://chromium-review.googlesource.com/938741
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539668}
[PE] Fix EndLayer without BeginLayer in BoxPainter::PaintBoxDecorationBackgroundWithRect()
Not the fix for crbug.com/816812, but fix the DCHECK failure encountered
during reproduction.
Bug: 816812
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I61d36f96bda6abeba3c98e7645072ec544071327
Reviewed-on: https://chromium-review.googlesource.com/939716
Reviewed-by: vmpstr <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539667}
Enable text-only parts of Async Clipboard API by default
Previously, we RuntimeEnable'd the entire |clipboard| object on the
navigator so that the entire feature is disabled.
To launch the text-only APIs, this cl enables the |clipboard|
object, and disables all the non-text APIs.
Launch bug: crbug.com/677565
Launch review approval: https://groups.google.com/a/google.com/forum/#!topic/chrome-launch-review/ux6GtFyICVs
Bug: 677564
Change-Id: Iee7a21f71eacb4521f83afbdb23c22b37b0b5881
Reviewed-on: https://chromium-review.googlesource.com/865516
Commit-Queue: Gary Kacmarcik <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539666}
NQE: Handle cases when signal strength is unavailable
When the signal strength for the current network is unavailable,
return the network quality that's fastest among all
cached values. This ensures that the Network Quality
Estimator (NQE) returns a conservative network quality.
Bug: 816976
Change-Id: Ie97290f0a1af63b38183cfeee60c5012d1046643
Reviewed-on: https://chromium-review.googlesource.com/938574
Reviewed-by: Doug Arnett <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539665}
[SPv175+] GraphicsLayer::SetNeedsCheckRasterInvalidation()
The flag for an GraphicsLayer is set when an object under the
GraphicsLayer
- has changed any paint property;
- may change paint properties relative to the GraphicsLayer (see
https://chromium-review.googlesource.com/920658 which called
SetNeedsRepaint for the non-composited fix-position case).
when the object's layer doesn't need repaint.
Bug: 816382
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16bd6f0f3a8c2bc80005afe5de1cf67d83a28fb9
Reviewed-on: https://chromium-review.googlesource.com/939081
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539664}
Roll src/third_party/libaddressinput/src/ a575c63de..d955c63ec (1 commit)
https://chromium.googlesource.com/external/libaddressinput.git/+log/a575c63de328..d955c63ec704
$ git log a575c63de..d955c63ec --date=short --no-merges --format='%ad %ae %s'
2018-01-17 peter Make size.h compatible with libc++ on Windows. (#153)
Created with:
roll-dep src/third_party/libaddressinput/src
Bug: 801780
Change-Id: I856bb1e9fedb0c2aa1f9cacc8db3a81c055342cb
Reviewed-on: https://chromium-review.googlesource.com/939877
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Peter Collingbourne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539663}
Initial impl of SystemTrayUnified bubble
This CL adds SystemTrayUnified bubble implementation under
(ash/system/unified) that is separate from existing SystemTray
(ash/system/tray).
When we port features from SystemTray, we also move the common logic to
ash/system/model/. See example: https://crrev.com/c/933685
See the design doc for detail. ("Class and directory structure" section)
This CL also implements basic features of top shortcuts view.
Design doc: go/cros-qs-restyling
Screenshot: http://screen/ahFUBnpugS5
BUG=811660
Change-Id: Ia3ba9208f6120ac871014e4ae1f6326b62de551f
Reviewed-on: https://chromium-review.googlesource.com/936945
Commit-Queue: Tetsui Ohkubo <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539662}
cros: Add device end of life message in md about page.
Chrome OS devices receive new feature Stable updates every six weeks,
these updates are for at least five years from the time devices are launched,
after 5 years the new feature updates are no longer guaranteed and devices will
eventually stop receiving updates. At this point, the device will be considered
End of Life.
The about page retrieves the end of life status(supported or end of life) from
update engine and show a message, an end of life icon, as well as an link for
more information: https://www.google.com/chromebook/older/
when status == end of life.
Bug: 809258
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I18568894a88cb8e1aabdf22613f748eb8bfbf8be
Reviewed-on: https://chromium-review.googlesource.com/936448
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Xiaoyin Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539661}
Surface synchronization: Improve guttering
SurfaceManager::GetLatestInFlightSurface enforced overly strict ownership
in order to embed a newer surface. It waited until a surface was assigned
an owner before it deemed it safe to embed that surface at aggregation
time. After a brief discussion with security, it seems like maybe
we don't need a new nonce and we don't need to validate ownership with
every surface creation. Thus, we can avoid waiting for assigning ownership
and can embed a surface at aggregation time as a fallback sooner.
This results in less gutter.
Bug: 672962
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I3bdfd4656ee2ce61e361f7c62539ef049d261382
Reviewed-on: https://chromium-review.googlesource.com/938645
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539660}
Reland "Enable mojo based synchronous compositor"
This is a reland of 69ac9fe8f6eb8340280ec386220ea968e8fbf5bd.
Original change's description:
> Enable mojo based synchronous compositor
>
> Turn off disabling mojo input messages for webview. That will enable
> the mojo input channel and the mojo synchronous compositor input channel.
>
> BUG=722928
>
> Change-Id: I14ae3d3a83405eb9c6a228f7f08171dab3ca86f2
> Reviewed-on: https://chromium-review.googlesource.com/898553
> Commit-Queue: Dave Tapuska <[email protected]>
> Reviewed-by: Bo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539127}
Bug: 722928
Change-Id: Ib74ce93acd0e6ab2cbea7e68883ac00e6a3aad7f
Reviewed-on: https://chromium-review.googlesource.com/939590
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Bo <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539659}
[Perf] Disable skpicture_printer unit test on cros
Refactoring to remove PageTestResults.failures revealed that this unit test
does not and should not pass on ChromeOS. This CL updates the logic to just
outright disable the test on ChromeOS rather than using a flaky assert.
Bug: 816962
Change-Id: Ifa31007f14f4281568a6e74d73513711fee1587e
Reviewed-on: https://chromium-review.googlesource.com/939728
Reviewed-by: Ned Nguyen <[email protected]>
Commit-Queue: Achuith Bhandarkar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539658}
cros: Add padding to sync consent next button
Add a 6px padding consistent with other screens such as EULA and
OOBE welcome.
Bug: 806678
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2ddeaf1b576e484a3ddbf6741d326d8fd88a84dc
Reviewed-on: https://chromium-review.googlesource.com/939718
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539657}
update whatsnew for m66
Bug: 817071
Change-Id: I71afb073c3901bd6a87b92bb2846eee1d79c9d67
Reviewed-on: https://chromium-review.googlesource.com/940183
Commit-Queue: Pavel Feldman <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539656}
Hosted app button name
Follows the pattern used for the Chrome 3-dot app menu.
Bug: 811555
Change-Id: I601a6225a98751657c83dd5d8dcf92b9200fecca
Reviewed-on: https://chromium-review.googlesource.com/920263
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539655}
Roll src/third_party/catapult/ 47ca0db0b..7a160b6bb (3 commits)
https://chromium.googlesource.com/catapult.git/+log/47ca0db0bd96..7a160b6bb44a
$ git log 47ca0db0b..7a160b6bb --date=short --no-merges --format='%ad %ae %s'
2018-02-27 eakuefner Revert "Revert "Reland "[Telemetry] Remove FailureValue from the value system"""
2018-02-27 eakuefner Revert "Reland "[Telemetry] Remove FailureValue from the value system""
2018-02-26 bsheedy Make profile_dir an abspath
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iafee726523763359b4f6076b9dbae2f1a884495e
Reviewed-on: https://chromium-review.googlesource.com/940272
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539654}
gpu: Luminance/alpha emulation for TexStorage
Make legacy, sized, half-float, and float luminance/alpha emulation work
with TexStorage. We noticed that this was broken because LUMINANCE_F16
textures are used with TexStorage for HDR video on Mac when overlays are
disabled. Add tests for legacy luminance/alpha formats since those are
easy to test.
R=zmo,piman
TEST=TextureStorageTest.LuminanceAlphaEmulation
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iae9cefd772536cc6dc419f226634ae07429d265b
Bug: 810591
Reviewed-on: https://chromium-review.googlesource.com/921401
Reviewed-by: Zhenyao Mo <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539653}
Roll src/third_party/depot_tools/ 53a629116..9cb8fad0b (1 commit)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53a62911658d..9cb8fad0b349
$ git log 53a629116..9cb8fad0b --date=short --no-merges --format='%ad %ae %s'
2018-02-27 jchinlee Update windows git to 2.16.2
Created with:
roll-dep src/third_party/depot_tools
The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I8a397993a9c025452a14507d3d92a9970da28f4d
Reviewed-on: https://chromium-review.googlesource.com/940340
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539652}
Omnibox UI Experiments: Fix steady state elision for long URLs
Previously unapplying the steady state elisions would scroll the
Omnibox to the end of the full URL. This was noticable for long URLs.
This CL fixes that.
Bug: 797354
Change-Id: I0a5e72d6d989fedeb97f6bef695465db9228fdcb
Reviewed-on: https://chromium-review.googlesource.com/939880
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539651}
Revert "Mark quic sessions as going away instead of close connections on SSL config change."
This reverts commit 505dc9c876d8feed6393d25008e0b4270cc666f7.
Reason for revert: reverted as this is suspected to be a potential cause
of Quic Internal Error spike. Will reland if this is not the cause.
Original change's description:
> Mark quic sessions as going away instead of close connections on SSL config change.
>
> Bug: 650509
> Change-Id: Ie5bb461a6094a33c50605a4735675b6552738b65
> Reviewed-on: https://chromium-review.googlesource.com/898502
> Reviewed-by: Ryan Hamilton <[email protected]>
> Reviewed-by: Nick Harper <[email protected]>
> Commit-Queue: Zhongyi Shi <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#535932}
[email protected],[email protected],[email protected]
Bug: 650509
Change-Id: I3dd3c2ac52aa8bb244660f6b2e9ac9de971e1a23
Reviewed-on: https://chromium-review.googlesource.com/939654
Commit-Queue: Zhongyi Shi <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Reviewed-by: Zhongyi Shi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539650}
[iOS] add further TabSwitcher support to TabGrid.
This CL makes all the implementation of the TabSwitcher protocol in TabGridAdaptor complete,
providing non-stub methods where required.
This includes:
- Adding a dispatcher to the TabGridCoordinator, matching how this is handled in the existing
tab switcher implementations. For now the BrowserCommands methods handled in the coordinator
are stubs.
- Adding code in the adaptor to create and open a new tab. The code paths for this from
MainController are from external events, generally (see testing note below).
- Adding code in the coordinator's ViewControllerPresengting method to call the TabSwitcher's
delegate method when the presentation of a tab completes.
I also cleaned up pragma comments in MainController (grouping all of the TabSwitcherDelegate
methods before the helpers) and corrected a method name in a comment in tab_switcher.h
I tested manually in simulator by launching Chrome (with the tab grid flag enabled), entering the
tab grid, then backgrounding Chrome. Then I 3D-touched the Chrome icon to get the various quick
action options, and tested each of them (they all open tabs using this code path).
My expectation is that that unit and egtests will (still) not pass with the tab grid flag enabled.
Fixes for that will follow in another CL (that's probably where the BrowserCommand methods will
get filled in).
Bug: 804533
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3427075225ab10c33aaa13d3f3e01c033e30cd12
Reviewed-on: https://chromium-review.googlesource.com/940195
Commit-Queue: Mark Cogan <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539649}
Revert "Enable Speedometer2-future on Linux and Windows"
This reverts commit 3b9005303e48fe88951a0c567d61199f37de8af0.
Reason for revert: still timeout (crbug.com/816913)
Original change's description:
> Enable Speedometer2-future on Linux and Windows
>
> R=[email protected]
>
> Bug: 792495, 784025
> Change-Id: I05345c81f31b30418eb0bf76da1e2c52f0dc0f54
> Reviewed-on: https://chromium-review.googlesource.com/937519
> Reviewed-by: Ned Nguyen <[email protected]>
> Commit-Queue: Michael Hablich <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539414}
[email protected],[email protected]
Change-Id: Iebde8e94b22c1df80871ffcb00f46b444a0a7e86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792495, 784025
Reviewed-on: https://chromium-review.googlesource.com/940362
Reviewed-by: Ned Nguyen <[email protected]>
Commit-Queue: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539648}
Roll src/third_party/angle/ 360098d5c..640fa5dc3 (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/360098d5c29f..640fa5dc3f95
$ git log 360098d5c..640fa5dc3 --date=short --no-merges --format='%ad %ae %s'
2018-02-22 fjhenigman Enable more of AttributeLayoutTest.
Created with:
roll-dep src/third_party/angle
The AutoRoll server is located here: https://angle-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I15d0a1a0e8c7050d2a71cc778913f96444049a17
Reviewed-on: https://chromium-review.googlesource.com/940565
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539647}
[Payments] Get top level web_contents through render frame host
Bug: 812297
Change-Id: If80bd0068a77fa973f7f0966429b54f31931dbb7
Reviewed-on: https://chromium-review.googlesource.com/939872
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539646}
cros: Update icons and paddings for UX specs of KSV.
This cl updates some icons, font size and paddings for Keyboard Shortcut
Viewer (KSV).
Bug: 768932
Test: Tested on device.
Change-Id: I2b9d7a5af23df55efadc082bd6f316395f3bf37f
Reviewed-on: https://chromium-review.googlesource.com/937906
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539645}
cros: Use is_ephemeral in WallpaperController for consistency
Purely renaming.
[email protected]
Bug: NONE
Change-Id: I43e738d58f3dc380a6bf303b072f87af35d374b7
Reviewed-on: https://chromium-review.googlesource.com/935482
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539644}
GetHelp M66 Release Cut
The scope is added for the eve email opt-in feature.
Bug: 779641
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1387801b1a7d725eea7d98148cae4dabaee681de
Reviewed-on: https://chromium-review.googlesource.com/924450
Reviewed-by: Xiaoyin Hu <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Xiaoyin Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539643}
[Android Webapp] Rename WebappDataStorage methods to clarify time unit
This CL renames:
WebappDataStorage#getLastUsedTime() -> WebappDataStorage#getLastUsedTimeMs()
WebappDataStorage#getLastCheckForWebManifestUpdateTime() ->
WebappDataStorage#getLastCheckForWebManifestUpdateTimeMs()
WebappDataStorage#getLastWebApkUpdateRequestCompletionTime() ->
WebappDataStorage#getLastWebApkUpdateRequestCompletionTimeMs()
BUG=815282
R=dominickn
TBR=yfriedman
Change-Id: Ide507c83c0fff504a09273827342a072088cd523
Reviewed-on: https://chromium-review.googlesource.com/938592
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Peter Kotwicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539642}
Add DevTools message for Symantec certs that have been distrusted
We already have logging for certs that are slated to be distrusted in a future
release. But we should also have a log message for certs that already have been
distrusted, to aid site owners in debugging. This CL adds logging for resources
that failed to load due to a legacy Symantec cert.
Note: this doesn't yet cover iframes, that'll have to be done separately.
Bug: 815219
Change-Id: I24a51011ef8d92668c184ec8fbd2e89969497b71
Reviewed-on: https://chromium-review.googlesource.com/938973
Commit-Queue: Emily Stark <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539641}
Remove Site Settings from the hosted app menu
The Site Settings menu item is redundant now that App Info opens Page Info.
Screenshot:
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325940&signed_aid=mKxJj9vpE0mIciuf3E9g_w==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325941&signed_aid=oCB4Kp8aUnFYrOcoHCPGSg==&inline=1
Bug: 811178
Change-Id: Iacadd269f5152f42b7f6d0a6afb25c20b9329e26
Reviewed-on: https://chromium-review.googlesource.com/930442
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539640}
Surface synchronization: Don't evict surface on DelegatedFrameHost::WasResized
If we evict a surface before the previous CompositorFrame activates with it
as a fallback, then we will attempt to add an invalid reference and we may
end up with missing surfaces in surface aggregator. This CL combats the issue
by avoiding evicting frames during resize.
We will still only update the primary surface ID if the tab is not hidden,
and we will clear the fallback surface ID if the tab is hidden.
Bug: 813157, 672962
Change-Id: Ie0b408af503ec9fefdcccc5fb0607cf015734052
Reviewed-on: https://chromium-review.googlesource.com/938678
Reviewed-by: Saman Sami <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539639}
Add --disable-audio-output switch for disabling audio browser side.
This ensures we still exercise the majority of the audio output path
(good for testing) but replace the actual OS level stream with a
fake stream at the last moment.
The goal here is to try setting this for macOS layout tests to see
if it reduces the run time due to hanging OS calls.
BUG=811525
TEST=manual
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id3b95125696a96ef8d14468f1a97dedf9cdf77b4
Reviewed-on: https://chromium-review.googlesource.com/938152
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539638}
Add Talkback-enabled options for re-ordering language settings.
Add move* options for each language item in a11y mode to help these
users move languages easily.
Tested in both normal mode and accessibility mode.
Bug: 814983
Change-Id: Idb65d6dab6502be1b4e2bbc270b345282505ee5e
Reviewed-on: https://chromium-review.googlesource.com/938874
Commit-Queue: Leo Zhang <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539637}
Add docked magnifier to the chrome://settings/manageAccessibility page.
Makes docked magnifier and fullscreen magnifier mutually exclusive
on the a11y settings page.
Bug: 709824
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7051f73c6ce7f5a416a5b729ac5d075651da2e0f
Reviewed-on: https://chromium-review.googlesource.com/934973
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539636}
[CRD iOS] Collecting in-session data for telemetry and feedback
This CL makes the iOS app track these fields for telemetry:
* Connection type
* Previous session state
It also makes ChromotingSession export a FeedbackData from current
telemetry data, to be attached to the feedback report.
Bug: 814863
Change-Id: Iab32eb5da6748a0e3b7f6d251fa2d7c926c01392
Reviewed-on: https://chromium-review.googlesource.com/939102
Commit-Queue: Yuwei Huang <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539635}
[remoting host] Restart ICE negotiation
This restarts ICE channel negotiation if the P2P session becomes
disconnected.
Change-Id: Ie8db318f714a70d924335f6b320c687805ce1129
Reviewed-on: https://chromium-review.googlesource.com/927619
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539634}
Add closing animation for inline settings.
The inline settings should have not only an opening animation but also a
closing animation in order to make it look like ARC ones. This CL adds
the closing animation.
The closing animation is also a ripple circle animation, but drawn
backwards. The inline settings have a gray background. When a gear icon
or "DONE" button is clicked, the gray background shrinks, changes into a
gray circle, gets smaller and smaller, and disappears at the point of
the gear icon.
BUG=813698
Change-Id: Ief41923a549e3c4cd66d9ed04ba94ee024f27086
Reviewed-on: https://chromium-review.googlesource.com/925927
Commit-Queue: Megumi Hattori <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539633}
Fix construction of SynchronousCompositorProxyRegistry
Fix incorrect construction of the registry object because the variable
that was being used was always null because it was used after a
std::move. Use the member variable instead.
BUG=722928
Change-Id: Ibd6b078184ec279c0d52369656e853c8e9055ebf
Reviewed-on: https://chromium-review.googlesource.com/939726
Reviewed-by: Mustaq Ahmed <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539632}
Add new Cronet headers to CronetChromeWebView framework.
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0b7d563447f6b801cd468cc7f9932303175efe75
Reviewed-on: https://chromium-review.googlesource.com/939321
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Hiroshi Ichikawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539631}
Add oopif-cookies-refresh.js to TestExpectations
Bug: 817167
TBR: phulce@
Change-Id: I96875c75544ca0f554e2fd4c295393ea1828e239
Reviewed-on: https://chromium-review.googlesource.com/940642
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539630}
[CrOS Tether] Stop scans when device is locked.
This prevents potentially bad interactions with EasyUnlock.
Bug: 763604, 672263
Change-Id: I3665a21d1c9ee96f74599e6592990f569b84d548
Reviewed-on: https://chromium-review.googlesource.com/940609
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539629}
service worker: Rename the URLLoader classes for consistency/accuracy.
ServiceWorkerURLLoaderJob -> ServiceWorkerNavigationLoader
ServiceWorkerSubresourceLoader -> ServiceWorkerSubresourceLoader
ServiceWorkerScriptURLLoader -> ServiceWorkerNewScriptLoader
ServiceWorkerInstalledScriptLoader -> ServiceWorkerInstalledScriptLoader
This change is largely mechanical but some documentation is modified
and some additional renames are made.
Bug: 816935
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia89dd1499cde4931c91e8c169ad594ebb19c5980
Reviewed-on: https://chromium-review.googlesource.com/939323
Commit-Queue: Kinuko Yasuda <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539628}
[RLS] Rebaseline 2 mac paint/invalidation/forms tests
The following tests are passing and just needed a mac-specific baseline:
paint/invalidation/forms/checkbox-focus-by-mouse-then-keydown.html
paint/invalidation/forms/radio-focus-by-mouse-then-keydown.html
Bug: 417782
Change-Id: I8c3f1d8875db5023b3145c9951c1a0691eab0419
Reviewed-on: https://chromium-review.googlesource.com/939534
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539627}
Add OnNotificationStateChanged call
- Previously notification is created by mojo event, and removed by
surface removal via wayland. Using different channels for creation and
removal can cause complicated situations.
- Add OnNotificationStateChanged call to simplify it.
Bug: 775841
Test: unit_tests:ArcAccessibilityHelperBridgeTest
Change-Id: Id3bcf74e05df604448b3578f0a9aef06a5fb3ef9
Reviewed-on: https://chromium-review.googlesource.com/844052
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539626}
Remove WebClient::GetAcceptLangs which is no longer used with WKWebView.
This API was used when ios/web relied on Chrome network stack for web
browsing.
Bug: 579697
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9bac10fcf9700cd33708c9b877898271de179727
Reviewed-on: https://chromium-review.googlesource.com/935294
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539625}
Remove some lingering references to ProxyResolutionService::ReconsiderProxyAfterError().
Which no longer exists.
Also fixes a discrepency in two tests where the comment did not match the behavior -- changed the behavior to match the comment.
Bug: 811910
Change-Id: I6a2aa8a24e23328525dcf8fb71e10d7ff32e196d
Reviewed-on: https://chromium-review.googlesource.com/939738
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Helen Li <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539624}
Introduce HammerdClient - a client for hammerd dbus service
BUG=796300,796342
Change-Id: I067155c431cdde40928e03cb9d0be94bb1fc73fd
Reviewed-on: https://chromium-review.googlesource.com/922267
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539623}
[DBG] Add a speculative CHECK to debug a crash.
This patch adds a speculative CHECK to ensure that when we create a
context during a PrePaintWalk, we have the parent source context to use.
[email protected]
Bug: 816810
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3b91a38402d6dbee669ea0220547c743cd06ee5c
Reviewed-on: https://chromium-review.googlesource.com/940326
Reviewed-by: Philip Rogers (OOO) <[email protected]>
Commit-Queue: vmpstr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539622}
[CI] Use LayoutObject::HasClip instead of checking for non-auto clip
This patch is a followup to [1] and updates all 1 callsites to use
LayoutObject::HasClip instead of !Style()->HasAutoClip(). A comment has
been added in LayoutObject::HasClip about why this is preferred.
One unit test, CanPaintBackgroundOntoScrollingContentsLayer, needed to
be updated because it had css clip without position so the css clip did
not actually apply. This test has been updated to have position, and the
formatting of the test has been cleaned up.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/936055
Bug: 581441
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4ca672f23bda782720787d08f023fce95d5dad9b
Reviewed-on: https://chromium-review.googlesource.com/939586
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539621}
Make fast/dom/Window/window-focus-self.html flaky on Mac
There are several patches failed on this test, but succeeded in retry.
https://chromium-review.googlesource.com/c/chromium/src/+/934481/5
https://chromium-review.googlesource.com/c/chromium/src/+/938847/1
https://chromium-review.googlesource.com/c/chromium/src/+/923767/16
https://chromium-review.googlesource.com/c/chromium/src/+/929664/4
Bug: 816766
Change-Id: I943c3443d98921ecbf886af5c4075b97fa961a91
Reviewed-on: https://chromium-review.googlesource.com/940501
Reviewed-by: Timothy Loh <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539620}
Add StateAtCancel UMA for downloads and offline pages
The histogram OfflineItems.StateAtCancel records the state of a request
at a user-initiated cancel. The name "OfflineItems" is used because the
metric is relevant to both downloads and offline pages. The histogram is
further broken down into two suffix histograms: Downloads and
OfflinePages.
The request state will be stored in the Intent associated with the
cancel button of notifications and Downloads Home. This ensures that the
cancel was user-initiated.
Bug: 796324
Change-Id: I9405ec90f62f00f8f532c973426ab094ee1e1e5d
Reviewed-on: https://chromium-review.googlesource.com/935969
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Reviewed-by: Joy Ming <[email protected]>
Commit-Queue: Candice Sy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539619}
Add EG tests for New Download Manager UI.
This CL adds only one test for a sucessfull download flow. Other tests
will be added in separate CLs.
Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I81a37ab02b1c5c2f4551477810e9e3f61575952f
Reviewed-on: https://chromium-review.googlesource.com/939041
Commit-Queue: Eugene But <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539618}
Mash: Enable WallpapaerPrivateApiTest
The test passes after wallpaper refactoring is completed.
Bug: 792641
Change-Id: I13939dcf69c3317b53d5338906bd277a2222aba3
Reviewed-on: https://chromium-review.googlesource.com/917436
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539617}
[CrOS MultiDevice] Set up //chromeos/components/multidevice_setup.
This CL adds BUILD/OWNERS/DEPS files as well as creating a watchlist
for MultiDevice CLs. This CL does not add any actual implementation.
Change-Id: I2010e42dc595bfbf5a763c1cb90d05005237e1a4
Reviewed-on: https://chromium-review.googlesource.com/938744
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539616}
Simplify Win GPU histogram code a little bit.
So we don't have to update this code everytime we support a new Windows version.
BUG=808119
TEST=bots
[email protected]
Change-Id: I1ab720387584027303b87a96d2c5350204603f5e
Reviewed-on: https://chromium-review.googlesource.com/924523
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539615}
Handle null isIncognito in HistoryManger#openUrl
https://chromium-review.googlesource.com/c/chromium/src/+/935263
failed to take into account the fact that isIncognito can be null at
times. Whoops.
Bug: 817032
Change-Id: If050d39445de2ecaaf54c407f13d72347ef6283a
Reviewed-on: https://chromium-review.googlesource.com/940101
Reviewed-by: Maria Khomenko <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539614}
[Perf] Disable another skpicture_printer unit test on Chrome OS
Found another one of these; should be the last one.
TBR=nednguyen
Bug: 816962
Change-Id: Ib6f771027e58724673e0d4aa4b7e06a97d921748
Reviewed-on: https://chromium-review.googlesource.com/940263
Reviewed-by: Ethan Kuefner <[email protected]>
Commit-Queue: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539613}
[LayoutNG] Implement PositionForPoint() for normal block flows and inlines
This patch implements NG versions (or, InlineBox-free versions) of
PositionForPoint() of LayoutBlockFlow, LayoutInline and LayoutText, so that
we can obtain a DOM position when hit testing in normal block flows and
inline layout in NG.
Note that this patch doesn't handle bidirectional text.
See design doc for details: https://goo.gl/Pf5zVB
Bug: 811502
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6d63d066881c286644304532ba7c9246ad461a6d
Reviewed-on: https://chromium-review.googlesource.com/915052
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539612}
Allow multiple SpdySessions to alias an IP address, not just one.
There can be multiple SpdySessions to the same IP address (e.g.
when they have differing privacy modes or socket tags). When
trying to reuse SpdySessions check them all, rather than just
one. This is more important with socket tagging because there
can be more aliases.
Bug: 520198
Change-Id: Ied88ec2a7799b79142775192dfe13ddd2fb98ded
Reviewed-on: https://chromium-review.googlesource.com/939421
Commit-Queue: Paul Jensen <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539611}
[ios] TabGridViewController improvements
This CL refines the TabGridViewController to include the scroll view,
incognito tabs, regular tabs, placeholder for remote tabs, top toolbar,
bottom toolbar, the floating action button. Protocols are used to
expose delegates, image data sources, and consumers to the outside
world.
Bug: 804496, 804499, 804497
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3bc3e6b391f50a183b6b4e8103a32dbc0ee34ec1
Reviewed-on: https://chromium-review.googlesource.com/936041
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: edchin <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539610}
Fix AssertNoURLRequests crash in system request context.
This issue was caused by calling AssertNoURLRequests on the
SystemRequestContext before the NetworkContext (Which may own
URLLoaders) was torn down. Since the NetworkContext also owns the
SystemRequestContext, the solution was just to remove the
AssertNoURLRequests call. URLRequestContextBuilder's URLRequestContext
implementation calls it, anyways.
This CL also moves NetworkQualityEstimator above the NetworkContext,
so it will be destroyed after the NetworkContext, which is needed if
there are live requests during NetworkContext teardown.
Bug: 816572
Change-Id: Ief3ca156d8c5edc8205bba7aaa22a24ec4fdb066
Reviewed-on: https://chromium-review.googlesource.com/939742
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Randy Smith <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539609}
Change modern media controls to dark scrim with white controls
This CL modifies the modern media controls CSS to use a dark scrim and
white controls for videos (besides ones with audio-only track).
Bug: 776770
Change-Id: Ib07c6f53e50991698f0087a86d7b6fc97346c151
Reviewed-on: https://chromium-review.googlesource.com/929995
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539608}
Sync metrics protos from upstream.
Change-Id: I00466d59930d6cf0a55e733e96b3bf241b181255
Reviewed-on: https://chromium-review.googlesource.com/938971
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539607}
macOS V2 Sandbox: Allow launchservicesd in GPU process.
This resolves a hang in the GPU process by allowing launchservicesd
access in the V2 sandbox. The hang occurs because SkyLight performs
synchronous IPC to launchservicesd, which the sandbox blocks.
Bug: 812228
Change-Id: I871f05f081dc24f26c848492f91c1d4244bafc1d
Reviewed-on: https://chromium-review.googlesource.com/939858
Commit-Queue: Greg Kerr <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539606}
[Win] Avoid overwriting axis elements for HID gamepads
The button and axis count for HID gamepads is determined by querying
the device for its input report descriptor and then iterating through
it to find elements with usage pages and usage numbers that are
appropriate for gamepad buttons and axes.
In some cases, this heuristic incorrectly includes inputs from other
usage pages that happen to have usage numbers that make them look like
axes. In general this is acceptable and these fake axes will be ignored
when the inputs are mapped to the standard gamepad. However, if the fake
axis has the same usage number as an already-discovered axis, it will
overwrite that axis and render it unusable.
To fix this, the HID report descriptor logic will prefer the first axis
it finds with a given usage number and ignore the rest.
BUG=814504
Change-Id: I2369849ebee825760c954b948c3a650f42478bee
Reviewed-on: https://chromium-review.googlesource.com/935622
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Matt Reynolds <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539605}
Roll src/third_party/pdfium/ 821c7236c..53f555a61 (1 commit)
https://pdfium.googlesource.com/pdfium.git/+log/821c7236cea9..53f555a619bf
$ git log 821c7236c..53f555a61 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 rharrison Move XFA pixel tests under pixel/
Created with:
roll-dep src/third_party/pdfium
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ie20b566e038883319f7e38dc1f255f88571dfcd9
Reviewed-on: https://chromium-review.googlesource.com/940266
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539604}
Fix gn_args enable_archive_compression -> skip_archive_compression
I used wrong config flag name in https://chromium-review.googlesource.com/936344
skip_archive_compression is the flag I need to set.
https://chromium-review.googlesource.com/901402
Bug: 808910
Change-Id: I01118ee9081dddfec6d802c860e41434682afcb2
Reviewed-on: https://chromium-review.googlesource.com/939181
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539603}
Fix some declarative net request test expectations with Network Service
Because the WebRequest API stack doesn't see network requests at all
when no listeners are installed and the Network Service is enabled, this
adjusts a few test expectations which are invalid in the Network Service
path.
Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I52c830c1d8604beee5bff591351cca3fbe0765c3
Reviewed-on: https://chromium-review.googlesource.com/940445
Reviewed-by: Karan Bhatia <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539602}
Add GPU workaround for eglClientWaitSyncKHR timeout on S8
Samsung's implementation of the Adreno 540 driver on Android N as used
on the S8/S8+ has a bug where eglClientWaitSyncKHR with a nonzero
timeout waits much longer than the specified timeout. This is fixed
in the Android O update for these devices.
Workaround is to replace the timeout with polling for completion.
Since we don't know if we need the workaround until the GPU process
initialization completes, add a OnGpuConnectionReady callback
in VrShellGl to check for this.
This bug is specific to Samsung S8/S8+ on Android N, but there isn't
currently a way to restrict the filter to those devices. The
functionality is currently only used for WebVR on Daydream ready
devices, and the non-Samsung Daydream devices generally use Android O,
so an overbroad match seems acceptable.
BUG=760389
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I72b92d529307fe114d850eea576fd41fe0fcb645
Reviewed-on: https://chromium-review.googlesource.com/939724
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Commit-Queue: Klaus Weidner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539601}
[Chromecast] Point fuchsia to correct dependency
BUG=NONE
TEST=CQ
Change-Id: Icf72f2bf44b3078ac92e201a3cc02cb1c9074059
Reviewed-on: https://chromium-review.googlesource.com/940533
Commit-Queue: Mina Almasry <[email protected]>
Reviewed-by: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539600}
[ChromeDriver] Disable testCanClickOOPIF on Windows
Python test ChromeDriverSiteIsolation.testCanClickOOPIF appears to
be flaky on Windows. Disabling it until we can find the cause.
[email protected]
Change-Id: I433ebb2ce23b06a5ac27df97b91b925856e2c0bd
Reviewed-on: https://chromium-review.googlesource.com/940329
Reviewed-by: John Chen <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539599}
Add Windows Release CI builders to the scheduler
Adds the compile builder, and the tester.
Bug: 790710, 790644
Change-Id: I31c2e9a3be1b210fdf59e4f38810b24741ca64e4
Reviewed-on: https://chromium-review.googlesource.com/940425
Reviewed-by: Andrii Shyshkalov <[email protected]>
Reviewed-by: Vadim Shtayura <[email protected]>
Commit-Queue: Stephen Martinis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539598}
Change VirtualMachinesAllowed managed default.
Change the default to True for managed devices for now. This will enable
dogfood while the policy is in the process of being rolled out. The
feature can still be turned off by using the enterprise policy once
policy is rolled out in the backend.
BUG=chromium:800120
TEST=manually tested with YAPS.
Change-Id: I441c77f896d185aefd7eeaf3b7ed89fd19b99a7d
Reviewed-on: https://chromium-review.googlesource.com/940182
Reviewed-by: Dan Erat <[email protected]>
Reviewed-by: Mike Frysinger <[email protected]>
Commit-Queue: Tim Zheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539597}
Make all the third-party conflicts code GOOGLE_CHROME_BUILD only
To avoid a mess of #if defined(GOOGLE_CHROME_BUILD), everything
related to the third-party conflits feature was moved from the
ModuleDatabase class to a new ThirdPartyConflictsManager class
owned by ModuleDatabase.
Also removed the ModuleListManager that is no longer needed.
Bug: 717696
Change-Id: Ie3f868c3afc81f98c1078200c8ae0716f5e6d0f8
Reviewed-on: https://chromium-review.googlesource.com/935158
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539596}
[Blobs] Handle length_hint when creating a blob from stream.
Pre-allocate enough space for length_hint bytes when starting to create
a blob from a stream. Also don't allocate more space until we're sure
the data pipe is going to send more data.
Bug: 754493
Change-Id: I6a7c888f6fd0687ec976aa8c54b469e8454c7f02
Reviewed-on: https://chromium-review.googlesource.com/938285
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539595}
[css-typed-om] Implement shorthands for .get/.getAll/.has.
This patch implements shorthands for stylemap.get/getAll/has. Shorthands
are implemented as a base CSSStyleValue. They are different to other
properties because they cannot be converted to a single CSSValue.
Instead, we need to store the CSSValues of their longhands so that
they can be set again on the same property.
Patches to come:
- styleMap.set/update
- Serialization of these values.
Bug: 816722
Change-Id: Ia2c3f694809c219566b965ebfae40bc38d74f4c5
Reviewed-on: https://chromium-review.googlesource.com/938881
Reviewed-by: nainar <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539594}
s/vebStateIsVisible/webStateIsVisible (fixed typo).
Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3b759e02b5fa65dbdee517224e1a915e266d083c
Reviewed-on: https://chromium-review.googlesource.com/939541
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539593}
Add back allowing SetNeedsBeginFrame during swapped out state.
The id was erroneously removed in crrev.com/530723 because it was
thought that since this ID wasn't generated from the main thread in the
renderer (where CanSendWhileSwappedOut is called) it wasn't necessarily.
The browser does call this function as well inside the
CanHandleWhileSwappedOut function so SetNeedsBeginFrame messages
were dropped instead of being handled when a renderer was swapped out
which was incorrect.
BUG=806743
Change-Id: Iebde7e2ff227c582f42a6c10d70d8672a12bda7b
Reviewed-on: https://chromium-review.googlesource.com/939985
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539592}
[Chromecast] Rename MediaPipelineBackendAudio
To MediaPipelineBackendForMixer. This component will no longer be audio
devices specific, but will be used by all devices that use stream_mixer.
Rename it accordingly.
BUG= internal 73746352
Depends-On: eureka-internal/150487
TEST=Build
Change-Id: I2eaeccff32433c966b40e0ee159411899240527b
Reviewed-on: https://chromium-review.googlesource.com/938967
Reviewed-by: Kenneth MacKay <[email protected]>
Commit-Queue: Mina Almasry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539591}
Revert "Disable BrowserFocusTest.FindFocusTest on Chrome OS"
This reverts commit 41d56f974752011f030c5b2f63be331df960bad0.
Reason for revert:
It only failed with a cq trybot patch applied, see http://crbug.com/816643
Original change's description:
> Disable BrowserFocusTest.FindFocusTest on Chrome OS
>
> Bug:816645
> Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9
>
> [email protected]
>
> Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9
> Reviewed-on: https://chromium-review.googlesource.com/938387
> Commit-Queue: Mohammad Reza Zakerinasab <[email protected]>
> Reviewed-by: Mohammad Reza Zakerinasab <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539279}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 816645
Change-Id: Ic584d4c7f423d8c1b9f0a5887bfabca4908cabe6
Reviewed-on: https://chromium-review.googlesource.com/940162
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539590}
Grab a crash dump when supposedly-reaped renderers WAIT_TIMEOUT.
Bug: 806661
Change-Id: I21d25010337b96898a5f9e07ad60e2957a58b682
Reviewed-on: https://chromium-review.googlesource.com/911600
Reviewed-by: Cait Phillips <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Sigurður Ásgeirsson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539589}
Revert "webauthn: support the appid extension."
This reverts commit 831be59aae45ff279e0eac88f736be2c2b033a2f.
Change-Id: Ief52cac2ae1f133b2c9db3e35a0c887b5a2bd02f
Reviewed-on: https://chromium-review.googlesource.com/939657
Reviewed-by: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539588}
[CrOS Tether] Trigger a host scan after device is unlocked.
This CL originally landed as:
https://chromium-review.googlesource.com/c/chromium/src/+/935476
However, it was reverted as:
https://chromium-review.googlesource.com/c/chromium/src/+/936061
The reason for revert was simply that it depended on another patch
which had been deleted (i.e., nothing was wrong with this patch).
Original CL description:
When combined with
https://chromium-review.googlesource.com/c/chromium/src/+/929867, this
CL will cause a notification to appear when unlocking a device if a
Tether host is nearby and the device is not connected to the Internet.
Bug: 813838, 672263
Change-Id: I6746203c2e8fae1f5b66e97c4c54efa0613dcf5d
Reviewed-on: https://chromium-review.googlesource.com/940322
Commit-Queue: Kyle Horimoto <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539587}
Remove Chrome Home app menu icon row footer
BUG=814528
Change-Id: Iffb128825b87b238d7e1d4ae7d49b40d2a2bb2ae
Reviewed-on: https://chromium-review.googlesource.com/939531
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539586}
Added a base::Feature command line flag for specifying a bounded ERL setup
This CL adds a command line switch based on base::Feature to allow the
user to explicitly specify when the setup used is such that the echo
path loss (ERL) is finite.
Bug: chromium:816745
Change-Id: Ib64d699c01a85c1251df132b329d00927d5fa72d
Reviewed-on: https://chromium-review.googlesource.com/938922
Commit-Queue: Per Åhgren <[email protected]>
Reviewed-by: Nick Carter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539585}
webauthn: support the appid extension.
This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.
The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.
I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.
[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] https://github.com/w3c/webauthn/issues/803
Bug: none
Change-Id: I22819adda99fbef9f10d38e797d08691dab7545d
Reviewed-on: https://chromium-review.googlesource.com/920659
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539584}
content: Remove "OnDidStopLoading was called twice." warning
Remove a LOG(WARNING) call from OnDidStopLoading in
render_frame_host_impl.cc. This is logged during normal use
on Chrome OS and clutters log files, and the responsible
code is currently being refactored.
Bug: 466089
Change-Id: Ife3c839d9126d78ddcbd46ec4b5aae86f1f9cd5a
Reviewed-on: https://chromium-review.googlesource.com/939583
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Dan Erat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539583}
cros: Make "mash" shelf button start the quick_launch app
We used to start quick_launch whenever we started chrome with mash.
We don't do that anymore because it slows down startup. Make the button
open quick_launch so we can manually test that mojo mini-apps start
properly.
Bug: none
Test: chrome --enable-features=Mash, click "mash" button
Change-Id: I75f8c2a425f3dba6146fd356b4a14cf3ee589a5f
Reviewed-on: https://chromium-review.googlesource.com/940187
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539582}
Change LUCI Webkit Mac Builder (dbg) bot's os dimension.
The new bot has 10.12, just like the one on buildbot.
[email protected]
Bug: 816364
Change-Id: Ieba6b647824caea45d61dd7503a629e01d31f001
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/940439
Reviewed-by: Ryan Tseng <[email protected]>
Commit-Queue: Andrii Shyshkalov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539581}
VR: Send controller touch information to the Daydream Keyboard
This CL also moves gvr_keyboard_shim to use versioned structs for the API
methods that are loaded.
Bug: 811494
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I516187517973ccefc3a7cd4df075936be8c9fe44
Reviewed-on: https://chromium-review.googlesource.com/939862
Reviewed-by: Christopher Grant <[email protected]>
Commit-Queue: Yash Malik <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539580}
Migrate JSONResponseFetcher to SimpleURLLoader
BUG=773295
Change-Id: I306b7b9b289d48d1df9306100814c567727fdaee
Reviewed-on: https://chromium-review.googlesource.com/939743
Commit-Queue: Mark Pilgrim <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539579}
Remove border line in TabbedPane with kHighlight mode
This cl made several changes based on UX specs:
1. Remove the border line in kHighlight mode.
2. Increase preferred tab width to 208.
3. Increase font size to 13.
4. Change the font weight to medium.
Bug: 814888, 768932
Test: tested on device and compared to specs.
Change-Id: I73b90d7a33c1fbea782cebcea89633fe1105e02a
Reviewed-on: https://chromium-review.googlesource.com/936785
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539578}
Removed some unused ContentViewCore APIs/methods
Following APIs ended up having no callsites over time.
- setBackgroundOpaque
- isFullscreenRequiredForOrientationLock
This CL removed them, together with a native method(WasResize)
left unused through refactoring.
Bug: 598880
Change-Id: I34f33751c285c880a4e250dfc3fdd4e92313312e
Reviewed-on: https://chromium-review.googlesource.com/938861
Reviewed-by: Bo <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539577}
[vr] Show fallback background if assets fail to load
Bug: 816987
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If1eac6d37494a90463397225ccf51d56326df599
Reviewed-on: https://chromium-review.googlesource.com/940184
Reviewed-by: Christopher Grant <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539576}
[PE] Invalidate text control selection when pseudo style changes
In the simplest case, ::selection styles only apply to the selected
children of an element. For example, "second" will not have a
selection background color style in the following example:
<style> .foo::selection { background: red; } </style>
<span class="foo">first <span>second</span> third</span>
Text controls such as <input> and <textarea> are implemented with a
user agent shadow tree so the LayoutText contents are not children
of the text control parent. For example:
<input type="text" value="AAAAAAAAAAAA">
Generates this layout tree:
LayoutTextControl INPUT
LayoutBlockFlow DIV (editable) <-- part of the user agent shadow tree
LayoutText #text "AAAAAAAAAAAA"
When painting selection, there is a special-case for text control
contents (see: GetUncachedSelectionStyle in SelectionPaintingUtils.cpp)
which uses the text control's pseudo selection style.
This patch adds a special-case for selection invalidation so changes to
text control pseudo styles invalidate selected text contents too.
Bug: 702610
Change-Id: I06b549b5b5eff77d71c4ea58ce12eaf00519f538
Reviewed-on: https://chromium-review.googlesource.com/929664
Reviewed-by: Philip Rogers (OOO) <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539575}
bluetooth: Use JNIAdditionalImport in ChromeBluetooth code
If a @CalledByNative method takes an instance of an inner class as an
argument, then JNI needs the outer class to be included. But including the
outer class results in a "Redundant import from same package" presubmit
error.
To get around this, we use JNIAdditionalImport.
Bug: 505554
Change-Id: I166a85462f8834cde0b9bfbc0cef8fe0ad35dc43
Reviewed-on: https://chromium-review.googlesource.com/938682
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Giovanni Ortuño Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539574}
[PaymentAppBridge]: Use JNIAdditionalImport to avoid casting from object
If a @CalledByNative method takes an instance of an inner class as an
argument, then JNI needs the outer class to be included. But including the
outer class results in a "Redundant import from same package" presubmit
error.
To get around this, we use JNIAdditionalImport.
Bug: 505554
Change-Id: Ic66882c230eb296ff14af962da94598538ff6090
Reviewed-on: https://chromium-review.googlesource.com/938882
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Giovanni Ortuño Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539573}
[webauthn] Reland: Close AuthenticatorImpl bindings before callbacks are destroyed.
This will prevent crashing when a tab is closed while
an authenticator request is pending.
(Also remove some stray logs in authenticator_impl_unittest.cc).
This is a reland of https://crrev.com/c/905929, which
was reverted due to the movement of the //services/device/public/interfaces directory.
This fixes the include in webauth_browsertest.
Bug: 808096
Change-Id: Ia3ffee8deab4566844f839c6ead0b376749855a4
Reviewed-on: https://chromium-review.googlesource.com/937660
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Kim Paulhamus <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539572}
Moved prebuilt Ink files for NaCl under nacl folder.
This way, the NaCl and Wasm versions have similar and parallel structures. This
is clearer than having the Wasm version as a subfolder of the NaCl version.
Change-Id: Icc01a988068613af22e4547a630f6569335c6269
Reviewed-on: https://chromium-review.googlesource.com/930623
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539571}
Add Install Google Drive button tap handler.
When the button is tapped, DownloadManagerCoordinator does the following:
- starts StoreKitCoordinator (which presents StoreKit dialog)
- hides Install Google Drive Button
UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2eee39b982_0_0
Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2bcc400e9fafbde54f251fc05e8b607cc70e463b
Reviewed-on: https://chromium-review.googlesource.com/937995
Commit-Queue: Eugene But <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539570}
Handle texture-not-bound and image-not-defined in MailboxManagerSync
We need to allocate face/level arrays if we create a texture, otherwise
we end up in a bad state.
Bug: 816693
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I59610fb5ce831754309f62bf1b13f21c6407a505
Reviewed-on: https://chromium-review.googlesource.com/939851
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539569}
[css-typed-om] remove duplicate test.
there are duplicate tests. so remove one of them.
Bug: 774887
Change-Id: I040ac68b8d2752ea7f952a0ff615f5352cb23b0e
Reviewed-on: https://chromium-review.googlesource.com/939881
Commit-Queue: Hwanseung Lee <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539568}
vaapi: remove unnecessary MEDIA_GPU_EXPORT clauses
posciak@ brought to my attention that some classes under vaapi/
have MEDIA_GPU_EXPORT when they don't need to (they are not used
beyond media_gpu component) and that's confusing and erroneous,
so this CL removes them.
TEST= no test needed since this is a build detail.
Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0397ff56d59380ebf55fc5595333b998faef9c4f
Reviewed-on: https://chromium-review.googlesource.com/940104
Reviewed-by: Daniele Castagna <[email protected]>
Commit-Queue: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539567}
VR: Allow VR intents if Chrome Icon in DD Home is enabled.
Previously these flags both needed to be set in order for the DD icon
to work. We should just assume that anybody adding the Chrome icon
intended for this flag to also be set.
Change-Id: I33ef7f59521f405e5a158bb2d02f65f2cddc7f91
Reviewed-on: https://chromium-review.googlesource.com/940082
Reviewed-by: Yash Malik <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539566}
Introduce PositionWithAffinity::operator bool()
This patch introduces |operator bool()| for |PositionWithAffinityTemplate<T>|
for writing code like: |if (PositionWithAffinikty position = ...) { ... }|.
Note: This patch is similar to the patch[1].
[1] http:crrev.com/c/939202 Introduce Position::operator bool()
Change-Id: I2643d579f637ff1c43bdb430626d634f5c9c358a
Reviewed-on: https://chromium-review.googlesource.com/939203
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539565}
Remove unused elements from RWHV::CopyFromSurface() API and dead code.
Removes both: 1) the SkColorType argument; and 2) the ReadbackResponse
enum from the callback. Neither of these is being used meaningfully
anywhere. In addition, migrated Bind→BindOnce for the callback argument.
As a result, this interface change also exposes many obvious now-dead
code paths, and they are also removed: 1) the "decompress bitmap" code
in the Android TabContentManager (java and c++); 2) the extra post-copy
scaling GLHelper readback infrastructure in content/.../surface_utils.*.
Furthermore, due to touched lines of code, there are misc changes to
placate presubmit warnings (e.g., Bind→BindOnce, and test code that was
using content::RunMessageLoopUntilIdle()).
Finally, an order-of-operations bug in the use of CopyFromSurface() was
discovered in headless/... code and was fixed.
Bug: 759310, 582955, 415682, 760348, 807843, 787941
Change-Id: I3398761661b7472ef24f40119278ec969a4929d5
Reviewed-on: https://chromium-review.googlesource.com/929874
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Fady Samuel <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Commit-Queue: Yuri Wiitala <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539564}
[Blobs] Clarify comment for AddFinalReleaseCallback.
Make the comment explaining LIFO order for release callbacks a bit more
explicit about why the order matters.
Bug: none
Change-Id: I2461cf7054896820989481f8b973bcd103fe114f
Reviewed-on: https://chromium-review.googlesource.com/938847
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539563}
UI strings for the relaunch required modal dialog.
BUG=511300
[email protected]
Change-Id: Ifd48eec75a1aea669828c15ca4d0ffeca6e146c5
Reviewed-on: https://chromium-review.googlesource.com/926132
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539562}
Network Config: omit empty GUID and additional logging
The bug was introduced in https://chromium-review.googlesource.com/922795
which was merged to 65 so it needs to be fixed there also.
Bug: 809776
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I09b45078290e9f6047c987fd9ec9472c99f07aba
Reviewed-on: https://chromium-review.googlesource.com/938363
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539561}
[Chromecast] Add reactive requestAudioFocus() helper.
This can help deduplicate code that makes audio focus requests.
Added ability to track audio focus state with an Observable, and
added tests, though this feature is unused by chromium/src code.
Bug: Internal b/36777136
Test: cast_shell_junit_tests
Change-Id: I1d988286df9429873b9ed6bf8397c0d71a4da461
Reviewed-on: https://chromium-review.googlesource.com/929804
Commit-Queue: Simeon Anfinrud <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539560}
Revert "Disable BrowserFocusTest.ClickingMovesFocus on Chrome OS"
This reverts commit da7df3358bd5750c6c3a684649a4e43232e8318c.
Reason for revert:
It only failed with a cq trybot patch applied, see the bug...
Original change's description:
> Disable BrowserFocusTest.ClickingMovesFocus on Chrome OS
>
> Bug:816643
> Change-Id: I0b3f4cfaf67794e9904d8f269c69c3eaa98b9c05
>
> [email protected]
>
> Change-Id: I0b3f4cfaf67794e9904d8f269c69c3eaa98b9c05
> Reviewed-on: https://chromium-review.googlesource.com/938486
> Commit-Queue: Mohammad Reza Zakerinasab <[email protected]>
> Reviewed-by: Mohammad Reza Zakerinasab <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539341}
[email protected],[email protected]
Change-Id: Id966bb3d987533af026061e11bbabc5e7100a21e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816643
Reviewed-on: https://chromium-review.googlesource.com/939655
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539559}
bindings: Prepare V8ContextSnapshot on Android
This CL makes it possible to create and use V8 context snapshot
files on Android, if a developer puts "use_v8_context_snapshot=true"
The V8 context snapshot feature is currently supported and enabled on
Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment
showed 20% reduction of time to create V8 contexts.
On local Android machine, this feature shows 50% time recution.
Beside it, in order to enable the feature on cross-build platforms
like Android, we have to build Blink twice.
So this CL does not flip the flag |use_v8_context_snapshot|.
FYI, some numbers with the feature are written in the next CL;
https://chromium-review.googlesource.com/c/chromium/src/+/923623
TBR=rockot
Bug: 764576
Change-Id: I7ee8a26d350b65b196854fc9209a52fb607b580d
Reviewed-on: https://chromium-review.googlesource.com/923683
Reviewed-by: Cait Phillips <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Tao Bai <[email protected]>
Reviewed-by: Ross McIlroy <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539558}
Log video playing time metrics for power manager ml.
This cl records the following features
(i). recent video playing time just before an idle event is generated.
(ii). time from the end of video playing to when an idle event is
generated.
Change-Id: Ied74b79416afc542b668b6c218c5a21ab4fc2046
Bug: 784232
Reviewed-on: https://chromium-review.googlesource.com/935303
Commit-Queue: Jia Meng <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539557}
[WebView Tracing API] Cleanup unnecessary code in AwTracingController
After crrev.com/i/571753 landed some upstream code can be removed because
it is not used anymore.
BUG=781249,812289
Change-Id: I439c3b2a3b3b2a018ca215a6dc10a0d202ad2028
Reviewed-on: https://chromium-review.googlesource.com/938061
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539556}
VR: Fix cancelling entry animation starting activity without VR flags.
Bug: 816638
Change-Id: Ia562eb23be2685fbe7875e69e2299d3dc155d1f7
Reviewed-on: https://chromium-review.googlesource.com/939990
Reviewed-by: Yash Malik <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539555}
Remove blink::AnimatableUnknown
This class was only referenced in a single test, where it was used in a
function that was never called. Dead code be gone!
Bug: 725385
Change-Id: I93d2261cb387a542e2dd9b277e19526f77b7961a
Reviewed-on: https://chromium-review.googlesource.com/939601
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539554}
Don't implicitly convert between mojo type string and C++ base::string16
Update most .mojom files to use mojo_base.mojom.String16. This implicit
conversion adds extra UTF8<->UTF16 conversions and makes mojo definitions
less self documenting.
CredentialManager is the last hold out. Fixing that and removing
string_traits_string16.cc/h is punted for now.
Bug: 816970
Change-Id: Ibf214e8f4096616291ff493f5ddf5c79c6a16cf4
Reviewed-on: https://chromium-review.googlesource.com/920688
Commit-Queue: Evan Stade <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539553}
Disable runtime feature CompositeOpaqueFixedPosition
The feature caused performance regression on low dpi devices when a
fix positioned element contains too many children.
Temporarily disble it to unblock Stable release. Will address it through
https://crbug.com/816937.
Bug: 814673
Change-Id: I6f0fea7d6b61f572b4d8da4e54c34d63cc5bc2f1
Reviewed-on: https://chromium-review.googlesource.com/939585
Commit-Queue: Yi Gu <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539552}
Fix failing data reduction proxy test
The test only fails on official builds where the
field trials command line switch is not working.
This CL updates the test to bail out earlier if the
command line switch is not working.
Bug: 813599
Change-Id: I1c0be03b4977782e590568930273a95372ab0f47
Reviewed-on: https://chromium-review.googlesource.com/939647
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539551}
[Zucchini] upload zucchini.exe to unsigned staging on win official
Whitelist zucchini.exe for upload to unsigned staging for experimental
integration with diff infra.
This is a followup to:
https://chromium-review.googlesource.com/c/chromium/src/937396
Bug: 729154
Change-Id: Id0da2fb5aca31782ef11e81dc47abf7706df2b52
Reviewed-on: https://chromium-review.googlesource.com/939665
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Samuel Huang <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Michael Moss <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539550}
Revert "Update Google Update COM interface definitions in google_update_idl.idl."
This reverts commit 21489fa99e78a80547d9e537f7cda88cf604e328.
Reason for revert: This broke the official builders because I did not realize that google_update_win_unittest.cc needs to be updated.
Original change's description:
> Update Google Update COM interface definitions in google_update_idl.idl.
>
> This update is required for work that is underway related to management
> of Chrome browsers for enterprise users.
>
> The google_update_idl.idl file was originally provided by the Google
> Update team. It has been modified as described in the README.chromium
> file in this CL.
>
> The change was tested with Chrome-branded builds with target_cpu set to
> "x86" and "x64". I followed these steps to make sure that this change
> does not break Chrome updates.
>
> 1. Manully set the version of Chrome in src/chrome/VERSION to a version
> prior to that which is currently served on the Dev channel.
> 2. Compile with is_chrome_branded=true and target_cpu set to one of
> "x86" or "x64".
> 3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit
> Win10 machine.
> 4. Navigate to chrome://help and make sure that the update process works
> as expected.
>
> Bug: 796270
> Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3
> Reviewed-on: https://chromium-review.googlesource.com/924474
> Commit-Queue: Ali Tofigh <[email protected]>
> Reviewed-by: Will Harris <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539457}
[email protected],[email protected],[email protected],[email protected]
Change-Id: Idac53b550e713d95f131cb0fe8ea189f88d89a26
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 796270
Reviewed-on: https://chromium-review.googlesource.com/939652
Reviewed-by: Ali Tofigh <[email protected]>
Commit-Queue: Ali Tofigh <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539549}
Update win/cross documentation.
Bug: 495204
Change-Id: Ie00df53ef293d7118f7cd581736408d602cc385d
Reviewed-on: https://chromium-review.googlesource.com/940061
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539548}
Add Android tests to match existing C++ browsertests.
This adds Android equivalents for the existing
UkmBrowserTests: RegularPlusIncognitoCheck and IncognitoPlusRegularCheck
Bug: 804451
Change-Id: If998e13c0f794af05f139f1072298d55db6f3ce8
Reviewed-on: https://chromium-review.googlesource.com/889360
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Bryan McQuade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539547}
Reporting: Check upload permissions asynchronously
This changes the signature of the CanSendReport method so that it works
asynchronously. We need this to able to check the background sync
permission, since that can only be checked from the UI thread; we need
the async logic to pass control between the IO and UI threads in the
right way.
To reduce the number of async calls, the method has also been updated to
check several origins all at once, instead of having a single method
call for each origin. You pass in a set of origins that you'd like to
upload reports for, and the method passes back the set of origins that
you're allowed to.
Bug: 704259
Change-Id: I431b2fe1c1eb4e65cea91a86fd213e3204b852a1
Reviewed-on: https://chromium-review.googlesource.com/937566
Reviewed-by: Julia Tuttle <[email protected]>
Commit-Queue: Douglas Creager <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539546}
Add initial implementation of assistant service to Chromium
BUG=807015
TEST=locally enable flag and observe assistant is running
Change-Id: I3578517e78dffa6139616913c3ef2c02f956a699
Reviewed-on: https://chromium-review.googlesource.com/905470
Commit-Queue: Muyuan Li <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539545}
Disable screenshots in locked fullscreen mode
Locked fullscreen mode will be used for low stakes assessments (student quizzes),
hence screenshots are a problem since the students can take screenshots of the
questions and share it with their friends later.
Bug: chromium:816481
Change-Id: I15de1ab5619e3cb2836089685b753ec5aa042b1b
Reviewed-on: https://chromium-review.googlesource.com/938081
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Ivan Šandrk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539544}
[Web Payments] Fix back arrow button on Payment Handler sheet
Bug: 816990
Change-Id: I4b7aaff3468e94e6eba52c09265d02e6d515594a
Reviewed-on: https://chromium-review.googlesource.com/939871
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: anthonyvd <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539543}
Update AUTHORS file with @vivaldi.com domain
Change-Id: I98f2cab3f8597e2bdb48d40999e13a7008a34096
Reviewed-on: https://chromium-review.googlesource.com/923738
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539542}
[iOS] Create ObjC container for fullscreen disabler observers.
This allows the proper memory management of ObserverLists used in
Objective-C blocks.
Bug: 816342
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic3b232303586ec99129ab999740454a0180833bb
Reviewed-on: https://chromium-review.googlesource.com/939101
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539541}
[ios] Ignore cache for welcome view page loads.
Bug: 815285
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I87ca4984122383038ecebf2a510d32bc16be54f0
Reviewed-on: https://chromium-review.googlesource.com/939746
Commit-Queue: Justin Cohen <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539540}
[ChromeDriver] Add --log-level command line switch
Add a new command line switch for ChromeDriver, to allow more
flexibility in controlling the log level.
Bug: chromedriver:2221
Change-Id: I788c56d823d7d63b9f65ce31105230d2ffa47887
Reviewed-on: https://chromium-review.googlesource.com/912589
Commit-Queue: John Chen <[email protected]>
Reviewed-by: Jonathon Kereliuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539539}
Add Histograms: Navigation.Renderer.ReadyToCommitUntilCommit.*
These histograms will record time it takes for the renderer to commit a
navigation once it has been requested to.
It is the duration between:
- RenderFrameImpl::CommitNavigation() and
- RenderFrameImpl::DidCommitProvisionalLoad().
Bug: 705744
Change-Id: Ia22062ef01923ed15d579313abb2ec99beb6e718
Reviewed-on: https://chromium-review.googlesource.com/934458
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539538}
VR: Update Chromium Daydream Icon
This icon is only available behind a default-disabled runtime flag.
The icon may not be final, and we may ship this feature with different
icons, but just in case users find and flip the flag we'd like to
preserve Chrome/Chromium branding.
The icons were passed through optimize-png-files.sh
[email protected]
Change-Id: Ic3744801867055a8dd8cf4b6ed90a27bc4d80e8b
Reviewed-on: https://chromium-review.googlesource.com/939747
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Yash Malik <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539537}
Bookmarks.FileSize histogram should be reported in kilobytes
This CL fixes a bug in reporting the Bookmarks.FileSize metric.
base::GetFileSize() return the file size in bytes while KBs are
required.
Additionally, UMA_HISTOGRAM_MEMORY_KB uses bucketing scheme as follows:
The first bucket is for files smaller than 1000K(1MB)
and the max bucket is for files larger than 500000KB (500MB)
This CL changes the bucketing scheme to better represent
small files (smaller than 1000KB)
And adjusts the max to be 50MB which is more suitable for bookmarks
files. 25 buckets should be enough for analysis.
It should be OK to change the bucketing scheme because it didn't hit
stable yet. Only canary reporting will be half broken.
Bug: 808439
Change-Id: I098f5df128949a9e545dc59973def693ec540ec1
Reviewed-on: https://chromium-review.googlesource.com/931507
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539536}
Log start end end of app push-installs
This makes the |AppInstallEventLogCollector| detect and log the
start and end of app push-installs:
* When an app is added to the push-install list in |ArcPolicy|,
the start of a push-install is logged.
* When an app disappears from the non-compliance list returned
by CloudDPC, the successful end of a push-install is logged.
* When an app is removed from the push-install list in |ArcPolicy|,
the cancellation of a push-install is logged.
|AppInstallEventLogCollector| also checks whether ARC has become
unavailable altogether (implicitly canceling all pending app
push-install requests) and starts an |AppInstallEventLogger| that
will log events which occur during the app push-install process.
Bug: b/73277923
Test: manual
Change-Id: Iafb49a33d877e5bb3230f32c9bf9c17e7145b6aa
Reviewed-on: https://chromium-review.googlesource.com/932302
Commit-Queue: Bartosz Fabianowski <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539535}
Add Duration UKM for Presentation sessions
Added a Duration metric for when a vr presentation is happening. Renamed
TimeOnPage to Duration under PageSession.
Bug: 808586
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5ab5810278399cc69c495fb44e89bc350d260c3f
Reviewed-on: https://chromium-review.googlesource.com/923024
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Reviewed-by: Bill Orr <[email protected]>
Commit-Queue: Anna Offenwanger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539534}
Introduce Position::operator bool()
This patch introduces |operator bool()| for |PositionTemplate<T>| for writing
code like: |if (Position position = ...) { ... }|.
Change-Id: Ifb9061cb8ac95c25f7db03293c17080dba3ebc43
Reviewed-on: https://chromium-review.googlesource.com/939202
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539533}
[Zucchini]: add PATCHERTYPE resource to setup.exe
The new PATCHERTYPE resource will be used by the release infra for
Chrome to determine which type(s) of patches setup.exe is compatible
with. This is a safety for the transition/experimentation period
between Courgette and Zucchini to ensure that compatible patches are
always created. This change implements a marker for Courgette only
and a Zucchini variant will be added in the CL in which it is
integrated into setup.exe
This was originally part of:
https://chromium-review.googlesource.com/916553
Bug: 729154
Change-Id: Ie197e1adae692dd2badc269363dd626af14f38dd
Reviewed-on: https://chromium-review.googlesource.com/937400
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539532}
overview: Fix crash in old ui when dragging item.
Crash was caused when trying to animate layer which only exist in new ui.
Test: manual
Bug: 814917
Change-Id: I95079d32a50c18cd6039e0d451ffee6fc6efc899
Reviewed-on: https://chromium-review.googlesource.com/934965
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539531}
Re-enable DumpAccessibilityTreeTest.AccessibilityInputTypes
Bug: 98976,622387
Change-Id: I61560e6c55966a2df05050d301391a385d114554
Tbr: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/938382
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Alice Boxhall <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539530}
cros: Hide context menu on entering tablet mode.
Otherwise users can select shelf settings that tablet mode does not
allow. Alternatively, we can keep the menu open and disable the
options, but I think this should suffice.
Test: manual
Bug: 814976
Change-Id: Id42a0c1ceef879d1227317ee0d27911b73df6c1b
Reviewed-on: https://chromium-review.googlesource.com/935627
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539529}
ArcUsbHostUIDelegte implemetation
Implementation of ArcUsbHostUIDelegate.
Bug: 776476
Bug: b:24572867
Change-Id: I8e0d2c44a758a802f6d224742f18ca41e2d7387c
Reviewed-on: https://chromium-review.googlesource.com/903403
Commit-Queue: Long Cheng <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539528}
arc: Add default notification delegate for provisioning managed user.
TRANSIENT type of notification requires delegate be set
Test: manually
Bug: 816977
Change-Id: Iea568f3ffea943899be2d3c212a10dbb5f70fbf6
Reviewed-on: https://chromium-review.googlesource.com/939846
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539527}
Roll src/third_party/angle/ b52fac03f..360098d5c (7 commits)
https://chromium.googlesource.com/angle/angle.git/+log/b52fac03f438..360098d5c29f
$ git log b52fac03f..360098d5c --date=short --no-merges --format='%ad %ae %s'
2018-02-21 lucferron Vulkan: Implement GL_LINE_LOOP support for non-indexed draw calls
2018-02-27 jiajia.qin ES31: Fix incorrect initialization for indexed atomic counter buffer
2018-02-27 jiajia.qin Move the early-return case of zero mask to Context::blitFramebuffer
2018-02-25 jmadill Vulkan: Fix offsets in BufferVk::setDataImpl.
2018-02-22 jiawei.shao ES31: Add link validation on geometry shader varyings
2018-02-23 jgilbert Allow EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE with EGL_PLATFORM_DEVICE_EXT.
2018-02-23 jiawei.shao ES31: Add missing checks for querying GL_COMPUTE_WORK_GROUP_SIZE
Created with:
roll-dep src/third_party/angle
The AutoRoll server is located here: https://angle-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: If576d8b48cc5d89edc41e44550ae327216af13c4
Reviewed-on: https://chromium-review.googlesource.com/939052
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539526}
Download Home : Disable NEW badge
Disabling the NEW badge for M66 until exact UX is being determined.
Bug: 810098
Change-Id: If24edd22235e6d74f89100a66214c78d9db011fc
Reviewed-on: https://chromium-review.googlesource.com/923284
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539525}
Remove the linkrepro_root_dir GN flag.
It's not needed anymore.
Bug: 669854
Change-Id: Ibf9fae7df457a5abb6237c9f43518b5d8a661587
Reviewed-on: https://chromium-review.googlesource.com/938369
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Commit-Queue: Sébastien Marchand <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539524}
Download home : Fixing back button on tablets
This CL tries to fix the back navigation which was broken after
introduction of "?showPrefetchedContent=true" query param in the
Download Home URL. This causes duplicate entries in navigation
history and tablets get stuck in a loop and cannot come out of
download page.
In this CL we are removing this query param and sending the
boolean through and intent extra instead. This is only intended
for phone as tablets will not have the animated expansion.
Bug: 813023
Change-Id: I79f5773209a6b9fecd6c37ca9e9a389f447de647
Reviewed-on: https://chromium-review.googlesource.com/927829
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539523}
cros: Disable back button on network error screen when it's not clickable
Bug: 781194
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c0946028e8fdb6e86825052af14cef498119cdb
Reviewed-on: https://chromium-review.googlesource.com/933706
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539522}
Add unittests for CastTouchDeviceManager
Ensure the touch device events are scaled correctly.
Bug: b/72054342
Test: Compiled and ran unittests
Change-Id: I40b9d1dac5f49f7c4cf7f38bf047f8a75e908d49
Reviewed-on: https://chromium-review.googlesource.com/932962
Commit-Queue: Daniel Nicoara <[email protected]>
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Sergey Volk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539521}
Clean up rects input to AccessibilityFocusRingController::setFocusRings.
This will remove duplicates and not bother to re-run logic if the
rects in the list have not changed.
While this doesn't fix a bug in which unnecessary chromevox focus is
seen for a short while, it helps to clean up related code.
Bug: 798691
Change-Id: I581789056390d370c67f0b2aebbace34bc714de2
Reviewed-on: https://chromium-review.googlesource.com/938672
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539520}
cros: Views-login UI for removing a user.
Bug: 809637
Change-Id: Id06bf1b73bed7e2338488b68a1702f13582331f0
Reviewed-on: https://chromium-review.googlesource.com/930242
Commit-Queue: Jacob Dufault <[email protected]>
Reviewed-by: Xiaoyin Hu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539519}
Prevent overflow in LayoutUnit operator++
Bug: 772263
Test: Source/platform/LayoutUnitTest.cpp
Change-Id: I470b0dd4ce654c777d178dba077e523d3748b926
Reviewed-on: https://chromium-review.googlesource.com/938850
Reviewed-by: Justin Schuh <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539518}
Drop BuildCompat.isAtLeastOMR1.
This is no longer called; drop it as it's deprecated on the Android
side (code should just check the version directly).
Change-Id: I5e666435e0b3a3c60e0da0e3448bd6a988026e27
Reviewed-on: https://chromium-review.googlesource.com/938601
Reviewed-by: Tobias Sargeant <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539517}
Mark two bookmarks tests as flaky on simulators.
Bug: 816699
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9ef613d741418b2a66f96664438979aa3256c680
Reviewed-on: https://chromium-review.googlesource.com/938677
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Menglu Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539516}
Fix some nits in pdf DocumentLoader code.
And add a header to IWYU in PDFiumEngine.
Change-Id: I93198a22d80d252339f19328788ac2e6ec5a96f9
Reviewed-on: https://chromium-review.googlesource.com/939643
Reviewed-by: dsinclair <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539515}
End-of-line conversion to Unix style
This .ver file in currently in Windows style (CR LF), which should be
converted to Unix style (LF).
Bug: 734095
Change-Id: I7560924f308ce2e7936c982b049e84e83f35231d
Reviewed-on: https://chromium-review.googlesource.com/938966
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Xi Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539514}
[Payments] Rename parameter to make it consistent with the implementation
Bug: 735063
Change-Id: I90a87a01c2769316230716fd3c590dbe6c106801
Reviewed-on: https://chromium-review.googlesource.com/939581
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539513}
Fuchsia: switch new runner scripts to use FVM disks instead of bootfs.
Switching to FVM will give us a functioning blobstore, a prerequisite
for installing packages, and allows the Fuchsia team to follow through
with bootfs deprecation.
Also added a missing package reference to local-sdk.py that caused it
to skip building the Fuchsia userspace.
Bug: 802331
Change-Id: I6cfc45c51dae97bef3c9f7a202f74fff483d5c50
Reviewed-on: https://chromium-review.googlesource.com/919266
Commit-Queue: Kevin Marshall <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539512}
Check for font in LayoutTextCombine::TransformToInlineCoordinates
Check for PrimaryFont in LayoutTextCombine::TransformToInlineCoordinates
as it may be NULL in which case no coordinate transform is required.
Bug: 814734
Change-Id: I9d637bc9956a3129cd294398e407023cc45e32ea
Reviewed-on: https://chromium-review.googlesource.com/938661
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539511}
Fix safe browsing interface exposure to renderers
The safe_browsing::mojom::PhishingDetectorClient interface appears to
have been added to the wrong interface_provider_spec. This moves it to
the correct one.
Bug: 816892
Change-Id: If6421f57920a36fa9c2be351c5b451cedfd024cc
Reviewed-on: https://chromium-review.googlesource.com/939538
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539510}
Allow null elements in EffectInput::Convert
By the spec, a KeyframeEffect may be created with a null target,
although unfortunately the spec doesn't then say what Document to use to
resolve style/etc. This CL adds null-target handling, falling back to
the Document extracted from the ScriptState if there is no target.
In terms of changes to tests:
- Three WPT tests no longer timeout (woo), but unfortunately they
currently crash on a DCHECK for setting transform-box to 'border-box'
and so are still disabled. See http://crbug.com/816534
- A number of tests for processing a keyframes argument start failing
due to a bug in that code; previously this went unseen because the
tests pass null for the element.
Bug: 772014, 816534
Change-Id: I01502c82bf758a796fe83c87ed395c6b9f6c4e11
Reviewed-on: https://chromium-review.googlesource.com/934625
Commit-Queue: Stephen McGruer <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539509}
Introduce Ignored state in ui/accessibility
There are times when a node needs to be ignored, meaning it
shouldn't be exposed as part of the accessibility tree, but
its subtree should. A common example is role=none/presentation,
but we also sometimes do this for extra wrapper divs and spans.
Previously these ignored nodes were just never exposed by Blink,
but that has led to problems when a node's ignored status changes.
Instead, let's introduce the concept of ignored to AXNodeData
and add support for walking the "unignored" tree to AXNode.
When a node's ignored state changes, we should fire a Children
Changed event on the first unignored parent.
This change introduces a new state and some helper functions
but doesn't actually use them. A follow-up change will start
making use of this code.
Bug: 651614
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ide93a65d5721c00e8c9d1780c8b524341b837f05
Tbr: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/936430
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539508}
ArcUsbHostUiDelegate
Add ArcUsbHostUiDelegate interface.
Bug: 776476
Bug: b:24572867
Change-Id: I0ff523c24ebc1786f1fee3e77bbd36ebed72831e
Reviewed-on: https://chromium-review.googlesource.com/903059
Commit-Queue: Long Cheng <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539507}
Rebaseline WPT on Mac 10.13
This CL rebaselines WPT that fail on Mac 10.13 by:
1. Triggering mac10.13_blink_rel
2. Grep "external/wpt" in the list of failing tests
3. `webkit-patch rebaseline-cl` that list of tests
Most of the changes are promoting mac-mac10.12/ to mac/ and then further
consolidating some of them with win/ to the generic baselines.
Bug: 774301
Change-Id: Ib50dcaaba5952a4e9ecbed710303041ca7f04013
Reviewed-on: https://chromium-review.googlesource.com/899785
Reviewed-by: Quinten Yearsley <[email protected]>
Commit-Queue: Robert Ma <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539506}
Scroll to beginning of text when displaying search terms in omnibox.
The assumption is currently that the URL bar displays URLs, so we
always make a call to #scrollToTLD. This results in showing the end of
a query, which is inconsistent with common SRP behaviour.
This CL ensures that when we're displaying search terms, we scroll to
the start of the text in an RTL friendly way.
Bug: 776988
Change-Id: Ied926bd276f312a7e4ab18b9c45173d0ce15dbbe
Reviewed-on: https://chromium-review.googlesource.com/935452
Commit-Queue: Troy Hildebrandt <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539505}
Roll src/third_party/depot_tools/ 9b4d0c771..53a629116 (1 commit)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b4d0c77152a..53a62911658d
$ git log 9b4d0c771..53a629116 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 agable Update windows bleeding-edge git to 2.16.2
Created with:
roll-dep src/third_party/depot_tools
The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I489178230fe31272df075eb94477a461562b9880
Reviewed-on: https://chromium-review.googlesource.com/939589
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539504}
Revert "Clean up SpeechRecognitionSessionContext."
This reverts commit e9c5d97316635b53595dbd2389d2b9407c69903f.
Reason for revert: There were clients depending on this confusion of invalid ID. It's not clear what broke, as tests are not reliable, so reverting to make sure that the 66 branch works.
Original change's description:
> Clean up SpeechRecognitionSessionContext.
>
> The correct "no process" id is not 0; use instead
> content::ChildProcessHost::kInvalidUniqueID (-1).
>
> The correct "no view/frame" id is not 0; use instead
> MSG_ROUTING_NONE (-2).
>
> In addition, guest_render_view_id is not actually used,
> so remove it.
>
> BUG=390749
>
> Change-Id: Iaf0510b00e8646f71d23eee2c9309e64f59e0903
> Reviewed-on: https://chromium-review.googlesource.com/922802
> Reviewed-by: Olga Sharonova <[email protected]>
> Reviewed-by: Justin Schuh <[email protected]>
> Commit-Queue: Avi Drissman <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#537378}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 390749
Change-Id: Icceeb7ff0e609e9193ae4c3a88e7a69f537242fe
Reviewed-on: https://chromium-review.googlesource.com/938723
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539503}
[ios] Creates TableViewTextItem
- Creates TableViewTextItem
- Creates TableViewTextCell
- Adds it to the Cell Catalog.
Screenshot:
https://drive.google.com/open?id=1TVy-uclmwfIo32KfQmRrq_aff5_qPvfg
Bug: 805149
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2708d458c06d245beab2cb35f78d1b13101548ff
Reviewed-on: https://chromium-review.googlesource.com/938500
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539502}
Add OutputStream to audio service.
This CL adds an AudioOutputStream implementation for the audio service.
Note that there isn't a separation between AudioOutputDelegate and
AudioOutputStream like for content/media, since it isn't needed, and
fewer layers are simpler. OutputStream has the same functionality as
AudioOutputDelegateImpl, except for
* mirroring: requires lots of refactoring to break content
dependencies.
* notifying content::MediaObserver. Will be done by the client in
content/.
CL with factory for this:
https://chromium-review.googlesource.com/c/chromium/src/+/939179.
Design doc: http://go/audio-service-streams-design
Bug: 803102
Change-Id: Id660d08497b99fb0beba8201760d2b13d788ffb2
Reviewed-on: https://chromium-review.googlesource.com/908561
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Max Morin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539501}
Make includes from pkg-config use -isystem not -I
pkg-config currently specifies include directories using the -I flag,
even for system libraries. This means that warnings in the included
header files (for example when enabling -Wzero-as-null-pointer-constant)
cause the build to fail.
This change will make pkg-config include directories included using the
-isystem flag instead, which will make the compiler not report warnings
in the included header files.
Bug: 816565
Change-Id: I441ddeee28f8031410ce95ae1712bd68b0b86a63
Reviewed-on: https://chromium-review.googlesource.com/938941
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Tim Brown <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539500}
PaymentHandler: Implement permission prompt when calling instruments.set
This patch is an initial implementation of the following spec change:
- https://github.com/w3c/payment-handler/issues/246
- https://chromium-review.googlesource.com/c/chromium/src/+/533193
This feature is still behind runtime flag.
Bug: 665949
Change-Id: Ied225b89c7aed3a39955e49e9af2e4e3866a92c2
Reviewed-on: https://chromium-review.googlesource.com/914661
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539499}
Make ChromeSessionManager's "signin flow" IdentityManager-friendly
The codebase is in the process of being incrementally converted from
usage of //components/signin to usage of //services/identity/public/cpp.
In the process of this conversion, IdentityManager can end up being
instantiated in the context of browser_tests. IdentityManager
has internal DCHECKs that verify that its view of the primary account
is consistent with SigninManagerBase. As ChromeSessionManager sets
signin information manually on SigninManager, these DCHECKs can fire.
This CL modifies ChromeSessionManager so that it goes through
IdentityManager to set the primary account info. Doing this sets the
primary account information both in IdentityManager and also in
SigninManagerBase.
Note that one complexity is that this flow does not set the refresh
token. In the long term we would ideally set the refresh token as part
of this flow in order to unify this flow with other signin flows in the
codebase. However, that is a behavioral change that is orthogonal to the
change being made here. In this CL, we simply add a method to
IdentityManager that allows for setting only the GAIA ID/email address
but not the refresh token. https://crbug.com/814787 tracks the work
required to remove this method and port this flow to use more
mainstream Identity Service APIs.
This change is concretely needed for an upcoming conversion to avoid
tickling this issue :).
Bug: 796544
Change-Id: I405a8883bef03c2aaa94b01ed7bebf5e41a1164d
Reviewed-on: https://chromium-review.googlesource.com/931469
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539498}
Fix use-after-free in message center.
MessageCenterImpl::OnBlockingStateChanged() was unsafe. On desktop,
MarkSinglePopupAsShown removes/deletes that notification since there is
no message center bubble. The function then references the notification
again, via the |blocked| list. Instead of a list of weak Notification
pointers, |blocked| should be a list of notification IDs.
This bug was revealed by (although not directly caused by) removing the
NotificationChangeQueue.
Bug: 816374
Change-Id: I9ebc21ae95b18bf167c52911c7c0e1eacaf6e06d
Reviewed-on: https://chromium-review.googlesource.com/938676
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539497}
Fix Scroll events failing to bubble on Youtube page.
The problem with Youtube page in oopif is that the Body element of the
iframe is vertically scrollable by a few pixels (ClampScrollOffset doesn't
shirnk the vertical scroll delta to zero) but
UserInputScrollable(kVerticalScrollbar) is false for its scrollablearea.
This cl uses the latter function in addition to ClampScrollOffset to
calculate the clamped scroll delta in ScrollManager::CanScroll.
Bug: 809621
Test: SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden
Change-Id: Id7c722331bc4e65cf4808aa7bb18b3cbf3f71808
Reviewed-on: https://chromium-review.googlesource.com/905473
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Sahel Sharifymoghaddam <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539496}
Tune the error message of profile blocking.
Bug: 803191
Change-Id: I04053d35036e05014c0ff8a670b774a7be5cb96c
Reviewed-on: https://chromium-review.googlesource.com/939584
Reviewed-by: Thiemo Nagel <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539495}
Change CWVTranslationController dependency injection to use init.
This will help in writing tests for CWVTranslationController.
Bug: 770983
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8f0b67e14872e654fcf276f0fba20dab4289b6b9
Reviewed-on: https://chromium-review.googlesource.com/939045
Commit-Queue: John Wu <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539494}
[ChromeDriver] Support OOPIF
Add support of OOPIF (out-of-process iFrame) to ChromeDriver
Change-Id: I0b936b21597d8970656029c3110bfe0f61ae9aa8
Reviewed-on: https://chromium-review.googlesource.com/934145
Commit-Queue: John Chen <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539493}
Update V8 to version 6.6.334.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/efc0f3d4..687fceb2
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Change-Id: If94d30c7437cf4ed518c3084927e014614faaaf5
Reviewed-on: https://chromium-review.googlesource.com/938596
Reviewed-by: v8 autoroll <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539492}
[subresource_filter] suppress notifications when forcing activation
We should never show the Ad block UI when devtools is the cause of the
activation. This CL does that by using suppress_notification for
forced activation. This messes up some logging, so we handle that by
adding a new histogram at the //content layer.
Bug: 812348
Change-Id: I16ae72cbb3342183a2067f2ad1698758425cd160
Reviewed-on: https://chromium-review.googlesource.com/919315
Commit-Queue: Charlie Harrison <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Shivani Sharma <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539491}
Add BrowsingDataRemoverObserver interface
Bug: none
Change-Id: Ie877b9c71a1851c5f663ecb3ef194391aa6bd9be
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/939173
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Elodie Banel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539490}
Make ViewAccessibility::OverrideIsLeaf work on Chrome OS too.
Bug: 812647
Test: manually tested bug 812647 with ChromeVox
Change-Id: I9110c0d9e301dad9315cfbcdb9572a1c91c90a16
Reviewed-on: https://chromium-review.googlesource.com/938753
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539489}
Roll src/third_party/catapult/ 38e8eedc7..47ca0db0b (5 commits)
https://chromium.googlesource.com/catapult.git/+log/38e8eedc7bb6..47ca0db0bd96
$ git log 38e8eedc7..47ca0db0b --date=short --no-merges --format='%ad %ae %s'
2018-02-26 charliea Reland: Roll the new BattOr firmware and battor agent to the latest version
2018-02-26 nednguyen [Telemetry] Cap the limit of trace size in TimelineBasedMeasurement to 400 MiB
2018-02-26 charliea Fix remaining reference to bad host/arch strings in BattOr wrapper
2018-02-23 wvw Add clock state support
2018-02-23 wvw Add clk_set_rate support
Created with:
roll-dep src/third_party/catapult
The AutoRoll server is located here: https://catapult-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ia5e66c2348dd7c8dd9487451fca60c3643534749
Reviewed-on: https://chromium-review.googlesource.com/938364
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539488}
Roll src/chrome/browser/resources/media_router/extension/src/ 8c27673ed..270eb6c46 (3 commits)
https://chromium.googlesource.com/media_router.git/+log/8c27673ed823..270eb6c464d5
$ git log 8c27673ed..270eb6c46 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 mfoltz Changed default values of MR compile-time constants.
2018-02-23 mfoltz Made logging settings easier for developers to discover.
2018-02-23 mfoltz Added device discovery via Slarti.
Created with:
roll-dep src/chrome/browser/resources/media_router/extension/src
Change-Id: If6a3633e4a8702e46527a39b30215a9373d4019a
Reviewed-on: https://chromium-review.googlesource.com/938565
Commit-Queue: mark a. foltz <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539487}
Use a real database in PostmortemReportCollector tests
NewReports are being made classes, intended to be initialized only by a
CrashReportDatabase (which is a friend). This makes mocking
PrepareNewCrashReport and FinishedWritingCrashReport awkward, but a
real CrashReportDatabase shouldn't be prohibitively heavyweight.
Bug: crashpad:206
Change-Id: I085cacfc4fd4b3e51578973c9795a5a25c1c14dc
Reviewed-on: https://chromium-review.googlesource.com/937982
Commit-Queue: Joshua Peraza <[email protected]>
Reviewed-by: Sigurður Ásgeirsson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539486}
Add browser tests for client hints without Accept-CH-Lifetime
This CL introduces no functional changes, and only verifies
the current behavior of client hints when only the
Accept-CH header is specified in the response headers.
Browser tests and Blink tests are added for cases where the origin has
specified only the Accept-CH header in the response headers. The tests
ensure that currently client hints are attached even if the origin
does not have permission to run JavaScript. Additionally, the tests
also ensure that the client hints are attached for third-party origins.
The next CL will modify these behaviors, and prevent attaching of
client hints when origin does not have permission to run scripts.
The next CL would also prevent attaching of client hints to
third-party origins. The tests added in this CL would be updated
to match that behavior in the next CL.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I90d992cd456e62f36924243972430012639efde9
Bug: 816661
Reviewed-on: https://chromium-review.googlesource.com/938541
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539485}
Remove GetTaskSchedulerInitParams() overload that takes variations params as argument.
This overload is no longer used. All callers use the overload that
calls base::GetFieldTrialParams() directly.
Bug: 810049
Change-Id: I0cde22bd6701b8b698b90aa7b39a10666fe7d32f
Reviewed-on: https://chromium-review.googlesource.com/909296
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539484}
Roll src/third_party/skia/ c657fa6d4..db1e5c647 (4 commits)
https://skia.googlesource.com/skia.git/+log/c657fa6d44d3..db1e5c6474c1
$ git log c657fa6d4..db1e5c647 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 kjlubick Port 3 API fuzzers to be oss-fuzz friendly
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6ae51611c..06a87ec83 (3 commits)
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b52fac03f..6ae51611c (1 commit)
2018-02-26 bsalomon Suppress CopySurface test on Nexus 7
Created with:
roll-dep src/third_party/skia
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I82764f84cf4d3d59e232caaedfd22c8d072c461f
Reviewed-on: https://chromium-review.googlesource.com/939441
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539483}
Add assets for UI Refresh
This CL adds the new assets to be used for the UI refresh and use them.
Bug: 807284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6cd1d1132a4552296fdefbcd488652a7cfd59ca2
Reviewed-on: https://chromium-review.googlesource.com/939394
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539482}
Ensure the SynchronousCompositorMojo is destroyed before InputHandlerProxy
Since the SynchronousCompositorProxy (base class of SynchronousCompositorMojo)
holds onto a reference to the InputHandlerProxy it must be destroyed
before the InputHandlerProxy is destroyed.
BUG=816538
Change-Id: I990b5a427970b28219464267de41a28b1fabb5d0
Reviewed-on: https://chromium-review.googlesource.com/938485
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539481}
[jumbo] rename variables name for jumbo build.
a patch[1] which is to fix jumbo build error was merged.
but g_instance_for_testing still keep in memory_dump_manager.cc.
that variable name looks like generic name which is some potential
to make same issue.
so it should be rename in order to void the same problem.
[1]https://chromium-review.googlesource.com/938821
Bug: 775547
Change-Id: Id7f3fc30a8118fb6f24f0e920ab530f44a27fa82
Reviewed-on: https://chromium-review.googlesource.com/938803
Reviewed-by: Primiano Tucci <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539480}
Add aura::Window::OcclusionState:HIDDEN.
This CL adds an occlusion state to allow delegates to be notified when
a window goest from hidden <-> occluded.
Bug: 668690
Change-Id: I3b16a699ab5d8e6050332e5146007766b0c3949f
Reviewed-on: https://chromium-review.googlesource.com/927205
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539479}
Disable ComponentCloudPolicyTest.InstallNewExtension on Mac
Bug:816647
Change-Id: Icbf574609b6aa1be953c5388407e5a8d4f587808
[email protected]
Change-Id: Icbf574609b6aa1be953c5388407e5a8d4f587808
Reviewed-on: https://chromium-review.googlesource.com/938368
Reviewed-by: Mohammad Reza Zakerinasab <[email protected]>
Commit-Queue: Mohammad Reza Zakerinasab <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539478}
Introduce the Problem Applications setting subpage under the reset card
When one or more programs that injects code into Chrome are detected,
this subpage displays a list of actions that the user can take to either
remove those programs or follow a link to upgrade or learn more.
This card is only active if the ModuleDatabase and the
ProblematicProgramsWarning features are enabled.
Bug: 717696
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibaff081d0f424080b2dba31cf6c5f2aaeab62214
Reviewed-on: https://chromium-review.googlesource.com/924522
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539477}
Move WebKit/common/{loader,message_port,net,page,quota} mojom to public/mojom
BUILD.gn file changes will be made in a follow-up.
[email protected],[email protected],[email protected]
Bug: 809983
Change-Id: I19a8a1bd5d9126328cb6e7f478fd92eb44150434
Reviewed-on: https://chromium-review.googlesource.com/939206
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539476}
Remove -chromeExecuteCommand:
Since ClearBrowsingDataCommand is no longer used (removed by
http://crrev.com/c/934501), there is no need to support the
deprecated -chromeExecuteCommand:.
Remove it and all the legacy support (GenericChromeCommand,
old #import, ...).
Bug: 738881
Change-Id: I004e548733550824aca4e9f5d0609e7172d2da1a
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934270
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539475}
S13nServiceWorker: Allow importScript() twice for non-installed workers.
An installing service worker can call importScripts('dupe.js');
importScripts('dupe.js');. The first call should install the script, and
the second call should read the installed script. This CL implements
that. We detect if the script is already installed, and if so we use
a simple URLLoader that reads the installed script.
This fixes WPT test import-scripts-resource-map.https.html.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I30c7532cedffaad3d62b12239ab230a0708bb49c
Bug: 814583
Reviewed-on: https://chromium-review.googlesource.com/934024
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539474}
Calling PushManager.subscribe() should always hit the GCM Driver
The PushMessagingManager currently maintains its own subscription cache
in the Service Worker database, keeping track of the subscriptions it
thinks are valid. This means that the PushMessagingManager assumes that
the subscription is valid.
There are cases where the underlying push service, in our case Google
Cloud Messaging implemented through our GCM Driver, invalidates a
subscription. We need to find out about that when it happens, so change
the PushMessagingManager to *always* attempt to create a subscription,
upon which we rely on the push service client to return the same
information given the same input.
The GCM Driver has its own cache, so in the vast majority of cases these
calls won't hit the server. They will, however, on occasion.
Bug: 799483
Change-Id: I715c6f2eb8296b4512b6b7e9e31734ce9f254744
Reviewed-on: https://chromium-review.googlesource.com/932401
Commit-Queue: Peter Beverloo <[email protected]>
Reviewed-by: Anita Woodruff <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539473}
Unify Browser frame profile icon creation code
The various callers of
BrowserNonClientFrameView::UpdateProfileIndicatorIcon() had
mostly-duplicated logic every where, which merited a refactor
in order to unify the common code in one place.
BUG=815031
Change-Id: I3ea46d9b0fca3eed4d491b5d5bf1da9289bd4c8e
Reviewed-on: https://chromium-review.googlesource.com/935882
Commit-Queue: Ahmed Fakhry <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539472}
[ios] Add device unit tests.
BUG=723764
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7284ca9ec0d291f51e13b9724d1e02aaedda870f
Reviewed-on: https://chromium-review.googlesource.com/936363
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Shenghua Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539471}
vaapi cleanup: move TRACE_COUNTER1(input buffers) to a better place
This CL moves a TRACE_COUNTER1() counting input_buffers_.size()
from its current position to next to |input_buffers_| actions
(i.e. where it grows or shrinks).
It also renames s/GetInputBuffer_Locked/GetCurrInputBuffer_Locked/
to better reflect what the method does.
Cosmetic changes:
- removes .get() on checks for |curr_input_buffer_|
(bc unique_ptr<> has an operator boolean()).
- Removes unnecessary curly brackets.
- Removes superfluous comments.
- Escapes some variable names in comments.
TEST= simplechrome w/ crosvideos and v_d_a_unittests on soraka
Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5b3d51fd1509f8d0ce87487a44d6c7a77b4a253b
Reviewed-on: https://chromium-review.googlesource.com/934403
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539470}
Add support for mouse back/forward buttons.
This CL adds support for the "back" and "forward" buttons (located on the side
of many mice) to the Linux and Windows hosts. macOS does not seem to have very
consistent support for these (the documentation only states that mouse buttons
beyond the standard three should be passed to the CGPostMouseEvent function
"in USB device order", which is driver-specific) so I haven't included support
for macOS in this CL.
Note that for this to work, Chrome's --enable-features="ExtendedMouseButtons"
flag must be used, at least until the feature is enabled by default.
Change-Id: I1a890c590b26da8c5f11185a2be68a22c7f06ec2
Reviewed-on: https://chromium-review.googlesource.com/938754
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539469}
Disable ChromeNavigationBrowserTest.BlockLegacySubresources on Mac
Bug:816646
Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb
[email protected]
Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb
Reviewed-on: https://chromium-review.googlesource.com/938365
Reviewed-by: Mohammad Reza Zakerinasab <[email protected]>
Commit-Queue: Mohammad Reza Zakerinasab <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539468}
Remove BrowsingDataRemovalController
BrowsingDataRemovalController is just a thin wrapper around
BrowsingDataRemover. As BrowsingDataRemover is a KeyedService
there is no need for the wrapper anymore.
Convert BrowsingDataRemovalController unit tests to instead
test BrowsingDataRemoverImpl (and fix a potential use after
free of a TaskRunner in the tests).
Bug: none
Change-Id: I59b0da2198f6c0375977436c6bfebc37398d7cf2
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934502
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539467}
aura: Manage the FrameSinkId in aura::Window.
Instead of WindowPortMus and WindowPortLocal managing the FrameSinkId of
a Window separately, manage it in Window itself.
BUG=none
Change-Id: I9fea68af4cc8b2c185fd1ff26e5be5d965b3ab90
Reviewed-on: https://chromium-review.googlesource.com/930663
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539466}
[Password Manager] Expand automated tests coverage for export feature
This CL adds tests for:
* Partial write (insufficient disk space to export)
* Export should be offered only if there are passwords
* Export Passwords menu item opens the export dialog.
* The Try Again button restarts the export
* The start and error dialogs are dismissible.
Bug: 815137
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib8d971ac8eda5824ea80c397bd13a26a36a66277
Reviewed-on: https://chromium-review.googlesource.com/934823
Commit-Queue: Christos Froussios <[email protected]>
Reviewed-by: Hector Carmona <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539465}
Minor refactor of win FontCache::PlatformFallbackFontForCharacter
* Uses early-return style to avoid code reaching to end even if
fonts are found in early stages, primarily for the readability.
* Uses AtomicString(const UChar*) ctor instead of wcslen(). These
are the only place that use wcslen in WebKit/ directory.
Bug: 561873
Change-Id: If403eafaa57a9f00eddf053bb8c6fb1d1343a4a2
Reviewed-on: https://chromium-review.googlesource.com/938687
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539464}
[HttpCache] Clarify some names
Makes the names of a couple of functions clearer.
Change-Id: I8c7923f62b691b3cf93642e54f4afd8cb257c01f
Reviewed-on: https://chromium-review.googlesource.com/937924
Reviewed-by: Shivani Sharma <[email protected]>
Commit-Queue: Josh Karlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539463}
Media Engagement: add UKM metric to carry preloaded information.
Bug: 813905
Change-Id: I7a0954620c62c7553397bdd13250f598589afb33
Reviewed-on: https://chromium-review.googlesource.com/928504
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539462}
Get metrics on the use of cross-origin JavaScript dialogs.
BUG=696454, 802007
Change-Id: I32982c6c34a24f67cfbb7c8fe07b943efaf90822
Reviewed-on: https://chromium-review.googlesource.com/924373
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539461}
[CI] Share invalidation code for geometry presentation attributes
Much like for geometry attributes - of which these are a subset. Also
push the InvalidationGuard into the invalidation function.
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib9254d8ad930ef132c8074a7636eb57f18ae22d5
Reviewed-on: https://chromium-review.googlesource.com/932122
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539460}
Add an IconLoader for Background Fetch.
This takes a url to an icon, and downloads it, in memory. It's not
currently storing it in disk, or resizing it, or even allowing selection
from a list of icons. This functionality will be added later.
And a unit test to verify expected behavior.
Bug: 813564
Change-Id: Ia00945d4f0c5f2b4bccd2fb03dcf289b265af110
Reviewed-on: https://chromium-review.googlesource.com/932121
Commit-Queue: Mugdha Lakhani <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539459}
AW: Remove redundant generate_components_strings dependence
No change to logic.
Bug: None
Change-Id: I3eb4fc82108488ba87b40323e0afa643d9e96e86
Reviewed-on: https://chromium-review.googlesource.com/939003
Reviewed-by: Bo <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539458}
Update Google Update COM interface definitions in google_update_idl.idl.
This update is required for work that is underway related to management
of Chrome browsers for enterprise users.
The google_update_idl.idl file was originally provided by the Google
Update team. It has been modified as described in the README.chromium
file in this CL.
The change was tested with Chrome-branded builds with target_cpu set to
"x86" and "x64". I followed these steps to make sure that this change
does not break Chrome updates.
1. Manully set the version of Chrome in src/chrome/VERSION to a version
prior to that which is currently served on the Dev channel.
2. Compile with is_chrome_branded=true and target_cpu set to one of
"x86" or "x64".
3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit
Win10 machine.
4. Navigate to chrome://help and make sure that the update process works
as expected.
Bug: 796270
Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3
Reviewed-on: https://chromium-review.googlesource.com/924474
Commit-Queue: Ali Tofigh <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539457}
[Autofill] Convert PersonalDataManager to use IdentityManager
The conversion is straightforward, getting the email address of the
primary account from IdentityManager rather than SigninManager and
AccountTrackerService.
Straightforward unittest conversions are also made.
NOTE: This CL was not tested manually as I don't know how to exercise
this functionality.
[email protected]
Bug: 809435
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7e145538b9e8634326a409c812b03a04c0254b05
Reviewed-on: https://chromium-review.googlesource.com/913390
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539456}
[base/task] Create skeleton for base/task.
Create base/task/task_scheduler and base/task/sequence_manager
directories, add OWNERS files and README.md stub.
[email protected]
BUG=783309
Change-Id: Ic30cfac8ce71e5f0553fcfb6c95e05750d15d265
Reviewed-on: https://chromium-review.googlesource.com/934444
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539455}
Add domian info the the profile blocking error page.
Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing
Bug: 803191
Change-Id: Ifdf428b592eb2c7bd497a40044e06a74338a247e
Reviewed-on: https://chromium-review.googlesource.com/938631
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539454}
[WebView] Add support library support for WebViewFactoryProvider.Statics
Static WebView methods are implemented using the class
WebViewFactoryProvider.Statics, in this CL we implement the
corresponding class for the WebView support library.
Bug: 816506
Change-Id: I3909a8f1b78a79ed06895da0611ca643231e1716
Reviewed-on: https://chromium-review.googlesource.com/939391
Reviewed-by: Bo <[email protected]>
Commit-Queue: Gustav Sennton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539453}
Purge more cache data in RenderThreadImpl::ClearMemory
RenderThreadImpl::ClearMemory has been purging only font cache in Skia.
But, it would be good if we purge more cache data in RenderThreadImpl::ClearMemory,
because it has mainly called under out of memory. I found SkGraphics::PurgeAllCaches
purges more cache data, so this CL calls it instead of calling SkGraphics::SetFontCacheLimit.
void SkGraphics::PurgeAllCaches() {
SkGraphics::PurgeFontCache();
SkGraphics::PurgeResourceCache();
SkImageFilter::PurgeCache();
}
Although I add a new test to measure if RenderThreadImpl::ClearMemory purges memory,
it's not completed yet. But, this CL can be covered by tests for MemoryPressureListener.
(i.e, RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure.)
Bug: None
Change-Id: I6d702e02c84a04c98489bc3f20b52f55beed1452
Reviewed-on: https://chromium-review.googlesource.com/910732
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Gyuyoung Kim <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539452}
Fixup of how AutofillClient impls get IdentityManager after r537790
https://chromium-review.googlesource.com/904992 added a new
AutofillClient::GetIdentityManager() interface. That CL mistakenly
had the ChromeAutofillClient and ChromeAutofillClientIOS implementations
return the IdentityManager instance associated with the current Profile.
It should actually be the IdentityManager instance associated with the
*original Profile* (/ChromeBrowserState) to be parallel with those
clients' constructions of the ProfileIdentityProvider instances whose
usage IdentityManager is replacing in //components/autofill.
Note that I verified that these are the only client implementations that
need this fix:
- AWAutofillClient returns nullptr for both the IdentityProvider and the
IdentityManager.
- WebViewAutofillClient (in //ios) doesn't use the original
ChromeBrowserState for anything, I assume because it doesn't have
incognito.
This bug was uncovered by the UBSanVptr bot. Thanks, UBSanVptr bot!
Bug: 798413, 814308
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3e87888bc622204a29b4f9d3990fa39e8b165eb3
Reviewed-on: https://chromium-review.googlesource.com/928654
Reviewed-by: Mathieu Perreault <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539451}
[Dice] Update strings in user menu
This CL updates the promo strings in the user menu for
turning on sync. A new string is added for the case
when there are signed in web accounts.
Bug: 814979
Change-Id: I028514d8894a2f8372784f7ff3a69c34c0573bf0
Reviewed-on: https://chromium-review.googlesource.com/934286
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539450}
Fix <webview> WebRequest + NetworkService
Plumbs through some additional WebRequestInfo fields in the Network
Service path to enable <webview> WebRequest (and declarative WebRequest)
APIs to work as expected.
Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I78eda1c4f286623f1d82e3e5be60dd9beff517bc
Reviewed-on: https://chromium-review.googlesource.com/938675
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539449}
AW: Improve code health for SpellCheck
The CL:
1. Add BUILDFLAG::ENABLE_SPELLCHECK in aw_main_delegate.cc
2. Remove redundant include spellcheck_build_features.h
Bug: None
Change-Id: Idc77171292fd0515240e52d86ac83fbdb4744534
Reviewed-on: https://chromium-review.googlesource.com/939221
Reviewed-by: Bo <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539448}
Relaunch recommended bubble.
This bubble is shown to a user when a relaunch is needed for an update
and the user's administrator has set the RelaunchNotification policy to
1 (recommended). The bubble is shown each time the UpgradeDetector moves
the UpgradeNotificationAnnoyanceLevel to LOW, ELEVATED, or HIGH; and is
shown on a recurring schedule while the level is at or above HIGH.
BUG=511300
Change-Id: Idd235ec0a3bef3b24484ab5cd40cb7b2a28bf450
Reviewed-on: https://chromium-review.googlesource.com/906774
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539447}
Remove subtitle from Clean up computer trigger
With the introduction of the 3p removal trigger, the concern is that
subtitles make the card too heavy, so we are simply removing them.
I will also send a follow-up CL to remove subtitle from the
"Reset settings" trigger. Not sending here, because I want to add other
people on that change for discussion.
Bug: 816666
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iae7c588c72f109e676212ceaf858177b21b22f5d
Reviewed-on: https://chromium-review.googlesource.com/938623
Commit-Queue: Fabio Tirelo <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539446}
Reland: Use StyleForLayoutObject for option to update stacking context.
We used OriginalStyleForLayoutObject which doesn't update animations or
stacking context.
This is a reland of [1] which was reverted because the added unit test
failed on Android because option elements do not create layout objects
with the platform's theme.
[1] https://crrev.com/4b96f800bd6d6c017ac14ab19e7b341c1a6efcc6
Bug: 813348, 813439, 813836
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I55d5f944e86ccaa326f01caa7f48606021f8df14
Reviewed-on: https://chromium-review.googlesource.com/939163
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539445}
Factor out logic from SessionsSyncManager to SyncedSessionTracker
The change makes SessionsSyncManager smaller which is good for our
upcoming changes to introduce an alternative implementation based on
USS.
Bug: 681921
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6e8ed8b3b588b6a8da5e9b6b90be6ed9f479b04c
Reviewed-on: https://chromium-review.googlesource.com/918863
Commit-Queue: Mikel Astiz <[email protected]>
Reviewed-by: Nicolas Zea <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539444}
Disable Export Passwords button in edit mode
Bug: 814574
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I396ff63e3e0d94e635dcf88e2d6bf0b6061e3b10
Reviewed-on: https://chromium-review.googlesource.com/930471
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539443}
Added histogram for events of call API skew shifts in AEC3
The reporting to the histogram is added in the WebRTC CL
https://webrtc-review.googlesource.com/c/src/+/53066.
The metric for the histogram is the amount of skew shifts
detected for each minute in a call. It should be noted that
the metric is also reported for the case where there are 0
skew shifts. Furthermore, the metric is capped to 20 shifts
per minute.
Bug: chromium:814962
Change-Id: Ie6c7bb9b8e43c5b8ca8f77ac45e7b0eb2235aded
Reviewed-on: https://chromium-review.googlesource.com/933201
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Per Åhgren <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539442}
Fix broken forward declaration that introduced a clashing namespace
A forward declaration claimed there was a ::viz::cc:CompositorFrame
class, and that introduction of a namespace ::viz::cc caused
confusion with the ::cc namespace and compilation errors in
some jumbo build configurations.
The real CompositorFrame is in viz::CompositorFrame so fixing
the forward declaration also removed the namespace clash.
Change-Id: I1cd4fe729591855172f5a07aca2e2c7f3e8db9fa
Reviewed-on: https://chromium-review.googlesource.com/939390
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Daniel Bratell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539441}
Refactor default group variation feature association code.
This is a no-op change that paves way for changing the logic
such that multiple features could be associated with a default
group.
Bug: 816696
Change-Id: Ic8f202dcb52316ad2c3e4310c3c0ecac18f092c6
Reviewed-on: https://chromium-review.googlesource.com/938654
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539440}
Add new net error code for legacy Symantec certificates
This CL adds a new net error code for legacy Symantec certificates that are
being distrusted in M66 and M70. The net error code will display on the
interstitial, allowing the specific problem to be diagnosed from just a
screenshot of the interstitial. We can also use it to decide when to put a
console message in DevTools.
Because there is code that maps net error -> CertStatus -> net error, this also
requires a new CertStatus flag for the error.
Bug: 815219
Change-Id: Ic15d6c96f8bdef38c26157af13bbf099fee43b70
Reviewed-on: https://chromium-review.googlesource.com/934969
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539439}
[Payments] Get web app manifest from the main frame's document
Bug: 812297
Change-Id: Iebd00dd49749c279088149b3b7fc6ba79aced58b
Reviewed-on: https://chromium-review.googlesource.com/932748
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539438}
Add Fuchsia to webkitpy's builders.json
So that layout_tests.port.factory can return the correct list of
builders and ports that contain Fuchsia. One use case of these lists is
to get rid of stray expectations after rebaseline (similar to Android).
Bug: 778467
Change-Id: Ia41fba2ea802518ce0d8418a02d07bd26250b5bc
Reviewed-on: https://chromium-review.googlesource.com/938584
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Robert Ma <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539437}
Add a "type" getter to UnderlyingSourceBase
Because UnderlyingSourceBase did not have a "type" getter the type was
inherited from Object.prototype, causing a crash when that returned
something other than "undefined".
BUG=806644
Change-Id: I709dc0469396e350f9494f102398a6d5bb5ff8d5
Reviewed-on: https://chromium-review.googlesource.com/936825
Commit-Queue: Adam Rice <[email protected]>
Reviewed-by: Takeshi Yoshino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539436}
Trigger new linux-blink-incremental-heap-marking bot on changes to master.
[email protected]
Bug: 812533
Change-Id: I575e5215b9fdeed07ff90949e7c637fed5de08b9
Reviewed-on: https://chromium-review.googlesource.com/937981
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539435}
WindowService: nuke ServerWindow::id
And instead have each tree maintain the mapping between client-id and
ServerWindow.
One of the things the id() encoded was the creator. Numerous places
still need that, so I kept it.
BUG=none
TEST=covered by tests
Change-Id: Ie6fc4833ce20a7c05bbe6ee1139ef361320d24d6
Reviewed-on: https://chromium-review.googlesource.com/936426
Reviewed-by: Ria Jiang <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539434}
[Video Capture Win] Add UMA histograms for Windows specific video capture events
This is to enable experiment-controlled rollout of MediaFoundation
based video capture on platforms where it is supported.
Bug: 792640
Change-Id: I325b3112d25b07ac6eb012bd3e8c59aaea131ff1
Reviewed-on: https://chromium-review.googlesource.com/917284
Commit-Queue: Christian Fremerey <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539433}
Changed std::find() to ContainsValue() in src/ash/wm/*
Bug: 561800
Change-Id: I4b851241568d86a10475585130780ad73ebcf4ce
Reviewed-on: https://chromium-review.googlesource.com/934361
Reviewed-by: srirama chandra sekhar <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: srirama chandra sekhar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539432}
Deprecate --h2_on_stream_path_length.
This CL lands server change 185528812 by dahollings.
BUG=488484
Change-Id: I265c7d8354b5258fbbf7d39cb446d3dda4f8c25f
Reviewed-on: https://chromium-review.googlesource.com/937687
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Dianna Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539431}
Add a SpdyMakeUnique use and an include.
This CL lands server change 185561279 by assar.
BUG=488484
Change-Id: I19a1525a9bfb6ec6b7f01ac163b9044f98f4fbd9
Reviewed-on: https://chromium-review.googlesource.com/937690
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Dianna Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539430}
Marked canvas-drawImage-live-video.html as flaky on Mac
[email protected]
No-Try: True
Bug: 816914
Change-Id: Ib62c7af7241350e80c18412b2c898734fe7b9074
Reviewed-on: https://chromium-review.googlesource.com/939470
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539429}
Expose ImageBitmapRenderingContext to users
ImageBitmapRenderingContext is supposed to be shipped in Chrome 55 as stated
in the Chrome Platform Status here:
https://www.chromestatus.com/feature/5709799995998208. However, the code itself
bars this feature from being accessible by users.
Bug: 658734
Change-Id: I7b54bbee58529507411109866885623ef5b7a999
Reviewed-on: https://chromium-review.googlesource.com/938461
Reviewed-by: Justin Novosad <[email protected]>
Commit-Queue: Olivia Lai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539428}
Roll AFDO from 66.0.3355.0_rc-r1 to 66.0.3356.0_rc-r1
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I98b7c3aef6dfc64ba9ddef02305208867ad2ab60
Reviewed-on: https://chromium-review.googlesource.com/938575
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539427}
Make the deprecated fields optional in notifications.mojom
Recently I made some fileds deprecated (crrev.com/c/917845),
in addition, we need to make them optional to remove these fields.
Test None (doesn't change any behavior)
Bug: None
Change-Id: Ic1afc986013fb3f395fd1f1e89f19a9c13852b7a
Reviewed-on: https://chromium-review.googlesource.com/936948
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539426}
Make tools/fuchsia/run-swarmed.py work for win/cross binaries too and move it to tools/
Bug: 816435
Change-Id: Iae8fd393c8fae53387ecf02d5e5779a44dee3030
Reviewed-on: https://chromium-review.googlesource.com/936588
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539425}
[jumbo] followup after 'tracing: Singleton -> NoDestructor and fix TSan test violation'
There are multiple g_instance_for_testing globals after
https://chromium-review.googlesource.com/c/chromium/src/+/935841 - let's
rename one of them to avoid jumbo build breakage.
[email protected]
Bug: 815234,775547
Change-Id: I184578b694e59dad8b06643db199f32820fd5887
Reviewed-on: https://chromium-review.googlesource.com/938821
Commit-Queue: Mostyn Bramley-Moore <[email protected]>
Reviewed-by: Mostyn Bramley-Moore <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539424}
Disable VideoInIFrameAndCloseInSuccessCb browser test
It's also flaky on Android, so disable on all platforms
Bug: chromium:807638
No-Try: True
Change-Id: I0b7dc9cb14198c590538f3a8125e47636fc2c1d7
Reviewed-on: https://chromium-review.googlesource.com/939162
Commit-Queue: Oleh Prypin <[email protected]>
Reviewed-by: Patrik Höglund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539423}
Fix GAIA dialog focus issue when it's displayed with UserManager.
Bug: 816499
Change-Id: Ib3ecf6730908289be6f799c7df39d3667f1552d0
Reviewed-on: https://chromium-review.googlesource.com/937657
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539422}
Revert "cc: Ensure correct scaling for non-lazy images in GPU cache."
This reverts commit 637c7485329228146d8af0555f8473cc9dc21e5b.
Reason for revert: Suspected culprit of consistent Linux MSan Tests failures of GpuImageDecodeCacheTest.NonLazyImageUploadDownscaled since
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/8195
Original change's description:
> cc: Ensure correct scaling for non-lazy images in GPU cache.
>
> When using a non-lazy (bitmap) image in the GPU cache, we assume the
> upload to be scaled at the mip-level required for draw, when we
> actually use the original image for the upload. Fix this by considering
> non-lazy scaled images as lazy generated. This also ensures we use
> lower gpu memory, by caching downscaled uploads.
>
> R=[email protected]
>
> Bug: 815045, 814219
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I4b7d3f4edbcf0e5ba5574512f662a3fdf53cabd6
> Reviewed-on: https://chromium-review.googlesource.com/935441
> Reviewed-by: Zhenyao Mo <[email protected]>
> Reviewed-by: Eric Karl <[email protected]>
> Commit-Queue: Khushal <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539276}
[email protected],[email protected],[email protected]
Change-Id: I441305f1ebfa962b3a78e5fa53f2169996fae196
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 815045, 814219
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/939361
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539421}
Marked many external/wpt/css/css-text/ tests as flaky.
[email protected]
No-Try: True
Bug: 816868
Change-Id: I0ccb2fa2ad89e2dfcbfb8e15e2dfb8fbc1e8e85b
Reviewed-on: https://chromium-review.googlesource.com/939176
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539420}
Revert "[heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot."
This reverts commit d690c63866704bb7896b89ddb5b6b3452baf28c6.
Reason for revert: Suspect for Linux MSAN bot consistent failures, first one being:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/6338
Original change's description:
> [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot.
>
> Each DOM node has a corresponding JS wrapper node. In heap snapshot
> they appear as duplicates.
>
> Example retaining path with duplicates:
> - [1] in InternalNode @2041178784
> - [1] in HTMLDivElement @2041079168 // DOM node
> - [3] in HTMLDivElement @2231 // JS wrapper
> - retainer in Window / @2105
>
> The heap snapshot generator now can merge an embedder node with a node
> returned by EmbedderGraph::Node::WrapperNode() function.
>
> This patch implements the WrapperNode() function for each DOM node.
>
> Bug: chromium:811925
> Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019
> Reviewed-on: https://chromium-review.googlesource.com/928503
> Reviewed-by: Michael Lippautz <[email protected]>
> Commit-Queue: Ulan Degenbaev <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#539132}
[email protected],[email protected],[email protected]
Change-Id: If05b23d13bb68f0dc870cc047b399ed43c4472f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:811925
Reviewed-on: https://chromium-review.googlesource.com/939341
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539419}
Format ShellExecuteEx call in notification_activator.cc
Bug: 734095
Change-Id: Ia29c55079a1fa0be50ef2053636b63288c0d92d6
Reviewed-on: https://chromium-review.googlesource.com/938656
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539418}
Roll src/third_party/depot_tools/ 6f83031f3..9b4d0c771 (1 commit)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f83031f3d0e..9b4d0c77152a
$ git log 6f83031f3..9b4d0c771 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 machenbach Gerrit: Enable overriding step_test_data
Created with:
roll-dep src/third_party/depot_tools
The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I382596c11e2071152e364f82e7a9be49f1c410d5
Reviewed-on: https://chromium-review.googlesource.com/938975
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539417}
[Dice] Adjust accounts submenu positioning
This CL adjusts the accounts submenu positioning
relative to the anchor and sets a fixed size
according to the mocks under:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr6-WzjO3kn_RsRHBgUr2ucD8
Screenshots:
https://drive.google.com/file/d/1ID5ydvPqe2Ivkyg8nxJz3Ckb5nQQtKJD/view?usp=sharing
https://drive.google.com/file/d/1-4d6qWLvfJ1-_mFZZEjO6FZBXzizY-p_/view?usp=sharing
Screenshot in RTL mode:
https://drive.google.com/file/d/1yrQdgq9ANVFV1K-AfdzSpe4b90esRJGx/view?usp=sharing
Bug: 814809
Change-Id: Id36f2443b6a7cc68a026006273daf96c659ebe71
Reviewed-on: https://chromium-review.googlesource.com/934247
Reviewed-by: Trent Apted <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539416}
[CFI] Make icall bot follow clang ToT
Some recent breaking changes have caused the icall bot to be red for
extended periods of time, make it follow ToT so it gets fixes more
quickly.
Change-Id: Ie927fddaf8fb2ac25f60fdf6c59c02a47be4852c
Reviewed-on: https://chromium-review.googlesource.com/938484
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Peter Collingbourne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539415}
Enable Speedometer2-future on Linux and Windows
[email protected]
Bug: 792495, 784025
Change-Id: I05345c81f31b30418eb0bf76da1e2c52f0dc0f54
Reviewed-on: https://chromium-review.googlesource.com/937519
Reviewed-by: Ned Nguyen <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539414}
Remove use of ClearBrowsingDataCommand
Introduce a new protocol BrowsingDataCommands that can be
implemented by the dispatcher. Modify code using the old
command ClearBrowsingDataCommand to instead use this new
protocol as a dispatcher.
Bug: 738881
Change-Id: I76b8650c6c9d4311a611980dc26c8850c4960d5b
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934501
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539413}
cros: Remove deprecated CR_DEFINE_STATIC_LOCAL in KSV.
This cl removes the deprecated CR_DEFINE_STATIC_LOCAL in Keyboard
Shortcut Viewer (KSV). It is now using NoDestructor.
Bug: 768932
Test: Passed all unittests.
Change-Id: I4872fe4cb6994592e93ed907d621194f99ad12a8
Reviewed-on: https://chromium-review.googlesource.com/938664
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539412}
Not wait after timeout in cluster telemetry leak detector
This CL removes additional wait after timeout exception in CT leak detector.
Change-Id: I1c7ce71f96803860da9dbe92ac09c8e94098fd89
Reviewed-on: https://chromium-review.googlesource.com/936926
Commit-Queue: Yuzu Saijo <[email protected]>
Reviewed-by: Keishi Hattori <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539411}
Pass a task runner to mojo::SimpleWatcher at web_service_worker_installed_scripts_manager_impl.cc
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.
This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's
default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get()
in content/renderer because it usually is not the right task runner to use,
as a per-frame runner should be used instead. In this case, it doesn't
really matter since frames are not involved, but we still want to remove the
calls for the bigger benefit of banning it in content/renderer.
Bug: 780785, 786332
Change-Id: I307cd4923912809b0577074585ea9fd953a84ef3
Reviewed-on: https://chromium-review.googlesource.com/937104
Commit-Queue: Hajime Hoshi <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539410}
Automated Commit: Committing new LKGM version 10442.0.0 for chromeos.
[email protected]
Change-Id: I1e9d00de8034299cfade38e3ab1ce4848c62000c
Reviewed-on: https://chromium-review.googlesource.com/938777
Reviewed-by: ChromeOS Commit Bot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539409}
Disable reddit in leak detection
This CL removes reddit from leak detection url set because it has been flakily failing because of time-outs.
Change-Id: If845aecb5414200fcc0aae75be9a523c65e42680
Reviewed-on: https://chromium-review.googlesource.com/936826
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Yuzu Saijo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539408}
v8binding: Supports "callback this value" in callback interfaces.
Makes callback interface's operations support "callback this value".
Also supports |InvokeAndReportException| member function as same as
callback function does. The member function is defined only when
there is a single operation (without any overload) and its return
type is |void| (otherwise, the call sites must check the return value).
Bug: 778580
Change-Id: I9e9b1e6eaf53d45356d7374963c14c321378af00
Reviewed-on: https://chromium-review.googlesource.com/936930
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539407}
FrameFetchContext: add clear comments on what the requestor origin is
To clarify what the requestor origin in Blink is, let me add some
comments in FrameFetchContext.
Change-Id: I32e8b45dc5189e773a02466960cce7e9c45292b9
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/937042
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539406}
Roll src/third_party/pdfium/ 0bc02c152..821c7236c (2 commits)
https://pdfium.googlesource.com/pdfium.git/+log/0bc02c152bd0..821c7236cea9
$ git log 0bc02c152..821c7236c --date=short --no-merges --format='%ad %ae %s'
2018-02-26 tsepez Shrink some tables and kill dead code in xfa.
2018-02-26 tsepez Get rid of some static variables.
Created with:
roll-dep src/third_party/pdfium
The AutoRoll server is located here: https://pdfium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iaf3a18e1bc49d87c7c53a77a62345b6beae05af0
Reviewed-on: https://chromium-review.googlesource.com/938630
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539405}
VR: Enable web input editing by default
Bug: 933701
Change-Id: I584d363a3f3fe88dcaf68291105bf73bd8d02de9
Reviewed-on: https://chromium-review.googlesource.com/934630
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Nick Carter <[email protected]>
Commit-Queue: Yash Malik <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539404}
[auto] Update FlagExpectations for LayoutNG
Following bot results are included.
3943 3944 3947 3948 3953 3955 3958 3961 3964
1 lines were removed and 26 lines were deflaked by consecutive results
since 3901.
[email protected]
NOTRY=true
Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I25713f3ae0713ad284c455eb10b67e808ef4e1e7
Reviewed-on: https://chromium-review.googlesource.com/936885
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539403}
[Blobs] Add minimal MemoryDumpProvider integration.
The Blob system can allocate a lot of memory, so we should integrate
with MemoryDumpProvider infra to account for this usage.
Bug: 813046
Change-Id: Ifabb469c36afb68df3031fe6660a76a97274950b
Reviewed-on: https://chromium-review.googlesource.com/938761
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539402}
Revert "[SPv175] Enable SlimmingPaintV175 by default"
This reverts commit 0a9a5c311a1d3a298f952e495510bd6fe3faa2f6.
Reason for revert: We decided to delay the launch of SlimmingPaintV175
to M67, so that we have more time to fix the regressions.
The revert CL is slightly modified so that later enabling/disabling of
SlimmingPaintV175 by default can just change one line in
content/public/common/content_features.cc (learnt from
RootLayerScrolling crrev/c/929662).
Original change's description:
> [SPv175] Enable SlimmingPaintV175 by default
>
> SlimmingPaintV175 enables raster invalidation and paint chunks based
> on paint properties. See crbug.com/771643.
>
> Bug: 771643
> Change-Id: I5fdbcabc7ca0f2fa8e69ae0fbf5a0077bba46cfe
> Reviewed-on: https://chromium-review.googlesource.com/923572
> Reviewed-by: Antoine Labour <[email protected]>
> Reviewed-by: Chris Harrelson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#537454}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 771643
Change-Id: I04177ada5d6b133fe47c0e0dbff42b6989f099ba
Reviewed-on: https://chromium-review.googlesource.com/938562
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539401}
Use no_symbols config linux_chromium_rel_ng builder
This is revert of https://crrev.com/c/892187 and change config to use no_symbols explicitly for linux_chromium_rel_ng builder.
Bug: 794423
Change-Id: I557b114292fd79e959140913f3077fd735dbdb5f
Reviewed-on: https://chromium-review.googlesource.com/938883
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539400}
MD Extensions: in keboard shortcuts extensions settings, set extension
icon size to 20x20, align text
Bug: 794275
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7bdaf43dce5074c4b758d27ae47afb54b1d2750
Reviewed-on: https://chromium-review.googlesource.com/937961
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Esmael El-Moslimany <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539399}
Updating trunk VERSION from 3356.0 to 3357.0
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: I72195ce2a1caad79fa2e06ec80c0b5a025939301
Reviewed-on: https://chromium-review.googlesource.com/938774
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539398}
Set the overlay content view height right
Overlay content view height should have taken the toolbar
into account to show the content. Incorrect height caused
the reported bug not showing the bottom part of the content.
Note that physical backing size doesn't need this but
should always be set to the full content view size.
Bug: 815052
Change-Id: Ia5cd8f24f72e507c0537c586b7b1c8244ca51a3c
Reviewed-on: https://chromium-review.googlesource.com/936823
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539397}
ash: Report Ash.TouchView.LidAngle histogram.
Update ash::TabletModeController to report a new histogram
containing the computed lid angle once per hour. (Note that
the computed angle is often inaccurate by tens of degrees.)
Also change "tabletmode" in a few members to "tablet_mode"
(this looks like an earlier search-and-replace bug) and
initialize POD members in the header.
Bug: 814363
Change-Id: I5066fb6e859a34343506f88453845156186b81b3
Reviewed-on: https://chromium-review.googlesource.com/933732
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Qiang Xu <[email protected]>
Commit-Queue: Dan Erat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539396}
Use the shared instance of base::Default{,Tick}Clock in safe_browsing
This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.
After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.
Bug: 789079
Change-Id: I992b13352a6fa1028bd8eeb2223056cc2cecf610
Reviewed-on: https://chromium-review.googlesource.com/900882
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Taiju Tsuiki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539395}
wallpaper refactoring: Deprecate WallpaperDelegate
Bug: 557405
Change-Id: Ic11363ce6a48288ebce37bdc388abd658c1a347b
Reviewed-on: https://chromium-review.googlesource.com/854950
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539394}
Roll Fuchsia SDK to 739d1fd10565f97bacae8215903403b2677d8f48.
- Removes sys/resource.h, requiring some additional conditionals around
includes of that header under OS_POSIX.
- Improves the system PRNG implementation to reduce the potential for
lock contention.
We also clean up some test filter entries that either no longer refer
to an existing test, or are no longer required.
Bug: 707030, 801353, 809660, 738275
Change-Id: Ic1f49625f20f2efc6c2509cf0f1fa8265d4e9f7f
Reviewed-on: https://chromium-review.googlesource.com/932822
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Eric Roman <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539393}
desktop-pwas: Always show an interstitial if in an app window
This covers the case where a user proceeded through an
interstitial in the past and then opened the app. In a regular tab,
we wouldn't show the interstitial but since Desktop PWAs always have
to be secure we show an interstitial.
Bug: 779857
Change-Id: I0efef48f38ef51d7e5016be07829971d44656e6c
Reviewed-on: https://chromium-review.googlesource.com/936922
Reviewed-by: Emily Stark <[email protected]>
Commit-Queue: Giovanni Ortuño Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539392}
Rebaseline virtual/layout_ng/fast/block/float/float-avoidance.html
Is failing on Mac10.10 and Mac10.11.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Flayout_ng%2Ffast%2Fblock%2Ffloat%2Ffloat-avoidance.html
Probable cause:
https://chromium-review.googlesource.com/937261
NOTRY=true
Change-Id: I6ff55eeeab203f0e6561fec8b3673d2f1da4eab2
Bug: 816757
Reviewed-on: https://chromium-review.googlesource.com/938981
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539391}
Disable cronet_tests on Fuchsia (dbg).
These tests expect that library-global and test-process-global state is
independent, which is not the case in component builds where critical
subcomponents such as //base and //net are shared.
TBR: jbudorick
Bug: 816705, 808075
Change-Id: I1ca3f670d472d588b3fabc584b6eaa7ce1f08de2
Reviewed-on: https://chromium-review.googlesource.com/938680
Reviewed-by: Wez <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539390}
Android: Remove extensions tests from disabled list.
They are no longer built.
Change-Id: I04ec357e4a1aef02ae9082920f4e389a63899bc0
Reviewed-on: https://chromium-review.googlesource.com/936049
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539389}
WebUI: Update Polymer iron-autogrow-textarea version 1.0.13 -> 2.1.1
Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I03971f6770bd35264d2162d93f5a9dcaa239c864
Reviewed-on: https://chromium-review.googlesource.com/938632
Reviewed-by: Hector Carmona <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539388}
[LayoutNG] Update list/README.md
This CL updates layout/ng/list/README.md to catch up changes in
CL:925381.
NOTRY=true
Bug: 725277
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id67584e531b1e1229f4f12e6a336881dddee76bf
Reviewed-on: https://chromium-review.googlesource.com/938102
Reviewed-by: Aleks Totic <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539387}
cros: Add high resolution suffix for surprise me wallpapers
Bug: 815310
Test: Turn on "Enable new wallpaper picker" in chrome://flags
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1907d83d5961c57413d4a5e2050e00680889f5b
Reviewed-on: https://chromium-review.googlesource.com/935754
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539386}
Fix SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone.
In Viz hit-test, when we set "pointer-events: none;" to an OOPIF, we
fall back to the slow-path targeting because all OOPIFs have
kHitTestAsk flag set, which means we should still get the right target
even though HitTestQuery doesn't know about "pointer-events: none;" at
all.
This CL adds an InputEventAckWaiter in the test to wait for async
targeting results. We didn't have to wait in current targeting because
SurfaceHittest skips OOPIFs with "pointer-events: none;". If there's
a regression (this case should be rare), we can have HitTestQuery
asking RenderWidgetHostInputEventRouter for this information like
what SurfaceHittest is doing right now.
Bug: 812012
Test: SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone/1
Change-Id: Ia13979750a87a37fd4a65b98f5951f11c097148e
Reviewed-on: https://chromium-review.googlesource.com/938483
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Ria Jiang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539385}
Roll src/third_party/skia/ 9d57afd93..c657fa6d4 (6 commits)
https://skia.googlesource.com/skia.git/+log/9d57afd93e70..c657fa6d44d3
$ git log 9d57afd93..c657fa6d4 --date=short --no-merges --format='%ad %ae %s'
2018-02-26 benjaminwagner Switch Win10 NUC6i5SYK to new image.
2018-02-26 egdaniel Fix height calculation when doing copyImageToBuffer
2018-02-26 mtklein which readpixels test is failing?
2018-02-26 mtklein make 1010102/888x layers 8888, not 1010102/888x
2018-02-26 bsalomon Start on new GPU pixel ops implementation.
2018-02-26 egdaniel Add cap workarounds for possible arm bugs
Created with:
roll-dep src/third_party/skia
The AutoRoll server is located here: https://autoroll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Change-Id: I2ded94e43f9dde97c106ff2974dc5b44f25a01d1
Reviewed-on: https://chromium-review.googlesource.com/938846
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539384}
Add source field and more reason values to offline page header
Reason::NOTIFICATION is added to prepare for differentiating between
clicking a notification and clicking an item in Downloads home.
Reason::FILE_URL_INTENT and Reason::CONTENT_URL_INTENT are added to prepare
to support handling intent to show MHTML file or content. "intent_url"
field is also added for this purpose.
This patch only updates the header parsing and formatting. The new
additions are not used yet.
Bug: 758690
Change-Id: Ibdcae9bdb468e96226387801c6220039476af51e
Reviewed-on: https://chromium-review.googlesource.com/932749
Commit-Queue: Jian Li <[email protected]>
Reviewed-by: Dmitry Titov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539383}
Remove GetKeyDataEx from HomedirMethods.
Bug: 741274
Change-Id: I8233e0cbc063642ebc8a876ad6a39d7905f2e927
Reviewed-on: https://chromium-review.googlesource.com/927936
Reviewed-by: Ryo Hashimoto <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Maajid <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539382}
Remove virtual baselines for virt../prefer.../.../tiled-mask.html
This patch removes the virtual baselines for the following test:
virtual/prefer_compositing_to_lcd_text/compositing/overflow/tiled-mask.html
Bug: 417782
Change-Id: Iaeb7d67c7b74009f43bf4239600b5c4209cff4a0
Reviewed-on: https://chromium-review.googlesource.com/938668
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Philip Rogers (OOO) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#539381}