Publish DEPS for Chromium 65.0.3325.106

• DEPS[diff]

Incrementing VERSION to 65.0.3325.106

[email protected]

Change-Id: I44d337b2dbdfe3e01901653252279f984834deb1
Reviewed-on: https://chromium-review.googlesource.com/940343
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#616}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Fix CreateAnonymousSharedMemory() not to leak FILE when returning fd.

CreateAnonymousSharedMemory() was modified to return the writable memory
handle as a file-descriptor rather than as a FILE. Since POSIX does not
provide a standard way to teardown a FILE without also close()ing the
underlying file-descriptor, this was achieved by leaking the FILE.

We now provide CreateAndOpenFdForTemporaryFileInDir(), to avoid the need
to wrap the temporary-file descriptor into a FILE at all.

Bug: 814444, 736452
Change-Id: Idd911f50f0e506de3eac91c809efb6c6d59fec10
Reviewed-on: https://chromium-review.googlesource.com/930336
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538599}(cherry picked from commit 45a7b305282b175e11c871c1a8ac3b8336c66259)
Reviewed-on: https://chromium-review.googlesource.com/940163
Reviewed-by: Wez <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#615}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• base/files/file_util.h[diff]
• base/files/file_util_posix.cc[diff]
• base/memory/shared_memory_helper.cc[diff]

Incrementing VERSION to 65.0.3325.105

[email protected]

Change-Id: I18a4a667fbfef34bc52c9418212a4ff7442ff6df
Reviewed-on: https://chromium-review.googlesource.com/940482
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#614}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Network config: Show error messages in button container

This CL:
* Moves the 'error' message display to the host dialogs so that it
  can be displayed in the button container which is always shown at
  the bottom of the dialog.
* Eliminates the 'Connecting' message which is no longer necessary
  since we now close the dialogs as soon as the asynchronous
  connection attempt starts.

[email protected]

(cherry picked from commit 0f54d8999aa322ffb5b58b103c1b24ea1529fecf)

Bug: 812477
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5fa17ed3b568f689bd76c71b9a921010a81bf56e
Reviewed-on: https://chromium-review.googlesource.com/922795
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Kevin Cernekee <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538341}
Reviewed-on: https://chromium-review.googlesource.com/940430
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#613}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html[diff]
• chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js[diff]
• chrome/browser/resources/settings/internet_page/internet_config.html[diff]
• chrome/browser/resources/settings/internet_page/internet_config.js[diff]
• ui/webui/resources/cr_components/chromeos/network/network_config.html[diff]
• ui/webui/resources/cr_components/chromeos/network/network_config.js[diff]

Disable runtime feature CompositeOpaqueFixedPosition

The feature caused performance regression on low dpi devices when a
fix positioned element contains too many children.

Temporarily disble it to unblock Stable release. Will address it through
https://crbug.com/816937.

Bug: 814673
Change-Id: I6f0fea7d6b61f572b4d8da4e54c34d63cc5bc2f1
Reviewed-on: https://chromium-review.googlesource.com/939585
Commit-Queue: Yi Gu <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539552}(cherry picked from commit fc95fed8a9e4cadd5842241b0bb93a9991ff0021)
Reviewed-on: https://chromium-review.googlesource.com/939653
Reviewed-by: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#612}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/child/runtime_features.cc[diff]
• content/public/common/content_features.cc[diff]

Adding back stale previews functionality

This was unintentionally removed, and needs to be added back. In the
future, this might move to DataReductionProxyData.

Bug: 813948
Change-Id: Iee0b5c16fc99860a9682804d1948651b434ab7ea
Reviewed-on: https://chromium-review.googlesource.com/927749
Commit-Queue: Ryan Sturm <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538847}(cherry picked from commit 97ba93d3e446d69e3b4311d604e1c027eacf84e9)
Reviewed-on: https://chromium-review.googlesource.com/939651
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#611}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/previews/previews_infobar_tab_helper.cc[diff]

Fix tabs sharing TEXTURE_2D_ARRAY/TEXTURE_3D data.

In linux and android, we are seeing an issue where texture data from one
tab overwrites the texture data of another tab. This is happening for apps
which are using webgl2 texture of type TEXTURE_2D_ARRAY/TEXTURE_3D.
Due to a bug in virtual context save/restore code for above texture formats,
the texture data is not properly restored while switching tabs. Hence
texture data from one tab overwrites other.

This CL has fix for that issue, an update for existing test expectations
and a new unit test for this bug.


Bug: 788448
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie933984cdd2d1381f42eb4638f730c8245207a28
Reviewed-on: https://chromium-review.googlesource.com/930327
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539111}(cherry picked from commit d128139d53e9268e87921e82d89b3f2053cb83fd)
Reviewed-on: https://chromium-review.googlesource.com/939878
Cr-Commit-Position: refs/branch-heads/3325@{#610}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• gpu/command_buffer/service/context_state.cc[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc[diff]
• gpu/command_buffer/tests/gl_manager.cc[diff]
• gpu/command_buffer/tests/gl_manager.h[diff]
• gpu/command_buffer/tests/gl_virtual_contexts_unittest.cc[diff]

Delete delegates in WindowState when window is being destroyed

Pinned app can request restore during destruction, (which itself
shouldn't happen), but the windowstate should also have a safe guard
by deleting delegate when being deleted.

BUG=811398
TEST=covered by unit tests

Change-Id: I4de6608e97dcf9e48531d31b07a530c10ef68978
Reviewed-on: https://chromium-review.googlesource.com/929315
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538262}(cherry picked from commit 64bf482feb86ae02503c588cad1cb56e46c31b1d)
Reviewed-on: https://chromium-review.googlesource.com/939921
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#609}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ash/wm/client_controlled_state.cc[diff]
• ash/wm/client_controlled_state.h[diff]
• ash/wm/client_controlled_state_unittest.cc[diff]
• ash/wm/screen_pinning_controller.cc[diff]
• ash/wm/window_state.cc[diff]
• ash/wm/window_state.h[diff]

Fix build broken by cherry-pick.

Bug: 816972
Change-Id: I3045e5099cc6b454573dbd217d4d7a667e7d8d22
Reviewed-on: https://chromium-review.googlesource.com/939825
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#608}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp[diff]
• third_party/WebKit/Source/core/html/media/HTMLMediaElement.h[diff]

DevTools: fix rule insertion with file URLs.

This patch allows accessing rules for inspector style sheets.
Our tests didn't catch the regression since we run with
--allow-file-access-from-files flag.

[email protected]

(cherry picked from commit 8a4ccd6b71037a1452a2cb2466029e1cb17eed48)

Bug: 814937
Change-Id: I58eabb8e299a81c5a912d5a42175ab78ad904704
Reviewed-on: https://chromium-review.googlesource.com/935749
Reviewed-by: Rune Lillesveen <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539166}
Reviewed-on: https://chromium-review.googlesource.com/939763
Cr-Commit-Position: refs/branch-heads/3325@{#607}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/core/css/CSSStyleSheet.cpp[diff]

images: Fix image animations for images with specific loop count.

For an image with a repetition count of n, it should animate for
n+1 loops. But the compositor only performs n loops. Fix this by
specifying the actual repetition count of PaintImage.

[email protected]
[email protected]

(cherry picked from commit 644b058c04c5a38e758f07832323f104c12443ad)

Bug: 815038
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I450d435ed38a3beba30276fa4dbabdcb5a68a944
Reviewed-on: https://chromium-review.googlesource.com/934968
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539238}
Reviewed-on: https://chromium-review.googlesource.com/939529
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#606}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/LayoutTests/images/resources/three-frames_loop-three-times.gif[Added - diff]
• third_party/WebKit/Source/platform/graphics/BitmapImage.cpp[diff]
• third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp[diff]

HTMLMediaElement: set `muted_` when cloning element with muted attribute.

This CL works around the fact that cloning does not call the parser
callbacks and the HTML specifications require the attribute to only
have an effect when the element was created. There is unfortunately
no notification that the element creation from `cloneNode()` happens
so we instead rely on a callback meant for something slightly different.

Bug: 811743
Change-Id: Ib7ac55088b9eaad23f9bce0cfc8366fec6fc5b0d
Reviewed-on: https://chromium-review.googlesource.com/937504
Commit-Queue: Mounir Lamouri <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539207}(cherry picked from commit 0d23cbfab31479d700140aa5d26d70d857f7be48)
Reviewed-on: https://chromium-review.googlesource.com/939561
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#605}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/user-interface/muted.html[diff]
• third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp[diff]
• third_party/WebKit/Source/core/html/media/HTMLMediaElement.h[diff]

Revert "Remove profile info cache entry on user removal on Chrome OS."

This reverts commit b228999b998658b6b91fa0399f08110fb69e9250.

Reason for revert: This broke build:
profile_info_cache.cc:758:26: error: no member named 'kUserNameKey' in 'ProfileAttributesEntry';

Original change's description:
> Remove profile info cache entry on user removal on Chrome OS.
> 
> Chrome OS removes users when profiles are not loaded, and Chrome does not know
> the exact profile path until it is mounted. So we need to be able to remove
> entries from ProfileInfoCache based solely on AccountId.
> 
> This Cl implements removal of cache entries given the AccountId and engages it
> on Chrome OS.
> 
> [email protected]
> 
> (cherry picked from commit 4084f503be1913290db968dc81f6ceb9fe796fbc)
> 
> Bug: 808125
> Change-Id: I9f8e3a5f1004d119425b92a4bdc3d8011a526dd5
> Reviewed-on: https://chromium-review.googlesource.com/905751
> Reviewed-by: anthonyvd <[email protected]>
> Reviewed-by: Bernhard Bauer <[email protected]>
> Commit-Queue: Alexander Alekseev <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#537905}
> Reviewed-on: https://chromium-review.googlesource.com/938571
> Reviewed-by: Alexander Alekseev <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3325@{#603}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

[email protected],[email protected],[email protected]

Change-Id: Iec63e9155c5b735259873a3109fa6bbf89a4f889
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808125
Reviewed-on: https://chromium-review.googlesource.com/939241
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#604}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc[diff]
• chrome/browser/profiles/profile_attributes_storage.h[diff]
• chrome/browser/profiles/profile_info_cache.cc[diff]
• chrome/browser/profiles/profile_info_cache.h[diff]
• chrome/browser/profiles/profile_info_cache_unittest.cc[diff]

Remove profile info cache entry on user removal on Chrome OS.

Chrome OS removes users when profiles are not loaded, and Chrome does not know
the exact profile path until it is mounted. So we need to be able to remove
entries from ProfileInfoCache based solely on AccountId.

This Cl implements removal of cache entries given the AccountId and engages it
on Chrome OS.

[email protected]

(cherry picked from commit 4084f503be1913290db968dc81f6ceb9fe796fbc)

Bug: 808125
Change-Id: I9f8e3a5f1004d119425b92a4bdc3d8011a526dd5
Reviewed-on: https://chromium-review.googlesource.com/905751
Reviewed-by: anthonyvd <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537905}
Reviewed-on: https://chromium-review.googlesource.com/938571
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#603}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc[diff]
• chrome/browser/profiles/profile_attributes_storage.h[diff]
• chrome/browser/profiles/profile_info_cache.cc[diff]
• chrome/browser/profiles/profile_info_cache.h[diff]
• chrome/browser/profiles/profile_info_cache_unittest.cc[diff]

[M65] media: handle StopAndDeAllocate after suspend correctly

Some application (e.g. Hangouts) closes the camera explicitly on system
suspend. As the Chrome OS VCD also closes the camera on system suspend
without going through the full destruction of the VideoCaptureDevice,
this results in StopAndDeAllocate being called back-to-back. The second
call to StopAndDeAllocate should simply return if the device context is
already destroyed.

BUG=b:73436939
TEST=unit tests
TEST=Verify that Hangouts call works correctly on Soraka when system
     suspends

Change-Id: Id6127b751ccc5bc71538d622bc0905bf03951e0d
Reviewed-on: https://chromium-review.googlesource.com/930605
Reviewed-by: Wu-Cheng Li <[email protected]>
Commit-Queue: Ricky Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539091}(cherry picked from commit 7b94276046ba4b6fd719f07706fa102a62a5c366)
Reviewed-on: https://chromium-review.googlesource.com/939061
Reviewed-by: Ricky Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#602}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• media/capture/video/chromeos/camera_device_delegate.cc[diff]
• media/capture/video/chromeos/camera_device_delegate.h[diff]
• media/capture/video/chromeos/camera_device_delegate_unittest.cc[diff]
• media/capture/video/chromeos/video_capture_device_arc_chromeos.cc[diff]

Incrementing VERSION to 65.0.3325.104

[email protected]

Change-Id: I2c40165b1c58a31d037bdbca51e0b866b218bb74
Reviewed-on: https://chromium-review.googlesource.com/938770
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#601}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.103

[email protected]

Change-Id: Ibd09090ee20069a5a3da4cef09bdccee74d334b1
Reviewed-on: https://chromium-review.googlesource.com/938768
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#600}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

M65: Fix child process leaks in the Cloud Print Connector.

Before r526819, the utility process performing the PDF to EMF conversion
disconnects itself. Its ServiceUtilityProcessHost notices the
disconnection and deletes itself. With r526819, the utility process no
longer disconnects itself, and waits forever for its host to tear down
the connection.

Meet this new expectation and tear down the connection from the host
side.

BUG=814984
[email protected]

(cherry picked from commit 6064af4e953d2f127e87101878fe464d63082aa7)

Change-Id: I505673a82eb4748898819c6664802238738443bb
Reviewed-on: https://chromium-review.googlesource.com/935631
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538959}
Reviewed-on: https://chromium-review.googlesource.com/938670
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#599}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/service/cloud_print/print_system_win.cc[diff]
• chrome/service/service_utility_process_host.cc[diff]
• chrome/service/service_utility_process_host.h[diff]

M65: Give "service" process its own Service Manager(s)

The cloud print proxy process (i.e. legacy "service" process) may launch
utility processes to do some out-of-process work. These utility
processes behave much like utility processes launched by the browser
process, and occasionally they request an interface from the browser in
order to get some work done.

Font caching behavior on Windows is exposed by the browser and is
sometimes needed from utility processes launched by the cloud print
process, but we don't currently have any way for the cloud print process
to expose interfaces back to utility processes. Such interface requests
will instead be silently ignored.

This CL gives every ServiceUtilityProcessHost its own isolated Service
Manager instance which knows how to route interface requests between the
service process and the single utility process launched by that host.
This in turn allows us to reuse common host interface registration
code to expose some interfaces from the service process.

[email protected]

Bug: 813101
Change-Id: I763033215d13535ba545ded7ef7e22fe5484b414
Reviewed-on: https://chromium-review.googlesource.com/924985
Commit-Queue: Ken Rockot <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538617}
Reviewed-on: https://chromium-review.googlesource.com/933873
Cr-Commit-Position: refs/branch-heads/3325@{#598}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/service/BUILD.gn[diff]
• chrome/service/DEPS[diff]
• chrome/service/service_utility_process_host.cc[diff]
• chrome/service/service_utility_process_host.h[diff]
• content/browser/renderer_host/render_message_filter.cc[diff]
• content/browser/service_manager/common_browser_interfaces.cc[diff]
• content/child/child_thread_impl.h[diff]
• content/common/BUILD.gn[diff]
• content/common/font_cache_dispatcher_win.cc[diff]
• content/public/common/BUILD.gn[diff]
• content/public/common/font_cache_dispatcher_win.h[Renamed from content/common/font_cache_dispatcher_win.h - diff]
• content/public/common/font_cache_win.mojom[Renamed from content/common/font_cache_win.mojom - diff]

Updating XTBs based on .GRDs from branch 3325

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife669802fcfb6cd39a429b72c01309bfbdb5d0a0
Reviewed-on: https://chromium-review.googlesource.com/937998
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#597}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/android/java/strings/translations/android_chrome_strings_de.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_pl.xtb[diff]
• chrome/app/resources/chromium_strings_tr.xtb[diff]
• chrome/app/resources/generated_resources_cs.xtb[diff]
• chrome/app/resources/generated_resources_en-GB.xtb[diff]
• chrome/app/resources/generated_resources_pl.xtb[diff]
• chrome/app/resources/generated_resources_pt-PT.xtb[diff]
• chrome/app/resources/generated_resources_sw.xtb[diff]
• chrome/app/resources/generated_resources_tr.xtb[diff]
• chrome/app/resources/google_chrome_strings_tr.xtb[diff]
• components/policy/resources/policy_templates_ca.xtb[diff]
• components/strings/components_strings_de.xtb[diff]
• components/strings/components_strings_es.xtb[diff]
• components/strings/components_strings_fil.xtb[diff]
• components/strings/components_strings_pl.xtb[diff]
• components/strings/components_strings_sw.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_de.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_pl.xtb[diff]

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

Bug: 800781
Change-Id: I901dc9287e235281cc6892c3aab9b499bfc5f762
Reviewed-on: https://chromium-review.googlesource.com/937401
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#596}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc[diff]

[scheduler] Prevent deadlock when posting a task from task destructor.

When TaskQueueManager was shutdown, posted closure will be destroyed
synchronously. When a closure owns an object, the destructor of this object
may try to post a task. If the task is destroyed while holding scheduler locks,
it may result in deadlocks.

[email protected], [email protected]
[email protected]

(cherry picked from commit 021a4bf395642491d7734138f06326b178a11e9a)

Bug: 814031
Change-Id: I7550b767d094fbd99543dd6b7827d58bf1c2bee9
Reviewed-on: https://chromium-review.googlesource.com/928705
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538147}
Reviewed-on: https://chromium-review.googlesource.com/937466
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#595}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/platform/scheduler/base/task_queue.cc[diff]
• third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc[diff]
• third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h[diff]
• third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc[diff]

Block access to CCID-enabled YubiKeys

This patch adds all YubiKey devices with a CCID interface to the
UsbBlocklist. The blocklist functionality had to be updated to support
blocking all devices with a given vendor and product ID up to and
including a maximum device version as the set of particular device
firmware versions we would like to block is unknown.

This unfortunately means this change cannot also be rolled out as a
field trial.

Bug: 813280
Change-Id: Ic84e71bdc57201a6e43a29dcd6376e3d84bcd258
Reviewed-on: https://chromium-review.googlesource.com/927788
Reviewed-by: Jeffrey Yasskin <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538658}(cherry picked from commit f00604c002f54951628f5cdac821bb283178eba1)
Reviewed-on: https://chromium-review.googlesource.com/938001
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#594}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/usb/usb_blocklist.cc[diff]
• chrome/browser/usb/usb_blocklist.h[diff]
• chrome/browser/usb/usb_blocklist_unittest.cc[diff]

Fix 65 branch after manual merge in 55ab9a6

Change-Id: Ic14e3e24dd67d82ccdac38bfd53dfce3db927016
Reviewed-on: https://chromium-review.googlesource.com/937945
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#593}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/browser/frame_host/render_frame_host_impl.cc[diff]

Fix crashes in FFmpegDemuxer::SetEnabled

What happens here is similar to crbug.com/775852 - somehow an invalid
track id is passed from blink level down to media pipeline and we fail
to find the demuxer stream corresponding to that track id. So instead
of using map operator[], we need to use map::find and check if the
stream for the given track id was actually found.

BUG=806871

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibbffc74046a562585d6b404f90a9ae38a0d43050
Reviewed-on: https://chromium-review.googlesource.com/902188
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Sergey Volk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534515}(cherry picked from commit 50f000d66dd5a2c512daf1fec265fc4e9668e6ab)
Reviewed-on: https://chromium-review.googlesource.com/937822
Reviewed-by: Sergey Volk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#592}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• media/filters/ffmpeg_demuxer.cc[diff]

merge 6bb1eba7d527f89d6d3eebec8fb1fb079b043060

Don't send new subresource loader factories to the renderer for failed commits when the network service is disabled.

This was an unintended change in r524876.

[email protected]

Bug: 8149131
Change-Id: Idac3b00e5f3216ff2d5b8192d6c5840262cf87fb
Reviewed-on: https://chromium-review.googlesource.com/937814
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#591}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/browser/frame_host/render_frame_host_impl.cc[diff]

Fix for a crasher in PdfToEmfConverter

Fix a crasher that happens in PdfToEmfConverter when failing to
create a temporary file. We would call set_connection_error_handler
on on pdf_to_emf_converter_ which would be null in that case.
Also adding a browser test to validate that case.

Bug: 814613
Change-Id: Ib336347512d09213494083007d0a3bdc99a25b21
Reviewed-on: https://chromium-review.googlesource.com/932831
Commit-Queue: Jay Civelli <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538603}(cherry picked from commit 537716a64ef068fc68832e14129e06c0bd4c17be)
Reviewed-on: https://chromium-review.googlesource.com/937821
Reviewed-by: Jay Civelli <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#590}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/printing/pdf_to_emf_converter.cc[diff]
• chrome/browser/printing/pdf_to_emf_converter.h[diff]
• chrome/browser/printing/pdf_to_emf_converter_browsertest.cc[diff]

Surface synchronization: Only throttle input on Chrome OS

Input throttling is not currently well supported on non-Chrome OS platforms
and that's causing some crashes in the wild. Input throttling still makes
sense on any synchronization event on any platform because things aren't
getting updated while we are synchronizing but for the time being to avoid
crashes in the wild, this CL disables input throttling outside of Chrome OS.

[email protected]

(cherry picked from commit 053e08962e327a9d5ac1958d7f808d55de9eaad4)

Bug: 672962, 791447
Change-Id: I0ac419a683f8a0f735e746fa629a037370fbd169
Reviewed-on: https://chromium-review.googlesource.com/932542
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538872}
Reviewed-on: https://chromium-review.googlesource.com/937384
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#589}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ui/aura/window_tree_host.cc[diff]
• ui/aura/window_tree_host_unittest.cc[diff]

Cancel callback on DOMFileSystem::ScheduleCallback on null context

|execution_context| there may be null, and ScheduleCallback()
should be nop in that case.

Bug: 802373
Change-Id: I6731f9a47f4460439acee6307ec42a5a3e931830
Reviewed-on: https://chromium-review.googlesource.com/881122
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Taiju Tsuiki <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531403}(cherry picked from commit 44fe59c8dd90d446da8eceda0cb28a5117311be1)
Reviewed-on: https://chromium-review.googlesource.com/936526
Reviewed-by: Taiju Tsuiki <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#588}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp[diff]

Incrementing VERSION to 65.0.3325.102

[email protected]

Change-Id: I0e32869d886cb5e24b14cfd3f3a00b95c8476dcb
Reviewed-on: https://chromium-review.googlesource.com/936670
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#587}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.101

[email protected]

Change-Id: Ia7d385f6ea96b0d09ce7a3769c9a0a50253e8feb
Reviewed-on: https://chromium-review.googlesource.com/936589
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#586}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.100

[email protected]

Change-Id: Ife841dac739d56e7cfce2cd7a3d8ec3b64342cb8
Reviewed-on: https://chromium-review.googlesource.com/936607
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#585}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.99

[email protected]

Change-Id: If207a8f70107f2bbe83f78a521006dd9b52bd7ae
Reviewed-on: https://chromium-review.googlesource.com/936663
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#584}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.98

[email protected]

Change-Id: I78fbbcf7c823f5f29df980118c2e99c3daef1f19
Reviewed-on: https://chromium-review.googlesource.com/936083
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#583}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.97

[email protected]

Change-Id: I02ae364e0c50df95fa58e9dfef9cfaa4bbc51a59
Reviewed-on: https://chromium-review.googlesource.com/936101
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#582}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

[Merge to M65]Fix crash when open new tab from eol notification in guest session

[email protected],[email protected]
(cherry picked from commit 3327cfed3f0a3d7dca70057cafa0d271e20daeff)

Bug: 809271
Change-Id: I769b03038509625eeade3fb4787d0d73ff105f03
Reviewed-on: https://chromium-review.googlesource.com/924755
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiaoyin Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538477}
Reviewed-on: https://chromium-review.googlesource.com/936042
Reviewed-by: Xiaoyin Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#581}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/profiles/profile_manager.cc[diff]

Merge M65: Update Flash plugin metadata versions to latest version.

https://helpx.adobe.com/security/products/flash-player/apsb18-03.html

BUG=412078
[email protected]

(cherry picked from commit 9b074a8e8dfffc8d9effbc8eca872c0e7d718dc4)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3a2211a113b4b01a58c13f9ce3448e905631ca7a
Reviewed-on: https://chromium-review.googlesource.com/935478
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538934}
Reviewed-on: https://chromium-review.googlesource.com/935824
Cr-Commit-Position: refs/branch-heads/3325@{#580}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/resources/plugin_metadata/plugins_linux.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_mac.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_win.json[diff]

[merge m-65]: macOS V2 Sandbox: Send profile to child process robustly.

This is CL squashes three cherry-picks into one CL for the purpose of
merging to m-65. The CLs make IPC of the seatbelt profile from the
browser to the child process robust by adding logging and handling short
writes or temporarily busy file descriptors.

Original CLs:
78e7405af0e16c10500bc5b923e938ad9f52e735
macOS V2 Sandbox: Add logging to failures in profile communication.
Change-Id: I425bedc92d47a27f90b4d80541d2cbf68e8f6a21
Reviewed-on: https://chromium-review.googlesource.com/916946
Cr-Commit-Position: refs/heads/master@{#536495}

7ea6cf78e3bced2f48c49394493832520cdc97f0
macOS V2 Sandbox: Send serialized seatbelt profile in a loop.
Change-Id: Ib1f4c57c61d3ce68b875b347de480f514100d3c2
Reviewed-on: https://chromium-review.googlesource.com/920765
Cr-Commit-Position: refs/heads/master@{#537360}

fb63be6d346dbbbe47e3edf3a7e8e6b6b7f286d7
macOS V2 Sandbox: Continue sending profile if EAGAIN occurs.
Change-Id: I1a6c91fc348a20804b06d0bb64fbcd17cccea20f
Reviewed-on: https://chromium-review.googlesource.com/924246
Cr-Commit-Position: refs/heads/master@{#538474}

Bug: 801889
Change-Id: I421f83dfa58ad2990e4f6fe304f9713cfa9d6b60
Reviewed-on: https://chromium-review.googlesource.com/935664
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#579}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/browser/child_process_launcher_helper_mac.cc[diff]
• sandbox/mac/seatbelt_exec.cc[diff]
• sandbox/mac/seatbelt_exec.h[diff]

Check publickey security requirements for calls to get(publicKey)
and handle empty or missing rpIds.

Add layout tests for various combinations of origins and rpId to
get(publicKey) just like the existing ones for create(publicKey).

Bug: 807774, 664630
Change-Id: I86d3d36c3f3825743f003da69245c74bdca10d5b
Reviewed-on: https://chromium-review.googlesource.com/896384
Commit-Queue: Kim Paulhamus <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537594}(cherry picked from commit d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18)
Reviewed-on: https://chromium-review.googlesource.com/935223
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#578}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/LayoutTests/VirtualTestSuites[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-origins.html[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame.html[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-origins.html[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/nested-mock-authenticator-client.html[diff]
• third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-get-helper.html[Added - diff]
• third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/README.txt[Added - diff]
• third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame-expected.txt[Added - diff]
• third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp[diff]
• third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp[diff]

AW: workaround Samsung mail app issue

This applies a workaround for one of Samsung's OEM mail apps which was
negatively affected by PlzNavigate. This is meant as a minimal temporary
workaround until we finish investigation on the issue.

The app is loading 2 URLs (a file:// URL followed by
loadDataWithBaseUrl) in quick succession. This workaround posts the
second load by 200ms. In my testing, I've found that 40ms is more than
enough, so 200ms should be very safe (but still fast enough to not
adversely impact user experience).

Bug: 781535
Test: manual - with the actual Samsung mail app
Change-Id: I1fdb002c377af083158a5dc4e0e7ce067a176d30
Reviewed-on: https://chromium-review.googlesource.com/924115
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537428}(cherry picked from commit da8150a61216a0eaa65428613d375968bec2fecc)
Reviewed-on: https://chromium-review.googlesource.com/935401
Reviewed-by: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#577}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• android_webview/java/src/org/chromium/android_webview/AwContents.java[diff]

Revert "AW: Enable Safe Browsing by default"

This reverts commit 0b4a380b719faf9ecb53d52dc7e26262a164bcc4.

Note: this revert only lands on the M65 branch, and does not affect trunk.

Reason for revert: We want to wait one more cycle before launching in
stable.

Original change's description:
> AW: Enable Safe Browsing by default
>
> This changes the logic to turn Safe Browsing on by default instead of
> off by default. "On by default" means that we assume applications opt in
> to Safe Browsing.
>
> Details for precisely when WebView Safe Browsing is enabled can be found
> here: https://goo.gl/zXkbFg
>
> This also removes WEBVIEW_ENABLE_SAFEBROWSING_SUPPORT from integration
> tests, since the flag is now redundant.
>
> Bug: 799317
> Test: Manual - tested with and without --webview-disable-safebrowsing-support
> Test: See SuperSafeBrowsing*.apk in https://sites.google.com/a/google.com/clank/engineering/android-webview/zzarchive/webview-manual-testing
> Change-Id: I96f88ff979b7bcbec9608a3d79f44575f26942d3
> Reviewed-on: https://chromium-review.googlesource.com/850825
> Reviewed-by: Changwan Ryu <[email protected]>
> Commit-Queue: Nate Fischer <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#527393}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 807130
Change-Id: I7b818d1a7948135064faa26f86b74b1d16ed483b
Reviewed-on: https://chromium-review.googlesource.com/932947
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#576}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java[diff]
• android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java[diff]

Revert "Support VTTCue.positionAlign and lineAlign for WebVTT"

This reverts commit 2c1d466d78db6df8b4c9fbe37ac5af1cb135bf34.

Reason for revert: https://crbug.com/814710

Conflicts with https://chromium-review.googlesource.com/836576 resolved.

Original change's description:
> Support VTTCue.positionAlign and lineAlign for WebVTT
>
> Implement VTTCue.[positionAlign and lineAlign] for WebVTT
> Updated parsing logic
> Exposed DOM API's
> Updated Layout algorithm
> Updated test expected results
>
> Bug: 633690
> Change-Id: I49970c068c53b462243ba8c7f314261b0e6455ce
> Reviewed-on: https://chromium-review.googlesource.com/756142
> Commit-Queue: srirama chandra sekhar <[email protected]>
> Reviewed-by: srirama chandra sekhar <[email protected]>
> Reviewed-by: Chris Harrelson <[email protected]>
> Reviewed-by: Philip Jägenstedt <[email protected]>
> Reviewed-by: Fredrik Söderquist <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#525659}

[email protected],[email protected],[email protected],[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 633690
Change-Id: Ib9f0b3dd1a4b679076ec55ec635337551f8b8806
Reviewed-on: https://chromium-review.googlesource.com/931481
Commit-Queue: Philip Jägenstedt <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538429}(cherry picked from commit ce7509393d9dd7ec49b8e0fd10d94959288a7caf)
Reviewed-on: https://chromium-review.googlesource.com/935341
Cr-Commit-Position: refs/branch-heads/3325@{#575}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTCue/constructor-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTCue/lineAlign-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTCue/positionAlign-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/api/interfaces-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/settings-position-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/rendering/cues-with-video/processing-model/track-cue-rendering-position-align-rtl-center-ref.html[Deleted - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/rendering/cues-with-video/processing-model/track-cue-rendering-position-align-rtl-center.html[Deleted - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/rendering/cues-with-video/processing-model/track-cue-rendering-position-align-rtl-line-left-ref.html[Deleted - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/rendering/cues-with-video/processing-model/track-cue-rendering-position-align-rtl-line-left.html[Deleted - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/rendering/cues-with-video/processing-model/track-cue-rendering-position-align-rtl-line-right-ref.html[Deleted - diff]
• third_party/WebKit/LayoutTests/external/wpt/webvtt/rendering/cues-with-video/processing-model/track-cue-rendering-position-align-rtl-line-right.html[Deleted - diff]
• third_party/WebKit/LayoutTests/media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt[diff]
• third_party/WebKit/LayoutTests/media/track/track-cue-rendering-position-auto-rtl-expected.html[diff]
• third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt[diff]
• third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt[diff]
• third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp[diff]
• third_party/WebKit/Source/core/html/track/vtt/VTTCue.h[diff]
• third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl[diff]
• third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp[diff]
• third_party/WebKit/Source/core/layout/LayoutVTTCue.h[diff]

[iOS] Fix scroll end adjustment for hiding toolbar.

This CL updates BVC's fullscreen scroll end adjustment animation to
only update the top content padding early for header-hiding animations
that reveal beyond the top of the rendered content.  All other
scroll end adjustments can update the top content padding in the
animation's completion block.

Bug: 800697
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3c53e39e6aec1f3ddad2c83aed9c109221780c49
Reviewed-on: https://chromium-review.googlesource.com/922269
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538542}(cherry picked from commit 458bc43f9505182db53ad3e7368fc73b35ba3fde)
Reviewed-on: https://chromium-review.googlesource.com/935221
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#574}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/browser_view_controller.mm[diff]

[iOS] Use UIScrollView scroll to top animation.

If you animate a UIScrollView's contentOffset while it's decelerating,
the CADisplayLink powering the deceleration scrolling is not stopped.
As a result, the deceleration will continue after the contentOffset
animation is completed.  This CL updates fullscreen's scroll to top
animation to allow the built-in UIScrollView scroll to top animation,
which cancels the deleration CADisplayLink.

Bug: 811294
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2fbb572dca7963e760b3ec417eb3157d9e4a5baf
Reviewed-on: https://chromium-review.googlesource.com/922273
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537114}(cherry picked from commit cb56b831ff407cb2396173944607b4ee7f6a2a80)
Reviewed-on: https://chromium-review.googlesource.com/935161
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#573}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/browser_view_controller.mm[diff]
• ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm[diff]

[iOS] Ignore pixel alignments when updating the MainContentUIState.

UIScrollView does not send a |-didEndDecelerating| to its delegate after
pixel alignments, so the MainContentUIState should not be considered
decelerating if the target contentOffset is less than a pixel away from
the current value.

This will correctly update the MainContentUIState's |scrolling|
property to NO, allowing the FullscreenScrollEndAnimator to start.

Bug: 800757
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4407bf34c4a6c5cb485bba01528c34cf9e86c156
Reviewed-on: https://chromium-review.googlesource.com/922888
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537382}(cherry picked from commit 24ec7cd715920382c1ab368cfc98efafc9530dd1)
Reviewed-on: https://chromium-review.googlesource.com/934942
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#572}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/main_content/main_content_ui_state.h[diff]
• ios/chrome/browser/ui/main_content/main_content_ui_state.mm[diff]
• ios/chrome/browser/ui/main_content/main_content_ui_state_unittest.mm[diff]
• ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm[diff]

[ios] Do not show grey placeholders when there is no current tab.

This fixes a crash that occurs when trying to access UserData for a NULL
WebState.

BUG=812237
TEST=None, could not find repro steps.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I59f2063a20887870f0e70368cda72cf85281dfe4
Reviewed-on: https://chromium-review.googlesource.com/927281
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538062}(cherry picked from commit aff0df6843211db6eea1caa9b2daf751367e04e0)
Reviewed-on: https://chromium-review.googlesource.com/935061
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#571}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/browser_view_controller.mm[diff]

[ios] Fixes more issues where the BVC is over-dismissed.

BUG=811671

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a8b9a649db4970b208e18419090dcbaa2eb64db
Reviewed-on: https://chromium-review.googlesource.com/927121
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538111}(cherry picked from commit f46de8c1c857b9913a9e5673f2f77c96ffdc5ec0)
Reviewed-on: https://chromium-review.googlesource.com/934602
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#570}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/browser_view_controller.mm[diff]

Fix NTP with hardware keyboard

Allow touch events on tablet when the keyboard is focused with a
hardware keyboard.

BUG=811997

Change-Id: I81027c919a292cafa877ffd13556cff65ef63d7a
Reviewed-on: https://chromium-review.googlesource.com/927346
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538151}(cherry picked from commit 8d53089023276a21700e9b4aac8843dce877dc13)
Reviewed-on: https://chromium-review.googlesource.com/935001
Cr-Commit-Position: refs/branch-heads/3325@{#569}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java[diff]

[iOS] Fix SadTabTabHelper compilation.

Bug: 815085
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib54f0a0c92da1ac3cdff7ad9c510ed60e41075e2
Reviewed-on: https://chromium-review.googlesource.com/934941
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#568}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/web/BUILD.gn[diff]

Incrementing VERSION to 65.0.3325.96

[email protected]

Change-Id: I4f5dcc1f6c27473f46c3b2096789ae51af55556a
Reviewed-on: https://chromium-review.googlesource.com/933605
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#567}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.95

[email protected]

Change-Id: Ie4c09fbefc9ee95e8288772e1c2afe4b41c5f0e3
Reviewed-on: https://chromium-review.googlesource.com/933604
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#566}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Revert "Zip Archiver: Disable storing mount and password info."

This reverts commit c3169366954d82dc6b35ad6a869907cde0d714cd.

Reason for revert: This caused regression Issue 812123.
This had caused that mount resuming succeeds superficially by
the caller despite it actually failed, thus leaving inaccessible
zip mount point.

Original change's description:
> Zip Archiver: Disable storing mount and password info.
>
> We are not restoring mount files at session restart anymore.
> Therefore the mount information and passwords should not be persisted.
> Othrewise it will be persisted until the user opens the same archive
> again manually after a long time and the files will be opened without
> requiring passwords.
>
> Bug: 789073,803752
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Idadcff694b20109eb7e31710b57d88400601d30a
> Reviewed-on: https://chromium-review.googlesource.com/876705
> Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
> Reviewed-by: Yuki Awano <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#531467}

[email protected],[email protected]

Bug: 789073, 803752
Change-Id: I387e16717b5187389d01c5d5bc4a8b6884dcf035
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/928063
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#538338}(cherry picked from commit 92067a9e7c3867cbfb832dd8d953a4ec54a59238)


Bug: 812123
Change-Id: I387e16717b5187389d01c5d5bc4a8b6884dcf035
Reviewed-on: https://chromium-review.googlesource.com/933681
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#565}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css[diff]
• chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html[diff]
• chrome/browser/resources/chromeos/zip_archiver/js/app.js[diff]
• chrome/browser/resources/chromeos/zip_archiver/js/background.js[diff]
• chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js[diff]
• chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js[diff]
• chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js[diff]
• chrome/browser/resources/chromeos/zip_archiver/manifest.json[diff]

Return a valid error type upon volume request before mount.

Rejection from the extension should return either of the error code in
ProviderError, or it will crash extension by a runtime error.

Bug: 812123
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I06d858bc7cb0eb325c7e8b188cfee559d05a078e
Reviewed-on: https://chromium-review.googlesource.com/926441
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538000}(cherry picked from commit 6217f45cd99d80aa76542460d91e882a857067b5)
Reviewed-on: https://chromium-review.googlesource.com/933661
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#564}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/resources/chromeos/zip_archiver/js/app.js[diff]

[iOS] Disable fullscreen for SadTab.

Additionally, this CL updates CRWGenericContentView's contentSize
adjustment logic to ensure that scrolling doesn't get disabled.

Bug: 807957
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf48f9b79966520f31477b0a58415eb286f037ae
Reviewed-on: https://chromium-review.googlesource.com/917642
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537450}(cherry picked from commit e8bbb37f4c9a26f147c5623ef88dd7828a53d83b)
Reviewed-on: https://chromium-review.googlesource.com/933304
Cr-Commit-Position: refs/branch-heads/3325@{#563}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/web/BUILD.gn[diff]
• ios/chrome/browser/web/sad_tab_tab_helper.h[diff]
• ios/chrome/browser/web/sad_tab_tab_helper.mm[diff]
• ios/web/web_state/ui/crw_generic_content_view.mm[diff]

WindowActivityWatcher: Verify browser window exists

It's apparently possible for
BrowserList::SetLastActive(Browser* browser) to be called before
|browser| is added to the BrowserList. This might happen, e.g., if a
BrowserView's widget receives an activation event before
CreateBrowserWindow() returns.

This will cause WindowActivityWatcher's CreateMetrics() helper function
to dereference the null pointer at browser->window().

(cherry picked from commit 3c2815cfbf41f0c76d74c64800d6d60c328d3d7b)

Bug: 811243,811191
Change-Id: Ia377a810b73494f88d1cd2b4532367950f35b1f7
Reviewed-on: https://chromium-review.googlesource.com/924353
Commit-Queue: Michael Giuffrida <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537825}
Reviewed-on: https://chromium-review.googlesource.com/932008
Cr-Commit-Position: refs/branch-heads/3325@{#562}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/ui/tabs/window_activity_watcher.cc[diff]

Surface synchronization: Update compositor scale factor whenever changes

If device emulation was enabled then the WebViewImpl device scale
factor may not change as system device scale factor changes.

Surface synchronization expects that every surface have a fixed device
scale factor. Prior to this CL, the layer compositor's view of device
scale factor may not be updated as system device scale factor changes
when device emulation is enabled. This would cause the layer compositor
to submit a CompositorFrame with an incorrect device scale factor. This
resulted in two problems:

1. Surface invariants violation error could result if device emulation
is later disabled. This can happen if the system DSF changes but the
device emulated DSF does not and then device emulation is turned off
with the new system DSF.

2. SurfaceAggregator does relative scaling of surfaces based on their
reported device scale factor. If the CompositorFrame doesn't report its
device scale factor correctly, it will be scaled incorrectly.

[email protected]

(cherry picked from commit e24c90e284ccaae925132cc0271d9179b5560ec3)

Bug: 791154, 672962
TBR: [email protected]
Change-Id: I68be4142a83806b8893185ca9e542afada126b9f
Reviewed-on: https://chromium-review.googlesource.com/925682
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#538042}
Reviewed-on: https://chromium-review.googlesource.com/933106
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#561}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/renderer/render_widget.cc[diff]
• third_party/WebKit/Source/core/exported/WebViewImpl.cpp[diff]
• third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp[diff]

Surface synchronization: Report whether an OOPIF is violating invariants

This CL reports whether an OOPIF is causing invariants violations.

[email protected]

(cherry picked from commit 8d41aa29fa6b773fbfa4c803e9d96adf2ad739da)

Bug: 791154, 672962
Change-Id: Ida943b8a6bb21cd5baed00bd0065f77e5a358033
Reviewed-on: https://chromium-review.googlesource.com/923041
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Fady Samuel <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537600}
Reviewed-on: https://chromium-review.googlesource.com/933181
Cr-Commit-Position: refs/branch-heads/3325@{#560}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/browser/renderer_host/render_widget_host_impl.cc[diff]

Fix entering mirror mode on docked

Background:
Mirror mode is turned on upon entering tablet mode. Tablet mode is
entered when lid angle is larger than 200 degree. However, closing lid
triggers erroneous accelerometer reading which makes the lid appear to
be fully open (e.g. 359 degree). So mirror mode is incorrectly turned
on.

Changes:
Ignore unstable lid angle for 2 seconds and only use unstable lid
angle to turn on/off tablet mode after that.

Bug: 790720

[email protected],[email protected]

(cherry picked from commit 208b44ca364b93b73286b3364f1700009197afc6)

Change-Id: I1d9fa6394350303730062136c7bfe7a5a6fe98f5
Reviewed-on: https://chromium-review.googlesource.com/814936
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Stefan Kuhne <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#535181}
Reviewed-on: https://chromium-review.googlesource.com/927213
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#559}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ash/wm/tablet_mode/tablet_mode_controller.cc[diff]
• ash/wm/tablet_mode/tablet_mode_controller.h[diff]
• ash/wm/tablet_mode/tablet_mode_controller_unittest.cc[diff]

Fix first search result highlight

Background:
The first search result should be highlighted after the search results
are updated.

Changes:
1. Create SearchResultBaseView as the parent class for SearchResultView,
SearchResultTileItemView and SearchAnswerContainerView so that we could
easily highlight different search results.
2. Rename SetFirstResultSelected to SetFirstResultHighlighted since we
will remove selection completely in crbug.com/766807.

BUG=804023

[email protected]

(cherry picked from commit 61930607aefd9ef4658d2fce8f5a16bd4479cb75)

Change-Id: I731657350ed76b3a8b92adce2c7e70e86b9a013c
Reviewed-on: https://chromium-review.googlesource.com/891939
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533387}
Reviewed-on: https://chromium-review.googlesource.com/926904
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#558}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ui/app_list/BUILD.gn[diff]
• ui/app_list/views/app_list_view_unittest.cc[diff]
• ui/app_list/views/search_box_view.cc[diff]
• ui/app_list/views/search_result_answer_card_view.cc[diff]
• ui/app_list/views/search_result_answer_card_view.h[diff]
• ui/app_list/views/search_result_answer_card_view_unittest.cc[diff]
• ui/app_list/views/search_result_base_view.cc[Added - diff]
• ui/app_list/views/search_result_base_view.h[Added - diff]
• ui/app_list/views/search_result_container_view.h[diff]
• ui/app_list/views/search_result_list_view.cc[diff]
• ui/app_list/views/search_result_list_view.h[diff]
• ui/app_list/views/search_result_page_view.cc[diff]
• ui/app_list/views/search_result_page_view.h[diff]
• ui/app_list/views/search_result_tile_item_list_view.cc[diff]
• ui/app_list/views/search_result_tile_item_list_view.h[diff]
• ui/app_list/views/search_result_tile_item_view.cc[diff]
• ui/app_list/views/search_result_tile_item_view.h[diff]
• ui/app_list/views/search_result_view.cc[diff]
• ui/app_list/views/search_result_view.h[diff]
• ui/app_list/views/suggestions_container_view.cc[diff]
• ui/app_list/views/suggestions_container_view.h[diff]

Don't consider browsing contexts with empty names for named lookup.

[email protected]

(cherry picked from commit 0c236612e5b506d3b1e3ab9b75b3a355e2ba620f)

Bug: 803620
Change-Id: I6c28067a10d812faf815a04360a701aee741abc5
Reviewed-on: https://chromium-review.googlesource.com/925541
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537735}
Reviewed-on: https://chromium-review.googlesource.com/932912
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#557}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/core/exported/WebFrameTest.cpp[diff]
• third_party/WebKit/Source/core/page/FrameTree.cpp[diff]
• third_party/WebKit/Source/core/page/FrameTree.h[diff]

[iOS] Reset content inset when overscroll action is cancelled.

This CL updates OverscrollActionsController to reset the scroll view's
top content inset when the gesture is cancelled.  This occurs before
reenabling the FullscreenController, as the content inset is used to
check whether the page's rendered content fits in the current viewport.
If the content fits, then scrolls will be ignored.

[email protected]

(cherry picked from commit b4e1a9ae423022a5bb87a9250d933fb5e1057427)

Bug: 809853, 809856
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I60c58b8ec75ae126217a58be2f3792048fc27e5c
Reviewed-on: https://chromium-review.googlesource.com/912272
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#536174}
Reviewed-on: https://chromium-review.googlesource.com/932549
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#556}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm[diff]

[iOS] Improve FullscreenModel scroll handling.

This CL improves fullscreen handling for several edge
conditions.  The behavior described in the referenced bug
is due to FullscreenModel attempting to handle UIScrollView
adjustments that occur when bouncing past the top edge of
content.  Similarly broken behavior also occurred when
attempting to scroll pages smaller or similarly sized with
the scroll view.

After this change, FullscreenModel ignores scrolls that
have to do with UIScrollView adjusting its contentOffset
for bouncing or resizing behavior.

Implementing this logic also required exposing the
scroll view frame, contentInset, contentSize, and zooming
properties.

[email protected]

(cherry picked from commit 963abca215a516aab5fbe81e17fb96466d327222)

Bug: 800757, 807957, 809853, 809856
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8980983e048ce73d3443160cb4dd2e29a1aed15a
Reviewed-on: https://chromium-review.googlesource.com/896304
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#535435}
Reviewed-on: https://chromium-review.googlesource.com/932548
Cr-Commit-Position: refs/branch-heads/3325@{#555}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/broadcaster/chrome_broadcast_observer.h[diff]
• ios/chrome/browser/ui/broadcaster/chrome_broadcast_observer_bridge.h[diff]
• ios/chrome/browser/ui/broadcaster/chrome_broadcast_observer_bridge.mm[diff]
• ios/chrome/browser/ui/broadcaster/chrome_broadcaster.mm[diff]
• ios/chrome/browser/ui/broadcaster/chrome_broadcaster_unittest.mm[diff]
• ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.mm[diff]
• ios/chrome/browser/ui/fullscreen/fullscreen_model.h[diff]
• ios/chrome/browser/ui/fullscreen/fullscreen_model.mm[diff]
• ios/chrome/browser/ui/fullscreen/fullscreen_model_unittest.mm[diff]
• ios/chrome/browser/ui/fullscreen/test/fullscreen_model_test_util.mm[diff]
• ios/chrome/browser/ui/main_content/main_content_ui_broadcasting_util.mm[diff]
• ios/chrome/browser/ui/main_content/main_content_ui_state.h[diff]
• ios/chrome/browser/ui/main_content/main_content_ui_state.mm[diff]
• ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm[diff]
• ios/web/public/web_state/ui/crw_web_view_scroll_view_proxy.h[diff]
• ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm[diff]
• ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm[diff]

media: Use per-frame task runners at WebRTCMediaStreamAdapterMap and WebRtcMediaStreamTrackAdapterMap

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

[email protected]

(cherry picked from commit d2f2ce6989291ada20b50bae26a7449f719cd683)

Bug: 786332
Change-Id: I300a38816bef6bb8f371203aaad52cb31154309a
Reviewed-on: https://chromium-review.googlesource.com/882713
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Hajime Hoshi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531820}
Reviewed-on: https://chromium-review.googlesource.com/931803
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#554}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/renderer/media/rtc_peer_connection_handler.cc[diff]
• content/renderer/media/webrtc/rtc_rtp_sender_unittest.cc[diff]
• content/renderer/media/webrtc/webrtc_media_stream_adapter_map.cc[diff]
• content/renderer/media/webrtc/webrtc_media_stream_adapter_map.h[diff]
• content/renderer/media/webrtc/webrtc_media_stream_adapter_map_unittest.cc[diff]
• content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc[diff]
• content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map.cc[diff]
• content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map.h[diff]
• content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map_unittest.cc[diff]
• content/renderer/media/webrtc/webrtc_set_remote_description_observer_unittest.cc[diff]

[iOS] Update the MainContentUIState upon initialization.

The MainContentUIState used to broacast information to FullscreenModel
is instantiated when the BVC's view appears.  When presenting a view
controller, it receives the hidden/appearing signals and the default
state gets broadcasted.  This CL updates the
WebScrollViewMainContentUIForwarder to update the state immediately if
there is an active WebState.

Bug: 811729
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I823f01d3c86c0ec8dd0dc2b62b873071a0578b16
Reviewed-on: https://chromium-review.googlesource.com/917124
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#536515}(cherry picked from commit a88559f1ee9968255dfcdbd1d02303e2a42729eb)
Reviewed-on: https://chromium-review.googlesource.com/932483
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#553}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm[diff]

Use 4x MSAA on Mac/Intel to avoid perf regression

On Mac/Intel, the default 8x MSAA causes huge performance regressions
specifically in WebGL contexts with {alpha:false,antialias:true}.

Add a workaround to fall back to 4x MSAA on Mac/Intel devices.

Adds pixel test suppressions that will be removed, after rebaseline,
in https://crrev.com/c/924310

[email protected]

Bug: 812071
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifd2283f6b232371cb63d67a8641236073cb0b4da
Reviewed-on: https://chromium-review.googlesource.com/923103
Commit-Queue: Kai Ninomiya <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537993}(cherry picked from commit 28cc4cd37aa9c4e27d882c249092098197920133)
Reviewed-on: https://chromium-review.googlesource.com/932007
Reviewed-by: Kai Ninomiya <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#552}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/test/gpu/gpu_tests/pixel_test_pages.py[diff]
• gpu/config/gpu_driver_bug_list.json[diff]

v8binding: Fixes wrapper-tracing at ResizeObserver.

The current implementation is running ResizeObserver's callback
functions even when they're NOT wrapper-traced.  This patch makes
it sure that the observed Element is performing wrapper-tracing
otherwise ResizeObserver does not invoke an untraced callback
function.

The attached test case causes crash with the current
implementation, but not with this patch.

Bug: 809784
Change-Id: If2e66d388ab4f4410ca8c472176fbdee5a957f08
Reviewed-on: https://chromium-review.googlesource.com/924104
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537714}(cherry picked from commit b1a610768d7351f4662c8a0b8916f4dc0db19267)
Reviewed-on: https://chromium-review.googlesource.com/932141
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#551}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/LayoutTests/resize-observer/wrapper-tracing.html[Added - diff]
• third_party/WebKit/Source/core/resize_observer/ResizeObserver.cpp[diff]
• third_party/WebKit/Source/core/resize_observer/ResizeObserver.h[diff]

DevTools: fix bookkeeping when evicting POST data

Due to the bug, free space size was not updated when the POST data was
evicted, resulting in crash.

[email protected]

(cherry picked from commit c9a324bf2fb731f1f9ef94dc4068cdc77140a5d6)

Bug: 813187
Change-Id: I8c4a3762eaa2ecf6ce58fccc639846c24cc9d6c8
Reviewed-on: https://chromium-review.googlesource.com/927643
Commit-Queue: Eugene Ostroukhov <[email protected]>
Reviewed-by: Eugene Ostroukhov <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537977}
Reviewed-on: https://chromium-review.googlesource.com/932005
Cr-Commit-Position: refs/branch-heads/3325@{#550}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/get-request-post-data-expected.txt[diff]
• third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/get-request-post-data.js[diff]
• third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp[diff]

cc: Make solid color mask layer ignore occlusion

Mask layer's occlusion is actually its render surface's occlusion in the
contributed parent surface space.

However, when tiling a solid color mask layer, we used to adopt the logic
from normal picture layers: overwrite the occlusion's transform with the
layer's draw transform. This is problematic because mask layer's draw
transform is to the render surface that owns the mask. In this way, we
can generate the wrong visible quad rect and result in blanks when
rendering.

Since solid color mask layer does not do anything but cannot be fully
avoided in the current code base, we should never apply an occlusion to
it. Any occlusion to the masked content can still take effect by
applying itself to the owning render surface.

Bug: 811143, 810820, 808372
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I821492c107c2abadb9b9e6986369c9f6262d0ad4
Reviewed-on: https://chromium-review.googlesource.com/916625
Commit-Queue: Xianda Sun <[email protected]>
Reviewed-by: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537794}(cherry picked from commit cf699d7fef4e3f03743cc916209c7ebff5dc7b7a)
Reviewed-on: https://chromium-review.googlesource.com/931903
Reviewed-by: Xianda Sun <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#549}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• cc/layers/picture_layer_impl.cc[diff]
• cc/layers/picture_layer_impl_unittest.cc[diff]

Fix coordinate space for touch pointer events

Consider frame scale for calculating coordinates
of touch pointer events.

[email protected]

(cherry picked from commit 735fa061d0f531bd0704c4c368d59edc1c1fea3a)
(cherry picked from commit 1478ec50aeb48fe9a10e51576a07cbe01d4a095f)

Bug: 809106
Change-Id: I5503583cd8c0e8b41b7e17fd59170a6f1dff7fa1
Reviewed-on: https://chromium-review.googlesource.com/914690
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Navid Zolghadr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#536813}
Reviewed-on: https://chromium-review.googlesource.com/931902
Reviewed-by: Navid Zolghadr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#548}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/core/events/PointerEventFactory.cpp[diff]
• third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp[diff]

Revert "Don't trigger end of track when starting a new disabled track"

This reverts commit 447c696aaf19064a79d7bc894ce4a0aa3422c69c.

Reason for revert: Introduces a regression. See https://crbug.com/813243

Original change's description:
> Don't trigger end of track when starting a new disabled track
>
> Fix reporting a size of 2x2 on the video element during the loading
> phase.
>
> Bug: 684288
> Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a
> Reviewed-on: https://chromium-review.googlesource.com/806215
> Commit-Queue: Florent Castelli <[email protected]>
> Commit-Queue: Guido Urdaneta <[email protected]>
> Reviewed-by: Guido Urdaneta <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#523152}

[email protected], [email protected]


(cherry picked from commit d1f07e92571d6a2db9ee116c267c2963f7b091ba)

Bug: 684288, 813243
Change-Id: I60bc092c23d1840a9c7e95b4b1d8d02c52c6fb46
Reviewed-on: https://chromium-review.googlesource.com/924190
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537675}
Reviewed-on: https://chromium-review.googlesource.com/928768
Cr-Commit-Position: refs/branch-heads/3325@{#547}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/browser/webrtc/webrtc_getusermedia_browsertest.cc[diff]
• content/renderer/media/media_stream_video_renderer_sink.cc[diff]
• content/test/data/media/getusermedia.html[diff]

Incrementing VERSION to 65.0.3325.94

[email protected]

Change-Id: I044353d643f6d439a12af45e201e6ab7ff9ac4d8
Reviewed-on: https://chromium-review.googlesource.com/930541
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#546}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.93

[email protected]

Change-Id: I2fbf6a051e58bd046da5cdfe5728138dc4382b5c
Reviewed-on: https://chromium-review.googlesource.com/930264
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#545}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Android Download: Fix an issue that Chrome removes external renamed file.

When user downloads a file in Chrome and remove the file in other
application, we check if the file is externally removed and call
Android API DownloadManager.remove(id) to avoid a crash on Android.

However, if the user rename the file, currently Chrome still deletes it
via the id provided by Android DownloadManager.

In this CL, we only let Android remove the file if it's deleted in
Chrome.


[email protected]

(cherry picked from commit 88276e189cc40e61a2f60fffd2b7a49b63af6695)

Bug: 774870
Change-Id: I5448a155c1e05e44ec3a812e93d3035d7061ecf7
Reviewed-on: https://chromium-review.googlesource.com/899770
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534738}
Reviewed-on: https://chromium-review.googlesource.com/930037
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#544}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/ui/BackendProvider.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java[diff]

Reland: NetworkConfig: Escape names before passing to i18n()

i18n() asserts if any unsafe tags are passed to it. We need to
HTMLEscape any network names passed to i18n().

Includes fix for browser tests.
Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/920903

[email protected]

(cherry picked from commit eaed246200f93cbe9042a56a2e609af0def6b710)

Bug: 811562
TBR: [email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7762ac9309b812358799c7eb885b1b4d29f9ec7f
Reviewed-on: https://chromium-review.googlesource.com/924655
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537518}
Reviewed-on: https://chromium-review.googlesource.com/929357
Cr-Commit-Position: refs/branch-heads/3325@{#543}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/resources/settings/internet_page/compiled_resources2.gyp[diff]
• chrome/browser/resources/settings/internet_page/internet_config.js[diff]
• chrome/browser/resources/settings/internet_page/tether_connection_dialog.js[diff]
• chrome/test/data/webui/settings/cr_settings_browsertest.js[diff]
• ui/webui/resources/cr_elements/chromeos/network/compiled_resources2.gyp[diff]
• ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js[diff]

Make SharedMemory::TakeHandle() unmap memory.

TakeHandle() was resetting |memory_| without unmapping the shared
memory. This leaks resources because it's no longer possible to unmap
after that point.

Bug: 804399
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I42397ec8dc768ec6d9b2affcaee829f6c8a8ea00
Reviewed-on: https://chromium-review.googlesource.com/897969
Commit-Queue: kylechar <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534109}(cherry picked from commit 58fd01a7e6537738c1f6a7063cb54bdc33d1e9a8)
Reviewed-on: https://chromium-review.googlesource.com/929741
Reviewed-by: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#542}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• base/memory/shared_memory.h[diff]
• base/memory/shared_memory_fuchsia.cc[diff]
• base/memory/shared_memory_mac.cc[diff]
• base/memory/shared_memory_nacl.cc[diff]
• base/memory/shared_memory_posix.cc[diff]
• base/memory/shared_memory_win.cc[diff]

SharedMemoryTracker will stop tracking memory if TakeHandle() was called

When TakeHandle() is called, the SharedMemory instance resets itself
and transfers ownership to the caller. In this case stop tracking the
instance since Unmap() will be noop since memory will be nullptr.
On Mac TakeHandle() just duplicates the handle and doesn't reset the
current instance. So, still tracking this memory is ok.
Note: This will change how private memory footprint is calculated since
we no longer track some shared memory instances.

BUG=804399

Change-Id: I28ed88bfee2033cdf07595d314505413f067e49b
Reviewed-on: https://chromium-review.googlesource.com/884999
Commit-Queue: Siddhartha S <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Hajime Hoshi <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533570}(cherry picked from commit a0996a237aaec59e2973eeed7f58e55f13169bc3)
Reviewed-on: https://chromium-review.googlesource.com/929721
Reviewed-by: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#541}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• base/memory/shared_memory_fuchsia.cc[diff]
• base/memory/shared_memory_nacl.cc[diff]
• base/memory/shared_memory_posix.cc[diff]
• base/memory/shared_memory_win.cc[diff]

Network config: Fix focus for configured networks

[email protected]

(cherry picked from commit abd2d4ed8622d96e84a4a78ae3daae86df98a5e9)

Bug: 811659
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id8937bcbd6828c8fc38b0e27e6505582ce6c25ca
Reviewed-on: https://chromium-review.googlesource.com/920647
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537107}
Reviewed-on: https://chromium-review.googlesource.com/929346
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#540}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ui/webui/resources/cr_components/chromeos/network/network_config.js[diff]

Network details: nameservers: stop learn more propagation

[email protected]

(cherry picked from commit 35328cc5ac8aafaefff8a50077074374ff5a77a0)

Bug: 810328
Change-Id: I511732bfc5429c58477b09a33fb8d83f3ba10539
Reviewed-on: https://chromium-review.googlesource.com/914925
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#536472}
Reviewed-on: https://chromium-review.googlesource.com/929582
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#539}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ui/webui/resources/cr_components/chromeos/network/network_nameservers.html[diff]
• ui/webui/resources/cr_components/chromeos/network/network_nameservers.js[diff]

Fix text autosizer behavior when printing

Cherry-picked from:

https://chromium-review.googlesource.com/920001

BUG=799014
[email protected]

Change-Id: Ia07e20f5aeaaa8d7d1d4d37fbb78c29a2b761d38
Reviewed-on: https://chromium-review.googlesource.com/929583
Reviewed-by: Stefan Zager <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#538}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• third_party/WebKit/Source/core/frame/LocalFrame.cpp[diff]
• third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp[diff]

[BackgroundSync] Trigger network notifications for more events

There is concern that we're missing some network connectivitiy events on
versions >= N due to doze mode. So this CL updates the network on Android via
ConnectivityManager.NetworkCallback events as well.

Bug: 794638
Change-Id: I4c9547653d881a430eb5a696804d778182b6c346
Reviewed-on: https://chromium-review.googlesource.com/896809
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Josh Karlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#535006}(cherry picked from commit 9ba2fee6d7c54b256369fc56e64dc6434207a51e)
Reviewed-on: https://chromium-review.googlesource.com/929481
Reviewed-by: Josh Karlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#537}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java[diff]

Merge to M65: Android Accessibility: Avoiding crash on unregistering broadcast receiver.

There might be cases where unregistering broadcast receiver can throw
IllegalArgumentException if the context is not handled in an appropriate
manner. This CL avoids the crash.

(cherry picked from commit 8839385d34f511f6498bc20edba638944b67d0cd)

Bug: 780261
Change-Id: Ibd244879237aea099787c37ebc2141366840e7a0
Reviewed-on: https://chromium-review.googlesource.com/891458
Reviewed-by: Bo <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Isha Bobra <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532578}
Reviewed-on: https://chromium-review.googlesource.com/929303
Cr-Commit-Position: refs/branch-heads/3325@{#536}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopWebContentsAccessibility.java[diff]

Incrementing VERSION to 65.0.3325.92

[email protected]

Change-Id: Ie924976cfd208f3bd24c3adb4ced717ebedfa771
Reviewed-on: https://chromium-review.googlesource.com/928850
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#535}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Incrementing VERSION to 65.0.3325.91

[email protected]

Change-Id: Ibb1d146a9817756426f54dc7ecc8236fb4cdcda0
Reviewed-on: https://chromium-review.googlesource.com/928848
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#534}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Revert "Merge to M65: Android Accessibility: Avoiding crash on unregistering broadcast receiver."

This reverts commit da433250fa7b5cb4fd094fe5186804eb5d0b6fba.

Reason for revert:
broke official arm builder:
https://uberchromegw.corp.google.com/i/official.android/builders/official-arm

also see crbug.com/814112

Original change's description:
> Merge to M65: Android Accessibility: Avoiding crash on unregistering broadcast receiver.
> 
> There might be cases where unregistering broadcast receiver can throw
> IllegalArgumentException if the context is not handled in an appropriate
> manner. This CL avoids the crash.
> 
> (cherry picked from commit 8839385d34f511f6498bc20edba638944b67d0cd)
> 
> Change-Id: I9d7888dcbde518caa6e7e426a215953e9c3ba672
> Bug: 780261
> Reviewed-on: https://chromium-review.googlesource.com/891458
> Reviewed-by: Bo <[email protected]>
> Reviewed-by: Dominic Mazzoni <[email protected]>
> Commit-Queue: Isha Bobra <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#532578}
> Reviewed-on: https://chromium-review.googlesource.com/927450
> Cr-Commit-Position: refs/branch-heads/3325@{#518}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

[email protected],[email protected]

Change-Id: I280b10d888dcbe82a1c4e07a246450e32f84bab6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 780261
Reviewed-on: https://chromium-review.googlesource.com/929081
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#533}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopWebContentsAccessibility.java[diff]

[Android WebView] Tracing API: add trace argument filtering by default.

MERGE to M65

Add filtering of trace arguments data by default to the WebView Tracing
API. Only specifically whitelisted strings are allowed in trace args
to avoid exposing any potential PII and address privacy concerns.

Currently only a few metadata category events are whitelisted, e.g.
the "process_name", "thread_name" arguments which are useful for
viewing in "chrome://tracing".

BUG=804414

Change-Id: I1477cd363d36cd9a3b5cf3c6bd4de0e8a3a63e63
Reviewed-on: https://chromium-review.googlesource.com/879144
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531609}(cherry picked from commit 4595b036c1f527b31ec3279759b6e2bcdfca2084)
Reviewed-on: https://chromium-review.googlesource.com/929021
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#532}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• android_webview/BUILD.gn[diff]
• android_webview/browser/tracing/aw_trace_event_args_whitelist.cc[Added - diff]
• android_webview/browser/tracing/aw_trace_event_args_whitelist.h[Added - diff]
• android_webview/browser/tracing/aw_tracing_controller.cc[diff]
• android_webview/lib/aw_main_delegate.cc[diff]

Add AudioVisualPerception to MediaPerceptionPrivate API.

Bug: 808144
Change-Id: I04a25f1776b7299dfc9273108e5fc38ed8c34290
Reviewed-on: https://chromium-review.googlesource.com/897895
Commit-Queue: Wei Guan <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#536140}(cherry picked from commit 9932813b326c3d4b70e2b0ca645b12e5890cf74f)
Reviewed-on: https://chromium-review.googlesource.com/927022
Reviewed-by: Simon Que <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#531}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chromeos/dbus/proto/media_perception.proto[diff]
• extensions/browser/api/media_perception_private/conversion_utils.cc[diff]
• extensions/browser/api/media_perception_private/conversion_utils_unittest.cc[diff]
• extensions/common/api/media_perception_private.idl[diff]

[Dice] Avoid showing the sync confirmation dialog before sync engine starts.

In pre-DICE, the sync confirmation dialog was always shown after the
accounts were added to the Gaia cookies. This took several seconds
allowing the sync engine to initialize and check whether sync was
allowed for the given account.

When DICE enabled, the sync confirmation dialog should only be shown
after sync has been initialized or failed to be initialized. This allows
us to make sure that the policy to enable or disable sync for the given
account is checked before displaying the sync confirmation dialog.

BUG = 812546
[email protected]

(cherry picked from commit 859bc0e66cd10599ce7a96517474fe22f57935cf)

Change-Id: Ic414cd8eb5a810a1ff0827526361b10f8e76210b
Reviewed-on: https://chromium-review.googlesource.com/921741
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Nicolas Zea <[email protected]>
Commit-Queue: Mihai Sardarescu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537348}
Reviewed-on: https://chromium-review.googlesource.com/928404
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#530}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc[diff]
• chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h[diff]

[M65] Add sleep fallback to base::SpinLock.

This avoids a situation where a thread of lesser priority is holding the
lock while a bunch of higher priority threads hog all CPU spinning,
preventing the lesser priority thread from releasing the lock.

Bug: 758695, 770312
Change-Id: Ibf36f16023069e32f3f55716a2b63e47fff0d9f7
Reviewed-on: https://chromium-review.googlesource.com/873647
Commit-Queue: Max Morin <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530835}(cherry picked from commit da57669f62bed877ec39dd5847470592109cb405)
Reviewed-on: https://chromium-review.googlesource.com/928481
Reviewed-by: Max Morin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#529}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• base/allocator/partition_allocator/spin_lock.cc[diff]

Files app: Enable muted autoplay for previewing video files.

Due to a Chrome policy change, autoplaying videos does not work in quick view.
Instead, we introduce muted autoplay to help users preview video files.

Bug: 804273
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I07768b04ff3994f53811d22fd33613291dd5b896
Reviewed-on: https://chromium-review.googlesource.com/920049
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Commit-Queue: Naoki Fukino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#536980}(cherry picked from commit 33e085fe31cc14110fc52092a35ee84c412b6bbb)
Reviewed-on: https://chromium-review.googlesource.com/928062
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#528}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.html[diff]

Merge to M65: Android Accessibility: Avoiding Infinite loop of FrameLayouts in a11y tree

Initially https://chromium-review.googlesource.com/c/chromium/src/+/729145
ContentViewCore.java#b1735 shows that if the mWebContentsAccessibility was null or
not enabled, we just create it and enable it. The return value was null for these 2 cases.

This CL tries to get that behavior back and avoid loops.

Bug: 805014
Change-Id: I4c880cf3f6fc482559b3cc81a3afbe22ae2fd199
Reviewed-on: https://chromium-review.googlesource.com/927861
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#527}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java[diff]
• content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java[diff]
• content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibility.java[diff]
• content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java[diff]

Merge to m65: Exclude chrome urls from focus recovery

[email protected]

Bug: 793754
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia452a9c25fbd35b0ccc91ac6572e3e5c11dc8418
Reviewed-on: https://chromium-review.googlesource.com/926221
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537818}
Reviewed-on: https://chromium-review.googlesource.com/927840
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#526}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js[diff]

Incrementing VERSION to 65.0.3325.90

[email protected]

Change-Id: I5a16e0059567639af9f266f5db9c5fc46cd5c936
Reviewed-on: https://chromium-review.googlesource.com/927490
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#525}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]

Use audio player and the Office Editing apps as the init default task.

We have several component extension as the initial default app, which
means set to default before user explicitly changes default app.
Audio player and the "Office Editing for Docs, Sheets & Slides" app
were not included in that list despite these are also components.

Bug: 810986
Test: unit_tests --gtest_filter=FileManagerFileTasksTest.*
Test: manually verified Office Editing shown as default

Change-Id: I1ee20773714ecda50fbe3d17f8cda1c0bb72fd96
Reviewed-on: https://chromium-review.googlesource.com/920124
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#537247}(cherry picked from commit b5d0b2f01bf6fc4abb7990aa434f02a10fa9d3ac)
Reviewed-on: https://chromium-review.googlesource.com/927841
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#524}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/browser/chromeos/file_manager/file_tasks.cc[diff]
• chrome/browser/chromeos/file_manager/file_tasks_unittest.cc[diff]

Incrementing VERSION to 65.0.3325.89

[email protected]

Change-Id: I03a92b68b8e5f6616b8333b9677cdc3c02074d57
Reviewed-on: https://chromium-review.googlesource.com/927082
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#523}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

• chrome/VERSION[diff]