Publish DEPS for Chromium 65.0.3325.52
Incrementing VERSION to 65.0.3325.52
[email protected]
Change-Id: I66747a6ccb1a20c4fcfc05c99bac2aa7e167cf48
Reviewed-on: https://chromium-review.googlesource.com/902867
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#327}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.51
[email protected]
Change-Id: Idc481ca2277e7d62cfaa7b9daca559bf7c391cc5
Reviewed-on: https://chromium-review.googlesource.com/903082
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#326}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.50
[email protected]
Change-Id: I96b9b357fbfc9f0c7f9225de5816aafcca6a53fa
Reviewed-on: https://chromium-review.googlesource.com/902866
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#325}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Handle null |collection_| in DWriteFontProxyImpl::GetFamilyCount again.
Bug: 804793
Change-Id: I5db57099fd3a0d3e348dc97a95e30af21e79d5b2
Reviewed-on: https://chromium-review.googlesource.com/892543
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Sam McNally <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533572}(cherry picked from commit 6e0a5ed93266817dfd10dcffc2083b839b332185)
Reviewed-on: https://chromium-review.googlesource.com/903022
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#324}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.49
[email protected]
Change-Id: I12d21ffaacd492cc444fbdb46c3f484da506a64e
Reviewed-on: https://chromium-review.googlesource.com/902865
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#323}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Locally fixed failing content_browsertests on M65.
(cherry picked from commit fa94b512324fab7c8a427068c8a59417148a8bf2)
[email protected]
Bug: 800822
Change-Id: Ic61ac714683424a405ded21033a9f087caafc0ee
Reviewed-on: https://chromium-review.googlesource.com/902773
Reviewed-by: Sahel Sharifymoghaddam <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#322}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Add Windows.HasHighResolutionTimeTicks metric.
This will help identify the portion of our population that is still
susceptible to a poor ticks clock (last update on this is in time_win.cc
and dates to 2015, not clear which data source this was based on).
R=[email protected]
Bug: 807615
Change-Id: I76627355c1357f1ad6c80ba461798facd41718b0
Reviewed-on: https://chromium-review.googlesource.com/897606
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533716}(cherry picked from commit 9350f6e61ceef7ffacb5f39fbf472c2ac4f95cc9)
Reviewed-on: https://chromium-review.googlesource.com/902703
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#321}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[browser nav] Remove FALLTHROUGH macro
...from GetBrowserAndTabForDisposition(). It's not available in M65.
Bug: 807171, 807550
Change-Id: I8afb8ad2fef03030ed08a41660eaab3b21dbe358
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/902174
Reviewed-by: Kevin Bailey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#320}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Chrome OS: Add Learm More link to Date and Time settings page.
[email protected]
(cherry picked from commit 576037389911a3f8c3007cbb74a7aeda35066d01)
Bug: 805078
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib9f558e1154744b99d9ce750a165ade07a5bafb3
Reviewed-on: https://chromium-review.googlesource.com/900022
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534153}
Reviewed-on: https://chromium-review.googlesource.com/902582
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#319}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Chrome OS: Update Supervised user icon in notification.
[email protected]
(cherry picked from commit 7690e85431d16839da14cadf05137eae976faad5)
Bug: 806038
Change-Id: I7671c6728f8e759f17cf3dafc5d6dbe845b5e900
Reviewed-on: https://chromium-review.googlesource.com/896947
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534260}
Reviewed-on: https://chromium-review.googlesource.com/902456
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#318}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Chrome OS: Update Supervised user icon in the system tray.
[email protected]
(cherry picked from commit a3f56460a463e2271fae57083cee4c54e7ca56f8)
Bug: 806038
Change-Id: If82af4835f2870acf37cc902e3e2f125f4b10f7c
Reviewed-on: https://chromium-review.googlesource.com/894200
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533089}
Reviewed-on: https://chromium-review.googlesource.com/902454
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#317}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Network: Fix edge case causing a crash
There is an edge case where SortNetworkList may destroy the default
network, causing a crash. This CL fixes that.
[email protected]
(cherry picked from commit 3c5f92b379715ade2f2fa872ef878519c789162c)
Bug: 805322
Change-Id: I3d880dacc567babea08d7b9f21c5c8759e290f83
Reviewed-on: https://chromium-review.googlesource.com/883971
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532963}
Reviewed-on: https://chromium-review.googlesource.com/902012
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#316}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}BrowserLifetimeHandler: Require true/false update arg
Previously tpm_firmware_update_requested might be undefined.
This makes the argument required and ensures that it is passed.
[email protected]
(cherry picked from commit 85a6ad31db1d6ca11cd52be6b0c35edd331aa42e)
Bug: 800103
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia5263d011a58f5f444b64df2e7109083c70b3daf
Reviewed-on: https://chromium-review.googlesource.com/887631
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532997}
Reviewed-on: https://chromium-review.googlesource.com/902430
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#315}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Network sim unlock: fix focus and disable buttons when in progress
This fixes a couple of minor sim unlock polish issues.
[email protected]
(cherry picked from commit add89c261260aa4c2b196f6ee0fdd60d6fd91c7f)
Bug: 797749, 786344
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9140397f4723c27514e09ce38cd2e527c231e9a9
Reviewed-on: https://chromium-review.googlesource.com/897823
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533798}
Reviewed-on: https://chromium-review.googlesource.com/902428
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#314}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Network config: nameservers: clear empty
Don't display empty nameservers when switching from custom -> automatic.
[email protected]
(cherry picked from commit 771fb3b616f0cc640127321c150b76f05b51578d)
Bug: 801087
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia4111f044368411773a0cbfb94cf129231f72845
Reviewed-on: https://chromium-review.googlesource.com/896267
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533789}
Reviewed-on: https://chromium-review.googlesource.com/902325
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#313}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Network config: fix shared logic
This fixes a couple of issues with the 'shared' logic in the config UI:
* 'guid' != configured, use source != CrOnc.Source.NONE instead
* Share toggle should be visible for all unconfigured networks, even
if it can not be changed (i.e. in the login screen).
[email protected]
(cherry picked from commit f7416c74afceb8d81f119a69833a5ec81a7ea980)
Bug: 807494
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6f068adbe04b9011763426e9b9f72ac0ebb01535
Reviewed-on: https://chromium-review.googlesource.com/896023
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533761}
Reviewed-on: https://chromium-review.googlesource.com/902424
Cr-Commit-Position: refs/branch-heads/3325@{#312}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Updating XTBs based on .GRDs from branch 3325
[email protected]
Change-Id: I22f6e0ceea598a22e4c80873ac926d8c9ea4985f
Reviewed-on: https://chromium-review.googlesource.com/902387
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#311}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Reland] Make scroll bounds include subpixel accumulation
This relands r532919 which was reverted in r533667
The original patch worked only in the initial case but the corrected
layer bounds were clobbered in
ScrollingCoordinator::ScrollableAreaScrollLayerDidChange. Even though
CompositedLayerMapping::UpdateScrollingLayerGeometry is always called
after this method, in ScrollingCoordinator the bounds are set directly
on the WebLayer. In CLM we set the bounds on a GraphicsLayer which
caches the size itself. It'll only update the WebLayer bounds if the
new size differs from the cached size. Thus, even though the bounds
were changed in ScrollingCoordinator, CLM would early out since it
the GraphicsLayer size hasn't changed.
This CL applies the same fix in ScrollingCoordinator and also adds a
new test that covers the linked bug more end-to-end.
The original patch is uploaded in patchset 1 for easy diff'ing.
Bug: 801381
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I28f7088ef6b429875c6c984c45fd1c53cf813c02
Reviewed-on: https://chromium-review.googlesource.com/897962
Reviewed-by: Tien-Ren Chen <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533913}(cherry picked from commit 19916d2994c0bcd456b159af78da4ab73af45270)
Reviewed-on: https://chromium-review.googlesource.com/902303
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#310}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[browser nav] Have singleton disposition behave differently from switch
We had SINGLETON_TAB and SWITCH_TO_TAB dispositions sharing a code
path. This change separates them such that singletons only search in
the current window for a tab, and fall-back to new-foreground-tab
instead of current-tab.
[email protected]
(cherry picked from commit cc983247c218b60efbf1de5fe3e1f6f12dcaf160)
Bug: 807171, 807550
Change-Id: I0fb3bb75806269df0916359d4c89246640241660
Reviewed-on: https://chromium-review.googlesource.com/896745
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Kevin Bailey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534279}
Reviewed-on: https://chromium-review.googlesource.com/902195
Reviewed-by: Kevin Bailey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#309}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Chrome data use ascriber: Maintain set of in-flight requests
Maintain a set of in-flight requests. When a render frame is deleted,
then all requests pointing to that frame are also deleted from the set.
Bug: 806732
Change-Id: Ie5b74271c426d68896fe6c428e55d9b8547dc572
Reviewed-on: https://chromium-review.googlesource.com/898004
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533902}(cherry picked from commit 36d852747003eb05955b4f5fb1a7da5abc50d450)
Reviewed-on: https://chromium-review.googlesource.com/902302
Cr-Commit-Position: refs/branch-heads/3325@{#308}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Stop tracking requests that happen after the next page load starts
The ChromeDataUseAscriber should stop tracking requests after the
renderframe is deleted or the next page load in the same frame has
commit (DidFinishNavigation).
This might fix the crash, but it's not guaranteed to.
Bug: 806732
Change-Id: I472b19dfc3d7adf8fafaff2c54374a37bf34bd4e
Reviewed-on: https://chromium-review.googlesource.com/895239
Commit-Queue: Ryan Sturm <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533420}(cherry picked from commit 5be2dd760e900f38144d3984f3311d8bd45a9b38)
Reviewed-on: https://chromium-review.googlesource.com/902010
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#307}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix a hang on 10.11 caused by -[MDHoverButton layout] making itself need layout.
Updating self.image (on an NSButton subclass) in -layout or -viewWillDraw both
seem to lead to an infinite loop in 10.11. I'm not sure if there's a better way
to fix this; using different triggers to update the image seems safest.
Bug: 805109
Change-Id: I468576069f44eae4a2f4b9058e078d88d157265a
Reviewed-on: https://chromium-review.googlesource.com/899586
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534137}(cherry picked from commit 68c11e3d47cf1c43db3b36b7a63c9a6914640016)
Reviewed-on: https://chromium-review.googlesource.com/901990
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#306}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Merged: [wasm][streaming] Call Abort without reason when executed in ScriptForbiddenScope
It can happen that WebAssembly.compileStreaming gets aborted when we
are not allowed to execute JavaScript code, and therefore are also not
allowed to reject the promise returned by WebAssembly.compileStreaming.
This can happen e.g. when the Chrome tab gets refreshed, which aborts
all downloads.
With this CL we do not pass a reason to Abort if we are not allowed to
execute JavaScript code. On the V8 side we can check the reason passed
to Abort and do not reject the promise if there is no reason passed.
The V8 side change is at crrev.com/c/876091
Originally Reviewed-on: https://chromium-review.googlesource.com/876103
(cherry picked from commit dbd136e4a72ca0fdd09cb5f35306a4d4eb87c534)
Bug: chromium:803838
Change-Id: I55727f97fac38790cadc34ec5284131e13642f20
Reviewed-on: https://chromium-review.googlesource.com/901163
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#305}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cros: Add ContextMenu metrics for shelf and desktop
Add ContextMenuMetrics (User Journey Time, Show Source,
and Command Executed) to shelf and desktop.
Modified histograms.xml to include "Desktop" and "Shelf" components.
TEST=manual
[email protected]
(cherry picked from commit 76f7dab6f9ca078d11a0d1013293126a4de9a1d7)
Bug: 807035
Change-Id: If54d53ef71b3f4dfe12c144333980ac2a5281bf5
Reviewed-on: https://chromium-review.googlesource.com/896628
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534082}
Reviewed-on: https://chromium-review.googlesource.com/902007
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#304}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cc: Don't clamp tex coords for nearest neighbor filtering
This fixes bad font visuals on Pixel XL. It's unclear why this was not
happening on other platforms, but maybe clamping to 0.5 made the nearest
neighbor fall on the wrong pixel in some cases.
We should not be bothering to clamp when there is not bilinear filtering
on anyway, so this should be a positive change for all platforms in
terms of shader work.
[email protected]
(cherry picked from commit 0a7947a6984a2131616c5c24e7c6c4043ba60eb2)
Bug: 803374
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia81af34fbef2a33883c50582adbfc59ce2ae6714
Reviewed-on: https://chromium-review.googlesource.com/883944
Reviewed-by: weiliangc <[email protected]>
Commit-Queue: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531658}
Reviewed-on: https://chromium-review.googlesource.com/901952
Reviewed-by: enne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#303}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Reland "Bounce Blob URL revoking through the UI thread to give navigation a chance."
This is a reland of a3dd29b25f01eef7bf726aef971d554ed153a4f0.
Original change's description:
> Bounce Blob URL revoking through the UI thread to give navigation a chance.
>
> Navigation IPCs are handled on the UI thread so if a blob URL is revoked
> immediately after navigating the revocation will almost always happen before
> the navigation code has had a chance to post a task back to the IO thread to
> actually perform the request. With this change revocation is hopefully
> delayed just long enough to make navigation work again.
>
> Bug: 807639
> Change-Id: I2afde86dd203c61cbb03cc02ac62ec21c7e7d704
> Reviewed-on: https://chromium-review.googlesource.com/899666
> Reviewed-by: Jochen Eisinger <[email protected]>
> Commit-Queue: Marijn Kruisselbrink <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#534119}
[email protected], [email protected], [email protected]
(cherry picked from commit 8a5561649b9567c394ef1ff1619745b02ed7759d)
Bug: 807639,808759
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5033422d57ac7672e761045f7871c6aed29368b9
Reviewed-on: https://chromium-review.googlesource.com/900191
Commit-Queue: Reilly Grant <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534257}
Reviewed-on: https://chromium-review.googlesource.com/902043
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#302}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cros: Do not enable password view after a successful authentication.
[email protected]
(cherry picked from commit 623c2298dd29ab1f41e560096f4b1aea5b8b74a2)
Bug: 808486
Change-Id: If818ae74618847671f6f0ed2ecddb2ed804fa429
Reviewed-on: https://chromium-review.googlesource.com/900131
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534167}
Reviewed-on: https://chromium-review.googlesource.com/901944
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#301}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix compile on M-65 branch (ax enums)
The refactor of ax_enums.idl (CL:877417) was not merged to M-65, but
CL:899505 had a dependency on that.
Change the enum to the old version so M-65 compiles without CL:877417.
BUG=803700
Change-Id: I0f79b25697f2354f764c13e9e7b406840133a5e4
Reviewed-on: https://chromium-review.googlesource.com/901283
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#300}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Use Android's threaded inputconnection for N+
As Android has implemented InputConnection#getHandler() in N,
the workaround from
https://docs.google.com/document/d/1MxICLxUwVwt1ofzEvJFkTnjt8t1rwHWmc-SthS9BrIU/edit
is no longer required for Android N+.
One side effect of the workaround is that it causes input to restart
on window focus loss. Therefore, in a situation where a dialog window
shows up, input gets restarted. Using InputConnection#getHandler()
properly on N+ fixes this problem.
BUG=807711, b/69940860, b/72659116
Change-Id: If7349c6565ac0465e9010c2c2d61f1c95ae0e2e3
Reviewed-on: https://chromium-review.googlesource.com/894499
Commit-Queue: Changwan Ryu <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533416}(cherry picked from commit 46a717901c025f96777bdc5963efbf9658c9e1de)
Reviewed-on: https://chromium-review.googlesource.com/901904
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#299}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}No eager creation of CanvasResourceProvider when canvas 2d bridge is created
This is a partial revert of the big refactoring CL
https://chromium-review.googlesource.com/c/chromium/src/+/864630. That CL
made the creation of CanvasResourceProvider for canvas 2d earlier at the point
of time when Canvas2DLayerBridge is created; this changed the code paths of
some instances and should not belong to a refactoring CL that is not intended
to change behavior.
Bug: 806066
Change-Id: I00493338f6bda4a9ea17ee01db2dcab29223398c
Reviewed-on: https://chromium-review.googlesource.com/896084
Reviewed-by: Justin Novosad <[email protected]>
Commit-Queue: Olivia Lai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533820}
Reviewed-on: https://chromium-review.googlesource.com/900453
Reviewed-by: Olivia Lai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#298}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}HttpCache::Transaction::Read should be able to handle an extra Read.
There was an extra Read being invoked by the consumer of
HttpCache::Transaction in some cases and the transaction state machine
was not handling it well (crashing with dcheck/infinite loop in DoLoop).
This CL fixes the handling.
Tested that the unit test indeed asserts without the fix if dcheck is
enabled (if not, the DoLoop will go in an infinite loop since we were
entering it with next_state_ set as STATE_NONE and then in the while
loop setting it as STATE_UNSET).
Test: net_unittests --gtest_filter=HttpCache.SimpleGET_ExtraRead
Bug: 806344
Change-Id: I8b9472b48b15ed9f6c2132863f66941010b7aa52
Reviewed-on: https://chromium-review.googlesource.com/896145
Commit-Queue: Shivani Sharma <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533693}(cherry picked from commit ecc43a2f3233d5c3189f6fc79c13aa5f714c9e4c)
Reviewed-on: https://chromium-review.googlesource.com/901703
Reviewed-by: Shivani Sharma <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#297}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Prepare mojom for new Skia color types.
Bug: skia:7533
Change-Id: If19339a4a0aaa8ea655184db054058ea2697c6f3
Reviewed-on: https://chromium-review.googlesource.com/887381
Commit-Queue: Brian Salomon <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Florin Malita <[email protected]>
Reviewed-by: Mike Klein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#532698}
(cherry picked from commit 8ae77702133e0921f9a6491eb3b6c5f1db67c885)
[email protected]
Bug: 779428
Change-Id: Iaa32246899f64fb4704fa6c7d17ffb1528667cce
Reviewed-on: https://chromium-review.googlesource.com/901366
Reviewed-by: Brian Salomon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#296}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Merge to M-65] Password page analyzer fix.
This CL fixes typo password_inputs->explicit_password_inputs. Which in some rare situations
leads to crash.
[email protected]
(cherry picked from commit 088743f463ba5016acca31192cf93c6b7bbdb913)
Bug: 805892
Change-Id: Ibe76806154e7172a4d433d51ec92fb20ba0d900c
Reviewed-on: https://chromium-review.googlesource.com/893298
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Vadym Doroshenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532870}
Reviewed-on: https://chromium-review.googlesource.com/901463
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#295}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Don't pass invalid modifier to eglCreateImageKHR
[email protected]
(cherry picked from commit a4ccd7d32c922d3af2af8c2ebed44d3fd0338c88)
Bug: 808240, 789292
Change-Id: Id87f4ecaa93acb3cc1b84cf304e7a99db816d0b6
Reviewed-on: https://chromium-review.googlesource.com/898542
Reviewed-by: Daniele Castagna <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534266}
Reviewed-on: https://chromium-review.googlesource.com/901362
Cr-Commit-Position: refs/branch-heads/3325@{#294}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix wrong RenderView history.
This fixes https://crbug.com/796561 and adds a regression test.
The issue was a race between the browser and renderer processes while
updating the renderer's history.
The renderer's history is updated in
* RenderFrameImpl::CommitNavigation and in
* RenderFrameImpl::DidCommitProvisionalLoad.
┌────────┐ ┌───────┐
│Renderer│ │Browser│
└───┬────┘ └───┬───┘
│ BeginNavigation │
│ - url=iframe.html │
│ - history_offset = 0 │
│ - history_length = 1 │
1) │ ──────────────────────────> ┐
│ │ │
│ DidCommitProvisionalLoad │ │
│ - "pushState" │ │
│ - history_offset = 1 │ │
│ - history_length = 2 │ │
2) │ ──────────────────────────> │
│ │ │
│ CommitNavigation │ │
│ - url=iframe.html │ │
│ - history_offset = 0 │ │
│ - history_length = 1 │ │
┌─│ <───────────────────────────┘
│ │ │
│ │ DidCommitProvisionalLoad │
│ │ - url=iframe.hmtl │
│ │ - history_offset = 0 │
│ │ - history_length = 1 │
└>│ ──────────────────────────>
┌───┴────┐ ┌───┴───┐
│Renderer│ │Browser│
└────────┘ └───────┘
What happens in the bug.
1) An iframe is created: [history.offset = 0, history.size = 1].
2) history.pushState: history is updated [offset = 1, size = 2].
3) CommitNavigation is received, history is updated using the old
values transmitted in 1) with BeginNavigation.
This CL update the values sent in CommitNavigation. This reduce
considerably the duration when the race can happen.
Before this CL, the race could happen if a history.pushState is sent in
between BeginNavigation and CommitNavigation (~300ms <-> severals
seconds). After this CL, the race happens if the history.pushState is
sent between when the CommitNavigation message is sent and when it is
received by the renderer process.
[email protected]
(cherry picked from commit 841b1d49851beaf63a447187d013948c10b901d4)
Bug: 796561
Change-Id: I7bf72fadbf9f4946da28126a394adddf051f49a8
Reviewed-on: https://chromium-review.googlesource.com/881171
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533233}
Reviewed-on: https://chromium-review.googlesource.com/901262
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#293}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Roll src/third_party/catapult/ b4706e73204..12ffa8933 (63 commits)
https://chromium.googlesource.com/catapult.git/+log/7c98d04db58b..12ffa8933991
$ git log b4706e73204..12ffa8933 --date=short --no-merges --format='%ad %ae %s'
(cherry picked from commit 6e232c773e850e3ce635a2f82ce36c162c6ff6db)
Bug: 807235
Change-Id: Ib4c04acf464af9c67ff49cd619179eaa758fa008
Reviewed-on: https://chromium-review.googlesource.com/899282
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#292}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}CSP: initial blank page inherits 'self'.
Content-Security-Policy: The CSP source 'self' is usually the origin of
the current document. Immediately after an new window or new frame is
created, there are no current document. In this case, the origin used is
the one of the opener (in case of a new window) or the parent (in case of a
new iframe).
For you intention: The frame's CSP are already the one of its opener when
there are still no committed document. It makes sense to do the same
with 'self'.
Several web platform tests are added.
Bug: 807206
Change-Id: I2acf66d9b6d63d4efb14370a4d0ff2206c943aeb
Reviewed-on: https://chromium-review.googlesource.com/895589
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534017}(cherry picked from commit 08357eedcc386b14bb39d06ed93c00b3cabb09d3)
Reviewed-on: https://chromium-review.googlesource.com/901242
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#291}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[css-grid] Allow alignment of in-flow items with non-static positions
This is a fix for a regression introduced in r515391, where we landed
the implementation of alignment for positioned objects in a Grid Layout
container.
We assumed that items with non-static positions shouldn't honor the
CSS Box Alignment properties. This is only true for out-of-flow items,
absolute or fixed positioned elements. However, sticky positioned
elements are treated as relative positioned items, but they indeed use
non-static position to define their behavior.
Bug: 806622
Change-Id: Ibaed2c36530d81223d1491def9022e82cf9c3525
Reviewed-on: https://chromium-review.googlesource.com/897949
Commit-Queue: Javier Fernandez <[email protected]>
Reviewed-by: Manuel Rego Casasnovas <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534029}(cherry picked from commit a123787c6df637b7e7b33fef67e15a587978110f)
Reviewed-on: https://chromium-review.googlesource.com/901162
Cr-Commit-Position: refs/branch-heads/3325@{#290}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Merge to M65] Fix crash for Unicorn on Chrome OS, on sign out from another device
Bug: 807568
Change-Id: Id9b249fdbacfcd7b64cc7256a33204778f437450
Reviewed-on: https://chromium-review.googlesource.com/897671
Commit-Queue: Kush Sinha <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534015}(cherry picked from commit 33e995f35177ad856a7d96c18d0a25f831e21b11)
Reviewed-on: https://chromium-review.googlesource.com/899251
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#289}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Add Finch flag for Sole integration
Sole integration needs to know whether it's enabled or not before
native is loaded, so it's cached in shared preference, and requires
restarting twice after the flag is modified.
[email protected]
(cherry picked from commit deff0806da23403cf3f1b2ae114e8f0877a77751)
Bug: 778805
Change-Id: I5885b2fb44990d6bb0cdcbba4cc382772c5732be
Reviewed-on: https://chromium-review.googlesource.com/875322
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530437}
Reviewed-on: https://chromium-review.googlesource.com/900706
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#288}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.48
[email protected]
Change-Id: Ide0a4f78b188f2f76c0fe830e23c7423700ff8b8
Reviewed-on: https://chromium-review.googlesource.com/900251
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#287}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.47
[email protected]
Change-Id: I738f7366954ec551b9bc75d7398d5e1cb6a1f0bb
Reviewed-on: https://chromium-review.googlesource.com/899589
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#286}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Set CanvasResourceHost when canvas replaces its canvas2d layer bridge
Bug: 807636, 807427
Change-Id: Ic5fe5abbf5deaed883c005280fd8418cf49ca9d2
Reviewed-on: https://chromium-review.googlesource.com/899962
Commit-Queue: Olivia Lai <[email protected]>
Reviewed-by: Mohammad Reza Zakerinasab <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#534152}
Reviewed-on: https://chromium-review.googlesource.com/900455
Reviewed-by: Olivia Lai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#285}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Views: Do not animate HTTP_SHOW_WARNING to DANGEROUS transition
This transition (which is currently only possible with an experiment enabled)
can look messy/confusing when animated, so do not animate it.
[email protected]
(cherry picked from commit 6bf91042a211c2ebda9fbe206c8f3f08952a1dbc)
Bug: 807075
Change-Id: Ib7bda303958739cd4840dbc57910c1c850c5e97a
Reviewed-on: https://chromium-review.googlesource.com/891630
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Emily Stark <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533312}
Reviewed-on: https://chromium-review.googlesource.com/900828
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#284}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Mac: Do not animate HTTP_SHOW_WARNING to DANGEROUS transition
This transition (which is currently only possible with an experiment enabled)
can look messy/confusing when animated, so do not animate it.
Bug: 807075
Change-Id: I1dae69b64e0e9f457b87abf7c4ff45ba1f595dad
Reviewed-on: https://chromium-review.googlesource.com/891587
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Emily Stark <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533319}(cherry picked from commit b3bb303745ee75bf22d08914bac63e03c9753de7)
Reviewed-on: https://chromium-review.googlesource.com/900560
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#283}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.46
[email protected]
Change-Id: I334217f9fd2d0e17ba16bc7dc27d88d64122529b
Reviewed-on: https://chromium-review.googlesource.com/899457
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#282}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.45
[email protected]
Change-Id: I9179b4956ca0623725297fa3add838564964a58e
Reviewed-on: https://chromium-review.googlesource.com/899456
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#281}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}DevTools: fix "other service workers" collapsing
"other" service workers section should only collapse when the label was
clicked.
(cherry picked from commit 9af875ff294055fc805828d6ab3b5a57a5a5231f)
Bug: 807232
Change-Id: Ib048968ed555121c385a176a602a84a00853b152
Reviewed-on: https://chromium-review.googlesource.com/897913
Commit-Queue: Andrey Lushnikov <[email protected]>
Reviewed-by: Andrey Lushnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533752}
Reviewed-on: https://chromium-review.googlesource.com/900326
Cr-Commit-Position: refs/branch-heads/3325@{#280}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.44
[email protected]
Change-Id: I5cba8c7393e68a4337434cda19701e0ea687b891
Reviewed-on: https://chromium-review.googlesource.com/900248
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#279}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.43
[email protected]
Change-Id: Id9345c4ec5eab6c6f71e1d2e3d1af49a7291e5f1
Reviewed-on: https://chromium-review.googlesource.com/899736
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#278}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cc: Defer impl-side invalidations for main frame with sync scheduling.
With sync scheduling, we don't have a draw deadline that can be used to
predict whether the main thread will commit before it. Since the
heuristic for detecting this does not for the sync scheduling case,
currently we default to assume it to be slow and always perform the
invalidation at the beginning of frame. This will result in more raster
and block the main thread from committing.
This change ensures that with sync compositing, we always defer the
invalidation in order to merge with the main frame.
R=[email protected]
Bug: 794986
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: If56ad4136de91d999dcf3423a90580ba64a1ccb1
Reviewed-on: https://chromium-review.googlesource.com/895188
Reviewed-by: Brian Anderson <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533599}(cherry picked from commit 10d3a66963310f7dc33b4f6478304439784da28e)
Reviewed-on: https://chromium-review.googlesource.com/900462
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#277}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix for crash during Android camera capture
See https://bugs.chromium.org/p/chromium/issues/detail?id=806440
This CL adds a null check to prevent a NullPointerException.
Bug: 806440
Change-Id: I7106de9d1a9bbdfa3dd0bdb3fbfd3315d611f8d2
Reviewed-on: https://chromium-review.googlesource.com/891810
Commit-Queue: Christian Fremerey <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532640}(cherry picked from commit 8003dfaffa26b9482ff4591ce2ee6c2bbe6e77de)
Reviewed-on: https://chromium-review.googlesource.com/900322
Reviewed-by: Christian Fremerey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#276}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cros: Do not use views::Button for PIN keyboard.
[email protected]
(cherry picked from commit f2f63601fbd44cea4b3823c4896d78cf26fa04d1)
Change-Id: Idaa6a2eefc94166e95d75ff726a704c5e071b16d
Reviewed-on: https://chromium-review.googlesource.com/889716
Commit-Queue: Jacob Dufault <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533389}
Bug: 803700
Reviewed-on: https://chromium-review.googlesource.com/899505
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#275}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cros: Increase touch target size of pin buttons on lock.
[email protected]
(cherry picked from commit 91ac7466a8e24b1837a180949ddfd9a631a09a62)
Bug: 803700
Change-Id: Ie88645a2ec0244b6f5870fdb3187087e918e8855
Reviewed-on: https://chromium-review.googlesource.com/884561
Commit-Queue: Jacob Dufault <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533134}
Reviewed-on: https://chromium-review.googlesource.com/899504
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#274}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[IMGDecode] Fix OOPIF case of accessing the wrong LTH.
This patch ensures that we don't go through GetPage() in order to
reach the destination LTH for the decode API.
[email protected]
[email protected]
(cherry picked from commit 1e108dcc39d6ee6e4fc16b9135a25dc26149ba00)
Bug: 807164
Change-Id: I8bc3242c5d54682e6a907f85762fd29c8d3104e6
Reviewed-on: https://chromium-review.googlesource.com/894173
Commit-Queue: vmpstr <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533396}
Reviewed-on: https://chromium-review.googlesource.com/899955
Reviewed-by: vmpstr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#273}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix incorrect placeholder text in feedback dialog.
Changes:
Avoid showing description placeholder if it is undefined.
[email protected]
BUG=803030
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iecdfddaa53dc0cb1343b5ba66060df74cbc6da87
Reviewed-on: https://chromium-review.googlesource.com/874550
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530597}(cherry picked from commit 58f6e6d431069413ac0dabd478f0b1956a1babf5)
Reviewed-on: https://chromium-review.googlesource.com/899544
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#272}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Remove the logic for skipping the persistence of network
quality when it matches the typical quality of the network
Bug: 806949
Change-Id: I02c8db315200e7ab28f72a0627015be15d8cfc4e
Reviewed-on: https://chromium-review.googlesource.com/890859
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532636}(cherry picked from commit 6b1d4918f33619719fa2360ada662f1d6e97070c)
Reviewed-on: https://chromium-review.googlesource.com/900143
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#271}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Updating XTBs based on .GRDs from branch 3325
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I71ab28ffd6e35bd47300ecffef40d10d133f2a6c
Reviewed-on: https://chromium-review.googlesource.com/900082
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#270}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Set IsScrollAnchorObject in FindAnchor
If this bit isn't set, crashes can happen because the anchor object
isn't properly cleaned up after being removed from the DOM. Rather than
adding a call to SetIsScrollAnchorObject at the problem call site, it
seemed easier to just ensure it was set by calling it in FindAnchor.
Bug: 806631
Change-Id: I6c12c65b83995b08d2fdaedd8d4f6b7f574fa692
Reviewed-on: https://chromium-review.googlesource.com/896562
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533770}(cherry picked from commit ac7518058eebc626aafa413cd292300014ba7a7b)
Reviewed-on: https://chromium-review.googlesource.com/900003
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#269}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Mark Feature Policy-related features as dependent.
This fixes the problem where Feature Policy can be independently
disabled through runtime flags (or chrome://flags), while the features
which depend on it, such as FeaturePolicyForPermissions, remain enabled.
[email protected]
(cherry picked from commit 0eefbc58ce72e1693e997d623c2799afc4bc3692)
Bug: 806362
Change-Id: Ied92dc74022a02f22a11c3ce68bd62c1aa98eaae
Reviewed-on: https://chromium-review.googlesource.com/893598
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532972}
Reviewed-on: https://chromium-review.googlesource.com/900050
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#268}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Introduce policy to allow web driver to function along site isolation.
Adds a policy that allows Site Isolation policies to be overriden by
the enable-automation flag.
BUG=800112
TEST=browser_tests.exe --gtest_filter=*SitePerProcessPolicyBrowserTest.*
[email protected]
(cherry picked from commit fac28008f27f0c889d9400c5f26a7e37be41a3c4)
Change-Id: I80003fa442c2f8afbd56fc3154d66fc9397858a4
Reviewed-on: https://chromium-review.googlesource.com/884582
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533633}
Reviewed-on: https://chromium-review.googlesource.com/899879
Cr-Commit-Position: refs/branch-heads/3325@{#267}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Make mouse events aware of root layer scrolls"
This reverts commit 4ca1c620a075f74d526126a0cb411217b0ba417a.
[email protected]
Bug: 802225
Change-Id: Ie9d964e67ae097713124f65d70b6d9204087866e
Reviewed-on: https://chromium-review.googlesource.com/899779
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#266}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[CrOS Tether] Add metrics for GATT connection success/failures.
This CL adds two metrics:
(1) Success rate for GATT connection attempts.
(2) Effective success rate for one or multiple connection attempts,
using retries if a previous connection failed (up to the maximum
number of retries).
These metrics aid in our ability to analyze what our effective
connection stability is.
[email protected]
(cherry picked from commit d87e25edb2924948b728832225c7097e5a8b9ef7)
Bug: 805219, 672263
Change-Id: I407c3af03eb86ccc80807395e1f18a5bff2b71a4
Reviewed-on: https://chromium-review.googlesource.com/894445
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533521}
Reviewed-on: https://chromium-review.googlesource.com/899910
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#265}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[CrOS Tether] Update connection retry attempt logic.
This CL re-submits a previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/889991
That CL was reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/895063
This CL uploads the original CL as patchset 1; the update which fixes
the broken tests is patchset 2.
Original CL description below:
Before this CL, we allowed 3 retries for the entire connection flow,
which includes advertising, scanning, creating a GATT connection, and
exchanging messages. However, it makes more sense to think of this as a
two-part process:
(1) Advertising and scanning. This portion always occurs when
attempting a BLE connection, even if the device we're trying to
contact is not nearby and cannot respond.
(2) Creating a GATT connection and exchanging message. This portion
only occurs when an Android host is nearby to respond to the
Chromebook.
Connection attempts which fail in part (2) above indicate that the
device actually is nearby and can potentially connect; additionally
connection failures during this part of the connection often will
succeed on a retry. Thus, this CL adds extra connection retry attempts
if a previous attempt failed in part (2).
[email protected]
(cherry picked from commit e0b27d14c02d8df7cef2befd6e6435225a2e9537)
Bug: 805218, 672263
Change-Id: Iafb9e1b7e84cb9bf557aeb3ce511bac679cc069c
Reviewed-on: https://chromium-review.googlesource.com/895388
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533456}
Reviewed-on: https://chromium-review.googlesource.com/899869
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#264}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[CrOS Tether] Provide extra data to BleConnectionManager observers.
This CL adds an extra StateChangeDetail parameter to the
Observer::OnSecureChannelStatusChanged() function. This parameter is
currently unused, but it will be used by a future CL to better handle
connection retries.
[email protected]
(cherry picked from commit 9a7a50d625e3fd7bd960925da552be97dbef64be)
Bug: 805218, 672263
Change-Id: I4dc80f324d74a6df54113b058dec0bb07459ae3f
Reviewed-on: https://chromium-review.googlesource.com/888038
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532510}
Reviewed-on: https://chromium-review.googlesource.com/899904
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#263}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Workaround for suspend happening to soon with views lock
Adds additional delay before views screen locker reports to
PowerEventObserver it's lock animations have finished. The goal is to
add more time between lock window UI being shown and device suspend
(more specifically stopping compositing on the root windows), and
thus prevent flash of non lock UI when showing lock screen after
device resume.
The issue surfaced by switching to views based lock UI - with webui
based lock screen, power event observer would wait for the animations
in web ui to finish before stopping the compositors, which added more
time (comared to views based solution) for the frame buffers to pick
up frame buffers from after lock window is shown.
BUG=807511
[email protected]
(cherry picked from commit 524994174827569d34d8dc69090b358c4dd8dfb5)
Change-Id: Iba75c03cf8058b19bed2dc6e791200a04252b603
Reviewed-on: https://chromium-review.googlesource.com/896577
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533553}
Reviewed-on: https://chromium-review.googlesource.com/899775
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#262}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Do not move the cursor if the cursor is invisible
Do not move the cursor if the cursor is invisible
when display configuration is changed. This was to
make sure that X11's cursor stays inside a display, as
reconfiguring display can potentially move the cursor
to outside of displays.
I think this is no longer a concern, and I'll
replace this with just a notification after merged to 65.
This also fixes the test harness that assumes the cursor
is visible by default but wasn't.
BUG=773479
TEST=covered by unit test. also tested on device.
Change-Id: I7debc957145318352f7ee3c858031091eb2a8e56
Reviewed-on: https://chromium-review.googlesource.com/890056
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533720}(cherry picked from commit ccfa74c42fb68d038a6a995278eff53f287fcc3e)
Reviewed-on: https://chromium-review.googlesource.com/899647
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#261}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Propagate inert state into subframes on fullscreen changes"
This reverts commit e8b02a53effabee8ecfc196b0a854f33c9e84771.
Reason for revert: build failure, see crbug.com/808396
Original change's description:
> Propagate inert state into subframes on fullscreen changes
>
> Bug: 805392
> Change-Id: Ie6cdb9ffd9c34ce9226553e61f855bd456749e7f
> Reviewed-on: https://chromium-review.googlesource.com/893718
> Reviewed-by: Dominic Mazzoni <[email protected]>
> Reviewed-by: Mounir Lamouri (slow) <[email protected]>
> Commit-Queue: Philip Jägenstedt <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#533391}(cherry picked from commit 818e182ca6da2b0eee55994b374723eec00b908e)
> Reviewed-on: https://chromium-review.googlesource.com/898882
> Reviewed-by: Philip Jägenstedt <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3325@{#256}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[email protected]
Change-Id: Idc20791f70eae1b559484b4a9c1fc15b646a64e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805392, 808396
Reviewed-on: https://chromium-review.googlesource.com/899702
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#260}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Always show sound in site settings on Android
This CL modifies the SingleWebsitePreferences setup to always show the
sound setting even when it's not currently set by showing the default
setting as selected.
Bug: 796873
Change-Id: Id7dec2bb0e75ee138dae95bbd219c569794d2b09
Reviewed-on: https://chromium-review.googlesource.com/889519
Reviewed-by: Finnur Thorarinsson <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532425}(cherry picked from commit f603fc5739f16f7557f7d9ca6d99e0e6efeb5536)
Reviewed-on: https://chromium-review.googlesource.com/898194
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#259}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}VR: Adjust URL bar icon size and position to look more like the spec
Note that the spec is based on different icons, so if we incorporate the
spec verbatim, the icons look too large. This change attempts to
visually match the spec, and we can circle back if the spec is updated.
BUG=804988
R=ymalik
[email protected]
(cherry picked from commit 8e08ec484fe160a1002fa9c8beae340413f0eaba)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaec15827fa2178f66c39e409baedd3560a1eb4de
Reviewed-on: https://chromium-review.googlesource.com/881557
Reviewed-by: Ian Vollick <[email protected]>
Commit-Queue: Christopher Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531546}
Reviewed-on: https://chromium-review.googlesource.com/899045
Reviewed-by: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#258}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[NTP Snippets] Revert RemoteSuggestionsFetcher usage of IdentityManager
This CL reverts the following two CLs:
- "[NTP Snippets] RemoteSuggestionsFetcherImpl test uses IdentityTestEnv"
(fce90bed4910ce81836dca45bc923bda6220d278)
- "[NTP Snippets] Have RemoteSuggestionsFetcherImpl use IdentityManager"
(683639a46be8c1a9c4ee278fe518bccd1a3ef0c5)
The reason is that the production change caused a regression in NTP
Snippets: on signout, an unauthenticated fetch of snippets is no longer
performed. The underlying cause is that IdentityManager being notified of
signout (and changing its internal state) currently races with NTP Snippets
itself being notified of signout (and starting its flow to refetch
snippets).
This is a straight revert with three minor exceptions:
- There was a minor amount of conflict resolution to do due to
intervening changes of base::MakeUnique to std::make_unique
- The //services/identity API additions in fce90bed were *not* reverted
as they are used by code that has subsequently landed in the tree.
- Similarly, the //components/ntp_snippets/BUILD.gn changes were not
reverted as those dependencies are now used on trunk even without
these changes.
This CL itself should be able to be reverted once I have fixed the above
race by ensuring that IdentityManager is notified of signin/signout events
before any observers of SigninManager. Note that in the long term this
won't be a problem as there will be no external observers of SigninManager.
To test this change, do the following:
- Sign in to Chrome on Android (in a chrome_apk build if building locally)
- Observe that there are personalized suggestions on the NTP
- Sign out
- Observe that there are different, generic suggestions on the NTP
[email protected], [email protected]
(cherry picked from commit d8bd981fe9d407f8f6b5bd0071d7fdb4c1dd2690)
Bug: 804410
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I114c3c4805d855b646bb748d4e2c5c5e9a966c3b
Reviewed-on: https://chromium-review.googlesource.com/883321
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Jan Krcal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531511}
Reviewed-on: https://chromium-review.googlesource.com/899083
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#257}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Propagate inert state into subframes on fullscreen changes
Bug: 805392
Change-Id: Ie6cdb9ffd9c34ce9226553e61f855bd456749e7f
Reviewed-on: https://chromium-review.googlesource.com/893718
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Mounir Lamouri (slow) <[email protected]>
Commit-Queue: Philip Jägenstedt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533391}(cherry picked from commit 818e182ca6da2b0eee55994b374723eec00b908e)
Reviewed-on: https://chromium-review.googlesource.com/898882
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#256}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.42
[email protected]
Change-Id: I2d4cce634bf8a9d6bc22b081561ac3080a55ed91
Reviewed-on: https://chromium-review.googlesource.com/897753
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#255}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.41
[email protected]
Change-Id: I4334ac95cf7e9d5d3e2794325757d02fcb156b4b
Reviewed-on: https://chromium-review.googlesource.com/898327
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#254}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[CrOS Tether] Handle updated TetherAvailabilityResponse response codes.
This CL adds additional enum values to tether.proto and updates
HostScannerOperation to accept these updated enum values when GmsCore
notifications are disabled.
Note: This CL's contents were already landed in
https://chromium-review.googlesource.com/c/chromium/src/+/894729.
However, this CL needed to be merged to the M-65 branch, so I'm landing
two separate CLs and only merging this one to the M-65 branch.
[email protected]
(cherry picked from commit 2444b0b1192eb54b197c6a7f22eb721745aebca6)
Bug: 793936, 672263
Change-Id: If04c1a2e2f5123c2a156a4925c19d3f801b45877
Reviewed-on: https://chromium-review.googlesource.com/897411
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533897}
Reviewed-on: https://chromium-review.googlesource.com/897737
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#253}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Move focus to option button in translate bubble.
As the options button doesn't make the dialog bubble go away focus needs
to be moved to it.
Bug: chromium:806729
Change-Id: I78fcdfbf098d0b44b2beec47ec6446b09a89c6c2
Reviewed-on: https://chromium-review.googlesource.com/894858
Reviewed-by: Bret Sepulveda <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533464}(cherry picked from commit 5b2d1d1e3229e3af1d3687c3e9626664623f6166)
Reviewed-on: https://chromium-review.googlesource.com/898491
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#252}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Media Router] Convert string origin to Mojo origin in media_router_bindings
This CL adds back the string-to-Mojo-origin conversion removed in http://crrev.com/c/769570.
Assuming the crash seen in bug 787427 is due to users using outdated Media Router component extension (<=M59) which send origins as strings, this fixes the issue.
Bug: 787427
Change-Id: If93782a3bca3ebb2ba8d50c7b42ccbef0ba4363e
Reviewed-on: https://chromium-review.googlesource.com/894859
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533157}(cherry picked from commit 76c5e9706a56e4e53f97be7a88077e4a240ca0e9)
Reviewed-on: https://chromium-review.googlesource.com/898495
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#251}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[CrOS Tether] Fix browser crash during network configuration removal.
Before this CL, a crash could occur due to the following:
(1) Tether connection is active.
(2) Connection is lost to the underlying Wi-Fi connection.
TetherNetworkDisconnectionHandler is notified of this change, then
posts a new task to handle the disconnection.
(3) Before the new task is run, the Wi-Fi network is removed from
NetworkStateHandler.
(4) The task is run, and TetherNetworkDisconnectionHandler requests
that NetworkStateHandler return the network associated with the
disconnection.
(5) Since the network had been removed, NULL is returned.
(6) TetherNetworkDisconnectionHandler attempts to invoke the path()
function on the null pointer, resulting in a segfault.
This CL fixes the issue by obtaining and caching the network's path as
soon as the disconnection occurs instead of waiting until a later time
to fetch the path value.
As a result, this CL also refactors the way that
NetworkConfigurationRemover works; instead of taking a Wi-Fi network
GUID as a parameter, the class now takes the Wi-Fi network path as a
parameter.
[email protected]
(cherry picked from commit a51901e5154ce660fc9e706d6a2b63202a949325)
Bug: 806944, 672263
Change-Id: I074aa691ca533616516a3e624be71fde832f382f
Reviewed-on: https://chromium-review.googlesource.com/894497
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533495}
Reviewed-on: https://chromium-review.googlesource.com/898486
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#250}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Do not skip out-of-flow boxes merging anonymous flex items.
A misread of the spec made us skip out-of-flow boxes merging anonymous
flex items. Only merge anonymous flex items which are truly box
siblings.
Adjusted the wpt tests accordingly. Fwiw, Firefox nightly now passes
all of wpt/css/css-flexbox/anonymous-*
[email protected]
Bug: 788379, 806151
Change-Id: I124740e5d2150becdcc03ded26773a69607e0bbb
Reviewed-on: https://chromium-review.googlesource.com/895283
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533440}(cherry picked from commit 277af9187ad3574d0946f08de078e86971f54fee)
Reviewed-on: https://chromium-review.googlesource.com/898413
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#249}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}ext4-migration: Mount with the correct authorization info when starting migration.
The info was lost during a refactoring: 7803fe02870ac7833a30d3c71b15fe0aea159db
BUG=807856
TEST=manually try the migration
Change-Id: I5e986b53f099ce3c7c28bbb66fabf6eb7263521d
Reviewed-on: https://chromium-review.googlesource.com/897066
Reviewed-by: Satoru Takabayashi <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Commit-Queue: Kazuhiro Inaba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533580}(cherry picked from commit 41978a3923e22c69057a0910200b691d77c085a3)
Reviewed-on: https://chromium-review.googlesource.com/897283
Reviewed-by: Bernie Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#248}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Disable framebusting intervention for M65.
Bug: 624061
Change-Id: I0b863938467b81dae3fbecd17b23aaf6faffe2a7
Reviewed-on: https://chromium-review.googlesource.com/876508
Reviewed-by: Ojan Vafai <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530608}(cherry picked from commit 45582a715b2d4f41efc510d6196e6a232126f4fc)
Reviewed-on: https://chromium-review.googlesource.com/898264
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#247}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}NTLM over HTTP: Make NTLMv2 the default.
- Makes NTLMv2 the default version.
- This implicitly disables NTLMv1.
- Leaving the flag available for the first release with the
default changed.
- Subsequent release will remove the flag but leave a policy.
BUG=chromium:22532
Change-Id: Ibb2778806b2a19b70abbc5300d20e06327077fb8
Reviewed-on: https://chromium-review.googlesource.com/885509
Commit-Queue: Zentaro Kavanagh <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532552}(cherry picked from commit 1890a3d1f7d3ab7c9a857ae0233f34f28a0d43ba)
Reviewed-on: https://chromium-review.googlesource.com/898262
Reviewed-by: Zentaro Kavanagh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#246}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Add audio perception and human presence detection to MediaPerceptionPrivate API.
BUG=803706
Change-Id: I5c1d7476d27e9ce35e9bd758351e6ebc22e43771
Reviewed-on: https://chromium-review.googlesource.com/884008
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Wei Guan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533181}(cherry picked from commit c81c0cc311b4044338b2cad974c793086eabcdb7)
Reviewed-on: https://chromium-review.googlesource.com/897184
Reviewed-by: Simon Que <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#245}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Android: Fix depfile name collision in process_resources
If an apk had a post-process action defined, and then later it was
removed, the post-process depfile would become the process_resources.py
depfile.
Change-Id: I1b5d26f800772db6c25bd6a34ce5a7a3bed75f1c
Reviewed-on: https://chromium-review.googlesource.com/890172
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: Eric Stevenson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532313}(cherry picked from commit a04b788ba1f5ffa2ef62e334cdbcb7e271ac1a11)
Reviewed-on: https://chromium-review.googlesource.com/898102
Cr-Commit-Position: refs/branch-heads/3325@{#244}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Merge M65: "Attempt recovery of WASAPI audio output driver during Start()."
Per Microsoft, IAudioClient/IAudioRenderClient may be invalidated
at any time; even when we're not using them. If this occurs after
a Stop() event, we won't find out until the next Start() and will
subsequently fail (triggering an unrecoverable playback error; we
only have fallback for Open() failures).
Instead if we detect that either client has an error during Start(),
we will now re-attempt Open() and subsequently retry creation of the
clients. If this still fails, we'll then continue down the old path
of signaling an unrecoverable playback error.
BUG=803691
TEST=switching audio devices does recovers IAudioClient.
[email protected]
(cherry picked from commit c297aad42b62f7f443868da28b21ded199e93996)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I54f0377a483bcd4dca91e8cb82fe4e46366731fa
Reviewed-on: https://chromium-review.googlesource.com/875306
Commit-Queue: Dale Curtis <[email protected]>
Reviewed-by: Tommi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530983}
Reviewed-on: https://chromium-review.googlesource.com/897964
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#243}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix mirror mode restoring after resume
Background:
Upon suspend, DisplayManager::SetSoftwareMirroring(true) will be called to
clear current mirroring source and destination displays. But mirror mode
is not enabled because DisplayManager::OnNativeDisplaysChanged() will
receive empty display info and stop before reconfiguration. Later upon
resume, mirror mode will not be restored because the mirror info is cleared.
Changes:
Prevent DisplayManager::SetSoftwareMirroring(true) from clearing the
mirroring source and destination displays as they will be cleared later
in DisplayManager::OnNativeDisplaysChanged().
[email protected]
Bug: 797016
Change-Id: I5540b8f114b55431966cec23e30d3f0766cd252b
Reviewed-on: https://chromium-review.googlesource.com/897467
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#242}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Allow navigations to opener's site to go back into opener SiteInstance (Merge to M65)
Previously, when a popup and its opener were cross-site, and neither
site required a dedicated process, navigating the popup back to the
opener's site did not swap processes, so the two ended up in different
processes and couldn't script each other. Even though
DetermineSiteInstanceForURL contains logic to place same-site popups
into their opener's SiteInstance (added as part of the fix for a
similar issue 796912), this logic was never reached because we never
attempted a process transfer in this case, thanks to
IsRendererTransferNeededForNavigation() returning false.
This CL tweaks IsRendererTransferNeededForNavigation so that a
cross-process transfer is always attempted is such cases. This allows
DetermineSiteInstanceForURL to always place the popup that's going back
to its opener site into the opener's SiteInstance.
[email protected]
(cherry picked from commit cd5b76ea43df36e2d64447aec0f5da654543133f)
Bug: 807184
Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec
Reviewed-on: https://chromium-review.googlesource.com/894369
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533410}
Reviewed-on: https://chromium-review.googlesource.com/898063
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#241}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Refer tooltip text to root view.
With the new async hit-testing code, the RenderWidgetHostViewGuest-
specific code in RenderWidgetHostInputEventRouter::FindMouseEventTarget
no longer seems to be hit, and thus mouse events are bypassing the
embedder (and hence the BrowserPlugin) for PDFs.
This CL changes RenderWidgetHostViewGuest so that it refers tooltip
text requests directly to the root view, instead of sending them to
the BrowserPlugin.
[email protected]
(cherry picked from commit 4d39420bc8a69e9374b120df9e49828537d31f69)
Bug: 807236
Change-Id: Ic943e6bca70035fb5ac9198281412fbc6b7887f1
Reviewed-on: https://chromium-review.googlesource.com/894145
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533306}
Reviewed-on: https://chromium-review.googlesource.com/897055
Reviewed-by: James MacLean <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#240}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Do not verify |interface_provider_request| for ignored commits.
Previously, RenderFrameHostImpl::DidCommitProvisionalLoad required that
a non-null |interface_provider_request| was supplied for all cross-
-document navigation commits if a real load had already committed in the
FrameTreeNode.
The check was performed for all commits, including those that the
DidCommitProvisionalLoad method itself later ignored, which led to
false-positive renderer kills in the following scenario with
browser-side navigation and site-per-process enabled:
1) http://foo.test/main.html is loaded in a main frame.
2) Either statically in HTML, or dynamically by JS, a frame is added:
<iframe 'src=http://foo.test/f.html'/>.
3) The initial byte of the response for `f.html` arrives, causing
FrameMsg_CommitNavigation to be sent to the same renderer.
4) Just before processing this message, however, `main.html` navigates
the iframe to http://bar.test/g.html, which results in a mojom::Frame::
BeginNavigation call being made to the RenderFrameHost.
5) Suppose that immediately afterwards, `main.html` enters a busy-loop.
6) The cross site navigation in the child frame starts, the first response
byte arrives quickly, and thus the navigation commits quickly.
6.1) FrameTreeNode::has_committed_real_load is set to true for the child.
6.2) The same-site RenderFrame in the child FrameTreeNode is swapped out,
i.e. FrameMsg_SwapOut is sent.
7) The renderer for site instance `foo.test` exits from the busy loop,
and starts processing messages in order:
7.1) The first being processed is FrameMsg_CommitNavigation, so a
provisional load is created and immediately committed to
http://foo.test/f.html.
7.2) Because at the time the same-site child RenderFrame was created,
there had been no real load committed in the child frame, and because
the navigation from the initial empty document to the first real
document was same-origin, the global object is reused and the
RemoteInterfaceProvider of the RenderFrame is not rebound.
7.3) The obsoleted load in the same-site child frame commits, calling
mojom::Frame::DidCommitProvisionalLoad, however, with
|interface_provider_request| being null.
8) RenderFrameHostImpl::DidCommitProvisionalLoad sees that a real load was
already committed in the frame, but |interface_provider_request| is
missing, so kills the renderer.
9) RenderFrameHostImpl::DidCommitProvisionalLoad also sees that the frame
was waiting for a swap-out ACK, so ignores the commit.
Instead, step 8 and step 9 should be reversed: RFHI::DidCommitProvisionalLoad
should first check if the frame already IsWaitingForUnloadACK(), and, if so,
return immediately, without checking |interface_provider_request|.
[email protected]
(cherry picked from commit 1cb5c0e6614090575c3ba97ab42ff4bc3552b1b9)
Bug: 793228
Change-Id: I3e833502ff43d603f1e063098df07a16b5d4b7ec
Reviewed-on: https://chromium-review.googlesource.com/877239
Commit-Queue: Balazs Engedy <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532860}
Reviewed-on: https://chromium-review.googlesource.com/897426
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#239}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Merge to 65: Elements that are positioned should not be ignored for a11y
This fixes a bug with absolutely positioned webviews in apps
such as Hangouts.
Note that AutomationApiTest.LocationInWebView fails without the
change to AXLayoutObject.cpp.
Bug: 801995
Change-Id: I1a3e8e66f3f64b7ec6f619076374438aad901d65
Reviewed-on: https://chromium-review.googlesource.com/894182
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533239}(cherry picked from commit 34d909668cac06dca01a5dc072173bc59fdb999f)
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/897941
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#238}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Avoid NPE in ImeAdapterImpl
Adding missing isValid() checks from
https://codereview.chromium.org/2752113005/
Also removing mInitialized which can be misleading.
BUG=806724
Change-Id: I872b3ce27d6efb57dda65b6ae7b84abdf26c250c
Reviewed-on: https://chromium-review.googlesource.com/892106
Reviewed-by: Bo <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532885}(cherry picked from commit 926d2014b2851b3b88e04c830621c756430a6e17)
Reviewed-on: https://chromium-review.googlesource.com/897940
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#237}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[merge into M65] Use proto in ext inline install request and append recent navigations
To help diagnose the broken referrer chain problem to extension inline
install, we want to use Proto instead of JSON as the content format,
such that we can easily add more info to the request.
In addition, when referrer chain appears broken (completely empty, or
missing some entries), we are going to append recent navigation events
(quantity controlled by Finch) and send them for SBER/SCOUT users when
they are not in incognito.
[email protected]
(cherry picked from commit fc668ec17835f63e327d769a5cdb4c8a8b5cca24)
Bug: 780532
Change-Id: I37ee0e6bf7a5e295640fca3eee86cb249595c7f5
Reviewed-on: https://chromium-review.googlesource.com/850726
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533146}
Reviewed-on: https://chromium-review.googlesource.com/896868
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#236}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}OOPIFs: Make sure that ctrl-click opens a new *background* tab.
This CL makes sure that Blink code that needs to consult the current
input event considers events going either through WebViewImpl or
through a WebFrameWidgetImpl. The CL removes separately maintained
|current_input_event_| fields from WebViewImpl and WebFrameWidgetImpl
(the latter was never read anyway) and consolidates them into
a new class - CurrentInputEvent.
[email protected]
(cherry picked from commit 65a684afcd42cd137af94da8daefba4757232601)
Bug: 804838
Change-Id: I89430f3a73f38ef5842c57635602fb079c1a34ef
Reviewed-on: https://chromium-review.googlesource.com/887346
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532241}
Reviewed-on: https://chromium-review.googlesource.com/897908
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#235}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Merge to M65] Support using mirror account consistency on local new tab page.
Mirror account consistency can be required by an enterprise policy
or in case the signed in user is a child account.
This is done by adding the
"X-Chrome-Connected: enable_account_consistency=true" header to the
request. For regular requests, this is done by
chrome/browser/signin/chrome_signin_helper.cc's
FixAccountConsistencyRequestHeader, but the local new tab page uses
a different code path.
[email protected]
(cherry picked from commit 6bbdd0a46fbdf2fdf0c2569927c7e6512870741f)
Bug: 790970
Change-Id: I81c86075c2b7488639beb4e919d429d53411c6fb
Reviewed-on: https://chromium-review.googlesource.com/879141
Commit-Queue: Marton Hunyady <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532839}
Reviewed-on: https://chromium-review.googlesource.com/897511
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#234}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Merge M65] Fix off-center thumb of seekbar in reader mode appearance
The regression was introduced in https://crrev.com/c/874753. The thumb
became off-center on older version of Android.
Reference:
https://stackoverflow.com/questions/7404100/how-to-fix-seekbar-bar-thumb-centering-issues
Bug: 804256
Change-Id: I3155f35c57ef53014fa6e3e52dedc9c43ab72697
Reviewed-on: https://chromium-review.googlesource.com/879116
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530982}(cherry picked from commit 8c64c769c3ee8a114f26f0bf9a3d51c40e435f62)
Reviewed-on: https://chromium-review.googlesource.com/896643
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#233}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}ozone/drm: Don't ignore modifiers in GbmBuffer::CreateBufferFromFds()
We dropped the modifier as we chain to the GbmBuffer constructor in
GbmBuffer::CreateBuffersFromFds() and passed 0 for addfb_flags. When
we create the KMS framebuffer, this indicates that the kernel should
get the buffer layout from the BO instead of the modifier.
This works only as long as the modifier is one supported by this
legacy convention. Intel Y-tiling isn't, and as when we started using
that, this path started failing.
We need to pass the modifier from the handle along so that we can
create the KMS framebuffer properly. The few callers that create a
NativePixmapHandle from scratch have been changed to pass
DRM_FORMAT_MOD_INVALID so they still get the legacy implicit behaviour
they expect.
[email protected]
(cherry picked from commit e6ffc0214ade7768d2102847017dd8b4a6ba0423)
Bug: b:70546200, b:71416883, chromium:789292, b:69238712, b:68003124
Change-Id: If851a9933eefcfc552cc60b5e45aaf6e1a205c82
Reviewed-on: https://chromium-review.googlesource.com/885906
Commit-Queue: Kristian H. Kristensen <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532759}
Reviewed-on: https://chromium-review.googlesource.com/896985
Cr-Commit-Position: refs/branch-heads/3325@{#232}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}native_pixmap: Don't use 0 to mean unspecified modifier
The modifier 0 means linear layout (DRM_FORMAT_MOD_LINEAR) which is
different from the legacy behavior of not specifying a modifier. When
a modifier is not specified, the exact layout (tiling, compression
etc) is communicated through some kind of driver specific back channel.
The few places that build a NativePixmapHandle from scratch want the
implicit legacy behavior, but passing 0 explicitly requests a linear
layout. We introduce gfx::NativePixmapPlane::kNoModifier (equal
to DRM_FORMAT_MOD_INVALID) to indicate that the caller wants the
legacy semantics.
[email protected]
(cherry picked from commit a9d98e665c9f8f15011fc892116249eed9c334c2)
Bug: b:70546200, b:71416883, chromium:789292, b:69238712, b:68003124
Change-Id: Ic7eb4838f53ffb30ede39709abd0bb4639223754
Reviewed-on: https://chromium-review.googlesource.com/885905
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Pawel Osciak <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Commit-Queue: Kristian H. Kristensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532706}
Reviewed-on: https://chromium-review.googlesource.com/895873
Cr-Commit-Position: refs/branch-heads/3325@{#231}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}ozone/drm: Use DRM_FORMAT_MOD_INVALID to indicate absence of modifier
Upstream has allocated DRM_FORMAT_MOD_INVALID as a special modifier
that indicates the absence of a modifier. This is the legacy mode
where the kernel gets the tiling/layout information through back
channels, typically as a property of the BO.
It's a little more concise that passing addfb_flags around as we did
before and can be encoded into the NativePixmap handle as well.
[email protected]
(cherry picked from commit dfe82f6e88be67a68eada8972a0895e33f1a0d76)
Bug: b:70546200, b:71416883, chromium:789292, b:69238712, b:68003124
Change-Id: I4340355e56d4117afebb06e1d96d4f8b93900a6e
Reviewed-on: https://chromium-review.googlesource.com/885904
Commit-Queue: Kristian H. Kristensen <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532536}
Reviewed-on: https://chromium-review.googlesource.com/895851
Cr-Commit-Position: refs/branch-heads/3325@{#230}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Prevent popping up Files app window with Incognito context for ZIP.
While 1+ incognito browser windows are opened, it'll have separate Files
app extension background and foreground scripts running. The ones in
the incognito context should only be visible by the file picker window
invoked by the browser, but should not show fullscreen app windows or
notifications.
This fix prevents opening a new Files app. window in incognito context
in these cases:
- When mounting a new zip file as a volume
- When reopening a zip file already mounted
(which navigates the current window to it)
Bug: 800543
Test: manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib3deccef39a9db61e6ff4d035a6de19c7309d113
Reviewed-on: https://chromium-review.googlesource.com/888192
Reviewed-by: Daichi Hirono <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533217}(cherry picked from commit 9210338d2c149f84e354cfa2484a72c4ed41d872)
Reviewed-on: https://chromium-review.googlesource.com/897285
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#229}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Zip Archiver: Prevent duplicated loading when opening ZIP file in Drive.
Once loading of an archive has been started, it should not start loading
the same file again.
Existing logic returns "EXISTS" error via fileSystemProvider API when
an archive is already mounted.
However, it missed handling of a case where user requested opening the
same archive while its loading is ongoing.
It typically happens when an archive is on Drive and not yet cached.
As a transitive fix, this change reuses the "scanning..." message to
indiacte that user need to wait operation finish in such case.
Bug: 807254
Test: manually tested on Files app as noted in the bug.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I90d5b8b2c157ea40b40ad106bbcb85b1bd022ea7
Reviewed-on: https://chromium-review.googlesource.com/895424
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533292}(cherry picked from commit f22c91d34b0eee473c31d80fb9d62b23fc2160b9)
Reviewed-on: https://chromium-review.googlesource.com/897382
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#228}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Zip Archiver: Disable storing mount and password info.
We are not restoring mount files at session restart anymore.
Therefore the mount information and passwords should not be persisted.
Othrewise it will be persisted until the user opens the same archive
again manually after a long time and the files will be opened without
requiring passwords.
Bug: 789073,803752
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idadcff694b20109eb7e31710b57d88400601d30a
Reviewed-on: https://chromium-review.googlesource.com/876705
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531467}(cherry picked from commit c3169366954d82dc6b35ad6a869907cde0d714cd)
Reviewed-on: https://chromium-review.googlesource.com/897284
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#227}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Merge: Updates preference.onPrefChaged dispatch to split incognito profile
Fixes two issues with how incognito extension prefs changes are
dispatched when the extension is in split incognito mode:
1. If an extension was incognito split, but not incognito enabled, the
incognito prefs changes were dispatched to the the extension's
original profile instance (even though extension in the original
profile generally cannot access incognito prefs). This CL does not
dispatch incognito pref changes to extensions that are not
incognito enabled.
2. If an incognito pref change was dispatched to an incognito split
extension when OTR profile was not around, in order to restrict
the preference to the OTR profile, DispatchEventToExtensions()
function would call Profile::GetOffTheRecordProfile which would
create an OTR profile instance. This cl avoids this issue by
dropping the events that are expected to be restricted to a
non-existent OTR profiles
(Note: if the pref value changed in the original profile, and there
is no incognito specific pref value, the value change is reported
for the incognito pref, too),
BUG=796814,805480
[email protected]
(cherry picked from commit 1324ea47d5870af00fccd488d06bb1bf68d00947)
Change-Id: I093949c9f9123e3baaab56932903f4f2be55903c
Reviewed-on: https://chromium-review.googlesource.com/882508
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532128}
Reviewed-on: https://chromium-review.googlesource.com/896864
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#226}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.40
[email protected]
Change-Id: I4b3186c6540f04dc1e9c695eec1af71390679658
Reviewed-on: https://chromium-review.googlesource.com/896706
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#225}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.39
[email protected]
Change-Id: Iaf89d0f5b3c7cb5c4389c784f49fa80e83066212
Reviewed-on: https://chromium-review.googlesource.com/896983
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#224}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Stop Files app in the incognito context to react to device events.
While 1+ incognito browser windows are opened, it'll have separate Files
app extension background and foreground scripts running. The ones in
the incognito context should only be visible by the file picker window
invoked by the browser, but should not show fullscreen app windows or
notifications.
- Prevent duplicated "Removable device detected" notifications
(when no DCIM folder in it)
- Prevent duplicated Files app windows popup
(when plugging a disk with /DCIM directory)
- Files app fullscreen mode opened with incognito context (which caused
some errors), when clicking the "show in folder" link in "Removable
device detected" notification.
- Other duplicated notifications such as "formatting finished".
This is reland of crrev.com/c/861589 with some tweak.
Bug: 800658
Test: manually tested as noted above
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7c9fbfb4bbf25d40228895d5f5836bb9caa1f5fa
Reviewed-on: https://chromium-review.googlesource.com/886661
Reviewed-by: Daichi Hirono <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532765}(cherry picked from commit c3951527be651a695ea440e684478eec4186a254)
Reviewed-on: https://chromium-review.googlesource.com/896902
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#223}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Updating XTBs based on .GRDs from branch 3325
[email protected]
Change-Id: If78f519828341e62435da8ca4a74da3418e2a220
Reviewed-on: https://chromium-review.googlesource.com/896824
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#222}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Reland "Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen.""
This is a reland of d79797fb8e103e4816291ef835447c1a72f8fe8d.
Relanding after DEPS have been updated.
[email protected], [email protected]
Original change's description:
> Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen."
>
> This is a reland of 69f0b0d21dc6a3d97bfa4cb059193db99cb00051.
> (Relanding to pick up resource file change.)
>
> Original change's description:
> > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen.
> >
> >
> > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo
> > to it.
> >
> > BUG=805507
> >
> > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03
> > Reviewed-on: https://chromium-review.googlesource.com/889916
> > Reviewed-by: Mitsuru Oshima <[email protected]>
> > Commit-Queue: Alexander Alekseev <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#532221}
>
> [email protected]
>
> Bug: 805507
> Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/891562
> Reviewed-by: Alexander Alekseev <[email protected]>
> Commit-Queue: Alexander Alekseev <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#532599}
(cherry picked from commit f21ddbca744f7a50c404be13bac1871b502b3120)
Bug: 805507
Change-Id: Iaa8e7a4d45d38683a3c06346ddaa53a349ab6a91
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/892360
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532755}
Reviewed-on: https://chromium-review.googlesource.com/896795
Cr-Commit-Position: refs/branch-heads/3325@{#221}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Always use backpressure for fetch"
This reverts commit e0eac774de0cea10625eea2cb68f70310b05f764.
Reason for revert: this patch breaks DevTools protocol, see crbug.com/807483
Original change's description:
> Always use backpressure for fetch
>
> Previously, backpressure would only be applied to fetch responses if the
> Cache-Control: no-store header was set. This was to avoid blocking other
> resource loads that might have to wait for the lock on the http disk
> cache that was held by the resource load to which backpressure was being
> applied.
>
> As of https://chromium-review.googlesource.com/684615 the disk cache
> supports multiple concurrent writers and so this protection is no longer
> needed.
>
> Remove support for the non-backpressure mode and always apply
> backpressure.
>
> The fact that the body is no longer implicitly read is visible
> to tests that observe the result of the fetch() via a side
> channel, specifically inspector and browser tests. Fix such tests
> to explicitly read the body to completion.
>
> Additionally, in order to satisfy the presubmit check, make
> SharedMemoryDataConsumerHandle::Context::on_reader_detached_ a
> OnceClosure.
>
> The implementation already implicitly ran on_reader_detached_ at most
> once, because is_on_reader_detached_valid_ would be set to false by
> ResetOnReaderDetached immediately after PostTask was called. Now this
> has been made explicit by using OnceClosure.
>
> on_reader_detached_ is only reset on the writer_task_runner_
> thread. When the closure is not run this is implemented by the logic in
> ResetOnReaderDetached(), the same as before. When the closure is run the
> behaviour has changed slightly: the OnceClosure is moved into the task
> that is posted to the writer_task_runner_ thread, where it will be
> destroyed automatically after running. There's no nead for a separate
> reset in this case.
>
> BUG=535793
>
> Change-Id: I9d2b58e183b84640afc153ac99de08fdc2368240
> Reviewed-on: https://chromium-review.googlesource.com/861695
> Commit-Queue: Adam Rice <[email protected]>
> Reviewed-by: Yutaka Hirano <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#530070}
[email protected], [email protected], [email protected]
(cherry picked from commit 4098fded9a86d2a47cddd5ed025695b6308e48b2)
Bug: 535793
Change-Id: I79a176496f6fada40ba8f2e4d95848421809ecee
Reviewed-on: https://chromium-review.googlesource.com/894683
Reviewed-by: Andrey Lushnikov <[email protected]>
Commit-Queue: Andrey Lushnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533153}
Reviewed-on: https://chromium-review.googlesource.com/896744
Cr-Commit-Position: refs/branch-heads/3325@{#220}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Chrome OS: Change Child account notification.
(cherry picked from commit 4651672b46455cddd341c549d4fa1ce16e82212c)
Bug: 806913
Change-Id: I57a57c860097187d24c5a9727e5cee2ffc591b31
Reviewed-on: https://chromium-review.googlesource.com/894494
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533090}
Reviewed-on: https://chromium-review.googlesource.com/896379
Reviewed-by: Bernie Thompson <[email protected]>
Commit-Queue: Bernie Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#219}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Reland "Add timestamp to requests for experimental contextual suggestions.
https://chromium.googlesource.com/chromium/src/+/e76e0e99dc3b8b2b7ad502603331ea7104745a1a
This reverts commit 8e96399b8b541866104479e7d761a918683235a5.
The original CL was reverted because of two consecutive unconditional returns within the same function, which was causing Windows MSVC build failures. This CL adds the preprocessor command to avoid this issue.
[email protected], rohitrao
for mechanical changes to ios/c/b/a/*
Change-Id: I823b815ae29f154df25391c21c0c43ec485192d5
Reviewed-on: https://chromium-review.googlesource.com/889698
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Gheorghe Comanici <[email protected]>
Cr-Commit-Position: refs/heads/master@{#532145}
(cherry picked from commit 034cff693a7e329c4c0b510a46aa04105911fa90)
Bug: 692471,705661
Change-Id: Ib8ed1376c498f42a18f9d1ba40fc8e334849b2fd
Reviewed-on: https://chromium-review.googlesource.com/896580
Reviewed-by: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#218}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix long extension install dialog titles from laying out on one line.
Versions of the dialog with long titles, like the "re-enable with new
permissions" or the "extension installed externally" dialogs, are
affected by this change. Instead of wrapping, their titles would all
be on one big line, making the dialog extremely wide. This is fixed.
This patch also adds interactive browser tests for "withheld"
permissions and for the "re-enable" version of the dialog.
[email protected]
(cherry picked from commit 56f8225cdd0c19f97cb10d41333da6d646c469db)
Bug: 654124
Change-Id: Iaffdede6a9977952f83a4393425a4df58007d05e
Reviewed-on: https://chromium-review.googlesource.com/885104
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532559}
Reviewed-on: https://chromium-review.googlesource.com/896503
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#217}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Rewrite extension install dialog layout for Harmony.
This patch completely changes the layout:
* The extension icon is now on the left. The icon, title, and webstore
data are moved into BubbleFrameView's title area, which simplifies
the layout.
* The extension info section (permissions, etc) is now the width of the
dialog, instead of having a fixed width.
* The extension info section is no longer bulleted, instead it uses a
secondary text style to distinguish lines from each header. Detailed
permissions are still bulleted. Indentation in this section is
removed.
* Each block in the extension info section now creates a {header,
content} representation that's handled in a standard way when
creating the layout.
* The animation when showing details is removed. The dialog will now
expand to accommodate the details if it has room to do so.
See screenshots in the associated bug.
[email protected]
(cherry picked from commit 0ea59b31b832031f9fdbce7e10e26f6e0c20dbe5)
Bug: 605657
Change-Id: Ie6815038138e524ff053449ec393d6cc6c1cf956
Reviewed-on: https://chromium-review.googlesource.com/841746
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531661}
Reviewed-on: https://chromium-review.googlesource.com/896390
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#216}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[DevTools] Fix performance problems with OOPIFs
- linear lookup changed to map;
- NotifyNavigated just once per frame;
- do not attach to service worker from each OOPIF.
(cherry picked from commit e72dcf29d2274244876e5b0d4e32a1e36c06d88c)
Bug: 805757
Change-Id: I1c912cf52fb74afc5eeb8a9fe8ae35f422eda8c9
Reviewed-on: https://chromium-review.googlesource.com/885244
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532223}
Reviewed-on: https://chromium-review.googlesource.com/896106
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#215}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Work around VC++ code-ben bug 804884
VC++ PGO builds crash deep inside memmove, as called by
message_center::InnerBoundedLabel::GetSizeForWidthAndLines which calls
base::JoinString and then ultimately basic_string<>::append and memmove.
Inspection of the stack and the generated code shows that
base::JoinString is called correctly but that base::JoinString (or the
inlined JoinStringT and three other levels of inlining) fail to read
separator off the stack correctly - they read it from an address that is
four bytes too early. This leads to copying too many bytes from the
wrong address.
Fully disabling optimizations in VC++ builds for the affected function
seems like the right fix. If time permits then a reduction and VC++ bug
will be created. However if this is a PGO-only bug then...
Bug: 804884
Change-Id: I80fd8e693a35b26a386cd99a1b17c54bede95d5c
Reviewed-on: https://chromium-review.googlesource.com/891569
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532658}(cherry picked from commit 4f4f08c928de6f68817b2d1ee3926b359e44cd6c)
Reviewed-on: https://chromium-review.googlesource.com/896183
Reviewed-by: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#214}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[remoting host] Fix div-by-zero in LeakyBucket
When receiving a bandwidth estimate of 0 from WebRTC, the host should
pause the video stream without crashing. This CL is a simple fix which
sets the bucket-emptying time to 1 minute if the rate is set to 0. This
is similar to what we already do in
FrameProcessingTimeEstimator::EstimatedTransitTime().
Bug: 806918
Change-Id: I43bf24cf54250cc3856adeb4c49809733320d46b
Reviewed-on: https://chromium-review.googlesource.com/891671
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532567}(cherry picked from commit e0ef90bec5de7875e0cd13ccdb7b7ada0d85078b)
Reviewed-on: https://chromium-review.googlesource.com/896162
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#213}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}NetworkNotifier: Show config UI on error
[email protected]
(cherry picked from commit fcb7a3399779155b008ace9708359ea4ebf62fc0)
Bug: 805357
Change-Id: Id3a6124a2fab1cfe40598d087aec86d82c567c70
Reviewed-on: https://chromium-review.googlesource.com/887635
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533029}
Reviewed-on: https://chromium-review.googlesource.com/895911
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#212}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Prevent MediaControls from scrubbing state before video is ready
This CL changes the scrubbing check in MediaControlsImpl::State to only
return the scrubbing state when the video is actually scrubbable. This
fixes a bug where the video CSS class would have a ready state when no
video source was available.
Bug: 802155
Change-Id: Ib7dfd26cb1be98dde2fc53ea6e230103162f64b1
Reviewed-on: https://chromium-review.googlesource.com/884262
Reviewed-by: Mounir Lamouri (slow) <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532906}(cherry picked from commit a2ac19aac66d459726d81f2caab05e015686bbc5)
Reviewed-on: https://chromium-review.googlesource.com/894836
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#211}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}DevTools: don't update all frames aggresively upon render frame swap.
We used to detach from targets aggressively because of the timing of the
UpdateFrames call. Current frame host was still non-cross-process and hence
was detached from. This change migrates from bulk-frame update to treating
render frame host swap in AutoAttachToFrame.
[email protected]
(cherry picked from commit a8e335abf5558708b20d892d6fbc5c76f5a84c6a)
Bug: 805248
Change-Id: Id6c8a665676167fea5048c23db20cfc8fafd86f1
Reviewed-on: https://chromium-review.googlesource.com/882167
Commit-Queue: Pavel Feldman <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531805}
Reviewed-on: https://chromium-review.googlesource.com/895908
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#210}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Settings/OOBE: Network: Handle connect failures in UI
An unintended side effect of:
https://chromium-review.googlesource.com/875002
is that NetworkingPrivateDelegate::HandleConnectFailed no longer
behaves as expected.
Instead we need to:
* Set check_error_state = true when calling ConnectToNetwork in the
networkingPrivate implementation.
* Clear any error state when Shill properties are set to ensure that
a connnection attempt after configuration does not fail when
check_error_state is true.
* Move configuration handling on error to the UI that calls startConnect.
ALso:
* Show the details dialog when connected networks are selected in OOBE.
This should provide a more robust / consistent experience in both oobe
and the Settings UI.
[email protected]
(cherry picked from commit e6889e929b2af432c31601a5652fd0473e58c3cb)
Bug: 805357
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0030fe5f6f6d054213cec812297829996a73bcfd
Reviewed-on: https://chromium-review.googlesource.com/884846
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533005}
Reviewed-on: https://chromium-review.googlesource.com/895054
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#209}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix CopyTexImage behavior when cubemap workaround is involved.
The bug is, we need to reset PIXEL_UNPACK_BUFFER as well as UNPACK params
in order to upload data to textures correctly.
BUG=804118
TEST=tests in the bug
[email protected]
[email protected]
NOTRY=true
(cherry picked from commit a89aa4642cefb79e312c95ca3c66bbaff5263a22)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I743f03cdc98b2c6993449ca615b246eb42ef4dfa
Reviewed-on: https://chromium-review.googlesource.com/892282
Commit-Queue: Zhenyao Mo <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Kai Ninomiya <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532749}
Reviewed-on: https://chromium-review.googlesource.com/895907
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#208}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Geolocation::HasPendingActivity should check watchers_ as well
This is a follow-up CL for https://chromium-review.googlesource.com/892557.
GeoNotifiers are in one_shots_ and watchers_. I forgot to support watchers_
in that CL.
Bug: 792604
Change-Id: I1421e14311de6c965cffc038892cfabdb63a4dbb
Reviewed-on: https://chromium-review.googlesource.com/894924
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533210}(cherry picked from commit d5ec2c33eaf060b4d0e910a5994cbd685588d60e)
Reviewed-on: https://chromium-review.googlesource.com/895850
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#207}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Merge to M65]cros: Dont create clipping window if no drag controller is set.
[email protected]
(cherry picked from commit da848713fa8943a1f3063d2cf08150df99743227)
Test: SystemTrayTest.ToggleAppListAfterOpenSystemTrayBubbleInTabletMode
Bug: 780146
Change-Id: I37444aabbd781961381934b57954ec4c614fc99b
Reviewed-on: https://chromium-review.googlesource.com/882288
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: min c <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531589}
Reviewed-on: https://chromium-review.googlesource.com/895057
Reviewed-by: min c <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#206}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Settings: Network proxy: fix 'allow shared proxies' visibility
This CL shows 'allow shared proxies' for device managed proxies
since these proxy settings may be subject to the
'use_shared_proxies' pref.
This also:
* Adds tests for the detail page, including a minor change to
internet_detail_page.js to facilitate testing.
* Fixes a subtle bug in isNetworkPolicyControlled.
CrSettingsInternetDetailPageTest.InternetDetailPage
[email protected]
(cherry picked from commit a07dbb7e2aa82c50a8dfe287fddf2ac6ccea21fc)
Bug: 798553
Test: browser_tests --gtest_filter=\
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I918710e106606127ff1246dd4400125b4c291273
Reviewed-on: https://chromium-review.googlesource.com/881867
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531998}
Reviewed-on: https://chromium-review.googlesource.com/895385
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#205}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Network details dialog: Add 'loading' string
[email protected]
(cherry picked from commit f0285d0821763d0387af6be82c9b6e8ef18190b5)
Bug: 804698
Change-Id: Icddb99d807b6fd0e76b9a6d7f91e6525b7f9b7f0
Reviewed-on: https://chromium-review.googlesource.com/882282
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531619}
Reviewed-on: https://chromium-review.googlesource.com/895848
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#204}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.38
[email protected]
Change-Id: Ibfef43f0495322dbced8814031ba617d04de883e
Reviewed-on: https://chromium-review.googlesource.com/895667
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#203}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Revert "Fix network config UI""
This reverts commit 8e34de0d47fea18a8ee420b199f538f3be29b2dd.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Fix network config UI"
>
> BUG=805357
>
> This reverts commit 4a5646ee3ab8887eddef734ef87ed808d9d3793f.
>
> Change-Id: I64bac73cd00352391eaa6dd07b931abc2cf9c0e7
> Reviewed-on: https://chromium-review.googlesource.com/892560
> Reviewed-by: Bernie Thompson <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3325@{#167}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 805357
Change-Id: I8049fc0e5f1c335ce205a0e5102ef91076bfdb79
Reviewed-on: https://chromium-review.googlesource.com/894833
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#202}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix segfault in AtRuleCSSStyleDeclaration::getPropertyValue
[email protected]
(cherry picked from commit 32c5f6b31c49bb0673bdc0cb0e464765d6ca82a1)
Bug: 803453, 803520
Change-Id: I3870ea56cd8349704621f3a72b64b69a24624680
Reviewed-on: https://chromium-review.googlesource.com/874981
Reviewed-by: nainar <[email protected]>
Commit-Queue: meade_UTC10 <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530434}
Reviewed-on: https://chromium-review.googlesource.com/895458
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#201}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Use Chrome User Agent for download requests.
Some web sites return HTML page instead of PassKit object if request's
User Agent is not a known iOS browser.
[email protected]
(cherry picked from commit 3955573a047a6b2ec777adab157787876cad3616)
Bug: 806759
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I566fe85eadb889dd715ddf858b07b6cef4a736c5
Reviewed-on: https://chromium-review.googlesource.com/891760
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532893}
Reviewed-on: https://chromium-review.googlesource.com/894696
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#200}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Do not unmute when muted by audio indicator
This CL adds a check in SoundContentSettingObserver to avoid unmuting a
tab if muted by the audio indicator.
Bug: 806482
Change-Id: I433c1fcb7a8e8034a9b100077e2f876e88a7d409
Reviewed-on: https://chromium-review.googlesource.com/891259
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Yuri Wiitala <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532861}(cherry picked from commit 08e823a59c72ef9ded0d6b7e902eedcf4133ab4d)
Reviewed-on: https://chromium-review.googlesource.com/894997
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#199}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}aw: Update background colour on newly created main frames.
[email protected]
(cherry picked from commit 5a21b8e6ec6485014c57a2ab79dd024fa318203a)
Bug: 802172
Change-Id: I5841fe34ee7226611a5ad2c66cf3c971fd40c670
Reviewed-on: https://chromium-review.googlesource.com/873977
Commit-Queue: Tobias Sargeant <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530540}
Reviewed-on: https://chromium-review.googlesource.com/894405
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#198}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Signin][Android] Fix confirmation screen if view is not attached yet
This CL addresses the issue when AccountSigninView doesn't show
confirmation page, showing empty account list instead. It could happen
if AccountSigninView is initialized before being attached to a window.
This CL also renames some methods in AccountSigninView to make them
less obscure.
Bug: 800665
Change-Id: I749bdb871877ac102cfb673989d9d318db117412
Reviewed-on: https://chromium-review.googlesource.com/881323
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531246}(cherry picked from commit 5f305aa904cc18b8977af87408db3ad716150674)
Reviewed-on: https://chromium-review.googlesource.com/894526
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#197}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Blink Loader: make FetchContext::NullInstance thread-safe
Accessing FetchContext passed to ResourceLoadScheduler causes
indeterminate crashes. This implies that there might be a race to
access NullInstance because dedicated FetchContext instance
should be passed in usual production code path, and NullInstance
use is only the exception. XHR will touch this regardless of
threads, and can cause a race condition among the first and the
second access over multiple-threading.
This patch creates new FetchContext instance always instead of
sharing one instance among all threads. If this affects performance
we would consider to make it thread-local.
Bug: 803849
Change-Id: I8bcdab577aceccaaea15288c6e3ae4c83f218213
Reviewed-on: https://chromium-review.googlesource.com/880421
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532396}(cherry picked from commit ef82c674ba3f6010f53f299760ab02d8743de21d)
Reviewed-on: https://chromium-review.googlesource.com/895126
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#196}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[m65 only] Disable Harmony for M65.
[email protected]
Bug: 805776
Change-Id: Iec875c6071357d38b1826300bba6192aef173598
Reviewed-on: https://chromium-review.googlesource.com/895125
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#195}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.37
[email protected]
Change-Id: I4dff489fff8c0e01ce1c7acf2b929b620970db15
Reviewed-on: https://chromium-review.googlesource.com/894903
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#194}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.36
[email protected]
Change-Id: Ic4550ce089498b7cb0e0169018bf087943378b3e
Reviewed-on: https://chromium-review.googlesource.com/894224
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#193}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Notify drag start/end from WorkspaceWindowResizer
They were inconsistently sent from different places,
which led to this bug because DragResizer isn't used in multi window resizer.
They should be sent from single soruce.
BUG=b/72402303
TEST=Covered by unit tests. Also tested manually. See bug for repro step.
Change-Id: If9e24b7b62d879a83607ee99634c2670645c7bb6
Reviewed-on: https://chromium-review.googlesource.com/885081
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Dominik Laskowski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532263}(cherry picked from commit 44b87f5103d52c7d9bc3f75aaadbdf0137cc76dc)
Reviewed-on: https://chromium-review.googlesource.com/894685
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#192}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Update cursor when it moves to different display.
Old remote shell drag used to capture the surface during drag because
motion events have to be sent to android. And cursor update logic
was depending on this behavior.
This is no longer true in chrome driven drag&resize and the capture
is now on the remote shell's widget (same as xdg).
This CL makes the update logic independent of focus surface, and
updates the cursor if the cursor created by this when moves to
different display.
BUG=804471
TEST=manual
Change-Id: I8dc7a6fdc6f87c7b3872e54d7a61f43e2904b263
Reviewed-on: https://chromium-review.googlesource.com/882191
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532264}(cherry picked from commit 314513713e5fe647c2bfa8935550c94b7cc21391)
Reviewed-on: https://chromium-review.googlesource.com/894709
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#191}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Return correct minimum size set by a client.
This CL hook up minimum size to
Widget::GetMinimumSize/WindowDelegate::GetMinimumSize.
BUG=b/72402291
TEST=Covered by unit test.
Change-Id: I6977f5578c5f8fd3992917f818e38a713689d84f
Reviewed-on: https://chromium-review.googlesource.com/883402
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531780}(cherry picked from commit e8946e7d5fbc64de2356cbfc3c79bdbbbd284d45)
Reviewed-on: https://chromium-review.googlesource.com/894289
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#190}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Do not lock the cursor when dragging a client controlled window
Do not lock the cursor when dragging a window whose
state is controlled by a client, which may set its own
cursor during drag.
Better fix is to add custom cursor API that supports density change.
We'll address it as a part of cursor improvement work.
(b/80666810, crbug.com/721601)
BUG=804471
TEST=manual
Change-Id: I4ddb5a96d820cca1fa08528adf8e311c5a0960e7
Reviewed-on: https://chromium-review.googlesource.com/881526
Reviewed-by: Dominik Laskowski <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531391}(cherry picked from commit 3806eaaeb33fa8c9a9f091c31cb3579fb5b499ee)
Reviewed-on: https://chromium-review.googlesource.com/894288
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#189}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Only show mute icon on tab when sound is playing
This CL adds a check to WasRecentlyAudible before adding a mute icon to
a tab to avoid always showing a mute icon when a tab is muted. This also
adds the fade animation to the (mute icon)->(no icon) transition. Since
adding the fade animation breaks a TabTest unit test (which worked under
the assumption that each of its transitions was instantaneous), this CL
also manually stops fade animations in that test.
Bug: 785406
Change-Id: I0d7fd732b605f634f9df59b736dd7f19c382a09e
Reviewed-on: https://chromium-review.googlesource.com/889178
Reviewed-by: Yuri Wiitala <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532652}(cherry picked from commit 6d8c81c88ed66d6311932f00414ac0e48d5b701d)
Reviewed-on: https://chromium-review.googlesource.com/894706
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#188}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[vr] Use alternate colors for environments with gradients
This CL uses base::Versions built-in comparison logic rather than
my incorrect, hand-rolled code. It also swaps out the color scheme
when the component has a gradient.
Also reduces the number of stars used with these environments.
Bug: 806452,806471
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I250692105e680e1f3d0fee372f6886f35f2ced95
Reviewed-on: https://chromium-review.googlesource.com/889842
Commit-Queue: Ian Vollick <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Christopher Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532240}(cherry picked from commit a04e5845a535c8e31c3182ed19e8065816b7e2c9)
Reviewed-on: https://chromium-review.googlesource.com/894246
Cr-Commit-Position: refs/branch-heads/3325@{#187}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[vr] Disable update ready snackbar
[email protected]
(cherry picked from commit 086bb77ef26bd5c11ec3078ab4302fc09e0ec220)
Bug: 806328
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic11d57e15fdd3645365c07d80addd672b838ac3e
Reviewed-on: https://chromium-review.googlesource.com/889680
Reviewed-by: Ian Vollick <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532154}
Reviewed-on: https://chromium-review.googlesource.com/894493
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#186}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}cc/ipc: Fix PaintFilter serialization.
Ensure that the memory returned when serializing a filter is resized to
the number of bytes written. Otherwise the message serializes the
complete buffer allocated initially.
R=[email protected], [email protected]
Bug: 805585
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia85688cbd77529c2f6e9c044de9a83a254787442
Reviewed-on: https://chromium-review.googlesource.com/885511
Reviewed-by: enne <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532228}(cherry picked from commit 793792516e90a2f694f874949525be0b1f079da4)
Reviewed-on: https://chromium-review.googlesource.com/894270
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#185}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[ios] Update privacy notice url.
[email protected]
(cherry picked from commit 78b87f719f32975708eeb3ade37923fd9b7d4956)
Bug: 786913
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c5ead72b584672fd322d9b74a0b24b40d958797
Reviewed-on: https://chromium-review.googlesource.com/882061
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532718}
Reviewed-on: https://chromium-review.googlesource.com/894304
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#184}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Browser Actions would not show predefined items if FRE is not complete
BrowserActionActivity could be shown even FRE is not finished but if FRE
is not finished, predefined item would not shown. It only shows the
custom item which looks like fallback dialog.
Bug: 801264
NOTRY=true
NOPRESUBMIT=true
[email protected]
(cherry picked from commit 20fb835192b5eae97ebe1db1e19ab6a7475a29f7)
Change-Id: I1d723e413fa06a7cd28d897620ed22f986887a5f
Original-Reviewed-on: https://chromium-review.googlesource.com/875190
Commit-Queue: Lei Tian <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531706}
Reviewed-on: https://chromium-review.googlesource.com/893424
Cr-Commit-Position: refs/branch-heads/3325@{#183}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Updating XTBs based on .GRDs from branch 3325
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I38ec589284b5599b063785869f5750f33644acd2
Reviewed-on: https://chromium-review.googlesource.com/894043
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#182}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[Android HW 264] append SPS/PPS NALUs to IDR correctly
HW H264 encoder on Android will output SPS/PPS packet separately, so we
need to cache and append it to all the IDR frames. During that processing,
the cache buffer isn't rewinded each time. Then currently only the first
IDR will have SPS/PPS appended correctly and all the followiing IDRs will
contain incorrect data.
In that case, if the first IDR is lost for some reason, the peer won't
get corrent SPS/PPS to start decoding.
This cl is to fix it by rewinding buffer of cached SPS/PPS each time and
add relevant unittest case.
Bug: 793038
Change-Id: I53d3e6f40c37f4eb31e3c1ce348db19c523d9d95
Reviewed-on: https://chromium-review.googlesource.com/879590
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Weiyong Yao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531294}(cherry picked from commit 07f8bb44eb43b8dfccdc07d796d5ce0541466d4c)
Reviewed-on: https://chromium-review.googlesource.com/893436
Reviewed-by: Weiyong Yao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#181}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Keep AudioHandlers alive until they can be safely deleted.
When an AudioNode is disposed, the handler is also disposed. But add
the handler to the orphan list so that the handler stays alive until
the context can safely delete it. If we don't do this, the handler
may get deleted while the audio thread is processing the handler (due
to, say, channel count changes and such).
For an realtime context, save the handler if the context is not closed.
(Nothing will clean up the handler if the context is closed.)
For an offline context, only need to do this when the context is
running because the context is guaranteed to be stopped if we're not
in the running state. Hence, there's no possibility of deleting the
handler while the graph is running.
Bug: 780919
Change-Id: Id8ba47f48504c5681121facebfc5acb85b05de87
Reviewed-on: https://chromium-review.googlesource.com/868841
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530892}(cherry picked from commit ebcf9595bf908b515ffcd31374b071697a69faed)
Reviewed-on: https://chromium-review.googlesource.com/893626
Reviewed-by: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#180}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix POST method getting lost in form submissions from an OOPIF to its parent (Merge to M65)
This CL fixes a problem in RequestTransferURL(), where in the case of
a form submission to the main frame, the FrameNavigationEntry's method
was never updated.
[email protected]
(cherry picked from commit 5bb1f944bf54f670c3e57c00239a6639766e11ce)
Bug: 806215
Change-Id: I1614a0e51f91b0d3346ce633bf8f027cf3609f15
Reviewed-on: https://chromium-review.googlesource.com/889646
Commit-Queue: Nasko Oskov <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532192}
Reviewed-on: https://chromium-review.googlesource.com/893945
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#179}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Disable data saver promo on Android one devices
Bug: 806068
Change-Id: I013b1396f3c56edb5b7dd349d9ad31616b1a5803
Reviewed-on: https://chromium-review.googlesource.com/887780
Reviewed-by: Scott Little <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532056}(cherry picked from commit 49b42b9c0f5b2b539d8c11e3f4ebcb03358f43ac)
Reviewed-on: https://chromium-review.googlesource.com/893701
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#178}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[MacRTL] Don't mirror reload toolbar icon
This came up in UX review. From Material Guidelines:
"Clocks still turn clockwise for RTL languages. A clock icon or a circular
refresh or progress indicator with an arrow pointing clockwise should not
be mirrored."
Bug: 805921
Change-Id: I1d345727b8656964b0574af9ccdc7d5dc26f8661
Reviewed-on: https://chromium-review.googlesource.com/887301
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532009}(cherry picked from commit 3f8dbc8d1358729387a3a331382d5956d3af68c9)
Reviewed-on: https://chromium-review.googlesource.com/893922
Reviewed-by: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#177}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Perform colorspace conversion for SW images in GPU cache at decode time
When caching very large images in the GPU image decode cache,
we don't upload to the GPU, but instead just cache the CPU side data
for re-use. Unfortunately, we currently perform color conversion post
upload, which means that, in the SW-only case, we end up re-converting
images on every use.
This patch causes SW-only cache entries to have their color conversion
done at decode time, ensuring we persist it in the cache.
[email protected]
(cherry picked from commit 79c2946a9bb6b480e623a16ed2a3bea9e87c92f1)
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I26831b119dffff09f977567631dd2dc7e99e7978
Bug: 802819
Reviewed-on: https://chromium-review.googlesource.com/877106
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532185}
Reviewed-on: https://chromium-review.googlesource.com/893650
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#176}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}[M65 merge] MD Extensions: Surface ExtensionInfo runtimeWarnings in the UI.
[email protected]
(cherry picked from commit fb85136da7f8e6e70210c18ffa4ebd1be0c6b5d6)
Bug: 800773
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I546e25b3748e455449ee3c0a541c5a6658ee2504
Reviewed-on: https://chromium-review.googlesource.com/884847
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532246}
Reviewed-on: https://chromium-review.googlesource.com/893903
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#175}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Adjust purging of unlocked discardable in GPU Image Decode Cache
We were incorrectly purging unlocked discardable to "make room" in the
cache, although unlocked entries don't take up room. This resulted in
non-optimal cache purging when we hit at-raster scenarios.
Now that all cached items are discardable, this change removes all
purging other than that needed to handle our max items in cache limit.
[email protected]
(cherry picked from commit ec5246d62d67feb1992c0fc61add8160f5b5309c)
Bug: 802819, 804328
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I5cece605bbd40283073c075e78b36867c8c7efbf
Reviewed-on: https://chromium-review.googlesource.com/879064
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531032}
Reviewed-on: https://chromium-review.googlesource.com/893428
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#174}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}v8binding: Fixes a crash issue at GeoNotifier::TimerFired.
Geolocation stops owning GeoNotifiers in some cases (e.g.
Geolocation::clearWatch), so it's possible that, when
GeoNotifier::TimerFired gets invoked, the owner geolocation
had already stopped owning the notifier. In this scenario,
no one is performing wrapper-tracing for the notifier, thus
the underlying V8 functions might have already been
collected by V8 GC. GeoNotifier must not invoke any
callback in such a case.
This patch adds a check whether the geolocation still owns
the notifier or not.
Originally Reviewed-on: https://chromium-review.googlesource.com/893240
(cherry picked from commit 1063641d0bf9b23449f758d7e0de55b7611dcc06)
Bug: 792604
Change-Id: I3b54e7e36214190665674398785b35e334b142ba
Reviewed-on: https://chromium-review.googlesource.com/893607
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#173}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Revert "NetworkConnectionHandler::ConnectToNetwork: support immediate succeed""
This reverts commit 683176b44b98dc3e63c0868e2fd85dabffed6b8d.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "NetworkConnectionHandler::ConnectToNetwork: support immediate succeed"
>
> BUG=805357
>
> This reverts commit 29fa3fcb5e65ac3985d2093bc11f372081ced1e0.
>
> Change-Id: Idf3230b4244cfd324ab9fb6422416e4d7c1e8721
> Reviewed-on: https://chromium-review.googlesource.com/892398
> Reviewed-by: Bernie Thompson <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3325@{#166}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: I556935c9d5ebe407b6c2e777a86f1b7a3c12ff77
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805357
Reviewed-on: https://chromium-review.googlesource.com/893699
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#172}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Merge "Add new error page when profile is permanently disabled by force-sign-in policy."
Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing
[email protected]
(cherry picked from commit 073b0641e1ca015efcc19b3dd11cb1e33d9cc11b)
Bug: 803191
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a41f51a82213f628a3ab11b5af341cc94f89a56
Reviewed-on: https://chromium-review.googlesource.com/876765
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530673}
Reviewed-on: https://chromium-review.googlesource.com/893639
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#171}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Keep alive Geolocation until its one-shot callbacks are invoked
This is a speculative fix for bug 792604.
It looks like that we're missing wrapper-missing somewhere and
the v8::Function of Geolocation's callbacks are collected prematurely.
This CL keeps Geolocation alive until all one-short callbacks are invoked.
This CL has no risk of causing memory leaks because 1) the one-shot callbacks are
guaranteed to be invoked in a finite time period and
2) ActiveScriptWrappable::HasPendingActivity is implemented in such a way that
it returns false after context gets destroyed.
[email protected]
(cherry picked from commit 62b45306b022e3c5f21818421b9fbac2740e0c14)
Bug: 792604
Change-Id: Ief245d0409fc6b1b35cfe11e3368de230b503482
Reviewed-on: https://chromium-review.googlesource.com/892557
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532775}
Reviewed-on: https://chromium-review.googlesource.com/892602
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#170}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Collapse older notification popups."
This reverts commit 4497e01a173b6fbaed337cb1164f453699862ab1.
Reason for revert: UpdateWidgets crash https://crbug.com/804389
Original change's description:
> Collapse older notification popups.
>
> According to UX, in addition to expanding the latest notification,
> older notification popups should be collapsed.
>
> See the screencast:
> - Without this CL:
> http://go/scrcast/NTY3OTAwNjEyOTA2MTg4OHxjMjY3MGMxMS0xNw
> - With this CL: http://go/scrcast/NTY0MjAyMzc3NjI4ODc2OHxhYjBmNWQ4Yy02NA
>
> TEST=NotificationViewMDTest.ExpandLongMessage
> BUG=792582
>
> Change-Id: Ie6693386acda5a47405350822a48b4b0a279029f
> Reviewed-on: https://chromium-review.googlesource.com/830998
> Reviewed-by: Yoshiki Iguchi <[email protected]>
> Commit-Queue: Tetsui Ohkubo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#525034}
[email protected], [email protected]
(cherry picked from commit ffe4a6dcc09997438caf1a6b11c8ca2d1d2ca22c)
Bug: 792582, 804389
Change-Id: Ibbf9f56660235be61ca2ba98ed8e0086f828e4ef
Reviewed-on: https://chromium-review.googlesource.com/882908
Commit-Queue: Tetsui Ohkubo <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531483}
Reviewed-on: https://chromium-review.googlesource.com/892578
Cr-Commit-Position: refs/branch-heads/3325@{#169}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.35
[email protected]
Change-Id: I627d7e02d3d78a6e4d851a6061571f4126f8e5d9
Reviewed-on: https://chromium-review.googlesource.com/891487
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#168}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "Fix network config UI"
BUG=805357
This reverts commit 4a5646ee3ab8887eddef734ef87ed808d9d3793f.
Change-Id: I64bac73cd00352391eaa6dd07b931abc2cf9c0e7
Reviewed-on: https://chromium-review.googlesource.com/892560
Reviewed-by: Bernie Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#167}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Revert "NetworkConnectionHandler::ConnectToNetwork: support immediate succeed"
BUG=805357
This reverts commit 29fa3fcb5e65ac3985d2093bc11f372081ced1e0.
Change-Id: Idf3230b4244cfd324ab9fb6422416e4d7c1e8721
Reviewed-on: https://chromium-review.googlesource.com/892398
Reviewed-by: Bernie Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#166}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.34
[email protected]
Change-Id: I6c95718c1d6a46a1e2d75e5a745a98f7290da0d1
Reviewed-on: https://chromium-review.googlesource.com/892519
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#165}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.33
[email protected]
Change-Id: I17a424c8acdc8f3c54c29590fc4b3cdecd47f596
Reviewed-on: https://chromium-review.googlesource.com/891486
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#164}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Only clear insertion handle if there is no range selection
There is a race condition where a user makes an insertion handle
and then long-presses some text to make a selection. This can result
in the |INSERTION_HANDLE_CLEARED| coming after the call to
|SelectionPopupControllerImpl#showSelectionMenu()| which resets the
menu position set by |showSelectionMenu()|. This CL fixes that by first
making sure there is no range selection before trying to clear the
insertion handle.
[email protected]
(cherry picked from commit 1e664dd6c6c6509c89fe3acd934e6d1f9e0f7056)
Bug: 773515
Change-Id: I16b1e845b3960420f424dd04d418464a26bc5f1b
Reviewed-on: https://chromium-review.googlesource.com/884508
Reviewed-by: Shimi Zhang <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531737}
Reviewed-on: https://chromium-review.googlesource.com/891657
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#163}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Fix a bug failing Android webview CTS test
JavascriptInjector instance cached in |AwContents| was left
untouched upon destruction. This is fine for normal webview
but popup window whose WebContents is swapped out on loading
kept using the cached one, therefore caused a problem
restoring the injected Javascript interface objects into
the new WebContents. This CL fixes that by nulling it out,
and adds an instrumentation that does what the failing CTS
test does.
Bug: 800941
Change-Id: I8fb50998fd461316d6fd4dc34f6a02f95856d24d
Reviewed-on: https://chromium-review.googlesource.com/886122
Reviewed-by: Bo <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532296}(cherry picked from commit 5690fe9f3546a1bc34b8e8a6cf4494729324729e)
Reviewed-on: https://chromium-review.googlesource.com/892218
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#162}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}Incrementing VERSION to 65.0.3325.32
[email protected]
Change-Id: I04f31bfde71ad1d60e6975dc1fc22a0996ccd216
Reviewed-on: https://chromium-review.googlesource.com/891926
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#161}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
