Publish DEPS for Chromium 65.0.3325.162
Incrementing VERSION to 65.0.3325.162
[email protected]
Change-Id: Ieee123752818c26451f2fbd95adc1d3cc304288f
Reviewed-on: https://chromium-review.googlesource.com/959391
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#695}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Fix print job early termination during PDF conversion (M65)
Many webpages use window.print() immediately followed by window.close()
in JS. This means that the renderer and web contents are torn down
while the PDF is still being converted for the printer on Windows.
However, the web contents are not needed if the full PDF document has
already been rendered, so the PrintViewManager should just release the
query and allow conversion and spooling to complete instead of
cancelling the job.
The CL to send the Print Preview PDF directly to the PrintViewManager
broke this for users that use Print Preview because we no longer store an
extra copy of the web contents in the BackgroundPrintingManager. This has
been broken if using the system dialog since M64 or earlier.
(cherry picked from commit d20e4ef32233412d947beeb190f93ccea71510b3)
Bug: 820105
Change-Id: I308adba43b3604509275f6c0f2946545b94dd1d5
Reviewed-on: https://chromium-review.googlesource.com/956257
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Wei Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542203}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/959449
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#694}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Clear the download item's target on dealloc.
This fixes a crash if the download item controller goes away while the
button is tracking the mouse and then sends its action on mouse up.
Bug: 815161
Change-Id: I4ab377ca5fe190e3d95aa81b989c13c96b46f5b4
Reviewed-on: https://chromium-review.googlesource.com/957843
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#542357}(cherry picked from commit e73502d816bfe339d9ef76d365c143166f6d1a26)
Reviewed-on: https://chromium-review.googlesource.com/958986
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#693}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[M-65] Remove libusb-Windows support for HID devices
This patch removes the Windows-specific support in libusb that provided
a translation between the WinUSB API and the HID API. Applications
currently depending on this using the chrome.usb API should switch to
using the chrome.hid API.
Bug: 818592
Change-Id: I82ee6ccdcbccc21d2910dc62845c7785e78b64f6
Reviewed-on: https://chromium-review.googlesource.com/951635
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#541265}(cherry picked from commit ac149a8d4371c0e01e0934fdd57b09e86f96b5b9)
Reviewed-on: https://chromium-review.googlesource.com/956765
Reviewed-by: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3359@{#125}
Cr-Original-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}(cherry picked from commit 20aaf51d748440ee4440eea1981abf428be7d0e1)
Reviewed-on: https://chromium-review.googlesource.com/959281
Cr-Commit-Position: refs/branch-heads/3325@{#692}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.161
[email protected]
Change-Id: I5a68fbd568986408592d8840b0ffb39562875c80
Reviewed-on: https://chromium-review.googlesource.com/959141
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#691}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Bail out if there are no stored encryption keys.
There is an increased number of crashes in DidLoadKeys() for M65 where
the keys vector of the EncryptionData proto is being accessed without
there being keys.
It's not clear why this is happening, but we do know that encryption
data that doesn't include keys isn't useful, so we can suppress the
crash by bailing out. Keep the DCHECK in place for the odd chance that
one of the bots catches this. This code has been rewritten in M66, where
there actually is a valid case for there to not be any keys.
Bug: 818594
Change-Id: I0ae12ea29ba4858127abc7944eeba1967353f450
Reviewed-on: https://chromium-review.googlesource.com/959011
Reviewed-by: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#690}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.160
[email protected]
Change-Id: I221d3dc6962255e6c9e36bba21fcc6524ef7b9b2
Reviewed-on: https://chromium-review.googlesource.com/957844
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#689}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.159
[email protected]
Change-Id: I5848591098baf7c66e43210652b12b9599efa81d
Reviewed-on: https://chromium-review.googlesource.com/958681
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#688}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.158
[email protected]
Change-Id: Ia9ba31195f2c18993ae7e1f7aed41fbdb7cdb0b4
Reviewed-on: https://chromium-review.googlesource.com/958205
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#687}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.157
[email protected]
Change-Id: Ieab388ff538057ce97d5b7d8f2b05eb6b43a2ca6
Reviewed-on: https://chromium-review.googlesource.com/958188
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#686}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.156
[email protected]
Change-Id: Icf79b372483f253980234ea53c5884a3f18e5bb2
Reviewed-on: https://chromium-review.googlesource.com/958062
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#685}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.155
[email protected]
Change-Id: I311b8adc879feb35e8badc0e69384946ceb5878d
Reviewed-on: https://chromium-review.googlesource.com/958022
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#684}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[Merge to M65] Fix XFCE frame buttons rendering too large on GTK < 3.20
> Prior to GTK 3.20, a background-size set to "contain" would actually behave like
> it was "stretch". This was causing frame button images to render too large on
> Greybird (XFCE theme) and Breeze (KDE theme). Since the issue the CSS override
> was fixing is not applicable to GTK < 3.20 (symbolic icons were used for these
> versions), only apply the CSS if the GTK version is >= 3.20.
>
> BUG=819594
> R=erg
> TBR=estade
>
> Change-Id: I91807e4b5675b56647e2da1be5284e68a7bc7c3a
> Reviewed-on: https://chromium-review.googlesource.com/954419
> Reviewed-by: Thomas Anderson <[email protected]>
> Commit-Queue: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#541834}
BUG=819594
TBR=estade
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: Ic12d428b8c3a8d6daa14468e13ba18710ec9206f
Reviewed-on: https://chromium-review.googlesource.com/957447
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#683}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.154
[email protected]
Change-Id: If8e6f95d01969d42637a4a328c33bf9fae06ab4e
Reviewed-on: https://chromium-review.googlesource.com/956842
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#682}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.153
[email protected]
Change-Id: Idc92e50598be4c3e66acc7f618ebf93fae32ef7b
Reviewed-on: https://chromium-review.googlesource.com/956565
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#681}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.152
[email protected]
Change-Id: Ie9631b64b32fef862e8e9d4b0f895aa7381ba1b5
Reviewed-on: https://chromium-review.googlesource.com/956507
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#680}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Fix decidePolicyForNavigationResponse crash for iframes downloads.
context returned from contextForPendingNavigationWithURL is null for
iframes, and dereferencing it causes a crash.
This CL always uses PAGE_TRANSITION_CLIENT_REDIRECT transition, because
transition is not used in production code yet, but only checked in
tests.
Bug: 801161
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7bfc0f8ac915e795f07217b97e91cec124cdde21
Reviewed-on: https://chromium-review.googlesource.com/956561
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#679}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Logs First Run Sentinel creation failures with FirstRun.SignIn histogram
Previously, failures to create First Run Sentinel file are dropped
silently. Frequent failures of creating First Run Sentinel file (not
expected, but possible) may cause FirstRun.SignIn to appear to have
high sign-in failure.
This is a precautionary metrics collection CL to help diagnose whether
such a problem exists or not.
Bug: 814437
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8a1c6dce86b59d66f57b068ef1f2b44636edbb34
Reviewed-on: https://chromium-review.googlesource.com/947396
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Peter Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540841}(cherry picked from commit 124ef83ecc828aee4d5e33df73ecd26d7e4eeeec)
Reviewed-on: https://chromium-review.googlesource.com/956443
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#678}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.151
[email protected]
Change-Id: I1a852f17b987caa0a930151640e68c6bbf91e29a
Reviewed-on: https://chromium-review.googlesource.com/954462
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#677}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.150
[email protected]
Change-Id: I8edc7109711c00a2ed35bf9dcf058ea0ca2ae485
Reviewed-on: https://chromium-review.googlesource.com/954363
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#676}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Devtools: Fix clipping with device emulation.
8bb58f52036793831d0363c285a6b159b21513d9 exposed a pre-existing bug on Mac
whereby an incorrect device scale factor was passed into the compositor
when device emulation mode was turned on. This bug only occurs on Mac
because Mac and Windows used different code paths for device scale factor.
Windows always reports to the compositor a device scale factor of 1, and then
passes the real device scale factor to Blink which deals with the scaling itself.
Mac reports the actual device scale factor to the compositor along with Blink.
Blink doesn't deal with the scaling directly via zoom.
In either case, device emulation can change the device scale factor. The DSF
reported to the compositor must be the non-emulated DSF. The pre-existing bug
was that we passed the post-emulation device scale factor to the compositor which
affected clipping.
Bug: 819489
Change-Id: Iecf87b5fcb22695a4af2213daf3f0597ddbffc20
Reviewed-on: https://chromium-review.googlesource.com/954122
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#675}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.149
[email protected]
Change-Id: I6975dc0865f780db5ae03f10de444d2bbb623533
Reviewed-on: https://chromium-review.googlesource.com/951757
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#674}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.148
[email protected]
Change-Id: I894b04f941f992a75b7c9cac610f9364c6a24e08
Reviewed-on: https://chromium-review.googlesource.com/952483
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#673}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Chrome OS OOBE: Change illustration when switching to tablet mode.
This CL adds setTabletModeState sceen object method and event flow to
update this status in runtime. Also illustration on the OOBE screen now
depends on the device status.
[email protected]
(cherry picked from commit 5ccf96ac889f2c82e9a91f564abb43339c4fa92b)
Bug: 792719
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I13a5dfb55630fe6b8debb022ca4a04529acdff52
Reviewed-on: https://chromium-review.googlesource.com/939049
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#539991}
Reviewed-on: https://chromium-review.googlesource.com/952069
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#672}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
android: Fix sensors in device service.
This patch fixes a bug that prevented more than one sensor data
to be available at once when using the device motion/orientation
API.
The issue was introduced by this other patch [1] which fixed
some security-related issues in the way shared memory region
handles are managed throughout Chromium (more details at
https://crbug.com/789959).
The device service´s sensor implementation doesn´t work
correctly because it assumes it is possible to create a
writable mapping of a given shared memory region at any
time. This assumption is not correct on Android, once an
Ashmem region has been turned read-only, such mappings
are no longer possible.
To fix the implementation, this CL changes the following:
- PlatformSensor used to require moving a
mojo::ScopedSharedBufferMapping into the newly-created
instance. Said mapping being owned by and destroyed
with the PlatformSensor instance.
With this patch, the constructor instead takes a single
pointer to the corresponding SensorReadingSharedBuffer,
i.e. the area in memory where the sensor-specific
reading data is located, and can be either updated
or read-from.
Note that the PlatformSensor does not own the mapping
anymore.
- PlatformSensorProviderBase holds the *single* writable
mapping that is used to store all SensorReadingSharedBuffer
buffers. It is created just after the region itself,
and thus can be used even after the region's access
mode has been changed to read-only.
Addresses within the mapping will be passed to
PlatformSensor constructors, computed from the
mapping's base address plus a sensor-specific
offset.
The mapping is now owned by the
PlatformSensorProviderBase instance.
Note that, security-wise, nothing changes, because all
mojo::ScopedSharedBufferMapping before the patch actually
pointed to the same writable-page in memory anyway.
Since unit or integration tests didn't catch the regression
when [1] was submitted, this patch was tested manually by
running a newly-built Chrome apk in the Android emulator
and on a real device running Android O.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/805238
BUG=805146
R=[email protected],[email protected],[email protected],[email protected]
Change-Id: I7d60a1cad278f48c361d2ece5a90de10eb082b44
Reviewed-on: https://chromium-review.googlesource.com/891180
Commit-Queue: David Turner <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Matthew Cary <[email protected]>
Reviewed-by: Alexandr Ilin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532607}(cherry picked from commit c0c8978849ac57e4ecd613ddc8ff7852a2054734)
Reviewed-on: https://chromium-review.googlesource.com/951663
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#671}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.147
[email protected]
Change-Id: I4b5a6f5c26285bb0a633913dc22f4ce6e3b26c2e
Reviewed-on: https://chromium-review.googlesource.com/950084
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#670}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}