Publish DEPS for Chromium 64.0.3282.140
Incrementing VERSION to 64.0.3282.140
[email protected]
Change-Id: I846428ea0c88101535bcdeb70b73b97acf277133
Reviewed-on: https://chromium-review.googlesource.com/897122
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#631}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Allow navigations to opener's site to go back into opener SiteInstance (Merge to M64)
Previously, when a popup and its opener were cross-site, and neither
site required a dedicated process, navigating the popup back to the
opener's site did not swap processes, so the two ended up in different
processes and couldn't script each other. Even though
DetermineSiteInstanceForURL contains logic to place same-site popups
into their opener's SiteInstance (added as part of the fix for a
similar issue 796912), this logic was never reached because we never
attempted a process transfer in this case, thanks to
IsRendererTransferNeededForNavigation() returning false.
This CL tweaks IsRendererTransferNeededForNavigation so that a
cross-process transfer is always attempted is such cases. This allows
DetermineSiteInstanceForURL to always place the popup that's going back
to its opener site into the opener's SiteInstance.
[email protected]
(cherry picked from commit cd5b76ea43df36e2d64447aec0f5da654543133f)
Bug: 807184
Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec
Reviewed-on: https://chromium-review.googlesource.com/894369
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533410}
Reviewed-on: https://chromium-review.googlesource.com/896969
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#630}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Geolocation::HasPendingActivity should check watchers_ as well
This is a follow-up CL for https://chromium-review.googlesource.com/892557.
GeoNotifiers are in one_shots_ and watchers_. I forgot to support watchers_
in that CL.
Bug: 792604
Change-Id: I1421e14311de6c965cffc038892cfabdb63a4dbb
Reviewed-on: https://chromium-review.googlesource.com/894924
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#533210}(cherry picked from commit d5ec2c33eaf060b4d0e910a5994cbd685588d60e)
Reviewed-on: https://chromium-review.googlesource.com/895849
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#629}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Revert "Guard against frame detachment during OOPIF Animate"
This reverts commit b14235c2901079ed4cc8fff1b375d65f4ea80b74.
Reason for revert: Caused https://crbug.com/802392.
[email protected]
Original change's description:
> Guard against frame detachment during OOPIF Animate
>
> Crash reports suggest that WebFrameWidgetImpl can have a null
> local root pointer after calling PageWidgetDelegate::Animate(). The
> subsequence call to GetPage() dereferences that pointer.
>
> This CL adds a null check for cases when Animate causes detachment.
>
> Bug: 776407
> Change-Id: I3429865a786aa3acd9a06000e93fc4385e4e6e19
> Reviewed-on: https://chromium-review.googlesource.com/819593
> Commit-Queue: Daniel Cheng <[email protected]>
> Reviewed-by: Daniel Cheng <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#527245}(cherry picked from commit 7e04a9d1f143fb6d37d380833f766bf938cc0284)
> Reviewed-on: https://chromium-review.googlesource.com/871090
> Reviewed-by: Ken Buchanan <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3282@{#524}
> Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 776407
Change-Id: I46ede1b0225096013089eb7ce5912bb701d55225
Reviewed-on: https://chromium-review.googlesource.com/895862
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#628}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[Merge to M64] Linux native notifications: Add close button on cinnamon notifications
> BUG=804637
> R=peter
>
> Change-Id: I06611b6d8569c05dc4349121d565b645a3359c6b
> Reviewed-on: https://chromium-review.googlesource.com/884572
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Peter Beverloo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#531800}
BUG=804637
TBR=peter
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: I723ddd0747bcecc682dce8d911ceaa5ceb82679c
Reviewed-on: https://chromium-review.googlesource.com/894301
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#627}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.139
[email protected]
Change-Id: I472245a9485bacc842e480e136ead66e6aa4d603
Reviewed-on: https://chromium-review.googlesource.com/894543
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#626}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.138
[email protected]
Change-Id: Icdea8f0855cfab2a98eaa70e3afbac362b551432
Reviewed-on: https://chromium-review.googlesource.com/894308
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#625}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[merge to m64] gpu: Disable gpu process crash when receiving invalid window handle.
Receiving an invalid child window handle is most likely due to a race
between the gpu process destroying the child window and the browser
receving SetChildSurface. There's not a strong argument to crash the gpu
process in this case. This is high volume on stable and polluting other
crash data.
R=piman
BUG=782359
Change-Id: If463462b0a15778513236013a8d31c833840c3ab
Reviewed-on: https://chromium-review.googlesource.com/891566
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532637}(cherry picked from commit 4cce23157c276fa9d0294f37910e1b4a92e3834f)
Reviewed-on: https://chromium-review.googlesource.com/894444
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#624}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Fix POST method getting lost in form submissions from an OOPIF to its parent (Merge to M64)
This CL fixes a problem in RequestTransferURL(), where in the case of
a form submission to the main frame, the FrameNavigationEntry's method
was never updated.
[email protected]
(cherry picked from commit 5bb1f944bf54f670c3e57c00239a6639766e11ce)
Bug: 806215
Change-Id: I1614a0e51f91b0d3346ce633bf8f027cf3609f15
Reviewed-on: https://chromium-review.googlesource.com/889646
Commit-Queue: Nasko Oskov <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532192}
Reviewed-on: https://chromium-review.googlesource.com/894484
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#623}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Reduce the lock scope in WebRtcMediaStreamAdapterMap.
Specifically this avoids holding the lock inside of GetOrCreateRemoteStreamAdapter
and GetOrCreateLocalStreamAdapter while we call out to external implementations
(CreateRemoteStreamAdapter and CreateLocalStreamAdapter).
Holding the lock could cause us to deadlock with the main thread or webrtc's signaling thread
if the lock was needed on the other thread during the nested call.
[email protected]
(cherry picked from commit ea0efafb2425865de79501bc3cf76dc539c995d8)
Bug: 736725
Change-Id: I121db4482bd9492de268b062f872b2af1d8484ca
Reviewed-on: https://chromium-review.googlesource.com/868656
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Tommi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#529518}
Reviewed-on: https://chromium-review.googlesource.com/894201
Reviewed-by: Tommi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#622}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Do not delay removing of the blur when unlocking.
[email protected]
(cherry picked from commit f341c59bc188013f67ccd7498806293d5e5802e2)
Bug: 801632, 803712
Change-Id: I559c747a7bd92df052258ef2e18b469e9fe09ef1
Reviewed-on: https://chromium-review.googlesource.com/872128
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Aga Wronska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530594}
Reviewed-on: https://chromium-review.googlesource.com/891695
Cr-Commit-Position: refs/branch-heads/3282@{#621}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.137
[email protected]
Change-Id: I317baa0ee51a359ee0aa566bd85e8d8c78db4a20
Reviewed-on: https://chromium-review.googlesource.com/893823
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#620}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
v8binding: Fixes a crash issue at GeoNotifier::TimerFired.
Geolocation stops owning GeoNotifiers in some cases (e.g.
Geolocation::clearWatch), so it's possible that, when
GeoNotifier::TimerFired gets invoked, the owner geolocation
had already stopped owning the notifier. In this scenario,
no one is performing wrapper-tracing for the notifier, thus
the underlying V8 functions might have already been
collected by V8 GC. GeoNotifier must not invoke any
callback in such a case.
This patch adds a check whether the geolocation still owns
the notifier or not.
Originally Reviewed-on: https://chromium-review.googlesource.com/893240
(cherry picked from commit 1063641d0bf9b23449f758d7e0de55b7611dcc06)
Bug: 792604
Change-Id: Iabfef1d0517c8d19c46f8f44f44d8b9998fa43dc
Reviewed-on: https://chromium-review.googlesource.com/893623
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#619}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
v8binding: Confirm that GeoNotifier::TimerFired has the execution context.
GeoNotifier::TimerFired should run only when it has an execution
context alive. We have an assumption that, if GetExecutionContext()
returns non-null, the execution context must be alive (not yet
destroyed). This patch temporarily adds a CHECK to confirm
whether it's true or not.
Originally Reviewed-on: https://chromium-review.googlesource.com/864182
(cherry picked from commit 82190c5fa7b0383b7262294f525b7f68fc655d1f)
Bug: 792604
Change-Id: I2e3942312a7b117a6dca28d9b60696558dee331a
Reviewed-on: https://chromium-review.googlesource.com/893608
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#618}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
cros: Notify powerd that views-based lock is finished.
Bug: 803727
Change-Id: I2fc28069cd33106b3c9019b402e9f549d956e54c
Reviewed-on: https://chromium-review.googlesource.com/879466
Reviewed-by: Dan Erat <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531031}(cherry picked from commit 8aa06a97852df56583204001684a1218ea97372d)
Reviewed-on: https://chromium-review.googlesource.com/893698
Cr-Commit-Position: refs/branch-heads/3282@{#617}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Revert "Fix perf regression on replacing AcceleratedImageBufferSurface with CanvasResourceProvider"
This reverts commit 152957dd913e7f22712828839d237d38a9d9f10c.
Reason for revert: This CL causes severe flickering in canvas web apps
BUG=805605
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6f403d13aabe106b8ac956326806e22b5f762d6b
Reviewed-on: https://chromium-review.googlesource.com/893528
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#616}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.136
[email protected]
Change-Id: Ic257f1f33eb5dc27a19bab079f9d6d96cad39d22
Reviewed-on: https://chromium-review.googlesource.com/893438
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#615}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Keep alive Geolocation until its one-shot callbacks are invoked
This is a speculative fix for bug 792604.
It looks like that we're missing wrapper-missing somewhere and
the v8::Function of Geolocation's callbacks are collected prematurely.
This CL keeps Geolocation alive until all one-short callbacks are invoked.
This CL has no risk of causing memory leaks because 1) the one-shot callbacks are
guaranteed to be invoked in a finite time period and
2) ActiveScriptWrappable::HasPendingActivity is implemented in such a way that
it returns false after context gets destroyed.
[email protected]
(cherry picked from commit 62b45306b022e3c5f21818421b9fbac2740e0c14)
Bug: 792604
Change-Id: Ief245d0409fc6b1b35cfe11e3368de230b503482
Reviewed-on: https://chromium-review.googlesource.com/892557
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532775}
Reviewed-on: https://chromium-review.googlesource.com/892719
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#614}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Make SystemTrayView owned by the view hierarchy
Previously, I have added SystemTrayView class which was owned by SystemTray class (crrev.com/727379). But the views in the tray are assumed to be destroyed with the parent view and the bubble, so that caused some issues.
This patch changes that and makes SystemTrayView owned by the view hierarchy. Then the issues are solved.
This patch also updates the newly-added code in NetworkStateListDetaiedView because the code didn't assume that lifetime of views.
[email protected]
(cherry picked from commit 3ae2446be3d11e6393c0bc8567f953212babc63c)
Bug: 790716, 789833
Change-Id: I62eca328780cabb7c5d68967cc1ddee7a1e23b9a
Reviewed-on: https://chromium-review.googlesource.com/813153
Commit-Queue: Yoshiki Iguchi <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#523701}
Reviewed-on: https://chromium-review.googlesource.com/892194
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#613}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.135
[email protected]
Change-Id: Ia62aafd8231879c66d66904f6bc1f27e3f751b2e
Reviewed-on: https://chromium-review.googlesource.com/892418
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#612}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.134
[email protected]
Change-Id: Ie0b2007f76b093fd6012c427aaff7387cab47377
Reviewed-on: https://chromium-review.googlesource.com/892259
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#611}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Revert section of
https://chromium-review.googlesource.com/c/chromium/src/+/775606 that is
causing collisions on cookie creation time.
This is a quick fix of problems
being seen in the field; a longer term fix is being tracked in
http://crbug.com/800414.
Bug: 800414
Bug: 795827
Bug: 794453
Change-Id: I0ff206fdc517e20f270cebadc6b64704f4c18d21
Reviewed-on: https://chromium-review.googlesource.com/889958
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Randy Smith <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#532152}(cherry picked from commit e6515d6ae158f5b53b8ee697cdd99d714a8ab402)
Reviewed-on: https://chromium-review.googlesource.com/891564
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#610}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.133
[email protected]
Change-Id: Id9f0f3d287ae0296471a3ff7b59f9b6aef16c0e6
Reviewed-on: https://chromium-review.googlesource.com/890069
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#609}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.132
[email protected]
Change-Id: I4bbb1bb9feb11e1b3917994457e176ef1d239880
Reviewed-on: https://chromium-review.googlesource.com/890365
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#608}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.131
[email protected]
Change-Id: I82c7a2794e1bbe42dbfa2d69f50de3175309d6ce
Reviewed-on: https://chromium-review.googlesource.com/889847
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#607}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.130
[email protected]
Change-Id: I938b9d237800edb2c074c735b561a257e1a3e9fb
Reviewed-on: https://chromium-review.googlesource.com/889822
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#606}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.129
[email protected]
Change-Id: I2e5a0c18144fa68946761a8f8e7901e653b550cd
Reviewed-on: https://chromium-review.googlesource.com/889801
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#605}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.128
[email protected]
Change-Id: Ie684f13c6d33d85bfa785a18c088c30a6b0e281b
Reviewed-on: https://chromium-review.googlesource.com/890358
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#604}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Fix build failure from change 0186bfee26ca0bc9d6eff1e80203f84319aec437
This change does without the helper method CanvasResourceProvider::
WritePixels, which exists in ToT, by simply in-lining the helper
method at the call site.
BUG=802081
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4d17934202154e0ed977dd0c7da1c0d1829e8a46
Reviewed-on: https://chromium-review.googlesource.com/890281
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#603}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.127
[email protected]
Change-Id: Iecf592bc895dd4652a34e9bf05fb5edcf8fda053
Reviewed-on: https://chromium-review.googlesource.com/889940
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#602}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.126
[email protected]
Change-Id: I7be6d88323b0ca177880e900677388581aad7b02
Reviewed-on: https://chromium-review.googlesource.com/890001
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#601}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Fix performance regression in putImageData
This CL returns to the simple direct blit code path we had before.
In CL https://chromium-review.googlesource.com/c/chromium/src/+/758562
the implementation of Canvas2DLayerBridge::WritePixels was changed to
go through the PaintCanvas interface, which required making an extra
copy and force the pixels through an alternate color correction code
path that handles alpha blending correctly. It turns out that this
detour is unnecessary since alpha blending does not come into play in
putImageData since it is a straight blit.
BUG=802081
[email protected]
(cherry picked from commit 7243aeeab61b2599e180f0cb4ddbba13daf323bf)
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3af99cc56745f6db52921282d905f73981675926
Reviewed-on: https://chromium-review.googlesource.com/883770
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Justin Novosad <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531723}
Reviewed-on: https://chromium-review.googlesource.com/889410
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#600}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Chrome OS: Fix crash in SigninScreenHandler::HandleAuthenticateUser.
SigninScreenHandler::HandleAuthenticateUser should ignore 'User not found'
errors.
[email protected]
(cherry picked from commit ccfa68e7d92f1e389fd8e33f859f56532ffa12cc)
Bug: 794487
Change-Id: I83c9a9bc2787514384e5bbee9253eaf383df94db
Reviewed-on: https://chromium-review.googlesource.com/850998
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#527106}
Reviewed-on: https://chromium-review.googlesource.com/888786
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#599}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.125
[email protected]
Change-Id: I20c5c7f3d782b3f1ba014d8319cf449331ec12b8
Reviewed-on: https://chromium-review.googlesource.com/887979
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#598}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.124
[email protected]
Change-Id: Id8c9ec41315342978219581aa73f8a48aec5595e
Reviewed-on: https://chromium-review.googlesource.com/887899
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#597}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.123
[email protected]
Change-Id: I734edd1d444025cca801f8aea9b046d7777033e0
Reviewed-on: https://chromium-review.googlesource.com/886383
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#596}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.122
[email protected]
Change-Id: I17f8cc31feeecfaa820839800894ce72556ff998
Reviewed-on: https://chromium-review.googlesource.com/886062
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#595}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.121
[email protected]
Change-Id: Id313bc1337b6e2ef2bb482a5f326e217b57d77f6
Reviewed-on: https://chromium-review.googlesource.com/885221
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#594}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[WebView Autofill] Post DidChangeScrollOffset outside PerformLayout
If LocalFrameView::PerformLayout() ends up calling
LocalFrameView::ViewportSizeChanged(), then
it may in turn call AutofillAgent::DidChangeScrollOffset().
However, FindFormAndFieldForFormControlElement() and
ElementBoundsInWindow() requires that document life cycle to be
mutatable (and thus not in the middle of perform layout).
Therefore, posting a task to delay calling these functions outside
PerformLayout().
Note that this uses a similar mechanism as
FormTracker::TextFieldDidChange().
BUG=804886
(cherry picked from commit 9db32db4d0cd5633d6d76d77ac74288d6d528cad)
Change-Id: Ibe6e6d9921185f075d16c6c955d45d17ad490fd5
Reviewed-on: https://chromium-review.googlesource.com/882664
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531528}
Reviewed-on: https://chromium-review.googlesource.com/884504
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#593}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Settings: Network details: Update enable Connect correctly
This fixes the Polymer data binding to update the enable state of the
'Connect' button correctly.
Bug: 804459
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb3b16824d526123ae7a934589bcae53e1b51e66
Reviewed-on: https://chromium-review.googlesource.com/881531
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#592}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Reland "Fix strip which appears over the toolbar on exiting immersive fullscreen."
This is a reland of e5e0800876fb452f690eb349b2fb1a77eccb6b54.
Original change's description:
> Fix strip which appears over the toolbar on exiting immersive fullscreen.
>
> This regressed in r492972 (switch to a custom window frame view class).
>
> When not using NSWindowStyleMaskFullSizeContentView (macOS <10.12, but
> it can probably be turned on back to 10.10), certain circumstances
> caused the tab strip background view to partially cover up the toolbar.
> The most reliable way to reproduce it, for me, is:
>
> - Be running macOS 10.11 or older.
> - Have multiple monitors connected.
> - Turn off "Displays have separate Spaces" in System Preferences.
> - Enter web content fullscreen (e.g. on YouTube).
> - Exit fullscreen by pressing Esc.
>
> Three things came together to make this happen:
>
> 1. |-[FramedBrowserWindow browserFrameViewPaintHeight]| returned a
> hard-coded value when not using FullSizeContentView. I believe it
> used to represent the height of the tab strip but no longer does, and
> I believe it was just kept out of caution when the full size content
> view path was added, but it's bigger than it needs to be and makes
> the tab strip background view slightly larger than necessary. (This
> value originally appeared in r40677).
>
> 2. |-[TabWindowController
> insertTabStripBackgroundViewIntoWindow:titleBar:]| explicitly
> inserted the background view behind all other views.
>
> 3. The immersive fullscreen path, which is only taken when multiple
> monitors are connected and "Displays have separate Spaces" is turned
> off (see |-[BrowserWindowController enterWebContentFullscreen]|)
> inserts the content view behind all other views on exiting fullscreen
> (see |-[BrowserWindowController
> moveViewsForImmersiveFullscreen:regularWindow:fullscreenWindow:]|),
> which means that it's now behind the tab strip background view.
>
> I'm fixing this with three changes:
>
> 1. Get rid of the special value in |-browserFrameViewPaintHeight| and
> return |chrome::kTabStripHeight| in both cases.
>
> 2. Hide the |visualEffectView_|/|tabStripBackgroundView_| in fullscreen
> always, not just when using FullSizeContentView — othersise, it can be seen
> visible on top of the content in fullscreen.
>
> 3. When setting up a window, insert the tab strip background view
> normally instead of behind its siblings. It just made these bugs
> harder to find (the strip would have appeared all the time,
> otherwise).
>
> [email protected]
>
> (cherry picked from commit 1b761b8d95af216fbd403262ac001ab362e7a6b3)
>
> Bug: 779082
> Change-Id: Id9536dc6ff8593b3e7e2b3f38bbf9149418d0ac6
> Reviewed-on: https://chromium-review.googlesource.com/848641
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Commit-Queue: Sidney San Martín <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#526766}
> Reviewed-on: https://chromium-review.googlesource.com/858316
> Reviewed-by: Sidney San Martín <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3282@{#472}
> Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Bug: 779082
Change-Id: Icc980357f0008056de745d28083558a59cb2865e
Reviewed-on: https://chromium-review.googlesource.com/882266
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#591}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
Incrementing VERSION to 64.0.3282.120
[email protected]
Change-Id: I7b8c31fc9fb74f85a0fab6ff9a4c344205d98f7f
Reviewed-on: https://chromium-review.googlesource.com/882684
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3282@{#590}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}