Publish DEPS for Chromium 63.0.3239.70
Incrementing VERSION to 63.0.3239.70
[email protected]
Change-Id: Ibf2e88363692b7bd2f70b23b5b5ad704e6474ac1
Reviewed-on: https://chromium-review.googlesource.com/795231
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#597}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Updating XTBs based on .GRDs from branch 3239
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie1f66863d2ec302f4fe84bc5bbea93c7f2f64f2d
Reviewed-on: https://chromium-review.googlesource.com/795035
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#596}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reverts 2 CLs to fix missing favicons issue.
The following 2 CLs are reverted on M63 branch in this CL.
https://chromium-review.googlesource.com/c/chromium/src/+/707003
https://chromium-review.googlesource.com/c/chromium/src/+/695761
[email protected]
Bug: 788708
Change-Id: Ia95d76cd3882f494ad3d34a74ab136189847d2a0
Reviewed-on: https://chromium-review.googlesource.com/795033
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#595}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Cros: fix the issue that window(s) show on incorrect user desktop.
It's caused by a code refactoring.
Bug: 781491
[email protected]
(cherry picked from commit c751780dd515bb4cfbda5d41f26a339a41846ee8)
Change-Id: I7be6edf96e18b1e93e754ed1a4b1658999afdb29
Reviewed-on: https://chromium-review.googlesource.com/784128
Reviewed-by: Stefan Kuhne <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518538}
Reviewed-on: https://chromium-review.googlesource.com/795031
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#594}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge M63: Extensions: Whitelist bookmark apps in StandardManagementPolicyProvider.
Original description:
>r496521 made the extension management policy checks more consistent. This had a
>side effect of disabling bookmark apps when the appropriate
>ExtensionInstallBlacklist/ExtensionAllowedTypes/ExtensionSettings policies were
>set. This CL whitelists bookmark apps in
>StandardManagementPolicyProvider::UserMayLoad. Hence the bookmark apps should no
>longer get disabled by the ExtensionInstallBlacklist, ExtensionAllowedTypes and
>ExtensionSettings policies.
>
>Based on https://chromium-review.googlesource.com/#/c/780205/
>
>[email protected]
>BUG=786061
>TEST=On Linux, navigate to google.com. Use chrome -> settings -> more tools ->
>"Add to Desktop..." to create a desktop shortcut for google.com. Change
>ExtensionInstallBlacklist to block all extensions ("*"). Ensure the same from
>
>chrome: //policy. Click on the google.com shortcut created earlier (from
>chrome: //apps or Desktop) and ensure that it works correctly.
>Change-Id: Ic2ac1ddd2dfef6c5442eb7b0d366eaf66443c51d
>Reviewed-on: https://chromium-review.googlesource.com/787011
>Reviewed-by: calamity <[email protected]>
>Reviewed-by: Maksim Ivanov <[email protected]>
>Commit-Queue: calamity <[email protected]>
>Cr-Commit-Position: refs/heads/master@{#519052}
[email protected]
Change-Id: Ic2ac1ddd2dfef6c5442eb7b0d366eaf66443c51d
Reviewed-on: https://chromium-review.googlesource.com/794880
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#593}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Media Controls: stops scrubbing when receiving pointercancel event.
The pointercancel event is fired when the pointer events are cancelled,
for example when the system decides that the touch was a mistake or when
the event is used for other type of behaviour such as padding. When the
event is cancelled this way, the pointerup event isn't fired, leaving
media controls in a broken state.
[email protected]
(cherry picked from commit 07ef1032af129175c6ba2248037120e01ff6364b)
Bug: 782628
Change-Id: I225dc459a94d53a7723fa62ed3af006c1c0d6e93
Reviewed-on: https://chromium-review.googlesource.com/787973
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518976}
Reviewed-on: https://chromium-review.googlesource.com/794112
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#592}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Ensure clean style when checking style in IsTabHTMLSpanElement
IsTabSpanElement() checks the 'white-space' style of an element, but
may be called with dirty style, and hence causing crash. This patch
adds a style update in the function to stop the crash.
[email protected]
(cherry picked from commit 9bbd081d6401276e8173cf0e33b9f93cba1c1b01)
Bug: 778901, 779527
Change-Id: I0c0d22f1a94ce06abd5fd146421cf00e4dbf6ac1
Reviewed-on: https://chromium-review.googlesource.com/772832
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517774}
Reviewed-on: https://chromium-review.googlesource.com/794631
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#591}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't send non-NAVIGATION_ID UKM Sources with no entries.
This change makes it so that UKM Sources that have no entries
and that aren't NAVIGATION_ID-based will not be sent up. If
a source is not sent this way, it will be kept around (up to
a limit of 100 sources - which can be overridden by a param)
so that it can be sent in the next log if there's an entry for
it at that point.
This allows us to use the UKM whitelist mechanism to disable
metrics and have their associated sources not sent. (For metrics
that don't use NAVIGATION_ID - as NAVIGATION_ID ones are safe.)
BUG=788887
[email protected]
(cherry picked from commit 7fbb0178109181f253eeb60b072d958d919b4008)
Change-Id: Ibfa468643e52b2adff0f416af6f4078ca91e7229
Reviewed-on: https://chromium-review.googlesource.com/789651
Commit-Queue: Alexei Svitkine <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Bryan McQuade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#519816}
Reviewed-on: https://chromium-review.googlesource.com/794550
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#590}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.69
[email protected]
Change-Id: Ibeee1099624374e25426c5dfe0a0bc56ad78c481
Reviewed-on: https://chromium-review.googlesource.com/794101
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#589}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android WebAPK] Fix WebAPK runtime library AIDL order
The compiler assigns to each method in the AIDL file a numeric identifier based on the
method's order in the AIDL file.
https://chromium-review.googlesource.com/c/chromium/src/+/667002 added a method in the
middle of the AIDL file.
As a result, for:
- Chrome which has been compiled against the AIDL prior to the CL (pre 63.0.3227.0)
- a WebAPK which has been compiled against the AIDL after the CL
A call from Chrome for IWebApkApi#notifyNotification() attempts to run
notificationPermissionEnabled() in the WebAPK
BUG=788003
R=​yfriedman
TBR=rsesek (The CL only changes the order of the methods in the aidl file)
Change-Id: Ia6912e53322e2622cd15dd318b47b9f451b29c00
Reviewed-on: https://chromium-review.googlesource.com/788182
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#519026}(cherry picked from commit 7f5f5c05a0f798b06b54fce08215c2fce924e5da)
Reviewed-on: https://chromium-review.googlesource.com/794350
Reviewed-by: Peter Kotwicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#588}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Use top frame origin for reporting WatchTime UKM
Inner frame URLs should not be reported for privacy. We still record
metrics for inner frames, but with the top frame's origin. This CL also
adds a flag for is_top_frame so we can tell the meaning of the URL.
(cherry picked from commit 1062fabdb739c9778032d369d923128952747671)
Bug: 785513
Change-Id: I54ef3c8f7a377a11ff93d67372cd178db77c4d21
Reviewed-on: https://chromium-review.googlesource.com/772806
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Chrome Cunningham <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518078}
Reviewed-on: https://chromium-review.googlesource.com/793987
Reviewed-by: Chrome Cunningham <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#587}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge M63: Update Flash plugin metadata versions to latest version.
https://helpx.adobe.com/security/products/flash-player/apsb17-33.html
BUG=412078
[email protected]
(cherry picked from commit c619b77f7461ebe5454048488dfbc7d55786aadc)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1b81321c46c655080cc8284191bb4bebdbd04f60
Reviewed-on: https://chromium-review.googlesource.com/769287
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: Justin Schuh <[email protected]>
Commit-Queue: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516392}
Reviewed-on: https://chromium-review.googlesource.com/793892
Cr-Commit-Position: refs/branch-heads/3239@{#586}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Allows renderer gets post data if devtools attached w/ plzNavigate
Adds a temporary fix to allow devtools to get the post data of
navigation request if the renderer has devtools attached.
TBR=pfeldman,govind
R=caseq,clamy
BUG=766715
(cherry picked from commit 649cc21a76d5e7e6dba6077b8013d3b8bf4ccc2d)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I875ea05e778fc431b6073a6fb6b1c393bcc904be
Reviewed-on: https://chromium-review.googlesource.com/770490
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Blaise Bruer <[email protected]>
Commit-Queue: Blaise Bruer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518109}
Reviewed-on: https://chromium-review.googlesource.com/794342
Reviewed-by: Blaise Bruer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#585}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add workaround for reallocating depth-stencil renderbuffers.
When needed, during reallocation of a depth-stencil renderbuffer,
create a new object and point all existing framebuffer objects to it.
Apply this workaround on NVIDIA GPUs on macOS 10.13 and later. This
works around an apparent bug in the graphics driver introduced in this
release.
This is a slight expansion of the earlier
multisample_renderbuffer_resize_emulation workaround.
Remove associated failure expectations. Also update the bug ID in the
conformance expectations for a workaround applying to the same
platform.
BUG=775202, 786717, 784817
[email protected]
(cherry picked from commit 3b7911b65b0d70164ed9b88ec22a9a455fa649b7)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I051009b17df1cb5dabe1b00fbdcc35008042eee9
Reviewed-on: https://chromium-review.googlesource.com/780211
Reviewed-by: Kai Ninomiya <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518348}
Reviewed-on: https://chromium-review.googlesource.com/794024
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#584}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}List markers should always get a layout when the list item does.
A follow-on to https://chromium-review.googlesource.com/602352.
Turns out it is safer to always update the list marker position after
laying out a list item.
[email protected]
(cherry picked from commit 7a22edaa3ae7ef77e5d2499062bbccf24f1f5f1c)
Bug: 780927
Change-Id: I09ef8e38bcb65a33593d8b6198f29dbd9dce26c7
Reviewed-on: https://chromium-review.googlesource.com/753362
Reviewed-by: Emil A Eklund <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513886}
Reviewed-on: https://chromium-review.googlesource.com/794035
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#583}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[m63 merge] Add a new HttpNetworkSession param quic_allow_remote_alt_svc to determine if we honor QUIC remote alt-svcs.
[email protected]
(cherry picked from commit c84473f329399b3e437235cf01e8d7fc8355c150)
Bug: 787949
Change-Id: I2f91b6b08a61f098e9f18fee9d986df968e00d27
Reviewed-on: https://chromium-review.googlesource.com/786329
Reviewed-by: Jana Iyengar <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518838}
Reviewed-on: https://chromium-review.googlesource.com/791825
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#582}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[ios] Merge GetLastCommittedNonAppSpecificItem fix to M63.
Currently there is an inconsistency between CreateNavigationItem and
GetLastCommittedNonAppSpecificItem. The former sets user agent type of
an item to NONE if URL is app-specific. The latter looks for an item
with user agent type that is not NONE, and uses VirtualURL to find
these. Historically this has not been a problem because app-specific
URLs always had identical VirtualURL.
Offline Reading List navigation items break this assumption. They have
app-specific URLs (e.g. chrome://offline/<blob>) and regular-looking
VirtualURLs.
Bug: 781284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I45d9afdb854b1d5340f6d4d2bb7ac306f0897662
Reviewed-on: https://chromium-review.googlesource.com/764540
Commit-Queue: Danyao Wang <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Yuke Liao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515983}(cherry picked from commit 48511a8d7675a8cf4d4a0ae06d94715b8b562943)
Reviewed-on: https://chromium-review.googlesource.com/794151
Cr-Commit-Position: refs/branch-heads/3239@{#581}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Define toolbar button height and width in-line instead of in styles.xml"
This reverts commit 646389458cfd7dc558a6ced895de2140711608b8.
Reason for revert: Speculative fix didn't fix crashes. See bug for details.
Original change's description:
> Define toolbar button height and width in-line instead of in styles.xml
>
> Define the layout_height and layout_width for ToolbarButton elements
> in-line rather than in styles.xml. This is a speculative fix for crash
> reports we've received indicating these attributes are missing.
>
> BUG=779271
>
> [email protected]
>
> Change-Id: I732ee9b39262aa8bfbc74dea57ea72469cd9e647
> Reviewed-on: https://chromium-review.googlesource.com/764378
> Commit-Queue: Theresa <[email protected]>
> Reviewed-by: Ted Choc <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#515966}
> Reviewed-on: https://chromium-review.googlesource.com/777766
> Reviewed-by: Theresa <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#532}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 779271
Change-Id: I8d3aa852a32cb5e336c549a114fb0e5cdcc6c576
Reviewed-on: https://chromium-review.googlesource.com/794010
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#580}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63][Autofill] Trim some invisible unicode characters when suggesting credit cards
As reported in the wild.
[email protected]
(cherry picked from commit 532f3c67ad698c4dc45912590a70f61ec9aebb78)
Bug: 788045
Test: AutofillManagerTest
Change-Id: I9b21d0fcec51a1b43281d0b8497e71b0cc60eea6
Reviewed-on: https://chromium-review.googlesource.com/786213
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518922}
Reviewed-on: https://chromium-review.googlesource.com/793870
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#579}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Web MIDI: MidiManagerMac should calculate index beforehands
The newly connected input port needs to calculate the device index,
it - sources_.begin(), but it should be done before pushing the new
instance to the sources_ because it invalidate the iterator.
Bug: 781220
Change-Id: Id41bb2f006e88390a1c94c84d2f8ee54e03fd592
Reviewed-on: https://chromium-review.googlesource.com/789211
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#519141}(cherry picked from commit de45d3ea7491f9a7ef8d4488f4f70d5f5ae2c7b8)
Reviewed-on: https://chromium-review.googlesource.com/792711
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#578}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.68
[email protected]
Change-Id: I1087912fa11e4ca90fddd4096c5d0adc149bc4d3
Reviewed-on: https://chromium-review.googlesource.com/792215
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#577}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add enterprise policy settings for Site Isolation.
Introduce enterprise policies to allow setting Site Isolation flags in
enterprise environments.
BUG=783842,760761
[email protected], [email protected]
(cherry picked from commit ac7d75648d323f2e08afd117b09318a4290e52a2)
Change-Id: I59b91aad33403a8138e5543bfb6847d68339b5c5
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/765008
Commit-Queue: Chris Palmer <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518725}
Reviewed-on: https://chromium-review.googlesource.com/792130
Cr-Commit-Position: refs/branch-heads/3239@{#576}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge-63 [Autofill] Use root URL when logging UKM for iframes.
UKM should log the top level URL, not the one of the iframe.
Adds the root origin to FormData and FormStructure so the UKM can use
that instead of the url in which the form is.
[email protected]
(cherry picked from commit 11a78383a6c7fa914d341f187039b71d74473652)
Bug: 784550
Change-Id: Iba949bde58b573019b3c3867bec3f679905c9b4f
Reviewed-on: https://chromium-review.googlesource.com/770654
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Roger McFarlane <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517950}
Reviewed-on: https://chromium-review.googlesource.com/791157
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#575}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge into M63] Save new_password_value hash upon change password
[email protected]
(cherry picked from commit 88c5d9872a405c03e44977c85118bf999d4a443e)
Bug: 767621
Change-Id: I18aa2d13d2a255692adeee28e0319540358c3f31
Reviewed-on: https://chromium-review.googlesource.com/782799
Commit-Queue: Jialiu Lin <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518457}
Reviewed-on: https://chromium-review.googlesource.com/791650
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#574}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Views] Fix LocationIconView focusable behavior
Currently the LocationIconView can be selected as
part of keyboard access when the search icon is
displayed (and therefore not clickable).
This CL fixes it by setting its FocusBehavior to
never when the search icon is displayed.
(cherry picked from commit a43aaf3011ef872121b6d81639290197a6ed4ea7)
Bug: 778859
Change-Id: If0d57efed6d3ecfd2f0ad01cc1fd105d65feb18a
Reviewed-on: https://chromium-review.googlesource.com/777966
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Sarah Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518053}
Reviewed-on: https://chromium-review.googlesource.com/791519
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#573}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Focus action button instead of triggering in profile picture chooser.
This improves accessibility behavior by focusing the button that will
perform the action when the selected item is pressed. Before, this
would have deleted a user photo or taken a photo. The new behavior
moves focus to a button that is properly labeled.
Bug: 765104,767820
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8b813a9d53c0e5b47579274253c173fc4294404f
Reviewed-on: https://chromium-review.googlesource.com/764594
Commit-Queue: Hector Carmona <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516391}(cherry picked from commit d4e5fdd3f018ead78e22e62d6a5a1943e0014598)
Reviewed-on: https://chromium-review.googlesource.com/791211
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#572}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}views: remove auxiliary text from collected cookies
Right now, this text is redundant with the infobar, although it will need
to be re-added when this dialog is redesigned without the infobar. Worse,
it is inaccurate in the "clear on exit" case of the Blocked panel.
[email protected]
(cherry picked from commit 18ac7f17e5517f3d6ce9bebab472e87cb0292c6c)
Bug: 610428, 787375
Change-Id: I20065f6823e60c6903a65d8ab022e77674cbdd58
Reviewed-on: https://chromium-review.googlesource.com/782661
Commit-Queue: Elly Fong-Jones <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518347}
Reviewed-on: https://chromium-review.googlesource.com/790610
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#571}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android WebView] Lower minidump generation fraction to 1% for Stable
To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.
BUG=772814
Change-Id: I0542225dc89f453b726db29932eee75b6e5be668
Reviewed-on: https://chromium-review.googlesource.com/786233
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#570}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.67
[email protected]
Change-Id: I437103419792078ee4cc14a64cee4fc19319a66c
Reviewed-on: https://chromium-review.googlesource.com/789563
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#569}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.66
[email protected]
Change-Id: I76f8e599725694a05b7dda4d46f51ea37f4c14ad
Reviewed-on: https://chromium-review.googlesource.com/789439
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#568}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.65
[email protected]
Change-Id: I7ce5fcba254efe2763fb961b175dbe4330ee64e8
Reviewed-on: https://chromium-review.googlesource.com/789555
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#567}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.64
[email protected]
Change-Id: I001a3c9cb22b34527c8e822a15d793f6c803243c
Reviewed-on: https://chromium-review.googlesource.com/788285
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#566}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.63
[email protected]
Change-Id: I287f0d5c7accfc3bd5af5d30f81185bdaf639894
Reviewed-on: https://chromium-review.googlesource.com/786114
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#565}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix the Bookmarks hidden under navigation bar issue.
Fix the issue that when bookmarks exceeds screen height, the auto
adjusted inset of tableView will cause the bookmarks to be shown under
the navigation bar at the first appearance.
An egtest is added to make sure this issue won't happen again.
Bug: 772383
Change-Id: Id3f9b33b3b882d3b8a680d7ef8f9053565161541
Reviewed-on: https://chromium-review.googlesource.com/754661
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Marti Wong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515507}(cherry picked from commit d86f66d8e5fbbbdea4ee7f6e36bd352cab3552de)
Reviewed-on: https://chromium-review.googlesource.com/786730
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#564}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Filter out non whitelisted UKM sources.
BUG=787610
[email protected]
(cherry picked from commit 18d82cc511c029a641bd853299eb841e7cf1368c)
Bug: 787610
Change-Id: Iad08a01f9abb912dd9801fd02203df3c05cad3f0
Reviewed-on: https://chromium-review.googlesource.com/782659
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Bryan McQuade <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#518463}
Reviewed-on: https://chromium-review.googlesource.com/786343
Reviewed-by: Bryan McQuade <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#563}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Get rid of redundant call of SetIsDirectional() in SelectionController::SetNonDirectionalSelectionIfNeeded()"
This is a manual revert of commit 9063cb91499ef3cf13e085ae4ad27ae52e09019a.
Reason of revert: causing crbug.com/785147. The |SetIsDirectional()| call
removed in the reverted CL turns out to be not redundant: it affects the
|IsDirectional()| value of |selection_in_flat_tree|, which is taken into
the decision of whether to abort the current operation or not.
Bug: 785147, 740804
Change-Id: I7f92ae1fe5223557346360a4509a3e448b0165fc
Reviewed-on: https://chromium-review.googlesource.com/779967
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518086}(cherry picked from commit 217d5aa0eba9d6e74f54712b1c1c5197442d5738)
Reviewed-on: https://chromium-review.googlesource.com/786352
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#562}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Workaround for NPE in UrlBar#onTouchEvent()
BUG=757161
Change-Id: Icc9e4a60731cd3f18da1f966fd54ae7733f0366f
Reviewed-on: https://chromium-review.googlesource.com/781103
Reviewed-by: Maria Khomenko <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518266}(cherry picked from commit e2a26b34ebd720ad07dc88997804bfd4ee43ae84)
Reviewed-on: https://chromium-review.googlesource.com/785872
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#561}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.62
[email protected]
Change-Id: If0d59d206e8a587cda6d81ad0dd71d2ad5ef8caa
Reviewed-on: https://chromium-review.googlesource.com/783798
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#560}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix bad merge
[email protected]
Bug:
Change-Id: Icab850b62f85d323041f0e211b1f7074687c3ef1
Reviewed-on: https://chromium-review.googlesource.com/784112
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#559}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.61
[email protected]
Change-Id: I26e9a873724bfeb9fba60c800931a3a19a9441d7
Reviewed-on: https://chromium-review.googlesource.com/784130
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#558}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to m63]: Disable clipping temporarily to fix a bug in Chrome 63.
Clipping will be re-enabled with a more robust solution for
newer versions of chrome, that will expose both the clipped
and unclipped bounds to ChromeVox.
Bug: 786164
Change-Id: Ia22fc00236168f9ba41841f6810b72bdd24d4612
Reviewed-on: https://chromium-review.googlesource.com/777541
Commit-Queue: Katie D <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#517620}
(cherry picked from commit bf5767172e191a022fac3deec4d772968015aaf5)
[email protected]
Change-Id: Ifd3ec2597c3efc4b92a9de4dec29496ac2a168ec
Reviewed-on: https://chromium-review.googlesource.com/783492
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#557}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert LayoutView::StyleWillChange viewport invalidation
This patch is a speculative revert of the following patch:
"Let LayoutView::StyleWillChange handle viewport invalidation."
https://chromium-review.googlesource.com/c/chromium/src/+/609984
r495573
1fac40c94ca96fc8bac2b00aab7bddc0d3a7b851
This patch could be responsible for regressions in the following:
* Blink.Paint.UpdateTime
* Blink.Compositing.UpdateTime
[email protected]
(cherry picked from commit 8c08d938982fdf7bc7a7c9844db71cb2c35cb602)
Bug: 768612
Change-Id: I8d12b80473afee2eecdb3ff1a8c3538f334eaf59
Reviewed-on: https://chromium-review.googlesource.com/719336
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509012}
Reviewed-on: https://chromium-review.googlesource.com/783551
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#556}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Restore multi_gpu_category=any for Intel HD 3000 blacklisting.
This was apparently lost during the switch to use JSON files for the
blacklists.
BUG=661596
[email protected]
(cherry picked from commit 0c5fd85b836bb7216a5acc1ed9e463ff26c436ae)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3c4658d2c8d14f2f6e6b8ce9a591693193780714
Reviewed-on: https://chromium-review.googlesource.com/778187
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#518031}
Reviewed-on: https://chromium-review.googlesource.com/782648
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#555}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Move early return for iph inside tracker initialization callback
Check if the sheet is open, layout manager is null, or overview is
visible inside the tracker initialization callback in case state has
changed during tracker intialization.
BUG=786251
Change-Id: I5cbfa00a98f06a02e9145f569c096595243f35cd
Reviewed-on: https://chromium-review.googlesource.com/777119
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517479}(cherry picked from commit cfef5d51ca13489dddca1ab9b4eeca42dce1d45c)
Reviewed-on: https://chromium-review.googlesource.com/782741
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#554}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Updating XTBs based on .GRDs from branch 3239
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idf76122e224862548a2b74a7e87dde0f1ad032d7
Reviewed-on: https://chromium-review.googlesource.com/781602
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#553}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.60
[email protected]
Change-Id: I5c6f2e72101d54d2e2cf47a3f12525a016f83c18
Reviewed-on: https://chromium-review.googlesource.com/780461
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#552}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}IndexedDB: Added UMA value for destruction of corrupt leveldb.
Added WebCore.IndexedDB.DestroyCorruptBackingStoreStatus to record the
result of an attempt to destroy a corrupt (leveldb) backing store used
by Indexed DB.
[email protected]
(cherry picked from commit 538fe6816c231c7c91ce15a4983834f9e1a55811)
Bug: 782972
Change-Id: I13e9d64531c72d1d4f5193e2d682671d799f59a5
Reviewed-on: https://chromium-review.googlesource.com/759616
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Chris Mumford <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515574}
Reviewed-on: https://chromium-review.googlesource.com/780199
Reviewed-by: Chris Mumford <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#551}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
