Publish DEPS for Chromium 63.0.3239.59
Incrementing VERSION to 63.0.3239.59
[email protected]
Change-Id: I7b9549cfbc26c36f0f16c179ab9497fa5ca97aa4
Reviewed-on: https://chromium-review.googlesource.com/779086
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#550}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Enable the Windows 10 inactive user toast experiment.
BUG=717091
R=[email protected], [email protected]
Change-Id: I1e8d1d9ac4dd7f5f9e1feb80aaad38dfea6ba7cc
Reviewed-on: https://chromium-review.googlesource.com/544817
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517041}(cherry picked from commit 0a18637be2718c3e4c911717cf6a0bf80cde63e6)
Reviewed-on: https://chromium-review.googlesource.com/779267
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#549}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Inactive toast Keyboard navigation tweaks
Use ShowInactive, add tab stops
(cherry picked from commit db5befa037fe7fc56a7631bd6eba522d2735b59c)
[email protected]
Bug: 717091
Change-Id: I53a709caf11df5dc9ef902616307c00404855bd8
Reviewed-on: https://chromium-review.googlesource.com/715440
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515179}
Reviewed-on: https://chromium-review.googlesource.com/779582
Cr-Commit-Position: refs/branch-heads/3239@{#548}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Smart Selection] Require only O for WebView.
Updates Smart Text Selection to enable on WebView for O+ and for
Chrome to be O_MR1+. This effectively reverts CL 773782 for WebView,
but leaves Chrome unchanged.
BUG=785033
(cherry picked from commit 1c78435451de2092b60d2802018eb55b29aa70d4)
Change-Id: Iccdb8a5a56d34cb5275a87260e95fa1974db8ce0
Reviewed-on: https://chromium-review.googlesource.com/776198
Commit-Queue: Donn Denman <[email protected]>
Reviewed-by: Shimi Zhang <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517586}
Reviewed-on: https://chromium-review.googlesource.com/779960
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#547}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Blink] Prevent heavy inlining in PrePaintTreeWalk::Walk()
This is a recursive function and inlining will result in larger stack
frames. We've observed as bad as ~4KB per frame on Win64 PGO builds,
that resulted in stack overflow. This CL splits all the heavy lifting to
a explicitly NOINLINE function so the local frame is isolated from
recursion.
BUG=781301
[email protected]
(cherry picked from commit 5a448b74592d258e2a37df67728251bf8d8565b1)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I787991639bad184674c172880bac9abf665e4117
Reviewed-on: https://chromium-review.googlesource.com/767548
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517351}
Reviewed-on: https://chromium-review.googlesource.com/779941
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#546}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Kill the process if abortLaunch() fails to finish the activity.
ChromeActivity.onStart() sometimes crashes on null mSnackbarManager.
That is weird because mSnackbarManager is set in a function called
from onCreate(). The only way this can happen is if finish() called
by AsyncInitializationActivity.abortLaunch() fails, and the activity
continues its lifecycle. And indeed as analysis of finish() shows
(crbug.com/781396#c13) there are cases when it can fail.
This CL adds code to kill the process if abortLaunch() fails to finish
the activity. The change only affects Android L, because that's where
the crashes are happening.
Bug: 781396
Change-Id: I3428245bd80ccd6b8c1b4ced2010e9be29f1a4c5
Reviewed-on: https://chromium-review.googlesource.com/777683
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Dmitry Skiba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517575}(cherry picked from commit 33d84707a61f0c18d2d0ec185a4b30776e398962)
Reviewed-on: https://chromium-review.googlesource.com/779859
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#545}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63 cherrypick] Remove blocking call to VideoFrameCompositor
Currently, WMPI pulls the current frame from the VideoFrameCompositor
by posting a task on the compositor task runner and blocking on its
completion. The task forces a frame update if necessary. When a lot of
activity happens on the compositor task runner, the hang detector might
kick in and crash the process.
This CL attempts to mitigate the issue by adding getCurrentFrame_Locked
to the WFC, and posting seperate request to update the frame. This
removes the blocking call from WMPI and should prevent hangs. However,
WMPI might receive a frame that is slightly out of date, since the
request to update the frame happens after fetching it.
Bug: 697386
Change-Id: I76f216f265031536fca1f36a29025d28e3167763
Reviewed-on: https://chromium-review.googlesource.com/754339
Commit-Queue: Thomas Guilbert <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514758}(cherry picked from commit d8540741f175eab5b502b5f3cf75ebefe837daab)
Reviewed-on: https://chromium-review.googlesource.com/779622
Reviewed-by: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#544}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Mutate BottomToolbarPhone background
BottomToolbarPhone sets tint on its background drawable. Call mutate to
avoid sharing state with other uses of modern_toolbar_background.xml.
BUG=786283
Change-Id: Ia8ab7000297d03f03edf612dc49047290ae4346f
Reviewed-on: https://chromium-review.googlesource.com/777039
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517466}(cherry picked from commit 64f4905aa456f377026b04647b0d3c516dac28d2)
Reviewed-on: https://chromium-review.googlesource.com/779770
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#543}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63][chrome-signin] Reduce focus stealing.
Merge to beta: M63.
With the OOPIF implementation of webview, the embedder page is not
considered focused when the guest has focus (it does not see any
keyboard input). This means that upon reaching the end of the
<webview>'s content and focusing an element in the embedder,
<paper-icon-button> in this case, the page is first refocused.
This event listener only seemed to expect this to happen once at the
beginning.
This CL prevents the authenticator from focusing the webview if another
element is focused when the page itself is focused.
The alternative would be to call focus only once, when constructing the
Authenticator.
Bug: 781748
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac7020caad90c9e5e617f46bba392caeb09482b0
Reviewed-on: https://chromium-review.googlesource.com/775978
Commit-Queue: Alex Vallee <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517511}(cherry picked from commit 839ae6ef38f225cdf0195e186e9c162b26eadcd0)
Reviewed-on: https://chromium-review.googlesource.com/777711
Reviewed-by: Alex Vallee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#542}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63] Serialize member access in Audio{In,Out}putDevice.
Some members are accessed on both the owning thread and the IO thread.
A caveat: it's now more likely that authorization finishes before
|callback_| is set, meaning that authorization failure won't signal
an error. An error will still be signaled when trying to start the
stream, so it should be fine.
Bug: 783129
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibf90bf60632b9d2893b1e80852dbfaf01fa717a1
Reviewed-on: https://chromium-review.googlesource.com/765451
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Max Morin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#516636}(cherry picked from commit 237ad913ef44e075240ead90fea4cc2731d45cae)
TBR: [email protected]
Change-Id: Ibf90bf60632b9d2893b1e80852dbfaf01fa717a1
Reviewed-on: https://chromium-review.googlesource.com/779579
Reviewed-by: Max Morin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#541}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Prevent squashing of border-radius layers"
This reverts commit 8ff2371257ac4f24d77da4a62569840a53c49b47.
Reason for revert: Bad for performance and not correct
M-63 revert
Original change's description:
> Prevent squashing of border-radius layers
>
> Inline transforms cause overlap to be assumed, which in turn
> results in sibling layers being squashed. But when that is
> done, the border radius mask needed for descendants of the
> siblings is not applied and border radius is missing.
>
> This patch prevents squashing of layers with border radius.
>
> R=[email protected]
> BUG=761298
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Idc321a376634b0fe0b2f3cda92415d014904fda7
> Reviewed-on: https://chromium-review.googlesource.com/699170
> Reviewed-by: Chris Harrelson <[email protected]>
> Commit-Queue: Stephen Chenney <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#508329}
[email protected], [email protected]
(cherry picked from commit ad129f43d6ef7b47ef3845bfc43636bbcc2b5b92)
Bug: 761298
Change-Id: Ia46c645c2baa74e5b3d19634b4739b97bab0812b
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/772758
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516951}
Reviewed-on: https://chromium-review.googlesource.com/779439
Cr-Commit-Position: refs/branch-heads/3239@{#540}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Make V8IntersectionObserverDelegate inherit from ContextClient"
This reverts commit 1635e4188721fac9f7fc250cc0af6a2c5bb50068.
Reason for revert: Caused crbug.com/786865
Original change's description:
> Make V8IntersectionObserverDelegate inherit from ContextClient
>
> We should use ContextClient instead of storing ScriptState because
> ContextClient can check whether the context is destroyed.
>
> [email protected]
>
> (cherry picked from commit ae782ad1a7f98241859666d94c91668f73e0e598)
>
> Bug: 785553
> Change-Id: Icf85fb6c3f97c9a50f85de812b812999669b96f5
> Reviewed-on: https://chromium-review.googlesource.com/776136
> Reviewed-by: Kentaro Hara <[email protected]>
> Reviewed-by: Yuki Shiino <[email protected]>
> Commit-Queue: Kenichi Ishibashi <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#517318}
> Reviewed-on: https://chromium-review.googlesource.com/778499
> Reviewed-by: Kenichi Ishibashi <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#537}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected],[email protected]
Change-Id: I10bb926d4b9840210ddbc4e24673d74ce8a500bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785553
Reviewed-on: https://chromium-review.googlesource.com/778702
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#539}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.58
[email protected]
Change-Id: I82cb6dbf0131cda268346b38ee8db0f8ad2888ef
Reviewed-on: https://chromium-review.googlesource.com/777931
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#538}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Make V8IntersectionObserverDelegate inherit from ContextClient
We should use ContextClient instead of storing ScriptState because
ContextClient can check whether the context is destroyed.
[email protected]
(cherry picked from commit ae782ad1a7f98241859666d94c91668f73e0e598)
Bug: 785553
Change-Id: Icf85fb6c3f97c9a50f85de812b812999669b96f5
Reviewed-on: https://chromium-review.googlesource.com/776136
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#517318}
Reviewed-on: https://chromium-review.googlesource.com/778499
Reviewed-by: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#537}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.57
[email protected]
Change-Id: I60aa06f2a3f7bb5652d6041f934a24f8afcdd1bc
Reviewed-on: https://chromium-review.googlesource.com/778142
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#536}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.56
[email protected]
Change-Id: I724b127a7ccbf6cc2a86e317232fcf5fe5d6ec44
Reviewed-on: https://chromium-review.googlesource.com/777901
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#535}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix bug where notification for paused download persists.
There was a bug where the notification for a paused offline page would
persist even after swiped away. This is because in some cases, the
foreground download notification service is restarted after the download
was paused but it does not get shut down again so downloads remains in
the foreground. This CL fixes this by putting in a check that will check
to stop the service if it is accidentally restarted.
Bug: 784602
Change-Id: Ic521fe39db62b3a0028ac3bed788f521cf0dcb44
Reviewed-on: https://chromium-review.googlesource.com/769869
Commit-Queue: Joy Ming <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516853}(cherry picked from commit 16b84d67c1349f534233cecefc332cf94387542a)
Reviewed-on: https://chromium-review.googlesource.com/777405
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#534}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "[M63] Make change password card resilient to refresh"
This is a reland of 1e61583b12eba1af8d814f1324a9a4eaf982dbd9
Original change's description:
> [M63] Make change password card resilient to refresh
>
> This is a follow-up of https://chromium-review.googlesource.com/753986.
> As a result of 753986, already-opened chrome://settings page will show
> change password card upon protected GAIA password reuse events. However
> if user refreshes the chrome://settings page, change password card
> disappears.
> To fix this issue, we need to make 'showChangePassword' value adapt to
> ChromePasswordProtectionService::ShouldShowChangePasswordSettingUI(..)
>
> This CL also refactors ChangePasswordHandler extensively that removes
> lots of unnecessary code.
>
> [email protected]
>
> (cherry picked from commit c6eaff36eaa33df728276c748e8a6a60f5c8a4da)
>
> Bug: 765740
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I3078fc74f71fd2e1fea14eb020ddd77e611c05d1
> Reviewed-on: https://chromium-review.googlesource.com/758971
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Luke Z <[email protected]>
> Commit-Queue: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#515762}
> Reviewed-on: https://chromium-review.googlesource.com/769338
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#491}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
Bug: 765740
Change-Id: Ic7ae460da84916ae26b2f6dd385a34d25cee97fb
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/777800
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#533}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Define toolbar button height and width in-line instead of in styles.xml
Define the layout_height and layout_width for ToolbarButton elements
in-line rather than in styles.xml. This is a speculative fix for crash
reports we've received indicating these attributes are missing.
BUG=779271
[email protected]
Change-Id: I732ee9b39262aa8bfbc74dea57ea72469cd9e647
Reviewed-on: https://chromium-review.googlesource.com/764378
Commit-Queue: Theresa <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515966}
Reviewed-on: https://chromium-review.googlesource.com/777766
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#532}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Allow the Chrome Home promo to be disabled on startup with finch
Since showing the promo at startup is the current behavior, this feature
is enabled by default. The feature to disable is
"ChromeHomePromoOnStartup".
BUG=783936
Change-Id: I827f7a828a484603860e3ce8362e91b50a6d742a
Reviewed-on: https://chromium-review.googlesource.com/764788
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515798}(cherry picked from commit 862d24329cf7d5365aca1976ebd179b5a0cd1bba)
Reviewed-on: https://chromium-review.googlesource.com/777799
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#531}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "[M63] Show change password card on already opened chrome://settings page"
This is a reland of bd6f97797c493b54343b75567bfa2bf3bdde353e
Original change's description:
> [M63] Show change password card on already opened chrome://settings page
>
> If user has chrome://settings already opened in some tabs, and
> encountered a password reuse warning, the change password setting
> card should show on these already opened chrome://settings page
> as soon as the password reuse modal warning is shown.
>
> Other fixes include: (1) exit fullscreen when warning is shown;
> (2) add js tests in
> chrome/test/data/webui/settings/change_password_page_test.js
> (3) minor refactoring in PasswordProtectionService.
>
> [email protected]
>
> (cherry picked from commit fecb7543cd8c2a2ec0b39ff2eca8f3ab9717e44d)
>
> Bug: 765740,773537
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I4372b6448cc5a612a9866b1f94692eeb0cfd56e7
> Reviewed-on: https://chromium-review.googlesource.com/753986
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Raymes Khoury <[email protected]>
> Reviewed-by: Nathan Parker <[email protected]>
> Commit-Queue: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514530}
> Reviewed-on: https://chromium-review.googlesource.com/769436
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#490}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
Bug: 765740, 773537
Change-Id: I42e6024fe8aa80a7aa5e598dddadbb7dd8b1250e
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/777159
Reviewed-by: Jialiu Lin (Low reply Nov 15-16) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#530}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "Fix egtests for the new iOS bookmarks flag."
This is a reland of 520cfd67bddc251af883f8affe9eeac3e8a71703
The original CL was reverted because the dep path ntp:modal_ntp doesn't exist.
In 3239 build, modal_ntp.mm was still inside ntp:internal_ntp
(instead of ntp:modal_ntp in master branch).
Patchset 2 corrects this mistakes.
Original change's description:
> Fix egtests for the new iOS bookmarks flag.
>
> After crrev.com/c/757887, there are still some broken egtests when new
> iOS bookmarks feature flag is enabled (some only broken on iPad iOS 11).
> This CL fixes them or adds scoped feature list to them so that they will
> not break for the new iOS bookmarks.
>
> [email protected]
>
> (cherry picked from commit 79151652bb5741cf335ecb27a9d3dee110360f37)
>
> Bug: 782127
> Change-Id: Ic830fdc8d096c22a953bd13eb1c47446ac88c4c8
> Reviewed-on: https://chromium-review.googlesource.com/765407
> Commit-Queue: Sylvain Defresne <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Reviewed-by: Gauthier Ambard <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#516255}
> Reviewed-on: https://chromium-review.googlesource.com/773904
> Reviewed-by: Marti Wong <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#519}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
Bug: 782127
Change-Id: Id64c6ce507ac4bef84d3d79b7381767424d47a1e
Reviewed-on: https://chromium-review.googlesource.com/776275
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#529}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Child accounts] Don't start reauth before auth status is known
If GaiaCookieManagerService doesn't have an account list yet,
it will return false from ListAccounts.
ChildAccountService::IsGoogleAuthenticated considered this as "Not
authenticated" case, and SupervisedUserGoogleAuthNavigationThrottle
would trigger a reauth flow.
This CL fixes this issue by changing IsGoogleAuthenticated return type
to enum and adding a AUTH_STATUS_PENDING there.
(cherry picked from commit b0c3aaadcd7b0b544b5614efdf429be747eca68c)
Bug: b/67870456
Change-Id: I48a03d4e9434b131dd574efb90beb47a5afd2246
Reviewed-on: https://chromium-review.googlesource.com/758399
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515154}
Reviewed-on: https://chromium-review.googlesource.com/775564
Cr-Commit-Position: refs/branch-heads/3239@{#528}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Fix egtests for the new iOS bookmarks flag."
This reverts commit 520cfd67bddc251af883f8affe9eeac3e8a71703.
Reason for revert: Breaking the Beta build. See crbug.com/786302
Original change's description:
> Fix egtests for the new iOS bookmarks flag.
>
> After crrev.com/c/757887, there are still some broken egtests when new
> iOS bookmarks feature flag is enabled (some only broken on iPad iOS 11).
> This CL fixes them or adds scoped feature list to them so that they will
> not break for the new iOS bookmarks.
>
> [email protected]
>
> (cherry picked from commit 79151652bb5741cf335ecb27a9d3dee110360f37)
>
> Bug: 782127
> Change-Id: Ic830fdc8d096c22a953bd13eb1c47446ac88c4c8
> Reviewed-on: https://chromium-review.googlesource.com/765407
> Commit-Queue: Sylvain Defresne <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Reviewed-by: Gauthier Ambard <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#516255}
> Reviewed-on: https://chromium-review.googlesource.com/773904
> Reviewed-by: Marti Wong <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#519}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 782127
Change-Id: I2a3de2de48d52b1200ee04fe37ff106d4406c7e0
Reviewed-on: https://chromium-review.googlesource.com/776693
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#527}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix notification focus painter related bugs.
This CL fixes these focus painter related bugs of notification:
- Focus painter for the expand button was not rendered correctly.
(https://crbug.com/778208)
- Expand button wasn't rendered initially, because
NotificationHeaderView::Layout() wasn't called after
NotificationHeaderView::SetExpandButtonEnabled() update.
- Focus painter for the entire notification was not rendered correctly,
due to recent shadow removal (https://crrev.com/c/722303).
Related bug: https://crrev.com/c/737690
TEST=manual
BUG=778208
(cherry picked from commit 45c31c31b68a759fde3f2693ea27a23060979938)
Change-Id: Ieeeb3a8b4bf3df0fda32b7c237ba78d942ab6b5a
Reviewed-on: https://chromium-review.googlesource.com/737503
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512093}
Reviewed-on: https://chromium-review.googlesource.com/776474
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#526}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Register accelerators at accelerator controller
- Register accelerators at global accelerator manager (accelerator
controller) to make them work while system tray is open.
- Close system tray when status area becomes invisible.
Confirm that reset screen is shown.
Bug: 774425
Test: Open system tray at login screen, and press Ctrl+Alt+Shift+R.
Change-Id: I642a6ceee04b721427c9ee7116c78e0f2163b40d
Reviewed-on: https://chromium-review.googlesource.com/754253
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516618}(cherry picked from commit 633edfecac687f0d04a0544c15811d9746c7c545)
Reviewed-on: https://chromium-review.googlesource.com/776473
Reviewed-by: Yuki Awano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#525}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.55
[email protected]
Change-Id: Ib3dcd6de15eb17fa677e4a6c5ef133bb546c5851
Reviewed-on: https://chromium-review.googlesource.com/775977
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#524}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix omnibox popup suggestions on rotation on iOS 11.
It seems like on iOS 11 the autoresize masks don't work well when the
device is rotated. Since suggestions rows don't really need the mask
since the frame of each view is exactly calculated and set every time it
changes the size, remove the use of autoresize masks.
including long and short suggestions, answers; specifically verify that
text is not clipped in unexpected ways even when rotating to landscape
and back.
[email protected]
(cherry picked from commit badd7614cd1878f75f55a8c1b6d9530b8994e46f)
Bug: 768374
Test: Please test by displaying all possible suggestions in omnibox,
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia00b60187b3d99e7e09dcd82d107c6a809492316
Reviewed-on: https://chromium-review.googlesource.com/760937
Commit-Queue: Stepan Khapugin <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516313}
Reviewed-on: https://chromium-review.googlesource.com/775936
Cr-Commit-Position: refs/branch-heads/3239@{#523}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Avoid null Node pointers in theme painting code
M-63 Merge.
A recent change to reduce the dependence of theme
code on layout objects changed painting code to take Node
objects instead of LayoutObjects. However, Node can be null
for anonymous layout objects, and the theme code crashes
when accessing this null node in numerous places.
As part of this patch, all of the uses of Node in the theme
painting code were audited to identify potential null accesses.
The sites affected have been changed to either check for null
or take a Document as an argument to avoid the node access.
TBR=[email protected]
BUG=782817,779377
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I409ea5f16f462d959cf2864b7019ca9ca0bf22c2
Reviewed-on: https://chromium-review.googlesource.com/764447
Reviewed-by: Emil A Eklund <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516175}(cherry picked from commit a1c0004ec1034fa715ded22620f3b7c7b3cef6d1)
Reviewed-on: https://chromium-review.googlesource.com/775001
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#522}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix disappearing omnibox on iPhone X.
The old-school layout logic in BVC was also re-inserting views on each
update, which is unnecessary, and in some cases causes views to show up
in the wrong z-order. Insert only needs to happen on initial layout,
so gating this in a flag should fix the issues.
[email protected]
(cherry picked from commit 4eeada3f3c8fd1c6dcfa200f82637657346a3192)
Bug: 782373
Change-Id: I326f3b9199717c0ad014267fa0239581574a826d
Reviewed-on: https://chromium-review.googlesource.com/763711
Reviewed-by: Stepan Khapugin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515987}
Reviewed-on: https://chromium-review.googlesource.com/775148
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#521}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Enable the new bookmarks UI feature flag by default on iOS.
Bug: 782127
Change-Id: Id683ed53061f2a34a73e5af96cb307c9b73d3069
Reviewed-on: https://chromium-review.googlesource.com/768509
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Marti Wong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516270}(cherry picked from commit 9c2479e93f38ea55c3e8233d314088de55e91678)
Reviewed-on: https://chromium-review.googlesource.com/773860
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#520}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix egtests for the new iOS bookmarks flag.
After crrev.com/c/757887, there are still some broken egtests when new
iOS bookmarks feature flag is enabled (some only broken on iPad iOS 11).
This CL fixes them or adds scoped feature list to them so that they will
not break for the new iOS bookmarks.
[email protected]
(cherry picked from commit 79151652bb5741cf335ecb27a9d3dee110360f37)
Bug: 782127
Change-Id: Ic830fdc8d096c22a953bd13eb1c47446ac88c4c8
Reviewed-on: https://chromium-review.googlesource.com/765407
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516255}
Reviewed-on: https://chromium-review.googlesource.com/773904
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#519}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Modify egtests, unittests for the new iOS bookmarks flag.
Add the feature flag checks and scoped feature list to unittests and
egtests so that they will not break when the new iOS bookmarks feature
flag is enabled.
[email protected]
(cherry picked from commit 9405c0477fec7b14e2a933d0445201d540d45f55)
Bug: 782127
Change-Id: Ia9ae01911c1c9da5d5a92991528d16ea3d550465
Reviewed-on: https://chromium-review.googlesource.com/757887
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Marti Wong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515540}
Reviewed-on: https://chromium-review.googlesource.com/773901
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#518}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Default-disable Smart Selection in Chrome.
Switches the default for Smart Selection in Chrome for Android.
Replaces the CS disable param with an enable Feature.
Update the fieldtrial_testing_config to enable the Feature.
BUG=783932, 756241
[email protected]
(cherry picked from commit f3222a271b4acd39847a04eafe41f9ee3b874265)
Change-Id: I4853943871f320c306fed99ec2d4883af7551ae3
Reviewed-on: https://chromium-review.googlesource.com/706644
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516426}
Reviewed-on: https://chromium-review.googlesource.com/773634
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#517}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Smart Selection] Require O_MR1 to enable.
Updates the check of the Android version to require
O_MR1 or later in order to enable Smart Text Selection.
BUG=785033
[email protected]
(cherry picked from commit 0c23e036775e0d1cca1fe7ff06156050b386384b)
Change-Id: Ic69d8baf719728d90e12d9b95adf223351845b77
Reviewed-on: https://chromium-review.googlesource.com/770303
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516748}
Reviewed-on: https://chromium-review.googlesource.com/773782
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#516}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.54
[email protected]
Change-Id: I8c9ade5d19a79566b6b629f9eb8abf932f098f2e
Reviewed-on: https://chromium-review.googlesource.com/773798
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#515}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "Fix the incorrect accessibility type issue (new iOS bookmarks)"
This is a reland of 50c6b97dcfe32b3a699d9e9303e3c5f7e40203b9
This CL was reverted (Patchset1) because the line [super setSelected...]
was missing and caused crbug.com/785289). Patchset 2 added back that
missing line.
Original change's description:
> Fix the incorrect accessibility type issue (new iOS bookmarks)
>
> Override the accessibility methods in bookmark_table_cell so that we can
> hide the title textField from UIAccessibility when it is not being
> edited.
>
> [email protected]
>
> (cherry picked from commit 5213e481438d7d9a058cf49d17542c295e0733d0)
>
> Bug: 781213
> Change-Id: I6f35c6ad8a060f09a8dfc5576123f89bc9ffa114
> Reviewed-on: https://chromium-review.googlesource.com/754466
> Commit-Queue: Sylvain Defresne <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514783}
> Reviewed-on: https://chromium-review.googlesource.com/765559
> Reviewed-by: Marti Wong <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#456}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
Bug: 781213
Change-Id: I2ce9cc481e3bd36d68e4dd391248cab6fbdc0cee
Reviewed-on: https://chromium-review.googlesource.com/773698
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#514}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "[TTS] Update last assert in CSearchTabHelper"
This is a reland of aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2
Original change's description:
> [TTS] Update last assert in CSearchTabHelper
>
> Speculative fix for an assert reported by a developer.
> Update an overly aggressive assert recently landed in
> ContextualSearchTabHelper when reparenting.
>
> BUG=783225, 775813
> [email protected]
>
> (cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205)
>
> Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420
> Reviewed-on: https://chromium-review.googlesource.com/764667
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Donn Denman <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#515755}
> Reviewed-on: https://chromium-review.googlesource.com/769244
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#488}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
Bug: 783225, 775813
Change-Id: I975ba6ef5f3ded9ecd543da801bfd76a52189f35
Reviewed-on: https://chromium-review.googlesource.com/773439
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#513}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "[TTS] Update an assert in CSearchTabHelper"
This is a reland of 7b96ffcedaa9339381fe8189b92baf257970ee39
Original change's description:
> [TTS] Update an assert in CSearchTabHelper
>
> Update an overly aggressive assert recently landed in
> ContextualSearchTabHelper when reparenting. This is causing an
> existing test to be very flaky (NewTabPageTest#testRender).
>
> BUG=775813, 778540, 782324
> [email protected]
>
> (cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449)
>
> Change-Id: I041742701820dc3899378515fe37a6be44a66d7a
> Reviewed-on: https://chromium-review.googlesource.com/757661
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Donn Denman <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514651}
> Reviewed-on: https://chromium-review.googlesource.com/769297
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#487}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
Bug: 775813, 778540, 782324
Change-Id: I29a275528f74d83395d5103a8d4fb1346010cf70
Reviewed-on: https://chromium-review.googlesource.com/773638
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#512}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Fix the incorrect accessibility type issue (new iOS bookmarks)"
This reverts commit 50c6b97dcfe32b3a699d9e9303e3c5f7e40203b9.
Reason for revert: The line [super setSelected...] is missing which caused crbug.com/785289.
Original change's description:
> Fix the incorrect accessibility type issue (new iOS bookmarks)
>
> Override the accessibility methods in bookmark_table_cell so that we can
> hide the title textField from UIAccessibility when it is not being
> edited.
>
> [email protected]
>
> (cherry picked from commit 5213e481438d7d9a058cf49d17542c295e0733d0)
>
> Bug: 781213
> Change-Id: I6f35c6ad8a060f09a8dfc5576123f89bc9ffa114
> Reviewed-on: https://chromium-review.googlesource.com/754466
> Commit-Queue: Sylvain Defresne <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514783}
> Reviewed-on: https://chromium-review.googlesource.com/765559
> Reviewed-by: Marti Wong <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#456}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 781213
Change-Id: I1f90f7725565172885622ba5ed8e98154dfa6329
Reviewed-on: https://chromium-review.googlesource.com/773518
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#511}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add MultiWindowTestHelper missed from commit 509
The MultiWindowTestHelper.java file was missed from our manual
commit on branch 3239#509 because it was a new file and we forgot
to add it to the commit.
[email protected],[email protected]
Bug:
Change-Id: I39f39c283c679d84db51b2ecc731fde841d8bdd6
Reviewed-on: https://chromium-review.googlesource.com/773284
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#510}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[TTS] Fix reparenting and add Test case.
Updates ContextualSearchTabHelper to handle reparenting correctly,
and improve usage of the mTab member to make that usage more explicit.
Adds a new TabObserver method onActivityAttachmentChanged to notify Tabs
when they've been attached or detached from an Activity.
Also refactor mulitwindow test utility methods into a separate utility
class: MultiWindowTestUtils.java, based mostly on static functions
from MultiWindowUtilsTest.java.
BUG=775813, 778540
[email protected]
Change-Id: I2437295ede41189d394c82fb64f7ea5c547c4b96
Reviewed-on: https://chromium-review.googlesource.com/772868
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#509}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}cros Add metric to record folder usage
We want to know how many folders users have. This will
inform upcoming decisions on whether we should do the folder
re-design.
[email protected]
(cherry picked from commit 85be3fca51df9b2ae9cb0b2027aab4b44f1fa98d)
Bug: 780107
Change-Id: Ifc2c77b403b0eab1d156c81f8e628e6417808893
Reviewed-on: https://chromium-review.googlesource.com/752683
Reviewed-by: Yury Khmel <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515189}
Reviewed-on: https://chromium-review.googlesource.com/772866
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#508}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}cros fix incorrect UMA Histogram recording
In the launcher, suggested apps and search results share a class,
SearchResultTileItemView.
The code path for launching a suggested app and a SearchResult is the
same,and we were recording SuggestedApp clicks as SearchResult clicks.
This CL modifies the code path to consider if the
SearchResultTileItemView is a suggested app before recording metrics.
I also included a UMA test in AppsGridViewTest.
[email protected]
(cherry picked from commit c7b6f2a93417a42bfe042662a540b63df25dcf29)
Bug: 779654
Change-Id: Ia059879c097b5845021bb9ed4050da51e70ac007
Reviewed-on: https://chromium-review.googlesource.com/751961
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515066}
Reviewed-on: https://chromium-review.googlesource.com/773098
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#507}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}mojoVEA: explicit Binding lifetime mgmt
MojoVEA creates a VideoEncodeAcceleratorClient and puts it into
a StrongBinding, sending the other end of the pipe to the remote
mojo VideoEncodeAccelerator. This causes a race between the former
and the latter going down. This CL addresses this issue by removing
the StrongBinding, holding on to the internal VEAClient and moving
the Binding explicitly to VideoEncodeAcceleratorClient.
[email protected]
(cherry picked from commit 4d63c67a45457992807ec0934c347330b1bcc76d)
Bug: 781560
Change-Id: Id674b30a9403fa08de42c3036d56df28a5f43c51
Reviewed-on: https://chromium-review.googlesource.com/767349
Reviewed-by: Yuzhu Shen <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516274}
Reviewed-on: https://chromium-review.googlesource.com/773018
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#506}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Handle onSetText() correctly for spannable inline autocomplete
We use setText() to apply the omnibox suggestion or any other externally
driven changes to the AutocompleteEditText.
In doing so, we need to reset internal states correctly.
BUG=783165
(cherry picked from commit 15ba99bfb8e30ea7d0b3b897cce43b76bd88bdc0)
Change-Id: I135ff29985dcdfdd32ba841b657b2f81955eab12
Reviewed-on: https://chromium-review.googlesource.com/769433
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516453}
Reviewed-on: https://chromium-review.googlesource.com/772827
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#505}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63]Check current ViewModel of ShelfView before clear the state of ShelfButton.
[email protected]
Changes,
1. Scale up the app only for mouse left click.
2. Call PointerReleasedOnButton at the end of ShelfButton::OnMouseReleased
to avoid crash.
(cherry picked from commit 580196e11f8b76dcd1493cc3da23aaf6f4c68aa4)
Bug: 780092
Change-Id: Ibe581f61ed36d31cd5a327a595f1e343ff7379c7
Reviewed-on: https://chromium-review.googlesource.com/753433
Commit-Queue: min c <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514590}
Reviewed-on: https://chromium-review.googlesource.com/772841
Reviewed-by: min c <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#504}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android O] Clear notification permission from PrefProvider on Reset
- Previously when users on O pressed the 'Clear and Reset' button to
clear notification settings for a site, the permission could remain
granted if it was granted on an older version of the browser, due to
a bug in the migration of settings to notification channels.
- This was because settings were never deleted from the PrefProvider
either during the migration process or on clearing notification
permission for a site.
- Now we return false from NCPA::SetWebsiteSetting when clearing
permission.
- This means the HostContentSettingsMap continues to iterate through the
content setting providers and clears the permission from the PrefProvider
too if present.
Bug: 781524
Change-Id: I883ee6ab0b70873c4157b545aeac3691bfb8a23f
Reviewed-on: https://chromium-review.googlesource.com/758687
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Anita Woodruff <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515532}(cherry picked from commit 3ecbacc4b37d37a19b2f1ece0bd72e983f836d26)
Reviewed-on: https://chromium-review.googlesource.com/771750
Reviewed-by: Anita Woodruff <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#503}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android] Restricting Smart Go Next only in Android
Current implementation of Smart Go Next will execute for
all platforms because of calculation logic touches blink.
Now restricting this logic only in Android platform. Due to
a regression in blink wrt element focus time, currently applying
a threshold of focus calculation.
[email protected]
(cherry picked from commit 9e7b5573604b73de075c1c7a86ae9b26b871a96b)
Bug: 781026
Change-Id: I96c60e15186bddae087345f2d5b25a359dd4ac48
Reviewed-on: https://chromium-review.googlesource.com/758481
Commit-Queue: Takayoshi Kochi <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Takayoshi Kochi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#516124}
Reviewed-on: https://chromium-review.googlesource.com/770914
Cr-Commit-Position: refs/branch-heads/3239@{#502}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Change Picture: Prevent new photo capture while capture is in progress
This prevents double-clicks on capture button from causing bad
behavior.
[email protected]
(cherry picked from commit d313402700cf122830699f78bf4926ed27eef78d)
Bug: 781160
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I976391a94741b95911fab412981a40f7e4de0696
Reviewed-on: https://chromium-review.googlesource.com/753404
Commit-Queue: David Reveman <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514359}
Reviewed-on: https://chromium-review.googlesource.com/770530
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#501}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.53
[email protected]
Change-Id: I531f884287eac5487dda5f73709cee03c72392c0
Reviewed-on: https://chromium-review.googlesource.com/770390
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#500}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Use application Context for apply in RemoteViews
Due to a support library bug, when we use Activity context while
inflating RemoteViews, if the layout contains any ImageViewCompat
there is an exception thrown. This uses the application context to avoid
the exception.
BUG=783834
Change-Id: Id205dfcef98e6e3341ba0a50d9859c815d9b69df
Reviewed-on: https://chromium-review.googlesource.com/763589
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515627}(cherry picked from commit f98f7477add854fc6344c33554b248c3392f8f27)
Reviewed-on: https://chromium-review.googlesource.com/770231
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#499}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[TTS] Fix reparenting and add Test case."
This reverts commit b13aa7d5546218642af08fcc8c7395cf6fffa496.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [TTS] Fix reparenting and add Test case.
>
> Updates ContextualSearchTabHelper to handle reparenting correctly,
> and improve usage of the mTab member to make that usage more explicit.
>
> Adds a new TabObserver method onActivityAttachmentChanged to notify Tabs
> when they've been attached or detached from an Activity.
>
> Also refactor mulitwindow test utility methods into a separate utility
> class: MultiWindowTestUtils.java, based mostly on static functions
> from MultiWindowUtilsTest.java.
>
> BUG=775813, 778540
> [email protected]
>
> (cherry picked from commit 17a017076099eb8558dfc8081b1a7cbdbc52bf32)
>
> Change-Id: I460bc3a91494f52aceb77c4880105caadb5c354d
> Reviewed-on: https://chromium-review.googlesource.com/738923
> Commit-Queue: Donn Denman <[email protected]>
> Reviewed-by: Ted Choc <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514328}
> Reviewed-on: https://chromium-review.googlesource.com/769242
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#486}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: Ie94dffa98c72d0ebeecf1e6d0c59f5179f9be5f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775813, 778540
Reviewed-on: https://chromium-review.googlesource.com/770110
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#498}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[TTS] Update an assert in CSearchTabHelper"
This reverts commit 7b96ffcedaa9339381fe8189b92baf257970ee39.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [TTS] Update an assert in CSearchTabHelper
>
> Update an overly aggressive assert recently landed in
> ContextualSearchTabHelper when reparenting. This is causing an
> existing test to be very flaky (NewTabPageTest#testRender).
>
> BUG=775813, 778540, 782324
> [email protected]
>
> (cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449)
>
> Change-Id: I041742701820dc3899378515fe37a6be44a66d7a
> Reviewed-on: https://chromium-review.googlesource.com/757661
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Donn Denman <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514651}
> Reviewed-on: https://chromium-review.googlesource.com/769297
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#487}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: I1cff30dc13f2eb8182e698f249078583dbe513b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775813, 778540, 782324
Reviewed-on: https://chromium-review.googlesource.com/770070
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#497}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[TTS] Update last assert in CSearchTabHelper"
This reverts commit aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [TTS] Update last assert in CSearchTabHelper
>
> Speculative fix for an assert reported by a developer.
> Update an overly aggressive assert recently landed in
> ContextualSearchTabHelper when reparenting.
>
> BUG=783225, 775813
> [email protected]
>
> (cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205)
>
> Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420
> Reviewed-on: https://chromium-review.googlesource.com/764667
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Donn Denman <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#515755}
> Reviewed-on: https://chromium-review.googlesource.com/769244
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#488}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: I6d3881b5814c5778e001de9a6d9ba0fffccaff94
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783225, 775813
Reviewed-on: https://chromium-review.googlesource.com/770030
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#496}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
