Publish DEPS for Chromium 63.0.3239.53
Incrementing VERSION to 63.0.3239.53
[email protected]
Change-Id: I531f884287eac5487dda5f73709cee03c72392c0
Reviewed-on: https://chromium-review.googlesource.com/770390
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#500}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Use application Context for apply in RemoteViews
Due to a support library bug, when we use Activity context while
inflating RemoteViews, if the layout contains any ImageViewCompat
there is an exception thrown. This uses the application context to avoid
the exception.
BUG=783834
Change-Id: Id205dfcef98e6e3341ba0a50d9859c815d9b69df
Reviewed-on: https://chromium-review.googlesource.com/763589
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515627}(cherry picked from commit f98f7477add854fc6344c33554b248c3392f8f27)
Reviewed-on: https://chromium-review.googlesource.com/770231
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#499}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[TTS] Fix reparenting and add Test case."
This reverts commit b13aa7d5546218642af08fcc8c7395cf6fffa496.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [TTS] Fix reparenting and add Test case.
>
> Updates ContextualSearchTabHelper to handle reparenting correctly,
> and improve usage of the mTab member to make that usage more explicit.
>
> Adds a new TabObserver method onActivityAttachmentChanged to notify Tabs
> when they've been attached or detached from an Activity.
>
> Also refactor mulitwindow test utility methods into a separate utility
> class: MultiWindowTestUtils.java, based mostly on static functions
> from MultiWindowUtilsTest.java.
>
> BUG=775813, 778540
> [email protected]
>
> (cherry picked from commit 17a017076099eb8558dfc8081b1a7cbdbc52bf32)
>
> Change-Id: I460bc3a91494f52aceb77c4880105caadb5c354d
> Reviewed-on: https://chromium-review.googlesource.com/738923
> Commit-Queue: Donn Denman <[email protected]>
> Reviewed-by: Ted Choc <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514328}
> Reviewed-on: https://chromium-review.googlesource.com/769242
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#486}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: Ie94dffa98c72d0ebeecf1e6d0c59f5179f9be5f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775813, 778540
Reviewed-on: https://chromium-review.googlesource.com/770110
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#498}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[TTS] Update an assert in CSearchTabHelper"
This reverts commit 7b96ffcedaa9339381fe8189b92baf257970ee39.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [TTS] Update an assert in CSearchTabHelper
>
> Update an overly aggressive assert recently landed in
> ContextualSearchTabHelper when reparenting. This is causing an
> existing test to be very flaky (NewTabPageTest#testRender).
>
> BUG=775813, 778540, 782324
> [email protected]
>
> (cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449)
>
> Change-Id: I041742701820dc3899378515fe37a6be44a66d7a
> Reviewed-on: https://chromium-review.googlesource.com/757661
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Donn Denman <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514651}
> Reviewed-on: https://chromium-review.googlesource.com/769297
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#487}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: I1cff30dc13f2eb8182e698f249078583dbe513b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775813, 778540, 782324
Reviewed-on: https://chromium-review.googlesource.com/770070
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#497}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[TTS] Update last assert in CSearchTabHelper"
This reverts commit aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [TTS] Update last assert in CSearchTabHelper
>
> Speculative fix for an assert reported by a developer.
> Update an overly aggressive assert recently landed in
> ContextualSearchTabHelper when reparenting.
>
> BUG=783225, 775813
> [email protected]
>
> (cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205)
>
> Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420
> Reviewed-on: https://chromium-review.googlesource.com/764667
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Donn Denman <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#515755}
> Reviewed-on: https://chromium-review.googlesource.com/769244
> Reviewed-by: Donn Denman <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#488}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: I6d3881b5814c5778e001de9a6d9ba0fffccaff94
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783225, 775813
Reviewed-on: https://chromium-review.googlesource.com/770030
Reviewed-by: Claude Masso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#496}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.52
[email protected]
Change-Id: I3607dce89a69a9fec0b139430418b7d9e7791de6
Reviewed-on: https://chromium-review.googlesource.com/769729
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#495}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[M63] Show change password card on already opened chrome://settings page"
This reverts commit bd6f97797c493b54343b75567bfa2bf3bdde353e.
Reason for revert: Breaking builds
Original change's description:
> [M63] Show change password card on already opened chrome://settings page
>
> If user has chrome://settings already opened in some tabs, and
> encountered a password reuse warning, the change password setting
> card should show on these already opened chrome://settings page
> as soon as the password reuse modal warning is shown.
>
> Other fixes include: (1) exit fullscreen when warning is shown;
> (2) add js tests in
> chrome/test/data/webui/settings/change_password_page_test.js
> (3) minor refactoring in PasswordProtectionService.
>
> [email protected]
>
> (cherry picked from commit fecb7543cd8c2a2ec0b39ff2eca8f3ab9717e44d)
>
> Bug: 765740,773537
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I4372b6448cc5a612a9866b1f94692eeb0cfd56e7
> Reviewed-on: https://chromium-review.googlesource.com/753986
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Raymes Khoury <[email protected]>
> Reviewed-by: Nathan Parker <[email protected]>
> Commit-Queue: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#514530}
> Reviewed-on: https://chromium-review.googlesource.com/769436
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#490}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected],[email protected]
Change-Id: Iad9f8a53a184c9fa670e482189393f996988c072
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 765740, 773537
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/769687
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#494}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[M63] Make change password card resilient to refresh"
This reverts commit 1e61583b12eba1af8d814f1324a9a4eaf982dbd9.
Reason for revert: Breaking builds
Original change's description:
> [M63] Make change password card resilient to refresh
>
> This is a follow-up of https://chromium-review.googlesource.com/753986.
> As a result of 753986, already-opened chrome://settings page will show
> change password card upon protected GAIA password reuse events. However
> if user refreshes the chrome://settings page, change password card
> disappears.
> To fix this issue, we need to make 'showChangePassword' value adapt to
> ChromePasswordProtectionService::ShouldShowChangePasswordSettingUI(..)
>
> This CL also refactors ChangePasswordHandler extensively that removes
> lots of unnecessary code.
>
> [email protected]
>
> (cherry picked from commit c6eaff36eaa33df728276c748e8a6a60f5c8a4da)
>
> Bug: 765740
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I3078fc74f71fd2e1fea14eb020ddd77e611c05d1
> Reviewed-on: https://chromium-review.googlesource.com/758971
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Luke Z <[email protected]>
> Commit-Queue: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#515762}
> Reviewed-on: https://chromium-review.googlesource.com/769338
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#491}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected],[email protected]
Change-Id: I81e766c2d954a366245fbbd83b59db709ae7162d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 765740
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/769667
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#493}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.51
[email protected]
Change-Id: Ie0f0be44d9a4c3cd0c9a665e999e9cacccc516e4
Reviewed-on: https://chromium-review.googlesource.com/769411
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#492}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63] Make change password card resilient to refresh
This is a follow-up of https://chromium-review.googlesource.com/753986.
As a result of 753986, already-opened chrome://settings page will show
change password card upon protected GAIA password reuse events. However
if user refreshes the chrome://settings page, change password card
disappears.
To fix this issue, we need to make 'showChangePassword' value adapt to
ChromePasswordProtectionService::ShouldShowChangePasswordSettingUI(..)
This CL also refactors ChangePasswordHandler extensively that removes
lots of unnecessary code.
[email protected]
(cherry picked from commit c6eaff36eaa33df728276c748e8a6a60f5c8a4da)
Bug: 765740
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3078fc74f71fd2e1fea14eb020ddd77e611c05d1
Reviewed-on: https://chromium-review.googlesource.com/758971
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Luke Z <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515762}
Reviewed-on: https://chromium-review.googlesource.com/769338
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#491}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63] Show change password card on already opened chrome://settings page
If user has chrome://settings already opened in some tabs, and
encountered a password reuse warning, the change password setting
card should show on these already opened chrome://settings page
as soon as the password reuse modal warning is shown.
Other fixes include: (1) exit fullscreen when warning is shown;
(2) add js tests in
chrome/test/data/webui/settings/change_password_page_test.js
(3) minor refactoring in PasswordProtectionService.
[email protected]
(cherry picked from commit fecb7543cd8c2a2ec0b39ff2eca8f3ab9717e44d)
Bug: 765740,773537
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4372b6448cc5a612a9866b1f94692eeb0cfd56e7
Reviewed-on: https://chromium-review.googlesource.com/753986
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Nathan Parker <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514530}
Reviewed-on: https://chromium-review.googlesource.com/769436
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#490}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Avoid stack allocations for PaintPropertyTreeBuilderFragmentContext.
The stack allocation is just to initialize the object and stick it
into a heap-allocated vector entry. Instead allocate the entry
and initialize it on the heap.
[email protected]
(cherry picked from commit 5bfb9b4d284290365e505d25767c793ed58a38a6)
Bug: 781301
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I58af3fdc18d19950d7f8911910ee33d1b0d445af
Reviewed-on: https://chromium-review.googlesource.com/764405
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515751}
Reviewed-on: https://chromium-review.googlesource.com/769301
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#489}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[TTS] Update last assert in CSearchTabHelper
Speculative fix for an assert reported by a developer.
Update an overly aggressive assert recently landed in
ContextualSearchTabHelper when reparenting.
BUG=783225, 775813
[email protected]
(cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205)
Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420
Reviewed-on: https://chromium-review.googlesource.com/764667
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515755}
Reviewed-on: https://chromium-review.googlesource.com/769244
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#488}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[TTS] Update an assert in CSearchTabHelper
Update an overly aggressive assert recently landed in
ContextualSearchTabHelper when reparenting. This is causing an
existing test to be very flaky (NewTabPageTest#testRender).
BUG=775813, 778540, 782324
[email protected]
(cherry picked from commit a508168ca0eff4981ef1b9ca29ca528395c2e449)
Change-Id: I041742701820dc3899378515fe37a6be44a66d7a
Reviewed-on: https://chromium-review.googlesource.com/757661
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514651}
Reviewed-on: https://chromium-review.googlesource.com/769297
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#487}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[TTS] Fix reparenting and add Test case.
Updates ContextualSearchTabHelper to handle reparenting correctly,
and improve usage of the mTab member to make that usage more explicit.
Adds a new TabObserver method onActivityAttachmentChanged to notify Tabs
when they've been attached or detached from an Activity.
Also refactor mulitwindow test utility methods into a separate utility
class: MultiWindowTestUtils.java, based mostly on static functions
from MultiWindowUtilsTest.java.
BUG=775813, 778540
[email protected]
(cherry picked from commit 17a017076099eb8558dfc8081b1a7cbdbc52bf32)
Change-Id: I460bc3a91494f52aceb77c4880105caadb5c354d
Reviewed-on: https://chromium-review.googlesource.com/738923
Commit-Queue: Donn Denman <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514328}
Reviewed-on: https://chromium-review.googlesource.com/769242
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#486}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Catch exceptions thrown by author script inside callback interfaces.
Failing to do so can cause them to be spuriously thrown later on in the V8
runtime, leading to confusing spooky-action-at-a-distance problems.
This fixes the issue in comment 3 of the linked bug.
Bug: 767359
Change-Id: I79982316f9631d10f9b76f452103b78bd1e7ef67
Reviewed-on: https://chromium-review.googlesource.com/751294
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514805}
(cherry picked from commit d492b2554f1154552ff5893b84afd7164d8bccd7)
Change-Id: I65fca0892837e9918d70050afb778552ae6e2949
Reviewed-on: https://chromium-review.googlesource.com/769387
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#485}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix target reference update for "absolute local" 'href's
M-63 Merge.
When the <use> 'href' was specified as an absolute URL, we would not
consider it local and attempt to request and use the URL as an "external"
resource instead. Because of state inconsistencies and the resource
requested being of the wrong type, this would make shadow tree expansion
fail for nested <use>.
[email protected]
Bug: 783761
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic4ee946c17e16d5dac96263874792ec3f1d882ea
Reviewed-on: https://chromium-review.googlesource.com/763459
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515664}(cherry picked from commit 01dd29be81769cd9490def490b77c795ccb1202a)
Reviewed-on: https://chromium-review.googlesource.com/769367
Cr-Commit-Position: refs/branch-heads/3239@{#484}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Re-enable accelerated 2D Canvas on NVidia High Sierra
Re-enabling accelerated 2D Canvas, as without acceleration performance
was bad enough that Canvas2D became unusable in common cases. If
deciding between occasional visual corruption and unusable performance,
visual corruption seems to be the lesser issue.
Note that this keeps GPU Raster blacklisted. This is unfortunate, but
was only enabled 1yr ago, so should have less sites with a hard
dependency.
[email protected]
(cherry picked from commit 6fa5813dbf5b2ee7e449f983e87e5aa73d196cd4)
Bug: 773705
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1f33a6769fb6691b839f768326c153dfdedf13ff
Reviewed-on: https://chromium-review.googlesource.com/759236
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515315}
Reviewed-on: https://chromium-review.googlesource.com/769232
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#483}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android] Restrict notification intent foreground flag to O+
- Only set the FLAG_RECEIVER_FOREGROUND flag on notification clicks
and closes when the sdk version is >= O.
Bug: 764437
Change-Id: I8a51f7cc7db670700ced543848c4bda092bf2248
Reviewed-on: https://chromium-review.googlesource.com/764148
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Anita Woodruff <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515927}(cherry picked from commit f9b078d0644e0e84044ede407c32809e1082149e)
Reviewed-on: https://chromium-review.googlesource.com/768689
Reviewed-by: Anita Woodruff <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#482}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Only set the FLAG_RECEIVER_FOREGROUND flag for Web Notifications on >=N
We understand what this behaviour does in cases where the Job
Scheduler is used to deliver Web Notification events, but aren't
sure of its behaviour on older versions of Android as it influences
the time we're allowed to run for. Limit it to >= Android N in
order to reduce the risk.
R=awdf
BUG=764437
Change-Id: Ib398adb3ac2ff61a93282639956e092d8315fb57
Reviewed-on: https://chromium-review.googlesource.com/755194
Commit-Queue: Peter Beverloo <[email protected]>
Reviewed-by: Anita Woodruff <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514203}(cherry picked from commit 53b7d7184b8d149c3365ef6683125c5bb7c77f86)
Reviewed-on: https://chromium-review.googlesource.com/768888
Cr-Commit-Position: refs/branch-heads/3239@{#481}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Android Notifications] Add foreground flag to notification intents
- Adding this FLAG_RECEIVER_FOREGROUND flag should ensure that
the intent is delivered to our broadcast receiver immediately after
the notification is clicked or closed.
- This should hopefully fix the bug where tapping a web notification
sometimes does nothing for several seconds when Chrome is in the
background.
Bug: 764437
Change-Id: I31d92266f31516acff896379647f5e65ae8435a4
Reviewed-on: https://chromium-review.googlesource.com/750981
Commit-Queue: Anita Woodruff <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513484}(cherry picked from commit 42af1f7909b1a4cc70543d43f0a9a6edd226042e)
Reviewed-on: https://chromium-review.googlesource.com/768688
Reviewed-by: Anita Woodruff <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#480}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Defer user profile network cert migration until user cert db load
Only run network certificate migration logic on networks
configured in the user profile when the user NSS database is
loaded.
Network certificate migration is still performed for shared
profile networks when the first NSS database (usually the
device-wide "system" token database) is loaded.
Side note: NetworkCertMigrator was the only consumer of the
|initial_load| argument of the OnCertificatesLoaded observer calls,
and as it doesn't rely on it anymore, I'm simplifying the code by
removing the argument.
Background:
NetworkCertMigrator goes through all saved networks and matches
the configured certificate against available certificates.
The goal is to update the PKCS11 slot id the certificate is on
or clear it if the certificate is not available anymore.
CL https://codereview.chromium.org/2858113003 caused a regression
where network certificate migration logic was running on user
profile load but before the user's certificates were available,
so all configured network certificates were cleared.
The visible effect of this was that that AutoConnect does not
work for manually configured EAP-TLS networks in user profiles.
BUG=774745
TEST=chromeos_unittests --gtest_filter=*Cert*
(this will include ClientCertResolver, CertLoader,
NetworkCertMigrator tests)
[email protected]
(cherry picked from commit da53cf1ba363bc68bcddcfd6beb041288448d0d6)
Change-Id: I76ed96df283c5d4219a7731f1150c481c520ce67
Reviewed-on: https://chromium-review.googlesource.com/741239
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Kevin Cernekee <[email protected]>
Commit-Queue: Pavol Marko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513726}
Reviewed-on: https://chromium-review.googlesource.com/768383
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#479}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}H264Decoder: Try to allow more reference frames than current level limit.
Some non-conforming H264 streams may request a number of frames larger than
the limit allowed by the codec level selected in SPS.
Try to accommodate this as long as the requested number of frames is not
above the per-spec upper limit of reference frames.
BUG=783074,b:65646253
TEST=crosvideo.appspot.com,vdaunittest,H264 conformance tests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5443f4a567ed2934b7cf19db850bf3a03dc52926
Reviewed-on: https://chromium-review.googlesource.com/760276
Reviewed-by: Kuang-che Wu <[email protected]>
Commit-Queue: Pawel Osciak <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515141}(cherry picked from commit 9eeda192720b6439a03021ae947ad63ce39a0c83)
Reviewed-on: https://chromium-review.googlesource.com/768527
Reviewed-by: Pawel Osciak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#478}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.50
[email protected]
Change-Id: I961056279ecfad536c5f1a4ffd10dd644f561478
Reviewed-on: https://chromium-review.googlesource.com/767987
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#477}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge 63]Revert of "Sign out user if it's not sign in during profile loaded"
This is the revert of crrev.com/b77864ad82e7b7a5dc0c547aa2ab879d311db98e
Turns out that fix causes crbug.com/775526.
In the mean time, revert won't re-trigger the crbug.com/759007 as it's
fixed by crrev.com/9990e87e486cceef3914bcbb82979190315bad3a.
[email protected]
(cherry picked from commit 53078c4b7a340af06b08927a4bb0727901aff622)
Bug: 759007
Bug: 775526
Change-Id: I2cd5acefb3d8588613629a99dde592f648650a93
Reviewed-on: https://chromium-review.googlesource.com/757718
Reviewed-by: anthonyvd <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515211}
Reviewed-on: https://chromium-review.googlesource.com/767907
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#476}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}m63 merge: app_list: clear AppListModel's search results when profile switching
changes:
Crash happens when doing profile switching, we reset SearchController
but didn't reset AppListModel's search results. When switching back,
search controller is accessing stale search results' stale pointers,
which causes the crash.
[email protected]
(cherry picked from commit a16dd8ab8857ee86fada741dcf3234788f04637e)
Bug: 781499
Test: test that crash doesn't happen any more
Change-Id: Id020581d2c94fd8e14637ec25b8bd1ab266fecde
Reviewed-on: https://chromium-review.googlesource.com/758520
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Vadim Tryshev <[email protected]>
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515231}
Reviewed-on: https://chromium-review.googlesource.com/767788
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#475}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Updating XTBs based on .GRDs from branch 3239
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic985d34d15a22e87a2b5f92abad61c698cf7b939
Reviewed-on: https://chromium-review.googlesource.com/767488
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#474}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Block component updater in M63 for kernel 3.8 and 3.10
This is a temporary fix.
BUG=chromium:783939
TEST=tested on kefka
Change-Id: I177b2b3887b307b63dfa0afe585b4471ddfc42d5
Reviewed-on: https://chromium-review.googlesource.com/745303
Reviewed-by: Bernie Thompson <[email protected]>
Reviewed-by: Greg Kerr <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3202@{#780}
Cr-Original-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}(cherry picked from commit ce1d259a434311632300857ffa1c1c655140b6f3)
Reviewed-on: https://chromium-review.googlesource.com/764506
Cr-Commit-Position: refs/branch-heads/3239@{#473}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge to m63] tray: Fix focus rectangle for tray_info_label.
See bug 771102 for screenshots. The label covers some of the of the focus
rectangle. Changed to use box layout so the label does not take up more
space than it needs.
Fix two other small bugs.
1) Strings for updating flash cutoff in German. Add label multiline
for that label.
2) Tab focus going on power, even though it is not a button. Users using
tab require to tabs to go from the last highlighted region (time) to the
next (sign out).
[email protected]
(cherry picked from commit f38c9a754438b6111c91d87a910c288f472a49d4)
TBR: [email protected]
Test: manual
Bug: 771102, 742283, 769240
Change-Id: I9bc25be80166afcdff2664a457c1f775a8065456
Reviewed-on: https://chromium-review.googlesource.com/750066
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513560}
Reviewed-on: https://chromium-review.googlesource.com/767113
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#472}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Extensions] Fix a bug in override settings
See bug for more info.
Bug: 782959
[email protected]
(cherry picked from commit 313da281c7bfeb11bdf7d7b78c9688fbb37af650)
Change-Id: Ie8c862ba6f489af6a3b8ea6c5bdae11895aaf281
Reviewed-on: https://chromium-review.googlesource.com/759657
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515586}
Reviewed-on: https://chromium-review.googlesource.com/767020
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#471}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[CrOS Tether] Update network iconography in settings page.
This CL changes icons such that:
(1) If no networks exist for the network type, a light-grey "0-bar" icon
is displayed.
(2) If at least one network exists for the network type but none of them
are connected, a light-grey icon with an X is displayed.
(3) If the network type is disabled, a darker strikethrough icon is
displayed.
(4) If a network is connecting, the icon is animated.
(5) If a network is connected, an icon displaying the signal strength is
displayed.
[email protected]
(cherry picked from commit 0dd661fa07ba6c406d331aa051744803c678bb58)
Bug: 764110, 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie433e21017bda469da81f7a297f08cf3cd515fd6
Reviewed-on: https://chromium-review.googlesource.com/762598
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515446}
Reviewed-on: https://chromium-review.googlesource.com/767351
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#470}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Views] AX Fix for the Omnibox Search Icon
The search icon is incorrectly labeled as a button
by screen readers.
To fix this, set the LocationIconView's accessibility
role to be NONE if it's displaying the search icon.
(cherry picked from commit 825fa0da1e43848312b9f5edd5aba5e6d8290aeb)
Bug: 778859
Change-Id: I0504c72009672d7617e465265035a13059535f50
Reviewed-on: https://chromium-review.googlesource.com/754041
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Sarah Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514982}
Reviewed-on: https://chromium-review.googlesource.com/767087
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#469}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[CrOS Tether] Add device type parameter to "Learn More" link.
Instant Tethering is not available on all devices, so we only want the
help article to show up for devices which have the feature. This change
adds a parameter to the "Learn More" link URL which will be used by the
back-end to determine which page to serve.
[email protected]
(cherry picked from commit b915363730541457a33fa0706505a4f85dfbe2eb)
Bug: 783273, 672263
Change-Id: I4ae29af9fbef6de662218d7a988c6af1a4d7b854
Reviewed-on: https://chromium-review.googlesource.com/762161
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515618}
Reviewed-on: https://chromium-review.googlesource.com/767018
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#468}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add missing import for UrlUtilies
This fixes crrev.com/c/763301.
Bug: 783554
Change-Id: I0f4d95ee408a946893bd7e9259ff99ec9299f21a
Reviewed-on: https://chromium-review.googlesource.com/767307
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#467}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Remove hack for TreatNullAsString
This was supposed to be a temporary workaround until issue 714866 is
fixed, but never got removed.
BUG=774176,783916
[email protected], [email protected]
[email protected]
(cherry picked from commit e37fc7c66268fca183dfff186c40e44cfd800998)
Change-Id: I381d0bca04707d0a361d9ce12c96e189b626c389
Reviewed-on: https://chromium-review.googlesource.com/762436
Commit-Queue: Jochen Eisinger <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hayato Ito <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515861}
Reviewed-on: https://chromium-review.googlesource.com/767247
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#466}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't stomp on fake status bar when ending side swipe.
M62's change to -setUpViewLayout changed how some of the view layout code works.
Those changes were correct, but they revealed an ancient bug in how side swipe
re-inserts _contentArea. The fix is to make sure _contentArea is put back
where it belongs.
[email protected]
(cherry picked from commit 16ad60e7f5c7db6055c73fbe5abd42fc78e13310)
Bug: 773394
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icf1c2f9b31f04504595e0ffe24687372476d5098
Reviewed-on: https://chromium-review.googlesource.com/761479
Reviewed-by: Elodie Banel <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515552}
Reviewed-on: https://chromium-review.googlesource.com/766517
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#465}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Expand interest rect in GraphicsLayer space, adjusted for approximate layer scale.
An earlier patch moved expansion of the interest rect to root space, but this
doesn't work for non-linear transforms like perspective. The intent of the earlier
patch was to account for layer scale when determining the amount to expand, with
the intent to expand by a certain number of pixels in screen space, not layer
space. This patch achieves the same result, but changing the expansion amount by
the scale factor.
[email protected]
(cherry picked from commit 692d8c95a4a76ff431b17ab760684aa3e4852d30)
Bug: 781699
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I85bcbd8301caa8b3abd36035df63f3eca0e1235c
Reviewed-on: https://chromium-review.googlesource.com/758821
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: vmpstr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515275}
Reviewed-on: https://chromium-review.googlesource.com/767148
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#464}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge to 3239] Don't grab malloc stats for memory_instrumentation service on Windows.
Only do so for DETAILED dumps. The call is expensive [~70ms per process].
[email protected]
(cherry picked from commit 99e816790db36cf7b225bf726f1ecb2d7e41a177)
Bug: 780735
Change-Id: I757c7e4359afe379561788420c9e257c2275174d
Reviewed-on: https://chromium-review.googlesource.com/757296
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Primiano Tucci <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514993}
Reviewed-on: https://chromium-review.googlesource.com/766478
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#463}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Ignore FrameHostMsg_WebUISend IPC from swapped-out frames.
Before r507414 when the Frame/ViewHostMsg_WebUISend message was sent
from a swapped out view/frame, then it would be dropped on the floor
because of SwappedOutMessages::CanSendWhileSwappedOut. This behavior
was important, because subsequent security checks (e.g. done by
WebUIImpl::CanCallJavascript) are performed against the *current* frame
host.
This CL restores the old behavior by ignoring the FrameHostMsg_WebUISend
message if it comes from a swapped-out frame.
[email protected]
(cherry picked from commit 629fc5856ae8b4a485d44f1ffc3a2dd6599d2a2c)
Bug: 780920
Change-Id: If9bd44b4badf79a92866c56bf67d84bc36f7db0d
Reviewed-on: https://chromium-review.googlesource.com/760717
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Nick Carter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515311}
Reviewed-on: https://chromium-review.googlesource.com/766477
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#462}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.49
[email protected]
Change-Id: I8a779a7e2dc2014a98803eb676ef80ff785f432f
Reviewed-on: https://chromium-review.googlesource.com/766510
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#461}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix padding issue in MD incognito NTP using Chrome Home.
Top and bottom padding of 0 was being applied to the MD incognito NTP
container when using Chrome Home, which was fine when the bottom
navigation menu was opaque. Now that the menu can be translucent, the
incognito NTP exists beneath the menu, so we can no longer rely on
the previous padding to push the content into the visible region.
The padding utils for the bottom sheet should take care of adding
appropriate padding to the incognito contents when using Chrome
Home, so we leave the padding intact here. An additional padding is
added to the Learn More link to give a little bump above the menu
and make it easier to tap.
[email protected]
(cherry picked from commit 99415a39c9e86e68fe3bbd135a4437c8dd20706a)
Bug: 777961
Change-Id: I4f6567db6a79cf4524d81f9207e236db970b1933
Reviewed-on: https://chromium-review.googlesource.com/738455
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Troy Hildebrandt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511548}
Reviewed-on: https://chromium-review.googlesource.com/766529
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#460}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Make sure we check that 3 hours has passed before opening NTP.
Currently, we don't check for the 3 hours to pass before opening the
bottom sheet to half if opened on the tab switcher. This adds that
check.
[email protected]
(cherry picked from commit 5ae532bced2ee3e6d73869f070d1a31c21c1fad2)
Bug: 781052
Change-Id: If680a1ed06d5e18161fdc8df60892592a6a55ddb
Reviewed-on: https://chromium-review.googlesource.com/758825
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Troy Hildebrandt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515212}
Reviewed-on: https://chromium-review.googlesource.com/766548
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#459}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}android: Add UrlUtilies.isHttpOrHttps.
This method is called by dd47630bbb313ca9f7efdd59ec2cf1604b2d9dbc which
is a cherry-pick of e29f7184a20c69e484adfd115b7dcdc4f774ef5b. This adds
the missing method to the branch.
Bug: 780708, 783554
Change-Id: I9fd08d720f324ee825558cfac480a39f1a652d94
Reviewed-on: https://chromium-review.googlesource.com/763301
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#458}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Avoid copying .xcassets in the application bundle.
The refactoring that introduced those templates inadvertently
regressed and caused the content of .xcassets to be copied to
the application bundle thus increasing the size of the bundle
unnecesssarily.
Bug: 782584
Change-Id: Ib7f39d00347a821467774489ecc222a57a3fe27d
Reviewed-on: https://chromium-review.googlesource.com/758262
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514819}(cherry picked from commit a19cb1ed33d46b889585385b39201198f506a384)
Reviewed-on: https://chromium-review.googlesource.com/765369
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#457}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix the incorrect accessibility type issue (new iOS bookmarks)
Override the accessibility methods in bookmark_table_cell so that we can
hide the title textField from UIAccessibility when it is not being
edited.
[email protected]
(cherry picked from commit 5213e481438d7d9a058cf49d17542c295e0733d0)
Bug: 781213
Change-Id: I6f35c6ad8a060f09a8dfc5576123f89bc9ffa114
Reviewed-on: https://chromium-review.googlesource.com/754466
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514783}
Reviewed-on: https://chromium-review.googlesource.com/765559
Reviewed-by: Marti Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#456}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.48
[email protected]
Change-Id: Ibee4a11b9f15e513cf7b1d8c8a9fd2e5e1af25f5
Reviewed-on: https://chromium-review.googlesource.com/764657
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#455}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.47
[email protected]
Change-Id: I7a2befecb2859846e657e245fef4790c54d8a9a8
Reviewed-on: https://chromium-review.googlesource.com/764653
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#454}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Password Manager] Don't reveal password value of a field if Chrome autofilled the field
Bug: 782164
Change-Id: If8060cb64a001a36be2118dc84a67d115bcf8215
Reviewed-on: https://chromium-review.googlesource.com/758652
Reviewed-by: Vadym Doroshenko <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514879}(cherry picked from commit ad0c0b5f0de364c358fa8b4a6b6b55eeb646f3a7)
Reviewed-on: https://chromium-review.googlesource.com/765347
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#453}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Password Manager] Show confirmation bubble as manual fallback for generated cases
Bug: 782663, 725883
Change-Id: I1e836ff22ab8e729a5b2a30519fc8e9b7579e151
Reviewed-on: https://chromium-review.googlesource.com/758270
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515123}(cherry picked from commit eb2186f3682000349de07278cc013da765ba364c)
Reviewed-on: https://chromium-review.googlesource.com/765327
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#452}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.46
[email protected]
Change-Id: I86c83b9a2c0999feeae914009f089cca1b02c2aa
Reviewed-on: https://chromium-review.googlesource.com/765148
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#451}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Introduce a new histogram: SB2.NoUserActionResourceLoadingDelay
It reports the total delay, in milliseconds, caused by SafeBrowsing for a
resource load, if the SafeBrowsing interstitial page is not showed and therefore
no user action is involved. At most one value is reported for each resource
load. If SafeBrowsing causes delays at different stages of a load, the sum of
all the delays will be reported.
BUG=782418
[email protected]
(cherry picked from commit 91a2dca5bef0a9851f4c853c834539240bc14356)
Change-Id: Ie467d181c4f535dbb4e5fcc67a8e23c284a4b4f7
Reviewed-on: https://chromium-review.googlesource.com/756962
Commit-Queue: Yuzhu Shen <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515379}
Reviewed-on: https://chromium-review.googlesource.com/765099
Reviewed-by: Yuzhu Shen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#450}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Use DidStartNavigation() to reset JS dialog blocking state..
This allows us to inspect whether the navigation is same-document or
renderer-initiated so we can maintain the blocking status for internal
page navigations.
[email protected]
(cherry picked from commit fab6bbb99df708e3e33f3a944e1a3396940a8bea)
Bug: 780852
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie7c7fb34f1ac7eef296a9b3f6d3844a2a25a87d1
Reviewed-on: https://chromium-review.googlesource.com/758058
Commit-Queue: Kurt Horimoto <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515103}
Reviewed-on: https://chromium-review.googlesource.com/765012
Cr-Commit-Position: refs/branch-heads/3239@{#449}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Grant generic sensor permission for Android WebView
This CL adds code to grant generic sensor permission for Android
WebView so that the sensors needed by device motion and orientation can
be obtained from the generic sensor provider.
Note: This will not allow Android WebView to have access to all the
sensors that the generic sensor API provides since
SensorProviderImpl::GetSensor() is still guarded by
features::kGenericSensorExtraClasses flag. There is no new sensors
permission granted, and the sensors that are exposed on WebView by
this CL are those sensors that are already available on WebView
previously which are used to implement device motion/orientation
events.
[email protected]
(cherry picked from commit b6c4e590df557fce300e3178e8d4c2e6cfdd7bce)
Bug: 779443
Change-Id: I1405e54213bb07d1d781181e473fc77e89bb12ed
Reviewed-on: https://chromium-review.googlesource.com/759240
Commit-Queue: Jun Cai <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Tao Bai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515285}
Reviewed-on: https://chromium-review.googlesource.com/765011
Reviewed-by: Jun Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#448}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Fix invalid URL bitmap
This change sets the 'toolbar ready for captute' flag when a tab is
shown rather than waiting for the URL to be updated. When a tab is
reparented for Chrome Home, the activity restarts and resets the flag.
Since the URL of the tab technically hasn't changed, the onUrlUpdated
even is not called and the URL bitmap is therefore never updated.
BUG=781692
[email protected]
(cherry picked from commit 943a81841210b063ce5e8f17e5a9c74a311c08cb)
Change-Id: I209f81d4f9bed0e2566d7a42c84294c8af1b863e
Reviewed-on: https://chromium-review.googlesource.com/757816
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515047}
Reviewed-on: https://chromium-review.googlesource.com/764871
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#447}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Handle transient items in VoiceSearchNavigationsTabHelper.
The previous implementation expected the NavigationItem to be committed
or pending, but this CL updates the logic to work for interstitials as
well.
This CL also adds WebTestWithWebState::AddTransientItem(), which is
used in a test to prevent regressions of this bug.
[email protected]
(cherry picked from commit 0134bc1589b4e8e5ea1da394e0bd100a65fc2f5e)
Bug: 781031
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I93e1db64b423592b833aaa843cfba2e834cdd214
Reviewed-on: https://chromium-review.googlesource.com/755946
Commit-Queue: Eugene But <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515323}
Reviewed-on: https://chromium-review.googlesource.com/764873
Cr-Commit-Position: refs/branch-heads/3239@{#446}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Truncate JavaScript message length to 150 characters.
[email protected]
(cherry picked from commit 31365a9e7d5dad2c09df0b4a86fb9ba355e019d5)
Bug: 782399
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icafc8d57aaa229acb3d66628378aa49146d9b8cd
Reviewed-on: https://chromium-review.googlesource.com/758083
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515219}
Reviewed-on: https://chromium-review.googlesource.com/764870
Cr-Commit-Position: refs/branch-heads/3239@{#445}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[sync] Only send valid page_urls to FaviconCache
Prior to a refactoring of sessions_sync_manager, page_urls were
implicitly filtered for validity by only using those that matched the
url of a local tab. With this filtering gone, there are scenarios that
can result in invalid urls being sent. Rather than trying to figure out
all these scenarios, it seems safer to just not forward these urls at
all.
R=[email protected]
BUG=769008
Change-Id: I5068842577b4625c21057d5a022145ebf3415948
Reviewed-on: https://chromium-review.googlesource.com/752541
Reviewed-by: Nicolas Zea <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513630}(cherry picked from commit 18f44eaca7744591524670b020b84506cb989171)
Reviewed-on: https://chromium-review.googlesource.com/764433
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#444}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge m63] Avoid crash in Autofill/Payment Request
Chrome crashes on Android when it is launched by chrome home UI
after fresh launch.
Instead of using PersonalDataManager's URL request context getter,
get the URL request context getter from the browser process.
Apply the change to Desktop as well.
[email protected]
(cherry picked from commit 3dcdabee80ae036e206eabd2e67a123fb2e79fc4)
Bug: 769691
Change-Id: Ib9b67b4c4719ae5e6cb681a6362c773a15fa3eff
Reviewed-on: https://chromium-review.googlesource.com/755216
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Parastoo Geranmayeh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514306}
Reviewed-on: https://chromium-review.googlesource.com/764707
Cr-Commit-Position: refs/branch-heads/3239@{#443}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "If a font resource load is cancelled, don't fallback to a different font."
Some cases are flagged as cancellations that aren't exactly, and that we want
to fall back after.
This reverts commit 126dc76bd00c11209ccf65ea151d5263fde0c7dc.
[email protected], toyoshim
(cherry picked from commit d8bfda2014e0a78237cc57de958898a6594faf29)
Bug: 780389, 781270
Change-Id: Ib8d6f96e63c1cd9b87e87c8651b7fdbafa69e460
Reviewed-on: https://chromium-review.googlesource.com/755316
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514226}
Reviewed-on: https://chromium-review.googlesource.com/764371
Cr-Commit-Position: refs/branch-heads/3239@{#442}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.45
[email protected]
Change-Id: I58cce949b7a9c6fe424b55b7e69beaf6cb68f623
Reviewed-on: https://chromium-review.googlesource.com/763930
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#441}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Use extra_substitutions for ios_framework_bundle.
Fix the ios_framework_bundle template to only forward the
extra_substitutions parameter to templates that support
it.
Change MDFInternationalization ios_framework_bundle target
to use extra_substitutions instead of using a separate
target for the generation of the Info.plist.
Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I615a76271089472d071ac0d4af1e28f957cbf674
Reviewed-on: https://chromium-review.googlesource.com/758577
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514925}(cherry picked from commit be2598dc65e1f353a02aaafc4b67e72e1bed7433)
Reviewed-on: https://chromium-review.googlesource.com/763637
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#440}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix toolbar leading calculation on RTL
The toolbar has two view: the background view and the content view.
The content view has the same size as the background view using auto
layout. When the frame of the toolbar is directly modified, the
constraints do not kick in before we use the size of the background
view to resize the omnibox.
This creates a problem as the content inside the content view is using
the autoresizing mask. When the content view is resized with auto
layout, its content is resized a second time.
This CL fixes it by using the frame of the content view instead of the
frame of the background view.
Bug: 781929, 781910
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia42190363ad48d08422b085e55a4a94e216ec9a9
Reviewed-on: https://chromium-review.googlesource.com/756708
Reviewed-by: Stepan Khapugin <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514440}(cherry picked from commit fd9517b66d8ed921e16d3c3ebe64c8fd45eb7ca0)
Reviewed-on: https://chromium-review.googlesource.com/763087
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#439}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[WebView autofill] Return the new value of list and checkbox
[email protected]
(cherry picked from commit dcee922856f0499dde86df39d978c4819bf01752)
Bug: 780857
Change-Id: I8c43090ab96daec09997fb0cb24a55c09bb464a7
Reviewed-on: https://chromium-review.googlesource.com/751686
Reviewed-by: Changwan Ryu <[email protected]>
Commit-Queue: Tao Bai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515184}
Reviewed-on: https://chromium-review.googlesource.com/762140
Reviewed-by: Tao Bai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#438}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.44
[email protected]
Change-Id: I82f6792452b40011bb737643a3e00076935f6a60
Reviewed-on: https://chromium-review.googlesource.com/762017
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#437}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge 63 Fix an issue that UI will infinitely loading when clicking notification.
If we kill Chrome on android and click on the notification. It will
infinitely show loading spinner, since the backend doesn't send the
correct signal to show the content.
https://chromium.googlesource.com/chromium/src/+/04ad2f701c01e367b9339794ba0ca4b7372e6274
accidentally fixed this issue on trunk, since it calls
OfflineContentAggregator::RegisterProvider in BackgroundFetchDelegateImpl early, but that
CL is not in M63 beta.
[email protected]
(cherry picked from commit 3995adaf732f249ffb410398bae53698c7c8d71c)
Bug: 781936
Change-Id: Ib1beccadb66b51f40c3602d022515789c397e3ec
Reviewed-on: https://chromium-review.googlesource.com/757781
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Carlos Knippschild <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#515005}
Reviewed-on: https://chromium-review.googlesource.com/762381
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#436}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Retain the password delegate with SSLPlatformKeyNSS.
PK11_FindKeyByAnyCert retains wincx on the resulting SECKEYPrivateKey,
which may be used on PK11_Sign. To keep the lifetimes correct, we must
retain a reference to the password delegate in SSLPlatformKeyNSS.
Bug: 779090
Change-Id: Ia769ebe967582e83fbcbcaa5bca7ef788c1345a6
Reviewed-on: https://chromium-review.googlesource.com/743847
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512641}(cherry picked from commit 441e128149625f1f7d86a32faa2ca9cf93d5810e)
Reviewed-on: https://chromium-review.googlesource.com/761399
Cr-Commit-Position: refs/branch-heads/3239@{#435}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Only allow googlechrome protocol for http(s) urls
The protocol should only be used to navigate to http(s) urls, no content or
file uri.
BUG=780708
[email protected]
(cherry picked from commit e29f7184a20c69e484adfd115b7dcdc4f774ef5b)
Change-Id: I00ea7e0fd31ec9e379ddcb5126265a6744de822d
Reviewed-on: https://chromium-review.googlesource.com/752202
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514030}
Reviewed-on: https://chromium-review.googlesource.com/761116
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#434}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Correct name of field trial for SerializeCoreAudioPauseAndResumeDuringSystemSleep finch study.
[email protected]
(cherry picked from commit 63d08bd8c480ed251038a0b8626e986e54d80d26)
Bug: 772884
Change-Id: Ia565b63f6135a7a64f477ad50a1718c26ddd3c91
Reviewed-on: https://chromium-review.googlesource.com/741706
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Henrik Grunell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512214}
Reviewed-on: https://chromium-review.googlesource.com/758682
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#433}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Update catapult revision for chromeos test fixes.
This includes fixes for 776512, 779910, 777541.
BUG=chromium:776512, chromium:779910, chromium:777541.
TEST=None
[email protected]
Change-Id: I54b28d61eed1bd8d0aab8c6796d030f7a26eb4e0
Reviewed-on: https://chromium-review.googlesource.com/758265
Reviewed-by: Achuith Bhandarkar <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#432}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[WebView autofill] Start new session in frame change
Start new session when frame is changed, previously, we check if the
form change to start a new session, it almost worked, but failed
once the other frame has same form, this patch starts a new session
when either frame or form changes, also removes unnecessary
reset when frame is changed.
Also, add test to cover this use case.
[email protected]
(cherry picked from commit 79438ded3cfafb2a3ae274ee8b5fe3861ead2ed3)
Bug: 774127
Change-Id: Ib03ff42677668b29a782f8ec44d007f6c4e1102a
Reviewed-on: https://chromium-review.googlesource.com/731612
Reviewed-by: Roger McFarlane <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Commit-Queue: Tao Bai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511563}
Reviewed-on: https://chromium-review.googlesource.com/759626
Reviewed-by: Tao Bai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#431}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Remove device policy wallpaper blur and add background to user pods
Tested with Admin panel to set device policy wallpaper.
Specs:
https://drive.google.com/a/google.com/file/d/0B7p2VSoU0uoeZjNnbXpvSktGMUhiMG5CUUNhZFJaUDZMR2lz/view?usp=sharing
[email protected]
(cherry picked from commit d26192b33b6b56b18bf09bb5227d4c7933856814)
Bug: 775591
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I244dd2247f2aaf3a21438aa48f8d636f7c06e259
Reviewed-on: https://chromium-review.googlesource.com/745531
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514619}
Reviewed-on: https://chromium-review.googlesource.com/759818
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#430}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.43
[email protected]
Change-Id: Ic49f76abcba3055ca9f5cbc2698073e65f693b75
Reviewed-on: https://chromium-review.googlesource.com/759379
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#429}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.42
[email protected]
Change-Id: I4f5089f7ff6bfdde7b78231f80a8f22895a14b96
Reviewed-on: https://chromium-review.googlesource.com/758660
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#428}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Change CFBundleIdentifier of MDFInternationalization
This CL changes the CFBundleIdentifier of the MDFInternationalization
to have the provisioning profiles used by the app working with it.
Bug: 782597
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9c579f00e6695d8fd8a836a6a412a56f48127e0a
Reviewed-on: https://chromium-review.googlesource.com/758240
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514818}(cherry picked from commit 03d80073fb96d92125d9ba07ba1eb634a87ffb71)
Reviewed-on: https://chromium-review.googlesource.com/759234
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#427}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Disable entitlements and mobileprovision on framework signatures
Frameworks inherit entitlements and mobileprovisions from the app.
Bug: 782597
Change-Id: Ib17b39c7c2ba7cc968e55bc2d1309b5de408fb18
Reviewed-on: https://chromium-review.googlesource.com/758255
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Commit-Queue: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514834}(cherry picked from commit 7cb10f0ad1d06917d24aa2e81491a706aef2413e)
Reviewed-on: https://chromium-review.googlesource.com/759154
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#426}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge M63: "Fix hung streams if a track change never reaches have_enough."
During a track change it's possible that a renderer will never
reach the have_enough state again. I.e., with MSE a client may
want to seek to a later location. The current code means the
renderer will get stuck forever waiting for data that never
comes.
Instead Flush() calls from the Pipeline should always take
precedence and cancel any track changes in progress. Upstream
of the renderer the demuxer has already had the track enabled,
so just letting the normal Flush() process occur is sufficient
to restart the track.
BUG=781010
TEST=updated unittest
[email protected], xhwang
(cherry picked from commit 3defa5495fc19bb5115286876dc94e0887874cd2)
Change-Id: I5c005e728d9c1babf2a95c2e603a75f7976ec16d
Reviewed-on: https://chromium-review.googlesource.com/752048
Commit-Queue: Dale Curtis <[email protected]>
Reviewed-by: Sergey Volk <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514324}
Reviewed-on: https://chromium-review.googlesource.com/758967
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#425}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge M63 "cros: Fix eula height regression"
> Use a fixed height on webview to work around the wrong height
> calculated for its inner iframe. Previously, the work around
> is to set a fixed height on #eulaDialog but that has a problem
> that webview height grows when it gains/loses focus.
>
> Bug: 778978
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I6be9054566f53251afe6bf3bca2972fa1d45ab7b
> Reviewed-on: https://chromium-review.googlesource.com/754296
> Reviewed-by: Achuith Bhandarkar <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#514238}
> (cherry picked from commit 8535de60c5047263328ed2c9d6e82aef69661a69)
Change-Id: I7962c34e3ba310a55d6e693de5da03adfa8e3e50
Reviewed-on: https://chromium-review.googlesource.com/758966
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#424}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[scheduler] Reintroduce concept of pausing timers for Android WebView.
Android WebView has an API to pause timers and we have to support it
for the time being because changing WebView API and CTS tests is hard.
This patch relands parts of
https://chromium-review.googlesource.com/c/chromium/src/+/702356.
[email protected], [email protected], [email protected], [email protected]
[email protected]
BUG=773848
(cherry picked from commit 4b61522379090f524b8c56d7ce4e9481f42beebd)
Change-Id: I728961bc4852ccefc9d5cc0ce45c872cd6dd840e
Reviewed-on: https://chromium-review.googlesource.com/718939
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Yoland Yan <[email protected]>
Reviewed-by: Bo <[email protected]>
Reviewed-by: Alex Clarke <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509504}
Reviewed-on: https://chromium-review.googlesource.com/758403
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#423}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Re-cache Chrome Home state in finalizePendingFeatures
This allows for metrics to be recorded properly.
BUG=780071
[email protected]
(cherry picked from commit c42efbe9e5cf5cd81c5876684f73576509cde90c)
Change-Id: I29d6bbab9e9701a1a0e40196ea17e992a2d97f43
Reviewed-on: https://chromium-review.googlesource.com/748969
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513525}
Reviewed-on: https://chromium-review.googlesource.com/758623
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#422}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Do not show IPH if the anchored view is not attached
Check if the anchored view is attached before trying to show an IPH over
an infobar. This should prevent BadTokenExceptions that are popping up
as we try to show IPH when the infobar shows.
BUG=779598
Change-Id: I0cf3766bda4ab649a0fecefc24769cfa40ee560f
Reviewed-on: https://chromium-review.googlesource.com/751702
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#513645}(cherry picked from commit 8ff77a9c1c5dd764a5e6eee69c4306165e8e0ed0)
Reviewed-on: https://chromium-review.googlesource.com/758960
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#421}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix bug where notifications for failed downloads are not dismissable.
There was a bug where notifications for failed downloads (specifically
offline pages) were not dismissable on Android O. This is because the
foreground service was accidentally being turned on as the download was
failed, leaving the summary notification pinned to the foreground.
Bug: 776998
Change-Id: I8780e6e0002939bfc186e38d18608a5845bb65a9
Reviewed-on: https://chromium-review.googlesource.com/742486
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Joy Ming <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512978}(cherry picked from commit 94fabd8ca8e0ae7d068c5e8471f88d439e9b0a5b)
Reviewed-on: https://chromium-review.googlesource.com/758957
Cr-Commit-Position: refs/branch-heads/3239@{#420}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Tests for bug where failed offline pages are not dismissable.
A previous CL (issue 742486) fixed a bug where notifications for failed
downloads were not dismissable on Android O. This CL writes a check to
make sure this fix continues to work.
Bug: 776998
Change-Id: I1a38c04c3c301dfd9c9daaa524f92d144f1d3967
Reviewed-on: https://chromium-review.googlesource.com/755537
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Joy Ming <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514242}(cherry picked from commit 7f574b48d64f5ca91a90ee6bde1c924658fba3cb)
Reviewed-on: https://chromium-review.googlesource.com/758956
Cr-Commit-Position: refs/branch-heads/3239@{#419}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Blacklist iWnn and variants
Wnn and iWnn don't seem to work correctly with
SpannableInlineAutocomplete, therefore blacklisting the package names.
BUG=758443
Change-Id: Ib9d677a4d4e49a43b1d70de5fb89b80eea876913
Reviewed-on: https://chromium-review.googlesource.com/745726
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512848}(cherry picked from commit 523e6cee73f7729c2ba74ef89e416824d6050de3)
Reviewed-on: https://chromium-review.googlesource.com/758958
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#418}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add a Mojo call for opening chrome://settings/ main and sub pages.
The preceding change crrev.com/717336 prohibited ARC++ apps to open
chrome:// URLs with one exception (chrome://settings/multidevice),
but this was too restrictive to support some Anrdoid framework APIs.
This CL adds a method dedicated for opening whitelisted (and
extendable) chrome://settings URLs to allow necessary cases.
BUG=b/68655417
TEST=adb shell am start -a android.settings.INPUT_METHOD_SETTINGS
[email protected]
(cherry picked from commit 7d5a92f12d6b1671d4365d2a96d2ac65f18e9a9f)
Change-Id: Iadaa7bf584b6a02656dbd484450a721decd1a7c8
Reviewed-on: https://chromium-review.googlesource.com/750501
Reviewed-by: Kazuhiro Inaba <[email protected]>
Reviewed-by: Mattias Nissler <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Commit-Queue: Kazuhiro Inaba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#514081}
Reviewed-on: https://chromium-review.googlesource.com/758059
Cr-Commit-Position: refs/branch-heads/3239@{#417}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
