Publish DEPS for Chromium 63.0.3239.30
Incrementing VERSION to 63.0.3239.30
[email protected]
Change-Id: Iec07ae600fb5c42be333cb9b0b8b469b9896f623
Reviewed-on: https://chromium-review.googlesource.com/747921
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#328}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix build after commit 6af4638.
TBR=pdr
Bug: 777253
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic4351adaf54b0b02a556f6d4bf97e5574753de41
Reviewed-on: https://chromium-review.googlesource.com/747877
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#327}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Have all notification interactions start DownloadNotificationService.
There were a few bugs (see attached) related to the fact that for some
cases notification interactions, native is not started. This CL makes
it so that all notification interactions received by
DownloadBroadcastReceiver start native.
Bug: 775277,774923,774972
Change-Id: Iba19dcb6ebe4b6cc0805f3656fbc36e0470d9610
Reviewed-on: https://chromium-review.googlesource.com/722320
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Joy Ming <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512065}(cherry picked from commit ea3bcc536b3aa5c0f953524bf83c2ac3987fd2e4)
Reviewed-on: https://chromium-review.googlesource.com/745421
Cr-Commit-Position: refs/branch-heads/3239@{#326}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.29
[email protected]
Change-Id: I77faba6af530057b7a63f21889a954d9de7cfec5
Reviewed-on: https://chromium-review.googlesource.com/747508
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#325}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "[Merge to M63] Give NestableTasksAllowed() control back to MessageLoop."
This reverts commit 8661c6c3eacf31fbbc5c202a844b06bd0381e571.
Reason for revert: known to cause crbug.com/778562, will reland merge + fix when we have it.
Original change's description:
> Give NestableTasksAllowed() control back to MessageLoop.
>
> While I still think RunLoop::Type::kNestableTasksAllowed is the right
> API to allow nesting of application tasks in the usual case:
> RunLoop::Delegate::Client::ProcessingTasksAllowed() wasn't the right
> level of abstraction for the allowance (even without the bug it suffered).
>
> When I hit https://bugs.chromium.org/p/chromium/issues/detail?id=754112#c6
> I initially thought the solution was for Client::ProcessingTasksAllowed()
> to return a scoped token to allow only a single application task at once
> per RunLoop instance. But implementing it (see PS1) it became apparent
> that this wasn't generally something most RunLoop::Delegates cared about.
> Rather it was a fallout of some MessageLoops which permit reentrancy
> without a nested RunLoop being involved (e.g. MessageLoop::Run() ->
> MessageLoop::RunTask() can go through an OS-driven MessagePump which can
> in some scenarios trigger reentrancy without a second call to Run()).
>
> This CL keeps the API in RunLoop to declare allowance but then tells
> RunLoop::Delegate::Run() via param whether it should allow application
> tasks for that layer. Leaving it up to the impl to determine how to
> control that.
>
> This ends up getting rid of the duality of the previous check in
> NestableTasksAllowed() as well. Now centralizing the logic in MessageLoop.
>
> Much simpler than the alternative (again, see PS1).
>
> While PS9 ended up keeping usage of a bool to control reentrancy (usage
> of racing counters (allowed vs used) proved useless as they were either
> equal or one off), it was renamed away from referring to "nestable tasks"
> as this makes the nomenclature very confusing with "nested loops" which
> are not the same thing at all. Instead we just name it
> "task_execution_allowed_" and leave it up to MessageLoop logic
> (DeferOrRunPendingTask()) to know to skip non-nestable tasks when inside
> a nested loop.
>
> For reference, see PS16-19 for attempts at making RunLoop be the sole
> controller of nesting/nestable tasks allowance. This was dropped for now as
> it proved to be ugly in conjunction with deprecated MessageLoop::*Nestable*
> APIs that still need to be supported until callers are migrated.
>
> Bug: 754112
> Change-Id: I9f3a8431c00f69b0b5bb696e1e86e32bba6e6ffe
> Reviewed-on: https://chromium-review.googlesource.com/730864
> Reviewed-by: Robert Liao <[email protected]>
> Reviewed-by: danakj <[email protected]>
> Commit-Queue: Gabriel Charette <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#511673}
[email protected], [email protected], [email protected]
Bug: 754112
Change-Id: I7dcc7521072f867f9513feafc8fb4ffacab1fad9
Reviewed-on: https://chromium-review.googlesource.com/747529
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#324}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.28
[email protected]
Change-Id: Ie2ac6da4733e96d97d3d3788ac1c785727b78446
Reviewed-on: https://chromium-review.googlesource.com/747527
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#323}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Set paint_offset_root for objects under an SVG hidden container.
[email protected]
(cherry picked from commit 91c05c7d72f068122fdb347a359ee15f88c6273f)
Bug: 777253
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7d6b29dcb4dc478048ce14ace2b839453a271c8c
Reviewed-on: https://chromium-review.googlesource.com/738865
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512025}
Reviewed-on: https://chromium-review.googlesource.com/747207
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#322}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Allocate a paint offset translation even if identity.
It's important for a paint offset root to be set to a LayoutObject when
it has any kind of transform. Paint offset roots are tied to the paint
offset transform in the code structure, so it is simpler and easier
to understand to always allocate it. The optimization this CL removes
had an unclear performance benefit as well, which is another reason
to be willing to remove it.
[email protected]
(cherry picked from commit e5c2911babfd517718f3b6d9f707cda3bf0bd28e)
Bug: 771300
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idd6d32f8d58872f0e7f25040631990fe78277887
Reviewed-on: https://chromium-review.googlesource.com/741038
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512405}
Reviewed-on: https://chromium-review.googlesource.com/747632
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#321}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't apply pagination offset for rounded clips outside of fragmentation.
This was broken by commit c3a3481. Before that commit, PaintLayerClipper
was not asked how to compute a clip *across* a pagination container, instead
stopping at the pagination container. Thus the case being fixed here was
never exhibited.
[email protected]
(cherry picked from commit 1a1ad402c946c211865d9e1b4ee227da7ffdbf70)
Bug: 778213
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3c540e31fdf3b77d5a34fbdf08104d0490f9a1ea
Reviewed-on: https://chromium-review.googlesource.com/740379
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512284}
Reviewed-on: https://chromium-review.googlesource.com/747205
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#320}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Give NestableTasksAllowed() control back to MessageLoop.
While I still think RunLoop::Type::kNestableTasksAllowed is the right
API to allow nesting of application tasks in the usual case:
RunLoop::Delegate::Client::ProcessingTasksAllowed() wasn't the right
level of abstraction for the allowance (even without the bug it suffered).
When I hit https://bugs.chromium.org/p/chromium/issues/detail?id=754112#c6
I initially thought the solution was for Client::ProcessingTasksAllowed()
to return a scoped token to allow only a single application task at once
per RunLoop instance. But implementing it (see PS1) it became apparent
that this wasn't generally something most RunLoop::Delegates cared about.
Rather it was a fallout of some MessageLoops which permit reentrancy
without a nested RunLoop being involved (e.g. MessageLoop::Run() ->
MessageLoop::RunTask() can go through an OS-driven MessagePump which can
in some scenarios trigger reentrancy without a second call to Run()).
This CL keeps the API in RunLoop to declare allowance but then tells
RunLoop::Delegate::Run() via param whether it should allow application
tasks for that layer. Leaving it up to the impl to determine how to
control that.
This ends up getting rid of the duality of the previous check in
NestableTasksAllowed() as well. Now centralizing the logic in MessageLoop.
Much simpler than the alternative (again, see PS1).
While PS9 ended up keeping usage of a bool to control reentrancy (usage
of racing counters (allowed vs used) proved useless as they were either
equal or one off), it was renamed away from referring to "nestable tasks"
as this makes the nomenclature very confusing with "nested loops" which
are not the same thing at all. Instead we just name it
"task_execution_allowed_" and leave it up to MessageLoop logic
(DeferOrRunPendingTask()) to know to skip non-nestable tasks when inside
a nested loop.
For reference, see PS16-19 for attempts at making RunLoop be the sole
controller of nesting/nestable tasks allowance. This was dropped for now as
it proved to be ugly in conjunction with deprecated MessageLoop::*Nestable*
APIs that still need to be supported until callers are migrated.
[email protected], [email protected]
(cherry picked from commit b030a4a0884a87640ad65e51b20847c6213b8eab)
Bug: 754112
Change-Id: I9f3a8431c00f69b0b5bb696e1e86e32bba6e6ffe
Reviewed-on: https://chromium-review.googlesource.com/730864
Reviewed-by: Robert Liao <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511673}
Reviewed-on: https://chromium-review.googlesource.com/747281
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#319}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Domain Reliability / NEL: Add third-party domains for prototyping
[email protected]
(cherry picked from commit 880af477a8b12b77e871c29cf0ea4e2515fba3d4)
Bug: 763433
Change-Id: Id314290c18ff7d6c7d2f2c4c995002a3434d734e
Reviewed-on: https://chromium-review.googlesource.com/648028
Commit-Queue: Julia Tuttle <[email protected]>
Reviewed-by: Chris Bentzel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510180}
Reviewed-on: https://chromium-review.googlesource.com/747461
Reviewed-by: Julia Tuttle <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#318}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63 merge] Call OnGaiaPasswordChanged() only on true password change
Password manager code calls SaveSyncPasswordHash(..) every time user
signs into google in the content area, thus triggers the preference change
event that consequently trigger OnGaiaPasswordChanged().
This CL checks if the value of kSyncPasswordHash actually changed (vs.
same password saved again) before triggering OnGaiaPasswordChanged() call.
[email protected]
(cherry picked from commit b0a98caed57549fec380943deb2fcbc3612925e9)
Bug: 767633
Change-Id: Iacb9c5bf75b7cd9ae92f24a2d0049ad44c99ffab
Reviewed-on: https://chromium-review.googlesource.com/677883
Commit-Queue: Jialiu Lin <[email protected]>
Reviewed-by: Nathan Parker <[email protected]>
Reviewed-by: Luke Z <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512616}
Reviewed-on: https://chromium-review.googlesource.com/747044
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#317}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}GuestViewMessageFilter should update the embedder web contents before attach.
GuestViewMessageFilter::OnAttachToEmbedderFrame() up until now assumed
the guest was created with the WebContents* that will be the final owner.
This works for WebViews created in static HTML or from JS in the
embedder, but can fail if window.open is used, and the embedder
web contents may be created along with the new window.
This function should instead look up the embedder WebContents* from
the provided embedder local frame id, and use that to override in the
call to GuestViewBase::WillAttach().
[email protected]
(cherry picked from commit a21ff3d498fdbdc0114fad1cdd127f7675614eb5)
Bug: 777839
Change-Id: I4a33ecf3aaab6dbd645835191247670a3dccd1f3
Reviewed-on: https://chromium-review.googlesource.com/738278
Commit-Queue: James MacLean <[email protected]>
Reviewed-by: Lucas Gadani <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512399}
Reviewed-on: https://chromium-review.googlesource.com/747383
Reviewed-by: James MacLean <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#316}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Settings: Network: Show 'allow shared' in guest mode + unenforced policy
Currently we hide the control if any policy exists, even if it is not
enforced. This prevents enabling 'allow shared proxies' which prevents
user editing of the proxy values.
[email protected]
(cherry picked from commit e92c0f6988a0fe486c5a679f9a4492f5667c0dc4)
Bug: 774507
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I38a42400aa4929b4b43990cf10c22613e1118115
Reviewed-on: https://chromium-review.googlesource.com/736059
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511307}
Reviewed-on: https://chromium-review.googlesource.com/747065
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#315}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't use -1 in Mac OS native notification action index responses
The negative value used to represent that no action button was used, but
that has since been changed to use base::Optional instead. This is
causing code on Mac to unintentionally believe that a button was used
anyway, which can lead to unexpected behaviour.
BUG=774983
Change-Id: I8c13aff77b77772077c9145b705d84904eb67a55
Reviewed-on: https://chromium-review.googlesource.com/730753
Commit-Queue: Peter Beverloo <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511882}(cherry picked from commit 178f4e39143777e5db15a6b7abc992ceb33df4ce)
Reviewed-on: https://chromium-review.googlesource.com/746647
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#314}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[subresource_filter] Do not populate metadata for warning sites.
Currently, we populate website data metadata for sites which activate
as ENABLED. This metadata is used to trigger showing the "Ads" setting
in the settings UI, OIB, and page info.
However, we also activate as ENABLED for warning sites, and decrease
activation level downstream in the driver factory. This means that
warning sites will show up in the various settings UIs as having
intrusive ads.
This CL makes it so that warning sites do not populate the metadata.
[email protected]
Bug: 779673
Change-Id: I972faf6aeda6884b584c8383918fa7a9ba966b6c
Reviewed-on: https://chromium-review.googlesource.com/744442
Reviewed-by: Shivani Sharma <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512636}(cherry picked from commit 16139bbf766b741be3037d19dba381dfcc311d9c)
Reviewed-on: https://chromium-review.googlesource.com/746822
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#313}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}chromeos: Add --touchscreen-usable-while-screen-off.
Add a new flag that can be set to instruct
ash::PowerButtonDisplayController to keep the touchscreen
enabled after the screen is turned off due to inactivity.
Chromebases support wakeup from touchscreen devices, so this
flag can be set there to avoid an inconsistency where the
touchscreen turns the screen on when the device is in S3 but
doesn't when the system is in S0 with its screen off.
Bug: 778156
Change-Id: I56011cee39b0918084623bea035965fb6bb91425
Reviewed-on: https://chromium-review.googlesource.com/739754
Commit-Queue: Dan Erat <[email protected]>
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511903}
Reviewed-on: https://chromium-review.googlesource.com/746042
Reviewed-by: Dan Erat <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#312}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Fork M63] Revert refs/heads/master@{#486835} for android
The CL introduced an infinite gpu restart loop, on devices where gpu
consistently crashes early on start up. This is because android sets
kDisableGpuProcessCrashLimit.
This is supposed to be a revert of that CL but only for android.
Bug: 772049
Change-Id: I7f2f417273bff012afb55ce115ae9850a88ef4b3
Reviewed-on: https://chromium-review.googlesource.com/736163
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#311}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.27
[email protected]
Change-Id: I34d6cd87cccdac61ba286a49f878c6abae822143
Reviewed-on: https://chromium-review.googlesource.com/744927
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#310}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Updating XTBs based on .GRDs from branch 3239
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id9b5ccd7c8094920469d3eed9284052714b64e43
Reviewed-on: https://chromium-review.googlesource.com/745402
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#309}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[ios] SadTabCoordinator gets Webstate from SadTabHelper.
[email protected]
(cherry picked from commit dfef35bd476cf6138ddbe4835f40e96a542f804d)
Bug: 765407
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3e0e9b66b2e5d3f7adb63e1cb0ed54574c5ab66e
Reviewed-on: https://chromium-review.googlesource.com/734625
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512057}
Reviewed-on: https://chromium-review.googlesource.com/745281
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#308}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Don't let intrinsic padding skew pagination struts on table cells"
This reverts commit 818f2935aba99b00716f8ab2804c211d99c39f31.
Reason for revert: See https://crbug.com/778682 (br + a in table cell is not correctly positioned)
Original change's description:
> Don't let intrinsic padding skew pagination struts on table cells
>
> Bug: 768330
> Change-Id: Ic2ef22bbd3a533505c0cc4757b3758c6063cb35c
> Reviewed-on: https://chromium-review.googlesource.com/693881
> Reviewed-by: Morten Stenshorne <[email protected]>
> Commit-Queue: Robert Hogan <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#506225}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 768330
Change-Id: I4db77e4b4c8c41e1b3a417ed016525d6707df848
Reviewed-on: https://chromium-review.googlesource.com/742362
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512330}(cherry picked from commit c43a08fc7d2b3a2e3fb8ead1dcfc931ec3b5cd41)
Reviewed-on: https://chromium-review.googlesource.com/745062
Cr-Commit-Position: refs/branch-heads/3239@{#307}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Insertion selection content rect should also include the touch handle"
This reverts commit 1d980f6e63a287e63284b8fc56b69a78a8c37312.
Reason for revert: Apps that relied on WebView had some of their functionality break. See crbug.com/771891 and crbug.com/766459.
Original change's description:
> Insertion selection content rect should also include the touch handle
>
> The content rect that is used for positioning the floating selection
> menu didn't include the touch handle when the selection was not a
> range selection. This could lead to the floating menu occluding the
> handle. This CL adds the touch handle to the content rect.
>
> Bug: 765455
> Change-Id: Ie3f60f5fba7edd223cd3d91e208b483a9eacd2b4
> Reviewed-on: https://chromium-review.googlesource.com/667820
> Commit-Queue: Pedro Amaral <[email protected]>
> Reviewed-by: Alexandre Elias <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#502084}
[email protected], [email protected]
(cherry picked from commit ae740f9436314440bd18ab946a52a7d29107c5d2)
Bug: 765455
Change-Id: I47eea73915bbee88effc84e908f468f28fdc51c1
Reviewed-on: https://chromium-review.googlesource.com/741688
Reviewed-by: Pedro Amaral <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512259}
Reviewed-on: https://chromium-review.googlesource.com/744994
Cr-Commit-Position: refs/branch-heads/3239@{#306}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge-m63] Check IsTryingToQuit() after showing the modal first run dialog.
The modal first run dialog spins a RunLoop, which could process a SIGTERM
and invoke chrome::AttemptExit() via a posted task.
Currently startup continues and StartupBrowserCreator tries to open
browser windows. This triggers a CHECK() via the KeepAliveRegistry
on Mac and uploads a crashdump. On Linux, the process effectively
ignores the SIGTERM and stays running, but the signal handler stops
functioning.
To fix, check browser_shutdown::IsTryingToQuit() after showing the
dialog and exit if it's set.
download Chrome from the Internet (the install must be "Organic") and,
on a device without any enterprise policy, run Chrome. The First Run
dialog should appear (see http://crbug.com/777660). In a terminal, run:
Mac: `killall -TERM 'Google Chrome'`
Linux: Run chrome from the terminal, press Ctrl+C.
Chrome should immediately exit without crashing (run Chrome again,
check chrome://crashes).
[email protected]
(cherry picked from commit f4ebf5168d0f148b49022c9549d28600412507a2)
Test: (on Mac and Linux) Completely remove Chrome's User Data Dir,
Bug: 772329
Change-Id: Ie6135fa817774bce5ebd18bb116433bb555594cf
Reviewed-on: https://chromium-review.googlesource.com/734961
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511312}
Reviewed-on: https://chromium-review.googlesource.com/745081
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#305}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix animation-end event trigger in Contextual Search
This change fixes a bug in contextual search that would cause a
navigation that would ordinarily open a different app to also open
a new tab and expand an empty panel. The tab creation logic in
contextual search is driven off of whether or not the panel is in
the fully expanded state, which normally happens when tapping a link.
Since the animation replacement patch, the animation-end event is
mistakenly over-triggered, particularly when an animation is canceled.
This would cause the panel to think it was open and create a new tab.
The existing animation listener has been replaced by a cancel-aware
one.
BUG=778998
[email protected]
(cherry picked from commit 3a7dfadbebd4fad9f49db29009c413aef616a479)
Change-Id: Idfaa8efbec952c9df68b9e91c6a8c306acb456ae
Reviewed-on: https://chromium-review.googlesource.com/742323
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512358}
Reviewed-on: https://chromium-review.googlesource.com/744600
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#304}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Update accesibility string description
BUG=778866
Change-Id: Id01cac466ab9d47c82680655d61b887c5e08701b
Reviewed-on: https://chromium-review.googlesource.com/741081
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512326}(cherry picked from commit 9c146162caf98ed27a194a798fb064389da04493)
Reviewed-on: https://chromium-review.googlesource.com/745061
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#303}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix dangling discovery session during suspend/resume.
Chrome's last Stop() discovery session failed due to bluetooth adapter
missing temporarily during suspend. This makes Chrome thinks that there
is still a discovery session but actually there is not.
This fix works by forcing Chrome to deactivate all bluetooth discovery
sessions even though the last Stop() discovery session fails.
BUG=777953
TEST=Tested under frequent suspend/resume that bluetooth discovery
session is never stuck anymore.
[email protected]
(cherry picked from commit 68298244a0d61856cc118ca9da25407e28c44410)
Change-Id: If32aec101ea6363856b8d9efcf56cd7944eb2cce
Reviewed-on: https://chromium-review.googlesource.com/737056
Reviewed-by: Miao-chen Chou <[email protected]>
Reviewed-by: Rahul Chaturvedi <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511675}
Reviewed-on: https://chromium-review.googlesource.com/744963
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#302}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Tracing: fix use-after-destruction at shutdown
The patch moves resources that are accessed from the background task
runner from Coordinator to Coordinator::TraceStreamer so that the new
object can be deleted on the background task runner. Then when
the coordinator is destroyed at shutdown, which is after the service
manager is brought down, it destroys Coordinator::TraceStreamer on the
background task runner so that we do not have use-after-destruction
issues.
Crash scenario: the service manager in the browser is shutdown before
the task scheduler. When service manager shuts down, the resource
coordinator service, and consequently the tracing coordinator, is
destroyed, on the UI thread. But the task scheduler may still be
running background tasks. So, background tasks should not access
tracing coordinator fields or there will be a race.
BUG=774276
[email protected]
(cherry picked from commit e95eac03906173714becf8a7f36b10426faa67ab)
Change-Id: I233932c5ebdd707ee8a3c71846d59d761d64458e
Reviewed-on: https://chromium-review.googlesource.com/723822
Commit-Queue: Ehsan Chiniforooshan <[email protected]>
Reviewed-by: oysteine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512333}
Reviewed-on: https://chromium-review.googlesource.com/744902
Reviewed-by: Ehsan Chiniforooshan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#301}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[DeviceService] Fix a bug that chrome.serial.getConnections never return
This CL fixes the bug:
1. chrome.serial.connect(port) --> got connection_id1
2. chrome.serial.disconnect(connection_id1) --> ok
3. chrome.serial.getConnections(cb) --> cb never be triggered!
BUG=777552
TEST=browser_tests --gtest_filter=SerialApiTest.SerialFakeHardware
Change-Id: I34c941c2141ab6555e1f26b59c547763acfea22d
Reviewed-on: https://chromium-review.googlesource.com/741522
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Han Leon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512382}(cherry picked from commit 8864b268ce2c9cdb6f6d77ceea774c56b6e82a8a)
Reviewed-on: https://chromium-review.googlesource.com/744761
Cr-Commit-Position: refs/branch-heads/3239@{#300}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Media Router] Record channel connect result as enum instead of boolean
"MediaRouter.Cast.Channel.ConnectResult" is recorded as enum at extension
side, but as boolean at browser side, causing Chrome crash. Changed to
record connect result as enum as well at browser side.
Bug: 778761
Change-Id: I9b4270091a4b061660301fa36f9630e23abc628b
Reviewed-on: https://chromium-review.googlesource.com/740563
Commit-Queue: Bin Zhao <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512052}(cherry picked from commit 7c3ecc068e20da5fc83908efed8a5135f3927fdd)
Reviewed-on: https://chromium-review.googlesource.com/744741
Reviewed-by: Bin Zhao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#299}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "Rename CSS scroll-boundary-behavior to overscroll-behavior"
Updated core/BUILD.gn to replace old references with new ones.
I cannot find a trybot that runs the noop builder test. So I did
the following to help ensure this does not break noop builders:
(1)
- Run: ninja -w 'dupbuild=err' -C ./out/default/ -j 1024 chrome all
(on a clean directory)
- Run: ninja -w 'dupbuild=err' -C ./out/default/ -j 1024 chrome all
Without my changes the second build was doing work but with my change
the second build does nothing. AFAICT no-op test expect the second one.
(2) grep -R "PropertyAPIScrollBoundary"
Made sure the above does not find anything given that those files are
renamed.
This is a reland of 74e8a0f74fc589a58258655f59aa7f1efa666155
Original change's description:
> Rename CSS scroll-boundary-behavior to overscroll-behavior
>
> The name change was decided here [1].
>
> This is the minimal patch to change the publicly exposed CSS property.
> It is intentionally small to make it easier to merge with M63. So,
> internally Blink and content still use ScrollBoundaryBehavior name which will
> be updated in the follow up patch larger patch.
>
>
> [1] https://github.com/WICG/scroll-boundary-behavior/issues/24
>
> Bug: 776776
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Iaa6ad62253ed7fe9ed7f0ee9865ffda852b17801
> Reviewed-on: https://chromium-review.googlesource.com/737090
> Reviewed-by: Dimitri Glazkov <[email protected]>
> Reviewed-by: Sandra Sun <[email protected]>
> Commit-Queue: Majid Valipour <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#511493}
[email protected]
(cherry picked from commit 24c13771fb5a3f5d72bcd69ef1980d23ee030cf2)
TBR: [email protected], [email protected]
Bug: 776776
Change-Id: I319c110bb27181fed7b3e1c75ae0534928958612
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/740061
Reviewed-by: Majid Valipour <[email protected]>
Commit-Queue: Majid Valipour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511985}
Reviewed-on: https://chromium-review.googlesource.com/743699
Cr-Commit-Position: refs/branch-heads/3239@{#298}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Chrome OS: make Offline Gaia screen animations smooth.
Offline Gaia screen has two blocks which must be animated synchronously.
<neon-animated-pages> (deprecated) are not suitable for this, so
this CL replaces it with pure CSS animations.
[email protected]
(cherry picked from commit 898c7b4e90619244d3b9ace8c3249e0e7b8a4f7d)
Bug: 771556
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie108f1bcf4a6c911654c05933919cc33297e192c
Reviewed-on: https://chromium-review.googlesource.com/734581
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511583}
Reviewed-on: https://chromium-review.googlesource.com/744316
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#297}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Domain Reliability: Move setup from ProfileImplIOData to ProfileIOData.
[email protected]
(cherry picked from commit ddf263cd59d256d87cfd8dd6bbdfac1ae7412995)
Bug: 777581
Change-Id: Ic556ed0d0fbde98fc663791dfdc1d6dcad5749aa
Reviewed-on: https://chromium-review.googlesource.com/735746
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Julia Tuttle <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512243}
Reviewed-on: https://chromium-review.googlesource.com/744441
Reviewed-by: Julia Tuttle <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#296}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Do not tear down Tether on screen lock.
This is only an intermediate CL with the bare minimum of
changes necessary, in order to reduce its risk impact when
merged into 62. A subsequent CL that will completely rip out
all lock screen logic will land after this, but will not be
merged into 62.
BUG=778785
Change-Id: Icf02c734795f6809f14087c0a96ff3a9e4fa4086
Reviewed-on: https://chromium-review.googlesource.com/742741
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512367}(cherry picked from commit d60e0e70d1b3b3a4d314a1e5f6ba0405c829fca4)
Reviewed-on: https://chromium-review.googlesource.com/744287
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#295}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Disable password exporting
During maintenance on the code surrounding the export feature, this CL
disables the ability to export passwords.
It does so by disabling PasswordManagerPresenter::GetAllPasswords,
which works but leads to an awkward UI (Chrome lets the user choose
the destination, but then exports an empty CSV there). This is to make
merging to M63 easier: unlike other pieces of code handling export,
GetAllPasswords has not been affected by the recent churn on
https://crbug.com/700003, it looks the same in M63 and on trunk. The
awkward UI does not matter, because the feature is behind the flag.
This CL should be reverted on trunk once https://crbug.com/700003 is
fixed.
[email protected]
(cherry picked from commit 318185ae44ef9416beac653a7b94c24f022e5f1a)
Bug: 778987
Change-Id: Iea21f2817c87ab194409059410b9ba841db809b3
Reviewed-on: https://chromium-review.googlesource.com/741229
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Vaclav Brozek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512152}
Reviewed-on: https://chromium-review.googlesource.com/744203
Cr-Commit-Position: refs/branch-heads/3239@{#294}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Verify persistent memory exists.
Ensure during allocation that the allocated segment is fully writable.
This should concentrate all related errors into this one place making it
easier to monitor such failure. It will also allow for future handling
of the condition.
[email protected]
(cherry picked from commit db690e2d96189eccda2792775ed3d0fb3cf4e11a)
Bug: 753741
Change-Id: I4e82d4f8a35c9066dd552915bb76fc333f9602cf
Reviewed-on: https://chromium-review.googlesource.com/737551
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511913}
Reviewed-on: https://chromium-review.googlesource.com/743851
Reviewed-by: Brian White <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#293}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Settings: Network: Fix Cellular siminfo
[email protected]
(cherry picked from commit ff9a7b68e03c099d030c5b242441b03d2965efba)
Bug: 776901
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id07479771abd6bf1eacfdc0abc13bbcfb12b6d25
Reviewed-on: https://chromium-review.googlesource.com/730849
Reviewed-by: Ben Chan <[email protected]>
Commit-Queue: Ben Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510653}
Reviewed-on: https://chromium-review.googlesource.com/744182
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#292}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Settings > Network > Choose Mobile fixes
* Disable 'scan' button while connected
* Move 'Scanning...' and 'Scan completed' to secondary text line
* Show 'Disconnect to enable scanning' in secondary text when connected
(and there is no other scan status).
* Hide SIM UI until Cellular properties load to avoid incorrect red
'SIM card missing' text while loading.
[email protected]
(cherry picked from commit 854791c2fac4ad1ad7aa2857ea64933ec6a4341b)
Bug: 773131, 774401
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I843fc6efd5f19137a63a1f12a1389e4ee55a9c8f
Reviewed-on: https://chromium-review.googlesource.com/716864
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Ben Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509097}
Reviewed-on: https://chromium-review.googlesource.com/744181
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#291}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Do not bypass data reduction proxy on net errors that arise due to
origin errors.
When invalid response headers are received, data reduction proxy may be
bypassed depending on the net error code. This CL prevents the
proxy from being bypassed if the net error code was generated
due to problems related to origin, and not due to network issues
or the proxy.
Bug: 770789
Change-Id: Ice781f4fcf949c0459cab462ccd83c9282afb69f
Reviewed-on: https://chromium-review.googlesource.com/732736
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510857}(cherry picked from commit 047ab646681f10a1ea0ccd2e8f7fcbe83e8cc5db)
Reviewed-on: https://chromium-review.googlesource.com/743283
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#290}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Network: Dialogs: Fix l10n
When the internet detail and config .html files were converted
to stand-alone dialogs with no extra wrapper the html formatting
was incorrect, causing l10n to fail.
This CL fixes that issue and ads a bit of additional cleanup to how
the dialogs are built, including the removal of an unnecessary call
to DisableContentSecurityPolicy().
[email protected]
(cherry picked from commit f4678ff108d0b4f0073bfd526cfc99a50e762074)
Bug: 777667
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If227215fd7d6037672302c3062ddd7234d97c712
Reviewed-on: https://chromium-review.googlesource.com/737536
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511630}
Reviewed-on: https://chromium-review.googlesource.com/744103
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#289}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Retry URL request if invalid response headers are received from data saver proxy
If Chrome receives invalid response headers from a data saver proxy,
it marks the proxy as bad, and retries the request.
Bug: 770789
Change-Id: Iec05f770bd7609ce0cea7c8a3be00f96dffcadbd
Reviewed-on: https://chromium-review.googlesource.com/719891
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510448}(cherry picked from commit 0c41da746b82bf1fca4ede3671d5c9c2c11a0437)
Reviewed-on: https://chromium-review.googlesource.com/743282
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#288}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Display modal permission prompts in RTL locales correctly.
This patch fixes modal permission prompts so that in RTL:
- The text direction is RTL as per the locale, instead of following the
first strong directional character (typically the first character of
the URL)
- The icon occurs on the right side of the dialog (i.e. before it)
Bug: 774926
Change-Id: I8677cf61c30bdce95113e0e414531c343ed302c2
Reviewed-on: https://chromium-review.googlesource.com/722382
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509637}(cherry picked from commit c42dbc153f640bc389f713b1d6001cec5d9354e8)
Reviewed-on: https://chromium-review.googlesource.com/742723
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#287}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.26
[email protected]
Change-Id: I1ad0aa35af5370cc4e6536435f7a168e5e1492b9
Reviewed-on: https://chromium-review.googlesource.com/742547
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#286}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.25
[email protected]
Change-Id: I0f13e001da78baf2d5822cf3f5f1f71b0ff28d40
Reviewed-on: https://chromium-review.googlesource.com/742545
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#285}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.24
[email protected]
Change-Id: Ibcebf43d9b0abc08d8b83eba130d83eef004a76d
Reviewed-on: https://chromium-review.googlesource.com/742423
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#284}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland [ios] Inserts and deletes history items in the same BatchUpdates block
Original CL at https://codereview.chromium.org/2800473004/
The theory is that performBatchUpdates processes deletion indexes in a
first pass, and then processes insertion indexes. The original CL
created insert indexes first, and then deletion indexes, which is the
suspected reason for needing the rollback. This CL addresses this by
deleting first, and then inserting. The performance ramification is
that we now pay the cost of constructing the array of items on all
query returns, not just when filtering is needed.
The only other change between this and original is that the filtering
method is renamed.
[email protected]
(cherry picked from commit a0c9194bc3239a2e3055667504e48238f80a7f23)
Bug: 707241, 776111
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I93f0aa9f8d65c43094c1d6ec86eda5565432b4ff
Reviewed-on: https://chromium-review.googlesource.com/730655
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511895}
Reviewed-on: https://chromium-review.googlesource.com/742358
Cr-Commit-Position: refs/branch-heads/3239@{#283}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add more unit tests for task scheduling
Add some more tests and expectations for task scheduling. These tests
are a first step, with a followup set coming when the task scheduler
code is refactored post 63. This adds:
- A test validating that device listener states aren't used when the
network listener isnt' valid.
- A test validating that we don't queue or cancel download tasks in
the middle of running one.
- A test validating that we don't queue or cancel cleanup tasks in the
middle of running one.
BUG=777090
[email protected]
Change-Id: Icbcf32d132f0e7fea6a4ac177f4336e6bcf467a4
Reviewed-on: https://chromium-review.googlesource.com/740372
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512014}(cherry picked from commit d4af8b9a73a5bd126a7791ad42eeaa0b0ad75947)
Reviewed-on: https://chromium-review.googlesource.com/742350
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#282}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix BackgroundTaskScheduler API usage
We were calling the background task scheduler in a way that did not
work across GCM and JobScheduler API differences (always hammering the
API with schedule()/cancel() calls even when we were already in a Job).
This caused the job to fail and cancel prematurely and had seemingly
undefined behavior from the OS.
The Controller also had a potential use-after-free issue in Entry when trying to schedule work downloads when one has failed in a certain way. The changes in this patch address address this as well.
This new patch limits the calls to when we are not currently inside of a
job.
BUG=777090
[email protected]
Change-Id: If0425d43349e4c0c81d172624ca6b3d1890887bd
Reviewed-on: https://chromium-review.googlesource.com/737054
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511394}(cherry picked from commit 2a5c347a10fce3d45bdbf40f39c1d5534e555850)
Reviewed-on: https://chromium-review.googlesource.com/742389
Cr-Commit-Position: refs/branch-heads/3239@{#281}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Hide ARC VPN behind a feature flag
The UI work will be completed in the M64 timeframe, so for M63 we
will require ARC VPN to be manually enabled via chrome://flags#arc-vpn
BUG=696865
TEST=manually test in both Enabled and Disabled state
(cherry picked from commit b7f96a5e6d6b07dde77de608e680d6c51658e4b0)
Change-Id: I5e362f2437629980c69dcfcef60a11786131e986
Reviewed-on: https://chromium-review.googlesource.com/736817
Commit-Queue: Kevin Cernekee <[email protected]>
Reviewed-by: Elijah Taylor <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511507}
Reviewed-on: https://chromium-review.googlesource.com/742685
Reviewed-by: Kevin Cernekee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#280}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Settings: Display: Use isTabletMode to disable orientation
[email protected]
(cherry picked from commit 1b83546e0509a53e5bced7eaaa654252a15c63b9)
Bug: 777587
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4f4be9848269fa38d737c3a2c5f9b1a4cfb030d4
Reviewed-on: https://chromium-review.googlesource.com/736021
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511532}
Reviewed-on: https://chromium-review.googlesource.com/742460
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#279}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63] Fix cherry-pick of crrev.com/c/740103
M63 branch uses old WebStateObserver callbacks without WebState
parameters.
Bug: 773895
Change-Id: If2ab994d6127fc855f6042dbae14122aa5eb0c7f
Reviewed-on: https://chromium-review.googlesource.com/742446
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Rohit Rao (ping after 24h) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#278}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Devtools] Removes 'ref' (#) from url before browser protocol event
Removes the ref from a url of a browser Network.Request object.
R=dgozman,pfeldman
BUG=776194
Change-Id: I1238f61adcea093c949746b7cafaefb6e58ab531
Reviewed-on: https://chromium-review.googlesource.com/726822
Commit-Queue: Blaise Bruer <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510386}(cherry picked from commit 5818fa1c113533a8eabaaa7311b2ffec3c446d2e)
Reviewed-on: https://chromium-review.googlesource.com/742363
Reviewed-by: Andrey Lushnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#277}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Destroy Select Action Mode when entering fullscreen
[email protected]
(cherry picked from commit 33a88c6737489e597802a4f64e4b340dc06517cf)
Bug: 763805
Change-Id: I64aad634ec6eb2d7050c35f2d546defdde6183fb
Reviewed-on: https://chromium-review.googlesource.com/726747
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511520}
Reviewed-on: https://chromium-review.googlesource.com/742133
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#276}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Add context menu flag to CommonNavigationParams
Plumbing started_from_context_menu to CommonNavigationParams so it can
be correctly seen by ArcNavigationThrottle even when PlzNavigate is
enabled by default.
Bug: 777990
Test: Try.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I969edbb39d0d12d2a4a6d7d26a2ef4e3d72a7b7a
Reviewed-on: https://chromium-review.googlesource.com/736310
Commit-Queue: David Jacobo <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511332}(cherry picked from commit 7508e0b389ba961001e69c5ce18984c8aadea449)
Reviewed-on: https://chromium-review.googlesource.com/742385
Reviewed-by: David Jacobo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#275}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Check for browserState before presenting IPH Bubbles.
When BVC checks for whether the In Product Help Bubbles should be shown,
self.browserState must not be null, or a crash occurs. viewDidAppear can
be called after self.browserState is destroyed, so this CL protects
the method call with an if statement. The CL also adds DCHECKs for the
existence of self.browserState in the various bubble presentation
methods.
Bug: 776917
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7264db612f55814a8f16ca12a4ae970b536ea126
Reviewed-on: https://chromium-review.googlesource.com/734198
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Gregory Chatzinoff <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511318}(cherry picked from commit 541b864f7aa3820604ad0a8d692d975bab4c2600)
Reviewed-on: https://chromium-review.googlesource.com/742242
Reviewed-by: Gregory Chatzinoff <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#274}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Use appContext to show download manager
When firing an intent to show the downlaod manager in Chrome Home, use
the application context instead of the activity context. When using the
activity context, ChromeTabbedActivity wasn't getting brought to the
foreground as expected.
Also add tests to verify the original crash fix does not regress.
BUG=777284
[email protected]
(cherry picked from commit 5dd574d005545324fc741ac82b2b39dab38b1bad)
Change-Id: Ie4e2bdd1f27aad16a1edde841386fec3de7bd5b6
Reviewed-on: https://chromium-review.googlesource.com/734812
Commit-Queue: Theresa <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511595}
Reviewed-on: https://chromium-review.googlesource.com/742342
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#273}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Change opt out snackbar fieldtrial name
BUG=778092
Change-Id: Ie42f3e01b5b6d4713137a8053d38d00c7795149e
Reviewed-on: https://chromium-review.googlesource.com/738491
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512003}(cherry picked from commit e4de67068681c0fcdfbab73ee4efd2b117caa940)
Reviewed-on: https://chromium-review.googlesource.com/742302
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#272}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.23
[email protected]
Change-Id: I824bae1022c9b99841ace364e5629995ec767987
Reviewed-on: https://chromium-review.googlesource.com/741893
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#271}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Enable LoadingWithMojo for webview since it doesn't use Finch.
BUG=778044
Change-Id: Id6a82f4ee86c30dd8045a5ebea527f44ae3639fd
Reviewed-on: https://chromium-review.googlesource.com/738831
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511657}(cherry picked from commit 6917671eb785e39d526dc11f1a9c4cd669669d95)
Reviewed-on: https://chromium-review.googlesource.com/742301
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#270}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Record which NavigationItems were created for voice searches.
In iOS11, there is a slight delay before a navigation is started, so
Tab's property was being rewritten to NO. By using
VoiceSearchNavigations, this state is associated with the
NavigationItems themselves. This ensures that the voice search bar
is shown and that the TTS results are properly played.
This is patch 3 of a 3-sided patch. It must be landed after
crrev.com/c/740103 and its associated downstream fix.
[email protected]
(cherry picked from commit 90ced7d4faeb9d8a0c48d6dcb382b213c03adba7)
Bug: 773895
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I89ec5abb5c3f779d14bc2854f440a5ad361e185c
Reviewed-on: https://chromium-review.googlesource.com/740086
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512082}
Reviewed-on: https://chromium-review.googlesource.com/742264
Cr-Commit-Position: refs/branch-heads/3239@{#269}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.22
[email protected]
Change-Id: Iad14a749464f3bec4796d6670b48d018b4c6c222
Reviewed-on: https://chromium-review.googlesource.com/741783
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#268}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Record which NavigationItems were created for voice searches.
In iOS11, there is a slight delay before a navigation is started, so
Tab's property was being rewritten to NO. By using
VoiceSearchNavigations, this state is associated with the
NavigationItems themselves. This ensures that the voice search bar
is shown and that the TTS results are properly played.
This is patch 1 of a 3-sided patch. It must be landed before
its associated downstream patch and crrev.com/c/740086.
[email protected]
(cherry picked from commit 208a1e87a413d81379e1d8c607114621592d6c21)
Bug: 773895
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If24a088006ddc41dd9277a4b04588cac32d06c4d
Reviewed-on: https://chromium-review.googlesource.com/740103
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#512059}
Reviewed-on: https://chromium-review.googlesource.com/742123
Cr-Commit-Position: refs/branch-heads/3239@{#267}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix merge conflicts
[email protected]
Bug:
Change-Id: I79987953177f7106163fafc03c8923c33148fcd8
Reviewed-on: https://chromium-review.googlesource.com/740874
Reviewed-by: apacible <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#266}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix merge conflicts
[email protected]
Bug:
Change-Id: I8bf48994a328f7a7ecb41cb03fd347460662e848
Reviewed-on: https://chromium-review.googlesource.com/740872
Reviewed-by: apacible <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#265}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Inject windowID when web view content is an image.
The system context menu is now always blocked, so we must use our own
to allow interaction with image content. We must inject the windowID
because our context menu implementation relies on injected javascript.
Bug: 777313
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0c0c5515c3fe99e5f7db6d963c0cdc1ec84940ac
Reviewed-on: https://chromium-review.googlesource.com/735121
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511214}(cherry picked from commit c47b1f13138b9f12b01da22ab11a82a8cf639bcc)
Reviewed-on: https://chromium-review.googlesource.com/740946
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#264}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Remove DCHECK expecting the top safearea of the infobar to be 0.
During the presentation animation of the Camera Scanner, the BVC (which
is a superview of the infobars) scrolls up offscreen.
This was triggering the DCHECK.
Bug: None
Change-Id: If2ca09c10ef26a281d3de52fd12a815a4c14ce0d
Reviewed-on: https://chromium-review.googlesource.com/723620
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Jean-François Geyelin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509422}(cherry picked from commit 7da0bdc24c99018971db6b6387e17586278bb502)
Reviewed-on: https://chromium-review.googlesource.com/741763
Reviewed-by: Jean-François Geyelin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#263}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Prevent the omnibox from being squashed.
The toolbar contains subviews positioned with autoresizing masks.
The margins used by the autoresizing masks get squashed if the
toolbar's width is set to 0. The toolbar's width is set to 0 when
the toolbar is moved out of the view hierarchy.
In order to prevent this, this CL adds a constraint on the minimal
toolbar width.
To have this constraint stick around required *not* removing
all of the toolbar's constraints when the toolbar changed superview
(i.e. *not* calling |[self removeConstraints:self.constraints];| from
|-willMoveToSuperview:|).
In turn, not automatically removing constraints meant that the
constraint on the height of the toolbar (unlike the
leading/trailing/top constraints which were attached to anchors and
thus automatically removed when the view is reparented) was not
getting automatically removed when the toolbar was reparented.
This is why this CL moves the ownership of the height constraint
out of the BVC/NTP, and into the ToolbarController.
This CL also makes the StackView's toolbar be positioned with
autolayout (and respond to safe area changes).
Bug: 773640
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2e9b3a59bf80f53c22285aff1595f79df54daefe
Reviewed-on: https://chromium-review.googlesource.com/733163
Commit-Queue: Jean-François Geyelin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511420}(cherry picked from commit bead99874c0f63f1ddf66963cd1af613b4a6531e)
Reviewed-on: https://chromium-review.googlesource.com/741562
Reviewed-by: Jean-François Geyelin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#262}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[iOS] Update the initial header height at every Pull To Action start.
Before this CL, the "initial header height" was only set when the
CRWWebController changed.
Since the iPhone X, the header height can change when the orientation
changes.
With this CL, the header height is set whenever the Pull To Action
flow starts.
Note that an on-going Pull To Action is cancelled if the screen is rotated,
so the header height can't change in the middle of a Pull To Action.
Bug: 773643
Change-Id: I6891d5da8de610d8cbfcab0f880c6f807ec98df5
Reviewed-on: https://chromium-review.googlesource.com/718099
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Commit-Queue: Jean-François Geyelin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#508742}(cherry picked from commit 9053173ab0cfd184114ed9dab0294e6865cf458b)
Reviewed-on: https://chromium-review.googlesource.com/741503
Reviewed-by: Jean-François Geyelin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#261}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}ui: Add new geo default user images.
This adds a new set of geometric figure images.
BUG=721647,763216
[email protected]
(cherry picked from commit 3e17497f3579fc221310f9452be1129e1f9103f0)
Change-Id: I415a6d201e78852f1e274bf98effa47e92764a69
Reviewed-on: https://chromium-review.googlesource.com/576998
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509164}
Reviewed-on: https://chromium-review.googlesource.com/741342
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#260}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Files App: Remove notifications for external drive rename
This CL removes notifications to indicate successfully completed and
pending operation of an external drive rename. Related strings will be
removed in CL:722460.
Bug: 775018
Test: browser_tests --gtest_filter=FileManagerJsTest.DeviceHandlerTest
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3eb43a6f4cc4f53214e074813e04f561262d7767
Reviewed-on: https://chromium-review.googlesource.com/722140
Commit-Queue: Klemen Kozjek <[email protected]>
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509315}(cherry picked from commit f07ee0890c5184f72df6ebfa8e66dff0b95c4b33)
Reviewed-on: https://chromium-review.googlesource.com/741281
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#259}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.21
[email protected]
Change-Id: I704b6f42b9bad94152ee71af629e0e77812cb14b
Reviewed-on: https://chromium-review.googlesource.com/740684
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#258}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix bad merge in 04244f9a
TBR: [email protected]
Bug: 778850
Change-Id: I4c72e0d7d9f6d6796cf2df6cb304864a5b4ec097
Reviewed-on: https://chromium-review.googlesource.com/740983
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#257}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Raise renderer process limit on Chrome OS for all boards
After running an experiment on Caroline with the renderer process
limit raised to 100, we saw a decrease in the overall number of tab
discards and no increase in the number of kernel OOM kills, so this
seems like a better policy that makes the tab discarder more
effective.
[email protected]
(cherry picked from commit 8048987c7f5fa6f31d66930b7b879c2d33cc1a60)
Bug: 743170
Change-Id: I83e1ee996e028608dc906896e15cc60afe512e5b
Reviewed-on: https://chromium-review.googlesource.com/729495
Commit-Queue: Sonny Rao <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511372}
Reviewed-on: https://chromium-review.googlesource.com/741034
Cr-Commit-Position: refs/branch-heads/3239@{#256}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63]CUPS: Fix the crash caused by accessing an invalid printer configuration.
The crash happens when the user try to get a CUPS printers list from
user sync preferences. However, it's possible that GetPrinterInfo()
returns a null pointer. In this case, when the printers list tries to
append the returned value to the list, it will try to use * to get the
value the pointer points to, then Chrome will crash if it's a null
pointer.
However, I think the root cause here is that we should not allow adding
invalid configured printer into user sync preferences. It will be
addressed later.
Bug: 778383
[email protected]
(cherry picked from commit 78c60ade72baed6c78fa3e6b8fd14248d397774c)
Change-Id: I5b1987ed67d0c639721e15beba130255e781ab09
Reviewed-on: https://chromium-review.googlesource.com/740081
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511938}
Reviewed-on: https://chromium-review.googlesource.com/740903
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#255}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}viz: Do not use root render pass size in lieu of output surface size.
On Windows with Direct Composition enabled, we want to set the root
damage rect to the output surface (display) size after a resize, but use
the root render pass output rect instead. The output surface size may
differ from root render pass output size because rendering is
asynchronous with respect to resize.
Futhermore, we disable swaps in between the WindowPosChanging and
WindowPosChanged messages (DisableSwapUntilResize) by setting display
size to zero. We normally skip drawing in flight compositor frames
because the display and surface sizes don't match. However, if copy
output requests are present we try to draw and fail in SetDrawRectangle
because the damage is calculated from root render pass output rect which
is larger than display size of zero.
This manifested in a GPU process crash on minimizing the window in the
presence of a copy output request from the thumbnail helper.
R=danakj, piman
[email protected]
BUG=773199
TEST=GLRendererPartialSwapTest.SetDrawRectangle*
(cherry picked from commit 6015a99b8843d7eceea6868d7a83166007e8bf89)
Change-Id: I5a037de38866a64bcd83a04a9b9dca9e682a2454
Reviewed-on: https://chromium-review.googlesource.com/734170
Commit-Queue: Sunny Sachanandani <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: ccameron (ping after 24hr) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511328}
Reviewed-on: https://chromium-review.googlesource.com/740661
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#254}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] Move getMatchedCSSRules removal to M64.
This patch changes the removal milestone for getMatchedCSSRules to M64.
Only changes the deprecation message string.
[email protected], [email protected]
Bug: 437569
Change-Id: I6f46c4d7abc137ca33601291b64465477075031e
Reviewed-on: https://chromium-review.googlesource.com/737709
Commit-Queue: nainar <[email protected]>
Reviewed-by: meade_UTC10 <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511469}(cherry picked from commit dc5db0319f9ac3977d0541da4b3b9ce9d2e8c1fb)
Reviewed-on: https://chromium-review.googlesource.com/740581
Reviewed-by: Darren Shen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#253}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] Revert "Add runtime flag to turn off getMatchedCSSRules."
This reverts commit d8898de32b729792f6d5bacd9131a10fc63427bc.
Reason for revert: See bug.
Original change's description:
> Add runtime flag to turn off getMatchedCSSRules.
>
> This patch adds a runtime flag for getMatchedCSSRules and turns it off
> completely. This will allow us to disable getMatchedCSSRules
> in M63 whilst making it easier to turn the feature back on again in case
> anything goes wrong.
>
> [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/fd-QLCiLESQ/_mfowSsRR8oJ
>
> [2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/-_Al0I5Rm9Q/PDzupcoxAwAJ
>
> Bug: 437569
> Change-Id: I2d022a3b03d4ec1297248563acd598c9fc7ccf9a
> Reviewed-on: https://chromium-review.googlesource.com/644831
> Commit-Queue: Darren Shen <[email protected]>
> Reviewed-by: Kent Tamura <[email protected]>
> Reviewed-by: meade_UTC10 <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#501076}
[email protected], [email protected], [email protected]
(cherry picked from commit 5510e7b40bf4a82a02862aba65aefccb453f245d)
Bug: 437569
Change-Id: Ia20e5fc973040f10081e641d0d4c85fcf377cf15
Reviewed-on: https://chromium-review.googlesource.com/737609
Commit-Queue: nainar <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Reviewed-by: meade_UTC10 <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511466}
Reviewed-on: https://chromium-review.googlesource.com/740461
Cr-Commit-Position: refs/branch-heads/3239@{#252}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Count uses of navigator.getBattery which would be blocked by spec
The most recent Battery Status API specification says that calls to getBattery
from secure contexts, or from frames which are cross-origin with the top-level
document, should return a promise which rejects. This doesn't match Chrome's
implementation, so this CL adds use counters to evaluate the real-world effects
that aligning with the spec would have.
[email protected]
(cherry picked from commit 40b9767c09612064d25a3470caf175d093f3c94a)
Bug: 747610
Change-Id: I2b0a387b1e61510700191946e345d9cef9a10e69
Reviewed-on: https://chromium-review.googlesource.com/733865
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511243}
Reviewed-on: https://chromium-review.googlesource.com/740601
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#251}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix a null pointer dereference bug in GetDiscoveryNetworkInfoListImpl.
The 'ifa_addr' field of an 'ifaddrs' struct returned by getifaddrs() may
be a null pointer. This CL adds a nullptr check in
GetDiscoveryNetworkInfoListImpl to prevent a potential null pointer
dereference issue.
Bug: 778132
Change-Id: Ia54057d1e7afb6d68635ce8291ec612dde025e03
Reviewed-on: https://chromium-review.googlesource.com/739744
Reviewed-by: Derek Cheng <[email protected]>
Commit-Queue: Ben Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511843}(cherry picked from commit 5b7dbba5e2197f9e316e9908e3f050cace7a6888)
Reviewed-on: https://chromium-review.googlesource.com/740501
Reviewed-by: Ben Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#250}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}To M63: Cannot compile media/filters/source_buffer_stream.cc with GCC
Make the BufferingByPts() static to be able to compile it with GCC 6.3.
Clang compiles fine as well as GCC 7.2+.
Upstream GCC bug - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66297
[email protected]
Bug: 777391
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9a3d0b1ad9abaff245f6a7ac540591acd990f106
Reviewed-on: https://chromium-review.googlesource.com/733121
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Matthew Wolenetz <[email protected]>
Commit-Queue: Matthew Wolenetz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511352}(cherry picked from commit 2083a5d15cbbe84b87e02075e397e6b1dcf1f4ca)
Reviewed-on: https://chromium-review.googlesource.com/740321
Cr-Commit-Position: refs/branch-heads/3239@{#249}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix crash in 'Guest mode' when navigate to chrome://interventions-internals.
Check for PreviewsService before initialize sources, display error
message saying that the page is not supported in 'Guest Mode'.
Screenshot: https://drive.google.com/open?id=0B_MBksOU85S3ZVRZWGNJd2ZJVnc
Bug: 777323
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5c4a6dc40381d600d4d017d58e9fb85516df8f9c
Reviewed-on: https://chromium-review.googlesource.com/733853
Commit-Queue: Thanh Le <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Tim Sergeant <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511375}(cherry picked from commit c489f2c7dca913aa85f6cd3a8d23419086c8df59)
Reviewed-on: https://chromium-review.googlesource.com/739763
Cr-Commit-Position: refs/branch-heads/3239@{#248}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}To M63: Fix the build of base/numerics with GCC
Initialize the uninitialized variables where the build is failing.
BUG=776705
[email protected]
Change-Id: I5782e18086a752b3676f8738930bf0553f3f97ad
Reviewed-on: https://chromium-review.googlesource.com/730709
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Justin Schuh <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510753}(cherry picked from commit ec48e4ae39eea7377870732a1bb9cf62e84af42e)
Reviewed-on: https://chromium-review.googlesource.com/740221
Reviewed-by: Matthew Wolenetz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#247}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}cros misc RTL bug fixes
This CL...
- Fixes App Icon Drag for RTL.
- Fixes Selection/focus for RTL.
For the Old selection model:
- Fixes RTL selection.
- Refactors old selection tests which didn't support RTL.
- Breaks down a long selection test into more understandable chunks,
and removes the EXPECT macros from the helper functions.
For the New selection model:
- Fixes FocusManager so that it considers RTL.
- Created test support for RTL in FocusManager.
- Replaces the out-dated EnableFullscreen param in AppsGridViewTest
with a param that enables RTL.
For App Icon Drag:
- Now all drag tests also test RTL.
- We explicitly check that the drag view bound are being used
correctly for RTL.
Bug: 462292
Change-Id: I8e941a9dfcfbd4f944f299d535ee044b429c5404
Reviewed-on: https://chromium-review.googlesource.com/728397
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511513}
Reviewed-on: https://chromium-review.googlesource.com/740015
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#246}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Remove EQT plumbing to GRC.
The patch that added EQT plumbing to GRC was suspected as a cause of OOM
crash when Windows was waken up, thus revert it speculatively.
BUG=763710
Change-Id: I4695328752aa5c9a19f100dbeaaefd2afb1b350b
Reviewed-on: https://chromium-review.googlesource.com/721613
Commit-Queue: lpy <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509483}(cherry picked from commit de184fe0065ceca2a3c8e65f91cc7ac48b7b288c)
Reviewed-on: https://chromium-review.googlesource.com/739762
Reviewed-by: lpy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#245}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Theoretical fix for chromeos crasher.
Observing the TabletModeClient shouldn't send an immediate notification about
the current value, as this leads to an order of operations problem in the
BrowserNonClientFrameViewAsh code which tries to access a Browser object while
it's under construction. Change the one place which actually needs the data
immediately.
[email protected]
(cherry picked from commit 0618e01bf168294e8259fba43d0fa2d75cac29c2)
Bug: 775117
Change-Id: I7bcb65a9b281545a621460675c36b57f1a0de8f5
Reviewed-on: https://chromium-review.googlesource.com/722040
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Elliot Glaysher <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509555}
Reviewed-on: https://chromium-review.googlesource.com/739944
Reviewed-by: Elliot Glaysher <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#244}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] arc: Add required metrics for reauth flow.
This adds extra metrics for reauthorization flow to control success rate
of reauthorization and separate results for silent authorization code
requests.
modes.
[email protected]
(cherry picked from commit 67e39309db1b4ef2c3f5011e0f01cef57fb37a75)
Bug: b/35326144
Test: Manually on device. Confirmed histograms and logs for different
Change-Id: I61599062d123a3261ecc18a1600e2ccc2f55defd
Reviewed-on: https://chromium-review.googlesource.com/726744
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510925}
Reviewed-on: https://chromium-review.googlesource.com/739747
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#243}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Early return from PaintInvalidator::InvalidatePaint if no invalidation is needed
This is to fix the slight performance regression caused by
https://chromium-review.googlesource.com/719716 which lengthened
the code path for no invalidation.
[email protected]
(cherry picked from commit 34eef3f8a4801a129feba98afd109b8f7e7062e8)
Bug: 776759
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I85aed1c264fa05895049ea4828569929d0e1282c
Reviewed-on: https://chromium-review.googlesource.com/731575
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510987}
Reviewed-on: https://chromium-review.googlesource.com/739756
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#242}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Cronet: Disallow blocking I/O on the network thread with exception on init
Currently, the Cronet network thread allows blocking I/O. We would like to disable it unless it
is the initialization code that has to finish the creation of the prefs service before the thread
can be used to send network requests. That includes the creation of the storage directory and files.
This change is motivated by M63 blocking issue 770053. It assumes that blocking I/O is disabled
right after the thread creation. As the result, disallowing blocking I/O after Cronet
initialization doesn't solve the issue.
The CL makes use ScopedAllowBlocking class, which use is not public and discouraged.
However, it provides the simplest solution to the problem. The alternative solutions
either mimic ScopedAllowBlocking with an additional thread or require significant changes
to Cronet code, e.g. queuing all network request until the prefs service is initialized.
BUG=770053
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib97b8b727bcfb349050434858332342264e3737d
Reviewed-on: https://chromium-review.googlesource.com/705700
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Misha Efimov <[email protected]>
Commit-Queue: Andrei Kapishnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510740}(cherry picked from commit 46532f347d4a6799647e012df075789b52dac5d9)
Reviewed-on: https://chromium-review.googlesource.com/739203
Reviewed-by: Andrei Kapishnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#241}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Sensors] Fixes in freeing resources code
This patch improves the freeing resources code in 'generic_sensor':
1) Resources are only freed after all pending create sensor
requests are completed.
2) The dedicated functionality is moved to the 'PlatformSensorProviderBase'
class from the platform-specific classes.
Bug: 776037
Change-Id: I4bba84d0d7b377432454d9e5c5833750e097afee
Reviewed-on: https://chromium-review.googlesource.com/728741
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Mikhail Pozdnyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510670}(cherry picked from commit 2fc01c4378bc7b981204d8873e77c55f79a14c3e)
Reviewed-on: https://chromium-review.googlesource.com/739761
Cr-Commit-Position: refs/branch-heads/3239@{#240}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Print name of log source during failed readLogSource()
BUG=778473
R=[email protected], [email protected]
Change-Id: I18de052ef94fffae63a93d9a09527d16ff845579
Reviewed-on: https://chromium-review.googlesource.com/737441
Commit-Queue: Simon Que <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511685}(cherry picked from commit fa02b4fcc906e0175cbdc3446ecb3fbea74c3d37)
Reviewed-on: https://chromium-review.googlesource.com/739184
Reviewed-by: Simon Que <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#239}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't offer generatig or saving passwords in incognito
BUG=777753
[email protected], [email protected]
[email protected]
(cherry picked from commit a972ed40c192d1be60872610a5ae7132ce28653f)
Change-Id: Ia00492beb50d81448087331163967b09aa98fea0
Reviewed-on: https://chromium-review.googlesource.com/735158
Reviewed-by: Tatiana Gornak <[email protected]>
Commit-Queue: Jochen Eisinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511147}
Reviewed-on: https://chromium-review.googlesource.com/738770
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#238}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Don't hold on to the ChromeActivity in NewTabPageView
The ChromeActivity might change if the tab is reparented, and the old
activity could get destroyed.
(cherry picked from commit be75e820632f8e945a8514c8138e533aeb698df6)
Bug: 775011
Change-Id: I0e8eb0fa4af035cb760718a0db4e92e92414b05b
Reviewed-on: https://chromium-review.googlesource.com/728244
Commit-Queue: Bernhard Bauer <[email protected]>
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510755}
Reviewed-on: https://chromium-review.googlesource.com/737882
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#237}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Media Controls: add "px" to media controls popup menu rule to position.
Otherwise, depending on the element for which the popup menu is created,
the position might be off.
[email protected]
(cherry picked from commit db17c3ccab2dbe2ce85e2317c26f7104570ec28e)
Bug: 777278
Change-Id: I2e5ffbc08ffa88997a42a3ee09d0dec65798c097
Reviewed-on: https://chromium-review.googlesource.com/735611
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511155}
Reviewed-on: https://chromium-review.googlesource.com/737998
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#236}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Always pass tab key event to focus manager if ax tree is attached
get stuck at Android notification.
Bug: b/67336344
Test: Enable spoken feedback. Confirm that tab focus traversal doesn't
Change-Id: Ie1e587def916416525f6b7d0e6111a02a7defb50
Reviewed-on: https://chromium-review.googlesource.com/715956
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#508588}(cherry picked from commit 29019eec7358d50be8824d4b1a2eca75ae35558c)
Reviewed-on: https://chromium-review.googlesource.com/738356
Reviewed-by: Yuki Awano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#235}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[merge-m63] Mac: If a modal window is detected, do not pump private message loop modes.
It's possible for [NSApp modalWindow] to be set under some rare
circumstances when pumping regular tasks. This was unexpected, so if
a menu is shown in these cases, Chrome currently CHECK()s.
Instead, detect this, and run the menu in a "safe" mode, without pumping
regular tasks in the private runloop modes used for menu animations. Crash
stacks suggest that one possibility may be that a background thread is
showing an NSAlert and setting the global [NSApp modalWindow]. This is fine
but it confuses the CHECK().
[email protected]
(cherry picked from commit 89f824bbb1bf0df2760331cde51be1754dcab143)
Bug: 775738
Change-Id: I6a60f77f3c6c229c4809a4718d128ad2c59c7309
Reviewed-on: https://chromium-review.googlesource.com/724759
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510350}
Reviewed-on: https://chromium-review.googlesource.com/738011
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#234}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.20
[email protected]
Change-Id: I9be57971cd06ed904acb4b6756a9dbcebaa0844f
Reviewed-on: https://chromium-review.googlesource.com/738439
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#233}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Bookmarks] Disable selection actions until BookmarkDelegate initialized
The BookmarkDelegate is used to retrieve the SelecitonDelegate, so
BookmarkActionBar can not respond to taps on the selection mode toolbar
until the BookmarkDelegate is set. Disable the selection_mode_menu_group
until the BookmarkDelegate is set. Also, try to get the
SelectionDelegate in #onMenuItemClick after checking whether the menu
item clicked was a one of the normal_menu_group items.
BUG=718178
Change-Id: I07a9187c97d7b8d2ce15f00acb535a93b2a8034a
Reviewed-on: https://chromium-review.googlesource.com/731369
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510545}(cherry picked from commit 4897c7cd9d6d0a8115b678a05e950d17938c9bd4)
Reviewed-on: https://chromium-review.googlesource.com/737528
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#232}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Revert "Temporarily remove the lower 512MB shared memory limits"
This reverts commit 1a827230eec3f344ab9ca0c2dea44e100a8ff977.
Reason for revert: This was a temporary change to check the impact of certain limits.
Original change's description:
> Temporarily remove the lower 512MB shared memory limits
>
> This is being done to see if the 512MB limits resulted in a large
> OOM rate reduction we saw. Will revert this change within 1 week.
>
> Bug: 773067
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I61acc0f3fdaf911a99beb2b9c97758435583d5f4
> Reviewed-on: https://chromium-review.googlesource.com/707774
> Commit-Queue: Eric Karl <[email protected]>
> Reviewed-by: Antoine Labour <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#507509}
[email protected], [email protected]
(cherry picked from commit cac238e06a78ee12d9d67542b07f7c00038ffe40)
Bug: 773067
Change-Id: I5db9ec9bdb95ba59e456082dff96c810a5b76bbd
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/721799
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509099}
Reviewed-on: https://chromium-review.googlesource.com/738792
Cr-Commit-Position: refs/branch-heads/3239@{#231}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Turn on partner customizations on all pre-stable channels
crrev.com/c/704398 unified the availability of partner customizations
like bookmarks, homepage, etc. The rule was: they are available if
Chrome is a system package, or is force-enabled by a command line
argument "--allow-partner-customization".
Hiding behind a command line argument reduced the benefit of staged
deployment, and lowered the real world coverage.
Now the rule is: partner customizations are available if Chrome is a
system package, or is on pre-stable channels.
Bug: 617284, 773623
Change-Id: I594c0313781cc9c10ab73d6e0f4d7e837d578d46
Reviewed-on: https://chromium-review.googlesource.com/719472
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509475}(cherry picked from commit 2cf6a04fc3fd9eae4dcebe0f095d55c15023acca)
Reviewed-on: https://chromium-review.googlesource.com/738333
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#230}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Trim the parameters off of the URL in download-internals
Trim the query parameters to make the URL easier to visualize.
BUG=776146
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id5b13c27a20e868b67bb121d9339e1be0ca893ad
Reviewed-on: https://chromium-review.googlesource.com/727359
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510161}(cherry picked from commit 71704cb5180827d55746156021a377cad329a7fe)
Reviewed-on: https://chromium-review.googlesource.com/738673
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#229}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Avoid flash when aborting CTA.
Sometimes there is a visual glitch when ChromeTabbedActivity finishes
itself after starting another activity. For example the associated bug
documents a case where there is a momentary flash during custom tab
redirection.
The glitch is caused by abortLaunch() calling overridePendingTransition()
to do the following:
1. Disable exit animation on CTA window.
2. Force enter animation of the next window to be 'activity_open_enter'.
Both of those arguments were chosen without much experimentation, and
together they cause a flash because initial state of 'activity_open_enter'
animation is a transparent window, and canceling exit animation on a CTA
window immediately removes it.
This CL fixes overridePendingTransition() call to do the following:
1. Use 'no_anim' for the exit animation. This causes CTA window to be
visible for a short amount of time (should enough for the next activity
to render its UI).
2. Disable enter animation for the incoming activity. Animating another
window on top of still CTA window just doesn't look good.
Bug: 776456
Change-Id: I4a8de790087c4f3f2711999c2255198f311b6b7e
Reviewed-on: https://chromium-review.googlesource.com/734260
Commit-Queue: Dmitry Skiba <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510954}(cherry picked from commit d9b7b30337ded7f20041f545792bcbadc55dd8d1)
Reviewed-on: https://chromium-review.googlesource.com/738493
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#228}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Early-exit for detached Document in IntersectionObserver::ComputeIntersectionObservations
delegate_->GetExecutionContext() can get confused for Element-root
IntersectionObservers if the Element moves between Documents. If the original
Document was detached, attempting to schedule a task for that context will crash.
Bug: 763040
Test: intersection-observer/observer-shared-from-iframe.html
Change-Id: I6315791b71bf1e3d02e0e6f7369992f2c6fe2a6c
Reviewed-on: https://chromium-review.googlesource.com/716671
Reviewed-by: Stefan Zager <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509604}(cherry picked from commit f1c517557986eccd69130140fb9fedb15b3f49e8)
Reviewed-on: https://chromium-review.googlesource.com/737663
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#227}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[CrOS Tether] Add metrics for stopping discovery sessions.
[email protected]
(cherry picked from commit d585a0ee966bc03d8a66eecbeaf12b589944bdf5)
Bug: 777027, 672263
Change-Id: I2dc1447601b6c3c65e2d8390e917b20c8fff4bf5
Reviewed-on: https://chromium-review.googlesource.com/734208
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511199}
Reviewed-on: https://chromium-review.googlesource.com/737419
Cr-Commit-Position: refs/branch-heads/3239@{#226}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Remove WinScreenKeyboardObserver as an observer in its class Destructor
Currently there are crashes on Windows 8+ which seems to be due making
calls to observers from OnScreenKeyboardDetector where the corresponding
|keyboard_observer_| in RWHVAura is already deleted.
The current logic in RWHVA tries to remove the observer from the list
before it is destroyed (to avoid such crashes). However, the internals
of OnScreenKeyboardDetector and OnScreenKeyboardDisplayManager involve
multiple post tasks for detecting and showing keyboard and this has
made tracking the life time of OnScreenKeyboardDetector difficult.
Specifically, in it's current form, excessive complexity is exposed to
content layer (adding and removing observers should be simple and
controlled by content/ and not dependent on the details of
implementation in ui/).
OTH, it is safe to call OSKDisplayManager::RemoveObserver(observer)
more than once (though non-ideal). Therefore, it might make more sense
to let content/ decide to remove the observer when required; which
ideally can happen inside the destructor of the observer itself.
This CL replaces the current code in content/ for removing
|keboard_observer_| from observer list and adds the logic to the dtor
of WinScreenKeyboardObserver.
[email protected]
(cherry picked from commit 3d9b0c1fee36d170de3ca009a8344d5f6cf68f21)
Bug: 775973, 692495, 760012
Change-Id: I156c85a6eda1d3312f3ea162941ffb450c991ffb
Reviewed-on: https://chromium-review.googlesource.com/733420
Reviewed-by: Nick Carter <[email protected]>
Reviewed-by: Ehsan Karamad <[email protected]>
Commit-Queue: Nick Carter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511306}
Reviewed-on: https://chromium-review.googlesource.com/737433
Cr-Commit-Position: refs/branch-heads/3239@{#225}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix a UaF for deleted |RWHVAura::keyboard_observer_|
It is possible to get consecutive calls to FocusedNodeChanged, i.e., repeatedly
tapping into an <input>. This currently replaces the current |keyboard_observer_|
in RWHVA with a new instance. However, there is a chance that during the call
to OSKDisplayManager::DisplayVirtualKeyboard for the new |keyboard_observer_|,
the OnScreenKeyboardDetector corresponding to the previous observer tries to
detect the OSK and notify its (now deleted observers). This issue has caused
crashes on Windows 8 and 10.
The CL resolves the problem by properly removing |keyboard_observer_| as an
OSKObserver before destroying and replacing it.
[email protected]
(cherry picked from commit ba9ec7534fb396b9e01ccb3b7a0571b4ed508724)
Bug: 775973
Change-Id: I94dea4926a9d91cb7b4473d4c91b6574da66cbea
Reviewed-on: https://chromium-review.googlesource.com/726376
Commit-Queue: Ehsan Karamad <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509971}
Reviewed-on: https://chromium-review.googlesource.com/738293
Reviewed-by: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#224}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reland "VR: Prevent WebVR from receiving poses while in VR browsing mode."
This reverts commit b856d8615328453536f0fd12972e07b3552d48bd.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "VR: Prevent WebVR from receiving poses while in VR browsing mode."
>
> This reverts commit 5aa44f5dbddbdf86f2ae8ec04f6b70bde080ab1f.
>
> Reason for revert: <INSERT REASONING HERE>
>
> Original change's description:
> > VR: Prevent WebVR from receiving poses while in VR browsing mode.
> >
> > This CL is kept intentionally as simple as possible for merging back to
> > M-63.
> >
> > Tests to prevent this regression in the future will be added in a
> > followup CL.
> >
> > [email protected]
> >
> > (cherry picked from commit 417f0e75b6ea9652ccc64e8951a47cc2c79104e1)
> >
> > Bug: 775571
> > Change-Id: I78ea1e46efdb2b48bc61e1ab704b6b1526d2c171
> > Reviewed-on: https://chromium-review.googlesource.com/723770
> > Reviewed-by: Brandon Jones <[email protected]>
> > Commit-Queue: Michael Thiessen <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#509606}
> > Reviewed-on: https://chromium-review.googlesource.com/735741
> > Reviewed-by: Michael Thiessen <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/3239@{#175}
> > Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
>
> [email protected],[email protected]
>
> Change-Id: I9447befdc77fea63f438bae24ce99f91785c442d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 775571
> Reviewed-on: https://chromium-review.googlesource.com/735460
> Reviewed-by: Michael Thiessen <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3239@{#184}
> Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[email protected],[email protected]
Change-Id: I0527e0ca6fe7a0051f0244bd66c86e1ed59f864c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775571
Reviewed-on: https://chromium-review.googlesource.com/737864
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#223}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}cc: Use scaled occlusion in SolidColorLayerImpl::AppendQuads
SolidColorLayerImpl used to ignore any scale factors. But this would
cause problems in downstream CA layers. We failed to scale the occlusion
in the previous patch, resulting in unwanted patches of pixel shown when
playing video fullscreen.
This CL fixes that bug.
Bug: 774942
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia028600fbc8e976575330c793702d3eb0343983d
Reviewed-on: https://chromium-review.googlesource.com/726254
Reviewed-by: enne <[email protected]>
Commit-Queue: Xianda Sun <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510836}(cherry picked from commit fd89fae64111cbc80f7f3d07e899784c0428edd1)
Reviewed-on: https://chromium-review.googlesource.com/738352
Reviewed-by: Xianda Sun <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#222}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Android HW H264: append SPS/PPS at the start of key frame
Android MediaCodec will generate a seperate config frame containing
SPS/PPS at beginning of encoding H264 stream and the following key
frames won't have SPS/PPS any more, while other SW/HW H264 encoder
implementations will generate key frames with SPS/PPS always.
Recently WebRTC requires the H264 IDR/keyframe to contain SPS/PPS to
start decoder. Then the H264 intercommunication is broken between
Android and other platforms.
To fix this, append SPS/PPS at the start of H264 keyframe on Android.
[email protected]
(cherry picked from commit d1eba968e852c442c23ed0ac8f31ee878f2e1f05)
Bug: 761336
Change-Id: Ifb6b27f4448186dc4d7411921c556cf57d74068e
Reviewed-on: https://chromium-review.googlesource.com/710454
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Weiyong Yao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510459}
Reviewed-on: https://chromium-review.googlesource.com/737545
Reviewed-by: Weiyong Yao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#221}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix DownloadTaskScheduler::scheduleTask parameters order.
[email protected], [email protected], [email protected]
(cherry picked from commit caa10203e2a0ea6cb668f024364ecd167a758d97)
Bug: 777576
Change-Id: I8124e4fe1d2e82e8843d53169b941201dfef7a49
Reviewed-on: https://chromium-review.googlesource.com/734301
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510971}
Reviewed-on: https://chromium-review.googlesource.com/737541
Cr-Commit-Position: refs/branch-heads/3239@{#220}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Cherry-pick: Add write permission to launch intent for downloaded files
Some apps requires write permission in order to work
Chrome originally uses file path to launch intents, so write operation is fine.
With Content URI, we need to explicitly add write permission to the content URI.
[email protected]
BUG=775232
(cherry picked from commit a71fde10fe3b0104d78444a67a0814a06356ab0f)
Change-Id: I22352cb8f7f6f50a14a1a77cb937c4deb3808c78
Reviewed-on: https://chromium-review.googlesource.com/722265
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510511}
Reviewed-on: https://chromium-review.googlesource.com/733721
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#219}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge-63 [Payments] Only record aborts for nav. in main frame for PR.
Merchant aborts could be recorded when an iframe navigated or if there
were other changes related to the same document. A history pushState
for example.
Since the only way a navigation can close a Payment Request is when the
main frame is navigating to a different document, that's the only
situation in which we should record the abort.
This CL only affects metrics, there should be no user visible change.
[email protected]
(cherry picked from commit d56b3e4213be1de11246db3aafbb1dd76ec6862d)
Bug: 776474
Change-Id: Ibe8ffc41afbafdf645dc7d970bfc4632ce03e04a
Reviewed-on: https://chromium-review.googlesource.com/728859
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510491}
Reviewed-on: https://chromium-review.googlesource.com/737582
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#218}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}feedbackPrivate: Allow multiple handles to a log source from an extension
Remove the rule that there can be only one source reader handle opened from a particular extension.
There will still be rate limiting mechanisms in place:
- 1 second between reads from one reader handle
- max of 10 open readers per source, regardless of extension.
BUG=768967
Change-Id: I00cb6af27e8a9bdb4da68e015e65fd7ca3c5422b
Reviewed-on: https://chromium-review.googlesource.com/685577
Commit-Queue: Simon Que <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#508677}(cherry picked from commit 57f07dea9f99e4edbbbd66a8b69ab0d6fa3a61b9)
Reviewed-on: https://chromium-review.googlesource.com/738389
Reviewed-by: Simon Que <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#217}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Change Picture: Support for PNGs with palette data.
Add support for PLTE chunks to PNG behavior. Profile pictures
may contain palette data and to be able to remove potential
animations from these images, the PNG behavior needs to support
PLTE chunks.
[email protected]
(cherry picked from commit 00acc6f68f5a8fd0c1664c33ec499fdce71b18f2)
Bug: 777373
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic118e29b88efd79f46a8c3286bdaf49ab26ff840
Reviewed-on: https://chromium-review.googlesource.com/733618
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511013}
Reviewed-on: https://chromium-review.googlesource.com/738351
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#216}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix glitches in the Toolbar
This CL fixes two glitches:
- It resizes the tappable area of the NTP's omnibox to prevent it from
overlapping with the stack button.
- It puts the omnibox controls (clear and cancel) inside the safe area.
Bug: 777807, 777864
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I96ee42df3bbafe9a76f811b62b6ac2fbaff1f40e
Reviewed-on: https://chromium-review.googlesource.com/735327
Reviewed-by: Rohit Rao (ping after 24h) <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511150}(cherry picked from commit 08637853d9272c18d02c7c6225f54766cb935a1f)
Reviewed-on: https://chromium-review.googlesource.com/737634
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#215}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Clear touchpoint map if receiving doc is destroyed
When the receiving document of the touch events is
destroyed we need to still update the new touch
points so they get cleared when they release or
they get canceled.
Bug: 774446
Change-Id: I8903cd77464eeeeb2f659be13754ced6af8064bf
Reviewed-on: https://chromium-review.googlesource.com/719340
Commit-Queue: Navid Zolghadr <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510481}(cherry picked from commit fdbb2450a2b131d8e08c48e9b411d7cb94ce2cba)
Reviewed-on: https://chromium-review.googlesource.com/738329
Reviewed-by: Navid Zolghadr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#214}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Record metrics when "Generate a password" is triggered from Context Menu.
BUG=739343, 775825
[email protected]
(cherry picked from commit 43b335030921dbc94cbadab8a78b981c0066c21a)
Change-Id: I12ba09c21afd4e2fd70e82974bb1720228b0829b
Reviewed-on: https://chromium-review.googlesource.com/727894
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Tatiana Gornak <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510376}
Reviewed-on: https://chromium-review.googlesource.com/738208
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#213}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Record metrics when "Show all saved passwords" is triggered from Context Menu.
BUG=739343, 775825
[email protected]
(cherry picked from commit 376b1551feed797687cbf362188efdf1ab5a718d)
Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0
Reviewed-on: https://chromium-review.googlesource.com/725342
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Tatiana Gornak <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510036}
Reviewed-on: https://chromium-review.googlesource.com/738205
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#212}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}y
[Merge to m63]: Begin navigation at last position after a scroll action if possible
In some UI, e.g. Assistant/ARC++, after a scroll occurs, begin navigation in
ChromeVox in the last known position if possible by repeating the previous
command.
Test: navigate in Assistant UI. Verify position is correct even after a scroll.
Map Chrome focus and make visible to Android equivalents
Chrome accessibility uses focus to mean typically system focus.
However, in Android, there are two types of focus tracked.
Accessibility focus and input focus.
Since accessibility services on Chrome always call focus and input focus triggers undesirable side effects e.g. opening up the system IME, map focus to Android's accessibility focus.
In addition, sync visibility by mapping Chrome's scroll to make visible to Android's scroll to position.
[email protected]
(cherry picked from commit 9016599aac5bbd89e22fd80c303c04ab8a5ea0b3)
Bug: 776872
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I32eb9d1c3d95aa2b19378f2d30013a399ec6f83e
Reviewed-on: https://chromium-review.googlesource.com/730769
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511004}
Reviewed-on: https://chromium-review.googlesource.com/737658
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#211}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to m63]: Map Chrome focus and make visible to Android equivalents
Chrome accessibility uses focus to mean typically system focus.
However, in Android, there are two types of focus tracked.
Accessibility focus and input focus.
Since accessibility services on Chrome always call focus and input focus triggers undesirable side effects e.g. opening up the system IME, map focus to Android's accessibility focus.
In addition, sync visibility by mapping Chrome's scroll to make visible to Android's show on screen.
In some apps, e.g. Assistant, entire container nodes that have content read by
TalkBack, return false for isVisibleToUser. This causes ChromeVox to miss large
chunks of text.
The Assistant tree looks something like:
- list item (on Android side, it is a node with CollectionItemInfo data)
- a large subtree of containers with invisible state (which gets mapped from isVisibleToUser()). This subtree contains fully populated text.
TalkBack, for each navigation, calls the accessibility focus action, and ChromeVox, for each navigation calls Chrome focus action. The accessibility focus action triggers the nodes to become visible.
Test: manually type a query to Assistant. Verify that all text is navigated via
Search+arrows.
[email protected]
(cherry picked from commit f4e7e4410a69243fcb5b0ea9c8e1c5ccf4762773)
Bug: 776872
Change-Id: I4d80553bdb5346de84ecc8004c729528448a2841
Reviewed-on: https://chromium-review.googlesource.com/729209
Reviewed-by: Yuki Awano <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510790}
Reviewed-on: https://chromium-review.googlesource.com/737657
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#210}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] shelf: Fix InkDrop animation does not end.
This CL fixes issue when InkDrop animation stays on shelf button after
the click. This was due item controller was replaced during the
ItemSelected call and calling callback with action back to ash was
dropped.
[email protected]
(cherry picked from commit eee1e7c136b81bf2ea54b0e60621fbf4d1c92947)
Bug: 771655
Test: Manually
Change-Id: I8af7dc844a441ada91c4e35b04847a09ebd582db
Reviewed-on: https://chromium-review.googlesource.com/724201
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509889}
Reviewed-on: https://chromium-review.googlesource.com/737276
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#209}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Do not offset notification accessibility location
- focused_window is focused application window. No need to offset
accessibility location of notification by it.
- No need to translate accessibility location of notification without
the offset.
Android notification is correct. Especially, confirm that
accessibility location of popup notification is correct.
Bug: 764870
Change-Id: I1290e677c9a9c5daac6b41d60fbcfe83c3e83794
Test: Enable spoken feedback and confirm that accessibility location of
Reviewed-on: https://chromium-review.googlesource.com/720726
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510761}(cherry picked from commit cc819f6f2f7a404513bf92e447f75aaa174c1c9a)
Reviewed-on: https://chromium-review.googlesource.com/737389
Reviewed-by: Yuki Awano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#208}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[CrOS Tether] Add prioritization of connections.
Without this change, it is possible for high-priority connection
attempts to be stuck at the end of a queue. In most cases, this does not
have a drastic effect, but for users with many devices (e.g., Chrome OS
developers), it is possible that the device queue is so long that
connection attempts cannot complete.
This change assigns each connection attempt a priority and only attempts
connections to low-priority connections once high-priority connections
have completed.
[email protected]
(cherry picked from commit f7f462b7a9ab86e0bad1f8b695183761781aa81e)
Bug: 766216, 672263
Change-Id: Ic94f59a86b97c0bfbda02e614d0a04c08394815b
Reviewed-on: https://chromium-review.googlesource.com/736686
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#511355}
Reviewed-on: https://chromium-review.googlesource.com/737371
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#207}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] shelf: Keep shelf view model and item model in sync.
This CL fixed crash condition when CancelDrag is executed on outdated
view model, which does not in sync with item model
ARC is finally booted. No crash longer observed.
[email protected]
(cherry picked from commit 3e5c2a1149c112cee43e13167f33c88a6e09ed38)
Bug: 774182
Test: Manually, drag shelf item while apps get updated, for example
Change-Id: I33c5204e2d1fa259da28037851dcb67587d14de7
Reviewed-on: https://chromium-review.googlesource.com/720083
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509107}
Reviewed-on: https://chromium-review.googlesource.com/737274
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#206}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] Revert "Do not start ARC cotnainer if chrome will be restarted due to flag"
This reverts commit a26daee641b2f2b02e621d44f224d268a2ebc87e.
This CL looks dangerous once IsArcAllowedForProfile needs to be
persistent for all calls during the user session lifetime. Otherwise
some ARC component may have wrong assumption. Crashes in go/rfunq
contain in log "ARC because chrome will restart" so this looks as the
reason of this.
Based on offline discussion with oshima@ now this CL is less important
starting from M62. Let merge this revert and see how this affects
stability.
[email protected]
(cherry picked from commit 0fc86dec47963d4c4deb6e945a58aa8366d42eee)
Test: N/A
Bug: 775861
Bug: 758820
Change-Id: Icab0dfe95402c1fdcfde11333522f74ae8236fb1
Reviewed-on: https://chromium-review.googlesource.com/734283
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510928}
Reviewed-on: https://chromium-review.googlesource.com/737273
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#205}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] Revert "arc: Disable ARC on non-Google clients."
This reverts commit 89417c1c1757aadc60108b362e7ab773fca2b068.
Reason for revert:
This would break AOSP image that does not suppose to have Play Store sign in.
Original change's description:
> arc: Disable ARC on non-Google clients.
>
> It is possible to make a Chromium build with custom client id that
> defines non-Google build. In this case auth code cannot be requested
> and ARC fails with server communication error. This CL disables ARC
> on such builds.
>
> this CL this leads to SERVER_COMMUNICATION_ERROR on attempt to
> use ARC. With this CL ARC UI is not available and do not
> start. If I redefine client to Chrome again using oauth2-client*
> flags or build Chrome build, then ARC is available again and can
> be started without error.
>
> Test: Manually on device. Build image with mozilla client id. Without
> Bug: b/67410968
> Change-Id: I6bcfcb8c5a184a52df74020552404ff86b05051b
> Reviewed-on: https://chromium-review.googlesource.com/699767
> Commit-Queue: Yury Khmel <[email protected]>
> Reviewed-by: Roger Tawa <[email protected]>
> Reviewed-by: Luis Hector Chavez <[email protected]>
> Reviewed-by: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#507883}
[email protected], [email protected], [email protected], [email protected]
(cherry picked from commit 7c3e36eff7045a18a303d43c378aa287a2cba5dd)
Bug: b/67410968
Change-Id: Ic13ec52a41b11c0ac10e7ded691ecda55ddc75f8
Reviewed-on: https://chromium-review.googlesource.com/719176
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#508746}
Reviewed-on: https://chromium-review.googlesource.com/737330
Cr-Commit-Position: refs/branch-heads/3239@{#204}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[M63] Reland "exo: Avoid clipping surfaces outside quadrant IV"
This reverts commit 0b3a6d1dc3a30ea9a5a7a95d5d65a5d98e0e4a07.
Reason for revert: Workaround is still needed in M63.
[email protected]
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:64893967
Change-Id: I595cb823c085f8042a847be1173092541b12bcba
Reviewed-on: https://chromium-review.googlesource.com/736877
Reviewed-by: Dominik Laskowski <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#203}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Reset PendingOffset for LocalFrameView
During ScrollIntoView process, if a LocalFrameView's scroll is added to
the scroll sequence and is not scrolled instantly, a pending_offset will
be added to calculate its ancestors' scroll_offset properly. However,
this pending_offset is not correctly reset each time, so if
ScrollIntoView is called for the second time on a same LocalFrameView,
the pending_offset may be incorrect.
This patch resets this pending_offset whenever a ScrollIntoView is
called so that we won't mistakenly re-apply the already-scrolled offset
as a pending_offset.
Bug: 774222
Change-Id: I798a120e0937fe2f6cc6b389c2bb2c4fc6a4889d
Reviewed-on: https://chromium-review.googlesource.com/723132
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Sandra Sun <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509816}(cherry picked from commit 6247becd3a3621eea409ea4758f70a9a4491a39e)
Reviewed-on: https://chromium-review.googlesource.com/737149
Reviewed-by: Sandra Sun <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#202}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Incrementing VERSION to 63.0.3239.19
[email protected]
Change-Id: I782096ce4b34e5bca9e0e224546eb148716d3296
Reviewed-on: https://chromium-review.googlesource.com/737069
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#201}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge M63] arc: Restore deferred controller item menu.
This fixes regression when ARC deferred launch controller does not have
a menu and user cannot closes launch request and pin/unpin item.
[email protected], [email protected]
(cherry picked from commit 7df0afaf17dc235754d3949b6901bfd6822b2a96)
Test: Manually on device. Unit test added
Bug: 775744
Change-Id: I85d902a77a251d2958f9cd2a42dd7c10a393d6c0
Reviewed-on: https://chromium-review.googlesource.com/724460
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509686}
Reviewed-on: https://chromium-review.googlesource.com/736678
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#200}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Merge to M63] Gtk3: Fix frame button scaling on HIDPI
> This CL fixes frame buttons being too small when GDK_SCALE=2, as seen
> in [1].
>
> [1] https://bugs.chromium.org/p/chromium/issues/detail?id=753067#c43
>
> BUG=753067
> [email protected]
>
> Change-Id: I835668b779ab10ab3da971960794093f37813141
> Reviewed-on: https://chromium-review.googlesource.com/729568
> Reviewed-by: Elliot Glaysher <[email protected]>
> Commit-Queue: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#510498}
BUG=753067
[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: Ia68e0ebbb9f4456852098a42f7fd007d6ac96296
Reviewed-on: https://chromium-review.googlesource.com/736810
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#199}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix process reuse races with lazily-initialized SiteInstances (Merge to M63)
When a navigation happens in a lazily-assigned (i.e., siteless)
SiteInstance, the site URL will be assigned, and the process marked as
used, when the response is received. Any redirects, as well as final
response, are unconditionally allowed to stay in the siteless
SiteInstance and its process, even for sites that require dedicated
processes. This is problematic, because someone else could've grabbed
the same process and locked it to an incompatible origin lock before
the final response is received, due to either being over process limit
or to the REUSE_PENDING_OR_COMMITTED_SITE process reuse policy (e.g.,
for ServiceWorkers). Then, when the response is received, the
navigation will incorrectly attempt to commit in the original process
due to the SiteInstance not having a site, leading to a CHECK for
origin lock mismatch.
This CL fixes siteless SiteInstances to still require a process
transfer when their process is no longer suitable for the destination
URL (e.g., due to their process becoming locked to an incompatible
origin lock).
[email protected]
(cherry picked from commit 9e082896806704f529fc74f77d305a042ab5496d)
Bug: 773809
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I01f0d16d908a52f6213142d792a3fb3cb67a485f
Reviewed-on: https://chromium-review.googlesource.com/728329
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510558}
Reviewed-on: https://chromium-review.googlesource.com/736852
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#198}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix default theme color checks
This patch fixes negations that were accidentally reomved by the
following: https://chromium-review.googlesource.com/c/chromium/src/+/713275
BUG=777326
[email protected]
(cherry picked from commit b0b64b59d5df48d81df946941b70297d89a45964)
Change-Id: Ibb49ba6909fe3f492742b85eee938a517e2255ed
Reviewed-on: https://chromium-review.googlesource.com/733858
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510873}
Reviewed-on: https://chromium-review.googlesource.com/736491
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#197}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Home] Block Chrome Home promo from showing on tablets
This change adds checks to feature utils, the Chrome Home promo, and
the new tab page view that check to make sure the device is not a
tablet before showing the relevant UI.
BUG=777026
[email protected]
(cherry picked from commit e506c33592c8ffc1955dd0fb4d90ff7dfdb0581b)
Change-Id: I37aed90ca1d64f6dc6f06a3039f4fd60402f33e2
Reviewed-on: https://chromium-review.googlesource.com/733660
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510906}
Reviewed-on: https://chromium-review.googlesource.com/736470
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#196}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix crash in DownloadBroadcastManager.
Before this CL, there was a NPE crash in DownloadBroadcastManager. This
CL fixes this crash.
Bug: 774705
Change-Id: I43c0aaa6acc58f6fd68203ffe785cbc997a81b9b
Reviewed-on: https://chromium-review.googlesource.com/719354
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Joy Ming <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509228}(cherry picked from commit 6166ed0ba6749037b1eb048212149dbce1e92b93)
Reviewed-on: https://chromium-review.googlesource.com/734728
Cr-Commit-Position: refs/branch-heads/3239@{#195}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Update UMA tracking for downloads notifications.
This is part of a larger refactor to make downloads a foreground
service on all versions of Android. During the refactor, a few
tradeoffs had to be made (ie. optimizing for single download or
multiple). These metrics can give light into how to make such tradeoffs
in the future, specifically around: notification interactions, number
of notifications (as a proxy for multiple downloads), service
lifecycle, unexpected/expected service stops, etc.
[email protected]
Bug: 747563
Change-Id: I90ab96c863bfaa77ded0d09c74277f10795dfdf1
Reviewed-on: https://chromium-review.googlesource.com/710579
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Joy Ming <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509466}(cherry picked from commit 7748cea2ab5767bef12997c2a5225b566df02d96)
Reviewed-on: https://chromium-review.googlesource.com/734729
Cr-Commit-Position: refs/branch-heads/3239@{#194}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge M63 "cros: Use Webview for public session ToS"
> - Replace public session ToS <span> with <webview>;
> - Use data url to set the content of the ToS <webview>;
> - Adjust style to match previous implementation;
>
> Bug: 770313
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I4906ab84b713e0e89245843b4c5162cc534aa463
> Reviewed-on: https://chromium-review.googlesource.com/731665
> Commit-Queue: Xiyuan Xia <[email protected]>
> Reviewed-by: Charlie Reis <[email protected]>
> Reviewed-by: Achuith Bhandarkar <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#510895}
> (cherry picked from commit c2da6a66bc9bfdb07e4a2ec945b89aebe0926393)
Change-Id: I4f39cd0a11c1ef7679d2edb0ff6ac064b4655540
Reviewed-on: https://chromium-review.googlesource.com/736430
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#193}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Merge M63 "cros: Use webview for Eula screen"
> - Replace eula iframes with webview;
> - Load chrome://terms via XHR and set to webviews via data url
> to re-use existing online/local/oem terms loading code;
> - Get rid of padding for .eula-frame css class as webview looks
> good without it;
> - Move online terms loading from ChromeOSTermsHandler to Oobe
> Eula webui;
> - Re-write EulaTest since old tests are testing chrome://terms
> in a tab;
> - Move EulaTest from interactive_ui_tests to browser_tests since
> it no longer uses ui_test_utils::FindInPage;
>
> Bug: 770313
> Test: Manual. Verify Eula screen works with MD/non-MD/language change.
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I2d90492958d0adae06a3e873942f2d3f534f7991
> Reviewed-on: https://chromium-review.googlesource.com/710738
> Reviewed-by: Charlie Reis <[email protected]>
> Reviewed-by: Alexander Alekseev <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#510197}(cherry picked from commit c09ae9d1985365d1aa7455eb25e7a70c1bcfe368)
Change-Id: I671e3d3a090ee1880159180178f448f255330115
Reviewed-on: https://chromium-review.googlesource.com/736037
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#192}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Fork M63] Remove locale broadcast receiver
This is causing a memory leak because the broadcast reciever is never
unregistered. For m63, just ignore locale changes. Proper fix has
already landed on trunk.
Bug: 773659
Change-Id: I879d1182e23b28f795cd63beff48854493ec6eb8
Reviewed-on: https://chromium-review.googlesource.com/736146
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3202@{#737}
Cr-Original-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}(cherry picked from commit b8b6b42b2ba4cbf4a8607cba6d707152bde8b415)
Reviewed-on: https://chromium-review.googlesource.com/736220
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#191}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}[Bookmarks] Fix folder icon tinting after de-selecting
Adds a SelectableItemView#getDefaultIconTint() method that sub-classes
can override to provide a ColorStateList for use when the item is not
selected.
BUG=776886
Change-Id: I0e10cc86c196634c54d224a33fbcdc8d79266f06
Reviewed-on: https://chromium-review.googlesource.com/731113
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510574}(cherry picked from commit 689beec6486f85d896b52bbff68c15c81c52fe54)
Reviewed-on: https://chromium-review.googlesource.com/736369
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#190}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}Fix reporting of OfflinePages.ClearStoragePreRunUsage.* metrics (M63 merge)
Fixes the OfflinePages.ClearStoragePreRunUsage.* series of metrics --
renaming them to ClearStoragePreRunUsage2 -- so that they report their
values in KiB. They were previously expected to be reported in MiB but
were incorrectly reported in bytes.
Bug: 775321
Change-Id: Ia12f0c039172292770ee066efc128b0fd9c8204e
Reviewed-on: https://chromium-review.googlesource.com/722033
Commit-Queue: Carlos Knippschild <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Peter Williamson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#510191}(cherry picked from commit de426dcb636e12f2a90ea783cd8f42476473488e)
Reviewed-on: https://chromium-review.googlesource.com/736119
Reviewed-by: Carlos Knippschild <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#189}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
