Publish DEPS for Chromium 62.0.3202.45
Incrementing VERSION to 62.0.3202.45
[email protected]
Change-Id: Ib2bbc9e887b42c11824da29edd4f2a0130e48bc3
Reviewed-on: https://chromium-review.googlesource.com/699458
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#573}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[M62] exo: Avoid clipping surfaces outside quadrant IV
The host window is positioned at ShellSurface::GetSurfaceOrigin. In ARC,
the surface origin is the negated origin of the ShellSurface geometry,
since the client positions surfaces in screen coordinates but the server
positions them relative to the ShellSurface.
However, the cc::RenderSurfaceImpl for a window's layer tree expects
layers to be positioned in the window's local coordinate space, and
clips content outside the layers' bounding box. If the host window
layer has positive coordinates, the top/left edges of the bounding
box correspond to those of the window frame, so content at negative
coordinates is clipped.
As a temporary workaround, this CL translates quads to non-negative
coordinates, and negates the offset by shifting the frame sink host
relative to the host window.
Bug: b:64893967
Test: Windows outside quadrant IV in screen coordinates are visible.
Test: Windows whose bounds exceed the top/left edges of the display
are not clipped in overview mode.
[email protected]
(cherry picked from commit 1650ad74545c5033abc6ca372bc552d21db8bf2a)
Change-Id: Ia60493e887c16be8f2250293fd726fcf6a9ee5af
Reviewed-on: https://chromium-review.googlesource.com/688460
Reviewed-by: David Reveman <[email protected]>
Commit-Queue: Dominik Laskowski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#506153}
Reviewed-on: https://chromium-review.googlesource.com/699021
Reviewed-by: Dominik Laskowski <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#572}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[M62] exo: Compute SurfaceTreeHost bounds recursively
The RenderPass::output_rect and host window bounds for SurfaceTreeHost
were set to the content size of the root surface. Hence, surfaces were
clipped to the viewport (0, 0) × (W, H), where (W, H) is the size of
the root surface. The root surface of ARC windows is sized to match
the Android display.
This CL computes the output_rect as the bounding box of the surface
tree, and resizes the host window to match the output_rect.
Bug: b:64893967
Test: Windows whose bounds exceed the bottom/right edges of the display
are not clipped in overview mode.
[email protected]
(cherry picked from commit 2af53e7b572ff9d2276b092c2290b39489c07ac3)
Change-Id: I51ddf7405e703f5c546aec88a01cc004d105b18a
Reviewed-on: https://chromium-review.googlesource.com/639472
Commit-Queue: Dominik Laskowski <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505871}
Reviewed-on: https://chromium-review.googlesource.com/699010
Reviewed-by: Dominik Laskowski <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#571}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Stop media-element capturers if the element has cross-origin data.
BUG=761622
Change-Id: I9428919041a0c5a0779bec18b911b253c82fece3
Reviewed-on: https://chromium-review.googlesource.com/690377
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505353}(cherry picked from commit 4f61ad37e42d20afdcc6442b18b617f7e5f7a2a0)
Reviewed-on: https://chromium-review.googlesource.com/698847
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#570}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}exo: Commit without contents should trigger a configure callback.
XDG shell 6 clients rely on this behavior.
[email protected]
(cherry picked from commit 226948c353c625744f61f90e0308d288a08c22d6)
Bug:
Test: exo_unittests --gtest_filter=ShellSurfaceTest.ConfigureCallback
Change-Id: I38ceebe8306267d118382ebfa627976e251c7383
Reviewed-on: https://chromium-review.googlesource.com/693164
Commit-Queue: David Reveman <[email protected]>
Reviewed-by: Dominik Laskowski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505635}
Reviewed-on: https://chromium-review.googlesource.com/699455
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#569}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[CrOS Tether] Update notification look-and-feel, including iconograpy.
Previously, notifications were in the old style, with a large image on
the right side. This CL updates notifications to the new style, with
small icons in the upper-left corner.
[email protected]
(cherry picked from commit 47ff41de6b7c6ea1f5c6f24d99bc24b3d7110207)
Bug: 759257, 672263
Change-Id: I1214002aa60a062b39c955dcfd8848adb8193f88
Reviewed-on: https://chromium-review.googlesource.com/685304
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#506203}
Reviewed-on: https://chromium-review.googlesource.com/699063
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#568}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[CrOS Tether] Add the ability for VectorIcons to adjust opacity.
Previously, it was possible specify an ARGB value via the
PATH_COLOR_ARGB command, which takes an alpha as well as RGB properties
as parameters. However, there was no command to specify a change in
opacity without also specifying the color to use.
This presented a problem for system notification. When displayed
on a notification, these icons are drawn in blue or red, depending on
the warning level of the notification, and when displayed in the black
bar at the bottom of the UI, they are drawn in white. Thus, for
notification icons which need to be displayed in a single color with
different opacities, a new command was needed.
This CL introduces the PATH_COLOR_ALPHA command, which takes a single
parameter expressing the opacity of the path. It will be used
immediately in a follow-up CL:
https://chromium-review.googlesource.com/c/chromium/src/+/685304
[email protected]
(cherry picked from commit 4177a8cdba1622571f0cf117dfe7bae3a5be7f62)
Bug: 759257, 672263
Change-Id: I00a5dbb28a06de41239cda2fe1c608754f190bf6
Reviewed-on: https://chromium-review.googlesource.com/690706
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505404}
Reviewed-on: https://chromium-review.googlesource.com/699062
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#567}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[CrOS Tether] Fix crash in BleSynchronizer.
The crash occurred in the following situation:
(1) Tether component gets shut down, but BLE advertising/scanning is
still active.
(2) Tether component shuts down asynchronously by waiting for active
advertising/scanning to finish, then deleting all Tether-related
objects.
(3) BleSynchronizer finishes a command (either unregister advertisement
or stop discovery session) and alerts clients.
(4) Client discovers that asynchronous shutdown is complete and deletes
the Tether component.
(5) BleSynchronizer tries to execute the next command, but it cannot
because it has already been deleted. A crash occurs because deleted
memory is referenced.
This CL fixes the issue by executing the next command as a new task,
ensuring that the next command will not be executed if BleSynchronizer
has been deleted.
[email protected]
(cherry picked from commit 604aeb5efed33c8cefa53adf493c638a498957ff)
Bug: 770863, 672263
Change-Id: I52f08990ab08b5de0f506d214fc0b1b8544d5b0c
Reviewed-on: https://chromium-review.googlesource.com/696331
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#506194}
Reviewed-on: https://chromium-review.googlesource.com/699060
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#566}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Crash when sending oversized Mojo or legacy IPC messages
This is a combined merge of r501844 and r502641, forcing
all IPC transmission code paths to CHECK if outgoing message
size exceeds the maximum allowed capacity.
NOTE: This WILL introduce new crash signatures in M62, but
they should almost entirely be taking the place of other
existing crashes.
BUG=771235
Change-Id: I3dcc2155b2d22dee8f6f5c701010aa58fea6c485
Reviewed-on: https://chromium-review.googlesource.com/699055
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#565}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix bug in VAO emulation, recently introduced by a workaround
The workaround was added here: https://crrev.com/c/636513
Bug: 768324
Test: GLVirtualContextsTest.VertexArrayObjectRestoreDefault
(with use_client_side_arrays_for_stream_buffers enabled).
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1f0b00a4ab9ab4bf5d8fbd33f567af3b0f41de58
Reviewed-on: https://chromium-review.googlesource.com/685984
Commit-Queue: Kai Ninomiya <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505508}(cherry picked from commit 728c5405bd66c8303b5f6f6eba750efe3e9b7847)
Reviewed-on: https://chromium-review.googlesource.com/699049
Reviewed-by: Kai Ninomiya <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#564}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Handle empty currentSrc() in HTMLMediaElementCapture
This CL addresses issues discovered by fuzz tests:
- currentSrc() can be null for a MediaStream. We can get descriptor via
GetSrcObject() then.
- VideoFramePool::CreateFrame() can fail then as resolution hasn't been
set. We skip capture for those frames then.
[email protected]
(cherry picked from commit dfbd5e4a13e399494354a4a51e4fb0a809090b50)
Bug: 765625
Change-Id: Ifc4f9c12d25511dd12f94cf01eb383078360dbfd
Reviewed-on: https://chromium-review.googlesource.com/687962
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Commit-Queue: Emircan Uysaler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504929}
Reviewed-on: https://chromium-review.googlesource.com/699292
Cr-Commit-Position: refs/branch-heads/3202@{#563}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Merge M62] Fix a race condition in OnCleanerProcessDone.
The race condition happens in the very rare case when the cleaner
process successfully removes UwS from the system before we haven't
started rendering the Settings page after the user accepted the prompt
(we expect a cleanup to take a few minutes, specially because an
elevation is required).
[email protected]
(cherry picked from commit 3e7b1aed8aa6a02f9d9f9f53ec9854eb374c58ca)
Bug: 768816
Change-Id: Ib3a7a866e38a870d6d83d99b7d8e054ccb3b7d65
Reviewed-on: https://chromium-review.googlesource.com/688476
Reviewed-by: Ali Tofigh <[email protected]>
Reviewed-by: Chris Sharp <[email protected]>
Commit-Queue: Chris Sharp <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504994}
Reviewed-on: https://chromium-review.googlesource.com/699006
Cr-Commit-Position: refs/branch-heads/3202@{#562}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Devtools] Regression: Fixed rendering of HTML and JSON in network
* Fixed bug where network preview would not render JSON if it was
fetched and and had an error code.
* Fixed bug where network preview would try to render as HTML
agressively if requested via XHR.
R=pfeldman,eostroukhov
BUG=765286,767393,763921
(cherry picked from commit 2a04495525d82b290a619c4abd62067e9fa79bad)
Change-Id: I9a160e50241e406456623469738b0694800ae586
Reviewed-on: https://chromium-review.googlesource.com/687890
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Blaise Bruer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505212}
Reviewed-on: https://chromium-review.googlesource.com/698906
Reviewed-by: Blaise Bruer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#561}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Revert Flash hack for DWrite IPC sender
This prevents Flash from crashing when requesting fonts using the new
DWrite proxy. The hack was removed on:
https://chromium-review.googlesource.com/c/chromium/src/+/587415
[email protected]
(cherry picked from commit 24108a861ec3cc39650c708c0748773bacd6c19e)
Bug: 755120
Change-Id: Ib6d1cfb2eda9e470d751960d0b1a957ac91f0705
Reviewed-on: https://chromium-review.googlesource.com/687283
Commit-Queue: Fernando Serboncini <[email protected]>
Reviewed-by: Ilya Kulshin <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505619}
Reviewed-on: https://chromium-review.googlesource.com/698295
Reviewed-by: Fernando Serboncini <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#560}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Custom Context Menu] Restoring Copy Link Text Removal
Reverts the changes in https://codereview.chromium.org/2942963002/.
One test currently fails so it's left out so we can merge this asap.
Bug: 764966
Change-Id: I30cb67c0633fba87178720347eac6c64e440d37c
Reviewed-on: https://chromium-review.googlesource.com/669959
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3163@{#1211}
Cr-Original-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}(cherry picked from commit 76c769a30fb816d8f48945995e779bfd8a55d53c)
Reviewed-on: https://chromium-review.googlesource.com/695283
Cr-Commit-Position: refs/branch-heads/3202@{#559}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Default the toolbar height to 44 and ignore the safe area in Stack View.
Bug: 768868, 767516, 767566
Change-Id: I8c2de3f2788bb0af090293ac4ead13b23bb73c78
Reviewed-on: https://chromium-review.googlesource.com/684743
Commit-Queue: Jean-François Geyelin <[email protected]>
Reviewed-by: Rohit Rao (ping after 24h) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504640}(cherry picked from commit be4f437a5eb20f3955c0b56a8a7a54aa3999c85b)
Reviewed-on: https://chromium-review.googlesource.com/697725
Reviewed-by: Jean-François Geyelin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#558}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix rarely shown invalid ripple from notification header.
After https://crrev.com/c/676963, in rare case, invalid ripple effect is
shown when the header is clicked. http://screen/29NRt5CTEEm
This CL fixes this by always returning stub InkDrop object.
TEST=manual
BUG=767246
[email protected]
(cherry picked from commit d248001347734f74771543635bbece4c2a41443b)
Change-Id: Ibb5902864474849e665c0e325f4c2b97a80a4d51
Reviewed-on: https://chromium-review.googlesource.com/681096
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504253}
Reviewed-on: https://chromium-review.googlesource.com/696463
Cr-Commit-Position: refs/branch-heads/3202@{#557}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Remove ripple effect from notification header.
This CL removes ripple effect from notification header for the sake of
consistency with Android notifications.
Originally, this feature was added in
* http://crrev.com/2959363002
* http://crrev.com/c/603033
TEST=manual
BUG=767246
[email protected]
(cherry picked from commit 4bc63b0625d9129a2a7d080fbdc440472ab502c5)
Change-Id: I80e7772fb535f3050263d57f4d11f8d6d81eec27
Reviewed-on: https://chromium-review.googlesource.com/676963
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503634}
Reviewed-on: https://chromium-review.googlesource.com/696784
Cr-Commit-Position: refs/branch-heads/3202@{#556}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Incrementing VERSION to 62.0.3202.44
[email protected]
Change-Id: I3f6d0d8c8db3ec566f8f3d43dbfb514cbd7f2c64
Reviewed-on: https://chromium-review.googlesource.com/696521
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#555}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Handle invalid format/type in texture uploading when FlipY/PremultiplyAlpha is set.
Currently if uploading from ArrayBuffer, NOTREACHED() will be hit in such situations
and in Release build, after hitting NOTREACHED() statement, unintended code path is taken.
BUG=765469
TEST=webgl_conformance
[email protected]
[email protected]
(cherry picked from commit 73ac8f4a66c057b6b22a1c2c6e042c77ef39450d)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icf1ab03723b6c13595bd6c4dbc4e5fa40fdf9d96
Reviewed-on: https://chromium-review.googlesource.com/685487
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504568}
Reviewed-on: https://chromium-review.googlesource.com/696284
Cr-Commit-Position: refs/branch-heads/3202@{#554}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Don't preserve the history item for blocked XFO navigations.
Back/forward navigations that get blocked with a data: URL should not
keep the same history item, since it will not be reloaded later and
its "data:," URL should not be considered same-document with previous
same-document navigations.
BUG=765291
TEST=See bug comment 19 for repro steps.
[email protected]
(cherry picked from commit d3a1af75d3e64c5cf6e1cf54a8ff1aadb9b9359b)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie7eedbdcc201315023543eaf465a7ff24b1f86ca
Reviewed-on: https://chromium-review.googlesource.com/693139
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505463}
Reviewed-on: https://chromium-review.googlesource.com/696261
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#553}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}arc/bluetooth: Prevent double-setting the user preference on power state
This adds a flag to guard SetPrimaryUserBluetoothPowerSetting if the
power state change on adapter is initiated by Chrome in the first place,
since the user preference has been saved. By guarding
SetPrimaryUserBluetoothPowerSetting, the following scenario can be
prevented.
Issue:
Double-setting the user preference is OK in the normal case where it
takes BlueZ < 1 second to power on/off the adapter. In some cases, it
takes BlueZ > 3 seconds to finish powering off adapter. Within that > 3
seconds window if an user turns on Bluetooth from Chrome Bluetooth
setting, the power-on request will be fulfilled by BlueZ and enqueued to
the to-be-send-to-android request queue while Android is still dealing
with the previous power-off request. Afterward, Android gets back to
Chrome about finishing power-off request, but since the current state is
powered-on in preference on Chrome, the power-off state will be stored
to preference again, which will then trigger a power-on request from
Chrome. And this toggling will go on and on.
BUG=769981
TEST=Check that bluetooth power change from Chrome OS doesn't get
re-applied by ARC bluetooth.
TBR=yusukes,mcchou
(cherry picked from commit c2984f64e32d960e68e9c544edec3567ca4d493c)
Change-Id: I57b530518ba380eb6945000baf6f4ff6c0fdc27a
Reviewed-on: https://chromium-review.googlesource.com/691276
Reviewed-by: Miao-chen Chou <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505428}
Reviewed-on: https://chromium-review.googlesource.com/696023
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#552}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Remove accessibility from manager during destruction.
If "accessibility" is enabled then a pointer to the WebContents-
AccessibilityAndroid object is held by an BrowserAccessibility-
ManagerAndroid object leaving it dangling if the former is
destructed. During destruction of the WCAA object, remove any
reference to itself from the BAMA object.
[email protected]
(cherry picked from commit 8ee829ff64a71d28956515e2276b1a5679e726dd)
Bug: 736675, 727210
Change-Id: I67050e7708abbdfe396a0571bc515a5bda88dcbe
Reviewed-on: https://chromium-review.googlesource.com/688035
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504807}
Reviewed-on: https://chromium-review.googlesource.com/696221
Reviewed-by: Brian White <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#551}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}viz: Fix empty swap current_buffer logic.
We observed buffers being scanned out while the GPU is still drawing to
them.
While I haven't been able to reproduce it, we noticed that it's possible
to call bindbuffer, swapbuffer and bindbuffer on the buffer queue, in a
way that the bound buffer ends up being the same as the buffer we just
sent for scanout.
The main problem seems to be that current_surface_, that is suppose
to represent the surface we're drawing to and that we're about to schedule
for scanout, does not advance in case of a swapbuffer with an empty rect.
This CL fixes that behavior, making sure calling bindbuffer after swapbuffer
always binds a new surface and not the same one we just used for scanout.
[email protected]
(cherry picked from commit 2c67d73943b3e0c8bf0c450fc2df514ab2e26236)
Bug: 759758
Change-Id: I99749cd7ddb13cc6e46dbaa06e33cbccc8834e93
Reviewed-on: https://chromium-review.googlesource.com/655678
Reviewed-by: David Reveman <[email protected]>
Commit-Queue: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#500376}
Reviewed-on: https://chromium-review.googlesource.com/696027
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#550}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}m62 merge: cros: Install RerouteEventHandler only when TrayBubbleView is shown by click
changes:
Regression comes from
https://chromium-review.googlesource.com/c/chromium/src/+/603547
Tray bubble view is default not active, install pre target event handler
(RerouteEventHandler) only when TrayBubbleView is opened by click on
the corresponding tray, which must be triggered by PerformAction().
[email protected]
[email protected]
[email protected]
[email protected]
(cherry picked from commit a3c10f43daa8f3e019b2b2fa81b0e92dc04fac6e)
Bug: 765473
Test: device test and added test coverage
Change-Id: Icca804f2d134f588d9901c38aaebb7a8d87f6f8e
Reviewed-on: https://chromium-review.googlesource.com/677231
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505772}
Reviewed-on: https://chromium-review.googlesource.com/695836
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#549}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}ozone: Disable overlays on HDC::Disable.
HDC::Disable currently calls drmModeSetCrtc, that disable the primary
plane, but not additional overlays.
This means that when disabling an HDC and then re-enabling, after the
new modeset, and before a new pageflip, you can see an overlay that was
set with the old pageflip.
This CL makes sure to disable all planes when disabling an HDC.
[email protected]
(cherry picked from commit a5d3a9cf9e9ca07713538810e2f0c98401755da4)
Bug: 763736
Change-Id: I30ec7eb9ec1323474c21335aaadd1ce2bb250a89
Reviewed-on: https://chromium-review.googlesource.com/680476
Commit-Queue: Daniele Castagna <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Daniel Nicoara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504094}
Reviewed-on: https://chromium-review.googlesource.com/696141
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#548}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[iOS] Stop listening to TTS notifications when the delegate is reset.
Text-To-Speech functionality requires a delegate, so the toolbar should
stop observing NSNotificationCenter when it's reset.
[email protected]
(cherry picked from commit fbd8715682cab88a66acf8f7c72bc482a628116a)
Bug: 766496
Change-Id: Iab91b68431562556569112be0539d1d43cc3b49d
Reviewed-on: https://chromium-review.googlesource.com/678507
Reviewed-by: Rohit Rao (ping after 24h) <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504067}
Reviewed-on: https://chromium-review.googlesource.com/696122
Cr-Commit-Position: refs/branch-heads/3202@{#547}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Updating XTBs based on .GRDs from branch 3202
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5cd2f57aa52569b87aa55e47fa7749898bf1efe3
Reviewed-on: https://chromium-review.googlesource.com/695912
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#546}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Less forcing of column flow flex children layout.
If the logical height of a child is intrinsic, we only need to lay it out if
there's a chance that the logical width of the flex container changed.
Otherwise nothing's going to change in there.
We do this by checking for kForceLayout, so that we don't risk descending into
deep subtrees just because some flex item sibling changed, for instance.
TEST=PerformanceTests/Layout/flexbox-deeply-nested-column-flow.html
[email protected]
(cherry picked from commit daf862b83d13e488a2c69a11d85cad2ee8904708)
Bug: 766633
Change-Id: I29337a176592779f07a37570fef8c85b1b4f6d99
Reviewed-on: https://chromium-review.googlesource.com/680214
Reviewed-by: Stefan Zager <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504924}
Reviewed-on: https://chromium-review.googlesource.com/696081
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#545}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Wrap siging out in case of an error in a check for local sync being off.
When local sync is enabled there is no account to sign-out of.
Long term all calls to cloud-related functionality should be made
though an interface that is aware of the local state and can handle
them properly and accordingly to avoid future issues like this one.
BUG=743592
Change-Id: I8d057aac1f5563aa99a89f804e4bc906bf77fa32
Reviewed-on: https://chromium-review.googlesource.com/681436
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504625}(cherry picked from commit 55ae06a4714e1f897a1dd5cae6dcb14783d29179)
Reviewed-on: https://chromium-review.googlesource.com/696061
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#544}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Clip metalayer selection to screen bounds
Although metalayer selection is constructed from stylus
input points, it can sometimes cross the screen bounds.
For example, when a horizontal stroke is recognized, its
bounding rectangle is inflated to guarantee minimal
height and generally be closer to the visual image of
the stroke.
This patch introduces necessary clipping to make sure
that clients do not have to do that.
[email protected]
(cherry picked from commit 549c7f97a47bc11f7cbc4d023bf96dd40d2f53c6)
Bug: b:67021526
Test: ash_unittests HighlighterControllerTest.SelectionInsideScreen
Change-Id: I09d67c8b9f1176ea083a40f581b8a46536152296
Reviewed-on: https://chromium-review.googlesource.com/691278
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505401}
Reviewed-on: https://chromium-review.googlesource.com/695921
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#543}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Update settings search page for secondary user
Check whether the user is primary when setup the search page in CrOS
settings. Remove the voice interaction entry and change the title if the
user is not primary.
BUG=b/66919596
[email protected]
(cherry picked from commit c23e9f44302539f64b92d6ca43d4fd6431a2878b)
Change-Id: I1b38de178830862ebca9c56160ddab595640c844
Reviewed-on: https://chromium-review.googlesource.com/689965
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505232}
Reviewed-on: https://chromium-review.googlesource.com/695903
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#542}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add missing synchronization in 2d canvas resource release
Call to WaitSyncTokenCHROMIUM was removed by mistake in:
https://chromium-review.googlesource.com/c/chromium/src/+/579690
BUG=769155, 766611
[email protected]
(cherry picked from commit 3caef7b900b16af22a5eba78a27aef5516011e52)
Change-Id: I25a95c79755801463b15fb12047458c594bf24d6
Reviewed-on: https://chromium-review.googlesource.com/685379
Commit-Queue: Xida Chen <[email protected]>
Commit-Queue: Justin Novosad <[email protected]>
Reviewed-by: Xida Chen <[email protected]>
Reviewed-by: Olivia Lai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504748}
Reviewed-on: https://chromium-review.googlesource.com/695881
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#541}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[merge to 62] ash: Add more color to stylus notification icon.
[email protected]
(cherry picked from commit b75c5835d988ee297dc17d0c619dec3948dc0820)
TBR: [email protected]
Test: manual
Bug: 728457
Change-Id: Ied00cdbf911e1b38cf78cb79f668c17805765e39
Reviewed-on: https://chromium-review.googlesource.com/687854
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505484}
Reviewed-on: https://chromium-review.googlesource.com/695804
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#540}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[merge to 62] cros: Add MD icon for stylus battery notification.
(cherry picked from commit 1c42f2b81cee1860c4a53e7dac2976a684d81fcc)
TBR: [email protected]
Test: manual
Bug: 728457
Change-Id: Ie3486f519a1cdd6471a8f377e8e0a34ec55238c4
Reviewed-on: https://chromium-review.googlesource.com/678234
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503893}
Reviewed-on: https://chromium-review.googlesource.com/695742
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#539}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Return the primary display when the view doesn't have a window associated with it.
Bug: 769754
Change-Id: I909fed33dd12215b30c13b5d5c913337b56ef717
Reviewed-on: https://chromium-review.googlesource.com/690656
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Lucas Gadani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#505346}(cherry picked from commit bcaa2d0669a1e3333a11692aa638cfc3fd980f82)
[email protected]
Change-Id: I909fed33dd12215b30c13b5d5c913337b56ef717
Reviewed-on: https://chromium-review.googlesource.com/695064
Reviewed-by: Lucas Gadani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#538}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Change the width of message center 360 px
[email protected]
(cherry picked from commit f6b15e61ebaa0c71426256d44e02cf0ce8540481)
Bug: 763952
Change-Id: I136501e19559a03e1dea4e9bf371bc638fd056d0
Reviewed-on: https://chromium-review.googlesource.com/662977
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504589}
Reviewed-on: https://chromium-review.googlesource.com/695045
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#537}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Merge M62] [Cronet] Adjust some tests to run on fast devices/emulators.
Some devices/emulators run quickly so requests take less than 1ms,
which causes some test failures.
[email protected]
(cherry picked from commit fe4368e39afae6f3a454c23445b2b400c3b859ee)
Bug: 751184
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ib41da1c337bf7dc08316cf7d4f083f969e8b3280
Reviewed-on: https://chromium-review.googlesource.com/694904
Reviewed-by: Miriam Gershenson <[email protected]>
Commit-Queue: Miriam Gershenson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505607}
Reviewed-on: https://chromium-review.googlesource.com/695226
Reviewed-by: Paul Jensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#536}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Cached the migration policy value
When migration policy is changed during the user session, it might
enable ARC for user with unpredictable consequences. This change caches
the migration policy value for the session and uses the cached value.
This is a cherry-pick of
https://chromium-review.googlesource.com/c/chromium/src/+/692195
[email protected]
(cherry picked from commit 89599d06f398354261cbe71d416637e8e69b1bd7)
Bug: b:67013794
Test: Manual
Change-Id: Id2f8c5173b8b63045a50531ec7e8d271d8df41da
Reviewed-on: https://chromium-review.googlesource.com/692195
Commit-Queue: Igor <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505422}
Reviewed-on: https://chromium-review.googlesource.com/695201
Reviewed-by: Igor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#535}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Settings: Network: Show static IP configs
Also only shows the IP Address line when connected.
[email protected]
(cherry picked from commit 9b18ea898596222e903b648ca01be71d37365653)
Bug: 758890
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7e167f5755140f6498524967eee89d0fd73bf09e
Reviewed-on: https://chromium-review.googlesource.com/675844
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503768}
Reviewed-on: https://chromium-review.googlesource.com/695681
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#534}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Merge "kiosk: Fix regressions on network config flow"
> - Reset solidBackground flag when hiding kiosk launch splash screen
> so that the account picker screen for owner auth is shown properly;
> - Fix network config screen not center aligned problem;
>
> Bug: 763515
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I642890dd4d9ece0096127435764d63adffe227d0
> Reviewed-on: https://chromium-review.googlesource.com/685368
> Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#504551}
> (cherry picked from commit 972453885009579d30608ca22b9c11ec4ef1bbc9)
[email protected]
Change-Id: I55b9d0005bb2da49cd7a918af954b0df06406190
Reviewed-on: https://chromium-review.googlesource.com/695643
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#533}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}arc: Always call RemoveObserver() in ArcSettingsServiceImpl's dtor
Calling RemoveObserver() when not observing is no-op, while not calling it when observing can result in a use-after-free.
BUG=767627
[email protected]
(cherry picked from commit 7a3373b84a42ece3971e7b29a393570463aa7256)
Change-Id: I9bc0c766c7aee0440963b20bd0dc92bac28b4c7c
Reviewed-on: https://chromium-review.googlesource.com/686219
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Ryo Hashimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504603}
Reviewed-on: https://chromium-review.googlesource.com/694944
Reviewed-by: Ryo Hashimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#532}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Clear selectedItem property when menu items are cleared.
Keeping selectedIndex/selectedItem on clear can cause an issue in this scenario:
1) Tap the 1st menu item. selectedIndex is now 0.
2) Menu items are cleared. selectedIndex property is still 0.
3) New menu items are created in the menu.
4) Tap the 1st menu item again. As the selectedIndex is not changed,
selectedIndexChange event will not be dispatched.
5) menu's selectedIndecChanged function will not called, so the 1st item's
selected property remains false.
6) 'mouseup' event on the menu item will be ignored, since its selected property
is false.
This can be fixed by clearing selectedItem/selectedIndex when menu items are
cleared.
Bug: 768737
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a99b3882b3917f4fc63ca8b16e108a4538c4cac
Reviewed-on: https://chromium-review.googlesource.com/684101
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Naoki Fukino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504550}(cherry picked from commit d561a9f46130f9e2740ce4acdba45bb345753560)
Reviewed-on: https://chromium-review.googlesource.com/694761
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#531}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix bug where GpuMemoryBufferImplIOSurface breaks ICCProfile cache
All ICCProfile ids should be generated in the browser process.
A bug here caused an id to be generated in the renderer process,
resulting in conflicting ids and caches spitting out the wrong data.
The issue is that GpuMemoryBufferImplIOSurface::SetColorSpaceForScanout
gets the ICCProfile from a ColorSpace, which calls ICCProfile::FromData,
which creates a new profile id, potentially conflicting with ids sent
from the browser process.
Avoid this by having GpuMemoryBufferImplIOSurface query just the profile
data directly, avoiding the ICCProfile structure.
This area needs cleanup in crbug.com/766736.
Bug: 764352, (originally filed in 770219)
[email protected]
(cherry picked from commit 7a8be39db8c7bf5eda180ad00718f7d4d24a75bf)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9d2bd6ac4fd24fbdeb7d073bf5f9f6e9b32d00a6
Reviewed-on: https://chromium-review.googlesource.com/692708
Commit-Queue: ccameron chromium <[email protected]>
Reviewed-by: Fredrik Hubinette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505491}
Reviewed-on: https://chromium-review.googlesource.com/694543
Reviewed-by: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#530}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Incrementing VERSION to 62.0.3202.43
[email protected]
Change-Id: Ic0d417cc02af5130a8581a804774bae0408eb348
Reviewed-on: https://chromium-review.googlesource.com/694263
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#529}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Resolve zeroconf printer IPs in PrinterConfigurer.
It's possible that we have to setup a printer before
ZeroconfPrinterDetector has finished its scan. Notably, when a printer
is pre-selected in the PrintPreview dialog. To avoid installing printers
with uris we can't resolve, resolve the IP in configurer. As a bonus,
we now deselect the printer if it's not immedeately usable.
[email protected]
(cherry picked from commit adb0980f878f088970d492185438a3525b177dfc)
Bug: 769469
Change-Id: I96e07edd9a2eaf199f093408bbb6b8cf583fe851
Reviewed-on: https://chromium-review.googlesource.com/688030
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505208}
Reviewed-on: https://chromium-review.googlesource.com/693965
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#528}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Incrementing VERSION to 62.0.3202.42
[email protected]
Change-Id: Ifd30fad89e80c9687ec341a23befdae111dbef02
Reviewed-on: https://chromium-review.googlesource.com/693639
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#527}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Reland "More accurate WebVR API exception message"
This reverts commit 8b8180a6d363f2d07b3141d63f116038fd14b6a0.
And applied a fix on top it.
[email protected], [email protected], [email protected]
Bug: 764447
Change-Id: I8ebade1b184079bf60e85e6438251d8c7a0b1e83
Reviewed-on: https://chromium-review.googlesource.com/693517
Reviewed-by: Biao She <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#526}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Incrementing VERSION to 62.0.3202.41
[email protected]
Change-Id: Ieb96c9e1fcde81c03ef720029a171ec975db71d9
Reviewed-on: https://chromium-review.googlesource.com/693515
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#525}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Revert "More accurate WebVR API exception message"
This reverts commit a8247326522c7333a5d9d887d4d8632f7316a0f2.
Reason for revert:
Bad merge. Unused variable.
Original change's description:
> More accurate WebVR API exception message
>
> [email protected]
>
> (cherry picked from commit 2ada1d99198538352ade379b4d9d518b3e253211)
>
> Bug: 764447
> Change-Id: I914d1703cc5f3564503810fcbd0b0058e392fa7b
> Reviewed-on: https://chromium-review.googlesource.com/665418
> Commit-Queue: Biao She <[email protected]>
> Reviewed-by: David Dorwin <[email protected]>
> Reviewed-by: Brandon Jones <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#503001}
> Reviewed-on: https://chromium-review.googlesource.com/693011
> Reviewed-by: Biao She <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{#516}
> Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[email protected],[email protected],[email protected]
Change-Id: I6f516229ffa8d0a51b90b86713e90e3934d97b10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 764447
Reviewed-on: https://chromium-review.googlesource.com/693012
Reviewed-by: Biao She <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#524}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Remove Google Now UI settings
Changes:
Remove javascript/html code of Google Now.
BUG=731991
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I14bc3684b9654215d53cb03f87d32cf814a308b9
Reviewed-on: https://chromium-review.googlesource.com/688642
Reviewed-by: Vadim Tryshev <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#523}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix compile error introduced in 6614575900438cfea1c1099d469eb0707a3210e4
[email protected]
Bug: 740596, 770366
Change-Id: I05f3e3db42d8f6b4ffb15a1a118f5a896f0f0e75
Reviewed-on: https://chromium-review.googlesource.com/693300
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#522}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}cros: Scroll events anywhere on AppListView
can change app grid pages
New behavior: Scroll events (ET_MOUSEWHEEL and ET_SCROLL) used to modify
the app grid if the mouse was over the grid, and modify the AppListState
otherwise.
Now, we want scroll events to first try to move the grid. If this
succeds, set a timer to keep the stream of scrolling events from also
closing the AppListView.
If the scroll could not move the grid, allow it to modify the
AppListState.
I used a timer because there is no reliable way to both determine the
end of an ET_SCROLL and the end of a mousewheel scroll. We need to avoid
acting twice with one user intent to scroll one surface. The behavior of
this change was reviewed by UX/PM and approved for M61.
Misc refactoring:
- No longer need OnMouseWheel/OnScroll in AppsGridView because AppListView
will handle all scroll events.
- Broke AppListView::HandleScroll into a few different functions because
it was starting to do multiple things.
- In HandleScroll, also combined mousewheel and touchpad logic to avoid
code duplication.
- Added tests to AppsGridView while debugging. Also moved the scroll test
from FullscreenAppListPresenterDelegateTest to
AppListViewFullscreenTest.
TEST=manual and automated
BUG: 769356
Bug:
Change-Id: I69c05106faed5c8b50731c2461edfe2b2b67394c
Reviewed-on: https://chromium-review.googlesource.com/688637
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505112}
Reviewed-on: https://chromium-review.googlesource.com/692702
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#521}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Autofill] Credit card local save dialog shouldn't have window icon
Previously, all card save dialogs under the new UI would have the logo.
The logo should only apply to server card uploads, not local saves.
[email protected]
(cherry picked from commit 5d632f9cca131c286682e70b544319b52318479c)
Bug: 736944, 768951
Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056
Reviewed-on: https://chromium-review.googlesource.com/685503
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Mathieu Perreault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504817}
Reviewed-on: https://chromium-review.googlesource.com/692700
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#520}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Update Settings search page title for supervised user
Check whether the user is supervised when choosing the search page title
in CrOS settings. Do not use the version contains voice interaction if
the user is supervised.
BUG=b/66913130
[email protected]
(cherry picked from commit cf61daf467fbf96e839ab431f4d729af156de5e6)
Change-Id: Ie631f7e476959f7ce315a627d13c13dca1ffbfd7
Reviewed-on: https://chromium-review.googlesource.com/686040
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504827}
Reviewed-on: https://chromium-review.googlesource.com/692507
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#519}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}sync voice_interaction_enabled to ARC.
The flag needs to be synced since hotword does
not go through any entrance point in
ArcVoiceInteractionFrameworkService. For this
case we can only guard context but not the
invocation of voice interaction session.
BUG=b:65963302
TEST=Manual test
Cherry picked from:
I2cddd95b8018e18d79991602834451ebbe28e698
Change-Id: I2d7e80310c0d2308ab241416d059589aa0e87575
Reviewed-on: https://chromium-review.googlesource.com/689031
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#518}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix Tab key focus for voice interaciont OOBE
Prevent the focus to be moved into the system tray, so that user could
use tab key to change focus between buttons.
BUG=b/64535533
[email protected]
(cherry picked from commit e0c29fc72930dddd0055ce2a696520ff2c3bb8b4)
Change-Id: Id9bbf89c06fe970db011bb42ee684367bb96e6aa
Reviewed-on: https://chromium-review.googlesource.com/686062
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504857}
Reviewed-on: https://chromium-review.googlesource.com/693216
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#517}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}More accurate WebVR API exception message
[email protected]
(cherry picked from commit 2ada1d99198538352ade379b4d9d518b3e253211)
Bug: 764447
Change-Id: I914d1703cc5f3564503810fcbd0b0058e392fa7b
Reviewed-on: https://chromium-review.googlesource.com/665418
Commit-Queue: Biao She <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503001}
Reviewed-on: https://chromium-review.googlesource.com/693011
Reviewed-by: Biao She <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#516}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Exit metalayer on failed gesture if invoked from stylus button
This should minimize disruption when a user is writing/sketching
while accidentally holding down the stylus button.
[email protected]
(cherry picked from commit 0bd94b50fad420de3eb75252403a35210a7188d4)
Bug: 767441
Test: ash_unittests --gtest_filter=PaletteTrayTest*
Change-Id: I155d6c7b0997dd56680aaae8a005fba074a15865
Reviewed-on: https://chromium-review.googlesource.com/688486
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504843}
Reviewed-on: https://chromium-review.googlesource.com/692562
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#515}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix duplicated OptIn dialog for PlayStore
Rewrite the IsOobeOptInActive() method since voice
interaction OptIn flow could be inside session and could be active in
existing user.
For example, user decline PlayStore terms and voice interaction value prop,
but press the voice interaction shortcut later (after logout and login again).
In that case, there will be two PlayStore OptIn dialog, both OOBE
version and default version.
Also rewrite the unittest for the method in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/676488
BUG=b/65493952
[email protected]
(cherry picked from commit 6e1380c7bf8313bb9ae469ec39791e5030996bec)
Change-Id: I6a25d5483014952c2d699c92ae68cbe4e4a03493
Reviewed-on: https://chromium-review.googlesource.com/660921
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504496}
Reviewed-on: https://chromium-review.googlesource.com/693007
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#514}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Revert "cros: Scroll events anywhere on AppListView"
This reverts commit ad748185bcbd736a6ea3c263c1895e6d0dc31055.
Reason for revert: breaks compile:
../../ui/app_list/views/app_list_view.cc:1070:7: error: use of undeclared identifier 'Dismiss'
Dismiss();
Original change's description:
> cros: Scroll events anywhere on AppListView
>
> can change app grid pages
>
> New behavior: Scroll events (ET_MOUSEWHEEL and ET_SCROLL) used to modify
> the app grid if the mouse was over the grid, and modify the AppListState
> otherwise.
>
> Now, we want scroll events to first try to move the grid. If this
> succeds, set a timer to keep the stream of scrolling events from also
> closing the AppListView.
>
> If the scroll could not move the grid, allow it to modify the
> AppListState.
>
> I used a timer because there is no reliable way to both determine the
> end of an ET_SCROLL and the end of a mousewheel scroll. We need to avoid
> acting twice with one user intent to scroll one surface. The behavior of
> this change was reviewed by UX/PM and approved for M61.
>
> Misc refactoring:
> - No longer need OnMouseWheel/OnScroll in AppsGridView because AppListView
> will handle all scroll events.
> - Broke AppListView::HandleScroll into a few different functions because
> it was starting to do multiple things.
> - In HandleScroll, also combined mousewheel and touchpad logic to avoid
> code duplication.
> - Added tests to AppsGridView while debugging. Also moved the scroll test
> from FullscreenAppListPresenterDelegateTest to
> AppListViewFullscreenTest.
>
> TEST=manual and automated
> [email protected]
>
> (cherry picked from commit 07e06ef4282818ffab806565c0fc05bfc1a5892e)
>
> BUG: 769356
> Bug:
> Change-Id: I15396b9845404d0c13de916e01ef62ea9af22ae8
> Reviewed-on: https://chromium-review.googlesource.com/688637
> Commit-Queue: Alex Newcomer <[email protected]>
> Reviewed-by: Xiyuan Xia <[email protected]>
> Reviewed-by: Yury Khmel <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#505112}
> Reviewed-on: https://chromium-review.googlesource.com/692995
> Reviewed-by: Alex Newcomer <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{#510}
> Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[email protected],[email protected],[email protected]
Change-Id: I1bdc6f5886aa5af81d341a8caa7635847e841139
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/692751
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#513}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}m62: cros: fix no type name MediaSession compile error in m62
TBR: [email protected]
Bug: none
Test: still complies
Change-Id: I607bb76b35cd9e4d40e1bf8573ca030812caa772
Reviewed-on: https://chromium-review.googlesource.com/693002
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#512}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix bug in localstorage migration that could leave DB in inconsistent state.
This extends the LevelDBWrapperImpl API to enable users of that class to
fixup broken data in the database. That API is then used to fix
incorrectly encoded keys, which should fix all weirdness around
removeItem that was being observed.
BUG=765524
[email protected]
(cherry picked from commit e8fdb3d52ab59c69baabcda544690100a2a136ea)
Change-Id: I4049445d46d30925774c2fec9dfd4dcdaba12e04
Reviewed-on: https://chromium-review.googlesource.com/678250
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Michael Nordman <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504251}
Reviewed-on: https://chromium-review.googlesource.com/692632
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#511}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}cros: Scroll events anywhere on AppListView
can change app grid pages
New behavior: Scroll events (ET_MOUSEWHEEL and ET_SCROLL) used to modify
the app grid if the mouse was over the grid, and modify the AppListState
otherwise.
Now, we want scroll events to first try to move the grid. If this
succeds, set a timer to keep the stream of scrolling events from also
closing the AppListView.
If the scroll could not move the grid, allow it to modify the
AppListState.
I used a timer because there is no reliable way to both determine the
end of an ET_SCROLL and the end of a mousewheel scroll. We need to avoid
acting twice with one user intent to scroll one surface. The behavior of
this change was reviewed by UX/PM and approved for M61.
Misc refactoring:
- No longer need OnMouseWheel/OnScroll in AppsGridView because AppListView
will handle all scroll events.
- Broke AppListView::HandleScroll into a few different functions because
it was starting to do multiple things.
- In HandleScroll, also combined mousewheel and touchpad logic to avoid
code duplication.
- Added tests to AppsGridView while debugging. Also moved the scroll test
from FullscreenAppListPresenterDelegateTest to
AppListViewFullscreenTest.
TEST=manual and automated
[email protected]
(cherry picked from commit 07e06ef4282818ffab806565c0fc05bfc1a5892e)
BUG: 769356
Bug:
Change-Id: I15396b9845404d0c13de916e01ef62ea9af22ae8
Reviewed-on: https://chromium-review.googlesource.com/688637
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#505112}
Reviewed-on: https://chromium-review.googlesource.com/692995
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#510}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[ios] Fix snapshot when reporting an issue.
This CL fixes a bug that was introduced while refactoring
IDC_REPORT_AN_ISSUE command. The command execution was originally
wrapped in a dispatch_async so as to give enough time for the tools
menu to disappear before taking a snapshot of the screen.
The refactoring removed this necessary dispatch_async call.
Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/638840
Bug: 761964
Change-Id: Idf498559c5f6d5963204cb35e7efad5def1d3b81
Reviewed-on: https://chromium-review.googlesource.com/662405
Reviewed-by: edchin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#501285}(cherry picked from commit 6964b655e8b1cf70d19365d885fdccc0bfa64a04)
Reviewed-on: https://chromium-review.googlesource.com/692555
Cr-Commit-Position: refs/branch-heads/3202@{#509}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Increase expected shell apk version to 26.
This is for pushing the latest template which includes polished WebApk dialog.
Bug: 765814
Change-Id: Iaee941a63ae0bf85f36b6d0497973a7f1624dac1
Reviewed-on: https://chromium-review.googlesource.com/675304
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503256}(cherry picked from commit fa95bee3cf393f2b6681396e5a7969c56fc275c3)
Reviewed-on: https://chromium-review.googlesource.com/692494
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#508}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Update quick action widget before display.
This avoids a flicker on iOS9.
Bug: 764938
Change-Id: I159da9a875e140dbecd7142ee2a64fca9234b699
Reviewed-on: https://chromium-review.googlesource.com/670707
Reviewed-by: Jean-François Geyelin <[email protected]>
Commit-Queue: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#502541}(cherry picked from commit 9d8037a736baeee658283be62e8f9d348ffac0a0)
Reviewed-on: https://chromium-review.googlesource.com/691998
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#507}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Reland] Delete notification site channels when all data is being cleared
When the user deletes all data for the Chromium application, we need to
make sure that site channels that were created will be removed as well.
The data associated with site channels in preferences will be deleted
implicitly, as the application data directory will be blown away
immediately after this call.
This CL was co-authored by Anita Woodruff <[email protected]>
BUG=765756
TBR=nyquist (previously reviewed)
Change-Id: Iace8ba6db20c87bbcb3c93f29f3ea808e053ab41
Reviewed-on: https://chromium-review.googlesource.com/680556
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503982}(cherry picked from commit d46416654b8587eb3e262d712222880e15553097)
Reviewed-on: https://chromium-review.googlesource.com/692754
Cr-Commit-Position: refs/branch-heads/3202@{#506}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Initialize PathUtils for the decoder service
This fixes a crash that's observed on certain Android M devices.
BUG=761060
Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8
Reviewed-on: https://chromium-review.googlesource.com/663363
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#501635}(cherry picked from commit a2dc3e7214f2d70c23ece4dd908b48e33bed15a0)
Reviewed-on: https://chromium-review.googlesource.com/692038
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#505}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Merge "[NTP::Push] Ignore and report received messages when not..." M62.
This is a merge of https://chromium-review.googlesource.com/668402 into
M62 (branch 3202). The merge applied cleanly, I've also built it locally
and tested (both manually on device and unittests).
Original description:
Previously, the handler just crashed when it was not listening and a
message was received. Unfortunately, the metric to track received
messages is reported after that code, so we do not observe these
messages in our data.
In this CL:
1) Ignore received messages when not listening.
2) Report whether the handler is listening when a message is received
(in addition to whether it contains pushed news).
[email protected]
(cherry picked from commit 1dc820d46191e5a48ad22b29264d43435fd5b805)
Bug: 763520
Change-Id: Ib35962d0584aeb39bf43cf2ca2e84a5efba99359
Reviewed-on: https://chromium-review.googlesource.com/668402
Commit-Queue: vitaliii <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#502557}
Reviewed-on: https://chromium-review.googlesource.com/691668
Reviewed-by: vitaliii <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#504}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Update color profile when moving window tree
To DesktopWindowTreeHostWin, add CheckForMonitorChange, a
lightweight check to see if the HWND has changed the
HMONITOR it is on. Call this method when resizing or
moving the window.
If this method sees that the HMONITOR has changed, call
the method aura::WindowTreeHost:OnHostDisplayChanged,
which will update the compositor color space based on the
more expensive call to query the current display::Display.
[email protected]
(cherry picked from commit fd90d276245b7552cfd1bf3855ea668c62362a6a)
Bug: 735613
Change-Id: I59e4a79cad599f70e63e898f4a7eacc2dbadc6d2
Reviewed-on: https://chromium-review.googlesource.com/674048
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503684}
Reviewed-on: https://chromium-review.googlesource.com/691439
Reviewed-by: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#503}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Update MP4 video pixel test expectation
This needs to be updated due to bt709 interpretation change in
crbug.com/763260
[email protected]
(cherry picked from commit dec4b78a6b54fd15ac764c44c4194a64658413a0)
Bug: 763260 (merge from 768608)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9321869000d10f79f82f9dd4ca778e6517ed7ef7
Reviewed-on: https://chromium-review.googlesource.com/683078
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504264}
Reviewed-on: https://chromium-review.googlesource.com/691519
Reviewed-by: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#502}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Always use sRGB transfer function for bt709
Previous behavior was:
* If the destination transfer function is sRGB, use the sRGB transfer
function
* Otherwise use the transfer function from the bt709 spec
This new behavior will more closely match other platforms and user
studies.
[email protected]
(cherry picked from commit 41d66154969ea403326bdd7b96b959ff6ad7fb77)
Bug: 763260
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaf49c0c8a5a20e53248854b6a7ecad72d685436d
Reviewed-on: https://chromium-review.googlesource.com/673165
Commit-Queue: ccameron chromium <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Reviewed-by: Fredrik Hubinette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504175}
Reviewed-on: https://chromium-review.googlesource.com/691125
Reviewed-by: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#501}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Merge M62: "Allow lookup of videodecoder service to fix HW video decoding on macOS 10.13"
Tha macOS sandbox has apparently changed in 10.13. If we don't allow
lookup of the global Mach service com.apple.coremedia.videodecoder,
VTDecompressionSessionCreate() fails with
kVTVideoDecoderNotAvailableNowErr for some videos.
[email protected]
(cherry picked from commit e0710753b51f9c81b9ab8b11a29240c437053109)
Bug: 767037
Change-Id: I4fee235d3808a504d57660976ef96b3a0a0f54d7
Reviewed-on: https://chromium-review.googlesource.com/677290
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503747}
Reviewed-on: https://chromium-review.googlesource.com/691050
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#500}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}m62 merge: cros: make VK_MEDIA_PLAY_PAUSE handle media contents on chrome browser
changes:
(1) Provide the support to make VK_MEDIA_PLAY_PAUSE handle toggling play
and pause on active browser's active tab. If there is an active browser,
then instead of dispatching this event, handle active tab's media session
play pause.
(2) add FindBrowserWithActiveWindow() in browser_finder.h.
(3) add Activate/IsActive in TestBrowserWindowAura, which is hooked to
the aura window's activation.
(4) refactor test in MultiUserWindowManagerChromeOSTest for new change.
TBR: [email protected], [email protected]
state on active browser's active tab.
(cherry picked from commit cb6871bbc25c3992e5d6656081308a493ce94cb2)
Bug: 763483
Test: tested on device, the play/pause button could toggle the playback
Change-Id: Ied566bf1f6c84edeaa762bb3a6e133720c1291c5
Reviewed-on: https://chromium-review.googlesource.com/666199
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503510}
Reviewed-on: https://chromium-review.googlesource.com/691185
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#499}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Don't use base URL and history URL for subframe navigations.
BUG=768575
TEST=See bug for repro steps
[email protected]
(cherry picked from commit c44784177e34421934fe40e7218bb350bb466d66)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I0c64d13dcea6a13b622ec250d55327972fe77390
Reviewed-on: https://chromium-review.googlesource.com/683341
Commit-Queue: Charlie Reis (catching up) <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504302}
Reviewed-on: https://chromium-review.googlesource.com/691184
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#498}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Incrementing VERSION to 62.0.3202.40
[email protected]
Change-Id: I18126a540d39e814e66eb06c0bb15aecbc0fc13d
Reviewed-on: https://chromium-review.googlesource.com/691337
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#497}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix hit testing on hidpi
The underline issue of this bug is that there is a foreground_layer_
that should participate in hit testing, but we didn't set it in
CompositedLayerMapping.
This CL makes the foreground_layer_ hit testable.
Bug: 767908
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icdede182921f576fe262f74f9a89cd6194563005
Reviewed-on: https://chromium-review.googlesource.com/685537
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504521}(cherry picked from commit 50837c25c6a202ef3f2a9eeac56497a753431d11)
Reviewed-on: https://chromium-review.googlesource.com/691308
Reviewed-by: Xida Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#496}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}exo: Fix issues with viewports and transforms
The crop rectangle is set via the Wayland interface in post-transform
buffer coordinates. To generate UV coordinates, the crop rectangle must
be transformed by the inverse transform.
The forward transformation from "buffer" pixel space to target space
also turned out to be incorrect when there was a crop, there was no
viewport, and the buffer transformation was 90 or 270. The construction
of that transformation matrix now makes sense, unlike before.
The fixed up code shares a common buffer transformation matrix (rotating
in normalized coordinates around 0.5, 0.5), but that is all that can be
shared. The two transformations otherwise apply different scaling and
translations to get to their respective coordinate spaces otherwise.
Correct functionality was verified with a test app that sets a crop
rectangle while also setting/disabling the viewport rectangle, while
cycling through buffers at different rotations. The test app was run on
Chrome OS as well as under the Weston reference implementation.
BUG=751232
[email protected]
(cherry picked from commit 0a3045f2254a248df9ca4d0da2229ad62afdd1bb)
Change-Id: Ibca12b6d722891076db4cb053d133d128ee78889
Reviewed-on: https://chromium-review.googlesource.com/653494
Commit-Queue: Lloyd Pique <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#502440}
Reviewed-on: https://chromium-review.googlesource.com/685936
Cr-Commit-Position: refs/branch-heads/3202@{#495}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}DevTools: make sure there's a single cpu throttler thread.
BUG=765074
[email protected]
(cherry picked from commit 241f91f256d5ee44d140fa9f00333648c3e65cc7)
Change-Id: Ifde666f07b568d3e87852b10a6cab8fc7372bce8
Reviewed-on: https://chromium-review.googlesource.com/669902
Commit-Queue: Alexei Filippov <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503029}
Reviewed-on: https://chromium-review.googlesource.com/691137
Reviewed-by: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#494}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Set note taking apps enabled on lock screen by default
Bug: 767703
[email protected] (for policy_browsertest.cc), [email protected]
(cherry picked from commit 579f2d08bd77ed88f6986f30429622e0ecbe1762)
Change-Id: I3215d5f46aefc3fb82fc2cbd7f4b854af54a74bf
Reviewed-on: https://chromium-review.googlesource.com/676254
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503910}
Reviewed-on: https://chromium-review.googlesource.com/690775
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#493}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Merge M-62][Payments] Don't crash for duplicate payment methods.
Before this patch, an Android payment app with duplicate default and
supported URL payment method would crash Chrome due to a null pointer
dereference if the payment method manifest contained
"supported_origins": "*".
This patch adds an integration test
testDuplicateDefaultAndSupportedMethodAndAllOriginsSupported which
crashes without a fix due to mMethodToSupportedAppsMapping map omitting
supported payment method names that are duplicates of the default
payment method name of an Android payment app. The fix is to check for
a null set of supported apps before iterating over it. The new test
passes after the fix has been applied.
After this patch, an Android payment app with duplicate default and
supported URL payment method does not crash Chrome, even if the payment
method manifest contains "supported_origins": "*". The payment app can
be used in Chrome.
Bug: 756665
Change-Id: I58756942baeec7b365c71fcf44fd29a513190b65
Reviewed-on: https://chromium-review.googlesource.com/687295
Reviewed-by: Mathieu Perreault <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504700}(cherry picked from commit cbdf643f13cacd3491febd0cd146b2b1158a27d4)
Reviewed-on: https://chromium-review.googlesource.com/690514
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#492}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix crash when receiving a RequestMove IPC from lingering Keyboard UI reference
[email protected]
(cherry picked from commit 82dc5ad66932263148dd9f33d52ed5e3edbab562)
Bug: 768164
Change-Id: I020d1f38af6c31d4929505ea47e692ad6d86da5b
Reviewed-on: https://chromium-review.googlesource.com/680250
Commit-Queue: Blake O'Hare <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504005}
Reviewed-on: https://chromium-review.googlesource.com/688383
Cr-Commit-Position: refs/branch-heads/3202@{#491}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Remove minimum width from notifiation button.
According to the UX review https://crbug.com/767253 , notifiation
buttons should not have minimum width.
TEST=manual
BUG=767253
[email protected]
(cherry picked from commit 02f1b28679bdd124b5ede9e6f7e635ad425d2171)
Change-Id: Id92c980745fe91bf6d325c578cdbab181c0c9ce3
Reviewed-on: https://chromium-review.googlesource.com/676547
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503652}
Reviewed-on: https://chromium-review.googlesource.com/686033
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#490}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Incrementing VERSION to 62.0.3202.39
[email protected]
Change-Id: I1b8becd3a0d4d91dfff75d4c7aaaad66ffb2e447
Reviewed-on: https://chromium-review.googlesource.com/688578
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#489}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Home] Make the bottom navigation menu opaque.
Bug: 762823
Change-Id: If75050169ee293d12c1173adc12cbcce9c5924ef
Reviewed-on: https://chromium-review.googlesource.com/677487
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Troy Hildebrandt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503533}(cherry picked from commit 44a92c376300866c9885a99400c2aa41fe21a06e)
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/688658
Cr-Commit-Position: refs/branch-heads/3202@{#488}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add a gn variable to configure Chrome variants.
Add ios_chrome_app_variants variable to allow to control which
variants of chrome are built when google branded.
(cherry picked from commit fda1785a9e978f9d37bfe78d2a8ab1e199d6f39c)
Bug: 764286
Change-Id: I6046c5eab85435f6890ac79f504e02a9f4c4b5d4
Reviewed-on: https://chromium-review.googlesource.com/677450
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503718}
Reviewed-on: https://chromium-review.googlesource.com/688397
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#487}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Move app icon for "chrome" to asset catalog.
Application build with iOS 11.0 SDK need to have their app icon
into the compiled asset catalog, so convert the "chrome" target
to this new way of doing.
(cherry picked from commit a1cfa18b274cdd035a89790af624b88a8f75d723)
Bug: 764286
Change-Id: I5f2fefecd68c0d92bbd5a9e78cddb5f3e2fc9361
Reviewed-on: https://chromium-review.googlesource.com/671363
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503714}
Reviewed-on: https://chromium-review.googlesource.com/688280
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#486}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add support for building variants of app on iOS.
Chrome on iOS needs to build the same app (exact same binary)
with different application icons (i.e. with different compiled
asset catalogs).
Add a "variants" property to "ios_app_bundle" template that
contains a list of scope, each defining the variant "name" and
the list of additional "bundle_deps".
When the "variants" property is defined, the executable will
be linked once, but n application bundles will be generated in
$root_out_dir/variants/$variant_name and a copy of the first
variant will be created in $root_out_dir.
The hardlink.py script is used to copy the first variant (it
tries to use hardlink if possible, but fallback to copy if it
fails).
(cherry picked from commit 7aac0a1de0b0c010efde682ad414770eb04eb4b0)
Bug: 764286
Change-Id: I0ea18e757c891ae884ba22c07fe20946715d1d0a
Reviewed-on: https://chromium-review.googlesource.com/677386
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503710}
Reviewed-on: https://chromium-review.googlesource.com/688396
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#485}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Fix of iOS Cronet build fails with "Duplicate output file"
(cherry picked from commit ba7d3df481d3540586c5440add57d859d498d193)
Bug: 768431
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5e5e9f6fa34d399c477dd828c900c13e32258eb3
Reviewed-on: https://chromium-review.googlesource.com/685556
Reviewed-by: Misha Efimov <[email protected]>
Commit-Queue: Andrei Kapishnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504553}
Reviewed-on: https://chromium-review.googlesource.com/688395
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#484}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Convert iOS/macOS build to use bundle_contents_dir.
A new property bundle_contents_dir was added to create_bundle to
allow distinction between the bundle directory and the directory
where the content should be added.
On iOS, this property should be equal to $bundle_root_dir, while
on macOS it should be equal to $bundle_root_dir/Contents. This
will allow creating bundles in a sub-directory of $root_out_dir.
(cherry picked from commit 6f8fe3dc09d5768956728b89ff4fb71dff1e92bb)
Bug: 764286
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I7742d7b69b3a306ddd405e5dc7e6feab98e26454
Reviewed-on: https://chromium-review.googlesource.com/675603
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503679}
Reviewed-on: https://chromium-review.googlesource.com/688279
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#483}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add support for partial Info.plist from actool.
Change ios_app_bundle template to merge the generated Info.plist
with the partial .plist created by the asset catalog compiler to
support compiling application icon to Assets.car as is required
for application built with iOS 11.0 SDK.
Quote args of compile_xcasset.py in build/toolchain/mac/BUILD.gn
as some of them may be empty or contain shell special characters
(mostly spaces).
(cherry picked from commit d73f3454a10aa2d20f50f1b145148380649e7849)
Bug: 764286
Change-Id: I453f3cbb34c82483bace9900c49e0f3b351b2635
Reviewed-on: https://chromium-review.googlesource.com/671050
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503129}
Reviewed-on: https://chromium-review.googlesource.com/688278
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#482}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add support for --partial-info-plist to compile_xcassets.py.
The asset catalog compiler (actool) can generate a partial Info.plist
file that needs to be merged with the application Info.plist at build
time (this is needed to support application icon in Assets.car).
Add a --partial-info-plist flag to compile_xcassets.py that can be
used to control the path of the generated partial Info.plist. Also
inspect the list of asset catalogs to be compiled and pass correct
flags to enable their proper treatment by actool (.appiconset and
.launchimage are the only two supported currently).
If --partial-info-plist is not passed or empty, and the compiler
need this flag (i.e. if any special asset catalog is compiled), then
the script create a temporary file and pass it to the compiler.
(cherry picked from commit 2d534feab40dd363424f5437ec4ba3579e172d55)
Bug: 764286
Change-Id: I3f51e5b6ac65919275a3fafb3408d02686105e21
Reviewed-on: https://chromium-review.googlesource.com/668976
Reviewed-by: Scott Graham <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503110}
Reviewed-on: https://chromium-review.googlesource.com/688277
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#481}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Uniformize asset catalog declarations in ios/.
The template to declare asset catalog (imageset, appicon, launchimage)
copy the resources into a .xcassets directory in $target_gen_dir, thus
there is no need to put them in a .xcassets directory in the checkout.
Standardize the asset catalog declarations so that the asset catalogs
are in a resources/ sub-directory, the corresponding target is in the
resources/BUILD.gn file.
(cherry picked from commit 6a5b217553e95e1ef14b07dd2c4fd704f5b2b9ef)
Bug: none
Change-Id: I56a751add67f7d77e95dcb0b213dfd756f129310
Reviewed-on: https://chromium-review.googlesource.com/672704
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#502863}
Reviewed-on: https://chromium-review.googlesource.com/688614
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#480}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}cros: Don't allow launcher to be dragged below shelf height
This change ensures the launcher cant be dragged below the shelf when
the drag originates on the AppListView.
[email protected]
(cherry picked from commit d3a91c4800506381896e480e045678b1fee948a6)
Bug: 765522
Change-Id: I8101f8f5568ff72cf91013199fe7c44438a2c679
Reviewed-on: https://chromium-review.googlesource.com/679855
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504169}
Reviewed-on: https://chromium-review.googlesource.com/688497
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#479}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Disable stylus barrel button for a brief period after pen up.
This should prevent metalayer triggering when a user is
writing/sketching while accidentally holding down the stylus button.
[email protected]
(cherry picked from commit 918b4f882ef09498b7649b5f7b673f71f115fbfe)
Bug: 767440
Test: ash_unittests --gtest_filter=PaletteTrayTest*
Change-Id: I98a1dc4be2bb888c6cc06e3e93a60b73b56c6a8d
Reviewed-on: https://chromium-review.googlesource.com/683254
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504419}
Reviewed-on: https://chromium-review.googlesource.com/687999
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#478}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Send homescreen information when start voice interaction session
Check whether there is other window visible (active window exists)
when start voice interaction session and send the information to ARC
Container.
BUG=b/65601064
[email protected]
(cherry picked from commit 664295bee1581db030c5a2f0c9ea9c7f71140fcb)
Change-Id: I4d01f3f7b3b196fdcc6059efe4001b8cecfe1c9b
Reviewed-on: https://chromium-review.googlesource.com/676231
Reviewed-by: Luis Hector Chavez <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504139}
Reviewed-on: https://chromium-review.googlesource.com/688216
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#477}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Disable stylus barrel button on lock screen.
When on lock screen, stylus touch with the barrel button
press should not activate the Assistant pen.
[email protected]
(cherry picked from commit 255dfe4f8c27ad382d15ae9ce35db1d4c41f3d79)
Bug: 767079
Test: ash_unittests --gtest_filter=PaletteTrayTest*
Change-Id: I34da657cc8a3cb9382cf69dbfba38d73ac92e3d4
Reviewed-on: https://chromium-review.googlesource.com/675704
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503310}
Reviewed-on: https://chromium-review.googlesource.com/687866
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#476}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Payment Request] Adds a navigation bar to the country picker.
Video of the fix in action:
https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing
This is a second attempt at fixing this issue. The first one was reverted due to failures in ios_showcase_egtests on smaller devices. Those failures were caused by the fact that some elements were off-screen, and EarlGrey was unable to select them.
Bug: 767154
Change-Id: I60df99bf12a0a0858c900faa6544bf562667eda8
Reviewed-on: https://chromium-review.googlesource.com/678020
Reviewed-by: edchin <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Marc-Antoine Courteau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503771}(cherry picked from commit 266e6ebd419359717c8d6aadf9311717765883f7)
Reviewed-on: https://chromium-review.googlesource.com/687875
Reviewed-by: Marc-Antoine Courteau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#475}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Distinguish invoke source for voice intearction session
The source to start the session could be distinguished by whether
StartVoiceInteractionSession (for long press) or
ToggleVoiceInteractionSession (for voice interaction key) is called.
If framework instance is not ready, the request will be stored to
process later, but the source information will lost (Start*Session will
be called no matter what the source is).
This CL add a flag to store the pending request.
BUG=b/65739738
[email protected]
(cherry picked from commit 71cc4cde2be4a15123b8d41786e93161cb86ad87)
Change-Id: Ieb0ba460cf229a85d1f082ee28cbad171c57bd4a
Reviewed-on: https://chromium-review.googlesource.com/671869
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503248}
Reviewed-on: https://chromium-review.googlesource.com/688016
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#474}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}cros: voice interaction service subscribes to hotword signal.
BUG=b:62065175
TEST=unit_tests --gtest_filter=\
ArcVoiceInteractionFrameworkServiceTest.HotwordTriggered
CQ-DEPEND=CL:673048
[email protected]
(cherry picked from commit 641f5fa04a2c40ca217563f4d033538c6e3de2d5)
Change-Id: Ia4d48d61729f9cef44a514d02fd09dd26d523d0e
Reviewed-on: https://chromium-review.googlesource.com/661918
Commit-Queue: Muyuan Li <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503071}
Reviewed-on: https://chromium-review.googlesource.com/688015
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#473}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}disable voice interaction settings when value_prop not accepted.
BUG=b:65838828
TEST=manual
[email protected]
(cherry picked from commit 819711b2fed4531345bcf02f33394220930b97d6)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1352ab37ece413bfb3380a005df594b36f9458d4
Reviewed-on: https://chromium-review.googlesource.com/673855
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Muyuan Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503244}
Reviewed-on: https://chromium-review.googlesource.com/688094
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#472}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[CrOS Tether] Adjust how BLE advertisements/scans are synchronized.
Previously, we would rate-limit sending BLE advertisements/discovery
commands to Bluetooth such that at most one command is sent every 200ms.
This CL ensures that there is at least a 200ms gap between the end of
one command and the start of the next. The Bluetooth team found that
some commands can take over 200ms each to complete, which can cause the
previous rate-limiting strategy to fail to avoid race conditions.
[email protected]
(cherry picked from commit 7d1d83812e2124d547d7c073616c7c7aed02fae6)
Bug: 768523, 768026, 672263
Change-Id: Ibd234008ebeb6febff7f6eebbbbbcbcde443a9d9
Reviewed-on: https://chromium-review.googlesource.com/685753
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504722}
Reviewed-on: https://chromium-review.googlesource.com/688074
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#471}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}[Merge to M62]Launcher should never be dragged below the shelf top.
[email protected]
Changes,
1. Add GetBackgroundAlphaValue in ShelfWidget to get the alpha value of the
given shelf background type.
2. Update the position of launcher during drag so that it will never be dragged
below the shelf top.
3. Update the logic of GetAppListBackgroundOpacityOnShelfOpacity. Launcher
should keep the same opacity of shelf when it is not higher than shelf top.
Bug: 765522
Change-Id: I20f8ea2ca34a597c1135ca95164870e3c8bf4bf0
Reviewed-on: https://chromium-review.googlesource.com/686097
Reviewed-by: min c <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#470}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add support for partial Info.plist to codesign.py script.
The asset catalog compiler may generate a partial Info.plist file
to merge with the bundle Info.plist; add support for creating the
bundle Info.plist to codesign.py script.
(cherry picked from commit 54d19130114243bc339f5fb256dcff7ea99a5b7a)
Bug: 764286
Change-Id: Ie2664f7b81907deca9c65dfb37834da8dcb15e69
Reviewed-on: https://chromium-review.googlesource.com/671224
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Eric Noyau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#502605}
Reviewed-on: https://chromium-review.googlesource.com/686768
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#469}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Add additional template for the different types of asset catalogs.
Add additional templates to compiled .appiconset and .launchimage
asset catalog types and rename the file defining the templates to
build/config/ios/asset_catalog.gni.
Leave a forwarding .gni named build/config/ios/imageset.gni as the
downstream code still reference this path. The file will be removed
in a followup CL once the downstream code has been fixed to use the
new path.
[email protected] (for remoting/ios/app/resources/BUILD.gn)
(cherry picked from commit 39ee46494805e717c7aca8f35f4d7acadaf43ce0)
Bug: 764286
Change-Id: Ia229d1bcbbcbeb828103ff283197120da2a21b85
Reviewed-on: https://chromium-review.googlesource.com/671264
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Eric Noyau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#502603}
Reviewed-on: https://chromium-review.googlesource.com/687134
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#468}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Chrome OS EULA screen: update focus ring size.
[email protected]
(cherry picked from commit 9cb8fa9df0db7a0d55950527766d7227c7c8d23e)
Bug: 760490
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e0046a02ad521fdf060e2677ae7d657a602a3d0
Reviewed-on: https://chromium-review.googlesource.com/682154
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#504150}
Reviewed-on: https://chromium-review.googlesource.com/686835
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#467}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Reland "[Merge to M62] Send TPM version information in a structured format"
[email protected]
This is a reland of 67d32e5175cc89848cc707b6d8e0632a41315489
Original change's description:
> [Merge to M62] Send TPM version information in a structured format
>
> CrOS CL @ crrev.com/c/663541
>
> [email protected],[email protected],[email protected]
>
> (cherry picked from commit 3c080cbeb3c4dca66c47670224db12fd3608ef09)
>
> Bug: chromium:764451
> Change-Id: I8982adeaf8ac1b89fe6c339513b1cf22efaed303
> Reviewed-on: https://chromium-review.googlesource.com/663548
> Commit-Queue: Ivan Šandrk <[email protected]>
> Reviewed-by: Ryo Hashimoto <[email protected]>
> Reviewed-by: Bartosz Fabianowski <[email protected]>
> Reviewed-by: Achuith Bhandarkar <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#502862}
> Reviewed-on: https://chromium-review.googlesource.com/683114
> Reviewed-by: Ivan Šandrk <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{#438}
> Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
Bug: chromium:764451
Change-Id: I0108b3a1cbf01f63d8cf1dfd68fe0f8122f09213
Reviewed-on: https://chromium-review.googlesource.com/686374
Reviewed-by: Ivan Šandrk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#466}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Revert "[Merge to M62] Send TPM version information in a structured format"
This reverts commit 67d32e5175cc89848cc707b6d8e0632a41315489.
Reason for revert: Breaking M62 build, no DBusMethodCallback in M62.
Original change's description:
> [Merge to M62] Send TPM version information in a structured format
>
> CrOS CL @ crrev.com/c/663541
>
> [email protected],[email protected],[email protected]
>
> (cherry picked from commit 3c080cbeb3c4dca66c47670224db12fd3608ef09)
>
> Bug: chromium:764451
> Change-Id: I8982adeaf8ac1b89fe6c339513b1cf22efaed303
> Reviewed-on: https://chromium-review.googlesource.com/663548
> Commit-Queue: Ivan Šandrk <[email protected]>
> Reviewed-by: Ryo Hashimoto <[email protected]>
> Reviewed-by: Bartosz Fabianowski <[email protected]>
> Reviewed-by: Achuith Bhandarkar <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#502862}
> Reviewed-on: https://chromium-review.googlesource.com/683114
> Reviewed-by: Ivan Šandrk <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{#438}
> Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:764451
Change-Id: I41530a5341ccf49d41238d6a6032efeeffe32991
Reviewed-on: https://chromium-review.googlesource.com/686234
Reviewed-by: Ivan Šandrk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#465}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}Also take focus for notifications on tap.
Previously, you could inline reply on a notification only using the
mouse.
Bug: 767327
Bug: b/66215638
Change-Id: I4999ade9bb7d07e5d81c5d8e2451600652c04521
Reviewed-on: https://chromium-review.googlesource.com/676687
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Eliot Courtney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#503382}(cherry picked from commit 5fcfec640f62098a4e8b2196b09e7566a5576e26)
Reviewed-on: https://chromium-review.googlesource.com/686134
Reviewed-by: Eliot Courtney <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#464}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
![ios/chrome/app/resources/launchscreen_app_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/app/resources/launchscreen_app_logo.imageset/launchscreen_app_logo%402x.png){kind=link}
![ios/chrome/app/resources/launchscreen_app_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/app/resources/launchscreen_app_logo.imageset/launchscreen_app_logo%403x.png){kind=link}
![ios/chrome/app/resources/launchscreen_brand_name.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/app/resources/launchscreen_brand_name.imageset/launchscreen_brand_name%402x.png){kind=link}
![ios/chrome/app/resources/launchscreen_brand_name.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/app/resources/launchscreen_brand_name.imageset/launchscreen_brand_name%403x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/error_icon.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/error_icon.imageset/error_icon%402x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/error_icon.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/error_icon.imageset/error_icon%403x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/file_icon_body.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/file_icon_body.imageset/file_icon_body%402x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/file_icon_body.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/file_icon_body.imageset/file_icon_body%403x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/file_icon_fold.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/file_icon_fold.imageset/file_icon_fold%402x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/file_icon_fold.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/file_icon_fold.imageset/file_icon_fold%403x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/file_icon_fold_complete.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/file_icon_fold_complete.imageset/file_icon_fold_complete%402x.png){kind=link}
![ios/chrome/browser/ui/downloads/resources/file_icon_fold_complete.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/downloads/resources/file_icon_fold_complete.imageset/file_icon_fold_complete%403x.png){kind=link}
![ios/chrome/browser/ui/first_run/resources/checkbox.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/first_run/resources/checkbox.imageset/checkbox%402x.png){kind=link}
![ios/chrome/browser/ui/first_run/resources/checkbox.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/first_run/resources/checkbox.imageset/checkbox%403x.png){kind=link}
![ios/chrome/browser/ui/first_run/resources/checkbox_checked.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/first_run/resources/checkbox_checked.imageset/checkbox_checked%402x.png){kind=link}
![ios/chrome/browser/ui/first_run/resources/checkbox_checked.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/first_run/resources/checkbox_checked.imageset/checkbox_checked%403x.png){kind=link}
![ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_off.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_off.imageset/torch_off%402x.png){kind=link}
![ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_off.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_off.imageset/torch_off%403x.png){kind=link}
![ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_on.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_on.imageset/torch_on%402x.png){kind=link}
![ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_on.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/ee8e4570ef89fad08e46f1b18eda43bb76c1e45f/ios/chrome/browser/ui/qr_scanner/resources/qr_scanner_torch_on.imageset/torch_on%403x.png){kind=link}