Publish DEPS for Chromium 61.0.3163.59
Incrementing VERSION to 61.0.3163.59
[email protected]
Change-Id: Icccd0510bf0b12eead20b9efc56132a9d5e170de
Reviewed-on: https://chromium-review.googlesource.com/627202
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#773}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Prepopulate CupsPrintersManager cache with Synced printers.
SyncedPrintersManager only emits OnPrintersChanged if printers actually
change. Populate the printer cache in CupsPrintersManager when we
create it.
[email protected]
(cherry picked from commit 330f5e14d2b1e3ac27cd3f11272f20e13b013474)
Bug: 757672
Change-Id: I83438dd6a6f7d2d3925095c671427aa8881b7688
Reviewed-on: https://chromium-review.googlesource.com/625277
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496347}
Reviewed-on: https://chromium-review.googlesource.com/627105
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#772}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Update voice interaction OOBE flow logic
- The value prop should be shown again after user accepted value prop but
skipped play store terms.
- The wait for container ready screen should be shown after user
accepted value prop and accepted play store terms.
BUG=b/64814862
[email protected]
(cherry picked from commit 6905edc2a300a8cc35c9617bbf757c80f6d8f982)
Change-Id: I798537d4921ccfa54bd24cc11eb53a5b93d3e0f3
Reviewed-on: https://chromium-review.googlesource.com/622050
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496024}
Reviewed-on: https://chromium-review.googlesource.com/627104
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#771}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Avoid calling EmitLoginPromptVisible in voice interaction OOBE flow
Set the flag for calling EmitLoginPromptVisible to false for voice
interaction OOBE so that it will not be called at the wrong time.
BUG=756687
[email protected]
(cherry picked from commit b89f8fb6be9087064b00bfd1ba74e853a0fde122)
Change-Id: I71c4f7d25695c807c66e8ddfc0e59e1e39744d91
Reviewed-on: https://chromium-review.googlesource.com/621751
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495684}
Reviewed-on: https://chromium-review.googlesource.com/627200
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#770}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix check failure when adding a printer.
The printing WebUI handler is looking for a parameter which has been
removed. Fix it so we can add printers again.
[email protected]
(cherry picked from commit 916f88c9ac3eed4569aa473dce1b10982a83efe1)
Bug: 757589
Change-Id: Id25d21474f052a911e86384847e37b1f6d9c4c0f
Reviewed-on: https://chromium-review.googlesource.com/624731
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496334}
Reviewed-on: https://chromium-review.googlesource.com/627088
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#769}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix several Zeroconf bugs.
* Use service_type instead of service_name to determine...the service type.
* Don't dereference a map iterator at end()
* Completely initialize CupsPrintersManager before starting
callbacks
*
[email protected]
(cherry picked from commit 172c6a15317aaff4f84455e8a7b634d23c26cf24)
Bug: 757091
Change-Id: I7a63962046ae9a8376439cf181b9edc729163589
Reviewed-on: https://chromium-review.googlesource.com/622167
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Justin Carlson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495775}
Reviewed-on: https://chromium-review.googlesource.com/627276
Cr-Commit-Position: refs/branch-heads/3163@{#768}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}add option for windows to be skipped or hidden in overview.
BUG=b:63068164
TEST=ash_unittests --gtest_filter=WindowSelectorTest.SkipOverviewWindow
Change-Id: I2320345e369a5464cda984ae729335b2ff0c90a8
Reviewed-on: https://chromium-review.googlesource.com/601350
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Commit-Queue: Muyuan Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495407}
Reviewed-on: https://chromium-review.googlesource.com/624546
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#767}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61] arc: Make PAI flow error resistant.
PAI is started during the initial ARC boot. However it might be the case
when PAI is not triggered due user logs out earlier, crash or other
conditions. PAI may be alse locked until assistant completes. This makes
PAI starter fragile and in cases described above PAI might not be
executed on device at all.
This CL introduces the flag that indicates that PAI was started for this
device and we will start PAI on next user login if this is required.
This also adds extra protection to assistant flow that would release
lock if something goes wrong. As side refactoring, PAI lock
manipulations are moved to one class to make logic clear.
Test: various test cases on device, simulated different errors. In all
cases PAI was finally called. Added extra unit tests.
Bug: b/63765408
[email protected], [email protected], [email protected]
(cherry picked from commit 160ece0201fd4737da6a7ec509f7bab7218ac9e0)
Test: various test cases on device, simulated different errors. In all
Change-Id: Ic6a026b4023d9ea91348f01e597910cdd4a084d8
Reviewed-on: https://chromium-review.googlesource.com/622071
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496096}
Reviewed-on: https://chromium-review.googlesource.com/626716
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#766}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Smart Text] Disable surrounding text for input elements.
This CL effectively reverts
https://codereview.chromium.org/2907963002, which appears to
causing problems, including leaking of input fields to
Google servers.
Disabling until a better fix is found.
BUG=751408, 753579, 721840
[email protected]
(cherry picked from commit afd38807e684a7b571e82b57977f636b6aa21933)
Change-Id: Iecddba6ebed8faf3c266daa232613c57fa5a7464
Reviewed-on: https://chromium-review.googlesource.com/622747
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Tima Vaisburd <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495985}
Reviewed-on: https://chromium-review.googlesource.com/627076
Reviewed-by: Tima Vaisburd <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#765}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reduced overlay scrollbar delay to 500ms
Th eoverlay scrollbar fade delay determines how long a period without
scrolling will cause the scrollbars to fade out. It also determines how
long the mouse must hover over the scrollbar area before it fades in.
The fade delay is currently set to 1000ms. In practice, this feels a
little long and difficult to discover that the scrollbars appear when
the mouse hovers near the page edge. Reducing it to 500ms to see how=
that feels
[email protected]
(cherry picked from commit 18a10d0e899c5d1ef5b1ccfe4a5858b75a166aa0)
Bug: 307091
Change-Id: I463b086fc17c5166e009f2440258e1e1fdf808f9
Reviewed-on: https://chromium-review.googlesource.com/598116
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#491497}
Reviewed-on: https://chromium-review.googlesource.com/626947
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#764}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Clear CoreTabHelperDelegate in TabAndroid::DestroyWebContents
When DestroyWebContents is called with delete_native=false, the
associated WebContents is released, but its CoreTabHelperDelegate still
points to the original TabAndroid instance. This can cause use after
free issues, since the lifetimes of the two objects are now no longer
intertwined. In the referenced bug, it's possible to destroy the tab
before the native WebContents, which causes a use after free when the
tab is later accessed. This change clears the delegate.
This problem is android-only; c/b/ui/browser.cc clears the delegate
already in TabDetachedAtImpl.
BUG=751432
[email protected]
[email protected]
(cherry picked from commit 6e755a44e0efbebb95794398c6b968da36d1ecf9)
Change-Id: I9996e567f0c03199eaf7f2ecad85cb9f26fec46f
Reviewed-on: https://chromium-review.googlesource.com/617398
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496022}
Reviewed-on: https://chromium-review.googlesource.com/626944
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#763}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}e go# Enter a description of the change.
PlzNavigate: make BlockCredentialedSubresources work.
Chrome blocks subresource requests whose URLs include credentials (i.e.
http://username:[email protected]/resource.png).
It was broken with PlzNavigate(--enable-browser-side-navigation) when
the subresource was a frame. The page was blocked, but only after the request
had been sent to the server.
This CL makes chrome block requests before they are submitted.
[email protected]
(cherry picked from commit 98218acf1f7c8c5c2b02a82cff7d10276fc53d27)
Test: NavigationHandleImplBrowserTest.BlockCredentialedSubresources
Bug: 755892
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ibce9555e0cd4f83d206c0fff8a8c8267bd9fb5b6
Reviewed-on: https://chromium-review.googlesource.com/619086
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Nasko Oskov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495659}
Reviewed-on: https://chromium-review.googlesource.com/626621
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#762}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Move extension unzip/unpack to background thread
The goal is to prevent extension unpacking operations from blocking
main utility thread; in particular to prevent the operations from
blocking main thread from receiving ChannelConnected IPC - if the IPC
is received while extension unzipping, and unzip operation takes more
than 15 seconds (which might happen for extensions sufficiently large,
especially on low end Chrome OS devices), utility process might
mistakenly assume that browser process is not responding to channel
creation request and terminate itself upon finishin unzip operation.
BUG=713315
[email protected]
(cherry picked from commit e2129fc0c0290aa8191fa03970c59c3dcaf7a8af)
Change-Id: I0427875ac5f8fd5fadfbaa57bd85ded2dbe4e980
Reviewed-on: https://chromium-review.googlesource.com/603167
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493862}
Reviewed-on: https://chromium-review.googlesource.com/626724
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#761}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Enable automatically detected CUPS printers in the print preview dialog.
[email protected]
(cherry picked from commit 3bf7caf9cdf98cbe7ffedb0fc6d9b1867d65b2c7)
Bug: 588234
Change-Id: I5c91ed32e1a84fb1d9ba11ca5aebc9dac5cff1ec
Reviewed-on: https://chromium-review.googlesource.com/617840
Commit-Queue: Justin Carlson <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495617}
Reviewed-on: https://chromium-review.googlesource.com/626723
Cr-Commit-Position: refs/branch-heads/3163@{#760}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Zeroconf printer detector implementation.
This adds printer detection support for ipp/ipps printers advertised
via zeroconf (bonjour).
BUG=744997,588234
[email protected]
(cherry picked from commit a3e66f7891b19c3c177d7073f37b98832d4ba064)
Change-Id: I9e0a633f8b026331090818d780e74c946492a71a
Reviewed-on: https://chromium-review.googlesource.com/612223
Commit-Queue: Justin Carlson <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495381}
Reviewed-on: https://chromium-review.googlesource.com/626721
Cr-Commit-Position: refs/branch-heads/3163@{#759}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reland: "Connect CupsPrintersManager, superceding SyncedPrintersManager."
This reverts commit 6dbf7125d2957091e4c165ea089de89ae10d072e.
Reason for original revert: Original CL exposed (but did not cause) an unrelated error that
has since been fixed in https://chromium-review.googlesource.com/c/619327
With that fix landed, this cl now passes msan testing unchanged.
Original change's description:
> Revert "Connect CupsPrintersManager, superceding SyncedPrintersManager."
>
> This reverts commit 41de7e17fb2912f17456aeb369539749dae2a8f0.
>
> Reason for revert: unit_tests failing on Linux ChromiumOS MSan bot:
> https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/2380
>
> Original change's description:
> > Connect CupsPrintersManager, superceding SyncedPrintersManager.
> >
> > Connect CupsPrintersManager to the UI. Simplify USB detection so it
> > does *not* automatically attempt to save the configured printer; this
> > is now a normal settings flow.
> >
> > Update the settings ui to go from discovery dialog -> complete if the
> > printer can be added without user input, or from discovery dialog ->
> > manufacturer/model dialog if the user needs to supply more
> > information.
> >
> > Note that there were severe merge conflicts with
> > https://chromium-review.googlesource.com/c/600890. Resolving these
> > conflicts involved moving much of the functionality from that change
> > into CupsPrintersManager. The combined solution is (I believe)
> > significantly more elegant)
> >
> > BUG=744987,588234,755403
> >
> > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> > Change-Id: Ief41410f45ff7e3b20ca38e7972abf4bb7725a8a
> > Reviewed-on: https://chromium-review.googlesource.com/611103
> > Commit-Queue: Justin Carlson <[email protected]>
> > Reviewed-by: Xiaoqian Dai <[email protected]>
> > Reviewed-by: Michael Giuffrida <[email protected]>
> > Reviewed-by: Sean Kau <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#495051}
>
> [email protected],[email protected],[email protected],[email protected]
>
> Change-Id: I916ac190ac420b48d7e7380e9a229c8927459cbf
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 744987, 588234, 755403
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/618566
> Reviewed-by: Max Morin <[email protected]>
> Commit-Queue: Max Morin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#495095}
[email protected]
(cherry picked from commit 5639cf6992298065a77ccc6102ed55bace500b8c)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaf186a7a445e5d34cefa59564adab5b6c5d4562d
Bug: 744987, 588234, 755403
Reviewed-on: https://chromium-review.googlesource.com/619466
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Justin Carlson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495316}
Reviewed-on: https://chromium-review.googlesource.com/626719
Cr-Commit-Position: refs/branch-heads/3163@{#758}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Create CupsPrintersManager class. Also create associated unit tests. This change does not plumb this class in yet.
BUG=744987
[email protected]
(cherry picked from commit ee00115994fbb7a137380b02160ca2fcb9b8c20d)
Change-Id: I0451bf57e635cb8b812002e95686eaf190364968
Reviewed-on: https://chromium-review.googlesource.com/606550
Commit-Queue: Justin Carlson <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493051}
Reviewed-on: https://chromium-review.googlesource.com/626717
Cr-Commit-Position: refs/branch-heads/3163@{#757}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Settings: Internet: Hide/disable Forget for policy networks
This CL:
* Hides the 'Forget' buttons for policy networks since 'Forget' is
not allowed (or for device-policy networks behavies unexpectedly).
* Disables the 'Forget' menu item (we do not remove it to avoid
empty networks)
* Adds an enterprise item to policy controlled networks to match the
primary network list and to make the reason for 'Forget' being
disabled more apparent.
[email protected]
(cherry picked from commit fbc44c77b42411eac4226c69228da92e2d09d48c)
Bug: 733737
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iadc3cf08cff543a0df1d0013eb5cb72fd044d822
Reviewed-on: https://chromium-review.googlesource.com/616077
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494668}
Reviewed-on: https://chromium-review.googlesource.com/626677
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#756}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Feature Flag for Dialog Touch Bar Support
Dialog touch bar support is currently behind
the Browser Touch Bar flag. This needs to be
separated into a separate flag that's disabled
by default.
This is an attempt to reland
https://chromium-review.googlesource.com/c/616341
which had caused several tests to failed. The test
failures are addressed in this CL
(cherry picked from commit eb1b3b1a757988622cab119a5f95b118c3338591)
Bug: 755814
Change-Id: I458527a859527b8ebcccca5b12ca9f55b4d39b2c
Reviewed-on: https://chromium-review.googlesource.com/617386
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Sarah Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495203}
Reviewed-on: https://chromium-review.googlesource.com/624872
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#755}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disable HideIncorrectlySizedFullscreenFrames feature by default
[email protected]
(cherry picked from commit a695726923900fad855c969fcc3e49d5f8fd4a47)
Bug: 756246
Change-Id: I5e8a1084f41f4cdc83a9ff7e434439e83e1b8a94
Reviewed-on: https://chromium-review.googlesource.com/618181
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496081}
Reviewed-on: https://chromium-review.googlesource.com/626067
Cr-Commit-Position: refs/branch-heads/3163@{#754}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Log net errors in case content fetch download faliure.
use the existing NetErrorCodes to log the positive value of the
fetcher->status->error code.
[email protected]
(cherry picked from commit 3805edee23e867aa64871520d30c2ea173bd0dd0)
Bug: 754398
Change-Id: I4451410a76f8c8f34efc983df73f1f70142ae69f
Reviewed-on: https://chromium-review.googlesource.com/611050
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Alexei Svitkine (very slow) <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494195}
Reviewed-on: https://chromium-review.googlesource.com/626377
Cr-Commit-Position: refs/branch-heads/3163@{#753}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Avoid starting a Chrome sign-in flow when browser process is shuting down.
This CL avoids opening a Chrome sign-in tab from the chrome.identity API
when the browser process is shutting down as this crashes the browser.
[email protected]
(cherry picked from commit 6cc9babc2a305c63d7925a922fb29c4995b1e9a5)
Bug: 753014
Change-Id: Ie2157350925d8b53170fb00b9baa569f66de6ad4
Reviewed-on: https://chromium-review.googlesource.com/618647
Commit-Queue: Mihai Sardarescu <[email protected]>
Reviewed-by: Michael Courage <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495513}
Reviewed-on: https://chromium-review.googlesource.com/626062
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#752}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disable Media Engagement and update tests to still work.
[email protected]
(cherry picked from commit 65a1ae787fd57bdf3846c3bcf7bff5b7bd54b03b)
Bug: 754604
Change-Id: I63ec82ed924da6fac8d7ac2dd1e3549d8c33feac
Reviewed-on: https://chromium-review.googlesource.com/618871
Commit-Queue: Mounir Lamouri <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495938}
Reviewed-on: https://chromium-review.googlesource.com/626064
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#751}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Refresh Public Suffic List to the latest version
This updates from revision
266972ca12e1916ebfb3365d5acd06bd143e20ea (2017-07-11)
to revision
fe6b36209b2cee5740d8909e3f1c9624756a628a (2017-08-21)
[email protected], [email protected]
BUG=743088
(cherry picked from commit 5820b7ea7e6582fc8a0dceb659168f3f95655adf)
Change-Id: If7dd7d6d0ef24f397e6542e604e993d574f43a80
Reviewed-on: https://chromium-review.googlesource.com/624197
Reviewed-by: Ryan Sleevi <[email protected]>
Commit-Queue: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495999}
Reviewed-on: https://chromium-review.googlesource.com/625762
Cr-Commit-Position: refs/branch-heads/3163@{#750}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Don't compare crypthome keys when the login flag is disabled.
[email protected]
(cherry picked from commit 875214817b888f4dd3ade00df0c7ce447ef946bd)
Bug: 757432
Change-Id: Ic38da4fbcbd14722f14014ce7677eadbc026b3a1
Reviewed-on: https://chromium-review.googlesource.com/623712
Reviewed-by: Tim Song <[email protected]>
Commit-Queue: Gustavo Sacomoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495977}
Reviewed-on: https://chromium-review.googlesource.com/625736
Reviewed-by: Gustavo Sacomoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#749}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Set null origin in cross origin redirect even when method is altered
URLRequest::Redirect modifies the origin header of the request as
follows:
1. If the method is altered (typically in response to 301/302), it
removes the origin header.
2. If the redirect is a cross-origin redirect, it sets a null
origin header.
This CL removes the first item for better conformance with the fetch
spec.
[email protected]
(cherry picked from commit 322fef8774794f175c4f049d233f974598ef92fa)
Bug: 746687
Change-Id: I577e6a5c4f00d78083deb3063e4285be00954cfe
Reviewed-on: https://chromium-review.googlesource.com/595300
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Takeshi Yoshino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492897}
Reviewed-on: https://chromium-review.googlesource.com/625538
Cr-Commit-Position: refs/branch-heads/3163@{#748}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Allow to close menu by tapping outside it.
Allow to close menu by tapping outside it, in addition to mouse click.
This a revised version of 608347 after fixing the issues.
Some UI components can cancel events after processing them. Therefore
the decorated object may not receive touchstart event in such case.
[email protected]
(cherry picked from commit 8394bae7034e5eeb9bf5ada381fc3ea39baf323a)
Bug: 753723
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I168e59bc9649d91a9bc3b1c11795153fc2547093
Reviewed-on: https://chromium-review.googlesource.com/616404
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495869}
Reviewed-on: https://chromium-review.googlesource.com/624765
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#747}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Making answer card resize when the new card has smaller contents.
We reuse web contents, and the currently used way doesn't work when the
new card that we load into web contents is smaller than the previous
one.
[email protected]
(cherry picked from commit fbd55c4636ca17f97ef73ad3c97c869a306274cb)
Bug: 712331
Change-Id: I026b844b11535c014c56ad3e766b6e3daef7747e
Reviewed-on: https://chromium-review.googlesource.com/622467
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Vadim Tryshev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496036}
Reviewed-on: https://chromium-review.googlesource.com/624949
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#746}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Revert "Disable backdrop if fullscreen app list is opened in tablet mode."
This reverts commit cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3.
CL introduces massive ash_unittests failures in M61.
[email protected]
Bug:
Change-Id: I50e3ef6897c527370ea6ae4e1c525f55ec658c98
Reviewed-on: https://chromium-review.googlesource.com/624671
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#745}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.58
[email protected]
Change-Id: I710d016a6e435874d466466db4399023f9211c97
Reviewed-on: https://chromium-review.googlesource.com/625216
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#744}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[CrOS Tether] Keep scanned host devices in the cache for longer.
Previously, we would remove scanned host devices from the cache after 5
minutes. However, this value proved to be too low - I often found myself
opening network settings a short while after a scan to find that the
previously-scanned results were missing due to this timeout. With this
CL, we change the timeout value from 5 minutes to 2 hours, which causes
our UI to behave the same way that Wi-Fi and Bluetooth do: keep scan
results in the UI until a scan completes and cannot find the same
results.
[email protected]
(cherry picked from commit d3c8142db5d3731d8819a54cdda68cb58ac950d6)
Bug: 757520, 672263
Change-Id: If6c0e03cc478ad8949241e1f663d9c4c94745345
Reviewed-on: https://chromium-review.googlesource.com/624538
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496087}
Reviewed-on: https://chromium-review.googlesource.com/625166
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#743}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Data Saver site breakdown should not show negative savings
[email protected]
(cherry picked from commit 03648256b7003ed2dc895a850e37121bd3295342)
Bug: 753097
Change-Id: I7136459f26d05e4d0ced6575f04a3a73c1558bfe
Reviewed-on: https://chromium-review.googlesource.com/607240
Reviewed-by: Ben Greenstein <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Megan Jablonski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496071}
Reviewed-on: https://chromium-review.googlesource.com/625161
Reviewed-by: Megan Jablonski <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#742}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Revert "Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop."
This reverts commit c5b5a53b8d7abf736b23a74801ce39f84652b3fb.
Reason for revert:
This is required to revert cff8bf40c2984421cb38c8f0d420f5f4c2c60cb3 which is breaking most of ash_unittests
Original change's description:
> Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop.
>
> [email protected]
>
> (cherry picked from commit 528643eac1afd68c58116742f22c20794f04dba9)
>
> Bug: 752383
> Change-Id: I990cbed13618e5857dc5927b787d9468d4a91626
> Reviewed-on: https://chromium-review.googlesource.com/615812
> Reviewed-by: Robert Flack <[email protected]>
> Commit-Queue: min c <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#494552}
> Reviewed-on: https://chromium-review.googlesource.com/624799
> Reviewed-by: Vadim Tryshev <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3163@{#727}
> Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[email protected],[email protected],[email protected]
Change-Id: I219540f311183e077809ca9547b5fdd63477bbe7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 752383
Reviewed-on: https://chromium-review.googlesource.com/624703
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#741}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add regression test for FP deprecation crash.
This adds an automated test for the case where a feature-policy-
deprecation warning is triggered when feature policy is disabled. It
ensures that no usage is recorded, and that the renderer does not crash.
[email protected]
(cherry picked from commit 65302d8e4a97c073cbcc675da90c7a1ff1547d95)
Bug: 752762
Change-Id: I2da29263381c3078d2cb1bc83bcc3b05de564ee3
Reviewed-on: https://chromium-review.googlesource.com/624419
Commit-Queue: Ian Clelland <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496105}
Reviewed-on: https://chromium-review.googlesource.com/624956
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#740}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix crash in CountDeprecationWarning
The code to count cross-origin uses of features which are going to be
under the control of Feature Policy wasn't checking whether Feature
Policy itself was enabled before asking the frame to check its policy.
This caused a DCHECK to fire in Frame.cpp in that case.
Without Feature Policy, we can't meaningfully check whether the usage
of the feature would have been declined in every case, so this change
causes CountDeprecationWarning to return early. This may introduce some
undercounting, but since Feature Policy is now enabled by default, that
should be minimal (and this undercounting is not new; it was just
previously represented by crashes instead).
[email protected]
(cherry picked from commit fb86b10bda0326d2e05c3f5f4060120613f91a76)
Bug: 752762
Change-Id: Ia36a2f7c85de8cedc4a386803d428e9d351db012
Reviewed-on: https://chromium-review.googlesource.com/619366
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495543}
Reviewed-on: https://chromium-review.googlesource.com/625016
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#739}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Apply TraceWrapper correctly for decudeAudioData callbacks.
emplace_back does not construct the object to include the
TraceWrapperMember. Instead use push_back with explicit construction
of the TraceWrapperMember to wrap the callback pointers.
Manually tested this fix using the repro case from
https://bugs.chromium.org/p/chromium/issues/detail?id=717723#c23 and
verify that a tone is heard, as expected.
Bug: 757563, 717723
Test: Run repro from 717723
Change-Id: If49501e0997c42f44e05f63323f3c42e6cee1913
Reviewed-on: https://chromium-review.googlesource.com/624620
Reviewed-by: Michael Lippautz <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#738}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Merge "kiosk: AppWindowHandler close session after app window creation"
> Make AppSession::AppWindowHandler only close app session after
> the kiosk app has created a window. The extensions that get
> loaded into a kiosk session could create/close window before
> the main kiosk app. This results in AppWindowHandler closes
> the kiosk session prematurely. The CL adds a boolean flag
> to detect the main kiosk app has created windows and only
> closes the session after the flag is set and the main kiosk
> app has no opening windows.
>
> BUG=756191
>
> Change-Id: I83c38c9b29d54782646f98243bcbf6aff8974ce9
> Reviewed-on: https://chromium-review.googlesource.com/624175
> Reviewed-by: Jenny Zhang <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#495971}
> (cherry picked from commit fa7219aa78897d5436defbec5b095bd3de862e09)
[email protected]
Change-Id: I33b40d9662b5c4ababfc83cddc574f64f7e2894d
Reviewed-on: https://chromium-review.googlesource.com/624934
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#737}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Enabling full-screen launcher by default.
Disabling unit-tests that assume
that Launcher is no full-screen.
This CL is landing directly in M61.
Is was tested first in trunk, but
wasn't landed there:
https://chromium-review.googlesource.com/c/chromium/src/+/622368
This will be followed by a trunk CL doing same thing.
That one will have a normal CR.
[email protected]
Bug: 757048
Change-Id: I561535d193d79ba8979a450ac745d18af0c0a4e8
Reviewed-on: https://chromium-review.googlesource.com/624898
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#736}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[History/Bookmarks] Check for null before setting background resource
We have received crash reports for NPE's while setting the background
resource on history and bookmark item views after deleting other list
items. This CL adds simple null checks to ensure the item view has an
associated item before using the item to determine the background
resource.
BUG=755627
Change-Id: I8a21c4db5a82398f86ec42e690b26ed0c01864c3
Reviewed-on: https://chromium-review.googlesource.com/624723
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#735}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Including app price and rating in the accessibility description.
For Play Store app search results, we've read only app name.
Now we include also star rating and price.
We are in talks about better description, such as
"Google Maps, four point three stars, one dollar", but I believe that
this small improvement is already beneficial for the users.
Fixed SearchResultTileItemView perpetuating
configuration parameters in static variables, which made
unit tests check wrong behavior.
[email protected]
(cherry picked from commit f5dc3baded573d180f940eb08b7ae2905bca2bc9)
Bug: 756598
Change-Id: Ia5913380f1d2370e3626c6f730c21b427fc6114d
Reviewed-on: https://chromium-review.googlesource.com/619180
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Vadim Tryshev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495625}
Reviewed-on: https://chromium-review.googlesource.com/624895
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#734}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros UMA: launcher transitions
Recording user metrics when the user transitions the launcher from
different states.
his CL fixing the state transition bug.
[email protected]
(cherry picked from commit 96d93bfdf739c5b5fafd97cbcaa04db97014b997)
TODO: Add closing launcher from presenter delegate once maajid@ lands
Bug: 750312
Change-Id: I0b2982df87660654b0052a3ad7dff6c01bbd964b
Reviewed-on: https://chromium-review.googlesource.com/609401
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495029}
Reviewed-on: https://chromium-review.googlesource.com/624539
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#733}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add a new shelf background type when fullscreen app list is visible.
Currently the status area is displayed with semi-transparent background
in a transparent shelf container. When the launcher background color is
themed as the shelf containers, the status area background will
disappear and we will not be able to see the touch targets. We are
adding one more shelf background type when the fullscreen app list is
visible: to display the status area with the separators and no
background.
Changes:
1. New shelf background type: SHELF_BACKGROUND_APP_LIST.
2. When there is a launcher, the shelf will use the new background type.
[email protected]
(cherry picked from commit a96b3f53cfebeea35a85b3579b505045a95475cb)
Bug: 748555
Test: with flags enable-fullscreen-app-list && enable-background-blur
Change-Id: Idda3757398662ed8300ac89a6c6559c5da76a861
Reviewed-on: https://chromium-review.googlesource.com/614398
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494896}
Reviewed-on: https://chromium-review.googlesource.com/624801
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#732}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros: Show xbutton only when query exists in search box
Changes:
1. Show xbutton only when text query exists in search box. Hide it
otherwise.
2. Add unit test for xbutton.
BUG=754768
TEST=SearchBoxViewFullscreenTest.*
[email protected]
(cherry picked from commit 2d6ccbc44dbc9a59dff0c747c9a15feae01f8a80)
Change-Id: Ibdbb5808576a3204927414c9e56000a57689ff64
Reviewed-on: https://chromium-review.googlesource.com/616123
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494846}
Reviewed-on: https://chromium-review.googlesource.com/624730
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#731}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Exclude the RDS checkbox from accessibility.
The text of the menu item is sufficient and having two
targets read out "request desktop site" is confusing IMO.
BUG=739380
[email protected]
Change-Id: Iae9c403d426fa76193fb296614f64bf0517e9b43
Reviewed-on: https://chromium-review.googlesource.com/606677
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492760}
Reviewed-on: https://chromium-review.googlesource.com/624702
Cr-Commit-Position: refs/branch-heads/3163@{#730}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros UMA: Added uma for suggested apps
Added UMA for suggested apps. We will record data when the user clicks
on a suggested app, and record whether the fullscreen feature is
enabled.
Also included slight refactoring of calls to feature flags.
The feature::isfullscreenapplistenabled and
features::isplaystoresearchenabled functions take a non-trivial amount
of time to call. We currently call both functions when we create a new
search result tile item view (which is reused for the suggested apps in
StartPageView and also for search results).
It makes sense to cache the value in a static bool so we can potentially
reduce UI jank.
I added SetSuggestedApps to SearchResultTileItemView so we can distinguish
when we are using the class as a suggested app and when it is a search
result.
[email protected]
(cherry picked from commit d879722873a98c9f9ada1a9576a9c4095feb304f)
Bug:
Change-Id: I08d388642409e0c6b85ceb55ab7d14f8bb729c00
Reviewed-on: https://chromium-review.googlesource.com/609361
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494807}
Reviewed-on: https://chromium-review.googlesource.com/624535
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#729}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros: Make switching pages easier while dragging app
Changes:
1. Extend the page flip zone all the way to the top of shelf if shelf
exists or to the bottom of display if shelf does not exist.
2. Change page flip timer to 500ms.
BUG=750660
[email protected]
(cherry picked from commit c3835bfc99b6a110a5867175dd534063b703eb08)
Change-Id: Ic458dcfb158b42e727c06037ac19006172dfa09b
Reviewed-on: https://chromium-review.googlesource.com/612699
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494582}
Reviewed-on: https://chromium-review.googlesource.com/624800
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#728}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Remove tablet mode restriction for AppListVisibilityChanged notification in backdrop.
[email protected]
(cherry picked from commit 528643eac1afd68c58116742f22c20794f04dba9)
Bug: 752383
Change-Id: I990cbed13618e5857dc5927b787d9468d4a91626
Reviewed-on: https://chromium-review.googlesource.com/615812
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: min c <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494552}
Reviewed-on: https://chromium-review.googlesource.com/624799
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#727}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}app_list: cap num of recommendation app results to 6
changes:
(1) cap num of recommendation app results to 6 for fullscreen app list.
(2) recommendation app results layout should only be controlled by
IsFullscreenAppListEnabled flag, except separators, play store badges, etc, whose
visibility are controlled by IsPlayStoreAppSearchEnabled. This will fix the bug
in crbug.com/754888 comment 2.
(3) update SearchResultTileItemListViewTest, enable fullscreen app list flag
for parameterized IsPlayStoreAppSearchEnabled tests.
IsPlayStoreAppSearchEnabled flag.
[email protected]
(cherry picked from commit 19c4782899224cb253ba50042fe5cc75484af564)
Test: test with/without IsFullscreenAppListEnabled flag and
Bug: 754888
Change-Id: If232b6bd90ce6fc427e373ae08d43e90f9d20b49
Reviewed-on: https://chromium-review.googlesource.com/614750
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494472}
Reviewed-on: https://chromium-review.googlesource.com/624836
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#726}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Check fullscreen manager before use in SwipeRefreshHandler
Swipes-to-refresh can happen before the browser is initialized. This
change adds a check to prevent crashes when the fullscreen manager is
not available.
BUG=756525
[email protected]
(cherry picked from commit 5e08523cd9b4091a91623f5ade3752d6c055036a)
Change-Id: I743df7fa19c46c47080169409122de50f14a1edd
Reviewed-on: https://chromium-review.googlesource.com/619849
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495385}
Reviewed-on: https://chromium-review.googlesource.com/624856
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#725}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}app_list: correctly show pure url link in search result row
changes:
Before this change, is_url is used to check whether the search result
is a url type result, if so, make |title_text_| show result's details
and |details_text_| show result's title. However, there might be a case
that a url title without details. This fix is to cover this case based
on specs.
(1) Swap title and details if OmniboxResult is a url result with
non-empty description.
(2) using |is_omnibox_result_| to specify matched/proposed color
requirements.
specs in crbug.com/754873
screenshot: https://screenshot.googleplex.com/jq0LhniuaEL
[email protected]
(cherry picked from commit d323a482ee55624809476267e6c7160c2c2bbcdd)
Test: test with fullscreen app list flag.
Bug: 754873
Change-Id: I77335da01a1d012d2b1f895fb5aa07f43c0f8afb
Reviewed-on: https://chromium-review.googlesource.com/614609
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494468}
Reviewed-on: https://chromium-review.googlesource.com/624798
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#724}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros: Modify launcher blur and alpha.
Modify launcher background blur and alpha to comply with UX Spec.
[email protected]
(cherry picked from commit c3421f6d9d62c5b55e08c4661b9b1b03339c7005)
Bug: 755212
Change-Id: I64d1405e47fc470c67006a93ba20eab456d40d38
Reviewed-on: https://chromium-review.googlesource.com/613688
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494466}
Reviewed-on: https://chromium-review.googlesource.com/624855
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#723}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reland: fix window bounds transformation from dip to pixel.
Previous transformation only considers device scale
factor but does not handle user-defined scale factor
with ctrl + +/=.
Reland https://chromium-review.googlesource.com/c/608875
reverted by https://chromium-review.googlesource.com/c/618426.
BUG=b:64029031
TEST=None
[email protected]
(cherry picked from commit cde321af86552c881806528333ccb7e48982beee)
Change-Id: Id550d81c3d97794a1a49dfc3f477ede57c5f7303
Reviewed-on: https://chromium-review.googlesource.com/618287
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Muyuan Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495294}
Reviewed-on: https://chromium-review.googlesource.com/624854
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#722}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disable backdrop if fullscreen app list is opened in tablet mode.
If fullscreen app list is opened, the shelf should change to be transparent.
But since there is a fullscreen backdrop window in tablet mode. The shelf area
is still black after app list is opened.
Change:
Add OnAppListVisibilityChanged(*) in BackdropController. Hide backdrop if app list
is opened, update it if app list is dismissed.
[email protected]
(cherry picked from commit 55709dd24edad7c026e0ba7ecdb6a9b4b196894c)
Bug: 752383
Change-Id: Ic1be66eb5cb9b0a4d126d8e8d78aa2f229b824b8
Reviewed-on: https://chromium-review.googlesource.com/606706
Commit-Queue: min c <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494437}
Reviewed-on: https://chromium-review.googlesource.com/624726
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#721}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros: Fix crash when typing in search box in fullscreen app list
This is a follow-up CL for
https://chromium-review.googlesource.com/c/612723.
When PlayStoreAppSearch is not enabled, rating and price are nullptr.
Add wrap to set background only if they are not nullptr.
[email protected]
(cherry picked from commit ef844489328c1820eca4983c7cb051fab0fb9925)
Changes:
Change-Id: Ideef88908ec974d3a3020236ac4be436c30a636c
Reviewed-on: https://chromium-review.googlesource.com/614746
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494418}
Bug:
Reviewed-on: https://chromium-review.googlesource.com/624797
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#720}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Additional UMA for Assistant pen
[email protected]
(cherry picked from commit 96a9abb8ca543ad6447732ae46f547ced49db6fa)
Bug: 753961
Change-Id: Id07fe32fd858105ece3b8ed3cb38b68e4e7a710e
Reviewed-on: https://chromium-review.googlesource.com/610828
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495040}
Reviewed-on: https://chromium-review.googlesource.com/624795
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#719}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix broken text in fullscreen app list
Known issue:
All text in SearchResultPageView is broken randomly when typing query in
the search box. One work-around fix is setting a solid color background.
But setting SearchResultView's background color will cause issue in
crbug.com/752685 and overwrite the border corner radius of
SearchResultPageView during animation.
Changes:
1. Set all the text's background to be kCardBackgroundColorFullscreen to
prevent broken text while not breaking the animation.
2. Adjust price and rating's bounds to avoid one's solid background
blocking the other's.
BUG=746563,752685
[email protected]
(cherry picked from commit 9985985766911f64a17053fff4575733568447ed)
Change-Id: I0ed538776957623e07a3a4a3aab08ee3ed5d46a3
Reviewed-on: https://chromium-review.googlesource.com/612723
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494224}
Reviewed-on: https://chromium-review.googlesource.com/624796
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#718}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Added a widgetobserver class to AppListView
Added FullscreenWidgetObserver to AppListView which is only used when
the fullscreen flag is enabled. This is a workaround for the crash which
is caused when we add an observer to the AppListView. The crash is due
the AppListView being a child class of BubbleDialogDelegateView. This
class will be assimilated into AppListView once we get rid of the old
AppListView code path.
[email protected]
(cherry picked from commit a0ab0da7c46fdbc85496037c13a9ca7049d04409)
Bug: 755170
Change-Id: I87a23b3ad0f73e143d9fc4502d392b1778b22f1b
Reviewed-on: https://chromium-review.googlesource.com/613576
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494207}
Reviewed-on: https://chromium-review.googlesource.com/624834
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#717}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[CrOS Tether] Fix BluetoothThrottler crash.
The issue was that when BluetoothThrottlerImpl is destroyed, it iterates
through a set of Connections and unregistered itself as an observer.
However, it is possible that the Connection had already been deleted by
this point, causing a segfault. To fix this issue, connections are only
registered once they are already connected to ensure that they are
removed before they are destroyed. This is enforced by a DCHECK() in
BluetoothThrottlerImpl::OnConnection().
[email protected]
(cherry picked from commit a98534f53e2388d9b8bb97798d394e49f00b7b04)
Bug: 756141, 672263
Change-Id: Ibd2014f044468760cd92b9762605f8bb791508b3
Reviewed-on: https://chromium-review.googlesource.com/622226
Reviewed-by: Tim Song <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495994}
Reviewed-on: https://chromium-review.googlesource.com/624670
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#716}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[CrOS Tether] Fail gracefully when GATT characteristic cannot be found.
Previously, this class would CHECK() that a GATT characteristic is
present after it received a callback that the characteristic was found.
However, it is possible that the characteristic still cannot be found
if the associated Bluetooth device was lost or if one of its services
was destroyed. In this situation, we now disconnect instead of crashing.
[email protected]
(cherry picked from commit 8908ba21fa88dfe1c14a4e6b063e2736c29e86b8)
Bug: 756174, 672263
Change-Id: Id571204871e2dbc3975f438bfdda0705f86bd4fc
Reviewed-on: https://chromium-review.googlesource.com/624394
Reviewed-by: Tim Song <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#496042}
Reviewed-on: https://chromium-review.googlesource.com/624669
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#715}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Change snapping threshold for dragging app list from shelf in tablet mode.
[email protected]
(cherry picked from commit a7c223c7f934d21891c2da62b85a276fc28118d6)
Bug: 754537
Change-Id: I6ca803519c340f2c9ee696c81123a8628609491f
Reviewed-on: https://chromium-review.googlesource.com/612595
Commit-Queue: min c <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494118}
Reviewed-on: https://chromium-review.googlesource.com/624721
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#714}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Mac] Remove Excessive Touch Bar Invalidates
The touch bar is updated with every page load, so that
the stop/reload button would have the proper state.
However, this causes the search button to blink frequently
in some hardware. To fix this issue, remove the excessive
invalidates and update the stop/reload item independently.
(cherry picked from commit ccfaf09a251e8a7c752638b07ae9dd1a37156889)
Bug: 749424
Change-Id: I02c5dd3ea8ddf978ecab6a3e5297df8d578939c2
Reviewed-on: https://chromium-review.googlesource.com/612694
Commit-Queue: Sarah Chan <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494292}
Reviewed-on: https://chromium-review.googlesource.com/624374
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#713}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Revert "Enable background video track optimization for MSE content."
This reverts commit df848adb8eb6bf9be13ed82e1b2156b8ae93615a for
the M61 branch due to bugs.
BUG=752726
TEST=none
TBR=tguilbert
Change-Id: I200d16cdbbe982b2723f066414cfb5f64159fd77
Reviewed-on: https://chromium-review.googlesource.com/624663
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#712}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Media Router WebUI] Switch pause/mute buttons' locations in RTL languages
Order before: mute button (LTR), pause button, volume slider (LTR)
Order after: volume slider (RTL), mute button (RTL), pause button
[email protected]
(cherry picked from commit a2c238d44612e7da16927963eb7c72a4ed655812)
Bug: 756625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I56903c78923e2bc38051a3ff77fb5e1a27c90b21
Reviewed-on: https://chromium-review.googlesource.com/613842
Reviewed-by: Derek Cheng <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495464}
Reviewed-on: https://chromium-review.googlesource.com/624754
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#711}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Change search box background colour logic to account for whether the search box is active
[email protected]
(cherry picked from commit d4a5f643bf9f7f9e8da8cb639d49e1dc2e8488a1)
Bug: 754567
Change-Id: Icebd5aff4aa8f580e51f9a40d7fc8650a1f5a0a6
Reviewed-on: https://chromium-review.googlesource.com/612456
Commit-Queue: Maajid <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494116}
Reviewed-on: https://chromium-review.googlesource.com/624659
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#710}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Android, Media] Handle OkHttp exceptions that might happen due to thread safety.
MediaUrlResolver has a long history of crashing in OkHttp due to undiscovered
threading issues. The crash rates went up in O for some reason so the problem
has to be fixed now before the actual reason is found. As a workaround the two
possible exceptions are handled and silenced in the AsyncTask and the media is
considered not suitable for casting.
A new result histogram value is added to track the number of occurrences in the
wild.
[email protected]
(cherry picked from commit 1dcaad6f92610fa44d91e453a666998b3bfa23fb)
Bug: 754480
Test: Make sure all targets build and trybots pass. No way was found to reliably reproduce the issue yet.
Change-Id: I2f4eb7b5b65e5aac7967738a35d89c9c24ff7715
Reviewed-on: https://chromium-review.googlesource.com/616272
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Anton Vayvod <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494790}
Reviewed-on: https://chromium-review.googlesource.com/624676
Reviewed-by: Anton Vayvod <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#709}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Updating XTBs based on .GRDs from branch 3163
TBR = [email protected]
Change-Id: I627510a087691c292a7e173e4f84004d46ea2ac0
Reviewed-on: https://chromium-review.googlesource.com/624614
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#708}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61] Make profile directory creation always synchronous.
[Merge M61] Make ios browser state directory creation always synchronous.
This requires allowing IO on the main thread for two lightweight I/O
operations (PathExists + CreateDirectory). The tradeoff is worth it as
it ensures the directory is up before any of the asynchronous I/O from
every service starts touching their portion of the profile directory.
Sequencing all of these operations on the directory creation would be a
herculian task and isn't worth it.
NOPRESUBMIT=True (for intentional ScopedAllowIO usage)
Bug: 755157, 689520
Change-Id: I81498d20e91cae79ea3a1948b3d84d255adb6bd6
Reviewed-on: https://chromium-review.googlesource.com/613683
Reviewed-by: Anthony Vallee-Dubois <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#494517}
(cherry picked from commit 0b08bf2eaee22458d459ef824e644d4493b29c20)
[email protected], [email protected], [email protected]
(cherry picked from commit 1abda036eaee58bcb8aee1c2704b93b45a773ea8)
Change-Id: I856a31ce1e2fc930587e04e5b32c49b19161e155
Reviewed-on: https://chromium-review.googlesource.com/618087
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495138}
Reviewed-on: https://chromium-review.googlesource.com/624455
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#707}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}WebUI: Change Picture: Focus list in oobe and scroll to selected
[email protected]
(cherry picked from commit 58853d1918fdf337dde1fd457e89856712ebbc9a)
Bug: 752034
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie28fbb60cb547e98e49ddf12c4be3807419e5821
Reviewed-on: https://chromium-review.googlesource.com/615746
Reviewed-by: David Reveman <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494638}
Reviewed-on: https://chromium-review.googlesource.com/624380
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#706}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reduce GPU image cache to 512KB
In local testing, I don't see a meaningful difference from the previous
2MB limit, so saving some memory. We should watch the bots for any
unexpected regressions.
[email protected]
(cherry picked from commit dd8208f70e44b269eb09d26e506f79f9c1d2eefb)
Bug: 706470
Change-Id: I2a1916436220cbdaaf5f644cfe845006fa12c359
Reviewed-on: https://chromium-review.googlesource.com/609482
Reviewed-by: enne <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493526}
Reviewed-on: https://chromium-review.googlesource.com/624379
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#705}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[instrumentation] Make sure the probe sink is still available when Did callbacks are invoked.
The patch makes it store the probe sink used in probe Will callbacks to
ensure the same sink will be used for Did callbacks.
BUG=754145
[email protected]
(cherry picked from commit 8f3270e31783e826b59086622789f6c3613f3792)
Change-Id: Iaa043c0240e9e84a117c9a168fc6cc15a4b1bbf6
Reviewed-on: https://chromium-review.googlesource.com/619598
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Alexei Filippov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495391}
Reviewed-on: https://chromium-review.googlesource.com/624187
Reviewed-by: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#704}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix bad aria-hidden usage
Aria-hidden was set to true for lots of meaningful elements including the password input. The result is that all of this content is invisible.
For the images, the author should provide a human readable string in the alt attribute.
For the input, this should *never* be invisible exclusively to accessibility. The potentially confusing part is that the DOM has a lot of aria labels set higher up in the node tree. In particular, the parent of the <input> has an aria label of "Password for ...", so someone trying to fix this might incorrectly assume that having the <div> non-aria hidden is sufficient. It unfortunately isn't. It would be best to at some point clean all of this up.
Here's what the live markup after all the js runs looks like:
"<div class="password-entry-container">
<div class="password-container" aria-label="Password for <omitted>@gmail.com">
<input type="password" class="password" placeholder="Password" tabindex="1">
</div>
<div class="capslock-hint-container">
<iron-icon class="capslock-hint" icon="user-pod:caps-lock">
</iron-icon>
</div>
<paper-icon-button class="submit-button" disabled="" aria-label="Submit" icon="user-pod:arrow-forward" tabindex="-1" role="button" aria-disabled="true" style="pointer-events: none;">
</paper-icon-button>
</div>"
[email protected]
(cherry picked from commit 65b53fd9a6d64ae0b9c3672779c69247e08e71d4)
Test: ChromeVox can actually see the input password, and typing echos characters on focus.
Bug: 753463
Change-Id: I7beedae79b18333e41d0c66ccd6e565844c8918f
Reviewed-on: https://chromium-review.googlesource.com/617907
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495613}
Reviewed-on: https://chromium-review.googlesource.com/624182
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#703}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Ignore placeholder text in Accessibility tree
[email protected]
(cherry picked from commit a9584c51d093c6c9c657bad06df55a50f710536c)
Bug: 753463
Test: when navigating text fields with a placeholder, this makes it so we don't get stuck. With ChromeVox with a working login screen, Search+right. Verify that we don't get stuck on the password text field.
Change-Id: Iae13558bdb513a733a2273e86770acfff3e11027
Reviewed-on: https://chromium-review.googlesource.com/617770
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495742}
Reviewed-on: https://chromium-review.googlesource.com/623918
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#702}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix layout issues for Android J
Android J does not allow 'requestLayout' to be called while in a
layout cycle. This change wraps the request in a post, allowing layout
to complete before requesting another.
BUG=747965
[email protected]
(cherry picked from commit 9cb7be3951264badfb2b4b30a8d46ed5a1bf933e)
Change-Id: I33235051ffcba80c00da27e8b6825c68d0b6042d
Reviewed-on: https://chromium-review.googlesource.com/615788
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495193}
Reviewed-on: https://chromium-review.googlesource.com/624180
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#701}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[EasyUnlock] Make sure to remove observers from CryptAuthDeviceManager during clean up.
BUG=756183
[email protected]
(cherry picked from commit 6b1a8c76664abc3ea557231c4f6e6dfa5f4498e9)
Change-Id: Id53cf375f045a43fd0878693baba68103c670028
Reviewed-on: https://chromium-review.googlesource.com/617399
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Gustavo Sacomoto <[email protected]>
Commit-Queue: Tim Song <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495424}
Reviewed-on: https://chromium-review.googlesource.com/623915
Reviewed-by: Tim Song <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#700}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Refactor and stabilize keyboard controller state machine (part 2/2)
[email protected]
(cherry picked from commit 5a5448aac9bdb1ccbd49768cd6f43dece1050c9d)
Bug: 719905
Change-Id: I448ed4eeba37903596937ef4a6c08903f643fd5d
Reviewed-on: https://chromium-review.googlesource.com/582709
Commit-Queue: Keigo Oka <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489627}
Reviewed-on: https://chromium-review.googlesource.com/624134
Reviewed-by: Keigo Oka <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#699}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Refactor and stabilize keyboard controller states machine (part 1/2).
Keyboard controller state machine and expected conditions per state:
https://docs.google.com/spreadsheets/d/1DnpW0s0TuulJr0IZRCuAhESwZc4ClUSY5GgxtFvNZ4g/edit#gid=0
[email protected]
(cherry picked from commit 36f87e57654c712296d4ebdad6533f427be631e8)
Bug: 719905
Test: try
Change-Id: I3319a49831f3f1c8e77f51c34ef4bdb374818080
Reviewed-on: https://chromium-review.googlesource.com/577434
Commit-Queue: Keigo Oka <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489312}
Reviewed-on: https://chromium-review.googlesource.com/624047
Reviewed-by: Keigo Oka <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#698}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disable Skia raster pipeline for image tiling
Adding SK_SUPPORT_LEGACY_TILED_BITMAPS.
This is a revert of https://chromium-review.googlesource.com/545816.
BUG=753905,744674
[email protected]
(cherry picked from commit b9e02f8f670683edaac8b9e6c7a6ce23a5a71194)
Change-Id: I078f076e75fb868a50927efb8fc4e2de65339533
Reviewed-on: https://chromium-review.googlesource.com/620528
Commit-Queue: Florin Malita <[email protected]>
Reviewed-by: Mike Klein <[email protected]>
Reviewed-by: Mike Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495583}
Reviewed-on: https://chromium-review.googlesource.com/623988
Reviewed-by: Florin Malita <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#697}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.57
[email protected]
Change-Id: I708dc821d509e889cc798f93d5e889137b0ac47c
Reviewed-on: https://chromium-review.googlesource.com/622060
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#696}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.56
[email protected]
Change-Id: I69c95ca1094a874c3cb5e1b00501959b0807c153
Reviewed-on: https://chromium-review.googlesource.com/622053
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#695}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Eliminating flicker on updating Play Store results.
[email protected]
(cherry picked from commit 96eac6d936a4178064afe8eee7f0083e831ce176)
Bug: 748669
Change-Id: I82073f528c5616f7ee75c73ae2559b7912e603cd
Reviewed-on: https://chromium-review.googlesource.com/620196
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Vadim Tryshev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495636}
Reviewed-on: https://chromium-review.googlesource.com/622468
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#694}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.55
[email protected]
Change-Id: I75f68fb2ab3c908d32d8a5b0b862c1a7db282fbc
Reviewed-on: https://chromium-review.googlesource.com/621631
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#693}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reland "Avoid process backgrounding for renderers with an active video capture stream"
This reland adds BUILDFLAG(ENABLE_WEBRTC) checks for browser tests.
This is a reland of 77656c316ea633752b7fce8496738008276f6637
Original change's description:
> Avoid process backgrounding for renderers with an active video capture stream
>
> This CL follows how audio avoids process backgrounding.
> - We add counter in RenderProcessHost to keep track of active video sessions
> in tab.
> - We increment/decrement this counter through VideoCaptureHost which is the
> browser side communication endpoint for a renderer process using a video
> capture device.
>
> Bug: 753943
> Test: Added browsertests.
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I335d8e7d2efa0806d16f7b30d0d1a3ce8a3abef3
> Reviewed-on: https://chromium-review.googlesource.com/609032
> Commit-Queue: Emircan Uysaler <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Reviewed-by: Christian Fremerey <[email protected]>
> Reviewed-by: Dale Curtis <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#493827}
[email protected], [email protected], [email protected], [email protected]
(cherry picked from commit a93f46228530850007b9ac98a3f41fe7ff216128)
Bug: 753943
Change-Id: I09b58f231e9b9b272449ed057484523ec82e7aae
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/614220
Commit-Queue: Emircan Uysaler <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494230}
Reviewed-on: https://chromium-review.googlesource.com/621269
Cr-Commit-Position: refs/branch-heads/3163@{#692}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}fix buildbreak on 3163 after test merge
[email protected]
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I47c729f4565789c8a791eef4f801b8e3c85d9e9c
Reviewed-on: https://chromium-review.googlesource.com/621451
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#691}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.54
[email protected]
Change-Id: I7a735c2847178ea15d517b59a24cd7a9e3d92e71
Reviewed-on: https://chromium-review.googlesource.com/622190
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#690}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}PlzNavigate: non-user initiated navigations cancel renderer-initiated
This CL changes the navigation cancellation policy in PlzNavigate.
Following this CL, non-user initiated renderer-initiated navigations
will be able to cancel user-initiated renderer-initiated navigations.
They still won't be able to cancel browser-initiated navigations.
This fixes an issue where a window.Open followed by a submit form in the
same script does not result in the form being submitted.
BUG=755507
(cherry picked from commit 6cbfad5930cd6c7b762318f72572d2472252f395)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ifdc651a513438c6fa2dd5290dda2a5b53be3cd3f
Reviewed-on: https://chromium-review.googlesource.com/616642
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Camille Lamy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495139}
Reviewed-on: https://chromium-review.googlesource.com/622257
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#689}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix form resubmissions losing the Content-Type header with PlzNavigate.
A form resubmit gets the POST data from the serialized content::PageState that was sent by the renderer after the original post. There are two parts to this fix:
1) when the first form submit commits, the browser should send the renderer the Content-Type header. Since this is with PlzNavigate, the renderer doesn't actually use it. However, it will send it back along with the post body in content::PageState.
2) when the (browser-initiated) form resubmit occurs, the browser needs to extract the Content-Type header from the serialized content::PageState and add it to the list of request headers.
BUG=747812
[email protected]
(cherry picked from commit 7dfbcccf5e6fe580bd9e12a5841ef28bcee36de7)
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Idf1fcc6efe32b948c6fea7e7a5dc5ba06c2d9c26
Reviewed-on: https://chromium-review.googlesource.com/618298
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495188}
Reviewed-on: https://chromium-review.googlesource.com/621965
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#688}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix URL blacklisting not working with PlzNavigate.
The problem was that the PlzNavigate blob url used to send data to the renderer was being incorrectly triggered. This was fixed for Android in r456824.
BUG=755256
[email protected]
(cherry picked from commit 337a87dc2c9e67d0185d0058f7c466d5f1448d41)
Change-Id: I890e95a22580c33f4a478f2f99d76c04d0fdb22f
Reviewed-on: https://chromium-review.googlesource.com/616350
Reviewed-by: Bartosz Fabianowski <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494784}
Reviewed-on: https://chromium-review.googlesource.com/622279
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#687}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}chromeos: Add --force-clamshell-power-button.
Add a command-line flag that can be passed to instruct
ash::PowerButtonController to use clamshell-style power
button behavior even if it sees accelerometer events.
[email protected]
(cherry picked from commit 96b4c361ec7f4e354f8252d7a46aba6194f66f71)
Bug: 756601
Test: tested on device with --force-clamshell-power-button switch
Change-Id: I50784c9b68f1a1b33fc5d1cb2b25e2cbeb535826
Reviewed-on: https://chromium-review.googlesource.com/619690
Commit-Queue: Dan Erat <[email protected]>
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495393}
Reviewed-on: https://chromium-review.googlesource.com/621957
Reviewed-by: Dan Erat <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#686}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}m61 merge: app_list: make GetPointInsideSearchbox picking CenterPoint
changes:
Mainly for addressing the issue in crbug.com/756516, where in 3163
branch https://chromium-review.googlesource.com/c/567486 is not merged
back. In that change, the whole search box is the event target rather
than just the part inside the shadow.
Contacted varkha@, better changing the tapping point, not the margin of
search box.
TBR: [email protected]
(cherry picked from commit 820a7a5574b570545f06f716c5b19c7f5f2a1360)
Bug: 756516
Test: covered by tests
Change-Id: If66f70b223ffb1c53ddeb148b9a708def7385f41
Reviewed-on: https://chromium-review.googlesource.com/621533
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495673}
Reviewed-on: https://chromium-review.googlesource.com/621195
Cr-Commit-Position: refs/branch-heads/3163@{#685}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Use the full uri for the printer-uri in Get-Printer-Attributes.
We've been using the relative path for the printer-uri value in
Get-Printer-Attributes requests. After further testing, limited
printers support the relative path and require the full uri.
[email protected]
(cherry picked from commit 8d5e7fb9a6ffbf80184091a23ed9e8450e514a56)
Bug: 753086
Change-Id: I75c6f82b2d62f18a299444d20b13f40d9404b42b
Reviewed-on: https://chromium-review.googlesource.com/613801
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494532}
Reviewed-on: https://chromium-review.googlesource.com/621291
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#684}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Restore minimized window's ignored_by_shelf state correctly
when exiting overview mode
BUG=756313
TEST=covered by unit test (reused old disabled test)
(cherry picked from commit ea65a745e112a8585a75b15e18c4f7dbc72fa13e)
Change-Id: I93bffc61b12b03a25dba36a18d0ea4596dd24297
Reviewed-on: https://chromium-review.googlesource.com/620151
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495637}
Reviewed-on: https://chromium-review.googlesource.com/621968
Cr-Commit-Position: refs/branch-heads/3163@{#683}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}A window in ForgetWindow may not be registered yet
TabletModeWindowManager starts observing the window when
it is added, then decide if it can be managed. If you
set the property, it'll call OnPropertyChanged on the window
before it is added to the managed map.
BUG=b:62531738
TEST=covered by unit tests.
(cherry picked from commit 7c6511d4eed31fa175d7d29f933f1c7c35e3ae8e)
Change-Id: Ib1ad66b3c9e5359e7ea2c4ec11252f2e5fafb9d0
Reviewed-on: https://chromium-review.googlesource.com/614961
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495354}
Reviewed-on: https://chromium-review.googlesource.com/621369
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#682}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[EasyUnlock] Clear cryptohome keys after user disables the login flow.
After disabling the login flow in chrome://settings, the cryptohome keys for
EasyUnlock will be cleared, so only the password can be used to decrypt the user
data.
BUG=754865
[email protected]
(cherry picked from commit 3f3a82a702e443ed80e1fd38168f68c95b22506d)
Change-Id: Ia68fbcf39e849ae6352994a8f459136ad7de19de
Reviewed-on: https://chromium-review.googlesource.com/612046
Commit-Queue: Tim Song <[email protected]>
Reviewed-by: Gustavo Sacomoto <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495389}
Reviewed-on: https://chromium-review.googlesource.com/621868
Reviewed-by: Tim Song <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#681}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[EasyUnlock] Fix crash when restarting BLE scan after a connection fails.
BUG=756143
[email protected]
(cherry picked from commit 6bac2afdd50364863edeffbdde06aeaf09bc6a87)
Change-Id: I3384c256aa6f3b2ad49e9606159512534b697d5d
Reviewed-on: https://chromium-review.googlesource.com/618142
Reviewed-by: Gustavo Sacomoto <[email protected]>
Commit-Queue: Tim Song <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495226}
Reviewed-on: https://chromium-review.googlesource.com/621774
Reviewed-by: Tim Song <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#680}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Keep track of which guests destroy on detach.
To maintain consistency with non-oopif webview and PDF, we
need to destroy PDF GuestViews on detach, but not other
guestViews. https://chromium-review.googlesource.com/c/587448
regressed the behaviour fixed in the related bug, this CL fixes
that.
[email protected]
(cherry picked from commit 2c792cfa50fb6e6ab02185ce846076ac8885bdb2)
Bug: 569903
Change-Id: I796954c282631e9ba50270e79d6a1b84fe12c2f8
Reviewed-on: https://chromium-review.googlesource.com/616006
Reviewed-by: Lucas Gadani <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494780}
Reviewed-on: https://chromium-review.googlesource.com/621511
Reviewed-by: James MacLean <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#679}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61] arc: Fix ARC OOBE ToS layout for some languages.
In case some languages are selected (for example Spain), ARC OOBE ToS
has visual gap at the bottom of the page. Fix is to apply page container
style with fixed height.
[email protected], [email protected]
Test: Manually with various langs.
Bug: b/64812679
(cherry picked from commit 42207cbe2a342e5dac6c120c8e1f49327b481a48)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1c592380c7299071eca879b7dc6a57c6b41c4e70
Reviewed-on: https://chromium-review.googlesource.com/619759
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495603}
Reviewed-on: https://chromium-review.googlesource.com/621420
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#678}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Enable asm.js -> WebAssembly by default.
Honor disable flag from the chrome side.
BUG=v8:4203
BUG=chromium:590395
[email protected]
[email protected]
(cherry picked from commit 2b2ec4ad531ae43a75973857fb969d18d81a22c3)
Change-Id: I798cc67255d07bbd8404254ec0b6332e77ec0452
Reviewed-on: https://chromium-review.googlesource.com/619293
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Brad Nelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495336}
Reviewed-on: https://chromium-review.googlesource.com/621398
Reviewed-by: Brad Nelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#677}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61] Reland "arc: Implement Play Store ToS pre-loading in OOBE."
This reverts commit fb0acd342f7dd7eba0881fc3a9eb9c798a454ba1.
Contains fix for MSan builds
[email protected], [email protected]
(cherry picked from commit 083071a9031a9d0ffdc8ed2deb9c9e6b855ffd19)
Bug: b/64368201
Bug: b/64367751
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I49d06071bc6d8ef5b3e327c4cd68a040dcc8afc7
Reviewed-on: https://chromium-review.googlesource.com/614570
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494415}
Reviewed-on: https://chromium-review.googlesource.com/621395
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#676}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Compute touch-action for replaced canvas
Touch action is ignored on inline non-replaced elements, but canvas can
be a replaced element under some circumstances.
This CL makes StyleAdjuster respect canvas' touch-action in this case.
[email protected]
(cherry picked from commit 6be43e7f8e0806cf773ffdd1adb91811740c9ed3)
Bug: 745898
Change-Id: I08c6d8410eb32d1122e2020d387dc169d96af539
Reviewed-on: https://chromium-review.googlesource.com/610800
Reviewed-by: Steve Kobes <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Xianda Sun <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495343}
Reviewed-on: https://chromium-review.googlesource.com/621606
Reviewed-by: Xianda Sun <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#675}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Update Google "G" in the NTP search box when the DSE changes.
[email protected]
(cherry picked from commit b13515ab56d3be6604df969bd74298d6e1e9066d)
Bug: 741882
Change-Id: I862a892fff13c00ac1b420aabaf1b23840db9356
Reviewed-on: https://chromium-review.googlesource.com/603718
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Bernhard Bauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493341}
Reviewed-on: https://chromium-review.googlesource.com/621327
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#674}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disable first run for mananged profiles
[email protected]
(cherry picked from commit d124ec827874e5b88eeabe3b2660214a84031bf5)
Bug: 753566
Change-Id: I653c6476d219363da8f79a3479180cef0f776556
Reviewed-on: https://chromium-review.googlesource.com/612346
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493883}
Reviewed-on: https://chromium-review.googlesource.com/621088
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#673}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Toggle select when tapping on thumbnail/icon, instead of opening it.
[email protected]
(cherry picked from commit cdb29caeef4fe23ca224e10cb72ef8b3fe2570d6)
Bug: 755695
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If0cff9f42e5bc023608bdbd174c1f1a88e33e3b0
Reviewed-on: https://chromium-review.googlesource.com/616580
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494723}
Reviewed-on: https://chromium-review.googlesource.com/620351
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#672}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Apply dangling markup restrictions to `<link>`.
`preconnect`, `dns-prefetch`, and `prefetch` were all inadvertantly
bypassing the danging markup mitigations we landed for "actual" resource
requests. This patch resolves that oversight.
[email protected]
(cherry picked from commit 682b16cc3fd2316946670f25f38a9abba6827fe4)
Bug: 680970, 695474, 749852
Change-Id: Ic2a262d062a92830b1869b3fb3183280156f3c0a
Reviewed-on: https://chromium-review.googlesource.com/571785
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493728}
Reviewed-on: https://chromium-review.googlesource.com/620587
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#671}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Remove unnecessary operation on opening message center.
This CL removes unnecessary image operation on opening message center. With this CL, opening the message center gets 50-500 times faster.
[email protected]
(cherry picked from commit 101b811383bbcdefaa86e864275afbea17d902f8)
Bug: b/64544553
Bug: 750587
Change-Id: I045f1a285fcacb6dafb997ad2fefbfe4ad54791b
Reviewed-on: https://chromium-review.googlesource.com/616520
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494703}
Reviewed-on: https://chromium-review.googlesource.com/620429
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#670}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Select and drag file(s) by long-touch and slide anywhere on a file row.
Dragging other parts of the row than filename / icon before selecting it
is treated as range-select if done by mouse.
We don't support this way to range-select by touch, but instead allow
select and drag the item in one action.
[email protected]
(cherry picked from commit 6ae9bf4f7a9879aeba58c1c856ab08cecb7b1b33)
Bug: 755709
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If29e8d08ba9a06ae188aa3b65f626c963ba2e0a2
Reviewed-on: https://chromium-review.googlesource.com/618310
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495083}
Reviewed-on: https://chromium-review.googlesource.com/620366
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#669}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Adding a missing accessibility event.
Now that answer card can change without being hidden first, we need to
generate an accessibility event when it's updated in-place.
[email protected]
(cherry picked from commit 9be2a3fd071cd9170af3c400f5323b3de7675e0d)
Bug: 712331
Change-Id: I7d08796d7854fa6644e6fd41c228ce5927c39252
Reviewed-on: https://chromium-review.googlesource.com/618290
Commit-Queue: Vadim Tryshev <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495276}
Reviewed-on: https://chromium-review.googlesource.com/620030
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#668}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Prevent focusing an invisible item in context menu by keyboard.
We have been using hidden=true attribute to hide some menu items.
We started to use display=none CSS attiribute for the same purpose,
so that it can change visibility of items by changing an attribute of
the parent node.
https://chromium-review.googlesource.com/c/566768/15/ui/file_manager/file_manager/foreground/css/file_manager.css
The logic for keyboard focus should also skip items hidden by that way.
[email protected]
(cherry picked from commit 943e158f13877b2ee92dd237913c1b0fa12ace11)
Bug: 748504
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia4c6cffcc9ac5e64c64da7644622ebf2949727e0
Reviewed-on: https://chromium-review.googlesource.com/597386
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#491926}
Reviewed-on: https://chromium-review.googlesource.com/620330
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#667}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix CHECK in ImageResource::AllClientsAndObserversRemoved()
There is slight chance where HasImage() and ErrorOccurred() are both
true, after ErrorOccurred() is set to true in Resource::FinishAsError()
before ImageResourceContent's image is cleared in UpdateImage()
called just after Resource::FinishAsError() from
ImageResource::FinishAsError().
This particular case looks harmless and causing crashes, this CL
supresses the CHECK during Resource::FinishAsError().
[email protected]
(cherry picked from commit 942393c6c300f35c3e74c94f95ddc730eff3025b)
Bug: 701723
Change-Id: I293950b44eb25229e1659e75348d4e800a4dd6ef
Reviewed-on: https://chromium-review.googlesource.com/607456
Reviewed-by: Hajime Hoshi <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494020}
Reviewed-on: https://chromium-review.googlesource.com/619181
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#666}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.53
[email protected]
Change-Id: I7b4b2db75a33116aee83571a9f09214192939999
Reviewed-on: https://chromium-review.googlesource.com/619891
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#665}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Updating XTBs based on .GRDs from branch 3163
[email protected]
Change-Id: Icac5c26c613739a73f8af0471b40f85ace2646e3
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Change-Id: Icac5c26c613739a73f8af0471b40f85ace2646e3
Reviewed-on: https://chromium-review.googlesource.com/619573
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#664}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Record printer installation metrics for automatic and manual installs.
Record IPP make and model information, USB information, and chosen
PPD data for printers installed from the printer setup page.
[email protected]
(cherry picked from commit 2027281ba9565edf3ed5dd745de6b734d5abc6ed)
Bug: 740270
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I08c34e54694de3eadf3647d16ff052f1ef848eb6
Reviewed-on: https://chromium-review.googlesource.com/600890
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494133}
Reviewed-on: https://chromium-review.googlesource.com/619852
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#663}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Default PrinterEventTracker logging to false.
[email protected]
(cherry picked from commit d54f3fa15646a377b15ac046d4e860b872ab5e33)
Bug: 647283
Change-Id: I09665f40ebfd6c7cec747a9ad8daa8cccaf0c5ce
Reviewed-on: https://chromium-review.googlesource.com/619327
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495260}
Reviewed-on: https://chromium-review.googlesource.com/619848
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#662}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Require encryption for IPPS printers in Get-Printer-Attributes requests.
Require encryption if we see an ipps scheme. IPPS requests were being
rejected otherwise.
[email protected]
(cherry picked from commit a2780bb650cd4c72357152d14a10371127f90bd1)
Bug: 753086
Change-Id: Ifec14e7fa036027c7874d6b684c8faa089deb75e
Reviewed-on: https://chromium-review.googlesource.com/609374
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493669}
Reviewed-on: https://chromium-review.googlesource.com/619927
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#661}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add a histogram to track IPP Attributes failures.
Requests for IPP Get-Attributes seem to be failing more than expected.
Add a metric to track the failure rate so we can verify when it's fixed.
[email protected]
(cherry picked from commit fcba9cb6188c6f3df986c93d4ca50eec39929fa3)
Bug: 753086
Change-Id: I536e5d755585f04eddb561d4c7f34f48e7209fff
Reviewed-on: https://chromium-review.googlesource.com/605054
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492779}
Reviewed-on: https://chromium-review.googlesource.com/619698
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#660}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Record USB printers installed automatically.
USB printers are installed automatically if we are sure of the
configuration. Log these printers with USB attributes and the fact
that they were configured automatically.
[email protected]
(cherry picked from commit 1f7193d347a565c5e3f1e5eef810dab2c5e97402)
Bug: 740270, 725739
Change-Id: I50d4596cbf94fc9de8871cf5c8e02ded75e05681
Reviewed-on: https://chromium-review.googlesource.com/598691
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#491800}
Reviewed-on: https://chromium-review.googlesource.com/619756
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#659}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Extend Printing detector interface to pass metadata.
This changes the PrinterDetector interface to pass through additional
metadata about printers in its API. This will allow us to do automatic
driver searches in users of the Detection results.
Copy from https://chromium-review.googlesource.com/c/580587
[email protected]
(cherry picked from commit 4d9f08573ffcace0f52f3740bdf1dde28b11cccf)
Bug: 744996, 742487, 725739
Change-Id: I8dc80224d35620c1614a6afb25e187f1ec00489b
Reviewed-on: https://chromium-review.googlesource.com/590586
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490556}
Reviewed-on: https://chromium-review.googlesource.com/619770
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#658}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add metalayer strings
Add two new metalayer-relater strings used to indicate the "loading"
state in the menu and in the toast.
[email protected]
(cherry picked from commit 84cf3111f0862a04829a9869f4724591a0476418)
Bug: b:64028565
Change-Id: I1fa7d28299e3760676da701efe97a4a1b4311d0d
Reviewed-on: https://chromium-review.googlesource.com/619288
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495253}
Reviewed-on: https://chromium-review.googlesource.com/619837
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#657}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}MetalayerMode should not be active during OOBE
Bail out early from PaletteDelegateChromeOS::IsMetalayerSupported
if profile_ is nullptr.
Also defensively moved the code accessing the palette delegate
after the event checks, so that the delegate it is only invoked
for pen events.
[email protected], [email protected]
(cherry picked from commit 7d2d92d8afb61d48c415839ec7e8109f9b66305f)
Bug: 756267
Change-Id: I55edf3cd55e76a4596f4b1f88edaae501c58e587
Reviewed-on: https://chromium-review.googlesource.com/618131
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495043}
Reviewed-on: https://chromium-review.googlesource.com/619836
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#656}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Update app list button style when non-primary user becomes active
- Update button style on user switches if necessary.
- Refactor flags inside AppListButton.
BUG=b/64496927
[email protected]
(cherry picked from commit 225e74598667a30dbc65816bdbc9c1fe62508ba5)
Change-Id: Ibd9163785478c828c1d0ed68d20c08214736eb40
Reviewed-on: https://chromium-review.googlesource.com/614425
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494933}
Reviewed-on: https://chromium-review.googlesource.com/619568
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#655}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix merge for branch 3183.
ProvideGeneralMetrics was renamed to ProvideCurrentSessionData.
Bug: 647283
Change-Id: I35a9a26200141ab067d12b07f28b8b4e5d31134f
Reviewed-on: https://chromium-review.googlesource.com/619591
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#654}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Notify the container about metalayer mode changes
Entering the metalayer mode should cause an explanatory
message shown in the voice interaction framework UI.
This can be achieved by using existing mojo method
VoiceInteractionFrameworkInstance.SetMetalayerVisibility, which
has been introduced for the previous metalayer implementation and
has not been deprecated yet.
[email protected]
(cherry picked from commit 3f119533e3dc0b795e61f4e0be4d2a5993e1a38e)
Bug: b:64218411
Change-Id: Ib5d26dc60818b0d1594dc4a03e341a15af7ac2d1
Reviewed-on: https://chromium-review.googlesource.com/617325
Reviewed-by: Luis Hector Chavez <[email protected]>
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494924}
Reviewed-on: https://chromium-review.googlesource.com/619831
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#653}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}add role to voice interaction structure.
BUG=b:64489919
TEST=locally verify role parameter is added to
voice interaction structure.
[email protected]
(cherry picked from commit 8aa2ec1f2c72a6e0590abfc3a4cd46db4aee05dc)
Change-Id: I1545aa79e214427f51c761e5315f8c7c941f8f0f
Reviewed-on: https://chromium-review.googlesource.com/612476
Reviewed-by: Luis Hector Chavez <[email protected]>
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Muyuan Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494923}
Reviewed-on: https://chromium-review.googlesource.com/619829
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#652}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}m61 merge: CrOS: Do not show orientation notification when existing tablet mode.
m61 merge on behalf of wutao@.
We should not get screen orientation notification when existing tablet
mode. Set the rotation source to ROTATION_SOURCE_ACCELEROMETER when
existing tablet mode.
TBR: [email protected]
(cherry picked from commit f1698dacf4b32366c7f0e59e08dfbcf22bfa58af)
Bug: 752590
Test: tested on device.
Change-Id: I61c208e848cef12a357755e3227a234945771092
Reviewed-on: https://chromium-review.googlesource.com/617612
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494956}
Reviewed-on: https://chromium-review.googlesource.com/619826
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#651}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add AppListButton unittests for Secondary user
If secondary user long press the button, the gesture should not be
handled.
BUG=b/64496927
[email protected]
(cherry picked from commit a6e0baac3ff8b10ff711fd4f6955dede1e993eb8)
Change-Id: I2624c476fbcacd68f394c9e9b8ea92ba481f4e15
Reviewed-on: https://chromium-review.googlesource.com/615983
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494855}
Reviewed-on: https://chromium-review.googlesource.com/619185
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#650}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros: Add ash prefs adapter from ShellObserver to SessionObserver
Trunk uses SessionObserver to notify when the user profile preferences
are ready. M61 does exactly the same thing, but via ShellObserver.
Make Shell also notify via SessionObserver so code written in trunk
can be cleanly backported.
Bug: none
Test: added to ash_unittests
Change-Id: Ib92b4d174fda9691cf6e2a2a828f47b69c74de17
Reviewed-on: https://chromium-review.googlesource.com/619492
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#649}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add UMA histogram for palette options invoked via shortcuts
Adding a new histogram "Ash.Shelf.Palette.Usage.Shortcut"
similar to existing "Ash.Shelf.Palette.Usage" and
"Ash.Shelf.Palette.Usage.AutoOpened".
It is used to track palette option invocation by means other
than the palette menu (such as a stylus button or a keyboard
shortcut).
[email protected]
(cherry picked from commit dd180779b7b4bb1f5dbf35b1ad7305d8affdbf4a)
Bug: 755563
Change-Id: I4063b9346ab800f55bb8608b161397b8a4e7410a
Reviewed-on: https://chromium-review.googlesource.com/615365
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494710}
Reviewed-on: https://chromium-review.googlesource.com/619183
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#648}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Show progress bar in system tray when Tether device is scanning.
[email protected]
(cherry picked from commit 43c8c33283670cd828c7ca92b4f2b908911b07a1)
Bug: 754491, 672263
Change-Id: I437f07207e36083ee310197843518d1fd398f525
Reviewed-on: https://chromium-review.googlesource.com/615666
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Leslie Watkins <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494892}
Reviewed-on: https://chromium-review.googlesource.com/619786
Cr-Commit-Position: refs/branch-heads/3163@{#647}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Revert "Add color transformation for voice interaction overlay"
This reverts commit f25b3f25ae9a51ab84e3ad9fe70b0f96eeefdc4c.
Reason for revert: UX does not want to change the color anymore.
BUG=b:64614459
TEST=build locally and see changes
Original change's description:
> Add color transformation for voice interaction overlay
>
> TEST=locally build and flash, check animation
> BUG=b:35624617
>
> Change-Id: Ibc1a6ff218790c547138ca406bb923467bc4fb8a
> Reviewed-on: https://chromium-review.googlesource.com/581855
> Reviewed-by: Mitsuru Oshima <[email protected]>
> Commit-Queue: Xiaohui Chen <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#490041}
[email protected]
(cherry picked from commit b77a942fbeaf003eb19e19372a6ae8f1d0d2f33d)
Bug: b:35624617
Change-Id: I22948adb311ec3d1cac6dd7737447faad837d7f1
Reviewed-on: https://chromium-review.googlesource.com/612566
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494494}
Reviewed-on: https://chromium-review.googlesource.com/619177
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#646}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Inset lock layout window bounds by the chromevox panel height
This fixes an issue with chromevox panel being shown on top of the lock
window, and obscuring top of the lock/login UI.
Changes lock_window_state to inset window bounds by the panel height
(which is provided by the current window shelf layout). Additionally,
to ensure the bounds get updated when the panel is shown, the lock
layout manager now updated the window bounds when the shelf is relayout.
BUG=755352
[email protected]
(cherry picked from commit 0988e3a0bd1fb0213a174dc890130cf13b96540d)
Change-Id: Ie14bce5cf7f2fbfe33a08781822e8d41f416d8a3
Reviewed-on: https://chromium-review.googlesource.com/612262
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494512}
Reviewed-on: https://chromium-review.googlesource.com/619746
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#645}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Record the printer removal PrinterEvent.
This CL implements the infrastructure for logging PrinterEventProtos. Only
removals are logged right now. Successful setup and setup abandonment will
be added in follow up CLs.
[email protected]
(cherry picked from commit 1b56803c0e2a1ff75797486f44712e951ee4f1a2)
Bug: 647283
Change-Id: I9b3dbd37ee0db486d1c55686f729f65009d03cb8
Reviewed-on: https://chromium-review.googlesource.com/590584
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#491222}
Reviewed-on: https://chromium-review.googlesource.com/619614
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#644}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Remove bidi checker tests and some of the backing code
[email protected]
[email protected]
BUG=748164
(cherry picked from commit aeb9d32b6c3329f1ee586f48294e625a19a3c31c)
Review-Url: https://codereview.chromium.org/2933653002
Cr-Original-Commit-Position: refs/heads/master@{#489361}
Change-Id: I2e87e14ae351554c6ee16b62fe6d184ee214e3f1
Reviewed-on: https://chromium-review.googlesource.com/619664
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#643}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Refactor VoiceInteractionOverlay initialization
- Move the initialization later into session so that all usages of
chromeos::swithes::IsVoiceIntearctionEnabled are inside user session.
- Add a flag for whether the primary user session is active. The voice interaction animation will be disabled when non-primary session is active.
- Update the unittests for app list button.
BUG=b/63778151, b/64496927
[email protected]
(cherry picked from commit d74466d76a13f75c206428d53c99b12265548000)
Change-Id: I5f97bf94fd85512b96b56b7c169026af0bedae71
Reviewed-on: https://chromium-review.googlesource.com/604693
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494215}
Reviewed-on: https://chromium-review.googlesource.com/619173
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#642}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}exo: Apply full surface damage on non-buffer changes
Setting certain surface values such as the plane alpha should
effectively damage the entire surface. The complete set seemed to be the
scale, blending mode, plane alpha, viewport rectangle, and clip rectangle.
[email protected]
(cherry picked from commit d1e23fd43417af085ecf8b3a14a3e8df1801db52)
Bug: 754548
Change-Id: I4ee8a47bdfcdbb1be4ae10b43fbf140aae25311c
Reviewed-on: https://chromium-review.googlesource.com/611619
Commit-Queue: Lloyd Pique <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494595}
Reviewed-on: https://chromium-review.googlesource.com/619488
Cr-Commit-Position: refs/branch-heads/3163@{#641}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}shelf: Make back button work in rtl languages.
Back button now does the right thing in RTL languages. It still does not work with voice interaction animation overlay but that is left untouched due to voice interaction animation overlay not working in RTL by itself.
[email protected]
(cherry picked from commit 3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc)
Bug: 751280
Test: ash_unittests "BackButtonAppListButtonTest*"
Change-Id: I8cd595bbf076beb2383fa1324a9f4a217ca44536
Reviewed-on: https://chromium-review.googlesource.com/597107
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494139}
Reviewed-on: https://chromium-review.googlesource.com/619451
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#640}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}shelf: App list button flashes under shelf before animating.
When moving from tablet mode to normal with a couple maximized windows. The app list button bounces to the bottom before animating as expected. This is because the back button is only displayed when it is tablet mode, or animating. In this case, it is considered as no longer in tablet mode, but the animation has yet to start (maybe because of reattaching former window states) so the app list button circle does a quick "bounce".
[email protected]
(cherry picked from commit f2a4c2d278c3cbfbca351ae29ebb15b30981e542)
Bug:
Test: ash_unittest "ShelfViewTest"
Change-Id: I8edfc4d18d0d46ec5f235f9929000bae1bc308cc
Reviewed-on: https://chromium-review.googlesource.com/607707
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494104}
Reviewed-on: https://chromium-review.googlesource.com/619650
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#639}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}shelf: Ink drop shows up on back button instead of app list button.
If one uses the back button, then opens the launcher without pressing the app list button (swipe shelf), the ink drop is activated on the back button. This is because the ink drop needs to know the last seen event to correctly figure out the placement.
[email protected]
(cherry picked from commit 7812562705dfd5734e572f4d49e9396eef2d7cbc)
Bug: 754058
Test: ash_unittests "AppListButtonInkDropTest.*"
Change-Id: Iad4b43c8c4e6f2566bbc655ddd59580444cc120e
Reviewed-on: https://chromium-review.googlesource.com/611009
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493575}
Reviewed-on: https://chromium-review.googlesource.com/619447
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#638}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Make a copy of passed-in ScriptOrigin in V8ScriptRunner::ThrowException
This avoids an ApiCheck failure when the origin was created for a module.
[email protected]
(cherry picked from commit 849e0545e6471b5b586cf5b2a20eea0764cf2d20)
Bug: 755798
Change-Id: I122365b17aa5d04ccc4a3465e14552c6dd9fc730
Reviewed-on: https://chromium-review.googlesource.com/616252
Commit-Queue: Adam Klein <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494912}
Reviewed-on: https://chromium-review.googlesource.com/619646
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#637}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}shelf: Animate the shelf back button when enter/exit maximize mode.
When entering or exiting maximize mode, animate the shelf back button.
See https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZR34IMaWJcOe/files/MCElSya0Iowq6DTSt2ueLG7iwMSJbxAVNpw
for the animation. The back button slides out from underneath the app list circle and the
back button arrow fades in. We need to allow animations on shelf icons when entering or exiting maximize
mode to achieve this.
[email protected]
(cherry picked from commit bbc880900a47a3d21b407c9e5b87510dd926ed55)
Test: ash_unittests --gtest_filter="ShelfViewTest.TestShelfItemsAnimations
Bug: 721940
Change-Id: I77953e28c1a3eeb1d285a2d97be8c0a476494977
Reviewed-on: https://chromium-review.googlesource.com/568246
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490995}
Reviewed-on: https://chromium-review.googlesource.com/619549
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#636}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Settings WebUI] Show hotwording deprecation message on Chrome OS
Shows a message in the settings UI notifying user hotwording is
deprecated on Chrome OS if they had previously enabled hotwording.
Otherwise hotword functionality including settings have been
completely disabled by
https://chromium-review.googlesource.com/c/616069
[email protected]
(cherry picked from commit ac6794caaf6af2153665f37a1c786e2de1d00202)
Bug: 737806
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9166267636f8c3d3e40448bd6595690a6df5adea
Reviewed-on: https://chromium-review.googlesource.com/611149
Commit-Queue: Ryan Cui <[email protected]>
Reviewed-by: Kendra Carattini <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Demetrios Papadopoulos (OOO till Sept 11th) <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#495034}
Reviewed-on: https://chromium-review.googlesource.com/619493
Cr-Commit-Position: refs/branch-heads/3163@{#635}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disable hotwording feature in ChromeOS
BUG=755579
TEST=build and flash locally, see hotword option gone in settings
[email protected]
(cherry picked from commit 2ae7e77825227aff906d9d3010e2379e7ad32417)
Change-Id: I2142d7b323aea9d66a31d999405ab79e4ca6e60a
Reviewed-on: https://chromium-review.googlesource.com/616069
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494653}
Reviewed-on: https://chromium-review.googlesource.com/619491
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#634}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Speculative fix to stop crashes for https://crbug.com/752822.
The crash reported in the linked bug appears to occur when we attempt to
get UserData associated with a null web-contents. This looks like it
occurs when the MimeHandlerViewGuest has a null embedder WebContents*.
This CL is a speculative fix, to at least stop the crashes while we sort
out why this situation occurs in the first place.
[email protected]
(cherry picked from commit 3270e6bfe5391eb10339eef4e15ca50ce2ecf5c9)
Bug: 752822
Change-Id: I6219633c88b6c151c748249e7d3f31ea78857e06
Reviewed-on: https://chromium-review.googlesource.com/614995
Reviewed-by: dsinclair <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494449}
Reviewed-on: https://chromium-review.googlesource.com/619294
Reviewed-by: James MacLean <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#633}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Merge - [Web Payments] Use the correct PersonalDataManager in incognito
Before this change, adding an address in incognito mode from the
Payment Request editor would cause a Browser crash because Payment
Request attempted to use an ill-initiated PersonalDataManager's
URLRequestContext. This is because autofill uses the original
profile's PersonalDataManager rather than instantiate a new one.
This change brings Payment Request in line with autofill and uses
the original profile's PersonalDataManager, preventing the crash.
[email protected]
(cherry picked from commit ef6e100e869af31681d62bfdb1b886e5cc18a963)
Bug: 755161
Change-Id: Iba1ca7cc86d2c0ef50030c4d9fe84c85c551b71f
Reviewed-on: https://chromium-review.googlesource.com/615185
Commit-Queue: Anthony Vallee-Dubois <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494432}
Reviewed-on: https://chromium-review.googlesource.com/618803
Reviewed-by: Anthony Vallee-Dubois <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#632}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61]arc: Optin reskin. Accessibility
Update optin app accessibility with feedback from accessibility review.
No layout/flow change.
1. Mark icon image and error image as non-readable
2. Create correct window title.
3. Read "Google play terms of service" before "Agree button" when Tos
page is loaded.
4. Move checkbox text into paper-checkbox body so that text and check
state are read together.
5. Create stand alone hidden content text in case metrics checkbox need
to be hidden.
[email protected]
Bug: 747549
Bug: 746569
Test: Manul test with ChomeVox
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I05c1fb00b20ff8dc21660feda9b08c837123e21b
Reviewed-on: https://chromium-review.googlesource.com/616062
Commit-Queue: Long Cheng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494849}(cherry picked from commit 3104cc174d1e2261394312efff22de29e904d6d8)
Reviewed-on: https://chromium-review.googlesource.com/619068
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#631}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Remove chrome://settings-frame on CrOS
This removes all remaining references to chrome://settings-frame
and removes the URL.
It does not remove the options code yet, see the list of issues
blocking crbug.com/728353
This also removes quick_unlock_configure_overlay.js since it
included a reference to chrome://settings-frame and is only
used by the now fully deprecated options UI.
[email protected]
(cherry picked from commit eaa2161ed13ccee7456612363d5017222f7fdf25)
Bug: 748164
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1b44f8a9c4b4eeefb972ae4b29eec95a8969220c
Reviewed-on: https://chromium-review.googlesource.com/583935
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489672}
Reviewed-on: https://chromium-review.googlesource.com/619230
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#630}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Removes unnecessary resource extraction step for Android assets
This CL removes unnecessary resource extraction step from
BrowserStartupController. This would stop Monochrome from automatically
extracting Chrome locale paks for WebView applications.
Previously, WebView's AwBrowserProcess would invoke
BrowserStartupController.startBrowserProcessesSync, which involved
the necessary resource extraction. Meanwhile, Chrome's resource
extraction is handled by ChromeBrowserInitializer. And as content_shell
now stores their resource pak uncompressed, this step is unnecssary
for non-test APKs.
This CL also modifies NativeLibraryTestCommon so that test APKs that
use Chrome's locale paks extract compressed locale paks at start up.
[email protected]
(cherry picked from commit 7b5d2466ed0b2dc453b93c542ce6a6846f2ffa0a)
Bug: 752510
Change-Id: I638f0e76c86df95f4f7d3ef817c401cea3932c85
Reviewed-on: https://chromium-review.googlesource.com/610824
Commit-Queue: Felix <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494169}
Reviewed-on: https://chromium-review.googlesource.com/619008
Reviewed-by: Felix <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#629}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reset selection and set the right lead index upon long-pressing.
The lead index must be set so that commands referring it, like rename,
can work successfully.
This change also clears the selection before selecting the item, so as
to make sure existing single selection (which is old lead item) will
be cleared.
[email protected]
(cherry picked from commit e6b3ed78d0c53ca28e9959363132e9d8f4252933)
Bug: 754272,754283,754290
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieb051b3b517cc06cd021d9b0feaa56c1e2a73b38
Reviewed-on: https://chromium-review.googlesource.com/610341
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494354}
Reviewed-on: https://chromium-review.googlesource.com/618830
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#628}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix race during WebRtcMediaStreamTrackAdapter initialization.
This does not completely fix bug 751785, but it is a prerequisite.
[email protected]
(cherry picked from commit bed043e4d38f7e38c98bec358a5ef870358ba195)
Bug: 751785
Change-Id: I3ece316c04f80cbafdb5959d9a19851086a1baf1
Reviewed-on: https://chromium-review.googlesource.com/610233
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494115}
Reviewed-on: https://chromium-review.googlesource.com/618332
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#627}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[merge-m61] Fix SizeToContents() for bubbles that change their StyledLabel title.
This regressed in r482840. Causing, e.g., the save password signin
promo dialog to lose its buttons.
Some dialogs switch out their client view and change dialog
title when transitioning between states. r482840 meant that titles in
the BubbleFrameView could be views::StyledLabel as well as views::Label.
Unfortunately, views::StyledLabel has a complex way of calculating
its preferred size. Previously, asking for its preferred size
immediately after calling PreferredSizeChanged() would always return
0x0, unless there was an intervening call to GetHeightForWidth().
And changing StyledLabel text triggers PreferredSizeChanged().
To fix properly, we need to address a chicken-and-egg problem that
exists in BubbleFrameView regarding the the dialog title. The
height of the title depends on the width of the dialog, since the title can
wrap. But insets used for GetSizeForClientSize() determine the bubble size,
and that must account for the dialog title.
So split out the GetInset() calculation into versions that can be
done with the current client size and a forecast client size.
[email protected]
(cherry picked from commit 1453be1214185aed2b13fdec79c73f842fd2eb83)
Bug: 751375
Change-Id: I3e7b26989008285c625cd56ac553d4418f493906
Reviewed-on: https://chromium-review.googlesource.com/601692
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493962}
Reviewed-on: https://chromium-review.googlesource.com/618531
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#626}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros, drm: fix errata to set src_y of plane to drm atomic
TEST=run chrome on youtube using eve
BUG=743277
[email protected]
(cherry picked from commit 7a2ac6c75aaeea4e3a2546b82cd358b4088cf036)
Change-Id: Ie096276779faafed71309372d4fa44ac07054c20
Reviewed-on: https://chromium-review.googlesource.com/581880
Commit-Queue: Dongseong Hwang <[email protected]>
Reviewed-by: Dongseong Hwang <[email protected]>
Reviewed-by: Daniel Nicoara <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488783}
Reviewed-on: https://chromium-review.googlesource.com/618487
Cr-Commit-Position: refs/branch-heads/3163@{#625}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Process Switching IME and Lock key events in chromium side.
Ctrl-SPACE, Ctrl-Shift-SPACE, and LOCK key accelerators are not
passed to a client of exo anymore.
Bug: b/64256762.
Test: Start ARC apps and focus on a text field, then press
Ctrl-SPACE. IME should switch.
[email protected]
(cherry picked from commit bf3aaeb3c34052bfa6d250b8180f86a4255bb2fd)
Change-Id: I6a2321f1ac1393aaa42de9ed2c4f68121ec8e6fb
Reviewed-on: https://chromium-review.googlesource.com/603042
Commit-Queue: Yuichiro Hanada <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492533}
Reviewed-on: https://chromium-review.googlesource.com/618309
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#624}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Revert "Close a menu when tapping outside it, in addition to mouse click."
This reverts commit 0a47b209521568489f0cfba7f39fb0e8bdec34b4.
Reason for revert: The change didn't fix 753723, and also caused a regression bug (crbug/753723#c9).
Original change's description:
> Close a menu when tapping outside it, in addition to mouse click.
>
> This is needed when the app processes touch events and cancels it so as
> to not trigger mousedown events after touch.
>
> Bug: 753723
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I37bab3186ebb982a56339633c8898827e0dfd478
> Reviewed-on: https://chromium-review.googlesource.com/608347
> Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
> Reviewed-by: Michael Giuffrida <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#494024}
[email protected], [email protected]
(cherry picked from commit 636d1e0453bdc143ded019bb3e45331a10c6dfa3)
Bug: 753723
Change-Id: I577d20e4f1686c61b78597008149bfd22a556356
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/615323
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494377}
Reviewed-on: https://chromium-review.googlesource.com/617847
Cr-Commit-Position: refs/branch-heads/3163@{#623}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Support fullscreen app list in extended monitor
Changes:
1. Use Window::SetBoundsInScreen and Window::SetBounds instead of
Widget::SetBounds which smartly show the widget only in the display
where it has the largest intersection.
2. Unify all points and rectangles in drag to using screen coordinates
to avoid weird movement in extended monitor.
3. Reset the initial drag point only when we are not in drag.
BUG=752166
[email protected]
(cherry picked from commit c9b5364ee619ec0aa24c7dbc087652c331b09769)
Change-Id: Ic42107991ec3007a640f851396f6a68fcbf142c3
Reviewed-on: https://chromium-review.googlesource.com/610889
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493925}
Reviewed-on: https://chromium-review.googlesource.com/618400
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#622}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}app_list: make apps search results the second most relevant results
changes:
answer card should always occupy the first row of results. Otherwise,
apps should then always occupy the first row of results.
[email protected]
(cherry picked from commit 8947f261c5e98a2b131650233d72e4946f0f7d31)
Test: test with fullscreen app list flag.
Bug: 750690
Change-Id: I3c0b54cd58084029a7e8ce8772f2462f929b4112
Reviewed-on: https://chromium-review.googlesource.com/609026
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Vadim Tryshev <[email protected]>
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493909}
Reviewed-on: https://chromium-review.googlesource.com/617992
Cr-Commit-Position: refs/branch-heads/3163@{#621}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}app_list: apps grid view non-clickable area
changes:
When app list is fullscreen all apps state, do not make tap or click
close app list.
Test: test with fullscreen app list flag
app_list_unittests --gtest_filter=
AppListViewFullscreenTest, TapAndClickWithinAppsGridView
[email protected]
(cherry picked from commit dc507215bb8ac7af48ba858e434c76f971c9f9e8)
Bug: 752229
Change-Id: I09890c9bcd2e31307a1d587d8019b5013983b22d
Reviewed-on: https://chromium-review.googlesource.com/608855
Commit-Queue: Qiang(Joe) Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493861}
Reviewed-on: https://chromium-review.googlesource.com/618275
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#620}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Relayout app list items during dragging.
Changes:
1. Add GetPageBoundsDuringDragging in AppListPage to get the page bounds during dragging.
Only fullscreen page can be dragged currently.
2. Update the rules for laying the search box and fullscreen page during dragging.
First step from collapsed to peeking, second step from peeking to fullscreen.
3. Update the rules for updating the opacity of items in app list during dragging.
First step from collapsed to peeking, second step from peeking to fullscreen.
UX specs and
Video recorded:
Please take a look of the crbug file.
[email protected]
(cherry picked from commit 3046f71f9932899a055760751c7224ab2d3bbf5b)
Bug: 740799, 754066
Change-Id: I26e2fa02dc77ae59afe060ecaf76e73968d9090d
Reviewed-on: https://chromium-review.googlesource.com/601215
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: min c <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493828}
Reviewed-on: https://chromium-review.googlesource.com/618274
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#619}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}cros:Peeking Launcher:webstore search
Enable webstore search only when arc is not enabled on the device.
[email protected]
(cherry picked from commit 8a32759c578e9235a916f8830cbc08e440388f93)
Bug: 750666
Change-Id: Ib32c99a56b4f7ca6aee2f5e801d0f38aba9aa75d
Reviewed-on: https://chromium-review.googlesource.com/600527
Reviewed-by: Elijah Taylor <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493077}
Reviewed-on: https://chromium-review.googlesource.com/618170
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#618}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.52
[email protected]
Change-Id: I3714267ffe9e5fc6814a62d0c354c1cea46bce48
Reviewed-on: https://chromium-review.googlesource.com/617772
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#617}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}gpu: Fix self-deadlock in vaapi_wrapper.
DestroySurfaces called inside the error path of CreateSurfaces
locked the same mutex twice. Avoid it by splitting out the body
of DestroySurfaces to DestroySurfaces_Locked.
BUG=b:64036511
TEST=CtsSecurityTestCases
[email protected]
(cherry picked from commit 53d086213c86b9bf83dc5e1786d47e1ec8a4c5de)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I667b78b528a0fad83ec422c730cf46889aa4119b
Reviewed-on: https://chromium-review.googlesource.com/604975
Reviewed-by: Kuang-che Wu <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Kazuhiro Inaba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492789}
Reviewed-on: https://chromium-review.googlesource.com/618201
Reviewed-by: Kazuhiro Inaba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#616}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[CrOS Tether] Start a scan when viewing the Tether subpage.
Previously, Wi-Fi networks were the only scannable network type, so the
internet subpage would only kick off scans when the Wi-Fi subpage was
visible. Now that tether networks can also be found via a scan, we
should request a scan when we open that page.
[email protected]
(cherry picked from commit bbb968870e812ad73c3df9c9302ffb99edb19b1a)
Bug: 754504, 672263
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I84e4b294efd7c404353fe0ea8f5edf2b12bcf90b
Reviewed-on: https://chromium-review.googlesource.com/616244
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494680}
Reviewed-on: https://chromium-review.googlesource.com/618222
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#615}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix build by replacing lambda with Runnable definition.
BUG=738217
Change-Id: I638f9193035fe6784e346e749016d7f5e72a1329
Reviewed-on: https://chromium-review.googlesource.com/617816
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3112@{#733}
Cr-Original-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}(cherry picked from commit 85602dce106a3141c3db034f7a8d0fb4b79f0af4)
Reviewed-on: https://chromium-review.googlesource.com/617983
Cr-Commit-Position: refs/branch-heads/3163@{#614}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}ChromeOS OOBE: add illustration for the update screen.
[email protected]
(cherry picked from commit 20c6ee8c1141b0ad1c9739e11e8f2ba151004a11)
Bug: 709256
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4cbfbf2766b659885403857ff08d7b11d7df142d
Reviewed-on: https://chromium-review.googlesource.com/612742
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493958}
Reviewed-on: https://chromium-review.googlesource.com/617659
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#613}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}ChromeOS Gaia: show Enterprise Enrollment option for unenrolled device only.
We should show Enterprise Enrollment option for unenrolled device only.
[email protected]
(cherry picked from commit 755b8a3608e6126c19ce0003f41ef4d3f524e0a0)
Bug: 752395
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d7063379008aaf5073e20c7ff5dd88ce55d23c3
Reviewed-on: https://chromium-review.googlesource.com/602744
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493943}
Reviewed-on: https://chromium-review.googlesource.com/617658
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#612}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}ChromeOS Gaia screen: fix support for dialogShown/Hidden messages for GLIF MM.
Support for dialogShown/dialogHidden messages was aparently missing in GLIF MM
support on ChromeOS. This CL implements disabling Gaia screen controls
when dialog is shown.
[email protected]
(cherry picked from commit f0cabc438f627623dd131666ddc74e7a1a7bc4b4)
Bug: b/64684270, chromium:755416
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I46ba8b4e044c4d840d422c175b5ddb044e39e950
Reviewed-on: https://chromium-review.googlesource.com/615004
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494315}
Reviewed-on: https://chromium-review.googlesource.com/617908
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#611}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge to M61][CUPS] Do not re-configure a printer if only printer name is changed.
Instead, we only update its name.
[email protected]
(cherry picked from commit 8b4f288e52ac25410c6c0b402ecb156933ddf95b)
Bug: 754561
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I731985c47844a2a4d68d3b245241443226a3b9c3
Reviewed-on: https://chromium-review.googlesource.com/614065
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494249}
Reviewed-on: https://chromium-review.googlesource.com/618101
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#610}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[ios] Fix blank snapshots after killing application.
The destruction of tabs should differentiate between user initiated
destruction vs. teardown due to shutdown of the app. When a user
initiates closing a tab, saved snapshots should be cleaned up.
However, when the application is shutdown, the teardown of the tab
should not delete the snapshot file.
This CL adds an -isShuttingDown flag to ApplicationContext. The flag
is set during shutdown in MainController. The flag is used inside
Tab's shutdown method to differentiate the two code paths.
[email protected]
(cherry picked from commit d66e03684dd1050562a3b2689f4c75d5e4c0e2e8)
Bug: 737114
Change-Id: Ic06e0a8ccee17b242af83e4f391fae386c064a2b
Reviewed-on: https://chromium-review.googlesource.com/597407
Commit-Queue: Ed Chin <[email protected]>
Reviewed-by: Rohit Rao (ping after 24h) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492406}
Reviewed-on: https://chromium-review.googlesource.com/617414
Reviewed-by: edchin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#609}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix ToSAckedReceiver after AccountManager refactoring.
All the necessary dependencies were not initialized when interacting
with the ToSAckedReceiver, which caused crashes during startup.
BUG=752145
Change-Id: I6f0c92dcaa0ddec8b55adf634143f3aa6a6d999e
Reviewed-on: https://chromium-review.googlesource.com/616113
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494609}
Reviewed-on: https://chromium-review.googlesource.com/617466
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#608}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Android] Add the ability to disable the filtering of custom search engines.
The filtering in the TemplateUrlServiceAndroid causes problems when you
expect the same model in template_url_service.cc to be reflected.
Addresses another issue where GetLocalPrepopulatedEngines returned an
empty list if it matched the current locale, but that causes issue if
kSearchProviderOverrides was not empty and overrode the default list.
Thus we would be in a state where we were not able to add the missing
search engines if needed.
[email protected]
BUG=738217
Change-Id: I0facc895bfbf56281754fc414547527b5cc1eb6a
Reviewed-on: https://chromium-review.googlesource.com/617603
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#494928}(cherry picked from commit a2e926a9ad0ff733ed9bf6d72f1421bfdd363922)
Reviewed-on: https://chromium-review.googlesource.com/617616
Cr-Original-Commit-Position: refs/branch-heads/3112@{#731}
Cr-Original-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}(cherry picked from commit 80a8fd97194a2d08d008cbef3a0344d6581a4393)
Reviewed-on: https://chromium-review.googlesource.com/617617
Cr-Commit-Position: refs/branch-heads/3163@{#607}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix race in BrowserAssociatedInterface setup
It's possible for BrowserAssociatedInterface's InternalState to have
Initialize invoked after ClearBindings, which can in turn lead to a
violation of the assumption that ClearBindings ensures no future message
dispatches to the bound implementation. This can occur in the following
rare but plausible scenario for a type X which inherits
BrowserAssociatedInterface<T>:
1. Post task to IO thread which may destroy some yet-uncreated
instance x of type X (e.g. maybe it posts a render process ID
and we'll later have an X associated with that RPH)
2. Create x as an instance of type X (posts an IO thread task to
Initialize x's Internal State)
3. Interface request is received, posting an IO thread task to bind a
handle to x.
3. Task from #1 executes, locating and deleting x; resetting
InternalState bindings (not yet initialized anyway).
4. Task from #2 executes, initializing the InternalState bindings.
5. Task from #3 executes, bindings a handle to the InternalState
6. Message is received on the bound handle, dispatched to deleted x
7. UAF!
As it turns out, AssociatedBindingSet does not own any thread-affine
state upon default construction; therefore it can be created on any
thread as long as it's subsequently used and destroyed from a single
thread. Since InternalState already guarantees those conditions, this
CL simply removes the async Initialize step.
BUG=753672
[email protected]
[email protected]
(cherry picked from commit 201a233484400329b3252979cbbabdb191cf9dbe)
Change-Id: Id603fb57d412daf3741b61f7857a29edeaac5443
Reviewed-on: https://chromium-review.googlesource.com/610924
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493797}
Reviewed-on: https://chromium-review.googlesource.com/617516
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#606}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Hide chromeos window resize shadow when window hides unexpectedly.
e.g. via shortcut
[email protected]
(cherry picked from commit bf51c7814db586dd69fafa2e738d995b11f573bb)
Bug: 752583
Change-Id: If9ef937ba331c8d937190478da1dd26b9bda656b
Reviewed-on: https://chromium-review.googlesource.com/616024
Commit-Queue: Evan Stade <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494663}
Reviewed-on: https://chromium-review.googlesource.com/617800
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#605}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Add Android re-use workaround to second ResourcePool entry point
Missed the second entry point on my previous CL: crrev.com/581576
[email protected]
[email protected]
(cherry picked from commit 2142c55356ac5299f841c5b72d6cc5419023f559)
Bug: 746931
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id793bc98e54c76da5fa2f0233c73223a105a1d52
Reviewed-on: https://chromium-review.googlesource.com/583783
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493039}
Reviewed-on: https://chromium-review.googlesource.com/617446
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#604}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disallow non-exact texture re-use on Android
Non-exact texture re-use seems to be causing visual corruption on
certain android devices. May be a GPU-specific issue, but disable
across all Android devices for now to be sure.
[email protected]
[email protected]
(cherry picked from commit 2856f2eda50f0b155bef62a429953ede3115fa29)
Bug: 746931
Change-Id: I7abbc0c98ee6fd06bffbf3409e214ae8dd12011e
Reviewed-on: https://chromium-review.googlesource.com/581576
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488901}
Reviewed-on: https://chromium-review.googlesource.com/617503
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#603}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61]Arc optin reskin.
Reskin surface of optin app to match oobe UX. No change of logic/behavior.
[email protected], [email protected]
Bug: 746569
Test: Manual.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic8bc1cd48ac93fe852ea94ed960ae1d5d9ca4834
Reviewed-on: https://chromium-review.googlesource.com/609583
Commit-Queue: Long Cheng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493581}(cherry picked from commit 6ee8845381273d61d73269ca0c4e4a23db2aebc2)
Reviewed-on: https://chromium-review.googlesource.com/617460
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#602}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[Merge M61] arc: Implement custom progress bar animation.
This CL substitutes paper progress animation to custom animation in
order to save CPU resources. More details can be found in document:
https://goto.google.com/kauce
[email protected], [email protected]
Bug: 746569
Bug: b/62540008
Test: Manually + perf testing as described in the document.
More than 2 seconds boost for Chekin time and more than
3 seconds boost for Play Store shown time on Minnie.
(cherry picked from commit 8f33cf78cb418199b52c6d35a80524788becccff)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic6bec6e3e5777563a7ebdf00b10564dfabac8b77
Reviewed-on: https://chromium-review.googlesource.com/590151
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492208}
Reviewed-on: https://chromium-review.googlesource.com/617374
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#601}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disabling context menu for Play Store search results.
Currently Play Store API doesn't return both install and launch intents,
so it doesn't make sense to have a context menu that opens the result
like what happens upon clicking it.
[email protected]
(cherry picked from commit e9f82013e2bb578efd050689f3442ad9f27e95cf)
Bug: 753603
Change-Id: I4659eaeb0b89709afaec9e3ec242b5ee8e1bd6e4
Reviewed-on: https://chromium-review.googlesource.com/616022
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Vadim Tryshev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494623}
Reviewed-on: https://chromium-review.googlesource.com/617368
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#600}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Enable metalayer when stylus button is pressed
This requires making MetalayerMode a pre-target
handler for touch events.
[email protected]
(cherry picked from commit 14a9239485bc59c92256202b0c7e7d6a89ab827b)
Bug: b:62543770
Change-Id: I86d143a4e5755e1ee7b7eacd4bef7becda5d3af6
Reviewed-on: https://chromium-review.googlesource.com/602784
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494210}
Reviewed-on: https://chromium-review.googlesource.com/617101
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#599}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Update default voice interaction locales
BUG=b/63098956
TEST=build locally
[email protected]
(cherry picked from commit 28c6a6bdfd5eca18b2799f145a36f5b8fdcc1062)
Change-Id: Ia55921c0b47c04f0989b5c9fb92c8a36197d2578
Reviewed-on: https://chromium-review.googlesource.com/614115
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494136}
Reviewed-on: https://chromium-review.googlesource.com/617042
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#598}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Revert "Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile"
This reverts commit b160073dd51148f56b6586a9902b8a24674886c4.
Reason for revert: We've decided to delay the removal of /deep/ from M61 to M63.
See https://bugs.chromium.org/p/chromium/issues/detail?id=489954#c99 for details.
Original change's description:
> Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile
>
> Reland the CL [1], which was reverted at [2], since CrOS's OOBE issue was fixed.
>
> - [1]: https://codereview.chromium.org/2778983006
> - [2]: https://codereview.chromium.org/2885153003
>
> Bug: 489954,723259
> Change-Id: Ie162502385443a4e9a9cc80444c596458ad1e100
> Reviewed-on: https://chromium-review.googlesource.com/575322
> Reviewed-by: Takayoshi Kochi <[email protected]>
> Commit-Queue: Hayato Ito <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#487745}
[email protected], [email protected]
(cherry picked from commit d5d015a62218436871593534dc5bb051aa14b2bc)
Bug: 489954, 723259
Change-Id: I1b58db5bc2f3268f16b832214b87f1d77ada38ee
Reviewed-on: https://chromium-review.googlesource.com/609602
Reviewed-by: Hayato Ito <[email protected]>
Reviewed-by: Takayoshi Kochi <[email protected]>
Commit-Queue: Hayato Ito <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493331}
Reviewed-on: https://chromium-review.googlesource.com/616502
Cr-Commit-Position: refs/branch-heads/3163@{#597}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}To M61: vp9_parser: handle invalid calls properly after failures
If Vp9Parser::ParseNextFrame returned error and the client continued to
call the parser, this may lead to out-of-bounds read. This issue only
affected the fuzzer.
BUG=741244
Change-Id: Ic60a5e21a85301af520753cecf2b725e66eddb6d
Reviewed-on: https://chromium-review.googlesource.com/566753
Commit-Queue: Kuang-che Wu <[email protected]>
Reviewed-by: Pawel Osciak <[email protected]>
Reviewed-by: Matthew Wolenetz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#491796}(cherry picked from commit c2849f197512852b95f46edd4c7ecd97d76c67ee)
Reviewed-on: https://chromium-review.googlesource.com/610740
Cr-Commit-Position: refs/branch-heads/3163@{#596}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Disabling context menu temporary on ARC notification
This patch disables context menu on ARC notification as a temporary fix
until the UX is finalized. ARC notification has own settings panel, so
showing context menu in addition to the setting panel is wrong.
[email protected]
(cherry picked from commit cb4f4d8506f5563876af654cb8d3fe3818093166)
Bug: 750307
Bug: b/64323659
Change-Id: Ia59103365ac430163bfecacd91259c4cf21f6449
Reviewed-on: https://chromium-review.googlesource.com/607728
Commit-Queue: Yoshiki Iguchi <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#492851}
Reviewed-on: https://chromium-review.googlesource.com/615982
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#595}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Update the extension list to watch for Android N.
Raw images and QuickTime images are added.
[email protected]
(cherry picked from commit fc55a9d866626a697c16375a9b2084e309f85a51)
Bug: 753524
Test: unit_tests
Test: Downloaded .nef image is shown in Media View
Change-Id: Ifc9b0f5a4fe8ff5280e26a3b565010815ce403e6
Reviewed-on: https://chromium-review.googlesource.com/615216
Commit-Queue: Shuhei Takahashi <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494356}
Reviewed-on: https://chromium-review.googlesource.com/616400
Reviewed-by: Shuhei Takahashi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#594}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Fix issues with isolated origins incorrectly reusing webview processes (Merge to M61)
Subframes with isolated origins use the
REUSE_PENDING_OR_COMMITTED_SITE process reuse policy, which allows
unrelated subframes from the same isolated origin to reuse the same
dedicated process. Unfortunately, the reuse logic allowed this to
happen even if the isolated origin previously committed in a process
with a different StoragePartition, which can happen with isolated
origins in a <webview>. This meant that isolated origin subframes
from regular tabs might've gotten committed into a <webview> process.
This resulted in renderer kills on the transfer path without
PlzNavigate. With PlzNavigate, which does not have transfers, the
problem manifested itself later, for example with a renderer kill when
trying to access cookies in the <webview>, since we also (incorrectly)
applied the isolate origin's origin lock to the <webview> process.
This CL fixes the problem by restricting the site/process tracker used
for REUSE_PENDING_OR_COMMITTED_SITE to only the default
StoragePartitions. Ultimately, this logic might need to be refactored
to track site-to-process mappings per-StoragePartition, given that
this logic was added to address process reuse issues for
ServiceWorkers, and that ServiceWorkers seem to be possible in
non-default StoragePartitions. This followup will be tracked in issue
752667.
Note also that for the time being, isolated origins frames inside
<webview> cannot use a dedicated process until issue 614463 is fixed.
[email protected]
(cherry picked from commit 3acd75fb3acbaed51b02c5c88e6e54ac1a628a87)
Bug: 751916,751920
Change-Id: Ib494994640ce699bef202df6947f0915fa4c7b0c
Reviewed-on: https://chromium-review.googlesource.com/602707
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493802}
Reviewed-on: https://chromium-review.googlesource.com/616361
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#593}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.51
[email protected]
Change-Id: I951a4ce8eded9b535a771215b4690b84133c4c07
Reviewed-on: https://chromium-review.googlesource.com/616266
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#592}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Reduce flickering of answer cards.
Currently, when the user sees the result, and then resumes typing the
query, we remove the result until the new result becomes available.
We want to get rid of this, and keep the old result until the new one
becomes available. For this, we create another WebContents for loading
the new result, while keeping the current one shown. Once the loading is
complete, we swap WebContents.
Also, now that the server guarantees that the card can never be too
large, we also remove card size validation, which helps to reduce the
number of states, which otherwise would become hard to manage, with 2
WebContents. In particular, now we don’t have to postpone what was
RecordReceivedAnswerFinalResult(), since now we know the load result as
early as the navigation finishes, not after post-load resizes
potentially happen.
Also removing AnswerCardContents::IsLoading() to make unit tests less
error - prone.
[email protected]
(cherry picked from commit 17cc0eea9c2adfdb5eccec0d177760d88da61383)
Bug: 712331
Change-Id: Ic2764c3951cae1838f98bc8ed2444cc22d4c253b
Reviewed-on: https://chromium-review.googlesource.com/614693
Commit-Queue: Vadim Tryshev <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494460}
Reviewed-on: https://chromium-review.googlesource.com/616264
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#591}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}m61 merge: Draw into render pass when caching the render pass.
m61 merge on behalf of wutao@
When we force caching render pass, we need to add it to the frame render
pass list, otherwise a contributing layer/surface can not find the
target_render_surface in the render pass list.
(cherry picked from commit f69c007458e5eb0e3c541674c781881c33b8540c)
TBR: [email protected]
Bug: 753135
Test: SetCacheRenderSurface in AnimateShowWindowCommon.
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I147cdcfca9a1a84880c48b63d718efb0ac04d94c
Reviewed-on: https://chromium-review.googlesource.com/615184
Reviewed-by: David Reveman <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494562}
Reviewed-on: https://chromium-review.googlesource.com/616203
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#590}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Incrementing VERSION to 61.0.3163.50
[email protected]
Change-Id: Id3b1e15fe6b5784729ce42d71a731976f5aa8b8b
Reviewed-on: https://chromium-review.googlesource.com/616089
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#589}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Updating XTBs based on .GRDs from branch 3163
[email protected]
Change-Id: Ia1fcc779b60626590fe90663f947e1484d448e59
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia1fcc779b60626590fe90663f947e1484d448e59
Reviewed-on: https://chromium-review.googlesource.com/616118
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#588}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[WebView autofill] Reset provider after form committed
Reset provider after form committed, so status won't be remembered
once WebView is reused.
BUG=755410
[email protected]
(cherry picked from commit 70dda9c808604ac609d8e4d8ecfb31549be8da5a)
Change-Id: I4f75d9e71d7b76bea877d048bc52a1c7475fda8a
Reviewed-on: https://chromium-review.googlesource.com/615006
Reviewed-by: Roger McFarlane <[email protected]>
Commit-Queue: Tao Bai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494484}
Reviewed-on: https://chromium-review.googlesource.com/616111
Reviewed-by: Tao Bai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#587}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Check the validity of selection range for SmartText selection
It is possible that by the time the surrounding text request reaches
the Renderer the selection range becomes empty (e.g. we have an input
caret). The empty selection range is a valid situation for surrounding
text algorithm which returns a text around the input caret, but
invalid for Android TextClassifier.
This CL checks the indices of the selection in the surrounding
text responce from Blink and treats an empty or invalid range
the same way as an empty text, i.e. bypasses classification.
BUG=751397
[email protected]
(cherry picked from commit 48b8ef3c6d0addb97d0efe9d7f1a4d93f7cb0aee)
Change-Id: I3646a16d701e04627e4729f5226850d2b83993b5
Reviewed-on: https://chromium-review.googlesource.com/601256
Commit-Queue: Tima Vaisburd <[email protected]>
Reviewed-by: Bo <[email protected]>
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493201}
Reviewed-on: https://chromium-review.googlesource.com/615748
Reviewed-by: Tima Vaisburd <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#586}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}ash: Move handling of root window transforms from compositor to fast ink.
For fast ink it's preferred to handle all transforms as part of
fast ink drawing as this increses the configurations for which
we can take advantage of HW overlays.
This allows the fastink code to use HW overlays and low-latency
rendering for all resolutions and all rotations.
BUG=754937
TEST=manually verified that laser pointer and highlighter get
low-latency rendering independent of screen resolution and
rotation.
[email protected]
(cherry picked from commit 8f80e302cddbd5e7b078039f7c9e156487bc5d4d)
Change-Id: Ifd451d80407c5ac6f39bb7705b7ca0512a9d4768
Reviewed-on: https://chromium-review.googlesource.com/611675
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494508}
Reviewed-on: https://chromium-review.googlesource.com/616013
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#585}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}IPH : Fixed the horizontal misalignment of text bubble on long text
For texts that span multi-line, somehow the bubble is misaligned
horizontally. This is probably happening due to WRAP_CONTENT being
set for the popup and the text view. This CL fixes the issue by
calling an update() with proper width.
[email protected]
(cherry picked from commit edb2f348f3abf7021492bbfd44299cbe613c821e)
Bug: 753375
Change-Id: I9e65f26f62dd3ca4bdb9155d69f9546666964ad4
Reviewed-on: https://chromium-review.googlesource.com/606668
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493298}
Reviewed-on: https://chromium-review.googlesource.com/616020
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#584}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Adjust padding for login header bar
[email protected]
(cherry picked from commit d2e208d4142087c53818440694a976c88d2293ce)
Bug: 755281
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I93e7889b2ad227c80a61e225d2c7eb375832d7df
Reviewed-on: https://chromium-review.googlesource.com/614908
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494340}
Reviewed-on: https://chromium-review.googlesource.com/615819
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#583}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}IPH : Talkback often skips text bubbles
This CL attempts to fix this issue by using announceForAccessibility
on a task.
[email protected]
(cherry picked from commit 863956a504507d526e85ed04410aeb0ca6a3b02c)
Bug: 706059
Change-Id: Ie3c4e719b20681c3e387e2afa7918775d1e72454
Reviewed-on: https://chromium-review.googlesource.com/606672
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493306}
Reviewed-on: https://chromium-review.googlesource.com/616009
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#582}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Inject a dummy value in the place where corruption is occurring.
Crash reports indicate that a core trampler is overwriting
Histogram objects at a specific offset. Adding a dummy field
in that location will hopefully mitigate the impact of that
and allow the release train to continue while investigation
into the true cause continues.
[email protected]
(cherry picked from commit 2febfd2f172cd4a19bd3d5c0d39315548894a5cb)
Bug: 736675
Change-Id: I2f0e549bca03c23faffae4cf5c34b176bcecfb7e
Reviewed-on: https://chromium-review.googlesource.com/610883
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Alexei Svitkine (very slow) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#493678}
Reviewed-on: https://chromium-review.googlesource.com/615814
Reviewed-by: Brian White <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#581}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}Remove the hack not to send activation from chrome.
This will be handled in Android side:
https://googleplex-android-review.git.corp.google.com/#/c/platform/frameworks/base/+/2695363/
BUG=b:62043263
BUS=b:62156169
[email protected]
TEST=Manual. Apply the above patch on Android side and follow repro step in b/62156169.
(cherry picked from commit a5af94b3cbe5fba12180c63e0a6ce8667bab8900)
Reviewed-on: https://chromium-review.googlesource.com/611541
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494325}
Change-Id: If36dfa96f76800a9f80ad8be1732cbdee275a3c6
Reviewed-on: https://chromium-review.googlesource.com/615809
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#580}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}[TTS] Fix index out of bounds adjusting selection.
Improves a previous fix checking bounds on a substring call in
ContextualSearchContext to also check that the start index
is not negative.
BUG=725027
[email protected]
(cherry picked from commit 873f4b0b65b26ab43c38435dc577241a385fa81c)
Change-Id: I053ead6e8a4cc3e9a04ace0b7ab67c209c6ce2fb
Reviewed-on: https://chromium-review.googlesource.com/614914
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#494288}
Reviewed-on: https://chromium-review.googlesource.com/615806
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#579}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
