Publish DEPS for Chromium 61.0.3163.20

• DEPS[diff]

Incrementing VERSION to 61.0.3163.20

[email protected]

Change-Id: I1075da2f46d664893f1d0d601d0097c0c25baf7f
Reviewed-on: https://chromium-review.googlesource.com/593129
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#137}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]

Make downloads work when history database fails to initialize.

Previously all download calls will be stuck when history database fails
to initialize.

This CL assigns 1 as the first id when history database failed to load,
all downloads in this browser session will not be persisted to history
database.

[email protected]

(cherry picked from commit d1bc5d0b5f6336fe076466ee42644b2e8fef4bc6)

Bug: 736511
Change-Id: If4db04ca518633a7dd999f45629e60e97fc78b1a
Reviewed-on: https://chromium-review.googlesource.com/587327
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490540}
Reviewed-on: https://chromium-review.googlesource.com/593048
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#136}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/download/chrome_download_manager_delegate.cc[diff]
• chrome/browser/download/chrome_download_manager_delegate.h[diff]
• chrome/browser/download/chrome_download_manager_delegate_unittest.cc[diff]
• chrome/browser/download/download_stats.cc[diff]
• chrome/browser/download/download_stats.h[diff]
• tools/metrics/histograms/histograms.xml[diff]

Incrementing VERSION to 61.0.3163.19

[email protected]

Change-Id: Ic1c35d6f9d8c48c7fecbeb00edc7230137e69585
Reviewed-on: https://chromium-review.googlesource.com/593152
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#135}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]

Add null check in IsCompositionTooLong

BUG=747236

(cherry picked from commit 5d1a2c23711e20e9ef5b042dabd778004b33cd71)

Change-Id: I10ae4407f4143dda6072edb6f152bdc4f65845b7
Reviewed-on: https://chromium-review.googlesource.com/581867
Commit-Queue: Changwan Ryu <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490080}
Reviewed-on: https://chromium-review.googlesource.com/592645
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#134}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/Source/core/editing/InputMethodController.cpp[diff]

Incrementing VERSION to 61.0.3163.18

[email protected]

Change-Id: I3f19fa676e43c171a26f014a2735c319efcf2f06
Reviewed-on: https://chromium-review.googlesource.com/592748
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#133}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]

Clicking an active apps icon from the shelf

Click an active app's icon while the launcher is active should close the
launcher.

Fixes the behavior where a shown app is closed if the app icon is
selected while the launcher is being shown.

[email protected]

(cherry picked from commit 6e62a5c1da215f15c6a30612e44cce75fb977f26)

Bug: 748160
Change-Id: I926d57bc9d040b412a07c761abaa927aab4b516d
Reviewed-on: https://chromium-review.googlesource.com/583641
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489475}
Reviewed-on: https://chromium-review.googlesource.com/592712
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#132}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc[diff]

Add tests for ArcPlayStoreAppSearchProvider.

Bug=736552

[email protected]

(cherry picked from commit cc2fbf55db543c262459dd9ae07bd7753f66e486)

Change-Id: I6a9da9ce619f302824ef63c447ebce6738de6cf0
Reviewed-on: https://chromium-review.googlesource.com/576291
Commit-Queue: Jiaquan He <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489211}
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/592526
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#131}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.h[diff]
• chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc[Added - diff]
• chrome/test/BUILD.gn[diff]
• components/arc/test/fake_app_instance.cc[diff]

Fix search box issue when expand arrow has focus

Changes:
1. Override OnKeyPressed function in ExpandArrowView to prevent SPACE
key being handled by parent view.
2. Avoid returning true for unhandled key event in
StartPageView::OnKeyPressed.

BUG=747146
[email protected]

(cherry picked from commit c93e801b7d165f2ea18697caa2dd2ffe74c94a30)

Change-Id: Ie3a195b133ba57040299deb1bbe542ed80462e1c
Reviewed-on: https://chromium-review.googlesource.com/582235
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489207}
Reviewed-on: https://chromium-review.googlesource.com/592707
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#130}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ui/app_list/views/expand_arrow_view.cc[diff]
• ui/app_list/views/expand_arrow_view.h[diff]
• ui/app_list/views/start_page_view.cc[diff]

Swiping up on shelf to show the app list.

If the app list is not opened and shelf is visible, swipe up on the shelf
should show the app list.
If the app list is opened, swipe up on the shelf should keep the app list
opened. Tap anywhere else of shelf should close the app list.

This is the basic one currently. Will add some simple animations followed.
(e.g, change the opacity of the searchbox and apps row by row according
to the dragging amount)

[email protected]

(cherry picked from commit d646ae0a014564fd9fb4e879e70837ea715a64e9)

Bug: 735999,742461
Change-Id: I5eb8b6d4d006a50720050b34168849e9d57370f2
Reviewed-on: https://chromium-review.googlesource.com/562739
Commit-Queue: min c <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488781}
Reviewed-on: https://chromium-review.googlesource.com/592692
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#129}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ash/app_list/app_list_presenter_delegate.cc[diff]
• ash/app_list/app_list_presenter_delegate_unittest.cc[diff]
• ash/shelf/shelf_layout_manager.cc[diff]
• ash/shelf/shelf_layout_manager.h[diff]
• ash/shelf/shelf_layout_manager_unittest.cc[diff]
• ash/shelf/shelf_view.cc[diff]
• ash/shell.cc[diff]
• ash/shell.h[diff]
• ash/shell/example_app_list_presenter.cc[diff]
• ash/shell/example_app_list_presenter.h[diff]
• ash/system/status_area_widget_delegate.cc[diff]
• ash/system/tray_drag_controller.cc[diff]
• chrome/browser/ui/ash/app_list/app_list_presenter_service.cc[diff]
• chrome/browser/ui/ash/app_list/app_list_presenter_service.h[diff]
• ui/app_list/presenter/app_list.cc[diff]
• ui/app_list/presenter/app_list.h[diff]
• ui/app_list/presenter/app_list_presenter.mojom[diff]
• ui/app_list/presenter/app_list_presenter_impl.cc[diff]
• ui/app_list/presenter/app_list_presenter_impl.h[diff]
• ui/app_list/presenter/test/test_app_list_presenter.cc[diff]
• ui/app_list/presenter/test/test_app_list_presenter.h[diff]
• ui/app_list/views/app_list_view.cc[diff]
• ui/app_list/views/app_list_view.h[diff]

Update start page view tab key focus

Changes:
1. Change the focus behavior triggered by tab key in start page view.
Focus should move cyclically like this: search box text field ->
suggestion apps -> expand arrow view -> search box text field.
2. Add unit test for this behavior.

BUG=741015
TEST=AppListViewFullscreenTest.StartPageTabFocusTest
[email protected]

(cherry picked from commit a4bb0a79d97dea6cd74e5c5272781aa9fd9300d9)

Change-Id: I7467d94b4028ef24422f8236e615f66b195d1f84
Reviewed-on: https://chromium-review.googlesource.com/580498
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488780}
Reviewed-on: https://chromium-review.googlesource.com/592687
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#128}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ui/app_list/views/app_list_view_unittest.cc[diff]
• ui/app_list/views/contents_view.cc[diff]
• ui/app_list/views/search_box_view.cc[diff]
• ui/app_list/views/search_box_view.h[diff]
• ui/app_list/views/start_page_view.cc[diff]
• ui/app_list/views/start_page_view.h[diff]

Fixing a compile error on M60 branch due to missing forward declaration

This CL fixes the broken build introduced in
https://chromium-review.googlesource.com/c/592413.

[email protected],[email protected]

Bug: 739199
Change-Id: Ida864688c5bcc254614d169bb03a88a58549c651
Reviewed-on: https://chromium-review.googlesource.com/592525
Reviewed-by: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#127}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/Source/web/ChromeClientImpl.h[diff]

Ignore voice queries for Play Store app search.

Voice queries just simply close the launcher. We don't need
voice queries for Play Store app search.

Bug=736027

[email protected]

(cherry picked from commit 33b08669fce281ca4bb360c64e7558bd0143fda3)

Change-Id: Ic34c45ad105c20598b6fc4bcb345883f55ccc012
Reviewed-on: https://chromium-review.googlesource.com/579958
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Jiaquan He <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488697}
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/592388
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#126}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider.cc[diff]

Incrementing VERSION to 61.0.3163.17

[email protected]

Change-Id: Ibc6e620730ba068a47bf50f94be58177894a6340
Reviewed-on: https://chromium-review.googlesource.com/592521
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#125}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]

[Merge to M61][Night Light] Flip the Night Light flag to make it disabled by default

Make Night Light disabled by default until rendering performance issues
are improved.

[email protected], [email protected]
BUG=749717

(cherry picked from commit 2fd8fc80c6f592dfa966406153120d582d3c8698)

Change-Id: I613a8e69709380629bb4491e00be589a63629679
Reviewed-on: https://chromium-review.googlesource.com/590952
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490424}
Reviewed-on: https://chromium-review.googlesource.com/592517
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#124}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ash/ash_switches.cc[diff]
• ash/ash_switches.h[diff]
• ash/system/night_light/night_light_controller.cc[diff]
• ash/system/night_light/night_light_controller_unittest.cc[diff]
• ash/system/night_light/tray_night_light_unittest.cc[diff]
• ash/system/tiles/tray_tiles_unittest.cc[diff]
• chrome/browser/about_flags.cc[diff]
• chrome/browser/chromeos/chrome_browser_main_chromeos.cc[diff]
• chrome/browser/flag_descriptions.cc[diff]
• chrome/browser/flag_descriptions.h[diff]

[merge to m61] Do not allow partial swap for pixel-moving background filter.

merge to m61 on behalf of wutao@

Partial swap does not handle the case with pixel-moving backgroud
filter. When expandng the damage rect, we fill the backbuffer in the
filter margins outside the damage rect with unblurred pixels. We need
those in order to produce correct edges in the interior border of the
damage rect. But we also need the blurred and blended versions of those
pixels we had in the previous frame, which we've just clobbered. The
backbuffer can't contain both blurred and unblurred pixels in a given
region, so we can't satisfy both requests.

Effectively disabling partial swap for layers containing pixel-moving
background filters by marking the whole output_rect as damage would fix
the correctness.

(cherry picked from commit 3af153f48e439140eeeed51e800a4526364a7688)

TBR: [email protected], [email protected]
Bug: 737255
Test: SurfaceAggregatorPartialSwapTest.IgnoreOutside && intel devices.
Change-Id: Ib1431c4e1912636c5ac4a7babf296b58b50177c0
Reviewed-on: https://chromium-review.googlesource.com/584307
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: John Bauman <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489451}
Reviewed-on: https://chromium-review.googlesource.com/592511
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#123}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/viz/service/display/surface_aggregator.cc[diff]
• components/viz/service/display/surface_aggregator_unittest.cc[diff]

[Merge to M61] GTK: Ensure UPPER_SEPARATORs get drawn when using a fractional scale

> This CL is a Linux port of the equivalent hack for Windows [1].
>
> [1] https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_separator.cc?rcl=d1853b975434d1b31a2143fa3a25af48fafda7a0&l=41
>
> BUG=748473
> [email protected]
>
> Change-Id: I838cb00a147fe9b63dd1a36e1e485fa8f5e0c4a4
> Reviewed-on: https://chromium-review.googlesource.com/585229
> Reviewed-by: Evan Stade <[email protected]>
> Commit-Queue: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#490027}

BUG=748473
[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I5520833e102f1e42ae509e3b8c5cc8f8b4bbc12a
Reviewed-on: https://chromium-review.googlesource.com/592084
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#122}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/libgtkui/native_theme_gtk3.cc[diff]

Re-skin of ARC opt in flow string.

Update Notification with string update.

Design is as follows:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZbc2uHrzBMcI/files/MCHtA7U1iMGr646KyMd0WbEyB66fk5La4OU

[email protected]

Bug: 746569
Test: Manual
Change-Id: I43436a3a773cd379b7d79e1af4738a0b67b0014a
Reviewed-on: https://chromium-review.googlesource.com/591830
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#121}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/chromeos_strings.grdp[diff]
• chrome/browser/chromeos/arc/arc_auth_notification.cc[diff]

[merge to m61] CrOS: Use foreground blur for lock screen.

merge to m61 on behalf of wutao@

Using foreground blur make it possible to cache the render surface and
provide good performance.

(cherry picked from commit 11c9d1dcb9e338be177fd46e10b15ea958bf000a)

TBR: [email protected], [email protected]
Bug: 738185
Test: tested locally.
Change-Id: I838c072ecd4deeb9e181e08644d215877616f0ef
Reviewed-on: https://chromium-review.googlesource.com/578713
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488618}
Reviewed-on: https://chromium-review.googlesource.com/592424
Reviewed-by: Qiang(Joe) Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#120}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ash/login/ui/lock_screen.cc[diff]
• ash/login/ui/lock_screen.h[diff]
• ui/compositor/layer.cc[diff]
• ui/compositor/layer.h[diff]

Update Welcome App texts and remove $1 placeholder

A reland of 584859 after updating first_run_ui.cc

[email protected]

(cherry picked from commit 2651d426c8c8fd0b85d9c7a8a85883b0579daf5d)

Bug: 748698, 749024
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic62094e0965d534c8b528e5801182d7febe7ad7d
Reviewed-on: https://chromium-review.googlesource.com/587289
Reviewed-by: Jay Civelli <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489885}
Reviewed-on: https://chromium-review.googlesource.com/592423
Cr-Commit-Position: refs/branch-heads/3163@{#119}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/chromeos_strings.grdp[diff]
• chrome/browser/resources/chromeos/first_run/help_step.html[diff]
• chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc[diff]

Fix "send feedback" screenshots for native pages and crashes.

Any Android drawn UI is not included in normal screenshots, so this
makes that conditional on the state of the activity to ensure we are
not showing primiarly Android UI content.

BUG=734608
[email protected]

(cherry picked from commit bea0b2ecb2f98d4bc9c880444dbc1b51f1c615ef)

Change-Id: I34c23d0790c430d6a0cebc30afaae429066bd5a7
Reviewed-on: https://chromium-review.googlesource.com/587232
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489733}
Reviewed-on: https://chromium-review.googlesource.com/592278
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#118}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/android/java/src/org/chromium/chrome/browser/feedback/ScreenshotTask.java[diff]

Revert "Re-skin of ARC++ opt in flow"

This reverts commit 824999c4a16a00a3ccf29d2720dbf95ad9d84c95.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Re-skin of ARC++ opt in flow
> 
> (cherry picked from commit 8698483d65e18e24b0e08ca4cfc6eb1a69d9afb3)
> [email protected]
> 
> Bug: 746569
> Change-Id: I043422ca209c2f73a91c95166953732f7c6d4600
> Reviewed-on: https://chromium-review.googlesource.com/592341
> Reviewed-by: Long Cheng <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3163@{#113}
> Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

[email protected],[email protected]

Change-Id: I1414ed5abd0e1f153e38508aa7952e08dc4e6fe3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 746569
Reviewed-on: https://chromium-review.googlesource.com/591952
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#117}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/chromeos_strings.grdp[diff]

Fix a crash due to GetDocument().GetFrame() returning nullptr

In ChromeClientImpl::OnMouseDown the node passed might have a document
whose frame is nullptr. This was causing crashes when trying to get the
AutofillClient from WebLocalFrame associated with the GetFrame().

The new method ChromeClientImpl::AutofillClientFromFrame will now take
a nullable frame and returns the AutofillClient corresponding to the
associated WebLocalFrame.

[email protected]
(cherry picked from commit
94db0a33758ba48ae3c6da75b58b2ba480ac9bcf)

Bug: 739199
Change-Id: Ib9ddc4bba86504c1ad02fd43c4c2f19368d53e9d
Reviewed-on: 
https: //chromium-review.googlesource.com/580294
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Ehsan Karamad <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489045}
Reviewed-on: https://chromium-review.googlesource.com/592413
Reviewed-by: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#116}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/Source/web/ChromeClientImpl.cpp[diff]
• third_party/WebKit/Source/web/ChromeClientImpl.h[diff]

[Merge to M61][CUPS] Add strings for Edit-Printer-Dialog first.

Since the cut data to merge strings is 7/28, add strings that are used in
https://chromium-review.googlesource.com/c/582271/ first to catch the
string merge deadline.

[email protected]
(cherry picked from commit 4593cc4454079163607dd12e0453f2f6f4aeacfb)

Bug: 685673
Change-Id: I8a8d0be9c56dc0780a5f47b861d0360a702c631f
Reviewed-on: https://chromium-review.googlesource.com/590307
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490422}
Reviewed-on: https://chromium-review.googlesource.com/592448
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#115}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/settings_strings.grdp[diff]
• chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc[diff]

DevTools: [Audits] Roll Lighthouse 2.3.0 w/ dense report

Also fixing: solid white background, scrolling restored,
removing unneeded call to `Input.setIgnoreInputEvents` and
'Run audit' button has autofocus.

Rolled LH commit: 924e1f11bd6b31f3a105185a8d667143770f3c65

[email protected]

(cherry picked from commit f2afd2acd7372a385ce3fa81b0dcc49064c93abe)

Bug: 663085, 723966, 747231
Change-Id: Id8f9c34a80fc0d251c07b9633fcd83a81cadc95c
Reviewed-on: https://chromium-review.googlesource.com/580500
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489099}
Reviewed-on: https://chromium-review.googlesource.com/592402
Reviewed-by: Paul Irish <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#114}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/util.js[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css[diff]
• third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/templates.html[diff]
• third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js[diff]

Re-skin of ARC++ opt in flow

(cherry picked from commit 8698483d65e18e24b0e08ca4cfc6eb1a69d9afb3)
[email protected]

Bug: 746569
Change-Id: I043422ca209c2f73a91c95166953732f7c6d4600
Reviewed-on: https://chromium-review.googlesource.com/592341
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#113}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/chromeos_strings.grdp[diff]

Add strings for voice interaction OOBE error screen

Add strings for voice interaction OOBE error screen, which will be shown
when the voice interaction is disabled either for the locale or the
account.

BUG=749900,747496
[email protected]

(cherry picked from commit 6b77de397205be39a04132ce7895b8e9121efd74)

Change-Id: Id31a27690af6974b3e23eeeaced617c295020293
Reviewed-on: https://chromium-review.googlesource.com/591635
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490493}
Reviewed-on: https://chromium-review.googlesource.com/591640
Cr-Commit-Position: refs/branch-heads/3163@{#112}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/chromeos_strings.grdp[diff]

[iOS] Adding underlying errors information when displaying an error

Error with description and one underlying error:
https://drive.google.com/open?id=0ByXziH_JVCGJZkZzS2s2VEx2Z28

Error without description and with one underlying error:
https://drive.google.com/open?id=0ByXziH_JVCGJdENIVUdxMEZjbDA

Error without description and without underlying error:
https://drive.google.com/open?id=0ByXziH_JVCGJZlZIZzBOYnl2dWs

[email protected]

(cherry picked from commit 78f86382084b7dd9ecd922e000a4b4d44d10af69)

Bug: 749699
Change-Id: I6ec36d328b405d7a69835c9a45744c4519c336dc
Reviewed-on: https://chromium-review.googlesource.com/589967
Reviewed-by: Benoit Zanotti <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490360}
Reviewed-on: https://chromium-review.googlesource.com/592031
Cr-Commit-Position: refs/branch-heads/3163@{#111}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ios/chrome/browser/ui/authentication/BUILD.gn[diff]
• ios/chrome/browser/ui/authentication/authentication_ui_util.h[diff]
• ios/chrome/browser/ui/authentication/authentication_ui_util.mm[diff]
• ios/chrome/browser/ui/authentication/authentication_ui_util_unittest.mm[Added - diff]

Ensure signing out deletes bookmarks only if full wipe is requested

Due to a bug in https://codereview.chromium.org/2966763003/, bookmarks
were being deleted when a non-managed user signed out, in which case
only Google service worker caches should have been deleted.

This CL fixes the problem and adds a unittest for bookmark deletion
in both cases.

Note that making bookmarks deletion testable required moving it into
ProfileDataRemover where the rest of the deletion occurs. However,
it happens on the same thread; and in any case, this is exactly the
part that is tested.

[email protected]

(cherry picked from commit d2fe8ebb71e77a5b05e3fe9c0ca8711fe4e51ab1)

Bug: 747155
Change-Id: I857e52cd4835d95e712e205c8c436adec73d1789
Reviewed-on: https://chromium-review.googlesource.com/581497
Commit-Queue: Martin Šrámek <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489343}
Reviewed-on: https://chromium-review.googlesource.com/591849
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#110}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/android/signin/signin_manager_android.cc[diff]
• chrome/browser/android/signin/signin_manager_android.h[diff]
• chrome/browser/android/signin/signin_manager_android_unittest.cc[diff]

[autofill] Log disused addresses count iff user actually has addresses.

autofill::PersonalDataManager::LogStoredProfileMetrics was always
logging the number of disused address profiles (i.e., addresses that
have not been use for at least 180 days) irrespective of whether or
not the user had any addresses to consider.

This dilutes the signal of this metric with 0 for all the user's that
don't actually have ANY addresses stored.

BUG=734151
[email protected]
[email protected]

(cherry picked from commit 9cb1b869e89119b630ff37d2a6a7588c49a5bace)

Change-Id: I55f04bb060e4cb6dbf40780d446b3973993d6c0d
Reviewed-on: https://chromium-review.googlesource.com/587338
Commit-Queue: Roger McFarlane <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489924}
Reviewed-on: https://chromium-review.googlesource.com/592268
Reviewed-by: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#109}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/autofill/core/browser/personal_data_manager.cc[diff]
• components/autofill/core/browser/personal_data_manager_unittest.cc[diff]

Add string for OK Google hotword deprecation

BUG=722141
[email protected]

(cherry picked from commit cb70129cf086ba88f7fd3ec4d4bd7437251ea4f1)

Change-Id: I72773c57a17a94c28bf9ae2eb4d0c596f4b8d9cf
Reviewed-on: https://chromium-review.googlesource.com/580701
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489023}
Reviewed-on: https://chromium-review.googlesource.com/592233
Cr-Commit-Position: refs/branch-heads/3163@{#108}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/settings_strings.grdp[diff]

Add Google Assistant settings to the settings UI

Does not currently launch an Intent when the "Google Assistant Settings" button
is tapped.  That'll be handled in a follow-up CL.

Mocks:  https://gallery.googleplex.com/login?redirect_to=%2Fprojects%2FMCHbtQVoQ2HCZXdtrkhTAHBP%2Ffiles%2FMCFrtjARIqeeI-1EJbPSBa22wMSJbxAVNpw

[email protected]

(cherry picked from commit 79c18709dcc89c752b5d34241214ab14db9ac768)

Bug: 727873
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I25a7e7b2a99590447b90f3f91d5b64960f467eef
Reviewed-on: https://chromium-review.googlesource.com/576474
Commit-Queue: Ryan Cui <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489440}
Reviewed-on: https://chromium-review.googlesource.com/592229
Cr-Commit-Position: refs/branch-heads/3163@{#107}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/settings_strings.grdp[diff]
• chrome/browser/extensions/api/settings_private/prefs_util.cc[diff]
• chrome/browser/resources/settings/google_assistant_page/compiled_resources2.gyp[Added - diff]
• chrome/browser/resources/settings/google_assistant_page/google_assistant_browser_proxy.html[Added - diff]
• chrome/browser/resources/settings/google_assistant_page/google_assistant_browser_proxy.js[Added - diff]
• chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html[Added - diff]
• chrome/browser/resources/settings/google_assistant_page/google_assistant_page.js[Added - diff]
• chrome/browser/resources/settings/route.js[diff]
• chrome/browser/resources/settings/search_page/search_page.html[diff]
• chrome/browser/resources/settings/search_page/search_page.js[diff]
• chrome/browser/resources/settings/settings_resources.grd[diff]
• chrome/browser/ui/BUILD.gn[diff]
• chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.cc[Added - diff]
• chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.h[Added - diff]
• chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc[diff]
• chrome/browser/ui/webui/settings/md_settings_ui.cc[diff]

[ios] Check that an active WebState exists before returning page titles.

This change is a speculative fix for https://crbug.com/749477 and aligns the iOS
implementation of GetTitle() with desktop's.

BUG=749477
[email protected]

(cherry picked from commit 3f66eaed29028323708438d837e23e9d5f0f1cfd)

Change-Id: I87f21fe2e84b069547376c2d315d8288f46039cb
Reviewed-on: https://chromium-review.googlesource.com/590135
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490371}
Reviewed-on: https://chromium-review.googlesource.com/592143
Reviewed-by: Peter Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#106}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm[diff]

Fix crash when back button is pressed at Doff

[email protected]

(cherry picked from commit f71b90f3e2816bd84bd35bf02d918995c99ddad2)

Bug: 748272
Change-Id: I25d416132dfc9dccca2205bbe485291933eaeb2f
Reviewed-on: https://chromium-review.googlesource.com/585590
Commit-Queue: Biao She <[email protected]>
Reviewed-by: Yash Malik <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489462}
Reviewed-on: https://chromium-review.googlesource.com/591636
Reviewed-by: Biao She <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#105}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java[diff]

[autofill] Suppress disused address suggestions

If enabled, suppress the suggestion of disused addresses (i.e., those
not used the last 6 months) unless they match non-empty user input.

BUG=734151
[email protected]

(cherry picked from commit 8af7f59317c7fe10cd1e013c69d506544a9eb685)

Change-Id: I6b2e52cce16f36af16b41d5a1aeafa2dd79752aa
Reviewed-on: https://chromium-review.googlesource.com/576627
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Roger McFarlane <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488671}
Reviewed-on: https://chromium-review.googlesource.com/592138
Reviewed-by: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#104}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/autofill/core/browser/autofill_experiments.cc[diff]
• components/autofill/core/browser/autofill_experiments.h[diff]
• components/autofill/core/browser/autofill_metrics.cc[diff]
• components/autofill/core/browser/autofill_metrics.h[diff]
• components/autofill/core/browser/personal_data_manager.cc[diff]
• components/autofill/core/browser/personal_data_manager.h[diff]
• components/autofill/core/browser/personal_data_manager_unittest.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

cros:Adding A11y strings for the peeking launcher.

Added strings for all launcher state transitions.
Added missing strings for the x button in the searchbox and for
the expand chevron.
Added all possible strings which could replace SUGGESTED APPS.

[email protected]

(cherry picked from commit 9b43378da44e0d01041ca7bb284750696e678a76)

Bug: 749685
Change-Id: I08a056533f0bc86ef8f9730275d5cd69f49a8270
Reviewed-on: https://chromium-review.googlesource.com/589987
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490168}
Reviewed-on: https://chromium-review.googlesource.com/592137
Cr-Commit-Position: refs/branch-heads/3163@{#103}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/generated_resources.grd[diff]
• ui/strings/ui_strings.grd[diff]

Update voice interaction string

TEST=build
BUG=749874
[email protected]

(cherry picked from commit e416efc30ebb12d79a113ccf288a6daeade591a6)

Change-Id: I205677631bfc69662f0917007bdeab53e269d871
Reviewed-on: https://chromium-review.googlesource.com/590674
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490171}
Reviewed-on: https://chromium-review.googlesource.com/592148
Cr-Commit-Position: refs/branch-heads/3163@{#102}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/chromeos_strings.grdp[diff]

Remove BrowserPluginGuestDelegate::CanRunInDetachedState() refs.

Allowing GuestViews to run in a detached state currently can cause test
flakiness, since a WebView.onContentLoad event can be received by the
embedder before the WebView has been properly attached. Since running in
a detached state isn't properly supported (or required), we remove it.

Bug: 747125
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I3a88bbc9be40ddb94d60c7aab3eeedfcc678b16e
Reviewed-on: https://chromium-review.googlesource.com/587448
Commit-Queue: James MacLean <[email protected]>
Reviewed-by: Lucas Gadani <[email protected]>
Reviewed-by: Charlie Reis (slow) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#490104}
(cherry picked from commit c2f38775367477469cddb95e2bb93ec916f1bf94)

[email protected],[email protected]

Change-Id: I3a88bbc9be40ddb94d60c7aab3eeedfcc678b16e
Reviewed-on: https://chromium-review.googlesource.com/591916
Reviewed-by: Lucas Gadani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#101}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/guest_view/browser/guest_view_base.cc[diff]
• components/guest_view/browser/guest_view_base.h[diff]
• content/browser/browser_plugin/browser_plugin_guest.cc[diff]
• content/public/browser/browser_plugin_guest_delegate.cc[diff]
• content/public/browser/browser_plugin_guest_delegate.h[diff]
• extensions/browser/guest_view/app_view/app_view_guest.cc[diff]
• extensions/browser/guest_view/app_view/app_view_guest.h[diff]
• extensions/browser/guest_view/extension_options/extension_options_guest.cc[diff]
• extensions/browser/guest_view/extension_options/extension_options_guest.h[diff]
• extensions/browser/guest_view/extension_view/extension_view_guest.cc[diff]
• extensions/browser/guest_view/extension_view/extension_view_guest.h[diff]
• extensions/browser/guest_view/web_view/web_view_guest.cc[diff]
• extensions/browser/guest_view/web_view/web_view_guest.h[diff]

[CrOS Tether] Shut down Tether before disabling in NetworkStateHandler.

Previously, we would disable Tether networks in NetworkStateHandler
before shutting down the Tether component, leaving open the possibility
that after Tether networks were disabled but before the component was
shut down, Tether code could interact with NetworkStateHandler. This
race condition caused occasional browser crashes.

This CL also:
(1) Changes some TetherService function names to be more appropriate.
(2) Changes a DCHECK() in NetworkStateHandler to an error log and an
    early return to prevent the possibility of a browser crash when it
    was not necessary to do so.

[email protected]

(cherry picked from commit e3919113ac18dab0feae2bdae522395faf316894)

Bug: 747644, 672263
Change-Id: I8687ffa141efd9fe0eac0875fb58f4556dd24452
Reviewed-on: https://chromium-review.googlesource.com/585400
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#490029}
Reviewed-on: https://chromium-review.googlesource.com/592129
Cr-Commit-Position: refs/branch-heads/3163@{#100}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/chromeos/login/session/chrome_session_manager.cc[diff]
• chrome/browser/chromeos/login/session/user_session_manager.cc[diff]
• chrome/browser/chromeos/tether/fake_tether_service.cc[diff]
• chrome/browser/chromeos/tether/fake_tether_service.h[diff]
• chrome/browser/chromeos/tether/tether_service.cc[diff]
• chrome/browser/chromeos/tether/tether_service.h[diff]
• chromeos/network/network_state_handler.cc[diff]

Add a string for lock screen notes section title in stylus settings

BUG=747157
[email protected]

(cherry picked from commit 6f4097431d1aa9b81bf51892c25f2be4a50c5904)

Change-Id: Ib90b9e98942f89964f189b6ece65f301094903ea
Reviewed-on: https://chromium-review.googlesource.com/585218
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489489}
Reviewed-on: https://chromium-review.googlesource.com/591881
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#99}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/app/settings_strings.grdp[diff]

Revert "[RemotePlayback] Add media source info to the RemotePlayback availability url"

This reverts commit 09fa66e1baaa95d069bbd6620670311ae8aa4dc5.

[email protected]

(cherry picked from commit ec724bb577b376824afcfe1e71e4c06a97357d9f)

Bug: 747420
Change-Id: I193769115a2304ebf5c25c1c82fa57bcad96838b
Reviewed-on: https://chromium-review.googlesource.com/591928
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#98}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• content/renderer/media/webmediaplayer_ms_unittest.cc[diff]
• media/base/media_observer.h[diff]
• media/base/renderer_factory_selector.cc[diff]
• media/blink/webmediaplayer_impl.cc[diff]
• media/blink/webmediaplayer_impl.h[diff]
• media/blink/webmediaplayer_impl_unittest.cc[diff]
• media/media_options.gni[diff]
• media/remoting/renderer_controller.cc[diff]
• media/remoting/renderer_controller.h[diff]
• media/remoting/renderer_controller_unittest.cc[diff]
• third_party/WebKit/Source/core/html/HTMLMediaElement.cpp[diff]
• third_party/WebKit/Source/core/html/HTMLMediaElement.h[diff]
• third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp[diff]
• third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h[diff]
• third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp[diff]
• third_party/WebKit/public/platform/WebMediaPlayerClient.h[diff]
• third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h[diff]

Incrementing VERSION to 61.0.3163.16

[email protected]

Change-Id: I452bae7da746497c5ef3d2f8f6e3717af34b650c
Reviewed-on: https://chromium-review.googlesource.com/590712
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#97}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]

[m61 merge] QuicHttpStream::ReadResponseBody() should return OK if a solo fin is read, not ERR_QUIC_PROTOCOL_ERROR.

BUG=748249
[email protected]

(cherry picked from commit 2ef0a9c3ed9aa629c0bb7428d4dfed904bfbb2cb)

Change-Id: I08e68b5ddf366f0632c49a3ec993ce62e9c8b891
Reviewed-on: https://chromium-review.googlesource.com/583906
Reviewed-by: Zhongyi Shi <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489209}
Reviewed-on: https://chromium-review.googlesource.com/590753
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#96}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• net/quic/chromium/quic_http_stream.cc[diff]
• net/quic/chromium/quic_http_stream_test.cc[diff]

Enable field trial testing config for Instant Tethering.

This also includes a small change to how Tether is called from
ChromeSessionManager: it is not called for tests because some
tests in browser_tests shut down a dependency of Tether before
it has a chance to itself shut down. We are tracking the eventual
correct fix here: crbug.com/748848.

[email protected]

(cherry picked from commit 3cb0af4bda55cdd383804a307fa3d8d5be7ede22)

Bug: 740684, 672263
Change-Id: Ia896e1be97aeb42f909b0e6b2223e85bcdbe165a
Reviewed-on: https://chromium-review.googlesource.com/585854
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489694}
Reviewed-on: https://chromium-review.googlesource.com/590754
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#95}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/chromeos/login/session/chrome_session_manager.cc[diff]
• testing/variations/fieldtrial_testing_config.json[diff]

[CrOS Tether] Eliminate crash in D2D-Auth protocol.

This fix makes it possible to instantiate
DeviceToDeviceInitiatorOperations instances and uses WeakPtrs
within the class to ensure that it is not possible to segfault by
attempting to call a function on a deleted object.

[email protected]

(cherry picked from commit 2693aa8e650f3819cbf455d628622d694d9d35a3)

Bug: 672263, 741042
Change-Id: Idcb13aa4772d6e227a335556bd4bf6b3cb4d3f4c
Reviewed-on: https://chromium-review.googlesource.com/583563
Reviewed-by: Tim Song <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489989}
Reviewed-on: https://chromium-review.googlesource.com/590750
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#94}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/cryptauth/BUILD.gn[diff]
• components/cryptauth/device_to_device_authenticator.cc[diff]
• components/cryptauth/device_to_device_authenticator.h[diff]
• components/cryptauth/device_to_device_authenticator_unittest.cc[diff]
• components/cryptauth/device_to_device_initiator_helper.cc[Renamed from components/cryptauth/device_to_device_initiator_operations.cc - diff]
• components/cryptauth/device_to_device_initiator_helper.h[Added - diff]
• components/cryptauth/device_to_device_initiator_operations.h[Deleted - diff]
• components/cryptauth/device_to_device_operations_unittest.cc[diff]

Restart via upstart functionality for MPP API.

Bug: 747517
Change-Id: I1fabb0ca66d4739d760b2d598cdadf407655574b
Reviewed-on: https://chromium-review.googlesource.com/580400
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Luke Sorenson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489493}(cherry picked from commit c307b8eff8fd39fd950222252d5e30408641d7dc)
Reviewed-on: https://chromium-review.googlesource.com/590493
Reviewed-by: Simon Que <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#93}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chromeos/dbus/fake_media_analytics_client.cc[diff]
• chromeos/dbus/fake_media_analytics_client.h[diff]
• chromeos/dbus/fake_upstart_client.cc[diff]
• chromeos/dbus/fake_upstart_client.h[diff]
• chromeos/dbus/proto/media_perception.proto[diff]
• chromeos/dbus/upstart_client.cc[diff]
• chromeos/dbus/upstart_client.h[diff]
• extensions/browser/api/media_perception_private/conversion_utils.cc[diff]
• extensions/browser/api/media_perception_private/conversion_utils_unittest.cc[diff]
• extensions/browser/api/media_perception_private/media_perception_api_manager.cc[diff]
• extensions/browser/api/media_perception_private/media_perception_api_manager.h[diff]
• extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc[diff]
• extensions/browser/api/media_perception_private/media_perception_private_api.cc[diff]
• extensions/common/api/media_perception_private.idl[diff]
• extensions/test/data/media_perception_private/state/runtest.js[diff]

Fix NPE in first run if the activity has been destroyed.

BUG=748161
[email protected]

(cherry picked from commit a610d7d27c1e5b53edde4259c965b0c7207f438b)

Change-Id: Ic188d622ed44982d0c9cb138711e2e907b8d49aa
Reviewed-on: https://chromium-review.googlesource.com/583710
Reviewed-by: Alexei Svitkine (slow) <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489430}
Reviewed-on: https://chromium-review.googlesource.com/590690
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#92}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java[diff]

Fix state transition bugs when pressing the escape key for the fullscreen app list. After this change, if escape is pressed, the following state changes occur: PEEKING->CLOSED HALF->PEEKING FULLSCREEN_ALL_APPS->CLOSED FULLSCREEN_SEARCH->FULLSCREEN_ALL_APPS

[email protected]

(cherry picked from commit 708874ac3d1135aff5c556d3c3f2a9f18af248b9)

Bug: 740662
Test: Unit tested, device tested with --enable-features=EnableFullscreenAppList
Change-Id: Id0820a9f07bf362fddc6e1adb3ef5648b3d2070d
Reviewed-on: https://chromium-review.googlesource.com/578733
Commit-Queue: Maajid <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489151}
Reviewed-on: https://chromium-review.googlesource.com/590527
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#91}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ui/app_list/views/app_list_view.cc[diff]
• ui/app_list/views/app_list_view.h[diff]
• ui/app_list/views/app_list_view_unittest.cc[diff]
• ui/app_list/views/contents_view.cc[diff]
• ui/app_list/views/search_box_view.cc[diff]

Display the HTTP login dialog on top of the sign-in modal dialog.

This CL adds a dialog manager for the sign-in dialog that allows
an HTTP login dialog to be displayed on top of the sign-in dialog.
This is required to avoid a crash when there loading the Gaia
sign-in page goes through a proxy that requires HTTP basic
authentication.

Screenshot:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbMzhPcGRWdXBlSkU/view?usp=sharing

[email protected]

(cherry picked from commit 0725e99fd873ec5412ef29e21c34d165ec84642d)

Bug: 629529
Change-Id: I358a28db0bc6cf071668cc71731fb3805af18692
Reviewed-on: https://chromium-review.googlesource.com/577847
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#489351}
Reviewed-on: https://chromium-review.googlesource.com/590447
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#90}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h[diff]
• chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm[diff]
• chrome/browser/ui/signin_view_controller.cc[diff]
• chrome/browser/ui/signin_view_controller_delegate.cc[diff]
• chrome/browser/ui/signin_view_controller_delegate.h[diff]
• chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc[diff]
• chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h[diff]

Patch around crbug.com/742370 until root cause can be found.

[email protected]

(cherry picked from commit bbb68692e50d2fcf679acb7047ed9f7efc46bc0e)

Bug: 742370
Change-Id: I317ae9cd9449adb6311ec7a7e7c28ff4ba582476
Reviewed-on: https://chromium-review.googlesource.com/583867
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Peter Williamson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489102}
Reviewed-on: https://chromium-review.googlesource.com/590507
Reviewed-by: Dmitry Titov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#89}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc[diff]

Fix app list test that assumed that a nonempty searchbox should be inactive. Even if there is only whitespace in the searchbox, it should still be active. In addition, clearing the searchbox from the app list view creates easy opportunities for infinite loops.

[email protected]

(cherry picked from commit 18da770d8e4781f5b08d14c6c2a4a56a43da54fa)

Bug: 740662
Change-Id: I9806242ac448dfb7a2a0d2af34388aa3fa3c47d8
Reviewed-on: https://chromium-review.googlesource.com/581567
Commit-Queue: Maajid <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488778}
Reviewed-on: https://chromium-review.googlesource.com/590093
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#88}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ash/app_list/app_list_presenter_delegate_unittest.cc[diff]
• ui/app_list/views/app_list_view.cc[diff]

Use the actual card's query for open-URL.

The answer server can autocomplete the query. It now returns a header
with the autocompleted query that was used to generate the card.

Using it when available.

Locally run server already returns the header, while the prod one
doesn't yet. Hence temporarily treating this header as optional.

Bug=712331

[email protected]

(cherry picked from commit a444dff663a9c5b28dc1c4193aef9ff2cb8a6c2e)

Change-Id: I426377d599a996049b5654eb87217413045156c2
Reviewed-on: https://chromium-review.googlesource.com/585810
Commit-Queue: Vadim Tryshev <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489856}
Bug: 712331
Reviewed-on: https://chromium-review.googlesource.com/590407
Reviewed-by: Vadim Tryshev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#87}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc[diff]
• chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h[diff]

M61 merge: MD Settings: Fix add language dialog search.

Previously it would not search any of the native language names, resulting
in missing results.

Bug: 746880
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6fb39d532eb87bf138c22018ca81638b1083a969
Reviewed-on: https://chromium-review.googlesource.com/580250
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Dave Schuyler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488792}
Reviewed-on: https://chromium-review.googlesource.com/590287
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#86}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/settings/languages_page/add_languages_dialog.js[diff]
• chrome/test/data/webui/settings/fake_language_settings_private.js[diff]
• chrome/test/data/webui/settings/languages_page_tests.js[diff]

Chrome Cleanup WebUI: polishing fixes from implementation review

Resize spinner, standardize color use, add learn more to error state,
change reboot required icon

Also makes chrome://settings/help use the right colors.

Bug: 747124
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifae6b61cc4ffa668dbe095333f3590a2d97277a4
Reviewed-on: https://chromium-review.googlesource.com/580360
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: proberge <[email protected]>
Cr-Commit-Position: refs/heads/master@{#488992}
(cherry picked from commit 435ed1848ee5bf092fcbfd818b9f49e98c1485a1)

Change-Id: I6f20ec0a45aec8f19e4df42921a994567576c7d9
Reviewed-on: https://chromium-review.googlesource.com/590349
Reviewed-by: proberge <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#85}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/settings/about_page/about_page.html[diff]
• chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html[diff]
• chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js[diff]

Reland OOBE display chooser commits + add Mash guard

This CL will reland / revert revert 2 commits and add a non-Mash guard
for listening to DeviceDataManager. A TODO has been added about using
InputDeviceClient in Mash, but it's not super urgent as the reaction to
the event is a NOP in Mash further down the call chain.

Revert "Revert of Remove confusing keyboard test & focus on input device"
  commit 8a2f3aa1eedac03d1fec4cccd802711424c39ce1

Revert "Revert "Listen to changes to touch input devices""
  commit 0cd134a54e6f49ef56245db82edced7b2dc44f52

[email protected]

(cherry picked from commit d706dfca2856894481f82ae6d5235166b7fc7c7b)

Bug: 738885
Change-Id: Ic805ca3966df2969d8444b2c441eac24f75dce62
Reviewed-on: https://chromium-review.googlesource.com/575138
Commit-Queue: Felix Ekblom <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488622}
Reviewed-on: https://chromium-review.googlesource.com/590352
Cr-Commit-Position: refs/branch-heads/3163@{#84}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/chromeos/login/ui/login_display_host_impl.cc[diff]
• chrome/browser/chromeos/login/ui/login_display_host_impl.h[diff]
• chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc[diff]
• chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc[diff]
• chrome/browser/ui/webui/chromeos/login/oobe_ui.cc[diff]

[vr] Disable auto-presentation of WebVR content

Bug: 749681
Change-Id: I70022aa1c214c21a711ff074f707cb1dab6132ec
Reviewed-on: https://chromium-review.googlesource.com/583903
Reviewed-by: Biao She <[email protected]>
Commit-Queue: Yash Malik <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489328}(cherry picked from commit a0c5d56c711cae83c4072bd0072b68d259e0af5d)
Reviewed-on: https://chromium-review.googlesource.com/590167
Reviewed-by: Yash Malik <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#83}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/android/chrome_feature_list.cc[diff]

Add accessible names to TrayInfoLabels.

[email protected]

(cherry picked from commit b15287cba7207048d9023ef3bf8d4a2574b0a04d)

Bug: 672263, 673874, 746107
Change-Id: I5a1f7a4d86307bd84e236dc29d3da224abdcaef4
Reviewed-on: https://chromium-review.googlesource.com/580406
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488770}
Reviewed-on: https://chromium-review.googlesource.com/590088
Cr-Commit-Position: refs/branch-heads/3163@{#82}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ash/system/tray/tray_info_label.cc[diff]
• ash/system/tray/tray_info_label_unittest.cc[diff]

Expand validation for histograms coming from persistent memory.

Specifically, we're seeing some instances of histograms failing
ValidateHistogramContents() due to their names being truncated
when coming out of persistent memory on Windows. This CL adds a
check that ids match the hash of the name, which should catch
such cases and not import these bad entries.

This should address the crashes we're seeing on Windows as a result
of ValidateHistogramContents(), which are a different issue than
what we're seeing on Android.

BUG=744734,736675
[email protected]

(cherry picked from commit 85f982b0e451c62c0127c83e846988b903b56e73)

Change-Id: I0aae94107292523b01a7618cf53b4f854678c4c0
Reviewed-on: https://chromium-review.googlesource.com/583292
Commit-Queue: Alexei Svitkine (slow) <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489115}
Reviewed-on: https://chromium-review.googlesource.com/590067
Reviewed-by: Alexei Svitkine (OOO July28-Aug6) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#81}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• base/metrics/persistent_histogram_allocator.cc[diff]

Fix bug in PaintOpBuffer folding alpha optimization

PaintOpBuffer tries to fold together saveLayer/draw/restore into a
single draw-with-alpha, however it was doing this in cases that it
shouldn't.  If the external saveLayer had an alpha of 255, then it would
believe that it was always a noop.  However, if the draw op had some
blend mode or image filter (and thus didn't support folding) then it's
not safe to consider this saveLayer a noop.

Fix by reordering the conditionals so that if the draw op doesn't
support then PaintOpBuffer goes down the normal no folding raster path.

[email protected]

(cherry picked from commit 23681aaf9e05a6db8f10f072f0db8c03e9334e6f)

Bug: 748485
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0eeea49f3348aecda137860231a78b0075993834
Reviewed-on: https://chromium-review.googlesource.com/585633
Reviewed-by: Vladimir Levin <[email protected]>
Commit-Queue: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489494}
Reviewed-on: https://chromium-review.googlesource.com/589785
Reviewed-by: enne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#80}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• cc/paint/paint_op_buffer.cc[diff]
• cc/paint/paint_op_buffer_unittest.cc[diff]

VR: Strip https scheme from offline pages.

As per Clank behavior and Enamel's request, offline pages should not
show an https scheme.

BUG=740112

Change-Id: I46bc34115d72ae83b2f76874279d125152d69ac7
Reviewed-on: https://chromium-review.googlesource.com/585305
Reviewed-by: Ian Vollick <[email protected]>
Commit-Queue: Christopher Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489435}(cherry picked from commit 52699acc5b78f5fd5c3be69f7051dd2ab669f1f3)
Reviewed-on: https://chromium-review.googlesource.com/589487
Reviewed-by: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#79}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/vr/elements/url_bar_texture.cc[diff]
• chrome/browser/vr/elements/url_bar_texture.h[diff]
• chrome/browser/vr/elements/url_bar_texture_unittest.cc[diff]

v8binding: Fixes MutationCallback not to access the empty context.

MutationCallback holds a ScriptState and accesses it assynchronously.
So, MutationCallback should check the context if it's alive before
the uses.

[email protected]

(cherry picked from commit 659015bc5eb341e9d3ccce40ba0293079f2c2e31)

Bug: 738299
Change-Id: Ib16b37b2e90e5ba87117d7c6e1218f9df6d69a41
Reviewed-on: https://chromium-review.googlesource.com/574509
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488611}
Reviewed-on: https://chromium-review.googlesource.com/589468
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#78}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h[diff]

VR: Add offline mode URL rendering unit test.

Check that:
- The security verbose text is present in offline mode oly.
- The URL moves when security verbose text is present.

BUG=
[email protected]

(cherry picked from commit d4a941c61b23cf4a59c7e23655249155aea2d6e7)

Change-Id: I2220ba6a2657a78a7fab1cb03fd23e6b02024bf9
Reviewed-on: https://chromium-review.googlesource.com/582934
Reviewed-by: Ian Vollick <[email protected]>
Commit-Queue: Christopher Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489020}
Reviewed-on: https://chromium-review.googlesource.com/588849
Reviewed-by: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#77}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/vr/elements/url_bar_texture.cc[diff]
• chrome/browser/vr/elements/url_bar_texture.h[diff]
• chrome/browser/vr/elements/url_bar_texture_unittest.cc[diff]

Typo between IsRunningOnIOS11OrLater() and IsRunningOnIOS10OrLater()

Hack introduced for iOS 11 to fix the issue related to WKWebView which
has to be part of the view hierarchy. This hack should be run only on
iOS 11, and not iOS 10.

Bug introduced with crrev.com/b/577807

[email protected]

(cherry picked from commit 7bd91a687e5eead254808a07f4b8741bf06f864e)

Bug: 748580
Change-Id: If133cfbf345961204fdae0773bc728898a2c7284
Reviewed-on: https://chromium-review.googlesource.com/584878
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489589}
Reviewed-on: https://chromium-review.googlesource.com/589171
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#76}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/signin/ios/browser/account_consistency_service.mm[diff]

Remove 'height: 0' from md-select-underline

Setting 'height: 0' in http://crrev.com/c/566826 caused issues when
zooming out. This CL removes the height attribute and increases the
margin in Clear Browsing Data to keep the dropdown and the label on
the same height.

Screenshot 100%
https://screenshot.googleplex.com/jJAZs5TFgiD.png

Screenshot 90%
https://screenshot.googleplex.com/ZrDWbud2VVs.png

[email protected]

(cherry picked from commit 45ba68f36c1ac34f7a5a584bde8621394c2618ae)

Bug: 747842
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic3d08a1e0b3a28e25ddde70a35a373bf089cb277
Reviewed-on: https://chromium-review.googlesource.com/584667
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489447}
Reviewed-on: https://chromium-review.googlesource.com/588909
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#75}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html[diff]
• ui/webui/resources/html/md_select_css.html[diff]

Merge 3163: Adjust the mid-word-break heuristic limit to 4em for Emoji ZWJ sequence

Mid-word-break algorithm kicks in when CSS properties such as
'word-wrap: break-word' is used. Logically speaking, we should layout
as normal, and break words if overflow occurs.

However, Blink has 2em heuristic limit because of the performance
problem in certain cases. This means Blink measures characters that go
beyond the right edge only up to 2em before it starts mid-word-break.
See the previous CL[1] for more details.

This patch adjusts it to 4em. The longest common ligature is Emoji ZWJ
sequence, and its v5.0[2] can ligate 4 Emoji into 1 at maximum. To
handle this, 3em overflow is needed, and 1em for a rainy day fund.

[1] r403830, https://codereview.chromium.org/2077313002
[2] http://unicode.org/emoji/charts/emoji-zwj-sequences.html

[email protected]

(cherry picked from commit 14ec221a9013017a9007181bb7414464ee63f1b4)

Bug: 746222
Change-Id: Ic58b58716502f4ae9a06c1e91d2f5de944bc7978
Reviewed-on: https://chromium-review.googlesource.com/581249
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488813}
Reviewed-on: https://chromium-review.googlesource.com/587705
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#74}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h[diff]

Policy to disable/whitelist lock screen note taking apps

Adds a policy to control whether/which note taking apps are allowed
on the lock screen - the policy is implemented as a white-list of
apps that will be allowed as lock screen note taking apps (provided
the user enables them in settings).

The policy value is saved as kNoteTakingAppsAllowedOnLockScreen pref
that's being added in https://chromium-review.googlesource.com/c/572842

BUG=741053
[email protected]

(cherry picked from commit c45d9b1e3ae2b6110927cb7bb6087ca9cb2d0832)

Change-Id: Ib1beb5ee3c7f4efad0eb8be99f894345adaf7530
Reviewed-on: https://chromium-review.googlesource.com/567556
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489199}
Reviewed-on: https://chromium-review.googlesource.com/588382
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#73}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/policy/configuration_policy_handler_list_factory.cc[diff]
• chrome/browser/policy/policy_browsertest.cc[diff]
• chrome/test/data/policy/policy_test_cases.json[diff]
• components/policy/resources/policy_templates.json[diff]
• tools/metrics/histograms/enums.xml[diff]

Update stylus settings for lock screen note taking

Fixes a number of issues with stylus settings for note taking on lock
screen:
 *  Provide a NoteTakingHelper observer interface called when the
    preferred app changes (or when it's lock screen status changes)
     *  Settings UI can use this to update itself when the preferred
        app changes.
     *  Switch lock_screen_apps::AppManagerImpl to observe this event
        for preferred app changes (instead of observing note taking
        pref directly)
  *  Introduces kNoteTakingAppsAllowedOnLockScreen pref, that will be
    used by a user policy to whitelist apps available on the lock
    screen (to be added in dependent patch)
 *  Disable lock screen support for note taking apps in non-primary
    profiles (the profile that supports lock screen use case is set
    by lock_screen_apps::StateController during its initialization).
 *  Redo settings UI for enabling apps on the lock screen so its
    state (whether it's disabled, the policy indicator) does not
    depend on prefs directly, instead derive the state from the
    note taking app's NoteAppInfo (in particular lockScreenSupport
    property)

While here, did some cleanup in test code:
 *  Provided utility methods to NoteTakingHelper unit tests to
    reduce code duplication:
     *  Method to create/install lock screen enabled note taking app
     *  Methods for verifying preferred app and available apps info
 *  In stylus device page browser tests, made fake browser proxy
    smarter, so test don't have to "manually" trigger note taking app
    changes

[email protected]

(cherry picked from commit e4a5c06a33df72ea7960883381427ac6b67b2f1e)

Bug: 741940
Bug: 741053
Bug: 746116
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5e2ee138df620d3832a8ad0d1b4d0db285fba0da
Reviewed-on: https://chromium-review.googlesource.com/572842
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489142}
Reviewed-on: https://chromium-review.googlesource.com/588341
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#72}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/chromeos/lock_screen_apps/app_manager_impl.cc[diff]
• chrome/browser/chromeos/lock_screen_apps/app_manager_impl.h[diff]
• chrome/browser/chromeos/lock_screen_apps/app_manager_impl_unittest.cc[diff]
• chrome/browser/chromeos/lock_screen_apps/note_taking_browsertest.cc[diff]
• chrome/browser/chromeos/lock_screen_apps/state_controller.cc[diff]
• chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc[diff]
• chrome/browser/chromeos/note_taking_helper.cc[diff]
• chrome/browser/chromeos/note_taking_helper.h[diff]
• chrome/browser/chromeos/note_taking_helper_unittest.cc[diff]
• chrome/browser/chromeos/preferences.cc[diff]
• chrome/browser/extensions/api/settings_private/prefs_util.cc[diff]
• chrome/browser/resources/settings/device_page/compiled_resources2.gyp[diff]
• chrome/browser/resources/settings/device_page/device_page_browser_proxy.js[diff]
• chrome/browser/resources/settings/device_page/stylus.html[diff]
• chrome/browser/resources/settings/device_page/stylus.js[diff]
• chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc[diff]
• chrome/browser/ui/webui/options/chromeos/options_stylus_handler.h[diff]
• chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc[diff]
• chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.h[diff]
• chrome/common/pref_names.cc[diff]
• chrome/common/pref_names.h[diff]
• chrome/test/data/webui/settings/device_page_tests.js[diff]

Fixes the frame of the menu view so that it is not truncated in RTL.

The menuview frame must be set equal to the panelview's menuwrapper
bounds on iPhone. This was missed during refactoring classes to pull
out logic to the super class. This did not effect LTR languages
but manifests as a bug in RTL.

[email protected]

(cherry picked from commit 8d5b4955c30c125215be6ea62e632ad8e567865d)

Bug: 747411,747410
Change-Id: Id1ac76153f3c12f9430f42460bf17e5de86c01fe
Reviewed-on: https://chromium-review.googlesource.com/583879
Reviewed-by: Jean-François Geyelin <[email protected]>
Reviewed-by: Louis Romero <[email protected]>
Commit-Queue: Louis Romero <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489323}
Reviewed-on: https://chromium-review.googlesource.com/587512
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#71}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm[diff]

chrome/android: Fixed bug in highlighting data saver menu footer

The data saver menu footer is supposed to be highlighted when the data
saver in-product help is shown but it is not. This patch fixed it by
changing the ID that is highlighted to be the inflatedID of the app menu footer
view stub.

BUG=747486

(cherry picked from commit c338ce85529eb595e7f11f916dbf1d05f856b0c5)

Change-Id: Iaf43badcf277dd424fc02fbafa4d27e51c03737c
Reviewed-on: https://chromium-review.googlesource.com/581879
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Angela Shao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488785}
Reviewed-on: https://chromium-review.googlesource.com/588247
Cr-Commit-Position: refs/branch-heads/3163@{#70}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java[diff]

Incrementing VERSION to 61.0.3163.15

[email protected]

Change-Id: I0c8892664c8be2aee057af08e8cee029c06d2c4e
Reviewed-on: https://chromium-review.googlesource.com/588131
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#69}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]

[Sync] No-op RecordUserEvent is ModelTypeStore has not initialized.

If RecordUserEvent happened before the ModelTypeStore initialized,
we would deref null and cause a crash. The other usages of store_
are driven by sync, which shouldn't call into us until we tell sync
that we're ready, so they should not need an null check. This fix is
ultimately a hack, and can be removed once crbug.com/709094 is done.

[email protected]

(cherry picked from commit 2aa9702d28364ee7fcf762cdcb9f2f26fd8687dd)

Bug: 748384
Change-Id: Iafeffee0d9bb77b5d539b72992b085d1833015ee
Reviewed-on: https://chromium-review.googlesource.com/584554
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489385}
Reviewed-on: https://chromium-review.googlesource.com/587830
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#68}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• components/sync/user_events/user_event_sync_bridge.cc[diff]

Fixed webViewLoadingStateDidChange crash.

webViewLoadingStateDidChange crashes on dereferencing a null pointer.
It is unknown how app gets into this state, but registering another load
request is a better option than crashing.

[email protected]

(cherry picked from commit 541f04637e46170e3882e20e047820046436c02a)

(cherry picked from commit 3046ee1149f701c0aaa316f7d5fb714d7534359b)

Bug: 737595
Change-Id: Ibbe66fe5689722fea2de205d07871f3dacec136a
Reviewed-on: https://chromium-review.googlesource.com/585864
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#489537}
Reviewed-on: https://chromium-review.googlesource.com/586926
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3112@{#673}
Cr-Original-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Reviewed-on: https://chromium-review.googlesource.com/587713
Cr-Commit-Position: refs/branch-heads/3163@{#67}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ios/web/web_state/ui/crw_web_controller.mm[diff]

[MD settings] change icon-delete to a -gray and -white version

This CL splits the icon-delete svg into icon-delete-gray and
icon-delete-white so that we have two colors to use.

[email protected], [email protected]

(cherry picked from commit 94d1984c3fc2106c2398540e9b3435631fe5b80e)

Bug: 745289
Change-Id: I4d28034520eded8f787ee605bbb0da22f252d698
Reviewed-on: https://chromium-review.googlesource.com/576969
Commit-Queue: Dave Schuyler <[email protected]>
Reviewed-by: Hector Carmona <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488540}
Reviewed-on: https://chromium-review.googlesource.com/587421
Reviewed-by: Dave Schuyler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#66}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/settings/device_page/storage.html[diff]
• chrome/browser/resources/settings/people_page/fingerprint_list.html[diff]
• chrome/browser/resources/settings/site_settings/site_data.html[diff]
• chrome/browser/resources/settings/site_settings/site_details.html[diff]
• chrome/browser/resources/settings/site_settings/site_list.html[diff]
• chrome/test/data/webui/settings/site_data_test.js[diff]
• ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html[diff]
• ui/webui/resources/cr_elements/cr_icons_css.html[diff]
• ui/webui/resources/cr_elements_images.grdp[diff]
• ui/webui/resources/images/icon_delete_gray.svg[Added - diff]
• ui/webui/resources/images/icon_delete_white.svg[Renamed from ui/webui/resources/images/icon_delete.svg - diff]

Fix null pointer crash.

There might not be a WebContents for a print job.

BUG=748368
[email protected]

Change-Id: Ic6bc12aa69e7f97b1b7f30894fef2dc57144cbd6
Reviewed-on: https://chromium-review.googlesource.com/585247
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489396}(cherry picked from commit 6fc1a1908f33e823d82de23421c69377825bf202)
Reviewed-on: https://chromium-review.googlesource.com/587456
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#65}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/printing/print_job_worker.cc[diff]

[Mac] Fix for AutofillPopupViewBridge Crash

Unsubscribe the WebTextfieldTouchBarController from
the notification center when it's deallocated or the
window it's observing is closed.

(cherry picked from commit 33fe2312cc96068fe2dc76ab2d06b7da159a83aa)

Bug: 747713
Change-Id: I9d3543775fadc9fda31f6de83c1b962218ce0a30
Reviewed-on: https://chromium-review.googlesource.com/583929
Commit-Queue: Sarah Chan <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489119}
Reviewed-on: https://chromium-review.googlesource.com/587288
Reviewed-by: Sarah Chan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#64}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.h[diff]
• chrome/browser/ui/cocoa/web_textfield_touch_bar_controller.mm[diff]

[Media Router Action] Disable "Report an issue" context menu item for incognito

The menu item for sending feedback was either no-op (guest mode) or showing an
error page (incognito) before the regression that made it crash. This CL
disables the menu item for incognito and guest mode.

[email protected]

(cherry picked from commit 192631d496023f444b4de1fa4191df76ccd599e2)

Bug: 747792
Change-Id: I8338015b5305273c95ad022afdc056a55ffb2591
Reviewed-on: https://chromium-review.googlesource.com/583408
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489157}
Reviewed-on: https://chromium-review.googlesource.com/586077
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#63}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/media/router/event_page_request_manager_factory.cc[diff]
• chrome/browser/media/router/event_page_request_manager_factory.h[diff]
• chrome/browser/ui/toolbar/media_router_contextual_menu.cc[diff]
• chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc[diff]

Add synthetic field trial for sign-in isolation. (Merge to M61)

This will allow filtering results for the sign-in process isolation
trial to users that have actually browsed to accounts.google.com.

[email protected]

(cherry picked from commit 95e8906de1c8c086fee109c0de0b3a322b1faf12)

Bug: 739418
Change-Id: I31c9b36614cbcf1440c692d29450a851a2e29aa3
Reviewed-on: https://chromium-review.googlesource.com/579629
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Lukasz Anforowicz <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488532}
Reviewed-on: https://chromium-review.googlesource.com/586075
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#62}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/chrome_navigation_browsertest.cc[diff]
• chrome/browser/metrics/chrome_metrics_service_accessor.h[diff]
• chrome/browser/tab_contents/navigation_metrics_recorder.cc[diff]
• chrome/browser/tab_contents/navigation_metrics_recorder.h[diff]

Revert "cc: Enable composited border-radius scrolling."

This reverts commit 06adb5e74eb341b5a1fa68fed4e489f6f62ec5e8.

Reason for revert: Composited border-radius scrolling triggers two regression bugs: 1) crbug.com/740720, it results in high memory usage probably due to mask tiling not saving enough memory; 2) crbug.com/745114, compositor's scroll snapping can sometimes result in blurry text.

Original change's description:
> cc: Enable composited border-radius scrolling.
>
> Enable composited border-radius scrolling as mask tiling is implemented.
> We'll revert this CL if anything breaks.
>
> Bug: 567293, 567296
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I70bea4c542e00d244a597d1a36857dd120fc96cd
> Reviewed-on: https://chromium-review.googlesource.com/543397
> Commit-Queue: Xianda Sun <[email protected]>
> Reviewed-by: Chris Harrelson <[email protected]>
> Reviewed-by: Robert Flack <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#485040}

[email protected], [email protected], [email protected], [email protected], [email protected], [email protected]


(cherry picked from commit 2397e783b2b5a59a174d25d26f66d467a8b0a88f)

Bug: 567293, 567296, 740720, 745114
Change-Id: Ia185a9ce4310aeaff0175f0e9f0a9080dccf22e5
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/585227
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Xianda Sun <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489477}
Reviewed-on: https://chromium-review.googlesource.com/586949
Cr-Commit-Position: refs/branch-heads/3163@{#61}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.html[Added - diff]
• third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.png[Deleted - diff]
• third_party/WebKit/LayoutTests/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.txt[Deleted - diff]
• third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius-expected.txt[diff]
• third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius.html[diff]
• third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/respect-clip-for-non-composited-scrollers-when-prefering-compositing-over-lcd-text-expected.png[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-border-radius-clipping-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.9/scrollbars/border-box-rect-clips-scrollbars-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/prefer_compositing_to_lcd_text/scrollbars/border-box-rect-clips-scrollbars-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-border-radius-clipping-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/scrollbars/border-box-rect-clips-scrollbars-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/scrollbars/border-box-rect-clips-scrollbars-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-border-radius-clipping-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/overflow/nested-border-radius-clipping-expected.png[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-border-radius-clipping-expected.png[diff]
• third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp[diff]
• third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp[diff]
• third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp[diff]
• third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp[diff]
• third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp[diff]

Chrome Cleaner UI: Close dialog if the controller leaves the infected state.

The Chrome Cleaner dialog is shown when unwanted software is found on
the user's computer. Currently, if errors occur during communication
with the Chrome Cleaner process or if the user starts the cleanup from
the settings page from a different browser window, the modal dialog
will remain open.

With this CL, the modal dialog is closed by Chrome if the global
ChromeCleanerController object leaves the infected state, either due
to errors or user action on the webui card in the settings page.

[email protected]

(cherry picked from commit f5baba98f14b59da707b769f2f78d2085e7c64c0)

Bug: 747077
Change-Id: I3f8ed6288901aa3f9aaa2c2f108ca141fa3d0545
Reviewed-on: https://chromium-review.googlesource.com/578472
Commit-Queue: Ali Tofigh <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Robert Shield <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488782}
Reviewed-on: https://chromium-review.googlesource.com/587107
Reviewed-by: Ali Tofigh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#60}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/safe_browsing/BUILD.gn[diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc[Renamed from chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.cc - diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h[Added - diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc[Renamed from chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win_unittest.cc - diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h[diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc[diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h[diff]
• chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h[diff]
• chrome/browser/ui/browser_dialogs.h[diff]
• chrome/browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc[diff]
• chrome/browser/ui/views/chrome_cleaner_dialog_win.cc[diff]
• chrome/browser/ui/views/chrome_cleaner_dialog_win.h[diff]
• chrome/test/BUILD.gn[diff]
• tools/metrics/histograms/enums.xml[diff]

Revert "Make border width rounding visible to js via getComputedStyle."

This reverts commit e87da780e04bf05f5ae863d7fda517ee6c03d534.

Reason for revert: This fix is a spec violation, and the previous behavior was more correct. A slightly inaccurate representation (off by less than 0.02px) is better than clamping it to 1px.

Original change's description:
> Make border width rounding visible to js via getComputedStyle.
>
> CL (https://chromium-review.googlesource.com/c/525536/) moved rounding of border
> widths to the painting stage, hence rounding is no longer visible in js via
> getComputedStyle. This cl makes rounding visible again to users via getComputedStyle.
>
> This cl contains the following changes
> * Implemented a ZoomAdjustedPixelValueWithRounding method.
> - This method is the same as ZoomAdjustedPixelValue except that it
> rounds pixel value to 1 if original value is between 0 and 1.0.
> * Changed ComputedStyle for border-[top|right|bottom|left] to use
> ZoomAdjustedPixelValueWithRounding so that getComputedStyle will
> display rounded pixels for these properties (and also border-width that
> is a shorthand of these 4 longhand properties).
> * Changed a layout test.
>
> Bug: 737962
> Change-Id: I0656f7ea1212fe32f866d95218995fb3de109e05
> Reviewed-on: https://chromium-review.googlesource.com/560917
> Commit-Queue: Jia Meng <[email protected]>
> Reviewed-by: Alan Cutter <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#487384}

[email protected], [email protected], [email protected]


(cherry picked from commit 6e2e63240bfae36af4dc2b7f059a9d82b5bf753b)

Bug: 737962
Change-Id: I03120da255990456614ffc3e0e3180eaa20a566a
Reviewed-on: https://chromium-review.googlesource.com/582608
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488947}
Reviewed-on: https://chromium-review.googlesource.com/586723
Cr-Commit-Position: refs/branch-heads/3163@{#59}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• third_party/WebKit/LayoutTests/fast/sub-pixel/sub-pixel-border.html[diff]
• third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp[diff]

Revert "Add NSAllowsArbitraryLoadsInWebContent Info plist key"

This reverts commit 12ac6409c869b1e00ccec05b0ae17bfd11099c9f.

Reason for revert: introduces crbug.com/745945

Original change's description:
> Add NSAllowsArbitraryLoadsInWebContent Info plist key
>
> The old NSAllowsArbitraryLoads key is still required for backwards
> compatibility when running on old iOS versions.
>
> EarlGrey test targets need to download insecure images from
> browsingtest.appspot.com so add it as an exception domain in
> EarlGreyAddition+Info.plist.
>
> Bug: 622747
> Change-Id: Ide26330939035cd8a876612dc659c48a6e2bd9fc
> Reviewed-on: https://chromium-review.googlesource.com/568791
> Reviewed-by: Eugene But <[email protected]>
> Commit-Queue: Mike Dougherty <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#486376}

[email protected], [email protected]


(cherry picked from commit f0b26ec18040e2111c7c847de98a4160fbf17ede)

Bug: 622747
Change-Id: If3b5cb105118d301fba67ef9b1d4c46859399022
Reviewed-on: https://chromium-review.googlesource.com/580524
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488561}
Reviewed-on: https://chromium-review.googlesource.com/586968
Cr-Commit-Position: refs/branch-heads/3163@{#58}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ios/chrome/app/resources/EarlGreyAddition+Info.plist[diff]
• ios/chrome/app/resources/Info.plist[diff]

audio_renderer_impl.cc: Only include media_switches.h on Windows.

media_switches is only used in audio_renderer_impl on Windows, so we
should only include it on Windows as well.

BUG=747229
[email protected]

(cherry picked from commit ca2051b6170d833a504c8b2d9138a4171d64b8c9)

Change-Id: Ic4ee05430379bd31fdfd3f609111330773bc8275
Reviewed-on: https://chromium-review.googlesource.com/581196
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Anita Woodruff <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488959}
Reviewed-on: https://chromium-review.googlesource.com/586714
Reviewed-by: Anita Woodruff <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#57}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• media/renderers/audio_renderer_impl.cc[diff]

Disable the FindReply beeps during a tab's shutdown.

Fix the system beep that happen when closing a tab in some situations
(see this repro: https://bugs.chromium.org/p/chromium/issues/detail?id=682299#c56)

This is probably not the best way to fix this bug but it's probably a
sufficient workaround until we find a better fix.

[email protected]

(cherry picked from commit cf97ed5bc86f3ec5ede7392671b7cc2e6d9a85dd)

Bug: 682299
Change-Id: I3a6c08cb01d3c2f6de1a8a2fee53a43eefde1e4d
Reviewed-on: https://chromium-review.googlesource.com/581571
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Paul Meyer <[email protected]>
Commit-Queue: Sébastien Marchand <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489146}
Reviewed-on: https://chromium-review.googlesource.com/586918
Reviewed-by: Sébastien Marchand <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#56}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• content/browser/web_contents/web_contents_impl.cc[diff]

customtabs: Always call CustomTabsConnection.onHandledIntent().

Previously, only new intents going to the current active session would go
through CustomTabsConnection.onHandledIntent(), which is not the
intended behavior, as this is used to trigger preconnection to redirect
endpoints.

[email protected]

(cherry picked from commit 67e17f3964ba1388b9b14c8d423d0441d210a94b)

Bug: 739165
Change-Id: Ie9da5dcf4e25f4d0ca2044cba20956a316f7a253
Reviewed-on: https://chromium-review.googlesource.com/581110
Commit-Queue: Benoit L <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488952}
Reviewed-on: https://chromium-review.googlesource.com/586551
Reviewed-by: Benoit L <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#55}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java[diff]

Fix an issue where touch events were dispatched to the incorrect webview

Was caused by touchscreen_gesture_target_queue_ + prevent default.  The
webview target was calculated on TouchStart and pushed to the the queue.
It was removed on its corresponding GestureTapDown.  However, if the
TouchStart had default behavior prevented, no GestureTapDown would ever
occur, and the queue would forever have an extra element.

Fixed by converting touchscreen_gesture_target_queue_ to a map with
unique_touch_event_id as keys and gesture target data as values.

Also updates AUTHORS file.

[email protected]

(cherry picked from commit 09a2f88ea04da4884e9d3c3820385c5cc8879c32)

Bug: 736623, 739831
Change-Id: If3bf844e2bcfb9a1ca6d6a56cdc7575e0767e6b6
Reviewed-on: https://chromium-review.googlesource.com/547669
Commit-Queue: James MacLean <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488759}
Reviewed-on: https://chromium-review.googlesource.com/586747
Cr-Commit-Position: refs/branch-heads/3163@{#54}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• AUTHORS[diff]
• content/browser/renderer_host/render_widget_host_input_event_router.cc[diff]
• content/browser/renderer_host/render_widget_host_input_event_router.h[diff]
• content/browser/renderer_host/render_widget_host_view_android.cc[diff]
• content/browser/renderer_host/render_widget_host_view_aura.cc[diff]
• content/browser/site_per_process_browsertest.cc[diff]
• content/test/data/page_with_touch_start_default_prevented.html[Added - diff]

Log site engagement scores for permission actions

This patch adds histograms for tracking site engagement scores for
permission prompts, Permissions.Engagement.[Action].[Permission].

BUG=731349
[email protected]

(cherry picked from commit 102eac87872ad8b399aeec59422e4f270826563f)

Review-Url: https://codereview.chromium.org/2952003003
Cr-Original-Commit-Position: refs/heads/master@{#488573}
Change-Id: I4b10ae633ba54e6f3c2af22058af95a2a55391ab
Reviewed-on: https://chromium-review.googlesource.com/584561
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#53}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/permissions/mock_permission_request.cc[diff]
• chrome/browser/permissions/permission_request.cc[diff]
• chrome/browser/permissions/permission_request.h[diff]
• chrome/browser/permissions/permission_request_manager.cc[diff]
• chrome/browser/permissions/permission_request_manager.h[diff]
• chrome/browser/permissions/permission_request_manager_unittest.cc[diff]
• chrome/browser/permissions/permission_uma_util.cc[diff]
• chrome/browser/permissions/permission_uma_util.h[diff]
• tools/metrics/histograms/histograms.xml[diff]

Consume mouse button events on toolbar

A regression was letting mouse button click events on toolbar
to be passed down to content layer, and causing the content
hidden behind the toolbar react to the events as well, while
they should have triggered corresponding action on the toolbar
only. This CL stop the leak.

BUG=740855
NOTRY=true
NOPRESUBMIT=true
[email protected]

(cherry picked from commit ddd3b95b86917f5c0e61563689762219bad18d87)

Change-Id: I3e0e3ede01ba73d589b3d3e3fa3a55b2577c0957
Reviewed-on: https://chromium-review.googlesource.com/582053
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489123}
Reviewed-on: https://chromium-review.googlesource.com/585509
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#52}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java[diff]

ChromeOS OOBE: update HID detection screen icons to SVG.

[email protected]

(cherry picked from commit 6c33b71d310550eaed2d3819531d941899509338)

Bug: 747138
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77e1b33f74f91e5918d9a74f9a79cd8b0de79fc6
Reviewed-on: https://chromium-review.googlesource.com/580675
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488794}
Reviewed-on: https://chromium-review.googlesource.com/585676
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#51}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/chromeos/login/oobe_hid_detection.css[diff]
• chrome/browser/resources/chromeos/login/oobe_hid_detection.html[diff]

Chrome OS: Adjust size of a hyperlink on the EULA screen.

This CL makes keyboard focus highlighting match the text size of a
hyperlink on the EULA screen.

[email protected]

(cherry picked from commit c2c6e0a1055c560d6c29d99b119ff95aacd93e60)

Bug: 732324
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifbfed41f7c52e0089d780917a5431638a92d9476
Reviewed-on: https://chromium-review.googlesource.com/580431
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488786}
Reviewed-on: https://chromium-review.googlesource.com/585898
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#50}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/chromeos/login/oobe_eula.css[diff]

Chromeos: use rounded border for Gaia frame.

This CL makes Gaia screen match other OOBE screens design.

[email protected]

(cherry picked from commit 734af4879ae28fa14c5dd97358be8a4ebab925dd)

Bug: 747103
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idfb6b58ce7d7721b4a33856280d1123165be4247
Reviewed-on: https://chromium-review.googlesource.com/580615
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488542}
Reviewed-on: https://chromium-review.googlesource.com/585674
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#49}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/resources/chromeos/login/screen_gaia_signin.css[diff]

[Merge to M-61] Disallow hardware mirroring when displays are on different devices

This will revert back to software mirroring, since hardware mirroring
won't work and will result in a black screen.

[email protected]
BUG=b/35583078

(cherry picked from commit fba7ceb692b9f2d2a856b12fe7746cf1d42f64ac)

Change-Id: Id8496c5966554f5fa866812cd87fc87e3ddd4a92
Reviewed-on: https://chromium-review.googlesource.com/575669
Reviewed-by: Daniele Castagna <[email protected]>
Reviewed-by: Stéphane Marchesin <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488779}
Reviewed-on: https://chromium-review.googlesource.com/585111
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#48}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• ui/display/manager/chromeos/display_configurator.cc[diff]

Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12 id:330001 of https://codereview.chromium.org/2978443002/ )

Reason for revert:
Wasn't thinking when I landed this just before branch.

Original issue's description:
> Make ProfileIOData use URLRequestContextBuilder
>
> BUG=734199
>
> Review-Url: https://codereview.chromium.org/2978443002
> Cr-Commit-Position: refs/heads/master@{#487590}
> Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f

[email protected], [email protected]
BUG=734199,746576#c3

(cherry picked from commit 8636cbd6b9449dd374d6879b6fad0e8ed7bf61de)

Review-Url: https://codereview.chromium.org/2986623002
Cr-Original-Commit-Position: refs/heads/master@{#488562}
Change-Id: Iff1b60065f76c6fad9aea8e82c5fa7a3ff584ebc
Reviewed-on: https://chromium-review.googlesource.com/585894
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#47}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/io_thread.cc[diff]
• chrome/browser/io_thread.h[diff]
• chrome/browser/net/proxy_service_factory.cc[diff]
• chrome/browser/net/proxy_service_factory.h[diff]
• chrome/browser/profiles/off_the_record_profile_io_data.cc[diff]
• chrome/browser/profiles/off_the_record_profile_io_data.h[diff]
• chrome/browser/profiles/profile_impl_io_data.cc[diff]
• chrome/browser/profiles/profile_impl_io_data.h[diff]
• chrome/browser/profiles/profile_io_data.cc[diff]
• chrome/browser/profiles/profile_io_data.h[diff]
• net/url_request/url_request_context_builder.cc[diff]
• net/url_request/url_request_context_builder.h[diff]

[Merge to M-61] Fix bugs leading to spamming the feedback server with unsent corrupt reports

The feedback uploader can spam the server with tons of instances of the exact
same report due to the following:

1) Corrupted reports will be retied once every 60 minutes and on every login.
   Each retry will fail with the exact same ClientError, so there's no point
   in retrying.
2) FeedbackProfileObserver and FeedbackUploader were using two different types
   of task runners with different threads from their blocking pools. This can
   lead to a race condition (when corrupted reports are being resent on login)
   between the thread that reads the unsent file, and the thread that rewrites
   the file before it's attempted to be resent.

This CL:

- Fixes (1) by introducing an exponential backoff delay on failures other
  than ClientErrors, and not retry on Client Errors.
- Fixes (2) by using the same type of SingleThreadTaskRunner for all feedback
  background tasks to ensure sequencing and thread affinity.
- Adds some tests.

[email protected]
BUG=739885
TEST=adds new tests.

(cherry picked from commit af8ab059dc73831fb7a40a1d4fa1c8b967aec249)

Change-Id: Ia80afbb77349444a02321f22754d3d89cd536507
Reviewed-on: https://chromium-review.googlesource.com/564304
Reviewed-by: Rahul Chaturvedi <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488758}
Reviewed-on: https://chromium-review.googlesource.com/585175
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#46}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/browser/feedback/feedback_profile_observer.cc[diff]
• components/feedback/feedback_data_unittest.cc[diff]
• components/feedback/feedback_report.cc[diff]
• components/feedback/feedback_report.h[diff]
• components/feedback/feedback_uploader.cc[diff]
• components/feedback/feedback_uploader.h[diff]
• components/feedback/feedback_uploader_chrome.cc[diff]
• components/feedback/feedback_uploader_chrome.h[diff]
• components/feedback/feedback_uploader_chrome_unittest.cc[diff]
• components/feedback/feedback_uploader_delegate.cc[diff]
• components/feedback/feedback_uploader_delegate.h[diff]
• components/feedback/feedback_uploader_factory.cc[diff]
• components/feedback/feedback_uploader_factory.h[diff]
• components/feedback/feedback_uploader_unittest.cc[diff]

Incrementing VERSION to 61.0.3163.14

[email protected]

Change-Id: Ia1148c4be64ffcd3ee3fc7bde4bf85b16c832d7d
Reviewed-on: https://chromium-review.googlesource.com/585833
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#45}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}

• chrome/VERSION[diff]