Publish DEPS for Chromium 59.0.3071.71

• DEPS[diff]

Incrementing VERSION to 59.0.3071.71

Cr-Commit-Position: refs/branch-heads/3071@{#680}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

Merge 59: Support NV12 textures in VideoTrackRecorder

Bug: 725274
Test: Tested on Win H264 decoded output.
Change-Id: I65695e763110d13e3d698c0b288272d511df676f
Reviewed-on: https://chromium-review.googlesource.com/511188
Reviewed-by: Miguel Casas <[email protected]>
Commit-Queue: Emircan Uysaler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#473820}
Review-Url: https://codereview.chromium.org/2901863003
Cr-Commit-Position: refs/branch-heads/3071@{#679}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• content/renderer/media_recorder/video_track_recorder.cc[diff]

Re-hook up surfaceRedrawNeededAsync callback.

This method was accidentally left unimplemented after
CompositorSurfaceManager was made the canonical SurfaceHolder.Callback2
implementation, leaving the CompositorView one dangling with no
callsites.  Because https://codereview.chromium.org/2201483002 also
changed it so that SurfaceViews are created later, at native library
load time, and always visible, bringing this back does not bring back
the black flicker associated with implementing this method on an
invisible View.  So we can safely reimplement it.

I changed CompositorView to inherit from a new interface because
surfaceRedrawNeededAsync is still not exposed in the SDK.

(In the future, we can also look into attaching the opaque SurfaceView
as early as possible -- instead of when the native library is loaded --
in order to avoid a flicker of View system content, given that this
callback should block the system from drawing until it's ready.)

BUG=512636
[email protected]

(cherry picked from commit 5e7b4d978a2b9a272fecf89d28562e9b724f53e5)

Review-Url: https://codereview.chromium.org/2893833005
Cr-Original-Commit-Position: refs/heads/master@{#473414}
Change-Id: Ie55f2f405022e109a2f8ebdfd9a28ea8ff047ab6
Reviewed-on: https://chromium-review.googlesource.com/513424
Reviewed-by: Alexandre Elias <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#678}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManager.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java[diff]
• chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerTest.java[diff]

[Merge to M59] Gracefully exit CanCreateProcessInNewUserNS for expected failure cases

> The only functional change that this CL makes is a check that
> /proc/self/gid_map and /proc/self/uid_map exist before writing to them.
>
> BUG=685717
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2817813002
> Cr-Commit-Position: refs/heads/master@{#464793}

[email protected]
BUG=685717
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2901823004
Cr-Commit-Position: refs/branch-heads/3071@{#677}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• sandbox/linux/services/credentials.cc[diff]

Don't update the save card bubble icon once the browser isn't available.

If a tab showing the save credit card buble is closed while the bubble
is still visible, the bubble will attempt to update the icon in the
location bar. Because the browser object is no longer available, this
causes a crash.

Note that this doesn't happen in the common case where the user
closes the tab by clicking on the tab close icon (x) because that action
closes the bubble first. But if the user closes the tab via a keyboard
shortcut or a page closes a child tab via javascript, then the crash
occurs.

BUG=694188

Review-Url: https://codereview.chromium.org/2887183005
Cr-Original-Commit-Position: refs/heads/master@{#473353}
Review-Url: https://codereview.chromium.org/2897113003 .
Cr-Commit-Position: refs/branch-heads/3071@{#676}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc[diff]

[Extensions] Remove external errors on profile shutdown

When an external error is deleted, it removes itself from the global
error service. Make sure to do this before the profile's services are
shut down by watching for the profile deleted notification.

Add a regression test.

BUG=720081

Review-Url: https://codereview.chromium.org/2885143003
Cr-Original-Commit-Position: refs/heads/master@{#472863}
Review-Url: https://codereview.chromium.org/2896293003 .
Cr-Commit-Position: refs/branch-heads/3071@{#675}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/extensions/external_install_error.cc[diff]
• chrome/browser/extensions/external_install_error_browsertest.cc[Added - diff]
• chrome/browser/extensions/external_install_manager.cc[diff]
• chrome/test/BUILD.gn[diff]

Gtk: Consider font dpi when calculating device scale factor

> Gtk2 did not have a global window scaling setting (so the only way to
> scale up widgets was with a custom theme).  However, it did allow font
> scaling with gdk-xft-dpi (backed by XSetting Xft/DPI).
>
> Gtk3 adds (non-fractional) global window scaling with
> gdk-window-scaling-factor (XSetting Gdk/WindowScalingFactor).  To
> ensure that fonts were not scaled up twice (once from
> gdk-window-scaling-factor and once from gdk-xft-dpi), a new setting
> was added in [1] that overrides gdk-xft-dpi: gdk-unscaled-dpi
> (XSetting Gdk/UnscaledDPI).  gdk-xft-dpi was kept around for
> compatibility with apps like Chromium that still need it.
>
> When modifying these settings, an invariant should be maintained:
> gdk-xft-dpi = gtk-window-scaling-factor * gdk-unscaled-dpi.  Chromium
> should have been able to keep using gdk-xft-dpi, but this invariant is
> violated when changing the settings using gnome-tweak-tool, where I
> have gdk-window-scaling-factor = 2, gdk-unscaled-dpi = 98304, and
> gdk-xft-dpi = 98304 (gdk-xft-dpi should be 196608).
>
> [2] changed Gtk builds to use the window scaling factor, which is
> incorrect because it did not consider font scaling, making fractional
> scaling impossible.
>
> This CL takes gdk-unscaled-dpi into the calculation as well, and
> continues to fallback on using gdk-xft-dpi if the other variables are
> unavailable, which can happen on Gtk2.
>
> [1] https://git.gnome.org/browse/gtk+/commit/?id=4b9c08f48d6f5be43b0795d3eee462d60b5f9e1f
> [2] https://codereview.chromium.org/2869763004
>
> BUG=723931
> [email protected],[email protected]
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2899943002
> Cr-Commit-Position: refs/heads/master@{#473966}

BUG=723931
[email protected]
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2900133002
Cr-Commit-Position: refs/branch-heads/3071@{#674}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/ui/libgtkui/gtk_ui.cc[diff]

Revert of [Cast,Android] Replace custom MediaController with android.widget.MediaController. (patchset #1 id:1 of https://codereview.chromium.org/2888273002/ )

Reason for revert:
Caused https://bugs.chromium.org/p/chromium/issues/detail?id=725028 and is not needed for 59 yet.

NOTRY=true
NOPRESUBMIT=true

Original issue's description:
> [Cast,Android] Replace custom MediaController with android.widget.MediaController.
>
> BUG=722688
> TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls)
>
> Review-Url: https://codereview.chromium.org/2888653002
> Cr-Original-Commit-Position: refs/heads/master@{#472583}
> Review-Url: https://codereview.chromium.org/2888273002 .
> Cr-Commit-Position: refs/branch-heads/3071@{#613}
> Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
> Committed: https://chromium.googlesource.com/chromium/src/+/eda6f4cf4ff69bea98350b37c43609fae020175c

TBR=
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=722688

Review-Url: https://codereview.chromium.org/2899033002
Cr-Commit-Position: refs/branch-heads/3071@{#673}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/BUILD.gn[diff]
• chrome/android/java/res/layout/expanded_cast_controller.xml[diff]
• chrome/android/java/res/values/colors.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java[diff]
• third_party/android_media/BUILD.gn[Added - diff]
• third_party/android_media/LICENSE[Added - diff]
• third_party/android_media/OWNERS[Added - diff]
• third_party/android_media/README.chromium[Added - diff]
• third_party/android_media/java/res/layout/media_controller.xml[Added - diff]
• third_party/android_media/java/res/values/colors.xml[Added - diff]
• third_party/android_media/java/src/org/chromium/third_party/android/media/MediaController.java[Added - diff]
• tools/android/eclipse/.classpath[diff]

Updating XTBs based on .GRDs from branch 3071

Cr-Commit-Position: refs/branch-heads/3071@{#672}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ash/strings/ash_strings_ca.xtb[diff]
• ash/strings/ash_strings_sw.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_it.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_id.xtb[diff]
• chrome/app/resources/generated_resources_it.xtb[diff]
• chrome/app/resources/generated_resources_pt-PT.xtb[diff]
• chrome/app/resources/generated_resources_sw.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb[diff]
• components/policy/resources/policy_templates_pt-PT.xtb[diff]
• components/policy/resources/policy_templates_sv.xtb[diff]
• components/policy/resources/policy_templates_sw.xtb[diff]
• components/strings/components_strings_it.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_id.xtb[diff]
• ui/accessibility/extensions/strings/accessibility_extensions_strings_sw.xtb[diff]

Merge 59: [Android WebAPK] Don't navigate WebAPK as a result of WindowClient.focus()

This CL makes WindowClient.Focus() not navigate the WebAPK if the WebAPK is
already open.

When a user taps on a Twitter notification, the following race condition occurs:
- The service worker uses postMessage() and the main page navigates by setting
  window.location.href
- The service worker calls WindowClient.Focus(). This causes a navigation to
  the current page

This CL will remove the race by making WindowClient.Focus() not do any
navigation if the WebAPK is already running

BUG=711011

Review-Url: https://codereview.chromium.org/2849873002
Cr-Original-Commit-Position: refs/heads/master@{#472327}
Review-Url: https://codereview.chromium.org/2901013002 .
Cr-Commit-Position: refs/branch-heads/3071@{#671}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java[diff]
• chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkNavigationClient.java[diff]
• chrome/android/webapk/shell_apk/shell_apk_version.gni[diff]
• chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java[diff]

Fix WebApkActivity not launching on Samsung Galaxy Grand Prime

This CL makes launching the WebApkActivity more similar to how a WebappActivity
is launched.

BUG=697211

Review-Url: https://codereview.chromium.org/2889123002
Cr-Original-Commit-Position: refs/heads/master@{#472898}
Review-Url: https://codereview.chromium.org/2899023002 .
Cr-Commit-Position: refs/branch-heads/3071@{#670}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/AndroidManifest.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java[diff]

Prevent access to null handler in RTCDataChannel.

BUG=717872,717912

Review-Url: https://codereview.chromium.org/2888043003
Cr-Original-Commit-Position: refs/heads/master@{#473566}
Review-Url: https://codereview.chromium.org/2900013002 .
Cr-Commit-Position: refs/branch-heads/3071@{#669}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp[diff]
• third_party/WebKit/Source/modules/peerconnection/RTCDataChannelTest.cpp[diff]

Handle missing toolbar data provider when updating the Google G in the omnibox.

This can happen during startup when the ToolbarManager is not
initialized yet.

BUG=712379
[email protected]

(cherry picked from commit 67008fa2e25fa38b319efb52ab189c3aabfc1991)

Review-Url: https://codereview.chromium.org/2820063004
Cr-Original-Commit-Position: refs/heads/master@{#465549}
Change-Id: I465e492bba37eb4a9155d94ecf3749b913d84857
Reviewed-on: https://chromium-review.googlesource.com/512183
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#668}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java[diff]

Don't access the HostContentSettingsMap in ~PermissionManager

As PermissionManager and HostContentSettingsMap are both KeyedServices,
it is disallowed to access one from the other in the destructor. This
patch moves the logic in ~PermissionManager to Shutdown().

BUG=720071

Review-Url: https://codereview.chromium.org/2884173002
Cr-Original-Commit-Position: refs/heads/master@{#472367}
Review-Url: https://codereview.chromium.org/2896943003 .
Cr-Commit-Position: refs/branch-heads/3071@{#667}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/permissions/permission_manager.cc[diff]
• chrome/browser/permissions/permission_manager.h[diff]
• chrome/browser/permissions/permission_manager_unittest.cc[diff]

Merge M59: Update Flash plugin metadata versions to latest version.

https://helpx.adobe.com/security/products/flash-player/apsb17-15.html

BUG=412078
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]

Review-Url: https://codereview.chromium.org/2898643002
Cr-Commit-Position: refs/heads/master@{#473497}
(cherry picked from commit afc8ebc4ba61cd7ee7780c868794bccfc499539a)

git cherry-pick -x afc8ebc4ba61cd7ee7780c868794bccfc499539a --strategy-option=theirs

Review-Url: https://codereview.chromium.org/2897943005 .
Cr-Commit-Position: refs/branch-heads/3071@{#666}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/resources/plugin_metadata/plugins_linux.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_mac.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_win.json[diff]

[Merge to M59] Touch memory ablation payload in chunks.

It was discovered that touching (to dirty pages) large regions of
memory can be very costly on Android (~60ms per 10MiB on Nexus 5).
We touch on IO thread, but still, it's better not to block it for
long periods.

With this CL we'll touch the ablation payload in chunks and we'll
schedule each touch individually to let other things to happen in
between.

BUG=710048

Review-Url: https://codereview.chromium.org/2896523004
Cr-Original-Commit-Position: refs/heads/master@{#473459}
Review-Url: https://codereview.chromium.org/2896963002 .
Cr-Commit-Position: refs/branch-heads/3071@{#665}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/experiments/memory_ablation_experiment.cc[diff]
• chrome/browser/experiments/memory_ablation_experiment.h[diff]

Incrementing VERSION to 59.0.3071.70

Cr-Commit-Position: refs/branch-heads/3071@{#664}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

Update scaling of video layers on every swap.

The scale factor can change even if the image itself doesn't change,
so the variables need to be updated before that early-out.

BUG=654631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2888783002
Cr-Original-Commit-Position: refs/heads/master@{#473380}
Review-Url: https://codereview.chromium.org/2900893002 .
Cr-Commit-Position: refs/branch-heads/3071@{#663}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• gpu/ipc/service/direct_composition_surface_win.cc[diff]
• gpu/ipc/service/direct_composition_surface_win_unittest.cc[diff]

Wait for GPU to finish before committing first video overlay frame.

The current code to do CopyResource helps in some cases, but with 4k
videos it still may flicker black before the first frame. Waiting for
the GPU commands to execute before the commit seems to help.

BUG=654631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2892123002
Cr-Original-Commit-Position: refs/heads/master@{#473373}
Review-Url: https://codereview.chromium.org/2896723004 .
Cr-Commit-Position: refs/branch-heads/3071@{#662}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• gpu/ipc/service/direct_composition_surface_win.cc[diff]

Check Null view in LayoutObjectChildList::InvalidatePaintOnRemoval()

BUG=720931
[email protected]
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2894573005
Cr-Original-Commit-Position: refs/heads/master@{#473289}
Review-Url: https://codereview.chromium.org/2895173004
Cr-Commit-Position: refs/branch-heads/3071@{#661}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp[diff]

Copy the cert's refptr to the stack to avoid use-after-free crasher.

The previous code directly used the reference passed as an argument.
However, ObjC blocks treats C++ references as raw pointers, and do not
extend the scope of objects referenced within.  Copying the refptr to
the stack correctly extends the lifetime of the object.

BUG=715292

Review-Url: https://codereview.chromium.org/2894093003
Cr-Original-Commit-Position: refs/heads/master@{#473248}
Review-Url: https://codereview.chromium.org/2899903002 .
Cr-Commit-Position: refs/branch-heads/3071@{#660}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ios/web/web_state/session_certificate_policy_cache_impl.mm[diff]

Don't attempt to open an NTP on becoming active multiple times.

Dismissing an system alert (like the micophone permissions prompt) will
send another |-applicationDidBecomeActive:| call to the app delegate.
This CL resets AppState's |_shouldOpenNTPTabOnActive| to NO regardless
of whether there were startup parameters so that dismissing a system
alert doesn't attempt to display another NTP.

BUG=701340

Review-Url: https://codereview.chromium.org/2872063002
Cr-Original-Commit-Position: refs/heads/master@{#471336}
Review-Url: https://codereview.chromium.org/2896093002 .
Cr-Commit-Position: refs/branch-heads/3071@{#659}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ios/chrome/app/application_delegate/app_state.mm[diff]

Incrementing VERSION to 59.0.3071.69

Cr-Commit-Position: refs/branch-heads/3071@{#658}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

Revert of Don't use the manifest brand color when a PWA is in immersive fullscreen. (patchset #1 id:1 of https://codereview.chromium.org/2900593003/ )

Reason for revert:
Breaks build

../../chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java:621: error: cannot find symbol
        if (mBrandColor != null && mWebappInfo.displayMode() != WebDisplayMode.FULLSCREEN) {

Original issue's description:
> Don't use the manifest brand color when a PWA is in immersive fullscreen.
>
> When in display: fullscreen, the status and navigation bars on Android
> are hidden, and can be swiped in by users if desired. The bars also
> appear if the on-screen keyboard is triggered. However, the bars
> sometimes appear as completely transparent, which hurts their usability.
>
> This CL explicitly sets the status bar color to black if a PWA is launched
> in display: fullscreen, and ignores the brand color specified in the web
> app manifest. This ensures that the status and navigation bars always
> have a solid black background and do not appear as transparent. Since
> PWAs that are open in display: fullscreen have the bars hidden most of
> the time, having a black color does not overly affect the native fit and
> feel too much.
>
> BUG=714704,716686
>
> Review-Url: https://codereview.chromium.org/2871103002
> Cr-Original-Commit-Position: refs/heads/master@{#470762}
> Review-Url: https://codereview.chromium.org/2900593003 .
> Cr-Commit-Position: refs/branch-heads/3071@{#646}
> Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
> Committed: https://chromium.googlesource.com/chromium/src/+/8fc052bc58d3adbc8c6f6e13109da6e733f8ee20

[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=714704,716686

Review-Url: https://codereview.chromium.org/2893413002
Cr-Commit-Position: refs/branch-heads/3071@{#657}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java[diff]

Incrementing VERSION to 59.0.3071.68

Cr-Commit-Position: refs/branch-heads/3071@{#656}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

MD Settings: add missing Mac-only "tab to links" pref

[email protected]
BUG=711680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888303006
Cr-Original-Commit-Position: refs/heads/master@{#473039}
Review-Url: https://codereview.chromium.org/2895943003 .
Cr-Commit-Position: refs/branch-heads/3071@{#655}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/extensions/api/settings_private/prefs_util.cc[diff]
• chrome/browser/resources/settings/appearance_page/appearance_page.html[diff]
• chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc[diff]

Fix for HTTP2 request hanging bug.

If, when a socket request completed asynchronously, the next
socket request in the queue failed synchronously,
ClientSocketPoolBase wouldn't continue to try to service other
socket requests in the queue.

As a result, the socket pools could end up with pending connect
requests and free socket slots, but no ConnectJobs would be made
to service them, if this happened 6 times in a row to a socket
group.

This was a relatively obscure issue, until H2 started depending
on this path for sharing sessions when different domains map to
the same IP.

BUG=723748

Review-Url: https://codereview.chromium.org/2888623011
Cr-Original-Commit-Position: refs/heads/master@{#472952}
Review-Url: https://codereview.chromium.org/2896883002 .
Cr-Commit-Position: refs/branch-heads/3071@{#654}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• net/socket/client_socket_pool_base.cc[diff]
• net/socket/client_socket_pool_base_unittest.cc[diff]

Merge "cros: Fix "close" button visible during sign-in"

> Fix a typo that leaves "close" button visible after sign-in
> starts. Just before we finish sign-in, login screen UI is
> re-enabled and if user clicks on the button at this very moment,
> it would trigger gaia reload which would do sign-in profile
> clean up. This would cause post login actions such as cookies
> to oauth2 token exchange failure (for SAML users).
>
> BUG=677312
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2891373003
> Cr-Commit-Position: refs/heads/master@{#473418}
> (cherry picked from commit 037910102420f21a96f535ad4e3549426dcb0f4f)

Review-Url: https://codereview.chromium.org/2896013002 .
Cr-Commit-Position: refs/branch-heads/3071@{#653}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/resources/chromeos/login/screen_gaia_signin.js[diff]

Detect frames from rotated devices in VideoTrackAdapter on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823

Review-Url: https://codereview.chromium.org/2870413004
Cr-Original-Commit-Position: refs/heads/master@{#472057}
Review-Url: https://codereview.chromium.org/2897993002 .
Cr-Commit-Position: refs/branch-heads/3071@{#652}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• content/renderer/media/media_stream_constraints_util.cc[diff]
• content/renderer/media/media_stream_constraints_util.h[diff]
• content/renderer/media/media_stream_constraints_util_unittest.cc[diff]
• content/renderer/media/media_stream_constraints_util_video_content.cc[diff]
• content/renderer/media/media_stream_constraints_util_video_device.cc[diff]
• content/renderer/media/media_stream_video_source.cc[diff]
• content/renderer/media/media_stream_video_source_unittest.cc[diff]
• content/renderer/media/media_stream_video_track_unittest.cc[diff]
• content/renderer/media/video_track_adapter.cc[diff]
• content/renderer/media/video_track_adapter.h[diff]

Fix HeapObjectHeader::PayloadSize for LargeObject pages

The HeapObjectHeader::PayloadSize is meant to return the payload without the
HeapObjectHeader included. But NormalPage and LargeObjectPage return their
payload with the HeapObjectHeader included.

The payload size is used when tracing an on-stack HeapVector to determine its
length, so when the HeapObjectHeader is included it increases the length of the
vector by 8 bytes. If the size of the HeapVector's elements is <= 8, this will
increase the calculated length of the vector by one. Normally this isn't a
problem since the additional element will be null and not traced. But it is
possible to completely fill the page with a vector, in which case the GC will
access one element outside of the page.

BUG=chromium:719634
[email protected]

Review-Url: https://codereview.chromium.org/2873113003
Cr-Commit-Position: refs/heads/master@{#470857}
(cherry picked from commit 250314432e59da58f1793f87bc4fa7512973f54a)

Conflicts:
Review-Url: https://codereview.chromium.org/2895283002 .
Cr-Commit-Position: refs/branch-heads/3071@{#651}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/platform/heap/HeapPage.cpp[diff]
• third_party/WebKit/Source/platform/heap/HeapPage.h[diff]
• third_party/WebKit/Source/platform/heap/HeapTest.cpp[diff]

[Android WebView] Lower minidump generation fraction to 0.1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 0.1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

BUG=713670
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2891733002
Cr-Commit-Position: refs/branch-heads/3071@{#650}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc[diff]

When creating sockets for ioctl() use AF_INET6 or AF_INET

This fixes issues on IPv6-only linux computers.

BUG=694860

Review-Url: https://codereview.chromium.org/2890773002
Cr-Original-Commit-Position: refs/heads/master@{#472556}
Review-Url: https://codereview.chromium.org/2896823002 .
Cr-Commit-Position: refs/branch-heads/3071@{#649}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• net/base/address_tracker_linux.cc[diff]
• net/base/network_interfaces_linux.cc[diff]
• net/base/network_interfaces_linux.h[diff]

[Password Manager, merge to M-59] Make filling robust against changing url by JavaScript.

When PasswordAutofillAgent receives filling data from the browser, it checks that origin of this data is the same of the current frame origin. If JavaScript changes origin between PasswordAutofillAgent discovers a password form and when it receives filling, filling fails.

This CL replaces checking by origin to by checking by signon_realm (signon_realm=scheme:origin:port), which is a primary key for retrieving credentials from the store, so it doesn't change any security guarantees.

[email protected]

BUG=723679

Review-Url: https://codereview.chromium.org/2893633002
Cr-Original-Commit-Position: refs/heads/master@{#472839}
Review-Url: https://codereview.chromium.org/2900713003 .
Cr-Commit-Position: refs/branch-heads/3071@{#648}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/renderer/autofill/password_autofill_agent_browsertest.cc[diff]
• components/autofill/content/renderer/password_autofill_agent.cc[diff]
• components/autofill/content/renderer/password_form_conversion_utils.cc[diff]
• components/autofill/content/renderer/password_form_conversion_utils.h[diff]

[Notifications] Fix swipe to close for ARC notifications.

Change ArcCustomNotificationView::EventForwarder to not directly invoke On*Event methods of ArcCustomNotificationView (which then call up to the parent). Instead, re-dispatch them to the containing widget, which should handle the event propagation, letting SlideOutController get events as it should. A consequence of this is that I had to add a delegate method to SlideOutController to update ArcCustomNotificationView::SlideHelper. This is because ArcCustomNotificationView will no longer get the gesture events, since it is no longer being called directly from EventForwarder.

BUG=719407

Review-Url: https://codereview.chromium.org/2873553002
Cr-Commit-Position: refs/heads/master@{#473094}
(cherry picked from commit 870290f623b47e436d231e354c84b8723bb7000a)

Review-Url: https://codereview.chromium.org/2897903002 .
Cr-Commit-Position: refs/branch-heads/3071@{#647}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ui/arc/notification/arc_custom_notification_view.cc[diff]
• ui/arc/notification/arc_custom_notification_view.h[diff]
• ui/message_center/views/custom_notification_content_view_delegate.h[diff]
• ui/message_center/views/custom_notification_view.cc[diff]
• ui/message_center/views/custom_notification_view.h[diff]
• ui/message_center/views/custom_notification_view_unittest.cc[diff]
• ui/message_center/views/message_view.cc[diff]
• ui/message_center/views/message_view.h[diff]
• ui/message_center/views/slide_out_controller.cc[diff]
• ui/message_center/views/slide_out_controller.h[diff]

Don't use the manifest brand color when a PWA is in immersive fullscreen.

When in display: fullscreen, the status and navigation bars on Android
are hidden, and can be swiped in by users if desired. The bars also
appear if the on-screen keyboard is triggered. However, the bars
sometimes appear as completely transparent, which hurts their usability.

This CL explicitly sets the status bar color to black if a PWA is launched
in display: fullscreen, and ignores the brand color specified in the web
app manifest. This ensures that the status and navigation bars always
have a solid black background and do not appear as transparent. Since
PWAs that are open in display: fullscreen have the bars hidden most of
the time, having a black color does not overly affect the native fit and
feel too much.

BUG=714704,716686

Review-Url: https://codereview.chromium.org/2871103002
Cr-Original-Commit-Position: refs/heads/master@{#470762}
Review-Url: https://codereview.chromium.org/2900593003 .
Cr-Commit-Position: refs/branch-heads/3071@{#646}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java[diff]

Incrementing VERSION to 59.0.3071.67

Cr-Commit-Position: refs/branch-heads/3071@{#645}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

Incrementing VERSION to 59.0.3071.66

Cr-Commit-Position: refs/branch-heads/3071@{#644}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

Image Capture: wire |exposureCompensation| in Linux/CrOs

This CL connects:
- reading of |exposureCompensation| in getPhotoCapabilities()
- configuring of |exposureCompensation| and |exposureMode| in
setPhotoOptions().

Bug: 723930
Change-Id: Ib3ceeacf1df34722fd274ebe935a1c890ae0c4c2
Reviewed-on: https://chromium-review.googlesource.com/508415
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#473027}
Review-Url: https://codereview.chromium.org/2890353003 .
Cr-Commit-Position: refs/branch-heads/3071@{#643}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• media/capture/video/linux/v4l2_capture_delegate.cc[diff]

[Merge to M59] Initialize GpuDataManagerImpl after GpuDataManagerVisualProxy

> Transparent visuals became broken in software rendering mode after
> [1], which caused GpuDataManagerVisualProxy to stop getting the
> initial OnGpuInfoUpdate() from GpuDataManagerImpl.  This CL moves the
> initialization of GDMI after GDMVP so this cannot happen.
>
> [1] https://codereview.chromium.org/2805933002
>
> [email protected]
> BUG=724297
>
> Review-Url: https://codereview.chromium.org/2892093002
> Cr-Commit-Position: refs/heads/master@{#473021}

[email protected]
BUG=724297
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2894673009
Cr-Commit-Position: refs/branch-heads/3071@{#642}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• content/browser/browser_main_loop.cc[diff]

Image Capture Mac: make setOptions() resolve the callback with true

This CL implements VideoCaptureDevice::setOptions() for Mac
so that we can resolve the callback with a true value --
setPhotoOptionsCallback on ToT resolves |callback| with false
if not explicitly Run() and Blink will think it has failed.

Bug: 723929
Change-Id: I2c9f0ec482538f7f1c389ea4bc970552fd39e324
Reviewed-on: https://chromium-review.googlesource.com/508183
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Vincent Scheib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#472994}
(cherry picked from commit 8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498)

NOTRY=True
NOPRESUBMIT=True
[email protected]

Review-Url: https://codereview.chromium.org/2895013003
Cr-Commit-Position: refs/branch-heads/3071@{#641}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• media/capture/video/mac/video_capture_device_mac.h[diff]
• media/capture/video/mac/video_capture_device_mac.mm[diff]

Incrementing VERSION to 59.0.3071.65

Cr-Commit-Position: refs/branch-heads/3071@{#640}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

[Android] Fix 'open in browser' in CCT does not work for images in Google image search

'Open in browser', 'Open in new Chrome tab' and 'Open in incognito tab'
in CCT don't work for images in Google image search. This is because
these images are both images and anchor. Their sourceUrls are data://
scheme which cannot be handled for Chrome for a View intent.

To fix the problem, since those images are also anchor and their linkUrl is
a valid url for View Intent in Chrome, thus sending linkUrl instead.
This CL also redesigns the logic for deciding the valid url of a
ContextMenuParams, that if the param is an anchor and its linkUrl is not
null, returns the linkUrl, otherwise returns the srcUrl.

BUG=720532
NOTRY=true
NOPRESUBMIT=true

Original-Review-Url: https://codereview.chromium.org/2891583004
Cr-Original-Commit-Position: refs/heads/master@{#473287}
Review-Url: https://codereview.chromium.org/2894293002
Cr-Commit-Position: refs/branch-heads/3071@{#639}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java[diff]

Make ARC's intent picker use the buttons insets.

Need to call SetupLayout via UpdateDialogButtons so the buttons make
proper use of the established insets.

Bug: 678141
Test: Try.
Review-Url: https://codereview.chromium.org/2874493002
Cr-Original-Commit-Position: refs/heads/master@{#472534}
Review-Url: https://codereview.chromium.org/2900443002 .
Cr-Commit-Position: refs/branch-heads/3071@{#638}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/ui/views/extensions/chooser_dialog_view.cc[diff]
• chrome/browser/ui/views/intent_picker_bubble_view.cc[diff]
• ui/views/bubble/bubble_dialog_delegate.cc[diff]
• ui/views/window/dialog_client_view.cc[diff]
• ui/views/window/dialog_client_view.h[diff]

[DevTools] breakpoint manager should be ready for location from different model

There is no gurantees for debugger model of location returned from uiLocationToRawLocation call.
BreakpointManager should be ready.

BUG=chromium:722715,chromium:721993
[email protected]

Review-Url: https://codereview.chromium.org/2889853002
Cr-Original-Commit-Position: refs/heads/master@{#472648}
Review-Url: https://codereview.chromium.org/2898473002 .
Cr-Commit-Position: refs/branch-heads/3071@{#637}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.html[Added - diff]
• third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js[diff]

Update checks for Android O to use generalized check

A couple of places in our code-based were hand-written to check for
whether the code was running on Android O, before we added support
for this through BuildInfo#isAtLeastO().

This CL makes them both call the generic method, so if that
generic method is changed, they will both benefit from that.

BUG=704209
[email protected]

(cherry picked from commit 0050d7e332eac8bb71e895989a7515d1a49d38c6)

Change-Id: I44b583af0744a67c889ef786eef7e6a96ddf8eed
Reviewed-on: https://chromium-review.googlesource.com/488129
Reviewed-by: Dan Alcantara <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#467585}
Reviewed-on: https://chromium-review.googlesource.com/509894
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#636}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/widget/ViewResourceFrameLayout.java[diff]

Updating XTBs based on .GRDs from branch 3071

Cr-Commit-Position: refs/branch-heads/3071@{#635}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/strings/translations/android_chrome_strings_ca.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_de.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_es.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_sl.xtb[diff]
• chrome/app/resources/address_input_strings_id.xtb[diff]
• chrome/app/resources/address_input_strings_sk.xtb[diff]
• chrome/app/resources/chromium_strings_pt-PT.xtb[diff]
• chrome/app/resources/generated_resources_am.xtb[diff]
• chrome/app/resources/generated_resources_ar.xtb[diff]
• chrome/app/resources/generated_resources_bg.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_cs.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_de.xtb[diff]
• chrome/app/resources/generated_resources_el.xtb[diff]
• chrome/app/resources/generated_resources_en-GB.xtb[diff]
• chrome/app/resources/generated_resources_es-419.xtb[diff]
• chrome/app/resources/generated_resources_es.xtb[diff]
• chrome/app/resources/generated_resources_et.xtb[diff]
• chrome/app/resources/generated_resources_fa.xtb[diff]
• chrome/app/resources/generated_resources_fi.xtb[diff]
• chrome/app/resources/generated_resources_fil.xtb[diff]
• chrome/app/resources/generated_resources_fr.xtb[diff]
• chrome/app/resources/generated_resources_gu.xtb[diff]
• chrome/app/resources/generated_resources_hi.xtb[diff]
• chrome/app/resources/generated_resources_hr.xtb[diff]
• chrome/app/resources/generated_resources_hu.xtb[diff]
• chrome/app/resources/generated_resources_id.xtb[diff]
• chrome/app/resources/generated_resources_it.xtb[diff]
• chrome/app/resources/generated_resources_iw.xtb[diff]
• chrome/app/resources/generated_resources_ja.xtb[diff]
• chrome/app/resources/generated_resources_kn.xtb[diff]
• chrome/app/resources/generated_resources_ko.xtb[diff]
• chrome/app/resources/generated_resources_lt.xtb[diff]
• chrome/app/resources/generated_resources_lv.xtb[diff]
• chrome/app/resources/generated_resources_ml.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_ms.xtb[diff]
• chrome/app/resources/generated_resources_nl.xtb[diff]
• chrome/app/resources/generated_resources_no.xtb[diff]
• chrome/app/resources/generated_resources_pl.xtb[diff]
• chrome/app/resources/generated_resources_pt-BR.xtb[diff]
• chrome/app/resources/generated_resources_pt-PT.xtb[diff]
• chrome/app/resources/generated_resources_ro.xtb[diff]
• chrome/app/resources/generated_resources_ru.xtb[diff]
• chrome/app/resources/generated_resources_sk.xtb[diff]
• chrome/app/resources/generated_resources_sl.xtb[diff]
• chrome/app/resources/generated_resources_sr.xtb[diff]
• chrome/app/resources/generated_resources_sv.xtb[diff]
• chrome/app/resources/generated_resources_sw.xtb[diff]
• chrome/app/resources/generated_resources_ta.xtb[diff]
• chrome/app/resources/generated_resources_te.xtb[diff]
• chrome/app/resources/generated_resources_th.xtb[diff]
• chrome/app/resources/generated_resources_tr.xtb[diff]
• chrome/app/resources/generated_resources_uk.xtb[diff]
• chrome/app/resources/generated_resources_vi.xtb[diff]
• chrome/app/resources/generated_resources_zh-CN.xtb[diff]
• chrome/app/resources/generated_resources_zh-TW.xtb[diff]
• chrome/app/resources/google_chrome_strings_pt-PT.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb[diff]
• components/policy/resources/policy_templates_de.xtb[diff]
• components/policy/resources/policy_templates_fa.xtb[diff]
• components/strings/components_strings_de.xtb[diff]
• components/strings/components_strings_es.xtb[diff]
• components/strings/components_strings_fr.xtb[diff]
• components/strings/components_strings_pt-BR.xtb[diff]
• components/strings/components_strings_pt-PT.xtb[diff]
• components/strings/components_strings_sk.xtb[diff]
• content/app/strings/translations/content_strings_da.xtb[diff]
• content/public/android/java/strings/translations/android_content_strings_nl.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_es.xtb[diff]
• remoting/resources/remoting_strings_da.xtb[diff]
• remoting/resources/remoting_strings_sw.xtb[diff]
• ui/strings/translations/ui_strings_pt-PT.xtb[diff]

Parallelizable download metrics.

Add average bandwidth, download time, and file size metrics for
parallelizable downloads.

Also add some suffixes to categorize these 3 metrics with file size.

BUG=723139

Review-Url: https://codereview.chromium.org/2885793004
Cr-Original-Commit-Position: refs/heads/master@{#473033}
Review-Url: https://codereview.chromium.org/2894833004 .
Cr-Commit-Position: refs/branch-heads/3071@{#634}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• content/browser/download/download_stats.cc[diff]
• content/browser/download/download_stats.h[diff]
• content/browser/download/download_stats_unittest.cc[Added - diff]
• content/test/BUILD.gn[diff]
• tools/metrics/histograms/histograms.xml[diff]

[Notifications] Fix crash in ArcCustomNotificationView::SlideHelper.

GetSlideOutLayer() can return null when called from ~SlideHelper() (e.g.
when a toast is destroyed), so add a null check.

BUG=718956

Review-Url: https://codereview.chromium.org/2881513002
Cr-Original-Commit-Position: refs/heads/master@{#470840}
Review-Url: https://codereview.chromium.org/2894133002 .
Cr-Commit-Position: refs/branch-heads/3071@{#633}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ui/arc/notification/arc_custom_notification_view.cc[diff]

Fix ARC notification crash.

Make ArcCustomNotificationView::SlideHelper operate on the correct
layer, i.e. that which is sliding out.

This is meant as a temporary hack to address the crash, but the code
still needs to be restructured to reduce fragility and improve test
coverage.

BUG=718965

Review-Url: https://codereview.chromium.org/2863163002
Cr-Original-Commit-Position: refs/heads/master@{#469787}
Review-Url: https://codereview.chromium.org/2886283006 .
Cr-Commit-Position: refs/branch-heads/3071@{#632}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ui/arc/notification/arc_custom_notification_view.cc[diff]

Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur

They look necessary because View::OnPaint draws the border, and View::OnFocus fires an accessibility event.

BUG=719414
TEST=manual (No issue happens)

Review-Url: https://codereview.chromium.org/2868833002
Cr-Original-Commit-Position: refs/heads/master@{#470024}
Review-Url: https://codereview.chromium.org/2892943002 .
Cr-Commit-Position: refs/branch-heads/3071@{#631}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ui/message_center/views/message_view.cc[diff]

reland "CrOS: Fix appearance of notification toasts when sliding out via gesture"

This re-lands 3d7851ff607c370234e4f93ecf6
original review: https://codereview.chromium.org/2849523005

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429
Review-Url: https://codereview.chromium.org/2849523005

Review-Url: https://codereview.chromium.org/2855763003
Cr-Original-Commit-Position: refs/heads/master@{#468962}
Review-Url: https://codereview.chromium.org/2892183002 .
Cr-Commit-Position: refs/branch-heads/3071@{#630}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ui/message_center/BUILD.gn[diff]
• ui/message_center/views/custom_notification_view_unittest.cc[diff]
• ui/message_center/views/message_center_view_unittest.cc[diff]
• ui/message_center/views/message_view.cc[diff]
• ui/message_center/views/message_view.h[diff]
• ui/message_center/views/message_view_factory.cc[diff]
• ui/message_center/views/notification_view_unittest.cc[diff]
• ui/message_center/views/slide_out_controller.cc[Added - diff]
• ui/message_center/views/slide_out_controller.h[Added - diff]
• ui/views/BUILD.gn[diff]
• ui/views/controls/slide_out_view.cc[Deleted - diff]
• ui/views/controls/slide_out_view.h[Deleted - diff]

Utilize Position::IsEquivalent() in {Up,Down}streamIgnoringEditingBoundaries()

This patch utilized |Position::IsEquivalent()| in
|{Up,Down}streamIgnoringEditingBoundaries()| to avoid infinite loop.

In http://crbug.com/716093, |UpstreamIgnoringEditingBoundaries()| causes
infinite loop as:
- |MostBackwardCaretPosition(AfterChildren/DIV)| After/INPUT
- |MostBackwardCaretPosition(After/INPUT)| AfterChildren/DIV
for <div contenteditable>foo <input contenteditable="false"></div>

When I attempt to change |MostBackwardCaretPosition()| to return one of them,
some layout tests failed. Hence, to minimize change, this patch change loop
condition.

BUG=716093
TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.ComputeInlineBoxPositionMixedEditabl

Review-Url: https://codereview.chromium.org/2875933004
Cr-Original-Commit-Position: refs/heads/master@{#471697}
Review-Url: https://codereview.chromium.org/2897623002 .
Cr-Commit-Position: refs/branch-heads/3071@{#629}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/core/editing/VisibleUnits.cpp[diff]
• third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp[diff]

Introduce Position::IsEquivalent()

This patch introduces |Position::IsEquivalent()| to check whether two positions
are in same position regardless anchor type, e.g. |Position(node, 0)| and
|Position::FirstPositionInNode(node)|. denote a position before first child of
|node|.

This patch is a preparation of patch[1].

[1] http://crrev.com/2875933004: Utilize Position::IsEquivalent() in
{Up,Down}streamIgnoringEditingBoundaries()

BUG=716093, 719343
TEST=run_webkit_unit_tests --gtest_filter=PositionTest.IsEquivalent

Review-Url: https://codereview.chromium.org/2875253002
Cr-Original-Commit-Position: refs/heads/master@{#471689}
Review-Url: https://codereview.chromium.org/2890403002 .
Cr-Commit-Position: refs/branch-heads/3071@{#628}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/core/editing/Position.cpp[diff]
• third_party/WebKit/Source/core/editing/Position.h[diff]
• third_party/WebKit/Source/core/editing/PositionTest.cpp[diff]

[css-grid] Properly reset auto repeat style attributes

All the auto repeat attributes stored in ComputedStyle were not properly
initialized/set up whenever initial or inherit were used in
grid-template-{columns|rows}. This means that any previous value would be
incorrectly used by the grid layout logic like for example to compute the
number of auto repeat tracks.

This was causing crashes as we were trying to access invalid indexes in the
Vectors storing the style information for tracks.

BUG=722054

Review-Url: https://codereview.chromium.org/2885003002
Cr-Original-Commit-Position: refs/heads/master@{#472396}
Review-Url: https://codereview.chromium.org/2896533003 .
Cr-Commit-Position: refs/branch-heads/3071@{#627}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash.html[Added - diff]
• third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl[diff]

Disable overlay scrollbars on ChromeOS

The decision has been made to push back shipping the overlay scrollbars
feature to M60. This patch turns off overlay scrollbars on the M59
branch.

BUG=723736

Review-Url: https://codereview.chromium.org/2893573006 .
Cr-Commit-Position: refs/branch-heads/3071@{#626}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ui/native_theme/native_theme_features.cc[diff]

Incrementing VERSION to 59.0.3071.64

Cr-Commit-Position: refs/branch-heads/3071@{#625}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

[Merge M59] arg: Implement retry logic for transient errors

BUG=723835
TEST=Manually, emulated different errors and confirmed that opt in
     flow worked as expected.
[email protected]
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2887093003
Cr-Original-Commit-Position: refs/heads/master@{#472606}
Review-Url: https://codereview.chromium.org/2896513002
Cr-Commit-Position: refs/branch-heads/3071@{#624}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/chromeos/arc/arc_auth_context.cc[diff]
• chrome/browser/chromeos/arc/arc_auth_context.h[diff]

Make disabling accelerated VPX decoding a GPU driver bug workaround.

This is currently a blacklist entry, which means that it's calculated in
the browser and the resulting decision could be incorrect if the GPU
process uses a different GPU from what the browser expects. If this is
a GPU driver bug workaround entry then it'll be determined with more
information in the GPU process.

[email protected]
BUG=687004,712006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2682723003
Cr-Original-Commit-Position: refs/heads/master@{#469513}
Review-Url: https://codereview.chromium.org/2888233002 .
Cr-Commit-Position: refs/branch-heads/3071@{#623}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• content/browser/gpu/compositor_util.cc[diff]
• content/browser/gpu/gpu_data_manager_impl_private.cc[diff]
• content/browser/gpu/gpu_data_manager_testing_arrays_and_structs_autogen.h[diff]
• gpu/config/gpu_blacklist.cc[diff]
• gpu/config/gpu_blacklist_unittest.cc[diff]
• gpu/config/gpu_driver_bug_list.json[diff]
• gpu/config/gpu_driver_bug_workaround_type.h[diff]
• gpu/config/gpu_feature_type.h[diff]
• gpu/config/software_rendering_list.json[diff]
• gpu/ipc/service/gpu_channel_manager.cc[diff]
• gpu/ipc/service/gpu_channel_manager.h[diff]
• gpu/ipc/service/gpu_channel_test_common.cc[diff]
• media/gpu/dxva_video_decode_accelerator_win.cc[diff]
• media/gpu/dxva_video_decode_accelerator_win.h[diff]
• media/gpu/gpu_video_decode_accelerator_factory.cc[diff]
• media/gpu/gpu_video_decode_accelerator_factory.h[diff]
• media/gpu/ipc/service/gpu_video_decode_accelerator.cc[diff]
• media/gpu/ipc/service/gpu_video_decode_accelerator.h[diff]
• services/ui/gpu/gpu_service.cc[diff]
• services/ui/gpu/gpu_service.h[diff]

[sync] Scope BrowserListRouterHelper to browsers with a matching profile

BrowserListRouterHelper listens to tab insertion/removal events for any and
all profiles, which duplicates events across multiple routers. This is
wrong and bad. This CL induces BrowserListRouterHelper to only add
itself as a listener for a browser with a matching profile.

BUG=721410
[email protected]

Review-Url: https://codereview.chromium.org/2887513002
Cr-Original-Commit-Position: refs/heads/master@{#472347}
Review-Url: https://codereview.chromium.org/2894683002 .
Cr-Commit-Position: refs/branch-heads/3071@{#622}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/sync/sessions/browser_list_router_helper.cc[diff]
• chrome/browser/sync/sessions/browser_list_router_helper.h[diff]
• chrome/browser/sync/sessions/browser_list_router_helper_unittest.cc[Added - diff]
• chrome/browser/sync/sessions/sync_sessions_web_contents_router.cc[diff]
• chrome/test/BUILD.gn[diff]

Image Capture: reject applyConstraints() if there isn't any recognized member

This CL corrects the code so that
 theTrack.applyConstraints({ advanced: [{blergh : 100}]});
will be rejected due to unknown dictionary members, also adding
a Layout Tests entry.

To reject, the logic in HasNonImageCaptureConstraints() is
inverted, checking for the presence of image constraints (instead
of checking for the absence of non-image constraints, which lets
an empty dictionary through) -- Note that WebIdl will silently
drop unsupported dictionary members.

Bug: 723779
Change-Id: I3c911ea4d319deab828c135a9f88a3d5af0b06bf
Reviewed-on: https://chromium-review.googlesource.com/508171
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#472699}
Review-Url: https://codereview.chromium.org/2887913005 .
Cr-Commit-Position: refs/branch-heads/3071@{#621}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html[diff]
• third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp[diff]

[merge to m59]md settings: Fix dialog buttons on lock screen.

Fix the password prompt, pin setup, fingerprint setup dialogs on the lock screen. They dont use the 'button-container' class from cr-dialog, so they are missing some margins/paddings the other dialogs have. Also the previous 'button-strip' was part of the body content of cr-dialog.

Before: https://screenshot.googleplex.com/heBMZLNjZXY
After: https://screenshot.googleplex.com/TYHdxUQNzC6

TEST=manual
BUG=723192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889893002
Cr-Original-Commit-Position: refs/heads/master@{#472586}
Review-Url: https://codereview.chromium.org/2894003003 .
Cr-Commit-Position: refs/branch-heads/3071@{#620}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/resources/settings/people_page/password_prompt_dialog.html[diff]
• chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html[diff]
• chrome/browser/resources/settings/people_page/setup_pin_dialog.html[diff]

X509CertificateBytes: Allow invalid serial numbers for now.

BUG=721778

Review-Url: https://codereview.chromium.org/2881023003
Cr-Original-Commit-Position: refs/heads/master@{#472040}
Review-Url: https://codereview.chromium.org/2897433002 .
Cr-Commit-Position: refs/branch-heads/3071@{#619}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• net/BUILD.gn[diff]
• net/cert/internal/parse_certificate_unittest.cc[diff]
• net/cert/internal/parsed_certificate_unittest.cc[diff]
• net/cert/x509_certificate_bytes.cc[diff]
• net/cert/x509_certificate_unittest.cc[diff]
• net/data/parse_certificate_unittest/serial_37_bytes.pem[Added - diff]
• net/data/parse_certificate_unittest/serial_negative.pem[Added - diff]
• net/data/parse_certificate_unittest/serial_zero_padded.pem[Added - diff]
• net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem[Added - diff]
• net/data/parse_certificate_unittest/tbs_negative_serial_number.pem[Deleted - diff]
• net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem[Deleted - diff]
• net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem[Deleted - diff]
• net/data/parse_certificate_unittest/v3_certificate_template.txt[diff]

Load the last committed native URL on DontProceed().

WebInterstitialImpl will remove all non-committed NavigationItems in its
DontProceed() implementation.  If the last committed URL was a web URL
then, this will simply display the previously loaded page.  If the last
committed URL corresponds with a native view, however, it must be
reloaded so that the webview can be purged and the URL's contents can be
displayed in a new native view.

BUG=712646
TEST=Open page with bad SSL (i.e. expired.badssl.com) from the NTP, then
tap "Return to Safety".  The NTP should be displayed again afterward.

Review-Url: https://codereview.chromium.org/2868193002
Cr-Original-Commit-Position: refs/heads/master@{#470631}
Review-Url: https://codereview.chromium.org/2887953005 .
Cr-Commit-Position: refs/branch-heads/3071@{#618}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• ios/web/web_state/ui/crw_web_controller.mm[diff]

WebUI: Stop keypresses on the close icon from firing the Enter handler.

Previously, Enter keypresses on the close icon could trigger the
whole dialog's default Enter handler.

This CL prevents that.

BUG=719387
TEST=MANUAL
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2884113002
Cr-Original-Commit-Position: refs/heads/master@{#472159}
Review-Url: https://codereview.chromium.org/2891993002 .
Cr-Commit-Position: refs/branch-heads/3071@{#617}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/test/data/webui/cr_elements/cr_dialog_test.js[diff]
• ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html[diff]
• ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js[diff]

Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash.

Apparently the crash is happening in blink::Document::GetFrame() because Document* is NULL.

BUG=706294,720282

Review-Url: https://codereview.chromium.org/2850813004
Cr-Original-Commit-Position: refs/heads/master@{#468952}
Review-Url: https://codereview.chromium.org/2884333005 .
Cr-Commit-Position: refs/branch-heads/3071@{#616}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/modules/BUILD.gn[diff]
• third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp[diff]
• third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h[diff]
• third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp[Added - diff]

chrome/android: Fix native toolbar drawing for custom tabs.

Currently the code ends up assuming that the tab strip exists for
CustomTabToolbar and does not clip the UI resource correctly when
drawing the composited toolbar. Pull the correct tab strip height from
Toolbar.

BUG=715508

Review-Url: https://codereview.chromium.org/2893743004
Cr-Original-Commit-Position: refs/heads/master@{#472642}
Review-Url: https://codereview.chromium.org/2889993005 .
Cr-Commit-Position: refs/branch-heads/3071@{#615}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java[diff]

Have sendBeacon throw for Blobs with a type that is not CORS-safelisted.

Intent to Temporarily Remove thread:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discussion

Pre-discussion happened at blink-api-owners-discuss@:
https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6C7wWviAI/discussion

BUG=490015,720303
[email protected],[email protected]

Review-Url: https://codereview.chromium.org/2870383002
Cr-Original-Commit-Position: refs/heads/master@{#471268}
Review-Url: https://codereview.chromium.org/2889683004 .
Cr-Commit-Position: refs/branch-heads/3071@{#614}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/LayoutTests/TestExpectations[diff]
• third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-blob-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-blob.html[diff]
• third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/beacon-cross-origin-redirect-blob-expected.txt[Deleted - diff]
• third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp[diff]
• third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5[diff]

[Cast,Android] Replace custom MediaController with android.widget.MediaController.

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls)

Review-Url: https://codereview.chromium.org/2888653002
Cr-Original-Commit-Position: refs/heads/master@{#472583}
Review-Url: https://codereview.chromium.org/2888273002 .
Cr-Commit-Position: refs/branch-heads/3071@{#613}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/BUILD.gn[diff]
• chrome/android/java/res/layout/expanded_cast_controller.xml[diff]
• chrome/android/java/res/values/colors.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java[diff]
• third_party/android_media/BUILD.gn[Deleted - diff]
• third_party/android_media/LICENSE[Deleted - diff]
• third_party/android_media/OWNERS[Deleted - diff]
• third_party/android_media/README.chromium[Deleted - diff]
• third_party/android_media/java/res/layout/media_controller.xml[Deleted - diff]
• third_party/android_media/java/res/values/colors.xml[Deleted - diff]
• third_party/android_media/java/src/org/chromium/third_party/android/media/MediaController.java[Deleted - diff]
• tools/android/eclipse/.classpath[diff]

Incrementing VERSION to 59.0.3071.63

Cr-Commit-Position: refs/branch-heads/3071@{#612}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

[VrShell] Mask system ui flags before checking.

This fixes an issue where extraneous flags were being set on some
devices and causing the flag check to fail.

BUG=719013
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2881403003
Cr-Original-Commit-Position: refs/heads/master@{#472257}
Review-Url: https://codereview.chromium.org/2888973002
Cr-Commit-Position: refs/branch-heads/3071@{#611}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java[diff]

Fix a crash when querying the Android DownloadManager

The DownloadInfo can be null when querying the Android DM

[email protected]
BUG=722768

Review-Url: https://codereview.chromium.org/2893673003 .
Cr-Commit-Position: refs/branch-heads/3071@{#610}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java[diff]

Slightly modify sizes of overlays that are larger than the monitor

Because of the rounding when converting between pixels and DIPs, a
fullscreen video can become slightly larger than the monitor - e.g. on a
3000x2000 monitor with a scale factor of 1.75 a 1920x1079 video can
become 3002x1689.

On older Intel drivers, swapchains that are bigger than the monitor
won't be put into overlays, which will hurt power usage a lot. On those
systems, the scaling can be adjusted very slightly so that it's less
than the monitor size. This should be close to imperceptible.

BUG=720059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884843002
Cr-Original-Commit-Position: refs/heads/master@{#471989}
Review-Url: https://codereview.chromium.org/2892653002 .
Cr-Commit-Position: refs/branch-heads/3071@{#609}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• gpu/config/gpu_driver_bug_list.json[diff]
• gpu/config/gpu_driver_bug_workaround_type.h[diff]
• gpu/ipc/service/direct_composition_surface_win.cc[diff]
• gpu/ipc/service/direct_composition_surface_win.h[diff]
• gpu/ipc/service/direct_composition_surface_win_unittest.cc[diff]

Workaround transform node NPE in draw_property_utils::UpdateElasticOverscroll

We have reports of crashes in draw_property_utils::UpdateElasticOverscroll
due to the transform node being null. We do not think this should be
possible. This patch works around this issue by adding a DCHECK and safely
returning from the function.

This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.

BUG=721772
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2889433002
Cr-Original-Commit-Position: refs/heads/master@{#471997}
Review-Url: https://codereview.chromium.org/2883263004 .
Cr-Commit-Position: refs/branch-heads/3071@{#608}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• cc/trees/draw_property_utils.cc[diff]

Change identification of Android O.

Up until now, only release builds of Android were identified as being
at least Android O.

This CL changes it to now just directly be only for SDK version 26 to
check if the current platform is at least Android O.

For whether Chrome is currently targetting Android O, the check now
also only checks for version 26.

BUG=None

Change-Id: Icd9fca4804eb7fd1e93e388efca6ae08994f13d6
Reviewed-on: https://chromium-review.googlesource.com/507809
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#472533}(cherry picked from commit 476235bd668ef183b5e605cc5d0ceaed36586592)
Reviewed-on: https://chromium-review.googlesource.com/508274
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#607}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• base/android/java/src/org/chromium/base/BuildInfo.java[diff]

Image Capture: correct LayoutTests name case

This CL is a follow up to https://crrev.com/2877273002, where tests
could not be renamed due to some platforms' file systems being case
insensitive.

Here we Rename a few tests:

- getphotocapabilities.html => getPhotoCapabilities.html
- setoptions.html => setOptions.html
- takephoto-with-photosettings.html => takePhoto-with-PhotoSettings.html
- takephoto.html => takePhoto.html

**No new code.**

[email protected]

Bug: 718765
Change-Id: I4dc03a95a86a43a4422f3d2311ed163322d656ba
Reviewed-on: https://chromium-review.googlesource.com/506506
Reviewed-by: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#472167}
Review-Url: https://codereview.chromium.org/2883283005 .
Cr-Commit-Position: refs/branch-heads/3071@{#606}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/LayoutTests/imagecapture/getPhotoCapabilities.html[Renamed from third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html - diff]
• third_party/WebKit/LayoutTests/imagecapture/setOptions.html[Renamed from third_party/WebKit/LayoutTests/imagecapture/setoptions.html - diff]
• third_party/WebKit/LayoutTests/imagecapture/takePhoto-with-PhotoSettings.html[Renamed from third_party/WebKit/LayoutTests/imagecapture/takephoto-with-photosettings.html - diff]
• third_party/WebKit/LayoutTests/imagecapture/takePhoto.html[Renamed from third_party/WebKit/LayoutTests/imagecapture/takephoto.html - diff]

Image Capture: reject setOptions()/applyConstraints() if any argument is unsupported

This CL adds rejection of applyConstraints()/setOptions() if the control value
is out of ranges or unsupported, e.g. trying to set zoom to 1000 where the
capability range is {1.0 - 10.0}.

LayoutTests for each of those methods are added.

BUG=718765

Review-Url: https://codereview.chromium.org/2877273002
Cr-Original-Commit-Position: refs/heads/master@{#472143}
Review-Url: https://codereview.chromium.org/2887043003 .
Cr-Commit-Position: refs/branch-heads/3071@{#605}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html[diff]
• third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html[Added - diff]
• third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html[diff]
• third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js[diff]
• third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html[Added - diff]
• third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp[diff]
• third_party/WebKit/Source/modules/imagecapture/ImageCapture.h[diff]
• third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp[diff]
• third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h[diff]

Always set damage rect to output rect if 3D context was reshaped.

The first draw after a reshape needs to draw the entire contents of the
window, so ensure the overlay processor doesn't accidentally shrink the
damage rect.

BUG=721131
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2881483002
Cr-Commit-Position: refs/heads/master@{#471244}
(cherry picked from commit 2f1f8dd5a7f7d15da2c24fc2ffa27ef48c7441a1)

Review-Url: https://codereview.chromium.org/2890053002 .
Cr-Commit-Position: refs/branch-heads/3071@{#604}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• cc/output/direct_renderer.cc[diff]
• cc/output/gl_renderer_unittest.cc[diff]

[Merge M59]BaseBubbleController: Do not close bubble while clicking in one of the child windows.

Currently, on clicking inside the <datalist> element in a bubble on Mac, the
browser action bubble is closed unexpectedly. This is because of an event
monitor registered by the BaseBubbleController. Modify the monitor so that it
ignores events in the bubble window's hierarchy.

BUG=587481
TEST=Open a browser action bubble with a <datalist> element. Click inside the
datalist picker. Ensure the bubble is not closed.

Review-Url: https://codereview.chromium.org/2847263004
Cr-Original-Commit-Position: refs/heads/master@{#468701}
Review-Url: https://codereview.chromium.org/2886733004 .
Cr-Commit-Position: refs/branch-heads/3071@{#603}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/ui/cocoa/base_bubble_controller.mm[diff]
• chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm[diff]

[merge to m59]md settings: Remove level of security indicator on lock screen.

Secuirty does not want users to know the level of security on their lock screen unlock method.

TEST=manual
BUG=722458
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885503002
Cr-Original-Commit-Position: refs/heads/master@{#471966}
Review-Url: https://codereview.chromium.org/2889723004 .
Cr-Commit-Position: refs/branch-heads/3071@{#602}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/app/settings_strings.grdp[diff]
• chrome/browser/resources/settings/people_page/lock_screen.html[diff]
• chrome/browser/ui/webui/options/browser_options_handler.cc[diff]
• chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc[diff]

[merge to m59]md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is enabled. Now easy unlock is moved to the lock screen section we want to just show lock screen section always and hide pin/fingerprint/easy unlock as needed on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862613003
Cr-Original-Commit-Position: refs/heads/master@{#470343}
Review-Url: https://codereview.chromium.org/2890003003 .
Cr-Commit-Position: refs/branch-heads/3071@{#601}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/resources/settings/people_page/lock_screen.html[diff]
• chrome/browser/resources/settings/people_page/lock_screen.js[diff]
• chrome/browser/resources/settings/people_page/people_page.html[diff]
• chrome/browser/resources/settings/people_page/people_page.js[diff]
• chrome/browser/ui/webui/options/browser_options_handler.cc[diff]
• chrome/browser/ui/webui/settings/md_settings_ui.cc[diff]

LayoutMenuList::ControlClipRect may depend on size of children

Add NeedsPaintPropertyUpdate().

BUG=721249
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=wangxianzhu
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2874413003
Cr-Original-Commit-Position: refs/heads/master@{#471828}
Review-Url: https://codereview.chromium.org/2890013002
Cr-Commit-Position: refs/branch-heads/3071@{#600}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• third_party/WebKit/Source/core/layout/LayoutMenuList.cpp[diff]
• third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp[diff]
• third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp[diff]

Merge "cros: No migration banner if user not allowed for ARC"

> Only show migration banner for the following user types:
> - Users with Gaia account (regular and child users);
> - AD users when ARC is allowed for AD users;
>
> BUG=722602
>
> Review-Url: https://codereview.chromium.org/2879393003
> Cr-Commit-Position: refs/heads/master@{#472128}
> (cherry picked from commit 468a6511775fca06ef0ae9d483cd2dc5668fdff8)

Review-Url: https://codereview.chromium.org/2888653004 .
Cr-Commit-Position: refs/branch-heads/3071@{#599}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/chromeos/login/screens/user_selection_screen.cc[diff]

Merge "cros: Hide banner on NeedsDircryptoMigration call failure"

> NeedsDircryptoMigration call fails when user cryptohome is removed.
> Leaving banner status unchanged is confusing. Hide the banner when
> this happens to make UI consistent.
>
> BUG=721948
>
> Review-Url: https://codereview.chromium.org/2879333002
> Cr-Commit-Position: refs/heads/master@{#471928}
> (cherry picked from commit ecfbc2ccd1072ed4f01a4a9c902fc5be9ed458a4)

Review-Url: https://codereview.chromium.org/2886083003 .
Cr-Commit-Position: refs/branch-heads/3071@{#598}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/browser/chromeos/login/screens/user_selection_screen.cc[diff]

Incrementing VERSION to 59.0.3071.62

Cr-Commit-Position: refs/branch-heads/3071@{#597}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• chrome/VERSION[diff]

bluetooth: Use a WeakPtr when posting a task

On macOS when writing without response we post a task. This task
was being posted by using base::Unretained(this). But there is no
guarantee that 'this' will be there by the time the task is ran.

This lead to a nullptr derefence when 'this' was deleted before the
callback was ran which could happen when a device disconnected.

This fixes the issue by using a WeakPtr when posting the task.

Bug: 721782
Change-Id: Iff00b4775de3c39aca50339fade33814b2c045d0
Reviewed-on: https://chromium-review.googlesource.com/505788
Commit-Queue: Vincent Scheib <[email protected]>
Reviewed-by: Vincent Scheib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#471817}
Review-Url: https://codereview.chromium.org/2881423006 .
Cr-Commit-Position: refs/branch-heads/3071@{#596}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

• device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h[diff]
• device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm[diff]
• device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc[diff]