Publish DEPS for Chromium 59.0.3071.47
Incrementing VERSION to 59.0.3071.47
Cr-Commit-Position: refs/branch-heads/3071@{#475}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849
This roll includes:
- [inspector_protocol] added StringUtil::toDouble method as requirement [1]
[1] https://codereview.chromium.org/2843223005/
BUG=712610
[email protected]
Review-Url: https://codereview.chromium.org/2846113002
Cr-Commit-Position: refs/heads/master@{#467878}
(cherry picked from commit 3b3ae152b652a7a4240954a07172bd57bdd64a00)
Review-Url: https://codereview.chromium.org/2866213002 .
Cr-Commit-Position: refs/branch-heads/3071@{#474}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
arc: Do filesystem check for ARC-installed (but not-enabled) devices.
Without this check ARC cannot run even if the filesystem is actually
good. Kiosk apps may run in this mode so we need to handle that.
BUG=719278
Review-Url: https://codereview.chromium.org/2871433002
Cr-Commit-Position: refs/heads/master@{#469926}
(cherry picked from commit 2a68c5c7da8b72728d1ffa4212831f89e4ebb64e)
Review-Url: https://codereview.chromium.org/2867263002 .
Cr-Commit-Position: refs/branch-heads/3071@{#473}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Workaround transform node NPE in LayerImpl::UpdatePropertyTreeScrollOffset
We have reports of crashes in LayerImpl::UpdatePropertyTreeScrollOffset due
to the transform node of a scrollable layer being null. These crashes have
happened for some time and this patch works around the crash by adding a
DCHECK and an early return.
BUG=712298
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2862193002
Cr-Commit-Position: refs/heads/master@{#469818}
(cherry picked from commit f1ebcf8d0a530d99bec6140dc7420933c9d69713)
Review-Url: https://codereview.chromium.org/2873503003 .
Cr-Commit-Position: refs/branch-heads/3071@{#472}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Fixed PageStateTest.testScrollPositionRestoring flake.
This CL adds a step where we scoll to the top whenever a page is loaded,
ensuring that the scroll actions end at the expected offset.
BUG=702410
Review-Url: https://codereview.chromium.org/2805573002
Cr-Commit-Position: refs/heads/master@{#465815}
(cherry picked from commit a6618dc84a89e04cad9c0badf3097b8af91c7795)
Review-Url: https://codereview.chromium.org/2868983004 .
Cr-Commit-Position: refs/branch-heads/3071@{#471}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Display the web view after commit for non-user-initiated loads.
The toolbar's visibility and URL is dependent on the visible URL.
However, the previous implementation of |-ensureWebViewCreated| would
immediately add web view to the hierarchy, even for non-user-initiated
loads. This CL updates the web view display logic so that it is
displayed at the same time as the toolbar updating.
BUG=703222
Review-Url: https://codereview.chromium.org/2820013003
Cr-Commit-Position: refs/heads/master@{#465365}
(cherry picked from commit cd2e9b497d8623d1c2844b6df874e42f865c2631)
Review-Url: https://codereview.chromium.org/2872823002 .
Cr-Commit-Position: refs/branch-heads/3071@{#470}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Enable testShowJavaScriptAfterNewTabAnimation for iPad
This CL disables EG synchronization when dealing with the onload JS
dialog.
BUG=711291
Review-Url: https://codereview.chromium.org/2825673003
Cr-Commit-Position: refs/heads/master@{#465737}
(cherry picked from commit 39b3663c37c90a8c6b13f50069eb017e2a1e3931)
Review-Url: https://codereview.chromium.org/2872803002 .
Cr-Commit-Position: refs/branch-heads/3071@{#469}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge M59] arg: Fix removing shortcuts on package update.
TEST=unit tests extented. Manually, updated test app via adb and
its shorcuts were left in app launcher
BUG=718625
BUG=b/34749664
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}
(cherry picked from commit 9984205426901dece21078e03eb68d4c7ef1fa07)
Review-Url: https://codereview.chromium.org/2869973002
Cr-Commit-Position: refs/branch-heads/3071@{#468}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Cherry-picked merge request for M59
[android omnibox] Move width calculation to onMeasure step
The Android text renderer runs in the ::measure() step. If the View
width is changed after this, in the layout or draw step, the text
is not re-laid out; it is truncated.
This change moves up the calculation.
BUG=718432
Review-Url: https://codereview.chromium.org/2866643002
Cr-Commit-Position: refs/heads/master@{#469869}
(cherry picked from commit d98981b9ab09719407adcb63f639276590f4263b)
Review-Url: https://codereview.chromium.org/2867923002 .
Cr-Commit-Position: refs/branch-heads/3071@{#467}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Disable inheritance propagation for text-align.
The text-align property has an internal value -webkit-match-parent with
a dependency on the parent computed style used in the UA sheet for LI,
which means the independent inheritance optimization won't work.
[email protected],[email protected]
BUG=716797
Review-Url: https://codereview.chromium.org/2860743004
Cr-Commit-Position: refs/heads/master@{#469609}
(cherry picked from commit be16e0bd842e5f7c1d62211f95e04ba41d2c3e11)
Review-Url: https://codereview.chromium.org/2867223002 .
Cr-Commit-Position: refs/branch-heads/3071@{#466}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Cherry picked merge request for M59
[Android Omnibox] Remove doubling of height for answers
We were adding twice the height necessary when an answer in suggest
was present, which created a large empty space at the end of the
suggestions. This changes it to adding custom "definition" line
height.
BUG=714042
Review-Url: https://codereview.chromium.org/2856253002
Cr-Commit-Position: refs/heads/master@{#469427}
(cherry picked from commit 2c16490e12bda68c5b784908105de4ec8edb3777)
Review-Url: https://codereview.chromium.org/2866143002 .
Cr-Commit-Position: refs/branch-heads/3071@{#465}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Don't update column position in StyleDidChange.
StyleDidChange set the first column position to the horizontal border
spacing value regardless of whether this value changed or not.
I am not familiar with how table layout works in Blink and haven't
debugged this extensively, but when we re-layout a table cell because
it has out-of-flow content which needs layout, the first effective
column position is set wrongly. It gets its initial value from the line
removed in this CL by a style recalc on the table element prior to the
re-layout, which is the h_spacing_, but the spacing is subtracted once
more in http://bit.ly/2pBB7x1
[email protected],[email protected]
BUG=716006
Review-Url: https://codereview.chromium.org/2855853002
Cr-Commit-Position: refs/heads/master@{#468920}
(cherry picked from commit d3c625b0b03346472e45dc1fda33d35b1d40efd3)
Review-Url: https://codereview.chromium.org/2867903002 .
Cr-Commit-Position: refs/branch-heads/3071@{#464}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary (2nd landing)
[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a { :-P
This CL:
- Adds an optional PhotoSettings arg to takePhoto(),
- cleanup: the 3 private methods used to receive mojo callbacks
(OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.
- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate. The sequence of method calls in ImageCapture.cpp then
would be:
- without options
takePhoto() -> OnMojoTakePhoto()
- with options:
takePhoto(options) -> setOptions(trigger_take_photo == true) --> OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()
- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.
BUG=718632
Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
[email protected] (reviewer of the original CL)
Review-Url: https://codereview.chromium.org/2871653003 .
Cr-Commit-Position: refs/branch-heads/3071@{#463}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Merge to M59: Revert "Fix computation of Automation API location offsets in WebViews."
This reverts commit c7c9e55f9f13ae947e938b8a4c929fefdeffe397.
Originally landed: r460412: https://codereview.chromium.org/2762373002
BUG=717684,658947
Review-Url: https://codereview.chromium.org/2867103005 .
Cr-Commit-Position: refs/branch-heads/3071@{#462}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
X509NameAttribute::ValueAsString: Decode TeletexString as Latin1.
BUG=717905,715969
Review-Url: https://codereview.chromium.org/2865603002
Cr-Commit-Position: refs/heads/master@{#469812}
(cherry picked from commit 788812f7788c07aa58487523ec70f9e921d78543)
Review-Url: https://codereview.chromium.org/2866063003 .
Cr-Commit-Position: refs/branch-heads/3071@{#461}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ )
Reason for revert:
The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html
Original issue's description:
> Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ )
>
> Reason for revert:
> Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644
>
> Original issue's description:
> > DevTools: fix aggregated donut chart cache population
> >
> > The check for stats cache availablity was made on the first task in the main thread
> > tasks list. If the first task happens to be filtered out, it never gets cache built for
> > it. Later the cache presence check would look for a cache on the first task, never find
> > it and forces recaching.
> >
> > BUG=714934
> >
> > Review-Url: https://codereview.chromium.org/2840463003
> > Cr-Commit-Position: refs/heads/master@{#467114}
> > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2
>
> [email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=714934
>
> Review-Url: https://codereview.chromium.org/2839083002
> Cr-Commit-Position: refs/heads/master@{#467223}
> Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f
[email protected],[email protected]
BUG=714934
Review-Url: https://codereview.chromium.org/2851823002
Cr-Commit-Position: refs/heads/master@{#468119}
(cherry picked from commit 2e2708b5c1cb31e5d4dde1f105af1c473795d3b9)
Review-Url: https://codereview.chromium.org/2867873002 .
Cr-Commit-Position: refs/branch-heads/3071@{#460}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge M59] arc: Support UNINSTALL_SHORTCUT
This adds handling UNINSTALL_SHORTCUT intent.
BUG=717661
BUG=b/34749139
TEST=Manually with test app. Shortcuts added and removed properly.
Extended unit_tests
[email protected],[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2858703002
Cr-Commit-Position: refs/heads/master@{#469063}
(cherry picked from commit cf0b40a80365c1c0de0d70e785ae91a26e547f74)
Review-Url: https://codereview.chromium.org/2861403003
Cr-Commit-Position: refs/branch-heads/3071@{#459}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Updating XTBs based on .GRDs from branch 3071
Cr-Commit-Position: refs/branch-heads/3071@{#458}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Revert of Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary (patchset #1 id:1 of https://codereview.chromium.org/2866053002/ )
Reason for revert:
This breaks build
../../third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:570:61: error: function definition is not allowed here
media::mojom::blink::PhotoCapabilitiesPtr capabilities) {
Sorry, Miguel
Original issue's description:
> Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
>
> This CL:
> - Adds an optional PhotoSettings arg to takePhoto(),
>
> - cleanup: the 3 private methods used to receive mojo callbacks
> (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
> prefix, for clarity.
>
> - adds a |trigger_take_photo| argument to setOptions() and a few
> others that pass it along; takePhoto() uses it to setOptions() when
> appropriate. The sequence of method calls in ImageCapture.cpp then
> would be:
> - without options
> takePhoto() -> OnMojoTakePhoto()
> - with options:
> takePhoto(options) -> setOptions(trigger_take_photo == true) --> OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()
>
> - methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
> (which are essentially the same thing) are merged and the resulting
> method renamed to UpdateMediaTrackCapabilities() to make more
> evident what it does.
>
> BUG=718632
>
> Review-Url: https://codereview.chromium.org/2865563002
> Cr-Commit-Position: refs/heads/master@{#469766}
> (cherry picked from commit 3fd00a51e22a0ffa55d0ab14725f9f300b2fc56b)
>
> Review-Url: https://codereview.chromium.org/2866053002 .
> Cr-Commit-Position: refs/branch-heads/3071@{#451}
> Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
> Committed: https://chromium.googlesource.com/chromium/src/+/dcc52283947a13edbd756eb739ee55a372fa5483
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718632
Review-Url: https://codereview.chromium.org/2872713002
Cr-Commit-Position: refs/branch-heads/3071@{#457}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.46
Cr-Commit-Position: refs/branch-heads/3071@{#456}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.45
Cr-Commit-Position: refs/branch-heads/3071@{#455}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
WebVR: fix initial vsync
Applications sometimes use window.rAF while not presenting, then switch to
vrDisplay.rAF after presentation starts. Depending on the animation loop's
timing, this can cause a race condition where presentation has been started
but there's no vrDisplay.rAF pending yet. Ensure there's at least vsync
being processed after presentation starts so that a queued window.rAF
can run and schedule a vrDisplay.rAF.
BUG=711789
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2848483003
Cr-Commit-Position: refs/heads/master@{#468167}
(cherry picked from commit 262e77a72493e36e8006aeeba1c7497a42ee5ad9)
Review-Url: https://codereview.chromium.org/2867813002
Cr-Commit-Position: refs/branch-heads/3071@{#454}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
MD-Settings - Update iron-list to fix scroll issue.
Fixed in https://github.com/PolymerElements/iron-list/issues/438
BUG=712544
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2858373003
Cr-Commit-Position: refs/heads/master@{#469685}
(cherry picked from commit df175df214a222e144783ec7cf776266fa8c974e)
Review-Url: https://codereview.chromium.org/2867053003 .
Cr-Commit-Position: refs/branch-heads/3071@{#453}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[MD settings] UMA and RevocationReporter in site settings
This CL adds UMA and Revocation reporting from site settings when a site
exception is added or removed. The goal is to match the behavior of the
old options.
BUG=718544
Review-Url: https://codereview.chromium.org/2861793005
Cr-Commit-Position: refs/heads/master@{#469561}
(cherry picked from commit b1c163ea6bf56b21576bed89fcf4162eebb2ab91)
Review-Url: https://codereview.chromium.org/2872693002 .
Cr-Commit-Position: refs/branch-heads/3071@{#452}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
This CL:
- Adds an optional PhotoSettings arg to takePhoto(),
- cleanup: the 3 private methods used to receive mojo callbacks
(OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.
- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate. The sequence of method calls in ImageCapture.cpp then
would be:
- without options
takePhoto() -> OnMojoTakePhoto()
- with options:
takePhoto(options) -> setOptions(trigger_take_photo == true) --> OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()
- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.
BUG=718632
Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
(cherry picked from commit 3fd00a51e22a0ffa55d0ab14725f9f300b2fc56b)
Review-Url: https://codereview.chromium.org/2866053002 .
Cr-Commit-Position: refs/branch-heads/3071@{#451}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Fix a crash on Chrome OS when selecting a file in chrome://net-export/
BUG=716198
Review-Url: https://codereview.chromium.org/2863283002
Cr-Commit-Position: refs/heads/master@{#469847}
(cherry picked from commit fc104446e6a2c11167e7f6e02b944f7e752be8b7)
Review-Url: https://codereview.chromium.org/2868913002 .
Cr-Commit-Position: refs/branch-heads/3071@{#450}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Add a metric to record http response code for download requests.
Currently we notice an issue according to metric data that parallel
download feature has a higher SERVER_FAIL interruption type.
we would like to know more details about the http response code from
the server to analyze the cause. This metric only applies to download
requests and will also be helpful to track general download system health.
BUG=718465
Review-Url: https://codereview.chromium.org/2862743002
Cr-Commit-Position: refs/heads/master@{#469888}
(cherry picked from commit 503e20c58c8fdae480d5e7bbc538365f17e32fa1)
Review-Url: https://codereview.chromium.org/2867803002 .
Cr-Commit-Position: refs/branch-heads/3071@{#449}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Merge "arc: Do not start the migration UI if ARC is only installed but not available."
> BUG=712580
> TEST=Manually confirmed with veyron_minnie_cheets (the UI is shown) \
> and a customized veyron_minnie_cheets with --arc-availability=installed \
> (the UI is not shown)
>
> Review-Url: https://codereview.chromium.org/2863663005
> Cr-Commit-Position: refs/heads/master@{#470005}
> (cherry picked from commit 3aa41dca5b0c069c0afc5bf9d14d671f96d35636)
Review-Url: https://codereview.chromium.org/2865123002 .
Cr-Commit-Position: refs/branch-heads/3071@{#448}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
MD Settings: Network: Do not call setProperties when setting defaults
In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.
To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.
BUG=718389
Review-Url: https://codereview.chromium.org/2863713004
Cr-Commit-Position: refs/heads/master@{#469523}
(cherry picked from commit b59f96b265d0bfb15ee56647ab4e3e28ae886b38)
Review-Url: https://codereview.chromium.org/2871523003 .
Cr-Commit-Position: refs/branch-heads/3071@{#447}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
WebVR: Don't crash when receiving null image from rendering context.
Not sure why/how this happens, but I was seeing this infrequently on https://with.in/watch/under-neon-lights/
BUG=718501
Review-Url: https://codereview.chromium.org/2862883002
Cr-Commit-Position: refs/heads/master@{#469517}
(cherry picked from commit a1215009f69ac267d13b072cc2d4c9cda7155fee)
Review-Url: https://codereview.chromium.org/2870553003 .
Cr-Commit-Position: refs/branch-heads/3071@{#446}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Revert of Merge to M59: Make adjustable large cursor enabled by default (patchset #1 id:1 of https://codereview.chromium.org/2847633002/ )
Reason for revert:
Adjustable large cursor will be enabled by default from M60.
Original issue's description:
> Merge to M59: Make adjustable large cursor enabled by default
>
> - Remove flag to enable adjustable large cursor and make it enabled by
> default.
>
> BUG=591493,700256,700260
> TEST=Go to accessibility section of settings, and confirm that
> adjustable large cursor is enabled by default.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2814743009
> Cr-Commit-Position: refs/heads/master@{#466271}
> (cherry picked from commit 92daff58d9c46d9ba81d43bb4ddf91bcfe82d3c0)
>
> Review-Url: https://codereview.chromium.org/2847633002 .
> Cr-Commit-Position: refs/branch-heads/3071@{#254}
> Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
> Committed: https://chromium.googlesource.com/chromium/src/+/7908a4575fa95708e3f27724838e9e58bd64b90e
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=591493,700256,700260
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2863413005
Cr-Commit-Position: refs/branch-heads/3071@{#445}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
cros: Add UMA metrics in encryption migration UI.
Some metrics about encryption migration are already recorded in cryptohomed.
In this CL, I'd like to add following UI-related UMA metrics on the app.
Cryptohome.MigrationUI.FirstScreen
Cryptohome.MigrationUI.UserChoice
Cryptohome.MigrationUI.ConsumedBatteryPercent
BUG=714887
TEST=Disable reboot after the migration by modifying the code, and check that chrome://histograms shows the added metrics.
Review-Url: https://codereview.chromium.org/2849833002
Cr-Commit-Position: refs/heads/master@{#468241}
(cherry picked from commit b75aa7267969141e12f5ece554be20d81d39b044)
Review-Url: https://codereview.chromium.org/2871493002 .
Cr-Commit-Position: refs/branch-heads/3071@{#444}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Add an experimental flag to change location.reload to take a hard-reload
BUG=716339
Review-Url: https://codereview.chromium.org/2852433004
Cr-Commit-Position: refs/heads/master@{#469663}
(cherry picked from commit 9ff98be419da56e5586093be8113b28e3a018484)
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2865013002
Cr-Commit-Position: refs/branch-heads/3071@{#443}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics.
This CL ensures that the NOT_STARTED state is recorded separately from
the STOPPED_BEFORE_COMPLETION state in the installability menu-open
check metrics.
BUG=704369
Review-Url: https://codereview.chromium.org/2844383004
Cr-Commit-Position: refs/heads/master@{#469283}
(cherry picked from commit 07f715aee7d56fd113ac152d5e0b34dd1ece3ff6)
Review-Url: https://codereview.chromium.org/2872483002 .
Cr-Commit-Position: refs/branch-heads/3071@{#442}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Don't send activation event when created
The new task may be already created on Android side, which
can deactivate a new task on Android side. This CL suppresses
the activation event for creation as well as activation request.
[email protected]
BUG=718429
TEST=Run cts test "CtsUiHostTestCases". It no longer fails.
Review-Url: https://codereview.chromium.org/2855883009
Cr-Commit-Position: refs/heads/master@{#469823}
(cherry picked from commit 67679038561e87a38508710c0058477333b40eac)
Review-Url: https://codereview.chromium.org/2871443002 .
Cr-Commit-Position: refs/branch-heads/3071@{#441}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.44
Cr-Commit-Position: refs/branch-heads/3071@{#440}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Android] Suppress the old and the new SharedPrefs.commit() lint warnings.
cherry-pick to M59
(cherry picked from commit d722433f871ba515de4c0e9a55b1803be4a6f1c6)
BUG=712852
[email protected]
Review-Url: https://codereview.chromium.org/2866973002 .
Cr-Commit-Position: refs/branch-heads/3071@{#439}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.43
Cr-Commit-Position: refs/branch-heads/3071@{#438}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.42
Cr-Commit-Position: refs/branch-heads/3071@{#437}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.41
Cr-Commit-Position: refs/branch-heads/3071@{#436}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Fixing white-screen problem for Curtain-mode Windows host connections
BUG=718143
Review-Url: https://codereview.chromium.org/2860203003
Cr-Commit-Position: refs/heads/master@{#469777}
(cherry picked from commit 699aaa5fdd0d66259d48d32cbe586ab841076eb6)
Review-Url: https://codereview.chromium.org/2861333002 .
Cr-Commit-Position: refs/branch-heads/3071@{#435}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Fixing a crash in our native messaging host binaries
This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent. The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.
The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.
BUG=718871
Review-Url: https://codereview.chromium.org/2857983008
Cr-Commit-Position: refs/heads/master@{#469646}
(cherry picked from commit e0ca3279b3b7ba5053a56f03fd57f7feb03d93ba)
Review-Url: https://codereview.chromium.org/2867623002 .
Cr-Commit-Position: refs/branch-heads/3071@{#434}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
display_compositor: Fix crash in GetCurrentTextureId.
Chwck that in-flight surface entry is not null. |in_flight_surfaces_|
entries can be null as a result of calling FreeAllSurfaces().
BUG=718796
Review-Url: https://codereview.chromium.org/2863613004
Cr-Commit-Position: refs/heads/master@{#469671}
(cherry picked from commit 03bf78e3cec7faa7819d87b458ea05ab4b577cab)
Review-Url: https://codereview.chromium.org/2861313002 .
Cr-Commit-Position: refs/branch-heads/3071@{#433}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
MD-Settings: Remove Mac specific warning that's no longer relevant.
Screenshot in bug.
[email protected]
BUG=718210
Review-Url: https://codereview.chromium.org/2862773003
Cr-Commit-Position: refs/heads/master@{#469505}
(cherry picked from commit 56aabec6e1277dde13b944d01e2fc2337c1cebf3)
Review-Url: https://codereview.chromium.org/2869503002 .
Cr-Commit-Position: refs/branch-heads/3071@{#432}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Merge 59: [Cherrypick] Change TaskQueueImpl to use a Deque with an inline capacity of 8
A speculative change that might help mitigate problems with
WTF::Deque::expandCapacity which sometimes takes over a second
due to heavy load on PartitionAlloc.
I'm hoping in normal operation the default_tq doesn't get more
than a handful of tasks (a quick trace of handouts on a high end
pc suggests the queue depth is <= 3) which would let us avoid
dynamic allocations entirely.
BUG=710245
Review-Url: https://codereview.chromium.org/2860813004
Cr-Commit-Position: refs/heads/master@{#469302}
(cherry picked from commit 05864d5cb320715302b6d39f88728ff0a8776378)
Review-Url: https://codereview.chromium.org/2862023002 .
Cr-Commit-Position: refs/branch-heads/3086@{#3}
Cr-Branched-From: 4159f36e93c398b9816b734a14e97220e83fc912-refs/heads/master@{#468266}
(cherry picked from commit 2d81885f86384317c7337f9d63f7e0baff09a784)
NOTRY=true
NOPRESUBMIT=true
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2865803002
Cr-Commit-Position: refs/branch-heads/3071@{#431}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.40
Cr-Commit-Position: refs/branch-heads/3071@{#430}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
M59: Clear the PrintContext in WebLocalFrameImpl::Close().
Also explicitly call PrintContext::EndPrintMode(), rather than calling
it in the destructor. Add a ScopedPrintMode helper class to do that
conveniently.
BUG=716474
Review-Url: https://codereview.chromium.org/2848823005
Cr-Commit-Position: refs/heads/master@{#468882}
(cherry picked from commit 85b7d7b31f25da2481ab2fa569c7b37a42abdeb6)
Review-Url: https://codereview.chromium.org/2864753004 .
Cr-Commit-Position: refs/branch-heads/3071@{#429}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Exclude crash tests for O
BUG=714672
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2846703004
Cr-Commit-Position: refs/heads/master@{#468253}
(cherry picked from commit ef4a5d5cee27a964cdfbe498ae71a93761b78b5b)
Review-Url: https://codereview.chromium.org/2863843004
Cr-Commit-Position: refs/branch-heads/3071@{#428}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Android] Keep extracted secondary dex files when clearing data in tests. (RELAND)
cherry pick to M59
BUG=716029
(cherry picked from commit 73357e2349014d7638b891070dc5d557e78f87fa)
Review-Url: https://codereview.chromium.org/2861273002 .
Cr-Commit-Position: refs/branch-heads/3071@{#427}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Android] Enable multidex for release builds of chrome_public_test_apk. (RELAND)
cherry pick to M59
BUG=712852
(cherry picked from commit 78730f18fc734d034e44d0dc63091562be82edae)
Review-Url: https://codereview.chromium.org/2868593002 .
Cr-Commit-Position: refs/branch-heads/3071@{#426}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
gpu: Reset OrderingBarrier state when recreating get buffer.
If the get buffer is destroyed say in SetAggressivelyFreeResources, the
next OrderingBarrier call after recreating the get buffer will see the
old value for last_barrier_put_offset_. CommandBufferProxyImpl uses this
to set the put_offset_changed parameter for OrderingBarrier. If the new
put_offset_ matches last_barrier_put_offset_ exactly the OrderingBarrier
becomes a nop. That can cause contexts to run out of order causing
all sorts of rendering glitches.
R=jbauman
[email protected]
BUG=715997
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1e511e22a3e2f3b0e71ea872bbd690925725be9
Reviewed-on: https://chromium-review.googlesource.com/495369
Reviewed-by: John Bauman <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#469217}
(cherry picked from commit e4f4044d257b331c40a6743b88e3050d8c12bee3)
Change-Id: I8dc11c768304481db1edf06cbd4f91457497fe26
Reviewed-on: https://chromium-review.googlesource.com/498130
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#425}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}Fix build break due to missing include.
BUG=718975,682299
[email protected]
Review-Url: https://codereview.chromium.org/2864463005 .
Cr-Commit-Position: refs/branch-heads/3071@{#424}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Remove fullscreen requirement from listening for vrdisplayactivate inside a frame.
BUG=718445
Review-Url: https://codereview.chromium.org/2862863002
Cr-Commit-Position: refs/heads/master@{#469399}
(cherry picked from commit 8847dabd9aef1075e157dced4d511a77308dedc2)
Review-Url: https://codereview.chromium.org/2860163007 .
Cr-Commit-Position: refs/branch-heads/3071@{#423}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[M59] exo: Fix multi-display cursor crash
The cursor surface is parented to the primary root window, which may
change when using multiple displays. This CL fixes a crash caused by
removing the child from the primary root window when the parent is a
different root window or the child is orphaned.
[email protected]
NOTRY=true
NOPRESUBMIT=true
BUG=714832
TEST=No crashes after changing primary display.
Review-Url: https://codereview.chromium.org/2862953002
Cr-Commit-Position: refs/heads/master@{#469543}
(cherry picked from commit 8d03afaa6214f583f526587f3865b4ccad45cad3)
Review-Url: https://codereview.chromium.org/2861213002
Cr-Commit-Position: refs/branch-heads/3071@{#422}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[M59] exo: Confine windows to primary display
Multi-display support in ARC was punted to the next milestone. This CL
temporarily prevents windows from being dragged to secondary displays
by using display rather than screen coordinates for window bounds.
[email protected]
NOTRY=true
NOPRESUBMIT=true
BUG=714832
TEST=ARC apps cannot be dragged to secondary displays.
Review-Url: https://codereview.chromium.org/2860863004
Cr-Commit-Position: refs/heads/master@{#469514}
(cherry picked from commit 53f36cb4e8b4301b733e64d392769ee3ab9a5ca8)
Review-Url: https://codereview.chromium.org/2860293004
Cr-Commit-Position: refs/branch-heads/3071@{#421}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Don't lower priority for scripts inserted by doc.write
HTML Chunks inserted by document.write() are run through a separate
instance of the preload scanner from the main document. If the main
document scanner has already discovered an image then all scripts
discovered by any preload scanner regardless of where they came from
would be considered late-body.
This behavior causes a regression where a document.write() in the head
that includes multiple script tags will discover them but treat them as
late-body scripts and only load them one at a time.
BUG=713727, 712338
Review-Url: https://codereview.chromium.org/2841363002
Cr-Commit-Position: refs/heads/master@{#467672}
(cherry picked from commit 591cbec71ef07912c8c7d2b0acc1efb25196d7f1)
Review-Url: https://codereview.chromium.org/2862303002 .
Cr-Commit-Position: refs/branch-heads/3071@{#420}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Fix extraneous beeps on empty page search.
As of https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768 a
find-in-page can issue multiple "final updates" if the document changes.
Each time a final update with zero results occurs, there is an audbible
notification which is a nuisance beyond the first one. Particularly
bothersome is that most or all pages cause a ding as you close them if
they have an active find in page with zero results.
BUG=682299
Review-Url: https://codereview.chromium.org/2839713002
Cr-Commit-Position: refs/heads/master@{#467417}
(cherry picked from commit 59192dd2dd5d23372ca3ace498327f1c690e61ac)
Review-Url: https://codereview.chromium.org/2858153005 .
Cr-Commit-Position: refs/branch-heads/3071@{#419}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Android] Add android:roundIcon for adaptive icon support
BUG=707449
[email protected]
Original-Review-Url: https://codereview.chromium.org/2850253003
Original-Cr-Commit-Position: refs/heads/master@{#468410}
Review-Url: https://codereview.chromium.org/2866583003 .
Cr-Commit-Position: refs/branch-heads/3071@{#418}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
The additional facetime:// prompts were introduced in iOS 10.3.0
BUG=710446
TEST=Please test with iOS 10.2, 10.3.0, 10.3.1, and 10.3.2 (beta).
Review-Url: https://codereview.chromium.org/2820083002
Cr-Commit-Position: refs/heads/master@{#464961}
(cherry picked from commit 57d77a1786e9b7a6c7a86a6d8f9f0d914e317cd4)
Review-Url: https://codereview.chromium.org/2861073003 .
Cr-Commit-Position: refs/branch-heads/3071@{#417}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ )
Reason for revert:
This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2).
Original issue's description:
> Don't set cpu architecture field on iOS in UMA logs.
>
> The value we were setting it to before was not correct, so this
> change instead just makes the value not get set on iOS.
>
> BUG=370104
>
> Review-Url: https://codereview.chromium.org/2671433002
> Cr-Commit-Position: refs/heads/master@{#447578}
> Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de
[email protected],[email protected]
BUG=370104, 718080
Review-Url: https://codereview.chromium.org/2855943005
Cr-Commit-Position: refs/heads/master@{#469062}
(cherry picked from commit 9f89092a8f533da1537b0a441b1e137b3d3b2728)
Review-Url: https://codereview.chromium.org/2860093004 .
Cr-Commit-Position: refs/branch-heads/3071@{#416}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
VR: Make work done during onResume in VrShellDelegate asynchronous.
Makes registerDaydreamIntent run after onResume. Makes static checking of VR support level in onResume an async task.
Note that doing this work asynchronously is racy. In practice this shouldn't be an issue because the user would have to put their phone into their daydream headset within a few milliseconds of launching chrome. The failure mode is also not terrible, the user would return to Daydream home instead of Chrome.
BUG=718136
Review-Url: https://codereview.chromium.org/2859893002
Cr-Commit-Position: refs/heads/master@{#469141}
(cherry picked from commit 2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c)
Review-Url: https://codereview.chromium.org/2855123008 .
Cr-Commit-Position: refs/branch-heads/3071@{#415}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Chrome Custom Tabs: set background tab feature to default disabled.
The CCTBackgroundTab chrome feature is used as a finch
kill-switch. Setting it disabled by default will be safer if the beta
launch is delayed.
NOTRY=true
NOPRESUBMIT=true
[email protected]
BUG=708173
Review-Url: https://codereview.chromium.org/2858223002
Cr-Commit-Position: refs/heads/master@{#469616}
(cherry picked from commit 023275881c6e064bfd5a87e29e75b90070280603)
Review-Url: https://codereview.chromium.org/2864453004
Cr-Commit-Position: refs/branch-heads/3071@{#414}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge M-59] Create google.com/pay alias for Android Pay PaymentRequest
BUG=718150
Review-Url: https://codereview.chromium.org/2861823002
Cr-Commit-Position: refs/heads/master@{#469197}
(cherry picked from commit 59386ee2da5a775d0f38ffef6adec9fb30bbb6b5)
Review-Url: https://codereview.chromium.org/2866513005 .
Cr-Commit-Position: refs/branch-heads/3071@{#413}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.39
Cr-Commit-Position: refs/branch-heads/3071@{#412}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Don’t call functions on a possibly-deleted object
JavaScriptDialogClosed walks up a list of frames. It shouldn’t be deleting frames and then calling functions on them.
BUG=717410
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2858743003
Cr-Commit-Position: refs/heads/master@{#469181}
(cherry picked from commit 44acfaa84e1b59c9cda18fc9c9b8a2cd5dc35564)
Review-Url: https://codereview.chromium.org/2861073002 .
Cr-Commit-Position: refs/branch-heads/3071@{#411}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge to M59] Gtk3: Add background class to tooltips
> This CL fixes the tooltip background color on the non-Dark variant of
> Adwaita which requires tooltips have the "background" class [1].
>
> Additionally, this CL avoids creating a selector with a GtkWindow
> parent class on Gtk 3.20. This avoids tinting the tooltip with the
> window background color if tooltips have transparency (FYI: Chrome
> tooltips are opaque, so the alpha will be ignored).
>
> [1] https://github.com/GNOME/gtk/blob/ee3994f715a2f53519f1478d2f08c6548471a8ae/gtk/theme/Adwaita/gtk-contained.css#L4387
>
> BUG=716599
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2855063002
> Cr-Commit-Position: refs/heads/master@{#469165}
BUG=716599
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2863843002
Cr-Commit-Position: refs/branch-heads/3071@{#410}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
MD Settings: Internet: Fix IP config visibility
In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.
BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2856023002
Cr-Commit-Position: refs/heads/master@{#469215}
(cherry picked from commit 1d11530a771298ce260f024b118864f66cdace4c)
Review-Url: https://codereview.chromium.org/2865543002 .
Cr-Commit-Position: refs/branch-heads/3071@{#409}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Last_n: do not delete the currently loading offline snapshot. (M59 merge)
The code to delete existing offline pages created previously by last_n
was also causing the deletion of the very offline snapshot currently
being loaded. This change fixes that by verifying that the snapshot that
would be deleted is not the same as the one being loaded.
It also changes slightly the way the information of the lastest last_n
snapshot is cleared: now that only happens when the snapshot is actually
being deleted.
BUG=718212
Review-Url: https://codereview.chromium.org/2854213005
Cr-Commit-Position: refs/heads/master@{#469411}
(cherry picked from commit 2319abbff11d73330235314486b7dec03f1b32e0)
Review-Url: https://codereview.chromium.org/2860233002 .
Cr-Commit-Position: refs/branch-heads/3071@{#408}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Media Router] Sync state when MR extension is (re)connected to MR.
The extension might have become out of sync with MediaRouter due to one
of few reasons:
(1) The extension crashed and lost unpersisted changes.
(2) The extension was updated; temporary data is cleared.
(3) The extension has an unforseen bug which causes temporary data to be
persisted incorrectly on suspension.
The number of calls made for the state sync should be relatively small
(< 10), and quite inexpensive since the extension is already up. Note
that the calls must be (and are) idempotent; the extension will no-op
if the query / observer being registered already exists.
Note that the existing mDNS activation call is also considered part of
state sync.
BUG=717325
Review-Url: https://codereview.chromium.org/2855473004
Cr-Commit-Position: refs/heads/master@{#469067}
(cherry picked from commit adb75ff0ecd96123cfeab63e9ab2bfc368e29f05)
Review-Url: https://codereview.chromium.org/2857393005 .
Cr-Commit-Position: refs/branch-heads/3071@{#407}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Allow empty UKM entries to be recorded.
BUG=717793
Review-Url: https://codereview.chromium.org/2855053002
Cr-Commit-Position: refs/heads/master@{#469101}
(cherry picked from commit 60d054d1f297debcae848680eead71f2517003fc)
Review-Url: https://codereview.chromium.org/2857983006 .
Cr-Commit-Position: refs/branch-heads/3071@{#406}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[ios] Revert of History didReceiveQueryResult performBatchUpdates.
This reverts: https://codereview.chromium.org/2800473004/
Since it increased the crash rate as in bug 716349.
BUG=716349
Review-Url: https://codereview.chromium.org/2855883002
Cr-Commit-Position: refs/heads/master@{#468856}
(cherry picked from commit 4575e0c18c3fea30e4f59ccc4c00fca6e6014698)
Review-Url: https://codereview.chromium.org/2860893005 .
Cr-Commit-Position: refs/branch-heads/3071@{#405}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Devtools][Regression] Fixed websocket frame selection loss on frame received
Fixed bug where if a websocket frame was received it would sometimes
move the selected node in network panel to a new request.
Offending patch: https://codereview.chromium.org/2694103007
R=dgozman,caseq
BUG=714229
Review-Url: https://codereview.chromium.org/2838673003
Cr-Commit-Position: refs/heads/master@{#468185}
(cherry picked from commit fc4b4d8fbe2657a7d51cef8939e68acc99fae05a)
Review-Url: https://codereview.chromium.org/2857673005 .
Cr-Commit-Position: refs/branch-heads/3071@{#404}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Clear callback when a parallel request can no longer write any data
If a StreamReader is found that it can no longer write any data, we should
clear its callback.
Otherwise, the StreamReader can still report an error and interrupt the download.
[email protected]
BUG=717719
If the data has already been written
Review-Url: https://codereview.chromium.org/2861443005
Cr-Commit-Position: refs/heads/master@{#469193}
(cherry picked from commit 2a542d8debc1075277dfa8de50dea36fb96d5aff)
Catch more exception when accessing content URI
Accessing content URI can throw more exceptions than expected.
This CL catch all possible exceptions so we don't crash.
BUG=706299
Review-Url: https://codereview.chromium.org/2861583008
Cr-Commit-Position: refs/heads/master@{#469208}
(cherry picked from commit 62b10acb8db135704af395a51ecf72d499944d76)
Review-Url: https://codereview.chromium.org/2861013002 .
Cr-Commit-Position: refs/branch-heads/3071@{#403}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Catch more exception when accessing content URI
Accessing content URI can throw more exceptions than expected.
This CL catch all possible exceptions so we don't crash.
[email protected]
BUG=706299
Review-Url: https://codereview.chromium.org/2861583008
Cr-Commit-Position: refs/heads/master@{#469208}
(cherry picked from commit 62b10acb8db135704af395a51ecf72d499944d76)
Review-Url: https://codereview.chromium.org/2865463002 .
Cr-Commit-Position: refs/branch-heads/3071@{#402}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Enable audio API for kiosk apps on stable channel
BUG=655444
Review-Url: https://codereview.chromium.org/2810943008
Cr-Commit-Position: refs/heads/master@{#465067}
(cherry picked from commit a10d5d2b99f3da802fa1a5d17742ff823d4aec34)
Review-Url: https://codereview.chromium.org/2862033002 .
Cr-Commit-Position: refs/branch-heads/3071@{#401}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Mojo: Allow data pipe creation to fail gracefully
Changes MojoCreateDataPipe and data pipe handle deserialization
to no longer assume that the internal buffer mapping must always
succeed. It can fail if, e.g., we're out of file descriptors.
These operations can fail gracefully in such cases.
Also changes MojoAsyncResourceHandle to handle such a failure
when attempting to create a data pipe.
BUG=706689
Change-Id: I24524035c0bdb12c4c2d02fd0666071bdb74cc97
Reviewed-on: https://chromium-review.googlesource.com/492308
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Jay Civelli <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#468741}
(cherry picked from commit d61caeda8451fe13bd74e403dd78faf96e620e17)
[email protected]
Change-Id: Iea087e84e240f9f0ba6a05506dfee4c3791afcbe
Reviewed-on: https://chromium-review.googlesource.com/496286
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#400}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}Allow command-line and system Flash when --disable-bundled-pepper-flash.
BUG=715431
Review-Url: https://codereview.chromium.org/2845823002
Cr-Commit-Position: refs/heads/master@{#468801}
(cherry picked from commit e389863c1b80cdfa819bea395fd4d5770c161ee7)
Review-Url: https://codereview.chromium.org/2862583007 .
Cr-Commit-Position: refs/branch-heads/3071@{#399}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Do not disable minimize animation for maximized/fullscreened exo windows
BUG=717761
TEST=Fullscreen/Maximize Play Store app, then minimize/unminmize.
Review-Url: https://codereview.chromium.org/2861523002
Cr-Commit-Position: refs/heads/master@{#469171}
(cherry picked from commit 30b31ad5f8d2cbfebe42a9288dd372edcaf0eca0)
Review-Url: https://codereview.chromium.org/2864433004 .
Cr-Commit-Position: refs/branch-heads/3071@{#398}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow.
* Make sure resets all shadow layers when the switching between deprecated shadow.
* Don't try to show the window that is already visible.
This is reland of crrev.com/2820493004 with a fix for crbug.com/713560
[email protected]
BUG=BUG=711514
TEST=covered by unit tests.
manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
Tested on MNC and NYC devices as well.
Review-Url: https://codereview.chromium.org/2837903002
Cr-Commit-Position: refs/heads/master@{#467485}
(cherry picked from commit 27b41b0b6fb0317aa944f2bdf7e4879628aab83c)
Review-Url: https://codereview.chromium.org/2862583006 .
Cr-Commit-Position: refs/branch-heads/3071@{#397}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Do not crash renderer with unique origins in MediaDevicesDispatcherHost.
Unique origins are not authorized to use media-devices features, but
they should not result in a killed renderer.
They might be using about:blank for testing, or perhaps trying to use the
feature too early, before the origin has been established.
BUG=717130
Review-Url: https://codereview.chromium.org/2858523003
Cr-Commit-Position: refs/heads/master@{#468706}
(cherry picked from commit 67298a699946b1d43bd6babb062f87577a2a730d)
Review-Url: https://codereview.chromium.org/2861973002 .
Cr-Commit-Position: refs/branch-heads/3071@{#396}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Consider Button clicks for extension notifications
BUG=716782
Review-Url: https://codereview.chromium.org/2855983002
Cr-Commit-Position: refs/heads/master@{#468836}
(cherry picked from commit e5d0ff4df4be89a8ec26ab26d7d468a54c294616)
Review-Url: https://codereview.chromium.org/2859153002 .
Cr-Commit-Position: refs/branch-heads/3071@{#395}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Permissions/Mac: Fix RTL positions for permission decision strings.
Support RTL for permission decision strings, wrapping strings that may be too
long to fit.
See
https://drive.google.com/file/d/0BzEa5HU1aAqBUEl4THZuSkd5Tms/view?usp=sharing
for before / after screenshots.
BUG=714859
Review-Url: https://codereview.chromium.org/2841013002
Cr-Commit-Position: refs/heads/master@{#468568}
(cherry picked from commit 09eed0675cc8f316344caf5ac695f140608493f6)
Review-Url: https://codereview.chromium.org/2859103003 .
Cr-Commit-Position: refs/branch-heads/3071@{#394}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Harden subsequence copying code to avoid null checks due to double-painting.
BUG=712660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2858753003
Cr-Commit-Position: refs/heads/master@{#468868}
(cherry picked from commit ff96b24760d2323bb466fe431632e7c1a9fff9c6)
Review-Url: https://codereview.chromium.org/2855383002 .
Cr-Commit-Position: refs/branch-heads/3071@{#393}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge to M59] Avoid Showing rotation change notification when source is accelerometer
[email protected]
BUG=717252
TEST=Manually rotate device with accelerometer and observe there's no notification
Review-Url: https://codereview.chromium.org/2853113005
Cr-Commit-Position: refs/heads/master@{#469058}
(cherry picked from commit 31b81d4cf8b6a063391839816c82fc61c8272e53)
Review-Url: https://codereview.chromium.org/2861953002 .
Cr-Commit-Position: refs/branch-heads/3071@{#392}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[merge to m59] cros: Update touchscreen status with backlights forced off state during start
Changes:
Sync powerd's backlights forced off state with touchscreen local pref and update touchscreen.
[email protected]
BUG=709209
TEST=added test coverage
Review-Url: https://codereview.chromium.org/2855033004
Cr-Commit-Position: refs/heads/master@{#468895}
(cherry picked from commit 750b068d2182bbb0bafe9c236dae7aea02f0431e)
Review-Url: https://codereview.chromium.org/2858173002 .
Cr-Commit-Position: refs/branch-heads/3071@{#391}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge to M59] Gtk3: Fix black patches on GtkFileChooser dialogs
> This CL fixes parts of GtkFileChoosers not getting rendered on GNOME
> standard themes (Adwaita + HighContrast) causing black areas to
> appear.
>
> BUG=704092
> [email protected]
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2854773002
> Cr-Commit-Position: refs/heads/master@{#468803}
BUG=704092
[email protected]
[email protected]
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2856393002
Cr-Commit-Position: refs/branch-heads/3071@{#390}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
ChromeOS OOBE: Fix language and keyboard md-select look.
BUG=716374
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2856933004
Cr-Commit-Position: refs/heads/master@{#468866}
(cherry picked from commit c9acca9df826b31c2b58b50565172428396afb30)
Review-Url: https://codereview.chromium.org/2862613004 .
Cr-Commit-Position: refs/branch-heads/3071@{#389}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Android] Update check for whether current OS platform is O
Previously we have used the pre-release code names for checking whether
the current platform Chrome runs on is Android O. This CL updates this
to instead check against the Build.VERSION.SDK_INT when running on
release builds of the OS.
This CL also updates the the check for whether Chrome is currently
targeting Android O, which now also uses the Build.VERSION.SDK_INT for
release builds, but still checks against CUR_DEVELOPMENT for
pre-releases for Android O.
BUG=685808
Change-Id: I7f17fd5bc8f6489586435818b224b080c391295c
Reviewed-on: https://chromium-review.googlesource.com/495266
Commit-Queue: Tommy Nyquist <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Theresa Wellington <[email protected]>
Cr-Commit-Position: refs/heads/master@{#469205}
(cherry picked from commit a1805a08180330ee59355e42f079d1fe5e5bcb3d)
[email protected]
Change-Id: I6df26a8a63360bc697c33e94181ee6b223fb43be
Reviewed-on: https://chromium-review.googlesource.com/495508
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3071@{#388}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}Incrementing VERSION to 59.0.3071.38
Cr-Commit-Position: refs/branch-heads/3071@{#387}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Updating XTBs based on .GRDs from branch 3071
Cr-Commit-Position: refs/branch-heads/3071@{#386}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
M59: Defer deletion in PrintWebViewHelper while handling IPC messages.
Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.
BUG=707549
Review-Url: https://codereview.chromium.org/2849483002
Cr-Commit-Position: refs/heads/master@{#467810}
(cherry picked from commit 9c0e322c8de168b121cd6ae8cba92cd3214e5b1f)
Review-Url: https://codereview.chromium.org/2857313002 .
Cr-Commit-Position: refs/branch-heads/3071@{#385}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Display "Restart to update Adobe Flash Player" for Flash updates.
This CL displays the text "Restart to update Adobe Flash Player" in the
system tray when a Flash player update is available.
BUG=711822
Review-Url: https://codereview.chromium.org/2816253002
Cr-Commit-Position: refs/heads/master@{#465818}
(cherry picked from commit ed2af8b429def7ee0de3d62efe1f07e7d61c1ed8)
Review-Url: https://codereview.chromium.org/2857193003 .
Cr-Commit-Position: refs/branch-heads/3071@{#384}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Media,Android] Always call startForeground after startForegroundService
On Android O, if startForegroundService() is called but then the service
created is not put to foreground with a startForeground() call, the app
is crashed by the OS. Media notification is sometimes discarded before
the service is created so startForeground() would never be called.
This change makes sure startForeground() is always called in this case.
It also updates the tests so they keep passing.
BUG=714619
TEST=manual+existing tests
Review-Url: https://codereview.chromium.org/2855003002
Cr-Commit-Position: refs/heads/master@{#469068}
(cherry picked from commit b711552b51c21f3ee5346a471786c59fb5ce9538)
Review-Url: https://codereview.chromium.org/2857033003 .
Cr-Commit-Position: refs/branch-heads/3071@{#383}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the snapshot controller
Changes include:
-- moving all timing parameters (how long to wait before snapshotting) to the snapshot controller
-- introducing 2 new factory methods for obtaining a snapshot controller
-- more explicit ownership and transfer of the snapshot controller
BUG=712473
Review-Url: https://codereview.chromium.org/2822023002
Cr-Commit-Position: refs/heads/master@{#468765}
(cherry picked from commit 5e17a9358f03488e71cba7c4b6786afba95fed6e)
Review-Url: https://codereview.chromium.org/2861583007 .
Cr-Commit-Position: refs/branch-heads/3071@{#382}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Offline pages] Fix order of error checking so URL mismatch would not override other error codes
BUG=717706
Review-Url: https://codereview.chromium.org/2860543002
Cr-Commit-Position: refs/heads/master@{#469082}
(cherry picked from commit 7ed8f251fa9ae767f20a32abe8d70921b883d062)
Review-Url: https://codereview.chromium.org/2856053003 .
Cr-Commit-Position: refs/branch-heads/3071@{#381}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Merge 59: Fix errors in destruction sequence of GpuVideoEncodeAccelerator::OnWillDestroyStub()
On Windows, we can use GPU IO thread to filter some messages for GPUVEA.
In that case, while GpuVideoEncodeAccelerator::OnWillDestroyStub() is running
on main thread, GpuVideoEncodeAccelerator::OnEncodeFrameCreated() can run
on IO thread. If |encoder_| is reset on main thread and accessed on IO
thread, we see the crashes listed on the bug.
This CL solves the issue by:
- Checking |filter_removed_| which is signaled on IO thread before deciding
to continue with encode GpuVideoEncodeAccelerator::OnEncodeFrameCreated() on
IO thread.
- Making sure that |encoder_worker_thread_| tasks are completed before reset.
BUG=715759
TEST=Tested AppRTC loopback with H264.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2849443003
Cr-Commit-Position: refs/heads/master@{#468457}
(cherry picked from commit a561de6d59f43481c46e61a34508fa15c5fd2abd)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2856283002
Cr-Commit-Position: refs/branch-heads/3071@{#380}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Check for null context_ in HTMLCanvasElement::DoDeferredPaintInvalidation
Merge M-59
We are seeing crashes on Android due to a null context_.
In most places we check for null, but not everywhere.
So add the correct checks such that
HTMLCanvasElement::DoDeferredPaintInvalidation
does not crash if the context is null.
[email protected]
BUG=709384
Review-Url: https://codereview.chromium.org/2860513002
Cr-Commit-Position: refs/heads/master@{#468767}
(cherry picked from commit 0b81b742121a5a86aa083d5793fbf2ee2493eaa0)
Review-Url: https://codereview.chromium.org/2858943002 .
Cr-Commit-Position: refs/branch-heads/3071@{#379}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Null check instance_ in PepperWebPluginImpl to prevent re-entry NPE
This patch fixes many NPEs in PepperWebPluginImpl where Sergeant
Pepper forgot to check the instance before using it. The instance
may be null due to re-entry and a comment has been added about this.
BUG=715747
Review-Url: https://codereview.chromium.org/2835193008
Cr-Commit-Position: refs/heads/master@{#467817}
(cherry picked from commit c7a827953ea89e6c314956119514fa3acd69eba6)
Review-Url: https://codereview.chromium.org/2855963003 .
Cr-Commit-Position: refs/branch-heads/3071@{#378}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Incrementing VERSION to 59.0.3071.37
Cr-Commit-Position: refs/branch-heads/3071@{#377}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge to m59] A11y: Don't accounce password keystrokes twice
When typing passwords on Android, TalkBack first announces the letter
from the keyboard. When the letter is inserted into the password field,
there is an AX_EVENT_TEXT_CHANGED, and TalkBack annaunces the inserted
letter as "dot". Then after a delay, SecureTextTimer replaces the letter
with a dot, causing a second AX_EVENT_TEXT_CHANGED, and TalkBack
announces "dot" again. This suppresses the second AX_EVENT_TEXT_CHANGED.
BUG=716212
Review-Url: https://codereview.chromium.org/2846133002
Cr-Commit-Position: refs/heads/master@{#468393}
(cherry picked from commit b042a7e565df1572caa21084289f6e37db216684)
Review-Url: https://codereview.chromium.org/2854163004 .
Cr-Commit-Position: refs/branch-heads/3071@{#376}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[SmartText Selecton] Increase the number of extra characters to 240
This is the maximal amount of characters from the left and from the right
taken together, i.e. there is 120 on each side.
BUG=717619
Review-Url: https://codereview.chromium.org/2862503002
Cr-Commit-Position: refs/heads/master@{#469019}
(cherry picked from commit a999e72fd81a030338d60785a2e6e09427fad811)
Review-Url: https://codereview.chromium.org/2857193002 .
Cr-Commit-Position: refs/branch-heads/3071@{#375}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge to M59] Whitelisted clipboardRead Permission
Follow up to crrev.com/2794803003 - forgot to actually whitelist the permission.
BUG=707864
Review-Url: https://codereview.chromium.org/2838173002
Cr-Commit-Position: refs/heads/master@{#466994}
(cherry picked from commit 9074b2db8c610057e8ef1a2b3d53b93e7d23f918)
Review-Url: https://codereview.chromium.org/2860653004 .
Cr-Commit-Position: refs/branch-heads/3071@{#374}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Merge to M59] Fix for broken "Load unpacked extension" popup
In crrev.com/2794803003 I introduced a bug that caused "Load unpacked extension" screen (available under chrome://extensions) to not display any files. This CL fixes it.
BUG=707864
Review-Url: https://codereview.chromium.org/2840043002
Cr-Commit-Position: refs/heads/master@{#467631}
(cherry picked from commit 55180f5ed3cd7386ef97e044d4084e5fb9afc67a)
Review-Url: https://codereview.chromium.org/2859783003 .
Cr-Commit-Position: refs/branch-heads/3071@{#373}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Settings reset prompt: Fix crash when fetching default settings.
When the Chrome installation has a brand code, the SettingsResetPromptModel may try to fetch default settings over the network. If the fetch fails, the ProfileResetter is passed a null pointer and any attempt to reset a setting will crash.
BUG=716372
Review-Url: https://codereview.chromium.org/2852883002
Cr-Commit-Position: refs/heads/master@{#468270}
(cherry picked from commit 2f2f39f646d36d9c56b723666a50fdeed43f90c2)
Review-Url: https://codereview.chromium.org/2856153002 .
Cr-Commit-Position: refs/branch-heads/3071@{#372}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Add month and year to time_format.
Add the possibility to have month and years in time format.
A year is defined as 365 days.
A month is defined as 1year / 12.
'1 month' means more than one month and less than two month (same for
years).
CL mainly made by olivierrobin
BUG=694451
Review-Url: https://codereview.chromium.org/2845693002
Cr-Commit-Position: refs/heads/master@{#467625}
(cherry picked from commit bef90b8dea482e8a4801f9c9c0543ab35ef2fd9f)
Review-Url: https://codereview.chromium.org/2856143002 .
Cr-Commit-Position: refs/branch-heads/3071@{#371}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
getScreenCTM on <use> should not include the additional translation
This is a partial revert of https://codereview.chromium.org/2711503002,
preserving the fix from that bug (crbug.com/678167) while restoring the
LocalCoordinateSpaceTransform() infrastructure to compute the correct
CTM for <use> elements.
BUG=716711
Review-Url: https://codereview.chromium.org/2853223002
Cr-Commit-Position: refs/heads/master@{#468657}
(cherry picked from commit 9acc325d119247a27d0a007d56fc6cc2fa23edc7)
Review-Url: https://codereview.chromium.org/2857863003 .
Cr-Commit-Position: refs/branch-heads/3071@{#370}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
MD Settings: special-case row spacing on Clear Browsing Data dialog
[email protected]
BUG=715796
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2853763003
Cr-Commit-Position: refs/heads/master@{#468530}
(cherry picked from commit d0206f11864ca3b7fd59e5f04a334c8c448349ed)
Review-Url: https://codereview.chromium.org/2857883002 .
Cr-Commit-Position: refs/branch-heads/3071@{#369}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
[Android]Bookmark widget crashes after Chrome data is cleared from application setting.
After Chrome data is cleared from application setting, if quickly swipe
down the Bookmark widget, it will crash.
This is because when the Chrome data is cleared from application
settings, Chrome does not send an intent to tell bookmark widget to
sync. So the widget does not know the size of list is 0 and is still
scrollable. Then when quickly swipe down the widget, the widget starts to
sync data and bookmark folder has no data, but since widget is scrolled
down deeply, widget still try to get the views whose data has been
cleared which causes IndexOutOfBound errors.
To fix this, add check to examine whether index is out of range of the
list of child bookmarks, if so, return null.
BUG=715045
NOTRY=true
NOPRESUBMIT=true
Original-Review-Url: https://codereview.chromium.org/2854233002
Cr-Commit-Position: refs/heads/master@{#468832}
(cherry picked from commit 131eedfde0a5ad180f927e4d7a0b771a54c91180)
Review-Url: https://codereview.chromium.org/2858643005
Cr-Commit-Position: refs/branch-heads/3071@{#368}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Make DOMArrayBuffer::Transfer neuter v8::ArrayBuffers
This behavior is currently done by ScriptValueSerializer, but it's more
convenient if the necessary logic is moved to DOMArrayBuffer::Transfer
directly; you'll never want to transfer without also calling Neuter on the V8
ArrayBuffer objects.
BUG=711824
Review-Url: https://codereview.chromium.org/2826263002
Cr-Commit-Position: refs/heads/master@{#467441}
(cherry picked from commit ca0862600acc57baec238c114be2af70e889708f)
Review-Url: https://codereview.chromium.org/2858643006 .
Cr-Commit-Position: refs/branch-heads/3071@{#367}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Disable explicit multisample resolve (and webgl2) on Adreno 4xx on Android 7.0
This was seen on Sony Xperia Z5 (Adreno 430).
BUG=696126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2855583003
Cr-Commit-Position: refs/heads/master@{#468507}
(cherry picked from commit 586c01de3897c0aa2d9911ff703c51595cf22f62)
Review-Url: https://codereview.chromium.org/2861433003 .
Cr-Commit-Position: refs/branch-heads/3071@{#366}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
