Publish DEPS for Chromium 58.0.3029.41
Incrementing VERSION to 58.0.3029.41
Cr-Commit-Position: refs/branch-heads/3029@{#465}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
chromeos: Update note-taking apps when ARC-enabled profile added.
Make NoteTakingHelper check new profiles' Play-Store-enabled
states when they're added. It appears that
OnArcPlayStoreEnabledChanged() is now not called in this
case, resulting in the list of Android note-taking apps
sometimes not being updated after login.
BUG=700554
Review-Url: https://codereview.chromium.org/2777253002
Cr-Commit-Position: refs/heads/master@{#459921}
(cherry picked from commit e96743eac963561dec6ec4d0f07f647cb27bc380)
Review-Url: https://codereview.chromium.org/2780513005 .
Cr-Commit-Position: refs/branch-heads/3029@{#464}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[GPU Workaround] Re-enable disable_chromium_framebuffer_multisample on Nexus 7g2 and alike
Somehow it has an interaction with the other workaround
force_update_scissor_state_when_binding_fbo0, disabling it would make
https://crbug.com/670607 to repro again. This CL re-enables it.
WebGL2 support on those devices are disabled as well.
BUG=698197
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2760073003
Cr-Commit-Position: refs/heads/master@{#459965}
(cherry picked from commit 06be3b5e0202f6c0b4aa4fc331e74ceada3f18ba)
Review-Url: https://codereview.chromium.org/2784723003 .
Cr-Commit-Position: refs/branch-heads/3029@{#463}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge-m58] Revert of Extensions: Only create Web request rules registry if Declarative Web Request is enabled. (patchset #4 id:60001 of https://codereview.chromium.org/2705513002/ )
Reason for revert:
Declarative Web Request is enabled on Stable through <webview>. Hence we can't disable creation of rules registry on Stable.
Original issue's description:
> Extensions: Only create Web request rules registry if Declarative Web Request is enabled.
>
> Currently the Web Request rules registry required by the Declarative Web
> Request API is created on all Chrome channels, even though the Declarative Web
> Request API is disabled on Stable. The UMA metric
> Extensions.NetworkDelayRegistryLoad shows significant delay for some web
> requests which are blocked due to the loading of the Web Request rules
> registry even on Stable. The mean delay is around 1.7 sec and the median delay
> is around 50ms.
>
> This CL modifies RulesRegistryService::EnsureDefaultRulesRegistriesRegistered
> to ensure the Web Request rules registry is only created for the channels on
> which the Declarative Web Request API is enabled. To do this,
> Feature::IsAvailableToChannel is introduced.
>
> BUG=693243
>
> Review-Url: https://codereview.chromium.org/2705513002
> Cr-Commit-Position: refs/heads/master@{#452240}
> Committed: https://chromium.googlesource.com/chromium/src/+/a77b53baca5f2a4ff102592c17c8ea3f53dd5307
BUG=693243
Review-Url: https://codereview.chromium.org/2773593003
Cr-Commit-Position: refs/heads/master@{#459269}
(cherry picked from commit 9df2cccc337ca57188f9709b2205439347870606)
Review-Url: https://codereview.chromium.org/2783543003 .
Cr-Commit-Position: refs/branch-heads/3029@{#462}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Android] Context menu and overflow item of CCT incorrect on Acer Predator when default browser is set
When the default browser is selected, the overflow menu of CCT should
show "Open in [Default browser]" item and context menu should show "Open
in Chrome incognito tab" and "Open in new Chrome tab". While on Acer
Predator, items are still "Open in browser". This bug only happens on
Acer Predator.
It turns out that PackageMangaer on Acer Predator cannot find any package
which could resolve VIEW intent for HTTP sample url. To fix this, change
the sample url to HTTPS.
BUG=702795
NOTRY=true
NOPRESUBMIT=true
Original-Review-Url: https://codereview.chromium.org/2771173002
Original-Cr-Commit-Position: refs/heads/master@{#460180}
(cherry picked from commit d9d08ba6477548fb48ce55cd1939b082d71b693c)
Review-Url: https://codereview.chromium.org/2780903002
Cr-Commit-Position: refs/branch-heads/3029@{#461}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge] Fix minidump-related JobScheduler test failures.
BUG=694884
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2753173002
Cr-Commit-Position: refs/heads/master@{#457650}
(cherry picked from commit 0c77af249cab19e99fc0024b828373b1751633e2)
Review-Url: https://codereview.chromium.org/2779693004 .
Cr-Commit-Position: refs/branch-heads/3029@{#460}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge] [Android Crash Reporting] Allow uploading minidumps via the JobScheduler
The new functionality is guarded behind a Feature.
BUG=694884
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2737263006
Cr-Commit-Position: refs/heads/master@{#457584}
(cherry picked from commit 8a5492dc16ac148bde50b46ca756f95a655fad58)
Review-Url: https://codereview.chromium.org/2778353002 .
Cr-Commit-Position: refs/branch-heads/3029@{#459}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix popunders spawned from a subframe.
BUG=705316
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2773403002
Cr-Commit-Position: refs/heads/master@{#459835}
(cherry picked from commit 8d1aa16d8f9e854e3f099f9fad9866efe072f821)
Review-Url: https://codereview.chromium.org/2778113003 .
Cr-Commit-Position: refs/branch-heads/3029@{#458}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/
According to the discussion in http://crbug.com/702251, we decide to revert this
change on all platforms, and propose a more comprehensive change on Mac OS
during M59.
BUG=702251, 680809
Review-Url: https://codereview.chromium.org/2778523002
Cr-Commit-Position: refs/heads/master@{#459639}
(cherry picked from commit e84b99c44420c5214aaf0d6b095130f5f6535a4e)
Review-Url: https://codereview.chromium.org/2778063004 .
Cr-Commit-Position: refs/branch-heads/3029@{#457}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge 58: Keep old WebLayer alive until setWebLayer() is completed in WebMediaPlayerMS
This Cl tries to adress the crashes listed in the bug below. The crash points
to HTMLMediaElement::setWebLayer() where there are operations done on the old
WebLayer. We should keep the old WebLayer alive in WebMediaPlayerMS until
those are completed.
BUG=705448
TEST=Modified RotationChange unittest.
Review-Url: https://codereview.chromium.org/2782433002
Cr-Commit-Position: refs/heads/master@{#459856}
(cherry picked from commit 0ce2435b3843ad695ff354cd3383bbfd354b2fac)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2779753004
Cr-Commit-Position: refs/branch-heads/3029@{#456}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix caret visual rect on compositing change
We should not clear CaretDisplayItemClient::m_localRect in
CaretDisplayItemClient::clearPreviousVisualRects() (which is called
on compositing change) because
- it doesn't change on compositing change;
- compositing change happens after updateStyleAndLayoutIfNeeded();
- we'll need m_localRect to calculate the new visual rect during paint
invalidation.
BUG=704443
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2777183003
Cr-Original-Commit-Position: refs/heads/master@{#459833}
Review-Url: https://codereview.chromium.org/2779953002
Cr-Commit-Position: refs/branch-heads/3029@{#455}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Cherry-picked Display the preload Tab if it replaces the current Tab.
BUG=698833, 702431, 705637
Original Review-Url: https://codereview.chromium.org/2759563003
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2779763006
Cr-Commit-Position: refs/branch-heads/3029@{#454}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge M58] arg: Enable Play Store item in App Launcher for managed case.
This fixes issue when Play Store item is not available for ARC
managed and enabled case.
NOTRY=true
NOPRESUBMIT=true
[email protected]
BUG=700601
BUG=b/36043525
TEST=Extended unit_tests
TEST=Manually on Caroline, normal case (@gmail.com), managed
enabled (@google.com) and managed disabled (@chromium.org).
Review-Url: https://codereview.chromium.org/2738983003
Cr-Commit-Position: refs/heads/master@{#455894}
(cherry picked from commit 8d651457cff4086e56e9861bc24ae1f127b590d6)
Review-Url: https://codereview.chromium.org/2781623005
Cr-Commit-Position: refs/branch-heads/3029@{#453}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
node-set($x), when $x is empty, should not halt XSLT processing
node-set is polymorphic; if called with a string, it returns a
node-set containing a text node with that content. The libxslt roll in
r425586 broke this behavior because Blink's fork of the node-set
extension returned a text node without an owner document. Fix that.
BUG=689977
Review-Url: https://codereview.chromium.org/2750943004
Cr-Commit-Position: refs/heads/master@{#457692}
(cherry picked from commit 3f6e482b7f13c1fc5bd68227321ef6da0ddf9937)
Review-Url: https://codereview.chromium.org/2772323005 .
Cr-Commit-Position: refs/branch-heads/3029@{#452}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
predictors: Fix incorrect histogram name.
Add Experimental suffix for FirstMeaningfulPaint histogram.
histograms.xml already contains correct name.
BUG=680049
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2775243002
Cr-Commit-Position: refs/heads/master@{#459783}
(cherry picked from commit 60ae8b467eae2696d4df9f87616b381dcaaf02b8)
Review-Url: https://codereview.chromium.org/2779933003
Cr-Commit-Position: refs/branch-heads/3029@{#451}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
NTP: Prevent conflict of dismiss animations and scroll position handling.
When an item is removed, the RecyclerView fires onScrolled once with the end value, and animates the remaining items into place via translation, without firing intermediate scroll events. Calling computeVerticalScrollOffset returns the end scroll state, not any intermediate animated values, because it's not the property being animated.
We disable all focus change animations while the NewTabPageLayout is moved by the RecyclerView, and then update afterwards.
BUG=696972
Review-Url: https://codereview.chromium.org/2776183002
Cr-Commit-Position: refs/heads/master@{#460061}
(cherry picked from commit ce4d88aebc3c49570ad75ceb0877e74c72aa4a4d)
Review-Url: https://codereview.chromium.org/2780813002 .
Cr-Commit-Position: refs/branch-heads/3029@{#450}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Do not launch external apps while page is scrolling
This is a long outstanding bug of launching a Google app while page
is scrolling. The root cause is that a URL is loaded as the page
scrolls down. Since the user touched the screen to initiate the scroll,
the "link clicked" logic took that scroll touch as a link click and
the URL load is then treated as if the user has clicked on the link.
This affects links such as maps.google.com and youtube.com.
Refer to http://crbug/704417 regarding the following types of
navigations. This CL simplifies the logic, at the expense of a change
in behavior:
[1] MV tiles - No change in behavior
[2] Bookmarks - Used to launch native iOS app, now opens web site in browser.
[3] Recently closed - Used to launch native iOS app, now opens web site in browser.
BUG=663583,700709
TEST=Test loading of Google web sites (maps, drive, etc). Check redirects. Embedded YT videos and Maps.
Review-Url: https://codereview.chromium.org/2764033005
Cr-Commit-Position: refs/heads/master@{#459072}
(cherry picked from commit fd4f2da01569ad80206f09edd2b585e186d06ed8)
Review-Url: https://codereview.chromium.org/2776393002 .
Cr-Commit-Position: refs/branch-heads/3029@{#449}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Refine the accessibility label of Clear Browsing Data flow.
When using VoiceOver, the user taps a button to Clear Browsing Data then
gets on a new Clear Browsing Data button, which can be confusing.
To make it more understandable, this CL changes the accessibility label
of the second button to "Confirm Clear Browsing Data".
This is a reland of https://codereview.chromium.org/2763943002.
This reverts commit 0c270621c300c0948fd64b24b7a2907fcf665e48.
BUG=688415
[email protected]
TEST=- Activate VoiceOver.
- Clear browsing data.
=> Verify that the action sheet "Clear Browsing Data" is read "Confirm
Clear Browsing Data".
Review-Url: https://codereview.chromium.org/2766923002
Cr-Commit-Position: refs/heads/master@{#459071}
(cherry picked from commit c99783c636b1169cb670c2a042b107c7371c4221)
Review-Url: https://codereview.chromium.org/2779923002 .
Cr-Commit-Position: refs/branch-heads/3029@{#448}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Allow webview guests to skip WAR checks in ShouldAllowOpenURL (Merge to M58)
Prior to r429532, the web-accessible resource checks in
ShouldAllowOpenURL were skipped for all schemes other than
HTTP/HTTPS/chrome-extension. After r429532, we've started enforcing
them for most other schemes, but this breaks navigations from webview
guests to webview-accessible app resources whenever those go through
the OpenURL path, since the webview-accessible resource check is done
separately later, in AllowCrossRendererResourceLoadHelper, and
ShouldAllowOpenURL was killing the navigation before it ever got
there.
This CL will return webview guests to the previous behavior.
BUG=691941
Review-Url: https://codereview.chromium.org/2766313002
Cr-Commit-Position: refs/heads/master@{#458959}
(cherry picked from commit f89e04046aaac44ecad27056fb856c3d6e37370f)
Review-Url: https://codereview.chromium.org/2781783002 .
Cr-Commit-Position: refs/branch-heads/3029@{#447}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.40
Cr-Commit-Position: refs/branch-heads/3029@{#446}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[FRE] Unify chrome://welcome and chrome://welcome-win10 button styles.
The "SIGN IN" button in chrome://welcome and the "CONTINUE" button in
chrome://welcome-win10 are styled differently. This CL unifies them.
Details:
- "SIGN IN": Fix color on mousedown, so that it does not turn dark as
with the case for keyboard nav.
- "SIGN IN": Copy "CONTINUE" button's :hover style, shadow, and
animation.
- "CONTINUE": Gain dark color when focused by keyboard nav.
BUG=657106
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2764623002
Cr-Commit-Position: refs/heads/master@{#459108}
(cherry picked from commit 8fe88eadb09b3307f897d17f1306fdaa78afe36f)
Review-Url: https://codereview.chromium.org/2780713002 .
Cr-Commit-Position: refs/branch-heads/3029@{#445}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Kick incognito tabs from CCTs to tabbed mode.
BUG=697849
Review-Url: https://codereview.chromium.org/2774763002
Cr-Commit-Position: refs/heads/master@{#459560}
(cherry picked from commit 161a32635f89a1f6bfde9e8f5836d747529a0d56)
Review-Url: https://codereview.chromium.org/2777223003 .
Cr-Commit-Position: refs/branch-heads/3029@{#444}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
DevTools: format generator objects as objects
Objects of type 'generator' incorrectly went through the function formatter.
Now they do go through the regular object formatter.
BUG=704380
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2769973004
Cr-Commit-Position: refs/heads/master@{#459298}
(cherry picked from commit 088e4a90947078a9dd6db43a21770ad14d0b9e43)
Review-Url: https://codereview.chromium.org/2779703002
Cr-Commit-Position: refs/branch-heads/3029@{#443}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add PuChuangSiDa CT log to known logs list
They have completed their initial compliance monitoring.
BUG=667663
Review-Url: https://codereview.chromium.org/2759293002
Cr-Commit-Position: refs/heads/master@{#458762}
(cherry picked from commit 588960fc36ee4335083ae671f7109b5b5f1d4d08)
Review-Url: https://codereview.chromium.org/2772413002 .
Cr-Commit-Position: refs/branch-heads/3029@{#442}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Recording download mime types for normal profile
BUG=699807
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2758453003
Cr-Commit-Position: refs/heads/master@{#459344}
(cherry picked from commit d87debc9b133cb364f9b307d9643ebb7c5bd7fb6)
Review-Url: https://codereview.chromium.org/2779683003
Cr-Commit-Position: refs/branch-heads/3029@{#441}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Mac] Disable the "AppleScriptExecuteJavaScript" feature
BUG=701994
Review-Url: https://codereview.chromium.org/2770083003
Cr-Commit-Position: refs/heads/master@{#459470}
(cherry picked from commit 2472a52a02924c39e7fdc5f9d4e140543cfe8238)
Review-Url: https://codereview.chromium.org/2772263003 .
Cr-Commit-Position: refs/branch-heads/3029@{#440}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[ash-md] Restores handler for VPN Disconnect button in system menu
The handler was unintentionally lost in MD work which got exposed after
turning the MD to be on by default in M-56.
Breaking CL - https://codereview.chromium.org/2463163002
BUG=704299
Review-Url: https://codereview.chromium.org/2768973002
Cr-Commit-Position: refs/heads/master@{#459182}
(cherry picked from commit c2637be18c2e52da142d6cbf646ab82045e13218)
Review-Url: https://codereview.chromium.org/2782473002 .
Cr-Commit-Position: refs/branch-heads/3029@{#439}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Updating XTBs based on .GRDs from branch 3029
Cr-Commit-Position: refs/branch-heads/3029@{#438}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Remember User locked rotation
* Save when the toggle state changes, as that's
only time the value changes.
* implement reverse lock.
BUG=695281, 683456
TEST=manual, covered by unit test
Review-Url: https://codereview.chromium.org/2773013003
Cr-Commit-Position: refs/heads/master@{#459502}
(cherry picked from commit 28bd8173b80ae1fe5e22875580051664cd97363d)
(cherry picked from commit ffb46dd77d7c4702110bf9dd6f3a9d35f70b41e5)
Review-Url: https://codereview.chromium.org/2777163003 .
Cr-Commit-Position: refs/branch-heads/3029@{#437}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
User orientation lock
* Added user locked orientation.
Once it's locked, the orientation will be used as a preferred orientation.
- If the active appilcation's orientation is any, the user locked orientation will be used.
- If the active appilcation's orientation is specified, the user locked orientation will be ignored
and uses the application's orientation.
* Exclude windows that does not have AppType because they do not control orientation into account.
For example, task manager, app list shouldn't affect orientation.
* added ScreenOrientationControllerTestApi
Next steps:
- landscape / portrait app should lock to secondary/primary.
- remember and restore the locked state.
- handle rotation change from chrome.system.display api.
- Add portrait/landscape lock icon and make UI consistent with Android rotation lock UI.
BUG=683456
TEST=manual, unitt tests
Review-Url: https://codereview.chromium.org/2757493002
Cr-Commit-Position: refs/heads/master@{#459291}
(cherry picked from commit a5176fd790a6ccc800274a4135dbdc7476deac88)
(cherry picked from commit a85beb49b1025a0430f5886c60b4d8768ef66352)
Review-Url: https://codereview.chromium.org/2776283002 .
Cr-Commit-Position: refs/branch-heads/3029@{#436}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect so that QuicStreamFactory::Job will not hang.
Currently, if QuicConnection is closed during crypto_stream_->CryptConnect(),
it will silently post a task to notify QuicStreamFactory to of the session
close without notifying the QuicStreamFactory::Job. This causes
QuicStreamFactory::Job to hang. Subsequent alt jobs will be bound to the
hanging QUIC job, and will never win race over TCP and get cleaned up.
BUG=700617
Review-Url: https://codereview.chromium.org/2766603004
Cr-Commit-Position: refs/heads/master@{#459271}
(cherry picked from commit 363c91c57a5ae99e63a138555afa83dc02262325)
[email protected]
Review-Url: https://codereview.chromium.org/2780523002 .
Cr-Commit-Position: refs/branch-heads/3029@{#435}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge into M58.
Fall back to heap allocation in courgette alloc.
BUG=704783
Review-Url: https://codereview.chromium.org/2775893002
Cr-Commit-Position: refs/heads/master@{#459554}
(cherry picked from commit e5d0b0e21128dafea994f88487e49f1c43fe4550)
Review-Url: https://codereview.chromium.org/2778013002 .
Cr-Commit-Position: refs/branch-heads/3029@{#434}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Offline Pages] Add UMA to record final offline request status and loading failed error code.
BUG=704999
Review-Url: https://codereview.chromium.org/2751253004
Cr-Commit-Position: refs/heads/master@{#458001}
(cherry picked from commit 642d1848697b731de396d6df1577443e33e17ad0)
Review-Url: https://codereview.chromium.org/2779783002 .
Cr-Commit-Position: refs/branch-heads/3029@{#433}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
M58: Initialize COM STA in the service process.
BUG=704754
Review-Url: https://codereview.chromium.org/2772573004 .
Cr-Commit-Position: refs/branch-heads/3029@{#432}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Revert "Send click event after pointer capturing retarget"
Reason for revert:
Reverting all the changes related to the click target in capturing as they are splitted across multiple commits.
This reverts commit 14cea387ce9359e5f9fe3e90c996adf75e092e64.
BUG=689158
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2771463002
Cr-Commit-Position: refs/heads/master@{#458743}
(cherry picked from commit 44b8e6b6355c3a0fe61bc6bfb38fb63632618a81)
(cherry picked from commit 47ec688a15c4a44f86bbd02785d7e41accf6a986)
Review-Url: https://codereview.chromium.org/2781623002 .
Cr-Commit-Position: refs/branch-heads/3029@{#431}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
cros: Defer lockscreen updateUserImage and loadUser calls.
Add DCHECKs so we can get stack traces to confirm the root cause and change fix if needed.
BUG=699798
Review-Url: https://codereview.chromium.org/2766393003
Cr-Commit-Position: refs/heads/master@{#458952}
(cherry picked from commit cf76073aac63d2e460740d7562ee1523e6a0c7d8)
Review-Url: https://codereview.chromium.org/2779743002 .
Cr-Commit-Position: refs/branch-heads/3029@{#430}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Revert of Add use count for click retargeting due to capture
Reason for revert:
Reverting all the changes related to the click target in capturing as they are splitted across multiple commits.
This reverts commit 18a3165ddb7326845a6028b1e3f93f7d347bde95.
Original issue's description
Since pointer capture changes the target of the
following events for that pointer it potentially
changes the target of the click. Considering the
changed target for calculating the click target
may cause some websites to break. So this CL
adds a usecount for that case. Note this is an
upper bound on the breakage as lots of pages
may not have any listener for these click events
or just not break due to this retargetting.
BUG=699933
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2769433002
Cr-Commit-Position: refs/heads/master@{#458550}
(cherry picked from commit 3d84b135e186d7d22d9597aa752ddc8f345be102)
(cherry picked from commit e96cb455bcb1979f239b242a2f81f5ed50572b28)
Review-Url: https://codereview.chromium.org/2777213002 .
Cr-Commit-Position: refs/branch-heads/3029@{#429}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Android] Record user actions of new context menus for CCT
Add the logic to record user actions for the newly added context
menus ("Open in new Chrome tab", "Open in Chrome incognito tab",
"Open in browser") for CCT. Also record the user action of "Open in
Chrome" for Fullscreen mode.
Change the title from "Open in Chrome incognito tab" to "Open in
incognito tab" since the translation for the former one needs too much
characters to show on the small screen devices.
BUG=703426
NOTRY=true
NOPRESUBMIT=true
Original-Review-Url: https://codereview.chromium.org/2767703002
Original-Cr-Commit-Position: refs/heads/master@{#459178}
(cherry picked from commit d8860857f5aa2a2a358c31c1122eccca7188faf9)
Review-Url: https://codereview.chromium.org/2771283002
Cr-Commit-Position: refs/branch-heads/3029@{#428}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Mac] Fix keyword hint spacing in RTL
BUG=668380
Review-Url: https://codereview.chromium.org/2755163002
Cr-Commit-Position: refs/heads/master@{#458064}
(cherry picked from commit ab1f101d05be92332f8c4a8532f6807e580c0568)
[Mac] Added missing right padding for keyword hint
BUG=668380
Review-Url: https://codereview.chromium.org/2753103002
Cr-Commit-Position: refs/heads/master@{#457687}
(cherry picked from commit e6d41b083683603ccb42c1d01c0389d12c219cb8)
Review-Url: https://codereview.chromium.org/2772383002 .
Cr-Commit-Position: refs/branch-heads/3029@{#427}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix a crash that ViewAndroidHelper could be NULL
From the crash stack, it looks like some webcontents might not have a tab
So the ViewAndroidHelper will be null when trying to show the storage permission dialog
This CL performs a null check before preceeding to get the window_android
[email protected]
BUG=702534
Review-Url: https://codereview.chromium.org/2765993002
Cr-Commit-Position: refs/heads/master@{#459160}
(cherry picked from commit d20d72add19ce77235c104bfe6cab1d1236d7aa6)
Review-Url: https://codereview.chromium.org/2781593002 .
Cr-Commit-Position: refs/branch-heads/3029@{#426}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Update expat to 2.2.0 to fix CVE vulnerability.
Security fixes:
CVE-2016-0718 -- Fix crash on malformed input
CVE-2016-4472 -- Improve insufficient fix to CVE-2015-1283 /
CVE-2015-2716 introduced with Expat 2.1.1
CVE-2016-5300 -- Use more entropy for hash initialization
than the original fix to CVE-2012-0876
CVE-2012-6702 -- Resolve troublesome internal call to srand
that was introduced with Expat 2.1.0
when addressing CVE-2012-0876 (issue #496)
BUG=703537
Review-Url: https://codereview.chromium.org/2761253002
Cr-Commit-Position: refs/heads/master@{#459025}
(cherry picked from commit 33a5703a620ec246ee08214e6c880068b6e9d687)
Review-Url: https://codereview.chromium.org/2781503002 .
Cr-Commit-Position: refs/branch-heads/3029@{#425}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge to M-58] Fix Password bubble title misalignment.
This CL sets correct margins for Password Bubbles titles. Screenshots with explanation what's wrong and how bubbles look like with this CL are attached on the bug.
BUG=704575
Review-Url: https://codereview.chromium.org/2773733002
Cr-Commit-Position: refs/heads/master@{#459418}
(cherry picked from commit bf765c663d54787ab8dc3bb1b8c1748aab1d0eea)
Review-Url: https://codereview.chromium.org/2777123002 .
Cr-Commit-Position: refs/branch-heads/3029@{#424}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Prerender] Remove the "wash" origin in prerender histograms
This origin was introduced at a time where the prerender metrics
were unable to keep track of multiple origins simultaneously.
When several origins were active at once, the origin would be reported
as a "wash".
This limitation no longer exists, and origins now don't interfere with
each other. Moreover, the wash origin is actually harmful now because
it destroys information.
BUG=704868
Review-Url: https://codereview.chromium.org/2769903005
Cr-Commit-Position: refs/heads/master@{#459437}
(cherry picked from commit 9aac56e95a24dcdeec343f906922f06cddfdf5a5)
Review-Url: https://codereview.chromium.org/2775263002 .
Cr-Commit-Position: refs/branch-heads/3029@{#423}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Make the WebView license available to the stub.
The stub WebView still needs to be able to respond to the platform
intent used to display the open source licenses. To that end:
1) Move the declaration of the activity and content provider for the
license to the part of the manifest shared with the stub.
2) Add an asset target that includes the license file - it's too
difficult to load the asset from the donor APK at present.
3) Reimplement the content provider using a pipe so that it doesn't need
to extract the license to the cache directory. This removes the need
to depend on FileUtils.
4) Switch the activity back to using android.util.Log.
The resulting license viewer code doesn't depend on any other chromium
classes and thus is easy to include in the stub.
BUG=664456
Review-Url: https://codereview.chromium.org/2771223002
Cr-Commit-Position: refs/heads/master@{#459524}
(cherry picked from commit 8954062900583a7364f1b981227c94e9e034e1b3)
Review-Url: https://codereview.chromium.org/2779613002 .
Cr-Commit-Position: refs/branch-heads/3029@{#422}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.39
Cr-Commit-Position: refs/branch-heads/3029@{#421}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Offline pages] Ensuring native init when OBT run though JobScheduler
When OfflineBackgroundTask is scheduled and run through JobScheduler
we are currently experiencing an assert on debug builds (and this
should lead to NPE on release builds). This patch fixes the issue and
is intended to be handling it in the short term, until
BackgroundTaskScheduler provides a proper support for that scenario.
BUG=704990
[email protected]
Review-Url: https://codereview.chromium.org/2773843003
Cr-Commit-Position: refs/heads/master@{#459525}
(cherry picked from commit b382956014fb295322ee15b14f72712b93b174aa)
Review-Url: https://codereview.chromium.org/2774193002 .
Cr-Commit-Position: refs/branch-heads/3029@{#420}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.38
Cr-Commit-Position: refs/branch-heads/3029@{#419}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
ChromeOS OOBE: Fix OK button on Welcome screen.
This Cl fixes issue "Let’s go button grows taller when tapped".
BUG=700643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2745843004
Cr-Commit-Position: refs/heads/master@{#456567}
(cherry picked from commit a45b9f4f9b55667f056c46915642691a112a2a3a)
Review-Url: https://codereview.chromium.org/2776013002 .
Cr-Commit-Position: refs/branch-heads/3029@{#418}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Disable SPInvalidation by default
We decided to delay launch until M59.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
[email protected]
BUG=692614
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2772833003
Cr-Original-Commit-Position: refs/heads/master@{#459201}
Review-Url: https://codereview.chromium.org/2777673002
Cr-Commit-Position: refs/branch-heads/3029@{#417}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.37
Cr-Commit-Position: refs/branch-heads/3029@{#416}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge m58] gpu: DisableCrashLimit cover crash before initialize
Android already sets kDisableGpuProcessCrashLimit since it has no
software fallback. Very rarely, but not impossible, the gpu process can
die before the initialize message is sent and received. This also causes
the gpu process to be disabled, which can cause a busy loop.
Also disable checking for initialized if kDisableGpuProcessCrashLimit is
set.
BUG=701041
Review-Url: https://codereview.chromium.org/2746333007
Cr-Commit-Position: refs/heads/master@{#457313}
(cherry picked from commit a1e402648a4863df452cb8e341faeca99ae4d3f7)
Review-Url: https://codereview.chromium.org/2774053002 .
Cr-Commit-Position: refs/branch-heads/3029@{#415}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix the position of AutofillClient for PasswordAutofillManager when the focused form element is inside OOPIF
When a form element is inside an OOPIF, the coordinates which are sent from
renderer are with respect to the WebFrameWidget's coordinates and need to be
transformed to root coordinate on the browser side. Without this change the
position of the autofill pop-up is incorrect.
This CL transforms the element bound to root view's coordinate before showing
the autofill pop-up.
BUG=686129
Review-Url: https://codereview.chromium.org/2754033002
Cr-Commit-Position: refs/heads/master@{#458593}
(cherry picked from commit 6f15a2dc3a3b9bd111352a58c40cf1a1ea0e9652)
Review-Url: https://codereview.chromium.org/2770363002 .
Cr-Commit-Position: refs/branch-heads/3029@{#414}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge to M58: AXObject::performDefaultAction() should focus if it can't click
The user-visible bug here is that sending a CLICK event to a text field on
Android does nothing, because a text field doesn't have a default action.
I could fix this on the Android side, but this seems wrong to me. If
performDefaultAction() is called on a focusable control, I think the natural
thing to do is focus it if there's no "press" behavior. So I think we should
handle that generally.
Let me know if you have any objection and I could make it more narrow. But to
me it seems more useful this way.
BUG=703659
Review-Url: https://codereview.chromium.org/2772913003
Cr-Commit-Position: refs/heads/master@{#459448}
(cherry picked from commit cbf2ebc6e589a5aa81d29c78cf392182de4329bb)
Review-Url: https://codereview.chromium.org/2770333002 .
Cr-Commit-Position: refs/branch-heads/3029@{#413}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Offline pages] Check errors and invalidate pointers only for mainframe for navigation
BUG=704311
Review-Url: https://codereview.chromium.org/2764373004
Cr-Commit-Position: refs/heads/master@{#459263}
(cherry picked from commit 69ad9a9d95cdf1ca2e7ffafb03a6e7ffdd74106d)
Review-Url: https://codereview.chromium.org/2771933004 .
Cr-Commit-Position: refs/branch-heads/3029@{#412}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Include control clip in list of clip-related properties.
BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2770943003
Cr-Commit-Position: refs/heads/master@{#459407}
(cherry picked from commit e038518f79d429d7ccebaa16aae92773bf238459)
Review-Url: https://codereview.chromium.org/2777493003 .
Cr-Commit-Position: refs/branch-heads/3029@{#411}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Revert: "Let SVGForeignObject's local SVG coordinates mean what it should"
This patch caused a hit testing regression with foreign objects. While
the fix is not hard, we are going to roll out as a precaution (and merge
to stable).
This is a manual revert of https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57
(commit number #435337) due to revert conflicts.
BUG=704643
Review-Url: https://codereview.chromium.org/2767343003
Cr-Commit-Position: refs/heads/master@{#459330}
(cherry picked from commit 0cfb512a4ae94e681bd10a15d93abd740f330e3e)
Review-Url: https://codereview.chromium.org/2766263008 .
Cr-Commit-Position: refs/branch-heads/3029@{#410}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Offline pages] Ensuring tasks scheduled through GCM NM are persisted
We are currently not persisting tasks scheduled through GCM Network
Manager, which means requests to offline pages in the background will
not be resumed after a device restart.
This patch fixes the issue.
BUG=704610
Review-Url: https://codereview.chromium.org/2769233003
Cr-Commit-Position: refs/heads/master@{#459174}
(cherry picked from commit 0c1ab0868b12be571311df463894f06e47c8e62a)
Review-Url: https://codereview.chromium.org/2776723002 .
Cr-Commit-Position: refs/branch-heads/3029@{#409}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Replace CHECK with DCHECK in BestEngineForKeyword
[email protected]
BUG=697745
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2766863002
Cr-Commit-Position: refs/heads/master@{#458727}
(cherry picked from commit f7ea59441bc8b99523126a57929559c2137f04d4)
Review-Url: https://codereview.chromium.org/2774893002 .
Cr-Commit-Position: refs/branch-heads/3029@{#408}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge of "Remote fetch device status (attributes and logs) command" to M58
This CL introduces a remote command that enables device administrators to remotely fetch device status (attributes and logs). Attributes were being uploaded every 3 hours and logs every 12 hours from the device side, and there was no way to trigger a remote refresh.
More context can be found by reading the design doc go/remote-audio-management
The new functionality was manually tested; remote reboot command was hijacked and rewired to decode into this command and then on the server side (CPanel admin) I clicked on "REBOOT NOW" and I observed the device attributes and logs being updated.
P.S. I've also fixed up some linter errors.
BUG=686389
TEST=Manually tested new behaviour.
Review-Url: https://codereview.chromium.org/2765463002
Cr-Commit-Position: refs/heads/master@{#459037}
(cherry picked from commit 35b9ec40290254e484cc17e76ee5205b618e23c9)
Review-Url: https://codereview.chromium.org/2774803003 .
Cr-Commit-Position: refs/branch-heads/3029@{#407}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
needsPaintInvalidation() should not return true for selection.
In [1] we introduced a paint invalidation constant for repainting
selection. needsPaintInvalidation() started to also return true when
only the selection needed paint invalidation. Callers of that method
assumes that true will cause at least a full element repaint which made
us skip setting the diff to invalidate the object and only invalidate
the selection in some cases. Instead, only return true for
PaintInvalidationObject and PaintInvalidationSubtree.
[1] https://crrev.com/eff357ef
[email protected]
BUG=697337
Review-Url: https://codereview.chromium.org/2727843004
Cr-Commit-Position: refs/heads/master@{#454564}
(cherry picked from commit c63e571885b21aa510dc323ecb1c5bc18f1ed29b)
Review-Url: https://codereview.chromium.org/2774763003 .
Cr-Commit-Position: refs/branch-heads/3029@{#406}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge "CSS Selector: Fix a regression of :first-child and :last-child invalidation" to M58.
https://codereview.chromium.org/2306323002 caused a regression of :first-child and
:last-child invalidation because the timing of ContainerNode::childrenChanged was
slightly changed for multiple nodes insertion.
Before: childrenChanged was called on every node insertion
After: childrenChanged was called after inserting all nodes
This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges. So this definition change is safe.
BUG=702104
Review-Url: https://codereview.chromium.org/2772463004
Cr-Commit-Position: refs/heads/master@{#459023}
(cherry picked from commit e89e9ca08e4abca7bf13d7424434b301caf5b4a5)
Review-Url: https://codereview.chromium.org/2774753003 .
Cr-Commit-Position: refs/branch-heads/3029@{#405}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge "Updating :in-range should not rely on validation." to M58.
m_validityIsDirty is not related to isInRange() and isOutOfRange().
This fixes sibling style invalidation using invalidation sets for
:in-range and :out-of-range changes when value changes through
setAttribute.
[email protected]
BUG=699884
Review-Url: https://codereview.chromium.org/2764023003
Cr-Commit-Position: refs/heads/master@{#458576}
(cherry picked from commit df2ef06a75aae87d449e2f801e90fd418679871b)
Review-Url: https://codereview.chromium.org/2777543002 .
Cr-Commit-Position: refs/branch-heads/3029@{#404}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
ChromeOS OOBE: replace i18n macro with i18n-values
i18n macro doesn't support language switching, so we need to use i18n-values.
BUG=704028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2767693003
Cr-Commit-Position: refs/heads/master@{#458970}
(cherry picked from commit 893656ac30d6e0d8afef9d0ce458276effb36dff)
Review-Url: https://codereview.chromium.org/2775683003 .
Cr-Commit-Position: refs/branch-heads/3029@{#403}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
WebVR: match GVR renderbuffer resolution to canvas resolution
This is a partial revert of the VrShellGl refactor r438256 aka
http://crrev.com/2562733002 which had commented out this resolution
change.
Matching resolution improves visual quality and performance, the
internal rendering was at 3606x2268 instead of the intended 2560x1440
on a Pixel XL.
(This is a manual bugfix, basically a partial revert of 0be372f1b41a7e7ad897743abd6b265da979a82e or equivalently a partial cherry pick of 362c621af1b1c9ad8da5bac607a082108b4aa213, as approved by amineer@. Please see bug for details.)
BUG=704364
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2775513002
Cr-Commit-Position: refs/branch-heads/3029@{#402}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
ChromeOS OOBE: Update alignment of checkbox label.
BUG=702951
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2759043002
Cr-Commit-Position: refs/heads/master@{#458969}
(cherry picked from commit 5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861)
Review-Url: https://codereview.chromium.org/2771013003 .
Cr-Commit-Position: refs/branch-heads/3029@{#401}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
DevTools: Fixes regression in cookies tab in Network panel having no output
Clicking on a request in the Network panel and selecting the cookies tab resulted in no output in this tab, despite there being cookies set.
This appears to be a regression in https://codereview.chromium.org/2714913002
BUG=702940
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2760013002
Cr-Commit-Position: refs/heads/master@{#458847}
(cherry picked from commit b8fba9d8708e06e1543bc3d9fe589640c8853137)
Review-Url: https://codereview.chromium.org/2768383003
Cr-Commit-Position: refs/branch-heads/3029@{#400}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.36
Cr-Commit-Position: refs/branch-heads/3029@{#399}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add black background to ARC maximzied window as well as fullscreen.
BUG=703731
TEST=unit tests, manual
Review-Url: https://codereview.chromium.org/2764733002
Cr-Commit-Position: refs/heads/master@{#458609}
(cherry picked from commit 69232cda736bc8b0570bc833ceb2323bf6bcd451)
Review-Url: https://codereview.chromium.org/2771663005 .
Cr-Commit-Position: refs/branch-heads/3029@{#398}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Updating XTBs based on .GRDs from branch 3029
Cr-Commit-Position: refs/branch-heads/3029@{#397}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fixed broken string resource
BUG=701187
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2749633007
Cr-Commit-Position: refs/heads/master@{#456780}
(cherry picked from commit b82e303b7eb71dab3d1a4471a57602ba6f848238)
Review-Url: https://codereview.chromium.org/2772933002
Cr-Commit-Position: refs/branch-heads/3029@{#396}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
WebVR: move animation state check to deferred task
The animation controller or document may have disappeared
in between scheduling the callback and executing it.
BUG=701444
R=bajones, mthiesse
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2752343002
Cr-Commit-Position: refs/heads/master@{#457618}
(cherry picked from commit efd3d31152e48d1089175b9256c56bccbe6d9792)
Review-Url: https://codereview.chromium.org/2771913002
Cr-Commit-Position: refs/branch-heads/3029@{#395}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
WebVR: process animations from posted task to yield for other events
If we call GetVSync inline from OnVSync, we can end up with the next
VSync already being ready and scheduled when we exit, and then we'll process
several frames in a row without ever yielding back to the main event loop,
causing input processing delay.
BUG=701444
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2748293002
Cr-Commit-Position: refs/heads/master@{#457189}
(cherry picked from commit ff386cfefd3fe0f9cef72ff28f7c7f09d972608d)
Review-Url: https://codereview.chromium.org/2774673003
Cr-Commit-Position: refs/branch-heads/3029@{#394}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Lower the webfont loading priority only if the user is in V2 field trial
Currently, the loading priority of web fonts is changed to Low if the
user is on 2G network (regardless of if Chrome is a part of
WebFontsInterventionV2 field trial or not). This CL adds an additional
constraint so that the loading priority is changed only if Chrome is
part of V2 field trial. This makes it possible to quantify the effect
of changing the loading priority as part of the WebFontsInterventionV2
field trial.
BUG=665504
Review-Url: https://codereview.chromium.org/2763523002
Cr-Commit-Position: refs/heads/master@{#458681}
(cherry picked from commit fd4fb29de4630be62b296e01987d7bd09d0e4a6e)
Review-Url: https://codereview.chromium.org/2769183003 .
Cr-Commit-Position: refs/branch-heads/3029@{#393}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Adjust common prefix/suffix correctly for InsertIncrementalTextCommand
In InsertIncrementalTextCommand, when adjusting common prefix/suffix for
grapheme clusters, the old implementation used mismatched offset and node
for the selection. This CL makes them matched. Besides, this CL replaces
wrong DCHECK with truncation when computing common suffix.
BUG=702082
TEST=run_webkit_unit_tests --gtest_filter=
InputMethodControllerTest.SetCompositionWithGraphemeCluster*
Review-Url: https://codereview.chromium.org/2763873003
Cr-Commit-Position: refs/heads/master@{#458669}
(cherry picked from commit 195221de391ce3bf00fb70a7e64995648e535feb)
Review-Url: https://codereview.chromium.org/2774773002 .
Cr-Commit-Position: refs/branch-heads/3029@{#392}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[ash-md] Fixed ShelfBackgroundAnimator to not snap target values when being preempted.
Snapping to the target values was causing the shelf to flicker when dragging a
window while in OVERLAP mode. And on some platforms this contributed to the
shelf incorrectly being painted as DEFAULT mode.
BUG=695901
Review-Url: https://codereview.chromium.org/2749123003
Cr-Commit-Position: refs/heads/master@{#456892}
(cherry picked from commit 27dd2542a15215360c4f4fc8eeca9d72780d5167)
Review-Url: https://codereview.chromium.org/2768933003 .
Cr-Commit-Position: refs/branch-heads/3029@{#391}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Media>UI] Allow the notification info to be updated before playback service is created
This CL fixes an issue that when a playback service is pending for start, and
the playback gets paused, the MediaNotificationInfo is not updated so that when
the service gets started, we are still seeing info with "playing" state.
BUG=704567
Review-Url: https://codereview.chromium.org/2769213002
Cr-Commit-Position: refs/heads/master@{#459139}
(cherry picked from commit 54c2facf2675be87fcbe39b74550b87fc0df08d8)
Review-Url: https://codereview.chromium.org/2775703002 .
Cr-Commit-Position: refs/branch-heads/3029@{#390}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge m58] cc:: Null check OuterViewportScrollLayer too
There are crash reports that OuterViewportScrollLayer is null when the
Inner one is not. The assumption is that blink can send an invalid tree
to cc. So remove the DCHECK, and replace it with a runtime check and
early out instead.
BUG=703416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2769453003
Cr-Commit-Position: refs/heads/master@{#458878}
(cherry picked from commit 97a462d45974e7a4eb0e033730abd8a78aa55e64)
Review-Url: https://codereview.chromium.org/2770043002 .
Cr-Commit-Position: refs/branch-heads/3029@{#389}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Settings reset prompt: the dialog should have focus when shown.
BUG=703701
Review-Url: https://codereview.chromium.org/2764033004
Cr-Commit-Position: refs/heads/master@{#458603}
(cherry picked from commit e33bb720f168fdb711b15b20832632970166a81b)
Review-Url: https://codereview.chromium.org/2763413006 .
Cr-Commit-Position: refs/branch-heads/3029@{#388}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix an issue that OMA download is not intercepted on Android
We use InterceptDownloadResourceThrottle to intercept OMA download.
However, MimeSniffingResourceHandler::MaybeStartInterception always start
the download with is_new_request == false.
This CL fixes the issue by moving InterceptDownloadResourceThrottle out the if(is_new_request) block.
And append the throttle after AppendStandardResourceThrottles so we won't skip safe browsing
This CL also fixes an issue that displayed filename is null on the snackbar
[email protected],[email protected]
BUG=675559
Review-Url: https://codereview.chromium.org/2757403002
Cr-Commit-Position: refs/heads/master@{#458666}
(cherry picked from commit 24c83fb4132db2d3ec271c7ae3ad22f6dcc9b5bc)
Review-Url: https://codereview.chromium.org/2772853002 .
Cr-Commit-Position: refs/branch-heads/3029@{#387}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Clean up video persister when ChromeActivity receives new intent
BUG=703665
Review-Url: https://codereview.chromium.org/2768063002
Cr-Commit-Position: refs/heads/master@{#459056}
(cherry picked from commit a5af97fb2663da70cfc0693b1ca19ef97d8fbf07)
Review-Url: https://codereview.chromium.org/2770933004 .
Cr-Commit-Position: refs/branch-heads/3029@{#386}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add new entry in VideoPersistenceEndReason.
BUG=703742
[email protected]
Review-Url: https://codereview.chromium.org/2769723002
Cr-Commit-Position: refs/heads/master@{#458898}
(cherry picked from commit fa9ba6d9ad044d07901d53ac5ccaeea4bae10b45)
Review-Url: https://codereview.chromium.org/2774433003 .
Cr-Commit-Position: refs/branch-heads/3029@{#385}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add more metrics for VideoPersistence.
BUG=703742
[email protected]
Review-Url: https://codereview.chromium.org/2769443002
Cr-Commit-Position: refs/heads/master@{#458594}
(cherry picked from commit a5e47761320d73c02ae0473936e059769c42df15)
Review-Url: https://codereview.chromium.org/2771043002 .
Cr-Commit-Position: refs/branch-heads/3029@{#384}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem.
This method will be called when pressing Enter key on an ARC
notification.
BUG=703556
Review-Url: https://codereview.chromium.org/2761283002
Cr-Commit-Position: refs/heads/master@{#458670}
(cherry picked from commit a9b559687be78936e36e571768dee3cc377131a6)
Review-Url: https://codereview.chromium.org/2769183002 .
Cr-Commit-Position: refs/branch-heads/3029@{#383}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge-58] Save billing address changes for server cards on android.
BUG=703280
Review-Url: https://codereview.chromium.org/2760903003
Cr-Commit-Position: refs/heads/master@{#458462}
(cherry picked from commit 1990dda534f52804f74fe74c749301ca1f937dd3)
Review-Url: https://codereview.chromium.org/2763383003 .
Cr-Commit-Position: refs/branch-heads/3029@{#382}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[wrapper-tracing] Emite write barrier upon associating a wrapper
Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.
A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.
BUG=chromium:702490
Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)
Review-Url: https://codereview.chromium.org/2769773003 .
Cr-Commit-Position: refs/branch-heads/3029@{#381}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Remove all ReadingList entries on managed account signout.
Clearing happens after the actual signout, so only local data is deleted.
Also interrupt current distillation on signout as profile may change.
BUG=699590
Review-Url: https://codereview.chromium.org/2745313004
Cr-Commit-Position: refs/heads/master@{#458377}
(cherry picked from commit 85c6bf63ddea1f0a18f2404090acb96f67369ca2)
Review-Url: https://codereview.chromium.org/2770723004 .
Cr-Commit-Position: refs/branch-heads/3029@{#380}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Reading List iOS] Test WebState on JavaScript return.
ContinuePageDistillation can be called on return from JavaScript call.
WebState can be deleted (specially if there was an error).
So test before dereferencing it.
BUG=703102
Review-Url: https://codereview.chromium.org/2761733003
Cr-Commit-Position: refs/heads/master@{#458061}
(cherry picked from commit aca5aa3e2873c888092bf83668286b515e891bfb)
Review-Url: https://codereview.chromium.org/2767193003 .
Cr-Commit-Position: refs/branch-heads/3029@{#379}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Don't GONE the unsuspended video only players
Video only players are reported to RendererWebMediaPlayerDelegate as GONE
even if they're playing. This CL would make sure we only report suspended
players as GONE. This affects the logic in MediaWebContentsDelegate that
creates the power blocker for videos.
BUG=703105
TEST=manual
Review-Url: https://codereview.chromium.org/2767253002
Cr-Commit-Position: refs/heads/master@{#458995}
(cherry picked from commit 5f34b644166c2dc02f7f937f69ce0fd08e89e626)
Review-Url: https://codereview.chromium.org/2763373003 .
Cr-Commit-Position: refs/branch-heads/3029@{#378}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Merge M58] arc: Fix regression in handling ARC shelf item.
This fix regressions caused by recent refactoring. First regression is
in case multiple shelf items for the same ARC app, clicking on shelf
item always activates last opened window. It is expected that in this
case last active window of that app becomes active. Second one,
selecting which item to activate from menu does not actually activate
selected item
BUG=703895
TEST=Manually, unit_tests extended.
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2763893004
Cr-Commit-Position: refs/heads/master@{#458638}
(cherry picked from commit a19209825989de7d6b620aea95dd0f95b5c3c03f)
Review-Url: https://codereview.chromium.org/2773493002
Cr-Commit-Position: refs/branch-heads/3029@{#377}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.35
Cr-Commit-Position: refs/branch-heads/3029@{#376}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix position of layer with floating ancestor within inline parent layer
<span style="position: relative">
...
<div style="float: left">
...
<target layer>
...
</div>
...
</span>
Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.
BUG=703666,703481
NOTRY=true
NOPRESUBMIT=true
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2761413002
Cr-Original-Commit-Position: refs/heads/master@{#458857}
Review-Url: https://codereview.chromium.org/2770713004
Cr-Commit-Position: refs/branch-heads/3029@{#375}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Ignore custom offscreen surface attributes unless explicitly opted in
The "own offscreen surface" support intended for use by WebGL contexts
as used by WebVR was unexpectedly getting activated for NaCl plugins,
causing issues because the Ozone surface factory doesn't implement
custom formats. WebGL contexts normally didn't set the attributes since
they do all drawing in a separate FBO.
To avoid this, add a new own_offscreen_surface attribute to make the
new behavior explicitly opt-in.
BUG=699664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2761153002
Cr-Commit-Position: refs/heads/master@{#458542}
(cherry picked from commit f8a6edb9c516c335cac49f3aa1b941a6f9ca52bb)
Review-Url: https://codereview.chromium.org/2767303002 .
Cr-Commit-Position: refs/branch-heads/3029@{#374}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix Views overlay scrollbar border stroke.
Using a square end cap instead of "butt" makes the stroke extend by a
half stroke width (0.5dp or 1px @2x) at the ends.
BUG=702744
Review-Url: https://codereview.chromium.org/2766773002
Cr-Commit-Position: refs/heads/master@{#458493}
(cherry picked from commit c6359868104299cc1eb5fe2700a792d52ecaac6c)
Review-Url: https://codereview.chromium.org/2767283002 .
Cr-Commit-Position: refs/branch-heads/3029@{#373}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Incrementing VERSION to 58.0.3029.34
Cr-Commit-Position: refs/branch-heads/3029@{#372}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add CriticalClosure to BLOCK_SHUTDOWN Tasks
iOS relies on CriticalClosure to notify the system that Chrome is doing
important work when Chrome is backgrounded.
BUG=701910
Review-Url: https://codereview.chromium.org/2761653004
Cr-Commit-Position: refs/heads/master@{#458529}
(cherry picked from commit 6442d6e4c7b405310f22a1e8c191faf6e1763425)
Review-Url: https://codereview.chromium.org/2770873003 .
Cr-Commit-Position: refs/branch-heads/3029@{#371}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add a timeout when waiting from install notification from google play.
When installing WebAPKs from Google Play, sometimes the install complete
broadcast is delayed. As a result, the text on the install infobar won't
change to "Open" after the WebAPK is installed until very late.
In this CL, we update GooglePlayInstallDelegate by adding a new method
updateAsync(), so both install and update cases can have their own timer.
The internal CL is:
https://chrome-internal-review.googlesource.com/c/335445
BUG=692249
Review-Url: https://codereview.chromium.org/2738863004
Cr-Commit-Position: refs/heads/master@{#458056}
(cherry picked from commit e0454c1a4c0df693e36938fd644315909a40f09b)
Review-Url: https://codereview.chromium.org/2767203003 .
Cr-Commit-Position: refs/branch-heads/3029@{#370}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3
This CL:
- Changes GooglePlayWebApkInstallDelegate#installAsync() to return a
WebApkInstallResult in the callback.
- Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk().
BUG=696132
Review-Url: https://codereview.chromium.org/2728053002
Cr-Commit-Position: refs/heads/master@{#457300}
(cherry picked from commit 19d929ae378491116d7683764baa6365d1ddd50d)
Review-Url: https://codereview.chromium.org/2773503002 .
Cr-Commit-Position: refs/branch-heads/3029@{#369}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Merge 58 [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 1/3
Chrome considers a install as "failed" if Google Play does not finish
the
install within 3 minutes. It is possible for the install to take more
time
if Google Play is busy with another install. When an install fails we
add a
webapp shortcut to the homescreen.
This CL changes the logic so that a webapp shortcut is not added to the
homescreen if the WebAPK install times out. It would be confusing for
the
user to end up with two shortcuts with the same icon on their
homescreen:
- one for a WebAPK
- one for a webapp
BUG=692249
Review-Url: https://codereview.chromium.org/2770813002 .
Cr-Commit-Position: refs/branch-heads/3029@{#368}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix Crash on M58 during VSync provider switch.
BUG=704063
[email protected]
Review-Url: https://codereview.chromium.org/2766293002 .
Cr-Commit-Position: refs/branch-heads/3029@{#367}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Remove logic about recording style related main thread scroll reasons
The current recording incorrectly propagates the style related main thread scrolling reasons
of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any
scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in
smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking
release of M57 stable, it's better to remove the recording logic for now and work
on a correct one in a following patch.
BUG=701355
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2766893002
Cr-Commit-Position: refs/heads/master@{#458596}
(cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46)
Review-Url: https://codereview.chromium.org/2769763002
Cr-Commit-Position: refs/branch-heads/3029@{#366}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Disables EnableAccelerationToAvoidReadbacks due to regression
BUG=702492
Review-Url: https://codereview.chromium.org/2767753002
Cr-Commit-Position: refs/heads/master@{#458623}
(cherry picked from commit ea6a16123f90b39e8de13c65cf04935107d252ae)
Review-Url: https://codereview.chromium.org/2772453002 .
Cr-Commit-Position: refs/branch-heads/3029@{#365}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Updating XTBs based on .GRDs from branch 3029
Cr-Commit-Position: refs/branch-heads/3029@{#364}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Add a DevTools warning for a missing subjectAltName
BUG=703616
Review-Url: https://codereview.chromium.org/2761333002
Cr-Commit-Position: refs/heads/master@{#458631}
(cherry picked from commit 74a7a294c2802cf5b65bf0c0d4f44ba093aae216)
Review-Url: https://codereview.chromium.org/2770713002 .
Cr-Commit-Position: refs/branch-heads/3029@{#363}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
predictors: Fix incorrect page load metrics histogram name.
s/ParseTiming/PaintTiming
histograms.xml contains correct (PaintTiming) name.
BUG=680049
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2761223003
Cr-Commit-Position: refs/heads/master@{#458426}
(cherry picked from commit 1e19c9d4d1268cf7f9048ac14825fe0ac4785740)
Review-Url: https://codereview.chromium.org/2764393003
Cr-Commit-Position: refs/branch-heads/3029@{#362}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Make the menu button accessible to all frameworks.
If we are using onTouch to simulate click events, then we
should also override performAccessibilityAction to handle
ACTION_CLICKED, which makes it compliant with accessibility
frameworks other than TalkBack.
This change also remove the document mode menu as it also
did menu things and was confusing why it wasn't being included.
BUG=700185
Review-Url: https://codereview.chromium.org/2762923003
Cr-Commit-Position: refs/heads/master@{#458573}
(cherry picked from commit 82e6adfa4eb4bc6517c91e1f3749eb4b7c3a2fdf)
Review-Url: https://codereview.chromium.org/2771503002 .
Cr-Commit-Position: refs/branch-heads/3029@{#361}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix accessibility for tabstrip for all accessibility frameworks.
Android specific change to ensure the tab strip supports clicking
on the items regardless of the accessibilty framework enabled.
This requires adding support for the accessibility ACTION_CLICK
events.
BUG=700317
Review-Url: https://codereview.chromium.org/2761223005
Cr-Commit-Position: refs/heads/master@{#458771}
(cherry picked from commit 2ff5d34ac279f8077dbcabe4afe21bbb964a4894)
Review-Url: https://codereview.chromium.org/2768853002 .
Cr-Commit-Position: refs/branch-heads/3029@{#360}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fixing Display Mirror Mode issue
As a part of https://codereview.chromium.org/2626413002 I've
inadvertently removed an unrelated line of code that sets
display_output_surface field on per-compositor data.
See line 565 here:
https://codereview.chromium.org/2626413002/diff/120001/content/browser/compositor/gpu_process_transport_factory.cc
This change puts the removed line of code back.
Thanks to afakhry@ for verifying the fix!
BUG=702713
Review-Url: https://codereview.chromium.org/2764633003
Cr-Commit-Position: refs/heads/master@{#458587}
(cherry picked from commit 165005de11ad4207b3003a42a3ce41f4ab797e67)
Review-Url: https://codereview.chromium.org/2764153003 .
Cr-Commit-Position: refs/branch-heads/3029@{#359}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Record the type of controls used for video persistence.
BUG=703267
[email protected]
Review-Url: https://codereview.chromium.org/2763723002
Cr-Commit-Position: refs/heads/master@{#458387}
(cherry picked from commit 9bab651a8a170a6016af11dc0ee4f6407456fcb9)
Review-Url: https://codereview.chromium.org/2770513003 .
Cr-Commit-Position: refs/branch-heads/3029@{#358}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Deprecate histogram "Media.Video.Autoplay.Muted.Attribute.OffscreenDuration"
As autoplaying muted videos by attribute will be paused when invisible,
the histogram will be no longer meaningful. This CL deprecates this
metric.
BUG=693497
Review-Url: https://codereview.chromium.org/2728423003
Cr-Commit-Position: refs/heads/master@{#455424}
(cherry picked from commit 55381c71a2733c387e34554b7fbacce912751906)
Review-Url: https://codereview.chromium.org/2766903005 .
Cr-Commit-Position: refs/branch-heads/3029@{#357}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[InputEvent] Add null check before converting Range to StaticRange
It's possible for |firstRangeOf()| to return null (see test case), and we shouldn't try to
construct StaticRange in this case.
BUG=697319
Review-Url: https://codereview.chromium.org/2727293003
Cr-Commit-Position: refs/heads/master@{#454614}
(cherry picked from commit b05824d69f2a8403552ef9e29bebdece24005400)
Review-Url: https://codereview.chromium.org/2763833006 .
Cr-Commit-Position: refs/branch-heads/3029@{#356}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[NTP Client] Fix incognito tab launch type from NTP
Mark the suggestions and tiles opened in incognito as being
opened in foreground. They were previously marked as opened
in the backgound, which comes with the wrong animation and
an irrelevant toast on svelte.
BUG=703753
Review-Url: https://codereview.chromium.org/2763303002
Cr-Commit-Position: refs/heads/master@{#458745}
(cherry picked from commit 639bf90880e0b6512c08b798dc478cf96d3d48af)
Review-Url: https://codereview.chromium.org/2764333002 .
Cr-Commit-Position: refs/branch-heads/3029@{#355}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
[NTP Tiles] Stop leaving null in pending tile data
BUG=703578
Review-Url: https://codereview.chromium.org/2767573002
Cr-Commit-Position: refs/heads/master@{#458399}
(cherry picked from commit 5a9eab70933bfe7105a3b6fbe713513ac946e47a)
Conflicts:
chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
Resolved by not merging the new test.
Review-Url: https://codereview.chromium.org/2762943004 .
Cr-Commit-Position: refs/branch-heads/3029@{#354}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
NTP: handle scroll position changes that are due to layout.
When the device is rotated the RecyclerView may change its scroll
position during layout without broadcasting a scroll event. Naughty.
BUG=701269
Review-Url: https://codereview.chromium.org/2758833002
Cr-Commit-Position: refs/heads/master@{#457821}
(cherry picked from commit e42e82d24eb1e150007055d0ba8ec641367114a9)
Review-Url: https://codereview.chromium.org/2762213003 .
Cr-Commit-Position: refs/branch-heads/3029@{#353}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Fix Find in Page on iOS 10.3.
In iOS 10.3, an error is generated when trying to find in page on a page
with iframe:
SecurityError (DOM Exception 18): Blocked a frame with origin "https://w
ww.reddit.com" from accessing a frame with origin "https://www.redditmed
ia.com". Protocols, domains, and ports must match.
As a result, the search results are not highlighted on the page.
The fix is wrapping the offending line in try/catch.
BUG=702566
TEST=On iOS 10.3 device, open cnn.com, select tools>Find in Page" and
type any string that is present on the page. The string should be found
and highglighted, and the number of results should be correct, and
next/previous buttons should scroll the page to the next/prev result.
Review-Url: https://codereview.chromium.org/2755123002
Cr-Commit-Position: refs/heads/master@{#457845}
(cherry picked from commit 2991f43a94bbdb2eb798a8f256b67b5b3865f129)
Review-Url: https://codereview.chromium.org/2766183002 .
Cr-Commit-Position: refs/branch-heads/3029@{#352}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Prerender: omnibox and instant field trial parameters.
Allow omnibox and instant prerendering origins to be controlled separately from
the rest of the NoStatePrefetch experiment.
BUG=565501,678332
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2754003006
Cr-Commit-Position: refs/heads/master@{#458124}
(cherry picked from commit 6430db2fde6019843ea53e3540757857934b804a)
Review-Url: https://codereview.chromium.org/2769633002
Cr-Commit-Position: refs/branch-heads/3029@{#351}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
