Publish DEPS for Chromium 57.0.2987.126
Incrementing VERSION to 57.0.2987.126
Cr-Commit-Position: refs/branch-heads/2987@{#877}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
M57: Initialize COM STA in the service process.
BUG=704754
Review-Url: https://codereview.chromium.org/2765333004 .
Cr-Commit-Position: refs/branch-heads/2987@{#876}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Include control clip in list of clip-related properties.
BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2770943003
Cr-Commit-Position: refs/heads/master@{#459407}
(cherry picked from commit e038518f79d429d7ccebaa16aae92773bf238459)
Review-Url: https://codereview.chromium.org/2773163002 .
Cr-Commit-Position: refs/branch-heads/2987@{#875}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Fix Find in Page on iOS 10.3.
In iOS 10.3, an error is generated when trying to find in page on a page
with iframe:
SecurityError (DOM Exception 18): Blocked a frame with origin "https://w
ww.reddit.com" from accessing a frame with origin "https://www.redditmed
ia.com". Protocols, domains, and ports must match.
As a result, the search results are not highlighted on the page.
The fix is wrapping the offending line in try/catch.
BUG=702566
TEST=On iOS 10.3 device, open cnn.com, select tools>Find in Page" and
type any string that is present on the page. The string should be found
and highglighted, and the number of results should be correct, and
next/previous buttons should scroll the page to the next/prev result.
Review-Url: https://codereview.chromium.org/2755123002
Cr-Commit-Position: refs/heads/master@{#457845}
(cherry picked from commit 2991f43a94bbdb2eb798a8f256b67b5b3865f129)
Review-Url: https://codereview.chromium.org/2773993002 .
Cr-Commit-Position: refs/branch-heads/2987@{#874}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Revert "Let SVGForeignObject's local SVG coordinates mean what it should"
This is a manual revert of https://crrev.com/f451d9b5de5a1b4691d60d8c74341ac8a466cf57
(commit number #435337) due to revert conflicts.
BUG=704643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2773963003 .
Cr-Commit-Position: refs/branch-heads/2987@{#873}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Adjust common prefix/suffix correctly for InsertIncrementalTextCommand
In InsertIncrementalTextCommand, when adjusting common prefix/suffix for
grapheme clusters, the old implementation used mismatched offset and node
for the selection. This CL makes them matched. Besides, this CL replaces
wrong DCHECK with truncation when computing common suffix.
NOTE: null check and early return was added for M57 respin.
BUG=702082
TEST=run_webkit_unit_tests --gtest_filter=
InputMethodControllerTest.SetCompositionWithGraphemeCluster*
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2763873003
Cr-Commit-Position: refs/heads/master@{#458669}
(cherry picked from commit 195221de391ce3bf00fb70a7e64995648e535feb)
Review-Url: https://codereview.chromium.org/2770183002 .
Cr-Commit-Position: refs/branch-heads/2987@{#872}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.125
Cr-Commit-Position: refs/branch-heads/2987@{#871}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
[Merge m57] cc:: Null check OuterViewportScrollLayer too
There are crash reports that OuterViewportScrollLayer is null when the
Inner one is not. The assumption is that blink can send an invalid tree
to cc. So remove the DCHECK, and replace it with a runtime check and
early out instead.
BUG=703416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2769453003
Cr-Commit-Position: refs/heads/master@{#458878}
(cherry picked from commit 97a462d45974e7a4eb0e033730abd8a78aa55e64)
Review-Url: https://codereview.chromium.org/2775663002 .
Cr-Commit-Position: refs/branch-heads/2987@{#870}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.124
Cr-Commit-Position: refs/branch-heads/2987@{#869}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Don't GONE the unsuspended video only players
Video only players are reported to RendererWebMediaPlayerDelegate as GONE
even if they're playing. This CL would make sure we only report suspended
players as GONE. This affects the logic in MediaWebContentsDelegate that
creates the power blocker for videos.
BUG=703105
TEST=manual
Review-Url: https://codereview.chromium.org/2767253002
Cr-Commit-Position: refs/heads/master@{#458995}
(cherry picked from commit 5f34b644166c2dc02f7f937f69ce0fd08e89e626)
Review-Url: https://codereview.chromium.org/2773573003 .
Cr-Commit-Position: refs/branch-heads/2987@{#868}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.123
Cr-Commit-Position: refs/branch-heads/2987@{#867}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.122
Cr-Commit-Position: refs/branch-heads/2987@{#866}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Fix position of layer with floating ancestor within inline parent layer
<span style="position: relative">
...
<div style="float: left">
...
<target layer>
...
</div>
...
</span>
Because of the floating ancestor, the containing layer of target layer
is not the span, but the layer found in the containing block chain.
BUG=703666,703481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOPRESUBMIT=true
NOTRY=true
R=chrishtr
Review-Url: https://codereview.chromium.org/2761413002
Cr-Original-Commit-Position: refs/heads/master@{#458857}
Review-Url: https://codereview.chromium.org/2767133003
Cr-Commit-Position: refs/branch-heads/2987@{#865}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Remove logic about recording style related main thread scroll reasons
The current recording incorrectly propagates the style related main thread scrolling reasons
of a scrollable overflow element to the main frame. It would make the main frame scroll on main if there were any
scrollers which needed to scroll on main which it shouldn't. It also caused 34.5% regression in
smoothness.key_mobile_sites_smooth benchmark (crbug.com/693527) .As the issue is blocking
release of M57 stable, it's better to remove the recording logic for now and work
on a correct one in a following patch.
BUG=701355
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2766893002
Cr-Commit-Position: refs/heads/master@{#458596}
(cherry picked from commit d528436cf0ab46778ccd56a439a250e41113fc46)
Review-Url: https://codereview.chromium.org/2766353002
Cr-Commit-Position: refs/branch-heads/2987@{#864}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Merge Keychain reauthorization to the 57.0.2987 branch
0e96702c0333 Reauthorize Keychain to Replace Developer ID Certificate
335d196213dc Backup and restore the Safe Storage keychain entry
451fd613c2dd Activate keychain reauthorization.
a84483607b1b Do Keychain reauthorization at update time
0464f001b95f Fix dmgdiffer to properly copy keychain_reauthorize stubs
to diff dmgs
06d18288a66e Copy keychain_reauthorization binaries
BUG=629906
[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2766323003 .
Cr-Commit-Position: refs/branch-heads/2987@{#863}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Search the entire subtree when looking for the end of an inline continuation chain.
Inlines may be nested, so we may not find the last inline in the chain as a
direct child of the anonymous blocks. We need to search the entire subtree.
Don't do this with anonymous blocks that wrap block children (the block-level
DOM children of the inline-level objects), though. We're not going to find
anything interesting there.
This fix is speculative; the original bug report didn't come with a test case.
BUG=662767
Review-Url: https://codereview.chromium.org/2738503004
Cr-Commit-Position: refs/heads/master@{#455420}
(cherry picked from commit e72c8c06b956706b54648589f807086d17340831)
Review-Url: https://codereview.chromium.org/2769703003 .
Cr-Commit-Position: refs/branch-heads/2987@{#862}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Disables EnableAccelerationToAvoidReadbacks due to regression
BUG=702492
Review-Url: https://codereview.chromium.org/2767753002
Cr-Commit-Position: refs/heads/master@{#458623}
(cherry picked from commit ea6a16123f90b39e8de13c65cf04935107d252ae)
Review-Url: https://codereview.chromium.org/2767993002 .
Cr-Commit-Position: refs/branch-heads/2987@{#861}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
[Mac] Fullscreen Toolbar Fixes
- Fixed the layout issues with the fullscreen toolbar
- Fixed the hiding animation
BUG=689115
Review-Url: https://codereview.chromium.org/2738043002
Cr-Commit-Position: refs/heads/master@{#456117}
(cherry picked from commit e86cff1a78d3b1f75b454487afee3101d3504519)
Review-Url: https://codereview.chromium.org/2768843002 .
Cr-Commit-Position: refs/branch-heads/2987@{#860}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Merge to M57: Correctly track cross-thread pending FetchEvents.
ServiceWorkerGlobalScopeProxy is an object that resides on the
main thread heap, but is passed to the embedder and called
on the (service) worker thread. As the object is GC managed
by the main thread, the worker thread cannot update the proxy
object with references to heap objects residing in its heap,
as the per-thread heap design assumes that each heap only keeps
local heap references (via Member<T> and similar.) References
across heaps must instead be kept and handled by explicit
CrossThreadPersistent<> references.
This per-thread heap rule was not being followed for the tracking
of pending FetchEvents; adjust the map representation to do so.
R=haraken
BUG=702527
Review-Url: https://codereview.chromium.org/2752203005
Cr-Commit-Position: refs/heads/master@{#457970}
(cherry picked from commit d0ff3d34a5798ddc3db10815d49dc1687e4f866e)
Review-Url: https://codereview.chromium.org/2769583002 .
Cr-Commit-Position: refs/branch-heads/2987@{#859}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.121
Cr-Commit-Position: refs/branch-heads/2987@{#858}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Merge 57: Move destruction of VEAEncoder to encoding task runner
We were seeing random crashes in WebRtcMediaRecorderTest.*FiresErrorEvent tests
because:
- GpuVideoEncodeAcceleratorHost::Initialize() takes a naked ptr to |client|
which is VEAEncoder.
- GpuVideoEncodeAcceleratorHost::OnRequireBitstreamBuffers() calls
client->OnRequireBitstreamBuffers().
- While VEAEncoder::RequireBitstreamBuffers() is running on
|encoding_task_runner_|, ~VEAEncoder() gets called on main render thread
through ~VideoTrackRecorder() after the error event.
~ VEAEncoder() needs a mechanism similar to H264Encoder::ShutdownEncoder() to
make sure that shutdown tasks on |encoding_task_runner_| are completed before
moving on.
This CL solves the issues by making sure that dtor completes tasks on encoding
task runner via DestroyOnEncodingTaskRunner().
BUG=701030
TEST=WebRtcMediaRecorderTest.*FiresErrorEvent tests consistently pass on
local Mac builds.
Review-Url: https://codereview.chromium.org/2750993002
Cr-Commit-Position: refs/heads/master@{#457101}
(cherry picked from commit caa1c995a9a8dc99a4d6999d78f796aa4dbdae0f)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2766753003
Cr-Commit-Position: refs/branch-heads/2987@{#857}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Merge "cros: AutomaticRebootManager reboots for ARC kiosk"
> Make AutomaticRebootManager allow rebooting for ARC kiosk sessions as
> well. And update unit tests to add some coverage.
>
> BUG=702725
>
> Review-Url: https://codereview.chromium.org/2761673006
> Cr-Commit-Position: refs/heads/master@{#458219}
> (cherry picked from commit 183db682fc5fb82cc837474c245cb6acab56f0fe)
Review-Url: https://codereview.chromium.org/2767783002 .
Cr-Commit-Position: refs/branch-heads/2987@{#856}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
[Merge to M57] cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe
Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in keyboard_utils.js.
Adding NOPRESUBMIT=true because otherwise it will report document.getElementById('oauth-enroll-auth-view')) javascript style violation error.
[email protected], [email protected]
BUG=702674
NOPRESUBMIT=true
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2751523010
Cr-Commit-Position: refs/heads/master@{#457929}
(cherry picked from commit 652e402f4703bf20297438b059d75c6884ba0d1f)
Review-Url: https://codereview.chromium.org/2760213002 .
Cr-Commit-Position: refs/branch-heads/2987@{#855}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.120
Cr-Commit-Position: refs/branch-heads/2987@{#854}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Merge to M57: BrowserAccessibilityManagerMac shouldn't have a raw ptr to its parent NSView
There are rare circumstances when the parent NSView can be freed before
the BrowserAccessibilityManagerMac is; see bug.
BUG=700584
Review-Url: https://codereview.chromium.org/2746693002
Cr-Commit-Position: refs/heads/master@{#456290}
(cherry picked from commit 94c44abd2c1a34bf882365953743311fa9a0ff19)
Review-Url: https://codereview.chromium.org/2759263004 .
Cr-Commit-Position: refs/branch-heads/2987@{#853}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.119
Cr-Commit-Position: refs/branch-heads/2987@{#852}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.118
Cr-Commit-Position: refs/branch-heads/2987@{#851}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Revert "Temporarily add CHECKs to VisualViewport::didSetScaleAndLocation"
This reverts commit 12b6df011abab4773df645d7a39cdab42f1336b2.
We shouldn't be landing CHECKs to the stable release branch, other
platforms ship from it...
BUG=665083
Cr-Commit-Position: refs/branch-heads/2987@{#850}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.117
Cr-Commit-Position: refs/branch-heads/2987@{#849}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.116
Cr-Commit-Position: refs/branch-heads/2987@{#848}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.115
Cr-Commit-Position: refs/branch-heads/2987@{#847}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Temporarily add CHECKs to VisualViewport::didSetScaleAndLocation
Adding CHECKS to help track down why we're getting infinite recursion in this
function. It looks like that may happen if the scale of offset ever become NaN.
BUG=665083,702771
Review-Url: https://codereview.chromium.org/2754323003
Cr-Commit-Position: refs/heads/master@{#457920}
(cherry picked from commit 3685db28900ee3e99c5e2e6ce8bfecb78805f1de)
Review-Url: https://codereview.chromium.org/2758773004 .
Cr-Commit-Position: refs/branch-heads/2987@{#846}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.114
Cr-Commit-Position: refs/branch-heads/2987@{#845}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Image Capture: skip more PAN/TILT controls, including non-standard
Seems like I missed a bunch of PAN/TILT related controls.
This CL skips all PAN/TILT controls, including non-standard
ones that are defined on the spot.
BUG=697885
Review-Url: https://codereview.chromium.org/2744333002
Cr-Commit-Position: refs/heads/master@{#456537}
V4L2: avoid resetting PAN and TILT controls
Avoid reset PAN/TILT controls due to Image Capture API not giving access
to them (yet) and only access coming from /extensions/browser/api/webcam_private.
BUG=697885
Review-Url: https://codereview.chromium.org/2732063006
Cr-Original-Commit-Position: refs/heads/master@{#455532}
Review-Url: https://codereview.chromium.org/2759793002 .
Cr-Commit-Position: refs/branch-heads/2987@{#844}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Fix CHECK that's being fired inside NavigationControllerImpl::RendererDidNavigateToExistingPage.
The check was supposed to alert us if this condition is being hit, and apparently it is. Add logic to not copy the cert for in-page navigations. I didn't add logic to handle the restore case since intended_as_new_entry shouldn't be set in that scenario.
BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2752113007
Cr-Commit-Position: refs/heads/master@{#457818}
(cherry picked from commit 1325c82018ee533b2d88ac923bfb516b4f552555)
Review-Url: https://codereview.chromium.org/2761553002 .
Cr-Commit-Position: refs/branch-heads/2987@{#843}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Fix crash during sync load of the signin profile
This fixes hitting a CHECK during restore-after-crash of the
signin profile in case of enrolled device:
[FATAL:device_cloud_policy_manager_chromeos.cc(252)] Check
failed: signin_profile_forwarding_schema_registry_.
The crash was caused by an attempt to start connection for
the device cloud policy manager _before_ the schema
registry of the sign-in profile is passed to it.
This has regressed recently due to the change in commit
afc9d60e96d31a11f756d5c56c2be54a28130960, which, in
particular, made the DeviceSettingsService load much
earlier than previously in case when restore-after-crash
happens. The DeviceSettingsService loading triggers
DeviceCloudPolicyManagerChromeOS::StartConnection(),
which hits a CHECK because this all happens before the
schema registry gets a chance to be passed by
ProfilePolicyConnectorFactory::CreateForBrowserContextInternal().
The fix is to pass the schema registry from a different
location - directly from
SchemaRegistryServiceFactory::CreateForContextInternal() that
constructs the schema registry. This is guaranteed by the
current code to be run before the DeviceSettingsService load
happens.
BUG=698136
TEST=manual: induce a crash on signin screen on an enrolled
device and verify that automatic restart works
Review-Url: https://codereview.chromium.org/2729093002
Cr-Commit-Position: refs/heads/master@{#454627}
(cherry picked from commit 9bae7d67f2a11bc706b9becb3aefa2d2e0286ff0)
Review-Url: https://codereview.chromium.org/2739453004 .
Cr-Commit-Position: refs/branch-heads/3029@{#42}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
(cherry picked from commit 1ef634f4f3ddb8614932d541c203f5584288abc4)
Review-Url: https://codereview.chromium.org/2759773002 .
Cr-Commit-Position: refs/branch-heads/2987@{#842}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Load DeviceLocalAccount policy and DeviceSettings immediately on restore after Chrome crash.
UserCloudPolicyManagerChromeOS and UserCloudPolicyManager are loading user policy immediately
after Chrome crash as profile is created synchronously so that the Profile initialization
never sees unmanaged prefs.
However, it was not true for device local accounts, such as public sessions and ARC Kiosk session,
that means having Profile with uninitialized prefs, that particularly leads to crash/data loss
for ARC kiosk.
This change forces policies for these accounts to also be loaded immediately on crash with blocking
call to D-Bus, similar to loading policies for users.
note: While this change fixes the described issue, the better way is to get rid of synchronous profile
creation, but still ensure that policy is loaded before end of profile creation. See crbug.com/160522
BUG=679810
BUG=694546
TEST=Ran tryjobs, start and restore after crash for: ARC Kiosk, Public Session, User Session.
Review-Url: https://codereview.chromium.org/2714493002
Cr-Commit-Position: refs/heads/master@{#453621}
(cherry picked from commit afc9d60e96d31a11f756d5c56c2be54a28130960)
Review-Url: https://codereview.chromium.org/2757943002 .
Cr-Commit-Position: refs/branch-heads/2987@{#841}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Invalidate SVG 'transform' pres. attribute style even if not attached
When the 'transform' attribute was manipulated via its SVG DOM
representation (SVGTransformList), the
presentation-attribute-style-is-dirty flag would not be set unless the
element had been attached.
Reorder the contents of the 'transform' branch in
SVGGraphicsElement::svgAttributeChanged so that the presentation
attribute style is always dirtied regardless of attachment status.
BUG=701075
Review-Url: https://codereview.chromium.org/2745053005
Cr-Commit-Position: refs/heads/master@{#456696}
(cherry picked from commit 8554eac989977ff9d7f82444c01a500430097919)
Review-Url: https://codereview.chromium.org/2755813004 .
Cr-Commit-Position: refs/branch-heads/2987@{#840}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Null check for IME descriptor in GetKeyboardLayoutsForResovledLocale
This is workaround for layouts returned by GetHardwareInputMethodIds
not having a valid IME descriptor.
BUG=700625
Review-Url: https://codereview.chromium.org/2756523003
Cr-Commit-Position: refs/heads/master@{#457228}
(cherry picked from commit a6ba05eb3482758392c1e440f853f4e612140122)
Review-Url: https://codereview.chromium.org/2746363011 .
Cr-Commit-Position: refs/branch-heads/2987@{#839}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.113
Cr-Commit-Position: refs/branch-heads/2987@{#838}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
arc: Update device owner check implementation
Update the device owner check to compare the account id of the active
user with the account id of the owner as provided by the user manager
API. The old implementation uses the logged in user state API which for
unbeknownst reasons returns the owner as a regular user. It can also
change asynchronously at boot resulting in racy behavior as its used
right now.
BUG=702311
BUG=b:34661187
BUG=b:33488433
TEST=run cts -c android.net.wifi.cts.WifiEnterpriseConfigTest -m
testAddEapNetwork
TEST=run cts -c android.net.wifi.cts.WifiManagerTest -m
testWifiManagerNetWork
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2756443003
Cr-Commit-Position: refs/heads/master@{#457563}
(cherry picked from commit eb260ae77f464ec4b53627278b9e842cafb3490e)
Review-Url: https://codereview.chromium.org/2756673003
Cr-Commit-Position: refs/branch-heads/2987@{#837}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.112
Cr-Commit-Position: refs/branch-heads/2987@{#836}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
bluetooth: Stop support of reconnecting devices not supporting pairing
This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3
BUG=701992
[email protected]
Review-Url: https://codereview.chromium.org/2751223002
Cr-Commit-Position: refs/heads/master@{#457325}
(cherry picked from commit 206866029e5e2fddc1cff642fbfc5318007a6574)
Review-Url: https://codereview.chromium.org/2751303002 .
Cr-Commit-Position: refs/branch-heads/2987@{#835}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Workaround for invalid keyboard_layout value in vpd for kefka
Kefka VPD has keyboard_layout set to ANSI, which is not a valid value.
This adds a workaround for this issue - if the read keyboard layout
is ANSI, replace it with valid xkb:us::eng.
BUG=700625
Review-Url: https://codereview.chromium.org/2747173007
Cr-Commit-Position: refs/heads/master@{#457312}
(cherry picked from commit ad715211f7d2069224eeb8e0ef5aa70c5495236f)
Review-Url: https://codereview.chromium.org/2741343014 .
Cr-Commit-Position: refs/branch-heads/2987@{#834}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.111
Cr-Commit-Position: refs/branch-heads/2987@{#833}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.110
Cr-Commit-Position: refs/branch-heads/2987@{#832}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Fix theme change paint issue on linux.
Merging to M57
We had added a recursion guard in the Widget::OnNativeThemeUpdated() function in this patch
https://codereview.chromium.org/2703933002. This was to work around a crash we were seeing
on Windows where views would be added/removed while the rootview was propagating the theme
changed notification to child views effectively making the iterators invalid.
The recursion killer check in Widget::FrameTypeChanged() causes a painting bug on Linux.
The callstack thanks to thomasanderson is here.
The BrowserView::UserChangedTheme() function also has a recursion killer which is not set to
true here, which indicates that this stack is legitimate.
Fixes as below:
1. BrowserFrame now overrides the Widget::OnNativeThemeUpdated() function. After calling the base class
we call the newly added function NativeThemeUpdated() in the BrowserView which ensures that we don't
nuke the views while the iteration is going on in View::PropagateNativeThemeChanged()
2. In the HWNDMessageHandler::SetFullscreen method we update the fullscreen window map after we call PerformDwmTransition(). This internally at times causes a window pos changed to treat the now non fullscreen window as fullscreen leading to a DCHECK. Fixed by moving this code above.
I verified that this does not regress the previous theme fix http://crbug.com/681525 on Windows.
BUG=700135
TBR=sky
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2743793003
Cr-Commit-Position: refs/heads/master@{#456580}
(cherry picked from commit 3d0d1cdfad3fd70d8d579dd03004b4e09d01f2f1)
Review-Url: https://codereview.chromium.org/2753933003
Cr-Commit-Position: refs/branch-heads/2987@{#831}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Incrementing VERSION to 57.0.2987.109
Cr-Commit-Position: refs/branch-heads/2987@{#830}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
DevTools: Don't trigger panel switcher shortcut if alt key is held
On Windows with some international keyboard layouts, typing [ might
report that both ctrl and alt are pressed.
BUG=685993
Review-Url: https://codereview.chromium.org/2680773003
Cr-Commit-Position: refs/heads/master@{#448824}
(cherry picked from commit 85d052a58e40fa393e1daa4e3b1848c2b0530607)
Review-Url: https://codereview.chromium.org/2751833009 .
Cr-Commit-Position: refs/branch-heads/2987@{#829}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
[Merge m57] RenderTextMac: Fix crash when passed an invalid font.
RenderTextMac currently crashes when rendering text if it is passed a FontList
with a nil native font. This can generally happen if the Font used was created
from a font name.
This CL modifies RenderTextMac to ensure that if an invalid font list is passed,
the default font list (or a font list derived from it) is used instead. Also
added a unit test which fails on master and demonstrates the problem.
BUG=668058, 368192
Review-Url: https://codereview.chromium.org/2734333005
Cr-Commit-Position: refs/heads/master@{#455833}
(cherry picked from commit d8958dbde3315979308abe86880cba48879f010c)
Review-Url: https://codereview.chromium.org/2752073003 .
Cr-Commit-Position: refs/branch-heads/2987@{#828}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
