Publish DEPS for Chromium 56.0.2924.12
Incrementing VERSION to 56.0.2924.12
Cr-Commit-Position: refs/branch-heads/2924@{#230}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix the bug which is login dialog won't close after the second sign-in to chrome with different account on the same profile.
This is the follow up of CLs:
1) https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
and
2) https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca04710152de495ba50ea
The javascript message that close sign in dialog will be sent regardless before. However, after the refactor in the second CL above, it's only sent once the profile_path is not empty. It didn't cause any issue because the JS message will be sent again in the OnClientOAuthSuccess()
However, the OnClientOAuthSuccess' JS message will only be sent while force sign in is enabled after the first CL landed which is used to solve crbug.com/667227. It means that if the profile_path is empty (second sign in with different account in the same profile), the sign in dialog will never be closed.
Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that the javascript message will be sent no matter the profile_path is empty or not.
BUG=668619
Review-Url: https://codereview.chromium.org/2528183002
Cr-Commit-Position: refs/heads/master@{#434668}
(cherry picked from commit 0233a4c8e8eaa98fd46de68f975286b438751211)
Review URL: https://codereview.chromium.org/2543843002 .
Cr-Commit-Position: refs/branch-heads/2924@{#229}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
UnlockProfileAndHideLoginUI() will be called once the sign in is almost finished. This function will unlock the profile, hide the UserManager and send the message to javascript to close the "sign-in dialog".
UnlockProfileAndHideLoginUI() will be called in two places. The first one is for the second sign-in of one profile when the force-sign-in is disabled. The second one is after the OnClientOAuthSuccess when the force-sign-in is enabled.
Theoretically, this function can be called multiple times in one sign-in process. However, the fact is, once it's called by the second time, the javascript message will be sent to the "sync confirm dialog" but not the "sign-in dialog" which will close the "sync confirm dialog" automatically and causes other issue.s
The quick fix here is making sure that the function will be called at most once no matter the force-sign-in is enabled or not.
BUG=667227
Review-Url: https://codereview.chromium.org/2519123003
Cr-Commit-Position: refs/heads/master@{#434287}
(cherry picked from commit ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb)
Review URL: https://codereview.chromium.org/2542773002 .
Cr-Commit-Position: refs/branch-heads/2924@{#228}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Use loaded resources to determine if device is a tablet
On some devices, OEM modifications have been made to the resource
loader that cause the DeviceFormFactor calculation of whether a
device is using tablet resources to be incorrect. Check which
resources were actually loaded and set the DeviceFormFactor values.
BUG=662338
[email protected]
Review URL: https://codereview.chromium.org/2534313003 .
Review-Url: https://codereview.chromium.org/2538903002
Cr-Original-Commit-Position: refs/heads/master@{#435345}
Cr-Commit-Position: refs/branch-heads/2924@{#227}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Roll up of playback rate efficiency improvements for M56.
532a5dc Fix implicit channel layout configurations at non-1.0 playback rates.
fe0d379 Lazily allocate WSOLA structures; saves 56kB to 765kB of memory.
d99d0fa Add SSE and NEON intrinsics for WSOLA's MultiChannelDotProduct().
2c82957 Don't run WSOLA over always muted channels
BUG=666813
(cherry picked from commit a2cf799e795b7125776e6d58f1bb384c465c4c18)
Review URL: https://codereview.chromium.org/2541873005 .
Cr-Commit-Position: refs/branch-heads/2924@{#226}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix typo in enterVR failure case, causing incorrect VR exiting.
BUG=667444
Review-Url: https://codereview.chromium.org/2533913003
Cr-Commit-Position: refs/heads/master@{#434780}
(cherry picked from commit 8976c9ccfc0a6eadfdeca964beb69a64e516bfce)
Review URL: https://codereview.chromium.org/2539033003 .
Cr-Commit-Position: refs/branch-heads/2924@{#225}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge "Fix range checking for PP_CdmKeyStatus"
The specified maximum value doesn't allow PP_CDMKEYSTATUS_RELEASED,
so update it.
BUG=666975
TEST=Tested with W3C EME tests
Review-Url: https://codereview.chromium.org/2514123004
Cr-Commit-Position: refs/heads/master@{#433754}
(cherry picked from commit c24785e7ff8bf6ce47d903b598d813e1bbd17fab)
Review URL: https://codereview.chromium.org/2541193002 .
Cr-Commit-Position: refs/branch-heads/2924@{#224}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix a crash when removing a completed download from download Manager
When executing the task on theadpool, we can get an exception if workers are running out.
This CL uses the serial executor to execute the task, so that there is no need to try-catch and re-run the async task.
The change also fixes some synchronization issue when adding/removing a download.
BUG=667517
[email protected]
Review-Url: https://codereview.chromium.org/2533943002
Cr-Commit-Position: refs/heads/master@{#435400}
(cherry picked from commit ec478b21836e36d073d68a042932cd6d75a905e0)
Review URL: https://codereview.chromium.org/2542763003 .
Cr-Commit-Position: refs/branch-heads/2924@{#223}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Set black background color only for fullscreen video mode
Setting the layer tree background to black has a side effect of
causing flicker when a tab is closed. This CL set the background
to black only when the full screen video mode is entered (i.e.
transparent mode is enabled) to avoid the issue.
BUG=646336
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2507143002
Cr-Commit-Position: refs/heads/master@{#434082}
(cherry picked from commit d4b3f4e4e76ec07625bdc463678a3c469f6b29a2)
Review-Url: https://codereview.chromium.org/2541583004
Cr-Commit-Position: refs/branch-heads/2924@{#222}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Clean up UI WebContents when destroying VR Shell.
Note that now our re-entry performance is worse than before, because we weren't recreating our WebContents before. We should look into either caching, pre-loading, or otherwise, to improve startup time.
BUG=669065
Review-Url: https://codereview.chromium.org/2535853002
Cr-Commit-Position: refs/heads/master@{#434672}
(cherry picked from commit 9da88a2254c9cde59bc7f266f420391a1ba9f3ec)
Review URL: https://codereview.chromium.org/2540233003 .
Cr-Commit-Position: refs/branch-heads/2924@{#221}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge to m56: Re-add the line break attribute
This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed.
TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2526073003
Cr-Commit-Position: refs/heads/master@{#434747}
(cherry picked from commit 7823f3cdcb5cdc467d8362673e205bac71953320)
BUG=669134
[email protected]
Review URL: https://codereview.chromium.org/2532953010 .
Cr-Commit-Position: refs/branch-heads/2924@{#220}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix privacy whitepaper link on safe browsing blocking page and captive
portal bloking page (whitepaper links on other interstitials are fine).
Link privacy whitepaper to "system information and page content" instead
of "Automatically send" on Scout opt-in string.
BUG=667823,667385
Review-Url: https://codereview.chromium.org/2526543002
Cr-Commit-Position: refs/heads/master@{#434546}
(cherry picked from commit 762fb54cd325ae2f557a3a8f9199daa480f8f8b7)
Review URL: https://codereview.chromium.org/2540243003 .
Cr-Commit-Position: refs/branch-heads/2924@{#219}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Remove XSS from chrome://downloads
BUG=668653
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2526323004
Cr-Commit-Position: refs/heads/master@{#435104}
(cherry picked from commit 6d9a7916b48581f72fda060a1210ebef7f89b229)
Review URL: https://codereview.chromium.org/2537893004 .
Cr-Commit-Position: refs/branch-heads/2924@{#218}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Instant Apps: Skip checking referrer param on SERP.
The referrer param doesn't get set because the web platform doesn't set
referrers for intent:// URLs. Since we are checking the referrer via
navigation controller, we don't need to do this check anyway.
BUG=669698
Review-Url: https://codereview.chromium.org/2539633003
Cr-Commit-Position: refs/heads/master@{#435306}
(cherry picked from commit 23d53a43e18bfd1399ea4a3ab922c887ecff453f)
Review URL: https://codereview.chromium.org/2543793002 .
Cr-Commit-Position: refs/branch-heads/2924@{#217}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[OfflinePages] Call NotifyInterrupted for pending requests
BUG=668231
Review-Url: https://codereview.chromium.org/2521353005
Cr-Commit-Position: refs/heads/master@{#435154}
(cherry picked from commit 59651690714d5c1b475d60a796ca11db423038cd)
Review URL: https://codereview.chromium.org/2537373004 .
Cr-Commit-Position: refs/branch-heads/2924@{#216}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix missing warning for canceling touchmove when in default not passive mode.
It appears that the the log error was dropped when the default mode enum
was added in change https://codereview.chromium.org/2475443004. Add a test
to ensure that it doesn't get dropped again.
BUG=667799
Review-Url: https://codereview.chromium.org/2536563003
Cr-Commit-Position: refs/heads/master@{#434998}
(cherry picked from commit be1e266d539e2caeff5e7b174dba20e88d60f319)
Review URL: https://codereview.chromium.org/2541003004 .
Cr-Commit-Position: refs/branch-heads/2924@{#215}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Don't log a console warning when touch-action is used.
To avoid log fatigue for the developer only log the "you are prevent
defaulting a passive event listener" if no touch-action is used. If
touch-action is being used then it is clear that the developer is doing
this to interop with other browsers that don't support touch-action.
BUG=667799
Review-Url: https://codereview.chromium.org/2520423004
Cr-Commit-Position: refs/heads/master@{#434536}
(cherry picked from commit 6ea5974532e7cfea654c59181f1819e6805bb368)
Review URL: https://codereview.chromium.org/2539183003 .
Cr-Commit-Position: refs/branch-heads/2924@{#214}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Removed un-wanted right padding from the date label in the system menu.
Removed 8dp padding from the right side of the date label in the system
menu that was left over from non-md.
BUG=669221
Review-Url: https://codereview.chromium.org/2537033002
Cr-Commit-Position: refs/heads/master@{#434980}
(cherry picked from commit bccf9329f520d11d88a04e43abb1632c4859ddfb)
Review URL: https://codereview.chromium.org/2538233002 .
Cr-Commit-Position: refs/branch-heads/2924@{#213}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Enable RemotePlayback API by default
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/Blink-dev/kJLzOeS-l4w/Dco5FIcpAwAJ
BUG=578833
TEST=none
Review-Url: https://codereview.chromium.org/2515443004
Cr-Commit-Position: refs/heads/master@{#435418}
(cherry picked from commit 23a621b7f7c8ee82922f9846d10f78ddb5722244)
Review URL: https://codereview.chromium.org/2540313003 .
Cr-Commit-Position: refs/branch-heads/2924@{#212}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
M56: Fix one more RenderFrame/RenderView ID mixup in printing code.
BUG=667208
Review-Url: https://codereview.chromium.org/2527913002
Cr-Commit-Position: refs/heads/master@{#434853}
(cherry picked from commit 26cd6767bd337d9a1bd4d71303669f4b371b0b90)
Review URL: https://codereview.chromium.org/2544623003 .
Cr-Commit-Position: refs/branch-heads/2924@{#211}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Disable WebVR presentation for Cardboard viewers.
BUG=667908
Review-Url: https://codereview.chromium.org/2524883002
Cr-Commit-Position: refs/heads/master@{#434023}
(cherry picked from commit 197a42ece84e4dbb583290d53f28b5501dc43619)
Review URL: https://codereview.chromium.org/2540103004 .
Cr-Commit-Position: refs/branch-heads/2924@{#210}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
DevTools: allow JS frames under EventDispatch
BUG=652332
Review-Url: https://codereview.chromium.org/2528553002
Cr-Commit-Position: refs/heads/master@{#434732}
(cherry picked from commit ce6a35209d7ebeb969d372c0bf23c0c403bdd83d)
Review URL: https://codereview.chromium.org/2541043003 .
Cr-Commit-Position: refs/branch-heads/2924@{#209}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Only apply accessibility font scale factor when autosizing inflates
The accessibility font scale factor is currently applied to all text
that the text autosizer would inflate (this is changing in
crbug.com/645717). crrev.com/1229b1414d64c314666d2fb3bf47706f2b5e947b
introduced a bug where text that would not be inflated would become
inflated if text-size-adjust: none was applied.
This patch only applies the accessibility font scale factor if the
text autosizer would have inflated the text already. A new test,
AccessibilityFontScaleFactorWithTextSizeAdjustNone, has been added.
Other tests in TestAutosizerTest.cpp have been reformatted to 80cols.
BUG=666378
Review-Url: https://codereview.chromium.org/2514733005
Cr-Commit-Position: refs/heads/master@{#433757}
(cherry picked from commit 394de7b0baa6b0136b6acfd15486de6a98e19152)
Review URL: https://codereview.chromium.org/2544633002 .
Cr-Commit-Position: refs/branch-heads/2924@{#208}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Do not query VPN connected state on null VPN NetworkState object
In VpnDefaultView::GetNetworkStateHandlerImageAndLabel(),
do not query the connected state of the NetworkState
|vpn| object if it is null (i.e., if VPN is not enabled).
BUG=669274
Review-Url: https://codereview.chromium.org/2542523002
Cr-Commit-Position: refs/heads/master@{#435282}
(cherry picked from commit acc1e141ba505a5ab488c4f80a375b4b837d5301)
Review URL: https://codereview.chromium.org/2540293002 .
Cr-Commit-Position: refs/branch-heads/2924@{#207}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix crashes when DaydreamApi returns null.
BUG=667444
Review-Url: https://codereview.chromium.org/2516303007
Cr-Commit-Position: refs/heads/master@{#434010}
(cherry picked from commit 467f897467dd34de6299f1b5853589e4cee4b4eb)
Review URL: https://codereview.chromium.org/2538023003 .
Cr-Commit-Position: refs/branch-heads/2924@{#206}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Regression bug Investigation: add guard socket file descriptor in UDPSocketPosix
Landing https://codereview.chromium.org/1053873003 again to
enables file descriptor guard on Max OSX for all UDP sockets to make sure we they
are not closed from anywhere else except UDPSocketPosix::Close() and we get a correct
crash stack to debug the linked issue.
BUG=640281
Review-Url: https://codereview.chromium.org/2505233003
Cr-Commit-Position: refs/heads/master@{#433088}
(cherry picked from commit 6a57f2bc3f617c441be7e8e8891919e983101c28)
Review URL: https://codereview.chromium.org/2539253002 .
Cr-Commit-Position: refs/branch-heads/2924@{#205}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M56 merge] Reference table row via the cell for row background display item client.
BUG=666800
Review-Url: https://codereview.chromium.org/2522923003
Cr-Commit-Position: refs/heads/master@{#434110}
(cherry picked from commit 91b1dd79c0916b9c329058622919f190958ec626)
Review URL: https://codereview.chromium.org/2541943002 .
Cr-Commit-Position: refs/branch-heads/2924@{#204}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Disable WebVR Presentation when in MultiWindow mode.
BUG=667781
Review-Url: https://codereview.chromium.org/2523583004
Cr-Commit-Position: refs/heads/master@{#433900}
(cherry picked from commit f212bb93309c374d4ff6c3c4c8a1a1e160eddece)
Review URL: https://codereview.chromium.org/2541633004 .
Cr-Commit-Position: refs/branch-heads/2924@{#203}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge-M56] arc: Fix duplicate icons in app launcher in case of crash.
This CL initializes tracking items by existing app set on start in
order to prevent race condition that leads to arc app created is
called twice for some apps.
[email protected]
NOTRY=true
NOPRESUBMIT=true
TEST=Extended unit_tests
TEST=Manually on device with chrome://inducebrowsercrashforrealz
BUG=b/32765086
BUG=667529
Review-Url: https://codereview.chromium.org/2520173002
Cr-Commit-Position: refs/heads/master@{#433980}
(cherry picked from commit 4e1e8774f3b147906917dbd4e50f30bfc7372ba6)
Review-Url: https://codereview.chromium.org/2545533002
Cr-Commit-Position: refs/branch-heads/2924@{#202}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix crash in onPause() for non-daydream devices.
BUG=667444
Review-Url: https://codereview.chromium.org/2521603003
Cr-Commit-Position: refs/heads/master@{#433666}
(cherry picked from commit aaf0f3966ce45a662c6ddc940fb48cf2174be35c)
Review URL: https://codereview.chromium.org/2540243002 .
Cr-Commit-Position: refs/branch-heads/2924@{#201}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge "Update milestone for EME non-standard functionality"
Moving milestone to M58.
BUG=605661
TEST=messages logged with EME layout tests
Review-Url: https://codereview.chromium.org/2539573002
Cr-Commit-Position: refs/heads/master@{#434852}
(cherry picked from commit c4b5bb4969a525126bb416aea5407f413abf0d0c)
Review URL: https://codereview.chromium.org/2541763004 .
Cr-Commit-Position: refs/branch-heads/2924@{#200}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Be more selective about when we show the "Take off your headset" flow.
BUG=641401
Review-Url: https://codereview.chromium.org/2516453002
Cr-Commit-Position: refs/heads/master@{#433214}
(cherry picked from commit 4ebc409e6f3e818512ebd0231cf9222e5d9400d3)
Review URL: https://codereview.chromium.org/2540223002 .
Cr-Commit-Position: refs/branch-heads/2924@{#199}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Fixed TriView to relayout child Views when their preferred size changed.
Previously TriView child views would be allocated their preferred size
during the TriView layout. However, if a child view's preferred size
later changed it did not trigger a TriView layout and the child view
would not be allocated space based on its new preferred size.
This change fixes it so that a TriView's child will be reallocated space
if its preferred size changes. This will not cause the TriView
container views to be resized when a child views preferred size changes.
BUG=667955
TEST=ash_unittests --gtest_filter=TriViewTest.ChildViewsPreferredSizeChanged
Review-Url: https://codereview.chromium.org/2538513002
Cr-Commit-Position: refs/heads/master@{#434818}
(cherry picked from commit 0f07a3024a009d9a367d07a2740a3ac96558ab79)
Review URL: https://codereview.chromium.org/2535173005 .
Cr-Commit-Position: refs/branch-heads/2924@{#198}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[RemotePlayback] No monitoring on low-end devices
BUG=659672
TEST=layout test with extra plumbing through Internals
Review-Url: https://codereview.chromium.org/2475293003
Cr-Commit-Position: refs/heads/master@{#435095}
(cherry picked from commit 2707b633861011503944b886e36e3708e39d2593)
Review URL: https://codereview.chromium.org/2541873003 .
Cr-Commit-Position: refs/branch-heads/2924@{#197}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Mac] Omnibox text and icon spacing
- Moved the BubbleDecoration one pt to the left
- Moved the Omnibox text one pt to the left
BUG=666990, 666977
Review-Url: https://codereview.chromium.org/2520003007
Cr-Commit-Position: refs/heads/master@{#434929}
(cherry picked from commit c3a5825e0723184c3f72bffdc916035249318390)
Review URL: https://codereview.chromium.org/2543693002 .
Cr-Commit-Position: refs/branch-heads/2924@{#196}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Reland of Post tasks for sensitive input visibility notifications (patchset #1 id:1 of https://codereview.chromium.org/2531683002/ )
Reason for revert:
Fixing SecuritySTateTabHelperTests
Original issue's description:
> Revert of Post tasks for sensitive input visibility notifications (patchset #5 id:80001 of https://codereview.chromium.org/2515373003/ )
>
> Reason for revert:
> Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10
>
> E.g.
> SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
> SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch
>
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/24682
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/9716
>
> Errors like
>
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
> Value of: security_info.security_level
> Actual: 0
> Expected: security_state::HTTP_SHOW_WARNING
> Which is: 1
> ../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
> Value of: entry->GetSSL().content_status & content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
> Actual: false
> Expected: true
>
> Original issue's description:
> > Post tasks for sensitive input visibility notifications
> >
> > If password inputs are hidden and shown multiple times in the same task
> > (as apparently happens when processing a stylesheet), we don't want to
> > the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> > input visibility notifications to the end of the task queue, so that the
> > omnibox warning updates get coalesced.
> >
> > BUG=664194
> > TEST=Visit http://http-password.badssl.com and observe that the omnibox
> > warning does not flicker in and out twice.
> >
> > Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> > Cr-Commit-Position: refs/heads/master@{#434340}
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664194
>
> Committed: https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
> Cr-Commit-Position: refs/heads/master@{#434400}
[email protected],[email protected],[email protected]
BUG=664194
Review-Url: https://codereview.chromium.org/2538473002
Cr-Commit-Position: refs/heads/master@{#434820}
(cherry picked from commit d262a0ed6bd977cfec18514171790fcaee02a0a1)
Review URL: https://codereview.chromium.org/2536203004 .
Cr-Commit-Position: refs/branch-heads/2924@{#195}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Adjust the timestamp for VRDisplay.requestAnimationFrame calls
Previously timestamps had their origin incorrectly adjusted and were multiplied
by 1000.
BUG=669594
Review-Url: https://codereview.chromium.org/2533383002
Cr-Commit-Position: refs/heads/master@{#435143}
(cherry picked from commit 769c85525581f5f39cdc1d207b2254d35cb106f3)
Review URL: https://codereview.chromium.org/2544553002 .
Cr-Commit-Position: refs/branch-heads/2924@{#194}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Implement vrdisplayactivate for GVR DON.
This allows webVR pages to auto-present when the DON flow is triggered by putting the phone in the headset, rather than by the page requesting WebVR.
BUG=641401
Review-Url: https://codereview.chromium.org/2502363004
Cr-Commit-Position: refs/heads/master@{#433213}
(cherry picked from commit c34e2fa914fb0f72599f632c3168f9ec3884441f)
Review URL: https://codereview.chromium.org/2538053003 .
Cr-Commit-Position: refs/branch-heads/2924@{#193}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Notify VRDeviceProviders when there are pages listening for vrdisplayactivate
BUG=389343
Review-Url: https://codereview.chromium.org/2510993002
Cr-Commit-Position: refs/heads/master@{#433144}
(cherry picked from commit 96c9f7733bd011ec909e3a5a60422b6c50066cb5)
Review URL: https://codereview.chromium.org/2537403004 .
Cr-Commit-Position: refs/branch-heads/2924@{#192}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Blink Heap] Move isLowEndDevice to Memory Coordinator, attempt #3
A preparation for https://codereview.chromium.org/2475293003 to be able to
override this from tests.
Had to go with a static method approach. Seems like hanging it off the heap allocated object breaks blink_heap_unittests on Mac and Windows
(see https://codereview.chromium.org/2503433003 and https://codereview.chromium.org/2510353005).
BUG=659672
TEST=Run the blink_heap_unittests locally (on Linux).
Review-Url: https://codereview.chromium.org/2518273003
Cr-Commit-Position: refs/heads/master@{#434027}
(cherry picked from commit caab7202c6ecbbaf5caa71be51e7c1d061606f35)
Review URL: https://codereview.chromium.org/2542683002 .
Cr-Commit-Position: refs/branch-heads/2924@{#191}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[MediaRouter, Android] Rebase the controller dialog fragment.
MediaRouteControllerDialogManager.Fragment inherits from
BaseMediaRouteDialogManager.Fragment which inherits from
MediaRouteChooserDialogFragment. I changed the former to inherit
directly from the MediaRouteControllerDialogFragment and merged the base
dialog fragment logic with both Chrome's custom fragment classes.
In the essence, the rebasing is needed so that two final subclasses could
inherit from the right MediaRouteXXXDialogFragment (Chooser and Controller)
- that's the only behavioral change that fixes the problem.
BUG=667269
TEST=manual on any cast-enabled mobile-friendly website.
[email protected]
Review-Url: https://codereview.chromium.org/2523413002
Cr-Commit-Position: refs/heads/master@{#434528}
(cherry picked from commit cebca8e4a6d6e86016a8b26812e74d706d2e8a16)
Review URL: https://codereview.chromium.org/2546463002 .
Cr-Commit-Position: refs/branch-heads/2924@{#190}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge-M56] arc: Fix link to privacy in OptIn UI.
This fixes the regression caused by refactoring.
TEST=Manually
BUG=b/32545771
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2541553002
Cr-Commit-Position: refs/heads/master@{#435030}
(cherry picked from commit 99fc133904fa8317fb0d0adc941791d00ea843e5)
Review-Url: https://codereview.chromium.org/2541883002
Cr-Commit-Position: refs/branch-heads/2924@{#189}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge-M56] arc: Prepare ArcAuthEndpoint flag for finch experiment.
We would like to test silent Arc opt-in flow via finch experiment
and this CL updates switch that acivates silent auth workflow.
TEST=Manually on device using --enable-features=ArcUseAuthEndpoint
and switch in chrome://flags. Plase note, for test I used
www-googleapis-staging.sandbox.google.com instead of
www.googleapis.com that should be availble on Nov 17.
BUG=b/28987931
[email protected]
[email protected]
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2508713003
Cr-Commit-Position: refs/heads/master@{#433165}
(cherry picked from commit b0b70023925b4d29270a76f77c45bf8a0d7fbafa)
Review-Url: https://codereview.chromium.org/2538493002
Cr-Commit-Position: refs/branch-heads/2924@{#188}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix UaF in RenderFrameImpl::OnBeforeUnload.
BUG=666714
Review-Url: https://codereview.chromium.org/2514323003
Cr-Commit-Position: refs/heads/master@{#434226}
(cherry picked from commit 0dd441a0007aa46917779e782ee9094f111a02b3)
[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2541073002
Cr-Commit-Position: refs/branch-heads/2924@{#187}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix XSS in app launcher and remove use of unvalidated URL
The third parameter of "launchApp" is only used for the webstore app,
and used to append utm_source=chrome-ntp-icon to the app URL.
But the launchApp handler did not validate that the URL is safe.
To fix that issue, I specialize the parameter for launchApp: It now takes the
source string ("chrome-ntp-icon") instead of a URL without validation.
BUG=668665
TEST=Manually using test case from bug report. Also opened the app launcher and
verified that clicking on the Webstore icon still leads to the same place.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2527413002
Cr-Commit-Position: refs/heads/master@{#434939}
(cherry picked from commit 15120efa4b9394086d687086e443f47290b5170a)
Review URL: https://codereview.chromium.org/2542593002 .
Cr-Commit-Position: refs/branch-heads/2924@{#186}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
M56: Check for PrintWebViewHelper validity when running nested message loops.
BUG=666616
Review-Url: https://codereview.chromium.org/2522313003
Cr-Commit-Position: refs/heads/master@{#434734}
(cherry picked from commit d5c9ff3d4eb3de0945a0537288a4bee31c2ee4cf)
Review URL: https://codereview.chromium.org/2532323004 .
Cr-Commit-Position: refs/branch-heads/2924@{#185}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects()
clearPreviousVisualRects() is called when the object's previous visual
rects become invalid (e.g. when the object becomes composited). We
should call setMayNeedPaintInvalidationSubtree to ensure paint
invalidation checking of subtree which would be triggered by changed
location if we had valid previous location.
BUG=666267
TEST=paint/invalidation/compositing/become-composited-zero-offset.html
Review URL: https://codereview.chromium.org/2541763002 .
Review-Url: https://codereview.chromium.org/2537653002
Cr-Original-Commit-Position: refs/heads/master@{#434894}
Cr-Commit-Position: refs/branch-heads/2924@{#184}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[TTS] Fix blank and stale bar-text issues.
This change seems to fix the cases where a stale Search Term is
sometimes displayed. It also seems to fix most of the cases where
a blank bar is sometimes shown when the Context should be displayed.
We were setting the opacity of the Search Term based on the opacity
of the Context, assuming that they are complementary, which is not
always the case. Now we honor the Search Term opacity passed in to
ContextualSearchLayer::SetProperties. This fixes the stale text
from the previous Search Term being shown.
When showing the Context we were checking if the panel is showing.
Sometimes the panel is not yet actually showing even after the code
has called requestPanelShow because the panel is still completely
offscreen. Now we no longer check if the panel is showing before
setting the Context. This seems to fix most of the remaining cases
where a blank panel was seen. The panel will always exist and its
components will be lazily created, so this seems safe for now.
However we should implement a better way to know if it's been asked
to show (crbug.com/669600).
This change may not fix all cases -- I occasionally see a blank
bar after the first startup.
BUG=658771
Review-Url: https://codereview.chromium.org/2535313002
Cr-Commit-Position: refs/heads/master@{#435112}
(cherry picked from commit bb3cb5760cc9f1778969dafaa67ee7712b010f5f)
Review URL: https://codereview.chromium.org/2540923002 .
Cr-Commit-Position: refs/branch-heads/2924@{#183}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[TTS] Fix Bar text showing blank after startup.
The Bar has main bar text that can either show the Search Term or the
Context. When the user taps we show the Context first, and the Search
Term is not yet visible, so calculations based on its size are invalid.
We now check to see if the Search Term text is visible before using any
attribute of it.
BUG=658771
Review-Url: https://codereview.chromium.org/2518503004
Cr-Commit-Position: refs/heads/master@{#434723}
(cherry picked from commit aa73340fc20421e8a9816de1033f6c553cb28983)
Review URL: https://codereview.chromium.org/2534263003 .
Cr-Commit-Position: refs/branch-heads/2924@{#182}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Extensions] Fix lifetime bug in ExtensionAction/IconImage
ExtensionActions can lazily load the default icon image, which is
implemented as an IconImage. The IconImage, in turn, is constructed with
a BrowserContext because it needs access to the ImageLoader (a
BrowserContextKeyedService). ExtensionActions are owned by the
ExtensionActionManager (another BrowserContextKeyedService with one
instance shared across incognito and normal profiles), but took a
BrowserContext as an argument when loading the default icon image.
This all caused a problem when an incognito profile was passed in as
the browser context to load the default icon for the extension action.
The extension action would then create an IconImage with the incognito
profile as a context, but the ExtensionAction (and thus the IconImage)
are owned by the ExtensionActionManager, and are therefore not deleted
upon the incognito profile's destruction. This means that if you have a
flow where the ExtensionAction's default icon is loaded via an incognito
profile, the incognito profile is deleted, and then the icon is later
used in the normal profile, there's a crash.
Fix this by having the ExtensionActionManager assign the IconImage to
the ExtensionAction using its own profile. Since the ExtensionActions
are owned by the ExtensionActionManager, and the ExtensionActionManager
is owned by the profile by being a BrowserContextKeyedService, this is
guaranteed to be safe. This also abstracts out the context of a profile
or BrowserContext from the ExtensionAction class, keeping it more in
line with its data-structure-like concept.
Add a regression test.
BUG=663726 (and possibly others)
Review-Url: https://codereview.chromium.org/2506273002
Cr-Commit-Position: refs/heads/master@{#433361}
(cherry picked from commit d09e1c4d5c955d73cc38f507ede1119f6c540320)
Review URL: https://codereview.chromium.org/2537263003 .
Cr-Commit-Position: refs/branch-heads/2924@{#181}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Use MD version of scroll item separator in MD Bluetooth details view.
The bluetooth details view used the old style separator, which has different
top/bottom spacing from MD version.
It should use MD standard separator which is provided by TrayPopupUtils.
BUG=663154
TEST=manually tested
Review-Url: https://codereview.chromium.org/2524253002
Cr-Commit-Position: refs/heads/master@{#434438}
(cherry picked from commit 58a04f09a6e676a285fa681120cbc70243f7a420)
Review URL: https://codereview.chromium.org/2538933002 .
Cr-Commit-Position: refs/branch-heads/2924@{#180}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.11
Cr-Commit-Position: refs/branch-heads/2924@{#179}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Updating XTBs based on .GRDs from branch 2924
Cr-Commit-Position: refs/branch-heads/2924@{#178}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
To M56: Roll src/third_party/ffmpeg/ 5ed6e20c0..d16162e3f (1 commit).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/5ed6e20c0984..d16162e3f4cb
$ git log 5ed6e20c0..d16162e3f --date=short --no-merges --format='%ad %ae %s'
2016-11-22 wolenetz mov: immediately return from mov_fix_index without old index entries
[email protected]
BUG=667063,591845
Review-Url: https://codereview.chromium.org/2523633006
Cr-Commit-Position: refs/heads/master@{#434094}
(cherry picked from commit 2c2f0c675831ce35c92723e249ebadd8cfc12bb5)
Review URL: https://codereview.chromium.org/2540863003 .
Cr-Commit-Position: refs/branch-heads/2924@{#177}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
To M56: Roll src/third_party/ffmpeg 141e56c:5ed6e20 (mp3 msan fix)
Summary of changes available at:
https://chromium.googlesource.com/chromium/third_party/ffmpeg/+log/141e56c..5ed6e20
Brings in single commit:
5ed6e20 mp3dec: fix msan warning when verifying mpa header
BUG=666874,591845
[email protected]
Review-Url: https://codereview.chromium.org/2527563002
Cr-Commit-Position: refs/heads/master@{#434055}
(cherry picked from commit 0c71998a74cf73fc7b0bb7d089d286449318b691)
Review URL: https://codereview.chromium.org/2543473002 .
Cr-Commit-Position: refs/branch-heads/2924@{#176}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
To M56: Roll src/third_party/ffmpeg/ e91355afa..141e56ccf (1 commit).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/e91355afac54..141e56ccf7fc
$ git log e91355afa..141e56ccf --date=short --no-merges --format='%ad %ae %s'
2016-11-21 wolenetz lavc/libopusdec.c Fix ff_vorbis_channel_layouts OOB
[email protected]
BUG=666794, 591845
Review-Url: https://codereview.chromium.org/2518063003
Cr-Commit-Position: refs/heads/master@{#433766}
(cherry picked from commit 3431ae5ea798e4ce3b7da6b44bf4dab426114bba)
Review URL: https://codereview.chromium.org/2537973002 .
Cr-Commit-Position: refs/branch-heads/2924@{#175}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
To M56: Roll src/third_party/ffmpeg/ 92f86a517..e91355afa (1 commit).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/92f86a51725e..e91355afac54
$ git log 92f86a517..e91355afa --date=short --no-merges --format='%ad %ae %s'
2016-11-21 wolenetz lavf/utils.c Protect against accessing entries[nb_entries]
[email protected]
BUG=666770,666769,591845
Review-Url: https://codereview.chromium.org/2521573003
Cr-Commit-Position: refs/heads/master@{#433740}
(cherry picked from commit b46025db9f4903b694812dbed8d1630c01897e65)
Review URL: https://codereview.chromium.org/2541463004 .
Cr-Commit-Position: refs/branch-heads/2924@{#174}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
To M56: Roll src/third_party/ffmpeg/ cdf4accee..92f86a517 (1 commit).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/cdf4acceee58..92f86a51725e
$ git log 3c7a09882..92f86a517 --date=short --no-merges --format='%ad %ae %s'
2016-11-17 wolenetz Disable deprecation warnings locally within ffmpeg
BUG=591845
[email protected]
Review-Url: https://codereview.chromium.org/2511773004
Cr-Commit-Position: refs/heads/master@{#433132}
(cherry picked from commit b25dd7e750dd25ee51f49d463ddce3eea3efc665)
Review URL: https://codereview.chromium.org/2541713002 .
Cr-Commit-Position: refs/branch-heads/2924@{#173}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
To M56: Roll src/third_party/ffmpeg/ 3c7a09882..cdf4accee (3188 commits).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/3c7a09882102..cdf4acceee58
$ git log 3c7a09882..cdf4accee --date=short --no-merges --format='%ad %ae %s'
2016-11-17 wolenetz Enable windows Chrom* build including lavf/wavdec.c
2016-11-17 wolenetz Updating build configs for M56 roll.
2016-11-17 wolenetz Disable nvenc autodetection by configure in build_ffmpeg.py
2016-11-16 wolenetz Remove deprecated munge script
2016-11-16 wolenetz build_ffmpeg on win: ignore unresolved symbols when linking
2016-11-16 wolenetz Update win_env.sh vs_files folder
2016-11-16 wolenetz Enable mac build_ffmpeg of lavf/wavdec.c
2016-11-16 wolenetz Enable mac build_ffmpeg to find external libopus symbols
2016-11-15 wolenetz Return to previous mips minimum ISA logic in configure
2016-10-25 thakis win: Remove VS2013 checks now that we require VS2015.
2016-11-15 wolenetz Enable FLAC in all Chrom* ffmpeg brandings
2016-11-15 wolenetz Remove the downstream patch for WinXP support
2016-11-15 wolenetz Drop obsolete 'arm' android TARGET_ARCH
2016-11-15 wolenetz Force HAVE_POSIX_MEMALIGN to be 0 in config.h for android in build_ffmpeg.py
2016-11-15 wolenetz Force HAVE_VALGRIND_VALGRIND_H to be 0 in build_ffmpeg.py
2016-11-11 wolenetz Update chromium/ffmpeg.sigs
2016-11-03 wolenetz Fix UAF in lavf/matroskadec.c if matroska_parse_tracks() fails
2016-11-01 wolenetz Temporarily undeprecate old ffmpeg A/V decode API
2016-11-01 wolenetz Update generate_gn.py to ignore generated bsf_list.c and protocol_list.c
2016-11-01 wolenetz Include generated bsf_list.c and protocol_list.c in configs
2016-10-28 wolenetz Update chromium/patches/README w.r.t. sidx revert patch
2016-10-25 wolenetz Chromium patch and README updates
2016-10-25 thakis win: Remove VS2013 checks now that we require VS2015.
2016-10-25 cehoyos lavc/utvideoenc: Set bits_per_coded_sample for rgba.
2016-10-25 michael avcodec/interplayvideo: Check side data size before use
2016-10-25 michael avcodec/ffv1enc: Fix storing RGB48 without explicitly set level
2016-10-18 vittorio.giovara vf_colorspace: Add support for iec61966-2.1 (sRGB) transfer
2016-10-24 rsbultje vf_colorspace: don't spam console with warnings if range is unspecified.
2016-10-14 rsbultje vp9: change order of operations in adapt_prob().
2016-01-07 rodger.combs lavf/mov: reindent
2016-01-07 rodger.combs lavf/mov: improve `tref/chap` chapter handling
2016-10-24 rodger.combs lavf: add AV_DISPOSITION_TIMED_THUMBNAILS
2016-04-28 rodger.combs fate/hevc: add automatic bsf test
2016-04-15 rodger.combs fate/aac: add automatic bsf test
2016-04-15 rodger.combs fate/h264: make mp4toannexb test use auto-BSF
2016-09-09 rodger.combs lavf/rawenc: add automatic bitstream filtering for H264+HEVC
2016-04-07 rodger.combs lavf/movenc+dashenc: add automatic bitstream filtering
2016-04-07 rodger.combs lavf/dashenc: add deinit function
2016-04-07 rodger.combs lavf/movenc: add deinit function
2016-04-07 rodger.combs lavf/segment: fix writing separate header with auto BSF
2016-04-07 rodger.combs lavf/segment: add deinit function
2016-06-24 rodger.combs lavf/mux: add avformat_init_output
2016-10-24 rodger.combs MAINTAINERS: add myself for audiotoolbox
2016-10-03 rodger.combs ffprobe: report field order for video streams
2016-10-03 rodger.combs lavc/utils: avcodec_string: dump field order when known
2016-10-03 rodger.combs lavc/h264_parser: export field order in more cases
2016-09-20 rodger.combs lavc/parser: export field order if not already set
2016-10-23 u lavfi: remove 2 unused lavc includes
2016-10-23 michael avutil/x86/emms: Document the emms_c() vs alloc/free relation.
2016-10-22 Andreas.Cadhalpun faq: use relative links to own documentation
2016-10-10 zhouxiaoyong avcodec/mips: loongson optimize mmi load and store operators
2016-10-10 zhouxiaoyong avutil/mips: loongson add mmi utils header file
2016-10-22 carlos lavf/mpegts: add missed fixes to scte35 section callback
2016-10-22 philipl avcodec/cuvid: Allow reinitialization of decoder
2016-10-17 jamrial avformat/matroskaenc: write DisplayWidth and DisplayHeight elements only if they differ from PixelWidth and PixelHeight
2016-10-22 Andreas.Cadhalpun mpegts: handle AVMEDIA_TYPE_UNKNOWN correctly
2016-10-21 michael avutil/avassert: Add av_assertX_fpu()
2016-10-21 michael avcodec/snowenc: Clear MMX state after edge drawing and picture encode
2016-10-21 michael avcodec/mpegvideo_enc: Add missing emms_c() to clear MMX state after SIMD use
2016-10-21 michael avcodec/utils: Move emms_c() before memory allocation functions in avcodec_encode_video2()
2016-10-21 michael avcodec/cavsdec: Clear MMX state after MB decode loop
2016-10-21 michael avcodec/svq1enc: Clear MMX state after svq1_encode_plane()
2016-10-22 cehoyos lavf/rtpdec_g726: Map mime type G726 to g726le.
2016-10-20 kagami lavc/libvpxenc: fix -auto-alt-ref option type
2016-10-21 dalecurtis Enable libopus builds within build_ffmpeg.py
2016-10-13 Andreas.Cadhalpun doc: fix spelling errors
2016-10-18 carlos lavf/mpegts: SCTE-35 extraction from mpegts
2016-10-18 carlos lavc: add SCTE-35 CUI codec ID
2016-10-13 cus lavd/decklink_dec: fix indentation
2016-10-13 cus lavd/decklink_dec: add option to disable drawing bars on signal loss
2016-10-21 michael avformat/mxfdec: Check size to avoid integer overflow in mxf_read_utf16_string()
2016-10-21 michael avformat/mxfdec: Fix mixed declaration and code
2016-10-20 Andreas.Cadhalpun mpeg12dec: unref discarded picture from extradata
2016-10-20 Andreas.Cadhalpun cavsdec: unref frame before referencing again
2016-10-20 Andreas.Cadhalpun dcstr: fix division by zero
2016-10-20 Andreas.Cadhalpun aiff: check block_align in aiff_read_packet
2016-10-12 lq avcodec/vda: define av_vda_default_init2 when CONFIG_H264_VDA_HWACCEL equ 0
2016-10-12 oyama avformat/rtmpproto: Fix RTMP control message handling error in listen mode.
2016-10-21 michael avcodec/mpegvideo_enc: Clear mmx state in ff_mpv_reallocate_putbitbuffer()
2016-10-21 michael avcodec/utils: Clear MMX state before returning from avcodec_default_execute*()
2016-10-21 michael avcodec/dnxhdenc: Move allocation out of radix_sort()
2016-10-06 rodger.combs lavf/segment: decide whether to rename based on list URI
2016-10-10 protogonoi openssl: Support version 1.1.0.
2016-09-21 mindmark tests/fate: add mxf metadata streams test
2016-09-21 mindmark libavformat/mxfdec: add metadata streams for external referenced sourclips
2016-09-21 mindmark libavformat/mxfdec: don't assume first stream index to be primary
2016-09-21 mindmark libavformat/mxfdec: export track name metadata
2016-10-19 t.rapp avformat/mxfdec: Detect field_order based on video_line_map
2016-10-19 Andreas.Cadhalpun rsd: limit number of channels
2016-10-20 h.leppkes dxva2: fix surface selection when compiled with both d3d11va and dxva2
2016-10-12 lq avformat/flvenc: do not attempt to write duration and filesize when not seekable
2016-10-18 cehoyos lavc/sheervideo: Increase av_get_codec_tag_string() input buffer size.
2016-10-19 mfcc64 avfilter/firequalizer: use zero phase kernel
2016-10-19 mfcc64 avfilter/showcqt: add cscheme option
2016-10-19 cehoyos lavf/riff: Document the interleaving of VSM4 video.
2016-10-19 Andreas.Cadhalpun avformat: prevent triggering request_probe assert in ff_read_packet
2016-10-18 derek.buitenhuis FATE: Add test for muxing discontinuous MP4 fragments with large timestamps
2016-10-18 michael avformat/movenc: Skip duration check for discontinuous fragments
2016-10-18 jean lavf/mov: support gopro hero moments udta tag
2016-10-19 sven.c.dack avfilter/vf_scale_npp: select cubic and lanczos as alternative where super-sampling is not supported
(...)
Roll FFmpeg DEPS for M56
Includes FFmpeg support for Opus audio decode, though disabled in
FFmpegAudioDecoder until OpusAudioDecoder is removed later.
Updates Chromium parsing and expectations of updated FFmpegUTCDate
format (it changed from YYYY-MM-DD HH:MM:SS to
YYYY-MM-DDTHH:MM:SS.xxxxxxZ) used by FFmpegDemuxer's
ExtractTimelineOffset() helper and related tests. Now uses
much more lenient base::Time::FromUTCString() for this conversion.
Includes changes to not use deprecated AVStream.codec:
ScopedPtrAVFreeContext is used instead of ~FFmpegGlue() iterating over
closing of deprecated AVStream.codec in each stream.
FFmpegDemuxer, FFmpegDemuxerStream, and various ffmpeg_common updates
to work using conversion from AVStream.codecpar. Note that
AVCodecParameters does not include coded_width or coded_height
information, and AVStream.parser's coded size fields are not
populated by av_find_stream_info(). We just use the width and
height as hints of coded size in AVStreamToVideoDecoderConfig().
AVStreamToVideoDecoderConfig() is also updated to allow 1 less
invalid extradata case (see bug 517163).
FFmpeg*BitStreamConverter, callers and related tests changed to use
AVCodecParameters instead of AVCodecContext.
AudioFileReader, MediaFileChecker, AudioVideoMetadataExtractor updated
to work using conversion from AVStream.codecpar. Note that
AVCodecContext built from an AVCodecParameters does not have its
time_base populated until after avcodec_open2(), so
AudioFileReader::SeekForTesting() uses AVStream.time_base instead.
FakeMediaSource changed to use AVStreamToAVCodecContext helper intead
of deprecated AVStream.codec, and to use AVFrame.pts instead of
deprecated AVFrame.pkt_pts.
Updates regressed FFmpeg regression tests:
Cr222754, CR234630b no longer get PIPELINE_OK when starting the
pipeline. Test expectations updated.
BUG=591845,517163,264459,93887,590401,604451,590440,661350
Review-Url: https://codereview.chromium.org/2497603003
Cr-Commit-Position: refs/heads/master@{#433075}
(cherry picked from commit cfd33cef4f1a51ba612d28504c6f76e1dfe588a6)
Review URL: https://codereview.chromium.org/2534193003 .
Cr-Commit-Position: refs/branch-heads/2924@{#172}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Revert of Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation(). (patchset #1 id:1 of https://codereview.chromium.org/2535243002/ )
Reason for revert:
Failing tests on windows bots. I suspect the tests are actually dependent on environment settings which is not good and will require time to investigate.
Original issue's description:
> Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation().
>
> Forces an animation duration of 0 for all ink drop animations if
> ShouldRenderRichAnimations() returns false.
>
> BUG=658384
>
> Review-Url: https://codereview.chromium.org/2520353004
> Cr-Commit-Position: refs/heads/master@{#434301}
> (cherry picked from commit 03ac98e06185f954738f1d3ec98c387b412c53f3)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/146e4c96e3e45a0edb5d04f6b76d44e86cdb24f7
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=658384
Review-Url: https://codereview.chromium.org/2543443002
Cr-Commit-Position: refs/branch-heads/2924@{#171}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Instant Apps: Allow custom tab redirects to Instant Apps.
Usually custom tabs force-load URLs or redirects to URLs that can be
handled by apps inside custom tabs. For instant-apps enabled clients
override the default behaviour and launch the instant app, if possible.
BUG=659301
Review-Url: https://codereview.chromium.org/2532223002
Cr-Commit-Position: refs/heads/master@{#434714}
(cherry picked from commit 0d4f64f504986b0ef87efd1275935c30a9416512)
Review URL: https://codereview.chromium.org/2532233005 .
Cr-Commit-Position: refs/branch-heads/2924@{#170}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment
* Adding a test and fixing the issue
BUG=669126
Review-Url: https://codereview.chromium.org/2535023002
Cr-Commit-Position: refs/heads/master@{#434811}
(cherry picked from commit 1acc2c4283c64636eb2a120f3e1e51267f74a427)
Review URL: https://codereview.chromium.org/2537763003 .
Cr-Commit-Position: refs/branch-heads/2924@{#169}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix compile issue caused by https://codereview.chromium.org/2533273003
TabTestUtils#getTabObservers is added post branch cut.
BUG=669169
Review URL: https://codereview.chromium.org/2538863002 .
Cr-Commit-Position: refs/branch-heads/2924@{#168}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge M56: "Remove unnecessary lock on setClient()."
The lock is unnecessary because the operation is a no-op
when client is unchanged (the vast majority of cases).
BUG=615589,647498
TEST=none
Review-Url: https://codereview.chromium.org/2527813002
Cr-Commit-Position: refs/heads/master@{#434380}
(cherry picked from commit 8be2e3fd36fb909ba695c0bd84ef9f97d3855ac3)
Review URL: https://codereview.chromium.org/2539773003 .
Cr-Commit-Position: refs/branch-heads/2924@{#167}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix initial USB enumeration on Linux to return all devices.
This patch fixes an issue where the first enumeration of USB devices on
Linux would only return a single device and observers would not be
notified of additional devices. This was because the logic to determine
if enumeration callbacks should be called was checking only that all
previously seen devices (of which there was only one at that point) were
ready and not that the sysfs tree had been completely walked.
BUG=662486
Review-Url: https://codereview.chromium.org/2523403002
Cr-Commit-Position: refs/heads/master@{#434718}
(cherry picked from commit 5c30282c70ec5f7f92129589fbbc84fef5738454)
Review URL: https://codereview.chromium.org/2534213002 .
Cr-Commit-Position: refs/branch-heads/2924@{#166}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Safely unpack referrer extras.
If a sender encodes the wrong type for referrer extra, don't crash.
BUG=666510
Review-Url: https://codereview.chromium.org/2520473002
Cr-Commit-Position: refs/heads/master@{#433261}
(cherry picked from commit 6f0355f2f00e3a4fd8d3e6e145ba3148fa412697)
Review URL: https://codereview.chromium.org/2539913002 .
Cr-Commit-Position: refs/branch-heads/2924@{#165}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Clean up WebVR RequestPresent and make callback asynchronous.
BUG=665006
Review-Url: https://codereview.chromium.org/2510873003
Cr-Commit-Position: refs/heads/master@{#433063}
(cherry picked from commit f97e23678abe358ec7c7241fe5511708be863625)
Review URL: https://codereview.chromium.org/2536063003 .
Cr-Commit-Position: refs/branch-heads/2924@{#164}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
DevTools: pick resource with certificate when retrieving cert data.
BUG=668072
NOTRY=true
Review-Url: https://codereview.chromium.org/2540493002
Cr-Commit-Position: refs/heads/master@{#434792}
(cherry picked from commit 922fbf5561c60b6d2239892f73eddcc3a0676aa7)
Review URL: https://codereview.chromium.org/2537853002 .
Cr-Commit-Position: refs/branch-heads/2924@{#163}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Make DnsSocketPool copy RandIntCallback
DnsSocketPool is created by DnsClient, and passed a reference to the
RandIntCallback in DnsClient. It is then stored in DnsSession, which is
ref-counted (so running transactions can continue while DnsSession is
recreated on config changes).
Unfortunately, if the DnsClient itself is destroyed, the DnsSession
hangs around, holding on to the DnsSocketPool, which is holding on to a
reference to the RandIntCallback in the destroyed DnsClient.
Fix this by copying the RandIntCallback into the DnsSocketPool when it
is constructed.
(Also, rearrange destructor to satisfy the linter.)
BUG=664457
Review-Url: https://codereview.chromium.org/2533753003
Cr-Commit-Position: refs/heads/master@{#434752}
(cherry picked from commit 2dd66098349196a1048403810c0faadf05072387)
Review URL: https://codereview.chromium.org/2532233004 .
Cr-Commit-Position: refs/branch-heads/2924@{#162}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Update Cast and VPN to follow MD layout
Implemented the correct layout for both Cast and VPN default rows
by following MD specs of system menu, which is done by making use
of TriView class.
TEST=MANUAL
BUG=666522, 666507
Review-Url: https://codereview.chromium.org/2512883002
Cr-Commit-Position: refs/heads/master@{#434419}
(cherry picked from commit a58f98c5be6b86fba82983a7a4f30a318d4524ec)
Review URL: https://codereview.chromium.org/2537203002 .
Cr-Commit-Position: refs/branch-heads/2924@{#161}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[CCT-Reparenting] Remove tab observer when the tab is removed from model
In tab reparenting, we never close but only remove the tab from the
model. During this process, both tab observer and also the metrics
observer was still kept, which leaked over some custom tab features into
the tab even after it was reparented. This removes the observers and
fixes the related issues.
TEST=CustomTabActivityTest#testTabReparentingBasic
BUG=669169
Review URL: https://codereview.chromium.org/2533273003 .
Cr-Commit-Position: refs/branch-heads/2924@{#160}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix an issue for blimp_support_strings.grd translation.
The translation script needs the prefix of xtb files to be the same as
the grd files.
This CL changed the translation file declaration in the grd file and
renamed all the xtb files to have the same prefix as the grd file.
BUG=665084
Review-Url: https://codereview.chromium.org/2524613003
Cr-Commit-Position: refs/heads/master@{#433918}
(cherry picked from commit 3e9d98ff9249bf9d16fecda9af4ce33cc841819d)
Review URL: https://codereview.chromium.org/2539873002 .
Cr-Commit-Position: refs/branch-heads/2924@{#159}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Media Controls: don't "cut" controls if fully hidden.
A media element might be outside of the page and can't be accessed and
for some reasons would have the controls enabled. Instead of having a
DCHECK, we should early return and use the default value.
BUG=664097
[email protected]
Review-Url: https://codereview.chromium.org/2499013003
Cr-Commit-Position: refs/heads/master@{#433219}
(cherry picked from commit 467481c23e2c416c34e5d4a34766d59a5aeefcf2)
Review URL: https://codereview.chromium.org/2534183003 .
Cr-Commit-Position: refs/branch-heads/2924@{#158}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Use correct fonts and add ripples to palette tray help/settings icon.
BUG=630464
Review-Url: https://codereview.chromium.org/2502153002
Cr-Commit-Position: refs/heads/master@{#434701}
(cherry picked from commit 07ede9c168f25c7eccfefeb76e703139d28c249f)
Review URL: https://codereview.chromium.org/2529393004 .
Cr-Commit-Position: refs/branch-heads/2924@{#157}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Avoid @import loops in the css scanner
Loops from @imports was causing the css scanner to stack overflow. Avoid
this case by ignoring (i.e. not scanning) resources that are already
loaded.
BUG=667753
Review-Url: https://codereview.chromium.org/2533633003
Cr-Commit-Position: refs/heads/master@{#434588}
(cherry picked from commit 18ff439bfb4b04ba5b3323cf525ed8b6c169933b)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2540493004
Cr-Commit-Position: refs/branch-heads/2924@{#156}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Kill vestigial transfer requests
When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.
However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.
This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.
Browser test written by [email protected]
BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2541543002
Cr-Commit-Position: refs/branch-heads/2924@{#155}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M56] Revert "Enable Initialization of the Task Scheduler by Default in the Browser Process"
This reverts commit 35980e3860cd6bb4241e9b4a6213048dcd6920e4 on M56 branch.
It unintentionally barely made the M56 cut and is useless without its follow-up CLs.
BUG=662053
[email protected]
Review URL: https://codereview.chromium.org/2521653002 .
Cr-Commit-Position: refs/branch-heads/2924@{#154}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation().
Forces an animation duration of 0 for all ink drop animations if
ShouldRenderRichAnimations() returns false.
BUG=658384
Review-Url: https://codereview.chromium.org/2520353004
Cr-Commit-Position: refs/heads/master@{#434301}
(cherry picked from commit 03ac98e06185f954738f1d3ec98c387b412c53f3)
Review URL: https://codereview.chromium.org/2535243002 .
Cr-Commit-Position: refs/branch-heads/2924@{#153}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Use the new statics interface to get APM stats from WebRTC
This also includes the new residual echo likelihood stat.
BUG=chromium:668632,webrtc:6525
Review-Url: https://codereview.chromium.org/2527193002
Cr-Commit-Position: refs/heads/master@{#434493}
(cherry picked from commit b5bc4a4e2967f50790fb378c14d1af668b350448)
Review URL: https://codereview.chromium.org/2540703002 .
Cr-Commit-Position: refs/branch-heads/2924@{#152}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Pull 'worker-src' back behind the experimental flag.
Good discussion at https://github.com/w3c/webappsec-csp/issues/146
suggests that we might want to modify `worker-src` before shipping it.
So let's work that out first.
BUG=666664
Review-Url: https://codereview.chromium.org/2503213005
Cr-Commit-Position: refs/heads/master@{#433152}
(cherry picked from commit 8071e0fb15f256d446f5483f4e7457d842a16800)
Review URL: https://codereview.chromium.org/2541443003 .
Cr-Commit-Position: refs/branch-heads/2924@{#151}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M56] [Autofill] Add a content_renderer manifest overlay for android_webview.
This CL creates a content_renderer service manifest overly for android_webview
to enable autofill mojo interfaces to be accessed well from content_browser
service.
BUG=662040
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2523193002
Cr-Commit-Position: refs/heads/master@{#434722}
(cherry picked from commit 9540b28d2181dc7d9cd86c3b7999bf5f4a23dc1f)
Review URL: https://codereview.chromium.org/2539673002 .
Cr-Commit-Position: refs/branch-heads/2924@{#150}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M56] [Autofill]Enable mojo AutofillDriver for android_webview.
BUG=662040
[email protected]
Review-Url: https://codereview.chromium.org/2491103003
Cr-Commit-Position: refs/heads/master@{#433418}
(cherry picked from commit e404109db1d011479ea0fee59c5d415f44d73b22)
Review URL: https://codereview.chromium.org/2538683002 .
Cr-Commit-Position: refs/branch-heads/2924@{#149}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.10
Cr-Commit-Position: refs/branch-heads/2924@{#148}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge "SELECT element: Commit a provisional OPTION selection on blur." to M56
PopupMenuImpl::hide(), which is called on blur, should have same behavior as
PopupMenuImpl::closePopup(), which is called on canceling a popup.
Also, this CL removes hidePopup() call on 'disabled' attribute change because
enabling 'disabled' attribute will remove the focus, and move blur event handling
from menuListDefaultEventHandler() to dispatchBlurEvent() because
menuListDefaultEventHandler() isn't called if the element is disabled.
BUG=659585
Review-Url: https://codereview.chromium.org/2522383002
Cr-Commit-Position: refs/heads/master@{#434395}
(cherry picked from commit b9ec42c0abbf77c9228f0d97ce261fb16b356094)
Review URL: https://codereview.chromium.org/2537573003 .
Cr-Commit-Position: refs/branch-heads/2924@{#147}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Update text layout in system menu.
Removes the vertical padding between multi label rows and moves the date
text in the system info row 4 dp to the right.
BUG=668333, 667944
Review-Url: https://codereview.chromium.org/2531713002
Cr-Commit-Position: refs/heads/master@{#434416}
(cherry picked from commit 445aa4a62b3f74e3276bfd83bceaf9c4699a734f)
Review URL: https://codereview.chromium.org/2530413004 .
Cr-Commit-Position: refs/branch-heads/2924@{#146}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Made the ink drop blue for system menu buttons with blue icons.
This fixes a regression caused by
https://codereview.chromium.org/2501693005/.
A small number of system menu buttons have blue icons and the ink drop
color should match this.
BUG=668292
Review-Url: https://codereview.chromium.org/2528853002
Cr-Commit-Position: refs/heads/master@{#434405}
(cherry picked from commit 2be8bbde136092f9565f11002fc65828143895af)
Review URL: https://codereview.chromium.org/2536963002 .
Cr-Commit-Position: refs/branch-heads/2924@{#145}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Hide Launcher app search box when empty
BUG=661380
TEST=Open launcher, type a search that returns no app results. The
horizontal box that usually contains app results should be hidden.
Review-Url: https://codereview.chromium.org/2473033002
Cr-Commit-Position: refs/heads/master@{#433686}
(cherry picked from commit 32247f5271fd583a683bc8dc2e4c07ce3cf72b85)
Review URL: https://codereview.chromium.org/2536053002 .
Cr-Commit-Position: refs/branch-heads/2924@{#144}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix separator position in status tray area in RTL system
In RTL mode, the separator between status tray and next item is
missing and an extra separator is shown at the end. This Cl fixes
separator positions in RTL system.
TEST=Manual
- Checked separator position in system tray area in RTL system
while the shelf is horizontally and vertically aligned.
- Check if separator satisfies the MD spec by measuring its
size using GIMP.
BUG=665043
Review-Url: https://codereview.chromium.org/2508363002
Cr-Commit-Position: refs/heads/master@{#434363}
(cherry picked from commit 571de9f774ee1cb11d78cc04f8c51c5805e5d429)
Review URL: https://codereview.chromium.org/2539543003 .
Cr-Commit-Position: refs/branch-heads/2924@{#143}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Changes font weight and color for sub-section header rows
This CL uses TrayPopupItemStyle to set up fonts and colors on
section header rows in Network and VPN detailed pages in system menu.
BUG=663451
TEST=Manual visual inspection
Review-Url: https://codereview.chromium.org/2527783003
Cr-Commit-Position: refs/heads/master@{#434334}
(cherry picked from commit 772863e3a0ce451e26400654797c3ef517f0c58b)
Review URL: https://codereview.chromium.org/2539633002 .
Cr-Commit-Position: refs/branch-heads/2924@{#142}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Fix system menu buttons to not show an ink drop when disabled.
The InkDropGestureHandler was not respecting the host views enabled flag and
thus was triggering ink drop animations on disabled buttons. Furthermore many
system menu buttons were being disabled via
CustomButton::SetState(STATE_DISABLED) which is a Button specific property and
is not visible to the InkDropGestureHandler.
This CL fixes the InkDropGestureHandler to respect View::enabled_ and updates
many system menu buttons to use View::SetEnabeled(false) instead of
CustomButton::SetState(STATE_DISABLED).
TEST=views_unittests --gtest_filter=InkDropHostViewTest.GestureEventsDontTriggerInkDropsWhenHostIsDisabled
BUG=668240
Review-Url: https://codereview.chromium.org/2530603002
Cr-Commit-Position: refs/heads/master@{#434333}
(cherry picked from commit b1d158120453d93836e7f13d309329aeb20a1d85)
Review URL: https://codereview.chromium.org/2539613002 .
Cr-Commit-Position: refs/branch-heads/2924@{#141}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
cc: Force update tile priorities for pending tree tiling set on commit.
Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.
|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.
BUG=664007
[email protected]
TEST=unittest + manual testing on samus
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2529533002
Cr-Commit-Position: refs/heads/master@{#434236}
(cherry picked from commit 53fabb1f55e8db09a8bd53ca7af11c2c96667af3)
Review URL: https://codereview.chromium.org/2538593002 .
Cr-Commit-Position: refs/branch-heads/2924@{#140}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add round rect mask to overflow button's ripple
BUG=667889
TEST=manual
Review-Url: https://codereview.chromium.org/2524183002
Cr-Commit-Position: refs/heads/master@{#434305}
(cherry picked from commit 6cc1f1f6a057f9870c82e8410169df35a6e60176)
Review URL: https://codereview.chromium.org/2538583002 .
Cr-Commit-Position: refs/branch-heads/2924@{#139}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Show system menu when user taps on the time in status tray
Tapping anywhere on the status tray should bring up system menu. That
was not the case for the part that shows time.
BUG=666453
TEST=manual
Review-Url: https://codereview.chromium.org/2530723002
Cr-Commit-Position: refs/heads/master@{#434304}
(cherry picked from commit 26cbf70015b7d26fcd0ce0dccea8f6d1e4966e97)
Review URL: https://codereview.chromium.org/2533113002 .
Cr-Commit-Position: refs/branch-heads/2924@{#138}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge to M56: Report redirect UMA in offline interceptor
BUG=666963
Review-Url: https://codereview.chromium.org/2507293006
Cr-Commit-Position: refs/heads/master@{#434029}
(cherry picked from commit 48ea10d8835e13336cf03c243b938bcb133dba49)
Review URL: https://codereview.chromium.org/2521393003 .
Cr-Commit-Position: refs/branch-heads/2924@{#137}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Adds Wi-Fi network status indicators in system menu
BUG=663129
Test=Connect to a Wi-Fi network.
Verify that connected network has "Connected" indicator.
Verify that connected network appears at the top of the list.
Review-Url: https://codereview.chromium.org/2517953006
Cr-Commit-Position: refs/heads/master@{#434283}
(cherry picked from commit bd890d24dd4bb15a15e891d4fdb273dc330d7f2a)
Review URL: https://codereview.chromium.org/2532053003 .
Cr-Commit-Position: refs/branch-heads/2924@{#136}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Update Caps Lock to changes text theme based on Native Theme
The Caps Lock now updates its theme based on the UI theme,
not the system native theme.
BUG=663207
Review-Url: https://codereview.chromium.org/2522803003
Cr-Commit-Position: refs/heads/master@{#434181}
(cherry picked from commit 4d14216654eb9a825efbb335f232af55b5c84e5a)
Review URL: https://codereview.chromium.org/2531163003 .
Cr-Commit-Position: refs/branch-heads/2924@{#135}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add virtual keyboard item into opt-in IME menu.
The 'Smart deploy toggle' is always hidden in opt-in IME menu. We should show/hide it based on the vr and devices state.
Make ImeMenuTray listens on the virtual keyboard state to show the toggle.
Currently the ImeMenuBubble doesn't support update UI. So if there's state change (which leads to UI change) of the VK, just hide the bubble.
BUG=668013
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2474843002
Cr-Commit-Position: refs/heads/master@{#434127}
(cherry picked from commit 1fb9e7720d5a4ddaef6ce257f4d252a831bea688)
Review URL: https://codereview.chromium.org/2536003002 .
Cr-Commit-Position: refs/branch-heads/2924@{#134}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Set the right ChromeVox spoken feedback for IME row.
As described in the bug, fixed the broken ChromeVox spoken feedback for IME row:
Output "<IME name>", followed by "check box", followed by either "checked" or "not checked" depending on the checked state of the row.
BUG=666526
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2518863002
Cr-Commit-Position: refs/heads/master@{#434102}
(cherry picked from commit ac9efef6c1818fcfb0ea5fdce3015afdd19787ed)
Review URL: https://codereview.chromium.org/2538553002 .
Cr-Commit-Position: refs/branch-heads/2924@{#133}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Restore original opacity when exiting overview
BUG=667526
[email protected]
TEST=Updated WindowSelectorTest.BasicTextFiltering
Review-Url: https://codereview.chromium.org/2525753002
Cr-Commit-Position: refs/heads/master@{#434025}
(cherry picked from commit 355b36934b8f321a7970679f9a13fa8768a1c384)
Review URL: https://codereview.chromium.org/2532273002 .
Cr-Commit-Position: refs/branch-heads/2924@{#132}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Android] Fix timing issue in enabling/disabling printing.
There are a couple timing issues in the previous
implementation of the code that enables/disables the print
activity that is accessible via share.
1.) Multiple calls to enablePrintShareOption could result
in the second call having the callback run immediately
without the component first being enabled (since it
would have been triggered in an AsyncTask in the first
call).
2.) Back to back enable/disable calls could result in
unpredictable execution ordering as they run their
tasks on the thread pool instead of in serial. Because
the initial UI is only shown after the first callback is
run, this would require a show, followed by a hide, followed
by a show where the task enqueued by the hide is run after
the enabling call in the second show.
To work around this (and due to the expected usage pattern of
this class), just wait for the task to be run in either of these
states to avoid this being possible. It would also be possible
to use the SERIAL executor, but that might end up slowing down
the default share flow where we don't expect this interleaving
issue.
BUG=649453,664486
Review URL: https://codereview.chromium.org/2535803003 .
Review-Url: https://codereview.chromium.org/2523873003
Cr-Original-Commit-Position: refs/heads/master@{#434676}
Cr-Commit-Position: refs/branch-heads/2924@{#131}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Linux Aura: Fix overlay shadows on notifications
>Linux Aura got support for translucent windows in CL:
>https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87
>
>Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that
>fade in or out, but that don't actually have an alpha mask. This was
>to support a limitation on MS Windows where windows must be
>translucent to fade.
>
>However, most Linux window managers only draw shadows on opaque
>windows: that is, windows that do not have an alpha channel. Windows
>that fade in or out may still have shadows since opacity is set as a
>property of the toplevel window.
>
>Therefore, the solution is to use INFER_OPACITY for fading widgets so
>it will work across platforms. TRANSLUCENT_WINDOW should only be used
>on widgets that have alpha masks.
>
>BUG=640170
>
>[email protected]
>
>patch from issue 2398203002 at patchset 40001
>(http://crrev.com/2398203002#ps40001)
>
NOPRESUBMIT=true
NOTRY=true
BUG=640170
[email protected]
Review-Url: https://codereview.chromium.org/2540463002
Cr-Commit-Position: refs/branch-heads/2924@{#130}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Remove merge artifact from 56f7c1e4c916655dbab30a49c1cea63b89d3f248.
In 56f7c1e4c916655dbab30a49c1cea63b89d3f248 I incorrectly added a test
exception from master (not my merged patch). Removing this.
TBR=schenney
BUG=666147
TEST=None
Review URL: https://codereview.chromium.org/2535073002 .
Cr-Commit-Position: refs/branch-heads/2924@{#129}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Reset settings button when update the list view.
We need to reset the settings button object when updating the IME detailed view, otherwise there may has memory leak, and checking if(settings_button_) could be true but the IME view is updated without drawing the settings button.
BUG=667105
TEST=Verified on Clapper.
Review-Url: https://codereview.chromium.org/2521443002
Cr-Commit-Position: refs/heads/master@{#434083}
(cherry picked from commit 4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821)
Review URL: https://codereview.chromium.org/2533793004 .
Cr-Commit-Position: refs/branch-heads/2924@{#128}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M56] Consolidate how ImageDocument sets image styling
* Consolidate how the image sets the cursor styling inside of
updateImageStyle(), which now checks for whether the cursor
or checkerboard size has changed during styling updates.
* Fix how the magnifying glass cursor is initialized on desktop
versions of the page.
BUG=664782
[email protected]
Review URL: https://codereview.chromium.org/2535063002 .
Original-Review-Url: https://codereview.chromium.org/2523553002
Original-Cr-Commit-Position: refs/heads/master@{#434020}
Cr-Commit-Position: refs/branch-heads/2924@{#127}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix for DragEnd event being sent with the wrong coordinates.
This event was accidentally sent with (x, x) instead of (x, y). This
patch corrects this.
BUG=667963
TBR=paulmeyer, lukasza, nick
Review-Url: https://codereview.chromium.org/2530663002
Cr-Commit-Position: refs/heads/master@{#434295}
(cherry picked from commit 94c098de407049a62aebef939cb7ce93200a5139)
Review URL: https://codereview.chromium.org/2533953002 .
Cr-Commit-Position: refs/branch-heads/2924@{#126}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge M56: "Fix MediaServerCrashListener JNI registration"
Commit f524383bbd03acfba4ffe18b7e77a66c46228dcd introduced the
MediaServerCrashListener, but did not properly call the method to
register the native methods with JNI.
This change properly registers the native methods.
BUG=667149
Review-Url: https://codereview.chromium.org/2527553002
Cr-Commit-Position: refs/heads/master@{#434044}
(cherry picked from commit 89f2b9bf3f9fece35f1e8c01554db10c55374970)
Review URL: https://codereview.chromium.org/2536623004 .
Cr-Commit-Position: refs/branch-heads/2924@{#125}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Set alpha on inactive user row without using a layer.
BUG=667205
Review-Url: https://codereview.chromium.org/2519243002
Cr-Commit-Position: refs/heads/master@{#433873}
(cherry picked from commit bc96fccd56aa58d9c45772e274d8ade141e415d5)
Review URL: https://codereview.chromium.org/2538523002 .
Cr-Commit-Position: refs/branch-heads/2924@{#124}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Implemented correct layout for system menu's system info row.
The separater in the system info row is will now align with the tile
row separators.
BUG=662975
TEST=ash_unittests ---gtest_filter=SystemInfoDefaultViewTest.*
Review-Url: https://codereview.chromium.org/2514403002
Cr-Commit-Position: refs/heads/master@{#433699}
(cherry picked from commit d7ca2fd0c335223efbcf69a952f14f2a06e242dd)
Review URL: https://codereview.chromium.org/2532953003 .
Cr-Commit-Position: refs/branch-heads/2924@{#123}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix LabelButton size calculation for non-default fonts.
BUG=666479
Review-Url: https://codereview.chromium.org/2514163002
Cr-Commit-Position: refs/heads/master@{#433670}
(cherry picked from commit 27ec4f8bcae25e024776f5f97390f768b5b47f49)
Review URL: https://codereview.chromium.org/2539523002 .
Cr-Commit-Position: refs/branch-heads/2924@{#122}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix event targeting for overlay scrollbar thumbs (in native UI).
Views with layers are targeted based on their layer's transform rather
than their local coordinates. See View::GetTransform(). Hence the thumb
did not receive events until the translated area was hovered. To resolve
this, make the thumb 11 + 4 = 15 dp wide all the time, and just slide
back and forth so that 4dp is off the left or 4dp is off the right of
the 11dp track, making sure the thumb always covers the whole track
(it won't extend beyond visually or in terms of event handling because
of the track's layer clipping).
BUG=666798
Review-Url: https://codereview.chromium.org/2520433003
Cr-Commit-Position: refs/heads/master@{#433664}
(cherry picked from commit 03722d39ae28885ebd6de91429325776c77da2a7)
Review URL: https://codereview.chromium.org/2535943002 .
Cr-Commit-Position: refs/branch-heads/2924@{#121}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Some PannerOptions dictionary members should be doubles
Some of the dictionary members were incorrectly declared to be floats
when they should have been doubles. The corresponding attributes
themselves are doubles so the members should match.
See https://webaudio.github.io/web-audio-api/#panneroptions
BUG=666471
TEST=constructor/panner.html updated
Review-Url: https://codereview.chromium.org/2508733006
Cr-Commit-Position: refs/heads/master@{#433217}
(cherry picked from commit a4eae706d4f07f9d297ce0f8d8cbc2bf07618598)
Review URL: https://codereview.chromium.org/2536603003 .
Cr-Commit-Position: refs/branch-heads/2924@{#120}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[MediaRouter, Android] Check request before use
Tentative null check crasher fix.
BUG=664384
TEST=None
[email protected]
Review-Url: https://codereview.chromium.org/2526113002
Cr-Commit-Position: refs/heads/master@{#434529}
(cherry picked from commit 6e15e9d533fe44b26beca64dce6d90d8962c65db)
Review URL: https://codereview.chromium.org/2533913002 .
Cr-Commit-Position: refs/branch-heads/2924@{#119}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
tweak the focus rectangle of TrayBackgroundView objects
BUG=640678
TEST=Manually tested on lock screen and signin screen, also after signin.
Review-Url: https://codereview.chromium.org/2513823002
Cr-Commit-Position: refs/heads/master@{#433662}
(cherry picked from commit dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc)
Review URL: https://codereview.chromium.org/2533903002 .
Cr-Commit-Position: refs/branch-heads/2924@{#118}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Show "Connected" Bluetooth icon on system menu when there is at least one connected device.
In the 1st layer of MD system menu, we show a separate icon for Bluetooth menu
when Bluetooth is enabled and there is at least one connected device.
BUG=652665
TEST=manually confirmed.
Review-Url: https://codereview.chromium.org/2512923002
Cr-Commit-Position: refs/heads/master@{#433483}
(cherry picked from commit 607c0c0072fbb639b0d94fed81a7f9e28559e520)
Review URL: https://codereview.chromium.org/2535033002 .
Cr-Commit-Position: refs/branch-heads/2924@{#117}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix renderer crashes due to non-existing RenderFrameImpl or WebFrameWidget during Navigations (merge to M56)
When navigating the main frame, the RenderViewImpl lingers around with no WebFrameWidget.
This yields a WebViewImpl in a call to RenderWidget::GetWebWidget().
When user interactions leads to an IME IPC for FirstRectForCharacterRange, the IPC migth arrive during the
navigation and lead to an invalid cast in TextInputClientObserver::GetFocusedFrame().
This CL will avoid those casts by explicitly verifying that the WebWidget returned from GetWebWidget() is a WebFrameWidget.
Also, the IPC handling in TextInputClientObserver is modified such that it now considers the possibilities
of nullptr outputs from GetFocusedFrame() and GetWebFrameWidget().
BUG=664890
Review-Url: https://codereview.chromium.org/2526563004
Cr-Commit-Position: refs/heads/master@{#434302}
(cherry picked from commit 95df18c257f410cff287f0b402dd50b3014c7784)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2533003002
Cr-Commit-Position: refs/branch-heads/2924@{#116}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Ensure NetworkHandler is initialized in WifiDataProviderChromeOs
BUG=661304
Review-Url: https://codereview.chromium.org/2515363003
Cr-Commit-Position: refs/heads/master@{#433943}
(cherry picked from commit 9ae7d75c5f2a4239364e79c0fcbbd64c5795a72f)
Review URL: https://codereview.chromium.org/2531403002 .
Cr-Commit-Position: refs/branch-heads/2924@{#115}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge M-56] Mark PaymentDetails.error as experimental
There has not been a request to implement and ship this feature, so it
should be marked as experimental until such request has been sent out
and consequently approved.
BUG=648240
Review-Url: https://codereview.chromium.org/2530713002
Cr-Commit-Position: refs/heads/master@{#434664}
(cherry picked from commit 1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87)
Review URL: https://codereview.chromium.org/2534993002 .
Cr-Commit-Position: refs/branch-heads/2924@{#114}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Notifications] Make image background white like notification background
Suggested by UI reviewers, and looks a little cleaner.
BUG=668087
Review-Url: https://codereview.chromium.org/2522083003
Cr-Commit-Position: refs/heads/master@{#434225}
(cherry picked from commit 1da7201bea9f6d2cd10619638fca3f0526778d73)
Review URL: https://codereview.chromium.org/2535873002 .
Cr-Commit-Position: refs/branch-heads/2924@{#113}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge M-56] Mark IFrame support in PaymentRequest experimental
IFrame support in PaymentRequest may be better served through
FeaturePolicy. This patch marks the current IFrame support
experimental, so it's disabled by default, but developers still can
experiment with it. Once the FeaturePolicy question is resolved, the
current implementation of the IFrame support will be either shipped or
replaced by FeaturePolicy.
BUG=652148
Review-Url: https://codereview.chromium.org/2525813003
Cr-Commit-Position: refs/heads/master@{#434257}
(cherry picked from commit d2c4379ec3783f7f70b14f6fda92f13cd496bf66)
Review URL: https://codereview.chromium.org/2529423002 .
Cr-Commit-Position: refs/branch-heads/2924@{#112}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Do not crash in SpdyHttpStream::GetTokenBindingSignature() if SpdySession is already destroyed.
BUG=667683
Review-Url: https://codereview.chromium.org/2525723003
Cr-Commit-Position: refs/heads/master@{#434213}
(cherry picked from commit 037eff137c8bc5e6685992f93b0f6721e8bbed7a)
Review URL: https://codereview.chromium.org/2534923002 .
Cr-Commit-Position: refs/branch-heads/2924@{#111}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix build on 2924 branch
3 Merges for crbug.com/633007 on M56 branch (2924) had a glich
that caused compile error.
This fixes the compilation error.
[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=633007, 668933
Review-Url: https://codereview.chromium.org/2533743002
Cr-Commit-Position: refs/branch-heads/2924@{#110}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully
GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
strings for particular IDs contain placeholders, and attempts to access the
vector of offsets corresponding to such placeholders. However, in some
situations (http://crbug.com/658902#c18) the localised string may be empty.
This led to an out-of-bounds access and crash on Android.
This CL is the smallest change to handle such situation gracefully -- it checks
the length of the vector with offsets and gives up accessing it if it is empty.
This avoids the crash but results in displaying a UI with empty strings.
Ideally, the UI would also be supressed on these occasions, but that is left
for follow-up CLs. The current situation is already an improvement (password
manager is still not very useful, but at least the browser has a chance to
continue).
The CL also removes the temporary logging put in for the crash investigation.
BUG=658902
Review-Url: https://codereview.chromium.org/2526283002
Cr-Commit-Position: refs/heads/master@{#434482}
(cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)
Review URL: https://codereview.chromium.org/2534793003 .
Cr-Commit-Position: refs/branch-heads/2924@{#109}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add a UseCounter for '>>>' combinator.
BUG=633007
[email protected] for histograms.xml
Review-Url: https://codereview.chromium.org/2517043002
Cr-Commit-Position: refs/heads/master@{#433484}
(cherry picked from commit ea3f73b7066df2f90e2ea56d280f6646760d4f35)
Review URL: https://codereview.chromium.org/2528313002 .
Cr-Commit-Position: refs/branch-heads/2924@{#108}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Matching part for >>> (shadow-piercing descendant combinator).
Parsing part is done in the previous dependent CL.
https://codereview.chromium.org/2500813003/
This CL implements matching '>>>' shadow-piercing descendant
combinator in static profile.
Note that the combinator only pierces through open shadow roots
and not V0 or closed shadow roots.
BUG=633007
Review-Url: https://codereview.chromium.org/2496123002
Cr-Commit-Position: refs/heads/master@{#433457}
(cherry picked from commit 04a4852c265670de8100ceee3e20215f4a56091f)
Review URL: https://codereview.chromium.org/2532813002 .
Cr-Commit-Position: refs/branch-heads/2924@{#107}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Parser support for >>> (shadow-piercing descendant) combinator.
'>>>' (shadow-piercing descendant) can only be parsed in
static profile. The parsing is guarded by a runtime enabled flag.
Matching part is done in the next CL:
https://codereview.chromium.org/2496123002/
BUG=633007
Review-Url: https://codereview.chromium.org/2500813003
Cr-Commit-Position: refs/heads/master@{#433133}
(cherry picked from commit 69635dc029d7ce77e7db12669a994295d5f93952)
Review URL: https://codereview.chromium.org/2528303002 .
Cr-Commit-Position: refs/branch-heads/2924@{#106}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
