Publish DEPS for Chromium 55.0.2883.35
Incrementing VERSION to 55.0.2883.35
Cr-Commit-Position: refs/branch-heads/2883@{#414}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Move Android.ContentDetectorActivated recording location
Record Android.ContentDetectorActivated in ContentViewClient.java
instead of render_view_impl.cc. When recording in RenderViewImpl,
the task runner needed to record user actions is null.
BUG=657852
[email protected]
Review URL: https://codereview.chromium.org/2471013002 .
Review-Url: https://codereview.chromium.org/2465363002
Cr-Original-Commit-Position: refs/heads/master@{#429067}
Cr-Commit-Position: refs/branch-heads/2883@{#413}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M-55] Increase spacing for payment request credit card and address editors
This CL also adds cards icon border and changes the cardEditor title.
BUG=657178, 657952
Review-Url: https://codereview.chromium.org/2450113003
Cr-Commit-Position: refs/heads/master@{#428247}
(cherry picked from commit 6d062f24e1ede7485051d12eea9909f24c453362)
Review URL: https://codereview.chromium.org/2463293005 .
Cr-Commit-Position: refs/branch-heads/2883@{#412}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M-55] Remove credit scan scanner experimental flag
BUG=640430
Review-Url: https://codereview.chromium.org/2452243002
Cr-Commit-Position: refs/heads/master@{#428761}
(cherry picked from commit ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9)
Review URL: https://codereview.chromium.org/2469953002 .
Cr-Commit-Position: refs/branch-heads/2883@{#411}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M-55] Float card scanner icon at the end of EditText instead of compound drawable
This gives better user experience since compound drawable do not support click event.
BUG=657178,640430
Review-Url: https://codereview.chromium.org/2434383002
Cr-Commit-Position: refs/heads/master@{#427222}
(cherry picked from commit c3da4b51497fca50ebed5e4adbec3f7ada68ceda)
Review URL: https://codereview.chromium.org/2474493002 .
Cr-Commit-Position: refs/branch-heads/2883@{#410}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fix printing triggered from in page actions.
Broken by:
https://codereview.chromium.org/2297193003
I had incorrectly assumed that all access to the PrintingController
was via the ChromeApplication, but PrintingContext accesses
PrintingControllerImpl directly.
This removes PrintingControllerFactory and the method from
ChromeApplication to have PrintingControllerImpl be the
only source.
BUG=659603
Review URL: https://codereview.chromium.org/2467843003 .
Cr-Commit-Position: refs/branch-heads/2883@{#409}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M-55] [Payments] Don't add expired cards in Payment Request.
BUG=658823
Review-Url: https://codereview.chromium.org/2451303002
Cr-Commit-Position: refs/heads/master@{#428164}
(cherry picked from commit 9517dee1565a1629116b9e30c43c75ba65d510cb)
Review URL: https://codereview.chromium.org/2469103002 .
Cr-Commit-Position: refs/branch-heads/2883@{#408}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Don't abort the MimeHandlerStreamManager stream if we receive a RenderProcessHostChanged notification for a null old host.
Merging to M55
This indicates that a subframe is being created. If we ignore the old_host here and set
the new host pointer in the MimeHandlerStreamManager::EmbedderObserver class, this causes
the stream to be aborted prematurely leading to embedded PDFs not loading.
This should fix bug 650985
BUG=650985
Review-Url: https://codereview.chromium.org/2418963002
Cr-Commit-Position: refs/heads/master@{#425498}
(cherry picked from commit b8cfa3b172b2741635247a8541e3251688aaa04f)
Review URL: https://codereview.chromium.org/2465223003 .
Cr-Commit-Position: refs/branch-heads/2883@{#407}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Offline pages] Fixing lint error by removing not used string
BUG=661051
[email protected]
Review-Url: https://codereview.chromium.org/2467943002
Cr-Commit-Position: refs/heads/master@{#429039}
(cherry picked from commit 916a3bc4e3ed4a81078c7e4439c8e763762bc5f5)
Review URL: https://codereview.chromium.org/2469653003 .
Cr-Commit-Position: refs/branch-heads/2883@{#406}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fixed track id remapping in MSE FrameProcessor
Previously FrameProcessor couldn't handle cases where audio and video
track ids were swapped between the previous and current init segment,
because we tried to do an in-place update, which is impossible to do
correctly when track ids have been swapped. Consider the case where
in the first init segment A=1,V=2 and in the second segment A=2,V=1.
In such case we can't simply move let's say track A from 1 to 2,
because track id 2 is occupied by V, and vice versa.
This CL implements a more advanced logic, that will record how track
ids have changed between segments and will then update all track buffer
mappings in FrameProcessor::UpdateTrackIds at once.
BUG=660247
Review-Url: https://codereview.chromium.org/2460763002
Cr-Commit-Position: refs/heads/master@{#428473}
(cherry picked from commit b9233a906062fd461503fca84fa2223ee315bfaf)
Review URL: https://codereview.chromium.org/2464153002 .
Cr-Commit-Position: refs/branch-heads/2883@{#405}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Improve updateOriginsEliding_ performance.
This CL is part of the effort to improve performance of the password manager
settings. In particular, this CL fixes layout thrashing in the
updateOriginsEliding_ code. Prior to this change the code was first reading
style information from the DOM and then changing it in a loop.
This change creates a canvas element that is not part of the DOM.
It then uses the canvas to do the text measurements, thus avoiding the
repainting of the DOM. In the end, it writes the final obtained string in the
DOM, and thus does not change the display of the saved passwords.
Reference: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/measureText
BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2439453005
Cr-Commit-Position: refs/heads/master@{#427028}
(cherry picked from commit 68f4faa15a37a66d07d374cd7df3dfd296ff957f)
Review URL: https://codereview.chromium.org/2468973003 .
Cr-Commit-Position: refs/branch-heads/2883@{#404}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fullscreen Notifications: Fix crash if delegate is NULL
Notification Delegates should never be NULL but it is not enforced with
a DCHECK, so of course there is a delegate that is null (for the ChromeOS
Battery notification). So fix the logic that never checks the delegate's
validity in FullscreenNotificationBlocker.
[email protected]
BUG=660889
TEST=have a fullscreen app window and drain the battery
below the warning level.
Review-Url: https://codereview.chromium.org/2459263004
Cr-Commit-Position: refs/heads/master@{#428825}
(cherry picked from commit b58f87810fac6a4d5ef606032a35ed8e8b179bd2)
Review URL: https://codereview.chromium.org/2463383002 .
Cr-Commit-Position: refs/branch-heads/2883@{#403}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Add a dummy entry with libsecret when initializing OSCrypt.
Under certain conditions, gnome libsecret methods that perform a lookup
in keyring may ignore a locked keyring and return empty results, instead
of unlocking said keyring. Store operations are unaffected by this quirk
(or bug, presumably).
With this change, we store a dummy entry during the initialisation of
OSCrypt. This ensures that the default keyring gets unlocked and is
available for future reads.
This solution is also applied to Password Manager, before performing
calls to secret_service_search_sync.
This solution should be temporary, until the underlying issue gets fixed
or there is an official workaround.
BUG=660005,631171
Review-Url: https://codereview.chromium.org/2461453002
Cr-Commit-Position: refs/heads/master@{#428378}
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2465083002
Cr-Commit-Position: refs/branch-heads/2883@{#402}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Unlock all libsecret items in Password Manager and OSCrypt
The various libsecret methods have different contracts w.r.t. unlocking
keyring items. Of the currently used methods, only secret_service_store
will trigger unlocking as necessary. As a result, operations fail in
various ways until someone performs the first store operation.
With the CL, the libsecret native backend of Password Manager is set to explicitly
request unlocking of items on every call. OSCrypt avoids using
secret_service_lookup, which apparently ignores locked items.
BUG=657828,631171
Review-Url: https://codereview.chromium.org/2441653002
Cr-Commit-Position: refs/heads/master@{#427067}
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2463263002
Cr-Commit-Position: refs/branch-heads/2883@{#401}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.34
Cr-Commit-Position: refs/branch-heads/2883@{#400}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert "Upgrade libsrtp to version 2.0"
This reverts commit 95ad82f20f781c2078837ad9e670087e5fb106de.
[email protected]
BUG=660985
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2464883004
Cr-Commit-Position: refs/branch-heads/2883@{#399}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Merge M55: Control DefaultPluginsSetting policy by variations.
BUG=658812
TEST=launch chrome on machine with a plugins enterprise policy with --enable-features=IgnoreDefaultPluginsSetting and verify HBD code gets used.
Review-Url: https://codereview.chromium.org/2442423002
Cr-Commit-Position: refs/heads/master@{#428176}
(cherry picked from commit 61a67fd2edebc58db48efde2f9d1846e648653a8)
Review URL: https://codereview.chromium.org/2469563002 .
Cr-Commit-Position: refs/branch-heads/2883@{#398}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Upgrade libsrtp to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.
Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63..71692eaab2a0
$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=625878
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://chromiumcodereview.appspot.com/2436913003
Cr-Commit-Position: refs/heads/master@{#426814}
(cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333)
Review-Url: https://codereview.chromium.org/2462213002
Cr-Commit-Position: refs/branch-heads/2883@{#397}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M55] sync compositor: Fix multiprocess software clipping
Apply the clip before the matrix, so that matrix is not applied to it.
Not entirely sure why recent clipping changes did not expose this.
BUG=660119
Review-Url: https://codereview.chromium.org/2462903002
Cr-Commit-Position: refs/heads/master@{#428700}
(cherry picked from commit 3a3725735f8f32c95b672537726037b9d0b9cf10)
Review URL: https://codereview.chromium.org/2463713004 .
Cr-Commit-Position: refs/branch-heads/2883@{#396}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Remove Phone Number data detection.
BUG=644489
Review-Url: https://codereview.chromium.org/2456533002
Cr-Commit-Position: refs/heads/master@{#427725}
(cherry picked from commit 330fef1531d57e4b77bdc0edf63e6bdf3218691e)
Review URL: https://codereview.chromium.org/2462213003 .
Cr-Commit-Position: refs/branch-heads/2883@{#395}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Make URLFetcherFileWriter::Finish() skip closing file when there is an error
This CL makes URLFetcherFileWriter::Finish() skip closing file when there is an
error. If there is an error, Finish() will delete the file after any pending
operation completes.
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
BUG=487732, 656692
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://chromiumcodereview.appspot.com/2425673006
Cr-Commit-Position: refs/heads/master@{#426540}
(cherry picked from commit ee63375d9c88e55c832cdf7f6181eb3ffc776695)
Review-Url: https://codereview.chromium.org/2467583002
Cr-Commit-Position: refs/branch-heads/2883@{#394}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M55][translate] Use the prod URL to download the TranslateRankerModel.
Switch the translate ranker model download URL from canary to prod.
BUG=646711
Review-Url: https://codereview.chromium.org/2420113002
Cr-Commit-Position: refs/heads/master@{#428044}
(cherry picked from commit 03fef0e34fba16c1bf49dd440d6de56ecf6e468f)
Review URL: https://codereview.chromium.org/2470493002 .
Cr-Commit-Position: refs/branch-heads/2883@{#393}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Increment/Decrement capturer count when starts/stops audio capturing.
BUG=656135
Review-Url: https://codereview.chromium.org/2460033003
Cr-Commit-Position: refs/heads/master@{#428576}
(cherry picked from commit c227f1bb6dc4e286df809a97abaef9bdef63c19e)
Review URL: https://codereview.chromium.org/2465013002 .
Cr-Commit-Position: refs/branch-heads/2883@{#392}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Delete download in Android DownloadManager when download is deleted from download home
This change adds a SharedPreference file to map download GUIDs to android download Ids.
When a download is removed from download home, also remove it from Android DM.
[email protected]
BUG=658829
Review-Url: https://codereview.chromium.org/2456593002
Cr-Commit-Position: refs/heads/master@{#428495}
(cherry picked from commit b318140c9474e8e133bf3a403e94e7569c9bd4cd)
Review URL: https://codereview.chromium.org/2466683002 .
Cr-Commit-Position: refs/branch-heads/2883@{#391}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
DevTools: [Workspace] show dirty asterisk in file tab title.
As we don't sync working copies between uiSourceCodes of persistent
binding (for now), we should get the dirty state of the original uiSourceCode
in the TabbedEditorContainer._titleForTab method.
BUG=660238
R=dgozman
Review-Url: https://codereview.chromium.org/2462493002
Cr-Commit-Position: refs/heads/master@{#428271}
(cherry picked from commit bfa81c19d0c430c2df363f6f9685031cddb21785)
Review URL: https://codereview.chromium.org/2466013002 .
Cr-Commit-Position: refs/branch-heads/2883@{#390}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Add extra information to investigate FileStream::Context::Close check failure
This CL adds additional information to aid the investigation of
FileStream::Context::Close check failure.
BUG=487732, 656692
[email protected]
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2422103005
Cr-Commit-Position: refs/heads/master@{#426067}
(cherry picked from commit cf470d52d8a5260a38accdc5335c86fa9afff879)
Review-Url: https://codereview.chromium.org/2467573002
Cr-Commit-Position: refs/branch-heads/2883@{#389}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
DevTools: [Persistence] tabs should not change order during reload
During page reload, the network UISourceCodes are removed and then
re-added. This results in bindings being removed and then re-added.
However, currently we're not doing a good job maintaining the selected
tab and the tab order - they're getting shuffled during this process.
This patch fixes the behavior so that the reload does not mess tabs
order.
BUG=660596
R=dgozman
Review-Url: https://codereview.chromium.org/2460513003
Cr-Commit-Position: refs/heads/master@{#428555}
(cherry picked from commit 1a31eac72f8252705bac3cee5823d0ec92d8d857)
Review URL: https://codereview.chromium.org/2462163002 .
Cr-Commit-Position: refs/branch-heads/2883@{#388}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Preserve the list of verified referenced files in SetPageState.
TBR=lukasza
BUG=620261
TEST=See bug comment 14 for repro steps.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2455883002
Cr-Commit-Position: refs/heads/master@{#428145}
(cherry picked from commit 2dabb5094ba149b751fc73c951f5cda076268b97)
Review URL: https://codereview.chromium.org/2466623002 .
Cr-Commit-Position: refs/branch-heads/2883@{#387}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fix NULL pointer dereference in FinishedAsyncCopyRequest()
Due to undefined (favorably right to left) argument evaluation order,
the tracker might have been passed and set to NULL before the window
is looked up which results in a NULL pointer dereference.
BUG=659210
Review-Url: https://chromiumcodereview.appspot.com/2435033002
Cr-Commit-Position: refs/heads/master@{#426748}
(cherry picked from commit 1b4c64279b7c212242738b96643a0700d04d725c)
Review URL: https://codereview.chromium.org/2465993002 .
Cr-Commit-Position: refs/branch-heads/2883@{#386}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Do not replace up-to-date System Flash with Component Flash.
BUG=656058
TEST=Cases 1, 3, 5 from https://docs.google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/edit#heading=h.pe0xr0h8vcrv
Review-Url: https://codereview.chromium.org/2434103005
Cr-Commit-Position: refs/heads/master@{#428205}
(cherry picked from commit 151a7690b7312bed56784b8b953cce11e03a1085)
Review URL: https://codereview.chromium.org/2463913002 .
Cr-Commit-Position: refs/branch-heads/2883@{#385}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
"Fix" remaining connection error handlers in Blink
This changes all remaining Mojo connection error handlers in Blink
to no-op if invoked after Blink shutdown.
TBRing haraken@ since this solution has already been discussed and
landed in several other cases, and it's a P0.
BUG=658907
[email protected]
Review-Url: https://codereview.chromium.org/2463453002
Cr-Commit-Position: refs/heads/master@{#428468}
(cherry picked from commit d84779e26d4783df207dd66e9b7f6f5f3878c026)
Review URL: https://codereview.chromium.org/2459283005 .
Cr-Commit-Position: refs/branch-heads/2883@{#384}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Offline pages] Removing the offline icon from OIB
Simply removing the icon placeholder (the icon does not display properly
right now).
BUG=660426
Review-Url: https://codereview.chromium.org/2463443002
Cr-Commit-Position: refs/heads/master@{#428508}
(cherry picked from commit f4e61e9950635faed2b7713efa2b7e87e3a3b387)
Review URL: https://codereview.chromium.org/2467523002 .
Cr-Commit-Position: refs/branch-heads/2883@{#383}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Media Controls: listen to events on the capturing phase to hide menu.
Otherwise, stopPropagation() will prevent the window object from receiving
click events.
BUG=657796
[email protected]
Review-Url: https://codereview.chromium.org/2443193002
Cr-Commit-Position: refs/heads/master@{#428339}
(cherry picked from commit 26d61829ca41ed2780e68459aa8c58d2c83d9743)
Review URL: https://codereview.chromium.org/2463763002 .
Cr-Commit-Position: refs/branch-heads/2883@{#382}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Add unknown dimension for data use histograms
Following CL changed data use histograms to be logged as foreground,
background and unknown. This CL adds the dimensions to histograms.xml.
https://crrev.com/b07005bcaac418bfed5e0e3a93edb025c8e43dfa
BUG=648808
Review-Url: https://codereview.chromium.org/2445193008
Cr-Commit-Position: refs/heads/master@{#428314}
(cherry picked from commit 4a5e8956c85b5ac72858d08cd472babc89e9c9b9)
Review URL: https://codereview.chromium.org/2460273002 .
Cr-Commit-Position: refs/branch-heads/2883@{#381}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Record the time since Chromium is in background for background data use
DataUse.BackgroundToDataRecievedPerByte.[User|System] histogram is
recorded for each background downstream byte.
DataUse.BackgroundToFirstDownstream.[User|System] histogram is
recorded for the first background downstream byte.
BUG=648808
Review-Url: https://chromiumcodereview.appspot.com/2417773005
Cr-Commit-Position: refs/heads/master@{#426386}
(cherry picked from commit 8766555a6c807796f6c177a3fe4ed81598620324)
Review URL: https://codereview.chromium.org/2462923002 .
Cr-Commit-Position: refs/branch-heads/2883@{#380}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Merge "Revert of Content in disabled input field should not be selectable. (patchset #4 id:80001 of https://codereview.chromium.org/2145323002/ )" to M55 branch
Reason for revert:
It caused regression:
https://bugs.chromium.org/p/chromium/issues/detail?id=656736
Original issue's description:
> Content in disabled input field should not be selectable.
>
> Spec: https://html.spec.whatwg.org/multipage/forms.html#the-readonly-attribute:attr-input-readonly
>
> BUG=626581
>
> Committed: https://crrev.com/21d670d3e740b26dcdf63631d163c45a57d9531c
> Cr-Commit-Position: refs/heads/master@{#405717}
[email protected],[email protected]
BUG=626581
Review-Url: https://codereview.chromium.org/2455853002
Cr-Commit-Position: refs/heads/master@{#428261}
(cherry picked from commit e16d4aaa97a134e73510e2bce2f99359396f690f)
Review URL: https://codereview.chromium.org/2461293002 .
Cr-Commit-Position: refs/branch-heads/2883@{#379}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.33
Cr-Commit-Position: refs/branch-heads/2883@{#378}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.32
Cr-Commit-Position: refs/branch-heads/2883@{#377}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
WebFonts intervention: understand if download time matches the decision
To understand download time correlation with intervention decision,
breakdown download time metrics per intervention decision.
We have download time metrics per data size, but this change adds only
10KB to 50KB range since it covers about 70% cases.
BUG=659371
Review-Url: https://codereview.chromium.org/2443883003
Cr-Commit-Position: refs/heads/master@{#428072}
(cherry picked from commit 3c3890ee4f2132a4a5e35ce9a2ceff73cac1b80e)
[email protected]
Review URL: https://codereview.chromium.org/2465643002 .
Cr-Commit-Position: refs/branch-heads/2883@{#376}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Wait a few seconds for simulators to be killed, and flush each line of output written
BUG=660527
TBR=rohitrao
(cherry picked from commit 0f503047288d543f8847bbd5d49b16af02277f16)
Review-Url: https://codereview.chromium.org/2461163002
Cr-Original-Commit-Position: refs/heads/master@{#428601}
Cr-Commit-Position: refs/branch-heads/2883@{#375}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.31
Cr-Commit-Position: refs/branch-heads/2883@{#374}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Drop navigations to NavigationEntry with invalid virtual URLs.
BUG=657720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2452443002
Cr-Commit-Position: refs/heads/master@{#428056}
(cherry picked from commit e4ebe078840e65d673722e94f8251b334030b5e8)
Review URL: https://codereview.chromium.org/2459913003 .
Cr-Commit-Position: refs/branch-heads/2883@{#373}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Kill simctl before starting iOS simulator tests
BUG=660527
(cherry picked from commit b2078ae095d322b807bd39b17f5fee29b1fa2feb)
Review-Url: https://codereview.chromium.org/2459933003
Cr-Original-Commit-Position: refs/heads/master@{#428547}
Cr-Commit-Position: refs/branch-heads/2883@{#372}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fix some remaining issues with Special Locale
This CL fixes issues regarding to recent_tabs' visibility in menu,
special engine's existence in special locale, and some dialog bugs.
BUG=656512,658942,655776
Review-Url: https://codereview.chromium.org/2450373002
Cr-Commit-Position: refs/heads/master@{#428448}
(cherry picked from commit 5a610002bc9430a03634337df721352be5985e18)
Review URL: https://codereview.chromium.org/2460053002 .
Cr-Commit-Position: refs/branch-heads/2883@{#371}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Android] Call onDismissNoAction() after dismissSnackbar() is called
Previously if a client calls SnackbarManager#dismissSnackbar(),
onDismissNoAction() will not be called. This CL changes this behavior to
make the API more clear.
BUG=652477
Review-Url: https://codereview.chromium.org/2454423002
Cr-Commit-Position: refs/heads/master@{#428451}
(cherry picked from commit 33ab9183a2b9ec7fe8e74e48edea2acbbece3e35)
Review URL: https://codereview.chromium.org/2457233002 .
Cr-Commit-Position: refs/branch-heads/2883@{#370}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Adding/renaming a folder in the bookmark manager should not hide the icon.
BUG=649629
TEST=Select a folder in the bookmark manager and hit F2. The folder icon should not disappear and the input field for changing the name should have a fully visible border. Type a name and hit enter; the text should not move between before and after you hit enter.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2444373003
Cr-Commit-Position: refs/heads/master@{#428189}
(cherry picked from commit 93a5e7c45a78646f04f1de812da3cb41d6667845)
Review URL: https://codereview.chromium.org/2450363005 .
Cr-Commit-Position: refs/branch-heads/2883@{#369}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Offline Page Cache: do not save a snapshot of a page loaded from a snapshot.
Offline Page Cache was saving snapshots of pages being loaded from
previously saved snapshots, which is unnecessary. This change fixes that
by only enabling the saving if the loaded page is not an "offline" page
itself.
BUG=660106
Review-Url: https://codereview.chromium.org/2448143005
Cr-Commit-Position: refs/heads/master@{#428239}
(cherry picked from commit ff2b583208f110e3217e5879a6681b3e1875f7bb)
Review URL: https://codereview.chromium.org/2462713003 .
Cr-Commit-Position: refs/branch-heads/2883@{#368}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
DevTools: restore selection and scrollposition between network and filesystem
BUG=658089
R=dgozman
Review-Url: https://codereview.chromium.org/2435043003
Cr-Commit-Position: refs/heads/master@{#427268}
(cherry picked from commit d70e6764b38821da712088fe67bbed2c563922d8)
Review URL: https://codereview.chromium.org/2456413003 .
Cr-Commit-Position: refs/branch-heads/2883@{#367}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Reland of DevTools: properly restore selected DOMNode in Elements panel.
This patch is a reland of https://crrev.com/2428823002/, merged with
https://crrev.com/2448963003.
Since the http://crrev.com/b4d6bf98e, we started
sending two "documentUpdated" events for every
page reload.
It's not a bad thing by itself (but probably needs
addressing in a follow-up), but the element restoration
logic is unprepared for this.
This patch re-writes the element restoring logic in the
elements panel so that we will try to restore to the last
focused selected element.
BUG=645645
R=dgozman
Review-Url: https://codereview.chromium.org/2449963004
Cr-Commit-Position: refs/heads/master@{#427715}
(cherry picked from commit f19c680112d1d6fc029b1463ceeb35b7a54297a4)
Review URL: https://codereview.chromium.org/2460953003 .
Cr-Commit-Position: refs/branch-heads/2883@{#366}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge-M55] arc: Add Goolge Privacy Policy link to OptIn UI.
This adds a link to GetStarted page that opens Privacy Policy for
the language currently selected in ToS
BUG=b/30103177
BUG=658833
TEST=Locally on device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://chromiumcodereview.appspot.com/2434823002
Cr-Commit-Position: refs/heads/master@{#426288}
(cherry picked from commit 06650954785fb597dba01d710db0a8665206e647)
Review-Url: https://codereview.chromium.org/2460933003
Cr-Commit-Position: refs/branch-heads/2883@{#365}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[M55] Generalize layer mirroring for phantom windows
Previously, the layers of a phantom window were recreated when the
surface changed in the corresponding layers of the original window.
The code also assumed that layers with surfaces are leaves in the
layer tree, but Exosphere surfaces are nested. Recursive layer
cloning would be inefficient for surfaces changing in each frame,
so this CL adds an alternative way to mirror layers. In addition,
the bounds of Exosphere surfaces relative to their parent window
are updated whenever the window moves, so this CL provides a way
to synchronize relative positions of layers in phantom windows.
In addition to implementing phantom windows for ARC apps, this CL
fixes three bugs related to mirroring:
1) Memory corruption due to the non-recursive layer cloning.
2) Dangling pointers due to observers sticking around.
3) Black Alt+Tab previews for ARC windows.
BUG=642894
BUG=649452
BUG=653113
TEST=ARC apps that render continuously (e.g. games, video players)
can be dragged to external displays, and their content is
mirrored in phantom windows.
TEST=ARC apps are mirrored in Alt+Tab previews.
Review-Url: https://codereview.chromium.org/2383263002
Cr-Commit-Position: refs/heads/master@{#427891}
(cherry picked from commit 4b33bfeda856f7ae20ffa43176e5bd529d5a100a)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2457163003 .
Cr-Commit-Position: refs/branch-heads/2883@{#364}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[m55 merge] bugfix for ResetPromised(). Guarded by ENABLED -- FLAGS_quic_bugfix_reset_promised.
Remove superfluous call to InsertLocallyClosedStreamHighestOffset() in ResetPromised().
ResetPromised() was triggering an integer overflow in GetNumLocallyClosedOutgoingStreamsHighestOffset(), because InsertLocallyClosedStreamHighestOffset() was called twice for the same stream,
The first call was from the chain ResetPromised() -> SendRstStream() -> CloseStreamInner() -> InsertLocallyClosedStreamHighestOffset(), the second was
ResetPromised() -> InsertLocallyClosedStreamHighestOffset().
The integer overflow in turn caused QuicChromiumClientSession::TryCreateStream() to queue up streams indefinitely, effectively wedging the session.
This change adds DCHECK's to detect such overflows (test-only) to
protect against such regressions in the future.
Merge internal change: 137406068
[email protected]
BUG=660076
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2453323003
Cr-Commit-Position: refs/heads/master@{#428092}
(cherry picked from commit 2f1f74cc11d45d84516ca7e32d37cb41a5ca66e6)
Review-Url: https://codereview.chromium.org/2461783002
Cr-Commit-Position: refs/branch-heads/2883@{#363}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge-M55] arc: Use overlay to show links from ToS.
BUG=b/32247410
BUG=658833
TEST=Locally on device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2429793003
Cr-Commit-Position: refs/heads/master@{#426101}
(cherry picked from commit 845e02dc39e9283f6a13957bac034c0d4a3d172c)
Review-Url: https://codereview.chromium.org/2458213002
Cr-Commit-Position: refs/branch-heads/2883@{#362}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M55] Suppressing First Run Bubble when chrome://welcome is displayed.
BUG=656178
Review-Url: https://chromiumcodereview.appspot.com/2441823002
Cr-Commit-Position: refs/heads/master@{#426871}
(cherry picked from commit 14bebe60982a8b31a780712d523eaf4ca2103d7a)
Review URL: https://codereview.chromium.org/2457673005 .
Cr-Commit-Position: refs/branch-heads/2883@{#361}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Make the content scheme local
WebContent should not be able to embed or redirect to content scheme.
BUG=659492
Review-Url: https://codereview.chromium.org/2456883002
Cr-Commit-Position: refs/heads/master@{#428222}
(cherry picked from commit c7c7daa089804c779c4ebfb2a2b5793be6b47090)
Review URL: https://codereview.chromium.org/2458793003 .
Cr-Commit-Position: refs/branch-heads/2883@{#360}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Clear floats when we make a ruby base's children inline
BUG=658584
Review-Url: https://codereview.chromium.org/2452993002
Cr-Commit-Position: refs/heads/master@{#427807}
(cherry picked from commit 2578cf94297437a2e23b9a15cf5ba8c1f0b4becb)
Review URL: https://codereview.chromium.org/2458143002 .
Cr-Commit-Position: refs/branch-heads/2883@{#359}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Copy float list of ruby base when merging it with a sibling
When merging two ruby bases ensure that the new base has a complete float list.
A 2nd go at https://crrev.com/6f208d569f6bd2488f2f2f6f9004e54417f78782
BUG=619380, 624028, 644605, 644803
Review-Url: https://codereview.chromium.org/2329863002
Cr-Commit-Position: refs/heads/master@{#424864}
(cherry picked from commit 3453e2368a018544e7143e60afbc7a1454e848ed)
Review URL: https://codereview.chromium.org/2455973005 .
Cr-Commit-Position: refs/branch-heads/2883@{#358}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fix Password Manager Performance Issues
This change further addresses the performance issue of password manager when
many passwords are saved. Prior to this change a long password list (~1000
entries) can freeze the password manager for multiple seconds.
Inspired by the edit dictionary settings (chrome://settings/editDictionary),
this change removes the |autoExpands| attributes from the saved passwords and
password exceptions lists and adds a CSS |max-height| attribute. This results in
rendering the list almost instantaneously and keeps it responsive with regard to
user interactions.
BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2443143002
Cr-Commit-Position: refs/heads/master@{#427655}
(cherry picked from commit 948349a43c3c3bd15a05c5b79e66507abfd31a3a)
Review URL: https://codereview.chromium.org/2458043002 .
Cr-Commit-Position: refs/branch-heads/2883@{#357}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Merge 2883: Do not SendPasswordForms when LocalFrame is being detached
Manually merged after resolving conflict with crbug.com/646610
This patch stops PasswordAutofillAgent::SendPasswordForms() to
enumerates forms in the document when LocalFrame is being detached.
This patch does not address the root cause of issue 561873 nor
issue 595078, but it is expected to reduce the crashes by large, and
it is reasonable not to fill passwords when Page is being destroyed.
[email protected], [email protected]
BUG=561873, 595078, 654654
Review-Url: https://codereview.chromium.org/2398733004
Cr-Commit-Position: refs/heads/master@{#424692}
(cherry picked from commit a398abc5085c5dc2d8db3076543072d1f196d668)
Review URL: https://codereview.chromium.org/2455053005 .
Cr-Commit-Position: refs/branch-heads/2883@{#356}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Handle navigations with PAGE_TRANSITION_CLIENT_REDIRECT qualifier
to allow the AppAuth web page to work properly with ARC.
BUG=659817
TEST=try, run the apk attached to the bug on ARC
(cherry picked from commit 250459af2d654e5bf411440f4a034c7e7799b7d6)
Review URL: https://codereview.chromium.org/2459803002 .
Cr-Commit-Position: refs/branch-heads/2883@{#355}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Update the md5 of test-25fps.vp9 for MediaTek.
VP9 driver of elm reported wrong visible size and it was fixed.
Update the md5 of test-25fps.vp9 to reflect the change.
BUG=b:32354993
TEST=Run VDA unittest on elm.
Review-Url: https://codereview.chromium.org/2445653002
Cr-Commit-Position: refs/heads/master@{#427239}
(cherry picked from commit 3074c99b45105f1de43251885686221cfd2e365b)
Review URL: https://codereview.chromium.org/2455233003 .
Cr-Commit-Position: refs/branch-heads/2883@{#354}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Merge "INPUT element: Do not dispatch events in detachLayoutTree()." to M55 branch.
When a color chooser is closed, we dispatches a 'change' event asynchronously.
Some tests need to be updated due to this behavior change.
BUG=658535
Review-Url: https://codereview.chromium.org/2447653002
Cr-Commit-Position: refs/heads/master@{#427286}
(cherry picked from commit fbe37c7239e4a6e75f12c0d35e60987a6aa75ee0)
Review URL: https://codereview.chromium.org/2458743004 .
Cr-Commit-Position: refs/branch-heads/2883@{#353}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.30
Cr-Commit-Position: refs/branch-heads/2883@{#352}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Use the generated checks for whether origin trials are enabled.
BUG=635741
Review-Url: https://codereview.chromium.org/2454513002
Cr-Commit-Position: refs/heads/master@{#427602}
(cherry picked from commit 3a5a4c96d03ff39adaed79d3fa0af80587e091c1)
Review URL: https://codereview.chromium.org/2454253003 .
Cr-Commit-Position: refs/branch-heads/2883@{#351}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Convert relative paths to absolute paths in iOS test runner
xctests for devices require BUILT_PRODUCTS_DIR to be an absolute path. Might as well just make all paths absolute.
n.b. Inputs to the test runner are always relative paths because this is required by Swarming.
BUG=608537
TBR=huangml
(cherry picked from commit 22203b32bdae9236d23cc89e70772721315f2d1f)
Review-Url: https://codereview.chromium.org/2450133003
Cr-Original-Commit-Position: refs/heads/master@{#427892}
Cr-Commit-Position: refs/branch-heads/2883@{#350}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Support xctests on devices
TestProject is copied from chromium/tools/build/scripts/slave/ios/TestProject.
BUG=608537
(cherry picked from commit 19d5fcc214823ba905cf37650585552027dcd6d0)
Review-Url: https://codereview.chromium.org/2447253003
Cr-Original-Commit-Position: refs/heads/master@{#427816}
Cr-Commit-Position: refs/branch-heads/2883@{#349}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Support xctests on simulators
xctest_utils.py is copied from chromium/tools/build/scripts/slave/ios/xctest_utils.py.
BUG=608537
(cherry picked from commit a02a2039a04b4bafd020ee80ff088be27cf3bdf7)
Review-Url: https://chromiumcodereview.appspot.com/2437953002
Cr-Original-Commit-Position: refs/heads/master@{#426933}
Cr-Commit-Position: refs/branch-heads/2883@{#348}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
DevTools: fix rounding of scale in device mode
While resizing the DevTools viewport to be smaller than the emulated device's
screen size in responsive mode, _calculateAndEmulate() clamps the emulated
screen size to preferredScaledWidth/Height(). The condition to do so checks
whether the screen's dimensions are greater than the preferred-scaled
dimensions. The sharp scale calculator in calculateFitScale() would find a scale
nearby the precise value that would result in integer screen sizes.
However, it was possible for the sharp scale to be greater than the actual
scale, which resulted in a smaller preferredScaledWidth/Height() than was
available. This edge case triggers the clamping condition, which led to
inaccurate widths/heights that differed from user input.
BUG=651123
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2449763002
Cr-Commit-Position: refs/heads/master@{#427583}
(cherry picked from commit 2f5985ecef25664e1b6bba43b338683dd5d63c64)
Review-Url: https://codereview.chromium.org/2457883004
Cr-Commit-Position: refs/branch-heads/2883@{#347}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert of [M55] Generalize layer mirroring for phantom windows (patchset #1 id:1 of https://codereview.chromium.org/2459653003/ )
Reason for revert:
This broke Windows build: https://bugs.chromium.org/p/chromium/issues/detail?id=660183
Original issue's description:
> [M55] Generalize layer mirroring for phantom windows
>
> Previously, the layers of a phantom window were recreated when the
> surface changed in the corresponding layers of the original window.
> The code also assumed that layers with surfaces are leaves in the
> layer tree, but Exosphere surfaces are nested. Recursive layer
> cloning would be inefficient for surfaces changing in each frame,
> so this CL adds an alternative way to mirror layers. In addition,
> the bounds of Exosphere surfaces relative to their parent window
> are updated whenever the window moves, so this CL provides a way
> to synchronize relative positions of layers in phantom windows.
>
> In addition to implementing phantom windows for ARC apps, this CL
> fixes three bugs related to mirroring:
>
> 1) Memory corruption due to the non-recursive layer cloning.
> 2) Dangling pointers due to observers sticking around.
> 3) Black Alt+Tab previews for ARC windows.
>
> [email protected]
> [email protected], [email protected], [email protected], [email protected], [email protected]
> BUG=642894
> BUG=649452
> BUG=653113
> TEST=ARC apps that render continuously (e.g. games, video players)
> can be dragged to external displays, and their content is
> mirrored in phantom windows.
> TEST=ARC apps are mirrored in Alt+Tab previews.
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Review-Url: https://codereview.chromium.org/2383263002
> Cr-Commit-Position: refs/heads/master@{#427891}
> (cherry picked from commit 4b33bfeda856f7ae20ffa43176e5bd529d5a100a)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/497b50fc19904a059de566474ff099519a4c881a
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642894
Review-Url: https://codereview.chromium.org/2458833003
Cr-Commit-Position: refs/branch-heads/2883@{#346}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[M55] Generalize layer mirroring for phantom windows
Previously, the layers of a phantom window were recreated when the
surface changed in the corresponding layers of the original window.
The code also assumed that layers with surfaces are leaves in the
layer tree, but Exosphere surfaces are nested. Recursive layer
cloning would be inefficient for surfaces changing in each frame,
so this CL adds an alternative way to mirror layers. In addition,
the bounds of Exosphere surfaces relative to their parent window
are updated whenever the window moves, so this CL provides a way
to synchronize relative positions of layers in phantom windows.
In addition to implementing phantom windows for ARC apps, this CL
fixes three bugs related to mirroring:
1) Memory corruption due to the non-recursive layer cloning.
2) Dangling pointers due to observers sticking around.
3) Black Alt+Tab previews for ARC windows.
[email protected]
[email protected], [email protected], [email protected], [email protected], [email protected]
BUG=642894
BUG=649452
BUG=653113
TEST=ARC apps that render continuously (e.g. games, video players)
can be dragged to external displays, and their content is
mirrored in phantom windows.
TEST=ARC apps are mirrored in Alt+Tab previews.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2383263002
Cr-Commit-Position: refs/heads/master@{#427891}
(cherry picked from commit 4b33bfeda856f7ae20ffa43176e5bd529d5a100a)
Review URL: https://codereview.chromium.org/2459653003 .
Cr-Commit-Position: refs/branch-heads/2883@{#345}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert of cc : Move screen space scale factor to root transform node (patchset #1 id:1 of https://codereview.chromium.org/2452023003/ )
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=660047
Original issue's description:
> cc : Move screen space scale factor to root transform node
>
> This CL computes the screen space scale factor which is
> combined form scale factors of device transform, device
> scale factor and page scale factor(if required), and stores
> it on the root transform node as its surface contents scale.
> This also implicitly fixes a clipping bug.
> TransformTree::ComputeTransforms(a, b) should return the
> transform between a and b without the surface contents
> scale. But, since screen space scale was baked into the
> local transform of the contents root node (before this CL),
> ComputeTransform(a, root) was having the scale baked in.
> (and this caused the bug)
>
> BUG=651584
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Review-Url: https://codereview.chromium.org/2408243002
> Cr-Commit-Position: refs/heads/master@{#427366}
> (cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b25318d43700fc
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651584
Review-Url: https://codereview.chromium.org/2454203002
Cr-Commit-Position: refs/branch-heads/2883@{#344}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Payments] Fix the Payment Request histogram check failure in tests.
BUG=659739
Review-Url: https://codereview.chromium.org/2455513004
Cr-Commit-Position: refs/heads/master@{#427887}
(cherry picked from commit fda49ee4f9201fe1190d982fd41a51e5f586e3c1)
Review URL: https://codereview.chromium.org/2460603002 .
Cr-Commit-Position: refs/branch-heads/2883@{#343}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Prevent AutoscrollForSelection when selecting text in a fixed-position element.
AutoscrollForSelection is triggered when selecting text and dragging mouse out
of the container. However, we don't want selecting text in a fixed-position
element triggers autoscroll otherwhere. Inside findAutoscrollable, when we find
the object is inside a fixed-position element, we should prevent
AutoscrollForSelection from happening.
BUG=655489
Review-Url: https://codereview.chromium.org/2441683002
Cr-Commit-Position: refs/heads/master@{#427146}
(cherry picked from commit 53546e297f782849d9da8004508d0b85c2fd931c)
Review URL: https://codereview.chromium.org/2455163002 .
Cr-Commit-Position: refs/branch-heads/2883@{#342}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
cros: Fixed 3 bugs for pin unlock.
User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown.
BUG= 655221, 654300, 655308
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2427073002
Cr-Commit-Position: refs/heads/master@{#427152}
(cherry picked from commit a77a4ddde837ba57fca3195127cd4f1ad8f96eab)
Review URL: https://codereview.chromium.org/2458763002 .
Cr-Commit-Position: refs/branch-heads/2883@{#341}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Merge M55: "Don't background pause suspend until we have future data."
Otherwise the pause state is not reliable and we may incorrectly
prevent background playback attempts.
We can't always force background pause suspend since background
playback may trigger a play() but we don't know the correct paused
state yet.
BUG=658680
TEST=new test.
Review-Url: https://codereview.chromium.org/2449873006
Cr-Commit-Position: refs/heads/master@{#427910}
(cherry picked from commit cc8baf72a3cfc63b1bd39710b8999b04508e43c8)
Review URL: https://codereview.chromium.org/2456613003 .
Cr-Commit-Position: refs/branch-heads/2883@{#340}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
HaTS does not work on dogfood devices
Dogfood devices are enterprise enrolled. The users on enterprise devices
cannot be the owner of the device which is required for hats. This
change adds an exception for dogfood devices to skip the ownership
check.
BUG=654899
COMPONENT=HaTS, Chrome OS
Review-Url: https://codereview.chromium.org/2415463002
Cr-Commit-Position: refs/heads/master@{#424584}
(cherry picked from commit 9236c35d88a731b043825008e201e1e1b213db0d)
Review URL: https://codereview.chromium.org/2461473002 .
Cr-Commit-Position: refs/branch-heads/2883@{#339}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Offline pages] Limiting download button to http and https URLs
Limits the download button availability to HTTP and HTTPS pages.
We are currently not supporting offline page downloads beyond these
two URL schemes.
BUG=641259
[email protected]
Review-Url: https://codereview.chromium.org/2452203002
Cr-Commit-Position: refs/heads/master@{#427869}
(cherry picked from commit db793bd5c303a3db7111e70b6dc63f4307742332)
Review URL: https://codereview.chromium.org/2447393004 .
Cr-Commit-Position: refs/branch-heads/2883@{#338}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Update Chromoting Mac signing script for new signing system.
This adds flag-style params, which makes calling the script more
flexible, and removes the need to specify the keychain, which is not
compatible with the "split keychains" configuration of the new system,
and not really needed anyhow.
[email protected], [email protected]
BUG=b/31931170
Review-Url: https://codereview.chromium.org/2448273003
Cr-Commit-Position: refs/heads/master@{#427542}
(cherry picked from commit 4b3679a26bad8f470408610bf9bb7ccd46c8610b)
Review URL: https://codereview.chromium.org/2452233003 .
Cr-Commit-Position: refs/branch-heads/2883@{#337}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[NTP Client][M55] Merge "Fix SignInPromo impression tracking"
The SignInPromo previously recorded impressions at the completely
wrong time.
Original review: https://codereview.chromium.org/2457743002/
BUG=659728
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2455113002
Cr-Commit-Position: refs/branch-heads/2883@{#336}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
RequestThrottler: reset quota at midnight *local time* rather than UTC
BUG=658686
Review-Url: https://codereview.chromium.org/2441413002
Cr-Commit-Position: refs/heads/master@{#427317}
(cherry picked from commit d5d08b7e79d33e044acca02ec197d096661de1dd)
Review URL: https://codereview.chromium.org/2457783002 .
Cr-Commit-Position: refs/branch-heads/2883@{#335}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert "Fix sandbox::PolicyBase leak"
This reverts commit b6a4ff86c730756a73d63cc882ef818fb7818a53
because it breaks Chrome when running as a published app on
Windows Terminal Services or Citrix XenApp.
Original issue's description:
> Fix sandbox::PolicyBase leak
>
> StartSandboxedProcess was missing a Release call, so this was always
> leaking. Use scoped_refptr instead to fix that and prevent it from
> happening in the future.
> [email protected]
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
>
> Committed: https://crrev.com/b6a4ff86c730756a73d63cc882ef818fb7818a53
> Cr-Commit-Position: refs/heads/master@{#417313}
BUG=659026
[email protected],[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2456573002
Cr-Commit-Position: refs/heads/master@{#427808}
(cherry picked from commit 2bfe4d60b683f05eb7fcb96f9a65d8279923f13f)
Review URL: https://codereview.chromium.org/2456063002 .
Cr-Commit-Position: refs/branch-heads/2883@{#334}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Make PermissionRequest::GetIconId return different types on desktop and Android so that the IDR_ and vector id versions don't coexist on any single platform.
BUG=651270
Review-Url: https://codereview.chromium.org/2385063005
Cr-Commit-Position: refs/heads/master@{#425577}
(cherry picked from commit 20c051a9a415b64187d410d0ec207c0442d784f5)
Review URL: https://codereview.chromium.org/2454813004 .
Cr-Commit-Position: refs/branch-heads/2883@{#333}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Obtain std::string from NSString via base::SysNSStringToUTF8 in password_controller.mm
This is a clean-up avoiding using NSString's UTF8String directly to construct a
std::string, in favour of using base::SysNSStringToUTF8 instead.
BUG=653379
Review-Url: https://codereview.chromium.org/2406833002
Cr-Commit-Position: refs/heads/master@{#424388}
(cherry picked from commit b88c2ab0a6b47e770cf7f3efdde2437491d80850)
Review URL: https://codereview.chromium.org/2446113011 .
Cr-Commit-Position: refs/branch-heads/2883@{#332}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Repeating header groups should align properly when captions are present
BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://chromiumcodereview.appspot.com/2422953003
Cr-Commit-Position: refs/heads/master@{#426243}
(cherry picked from commit 42151f9c0132a60a7be3b1793295a1966f532ca6)
Review URL: https://codereview.chromium.org/2453023003 .
Cr-Commit-Position: refs/branch-heads/2883@{#331}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Remove invalid "suffix" assumption from CreateSortKey
Currently, CreateSortKey in password_manager_presenter.cc assumes that domain
and registry name obtained from a hostname string is always a suffix of the
hostname string. This is true for ASCII-based examples like this:
hostname: subdomain.example.com
domain and registry: example.com
But it is not true for non-ASCII-based examples like this:
hostname: žřč.com
domain and registry: xn--bea5m6d.com
The reason is that to obtain the domain and registry, the hostname is being
canonicalized.
The domain and registry is used to create a sort key for a credential with the
given hostname. The idea is to start with the domain and registry part, and
then append the remaining subdomains (reversed). The remaining subdomains were
computed by taking the prefix of hostname of the length of the difference of
the length of the hostname minus the length of the domain and registry part.
This number may overflow in case the domain and registry is not a suffix of the
hostname.
This CL fixes the issue by appending the whole hostname to the domain and
registry part. The results look like this:
hostname: subdomain.example.com
old key: example.com.subdomain
new key: example.com.com.example.subdomain
hostname: žřč.com
old key: undefined
new key: xn--bea5m6d.com.com.žřč
This is safe (no assumptions about suffixes) and preserves the sorting order of
any two credentials before and after this change. It is potentially duplicating
the domain and registry part. An alternative solution could just canonicalize
the hostname before composing the key, but the code would be more complex for
an unclear benefit.
The CL also uses a more efficient call to GetDomainAndRegistry (avoiding
redoing the canonicalization of a known URL). It also introduces a test and
removes an unnecessary call to ASCIIToUTF16.
BUG=655949
Review-Url: https://codereview.chromium.org/2439953004
Cr-Commit-Position: refs/heads/master@{#427051}
(cherry picked from commit f77c3ffef00e68fe59150c78619dbdf289677400)
Review URL: https://codereview.chromium.org/2458633002 .
Cr-Commit-Position: refs/branch-heads/2883@{#330}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[NTP Snippets] Disable for supervised users
BUG=659120
Review-Url: https://codereview.chromium.org/2444373002
Cr-Commit-Position: refs/heads/master@{#427638}
(cherry picked from commit c95daea11942abb0582aced564e18f24b776253c)
Review URL: https://codereview.chromium.org/2459473002 .
Cr-Commit-Position: refs/branch-heads/2883@{#329}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Make the site engagement service more robust to clock changes and time inconsistencies.
This CL adjusts the site engagement service's logic for rebasing last
engagement times when no engagement has been earned for some time.
This code was prone to errors when users changed their clocks, where
last engagement times could be moved into the future or into the past
based on a clock change. This has only recently become an issue because
the rebasing codepath now triggers if no engagement is earned for ~9
hours, as opposed to three weeks.
The code was also brittle if the overall last engagement time (a lossy
pref) became out of sync with any single engagement score's last
engagement time (a lossy content setting). It is theoretically possible
that the content setting would be written to prefs, but the overall last
engagement time would not due to the prefs system buffering the lossy
write and then failing to complete it before browser shutdown.
This CL changes the rebase logic to also sanely handle unexpected times
caused by changing clocks or pref writing race conditions. Time rebasing
now occurs when the last engagement time is detected to be in the future
as well as in the past. Regression tests are added to ensure the correct
behaviour.
BUG=654560
Review-Url: https://chromiumcodereview.appspot.com/2427343002
Cr-Commit-Position: refs/heads/master@{#426696}
(cherry picked from commit ed64b2a6aaeb060283ca5583abc1583a879b1ce1)
Review URL: https://codereview.chromium.org/2452123003 .
Cr-Commit-Position: refs/branch-heads/2883@{#328}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
