Publish DEPS for Chromium 55.0.2883.9
Merge to 2883 "[DevTools] Support top/bottom show sidebar button."
> [DevTools] Support top/bottom show sidebar button.
>
> BUG=651705
>
> Review-Url: https://codereview.chromium.org/2395333002
> Cr-Commit-Position: refs/heads/master@{#423998}
(cherry picked from commit 35bb5043ed9e6f455d3c725d755ebfc76b53cf2b)
[email protected]
Review URL: https://codereview.chromium.org/2401353004 .
Cr-Commit-Position: refs/branch-heads/2883@{#32}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.9
Cr-Commit-Position: refs/branch-heads/2883@{#31}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge to 2883] Revert "[scheduler] Teach scheduler about audio state"
> > This patch wires information about audio state to renderer scheduler
> > and stops all throttling (background and offscreen) while
> > audio is playing and for a short period after audio is stopped.
> >
> > BUG=642321, 616519
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> >
> > Committed: https://crrev.com/a7a651d546b76499821b4ba47b8f017d4b8becac
> > Cr-Commit-Position: refs/heads/master@{#423405}
>
> BUG=653865, 642321, 616519
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> [email protected], [email protected], [email protected], [email protected]
>
> Review-Url: https://codereview.chromium.org/2408003002
> Cr-Commit-Position: refs/heads/master@{#424334}
> (cherry picked from commit ab94f97287e2649a65b633fe8e5d841ff2a65716)
Review URL: https://codereview.chromium.org/2403363003 .
Cr-Commit-Position: refs/branch-heads/2883@{#30}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Remove merge rules for //third_party/WebKit from M55 branch.
Less magic for merges.
BUG=563793
[email protected]
Review URL: https://codereview.chromium.org/2404553002 .
Cr-Commit-Position: refs/branch-heads/2883@{#29}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge to 2883] Revert "[scheduler] Throttle background frames with 1% CPU limit"
> [Note that original CL had no description].
>
> > BUG=639852
> > Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
> > Committed: https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22
> > Cr-Original-Commit-Position: refs/heads/master@{#423170}
> > Cr-Commit-Position: refs/heads/master@{#423604}
>
> BUG=639852, 653865
> [email protected], [email protected], [email protected], [email protected], [email protected]
>
> Review-Url: https://codereview.chromium.org/2407023002
> Cr-Commit-Position: refs/heads/master@{#424283}
> (cherry picked from commit b4702b576414fc5f06bb20454988d0705fba9e9e)
Review URL: https://codereview.chromium.org/2409653003 .
Cr-Commit-Position: refs/branch-heads/2883@{#28}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Blacklist Samsung Galaxy Star Pro (GT-S7262) for Spitzer.
Speculative fix for associated bug, on branch only
R=liberato,watk
BUG=634920
Review URL: https://codereview.chromium.org/2405053002 .
Cr-Commit-Position: refs/branch-heads/2883@{#27}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Offline pages] Adds an infobar blocking download if a duplicate page or request is detected
* Adds infobar delegate for offline page overwrite confirmation
* Adds test for filtering list of offline pages based on URL
* Updates logic in offline_page_download_bridge to show infobar, when offline page duplicates are detected.
* Removes "Downloading..." toast when actual download is not going to happen.
BUG=640143,641259
Review-Url: https://codereview.chromium.org/2389033002
Cr-Commit-Position: refs/heads/master@{#423901}
(cherry picked from commit 2684ff8fe336b861e9b37cfbcd09e59742afdb26)
Review URL: https://codereview.chromium.org/2408013002 .
Cr-Commit-Position: refs/branch-heads/2883@{#26}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.8
Cr-Commit-Position: refs/branch-heads/2883@{#25}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[M55] Blacklist Spitzer for Lenovo A6600 / 6800 due to GL crashses.
Merge of: https://codereview.chromium.org/2406553002
BUG=628059
NOPRESUBMIT=true
NOTRY=true
[email protected]
Review URL: https://codereview.chromium.org/2408943002 .
Cr-Commit-Position: refs/branch-heads/2883@{#24}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert "Reland of Move language pak files to assets."
This reverts commit 67101cd0338a409d80689b9c9c875c95ccde7957.
One last revert to address a dev blocking crash.
BUG=653771
Revert "Move PathUtils to use ContextUtils."
This reverts commit 7200e9f34aa2e9006d8ea5540035de744b13d27d.
Have to revert this to unwind another revert.
BUG=653771
Cr-Commit-Position: refs/branch-heads/2883@{#23}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.7
Cr-Commit-Position: refs/branch-heads/2883@{#22}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert "Store only locale paks rather than all assets within BuildConfig.java"
This reverts commit 4e09dacc10a8a359785c6f49d75653ce7cfd00ec.
Reverting on M55 branch to unblock dev tomorrow.
BUG=653771
Cr-Commit-Position: refs/branch-heads/2883@{#21}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
MD History: Use iron-a11y-announcer to announce search result messages
The existing method we were using, `announceAccessibleMethod`, did
not correctly announce messages on Canary, possibly due to timing
issues. iron-a11y-announcer appears to be more robust for making
sure messages are actually announced, since they do not immediately
disappear from the DOM tree.
BUG=606527,653764
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2399213004
Cr-Commit-Position: refs/heads/master@{#423949}
(cherry picked from commit 2a2797cc88833b227a24dfd476cb9ce125b07004)
Review URL: https://codereview.chromium.org/2405993002 .
Cr-Commit-Position: refs/branch-heads/2883@{#20}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Fix gn installer/linux/BUILD.gn with target_arch=arm
Widevine is only available for x86 and x64 on linux. This
check was mistakenly removed in:
https://codereview.chromium.org/2395673002
The widevine shared libraries are not buildable for
other architectures currently (see
//third_party/widevine/cdm/BUILD.gn).
TEST=gn gen with target_cpu=arm and enable_linux_installer = true
BUG=653900
Review-Url: https://codereview.chromium.org/2401033003
Cr-Commit-Position: refs/heads/master@{#424198}
(cherry picked from commit 8c9a63e1b68dccd8dab4e4b093dcea3f31d60163)
Review URL: https://codereview.chromium.org/2405963002 .
Cr-Commit-Position: refs/branch-heads/2883@{#19}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
chromeos: Avoid crash on synchronous suspend readiness call.
Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.
BUG=chrome-os-partner:58295,648580
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)
Review URL: https://codereview.chromium.org/2402283004 .
Cr-Commit-Position: refs/branch-heads/2883@{#18}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M55] aw: Fix hardware draw clipping
BUG=653834
Review-Url: https://codereview.chromium.org/2403883002
Cr-Commit-Position: refs/heads/master@{#424208}
(cherry picked from commit 22516bf51d004cd0161781e983b1124ff03c0f07)
Review URL: https://codereview.chromium.org/2401413003 .
Cr-Commit-Position: refs/branch-heads/2883@{#17}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
DevTools: Fix CPU page becoming unresponsive with timeline CPU throttling on Win
BUG=643127
Review-Url: https://codereview.chromium.org/2400363002
Cr-Commit-Position: refs/heads/master@{#424021}
(cherry picked from commit ed96d750e94db5c11d44b987d7a1995a46f69fb4)
Review URL: https://codereview.chromium.org/2407773003 .
Cr-Commit-Position: refs/branch-heads/2883@{#16}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
DevTools: CPU throttling should disable when DevTools are closed.
BUG=654138
Review-Url: https://codereview.chromium.org/2399883005
Cr-Commit-Position: refs/heads/master@{#424042}
(cherry picked from commit 94eb2d6a00a578b21a22f5c8cc9e5661d29b2a9e)
Review URL: https://codereview.chromium.org/2404923003 .
Cr-Commit-Position: refs/branch-heads/2883@{#15}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Updating XTBs based on .GRDs from branch 2883
Cr-Commit-Position: refs/branch-heads/2883@{#14}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Cronet] Add new API methods before removing old ones
To allow embedders to update to the new API piecemeal, rather than
forcing an all-at-once update:
1. Allow mocking of UrlRequest.Builder by making non-final. This
allows embedders to prepare for removal of CronetEngine.createRequest().
2. Add CronetEngine.newUrlRequestBuilder()
R=kapishnikov
BUG=654432
Review-Url: https://codereview.chromium.org/2402753002
Cr-Commit-Position: refs/heads/master@{#424154}
(cherry picked from commit 4480e95462fa0a4a59f7ba517a5fde5262aa8801)
Review URL: https://codereview.chromium.org/2403053002 .
Cr-Commit-Position: refs/branch-heads/2883@{#13}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Change the auto sign-in first run title.
The new string better suits the use case when the user signs into Chrome after accepting the promo.
BUG=653123
Review-Url: https://codereview.chromium.org/2396373002
Cr-Commit-Position: refs/heads/master@{#423869}
(cherry picked from commit 7e9a1a9fd97ac749d424539726cc17e98f8f2643)
Review URL: https://codereview.chromium.org/2405863002 .
Cr-Commit-Position: refs/branch-heads/2883@{#12}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.6
Cr-Commit-Position: refs/branch-heads/2883@{#11}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.5
Cr-Commit-Position: refs/branch-heads/2883@{#10}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[Merge M55] android: Workaround null WindowAndroid crash
This check should be redundant with |observing_root_window_| check.
However we are receiving trickle of crash reports (crbug.com/639868)
with no root cause. Should investigate more when time allows what
corner case is missed. But for now, just add the null check.
BUG=639868
Review-Url: https://codereview.chromium.org/2402113002
Cr-Commit-Position: refs/heads/master@{#424011}
(cherry picked from commit f315ce3a9f3b33e54c7aac446b75234919223efd)
Review URL: https://codereview.chromium.org/2400173004 .
Cr-Commit-Position: refs/branch-heads/2883@{#9}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.4
Cr-Commit-Position: refs/branch-heads/2883@{#8}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert "Do not allow sign in if Google play service is absent"
This reverts commit 7aa9383118fa65b813a5f57900cece8b66028a83.
BUG=653832
[email protected]
Review URL: https://codereview.chromium.org/2402093002 .
Cr-Commit-Position: refs/branch-heads/2883@{#7}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.chromium.org/2365263006/ )
Reason for revert:
The downstream Chrome on iOS code has never been ported to the new vector icon and still use MD raster icon. This CL breaks Chrome on iOS downstream (due to missing resources and removal of GetIcon() method).
Original issue's description:
> Delete pre-MD code from OmniboxResultView
>
> BUG=648281
>
> Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
> Cr-Commit-Position: refs/heads/master@{#423690}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648281
Review-Url: https://codereview.chromium.org/2399333002
Cr-Commit-Position: refs/heads/master@{#423819}
(cherry picked from commit 7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c)
Review URL: https://codereview.chromium.org/2401213002 .
Cr-Commit-Position: refs/branch-heads/2883@{#6}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
[DurableStorage] Ship Durable in m55
Intent to Ship email:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/nAM3o4NSMsI
BUG=502373
Review-Url: https://codereview.chromium.org/2398353002
Cr-Commit-Position: refs/heads/master@{#423891}
(cherry picked from commit 12499f48413169c488095cfb8b7ef9e871b030a4)
Review URL: https://codereview.chromium.org/2394373003 .
Cr-Commit-Position: refs/branch-heads/2883@{#5}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Don't prompt for download location on Android
On Android, choosing file location is not very user friendly.
Disable this for now.
[email protected]
BUG=641790
Review-Url: https://codereview.chromium.org/2394303003
Cr-Commit-Position: refs/heads/master@{#423921}
(cherry picked from commit b034f7843cb922da49735428a0aafcb4cf9a3e38)
Review URL: https://codereview.chromium.org/2401143002 .
Cr-Commit-Position: refs/branch-heads/2883@{#4}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.3
Cr-Commit-Position: refs/branch-heads/2883@{#3}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.2
Cr-Commit-Position: refs/branch-heads/2883@{#2}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
Incrementing VERSION to 55.0.2883.1
Cr-Commit-Position: refs/branch-heads/2883@{#1}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
MD Settings: Date and Time page, part 1/3
Modernizes the UI a bit and adds a DateTimeHandler for policy stuff
(notifications TBD) and to provide the time zone list (TBD).
BUG=546835,460542
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2393703005
Cr-Commit-Position: refs/heads/master@{#423768}
Tweaking the draw-video-to-hw-accelerated-canvas-2d to stay on GPU
This performance test that is meant to draw to a GPU accelerated
canvas accidentally changed its behavior due to a recently added
heuristic that cancels GPU acceleration under certain
circumstances. This CL fixes the test to prevent it from triggering
the heuristic.
BUG=653565
Review-Url: https://codereview.chromium.org/2399013003
Cr-Commit-Position: refs/heads/master@{#423767}
Remove ash localization from display_manager.cc
As part of preparing ash::DisplayManager for relocation to ui,
eliminate its dependency on ash localization strings.
BUG=581462
Review-Url: https://codereview.chromium.org/2383313002
Cr-Commit-Position: refs/heads/master@{#423766}
Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/ )
Reason for revert:
Reverting since it is causing flakiness on the blink bots. Latest flake:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7628
unexpected_failures:
http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php
[email protected],[email protected],[email protected],[email protected]
BUG=616234
Review-Url: https://codereview.chromium.org/2399243002
Cr-Commit-Position: refs/heads/master@{#423765}
WebSQL: Add missing getExecutionContext() null check
Following r419951 getExecutionContext() may return null, so
return value must be checked.
BUG=653272
[email protected]
Review-Url: https://codereview.chromium.org/2398313002
Cr-Commit-Position: refs/heads/master@{#423764}
Don't call the decomposed thing a "Cipher Suite".
This matches the obsolete/modern part of the security panel. A cipher
suite is a particular thing in TLS and is not just the bulk cipher.
Cipher is a more appropriately generic term for a decomposition we made
up.
BUG=none
Review-Url: https://codereview.chromium.org/2393393004
Cr-Commit-Position: refs/heads/master@{#423763}
Making EventSender talk to the right WebWidget (for OOPIF support).
After the CL, there is a separate EventSender instance for each
WebWidgetTestProxyBase. Additionally EventSender transforms the
coordinates of the event before calling Blink, to make sure the
coordinates will work with the target widget.
Supporting EventSender via WebWidgetTestProxyBase requires
exposing WebWidgetTestProxyBase::web_view_test_proxy_base()
accessor and this in turn allows for clean-ups in some other
places - for example this allows to remove storing borrowed
pointers to TestRunner and WebViewTestProxyBase inside
WebWidgetTestClient.
BUG=616608
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2036873002
Cr-Commit-Position: refs/heads/master@{#423762}
Split the data use into foreground, background and unknown
Currently data use is measured as foreground and background. In some
cases where the app was transitioning from one state to different state,
data use at that time should be logged as unknown.
This CL changes the UMA to log on every network TX/RX of the URLRequest.
Earlier it was logged only when URLRequest completes.
BUG=648808
Review-Url: https://codereview.chromium.org/2399783003
Cr-Commit-Position: refs/heads/master@{#423761}
Remove stl_util's deletion functions from net/proxy/.
BUG=555865
Review-Url: https://codereview.chromium.org/2391453002
Cr-Commit-Position: refs/heads/master@{#423760}
Finish AppTasks on UI thread during test tear down
Finish AppTasks on the UI thread rather than the insturmentation
thread during test setup and tear down. Also eclose the finishAndRemoveTask()
calls in a try-catch block so that otherwise passing tests don't fail
on Android framework exceptions.
BUG=653731
Review-Url: https://codereview.chromium.org/2396253002
Cr-Commit-Position: refs/heads/master@{#423759}
Add type casts for KeyframeEffectReadOnly
The following type hierarchy exists in core/animation: KeyframeEffect is a
subclass of KeyframeEffectReadOnly is a subclass of AnimationEffectReadOnly.
Type casts have already been defined to convert AnimationEffectReadOnly objects
to KeyframeEffect objects; this patch adds the equivalent for converting to
KeyframeEffectReadOnly.
Review-Url: https://codereview.chromium.org/2395993002
Cr-Commit-Position: refs/heads/master@{#423758}
Rename a bunch of Mojo Application stuff to reference Services.
. MojoShellConnection -> ServiceManagerConnection
. MojoChildConnection -> ChildConnection
. EmbeddedApplicationRunner -> EmbeddedServiceRunner
. *MojoApplication* -> *Service*
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2398783002
Cr-Commit-Position: refs/heads/master@{#423757}
Linux installer: Add expected_deps*trusty
BUG=564904
Review-Url: https://codereview.chromium.org/2397993003
Cr-Commit-Position: refs/heads/master@{#423756}
Metrics - Add actions/README.md
BUG=
Review-Url: https://codereview.chromium.org/2384323002
Cr-Commit-Position: refs/heads/master@{#423755}
Add an empty Android implementation of the PhysicalWebDataSource
The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.
BUG=636490
Review-Url: https://codereview.chromium.org/2361603002
Cr-Commit-Position: refs/heads/master@{#423754}
Restrict TemplateUrlServiceTest#testLoadUrlService to phones
It frequently fails all three test runs on tablets.
BUG=581268
[email protected]
Review-Url: https://codereview.chromium.org/2400083002
Cr-Commit-Position: refs/heads/master@{#423753}
Roll src/third_party/catapult/ f7d080135..22570732f (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f7d080135d03..22570732fbb1
$ git log f7d080135..22570732f --date=short --no-merges --format='%ad %ae %s'
2016-10-06 benjhayden Finish value-set-table tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2396003003
Cr-Commit-Position: refs/heads/master@{#423752}
Ping watchdog thread during GpuChannel destruction
Currently GpuChannel destruction runs as a single large task in the GPU
process. This can cause watchdog timeouts on very busy systems, as we
can end up doing a huge number of GL commands in a single task.
This change adds logic to ping the watchdog thread at regular intervals
(assuming that destruction is moving forward, and hasn't actually hung).
This should prevent the timeout hangs we're seeing.
In addition to reporting progress in ContextGroup, we also report during
shader, program, and texture deletion, as these are the three cases
where we've actually seen timeouts.
BUG=612219
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2378583003
Cr-Commit-Position: refs/heads/master@{#423751}
chromeos: Add VLOG(1)s around renderer-freezing for suspend.
Add temporary VLOG(1) messages to renderer-freezing code to
try to track down the cause of a strange crash.
BUG=chromium:648580
Review-Url: https://codereview.chromium.org/2395293003
Cr-Commit-Position: refs/heads/master@{#423750}
Removes a data-dependent DCHECK().
This check actually triggered on the wrong condition (hence I also renamed a few things to reduce the confusion).
There was a valid point for the check, though: we should only fill the histogram when we don't get too many snippets.
Once we completely moved to the Zine cloud backend, this histogram should go away anyways.
Review-Url: https://codereview.chromium.org/2387293009
Cr-Commit-Position: refs/heads/master@{#423749}
Queued ClearBlackList() shouldn't use weak pointer.
The queue lives in the target, so the weak pointer is redundant.
BUG=639087
Review-Url: https://codereview.chromium.org/2397783004
Cr-Commit-Position: refs/heads/master@{#423748}
Simplify and add comments to copy-existing-baselines-internal test.
The purpose of this CL is to improve the readability of this test, to
try to better indicate what webkit-patch copy-existing-baselines-internal
does.
Review-Url: https://codereview.chromium.org/2392173002
Cr-Commit-Position: refs/heads/master@{#423747}
Remove GLFrameData from CompositorFrame.
Split GLFrameData out of CompositorFrame. Create a new struct
OutputSurfaceFrame that contains the parts of CompositorFrame need by
OutputSurface::SwapBuffers(). Update OutputSurface implementations to
use the new OutputSurfaceFrame struct instead.
BUG=651851
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2374183006
Cr-Commit-Position: refs/heads/master@{#423746}
Disable ServiceWorker when JS is disabled
This patch restricts the service worker when JavaScript is disabled by checking
the settings in ChromeContentBrowserClient::AllowServiceWorker().
BUG=632823
Review-Url: https://codereview.chromium.org/2377603002
Cr-Commit-Position: refs/heads/master@{#423745}
Update comments on pressing Esc on PlatformVerificationDialog
On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.
Also update comments in DialogDelegate.
[email protected]
BUG=467155,590960
TEST=No functionality change.
Review-Url: https://codereview.chromium.org/2395133003
Cr-Commit-Position: refs/heads/master@{#423744}
Revert of Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices (patchset #1 id:1 of https://codereview.chromium.org/2397573008/ )
Reason for revert:
Root cause is in Android framework, we're just going to catch the exception
Original issue's description:
> Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices
>
> BUG=653685
> [email protected], [email protected]
>
> Committed: https://crrev.com/3988c1fd1bc405d01850a8e5e28619d0630b5184
> Cr-Commit-Position: refs/heads/master@{#423709}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653685
Review-Url: https://codereview.chromium.org/2396243002
Cr-Commit-Position: refs/heads/master@{#423743}
Align IndexedDB metadata rollback on transaction abort to spec.
When an IndexedDB versionchange transaction is aborted, Blink's
IndexedDB metadata is not entirely reverted, causing our behavior to
deviate from the IndexedDB specification in minor, subtle ways. This
change aligns our behavior with the spec and with Firefox's
implementation.
The change also (slightly) reduces IndexedDB memory usage in two ways.
(1) Object store and index metadata is now shared between an IDBDatabase
and its associated IDBObjectStore and IDBIndex instances, instead of
being copied. (2) versionchange transactions only back up the metadata
for object stores that are accessed by JavaScript, instead of creating a
backup for the entire database metadata.
BUG=645018,457447
Review-Url: https://codereview.chromium.org/2314933005
Cr-Commit-Position: refs/heads/master@{#423742}
Do not white list offline archive directory
This is not longer needed after we switch to using offline interceptor
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2395763003
Cr-Commit-Position: refs/heads/master@{#423741}
Web Share: Disable warning when web share is used from incognito.
This was deemed unnecessary in UX review. When navigator.share is used
from incognito, you still see the intent picker which is considered
sufficient warning for users.
The bulk of the code to support this (https://crrev.com/420564) remains
and will be removed in a future CL.
BUG=645007
Review-Url: https://codereview.chromium.org/2389393004
Cr-Commit-Position: refs/heads/master@{#423740}
Add MB config and installer target for an official CrOS builder.
This adds an MB config for 'Linux ChromeOS Buildspec Tests' builder, and makes the 'linux_packages_all' target be defined for CrOS builds as well as desktop Linux, though I have no idea if this'll actually build in that config.
[email protected], [email protected]
BUG=643238
Review-Url: https://codereview.chromium.org/2399883003
Cr-Commit-Position: refs/heads/master@{#423739}
Use high quantizer value for "big" frames after a sequence of "small" frames.
After a sequence of frames that don't saturate bandwidth libvpx always
chooses lowest allowed quntizer (highest quality). As result these frames
are quite big after being encoded, which results in poor response latency
for those frames. With this change the scheduler detects those frames and
sets min_quantizer to 60 to ensure that they are first encoded with low
quality and quality is topped off later.
This change reduces latency for "big" frames in
ProtocolPerfTest.TotalLatencyWebrtc from 500ms to 200ms in 8Mbps case,
even without proper BW estimation.
Also changed frame duration from 66 to 33 ms, to match actual frame
duration (this doesn't seem to have significant effect on quality).
BUG=645656
Review-Url: https://codereview.chromium.org/2381213002
Cr-Commit-Position: refs/heads/master@{#423738}
Remove DownloadProcessService code path
Chrome now uses the browser process for background download resumption.
We don't need a separate process for this, remove the code.
[email protected]
Review-Url: https://codereview.chromium.org/2365093002
Cr-Commit-Position: refs/heads/master@{#423737}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/b5cecfe7c5a9684ea21d08599cbcc85a419dd190 Roll recipe dependencies (trivial). ([email protected])
depot_tools:
https://crrev.com/a3f10315eb5597be73cdfc1a4a1145fe3cc3b541 Roll recipe dependencies (trivial). ([email protected])
recipe_engine:
https://crrev.com/825386b5d616ed1e5fca94ec76eb6de9335b86d2 Add astunparse and update_vendoring. ([email protected])
[email protected],[email protected]
BUG=
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2400843002
Cr-Commit-Position: refs/heads/master@{#423736}
MediaSource: Fix CHECK crash in append fudge room edge case.
This CHECK is hit by MSE users who make a small Remove() of their last
appended frames and then a subsequent Append() as if the previous remove
had not occurred.
The bug will also manifest if users set duration to just under the
current duration - currently equivalent to a small Remove().
Aside: duration truncation will soon be deprecated.
If the initial Remove() is small enough (less than the fudge room),
RemoveInternal() will fail to see this as causing a discontinuity and will
not reset range_for_next_append_. If the next append is beyond the
newly-shortened-range-end + fudge room, then CanAppendToEnd will CHECK.
BUG=627905
TEST=new unit tests, crash gone from (nsfw) http://ck101.com/thread-3559838-1-1.html?ref=banner
Review-Url: https://codereview.chromium.org/2385423002
Cr-Commit-Position: refs/heads/master@{#423735}
Ensure web page clicks off SERP are loaded in Chrome.
SERP will dispatch intents directly to instant apps. If the user clicked
on http/https link on SERP, it should not offer or launch instant apps.
BUG=644772
Review-Url: https://codereview.chromium.org/2397153003
Cr-Commit-Position: refs/heads/master@{#423734}
[Extensions] Convert some ChromeSyncExtensionFunctions
SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.
Remove ChromeSyncExtensionFunctions from:
- tabs
BUG=634140
Review-Url: https://codereview.chromium.org/2398793002
Cr-Commit-Position: refs/heads/master@{#423733}
Converts most of WorkspaceLayoutManager tests to use common code
A couple triggers crashes, which I've filed separately. The keyboard
ones won't work in mash. I plan to move those out of this file
separately.
BUG=624172,652871
TEST=covered by tests
[email protected]
Review-Url: https://codereview.chromium.org/2391153002
Cr-Commit-Position: refs/heads/master@{#423732}
Use GeometryMapper to implement PaintLayerClipper.
BUG=593596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2238883006
Cr-Commit-Position: refs/heads/master@{#423731}
bluetooth: Standardize Bluetooth adapter access in Adapter service.
Every implemented function of the Adapter Mojo service requires a
reference to the system's Bluetooth adapter. Since any function could be called
at any time in the service, the adapter must be available from the creation of
the Adapter service. To satisfy this requirement, a factory pattern has been
implemented to create instances of the Adapter service with the required
reference to a Bluetooth adapter.
BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2379573006
Cr-Commit-Position: refs/heads/master@{#423730}
Do not allow sign in if Google play service is absent
It is bad user experience to show sign in promotions to users who
eventually cannot sign in anyway, because of missing gmscore. This CL
suppresses sign in promotions by checking the availability of gmscore.
BUG=653615
Review-Url: https://codereview.chromium.org/2399183002
Cr-Commit-Position: refs/heads/master@{#423729}
In update-w3c-test-expectations, stage all new files before committing.
Currently, w3c-test-autoroller is blocked on importing
because new baseline files are not added and committed
before uploading. Example of a build where this happens:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7732.
Purpose: This CL would unblock this issue on w3c-test-autoroller.
This would be unnecessary (and could be reverted) if either of
http://crrev.com/2397573002 or http://crrev.com/2396433004 is committed.
BUG=621599
Review-Url: https://codereview.chromium.org/2394913002
Cr-Commit-Position: refs/heads/master@{#423728}
cc: Restructure access to LayerTreeHost in LayerTreeTests.
Move tests to depends on the LayerTreeHost, instead of the InProcess
subclass, in preparation of setting up the framework to have tests
run in remote mode.
There is still an accessor for LayerTreeHostInProcess, only it DCHECKS
that the test is running in threaded or single-threaded mode.
BUG=653371
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2400733002
Cr-Commit-Position: refs/heads/master@{#423727}
arc: bluetooth: Send update to Android when got DeviceChanged event
Currently we only send device properties and advertising data to
Android only when we first found a new device. We should also
update Android when we got DeviceChanged event.
Also refactor the code to
- Add new SendDevice() for common code related to this.
- Filter invalid data out from data that will send to Android.
BUG=653310,b:31916649
TEST=nRF Connect app in minnie correctly show rssi graph
Review-Url: https://codereview.chromium.org/2391973003
Cr-Commit-Position: refs/heads/master@{#423726}
Speculative fix for libPowerStretch.so crash.
Disable View System hardware acceleration to see if users on this specific device
no longer crash in M54.
BUG=651918
Review-Url: https://codereview.chromium.org/2397903003
Cr-Commit-Position: refs/heads/master@{#423725}
Do not show multiple instance of disambiguation menu for TextViewWithClickableSpans
BUG=650852
Review-Url: https://codereview.chromium.org/2387333006
Cr-Commit-Position: refs/heads/master@{#423724}
[ash-md] Erases the pre-MD code path for Overview Mode
This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.
BUG=604767, 614453
TEST=WindowSelectorTest
Review-Url: https://codereview.chromium.org/2401473002
Cr-Commit-Position: refs/heads/master@{#423723}
[layoutng] Refactor NGBox::Layout
Move some of the code into two new functions to make everything more readable.
[email protected],[email protected]
BUG=635619
Review-Url: https://codereview.chromium.org/2400023002
Cr-Commit-Position: refs/heads/master@{#423722}
Use a binding set for BrowserAssociatedInterface
This allows multiple client proxies in a render process to connect
to a single BrowserAssociatedInterface at the same time.
BUG=612500
Review-Url: https://codereview.chromium.org/2400663003
Cr-Commit-Position: refs/heads/master@{#423721}
cc: Set sync token on resource even if context is lost.
If the gpu process crashes the worker context will return null sync
tokens which the resource write lock ignores. It's possible for the
compositor context to not detect the gpu process crash until much later.
Until then the scheduler might initiate a draw which will crash when
DCHECKing that resources being sent have sync tokens.
This CL also enables sync tokens for LayerTreeTests by default and
includes some minor cleanup in LayerTreeHostTestContext.
[email protected],[email protected]
BUG=645736
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2387333003
Cr-Commit-Position: refs/heads/master@{#423720}
Annotate WebappSplashScreenIconTest with @RetryOnFailure
BUG=653701
[email protected]
Review-Url: https://codereview.chromium.org/2396223002
Cr-Commit-Position: refs/heads/master@{#423719}
[Bootstrapping] Introduce an accelerator (Ctrl+Alt+Shift+S) to put a ChromeOS device into Slave OOBE process.
In order to enhance the security and avoid the Bluetooth in-middle attach between
Master and Slave, we've decided to do the followings for a Slave device:
- For devices lacking sufficient input, e.g., Chromebit, keep the state as it is today:
- The ChromeOS device will put itself in Bluetooth discoverable mode in the first
OOBE screen (HID detection screen) and accpet the incoming connection request
from the Bootstrapping app.
- For devices with sufficient input, e.g., Chromebook:
- The ChromeOS device will have Bluetooth disabled by default as in normal OOBE flow
- Upon the user pressing the accelerator (Ctrl+Alt+Shift+S) in the first OOBE screen
(Network screen): the device will put itself in Bluetooth discoveralbe mode and
accept the incoming connection request from the Bootstrapping app.
BUG=652003
Review-Url: https://codereview.chromium.org/2383953002
Cr-Commit-Position: refs/heads/master@{#423718}
Remove (Native)Widget::StackBelow().
This method is never used and is unimplemented on most platforms.
BUG=599570
Review-Url: https://codereview.chromium.org/2399993002
Cr-Commit-Position: refs/heads/master@{#423717}
[mac] Use -[NSApp isActive] for checking if current app is active.
Use short version in RelaunchAppWithHelper() instead of
[[NSRunningApplication currentApplication] isActive]
BUG=650854
Review-Url: https://codereview.chromium.org/2398943002
Cr-Commit-Position: refs/heads/master@{#423716}
Polish Safe Browsing Subresource filter infobar.
1. Both OK and "Load full site" buttons should be present.
2. Infobar should have message and explanation text
BUG=609747
Review-Url: https://codereview.chromium.org/2393813002
Cr-Commit-Position: refs/heads/master@{#423715}
Add @RetryOnFailure to DownloadManagerServiceTest#testInterruptedDownloadAreAutoResumed
BUG=653609
[email protected]
Review-Url: https://codereview.chromium.org/2402533002
Cr-Commit-Position: refs/heads/master@{#423714}
[SPInvalidation] Fix PrePaintTreeWalk for multicol spanner
We should not do anything for the spanner placeholder but just walk the
spanner directly.
Out-of-flow positioned descendants of a multicol spanner need to be
specially handled because their container may be not their ancestor in
the order of PrePaintTreeWalk.
This fixes the following layout tests for slimmingPaintInvalidation:
fast/multicol/dynamic/*spanner*.html
fast/multicol/span/*.html
(except for fast/multicol/dynamic/abspos-multicol-with-spanner-becomes-spanner.html
which is still failing because of some other reason.)
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2388723004
Cr-Commit-Position: refs/heads/master@{#423713}
Skip reflowed comments css/parser for git-blame.
[email protected]
BUG=563793
Review-Url: https://codereview.chromium.org/2396433006
Cr-Commit-Position: refs/heads/master@{#423712}
[Blink, RemotePlayback] Dismissing the dialog rejects with NotAllowedError.
BUG=647441
TEST=manual
Review-Url: https://codereview.chromium.org/2338173005
Cr-Commit-Position: refs/heads/master@{#423711}
Scale Stack Limits in ThreadTest.StartWithOptions_StackSize with Bitness
12 kb may be too small for a 64-bit machine. This allows enough
breathing space for the thread local storage teardown later on.
BUG=590907
Review-Url: https://codereview.chromium.org/2395303002
Cr-Commit-Position: refs/heads/master@{#423710}
Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices
BUG=653685
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2397573008
Cr-Commit-Position: refs/heads/master@{#423709}
Adjust some includes around SVGResourceClient and FilterOperation
Also drop an unused include of ReferenceFilterBuilder.h.
BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2400663002
Cr-Commit-Position: refs/heads/master@{#423708}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/fecd39cfc57157898353120c65b5d3e054451cb8 Remove "Precise" from chromium.fyi builder names ([email protected])
[email protected],[email protected]
BUG=652691
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2401773002
Cr-Commit-Position: refs/heads/master@{#423707}
[net] Remove AuthData from net/base/auth.h.
This is only used in URLRequestFtpJob.
[email protected]
BUG=529319
Review-Url: https://codereview.chromium.org/2398153002
Cr-Commit-Position: refs/heads/master@{#423706}
Increase max saved frames on high-end Android devices
This is a work-around for flickering in CCT for M54. Increasing the
max number of saved frames for high-end devices (>= 3.5 GB memory)
will prevent a flash that comes from bringing a background tab into
the foreground whose frame has been evicted.
BUG=653249
Review-Url: https://codereview.chromium.org/2394113003
Cr-Commit-Position: refs/heads/master@{#423705}
Don't run CaptureScreenshotTest#CaptureScreenshot on low-end devices
This test fails consistently on low-end Android devices.
Return early instead of running the test.
BUG=653637
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2395863004
Cr-Commit-Position: refs/heads/master@{#423704}
DevTools: continue recording network activity after load
BUG=569557
Review-Url: https://codereview.chromium.org/2392553003
Cr-Commit-Position: refs/heads/master@{#423703}
Add LanguageModel, a keyed service that collects language info from CLD.
Before this CL, user's statistics about language detection from the CLD3
library were not accessible to Chrome.
This CL introduces a new keyed service called LanguageModel that
collects such statistics and builds a simple model on top of that. This
allows other parts of Chrome to see top languages in which the user
consumes web content.
A design doc:
https://docs.google.com/a/google.com/document/d/1FBD79CEBUKkMtSJKk3fnF1xnlrXd23z2fHgIGQUFOE8/edit?usp=sharing
BUG=653058
Review-Url: https://codereview.chromium.org/2396783002
Cr-Commit-Position: refs/heads/master@{#423702}
Store physical location in LayoutTableRow, just like in all other objects.
BUG=652496
Review-Url: https://codereview.chromium.org/2399633002
Cr-Commit-Position: refs/heads/master@{#423701}
Early out when setting global root scroller
BUG=505516
Review-Url: https://codereview.chromium.org/2400723002
Cr-Commit-Position: refs/heads/master@{#423700}
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations
Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).
CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.
The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.
BUG=skia:5773
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2391373002
Cr-Commit-Position: refs/heads/master@{#423699}
GN: Initialize Tool::defined_from_ in the constructor
set_defined_from() isn't called in some tests (e.g. those using TestWithScope),
thus calling defined_from() will only yield garbage, likely leading to a crash.
BUG=
Review-Url: https://codereview.chromium.org/2394323002
Cr-Commit-Position: refs/heads/master@{#423698}
Roll src/third_party/catapult/ a2738b137..f7d080135 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a2738b13731a..f7d080135d03
$ git log a2738b137..f7d080135 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 zhenw Update systrace and profile_chrome's default agent behavior
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2395083004
Cr-Commit-Position: refs/heads/master@{#423697}
Reformat comments in core/layout/svg
BUG=563793
[email protected]
Review-Url: https://codereview.chromium.org/2400783002
Cr-Commit-Position: refs/heads/master@{#423696}
[Durable] Updated Durable heuristic to use 'important sites'
This also involves moving the important sites util into a location
visible to the durable storage permission context.
BUG=595433
Review-Url: https://codereview.chromium.org/2393103002
Cr-Commit-Position: refs/heads/master@{#423695}
Disable BidirectionalStreamTest#testFailures
It's flaky, with more failures than not, because of new checks added in
a CL from earlier today. Disabling for now, to be fixed for real
tomorrow.
BUG=653654
Review-Url: https://codereview.chromium.org/2398273002
Cr-Commit-Position: refs/heads/master@{#423694}
Add comment to GetSourceProfile.
This is a followup to https://codereview.chromium.org/2372323003/.
BUG=590068
Review-Url: https://codereview.chromium.org/2398223003
Cr-Commit-Position: refs/heads/master@{#423693}
Enables delegating signal strategy for It2Me Host.
Motivation:
Allow the It2me host to delegates signaling messages sending/receiving
via native messaging.
Summary of changes:
- Add a new flag useSignalingProxy on the connect message for
com.google.chrome.remote_assistance.
- Move delegating_signal_strategy from the plugin directory to the
signaling directory so that it can be shared by the client and the
host
- Change the threading behavior of delegating_signal_strategy so that
the delegate and the listener can be run on two different threads.
Review-Url: https://codereview.chromium.org/2384063008
Cr-Commit-Position: refs/heads/master@{#423692}
Move GIF decoder's aggressive purge into ImageDecoder
Other animated image formats should have the same aggressive purge
behavior.
So move it out of the GIF decoder and into ImageDecoder.
BUG=651666
Review-Url: https://codereview.chromium.org/2376033005
Cr-Commit-Position: refs/heads/master@{#423691}
Delete pre-MD code from OmniboxResultView
BUG=648281
Review-Url: https://codereview.chromium.org/2365263006
Cr-Commit-Position: refs/heads/master@{#423690}
Adjust shadow and stroke of MdTextButton.
Also fix the appearance of the "Show All" button on the download shelf when using custom themes (this regressed at some point in M55, as it works properly in my M54 build).
BUG=647047
Review-Url: https://codereview.chromium.org/2400563004
Cr-Commit-Position: refs/heads/master@{#423689}
Fixing repeated pixels when drawing HTML5 video to canvas.
When the coded size of the video frame is different from the visible
rect, SkCanvasVideoRenderer::Paint tries to scale the video while it
must ignore the pixels outside visible rect. This is addressed by
clipping the SkImage object created from VideoFrame prior to painting
the frame on the canvas.
BUG=611330
Review-Url: https://codereview.chromium.org/2369093002
Cr-Commit-Position: refs/heads/master@{#423688}
Revert of DevTools: archive content shell (patchset #1 id:1 of https://codereview.chromium.org/2383043003/ )
Reason for revert:
This broke the chromium build archive crbug.com/653406
Original issue's description:
> DevTools: archive content shell
>
> Creates an archive of the content shell for each desktop platform.
> This will enable external contributors to use a precompiled
> content shell to run devtools layout tests (and possibly others).
>
> I manually verified these files are needed to run devtools layout tests
> with the content shell.
>
> BUG=none
>
> Committed: https://crrev.com/baf98fcec2132efbdf404f9dff40de42703b65bf
> Cr-Commit-Position: refs/heads/master@{#423195}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2399173002
Cr-Commit-Position: refs/heads/master@{#423687}
[Android] Permanently disable "All bookmarks" and remove its experiment
This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks" (d7e42ebb7ffab7b19303abc69bcec577938ad8ea)
2. Make "All Bookmarks" to be controlled by feature" (b8a3ebb9e0ed8f14db3182991fd1cec16ba43339)
3. "Add an about flag to toggle the visibility of "All bookmarks"" (d37c3af126cb22a7831032b22a7c24bb2628c4bc)
4. "Revert "Remove all bookmark section from bookmark manager"" (837a30e53b89b813b463953238ce24272c48c58a)
BUG=605614
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2394273002 .
Cr-Commit-Position: refs/heads/master@{#423686}
Revert of Use FileDescriptorWatcher in AlarmTimer. (patchset #2 id:20001 of https://codereview.chromium.org/2398753003/ )
Reason for revert:
This CL is causing a memory leak in the unit tests:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16728
failures:
AlarmTimerTest.RetainNonRepeatIsRunning
AlarmTimerTest.MessageLoopShutdown
AlarmTimerTest.NonRepeatIsRunning
AlarmTimerTest.RetainRepeatIsRunning
Sample report:
Direct leak of 152 byte(s) in 1 object(s) allocated from:
#0 0xab8ebb in operator new(unsigned long) (/b/swarm_slave/w/irlnnUGq/out/Release/components_unittests+0xab8ebb)
#1 0x9eba8fd in MakeUnique<base::FileDescriptorWatcher::Controller::Watcher, base::WeakPtr<base::FileDescriptorWatcher::Controller>, base::MessageLoopForIO::Mode &, int &> base/memory/ptr_util.h:56:29
#2 0x9eba8fd in base::FileDescriptorWatcher::Controller::Controller(base::MessageLoopForIO::Mode, int, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/files/file_descriptor_watcher_posix.cc:159
#3 0x9ebb293 in base::FileDescriptorWatcher::WatchReadable(int, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/files/file_descriptor_watcher_posix.cc:198:25
#4 0xe0016a3 in timers::AlarmTimer::Reset() components/timers/alarm_timer_chromeos.cc:103:25
#5 0x515b488 in timers::AlarmTimerTest_RetainRepeatIsRunning_Test::TestBody() components/timers/alarm_timer_unittest.cc:310:9
Original issue's description:
> Use FileDescriptorWatcher in AlarmTimer.
>
> FileDescriptorWatcher is a new API that replaces
> MessageLoopForIO::WatchFileDescriptor.
>
> This CL also gets rid of the base::Thread created in the anonymous
> namespace of alarm_timer_chromeos.cc. The FileDescriptorWatcher
> API is supported by every TaskScheduler thread. Very soon, most
> tasks in Chrome will run in TaskScheduler. Therefore, there is no
> reason to create a base::Thread to allow AlarmTimer to be used from
> threads that don't support the FileDescriptorWatcher API.
>
> BUG=645114
>
> Committed: https://crrev.com/8e17d7e9031b7e2e58473fe66a399943051357f0
> Cr-Commit-Position: refs/heads/master@{#423617}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645114
Review-Url: https://codereview.chromium.org/2394333002
Cr-Commit-Position: refs/heads/master@{#423685}
Auto-rebaseline for r423638
https://chromium.googlesource.com/chromium/src/+/bd1529c0d
BUG=649760
[email protected]
Review URL: https://codereview.chromium.org/2396203002 .
Cr-Commit-Position: refs/heads/master@{#423684}
Roll src/third_party/pdfium/ ca03f7a1c..3a0a808ff (4 commits).
https://pdfium.googlesource.com/pdfium.git/+log/ca03f7a1c654..3a0a808ff546
$ git log ca03f7a1c..3a0a808ff --date=short --no-merges --format='%ad %ae %s'
2016-10-06 kcwu Fix assertion failure when decoding malform G4 fax image
2016-10-06 kcwu Reject JBig2 Huffman table with too large shift value
2016-10-06 npm Split m_InstalledTTFonts into two vectors to avoid sketchy logic.
2016-10-06 caryclark switch to new skia blend mode enum class
BUG=653044
[email protected]
Review-Url: https://codereview.chromium.org/2395263002
Cr-Commit-Position: refs/heads/master@{#423683}
Revert "[Custom Tabs] Implement "Read It Later" Behind a Flag"
This reverts commit ea63767b61ae1a8935b420685bbee58467b68b5b, which
represents a feature that was disabled in M54 via field trial.
BUG=620535
[email protected]
Review-Url: https://codereview.chromium.org/2393993005
Cr-Commit-Position: refs/heads/master@{#423682}
Add a task_scheduler tracing category which will record an extra event per task.
That event will contain ExecutionMode/SequenceToken and TaskPriority.
It would be better to tack an optional extra arg to the main task event but
tracing doesn't currently allow this (http://crbug.com/652692).
BUG=649084
Review-Url: https://codereview.chromium.org/2392903002
Cr-Commit-Position: refs/heads/master@{#423681}
[layoutng] margin: auto support
Add an ApplyAutoMargin function in ng_length_utils and use that from
ng_block_layout_algorithm.
I did not add it to computeMargins because not all callers should take
margin: auto into account. In particular, a child's width: auto computation
needs to treat margin: auto as zero (and, at any rate, does not have a fragment
available yet).
[email protected],[email protected]
BUG=635619
Review-Url: https://codereview.chromium.org/2399963002
Cr-Commit-Position: refs/heads/master@{#423680}
Remove TestWebKitPort from port_testcase.
This removes TestWebKitPort (as suggested by a FIXME in the code)
and replaces each use with different Port subclasses. For the
most part this is straightforward, except for a few test methods.
Notes:
- Previously, test_path_to_apache_config_file just tested the logic
in the base Port class, but Port subclasses have different behavior,
so more specific test methods could be added in test case subclasses.
- The test_apache_config_file_name_for_platform method was testing
behavior in the base Port class which didn't make sense to repeat
for port subclasses, so I moved it to base_unittest.
Review-Url: https://codereview.chromium.org/2392683003
Cr-Commit-Position: refs/heads/master@{#423679}
HSTS preload list removals for Chrome 55.
eyyit.com:
> I jumped the gun on hsts preloading and now have a subdomain that needs to
> read xml feeds from non-https sites. This HSTS preload including subdomains
> broke that. Instead of waiting for the feeds to update their site to https,
> I'd rather get the removal process started soon so I have some options.
svallee.fr:
> • home.svallee.fr (many services, not all with HTTPS available)
vjirovsky.cz:
> axure.vjirovsky.cz – it’s branded (CNAME) version of axshare.com and they are
> not able to have certificate for axure.vjirovsky.cz
tradeacademy.in:
> list.tradeacademy.in -> We are using this domain for our newsletter
> application & we don't have Wildcard SSL certificate so whenever we open
> list.tradeacademy.in it goes to HTTPS in chrome.
almeria.fr:
> store.almeria.fr – problem with our website supplier
almeria-si.fr:
> store.almeria-si.fr – this site is managed by a partner, and we are not ready
> to migrate to https.
vozp.cz:
> • maps.vozp.cz – subsite dont using SSL
> • intranet.vozp.cz – internal application
> • helpdesk.vozp.cz – internal application
zen-trader.com:
> We cannot support HTTPS on the following subdomains:
> • status - Not under our control (third party server)
> • email - Not under our control (third party server)
> • clk - Not under our control (third party server)
> • mailsrv - Not under our control (third party server)
bratteng.me:
> dell.bratteng.me - some of the ports other than 80 and 443 does not support
> https yet
soleus.nu:
> We are a non-profit hosting association, and almost all subdomains are
> assigned to members (with their own vps and hosting services).
chrishamper.com:
> I had enabled the HSTS header with the "preload" directive on my domain while
> following an online guide related to HSTS, which didn't explain the meaning or
> repercussions of that directive. It is now causing much trouble when
> attempting to do development work using subdomains I'm spinning up as needed.
elisa.ee:
> tanama.elisa.ee – it needs to be opened with HTTP
mijailovic.net:
> • www.mijailovic.net - I’m moving my website from custom server to GitHub
> pages, but GitHub doesn’t support https on their custom subdomains.
skyo.com:
> • Skyo.com/api/ - Most Clients using API part of our site only support weak
> SSLv3 or dont support SSL/TLS at all. This had a huge impact on our business
> and we have found temporary ways around this until we can get off the preload
> list. We eventually will add the main site, skyo.com (www.skyo.com), back to
> HSTS but our backend Admin and API sections we will avoid the change due to
> too many clients not running modern systems.
mitell.jp:
> • [staging.mitell.jp, test.mitell.jp] - They are for test and our project
> cannot apply SSL for test sites.
callcap.com:
> We have several callcap.com subdomains that are used internally only that
> cannot work with HTTPS. The preload directive was configured by mistake on our
> webservers but has since been removed.
BUG=527947
[email protected]
Review URL: https://codereview.chromium.org/2306423004 .
Cr-Commit-Position: refs/heads/master@{#423678}
Remove the "chromium" port name and --chromium platform option.
Review-Url: https://codereview.chromium.org/2398823002
Cr-Commit-Position: refs/heads/master@{#423677}
MacViews: Emit OnNativeWidgetDestroying() before clearing the
NSWindowDelegate.
Currently the NSWindowDelegate is cleared beforehand, which
means observers of OnWidgetDestroying() are unable to use
GetWidgetForNativeWindow(). This is a problem during closure of
the browser window because inactive tabs are reattached when they
become active due to the active tab being closed. This results in a
DCHECK in NativeViewHostMac::AttachNativeView().
To fix, clear the NSWindowDelegate in the method
BridgedNativeWidget calls on NativeWidgetMac which deletes the
BridgedNativeWidget instance (i.e. just after emitting
OnNativeWidgetDestroying()).
[email protected]
BUG=604628
Review-Url: https://codereview.chromium.org/2375903002
Cr-Commit-Position: refs/heads/master@{#423676}
ChromeOS: disable MD OOBE by default.
BUG=604119
TEST=none
Review-Url: https://codereview.chromium.org/2399163002
Cr-Commit-Position: refs/heads/master@{#423675}
Landing Recent QUIC changes until 3:24 PM, Oct 01, 2016 UTC-4
Record a QUIC packet as received once it's been decrypted, instead of waiting for it to be fully processed. Protected by FLAGS_quic_receive_packet_once_decrypted.
Merge internal change: 134893437
https://codereview.chromium.org/2388153005/
Rename QuicSpdyStream::MarkTrailersDelivered to MarkTrailersConsumed. No behavior change.
Merge internal change: 134828057
https://codereview.chromium.org/2399543002/
Remove unused "bytes" argument from QuicReceivedPacketManager::RecordPacketReceived. No functional change, not flag protected.
Merge internal change: 134709757
https://codereview.chromium.org/2391933005/
Deprecate FLAGS_quic_send_scfg_ttl
Merge internal change: 134688122
https://codereview.chromium.org/2394903002/
Deprecate FLAGS_quic_better_last_send_for_timeout
Merge internal change: 134622401
https://codereview.chromium.org/2396833002/
Adds QUIC_TOO_MANY_SESSIONS_ON_SERVER error code.
Merge internal change: 134538917
https://codereview.chromium.org/2393943002/
Move the logic from SendAlgorithmInterface::RetransmissionDelay() into QuicSentPacketManager, because it's identical for all send algorithms. No functional change, not flag protected.
Merge internal change: 134467054
https://codereview.chromium.org/2393933002/
StringPiece will be replaced with std::string_view. std::string_view doesn't have starts_with.
Merge internal change: 134445920
https://codereview.chromium.org/2399473003/
short circuit QUIC packets to packet buffer if there is already a CHLO on same connection buffered there. Protected by FLAGS_quic_buffer_packets_after_chlo.
Merge internal change: 134431904
https://codereview.chromium.org/2390773005/
Conversion of a QUIC method to an async signature and resulting fallout. No functional change intended, not flag-protected.
Merge internal change: 134406963
https://codereview.chromium.org/2397513002/
Add a QUIC connection option to use a more conservative handshake retransmission timer. Protected by ENABLED FLAGS_quic_conservative_handshake_retransmits.
Merge internal change: 134348006
https://codereview.chromium.org/2392093002/
Negotiate token binding version 0.10 in QUIC crypto.
Merge internal change: 134333443
https://codereview.chromium.org/2392053002/
BUG=
Review-Url: https://codereview.chromium.org/2391103003
Cr-Commit-Position: refs/heads/master@{#423674}
Add a variable use_system_xcode to GN.
Start plumbing it through to actions that require binaries from the Xcode
toolchain.
BUG=651267
[email protected]
Review-Url: https://codereview.chromium.org/2388063003
Cr-Commit-Position: refs/heads/master@{#423673}
Reland "components/arc: implement multi advertising"
This plumbs through multi advertising capabilities for the
instance. Instances can register and unregister advertisements.
Now with virtual destructors to prevent memory leaks in the
StructTraits conversion.
BUG=637171,653338
TEST=use nrf connect on remote device and verify that packets
registered from the instance are visible on the remote device,
run tests with ASAN/LSAN turned on and verify there are no
memory errors
Review-Url: https://codereview.chromium.org/2394683007
Cr-Commit-Position: refs/heads/master@{#423672}
Fix performance regression and bug with hide_scrollbars setting.
FrameView and PaintLayerScrollableArea may perform more work than
necessary if hide_scrollbars is true (e.g. trigger unnecessary
layouts), because they think that scrollbar existence has changed
even if it didn't.
For FrameView, we can avoid this by enforcing hide_scrollbars
in computeScrollbarExistence instead. For PLSA, we check for
hide_scrollbars in updateAfterLayout to determine if the
scrollbar existence will change.
Also fixes another potential bug in PLSA, which may incorrectly
assume existence of scrollbars if hide_scrollbars is true.
BUG=652317,639806
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2394163002
Cr-Commit-Position: refs/heads/master@{#423671}
Reformat comments in core/layout/svg/line
BUG=563793
[email protected]
Review-Url: https://codereview.chromium.org/2391693004
Cr-Commit-Position: refs/heads/master@{#423670}
WebGL CTS: remove fixed Linux Intel ANGLE expectations
[email protected]
BUG=angleproject:1492
BUG=chromium:634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2397213002
Cr-Commit-Position: refs/heads/master@{#423669}
Fix compile for vr_shell/ui_scene_unittest.cc
BUG=653668
TEST=built the test
Review-Url: https://codereview.chromium.org/2394223003
Cr-Commit-Position: refs/heads/master@{#423668}
Allow variations controls for the time banners are suppressed after ignore/dismiss.
This CL implements variations querying and control for the number of
days after an app banner is dismissed or ignored that the banner will
not be shown for that site.
BUG=653339
Review-Url: https://codereview.chromium.org/2397043002
Cr-Commit-Position: refs/heads/master@{#423667}
DrMemory: Avoid capture with no capture callback set
ScheduleNextFrame() has several entry points. Ensure capture
timer is not set with no valid callback.
BUG=
Review-Url: https://codereview.chromium.org/2398993004
Cr-Commit-Position: refs/heads/master@{#423666}
Fix a DCHECK failure in AppBannerManager when adding to homescreen from devtools.
If the desktop browser is opened to a banner-eligible PWA, and then
"Add to homescreen" is run from the Devtools "Application" tab, a DCHECK
failure in HostContentSettingsMap is triggered. The cause of this is a
null validated_url; this variable is usually set in
AppBannerManager::DidFinishLoad, but this will not run since banners are
disabled by default on desktop and triggering add to homescreen manually
creates the AppBannerManager after DidFinishLoad is run.
This CL fixes the issue by manually setting the validated_url when the
banner pipeline begins if it is null. This bug should only manifest
itself in this exact instance; enabling banners via
chrome://flags#enable-add-to-shelf ensures that the AppBannerManager is
created.
BUG=None
TEST=Disable "Add to shelf" in chrome://flags in a desktop Chrome
instance. Navigate to a banner-eligible site, open Devtools, and trigger
"Add to homescreen" from the "Application" tab. No crash should happen
and the add to shelf banner should be seen.
Review-Url: https://codereview.chromium.org/2392313003
Cr-Commit-Position: refs/heads/master@{#423665}
Simplify the text in the external protocol confirmation dialog.
The external protocol handler dialog currently presents users with
a very large amount of jargon-filled text. This CL simplifies the dialog
down to just a title containing the app name and the existing checkbox.
On Windows 7 and earlier, the registry is queried for an app path,
which is displayed in the dialog. This CL modifies the query to
retrieve a program name from the app path, falling back to just
the executable name if the retrieval doesn't succeed.
A new histogram to log the number of times users check the
checkbox in the dialog is also added.
BUG=601725
Review-Url: https://codereview.chromium.org/2076253002
Cr-Commit-Position: refs/heads/master@{#423664}
Revert "Mojoify FetchEvent of Service Worker."
This reverts commit bdc8e1e4477f7dcd911528720a50d639be6d39b5.
This is a top crasher that's blocking release.
BUG=653403
[email protected]
Review-Url: https://codereview.chromium.org/2399903003
Cr-Commit-Position: refs/heads/master@{#423663}
Don't pass unused options on to webkit-patch copy-existing-baselines-internal.
This shouldn't result in any change in behavior. The purpose of this
CL is to make it clearer what arguments may be used by
copy-existing-baselines-internal and which aren't.
Review-Url: https://codereview.chromium.org/2395633002
Cr-Commit-Position: refs/heads/master@{#423662}
Re-land Reformat comments in core/layout up until LayoutBox
This reverts commit 64f8e6ee53f1542634b9bb32cc84f2e24356fee3.
BUG=563793
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2398623003
Cr-Commit-Position: refs/heads/master@{#423661}
Initial definition of HeliumSyncManager and SyncRegistration objects.
This CL contains an abstract interface for SyncManager and a private
class skeleton SyncManagerImpl with the method bodies stubbed out.
[email protected],[email protected]
[email protected]
BUG=650469
Review-Url: https://codereview.chromium.org/2377873002
Cr-Commit-Position: refs/heads/master@{#423660}
Add zpeng@ to banners WATCHLISTS
Review-Url: https://codereview.chromium.org/2400683002
Cr-Commit-Position: refs/heads/master@{#423659}
[Win] Count number of distinct certificates covering third party modules.
The real cost in validating signed modules is validating individual certificates. Since many certificates are provided en masse by catalogs, this counts catalogs as providing a single certificate.
BUG=617176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2384413004
Cr-Commit-Position: refs/heads/master@{#423658}
cc: Replace viewport/clip rect with a viewport size for DirectRenderer
The viewport rect is always at 0,0 and the clip rect is always the
viewport rect now that WebView does external viewport/clip things via
embedding a SurfaceDrawQuad into another surface. So express this in
the code.
[email protected]
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2399713003
Cr-Commit-Position: refs/heads/master@{#423657}
EME: Check capabilities provided only on success
As some applications are providing multiple configurations for
compatability with previous versions, only check that at least
one capability is provided on success, as that is likely to fail
once Chrome starts following the EME spec strictly. This also
avoids the problem of counting both success and failure for the
same configuration (if multiple configs were provided).
BUG=616233
TEST=encrypted media layout tests pass
Review-Url: https://codereview.chromium.org/2397543002
Cr-Commit-Position: refs/heads/master@{#423656}
Harmony - Increase bubble/dialog border stroke opacity
BUG=652467
Review-Url: https://codereview.chromium.org/2399113002
Cr-Commit-Position: refs/heads/master@{#423655}
Roll src/third_party/catapult/ 6723c79f0..a2738b137 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6723c79f0772..a2738b13731a
$ git log 6723c79f0..a2738b137 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 dtu [code health] Move request_handler.py and xsrf.py into common/.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2387113007
Cr-Commit-Position: refs/heads/master@{#423654}
cros: Use PIN instead of Pin in localization.
BUG=653289
TBR=grt
Review-Url: https://codereview.chromium.org/2394163003
Cr-Commit-Position: refs/heads/master@{#423653}
Remove redundant check for whether WebappInfo#id or WebappInfo#uri are null
WebappInfo#create() returns null if either the id or the uri are null
BUG=None
Review-Url: https://codereview.chromium.org/2386383002
Cr-Commit-Position: refs/heads/master@{#423652}
Eliminate use of StringPiece(nullptr, n) with non zero n.
This CL lands server change 135025499 by rogeeff.
BUG=488484
Review-Url: https://codereview.chromium.org/2400463002
Cr-Commit-Position: refs/heads/master@{#423651}
cc: Remove SurfaceSize from OutputSurface.
SurfaceSize is no longer needed that the external viewport is always
at 0,0 and no output surfaces override the size returned there except
cc unittests. So make them stop and remove the getter.
This kinda points out that GLFrameData's size is redundant with the
size given to Reshape. For now I'm DCHECKing that they are the same
to document (and confirm) this.
Also adds DCHECKs that the viewport rect is at 0,0 and the clip rect
given to DirectRenderer matches the viewport rect since that is what
Display does now. Followups can remove code to not need DCHECKs.
[email protected]
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2392183003
Cr-Commit-Position: refs/heads/master@{#423650}
Fix BidirectionalStreamTest#testFailures
Response start can be null or non-null in
BidirectionalStream.Callback#onStreamReady() step.
[email protected]
BUG=653654
Review-Url: https://codereview.chromium.org/2400803002
Cr-Commit-Position: refs/heads/master@{#423649}
VrShell: Split HTML UI Javascript into UI and support portions.
With this change, we have:
- A native API Javascript module, hiding details of the Native API.
- A scene helper class, to manage adding and removing elements and
animations.
- The remaining UI Javascript.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2392683002
Cr-Commit-Position: refs/heads/master@{#423648}
Build: Use wget instead of curl to download sysroots
[email protected]
BUG=650482
Review-Url: https://codereview.chromium.org/2398633004
Cr-Commit-Position: refs/heads/master@{#423647}
Use Unicode in Format{Origin,URL}forSecurityDisplay
Use Unicode instead of punycode for 'host' part of URL
in Format{Origin,URL}ForSecurityDisplay. This would only change
the way IDN(internationalized domain name) is displayed.
To be very conservative, continue to use punycode if there's any RTL
characters in the domain name. See the bug for more details on this issue.
Besides, change IDNToUnicode() to accept StringPiece instead of
|const string&|.
BUG=650760
TEST=components_unittests --gtest_filter=Format*Security*
Review-Url: https://codereview.chromium.org/2375803002
Cr-Commit-Position: refs/heads/master@{#423646}
Unwind WebRTC DTLS 1.2 flag and field trial.
DTLS 1.2 shipped some time ago and the control field
trials have expired. This should no longer be needed.
BUG=
Review-Url: https://codereview.chromium.org/2385623003
Cr-Commit-Position: refs/heads/master@{#423645}
Revert of 📰 Spacing and fixes for the sign in promo (patchset #2 id:20001 of https://codereview.chromium.org/2396863003/ )
Reason for revert:
Reverting due to test failures in chrome_public_test_apk
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36518
failures:
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility
Original issue's description:
> [NTP Client] Spacing and fixes for the sign in promo
>
> - Fixes an exception when only the sign in promo is present on the NTP
> and we attempt to make it peek
>
> - Adds 20dp space between the promo and the status card if present
>
> - Fixes to the bottom space calculation related to the dismissal of
> sibling elements.
>
> Preview: https://goo.gl/photos/94hhXK5rygGamFqt7
>
> BUG=649670,652578
>
> Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
> Cr-Commit-Position: refs/heads/master@{#423525}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649670,652578
Review-Url: https://codereview.chromium.org/2399983002
Cr-Commit-Position: refs/heads/master@{#423644}
Roll ANGLE d08f3b3..873d00f
https://chromium.googlesource.com/angle/angle.git/+log/d08f3b3..873d00f
BUG=chromium:653274,chromium:651493,chromium:653276,chromium:593024,chromium:634525
[email protected]
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2399933002
Cr-Commit-Position: refs/heads/master@{#423643}
cros: Small tweaks to palette behavior.
Update laser icon color and automatically close the palette when enabling the magnifier or laser.
BUG=645312
Review-Url: https://codereview.chromium.org/2368713002
Cr-Commit-Position: refs/heads/master@{#423642}
arc: bluetooth: Use uuid 128 bit for service uuid
We used 128 bit uuid for service uuid before. However this
caused buffer overflow problem when encounter with multiple
16 bit uuid for this field as the length of advertising data
would exceed the limit.
We mitigated that by forcing the service uuid to be 16 bit.
But this break the device that decide to advertised custom
128 bit uuids.
This CL properly fixes the above problems by send 128 bit
uuid to Android and let Android side deal with the overflow
problem.
BUG=653310,b:28670943
TEST=Android side can see 128 bit service uuid
Review-Url: https://codereview.chromium.org/2376873002
Cr-Commit-Position: refs/heads/master@{#423641}
Roll src/third_party/pdfium/ f7ca7302b..ca03f7a1c (1 commit).
https://pdfium.googlesource.com/pdfium.git/+log/f7ca7302bed8..ca03f7a1c654
$ git log f7ca7302b..ca03f7a1c --date=short --no-merges --format='%ad %ae %s'
2016-10-06 dsinclair Fixup MSan embeddertests
[email protected]
Review-Url: https://codereview.chromium.org/2394283002
Cr-Commit-Position: refs/heads/master@{#423640}
Do not de-select text across continuations
When determining the end position for a selection ending on a
continuation's margin, we would incorrectly de-select all content
below the continuation's containing block.
This affects sites like hackernews, such as selecting text in:
https://news.ycombinator.com/item?id=347261
This patch is a buy-one-get-one-free with two fixes in one patch (both
fixes are required):
1) Continuations should be tested immediately because ancestors of a
continuation will not check them. In LayoutInline::positionForPoint, we
need to check our continuations first, before an early return, because
the containing block will not return to test the continuations.
2) Continuations do not need an adjustment for their position to
"translate the coords from the pre-anonymous block to the post-anonymous
block." This code was not tested and seems wrong because the point is
already in the correct coordinate space.
Here's an example of a layout tree dump (included as a new test as well):
LayoutView
LayoutBlockFlow
LayoutBlockFlow (anonymous)
LayoutInline continuation=(next block flow) FONT
LayoutText #text "AAAAAAAAAA"
LayoutBlockFlow (anonymous) continuation=(next sibling block flow)
LayoutBlockFlow P
LayoutText #text "BBBBBBBBBB"
LayoutBlockFlow P
LayoutText #text "CCCCCCCCCC"
LayoutBlockFlow (anonymous)
LayoutInline FONT
This patch is solving a bug when selecting from the beginning of AA...AA
to the margin between BB...BB and CC...CC. Before this patch, BB...BB
would not be selected.
BUG=468497
Review-Url: https://codereview.chromium.org/2398583002
Cr-Commit-Position: refs/heads/master@{#423639}
Mark children of an SVG root as needing paint invalidation checking on resize.
BUG=649760
Review-Url: https://codereview.chromium.org/2397003002
Cr-Commit-Position: refs/heads/master@{#423638}
Revert "Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy"
This reverts commit c42c0dddcb3c630cb30096d16a4485bd1025eccc.
Reason:
The PolicyTest.ForceSafeSearch test is failing on Windows bots.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/53375
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590478
Review URL: https://codereview.chromium.org/2401733002 .
Cr-Commit-Position: refs/heads/master@{#423637}
Refactoring startup logic for upcoming FRE changes (non-Win 10).
Refactor goals (in descending order):
1. Consolidate the various places throughout startup where onboarding and other special-case tabs are added.
2. Reduce the massive number of branches, spaghetti calls, and seemingly-redundant checks into a manageable, linear flow.
3. Offload all policy logic (e.g., "Should we show the Welcome page?") for FRE to the more-appropriate first_run directory.
4. Where possible, consolidate code into testable units.
BUG=618454, 248883, 517248
Review-Url: https://codereview.chromium.org/2164033002
Cr-Commit-Position: refs/heads/master@{#423636}
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake.
BUG=650925
TBR=sadrul
Review-Url: https://codereview.chromium.org/2394483006
Cr-Commit-Position: refs/heads/master@{#423635}
[Android] Don't pass adb path to sharded perf tests.
BUG=652250
Review-Url: https://codereview.chromium.org/2392423002
Cr-Commit-Position: refs/heads/master@{#423634}
Move PathUtils to use ContextUtils.
PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.
BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2333713003
Cr-Commit-Position: refs/heads/master@{#423633}
Remove ink drop highlight for Ash MD SystemMenuButton
Remove the ink drop highlight (hover) effect for the
system menu buttons used in Ash material design
(--ash-md=experimental) for design review. Also
update the base color of the ripple effect to black.
BUG=649734
TEST=manual
Review-Url: https://codereview.chromium.org/2401623003
Cr-Commit-Position: refs/heads/master@{#423632}
DrawingBuffer cleanup: Part 1 of many
DrawingBuffer is actually a buffer queue that recycles buffers.
This buffer queue shrinks the recycle queue when it is asked to
pull an element from the recycle queue. It makes more sense to
do this when the elements are put in the recycle queue.
The buffer queue also has a function to resize a recycled
buffer, instead of just deleting it and creating a new one (perhaps
under the idea the creating and destroying GL texture names
is expensive). Remove this functionality because it just complicates
things.
While we're in the neighborhood, inline the resize functions for
the multisample and depth and stencil functions (there's no point
to having a short helper function that is called in only one place,
it gives a feeling of more generality than actually exists).
BUG=648707
Review-Url: https://codereview.chromium.org/2399733002
Cr-Commit-Position: refs/heads/master@{#423631}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/fcac5b2bfcde27d33f34960c44066b976ee2006e Make clusterfuzz_archive include llvm-symbolizer and sancov. ([email protected])
[email protected],[email protected]
BUG=636168
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2396173002
Cr-Commit-Position: refs/heads/master@{#423630}
Add BlimpDocument, pull out functions in BlimpCompositor.
Previously BlimpCompositor is heavy weight class that also include
render_widget_id and input manager, and we have the following ownership:
BlimpContentImpl -> BlimpCompositorManager -> BlimpCompositor.
This CL:
1. Rename BlimpCompositorManager to BlimpDocumentManager.
2. Add BlimpDocument, which owns a BlimpCompositor. It matches the idea
of helium document. So more feature with document scope can goes in
this layer.
3. Unit test for new class, and also rename old unit tests.
The ownership chains now become the following:
BlimpContentImpl->BlimpDocumentManager->BlimpDocument->BlimpCompositor.
BUG=644326
Review-Url: https://codereview.chromium.org/2382733007
Cr-Commit-Position: refs/heads/master@{#423629}
Force-enable Sync for Supervised users on Android.
BUG=650699
Review-Url: https://codereview.chromium.org/2391293003
Cr-Commit-Position: refs/heads/master@{#423628}
Make apk_merger.py use hermetic timestamps.
This ensures two runs of the merger with same inputs results in the same
outputs.
Review-Url: https://codereview.chromium.org/2400693002
Cr-Commit-Position: refs/heads/master@{#423627}
Roll src/third_party/catapult/ 3c58b62cb..6723c79f0 (4 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3c58b62cb24c..6723c79f0772
$ git log 3c58b62cb..6723c79f0 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 aiolos Update android chrome reference builds.
2016-10-06 hjd [tracing] Preserve sort column in heap breakdown
2016-10-06 alexandermont Turn on keyword-spacing in eslint and fix existing keyword-spacing errors.
2016-10-06 dtu [pinpoint] Pure Python implementation of Mann-Whitney U.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2394263002
Cr-Commit-Position: refs/heads/master@{#423626}
[SPInvalidation] Enable LayoutEmbeddedObject paint invalidation in new path
This fixes plugins/webview-plugin-lifecycle.html and
plugins/webview-plugin-nested-iframe-scroll.html
for slimmingPaintInvalidation.
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2393043002
Cr-Commit-Position: refs/heads/master@{#423625}
cc: Handle more cases in TransformOperations::ScaleComponent
TransformOperations::ScaleComponent currently only handles combinations
of translations and at most a single scale operation. This CL adds
support for all operations that don't include perspective, including
TransformOperations that have multiple scale operations.
BUG=561153
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2397903002
Cr-Commit-Position: refs/heads/master@{#423624}
Add a DOM.getLayoutTreeNodes devtools command
This command will help Headless API users understand the layout
of the page.
BUG=546953
Review-Url: https://codereview.chromium.org/2346853002
Cr-Commit-Position: refs/heads/master@{#423623}
Restrict UrlBarTest#testDelayedCompositionCorrectedWithAutocomplete to non-low-end devices
BUG=635714
[email protected]
Review-Url: https://codereview.chromium.org/2401693002
Cr-Commit-Position: refs/heads/master@{#423622}
BlobDispatcherHost: don't rely on NOTREACHED() checks in ParamTraits::Read
Explicitly handle all possible storage::DataElement cases, and add comments
explaining the purpose of existing security checks.
BUG=644966
TEST=content_browsertests
Review-Url: https://codereview.chromium.org/2378253002
Cr-Commit-Position: refs/heads/master@{#423621}
net: remove ExplicitUserRequest() method from URLRequestThrottlerEntry
This load flag is only used by net/url_request/url_request_throttler_entry.cc in
net, but the URLThrottler is no longer used on the main URLRequestContexts (the
only ones with main user gesture ever set), so it's not needed in net, and that
method can safely be removed.
BUG=516495
TEST=net_unittests
[email protected]
Review-Url: https://codereview.chromium.org/2396093002
Cr-Commit-Position: refs/heads/master@{#423620}
[Android] Delete org.chromium.net.test.BaseTestServer and friends.
They're no longer used.
BUG=488192
Review-Url: https://codereview.chromium.org/2390203007
Cr-Commit-Position: refs/heads/master@{#423619}
Use WebSecurityOrigin in //content to add origin headers
This prevents KURL() churn in SecurityOrigin::createFromString.
Review-Url: https://codereview.chromium.org/2392243003
Cr-Commit-Position: refs/heads/master@{#423618}
Use FileDescriptorWatcher in AlarmTimer.
FileDescriptorWatcher is a new API that replaces
MessageLoopForIO::WatchFileDescriptor.
This CL also gets rid of the base::Thread created in the anonymous
namespace of alarm_timer_chromeos.cc. The FileDescriptorWatcher
API is supported by every TaskScheduler thread. Very soon, most
tasks in Chrome will run in TaskScheduler. Therefore, there is no
reason to create a base::Thread to allow AlarmTimer to be used from
threads that don't support the FileDescriptorWatcher API.
BUG=645114
Review-Url: https://codereview.chromium.org/2398753003
Cr-Commit-Position: refs/heads/master@{#423617}
Add Notification images (Android pre-N standard layout)
Previously images were only supported on desktop and Android Nougat;
they would be hidden on JellyBean through Marshmallow where we use a
custom layout for the notifications. This patch makes us use the
standard layout on all versions of Android when an image is present,
thus images are now supported everywhere.
Still behind the --enable-experimental-web-platform-features flag.
Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discussion
Screenshot: https://imgur.com/a/A7VzK
Depends on https://codereview.chromium.org/2273033002
BUG=614456
Review-Url: https://codereview.chromium.org/2396063002
Cr-Commit-Position: refs/heads/master@{#423616}
Fix some accessibility issues in image editing.
- Fix tab order on editing tool bar by swapping containers.
- Add background color for focused buttons on editing tool.
- When a editing tool is shown, the first input element should be focused.
BUG=652352
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2400613002
Cr-Commit-Position: refs/heads/master@{#423615}
Merge makeString into StringAppend.
makeString is duplicating the logic to merge the is8Bit and length()
values of two string types, we can just use the StringAppend directly
instead.
I also simplified the code some removing the null checks on the
return value of StringImpl::createUninitialized which can never actually
return null.
Further I fixed the overflow math check which was checking for overflow
in the final call to makeString, but not inside all of the nested calls
to ::length() which meant a + b + c could still overflow the length. We
not check directly inside StringAppend::length() and crash instead of
returning null since that was likely to lead to crashes anyway as no
caller assumes stringA + stringB could ever result in null.
Review-Url: https://codereview.chromium.org/2399743002
Cr-Commit-Position: refs/heads/master@{#423614}
Add missing dependencies to extensions BUILD.gns
Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.
BUG=
Review-Url: https://codereview.chromium.org/2402453002
Cr-Commit-Position: refs/heads/master@{#423613}
[NTP Snippets] Remove SuggestionsService integration
Host restricts can still be specified manually via about:snippets-internals
BUG=653534
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2389323005
Cr-Commit-Position: refs/heads/master@{#423612}
Fix message loops in SSLUITestWaitForDOMNotification
I added this test in https://codereview.chromium.org/2395663002/, but it
was flaky, probably because my use of MessageLoops was nonsense. Plus,
QuitWhenIdle() is deprecated in favor of using RunLoops, so use that
instead.
BUG=653340
Review-Url: https://codereview.chromium.org/2389233004
Cr-Commit-Position: refs/heads/master@{#423611}
Change external link handling policy for CCTs
- Changes the url handling so that initial urls and the associated
redirect chain is also checked for default handlers inside CCT.
- This behavior is tied to a new extra that is added.
- This behavior is enabled by default as a feature, so that it can be
disabled if necessary
- Followup: The extra should be moved to CustomTabsIntent in the support
library and published as a new API. Tests that check for new corner
cases will be added to CustomTabsExternalNavigationTest
BUG=647474
Review-Url: https://codereview.chromium.org/2387293005
Cr-Commit-Position: refs/heads/master@{#423610}
Revert the removal of CompositingReasonOutOfFlowClipping
Change https://codereview.chromium.org/2382563002/ modified
the logic for compositing layers with a clip parent when
we prefer compositing to LCD text. Revert that change to fix
painting of fixed position clipped elements over accelerated
scrolling elements.
[email protected]
BUG=650446
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2389293002
Cr-Commit-Position: refs/heads/master@{#423609}
[MD settings] right arrow for manage other people setting row
Alan requested that the settings row for Manage other people have the
right arrow icon.
BUG=652803
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2392283004
Cr-Commit-Position: refs/heads/master@{#423608}
[MD settings] tweaks to what is shown in about page; and css cleanup
This CL hides the vertical grey bar (secondary action separator) in the
version row of the About page (when appropriate). It also adjusts the
spacing around the icon in that row to better match the mocks.
While doing the above I noticed there was an old reference to
--iron-icon-spacing which is obsolete so I removed references to that
as well.
BUG=651697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2387053004
Cr-Commit-Position: refs/heads/master@{#423607}
cc/blimp: Remove remenants of the old setup from LayerTreeTests
Remove the old setup code for LayerTreeTests. None of the tests use
them so a trivial change.
BUG=653371
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2398933002
Cr-Commit-Position: refs/heads/master@{#423606}
Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ )
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=653388
Original issue's description:
> Attach color space information to hardware decoded NV12 video frames.
>
> This extracts the color information from the h264 stream and attaches
> it to the video frame. Currently this is only done if the result is
> NV12 as we don't have the code yet to do it for RGB frames.
>
> BUG=622133, 647725
>
> Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
> Cr-Commit-Position: refs/heads/master@{#422942}
[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622133, 647725
Review-Url: https://codereview.chromium.org/2399133002
Cr-Commit-Position: refs/heads/master@{#423605}
[scheduler] Throttle background frames with 1% CPU limit
BUG=639852
Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
Review-Url: https://codereview.chromium.org/2345483002
Cr-Original-Commit-Position: refs/heads/master@{#423170}
Cr-Commit-Position: refs/heads/master@{#423604}
[Cronet] Pass metrics information from C++ BidirectionalStream to Java
This CL adds plumbing to pass metrics information from C++
BidirectionalStream to its Java counterpart.
BUG=648346
Review-Url: https://codereview.chromium.org/2360813003
Cr-Commit-Position: refs/heads/master@{#423603}
Use FileDescriptorWatcher in BrlapiConnectionImpl.
This allows BrlapiConnectionImpl to be used from any thread that
instantiates a FileDescriptorWatcher (not just threads that run
a MessageLoopForIO). This will facilitate the migration of
BrowserThreads to base/task_scheduler.
BUG=645114
Review-Url: https://codereview.chromium.org/2388913002
Cr-Commit-Position: refs/heads/master@{#423602}
Add @RetryOnFailure to DownloadNotificationServiceTest#testDownloadSuccessNotification
BUG=653609
[email protected]
Review-Url: https://codereview.chromium.org/2398653004
Cr-Commit-Position: refs/heads/master@{#423601}
chromeos: Refactor system tray ShowNetworkSettingsForGuid for mash
* Add to ash::mojom::SystemTrayClient interface
* Move implementation in chrome browser into SystemTrayClient
* Rename to ShowNetworkSettings with |network_id| because the parameter
|guid| isn't always a GUID.
This unfortunately has to check IsRunningInMash to access the session
state delegate. xiyuan@ is working on a system to replace that delegate,
but for now this is the simplest way.
BUG=647412
TEST=browser_tests, manually open network settings from system tray, both
via the Settings button and by clicking on the connected network
Review-Url: https://codereview.chromium.org/2396863004
Cr-Commit-Position: refs/heads/master@{#423600}
Initialize the font proxy even when not using the sandbox
Now that we removed the font cache, there is no reason for
the font proxy to be tied to sandbox initialization.
BUG=652898
Review-Url: https://codereview.chromium.org/2387373003
Cr-Commit-Position: refs/heads/master@{#423599}
[HBD] Blanket BLOCK on all non-HTTP(s) and non-FILE URLs for Flash.
This patch does two things:
1) Blocks all non-HTTP and non-FILE plugin loads within plugin_utils.cc (unless the user has chosen ALLOW)
2) Fixes FILE plugin loads. Previously, FILE origins were getting lost in the GetPlugins, since WebSecurityOrigin serializes FILE origins to "null".
This meant that content settings exceptions did not work correctly for the plugin list retrieval. This didn't matter before HBD because the plugin list wasn't affected by content settings until HBD.
This patch fixes it by passing url::Origin throughout the Plugins code rather than GURL for the page origin.
BUG=649223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2378573005
Cr-Commit-Position: refs/heads/master@{#423598}
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset #14 id:260001 of https://codereview.chromium.org/2351113005/ )
Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/155149
failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears
Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
>
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
>
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
>
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
>
> BUG=633791
>
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
Review-Url: https://codereview.chromium.org/2395233002
Cr-Commit-Position: refs/heads/master@{#423597}
API changes to support suspending requests
We want to be able to suspend requests until the offline download
code is sure it won't be manually downloading them. This API surface
change provides a mechanism to allow requests to be started in a
suspended state, and later transition to an available state.
BUG=652889
Review-Url: https://codereview.chromium.org/2395903002
Cr-Commit-Position: refs/heads/master@{#423596}
Fix parsing of minimum values
When parsing values that are minimum finite values
(for example std::numeric_limits::min<int>), we end up ignoring
the sign when calling charactersToIntStrict. This method will
then use the std::numeric_limits::max values for parsing, and
since abs(max) is smaller than abs(min) it will bail out and
parseHTMLIntegerInternal will return false.
To fix this simply add the minus sign in the string to be
parsed by charactersToIntStrict.
BUG=653557
Review-Url: https://codereview.chromium.org/2363823004
Cr-Commit-Position: refs/heads/master@{#423595}
Disable ItemChooserDialogTest#testAdd*
Add the DisableTest@ annotation to #testAddItemWithSameNameToListAndRemoveItemFromList
and #testAddOrUpdateItemAndRemoveItemFromList. These tests are already annotated with
@RetryOnFailure and continue to flake on several bots.
BUG=653618
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2395223002
Cr-Commit-Position: refs/heads/master@{#423594}
Roll src/third_party/catapult/ 89591c7f7..3c58b62cb (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/89591c7f79eb..3c58b62cb24c
$ git log 89591c7f7..3c58b62cb --date=short --no-merges --format='%ad %ae %s'
2016-10-06 eakuefner [Catapult] Disable eslint tests on Windows
2016-10-06 perezju [telemetry] Fix small bug when listing benchmarks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2393633007
Cr-Commit-Position: refs/heads/master@{#423593}
[SPInvalidation] Ignore clip failure in GeometryMapper::localToVisualRectInAncestorSpace()
On SPv1 GeometryMapper may fail to apply clip when the paint
invalidation container creates an overflow clip (in ancestorState)
which is not in localState of an out-of-flow positioned descendant.
See crbug.com/513108 and layout test
compositing/overflow/handle-non-ancestor-clip-parent.html (run with
--enable-prefer-compositing-to-lcd-text) and crbug.com/ for details.
Ignore clip failure for SPv1 for now.
BUG=646176
TEST=virtual/prefer_compositing_to_lcd_text/compositing/overflow/handle-non-ancestor-clip-parent.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2394483003
Cr-Commit-Position: refs/heads/master@{#423592}
Use the previews black list for offline previews
This injects PreviewsDecider into the
OfflinePagesURLRequestInterceptor to be used in determining if URLs are
allowed to be shown an offline preview.
BUG=639087
Review-Url: https://codereview.chromium.org/2388253002
Cr-Commit-Position: refs/heads/master@{#423591}
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication activateWithOptions:].
In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483, to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.
The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].
BUG=653483,650845
[email protected]
Review-Url: https://codereview.chromium.org/2395083003
Cr-Commit-Position: refs/heads/master@{#423590}
Hide timestamp of notifications in sensitive contexts on Android L+M
- UI review suggested we match the default public version of
notifications as closely as possible.
- On Android L & M the default hides the timestamp, so we should too.
- Updated before/after screenshots of #b75661d + this change at
https://drive.google.com/drive/u/1/folders/0B13NYI1M3t93aVJlWi03RDdrTUU
BUG=498716
Review-Url: https://codereview.chromium.org/2402453003
Cr-Commit-Position: refs/heads/master@{#423589}
Don't filter the federated credentials in the account chooser.
The filtering was introduced in https://codereview.chromium.org/2277793002
BUG=653364
Review-Url: https://codereview.chromium.org/2398863003
Cr-Commit-Position: refs/heads/master@{#423588}
Store only locale paks rather than all assets within BuildConfig.java
This works around Monochrome having diffferent BuildConfig.java for
32/64 bit.
BUG=652984
Review-Url: https://codereview.chromium.org/2396073002
Cr-Commit-Position: refs/heads/master@{#423587}
Separate ash::test::DisplayManagerTestApi from ash
To permit relocating DisplayManager and its tightly coupled
dependencies, decouple DisplayManagerTestApi from the rest of
ash. Also, modify ash display tests to obtain the current display
manager from AshTestBase so they can retrieve the current
display manager from there instead from a global singleton.
The combination of these changes permits relocating
ash::DisplayManager to ui/display.
BUG=581462
Review-Url: https://codereview.chromium.org/2355063002
Cr-Commit-Position: refs/heads/master@{#423586}
Obsolete now deprecated tab histograms.
Obsolete deprecated tab histograms since they are not collected
anymore.
BUG=627579
Review-Url: https://codereview.chromium.org/2393363002
Cr-Commit-Position: refs/heads/master@{#423585}
Miscellaneous fixes for various aspects of special locale
This CL:
1. Adds a UMA action to see how many users manually switch search
engines.
2. Refine the promo dialog suppression logic so that it will only be
suppressed after user's meaningful choice.
3. Switches the prepopulated Sogou search URL to HTTPS, which is what the
website redirects to.
BUG=638062
Review-Url: https://codereview.chromium.org/2398623004
Cr-Commit-Position: refs/heads/master@{#423584}
WidgetDelegateView is its own contents view.
Therefore, make it override GetContentsView instead of making all subclasses do so.
BUG=none
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2390953004
Cr-Commit-Position: refs/heads/master@{#423583}
Mus+Ash: Fix the FrameSinkId of the FrameGenerator's CompositorFrameSink
Previously, FrameSinkId collisions would have been possible. This CL
gives FrameGenerator a unique client_id (0), and an autogenerated sink_id.
BUG=647852
Review-Url: https://codereview.chromium.org/2400593002
Cr-Commit-Position: refs/heads/master@{#423582}
Modify MandatoryCallback to use function signature in template args.
Modify MandatoryCallback to use function signature in template args.
This lets us declare a MandatoryCallback<void(int, char)> instead of
MandatoryCallback<void, int, char> - consistent with how
base::Callback behaves.
Also removed some LOG(ERROR)s that mistakenly snuck in as part of a
post-LGTM patch upload.
[email protected]
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2392393003
Cr-Commit-Position: refs/heads/master@{#423581}
Disable ProximityAuthBluetoothLowEnergyWeavePacket*Test tests
These tests are consistently flaky across platforms.
BUG=651246
Review-Url: https://codereview.chromium.org/2395923002
Cr-Commit-Position: refs/heads/master@{#423580}
Add support for IsPerUserInstall in the Configurator interface.
This is a mechanical change. The code will be use in the next CL to
refactor how the UpdaterState is being sent in the
component updater update checks.
BUG=615187
Review-Url: https://codereview.chromium.org/2399533004
Cr-Commit-Position: refs/heads/master@{#423579}
Handle the is_preferred flag from ARC properly
BUG=b:31665510
TEST=try, manual
Review-Url: https://codereview.chromium.org/2389003003
Cr-Commit-Position: refs/heads/master@{#423578}
Upstream AuthenticationService and supporting classes.
Upstream AuthenticationService (Chrome interface to the iOS shared
authentication library), its factory, its fake and unit test.
BUG=None
Review-Url: https://codereview.chromium.org/2387143005
Cr-Commit-Position: refs/heads/master@{#423577}
Fix GCMS::ListAccounts returning stale data on iOS.
Marking the listed accounts cache as stale in GCMS is done by listening
to cookie changes (as this will catch any changes).
However, cookie changes notifications are not available on iOS, causing
the cache to be considered valid almost all the time.
This CL correctly marks the cache as stale for the most ususal actions
that will modify the listed accounts (AddAccount and LogOut).
BUG=653546
Review-Url: https://codereview.chromium.org/2394203002
Cr-Commit-Position: refs/heads/master@{#423576}
Revert of Add Reclaim Support to ThreadLocalStorage (patchset #1 id:1 of https://codereview.chromium.org/2363783002/ )
Reason for revert:
Precautionary revert while waiting for https://codereview.chromium.org/2383833004/
Will reland after branch point.
Original issue's description:
> Add Reclaim Support to ThreadLocalStorage
>
> Previously, ThreadLocalStorage::StaticSlot::Free() did not actually
> release the corresponding ThreadLocalStorage slot. It simply cleared
> out the slot and did not reuse it. As a result, each process had a
> finite number of calls to ThreadLocalStorage::StaticSlot::Initialize()
> before running out of slots.
>
> This problem would manifest itself in tests where a single process runs
> many tests that each do their own initialization and uninitialization.
> Tests that involve TLS usage caused the process to run out of TLS slots
> because there was no free support in ThreadLocalStorage.
>
> This change adds in free support by doing what most operating systems
> do, lock and track metadata in an array.
>
> BUG=590907
>
> Committed: https://crrev.com/783d1f9630c86d816669ab23981d0f3722c96808
> Cr-Commit-Position: refs/heads/master@{#421320}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=590907
Review-Url: https://codereview.chromium.org/2395043002
Cr-Commit-Position: refs/heads/master@{#423575}
Add my blink comment reflow CLs to .git-blame-ignore-revs
(Copy-pasted from `git log --pretty=oneline --author=thakis`, after removing
a few unrelated CLs.)
BUG=563793
Review-Url: https://codereview.chromium.org/2393633008
Cr-Commit-Position: refs/heads/master@{#423574}
Revert of 📰 Use the separate button style for the NoArticles status (patchset #6 id:100001 of https://codereview.chromium.org/2392943002/ )
Reason for revert:
Breaking tests on Android bots, see bug comment.
Original issue's description:
> [NTP Client] Use the separate button style for the NoArticles status
>
> Makes the articles and bookmarks sections use the same style of status
> card when they have no snippets.
>
> the hasMoreButton property of categories now only determines whether
> the action item will be shown when there are suggestions to display.
>
> This patch also lets the SuggestionsCategoryInfo be aware of the
> current category it is describing, and moves various category specific
> behaviours into the SuggestionsCategoryInfo class.
>
> Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7
>
> BUG=649670
>
> Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171
> Cr-Commit-Position: refs/heads/master@{#423517}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649670
Review-Url: https://codereview.chromium.org/2398463005
Cr-Commit-Position: refs/heads/master@{#423573}
Mock out pieces of Android Context to avoid actual system interaction
The state of the actual system shouldn't affect testing. In particular
we don't want NetworkChangeNotifierAutoDetect.mIgnoreNextBroadcast
getting set inadvertently if the system is actually connected to a
network.
BUG=653214
R=xunjieli
Review-Url: https://codereview.chromium.org/2401633002
Cr-Commit-Position: refs/heads/master@{#423572}
Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy
ForceYouTubeRestrict allows 3 settings: off/moderate/strict.
ForceYouTubeSafetyMode only allowed off/on.
If ForceYouTubeRestrict is set, ForceYouTubeSafetyMode is ignored.
If ForceYouTubeRestrict is not set and ForceYouTubeSafetyMode is set, 'on' is mapped to 'moderate'.
If the deprecated ForceSafeSearch policy is set and neither ForceYouTubeSafetyMode nor
ForceYouTubeRestrict are set, 'on' is mapped to 'moderate' as well.
The restrict mode is sent to YouTube by adding a "YouTube-Restrict" HTML request header
with values "Moderate" resp. "Strict". The old "YouTube-Safety-Mode" is no longer sent,
even if ForceYouTubeRestrict is not set. YouTube already properly interprets
"YouTube-Restrict".
BUG=590478
Review-Url: https://codereview.chromium.org/2239753002
Cr-Commit-Position: refs/heads/master@{#423571}
[Payments] Ignore CVC prompt result if client closed
Another case needs to be null checked now that multi-window
can cause a second Chrome window to appear.
BUG=652990
Review-Url: https://codereview.chromium.org/2393173003
Cr-Commit-Position: refs/heads/master@{#423570}
Prewarm WebView renderer when in multiprocess mode.
When we're in multiprocess mode, prewarm the renderer process early in
browser startup in the same way Chrome does. This reduces the startup
time penalty of multiprocess WebView by almost half in simple local
tests on a Nexus 6P.
BUG=653560
Review-Url: https://codereview.chromium.org/2390203006
Cr-Commit-Position: refs/heads/master@{#423569}
Add structured clone serialize/deserialize measurements to PerformanceTests.
Unlike the existing performance tests, these do not spawn a worker thread,
and measure both serialization and deserialization (as opposed to measuring
only serialization).
BUG=148757
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2391573007 .
Cr-Commit-Position: refs/heads/master@{#423568}
Store net::ProxyServer in HttpResponseInfo object.
Store net::ProxyServer in HttpResponseInfo instead of
net::HostPortPair. This makes it possible for the net
consumers to determine the proxy scheme used for a given
request (e.g., QUIC vs. HTTPS)
BUG=646197
Review-Url: https://codereview.chromium.org/2334623003
Cr-Commit-Position: refs/heads/master@{#423567}
[android] Switch the layout test android port to devil.
BUG=510678,567947
Review-Url: https://codereview.chromium.org/2381733002
Cr-Commit-Position: refs/heads/master@{#423566}
arc: OnClosedFromAndroid removes notifications as not by_user
Otherwise, a pinned notification remains in message center while
the underlying ArcNotificationItem is destroyed. This would cause
a crash later when message center attempts to create a view for
the notification.
BUG=647149,649379
BUG=b/31905643
TEST=Install any app from play store. After install finishes, bring
up the message center and observe no crash.
Review-Url: https://codereview.chromium.org/2394483004
Cr-Commit-Position: refs/heads/master@{#423565}
Add a ignore_elf32_limitations flag in build/config/compiler/compiler.gni
Add a ignore_elf32_limitations flag in
build/config/compiler/compiler.gni to turn off
assertion for Cronet builds.
This CL additionally adds is_clang to the
assertion per comment in 648948.
BUG=651887,648948
Review-Url: https://codereview.chromium.org/2395603003
Cr-Commit-Position: refs/heads/master@{#423564}
Remove two lines of failure entries in gpu pixel expectation page
Our previous CL: https://codereview.chromium.org/2391883004/ that
implements WebGL's commit with software compositing has been picked up
by all GPU bots, and all generated images are looking good. So this CL
removes these two failure entires.
BUG=563852
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2398093002
Cr-Commit-Position: refs/heads/master@{#423563}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/661c479e9dadfec6bf9c51a2b762eea23a5f5137 Relanding changes to swarming isolate script and refactor of slave_utils ([email protected])
[email protected],[email protected]
BUG=chromium:633253
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2399033003
Cr-Commit-Position: refs/heads/master@{#423562}
Report ARC status asynchronously via DeviceStatusCollector
Add field to SessionStatusReportRequest proto and add code to query
ARC for status blob and DroidGuardInfo. Code is still hidden behind a flag,
and will be controlled by a user policy that will be created in a follow-up
CL. Browser tests will also come with the policy CL.
BUG=b/31084348
Review-Url: https://codereview.chromium.org/2383763002
Cr-Commit-Position: refs/heads/master@{#423561}
Convert //ios/chrome/browser/signin target to real source_set.
As the downstream code now has the proper dependencies on
//ios/chrome/browser/signin (and ...:test_support), move
the files in the correct target.
BUG=653086
Review-Url: https://codereview.chromium.org/2389243003
Cr-Commit-Position: refs/heads/master@{#423560}
Fix RequestTrackerImpl uncontrolled destruction.
Objective-C blocks' lifetime can't be precisely controlled when they
are in an autoreleased pool. Since moving to ARC, base::BindBlock will
cause blocks to be added to such a pool.
This will affect in turn the objects retained by the pool. In this
case, the object is a scoped_refptr and controlling exactly its
lifetime is extremely important since some work is done in its
destructor (the RequestTrackerImpl object is removed from a global
map).
BUG=
Review-Url: https://codereview.chromium.org/2394143002
Cr-Commit-Position: refs/heads/master@{#423559}
blink: Enforce comment formatting.
All of blink's comments are now reflown [1], so we can stop telling clang-format
that it shouldn't touch comments. Delete third_party/WebKit/.clang-format, since
the top-level .clang-format file now works for blink.
Also reflow a few straggler comments that made it in in the last day.
1: core/layout isn't completely done yet, so suppress comment reflow enforcement
in core/layout until the last two patches there made it through the cq.
BUG=563793
NOTRY=true
Review-Url: https://codereview.chromium.org/2393803004
Cr-Commit-Position: refs/heads/master@{#423558}
CSP: Fix 'strict-dynamic' with multiple policies.
The checks we wrote for 'strict-dynamic' fail to allow dynamically-
injected scripts if more than one policy is present. This patch
addresses that by delegating the dynamic check to 'ContentSecurityPolicy'
(rather than bypassing CSP entirely from 'ScriptLoader'). Most of the
patch is just piping the "Was this parser-inserted?" bit from
'ScriptLoader::fetchScript' to 'CSPDirectiveList::allowScriptFromSource'.
to another.
BUG=653511
Review-Url: https://codereview.chromium.org/2401573003
Cr-Commit-Position: refs/heads/master@{#423557}
Fix label colors for dark native themes (incognito, shelf).
Regressed in f02568a216b975130849079183cc0f7173d6b832
BUG=653241
Review-Url: https://codereview.chromium.org/2394083002
Cr-Commit-Position: refs/heads/master@{#423556}
Add SetVideoMode API to avsettings
BUG= internal b/31777725
TEST= None
Review-Url: https://codereview.chromium.org/2384823002
Cr-Commit-Position: refs/heads/master@{#423555}
This CL migrates MediaSession message from IPC to mojo.
Currently MediaSession message is still Android-only, but it will
be available to Desktop in a follow-up CL.
BUG=649630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2367393002
Cr-Commit-Position: refs/heads/master@{#423554}
Asynchronously resolve getAvailability callbacks.
BUG=651216
[email protected]
Review-Url: https://codereview.chromium.org/2397453002
Cr-Commit-Position: refs/heads/master@{#423553}
Start Alt+Tab on MRU instead of MRU+1 if all windows are minimized.
BUG=647124
Review-Url: https://codereview.chromium.org/2389323002
Cr-Commit-Position: refs/heads/master@{#423552}
[HBD] Add HBD to about:flags for manual and Enterprise testers.
BUG=650903
Review-Url: https://codereview.chromium.org/2388903007
Cr-Commit-Position: refs/heads/master@{#423551}
Mark GpuRasterization.BlueBox flaky on new Win/AMD drivers.
This test seems to have started flaking since the change to new AMD.
It looks as though it had been flaking before we switched the swarming
pool to the new cards.
BUG=653538
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2392463008
Cr-Commit-Position: refs/heads/master@{#423550}
Roll src/third_party/catapult/ 6af2416f6..89591c7f7 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6af2416f6910..89591c7f79eb
$ git log 6af2416f6..89591c7f7 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 perezju [Dashboard] Use --pageset-repeat=1 in Telemetry bisects
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2395153002
Cr-Commit-Position: refs/heads/master@{#423549}
[Blink] Modify SuspendableScriptExecutor to take a v8::Function
Allow SuspendableScriptExecutor to take a v8::Function so that it can be
used from Extensions code. Also wire up WebLocalFrame and ScriptContext
to have handles to use it. Convert a couple of basic extensions call
sites as a POC.
BUG=629431
Review-Url: https://codereview.chromium.org/2339683006
Cr-Commit-Position: refs/heads/master@{#423548}
Add check to investigate the crash.
I run the clusterfuzz test locally but couldn't reproduce this crash. The crash can happen if the bubble gets closed after activation, so adding CHECK to investigate how that's happening.
BUG=651242
Review-Url: https://codereview.chromium.org/2392183002
Cr-Commit-Position: refs/heads/master@{#423547}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/31bf99ca4da39f9eae797276d675f53249054d14 Roll recipe dependencies (trivial). ([email protected])
depot_tools:
https://crrev.com/221ab25f46ce6469c7b00e080751428c94316552 git cl try-results: refactor Rietveld + add tests. ([email protected])
[email protected],[email protected]
BUG=599931
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2399033002
Cr-Commit-Position: refs/heads/master@{#423546}
Remove the last of the TLS fallback code.
It's gone and TLS 1.3 is not going to force it back.
Remove the last of the dead code.
Note this has a small behavior change: if we load a
cached top-level resource which previously used the
fallback and wasn't revalidated since the fallback was
removed, the website_settings.cc logic will no longer
show a message about this. But that message was only
ever shown on Android and only if you went looking for the
connection info.
(There's some other stale code there like downgrading
the connection status on SSLv3, but we may wish to
drop the cache entry instead in that case. Though in
general we don't really do the full provenance tracking
so it's largely a UI thing. Notably revalidations and
range requests will clobber one set of flags with another.
Will poke at that in a follow-up.)
BUG=621780
Review-Url: https://codereview.chromium.org/2382983002
Cr-Commit-Position: refs/heads/master@{#423545}
Check for valid context in AudioOutputDeviceClient::from.
BUG=652214
Review-Url: https://codereview.chromium.org/2397173002
Cr-Commit-Position: refs/heads/master@{#423544}
Allows prerendering to continue for offline requests even if the url was recently visited.
This is important for the way the new Download feature works. If a link is taking a while
to load, you can choose to download it (which does background load using prerender with
ORIGIN_OFFLINE). We indeed were recently trying to visit it but still want to load in the
background.
BUG=652350
Review-Url: https://codereview.chromium.org/2397783003
Cr-Commit-Position: refs/heads/master@{#423543}
Whitelist Chrome Webstore crx downloads by default for supervised users.
Themes are allowed for supervised users, and apps and extension have
their own approval mechanism that install the extensions in a disabled
mode untill they are approved by their parents.
Regardless from the browsing mode for suypervise users
(allow or block all websites), Chrome should always allow crx downloads
for themes and extensions to work as intended.
BUG=537142
Review-Url: https://codereview.chromium.org/2389073006
Cr-Commit-Position: refs/heads/master@{#423542}
Remove Path::pathBounds() workaround
The upstream bug has been fixed in Skia (https://bugs.chromium.org/p/skia/issues/detail?id=5555),
and TightBounds should now produce the same/correct results.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2399743003
Cr-Commit-Position: refs/heads/master@{#423541}
Clean up imports accross VR Shell native code.
BUG=
Review-Url: https://codereview.chromium.org/2398083002
Cr-Commit-Position: refs/heads/master@{#423540}
Incorporate 15 degree laser beam angle on pointer.
- Point the beam 15 degrees down from where the controller is pointing, for wrist comfort.
- Fix the beam to point directly at the reticle.
BUG=642058
Review-Url: https://codereview.chromium.org/2392333003
Cr-Commit-Position: refs/heads/master@{#423539}
Walk up frame tree for srcdoc referrer policies
When deciding the referrer policy for a srcdoc document, walk up the
frame tree until we find a non-srcdoc document OR a srcdoc document with
its own policy set via a meta element.
This implements the algorithm defined in
https://html.spec.whatwg.org/multipage/browsers.html#set-up-a-browsing-context-environment-settings-object. However,
the spec'ed algorithm has to be adjusted per
https://github.com/whatwg/html/pull/1559#issuecomment-251767893 to
account for meta elements in srcdoc documents (which this CL
implements).
BUG=653034,637007
Review-Url: https://codereview.chromium.org/2400443004
Cr-Commit-Position: refs/heads/master@{#423538}
Delete fixed todo in NewTabPageAdapter.
It was addressed in https://codereview.chromium.org/2274293002
Review-Url: https://codereview.chromium.org/2398983002
Cr-Commit-Position: refs/heads/master@{#423537}
Fix double-delete in BatteryMonitor.
BatterMonitorImpl is uniquely owned by its StrongBinding, so deleting it
directly results in a double-delete.
BUG=653298
Review-Url: https://codereview.chromium.org/2398833003
Cr-Commit-Position: refs/heads/master@{#423536}
Adds methods for Cast support to ios::ChromeBrowserProvider.
BUG=653233
TEST=None
Review-Url: https://codereview.chromium.org/2396943002
Cr-Commit-Position: refs/heads/master@{#423535}
Prune deprecated functions from BreakBlockquoteCommand
BUG=647219,651373
Review-Url: https://codereview.chromium.org/2399773002
Cr-Commit-Position: refs/heads/master@{#423534}
Prune deprecated functions from DeleteSelectionCommand
BUG=647219,651373
Review-Url: https://codereview.chromium.org/2399793002
Cr-Commit-Position: refs/heads/master@{#423533}
Move SurfaceSequenceGenerator => cc/surfaces
SurfaceSequenceGenerator is useful in mus in the short term and so
this CL moves it somewhere where we can use it.
BUG=647852
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2397103002
Cr-Commit-Position: refs/heads/master@{#423532}
Benchmark tools: Android memtrack_helper meaningful errors.
If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.
BUG=651833
Review-Url: https://codereview.chromium.org/2389883004
Cr-Commit-Position: refs/heads/master@{#423531}
WebGL: Mark half float test flaky on Win/AMD.
New AMD only, the whole test suite is flaky on the old one.
BUG=653533
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2398923004
Cr-Commit-Position: refs/heads/master@{#423530}
NTPSnippetsService: Garbage collect orphaned images at startup.
Also extends the unittest to use a proper image_decoder to allow better test coverage (and actually verifying the intended behavior).
BUG=649009
Review-Url: https://codereview.chromium.org/2386103009
Cr-Commit-Position: refs/heads/master@{#423529}
Add new sections to histogram guide.
BUG=
Review-Url: https://codereview.chromium.org/2384273006
Cr-Commit-Position: refs/heads/master@{#423528}
Disabling BlinkPerfDom on reference build for win and linux
BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Review-Url: https://codereview.chromium.org/2397583003
Cr-Commit-Position: refs/heads/master@{#423527}
[Supervised users] Don't set the new_navigation flag when blocking a previously loaded page.
BUG=582936
Review-Url: https://codereview.chromium.org/2151463002
Cr-Commit-Position: refs/heads/master@{#423526}
[NTP Client] Spacing and fixes for the sign in promo
- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek
- Adds 20dp space between the promo and the status card if present
- Fixes to the bottom space calculation related to the dismissal of
sibling elements.
Preview: https://goo.gl/photos/94hhXK5rygGamFqt7
BUG=649670,652578
Review-Url: https://codereview.chromium.org/2396863003
Cr-Commit-Position: refs/heads/master@{#423525}
Remove 'char' from IDL
We should just use int8_t or uint8_t instead of char in the IDL.
BUG=255715
Review-Url: https://codereview.chromium.org/2394773002
Cr-Commit-Position: refs/heads/master@{#423524}
Remove empty target //ios/chrome/browser:browser_about_rewriter.
This target was there to allow safe migration while upstreaming the
code. Now that downstream has no dependency on this target, it can
safely be removed.
BUG=None
Review-Url: https://codereview.chromium.org/2384323004
Cr-Commit-Position: refs/heads/master@{#423523}
Rename MojoShellContext -> ServiceManagerContext.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2387263002
Cr-Commit-Position: refs/heads/master@{#423522}
Remove all ContentViewCore references in native vr_shell code.
BUG=
Review-Url: https://codereview.chromium.org/2397013002
Cr-Commit-Position: refs/heads/master@{#423521}
Various bits of cleanup for native vr shell code.
No functional changes.
BUG=
Review-Url: https://codereview.chromium.org/2394033002
Cr-Commit-Position: refs/heads/master@{#423520}
Remove ASSERT_UNUSED
This CL has no behavior changes.
BUG=596760
Review-Url: https://codereview.chromium.org/2394683005
Cr-Commit-Position: refs/heads/master@{#423519}
Update the V8 version for Chromium branch 55.
This is a roll-back to 5.5.372. This is the most stable candidate out of the latest Canaries.
If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.
When in doubt please try to contact the committer and reviewers of this CL before reverting it.
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2393703006
Cr-Commit-Position: refs/heads/master@{#423518}
[NTP Client] Use the separate button style for the NoArticles status
Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.
the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.
This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.
Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7
BUG=649670
Review-Url: https://codereview.chromium.org/2392943002
Cr-Commit-Position: refs/heads/master@{#423517}
Allocator shim explanatory error message.
Error message explicitly tells to disable allocator shim if libc
is unsupported. Currently it's hardly achievable to figure out
target libc implementation on the GN generation stage.
BUG=595406
Review-Url: https://codereview.chromium.org/2393413003
Cr-Commit-Position: refs/heads/master@{#423516}
Add bottom row of buttons for Ash MD system menu
Introduce the TrayTiles and TilesDefaultView
classes. For Ash material design, these will
be used to represent a row of buttons ('tiles')
at the bottom of the system menu. This CL
adds four such buttons: power, lock, help, and
settings.
BUG=631986
TEST=TrayTilesTest.*
[email protected]
Review-Url: https://codereview.chromium.org/2382883002
Cr-Commit-Position: refs/heads/master@{#423515}
Reflow comments in core/css
Note that some ASSERTs became DCHECKs, and some bitfields became unsigned
instead of uint16_t, because I reflowed a comment next to them.
BUG=563793
Review-Url: https://codereview.chromium.org/2392343005
Cr-Commit-Position: refs/heads/master@{#423514}
[Android WebView] Add functionality to enable features and enable the spellcheck feature.
This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).
This patch also enables spellchecking in WebView by default, but only
on non low-end devices.
The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line
BUG=583616, 629609
Review-Url: https://codereview.chromium.org/2396803002
Cr-Commit-Position: refs/heads/master@{#423513}
Protobuf changes to support ARC++ kiosk policy.
BUG=634497
Review-Url: https://codereview.chromium.org/2394773005
Cr-Commit-Position: refs/heads/master@{#423512}
Remove unused auto-signin strings from the resources.
Review-Url: https://codereview.chromium.org/2395093002
Cr-Commit-Position: refs/heads/master@{#423511}
Remove redundant logic from generate_resource_whitelist.py
The --use-existing-resource-ids flag was added in
https://codereview.chromium.org/2278983002 in an attempt to maintain
compatibility with official builder scripts. These have been updated,
and the flag can now be removed.
BUG=
Review-Url: https://codereview.chromium.org/2401463002
Cr-Commit-Position: refs/heads/master@{#423510}
[scheduler] Change ThreadLoadTracker to use only recent data.
Currently ThreadLoadTracker accumulates data from the start and reports average load of an interval from the start to current moment.
This patch replaces cumulative approach with sliding window and makes ThreadLoadTracker report last minute average load.
BUG=639852
Review-Url: https://codereview.chromium.org/2391593002
Cr-Commit-Position: refs/heads/master@{#423509}
[wrapper-tracing] CSSRule: Add write barriers
Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRkRDFwBc/edit#gid=0&vpid=A3
BUG=chromium:468240
[email protected]
Review-Url: https://codereview.chromium.org/2396033002
Cr-Commit-Position: refs/heads/master@{#423508}
Fix several issues with the TaskQueueManagerPerfTest
The perf test was crashing (it needed a messageloop).
It was executing more than 10000 tasks (oops).
There was noise due to the OS delayed timer.
BUG=
Review-Url: https://codereview.chromium.org/2400653002
Cr-Commit-Position: refs/heads/master@{#423507}
Revert of components/arc: implement multi advertising (patchset #17 id:320001 of https://codereview.chromium.org/2256003002/ )
Reason for revert:
Causes LSAN failures: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16702
Original issue's description:
> components/arc: implement multi advertising
>
> This plumbs through multi advertising capabilities for the
> instance. Instances can register and unregister advertisements.
>
> BUG=637171
> TEST=use nrf connect on remote device and verify that packets
> registered from the instance are visible on the remote device
>
> Committed: https://crrev.com/efca08b08a581ec53c7a140fc13e660ed7530865
> Cr-Commit-Position: refs/heads/master@{#423253}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637171
Review-Url: https://codereview.chromium.org/2389393005
Cr-Commit-Position: refs/heads/master@{#423506}
Revert of Bluetooth: Disabling test due to leak. (patchset #1 id:20001 of https://codereview.chromium.org/2394153002/ )
Reason for revert:
CLs with leaks should be reverted, not their test disabled IMO: https://codereview.chromium.org/2389393005/
Original issue's description:
> Bluetooth: Disabling test due to leak.
>
> TBR=ejcaruso
> BUG=653480
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/c0b0d871d078b6615fc17fad42cd96ca1a118e62
> Cr-Commit-Position: refs/heads/master@{#423499}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653480
Review-Url: https://codereview.chromium.org/2395573004
Cr-Commit-Position: refs/heads/master@{#423505}
[wrapper-tracing] IntersectionObserver: Add write barriers
Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRkRDFwBc/edit#gid=0&vpid=A3
BUG=chromium:468240
[email protected]
Review-Url: https://codereview.chromium.org/2398683005
Cr-Commit-Position: refs/heads/master@{#423504}
Skip reflowed comments css/invalidation for git-blame.
[email protected]
BUG=563793
Review-Url: https://codereview.chromium.org/2393393002
Cr-Commit-Position: refs/heads/master@{#423503}
Move browser_about_rewriter.{cc,h} to //ios/chrome/browser.
BUG=None
Review-Url: https://codereview.chromium.org/2394813002
Cr-Commit-Position: refs/heads/master@{#423502}
Fix performance issue in InstanceCounters for DOM nodes
The instance counters have used atomic incrementing/decrementing, but
this caused performance issue for dromaeo.domcoremodify test where DOM
objects are injected and created. This CL fixes this issue by creating
another counter without locks or atomic barriers only for nodes.
BUG=641019
Review-Url: https://codereview.chromium.org/2393353003
Cr-Commit-Position: refs/heads/master@{#423501}
Implement WebGL's commit with software compositing
We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.
Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.
BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2391883004
Cr-Commit-Position: refs/heads/master@{#423500}
Bluetooth: Disabling test due to leak.
TBR=ejcaruso
BUG=653480
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2394153002
Cr-Commit-Position: refs/heads/master@{#423499}
Roll src/third_party/catapult/ 7a9bb7d41..6af2416f6 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7a9bb7d412cc..6af2416f6910
$ git log 7a9bb7d41..6af2416f6 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 petrcermak [tracing] Encapsulate unit and description prefix builder in memory metric properties
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2394963004
Cr-Commit-Position: refs/heads/master@{#423498}
Supervised Users should always need custodian approval for permission increase.
Remove the field trial SupervisedUserExtensionPermissionIncrease
BUG=652235
Review-Url: https://codereview.chromium.org/2396903002
Cr-Commit-Position: refs/heads/master@{#423497}
Update comment for CardViewHolder.
Review-Url: https://codereview.chromium.org/2394663005
Cr-Commit-Position: refs/heads/master@{#423496}
Ntp: delete trailing semicolon.
Review-Url: https://codereview.chromium.org/2391333002
Cr-Commit-Position: refs/heads/master@{#423495}
Update V8 to version 5.5.377.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b8d85bfa..ad3b8b74
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2394133002
Cr-Commit-Position: refs/heads/master@{#423494}
Fix 'noopener' targeting and return value.
Boris noted a few cases in which Chrome wasn't following the spec for
'noopener'. This patch addresses two of them by ensuring that the call
to 'window.open' return 'null' (rather than 'undefined'), and that we
don't reuse existing windows when processing a 'noopener' request.
BUG=651578,651579
Review-Url: https://codereview.chromium.org/2379313002
Cr-Commit-Position: refs/heads/master@{#423493}
DevTools: Support reading streamed CpuProfile format in timeline.
BUG=406277
Review-Url: https://codereview.chromium.org/2400533002
Cr-Commit-Position: refs/heads/master@{#423492}
Prune createVisibleSelectionDeprecated from CreateLinkCommand
A previous patch (crrev.com/2391723006) ensured clean layout but forgot
to rename the function call from createVisibleSelectionDeprecated to
createVisibleSelection. This patch does the renaming.
BUG=651373
Review-Url: https://codereview.chromium.org/2397873004
Cr-Commit-Position: refs/heads/master@{#423491}
Reflow comments in //third_party/WebKit/Source/core/editing
BUG=563793
Review-Url: https://codereview.chromium.org/2399663003
Cr-Commit-Position: refs/heads/master@{#423490}
Delete from Sync the artificial search engines created by the omnibox extensions.
They are not synced for almost two years. However, the old entries may still reside in the server data. Now the client will remove them.
BUG=411197
Review-Url: https://codereview.chromium.org/2354413004
Cr-Commit-Position: refs/heads/master@{#423489}
[Zine] Update bookmark provider when new bookmarks are added (by sync)
This CL makes the bookmark suggestions provider react to sync. Thus,
when sync creates new bookmarks (that have been visited recently on
another mobile device) and these bookmarks sync to a new device, they
are shown on a newly opened NTP, afterwards.
BUG=646773
Review-Url: https://codereview.chromium.org/2397723003
Cr-Commit-Position: refs/heads/master@{#423488}
Mojo C++ bindings: make String16 and gfx::Size available in Blink
This CL adds C++ bindings for String16 and Size in Blink, which will
be used in a follow-up CL (https://codereview.chromium.org/2367393002/).
BUG=624136,649630
Review-Url: https://codereview.chromium.org/2379993003
Cr-Commit-Position: refs/heads/master@{#423487}
Re-enable all v8 benchmarks on reference
BUG=540022
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Review-Url: https://codereview.chromium.org/2381863002
Cr-Commit-Position: refs/heads/master@{#423486}
Use base_idl_type if it is available.
BUG=None
Review-Url: https://codereview.chromium.org/2393413002
Cr-Commit-Position: refs/heads/master@{#423485}
Roll src/third_party/catapult/ b15a8c1c4..7a9bb7d41 (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b15a8c1c4173..7a9bb7d412cc
$ git log b15a8c1c4..7a9bb7d41 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 dtu [bisect] Add rudimentary swarming service.
2016-10-05 dtu [bisect] Add pinpoint service to dashboard and deployment script.
2016-10-05 benjhayden [tr-ui-b-table] Prevent line breaks around expand-buttons.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2385423006
Cr-Commit-Position: refs/heads/master@{#423484}
Remove dangerous CHECK. Add unit test.
New unit test failed before changes, passes now.
BUG=652610
Review-Url: https://codereview.chromium.org/2396463002
Cr-Commit-Position: refs/heads/master@{#423483}
Reflow comments in core/css/parser
[email protected]
BUG=563793
Review-Url: https://codereview.chromium.org/2398013002
Cr-Commit-Position: refs/heads/master@{#423482}
Add an XPC service to handle alert notifications on mac
BUG=571056
Review-Url: https://codereview.chromium.org/2070903002
Cr-Commit-Position: refs/heads/master@{#423481}
Update V8 to version 5.5.376.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e5fb7614..b8d85bfa
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2399683003
Cr-Commit-Position: refs/heads/master@{#423480}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/6f2eba7913d04ff589a8c3da1c7f226df1591569 Update fugu-debug's device. ([email protected])
[email protected],[email protected]
BUG=
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2395073002
Cr-Commit-Position: refs/heads/master@{#423479}
Move Priority enum/field to KeyframeEffectReadOnly
Following from https://codereview.chromium.org/2389323003, this patch begins the
process of moving content from KeyframeEffect to its superclass,
KeyframeEffectReadOnly, so that KeyframeEffectReadOnly objects can be
constructed directly. This patch moves the definition of the Priority enum and
the m_priority field.
BUG=624639
Review-Url: https://codereview.chromium.org/2394993002
Cr-Commit-Position: refs/heads/master@{#423478}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/c36aaf1c36deaa69fb914ad68388da7b2ea5e2a9 Fix chromium_perf_fyi android FYI builder compile targets ([email protected])
https://crrev.com/ccf70fea5aeed4aa516ee5126c2eded681a4ca6a Roll recipe dependencies (trivial). ([email protected])
https://crrev.com/44c57c81eb768a3cfd8c802479aa312679c59192 WebRTC: Fix Android swarming bots. ([email protected])
depot_tools:
https://crrev.com/1838bade4359194dadd6287af1876322f0584414 git cl: style cleanup. ([email protected])
[email protected],[email protected]
BUG=639530,583318
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2394063003
Cr-Commit-Position: refs/heads/master@{#423477}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
build:
https://crrev.com/8ae1c6cfb7566ca91ba372fdb800ee5c02b61dfe WebRTC: Add Android swarming bots to the waterfall and tryserver. ([email protected])
[email protected],[email protected]
BUG=583318
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2397123002
Cr-Commit-Position: refs/heads/master@{#423476}
[NTP Snippets] Add category-aware UMA for dismissals
BUG=649776
Review-Url: https://codereview.chromium.org/2391993003
Cr-Commit-Position: refs/heads/master@{#423475}
Reflow comments for core/css/cssom
BUG=563793
Review-Url: https://codereview.chromium.org/2398683003
Cr-Commit-Position: refs/heads/master@{#423474}
Log app_shell warnings on loading apps
Extension warnings should be logged somewhere, since we don't have a
UI for them like the Extensions UI's "developer mode".
[email protected]
BUG=652006
Review-Url: https://codereview.chromium.org/2390073002
Cr-Commit-Position: refs/heads/master@{#423473}
Cancel RawResource asynchronously in allClientsAndObserversRemoved()
allClientsAndObserversRemoved() can be called in subtle situations, e.g. in
prefinalizers, and thus we should avoid non-trivial things, such as Resource
cancelling.
This CL moves the last part of Resource cancelling (RawResource) out of
allClientsAndObserversRemoved().
BUG=606651, 644058
Review-Url: https://codereview.chromium.org/2306303003
Cr-Commit-Position: refs/heads/master@{#423472}
Move below headers even when row doesn't require a strut
When a row doesn't need a strut to appear at the top of a page, ensure it moves
below any repeating header. When the tables uses 'border-spacing' ensure that
the row is offsetting from the top of the page, as the border-spacing can often
straddle the page-break.
BUG=642814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2388613002
Cr-Commit-Position: refs/heads/master@{#423471}
Fix pylint warnings: build/toolchain/win/tool_wrapper.py
************* Module tool_wrapper
W: 94,32: Unused argument 'excinfo' (unused-argument)
W:230,29: Unused argument 'arch' (unused-argument)
W:301, 0: Redefining built-in 'dir' (redefined-builtin)
Review-Url: https://codereview.chromium.org/2393283003
Cr-Commit-Position: refs/heads/master@{#423470}
Implement animation tainted custom property values
This patch updates the CSSVariableResolver to be aware of animation tainted
custom property values and to support disallowing custom property
substitution when a referenced value has been animation tainted.
Relevant spec: https://drafts.csswg.org/css-variables/#substitute-a-var
The spec currently references the out of date notion of animation tainted
custom properties rather than tainted values. This implementation reflects
a future amendment of the spec.
Because animations are the only source of animation tainted values and our
implementation doesn't support animations setting custom property values
there is no user-visible change made by this patch.
The (failing) layout test shows the kind of behaviour this patch is
intended to support.
BUG=644148
Review-Url: https://codereview.chromium.org/2323633002
Cr-Commit-Position: refs/heads/master@{#423469}
Adding csp to frameOwnerPropertiesChanged
If the iframe is remote and the csp attribute gets updated,
we need to have access to the newest value when sending
Embedding-CSP header and setting browsing context's requiredCSP value.
BUG=647588
Review-Url: https://codereview.chromium.org/2378643002
Cr-Commit-Position: refs/heads/master@{#423468}
Move handling of 'attributeType' to SVGAnimateElement
Another animation property that applies only to the SVGAnimateElement
part/subtree of the element hierarchy. Move it down for continued
"unlocking" of the structure.
BUG=641437
Review-Url: https://codereview.chromium.org/2391993006
Cr-Commit-Position: refs/heads/master@{#423467}
IDL compiler should generate equalIgnoringASCIICase() for ReflectOnly.
https://html.spec.whatwg.org/multipage/infrastructure.html#keywords-and-enumerated-attributes
> If an enumerated attribute is specified, the attribute's value must be an ASCII
> case-insensitive match ...
BUG=627682
Review-Url: https://codereview.chromium.org/2397093002
Cr-Commit-Position: refs/heads/master@{#423466}
Prune createVisibleSelectionDeprecated from SelectionAdjuster
BUG=651373
Review-Url: https://codereview.chromium.org/2395053002
Cr-Commit-Position: refs/heads/master@{#423465}
bluetooth: Add kinomap service and characteristic UUIDs hashes to histograms.xml
See https://www.kinomap.tv/js/ble/deviceEcma6.js
Review-Url: https://codereview.chromium.org/2397543004
Cr-Commit-Position: refs/heads/master@{#423464}
Directly call ChunkDemuxer::Initialize completion callback.
ChunkDemuxer posts init_cb while calls DemuxerHost::OnDemuxerError
directly, which creates a race between the two. In some cases if
there is an error right after a successful intialization, the error
will be reported before init_cb has a chance to run which violates
upstream expectations.
BUG=633016
Review-Url: https://codereview.chromium.org/2273273002
Cr-Commit-Position: refs/heads/master@{#423463}
Automated Commit: Committing new LKGM version 8867.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#423462}
Set status bar height to 44px on login screen
The height of the status bar is 44px on normal screen, but is 48px on login and lock screen. This patch makes the login screen 44px, by reducing 3px black bottom border and 1px top margin. As the result, the height of top and bottom margin and tray are same among login, lock and normal screen.
BUG=641377
TEST=see the notification tray manually with MD and non-MD mode
Review-Url: https://codereview.chromium.org/2371153002
Cr-Commit-Position: refs/heads/master@{#423461}
Remove TreeScopeEventContext::m_rootNode.
This is no longer needed to keep TreeScope live, since TreeScope itself
is already allocated on the Oilpan heap.
BUG=none
Review-Url: https://codereview.chromium.org/2399673003
Cr-Commit-Position: refs/heads/master@{#423460}
Rename HTMLSelectElement::m_multiple and multiple() to m_isMultiple and isMultiple().
The function isn't used for the 'multiple' IDL attribute. We should follow the
coding style.
This CL has no behavior changes.
Review-Url: https://codereview.chromium.org/2391233002
Cr-Commit-Position: refs/heads/master@{#423459}
Reflow comments in //third_party/WebKit/Source/core/editing/commands
BUG=563793
Review-Url: https://codereview.chromium.org/2397963002
Cr-Commit-Position: refs/heads/master@{#423458}
bluetooth: Add Elgato Avea Bulb service and characteristic UUIDs hashes to histograms.xml
See http://szeged.github.io/servo/demos/elgato/wbt.js
Review-Url: https://codereview.chromium.org/2398633002
Cr-Commit-Position: refs/heads/master@{#423457}
Update V8 to version 5.5.375.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee4a49f5..e5fb7614
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2396003002
Cr-Commit-Position: refs/heads/master@{#423456}
Replace ASSERT family with DCHECK and so on in core/dom/.
- ASSERT_UNUSED -> DCHECK*
- ASSERT_NOT_REACHED -> NOTREACHED
- ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK
* core/dom/SpaceSplitString.h
Remove two ASSERT_WITH_SECURITY_IMPLICATIONs. Vector[] has a RELEASE_ASSERT for
the same condition. These ASSERT_WITH_SECURITY_IMPLICATIONs were redundant.
BUG=596760
Review-Url: https://codereview.chromium.org/2401523002
Cr-Commit-Position: refs/heads/master@{#423455}
Remove Resource::create() to ensure proper subclasses of Resource are created
- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.
BUG=652999
Review-Url: https://codereview.chromium.org/2399473002
Cr-Commit-Position: refs/heads/master@{#423454}
Revert of MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget. (patchset #1 id:20001 of https://codereview.chromium.org/2396883004/ )
Reason for revert:
Breaks compile. Probably because the CountBridgedWindows function is only compiled in when DCHECK are ON.
Original issue's description:
> MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.
>
> BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
> ensure that
> - When a window is hidden, all its child windows are hidden and removed from its
> child window list.
> - When a window is made visible, all its child windows which want to become
> visible are made visible and added to its child window list.
>
> However, this does not account for windows which may be added by AppKit, for
> example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
> account for windows added by AppKit.
>
> BUG=653325
>
> Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
> Cr-Commit-Position: refs/heads/master@{#423450}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653325
Review-Url: https://codereview.chromium.org/2399783002
Cr-Commit-Position: refs/heads/master@{#423453}
Reland of ServiceWorker: Added --mojo-service-worker to the browser tests (patchset #1 id:1 of https://codereview.chromium.org/2380723002/ )
Reason for revert:
A revert of https://codereview.chromium.org/2227593002 is reverted.
Original issue's description:
> Revert of ServiceWorker: Added --mojo-service-worker to the browser tests (patchset #2 id:20001 of https://codereview.chromium.org/2357543002/ )
>
> Reason for revert:
> Revert so a revert of https://codereview.chromium.org/2227593002 will compile.
>
> Original issue's description:
> > ServiceWorker: Added --mojo-service-worker to the browser tests
> >
> > In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P
> > to use the parameterized tests for flipping the flag.
> >
> > BUG=629701
> >
> > Committed: https://crrev.com/baa9cb520b6ee800f7633fb966474bf12325b8d9
> > Cr-Commit-Position: refs/heads/master@{#421462}
>
> [email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=629701
>
> Committed: https://crrev.com/9fad885c354ebf046e9506f85391cf4585991c05
> Cr-Commit-Position: refs/heads/master@{#421518}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629701
Review-Url: https://codereview.chromium.org/2397523004
Cr-Commit-Position: refs/heads/master@{#423452}
Make a function to query whether a CSSPropertyID is valid and whether it has a name.
This just tidies up and clarifies what is being checked for in a bunch of DCHECKs.
I manually looked for asserts, DCHECKs or if statements containing one of
id >= firstCSSProperty && id <= lastUnresolvedCSSProperty
or
id < firstCSSProperty || id > lastCSSProperty
and replaced them with a new method
isPropertyIDWithName
Also manually replaced things like
DCHECK_NE(property, CSSPropertyInvalid)
with
DCHECK(isValidCSSPropertyID(property));
Review-Url: https://codereview.chromium.org/2228313002
Cr-Commit-Position: refs/heads/master@{#423451}
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.
BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
child window list.
- When a window is made visible, all its child windows which want to become
visible are made visible and added to its child window list.
However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.
BUG=653325
Review-Url: https://codereview.chromium.org/2396883004
Cr-Commit-Position: refs/heads/master@{#423450}
reflow comments in core/frame
BUG=563793
Review-Url: https://codereview.chromium.org/2393313002
Cr-Commit-Position: refs/heads/master@{#423449}
[Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue
* Switching the interface of RequestQueue/RequestStore::RemoveRequests
* Converting implementation to Task based: RemoveRequestsTask with tests.
* Removing most of old callbacks and typedefs
BUG=645522,651238
Review-Url: https://codereview.chromium.org/2373933003
Cr-Commit-Position: refs/heads/master@{#423448}
CSS Motion Path: Use counters for motion properties having effect
A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhRAAAJ
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.
We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.
BUG=637543
Review-Url: https://codereview.chromium.org/2358433005
Cr-Commit-Position: refs/heads/master@{#423447}
Re-enable storage for Suborigins.
Suborigins should, according to the spec, have access to their own
storage partitions. This CL re-enables the storage objects for
suborigins. Additionally, it implements the Cookies Tree Model updates
to make sure that the storage partitions appear under their parent
host's storage object.
BUG=608564, 336894
Review-Url: https://codereview.chromium.org/2005783005
Cr-Commit-Position: refs/heads/master@{#423446}
Mark more encrypted-media tests as flaky.
BUG=652978
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2397833003
Cr-Commit-Position: refs/heads/master@{#423445}
Reflow comments in //third_party/WebKit/Source/core/editing/serializers
BUG=563793
Review-Url: https://codereview.chromium.org/2393243003
Cr-Commit-Position: refs/heads/master@{#423444}
Fix a null ptr crash on a empty body response on mojo loading
|body_consumer_| can be null on a request completion of an empty body
response.
BUG=603396
Review-Url: https://codereview.chromium.org/2390293002
Cr-Commit-Position: refs/heads/master@{#423443}
Create MetricsPrivateDelegate for metricsPrivate behavior
This creates a MetricsPrivateDelegate for metricsPrivate functionality
implemented by the embedder. This helps deal with the way MetricsServiceAccessor
uses inheritance to restrict access to static methods to friends of subclasses.
(MetricServiceAccessor is "pretty much just a hack around limitations in the
OWNERS system": crbug.com/374199#c7)
Precursor to moving chrome.metricsPrivate to //extensions (crrev.com/2349453002).
BUG=647397
Review-Url: https://codereview.chromium.org/2331343012
Cr-Commit-Position: refs/heads/master@{#423442}
Reflow comments in core/css/invalidation.
[email protected]
BUG=563793
Review-Url: https://codereview.chromium.org/2398833004
Cr-Commit-Position: refs/heads/master@{#423441}
Prune deprecated functions from ApplyStyleCommand
This patch prunes the following deprecated functions from ApplyStyleCommand by
ensuring clean layout and valid input parameters:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- startOfParagraphDeprecated
- endOfParagraphDeprecated
BUG=647219,651373
Review-Url: https://codereview.chromium.org/2391193004
Cr-Commit-Position: refs/heads/master@{#423440}
Worker: Cancel script loading when an execution context is destroyed
Before this CL, WorkerScriptLoader can work even after the context is destroyed
and a finish callback may crash because of null context access.
This CL cancels script loading when the context is destroyed and provides a way
to check whether the loading is canceled for the finish callback.
BUG=650131
Review-Url: https://codereview.chromium.org/2393783002
Cr-Commit-Position: refs/heads/master@{#423439}
Prune a new call site of createVisibleSelectionDeprecated from DragController
This patch prunes a new call site of createVisibleSelectionDeprecated, which
was introduced by r422915 and hence not catched by r423036, from DragController.
BUG=651373
Review-Url: https://codereview.chromium.org/2398923002
Cr-Commit-Position: refs/heads/master@{#423438}
Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests.
BUG=636710
Review-Url: https://codereview.chromium.org/2389803004
Cr-Commit-Position: refs/heads/master@{#423437}
Fix compile error on simple chrome.
Under C++11, NVRO can happen when a return's expression
has the function's return type.
Here, those are different (although FakeArcBridgeBootstrap
inherits ArcBridgeBootstrap), thus explicit std::move()
should be here.
Note, C++17 or later, the condition is relaxed and NVRO
becomes mandatory, so the old code should work, though.
cf): C++11 n3337/12.8/32, C++17 n4594/12.8/32
BUG=633258
TEST=Ran bots. Build component_unittests under simple chrome env.
Review-Url: https://codereview.chromium.org/2394883004
Cr-Commit-Position: refs/heads/master@{#423436}
Roll src/third_party/skia/ 374772bd6..d207884bf (1 commit).
https://chromium.googlesource.com/skia.git/+log/374772bd6195..d207884bf5d1
$ git log 374772bd6..d207884bf --date=short --no-merges --format='%ad %ae %s'
2016-10-05 reed fix printf warning in dumpcanvas
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2400583002
Cr-Commit-Position: refs/heads/master@{#423435}
bluetooth: Expose service data from BlueZ
BlueZ exposed Bluetooth device's ServiceData as a{sv} property[1]
where the dict value variant is an array of byte.
This CL exposes that to upper layer by
- Add support to map<string, vector<uint8_t>> in dbus::Property
- Add new service_data property in BluetoothDeviceClient
- Implement GetServiceDataUUIDs() and GetServiceDataForUUID()
in BluetoothDeviceBlueZ
- Fix misc style issues in original code to make linter happy
[1] http://git.kernel.org/cgit/bluetooth/bluez.git/tree/src/device.c#n2551
BUG=618442,653310,b:28670943
TEST=Manually tested.
Review-Url: https://codereview.chromium.org/2369423003
Cr-Commit-Position: refs/heads/master@{#423434}
Test Xvfb for RandR support
Our RandR patch has now been applied and shipped upstream, so the
previous assumption that only a custom Xvfb will support RandR no longer
holds. This commit changes the logic to explicitly check for RandR
support when using Xvfb.
Additionally, when testing the changes, I discovered that GL was broken
with stock Xvfb. This commit changes the launch of Xvfb to use the child
environment like we do for Xorg, which fixes the problem.
BUG=643790
Review-Url: https://codereview.chromium.org/2363433002
Cr-Commit-Position: refs/heads/master@{#423433}
Prune createVisibleSelectionDeprecated from Element
BUG=651373
Review-Url: https://codereview.chromium.org/2399753002
Cr-Commit-Position: refs/heads/master@{#423432}
CSS: test that transform properties create containing block
Add test that verifies 'perspective', 'translate', 'scale',
'rotate' create a containing block, just like 'transform'.
Also check if listing these properties in will-change
causes a containing block to be created.
(These checks currently fail - see bug.)
BUG=650607
Review-Url: https://codereview.chromium.org/2380723003
Cr-Commit-Position: refs/heads/master@{#423431}
Remove the ability append a Vector<char> or Vector<LChar> to a WTF::String.
Nothing ever does this today, lets remove it and make the code simpler,
we can add it back in the future if needed. Callers can also use a
StringView(vector.data(), vector.length()) instead.
Review-Url: https://codereview.chromium.org/2397973002
Cr-Commit-Position: refs/heads/master@{#423430}
Rename mojo: to service:
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2390013002
Cr-Commit-Position: refs/heads/master@{#423429}
Enable OPUS and VP9 codecs on Android for Clear Key key system
Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.
BUG=652896
Review-Url: https://codereview.chromium.org/2394873004
Cr-Commit-Position: refs/heads/master@{#423428}
[Mac Fix-It] Removed usage of deprecated resource fork API.
There is no modern API to open resource forks on macOS. Currently used
API is deprecated and its usage should be removed as a part of
"Chrome Mac Deployment Target Fix-It". |URLFromInetloc| allows opening
of webloc files created by Safari, which works fine just by reading data
from webloc plist. New implementation will not open resource forks, but
it's very unlikely that they would exist on modern macOS.
BUG=650805
Review-Url: https://codereview.chromium.org/2391653003
Cr-Commit-Position: refs/heads/master@{#423427}
Enable more browser tests that now pass with PlzNavigate.
BUG=504347
Review-Url: https://codereview.chromium.org/2395973002
Cr-Commit-Position: refs/heads/master@{#423426}
[Mac Fix-It] removed base::mac::AmIForeground function.
Use [[NSRunningApplication currentApplication] isActive]
call instead.
BUG=650854
Review-Url: https://codereview.chromium.org/2394733002
Cr-Commit-Position: refs/heads/master@{#423425}
Do not use registerMockedURLLoadWithCustomResponse() where not needed
registerMockedURLLoad() can be used when no custom headers etc. are set.
This CL also fixes some mime types/URLs (that don't affect tests though).
BUG=None
Review-Url: https://codereview.chromium.org/2395753002
Cr-Commit-Position: refs/heads/master@{#423424}
Roll src/third_party/catapult/ f5dda2322..b15a8c1c4 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f5dda2322c74..b15a8c1c4173
$ git log f5dda2322..b15a8c1c4 --date=short --no-merges --format='%ad %ae %s'
2016-10-05 dtu [code health] Create common/ and services/ folders within dashboard.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2393223003
Cr-Commit-Position: refs/heads/master@{#423423}
Make mojom.srcjar files produce hermetic zip files.
This makes compiles faster because they can now detect
when inputs haven't changed.
BUG=523420
Review-Url: https://codereview.chromium.org/2396803003
Cr-Commit-Position: refs/heads/master@{#423422}
Reflow comments in //third_party/WebKit/Source/core/editing/state_machines
BUG=563793
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2396833003
Cr-Commit-Position: refs/heads/master@{#423421}
Roll src/third_party/libvpx/source/libvpx/ 50b9c467d..897870497 (8 commits).
https://chromium.googlesource.com/webm/libvpx.git/+log/50b9c467da77..897870497024
$ git log 50b9c467d..897870497 --date=short --no-merges --format='%ad %ae %s'
2016-09-21 sarahparker Remove rate deviation metric from vp8
2016-10-03 johannkoenig Connect partial IDCT tests
2016-09-30 angiebird Move highbd txfm input range check from 2d iht transform to 1d idct/iadst
2016-10-03 kaustubh.raste Fix vpx_plane_add_noise_msa functionality bit-mismatch
2016-10-03 marpan Update to vpx_temporal_svc_encoder command line.
2016-04-13 gezalore Fix warning when building with GCC 5.
2016-10-01 jzern invalid_file_test: quiet unused const warning
2016-09-30 jzern cosmetics,*_neon.c: rm redundant return from void fns
BUG=651625
Review-Url: https://codereview.chromium.org/2395863002
Cr-Commit-Position: refs/heads/master@{#423420}
MacViews: Implement Force Touch/Mac dictionary lookup for Textfields.
This CL adds support to MacViews for Force touch and dictionary lookups. This is
achieved by implementing quickLookWithEvent: on the BridgedContentView. A new
interface called WordLookupClient is added which is to be implemented by views
which support word lookups. Currently only views::Textfield implements this
interface. A virtual method GetWordLookupClient is added to views::View to
retrieve the WordLookupClient associated with a given View. Support is added to
the RenderText class to retreive the word displayed at a given point along with
its styling information. A DecoratedText class is also introduced to encapsulate
the styling information for some given text.
Note, this CL only adds support for dictionary lookups to Views::Textfields.
Doc- https://docs.google.com/a/google.com/document/d/17QYrMpIXpk-FpGanjhJ-Yx33njNQy7B5oL_bxb7-vns/edit?usp=sharing.
BUG=640502
TEST= Enable chrome://flags/#mac-views-native-dialogs. Open Bookmark Bubble.
Enter some text in the name textfield. Hover over the text and press
Ctrl+Command+D. Verify that a dictionary popup appears showing the definition of
the word, the mouse was hovering on.
Review-Url: https://codereview.chromium.org/2348143003
Cr-Commit-Position: refs/heads/master@{#423419}
Updating trunk VERSION from 2882.0 to 2883.0
Cr-Commit-Position: refs/heads/master@{#423418}
Update V8 to version 5.5.374.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e1e2ee10..ee4a49f5
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2397073002
Cr-Commit-Position: refs/heads/master@{#423417}
reflow comments in core/events,core/fileapi
BUG=563793
NOTRY=true
Review-Url: https://codereview.chromium.org/2394653003
Cr-Commit-Position: refs/heads/master@{#423416}
ChromeOS: Implement Update screen of material design OOBE.
This CL adds Update screen to material design OOBE.
BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2392273002
Cr-Commit-Position: refs/heads/master@{#423415}
Roll src/third_party/skia/ 61c21cdcc..374772bd6 (1 commit).
https://chromium.googlesource.com/skia.git/+log/61c21cdcc310..374772bd6195
$ git log 61c21cdcc..374772bd6 --date=short --no-merges --format='%ad %ae %s'
2016-10-05 reed Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints"
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2394833003
Cr-Commit-Position: refs/heads/master@{#423414}
Make aidl .srcjars and lib.java jars use hermetic timestamps
This makes compiles faster because they can now detect
when inputs haven't changed.
BUG=523420
Review-Url: https://codereview.chromium.org/2397683003
Cr-Commit-Position: refs/heads/master@{#423413}
reflow comments in core/css/resolver
BUG=563793
Review-Url: https://codereview.chromium.org/2399633003
Cr-Commit-Position: refs/heads/master@{#423412}
Add UMA to measure feasibility of making unique names immutable
r418350 changed Chrome so that unique names are fixed once the frame has
committed the first real load. Unfortunately, the bug still occurs if
there are in-page navigations on the initial empty document mixed with
window.name changes, since the first real load has not yet committed.
One possible simplification is to just make unique name completely
immutable. However, it's possible that some sites depend on creating a
browsing context, naming it, and then navigating it. This measures how
many sites depend on that behavior (though it doesn't measure how many
sites might be broken if this behavior changes).
BUG=607205
Review-Url: https://codereview.chromium.org/2385773003
Cr-Commit-Position: refs/heads/master@{#423411}
fix pylint warning: build/toolchain/mac/linker_driver.py
W:134, 3: Unused variable 'head' (unused-variable)
W:159, 3: Unused variable 'head' (unused-variable)
Review-Url: https://codereview.chromium.org/2396723003
Cr-Commit-Position: refs/heads/master@{#423410}
reflow comments in core/html/*.{cpp,h},core/html/imports
BUG=563793
NOTRY=true
Review-Url: https://codereview.chromium.org/2384273007
Cr-Commit-Position: refs/heads/master@{#423409}
Reflow comments in //third_party/WebKit/Source/core/editing/markers
BUG=563793
Review-Url: https://codereview.chromium.org/2399723002
Cr-Commit-Position: refs/heads/master@{#423408}
arc: Stop calling HandleUrlListDeprecated.
Remove a call to IntentHelperInstance's
HandleUrlListDeprecated method. The updated HandleUrlList
method has been available for more than four months now.
BUG=647802
Review-Url: https://codereview.chromium.org/2392253003
Cr-Commit-Position: refs/heads/master@{#423407}
Reflow comments in //third_party/WebKit/Source/core/editing/iterators
BUG=563793
Review-Url: https://codereview.chromium.org/2397033002
Cr-Commit-Position: refs/heads/master@{#423406}
[scheduler] Teach scheduler about audio state
This patch wires information about audio state to renderer scheduler
and stops all throttling (background and offscreen) while
audio is playing and for a short period after audio is stopped.
BUG=642321,616519
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2383473002
Cr-Commit-Position: refs/heads/master@{#423405}
Add some NeedsManualRebaseline entries in layout test expectations
This is for preparation to land this skia CL:
https://codereview.chromium.org/2388833002/
BUG=640031
[email protected]
Review-Url: https://codereview.chromium.org/2398893002
Cr-Commit-Position: refs/heads/master@{#423404}
Reflow comments in //third_party/WebKit/Source/core/editing/spellcheck
BUG=563793
Review-Url: https://codereview.chromium.org/2397023002
Cr-Commit-Position: refs/heads/master@{#423403}
[Offline pages] Use the new policy bits
BUG=641053
Review-Url: https://codereview.chromium.org/2342443006
Cr-Commit-Position: refs/heads/master@{#423402}
[Remoting Android] Hide soft keyboard button when physical keyboard is connected
Currently the soft keyboard button on the desktop actionbar is visible when a
physical keyboard is present, in which case the button has unexpected behavior:
* Soft keyboard doesn't show up since physical keyboard is present.
* Actionbar and status bar won't go away since triggering the IME blocks
requests to hide the status bar but won't show any soft keyboard.
Neither can be easily fixed due to limitation of available API. So this CL
hides the soft keyboard button when a physical keyboard is present to prevent
unexpected behaviors.
BUG=640426
Review-Url: https://codereview.chromium.org/2391993004
Cr-Commit-Position: refs/heads/master@{#423401}
MD Settings: Migrating site_data_details_dialog to native select.
BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2395853002
Cr-Commit-Position: refs/heads/master@{#423400}
Adjust Signin Error modal line-height.
BUG=652360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2394053003
Cr-Commit-Position: refs/heads/master@{#423399}
ICO: Skip checking declared entry bounds when file is completelly received.
It is relativelly common that the last entry offset + bytesize is two bytes over
file byte size. When calculating frame count, return entry count and allow
decoder to decode file.
BUG=653075
Review-Url: https://codereview.chromium.org/2391073003
Cr-Commit-Position: refs/heads/master@{#423398}
Record UMA stats for subframes history navigations.
This CL tracks how often subframe history navigations go to a different
URL than the default frame src URL, and how long the unique names are
in these cases when they include frame paths. The latter is useful for
knowing whether a plan to truncate unique names would affect session
history behavior.
This should be reverted after sufficient data is collected.
BUG=626202
TEST=UMA stats reported when going back after navigating an unnamed
child frame, particularly unnamed grandchildren of subframes
with long names.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2398753002
Cr-Commit-Position: refs/heads/master@{#423397}
Rename setFocus() of blink::Node and blink::Widget to setFocused().
A getter function focus() was renamed to isFocused(). This CL renamed setter
functions for consistency.
This CL has no behavior changes.
Review-Url: https://codereview.chromium.org/2397933002
Cr-Commit-Position: refs/heads/master@{#423396}
Prune deprecated editing functions from ApplyBlockElementCommand and its subclasses
This patch prunes the following deprecated functions from ApplyBlockElementCommand
and its subclasses by ensuring clean layout and valid arguments at each call site:
- createVisiblePositionDeprecated
- createVisibleSelectionDeprecated
- VisibleSelection::visible{Start,End}Deprecated
- nextPositionOfDeprecated
- paragraph related deprecated functions
BUG=647219,651373
Review-Url: https://codereview.chromium.org/2393133002
Cr-Commit-Position: refs/heads/master@{#423395}
Prune createVisibleSelectionDeprecated from CreateLinkCommand
BUG=651373
Review-Url: https://codereview.chromium.org/2391723006
Cr-Commit-Position: refs/heads/master@{#423394}
Plumb StreamTexture to MediaPlayerRenderer
The ScopedSurfaceRequestManager and ScopedSurfaceRequestConduit
allow classes to register a ScopedJavaSurface request in the browser
process, and to send SurfaceTexture from the GPU process to the
browser process to fulfill those requests.
This change adds the necessary plumbing to send a StreamTexture to
a MediaPlayerRenderer living in the browser, using the
manager/conduit pair.
N.B: In order to prevent the MojoRendererService from taking a
dependency on the MediaPlayerRenderer, the MojoRendererService
initiates surface requests via a callback (given at construction time).
BUG=627658
TEST=successfully exercised the new code path in a working prototype.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2282633002
Cr-Commit-Position: refs/heads/master@{#423393}
Fix a NodeList invalidation bug caused by Oilpan.
This CL fixes a regression since M50.
NodeRareData::traceAfterDispatch() clears m_nodeLists if the NodeListsNodeData
is empty. If Oilpan GC is triggered by ChildNodeList / EmptyNodeList allocation
just after NodeListsNodeData creation, NodeListsNodeData was incorrectly
disconnected from NodeRareData.
Implementation:
Forbid GC during NodeListsNodeData creation and a following NodeListsNodeData
method call. This CL introduces ThreadState::GCForbiddenScope class.
Also, adds multiple DCHECKs() which failed for crbug.com/622103.
This CL has no tests because it's difficult to trigger Oilpan GC during a specific
memory allocation.
BUG=622103
[email protected]
Review URL: https://codereview.chromium.org/2393633003 .
Cr-Commit-Position: refs/heads/master@{#423392}
[Mac Fix-It] Changed OpenApplicationWithPath to use NSWorkspace.
This removes base::mac::FSRefFromPath usage from
OpenApplicationWithPath. |FSRefFromPath| is relying on deprecated API
and should be removed.
BUG=650854
Review-Url: https://codereview.chromium.org/2390953003
Cr-Commit-Position: refs/heads/master@{#423391}
Filter more windows to reduce # of windows observe in ArcAppWindowLauncherController
[email protected]
BUG=None
Review-Url: https://codereview.chromium.org/2399683002
Cr-Commit-Position: refs/heads/master@{#423390}
[Reland] Refactor WebappRegistry into a singleton instance.
This CL refactors WebappRegistry and WebappDataStorage to make most of
the methods synchronous. WebappRegistry is now a singleton instance that
is instantiated at browser startup. This allows all SharedPreferences files to
be pre-warmed before the class is used; new web apps open new
SharedPreferences on a background thread when registered, after which the
preferences are cached automatically.
Most static methods on WebappRegistry and WebappDataStorage have been
converted to instance methods or removed. This makes the code much
cleaner and more efficient; each static method had to independently open
their SharedPreferences, which minimally performs a stat() on the
underlying XML file to see if it has changed. Now the singleton
WebappRegistry caches all WebappDataStorage objects on startup and
whenever new ones are added. This reduces disk IO overhead.
This CL allows all calls to SharedPreferences.Editor.apply() in
WebappRegistry and WebappDataStorage to occur on the main thread,
mostly removing the need for unwieldy callback interfaces and bare
pointer passing across the JNI.
BUG=633791
Review-Url: https://codereview.chromium.org/2351113005
Cr-Commit-Position: refs/heads/master@{#423389}
Reland: VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1
This CL migrates the renderer (client) side of the
communication VCImp --> VCHost that was forgotten
in the reverted CL (all due to my misunderstanding,
apologies!).
Unittests are also updated, constituting the bulk of
the CL.
Original CL description ------------------------------------------------
VideoCapture: migrate VideoCapture renderer-->host messages to mojo, part 1
This CL migrates the easy-to-migrate video_capture_messages from
IPC to mojom. "Easy" refers to those messages whose data types are
readily available.
BUG=651897
TEST=./out/gn/content_unittests --gtest_filter=*VideoCapture*,
content_browsertests and video capture working as before.
Review-Url: https://codereview.chromium.org/2390103002
Cr-Commit-Position: refs/heads/master@{#423388}
Add RAPPOR metric for sites not reporting first meaningful paint
First Meaningful Paint UMA is not recorded on >20% of page loads. This
RAPPOR metric will help identify top sites that fail to report First
Meaningful Paint.
BUG=632081
Review-Url: https://codereview.chromium.org/2398573002
Cr-Commit-Position: refs/heads/master@{#423387}
Port storage manager to MD settings.
This CL adds an "Storage management" item on MD settings/Device, and it shows the size of each storage item.
C++ side implementation is basically copied from old setting's one.
(I don't share the implementation assuming that the old one will be removed.)
Following are not implemented.
- The UI design is temporary.
- metrics/tests will be added separately.
BUG=629438
TEST=with the flag "--enable-md-storage-manager=1", manually tested that chrome://md-settings/storage shows the same items/values with chrome://settings/storage
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2348913002
Cr-Commit-Position: refs/heads/master@{#423386}
[mb] Use optimize_for_fuzzing for libfuzzer bots.
[email protected]
BUG=643249
Review-Url: https://codereview.chromium.org/2393993002
Cr-Commit-Position: refs/heads/master@{#423385}
[Extensions] Add metrics for execution time of binding.js
Add UMA for the time it takes for the BindingGeneratingNativeHandler
to create the JS object representing an API object. Since this tends to
be a fast process (but a repeated one), use microsecond accuracy.
BUG=608561
Review-Url: https://codereview.chromium.org/2395803003
Cr-Commit-Position: refs/heads/master@{#423384}
Use -O1 in more optimize configs when optimize_for_fuzzing=true.
BUG=643249
Review-Url: https://codereview.chromium.org/2397873003
Cr-Commit-Position: refs/heads/master@{#423383}
fix highbit video
My recent cl for implementing 12-bit video broke re-drawing of highbit video layers.
This is because the resource has to be marked with the right multiplier & offset every time,
even if we're re-using the texture. This fixes that.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2395943002
Cr-Commit-Position: refs/heads/master@{#423382}
Update V8 to version 5.5.373.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3cbd5838..e1e2ee10
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2398873002
Cr-Commit-Position: refs/heads/master@{#423381}
media: Fix gn deps on //media/test
BUG=599578
TEST=gn check //media/test/* is clean
Review-Url: https://codereview.chromium.org/2387063004
Cr-Commit-Position: refs/heads/master@{#423380}
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"
On debug mode the WPT will start before image/document is loaded.
This CL changed the tests to use styled text (instead of image) as
drag data.
Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)
BUG=652979
Review-Url: https://codereview.chromium.org/2393903003
Cr-Commit-Position: refs/heads/master@{#423379}
