Publish DEPS for Chromium 54.0.2816.4
Incrementing VERSION to 54.0.2816.4
Cr-Commit-Position: refs/branch-heads/2816@{#6}
Cr-Branched-From: 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090}
Incrementing VERSION to 54.0.2816.3
Cr-Commit-Position: refs/branch-heads/2816@{#5}
Cr-Branched-From: 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090}
Properly set the BufferToTextureTargetMap in Blimp
Make sure to set the texture target map properly. This is temporary as
this code will be going away shortly. Android (and the Linux client)
look like they only use GL_TEXTURE_2D for the map entries, so hard
coding that for the standalone app.
BUG=632418
Review-Url: https://codereview.chromium.org/2207453002
Cr-Commit-Position: refs/heads/master@{#409213}
(cherry picked from commit 5ea3a8291f91fcddc9e408b50b736f0d5ea929a1)
Review URL: https://codereview.chromium.org/2198983005 .
Cr-Commit-Position: refs/branch-heads/2816@{#4}
Cr-Branched-From: 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090}
Incrementing VERSION to 54.0.2816.2
Cr-Commit-Position: refs/branch-heads/2816@{#3}
Cr-Branched-From: 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090}
orderfile: Don't report failure when a single symbol pair is misordered.
A single misordered pair is not going to affect startup
performance. Making this a warning only, as it broke the official
builders. This is not a fix, unfortunately.
BUG=633059
Review-Url: https://codereview.chromium.org/2203583003
Cr-Commit-Position: refs/heads/master@{#409185}
(cherry picked from commit ee9e2530c546263077857f6590727d43ffb24321)
Review URL: https://codereview.chromium.org/2203043002 .
Cr-Commit-Position: refs/branch-heads/2816@{#2}
Cr-Branched-From: 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090}
Incrementing VERSION to 54.0.2816.1
Cr-Commit-Position: refs/branch-heads/2816@{#1}
Cr-Branched-From: 5ca3397bac11535fb30249c96b9ee311fe2474a8-refs/heads/master@{#409090}
Remove a DCHECK from QuicChromiumClientSession::TryCreateStream
now that QuicSession correctly handles writes when no encryption
has been established.
Review-Url: https://codereview.chromium.org/2202003002
Cr-Commit-Position: refs/heads/master@{#409090}
Add configuration_changed event and set_background_opacity request.
* remote shell API version is updated to 9.
* Send the current primary display info because primary display is dynamic and can change or even go away.
* This also fixed a bug where a underlay wasn't created when it started maximized.
BUG=632083
TEST=tested on new and old impl on android side. Updated unit test.
Review-Url: https://codereview.chromium.org/2189073003
Cr-Commit-Position: refs/heads/master@{#409089}
MD Settings: Inherit font size in passwords/autofill shared menu
Switching to a native button element caused these elements to use the
default User Agent stylesheet fonts. This caused the menu items to
render in the system font rather than Roboto, and to not adjust to
changes in font size preferences.
BUG=629811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2202433002
Cr-Commit-Position: refs/heads/master@{#409088}
TaskManager: when shown or activated, select the last active tab.
Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.
Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).
Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.
BUG=614551
TEST=included browser_test
Review-Url: https://codereview.chromium.org/2146273002
Cr-Commit-Position: refs/heads/master@{#409087}
[Chromedriver] Disable java tests on Linux AND v53
BUG=chromedriver:1418
Review-Url: https://codereview.chromium.org/2190973002
Cr-Commit-Position: refs/heads/master@{#409086}
Roll DEPS for bringing in custom tabs client changes
BUG=622894
Review-Url: https://codereview.chromium.org/2198353002
Cr-Commit-Position: refs/heads/master@{#409085}
Make strings consistent in Android and desktop chooser
This CL changes some of the strings in Android and desktop chooser to
make them consistent:
1. Use uppercase 'G' for "Get help" in Android chooser.
2. Use "Scanning" in Android chooser.
3. Use "Re-scan" in Android chooser.
4. Use "No Bluetooth devices found" in desktop chooser.
5. Use uppercase 'B' for "Bluetooth" in Android chooser.
BUG=583452
Review-Url: https://codereview.chromium.org/2198323002
Cr-Commit-Position: refs/heads/master@{#409084}
GN: Set |enable_webvr| in the declare_args() block.
This effectively makes it a configurable argument that can be changed by
downstreams and users alike; so far, trying to change it via `gn args'
failed with:
The variable "enable_webvr" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
BUG=389343
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2198003002
Cr-Commit-Position: refs/heads/master@{#409083}
Roll src/third_party/skia/ d783e0800..1bb5fecbe (2 commits).
https://chromium.googlesource.com/skia.git/+log/d783e08004e2..1bb5fecbea49
$ git log d783e0800..1bb5fecbe --date=short --no-merges --format='%ad %ae %s'
2016-08-01 mtklein Sketch SkPictureRecorder::optimizeFor(GrContext*).
2016-08-01 mtklein GN: use the correct fontconfig font mugger.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2194363002
Cr-Commit-Position: refs/heads/master@{#409082}
Workaround for issue breaking NACL on ChromeOS.
ChromeOS uses AFDO to improve Chrome performance. However, after the GN
migration, NACL broke. We triaged this to using AFDO on
tcmalloc. tcmalloc has some dependencies on specific stack traces and
section allocations that may break once AFDO is used. So, we need to
disable AFDO for the file debugallocation_shim.cc (object bisecting
pointed to it). We need a quick workaround, so we are doing this with a
GCC pragma. The real solution will come in a few days by a change in GN
to avoid passing -fauto-profile to tcmalloc files.
BUG=chromium:629593
TEST=verified by hand problem does not reproduce after this change.
Review-Url: https://codereview.chromium.org/2198253002
Cr-Commit-Position: refs/heads/master@{#409081}
gn: Update clang_version when using ToT Clang
Tip-of-tree Clang is now at 4.0.0.
BUG=none
Review-Url: https://codereview.chromium.org/2201983002
Cr-Commit-Position: refs/heads/master@{#409080}
Switch all LayoutTests to use new accessibility relative bounding box API.
This change switches test_runner to use only the new relative bounding box
API to get bounding boxes of accessibility elements.
I made a few fixes in order to get existing tests to pass:
* Support explicit element rects inside a canvas
* Implement bounding boxes for inline text boxes
* Bounding box for LayoutText needs to clip to ellipses
* Bounding box for LayoutInline needs to include continuations
The next step will be to switch Chrome to use the new API, then we can
delete the old bounding box code from blink.
BUG=618120
Review-Url: https://codereview.chromium.org/2169273004
Cr-Commit-Position: refs/heads/master@{#409079}
Add synthetic trial APIs allowing a study with multiple groups.
This is needed because for experiment ids coming from outside
sources, we do not have information on their study names and thus
have to synthesize them, which may result in multiple experiments
being nested under one study name in a given instance.
This CL changed the registerExternalExperiment() Java API and
underlying code to the new format. This API was implemented for
a previously planned version of this feature but was never used. We
now plan to use this (which will be done in a follow-up CL) and the
new signature (multiple groups) is required.
BUG=632409
Review-Url: https://codereview.chromium.org/2178363004
Cr-Commit-Position: refs/heads/master@{#409078}
android: Swallow PopupWindow exception from android
This is a workaround for Android L bug with PopupWindow.
BUG=633224
Review-Url: https://codereview.chromium.org/2201923002
Cr-Commit-Position: refs/heads/master@{#409077}
Allow long function names in pylintrc
Out of the ~283[1] python function names in third_party/WebKit/ at least
~44 (15%) are longer than 30 characters[2]. This increases the name limit.
[1] https://cs.chromium.org/search/?q=f:third_party/Webkit+%5Edef%5C++lang:%5Epython$&sq=package:chromium&type=cs
[2] https://cs.chromium.org/search/?q=f:third_party/Webkit+%5Edef%5C+%5Ba-zA-Z0-9_%5D%7B31%7D+lang:%5Epython$&sq=package:chromium&type=cs
Review-Url: https://codereview.chromium.org/2196113003
Cr-Commit-Position: refs/heads/master@{#409076}
Settings Menu: Apply actionable attribute to Advanced expand trigger.
BUG=633102
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2202743002
Cr-Commit-Position: refs/heads/master@{#409075}
Fix task groups to always be self-consistent.
BUG=632775
TEST=TaskManagerBrowserTest.*
Review-Url: https://codereview.chromium.org/2195873002
Cr-Commit-Position: refs/heads/master@{#409074}
[Devtools] Fix multi-line curl copy response when multi-part-form
This patch fixes a bug with windows where when a user would copy
command as curl from devtools network panel it would not copy properly
if data in the request had multiple lines.
BUG=505391
Review-Url: https://codereview.chromium.org/2182213006
Cr-Commit-Position: refs/heads/master@{#409073}
Make MSE buffer sizes configurable via command line
BUG=630342
Review-Url: https://codereview.chromium.org/2170303002
Cr-Commit-Position: refs/heads/master@{#409072}
Move SchedulerWorkerPoolParams to the base Namespace
BUG=553459
Review-Url: https://codereview.chromium.org/2196373002
Cr-Commit-Position: refs/heads/master@{#409071}
Fix fuzzing shift direction bug found in presentation
I saw this bug in a slide and it is also in the code. Need to right shift to remove the LSB.
Review-Url: https://codereview.chromium.org/2203573002
Cr-Commit-Position: refs/heads/master@{#409070}
Make "All Bookmarks" to be controlled by feature
This is used for controlling this feature in field trial, which targets
at M52.
BUG=605614
Review-Url: https://codereview.chromium.org/2199033002
Cr-Commit-Position: refs/heads/master@{#409069}
Fix the incorrect accessibility description for the bookmark icon on Android tablet.
BUG=506377
Review-Url: https://codereview.chromium.org/2194713002
Cr-Commit-Position: refs/heads/master@{#409068}
Show "pages" not "sheets of paper" on print to drive.
Top left message box printed "sheets of paper" message
when printing to Google Drive. Modified so it simply
states the number of pages, as with print to PDF.
BUG=632758
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2197393002
Cr-Commit-Position: refs/heads/master@{#409067}
Fixes a crash resulting from nativeSetGamepadData not being properly registered with JNI.
BUG=632692
Review-Url: https://codereview.chromium.org/2196913002
Cr-Commit-Position: refs/heads/master@{#409066}
Revert of [Sync] Merge sync_unit_tests into components_unit_tests. (patchset #4 id:60001 of https://codereview.chromium.org/2186733002/ )
Reason for revert:
Seems to be causing compile failure on Linux https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/49248
Original issue's description:
> [Sync] Merge sync_unit_tests into components_unit_tests.
>
> BUG=626114
>
> Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d
> Cr-Commit-Position: refs/heads/master@{#409060}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626114
Review-Url: https://codereview.chromium.org/2205613002
Cr-Commit-Position: refs/heads/master@{#409065}
Reland of Use only toolbar to transition from fakebox to real omnibox. (patchset #1 id:1 of https://codereview.chromium.org/2198993002/ )
Reason for revert:
Was not the culprit for webkit_unit_tests failing.. relanding
Original issue's description:
> Revert of Use only toolbar to transition from fakebox to real omnibox. (patchset #11 id:200001 of https://codereview.chromium.org/2134663002/ )
>
> Reason for revert:
> Suspect for http://crbug.com/633321, will re-land if not.
>
> Original issue's description:
> > Use only toolbar to transition from fakebox to real omnibox.
> >
> > Previously, we would fade out the fakebox and fade in the real omnibox during
> > the scroll transition, which created discrepancies. With this change, the
> > toolbar omnibox does the full transition. The search box on the NTP is still
> > kept, both to get the starting point of the transition, and for the tablet
> > toolbar, where the omnibox stays at the top, so there are two boxes.
> >
> > Because the two boxes now have to match, their dimensions and padding are
> > slightly updated. The height is 56dp, and the padding on the sides is 12dp.
> >
> > Also, in the focused state the omnibox now has 1dp bleed at the sides,
> > which moves the rounded corners out of view.
> >
> > The remaining changes are not user-visible:
> > * Opacity of the fakebox is now driven by the toolbar. This lets us centralize
> > the logic (the toolbar can decide its own opacity and the opacity of the
> > fakebox) and use different behavior on tablets, where the fakebox will simply
> > fade out as before.
> > * Rename variables to (hopefully) make them more consistent / self-explanatory.
> > * |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more accurately
> > reflects the visible omnibox bounds in the absence of the NTP / when the NTP
> > is scrolled so that the omnibox is at the top. To do that, we no longer
> > include the Y translation we apply to position it where the fakebox is (it's
> > instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
> > an expansion value of 1 if the current tab is an NTP.
> > * Remove the |inset_textbox| drawable -- it was the same as |textbox|, but with
> > a margin added at the top and bottom (but *not* left or right). Since we
> > calculate the omnibox bounds manually anyway, this allows us to account for
> > the omnibox padding in the same way in either dimension.
> > * Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
> > the member variable.
> >
> > BUG=605054,625108,618955,616728,612520
> >
> > Committed: https://crrev.com/7a676cfc5291809bf2a95fd16ba1d57907f7961a
> > Cr-Commit-Position: refs/heads/master@{#408885}
>
> [email protected],[email protected],[email protected],[email protected],[email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=605054,625108,618955,616728,612520
>
> Committed: https://crrev.com/ed720fdd749d46e0934267bd8f935bbeb1ec0991
> Cr-Commit-Position: refs/heads/master@{#409045}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605054,625108,618955,616728,612520
Review-Url: https://codereview.chromium.org/2204613002
Cr-Commit-Position: refs/heads/master@{#409064}
mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization
BUG=626811
Review-Url: https://codereview.chromium.org/2204473002
Cr-Commit-Position: refs/heads/master@{#409063}
Downgrade node introduction failure message to DVLOG(0)
DLOG(ERROR) is too spammy since this can occur any time a child
process exits and almost never indicates that there's an actual
problem a developer should be aware of.
[email protected]
BUG=None
Review-Url: https://codereview.chromium.org/2198273002
Cr-Commit-Position: refs/heads/master@{#409062}
Updating XTBs based on .GRDs from branch master
Cr-Commit-Position: refs/heads/master@{#409061}
[Sync] Merge sync_unit_tests into components_unit_tests.
BUG=626114
Review-Url: https://codereview.chromium.org/2186733002
Cr-Commit-Position: refs/heads/master@{#409060}
DevTools: [Console] revert filtering out URLs from %c styling properties
The patch reverts logic which filters URL's from %c styling properties.
(which was added in crrev.com/1191983002)
The motivation behind this current implementation is naive and doesn't
address the issue.
BUG=495643
R=dgozman
Review-Url: https://codereview.chromium.org/2201913002
Cr-Commit-Position: refs/heads/master@{#409059}
Add a user action for when the home button is clicked.
"Home" matches the existing desktop user action.
BUG=633326
Review-Url: https://codereview.chromium.org/2203553002
Cr-Commit-Position: refs/heads/master@{#409058}
Roll src/third_party/skia/ abbd6d5e0..d783e0800 (9 commits).
https://chromium.googlesource.com/skia.git/+log/abbd6d5e0283..d783e08004e2
$ git log abbd6d5e0..d783e0800 --date=short --no-merges --format='%ad %ae %s'
2016-08-01 bungeman Replace 'Ulta' with 'Ultra'.
2016-08-01 herb Pick the right download tool for windows.
2016-08-01 dvonbeck Added distance vector support for CircleGeometryProcessor
2016-08-01 reed implement isABitmap for imageshader, return localmatrix for bitmap's impl
2016-08-01 mtklein Replace old SkRecords RefBox with sk_sp.
2016-08-01 reed make an image from a mutable bitmap
2016-08-01 dvonbeck GrFP can express distance vector field req., program builder declares variable for it
2016-08-01 mtklein GN: only include headers in echo_headers.py
2016-08-01 vjiaoblack adding new GM to demostrate new shadows
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2194313002
Cr-Commit-Position: refs/heads/master@{#409057}
Fix pathpattern warning and delete eml support
EML is a generic MIME file format, that can contain arbitrary email messages, including attachments etc. We want to stay focus on mhtml only.
BUG=633271
Review-Url: https://codereview.chromium.org/2197343002
Cr-Commit-Position: refs/heads/master@{#409056}
Mark AVDA construction thread in use during delete.
Previously, AVDA::ReleaseMediaCodec would DeleteSoon the MediaCodec
instance on the construction thread in some cases. It would not
mark the construction thread as in use. This does not prevent
~AVDA to stop the construction thread, so if the release hangs, then
so will ~AVDA.
BUG=619412
Review-Url: https://codereview.chromium.org/2201753003
Cr-Commit-Position: refs/heads/master@{#409055}
Remove unused copy of sync_handle_registry.h
mojo/public/cpp/bindings/lib/sync_handle_registry.h was moved up
a level and this copy was left in place. BALETED.
[email protected]
BUG=None
Review-Url: https://codereview.chromium.org/2204553002
Cr-Commit-Position: refs/heads/master@{#409054}
Fix an error in the PGO mb config.
BUG=632864
Review-Url: https://codereview.chromium.org/2198963002
Cr-Commit-Position: refs/heads/master@{#409053}
Add PTHREAD_PRIO_INHERIT Locks for Mac
The Browser Task Scheduler will be using thread priorities.
PTHREAD_PRIO_INHERIT will help avoid priority inversion with the use of thread
priorities on Mac.
Linux currently cannot use them due to security concerns in the kernel priority
inheritance futex.
BUG=611856
Review-Url: https://codereview.chromium.org/2178503003
Cr-Commit-Position: refs/heads/master@{#409052}
[Sync] Add option to remove device from "Other devices" on desktop
It is possible on Android/iOS to remove device entry from "Recent tabs"
page. I'm adding item to drop-down menu on history page that offers
similar functionality for desktop.
BUG=280665
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2069183002
Cr-Commit-Position: refs/heads/master@{#409051}
Fill user_population field in PPAPI download ping.
Plus minor refactor on download_protection_service_unittest.cc to get rid of
deprecated message_loop.
BUG=632170
Review-Url: https://codereview.chromium.org/2186913005
Cr-Commit-Position: refs/heads/master@{#409050}
Revert of On Linux rework driver_version/vendor extraction from gl version (patchset #11 id:200001 of https://codereview.chromium.org/2153373002/ )
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=633286
Original issue's description:
> On Linux rework driver_version/vendor extraction from gl version
>
> Previously it could not extract them from the gl version
> "3.3 (Core Profile) Mesa 10.5.9" because of the presence
> of '(Core Profile)'.
>
> BUG=628929
>
> [email protected], [email protected], [email protected]
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
>
> Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
> Committed: https://crrev.com/f65e8f9730d970724d533a27b96d7c6388c84358
> Cr-Original-Commit-Position: refs/heads/master@{#407804}
> Cr-Commit-Position: refs/heads/master@{#408604}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628929
Review-Url: https://codereview.chromium.org/2198243002
Cr-Commit-Position: refs/heads/master@{#409049}
[LayoutNG] Add blink runtime feature flag for LayoutNG.
BUG=591099
Review-Url: https://codereview.chromium.org/2197843002
Cr-Commit-Position: refs/heads/master@{#409048}
Setting Router Refactor: Implement RouteObserverBehavior.
This also removes most of the contents of settings-router. It still
exists for now to propagate the property update, but will be removed
once everything uses RouteObserverBehavior.
BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2193333002
Cr-Commit-Position: refs/heads/master@{#409047}
Refactoring Me2MeNativeMessagingHost to implement NativeMessageHost interface
This change updates the Me2Me native messaging host to use the same interface
as the It2Me native messaging host. This change reduces the differences
between the two hosts and will make it simpler to continue the refactoring in
my next change to allow Me2Me and It2Me native messaging hosts to share the
same process elevation logic and communication channel.
BUG=617185
Review-Url: https://codereview.chromium.org/2153313002
Cr-Commit-Position: refs/heads/master@{#409046}
Revert of Use only toolbar to transition from fakebox to real omnibox. (patchset #11 id:200001 of https://codereview.chromium.org/2134663002/ )
Reason for revert:
Suspect for http://crbug.com/633321, will re-land if not.
Original issue's description:
> Use only toolbar to transition from fakebox to real omnibox.
>
> Previously, we would fade out the fakebox and fade in the real omnibox during
> the scroll transition, which created discrepancies. With this change, the
> toolbar omnibox does the full transition. The search box on the NTP is still
> kept, both to get the starting point of the transition, and for the tablet
> toolbar, where the omnibox stays at the top, so there are two boxes.
>
> Because the two boxes now have to match, their dimensions and padding are
> slightly updated. The height is 56dp, and the padding on the sides is 12dp.
>
> Also, in the focused state the omnibox now has 1dp bleed at the sides,
> which moves the rounded corners out of view.
>
> The remaining changes are not user-visible:
> * Opacity of the fakebox is now driven by the toolbar. This lets us centralize
> the logic (the toolbar can decide its own opacity and the opacity of the
> fakebox) and use different behavior on tablets, where the fakebox will simply
> fade out as before.
> * Rename variables to (hopefully) make them more consistent / self-explanatory.
> * |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more accurately
> reflects the visible omnibox bounds in the absence of the NTP / when the NTP
> is scrolled so that the omnibox is at the top. To do that, we no longer
> include the Y translation we apply to position it where the fakebox is (it's
> instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
> an expansion value of 1 if the current tab is an NTP.
> * Remove the |inset_textbox| drawable -- it was the same as |textbox|, but with
> a margin added at the top and bottom (but *not* left or right). Since we
> calculate the omnibox bounds manually anyway, this allows us to account for
> the omnibox padding in the same way in either dimension.
> * Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
> the member variable.
>
> BUG=605054,625108,618955,616728,612520
>
> Committed: https://crrev.com/7a676cfc5291809bf2a95fd16ba1d57907f7961a
> Cr-Commit-Position: refs/heads/master@{#408885}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605054,625108,618955,616728,612520
Review-Url: https://codereview.chromium.org/2198993002
Cr-Commit-Position: refs/heads/master@{#409045}
[DevTools] Move canExecuteScript to V8DebuggerClient.
BUG=631162
Review-Url: https://codereview.chromium.org/2194063002
Cr-Commit-Position: refs/heads/master@{#409044}
Refactoring Native Messaging Host process launching code into its own file.
This change will allow Me2Me and It2Me native messaging hosts to use the same
code to launch and commnicate with an elevated (admin/uiaccess) child process.
BUG=617185
Review-Url: https://codereview.chromium.org/2152953002
Cr-Commit-Position: refs/heads/master@{#409043}
exo: Set widget parent to target root window
Windows created by the active window on a secondary display would appear
on the primary display instead of the same display.
BUG=631136
TEST=weston-terminal: Right-click > Open Terminal on secondary display.
TEST=Opening windows in ARC apps still works.
Review-Url: https://codereview.chromium.org/2179243002
Cr-Commit-Position: refs/heads/master@{#409042}
DevTools: allow module scripts reside in the module folders upon modular build.
TBR=dgozman
Review-Url: https://codereview.chromium.org/2197373002
Cr-Commit-Position: refs/heads/master@{#409041}
Reland [Android] Set platform mode as default for perf tests.
BUG=615157, 632922
Review-Url: https://codereview.chromium.org/2201843002
Cr-Commit-Position: refs/heads/master@{#409040}
Submit button does not show up on md-settings anymore.
BUG=630385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2172823002
Cr-Commit-Position: refs/heads/master@{#409039}
Add a hash_store_contents implementation which reads/writes from the Windows registry
BUG=624858
Review-Url: https://codereview.chromium.org/2112713004
Cr-Commit-Position: refs/heads/master@{#409038}
Roll src/third_party/catapult/ cc2f04068..c02a3be3c (4 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cc2f04068f97..c02a3be3c9c2
$ git log cc2f04068..c02a3be3c --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2204453002
Cr-Commit-Position: refs/heads/master@{#409037}
Unify usage of logging/assert macros in base/
* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs behind !NDEBUG):
- icu_util
- LazyInstance
- CancellationFlag
* Unifies ENABLE_DLOG into DCHECK_IS_ON()
* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()
TBR=rkaplow, alokp, boliu
- rkaplow for chrome/browser/metrics/ side-effects
- alokp for chromecast/ side-effects
- boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing
https://codereview.chromium.org/2135413003/ for https://codereview.chromium.org/2103883004/#msg14)
Review-Url: https://codereview.chromium.org/2163023002
Cr-Commit-Position: refs/heads/master@{#409036}
[LayoutNG] Add NGConstraintSpace class definition
Define initial outline of the constraint space API for LayoutNG by means
of the NG[Derived]ConstraintSpace & NGLayoutOpportunityIterator classes.
BUG=591099
[email protected]
Review-Url: https://codereview.chromium.org/2176343006
Cr-Commit-Position: refs/heads/master@{#409035}
Make the options parameter of TestParser constructor optional.
This is a simple refactoring change; purpose is to make the
TestParser constructor more like how I would expect it to be.
Review-Url: https://codereview.chromium.org/2198553002
Cr-Commit-Position: refs/heads/master@{#409034}
WebGL 2: Mark Windows multisample blit tests as flaky.
Intel and AMD already have blanket flaky suppressions.
BUG=631317
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2197293002
Cr-Commit-Position: refs/heads/master@{#409033}
CHECK for two simultaneous async operations in net::FileStreamContext
It's likely that a net::FileStream client is starting an async operation while
one is already running. Add CHECKs to determine where it is happening.
BUG=487732
Review-Url: https://codereview.chromium.org/2203463002
Cr-Commit-Position: refs/heads/master@{#409032}
Disable page_cycler.top_10_mobile on Nexus 5.
[email protected]
BUG=633222
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;
Review-Url: https://codereview.chromium.org/2197213003
Cr-Commit-Position: refs/heads/master@{#409031}
Fix method-rgx in webkitpy/pylintrc.
This is a follow-up fix to http://crrev.com/2192213002; in that CL,
I made a copy-paste mistake, so the expression was incorrect.
Review-Url: https://codereview.chromium.org/2194033002
Cr-Commit-Position: refs/heads/master@{#409030}
Change "TryJob" -> "Build" in Build class in buildbot module.
This is a follow-up fix to http://crrev.com/2181533002, which merged TryBot into the Build class and moved it to buildbot.py.
Changing this string to "Build" makes the printed repr "Build", which is what one would expect.
Review-Url: https://codereview.chromium.org/2194043002
Cr-Commit-Position: refs/heads/master@{#409029}
Roll src/third_party/skia/ 9be6866e9..abbd6d5e0 (2 commits).
https://chromium.googlesource.com/skia.git/+log/9be6866e9512..abbd6d5e0283
$ git log 9be6866e9..abbd6d5e0 --date=short --no-merges --format='%ad %ae %s'
2016-08-01 msarett Add SkColorSpace::Equals() API
2016-08-01 mtklein Default fake gamma to sRGB.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2197943003
Cr-Commit-Position: refs/heads/master@{#409028}
Introduce an NTPContentSuggestionsEnabled policy
It directly maps to ntp_snippets::prefs::kEnableSnippets
BUG=595713
Review-Url: https://codereview.chromium.org/2162413002
Cr-Commit-Position: refs/heads/master@{#409027}
MD Settings: Cleanup: Appearance fonts page, use data binding.
Even though the HTML was using data binding variables, fontOptions_
and encodingOptions_, JS was ignoring them. Instead it was manually
setting the menuOption variable on every single
<settings-dropdown-menu> instance.
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2191203003
Cr-Commit-Position: refs/heads/master@{#409026}
Perform merging of metrics from providers as an async task.
While this doesn't reduce the total amount of time the UI thead
will spend doing this work, is does break it down into pieces so
there is less jank.
BUG=546019
Review-Url: https://codereview.chromium.org/2170003002
Cr-Commit-Position: refs/heads/master@{#409025}
MD Settings: fix a couple errors
Fix an error when navigating Chrome to a section (e.g. chrome://md-settings/search).
Remove an observer that was removed.
BUG=631332
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2197943002
Cr-Commit-Position: refs/heads/master@{#409024}
Add fallback behavior if the last used profile cannot initialize
Before this CL, if the last used profile cannot be initialized, it will
be a silent exit in Windows and a CHECK failure in other platforms.
In this CL a list of possible fall-back behavior are used (from the top
to the bottom):
(1) open other last opened profiles which was not signed out.
(2) open the user manager (guest profile & system profile)
(3) open other profiles which was not signed out.
(4) at last, show a message box and do not start chromium.
BUG=614753
Review-Url: https://codereview.chromium.org/2047483003
Cr-Commit-Position: refs/heads/master@{#409023}
Add note page to options.
BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2188033005
Cr-Commit-Position: refs/heads/master@{#409022}
Create ScreenWin::GetSystemMetricsInDIP and Correctly Deprecate display::win::GetSystemMetricsInDIP
This allows GetSystemMetricsInDIP to use the primary display for DIP
calculations consistent with MSDN.
BUG=426656
Review-Url: https://codereview.chromium.org/2186163002
Cr-Commit-Position: refs/heads/master@{#409021}
Loosen/improve AtomicFlag semantics.
In particular don't attach to construction thread, the requirement
was I think trying to articulate that it doesn't make sense to call
Set() from different threads as it's then not clear which thread
IsSet() is memory consistent with.
But:
1) What's required is *sequence* not *thread* checking.
2) Calls to Set() need to be sequenced w.r.t. to each other, but not
with respect to construction (AtomicFlag is not modified before Set()).
Update restrictions to reflect that and update comments to reflect the
guarantees provided by them + its usage of atomics/barriers.
Also expose UnsafeReset() outside of "testing", it will be used in
https://codereview.chromium.org/2135413003/.
BUG=629716
Review-Url: https://codereview.chromium.org/2187333002
Cr-Commit-Position: refs/heads/master@{#409020}
DevTools: promote exact method name match in JavaScript outline dialog
BUG=469137
R=dgozman
Review-Url: https://codereview.chromium.org/2196803003
Cr-Commit-Position: refs/heads/master@{#409019}
Removed unnecessary declaration.
The declared function's implementation was removed by refactoring.
Review-Url: https://codereview.chromium.org/2202693002
Cr-Commit-Position: refs/heads/master@{#409018}
Use lossy prefs in the net predictor, and update them more frequently
This patch changes the predictor to use lossy prefs to sync referrer lists,
and updates them upon receiving the load event from a main frame document.
This fixes an issue where prefs are not updated on unclean shutdown, and
a hang during a synchronous thread hop roundtrip.
BUG=78451,621604
Review-Url: https://codereview.chromium.org/2084093002
Cr-Commit-Position: refs/heads/master@{#409017}
[Android] Fix backwards compatibility flags with perf tests running in platform mode.
BUG=615157,632922
Review-Url: https://codereview.chromium.org/2196343002
Cr-Commit-Position: refs/heads/master@{#409016}
DevTools: Merge CodeMirror changes that affect same text range
We can merge the changes emitted by CodeMirror when they manipulate the same
piece of text. Then we can call onTextChanged once for the overall TextRange
change, rather than each individual change.
This speeds up the Undo/Redo of the color text manipulated by the source
color picker.
R=lushnikov
Review-Url: https://codereview.chromium.org/2196893002
Cr-Commit-Position: refs/heads/master@{#409015}
MD Settings: Fix starting height of expanding sections
Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.
One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.
I also considered ways of changing the order of callbacks or adding asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.
[email protected]
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2197093002
Cr-Commit-Position: refs/heads/master@{#409014}
Add parent pointer to NavigationEntryImpl::TreeNode.
Currently the tree of FrameNavigationEntries in NavigationEntryImpl does
not have any way for traversing from an arbitrary node in the tree up
to its parent. This is useful when comparing the expected chain of
ancestors, which is needed to fix issue 628677.
BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2198903002
Cr-Commit-Position: refs/heads/master@{#409013}
Exclude border from tab switcher asset
The inner border of the tab switcher is a separate asset and
therefore does not need to be included at all in the main tab
switcher asset.
BUG=623571
Review-Url: https://codereview.chromium.org/2197263002
Cr-Commit-Position: refs/heads/master@{#409012}
Revert of Speculative fix for perf test performance regressions. (patchset #1 id:1 of https://codereview.chromium.org/2190083002/ )
Reason for revert:
This patch has no effect on perf test performance regressions, although it helped me understand what is really going on.
I've identified two paths forward and neither of them involves having this behavior; hence, removing it.
Original issue's description:
> Speculative fix for perf test performance regressions.
>
> BUG=623804
>
> Committed: https://crrev.com/1eadbdccdb0dee6fe9e169ac374bfa6c1ad9d03d
> Cr-Commit-Position: refs/heads/master@{#408789}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623804
Review-Url: https://codereview.chromium.org/2198193002
Cr-Commit-Position: refs/heads/master@{#409011}
Roll src/third_party/catapult/ f3881da3d..cc2f04068 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f3881da3d75a..cc2f04068f97
$ git log f3881da3d..cc2f04068 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2199763003
Cr-Commit-Position: refs/heads/master@{#409010}
Remove dom_loading from page_load_metrics
dom_loading has been deprecated in the navigation timing spec, so we
are removing it from page_load_metrics metrics as well. See
https://github.com/w3c/navigation-timing/issues/13 for more details.
BUG=632331
Review-Url: https://codereview.chromium.org/2190723005
Cr-Commit-Position: refs/heads/master@{#409009}
GN: update error message for invalid input_conversion.
The current message is off-putting to read every time I get
input_conversion wrong.
BUG=
Review-Url: https://codereview.chromium.org/2186683003
Cr-Commit-Position: refs/heads/master@{#409008}
Sets appropriate font and color for the login error bubble in MD User Manager
before: http://imgur.com/a/HcE5r
after: http://imgur.com/a/aHVfS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2197313002
Cr-Commit-Position: refs/heads/master@{#409007}
Initialize mPrimaryColor in ToolbarModelImpl
With tab reparenting we don't receive any security state updates or
color updates for the tab, because none of those states change. This
exposed an issue inside ToolbarModelImpl where if we are using default
color, it just uses 0 (the initial value of the mPrimaryColor field) for
checking whether the security icon should be tinted. This change
initializes it to the default value on construction.
BUG=623747
Review-Url: https://codereview.chromium.org/2196383002
Cr-Commit-Position: refs/heads/master@{#409006}
bluetooth: Use an actual mojo service for testing FrameConnectedBluetoothDevices
Creates a mojo service whose FrameConnectedBluetoothDevices instance is accessible
to tests.
Also adds a test for FrameConnectedBluetoothDevices being destroyed while
WebContentsImpl is being destroyed.
BUG=615319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2055313002
Cr-Commit-Position: refs/heads/master@{#409005}
Reland of Fold compositing display items into contained drawings if the drawing is a singleton.
Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a singleton.
>
> BUG=628831
>
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}
This reverts patchset #7 id:110001 of https://codereview.chromium.org/2186643002/
(46344c2a474c1599c6cbc44297a1b9afcae04bb6).
Change on the original CL:
- During under-invalidation checking, allow invalidated display items
in cached subsequence as long as they are the same as the the cached
display items. This is to support skipped-cache display items in a
cached subsequence.
- Added an under-invalidation checking test for compositing drawing
folding in cached subsequence.
Review-Url: https://codereview.chromium.org/2198113002
Cr-Commit-Position: refs/heads/master@{#409004}
Remove unused parameter from NotificationUIManager::Create.
Remove unused PrefService* parameter from NotificationUIManager::Create.
[email protected]
Review-Url: https://codereview.chromium.org/2179793003
Cr-Commit-Position: refs/heads/master@{#409003}
[NTP Client] Fix SnippetsService's status reporting
During the initial phases of the snippets service lifetime, it currently
reports frequent state changes and does not use AVAILABLE_LOADING at all
to notify its observers that it is currently fetching. This CL aims at
fixing that to allow showing more useful information to the user.
BUG=627488
Review-Url: https://codereview.chromium.org/2190353002
Cr-Commit-Position: refs/heads/master@{#409002}
Unbreak two iOS bots after gn switch.
https://codereview.chromium.org/2194703002/ broke 3 iOS bots.
https://codereview.chromium.org/2195213002/ fixed one of them,
this fixes the other two.
BUG=621708,633264
[email protected]
TBR=smut
Review URL: https://codereview.chromium.org/2199833002 .
Cr-Commit-Position: refs/heads/master@{#409001}
Revert of Change FYI win clang builders from official to official_optimize. (patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )
Do keep the change for CrWinClangGoma, since that bot doesn't run tests.
Reason for revert:
This was landed without review or motivation and breaks tests on these bots.
Original issue's description:
> Change FYI win clang builders from official to official_optimize.
>
> This changes the config settings for the builders so that they don't
> need to pull internal files.
>
> [email protected], [email protected], [email protected]
> NOTRY=true
> BUG=623659, 630095
>
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
Review-Url: https://codereview.chromium.org/2198153002
Cr-Commit-Position: refs/heads/master@{#409000}
[MD Extensions] Add drag-and-drop functionality
Add the drag-and-drop implementation to drag crxs onto the MD extensions
page to install them.
BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2185243002
Cr-Commit-Position: refs/heads/master@{#408999}
mash: Migrate shelf tooltip manager tests to ash/common.
Move shelf_tooltip_manager_unittest.cc to ash/common/shelf/.
Use AshTestBase::GetPrimaryShelf and WmShelf::GetShelfViewForTesting().
UseShelfView::GetAppListButton and nix ash::Shelf pointer.
Consolidate local CreateTestWidget helper function.
(AshTestBase::CreateTestWidget doesn't work here for some reason...)
BUG=629255
TEST=automated
[email protected]
Review-Url: https://codereview.chromium.org/2196933002
Cr-Commit-Position: refs/heads/master@{#408998}
DevTools: fix front-end closure compilation
The patch fixes compilation, which was broken by crrev.com/2196003002
BUG=none
R=dgozman
Review-Url: https://codereview.chromium.org/2194253002
Cr-Commit-Position: refs/heads/master@{#408997}
Add data dependency directories for blink_tests in BUILD.gn.
Suggested in http://crrev.com/2190163003. This should make it so that the analyze step identifies blink_tests as a dependency for changes in layout tests and WebKit/Tools/Scripts.
BUG=631014
Review-Url: https://codereview.chromium.org/2195223002
Cr-Commit-Position: refs/heads/master@{#408996}
Even if network enumeration is blocked, wait for default IP addresses.
If network enumeration was disabled, the FilteringNetworkManager and
EmptyNetworkManager were not waiting for a network change signal from
the network manager they wrapped before signaling "networks changed".
The assumption was "if network enumeration is disabled, there's no
point in waiting since we give out an empty list anyway." However, even
if enumeration is disabled, we still want the *default* IPv4/IPv6
addresses, and these come from the wrapped network manager.
The result was a race condition with the effect that sometimes, the
candidates for the default interfaces were never gathered.
This CL ensures the network manager wrappers *do* wait in all cases. It
also refactors FilteringNetworkManager, making the "should I signal?"
logic more straightforward.
BUG=620413
Review-Url: https://codereview.chromium.org/2183273002
Cr-Commit-Position: refs/heads/master@{#408995}
Disable WebRtcImageCaptureBrowserTest on Windows.
It is flaky on WebRTC Windows bots.
BUG=633242
Review-Url: https://codereview.chromium.org/2197093004
Cr-Commit-Position: refs/heads/master@{#408994}
Clarify fullscreenElement vs. currentFullScreenElement distinction
No observable changes are intended.
This may make DocumentFullscreen::fullscreenElement and
::currentFullScreenElement slightly slower, but if that turns out to be
a problem a reasonable fix would be to inline the corresponding getters
in Fullscreen.h.
The Screen in m_fullScreenElementStack is lowercased, as it should be
and it shows all the places where it is used internally.
BUG=402421
[email protected]
Review-Url: https://codereview.chromium.org/2199783002
Cr-Commit-Position: refs/heads/master@{#408993}
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."
This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.
Per the outcome of the discussion on http://crbug.com/618043 and associated doc/chromium-dev discussion.
BUG=618043
Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
Review-Url: https://codereview.chromium.org/2177373005
Cr-Original-Commit-Position: refs/heads/master@{#408440}
Cr-Commit-Position: refs/heads/master@{#408992}
Roll WebRTC 13569:13589
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8af4222..e62282e
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2197903004
Cr-Commit-Position: refs/heads/master@{#408991}
Fix precache crash in intel compiler
In android x86, amd64 devices unique_ptr gets released before saved to
elements_ map. This behavior is only seen in release versions of
Chrome.
BUG=619111
Review-Url: https://codereview.chromium.org/2199643002
Cr-Commit-Position: refs/heads/master@{#408990}
Use text affinity to return correct accessible line boundaries.
Our calculations of line boundaries for accessibility were wrong
in certain cases where the character offset is ambiguous. It's
possible for there to be a line break immediately between two
characters, such that one character is on the previous line and
one is on the next line. If the character index is between those
two characters, previously we had no way of knowing if the cursor
was on the first line or second line.
Fix this by passing through the text affinity of the selection
focus and anchor from Blink all the way into Chrome's accessibility
tree. If the affinity is upstream, it means the cursor is on the
previous line, and downstream means the next line.
I added a LayoutTest for Blink and a unit test for Chrome. I also
manually verified this fixes at least one broken case with VoiceOver,
see the bug for a very specific repro.
BUG=632450
Review-Url: https://codereview.chromium.org/2191833003
Cr-Commit-Position: refs/heads/master@{#408989}
Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...
... so that we return traces from all agents and metadata to clients.
This depens on https://codereview.chromium.org/2160793003/
on the Telemetry side.
BUG=599932
Review-Url: https://codereview.chromium.org/2161583004
Cr-Commit-Position: refs/heads/master@{#408988}
arc: Support custom notification size change
BUG=632455
BUG=b/30477159
TEST=Manual. Run Orbot and observe the notification change its size.
Review-Url: https://codereview.chromium.org/2192023002
Cr-Commit-Position: refs/heads/master@{#408987}
Print proper debug message in case of change event timeout.
"AbortError: Timed out as the page didn't resolve the promise
from change event"
BUG=629462
Review-Url: https://codereview.chromium.org/2193183002
Cr-Commit-Position: refs/heads/master@{#408986}
Removed unwanted scroll bar on user-manager.
BUG=627278
Review-Url: https://codereview.chromium.org/2155373002
Cr-Commit-Position: refs/heads/master@{#408985}
Roll ANGLE c9bde92..ee7e1e2
https://chromium.googlesource.com/angle/angle.git/+log/c9bde92..ee7e1e2
BUG=
TEST=bots
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2196193003
Cr-Commit-Position: refs/heads/master@{#408984}
Roll src/third_party/skia/ 150d113db..9be6866e9 (1 commit).
https://chromium.googlesource.com/skia.git/+log/150d113db56d..9be6866e9512
$ git log 150d113db..9be6866e9 --date=short --no-merges --format='%ad %ae %s'
2016-08-01 mtklein GN: define fake-gamma configuration to match our bots.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2197213004
Cr-Commit-Position: refs/heads/master@{#408983}
Removing old alias from OWNERS file
BUG=
Review-Url: https://codereview.chromium.org/2198743002
Cr-Commit-Position: refs/heads/master@{#408982}
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter
* Wiring OfflinePageDownloadBridge to DownloadUIAdapter
* Making DownloadUIAdapter into SupportsUserData::Data available through OfflinePageModel
BUG=630817
Review-Url: https://codereview.chromium.org/2180973002
Cr-Commit-Position: refs/heads/master@{#408981}
[system-health] Change load:news:flipboard class name to LoadFlipboardStory
BUG=633239
[email protected]
Review-Url: https://codereview.chromium.org/2195403003
Cr-Commit-Position: refs/heads/master@{#408980}
aw: Add thread hops to more Adapter classes
BUG=630709
Review-Url: https://codereview.chromium.org/2201593002
Cr-Commit-Position: refs/heads/master@{#408979}
Move EXPECT_DCHECK_DEATH from base/task_scheduler and use it in relevant base/ tests
Extracted from https://codereview.chromium.org/2163023002/
This has the following advantages:
- Reduces inconsistent usage of #if preprocessors macros for death tests.
- Enables some tests when DCHECK_ALWAYS_ON in Release builds
that were previously not (per aforementioned inconsistency)
- Runs those tests anyways (modulo call expected to die) in non-DCHECK
builds -- resulting in extra coverage (though sometimes mostly a no-op).
TODO(gab): Try to enable death tests on OS_ANDROID in a follow-up CL and document what breaks.
BUG=622400
(relation to that bug is the attempt to open as many tests as possible
to Release+DCHECK_ALWAYS_ON started in https://codereview.chromium.org/2163023002/
as a safety measure for the impl for 622400)
Review-Url: https://codereview.chromium.org/2162053006
Cr-Commit-Position: refs/heads/master@{#408978}
Extract SnippetSource interface from SnippetBridge.
I have a testing CL that is taking a while to land. This will help reduce
churn on it.
BUG=
Review-Url: https://codereview.chromium.org/2193683005
Cr-Commit-Position: refs/heads/master@{#408977}
HeadlessDevToolsClientImpl::DispatchEvent to post a task
DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break. This patch works around that
by posting a task to run the event handler.
BUG=546953
Review-Url: https://codereview.chromium.org/2200663002
Cr-Commit-Position: refs/heads/master@{#408976}
Fix flaky testRequestFinishedListenerFailedRequest
The time reported can occasionally be 0.
BUG=632925
Review-Url: https://codereview.chromium.org/2198083002
Cr-Commit-Position: refs/heads/master@{#408975}
WebGL2 test expectations: add back suppression for Linux AMD
It was removed in 4771076dd784de4 but wasn't completely fixed.
[email protected]
BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2198053002
Cr-Commit-Position: refs/heads/master@{#408974}
Add IntDefs to generated Java enums.
BUG=607519
[email protected]
Review-Url: https://codereview.chromium.org/1932183002
Cr-Commit-Position: refs/heads/master@{#408973}
Roll src/third_party/boringssl/src 5440fe0cd..0d1b0961f
https://boringssl.googlesource.com/boringssl/+log/5440fe0cd10aab3c106eadf9873bb6d61344e29f..0d1b0961f9b8ef720cd96ae0a7ac3edcbbf538e5
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2198893002
Cr-Commit-Position: refs/heads/master@{#408972}
Use base::string16 for user-visible texts in ContentSuggestion
Because some providers (like the bookmarks provider) have their strings
available in UTF-16 encoding, we should use these throughout. The
NTPSnippetsService needs to continue using std::string because the JSON
format does not support UTF-16.
BUG=633141
Review-Url: https://codereview.chromium.org/2197223002
Cr-Commit-Position: refs/heads/master@{#408971}
Safe browsing subresource filter bubble UI skeleton.
After user proceed through Safe Browsing warning interstitials that are
displayed when the site ahead contains deceptive embedded content, we
need to give the user an ability to reload the page with the content
we've blocked previously.
This CL implements the skeleton of the bubble, but doesn't have logic to
triggering the bubble.
BUG=609747
Review-Url: https://codereview.chromium.org/2171713002
Cr-Commit-Position: refs/heads/master@{#408970}
Reland of Speculative fix for perf test performance regressions. (patchset #1 id:1 of https://codereview.chromium.org/2196103003/ )
Reason for revert:
The revert did not fix the issue it was suspect of causing.
Original issue's description:
> Revert of Speculative fix for perf test performance regressions. (patchset #1 id:1 of https://codereview.chromium.org/2190083002/ )
>
> Reason for revert:
> Speculative revert to see if that fixes the WebRTC Win7 Tester bot.
>
> See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/28171
>
> Sample error logs:
> [ RUN ] PPAPINaClPNaClTest.MediaStreamVideoTrack
> [4788:5076:0729/174935:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
> [5744:3076:0729/174935:ERROR:dxva_video_decode_accelerator_win.cc(273)] EGL_EXT_device_query missing
> [5744:3076:0729/174935:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 273
> [6048:3772:0729/174935:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
> [4788:4472:0729/174936:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico
> [4788:4168:0729/174936:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
> [4788:5076:0729/174936:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: http://127.0.0.1:50824/test_case.html?mode=nacl_pnacl&testcase=MediaStreamVideoTrack (0)
> e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_test.cc(249): error: Value of: handler.message().c_str()
> Actual: "Plugin crashed. 'NaCl module crashed'"
> Expected: "PASS"
> [5744:3300:0729/174936:ERROR:node_controller.cc(1099)] Could not be introduced to peer 71198AAF592CFFC1.CFEE94F16E49B4BD
> [4788:5076:0729/174937:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
> [ FAILED ] PPAPINaClPNaClTest.MediaStreamVideoTrack, where TypeParam = and GetParam() = (2255 ms)
> [98/98] PPAPINaClPNaClTest.MediaStreamVideoTrack (2556 ms)
> Retrying 1 test (retry #3)
> [ RUN ] PPAPINaClPNaClTest.MediaStreamVideoTrack
> [5628:4292:0729/174937:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
> [1440:4176:0729/174937:ERROR:dxva_video_decode_accelerator_win.cc(273)] EGL_EXT_device_query missing
> [1440:4176:0729/174937:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 273
> [4792:5844:0729/174937:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
> [5628:6016:0729/174938:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico
> [5628:6104:0729/174939:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
> [5628:4292:0729/174939:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: http://127.0.0.1:50830/test_case.html?mode=nacl_pnacl&testcase=MediaStreamVideoTrack (0)
> e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_test.cc(249): error: Value of: handler.message().c_str()
> Actual: "Plugin crashed. 'NaCl module crashed'"
> Expected: "PASS"
> [1440:1012:0729/174939:ERROR:node_controller.cc(1099)] Could not be introduced to peer 326301B2EC2EF45.56A4474DAFD5DD29
> [5628:4292:0729/174939:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
> [ FAILED ] PPAPINaClPNaClTest.MediaStreamVideoTrack, where TypeParam = and GetParam() = (2243 ms)
> [99/99] PPAPINaClPNaClTest.MediaStreamVideoTrack (2537 ms)
> 1 test failed:
> PPAPINaClPNaClTest.MediaStreamVideoTrack (e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_browsertest.cc:1164)
>
> Will reland if the revert doesn't fix the issue.
>
> Original issue's description:
> > Speculative fix for perf test performance regressions.
> >
> > BUG=623804
> >
> > Committed: https://crrev.com/1eadbdccdb0dee6fe9e169ac374bfa6c1ad9d03d
> > Cr-Commit-Position: refs/heads/master@{#408789}
>
> [email protected],[email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=623804
>
> Committed: https://crrev.com/01bd53dba19f1df9dd002a15c87a1ea180c1ffbb
> Cr-Commit-Position: refs/heads/master@{#408956}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623804
Review-Url: https://codereview.chromium.org/2195373003
Cr-Commit-Position: refs/heads/master@{#408969}
Remove blink::Document::removeFormAssociation().
It's no-op.
Also, this CL removes HTMLLabelElement::insertedInto(). It's a lefover of
removing FormAssociatedElement from HTMLLabelElement.
Review-Url: https://codereview.chromium.org/2195513002
Cr-Commit-Position: refs/heads/master@{#408968}
Roll src/third_party/skia/ 12e9662cf..150d113db (1 commit).
https://chromium.googlesource.com/skia.git/+log/12e9662cf796..150d113db56d
$ git log 12e9662cf..150d113db --date=short --no-merges --format='%ad %ae %s'
2016-08-01 mtklein GN: Define SK_HAS_... in all Skia-private code, not just libskia.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2195213003
Cr-Commit-Position: refs/heads/master@{#408967}
Bump android_n5x_swarming_rel percentage to 70%.
BUG=589168
NOTRY=True
Review-Url: https://codereview.chromium.org/2193413002
Cr-Commit-Position: refs/heads/master@{#408966}
Get rid of GnomeKeyringLoader macros
BUG=602624
Review-Url: https://codereview.chromium.org/2196193002
Cr-Commit-Position: refs/heads/master@{#408965}
[TrackedPref] a super MAC validating a null contents is also valid.
This fixes the issue found @
https://codereview.chromium.org/2112713004/#msg39 (PS 14-15).
ProfilePrefStoreManagerTest.NewPrefWhenFirstProtecting is verifying
that the following works:
1) Have N valid MACs for tracked but so far unprotected prefs.
2) Start tracking a new pref and enable protection for all tracked prefs
3) Existing tracked prefs should be migrated.
4) The newly tracked pref should also be accepted per the old MAC being valid.
This failed because https://codereview.chromium.org/2112713004
correctly no longer creates the DictionaryValue representing the MACs
in DictionaryHashStoreContents when RemoveEntry() is called while it
doesn't even exist (i.e. nothing to remove).
But not creating the dictionary results in the end of the transaction stamping
a null contents instead of an empty contents which results in a different MAC
although it's essentially protecting the same thing.
The logic altered in this CL previously refrained from declaring a MAC stamping
a null contents as valid while it's just as valid and secure as one stamping an
empty dictionary.
BUG=624858
Review-Url: https://codereview.chromium.org/2198873002
Cr-Commit-Position: refs/heads/master@{#408964}
Update V8 to version 5.4.310.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/78d2d649..fe80fd44
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2197173002
Cr-Commit-Position: refs/heads/master@{#408963}
Reset HTTP/2 stream on line-folded response headers.
Also add unittests for HeaderCoalescer.
BUG=524041, 621487
Review-Url: https://codereview.chromium.org/2184253002
Cr-Commit-Position: refs/heads/master@{#408962}
Roll src/third_party/skia/ f5b675efb..12e9662cf (1 commit).
https://chromium.googlesource.com/skia.git/+log/f5b675efbe6f..12e9662cf796
$ git log f5b675efb..12e9662cf --date=short --no-merges --format='%ad %ae %s'
2016-08-01 robertphillips Remove some ancillary users of SkSurface::MakeRenderTargetDirect
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2197193002
Cr-Commit-Position: refs/heads/master@{#408961}
Revert of Returning sane device parameters in case authorization timed out. (patchset #1 id:1 of https://codereview.chromium.org/2146203005/ )
Reason for revert:
Does not fix the problem, since in case the status is OUTPUT_DEVICE_STATUS_ERROR_TIMED_OUT |output_params_| are not assigned. We should initialized |output_params_| as media::AudioParameters::UnavailableDeviceParams() by default instead.
Original issue's description:
> Returning sane device parameters in case authorization timed out.
>
> BUG=628186
>
> Committed: https://crrev.com/69f771c18ca15cd537eeb01743cbc6333da9c05a
> Cr-Commit-Position: refs/heads/master@{#405779}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628186
Review-Url: https://codereview.chromium.org/2198013002
Cr-Commit-Position: refs/heads/master@{#408960}
Make page_load_metrics_browsertest reference a real svg file
This was resulting in a 404 rather than a navigation to an
SVG.
BUG=
Review-Url: https://codereview.chromium.org/2191253003
Cr-Commit-Position: refs/heads/master@{#408959}
Deprecate currentView, useCurrentView properties of SVGSVGElement and SVGViewSpec interface
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Dfqld7wjHJM
BUG=629445
Review-Url: https://codereview.chromium.org/2163213007
Cr-Commit-Position: refs/heads/master@{#408958}
WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink.
Previously RTCStatsResponseBase and impls had addReport and addStatistic
methods, adding stats as string key-string value pairs. These are replaced by
addStats(const WebRTCStats&). WebRTCStats describe a stats report and has a
member iterator.
The members' names and values can be converted to strings and be used like
addReport and addStatistic was previously used. RTCStatsResponse still uses this
functionality.
Additionally, the members are described with type information and has getters
for each type. The WebRTCStatsType and WebRTCStatsMemberName enums will be used
to identify individual stats. In follow-up CLs where .idl dictionaries are added
for each RTCStats in the spec, the member and type information will be used to
translate WebRTCStats into RTCStats-derived dictionaries.
Existing getStats tests use mocking. (blink_tests' RTCPeerConnection-stats.html
use a mock WebRTCPeerConnectionHandler, content_unittests'
RTCPeerConnectionHandlerTest.GetStats* use a mock LocalRTCStatsRequest). This CL
adds a getStats browser_tests that make sure getStats can be called and result
iterated without mocking components (integration test).
BUG=627816
Review-Url: https://codereview.chromium.org/2186853002
Cr-Commit-Position: refs/heads/master@{#408957}
Revert of Speculative fix for perf test performance regressions. (patchset #1 id:1 of https://codereview.chromium.org/2190083002/ )
Reason for revert:
Speculative revert to see if that fixes the WebRTC Win7 Tester bot.
See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/28171
Sample error logs:
[ RUN ] PPAPINaClPNaClTest.MediaStreamVideoTrack
[4788:5076:0729/174935:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
[5744:3076:0729/174935:ERROR:dxva_video_decode_accelerator_win.cc(273)] EGL_EXT_device_query missing
[5744:3076:0729/174935:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 273
[6048:3772:0729/174935:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
[4788:4472:0729/174936:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico
[4788:4168:0729/174936:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
[4788:5076:0729/174936:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: http://127.0.0.1:50824/test_case.html?mode=nacl_pnacl&testcase=MediaStreamVideoTrack (0)
e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_test.cc(249): error: Value of: handler.message().c_str()
Actual: "Plugin crashed. 'NaCl module crashed'"
Expected: "PASS"
[5744:3300:0729/174936:ERROR:node_controller.cc(1099)] Could not be introduced to peer 71198AAF592CFFC1.CFEE94F16E49B4BD
[4788:5076:0729/174937:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[ FAILED ] PPAPINaClPNaClTest.MediaStreamVideoTrack, where TypeParam = and GetParam() = (2255 ms)
[98/98] PPAPINaClPNaClTest.MediaStreamVideoTrack (2556 ms)
Retrying 1 test (retry #3)
[ RUN ] PPAPINaClPNaClTest.MediaStreamVideoTrack
[5628:4292:0729/174937:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
[1440:4176:0729/174937:ERROR:dxva_video_decode_accelerator_win.cc(273)] EGL_EXT_device_query missing
[1440:4176:0729/174937:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 273
[4792:5844:0729/174937:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
[5628:6016:0729/174938:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico
[5628:6104:0729/174939:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
[5628:4292:0729/174939:INFO:CONSOLE(0)] "NativeClient: NaCl module crashed", source: http://127.0.0.1:50830/test_case.html?mode=nacl_pnacl&testcase=MediaStreamVideoTrack (0)
e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_test.cc(249): error: Value of: handler.message().c_str()
Actual: "Plugin crashed. 'NaCl module crashed'"
Expected: "PASS"
[1440:1012:0729/174939:ERROR:node_controller.cc(1099)] Could not be introduced to peer 326301B2EC2EF45.56A4474DAFD5DD29
[5628:4292:0729/174939:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[ FAILED ] PPAPINaClPNaClTest.MediaStreamVideoTrack, where TypeParam = and GetParam() = (2243 ms)
[99/99] PPAPINaClPNaClTest.MediaStreamVideoTrack (2537 ms)
1 test failed:
PPAPINaClPNaClTest.MediaStreamVideoTrack (e:\b\c\b\win_builder\src\chrome\test\ppapi\ppapi_browsertest.cc:1164)
Will reland if the revert doesn't fix the issue.
Original issue's description:
> Speculative fix for perf test performance regressions.
>
> BUG=623804
>
> Committed: https://crrev.com/1eadbdccdb0dee6fe9e169ac374bfa6c1ad9d03d
> Cr-Commit-Position: refs/heads/master@{#408789}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623804
Review-Url: https://codereview.chromium.org/2196103003
Cr-Commit-Position: refs/heads/master@{#408956}
Rename ContentSuggestionsCategory to Category
Rename ContentSuggestionsCategoryFactory to CategoryFactory
Rename ContentSuggestionsCategoryStatus to CategoryStatus
Rename KnownSuggestionsCategories to KnownCategories
All of those are in the ntp_snippets namespace, which will be renamed
to content_suggestions, ensuring that the shorter name Category is still
sufficiently associated with content suggestions.
BUG=None
Review-Url: https://codereview.chromium.org/2189963003
Cr-Commit-Position: refs/heads/master@{#408955}
Add ThreadChecker to MessageLoopRunner.
MessageLoopRunner is meant to be used on the same thread. When using it across
threads, there will be a DCHECK that, if investigated will give a hint about
the thread restriction. It is very easy to end up missing the hint and try to
understand what is happening.
BUG=None
Review-Url: https://codereview.chromium.org/2192943002
Cr-Commit-Position: refs/heads/master@{#408954}
Use full version for breakpad on iOS
The current version for breakpad in crash reports is CFBundleShortVersionString
It should be long version.
BUG=626490
Review-Url: https://codereview.chromium.org/2132913003
Cr-Commit-Position: refs/heads/master@{#408953}
Roll src/third_party/skia/ 02aed95f9..f5b675efb (1 commit).
https://chromium.googlesource.com/skia.git/+log/02aed95f9c7c..f5b675efbe6f
$ git log 02aed95f9..f5b675efb --date=short --no-merges --format='%ad %ae %s'
2016-08-01 borenet Stop running nanobench on Test.*Debug bots
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2198843002
Cr-Commit-Position: refs/heads/master@{#408952}
Refactoring: Remove unused member functions in MemoryCache
This CL removes unused member functions in MemoryCache for code health.
BUG=n/a
TEST=n/a
Review-Url: https://codereview.chromium.org/2192803002
Cr-Commit-Position: refs/heads/master@{#408951}
Form submission should abort before constraint validation if sandboxed forms flag is set.
BUG=630628
Review-Url: https://codereview.chromium.org/2191493002
Cr-Commit-Position: refs/heads/master@{#408950}
Update V8 to version 5.4.307.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a647e004..78d2d649
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2200643002
Cr-Commit-Position: refs/heads/master@{#408949}
[ServiceWorker] Don't check the origin equality when disable-web-security flag is set.
When "disable-web-security" flag is set, we don't check the origin equality in Blink.
So we shouldn't check it in content side.
BUG=619294,630495,630496
Review-Url: https://codereview.chromium.org/2196633002
Cr-Commit-Position: refs/heads/master@{#408948}
cc: Remove ImageBackgroundFilter.BackgroundFilterRotated_GL test from DrMemory blacklist
Since we increased timeout for cc tests in 579189, this test should
pass.
BUG=523689
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2021733002
Cr-Commit-Position: refs/heads/master@{#408947}
Fix content description for site and username buttons
This CL fixes the content description for the site and username buttons, which previously consisted of 'Content description for the button that copies the stored password.'
BUG=633152
Review-Url: https://codereview.chromium.org/2197963002
Cr-Commit-Position: refs/heads/master@{#408946}
binding: Uses the current context if attribute/method is static.
https://crrev.com/2049493005 did not care about static attributes /
methods. This CL takes care of "static".
BUG=632634
Review-Url: https://codereview.chromium.org/2199643003
Cr-Commit-Position: refs/heads/master@{#408945}
Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING
Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING to initially
pause virtual time until at least one loading task has run. This fixes
a problem where virtual time could advance arbitrarily far before the
first fetch occurred.
Also refactor the way virtual time is dealt with so that
RendererSchedulerImpl and ThrottlingHelper know about it and
Virtual Time is applied to all relevant queues.
Finally remove unused WebViewSchedulerTest.cpp
BUG=546953
Review-Url: https://codereview.chromium.org/2184123002
Cr-Commit-Position: refs/heads/master@{#408944}
Refactoring: Make member variables in Resource private
This CL moves some member variables in Resource class from protected to
private to improve code health.
BUG=n/a
TEST=webkit_unit_tests
Review-Url: https://codereview.chromium.org/2199713002
Cr-Commit-Position: refs/heads/master@{#408943}
Add ContentSuggestionsCategoryFactory; Store categories as ints
Replace the ContentSuggestionsCategory enum with a thin wrapper class
around an int to allow for categories to be added dynamically at
runtime. Add a ContentSuggestionsCategoryFactory, which creates
instances and keeps track of the ordering of the categories.
Adjust the ContentSuggestionsService to use the category ordering
provided by the new factory. Adjust ContentSuggestionsProvider to use
the factory for recovering categories from combined IDs and move the
provided_categories_ field to subclasses. Adjust the SnippetsBridge
to use the new factory.
BUG=632320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2187233002
Cr-Commit-Position: refs/heads/master@{#408942}
MostVisitedSites cleanup
- remove unused members thread_checker_ and blocking_runner_
- rename scoped_observer_ to top_sites_observer_
- replace "received_x_" with "waiting_for_x_", which is more honest (esp. for x == popular_sites)
BUG=none
Review-Url: https://codereview.chromium.org/2197093003
Cr-Commit-Position: refs/heads/master@{#408941}
Remove confusing unitless quirk hint
This unitless quirk hint is confusing since stroke-dasharray is an
SVG attribute and for these attributes unitless quirks are always
allowed.
To avoid confusion remove the hint.
Review-Url: https://codereview.chromium.org/2192283002
Cr-Commit-Position: refs/heads/master@{#408940}
Typo fix for MathExtras.h
BUG=
Review-Url: https://codereview.chromium.org/2197103002
Cr-Commit-Position: refs/heads/master@{#408939}
Layout test of PerformanceResourceTiming for multipart
PerformanceResourceTiming fields should be correctly initialised for
multipart images.
They are not, so this CL includes an expectation that
the test will fail.
BUG=631004
Review-Url: https://codereview.chromium.org/2176153002
Cr-Commit-Position: refs/heads/master@{#408938}
Revert of Adds a WebRTC browser_test with opus dtx enabled. (patchset #5 id:100001 of https://codereview.chromium.org/2190533002/ )
Reason for revert:
Speculative revert due to this CL being suspect of breaking webrtc bots.
See https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/19829
Sample error message:
[32431:32431:0801/012147:INFO:CONSOLE(13)] "Returning Test failed: Error: getSdpDefaultCodec() failed: "'m=video' line missing from |sdp|."
at failTest (http://127.0.0.1:47758/webrtc/test_functions.js:46:15)
at failure (http://127.0.0.1:47758/webrtc/test_functions.js:56:9)
at getSdpDefaultCodec (http://127.0.0.1:47758/webrtc/munge_sdp.js:108:5)
at getSdpDefaultVideoCodec (http://127.0.0.1:47758/webrtc/munge_sdp.js:93:10)
at verifyDefaultVideoCodec (http://127.0.0.1:47758/webrtc/peerconnection.js:174:27)
at <anonymous>:1:51 to test.", source: http://127.0.0.1:47758/webrtc/test_functions.js (13)
../../chrome/browser/media/webrtc_browsertest_base.cc:361: Failure
Original issue's description:
> Adds a WebRTC browser_test with opus dtx enabled.
>
> Additionally, starts tracking the 'packetsSentPerSecond' metric for WebRTC browser_tests.
>
> BUG=631927
>
> Committed: https://crrev.com/e9df939bf67e2dea8e3ca1d9a0857272324611b8
> Cr-Commit-Position: refs/heads/master@{#408825}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=631927
Review-Url: https://codereview.chromium.org/2195293002
Cr-Commit-Position: refs/heads/master@{#408937}
[Editing][CodeHealth] Move isAtUnsplittableElement to ApplyBlockElementCommand
That's because isAtUnsplittableElement is used only in ApplyBlockElementCommand.
Ditto with unsplittableElementForPosition in ApplyStyleCommand.
TEST=No change in behavior
Review-Url: https://codereview.chromium.org/2197063002
Cr-Commit-Position: refs/heads/master@{#408936}
Update V8 to version 5.4.306.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6c53c6c7..a647e004
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2198823002
Cr-Commit-Position: refs/heads/master@{#408935}
Create IOSChromeContentSuggestionsServiceFactory
Create the factory so that the new ContentSuggestionsService is
available on iOS. It is currently always disabled, but the factory
ensures that the service doesn't introduce new non-iOS dependencies.
Remove the IOSChromeNTPSnippetsServiceFactory because the
NTPSnippetsService is now a plain provider and will not be
a KeyedService anymore. It will be created by the new
IOSChromeContentSuggestionsServiceFactory in the future.
BUG=632690
Owner: me
Review-Url: https://codereview.chromium.org/2194793004
Cr-Commit-Position: refs/heads/master@{#408934}
Worker: Remove indirect function calls for cleanup
BUG=n/a
Review-Url: https://codereview.chromium.org/2199693002
Cr-Commit-Position: refs/heads/master@{#408933}
Revert of Pass per-frame task runners to Workers (when possible) (patchset #5 id:100001 of https://codereview.chromium.org/2163983004/ )
Reason for revert:
This CL seems to cause a test failure on "WebKit Linux Leak" bot.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21436
An example of the failure is:
http/tests/serviceworker/foreign-fetch-workers.html
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,15],"numberOfLiveResources":[0,1]})
Original issue's description:
> Pass per-frame task runners to Workers (when possible)
>
> - For in-process workers (i.e. dedicated/compositor workers): always use
> the associated document's task runners
> - For out-of-process workers (i.e. service/shared workers): keep using the
> default task runner of the main thread, but via TaskRunnerHelper so
> we could still start using different task runners for different tasks
> (e.g. loading vs timer) if we want.
>
> BUG=627034
>
> Committed: https://crrev.com/66b07a326160fed57046fbb454f424a302d4cc6b
> Cr-Commit-Position: refs/heads/master@{#408652}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627034
Review-Url: https://codereview.chromium.org/2199633002
Cr-Commit-Position: refs/heads/master@{#408932}
Migrate libjingle to WebRTC build targets.
This is a large improvement from the previous duplicated lists of
source files in WebRTC. This moves over to using the GYP/GN targets
in third_party/webrtc instead, which has become possible after landing
https://codereview.webrtc.org/1924663003/ and
https://codereview.webrtc.org/2037983002/.
BUG=webrtc:4256
TESTED=Local builds passing for Linux and Android.
Review-Url: https://codereview.chromium.org/2022833002
Cr-Commit-Position: refs/heads/master@{#408931}
Stop showing orange highlight when thumbnail window is active.
BUG=526892
TEST=manually
Review-Url: https://codereview.chromium.org/2195283002
Cr-Commit-Position: refs/heads/master@{#408930}
Update V8 to version 5.4.305.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d0caa399..6c53c6c7
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2198793002
Cr-Commit-Position: refs/heads/master@{#408929}
Revert of Fold compositing display items into contained drawings if the drawing is a singleton. (patchset #7 id:110001 of https://codereview.chromium.org/2186643002/ )
Reason for revert:
This CL seems to break layout tests on bot.
An example of failure is:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/results/layout-test-results/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-crash-log.txt
STDERR: [4:4:0731/203155:3802475433:FATAL:PaintController.cpp(554)] Check failed: false.
STDERR: #0 0x7f109c38b99e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f109c3f2fef logging::LogMessage::~LogMessage()
STDERR: #2 0x7f1097594655 blink::PaintController::checkUnderInvalidation()
STDERR: #3 0x7f1097592e64 blink::PaintController::processNewItem()
STDERR: #4 0x7f1097583d52 _ZN5blink15PaintController15createAndAppendINS_18DrawingDisplayItemEJRKNS_17DisplayItemClientERKNS_11DisplayItem4TypeEN3WTF10PassRefPtrI9SkPictureEERbEEEvDpOT0_
STDERR: #5 0x7f1097583af1 blink::DrawingRecorder::~DrawingRecorder()
STDERR: #6 0x7f109422f925 base::internal::OptionalStorage<>::~OptionalStorage()
STDERR: #7 0x7f109422f8c5 base::Optional<>::~Optional()
STDERR: #8 0x7f109422ed83 blink::LayoutObjectDrawingRecorder::~LayoutObjectDrawingRecorder()
STDERR: #9 0x7f109423e187 blink::BoxPainter::paintBoxDecorationBackgroundWithRect()
STDERR: #10 0x7f109423dcde blink::BoxPainter::paintBoxDecorationBackground()
STDERR: #11 0x7f10943f34f5 blink::LayoutBox::paintBoxDecorationBackground()
STDERR: #12 0x7f109422dbcd blink::BlockPainter::paintObject()
STDERR: #13 0x7f10943b1bd5 blink::LayoutBlock::paintObject()
STDERR: #14 0x7f109422d25c blink::BlockPainter::paint()
STDERR: #15 0x7f10943b1b55 blink::LayoutBlock::paint()
Original issue's description:
> Fold compositing display items into contained drawings if the drawing is a singleton.
>
> BUG=628831
>
> Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd
> Cr-Commit-Position: refs/heads/master@{#408725}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628831
Review-Url: https://codereview.chromium.org/2197903002
Cr-Commit-Position: refs/heads/master@{#408928}
Fix a hidden crash when ImeThread feature is used
DCHECK in PlainTextRange's constructor causes a crash when start > end, but
the test passes, probably because it's a renderer crash and we call it at
the end.
In this case, we'll swap start and end just like BaseInputConnection does.
Also adds some tests to fix the behavior and prevents a crash in the future.
BUG=
Review-Url: https://codereview.chromium.org/2179943006
Cr-Commit-Position: refs/heads/master@{#408927}
Report detailed batch upload error by UMA.
Currently chrome reports HTTP response code to UMA and it always -1 when
the HTTP connection is failed.
The CL let chrome report net status error instead if the response code
is -1.
BUG=539608
TEST=Sync multiple files in Files.app.
Review-Url: https://codereview.chromium.org/2163903002
Cr-Commit-Position: refs/heads/master@{#408926}
Cache proxy view return value to avoid deadlock
If WebView has an active IME but the Android app calls
InputMethodManager#hideSoftInputFromWindow() on a non-UI thread,
then a deadlock may happen.
One example case is when JavaScript triggers it through JavascriptInterface
(therefore, on JavaBridge thread.)
The deadlock scenario is as follows:
1) InputMethodManager#hideSoftFromWindow() calls
ThreadedInputConnectionProxyView#getWindowToken() on JavaBridge thread
while holding InputMethodManager#mH.
Then getWindowToken() waits for UI thread to become available.
2) At almost same time, InputMethodManager#restartInput() was waiting for
InputMethodManager#mH on UI thread
This deadlock can be avoided by caching return values as atomic objects.
Alternative approach I've tried: check the current thread and block
it only when it's IME thread - this may still leave room for deadlock
between IME thread and UI thread.
BUG=630937
Review-Url: https://codereview.chromium.org/2175263002
Cr-Commit-Position: refs/heads/master@{#408925}
Deprecate DLOPEN_GNOME_KEYRING flag
GnomeKeyringLoader will be moved into a separate utility.
This change makes GnomeKeyringLoader simpler to build on and easier
to move.
Currently, GnomeKeyringLoader compiles different code, depending on
whether keyring is statically linked. Now it will only do dynamic
loading. The only place that requires static linking is tests, and they
don't need GnomeKeyringLoader to do it for them.
BUG=602624
Review-Url: https://codereview.chromium.org/2191873002
Cr-Commit-Position: refs/heads/master@{#408924}
Refactoring: Introduce the local variables
Use nextSiblingIsTextNode and shouldEmitNBSPbeforeEnd variables
to improve code readability and add comment.
See discussion here:
https://codereview.chromium.org/2191163002/#msg13
BUG=none
Review-Url: https://codereview.chromium.org/2196553003
Cr-Commit-Position: refs/heads/master@{#408923}
Reland of Further reduction of feature_compiler.py generated code (patchset #1 id:1 of https://codereview.chromium.org/2201653003/ )
Reason for revert:
Not this either
Original issue's description:
> Revert of Further reduction of feature_compiler.py generated code (patchset #5 id:80001 of https://codereview.chromium.org/2193693003/ )
>
> Reason for revert:
> Suspect for widespread Win7 NaCl failures starting with
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55503
>
> Wasn't r408782, r408787 or r408781
>
> Original issue's description:
> > Further reduction of feature_compiler.py generated code
> >
> > Use raw pointers instead of unique pointers to reduce size. See linked
> > bug for size details.
> >
> > BUG=631416
> >
> > Committed: https://crrev.com/2026cea7fa1b2146d7113dc31f2a2969d9ec58e3
> > Cr-Commit-Position: refs/heads/master@{#408788}
>
> [email protected],[email protected],[email protected]
> NOTRY=true
> NOTREECHECKS=true
> BUG=631416
>
> Committed: https://crrev.com/132a21ca3dedb4b2942737a3e947c772c81743aa
> Cr-Commit-Position: refs/heads/master@{#408917}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631416
Review-Url: https://codereview.chromium.org/2199683002
Cr-Commit-Position: refs/heads/master@{#408922}
Automated Commit: Committing new LKGM version 8658.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#408921}
Default page title (the page's URL) is now in an LTR embedding.
Only affects URLs with strong right-to-left characters.
This fixes the case where the URL contains RTL characters, causing the
components of the URL to be rendered from right to left. The display is
now consistent with the Omnibox display of URLs and compliant with RFC
3987.
BUG=630481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2176463002
Cr-Commit-Position: refs/heads/master@{#408920}
Revert of Use MediaRecorder to capture video for quality test. (patchset #1 id:1 of https://codereview.chromium.org/2183873002/ )
Reason for revert:
Performance numbers regressed a bit too much after landing this, example:
https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxozpqQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICght-9qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxuK2sgkM
Original issue's description:
> Use MediaRecorder to capture video for quality test.
>
> Retrite the WebRTC video quality test to use the MediaRecorder API
> instead of recording from a canvas.
>
> BUG=631458
>
> Committed: https://crrev.com/0204f3d64d8472a25d93312356d2a1c4acbb600e
> Cr-Commit-Position: refs/heads/master@{#408633}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=631458
Review-Url: https://codereview.chromium.org/2199653002
Cr-Commit-Position: refs/heads/master@{#408919}
Improve console log message for CORS failure
When a simple cross-origin request has been made and then blocked,
a log message of "blocked from loading" may sound confusing since we've
loaded the resource from the server but just prevented the response
from being delivered to the page.
When a redirect has been blocked, the error message should say that the
redirect has been blocked and the reason (e.g. whether the redirect location
is bad or the response didn't pass the CORS check) clearly.
BUG=417786
R=sof
Review-Url: https://codereview.chromium.org/1196423003
Cr-Commit-Position: refs/heads/master@{#408918}
Revert of Further reduction of feature_compiler.py generated code (patchset #5 id:80001 of https://codereview.chromium.org/2193693003/ )
Reason for revert:
Suspect for widespread Win7 NaCl failures starting with
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55503
Wasn't r408782, r408787 or r408781
Original issue's description:
> Further reduction of feature_compiler.py generated code
>
> Use raw pointers instead of unique pointers to reduce size. See linked
> bug for size details.
>
> BUG=631416
>
> Committed: https://crrev.com/2026cea7fa1b2146d7113dc31f2a2969d9ec58e3
> Cr-Commit-Position: refs/heads/master@{#408788}
[email protected],[email protected],[email protected]
NOTRY=true
NOTREECHECKS=true
BUG=631416
Review-Url: https://codereview.chromium.org/2201653003
Cr-Commit-Position: refs/heads/master@{#408917}
Roll src/third_party/catapult/ e689c4714..f3881da3d (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e689c4714834..f3881da3d75a
$ git log e689c4714..f3881da3d --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2196173002
Cr-Commit-Position: refs/heads/master@{#408916}
Remove the CSS Properties API
Remove the core/css/properties/ folder, since it's currently dead code.
Will re-add when the Ribbon project starts up again.
This is a revert of crrev.com/1431773002.
BUG=545324
Review-Url: https://codereview.chromium.org/2202453002
Cr-Commit-Position: refs/heads/master@{#408915}
Update V8 to version 5.4.304.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/462f4bd5..d0caa399
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2200623002
Cr-Commit-Position: refs/heads/master@{#408914}
Revert of Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types (patchset #3 id:40001 of https://codereview.chromium.org/2181443002/ )
Reason for revert:
This patch has broken compiling on the MSan bots.
Due to memory waterfall shenanigans I haven't had time to investigate why, but I do know that locally reverting this change fixed compile.
Sample failure output:
FAILED: obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DMEMORY_SANITIZER -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=274369-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DENABLE_OILPAN=1 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -O2 -fno-ident -fdata-sections -ffunction-sections -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -gline-tables-only -fno-omit-frame-pointer -fsanitize=memory -fsanitize-memory-track-origins=2 -fsanitize-blacklist=../../tools/msan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc -o obj/mojo/public/interfaces/bindings/tests/test_interfaces_blink_cpp_sources/test_structs.mojom-blink.o
In file included from gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.cc:15:
In file included from gen/mojo/public/interfaces/bindings/tests/test_structs.mojom-blink.h:37:
In file included from gen/mojo/public/interfaces/bindings/tests/rect.mojom-blink.h:37:
In file included from ../../mojo/public/cpp/bindings/wtf_array.h:15:
In file included from ../../mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h:13:
../../third_party/WebKit/Source/wtf/Vector.h:196:32: error: call to deleted constructor of 'mojo::ScopedHandleBase<mojo::Handle>'
new (NotNull, dst) T(*src);
^ ~~~~
../../third_party/WebKit/Source/wtf/Vector.h:323:62: note: in instantiation of function template specialization 'WTF::VectorCopier<false, mojo::ScopedHandleBase<mojo::Handle> >::uninitializedCopy<mojo::ScopedHandleBase<mojo::Handle> >' requested here
VectorCopier<VectorTraits<T>::canCopyWithMemcpy, T>::uninitializedCopy(src, srcEnd, dst);
^
../../third_party/WebKit/Source/wtf/Vector.h:1004:21: note: in instantiation of member function 'WTF::VectorTypeOperations<mojo::ScopedHandleBase<mojo::Handle> >::uninitializedCopy' requested here
TypeOperations::uninitializedCopy(other.begin(), other.end(), begin());
^
../../buildtools/third_party/libc++/trunk/include/memory:1740:31: note: in instantiation of member function 'WTF::Vector<mojo::ScopedHandleBase<mojo::Handle>, 0, WTF::PartitionAllocator>::Vector' requested here
::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...);
^
.... snip
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true
BUG=624136,631415
Review-Url: https://codereview.chromium.org/2199623002
Cr-Commit-Position: refs/heads/master@{#408913}
Hide some member functions of SpellChecker as private
This patch hides the following member functions of SpellChecker as
private because they are only used by SpellChecker itself:
bool markMisspellings(const VisibleSelection&);
void markBadGrammar(const VisibleSelection&);
bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection);
void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
This patch is a preparation for cleaning up grammar checking code from
SpellChecker.
BUG=619452
TEST=n/a; no behavior change
Review-Url: https://codereview.chromium.org/2198733003
Cr-Commit-Position: refs/heads/master@{#408912}
MD History: UI polish pass
* Remove 'Psst' notice from delete confirmation dialog
* Increase line-height of 'other forms of history' notice to 20px
BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2195263002
Cr-Commit-Position: refs/heads/master@{#408911}
Reland of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #1 id:1 of https://codereview.chromium.org/2196143002/ )
Reason for revert:
Didn't work. NaCl still crashing. Sadness :(
Original issue's description:
> Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #5 id:80001 of https://codereview.chromium.org/2181163003/ )
>
> Reason for revert:
> Suspect (not the first) for widespread NaCl test failures since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> Errors like
>
> [4224:3200:0729/162247:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
> ...
> Actual: "Plugin crashed. 'NaCl module crashed'"
>
> Wasn't r408782 or r408787. Running out of candidates..
>
> Original issue's description:
> > [Presentation API] Convert presentation.mojom to new wrapper types.
> >
> > This converts presentation.mojom to use the new (std::) Mojo wrapper types:
> > mojo::String => std::string
> > mojo::Array => std::vector
> >
> > No behavior changes should ensue.
> >
> > Optional values are represented as base::Optional<Foo> with the new wrapper
> > types requiring some additional changes.
> >
> > This work will simplify further changes for crbug.com/627655.
> >
> > BUG=627655
> >
> > Committed: https://crrev.com/59e7b40948030815a49af887b922b370ba048b8b
> > Cr-Commit-Position: refs/heads/master@{#408781}
>
> [email protected],[email protected],[email protected]
> NOTRY=true
> BUG=627655
>
> Committed: https://crrev.com/43c746be32b2bfce5c3fd654894e4b7f7bf6387f
> Cr-Commit-Position: refs/heads/master@{#408905}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627655
Review-Url: https://codereview.chromium.org/2197053002
Cr-Commit-Position: refs/heads/master@{#408910}
Make the ARC opt-in preference not synced.
If we sync the ARC opt-in prefence we may cause unintentional data loss
when the user opts-out of ARC on one device.
BUG=633017
TEST=Manually test by opting out of ARC on one machine and observing a
second (opted-in) machine's state.
Review-Url: https://codereview.chromium.org/2198733002
Cr-Commit-Position: refs/heads/master@{#408909}
Fixed CSSVisibilityInterpolationType to store enum instead of double
Fixed ParentVisibilityChecker in CSSVisibilityInterpolationType to store
the EVisibility enum, rather than a double.
Review-Url: https://codereview.chromium.org/2195233002
Cr-Commit-Position: refs/heads/master@{#408908}
Remove myself from OWNERS and histograms.xml.
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2190293004
Cr-Commit-Position: refs/heads/master@{#408907}
Mark LayoutTest updating-scrolling-container-and-content as FLAKY
BUG=633026, 619103
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2194123002
Cr-Commit-Position: refs/heads/master@{#408906}
Revert of [Presentation API] Convert presentation.mojom to new wrapper types. (patchset #5 id:80001 of https://codereview.chromium.org/2181163003/ )
Reason for revert:
Suspect (not the first) for widespread NaCl test failures since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
Errors like
[4224:3200:0729/162247:ERROR:nacl_process_host.cc(337)] NaCl process exited with status -1073741674 (0xc0000096)
...
Actual: "Plugin crashed. 'NaCl module crashed'"
Wasn't r408782 or r408787. Running out of candidates..
Original issue's description:
> [Presentation API] Convert presentation.mojom to new wrapper types.
>
> This converts presentation.mojom to use the new (std::) Mojo wrapper types:
> mojo::String => std::string
> mojo::Array => std::vector
>
> No behavior changes should ensue.
>
> Optional values are represented as base::Optional<Foo> with the new wrapper
> types requiring some additional changes.
>
> This work will simplify further changes for crbug.com/627655.
>
> BUG=627655
>
> Committed: https://crrev.com/59e7b40948030815a49af887b922b370ba048b8b
> Cr-Commit-Position: refs/heads/master@{#408781}
[email protected],[email protected],[email protected]
NOTRY=true
BUG=627655
Review-Url: https://codereview.chromium.org/2196143002
Cr-Commit-Position: refs/heads/master@{#408905}
Updating trunk VERSION from 2815.0 to 2816.0
Cr-Commit-Position: refs/heads/master@{#408904}
SELECT popup: Tentative fix for an issue on Android WebView.
Disable element visibility check only on Android.
BUG=632561
Review-Url: https://codereview.chromium.org/2201703002
Cr-Commit-Position: refs/heads/master@{#408903}
Reland of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2200593002/ )
Reason for revert:
No dice - NaCl still crashing in
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55553
Original issue's description:
> Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ )
>
> Reason for revert:
> Suspected for widespread NaCl plugin failures on waterfall since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> Crashes with "Actual: "Plugin crashed. 'NaCl module crashed"
>
> It wasn't r408782, so I think it's gotta be this or r408781.
>
> Original issue's description:
> > Fix bug with blank pages during navigation
> >
> > This bug started after r408172. In some situations when navigating, the
> > SetNeedsBeginFrame messages that is sent from the
> > CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
> > received by the RenderWidgetHostImpl while the RenderViewHost is swapped
> > out and before it has swapped back in. In these cases, if this message
> > is dropped, the renderer will never tick new frames and the tab will
> > freeze. This appears to be racy, as the renderer finds out that it is
> > visible and sends this message before the view host is swapped in.
> >
> > To fix this race, always allow the SetNeedsBeginFrame message to be
> > received while being swapped out so that the RenderWidgetHostView can be
> > in the correct state when it is swapped in.
> >
> > [email protected]
> > BUG=632276
> >
> > Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
> > Cr-Commit-Position: refs/heads/master@{#408787}
>
> [email protected],[email protected],[email protected]
> NOTRY=true
> BUG=632276
>
> Committed: https://crrev.com/ad648d7d920843e226b5f0aee2cf8e9662412413
> Cr-Commit-Position: refs/heads/master@{#408899}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632276
Review-Url: https://codereview.chromium.org/2195253002
Cr-Commit-Position: refs/heads/master@{#408902}
Move generated Mojo C++ error reporting code out of line
Also switch from scoped_refptr to unique_ptr, as we only have one owner.
Savings:
SafeJsonParserStub::AcceptWithResponder: 42 bytes
SafeJsonParser_Parse_ForwardToCallback: 44 bytes
We lose a few bytes (but come out positive in the end) due to fixing the incorrect Ninja template expansions in the error messages.
BUG=597125
Review-Url: https://codereview.chromium.org/2188143002
Cr-Commit-Position: refs/heads/master@{#408901}
Do not calculate composition bounds until IME requests.
Calculating composition bounds is not a light-weight operation.
On the other hand, few IME uses this information.
To skip this unnecessary calculation on certain environment, propagate
cursor update mode from browser to the renderer.
BUG=624714
Review-Url: https://codereview.chromium.org/2121953002
Cr-Commit-Position: refs/heads/master@{#408900}
Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ )
Reason for revert:
Suspected for widespread NaCl plugin failures on waterfall since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
Crashes with "Actual: "Plugin crashed. 'NaCl module crashed"
It wasn't r408782, so I think it's gotta be this or r408781.
Original issue's description:
> Fix bug with blank pages during navigation
>
> This bug started after r408172. In some situations when navigating, the
> SetNeedsBeginFrame messages that is sent from the
> CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
> received by the RenderWidgetHostImpl while the RenderViewHost is swapped
> out and before it has swapped back in. In these cases, if this message
> is dropped, the renderer will never tick new frames and the tab will
> freeze. This appears to be racy, as the renderer finds out that it is
> visible and sends this message before the view host is swapped in.
>
> To fix this race, always allow the SetNeedsBeginFrame message to be
> received while being swapped out so that the RenderWidgetHostView can be
> in the correct state when it is swapped in.
>
> [email protected]
> BUG=632276
>
> Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
> Cr-Commit-Position: refs/heads/master@{#408787}
[email protected],[email protected],[email protected]
NOTRY=true
BUG=632276
Review-Url: https://codereview.chromium.org/2200593002
Cr-Commit-Position: refs/heads/master@{#408899}
Mark LayoutTest mediasource-errors.html FLAKY
BUG=633016
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2197003002
Cr-Commit-Position: refs/heads/master@{#408898}
Reland of Try yet again to flip official win builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2196993002/ )
Reason for revert:
Didn't help - NaCl still crashing.
Original issue's description:
> Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )
>
> Reason for revert:
> All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> This seems to be the most likely cause :(
>
> There's also an outstanding issue with win-pgo (see BUG=)
>
> BUG=632864
>
> Original issue's description:
> > Try yet again to flip official win builders to GN.
> >
> > [email protected]
> > NOTRY=true
> > BUG=623659
> >
> > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> > Cr-Commit-Position: refs/heads/master@{#408782}
>
> [email protected],[email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=623659
> NOTRY=true
>
> Committed: https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8
> Cr-Commit-Position: refs/heads/master@{#408896}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632864
Review-Url: https://codereview.chromium.org/2192393003
Cr-Commit-Position: refs/heads/master@{#408897}
Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )
Reason for revert:
All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
This seems to be the most likely cause :(
There's also an outstanding issue with win-pgo (see BUG=)
BUG=632864
Original issue's description:
> Try yet again to flip official win builders to GN.
>
> [email protected]
> NOTRY=true
> BUG=623659
>
> Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> Cr-Commit-Position: refs/heads/master@{#408782}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659
NOTRY=true
Review-Url: https://codereview.chromium.org/2196993002
Cr-Commit-Position: refs/heads/master@{#408896}
Recognize new Operating System: NetBSD
NetBSD is BSD and POSIX-like OS.
BUG=
Review-Url: https://codereview.chromium.org/2195203002
Cr-Commit-Position: refs/heads/master@{#408895}
Turn off syzygy_optimize by default when is_syzyasan is on.
This correctly matches the GYP behavior.
[email protected], [email protected]
BUG=632563
Review-Url: https://codereview.chromium.org/2199603002
Cr-Commit-Position: refs/heads/master@{#408894}
Remove the gyp_chromium hook from DEPS.
Also, add a watchlist entry for modifications to gyp files.
[email protected]
BUG=432967
Review-Url: https://codereview.chromium.org/2194043004
Cr-Commit-Position: refs/heads/master@{#408893}
Fix MB config for ios-simulator-cronet.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2195213002
Cr-Commit-Position: refs/heads/master@{#408892}
Remove GYP builders from the CQ.
[email protected]
BUG=432967
Review-Url: https://codereview.chromium.org/2200573002
Cr-Commit-Position: refs/heads/master@{#408891}
Flip remaining builders to GN.
(Apart from the dedicated GYP builders, of course).
This affects:
- chromium.fyi
- Closure Compilation Linux
- CrWinAsan
- CrWinAsan(dll)
- CrWinAsanCov
- chromium.lkgr
- Win ASan Release Coverage
- Win ASan Release Media
- Win ASan Release
- chromium.mac
- ios-simulator
- chromium.memory.full
- Chromium Windows Builder (DrMemory x64)
- Chromium Windows Builder (DrMemory)
- tryserver.chromium.linux
- closure_compilation
- tryserver.chromium.mac
- ios-simulator
Though the closure compilation builder doesn't really use GN or MB yet.
[email protected]
BUG=605318, 621708
Review-Url: https://codereview.chromium.org/2198693002
Cr-Commit-Position: refs/heads/master@{#408890}
Add mac10.11_retina_blink_rel and android_blink_rel to builder config.
BUG=474273
Review-Url: https://codereview.chromium.org/2188413005
Cr-Commit-Position: refs/heads/master@{#408889}
Have ResizeViewportAnchor derive from GarbageCollected<> only.
Drop use of GarbageCollectedFinalized<>; not needed for this
class.
R=
BUG=
Review-Url: https://codereview.chromium.org/2192373002
Cr-Commit-Position: refs/heads/master@{#408888}
Remove unused function template overloads.
Leftover from r408135, remove the generated isT(*RefPtr<T>)
overloads also.
R=
BUG=
Review-Url: https://codereview.chromium.org/2201633002
Cr-Commit-Position: refs/heads/master@{#408887}
Propagate proper FROM_HERE to postTask() in worker code
Some of postTask() implementation in Worker code don't have
WebTraceLocation parameter, and pass wrong FROM_HEREs. That
make it hard to follow the call stack in a crash report.
This adds the missing WebTraceLocation parameter, puts correct
FROM_HEREs and adds alias() to ensure it's in the crash report.
Review-Url: https://codereview.chromium.org/2196833002
Cr-Commit-Position: refs/heads/master@{#408886}
Use only toolbar to transition from fakebox to real omnibox.
Previously, we would fade out the fakebox and fade in the real omnibox during
the scroll transition, which created discrepancies. With this change, the
toolbar omnibox does the full transition. The search box on the NTP is still
kept, both to get the starting point of the transition, and for the tablet
toolbar, where the omnibox stays at the top, so there are two boxes.
Because the two boxes now have to match, their dimensions and padding are
slightly updated. The height is 56dp, and the padding on the sides is 12dp.
Also, in the focused state the omnibox now has 1dp bleed at the sides,
which moves the rounded corners out of view.
The remaining changes are not user-visible:
* Opacity of the fakebox is now driven by the toolbar. This lets us centralize
the logic (the toolbar can decide its own opacity and the opacity of the
fakebox) and use different behavior on tablets, where the fakebox will simply
fade out as before.
* Rename variables to (hopefully) make them more consistent / self-explanatory.
* |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more accurately
reflects the visible omnibox bounds in the absence of the NTP / when the NTP
is scrolled so that the omnibox is at the top. To do that, we no longer
include the Y translation we apply to position it where the fakebox is (it's
instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
an expansion value of 1 if the current tab is an NTP.
* Remove the |inset_textbox| drawable -- it was the same as |textbox|, but with
a margin added at the top and bottom (but *not* left or right). Since we
calculate the omnibox bounds manually anyway, this allows us to account for
the omnibox padding in the same way in either dimension.
* Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
the member variable.
BUG=605054,625108,618955,616728,612520
Review-Url: https://codereview.chromium.org/2134663002
Cr-Commit-Position: refs/heads/master@{#408885}
Automated Commit: Committing new LKGM version 8656.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#408884}
Update V8 to version 5.4.303.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e07fc752..462f4bd5
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2192363002
Cr-Commit-Position: refs/heads/master@{#408883}
Updating trunk VERSION from 2814.0 to 2815.0
Cr-Commit-Position: refs/heads/master@{#408882}
Update V8 to version 5.4.302.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3a5efbf0..e07fc752
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2196063002
Cr-Commit-Position: refs/heads/master@{#408881}
Revert of Linux: Sync GetDesktopName in gtk2_util.cc (patchset #2 id:20001 of https://codereview.chromium.org/2195063003/ )
Reason for revert:
Broke Linux GN build on my desktop (linker error):
obj/chrome/browser/ui/libgtk2ui/libgtk2ui/gtk2_util.o:../../chrome/browser/ui/libgtk2ui/gtk2_util.cc:function libgtk2ui::GetDesktopName(base::Environment*): error: undefined reference to 'chrome::GetChannel()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Contents of my out/Release/args.gn:
is_component_build = true
is_debug = false
is_chrome_branded = true
dcheck_always_on = true
use_goma = true
Original issue's description:
> Linux: Sync GetDesktopName in gtk2_util.cc
>
> BUG=632841
>
> Committed: https://crrev.com/12d7c7f1f6a38f067803c676e5cac9cccc11dab2
> Cr-Commit-Position: refs/heads/master@{#408846}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632841
Review-Url: https://codereview.chromium.org/2196073002
Cr-Commit-Position: refs/heads/master@{#408880}
Roll src/third_party/skia/ 570f8af47..02aed95f9 (2 commits).
https://chromium.googlesource.com/skia.git/+log/570f8af47305..02aed95f9c7c
$ git log 570f8af47..02aed95f9 --date=short --no-merges --format='%ad %ae %s'
2016-07-30 mtklein Revert of GrFP can express distance vector field req., program builder declares variable for it (patchset #20 id:370001 of https://codereview.chromium.org/2114993002/ )
2016-07-30 mtklein Revert of Tidy up SkNx_neon. (patchset #3 id:40001 of https://codereview.chromium.org/2196773002/ )
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2201593003
Cr-Commit-Position: refs/heads/master@{#408879}
Roll src/third_party/skia/ 73106225d..570f8af47 (1 commit).
https://chromium.googlesource.com/skia.git/+log/73106225d1fc..570f8af47305
$ git log 73106225d..570f8af47 --date=short --no-merges --format='%ad %ae %s'
2016-07-30 mtklein Revert of Added distance vector support for CircleGeometryProcessor (patchset #4 id:60001 of https://codereview.chromium.org/2190023002/ )
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2195183002
Cr-Commit-Position: refs/heads/master@{#408878}
Add use counter for multiple origins in Timing-Allow-Origin
As part of a discussion about Timing-Allow-Origin and multiple origins in that syntax[1], the possibility of a change to the syntax was raised. In order for that to be considered, we need to check usage.
This CL does that by adding a counter when there's more than 1 origin in that header.
[1] https://github.com/w3c/resource-timing/issues/62
BUG=
Review-Url: https://codereview.chromium.org/2178973002
Cr-Commit-Position: refs/heads/master@{#408877}
Add eclipse classpath for blimp.
So after run gclient runhooks, we don't need to manually add java build path in eclipse.
Review-Url: https://codereview.chromium.org/2193133003
Cr-Commit-Position: refs/heads/master@{#408876}
DevTools: [SSP] do not throw exception if click on yellow triangle
The patch avoids throwing exception in the following scenario:
- add any non-existing property in SSP, e.g. "foo: bar;"
- observe a yellow triangle next to the property
- try clicking this triangle
BUG=none
R=dgozman
Review-Url: https://codereview.chromium.org/2191413003
Cr-Commit-Position: refs/heads/master@{#408875}
In rietveld.filter_latest_jobs, handle jobs with no build number.
Currently, in some circumstances, filter_try_jobs may throw an error depending on the state of the current try jobs.
This CL changes just this method so that it doesn't throw a KeyError if there are jobs with no build number passed in.
Review-Url: https://codereview.chromium.org/2182413004
Cr-Commit-Position: refs/heads/master@{#408874}
[DevTools] Add awaitPromise flag to Runtime.evaluate
BUG=632875
[email protected]
Review-Url: https://codereview.chromium.org/2196003002
Cr-Commit-Position: refs/heads/master@{#408873}
Roll src/third_party/skia/ fe2042e60..73106225d (1 commit).
https://chromium.googlesource.com/skia.git/+log/fe2042e60fa7..73106225d1fc
$ git log fe2042e60..73106225d --date=short --no-merges --format='%ad %ae %s'
2016-07-30 mtklein Docs: ooops, debug is the default in GN.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2196033002
Cr-Commit-Position: refs/heads/master@{#408872}
Remove more unused landmines code
Follow-up to https://codereview.chromium.org/2071463002/
BUG=none
Review-Url: https://codereview.chromium.org/2193023003
Cr-Commit-Position: refs/heads/master@{#408871}
No "Factory error" splashscreen on ChromeOS VMs
If the HWID is invalid (for instance, "unknown") and the firmware ID is non-Chrome ("nonchrome") then assume that we're running in a VM and do not report a factory
error. A warning message is added to the log.
BUG=b:30155895
Review-Url: https://codereview.chromium.org/2187473006
Cr-Commit-Position: refs/heads/master@{#408870}
StringBuilder::append should not use reserveCapacity.
reserveCapacity allocates the exact capacity specified which means
when we had a 16bit buffer in StringBuilder and were appending 8bit
strings to it we were constantly reallocating and copying the buffer.
Instead we can just call Vector::append() directly since it has a
template overload that can accept implicitly convertible types.
I noticed this when looking at lever.co's web app loading in
Instruments, it was spending 15% of the main thread time inside
TextResource::decodedText which was 83% memmove, and 11% munmap.
Switching to Vector::append should restore the correct size
doubling behavior when appending LChars to a UChar StringBuilder
and make this much faster.
This was a regression from when I switched to using a Vector
inside StringBuilder in:
https://codereview.chromium.org/2046353002
Review-Url: https://codereview.chromium.org/2192293002
Cr-Commit-Position: refs/heads/master@{#408869}
Automated Commit: Committing new LKGM version 8652.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#408868}
ResizeObserver pt5: size change notification
This change implements size change notification algorithm.
Design doc at https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing
Size change notification
We collect and deliver notifications about all Elements
whose size has changed inside the event loop.
The algorithm loops until all notifications are delivered,
or it hits the depth limit.
c = ResizeObserverController();
for (limit = c.gatherObservations(0);
limit != ResizeObserverController::kDepthLimit;
limit = c.gatherObservations(limit)) {
c.deliverObservations();
}
if (c.skippedObservations()) {
c.clearObservations();
sendError()
}
For efficiency, we avoid continuosly polling all elements
for size changes. Instead, an Element notifies ResizeObservation
when its size might have changed. ResizeObservation propagates
this change to ResizeObserver, which propagates to
ResizeObserverController. All of them set a flag indicating that
they might have been changed.
The flag is cleared when observations are delivered.
BUG=612962
Review-Url: https://codereview.chromium.org/2188983003
Cr-Commit-Position: refs/heads/master@{#408867}
Fix GN build on mac with icu_use_data_file = false
Several BUILD.gn files were bundling icudtl.dat even when
icu_use_data_file = false (i.e. icudata is statically linked).
The TEST below was done with https://codereview.chromium.org/2174993002/ on
the ICU side. This CL still can get in without that change, though.
BUG=630929
TEST='gn args <outdir>' with icu_use_data_file=false generates ninja files.
TEST=chrome / content_shell can be built.
TEST=In Chrome/content_shell, go to a non-UTF-8 page (www.hankyung.com) or
run `(new Date()).toLocaleString("de")` to make sure that ICU data
is accessible.
Review-Url: https://codereview.chromium.org/2181043003
Cr-Commit-Position: refs/heads/master@{#408866}
Update V8 to version 5.4.301.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6b119eb8..3a5efbf0
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2195893003
Cr-Commit-Position: refs/heads/master@{#408865}
services/ui: Detect when a video is playing.
Compositor frames submitted by mus clients include a flag to indicate whether the
client is playing a video or not. This information is plumbed through from
cc::Layer to cc::LayerImpl to cc::CompositorFrame[Metadata].
BUG=627140
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2140783002
Cr-Commit-Position: refs/heads/master@{#408864}
[DevTools] Pass error object when reporting exceptions.
We used to just extract string from the error, which didn't allow to inspect the error object itself. Now we pass the thrown object as a RemoteObject.
This also unifies exceptions with promise rejections in V8Debugger.
BUG=631162,632405
Review-Url: https://codereview.chromium.org/2170263002
Cr-Commit-Position: refs/heads/master@{#408863}
Roll PDFium 6f10254..3e454bf
https://pdfium.googlesource.com/pdfium.git/+log/6f10254..3e454bf
BUG=409472,629839
TEST=bots
[email protected]
Review-Url: https://codereview.chromium.org/2193623005
Cr-Commit-Position: refs/heads/master@{#408862}
Linux: Fix up sysroot_scripts.
- Use the right repo for Ubuntu ARM(64)
- Add checks for valid architectures so the "All" commands work.
- Try to fix up some bashisms
- And give up on the rest and just switch to bash
BUG=632522
Review-Url: https://codereview.chromium.org/2193903004
Cr-Commit-Position: refs/heads/master@{#408861}
Fix print preview close in gmail.
Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.
BUG= 614998
Review-Url: https://codereview.chromium.org/2201543002
Cr-Commit-Position: refs/heads/master@{#408860}
DevTools: Remove Advanced heap snapshot properties setting.
Make it always show all the object properties.
BUG=632917
Review-Url: https://codereview.chromium.org/2188413004
Cr-Commit-Position: refs/heads/master@{#408859}
Add stylus_protocol dependency.
BUG=None
Review-Url: https://codereview.chromium.org/2198633002
Cr-Commit-Position: refs/heads/master@{#408858}
Fix GN generation for WinASAN build
This is a step toward a working Asan build with GN.
There are still a few missing pieces to land.
This patch is fixing an assert triggering due to courgette using an
harcoded toolchains.
----------------------
ERROR at //build/config/sanitizers/sanitizers.gni:12:1: Assertion failed.
assert(!using_sanitizer || is_clang,
^-----
Sanitizers (is_*san) require setting is_clang = true in 'gn args'
----------------------
This patch is also fixing the compiler-rt runtime paths for a x64 bit
build. The port of WinASAN-64 is almost done and should part of the next
clang roll-deps.
[email protected], [email protected]
[email protected]
BUG=598761
Review-Url: https://codereview.chromium.org/2192833002
Cr-Commit-Position: refs/heads/master@{#408857}
[DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call.
BUG=631162
Review-Url: https://codereview.chromium.org/2189263004
Cr-Commit-Position: refs/heads/master@{#408856}
Updating trunk VERSION from 2813.0 to 2814.0
Cr-Commit-Position: refs/heads/master@{#408855}
DevTools: Show/hide console -> 'console drawer'
Minor text change that clarifies our menu item for "show/hide console" is
revealing the drawer in general. Users are confused that "show console" can
reveal the "Search all files" functionality.
BUG=522040
Review-Url: https://codereview.chromium.org/2191333003
Cr-Commit-Position: refs/heads/master@{#408854}
DevTools: do not apply number editings shortcuts to HTML attributes which look like URL
BUG=596181
R=dgozman
Review-Url: https://codereview.chromium.org/2197653004
Cr-Commit-Position: refs/heads/master@{#408853}
Add config for ios-simulator-swarming
BUG=598405
Review-Url: https://codereview.chromium.org/2200553002
Cr-Commit-Position: refs/heads/master@{#408852}
[Extensions] rm unnecessary GetRawDataResource().as_string() to reduce string copy.
BUG=None
Test=None, internal change.
Review-Url: https://codereview.chromium.org/2197483004
Cr-Commit-Position: refs/heads/master@{#408851}
Implement resize option for createImageBitmap(HTMLVideoElement)
Without resize, this function works like this:
It creates a ImageBuffer, and calls video->paintCurrentFrame to the
SkCanvas backed by the buffer, then it calls buffer's snapshot to get
a SkImage. To make resize efficient, we just need to carefully calculate
the parameter for the video->paintCurrentFrame, and we can do the resize
in one pass.
BUG=627855
Review-Url: https://codereview.chromium.org/2192103002
Cr-Commit-Position: refs/heads/master@{#408850}
[DevTools] Added Runtime.awaitPromise protocol method
Method will call callback when promise is fulfilled, rejected or collected.
BUG=632875
[email protected]
Review-Url: https://codereview.chromium.org/2185233002
Cr-Commit-Position: refs/heads/master@{#408849}
[DevTools] Replace InjectedScriptHost.suppressWarningsAndCallFunction with hasOwnProperty.
BUG=none
Review-Url: https://codereview.chromium.org/2190353004
Cr-Commit-Position: refs/heads/master@{#408848}
[MD settings] only add overscroll if needed.
This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.
This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.
BUG=631332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2201553002
Cr-Commit-Position: refs/heads/master@{#408847}
Linux: Sync GetDesktopName in gtk2_util.cc
BUG=632841
Review-Url: https://codereview.chromium.org/2195063003
Cr-Commit-Position: refs/heads/master@{#408846}
[DevTools] Rename findObject to unwrapObject.
BUG=631162
Review-Url: https://codereview.chromium.org/2192093004
Cr-Commit-Position: refs/heads/master@{#408845}
Update V8 to version 5.4.300.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8d5d2145..6b119eb8
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2195013004
Cr-Commit-Position: refs/heads/master@{#408844}
[DevTools] Fix location.script().sourceURL
Script can be null.
BUG=607532
[email protected]
Review-Url: https://codereview.chromium.org/2198443004
Cr-Commit-Position: refs/heads/master@{#408843}
MD Settings: Remove unnecessary scrollbar from Sign out dialog.
BUG=632575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2196613003
Cr-Commit-Position: refs/heads/master@{#408842}
[MD settings] update site details permission layout
This CL updates the permission dropdown menu so that it matches the
mocks better.
BUG=632535
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2190243002
Cr-Commit-Position: refs/heads/master@{#408841}
Use mojo for cursor control in ozone drm
Use mojo to control the cursor in ozone drm in mus. First in a series of patches to
convert Ozone IPC to mojo.
BUG=620927
Review-Url: https://codereview.chromium.org/2156093004
Cr-Commit-Position: refs/heads/master@{#408840}
[Mac] Fix download shelf items
Make sure that the download shelf items are updated after we exit
fullscreen.
BUG=600411
Review-Url: https://codereview.chromium.org/2148483002
Cr-Commit-Position: refs/heads/master@{#408839}
[DevTools] Remove & add required methods
R=dgozman, pfeldman
BUG=
Review-Url: https://codereview.chromium.org/2192333002
Cr-Commit-Position: refs/heads/master@{#408838}
Set Ash material design mode in tests properly
Currently, in Ash tests, material design mode is set after call to
AshTestBase::SetUp(). This is not right as some setup in AshTestBase
might depend on material mode. This CL allows setting material mode
before calling AshTestBase::SetUp().
BUG=620093
Review-Url: https://codereview.chromium.org/2186363002
Cr-Commit-Position: refs/heads/master@{#408837}
DevTools: do not CHECK devtools messages received from renderer in the browser, issue bad_message instead.
BUG=629307
Review-Url: https://codereview.chromium.org/2198503002
Cr-Commit-Position: refs/heads/master@{#408836}
DevTools: Take into account links from root to user global objects when building heap snapshot.
Traverse the links during building postorder iterator as well as the dominator tree.
Review-Url: https://codereview.chromium.org/2197853002
Cr-Commit-Position: refs/heads/master@{#408835}
Linux: Add xcb to sysroot
Needed by
https://codereview.chromium.org/2163623003/
Review-Url: https://codereview.chromium.org/2188403003
Cr-Commit-Position: refs/heads/master@{#408834}
DevTools: add CSS.FontsUpdated event to signify that WebFont has loaded.
BUG=595356
R=dgozman
Review-Url: https://codereview.chromium.org/2198463003
Cr-Commit-Position: refs/heads/master@{#408833}
Roll src/third_party/catapult/ a6464cb62..e689c4714 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a6464cb626ec..e689c4714834
$ git log a6464cb62..e689c4714 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2192323002
Cr-Commit-Position: refs/heads/master@{#408832}
Roll src/third_party/skia/ 848904e5b..fe2042e60 (4 commits).
https://chromium.googlesource.com/skia.git/+log/848904e5b356..fe2042e60fa7
$ git log 848904e5b..fe2042e60 --date=short --no-merges --format='%ad %ae %s'
2016-07-29 mtklein SkRasterPipeline: new APIs for fusion
2016-07-29 mtklein simplify neon shifts
2016-07-29 bsalomon If scissor would be empty in GrClipMaskManager::SetupClipping indicate draw can be skipped.
2016-07-29 csmartdalton Add ES 3.0 fallback for instanced rendering
BUG=632185
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2201533002
Cr-Commit-Position: refs/heads/master@{#408831}
Make PipelineImpl state change tasks consistent.
Review-Url: https://codereview.chromium.org/2091893003
Cr-Commit-Position: refs/heads/master@{#408830}
MD Settings: Fix canceling of "Add site exception" dialog.
BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2197723003
Cr-Commit-Position: refs/heads/master@{#408829}
Add new baselines for mac-retina after swapping the machine.
Background: In order to have a mac retina layout test try bot with a
matching continuous bot, the slave for "WebKit Mac10.11 (retina)", which
was a MacBookPro11,3 with Nvidia GPU, was swapped for a MacBookPro11,5
with AMD GPU (http://crrev.com/2184313002).
After the builder came back online with the new slave,
svg/text/combining-character-queries.html was failing consistently.
See results:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/5141/layout-test-results/results.html
Review-Url: https://codereview.chromium.org/2193353004
Cr-Commit-Position: refs/heads/master@{#408828}
Use server ID to identify server cards.
Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.
BUG=632482
Review-Url: https://codereview.chromium.org/2189563002
Cr-Commit-Position: refs/heads/master@{#408827}
DevTools: roll codemirror to @6d1379e29
The patch rolls CodeMirror to fix a wrong gutter background positioning.
This fixes the SourceCode-Diff experiment rendering in case of horizontal
source scroll.
BUG=none
R=einbinder
Review-Url: https://codereview.chromium.org/2201523002
Cr-Commit-Position: refs/heads/master@{#408826}
Adds a WebRTC browser_test with opus dtx enabled.
Additionally, starts tracking the 'packetsSentPerSecond' metric for WebRTC browser_tests.
BUG=631927
Review-Url: https://codereview.chromium.org/2190533002
Cr-Commit-Position: refs/heads/master@{#408825}
More style in server card editor for PaymentRequest
BUG=632915
Review-Url: https://codereview.chromium.org/2198623002
Cr-Commit-Position: refs/heads/master@{#408824}
Revert of [Android] Set platform mode as default for perf tests. (patchset #1 id:1 of https://codereview.chromium.org/2189773002/ )
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=632922
Original issue's description:
> [Android] Set platform mode as default for perf tests.
>
> BUG=615157
>
> Committed: https://crrev.com/9ea896bb6a840dcf84381fea4fece6069d497159
> Cr-Commit-Position: refs/heads/master@{#408665}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615157
Review-Url: https://codereview.chromium.org/2201563002
Cr-Commit-Position: refs/heads/master@{#408823}
Adding Discarded property support for onUpdate function.
BUG=621070
Review-Url: https://codereview.chromium.org/2142413003
Cr-Commit-Position: refs/heads/master@{#408822}
Geolocation cleanup: run clang-format
After moving geolocation to device, the presubmit
kept saying that I had to run git cl format, so here
we go. No new code, just ran:
clang-format -i -style=Chromium device/geolocation/*.h
clang-format -i -style=Chromium device/geolocation/*.cc
Review-Url: https://codereview.chromium.org/2200483002
Cr-Commit-Position: refs/heads/master@{#408821}
Add template file to get clipboard API documentation to show up
This should make it both show up in the "Dev APIs" section at the
bottom of the /apps/api_index page, but also have its own
standalone page at /apps/clipboard.
Review-Url: https://codereview.chromium.org/2200443002
Cr-Commit-Position: refs/heads/master@{#408820}
MD Settings: Remove unused settings.main.rendered global variable.
It was used to re-position the CBD dialog correctly, but its usage
was removed as part of migrating to native <dialog>.
BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2193953002
Cr-Commit-Position: refs/heads/master@{#408819}
Simplify landmines code a bit now that all branches of all platforms are on ninja
BUG=none
Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Review-Url: https://codereview.chromium.org/2071463002
Cr-Original-Commit-Position: refs/heads/master@{#408739}
Cr-Commit-Position: refs/heads/master@{#408818}
Two visual fixes in the MD Clear Browsing Data dialog
1. Change the footer color to that of secondary text (i.e. --paper-grey-600).
2. Replace the 12px bottom margin with padding, so that this 12px high area
at the bottom becomes a part of the scrollable region.
Screenshot: https://screenshot.googleplex.com/aodmwFZfdrq
BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2191283002
Cr-Commit-Position: refs/heads/master@{#408817}
Switch "alt-tab" to "Alt+Tab" in strings for window cycle UI flag.
alt-tab confuses translators.
BUG=b/30495226
Review-Url: https://codereview.chromium.org/2195923002
Cr-Commit-Position: refs/heads/master@{#408816}
Settings Router Refactor: Remove route.page legacy property.
This property is not used that much, and can be removed.
BUG=608115, 628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2184893002
Cr-Commit-Position: refs/heads/master@{#408815}
Roll src/third_party/catapult/ 395e5365f..a6464cb62 (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/395e5365f02a..a6464cb626ec
$ git log 395e5365f..a6464cb62 --date=short --no-merges --format='%ad %ae %s'
BUG=599932
[email protected]
Review-Url: https://codereview.chromium.org/2195913002
Cr-Commit-Position: refs/heads/master@{#408814}
cc: Move solid color scrollbar layer data in a seperate struct.
Just a clean up as a part of Layers cleanup.
BUG=625284
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2185973005
Cr-Commit-Position: refs/heads/master@{#408813}
MD Settings: Internet: Clean up network and proxy sections.
This CL correctly formats the network and proxy sections of the
internet detail page.
It also introduces internet_shared_css.html for common styling.
BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2179223004
Cr-Commit-Position: refs/heads/master@{#408812}
MD Settings: invert the "Use Window Decorations" checkbox
I checked that it worked, but not that it matched what the label says.
My bad.
[email protected]
BUG=632679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2193353002
Cr-Commit-Position: refs/heads/master@{#408811}
(Mojo) Shell types have been renamed elsewhere in Chromium, specifically ServiceRegistry is split into two parts:
- InterfaceRegistry, for registration of interface factories in code that implements the interfaces
- InterfaceProvider, allowing binding of named interfaces in code that consumes them.
This reflects this naming scheme into Blink, which uses only the Provider half.
[email protected]
http://crbug.com/632874
Review-Url: https://codereview.chromium.org/2196843003
Cr-Commit-Position: refs/heads/master@{#408810}
cc mojo: Use ArrayDataViews in RenderPasses
This CL makes use of the newly introduced Array DataViews
in cc StructTraits in order to improve serialization (and
to a lesser degree deserialization) performance.
This CL improves serialization performance by an average of
18% on an HP Z620. Deserialization performance improves
between 7 to 10%.
Prior to the ability to inspect Array and Struct DataViews
in parent StructTraits, we had to do extra work at
serialization time in order to capture state that spans
individual structs within a larger struct.
This CL addresses two of those cases:
1. Previously, QuadList maintained an extra array of
materials. This array existed so that we could preallocate
the appropriately typed DrawQuads during deserialization.
StructTraits assume a preallocated type and populated
fields in that type.
Alternatively we could have deserialized DrawQuads into
unique_ptrs, but cc required that we allocate DrawQuads
inline within a buffer in order to minimize the cost of
allocations (there can be hundreds of DrawQuads in a
CompositorFrame).
2. Previously, SharedQuadStates were serialized
independently of DrawQuads. However, in in-memory form,
DrawQuads refer to SharedQuadStates via raw pointers. In
order to allow DrawQuads and SharedQuadStates to deserialize
independently, as was required previously by StructTraits, a third
array was serialized "shared_quad_state_references" which was equal in
size to the QuadList. Each slot corresponded to an index in
the SharedQuadStateList. After the QuadList and SharedQuadStateList were
serialized, shared_quad_state_references updated the raw
pointers in the DrawQuads in the quad list to refer to the
SharedQuadStates. This required revisiting all deserialized
DrawQuads again.
In both 1. and 2. additional state needed to be allocated on the heap
during serialization. In pprof profiling, it became apparent that much
of the cost of serialization was in SetupContext. This CL eliminates
that cost.
Performance measures are available here:
https://docs.google.com/a/google.com/spreadsheets/d/13Y0I-BVDrQC4RHIzMSs0vl0QPe8xFAhYMUAXaxoEqgg/pubhtml
BUG=624459
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2174843003
Cr-Commit-Position: refs/heads/master@{#408809}
Clean up response handling in ResourceLoader/ResourceFetcher
This moves all of ResourceLoader's non-trivial response handling logic to ResourceFetcher, and changes the ordering of some steps to better match other callbacks.
Old order:
- Access control checks in ResourceLoader::didReceiveResponse()
- Resource::responseReceived()
- Access control checks in ResourceFetcher::didReceiveResponse()
- FetchContext::dispatchDidReceiveResponse()
New order:
- Access control checks in ResourceLoader::didReceiveResponse() (now in ResourceFetcher)
- Access control checks in ResourceFetcher::didReceiveResponse()
- FetchContext::dispatchDidReceiveResponse()
- Resource::responseReceived()
BUG=
Review-Url: https://codereview.chromium.org/1975373002
Cr-Commit-Position: refs/heads/master@{#408808}
DevTools: do not lazy load provided view if it was explicitly added.
TBR=dgozman
Review-Url: https://codereview.chromium.org/2197823002
Cr-Commit-Position: refs/heads/master@{#408807}
Tracing: fix error checking from deflate() when compressing trace
Initially broken by https://codereview.chromium.org/2150783002
BUG=629530,630030
Review-Url: https://codereview.chromium.org/2193323002
Cr-Commit-Position: refs/heads/master@{#408806}
Copy memory.fyi definitions to memory.full.
BUG=597178
Review-Url: https://codereview.chromium.org/2191323004
Cr-Commit-Position: refs/heads/master@{#408805}
Pass in the right sender to font proxy init
Previous change passed the sender to FontFallback init, but not
DWriteFontCollectionProxy which is what really matters. This will
ensure that both classes get the right sender.
BUG=631254
Review-Url: https://codereview.chromium.org/2196493003
Cr-Commit-Position: refs/heads/master@{#408804}
Md/Vectorize cellular network iconography.
Side note: if we had just used .icon files, besides the massive proliferation of them that would have been necessary, we'd have worse rendering at fractional scales like 1.5x because we'd be filling fractional pixels. However, to actually get the better drawing at fractional scales, the network technology badges (LTE, G, etc.) will also have to be vectorized.
BUG=617306
Review-Url: https://codereview.chromium.org/2201443002
Cr-Commit-Position: refs/heads/master@{#408803}
Move more client network code to //blimp/client/core/session.
The BlimpClientSession will be going away, so this CL takes part of it
and splits it up into smaller parts and moves them to
//blimp/client/core/session. They will be used by the
BlimpClientContextImpl.
BUG=611097
Review-Url: https://codereview.chromium.org/2187893002
Cr-Commit-Position: refs/heads/master@{#408802}
Do not use deprecated MessageLoop methods in //media/filters:media_vpx_video_decoder_fuzzer.
[email protected]
Review-Url: https://codereview.chromium.org/2196453003
Cr-Commit-Position: refs/heads/master@{#408801}
Tiny: Enable v4_rice* to be built using GYP
BUG=543161, 624567
Review-Url: https://codereview.chromium.org/2196553002
Cr-Commit-Position: refs/heads/master@{#408800}
[sync] Transient_invalidation_error in chrome://invalidations on Android.
invalidation_service_android never updated its logger instance's state,
since the state is always enabled. This meant the logger only ever
reported the state as its initial value, which is transient_error. This
change causes invalidation_service_android to update the state to
enabled upon construction.
[email protected]
BUG=630406
[sync] re-enable SyncTest#testRename
Review-Url: https://codereview.chromium.org/2201503002
Cr-Commit-Position: refs/heads/master@{#408799}
Fix android_aar resources causing lint warnings
Just needed to make the aar's java_prebuilt targets depend on the
resource targets so that would be deemed the resource owners within
write_build_config.py
BUG=632362
Review-Url: https://codereview.chromium.org/2190283002
Cr-Commit-Position: refs/heads/master@{#408798}
Roll ICU to ef5c7353 from b5ecbb29
1. Update the IANA timezone DB to 2016f from 2016d.
2. Add support for Big Endian (should not affect Chrome builds) mainly for v8
embedders (mips/mips64 BE targets).
3. Make it possible to run foreign trybots.
For more details, see
https://chromium.googlesource.com/chromium/deps/icu.git/+log/b5ecbb29..ef5c7353
[email protected]
BUG=473288,v8:4828
TEST=Try the following in d8 or Chrome's JS console:
> (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone:
"Asia/Novosibirsk"})
7/23/2016, 6:00:00 PM
> (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone:
"Asia/Novosibirsk"})
7/24/2016, 7:00:00 PM
Review-Url: https://codereview.chromium.org/2188333002
Cr-Commit-Position: refs/heads/master@{#408797}
Cleanup: move content/browser/media/webrtc/ to content/browser/webrtc
No new code, just shuffling files around -- commands:
git mv content/browser/media/webrtc content/browser/
tools/git/mass-rename.py
BUG=632020
Review-Url: https://codereview.chromium.org/2193343002
Cr-Commit-Position: refs/heads/master@{#408796}
Try to fix flakiness of fast/repaint/window-resize-background-image*.html
The flakiness may be because sometimes the test was started before the image is
loaded. Now start the test in onload.
Remove wrong baselines that were created based on wrong results when the
test failed on the bots.
BUG=622898
Review-Url: https://codereview.chromium.org/2188383002
Cr-Commit-Position: refs/heads/master@{#408795}
Support PostTaskAndReply from a sequenced task.
Currently, TaskRunner::PostTaskAndReply and
WorkerPool::PostTaskAndReply can only be called when
ThreadTaskRunnerHandle::IsSet(). The reply is posted back to the
thread on which PostTaskAndReply was invoked.
With this CL, these methods can also be called when
SequencedTaskRunnerHandle::IsSet(). The reply is posted back to the
sequence on which PostTaskReply was invoked.
This change is a prerequisite to implement base::PostTaskAndReply
which must work from a sequenced task
https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa5k/edit#heading=h.gf6e3bwrxqqs
BUG=553459
Review-Url: https://codereview.chromium.org/2180953002
Cr-Commit-Position: refs/heads/master@{#408794}
Roll src/third_party/catapult/ 28aad26a0..395e5365f (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/28aad26a05ee..395e5365f02a
$ git log 28aad26a0..395e5365f --date=short --no-merges --format='%ad %ae %s'
BUG=630300
[email protected]
Review-Url: https://codereview.chromium.org/2196483005
Cr-Commit-Position: refs/heads/master@{#408793}
[Password Manager] Change signature of PasswordAutofillAgent.FillSuggestion
Replace WebString with base::string16. AutofillAgent sends to PasswordAutofillAgent base::string16, but they are wrapped into WebString and and unwrapped to base::string16. That doesn't make sense.
Review-Url: https://codereview.chromium.org/2187253002
Cr-Commit-Position: refs/heads/master@{#408792}
Disable NV12 texture sharing with VP9 hardware video decoding.
The Microsoft MFT we're using doesn't pass through the bind flags
correctly so sharing textures with ANGLE doesn't work.
Review-Url: https://codereview.chromium.org/2188423002
Cr-Commit-Position: refs/heads/master@{#408791}
Updating trunk VERSION from 2812.0 to 2813.0
Cr-Commit-Position: refs/heads/master@{#408790}
Speculative fix for perf test performance regressions.
BUG=623804
Review-Url: https://codereview.chromium.org/2190083002
Cr-Commit-Position: refs/heads/master@{#408789}
Further reduction of feature_compiler.py generated code
Use raw pointers instead of unique pointers to reduce size. See linked
bug for size details.
BUG=631416
Review-Url: https://codereview.chromium.org/2193693003
Cr-Commit-Position: refs/heads/master@{#408788}
Fix bug with blank pages during navigation
This bug started after r408172. In some situations when navigating, the
SetNeedsBeginFrame messages that is sent from the
CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
received by the RenderWidgetHostImpl while the RenderViewHost is swapped
out and before it has swapped back in. In these cases, if this message
is dropped, the renderer will never tick new frames and the tab will
freeze. This appears to be racy, as the renderer finds out that it is
visible and sends this message before the view host is swapped in.
To fix this race, always allow the SetNeedsBeginFrame message to be
received while being swapped out so that the RenderWidgetHostView can be
in the correct state when it is swapped in.
[email protected]
BUG=632276
Review-Url: https://codereview.chromium.org/2197783002
Cr-Commit-Position: refs/heads/master@{#408787}
Allow long test names in pylintrc.
Many test methods in unit tests have names much longer than 30
characters. I think this is fine for test method names, since they're
meant to be descriptive, but not necessarily short and memorable.
Review-Url: https://codereview.chromium.org/2192213002
Cr-Commit-Position: refs/heads/master@{#408786}
[Offline Pages] Make querying by client ID support a list.
This is an inefficient intermediate step to support multiple client IDs
in a single API call. TODO: update native backend to support multiple
Client ID search.
BUG=
Review-Url: https://codereview.chromium.org/2187033002
Cr-Commit-Position: refs/heads/master@{#408785}
Revert of Simplify landmines code a bit now that all branches of all platforms are on ninja (patchset #2 id:20001 of https://codereview.chromium.org/2071463002/ )
Reason for revert:
I just synced on Windows and this is giving me:
________ running 'D:\depot_tools\python276_bin\python.exe src/build/landmines.py
' in 'D:\src\src1'
Traceback (most recent call last):
File "D:\src\src1\src\build\get_landmines.py", line 16, in <module>
builder = landmine_utils.builder
AttributeError: 'module' object has no attribute 'builder'
Clobbering due to:
--- old_landmines Tue Aug 12 16:34:51 2014
+++ new_landmines Fri Jul 29 15:16:56 2016
@@ -1,17 +0,0 @@
-Compile on cc_unittests fails due to symbols removed in r185063.
-Improper dependency for create_nmf.py broke in r240802, fixed in r240860.
-Switch to VS2015 Update 2
-Need to clobber everything due to an IDL change in r154579 (blink)
-Need to clobber everything due to gen file moves in r175513 (Blink)
-Clobber to get rid of obselete test plugin after r248358
-Clobber to rebuild GN files for V8
-Clobber to get rid of stale generated mojom.h files
-Need to clobber everything due to build_nexe change in nacl r13424
-[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...
-blink_resources.grd changed: crbug.com/400860
-ninja dependency cycle: crbug.com/408192
-Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).
-Another clobber for missing NaCl gyp deps (crbug.com/427427).
-Clobber to fix GN not picking up increased ID range (crbug.com/444902)
-Remove NaCl toolchains from the output dir (crbug.com/456902)
-Clobber to delete stale generated files (crbug.com/510086)
Original issue's description:
> Simplify landmines code a bit now that all branches of all platforms are on ninja
>
> BUG=none
>
> Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
> Cr-Commit-Position: refs/heads/master@{#408739}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2198583002
Cr-Commit-Position: refs/heads/master@{#408784}
Use inline layout object accessor for better code readability.
Review-Url: https://codereview.chromium.org/2193073004
Cr-Commit-Position: refs/heads/master@{#408783}
Try yet again to flip official win builders to GN.
[email protected]
NOTRY=true
BUG=623659
Review-Url: https://codereview.chromium.org/2192303002
Cr-Commit-Position: refs/heads/master@{#408782}
[Presentation API] Convert presentation.mojom to new wrapper types.
This converts presentation.mojom to use the new (std::) Mojo wrapper types:
mojo::String => std::string
mojo::Array => std::vector
No behavior changes should ensue.
Optional values are represented as base::Optional<Foo> with the new wrapper
types requiring some additional changes.
This work will simplify further changes for crbug.com/627655.
BUG=627655
Review-Url: https://codereview.chromium.org/2181163003
Cr-Commit-Position: refs/heads/master@{#408781}
MD Settings: Add missing month from credit card month dropdown.
BUG=632761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2198443003
Cr-Commit-Position: refs/heads/master@{#408780}
IndexedDB: Rename OpenOrDeleteRequest class to ConnectionRequest
Better name and it matches the concept in the spec.
Review-Url: https://codereview.chromium.org/2170043004
Cr-Commit-Position: refs/heads/master@{#408779}
MojoMain() -> ServiceMain()
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2192263002
Cr-Commit-Position: refs/heads/master@{#408778}
Move shared files in net/quic/ into net/quic/core/
Review-Url: https://codereview.chromium.org/2193073003
Cr-Commit-Position: refs/heads/master@{#408777}
DevTools: Give autocomplete suggestions even after brackets
BUG=
Review-Url: https://codereview.chromium.org/2163393002
Cr-Commit-Position: refs/heads/master@{#408776}
[arc-intents] Properly qualify API-generated page transitions.
Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism. This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.
Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.
BUG=632360
Review-Url: https://codereview.chromium.org/2189063002
Cr-Commit-Position: refs/heads/master@{#408775}
Linux: Increase storage size of vmstat data
The linux kernel stores and prints the data associated with /proc/vmstat
as unsigned longs, so increase Chrome's storage of these fields
accordingly.
https://github.com/torvalds/linux/blob/e4fba88d00d21f50239eac7d653027bfaf844296/include/linux/vmstat.h#L25
Review-Url: https://codereview.chromium.org/2188043003
Cr-Commit-Position: refs/heads/master@{#408774}
[Android][Telemetry] Enable ATrace tracing for BattOr Tests.
BUG=632809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Review-Url: https://codereview.chromium.org/2198523003
Cr-Commit-Position: refs/heads/master@{#408773}
Android: Remove ContentViewCore::GetLayer() from public interface
This removes some native references to ContentViewCore
from the embedder, which were mostly unnecessary indirections
and can use WebContents directly.
BUG=626764
Review-Url: https://codereview.chromium.org/2179563003
Cr-Commit-Position: refs/heads/master@{#408772}
Background Tracing: Remove safety check for crash exit on Android
On Android the exit status is always marked as EXIT_CRASHED. So, the
background traces are never uploaded. Since the check is useful only for
preemptive mode, this CL removes this check for REACTIVE triggers on
Android and adds extra check for preemptive trigger in that place.
BUG=613198
Review-Url: https://codereview.chromium.org/2192093002
Cr-Commit-Position: refs/heads/master@{#408771}
Roll src/third_party/skia/ 5db44aa2a..848904e5b (10 commits).
https://chromium.googlesource.com/skia.git/+log/5db44aa2aa4a..848904e5b356
$ git log 5db44aa2a..848904e5b --date=short --no-merges --format='%ad %ae %s'
2016-07-29 egdaniel Fix vulkan build
2016-07-29 dvonbeck Added distance vector support for CircleGeometryProcessor
2016-07-29 mtklein Tidy up SkNx_neon.
2016-07-29 jcgregorio perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm.
2016-07-29 bungeman Conditionally define SK_SUPPORT_LEGACY_DATA_FACTORIES.
2016-07-29 egdaniel Properly recycle uniform buffers in vulkan
2016-07-29 mtklein Add some GN builders to the CQ.
2016-07-29 halcanary SkPDF: PDFStream has-a not is-a PDFDict
2016-07-29 mtklein SkNx: add Sk4u
2016-07-29 dvonbeck GrFP can express distance vector field req., program builder declares variable for it
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2199433002
Cr-Commit-Position: refs/heads/master@{#408770}
Update WebAPK metadata namespace.
This updates the ManifestUpdateDetector after CL
(https://codereview.chromium.org/2193683003/) landed.
BUG=631063
Review-Url: https://codereview.chromium.org/2189413002
Cr-Commit-Position: refs/heads/master@{#408769}
Migrate SchedulerWorkerPoolImpl to AtomicFlag
BUG=553459
Review-Url: https://codereview.chromium.org/2195813002
Cr-Commit-Position: refs/heads/master@{#408768}
XXS: Update a comment in the safebrowsing.proto file
The comment states that although the field is marked as repeated, in practice it
can only contain 0 or 1 values.
BUG=543161
Review-Url: https://codereview.chromium.org/2195043002
Cr-Commit-Position: refs/heads/master@{#408767}
Remove NOTREACHED that gets hit for non well formed xhtml.
BUG=627607
Review-Url: https://codereview.chromium.org/2194893003
Cr-Commit-Position: refs/heads/master@{#408766}
Roll buildtools 67bf0653b2..db9be6cbc4
In order to roll GN 15e0e74f4d..da21696cd2 (r407852:r408676) and pick up
the following changes:
da21696 GN: only write targets that should be generated.
1c27131 [GN] Prefer explicit pool to automatic link_pool for link targets.
8293c35 GN: don't write separate files for non-binary targets
[email protected]
Review-Url: https://codereview.chromium.org/2193873002
Cr-Commit-Position: refs/heads/master@{#408765}
Revert of Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots. (patchset #1 id:1 of https://codereview.chromium.org/2097923002/ )
Reason for revert:
Regression was reverted, so tests can be re-enabled
Original issue's description:
> Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots.
>
> BUG=623105
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/582209c397ef25fb75bd8fdf58ff74c291172247
> Cr-Commit-Position: refs/heads/master@{#402060}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623105
Review-Url: https://codereview.chromium.org/2191413002
Cr-Commit-Position: refs/heads/master@{#408764}
[ash-md] Properly scales windows with transient parents in overview
Previously to this CL the code was only considering the focused window
when calculating scale for the overview mode transform. It needs to
consider the bounding rectangle of the whole transient parent's tree.
BUG=632694
Review-Url: https://codereview.chromium.org/2197773002
Cr-Commit-Position: refs/heads/master@{#408763}
Remove ScreenOrientation runtime flag (status=stable)
BUG=402536
Review-Url: https://codereview.chromium.org/2188523005
Cr-Commit-Position: refs/heads/master@{#408762}
chrome/browser/metrics: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2195503002
Cr-Commit-Position: refs/heads/master@{#408761}
Remove herb restriction for tablets and stable/beta builds.
BUG=630475
Review-Url: https://codereview.chromium.org/2193933002
Cr-Commit-Position: refs/heads/master@{#408760}
Disable Skia histograms until issues can be debugged.
Skia histograms are generating invalid data. Disable them until we have
time to debug further.
Review-Url: https://codereview.chromium.org/2185263002
Cr-Commit-Position: refs/heads/master@{#408759}
DevTools: Find bookmarks at line endpoints when calling _clearBookmarks
This fixes an issue with the source color picker where undo-ing the color text did not
always remove the color swatch. CodeMirror findMarks() is not inclusive, so we also need
to check the line endpoints.
The additional newline added to the string in _updateColorSwatches allows
color text to be matched when it is located at the start of a line.
R=lushnikov
Review-Url: https://codereview.chromium.org/2187173002
Cr-Commit-Position: refs/heads/master@{#408758}
Add explicit geolocation_java dependency for android_webview
This CL addresses the problem in the bug, i.e. android webview
not finding the Geolocation classes after moving to //device.
BUG=632777
Review-Url: https://codereview.chromium.org/2195783002
Cr-Commit-Position: refs/heads/master@{#408757}
Linux: Support the --class argument
It appears we lost support for --class when we stopped using gtk for our
windowing. This CL adds that feature back.
BUG=118613
Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520
Review-Url: https://codereview.chromium.org/2186813002
Cr-Original-Commit-Position: refs/heads/master@{#408709}
Cr-Commit-Position: refs/heads/master@{#408756}
Improve i18n descriptions based on clarifications requested.
BUG=NONE
Review-Url: https://codereview.chromium.org/2195003002
Cr-Commit-Position: refs/heads/master@{#408755}
Delete old NetworkQualityEstimator Cronet API
Now that RequestFinishedListener doesn't depend on NQE's executor, the
rest of this API can go away.
BUG=618034
Review-Url: https://codereview.chromium.org/2188553002
Cr-Commit-Position: refs/heads/master@{#408754}
MD Settings: add test for managed actionability of people section
[email protected]
BUG=629604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2195793003
Cr-Commit-Position: refs/heads/master@{#408753}
Add rego and jfernandez to core/OWNERS after successful nomination
NOTRY=true
Review-Url: https://codereview.chromium.org/2193373002
Cr-Commit-Position: refs/heads/master@{#408752}
Make HostBrowserClassLoader#getClassLoaderInstance() work if Chrome gets updated
WebAPK process is not guaranteed to terminate when Chrome gets updated. The
WebAPK code assumes that it is always using the latest version of runtime
library. In order to guarantee this, the ClassLoader must be re-created if Chrome
is updated but the WebAPK is still running.
BUG=627950
TEST=HostBrowserLauncherTest.*
TBR=hanxi (TBR for DEP on testing/ by JUnit test)
Review-Url: https://codereview.chromium.org/2179163002
Cr-Commit-Position: refs/heads/master@{#408751}
Fix Bold font is not seen for Remove this Person text of Supervised User in CrOS
Not sure why it is missing. Probably related to this CL: https://codereview.chromium.org/2007133006
This fix is to add a style to .remove-warning-button.
BUG=631975
Review-Url: https://codereview.chromium.org/2197653003
Cr-Commit-Position: refs/heads/master@{#408750}
MD Settings: Fix footer text alignment in CBD.
Credit goes to @dbeam.
BUG=632674
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2194823004
Cr-Commit-Position: refs/heads/master@{#408749}
[ash-md] Disables rounded corners by default in overview mode
This CL only changes the default for the --ash-max-previews-to-use-mask
runtime flag to 0 (from 10). Not using masks seems to improve animation.
BUG=632825
TEST=None
Review-Url: https://codereview.chromium.org/2193403002
Cr-Commit-Position: refs/heads/master@{#408748}
Roll src/third_party/catapult/ 317e984a8..28aad26a0 (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/317e984a87db..28aad26a05ee
$ git log 317e984a8..28aad26a0 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2191383003
Cr-Commit-Position: refs/heads/master@{#408747}
Broaden the check for whether an intent came from Chrome for herb check.
BUG=632488
Review-Url: https://codereview.chromium.org/2195773003
Cr-Commit-Position: refs/heads/master@{#408746}
Change logging statements to not use the "%" operator.
AKA "lazy logging".
This slightly improves readability because it decreases
the number of parentheses. It also saves a tiny amount of time
constructing the interpolated strings for debug statements
when the logging level would make it so that debug logs
are not printed.
This fixes the logging-not-lazy warnings which were
just enabled in http://crrev.com/2120083002.
This CL also changes the few instances of _log.warn to
_log.warning for consistency.
Note, most of the changes were done with sed:
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % (\(.*\)))/\.\1(\2, \3)/
s/\.\(debug\|warning\|warn\|info\|error\|critical\)(\(.*\) % \(.*\))/\.\1(\2, \3)/
BUG=598897
Review-Url: https://codereview.chromium.org/2188623002
Cr-Commit-Position: refs/heads/master@{#408745}
Notify page load metrics when the app enters the background.
This change adds a PageLoadMetricsProvider, which implements the new
OnAppEnterBackground hook, and informs all MetricsWebContentsObservers
and in turn all PageLoadTrackers when the app enters the background.
On Android (and iOS), when an app enters the background, it may be
killed without further notifications. Thus, having this callback
will allow us to persist metrics before the app may be killed.
Our page load metrics subsystem isn't used on iOS, so we only target
Android in this change.
Unfortunately, we can't use the existing WebContents hidden callback,
as this gets invoked after the UMA subsystem has already flushed
metrics to disk. Thus, we need to add this explicit callback which
allows us to persist metrics as part of the UMA subsystem handling
the backgrounding callback.
For now, we log a debugging histogram in PageLoadTracker to help
understand how often trackers enter the background, and how often
those trackers are destroyed without running their destructors. In a
subsequent change, we'll add support for informing PLMObservers that
the app entered the background. This will allow any PLMObsevers that
implement OnComplete or OnFailedProvisionalLoad to also get called back
in cases where the tracker may be destroyed before its destructor runs,
due to the application being killed.
BUG=608360
Review-Url: https://codereview.chromium.org/2189543002
Cr-Commit-Position: refs/heads/master@{#408744}
[DevTools] Cleanup v8_inspector console API.
BUG=631162
TBR=pfeldman
Review-Url: https://codereview.chromium.org/2194683003
Cr-Commit-Position: refs/heads/master@{#408743}
Add a pre-finalizer to PromiseRejectionEvent
We need to clear ScopedPersistents so that V8 doesn't call phantom callbacks
after Oilpan starts lazy sweeping.
BUG=626893
Review-Url: https://codereview.chromium.org/2196543003
Cr-Commit-Position: refs/heads/master@{#408742}
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in DocumentMarkerController.
BUG=590369
R=yosin,esprehn
Review-Url: https://codereview.chromium.org/2142903003
Cr-Commit-Position: refs/heads/master@{#408741}
Comment out an identifier for for an obsolete infobar, and notate
two that seem unused as iOS only.
BUG=none
Review-Url: https://codereview.chromium.org/2197713002
Cr-Commit-Position: refs/heads/master@{#408740}
Simplify landmines code a bit now that all branches of all platforms are on ninja
BUG=none
Review-Url: https://codereview.chromium.org/2071463002
Cr-Commit-Position: refs/heads/master@{#408739}
Remove sign in preference in demo mode
BUG=632379
Review-Url: https://codereview.chromium.org/2195563002
Cr-Commit-Position: refs/heads/master@{#408738}
A couple fixes to net_data_job_fuzzer.
In particular, the code was being run on non-data URLs, which caused it
to do weird and exciting things, and it had an incorrect DCHECK.
BUG=632605
Review-Url: https://codereview.chromium.org/2191323005
Cr-Commit-Position: refs/heads/master@{#408737}
Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).
This mostly cleans up some routing code in Quick Unlock. It also has a few small fixes in People.
BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2154213008
Cr-Commit-Position: refs/heads/master@{#408736}
[Password Generation] Add FormFieldData.properties_mask to mojo
The similar CL for IPC https://codereview.chromium.org/2148303005/
BUG=582434
Review-Url: https://codereview.chromium.org/2189543004
Cr-Commit-Position: refs/heads/master@{#408735}
Multi-pod support for lock screen.
BUG=616536
Review-Url: https://codereview.chromium.org/2129253002
Cr-Commit-Position: refs/heads/master@{#408734}
Revert of Linux: Support the --class argument (patchset #4 id:60001 of https://codereview.chromium.org/2186813002/ )
Reason for revert:
Change breaks compile on Linux x64: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/12770
Original issue's description:
> Linux: Support the --class argument
>
> It appears we lost support for --class when we stopped using gtk for our
> windowing. This CL adds that feature back.
>
> BUG=118613
>
> Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520
> Cr-Commit-Position: refs/heads/master@{#408709}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=118613
Review-Url: https://codereview.chromium.org/2193393002
Cr-Commit-Position: refs/heads/master@{#408733}
Migrate IDL compiler documentation to Markdown.
The existing doc (https://sites.google.com/a/chromium.org/dev/developers/design-documents/idl-compiler)
looks old, but it's probably better to keep it next to the code.
R=haraken,yukishiino
BUG=
Review-Url: https://codereview.chromium.org/2195743003
Cr-Commit-Position: refs/heads/master@{#408732}
Disable top_10_mobile_memory_ignition on mac.
[email protected]
BUG=630854
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;
Review-Url: https://codereview.chromium.org/2189383002
Cr-Commit-Position: refs/heads/master@{#408731}
[Offline Pages] Add expiration in internal log.
Add expired as a logged event in offline-internal page.
BUG=NONE
Review-Url: https://codereview.chromium.org/2191183002
Cr-Commit-Position: refs/heads/master@{#408730}
bluetooth: Reject getPrimaryService(s) if frame is not connected
First of three patches to reject promises if the frame is not connected
or the frame disconnected while the promise was not fulfilled.
Implements:
1. The ActiveAlgorithm set[1] as m_activeAlgorithms in BluetoothRemoteGATTServer
2. gattServer-connection-checking wrapper[2] as GetPrimaryServicesCallback in
BluetoothRemoteGattServer.cpp
3. Connection check of query bluetooth cache[3] in getPrimaryServicesImpl.
[1] https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-activealgorithms-slot
[2] https://webbluetoothcg.github.io/web-bluetooth/#connection-checking-wrapper
[3] https://webbluetoothcg.github.io/web-bluetooth/#query-the-bluetooth-cache
BUG=608538
Review-Url: https://codereview.chromium.org/2183903002
Cr-Commit-Position: refs/heads/master@{#408729}
chrome/utility/safe_browsing: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2194613002
Cr-Commit-Position: refs/heads/master@{#408728}
chrome/browser/renderer_context_menu: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2195483004
Cr-Commit-Position: refs/heads/master@{#408727}
Fix spurious WebRTC test failure on certain IPv6 networks
A helper function that determines whether an IP address is loopback was
checking for a "::1" substring in the IP address. Non-loopback IPv6
addresses can have that substring - e.g. "1234::1234:1234". If the test
runs on a machine with one of these addresses, it would fail
erroneously.
The fix simply adds spaces on both sides of the pattern, so that it only
matches complete IP addresses (always surrounded by spaces in an ICE
candidate line).
BUG=629705
Review-Url: https://codereview.chromium.org/2185533007
Cr-Commit-Position: refs/heads/master@{#408726}
Fold compositing display items into contained drawings if the drawing is a singleton.
BUG=628831
Review-Url: https://codereview.chromium.org/2186643002
Cr-Commit-Position: refs/heads/master@{#408725}
chrome/browser/renderer_host: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2188393002
Cr-Commit-Position: refs/heads/master@{#408724}
cc : Use dynamically calculated target space transforms
In ComputeTransformToTarget and ComputeTransformFromTarget. This is
turned on only when verify_transform_tree_calculations is true (only
cc_unittests as of now) and when target is an ancestor (as that's
the only case dynamically calculated target space transforms support
right now)
This CL also sets verify_transform_tree_calculations and
verify_clip_tree_calculations in some tests.
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2191983002
Cr-Commit-Position: refs/heads/master@{#408723}
Don't crash when closing UI while waiting for apps to respond.
BUG=632468
Review-Url: https://codereview.chromium.org/2193293003
Cr-Commit-Position: refs/heads/master@{#408722}
chrome/browser/profiles: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2192033002
Cr-Commit-Position: refs/heads/master@{#408721}
chrome/browser/safe_browsing: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2194653002
Cr-Commit-Position: refs/heads/master@{#408720}
skia_commit_hash.h
shows up in chrome://gpu
makes use of build/util/lastchange.py
BUG=235455
Review-Url: https://codereview.chromium.org/2187533002
Cr-Commit-Position: refs/heads/master@{#408719}
chrome/common: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
R=dsinclair, jochen
BUG=554600
Review-Url: https://codereview.chromium.org/2184913006
Cr-Commit-Position: refs/heads/master@{#408718}
Add DVLOG with child process id in mojo shell.
When running "./chrome --mash" most child processes no longer have the
mojo application name as part of the command string. This makes it
difficult to figure out what part of mus+ash LOG statements or CHECK
failures come from. Add a DVLOG(0) that prints out the name and pid when
a child process is successfully launched.
Using verbosity level 0 since it is important information for debugging
and should occur rarely.
BUG=none
Review-Url: https://codereview.chromium.org/2194943002
Cr-Commit-Position: refs/heads/master@{#408717}
MD Settings: disable cursor: pointer when sync is disabled
[email protected]
BUG=629604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2178303003
Cr-Commit-Position: refs/heads/master@{#408716}
chrome/browser/media: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2194673002
Cr-Commit-Position: refs/heads/master@{#408715}
Revert "Send got/lostpointercapture immediately if possible"
This reverts commit 7d314cf3ad6a9f0fe163228f7a0efc5a72adc560 as a follow up to the decision about delayed capturing
https://github.com/w3c/pointerevents/issues/32
This also gets rid of the need to make PointerEventManager a GC object.
BUG=627192, 629935
Review-Url: https://codereview.chromium.org/2193473002
Cr-Commit-Position: refs/heads/master@{#408714}
chrome/browser/notifications: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2193653002
Cr-Commit-Position: refs/heads/master@{#408713}
chrome/browser/printing: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2194643003
Cr-Commit-Position: refs/heads/master@{#408712}
Change RequestFinishedListener to provide executor
RequestFinishedListener originally depended on NetworkQualityEstimator's
executor. These are separate features which should not depend on each
other, and as of recently the NQE listeners also provide their own
executors.
Also move RequestFinishedListener out of CronetEngine into its own file,
and move its tests into their own file.
BUG=618034
Review-Url: https://codereview.chromium.org/2178053002
Cr-Commit-Position: refs/heads/master@{#408711}
Revert of services/ui: Revert CLs that broke Windows. (patchset #2 id:20001 of https://codereview.chromium.org/2194893002/ )
Reason for revert:
crrev.com/408695 fixes the issue. So we can reland
these CLs.
Original issue's description:
> services/ui: Revert CLs that broke Windows.
>
> The new GPU code path does not seem to work correctly on Windows yet
> (everything is black). So restore the deprecated path.
>
> Revert "services/ui: Remove deprecated gpu code" crrev.com/408207
> Revert "services/ui: Remove unused connector argument" crrev.com/408230
>
> BUG=623157, 630893
> TBR=ben@, piman@, penghuang@
>
> Committed: https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d
> Cr-Commit-Position: refs/heads/master@{#408648}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623157, 630893
Review-Url: https://codereview.chromium.org/2196503003
Cr-Commit-Position: refs/heads/master@{#408710}
Linux: Support the --class argument
It appears we lost support for --class when we stopped using gtk for our
windowing. This CL adds that feature back.
BUG=118613
Review-Url: https://codereview.chromium.org/2186813002
Cr-Commit-Position: refs/heads/master@{#408709}
Rename EarlGrey test classes with TestCase suffix.
They inherit from XCTestCase, so TestCase suffix makes
it a bit more clear.
BUG=
Review-Url: https://codereview.chromium.org/2195773002
Cr-Commit-Position: refs/heads/master@{#408708}
Split ServiceRegistryAndroid into InterfaceRegistryAndroid and InterfaceProviderAndroid
This has been done in the C++ layer already, and I'd like to do this on the Java side as well since a single object doesn't always want to hold both the registry and the provider objects.
[email protected]
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2191033002
Cr-Commit-Position: refs/heads/master@{#408707}
[DevTools] Always instrument async tasks in V8Debugger.
BUG=631162
Review-Url: https://codereview.chromium.org/2197723002
Cr-Commit-Position: refs/heads/master@{#408706}
MD/vectorize wifi icons.
Testable with: chrome --ash-md=experimental --shill-stub=ethernet=off
BUG=617304
Review-Url: https://codereview.chromium.org/2186353002
Cr-Commit-Position: refs/heads/master@{#408705}
Update V8 to version 5.4.299.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/381147c5..8d5d2145
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2198443002
Cr-Commit-Position: refs/heads/master@{#408704}
Remove stray #include.
This was left in here while debugging. I forgot to remove it.
BUG=none
Review-Url: https://codereview.chromium.org/2189373002
Cr-Commit-Position: refs/heads/master@{#408703}
Improving the description of the dynamic rendering mode switching flag.
BUG=606687, 606686, 606685
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2194963002
Cr-Commit-Position: refs/heads/master@{#408702}
Check for FROM_EXIT in TabModelGetLastId().
This early return is meant to avoid storing the last ID for a tab which is about
to be destroyed. The behavior should logically apply equally to FROM_CLOSE and
FROM_EXIT, but by an oversight, only FROM_CLOSE was checked.
BUG=629080
Review-Url: https://codereview.chromium.org/2195543002
Cr-Commit-Position: refs/heads/master@{#408701}
Roll src/third_party/skia/ 1e8761809..5db44aa2a (6 commits).
https://chromium.googlesource.com/skia.git/+log/1e8761809d76..5db44aa2aa4a
$ git log 1e8761809..5db44aa2a --date=short --no-merges --format='%ad %ae %s'
2016-07-29 mtklein GN: components as static library instead of source set
2016-07-29 msarett Fix various SkColorSpace bugs
2016-07-29 egdaniel Use HashSet instead of Dynamic hash for tracking vulkan resources
2016-07-29 fmalita [SVGDom] Parse style attributes
2016-07-29 halcanary SkPDF: flip saveLayer rightside up
2016-07-29 mtklein GN: quick doc
BUG=632574
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2193593004
Cr-Commit-Position: refs/heads/master@{#408700}
Undo scroll snaps in to_parent when NeedsSourceToParentUpdate.
When we scroll on impl thread, we do scroll snapping in transform trees
if the transform node has a non-integer screen space transform. However,
the main thread logic also do snapping. When updating source to parent
transforms on main thread, it is possible that the scroll snaps are used
to compute the to_parent transform.
It becomes a problem if the node is created due to a fixed pos layer,
the snapping will add a small translation to the to_parent transform and
result in the unstable position. This CL undoes the snapping in this
case. It is notable that scroll_parent might also be influenced by this
change.
BUG=584598
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2183923002
Cr-Commit-Position: refs/heads/master@{#408699}
Add check for mismatching item and document sequence numbers.
When a PageState update is received from the renderer process, it must
be for the current session history entry. This means that the sequence
numbers associated with the FrameNavigationEntry should match the ones
coming from the renderer process.
This CL adds a check for this case and drops the update if mismatch is
found.
BUG=628677
Review-Url: https://codereview.chromium.org/2196623003
Cr-Commit-Position: refs/heads/master@{#408698}
Roll src/third_party/catapult/ 430002a69..317e984a8 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/430002a696ad..317e984a87db
$ git log 430002a69..317e984a8 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2194803004
Cr-Commit-Position: refs/heads/master@{#408697}
[MD settings] remove label float from dropdowns so that they center correctly
This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.
BUG=632543
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2191203002
Cr-Commit-Position: refs/heads/master@{#408696}
services/ui: Fix new GPU code path on Windows.
Make sure the child window created by the GPU is actually added to the
toplevel window.
BUG=623157
Review-Url: https://codereview.chromium.org/2188403004
Cr-Commit-Position: refs/heads/master@{#408695}
Fix a comment.
The comment used to be correct, but
https://chromiumcodereview.appspot.com/9958139 broke it. Unbreak it again.
BUG=none
TBR=jochen
Review-Url: https://codereview.chromium.org/2152053003
Cr-Commit-Position: refs/heads/master@{#408694}
Revert of Enable RenderPassDrawQuad promotion to CALayer. (patchset #1 id:1 of https://codereview.chromium.org/2183333002/ )
Reason for revert:
Has correctness problems:
https://bugs.chromium.org/p/chromium/issues/detail?id=632613#c5
And likely performance problems:
https://bugs.chromium.org/p/chromium/issues/detail?id=632636
Original issue's description:
> Enable RenderPassDrawQuad promotion to CALayer.
>
> This CL enables the Core Animation compositor's implementation of CSS filter
> effects.
>
> BUG=581526
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/c2e44129f9712162be14a1a054225e29d89b1296
> Cr-Commit-Position: refs/heads/master@{#408216}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=581526
Review-Url: https://codereview.chromium.org/2193623004
Cr-Commit-Position: refs/heads/master@{#408693}
arc: bluetooth: Always acquire a NotifySession
If Arc++ needs to keep receiving notifications it needs to
unconditionally acquire a NotifySession. The Bluetooth API
uses a ref-counting model to write to the descriptor. If
other clients drop their NotifySessions, notifications will stop.
BUG=632476
TEST=Build
Review-Url: https://codereview.chromium.org/2189183002
Cr-Commit-Position: refs/heads/master@{#408692}
[Chromecast] Disable audio filtering on silence data.
Audio filters can be costly to run, and this skips them on silence data.
BUG=internal b/30441995
TEST=cast_alsa_cma_backend_unittests; ensured large reduction in CPU
utilization on live system.
Change-Id: I18bce9c6fea35493adf8a018d6655e11858a3a34
Review-Url: https://codereview.chromium.org/2194773002
Cr-Commit-Position: refs/heads/master@{#408691}
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest
This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented
(i.e., Android).
WebRtcImageCaptureBrowserTest needs access to the
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made
public and reused as base class for the former.
Also, this CL moves
content/test/webrtc_content_browsertest_base.{cc,h}
to
content/browser/media/webrtc/
since they are purely internal to content_browsertests.
BUG=627537, 518807
TEST=new content_browsertests
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
(all platforms)
Review-Url: https://codereview.chromium.org/2190523004
Cr-Commit-Position: refs/heads/master@{#408690}
Fix tab model merging crash & tab selection
saveTabListAsynchronously() was previously being called in a
background task when a merge finished; it needs to be called
from the UI thread.
Select the first tab during a merge if the model being merged
into has no tabs to ensure that a tab selection is set.
BUG=631854, 602498
Review-Url: https://codereview.chromium.org/2195573002
Cr-Commit-Position: refs/heads/master@{#408689}
MD History: fix typo and dialog inheritance
[email protected]
BUG=632572,632602
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2198463002
Cr-Commit-Position: refs/heads/master@{#408688}
Chooser spinner should disappear as soon as one device shows up
The chooser needs to show devices as they come. So the spinner should
disappear as soon as one device shows up. This can reduce the wait time
and user can select a device more quickly if it is already listed in
the chooser.
I added some screenshots at issue 583452.
BUG=583452, 632173
Review-Url: https://codereview.chromium.org/2192953002
Cr-Commit-Position: refs/heads/master@{#408687}
Disable top_10_mobile_memory on mac.
[email protected]
BUG=630854
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;
Review-Url: https://codereview.chromium.org/2197553003
Cr-Commit-Position: refs/heads/master@{#408686}
Remove didInvalidateRect calls from WebViewClient and move it to
WebWidgetClient.
This is part of a refactor to split WebView/WebWidget.
BUG=583347
Review-Url: https://codereview.chromium.org/2175233005
Cr-Commit-Position: refs/heads/master@{#408685}
[Password Generation] Sends field properties mask in autofill upload
1. Extend |PasswordAutofillAgent.nonscript_modified_values_| to FieldValueAndPropertiesMaskMap that is a map from WebFormControlElement to the pair of:
a) The most recent text that user typed or PasswordManager autofilled in input elements. Used for storing username/password before JavaScript changes them.
a) Field properties mask, i.e. whether the field was autofilled, modified by user, etc. (see FieldPropertiesMask). THIS ONE was added.
2) Update field properties mask on (PasswordAutofillAgent)
a) autofilling form field
b) user input in a field
c) user moves focus to a field
3) On FormData initialization, copy field properties masks from |field_value_and_properties_map_| to |FormFieldData.properties_mask|. Thus, the field properties masks will be sent to the browser on form submission, inpage nvaigation, force saving.
4) On the browser side, copy the field properties to |pending_credentials_|. See PasswordFormManager.CreatePendingCredentials()
5) Add the field properties mask to autofill upload request.
BUG=552420
TEST=FormStructureTest.EncodeUploadRequestWithAdditionalPasswordFormSignature, PasswordAutofillAgentTest.RememberFieldPropertiesOnSubmit, PasswordAutofillAgentTest, RememberFieldPropertiesOnInPageNavigation, PasswordFormManagerTest.FieldPropertiesMasksUpload
Review-Url: https://codereview.chromium.org/2148303005
Cr-Commit-Position: refs/heads/master@{#408684}
Remove finch experiment for the STHSet component.
Picked the way that seems to address the start-up regression best.
BUG=607946
[email protected] (revert of r404457)
Review-Url: https://codereview.chromium.org/2193163003
Cr-Commit-Position: refs/heads/master@{#408683}
[ios] Cleaned up web EG matchers.
1.) Dropped Obj-C API as unused
2.) Pass std::string by value because they almost always used in blocks
3.) Consistently use C++ Style for variable naming
4.) Dropped namespace prefixing where unneeded
BUG=None
Review-Url: https://codereview.chromium.org/2192593002
Cr-Commit-Position: refs/heads/master@{#408682}
Revert of [Media Router Contextual Menu] Test 'checked' state of cloud services item. (patchset #2 id:60001 of https://codereview.chromium.org/2190223002/ )
Reason for revert:
Broke official build.
Original issue's description:
> [Media Router Contextual Menu] Test 'checked' state of cloud services item.
>
> Add a test to check whether the "Enable cloud services" item is currently checked or not.
>
> BUG=623330
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/5dc8d635fceca17f8bf56044865ae4afb462f48c
> Cr-Commit-Position: refs/heads/master@{#408640}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623330
Review-Url: https://codereview.chromium.org/2196453004
Cr-Commit-Position: refs/heads/master@{#408681}
Remove the concept of retrying a request.
To make our life simpler for shipping M54, set the max number of retries to 1. We may turn it back up in a future milestone.
BUG=610521
Review-Url: https://codereview.chromium.org/2191733004
Cr-Commit-Position: refs/heads/master@{#408680}
Revert "Try again to flip official win builders to GN."
It looks like the syzygy build is still incorrect :(.
[email protected]
BUG=632566, 623659
Review-Url: https://codereview.chromium.org/2195713003
Cr-Commit-Position: refs/heads/master@{#408679}
Roll src/third_party/catapult/ 3c3afa500..430002a69 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3c3afa500fca..430002a696ad
$ git log 3c3afa500..430002a69 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2191103003
Cr-Commit-Position: refs/heads/master@{#408678}
Add UMA for cross origin subresources triggering HTTP Auth.
This is a follow up to crrev.com/2138533002 which didn't
differentiate between same origin and cross origin
subresources.
BUG=400380
Review-Url: https://codereview.chromium.org/2190803003
Cr-Commit-Position: refs/heads/master@{#408677}
GN: only write targets that should be generated.
Apparently forever GN has been writing .ninja files for targets that were resolved but didn't have the "should generate" bit set. The "should generate" bit will be unset for things in non-default toolchains that aren't required to build anything in the main toolchain. This set of things is small since most things will have incomplete deps if they're not required. But it comes up for a few NaCl copy rules.
The extra files were never a problem because only "should generate" targets were written to the main ninja file, so the extra files were just unreferenced. The recent change that moves more stuff into the main file rather than subninjas exposed the bug, which now appears as multiply-defined targets.
This fix only issues the callback when an item is both resolved and "should generate" is set.
Review-Url: https://codereview.chromium.org/2195753002
Cr-Commit-Position: refs/heads/master@{#408676}
Fix audit/tracking entries for ios builders in mb config.
For iOS builders, MB doesn't actually use the entries in mb_config.pyl
to generate the build args, but we still distinguish between gyp/gn
so that `mb audit` can track things. However, when I flipped the
builders to GN, I forgot to update the entries here.
[email protected]
Review-Url: https://codereview.chromium.org/2196753002
Cr-Commit-Position: refs/heads/master@{#408675}
Add equality and empty tests for first_contentful_paint
ksakamoto discovered that our PageLoadTiming code is missing
equality/empty tests for the first_contentful_paint field.
This means that when FCP is different from FP, and no subsequent
metrics are logged for a given page, FCP may erroneously not get
logged for that page.
BUG=632765
Review-Url: https://codereview.chromium.org/2195743002
Cr-Commit-Position: refs/heads/master@{#408674}
[AFL][libFuzzer] Fix read past end of fuzzing target input buffer.
BUG=
Review-Url: https://codereview.chromium.org/2193283002
Cr-Commit-Position: refs/heads/master@{#408673}
MuteSource Audio During Full Screen Cast
Previously, when casting a chrome tab, the source audio is
automatically muted; however, casting the full screen, the
system audio is still audible.
This CL makes the behavior consistent.
P.S. But the technique is different for muting a tab and muting system audio.
1. For muting tab, we divert the audio stream from speaker
to WebContentsAudioInputStream.
2. For muting system audio, we call the OS API to do so,
which is just as if the user click the "mute" button on
the task bar.
Visible difference is that during capturing, the user is
not able to unmute tab audio on the capture side, but
nothing can prevent the end user to unmute system audio.
BUG=629561
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2144333002
Cr-Commit-Position: refs/heads/master@{#408672}
Auto-rebaseline for r408543
https://chromium.googlesource.com/chromium/src/+/e704a3c06
BUG=619103
[email protected]
Review URL: https://codereview.chromium.org/2196783002 .
Cr-Commit-Position: refs/heads/master@{#408671}
Remove a DCHECK on ClientSocketHandle state from proxy code.
This was causing issues for one of our fuzzers.
The DCHECK made sure the ClientSocketHandle was initialized, which was
not the state in tests. Normally, handles set initialized to true
when they are assigned a socket, and the connection callback is invoked.
When the Handle is torn down, if the Handle was initialized, the socket
is returned to the socket pool. A lot of tests bypass all this, not
using socket pools at all, and just assigning a socket to the
SocketHandle. This results in is_connected being false, which was
triggering the DCHECK.
We could instead make sure that is_initialized is set to true in tests,
but this has minimal value - in production, it's set to true if and only
if a socket is set and the callback invoked, and set to false only when
the socket is destroyed or returned to the socket pool. If the socket is
null, we'll crash very soon with an equally useful crash stack, anyways.
In production, if the connection callback wasn't invoked, the
HttpProxyClientSocket's state machine will catch the issue, anyways.
BUG=632608
Review-Url: https://codereview.chromium.org/2192193002
Cr-Commit-Position: refs/heads/master@{#408670}
Revert of Reenable start_with_ext tests. (patchset #1 id:1 of https://codereview.chromium.org/2188273002/ )
Reason for revert:
Errors on waterfall:
https://bugs.chromium.org/p/chromium/issues/detail?id=563424#c25
Original issue's description:
> Reenable start_with_ext tests.
>
> BUG=563424
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/c51f7349b05bfaccbff4ac41d6897f84d9c9d64b
> Cr-Commit-Position: refs/heads/master@{#408523}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=563424
Review-Url: https://codereview.chromium.org/2195763002
Cr-Commit-Position: refs/heads/master@{#408669}
Let blink scheduler know when background parsing a document
This is necessary to make Virtual time behave deterministically.
Without knowing that a document is being parsed in the background
we might think loading is safe to run timers (which it isn't if
you want determinism).
BUG=546953
Review-Url: https://codereview.chromium.org/2192493002
Cr-Commit-Position: refs/heads/master@{#408668}
Add jar_excluded_patterns support in android_aar_prebuilt
Gvr library needs to exclude protobuf classes(chromium has its own version)
in order to link properly with chromium. This CL adds
"jar_excluded_patterns" support for android_aar_prebuilt
BUG=632730
Review-Url: https://codereview.chromium.org/2188243002
Cr-Commit-Position: refs/heads/master@{#408667}
Refactor browser process coordinate transformation code
The current Surface-based coordinate transformation methods are only
useful for transforming coordinates from a child frame's coordinate
space to the root's space. More flexibility is needed for delivering
MouseMove events to multiple renderer processes for the sake of
MouseEnter and MouseLeave event handlers. This CL reworks the exposed
methods in RenderWidgetHostViewBase and DelegatedFrameHost to provide
that flexibility.
BUG=632035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2184033003
Cr-Commit-Position: refs/heads/master@{#408666}
[Android] Set platform mode as default for perf tests.
BUG=615157
Review-Url: https://codereview.chromium.org/2189773002
Cr-Commit-Position: refs/heads/master@{#408665}
Remove expectation images incorrectly added by autorebaseline bot
Auto rebaseline bot incorrectly added layout test expectation images in
platform/android for tests that are not run on Android bots in r408359.
This patch manually removes them.
BUG=619452
[email protected]
Review-Url: https://codereview.chromium.org/2188393003
Cr-Commit-Position: refs/heads/master@{#408664}
Update V8 to version 5.4.296.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b9200bca..381147c5
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2195733002
Cr-Commit-Position: refs/heads/master@{#408663}
Fix the common typo "snaphot" (should be "snapshot")
While looking at blink's File API code I noticed a repeated typo.
Since I was fixing it there, I grepped the rest of the code base and
fixed other instances too.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2179903010
Cr-Commit-Position: refs/heads/master@{#408662}
Update comments on some find-in-page methods.
I noticed that some of the comments on find-in-page methods in WebLocalFrame still mention that they apply either to multiple frames or only to the main frame. This is no longer true, so this patch updates these comments.
Review-Url: https://codereview.chromium.org/2184213002
Cr-Commit-Position: refs/heads/master@{#408661}
cc serialization perf: Add a couple more tests
Add two more tests that better represent real world CompositorFrame sizes
1. 100 Quads * 5 RenderPasses
2. 500 Quads * 10 RenderPasses
BUG=624459
Review-Url: https://codereview.chromium.org/2190943002
Cr-Commit-Position: refs/heads/master@{#408660}
Move chromium-specific QUIC files net/quic/chromium/
BUG=
Review-Url: https://codereview.chromium.org/2185203002
Cr-Commit-Position: refs/heads/master@{#408659}
Roll src/third_party/skia/ 50ce1f28f..1e8761809 (3 commits).
https://chromium.googlesource.com/skia.git/+log/50ce1f28ffed..1e8761809d76
$ git log 50ce1f28f..1e8761809 --date=short --no-merges --format='%ad %ae %s'
2016-07-29 robertphillips Remove GrContext::applyGamma GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191323002
2016-07-29 csmartdalton Add test configs for instanced rendering
2016-07-29 egdaniel Merge ProgramDesc's for GL and Vulkan
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2193253002
Cr-Commit-Position: refs/heads/master@{#408658}
[UserScript cleanup] Remove use of ScopedVector from UserScriptSet.
Change it to vector of unique_ptrs.
Also remove an used param from UserScriptSet::OnUserScriptUpdated().
BUG=622464
Test=None, internal cleanup.
Review-Url: https://codereview.chromium.org/2193093002
Cr-Commit-Position: refs/heads/master@{#408657}
Settings: Update translation strings that needed clarifying.
I got two bugs from the translator on these description being unclear.
Hopefully these changes clear it up.
[email protected]
BUG=NONE
Review-Url: https://codereview.chromium.org/2194513002
Cr-Commit-Position: refs/heads/master@{#408656}
Fix serialization of css-wide keywords in custom properties
Serialize css-wide keywords in custom properties by prefixing
it with a space character and then serialing the keyword
itself (inherit/initial/unset).
BUG=632242
Review-Url: https://codereview.chromium.org/2188343002
Cr-Commit-Position: refs/heads/master@{#408655}
Change wildcard source expression matching to conform latest spec
This changes wildcard source expression matching to require
any schemes other than http/https/ws/wss be explicitly present
in the source list to match, per
https://w3c.github.io/webappsec-csp/#match-url-to-source-expression
This also updates CSP injected in inline_login_ui.cc to explicitly allow
`chrome:` as in `connect-src * chrome:` to fix failing tests.
Previous CL at https://codereview.chromium.org/1973933002/ is stale,
so creating a new one to nail it this time.
BUG=611314
[email protected]
Review-Url: https://codereview.chromium.org/2160983002
Cr-Commit-Position: refs/heads/master@{#408654}
aw: Fix WebViewDatabaseAdapter threading
Hope to UI thread where needed.
BUG=630709
Review-Url: https://codereview.chromium.org/2191053002
Cr-Commit-Position: refs/heads/master@{#408653}
Pass per-frame task runners to Workers (when possible)
- For in-process workers (i.e. dedicated/compositor workers): always use
the associated document's task runners
- For out-of-process workers (i.e. service/shared workers): keep using the
default task runner of the main thread, but via TaskRunnerHelper so
we could still start using different task runners for different tasks
(e.g. loading vs timer) if we want.
BUG=627034
Review-Url: https://codereview.chromium.org/2163983004
Cr-Commit-Position: refs/heads/master@{#408652}
Remove layerTreeView calls from WebViewClient and move it to
WebWidgetClient.
This is part of a refactor to split WebView/WebWidget.
BUG=583347
Review-Url: https://codereview.chromium.org/2178993004
Cr-Commit-Position: refs/heads/master@{#408651}
[NTP Client] Remove SnippetService's dependency on Sync
The SnippetService doesn't care about the sync state anymore so we
can get rid of that dependency.
BUG=627488
[email protected]
Review-Url: https://codereview.chromium.org/2191343002
Cr-Commit-Position: refs/heads/master@{#408650}
[InputEvent] Support inputType Insert* and Delete*
This CL adds support for various insert/delete related inputTypes:
1. InsertLineBreak
2. InsertParagraph
3. DeleteComposedCharacterForward/Backward
4. DeleteWordForward/Backward
5. DeleteLineForward/Backward
6. DeleteContentForward/Backward
Note:
1. Blink's command |InsertNewLine| could be either |InsertLineBreak| or |InsertParagraph| depends on rich text editable.
2. On Mac OS Kill/Yank actions are treated as Delete*/Insert*
BUG=585875
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ
Review-Url: https://codereview.chromium.org/2166013002
Cr-Commit-Position: refs/heads/master@{#408649}
services/ui: Revert CLs that broke Windows.
The new GPU code path does not seem to work correctly on Windows yet
(everything is black). So restore the deprecated path.
Revert "services/ui: Remove deprecated gpu code" crrev.com/408207
Revert "services/ui: Remove unused connector argument" crrev.com/408230
BUG=623157, 630893
TBR=ben@, piman@, penghuang@
Review-Url: https://codereview.chromium.org/2194893002
Cr-Commit-Position: refs/heads/master@{#408648}
Return the certificate chain in ClientCertStoreNSS.
NSS used to build a chain internally in the SSL stack which got lost
when switching to BoringSSL. Align with other platforms by building the
chain externally in ClientCertStoreNSS.
Although this is inherently somewhat flaky, some servers do not have
intermediates configured locally and expect the client to supply them.
This modifies (really completely rewrites) our bundled
NSS_CmpCertChainWCANames to return the chain it found. That is returned
out of ClientCertStoreNSS.
Note that this is not completely the same as the old behavior. Rather
than building as much of a path as we can manage from the leaf, we will
stop at the issuer list supplied by the server. It is assumed that the
server accepts the issuers it claims to accept. We also only do
name-based matching (which we were doing anyway) to avoid adding a more
expensive global operation in the candidate matching path.
In doing so, this syncs NSS with other platforms in removing the ancient
workaround for Netscape Enterprise Server 2.0, released in 1996.
Tested with unit tests and also manually against a custom Go server.
BUG=548631
Review-Url: https://codereview.chromium.org/2185403003
Cr-Commit-Position: refs/heads/master@{#408647}
Add remove non-device-owner user removal confirmation
Just like removing supervised user, there will be a removing warning UI for removing non-device-owner (since device owner doesn't show "Remove this person" entry).
The removing warning message right now is just a placeholder. Will update it later once I hear it back from the discussion.
BUG=611904
TEST=device test
Review-Url: https://codereview.chromium.org/2189163002
Cr-Commit-Position: refs/heads/master@{#408646}
Delete unused field within .build_config: resources_deps
BUG=none
Review-Url: https://codereview.chromium.org/2194813002
Cr-Commit-Position: refs/heads/master@{#408645}
Mojo C++ bindings: make ipc/ mojom targets to use STL string/vector types
BUG=624136,631415
Committed: https://crrev.com/9d5c6a8af5e8298269dc0edf38831a8360be3c7b
Review-Url: https://codereview.chromium.org/2181443002
Cr-Original-Commit-Position: refs/heads/master@{#407340}
Cr-Commit-Position: refs/heads/master@{#408644}
aw: Fix FactoryProvider threading
Access thread-unsafe chromium classes on the UI thread only
BUG=630709
Review-Url: https://codereview.chromium.org/2180423003
Cr-Commit-Position: refs/heads/master@{#408643}
Roll src/third_party/skia/ 830c91362..50ce1f28f (1 commit).
https://chromium.googlesource.com/skia.git/+log/830c913625ac..50ce1f28ffed
$ git log 830c91362..50ce1f28f --date=short --no-merges --format='%ad %ae %s'
2016-07-29 msarett Add color space xform support to SkJpegCodec (includes F16!)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2196733002
Cr-Commit-Position: refs/heads/master@{#408642}
Removed unused TrayBarButtonWithTitle class.
BUG=None
Review-Url: https://codereview.chromium.org/2186153002
Cr-Commit-Position: refs/heads/master@{#408641}
[Media Router Contextual Menu] Test 'checked' state of cloud services item.
Add a test to check whether the "Enable cloud services" item is currently checked or not.
BUG=623330
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2190223002
Cr-Commit-Position: refs/heads/master@{#408640}
Enable chrome.certificateProvider API on the login screen
This turns on the chrome.certificateProvider API for the login screen
apps by allowing to create the CertificateProviderService for the signin
profile.
BUG=632728
TEST=manual (install a smart card app on the login screen and go through SAML login with an IdP page that requires the client certificate)
Review-Url: https://codereview.chromium.org/2195533003
Cr-Commit-Position: refs/heads/master@{#408639}
binding: Compiles event handlers only once if not compilable.
Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.
BUG=597900
Review-Url: https://codereview.chromium.org/2190553003
Cr-Commit-Position: refs/heads/master@{#408638}
Move WebAPK <meta-data> to org.chromium.webapk.shell_apk namespace
BUG=631063
Review-Url: https://codereview.chromium.org/2193683003
Cr-Commit-Position: refs/heads/master@{#408637}
Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.
The ManifestUpgradeDetector fetches the latest web manifest for a WebAPK, compare
with cached one and make a decision of whether to request re-mint.
The ManifestUpgradeDetector is initilized for WebApkActivity when it needs to check
resources changes. Once the detector starts, it observes WebContents's change,
and stops when the manifest file of the WebApk is found and fetched. This is
because not all of the urls within the WebAPK's scope link to its manifest file.
Therefore, the detector needs to follow WebContents's change until find
the manifest file.
TEST=org.chromium.chrome.browser.webapps.ManifestUpgradeDetectorTest
BUG=624834
Review-Url: https://codereview.chromium.org/2124513002
Cr-Commit-Position: refs/heads/master@{#408636}
[Android] Remove host_info from chromium.perf.json testing config.
It is run via recipes now since it is suppose to run on every android bot
similar to device_status and device_recovery.
BUG=592140
Review-Url: https://codereview.chromium.org/2193003002
Cr-Commit-Position: refs/heads/master@{#408635}
Roll src/third_party/skia/ 9081ceb12..830c91362 (2 commits).
https://chromium.googlesource.com/skia.git/+log/9081ceb1236d..830c913625ac
$ git log 9081ceb12..830c91362 --date=short --no-merges --format='%ad %ae %s'
2016-07-29 mtklein GN: ccache+clang needs -Qunused-arguments
2016-07-29 mtklein GN: Always quote cc and cxx.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2195553003
Cr-Commit-Position: refs/heads/master@{#408634}
Use MediaRecorder to capture video for quality test.
Retrite the WebRTC video quality test to use the MediaRecorder API
instead of recording from a canvas.
BUG=631458
Review-Url: https://codereview.chromium.org/2183873002
Cr-Commit-Position: refs/heads/master@{#408633}
Unify display ids between Display and PlatformDisplay.
Instead of having an int32_t and int64_t id for each display, unify them
to use a single int64_t id. The int64_t id is the actual display id and
is provided by lower level code, so it makes more sense to keep it.
BUG=625876
Review-Url: https://codereview.chromium.org/2189893004
Cr-Commit-Position: refs/heads/master@{#408632}
Convert Ozone wayland to directly create GLSurfaces.
The Ozone wayland platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.
BUG=611142
Review-Url: https://codereview.chromium.org/2187443003
Cr-Commit-Position: refs/heads/master@{#408631}
arc: Scale notification surface to fit
BUG=632720
BUG=b/30374625
TEST=Manual. Increase resolution and custom notification should always fill
chrome notification space.
Review-Url: https://codereview.chromium.org/2187363002
Cr-Commit-Position: refs/heads/master@{#408630}
Adds a README.md to content/browser/cache_storage/.
BUG=632354
Review-Url: https://codereview.chromium.org/2192823003
Cr-Commit-Position: refs/heads/master@{#408629}
Integration test for minidump paths, adding in wait time to make sure the
browser has been fully loaded before crashing it.
BUG=catapult:#2346
Review-Url: https://codereview.chromium.org/2184263004
Cr-Commit-Position: refs/heads/master@{#408628}
[LevelDBWrapper] Fix an issue that check condition is always true.
item->value.is_null() is always true, should check it.second.is_null() instead.
BUG=
Review-Url: https://codereview.chromium.org/2182993002
Cr-Commit-Position: refs/heads/master@{#408627}
Refactor Timer classes in preparation for landing FrameTimers.
- The original Timer template is now TaskRunnerTimer and requires a
TaskRunner argument.
- A new Timer template implements the behavior of the original Timer
template to avoid breaking a lot of code.
- The timer callback parameter has changed to be a TimerBase*, to make
it easier to share the underlying template implementations. This is a
safe change, because almost all TaskRunnerTimer callbacks don't use
the parameter. The few callbacks that care use it to multiplex
multiple timers in one callback, and only use it for equality
comparisons with subclasses of TimerBase, so there's no problem.
Followup CLs will introduce frame-specific timers (e.g. LoadingTimer)
which will use TaskRunnerTimer as the base template, as well as rename
the new Timer template to DefaultThreadTimer.
BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2191533003
Cr-Commit-Position: refs/heads/master@{#408626}
Roll src/third_party/skia/ 4e41364b1..9081ceb12 (1 commit).
https://chromium.googlesource.com/skia.git/+log/4e41364b1ee4..9081ceb1236d
$ git log 4e41364b1..9081ceb12 --date=short --no-merges --format='%ad %ae %s'
2016-07-29 mtklein GN: use ccache if available and the requested compiler.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2196683002
Cr-Commit-Position: refs/heads/master@{#408625}
DNS: Add stubs for persisting data across restarts
I'm going to start experimenting with making certain data in the DNS
stack (cache, learned RTT, etc.) persist across restarts or network
type changes (e.g. on 2G -> 3G -> 2G, restore the previous 2G RTT
instead of starting over).
This CL adds the basic set of methods that will be called, but does not
add the code to include anything in the persisted data, nor the code to
actually persist the data outside the DNS stack.
BUG=605149
Review-Url: https://codereview.chromium.org/1898033006
Cr-Commit-Position: refs/heads/master@{#408624}
Make instrumented_libraries download script src-independent
This allows to call this script as a hook from other
projects than chromium, e.g. v8.
BUG=chromium:631979
Review-Url: https://codereview.chromium.org/2197603002
Cr-Commit-Position: refs/heads/master@{#408623}
Update V8 to version 5.4.289.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/acd4cea5..b9200bca
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2191263003
Cr-Commit-Position: refs/heads/master@{#408622}
Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission
Changes from the first attempt:
- AwPermissionManager::RequestPermissions() was implemented for
Android WebView in a separate CL.
- Workarounds to avoid touching NOTIMPLEMENTED() was removed
Original description follows:
SystemWebViewShellLayoutTest failed because of the same reason with
other modified tests in this CL. Tests are modified to pass, but now
it does not cover {sysex:true} case that needs
AwPermissionManager::RequestPermissions implementation.
It will be implemented in the next CL soon.
Original description follows:
Web MIDI asked permissions via public/web interfaces.
But now that PermissionService is available in Blink,
use the service to ask permissions.
This migration makes it possible to remove all MIDI
related public/web interfaces.
BUG=582328
Committed: https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc
Cr-Commit-Position: refs/heads/master@{#404136}
TEST=${OUT}/bin/run_system_webview_shell_layout_test_apk # with a built SystemWebViewGoogle.apk
TEST=git cl try
Review-Url: https://codereview.chromium.org/2116763002
Cr-Commit-Position: refs/heads/master@{#408621}
Delete leftover comment in subresource filter rules definitions.
BUG=609747
Review-Url: https://codereview.chromium.org/2194873002
Cr-Commit-Position: refs/heads/master@{#408620}
Enable IO in WebRtcAudioDebugRecordingsBrowserTest
Set base::ThreadRestrictions::SetIOAllowed(),
since the tests need to create a temporary file.
BUG=632685
Review-Url: https://codereview.chromium.org/2193803002
Cr-Commit-Position: refs/heads/master@{#408619}
Stub for ARC print Bridge
All change sets include:
- http://crrev.com/2115863002 (Chromium)
- http://ag/1191589 (Android device/google/cheets2)
- http://ag/1191517 (Android platform/frameworks/base)
BUG=625126
Review-Url: https://codereview.chromium.org/2115863002
Cr-Commit-Position: refs/heads/master@{#408618}
Adds support for headless chrome embedder mojo services
You can now request a HeadlessWebContents be created with one or more embedder
provided mojo services and request js bindings.
We add a BINDINGS_POLICY_HEADLESS which instructs
MojoContextState to use the new headless-mojom:// protocol to
fetch the mojo bindings.
Design doc:
https://docs.google.com/document/d/1Fr6_DJH6OK9rG3-ibMvRPTNnHsAXPk0VzxxiuJDSK3M/edit
More context is available from our BlinkOn presentation
slides: https://docs.google.com/presentation/d/1gqK9F4lGAY3TZudAtdcxzMQNEE7PcuQrGu83No3l0lw/edit#slide=id.g14ebf0ab58_0_0
recording: https://youtu.be/zlNgsoPV3ho?t=6m55s
BUG=546953, 623954
Review-Url: https://codereview.chromium.org/2049363003
Cr-Commit-Position: refs/heads/master@{#408617}
Convert mediasource http tests to testharness.js
Cleaning mediasource http tests to use testharness.js
instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2192713003
Cr-Commit-Position: refs/heads/master@{#408616}
Framework for indexing of subresource filtering rules.
Make the RulesetService capable of receiving and indexing Safe Browsing
subresource filtering rules coming in through the component updater. The wire
format is still TBD, but for now consists of a single rule.
Also, change the directory structure so that both indexed and unindexed rules
are stored under a BASE directory at "$USER_DATA_DIR/Subresource Filter/".
Unindexed rules are now stored under "$BASE/Unindexed Rules/$CONTENT_VERSION/";
and indexed rules under "$BASE/Indexed Rules/$FORMAT_VERSION/$CONTENT_VERSION",
instead of "$BASE/$FORMAT_VERSION_$CONTENT_VERSION".
Furthermore, refactor TestRulesetCreator to facilitate testing by supplying
both the indexed/unindexed representation of the testing rules, and making them
available as files, file paths or blobs.
BUG=609747
Review-Url: https://codereview.chromium.org/2182493009
Cr-Commit-Position: refs/heads/master@{#408615}
predictors: Don't cancel the request when IO is pending.
In resource_prefetch_predictor, when reading the response of a prefetch
request, the request is marked as failed (and aborted) when the status
is IO_PENDING. This is not intended.
BUG=629424
Review-Url: https://codereview.chromium.org/2188253002
Cr-Commit-Position: refs/heads/master@{#408614}
predictors: Support fonts in resource_prefetch_predictors.
BUG=631966
Review-Url: https://codereview.chromium.org/2184323003
Cr-Commit-Position: refs/heads/master@{#408613}
Prevent crash when adding first account.
BUG=630710
Review-Url: https://codereview.chromium.org/2191273002
Cr-Commit-Position: refs/heads/master@{#408612}
Command buffer: feedback loop detection for CopyTexSubImage3D
BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2190543005
Cr-Commit-Position: refs/heads/master@{#408611}
Roll WebRTC 13526:13569
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f82b08f..8af4222
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2193093003
Cr-Commit-Position: refs/heads/master@{#408610}
Add context menu to snippets.
BUG=631939
Review-Url: https://codereview.chromium.org/2186053002
Cr-Commit-Position: refs/heads/master@{#408609}
Update V8 to version 5.4.287.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0b56cb99..acd4cea5
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2190323002
Cr-Commit-Position: refs/heads/master@{#408608}
Rewrite Fetch API referrer layout tests with service worker
BUG=630996
Review-Url: https://codereview.chromium.org/2192743002
Cr-Commit-Position: refs/heads/master@{#408607}
Revert of Comment out some infobar identifiers for obsolete infobars. (patchset #1 id:1 of https://codereview.chromium.org/2189963002/ )
Reason for revert:
Very sorry to revert this, but both READER_MODE_INFOBAR_DELEGATE and UPGRADE_INFOBAR_DELEGATE are still used by Chrome iOS.
Original issue's description:
> Comment out some infobar identifiers for obsolete infobars.
>
> BUG=none
>
> Committed: https://crrev.com/c283644ddac0839170780ef5e3c78798db5b293b
> Cr-Commit-Position: refs/heads/master@{#408454}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2193773002
Cr-Commit-Position: refs/heads/master@{#408606}
NQE: Move ECT to net:: namespace
Move EffectiveConnectionType from NetworkQualityEstimator
class to net:: namespace
Also, move EffectiveConnectionType to a separate file in
//net/nqe/effective_connection_type.h.
[email protected],[email protected]
BUG=631552,631554
Review-Url: https://codereview.chromium.org/2183153002
Cr-Commit-Position: refs/heads/master@{#408605}
On Linux rework driver_version/vendor extraction from gl version
Previously it could not extract them from the gl version
"3.3 (Core Profile) Mesa 10.5.9" because of the presence
of '(Core Profile)'.
BUG=628929
[email protected], [email protected], [email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
Review-Url: https://codereview.chromium.org/2153373002
Cr-Original-Commit-Position: refs/heads/master@{#407804}
Cr-Commit-Position: refs/heads/master@{#408604}
Organize public ComputedStyle methods by property
Organized ComputedStyle public methods by property. This is part of a
larger effort to clean up ComputedStyle and ultimately generate it. Also
added a comment to the top of ComputedStyle explaining the new style, as
well as TODOs to classes used by ComputedStyle to merge their logic into
ComputedStyle.
BUG=628043
Review-Url: https://codereview.chromium.org/2174703002
Cr-Commit-Position: refs/heads/master@{#408603}
Recategorize ARC auth sign in errors.
Currently, many errors are categorized to UNKNOWN_ERROR.
With this CL and client modification, we can assign more precise error code for each case.
BUG=630624
TEST=Trybot.
Review-Url: https://codereview.chromium.org/2173103002
Cr-Commit-Position: refs/heads/master@{#408602}
Skip dirtying lines when attaching children prior to attaching oneself
If a parent is about to be (re)attached then there is no point in keeping its
dirty lines up to date as we attach children. The parent will get a full layout
anyway and we end up having to dirty the lineboxes for every inlines we add - which
can get expensive if there are a lot of inlines.
BUG=345972
Review-Url: https://codereview.chromium.org/1550513003
Cr-Commit-Position: refs/heads/master@{#408601}
NTP, only add the peeking functionality to the first card if there is space
Previously this logic sat in the components themselves which resorted to having the logic in a number of different places - moving this to a central location and setting flags for each component. Relying on the RecyclerView.computeVerticalScrollOffset() was not always accurate and caused issues such as the bug.
BUG=630306
Review-Url: https://codereview.chromium.org/2191833002
Cr-Commit-Position: refs/heads/master@{#408600}
Add other variations (with ids) for NTPSnippets to chrome://flags
This CL allows to specify variation ids for variations defined for
chrome://flags. The CL also extends the list of variations for the
NTPSnippets feature (some of the variations specify a variation id).
This issue also updates the iOS code to achieve feature parity w.r.t. issues 2036193002 and 2129543002.
BUG=631442
Review-Url: https://codereview.chromium.org/2182553002
Cr-Commit-Position: refs/heads/master@{#408599}
Automated Commit: Committing new LKGM version 8648.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#408598}
Roll src/third_party/catapult/ 969b3e59b..3c3afa500 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/969b3e59b41f..3c3afa500fca
$ git log 969b3e59b..3c3afa500 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2190303002
Cr-Commit-Position: refs/heads/master@{#408597}
command buffer: cleanup for cmds namespace
We have used cmds namespace in these files. As a result, "cmds::" prefix is not necessary.
Most users don't use "cmds::" prefix in these files. So remove the others to keep conformant.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2193733002
Cr-Commit-Position: refs/heads/master@{#408596}
Cleanup some context estimation code in command buffer
Use the wrapped function instead of separate statements.
BUG=429053
TEST=No functional changes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2196563002
Cr-Commit-Position: refs/heads/master@{#408595}
Stop TextCheckingHelper from checking grammar
This patch removes grammar checking related code from TextCheckingHelper
because Chromium and Blink do not support grammar checking. The related
public member functions still keep the same signatures but no longer
perform any grammar checking or return any grammar mistake.
TextCheckerClient::checkGrammarOfString() is also removed since it is
only used by TextCheckingHelper.
BUG=619452
TEST=n/a; no visible behavior change
Review-Url: https://codereview.chromium.org/2190293002
Cr-Commit-Position: refs/heads/master@{#408594}
Switch on use_new_wrapper_types mode for content/shell and content/test.
BUG=624136
[email protected]
Review-Url: https://codereview.chromium.org/2185703003
Cr-Commit-Position: refs/heads/master@{#408593}
[Fetch API] Introduce BytesConsumer
This CL introduces BytesConsumer interface which is expected to replace most of
WebDataConsumerHandle subclasses. Unlike WebDataConsumerHandle, BytesConsumer
is bound to a thread and an on-heap interface.
This CL also implements a bridge class from FetchDataConsumerHandle to
BytesConsumer. As it is not yet used, this CL doesn't change the actual
behavior.
BUG=610195
Review-Url: https://codereview.chromium.org/2046203003
Cr-Commit-Position: refs/heads/master@{#408592}
[DevTools] implement isSpaceOrNewline for the STL string wrapper.
We now use std::isspace, which is not equivalent to the WTF
implementation. But it is consistent with the STL version of
String16::stripWhiteSpace.
With this, the inspector protocol parser test succeeds in the
V8 standalone build that uses the STL string wrapper.
[email protected]
BUG=580337
Review-Url: https://codereview.chromium.org/2188203002
Cr-Commit-Position: refs/heads/master@{#408591}
Fix official win-asan build to be an x86 build, not an x64 build.
Since x64 doesn't work :). This was a mistake caused when I flipped
the builder from GYP to GN but forgot to specify the architecture
(and the default is different between the two).
[email protected]
BUG=632563
Review-Url: https://codereview.chromium.org/2196623002
Cr-Commit-Position: refs/heads/master@{#408590}
Remove AccessControlLoggingDecision enum from ResourceFetcher::canAccessResource
Callers always set it to ShouldLogAccessControlErrors
BUG=
Review-Url: https://codereview.chromium.org/2193603002
Cr-Commit-Position: refs/heads/master@{#408589}
Call FetchContext::dispatchWillSendRequest() only if an actual load is started
Fixing a regression since [1].
[1] https://codereview.chromium.org/1889973002/
Since [1], FetchContext::dispatchWillSendRequest() was called from
ResourceFetcher::willSendRequest() in the middle of
ResourceFetcher::requestResource(), and might have modified
Resource::m_resourceRequest.
However, if the actual loading is deferred, e.g. when FontResource is not
used, FetchContext::dispatchWillSendRequest() was called without actual
loading, causing stale pending load reports in DevTools.
This CL
- Moves the ResourceFetcher::willSendRequest() call in requestResource() to
ResourceFetcher::startLoad().
Now FetchContext::dispatchWillSendRequest() (called from startLoad())
modifies the local ResourceRequest in startLoad(), not modifying
ResourceRequest::m_resourceRequest (which is the behavior before [1]).
- Moves setAllowStoredCredentials() call in ResourceFetcher::willSendRequest()
to its callsites, because this should be done even when the actual loading
is deferred and should modify Resource::m_resourceRequest.
- Adds a layout test.
BUG=623616, 632580
Review-Url: https://codereview.chromium.org/2184823006
Cr-Commit-Position: refs/heads/master@{#408588}
Use TranslateManager::GetTargetLanguage() for context menu
BUG=632545
Review-Url: https://codereview.chromium.org/2189283002
Cr-Commit-Position: refs/heads/master@{#408587}
MD History: Fix clicking on synced tab links
A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.
BUG=632265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2195593002
Cr-Commit-Position: refs/heads/master@{#408586}
Flip all but ios-simulator builders to GN.
This affects:
- tryserver.chromium.mac:
- ios-device
- ios-simulator-cronet
- chromium.mac
- ios-device
- chromium.fyi
- ClangToTiOS
- EarlGreyiOS
This CL also flips the ios-device-gn builder to use the xcode version
of Clang so that we can get some coverage of that configuration.
The ios-simulator builder will remain on GYP until we drop GYP support.
[email protected], [email protected]
BUG=621708
Review-Url: https://codereview.chromium.org/2194703002
Cr-Commit-Position: refs/heads/master@{#408585}
Treat underscores as part of word when searching for prev/next word
ICU treats underscores as part of word, but Blink's adaptation layer does
not, which is fixed in this patch.
BUG=447339
TESTS=LayoutTests/editing/selection/modify_move/move_by_word_with_underscore.html
Review-Url: https://codereview.chromium.org/2192763002
Cr-Commit-Position: refs/heads/master@{#408584}
Roll src/third_party/catapult/ c880a714d..969b3e59b (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c880a714d6b1..969b3e59b41f
$ git log c880a714d..969b3e59b --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2189313002
Cr-Commit-Position: refs/heads/master@{#408583}
Move DOMConvenienceAPI to stable.
Move ChildNode.{before,after,replaceWith}() +
ParentNode.{prepend,append}() to stable.
R=
BUG=255482
Review-Url: https://codereview.chromium.org/2184223004
Cr-Commit-Position: refs/heads/master@{#408582}
V4L2VDA: Move allocation from GPU Child thread to decoder thread.
Allocation may take time, and we don't need to be on the GPU Child
thread to do it. This also removes the explicit synchronization between
the decoder and GPU Child threads during resolution change.
BUG=574241
TEST=Run VDA test and play video on oak.
Review-Url: https://codereview.chromium.org/2078913002
Cr-Commit-Position: refs/heads/master@{#408581}
Remove OutputSurfaceClient external clip
All use cases of OutputSurfaceClient::OnDraw pass the exact same value
for external viewport and clip, so remove the redundancy.
Also take this opporunity to clean up the sync compositor hardware draw
IPC. A bunch of params are no longer needed.
BUG=631276
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2188943002
Cr-Commit-Position: refs/heads/master@{#408580}
Remove |TouchEvent.initTouchEvent()| in M54
|TouchEvent.initTouchEvent()| is not standardized and not interoperate
with Firefox or Safari. Developers should be encouraged to use the new
TouchEvent constructor instead.
|initTouchEvent()| was deprecated in M49, and this CL removes it
in M54 (deferred from M53).
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs
Chrome Status Entry:
https://www.chromestatus.com/features/5730982598541312
TBR=timvolodine
BUG=522100
Review-Url: https://codereview.chromium.org/2182183003
Cr-Commit-Position: refs/heads/master@{#408579}
MD Settings: made proxy button respect policy
[email protected]
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2180393002
Cr-Commit-Position: refs/heads/master@{#408578}
[libFuzzer][AFL] Change target function so that IsQuote(),
AdvanceOne(), and other other code can be exercised.
BUG=539572
Review-Url: https://codereview.chromium.org/2186553005
Cr-Commit-Position: refs/heads/master@{#408577}
Fail write_build_config.py if current_toolchain != default_toolchain
There are a few spots in the Android templates that assume appending
__build_config to a given target label will result in the label for a
write_build_config action. When toolchains exist in a label, appending
like this doesn't work. E.g.: :some_label(//toolchain)__build_config
Previously, we added a GN assert to enforce default toolchain, but that
was too strict, as it made it so no other targets that are defined in
the same BUILD.gn file could use a non-default toolchain.
This change make the error a build-time error rather than a gn gen
error.
BUG=629371
Review-Url: https://codereview.chromium.org/2161063003
Cr-Commit-Position: refs/heads/master@{#408576}
[DevTools] Add "Disable JavaScript" into command menu
BUG=619889
[email protected]
Review-Url: https://codereview.chromium.org/2194753002
Cr-Commit-Position: refs/heads/master@{#408575}
Remove AnimationTimeline pre-finalizer
Now that Animations have their own pre-finalizers to clean up their
CompositorAnimationPlayers there's no need for AnimationTimeline to
dispose of them.
Review-Url: https://codereview.chromium.org/2188993004
Cr-Commit-Position: refs/heads/master@{#408574}
ServiceWorker: Unregister SW after finishing activation.html
Calling registration.unregister instead of returning
registration.unregister
BUG=632256
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Release http/tests/serviceworker/activation.html
Review-Url: https://codereview.chromium.org/2190853003
Cr-Commit-Position: refs/heads/master@{#408573}
MD History: Show sidebar next to content on wide screens
This ensures that the sidebar is always visible when the screen has
enough space, and hides it within a drawer otherwise. To achieve this,
we split <history-side-bar> apart so that it is no longer responsible
for the drawer. We also add extra capabilities to <cr-toolbar> to
support hiding the menu button and adjusting the margins.
These changes break the focus trapping inside the drawer (which already
didn't work in certain situations). This will be addressed in a follow-up.
BUG=608968
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2165903003
Cr-Commit-Position: refs/heads/master@{#408572}
Add instead of plain space when it is inserted before the empty text node
This CL fixes the regression that space key doesn't work in the gmail
chat window.
BUG=632300
TEST=editing/inserting/insert-space.html
Review-Url: https://codereview.chromium.org/2191163002
Cr-Commit-Position: refs/heads/master@{#408571}
[Autofill] Switch on use_new_wrapper_types mode.
This CL also adds a custom typemap for base::string16:
"mojo.common.mojom.String16=base::string16"
BUG=624136
Review-Url: https://codereview.chromium.org/2180093002
Cr-Commit-Position: refs/heads/master@{#408570}
Handle removed display items in under-invalidation checking in cached subsequences
When we see a mismatched display item when checking under-invalidation
in a cached subsequence, if the item might be removed later, we
temporarily skip the display item and look forward.
- If the item is finally removed, the mismatch will be ignored;
- If the item is not removed, report the mismatch as under-invalidation.
Also added unit tests for under-invalidation.
BUG=619103
Review-Url: https://codereview.chromium.org/2184363002
Cr-Commit-Position: refs/heads/master@{#408569}
Roll src/third_party/skia/ 39979d8c6..4e41364b1 (1 commit).
https://chromium.googlesource.com/skia.git/+log/39979d8c6b97..4e41364b1ee4
$ git log 39979d8c6..4e41364b1 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 mtklein Add another GM to skip in serialize mode.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2190263002
Cr-Commit-Position: refs/heads/master@{#408568}
[DevTools] Remove V8ContentSearchUtil.
BUG=580337
TBR=pfeldman
Review-Url: https://codereview.chromium.org/2182423002
Cr-Commit-Position: refs/heads/master@{#408567}
Tidy up of TabPersistentStore's clean-up logic
* Clean files on every activity start rather than just the first
* Don't delete files owned by other TabModels
* Don't delete icons used by other TabModels
* Adds test for incognito tab files being removed appropraitely
BUG=626629
Review-Url: https://codereview.chromium.org/2143203002
Cr-Commit-Position: refs/heads/master@{#408566}
Updating trunk VERSION from 2811.0 to 2812.0
Cr-Commit-Position: refs/heads/master@{#408565}
Disable compositing/overflow/text-match-highlight, overflow-scroll-body-appear, invalidation-after-opacity-change-subtree on Win
They've been flaky after the last rebaseline for r407755
BUG=632548
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2191223002
Cr-Commit-Position: refs/heads/master@{#408564}
Disable fast/images/paint-subrect-grid.html more widely on Win
Flakes on more than just debug.
Link https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/44524
BUG=632000
TBR=xidachen
NOTRY=true
Review-Url: https://codereview.chromium.org/2197473002
Cr-Commit-Position: refs/heads/master@{#408563}
[worklets] Change paintWorklet method to non-const to remove mutable member.
Similar change occurred for WindowAnimationWorklet.
BUG=567358
Review-Url: https://codereview.chromium.org/2193103002
Cr-Commit-Position: refs/heads/master@{#408562}
Add crash keys for ServiceWorkerDispatcherHost crashes
BUG=619294,630495,630496
Review-Url: https://codereview.chromium.org/2190513002
Cr-Commit-Position: refs/heads/master@{#408561}
DevTools: measure should not destroy elements hierarchy.
BUG=631890
Review-Url: https://codereview.chromium.org/2190213002
Cr-Commit-Position: refs/heads/master@{#408560}
Roll src/third_party/catapult/ 9902cd872..c880a714d (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9902cd872fed..c880a714d6b1
$ git log 9902cd872..c880a714d --date=short --no-merges --format='%ad %ae %s'
BUG=623989
[email protected]
Review-Url: https://codereview.chromium.org/2189273002
Cr-Commit-Position: refs/heads/master@{#408559}
Rename CalledOnValidSequencedThread() to CalledOnValidSequence().
The new name is more accurate (we don't verify that we're on a
specific thread) and shorter.
Discussion here:
https://codereview.chromium.org/2165663003/diff/260001/base/sequence_checker.h#newcode25
[email protected]
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2189113002
Cr-Commit-Position: refs/heads/master@{#408558}
Revert of aw: Fix FactoryProvider threading (patchset #3 id:40001 of https://codereview.chromium.org/2180423003/ )
Reason for revert:
Broke correct usage: crbug.com/632547
BUG=632547
Original issue's description:
> aw: Fix FactoryProvider threading
>
> Access thread-unsafe chromium classes on the UI thread only
>
> BUG=630709
>
> Committed: https://crrev.com/993fff8648f2701910b9efdbf1d35244fbf8ca73
> Cr-Commit-Position: refs/heads/master@{#408432}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630709
Review-Url: https://codereview.chromium.org/2197433002
Cr-Commit-Position: refs/heads/master@{#408557}
Roll src/third_party/skia/ ecf3dbe8f..39979d8c6 (1 commit).
https://chromium.googlesource.com/skia.git/+log/ecf3dbe8f298..39979d8c6b97
$ git log ecf3dbe8f..39979d8c6 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 msarett Revert of Add color space xform support to SkJpegCodec (includes F16!) (patchset #9 id:260001 of https://codereview.chromium.org/2174493002/ )
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2196533002
Cr-Commit-Position: refs/heads/master@{#408556}
Fix ApplicationStatus.isEveryActivityDestroyed() = false within callbacks
isEveryActivityDestroyed was not being updated until after callbacks
were called, so querying it from within a callback would always return
false.
There is currently only one use of this function within a callback:
ChromeApplication.onForegroundActivityDestroyed()
This change fixes isEveryActivityDestroyed(), and also updates
onForegroundActivityDestroyed() so that it doesn't do bad things. Namely:
1) DevTools server shouldn't ever be taken down once it's been initialized in
initializeSharedClasses(), which is only called once and would cause the
DevTools server to never start up again.
2) stopApplicationActivityTracker() would require another call to
startApplicationActivityTracker() once an activity is again created. However,
the only call to it is within initializeSharedClasses(), which happens only during
cold start.
3) CombinedPolicyProvider.get().destroy() actually led me to a separate bug:
https://codereview.chromium.org/2184203004/
BUG=632042
Review-Url: https://codereview.chromium.org/2188723003
Cr-Commit-Position: refs/heads/master@{#408555}
Add pre finalizer to Animation to ensure compositor handles get cleaned up
BUG=631052
Review-Url: https://codereview.chromium.org/2188623006
Cr-Commit-Position: refs/heads/master@{#408554}
Fix CrSettingsPrivacyPageTest.PrivacyPage test failure.
Also convert one more occurrence of iron-overlay-closed to close in site_settings/.
BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2193073002
Cr-Commit-Position: refs/heads/master@{#408553}
Use enum to track state of DXVAPictureBuffers.
DXVAPictureBuffers currently use multiple booleans to specify what
state they're in. Switch to using a single enum to simplify the
logic and add DCHECKs to ensure we don't have invalid state
transitions.
Review-Url: https://codereview.chromium.org/2135773002
Cr-Commit-Position: refs/heads/master@{#408552}
Use ChildThreadImpl::thread_safe_sender in font proxy if available
This changes the logic that the font proxy uses to get the IPC
sender. It will now try to get a sender in the initialization code,
and use that one if available. This allows it to get the sender
while it is still running on the main thread in the plugin, so that
it can use it for IPCs later when called from a different thread.
This is a threading violation, but it will allow the proxy to work
when called by Flash from a background thread.
BUG=631254
Review-Url: https://codereview.chromium.org/2182213004
Cr-Commit-Position: refs/heads/master@{#408551}
[chromedriver] Load automation extension as a component extension on Windows.
BUG=
[email protected]
Review-Url: https://codereview.chromium.org/2191173002
Cr-Commit-Position: refs/heads/master@{#408550}
Add LC_ALL=C to gcc linker wrappers to speed up links
This speeds up an Android component build of libchrome.cr.so from
35s -> 10s on my z620.
BUG=632230
Review-Url: https://codereview.chromium.org/2190813002
Cr-Commit-Position: refs/heads/master@{#408549}
Add loading-reviews@ to core/html/parser watchlist.
BUG=
Review-Url: https://codereview.chromium.org/2192933002
Cr-Commit-Position: refs/heads/master@{#408548}
Fix SyzyASAN builders to be release GN builds, not debug.
Also, turn off goma and add no_pch on the trybot.
[email protected]
BUG=605318
Review-Url: https://codereview.chromium.org/2196503002
Cr-Commit-Position: refs/heads/master@{#408547}
Roll src/third_party/catapult/ c0ce8d0ba..9902cd872 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c0ce8d0bab97..9902cd872fed
$ git log c0ce8d0ba..9902cd872 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2193713002
Cr-Commit-Position: refs/heads/master@{#408546}
[DevTools] Show stack for console.warn messages
BUG=605932
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2189223002
Cr-Commit-Position: refs/heads/master@{#408545}
Correcting the CLD3 LICENSE file
BUG=624904
Review-Url: https://codereview.chromium.org/2181803002
Cr-Commit-Position: refs/heads/master@{#408544}
Always fallback to checking bitmaps during under-invalidation checking
There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.
Always fallback to checking bitmaps to avoid such false-positives.
This won't degrade performance because normally the pictures should
equal.
Also changed bitmap comparison to a more stable version and make the
result more readable.
BUG=619603
Review-Url: https://codereview.chromium.org/2184053003
Cr-Commit-Position: refs/heads/master@{#408543}
gpu: Remove more glClear calls with gl_clear_broken
BUG=612474
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2180963003
Cr-Commit-Position: refs/heads/master@{#408542}
Remove hasGrammarMarker from internals
BUG=619452
TEST=n/a; no behavior change
Review-Url: https://codereview.chromium.org/2191803002
Cr-Commit-Position: refs/heads/master@{#408541}
Roll src/third_party/skia/ dc90b5335..ecf3dbe8f (4 commits).
https://chromium.googlesource.com/skia.git/+log/dc90b53350b9..ecf3dbe8f298
$ git log dc90b5335..ecf3dbe8f --date=short --no-merges --format='%ad %ae %s'
2016-07-28 robertphillips Remove use of MakeRenderTargetDirect from view system
2016-07-28 benjaminwagner Update public.bzl based on internal cl/128616707.
2016-07-28 msarett Add color space xform support to SkJpegCodec (includes F16!)
2016-07-28 mtklein Make coverage.py optional for dm and nanobench _flags.py
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2193693002
Cr-Commit-Position: refs/heads/master@{#408540}
Remove HTMLImportsController::loaderDocumentAt()
No one calls this function and remove it.
Review-Url: https://codereview.chromium.org/2192793003
Cr-Commit-Position: refs/heads/master@{#408539}
Fix some generated test certs having same issuer name & serial.
BUG=none
Review-Url: https://codereview.chromium.org/2192493004
Cr-Commit-Position: refs/heads/master@{#408538}
ParseHTMLOnMainThread: notify main thread of chunks less frequently
This patch adds an experiment variant to the
ParseHTMLOnMainThread experiment threaded group. It adds
a group that uses the threaded parser, but coalesces token
chunks in the background parser, notifying the main thread
less often. This can often result in issuing preloads faster
due to not eagerly parsing/scripting when tokens are about to
come in.
Note: this experiment group actually aligns the threaded behavior
closer to the non-threaded behavior. The non-threaded experiment
group also runs the entirety of pumpTokenizer when it is tokenizing,
whereas the threaded parser usually starts parsing at the first call to
notifyPendingTokenizedChunks (if it is idle). This is usually very early
on in pumpTokenizer, because we split up chunks very fine grained.
This experiment group tries not to start the main thread parsing until
we've tokenized a bit more.
[email protected]
BUG=632394
Review-Url: https://codereview.chromium.org/2065163005
Cr-Commit-Position: refs/heads/master@{#408537}
Remove old LinkPreconnect flag from predictor browsertests
BUG=
Review-Url: https://codereview.chromium.org/2189783006
Cr-Commit-Position: refs/heads/master@{#408536}
exo: Convert initial bounds to screen coordinates
Since the initial bounds of a ShellSurface were relative to the root
window, pop-up windows (e.g. context menus in weston-terminal) whose
parents are on a secondary display would appear on the primary display.
BUG=631136
TEST=Drag weston-terminal to secondary display and right-click.
TEST=ARC apps can still be dragged and maximized.
Review-Url: https://codereview.chromium.org/2175373003
Cr-Commit-Position: refs/heads/master@{#408535}
Makes an expensive CTLogVerifier test into a value-parameterized test
As recommended by Ryan Sleevi in https://codereview.chromium.org/2178153003/,
this turns one test case with nested loops into a value-parameterized test.
This avoids having a single test case that runs for ~13s in exchange for
128 test cases which each take ~1-350ms each (proportional to the tree size). It reduces the chance of the test case
timing out, but increases the overall test duration by ~3s.
BUG=598406
Review-Url: https://codereview.chromium.org/2187043004
Cr-Commit-Position: refs/heads/master@{#408534}
Revert of cc : Use screen space transform for computing translation (patchset #3 id:40001 of https://codereview.chromium.org/2187403002/ )
Reason for revert:
Causes ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate to fail on linux debug
links:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/56008
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)/builds/31557
errors like
ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate (run #1):
[ RUN ] ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate
[1:1:0728/152609:FATAL:property_tree.cc(181)] Check failed: transform->IsApproximatelyIdentityOrTranslation(SkDoubleToMScalar(1e-4)).
..
#2 0x7f99d9f73a0d cc::TransformTree::ComputeTranslation()
#3 0x7f99d9f74189 cc::TransformTree::UpdateLocalTransform()
#4 0x7f99d9f73ece cc::TransformTree::UpdateTransforms()
#5 0x7f99d9fa0ce0 cc::(anonymous namespace)::AddTransformNodeIfNeeded<>()
#6 0x7f99d9f9e98d cc::(anonymous namespace)::BuildPropertyTreesInternal<>()
Original issue's description:
> cc : Use screen space transform computing translation
>
> Since flattenning won't effect the result,
> TransformTree::ComputeTranslation can use screen space transform instead
> of calling ComputeTransforms.
>
> BUG=622372
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/b7a8f7678a999ba33e509e918e8e339956e3d150
> Cr-Commit-Position: refs/heads/master@{#408462}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622372
Review-Url: https://codereview.chromium.org/2188413002
Cr-Commit-Position: refs/heads/master@{#408533}
Revert of Replaced BackgroundAnimator with ShelfBackgroundAnimator. (patchset #19 id:360001 of https://codereview.chromium.org/2053113002/ )
Reason for revert:
Many ASAN failures in ash_unittests and others on ChromeOS builders
link: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/14853
errors like
==3029==ERROR: AddressSanitizer: heap-use-after-free on address 0x6030000b9800 at pc 0x0000127a38fa bp 0x7fff10ad4a50 sp 0x7fff10ad4a48
READ of size 8 at 0x6030000b9800 thread T0
#0 0x127a38f9 in __find<__gnu_cxx::__normal_iterator<ash::ShelfBackgroundAnimatorObserver **, std::vector<ash::ShelfBackgroundAnimatorObserver *, std::allocator<ash::ShelfBackgroundAnimatorObserver *> > >, ash::ShelfBackgroundAnimatorObserver *> ../../include/c++/4.6/bits/stl_algo.h:190:8
#1 0x127a38f9 in find<__gnu_cxx::__normal_iterator<ash::ShelfBackgroundAnimatorObserver **, std::vector<ash::ShelfBackgroundAnimatorObserver *, std::allocator<ash::ShelfBackgroundAnimatorObserver *> > >, ash::ShelfBackgroundAnimatorObserver *> ../../include/c++/4.6/bits/stl_algo.h:4402
#2 0x127a38f9 in base::ObserverListBase<ash::ShelfBackgroundAnimatorObserver>::RemoveObserver(ash::ShelfBackgroundAnimatorObserver*) base/observer_list.h:174
#3 0x127033f2 in ash::ShelfView::~ShelfView() ash/shelf/shelf_view.cc:408:27
#4 0x12703a5d in ash::ShelfView::~ShelfView() ash/shelf/shelf_view.cc:404:25
#5 0xcf2b9f1 in views::View::~View() ui/views/view.cc:134:7
#6 0x127191a4 in ~DelegateView ash/shelf/shelf_widget.cc:407:44
#7 0x127191a4 in non-virtual thunk to ash::ShelfWidget::DelegateView::~DelegateView() ash/shelf/shelf_widget.cc:407
#8 0xcf2dd8d in operator() ../../include/c++/4.6/bits/unique_ptr.h:63:2
#9 0xcf2dd8d in reset ../../include/c++/4.6/bits/unique_ptr.h:245
#10 0xcf2dd8d in ~unique_ptr ../../include/c++/4.6/bits/unique_ptr.h:169
#11 0xcf2dd8d in views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) ui/views/view.cc:1847
...
0x6030000b9800 is located 0 bytes inside of 32-byte region [0x6030000b9800,0x6030000b9820)
freed by thread T0 here:
#0 0xa83edb in operator delete(void*) (/b/swarm_slave/w/ireuBjON/out/Release/unit_tests+0xa83edb)
#1 0x127a2c17 in deallocate ../../include/c++/4.6/ext/new_allocator.h:98:9
#2 0x127a2c17 in _M_deallocate ../../include/c++/4.6/bits/stl_vector.h:156
#3 0x127a2c17 in ~_Vector_base ../../include/c++/4.6/bits/stl_vector.h:142
#4 0x127a2c17 in ~vector ../../include/c++/4.6/bits/stl_vector.h:351
#5 0x127a2c17 in ~ObserverListBase base/observer_list.h:69
#6 0x127a2c17 in ~ObserverList base/observer_list.h:229
#7 0x127a2c17 in ash::ShelfBackgroundAnimator::~ShelfBackgroundAnimator() ash/common/shelf/shelf_background_animator.cc:37
Original issue's description:
> Apply Shelf/Dock opacity animations for the Material Design style.
>
> The Shelf animates between the 3 ShelfBackgroundType's using 2
> different animations; one uses BackgroundAnimator timers and
> View::OnPaint() and the other uses a Layer to animate the
> SHELF_BACKGROUND_MAXIMIZED opaque background.
>
> This change centralizes the animation logic so they all stay in sync
> and applies the opacity animations to the material design style
> Shelf/Dock.
>
> Eventually the ShelfBackgroundAnimator will be enhanced to animate
> between colors instead of just alpha values.
>
> Follow-up plans:
> - Use a single instance of the ShelfBackgroundAnimator.
> - Remove the |opaque_background_| from ShelfWidget and
> DockedBackgroundWidget.
> - Collapse the multiple BackgroundAnimators owned by the
> ShelfBackgroundAnimator into a single SlideAnimation.
> - Animate the MD AppList and Overflow buttons.
>
> BUG=607037
>
> TEST=ShelfBackgroundAnimator(NonMD|MD)Test.*
>
> Committed: https://crrev.com/f34d76ca0084f12c0d01f18bd9549e300b8d2ada
> Cr-Commit-Position: refs/heads/master@{#408390}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607037
Review-Url: https://codereview.chromium.org/2191153002
Cr-Commit-Position: refs/heads/master@{#408532}
[ios] Implemented redirect EG tests for web shell.
BUG=612957
Review-Url: https://codereview.chromium.org/2190153002
Cr-Commit-Position: refs/heads/master@{#408531}
Expose a WasLaunchedRecently method using the app banner content setting.
The app banner system records a DID_ADD_TO_HOMESCREEN event every time:
a) a user adds a site to homescreen via an app banner
b) a user adds a site to homescreen via the add to homescreen overflow
menu item
c) the user launches a site from homescreen
This CL adds AppBannerSettingsHelper::WasLaunchedRecently, which returns
true if there is any site under a supplied origin which has been added
to or launched from homescreen in the last 10 days. This mirrors the
Java-side heuristic used to determine if notification deep-linking
should take effect.
A future CL will look to combine the Java and C++ side heuristics so
that the timestamp data is stored in one location that is accessible to
both.
BUG=631305
Review-Url: https://codereview.chromium.org/2185453003
Cr-Commit-Position: refs/heads/master@{#408530}
Remove extraneous frameView->setNeedsLayout() in LayoutPart
This CL is one step towards having saner pixel snapping for sub-frames.
The goal is to remove dependencies to roundedIntRect, which is conceptually
incorrect and is inconsistent with other part of our code base.
The setNeedsLayout is extraneous because LayoutPart is not supposed to know
whether the sub-frame actually changed its layout size, and the FrameView is
responsible for scheduling layout if it decided to mutate layout size.
Review-Url: https://codereview.chromium.org/2188483004
Cr-Commit-Position: refs/heads/master@{#408529}
sync compositor: Reduce begin frame sync IPC overhead
By making the begin frame sync IPC per renderer process rather than
per compositor.
Convert SyncCompositorMsg_SynchronizeRendererState
to a control message, with a list of routing_ids as input, and a list of
SyncCompositorCommonRendererParams as output.
Introduce SynchronousCompositorRPHObserver which is tied to the
lifetime of the RenderProcessHost, which is the browser side handler of
control messages. SynchronousCompositorFilter serves as the renderer
side control message handler.
SynchronousCompositorRPHObserver adds itself as a vsync observer
for the duration of a single vsync. Then its OnVSync callback is called
after SynchronousCompositorHosts, where the single synchronous
IPC is sent.
BUG=596235
Review-Url: https://codereview.chromium.org/2160743002
Cr-Commit-Position: refs/heads/master@{#408528}
Fix asserts when updating shouldPaint for floating objects.
The assert would trigger when loading fast/overflow/overflow-float-stacking.html if
--enable-prefer-compositing-to-lcd-text was true, because
LayoutBlockFlow::setAncestorShouldPaintFloatingObject asserted that the floating
object is not self-painting. But that method could be called when transitioning
from not-self-painting to self-painting, so the assert appears bogus.
Review-Url: https://codereview.chromium.org/2191953002
Cr-Commit-Position: refs/heads/master@{#408527}
Fix GYP isolates for sync_unit_tests after r408497.
[email protected]
TBR=jam
NOTRY=true
NOTREECHECKS=true
BUG=626114
Review-Url: https://codereview.chromium.org/2191133002
Cr-Commit-Position: refs/heads/master@{#408526}
Clean up DevTools API docs following removal of old APIs
- remove docs for chrome.experimental.devtools.console
- remove docs and sample for preprocessorScript option of
chrome.devtools.inspectedWindow.reload()
BUG=602063
Review-Url: https://codereview.chromium.org/2179673002
Cr-Commit-Position: refs/heads/master@{#408525}
Roll src/third_party/catapult/ 08228c24d..c0ce8d0ba (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/08228c24dda4..c0ce8d0bab97
$ git log 08228c24d..c0ce8d0ba --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2190173002
Cr-Commit-Position: refs/heads/master@{#408524}
Reenable start_with_ext tests.
BUG=563424
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2188273002
Cr-Commit-Position: refs/heads/master@{#408523}
[android] Correct the URL scheme colors in the Omnibox.
Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.
BUG=626646
Review-Url: https://codereview.chromium.org/2176853002
Cr-Commit-Position: refs/heads/master@{#408522}
Temporarily dump without crashing when setting an empty PageState.
This will help track down the cause of crashes in NavigateInternal.
BUG=568703
TEST=Receive crash reports.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2191563004
Cr-Commit-Position: refs/heads/master@{#408521}
Fix visible position calculation in accessible setSelection
The accessible setSelection function is similar to the equivalent APIs to
create a range and set the selection in the DOM, except that offsets are
all visible positions, since the accessibility tree uses visible text
(with whitespace collapsed, for example).
The code that created a VisiblePosition from a text node and offset was
incorrect if the text node had a previous sibling. Fix it so that the
offset of the text node within its container is taken into account.
BUG=626385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2164813003
Cr-Commit-Position: refs/heads/master@{#408520}
DevTools: remove rarely used raii instrumentation classes.
Review-Url: https://codereview.chromium.org/2189793003
Cr-Commit-Position: refs/heads/master@{#408519}
Set up a LayerTree class to split the LayerTreeHost.
The LayerTree class is the main thread counter-part to the LayerTreeImpl, which
will own the root layer and other tree state. Data and functionality will be
incrementally moved to this class as we eliminate dependencies of internal cc
class and the embedder to LayerTree from the host.
This patch moves the Registration/Unregistration logic for maintaining a map of
layers tied to a host and tracking of dirty layers that need to push properties
in the next commit, to the LayerTree.
BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2159513003
Cr-Commit-Position: refs/heads/master@{#408518}
Use inline text accessors for better code readability.
Review-Url: https://codereview.chromium.org/2166663002
Cr-Commit-Position: refs/heads/master@{#408517}
Roll src/native_client/ a07450d16..5e296cb47 (1 commit).
https://chromium.googlesource.com/native_client/src/native_client.git/+log/a07450d163bf..5e296cb4749c
$ git log a07450d16..5e296cb47 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 dpranke Reland of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (patchset #1 id:1 of https://codereview.chromium.org/2188303002/ )
BUG=621686
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
[email protected]
Review-Url: https://codereview.chromium.org/2192863003
Cr-Commit-Position: refs/heads/master@{#408516}
Explicitly call SequenceToken's default constructor.
This CL is to workaround a clang bug occurring when building
sequence_token_unittest.cc for Chrome iOS.
BUG=632330
Review-Url: https://codereview.chromium.org/2184353003
Cr-Commit-Position: refs/heads/master@{#408515}
Roll src/third_party/skia/ 4d516a690..dc90b5335 (5 commits).
https://chromium.googlesource.com/skia.git/+log/4d516a6903d8..dc90b53350b9
$ git log 4d516a690..dc90b5335 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 mtklein Silence -Wclobbered in each file that needs it.
2016-07-28 halcanary SkPDF: drawText makes use of SkPaint.measureText() for alignment.
2016-07-28 reed turn bitmaps into images during recording
2016-07-28 mtklein GN: nanobench
2016-07-28 mtklein Revert of Silence -Wclobbered in each file that needs it. (patchset #2 id:20001 of https://codereview.chromium.org/2184823009/ )
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2195463002
Cr-Commit-Position: refs/heads/master@{#408514}
MD Settings: Fix runtime error when visiting "manage passwords" page.
BUG=632432
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2188063003
Cr-Commit-Position: refs/heads/master@{#408513}
Remove a testing line in update-w3c-test-expectations
Review-Url: https://codereview.chromium.org/2194593002
Cr-Commit-Position: refs/heads/master@{#408512}
Offline pages using NQE 2G Slow
This allows use of the offline pages feature when on a prohibitively slow network. This feature is behind a
FieldTrial.
BUG=615563
Review-Url: https://codereview.chromium.org/2166363003
Cr-Commit-Position: refs/heads/master@{#408511}
Reland of mote-debugging-port for guest sessions. (patchset #1 id:1 of https://codereview.chromium.org/2189503002/ )
Reason for revert:
Problem is still happening, so this isn't responsible.
Original issue's description:
> Revert of remote-debugging-port for guest sessions. (patchset #1 id:1 of https://codereview.chromium.org/2141303003/ )
>
> Reason for revert:
> Speculative revert for crbug.com/631640
>
> BUG=631640
>
> Original issue's description:
> > remote-debugging-port for guest sessions.
> >
> > --remote-debugging-port flag is lost when guest sessions are started on
> > chromeos.
> >
> > BUG=None
> >
> > Committed: https://crrev.com/7268c3d1f3f991740f536d9680426251392b98e8
> > Cr-Commit-Position: refs/heads/master@{#405633}
>
> [email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=None
>
> Committed: https://crrev.com/f85dca4cad17e2a4464d9e6f722f44e1c8082a93
> Cr-Commit-Position: refs/heads/master@{#408009}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=631640
Review-Url: https://codereview.chromium.org/2196463002
Cr-Commit-Position: refs/heads/master@{#408510}
ios/chrome: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2187733002
Cr-Commit-Position: refs/heads/master@{#408509}
[worklets] Add stub classes for window.animationWorklet
This adds the code necessary just to return a Worklet object from the
window.animationWorklet attribute.
Followup patches will actually perform the wiring between this and
creating the background WorkerThread.
(Alternatively we could also start with audioWorklet as well, up to the
reviewers; either or :).
BUG=567358
Review-Url: https://codereview.chromium.org/2186203002
Cr-Commit-Position: refs/heads/master@{#408508}
Refactor: remove SetDisplayWorkAreaInsets calls.
Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.
BUG=631557
Review-Url: https://codereview.chromium.org/2185773002
Cr-Commit-Position: refs/heads/master@{#408507}
[Chromedriver] Fix minimum supported chrome browser version
BUG=
Review-Url: https://codereview.chromium.org/2196443002
Cr-Commit-Position: refs/heads/master@{#408506}
Start documentation in the component updater.
BUG=
Review-Url: https://codereview.chromium.org/2147793002
Cr-Commit-Position: refs/heads/master@{#408505}
[ios] Added web::test::SetUpHttpServer which takes ResponseProvider.
This function will be used by EG tests and reused by other response
provider util functions.
BUG=612957
Review-Url: https://codereview.chromium.org/2193543002
Cr-Commit-Position: refs/heads/master@{#408504}
[Media Router WebUI] Update header background color.
Per UX discussion, having lots of header background colors is confusing. This change makes all header states blue except for error, which is still red.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2188203003
Cr-Commit-Position: refs/heads/master@{#408503}
[Editing][CodeHealth] Replace isContent/RichEditable with hasRichly/EditableStyle
That's because isContentEditable does same as hasEditableStyle except calling
document::updateStyleAndLayoutTree.
This CL replaces isContentEditable(node) to
node.document().updateStyleAndLayoutTree(); hasEditableStyle(node)
and ditto with isRichEditable.
TEST=No change in behavior
Review-Url: https://codereview.chromium.org/2185343002
Cr-Commit-Position: refs/heads/master@{#408502}
Roll src/third_party/catapult/ 45f84c704..08228c24d (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/45f84c7040ec..08228c24dda4
$ git log 45f84c704..08228c24d --date=short --no-merges --format='%ad %ae %s'
BUG=632392
[email protected]
Review-Url: https://codereview.chromium.org/2195433002
Cr-Commit-Position: refs/heads/master@{#408501}
Remove KeyboardUmaEventFilter
Metric is no longer used (either by code, or by anyone)
BUG=631204
Review-Url: https://codereview.chromium.org/2187303002
Cr-Commit-Position: refs/heads/master@{#408500}
chromeos/dbus: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2183343002
Cr-Commit-Position: refs/heads/master@{#408499}
Fix infobar painting issues at fractional scales
This calculates the paths for the infobar background (which paints the arrow) with the scale factor taken into account. It fixes blurriness in the arrow as well as a gap above the infobar (you can see both issues in a screenshot in the linked bug report).
It should have no impact on whole number DSFs (1x, 2x, etc)
BUG=627601
Review-Url: https://codereview.chromium.org/2179643002
Cr-Commit-Position: refs/heads/master@{#408498}
[Sync] Move //sync to //components/sync.
There are a bunch of subfolder reorganizations going along with this:
- engine/ -> engine_impl/
- sessions/ -> sessions_impl/
- util/ -> base/
- internal_api/public/base/ -> base/
- internal_api/public/sessions/ -> sessions/
- internal_api/public/engine/ -> engine/
- internal_api/public/events/ -> engine/events/
- internal_api/public/util/ -> base/
- internal_api/public/ -> core/
- internal_api/ -> core_impl/
This change was generated using the following script:
http://pastebin.com/vVAkRCkh
Because this patch is so large, some review was done in split CLs:
Manual changes: http://crrev.com/2155763002
Sync internal changes: http://crrev.com/2156693002
Sync external changes: http://crrev.com/2148293004
This is a minimal change to support file movement; it doesn't do
anything like merging sync_unit_tests into component_unit_tests,
which will be done in a followup.
The gyp files are not sorted because they're all going to be removed
very soon anyways.
BUG=626114
[email protected], [email protected]
TBR=jam
Review URL: https://codereview.chromium.org/2130453004 .
Cr-Commit-Position: refs/heads/master@{#408497}
More aggressive IO asserts in content_browsertests.
Since browser test's main thread corresponds roughly to the product's UI
thread, it should behave in the same wrt base::ThreadRestrictions -
after this CL the body of browser tests derived from
content::ContentBrowserTest is not allowed to do file IO.
Motivation: The more aggressive IO asserts would have caught
https://crbug.com/626972 earlier. Hopefully the more aggressive
asserting will also prevent future regressions in this area.
BUG=631145
Review-Url: https://codereview.chromium.org/2175933002
Cr-Commit-Position: refs/heads/master@{#408496}
Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.
- Make <cr-dialog> extend a native <dialog> element.
- Modify <cr-dialog> API as follows
Events renamed:
'iron-overlay-closed' -> 'close'
'iron-overlay-canceled' -> 'cancel'
'iron-overlay-opened' -> No equivalent event. Can be added if it
turns out to be necessary.
Method rename: 'open()' -> 'showModal()'
Attribute rename: 'opened' -> 'open'
Also since HTMLDialogElement#showModal() and HTMLDialogElement#close()
are stricter than equivalent PaperDialogBehavior methods, the following
<cr-dialog> behavioral changes are caused by this migration.
1) Calling showModal() when the element is not in the DOM throws exception.
2) Calling showModal()/close() when dialog is already opened/closed throws
exception.
BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2180823004
Cr-Commit-Position: refs/heads/master@{#408495}
Roll src/third_party/skia/ 03f704a34..4d516a690 (1 commit).
https://chromium.googlesource.com/skia.git/+log/03f704a343d7..4d516a6903d8
$ git log 03f704a34..4d516a690 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 bsalomon Serialize SkColorSpace into DeferredTextureImage
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2192443004
Cr-Commit-Position: refs/heads/master@{#408494}
Create a UseGoogleLocalNtp feature
When enabled, this triggers using the local NTP instead of the remote one if the default search provider is Google.
BUG=583289
Review-Url: https://codereview.chromium.org/2189973002
Cr-Commit-Position: refs/heads/master@{#408493}
Add common palette tray implementation.
This class will be derived from by the actual palette tools.
Design doc: go/caebn
The palette manager is added in https://codereview.chromium.org/2140343002/.
BUG=625251
Review-Url: https://codereview.chromium.org/2147783002
Cr-Commit-Position: refs/heads/master@{#408492}
Add revalidation / memory cache trace probes
BUG=
Review-Url: https://codereview.chromium.org/2139173003
Cr-Commit-Position: refs/heads/master@{#408491}
Update spv2 expectations for linux in preparation for the new trybot
This patch updates the spv2 expectations to what they are today on
linux. Previously, I generated this list from my mac. No attempt has
been made to triage these results.
BUG=601275
Review-Url: https://codereview.chromium.org/2188923002
Cr-Commit-Position: refs/heads/master@{#408490}
Renamed Node::reattach to Node::reattachLayoutTree.
More descriptive name. Also helps clarify parts of the code related to
layout as opposed to style.
Review-Url: https://codereview.chromium.org/2189903002
Cr-Commit-Position: refs/heads/master@{#408489}
Make video-auotplay layout test use gpu acceleration.
Test is failing with logs complaining about GL. Suspected to be the same
issue as encountered with other android tests that attempt to use hw
acceleration. Mesa is not compatible with Android's SurfaceTexture.
BUG=599975
TEST=New virtual test passes.
Review-Url: https://codereview.chromium.org/2185123004
Cr-Commit-Position: refs/heads/master@{#408488}
Add mac hermetic support to build/config/mac/sdk_info.py.
BUG=632229
Review-Url: https://codereview.chromium.org/2183053006
Cr-Commit-Position: refs/heads/master@{#408487}
Roll src/native_client/ 412a6e2bb..a07450d16 (1 commit).
https://chromium.googlesource.com/native_client/src/native_client.git/+log/412a6e2bb153..a07450d163bf
$ git log 412a6e2bb..a07450d16 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 dpranke Revert of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (patchset #2 id:20001 of https://codereview.chromium.org/2085683004/ )
BUG=621686
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
[email protected]
Review-Url: https://codereview.chromium.org/2191003002
Cr-Commit-Position: refs/heads/master@{#408486}
Flip two Mac ASAN straggler builders to GN and fix mb audit.
The addition of the internal.client.kitchensync builder broke
mb audit (which can't audit internal builders), so this skips
that, and toggles two builders that were supposed to be flipped
to GN but I mistyped things :).
[email protected]
BUG=618468
Review-Url: https://codereview.chromium.org/2187393002
Cr-Commit-Position: refs/heads/master@{#408485}
CreateButtonBackground() has been creating unpremultiplied bitmaps.
This has been feeding unpremultiplied SkBitmaps into Skia as if they were premultiplied when drawing UI themes. The attached bug shows an example of how this can go wrong.
It looks like this bug is ~7 years old. While reading the code, I noted down a couple questions worth thinking about if we want to tread into this code again.
As it is, this should be enough to be able to revert the earlier bandaid CL I landed (see the bug). It should also let us start asserting that premultiplied pixels are well-formed, to prevent this sort of problem in the future.
BUG=611002
Review-Url: https://codereview.chromium.org/2079413002
Cr-Commit-Position: refs/heads/master@{#408484}
Update tab switcher text and assets
This change removes the text shadow from titles in the tab switcher
and updates the text and close button colors to be more visible
(black with 0.64 alpha).
BUG=606612
Review-Url: https://codereview.chromium.org/2186153003
Cr-Commit-Position: refs/heads/master@{#408483}
Settings Router Refactor: Fix Closure compile issue from merge conflict.
Device page added a new navigation at the same time as the mega
router navigateTo patch. This fixes the Closure compile issue that
resulted from that collision.
BUG=608115
[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true
Review-Url: https://codereview.chromium.org/2189533005
Cr-Commit-Position: refs/heads/master@{#408482}
Reland 3: Geolocation: move from content/browser to device/
Something went wrong between revert 2 and reland 2 and not all files
were included in reland 2, however the dry-run passed, because the
dangling files were still there, and by the time Re2 landed, they
were gone, bots were not retried and everything stopped compiling after
landing :(
So this CL is just verbatim Reland 2, with a sane master branch.
Original Reland 2 description ------------------------------------------
Reland 2:Geolocation: move from content/browser to device/
Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:
FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
[1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text
Original Reland description --------------------------------------------
Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.
Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/
This CL:
- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
(already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn and
geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
geolocation_jni_registrar is added.
- classes are moved to device namespace.
All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.
Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
task runner is cached on constructor and used for both thread
checking and PostTask()ing (a few unittest and wifi_data_provider*
needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.
BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
[email protected]
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
Review-Url: https://codereview.chromium.org/2184013004
Cr-Commit-Position: refs/heads/master@{#408481}
Give the "update available" dialog a better title.
This also updates the strings involved to not use IDS_PRODUCT_NAME, per current
l10n guidelines. Their descriptions are (hopefully) improved as well.
This also collapses the disparate users of the string "Not now" into using one
common generic string.
BUG=629184
TEST=Select the "Update Chrome" menu entry and check that the dialog title is not just "Google Chrome".
Review-Url: https://codereview.chromium.org/2178103002
Cr-Commit-Position: refs/heads/master@{#408480}
Roll mocha to v2.5.3 for more useful async error messages
Mocha has fixed the annoying "Script error." problem, which async errors
or errors outside the test suite would sometimes give. Now the actual
error is logged.
Commit log: https://github.com/mochajs/mocha/compare/ebe9ceab96fc1a05d4c89b13c23824b94b01ec43...e939d8e4379a622e28064ca3a75f3e1bda7e225b
Example "Script error." which now includes the actual error (last line):
"Running TestCase Foo.Bar", source: test_api.js (1206)
"Mocha test failed: SearchTests Shows no results page
Error: Script error. (:0)
", source: mocha_adapter.js (48)
"Uncaught TypeError: Cannot read property '$$' of null", source: chrome://resources/foo.js (2034)
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2180413002
Cr-Commit-Position: refs/heads/master@{#408479}
PVer4: Implements a RICE Decoder that converts a RICE encoded string, to a list of uint32_t values, or a sequence of 4-byte hash prefixes.
For more details about RICE encoding, see: https://en.wikipedia.org/wiki/Golomb_coding
BUG=543161,624567
Review-Url: https://codereview.chromium.org/2183433002
Cr-Commit-Position: refs/heads/master@{#408478}
Tune the predictor DB size based on Net.Predictor.MRUIndex histogram
BUG=78451
Review-Url: https://codereview.chromium.org/2191013002
Cr-Commit-Position: refs/heads/master@{#408477}
Use FROM_CHROME_UI for launcher shortcuts Tab.LaunchType
BUG=629149
Review-Url: https://codereview.chromium.org/2187433005
Cr-Commit-Position: refs/heads/master@{#408476}
Enable hardware VPx decode by default.
BUG=616318
Review-Url: https://codereview.chromium.org/2183303002
Cr-Commit-Position: refs/heads/master@{#408475}
Remove one content::SSLStatus usage in the renderer.
Move the console warning when visiting localhost sites with bad certs can be done in the browser. Also remove the DHE warning since it's not needed anymore per the bug.
BUG=598073,598109
Review-Url: https://codereview.chromium.org/2190783002
Cr-Commit-Position: refs/heads/master@{#408474}
Refactored VRService interaction and added VRServiceClient
Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.
BUG=389343
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2167643003
Cr-Commit-Position: refs/heads/master@{#408473}
[Layout API] Use ownerLayoutItem() instead of ownerLayoutObject() in ScrollingCoordinator
Direct access to LayoutPart (via ownerLayoutObject()) is deprecated
and being removed soon. The replacement is LayoutPartItem (accessed
via ownerLayoutItem()), which routes methods through the new block
layout API. (See linked crbug for details.)
There are no functional changes.
BUG=499321
Review-Url: https://codereview.chromium.org/2189893003
Cr-Commit-Position: refs/heads/master@{#408472}
Roll src/third_party/skia/ 0634317cb..03f704a34 (8 commits).
https://chromium.googlesource.com/skia.git/+log/0634317cbe50..03f704a343d7
$ git log 0634317cb..03f704a34 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 mtklein Silence -Wclobbered in each file that needs it.
2016-07-28 jcgregorio Fix expectations for GN bot.
2016-07-28 bsalomon Remove unused render target members from GL and VK sk_app::WindowContext classes GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191673002
2016-07-28 csmartdalton Include NVPR configs in dm runs on TegraX1
2016-07-28 mtklein GN: add abbreviated versions of the command line as descriptions.
2016-07-28 fmenozzi Add HardStopGradientBench_ScaleNumHardStops.cpp
2016-07-28 borenet Add swarmbucket_wrapper recipe
2016-07-28 msarett Add writeToMemory() API to SkColorSpace
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2194533002
Cr-Commit-Position: refs/heads/master@{#408471}
Roll src/third_party/catapult/ 6b0563110..45f84c704 (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6b0563110dd8..45f84c7040ec
$ git log 6b0563110..45f84c704 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2188223003
Cr-Commit-Position: refs/heads/master@{#408470}
Correctly detect renderer crash because of CHECK failures on Mac
Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.
Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.
BTW also for SIGSYS.
BUG=619153
Review-Url: https://codereview.chromium.org/2188293002
Cr-Commit-Position: refs/heads/master@{#408469}
exo: Implement support for zwp_stylus_v1 protocol
This CL foward pointer tool, force and tilt information through the
zwp_stylus_v1 protocol in wayland.
BUG=628332
Review-Url: https://codereview.chromium.org/2153503005
Cr-Commit-Position: refs/heads/master@{#408468}
[serial] When a read is requested on posix platforms, try the read immediately.
On some posix platforms (e.g., OSX) the first read after a serial device is
opened may never complete. The problem is on these platforms the message loop
will not notify that a file descriptor is ready to read if it was in that state
when it was opened.
This fixed this problem by trying to perform a read immediately after it is requested.
BUG=618911
Review-Url: https://codereview.chromium.org/2057973002
Cr-Commit-Position: refs/heads/master@{#408467}
Settings Router Refactor: Migrate to settings.Route.navigateTo calls.
BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2156413002
Cr-Commit-Position: refs/heads/master@{#408466}
Avoid file IO on UI thread by moving more save-page-as stuff to the FILE thread.
BUG=626972
Review-Url: https://codereview.chromium.org/2168403003
Cr-Commit-Position: refs/heads/master@{#408465}
Running 3 ProgGuard optimization passes.
This increases release build time by 30s, reduces our .dex size by 33k,
and saves us 2k memory per process.
BUG=620371
Review-Url: https://codereview.chromium.org/2166813002
Cr-Commit-Position: refs/heads/master@{#408464}
[chromedriver] Update chrome_paths to use GN build directory.
BUG=632389
[email protected]
Review-Url: https://codereview.chromium.org/2188323002
Cr-Commit-Position: refs/heads/master@{#408463}
cc : Use screen space transform computing translation
Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2187403002
Cr-Commit-Position: refs/heads/master@{#408462}
Add note page to settings.
BUG=616112
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2178213002
Cr-Commit-Position: refs/heads/master@{#408461}
Renamed Text::reattachIfNeeded to Text::reattachLayoutTreeIfNeeded.
More descriptive name. Also helps clarify parts of the code related to
layout as opposed to style.
Review-Url: https://codereview.chromium.org/2186933003
Cr-Commit-Position: refs/heads/master@{#408460}
[Mac/GN] Fix gn gen when using_sanitizer=true use_custom_libcxx=true.
BUG=630322
[email protected]
Review-Url: https://codereview.chromium.org/2192923003
Cr-Commit-Position: refs/heads/master@{#408459}
Fix nullptr deref in remote interface acquisition
Changes MessagePipeReader to drop remote associated interface
requests if the pipe has been closed. This avoids dereferencing
a null |sender_| instance.
Also adds a sanity check to
ChannelProxy::GetGenericRemoteAssociatedInterface() to ensure it's
never called before Init(). We aren't hitting this today but it
clarifies that the method has the same expectations as
ChannelProxy::Send().
BUG=632263
[email protected]
Review-Url: https://codereview.chromium.org/2188173003
Cr-Commit-Position: refs/heads/master@{#408458}
[Chromecast] Fix reboot_util_test to use renamed api.
RebootType was renamed to RebootSource, but the change was missed
in this file. Update accordingly.
BUG= internal b/27494734
TEST= build all unittests
Review-Url: https://codereview.chromium.org/2193493002
Cr-Commit-Position: refs/heads/master@{#408457}
[css-flexbox] align-content should apply even when there's just a single line
In Jan 2015 the spec changed in
https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping
Change our code accordingly. This effectively reverts commit
764735dc12285a09a32b7d5ad3a8d6f178b0ab83
BUG=599828
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2191683003
Cr-Commit-Position: refs/heads/master@{#408456}
Roll src/third_party/catapult/ f3f785423..6b0563110 (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f3f7854232b5..6b0563110dd8
$ git log f3f785423..6b0563110 --date=short --no-merges --format='%ad %ae %s'
BUG=632155
[email protected]
Review-Url: https://codereview.chromium.org/2189983003
Cr-Commit-Position: refs/heads/master@{#408455}
Comment out some infobar identifiers for obsolete infobars.
BUG=none
Review-Url: https://codereview.chromium.org/2189963002
Cr-Commit-Position: refs/heads/master@{#408454}
1. Records additional aspects of how the canvas is used, including:
* Areas and perimeters of the total bounding box area
of different types of draw calls and fill types.
* The number of frames rendered.
2. Method to restart the usage counters.
BUG=
Review-Url: https://codereview.chromium.org/2182743002
Cr-Commit-Position: refs/heads/master@{#408453}
Remove deprecated QUIC code from DRP component
This code can be removed because Chromium network stack will
use ProxyDelegate to trigger the usage of QUIC proxies.
This is factored out from https://codereview.chromium.org/1982443003/
BUG=343579
Review-Url: https://codereview.chromium.org/2182363002
Cr-Commit-Position: refs/heads/master@{#408452}
[MD settings] propagate stopKeyboardEventPropagation to paper-input
This CL passes stopKeyboardEventPropagation from settings-input to the
underlying paper-input and then uses that property to keep the focus
in the home page url setting.
BUG=621480
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2187713003
Cr-Commit-Position: refs/heads/master@{#408451}
Change the expected results on win10 bots
Right now fast/images/paint-subrect-grid.html fails on win10. By looking
at the expected results directory, I found that win7 doesn't have
expected.png for this test, which means it refers to the expected.png
under win/ directory. By looking at the stdio of win7 bots, it appears
that this test always pass at the first run. That means the expected.png
is good for win7, but not good for win10.
So in this CL, we copy the expected.png from win/ to win7/. And replace
the expected.png under win/ by the actual results generated from the
win10 bots. So that next time when win10 bots runs, it will refer to
the actual result that itself generated, which should pass.
We should closely monitor win7 and win10 bots to make sure that
they are green after this change.
[email protected]
BUG=632000
Review-Url: https://codereview.chromium.org/2188893003
Cr-Commit-Position: refs/heads/master@{#408450}
Add regression test for an aborting navigation losing its nav_entry_id
BUG=631617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2188283002
Cr-Commit-Position: refs/heads/master@{#408449}
Revert of Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks." (patchset #2 id:40001 of https://codereview.chromium.org/2177373005/ )
Reason for revert:
Actually oops forgot this wasn't supposed to land until this blocker is resolved : https://bugs.chromium.org/p/chromium/issues/detail?id=618043#c5
Original issue's description:
> Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."
>
> This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.
>
> Per the outcome of the discussion on http://crbug.com/618043 and associated doc/chromium-dev discussion.
>
> BUG=618043
>
> Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b
> Cr-Commit-Position: refs/heads/master@{#408440}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618043
Review-Url: https://codereview.chromium.org/2190073002
Cr-Commit-Position: refs/heads/master@{#408448}
Add switch to enable palette tray UI.
BUG=625251
Review-Url: https://codereview.chromium.org/2170173002
Cr-Commit-Position: refs/heads/master@{#408447}
Roll src/third_party/skia/ 9c18546b7..0634317cb (5 commits).
https://chromium.googlesource.com/skia.git/+log/9c18546b78f9..0634317cbe50
$ git log 9c18546b7..0634317cb --date=short --no-merges --format='%ad %ae %s'
2016-07-28 mtklein GN: fix mac build again
2016-07-28 fmalita SkPaint intercept API for SkTextBlob and horizontal text
2016-07-28 mtklein Make both SK_API definition points identical and order independent.
2016-07-28 jcgregorio recipes: Add a GN flavor.
2016-07-28 robertphillips Add SkGammaColorFilter
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2191913002
Cr-Commit-Position: refs/heads/master@{#408446}
Fix keyboard focus for OOPIF-<webview>.
When using --use-cross-process-frames-for-guests input events were being
routed to the embedder which should not be able to process guests' input
events.
+ WebContents tree traversal from parent to child.
+ WebContents keeps global track of focused frame, unlike frame tree
which might not know about inner/outer web contents.
+ RenderFrameHostImpl::OnFrameFocused delegates back to WebContents
instead of frame tree.
+ Send input to Webcontents that is focused.
+ Add unfocus message to renderer. When moving focus from a frame in the
webview back to the embedder, the inner contents no longer has any focus
(the frame with focus is not visible to the inner guest).
~ Changed frame focusing with the keyboard. Tabbing into the webview did not cause focus to properly propagate everywhere.
~ Disabled NOTREACHED when finished tabbing through the webview. Left note to crbug for properly moving focus to the next element in tab order.
~ Left note on re-enabling WebViewAccessibilityTest::FocusAccessibility.
~ Reworked RenderWidgetHostViewGuest to use
MaybeSendSyntheticTapGesture for Touch and Mouse event.
~ Edited SelectShowHide for direct routing.
BUG=600395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1934703002
Cr-Commit-Position: refs/heads/master@{#408445}
Adding a new component, Previews.
This component will focus on reducing the data and page load performance
footprint of loading pages by performing various optimizations to
transform the content of those pages.
This is being added to //components (rather than //chrome) because this
will be consumed by //components/data_reduction_proxy/ and
//components/offline_pages/.
BUG=615563
Review-Url: https://codereview.chromium.org/2179863003
Cr-Commit-Position: refs/heads/master@{#408444}
[DevTools] add notifyContextDestroyed to V8Inspector
BUG=632245
Review-Url: https://codereview.chromium.org/2188723004
Cr-Commit-Position: refs/heads/master@{#408443}
Componentize spellcheck [2]: move common/ files to component.
Move chrome/common spellcheck files to component, update
spellcheck namespace, update dependencies and build files,
reformat.
The main motivation behind the componentization of the
spellcheck feature is that we want to make it available
in Android WebView.
Preceding 'componentize' patch:
[1] https://codereview.chromium.org/2166683003/
Note:
Skipping presubmit due to a warning about IPC_ENUM_TRAITS,
which is to be addressed separately.
BUG=583616, 629609
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2177343002
Cr-Commit-Position: refs/heads/master@{#408442}
headless: Support --use-gl in headless shell
This patch adds support for the --use-gl command line flag in headless
shell and makes sure we build the default osmesa implementation.
BUG=617551
Review-Url: https://codereview.chromium.org/2187353003
Cr-Commit-Position: refs/heads/master@{#408441}
Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."
This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217.
Per the outcome of the discussion on http://crbug.com/618043 and associated doc/chromium-dev discussion.
BUG=618043
Review-Url: https://codereview.chromium.org/2177373005
Cr-Commit-Position: refs/heads/master@{#408440}
Fix scroll anchoring during viewport resize.
WebView::resizeWithTopControls does a synchronous layout. Anchoring scrolls
performed during this layout were getting clobbered by ResizeViewportAnchor,
whose purpose is to scroll the viewports to preserve their combined position
(as reported by RootFrameViewport) after bounds-clamping to their new sizes.
After this change, ResizeViewportAnchor tracks the resize-induced scroll delta
while ignoring other scrolls.
BUG=626258, 612305
Review-Url: https://codereview.chromium.org/2184333002
Cr-Commit-Position: refs/heads/master@{#408439}
Fix DCHECK when opening two password bubbles one after another.
The test reproduced this by bringing the save bubble after the autosignin. Changing the state forced the bubble to close. However, it fades out and closes later. The second attempt to close was ignored and DCHECK fired.
BUG=626759
Review-Url: https://codereview.chromium.org/2188623007
Cr-Commit-Position: refs/heads/master@{#408438}
wayland-protocols: Add protocol for stylus support
Extends the wl_pointer protocol to pass along information about
stylus force, tilt and tool type.
BUG=628332
Review-Url: https://codereview.chromium.org/2144283003
Cr-Commit-Position: refs/heads/master@{#408437}
[Chromecast] Update alsa backend BUILD.gn
My recent CL https://codereview.chromium.org/2156193003/ made
//chromecast/media/cma/base depend on //chromecast/media/base, so now
the libcast_media_1.0_audio target depends on //chromecast/media/base
via alsa_cma_backend target and doesn't need to include media_caps.cc
explicitly.
Review-Url: https://codereview.chromium.org/2194463002
Cr-Commit-Position: refs/heads/master@{#408436}
gpu: Fix FD leak when creating GLImages on ChromeOS.
When creating a buffer from an existing native pixmap the FDs in the
handle received must be closed.
BUG=632375
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2187813004
Cr-Commit-Position: refs/heads/master@{#408435}
Fix order of operations in LayoutView::mapAncestorToLocal
mapAncestorToLocal should first recurse, then apply each of the offsets/transforms
in the forward direction but inverse order.
The forward direction will be transformed to backwards direction by the TransformState state bit indicating "unapply inverse direction".
This was incorrectly fixed in https://codereview.chromium.org/1994203003.
Also, remove code to handle transforms on the LayoutView. It's impossible
to have such a transform from content. This code was added in:
https://chromium.googlesource.com/chromium/src/+/ce75f4f9824faae4464420cf9c96a6cf0fb85c77
without comment as to why.
BUG=613894
Review-Url: https://codereview.chromium.org/2141693002
Cr-Commit-Position: refs/heads/master@{#408434}
Removed System tray menu separators in Material Design mode.
BUG=632152
Review-Url: https://codereview.chromium.org/2191893002
Cr-Commit-Position: refs/heads/master@{#408433}
aw: Fix FactoryProvider threading
Access thread-unsafe chromium classes on the UI thread only
BUG=630709
Review-Url: https://codereview.chromium.org/2180423003
Cr-Commit-Position: refs/heads/master@{#408432}
Fix the corner case for new audio device is not selected as active if it is plugged in for the first time after cros device is powered down.
BUG=622045
Review-Url: https://codereview.chromium.org/2189463004
Cr-Commit-Position: refs/heads/master@{#408431}
Fixed cloud policy refresh API to return correct value.
Removed CloudPolicyRefreshScheduler::refresh_delay() because it returned
a value that was not the actual value used in practice.
Replaced with GetRefreshDelay() which returns the actual value that is used
by the refresh scheduler.
BUG=628991
TBR=xiyuan
Review-Url: https://codereview.chromium.org/2159223002
Cr-Commit-Position: refs/heads/master@{#408430}
Add matching algorithm to history query options
Add text matching algorithm to history query options
to allow history queries to match against text regardless
of length. Previously, local queries would only perform
text matching for queries greater than 2 characters long.
BUG=613591
Review-Url: https://codereview.chromium.org/2187013002
Cr-Commit-Position: refs/heads/master@{#408429}
cc: Add mask target size to the effect tree
This removes another dependency of RenderSurfaceImpl on its
owning layer.
BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2188873002
Cr-Commit-Position: refs/heads/master@{#408428}
Remove thread TaskRunner hack from ChannelAssociatedGroupController
With BrowserThreadTaskRunner fixed it is no longer necessary for
ChannelAssociatedGroupController to cache the thread's
ThreadTaskRunnerHandle during Bind. It can instead rely on its
IPC TaskRunner correctly reporting RunsTasksOnCurrentThread even
during shutdown.
BUG=631039
[email protected]
Review-Url: https://codereview.chromium.org/2177933004
Cr-Commit-Position: refs/heads/master@{#408427}
Roll src/third_party/skia/ 92772222b..9c18546b7 (4 commits).
https://chromium.googlesource.com/skia.git/+log/92772222bf54..9c18546b78f9
$ git log 92772222b..9c18546b7 --date=short --no-merges --format='%ad %ae %s'
2016-07-28 borenet Fixes for SwarmBucket bot
2016-07-28 dvonbeck Added API for Bevel NormalSource.
2016-07-28 bsalomon Remove unused sk_app::WindowContext::presentRenderSurface GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184273002
2016-07-28 egdaniel Don't call finish on GrDrawTarget if we drew no batches
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2192893002
Cr-Commit-Position: refs/heads/master@{#408426}
Revert of [Android] Sanitize APK signing file timestamps. (patchset #3 id:40001 of https://codereview.chromium.org/2176023002/ )
Reason for revert:
Breaking builds:
https://bugs.chromium.org/p/chromium/issues/detail?id=632400
Original issue's description:
> [Android] Sanitize APK signing file timestamps.
>
> BUG=630931
>
> Committed: https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce
> Cr-Commit-Position: refs/heads/master@{#408389}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630931
Review-Url: https://codereview.chromium.org/2191673004
Cr-Commit-Position: refs/heads/master@{#408425}
Add entry to mb_config.pyl for new Mac 10.11 retina try bot.
Build-side changes in: http://crrev.com/2185133003
BUG=630757
Review-Url: https://codereview.chromium.org/2185033003
Cr-Commit-Position: refs/heads/master@{#408424}
Measure EventSource usage in Document and Workers.
BUG=632138
Review-Url: https://codereview.chromium.org/2186233002
Cr-Commit-Position: refs/heads/master@{#408423}
Re-land "Flip the last Mac GYP bots to GN (the ASAN bots)"
This re-lands r408345 with the needed fix to the Mac ASAN 64
Builder on chromium.memory (by turning off lsan).
[email protected]
BUG=618468, 630322, 632059
Review-Url: https://codereview.chromium.org/2191473006
Cr-Commit-Position: refs/heads/master@{#408422}
[Android] Reenable BattOr tests for android.
BUG=624962,618330
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Review-Url: https://codereview.chromium.org/2187183002
Cr-Commit-Position: refs/heads/master@{#408421}
Add more detail to Dst Color Space UMA
First version was good:
https://codereview.chromium.org/2177933002/
Hoping to add to more detail to better understand "non-standard"
gammas.
BUG=
Review-Url: https://codereview.chromium.org/2190653004
Cr-Commit-Position: refs/heads/master@{#408420}
Roll PDFium d8cc503..6f10254
https://pdfium.googlesource.com/pdfium.git/+log/d8cc503..6f10254
BUG=630654
[email protected]
Review-Url: https://codereview.chromium.org/2190853004
Cr-Commit-Position: refs/heads/master@{#408419}
Ash window cycle UI - fix highlight painting during animation.
The background was being painted to the size of the view, which changes
immediately. Instead it should be painted to the size of the layer,
which transitions from one size to another.
Previously, when transitioning from highlighting a wider window to a narrower
one, it would resize immediately. When transitioning from highlighting a
narrower window to a wider one, it would appear to work correctly because the
background would be clipped to the layer bounds (which were animating) but
the rounded corners were subtly cut off.
BUG=626111
Review-Url: https://codereview.chromium.org/2185173002
Cr-Commit-Position: refs/heads/master@{#408418}
Remove unnecessary eager finalization of PingLoaders.
A PingLoader instance controls its own lifetime, releasing its
self-keepalive reference upon completion of the load request. At that
time it also lets go of its loader object (and stops the timer), hence
there's no need to eagerly finalize this object -- it serves no real
purpose.
R=
BUG=
Review-Url: https://codereview.chromium.org/2180423005
Cr-Commit-Position: refs/heads/master@{#408417}
Roll src/third_party/catapult/ 53df93380..f3f785423 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/53df933806d9..f3f7854232b5
$ git log 53df93380..f3f785423 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2185423002
Cr-Commit-Position: refs/heads/master@{#408416}
[Chromecast] Add Initialize/Finalize to RebootShlib api.
Need to be able to pass commandline args to reboot shlib, so add
Initialize method (and corresponding finalize).
BUG= internal b/27494734
TEST= built for device and tested reboot api
Review-Url: https://codereview.chromium.org/2187703004
Cr-Commit-Position: refs/heads/master@{#408415}
Fix dock window behavior when shelf is auto-hidden
In Chrome OS MD, the docked window can now extend to the edge of screen
when the shelf is auto-hidden. This bug is originally discovered by
running test case DockedWindowResizerTest.AttachOneAutoHideShelf, so no
test cases is added to verify it.
BUG=630361
Review-Url: https://codereview.chromium.org/2183613006
Cr-Commit-Position: refs/heads/master@{#408414}
Add some flags when launching the Chrome Cleanup Tool.
This allows the Chrome Cleanup Tool to correctly identify Chrome's version and channel information, and also whether or not the user has user metrics and crash reporting enabled.
BUG=601668
Review-Url: https://codereview.chromium.org/2151133003
Cr-Commit-Position: refs/heads/master@{#408413}
Flip SyzyASAN builders to GN.
This affects the following builders:
- chromium.lkgr
- Chromium Win SyzyASAN
- official.desktop
- win-asan
- tryserver.chromium.win
- win_chromium_syzyasan_rel
[email protected]
BUG=605318, 623659
Review-Url: https://codereview.chromium.org/2178393003
Cr-Commit-Position: refs/heads/master@{#408412}
Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown
Changes BrowserThread::CurrentlyOn (and thus
BrowserThreadTaskRunner::RunsTasksOnCurrentThread()) to correctly report
a BrowserThread's association during MessageLoop destruction notification.
Also adds an explicit Start() to BrowserThreadImpl as there are tests which
call it and which incorrectly assumed base::Thread's implementation would
call BrowserThreadImpl::StartWithOptions (which it wouldn't since the latter
is not a virtual function.)
This change provokes many tests to delete ExtensionFunction instances that
were otherwise being leaked because UIThreadExtensionFunction::Destroy was
incorrectly deferring destruction when run on the UI thread during shutdown.
This in turn revealed a few small bugs which have also been fixed here.
BUG=631093
[email protected]
Committed: https://crrev.com/b02da29fb9116d1a1fb4fd0476628f333ff6bd1a
Review-Url: https://codereview.chromium.org/2180253003
Cr-Original-Commit-Position: refs/heads/master@{#408295}
Cr-Commit-Position: refs/heads/master@{#408411}
Make sure the Async test cases availabel today generate correct ClientID.
BUG=630817
Review-Url: https://codereview.chromium.org/2180113003
Cr-Commit-Position: refs/heads/master@{#408410}
cc : Split TransformTree::ComputeTransform
ComputeTransform is too general as we can call it with any transform nodes.
To to able to effectively use the new transforms caching system, we have
to know more information. I added ComputeTransformsToTarget for this
reason. This CL adds ComputeTransformsFromTarget and
ComputeTranslation.
With this CL, TransformTree::ComputeTransforms is only called by tests,
for computing target space transform while updating transform tree,
and from these new functions.
Also changed the return value of TransformTree::CombineTransformBetween
from bool to void as it always returns true.
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2180223005
Cr-Commit-Position: refs/heads/master@{#408409}
Remove --certificate-transparency-log command-line flag
This removes the --certificate-transparency-log command-line flag
from Chrome initialization. It was used to be able to add additional
logs at runtime, but this was only ever intended to be used when
standing up a new log, and if you're standing up a new log, then it's
not unreasonable to expect locally compiling Chromium to test.
If there is significant concern from log operators, we can revisit how to
add logs on demand, but so far, there hasn't been a need.
BUG=632351
Review-Url: https://codereview.chromium.org/2184053002
Cr-Commit-Position: refs/heads/master@{#408408}
* Adds the initial version of mojom interfaces for Mus IME.
* Implements basic IME driver in services/ui/test_ime. An IME driver is a
service which is responsible for doing the composition logic and generating
composition events. The basic driver replies back key events with an INSERT_CHAR
composition event with the same character code.
BUG=548407
Review-Url: https://codereview.chromium.org/2161773002
Cr-Commit-Position: refs/heads/master@{#408407}
Remove code used for downstream compatibility
This CL removes ContextMenuCoordinator code used for downstream compatibility
during refactoring.
BUG=none
Review-Url: https://codereview.chromium.org/2156953002
Cr-Commit-Position: refs/heads/master@{#408406}
Revert of Update V8 to version 5.4.285. (patchset #1 id:1 of https://codereview.chromium.org/2187753004/ )
Reason for revert:
I think this is causing compile failures on win x64:
http://build.chromium.org/p/chromium/builders/Win%20x64/builds/2828
Original issue's description:
> Update V8 to version 5.4.285.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/0b56cb99..41f6e072
>
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> [email protected],[email protected],[email protected],[email protected]
>
> Committed: https://crrev.com/da4da3a788baf26de1125de03e9169af56b00fb4
> Cr-Commit-Position: refs/heads/master@{#408392}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2193433002
Cr-Commit-Position: refs/heads/master@{#408405}
DevTools: simplify instance access to provided views.
Review-Url: https://codereview.chromium.org/2187023003
Cr-Commit-Position: refs/heads/master@{#408404}
[Extensions UI] Check for a browser not being found
chrome::FindBrowserWithWebContents() can return null in some cases.
Guard against it in showing the warning bubble.
BUG=631362
Review-Url: https://codereview.chromium.org/2191713003
Cr-Commit-Position: refs/heads/master@{#408403}
Implement resize option for createImageBitmap from ImageData
In the case of ImageData, we use two different code path for the
following two cases:
1). ImageBitmapOptions.premultiplyAlpha = true
2). ImageBitmapOptions.premultiplyAlpha = false
In the first case, we create a SkSurface and draw the original SkImage
onto it for resizing. In the second case, we call scalePixels on the
original SkImage.
BUG=627855
Review-Url: https://codereview.chromium.org/2183323003
Cr-Commit-Position: refs/heads/master@{#408402}
Changed raw pointer to WeakPtr to prevent use-after-free on destruction.
BUG=631320
Review-Url: https://codereview.chromium.org/2187243002
Cr-Commit-Position: refs/heads/master@{#408401}
Roll src/third_party/skia/ 95860ad40..92772222b (13 commits).
https://chromium.googlesource.com/skia.git/+log/95860ad4004e..92772222bf54
$ git log 95860ad40..92772222b --date=short --no-merges --format='%ad %ae %s'
2016-07-28 tomhudson Revert of align cap hairline first point (patchset #2 id:20001 of https://codereview.chromium.org/2189583003/ )
2016-07-27 mtklein Turn on flags to enforce SK_API.
2016-07-27 halcanary SkPdf: SkPDFFormXObject de-class-ified.
2016-07-27 jcgregorio upload_bench_results - fix GS upload path.
2016-07-27 jvanverth Enable backend switching for Windows Viewer
2016-07-27 halcanary SkPDF: refactor font subset: fewer copies
2016-07-27 borenet Fix silently-failing compile
2016-07-27 mtklein GN: dm
2016-07-27 msarett Expose more gamma info for UMA statistics
2016-07-27 csmartdalton Fix GrDrawContextPriv::stencilRect
2016-07-27 kjlubick Add Vulkan runtime dll
2016-07-27 caryclark align cap hairline first point
2016-07-27 borenet Make the experimental SwarmBucket bot use the SkiaTriggers pool
BUG=617658
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2187313002
Cr-Commit-Position: refs/heads/master@{#408400}
Make Resource::m_response private
This CL makes |Resource::m_response| private and replaces the usage of
this with |response()| calls.
There was only one place where |m_response| was updated in the
subclasses of Resource. This was in
|ImageResource::onePartInMultipartReceived| and replaced with
|setResponse()|. |setResponse()| updates not only |m_response| but
also |m_cacheHandler|. Calling |setReponse()| is more appropriate
for caching of a response which is multipart and fetched from
ServiceWorker.
BUG=n/a
TEST=webkit_unit_tests --gtest_filter=ImageResourceTest.*
Review-Url: https://codereview.chromium.org/2183323005
Cr-Commit-Position: refs/heads/master@{#408399}
Add check for GmsCore before showing AccountSigninActivity.
BUG=626702, 603020
Review-Url: https://codereview.chromium.org/2154733002
Cr-Commit-Position: refs/heads/master@{#408398}
Removing DownloadInfoTest
It doesn't make sense to have DownloadInfoTest with upcoming ProGuard
changes. It doesn't check any meaningful functionality (just that all
setters correspond to getters, and that running all getters on a copied
object all return the same values) and relies on getting the method's
names via reflection, which is going to cause a lot of issues as
ProGuard usage increases.
BUG=620323
Review-Url: https://codereview.chromium.org/2186993003
Cr-Commit-Position: refs/heads/master@{#408397}
Revert of Reland 2:Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2192683002/ )
Reason for revert:
Looks like this is still breaking builders:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/40523
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/112343/steps/generate_build_files%20%28with%20patch%29/logs/stdio
Original issue's description:
> Reland 2:Geolocation: move from content/browser to device/
>
> Reland was reverted due to a build failure in an official win64 builder
> that hit the infamous size_t to int conversion warning [1]:
>
> FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
> ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
> c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
> c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
>
> [1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text
>
> Original Reland description --------------------------------------------
>
> Original CL was reverted because it broke Win Gyp Component-build
> bot(s). This CL (PS2) defines the geolocation gyp component
> correctly.
>
> Original CL description ------------------------------------------------
> Geolocation: move from content/browser to device/
>
> This CL:
>
> - moves all of content/browser/geolocation to device/geolocation
> - the public geolocation files in content/common/{browser, public}
> are also relocated to device/geolocation
> - the geolocation-specific unittests are compiled into
> (already existing) device_unittests
> - adds new fancy new device/geolocation BUILD.gn and
> geolocation.gyp as well
> - makes a component of geolocation (at least for gn) and that forces
> adding geolocation_export.h (like other //device/ folders).
> - Java Geolocation files are moved as well, and a new
> geolocation_jni_registrar is added.
> - classes are moved to device namespace.
>
> All paths and include/call sites updated, DEPS, BUILD.gn files,
> gypi files etc.
>
> Some tricks:
> - can't use BrowserThread::CurrentlyOn, etc; instead, the
> task runner is cached on constructor and used for both thread
> checking and PostTask()ing (a few unittest and wifi_data_provider*
> needed that substitution).
> - GeolocationServiceContext is moved to public/cpp so it can
> be referenced from WebContentsImpl.
> - MockLocationProvider.java is also moved to device/geolocation.
>
> BUG=612334
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> [email protected]
> rationale:device/geolocation depends on dbus and this triggers
> a DEPS presubmit rule -- however, this CL adds no new dependencies,
> hence moving on in the interest of speed (and avoiding more rebases).
>
> Committed: https://crrev.com/67553346ccc4dcb3c2da968bd98f1b15136d2d08
> Cr-Commit-Position: refs/heads/master@{#408393}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334
Review-Url: https://codereview.chromium.org/2187923003
Cr-Commit-Position: refs/heads/master@{#408396}
Fix make_file_types_protobuf when built under secondary toolchain
BUG=632104
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
Review-Url: https://codereview.chromium.org/2185403002
Cr-Commit-Position: refs/heads/master@{#408395}
Add PlatformThread::IsIncreaseCurrentThreadPrioritySupported().
PlatformThread::IsIncreaseCurrentThreadPrioritySupported() indicates
whether the priority of the current thread can be increased using
PlatformThread::SetCurrentThreadPriority(). On Windows and Mac, it
always returns true. On POSIX, it returns true when the current user
is root.
This function will be used in base/task_scheduler to avoid creating
low priority threads if their priority can't be increased during
shutdown.
BUG=553459
Review-Url: https://codereview.chromium.org/2176263005
Cr-Commit-Position: refs/heads/master@{#408394}
Reland 2:Geolocation: move from content/browser to device/
Reland was reverted due to a build failure in an official win64 builder
that hit the infamous size_t to int conversion warning [1]:
FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
[1] https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/1125/steps/compile/logs/stdio/text
Original Reland description --------------------------------------------
Original CL was reverted because it broke Win Gyp Component-build
bot(s). This CL (PS2) defines the geolocation gyp component
correctly.
Original CL description ------------------------------------------------
Geolocation: move from content/browser to device/
This CL:
- moves all of content/browser/geolocation to device/geolocation
- the public geolocation files in content/common/{browser, public}
are also relocated to device/geolocation
- the geolocation-specific unittests are compiled into
(already existing) device_unittests
- adds new fancy new device/geolocation BUILD.gn and
geolocation.gyp as well
- makes a component of geolocation (at least for gn) and that forces
adding geolocation_export.h (like other //device/ folders).
- Java Geolocation files are moved as well, and a new
geolocation_jni_registrar is added.
- classes are moved to device namespace.
All paths and include/call sites updated, DEPS, BUILD.gn files,
gypi files etc.
Some tricks:
- can't use BrowserThread::CurrentlyOn, etc; instead, the
task runner is cached on constructor and used for both thread
checking and PostTask()ing (a few unittest and wifi_data_provider*
needed that substitution).
- GeolocationServiceContext is moved to public/cpp so it can
be referenced from WebContentsImpl.
- MockLocationProvider.java is also moved to device/geolocation.
BUG=612334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
[email protected]
rationale:device/geolocation depends on dbus and this triggers
a DEPS presubmit rule -- however, this CL adds no new dependencies,
hence moving on in the interest of speed (and avoiding more rebases).
Review-Url: https://codereview.chromium.org/2192683002
Cr-Commit-Position: refs/heads/master@{#408393}
Update V8 to version 5.4.285.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0b56cb99..41f6e072
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2187753004
Cr-Commit-Position: refs/heads/master@{#408392}
customtabs: Send time to first contentful paint to the caller.
Time to First Contentful Paint is a very useful metric to assess page load
performance. It is collected on the native side. This patch forwards it to the
Java side on Android, and makes it available to the embedding app for Custom
Tabs.
BUG=624909
Review-Url: https://codereview.chromium.org/2139243003
Cr-Commit-Position: refs/heads/master@{#408391}
Apply Shelf/Dock opacity animations for the Material Design style.
The Shelf animates between the 3 ShelfBackgroundType's using 2
different animations; one uses BackgroundAnimator timers and
View::OnPaint() and the other uses a Layer to animate the
SHELF_BACKGROUND_MAXIMIZED opaque background.
This change centralizes the animation logic so they all stay in sync
and applies the opacity animations to the material design style
Shelf/Dock.
Eventually the ShelfBackgroundAnimator will be enhanced to animate
between colors instead of just alpha values.
Follow-up plans:
- Use a single instance of the ShelfBackgroundAnimator.
- Remove the |opaque_background_| from ShelfWidget and
DockedBackgroundWidget.
- Collapse the multiple BackgroundAnimators owned by the
ShelfBackgroundAnimator into a single SlideAnimation.
- Animate the MD AppList and Overflow buttons.
BUG=607037
TEST=ShelfBackgroundAnimator(NonMD|MD)Test.*
Review-Url: https://codereview.chromium.org/2053113002
Cr-Commit-Position: refs/heads/master@{#408390}
[Android] Sanitize APK signing file timestamps.
BUG=630931
Review-Url: https://codereview.chromium.org/2176023002
Cr-Commit-Position: refs/heads/master@{#408389}
Blink: prevent didAssociateFormControls notification while parsing the document.
Also remove Document::m_associatedFormControls unused by the consumer.
BUG=631958
Review-Url: https://codereview.chromium.org/2189513004
Cr-Commit-Position: refs/heads/master@{#408388}
Do not show Lightweight FRE if it is disabled
BUG=630991
Review-Url: https://codereview.chromium.org/2177943002
Cr-Commit-Position: refs/heads/master@{#408387}
Add "MORE ↓" button on sign in confirmation screen when it has not been scrolled to bottom
Click of the button scrolls the sign in confirmation screen down.
BUG=627675
Review-Url: https://codereview.chromium.org/2183523002
Cr-Commit-Position: refs/heads/master@{#408386}
Set the testing parameter for the PasswordSmartBubble study.
BUG=618312
Review-Url: https://codereview.chromium.org/2186163004
Cr-Commit-Position: refs/heads/master@{#408385}
Rename browsing_data::TimePeriod::EVERYTHING to ALL_TIME
Time ranges used to be the only filtering that BrowsingDataRemover supported.
Nowadays, we support deleting some data types per url [, origin, domain].
This makes "EVERYTHING", the name of the unbounded time range, a misnomer;
it's possible that deletion of EVERYTHING will in fact not delete everything
if a url filter is present.
Rename EVERYTHING to ALL_TIME to avoid confusion.
[email protected]
BUG=589586
Review-Url: https://codereview.chromium.org/2187273003
Cr-Commit-Position: refs/heads/master@{#408384}
Update V8 to version 5.4.283.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/36325c41..0b56cb99
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2188183002
Cr-Commit-Position: refs/heads/master@{#408383}
Do no show sign in screen for full FRE if user already signed in
User may signed in after going through scoped FRE
BUG=627444
Review-Url: https://codereview.chromium.org/2184063004
Cr-Commit-Position: refs/heads/master@{#408382}
CacheStorage: Introduce QueryCache algorithm.
This CL is introducing QueryCache[1] algorithm. The algorithm is used to get
requestResponseArray from target storage. (e.g. in matchAll())
This CL is triggered from a comment in [2].
[1] http://slightlyoff.github.io/ServiceWorker/spec/service_worker/#query-cache-algorithm
[2] https://codereview.chromium.org/1719103002/diff/100001/content/browser/cache_storage/cache_storage_cache.cc#newcode1253
BUG=none
TEST=existing tests
Review-Url: https://codereview.chromium.org/2137833002
Cr-Commit-Position: refs/heads/master@{#408381}
Update and fix sendBeacon() redirect behavior.
Refresh the implementation to follow the specification changes in
https://github.com/w3c/beacon/pull/33
https://github.com/w3c/beacon/pull/34
In particular, correctly flag a CORS-disallowed redirect as not to
be followed by WebURLLoader.
R=
BUG=628762
Review-Url: https://codereview.chromium.org/2177383006
Cr-Commit-Position: refs/heads/master@{#408380}
Change ContextMenu to use AlertCoordinator
This CL changes the ContextMenu class to use AlertCoordinator for handling the
display of the alerts.
BUG=none
Review-Url: https://codereview.chromium.org/2154163002
Cr-Commit-Position: refs/heads/master@{#408379}
Deprecate the CallbackSubscription in BrowsingDataRemover
BrowsingDataRemover currently supports two notification systems:
1. BrowsingDataRemover::Observer
2. BrowsingDataRemover::CallbackSubscription
Remove #2 in favor of #1.
The NotificationDetails class which is returned by #2, and used by tests to
determine the parameters of the last call to BrowsingDataRemover, is replaced
by a public API of BrowsingDataRemover exposing the same values.
The consolidation of notifications will simplify the implementation of task
scheduler for removal tasks, as described in
https://docs.google.com/document/d/1oIbmZJlq5m5FvHcN7trCpp0h4mtydA0UfZasxEIe3P8/
BUG=630327
Review-Url: https://codereview.chromium.org/2171383002
Cr-Commit-Position: refs/heads/master@{#408378}
Parse PopularSites JSON by callback.
Pass safe_json::SafeJsonParser::Parse in from MostVisitedSitesBridge and
remove the dep on safe_json from ntp_tiles.
BUG=617966
Review-Url: https://codereview.chromium.org/2192783002
Cr-Commit-Position: refs/heads/master@{#408377}
binding: Disallows to run a function if its context is detached.
There are two contexts when about to run a ScheduledAction.
|this|'s context and the context of the function to be run.
If the latter context no longer has a valid V8PerContextData,
|self| returns null.
function() { self.testRunner; } // self will be null
This issue has been there for a long time, but
https://crrev.com/2049493005 made it easy to happen.
This CL disallows to run a function if the function's context is
detached. This is not the right fix, but close to the behavior
before https://crrev.com/2049493005 .
The right fix is that, per spec, |self| always returns the global
proxy object that never be null. I.e. we need to support detached
windows.
BUG=630996
Review-Url: https://codereview.chromium.org/2191543002
Cr-Commit-Position: refs/heads/master@{#408376}
Update V8 to version 5.4.282.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/181388a1..36325c41
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2190723004
Cr-Commit-Position: refs/heads/master@{#408375}
MacViews: Change insertTextInternal to correctly handle IME character input.
This CL fixes a regression caused in r400918 which modified the insertText
handlers to use the current key down event instead of the passed |text| argument
for character text insertion. While this works correctly for regular text, this
is not correct for text inserted using an IME. This is because when the current
composition text is confirmed, say by pressing the Return key, |keyDownEvent_|
will correspond to the return key press event. Hence [keyDownEvent_ characters]
will not contain the text to be inserted.
This CL corrects the insertTextInternal function to use |text| instead of
|keyDownEvent_| to generate the synthetic ui::KeyEvent for character insertion,
hence fixing the bug.
BUG=630980
Review-Url: https://codereview.chromium.org/2180873002
Cr-Commit-Position: refs/heads/master@{#408374}
Register delete time period pref for Clear Browsing Data on iOS
This will be set via a time selector in the Clear Browsing Data UI on iOS.
BUG=620318
Review-Url: https://codereview.chromium.org/2184163002
Cr-Commit-Position: refs/heads/master@{#408373}
Added include from xdg_user_dir_lookup.cc to xdg_user_dir_lookup.h
Review-Url: https://codereview.chromium.org/2191513002
Cr-Commit-Position: refs/heads/master@{#408372}
Implement AwPermissionManager::RequestPermissions
This is needed to work with new Web MIDI permission requests.
BUG=582328
TEST=git cl try
TEST=run_android_webview_unittests --gtest_filter='AwPermissionManagerTest.*'
TEST=run_system_webview_shell_layout_test_apk with built SystemWebViewGoogle.apk
Review-Url: https://codereview.chromium.org/2143573002
Cr-Commit-Position: refs/heads/master@{#408371}
harfbuzz-ng: make use of the use_glib gn arg
BUG=632297
Review-Url: https://codereview.chromium.org/2187163002
Cr-Commit-Position: refs/heads/master@{#408370}
Start PopularSites fetch from separate function.
Then, inject a PopularSites into MostVisited, instead of injecting all
of its arguments and creating one locally.
BUG=617966
Review-Url: https://codereview.chromium.org/2179233003
Cr-Commit-Position: refs/heads/master@{#408369}
META refresh: Accept only HTML spaces, instead of all control characters.
We used to accept U+0020 SPACE and all of controls characters as whitespace in META
refresh parsing. This CL updates it so that we accepts only HTML spaces (SPACE,
CHARACTER TABULATION, LINE FEED, FORM FEED, and CARRIAGE RETURN).
Firefox accepts
- SPACE,
- CHARACTER TABULATION,
- LINE FEED, and
- CARRIAGE RETURN.
Edge accepts
- SPACE,
- CHARACTER TABULATION,
- LINE TABULATION,
- LINE FEED,
- FORM FEED, and
- CARRIAGE RETURN.
So our new behavior doesn't match to Firefox and Edge. But compatibility risk is low
because we accept more characters than Firefox.
BUG=20117
Review-Url: https://codereview.chromium.org/2184063003
Cr-Commit-Position: refs/heads/master@{#408368}
Revert of Update V8 to version 5.4.281. (patchset #1 id:1 of https://codereview.chromium.org/2185983003/ )
Reason for revert:
Compilation errors on win:
https://build.chromium.org/p/chromium/builders/Win/builds/45681
Original issue's description:
> Update V8 to version 5.4.281.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/181388a1..18d2685f
>
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> [email protected],[email protected],[email protected],[email protected]
>
> Committed: https://crrev.com/3118f46c6852e457ef636d9b2f1e4012b378d55c
> Cr-Commit-Position: refs/heads/master@{#408360}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2177373006
Cr-Commit-Position: refs/heads/master@{#408367}
Revert of Update V8 to version 5.4.281.1 (cherry-pick). (patchset #1 id:1 of https://codereview.chromium.org/2189943002/ )
Reason for revert:
Didn't help - reverting this and original roll.
Original issue's description:
> Update V8 to version 5.4.281.1 (cherry-pick).
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/18d2685f..d158e5fb
>
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> [email protected],[email protected],[email protected],[email protected]
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://crrev.com/ee151ac07640634955472aa6415d10856cc877be
> Cr-Commit-Position: refs/heads/master@{#408365}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2191843002
Cr-Commit-Position: refs/heads/master@{#408366}
Update V8 to version 5.4.281.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/18d2685f..d158e5fb
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
NOTRY=true
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2189943002
Cr-Commit-Position: refs/heads/master@{#408365}
Add "Locale uses in Fonts" document
This patch adds a document that describes how locales are used in
fonts.
NOTRY=true
BUG=586517
Review-Url: https://codereview.chromium.org/2190833003
Cr-Commit-Position: refs/heads/master@{#408364}
[Media Router] Rename mojo namespace from interfaces to mojom
BUG=629376
Review-Url: https://codereview.chromium.org/2185293002
Cr-Commit-Position: refs/heads/master@{#408363}
make use of use_gconf & use_glib gn args in content/browser/
Review-Url: https://codereview.chromium.org/2191733002
Cr-Commit-Position: refs/heads/master@{#408362}
document.all: Fix name access coverage.
Add name access for
- <applet>
- <button>
- <map>
- <meta>
- <textarea>
Drop name access for <area>
New behavior matches to the standard, Firefox, and Edge.
* testharnessreport.js
Support cases where document.body is <frameset>.
* document-all-input.html and document-all-select.html
Merge them into new test, htmlallcollection-name.html.
* htmlallcollection-enumerated-properties.html
Adjust expectation for <area> and <map>. Also, fix an incorrect inheritance
check.
BUG=10838
Review-Url: https://codereview.chromium.org/2188963002
Cr-Commit-Position: refs/heads/master@{#408361}
Update V8 to version 5.4.281.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/181388a1..18d2685f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2185983003
Cr-Commit-Position: refs/heads/master@{#408360}
Auto-rebaseline for r408347
https://chromium.googlesource.com/chromium/src/+/57b84ed8f
BUG=619452
[email protected]
Review URL: https://codereview.chromium.org/2189733005 .
Cr-Commit-Position: refs/heads/master@{#408359}
Simplify the condition for destroyDecodedData()
This CL simplifies the condition for destroyDecodedData(). When an error
occurs, |m_image| must be null and the condition for |m_image| doesn't
make sense.
This CL also fixes another if condition and inserts DCHECK based on the
above assumption.
BUG=618623, 631321
TEST=webkit_unit_tests --gtest_filter=ImageResourceTest.*
Review-Url: https://codereview.chromium.org/2176603002
Cr-Commit-Position: refs/heads/master@{#408358}
Update test names in DrMemory suppressions
At some point the test names changed.
TBR=jyasskin
BUG=None
Review-Url: https://codereview.chromium.org/2186223002
Cr-Commit-Position: refs/heads/master@{#408357}
Disable two tests under DrMemory.
TBR=jyasskin
BUG=632264, 632248
Review-Url: https://codereview.chromium.org/2188973002
Cr-Commit-Position: refs/heads/master@{#408356}
Revert of Fix extension bindings injection for iframes (patchset #5 id:120001 of https://codereview.chromium.org/2151693002/ )
Reason for revert:
This Cl caused a test failure under DrMemory.
First build with failing test: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%282%29/builds/3969
Sample failure output: FramesExtensionBindingsApiTest.FramesBeforeNavigation:
[1420:4432:0722/173632:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
[1420:4432:0722/174006:INFO:CONSOLE(0)] "Denying load of chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/nonexistent.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0)
[1420:4432:0722/174015:INFO:CONSOLE(24)] "caught exception: SecurityError: Blocked a frame with origin "http://127.0.0.1:50285" from accessing a cross-origin frame.", source: http://127.0.0.1:50285/extensions/api_test/bindings/frames_before_navigation.html (24)
[1420:4432:0722/174018:INFO:CONSOLE(0)] "Denying load of chrome-extension://ficgdghpakbhhkmdjamiedmcoobamkoo/nonexistent.html. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.", source: about:blank (0)
[1420:4988:0722/174053:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_bindings_apitest.cc(257): error: Value of: page_success
Actual: false
Expected: true
Original issue's description:
> Fix extension bindings injection for iframes
>
> For iframes, we don't want to use the source url for determining the
> associated extension because it starts out with an about:blank context
> that is scriptable by its parent.
>
> BUG=573131
>
> Committed: https://crrev.com/91f655b19888da3f86b57ad8c548da93e7b9aba4
> Cr-Commit-Position: refs/heads/master@{#407214}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=573131
Review-Url: https://codereview.chromium.org/2191793002
Cr-Commit-Position: refs/heads/master@{#408355}
Defer loads in new pages/frames if ScopedPageLoadDeferral is active
BUG=628942
Review-Url: https://codereview.chromium.org/2174263002
Cr-Commit-Position: refs/heads/master@{#408354}
Update V8 to version 5.4.280.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b634291e..181388a1
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2191783002
Cr-Commit-Position: refs/heads/master@{#408353}
Automated Commit: Committing new LKGM version 8642.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#408352}
Revert of Substituting legacy protocol with uWeave protocol (patchset #33 id:630001 of https://codereview.chromium.org/2075313002/ )
Reason for revert:
This CL has a memory problem in the unit tests, as reported by DrMemory.
First build showing the error: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5364
Note, that build doesn't include this change as there was a problem introduced earlier that caused the whole build to fail.
Error text:
UNADDRESSABLE ACCESS of freed memory: reading 0x069fa848-0x069fa84c 4 byte(s)
# 0 proximity_auth::weave::BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance [components\proximity_auth\ble\bluetooth_low_energy_weave_packet_generator.cc:33]
# 1 proximity_auth::weave::ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest_CreateConnectionRequestTest_Test::TestBody [components\proximity_auth\ble\bluetooth_low_energy_weave_packet_generator_unittest.cc:54]
# 2 testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2458]
Note: @0:05:46.506 in thread 13092
Note: 0x069fa848-0x069fa84c overlaps memory 0x069fa5d8-0x069fa8c0 that was freed here:
Note: # 0 replace_operator_delete_nothrow [d:\drmemory_package\common\alloc_replace.c:2974]
Note: # 1 proximity_auth::weave::ProximityAuthBluetoothLowEnergyWeaveClientConnectionTest_ConnectAfterADelayWhenThrottled_Test::`scalar deleting destructor'
Note: # 2 testing::Test::DeleteSelf_ [testing\gtest\include\gtest\gtest.h:453]
Note: # 3 testing::TestInfo::Run [testing\gtest\src\gtest.cc:2661]
Note: instruction: mov (%eax) -> %edx
Suppression (error hash=#E743E83C1B0FB1CF#):
For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNADDRESSABLE ACCESS
name=<insert_a_suppression_name_here>
*!proximity_auth::weave::BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance
*!proximity_auth::weave::ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest_CreateConnectionRequestTest_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
The problem is real, to fix this SetInstanceForTesting should keep the previous factory around somewhere, and there should be a method to clear the testing instance. Or something like that.
Original issue's description:
> Using the uWeave packet generator and receiver to re-implement the BluetoothLowEnergyConnection class
>
> Major changes:
> SendMesssageImpl which instead of using the old protocol, it will just generate the message with the WeavePacketGenerator.
>
> GattCharacteristicValueChanged instead of parsing messages received with the old protocol, will now use the WeavePacketReceiver and just switch on the state of the receiver and take appropriate action.
>
> Design Doc for ProximityAuth uWeave Migration:
> https://docs.google.com/a/google.com/document/d/1HJ1fipxsNQwIxmKs-5_6TjroCAcs6qRhAYvOnIr6mQw/edit?usp=sharing
>
> BUG=617238
>
> Committed: https://crrev.com/f4f0a5cde8eff464de5359281560444ff442f920
> Cr-Commit-Position: refs/heads/master@{#407655}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617238
Review-Url: https://codereview.chromium.org/2189913002
Cr-Commit-Position: refs/heads/master@{#408351}
Reduce size of generated extension FeatureProviders.
The generated feature provider code was generating a lot of std::string
and std::vector objects from string literals and initializer lists.
Unfortunately, this results in inlining a lot of STL code: on an
official Linux build, extensions::APIFeatureProvider::APIFeatureProvider
was over 200KB of code. After this change, it's still larger than
expected, at just under 67KB, but it's much better than before. In all,
this saves about 275KB of binary size in an official Linux GN build.
BUG=631915
Review-Url: https://codereview.chromium.org/2186893002
Cr-Commit-Position: refs/heads/master@{#408350}
DevTools: differentiate between singleton and factory extension classes.
Review-Url: https://codereview.chromium.org/2192663002
Cr-Commit-Position: refs/heads/master@{#408349}
Revert of Flip the last Mac GYP bots to GN (the ASAN bots) (patchset #4 id:60001 of https://codereview.chromium.org/2168713003/ )
Reason for revert:
The Mac ASAN bot is not compiling after this.
Example stdio: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/40502/steps/compile/logs/stdio
Original issue's description:
> Flip the last Mac GYP bots to GN (the ASAN bots):
>
> This flips the remaining Mac builders to GN. A number of
> browser_tests that use NaCl are failing under ASAN, so
> we disable NaCl for now.
>
> This affects:
>
> - chromium.fyi
> - ClangToTMacASan
> - chromium.lkgr
> - Mac ASAN Debug
> - Mac ASAN Release Media
> - Mac ASAN Release
> - chromium.memory:
> - Mac ASAN 64 Builder
> - tryserver.chromium.mac:
> - mac_chromium_asan_rel_ng
>
> [email protected], [email protected], [email protected]
> BUG=618468, 630322, 632059
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
>
> Committed: https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5
> Cr-Commit-Position: refs/heads/master@{#408345}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618468, 630322, 632059
Review-Url: https://codereview.chromium.org/2184363003
Cr-Commit-Position: refs/heads/master@{#408348}
Remove grammar checking from layout tests, and MockGrammarCheck
Since Chromium and Blink do not support grammar checking, this patch
removes grammar checking from the following layout tests:
spelling/markers.html
spelling/inline_spelling_markers.html
spelling/inline-spelling-markers-hidpi.html
spelling/inline-spelling-markers-hidpi-composited.html
The last three tests use pixel tests, and are temporarily marked
as failing. They will be unmarked after the grammar marks are removed
from their pixel results.
This patch also removes the class MockGrammarCheck since its only
purpose is to support grammar checking in tests.
BUG=619452
TEST=n/a; this patch changes test files
Review-Url: https://codereview.chromium.org/2186923002
Cr-Commit-Position: refs/heads/master@{#408347}
Add browsertest for permission action reporting
MockReportSender class is refactored from chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed to MockPermissionReportSender so that it can be used in chrome/browser/safe_browsing/permission_reporter_browsertest.cc
BUG=613883
Review-Url: https://codereview.chromium.org/2164513002
Cr-Commit-Position: refs/heads/master@{#408346}
Flip the last Mac GYP bots to GN (the ASAN bots):
This flips the remaining Mac builders to GN. A number of
browser_tests that use NaCl are failing under ASAN, so
we disable NaCl for now.
This affects:
- chromium.fyi
- ClangToTMacASan
- chromium.lkgr
- Mac ASAN Debug
- Mac ASAN Release Media
- Mac ASAN Release
- chromium.memory:
- Mac ASAN 64 Builder
- tryserver.chromium.mac:
- mac_chromium_asan_rel_ng
[email protected], [email protected], [email protected]
BUG=618468, 630322, 632059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
Review-Url: https://codereview.chromium.org/2168713003
Cr-Commit-Position: refs/heads/master@{#408345}
Add use counters for PerformanceResourceTiming size fields
We would like to measure usage of the PerformanceResourceTiming size
fields. Add a UseCounter, PerformanceResourceTimingSizes, to measure
this.
BUG=
TEST=manual, with about:histograms
Review-Url: https://codereview.chromium.org/2178853002
Cr-Commit-Position: refs/heads/master@{#408344}
Add ImeMenuBubble for ImeMenuTray.
- Creates an bubble when clicking/tapping on ImeMenuTray.
- The bubble shows the IME list and properties of the current IME.
- Adds an settings button on the bottom of the list.
- Adds ImeListView and make IMEDetailedView reuse it.
See doc: go/ime-menu-chromeos.
BUG=570761
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2185523003
Cr-Commit-Position: refs/heads/master@{#408343}
Update V8 to version 5.4.279.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ff79f437..b634291e
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2190853002
Cr-Commit-Position: refs/heads/master@{#408342}
Add revocations from OIB and content setting
Revocations from OIB are recorded from chrome/browser/ui/website_settings/website_settings.cc
Revocations from content setting are recorded from chrome/browser/ui/webui/options/content_settings_handler.cc. Revocations are only recorded from content setting if the pattern is a valid host string with no wildcards. We also refactored GetContentSettingsMap to GetProfile and GetOTRContentSettingsMap to GetOTRProfile since we need to pass in the profile to ScopedRevocationReporter.
BUG=613883,469221
Review-Url: https://codereview.chromium.org/2180723002
Cr-Commit-Position: refs/heads/master@{#408341}
Disable flaky test AboutTracingIntegrationTest.testBasicTraceRecording on Mac
This test has been flaky on Mac10.10 and Mac10.11 Tests. See bug for links
and sample output.
BUG=632238
[email protected]
Review-Url: https://codereview.chromium.org/2192693002
Cr-Commit-Position: refs/heads/master@{#408340}
Remove warning suppression for Wexpansion-to-defined violation for Opus
The warning suppression was originally introduced in https://codereview.chromium.org/1651643002. Opus has now been updated to v1.1.3 which includes the fix.
BUG=
Review-Url: https://codereview.chromium.org/2184993002
Cr-Commit-Position: refs/heads/master@{#408339}
Add revocation reporter to permission util
A new class ScopedRevocationReporter is added to permission_util.h to replace PermissionUmaUtil::SetContentSettingAndRecordRevocation for reporting revocations.
The revocation metrics are sent when the initial resolved content setting is allow and changed when ScopedRevocationReporter is destructed.
BUG=613883,469221
Review-Url: https://codereview.chromium.org/2165733003
Cr-Commit-Position: refs/heads/master@{#408338}
Fix uv_ac_delta and uv_dc_delta parsing in vp9 parser
TEST=vp9 still works on samus
BUG=none
Review-Url: https://codereview.chromium.org/2109493002
Cr-Commit-Position: refs/heads/master@{#408337}
DevTools: Show more details on orphan heap snapshot nodes.
Review-Url: https://codereview.chromium.org/2191663003
Cr-Commit-Position: refs/heads/master@{#408336}
DevTools: Keep timeline counters graph colors independent of dark theme.
BUG=630841
Review-Url: https://codereview.chromium.org/2183543003
Cr-Commit-Position: refs/heads/master@{#408335}
DevTools: track extension instances, allow external instance resolution over runtime global object.
Review-Url: https://codereview.chromium.org/2189523002
Cr-Commit-Position: refs/heads/master@{#408334}
Add gesture type value from infobar to permission report
We are using the value of user_gesture obtained from PermissionContextBase::DecidePermission to obtain the PermissionRequestGestureType value. If user_gesture is true, we record PermissionRequestGestureType::GESTURE, otherwise PermissionRequestGestureType::NO_GESTURE.
To record PermissionIgnored, user_gesture is passed to PermissionInfobarDelegate + its subclasses.
To record other permission actions, user_gesture is passed to PermissionQueueController.
BUG=613883
Review-Url: https://codereview.chromium.org/2154033003
Cr-Commit-Position: refs/heads/master@{#408333}
Delete remaining leftover files in //device/geolocation
These were left behind by a bad revert in
https://codereview.chromium.org/2188933002. Deleting them completely
reverts the changes in https://codereview.chromium.org/2185993003, and
fixes DEPS failures on the Linux Tests bot.
BUG=612334
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2179903007
Cr-Commit-Position: refs/heads/master@{#408332}
MacViews: Fix setMarkedText in BridgedContentView to take replacementRange into account.
This CL changes setMarkedText:selectedRange:replacementRange: method implemented
by BridgedContentView to take replacementRange parameter into account. This
prevents the insertion of redudant characters by the IME, when accented
characters are input. Also, a test is added which fails on the current master.
BUG=624657
Review-Url: https://codereview.chromium.org/2177853002
Cr-Commit-Position: refs/heads/master@{#408331}
Add a helper function for allocating XPointer ranges.
BUG=624011
Review-Url: https://codereview.chromium.org/2121073002
Cr-Commit-Position: refs/heads/master@{#408330}
Add gesture type value from desktop prompt to permission report
We are using the value of user_gesture obtained from PermissionContextBase::DecidePermission to obtain the PermissionRequestGestureType value. If user_gesture is true, we record PermissionRequestGestureType::GESTURE, otherwise PermissionRequestGestureType::NO_GESTURE. PermissionRequestGestureType::UNKNOWN is used when it is not applicable.
To record PermissionIgnored, gesture type obtained from PermissionRequestImpl.
For PermissionRevoked, an UNKNOWN gesture type will be passed in since gesture type only applicable in the prompt UIs where revocations are not possible.
To record other permission actions, gesture type can be obtained from PermissionContextBase and its subclasses.
For call from media_stream_devices_controller, gesture type is set to UNKNOWN since it will be refactored into PermissionContext soon.
BUG=613883
Review-Url: https://codereview.chromium.org/2153133002
Cr-Commit-Position: refs/heads/master@{#408329}
cc: Don't use an anonymous AutoReset which just does nothing.
We want it to hold a value, so give it a variable name so it has the
expected scope!
TBR=jbauman, sunnyps
BUG=495650
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2185313002
Cr-Commit-Position: refs/heads/master@{#408328}
Use-count when SMIL animation renders a frame
To gain a better understanding of the usage of particular features of SMIL
animations, this patch adds a use counter for when a SMIL animation renders a
frame, thus creating a user-visible effect.
Review-Url: https://codereview.chromium.org/2164233002
Cr-Commit-Position: refs/heads/master@{#408327}
Updating trunk VERSION from 2810.0 to 2811.0
Cr-Commit-Position: refs/heads/master@{#408326}
Add dominicc to libxslt OWNERS.
[email protected]
BUG=604167
Review-Url: https://codereview.chromium.org/2122763003
Cr-Commit-Position: refs/heads/master@{#408325}
Roll src/third_party/catapult/ 8d0f7dbe6..53df93380 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8d0f7dbe6717..53df933806d9
$ git log 8d0f7dbe6..53df93380 --date=short --no-merges --format='%ad %ae %s'
BUG=630278
[email protected]
Review-Url: https://codereview.chromium.org/2185053004
Cr-Commit-Position: refs/heads/master@{#408324}
DevTools: do not switch to the sources panel when breakpoints are added.
Review-Url: https://codereview.chromium.org/2191673003
Cr-Commit-Position: refs/heads/master@{#408323}
[win] Fallback to registry when finding external handlers for a protocol
On windows 8 and later AssocQuery is used to find external protocol
handlers (e.g. to handle steam:// links). Prior versions use the
registry.
Some programs may not register in a way that AssocQuery recognizes, so
this change also consults the registry if AssocQuery does not return any
results.
BUG=560809
Review-Url: https://codereview.chromium.org/2172573002
Cr-Commit-Position: refs/heads/master@{#408322}
device: Change auto to not deduce raw pointers.
This patch updates the code to prevent auto deducing to a raw pointer.
[email protected]
BUG=554600
Review-Url: https://codereview.chromium.org/2108923002
Cr-Commit-Position: refs/heads/master@{#408321}
Notify WindowStateObserver when minimizing in maximized mode.
BUG=631498
TEST=covered by unittest
Review-Url: https://codereview.chromium.org/2182183002
Cr-Commit-Position: refs/heads/master@{#408320}
Convert extend-by-character-[1-6].html to use assert_selection
This patch converts "extend-by-character-[1-6].html" in "editing/selection" to
use |assert_selection()| test harness to simplify test files and consolidate
into "extend_by_character.html" to run tests faster.
This patch is a preparation of getting rid of grammar checking feature.
BUG=619452
TEST=n/a; this patch changes a test file
Review-Url: https://codereview.chromium.org/2184953002
Cr-Commit-Position: refs/heads/master@{#408319}
Try again to flip official win builders to GN.
We believe we've fixed the remaining known issues w/ the upload/
signing scripts, so it's time to try again. This affects:
- chromium.perf
- Win Builder
- official.desktop
- win
- win64
- official.desktop.continuous
- win beta
- win stable
- win trunk
- win64 trunk
(Though the beta and stable builders aren't actually affected and
won't be until they are on M54).
[email protected], [email protected], [email protected]
BUG=623659
Review-Url: https://codereview.chromium.org/2187613004
Cr-Commit-Position: refs/heads/master@{#408318}
Try again to flip Win PGO builders to GN.
This affects:
- chromium.fyi
- Chromium Win PGO Builder
- Chromium Win x64 PGO Builder
- official.desktop
- win-pgo
- win64-pgo
- tryserver.chromium.win
- win_pgo
[email protected]
BUG=605318
Review-Url: https://codereview.chromium.org/2189853002
Cr-Commit-Position: refs/heads/master@{#408317}
Re-land "Remove non-immediate core page load metrics"
This reverts commit 6ea2c7581324e29bf1106af332e3124a17562dbd.
When this patch was originally landed in
https://codereview.chromium.org/2156093002, it caused some
page load metrics browser tests to fail. Those issues have
since been addressed in
https://codereview.chromium.org/2176803002, so we're ready
to land this change again.
BUG=630549
Review-Url: https://codereview.chromium.org/2191633002
Cr-Commit-Position: refs/heads/master@{#408316}
Storage manager: Hide "Offline files" when Google Drive volume is not mounted.
The "Google Drive" volume in Files app does not always exist.
(e.g. Guest session, Supervised user, or disabled by setting.)
Showing "Offline files" in storage manager doesn't make sense in such cases and
causes a crash.
We should hide "Offline files" item when Google Drive volume doesn't exist.
BUG=629347
TEST=manually tested on a guest user and a supervised user.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2184083002
Cr-Commit-Position: refs/heads/master@{#408315}
Remove layout tests only for grammar checking
Blink does not have grammar checking, so the following layout tests for
grammar checking are removed:
editing/spelling/grammar-edit-word.html
editing/spelling/grammar-markers-hidpi.html
editing/spelling/grammar.html
editing/spelling/grammar-paste.html
editing/spelling/grammar-markers.html
BUG=619452
TEST=n/a; this patch changes a test file
Review-Url: https://codereview.chromium.org/2188703002
Cr-Commit-Position: refs/heads/master@{#408314}
WebGL 2: Fix bugs in negativetextureapi.html for Mac
BUG=631934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2182443003
Cr-Commit-Position: refs/heads/master@{#408313}
Defines IMEInfo, IMEPropertyInfo in their own file.
Adds new files to define IMEInfo & IMEPropertyInfo, which are used to be defined in ash/common/system/tray/system_tray_delegate.h, and include the separate header when needed.
BUG=570761
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2188683002
Cr-Commit-Position: refs/heads/master@{#408312}
Revert of Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown (patchset #8 id:160001 of https://codereview.chromium.org/2180253003/ )
Reason for revert:
Test failures in the changes to the ComponentCloudPolicyTest. Doh.
Original issue's description:
> Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown
>
> Changes BrowserThread::CurrentlyOn (and thus
> BrowserThreadTaskRunner::RunsTasksOnCurrentThread()) to correctly report
> a BrowserThread's association during MessageLoop destruction notification.
>
> Also adds an explicit Start() to BrowserThreadImpl as there are tests which
> call it and which incorrectly assumed base::Thread's implementation would
> call BrowserThreadImpl::StartWithOptions (which it wouldn't since the latter
> is not a virtual function.)
>
> This change provokes many tests to delete ExtensionFunction instances that
> were otherwise being leaked because UIThreadExtensionFunction::Destroy was
> incorrectly deferring destruction when run on the UI thread during shutdown.
> This in turn revealed a few small bugs which have also been fixed here.
>
> BUG=631093
> [email protected]
>
> Committed: https://crrev.com/b02da29fb9116d1a1fb4fd0476628f333ff6bd1a
> Cr-Commit-Position: refs/heads/master@{#408295}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631093
Review-Url: https://codereview.chromium.org/2186213002
Cr-Commit-Position: refs/heads/master@{#408311}
Revert changes to device/test/run_all_unittests.cc
Changes to this file were made in https://codereview.chromium.org/2185993003/.
However, they were not reverted when the remainder of that patch was reverted in
https://codereview.chromium.org/2188933002/.
This should fix the Android build.
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334
Review-Url: https://codereview.chromium.org/2185303002
Cr-Commit-Position: refs/heads/master@{#408310}
DevTools: remove hasFrontends check from inspector instrumentation.
Review-Url: https://codereview.chromium.org/2189833002
Cr-Commit-Position: refs/heads/master@{#408309}
Improve page load metrics error tracking.
This change adds a few improvements to page load metrics error tracking:
* track cases where we receive neither a commit nor a provisional load
* check if the render frame host matches first, and return early if not
* rename the UMA histogram, since tracking logic is changing and to make
its name more consistent with other internal histograms.
This also adds filtering to ignore NTP loads in the render process, now
that the render frame observer can include code in chrome/.
Review-Url: https://codereview.chromium.org/2184473005
Cr-Commit-Position: refs/heads/master@{#408308}
Move SearchProvider implementation into Blink and make it a no-op.
BUG=545585,631325
Review-Url: https://codereview.chromium.org/2177123003
Cr-Commit-Position: refs/heads/master@{#408307}
cc: Remove LayerTreeImpl::create in favor of a public constructor.
This patch removes LayerTreeImpl::create and while there also makes
a const int into an anonymous enum.
R=danakj
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2187853004
Cr-Commit-Position: refs/heads/master@{#408306}
Ensure the permissions DOMTokenList is initialized before access
The permissions DOMTokenList in the HTMLIFrameElement is lazily initialized but
we weren't initializing it before it was accessed through its accessor. This caused the
code not to work correctly in cases where the attribute is initially accessed via JS.
BUG=614608
Review-Url: https://codereview.chromium.org/2191443002
Cr-Commit-Position: refs/heads/master@{#408305}
Dont bail out of preload scanning if a appcache manifest is found
The preload scanner bails if it sees an appcache manifest in the markup.
This behavior isn't really correct, as we already wait for appcache to
be initialized before sending out any requests. Also, there could be
resources that still need to be loaded over the network.
BUG=630717
Review-Url: https://codereview.chromium.org/2187193002
Cr-Commit-Position: refs/heads/master@{#408304}
Revert of Reland: Geolocation: move from content/browser to device/ (patchset #2 id:20001 of https://codereview.chromium.org/2185993003/ )
Reason for revert:
Build failure:
FAILED: obj/device/geolocation/device_geolocation.network_location_request.obj
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\device\geolocation\device_geolocation.network_location_request.obj.rsp /c ..\..\device\geolocation\network_location_request.cc /Foobj\device\geolocation\device_geolocation.network_location_request.obj /Fdobj\device\geolocation\device_geolocation.cc.pdb
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win64_trunk\build\src\device\geolocation\network_location_request.cc(119): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
Original issue's description:
> Reland: Geolocation: move from content/browser to device/
>
> Original CL was reverted because it broke Win Gyp Component-build
> bot(s). This CL (PS2) defines the geolocation gyp component
> correctly.
>
> Original CL description ------------------------------------------------
> Geolocation: move from content/browser to device/
>
> This CL:
>
> - moves all of content/browser/geolocation to device/geolocation
> - the public geolocation files in content/common/{browser, public}
> are also relocated to device/geolocation
> - the geolocation-specific unittests are compiled into
> (already existing) device_unittests
> - adds new fancy new device/geolocation BUILD.gn and
> geolocation.gyp as well
> - makes a component of geolocation (at least for gn) and that forces
> adding geolocation_export.h (like other //device/ folders).
> - Java Geolocation files are moved as well, and a new
> geolocation_jni_registrar is added.
> - classes are moved to device namespace.
>
> All paths and include/call sites updated, DEPS, BUILD.gn files,
> gypi files etc.
>
> Some tricks:
> - can't use BrowserThread::CurrentlyOn, etc; instead, the
> task runner is cached on constructor and used for both thread
> checking and PostTask()ing (a few unittest and wifi_data_provider*
> needed that substitution).
> - GeolocationServiceContext is moved to public/cpp so it can
> be referenced from WebContentsImpl.
> - MockLocationProvider.java is also moved to device/geolocation.
>
> BUG=612334
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> [email protected]
> rationale:device/geolocation depends on dbus and this triggers
> a DEPS presubmit rule -- however, this CL adds no new dependencies,
> hence moving on in the interest of speed (and avoiding more rebases).
>
> Committed: https://crrev.com/cc322ebcb1c911072c8dc4fc38d41c1a41c426b7
> Cr-Commit-Position: refs/heads/master@{#408272}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612334
Review-Url: https://codereview.chromium.org/2188933002
Cr-Commit-Position: refs/heads/master@{#408303}
const base::TimeDelta& => base::TimeDelta in media_codec_bridge.
Per PRESUBMIT.py .
BUG=
Review-Url: https://codereview.chromium.org/2190533003
Cr-Commit-Position: refs/heads/master@{#408302}
DevTools: update transfer mode in Tracing.start when using start-up tracing
BUG=632155
This allows clients to issue Tracing.start when tracing is already running, but only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode, as Tracing.start is currently the only way to specify it.
Review-Url: https://codereview.chromium.org/2180423004
Cr-Commit-Position: refs/heads/master@{#408301}
[Chromecast] Add a custom CastMediaClient for Chromecast
It will forward MediaClient::IsSupportedVideoConfig invocations to a
shared library implementation, which will allow us to have different
codecs supported on different platforms.
BUG=477103
Review-Url: https://codereview.chromium.org/2156193003
Cr-Commit-Position: refs/heads/master@{#408300}
Disable fast/images/paint-subrect-grid.html on Win7 Debug and Win10
BUG=632000
TBR=xidachen
NOTRY=true
Review-Url: https://codereview.chromium.org/2185103003
Cr-Commit-Position: refs/heads/master@{#408299}
Remove dead WebsiteSettings accessors
WebsiteSettings::site_connection_details() and site_identity_details()
are never called, so this CL deletes them.
BUG=
Review-Url: https://codereview.chromium.org/2187153002
Cr-Commit-Position: refs/heads/master@{#408298}
[Layout API] Add Frame::ownerLayoutItem() and use in FrameView
Direct access to LayoutPart is deprecated and being removed soon. The
replacement is LayoutPartItem, which routes methods through the new
block layout API. (See linked crbug for details.) I added several
methods to api/LayoutBoxModel.h and api/LayoutPartItem.h which proxy
to the underlying layout objects. These proxies disappear during
linking, so there is no performance penalty.
There are no functional changes.
BUG=499321
Review-Url: https://codereview.chromium.org/2191623002
Cr-Commit-Position: refs/heads/master@{#408297}
[libfuzzer] extracting common setup utility, fixing leaks
BUG=
Review-Url: https://codereview.chromium.org/2187133002
Cr-Commit-Position: refs/heads/master@{#408296}
Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown
Changes BrowserThread::CurrentlyOn (and thus
BrowserThreadTaskRunner::RunsTasksOnCurrentThread()) to correctly report
a BrowserThread's association during MessageLoop destruction notification.
Also adds an explicit Start() to BrowserThreadImpl as there are tests which
call it and which incorrectly assumed base::Thread's implementation would
call BrowserThreadImpl::StartWithOptions (which it wouldn't since the latter
is not a virtual function.)
This change provokes many tests to delete ExtensionFunction instances that
were otherwise being leaked because UIThreadExtensionFunction::Destroy was
incorrectly deferring destruction when run on the UI thread during shutdown.
This in turn revealed a few small bugs which have also been fixed here.
BUG=631093
[email protected]
Review-Url: https://codereview.chromium.org/2180253003
Cr-Commit-Position: refs/heads/master@{#408295}