Publish DEPS for Chromium 53.0.2785.92
Incrementing VERSION to 53.0.2785.92
Cr-Commit-Position: refs/branch-heads/2785@{#807}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ )
Reason for revert:
Breaks icons on deb packages
Original issue's description:
> Support relocatable RPM packages
>
> BUG=31519
>
> Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
> Cr-Commit-Position: refs/heads/master@{#402666}
[email protected]
BUG=642953
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2299093002
Review-Url: https://codereview.chromium.org/2299273002
Cr-Original-Commit-Position: refs/heads/master@{#415840}
Cr-Commit-Position: refs/branch-heads/2785@{#806}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.91
Cr-Commit-Position: refs/branch-heads/2785@{#805}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix the T-Rex easter egg on iOS.
In this CL:
- Always supply a user agent to WKWebViews in web//'s creation methods.
This allows the IS_IOS variable in offline.js to be correctly set to
true.
- Delay initializing the game runner until after images have been
loaded.
- Check for existence of errorPageController when activating the game.
BUG=none
Review-Url: https://codereview.chromium.org/2144933002
Cr-Commit-Position: refs/heads/master@{#406949}
(cherry picked from commit 068ace2593da95f2f47b20432e02e8d1e3706807)
Review URL: https://codereview.chromium.org/2298593006 .
Cr-Commit-Position: refs/branch-heads/2785@{#804}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Disallow WKBackForwardListItem navigations for pushState pages.
The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.
BUG=none
Review-Url: https://codereview.chromium.org/2292773002
Cr-Commit-Position: refs/heads/master@{#415114}
(cherry picked from commit 540983ab54c3259bb9b548bfd8c1d95367fa15f2)
Review URL: https://codereview.chromium.org/2298093004 .
Cr-Commit-Position: refs/branch-heads/2785@{#803}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Fix advertised uuid
device->GetUUIDs() is the correct way to get the advertised uuid
for recreate advertise data.
BUG=None
TEST=Build
Review-Url: https://codereview.chromium.org/2244703005
Cr-Commit-Position: refs/heads/master@{#412065}
(cherry picked from commit 6de80cb2538a41d1144cae3622011ee2e17c1119)
Review URL: https://codereview.chromium.org/2297383002 .
Cr-Commit-Position: refs/branch-heads/2785@{#802}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Work around PanGestureRecognizer iOS10 issue.
In iOS10, sometimes a PanGestureRecognizer will fire a touchesMoved even
after touchesBegan sets its state to |UIGestureRecognizerStateFailed|.
Somehow the state is re-set to UIGestureRecognizerStatePossible, and ends
up in moved. Checking if |_startPoint| has been set is a secondary way to
catch for failed gestures. It appears setting failed in touchesMoved still always
works -- this issue only seems to be related to setting Failure in touchesBegan,
and only sometimes.
BUG=640611
Review-Url: https://codereview.chromium.org/2281303002
Cr-Commit-Position: refs/heads/master@{#415004}
(cherry picked from commit 95144337ab1af223377554b7ca838de787d8080e)
Review URL: https://codereview.chromium.org/2294223004 .
Cr-Commit-Position: refs/branch-heads/2785@{#801}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Apply blue filter to selection handles on 53 branch.
A bad version of the support library on M53 is both overriding the
system theme handles with the Material Design handles, and also on pre-L
only, making them appear white instead of blue (only in the way we load
them in the content area). The former bug is only a P2 bug, but the
latter makes the handles almost invisible on a white background.
This patch simply applies a color filter to blast the appropriate
Material Design blue on all opaque pixels, while leaving transparent
pixels untouched. This fixes the white handles on pre-L while having no
visible effect on L+. It also deletes the "fast path" handle loading
code (since we need to create a Canvas and Drawable anyway to apply the
filter), which is a pretty negligible optimization anyway (only avoids
one-time transient allocation of small bitmaps).
BUG=640764
[email protected]
Review URL: https://codereview.chromium.org/2298643002 .
Cr-Commit-Position: refs/branch-heads/2785@{#800}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.90
Cr-Commit-Position: refs/branch-heads/2785@{#799}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Do not call LayerAnimator::SetOpacity if the new value is same as the target value.
I think this is safer to merge than https://codereview.chromium.org/2291923002/. I'll remove the check once the bug 64223 is fixed.
BUG=642222
Review-Url: https://codereview.chromium.org/2291933002
Cr-Commit-Position: refs/heads/master@{#415341}
(cherry picked from commit b0bddce1bad52c3efbe224c08a43fe02bf95cda3)
Review URL: https://codereview.chromium.org/2297983002 .
Cr-Commit-Position: refs/branch-heads/2785@{#798}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix conflicting PendingIntent for stop button and swipe away
Notification PendingIntents having the same name will conflict
with each other. This CL fixes the conflict for MediaNotification
stop button and swipe away, which now fire different actions but
we treat both as ACTION_STOP.
BUG=640301
(cherry picked from commit 07812a287530bb8629718c2777b07d85c5a51e6a)
Review-Url: https://codereview.chromium.org/2279263002
Cr-Original-Commit-Position: refs/heads/master@{#414754}
Cr-Commit-Position: refs/branch-heads/2785@{#797}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.89
Cr-Commit-Position: refs/branch-heads/2785@{#796}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Cherry-pick r415013 to M53.
TBR=wkorman
Ref: https://codereview.chromium.org/2271883002
BUG=635724
Review URL: https://codereview.chromium.org/2292353003 .
Cr-Commit-Position: refs/branch-heads/2785@{#795}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
exo: Avoid creating transparent texture quads.
The surface is fully transparent when alpha is 0 and we can then
avoid to create a texture quad completely. Failing to do so
currently results in unnecessary compositing.
BUG=640805
TEST=exo_unittests
Review-Url: https://codereview.chromium.org/2277833004
Cr-Commit-Position: refs/heads/master@{#414220}
(cherry picked from commit e2d54b85fbc32bd0d19e1741677a296e25fd47c7)
Review URL: https://codereview.chromium.org/2293223002 .
Cr-Commit-Position: refs/branch-heads/2785@{#794}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Disable pin unlock for m53 only.
See https://codereview.chromium.org/2280633003/.
BUG=639977
(cherry picked from commit c897cc67701a2f04cc4554d41a0ad39ff9bd61df)
Review URL: https://codereview.chromium.org/2289393002 .
Cr-Commit-Position: refs/branch-heads/2785@{#793}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Updating XTBs based on .GRDs from branch 2785
Cr-Commit-Position: refs/branch-heads/2785@{#792}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix jank on Android due to bad scheduler deadline
https://codereview.chromium.org/1821863002 changed the display scheduler
on Android to use the CompositorImpl ExternalBeginFrameSource directly
instead of a synthetic BeginFrameSource that had its vsync parameters
set from WindowAndroidCompositor::OnVSync.
The frame time given to the display scheduler is always in the past,
which made the past logic always give an immediate deadline, causing
the display scheduler to run immediately. Fix this by providing a
correct deadline in the future.
This fixes bad jank where the display scheduler would never give any
other compositors time to give frames. So, if the browser compositor
was producing frames (such as a loading spinner) then the renderer
frames would be extremely janky as they would often miss the immediate
(incorrect) deadline.
BUG=613193
[email protected]
(cherry picked from commit ab408ac5e81ddf37772a9410cec2b7f747973a2d)
Review-Url: https://codereview.chromium.org/2275253003
Cr-Original-Commit-Position: refs/heads/master@{#414765}
Cr-Commit-Position: refs/branch-heads/2785@{#791}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Ignore reentrancy for ImeThread triggering
In the delayed activation of input connection, we call requestFocus()
on proxy view, and this triggers HwSecImmHelper.isPasswordInputType()
on Huawei phone, which in turn calls View#onCreateInputConnection() so
there is an infinite loop, which eventually causes stackoverflow.
Presumably isPasswordInputType() is only concerned about whether
onCreateInputConnection()'s outAttrs.inputType is password type or not,
so we fill out outAttrs.inputType and early out when there is a reentrance.
BUG=636197
(cherry picked from commit f5feceb259130400bc3f05826c8bc625f3399794)
Review-Url: https://codereview.chromium.org/2246833002
Cr-Original-Commit-Position: refs/heads/master@{#415220}
Cr-Commit-Position: refs/branch-heads/2785@{#790}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Change "Read it later" to "Keep tab in" in Custom Tabs
BUG=642131
[email protected]
Review URL: https://codereview.chromium.org/2291843002 .
Cr-Commit-Position: refs/heads/master@{#415048}
(cherry picked from commit ba030277053e6bd7d5bc948a6a15094d00b8c705)
Review URL: https://codereview.chromium.org/2289253002 .
Cr-Commit-Position: refs/branch-heads/2785@{#789}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.88
Cr-Commit-Position: refs/branch-heads/2785@{#788}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
HSTS preload list removals for Chrome 54.
ecosystem.atlassian.net:
Covered by atlassian.net
redbee.nl:
> We cannot support HTTPS on the following subdomains:
> • staging.schoolwijzer.redbee.nl - Customer staging environment, out of
> our control and just for testing purposes.
cerfrance.fr:
> We cannot support HTTPS on the following subdomains:
> • link.85.cerfrance.fr – use by a email marketing service (sarbacane)
> • link.cn.cerfrance.fr – use by a email marketing service (sarbacane)
spacecompute.com:
> I have no idea how this happened, since I never submitted the domain, but I
> would like to remove it because unfortunately it's breaking some services that
> integrate with google apps -- which it turns out do not play well with HTTPS
> requests.
ptsoft.de:
> We cannot support HTTPS on the following subdomains:
>
> • dm8000.ptsoft.de - Forwarding to internal server
> • config.ptsoft.de - Forwarding to internal server
everythingkitchens.com:
[15 subdomains] hosted on separate server than main domain
hilti.com, etc. (25 hilti.{eTLD} domains):
internal systems with same domain hilti.com do not all support https yet
souyidai.com:
> We cannot support HTTPS on the following subdomains:
> • mail.souyidai.com - cooperation with other company
nitho.me:
> I am afraid that it due to that blindly following online tutorial.
hovie.at:
> We cannot support HTTPS on the following subdomains:
>
> • andrew.hovie.at - I don't have to time to manage my own server
> anymore, so I switched to a hosting provider, wildcard certs are
> expensive, they do not support certs with multiple domains.
>
> Also, when I enabled preload, I did not actually know what I am doing,
> I was just following the recommendation from https://cipherli.st/.
constructdigital.net:
> We cannot support HTTPS on all sub-subdomains, since we don't have a wildcard
> SSL for them. Also, this domain is meant for development purpose and was
> configured as HSTS preload by mistake.
groovinads.com:
> We cannot support HTTPS on the following subdomains:
> • my.groovinads.com - Appnexus does not handshake over https, and it's killing us.
> • groovinads.com - same as above
> • *.groovinads.com
shamka.ru:
> We cannot support HTTPS on the following subdomains:
>
> • [water] - don’t have ssl cert.
> • [w] - not open 443 port
> • and many new subdomains
terravirtua.com:
> chalk it up to copy-pasting something without fully understanding what i was
> doing... i had added that after doing the ssl checker, following a
> recommendation about increasing the 'grade' it returned. i later removed it
> (the whole HSTS header) only to discover that everything continued to redirect
> to https... and finally realizing i was preloaded.
domainkauf.de:
> We support HTTPS in another way and so we have problems with the following
> subdomains:
> • mail.domainkauf.de HTTP Redirect to the main mailserver
> • imap /smtp / pop / pop3 / webmail with same reason
internl.net:
Uses uniquely generated domains per user with second-level subdomains, e.g. www.*.pa.internl.net; this can't be handled using wildcard certs.
rinobroer.nl:
No citable reason given.
sexton.uk.com:
> We cannot support HTTPS on the following subdomains:
>
> • mail.sexton.uk.com - costs for multiple SSL or SAN cert
> • webmail.sexton.uk.com - costs for multiple SSL or SAN cert
extracobanks.com:
> We cannot support HTTPS on the following subdomains:
>
> • Various internal subdomains - Although our external website,
> www.extracobanks.com, exclusively uses HTTPS, we also use extracobanks.com as
> our internal domain. Having extracobanks.com on the HSTS preload list is
> causing problems for our employees connecting to internal sites, such as our
> internal CRM that uses a self-signed certificate. Chrome and Firefox are
> giving "certificate authority invalid" errors when connecting to these
> internal subdomains. We also have some non-HTTPS 3rd party vendor provided
> internal sites that cannot be changed to HTTPS that we cannot connect to at
> all.
>
> Our www.extracobanks.com site was built and is managed by a 3rd party
> Marketing firm. I'm sure they added the HSTS header with the best intentions,
> but it is causing issues for us internally with our employees.
intramanager.co.uk/intramanager.dk:
> We cannot support HTTPS on the domain, since we changed our whole SSL setup
> and therefore do not support HTTPS on the intramanager.co.uk
> [/intramanager.dk] domain anymore.
>
> We have moved all activity to intramanager.com, where we have full HTTPS
> support.
thekelvinliu.com:
> I have a Tumblr blog at blog.thekelvinliu.com, which does not support https.
h-neef.de:
> We cannot support HTTPS on the whole Domain including subdomains, because we
> moved to a new IP Address and Need it for test purposes!
nathancheek.com:
> I never intended to be preloaded, nor to include subdomains, but I made the
> mistake of adding ‘preload’ and 'includeSubDomains’ to the HSTS header,
> without understanding what they entailed.
mercurystorm.co.za:
> I have moved from a Virtual Private Server to shared hosting, and can no
> longer use SSL certificates
klaxn.com:
> my client is not able to pay for a SSL certificate
postpi.com:
> self signed certificate
stupus.com:
> We cannot always support HTTPS on the all of our subdomains.
> ...
> I can no longer always support HTTPS on my domain because I change server
> distributions frequently.
upstox.com:
> We cannot support HTTPS on the following subdomain:
>
> help.upstox.com -> We are using this domain to point help.rksv.in with CNAME
> record and for rksv.in domain we don't have Wildcard SSL certificate so
> whenever we open help.upstox.com it goes to HTTPS in chrome.
[email protected]
BUG=527947, 641449
Review URL: https://codereview.chromium.org/2113813002 .
Cr-Commit-Position: refs/heads/master@{#414299}
(cherry picked from commit c2ed5d4ef0dc5dbb94240dadb56a08c2a3f7c9b0)
Review URL: https://codereview.chromium.org/2290103002 .
Cr-Commit-Position: refs/branch-heads/2785@{#787}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix security icon colors on light themes
Security icon colors on Chrome for Android and Chrome Custom Tabs should
be as follows:
1. Default toolbar color => green lock/red triangle
2. Dark toolbar color => white icons
3. Light toolbar color with opaque omnibox => green/red
4. Other toolbar color with transparent omnibox => dark icons
BUG=633736
TEST=On Chrome for Android, visit the following URLs and observe the
given security icon colors:
1. https://google.com => green lock
2. https://yahoo.com => white lock
3. https://just-skyline-137219.appspot.com/lightblue => opaque omnibox
with green lock
4. https://garron.net/test/theme-color/?color=%2300ffff => transparent
omnibox with dark lock
In a CCT client app, set the toolbar color to the following colors and then visit https://www.google.com:
1. Default => green lock
2. #ef6c00 => white lock
3. #ffffcc => dark lock
4. #66ffff => dark lock
Review-Url: https://codereview.chromium.org/2274973004
Cr-Commit-Position: refs/heads/master@{#414897}
(cherry picked from commit cf4299907423c27d40182d17099d54a2e97e154c)
Review URL: https://codereview.chromium.org/2290953002 .
Cr-Commit-Position: refs/branch-heads/2785@{#786}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert "[Android]Use zh instead of zh-rTW as output folder of zh_TW translation"
This reverts commit 21571ae1ee47d614541f814bd98dfbd71f561dbc, which was
committed in M52.
Reason for revert: in android N, locale is defined in finer granularity,
and simply falling back to zh will no longer work.
BUG=641852
Previously reviewed in https://codereview.chromium.org/1931093002
[email protected]
[email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/2280143002 .
Review URL: https://codereview.chromium.org/2293753002 .
Cr-Original-Commit-Position: refs/heads/master@{#415045}
Cr-Commit-Position: refs/branch-heads/2785@{#785}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.87
Cr-Commit-Position: refs/branch-heads/2785@{#784}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Updating XTBs based on .GRDs from branch 2785
Cr-Commit-Position: refs/branch-heads/2785@{#783}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Android] Add user actions for bookmark manager creation
When checking the recent data about bookmark opening stats, we found a
mystery that is hard to explain: the number of bookmark open is larger
than the number of bookmark manager open on phones. This CL adds some
extra loggings to the bookmark code to seek definite answer to this
mystery.
BUG=639512
Review-Url: https://codereview.chromium.org/2266633002
Cr-Commit-Position: refs/heads/master@{#413456}
(cherry picked from commit c1d960f82e7bb779979e5cd4b3f8c3bae9b3b6c7)
Review URL: https://codereview.chromium.org/2290783002 .
Cr-Commit-Position: refs/branch-heads/2785@{#782}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Don't play new animation on external intents
Playing this animation right after the task transition animation
causes a lot of jank. Removing it for external intents.
BUG=641592
Review URL: https://codereview.chromium.org/2289913002 .
Cr-Commit-Position: refs/branch-heads/2785@{#781}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Update the cached WindowAndroid in PermissionInfobar after reparenting
WindowAndroid object is cached in PermissionInfobars, and the object is
not updated since their creation. Yet after reparenting, WindowAndroid
has changed. This CL fixes this issue by adding a new public call,
onTabReparented() to Infobar.java
BUG=632477
Review-Url: https://codereview.chromium.org/2282953003
Cr-Commit-Position: refs/heads/master@{#414849}
[email protected]
Review URL: https://codereview.chromium.org/2282253002 .
Cr-Commit-Position: refs/branch-heads/2785@{#780}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix nullptr dereference in service catalog
ProcessManifest can return null in a few failure modes.
This result gets passed into Reader::OnReadManifest which
was doing no null checking. This fixes that.
BUG=632916
[email protected]
Review-Url: https://codereview.chromium.org/2284843002
Cr-Commit-Position: refs/heads/master@{#414769}
(cherry picked from commit 3d1a0f65aa799880b017881b5b5e0f14e958cb74)
BUG=632916
Review URL: https://codereview.chromium.org/2294443002 .
Cr-Commit-Position: refs/branch-heads/2785@{#779}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to M53] No initial focusing of buttons in the message center bubble
Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/view?usp=sharing]
[email protected]
BUG=620801
Review-Url: https://codereview.chromium.org/2281983002
Cr-Commit-Position: refs/heads/master@{#414779}
(cherry picked from commit 910a888e51a6544f8092e748166173bf13af32b1)
Review URL: https://codereview.chromium.org/2293563002 .
Cr-Commit-Position: refs/branch-heads/2785@{#778}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix document mode migration.
There is an old tab_state file in the tabbed mode state directory. If
it is not deleted and the new tab state is written to the new
tab_state0 file, then when it comes time to run the migration code in
TabPersistentStore the old tab_state file will be given preference
and overwrite the new one with all the document mode tabs that were
just migrated. Thus we need to delete the old tab_state file if it
exists.
BUG=640625
Review-Url: https://codereview.chromium.org/2274943002
Cr-Commit-Position: refs/heads/master@{#414194}
(cherry picked from commit 9df9c7815b45e142c29162e02ddcdd8f411ec703)
Review URL: https://codereview.chromium.org/2290633002 .
Cr-Commit-Position: refs/branch-heads/2785@{#777}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Don't retry fetching policies if it's a blocking operation, don't wait if we will bypass the proxy next time.
BUG=639822
Review-Url: https://codereview.chromium.org/2275553002
Cr-Commit-Position: refs/heads/master@{#414055}
(cherry picked from commit d3ff97fdea62ba0b09a06cf4f730f92b151a2c58)
Review URL: https://codereview.chromium.org/2285233002 .
Cr-Commit-Position: refs/branch-heads/2785@{#776}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.86
Cr-Commit-Position: refs/branch-heads/2785@{#775}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Return null when selected text is empty
InputConnection#getSelectedText() should return null when the selection
is empty. ThreadedInputConnection was not doing this correctly, and confused
some OEM keyboards.
BUG=638201
Review-Url: https://codereview.chromium.org/2279293002
Cr-Commit-Position: refs/heads/master@{#414821}
(cherry picked from commit fe62ee1b4b965d3c63bee8f2d0df160ae4529ae0)
Review URL: https://codereview.chromium.org/2280423002 .
Cr-Commit-Position: refs/branch-heads/2785@{#774}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.85
Cr-Commit-Position: refs/branch-heads/2785@{#773}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix build dependence for data_reduction_proxy
This CL fixes a dependence problem for building data_reduction_proxy with gyp.
BUG=625030
Review-Url: https://codereview.chromium.org/2111913004
Cr-Commit-Position: refs/heads/master@{#403445}
(cherry picked from commit 1ec6ed740a07768d0bbcb70605b576fea4edb8e7)
Review URL: https://codereview.chromium.org/2287823002 .
Cr-Commit-Position: refs/branch-heads/2785@{#772}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.84
Cr-Commit-Position: refs/branch-heads/2785@{#771}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Accelerometer: find trigger name
Do not assume the sysfs trigger to use is trigger0. Instead find the
trigger which name is "sysfstrig0". This is the name used by
accelerometer-init.sh udev script.
BUG=chromium:632486
TEST=With proper accelerometer-init.sh, check that chrome rotate screen
even when cros-ec-ring driver is loaded.
NOTRY=true
NOPRESUBMIT=true
[email protected]
Signed-off-by: Gwendal Grignou <[email protected]>
Review-Url: https://codereview.chromium.org/2198543002
Cr-Commit-Position: refs/heads/master@{#410407}
(cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014)
Review-Url: https://codereview.chromium.org/2277133002
Cr-Commit-Position: refs/branch-heads/2785@{#770}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[DevTools] Improve ConsoleAPI functions string description
BUG=638742
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2269843002/
Cr-Commit-Position: refs/heads/master@{#413968}
(cherry picked from commit 149d9e717953a1979d186a99ef7075e184253bd7)
Review URL: https://codereview.chromium.org/2280993003 .
Cr-Commit-Position: refs/branch-heads/2785@{#769}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[DevTools] Copy objects from debugger context to inspected context properly.
BUG=637594
Review-Url: https://codereview.chromium.org/2253643002
Cr-Commit-Position: refs/heads/master@{#412436}
(cherry picked from commit 93bc623489bdcfc7e9127614fcfb3258edf3f0f9)
[email protected]
Review URL: https://codereview.chromium.org/2284873002 .
Cr-Commit-Position: refs/branch-heads/2785@{#768}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix background of overflow shelf icon
BUG=640642
TEST=Add shelf icons and/or increase zoom until shelf overflows.
Observe that background of overflow button is square, not round.
Review-Url: https://codereview.chromium.org/2277523004
Cr-Commit-Position: refs/heads/master@{#414501}
(cherry picked from commit cc77d07303f42212610e01d7fac2e8e4dd01647a)
Review URL: https://codereview.chromium.org/2287753002 .
Cr-Commit-Position: refs/branch-heads/2785@{#767}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Cherrypick Bugfix for cross-origin check
The code is mistaking a missing reader for an error, but readers are now destroyed and re-created on demand.
Adding a new variable to explicitly track failures fixes the problem.
Original commit: https://crrev.com/5f8b274cdab547c8afff5429110a97d15353c19c
BUG=639690
Review URL: https://codereview.chromium.org/2283153002 .
Cr-Commit-Position: refs/branch-heads/2785@{#766}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
DevTools: Use stableSort for async events
Async events may have identicatl start and end time.
Also make sure async events go the the right strip, not to input one.
BUG=640652
Review-Url: https://codereview.chromium.org/2276743004
Cr-Commit-Position: refs/heads/master@{#414506}
(cherry picked from commit 7465824d77013dd37242713c7a2520be2b718345)
Review URL: https://codereview.chromium.org/2283143002 .
Cr-Commit-Position: refs/branch-heads/2785@{#765}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of conflicts resolved (patchset #1 id:1 of https://codereview.chromium.org/2280173002/ )
Reason for revert:
breaks build (bad merge)
Original issue's description:
> conflicts resolved
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/63dd2d9cfe0f30d08fbd6db291b62b8aa5041b5b
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2281143003
Cr-Commit-Position: refs/branch-heads/2785@{#764}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Update widget bounds after ScopedConfigure
ScopedConfigure suppress the UpdateWidgetBounds which results in the inconsistent shadow because
* the shadow bounds gets updated with the stale bounds in OnPostWindowStateTypeChanged
* then the widget bounds is updated in the UpdateWidgetBounds in ScopedConfigure dtor
BUG=b/30961411
[email protected]
Review-Url: https://codereview.chromium.org/2277463004
Cr-Commit-Position: refs/heads/master@{#414065}
(cherry picked from commit ab5745b24dd0536f27b2b4ad6160d474c77491e7)
Review URL: https://codereview.chromium.org/2286953002 .
Cr-Commit-Position: refs/branch-heads/2785@{#763}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
conflicts resolved
BUG=
Review URL: https://codereview.chromium.org/2280173002 .
Cr-Commit-Position: refs/branch-heads/2785@{#762}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
IndexedDB: Avoid side effects by evaluating key paths w/ HasOwnProperty
Although key path evaluation is always done against clones (so getters
are flattened into simple data properties), property lookups were
not restricted to inherited properties, allowing getters on prototypes
to be executed. This allows evaluation to be observable, and cause
side effects.
Restrict the lookup to own properties, and introduce special-case code
for those non-own values identified in the spec[1] as special cases.
[1] https://w3c.github.io/IndexedDB/#key-path-construct
BUG=637963
[email protected]
Review-Url: https://codereview.chromium.org/2255413004
Cr-Commit-Position: refs/heads/master@{#414170}
(cherry picked from commit fb18204c77e3f6e43ce05dd3ce24f00e0201bac1)
Review URL: https://codereview.chromium.org/2283023002 .
Cr-Commit-Position: refs/branch-heads/2785@{#761}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert "Android: Fix some tab placeholder/thumbnail readbacks"
This reverts commit d16f09b680e4baabb5fb4a3e34fe23f888d39683 or
essentially merges https://codereview.chromium.org/2279113002/
BUG=640561
Review URL: https://codereview.chromium.org/2282053003 .
Cr-Commit-Position: refs/branch-heads/2785@{#760}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M53] Disable unified media pipeline (Spitzer) for Webview for PowerVR
The function eglCreateImageKHR() seems to fail on this GPU
for L8 textures which results in YUV->RGB conversion failures.
EGLImage is used for Spitzer in WebView.
BUG=632461
TBR=timav
> Review-Url: https://codereview.chromium.org/2281663002
> Cr-Commit-Position: refs/heads/master@{#414629}
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/2282983002 .
Cr-Commit-Position: refs/branch-heads/2785@{#759}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Do not initialize gestureconfiguration in renderer process
When multiprocess is enabled for webview, do not initialize
gesture configuration in renderer process as this eventually
leads to accessing Window Manager Service.
BUG=640379
Bug: b/31045266
Review-Url: https://codereview.chromium.org/2272703008
Cr-Commit-Position: refs/heads/master@{#414445}
(cherry picked from commit 2fc863f2c7fc232b37c9ced79ca6493bba498ed9)
Review URL: https://codereview.chromium.org/2283863002 .
Cr-Commit-Position: refs/branch-heads/2785@{#758}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.83
Cr-Commit-Position: refs/branch-heads/2785@{#757}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Remove extraneous base::debug::DumpWithoutCrashing call.
This is needed to fix the compile error introduced by 4ab88c96e291c275b3c0801aaffe13f124dd427d.
BUG=641233
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
[email protected]
Review URL: https://codereview.chromium.org/2285653002 .
Cr-Commit-Position: refs/branch-heads/2785@{#756}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Ensure FrameNavigationEntry is fully updated.
Currently RendererDidNavigateToExistingPage and RendererDidNavigateToSamePage
only partially update the FrameNavigationEntry for the committing
navigation. This leads to inconsistency between sequence numbers and
PageState, which can cause origin/URL mismatches.
This CL updates both these methods to call AddOrUpdateFrameEntry to
ensure that all members are properly updated.
BUG=630103, 628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2224213005
Cr-Commit-Position: refs/heads/master@{#411224}
(cherry picked from commit af18219268a332a92b3c8bbaa306aade92142c55)
[email protected]
Review URL: https://codereview.chromium.org/2284533002 .
Cr-Commit-Position: refs/branch-heads/2785@{#755}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.82
Cr-Commit-Position: refs/branch-heads/2785@{#754}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Delay setting the compositor view background to null on N
We set compositor view background to white while there are no
frames and onSwapBufferCompleted swap it back to null. On N
this creates a black flash on some cold starts where there is
still a frame that is drawn before the frame is actually completed.
BUG=640758
Review URL: https://codereview.chromium.org/2281593003 .
Cr-Commit-Position: refs/branch-heads/2785@{#753}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge "arc: Update notification close button image"
> Update the close button image and fix tapping-not-working issue
> since making changes to the file.
>
> BUG=640399
> BUG=b/30814819
> BUG=b/30917629
> TEST=Manual. Verify new close button image on arc notifications.
> And tapping to close works.
>
> Review-Url: https://codereview.chromium.org/2269143004
> Cr-Commit-Position: refs/heads/master@{#414188}
> (cherry picked from commit a9d42b7e1ef639e0a29462046e543561ca37230a)
Review URL: https://codereview.chromium.org/2273133003 .
Cr-Commit-Position: refs/branch-heads/2785@{#752}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Media Router WebUI] Use updated sink on click
Since crrev.com/2221933003, the dom-repeat element that creates the sink
list doesn't seem to correctly update its element-item mapping. Instead
we will use the most current sink object with the same ID in our own
map.
BUG=637222
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2252313002
Cr-Commit-Position: refs/heads/master@{#413573}
(cherry picked from commit 7e3c3e80f15d513f9c2fe7a59b1854c7e1ff47e9)
Review URL: https://codereview.chromium.org/2278723006 .
Cr-Commit-Position: refs/branch-heads/2785@{#751}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Update the generated public suffix file
Commit 702d65e434b5a41965f5b9fbe644e9e4300157b6
updated the underlying data file, but the
generated .gperf file was not re-generated because
I forgot to run net/tools/tld_cleanup on it.
TBR'ing because it's a file derived from the
already reviewed CL.
[email protected]
BUG=626532, 639677
Review-Url: https://codereview.chromium.org/2263923002
Cr-Commit-Position: refs/heads/master@{#413380}
(cherry picked from commit a16e791c295658f7253f30ab7680ce74b7e0b93b)
Review URL: https://codereview.chromium.org/2270193005 .
Cr-Commit-Position: refs/branch-heads/2785@{#750}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
StringBuilder::append should not use reserveCapacity.
reserveCapacity allocates the exact capacity specified which means
when we had a 16bit buffer in StringBuilder and were appending 8bit
strings to it we were constantly reallocating and copying the buffer.
Instead we can just call Vector::append() directly since it has a
template overload that can accept implicitly convertible types.
I noticed this when looking at lever.co's web app loading in
Instruments, it was spending 15% of the main thread time inside
TextResource::decodedText which was 83% memmove, and 11% munmap.
Switching to Vector::append should restore the correct size
doubling behavior when appending LChars to a UChar StringBuilder
and make this much faster.
This was a regression from when I switched to using a Vector
inside StringBuilder in:
https://codereview.chromium.org/2046353002
Review-Url: https://codereview.chromium.org/2192293002
Cr-Commit-Position: refs/heads/master@{#408869}
(cherry picked from commit 25fdbad21c66328e5ada9b9b436d3a8c146ca728)
BUG=640598
[email protected]
Review URL: https://codereview.chromium.org/2280723002 .
Cr-Commit-Position: refs/branch-heads/2785@{#749}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Makes the IME APIs available for beta/stable channels.
BUG=607425,517773
Review-Url: https://codereview.chromium.org/1925983002
Cr-Commit-Position: refs/heads/master@{#414313}
(cherry picked from commit 3f9aaee9da59138d3bde342bff4d18011694ef5f)
Review URL: https://codereview.chromium.org/2276303002 .
Cr-Commit-Position: refs/branch-heads/2785@{#748}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge] Do reconfigure the font cascade list for the Emoji font
The previous fix for for issue 576941 and issue 625902 seems to have
caused a spike in crash rate in _hb_coretext_shape on OS X 10.9.5. The
CoreText bug seems to be around font fallback in the CTTypeSetter and
very sensitive to what the cascade list (i.e. the font fallback list for
CoreText) looks like.
Reproduction URLs and reduction in issue 549610 shows that at least for
the emoji font, we increase the crash rate if we do not reconfigure the
cascade list for the "Apple Color Emoji" font. So in this CL, we address
this by skipping cascade list reconfiguration on OS X 10.9.5 only if the
font is not the emoji font.
This might not cover all situations in which CoreText crashes at this
point but should help with the spike in crash rates.
BUG=549610
Review-Url: https://codereview.chromium.org/2270033002
Cr-Commit-Position: refs/heads/master@{#413788}
(cherry picked from commit 4b7b8c5693a2ffcc4f91c9e41b464ee6db7cb2f5)
Review URL: https://codereview.chromium.org/2280573002 .
Cr-Commit-Position: refs/branch-heads/2785@{#747}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Migrate ArcUserDataService into ArcAuthService.
There are race problems around data removing.
One of the cause is that state management is done in
ArcAuthService and ArcUserDataService separately.
This CL migrates ArcUserDataService into ArcAuthService
so that we can remove the data when necessary.
BUG=633258, 636218
TEST=Ran manually.
- "Enable -> ARC boot wait -> Disable" triggers data removal after
ARC stop.
- "Enable -> Disable before ARC boot" triggers immediate data
removal.
- "Enable -> ARC boot wait -> Kill ARC instance" does not trigger
data removal.
NOTRY=true
NOPRESUBMIT=true
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2209173002
Cr-Commit-Position: refs/heads/master@{#411923}
(cherry picked from commit 6d95ad318e992261c45f5a88a0a599663a6d66ae)
Review-Url: https://codereview.chromium.org/2261653002
Cr-Commit-Position: refs/branch-heads/2785@{#746}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Plugin Power Saver Tiny: Add Blocked Plugin Icon Metrics
Adds the ContentSettings.Plugins UMA Histogram.
BUG=634991
Review-Url: https://codereview.chromium.org/2268423002
Cr-Commit-Position: refs/heads/master@{#414137}
(cherry picked from commit c140294cd38d463d170fc0fc0166984933c1cdcb)
Review URL: https://codereview.chromium.org/2275183002 .
Cr-Commit-Position: refs/branch-heads/2785@{#745}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.81
Cr-Commit-Position: refs/branch-heads/2785@{#744}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Fix appearing duplicate icons in recent.
Filter out Arc apps that should not come to Arc app list
search result.
TEST=Manually
BUG=640253
BUG=b/30977618
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2270733003
Cr-Commit-Position: refs/heads/master@{#413819}
(cherry picked from commit 4b6f8dc28e19c486554dba2bc8855781cd724ca5)
Review-Url: https://codereview.chromium.org/2272003003
Cr-Commit-Position: refs/branch-heads/2785@{#743}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Enable arrow keys advancing focus in Oobe for CFM mode
This solution is a hybrid solution:
1) on eula screen, we are using EventRewriter to rewrite shift-arrow key events to tab/shift-tab events.
2) otherwise, when keyboard_utils.js receiving keydown arrow key event, translating it to tab/shift-tab events on C++ side.
BUG=626475
NOPRESUBMIT=true
TEST=tested on desktop build, CFM workflow works on arrow keys now.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2223393002
Cr-Commit-Position: refs/heads/master@{#414011}
(cherry picked from commit b28b52083bedc924f575b5955b60902245e5ca35)
Review URL: https://codereview.chromium.org/2275033002 .
Cr-Commit-Position: refs/branch-heads/2785@{#742}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
M53: Fix branding/official build confusion in os_crypt.
This is the spiritial backport of
https://codereview.chromium.org/2264163002
BUG=640603
[email protected]
Review URL: https://codereview.chromium.org/2272143002 .
Cr-Commit-Position: refs/branch-heads/2785@{#741}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Make TabLayer recycling sticky to tab_id.
TabListSceneLayer is the parent of all currently visible phone tab
switcher CC layers. It prefers to reuse existing layers instead of
recreating them from scratch.
However, the old logic was vector-based and had no guaranteed
correlation to tab ids, so when a layer in the middle became covered and
invisible, all layers after it were suddenly repurposed to display a
different tab than on the previous frame (and the last layer in the list
was destroyed, not the layer that became invisible). The thumbnail
subsystems have problems handling this switchover perfectly and
sometimes flicker white or black for one frame, and this is also
inefficient.
This patch replaces the vector of TabLayers with a map sorted by id, so
that when a TabLayer becomes invisible, that one is removed without
disturbing any of the other layers.
[edited to add more #includes: see http://crbug.com/640352]
BUG=638068,640352
Review URL: https://codereview.chromium.org/2274993002 .
Review-Url: https://codereview.chromium.org/2253423003
Cr-Original-Commit-Position: refs/heads/master@{#413244}
Cr-Commit-Position: refs/branch-heads/2785@{#740}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge M53: Made setting lowbox token a warning.
This patch makes setting of the lowbox toke a warning rather than a hard failure. Some configurations cause the setting of the token to fail, this is most likely issues with third party software. Worst case this will mean that the lowbox token is not set, but we'll continue with the original restricted token sandbox.
BUG=501975
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2130753002
Cr-Commit-Position: refs/heads/master@{#405173}
(cherry picked from commit 351566a4e91d7f5c204c6c0881986f6bb385a04b)
Review URL: https://codereview.chromium.org/2274573005 .
Cr-Commit-Position: refs/branch-heads/2785@{#739}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to 2785] Discard correct drawing buffer
> This partly revert https://codereview.chromium.org/1950053003. On
> platform supported GL_EXT_discard_framebuffer extension, it causes a
> WebGL conformance test regression:
> conformance/state/state-uneffected-after-compositing.html
>
> The root cause is current bound fbo will be discarded other than the
> default fbo. We should discard default fbo correctly.
>
> BUG=628472
>
> Review-Url: https://codereview.chromium.org/2145093003
> Cr-Commit-Position: refs/heads/master@{#405689}
> (cherry picked from commit fd383c4428d3a4e1041425214f001661dca8d173)
Review URL: https://codereview.chromium.org/2267423004 .
Cr-Commit-Position: refs/branch-heads/2785@{#738}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
