Publish DEPS for Chromium 53.0.2785.80
Incrementing VERSION to 53.0.2785.80
Cr-Commit-Position: refs/branch-heads/2785@{#737}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.79
Cr-Commit-Position: refs/branch-heads/2785@{#736}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert "Make TabLayer recycling sticky to tab_id."
This reverts commit f66182335a8d477501e0657cafc3600ae9896e98,
which is failing on Android official builders.
BUG=640352,638068
Review URL: https://codereview.chromium.org/2272603004 .
Cr-Commit-Position: refs/branch-heads/2785@{#735}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert "Revert "Separate data use reporting logic in ExternalDataUseObserver""
This reverts commit 12f561ba18f5edff70ee2a261b06af11026766b6.
Blimp engine builds still failing; this is not the root cause.
Cr-Commit-Position: refs/branch-heads/2785@{#734}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.78
Cr-Commit-Position: refs/branch-heads/2785@{#733}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert "Separate data use reporting logic in ExternalDataUseObserver"
This reverts commit 5d6be6747a7e7630cc498aed1712602df24879ed.
Speculative revert to see if this fixes blimp-engine builds
BUG=638162
Cr-Commit-Position: refs/branch-heads/2785@{#732}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix the issue of app window frame header buttons not being repainted when its activation state changes.
BUG=620628
TBR=sky
Review URL: https://codereview.chromium.org/2268863006 .
Cr-Commit-Position: refs/branch-heads/2785@{#731}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Make TabLayer recycling sticky to tab_id.
TabListSceneLayer is the parent of all currently visible phone tab
switcher CC layers. It prefers to reuse existing layers instead of
recreating them from scratch.
However, the old logic was vector-based and had no guaranteed
correlation to tab ids, so when a layer in the middle became covered and
invisible, all layers after it were suddenly repurposed to display a
different tab than on the previous frame (and the last layer in the list
was destroyed, not the layer that became invisible). The thumbnail
subsystems have problems handling this switchover perfectly and
sometimes flicker white or black for one frame, and this is also
inefficient.
This patch replaces the vector of TabLayers with a map sorted by id, so
that when a TabLayer becomes invisible, that one is removed without
disturbing any of the other layers.
BUG=638068
Review-Url: https://codereview.chromium.org/2253423003
Cr-Commit-Position: refs/heads/master@{#413244}
(cherry picked from commit f859be05a8db1f6301119cd9dfd58d7ddd75ee22)
Review URL: https://codereview.chromium.org/2270563004 .
Cr-Commit-Position: refs/branch-heads/2785@{#730}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Don't open explicitly opted out intents in custom tabs
Don't route VIEW intents to custom tabs if explicitly opted out.
Override any other custom tabs extras if explicitly opted out.
BUG=622894
[email protected]
Review URL: https://codereview.chromium.org/2200883002 .
Committed: https://crrev.com/6f455e1966ec8bbc41d200a3b787f7c3c5a48e4b
Cr-Original-Commit-Position: refs/heads/master@{#409240}
Cr-Commit-Position: refs/branch-heads/2785@{#729}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Remove DumpWithoutCrashing in RouteGestureEvent.
This DumpWithoutCrashing is not providing useful diagnostics, and is
generating a lot of noise in the crash reports. We are removing it and pursuing other avenues for debugging.
BUG=595422
[email protected]
Review-Url: https://codereview.chromium.org/2207993002
Cr-Commit-Position: refs/heads/master@{#409525}
(cherry picked from commit 87022427432ab8ab1d11a4d6e1143bdfeb9c12ee)
Review URL: https://codereview.chromium.org/2269163002 .
Cr-Commit-Position: refs/branch-heads/2785@{#728}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Ignore multiple assignments to global context.
WebView encounters applications where they override
getApplicationContext and return fresh instances or wrappers every
time it is called. We cannot rely on that method and so we assume that
the first assignment is the most correct one.
BUG=637389
Review-Url: https://codereview.chromium.org/2242173003
Cr-Commit-Position: refs/heads/master@{#412845}
(cherry picked from commit 10f8626fd501f0f58f7136e27da134678300a439)
Review URL: https://codereview.chromium.org/2273603003 .
Cr-Commit-Position: refs/branch-heads/2785@{#727}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix the corner case for new audio device is not selected as active if it is plugged in for the first time after cros device is powered down.
BUG=622045
Review-Url: https://codereview.chromium.org/2189463004
Cr-Commit-Position: refs/heads/master@{#408431}
(cherry picked from commit 6d5579b510fe8dcc6efb7ea1b6e881f840aa7f87)
Review URL: https://codereview.chromium.org/2270693005 .
Cr-Commit-Position: refs/branch-heads/2785@{#726}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Detect duplicate USB device notifications from udev.
This patch adds a check to detect when udev has sent Chrome multiple
notifications for the same device, ignoring the duplicates, as this
behavior has been observed in the wild.
I also fix DeviceReady() to not send a device added notification if a
device was disconnected while it was being enumerated. The device would
not have been added to the global device list in this case.
BUG=638298
Review-Url: https://codereview.chromium.org/2261783002
Cr-Commit-Position: refs/heads/master@{#413273}
(cherry picked from commit f2c7b56f4a4f2c16b2f7062f60ad3041217e9f20)
Review URL: https://codereview.chromium.org/2269143002 .
Cr-Commit-Position: refs/branch-heads/2785@{#725}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Teach the preload scanner about the 'nonce' attribute.
The 'nonce' attribute helps determine whether a particular script or
stylesheet can be loaded in the context of a page's Content Security
Policy. Currently, the preload scanner ignores this attribute, which
means we might end up not preloading something we ought to preload.
This patch teaches the preload scanner to store this data and pass it
on with the preload request.
[email protected]
Review-Url: https://codereview.chromium.org/2148723002
Cr-Commit-Position: refs/heads/master@{#405446}
(cherry picked from commit dde5487f380cf774e4c0e96ba7f88ea68e723907)
BUG=639825
Review URL: https://codereview.chromium.org/2270723003 .
Cr-Commit-Position: refs/branch-heads/2785@{#724}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Reland: arc: avoid checkbox AutomationNode issue
The original CL has caused https://crbug.com/638840.
This CL includes the fix to the issue in addition to the original CL.
BUG=638501,638840
BUG=b/30906810
TEST=tested as described in the issues.
[email protected]
Original description:
arc: avoid checkbox AutomationNode issue
Avoid checkbox AutomationNode issue https://crbug.com/638498
BUG=638501
BUG=b/30906810
TEST=tested as described in the issue
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
Cr-Commit-Position: refs/heads/master@{#412740}
patch from issue 2254673003 at patchset 1 (http://crrev.com/2254673003#ps1)
Review-Url: https://codereview.chromium.org/2259713003
Cr-Commit-Position: refs/heads/master@{#412887}
(cherry picked from commit 1e2b1930480538185b0cef473949b586d96f4da2)
Review URL: https://codereview.chromium.org/2274543002 .
Cr-Commit-Position: refs/branch-heads/2785@{#723}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Use UUID 16 bits in advertising data
For device advertising data received from low energy scan,
Android framework supports UUID 128 bits in services data
field. But, Android Bluetooth package supports only UUID
16 bits.
This patch makes Chrome send UUID 16 bits to Android
instead of UUID 128 bits.
BUG=636478
TEST=Build
Review-Url: https://codereview.chromium.org/2204263003
Cr-Commit-Position: refs/heads/master@{#412417}
(cherry picked from commit 31fcf11302a5dc9670458fe666f86c086191089d)
Review URL: https://codereview.chromium.org/2268113002 .
Cr-Commit-Position: refs/branch-heads/2785@{#722}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc/bluetooth: Plumb incoming connections to instance
The instance is currently unaware of when connections are
made from the outside. We need to keep track of connected
LE devices and alert the instance as appropriate. This
will allow us to accept incoming GATT clients when we are
operating as a GATT server.
Since connected LE devices can also change address, we
need to implement this to make sure our bookkeeping is
correct.
BUG=629210
TEST=log from instance when connections are made and when
devices change address, make a connection using Chrome
UI, verify that the logs in the instance show the device
connecting, disconnecting and changing address as
appropriate.
Review-Url: https://codereview.chromium.org/2212673002
Cr-Commit-Position: refs/heads/master@{#412952}
(cherry picked from commit 149955d5a201173e1aa59a41c0c3b2dd33bfd300)
Review URL: https://codereview.chromium.org/2264403002 .
Cr-Commit-Position: refs/branch-heads/2785@{#721}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
device/bluetooth: set fake device type in CreateDevice
Fake devices were being created with invalid type
properties and unknown types. This was a problem for
code that expects to be able to use the type field to
figure out if the device is an LE device, since it
would fail tests spuriously.
BUG=None
TEST=ArcBluetoothBridgeTest.LEDeviceFound after
applying issue 2212673002
Review-Url: https://codereview.chromium.org/2259953002
Cr-Commit-Position: refs/heads/master@{#412932}
(cherry picked from commit 1bcc77dabb74cf131f5c43c2f9c308aacc34ed3d)
Review URL: https://codereview.chromium.org/2264393002 .
Cr-Commit-Position: refs/branch-heads/2785@{#720}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Always acquire a NotifySession
If Arc++ needs to keep receiving notifications it needs to
unconditionally acquire a NotifySession. The Bluetooth API
uses a ref-counting model to write to the descriptor. If
other clients drop their NotifySessions, notifications will stop.
BUG=632476
TEST=Build
Review-Url: https://codereview.chromium.org/2189183002
Cr-Commit-Position: refs/heads/master@{#408692}
(cherry picked from commit 3a796de6b43352fb756aa1c9c24a8bc5fc481553)
Review URL: https://codereview.chromium.org/2270613002 .
Cr-Commit-Position: refs/branch-heads/2785@{#719}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Implement Gatt server request to read/write
Implement the following functionality
- Request to read/write Gatt characteristic/descriptor.
- Send response message back for the request read/write.
- Send reply back that response message is sent.
BUG=629210
TEST=manual test using step below
1. Create custom Gatt server in nrF connect app.
2. Connect minnie to ryu via chrome interface.
3. Ryu can correctly see minnie's Gatt server object.
4. Ryu can correctly read / write Gatt server object.
Review-Url: https://codereview.chromium.org/2101283003
Cr-Commit-Position: refs/heads/master@{#407587}
(cherry picked from commit 8dcc59fa56cb65f1f4cd48bb0e11eb1633c9ccf8)
Review URL: https://codereview.chromium.org/2270603002 .
Cr-Commit-Position: refs/branch-heads/2785@{#718}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Implement Gatt Server Add/Delete/Start/Stop service
Implement the following functionality
- Add Gatt service / characteristic / descriptor to Gatt Server
"Gatt included service" is currently not support in Chrome side.
- Start / Stop Gatt service
- Delete Gatt Service
BUG=629210
TEST=manual test using step below
1. Create custom Gatt server in nrF connect app.
2. Connect minnie to ryu via chrome interface.
3. Ryu can correctly see minnie's Gatt server object.
Review-Url: https://codereview.chromium.org/2104043002
Cr-Commit-Position: refs/heads/master@{#407566}
(cherry picked from commit a8e840b9957e040e0e283cce8a9bbf27802d70b9)
Review URL: https://codereview.chromium.org/2268083002 .
Cr-Commit-Position: refs/branch-heads/2785@{#717}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Add Gatt server mojo API
This patch adds the mojo definition for Gatt Server API
BUG=629210
TEST=Build
Review-Url: https://codereview.chromium.org/2104023002
Cr-Commit-Position: refs/heads/master@{#407546}
(cherry picked from commit 9c5baa3ebd453f8b0778d922bd418c47f042cb68)
Review URL: https://codereview.chromium.org/2268873002 .
Cr-Commit-Position: refs/branch-heads/2785@{#716}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.77
Cr-Commit-Position: refs/branch-heads/2785@{#715}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Roll m53 back to Urda
BUG=639494
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2254733012
Cr-Commit-Position: refs/branch-heads/2785@{#714}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Require certain faimilies to contain certain styles
This is a workaround for 635932, so that Chrome will ignore certain font
families unless they contain the specified font styles. We start out
requiring that Helvetica and Open Sans contain the regular variant,
because in some cases they get installed only in specialized variants
which results in fonts incorrectly displaying bold or condensed.
BUG=635932
Review-Url: https://codereview.chromium.org/2259733002
Cr-Commit-Position: refs/heads/master@{#413323}
(cherry picked from commit 0bf300d07fe226dc48da9cbfaa6d9ea36480f66d)
Review URL: https://codereview.chromium.org/2268003002 .
Cr-Commit-Position: refs/branch-heads/2785@{#713}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
ChromeOS: fix crash in HashWallpaperFilesIdStr.
This CL postpones SetPolicyControlledWallpaper() until system salt is ready.
BUG=615239
TEST=none
Review-Url: https://codereview.chromium.org/2220433002
Cr-Commit-Position: refs/heads/master@{#410909}
(cherry picked from commit 35461b845a3ba44af7c2fc28cb60ffe521eecc96)
Review URL: https://codereview.chromium.org/2266213002 .
Cr-Commit-Position: refs/branch-heads/2785@{#712}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of arc: bluetooth: Add Gatt server mojo API (patchset #1 id:1 of https://codereview.chromium.org/2265173003/ )
Reason for revert:
Bad merge.
Original issue's description:
> arc: bluetooth: Add Gatt server mojo API
>
> This patch adds the mojo definition for Gatt Server API
>
> BUG=629210
> TEST=Build
>
> Review-Url: https://codereview.chromium.org/2104023002
> Cr-Commit-Position: refs/heads/master@{#407546}
> (cherry picked from commit 9c5baa3ebd453f8b0778d922bd418c47f042cb68)
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=629210
Review-Url: https://codereview.chromium.org/2263363003
Cr-Commit-Position: refs/branch-heads/2785@{#711}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: bluetooth: Add Gatt server mojo API
This patch adds the mojo definition for Gatt Server API
BUG=629210
TEST=Build
Review-Url: https://codereview.chromium.org/2104023002
Cr-Commit-Position: refs/heads/master@{#407546}
(cherry picked from commit 9c5baa3ebd453f8b0778d922bd418c47f042cb68)
Review URL: https://codereview.chromium.org/2265173003 .
Cr-Commit-Position: refs/branch-heads/2785@{#710}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Updating XTBs based on .GRDs from branch 2785
Cr-Commit-Position: refs/branch-heads/2785@{#709}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Android] Introduce LocaleManager to Chrome
LocaleManager will manage the locale specific logic in Chrome. Currently
the only thing it does is to record some metrics in deferred startup.
BUG=630703
Review-Url: https://codereview.chromium.org/2248013004
Cr-Commit-Position: refs/heads/master@{#412709}
[email protected]
Review URL: https://codereview.chromium.org/2268693002 .
Cr-Commit-Position: refs/branch-heads/2785@{#708}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Sync] Fix account id comparison for cookie jar
Gaia ID != Account ID in all cases. |id| is the proper variable to use.
BUG=639335
Review-Url: https://codereview.chromium.org/2266483002
Cr-Commit-Position: refs/heads/master@{#413210}
(cherry picked from commit 5ca485b1159f942c41fa94978c3ba672928eb939)
Review URL: https://codereview.chromium.org/2261243003 .
Cr-Commit-Position: refs/branch-heads/2785@{#707}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Change GPU Tile rounding to 32
Rounding to 64 was done to match SW, but this leads to android
memory regressions. Use 32 instead, which still fixes the Core
Animation issue, but doesn’t regress memory as much.
BUG=632274
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2258343002
Cr-Commit-Position: refs/heads/master@{#413310}
(cherry picked from commit 55f181c683f26d1d43f264367363790a802e096d)
Review URL: https://codereview.chromium.org/2268643002 .
Cr-Commit-Position: refs/branch-heads/2785@{#706}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add a choice not to crash when unexpected dirty layout is encountered
If choose not to crash, the callsite can choose to ignore the result
or early return from the function.
When merging to M53, the condition for CHECK_FOR_DIRTY_LAYOUT is
set to not crashing when the check fails.
BUG=590856
Review URL: https://codereview.chromium.org/2261243002 .
Review-Url: https://codereview.chromium.org/2259983003
Cr-Original-Commit-Position: refs/heads/master@{#413358}
Cr-Commit-Position: refs/branch-heads/2785@{#705}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Set WebPagePopupImpl's bounds even if they don't appear to have changed.
In r389984 I tried to make WebPagePopupImpl::resize only call into
setWindowRect (which sends an IPC to the browser process) if the bounds have
actually changed. This uncovered a bug in Aura that was papered up by the fact
that we repeatedly set the bounds. The proper way to fix this is in Aura itself
but we'd like to merge this for release so I'm landing this quick fix to
restore the previous behavior.
I'm working on a proper fix in crrev.com/2228093003
BUG=633140
Review-Url: https://codereview.chromium.org/2263503003
Cr-Commit-Position: refs/heads/master@{#413288}
(cherry picked from commit 10dc8b7652e6d30337d9bea0ff8bba2592942751)
Review URL: https://codereview.chromium.org/2265923002 .
Cr-Commit-Position: refs/branch-heads/2785@{#704}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Avoid setting timers from SVGImage::resetAnimation()
When resetting the timeline to t=0, we may up generating syncbase
notification, which sets up a timer (to update any possibly dependent
intervals.) Since resetAnimation() is what's called when the (SVG)Image
no longer has any clients, we should try to make sure it is indeed
idle after that happens. This avoids trying to update animation state
while the image is otherwise dead, leaving "reactivation" to the time
it is next painted.
BUG=627418
Review-Url: https://codereview.chromium.org/2247783003
Cr-Commit-Position: refs/heads/master@{#412798}
(cherry picked from commit 12c039d9866df4bae5c2b1a398b04816701233b3)
Review URL: https://codereview.chromium.org/2263993002 .
Cr-Commit-Position: refs/branch-heads/2785@{#703}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
CSP: Strip reported URLs for 'frame-src' and 'object-src'.
The relaxation that landed in https://codereview.chromium.org/2002943002
was a bit too relaxed, and leaks navigation targets cross-origin for
'frame-src' and 'object-src' violations.
This patch reverts to the old behavior for those two directives.
BUG=633306
Review-Url: https://codereview.chromium.org/2255103002
Cr-Commit-Position: refs/heads/master@{#412809}
(cherry picked from commit 94a6ff53682eac87184c1682b63faf6110325174)
Review URL: https://codereview.chromium.org/2267653003 .
Cr-Commit-Position: refs/branch-heads/2785@{#702}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
boundaryTextInserted/Removed() should not call markValid() for irrelavent changes
This patch fixes a bug related to the maintenance of RangeBoundaryPoint. Example:
Let body's content be "<div>foo<span>bar</span></foo>", and a range be created as
from (<span>, 0) to (<div>, 2). Then there are two updates:
1. Insert a new sibling before the text node "foo"
2. Insert/Remove characters in the text node "foo"
In the current implementation, step 2 incorrectly marks the boundary points of
the range as up-to-date without actually updating the stored offsets in it, making
the change in step 1 ignored. Then if we call |range->endPosition()|, we still get
(<div>, 2) instead of (<div>, 3), finding the range in an inconsistent state.
This patch ensures that boundaryTextInserted/Removed() only calls markValid()
when the current RangeBoundaryPoints's container is the CharacterData node
where text is inserted/removed, and irrelevant RangeBoundaryPoints should not
be changed.
BUG=639184
Review-Url: https://codereview.chromium.org/2254423002
Cr-Commit-Position: refs/heads/master@{#413104}
(cherry picked from commit 8cdfdf011fb08fd2dda2d02c2b89bb7f08a53272)
Review URL: https://codereview.chromium.org/2265853002 .
Cr-Commit-Position: refs/branch-heads/2785@{#701}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Add package app list updated event.
This requires to keep state of installed Arc apps when a package gets
updated. Before 2 events were issued, package removed and packaged
added. First event removes all relevant data from Chrome prefs and this
also makes pin disappearing.
[email protected]
NOTRY=true
NOPRESUBMIT=true
BUG=b/30564914
TEST=Manually on device. Pin and position in recent are preserved on
package update. Pin and item from app list are removed when
packaged is uninstalled.
TEST=Extend unit_tests browser_tests
Review-Url: https://codereview.chromium.org/2228663003
Cr-Commit-Position: refs/heads/master@{#411194}
(cherry picked from commit 500b22fce0a7c794d90d3ddbba5aec93f9e8f9ab)
Review-Url: https://codereview.chromium.org/2263013002
Cr-Commit-Position: refs/branch-heads/2785@{#700}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.76
Cr-Commit-Position: refs/branch-heads/2785@{#699}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Mac: Disable AVSampleBufferDisplayLayer on Mac <10.11
There are reports of this leaking IOSurfaces.
BUG=631485
Review URL: https://codereview.chromium.org/2269473002 .
Cr-Commit-Position: refs/branch-heads/2785@{#698}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Refresh Public Suffic List to the latest version
This updates from revision
28e17a0f8f26f1bddfbd62d9861b223efa7792bc (2016-07-06)
to revision
4dcaacaf593dde7e2a34436913c24af3bf2bdb06 (2016-08-16)
[email protected]
BUG=626532
Review-Url: https://codereview.chromium.org/2248253002
Cr-Commit-Position: refs/heads/master@{#412419}
(cherry picked from commit 702d65e434b5a41965f5b9fbe644e9e4300157b6)
Review URL: https://codereview.chromium.org/2266753002 .
Cr-Commit-Position: refs/branch-heads/2785@{#697}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Handle non-launchable apps.
There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.
BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2210143003
Cr-Commit-Position: refs/heads/master@{#411120}
(cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)
Review-Url: https://codereview.chromium.org/2260363003
Cr-Commit-Position: refs/branch-heads/2785@{#696}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions
This is a very conservative fix designed to fix the regression.
The page transition logic was and is not in sync with the renderer-side check, see https://crbug.com/633963#c14.
BUG=633963
TEST=manually using steps from bug report
Review-Url: https://codereview.chromium.org/2249423002
Cr-Commit-Position: refs/heads/master@{#413258}
(cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)
Review URL: https://codereview.chromium.org/2261043002 .
Cr-Commit-Position: refs/branch-heads/2785@{#695}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.75
Cr-Commit-Position: refs/branch-heads/2785@{#694}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge M53: Update Flash plugin metadata versions to latest version.
https://helpx.adobe.com/security/products/flash-player/apsb16-25.html
BUG=412078
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
[email protected]
Review-Url: https://codereview.chromium.org/2266463002
Cr-Commit-Position: refs/heads/master@{#413194}
(cherry picked from commit 225f6d7d4e07f273558a186429331d56a0555105)
Review URL: https://codereview.chromium.org/2258313003 .
Cr-Commit-Position: refs/branch-heads/2785@{#693}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Don't handle the tab press event in the window cycle event filter.
Because fullscreen windows are allowed to handle alt+tab, we have to be careful
not to handle the tab press event in the window cycle event filter as it will
be treated as a fullscreen window preventing alt-tabbing.
BUG=622396
TEST=WindowCycleControllerTest.TabPastFullscreenWindow,WindowCycleControllerTest.TabKeyNotLeaked
[email protected]
Review-Url: https://codereview.chromium.org/2252673002
Cr-Commit-Position: refs/heads/master@{#412616}
(cherry picked from commit 66b4142cfaf0acc038f220b6288089f8a60b923d)
Review URL: https://codereview.chromium.org/2260973003 .
Cr-Commit-Position: refs/branch-heads/2785@{#692}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.74
Cr-Commit-Position: refs/branch-heads/2785@{#691}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Send GWS ID to google domains when matching rule is available
When valid matching rules are available, a synthetic field trial is
created and GWS ID is set for it. When the control app is
uninstalled or the matching rules are removed, the synthetic field trial
is set to disabled group.
BUG=615170
Review-Url: https://codereview.chromium.org/2241133002
Cr-Commit-Position: refs/heads/master@{#413251}
(cherry picked from commit 7f4a80f44ebad67bafc75cc113bdb938beeda997)
Review URL: https://codereview.chromium.org/2258323002 .
Cr-Commit-Position: refs/branch-heads/2785@{#690}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Fix crash on window close (on close race condition).
This handles race condition on window closing.
TEST=Extended browser_tests
TEST=Manually on device
TEST=test_that -b veyron_minnie <IP> cheets_Notification
BUG=638656
BUG=638261
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2256273003
Cr-Commit-Position: refs/heads/master@{#412940}
(cherry picked from commit 800987eb69027f6f34dff840b19c68a83065c6ae)
Review-Url: https://codereview.chromium.org/2259403002
Cr-Commit-Position: refs/branch-heads/2785@{#689}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add an api to check android permissions w/o exceptions.
Some older configurations of Android are throwing exceptions
when we call Context#checkPermission. Treat this as a denied
permission and proceed.
[email protected]
BUG=639099
Review URL: https://codereview.chromium.org/2260823003 .
Review-Url: https://codereview.chromium.org/2266503002
Cr-Original-Commit-Position: refs/heads/master@{#413234}
Cr-Commit-Position: refs/branch-heads/2785@{#688}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Prevent peripheral mode operation from outside of Kiosk.
Peripheral mode is only supposed to work with auto-launched apps in a
Kiosk session. This check wasn't put in the API when this was first
implemented but we should fix this ASAP.
[email protected],[email protected]
BUG=638460
Review-Url: https://codereview.chromium.org/2249333002
Cr-Commit-Position: refs/heads/master@{#412718}
(cherry picked from commit 94e2a8816e090d944a8248ea3a4d526ffc49dd4a)
Review URL: https://codereview.chromium.org/2264783002 .
Cr-Commit-Position: refs/branch-heads/2785@{#687}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Fix crash on Arc window close.
BUG=638261
BUG=b/30817552
TEST=Manually on device. No more crashes are observed.
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2251493002
Cr-Commit-Position: refs/heads/master@{#412390}
(cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)
Review-Url: https://codereview.chromium.org/2262723002
Cr-Commit-Position: refs/branch-heads/2785@{#686}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Disallow hit tests in a not-active Document.
Cherry-picked from:
https://codereview.chromium.org/2236003002
BUG=590856
[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2259093004
Cr-Commit-Position: refs/branch-heads/2785@{#685}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Copy Page::ordinaryPages() before undeferring loads.
Undeferring loads can run script, which can mutate the PageSet.
BUG=628942
Review-Url: https://codereview.chromium.org/2242923002
Cr-Commit-Position: refs/heads/master@{#412104}
(cherry picked from commit 5544c19b4252cbf65eea6894d55b2ed486957079)
Review URL: https://codereview.chromium.org/2254273005 .
Cr-Commit-Position: refs/branch-heads/2785@{#684}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Defer loads in new pages/frames if ScopedPageLoadDeferral is active
BUG=628942
Review-Url: https://codereview.chromium.org/2174263002
Cr-Commit-Position: refs/heads/master@{#408354}
(cherry picked from commit 19ad54cb204cde45db95e773c5d54b04b2f178d4)
Review URL: https://codereview.chromium.org/2257933005 .
Cr-Commit-Position: refs/branch-heads/2785@{#683}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix ScopedPageLoadDeferrer to work with pages that have remote main frames.
BUG=628942
Review-Url: https://codereview.chromium.org/2155393002
Cr-Commit-Position: refs/heads/master@{#406632}
(cherry picked from commit 07ff366089e56cb17712457e3f5e8469f034631b)
[email protected]
Review URL: https://codereview.chromium.org/2260903002 .
Cr-Commit-Position: refs/branch-heads/2785@{#682}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Use MD-ash's auto hide behavior for arc++ windows.
This add a runtime flag to enable MD-ash's auto hide behavior , which makes the shelf invisible, for arc++ windows. I'll remove this mode once MD ash is launched.
BUG=634566
TEST=covered by unit test. Manually tested on minnie.
Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Review-Url: https://codereview.chromium.org/2248773002
Cr-Original-Commit-Position: refs/heads/master@{#412309}
Cr-Commit-Position: refs/heads/master@{#412352}
(cherry picked from commit 41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef)
Register the window in MaximizeModeWindowManager when the window is shown.
This is necessary for arc app to set the "don't manage me" flag.
BUG=635899
Review-Url: https://codereview.chromium.org/2250963006
Cr-Commit-Position: refs/heads/master@{#412882}
(cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8)
Review URL: https://codereview.chromium.org/2255313005 .
Committed: https://chromium.googlesource.com/chromium/src/+/09b361d92cba6a2e1b78998f74ccda1f0485de39
Cr-Commit-Position: refs/branch-heads/2785@{#681}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Use MD-ash's auto hide behavior for arc++ windows.
This add a runtime flag to enable MD-ash's auto hide behavior , which makes the shelf invisible, for arc++ windows. I'll remove this mode once MD ash is launched.
BUG=634566
TEST=covered by unit test. Manually tested on minnie.
Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Review-Url: https://codereview.chromium.org/2248773002
Cr-Original-Commit-Position: refs/heads/master@{#412309}
Cr-Commit-Position: refs/heads/master@{#412352}
(cherry picked from commit 41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef)
Register the window in MaximizeModeWindowManager when the window is shown.
This is necessary for arc app to set the "don't manage me" flag.
BUG=635899
Review-Url: https://codereview.chromium.org/2250963006
Cr-Commit-Position: refs/heads/master@{#412882}
(cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8)
Review URL: https://codereview.chromium.org/2255313005 .
Cr-Commit-Position: refs/branch-heads/2785@{#680}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Enable closing while processing payment.
This patch allows closing PaymentRequest UI via the [x] button while
waiting for merchant to process the payment. This is accomplished by
switching off the "is processing pay clicked" flag when
showProcessingMessage() has been called. PaymentRequestImpl calls
showProcessingMessage() when payment app has closed and its info has
been sent to the merchant website.
BUG=637366
Review-Url: https://codereview.chromium.org/2247493002
Cr-Commit-Position: refs/heads/master@{#411881}
(cherry picked from commit 4d72ec4ded66ff9ad99497f5895433bccd179716)
Review URL: https://codereview.chromium.org/2260503004 .
Cr-Commit-Position: refs/branch-heads/2785@{#679}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.73
Cr-Commit-Position: refs/branch-heads/2785@{#678}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Register the window in MaximizeModeWindowManager when the window is shown.
This is necessary for arc app to set the "don't manage me" flag.
BUG=635899
Review-Url: https://codereview.chromium.org/2250963006
Cr-Commit-Position: refs/heads/master@{#412882}
(cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8)
Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are.
The maximizing in tablet mode will be handled on arndroid side.
BUG=635899
TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows
Review-Url: https://codereview.chromium.org/2249953002
Cr-Commit-Position: refs/heads/master@{#412566}
(cherry picked from commit cbd18684621964b72a64cc91775c89721cc07a4f)
Review URL: https://codereview.chromium.org/2260083002 .
Cr-Commit-Position: refs/branch-heads/2785@{#677}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are.
The maximizing in tablet mode will be handled on arndroid side.
BUG=635899
TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows
Review-Url: https://codereview.chromium.org/2249953002
Cr-Commit-Position: refs/heads/master@{#412566}
(cherry picked from commit cbd18684621964b72a64cc91775c89721cc07a4f)
Review URL: https://codereview.chromium.org/2264443002 .
Cr-Commit-Position: refs/branch-heads/2785@{#676}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to 53] [android] Correct the URL scheme colors in the Omnibox.
Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.
BUG=626646
Review-Url: https://codereview.chromium.org/2176853002
Cr-Commit-Position: refs/heads/master@{#408522}
(cherry picked from commit b03c9e423566305be2fe7b770288e0de68c510e4)
Review URL: https://codereview.chromium.org/2250263006 .
Cr-Commit-Position: refs/branch-heads/2785@{#675}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix fragmented image signature handling
ImageDecoder::determineImageType() is currently only examining the first
buffer segment (getSomeData). But the signature is not guaranteed to be contiguous,
nor do we ever re-consolidate the buffer after receiving more data.
As a consequence, when the signature is fragmented (e.g. due to a slow
image load), we cannot detect the image type - even after all the data is
later received.
Refactor determineImageType() to consolidate the signature when needed.
BUG=637556
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2252723003
Cr-Commit-Position: refs/heads/master@{#412631}
(cherry picked from commit 1b80a74055acae8a0296afe644513f52e34dec79)
Review URL: https://codereview.chromium.org/2260703002 .
Cr-Commit-Position: refs/branch-heads/2785@{#674}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.72
Cr-Commit-Position: refs/branch-heads/2785@{#673}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of arc: Fix crash on Arc window close. (patchset #1 id:1 of https://codereview.chromium.org/2251973003/ )
Reason for revert:
wrong resolve
Original issue's description:
> arc: Fix crash on Arc window close.
>
> BUG=638261
> BUG=b/30817552
> TEST=Manually on device. No more crashes are observed.
>
> NOTRY=true
> NOPRESUBMIT=true
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2251493002
> Cr-Commit-Position: refs/heads/master@{#412390}
> (cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638261
Review-Url: https://codereview.chromium.org/2255383004
Cr-Commit-Position: refs/branch-heads/2785@{#672}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of [M53 cherry-pick] Migrate ArcUserDataService into ArcAuthService. (patchset #1 id:1 of https://codereview.chromium.org/2248353002/ )
Reason for revert:
Compilation problem:
../../chrome/browser/chromeos/arc/arc_auth_service.cc:244:34: error: no member named 'stopped' in 'arc::ArcBridgeService'
Original issue's description:
> Migrate ArcUserDataService into ArcAuthService.
>
> There are race problems around data removing.
> One of the cause is that state management is done in
> ArcAuthService and ArcUserDataService separately.
>
> This CL migrates ArcUserDataService into ArcAuthService
> so that we can remove the data when necessary.
>
> BUG=633258, 636218
> TEST=Ran manually.
> - "Enable -> ARC boot wait -> Disable" triggers data removal after
> ARC stop.
> - "Enable -> Disable before ARC boot" triggers immediate data
> removal.
> - "Enable -> ARC boot wait -> Kill ARC instance" does not trigger
> data removal.
> [email protected], [email protected]
> [email protected], [email protected], [email protected]
>
> Review-Url: https://codereview.chromium.org/2209173002
> Cr-Commit-Position: refs/heads/master@{#411923}
> (cherry picked from commit 6d95ad318e992261c45f5a88a0a599663a6d66ae)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d7ca35a59c7bd8c7ddd78d7682458e48e6b4e934
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633258, 636218
Review-Url: https://codereview.chromium.org/2255673004
Cr-Commit-Position: refs/branch-heads/2785@{#671}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix extension bindings injection for iframes (reland)
For iframes, we don't want to use the source url for determining the
associated extension because it starts out with an about:blank context
that is scriptable by its parent.
This originally landed in codereview.chromium.org/2151693002/ but
was reverted because of bug 630928 as well as the test failing under
DrMemory (not with memory errors; just not succeeding which likely
indicates some kind of race condition in the test). I've added a fix for
bug 630928 but haven't been able to locally reproduce the test failure
under DrMemory, so I've added some extra logging to the test to hopefully
better understand what might be going wrong.
Memory sheriffs: If the FramesExtensionBindingsApiTest.FramesBeforeNavigation
test fails again without any actual memory errors, please do not revert the
entire CL (since it is an important security fix); instead just disable the
test or add it to a suppression file so I can iterate on a fix.
BUG=573131,630928
Review-Url: https://codereview.chromium.org/2208483002
Cr-Commit-Position: refs/heads/master@{#409819}
(cherry picked from commit 79b64c3e741cc9c6afbb23885945831a45c6baa5)
Review URL: https://codereview.chromium.org/2257273002 .
Cr-Commit-Position: refs/branch-heads/2785@{#670}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add ERR_CERTIFICATE_TRANSPARENCY_REQUIRED to error report cert errors
I noticed that ERR_CERTIFICATE_TRANSPARENCY_REQUIRED wasn't being added
to cert reports, so this fixes that.
BUG=637970
[email protected]
Review-Url: https://codereview.chromium.org/2232813003
Cr-Commit-Position: refs/heads/master@{#412117}
(cherry picked from commit d36933b3152a7b41c6909d0209687df020e734c9)
Review URL: https://codereview.chromium.org/2262513002 .
Cr-Commit-Position: refs/branch-heads/2785@{#669}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[ios] Set WebState::IsLoading flag to false if load is cancelled.
Before this change WebState::IsLoading was returning false which caused
Toolbar to think that page did not finish loading. In M52 and earlier
toolbar was relying to CRWWebController.loadPhase API to check the load
state so this bug is M53 regression.
Keeping WebState::IsLoading in sync with CRWWebController.loadPhase
fixes toobar bug and is generally a reasonable thing to do.
BUG=638277
Review-Url: https://codereview.chromium.org/2250563003
Cr-Commit-Position: refs/heads/master@{#412391}
(cherry picked from commit 16e4de4de55c5c946b8bdfa47bfee274afc930f2)
Review URL: https://codereview.chromium.org/2260003002 .
Cr-Commit-Position: refs/branch-heads/2785@{#668}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add UMA for signin through NTP content suggestions.
BUG=636523
Review-Url: https://codereview.chromium.org/2230183005
Cr-Commit-Position: refs/heads/master@{#412554}
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2257933002
Cr-Commit-Position: refs/branch-heads/2785@{#667}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of arc: Handle non-launchable apps. (patchset #1 id:1 of https://codereview.chromium.org/2257923002/ )
Reason for revert:
Wrong resolve
Original issue's description:
> arc: Handle non-launchable apps.
>
> There are Android apps that can be started indirectly and which
> don't have launchable flag. We had no support such apps in Chrome
> and that caused incorrect behavior in shelf. Fix is to register
> such apps on creation with special flag that prevents them to
> appear in launcher app list and to be pinned in shelf.
>
> BUG=635536
> BUG=b/30508435
> TEST=Manually on device. Icon of an app (app info) appears on the
> shelf and cannot be pinned. No app info icon in app list.
> TEST=Extended unit_test
> [email protected]
> NOTRY=true
> NOPRESUBMIT=true
>
> Review-Url: https://codereview.chromium.org/2210143003
> Cr-Commit-Position: refs/heads/master@{#411120}
> (cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635536
Review-Url: https://codereview.chromium.org/2259033002
Cr-Commit-Position: refs/branch-heads/2785@{#666}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Remove debug loggings in history report for privacy reasons
There are complaints about history report spamming Android logcat, and
leaking users history entirely in logcat.
BUG=474708
Review-Url: https://codereview.chromium.org/2247633004
Cr-Commit-Position: refs/heads/master@{#412021}
(cherry picked from commit 11cf2f58ec87d91cae9eb9855f45f77604a263a5)
Review URL: https://codereview.chromium.org/2256833004 .
Cr-Commit-Position: refs/branch-heads/2785@{#665}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Handle non-launchable apps.
There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.
BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2210143003
Cr-Commit-Position: refs/heads/master@{#411120}
(cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)
Review-Url: https://codereview.chromium.org/2257923002
Cr-Commit-Position: refs/branch-heads/2785@{#664}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M53] Revert of android: Switch CleanupReference to PhantomReference (patchset #1 id:1 of https://codereview.chromium.org/2241533002/ )
Reason for revert:
Experiment out. Reverting. See bug for reasoning.
Original issue's description:
> android: Switch CleanupReference to PhantomReference
>
> Again. This time due to correctness. Want to experiment on beta to see
> how big the impact is. Quoting from the comment in the CL:
>
> NOTE Using PhantonReference instead of WeakReference is required for correctness.
> WeakReferences are enqueued before finalizers are called, and finalizers can
> resurrect the referent object. PhantomReference does delay clean up more compared
> to WeakReference.
>
> BUG=618807
>
> Committed: https://crrev.com/630d88124d2e5a3fda6b9fd25d06eaa1af403fca
> Cr-Commit-Position: refs/heads/master@{#411417}
[email protected],[email protected]
BUG=618807
Review-Url: https://codereview.chromium.org/2255253002
Cr-Commit-Position: refs/heads/master@{#412871}
(cherry picked from commit 74e50f4c229d7b9f895a3108abdd0309395b919c)
Review URL: https://codereview.chromium.org/2257893003 .
Cr-Commit-Position: refs/branch-heads/2785@{#663}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Android Bookmark]Disable "Open in new tab" for folders
It does not make sense to open a folder in new tab. Currently if a
folder is chosen, an empty tab will be created in browser.
BUG=625818
Review-Url: https://codereview.chromium.org/2125203002
Cr-Commit-Position: refs/heads/master@{#404018}
(cherry picked from commit f89eb57398e8c36dca7eda3b3b080e4884673b1f)
Review URL: https://codereview.chromium.org/2261553002 .
Cr-Commit-Position: refs/branch-heads/2785@{#662}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge m53] aw: Workaround use after free due to finalizers
CleanupReference based on WeakReference can run before finalizers. So
the mere existance of a finalizer can keep enough webview objects alive,
causing use after free. The correct fix of using PhantomReference has
negative effects. So this is just a workaround.
The workaround is for apps that unintentionally uses a finalizer, but do
not intentionally try to use the webview in or past the finalizer. Just
mark the webview object as destroyed, but then silently swallow the
error to avoid crashes.
BUG=618807
Review-Url: https://codereview.chromium.org/2245713002
Cr-Commit-Position: refs/heads/master@{#411961}
(cherry picked from commit f1faf07976b000fc39b929eab7dea94693d17f22)
Review URL: https://codereview.chromium.org/2255343002 .
Cr-Commit-Position: refs/branch-heads/2785@{#661}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Support managed Arc and managed Location Service and B&R consents.
Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.
TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2235293002
Cr-Commit-Position: refs/heads/master@{#412578}
(cherry picked from commit e5a7ff50b3c0cb72e06a3ea7af481d7f41f872a9)
Review-Url: https://codereview.chromium.org/2257873002
Cr-Commit-Position: refs/branch-heads/2785@{#660}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Make Location Service manageable.
Add policy declaration for using of Location Service
BUG= b/30469058
TEST=policy and browser tests extended.
[email protected]
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
patch from issue 2225933002 at patchset 20001 (http://crrev.com/2225933002#ps20001)
Review-Url: https://codereview.chromium.org/2243513002
Cr-Commit-Position: refs/heads/master@{#412559}
(cherry picked from commit 75cf0e73ef617606f3e38c28d0b470f74ee821de)
Review-Url: https://codereview.chromium.org/2252273003
Cr-Commit-Position: refs/branch-heads/2785@{#659}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix an NPE as DownloadManager.query() could return a null cursor
Although not documented on SDK page, this is possible in DownloadManager
source code.
[email protected]
BUG=618458
Review-Url: https://codereview.chromium.org/2242213006
Cr-Commit-Position: refs/heads/master@{#412696}
(cherry picked from commit 757b19c57cfac1fdb034e9b79a80c2dcee9da260)
Review URL: https://codereview.chromium.org/2258963002 .
Cr-Commit-Position: refs/branch-heads/2785@{#658}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fixing headset unplug issues in MediaNotification
This CL make MediaNotification fire a ACTION_STOP PendingIntent when the
notification is dismissed, making the MediaSession inactive.
Also, MediaNotification will not call play()/pause() when the
notification is already in that state, preventing calling pause() when
unpluging headset when the notification is already in paused state.
An unplug-related UMA issue is also fixed in this CL.
BUG=638858
Review-Url: https://codereview.chromium.org/2253293004
Cr-Commit-Position: refs/heads/master@{#412829}
(cherry picked from commit e03e8ee0fc359e38700001f04b7ec2e9a01f5f52)
Review URL: https://codereview.chromium.org/2260563002 .
Cr-Commit-Position: refs/branch-heads/2785@{#657}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
binding: Moves the check for the first access to the initial document into BindingSecurity.
Checks the access to the initial document and reports it not only at
securityCheck() in V8Window.cpp but also at every call to
BindingSecurity::shouldAllowAccessTo() because V8 only calls back
securityCheck() on property lookups, and not for function invocation.
BindingSecurity::shouldAllowAccessTo() is called with every possible
cross-origin window, which means every possible new window. Thus,
shouldAllowAccessTo() should be the right place to check the access
to the initial document.
BUG=630662
Review-Url: https://codereview.chromium.org/2209303002
Cr-Commit-Position: refs/heads/master@{#412195}
(cherry picked from commit b8dcfeb065bbfd777cdc5f5433da9a87f25e6ec6)
Review URL: https://codereview.chromium.org/2259773002 .
Cr-Commit-Position: refs/branch-heads/2785@{#656}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Fix crash in ArcNetHostImpl::DefaultNetworkSuccessCallback
NetInstance can become null at any timing.
BUG=636293
Review-Url: https://codereview.chromium.org/2245303005
Cr-Commit-Position: refs/heads/master@{#412460}
(cherry picked from commit 1f15ad36fa29ce79907f7b4a9572091dd2672768)
Review URL: https://codereview.chromium.org/2258773002 .
Cr-Commit-Position: refs/branch-heads/2785@{#655}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Migrate ArcUserDataService into ArcAuthService.
There are race problems around data removing.
One of the cause is that state management is done in
ArcAuthService and ArcUserDataService separately.
This CL migrates ArcUserDataService into ArcAuthService
so that we can remove the data when necessary.
BUG=633258, 636218
TEST=Ran manually.
- "Enable -> ARC boot wait -> Disable" triggers data removal after
ARC stop.
- "Enable -> Disable before ARC boot" triggers immediate data
removal.
- "Enable -> ARC boot wait -> Kill ARC instance" does not trigger
data removal.
[email protected], [email protected]
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2209173002
Cr-Commit-Position: refs/heads/master@{#411923}
(cherry picked from commit 6d95ad318e992261c45f5a88a0a599663a6d66ae)
Review URL: https://codereview.chromium.org/2248353002 .
Cr-Commit-Position: refs/branch-heads/2785@{#654}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Fix crash on Arc window close.
BUG=638261
BUG=b/30817552
TEST=Manually on device. No more crashes are observed.
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2251493002
Cr-Commit-Position: refs/heads/master@{#412390}
(cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)
Review-Url: https://codereview.chromium.org/2251973003
Cr-Commit-Position: refs/branch-heads/2785@{#653}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert of arc: Fix crash on Arc window close. (patchset #1 id:1 of https://codereview.chromium.org/2252283002/ )
Reason for revert:
Wrong resolve
Original issue's description:
> arc: Fix crash on Arc window close.
>
> BUG=638261
> BUG=b/30817552
> TEST=Manually on device. No more crashes are observed.
>
> NOTRY=true
> NOPRESUBMIT=true
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2251493002
> Cr-Commit-Position: refs/heads/master@{#412390}
> (cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638261
Review-Url: https://codereview.chromium.org/2251313002
Cr-Commit-Position: refs/branch-heads/2785@{#652}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Fix crash on Arc window close.
BUG=638261
BUG=b/30817552
TEST=Manually on device. No more crashes are observed.
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2251493002
Cr-Commit-Position: refs/heads/master@{#412390}
(cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)
Review-Url: https://codereview.chromium.org/2252283002
Cr-Commit-Position: refs/branch-heads/2785@{#651}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix notification button background size
In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView
to adjust the size of notification button background; however, this adjustment
is later cancelled by re-setting border to NULL. As a result, the background
is incorrect as shelf alignment changes.
BUG=637882
Review-Url: https://codereview.chromium.org/2247893002
Cr-Commit-Position: refs/heads/master@{#412060}
(cherry picked from commit e311188e565ea85ccc4ad8f0aeee03eab488bb23)
Review URL: https://codereview.chromium.org/2256053002 .
Cr-Commit-Position: refs/branch-heads/2785@{#650}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
ARC: Show window title in launcher menu instead of app title
BUG=627590
TEST=manual test
Review-Url: https://codereview.chromium.org/2243573002
Cr-Commit-Position: refs/heads/master@{#411407}
(cherry picked from commit 6ecae883342f04ab73135958cd9067fea0fa27d0)
Review URL: https://codereview.chromium.org/2258713002 .
Cr-Commit-Position: refs/branch-heads/2785@{#649}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.71
Cr-Commit-Position: refs/branch-heads/2785@{#648}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Don't reposition if shutdown is in progress
BUG=634572
Review-Url: https://codereview.chromium.org/2249853009
Cr-Commit-Position: refs/heads/master@{#412675}
(cherry picked from commit bbe0bdc738e50b89b5bffb25e431e6b6e75a4249)
Review URL: https://codereview.chromium.org/2252833004 .
Cr-Commit-Position: refs/branch-heads/2785@{#647}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Allow updating arc widget bounds in maximize/fullscreen state.
ARC window can be pillar/letterboxed in maximized state, and chrome needs to adjust its window to those sizes.
BUG=634572
[email protected]
TEST=WindowStateTest.AllowSetBoundsInMaximized
Manually tested on minnie
Review-Url: https://codereview.chromium.org/2237983002
Cr-Commit-Position: refs/heads/master@{#412006}
(cherry picked from commit e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b)
Review URL: https://codereview.chromium.org/2250713006 .
Cr-Commit-Position: refs/branch-heads/2785@{#646}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Disable link previews to prevent links by default.
BUG=622746
Review-Url: https://codereview.chromium.org/2151133002
Cr-Commit-Position: refs/heads/master@{#405676}
(cherry picked from commit bfacb4e36c39f0a2f4fea0851fbf3b8f543360d5)
Review URL: https://codereview.chromium.org/2252113003 .
Cr-Commit-Position: refs/branch-heads/2785@{#645}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to M53][Chrome OS] Change layout of the launcher.
- Add an additional row of "recent apps" to the launcher.
- Add recently installed app to "recent apps" for quick discovery.
BUG=633365
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2225073002
Cr-Commit-Position: refs/heads/master@{#412072}
(cherry picked from commit 3f4de06f8aea12e28828adbdcd56307b228c0e2a)
Review URL: https://codereview.chromium.org/2253253002 .
Cr-Commit-Position: refs/branch-heads/2785@{#644}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
DevTools: Make sure the worker instance is not collected while the promise is in flight.
BUG=637161
Review-Url: https://codereview.chromium.org/2239753003
Cr-Commit-Position: refs/heads/master@{#411553}
(cherry picked from commit e68f462e0eee7ce6a4befad62fee5fb76bc61da4)
Review URL: https://codereview.chromium.org/2247183006 .
Cr-Commit-Position: refs/branch-heads/2785@{#643}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Count the SetOutputNodeVolume requests sent during the audio initialization and track them with the OutputNodeVolumeChanged signals responding from cras, do not pop up the volume bar for such signals.
BUG=625222
[email protected]
Review URL: https://codereview.chromium.org/2250963003 .
Review-Url: https://codereview.chromium.org/2146313005
Cr-Original-Commit-Position: refs/heads/master@{#406014}
Cr-Commit-Position: refs/branch-heads/2785@{#642}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to M53][ChromeOS] Change the "all apps" icon in the launcher to be a drop down icon.
See the comment#6 in the bug 633365 for the mock.
BUG=633365
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2229303003
Cr-Commit-Position: refs/heads/master@{#412003}
(cherry picked from commit 85b90cfd3234c776cae303ba6660e6143eb68baa)
Review URL: https://codereview.chromium.org/2245103005 .
Cr-Commit-Position: refs/branch-heads/2785@{#641}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Sync] Fix behavior when there are two type roots for a type
Due to a bug in how server generated root nodes for autofill wallet metadata
were created, clients can have both an implicitly created root node and an
explicitly (server-side) created root node. This change makes it so we
gracefully handle this by allowing both to live side by side in the
parent_child_index, and ensures new entities don't become invisible.
BUG=630035
Review-Url: https://codereview.chromium.org/2168273002
Cr-Commit-Position: refs/heads/master@{#407544}
(cherry picked from commit ca751c9fd46d972b9e18aff7871df323b1cccaff)
Review URL: https://codereview.chromium.org/2256473004 .
Cr-Commit-Position: refs/branch-heads/2785@{#640}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Do not notify Volume change event to CrasAudioHandler::Observer when CrasAudioHandler change volume during initialization.
BUG=625222
[email protected]
Review URL: https://codereview.chromium.org/2256773002 .
Review-Url: https://codereview.chromium.org/2127033004
Cr-Original-Commit-Position: refs/heads/master@{#404448}
Cr-Commit-Position: refs/branch-heads/2785@{#639}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Cancel autoplay muted when visible if the video gets unmuted before being visible.
Otherwise, we end up autoplaying unmuted.
BUG=627451
[email protected]
Review-Url: https://codereview.chromium.org/2250393002
Cr-Commit-Position: refs/heads/master@{#412512}
(cherry picked from commit c578967369c610605ef62747d0b33f986cab0e23)
Review URL: https://codereview.chromium.org/2253683004 .
Cr-Commit-Position: refs/branch-heads/2785@{#638}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add metrics for schemes of content setting exceptions
Add a uma metric to collect data for schemes (http/https/file/chrome-extension) of
content setting exceptions.
BUG=621724
Review-Url: https://codereview.chromium.org/2226643002
Cr-Commit-Position: refs/heads/master@{#411245}
(cherry picked from commit d06a12d4cf219e1c310cdc736736f35d6168de49)
Review URL: https://codereview.chromium.org/2250713003 .
Cr-Commit-Position: refs/branch-heads/2785@{#637}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Storage manager: Fix font size and adjust layout.
In the previous layout spec, the font size looks too big compared to other parts in Settings.
This CL adjust the font size and some layout.
The spec is https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OWkdMM2tJanUxdjg
BUG=636224
TEST=confirmed manually on minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
Review-Url: https://codereview.chromium.org/2233693002
Cr-Commit-Position: refs/heads/master@{#411260}
(cherry picked from commit 3f134220f879b3ec4a29d985ac94c10c7b82524c)
Review URL: https://codereview.chromium.org/2250903002 .
Cr-Commit-Position: refs/branch-heads/2785@{#636}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}