Publish DEPS for Chromium 53.0.2785.30
Incrementing VERSION to 53.0.2785.30
Cr-Commit-Position: refs/branch-heads/2785@{#352}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix the mobile emulator to use the correct device scale when disabled.
The mobile emulator was triggering a layout before it had reapplied the
original viewport parameters when it was being disabled, which with
use-zoom-for-dsf enabled was causing the wrong viewport size to be given
to various components, like plugins and scrollbars.
BUG=628501,628185
[email protected]
Review URL: https://codereview.chromium.org/2168313002 .
Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f
Cr-Original-Commit-Position: refs/heads/master@{#407294}
Cr-Commit-Position: refs/heads/master@{#407639}
(cherry picked from commit 1c78b3850f956c1507e4cdf9429652ee0ef15cb0)
Review URL: https://codereview.chromium.org/2183533003 .
Cr-Commit-Position: refs/branch-heads/2785@{#351}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Defer effects of HandleViewed/HandleClosed until prefs are loaded again.
This CL changes NotificationPromo's HandleViewed/HandleClosed methods to
not update the current instance variables and just save the updated
values to prefs. This is needed because HandleViewed can be called
in the middle of the chain of CanShow calls made during layout of the
NTP, causing some CanShow calls to return true while others to return
false during the same layout. By not saving the updated values to the
current instance variables, the CanShow calls will remain consistent
during the same layout. To facilitate this change, this CL also changes
the return type of HandleViewed to void since the return value is never
used.
BUG=625192
Review-Url: https://codereview.chromium.org/2140173009
Cr-Commit-Position: refs/heads/master@{#407218}
(cherry picked from commit ab57275f5b35d23c5d8504782f229cebdb7de8eb)
Review URL: https://codereview.chromium.org/2181833003 .
Cr-Commit-Position: refs/branch-heads/2785@{#350}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.29
Cr-Commit-Position: refs/branch-heads/2785@{#349}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
switch translate element loading domain
BUG=630068
Review-Url: https://codereview.chromium.org/2167843005
Cr-Commit-Position: refs/heads/master@{#407279}
(cherry picked from commit 149a3740a58de22cd0ebbd0fe962a9f116c2e776)
Review URL: https://codereview.chromium.org/2183623002 .
Cr-Commit-Position: refs/branch-heads/2785@{#348}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[merge to m53] Fix getComputedStyle for non-box-layout elements
This fixes a crash introduced by https://codereview.chromium.org/1826423003/
Code that treated a layout object as a Box layout were not properly
guarded by isBox. This caused a crash when calling getComputedStyle on
positioned non-box elements, e.g. <ruby>.
[email protected]
BUG=610986
Review-Url: https://codereview.chromium.org/2102843002
Cr-Commit-Position: refs/heads/master@{#404336}
(cherry picked from commit 86d16a615d6e9abf6d991f430b496c26a4271d10)
Review URL: https://codereview.chromium.org/2177243004 .
Cr-Commit-Position: refs/branch-heads/2785@{#347}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add macro definition __CHROMEOS__ for ChromeOS builds in GYP.
This is needed for clients that need to address some special
behaviors of ChromeOS.
This is intended to be a cherry-pick for older releases, where
GYP is used
BUG=chromium:628040
Review-Url: https://codereview.chromium.org/2180803003
Cr-Commit-Position: refs/heads/master@{#407630}
(cherry picked from commit b655d0a1b0ea8cf0dc8e29ee650c8a55b79337d1)
Review URL: https://codereview.chromium.org/2182693004 .
Cr-Commit-Position: refs/branch-heads/2785@{#346}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Mac: Correct CALayer reuse logic
This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.
With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.
A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.
BUG=618287
Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}
(cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731)
Review URL: https://codereview.chromium.org/2184463002 .
Cr-Commit-Position: refs/branch-heads/2785@{#345}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
exo: Fix crash in out-of-order destruction of Gamepad
Destroying the gaming input resource will destroy the gamepad
polling thread, which causes the Gamepad destructor to access an
invalid reference to the task runner of that thread.
This CL changes the raw pointer to a ref counted pointer so we won't
destroy the task runner prematurely.
BUG=620977
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2159283002
Cr-Commit-Position: refs/heads/master@{#406327}
(cherry picked from commit a3633143505b30713e83baabfa7767877bf79788)
Review-Url: https://codereview.chromium.org/2179173002
Cr-Commit-Position: refs/branch-heads/2785@{#344}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
wayland-protocols: Add gaming-input-unstable-v1 protocol
This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.
BUG=620977
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2093803002
Cr-Commit-Position: refs/heads/master@{#405238}
(cherry picked from commit 350078de44e0def33380d1074446408f6ebe6967)
Review-Url: https://codereview.chromium.org/2182703002
Cr-Commit-Position: refs/branch-heads/2785@{#343}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Filter GestureFlingStarts with Vx=Vy=0 in RenderWidgetHostViewChildFrame
This CL fixes both (1) the renderer crash originally fixed by
https://codereview.chromium.org/2165043002, and (2) reverts the part
of that CL which prevents ChromeOS from having zero-velocity
GestureFlingStarts, which caused a regression in two-finger swipe
navigation for touchpad. It also moves the DCHECK from the original CL
to a new location which would have prevented the renderer crashes from
being introduced in the first place.
This CL doesn't include a test, though the test proposed by
khmel@ in https://codereview.chromium.org/2168693003 presumably will
land shortly after this CL.
BUG=627227
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2173603002
Cr-Commit-Position: refs/heads/master@{#407275}
(cherry picked from commit d51673024bb1990807d86e8acfbf7759748fbae3)
Review URL: https://codereview.chromium.org/2182693003 .
Cr-Commit-Position: refs/branch-heads/2785@{#342}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Don't create zero-velocity GestureFlingStarts.
Currently trackpad initiated GestureFlingStarts on CrOS can have zero-
velocity, but this causes crashes in the renderer. This CL converts
these events to be GestureFlingCancels (just in case they are issued
in the middle of ongoing fling).
As it is hard to find the sources of such events after the fact, a
DCHECK has been added to catch new pathways if they issue such events.
BUG=627227
Review-Url: https://codereview.chromium.org/2165043002
Cr-Commit-Position: refs/heads/master@{#406678}
(cherry picked from commit e80690ff28bf6db9392ab9b96a31105e1a6d4205)
Review URL: https://codereview.chromium.org/2176373002 .
Cr-Commit-Position: refs/branch-heads/2785@{#341}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
This CL implements the gamepads wayland API. Since js device nodes on linux can be opened multiple times, we are not required to go through the content::GamepadService, but can directly use our own device::GamepadPlatformDataFetcher in our own polling thread. The polling thread will compare the newly fetched data to the previous data and send any changes as events to the wayland client.
BUG=620977
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2076013002
Cr-Commit-Position: refs/heads/master@{#405356}
(cherry picked from commit 68de182439eed91857dafbb4348f1e4857b18c69)
Review-Url: https://codereview.chromium.org/2179903003
Cr-Commit-Position: refs/branch-heads/2785@{#340}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Notify the Blink client synchronously if the initial doc is accessed.
This avoids problems with the timer being delayed by nested message
loops and ScopedPageLoadDeferrers, where code in the nested message
loop might access the document and not generate a notification.
The timer was originally added to prevent re-entrant calls to V8,
but that can now be prevented with ScriptForbiddenScope.
BUG=629542
TEST=See bug for repro steps.
Review-Url: https://codereview.chromium.org/2171063002
Cr-Commit-Position: refs/heads/master@{#407269}
(cherry picked from commit 00314989401bfee5ffcb5e579162071c86e72f61)
Review URL: https://codereview.chromium.org/2179763004 .
Cr-Commit-Position: refs/branch-heads/2785@{#339}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Avoid crashing if MHTMLGenerationManager::JobFinished is called twice.
This CL makes sure that MHTMLGenerationManager::JobFinished is
idempotent and doesn't do anything when called for a second time.
This avoids the crash from the linked bug.
BUG=612098
Review-Url: https://codereview.chromium.org/2163073002
Cr-Commit-Position: refs/heads/master@{#407244}
(cherry picked from commit a668d7811c2c19662cbeec9e10a3e283292445e5)
Review URL: https://codereview.chromium.org/2182673003 .
Cr-Commit-Position: refs/branch-heads/2785@{#338}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Updating XTBs based on .GRDs from branch 2785
Cr-Commit-Position: refs/branch-heads/2785@{#337}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Gamepad: Fix GYP build on Linux
GN config on Linux has a dependency on //device/udev_linux when use_udev==1, but
GYP config does not have the equivalent. This is failing GYP build on Linux.
This gyp file was changed in
https://codereview.chromium.org/2081583002
BUG=612330
Review-Url: https://codereview.chromium.org/2132453002
Cr-Commit-Position: refs/heads/master@{#404173}
(cherry picked from commit 67b3938316821d5ccd3d41b2c002f99b1dd125c1)
Review URL: https://codereview.chromium.org/2180993002 .
Cr-Commit-Position: refs/branch-heads/2785@{#336}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
gyp: don't build gamepad_platform_data_fetcher_linux.cc when udev is disabled
Fixup after https://codereview.chromium.org/2081583002
BUG=612330
Review-Url: https://codereview.chromium.org/2125223003
Cr-Commit-Position: refs/heads/master@{#404168}
(cherry picked from commit 3fd0432005a1a370ed273077aec593acd1aa963c)
Review URL: https://codereview.chromium.org/2180983002 .
Cr-Commit-Position: refs/branch-heads/2785@{#335}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Migrating majority of gamepad from content/browser/ to device/
BUG=612330
Review-Url: https://codereview.chromium.org/2081583002
Cr-Commit-Position: refs/heads/master@{#403998}
(cherry picked from commit b9bb4c42d6b19a7d7131af942d3769c54e89981c)
Review URL: https://codereview.chromium.org/2182653002 .
Cr-Commit-Position: refs/branch-heads/2785@{#334}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Cronet] Mark request as complete when OutputStream fails
When consumer specifies a chunked upload or a fixed stream upload, Cronet's
HttpURLConnection starts the request right away. If an error happens, we will
surface that error as an IOException to consumer. However, if the consumer
tries to call any other API (like getResponseCode(), getResponseMessage())
afterwards, we will spin up the message loop and wait forever.
This CL marks the request as complete if an error occurred in upload, so
getResponseCode() etc. do not spin up the message loop to wait for response.
[email protected]
NOTRY=true
NOPRESUBMIT=true
BUG=630664
Review-Url: https://codereview.chromium.org/2173923002
Cr-Commit-Position: refs/heads/master@{#407468}
(cherry picked from commit 7fbfe4fe8ff451d1f65ac574a2304d383aaeec16)
Review-Url: https://codereview.chromium.org/2175403002
Cr-Commit-Position: refs/branch-heads/2785@{#333}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Material][Mac] Fixed Bookmark Items Highlight Issues
Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled
BUG=627722, 628187, 628204
Review-Url: https://codereview.chromium.org/2169623002
Cr-Commit-Position: refs/heads/master@{#407032}
(cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309)
Review URL: https://codereview.chromium.org/2180963002 .
Cr-Commit-Position: refs/branch-heads/2785@{#332}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix extension bindings injection for iframes
For iframes, we don't want to use the source url for determining the
associated extension because it starts out with an about:blank context
that is scriptable by its parent.
BUG=573131
Review-Url: https://codereview.chromium.org/2151693002
Cr-Commit-Position: refs/heads/master@{#407214}
(cherry picked from commit 91f655b19888da3f86b57ad8c548da93e7b9aba4)
Review URL: https://codereview.chromium.org/2183443002 .
Cr-Commit-Position: refs/branch-heads/2785@{#331}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert the patch that has disabled Panels for M53 (https://codereview.chromium.org/2083113002)
The current plan is to remove the code for M54 but
keep the Panels enabled for M53 to provide more time for transition.
BUG=571511
Review-Url: https://codereview.chromium.org/2176823002
Cr-Commit-Position: refs/heads/master@{#407262}
(cherry picked from commit af86f4caef16dc6a12edbb8305ba2149ee763cc9)
Review URL: https://codereview.chromium.org/2177303002 .
Cr-Commit-Position: refs/branch-heads/2785@{#330}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix a crash on selecting a suggestion.
Sometimes the underlying results change after the selection was made and
we crash in updateMatchDestination. Instead, try to find if we still
have an underlying result, and update the index if necessary or just
skip the URL update.
BUG=629124,595395
Review-Url: https://codereview.chromium.org/2159363002
Cr-Commit-Position: refs/heads/master@{#406608}
(cherry picked from commit 0f92cee49214da9099c08d493cc83c3fa7e79dc9)
Review URL: https://codereview.chromium.org/2174243003 .
Cr-Commit-Position: refs/branch-heads/2785@{#329}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge "exo: Add notification surface to manager after commit"
> Add notification surface to manager after commit so that it has
> the correct content size when creating the hosting view.
>
> BUG=629854
>
> Review-Url: https://codereview.chromium.org/2169513003
> Cr-Commit-Position: refs/heads/master@{#406851}
> (cherry picked from commit e55d9d3bf6082a636271efda6ece4cd04dc94109)
Review URL: https://codereview.chromium.org/2177973002 .
Cr-Commit-Position: refs/branch-heads/2785@{#328}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[arc-intents] Adjust link-click detection code.
Use the page transition, which seems more reliable, rather than the
HasUserGesture method, to detect whether a given navigation event was
spawned by the user clicking on a link.
BUG=630072
Review-Url: https://codereview.chromium.org/2165193002
Cr-Commit-Position: refs/heads/master@{#407256}
(cherry picked from commit ef206ad2f2bd182205b4adb5580c00e7967c4fd8)
Review URL: https://codereview.chromium.org/2175353002 .
Cr-Commit-Position: refs/branch-heads/2785@{#327}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Use chrome-content-suggestions scope when needed.
webhistory is good for Chrome Reader, but access to the Chrome Content
Suggestions Server is under the chrome-content-suggestions scope.
BUG=629531
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2163203002
Cr-Commit-Position: refs/heads/master@{#406826}
(cherry picked from commit ee6b29bca260eee63fab12805c84612d76c4b318)
Review-Url: https://codereview.chromium.org/2177193003
Cr-Commit-Position: refs/branch-heads/2785@{#326}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
customtabs: Don't crash when the death notificaton is sent to a random thread.
When a Custom Tabs client dies, the Android framework sends a
notification to an IBinder.DeathRecipient. This is relayed by
CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this
method is called from a different thread than the UI thread, then this
triggers a native crash.
Avoid that crash by making sure that mClientManger#cleanupSession() (and
then CustomTabsConnection#cancelPrerender()) is called from the UI thread.
Also add a non-regression test.
BUG=623128
Review-Url: https://codereview.chromium.org/2158843003
Cr-Commit-Position: refs/heads/master@{#407101}
(cherry picked from commit 1fb838fe1139f442dc24eddb08aa3b3bb408c5d8)
Review URL: https://codereview.chromium.org/2178893002 .
Cr-Commit-Position: refs/branch-heads/2785@{#325}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] [Payments] Use the correct index when checking addresses
We have an off-by-one error now that the mOptionLayout can have multiple children in it above the actual options.
* Use the correct index when indexing into the options layout.
* Add a test that checks for the crash and additionally checks that the "merchant doesn't accept address" string is
correctly displayed.
* Plumbs a new callback that indicates that the client has finished
checking the selection.
BUG=630348
Review-Url: https://codereview.chromium.org/2170603006
Cr-Commit-Position: refs/heads/master@{#407197}
(cherry picked from commit 80155b30015fca0ea8774117ee2a9b8d0d8da91d)
Review URL: https://codereview.chromium.org/2173383002 .
Cr-Commit-Position: refs/branch-heads/2785@{#324}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Autofill cards at the bottom of the PaymentRequest UI
This patch arranges the payment instruments in the following order:
> Non-autofill payment apps
> Complete credit cards from Autofill.
> Incomplete credit card from Autofill (need editing before sending to
the merchant).
BUG=629882
Review-Url: https://codereview.chromium.org/2165163002
Cr-Commit-Position: refs/heads/master@{#407179}
(cherry picked from commit 84204fda8113ffef6766812db30d6e11fee1269c)
Review URL: https://codereview.chromium.org/2179703002 .
Cr-Commit-Position: refs/branch-heads/2785@{#323}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Removing autofill addresses should not crash PaymentRequest
BUG=630056
Review-Url: https://codereview.chromium.org/2165023004
Cr-Commit-Position: refs/heads/master@{#407071}
(cherry picked from commit 6b49e38ad8f0bf3c4f02eeb23134008ff9c47669)
Review URL: https://codereview.chromium.org/2181553002 .
Cr-Commit-Position: refs/branch-heads/2785@{#322}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.28
Cr-Commit-Position: refs/branch-heads/2785@{#321}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
exo: Implement custom fullscreening for ShellSurfaces.
This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.
BUG=630696,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen
Review-Url: https://codereview.chromium.org/2177623002
Cr-Commit-Position: refs/heads/master@{#407248}
(cherry picked from commit 25f638ab8c4adbf3470b2e0e07183919f60bc3f9)
Review URL: https://codereview.chromium.org/2174193002 .
Cr-Commit-Position: refs/branch-heads/2785@{#320}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.27
Cr-Commit-Position: refs/branch-heads/2785@{#319}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M53] gpu: Disable multisample on more adreno renderers
We know for sure the initial N release for N5X/N6P will have multisample
bugs. There is evidence as well that adreno 530 drivers in existing
devices like samsung s7 is affected as well. Expand the workaround to
cover these devices.
Planning on merging back to m52
BUG=612474
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2176703002
Cr-Commit-Position: refs/heads/master@{#407311}
(cherry picked from commit 1243666b4f5c7c48312233e1f6e6fda46191b184)
Review URL: https://codereview.chromium.org/2175073002 .
Cr-Commit-Position: refs/branch-heads/2785@{#318}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.26
Cr-Commit-Position: refs/branch-heads/2785@{#317}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Mark calendar/data picker tests @150% failing on Linux Dbg.
virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html
BUG=627754,593567
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2139293003
Cr-Commit-Position: refs/heads/master@{#405109}
(cherry picked from commit 68a356c37d43acc2e21a43bb500211bef227cfe2)
Review URL: https://codereview.chromium.org/2178673003 .
Cr-Commit-Position: refs/branch-heads/2785@{#316}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Mark svg/filters/filter-source-position.svg as flaky on Win.
BUG=613414
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2143413002
Cr-Commit-Position: refs/heads/master@{#405122}
(cherry picked from commit 2632eeeb86466e4774d4e901e5b4e307efc80ae0)
Review URL: https://codereview.chromium.org/2175953002 .
Cr-Commit-Position: refs/branch-heads/2785@{#315}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add finch control for use-zoom-for-dsf.
BUG=613414
Review-Url: https://codereview.chromium.org/2147143003
Cr-Commit-Position: refs/heads/master@{#405922}
(cherry picked from commit 9dc180d31f8452c215651ccacbf1b5fc731f479d)
Review URL: https://codereview.chromium.org/2180583002 .
Cr-Commit-Position: refs/branch-heads/2785@{#314}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Try to fix crash because of InlineBox deletion in a cached subsequence
Don't know why the crashes occurred on bots. Couldn't reproduce the
crashes reported by clusterfuzz locally. Based on the stack, the crash
are because of deletion of an InlineBox in a cached subsequence.
This partly reverts https://codereview.chromium.org/2160983007/.
BUG=619630,628117
[email protected]
Review URL: https://codereview.chromium.org/2170583003 .
Review URL: https://codereview.chromium.org/2180573002 .
Cr-Original-Commit-Position: refs/heads/master@{#406925}
Cr-Commit-Position: refs/branch-heads/2785@{#313}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Enable use-zoom-for-dsf by default.
BUG=613414
Review-Url: https://codereview.chromium.org/2044963004
Cr-Commit-Position: refs/heads/master@{#404875}
(cherry picked from commit f449a7f4828a5610b1e21b8d2e378555fa59ca7b)
Review URL: https://codereview.chromium.org/2173243002 .
Cr-Commit-Position: refs/branch-heads/2785@{#312}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
WebViewPlugin: Post geometry-update actions to a task to run async.
WebViewPlugin resizes itself and actually may load a new plugin in
response to a geometry update.
Geometry updates are triggered during layout, and Blink assumes these
things can't happen during layout.
Therefore, post these actions to a task to run asynchronously. This is
the same approach that PepperPluginInstanceImpl takes.
BUG=628629
Review-Url: https://codereview.chromium.org/2164753003
Cr-Commit-Position: refs/heads/master@{#406908}
(cherry picked from commit d16e91647e4238b13301fdfc3dce960427f4d18e)
Review URL: https://codereview.chromium.org/2178663002 .
Cr-Commit-Position: refs/branch-heads/2785@{#311}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Updating XTBs based on .GRDs from branch 2785
Cr-Commit-Position: refs/branch-heads/2785@{#310}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge to M53: Null-check render_frame_ in PepperPluginInstanceImpl::Initialize
BUG=627206
Review-Url: https://codereview.chromium.org/2160973002
Cr-Commit-Position: refs/heads/master@{#406229}
(cherry picked from commit d7411acd92d04753e83b4eef6e3a4021a9c6edb7)
Review URL: https://codereview.chromium.org/2172383002 .
Cr-Commit-Position: refs/branch-heads/2785@{#309}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix incognito tabs persisting when cct service is active
Swiping away the Chrome activity does not cause the process to be killed
if a Chrome Custom Tab is open somewhere. In this case, when Chrome is
started again, the CipherData static still has the old Activity's
incognito key stored in it and the tabs are unexpectedly restored.
This changes the start-up behaviour to explicitly ignore incognito tab
state files when no bundle is passed to the activity's onCreate.
TBR=amineer
BUG=626629
Review URL: https://codereview.chromium.org/2170413003 .
Review-Url: https://codereview.chromium.org/2166943002
Cr-Original-Commit-Position: refs/heads/master@{#406747}
Cr-Commit-Position: refs/branch-heads/2785@{#308}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge to M53: Bypass cached element rects in AXLayoutObject.
AXLayoutObject has code to cache the computed bounding box of an element
because the computation can be expensive. However, it has a bug in that
the cache doesn't get properly invalidated when an object's position changes
due to only a CSS transformation.
This is resulting in a serious user issue on Android (b/28988142) so
this patch just temporarily removes the element rect caching. This will
unfortunately impact performance, some pages will load more slowly when
accessibility is enabled.
I've been working on a better longer-term fix for many months - storing
relative bounding boxes and transformation matrixes instead. It's much
faster to compute those and doesn't require any caching to be fast.
Unfortuantely it looks like we need to trade performance for correctness
in the short term because there isn't a trivial fix to make the cache
work.
BUG=629439
Review-Url: https://codereview.chromium.org/2168663002
Cr-Commit-Position: refs/heads/master@{#406663}
(cherry picked from commit d091cc2097ed7cedb7d310a4161f022ae870bddc)
Review URL: https://codereview.chromium.org/2179573002 .
Cr-Commit-Position: refs/branch-heads/2785@{#307}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
gpu: Keep original GMB alive to workaround problem with importing of UDL/EVDI buffers.
Destroying the original buffer invalidates kernel state such that
importing from the FD doesn't work as expected. By keeping the
original buffer alive we avoid this issue for scanout buffers used
by the browser process.
BUG=628334
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2171713004
Cr-Commit-Position: refs/heads/master@{#406973}
(cherry picked from commit 1ff18bae4738ee3d62c2310d9e03211054be0582)
Review URL: https://codereview.chromium.org/2171213003 .
Cr-Commit-Position: refs/branch-heads/2785@{#306}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
gpu: Take surface handle into account when importing buffers.
This makes us use the appropriate DRM device when importing
native GMBs on Ozone instead of always using the primary device.
BUG=626807,597932
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2148983002
Cr-Commit-Position: refs/heads/master@{#406322}
(cherry picked from commit 15e3d9a4516ad22cc56c1ff162f32f3d03e8de9f)
Review URL: https://codereview.chromium.org/2178563002 .
Cr-Commit-Position: refs/branch-heads/2785@{#305}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] Handle transition to error state in MCAD for EOS.
Merge to M53 of https://codereview.chromium.org/2160823002 .
If MediaCodecLoop transitions to the error state while an EOS is
queued, it was possible for MediaCodecAudioDecoder to try to dequeue
the EOS after it was freed by the error transition. In particular,
if an unknown status was returned while dequeuing output, it would
not prevent future dequeues from being attempted.
To fix this, this CL does two things:
- make MCL::ProcessOneOutputBuffer check for the error state before
trying to do more work. This mirros what ProcessOneInputBuffer
already does.
- make MCAD::OnDecodedEos check for the error state explicitly,
since it shouldn't depend that MCL won't call it back while in
the error state.
I wasn't able to repro locally, but the stack in the CF report does
make it seem likely that it did this.
BUG=629010
NOPRESUBMIT=true
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2177573002
Cr-Commit-Position: refs/branch-heads/2785@{#304}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] Delay removing input buffers in MCAD.
Merge to M53 of https://codereview.chromium.org/2145643006 .
MCAD was previously droppings its reference to the DecoderBuffer,
which could potentially free the encoded data buffer before MCL
queued it.
This CL causes it to delay dropping its reference until MCL signals
that it is done with the data.
This CL also stops the MCL timer during destruction, rather than
relying on MCAD::Reset to do so indirectly via TryFlush and / or
destroying the MCL instance.
BUG=627352
NOPRESUBMIT=true
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2175853002
Cr-Commit-Position: refs/branch-heads/2785@{#303}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Record and log the use of a profile and/or credit card
when they get used in in Payment Request. Calls the RecordAndLogUse()
method that is currently used in Autofill.
BUG=625643
TEST=PersonalDataManagerTest, PaymentRequestUseStatsTest
Review-Url: https://codereview.chromium.org/2126213002
Cr-Commit-Position: refs/heads/master@{#406692}
(cherry picked from commit 0b85d558587cb6195338161ca6ebcf77f6b7166d)
Review URL: https://codereview.chromium.org/2170213003 .
Cr-Commit-Position: refs/branch-heads/2785@{#302}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Don't show [+ ADD CARD] button for merchant that does not take cards.
If the merchant does not accept cards as forms of payment, then do not
show [+ ADD CARD] button the PaymentRequest UI. Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=243022&inline=1
BUG=628781
Review-Url: https://codereview.chromium.org/2158453003
Cr-Commit-Position: refs/heads/master@{#406645}
(cherry picked from commit 4f0ae181161cdec13eb29cc8753aaa83c587a332)
Review URL: https://codereview.chromium.org/2179483003 .
Cr-Commit-Position: refs/branch-heads/2785@{#301}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Enable PaymentRequest on Android by default.
BUG=627648
Review-Url: https://codereview.chromium.org/2145793002
Cr-Commit-Position: refs/heads/master@{#406631}
(cherry picked from commit 59899871c544eb16d31c31b6eb761f83de00fd7d)
Review URL: https://codereview.chromium.org/2179503002 .
Cr-Commit-Position: refs/branch-heads/2785@{#300}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M53] Put STHSet component behind a base::Feature.
Keeps its default state as enabled, as before, but this
lets us experiment with turning it off experimentally to
see whether it may be causing a suspected startup
regression.
BUG=626676, 607946
Review-Url: https://codereview.chromium.org/2131233002
Cr-Commit-Position: refs/heads/master@{#404457}
(cherry picked from commit 6cc7584e55ab69b8a3454f1054fcf982f4a2584a)
[email protected]
Review URL: https://codereview.chromium.org/2170373003 .
Cr-Commit-Position: refs/branch-heads/2785@{#299}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] NotSupportedError for payment apps without instruments.
If the merchant website requests only a payment app that happens to not
have any payment instruments and no ability to add an instrument from
within PaymentRequest UI, then reject the show() promise with
NotSupportedError.
BUG=628685
Review-Url: https://codereview.chromium.org/2159513002
Cr-Commit-Position: refs/heads/master@{#406558}
(cherry picked from commit 036c952c9a98ce9b25d7020fe865727b172d501a)
Review URL: https://codereview.chromium.org/2173893002 .
Cr-Commit-Position: refs/branch-heads/2785@{#298}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Constrained Web Dialogs] [Views] Enable autoresizing immediately if intended.
For constrained web dialogs, we currently enable autoresizing post-constructor, either when the document has loaded or when the RenderViewHost has been created or changed.
Recently, we've found that this causes a race condition where the DelegatedFrameHost's resize lock is sometimes created on ChromeOS when we don't intend to. The resize lock should never be created when autoresizing is enabled. However, since we don't enable autoresizing until later, the lock is sometimes created before autoresizing has been enabled.
The resize lock is never created on non-ChromeOS platforms.
This change enables autoresizing to the constructor for views. If the max size is defined, we know the dialog will set to autoresize at some point, so it's fine to do that sooner rather than later. When the RVH is created or swapped, we also want to enable autoresizing immediately. This change also adds a check that we should not have a resize lock if autoresizing is enabled.
Mac OSX cleanup will be done in a separate patch.
BUG=609863
Review-Url: https://codereview.chromium.org/2140753004
Cr-Commit-Position: refs/heads/master@{#404954}
(cherry picked from commit 5c3d7e3bbd734669458396ab1c56041f7670a2d5)
Review URL: https://codereview.chromium.org/2175743003 .
Cr-Commit-Position: refs/branch-heads/2785@{#297}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
omnibox: make decorations non-focusable for now
The key view loop is messed up for these decorations, as described in
https://crbug.com/623883, so let's make them non-focusable pending a real fix.
BUG=623883
Review-Url: https://codereview.chromium.org/2155233002
Cr-Commit-Position: refs/heads/master@{#406376}
(cherry picked from commit bd2ba8d0939223348e7b01d5c0398fde744fb72f)
Review URL: https://codereview.chromium.org/2178473002 .
Cr-Commit-Position: refs/branch-heads/2785@{#296}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M53] STH Set: Delay loading until after start-up.
When loading the STHs, the STHSet Component will invoke the
SafeJsonParser up to half a dozen times (one for each STH), which
can have performance implications.
Also update the PostAfterStartupTask documentation to indicate the
task will be posted immediately if called after start-up.
BUG=607946
Review-Url: https://codereview.chromium.org/2140093002
Cr-Commit-Position: refs/heads/master@{#406009}
(cherry picked from commit af4e289461794790203de6d050198b7e8e7ad5d1)
[email protected]
Review URL: https://codereview.chromium.org/2179473002 .
Cr-Commit-Position: refs/branch-heads/2785@{#295}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Queued wheel events should not use ScopedInputScaleDisabler.
Since WebMouseWheelEvents returned by BrowserPlugin are sent to the
guest's RenderWidgetHostImpl, which queues them and (may) send them
later, they should have the device_scale_factor explicitly removed, as
RenderWidgetHostImpl/InputRouterImpl may re-add it before sending.
BUG=601875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2164673002
Cr-Commit-Position: refs/heads/master@{#406417}
(cherry picked from commit 288a99fe15afb1dfefbe253aaa3a5de3c249d866)
Review URL: https://codereview.chromium.org/2174633003 .
Cr-Commit-Position: refs/branch-heads/2785@{#294}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.
We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.
BUG=626831
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
Review-Url: https://codereview.chromium.org/2169393002
Cr-Commit-Position: refs/branch-heads/2785@{#293}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread()
ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main
thread and its String members should not be accessed from a non-main thread
in decodeImageOnDecoderThread().
This CL passes deep copies of some |m_options| members via crossThreadBind()
as arguments of decodeImageOnDecoderThread().
BUG=627048
Review-Url: https://codereview.chromium.org/2137973002
Cr-Commit-Position: refs/heads/master@{#404997}
(cherry picked from commit 12d642c17c4248436f45c1c551de111725827575)
Review URL: https://codereview.chromium.org/2170373002 .
Cr-Commit-Position: refs/branch-heads/2785@{#292}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to 2785] Hide the DIV containing password import/export buttons
The import/export feature for passwords is currently behind a flag. However,
the settings WebUI hides the controls instead of the containing DIV. As a
result, on loading the settings, the space for the controls is briefly
taken into consideration and a vertical scrollbar shows up.
This CL hides the containing DIV instead of the individual controls.
Test steps:
With chrome://flags/#password-import-export enabled, observe that about:settings/passwords looks the same as without the patch. With chrome://flags/#password-import-export disabled, observe that during reloading of about:settings/passwords, no vertical scroll bar is flashing/seen.
BUG=626634
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2154223002
Cr-Commit-Position: refs/heads/master@{#406616}
(cherry picked from commit 33bd96dd8b9c462fe5a83d43a6ce535321907ca5)
Review URL: https://codereview.chromium.org/2176573002 .
Cr-Commit-Position: refs/branch-heads/2785@{#291}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Reland "Ensure |m_image| is (re-)created in ImageResource::didAddClient()"
After ImageResource is pruned, |m_image| can be turned into null, but is not
re-created when ResourceClient is added to ImageResource later.
We re-create |m_image| when ImageResourceObserver is added in
ImageResource::addObserver().
This CL do the same thing in ImageResource::didAddClient() to ensure |m_image|
is non-null when ImageResource is reused after pruning.
This is regression since ImageResourceClient was split into ResourceClient and
ImageResourceObserver but the |m_image| re-creation logic was put only in the
ImageResourceObserver path and not in the ResourceClient path:
https://codereview.chromium.org/1706083002
https://codereview.chromium.org/1728313003
BUG=618597, 587663
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2141843003
Cr-Commit-Position: refs/heads/master@{#405024}
(cherry picked from commit d415aad374ad81906840afbf4c05f0594f1f581b)
Review URL: https://codereview.chromium.org/2169363002 .
Cr-Commit-Position: refs/branch-heads/2785@{#290}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Abort booting ARC if the device is critically low on disk space.
If the device is too low on disk space (<64MB), ARC aborts booting,
and notification is shown to the user.
BUG=chromium:625923
TEST=components_unittests --gtest_filter='ArcBridgeTest.*'
TEST=chromeos_unittests
TEST=Notification shows up on login when free disk space is 40MB.
Review-Url: https://codereview.chromium.org/2136023002
Cr-Commit-Position: refs/heads/master@{#406218}
(cherry picked from commit 1821ddc81c38b0fbb42d9e1c0e59e42afa39b327)
Review URL: https://codereview.chromium.org/2168423003 .
Cr-Commit-Position: refs/branch-heads/2785@{#289}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Notify ARC instance failures via callbacks.
StopReason is passed to following observer methods:
- ArcBridgeBootstrap::Observer::OnStopped
- ArcBridgeService::Observer::OnBridgeStopped
Those callbacks can now tell the reason the bridge stopped.
I am planning to use this soon to show notifications on failures.
See the bug entry for more details.
BUG=chromium:625923
TEST=components_unittests --gtest_filter=ArcBridgeTest.*
TEST=Manually verified that ARC boots.
Review-Url: https://codereview.chromium.org/2133653002
Cr-Commit-Position: refs/heads/master@{#405241}
(cherry picked from commit 0c9dabff67eaefb515e9bc39299e33811915ffb4)
Review URL: https://codereview.chromium.org/2173703002 .
Cr-Commit-Position: refs/branch-heads/2785@{#288}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix WebSocket to set first party for cookies
BUG=618962
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2102993002
Cr-Commit-Position: refs/heads/master@{#405057}
(cherry picked from commit 8572d57f3e17612ce57406b6cbc15704b67901e9)
Review URL: https://codereview.chromium.org/2172953002 .
Cr-Commit-Position: refs/branch-heads/2785@{#287}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Revert "Ensure |m_image| is (re-)created in ImageResource::didAddClient()"
This reverts commit c2ef272fdddd2608b0aed1ff0eb0c13fa04d4bc4.
BUG=630531, 618597
Review URL: https://codereview.chromium.org/2175593003 .
Cr-Commit-Position: refs/branch-heads/2785@{#286}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge: ARC Opt in notification not shown.
As the profile id is not set, the notifications are never shown to user.
Instead they land in the notification center, and user needs to click
on the "1" icon to see it.
This CL fixes the issue by setting a correct profile id on the
notification.
TEST=Tested manually on a fresh profile.
BUG=629399
Review-Url: https://codereview.chromium.org/2160723004
Cr-Commit-Position: refs/heads/master@{#406428}
(cherry picked from commit 3ae0dad4690b7579921cd503e6a863467ef27bfe)
Review URL: https://codereview.chromium.org/2171213002 .
Cr-Commit-Position: refs/branch-heads/2785@{#285}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix mismatch in Site Engagement finch setup.
This CL adds a missing variation name in SiteEngagementScore that was
causing a crash when the finch config was read.
BUG=628691
Review URL: https://codereview.chromium.org/2174623002 .
Cr-Commit-Position: refs/branch-heads/2785@{#284}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Ensure |m_image| is (re-)created in ImageResource::didAddClient()
After ImageResource is pruned, |m_image| can be turned into null, but is not
re-created when ResourceClient is added to ImageResource later.
We re-create |m_image| when ImageResourceObserver is added in
ImageResource::addObserver().
This CL do the same thing in ImageResource::didAddClient() to ensure |m_image|
is non-null when ImageResource is reused after pruning.
This is regression since ImageResourceClient was split into ResourceClient and
ImageResourceObserver but the |m_image| re-creation logic was put only in the
ImageResourceObserver path and not in the ResourceClient path:
https://codereview.chromium.org/1706083002
https://codereview.chromium.org/1728313003
BUG=618597, 587663
Review-Url: https://codereview.chromium.org/2141843003
Cr-Commit-Position: refs/heads/master@{#405024}
(cherry picked from commit d415aad374ad81906840afbf4c05f0594f1f581b)
Review URL: https://codereview.chromium.org/2175613002 .
Cr-Commit-Position: refs/branch-heads/2785@{#283}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
arc: Add messages shown when Android apps can not be launched.
BUG=chromium:625923
TEST=CQ
Review-Url: https://codereview.chromium.org/2127703002
Cr-Commit-Position: refs/heads/master@{#404376}
(cherry picked from commit ad957a7bcebac8bff40c0037edbb689d083cfeed)
Review URL: https://codereview.chromium.org/2173663002 .
Cr-Commit-Position: refs/branch-heads/2785@{#282}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Open the notification URL (not the web app start_url) when deep-linking into standalone mode.
When deep-linking into a standalone web app from a notification, the
app's start_url is always opened and the URL that the notification wants
to open is ignored. This CL fixes the bug by injecting the notification
URL in place of the web app URL when deep-linking. We also force a
reload of the web app if it is already running to ensure that the desired
url is loaded.
Replacing the URL in this manner is correct as the notification URL is
guaranteed to live within the web app's scope for notification
deep-linking to trigger.
BUG=627791
Review-Url: https://codereview.chromium.org/2145833003
Cr-Commit-Position: refs/heads/master@{#405638}
(cherry picked from commit e10048ec434da0f56f6b2c5579bdbee2fa06654d)
Review URL: https://codereview.chromium.org/2173643002 .
Cr-Commit-Position: refs/branch-heads/2785@{#281}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add UMA stats for storage manager for Chrome OS.
Record user actions when:
- User clicks the storage management button in chrome://settings
- User clicks links to manage storage items on storage manager
BUG=629433
TEST=manually confirmed that expected logs were recorded in chrome://user-actions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2165503002
Cr-Commit-Position: refs/heads/master@{#406595}
(cherry picked from commit e50b2670f3ad15f999eb4881125dfb90d45b62e5)
Review URL: https://codereview.chromium.org/2175533002 .
Cr-Commit-Position: refs/branch-heads/2785@{#280}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix referrerPolicy IDL attribute spelling
In the grand tradition of trivial HTTP-referrer-related misspellings
that haunt the web forever, I miscapitalized the referrerPolicy IDL
attribute. This CL fixes the mistake for compatibility with Firefox and
the spec (see for example
https://html.spec.whatwg.org/multipage/semantics.html#the-a-element).
BUG=628718
Review-Url: https://codereview.chromium.org/2150393003
Cr-Commit-Position: refs/heads/master@{#406311}
(cherry picked from commit 3c3b9e79b591bdf2fdea29c1f44f455f124f2539)
Review URL: https://codereview.chromium.org/2168283003 .
Cr-Commit-Position: refs/branch-heads/2785@{#279}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
BodyStreamBuffer shouldn't run scripts when ActiveDOMObjects are stopped
Some DataConsumerHandle subclasses close the handle when ActiveDOMObjects are
stopped. BodyStreamBuffer::didGetReadable should not do anything because
executing scripts are forbidden in such cases. As BodyStreamBuffer::stop will
be called shortly, just returning early is enough.
BUG=625563
R=hiroshige
Review-Url: https://codereview.chromium.org/2146453002
Cr-Commit-Position: refs/heads/master@{#406542}
(cherry picked from commit edb37f2d98c9fc82d8366884eb4c45f75c48cc17)
Review URL: https://codereview.chromium.org/2173633002 .
Cr-Commit-Position: refs/branch-heads/2785@{#278}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.25
Cr-Commit-Position: refs/branch-heads/2785@{#277}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add CURRENT lock orientation.
* This also updates the API version:
The CL was rebased prior to land, which was accidentally merged with another CL that added version 12.
These APIs that I added haven't implemented yet, so it should be safe to update.
BUG=b/28341028
TEST=covered by unit tests.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2139893002 .
Cr-Commit-Position: refs/heads/master@{#404853}
(cherry picked from commit e5b8865795165551c8b0427d07b1e3f40067663b)
Review URL: https://codereview.chromium.org/2167373002 .
Committed: https://chromium.googlesource.com/chromium/src/+/48dc0fbcb6bc564ee0109a15b07972b034fca019
Committed: https://chromium.googlesource.com/chromium/src/+/0429de13037406486eab9234ee1f9bbba2dc6f0b
Cr-Commit-Position: refs/branch-heads/2785@{#276}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add CURRENT lock orientation.
* This also updates the API version:
The CL was rebased prior to land, which was accidentally merged with another CL that added version 12.
These APIs that I added haven't implemented yet, so it should be safe to update.
BUG=b/28341028
TEST=covered by unit tests.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2139893002 .
Cr-Commit-Position: refs/heads/master@{#404853}
(cherry picked from commit e5b8865795165551c8b0427d07b1e3f40067663b)
Review URL: https://codereview.chromium.org/2167373002 .
Committed: https://chromium.googlesource.com/chromium/src/+/48dc0fbcb6bc564ee0109a15b07972b034fca019
Cr-Commit-Position: refs/branch-heads/2785@{#275}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add CURRENT lock orientation.
* This also updates the API version:
The CL was rebased prior to land, which was accidentally merged with another CL that added version 12.
These APIs that I added haven't implemented yet, so it should be safe to update.
BUG=b/28341028
TEST=covered by unit tests.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2139893002 .
Cr-Commit-Position: refs/heads/master@{#404853}
(cherry picked from commit e5b8865795165551c8b0427d07b1e3f40067663b)
Review URL: https://codereview.chromium.org/2167373002 .
Cr-Commit-Position: refs/branch-heads/2785@{#274}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix NOTREACHED() errors in arc_net_host_impl
WebProxyAutoDiscoveryUrl is optional, so allow it to be empty.
Gateway isn't optional, but it isn't getting populated for IPv6. Note
the bug in the comments, and add a temporary workaround.
BUG=b:29402926
TEST=`grep NOTREACHED /var/log/ui/ui.LATEST`
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2112363002
Cr-Commit-Position: refs/heads/master@{#403526}
(cherry picked from commit 37f8d2f3416b744d964258e2c20324f97142a344)
Review-Url: https://codereview.chromium.org/2167113004
Cr-Commit-Position: refs/branch-heads/2785@{#273}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
PrecacheFetcher::CancelPrecaching should run in the main UI thread
Reducing the possibilities of crash in CancelPrecaching.
BUG=619111
Review-Url: https://codereview.chromium.org/2141183002
Cr-Commit-Position: refs/heads/master@{#404844}
(cherry picked from commit 268948da609bdca7b15353319395606cd72b4d2f)
Review URL: https://codereview.chromium.org/2165833008 .
Cr-Commit-Position: refs/branch-heads/2785@{#272}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Adjust width of find in page bar.
The text area now approximately fits "DesignDesignDesignDesign".
BUG=629217
Review-Url: https://codereview.chromium.org/2156423002
Cr-Commit-Position: refs/heads/master@{#406356}
(cherry picked from commit 043095f529a06276651d87e1f503c0d8f9867ace)
Review URL: https://codereview.chromium.org/2170943002 .
Cr-Commit-Position: refs/branch-heads/2785@{#271}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Change initTouchEvent removal warning to M54
This CL updates TouchEvent.InitTouchEvent removal warning to M54
since we missed M53 branch point. (The original plan was to remove
in M53)
The Chrome Status Entry has also been updated to M54:
https://www.chromestatus.com/features/5730982598541312
BUG=629554
Review-Url: https://codereview.chromium.org/2158863002
Cr-Commit-Position: refs/heads/master@{#406350}
(cherry picked from commit ae2c536166e766bdff9b4a7ccb8757cd9b569598)
Review URL: https://codereview.chromium.org/2171863002 .
Cr-Commit-Position: refs/branch-heads/2785@{#270}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
cc: Clear entries from animations maps only when main thread wins
Because we will may need these values in future commits.
BUG=624366
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2105173006
Cr-Commit-Position: refs/heads/master@{#406131}
(cherry picked from commit f03aa24a39fc23c5749b50966c8d1967063faa81)
Review URL: https://codereview.chromium.org/2173483002 .
Cr-Commit-Position: refs/branch-heads/2785@{#269}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Error out when merchant requests only unknown payment methods.
If the merchant requests only payment methods that Chrome does not
support, then reject the show() promise with NotSupportedError.
BUG=628460
Review-Url: https://codereview.chromium.org/2149023005
Cr-Commit-Position: refs/heads/master@{#406460}
(cherry picked from commit 3748272dc88b06912bf432655587dc7dd4a4a561)
Review URL: https://codereview.chromium.org/2165343002 .
Cr-Commit-Position: refs/branch-heads/2785@{#268}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Prevent simultaneous UI interactions in PaymentRequest UI.
This patch prevents interacting with the dialog when the user is:
- Opening an editor overlay,
- Closing the dialog via the [x] button,
- Cancelling the dialog via the [cancel] button, or
- Dismissing the dialog via Android's [<] (back) button.
Allowing these interactions leads to crashes.
BUG=629030
Review-Url: https://codereview.chromium.org/2157183002
Cr-Commit-Position: refs/heads/master@{#406370}
(cherry picked from commit 8cc17dd5bd16119157decba981d11f1e217052dd)
Review URL: https://codereview.chromium.org/2172723002 .
Cr-Commit-Position: refs/branch-heads/2785@{#267}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Parameterize OnError method.
This change is required to support following part of the
spec. "Let acceptedMethods be supportedMethods with all
identifiers removed that the user agent does not accept.
If the length of acceptedMethods is zero, then reject
acceptPromise with a NotSupportedError."
BUG=627705
Review-Url: https://codereview.chromium.org/2145553002
Cr-Commit-Position: refs/heads/master@{#406227}
(cherry picked from commit e542d0af7a4908ec043b86d858bb9206a1c9c7f9)
Review URL: https://codereview.chromium.org/2171503004 .
Cr-Commit-Position: refs/branch-heads/2785@{#266}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Adjust BackgroundWith1PxBorder to better handle fractional scale factors
This fixes blurriness in the omnibox border on surface tablets.
BUG=627469
Review-Url: https://codereview.chromium.org/2145713002
Cr-Commit-Position: refs/heads/master@{#406371}
(cherry picked from commit eb39becd04cdefd6aac776b659358458aa7ace23)
Review URL: https://codereview.chromium.org/2172713002 .
Cr-Commit-Position: refs/branch-heads/2785@{#265}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] Add FramesSentAsOverlay UMA metric to AVDA.
Merge to M53 of https://codereview.chromium.org/2163513002 .
This metric records frames sent by AVDA, bucketed by whether they
are or are not overlays.
The goal is to provide an approximate count of how often SurfaceView
is used versus SurfaceTexture.
BUG=629313
NOPRESUBMIT=true
NOTRY=true
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2166953003
Cr-Commit-Position: refs/branch-heads/2785@{#264}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Allow idle/suspend with 3+ monitors attached
On Samus it is possible to connect 2 external displays and on other
chromebooks it is possible to connect 2 DisplayLink devices to have
more than 2 monitors. In such cases turning off displays causes the
display configuration to fail and present a "Dear monitor..." message
even though it is possible to turn off these displays.
BUG=627795
TEST=display_unittests and ran on Samus with 2 DisplayLink devices attached.
Review-Url: https://codereview.chromium.org/2152303002
Cr-Commit-Position: refs/heads/master@{#406555}
(cherry picked from commit 310889b982ca44844dbb79b409b874f3267c58fe)
Review URL: https://codereview.chromium.org/2170603004 .
Cr-Commit-Position: refs/branch-heads/2785@{#263}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix queuing of display power state change requests
If a display power change request arrives before the previous one
finishes or if a previous power change request failed the state becomes
inconsistent and future requests are optimized out.
BUG=627795
TEST=New unittest in display_unittests and manually checked on Samus
Review-Url: https://codereview.chromium.org/2154743003
Cr-Commit-Position: refs/heads/master@{#405990}
(cherry picked from commit 760bfbf595eb8e4597c971b60c2da1c911481fbd)
Review URL: https://codereview.chromium.org/2172583003 .
Cr-Commit-Position: refs/branch-heads/2785@{#262}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Only flag the LayoutObject on CSP error if one is attached
When instantiating a plugin through the (somewhat special) code-path
that does not require a LayoutObject to be present, we would end up
dereferencing a null-pointer if a CSP error was flagged, failing the
plugin load sequence.
BUG=627694
Review-Url: https://codereview.chromium.org/2162473003
Cr-Commit-Position: refs/heads/master@{#406295}
(cherry picked from commit 386e769dbd70b39c348bd663749858f117654408)
Review URL: https://codereview.chromium.org/2166273002 .
Cr-Commit-Position: refs/branch-heads/2785@{#261}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Remove slow test for connecting to the AD DC server.
DsBind was slowing down Chrome startup blocking the file thread for
up to a few minutes on some machines. This check is not really delivering
any more useful information to us so it can be safely removed.
BUG=621270
TEST=none
Review-Url: https://codereview.chromium.org/2157143003
Cr-Commit-Position: refs/heads/master@{#406373}
(cherry picked from commit f34984bbeee68c231b5ad17464ad8ea41f1f0d09)
Review URL: https://codereview.chromium.org/2167103002 .
Cr-Commit-Position: refs/branch-heads/2785@{#260}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Ensure invalidation in LayoutBlockChildNode::removeChildNodes() without notifyLayoutObject
Some callers of LayoutBlockChildNode::removeChildNodes() passes
notifyLayoutObject=false and we missed invalidation of the painting
layer and the object.
The test case is converted from a cluster-fuzz test case.
BUG=628146
Review URL: https://codereview.chromium.org/2163873003 .
Review-Url: https://codereview.chromium.org/2160723006
Cr-Original-Commit-Position: refs/heads/master@{#406436}
Cr-Commit-Position: refs/branch-heads/2785@{#259}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] service worker: Wait for inflight requests before activating
This patch makes changes as per discussion at
https://github.com/slightlyoff/ServiceWorker/issues/916
Namely,
* The waiting worker gets promoted to active once there are no
controllees and the incumbent worker has no in-flight events
(fetch/sync/push/message etc).
* skipWaiting bypasses the no controllees requirement, but we
still wait until there are no in-flight events.
* As usual, incoming fetch/sync/push events always go to the
active worker.
BUG=616331
Review-Url: https://codereview.chromium.org/2119143002
Cr-Commit-Position: refs/heads/master@{#405628}
(cherry picked from commit 6c95b0ff8f694cda918e38c96387e5445713fc8e)
Review URL: https://codereview.chromium.org/2164113003 .
Cr-Commit-Position: refs/branch-heads/2785@{#258}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] service worker: Refactor OnNoControllees
OnNoControllees doesn't need to unset the flags.
* If |is_uninstalling_| is set, the call to Clear() would unset it.
* If |should_activate_when_ready_| is set, the call to ActivateWaitingVersion() would
unset it. We also change Clear() to unset |should_activate_when_ready_| which
makes sense for any callsite of Clear().
Minor simplification in anticipation of changes for https://crbug.com/616331
Refactoring only; no behavior change.
BUG=616331
Review-Url: https://codereview.chromium.org/2115393002
Cr-Commit-Position: refs/heads/master@{#403650}
(cherry picked from commit 6c74874b9c6969a2afc6f195c96a1a3b15cda890)
Review URL: https://codereview.chromium.org/2170723003 .
Cr-Commit-Position: refs/branch-heads/2785@{#257}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] service worker: Clean up the fetch event request if URLRequest gets cancelled.
Before this patch, an inflight fetch event would never be
finished, since the request being cancelled results in the
URLRequestJob being destroyed, so the the response callback
is never called. Eventually the event would timeout, but this
is an error state that terminates the worker. It's better to
listen for the response and finish the request cleanly.
BUG=616331
Review-Url: https://codereview.chromium.org/2114893002
Cr-Commit-Position: refs/heads/master@{#403632}
(cherry picked from commit 9ed9574ae81390911dd582a0d5a49a4c0430eafa)
Review URL: https://codereview.chromium.org/2168013002 .
Cr-Commit-Position: refs/branch-heads/2785@{#256}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Fetch API] Remove HandleScope to protect local handles
BodyStreamBuffer, Request and Response constructors create their
JS wrappers to keep the weak reference to ReadableStream implemented
with V8 extras. Currently these constructors have ScriptState::Scope
and that means that the created JS wrappers would be protected only
in the scope (via v8::HandleScope).
This CL removes some ScriptState::Scopes so that local handles will
be protected by wider v8::HandleScopes.
BUG=617864
Review-Url: https://codereview.chromium.org/2141383002
Cr-Commit-Position: refs/heads/master@{#405451}
(cherry picked from commit 6e5425bcac204ed0892ce8368cd8746526b66a2d)
Review URL: https://codereview.chromium.org/2167023002 .
Cr-Commit-Position: refs/branch-heads/2785@{#255}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
DevTools: do not detach sourcemap in case of style sheet editing
Also the sourcemapping does not make sense for the edited style sheet,
it still seems to be helpful for the web developers as it
gives a brief idea of source file name / approximate line
number.
This was regressed at crrev.com/1806233002
BUG=257778
R=dgozman
Review-Url: https://codereview.chromium.org/2116903002
Cr-Commit-Position: refs/heads/master@{#404316}
(cherry picked from commit 2dfd4ba707f617a44641c4e732ec986a331b4618)
Review URL: https://codereview.chromium.org/2170743002 .
Cr-Commit-Position: refs/branch-heads/2785@{#254}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.24
Cr-Commit-Position: refs/branch-heads/2785@{#253}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[merge-m53] Cocoa: Enable controls in the content settings popup based on enterprise settings.
r141724 added code to the toolkit-views content settings bubble to
disable the radio buttons on a content settings popup if the setting was
controlled by enterprise policy, but this never made it to Cocoa.
Fix Cocoa by calling setEnabled on the NSMatrix of radio buttons. Pass
the value ContentSettingBubbleModel::BubbleContent::radio_group_enabled.
Screenshot at http://crbug.com/509249#c30
See also http://crbug.com/98029
BUG=509249
Review-Url: https://codereview.chromium.org/2153393002
Cr-Commit-Position: refs/heads/master@{#405980}
(cherry picked from commit 2f31973596db77e508ab0ab46d034537e04f7585)
Review URL: https://codereview.chromium.org/2165113002 .
Cr-Commit-Position: refs/branch-heads/2785@{#252}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Copy array buffer data used by WebCrypto in the order expected by draft specification.
* Most data buffers to crypto.subtle.* are copied prior to algorithm normalization.
* Data buffers that are part of algorithm dictionaries are copied and read in the declaration order of the properties.
BUG=626948
Review-Url: https://codereview.chromium.org/2141843002
Cr-Commit-Position: refs/heads/master@{#406170}
(cherry picked from commit 923aa7b0442d331e07b1853acd4f40d3a99a35ce)
Review URL: https://codereview.chromium.org/2163983003 .
Cr-Commit-Position: refs/branch-heads/2785@{#251}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
URLRequestContextBuilder should initialize a default CT state
When using a URLRequestContextBuilder, the URLRequestContext
it built would not be initialized with any Certificate
Transparency logs. This is because CT logs are a policy of the
embedder. Without any CT logs, all certificates naturally fail
any CT policies the embedder has set.
With no way to override this on the URLRequestContextBuilder,
any CA which has CT compliance enforced on it will be rejected.
This is because per-CA policies are enforced at the //net layer
as part of a 'secure by default' policy, and thus fail closed.
The result is that embedders that used URLRequestContextBuilder,
such as Android WebView, rather than building URLRequestContexts
themselves, such as Chrome does, would reject certs from some
CAs. While this could be overridden by manipulating the
TransportSecurityState of the URLRequestContext that was built,
doing so would result in a less-secure solution.
This CL mitigates it two-fold, by allowing the embedder to specify
their own CTVerifier to handle evaluating Certificate Transparency
information, and if they fail to, by initializing with the set
of logs known to //net and trusted by Chrome according to the
Chrome CT policy. This gives embedders a sane default, while still
allowing them to override with their own application policies.
This doesn't fully bootstrap a CT enforcement for embedders, as
things like consistency proof fetching are concepts that extend
beyond the URLRequestContext (and handled by the IOThread in
Chrome), but offers a reasonable baseline. This also helps ensure
things like Expect-CT work consistently for embedders.
BUG=628421
Review-Url: https://codereview.chromium.org/2161983003
Cr-Commit-Position: refs/heads/master@{#406455}
(cherry picked from commit 0fe709bafb6c31586b2833d4974612d6eccc2e02)
Review URL: https://codereview.chromium.org/2168723003 .
Cr-Commit-Position: refs/branch-heads/2785@{#250}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[arc-intents] Deal correctly with default ports.
Loosen the match requirements for ports so that URLs are matched
regardless of whether the port was implicitly (i.e. the default) or
explicitly specified. This provides an optimistic filter that ensures
the disambiguation code doesn't get skipped in the case of potential
matches.
BUG=628788
Review-Url: https://codereview.chromium.org/2159203003
Cr-Commit-Position: refs/heads/master@{#406644}
(cherry picked from commit d8692456882c5cde70eb246fc11b9372032d3992)
Review URL: https://codereview.chromium.org/2166933002 .
Cr-Commit-Position: refs/branch-heads/2785@{#249}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[arc-intents] Remove SSP matching; add unit tests.
- As discussed with elijahtaylor@ and yusukes@, don't attempt matching
for scheme-specific parts. Extracting an SSP from a chrome URL is
fraught, and SSPs don't really apply to http/https URLs anyway.
- Add unit tests for the IntentFilter class.
BUG=628788
Review-Url: https://codereview.chromium.org/2156683002
Cr-Commit-Position: refs/heads/master@{#406283}
(cherry picked from commit 5acc3b7599948290a46f7f9003e7a1cc5b466590)
Review URL: https://codereview.chromium.org/2161073004 .
Cr-Commit-Position: refs/branch-heads/2785@{#248}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fix crash on Android.
The OfflinePage's TabHelper which is WebContentsObserver was not expecting
to receing DocumentOnLoadCompletedInMainFrame() w/o preceding DidFinishNavigation().
For the time being, added a check and bail out and a TODO to figure out the real cause.
BUG=628716
Review-Url: https://codereview.chromium.org/2168463002
Cr-Commit-Position: refs/heads/master@{#406451}
(cherry picked from commit 150dce79e9d91e7b53e8510404659485e57680d6)
Review URL: https://codereview.chromium.org/2168523004 .
Cr-Commit-Position: refs/branch-heads/2785@{#247}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Plugin Power Saver: Fix a dangling WebViewPlugin.
Currently, there can be a situation where if the plugin removes itself
during initialization, the container is destroyed but the placeholder
plugin is not. This patch fixes this issue.
BUG=620515
Review-Url: https://codereview.chromium.org/2151483007
Cr-Commit-Position: refs/heads/master@{#406018}
(cherry picked from commit c37f6c9c5535c9c5e4aaba9d61a93673561ce344)
Review URL: https://codereview.chromium.org/2163213003 .
Cr-Commit-Position: refs/branch-heads/2785@{#246}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53][bgmode] Skip some KeepAlive registrations on shutdown.
M53 merge of https://crrev.com/43f25e4fc136ddba3b516c329ac375ce9185b6b3
Registering a KeepAlive during shtudown is forbidden and hits
a CHECK, so we should avoid starting some operations that do
it.
This CL adds checks to avoid such situations:
- push notifications received from GCM while shutting down
will be dropped early instead of causing a crash and being
dropped anyway.
- Extension functions using chrome_details validate before
running that the browser process is not shutting down.
BUG=612815
[email protected], [email protected], [email protected],
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2118473002
Review-Url: https://codereview.chromium.org/2162013002
Cr-Original-Commit-Position: refs/heads/master@{#406001}
Cr-Commit-Position: refs/branch-heads/2785@{#245}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Append variation headers when fetching snippets.
Since we are directly using URLFetcher, this is not done automatically.
In order to propagate experiments to Google servers, this call needs to
be done manually.
Snippets are not enabled for incognito NTPs, so we pass false for
|incognito|.
BUG=629493
Review-Url: https://codereview.chromium.org/2164593002
Cr-Commit-Position: refs/heads/master@{#406269}
(cherry picked from commit 630a991e73d67ae1162d9b64e22308f9c9df29ba)
Review URL: https://codereview.chromium.org/2168523003 .
Cr-Commit-Position: refs/branch-heads/2785@{#244}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Fallback to 300x150 instead of 0x0 size for SVG inside content()
Prior to r379801, the fallback 300x150 in SVGImage::dataChanged() was
used. Post r379801 we instead used the empty rect as fallback. Both
are probably wrong but 300x150 matches what we did previously more
closely and we are less likely to end up with an empty image.
BUG=623528
Review-Url: https://codereview.chromium.org/2121973002
Cr-Commit-Position: refs/heads/master@{#404374}
(cherry picked from commit da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae)
Review URL: https://codereview.chromium.org/2168603002 .
Cr-Commit-Position: refs/branch-heads/2785@{#243}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Storage manager: Show accounts panel from "Other users" link.
BUG=625070
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
[email protected]
Review-Url: https://codereview.chromium.org/2162753002
Cr-Commit-Position: refs/heads/master@{#406222}
(cherry picked from commit fd79db4b1cea32d3fc151fb753e767a2c24b765f)
Review URL: https://codereview.chromium.org/2168583002 .
Cr-Commit-Position: refs/branch-heads/2785@{#242}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.23
Cr-Commit-Position: refs/branch-heads/2785@{#241}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add macro definition __CHROMEOS__ for ChromeOS builds.
This is needed for clients that need to address some special
behaviors of ChromeOS.
BUG=chromium:628040
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2154353002
Cr-Commit-Position: refs/heads/master@{#406193}
(cherry picked from commit d7bef0cd66dbb7169c1098a620fc73cbb56f0aa4)
Review-Url: https://codereview.chromium.org/2161263002
Cr-Commit-Position: refs/branch-heads/2785@{#240}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Update Symantec Roots for CT enforcement
Adds Symantec Enterprise Mobile Root and remove TC TrustCenter root
operated by S-Trust
BUG=620178
Review-Url: https://codereview.chromium.org/2127903004
Cr-Commit-Position: refs/heads/master@{#404071}
(cherry picked from commit 604bed36a3ef96e6c331cb3032ddc06d1dcbd364)
Review URL: https://codereview.chromium.org/2159393002 .
Cr-Commit-Position: refs/branch-heads/2785@{#239}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Add additional Symantec roots to the CT requirement
This updates the last set of CT-enforced roots to include the
decomissioned TC TrustCenter roots that Symantec acquired in
July 2010. Although these roots are not supposed to issue
any further certificates (intermediate or sub-CAs), they remain
trusted on OS X, so cover them for comprehensiveness.
This also includes Symantec's G4/G6/G7 CAs, which are either
trusted by Microsoft or pending inclusion.
BUG=620178
Review-Url: https://codereview.chromium.org/2122383002
Cr-Commit-Position: refs/heads/master@{#403971}
(cherry picked from commit 33b3ff6f1b878e3598f7dca280e72708dc5d7ace)
Review URL: https://codereview.chromium.org/2164633003 .
Cr-Commit-Position: refs/branch-heads/2785@{#238}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Require CT for the Symantec-operated, Thawte-branded roots (active and retired)
BUG=620178
Review-Url: https://codereview.chromium.org/2118723002
Cr-Commit-Position: refs/heads/master@{#403399}
(cherry picked from commit bd59b11124c47ae3e62bed05fc46cc924f7bc4b7)
Review URL: https://codereview.chromium.org/2163853002 .
Cr-Commit-Position: refs/branch-heads/2785@{#237}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] service worker: Relax the BadMessageReceived call in OnSetHostedVersionId
The message may be for an embedded worker that had
been detached.
BUG=625042
Review-Url: https://codereview.chromium.org/2154663002
Cr-Commit-Position: refs/heads/master@{#405748}
(cherry picked from commit 1dd05b7262de80415eb0d106a0ff0a471d675aad)
Review URL: https://codereview.chromium.org/2163143002 .
Cr-Commit-Position: refs/branch-heads/2785@{#236}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53] ServiceWorker: Break down bad_message::SWDH_SET_HOSTED_VERSION into more specific reasons
bad_message::SWDH_SET_HOSTED_VERSION can be reported by multiple reasons:
absence of an active worker or process mismatch. For better debuggability, this
should be broken down into more specific reasons.
BUG=625042
Review-Url: https://codereview.chromium.org/2120183002
Cr-Commit-Position: refs/heads/master@{#403729}
(cherry picked from commit d3579ffbfc8a0da19fb2cf0386b8ba96e81405a1)
Review URL: https://codereview.chromium.org/2164773003 .
Cr-Commit-Position: refs/branch-heads/2785@{#235}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to M53] Worker: Remove locking from WorkerThread::postTask()
WorkerThread::postTask() can be called from various places and locking in the
function may lead to deadlock. To avoid the problem, this CL removes locking
from WorkerThread::postTask() and makes it possible to safely access to shared
flags without locking.
BUG=620442
Review-Url: https://codereview.chromium.org/2142273004
Cr-Commit-Position: refs/heads/master@{#405715}
(cherry picked from commit 18d1be3c48e503e5d080361f8fe6df7cfd2b503e)
Review URL: https://codereview.chromium.org/2164873002 .
Cr-Commit-Position: refs/branch-heads/2785@{#234}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Incrementing VERSION to 53.0.2785.22
Cr-Commit-Position: refs/branch-heads/2785@{#233}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Check for a null callback in RendererSurfaceViewManager
Now RSVM ignores surface created messages if there's no
outstanding request instead of trying to call a null
callback.
BUG=627453
Review-Url: https://codereview.chromium.org/2141163003
Cr-Commit-Position: refs/heads/master@{#405322}
(cherry picked from commit abac0bdc0db93d2dba82b057222626506ec52533)
Review URL: https://codereview.chromium.org/2162273002 .
Cr-Commit-Position: refs/branch-heads/2785@{#232}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Disable Android FRE in demo mode
BUG=625032
[email protected],[email protected]
Review URL: https://codereview.chromium.org/2157393003 .
Review-Url: https://codereview.chromium.org/2113243004
Cr-Original-Commit-Position: refs/heads/master@{#404002}
Cr-Commit-Position: refs/branch-heads/2785@{#231}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange()
Anticipating a spec change to remove this 'updating' check to fix
spec issue https://github.com/w3c/media-source/issues/118, these methods
no longer throw exception if any of the SourceBuffers in sourceBuffers
are currently updating.
[1] https://github.com/w3c/web-platform-tests/pull/3296
BUG=627880,624037
[email protected]
TEST=Expected update [1, above] to upstream
wpt/media-source/mediasource-liveseekable.html fails before and passes
after this change (with --enable-experimental-web-platform-features in
both cases, of course).
Review-Url: https://codereview.chromium.org/2144063002
Cr-Commit-Position: refs/heads/master@{#405309}
(cherry picked from commit dbebef53441200e0ce94dcd41668df78c93f568e)
Review URL: https://codereview.chromium.org/2166683002 .
Cr-Commit-Position: refs/branch-heads/2785@{#230}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge to 2785] Finish plumbing for CALayerOverlay filter.
BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2162713002
Cr-Commit-Position: refs/heads/master@{#406154}
(cherry picked from commit c32640c475b6df0e715edfbc16dd9a335e186625)
Review URL: https://codereview.chromium.org/2166643002 .
Cr-Commit-Position: refs/branch-heads/2785@{#229}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
ManageSpace activity - Do not load browser on insta crash.
Use a preference to track whether the managed space activity
successfully completes before attempting to load the browser
process on the next startup.
This should ensure that native crashes in the renderer process
do not prevent users from clearing their data.
It uses the current product version to allow the browser process
to be attempted after upgrades regardless of previous failures.
BUG=571461
Review URL: https://codereview.chromium.org/2161273003 .
Review-Url: https://codereview.chromium.org/2111813003
Cr-Original-Commit-Position: refs/heads/master@{#403553}
Cr-Commit-Position: refs/branch-heads/2785@{#228}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
bluetooth: Only unregister the receiver if dialog hasn't been closed.
Also modifies nativeOnDialogFinished to more closely resemble the
non-test nativeOnDialogFinished function. This change would have
allowed us to catch the problem with the receiver.
BUG=625398
Review-Url: https://codereview.chromium.org/2129763002
Cr-Commit-Position: refs/heads/master@{#404170}
(cherry picked from commit d04c4837088288ebe2d6348e29018f754a1f91d7)
Review URL: https://codereview.chromium.org/2162853004 .
Cr-Commit-Position: refs/branch-heads/2785@{#227}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Media Router] Replace route messaging API.
Remove old callback-based ListenForRouteMessages API and replace it
with StartListeningForRouteMessages and OnRouteMessagesReceived. The
rationale is return value based API doesn't work well for event pages;
when the event page is suspended, the callback supplied by the old API
is lost and cannot be restored when the extension wakes up. Switching
to the listener model unblocks the work to reduce the nessesity of
keeping the event page alive and should result in considerably
simpler logic on the extension side.
To maintain backwards compatibility with older extensions, a smaller
adapter logic is introduced in media_router_bindings.js.
Add missing WakeReason for StartListeningForRouteMessages.
Also added OWNERs for the mojom file to comply with presubmit.
BUG=625007
Review-Url: https://codereview.chromium.org/2111303003
Cr-Commit-Position: refs/heads/master@{#406083}
(cherry picked from commit bf455be1850399b8b374809cfc2584e0611e1c77)
Review URL: https://codereview.chromium.org/2161073003 .
Cr-Commit-Position: refs/branch-heads/2785@{#226}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
If location services are turned off, have the BT chooser prompt the user to turn them on.
Based on jyasskin's patch at http://crrev.com/2032273002
This patch just fixes conflicts and uses the new method to control Location Services
state
BUG=545867
Review-Url: https://codereview.chromium.org/2102813002
Cr-Commit-Position: refs/heads/master@{#403597}
(cherry picked from commit 0fbab99112bf947322e9b1dc0f3612e0b23f29fe)
Review URL: https://codereview.chromium.org/2159253003 .
Cr-Commit-Position: refs/branch-heads/2785@{#225}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
bluetooth: Remove Context from Wrappers and use LocationUtils directly
Context is not final so there is no need to create a wrapper for it.
We extend MockContext directly in our fakes.
Adds a new setHasAndroidLocationPermission that sets a new factory
for LocationUtils to return true or false.
Follow up patch of http://crrev.com/2038753004
Review-Url: https://codereview.chromium.org/2100313003
Cr-Commit-Position: refs/heads/master@{#403390}
(cherry picked from commit 5966ddbd6d38eba46253350308f1bb59d1d467ab)
BUG=545867
Review URL: https://codereview.chromium.org/2166613002 .
Cr-Commit-Position: refs/branch-heads/2785@{#224}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Merge M53: "Don't use the AudioSourceCallback to pre-fill audio during Start()."
If an error occurs during the fill process, this will trigger a
call to AudioSourceCallback::OnError() which further triggers a
whole chain of re-entrancy. Don't do this. Instead fill the first
buffer with silence.
BUG=624877
TEST=audio av/sync continues to work and does not glitch.
Review-Url: https://codereview.chromium.org/2112243003
Cr-Commit-Position: refs/heads/master@{#403562}
(cherry picked from commit 9dfd85fcc1ae4b17d9fd24149bc0d176645d5e30)
Review URL: https://codereview.chromium.org/2164653003 .
Cr-Commit-Position: refs/branch-heads/2785@{#223}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Updating XTBs based on .GRDs from branch 2785
Cr-Commit-Position: refs/branch-heads/2785@{#222}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M53] Run autofill-profile de-dupe after sync starts if sync is enabled.
This CL updates the PersonalDataManager to run autofill profile
de-duplication (if enabled) at the appropriate time, depending on
whether autofill profile sync is enabled.
If sync is not enabled, profile de-duplication is run after the
data is initially loaded.
If sync is enabled, profild de-duplication is run after the sync
first becomes active.
In all cases, de-duplication is only run once for a given version
of chromium.
BUG=627519
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2142123002
Cr-Commit-Position: refs/heads/master@{#406026}
(cherry picked from commit d594dc5f82b5836f5f0b4ba8d52b8563ff3c2f27)
Review URL: https://codereview.chromium.org/2163783002 .
Cr-Commit-Position: refs/branch-heads/2785@{#221}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
exo: Close widget at the top of ShellSurface dtor.
Allows widget close animations to use the scale assigned
to shell surface at the time it is destroyed.
BUG=628932, b/29082277
Review-Url: https://codereview.chromium.org/2157863002
Cr-Commit-Position: refs/heads/master@{#406044}
(cherry picked from commit 14bc66f849fad108c4f33883f40988dc3041e3c3)
Review URL: https://codereview.chromium.org/2162963003 .
Cr-Commit-Position: refs/branch-heads/2785@{#220}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] [Payments] Add ability to bold parts of addresses
* Add the ability to bold parts of a label.
* Add the ability to show a tertiary label in the PaymentOption, which
will later be used for phone number display.
* The phone number is passed in to the PaymentOption using the new constructor
via the AutofillAddress class.
See crbug.com/626833 for screenshots.
BUG=603635,626833
Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f
Review-Url: https://codereview.chromium.org/2135573004
Cr-Original-Commit-Position: refs/heads/master@{#405900}
Cr-Commit-Position: refs/heads/master@{#406062}
(cherry picked from commit 1089ca591550d0ca24befe3023b369a5ed2944da)
Review URL: https://codereview.chromium.org/2160293002 .
Cr-Commit-Position: refs/branch-heads/2785@{#219}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] Credit card editor for PaymentRequest UI.
When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.
For server cards, the editor shows uneditable card information and lets
the user set the billing address.
For local cards, the editor shows the following fields.
1) A list of icons for supported card types.
2) The card number input with Luhn validation and formatting. Required
field.
3) The name on card input. Required field.
4) The month and year dropdowns. January of this year by default for new
cards.
5) The billing address dropdown with only complete addresses on disk and
an option to add a new address. Required field.
6) A checkbox for saving the new card on disk. Checked by default,
so it behaves similar to autofill settings.
BUG=624924
Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Review-Url: https://codereview.chromium.org/2116583002
Cr-Original-Commit-Position: refs/heads/master@{#405876}
Cr-Commit-Position: refs/heads/master@{#406036}
(cherry picked from commit 80b5895d9b722eba9129c62c1788f8cbef351dc4)
Review URL: https://codereview.chromium.org/2163693002 .
Cr-Commit-Position: refs/branch-heads/2785@{#218}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[Merge M-53] [Payments] API Level 16 fixes
* Try to address the background of PaymentRequest being gray.
* Address crashes from calling methods that exist only on
API level 17+.
- This is a slight step backward for accessibility pre-JBMR1,
but the parent layout already has an accessibility hint set,
so the child view just ends up saying something less useful
during TalkBack.
BUG=628587
Review-Url: https://codereview.chromium.org/2150403002
Cr-Commit-Position: refs/heads/master@{#405838}
(cherry picked from commit d642a449361a9a30aecd1cb28c8d30d8dcc08991)
Review URL: https://codereview.chromium.org/2158063004 .
Cr-Commit-Position: refs/branch-heads/2785@{#217}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Dismiss Sync Dialogs if Account has been deleted.
BUG=627079
Review-Url: https://codereview.chromium.org/2145983002
Cr-Commit-Position: refs/heads/master@{#405497}
(cherry picked from commit 74e94b331cfeac65a846cad109db3ee0f8442603)
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2163663002
Cr-Commit-Position: refs/branch-heads/2785@{#216}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[M53]: service worker: Don't BadMessageReceived when a response for a timed out request arrives
If the worker is stopping, assume an unhandled message is due to the
request timing out which triggered the stopping.
I considered saving timed out request ids but it's a bit cumbersome: you
have to store the IPC message type along with the request id which involves
some changes to PendingRequest along with the data structure to hold
the timed out requests. Seems more trouble than it's worth to avoid this bug,
and we expect to migrate to Mojo soon anyway.
BUG=625040
Review-Url: https://codereview.chromium.org/2150863002
Cr-Commit-Position: refs/heads/master@{#405477}
(cherry picked from commit b321c36b95fa43f0378ce82a222b89224d030a6a)
Review URL: https://codereview.chromium.org/2160233002 .
Cr-Commit-Position: refs/branch-heads/2785@{#215}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
[CM API] Account Chooser with Sign in button for single account
BUG=612504
Review-Url: https://codereview.chromium.org/2126353003
Cr-Commit-Position: refs/heads/master@{#404350}
(cherry picked from commit ae78f7fefdeea8deb1a14a98626909628da6a36b)
Review URL: https://codereview.chromium.org/2164573002 .
Cr-Commit-Position: refs/branch-heads/2785@{#214}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
Contenteditable w/ "-webkit-user-select:all" should be editable.
<div id ="div" style="-webkit-user-select:all" contenteditable="true"></div>
should be editable.
In this CL, we ignore "-webkit-user-select:all" if element has
|contenteditable="true| in
Node::hasEditableStyle and expandSelection by user click.
BUG=618920
TEST=editing/selection/user-select/user-select-all-contenteditable.html, mouse/click-
user-select-all-textarea.html, user-select/user-select-all-contenteditable.html
Review-Url: https://codereview.chromium.org/2120913002
Cr-Commit-Position: refs/heads/master@{#405440}
(cherry picked from commit d607a605c05ae726b55aa3a28b32c94a2ab597ff)
Review URL: https://codereview.chromium.org/2162483003 .
Cr-Commit-Position: refs/branch-heads/2785@{#213}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
