Publish DEPS for Chromium 53.0.2767.4
Incrementing VERSION to 53.0.2767.4
Cr-Commit-Position: refs/branch-heads/2767@{#8}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Revert of Split the code for fetching images and for decoding images into two separate classes. This will all… (patchset #18 id:340001 of https://codereview.chromium.org/2045233002/ )
Reason for revert:
Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is ReleaseBlock-Dev.
NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true
TBR=markusheintz
Original issue's description:
> Split the code for fetching images and for decoding images into two separate classes. This will allow to use common code for image URL fetching and platform specific implementations for image decoding.
>
> BUG=609127
>
> Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916
> Cr-Commit-Position: refs/heads/master@{#399457}
[email protected],[email protected],[email protected],[email protected],[email protected]
BUG=609127
Review-Url: https://codereview.chromium.org/2068783003
Cr-Commit-Position: refs/heads/master@{#399765}
(cherry picked from commit 8b92318ca8fbdafc79599e8bc707ad721b880b14)
Review URL: https://codereview.chromium.org/2065253002 .
Cr-Commit-Position: refs/branch-heads/2767@{#7}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Oilpan: Idle GCs should not fire when a GC is forbidden
This can happen when an idle GC is fired after cleanupMainThread is called
(because cleanupMainThread intentionally sets the GCForbidden flag to avoid any GC from happening after that).
BUG=613678
Review-Url: https://codereview.chromium.org/2069503002
Cr-Commit-Position: refs/heads/master@{#399671}
(cherry picked from commit 21ed870cd80fd354bcbc39dc827506b52dcebe38)
Review URL: https://codereview.chromium.org/2061243003 .
Cr-Commit-Position: refs/branch-heads/2767@{#6}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Revert of Remove ineffective PendingScript prefinalizer (2nd attempt.) (patchset #1 id:1 of https://codereview.chromium.org/2060853002/ )
Reason for revert:
Canary crashes reported,
https://bugs.chromium.org/p/chromium/issues/detail?id=615977#c12
Original issue's description:
> Remove ineffective PendingScript prefinalizer (2nd attempt.)
>
> With the missing case from r397106 aboard, retire the prefinalizer
> for PendingScript. Script loader and runner objects are expected
> to explicitly dispose of these upon success or failure.
>
> R=
> BUG=
>
> Committed: https://crrev.com/fbf7f01ae80f666a5b37acf0ef38fd174443787f
> Cr-Commit-Position: refs/heads/master@{#399504}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615977
Review-Url: https://codereview.chromium.org/2069573002
Cr-Commit-Position: refs/heads/master@{#399691}
(cherry picked from commit cb0b8cd6962b00abf23a9779d13eee15af316693)
Review URL: https://codereview.chromium.org/2067953002 .
Cr-Commit-Position: refs/branch-heads/2767@{#5}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Incrementing VERSION to 53.0.2767.3
Cr-Commit-Position: refs/branch-heads/2767@{#4}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Incrementing VERSION to 53.0.2767.2
Cr-Commit-Position: refs/branch-heads/2767@{#3}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Revert "[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog"
This reverts commit 05781339eb7e4153776b66bd6353d4b7ba24d0a6.
Appears to be causing crashes
BUG=619866
Cr-Commit-Position: refs/branch-heads/2767@{#2}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Incrementing VERSION to 53.0.2767.1
Cr-Commit-Position: refs/branch-heads/2767@{#1}
Cr-Branched-From: 92614dc154ad143a1ef9849ae0fe90c02df09f30-refs/heads/master@{#399650}
Added comprehensive tests for views::Border.
BUG=568389
Review-Url: https://codereview.chromium.org/1517463003
Cr-Commit-Position: refs/heads/master@{#399650}
Rename StyleLayoutData to StyleGeometryData
The term 'geometry' better matches what is stored here (and is also more
in line with the SVG spec chapter [1] that defines most of the properties
here.)
Rename the SVGComputedStyle::layout field to 'geometry' to match.
This is a mechanical rename-only CL, with the exception of some
additional whitespace fixups.
[1] https://svgwg.org/svg2-draft/geometry.html ("Geometry Properties")
BUG=603956
Review-Url: https://codereview.chromium.org/2066563002
Cr-Commit-Position: refs/heads/master@{#399649}
gl: Build drm dependent test only when target_os == "chromeos".
The original check we used was |is_chromeos| that is true also
when the ChromeOS UI is built on linux.
More info about the issue here:
https://bugs.chromium.org/p/chromium/issues/detail?id=618516#c5
BUG=618516
Review-Url: https://codereview.chromium.org/2060753004
Cr-Commit-Position: refs/heads/master@{#399648}
Simplify and document MP4 AAC parsing
Minor cleanup of parser flow and comments. We implement the 2009 spec
for base profiles 1-4 and extenions 5 (sbr) & 29 (ps). Parsing for other
profiles is not implemented, so bail out and warn when found.
BUG=526314,532281
TEST=media_unittest updated
Review-Url: https://codereview.chromium.org/2055663002
Cr-Commit-Position: refs/heads/master@{#399647}
Make ui::TextInputClient::IsEditCommandEnabled const.
This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.
BUG=586985
Review-Url: https://codereview.chromium.org/2024033006
Cr-Commit-Position: refs/heads/master@{#399646}
Refactored media pipeline integration tests
Got rid of code duplication in StartPipelineWithMediaSource and
StartPipelineWithEncryptedMedia and made pipeline status checks
explicit at call sites.
Review-Url: https://codereview.chromium.org/2001773002
Cr-Commit-Position: refs/heads/master@{#399645}
Add totalAmount to PaymentResponse.
This patch adds the totalAmount to PaymentResponse. This reflects the
total amount that the user has confirmed they will pay. The change that
introduced totalAmount also introduced PaymentMethodModifier, which is
not in this patch.
https://w3c.github.io/browser-payment-api/#paymentresponse-interface
https://github.com/w3c/browser-payment-api/commit/67f4f25f4a0562e7b13c5139e1bb8f8b1d41f53a
BUG=618860
Review-Url: https://codereview.chromium.org/2062583002
Cr-Commit-Position: refs/heads/master@{#399644}
MD Settings: Hook up reset_page to new LifetimeBrowserProxy.
BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2052003002
Cr-Commit-Position: refs/heads/master@{#399643}
Clean up LoginWebDialog.
Review-Url: https://codereview.chromium.org/2053393005
Cr-Commit-Position: refs/heads/master@{#399642}
Adds implementation of BackgroundScheduler.unschedule()
BUG=619686
Review-Url: https://codereview.chromium.org/2060353003
Cr-Commit-Position: refs/heads/master@{#399641}
[MD Settings] Add feature to enable md-settings by default.
chrome://settings will serve either old settings or md-settings,
depending on flag. chrome://settings-frame will always serve old
settings. chrome://md-settings will serve new settings, unless
the flag is off.
BUG=614758
Review-Url: https://codereview.chromium.org/2029263002
Cr-Commit-Position: refs/heads/master@{#399640}
Incorporate BlobChannel into Blimp image encode/decode pipeline.
* Add "BlobChannelSenderHost" class which encapsulates calls to Mojo
and manages a renderer-resident copy of the cache state.
Access to the cache state enables the renderer to avoid
performing redundant operations such as resampling/transcoding
if the data has previously been processed by another renderer.
* Modify Mojo interface to transmit blob payloads as strings,
which is consistent with the C++ BlobData typedef.
* Remove BlobChannel/BlobCache calls from WebPDecoder (now it only
decodes WebP images.)
* Make ClientImageSerializationProcessor into a singleton.
* Add getter path for BlobChannel sender for Engine browser process.
[email protected],[email protected]
BUG=600719
Review-Url: https://codereview.chromium.org/1985863002
Cr-Commit-Position: refs/heads/master@{#399639}
Roll src/third_party/catapult/ ddb2a25a3..a5b12d3ee (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ddb2a25a3008..a5b12d3eed34
$ git log ddb2a25a3..a5b12d3ee --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2066713002
Cr-Commit-Position: refs/heads/master@{#399638}
Adds support for attaching a market referrer.
Given an intent:// URL, if the application cannot be found and we
redirect the user to Play Market, set the referrer string in the market
URL to the value of market_referrer extra specified in the original
intent.
BUG=603999
Review-Url: https://codereview.chromium.org/2061493002
Cr-Commit-Position: refs/heads/master@{#399637}
Roll src/third_party/skia/ d06693d90..401cf4863 (2 commits).
https://chromium.googlesource.com/skia.git/+log/d06693d9088f..401cf48631ac
$ git log d06693d90..401cf4863 --date=short --no-merges --format='%ad %ae %s'
2016-06-13 liyuqian Quickly fix 0f to 0.0f [email protected]
2016-06-13 jvanverth Create free list heap for suballocation
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2060953004
Cr-Commit-Position: refs/heads/master@{#399636}
Re-implement SVG transform paint property nodes [spv2]
This patch adds a new property node for LayoutSVGRoot which maps from
the local SVG space to the HTML border box[1]. This patch also removes
the local SVG transform and makes SVG objects create transform nodes
in PaintPropertyTreeBuilder::updateTransform[2]. This approach will let
us support the other paint property types in SVG fairly easily in a
followup patch.
[1] Why do we need two transform nodes for the SVG root? LayoutSVGRoot
paints itself (e.g., borders, outlines) in the local HTML border box
transform space. LayoutSVGRoot's SVG children cannot paint in this space
because they need an additional transform (called the local svg to
border box) which offsets children by the border and includes SVG's
"viewbox".
[2] Why was m_svgLocalTransform removed? svgLocalTransform was designed
to support the local transform of both the SVG root and all SVG
descendants. Unfortunately, LayoutSVGRoot required that svgLocalTransform
get created after filters/clips in PaintPropertyTreeBuilder but that
left filters/clips in the wrong transform space. To solve this without
a parallel implementation of filters/clips/etc for SVG, SVG children
now create regular transform property nodes in PaintPropertyTreeBuilder.
BUG=600618
Review-Url: https://codereview.chromium.org/2045253005
Cr-Commit-Position: refs/heads/master@{#399635}
Unregister Images, Plugins and Mouselock content settings on android
Images, plugins and mouselock content settings aren't used on Android, so
unregister them in ContentSettingsRegistry and handle places in shared code
where get access to these types.
Several places in shared code are if-defed out when they try to get access to
unregistered types. Some tests are also changed to use COOKIES instead of IMAGES
to make the tests more platform generic, if they are not testing images
specifically.
This is a follow up CL of https://codereview.chromium.org/1991623005/.
BUG=604632
Review-Url: https://codereview.chromium.org/2039803002
Cr-Commit-Position: refs/heads/master@{#399634}
Default components to static libraries in GN build
Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow.
Reland of https://codereview.chromium.org/2043873004/ and https://codereview.chromium.org/2063483002 but disabled for official Windows builds.
In support of the official condition, is_official_build moved to BUILDCONFIG. Since this is really a different level of debug/release, this may actually make more sense. The documentation around this was enhanced a lot, official now automatically turns off debug, and it will assert if you override both to produce an official debug build.
BUG=617837
Review-Url: https://codereview.chromium.org/2060983002
Cr-Commit-Position: refs/heads/master@{#399633}
[ash-md] New algorithm for overview mode layout
The layout should now be close enough to the spec to be landed behind the flag.
BUG=604765
Review-Url: https://codereview.chromium.org/1999643003
Cr-Commit-Position: refs/heads/master@{#399632}
Removed proguard keeps for BaseChromiumApplication.
Removing keeps for classes since we now have the ability to only access
them by class name in debug mode.
TBR=yfriedman
BUG=587225
Review-Url: https://codereview.chromium.org/2060293002
Cr-Commit-Position: refs/heads/master@{#399631}
Create script to upload/download third party lib jar
BUG=579638
Review-Url: https://codereview.chromium.org/2035133003
Cr-Commit-Position: refs/heads/master@{#399630}
Roll src/third_party/catapult/ 3c05947bf..ddb2a25a3 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3c05947bfdaf..ddb2a25a3008
$ git log 3c05947bf..ddb2a25a3 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2060953005
Cr-Commit-Position: refs/heads/master@{#399629}
mash: Move most files in //ash/system/tray to //ash/common/system/tray
None of these files have aura or ash::Shell dependencies, but many of them are
dependencies of other files I'm trying to move.
This is a mechanical change:
move_source_file.py ash/system/tray/actionable_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/actionable_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/fixed_sized_scroll_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/fixed_sized_scroll_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/hover_highlight_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/hover_highlight_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/special_popup_row.h ash/common/system/tray/
move_source_file.py ash/system/tray/special_popup_row.cc ash/common/system/tray/
move_source_file.py ash/system/tray/throbber_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/throbber_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bar_button_with_title.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bar_button_with_title.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_empty.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_empty.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_more.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_more.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_notification_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_notification_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_header_button.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_header_button.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_item_container.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_item_container.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button_border.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button_border.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button.cc ash/common/system/tray/
move_source_file.py ash/system/tray/view_click_listener.h ash/common/system/tray/
I also removed a few unnecessary includes of base/compiler_specific.h.
BUG=619636
TEST=compiles
[email protected] for mechanical changes to //chrome/browser/chromeos
Review-Url: https://codereview.chromium.org/2066583004
Cr-Commit-Position: refs/heads/master@{#399628}
Split //media/mojo/clients from //media/mojo/services.
Review-Url: https://codereview.chromium.org/2057923002
Cr-Commit-Position: refs/heads/master@{#399627}
Draw nicer arrows when the scrollbar buttons are not square.
Before they would look squished or messed up, but with this patch
their bounding box is always square so we'll get the nice pixel pyramids
that we want. This shouldn't change anything visually for the normal
square scrollbar buttons.
BUG=614297
Review-Url: https://codereview.chromium.org/2009733002
Cr-Commit-Position: refs/heads/master@{#399626}
Reenable WebGL Image Chromium.
The feature was disabled because of two bugs. Both have since been fixed.
BUG=617249, 581777
Review-Url: https://codereview.chromium.org/2063803002
Cr-Commit-Position: refs/heads/master@{#399625}
arc: bluetooth: Fix remote friendly name in GetDeviceProperties
BUG=None
TEST=Build
Review-Url: https://codereview.chromium.org/2065783003
Cr-Commit-Position: refs/heads/master@{#399624}
Manually rebaseline 10 tests after 399384
This patch manually rebaselines 10 tests after:
https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52
This patch also reverts suppressions added in:
https://crrev.com/89ac1777f53c26ac798acccef38cb5506cf901a1
Rebaseline bot bug discussion:
https://bugs.chromium.org/p/chromium/issues/detail?id=574272#c12
svg/custom/js-late-clipPath-and-object-creation.svg
svg/custom/js-late-clipPath-creation.svg
svg/custom/marker-viewBox-changes.svg
svg/custom/relative-sized-content.xhtml
svg/custom/relative-sized-deep-shadow-tree-content.xhtml
svg/custom/relative-sized-image.xhtml
svg/custom/relative-sized-shadow-tree-content.xhtml
svg/custom/resource-invalidate-on-target-update.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/repaint/inner-svg-change-viewBox-contract.svg
svg/repaint/mask-clip-target-transform.svg
BUG=619108
[email protected]
Review-Url: https://codereview.chromium.org/2068553002
Cr-Commit-Position: refs/heads/master@{#399623}
Remove use of DescheduleUntilFinished from WebGL.
It's no longer necessary, since the new implementation of
ImageTransportSurfaceOverlayMac::ClientWait correctly waits for the WebGL
context's work to finish.
BUG=617249
Review-Url: https://codereview.chromium.org/2062813003
Cr-Commit-Position: refs/heads/master@{#399622}
Mojo C++ bindings: add support for native-only enums.
BUG=577686
Review-Url: https://codereview.chromium.org/2067623002
Cr-Commit-Position: refs/heads/master@{#399621}
third_party: Update wayland-protocols to 1.4.
BUG=549781
[email protected]
Review-Url: https://codereview.chromium.org/2064923002
Cr-Commit-Position: refs/heads/master@{#399620}
media: Cancel MediaCryptoReadyCB during AVDA destruction
This is the AVDA version of
https://codereview.chromium.org/1601743007
We could be reusing the same MediaKeys object in JS app on a second
media element. If the MediaCryptoReadyCB has not been returned by
MediaDrmBridge for the first media element, and we attach the same
MediaKeys on the second media element, we could hit the DCHECK in
MediaDrmBridge that we only allow one MediaCryptoReadyCB at one
time.
BUG=b/26593586
Review-Url: https://codereview.chromium.org/2059153003
Cr-Commit-Position: refs/heads/master@{#399619}
third_party: Update Wayland to version 1.11.0.
BUG=549781
[email protected]
Review-Url: https://codereview.chromium.org/2064933002
Cr-Commit-Position: refs/heads/master@{#399618}
MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.
BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2057593003
Cr-Commit-Position: refs/heads/master@{#399617}
Expose an interface to generate a unique accessibility ID.
This will be used in a subsequent changelist
(http://crrev.com/2055953002) to make the PDF plug-in
accessible by embedding its accessibility tree inside
the accessibility tree for the host page.
BUG=54724
Review-Url: https://codereview.chromium.org/2055903002
Cr-Commit-Position: refs/heads/master@{#399616}
Omnibox - Enforce non-URL Inputs Show Query First
This was run as an experiment. We've decided to launch it, so this disables the experiment and revises the code appropriately.
This resolves all the examples on
https://bugs.chromium.org/p/chromium/issues/detail?id=421514#c19
It makes two changes in passing:
- keep the old behavior for handling word#ref as being labeled as QUERY input
- make exact URL suggestions allowed to be the default match regardless of identified input type if there is no default search engine
BUG=421514,561685
Review-Url: https://codereview.chromium.org/2047323004
Cr-Commit-Position: refs/heads/master@{#399615}
LayoutObject::paintInvalidationParent() to fix multicol spanner invalidation
This was LayoutObject::parentCrossingFrameBoundaries(). Renamed and
added special rule for column spanner, and used for both finding
painting layer and marking ancestor chain for paint invalidation.
Previously we marked ancestor chain for paint invalidation through
the normal tree order, causing the placeholder not marked for
paint invalidation and missing walking to the spanner. If dcheck
was enabled, it would crash because the paint invalidation flags
of the spanner is not cleared.
BUG=619263
TEST=fast/repaint/multicol-spanner-background-color.html
Review-Url: https://codereview.chromium.org/2063543002
Cr-Commit-Position: refs/heads/master@{#399614}
Switch RenderThreadImplBrowserIPCTestHelper to use test mojo ipc support.
All other test code uses mojo::edk::test::ScopedIPCSupport.
Review-Url: https://codereview.chromium.org/2056123002
Cr-Commit-Position: refs/heads/master@{#399613}
Add "Checking" spinner for server-side shipping address validation.
PaymentRequest should let the user know that their section is being
verified. This is used, for example, when the website is verifying
availability of shipping options to the shipping address that the user
has selected. If an address is not supported, an error message should be
shown. The unsupported address should be disabled.
BUG=619318
Review-Url: https://codereview.chromium.org/2059073002
Cr-Commit-Position: refs/heads/master@{#399612}
cc: Print out GLSL compile errors for shaders
Without it, working on the shaders in /cc/ is very painful.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2059093003
Cr-Commit-Position: refs/heads/master@{#399611}
Fix TransformOperationsTest.AbsoluteAnimatedPerspectiveBoundsTest
The original test values were invalid in the way that the object getting
projected overlaps with the observer, and should be projected to infinity.
The transform code silently ignored the error when it detected the divider
being 0, but on some FPUs the computed divider would be a near zero value
and project the point to some distant value.
This CL changes the test value to something sane.
Review-Url: https://codereview.chromium.org/2049983002
Cr-Commit-Position: refs/heads/master@{#399610}
Update expected opus hash value for fixed point platforms.
Expected values grew stale and are no longer correct on platforms that
use OPUS_FIXED_POINT (mostly just arm platforms).
BUG= internal b/27455844
Review-Url: https://codereview.chromium.org/2066603002
Cr-Commit-Position: refs/heads/master@{#399609}
Announce phonetics when navigating by character.
BU=619456
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2064883002
Cr-Commit-Position: refs/heads/master@{#399608}
Make sure FrameScheduler is cleared when LocalFrame::detach() finishes
This patch is a relanding of https://codereview.chromium.org/1907453002 (Make
RenderFrameImpl own its frame blame context) with necessary modification:
Since a FrameScheduler may be created in LocalFrame::detach() due to scripting,
this patch adds an extra clearing of |m_frameScheduler| to make sure it is cleared.
BUG=618599
Review-Url: https://codereview.chromium.org/2053233002
Cr-Commit-Position: refs/heads/master@{#399607}
mash: Move TrayUpdate to //ash/common
It no longer has aura or ash::Shell dependencies.
Allow +ash/test in ash/common/system/DEPS because it's important for tests to
sit next to their implementation code, even if ash/test hasn't been converted
away from aura yet.
BUG=619636
TEST=ash_unittests
Review-Url: https://codereview.chromium.org/2059383002
Cr-Commit-Position: refs/heads/master@{#399606}
[sql] Log prepare compile errors on SQLITE_ERROR.
Code which prepares statements attempts to flag invalid statements with
a DLOG(FATAL), because in almost all cases an invalid statement is
always invalid, likely due to a typo or incorrect schema. Previously,
ShouldIgnoreSqliteCompileError() attempted to ignore certain errors
which sometimes caused failed prepares, but which could vary over time.
For instance, a corrupt database could cause a failed prepare, but
doesn't reflect on the statement itself. The new code only flags on
SQLITE_ERROR, which is what sqlite3_prepare_v2() returns for syntax
errors.
Merged GetUniqueStatement() and GetUntrackedStatement() into an
implementation helper to reduce duplication.
BUG=none
Review-Url: https://codereview.chromium.org/2038733002
Cr-Commit-Position: refs/heads/master@{#399605}
Reset user data directory and disk cache directory after downgrade.
BUG=607592
Review-Url: https://codereview.chromium.org/1986823002
Cr-Commit-Position: refs/heads/master@{#399604}
Added the default browser prompt style experiment
Let us experiment with Blue or Colored Chrome logo on Yellow or White infobar.
BUG=614866
Review-Url: https://codereview.chromium.org/2036293002
Cr-Commit-Position: refs/heads/master@{#399603}
media/capture: Addressing size_t to int warnings C4267
They popped up in
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/compile/logs/stdio
And decided to address them in capture/ once and
for all :)
BUG=167187
TEST= passing compilation in x64 win bots
and without the ignoring W4267 flag (see PS1)
- win_chromium_x64_rel_ng
- win10_chromium_x64_rel_ng_exp
- win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2060073002
Cr-Commit-Position: refs/heads/master@{#399602}
Roll src/third_party/catapult/ 4c5421126..3c05947bf (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4c54211265bc..3c05947bfdaf
$ git log 4c5421126..3c05947bf --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2066583003
Cr-Commit-Position: refs/heads/master@{#399601}
Updating XTBs based on .GRDs from branch master
Cr-Commit-Position: refs/heads/master@{#399600}
Mustash implementation of ChromeLauncherController.
Adds ChromeLauncherControllerMus. The functionality is mostly stubbed out, but app launches work.
BUG=619605
Review-Url: https://codereview.chromium.org/2059963002
Cr-Commit-Position: refs/heads/master@{#399599}
Add timeout to swap fence
In some cases (mainly on Mac OS 10.9), it appears that a glFence
may never pass. To work around this issue (and make the code more
robust in similar cases), a 32ms timeout has been added, after which
we will just call glFinish rather than continuing to wait on the fence.
Will add an UMA stat in a follow-up CL to make sure this is very rare
on 10.9 - if this turns out to be at all common, we should probably
modify 10.9 to indicate that it doesn't support glFence.
BUG=618075
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2064853002
Cr-Commit-Position: refs/heads/master@{#399598}
More YUV_420 buffers support.
This CL adds:
- YVU_420 to the list of native formats supported by
BrowserGPuMemoryBufferManager.
- YVU_420 to the list of native formats supported by
ClientNativePixmapFactory.
- GL_RGB_YCRCB_420_CHROMIUM as a valid internal format when creating
an image.
- A logging statement in exo::Buffer in case an image fails to be
created.
Additionally, this CL let GbmPixmap::ExportHandle to export buffers
with less fds than planes as discussed in crrev.com/2055483002
BUG=crbug.com/618516
TEST=Manually tested creating a fake YV12 buffer in exo::Display::CreateLinuxDMABufBuffer.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2052003006
Cr-Commit-Position: refs/heads/master@{#399597}
Update V8 to version 5.3.222.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a5e57a3f..a7d2bb3b
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2061873002
Cr-Commit-Position: refs/heads/master@{#399596}
Change MediaKeys.setServerCertificate() to return Promise<boolean>
https://github.com/w3c/encrypted-media/issues/145 changed the EME spec
so that setServerCertificate() returns Promise<boolean>. Update the
implementation to match.
This change updates the IDL and returns true on success.
NOT_SUPPORTED_ERRORs will resolve with false.
BUG=618800
TEST=EME tests pass, www.netflix.com plays
Review-Url: https://codereview.chromium.org/2056053003
Cr-Commit-Position: refs/heads/master@{#399595}
Change the default result for CT Verification to "Not verified"
When default constructing a CTVerifyResult, set the result to indicate
that there were not enough SCTs. This matches a reasonable 'fail closed'
implementation for CT status.
BUG=none
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2066643002
Cr-Commit-Position: refs/heads/master@{#399594}
Cleanup WebrtcVideoRendererAdapter
Fixed two issue:
- FrameConsumer::AllocateFrame() wasn't previusly called.
- The adapter was rendering frames out-of-order when the host didn't
have playout-delay extension enabled. Changed the adapter to just log
a warning when render delay is greater than 0, and otherwise ignore
render timestamp. This ensures that frames are emitted in the order
they are received. This is safe because host now sets playout delay
to 0 for all video frames.
Review-Url: https://codereview.chromium.org/2062843003
Cr-Commit-Position: refs/heads/master@{#399593}
Add a flag to disable server experiments in DRP
Use this flag to disable server experiments field trial when
running Lo-Fi integration tests.
BUG=619622
Review-Url: https://codereview.chromium.org/2062963003
Cr-Commit-Position: refs/heads/master@{#399592}
Auto-rebaseline for r399532
https://chromium.googlesource.com/chromium/src/+/4fd93e539
BUG=254639
[email protected]
Review URL: https://codereview.chromium.org/2060753003 .
Cr-Commit-Position: refs/heads/master@{#399591}
DevTools: allow inspector protocol generator reuse as a gyp target.
TBR=dgozman
Review-Url: https://codereview.chromium.org/2065813002
Cr-Commit-Position: refs/heads/master@{#399590}
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer, not equal
BUG=618967
TEST=ResourceTest.RevalidateWithFragment
Review-Url: https://codereview.chromium.org/2061843002
Cr-Commit-Position: refs/heads/master@{#399589}
wayland: Fix GetUserDataAs in remote_shell_get_remote_surface
GetUserDataAs<T> needs to be consistent with SetImplementation.
WaylandRemoteShell instance is associated with WaylandRemoteShell
and that is what GetUserDataAs<T> gets back.
BUG=None
Review-Url: https://codereview.chromium.org/2061023002
Cr-Commit-Position: refs/heads/master@{#399588}
Fix canvas-related crash caused by bad object teardown sequence
Made it safe for HTMLCanvasElement and its associated rendering
context to be garbage collected in separate sweeps.
Drive-by: changed ASSERTs to DCHECKs etc.
BUG=616003
Review-Url: https://codereview.chromium.org/2057283002
Cr-Commit-Position: refs/heads/master@{#399587}
net: migrate SQLitePersistentCookieStoreTest to CanonicalCookies::Create method
This patch converts the usage of CanonicalCookie's constructor in SQLitePersistentCookieStoreTest
to CanonicalCookie's Create() method.
We are doing this because Create() is more robust, as it does validation of the parameters and
return NULL as an error signal if they fail to comply with the checks.
BUG=57061
TEST=net_unittests
[email protected]
Review-Url: https://codereview.chromium.org/2065643002
Cr-Commit-Position: refs/heads/master@{#399586}
[Material][Mac] Fix text color in incognito omnibox
BUG=617766
Review-Url: https://codereview.chromium.org/2056093002
Cr-Commit-Position: refs/heads/master@{#399585}
[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog
See the screenshots in the bug.
This patch does the following:
* Adds an activity for the manageSpaceActivity target in the
AndroidManifest.xml which gives options for managing or clearing
storage.
NOTE: This is only hooked up in API >= KLP, as the API for
clearing an application's app data isn't available until then.
* We have a Dialog protecting the Reset App functionality.
* Tested for clearing unimportant storage.
* Adds a Clear All button to the bottom of the Storage site settings
view. This involves a layout that's almost an exact copy of the
default layout, except we have one button.
* Protected again by a dialog.
* Adds a dialog to the Clear Browsing Data screen, that only shows
up when the user has 'important' origins.
* The user is prompted about these sites, and can uncheck them.
* Test is included, which also double checks that cookies are
not deleted.
BUG=560549,579763
Review-Url: https://codereview.chromium.org/1465363002
Cr-Commit-Position: refs/heads/master@{#399584}
Basic implementation of showing password fill dialog on page load
BUG=568713
Review-Url: https://codereview.chromium.org/2035143002
Cr-Commit-Position: refs/heads/master@{#399583}
Roll src/third_party/skia/ 6f163d294..d06693d90 (1 commit).
https://chromium.googlesource.com/skia.git/+log/6f163d29438c..d06693d9088f
$ git log 6f163d294..d06693d90 --date=short --no-merges --format='%ad %ae %s'
2016-06-13 liyuqian Quickly fix the double to SkScalar issue
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2063733003
Cr-Commit-Position: refs/heads/master@{#399582}
Sync: Support multiple setup UIs.
Replaces the SetSetupInProgress mechanism with a scoped
GetSetupInProgressHandle mechanism. This has two advantages:
1. Allows for multiple simultaneously open Setup UIs.
2. Prevents a buggy UI from blocking Sync indefinitely by forgetting
to SetSetupInProgress(false).
BUG=563721
Review-Url: https://codereview.chromium.org/2044303004
Cr-Commit-Position: refs/heads/master@{#399581}
Roll src/native_client/ 5152c12c4..33ea6a023 (1 commit).
https://chromium.googlesource.com/native_client/src/native_client.git/+log/5152c12c4477..33ea6a02332d
$ git log 5152c12c4..33ea6a023 --date=short --no-merges --format='%ad %ae %s'
2016-06-13 rockot Increase the number of pthread keys available to the IRT
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
[email protected]
Review-Url: https://codereview.chromium.org/2065773002
Cr-Commit-Position: refs/heads/master@{#399580}
MD Settings: Spellcheck subsection secondary text
Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.
Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1
[email protected]
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2047733003
Cr-Commit-Position: refs/heads/master@{#399579}
Incognito icon shows up again when opening incognito browser.
BUG=615360
Review-Url: https://codereview.chromium.org/2053563002
Cr-Commit-Position: refs/heads/master@{#399578}
Use DCHECKs when observing only a single notification.
In c/b/ui.
Review-Url: https://codereview.chromium.org/2065663002
Cr-Commit-Position: refs/heads/master@{#399577}
[ash-md] Makes overview window captions translucent
Changes to update overview mode to MD spec.
Captions are less dark.
Close buttons are now part of a single caption widget.
Close buttons use vector icons.
Selector widget now blends with the caption label
Label text is regular font
Shield is darker
Shelf is no longer put in overlap mode (stays transparent) in overview.
BUG=604767
Review-Url: https://codereview.chromium.org/2061533002
Cr-Commit-Position: refs/heads/master@{#399576}
Use the blocking pool in PrintPreviewHandler.
Review-Url: https://codereview.chromium.org/2065753002
Cr-Commit-Position: refs/heads/master@{#399575}
Clean Up Remaining Domain Check Call and netapi32.lib Usage
BUG=none
Review-Url: https://codereview.chromium.org/2056033002
Cr-Commit-Position: refs/heads/master@{#399574}
Roll src/third_party/catapult/ 5b88a9ec7..4c5421126 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5b88a9ec7a0e..4c54211265bc
$ git log 5b88a9ec7..4c5421126 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2064873002
Cr-Commit-Position: refs/heads/master@{#399573}
Disable "taking address of packed member" clang warning.
Pending cleanup.
BUG=619640
Review-Url: https://codereview.chromium.org/2059143003
Cr-Commit-Position: refs/heads/master@{#399572}
Restricting method and interface access in ChromeLauncherControllerImpl
Making most inherited interfaces private. Also making most of the inherited
methods private.
BUG=NONE
Review-Url: https://codereview.chromium.org/2066593002
Cr-Commit-Position: refs/heads/master@{#399571}
Disable idle suspend on Cast for ATV
Turn on kDisableMediaSuspend switch to prevent media player from
suspending when idle, and uses it to prevent suspend on Cast for
ATV (where it causes the screen to go black with current hardware
decoders).
BUG=internal b/29183381
Review-Url: https://codereview.chromium.org/2057393002
Cr-Commit-Position: refs/heads/master@{#399570}
Rename currency_code into currency in PaymentRequest mojo interface
This patch follows the renaming of currencyCode into currency in Blink.
Original renaming CL: http://crrev.com/1981903002
BUG=NONE
Review-Url: https://codereview.chromium.org/2062603002
Cr-Commit-Position: refs/heads/master@{#399569}
Dexdiffer scripts
Tools to allow us to diff between similiar dex files (using dextra to put them
into a readable form). This helps when checking proguard configs to see what
they are actually doing.
BUG=619124
Review-Url: https://codereview.chromium.org/2057323002
Cr-Commit-Position: refs/heads/master@{#399568}
Remove use of deprecated MessageLoop methods in storage.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2036593003
Cr-Commit-Position: refs/heads/master@{#399567}
Implement Suborigin's 'unsafe-cookies' opt-out
According to the spec draft
(https://w3c.github.io/webappsec-suborigins/), by default, a
Document in a Suborigin is cookie-averse. However, there is an optional
directive 'unsafe-cookies' that causes the Suborigin to share
document.cookie fully with the physical origin.
This implements that opt-out directive and is a follow-up to the
cookie-averse implementation in
https://codereview.chromium.org/2020513002/. It adds the parsing for
'unsafe-cookies' and a simple set of checks in Document to bypass the
cookie-averse behavior.
BUG=336894
[email protected]
Review-Url: https://codereview.chromium.org/2049863002
Cr-Commit-Position: refs/heads/master@{#399566}
Remove unused [D]VLOG statements in //net/socket
The logs haven't been used, reduce bloat.
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2061833002
Cr-Commit-Position: refs/heads/master@{#399565}
mojom: Error if multiple native types are mapped to the same mojom type.
BUG=none
Review-Url: https://codereview.chromium.org/2057603002
Cr-Commit-Position: refs/heads/master@{#399564}
Fix an assertion failure in InputType::applyStep()
If stepBase is extremely larger than step or maximum, the old code produced
alignedMaximum larger than maximum(). This CL fixes it.
- The core logic is moved to StepRange class to improve testability
- Move the stream printer for Decimal because it is used in DCHECK_LE().
BUG=617809
Review-Url: https://codereview.chromium.org/2048943002
Cr-Commit-Position: refs/heads/master@{#399563}
Revert of telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (patchset #2 id:20001 of https://codereview.chromium.org/1994653004/ )
Reason for revert:
smoothness.tough_path_rendering_cases fails on Android Nexus5 Perf (1) and Android Nexus7v2 Perf (1) bots.
Seems clear that this CL causes it.
BUG=619716
Original issue's description:
> telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops
>
> Stop measuring tough_path_rendering_cases chalkboard test-case after the
> page stops its "benchmark" and presents the results.
>
> The page used to wait 20s. On my desktop it runs <10s and on my
> particular Android device, ~17s.
>
> This avoids measuring the page after it stops updating.
>
> Committed: https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4
> Cr-Commit-Position: refs/heads/master@{#399432}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2063013002
Cr-Commit-Position: refs/heads/master@{#399562}
Revert of Move 'frame-src' CSP checks into FrameFetchContext. (patchset #5 id:100001 of https://codereview.chromium.org/2022083002/ )
Reason for revert:
Speculative revert for breaking Dr. Memory:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29?numbuilds=200
First breaking build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/8028
Original issue's description:
> Move 'frame-src' CSP checks into FrameFetchContext.
>
> Currently, we're doing 'frame-src' checks inside 'FrameLoader', which
> ends up being too early in the navigation cycle to handle the results
> of 'upgrade-insecure-requests'. Happily, we've refactored enough of the
> loading code in the last ~3 years that we can pretty easily move this
> check into 'FrameFetchContext::canRequest' alongside the rest of CSP.
>
> BUG=615910
>
> Committed: https://crrev.com/3f3e725e6479c711e5e13e59e8d011ee89992119
> Cr-Commit-Position: refs/heads/master@{#398685}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=615910
Review-Url: https://codereview.chromium.org/2068443002
Cr-Commit-Position: refs/heads/master@{#399561}
[DevTools] Support CommandLineAPI in workers and Node.js
CommandLineAPI injection is moved to v8_inspector in this CL. CommandLineAPI methods are installed to global object as non enumerable, replaceble properties. Method can be overriden during evaluation and doesn't override existing property if it's presented.
BUG=607748,595206
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2030453002
Cr-Commit-Position: refs/heads/master@{#399560}
Enable cc::Surface backend for exo Surfaces by default.
BUG=610086
Review-Url: https://codereview.chromium.org/2032863002
Cr-Commit-Position: refs/heads/master@{#399559}
Landing Recent QUIC changes until UTC Fri Jun 10 22:29:19 2016 +0000
relnote: Add extra log when AppendAckFrameAndTypeByte failed. n/a
logging only change.
Merge internal change: 124496602
https://codereview.chromium.org/2065493003
relnote: Deprecate rolled back flag quic_only_one_sending_alarm.
Merge internal change: 124469720.
https://codereview.chromium.org/2065553002
relnote: deprecating flag quic_use_early_return_when_verifying_chlo
Merge internal change: 124348798
https://codereview.chromium.org/2060723002
relnote: Add a new rate based sending connection option which uses the
pacing rate to keep the bytes_in_flight close to the CWND. Protected
by flag quic_rate_based_sending.
Merge internal change: 124302573
https://codereview.chromium.org/2064543002
relnote: Always send queued retransmission packets, because of write
blocked socket, once the socket gets unblocked. Protected by flag
quic_always_write_queued_retransmissions.
Merge internal change: 124273380
https://codereview.chromium.org/2065463002
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2061743002
Cr-Commit-Position: refs/heads/master@{#399558}
Remove unused variables, ash/ edition.
These were exposed while trying to make various geometry classes constexpr.
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2055273004
Cr-Commit-Position: refs/heads/master@{#399557}
Removes SingleOfflinePageItemResult and makes it a const ptr.
base::Optional has some tricky gotchas related to aligned memory that
(a) only appear on Windows and (b) prevent them from being used as
function parameters. So just use pointer to const and a copy of
an OfflinePageItem in its place.
BUG=
Review-Url: https://codereview.chromium.org/2048743002
Cr-Commit-Position: refs/heads/master@{#399556}
[MD settings] not clipping ink ripple in spelling settings
This CL reduces the use of overflow: hidden to places that need it,
than having it set on .start and .middle which are more about position
than elision.
BUG=608647
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2063453003
Cr-Commit-Position: refs/heads/master@{#399555}
[ios] Removed deprecated ios/web/test/web_test.h.
This header was split into 3 separate headers:
ios/web/public/test/web_test.h
ios/web/public/test/web_test_with_web_state.h
ios/web/test/web_test_with_web_controller.h
BUG=619076
Review-Url: https://codereview.chromium.org/2063763002
Cr-Commit-Position: refs/heads/master@{#399554}
Add native_pixmap.h to a build target.
The header file wasn't included in any GN build targets so it was missed
by GN check.
BUG=none
Review-Url: https://codereview.chromium.org/2062773003
Cr-Commit-Position: refs/heads/master@{#399553}
[MD settings] docs for shared css styles
This CL adds comments (docs) for the shared css styles. There are no
code/logic changes.
BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2062493002
Cr-Commit-Position: refs/heads/master@{#399552}
[Offline] Replace single-argument custom callbacks with base's Callback.
This adds a wrapper to org.chromium.base.Callback so that
integer types can be passed back as Integers on the Java
side.
BUG=
Review-Url: https://codereview.chromium.org/2045553003
Cr-Commit-Position: refs/heads/master@{#399551}
gl: Fix byte_number for YVU_420 unit test.
We were incorrectly computing the total number of bytes of the buffer
assuming that the plane of the last offset is the biggest of all the
three planes.
This is not always the case.
BUG=
Review-Url: https://codereview.chromium.org/2059373002
Cr-Commit-Position: refs/heads/master@{#399550}
Remove dependency of power_save_blocker_android on various content bits
BUG=612337,612563
TEST=start/stop video on m.youtube.com, content_browsertests
Review-Url: https://codereview.chromium.org/2003803002
Cr-Commit-Position: refs/heads/master@{#399549}
Removing unused GetAppIDForShelfIDConst.
BUG=NONE
Review-Url: https://codereview.chromium.org/2065713002
Cr-Commit-Position: refs/heads/master@{#399548}
Use the doc rect to figure out how many pages there are
When painting fixed pos objects on every page of paged media use the
doc's rects when figuring out the number of pages to paint.
BUG=618230
Review-Url: https://codereview.chromium.org/2053463003
Cr-Commit-Position: refs/heads/master@{#399547}
MD User Manager: Try to place the user pods only when the user pods page is visible.
BUG=563722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2053873002
Cr-Commit-Position: refs/heads/master@{#399546}
Support glCopyTex[Sub]Image to LUMA formats on the core profile.
BUG=577144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2027703003
Cr-Commit-Position: refs/heads/master@{#399545}
Upstream: Initialize ChromeWebApkHost in WebappLaunchActivity.
This CL fixes a bug that when a WebAPK is launched without Chrome
is running, WebApkValidator returns false for a valid WebAPK since
the WebApkValidator hasn't been initialized.
BUG=609122
Review-Url: https://codereview.chromium.org/2056383002
Cr-Commit-Position: refs/heads/master@{#399544}
Enable the translate bubble to be dismissed when user ignores it.
Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.
Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.
BUG=619192
Review-Url: https://codereview.chromium.org/2061523002
Cr-Commit-Position: refs/heads/master@{#399543}
Roll src/third_party/skia/ f533f116e..6f163d294 (3 commits).
https://chromium.googlesource.com/skia.git/+log/f533f116e632..6f163d29438c
$ git log f533f116e..6f163d294 --date=short --no-merges --format='%ad %ae %s'
2016-06-13 liyuqian Display JPGs in Viewer with Split Screen and ColorSpaceXform
2016-06-13 bsalomon Move create_image_large in ImageTest.cpp inside #if SK_SUPPORT_GPU
2016-06-13 mtklein Revert of Clean up two unlaunched SSE 4.1 8888 blits. (patchset #1 id:1 of https://codereview.chromium.org/2062853002/ )
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2068493002
Cr-Commit-Position: refs/heads/master@{#399542}
Use DCHECKs when observing only a single notification.
In c/b/extensions.
Review-Url: https://codereview.chromium.org/2065473003
Cr-Commit-Position: refs/heads/master@{#399541}
Fix the Material Design infobar icons size
The MD icon guidelines specify a size of 16pts including the 1pixel
padding. The previous size was incorrectly 18pts (16pts excluding
padding).
BUG=619155
Review-Url: https://codereview.chromium.org/2066543002
Cr-Commit-Position: refs/heads/master@{#399540}
Removing ProxyDelegate::OnBeforeSendHeaders
This is unimplemented everywhere and there is an existing
NetworkDelegate method that does the same thing.
BUG=
Review-Url: https://codereview.chromium.org/2065523003
Cr-Commit-Position: refs/heads/master@{#399539}
[TabManager] fixing comment at DiscardTabById function.
BUG=618338
Review-Url: https://codereview.chromium.org/2047283004
Cr-Commit-Position: refs/heads/master@{#399538}
Roll PDFium 855665d..993d817
https://pdfium.googlesource.com/pdfium.git/+log/855665d..993d817
BUG=108144
[email protected]
Review-Url: https://codereview.chromium.org/2066573002
Cr-Commit-Position: refs/heads/master@{#399537}
Use DCHECKs when observing only a single notification.
In various places in chrome/browser.
Review-Url: https://codereview.chromium.org/2063863002
Cr-Commit-Position: refs/heads/master@{#399536}
[Mac][Material] Fixed the lock icon color
BUG=618776
Review-Url: https://codereview.chromium.org/2067443003
Cr-Commit-Position: refs/heads/master@{#399535}
Fixing the order of methods in ChromeLauncherControllerImpl.
Fixing the order of methods in .cc to match that in .h.
No code changes.
BUG=NONE
Review-Url: https://codereview.chromium.org/2064813002
Cr-Commit-Position: refs/heads/master@{#399534}
Suppress two WebGL 2.0 conformance test flakes.
BUG=619264
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2062933002
Cr-Commit-Position: refs/heads/master@{#399533}
Optimize render passes with single quads
Many effects (masks, replicas, filters) generate render passes for
simplicity in the code. However, in the cases where the pass contains a
single quad with a texture, that resulting texture could just be used as
the input texture instead of the render pass itself.
The complication is mostly that render passes and tile textures are
flipped relative to each other (oops) and so some knowledge of this has
to leak into drawing render passes.
This is done by detecting such render passes inside of DirectRenderer,
storing the TileQuad that would have been drawn, skipping allocating the
pass and rendering it, and then calling a slightly modified version of
DrawRenderPassQuad with the TileQuad's resource. The check for which
render passes can be supported is conservative to start.
This optimization usually will not be supported on mac because skia
does not support textures with texture rectangle targets as input.
BUG=254639,606672
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/ff3dc65b0f7845184458fb25b3d566fa079cd232
Review-Url: https://codereview.chromium.org/1960543002
Cr-Original-Commit-Position: refs/heads/master@{#399060}
Cr-Commit-Position: refs/heads/master@{#399532}
mash: Move ash constants and layout constants files to //ash/common
These are dependencies of some of the system tray code that I'm moving to
//ash/common.
* Removed some unneeded includes
* move_source_file.py ash/ash_constants.h ash/common/
* move_source_file.py ash/ash_constants.cc ash/common/
* move_source_file.py ash/ash_layout_constants.h ash/common/
* move_source_file.py ash/ash_layout_constants.cc ash/common/
BUG=619636
TEST=compiles, ash_unittests
[email protected] for mechanical change to chrome/browser/chromeos
Review-Url: https://codereview.chromium.org/2061823002
Cr-Commit-Position: refs/heads/master@{#399531}
Mus: Delete unused Mandoline Surfaces code
In Mandoline, we converted SurfaceIds in SurfaceDrawQuads from submitted
CompositorFrames to global Window IDs to embed other mus::Window.
This was useful for out of process iframes so that the embedder could
securely synchronously control position, transform and clipping of the frame.
This has been obviated by unguessable SurfaceIds. In an effort to remove
surfaces type converters, I'm deleting this dead code.
BUG=611802
[email protected]
Review-Url: https://codereview.chromium.org/2065573003
Cr-Commit-Position: refs/heads/master@{#399530}
Fix for running Chrome under a service token.
This patch fixes an issue with the handling of the default DACL when running
Chrome under a service token, such as Local System. These tokens don't always
have an assigned logon session SID, which would cause the DACL lockdown process
to fail.
BUG=615396
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TEST=1. Download PSTools from https://technet.microsoft.com/en-us/sysinternals/pstools.aspx
2. Run cmd.exe as an administrator
3. Run the command 'psexec -s -i c:\path\to\chrome.exe'
4. Verify that the browser is useable
Review-Url: https://codereview.chromium.org/2061703002
Cr-Commit-Position: refs/heads/master@{#399529}
Fix shutdown crash in settings app monitor.
Don't assume that the caller's task runner will outlive the monitor.
BUG=611827
[email protected]
Review-Url: https://codereview.chromium.org/2065673002
Cr-Commit-Position: refs/heads/master@{#399528}
Adding ChromeLauncherController interface.
Breaking up the existing ChromeLauncherController class into ChromeLauncherController interface and ChromeLauncherControllerImpl implementation. With a few exceptions, classes that interact with ChromeLauncherController now do it through ChromeLauncherController interface.
This is the first step in adding a Mustash implementation of ChromeLauncherController.
ChromeLauncherControllerImpl does a lot more than implement ChromeLauncherController interface. Various parts of the code rely on this functionality. Particularly on methods from ash::ShelfDelegate that it implements. This was resolved in one of three ways:
- Using ash::Shell::GetShelfDelegate() (the reason this couldn't be used everywhere is unit tests)
- Using ChromeLauncherControllerImpl instead of ChromeLauncherController
- Storing separate pointers for ChromeLauncherController and ash::ShellDelegate.
BUG=619605
Review-Url: https://codereview.chromium.org/2052013002
Cr-Commit-Position: refs/heads/master@{#399527}
Rewrite enum in MACRO_STYLE
Files with related issue:
snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc
Related files are edited to match the style.
BUG=619215
Review-Url: https://codereview.chromium.org/2063533002
Cr-Commit-Position: refs/heads/master@{#399526}
[Chromoting] Log mouse events in remoting_key_tester
We have received a bug to complain scrolling moves in only one direction when
zooming with CAD tools in chromoting from Mac to Windows. This issue won't
reproduce on Linux client, so a potential Mac PNACL implementation defect could
be the root cause. So this change logs mouse related events in
remoting_key_tester to help debugging on Mac.
BUG=
Review-Url: https://codereview.chromium.org/2063623002
Cr-Commit-Position: refs/heads/master@{#399525}
OOPIFs: Fixing submitting forms targeting a remote frame.
The fix makes form submissions targeting a remote frame go through
RenderFrameProxy::navigate which forwards them to the browser via
FrameHostMsg_OpenURL IPC message. Right now this IPC only supports
HTTP GET method (support for POST method is being fixed in parallel
- see https://crbug.com/344348).
BUG=585284
Review-Url: https://codereview.chromium.org/1999573003
Cr-Commit-Position: refs/heads/master@{#399524}
Roll WebGL 2eef1ea..fc5ae3a
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/2eef1ea..fc5ae3a
BUG=
TEST=bots
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2060343002
Cr-Commit-Position: refs/heads/master@{#399523}
Measure queueing and blocking time for touchstart/touchend.
Adds histograms for
Event.Latency.QueueingTime.TouchStartDefaultPrevented
Event.Latency.QueueingTime.TouchStartDefaultAllowed
Event.Latency.BlockingTime.TouchStartDefaultPrevented
Event.Latency.BlockingTime.TouchStartDefaultAllowed
Event.Latency.QueueingTime.TouchEndDefaultPrevented
Event.Latency.QueueingTime.TouchEndDefaultAllowed
Event.Latency.BlockingTime.TouchEndDefaultPrevented
Event.Latency.BlockingTime.TouchEndDefaultAllowed
BUG=600730
TEST=RenderWidgetHostLatencyTrackerTest.TouchBlockingAndQueueingTime
Review-Url: https://codereview.chromium.org/2051853002
Cr-Commit-Position: refs/heads/master@{#399522}
Add UMA for studying download cancellation reasons
We found high cancellation rate with new download experiment.
This CL is to study why user cancels the download
BUG=618864
Review-Url: https://codereview.chromium.org/2058593002
Cr-Commit-Position: refs/heads/master@{#399521}
Pass SetServerCertificate call on
Have SetServerCertificate() call the matching method on |decryptor_|
rather than resolving the promise immediately. This allows External
Clear Key to more closely match the functionality of Clear Key.
BUG=618800
TEST=encrypted media browser tests pass
Review-Url: https://codereview.chromium.org/2057103004
Cr-Commit-Position: refs/heads/master@{#399520}
Implement Biquad lowpass and highpass filters according to spec
The WebAudio spec has changed the definition of the lowpass and
highpass filters slightly because some lowpass and highpass filters
could not be represented by the existing filters. Update
implementation to match spec.
This will cause some very slight difference in sound quality for some
values of Q. The new filters were careful to preserve the sound as
much as possible.
WebAudio issue https://github.com/WebAudio/web-audio-api/issues/771.
Resolution: https://github.com/WebAudio/web-audio-api/pull/795
Feature: https://www.chromestatus.com/features/5687523284090880
BUG=597432
TEST=biquad-*.html, iirfilter-getFrequencyResponse.thml, iirfilter.html
Review-Url: https://codereview.chromium.org/1885723003
Cr-Commit-Position: refs/heads/master@{#399519}
Mark ContextLost.WebGLContextLostFromGPUProcessExit failing on Win7.
BUG=619196
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2068503002
Cr-Commit-Position: refs/heads/master@{#399518}
[net] Fix use of definition lists in Markdown documentation.
Gitiles has moved to CommonMark and won't support definition lists. See
https://code.google.com/p/gitiles/issues/detail?id=89
[email protected]
BUG=none
Review-Url: https://codereview.chromium.org/2063843003
Cr-Commit-Position: refs/heads/master@{#399517}
MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes
Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.
BUG=619466
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2063623003
Cr-Commit-Position: refs/heads/master@{#399516}
PrintPreviewHandler: remove extra data copy.
Review-Url: https://codereview.chromium.org/2060993002
Cr-Commit-Position: refs/heads/master@{#399515}
public_dep //media so pipeline_integration_test.cc gets OPUS_FIXED_POINT
OPUS_FIXED_POINT was never getting defined in
pipeline_integration_test.cc even on "arm" platforms when it should
have. This adds a public_dep so the opus config is applied correctly.
BUG=
Review-Url: https://codereview.chromium.org/2057813002
Cr-Commit-Position: refs/heads/master@{#399514}
Handle ChromeTabbedActivity intents Android N multi-window mode
BUG=616612
Review-Url: https://codereview.chromium.org/2056083002
Cr-Commit-Position: refs/heads/master@{#399513}
Pull out SnackbarActivity from BookmarkActivity
* Pull out the SnackbarActivity from BookmarkActivity
so that the DownloadActivity can inherit from it.
* Rename a few color and size constants used by the
Bookmark UI.
BUG=616324
Review-Url: https://codereview.chromium.org/2058313002
Cr-Commit-Position: refs/heads/master@{#399512}
MD User Manager: in dropdown menu, No bkg-color for focused item. default bold font for selected item.
BUG=618151
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2060263002
Cr-Commit-Position: refs/heads/master@{#399511}
Roll src/third_party/catapult/ bb49ca05e..5b88a9ec7 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bb49ca05ea7c..5b88a9ec7a0e
$ git log bb49ca05e..5b88a9ec7 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2068463002
Cr-Commit-Position: refs/heads/master@{#399510}
Use asyncGC instead of GC in fast/events/message-port-gc-closed*.html
BUG=619242
[email protected]
Review-Url: https://codereview.chromium.org/2066533003
Cr-Commit-Position: refs/heads/master@{#399509}
Roll src/third_party/skia/ fe19987e5..f533f116e (9 commits).
https://chromium.googlesource.com/skia.git/+log/fe19987e5499..f533f116e632
$ git log fe19987e5..f533f116e --date=short --no-merges --format='%ad %ae %s'
2016-06-13 egdaniel Revert of Add samples to Viewer. (patchset #4 id:60001 of https://codereview.chromium.org/2056343004/ )
2016-06-13 mtklein Revert of Update typeface serialization style. (patchset #3 id:40001 of https://codereview.chromium.org/2030683002/ )
2016-06-13 msarett Fix SkImage::asLegacyBitmap() to respect color space info
2016-06-13 ericrk Add prescale option to deferred params
2016-06-13 mtklein Clean up two unlaunched SSE 4.1 8888 blits.
2016-06-13 bungeman Update typeface serialization style. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002
2016-06-13 bsalomon Add control over whether lines are special cased in SkDashPath. Disable when called from GrShape. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002
2016-06-13 ethannicholas skiaserve no longer crashes when no X server is present GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059263002
2016-06-13 jvanverth Add samples to Viewer.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2059363002
Cr-Commit-Position: refs/heads/master@{#399508}
PdfMetafileSkia: don't rely on SkPicture::cullRect
BUG=619371
Review-Url: https://codereview.chromium.org/2062903002
Cr-Commit-Position: refs/heads/master@{#399507}
[Mac] Fix Issue to Exit Fullscreen
Ensure that the browser exits fullscreen if toggleFullscreen was called
during the transition to fullscreen.
BUG=579934
Review-Url: https://codereview.chromium.org/2053343003
Cr-Commit-Position: refs/heads/master@{#399506}
PDF accessibility tweaks
1. Allows EnableAccessibility to be called at any time, and doesn't actually
send the accessibility tree until after the document loads. (In the future
we could send it while loading, but this is a good start.)
2. The character width wasn't accurate if there was space between
characters in the same text run. Update it so that a character's width
includes all of the space between this character and the start of the
next one, because the purpose of this field is a very compact
representation of the character bounds within a line, to enable
visually highlighting the accessible selection.
3. Heuristic: split a text run after whitespace wider than 3 characters.
4. Heuristic: if the font size is missing or obviously bogus, use the
pixel height of the text run, which is at least in the right ballpark.
BUG=54724
Review-Url: https://codereview.chromium.org/2050973003
Cr-Commit-Position: refs/heads/master@{#399505}
Remove ineffective PendingScript prefinalizer (2nd attempt.)
With the missing case from r397106 aboard, retire the prefinalizer
for PendingScript. Script loader and runner objects are expected
to explicitly dispose of these upon success or failure.
R=
BUG=
Review-Url: https://codereview.chromium.org/2060853002
Cr-Commit-Position: refs/heads/master@{#399504}
mash: Move SystemTrayImage and TrayImageItem to //ash/common
These are dependencies of TrayUpdate, which I am moving to //ash/common
I'm allowing //ash/system/tray/system_tray.h in DEPS because it's mostly a bag
of pointers to individual tray items. We'll be able to move it over once most
of the individual items move and it doesn't seem worth the code churn to add a
WmSystemTray.
move_source_file.py ash/system/tray/tray_utils.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_utils.cc ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_item.h ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_item.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_image_item.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_image_item.cc ash/common/system/tray/
BUG=619636
TEST=compiles, ash_unittests
Review-Url: https://codereview.chromium.org/2063813002
Cr-Commit-Position: refs/heads/master@{#399503}
[compositorworker] Register compositor proxies with proxy client
Each compositor proxy registers itself with its proxy client when created.
This populated set is later used to update the backing mutable state for each
compositor proxy.
TEST=These machinery is tested in the follow-up CL https://codereview.chromium.org/2041193005/
BUG=430155
Review-Url: https://codereview.chromium.org/1900423004
Cr-Commit-Position: refs/heads/master@{#399502}
Fix generation of inner_url in GURL::Replacements.
It was being created using a combination of the old and new URLs,
instead of just using the new URL.
BUG=615820
Review-Url: https://codereview.chromium.org/2029213002
Cr-Commit-Position: refs/heads/master@{#399501}
[Chromoting] Fling gestures on Android client are too fast
This change is to fix a bug in DesktopView.paint, which cause fling gestures to
be too fast. This issue has been introduced by commit
06d70696de0b8fac307927064bd36be2d486fe2a. And the root cause is that animation
job should be called during each paint call.
BUG=619224
Review-Url: https://codereview.chromium.org/2060643002
Cr-Commit-Position: refs/heads/master@{#399500}
Use theme color when tab is restored
BUG=606612
Review-Url: https://codereview.chromium.org/2024333003
Cr-Commit-Position: refs/heads/master@{#399499}
Fix typo in sandbox/linux/BUILD.gn.
In r399050 I added a condition to fix component builds of the Linux
sandbox to not contain -rpath=$ORIGIN, but I messed up the non-gold
configuration. This patch fixes the typo.
[email protected], [email protected], [email protected]
BUG=612647
Review-Url: https://codereview.chromium.org/2059343002
Cr-Commit-Position: refs/heads/master@{#399498}
Update V8 to version 5.3.221.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/08a6f791..a5e57a3f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2060423002
Cr-Commit-Position: refs/heads/master@{#399497}
Implement callback reactions for Custom Elements V1
This patch implements callbacks for Custom Elements V1:
1. Add Hooks to call methods in CustomElement class.
a. Element calls connected, disconnected, and attributeChanged.
b. CustomElementDefinition calls on upgrade.
2. CustomElement looks up CustomElementDefinition. Enqueueing reactions
were moved from CustomElement to CustomElementDefinition.
Implementing ScriptCustomElementDefinition to call JavaScript will be
in the following patch.
BUG=594918
Review-Url: https://codereview.chromium.org/2058823002
Cr-Commit-Position: refs/heads/master@{#399496}
On profile insertion, goes through all the user's profiles and try to merge. Delete all original profiles that were used in the merge, keeping only the result of the merge(s).
BUG=618356
TEST=PersonalDataManagerTest
Review-Url: https://codereview.chromium.org/1989173005
Cr-Commit-Position: refs/heads/master@{#399495}
Modify chooser controller to correctly handle removing item on Mac
This CL modified ChooserBubbleUiController and ChooserDialogCocoaController
to correctly handle removing item. And it also added and updated test code
to cover it.
BUG=619230
Review-Url: https://codereview.chromium.org/2054333002
Cr-Commit-Position: refs/heads/master@{#399494}
[Mac/GN] Only use -fstack-protector-strong in debug mode.
In release mode, just use -fstack-protector.
BUG=431177
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2058283002
Cr-Commit-Position: refs/heads/master@{#399493}
Disable DCHECKs on linux_chromium_msan_rel_ng.
It seems likely that DCHECKs are producing sanitizer failures
that aren't showing up on the continuous builder.
[email protected]
BUG=619349
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng
Review-Url: https://codereview.chromium.org/2063583002
Cr-Commit-Position: refs/heads/master@{#399492}
Fix homescreen shortcut targeting on N.
In N if the intent matches the one that triggered your activity,
then the activity will simply be refocused but no additional signals
are given.
This breaks homescreen shortcuts because if you launch Chrome for
the first time via a shortcut, all subsequent launches of the same
shortcut only bring Chrome forward. They do not create a new tab,
refocus the existing tab, which breaks the experience.
By adding relinquishTaskIdentity to the launcher activity, it is
"forgetting" the triggering intent to the ChromeTabbedActivity and
the task in android is only associated with the intent created and
triggered by ChromeLauncherActivity to create the Tabbed activity.
As this intent is always different from the homescreen shortcuts,
it will ensure that the ChromeTabbedActivity will always get an
onNewIntent for all shortcut pressed.
BUG=606418
Review-Url: https://codereview.chromium.org/2057963003
Cr-Commit-Position: refs/heads/master@{#399491}
Roll src/third_party/catapult/ 62c88709e..bb49ca05e (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/62c88709ef86..bb49ca05ea7c
$ git log 62c88709e..bb49ca05e --date=short --no-merges --format='%ad %ae %s'
BUG=552376
[email protected]
Review-Url: https://codereview.chromium.org/2060383002
Cr-Commit-Position: refs/heads/master@{#399490}
Cleanup: Remove static_casts of NULL in components/
Review-Url: https://codereview.chromium.org/2044323004
Cr-Commit-Position: refs/heads/master@{#399489}
Added girard@ to /device/vr/OWNERS
BUG=389343
Review-Url: https://codereview.chromium.org/2059313002
Cr-Commit-Position: refs/heads/master@{#399488}
MD User Manager: Fixes broken paper-input-container's underline focused color.
BUG=619547
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2063713002
Cr-Commit-Position: refs/heads/master@{#399487}
Remove MessageLoop::current()->task_runner() in content.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in content.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
Review-Url: https://codereview.chromium.org/2049943002
Cr-Commit-Position: refs/heads/master@{#399486}
Auto-rebaseline for r399464
https://chromium.googlesource.com/chromium/src/+/8c0ac8d88
BUG=599917
[email protected]
Review URL: https://codereview.chromium.org/2066483003 .
Cr-Commit-Position: refs/heads/master@{#399485}
X11: Wait for UnmapNotify before trying to remap
A speculative fix for a suspected race condition in which we wait for a
MapNotify that will never come.
BUG=381732
Review-Url: https://codereview.chromium.org/2057333002
Cr-Commit-Position: refs/heads/master@{#399484}
cc: avoid redundant error report on android.
android browser compositor creates output surface without
worker context provider and sets default raster mode as zero-copy.
Avoid redundant setting and error reporting.
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2064543003
Cr-Commit-Position: refs/heads/master@{#399483}
arc: Fixed unrecoverable network failure error in OptIn workflow.
BUG=b/29320474
TEST=Manually on device as described in bug. Network failure
is recoverable and OptIn flow can be continued.
Review-Url: https://codereview.chromium.org/2059323002
Cr-Commit-Position: refs/heads/master@{#399482}
Disable flaky NavigationTest.Navigate
BUG=619523
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2063833002
Cr-Commit-Position: refs/heads/master@{#399481}
Allow reactions to enqueue other reactions for the same element
When upgrade reactions[1] upgrade elements[2], it may enqueue callback
reactions.
This patch allows CustomElementReactionStack to enqueue() for the same
element from within popInvokingReactions().
[1] https://html.spec.whatwg.org/multipage/scripting.html#upgrade-reaction
[2] https://html.spec.whatwg.org/multipage/scripting.html#upgrades
BUG=594918
Review-Url: https://codereview.chromium.org/2052283002
Cr-Commit-Position: refs/heads/master@{#399480}
mojo::ArrayTraits: Add Support for Iterators
This CL adds support for iterating over a data structure to serialize over
mojo as an array wire format.
This CL also modifies changes to LatencyInfo StructTraits that avoids
extra copies of LatencyMap on serialization.
Note that this solution doesn't fully address deserialization though.
You cannot directly assign an std::pair to a map iterator, for example.
The solution is to introduce an ArrayTraits::Assign. I'll do that in a
separate CL as this CL has already gotten very complex.
BUG=611802
[email protected]
Review-Url: https://codereview.chromium.org/2058633002
Cr-Commit-Position: refs/heads/master@{#399479}
Add Label::SetMaximumWidth() and fix wrong comment in SizeToFit()
The implementation of Label::SizedToFit() was wrong but some component depend on that wrong behavior. So this patch fixes the comment of SizedToFit() according to the current behavior, and adds SetMaximumWidth() method which works as the previous SizedToFit() comment expected.
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/1940743003
Cr-Commit-Position: refs/heads/master@{#399478}
Update ChromeVox to use name from in heading rule.
Headings had sometimes repetitive name text when it comes from the contents of the node.
Also, update ChromeVox as per the renaming of the nameFrom and descriptionFrom enum values.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2062543002
Cr-Commit-Position: refs/heads/master@{#399477}
Initialize MDController in ash_shell_with_content
BUG=None
Review-Url: https://codereview.chromium.org/2064763002
Cr-Commit-Position: refs/heads/master@{#399476}
Add support in Chrome to send notifications to a specific device.
This CL adds the Chrome side support for sending notications to a specific
device as well as specifying whether an indiciation or notification should
be used.
Reviews requested:
xiyuan@ - general review
scheib@ - owner's review for the tests
[email protected], [email protected]
BUG=617745
Review-Url: https://codereview.chromium.org/2039773005
Cr-Commit-Position: refs/heads/master@{#399475}
Update V8 to version 5.3.218.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/961239be..08a6f791
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2063753002
Cr-Commit-Position: refs/heads/master@{#399474}
mash: Introduce WmSystemTrayNotifier for //ash/common
SystemTrayNotifier is a dependency of TrayUpdate, which I am trying to move
to //ash/common.
SystemTrayNotifier has a large number of dependencies, so split out a new
version called WmSystemTrayNotifier where we can port dependencies one by one.
Move update notifications to WmSystemTrayObserver.
BUG=615155
TEST=existing ash_unittests, specifically TrayUpdateTest
Review-Url: https://codereview.chromium.org/2060633002
Cr-Commit-Position: refs/heads/master@{#399473}
Revert of Perform BSP polygon splitting and orientation selection in a single step. (patchset #4 id:60001 of https://codereview.chromium.org/2043283002/ )
Reason for revert:
Broke Windows 7 cc_unittests: DrawPolygonSplitTest.AngledSplit
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/53692
Original issue's description:
> Perform BSP polygon splitting and orientation selection in a single step.
>
> This eliminates redundant testing of vertices for orientation with
> respect to the splitting polygon. Previously, up to 3 sets of tests
> were made (once to determine whether the polygon was split, then once
> during the split, and then finally to determine the orientation of the
> split polygons.
>
> Merging these steps in order to reuse calculated values also eliminates
> the possibility that different calculations in testing and splitting
> could be inconsistent.
>
> BUG=606984
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48
> Cr-Commit-Position: refs/heads/master@{#399459}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=606984
Review-Url: https://codereview.chromium.org/2060183003
Cr-Commit-Position: refs/heads/master@{#399472}
Revert of Default components to static libraries in GN build (patchset #15 id:280001 of https://codereview.chromium.org/2043873004/ )
Reason for revert:
This CL causes Win x64 Builder (Perf) compilation error:
FAILED: obj/third_party/WebKit/Source/modules/blink_modules.lib
C:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False lib.exe /nologo /ignore:4221 /LTCG /LTCG /LTCG /LTCG /OUT:obj/third_party/WebKit/Source/modules/blink_modules.lib @obj/third_party/WebKit/Source/modules/blink_modules.lib.rsp
obj/third_party/WebKit/Source/modules/blink_modules.lib : fatal error LNK1248: image size (10061341C) exceeds maximum allowable size (FFFFFFFF)
[791/850] LINK(DLL) mus_library.dll mus_library.dll.lib
[792/850] LINK cc_perftests.exe
ninja: build stopped: subcommand failed.
Also see http://crbug.com/619606.
Original issue's description:
> Default components to static libraries in GN build
>
> Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow.
>
> BUG=617837
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/3b678169f32f46b0bab203bfd0572fad1c314ab7
> Cr-Commit-Position: refs/heads/master@{#399406}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617837
Review-Url: https://codereview.chromium.org/2065633002
Cr-Commit-Position: refs/heads/master@{#399471}
Roll Syzygy binaries to 0.8.19.0.
This includes experimental Crashpad integration.
BUG=565768
Review-Url: https://codereview.chromium.org/2060913002
Cr-Commit-Position: refs/heads/master@{#399470}
Repair Chrome to address update error 51.
Update error 51 occurs when multi-install binaries are installed without
Chrome. This change repairs Chrome if it has been used within the last
28 days.
A new RepairChromeStrandedBinaries test has been added that simulates
this situation for per-user Chrome by installing multi-install Chrome,
updating "lastrun" in the registry to make it appear to be used,
deleting Chrome's pv value, then applying an update to the binaries.
BUG=579627
Review-Url: https://codereview.chromium.org/2036043002
Cr-Commit-Position: refs/heads/master@{#399469}
Roll src/third_party/skia/ d2ebe49e1..fe19987e5 (2 commits).
https://chromium.googlesource.com/skia.git/+log/d2ebe49e1f10..fe19987e5499
$ git log d2ebe49e1..fe19987e5 --date=short --no-merges --format='%ad %ae %s'
2016-06-13 brianosman Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture
2016-06-13 brianosman Request an sRGB FBO0 on Android. Fixes sRGB GL mode.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2059173003
Cr-Commit-Position: refs/heads/master@{#399468}
[Extensions UI] Fix a bug with removing a popped out extension
Fix a bug where removing a popped out extension would cause a crash.
This would only really happen with media router (cast), since all other
extensions are removed asynchronously and would pop themselves back into
the overflow. Add a test.
BUG=599467
Review-Url: https://codereview.chromium.org/2055423002
Cr-Commit-Position: refs/heads/master@{#399467}
MD User Manager: Error message if pref doesn't allow creating supervised user.
BUG=563722
Review-Url: https://codereview.chromium.org/2058083002
Cr-Commit-Position: refs/heads/master@{#399466}
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.
No intended behavior change.
BUG=608380
TBR=rohitrao,thestig
Review-Url: https://codereview.chromium.org/2066533002
Cr-Commit-Position: refs/heads/master@{#399465}
Update libpng to 1.6.22
BUG=599917
BUG=618061
Review-Url: https://codereview.chromium.org/2021403002
Cr-Commit-Position: refs/heads/master@{#399464}
Cleanup SavePackage/SaveItem for readability.
* Remove unused function SaveItem::PercentComplete().
* Change type of FinalNamesMap to std::unordered_map from std::map.
* Remove unused/unnecessary members from SaveItem.
* Fix comments.
* Add thread checks where necessary.
* Assorted renames to reflect reality.
[email protected]
BUG=none
Review-Url: https://codereview.chromium.org/2051153002
Cr-Commit-Position: refs/heads/master@{#399463}
Revert of Make chrome/browser and .../ui static libraries. (patchset #2 id:20001 of https://codereview.chromium.org/2063483002/ )
Reason for revert:
Breaking Win x64 Perf builder (official)
Speculative.
BUG=619606
Original issue's description:
> Make chrome/browser and .../ui static libraries.
>
> On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded.
>
> TBR=dpranke
> (split off of https://codereview.chromium.org/2043873004/ which already has review)
> BUG=617837
>
> Committed: https://crrev.com/2f95a3fb1773f911ca05c26cbacaecc537bd9e31
> Cr-Commit-Position: refs/heads/master@{#399401}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617837
Review-Url: https://codereview.chromium.org/2061773002
Cr-Commit-Position: refs/heads/master@{#399462}
binding: Fixes the fallback mechanism of Document's named properties.
The old implementation only works for
a) there is a hidden prototype, and documentWrapper->GetPrototype()
actually returns itself, or
b) fallbacked attributes are data-type properties.
Since we made attributes be accessor-type properties _and_ removed
the hidden prototype, the old implementation no longer works.
Fixed the issue using V8's GetRealNamedPropertyInPrototypeChain().
BUG=619036
Review-Url: https://codereview.chromium.org/2065523002
Cr-Commit-Position: refs/heads/master@{#399461}
Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #4 id:60001 of https://codereview.chromium.org/2039363002/ )
Reason for revert:
Possibly breaking v8 perf bots.
Original issue's description:
> [Android] Ensure perf test runner does not create shards for blacklisted devices.
>
> BUG=617559
>
> Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
> Cr-Commit-Position: refs/heads/master@{#398197}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617559
Review-Url: https://codereview.chromium.org/2059253002
Cr-Commit-Position: refs/heads/master@{#399460}
Perform BSP polygon splitting and orientation selection in a single step.
This eliminates redundant testing of vertices for orientation with
respect to the splitting polygon. Previously, up to 3 sets of tests
were made (once to determine whether the polygon was split, then once
during the split, and then finally to determine the orientation of the
split polygons.
Merging these steps in order to reuse calculated values also eliminates
the possibility that different calculations in testing and splitting
could be inconsistent.
BUG=606984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2043283002
Cr-Commit-Position: refs/heads/master@{#399459}
Make fake audio file playback loop by default.
Some do long-running tests with --use-file-for-fake-audio-capture, and
since the flag doesn't loop the audio file by default, you'd need a
huge file to play audio during a long-running test.
Instead of specifying <path> you can now specify <path>%noloop for the
flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop
to get the old behavior. To get the new behavior, just pass a wav file
path to the flag.
The current WebRTC audio quality tests currently need the file to stop
after the first playout. Another option could be to pad the audio file
with lots of silence at the end.
BUG=618215
Review-Url: https://codereview.chromium.org/2043353002
Cr-Commit-Position: refs/heads/master@{#399458}
Split the code for fetching images and for decoding images into two separate classes. This will allow to use common code for image URL fetching and platform specific implementations for image decoding.
BUG=609127
Review-Url: https://codereview.chromium.org/2045233002
Cr-Commit-Position: refs/heads/master@{#399457}
Implement parseIconSizes in one place
This CL moves duplicate implementations for parsing icon sizes into
Blink. Existing implementations are insistent, and some of them do not
follow the spec:
https://html.spec.whatwg.org/multipage/semantics.html#attr-link-sizes
BUG=416477
Review-Url: https://codereview.chromium.org/2030603002
Cr-Commit-Position: refs/heads/master@{#399456}
Move classes to //components/ntp_tiles.
Move MostVisitedSites and PopularSites; leave behind ChromePopularSites,
which depends on Chrome paths.
In the short term, there are no changes introduced by this CL; the same
code builds as before against the same dependencies. In the future,
multiple platforms' versions of the new tab page will share this part of
their implementation. (Android's NTP currently is all native code; on
other platforms we use HTML)
BUG=603026
Review-Url: https://codereview.chromium.org/1983063002
Cr-Commit-Position: refs/heads/master@{#399455}
Reorganize event mojom files.
* Moves input_events.mojom to //ui/events/mojo/event.mojom.
* Moves input_event_constants.mojom to //ui/events/mojo/event_constants.mojom.
* Moves input_key_codes.mojom to //ui/events/mojo/keyboard_codes.mojom.
BUG=618808
Review-Url: https://codereview.chromium.org/2057793002
Cr-Commit-Position: refs/heads/master@{#399454}
Displaying human-readable Android credentials on Android OS.
Note: link_url from GetShownOriginAndLinkUrl is not being used.
BUG=617094
Review-Url: https://codereview.chromium.org/2042033003
Cr-Commit-Position: refs/heads/master@{#399453}
Add an AutofillProfileComparator class.
This CL adds an AutofillProfileComparator class that applies broader
heuristics to identify mergeable autofill profiles. This is the first
of several CLs to more intelligently prevent and eliminate duplicate
autofill profiles.
Chrome Autofill often create duplicate profiles. These profiles differ
lexically, but have identical meaning to the user. While we do perform
some level of deduplication, it is insufficient.
We can improve Chrome's ability to detect and resolve duplicate autofill
profiles by adopting the following approaches:
- Normalize fields before comparison to fold case, remove diacritics,
remove punctuation and collapse or remove whitespace.
- Smarter name comparison to account for compound names and the use
of initials. For example, John Quincy Public and John Q. Public.
- Broaden phone number matching to include missing extensions or
area codes.
- Use bag-of-words comparison to compare addresses. This accounts for
different orderings of the information. For example,
23-1 Main St vs 23 Main St, Apt 1
BUG=618095, 587465
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2041413004
Cr-Commit-Position: refs/heads/master@{#399452}
Record FRE events only once during FRE and remove unnecessary interface
Record events in onStart() will cause the events been recorded multiple times.
BUG=618834
Review-Url: https://codereview.chromium.org/2047353005
Cr-Commit-Position: refs/heads/master@{#399451}
Upstream: Enable proguard on WebApk.template.apk in release mode
BUG=609122
Review-Url: https://codereview.chromium.org/2054973002
Cr-Commit-Position: refs/heads/master@{#399450}
Update V8 to version 5.3.217.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/12a24fa8..961239be
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2065603002
Cr-Commit-Position: refs/heads/master@{#399449}
Only trigger session restore logic for urls if it is not first run.
The current logic trumped over start up urls specified in master_prefs
because session restore simply ignored them. Instead of adding them to
session restore we gate session restore logic on the absence of the
first run flag. There should be no session to restore in this case anyway.
Even if the user manually used the --force-first-run it makes sense to
disregard the session restore code as this sounds more in line with the
flag name.
BUG=419580
TEST=StartupBrowserCreatorFirstRunTest.FirstRunTabsWithRestoreSession
Review-Url: https://codereview.chromium.org/2053293003
Cr-Commit-Position: refs/heads/master@{#399448}
Disable svg layouttest on Mac(Retina) and Win
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-shadow-tree-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-deep-shadow-tree-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/resource-invalidate-on-target-update.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/marker-viewBox-changes.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-image.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/js-late-clipPath-and-object-creation.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/js-late-clipPath-creation.svg [ Pass Failure ]
BUG=619103
[email protected]
Review URL: https://codereview.chromium.org/2060863002 .
Cr-Commit-Position: refs/heads/master@{#399447}
Move caching out of MultiThreadedCertVerifier
Split out the logic for caching cert verification from the
MultiThreadedCertVerifier, and into the CachingCertVerifier,
which can add caching/memoization to any CertVerifier.
BUG=612655
Review-Url: https://codereview.chromium.org/1991653002
Cr-Commit-Position: refs/heads/master@{#399446}
Have CanvasAsyncBlobCreator speculative idle tasks keep a weak 'this'.
If image encoding should be attempted done via idle tasks,
CanvasAsyncBlobCreator schedules an idle task along with a delayed
task on the main thread to check if the idle task has been scheduled
before too long. If not, the delayed task will handle the encoding
instead (still on the main thread.)
The idle tasks represent opportunistic work, and should not keep the
CanvasAsyncBlobCreator alive until they eventually do get to run.
Consequently, make them keep a weak 'this' reference.
This addresses leaks exposed by r399181.
R=
BUG=
NOTRY=true
Review-Url: https://codereview.chromium.org/2060153002
Cr-Commit-Position: refs/heads/master@{#399445}
Add a new is_preferred boolean flag to UrlHandlerInfo.
The new flag will be used to communicate preferred activity state from
android to chrome when multiple activities are capable of handling a
given URL.
BUG=b:29248260
Review-Url: https://codereview.chromium.org/2058293002
Cr-Commit-Position: refs/heads/master@{#399444}
Split up deferred startup tasks.
Tasks that depend on the app can take longer in a runnable queue, but
the ones that rely on the activity being active need more care.
Clarifying which ones actually depend on the activity vs app also
gives us more accurate accounting.
BUG=614452
Review-Url: https://codereview.chromium.org/2044403002
Cr-Commit-Position: refs/heads/master@{#399443}
Promptly release cross-thread websocket bridge/proxy references
To prevent other threads using cross-thread persistents from accessing
to-be-finalized websocket Peer and Bridge abstractions, promptly free
them on becoming garbage. Delaying this until lazy sweeping runs risks
(benignly) touching poisoned objects.
R=
BUG=619373
Review-Url: https://codereview.chromium.org/2064633002
Cr-Commit-Position: refs/heads/master@{#399442}
Roll WebRTC 13104:13109
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c0bec8f..c4dedf3
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2064613003
Cr-Commit-Position: refs/heads/master@{#399441}
Drop dependency on webrtc rawtransport and rawtransportchannel.
BUG=
Review-Url: https://codereview.chromium.org/2056243003
Cr-Commit-Position: refs/heads/master@{#399440}
Roll src/third_party/skia/ 3cc37d3db..d2ebe49e1 (1 commit).
https://chromium.googlesource.com/skia.git/+log/3cc37d3db3b8..d2ebe49e1f10
$ git log 3cc37d3db..d2ebe49e1 --date=short --no-merges --format='%ad %ae %s'
2016-06-13 update-skps Update SKP version
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2065563002
Cr-Commit-Position: refs/heads/master@{#399439}
tools/android/loading Add delay before deleting worker instances
Add a random delay before destroying the worker instances. This is done
to avoid a ComputeEngine issue that happens when too many instances are
destroyed at the same time.
Review-Url: https://codereview.chromium.org/2065573002
Cr-Commit-Position: refs/heads/master@{#399438}
Eliminate use of InitToBlack. Replaced by new I420Buffer::SetToBlack.
BUG=webrtc:5682
Review-Url: https://codereview.chromium.org/2052253002
Cr-Commit-Position: refs/heads/master@{#399437}
[NTP Snippets] Small layout fixes to the cards and header
- Fixed the way the header collapses, it now slides under the top card.
https://goo.gl/photos/HvDEupKHb26x7zXW6
- Added space between the text and the button on status cards.
https://goo.gl/photos/fkXrg5aTwMc7fWTr8
BUG=617140,612508
Review-Url: https://codereview.chromium.org/2061653002
Cr-Commit-Position: refs/heads/master@{#399436}
[tools/perf] Tear down state between webview_startup stories
This is needed for --page-repat and --pageset-repeat to work correctly.
BUG=613706
Review-Url: https://codereview.chromium.org/2056323002
Cr-Commit-Position: refs/heads/master@{#399435}
Update expectations for http/tests/workers/terminate-during-sync-operation-file.html on Win10
crbug.com/619539 [ Win10 ] http/tests/workers/terminate-during-sync-operation-file.html [ Pass Timeout ]
BUG=619539
[email protected]
Review URL: https://codereview.chromium.org/2059183002 .
Cr-Commit-Position: refs/heads/master@{#399434}
Update V8 to version 5.3.216.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a905d211..12a24fa8
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2065533002
Cr-Commit-Position: refs/heads/master@{#399433}
telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops
Stop measuring tough_path_rendering_cases chalkboard test-case after the
page stops its "benchmark" and presents the results.
The page used to wait 20s. On my desktop it runs <10s and on my
particular Android device, ~17s.
This avoids measuring the page after it stops updating.
Review-Url: https://codereview.chromium.org/1994653004
Cr-Commit-Position: refs/heads/master@{#399432}
Disable failing LayoutTests.
crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-empty.html [ Failure ]
+crbug.com/484632 [ Win7 ] transforms/2d/zoom-menulist.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-rtl-default.html [ Failure ]
+crbug.com/484632 [ Win7 ] http/tests/webfont/popup-menu-load-webfont-after-open.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug2479-3.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug29326.html [ Failure ]
+crbug.com/484632 [ Win7 Linux ] fast/replaced/table-percent-height.html [ Failure ]
+crbug.com/484632 [ Win7 ] virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/replaced/width100percent-menulist.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/replaced/replaced-breaking.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/core/margins.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-single-option.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug96334.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug4382.html [ Failure ]
+crbug.com/484632 [ Win7 ] virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-zoom090.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/dom/tableDom.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-long.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select/select-visual-hebrew.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/text/international/bidi-menulist.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla_expected_failures/bugs/bug2479-5.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/invalid/014.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/text/international/pop-up-button-text-alignment-and-direction.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-transform.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug1188.html [ Failure ]
+crbug.com/484632 [ Win7 ] virtual/scalefactor200/fast/hidpi/static/popup-menu-appearance.html [ Failure ]
+crbug.com/484632 [ Win7 Mac10.11 ] fast/parser/document-write-option.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/replaced/three-selects-break.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/html/keygen.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-texttransform.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug2479-4.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug33855.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select/select-baseline.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-many.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-styled.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select/select-selected.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/text/international/menulist-width-rtl.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/replaced/replaced-breaking-mixture.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select-popup/popup-menu-appearance-tall.html [ Failure ]
+crbug.com/484632 [ Win7 ] fast/forms/select/select-writing-direction-natural.html [ Failure ]
+crbug.com/484632 [ Win7 ] tables/mozilla/bugs/bug18359.html [ Failure ]
+
BUG=484632
[email protected]
Review URL: https://codereview.chromium.org/2060223002 .
Cr-Commit-Position: refs/heads/master@{#399431}
[chromedriver] Apply page load timeout to back/forward navigations and reloads.
This CL further employs timeouts handling introduced in
https://codereview.chromium.org/1669453002/ and fixes a couple issues:
- NavigationTracker could cause a long wait in OnCommandSuccess;
- when a navigation times out, WebViewImpl::WaitForPendingNavigations
did not wait for it to stop.
BUG=chromedriver:1292
R=samuong
Review-Url: https://codereview.chromium.org/1995663002
Cr-Commit-Position: refs/heads/master@{#399430}
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros
Replaced ASSERT with DCHECK in mediasession module.
BUG=596522
Review-Url: https://codereview.chromium.org/2058783002
Cr-Commit-Position: refs/heads/master@{#399429}
Move SourceRange and CSSPropertySourceData classes off-heap.
SourceRange is a value/POD class that has no complex
sharing or lifetime handling associated with it. It does not
meet minimal requirements that we've now settled on for when
an object ought to be Oilpan managed -- doesn't have other
heap references nor sharing&lifetime issues that would benefit
from Oilpan use -- hence, we should move it off-heap.
With SourceRange off-heap, a number of classes that package up
SourceRanges in various ways can be converted to off-heap
classes also.
R=
BUG=
Review-Url: https://codereview.chromium.org/2060433002
Cr-Commit-Position: refs/heads/master@{#399428}
Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #1 id:1 of https://codereview.chromium.org/2057193003/ )
Reason for revert:
This breaks:
* UBSan vptr Release: https://build.chromium.org/p/chromium.lkgr/builders/UBSan%20vptr%20Release/builds/3782/steps/compile/logs/stdio
clang: error: argument unused during compilation: '-fsanitize-coverage=edge'
This is https://crbug.com/618534
* The 3 32-bit x86 with 32-bit arm v8 asan bots, e.g. https://build.chromium.org/p/chromium.lkgr/builders/ASan%20Debug%20%2832-bit%20x86%20with%20V8-ARM%29/builds/2477/steps/compile/logs/stdio
../../v8/src/base/build_config.h:145:2: error: Target architecture ia32 is only supported on ia32 host
#error Target architecture ia32 is only supported on ia32 host
^
I filed https://crbug.com/619503 for this.
Original issue's description:
> Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ )
>
> Reason for revert:
> This might work now (see https://crbug.com/618702, which I forgot to mention in the revert message).
>
> Original issue's description:
> > Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
> >
> > Reason for revert:
> > This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
> >
> > I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
> >
> > Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
> >
> > Original issue's description:
> > > Flip Linux bots on chromium.lkgr to GN.
> > >
> > > [email protected], [email protected]
> > > BUG=605732
> > >
> > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> > > Cr-Commit-Position: refs/heads/master@{#398038}
> >
> > [email protected],[email protected],[email protected]
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=605732
> >
> > Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
> > Cr-Commit-Position: refs/heads/master@{#398904}
>
> [email protected],[email protected],[email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=605732
>
> Committed: https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75
> Cr-Commit-Position: refs/heads/master@{#399261}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605732
NOTRY=true
Review-Url: https://codereview.chromium.org/2063673002
Cr-Commit-Position: refs/heads/master@{#399427}
Use an inline capacity for CSSTokenizer's Vector<CSSParserToken>
This patch adds an inline capacity of 32 to CSSTokenizer's vector of
parser tokens. This improves performance of parsing short pieces of CSS,
for example setting inline styles, as we don't need to allocate memory
for this vector. The capacity of 32 is chosen arbitrarily to accomodate
most uses of inline styles (we reserve an initial capacity of length/3).
This patch makes setting inline transforms to strings that miss the fast
path ~2% faster on my z620. Note that this is not a reliable testing
device, but we still expect that this optimisation improves performance.
BUG=619498
Review-Url: https://codereview.chromium.org/2058403002
Cr-Commit-Position: refs/heads/master@{#399426}
RenderViewObserver -> RenderFrameObserver in password_generation_agent.h comment
Updates an outdated comment.
[email protected]
BUG=433486
Review-Url: https://codereview.chromium.org/2061643002
Cr-Commit-Position: refs/heads/master@{#399425}
Disable SingleProcessTracingBrowserTest.TestMemoryInfra on Linux.
BUG=619515
[email protected]
Review URL: https://codereview.chromium.org/2059133002 .
Cr-Commit-Position: refs/heads/master@{#399424}
Make trace() over persistents private.
Persistent references register a trace callback with the underlying persistent
node, allowing the Blink GC to trace the persistent root set when marking.
Consequently, there's no need to expose their trace() methods as public
methods. Make them private and thereby disallow calling trace() from
Blink code.
R=
BUG=
Review-Url: https://codereview.chromium.org/2060683002
Cr-Commit-Position: refs/heads/master@{#399423}
[perf] Prepare benchmarks for memory metric normalization (vol. 2)
This is patch is necessary so that benchmarks using the memory metric
wouldn't stop reporting values once
https://codereview.chromium.org/2018503002/ lands.
First preparation patch: https://codereview.chromium.org/2044853002/
BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2060443002
Cr-Commit-Position: refs/heads/master@{#399422}
Update V8 to version 5.3.215.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/580a3b99..a905d211
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2061613002
Cr-Commit-Position: refs/heads/master@{#399421}
Add UseCounter for Date.parse's legacy parse heuristics.
[email protected], [email protected]
BUG=chromium:618595
Review-Url: https://codereview.chromium.org/2055713002
Cr-Commit-Position: refs/heads/master@{#399420}
Support infinite Toast showing and dismiss_text.
This CL adds two supports to toast feature:
- Supporting infinite toast UI showing.
Currently it always has the duration to show the UI,
so the message will be automatically hidden on timeout.
With this CL, '-1' means no-timeout.
- Supporting dismiss_text.
The dismiss_text will replace the dismiss button's label.
It is optional, if not set, the message we are now using
is used as a default value.
BUG=b/27995648
TEST=git cl try. Tested manually with client side implementation.
No breakage without client side implementation.
Review-Url: https://codereview.chromium.org/2055303002
Cr-Commit-Position: refs/heads/master@{#399419}
Make textInputController#selectedRange() not to crash when there is no selection.
This patch makes |textInputController#selectedRange()| not to crash when
there is no selection by checking whether |WebRange| is non-null or null to
make ClusterFuzz to be happy.
Since, |textInputController#selectedRange()| is available only for layout test
runner, this patch doesn't affect "real" users.
BUG=585750
TEST=n/a; no user visible changes
Review-Url: https://codereview.chromium.org/2065513002
Cr-Commit-Position: refs/heads/master@{#399418}
Get rid of useless function HitTestResult::spellingToolTip()
This patch gets rid of useless function |HitTestResult::spellingToolTip()|,
which returns result of grammar checking, since Blink doesn't support grammar
checking, to simplify source code for improving code health.
BUG=619452
TEST=n/a; no user visible changes
Review-Url: https://codereview.chromium.org/2059093002
Cr-Commit-Position: refs/heads/master@{#399417}
Fix unsafe handling of part object in RuleFeatureSetTest.
The part object needs to be traced; the ad-hoc and unused
trace method used prevented GC plugin detection.
R=
BUG=
NOTRY=true
Review-Url: https://codereview.chromium.org/2063603002
Cr-Commit-Position: refs/heads/master@{#399416}
Add storage_manager.DeleteApplicationsCache RPC
BUG=29306776
Review-Url: https://codereview.chromium.org/2058373002
Cr-Commit-Position: refs/heads/master@{#399415}
Fix GN build on is_clang=false configuration.
The CL <https://codereview.chromium.org/2059843002> introduced an
"if (is_clang)" guard to //build/sanitizers:copy_llvm_symbolizer, but
there is a bare reference to that target without a is_clang guard, which
causes unmet dependencies on is_clang=false build.
BUG=none
Review-Url: https://codereview.chromium.org/2058383002
Cr-Commit-Position: refs/heads/master@{#399414}
Force FrameView::checkDoesNotNeedLayout() not inlined in FrameView.cpp
Some new crash reports just report the line calling
checkDoesNotNeedLayout() but not which line in the function
crashes.
BUG=590856
[email protected]
Review URL: https://codereview.chromium.org/2062693002 .
Cr-Commit-Position: refs/heads/master@{#399413}
Update V8 to version 5.3.214.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/245b66c2..580a3b99
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2059083002
Cr-Commit-Position: refs/heads/master@{#399412}
Add events tests for inputText in IME test
BUG=614937
Review-Url: https://codereview.chromium.org/2010803005
Cr-Commit-Position: refs/heads/master@{#399411}
Don't need to preserve CSS line-height property during editing operation
When we merge two paragraphs by typing backspace key at the head
of the second paragraph, the styles of the second paragraph can be
preserved by using <span> tag. However, we don't need to preserve
line-height style because the computed value can be different from
the value defined in HTML.
BUG=226941
TEST=editing/deleting/backspace-merge-two-paragraphs.html
Review-Url: https://codereview.chromium.org/2064473002
Cr-Commit-Position: refs/heads/master@{#399410}
Support a ui::test::EventGenerator constructed with a single argument on Mac
EventGeneratorDelegateMac::SetContext(..) ignores |root_window|. If that
was all that's provided, assume it's the active window.
This fixes all the Mac views_unittests regressions from r398705.
BUG=618880
Review-Url: https://codereview.chromium.org/2053253002
Cr-Commit-Position: refs/heads/master@{#399409}
Fix: return FILTER_ERROR through the chain of filters
When the data is compressed by gzip, sdch and we apply
double filter chaining (gzip, sdch, gzip, sdch) for some
reason, the filters should pass the FILTER_ERROR message
back through the chain of filters to avoid unnecessary
job and return just an empty output buffer instead of an
output filled by garbage, even though the third filter is
not applied.
+ created a test for this case.
BUG=513846
Review-Url: https://codereview.chromium.org/2052833002
Cr-Commit-Position: refs/heads/master@{#399408}
Convert media-source*, no-autoplay* and remove-from* tests to testharness.js
Cleaning up media-source*, no-autoplay* and remove-from* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2065433002
Cr-Commit-Position: refs/heads/master@{#399407}
Default components to static libraries in GN build
Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow.
BUG=617837
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2043873004
Cr-Commit-Position: refs/heads/master@{#399406}
arc: IPC method to open wallpaper picker.
BUG=chromium:618922
TEST=Manually tested.
Review-Url: https://codereview.chromium.org/2058513004
Cr-Commit-Position: refs/heads/master@{#399405}
Respect the order of input messages from browser to renderer
When we call InputConnection#setSelection and other methods together,
the order sometimes does not get kept. The reason is that
SetEditableSelectionOffsets is a frame message while all the others are
input messages, and they go to different message queues.
In addition, RenderViewImpl is the only who registers its routing ID
through InputHandlerManager::AddInputHandler() call. RenderFrameImpl,
on the other hand, does not register itself.
Once routing ID is registered, InputEventFilter will post input messages to
compositor impl thread first (such that scrolling can happen inside
compositor impl thread and keep in line with other input message handling
order).
We fix this by
1) Changing SetEditableSelectionOffsets from FrameMsg to InputMsg.
(Now there is no remaining frame messages in ime_adapter_android.cc.)
2) Change DidAddInputHandler() and DidRemoveInputHandler() names to
RegisterRoutingID() and UnregisterRoutingID(), respectively.
3) Register RenderFrame's routing ID at InputEventFilter.
BUG=601707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1877073003
Cr-Commit-Position: refs/heads/master@{#399404}
exo: Implement version 3 of remote shell interface.
Adds basic support for pin, as well as allowing the
client to request that window is pinned.
BUG=b/27995648
TEST=exo_unittests
Review-Url: https://codereview.chromium.org/2059943002
Cr-Commit-Position: refs/heads/master@{#399403}
Generate VS projects also for target dependencies.
This changes the way the --filters argument to
`gn gen --ide=vs --filters=X;Y;...` works so that
the information for all the dependents of X and Y will be generated
along with the information for X and Y.
This CL is based on [email protected]'s patch from
issue 2027733004 at patchset 1 (http://crrev.com/2027733004#ps1),
just updated w/ the review feedback, so we can land it.
[email protected], [email protected], [email protected]
BUG=589099
Review-Url: https://codereview.chromium.org/2060613002
Cr-Commit-Position: refs/heads/master@{#399402}
Make chrome/browser and .../ui static libraries.
On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded.
TBR=dpranke
(split off of https://codereview.chromium.org/2043873004/ which already has review)
BUG=617837
Review-Url: https://codereview.chromium.org/2063483002
Cr-Commit-Position: refs/heads/master@{#399401}
LocalFrame::localLayerTreeAsText() ==> layerTreeAsText()
There is no "local" layer tree as the layer tree is crossing frame
boundaries. Rename localLayerTreeAsText() to layerTreeAsText()
and remove the original layerTreeAsText().
The test expectations that included sub-frame layer trees just
repeated subtrees in the main layers layer tree.
Review-Url: https://codereview.chromium.org/2060083002
Cr-Commit-Position: refs/heads/master@{#399400}
Mark paint/invalidation/animated-gif-background-offscreen.html flaky
BUG=619103
Cr-Commit-Position: refs/heads/master@{#399399}
Mark virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html flaky on Linux
BUG=619427
Review URL: https://codereview.chromium.org/2060703002 .
Cr-Commit-Position: refs/heads/master@{#399398}
Use base::TimeTicks & base::TimeDelta for UpdateVSyncParameters.
BUG=None
Review-Url: https://codereview.chromium.org/2055513002
Cr-Commit-Position: refs/heads/master@{#399397}
Mac video: Enable fullscreen low power mode
BUG=594460
Review-Url: https://codereview.chromium.org/2059863004
Cr-Commit-Position: refs/heads/master@{#399396}
Add test for single quote suborigin option.
BUG=336894
[email protected]
Review-Url: https://codereview.chromium.org/2058893002
Cr-Commit-Position: refs/heads/master@{#399395}
Convert track-webvtt-tc[024-026] tests to testharness.js
Cleaning up track-webvtt-tc[024-026] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2051233004
Cr-Commit-Position: refs/heads/master@{#399394}
Roll WebGL fda7011..2eef1ea
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fda7011..2eef1ea
BUG=
TEST=bots
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2064503002
Cr-Commit-Position: refs/heads/master@{#399393}
Convert unsupported* and video-append* tests to testharness.js
Cleaning up unsupported* and video-append* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2062673002
Cr-Commit-Position: refs/heads/master@{#399392}
Do not suppress referrers for '<a ... rel="noopener">'.
The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.
BUG=618532
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2058693002
Cr-Commit-Position: refs/heads/master@{#399391}
Implement MusGpuMemoryBufferManager.
Implement the MusGpuMemoryBufferManager which is used by MUS
locally. It supports allocating Native GpuMemoryBuffer(Ozone, etc).
It is needed for ChromeBook/ozone native rendering.
BUG=618316
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2049083002
Cr-Commit-Position: refs/heads/master@{#399390}
Rename and improve "traceable" templates.
The NeedsTracing<T>::value expression would previously return true
if T had a trace() method or T == Member<U>. It would not be
true if T == WeakMember<U>; something that was convenient when
using NeedsTracing<> in connection with hash table backing stores,
needing to determine whether to trace the elements of the table, but
not if they were weak references & delegate that to weak processing.
As NeedsTracing<T> has grown an increasing number of uses besides
the handling of backing store tracing, where exempting WeakMember<>
makes no great sense, it is time to alter its meaning to accommodate
those uses better. And at the same time rename it to follow the various
other predicate templates we provide over types. So,
NeedsTracing<T> => IsTraceable<T> (includes weak)
NeedsTracingLazily<T> => IsTraceableInCollection<T> (excludes weak)
NeedsTracingTrait<Trait> => IsTraceableInCollectionTrait<T>
Along with these changes, tidy up the static_assert() error messages in
a few places.
R=
BUG=
Review-Url: https://codereview.chromium.org/2065443002
Cr-Commit-Position: refs/heads/master@{#399389}
ash: Add a unit test for the system update tray item
I'm about to refactor SystemTrayNotifier and TrayUpdate, and I want more
confidence that I'm not breaking it.
This also changes the default "update required" state in ash unit tests to not
having an update.
BUG=619181
TEST=ash_unittests TrayUpdateTest
Review-Url: https://codereview.chromium.org/2060003002
Cr-Commit-Position: refs/heads/master@{#399388}
Precache manifest should not be added to fetcher pool which is full
Fetcher pool accepts limited number of requests which are fetched in
parallel. If the pool is full, precache manifest resources should not be
added to it.
BUG=606231
Review-Url: https://codereview.chromium.org/2037903002
Cr-Commit-Position: refs/heads/master@{#399387}
Updating trunk VERSION from 2766.0 to 2767.0
Cr-Commit-Position: refs/heads/master@{#399386}
Auto-rebaseline for r399384
https://chromium.googlesource.com/chromium/src/+/6c46c2c41
BUG=619103
[email protected]
Review URL: https://codereview.chromium.org/2062663002 .
Cr-Commit-Position: refs/heads/master@{#399385}
Disable incremental invalidation for SVG
Incremental invalidation is a feature where size changes (e.g.,
shrinking an object's height) can only invalidate the shrunken region
instead of the entire object. This can lead to underinvalidation bugs
if the object is not fully opaque, such as the case of rounded corners.
This patch switches all incremental invalidations to be full
invalidations.
BUG=619108
Review-Url: https://codereview.chromium.org/2062533002
Cr-Commit-Position: refs/heads/master@{#399384}
Prevent a crash where CSS containment assumed a layer would be created
SVG has different PaintLayer semantics and does not currently use
PaintLayers. This patch fixes a crash where CSS containment assumed
a layer would be present for an SVG text node.
Additionally, the DCHECK in ~BoxClipper has been updated to match the
conditional in the BoxClipper constructor.
BUG=613929
Review-Url: https://codereview.chromium.org/2062643002
Cr-Commit-Position: refs/heads/master@{#399383}
Mojo: Add NotifyBadMessage API
Adds a new public API for rejecting user messages read from
a message pipe. The EDK can in some simple cases (e.g. messages
from a direct child to its parent process) determine the source
process of the bad message and notify the embedder via a callback
API.
BUG=607293
Review-Url: https://codereview.chromium.org/2043713004
Cr-Commit-Position: refs/heads/master@{#399382}
Flip remaining Linux builders to GN.
This CL flips the last remaining Linux builders to GN, the
MSAN builders on the chromium.lkgr and chromium.webkit
waterfalls.
[email protected], [email protected], [email protected]
BUG=605732
Review-Url: https://codereview.chromium.org/2059003003
Cr-Commit-Position: refs/heads/master@{#399381}
exo: Fix Linux DMA-buf interface.
Set buffer implementation correctly instead of having the buffers
allocated using this interface be immediately destroyed.
BUG=549781
Review-Url: https://codereview.chromium.org/2062653002
Cr-Commit-Position: refs/heads/master@{#399380}
Revert of [Android] Use devil for status and recovery in bb_device_status_check. (patchset #2 id:20001 of https://codereview.chromium.org/2056343003/ )
Reason for revert:
Speculative revert as it seems to be crashing the host_info step on all Android bots.
BUG=619342
Original issue's description:
> [Android] Use devil for status and recovery in bb_device_status_check.
>
> BUG=619045
>
> Committed: https://crrev.com/391365fc50704855ec9eeb91c53cbe0d47d229e9
> Cr-Commit-Position: refs/heads/master@{#399350}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619045
Review-Url: https://codereview.chromium.org/2063563002
Cr-Commit-Position: refs/heads/master@{#399379}
Add use counter for parsing of filter functions with no arguments
Count before deciding the future for this, and related, "features".
BUG=618960
Review-Url: https://codereview.chromium.org/2051233003
Cr-Commit-Position: refs/heads/master@{#399378}
Add missing 'compiler.gni' import to //BUILD.gn.
[email protected]
BUG=619086
Review-Url: https://codereview.chromium.org/2058363002
Cr-Commit-Position: refs/heads/master@{#399377}
Splits PipelineImpl into main and media thread components.
The outer PipelineImpl runs on the main thread and acts as a proxy
between PipelineClient and the internal RendererWrapper that runs on
the media thread. This sets the stage to get rid of WaitableEvent
and Locks used in PipelineImpl.
This patch should not change anything functionality wise except for
timing of the notifications received from Demuxer and Renderer. In
response to the notifications we used to change member variables
inside a lock. Now we post a task to change those variables to the
main thread. The list of variables affected by this change are:
- buffered_time_ranges_
- did_loading_progress_
- duration_
- statistics_
BUG=616959
Review-Url: https://codereview.chromium.org/1999893004
Cr-Commit-Position: refs/heads/master@{#399376}
ImageCapture: add Java PhotoCapabilities and wire reading it on Java and native
This CL represents the Android-related files necessary for
implementing the retrieval of Zoom from Android into native,
as part of a larger set of PhotoCapabilities. PhotoCapabilities
is expected to grow to include more parameters, see [1].
These set of files are extracted from
https://crrev.com/1996403002/ to ease reviewing
(see also https://crrev.com/2031073002 where
capture is made a component so it can pull mojo
as a dependency).
[1] http://w3c.github.io/mediacapture-image/index.html#photocapabilities
BUG=518807
TEST= see mentioned CL or run demo html in
https://rawgit.com/Miguelao/demos/master/imagecapture.html
with flag --enable-blink-features=ImageCapture
(click on "Open Camera 320x240", then on
"Create Image Capturer", open a console and type
theImageCapturer.getPhotoCapabilities()
and see the (temporary) DVLOG in the console.
Review-Url: https://codereview.chromium.org/2050993002
Cr-Commit-Position: refs/heads/master@{#399375}
Fix compile errors in ca_layer_tree_unittest_mac.mm.
../../ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm:83:25: error: no viable overloaded '='
properties.io_surface =
~~~~~~~~~~~~~~~~~~~~~ ^
../../base/mac/scoped_typeref.h:87:18: note: candidate function not viable: cannot convert argument of
incomplete type 'IOSurfaceRef' (aka '__IOSurface *') to
'const ScopedTypeRef<__IOSurface *, base::internal::ScopedCFTypeRefTraits<__IOSurface *> >'
for 1st argument
ScopedTypeRef& operator=(const ScopedTypeRef<T, Traits>& that) {
[email protected]
BUG=none
Review-Url: https://codereview.chromium.org/2058953002
Cr-Commit-Position: refs/heads/master@{#399374}
Move file chooser from RenderView(Host) to RenderFrame(Host).
The file chooser does not work with out-of-process iframes, since it works through RenderView(Host). It needs to be moved to user RenderFrame(Host) at which point it works for subframes in a process different from its parent.
BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
[email protected]
Review-Url: https://codereview.chromium.org/2050623005
Cr-Commit-Position: refs/heads/master@{#399373}
tools/android/loading Add link to dashboard and a way to cancel tasks.
Review-Url: https://codereview.chromium.org/2053363002
Cr-Commit-Position: refs/heads/master@{#399372}
Update V8 to version 5.3.213.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/de69a97c..245b66c2
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2063553002
Cr-Commit-Position: refs/heads/master@{#399371}
Use base::SysInfo::AmountOfTotalDiskSpace() where appropriate.
Review-Url: https://codereview.chromium.org/2058223002
Cr-Commit-Position: refs/heads/master@{#399370}
Handle the "key" field as opposed to keyIdentifier field.
keyIdentifier will be deprecated soon so we need to move over to the
standardized identifier.
Approved Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ
BUG=607349
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2045603002
Cr-Commit-Position: refs/heads/master@{#399369}
Roll src/third_party/skia/ cadb5a24c..3cc37d3db (1 commit).
https://chromium.googlesource.com/skia.git/+log/cadb5a24c20d..3cc37d3db3b8
$ git log cadb5a24c..3cc37d3db --date=short --no-merges --format='%ad %ae %s'
2016-06-11 reed tweak mipmap_srgb gm to use integer coordinates
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2055003004
Cr-Commit-Position: refs/heads/master@{#399368}
histograms.xml: Added a new cryptohome error enum value.
New cryptohome error for the case when the keyset is wrapped by
both TPM and Scrypt.
BUG=chromium:411923
Review-Url: https://codereview.chromium.org/2034323002
Cr-Commit-Position: refs/heads/master@{#399367}
Revert of Re-reland: Make media/capture gn and gyps produce components (patchset #3 id:140001 of https://codereview.chromium.org/2055293002/ )
Reason for revert:
Failed in Win x64 bot
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1507/steps/compile/logs/stdio
Original issue's description:
> Re-reland: Make media/capture gn and gyps produce components
>
> Reland got reverted due to a WinX64 typical issue:
> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
>
> This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
> but just in case also addresses the problem by forcing static_cast<int>() in
> places where size_t was implicitly casted to int, causing C4267 in
> https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/compile/logs/stdio
>
> Original reland description -------------------------------------------
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
>
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> [email protected], [email protected], [email protected]
> since the PS2/3 are trivial, just making explicit libs that are
> already elsewhere in media/ build files- I wonder why it didn't fail in
> the bots :( .
>
> Committed: https://crrev.com/058cd78b87dbb0ba9f1ea64667418f4d61d25f58
> Cr-Commit-Position: refs/heads/master@{#399365}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807
Review-Url: https://codereview.chromium.org/2054353002
Cr-Commit-Position: refs/heads/master@{#399366}
Re-reland: Make media/capture gn and gyps produce components
Reland got reverted due to a WinX64 typical issue:
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
but just in case also addresses the problem by forcing static_cast<int>() in
places where size_t was implicitly casted to int, causing C4267 in
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/compile/logs/stdio
Original reland description -------------------------------------------
Reland: Make media/capture gn and gyps produce components
Which got reverted due to a Mac build breakage (see
https://codereview.chromium.org/2059493002/) and
a Win one (https://crbug.com/618854).
Original description ---------------------------------------------------
Make media/capture gn and gyps produce components
This CL separates media/capture into a component,
to allow, in a subsequent CL, linking with mojo for using
ImageCapture types.
This basically reproduces the media/cast and media/midi
structure.
Windows import/export issues made necessary to add
capture_export and associated CAPTURE_EXPORT macro,
again, replicating media/midi.
gn gen ... --check uncovered some transitive dependencies
during the "analyze" phase of the bots and I had to make
them explicit (e.g. media:gpu).
BUG=518807
-----------------------------------------------------------------------
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
[email protected], [email protected], [email protected]
since the PS2/3 are trivial, just making explicit libs that are
already elsewhere in media/ build files- I wonder why it didn't fail in
the bots :( .
Review-Url: https://codereview.chromium.org/2055293002
Cr-Commit-Position: refs/heads/master@{#399365}
Fix CrOS build for enable_nacl=false.
[email protected]
BUG=612647
Review-Url: https://codereview.chromium.org/2055023004
Cr-Commit-Position: refs/heads/master@{#399364}
Roll DEPS for sfntly to 468cad5.
[email protected]
BUG=614934
Review-Url: https://codereview.chromium.org/2060023003
Cr-Commit-Position: refs/heads/master@{#399363}
Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.
Generated with https://codereview.chromium.org/2056153003/.
BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2058233002
Cr-Commit-Position: refs/heads/master@{#399362}
Fix logic for checking chrome-sandbox setuid binary
We only need to check for chrome-sandbox if we plan on launching
zygotes with the setuid sandbox or we need it to adjust OOM scores.
Also, the error only needs to be fatal when we want the setuid
sandbox.
BUG=598454
Review-Url: https://codereview.chromium.org/1976403002
Cr-Commit-Position: refs/heads/master@{#399361}
Perform alarm's period limit check while reading alarm info from StateStore.
We used to only check for the minimum allowable period length in
chrome.alarms.create(). This CL also adds that check when alarms are
read through StateStore. This CL stores alarm.minimum_granularity to make
sure we do not poll more frequently than that granularity.
Because already stored (before this CL) alarms in StateStore won't have
minimum_granularity set, fall back to a relaxed minimum_granularity
in those cases (kDevDelayMinimum).
This CL also bumps up the minimum allowed period (kDevDelayMinimum)
for unpacked extensions from 0s to ~1s. The rationale is that using
a 0s period can result in very high browser memory usage very quickly.
For example, in test, I could make the browser/ process take up to
10GB of memory within 30s of browser run.
BUG=618540
Test=See bug description for repro case.
Review-Url: https://codereview.chromium.org/2051573003
Cr-Commit-Position: refs/heads/master@{#399360}
Revert of Mojo interface for Leak Detector on remote process (patchset #2 id:20001 of https://codereview.chromium.org/2018983004/ )
Reason for revert:
Need to re-submit mojom interface and implementation in single CL, and get security review from IPC owners.
Original issue's description:
> Mojo interface for Leak Detector on remote process
>
> This interface allows an instance of the Runtime Memory Leak Detector
> (components/metrics/leak_detector) to run on a non-browser process, such
> as a tab (renderer) process. The interface provides two function APIs:
>
> - GetParams(): Returns the profiling parameters used for initializing
> LeakDetector.
> - SendLeakReports(): Passes an array of leak reports in serialized proto
> format (strings) to the browser process, where they can be attached to
> the UMA protobuf.
>
> BUG=chromium:615223
> TEST=Build successfully
> [email protected]
>
> Committed: https://crrev.com/51e4f33eae448bae4c95fde5a8f16d6d2e6e6960
> Cr-Commit-Position: refs/heads/master@{#396780}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:615223
Review-Url: https://codereview.chromium.org/2055393002
Cr-Commit-Position: refs/heads/master@{#399359}
Roll src/third_party/skia/ 815110353..cadb5a24c (3 commits).
https://chromium.googlesource.com/skia.git/+log/8151103535ba..cadb5a24c20d
$ git log 815110353..cadb5a24c --date=short --no-merges --format='%ad %ae %s'
2016-06-10 bsalomon Make large array of GrShapes in test code heap allocated
2016-06-10 csmartdalton Move multisampleDisableSupport into GrCaps
2016-06-10 mtklein Type-erase SkAutoMutexAcquire and SkAutoExclusive.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2053423003
Cr-Commit-Position: refs/heads/master@{#399358}
Updating trunk VERSION from 2765.0 to 2766.0
Cr-Commit-Position: refs/heads/master@{#399357}
DevTools: upstream the stl version of the gyp files for v8_inspector.
BUG=580337
NOTRY=true
Review-Url: https://codereview.chromium.org/2054243002
Cr-Commit-Position: refs/heads/master@{#399356}
Revert of Add LeakDetectorRemoteController as a Mojo service (patchset #6 id:100001 of https://codereview.chromium.org/2030883004/ )
Reason for revert:
Need to re-submit mojom interface and implementation in single CL, and get security review from IPC owners.
Original issue's description:
> Add LeakDetectorRemoteController as a Mojo service
>
> New class LeakDetectorRemoteController that implements the Mojo
> interface LeakDetectorRemote. This class provides a bridge between the
> browser and renderer processes. It also allows a single instance of
> LeakDetectorController to provide leak detector params to the renderer
> process and receive leak reports from the renderer process.
>
> The renderer process client will be implemented in a future CL.
>
> BUG=chromium:615223
>
> Committed: https://crrev.com/23bcb38936fddb66a15c02315d05d62e529756d4
> Cr-Commit-Position: refs/heads/master@{#398775}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:615223
Review-Url: https://codereview.chromium.org/2062483002
Cr-Commit-Position: refs/heads/master@{#399355}
Removed unnecessary mutable in SiblingData.
Seemingly no reason for this mutable anymore.
[email protected]
Review-Url: https://codereview.chromium.org/2057093002
Cr-Commit-Position: refs/heads/master@{#399354}
Remove unused variables, cc/ edition.
These were exposed while trying to make various geometry classes constexpr.
BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2054253002
Cr-Commit-Position: refs/heads/master@{#399353}
Add config so perbots test tamper detection experiment
Lists the tamper detection group in the list of experimental
groups that should be tested by perfbots.
BUG=597969
Review-Url: https://codereview.chromium.org/2048233002
Cr-Commit-Position: refs/heads/master@{#399352}
[ios] Extracted web_test.h classes into separate files.
web::WebTest, web::WebTestWithWebStates and
web::WebTestWithWebController are now separate classes
placed in separate files. Old web_test.h files is kept
temporary to switch all downstream files to use new includes.
BUG=619076
Review-Url: https://codereview.chromium.org/2060483003
Cr-Commit-Position: refs/heads/master@{#399351}
[Android] Use devil for status and recovery in bb_device_status_check.
BUG=619045
Review-Url: https://codereview.chromium.org/2056343003
Cr-Commit-Position: refs/heads/master@{#399350}
Make large test_support targets static libraries.
On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded.
TBR=dpranke
(split off of https://codereview.chromium.org/2043873004/ which already has review)
BUG=617837
Review-Url: https://codereview.chromium.org/2063503002
Cr-Commit-Position: refs/heads/master@{#399349}
Delete OnscreenDisplayClient and TopLevelDisplayClient.
These classes just own Display and forward along the client calls to
the owner of themselves. Instead, have code own a cc::Display directly.
Part of this reworks how OutputSurface gets to the Display. Previously
the OnscreenDisplayClient would hold the OutputSurface created during
creation of the delegated OutputSurface to be given to the compositor.
But it wouldn't be given to the Display until the compositor bound the
delegated OutputSurface from LayerTreeHostImpl.
Now, we give the display's OutputSurface to it at construction time of
the Display. The Display will continue to bind it when it is
Initialize()'d by the delegated output surface in the compositor being
bound. However, now the DisplayClient (the delegated OutputSurface) is
created after the Display is, since it wants to have a pointer to the
Display. So we give the DisplayClient to the Display at the time of
Initialize().
Lastly, SurfaceDisplayOutputSurface was doing some shady things to avoid
binding the lost context callback on the shared context provider (shared
between the compositor's delegated and the display's OutputSurface) more
that once. It would avoid calling OutputSurface::BindToClient() and
implemented it partially itself. I changed this to call the parent but
just unset the callback with a comment explaining that we want it to go
to the Display (via its own OutputSurface) first, so we have it set up
the callback (which happens in Initialize).
The point of this whole thing was to work on merging the two delegated-
to-a-display output surface implementations: SurfaceDisplayOutputSurface
and PixelTestDelegatingOutputSurface. In the end this doesn't appear
feasible since the PixelTestDelegatingOutputSurface is meant for the
renderer, which can have a threaded compositor. In that case, the
Display, SurfaceManager, etc should be created, used and destroyed on the
compositor thread since they are not threadsafe. At least hopefully this
makes ownership more clear.
[email protected], [email protected], [email protected], [email protected]
BUG=487471
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2036563002
Cr-Commit-Position: refs/heads/master@{#399348}
Prevent sign extension for pointer trace values
This makes 32-bit pointers serialize like "0xdeadbeef", not
"0xffffffffdeadbeef".
BUG=618221
Review-Url: https://codereview.chromium.org/2043233003
Cr-Commit-Position: refs/heads/master@{#399347}
Disallow invalid enums in TexParameter*
GL_TEXTURE_IMMUTABLE_FORMAT and GL_TEXTURE_IMMUTABLE_LEVELS are valid enums for
GetTexParameter* but not for TexParameter* so make sure to disallow them.
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2058663002
Cr-Commit-Position: refs/heads/master@{#399346}
Capture from Video Element: micro fix s/coded_size/natural_size/
Following some offline discussion, changing the reference to
VideoFrame::natural_size() with coded_size(). This was causing
no bug due to those being equal after the initialization of the
VideoFrame in l.155, where
scoped_refptr<media::VideoFrame> frame = frame_pool_.CreateFrame(
media::PIXEL_FORMAT_I420, resolution, gfx::Rect(resolution), resolution,
base::TimeTicks::Now() - base::TimeTicks());
both were made equal to |resolution|, but is (more) correct to
use coded_size.
BUG=569976
Review-Url: https://codereview.chromium.org/2053093003
Cr-Commit-Position: refs/heads/master@{#399345}
[TTS] Fix the Quick Answer Caption in RTL languages.
When invalidate is called a new snapshot is taken. However it's possible
for the renderer to try to render during the invalid period. In this case
it may show the previous snapshot.
A previous attempt to fix this issue tried to snapshot a blank image,
but that caused a possibility of showing a blank image without overwriting
with a valid image, which we never saw until looking at RTL (which is
presumably slower taking a snapshot).
Exposing ViewResourceInflater#onEndCapture to subclasses to allow waiting for the capture of
the new snapshot to complete.
Added a new caption visibility property to the ContextualSearchLayer to control whether the resource for the caption is available, which allows a snapshot. Now the Caption Control checks whether a snapshot is complete before
returning a valid opacity.
BUG=610675, 608914
Review-Url: https://codereview.chromium.org/2038753005
Cr-Commit-Position: refs/heads/master@{#399344}
Update V8 to version 5.3.212.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/37d5cf9f..de69a97c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2058963002
Cr-Commit-Position: refs/heads/master@{#399343}
Revert of [PCv2] Add tracing category needed for computing ttfmp (patchset #3 id:40001 of https://codereview.chromium.org/2049593002/ )
Reason for revert:
Speculative revert, suspecting crashing the reference test page_cycler_v2.typical_25.reference on mac.
BUG=619254
Original issue's description:
> [PCv2] Add tracing category needed for computing ttfmp
>
> The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled.
> This CL enables recording of the category in PCv2.
>
> https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/system_health/first_paint_metric.html
>
> BUG=None
>
> Committed: https://crrev.com/f9bc2493524f028607a8755c5bcfd8f51ba17998
> Cr-Commit-Position: refs/heads/master@{#399186}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.chromium.org/2057413002
Cr-Commit-Position: refs/heads/master@{#399342}
Settings People Revamp: Add 'Manage Supervised Users' row
Only displays when user actually has supervised users.
BUG=617245, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2062503002
Cr-Commit-Position: refs/heads/master@{#399341}
Adds support for new-tab targeted loads initiated from the renderer.
- My WCD impl in navigation::ViewImpl didn't provide an impl of "WCD::OpenURLInTab".
- Fix some crashes in browser.
[email protected]
Review-Url: https://codereview.chromium.org/2057023002
Cr-Commit-Position: refs/heads/master@{#399340}
exo: Only create new SurfaceLayer if layer properties change.
This allows us to avoid an unnecessary browser compositor commit and draw if only the contents of the buffer change, which saves CPU.
BUG=610086
Review-Url: https://codereview.chromium.org/2041193006
Cr-Commit-Position: refs/heads/master@{#399339}
Roll WebRTC 13098:13104
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/456c3c7..c0bec8f
As part of this roll, also adding more detailed tracing to JingleThreadWrapper.
After this CL, WebRTC starts posting messages with a location, which
includes a file name, function and line number:
https://codereview.webrtc.org/2019423006/
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
Review-Url: https://codereview.chromium.org/2037873003
Cr-Commit-Position: refs/heads/master@{#399338}
Mac: Flip fullscreen low power layer geometry
This is done for the regular content layer, and needs to be done for
the fullscreen low power layer.
BUG=594460
Review-Url: https://codereview.chromium.org/2062463002
Cr-Commit-Position: refs/heads/master@{#399337}
Store the received token if the native library is not yet loaded
What used to happen before this CL?
if the library load takes a long time, and the callback for the token
comes back before it is finished, client will never connect
BUG=617656
Review-Url: https://codereview.chromium.org/2062513002
Cr-Commit-Position: refs/heads/master@{#399336}
Add dcheng to base/OWNERS.
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2056343005
Cr-Commit-Position: refs/heads/master@{#399335}
Cleanup comparison with NULL for DCHECK.
Substitutes smart_pointer.get() == NULL with !smart_pointer in DCHECKs.
BUG=NONE
Review-Url: https://codereview.chromium.org/2030693003
Cr-Commit-Position: refs/heads/master@{#399334}
ash: Remove an unnecessary include and forward declare
Code review feedback from https://codereview.chromium.org/2058173002
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2058673004
Cr-Commit-Position: refs/heads/master@{#399333}
Remove unnecessary dependencies on mojo/edk/system
Since we no longer need to compensate for intentionally
underspecified dependencies on public Mojo APIs, targets
which don't directly depend on mojo/edk sources no longer
need to express a direct dependency on //mojo/edk/system.
This removes all the unnecessary ones, and as a result
also gets rid of the blink_for_unittests target which
only needed to exist because of this weirdness.
BUG=612500
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2059983002
Cr-Commit-Position: refs/heads/master@{#399332}
Check rect under-invalidations
There are two modes:
- Using RuntimeEnabledFeatures::slimmingPaintUnderInvalidationChecking.
When the feature is enabled, for each paint, changed pixels without
invalidation are logged and marked red.
- In layout tests, when tracking paint invalidation, content_shell will
crash if there are any changed pixels without invalidation.
The method is: for each GraphicsLayer, after each paint, save the
painted picture. After another paint, rasterize the old and new pictures
into bitmaps and compare the bitmaps. If any pixel changed but not
covered by paint invalidations between the paints, take action (log,
mark as red or crash).
BUG=617799,619242
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2049263003 .
Cr-Commit-Position: refs/heads/master@{#399331}
Auto-rebaseline for r399293
https://chromium.googlesource.com/chromium/src/+/468190372
BUG=484632
[email protected]
Review URL: https://codereview.chromium.org/2061513002 .
Cr-Commit-Position: refs/heads/master@{#399330}
Skip SiteDetailsBrowserTest.PlatformAppsNotIsolated in --site-per-process.
The test tests exemption of isolating frames in platform apps (r399229) with
--isolate-extensions. This exemption doesn't apply to --site-per-process, so
don't run the test in that mode.
BUG=612711
Review-Url: https://codereview.chromium.org/2055413002
Cr-Commit-Position: refs/heads/master@{#399329}
Remove MessageLoop::current()->task_runner() in chrome.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in chrome.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
Review-Url: https://codereview.chromium.org/2055073003
Cr-Commit-Position: refs/heads/master@{#399328}
[Android] Fix a bug that snackbar does not show when there is no tab on tablet
EmptyBackgroundViewWrapper is the Android View that becomes visible when
there is no tabs on Android tablet Chrome. Since this View hides the
CompositorViewHolder, snackbars becomes not be visible in this mode.
This CL makes EmptyBackgroundViewWrapper aware of SnackbarManager, and
let it override the parent of the snackbar temporarily when it shows up.
BUG=614696
Review-Url: https://codereview.chromium.org/2032773002
Cr-Commit-Position: refs/heads/master@{#399327}
Added const getter for WebState's NavigationManager.
This allows for readonly access to navigation state via a const
reference to a WebState (e.g. from WebStateObservers).
BUG=none
Review-Url: https://codereview.chromium.org/2046063005
Cr-Commit-Position: refs/heads/master@{#399326}
More detailed checking of FrameView::needsLayout()
BUG=590856
Review-Url: https://codereview.chromium.org/2052263004
Cr-Commit-Position: refs/heads/master@{#399325}
Flip Linux MSAN (non-CF) bots to GN.
The CF bots on chromium.lkgr will be flipped in a separate CL.
[email protected], [email protected]
BUG=605732
Review-Url: https://codereview.chromium.org/2033483003
Cr-Commit-Position: refs/heads/master@{#399324}
Don't suspend caret blinking on long press
Don't suspend caret if the mouse click comes from touch.
BUG=618888
Review-Url: https://codereview.chromium.org/2053213002
Cr-Commit-Position: refs/heads/master@{#399323}
Add ability to delete plugin private data
Currently encrypted media content licenses are stored in plugin
private data (as decryption happens in a pepper plugin). Add the
ability to erase the data on request.
As the data is organized by origin and plugin, all files for a
particular origin/plugin combination are removed if any of the files
matches the time criteria. The existing plugins only use 1 file
currently, but this should avoid issues if the plugins change to
use multiple files.
The UI is still being debated, so this is simply adding the ability
to delete the data once called.
BUG=607631
TEST=new content_unittests pass
Review-Url: https://codereview.chromium.org/1979733002
Cr-Commit-Position: refs/heads/master@{#399322}
Send API error response when chrome.socket.* API receives an invalid port number.
We used to call EXTENSION_FUNCTION_VALIDATE to validate these, which would
result in CHECK on debug builds and bad_message_ = true in release builds.
bad_message_ will end up killing the extension process.
BUG=619158
Test=See bug description for repro case.
Review-Url: https://codereview.chromium.org/2058513006
Cr-Commit-Position: refs/heads/master@{#399321}
Add support for user certificates in Android N.
BUG=616511
Review-Url: https://codereview.chromium.org/2059943003
Cr-Commit-Position: refs/heads/master@{#399320}
value_cleanup: Rewrite more base::ListValue::Append(base::Value*) calls.
The tool now understands how to rewrite simple cases of constructing a
new base::Value that's stored in a raw pointer, manipulating it to
populate the data, and then passing ownership into base::ListValue with
the raw pointer overload of base::ListValue::Append.
BUG=581865
Review-Url: https://codereview.chromium.org/2056153003
Cr-Commit-Position: refs/heads/master@{#399319}
Fixing copresence crash
BUG=616989
[email protected]
Review URL: https://codereview.chromium.org/2053973002 .
Cr-Commit-Position: refs/heads/master@{#399318}
Add tracing for DescheduleUntilFinishedCHROMIUM.
This makes it easier to track down problems with chrome://tracing. This should
have no functional effect.
BUG=617249
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2060533002
Cr-Commit-Position: refs/heads/master@{#399317}
[Chromecast] Add CDM support to CastMojoMediaClient.
Implement CastMojoMediaClient::CreateRendererFactory to add browser-
side CDM support in cast_shell. Verified on internal Chromecast build.
BUG=571155
Review-Url: https://codereview.chromium.org/1740473003
Cr-Commit-Position: refs/heads/master@{#399316}
MD Settings: Add display_overscan dialog
BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1999203003
Cr-Commit-Position: refs/heads/master@{#399315}
Add ClipboardMonitor and ClipboardObserver for notifiying clipboard data change event.
The clipboard changes are only monitored on X11 and chromeos platform so far. No code is implemented for windows and mac.
BUG=460610
Review-Url: https://codereview.chromium.org/2013273002
Cr-Commit-Position: refs/heads/master@{#399314}
Add more known exes to ProcessHashName enum
[email protected]
Review-Url: https://codereview.chromium.org/2052403002
Cr-Commit-Position: refs/heads/master@{#399313}
Disable flaky test ExtensionStorageMonitorTest.UninstallExtension
[email protected]
BUG=617801
Review-Url: https://codereview.chromium.org/2058913002
Cr-Commit-Position: refs/heads/master@{#399312}
Fix background show logic for UI compositor
The logic that determined whether or not to show the background
of the root layer is no longer applicable due to the toolbar layer
always being a parent to the content. This change updates the
background visibility logic in for StaticTabSceneLayer to look at
the root layer.
BUG=615365
Review-Url: https://codereview.chromium.org/2040513002
Cr-Commit-Position: refs/heads/master@{#399311}
Using new WebRtc methods that use a refptr instead of raw pointer.
This will allow the old methods that use a raw pointer to be removed.
Review-Url: https://codereview.chromium.org/2051603002
Cr-Commit-Position: refs/heads/master@{#399310}
Remove unused variables, ui/ edition.
These were exposed while trying to make various geometry classes constexpr.
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2060603002
Cr-Commit-Position: refs/heads/master@{#399309}
Revert of Optimize render passes with single quads (patchset #13 id:240001 of https://codereview.chromium.org/1960543002/ )
Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing
BUG=619185
Original issue's description:
> Optimize render passes with single quads
>
> Many effects (masks, replicas, filters) generate render passes for
> simplicity in the code. However, in the cases where the pass contains a
> single quad with a texture, that resulting texture could just be used as
> the input texture instead of the render pass itself.
>
> The complication is mostly that render passes and tile textures are
> flipped relative to each other (oops) and so some knowledge of this has
> to leak into drawing render passes.
>
> This is done by detecting such render passes inside of DirectRenderer,
> storing the TileQuad that would have been drawn, skipping allocating the
> pass and rendering it, and then calling a slightly modified version of
> DrawRenderPassQuad with the TileQuad's resource. The check for which
> render passes can be supported is conservative to start.
>
> This optimization usually will not be supported on mac because skia
> does not support textures with texture rectangle targets as input.
>
> BUG=254639,606672
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/ff3dc65b0f7845184458fb25b3d566fa079cd232
> Cr-Commit-Position: refs/heads/master@{#399060}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=254639,606672
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2058013003
Cr-Commit-Position: refs/heads/master@{#399308}
[battor benchmark] Enable Chrome tracing in the BattOr benchmark
This wasn't possible before due to
https://github.com/catapult-project/catapult/issues/2341.
BUG=618370
Review-Url: https://codereview.chromium.org/2051933002
Cr-Commit-Position: refs/heads/master@{#399307}
Update Autofill Private API to provide a list of available countries.
BUG=607347
Review-Url: https://codereview.chromium.org/2028903002
Cr-Commit-Position: refs/heads/master@{#399306}
Revert of Auto-rebaseline for r399060 (patchset #1 id:1 of https://codereview.chromium.org/2056993002/ )
Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing
BUG=619185
Original issue's description:
> Auto-rebaseline for r399060
>
> https://chromium.googlesource.com/chromium/src/+/ff3dc65b0
>
> BUG=254639
> [email protected]
>
> Committed: https://crrev.com/68faa261f0095f54cc38e9fc5cfb540f06e1fee4
> Cr-Commit-Position: refs/heads/master@{#399076}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=254639
Review-Url: https://codereview.chromium.org/2063433003
Cr-Commit-Position: refs/heads/master@{#399305}
Decouple capture timestamp and reference time
In this CL, we make the captured VideoFrame to take capture device
timestamp; and take system clock reference time.
Background:
Previously, we have only timestamp parameter, and it actually
plays the role as timestamp and reference_time.
Here we define timestamp as the ideal time span between
the current frame and the first frame in the stream.
Define reference time as the system clock time when the frame
gets generated.
Ideally, timestamp can be derived from reference_time.
However, in reality, especially in a multi process application
like Chrome, system clock read has noise on the order of 5ms.
To overcome that, we found the original timestamp from camera
driver is much smoother. But the defect is that the camera
clock would have a drift with respect to the system clock.
Thus a perfect solution would be that we take system time for
reference time, which is used for AV sync; we stream timestamp
to the remote side, which will make the rendering smooth.
This CL is complete for the complete fix.
BUG=601657
[email protected]
Review-Url: https://codereview.chromium.org/2045813003
Cr-Commit-Position: refs/heads/master@{#399304}
Revert of Disable blink layout tests related to crbug/254639 + (patchset #1 id:1 of https://codereview.chromium.org/2059723002/ )
Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing
BUG=619185
Original issue's description:
> Disable blink layout tests related to crbug/254639 +
> crbug.com/254639 css3/filters/effect-brightness-hw.html [ Failure Pass ]
> crbug.com/254639 css3/filters/effect-hue-rotate-hw.html [ Failure Pass ]
>
> [email protected]
> BUG=254639
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2af0f64999cc750dadcc0ba17b7cb7e8fe9a9563
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=254639
Review-Url: https://codereview.chromium.org/2054293002
Cr-Commit-Position: refs/heads/master@{#399303}
Fix crash with respect to a retain ptr not being initialized correctly.
The ScrollbarPainter object returned from scrollerImpWithStyle
is allocated and autoreleased but not retained anywhere.
Call retain on the object and then create the RetainPtr
with AdoptNS.
BUG=520024, 590130
Review-Url: https://codereview.chromium.org/2026603002
Cr-Commit-Position: refs/heads/master@{#399302}
[MD Settings] Check that iron-icons are non-empty in tearDown()
Iron icons (and by extension, elements like paper-icon-buttons) can be
empty if an include is missing. Add a test so that any present iron
icons in the DOM at tearDown are checked.
BUG=
Review-Url: https://codereview.chromium.org/1950133006
Cr-Commit-Position: refs/heads/master@{#399301}
Reland: Switch WTF::find on LChar to use memchr.
BUG=607208
Review-Url: https://codereview.chromium.org/2043063003
Cr-Commit-Position: refs/heads/master@{#399300}
Add initial stub implementation of LocalActivityResolver.
ShouldChromeHandleUrl just returns true for now. In future it
will return true only if Chrome should handle this URL. Part of b\29248657
BUG=619137
Review-Url: https://codereview.chromium.org/2059573002
Cr-Commit-Position: refs/heads/master@{#399299}
Landing recent QUIC changes until 6/7/2016 04:42 UTC
n/a (Remove unused typedefs)
Remove unused typedefs in QUIC for PacketNumberList and PacketNumberSet.
Merge internal change: 124232563
https://codereview.chromium.org/2050363002/
Flatten QuicRandomBoolSource. No functional change. Not flag protected.
The dereference takes up to 0.2% CPU now.
Merge internal change: 124167705
https://codereview.chromium.org/2051183002/
Deprecate quic_avoid_empty_nonfin_writes
Merge internal change: 123980047
https://codereview.chromium.org/2057713002/
Replace QUIC's ServerHelloNotifier with a check to see if the decrypted packet is forward secure. Protected by quic_no_shlo_listener.
Merge internal change: 123916474
https://codereview.chromium.org/2050303002/
Ignore QUIC data frames of length 0 for flow control accounting. Protected by --quic_ignore_zero_length_frames
If there are queued bytes and the stream is RST before they are sent, then the RstStreamFrame which is sent to the peer will correctly include the final byte offset of (sent_bytes), so flow control states will stay in sync.
Merge internal change: 123865596
https://codereview.chromium.org/2052923002/
Remove quic_crypto_server_config_default_has_chacha20. ChaCha20 is now fast. No functional change.
Merge internal change: 123859515
https://codereview.chromium.org/2042333003/
Remove unnecessary dependencies in Quic quic_packet_reader_lib. No behavior change.
Merge internal change: 123746446
https://codereview.chromium.org/2046153002/
Enable packet tossing.
Merge internal change: 123676532
https://codereview.chromium.org/2048513003/
Increase QUIC's default receive buffer size from 256k to 1MB. Not flag protected.
No longer manually set quic_reply_to_rej to false for EndToEndTest or expect no packet loss in TestHugeResponseWithPacketLoss.
When merging into Chromium, ensure the flag is set to true as is quic_ignore_srbf.
Merge internal change: 123674806
https://codereview.chromium.org/2043043003/
Check to see if a QUIC CHLO is "acceptable" as a matter of policy in the QUIC ServerSessionBase::Helper instead of the crypto stream. Protected by --gfe2_reloadable_flag_quic_enable_chlo_policy
Merge internal change: 123671618
https://codereview.chromium.org/2041413003/
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2054933002
Cr-Commit-Position: refs/heads/master@{#399298}
Remove deprecated extension ready notification from first_run.cc
And use OneShotEvent& ExtensionSystem::ready() instead.
BUG=354459
Review-Url: https://codereview.chromium.org/2035413002
Cr-Commit-Position: refs/heads/master@{#399297}
[Md Feedback] Add initial content/strings to feedback-container element.
Changes include:
- Create feedback-container custom Polymer element with initial contents/strings and very minimal styling.
- String localization. The strings are primarily duplicates of the existing feedback, which avoids messiness if/when one set of strings are modified.
- Add newly used resources to polymer_resources.grdp.
WebUI interaction/functionality implemented later.
BUG=615535, 606844
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2039593002
Cr-Commit-Position: refs/heads/master@{#399296}
Renamed AppMenuBadgeController to AppMenuIconController
Since the app menu doesn't use "badges" under MD, it uses separate icons in place of the three vertically oriented dots. This is a follow-on CL to this one: https://codereview.chromium.org/1966643002/
BUG=584342
[email protected]
Review-Url: https://codereview.chromium.org/2039403002
Cr-Commit-Position: refs/heads/master@{#399295}
Handle NullPointerException when there is no active network
BUG=619075
Review-Url: https://codereview.chromium.org/2058883002
Cr-Commit-Position: refs/heads/master@{#399294}
Reserve enough vertical space for the menuList layout element setting its logical height to the max option height.
The option's height is calculated from option's text FloatRect generated by CachingWordShaper.
BUG=484632
TEST=fast/forms/select/menulist-height-change.html
Review-Url: https://codereview.chromium.org/2055593002
Cr-Commit-Position: refs/heads/master@{#399293}
Add tbansal to nqe OWNERS
BUG=
Review-Url: https://codereview.chromium.org/2040373007
Cr-Commit-Position: refs/heads/master@{#399292}
Clean Up Windows Thread Join Debug Code
BUG=127931
Review-Url: https://codereview.chromium.org/2053393002
Cr-Commit-Position: refs/heads/master@{#399291}
Disable flaky test ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest
[email protected]
BUG=617865
Review-Url: https://codereview.chromium.org/2056103003
Cr-Commit-Position: refs/heads/master@{#399290}
Roll src/third_party/skia/ 7049396b6..815110353 (8 commits).
https://chromium.googlesource.com/skia.git/+log/7049396b6566..8151103535ba
$ git log 7049396b6..815110353 --date=short --no-merges --format='%ad %ae %s'
2016-06-10 reed fix non-square stroke rects (non-aa)
2016-06-10 herb Make SkBlitter hierarchy explicit about what needs to be implemented.
2016-06-10 kjlubick Remove shaderc cmake compiling
2016-06-10 bungeman Implement SkFontMgr_Custom::onCreateFromFontData.
2016-06-10 csmartdalton Fix GrDrawContextPriv::stencilRect
2016-06-10 bsalomon Extend inverse_paths GM to test dashing GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057213002
2016-06-10 kjlubick Create .gyp rules for shaderc libraries
2016-06-10 reed respect srgb gamma when building mips
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2062473002
Cr-Commit-Position: refs/heads/master@{#399289}
Fix GN bootstrap.
Add two files needed to compile GN.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2059803002
Cr-Commit-Position: refs/heads/master@{#399288}
Don't resume paused media. Don't resume playing media after timeout.
As titled. We shouldn't resume paused media because there's no
reason to not wait for the user interaction. We shouldn't resume
playing media if the user has moved on to other tasks and comes
back some time later.
The idle timeout for resuming playing media is 5 seconds as chosen
by a dice roll.
BUG=617815
TEST=media suspends and resumes as expected.
Review-Url: https://codereview.chromium.org/2039793005
Cr-Commit-Position: refs/heads/master@{#399287}
Move VP8 top-off logic from WebRtcFrameScheduler to WebRtcVideoEncoderVpx
Previously WebRtcFrameScheduler contained top-off logic, while
WebRtcVideoEncoderVpx also supported top-off for VP9. With this change
WebRtcVideoEncoderVpx is always responsible for top-off logic for both
VP8 and VP9.
Review-Url: https://codereview.chromium.org/2050893002
Cr-Commit-Position: refs/heads/master@{#399286}
Clean up some nits in base::NativeLibrary.
- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().
Review-Url: https://codereview.chromium.org/2042103002
Cr-Commit-Position: refs/heads/master@{#399285}
Disable flaky test on linux
BUG=619148
TBR=wjmaclean
Review-Url: https://codereview.chromium.org/2061483002
Cr-Commit-Position: refs/heads/master@{#399284}
Update V8 to version 5.3.207.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5755d7ee..37d5cf9f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2058813002
Cr-Commit-Position: refs/heads/master@{#399283}
[Mac/GN] Fix typo in "Default Apps".
BUG=431177
[email protected]
Review URL: https://codereview.chromium.org/2056123004 .
Cr-Commit-Position: refs/heads/master@{#399282}
[Media Router WebUI] Prevent error when route becomes null
Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.
BUG=614144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2053743002
Cr-Commit-Position: refs/heads/master@{#399281}
Introduce PlatformThread::Detach
This will allow callers to decide at runtime if they want to detach or join
against a thread. This is particularly useful for threadpools that need to
detach to release resources or join to clean up during unit tests.
BUG=616867
Review-Url: https://codereview.chromium.org/2033243002
Cr-Commit-Position: refs/heads/master@{#399280}
Fix Windows Condition Variable GetLastError Check
During the SleepConditionVariableCS days, the GetLastError was checked
against WAIT_TIMEOUT. This should have been ERROR_TIMEOUT per the docs.
WAIT_TIMEOUT applies to functions like WaitForSingleObject (and more).
BUG=619037
Review-Url: https://codereview.chromium.org/2053403002
Cr-Commit-Position: refs/heads/master@{#399279}
Add billing address identifier to WalletMaskedCard.
BUG=602663
Review-Url: https://codereview.chromium.org/2058513002
Cr-Commit-Position: refs/heads/master@{#399278}
mash: Move SystemTrayDelegate ownership to WmShell
This makes it possible to use inside //ash/common.
(SystemTrayDelegate is a dependency of TrayUpdate, which I'm in the process
of moving to //ash/common.)
* Make WmShell non-pure-virtual
* Fix now-unneeded includes of shell.h
* Fix some unnecessary ash:: qualifiers along the way
BUG=615155
TEST=existing ash_unittests, chrome unit_tests and browser_tests
[email protected] for mechanical changes to //chrome/browser
Review-Url: https://codereview.chromium.org/2058173002
Cr-Commit-Position: refs/heads/master@{#399277}
Revert of Change //build/config/compiler:optimize_max to use -O3. (patchset #1 id:1 of https://codereview.chromium.org/2048163002/ )
Reason for revert:
Reverting, this caused a size regression for cronet that is more important to them than any likely perf gains.
I'll re-land a different CL that's less broad.
Original issue's description:
> Change //build/config/compiler:optimize_max to use -O3.
>
> Certain components (e.g., v8) really want to be compiled with -O3,
> but the current ":optimize_max" setting just used -O2. Since "max"
> should theoretically mean "max", let's try making it be -O3 across
> the board and see what happens.
>
> [email protected]
> BUG=616031
>
> Committed: https://crrev.com/96a6dfa2c30ab9b22abd20c87ed0e0d6ae41c40e
> Cr-Commit-Position: refs/heads/master@{#398704}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=616031
Review-Url: https://codereview.chromium.org/2062433002
Cr-Commit-Position: refs/heads/master@{#399276}
Disable testFindNext CTS test
BUG=618089
Review-Url: https://codereview.chromium.org/2061473002
Cr-Commit-Position: refs/heads/master@{#399275}
Fix DropdownPopupWindow's position in Android N.
In Android N, the framework will read view.getLeft() and view.getTop() to
determine where to put the drop down, and if the anchor view is not on screen,
the parent view will be scrolled to make it on screen (by means of
requestChildRectangleOnScreen).
setLayoutParams() is not enough to change left and top values of the anchorView
immediately. Show()ing the ListPopupWindow immediately after setLayoutParams()
will show the popup window in the wrong location, and also cause the parent view
to be improperly scrolled.
Call postShow() to put show() after when the layout of the anchor view is
changed.
Initial selection has to be set after show() is actually called,
because getListView() is null until the ListPopupWindow is shown.
BUG=614746
Review-Url: https://codereview.chromium.org/2049523005
Cr-Commit-Position: refs/heads/master@{#399274}
Clean up Mojo C API dependent targets
Wipes out references to mojo/public/c/system:for_component and
:for_shared_library which are now unnecessary.
mojo/public/cpp/bindings and mojo/public/cpp/sysetm now carry
mojo/public/c/system as a public_deps and there's no longer a
need for targets to explicitly link against it or its variants.
This renders the dependencies much easier to understand since
they reflect what's seen in the code.
Also opportunistically cleans up deps/public_deps on many
affected targets since a lot of these were wrong.
BUG=None
[email protected] for mus, mash, mojo, toplevel, ui
[email protected] for blink gn changes
[email protected]
Review-Url: https://codereview.chromium.org/2058023004
Cr-Commit-Position: refs/heads/master@{#399273}
DevTools: allow toValue to accept unique_ptr.
Review-Url: https://codereview.chromium.org/2060463002
Cr-Commit-Position: refs/heads/master@{#399272}
Remove MessageLoop::current()->RunUntilIdle() in blimp.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in blimp.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2058523002
Cr-Commit-Position: refs/heads/master@{#399271}
[Android] Fix provision devices failure getting timeout.
Fixing provision devices script failing if timeout is not manually
set and one of the devices is unresponsive.
BUG=619088
Review-Url: https://codereview.chromium.org/2059863002
Cr-Commit-Position: refs/heads/master@{#399270}
Opens the HaTS dialog with an empty HTML
Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2057853002
Cr-Commit-Position: refs/heads/master@{#399269}
Roll src/third_party/catapult/ 01b5224b1..62c88709e (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/01b5224b17c8..62c88709ef86
$ git log 01b5224b1..62c88709e --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2059973002
Cr-Commit-Position: refs/heads/master@{#399268}
Re-enable TestMemoryInfra browser tests
The single process memory infra tests were failing because the number of
tracing categories exceeded the MAX_CATEGORY_GROUPS. This is increased
to 200 to suit the needs of single proecss mode (WebView).
BUG=594884
[email protected]
Review-Url: https://codereview.chromium.org/2043883003
Cr-Commit-Position: refs/heads/master@{#399267}
Track password field id so it can be used to improve uniqueness of passwordId
BUG=618717
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2053393003
Cr-Commit-Position: refs/heads/master@{#399266}
Fix for sync filesystem app crash.
Previously removing the SafePointScope had a risk of producing a dead lock if the following scenario happens:
1) The main thread starts a GC and tries to stop all other threads.
2) The worker thread is waiting on a signal without entering the SafePointScope. The main thread cannot stop the worker thread forever and thus cannot make progress. Dead lock.
However, (to avoid this kind of dead lock) code has been added to timeout the GC if the GCing thread fails at stopping other threads within 100 ms. So not entering SafePointScope will just cause the timeout -- it won't cause a dead lock.
This fixes a hard-to-reproduce timing bug that's been a big concern of one of our partners.
BUG=592124,608603
TEST=manual
Review-Url: https://codereview.chromium.org/2009093002
Cr-Commit-Position: refs/heads/master@{#399265}
Remove MessageLoop::current()->RunUntilIdle() in gpu.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in gpu.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2055013002
Cr-Commit-Position: refs/heads/master@{#399264}
Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId
Review-Url: https://codereview.chromium.org/1861963008
Cr-Commit-Position: refs/heads/master@{#399263}
Implement GetMediaClientAndroid() in {Aw|Cast}ContentClient.
This is needed to setup the correct MediaClientAndroid in the GPU
process. See GpuChildThread::Init() and BUG for more info.
Also, to be able to use {Aw|Cast}MediaClientAndroid in
ContentClient, these files are moved from */browser/* to
*/common/*, which caused a lot of noise in this CL unfortunately.
Note that WebView doesn't use out-of-process GPU process, so this
CL will not affect WebView today. But if WebView ever want to
switch to out-of-process GPU process, then it'll just work because
of this CL.
BUG=618433
TEST=Verified on Cast and Android WebView.
Review-Url: https://codereview.chromium.org/2050863002
Cr-Commit-Position: refs/heads/master@{#399262}
Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ )
Reason for revert:
This might work now (see https://crbug.com/618702, which I forgot to mention in the revert message).
Original issue's description:
> Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
>
> Reason for revert:
> This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
>
> I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
>
> Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
>
> Original issue's description:
> > Flip Linux bots on chromium.lkgr to GN.
> >
> > [email protected], [email protected]
> > BUG=605732
> >
> > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> > Cr-Commit-Position: refs/heads/master@{#398038}
>
> [email protected],[email protected],[email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=605732
>
> Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
> Cr-Commit-Position: refs/heads/master@{#398904}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605732
Review-Url: https://codereview.chromium.org/2057193003
Cr-Commit-Position: refs/heads/master@{#399261}
exo: Add support for importing YVU_420 buffers.
This CL adds support for importing YVU_420 buffers via the
wayland drm and dmabuf interfaces into Exo.
BUG=618516
Review-Url: https://codereview.chromium.org/2046743002
Cr-Commit-Position: refs/heads/master@{#399260}
bluetooth: Use BluetoothUUID instead of string when sending uuids
This patch introduces a Typemap from mojo::String to unique_ptr<device::BluetoothUUID>.
Mapping to base::Optional allows us to have a nullable type.
BUG=606446
Review-Url: https://codereview.chromium.org/2015463004
Cr-Commit-Position: refs/heads/master@{#399259}
Disallow CommitOverlayPlanes on surfaces that don't support it
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2053243002
Cr-Commit-Position: refs/heads/master@{#399258}
Record the amount of time spent recording histograms.
BUG=546019
Review-Url: https://codereview.chromium.org/2058523004
Cr-Commit-Position: refs/heads/master@{#399257}
Remove [ Failure Pass ] expectation for video-layer-crash.html.
It was mildly flaky before my patch, so in all likelihood this trouble was
caused only by the rebaseline bot picking a bad run on Retina (there are
flaky-but-pass-on-retry failures before and after my original patch on the
flakiness dashboard, and it's not obvious why this test is flaky).
BUG=618693
Review-Url: https://codereview.chromium.org/2059903002
Cr-Commit-Position: refs/heads/master@{#399256}
Remove obsoleted function and add test
Remove OfflinePageUtils::MaybeGetOfflineURLForOnlineURL
Add OfflinePageUtilsTest::GetOfflineURLForOnlineURL
BUG=618732
Review-Url: https://codereview.chromium.org/2059513002
Cr-Commit-Position: refs/heads/master@{#399255}
Include network UDPSocket is bound to in NetLog.
This helps debug QUIC connection migration.
R=xunjieli
Review-Url: https://codereview.chromium.org/2051993004
Cr-Commit-Position: refs/heads/master@{#399254}
Include gdb and strace in Blimp Engine container image
BUG=618802
Review-Url: https://codereview.chromium.org/2054953002
Cr-Commit-Position: refs/heads/master@{#399253}
Move implementation of QuotaManager.getVolumeInfo to base::SysInfo.
We get both total disk space and available disk space in multiple places.
I'd like to move the QuotaManager's implementation to base::SysInfo so that we can share the implementation.
This CL also changes the type of disk size from uint64_t to int64_t to be consistent with base::SysInfo::AmountOfFreeDiskSpace().
BUG=none
Review-Url: https://codereview.chromium.org/2052663003
Cr-Commit-Position: refs/heads/master@{#399252}
Roll src/third_party/catapult/ 764f67b2e..01b5224b1 (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/764f67b2e490..01b5224b17c8
$ git log 764f67b2e..01b5224b1 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2059873002
Cr-Commit-Position: refs/heads/master@{#399251}
Fix the scaling problem of some "desktop" page (no viewport tag, window.innerWidth is 980)
1) What used to happen before this CL?
For some particular websites, the pages look like zoomed in compared to
Clank. Example page,
http://g1.globo.com/sao-paulo/noticia/2016/04/apos-protesto-temer-decide-deixar-sao-paulo-e-ir-para-brasilia.html.
Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=605709#c9
The page is actually a desktop page (no viewport tag, window.innerWidth is 980) in Clank. Blimp has some problem rendering such kind of pages
2) What does this CL do to make it better?
Screenshot after the fix:
https://bugs.chromium.org/p/chromium/issues/detail?id=605709#c19
BUG=605709
Globo.com page
Review-Url: https://codereview.chromium.org/2056533003
Cr-Commit-Position: refs/heads/master@{#399250}
Roll src/third_party/boringssl/src 0fc7df55c..171b5403
https://boringssl.googlesource.com/boringssl/+log/0fc7df55c04e439e765c32a4dd93e43387fe40be..171b5403ee767fa0f3aecd377867db6533c3eb8f
BUG=none
Review-Url: https://codereview.chromium.org/2050383002
Cr-Commit-Position: refs/heads/master@{#399249}
Sync vector icon list in ui/gfx/BUILD.gn.
These cause weird build issues when the list doesn't match the actual file list
processed by the script.
BUG=535386
Review-Url: https://codereview.chromium.org/2041853003
Cr-Commit-Position: refs/heads/master@{#399248}
Remove unnecessary function ChromeExtensionChooserDialog::web_contents()
It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.
BUG=613638, 577170
Review-Url: https://codereview.chromium.org/2034163002
Cr-Commit-Position: refs/heads/master@{#399247}
[Custom Tabs] Long press urlbar to copy the link to clipboard
There has been complaints about how difficult it is to copy the url to
clipboard. This CL fixes it.
BUG=610745
Review-Url: https://codereview.chromium.org/2055173002
Cr-Commit-Position: refs/heads/master@{#399246}
testharnessreport: Print test results even if a test didn't complete.
BUG=618444
Review-Url: https://codereview.chromium.org/2052643002
Cr-Commit-Position: refs/heads/master@{#399245}
Turn on the BackgroundScheduler test that was flaky, so we can
test a fix on trybots.
BUG=612325
Review-Url: https://codereview.chromium.org/2053713002
Cr-Commit-Position: refs/heads/master@{#399244}
Imposing enums for Context Menu modes
Currently many integer constants are clattered for checking
different modes. In this patch, clubbed all related integer to
an enum variable for better readabilty.
BUG=
Review-Url: https://codereview.chromium.org/2057103003
Cr-Commit-Position: refs/heads/master@{#399243}
Add |pkp_bypassed| to SSLInfo.
This is the first step in exposing in devtools when pinning is bypassed due to a local trust anchor. To correctly expose this for all socket types, |pkp_bypassed| is also exposed in a CertificateVerifyResult, and set by each socket after calling TransportSecurityState::CheckPublicKeyPins.
This also updates HttpResponseInfo to serialize the new field correctly.
BUG=566144
Review-Url: https://codereview.chromium.org/2016143002
Cr-Commit-Position: refs/heads/master@{#399242}
gn: Add chromium_builder_asan target.
All the LKGR clusterfuzz bots build this target, so add it to allow
switching these bots to gn.
BUG=618702,542853,619086
TBR=eroman
Review-Url: https://codereview.chromium.org/2059843002
Cr-Commit-Position: refs/heads/master@{#399241}
Change WebContentsDelegate::RunFileChooser to be frame based.
The file chooser code needs to be updated to support out-of-process iframes.
This CL is a required step in converting the public API to run the file
chooser based on RenderFrameHost instead of WebContents.
BUG=615575
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2059533002
Cr-Commit-Position: refs/heads/master@{#399240}
Hide hover effect on hidden ink drop host views.
BUG=584685
Review-Url: https://codereview.chromium.org/2028303004
Cr-Commit-Position: refs/heads/master@{#399239}
Remove MessageLoop::current()->RunUntilIdle() in media.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in media.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053123002
Cr-Commit-Position: refs/heads/master@{#399238}
Fix a bug that in progress notification can change when auto resumption starts
When a download is in progress, auto resumption should be an
no-op for it.
However, auto resumption changes the notification icon when started.
This CL fixes that issue.
BUG=618480
Review-Url: https://codereview.chromium.org/2053523002
Cr-Commit-Position: refs/heads/master@{#399237}
[Android] Set max line for snackbars
There can be folders with very long names. This CL prevents the entire
string from showing up in the snackbar.
BUG=618977, 618984
Review-Url: https://codereview.chromium.org/2051283003
Cr-Commit-Position: refs/heads/master@{#399236}
third_party: Update to version 3 of remote_shell_protocol.
Adds support for screen pinning.
BUG=b/27995648
TEST=trybots.
Review-Url: https://codereview.chromium.org/2058553003
Cr-Commit-Position: refs/heads/master@{#399235}
Add RunLoop::QuitWhenIdleClosure().
BUG=616447
Review-Url: https://codereview.chromium.org/2053223004
Cr-Commit-Position: refs/heads/master@{#399234}
Update webgl2 conformance test expectations.
BUG=
TEST=gpu bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2056403002
Cr-Commit-Position: refs/heads/master@{#399233}
Remove an extra Gpu interface in MusApp
Bug=None
Review-Url: https://codereview.chromium.org/2053753002
Cr-Commit-Position: refs/heads/master@{#399232}
WebGL: Three small fixes to Image CHROMIUM logic.
1. Use the newly added method DescheduleUntilFinishedCHROMIUM() to add back
pressure.
2. Update the color mask appropriately before calling clearFramebuffers().
3. Plumb gpuMemoryBufferId through to the mailbox.
BUG=611805, 617249, 607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2053983002
Cr-Commit-Position: refs/heads/master@{#399231}
Add interface to get relative bounding box rect of AX objects.
Currently accessibility bounding box rects are absolute coordinates
within their frames. This means we have to recompute the bounding box
of every AX object when part of the page scrolls or animates.
To improve efficiency, this patch adds a new interface that returns
the relative bounds of an object, consisting of three pieces:
* Its "container" (an ancestor that scrolls or has a paint layer)
* Its bounding box relative to its container
* Optionally, its matrix transform relative to its container
This patch just implements the new interface and tests it.
Adds test_runner interfaces to access this interface at a
low level (relative bounds) and high level (computed bounds)
plus interfaces for accessing the scroll position.
This will be followed up with a patch to use this interface instead
throughout the rest of Chrome, and then delete the old interface.
BUG=618120
Review-Url: https://codereview.chromium.org/2047873002
Cr-Commit-Position: refs/heads/master@{#399230}
Load web content frames in V2 app's process.
That is, --isolate-extensions is not enabled for V2 apps/platform apps.
We'd like to eventually deprecate loading web content in (highly
privileged) platform app's process. That will be tackled in
http://crbug.com/615585.
BUG=612711
Test=With --isolate-extensions. In a platform app, load an iframe to
a sandboxed local content. From the sandboxed page, load an iframe to web
content, e.g. google.com. See that the frame to google.com loads. Without
this CL, it won't load and you'd see a renderer termination message.
Review-Url: https://codereview.chromium.org/2039373002
Cr-Commit-Position: refs/heads/master@{#399229}
Avoid incorrect NC_AUTO_SUBFRAME renderer kills for non-web URLs.
There are several corner cases with in-page navigations where non-web
URLs (e.g., about:blank, file) may look cross-origin. This was
leading to renderer kills when a subframe went back/forward.
A followup CL will account for these cases more accurately, but since
this is just second line of defense against URL spoofs, we can loosen
it to only check web URLs for the time being to avoid the kills.
BUG=613732
TEST=See bug comment 10 for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2054013003
Cr-Commit-Position: refs/heads/master@{#399228}
mac/gn: Add chromium_builder_perf
BUG=431177
Review-Url: https://codereview.chromium.org/2058103002
Cr-Commit-Position: refs/heads/master@{#399227}
Remove MessageLoop::current()->RunUntilIdle() in cc.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in cc.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2056883002
Cr-Commit-Position: refs/heads/master@{#399226}
Roll src/third_party/catapult/ d0dadd6a2..764f67b2e (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d0dadd6a27a1..764f67b2e490
$ git log d0dadd6a2..764f67b2e --date=short --no-merges --format='%ad %ae %s'
BUG=619045
[email protected]
Review-Url: https://codereview.chromium.org/2052323002
Cr-Commit-Position: refs/heads/master@{#399225}
Includes GMS version in crash report.
We saw crashes happen that vary between GMS, but GMS info is not
recorded by chrome crash yet. In this cl, we will add GMS version code
to crash report.
BUG=613618
Review-Url: https://codereview.chromium.org/2014693003
Cr-Commit-Position: refs/heads/master@{#399224}
Remove credentials from URL in printed page footer
BUG=618435
Review-Url: https://codereview.chromium.org/2056203002
Cr-Commit-Position: refs/heads/master@{#399223}
GPU Watchdog to check I/O before terminating
The idea is to try to do an unbuffered write in GPU watchdog
just before crashing the process. If the process is slow due
to heavy I/O this should give it more time to unblock.
This should theoretically help with some of GPU hangs.
BUG=612607
Review-Url: https://codereview.chromium.org/1980263002
Cr-Commit-Position: refs/heads/master@{#399222}
Remove MessageLoop::current()->RunUntilIdle() in chrome.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in chrome.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053103002
Cr-Commit-Position: refs/heads/master@{#399221}
Consolidate printing OWNERS to one file.
NOTRY=true
Review-Url: https://codereview.chromium.org/2052193002
Cr-Commit-Position: refs/heads/master@{#399220}
[Sync] Status summary on main prefs should match signin prefs.
This change makes the sync status summary shown on the main
preferences screen always match the one shown on the signin
settings screen. It also tweaks one of the strings that can
be shown so it will fit better.
BUG=615571
Review-Url: https://codereview.chromium.org/2023903002
Cr-Commit-Position: refs/heads/master@{#399219}
Remove MessageLoop::current()->RunUntilIdle() in jingle.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in jingle.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053923002
Cr-Commit-Position: refs/heads/master@{#399218}
Chrome side Change for showing app info.
Add menu item "App info" for Arc app.
Add function to send the intent to android side.
BUG= b/27952403
TEST= manual Test
TEST= Update arc applist context menu unit_tests to cover new added context menu item for app info. Unit_tests passed.
Committed: https://crrev.com/e0ccdc72e078990941c67c4376029c6dc93dd7ee
Review-Url: https://codereview.chromium.org/2022663002
Cr-Original-Commit-Position: refs/heads/master@{#398953}
Cr-Commit-Position: refs/heads/master@{#399217}
Prevent crash when resize is sent to a swapped out main frame
On Mac, it is possible for the UI code to trigger a resize on a main
frame that is in the process of being navigated and has already been
swapped out. This patch prevents a renderer crash in that scenario.
BUG=612606
Review-Url: https://codereview.chromium.org/2044683002
Cr-Commit-Position: refs/heads/master@{#399216}
Move more helper methods out of CSSPropertyParser
Move more helper methods out of CSSPropertyParser, isSystemColor
and isValidNumericValue make more sense in StyleColor and
CSSParserToken respectively.
Also remove a superfluous std::isfinite check.
Review-Url: https://codereview.chromium.org/2056593005
Cr-Commit-Position: refs/heads/master@{#399215}
Implemented announcement of spelling errors on Mac.
BUG=508320
[email protected]
Review-Url: https://codereview.chromium.org/2048283002
Cr-Commit-Position: refs/heads/master@{#399214}
Replace expected pixel result for video-layer-crash.html on Mac Retina.
It looks like this was already flaky before my patch, but the rebaseline bot
had the misfortune of grabbing a bad expectation. If so, hopefully committing
the good expectation will fix things.
BUG=618693
Review-Url: https://codereview.chromium.org/2056343002
Cr-Commit-Position: refs/heads/master@{#399213}
Add UMA histograms for WebAudio.
Histograms are added to keep track of the following properties:
AudioBuffer.numberOfChannels
AudioBuffer.length
AudioBuffer.sampleRate
AudioBuffer.sampleRateRatio (buffer rate divided by context rate)
AudioContext.maxChannelCount
AudioContext.sampleRate
BiquadFilter.type
Panner.panningModel
OfflineAudioContext.channelCount
OfflineAudioContext.length
OfflineAudioContext.sampleRate
BUG=607711, 621292
TEST=manually test using chrome://histograms
Review-Url: https://codereview.chromium.org/1978403004
Cr-Commit-Position: refs/heads/master@{#399212}
Fix GN browser_tests
BUG=433082
[email protected], [email protected]
Review URL: https://codereview.chromium.org/2053153002 .
Cr-Commit-Position: refs/heads/master@{#399211}
Remove unused function rlz_lib::PingFinancialServer.
BUG=
Review-Url: https://codereview.chromium.org/2041413007
Cr-Commit-Position: refs/heads/master@{#399210}
Always post deletion of WebMediaPlayerMSCompositor.
Another speculative fix to ensure that the provider is not
deleted before the compositor is finished with it.
BUG=595980
Review-Url: https://codereview.chromium.org/2053133003
Cr-Commit-Position: refs/heads/master@{#399209}
Add additional compressed formats for Mac OS
R=vakh
BUG=600907
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2051213003
Cr-Commit-Position: refs/heads/master@{#399208}
Roll src/third_party/catapult/ e37097a1c..d0dadd6a2 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e37097a1cbf9..d0dadd6a27a1
$ git log e37097a1c..d0dadd6a2 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2052303002
Cr-Commit-Position: refs/heads/master@{#399207}
Roll src/third_party/skia/ 5dfe7bbcf..7049396b6 (4 commits).
https://chromium.googlesource.com/skia.git/+log/5dfe7bbcfda3..7049396b6566
$ git log 5dfe7bbcf..7049396b6 --date=short --no-merges --format='%ad %ae %s'
2016-06-10 bsalomon Make GrShape capable of representing inverse filled rrects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056523002
2016-06-10 caryclark add fail condition to addexpanded
2016-06-10 djsollen Cleanup VulkanWindowContext for use on Android GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058763002
2016-06-10 bsalomon Add blurcircles to blacklist for macmini4.1
BUG=618991
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2058793002
Cr-Commit-Position: refs/heads/master@{#399206}
[chromedriver] Disable alert tests on Chrome 52
BUG=
Review-Url: https://codereview.chromium.org/2051443005
Cr-Commit-Position: refs/heads/master@{#399205}
hook up background task's "startProcessing" from Java to request_coordinator
BUG=612325
Review-Url: https://codereview.chromium.org/2054913002
Cr-Commit-Position: refs/heads/master@{#399204}
Fix cr_cronet.py APK install when custom build directory is used
BUG=600857
Review-Url: https://codereview.chromium.org/2013073002
Cr-Commit-Position: refs/heads/master@{#399203}
[NTP Snippets] Show a status card when there are no available snippets
Introduce a new NTP item type type: Status cards! They show up when
there are no snippets to display and let the user know that the NTP
is not broken. The current one simply acknowledges that we ran out
of snippets and allows to manually fetch more.
This CL also refactors some basic card features out of Snippet specific
classes.
Known issues that will be addressed in future CLs:
- Show a different message if the service can't fetch snippets but the
user can fix it, for example by enabling sync.
- The card should be animated as coming from below
BUG=612508
Review-Url: https://codereview.chromium.org/2024933002
Cr-Commit-Position: refs/heads/master@{#399202}
Disable iframe-upgrade-csp.https.html on Site Isolation FYI bots.
BUG=611154
NOTRY=true
Review-Url: https://codereview.chromium.org/2052313002
Cr-Commit-Position: refs/heads/master@{#399201}
Revert "Fixed first step of scrolling not applying"
This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.
This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.
BUG=609748,593453
Review-Url: https://codereview.chromium.org/2055913002
Cr-Commit-Position: refs/heads/master@{#399200}
[Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element.
Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site setting.
Check the setting before allowing muted videos to autoplay.
BUG=618083,618081
TEST=Manual
Review-Url: https://codereview.chromium.org/2052623002
Cr-Commit-Position: refs/heads/master@{#399199}
Improve NetLog logging in net::BidirectionalStream
This CL adds three additional events to
net::BidirectionalStream to log when buffers are coalesced,
when stream is ready, and when stream is failed.
BUG=617698
Review-Url: https://codereview.chromium.org/2044583002
Cr-Commit-Position: refs/heads/master@{#399198}
Remove MessageLoop::current()->RunUntilIdle() in net.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in net.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053133002
Cr-Commit-Position: refs/heads/master@{#399197}
Consolidate media_galleries OWNERS to one file.
NOTRY=true
Review-Url: https://codereview.chromium.org/2054033002
Cr-Commit-Position: refs/heads/master@{#399196}
Remove MessageLoop::current()->RunUntilIdle() in ash.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in ash.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2051283002
Cr-Commit-Position: refs/heads/master@{#399195}
Remove MessageLoop::current()->RunUntilIdle() in content.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in content.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2056893002
Cr-Commit-Position: refs/heads/master@{#399194}
Change FileMetricsProvider to merge into StatisticsRecorder.
Also enable the "active file" mode now that read/write mapped files are available.
BUG=546019
Review-Url: https://codereview.chromium.org/2046083002
Cr-Commit-Position: refs/heads/master@{#399193}
cc: Remove scheduling estimate UMAs
These do not need long term monitoring.
BUG=603202
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2056663003
Cr-Commit-Position: refs/heads/master@{#399192}
Consolidate pdf OWNERS to one file.
NOTRY=true
Review-Url: https://codereview.chromium.org/2058543003
Cr-Commit-Position: refs/heads/master@{#399191}
Move GLSurface creation from //ui/gl to //ui/gl/init.
Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.
Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.
There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.
These is almost the last part of step 2 in the associated bug. There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.
BUG=611142
Review-Url: https://codereview.chromium.org/2047283003
Cr-Commit-Position: refs/heads/master@{#399190}
Revert of Attempt to deflake video-layer-crash.html. (patchset #1 id:1 of https://codereview.chromium.org/2053793002/ )
Reason for revert:
Didn't deflake -- and there should be a synchronous layout/paint before pixel dump anyhow.
Original issue's description:
> Attempt to deflake video-layer-crash.html.
>
> This makes the test wait for layout and paint, instead of finishing the test as
> soon as the seeked event is seen. Currently the Retina bot flakily produces the
> frame previous to the one that is expected.
>
> BUG=618693
>
> Committed: https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63
> Cr-Commit-Position: refs/heads/master@{#399010}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618693
Review-Url: https://codereview.chromium.org/2057193002
Cr-Commit-Position: refs/heads/master@{#399189}
Update V8 to version 5.3.205.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3a590058..5755d7ee
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2057793004
Cr-Commit-Position: refs/heads/master@{#399188}
Remove BOM characters <U+FEFF>
They breaks page display on iOs UIWebView.
I think they were added accidental.
Was introduced in https://codereview.chromium.org/1820523002
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2057183002
Cr-Commit-Position: refs/heads/master@{#399187}
[PCv2] Add tracing category needed for computing ttfmp
The time-to-first-meaningful-paint computation requires extra tracing categories to be enabled.
This CL enables recording of the category in PCv2.
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/system_health/first_paint_metric.html
BUG=None
Review-Url: https://codereview.chromium.org/2049593002
Cr-Commit-Position: refs/heads/master@{#399186}
[ios Mojo] Cleaned up Mojo WebUI test.
BUG=567809
Review-Url: https://codereview.chromium.org/2059463002
Cr-Commit-Position: refs/heads/master@{#399185}
Worker: Rename WorkerThreadContext to WorkerThreadLifecycleContext
WorkerThreadContext was too generic name. You can see the context of this change
here:
https://codereview.chromium.org/2025783002/diff/320001/third_party/WebKit/Source/core/workers/WorkerThread.h#newcode61
BUG=575532
Review-Url: https://codereview.chromium.org/2052183002
Cr-Commit-Position: refs/heads/master@{#399184}
Auto-rebaseline for r399167
https://chromium.googlesource.com/chromium/src/+/2127dca0a
BUG=617404
[email protected]
Review URL: https://codereview.chromium.org/2057063003 .
Cr-Commit-Position: refs/heads/master@{#399183}
Update Fieldtrial testing config for NTPPopularSites
BUG=none
Review-Url: https://codereview.chromium.org/2057793003
Cr-Commit-Position: refs/heads/master@{#399182}
Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator.
The callback object that the CanvasAsyncBlobCreator passes along to a
background thread can be kept as a simple Member<>; no need to
involve CrossThreadPersistent<> and risk inadvertently introducing
leaks.
R=
BUG=
Review-Url: https://codereview.chromium.org/2051993002
Cr-Commit-Position: refs/heads/master@{#399181}
Roll src/third_party/catapult/ 2c5cde737..e37097a1c (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2c5cde737888..e37097a1cbf9
$ git log 2c5cde737..e37097a1c --date=short --no-merges --format='%ad %ae %s'
BUG=616483,612779
[email protected]
Review-Url: https://codereview.chromium.org/2058073002
Cr-Commit-Position: refs/heads/master@{#399180}
Implement the Sync promo in the password bubble on Mac.
BUG=615825
Review-Url: https://codereview.chromium.org/2040143006
Cr-Commit-Position: refs/heads/master@{#399179}
tools/android/loading Reduce taskqueue access rate.
This CL increases the number of URLs per ClovisTask, making them longer
to process, and thus reducing the rate at which workers pull tasks from
the queue.
Review-Url: https://codereview.chromium.org/2059683002
Cr-Commit-Position: refs/heads/master@{#399178}
Roll src/third_party/skia/ 4772bd537..5dfe7bbcf (1 commit).
https://chromium.googlesource.com/skia.git/+log/4772bd537d15..5dfe7bbcfda3
$ git log 4772bd537..5dfe7bbcf --date=short --no-merges --format='%ad %ae %s'
2016-06-10 egdaniel Define LEAN_AND_MEAN and NOMINMAX for all windows builds
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2054103002
Cr-Commit-Position: refs/heads/master@{#399177}
clovis: Allow customization of the output table name in the report generation.
Review-Url: https://codereview.chromium.org/2057073002
Cr-Commit-Position: refs/heads/master@{#399176}
tools/android/loading Move task creation to background and add dashboard
This CL moves the tasks creation to the background queue,
to avoid AppEngine timeouts.
It also adds a way to list the current jobs and track them.
The list of jobs is persisted in the datastore.
There is more work to be done in follow up CLs:
- improving the UI for the job dashboard
- possibly replacing the per-job polling by a global
polling that would poll all active jobs at once, in order
to simplify the code.
Review-Url: https://codereview.chromium.org/2041193008
Cr-Commit-Position: refs/heads/master@{#399175}
Pause autoplay muted video when unmuting if there's no user gesture
BUG=617598
TEST=https://avayvod.github.io/autoplay-test.html
Review-Url: https://codereview.chromium.org/2047333002
Cr-Commit-Position: refs/heads/master@{#399174}
Disable tests blink LayoutTests
[ Win ] fast/repaint/window-resize-centered-inline-under-fixed-pos.html
[ Win ] fast/repaint/window-resize-vertical-writing-mode.html
[ Mac Win ] fast/repaint/window-resize-background-image-non-fixed.html
BUG=600008
[email protected]
Review URL: https://codereview.chromium.org/2058743002 .
Cr-Commit-Position: refs/heads/master@{#399173}
Adding option for Proguard jar to be switched.
Additionally, adds the is_java_debug gn arg, which can now be set
separately from is_debug, which will control Java specific debug
features, such as Proguard, multidexing, and incremental dexing.
BUG=616831,615082,615083
Review-Url: https://codereview.chromium.org/2031033002
Cr-Commit-Position: refs/heads/master@{#399172}
Introduce CustomElementRegistry#whenDefined() method
This patch introduces |CustomElementRegistry#whenDefined()| as specified in [1],
and makes |CustomElementRegistry::define()| to resolve a promise associated to
newly defined name.
[1] // https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregistry-whendefined
BUG=594918
TEST=LayoutTests/custom-elements/spec/custom-elements-registry/when_defined.html
Review-Url: https://codereview.chromium.org/2048343002
Cr-Commit-Position: refs/heads/master@{#399171}
[Layout API] Use document::layoutViewItem() in WebDocument
As this is passing a reference to the accessibility cache (which has
not been converted to use the block layout API), we need to use the
API shim to get a reference to the underlying layout view.
BUG=499321
Review-Url: https://codereview.chromium.org/2057573002
Cr-Commit-Position: refs/heads/master@{#399170}
MD User Manager: Overhaul Urls
1. Uses relative Urls for the user manager resources.
2. Inlines css for user_manager.html.
2. Only flattens files that need to be flattened.
3. Fixes iron-flex-layout warnings.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2053723002
Cr-Commit-Position: refs/heads/master@{#399169}
Update V8 to version 5.3.204.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f90931d0..3a590058
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2058723002
Cr-Commit-Position: refs/heads/master@{#399168}
Update document marker rects lazily in frame
Updating document marker rects in a layout can be slow when there are many markers.
This defers the document marker update to FrameView::invalidateTreeIfNeeded.
BUG=617404
Review-Url: https://codereview.chromium.org/2034363002
Cr-Commit-Position: refs/heads/master@{#399167}
[Mac/GN] Write PkgInfo files for .app bundles.
BUG=431177
[email protected]
Review-Url: https://codereview.chromium.org/2055933002
Cr-Commit-Position: refs/heads/master@{#399166}
Quick View: Space key opens quick view for image, video and audio in Download.
--disable-files-quick-view disables quick view.
Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbkw5UW5GVGNDLXc/view?pli=1
BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
Review-Url: https://codereview.chromium.org/2043333002
Cr-Commit-Position: refs/heads/master@{#399165}
Revert of Address a crash under -[NSWindow close] via a WeakPtr PostTask from Browser::TabStripEmpty() (patchset #6 id:100001 of https://codereview.chromium.org/2041213002/ )
Reason for revert:
Fix didn't work.
Original issue's description:
> Address a crash under -[NSWindow close] via a WeakPtr PostTask from Browser::TabStripEmpty()
>
> This is the #1 browser crash for Mac in current Beta - 52.0.2743.24. The
> stacks all have in common a Posted Task that's triggering -[NSWindow
> close] via a base::WeakPtr<Browser>. This only happens via
> Browser::TabStripEmpty().
>
> The WeakPtr is only nerfed when BrowserWindowController's dealloc fully
> completes. It seems plausible that this can be after the NSWindow's
> dealloc fully completes, leading to an invalid access. One would hope
> that [NSWindowController window] returns nil once the controlled window
> is destroyed, but this seems to not be guaranteed.
>
> To (speculatively) fix, set a flag when the controlled window invokes
> -[NSWindowController windowWillClose]. The window shouldn't be accessed
> after this. Ensure the C++ BrowserWindowCocoa shim returns nil in this
> case for the window, even if -[NSWindowController window] doesn't.
>
> See http://crbug.com/616701
>
> Committed: https://crrev.com/7e91932ca0df94f1d3ebe9303e6ff31637751c17
> Cr-Commit-Position: refs/heads/master@{#398474}
# Not skipping CQ checks because original CL landed more than 1 days ago.
See http://crbug.com/616701
Review-Url: https://codereview.chromium.org/2042123005
Cr-Commit-Position: refs/heads/master@{#399164}
Remove MessageLoop::current()->RunUntilIdle() in ios.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in ios.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2052073002
Cr-Commit-Position: refs/heads/master@{#399163}
Roll src/third_party/skia/ 739bbb2da..4772bd537 (1 commit).
https://chromium.googlesource.com/skia.git/+log/739bbb2dadbb..4772bd537d15
$ git log 739bbb2da..4772bd537 --date=short --no-merges --format='%ad %ae %s'
2016-06-10 bungeman Implement all onCreateFromStream overloads.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2052223002
Cr-Commit-Position: refs/heads/master@{#399162}
clovis: Fix report generation for queuing-related metrics.
Patch from mattcary@.
Review-Url: https://codereview.chromium.org/2054063002
Cr-Commit-Position: refs/heads/master@{#399161}
Moves Blink mixed content enums and helper methods to public.
To allow the sharing of data and helper functions related to mixed content
between the renderer and the browser. This is in preparation to the moving
of the mixed content checks logic to the browser for navigation loads.
BUG=576270
Review-Url: https://codereview.chromium.org/2050553003
Cr-Commit-Position: refs/heads/master@{#399160}
[Layout API] Use Document::layoutViewItem in WebPagePopupImpl
As this is passing a reference to the accessibility module (which has
not be converted to the block layout API), we need to use the layout
API shim to get the underlying layout view.
BUG=499321
Review-Url: https://codereview.chromium.org/2050693003
Cr-Commit-Position: refs/heads/master@{#399159}
Update V8 to version 5.3.202.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9956186f..f90931d0
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2051413002
Cr-Commit-Position: refs/heads/master@{#399158}
Revert "Parse PopularSites JSON on iOS too."
This reverts commit e4eb2a57c8667ab31903237e3c316fcaf4afe718. We'll
switch to a callback after the move.
BUG=603026
Review-Url: https://codereview.chromium.org/2052213002
Cr-Commit-Position: refs/heads/master@{#399157}
Make ready to unprefix getUserMedia, and counters
This CL adds an unprefixed getUserMedia on navigator,
behind the same flag as the promise-based getUserMedia.
It also counts all three variants.
BUG=607439
Review-Url: https://codereview.chromium.org/2045193003
Cr-Commit-Position: refs/heads/master@{#399156}
Fix VulkanOutputSurface build error
Previous OutputSurface refactor did not consider VulkanOutputSurface.
This patch makes it refer to the right OutputSurface constructor.
BUG=582558
Review-Url: https://codereview.chromium.org/2027103002
Cr-Commit-Position: refs/heads/master@{#399155}
Roll WebRTC 13089:13098
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cb6b288..456c3c7
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2054083002
Cr-Commit-Position: refs/heads/master@{#399154}
Add mojo::SharedBufferHandle::Create().
Previously, the high-level API for creating mojo shared buffers DCHECKs
that creation succeeds; this is not a useful check. This adds a simpler
Create that reports failure.
Review-Url: https://codereview.chromium.org/2058633003
Cr-Commit-Position: refs/heads/master@{#399153}
Disable blink layout tests related to crbug/254639 +
crbug.com/254639 css3/filters/effect-brightness-hw.html [ Failure Pass ]
crbug.com/254639 css3/filters/effect-hue-rotate-hw.html [ Failure Pass ]
[email protected]
BUG=254639
Review URL: https://codereview.chromium.org/2059723002 .
Cr-Commit-Position: refs/heads/master@{#399152}
[bgmode] Make push notifications register KeepAlives
Based on https://codereview.chromium.org/1849153003/
that was reverted in https://codereview.chromium.org/2020563003/
Original issue's description:
> A KeepAlive is now registered in the following cases:
> a) There is an in-flight push message
> b) A Notification is being shown by the message center
>
> That will happen on all platforms supporting Chrome's
> background mode.
Added:
- Close all the notifications when explicit Exit is clicked
- Make sure the browser is not killed in between the moment a
notification is closed and the result of the user's interaction
is obtained.
BUG=585080
Review-Url: https://codereview.chromium.org/2028673002
Cr-Commit-Position: refs/heads/master@{#399151}
Make flat tree version RenderedPosition constructor to work on flat tree
This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.
Before this patch, flat tree version of |RenderedPosition| constructor uses
|toPositionInDOMTree()|, but id doesn't work well for children of shadow
root and insertion point, e.g. CONENT elements and SLOT elements.
In attached layout test, |RenderedPosition| constructor attempts to compute
for CONTENT element in DETAIL element.
BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html
Review-Url: https://codereview.chromium.org/2059663002
Cr-Commit-Position: refs/heads/master@{#399150}
Delete references to obsolete webrtc header files.
BUG=
Review-Url: https://codereview.chromium.org/2054763002
Cr-Commit-Position: refs/heads/master@{#399149}
Fetch missing favicons for NTP snippets from a Google favicon service.
Previously, favicons for NTP snippets were obtained only from the local
chrome favicon cache. If there was no favicon (the user has not visited
the page on mobile, yet), a default favicon was displayed.
This CL adds experimental support for fetching such missing favicons
from https://s2.googleusercontent.com/s2/favicons. The purpose of the
CL is to test out the quality of favicons provided by the service. If
the quality turns out to be good enough, the whole code for fetching
favicons will be moved into a C++ service.
BUG=611007
Review-Url: https://codereview.chromium.org/2036663002
Cr-Commit-Position: refs/heads/master@{#399148}
Update V8 to version 5.3.201.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ca21f805..9956186f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2051393002
Cr-Commit-Position: refs/heads/master@{#399147}
clovis: Report the total request count.
Review-Url: https://codereview.chromium.org/2051333003
Cr-Commit-Position: refs/heads/master@{#399146}
Site Settings Desktop: Change how adding site exceptions work.
Instead of the whitelist model, move to one that allows adding either
Block/Allow entries. This requires the category heading to be always
shown, because otherwise there's no context. This CL also adds support
for Enter (to submit) in the dialog.
BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2044963003
Cr-Commit-Position: refs/heads/master@{#399145}
Clamp filter functions {grayscale, invert, opacity, sepia} to 100%
The spec says the following for these functions:
"Values of amount over 100% are allowed but UAs must clamp the values
to 1."
So do that rather than failing. This matches the behavior of Gecko and
Edge.
This fixes
http://test.csswg.org/suites/filters-1_dev/nightly-unstable/html/filter-grayscale-005.htm
from the CSS WG Filter Effects testsuite (w/ the property unprefixed.)
BUG=618607
Review-Url: https://codereview.chromium.org/2052883002
Cr-Commit-Position: refs/heads/master@{#399144}
Remove MessageLoop::current()->RunUntilIdle() in headless.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in headless.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2052063002
Cr-Commit-Position: refs/heads/master@{#399143}
Move insecure content signal logic into common ssl_insecure_content.
Moves some histogram reporting of insecure content being diplayed or run
into a new ssl_insecure_content file living in the chrome/common. This
functionality will later be called from the browser process once mixed
content checks are executed there (see ChromeContentBrowserClient changes in
http://crrev.com/1905033002).
BUG=576270
Review-Url: https://codereview.chromium.org/2045253002
Cr-Commit-Position: refs/heads/master@{#399142}
Trace ScriptWrappableVisitor.m_markingDeque by oilpan gc
This cl has two parts:
1. Make ScriptWrappableVisitor.m_markingDeque part of the root set for the
oilpan gc so wrapper marked objects will not be collected.
Without this cl, v8 can detect wrapper during incremental marking, but the v8
scavenger is free to collect the wrapper. Subsequent oilpan gc will collect
ScriptWrappable and recorded internal fields of v8 wrapper are no longer valid.
With this cl, oilpan will not collect ScriptWrappables if they are in the
marking deque. Other slightly more complicated approach would be to cleanup the
marking deque after oilpan gc and remove dead objects.
2. Add freshly associated wrappers to the ScriptWrappableVisitor.m_markingDeque
to ensure they will be processed when black allocation in v8 is on.
When black allcation is on, v8 creates new objects black, and completely skips
any processing, including wrapper detection. Such object would be undetected and
not traced at all. Because of that, on all wrapper associations (which
happen shortly after creation) we put objects into the marking deque. This way
we make sure the object will be traced.
LOG=no
BUG=468240
Review-Url: https://codereview.chromium.org/2043033002
Cr-Commit-Position: refs/heads/master@{#399141}
Set the Accept-Language header in Physical Web requests
The Physical Web service now supports locale-specific
metadata caching. To receive metadata specific to the
user's locale, attach the language code for the current
system locale to the metadata request.
BUG=607660
Review-Url: https://codereview.chromium.org/2042863002
Cr-Commit-Position: refs/heads/master@{#399140}
[webnfc] Implement push() method in blink nfc module.
This patch implements nfc.push() and nfc.cancelPush() methods in nfc module.
https://w3c.github.io/web-nfc/#dom-nfc-push
https://w3c.github.io/web-nfc/#dom-nfc-cancelpush
Mock mojo service and simple layout test is added to validate input parameters
as well as conversion between WebNFC and corresponding mojo data structures.
BUG=520391
Committed: https://crrev.com/5058e32db5582978f60a28bc0ccbeed0a7421283
Review-Url: https://codereview.chromium.org/1708543002
Cr-Original-Commit-Position: refs/heads/master@{#398538}
Cr-Commit-Position: refs/heads/master@{#399139}
Update V8 to version 5.3.200.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1ba6f6ac..ca21f805
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2057993002
Cr-Commit-Position: refs/heads/master@{#399138}
[Chromecast] Add alsa-enable-up-sampling switch to audio products.
Make resampling cutoff optional so OEMs can disable resampling
to reduce CPU load.
BUG=internal b/28110563
TEST=Tested on pepperoni and rpi, sample rate cutoff frequency is set
correctly on both.
Review-Url: https://codereview.chromium.org/2054533002
Cr-Commit-Position: refs/heads/master@{#399137}
Clean up script-tests in css3/filters
Rewrite the parsing tests using
css-parser/resources/property-parsing-test.js and also use testharness
for the computed style test.
Drop css3/filters/filter-property.html since that is already covered by
the wider parsing tests. Also remove the template html file and inline
the scripts for effect-reference-reset-style-delete-crash.html [1] and
effect-reference-delete-crash.html, clearing out the script-tests sub-
directory.
[1] This test was actually referencing the
effect-reference-delete-crash.js file, meaning it was a duplicate.
BUG=618607
Review-Url: https://codereview.chromium.org/2055733002
Cr-Commit-Position: refs/heads/master@{#399136}
Mac fullscreen low power: Add unittests
Fix a bug in ChildWindowsChanged, discovered by those tests.
Move command line check to controller, to make unittests work.
Don't allow entering low power mode until the fullscreen low power
layer has been valid for 15 frames. This ensures that we won't get
flashes of invalid content.
BUG=616364
Review-Url: https://codereview.chromium.org/2047103003
Cr-Commit-Position: refs/heads/master@{#399135}
Roll src/native_client/ f9308087f..5152c12c4 (1 commit).
https://chromium.googlesource.com/native_client/src/native_client.git/+log/f9308087f764..5152c12c4477
$ git log f9308087f..5152c12c4 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 dpranke Fix NaCL executable linkages under ASAN.
BUG=618450
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
[email protected]
Review-Url: https://codereview.chromium.org/2052203002
Cr-Commit-Position: refs/heads/master@{#399134}
MD History: Deselect items when clicking 'More from this site'
Previously, it was possible to select an item and perform a domain
search. This would still show '1 selected' in the toolbar, even though
none of the new search results were selected.
BUG=618244
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2053553002
Cr-Commit-Position: refs/heads/master@{#399133}
Use ApplicationsSize in storage_manager.mojom
This CL replaces three uint64s to ApplicationsSize struct, suggested by
the reviewer of the previous CL.
https://codereview.chromium.org/2035793005/
Since there is no client of this API so far, it is safe to change Mojo
signature without changing a version of RPC definition.
BUG=611651
BUG=b/27601511
Review-Url: https://codereview.chromium.org/2051023002
Cr-Commit-Position: refs/heads/master@{#399132}
DevTools: Add grouping by Activity to Timeline treeview.
Allows a user to compare time spent in Painting vs Image Decode, etc.
BUG=614935
Review-Url: https://codereview.chromium.org/2010943002
Cr-Commit-Position: refs/heads/master@{#399131}
[css-grid] Avoid unneeded calls to percentageLogicalHeightIsResolvable()
r398535 was introducing a performance regression on grid layout tests.
The problem is that it was calling LayoutGrid::hasDefiniteLogicalSize()
which was very slow.
r398680 was getting rid of hasDefiniteLogicalSize() and replacing it
by calls to LayoutBox::percentageLogicalHeightIsResolvable().
Despite being faster it's still an expensive operation and
we don't need to do it always.
So in this patch we're avoid calling percentageLogicalHeightIsResolvable()
when the min and max track breadths are not percentages.
BUG=618664,616716
Review-Url: https://codereview.chromium.org/2051953002
Cr-Commit-Position: refs/heads/master@{#399130}
Revert of Reland: Make media/capture gn and gyps produce components (patchset #3 id:60001 of https://codereview.chromium.org/2058553002/ )
Reason for revert:
Breaks windows compilation (see crbug.com/518807#c33)
Original issue's description:
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
> Committed: https://crrev.com/f4683c359791bb0264cddddeca6b8bcae0e61817
> Cr-Commit-Position: refs/heads/master@{#399024}
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> [email protected], [email protected], [email protected]
> (since the PS2 is trivial, just making explicit libs that are
> already in media/base/mac - I wonder why it didn't fail in
> the bots).
>
> Committed: https://crrev.com/2e0d97f84bd502e356b46031422a0db91dcbf1f1
> Cr-Commit-Position: refs/heads/master@{#399115}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807
Review-Url: https://codereview.chromium.org/2056193002
Cr-Commit-Position: refs/heads/master@{#399129}
Remove DeferredImageDecoder::setEnabled and ImageDecoder::deferredImageDecodingEnabled
DeferredImageDecoder::setEnabled is used only at BitmapImageTest and not
used in non-test code. ImageDecoder::deferredImageDecodingEnabled is not
called anywhere. This CL removes those functions for code health.
BUG=n/a
TEST=blink_platform_unittests --gtest_filter=BitmapImageTest.*:ImageDecoderTest.* ; webkit_unit_tests --gtest_filter=DeferredImageDecoderTest.*
Review-Url: https://codereview.chromium.org/2048003002
Cr-Commit-Position: refs/heads/master@{#399128}
Rewrite and organize tests in LayoutTests/shadow-dom
To separate our concerns, move some tests to LayoutTests/shadow-dom/v0 directory if
they are also testing v0 features for compatibility reasons.
In summary:
- LayoutTests/shadow-dom/
Used for tests if they are testing only v1 features
- LayoutTests/shadow-dom/v0/
Used for tests if they are also testing v0 featuers
Clean up is not finished. Other clean up CLs will come later.
BUG=531990
Review-Url: https://codereview.chromium.org/2051373002
Cr-Commit-Position: refs/heads/master@{#399127}
Fix data race in blink::ThreadHeap::detach
BUG=618504
Review-Url: https://codereview.chromium.org/2051053002
Cr-Commit-Position: refs/heads/master@{#399126}
Remove unnecessary use of CrossThreadPersistent<>.
The CompositorMutatorImpl object that WebFrameWidgetImpl creates and
controls the lifetime of, should be referenced as a normal Member<>
R=
BUG=
Review-Url: https://codereview.chromium.org/2056833003
Cr-Commit-Position: refs/heads/master@{#399125}
minimized browser window avoid showing global-error extension bubble view
Bug happens when extension will show new error bubble view and browser is minimized.
BUG=600009
TEST=manually test seeing bug is away
Review-Url: https://codereview.chromium.org/2058583002
Cr-Commit-Position: refs/heads/master@{#399124}
Make CanvasRenderingContext2DState store a const CSSValue
Make CanvasRenderingContext2DState store a Member<const CSSValue>
instead of non-const. This is an entirely mechanical change that is
pre-work for making CSSPropertyParser::parseSingleValue return a const
CSSValue*.
[email protected]
BUG=526586
Review-Url: https://codereview.chromium.org/2041703002
Cr-Commit-Position: refs/heads/master@{#399123}
Naming cleanup in Safe Browsing browser tests.
BUG=NONE
[email protected]
Review-Url: https://codereview.chromium.org/2057463002
Cr-Commit-Position: refs/heads/master@{#399122}
Roll PDFium 9e077d2..855665d
https://pdfium.googlesource.com/pdfium.git/+log/9e077d2..855665d
BUG=616339,618164
TEST=bots
[email protected]
Review-Url: https://codereview.chromium.org/2056163002
Cr-Commit-Position: refs/heads/master@{#399121}
Move WebVR feature out of experimental (to off-by-default).
Otherwise, whenever experimental web platform features are on, VRController
will boot up and try to connect to device::VRService, which simply doesn't
exist unless --enable-webvr is set.
Since --enable-webvr enables the corresponding runtime-enabled feature
already, this shouldn't break WebVR in any case where it previously worked.
However, it does prevent users that enable experimental features (notably,
layout tests) from having spurious messages about VRService failing to connect.
Review-Url: https://codereview.chromium.org/2055943002
Cr-Commit-Position: refs/heads/master@{#399120}
Update V8 to version 5.3.199.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/05f552d9..1ba6f6ac
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2056143002
Cr-Commit-Position: refs/heads/master@{#399119}
Convert track-webvtt-tc[022, 023] tests to testharness.js
Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2050213003
Cr-Commit-Position: refs/heads/master@{#399118}
Roll src/third_party/skia/ c9b4ccd77..739bbb2da (1 commit).
https://chromium.googlesource.com/skia.git/+log/c9b4ccd77100..739bbb2dadbb
$ git log c9b4ccd77..739bbb2da --date=short --no-merges --format='%ad %ae %s'
2016-06-09 csmartdalton Fix glDraw*Indirect prototypes
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2057003002
Cr-Commit-Position: refs/heads/master@{#399117}
Made CSSImageValue::reResolveURL() const
Made CSSImageValue::reResolveURL() a const method, and made all cache-
related members of CSSImageValue mutable. This is an entirely mechanical
change that is pre-work for removing the PropertyReference::value()
method that returns a non-const CSSValue*.
BUG=526586
Review-Url: https://codereview.chromium.org/2045083002
Cr-Commit-Position: refs/heads/master@{#399116}
Reland: Make media/capture gn and gyps produce components
Which got reverted due to a Mac build breakage (see
https://codereview.chromium.org/2059493002/) and
a Win one (https://crbug.com/618854).
Original description ---------------------------------------------------
Make media/capture gn and gyps produce components
This CL separates media/capture into a component,
to allow, in a subsequent CL, linking with mojo for using
ImageCapture types.
This basically reproduces the media/cast and media/midi
structure.
Windows import/export issues made necessary to add
capture_export and associated CAPTURE_EXPORT macro,
again, replicating media/midi.
gn gen ... --check uncovered some transitive dependencies
during the "analyze" phase of the bots and I had to make
them explicit (e.g. media:gpu).
BUG=518807
Committed: https://crrev.com/f4683c359791bb0264cddddeca6b8bcae0e61817
Cr-Commit-Position: refs/heads/master@{#399024}
-----------------------------------------------------------------------
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
[email protected], [email protected], [email protected]
(since the PS2 is trivial, just making explicit libs that are
already in media/base/mac - I wonder why it didn't fail in
the bots).
Review-Url: https://codereview.chromium.org/2058553002
Cr-Commit-Position: refs/heads/master@{#399115}
Add heuristics to limit showing of new backspace UI bubble.
This restricts the bubble to showing 5 times, and only showing when users
trigger backspace twice within three seconds (which likely indicates "hey, why
isn't the browser going back").
The bubble is also immediately hidden (by fading out) if the user successfully
navigates back or forward (by any means) while it's showing.
BUG=610039,615760
TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds. After the UI is shown 5 times, it should not appear again.
TBR=phajdan.jr
Review-Url: https://codereview.chromium.org/2041293002
Cr-Commit-Position: refs/heads/master@{#399114}
Remove mojo_system_unittests DrMemory exclusions
One of the tests no longer exists and the other two no longer
need to be excluded.
BUG=464019,440828,372452
[email protected]
Review-Url: https://codereview.chromium.org/2055183002
Cr-Commit-Position: refs/heads/master@{#399113}
Roll src/third_party/chromite/ 64e8b9a60..7b5c1d361 (88 commits).
https://chromium.googlesource.com/chromiumos/chromite.git/+log/64e8b9a603e4..7b5c1d36149b
$ git log 64e8b9a60..7b5c1d361 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 dgarrett cros stats, cros uprevchrome: Only import cidb when needed.
2016-06-08 ameyd cbuildbot: do not produce lakitu factory_install image
2016-06-07 dgarrett build_time_stats: Move script to "cros stats".
2016-05-24 llozano chromite: Fix some issues with the GN support.
2016-06-08 akeshet chromeos_config: temporarily mark cheets paladins important=False
2016-06-08 elijahtaylor Revert "Switch Android PFQ to user builds"
2016-06-07 elijahtaylor Switch Android PFQ to user builds
2016-06-08 akeshet validiation_pool: log leader change when attempting transaction
2016-06-06 ameyd cbuildbot: add lakitu and lakitu_next to nofactory_boards list
2016-06-06 dgarrett chromeos_config: Add unimportant_boards argument.
2016-06-06 akeshet test_stages_unittest: delete obsolete test
2016-06-06 dhaddock cheets: Create an elm-cheets paladin.
2016-06-06 bhthompson Disable old builds for various unused builds
2016-06-03 akeshet chromeos_config: run bvt-inline asynchronously on release branches
2016-06-02 nxia misc fix in cros_uprevchrome
2016-06-03 bhthompson cros uprevchrome: adjust help message
2016-06-03 dgarrett sync_stages: Switch self.options -> self._run.options.
2016-06-03 dgarrett Revert "Revert "paygen_build_lib: Remove support for NPO images.""
2016-06-03 dgarrett Revert "paygen_build_lib: Remove support for NPO images."
2016-06-02 nxia Remove variant_boards concept in leader/follower release configs.
2016-05-27 dgarrett cbuildbot: Add --repo-cache option.
2016-05-31 akeshet chromeos_config: make aosp/ projects branchable
2016-06-02 akeshet Revert "generic_stages: temporarily ignore all target prebuilts."
2016-05-20 dgarrett paygen_build_lib: Remove support for NPO images.
2016-06-02 briannorris cros flash: print out board properly on error
2016-06-02 briannorris cros deploy: print out board properly on error
2016-05-26 joth Mark veyron_rialto-paladin as important
2016-06-01 akeshet binhost_test: add veyron_rialto to the no-chromium whitelist
2016-06-01 akeshet binhost_test: clarify the skipconfigs message
2016-06-01 dgarrett sync_chrome: Clobber/retry on sync failure.
2016-06-01 cmtice generic_stages: temporarily ignore all target prebuilts.
2016-06-01 dgarrett Revert "commands: upload_symbols with --dedupe"
2016-05-31 dgarrett validation_pool: PrintLinksToChanges handle a null owner_email.
2016-05-27 hidehiko Roll sdk tools.
2016-05-25 kevcheng guado_moblab: Re-enable hwtests for paladins
2016-05-27 akeshet validation_pool: clearer logging for ineligible changes
2016-05-26 dgarrett chromeos_config: Remove two (unused) group configs.
2016-05-27 jrbarnette Revert "chromeos_config: Enable siging/paygen for beaglebone."
2016-05-27 nxia Mark stages as skipped if WaitUntilReady returns False.
2016-05-19 nxia Verify stage status from CIDB for results_lib.Result.
2016-05-26 akeshet sync_stages: add some logging to pre-cq launcher
2016-05-25 dgarrett chromeos_config: Enable siging/paygen for beaglebone.
2016-05-20 xixuan chromite: not use signal when it's not in the main thread.
2016-05-24 nxia Raise ExitEarlyException instead of SystemExit
2016-05-24 cmtice [cbuildbot] Add toolchain waterfall buildbot for next llvm.
2016-05-24 dnj Waterfall layout dump shows buildslave type.
2016-05-20 bhthompson Make more auron boards important
2016-05-24 stevenjb Configure cheets informational builders to only run arc-bvt-cq HWTests
2016-05-23 akeshet summarize_build_stats: add an --ending-build argument
2016-05-18 dgarrett commands: upload_symbols with --dedupe
2016-05-24 cmtice [cbuildbot] Increase timeout for toolchain waterfall bots.
2016-05-23 dgarrett chromeos_config: Preserve release VMTests for tryjobs.
2016-05-20 joth Mark veyron_rialto-chrome-pfq as important
2016-05-20 dgarrett paygen_build_lib: Remove au_generator_uri argument.
2016-05-20 dgarrett paygen_build_lib: Remove excessive flags controlling payloads.
2016-05-20 dgarrett paygen: Remove run_on_builder flag.
2016-05-20 dgarrett paygen_build_lib: Remove SKIP flag concept.
2016-05-24 kevcheng guado_moblab-paladin: Temporarily disable hwtests during lab move.
2016-05-23 cywang chromeos_config: Change back to 'bvt' pool for arc-bvt-cq suite
2016-05-18 nxia Add whitelist for testbed-ap images
2016-05-20 shenhan Revert "Configure ChromeOS clang for simple-chrome."
2016-05-19 akeshet git: demote chromite checkout warning
2016-05-19 cmtice [cbuildbot] Make grouped toolchain bots build_packages in foreground.
2016-05-18 sbasi guado_moblab-release: Run bvt-cq
2016-05-18 rickyz Handle Paths that match overlapping sets of files
2016-05-18 phobbs sync_stages: Change pre-cq CL count Monarch path.
2016-05-18 akeshet cbuildbot: improve the master-deadline timeout message
2016-05-13 akeshet [re-land] sync_stages: fix _VerifyMasterId to respect milestone_version
2016-05-18 akeshet sync_stages: fix blamelist link
2016-03-21 dgarrett paygen_build_lib: Move disable_tests handling into _PaygenBuild.
2016-05-18 phobbs sync_stages: Add monarch collection for cl-counts
2016-05-11 vapier gs: update to 4.19
2016-03-04 shenhan Configure ChromeOS clang for simple-chrome.
2016-05-16 stevenjb DictToGypDefines - use double quotes to support gyp flags with spaces
2016-05-12 philipchen Make oak-based board builder 'non-experimemtal'
2016-05-11 nxia cros_uprevchrome tool to manually uprev Chrome PFQ (part 3)
2016-05-17 nya Revert "sync_stages: fix _VerifyMasterId to respect milestone_version"
2016-05-13 akeshet sync_stages: fix _VerifyMasterId to respect milestone_version
2016-05-16 akeshet archive_lib: fix download urls for gs artifacts
2016-05-16 akeshet validation_pool: allow CQ to work on aosp/ repos
2016-05-12 wonderfly chromeos_config: Enable vm tests and gce tests on lakitu_next-pre-cq
2016-05-13 cmtice [cbuildbot] Create ToolchainTests and assign them to toolchain bots.
2016-05-16 phobbs Revert "stats: Added Monarch metrics to statsd class"
2016-05-09 nxia cros_uprevchrome tool to manually uprev Chrome PFQ (part 2)
2016-02-04 phobbs stats: Added Monarch metrics to statsd class
2016-05-13 nxia Use BuildRootGitCleanup in Sync retry
2016-05-09 dgarrett chromeos_config: Build Chrome on veyron_rialto-release
2016-05-11 bhthompson Make cheets paladins important
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2055873002
Cr-Commit-Position: refs/heads/master@{#399112}
Create a watchlist for media/mojo and add myself.
Review-Url: https://codereview.chromium.org/2053923003
Cr-Commit-Position: refs/heads/master@{#399111}
GN: Set and use use_clipboard_aurax11 correctly
BUG=618852
Review-Url: https://codereview.chromium.org/2058623002
Cr-Commit-Position: refs/heads/master@{#399110}
Disable PDFium XFA forms.
There have been a lot of bugs found/reported.
BUG=62400
Review-Url: https://codereview.chromium.org/2052163002
Cr-Commit-Position: refs/heads/master@{#399109}
Remove pylint checking for print statement usage.
In http://crrev.com/2038223002, Dirk notes:
> print is perfectly legal in Python 2, so we might want to just disable it in pylintrc.
This CL would make our linter not warn about print statements anymore.
Review-Url: https://codereview.chromium.org/2047563002
Cr-Commit-Position: refs/heads/master@{#399108}
Make CSSValuePool::fontFaceValueCache store a const CSSValueList
Make CSSValuePool::fontFaceValueCache store a Member<const CSSValueList>
instead of non-const. Also added a TODO to make all the CSSValuePools
store const CSSValues.
This is an entirely mechanical change that is more semantically correct
and safe, and is pre-work for making CSSPropertyParser::parseSingleValue
return a const CSSValue*.
BUG=526586
Review-Url: https://codereview.chromium.org/2034383002
Cr-Commit-Position: refs/heads/master@{#399107}
DevTools: clear layers using transparent color
The default layer backing is transparent. Clearing with anything else
can interfere with compositing later.
Use transparent color instead of opaque white when clearing layers for
partial playback.
[email protected],[email protected]
BUG=607720
Review-Url: https://codereview.chromium.org/2044643006
Cr-Commit-Position: refs/heads/master@{#399106}
Made EditingStyle::attributeValueAsCSSValue return a const CSSValue*
Made EditingStyle::attributeValueAsCSSValue return a const CSSValue*.
This is an entirely mechanical change and is pre-work for making
StylePropertySet::getPropertyCSSValue return a const CSSValue*.
BUG=526586
Review-Url: https://codereview.chromium.org/2042693002
Cr-Commit-Position: refs/heads/master@{#399105}
Roll src/third_party/catapult/ b648cd04c..2c5cde737 (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b648cd04ccd9..2c5cde737888
$ git log b648cd04c..2c5cde737 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2057963002
Cr-Commit-Position: refs/heads/master@{#399104}
Updating initial zoom level for remote connections in Android Client.
This change updates the method used for sizing the remote desktop image
to the Android device's screen. The previous method was to scale down
the remote image so that the entire image would fit. This worked great
for similarly sized displays but not so great for high resolution or
multi-monitor displays.
The method I use now is to scale up the remote image (if needed) such
that there isn't any empty space on the screen. I do this by
calculating the width and height ratios and scaling the image by the
larger of the two. This ensures that the local screen is filled with
the image of the remote display and is similar to the behavior that
existed prior to my last change. The viewport is then translated to the
upper left of the screen for the default starting position.
Once the image is resized and positioned, I update starting coordinates
for the cursor so it is placed in the center of the viewport area.
BUG=618385
Review-Url: https://codereview.chromium.org/2058543002
Cr-Commit-Position: refs/heads/master@{#399103}
Skip profiles in GetLastOpenedProfiles that fail to initialize
If a profile fails to initialize, a nullptr is returned when we create
that profile, causing a DCHECK failure. However, if this happens in
Release, the DCHECK is bypassed, and a vector with nullptrs is returned.
This results in crashes because callsites of GetLastOpenedProfiles does
not check for nullptrs.
See #17 of the bug for a detailed analysis of the crash.
BUG=614753
TEST=
1. Use a Windows version.
2. Start chromium with a new user data directory, e.g.
chromium --user-data-dir=d:\datadir1
3. Create two extra profiles, so you have "Person 1", "Person 2" and
"Person 3"
4. Exit by Ctrl+Shift+Q while the browser windows are still open.
5. Now remove the directory "Profile 1" in the user data directory.
6. Set the permission of the user data directory to deny creating new
directories.
(a) Right-click the directory, select "Properties".
(b) Click "Advanced"
(c) Click "Add" in "Permission" tab.
(d) Click "Select a principal", type "EVERYONE" in the box, then press
"Okay".
(e) In the combo boxes, select "Type: Deny" and
"Applies To: This folder only".
(f) Select "Show advanced permissions".
(g) Uncheck all, then check "Create folders / append data", which is
at the lower left corner.
(h) Click Ok in the three dialog boxes.
7. Start chromium again (repeat step (1)).
Expected behavior:
Before patch - crash.
After patch - chromium starts with TWO browser windows in step 7.
If step 6 is not taken - chromium starts with THREE browser windows in
step 7
Review-Url: https://codereview.chromium.org/2021253002
Cr-Commit-Position: refs/heads/master@{#399102}
Construct the site engagement helper with a site engagement service.
This CL refactors the site engagement helper to initialise its site
engagement service point at construction. This obviates the
need to query for the site engagement service each time
engagement is increased. The service' private interface is also
refactored to take a WebContents pointer rather than a GURL
on engagement increases, allowing it to signal other observers
of the WebContents in a future CL.
BUG=616322
Review-Url: https://codereview.chromium.org/2042243004
Cr-Commit-Position: refs/heads/master@{#399101}
Update the style of opt-in IME menu checkbox in language settings to make it matching other checkboxes.
Change the height of the #language-options-languages/details to avoid showing two scrollbars.
BUG=570761
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2047133003
Cr-Commit-Position: refs/heads/master@{#399100}
Remove MessageLoop::current()->RunUntilIdle() in components.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in components.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053913002
Cr-Commit-Position: refs/heads/master@{#399099}
Allow ClearLevel to clear outside renderable range
A level may be attached to a framebuffer even though it's outside the renderable
range (below GL_TEXTURE_BASE_LEVEL). We can and need to clear it even in that
case.
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2057903002
Cr-Commit-Position: refs/heads/master@{#399098}
mash: Convert ash::ShellDelegate from aura::Window to WmWindow
Also remove unnecessary shell.h include from shell_delegate.h and clean up
includes elsewhere.
BUG=615155
TEST=existing ash_unittests and chrome unit_tests
Review-Url: https://codereview.chromium.org/2055053002
Cr-Commit-Position: refs/heads/master@{#399097}
Roll src/third_party/skia/ b445a57e6..c9b4ccd77 (2 commits).
https://chromium.googlesource.com/skia.git/+log/b445a57e6c36..c9b4ccd77100
$ git log b445a57e6..c9b4ccd77 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 mtklein Skip verylargebitmap serialization on Android too
2016-06-09 mtklein Move immintrin/arm_neon includes to where they are used.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2057883003
Cr-Commit-Position: refs/heads/master@{#399096}
Move WTF string to number converter functions to StringToNumber.h
This allows various things to call these methods without having to
depend on the WTFString.h header which was a strange place for
a bunch of functions that take LChar* and UChar*'s.
No functional changes are made, the code is just moved around.
BUG=615174
Review-Url: https://codereview.chromium.org/2058613002
Cr-Commit-Position: refs/heads/master@{#399095}
Implement bluetooth chooser for Chrome Apps on non-Mac desktops
This is the part 5 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.
This CL implements the chooser UI for Bluetooth from Apps on non-Mac
desktops.
BUG=616602, 577170
Review-Url: https://codereview.chromium.org/2033283002
Cr-Commit-Position: refs/heads/master@{#399094}
cc : Move LayerImpl::children to test properties
BUG=602438
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2053193002
Cr-Commit-Position: refs/heads/master@{#399093}
Vectorize the remaining material design shelf icons
Create vectorized versions of the icons used
in the material design shelf:
* Overflow arrow
* Keyboard
* Notifications bell
* Overview mode
BUG=595015
TEST=manual
Review-Url: https://codereview.chromium.org/2051663005
Cr-Commit-Position: refs/heads/master@{#399092}
bluetooth: Don't call methods of WebContentsImpl while it's being destroyed.
Also adds a test to excercise that code path.
BUG=615319
Review-Url: https://codereview.chromium.org/2038843003
Cr-Commit-Position: refs/heads/master@{#399091}
Encapsulate the CSSPrimitiveValue UnitType trie bethind a method that takes a StringView.
This removes the need for callers to manually branch on is8Bit() and
also avoids having these separate functions in a header that's harder
to discover.
Now CSSPrimitiveValue has both unitTypeToString and stringToUnitType.
BUG=615174
Review-Url: https://codereview.chromium.org/2051313002
Cr-Commit-Position: refs/heads/master@{#399090}
[chromecast] Moves fake key handling to DecoderBufferAdpter.
The logic is being moved from DecoderBufferBaseMarshaller, IPC
transport layer to DecoderBufferAdapter so that it is shared between
the cma and mojo pipleine.
BUG=571155
TBR=yucliu1
Review-Url: https://codereview.chromium.org/2054003002
Cr-Commit-Position: refs/heads/master@{#399089}
events: Initialize |MouseEvent::changed_button_flags_| correctly.
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2055093002
Cr-Commit-Position: refs/heads/master@{#399088}
Replace the old URL format for PVer4 requests with the new format.
The new URL format is described in the bug.
The old format doesn't seem to be working currently so this is a good time to
switch. See: http://b/29229908
BUG=603348, 543161
Review-Url: https://codereview.chromium.org/2057433002
Cr-Commit-Position: refs/heads/master@{#399087}
Remove MessageLoop::current()->task_runner() in mojo.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in mojo.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2050873002
Cr-Commit-Position: refs/heads/master@{#399086}
Refactor ChooserBubbleUiViewDelegate
This is part 4 of enabling the chooser UIs for Bluetooth
from Apps to enable developers to make a transition.
Since the chooser content view is the same for WebBluetooth
on desktop and Chrome Apps, it is better to pull it out of
ChooserBubbleUiViewDelegate and have a class
ChooserContentView that can be reused.
BUG=616598, 577170, 618618
Review-Url: https://codereview.chromium.org/2029863002
Cr-Commit-Position: refs/heads/master@{#399085}
MacViews: Refine the LabelButton style
Update the style used for LabelButtons under MacViews per the detailed
spec at http://crbug.com/543686#c12
Changes:
- Draws the border stroke with gradient -- lighter on the top edge than
the bottom edge.
- Draws a subtle drop shadow.
- Updated border radius 2->3.
- Focus ring draws over border stroke (using alpha).
- Focus ring thickness is "unchanged" it was 3, it's now 4 but it draws
over the border stroke for a diff of 3.
- Focus ring corner radius is inferred so the corner radii align
properly: it must be border_radius(3) + focus_ring_thickness(4) -
border_stroke(1). So it's effectively 6.
The drawing logic moves from DialogButtonBorderMac to NativeThemeMac
because the same core style is used for the TabbedPane and the Combobox,
just with some corners not rounded.
BUG=543686
Review-Url: https://codereview.chromium.org/2033313002
Cr-Commit-Position: refs/heads/master@{#399084}
aw: Add missing destroy check
BUG=618807
Review-Url: https://codereview.chromium.org/2052023002
Cr-Commit-Position: refs/heads/master@{#399083}
MD History: Change sizing of dropdown toggle to 20x20px
As per feedback from UI.
BUG=425625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2054523003
Cr-Commit-Position: refs/heads/master@{#399082}
Refactor CertificateReportSender
CertificateReportSender renamed to ReportSender
TransportSecurityState::ReportSender renamed to TransportSecurityState::ReportSenderInterface
BUG=613883
Review-Url: https://codereview.chromium.org/2026213002
Cr-Commit-Position: refs/heads/master@{#399081}
Add WebView startup time benchmark.
BUG=614374
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2013223002
Cr-Commit-Position: refs/heads/master@{#399080}
cc: Fix for synced property main thread updates with MFBA.
Main thread before activation allows sending BeginMainFrames while there
is a pending tree. In this mode pulling deltas from SyncedProperty for
BeginMainFrame should not be incorrect in between commit and activation
of a previous frame.
BUG=616086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2035543003
Cr-Commit-Position: refs/heads/master@{#399079}
Media permissions: Remove plumbing for insecure pepper requests in Chrome
Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).
This CL removes the plumbing for Pepper requests from the media
permission layer, since it is no longer needed.
BUG=596786
Review-Url: https://codereview.chromium.org/1828803003
Cr-Commit-Position: refs/heads/master@{#399078}
Use String::find(CharacterMatchFunctionPtr) in SelectorChecker's attributeValueMatches.
This removes a bunch of code but does mean we need to make a function
call per character instead of it all being inline, but if that's an
issue we can inline StringImpl::find and the compiler can then inline
the function pointer call.
Review-Url: https://codereview.chromium.org/2055033002
Cr-Commit-Position: refs/heads/master@{#399077}
Auto-rebaseline for r399060
https://chromium.googlesource.com/chromium/src/+/ff3dc65b0
BUG=254639
[email protected]
Review URL: https://codereview.chromium.org/2056993002 .
Cr-Commit-Position: refs/heads/master@{#399076}
Add a tabstrip to the browser.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2051223003
Cr-Commit-Position: refs/heads/master@{#399075}
WorkerLoaderProxy should not inherit WorkerLoaderProxyProvider
WorkerLoaderProxyProvider::postTaskToLoader is called only from
WorkerLoaderProxy::postTaskLoader via the WorkerLoaderProxyProvider
provided from WorkerLoaderProxy's constructor. But a WorkerLoaderProxy
is never passed to the constructor according to the CodeSearch.
The same applies to WorkerLoaderProxyProvider::postTaskToWorkerGlobalScope.
This inheritance is very confusing for readers including me and
actually does nothing based on the above observation. Let's delete it.
BUG=None
Review-Url: https://codereview.chromium.org/2050083003
Cr-Commit-Position: refs/heads/master@{#399074}
Set text anti-aliasing settings at PPAPI plugin process on Windows.
This patch will enable text anti-aliasing to call the following methods:
* blink::WebFontRendering::setAntialiasedTextEnabled
* blink::WebFontRendering::setLCDTextEnabled
This patch will also get anti-aliasing settings from
gfx::GetFontRenderParams method.
BUG=615375
TEST=If [Smooth edges of screen fonts] at advanced system settings is
enabled, text in flash is anti-aliased. If disabled, text is aliased.
Review-Url: https://codereview.chromium.org/2048563004
Cr-Commit-Position: refs/heads/master@{#399073}
Revert of Re-enable DexLoaderTests (patchset #1 id:1 of https://codereview.chromium.org/2056783002/ )
Reason for revert:
Still red on the debug bot :(
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/34786
Original issue's description:
> Re-enable DexLoaderTests
>
> https://codereview.chromium.org/2045313002/ fixed the bug with dx --incremental
> causing the DexLoaderTests to fail on partial rebuilds of chrome_public_test_apk
>
> BUG=617935
>
> Committed: https://crrev.com/ab92c217cd5792ea92b9e52d2dc65d03992b6f68
> Cr-Commit-Position: refs/heads/master@{#399023}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617935
Review-Url: https://codereview.chromium.org/2057953002
Cr-Commit-Position: refs/heads/master@{#399072}
Updating trunk VERSION from 2764.0 to 2765.0
Cr-Commit-Position: refs/heads/master@{#399071}
Add client library for navigation service.
Flips the browser app to use it instead of maintaining its own caches.
[email protected]
Review-Url: https://codereview.chromium.org/2057683002
Cr-Commit-Position: refs/heads/master@{#399070}
Clean up V8 bindings constants code
This small refactoring makes constants handled in the same way as attributes,
extending the work in https://crrev.com/b9619673. It uses filters on a single
|constants| context variable, rather than defining new lists for each (possibly
overlapping) group of constants, and makes use of the same logic for grouping
runtime-enabled constants by feature name that attributes were previously
changed to use.
(This also includes some pylint cleanup for v8_attributes.py and
code_generator_v8.py)
Review-Url: https://codereview.chromium.org/2058443002
Cr-Commit-Position: refs/heads/master@{#399069}
Build fixes for linux desktop CrOS builders.
This almost gets them ready to be flipped to GN.
[email protected], [email protected]
BUG=433082
Review-Url: https://codereview.chromium.org/2053083002
Cr-Commit-Position: refs/heads/master@{#399068}
[ash-md] Adds a dark shield behind the windows in overview mode
The translucent shield brings attention to the windows in overview mode.
Also the ShelfLayoutManager watches the overview mode and darkens the shelf when in overview mode (same as when some window overlaps the shelf).
BUG=604764
TEST=ShelfLayoutManagerTest.ShelfBackgroundDarkInOverview
Review-Url: https://codereview.chromium.org/2049403003
Cr-Commit-Position: refs/heads/master@{#399067}
DevTools: properly format custom elements without nodenames
Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.
BUG=616981
Review-Url: https://codereview.chromium.org/2056433002
Cr-Commit-Position: refs/heads/master@{#399066}
[ash-md] Masks the original window header in overview mode
Uses mask layer to hide original window header in overview.
Adds a container view with a background to match the close button.
BUG=604767
Review-Url: https://codereview.chromium.org/2050643003
Cr-Commit-Position: refs/heads/master@{#399065}
Check for empty panel state in animations
This change reverts the boolean added checking if an animation
had been added and checks for a null panel state. It is
suspected that this is the result of some animation not directly
related to panel state finishing before the panel is assigned a
state.
BUG=616898, 616856, 614905, 613945
Review-Url: https://codereview.chromium.org/2037523004
Cr-Commit-Position: refs/heads/master@{#399064}
Correct inforbar state tracked by Reader Mode
The ReaderModeManager did not correctly update the state of its
InfoBars when the tab was switched. This resulted in Reader Mode
not showing if an infobar was visible on any tab. This change checks
how many infobars are showing on a tab when it is switched to.
BUG=617937, 613150, 586882
Review-Url: https://codereview.chromium.org/2055453002
Cr-Commit-Position: refs/heads/master@{#399063}
DevTools: fix the FrontendChannel header.
TBR=dgozman
NOTRY=true
Review-Url: https://codereview.chromium.org/2057913002
Cr-Commit-Position: refs/heads/master@{#399062}
Update Suborigins grammar to match spec changes
The spec took away semicolons from the grammar because they were
unnecessary. This CL updates the implementation and tests accordingly.
BUG=336894
[email protected]
Review-Url: https://codereview.chromium.org/2052033002
Cr-Commit-Position: refs/heads/master@{#399061}
Optimize render passes with single quads
Many effects (masks, replicas, filters) generate render passes for
simplicity in the code. However, in the cases where the pass contains a
single quad with a texture, that resulting texture could just be used as
the input texture instead of the render pass itself.
The complication is mostly that render passes and tile textures are
flipped relative to each other (oops) and so some knowledge of this has
to leak into drawing render passes.
This is done by detecting such render passes inside of DirectRenderer,
storing the TileQuad that would have been drawn, skipping allocating the
pass and rendering it, and then calling a slightly modified version of
DrawRenderPassQuad with the TileQuad's resource. The check for which
render passes can be supported is conservative to start.
This optimization usually will not be supported on mac because skia
does not support textures with texture rectangle targets as input.
BUG=254639,606672
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1960543002
Cr-Commit-Position: refs/heads/master@{#399060}
Mojo C++ bindings: don't DCEHCK in Binding::Close() when the binding is not bound.
BUG=618488
Review-Url: https://codereview.chromium.org/2052963002
Cr-Commit-Position: refs/heads/master@{#399059}
[ios Mojo] Allow defining anonymous modules which load automatically.
In content// |define| automatically loads anonymous modules. require.js
does not support nameless modules, so this CL assigns a unique name
for each anonymous module and loads it to make web// mojo API consistent
with content//.
BUG=567809
Review-Url: https://codereview.chromium.org/2055443003
Cr-Commit-Position: refs/heads/master@{#399058}
Storage manager: Show overall size information and size of Downloads.
On the storage manager overlay, this CL adds following functions.
- Shows overall storage information(total/used/available) using statvfs() on the local volume.
- Shows size of Downloads directory by computing directory size recursively.
- Opens up Files app when the label "Downloads" is clicked.
The layout inside the overlay is tentative.
BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TEST=manually by flag #enable-storage-manager enabled.
Review-Url: https://codereview.chromium.org/2041343002
Cr-Commit-Position: refs/heads/master@{#399057}
Mojo C++ bindings: introduce EnumTraits.
BUG=577686
Review-Url: https://codereview.chromium.org/2049353002
Cr-Commit-Position: refs/heads/master@{#399056}
Roll WebGL 04fa5ca..fda7011
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/04fa5ca..fda7011
BUG=
TEST=bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2056013002
Cr-Commit-Position: refs/heads/master@{#399055}
media: Fix mojo DecoderBuffer type converter
When side_data is empty, we should not called front(), otherwise it's undefined behavior:
https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/array.h?rcl=0&l=97
The crash is like this:
#2 0x00007ffff442dfe5 in __gnu_debug::_Error_formatter::_M_error (this=0x7fffffffc058)
at ../../../../../src/libstdc++-v3/src/c++11/debug.cc:781
#3 0x0000000000550062 in std::__debug::vector<unsigned char, std::allocator<unsigned char> >::front
(this=0x362504b6f3a8)
at ../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../in
clude/c++/4.6/debug/vector:329
#4 0x000000000054d905 in mojo::Array<unsigned char>::front (this=0x362504b6f3a8)
at ../../mojo/public/cpp/bindings/array.h:99
#5 0x000000000054b9b4 in mojo::TypeConverter<scoped_refptr<media::DecoderBuffer>, mojo::StructPtr<m
edia::mojom::DecoderBuffer> >::Convert (input=...)
at ../../media/mojo/common/media_type_converters.cc:476
I'll enable media_mojo_unittests on bots shortly so that we can catch
regressions.
BUG=617204
TEST=fixes a unittest
Review-Url: https://codereview.chromium.org/2050323002
Cr-Commit-Position: refs/heads/master@{#399054}
Add RunLoop::QuitWhenIdle().
This will facilitate the removal of calls to
MessageLoop::QuitWhenIdle().
BUG=616447
Review-Url: https://codereview.chromium.org/2045263004
Cr-Commit-Position: refs/heads/master@{#399053}
Roll src/third_party/skia/ 804b461bc..b445a57e6 (8 commits).
https://chromium.googlesource.com/skia.git/+log/804b461bc4fe..b445a57e6c36
$ git log 804b461bc..b445a57e6 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 jbauman Add NV12 texture conversion support.
2016-06-09 brianosman Add control of manual mipmapping to GrContextOptions
2016-06-09 djsollen Cleanup needed to use WindowContext for Android GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055693003
2016-06-09 borenet Add housekeeper_skia.isolate
2016-06-09 senorblanco SkPictureAnalyzer: expose the number of slow GPU commands.
2016-06-09 mtklein Revert of Disable tail calls inside Simple GM functions. (patchset #1 id:1 of https://codereview.chromium.org/2050473006/ )
2016-06-09 mtklein Revert of Add control of manual mipmapping to GrContextOptions (patchset #2 id:20001 of https://codereview.chromium.org/2054623003/ )
2016-06-09 liyuqian Support resize in Android Viewer App
BUG=614724
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2053833002
Cr-Commit-Position: refs/heads/master@{#399052}
Implement update notifications for ChromeVox Next.
- adds a notification on startup alerting the user to a new ChromeVox experience
- adds a skeleton page to be filled with content for the transition intro/tutorial
- fixes the alert output rule to ignore descendants in the output if the alert has a name
- adds a new command to open the "new" or "next" announcements/release notes/tutorial
- fixes two issues with the notification center:
1. the focus wasn't being placed on the first message view item
2. the scroll view parenting the message views was receiving focus but has no actionable functionality from the keyboard. Removed it from being focusable.
The outcome is when hitting alt+shift+n, an actionable button gets focused with or wihtout a notification being present (do not disturb gets focus if there are no messages).
Previously, alt+shift+n focused the scrollview, which has no name/role, so gave no meaningful feedback.
BUG=618094
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2054473003
Cr-Commit-Position: refs/heads/master@{#399051}
Ensure that chrome_sandbox doesn't have -rpath=$ORIGIN.
This CL tweaks the ldflag configs for chrome_sandbox to make
sure we don't accidentally pick up -rpath=$ORIGIN, which can
be a security hole for a setuid binary.
[email protected],[email protected]
BUG=612647
Review-Url: https://codereview.chromium.org/2050763004
Cr-Commit-Position: refs/heads/master@{#399050}
Remove MessageLoop::current()->RunUntilIdle() in extensions.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in extensions.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2059483002
Cr-Commit-Position: refs/heads/master@{#399049}
Update V8 to version 5.3.198.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4a9c5195..05f552d9
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2056003002
Cr-Commit-Position: refs/heads/master@{#399048}
Test for bug 618429.
BUG=618429
[email protected]
Review-Url: https://codereview.chromium.org/2048393002
Cr-Commit-Position: refs/heads/master@{#399047}
Removing unused enum.
BUG=NONE
Review-Url: https://codereview.chromium.org/2051063004
Cr-Commit-Position: refs/heads/master@{#399046}
[Mac/GN] Add targets to run dump_syms and create the dSYM archive.
These steps are required for the official build.
BUG=330301,431177
[email protected]
Review-Url: https://codereview.chromium.org/2054893002
Cr-Commit-Position: refs/heads/master@{#399045}
Replace forward declarations with includes in TaskRunner APIs.
This CL:
- Adds #include "base/location.h" in base/task_runner.h
- Adds #include "base/single_thread_task_runner.h"
in base/threading/thread_task_runner_handle.h
- Adds #include "base/sequenced_task_runner.h"
in base/threading/sequenced_task_runner_handle.h
This will be followed by a mass removal of includes that
are no longer necessary.
BUG=618793
Review-Url: https://codereview.chromium.org/2053503004
Cr-Commit-Position: refs/heads/master@{#399044}
Remove extra png files for a ref test
Review URL: https://codereview.chromium.org/2053173002 .
Cr-Commit-Position: refs/heads/master@{#399043}
Make ap effective.
The value must be propagated to the CrxInstaller for the feature
to work end to end.
Changed the order of assignments to match the order of member
declaration in CrxInstaller class.
R=waffles
BUG=599703
Review-Url: https://codereview.chromium.org/2056773002
Cr-Commit-Position: refs/heads/master@{#399042}
Add white-list for new StrictMode violations.
BUG=613977,617725
Review-Url: https://codereview.chromium.org/2052473004
Cr-Commit-Position: refs/heads/master@{#399041}
Filtered out hidden apps from launcher search results.
BUG=b/29244891
TEST=manual
Review-Url: https://codereview.chromium.org/2056873002
Cr-Commit-Position: refs/heads/master@{#399040}
Added telemetry pages for the canvas element.
BUG=606687,606686,606685
Review-Url: https://codereview.chromium.org/2047773002
Cr-Commit-Position: refs/heads/master@{#399039}
Relocate Blimp engine browser tests from test/ to engine/.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2058483002
Cr-Commit-Position: refs/heads/master@{#399038}
Auto-rebaseline for r399007
https://chromium.googlesource.com/chromium/src/+/c612643f5
BUG=600008
[email protected]
Review URL: https://codereview.chromium.org/2052083002 .
Cr-Commit-Position: refs/heads/master@{#399037}
Clamp shown ratio when setting main thread top controls constraints.
We already do this on the compositor thread so this just applies matching
behaviour on the main thread. When we constrain the top controls to being shown
or hidden, we set the currently shown ratio to 1 or 0, respectively, at the time
the constraint is set, rather than waiting for a compositor commit to reflect
the delta back to the main thread.
BUG=476541
Review-Url: https://codereview.chromium.org/2044133002
Cr-Commit-Position: refs/heads/master@{#399036}
Collapse description into either value or name, and value into name if duplicated.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TEST=BackgroundTest.ButtonNameValueDescription
BUG=613639
Review-Url: https://codereview.chromium.org/2016003002
Cr-Commit-Position: refs/heads/master@{#399035}
PermissionSelectorView: use Combobox on MacViews builds.
The Cocoa version of this dialog uses the cocoa equivalent of Comboboxes. Also,
Comboboxes on MacViews have appropriate styling, whereas MenuButtons don't and
changing them to have it seems quite involved.
This CL involves adapting the permission selector's MenuModel to a
ComboboxModel, then creating a Combobox instead of a MenuButton on Mac.
BUG=605161
Review-Url: https://codereview.chromium.org/2011963002
Cr-Commit-Position: refs/heads/master@{#399034}
Add a few more OWNERS in chrome/
NOTRY=true
Review-Url: https://codereview.chromium.org/2052723004
Cr-Commit-Position: refs/heads/master@{#399033}
Adds UnsafeArena::Free(), and uses it in SpdyHeaderBlock::StringPieceProxy.
Makes lookup-only access to SpdyHeaderBlock::operator[] memory-neutral.
The implementation of operator[] returns a StringPieceProxy, an object that was designed to have a temporary lifetime. When constructing a StringPieceProxy, it is not known whether it will be used for a lookup or to modify the SpdyHeaderBlock. To allow the latter use case, operator[]'s argument is written to SpdyHeaderBlock's Storage. In the case where the StringPieceProxy is only used for lookup, this memory was effectively "leaked". It would have been possible to use an unbounded amount of memory by repeatedly looking up keys not present in the SpdyHeaderBlock.
This CL lands server change 123251582 by birenroy.
BUG=488484
Review-Url: https://codereview.chromium.org/2047783002
Cr-Commit-Position: refs/heads/master@{#399032}
[Sync] Attempt to fix a flake in OpenTabsTest.
BUG=618741
Review-Url: https://codereview.chromium.org/2056753002
Cr-Commit-Position: refs/heads/master@{#399031}
mash: Move tray_constants.h and FixedSizedImageView to //ash/common
These are dependencies of TrayUpdate, which I am moving to //ash/common
TBR because this is a purely mechanical move:
* move_source_file.py ash/system/tray/tray_constants.h ash/common/system/tray/
* move_source_file.py ash/system/tray/tray_constants.cc ash/common/system/tray/
* move_source_file.py ash/system/tray/fixed_sized_image_view.h ash/common/system/tray/
* move_source_file.py ash/system/tray/fixed_sized_image_view.cc ash/common/system/tray/
BUG=615155
TEST=compiles
[email protected]
Review-Url: https://codereview.chromium.org/2056683003
Cr-Commit-Position: refs/heads/master@{#399030}
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group> when controlled
This does not yet add UI for showing that the radio group is controlled.
[email protected]
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2052543002
Cr-Commit-Position: refs/heads/master@{#399029}
Revert of Make media/capture gn and gyps produce components (patchset #7 id:580001 of https://codereview.chromium.org/2031073002/ )
Reason for revert:
Broke (at least)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/157095/steps/compile/logs/stdio/text:
FAILED: libmedia.dylib libmedia.dylib.TOC
if [ ! -e "./libmedia.dylib" -o ! -e "./libmedia.dylib.TOC" ] || otool -l "./libmedia.dylib" | grep -q LC_REEXPORT_DYLIB ; then ../../build/toolchain/mac/linker_driver.py /b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-install_name,@rpath/"libmedia.dylib" -stdlib=libc++ -arch x86_64 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -o "./libmedia.dylib" -Wl,-filelist,"./libmedia.dylib.rsp" -framework CoreVideo -framework AVFoundation -framework AudioToolbox -framework AudioUnit -framework CoreAudio ./libshared_memory_support.dylib ./libffmpeg.dylib ./libbase.dylib ./libbase_i18n.dylib ./libcrcrypto.dylib ./libskia.dylib ./libevents_base.dylib ./libgfx.dylib ./libgeometry.dylib ./libgl_wrapper.dylib ./liburl.dylib ./libgpu.dylib ./libgles2_utils.dylib ./libicui18n.dylib ./libicuuc.dylib ./librange.dylib ./libui_base.dylib ./libplatform.dylib ./libgl_init.dylib ./libipc.dylib ./libboringssl.dylib && { otool -l "./libmedia.dylib" | grep LC_ID_DYLIB -A 5; nm -gP "./libmedia.dylib" | cut -f1-2 -d' ' | grep -v U$$; true; } > "./libmedia.dylib.TOC"; else ../../build/toolchain/mac/linker_driver.py /b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-install_name,@rpath/"libmedia.dylib" -stdlib=libc++ -arch x86_64 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -o "./libmedia.dylib" -Wl,-filelist,"./libmedia.dylib.rsp" -framework CoreVideo -framework AVFoundation -framework AudioToolbox -framework AudioUnit -framework CoreAudio ./libshared_memory_support.dylib ./libffmpeg.dylib ./libbase.dylib ./libbase_i18n.dylib ./libcrcrypto.dylib ./libskia.dylib ./libevents_base.dylib ./libgfx.dylib ./libgeometry.dylib ./libgl_wrapper.dylib ./liburl.dylib ./libgpu.dylib ./libgles2_utils.dylib ./libicui18n.dylib ./libicuuc.dylib ./librange.dylib ./libui_base.dylib ./libplatform.dylib ./libgl_init.dylib ./libipc.dylib ./libboringssl.dylib && { otool -l "./libmedia.dylib" | grep LC_ID_DYLIB -A 5; nm -gP "./libmedia.dylib" | cut -f1-2 -d' ' | grep -v U$$; true; } > "./libmedia.dylib.tmp" && if ! cmp -s "./libmedia.dylib.tmp" "./libmedia.dylib.TOC"; then mv "./libmedia.dylib.tmp" "./libmedia.dylib.TOC" ; fi; fi
Undefined symbols for architecture x86_64:
"_CFArrayCreate", referenced from:
media::video_toolbox::ArrayWithIntegers(int const*, unsigned long) in videotoolbox_helpers.o
media::video_toolbox::ArrayWithIntegerAndFloat(int, float) in videotoolbox_helpers.o
"_CFDictionaryCreate", referenced from:
media::video_toolbox::DictionaryWithKeysAndValues(void const**, void const**, unsigned long) in videotoolbox_helpers.o
"_CFGetTypeID", referenced from:
media::VideoFrame::WrapCVPixelBuffer(__CVBuffer*, base::TimeDelta) in video_frame.o
"_CFNumberCreate", referenced from:
media::video_toolbox::ArrayWithIntegers(int const*, unsigned long) in videotoolbox_helpers.o
media::video_toolbox::ArrayWithIntegerAndFloat(int, float) in videotoolbox_helpers.o
media::video_toolbox::SessionPropertySetter::Set(__CFString const*, int) in videotoolbox_helpers.o
"_CFRelease", referenced from:
base::internal::ScopedCFTypeRefTraits<__CVBuffer*>::Release(__CVBuffer*) in video_frame_mac.o
media::video_toolbox::ArrayWithIntegers(int const*, unsigned long) in videotoolbox_helpers.o
media::video_toolbox::ArrayWithIntegerAndFloat(int, float) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<__CFArray const*>::Release(__CFArray const*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<OpaqueCMBlockBuffer*>::Release(OpaqueCMBlockBuffer*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<OpaqueVTCompressionSession*>::Release(OpaqueVTCompressionSession*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<__CFNumber const*>::Release(__CFNumber const*) in videotoolbox_helpers.o
...
"_CFRetain", referenced from:
base::internal::ScopedCFTypeRefTraits<__CVBuffer*>::Retain(__CVBuffer*) in video_frame_mac.o
base::internal::ScopedCFTypeRefTraits<__CFDictionary const*>::Retain(__CFDictionary const*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<__CFArray const*>::Retain(__CFArray const*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<OpaqueCMBlockBuffer*>::Retain(OpaqueCMBlockBuffer*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<OpaqueVTCompressionSession*>::Retain(OpaqueVTCompressionSession*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<__CFNumber const*>::Retain(__CFNumber const*) in videotoolbox_helpers.o
base::internal::ScopedCFTypeRefTraits<__CFString const*>::Retain(__CFString const*) in audio_manager_mac.o
...
"_CGEventSourceCounterForEventType", referenced from:
media::(anonymous namespace)::UserInputMonitorMac::GetKeyPressCount() const in user_input_monitor_mac.o
"_OBJC_CLASS_$_NSBundle", referenced from:
objc-class-ref in coremedia_glue.o
objc-class-ref in videotoolbox_glue.o
objc-class-ref in avfoundation_glue.o
"_OBJC_CLASS_$_NSObject", referenced from:
_OBJC_CLASS_$_AVCaptureDeviceGlue in avfoundation_glue.o
_OBJC_CLASS_$_AVCaptureDeviceInputGlue in avfoundation_glue.o
"_OBJC_CLASS_$_NSThread", referenced from:
objc-class-ref in avfoundation_glue.o
"_OBJC_METACLASS_$_NSObject", referenced from:
_OBJC_METACLASS_$_AVCaptureDeviceGlue in avfoundation_glue.o
_OBJC_METACLASS_$_AVCaptureDeviceInputGlue in avfoundation_glue.o
"___CFConstantStringClassReference", referenced from:
CFString in coremedia_glue.o
CFString in videotoolbox_glue.o
CFString in avfoundation_glue.o
CFString in avfoundation_glue.o
CFString in avfoundation_glue.o
CFString in avfoundation_glue.o
CFString in avfoundation_glue.o
...
"__objc_empty_cache", referenced from:
_OBJC_METACLASS_$_AVCaptureDeviceGlue in avfoundation_glue.o
_OBJC_CLASS_$_AVCaptureDeviceGlue in avfoundation_glue.o
_OBJC_METACLASS_$_AVCaptureDeviceInputGlue in avfoundation_glue.o
_OBJC_CLASS_$_AVCaptureDeviceInputGlue in avfoundation_glue.o
"__objc_empty_vtable", referenced from:
_OBJC_METACLASS_$_AVCaptureDeviceGlue in avfoundation_glue.o
_OBJC_CLASS_$_AVCaptureDeviceGlue in avfoundation_glue.o
_OBJC_METACLASS_$_AVCaptureDeviceInputGlue in avfoundation_glue.o
_OBJC_CLASS_$_AVCaptureDeviceInputGlue in avfoundation_glue.o
"_kCFAllocatorDefault", referenced from:
media::WrapVideoFrameInCVPixelBuffer(media::VideoFrame const&) in video_frame_mac.o
media::video_toolbox::DictionaryWithKeysAndValues(void const**, void const**, unsigned long) in videotoolbox_helpers.o
media::video_toolbox::ArrayWithIntegers(int const*, unsigned long) in videotoolbox_helpers.o
media::video_toolbox::ArrayWithIntegerAndFloat(int, float) in videotoolbox_helpers.o
media::video_toolbox::CopySampleBufferToAnnexBBuffer(OpaqueCMSampleBuffer*, media::video_toolbox::AnnexBBuffer*, bool) in videotoolbox_helpers.o
"_kCFBooleanFalse", referenced from:
media::video_toolbox::SessionPropertySetter::Set(__CFString const*, bool) in videotoolbox_helpers.o
"_kCFBooleanTrue", referenced from:
media::video_toolbox::SessionPropertySetter::Set(__CFString const*, bool) in videotoolbox_helpers.o
"_kCFRunLoopCommonModes", referenced from:
media::PCMQueueInAudioInputStream::Open() in audio_input_mac.o
"_kCFTypeArrayCallBacks", referenced from:
media::video_toolbox::ArrayWithIntegers(int const*, unsigned long) in videotoolbox_helpers.o
media::video_toolbox::ArrayWithIntegerAndFloat(int, float) in videotoolbox_helpers.o
"_kCFTypeDictionaryKeyCallBacks", referenced from:
media::video_toolbox::DictionaryWithKeysAndValues(void const**, void const**, unsigned long) in videotoolbox_helpers.o
"_kCFTypeDictionaryValueCallBacks", referenced from:
media::video_toolbox::DictionaryWithKeysAndValues(void const**, void const**, unsigned long) in videotoolbox_helpers.o
"_objc_msgSend", referenced from:
(anonymous namespace)::CoreMediaLibraryInternal::CoreMediaLibraryInternal() in coremedia_glue.o
VideoToolboxGlue::Loader::Loader() in videotoolbox_glue.o
AVFoundationGlue::InitializeAVFoundation() in avfoundation_glue.o
(anonymous namespace)::LoadAVFoundationInternal() in avfoundation_glue.o
AVFoundationGlue::AVCaptureSessionClass() in avfoundation_glue.o
AVFoundationGlue::AVCaptureVideoDataOutputClass() in avfoundation_glue.o
+[AVCaptureDeviceGlue devices] in avfoundation_glue.o
...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
File "../../build/toolchain/mac/linker_driver.py", line 186, in <module>
Main(sys.argv)
File "../../build/toolchain/mac/linker_driver.py", line 68, in Main
subprocess.check_call(compiler_driver_args)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
raise CalledProcessError(retcode, cmd)
Original issue's description:
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
>
> Committed: https://crrev.com/f4683c359791bb0264cddddeca6b8bcae0e61817
> Cr-Commit-Position: refs/heads/master@{#399024}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807
Review-Url: https://codereview.chromium.org/2059493002
Cr-Commit-Position: refs/heads/master@{#399028}
Add @Override annotation to WebApkActivity#onStop()
BUG=None
Review-Url: https://codereview.chromium.org/2053783002
Cr-Commit-Position: refs/heads/master@{#399027}
[Android] Disable check_return when running exe tests.
Executable tests return a nonzero exit code on test failure, which is
fine from the test runner's perspective.
BUG=pdfium:415
Review-Url: https://codereview.chromium.org/2050473007
Cr-Commit-Position: refs/heads/master@{#399026}
Introduce --vr-shell flag on Android
BUG=617946
Review-Url: https://codereview.chromium.org/2030223002
Cr-Commit-Position: refs/heads/master@{#399025}
Make media/capture gn and gyps produce components
This CL separates media/capture into a component,
to allow, in a subsequent CL, linking with mojo for using
ImageCapture types.
This basically reproduces the media/cast and media/midi
structure.
Windows import/export issues made necessary to add
capture_export and associated CAPTURE_EXPORT macro,
again, replicating media/midi.
gn gen ... --check uncovered some transitive dependencies
during the "analyze" phase of the bots and I had to make
them explicit (e.g. media:gpu).
BUG=518807
Review-Url: https://codereview.chromium.org/2031073002
Cr-Commit-Position: refs/heads/master@{#399024}
Re-enable DexLoaderTests
https://codereview.chromium.org/2045313002/ fixed the bug with dx --incremental
causing the DexLoaderTests to fail on partial rebuilds of chrome_public_test_apk
BUG=617935
Review-Url: https://codereview.chromium.org/2056783002
Cr-Commit-Position: refs/heads/master@{#399023}
Roll src/third_party/catapult/ 4a98f56f9..b648cd04c (5 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4a98f56f9f14..b648cd04ccd9
$ git log 4a98f56f9..b648cd04c --date=short --no-merges --format='%ad %ae %s'
BUG=477056
[email protected]
Review-Url: https://codereview.chromium.org/2049923004
Cr-Commit-Position: refs/heads/master@{#399022}
Merge autofill::FormFieldData::is_checkable and is_checked
Currently, autofill::FormFieldData contains two Boolean data members:
* is_checked, and
* is_checkable.
As expected, the former can only be true when the latter is,
but the code makes this not clear.
We should merge these two Booleans into a single 3-valued enum representing the values:
not checkable, checkable but unchecked, checked.
BUG=614280
Review-Url: https://codereview.chromium.org/2022123002
Cr-Commit-Position: refs/heads/master@{#399021}
cc: Fix flaky RemoteChannelTest.ReleaseOutputSurfaceDuringCommit.
The test flakes because it expects only 1 BeginMainFrame to be sent from
the Scheduler and sets the expectations for commit count and output
surface initializations accordingly.
Update the test to perform the following:
1) When the first BeginMainFrame request is sent to the server, release
the output surface on the client. It would earlier do it for each
BeginMainFrame request, do it only for the first one.
2) Make sure that the first commit doesn't go through on the client
after the output surface is released till a new output surface is
initialized.
BUG=612562
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2042433002
Cr-Commit-Position: refs/heads/master@{#399020}
Use IsOS(OS_DOMAINMEMBER) to Check for Domain Membership
The IsOS check and the NetGetJoinInformation check are equivalent.
BUG=579196
Review-Url: https://codereview.chromium.org/2048083003
Cr-Commit-Position: refs/heads/master@{#399019}
Remove unused constructor for blink::GestureEvent.
BUG=none
Review-Url: https://codereview.chromium.org/2051623003
Cr-Commit-Position: refs/heads/master@{#399018}
Refactoring starting a resource load
Move most of Resource::load to a new ResourceFetcher::startLoad,
which is well-positioned to verify that FetchContext is still
valid. This also means that deferred loads call ResourceFetcher
to actually start the load, just as they called ResourceFetcher
to initialize the load.
BUG=603428
Review-Url: https://codereview.chromium.org/1889973002
Cr-Commit-Position: refs/heads/master@{#399017}
Update V8 to version 5.3.191.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ed450561..4a9c5195
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2051943002
Cr-Commit-Position: refs/heads/master@{#399016}
Clear the last focus time on losing focus.
This looks like an oversight to me, and the primary effect was to make a DCHECK
in OmniboxEditModel::OpenMatch() (that the edit had been focused) be mostly
ineffective.
I noticed this by inspection while debugging a different issue and haven't seen
concrete issues related to this.
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2040363002
Cr-Commit-Position: refs/heads/master@{#399015}
Fix DCHECK.
SuggestExactInput() was being called with the wrong value for |trim_http|. We
want to trim HTTP only when the user hasn't explicitly typed it, but instead we
were trying to trim it only _if_ the user explicitly typed it.
This has been wrong since this code was introduced in
https://codereview.chromium.org/58553003/ .
BUG=603839
TEST=In a debug build, use the omnibox to navigate to "http://ab cd" (no quotes). This should not DCHECK.
Review-Url: https://codereview.chromium.org/2046263002
Cr-Commit-Position: refs/heads/master@{#399014}
Refactor mipmap fn from SW IDC to shared util file
This allows GPU IDC to share this logic, which it needs to handle
display resolution scaling.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2037503003
Cr-Commit-Position: refs/heads/master@{#399013}
Cleanup: Initialize Value from tools/gn by moving std::string
Previously it used string::swap, but std::move is more effective in this case.
BUG=367418
TEST=
[email protected]
Review-Url: https://codereview.chromium.org/1350043004
Cr-Commit-Position: refs/heads/master@{#399012}
MD Settings: About page, fix bug causing update status message to not update.
The bug was twofold
1) Non ChromeOS data binding should not depend on targetChannel_, since
targetChannel_ is only defined for ChromeOS.
2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.
Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.
BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2050903002
Cr-Commit-Position: refs/heads/master@{#399011}
Attempt to deflake video-layer-crash.html.
This makes the test wait for layout and paint, instead of finishing the test as
soon as the seeked event is seen. Currently the Retina bot flakily produces the
frame previous to the one that is expected.
BUG=618693
Review-Url: https://codereview.chromium.org/2053793002
Cr-Commit-Position: refs/heads/master@{#399010}
Auto-rebaseline for r398970
https://chromium.googlesource.com/chromium/src/+/c30f46be5
BUG=618638
[email protected]
Review URL: https://codereview.chromium.org/2055963002 .
Cr-Commit-Position: refs/heads/master@{#399009}
Replicate WebInsecureRequestPolicy instead of a bool for strict mixed content checks.
This patch is huge, but fairly mechanically replaces the bool sitting on
the replicated frame state with WebInsecureRequestPolicy (which is currently
a bitfield, but will eventually be an enum once https://crbug.com/617584
is addressed). This bitfield holds both 'upgrade-insecure-requests' and
'block-all-mixed-content' state, which means we can take care of replicating
both in one shot.
[Step 1]: https://codereview.chromium.org/2046523005
[Step 2]: https://codereview.chromium.org/2040133003
[Step 3]: This patch.
BUG=617947
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2046733003
Cr-Commit-Position: refs/heads/master@{#399008}
Convert fast/repaint/window-resize*.html into reftests
to make rect under-invalidations more visible, and show
painting/rasterization errors if any.
BUG=600008
Review-Url: https://codereview.chromium.org/2039943003
Cr-Commit-Position: refs/heads/master@{#399007}
Revert of Chrome side Change for showing app info. (patchset #23 id:520001 of https://codereview.chromium.org/2022663002/ )
Reason for revert:
causing compile error here:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/45538
Original issue's description:
> Chrome side Change for showing app info.
>
> Add menu item "App info" for Arc app.
> Add function to send the intent to android side.
>
> BUG= b/27952403
> TEST= manual Test
> TEST= Update arc applist context menu unit_tests to cover new added context menu item for app info. Unit_tests passed.
>
> Committed: https://crrev.com/e0ccdc72e078990941c67c4376029c6dc93dd7ee
> Cr-Commit-Position: refs/heads/master@{#398953}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= b/27952403
Review-Url: https://codereview.chromium.org/2051223002
Cr-Commit-Position: refs/heads/master@{#399006}
Don't show navigation menu items when URI isnt accepted
Don't show "open in new window", "open in new tab", or "open in incognito tab" if URI isn't accepted.
BUG=618700
Review-Url: https://codereview.chromium.org/2048353004
Cr-Commit-Position: refs/heads/master@{#399005}
tools/android/loading Allow specifying 0 instances
As instance count of 0 was considered like a missing count, and leading
to automatic computation of the instance count.
This was not intended, as it can be useful to request 0 instances (for
testing).
Review-Url: https://codereview.chromium.org/2052903002
Cr-Commit-Position: refs/heads/master@{#399004}
[Media Router WebUI] Remove flex layout from cast button
The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.
BUG=618508
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2049953003
Cr-Commit-Position: refs/heads/master@{#399003}
lkgr: src-side change to enable goma on the Win ASan bots
https://codereview.chromium.org/2055623002 enabled goma on the Win ASan
bots build-side (i.e. compile.py now starts goma and builds with -j200).
Turn it on src-side as well so that gomacc gets actually used.
BUG=618425
Review-Url: https://codereview.chromium.org/2051073003
Cr-Commit-Position: refs/heads/master@{#399002}
For Offliner, pass in the URL from WebContents to SavePage request instead of the request URL since redirect link will fail a URL check in OfflinePageModelImpl.
This is workaround until better understand how to deal with redirected URLs for async loading.
BUG=618716
Review-Url: https://codereview.chromium.org/2052913002
Cr-Commit-Position: refs/heads/master@{#399001}
GN build of angle_end2end_tests on Android
BUG=angleproject:1362
TEST=Compile angle_end2end_tests
Review-Url: https://codereview.chromium.org/2043713003
Cr-Commit-Position: refs/heads/master@{#399000}
Misc. omnibox cleanup:
* NULL -> nullptr
* unix_hacker()-style functions should be inlined
* Add convenience wrapper in OmniboxEditModel for popup IsOpen() checks and use
it everywhere (this results in us adding null checks in a few places that
didn't have them, which is necessary for an upcoming change)
* UTF8ToUTF16() -> ASCIIToUTF16()
* Avoid using directives
* Collapse common setup in edit unittests into the test base class
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2048693003
Cr-Commit-Position: refs/heads/master@{#398999}
Roll src/third_party/skia/ 06ca8ec87..804b461bc (7 commits).
https://chromium.googlesource.com/skia.git/+log/06ca8ec87cf6..804b461bc4fe
$ git log 06ca8ec87..804b461bc --date=short --no-merges --format='%ad %ae %s'
2016-06-09 msarett SkPixmap::setColorSpace
2016-06-09 mtklein Add raw pixel serialization fallback for SkImages that cannot be encoded.
2016-06-09 mtklein Disable tail calls inside Simple GM functions.
2016-06-09 cblume SkMipMap::ComputeLevelSize should only cover SkMipMap's levels.
2016-06-09 brianosman Add control of manual mipmapping to GrContextOptions
2016-06-09 herb Simplify code by breaking general sampler into Nearest and Bilerp.
2016-06-09 mtklein better exclusion for stack traces
BUG=601851,578304
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2054923002
Cr-Commit-Position: refs/heads/master@{#398998}
Fix newly introduced flake in ExtensionPreferenceApiTest.Standard
BUG=614552
Review-Url: https://codereview.chromium.org/2030803002
Cr-Commit-Position: refs/heads/master@{#398997}
Remove bad expectations for layer-compositing-reasons.html.
BUG=618693
Review-Url: https://codereview.chromium.org/2050053006
Cr-Commit-Position: refs/heads/master@{#398996}
[Mac][Material]Update the text color on Guest Mode Chip
BUG=618506
Review-Url: https://codereview.chromium.org/2050303003
Cr-Commit-Position: refs/heads/master@{#398995}
Integrates the SnapshotController into the PrerenderingLoader to provide logic for determining when the right moment is to consider the page loaded and ready for snapshotting.
BUG=601173
Review-Url: https://codereview.chromium.org/2049743004
Cr-Commit-Position: refs/heads/master@{#398994}
Remove davidben from prerender WATCHLISTS.
I haven't been paying attention to these for a while.
BUG=none
Review-Url: https://codereview.chromium.org/2053663003
Cr-Commit-Position: refs/heads/master@{#398993}
[Typed OM] Implement FilteredComputedStylePropertyMap
This is needed for the CSS Paint API, as inside the paint callback only
properties listed as inputProperties should exist in the style map.
FilteredComputedStylePropertyMap takes a list of both the native and
custom properties and accessors will throw if the property isn't in this
list.
BUG=578252
Review-Url: https://codereview.chromium.org/2054633002
Cr-Commit-Position: refs/heads/master@{#398992}
Get Polymer externs from closure/github (instead of Polymer/bower)
[email protected]
[email protected] # for trivial path change
BUG=none
Review-Url: https://codereview.chromium.org/2052973002
Cr-Commit-Position: refs/heads/master@{#398991}
mash: Move SystemTrayDelegate and dependencies to //ash/common
These are dependencies of TrayUpdate, which I'm in the process of moving.
Creates a new directory for update-related code, //ash/common/system/update.
This is mostly a mechanical move:
* move_source_file.py ash/system/tray/system_tray_delegate.h ash/common/system/tray/
* move_source_file.py ash/system/tray/system_tray_delegate.cc ash/common/system/tray/
* move_source_file.py ash/system/tray/default_system_tray_delegate.h ash/common/system/tray/
* move_source_file.py ash/system/tray/default_system_tray_delegate.cc ash/common/system/tray/
* move_source_file.py ash/system/user/update_observer.h ash/common/system/update/
* move_source_file.py ash/volume_control_delegate.h ash/common/system/
* move_source_file.py ash/networking_config_delegate.h ash/common/system/
* move_source_file.py ash/networking_config_delegate.cc ash/common/system/
Removes a couple of unnecessary includes along the way.
BUG=615155
TEST=compiles
[email protected] for mechanical changes in //chrome
Review-Url: https://codereview.chromium.org/2056823002
Cr-Commit-Position: refs/heads/master@{#398990}
cc: Put to_target and to_screen behind an accessor.
Target-related information will eventually be removed from transform
tree and computed when needed.
This CL wraps the target-related information in transform tree in an
accessor, so that we can hide the implementations of the accessor, thus
we can make the code work with either the old way or the new way of
computing the information each time we need it.
BUG=597721
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2032213002
Cr-Commit-Position: refs/heads/master@{#398989}
Avoid full rebuild when using make
BUG=
Review-Url: https://codereview.chromium.org/2053443004
Cr-Commit-Position: refs/heads/master@{#398988}
tools/clang: Add an error if auto deduces to be a pointer type.
This patch ensures that when auto is used, it is not deduced to be a
pointer type, since that can lead to confusion when reading code.
BUG=554600
Review-Url: https://codereview.chromium.org/1691113003
Cr-Commit-Position: refs/heads/master@{#398987}
Change back to destroy the CDM synchronously
Outstanding promises may get rejected due to blink garbage collection
destroying all the remaining EME objects when they are no longer
referenced. The original fix destroyed the CDM asynchronously.
However, that causes problems as the CDM may hold references to
objects owned by RenderFrameImpl, and they may get accessed after
~RenderFrameImpl.
This fix posts a task to reject the promise asynchronously. That way
any outstanding promises that need to be rejected are handled after
gc is done. It affects all EME promise rejections (from Chromium).
Resolving promises is still done synchronously as there may be events
already posted that need to happen only after the promise is resolved.
BUG=597355
TEST=existing EME tests still pass
Review-Url: https://codereview.chromium.org/1987883002
Cr-Commit-Position: refs/heads/master@{#398986}
telemetry: Update tough_path_rendering_cases Chalkboard test URL
[Copy of https://codereview.chromium.org/1998543002/ by
[email protected] with the WPR uploaded.]
Update tough_path_rendering_cases Chalkboard test URL. The old
url would go to a page that would load the content in an iframe.
The injected script would fail.
Load the iframe URL instead. Loading the main document would inject
the script to the parent main document. The injected code would
start the test by click()ing an element cross domains, which
would be rejected.
Fixing is needed in order to record new content to
tough_path_rendering_cases.
BUG=594928
Review-Url: https://codereview.chromium.org/2055823004
Cr-Commit-Position: refs/heads/master@{#398985}
[ios] Use WebState instead of CRWWebController in JsInjectionManagerTest
BUG=None
Review-Url: https://codereview.chromium.org/2050203003
Cr-Commit-Position: refs/heads/master@{#398984}
Implements an empty hats dialog
Displays an empty hats dialog when the user clicks on 'Take Survey' in
the notification.
Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS
Review-Url: https://codereview.chromium.org/2048133002
Cr-Commit-Position: refs/heads/master@{#398983}
Supress failures on the WebGL 2 test deqp/functional/gles3/shaderderivate
This test already fails on Intel on all other platforms. ANGLE spews warnings about
undefined behaviour so there may be test bugs.
Broken since a WebGL conformance test roll: https://codereview.chromium.org/2041193007
BUG=483282
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2056763002
Cr-Commit-Position: refs/heads/master@{#398982}
MD Settings: Workaround for section expand/collapse animation jank.
Temporary workaround for crbug.com/617287 by using margin instead of padding.
The result is not 100% identical but is very close.
The transition bug this fixes is the jump right (and left) at the start (and
end) of the subpage open animations.
BUG=589681, 617287
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2041083002
Cr-Commit-Position: refs/heads/master@{#398981}
remoting: Turn off jitter buffer based smoothing
This change allows frames to be rendered as they are received at receiver.
This is depending on the CL for adaptive playout delay extension to go in.
BUG=
Review-Url: https://codereview.chromium.org/2049533002
Cr-Commit-Position: refs/heads/master@{#398980}
Rename net/http/transport_security_state_static.{certs -> pins} and update comments at the top.
BUG=
Review-Url: https://codereview.chromium.org/2049773006
Cr-Commit-Position: refs/heads/master@{#398979}
CommandBufferProxyImpl holds on to GpuMemoryBuffers while they are in use.
As soon as the GpuMemoryBuffer is destroyed, the cached GpuMemoryBuffer in the
browser process is also cleaned up, despite the fact that underlying IOSurface
is still usable. This keeps the GpuMemoryBuffer around in the child process as
long as there is an associated image.
BUG=581777
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2041043002
Cr-Commit-Position: refs/heads/master@{#398978}
Remove the CryptoAPI implementation of SHA-1
There are no performance wins for using it, due to the overheads
of acquiring a CryptoAPI/CNG context. Remove this codepath because
it's not used nor maintained.
BUG=none
Review-Url: https://codereview.chromium.org/2052713002
Cr-Commit-Position: refs/heads/master@{#398977}
Remove MessageLoop::current()->task_runner() in sync.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in sync.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2055473003
Cr-Commit-Position: refs/heads/master@{#398976}
Refactoring. This is the first step towards multiple tab support in Engine.
BUG=547231
Review-Url: https://codereview.chromium.org/2035543002
Cr-Commit-Position: refs/heads/master@{#398975}
Modify leveldb::DeleteRangeBasic function to return number of values deleted by IDBObjectStore.delete(range) with modifications to other functions as needed.
BUG=611201
Review-Url: https://codereview.chromium.org/1996443003
Cr-Commit-Position: refs/heads/master@{#398974}
Roll src/third_party/catapult/ 16b3f4ebd..4a98f56f9 (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/16b3f4ebdcbb..4a98f56f9f14
$ git log 16b3f4ebd..4a98f56f9 --date=short --no-merges --format='%ad %ae %s'
BUG=617547
[email protected]
Review-Url: https://codereview.chromium.org/2051893002
Cr-Commit-Position: refs/heads/master@{#398973}
[ios Mojo] Created MojoWebUIIOSController base class.
This class mirrors MojoWebUIController and should be used instead of
WebUIIOSController for Mojo implementations of WebUI.
BUG=566163
Review-Url: https://codereview.chromium.org/2039323002
Cr-Commit-Position: refs/heads/master@{#398972}
[css-grid] Fix percentage height on grid item's children
Grid items can be vertically stretched in that case
they store its height on LayoutBox::overrideLogicalContentHeight().
In order to resolve the percentage height on the grid item's children
we need to use that size.
BUG=612755
TEST=fast/css-grid-layout/percent-resolution-grid-item-children.html
Review-Url: https://codereview.chromium.org/2039223002
Cr-Commit-Position: refs/heads/master@{#398971}
Rebaseline svg/custom/relative-sized-image.xhtml one more time
It still fails on win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11147
BUG=618638
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2050203004
Cr-Commit-Position: refs/heads/master@{#398970}
MD User Manager: Refactors existing dialogs in User Manager into <user-manager-dialog>
BUG=563722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2024233003
Cr-Commit-Position: refs/heads/master@{#398969}
arc: update opt in flow message
BUG=b/28479598
Review-Url: https://codereview.chromium.org/2031973004
Cr-Commit-Position: refs/heads/master@{#398968}
aw: Diable testOnShowAndHideCustomView tests
Flaky on cq.
BUG=618749
[email protected]
Review-Url: https://codereview.chromium.org/2056793002
Cr-Commit-Position: refs/heads/master@{#398967}
Explain why ETW manifest needn't be compiled/linked in
The only absolutely essential thing generated from Chrome's ETW manifest
is a header file which is compiled by trace_event_etw_export_win.cc. The
rest is optional and I now document that in the gn file.
BUG=569989
Review-Url: https://codereview.chromium.org/2052593004
Cr-Commit-Position: refs/heads/master@{#398966}
Move isColorKeyword out of CSSPropertyParser
Move isColorKeyword out of CSSPropertyParser so that we do
not need to include CSSPropertyParser.h in CSSPropertyParserHelpers.
Review-Url: https://codereview.chromium.org/2041363002
Cr-Commit-Position: refs/heads/master@{#398965}
Extend the ToRenderFrameHost magic to FrameTreeNode* and Shell*.
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2052633002
Cr-Commit-Position: refs/heads/master@{#398964}
value_cleanup: fixup ListValue::Append() calls that already have a unique_ptr to use.
BUG=581865
Review-Url: https://codereview.chromium.org/2056573002
Cr-Commit-Position: refs/heads/master@{#398963}
sandwich: Reboot device on first WebSocketConnectionClosedException
On some devices, RemoteChromeController start to fail running
devices because of memory pressure. This CL address this issue
by letting SandwichRunner to reboot the android device.
BUG=582080
Review-Url: https://codereview.chromium.org/2051843002
Cr-Commit-Position: refs/heads/master@{#398962}
exo: Make the aura::Window a member of Surface.
In the future some Surfaces won't have aura windows (but will be
contained inside a parent surface), so as a first step make the
aura window a member variable instead of the parent class.
Review-Url: https://codereview.chromium.org/2052443004
Cr-Commit-Position: refs/heads/master@{#398961}
[PCv2] remove wildcard from tracing category filter
Before this CL, the chrome traced high-overhead categories like NetLog.
This CL removes wildcard from the tracing category filter so that PCv2
records tracing with minimal overhead.
BUG=618156
Review-Url: https://codereview.chromium.org/2057553002
Cr-Commit-Position: refs/heads/master@{#398960}
Remove boolean-based WaitableEvent constructor.
BUG=612843
[email protected]
Review-Url: https://codereview.chromium.org/2030683005
Cr-Commit-Position: refs/heads/master@{#398959}
In DevicePermissionsViewController disable Connect button if no device selected on Mac
When no device selected in the dialog, the "Connect" button needs to be
disabled.
BUG=613596
Review-Url: https://codereview.chromium.org/2058433002
Cr-Commit-Position: refs/heads/master@{#398958}
Add null check for tab accessibility description
Don't append the title for a tab's accessibility description if the
title is empty or null.
Test: chrome_junit_test (StripLayoutHelperTest).
BUG=616377
Review-Url: https://codereview.chromium.org/2045043004
Cr-Commit-Position: refs/heads/master@{#398957}
[Chromoting] TouchInputHandler now listens to events in DesktopView
This change is to continually decouple TouchInputHandler and DesktopView.
Instead of calling functions of TouchInputHandler from DesktopView, now
TouchInputHandler listens to a set of DesktopViewInterface events. So we can
have another implementation listens to the same events concurrently without
impacting current logic.
The advantages of this design are,
1. Eventually we do not need to modify mRenderData in DesktopView anymore, it
can also listen to onClientSizeChanged / onHostSizeChanged event.
2. We can have a dummy DesktopViewInterface to test other components.
3. We can forward exactly same events to several implementations, and compare
their outputs. For example, comparing the events generated by TouchInputHandler
and a new implementation.
This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.
BUG=615277
Review-Url: https://codereview.chromium.org/2047903002
Cr-Commit-Position: refs/heads/master@{#398956}
The units for the CanvasExpansion should be pixels
YCanvasExpansion and XCavnasExpansion both measure how much the image
canvas expanded due to first frame size being larger than canvas size.
The units are currently in bytes, but should be in pixels.
BUG=616582
Review-Url: https://codereview.chromium.org/2055633002
Cr-Commit-Position: refs/heads/master@{#398955}
PaymentRequest: Introduce PaymentMethodData.
This CL is introducing PaymentMethodData to combine the supported methods and
payment method specific data. By making this change it is possible to share an
instance of data amongst multiple payment methods that wasn't possible before.
Related spec links:
[1] https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-paymentmethoddata
[2] https://github.com/w3c/browser-payment-api/pull/162/commits/6d9c92e5d2bc82e4900823e9fa915a5be9584f6b
BUG=none
Review-Url: https://codereview.chromium.org/2020883002
Cr-Commit-Position: refs/heads/master@{#398954}
Chrome side Change for showing app info.
Add menu item "App info" for Arc app.
Add function to send the intent to android side.
BUG= b/27952403
TEST= manual Test
TEST= Update arc applist context menu unit_tests to cover new added context menu item for app info. Unit_tests passed.
Review-Url: https://codereview.chromium.org/2022663002
Cr-Commit-Position: refs/heads/master@{#398953}
views/mus: Reset the singleton Screen instance when ScreenMus dies.
This is causing some flaky crashes in views_mus_unittests.
BUG=577274
Review-Url: https://codereview.chromium.org/2052513003
Cr-Commit-Position: refs/heads/master@{#398952}
Stop propagating customscrollbar styles across iframe boundaries.
Stop propagating customscrollbar styles across iframe boundaries.
Currently we are applying the style of ownerLayoutObject style which is
throwing uneven behaviour while creatingcustom-scrollbar's for nested
IFrames. To Standardize this behaviour create custom-scrollbar if
IFrame body/document has ::-webkit-scrollbar selector else create
regular scrollbar.
BUG=531816
Review-Url: https://codereview.chromium.org/1340643004
Cr-Commit-Position: refs/heads/master@{#398951}
[Sync] Notify observers when IsSyncRequested goes from true to false.
BUG=618453
Review-Url: https://codereview.chromium.org/2047383004
Cr-Commit-Position: refs/heads/master@{#398950}
Revert of Update V8 to version 5.3.191. (patchset #1 id:1 of https://codereview.chromium.org/2053703002/ )
Reason for revert:
causing compile error here:
https://build.chromium.org/p/chromium/builders/Win/builds/44180
Bug filed here:
https://bugs.chromium.org/p/chromium/issues/detail?id=618757
Original issue's description:
> Update V8 to version 5.3.191.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/ed450561..a8931576
>
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> [email protected],[email protected],[email protected],[email protected]
>
> Committed: https://crrev.com/e4a4a8bc886a7aaf4ed4db4ee402145566c21cc6
> Cr-Commit-Position: refs/heads/master@{#398921}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2050333002
Cr-Commit-Position: refs/heads/master@{#398949}
cc : Push layer lists instead of layer tree at commit and activation
BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2051013002
Cr-Commit-Position: refs/heads/master@{#398948}
Change ui::Event::time_stamp from TimeDelta to TimeTicks
Event timestamp values are now consistently coming from the same clock as
base::TimeTicks. Historically this was not the case in particular on Windows
platform which is why we were using base::TimeDelta instead.
Now that this has been addressed we should use base::TimeTicks to make it clear
that these values are expected to come from the same clock and remove some
crufty code.
The changes in the CL are pretty simple and mechanical:
- Introduce a pair of conversion functions in ui/events/base_event_utils.h to
convert between WebInputEvent::timeStampSeconds (double) and
ui::Event::timeStamp (TimeTicks)
- TimeDelta() =>TimeTicks()
- TimeDelta::FromMilliseconds(0) => base::TimeTicks()
- TimeDelta::FromInternalValue(TimeTicks::Now().ToInternalValue()) => TimeTicks::Now()
- TimeDelta::FromMilliseconds(Time::Now().ToDoubleT() * 1000) => TimeTicks::Now()
- Time::NowFromSystemTime() - base::Time() => TimeTicks::Now()
BUG=453559
Review-Url: https://codereview.chromium.org/1975533002
Cr-Commit-Position: refs/heads/master@{#398947}
Upstream: Launch WebAPK without showing intent picker when user taps link in WebAPK scope
This CL surpresses the intent picker when:
- User navigates via a link
AND
- The URL falls in the scope of a WebAPK
AND
- The WebAPK is the only specialized handler for the URL
BUG=609122
TEST=ExternalNavigationHandlerTest.*
Review-Url: https://codereview.chromium.org/2035183002
Cr-Commit-Position: refs/heads/master@{#398946}
[DevTools] Enable DevToolsBeforeUnloadTest.TestDevToolsOnDevTools
[email protected]
BUG=497857
Review-Url: https://codereview.chromium.org/2055843002
Cr-Commit-Position: refs/heads/master@{#398945}
Fix invalid argument passed to Oobe.showSigninUI
In case SCREEN_ACCOUNT_PICKER screen is to be shown and pod row is
empty, the Oobe.showSigninUI method was previously going to be
called with an argument of invalid type.
BUG=
Review-Url: https://codereview.chromium.org/2048423002
Cr-Commit-Position: refs/heads/master@{#398944}
Start from clean state in DownloadTests
Clear all files that could conflict with the tests execution
from download directory.
BUG=618067
Review-Url: https://codereview.chromium.org/2043743004
Cr-Commit-Position: refs/heads/master@{#398943}
Add Mojo structs and StructTraits for //ui/events/devices.
Add structs for ui::InputDevice and ui::TouchscreenDevice so they can be
shared between processes. Add StructTraits for the structs for automatic
type conversions.
The Mojo structs used composition instead of inheritance, as inheritance
is unsupported.
BUG=601981
Review-Url: https://codereview.chromium.org/2054463002
Cr-Commit-Position: refs/heads/master@{#398942}
base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.
BUG=581865
[email protected]
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2051663003
Cr-Commit-Position: refs/heads/master@{#398941}
Fix typos on offline pages
Fix "kOfflinePageArchviesDirname" to "kOfflineArchivesDirname" at line 58 in chrome_constants.h
Fix "OfflienPageArchiver" to "OfflinePageArchiver" at line 46 in recent_tab_helper.h
BUG=618428
Review-Url: https://codereview.chromium.org/2041233007
Cr-Commit-Position: refs/heads/master@{#398940}
[css-grid] Fix a crash when inspecting grids with abs. positioned children
Absolute positioning occurs after layout of the grid and its in-flow
contents, and does not contribute to the sizing of any grid tracks or affect
the size/configuration of the grid in any way. This means that we should
treat as empty any grid whose only children are absolutely positioned items.
Since refs/heads/master@{#396192} empty grids are no longer internally
represented by a 1x1 matrix. As we were not considering
grids-with-only-absolutely-positioned-children as empty, we were trying to
access some invalid position in the internal representation of the grid
triggering a crash (or ASSERT in Debug) in the Vector code.
Review-Url: https://codereview.chromium.org/2049503005
Cr-Commit-Position: refs/heads/master@{#398939}
Remove inactive accounts from OWNERS: armansito, keybuk, rpaquay
These individuals are no longer performing reviews or submitting code
in the Chromium repository. Being in the OWNERS files confuses tools
such as git cl owners.
Review-Url: https://codereview.chromium.org/2030783002
Cr-Commit-Position: refs/heads/master@{#398938}
Notify the HTMLDocumentParser on document element available
This patch adds logic to the HTMLHtmlElement so that it can notify
the HTMLDocumentParser immediately when the document element is available.
This is triggered in HTMLHtmlElement::insertedByParser. Additionally,
logic to dispatch notifications to the embedder is refactored into
insertedByParser.
insertedByParser initializes the ApplicationCache, then sends the
notification to the HTMLDocumentParser to issue any queued preloads (the
preloads wait for ApplicationCache so they don't download needlessly).
Next, the method dispatches notifications to embedders, via
FrameLoader::dispatchDocumentElementAvailable and
FrameLoader::runscriptsAtDocumentAvailable.
Note the latter is used by extensions, which can run extremely expensive
content scripts. This patch changes ordering so that preloads can be sent
before this happens.
BUG=618101
Review-Url: https://codereview.chromium.org/2042413002
Cr-Commit-Position: refs/heads/master@{#398937}
Fix cras_input_unittest.cc fails on BadBitsPerSample
The reason is when CrasInputStream::Open() meets badbitsformat or badsamplerate, |client_| will still be nullptr. The Close() will first call Stop(), which has a DCHECK not null.
BUG=616982
Review-Url: https://codereview.chromium.org/2031183002
Cr-Commit-Position: refs/heads/master@{#398936}
Documentation: Add .gni and .mojom in Eclipse setup instructions.
Adding .gni and .mojom to the list of files which should be included in the Eclipse project.
BUG=NONE
Review-Url: https://codereview.chromium.org/2049923003
Cr-Commit-Position: refs/heads/master@{#398935}
Moves Add/RemoveShellObserver onto WmShell
Also adds the two OnOverviewMode calls to WmShell.
BUG=581868
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2051133002
Cr-Commit-Position: refs/heads/master@{#398934}
Added missing pen tilt when creating PointerEvent from ME.
Added back the missing plumbing. Also added EventSender support to pass stylus
info for testing.
BUG=593850
Review-Url: https://codereview.chromium.org/2043053002
Cr-Commit-Position: refs/heads/master@{#398933}
Use 1.25 DSF by default for new users on FHD mid-density
BUG=516246
TEST=covered by unitests. Also tested on peach_pi
Review-Url: https://codereview.chromium.org/2044833003
Cr-Commit-Position: refs/heads/master@{#398932}
gl: Test YV12 buffer drm import.
Adds a test to check that importing YV12 format created via drm works
and that it is possible to draw after creating an EGL image backed by
them.
BUG=618516
TEST=gl_unittests on samus.
Review-Url: https://codereview.chromium.org/2052543004
Cr-Commit-Position: refs/heads/master@{#398931}
Remove MessageLoop::current()->task_runner() in net.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in net.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2052673002
Cr-Commit-Position: refs/heads/master@{#398930}
Report hash of Chrome's parent process name.
This is in order to try and correlate Chrome stability with parent
process name.
BUG=385714
Review-Url: https://codereview.chromium.org/2055613002
Cr-Commit-Position: refs/heads/master@{#398929}
[ios] Removed WebClient::PostWebViewCreation.
This function is unused after UIWebView support has been dropped.
BUG=579697
Review-Url: https://codereview.chromium.org/2057653002
Cr-Commit-Position: refs/heads/master@{#398928}
Fix two more compile errors for WaitableEvent boolean-based constructor removal.
Caught by dry-run @ https://codereview.chromium.org/2030683005/
BUG=612843
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2050283002
Cr-Commit-Position: refs/heads/master@{#398927}
Remove MaxSharedMemorySize() function from SysInfo
It is not used anywhere, and is only supported on some platforms. In
addition, it synchronously reads a file during Zygote startup.
Last use was removed in 2014: 1cf03f7f0c2eff4e34b6d6e4a088dcbd762ee9b9
BUG=
Review-Url: https://codereview.chromium.org/2054593002
Cr-Commit-Position: refs/heads/master@{#398926}
Deflake inspector/layers/layer-compositing-reasons.html
BUG=618693
Review-Url: https://codereview.chromium.org/2048133004
Cr-Commit-Position: refs/heads/master@{#398925}
scheduler: Enable expensive task blocking by default
BUG=598248,574343,581039
Review-Url: https://codereview.chromium.org/2025863002
Cr-Commit-Position: refs/heads/master@{#398924}
build: make views_examples targets buildable with gn
This change makes these targets conditional on toolkit_views instead of
specific OSes, and makes includes of //ui/wm and //ui/aura conditional on
use_aura.
BUG=431177
Review-Url: https://codereview.chromium.org/2051823004
Cr-Commit-Position: refs/heads/master@{#398923}
Implement MediaMetadata artwork in Blink
This CL adds artwork in MediaMetadata in Blink.
The artwork info will be propagated to the browser through MediaMetadata, and we will finally fetch the image and display it in media notification.
Discussion for the spec:
https://github.com/whatwg/mediasession/pull/129
Related CLs:
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2014553002/
https://codereview.chromium.org/2009243002/
BUG=616411
Review-Url: https://codereview.chromium.org/2013813002
Cr-Commit-Position: refs/heads/master@{#398922}
Update V8 to version 5.3.191.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ed450561..a8931576
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2053703002
Cr-Commit-Position: refs/heads/master@{#398921}
getChannelData() should return the same object
Previously each call to getChannelData would return a new object (but
backed by exactly the same data).
BUG=580724
TEST=audiobuffer-getChannelData.html
Review-Url: https://codereview.chromium.org/1684263002
Cr-Commit-Position: refs/heads/master@{#398920}
Roll src/third_party/skia/ 0b04fea22..06ca8ec87 (2 commits).
https://chromium.googlesource.com/skia.git/+log/0b04fea22851..06ca8ec87cf6
$ git log 0b04fea22..06ca8ec87 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 bungeman sk_sp for Ganesh.
2016-06-09 kjlubick Add ICC fuzzer
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2041233008
Cr-Commit-Position: refs/heads/master@{#398919}
tools/android/loading: Add possibility to delay url monitoring tear down
On website finishing loading resources through javascript such as
amazon.com, the WPR archive were not recording all these resources
because were stoping at devtools' load page finish event. These
miss recording resources were leading to unprecise loading times
on benchmark using the WPR archive, because all the requests for
these resources were getting light weight 404 back.
This CL fixes the issue by implementing the stop_delay_multiplier
in the loading_trace.LoadingTrace.RecordUrlNavigation().
BUG=582080
Review-Url: https://codereview.chromium.org/2049673002
Cr-Commit-Position: refs/heads/master@{#398918}
Fix ProcessUtilTest.GetParentProcessId to use correct call.
base::GetParentProcessId takes a ProcessHandle so should be called with
the result of base::GetCurrentProcessHandle() not base::GetCurrentProcId().
BUG=None
Review-Url: https://codereview.chromium.org/2055443002
Cr-Commit-Position: refs/heads/master@{#398917}
Pressing ContextMenu key should scroll focused Element to view
Focused Element should be scrolled to view when pressing ContextMenu key,
otherwise ContextMenu will be displayed off-screen.
Interop:
When the focused Element is off-screen,
* Edge display ContextMenu on the top-left corner;
* Firefox scroll the Element to top or bottom edge.
We match Firefox but scroll the Element to center, which matches our
text insertion scroll.
Also note that scroll was handled in 'keydown' event (match FF), so
1. Mouse right click won't be affected;
2. Preventing 'contextmenu' won't prevent scroll;
3. Does not match our text insertion scroll, which was handled in 'textInput' event.
BUG=323152
Review-Url: https://codereview.chromium.org/2047493003
Cr-Commit-Position: refs/heads/master@{#398916}
Disable latimes.com from power.tough_ad_cases.
Failing on android.
[email protected]
BUG=618708
Review-Url: https://codereview.chromium.org/2057623002
Cr-Commit-Position: refs/heads/master@{#398915}
[NTP Snippets] More reliable service initialization
The service was trying to guess if it should be enabled or not
during its initialization if the sync state was not available.
We now wait until the sync service is up to change states.
BUG=618361,618280
Review-Url: https://codereview.chromium.org/2051823003
Cr-Commit-Position: refs/heads/master@{#398914}
Remove MessageLoop::current()->task_runner() in services.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in services.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2052653003
Cr-Commit-Position: refs/heads/master@{#398913}
[Android] Make android templates in build/ usable without java.
BUG=pdfium:38
Review-Url: https://codereview.chromium.org/2048133003
Cr-Commit-Position: refs/heads/master@{#398912}
Remove skia::RefPtr
Chrome's skia::RefPtr has been replaced by Skia's sk_sp<>.
Previous CLs have fixed all uses; this removes the class.
[email protected]
[email protected]
BUG=skia:5077
Review-Url: https://codereview.chromium.org/2048173003
Cr-Commit-Position: refs/heads/master@{#398911}
Factors an arena class out of SpdyHeaderBlock. After discussion with bnc@, we decided that this was simpler than importing the arena implementation from CTemplate.
This CL lands server change 116142657 by birenroy.
BUG=488484
Review-Url: https://codereview.chromium.org/2041093005
Cr-Commit-Position: refs/heads/master@{#398910}
WebmMuxer: handle Add{Audio,Video}Track error return
See bug, but essentially fuzzer discovered cases where
mkvmuxer::Segment::Add{Audio,Video}Track would fail and
we just have a DCHECK for it. This CL handles this case
explicitly.
BUG=616391
Review-Url: https://codereview.chromium.org/2048413002
Cr-Commit-Position: refs/heads/master@{#398909}
[Android, Settings] Fix NPE when both media related site settings are enabled
Only look for AUTOPLAY preference if it's the only one enabled.
BUG=618439
TEST=manual
Review-Url: https://codereview.chromium.org/2052613002
Cr-Commit-Position: refs/heads/master@{#398908}
Migrate some DeviceUtils clients to List/StatDirectory
Migrate some previous uses of the (now deprecated) Ls method, and
instances of hand rolled shell 'ls' commands to the new available
methods.
Also a bit of cleanup on RunShellCommand uses.
BUG=552376
Review-Url: https://codereview.chromium.org/2045833004
Cr-Commit-Position: refs/heads/master@{#398907}
Add pointers from README files in /services to documentation on the wiki and in docs.
BUG=618411
Review-Url: https://codereview.chromium.org/2049973002
Cr-Commit-Position: refs/heads/master@{#398906}
Autoplay: disable muted video autoplay if data saver is on.
BUG=607551
[email protected]
Review-Url: https://codereview.chromium.org/2046403002
Cr-Commit-Position: refs/heads/master@{#398905}
Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
Reason for revert:
This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
Original issue's description:
> Flip Linux bots on chromium.lkgr to GN.
>
> [email protected], [email protected]
> BUG=605732
>
> Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> Cr-Commit-Position: refs/heads/master@{#398038}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605732
Review-Url: https://codereview.chromium.org/2054843002
Cr-Commit-Position: refs/heads/master@{#398904}
Remove MessageLoop::current()->task_runner() in android_webview.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in android_webview.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2053503002
Cr-Commit-Position: refs/heads/master@{#398903}
Removing some simple methods from ChromeLauncherController API.
Removing IsLoggedInAsGuest(), CreateNewWindow(), CreateNewIncognitoWindow().
They are all trivial. This reduces the API surface of ChromeLauncherController,
making the Mustash implementation a tad easier.
BUG=NONE
Review-Url: https://codereview.chromium.org/2045273004
Cr-Commit-Position: refs/heads/master@{#398902}
Auto-rebaseline for r398877
https://chromium.googlesource.com/chromium/src/+/3095dfc61
BUG=618638
[email protected]
Review URL: https://codereview.chromium.org/2056583003 .
Cr-Commit-Position: refs/heads/master@{#398901}
gl: Add YVU_420 support to GLImageOzoneNativePixmap.
This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.
BUG=618516
TEST=crrev.com/2052543004
Review-Url: https://codereview.chromium.org/2055483002
Cr-Commit-Position: refs/heads/master@{#398900}
[Layout API] Use Document::layoutViewItem in LayoutPart
Document::layoutView is being removed (replaced by layoutViewItem).
As this file is already in core/layout/, there's no harm in busting
through the block layout API to get the underlying layout view from
Document::layoutViewItem.
BUG=499321
Review-Url: https://codereview.chromium.org/2054793002
Cr-Commit-Position: refs/heads/master@{#398899}
WebUI: Fix lifecycle-bug when RenderFrameHost is swapped out
Currently, once the RenderFrameHost is swapped out, WebUI C++ -> JS
calls will trigger a crash.
These C++ -> JS calls are usually triggered by an observer action that
occurs on navigation. (For instance, updating the list of cookies in
the settings UI.)
This patch calls WebUIMessageHandler::DisallowJavascript once Swap Out
begins. This is a quick fix to the issue.
The ideal fix would be to make WebUI have a pointer to its owning
RenderFrameHost. However, that will have to wait until the UberUI is
removed.
BUG=615274
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2041993002
Cr-Commit-Position: refs/heads/master@{#398898}
Unregister ChromeLauncherPrefsObserver after it syncs the prefs and is no longer needed.
ChromeLauncherPrefsObserver only needs to update the prefs once during the
first run. No need to keep it registered after that.
BUG=NONE
Review-Url: https://codereview.chromium.org/2044163003
Cr-Commit-Position: refs/heads/master@{#398897}
Combobox: detailing, part 1
This change:
* Redoes the enabled combobox arrow image
* Adds a disabled combobox arrow image
* Adds a notion of platform-defined fixed height and arrow container width
for comboboxes
* Adds support in comboboxes for arrow images to contain padding, in which case
the combobox painting code will not add more padding
* Changes the font size for comboboxes to always be the "base" font size
instead of the "label" font size (they only differ on Mac anyway)
* Flattens the combobox background gradient to match the mocks
* Changes ComboboxBackgroundMac to special-case disabled comboboxes, for which
the entire combobox uses the background shader, not just the arrow container
Still to do:
* The borders are flat color rings, instead of having separate colors for their
sides
* Borders are drawn around the arrow container, which should not happen
These will be fixed in a followup CL.
BUG=543683
Review-Url: https://codereview.chromium.org/2036903002
Cr-Commit-Position: refs/heads/master@{#398896}
Roll src/third_party/skia/ a058786ae..0b04fea22 (2 commits).
https://chromium.googlesource.com/skia.git/+log/a058786ae3cd..0b04fea22851
$ git log a058786ae..0b04fea22 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 rmistry Update CQ keywords documentation
2016-06-09 msarett SkColorSpace::NewICC fix integer overflow caught by fuzzer
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2054803002
Cr-Commit-Position: refs/heads/master@{#398895}
tools/android/loading: Fix TCP listening port collision in RemoteChromeController
Before when using the RemoteChromeController, the TCP host to
device forwarder was set up to listen on OPTIONS.devtools_port.
The issue was that Sandwich was then failing when recording traces
on several devices from the same host.
This CL fixes the issue as Telemetry did by allocating a port number
using a socket getting its listening port number assigned by the OS.
This solution is OS level racy, but in case of failure, the
exception is caught and the devtool connection is retried
automatically within RemoteChromeController.Open().
BUG=582080
Review-Url: https://codereview.chromium.org/2044703005
Cr-Commit-Position: refs/heads/master@{#398894}
Remove MessageLoop::current()->task_runner() in media.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in media.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2040383004
Cr-Commit-Position: refs/heads/master@{#398893}
Remove MessageLoop::current()->task_runner() in blimp.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in blimp.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2048213002
Cr-Commit-Position: refs/heads/master@{#398892}
Prevent Null input in texSubImage2D(3D)
In a previous CL which packs some repeated code into helper functions,
I made a mistake so that tex(Sub)Image2D(3D) can always take null input
for DOMArrayBufferView. However, I took a look at the original code
before my change, it turns out that texImage2D and texImage3D is allowed
to take null input, but texSubImage2D and texSubImage3D is not allowed.
The stack trace in the bug also suggests that it crashes
because the input is null.
This CL makes change for that.
BUG=618299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2046223003
Cr-Commit-Position: refs/heads/master@{#398891}
Mac: Retain the child NSWindow in WidgetOwnerNSWindowAdapter before invoking close
AppKit has gotten better at handling the last reference to an NSWindow
going away inside -[NSWindow close]. However, on 10.9, bad things can
happen if we don't retain the NSWindow being closed until after the
-[NSWindow close] call returns.
WidgetOwnerNSWindowAdapter::OnWindowWillClose() wasn't doing this. The
result: in some codepaths, a zombie access under the close call.
To fix, retain the window being closed.
BUG=616701
TEST=On OSX 10.9, have one browser tab, navigate to a page (e.g.
chrome://version), then press Backspace. The "Press Cmd+Left to go back"
bubble should appear. Wait for it to fade out completely. Then close the
tab via the tabstrip. Chrome shouldn't crash.
Review-Url: https://codereview.chromium.org/2056593002
Cr-Commit-Position: refs/heads/master@{#398890}
Move Fullscreen static helpers to an anonymous namespace
[email protected]
Review-Url: https://codereview.chromium.org/2053673002
Cr-Commit-Position: refs/heads/master@{#398889}
Remove MessageLoop::current()->task_runner() in google_apis.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in google_apis.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2050443004
Cr-Commit-Position: refs/heads/master@{#398888}
[Blink, HTMLMediaElement] Fix ASSERT in ScriptPromiseResolver dtor
Don't get promise() from the resolver if it's not used.
BUG=618429
TEST=the test page from the bug.
Review-Url: https://codereview.chromium.org/2047313004
Cr-Commit-Position: refs/heads/master@{#398887}
Worker: Introduce an observation mechanism for WorkerThread termination
This mechanism provides a way to observe WorkerThread termination from the main
thread. This is useful when an object living on the main thread needs to release
references to objects on the worker thread before it gets terminated.
As an example of using this mechanism, this CL applies it to WebSocket.
WorkerWebSocketChannel::Peer observes worker thread termination from the main
thread and asks DocumentWebSocketChannel to release references to objects on the
worker thread when the termination happens.
Design doc: https://docs.google.com/document/d/1rYFKem6SwghdISe_to5b4apORIKqjOpsV5FkE3f5WQ0/edit
BUG=575532
Review-Url: https://codereview.chromium.org/2025783002
Cr-Commit-Position: refs/heads/master@{#398886}
[Layout API] use Frameview::layoutViewItem in AXLayoutObject
This requires the use of the block layout API shim, just as we did with
the line layout API.
BUG=499321
Review-Url: https://codereview.chromium.org/2048823006
Cr-Commit-Position: refs/heads/master@{#398885}
[Mac/GN] Add //build/config/mac/package_framework.py.
This moves another step performed by gyp-mac-tool into a standalone script. In
addition, support for more top-level bundle directories (e.g. Helpers, XPCServices,
etc.) is added.
BUG=616813,604809
[email protected]
Review-Url: https://codereview.chromium.org/2055673002
Cr-Commit-Position: refs/heads/master@{#398884}
Make Windows Chrome first run record default UMA checkbox state.
This value is plumbed through the -statsdef:1 or -statsdef:0 tag in
the "ap" param. This CL makes the value get picked up during
Chrome first run on Windows.
If not set in the "ap" tag, it means we don't know what the default
state is, which is the default value in UMA and we do not need to
set it.
BUG=596185
Review-Url: https://codereview.chromium.org/2041923002
Cr-Commit-Position: refs/heads/master@{#398883}
Roll src/third_party/catapult/ e3cd126c1..16b3f4ebd (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e3cd126c10a4..16b3f4ebdcbb
$ git log e3cd126c1..16b3f4ebd --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2055613003
Cr-Commit-Position: refs/heads/master@{#398882}
Wire up the Chrome Sign In modal dialog from the password bubble promo.
The promo is still disabled as the Finch config isn't created.
BUG=615825
Review-Url: https://codereview.chromium.org/2049683002
Cr-Commit-Position: refs/heads/master@{#398881}
[Mac/iOS/GN] copy_bundle_data.py should preserve symlinks.
Bundled directory structures use symlinks relative to other components in the
bundle, and those should be preserved as symlinks, rather than copying the
file contents.
BUG=297668,604809
[email protected]
Review-Url: https://codereview.chromium.org/2050963002
Cr-Commit-Position: refs/heads/master@{#398880}
Replace SecurityContext::InsecureRequestsPolicy with WebInsecureRequestPolicy.
Introduced in https://codereview.chromium.org/2046523005, WebInsecureRequestPolicy
aims to represent the complete policy set by a context for insecure
requests. This patch expands its usage from //core/frame/csp to encompass
all of blink, replacing 'SecurityContext::InsecureRequestsPolicy' and
the strict mixed content checking boolean in various bits of our loading
infrastructure.
The next step will be to replicate this bitfield to remote frames instead
of replicating the strict mixed content checking boolean.
[Step 1]: https://codereview.chromium.org/2046523005
[Step 2]: This patch.
[Step 3]: https://codereview.chromium.org/2046733003
BUG=617947
[email protected]
Review-Url: https://codereview.chromium.org/2040133003
Cr-Commit-Position: refs/heads/master@{#398879}
Try to remove Dr.Memory suppression for issue 618265.
BUG=618265
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2052633003
Cr-Commit-Position: refs/heads/master@{#398878}
Rebaseline svg/custom/relative-sized-image.xhtml again
It is still failing on Win10 after first rebaseline here
https://codereview.chromium.org/2046123005
BUG=618638
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2050253002
Cr-Commit-Position: refs/heads/master@{#398877}
Remove the use of KeyEvent.keyIdentifier.
We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still depends on keyIdentifier, but it should be handled in a separate CL.
BUG=612717
TEST=run browser_tests
Review-Url: https://codereview.chromium.org/1994563002
Cr-Commit-Position: refs/heads/master@{#398876}
Remove LayerImpl::synced_scroll_offset declarations.
The implementation was removed in https://codereview.chromium.org/1803643002
and presumably the declaration was forgotten.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2051443004
Cr-Commit-Position: refs/heads/master@{#398875}
Remove all uses of skia::RefPtr
Finish deprecating skia::RefPtr in favor of sk_sp<>.
This should significantly reduce the amount of manual reference
management Chromium and Blink authors need to do for Skia objects.
We still have some APIs vending raw pointers to ref-counted Skia
objects which will need to be wrapped in sk_sp<>, but that should
be easier and more predictable. This CL does *not* try to remove
all cases of raw pointers to Skia objects in Chromium.
BUG=skia:5077
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1923943002
Cr-Commit-Position: refs/heads/master@{#398874}
Revert of [CacheStorage] Clean up CacheStorageCache lifetimes (patchset #3 id:60001 of https://codereview.chromium.org/2040173002/ )
Reason for revert:
Rather than carefully control the lifetimes of the refptrs, I'm going to give explicit ownership of caches to CacheStorage so that on ~CacheStorage the caches die. CacheStorage will give clients handles to the caches (that extend the lifetime but not past destruction).
Original issue's description:
> [CacheStorage] Clean up CacheStorageCache lifetimes
>
> CacheStorageCache refptrs are held in callbacks to cache operations, meaning that they won't be destructed
> on profile shutdown. This CL moves the refptrs to member variables so that they will.
>
> BUG=617683
>
> Committed: https://crrev.com/f9b13e0a9790f868a54ad4f3d1268d7369239ed4
> Cr-Commit-Position: refs/heads/master@{#398529}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617683
Review-Url: https://codereview.chromium.org/2040373006
Cr-Commit-Position: refs/heads/master@{#398873}
Mark inspector/layers/layer-compositing-reasons.html as flaky
BUG=618693
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2049793004
Cr-Commit-Position: refs/heads/master@{#398872}
Remove MessageLoop::current()->task_runner() in device.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in device.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2046843006
Cr-Commit-Position: refs/heads/master@{#398871}
Label video-layer-crash.html as flaky on Mac10.11 retina
BUG=618693
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2049793003
Cr-Commit-Position: refs/heads/master@{#398870}
Update V8 to version 5.3.190.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2f0cd4e0..ed450561
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2056723002
Cr-Commit-Position: refs/heads/master@{#398869}
More WaitableEvent stragglers migrated to enum-based constructor
Previous manual regex was finding "new WaitableEvent(...)" and
"...event_(...)", i.e. heap allocs and initializer lists but
was missing stack variables.
This change uses the following regex to catch those and manually fix them:
"WaitableEvent\ [\w]+\((true|false),"
Also fixed missing space presubmit error in media_message_fifo_unittest.cc
BUG=612843
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2043303004
Cr-Commit-Position: refs/heads/master@{#398868}
Roll src/third_party/skia/ a9e878c83..a058786ae (1 commit).
https://chromium.googlesource.com/skia.git/+log/a9e878c83699..a058786ae3cd
$ git log a9e878c83..a058786ae --date=short --no-merges --format='%ad %ae %s'
2016-06-09 bsalomon Make SkDashPathEffect fail for stroke+fill style (in addition to fill style) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2052863002
Cr-Commit-Position: refs/heads/master@{#398867}
Move ReferenceFilterBuilder::build to FilterEffectBuilder
This function resolves a filter reference and then builds a filter
(sub)DAG for painting. Split it into the two fairly distinct parts,
leaving ReferenceFilterBuilder as a class that only does element
lookup/resolution, while the DAG-building takes place in
FilterEffectBuilder (with a little help from SVGFilterBuilder.)
Use the new function in SVGFilterPainter.
Also pass Element& to ReferenceFilterBuilder::build, and remove a
redundant null-check of ComputedStyle in
PaintLayer::updateOrRemoveFilterEffectBuilder (already checked by
paintsWithFilters and assumed later in the function.)
BUG=109224,533457
Review-Url: https://codereview.chromium.org/2044153002
Cr-Commit-Position: refs/heads/master@{#398866}
MD User Manager: "Select an account" should just be a label not a menu entry
BUG=618151
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2047383003
Cr-Commit-Position: refs/heads/master@{#398865}
Remove dead code: mojom CheckerboardQuadState
It doesn't look like CheckerboardQuadState is used anymore so this CL
removes it.
BUG=611802
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2056703002
Cr-Commit-Position: refs/heads/master@{#398864}
Remove MessageLoop::current()->task_runner() in ios.
This CL replaces MessageLoop::current()->task_runner() with
ThreadTaskRunnerHandle::Get() in ios.
In files where this replacement is made, it adds these include:
#include "base/threading/thread_task_runner_handle.h"
#include "base/location.h" (if required)
#include "base/single_thread_task_runner.h" (if required)
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will have access to
a ThreadTaskRunnerHandle.
Steps to generate this patch:
1. Run message_loop_cleanup_2.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2054563002
Cr-Commit-Position: refs/heads/master@{#398863}
Remove enable/disable wheel gestures setting.
Since wheel gesture based scrolling has shipped and the code has been
removed from blink we can remove the runtime setting.
BUG=598798
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f
Review-Url: https://codereview.chromium.org/2047093002
Cr-Original-Commit-Position: refs/heads/master@{#398716}
Cr-Commit-Position: refs/heads/master@{#398862}
Worker: Remove unnecessary indirection on WorkerThread::postTask()
This is just a cleanup. This should not change any behavior.
BUG=n/a
Review-Url: https://codereview.chromium.org/2054703003
Cr-Commit-Position: refs/heads/master@{#398861}
Roll WebRTC 13070:13089
Also removes reference to removed file dtlsidentitystore.cc from libjingle's buildfiles.
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/393886f..cb6b288
[email protected]
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2049343003
Cr-Commit-Position: refs/heads/master@{#398860}
MD User Manager: Reauthenticate custodian
BUG=563722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2035883002
Cr-Commit-Position: refs/heads/master@{#398859}
Auto-rebaseline for r398841
https://chromium.googlesource.com/chromium/src/+/773ae64e0
BUG=618638
[email protected]
Review URL: https://codereview.chromium.org/2046123005 .
Cr-Commit-Position: refs/heads/master@{#398858}
WebRTCCertificateGenerator dropping unused URL parameters.
Non-functional clean-up. The generator previously needed "url" and
"first party for cookies" because its implementation was using an identity store
that had access to storage for caching. The implementation has since been
replaced not to do this and the parameters are unused. So this CL removes them.
BUG=webrtc:5708, webrtc:5707
Review-Url: https://codereview.chromium.org/2030373002
Cr-Commit-Position: refs/heads/master@{#398857}
Reorganize bindings test IDL files
Rename the various IDL files used to test bindings for partial interfaces.
The intent is to make it clearer which files are extending a particular
interface. The naming convention follows the suggestion in an earlier CL:
https://codereview.chromium.org/1884423002/#msg20
This prepares for a subsequent CL to fix the bindings for partial
interfaces for the [OriginTrialEnabled] extended attribute.
BUG=585656
Review-Url: https://codereview.chromium.org/2049843003
Cr-Commit-Position: refs/heads/master@{#398856}
[Media, Autoplay] Add UMA to record autoplay source
This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.
BUG=617948
Review-Url: https://codereview.chromium.org/2044373002
Cr-Commit-Position: refs/heads/master@{#398855}
pointerevent_button_attribute_mouse-manual.html also times out
In https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/13415/steps/webkit_tests/logs/stdio the test also timed out.
BUG=612924
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2043963008
Cr-Commit-Position: refs/heads/master@{#398854}
headless: Introduce a browser context
A headless browser context can be used to isolate different WebContents
from one another. Each context has a separate cache, cookies, local
storage and other profile-related data.
This patch also adds a way to create a HeadlessWebContents using a
specific browser context instead of the default one. This can be used to
isolate tabs from one another.
Design doc: https://docs.google.com/document/d/1XAKvrxtSEoe65vNghSWC5S3kJ--z2Zpt2UWW1Fi8GiM/edit?pref=2&pli=1#heading=h.7r3ycehq63g2
BUG=546953,617931
Review-Url: https://codereview.chromium.org/2043603004
Cr-Commit-Position: refs/heads/master@{#398853}
Update autoplay settings when moving media elements between documents
BUG=617098
Review-Url: https://codereview.chromium.org/2047433003
Cr-Commit-Position: refs/heads/master@{#398852}
Delete the non-static CLD data source logic.
This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-data-source-configuration
Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.
CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.
This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/
It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.
BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2034413003
Cr-Commit-Position: refs/heads/master@{#398851}
Disable AudioPlayerBrowserTest.ChangeTracks for flakyness
BUG=618198
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2053663002
Cr-Commit-Position: refs/heads/master@{#398850}
Disable failing layout tests
BUG=612924
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2053653002
Cr-Commit-Position: refs/heads/master@{#398849}
media: Remove logMedia from WTFLogChannel
Removed logMedia from WTFLogChannel as all WTF_LOGs are replaced
with DVLOGs in media modules. Few WTF_LOGs are still present in
HTMLMediaElement.cpp and removed them as well in this CL.
BUG=596522
Review-Url: https://codereview.chromium.org/2046473002
Cr-Commit-Position: refs/heads/master@{#398848}
Roll src/third_party/catapult/ 20c004c9f..e3cd126c1 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/20c004c9fccd..e3cd126c10a4
$ git log 20c004c9f..e3cd126c1 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2051753002
Cr-Commit-Position: refs/heads/master@{#398847}
[WebView] Unbreak layout tests on the Android WebView L/M bots.
Add the "window.chrome" attribute to excluded interfaces
for WebView.
BUG=618471
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2053633002
Cr-Commit-Position: refs/heads/master@{#398846}
clovis: Fix report generation.
The user lenses report an offset, not an absolute number, making the
report generation fail. Add back the base value.
Review-Url: https://codereview.chromium.org/2048253003
Cr-Commit-Position: refs/heads/master@{#398845}
[headless] Define HEADLESS_IMPLEMENTATION.
[email protected]
Review-Url: https://codereview.chromium.org/2049823002
Cr-Commit-Position: refs/heads/master@{#398844}
Roll WebGL 0e41a33..04fa5ca
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/0e41a33..04fa5ca
BUG=618464
TEST=bots
[email protected],[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2049693004
Cr-Commit-Position: refs/heads/master@{#398843}
Update V8 to version 5.3.189.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a0c1662b..2f0cd4e0
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2054713002
Cr-Commit-Position: refs/heads/master@{#398842}
Another rebaseline for some SVG layout tests
Just on Win and Mac
BUG=618638
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2057503002
Cr-Commit-Position: refs/heads/master@{#398841}
[Android] Added a runtime flag to enable autoplay of muted videos.
Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.
BUG=617592,617595
TEST=avayvod.github.io/autoplay-test.html
Review-Url: https://codereview.chromium.org/2039773003
Cr-Commit-Position: refs/heads/master@{#398840}
Limit live Document tracking to debug builds.
liveDocumentSet() is only used by a debug entry point, so only extend
it on Document creation in debug builds.
R=
BUG=611702
Review-Url: https://codereview.chromium.org/2052583003
Cr-Commit-Position: refs/heads/master@{#398839}
[memory-infra] Log reasons for memory dump failure
All memory dump failures will now lead to VLOG(1) error messages so that
the reason for failure could be determined from outside chrome (e.g. in
Telemetry).
BUG=616483
TBR=shatch
Review-Url: https://codereview.chromium.org/2049143002
Cr-Commit-Position: refs/heads/master@{#398838}
Worker: Protect a running debugger task from forcible worker termination
A running debugger task must be protected from forcible worker termination, but
in the current implementation, there is a corner case where the debugger task
can suddenly be killed as follows:
1) performDebuggerTaskOnWorkerThread() is called almost at the same time as
terminateInternal() on the main thread. terminateInternal() acquires
|m_threadStateMutex| before performDebuggerTaskOnWorkerThread().
2) terminateInternal() checks a flag |m_runningDebuggerTask| before
performDebuggerTaskOnWorkerThread() sets it, schedules a force termination
task, and releases the lock.
3) performDebuggerTaskOnWorkerThread() acquires the lock, sets the flag, and
runs the debugger task.
4) The scheduled task is fired while the debugger task is running and attempts
to terminate it. This may cause crashes.
To avoid the case, this CL makes a scheduled task check the flag before
terminating the worker execution. In addition, this ensures that postTask() and
appendDebuggerTask() don't post new tasks after terminateInternal() or
prepareForShutdownOnWorkerThread() is called.
BUG=616775
Review-Url: https://codereview.chromium.org/2041753002
Cr-Commit-Position: refs/heads/master@{#398837}
Roll src/third_party/pdfium/ 759de3828..9e077d288 (18 commits).
https://pdfium.googlesource.com/pdfium.git/+log/759de3828419..9e077d288016
$ git log 759de3828..9e077d288 --date=short --no-merges --format='%ad %ae %s'
2016-06-09 jochen Roll V8 and its deps and update ICU initialization call
2016-06-08 tsepez Remove redundant casts, part 4
2016-06-08 dsinclair xfa_fm2jscontext method cleanup - pt VIII
2016-06-08 dsinclair xfa_fm2jscontext method cleanup - pt VII
2016-06-08 tsepez Remove even more const casting from core.
2016-06-08 tsepez Add some consts and remove more casts in core/
2016-06-08 dsinclair Set data availablity error.
2016-06-08 dsinclair Remove more FXJSE c-method wrappers.
2016-06-08 caryclark update skia
2016-06-08 tsepez Remove implicit CFX_CountedRef::operator T*()
2016-06-08 weili Change time_t conversion operator to ToTime_t() function
2016-06-08 thestig Fix GetPageIndex() for dynamic XFA documents.
2016-06-07 tsepez Avoid const-cast in CPDF_Font
2016-06-07 dsinclair Remove various FXJSE Value methods.
2016-06-07 thestig Remove dead code in CFGAS_FontMgrImp.
2016-06-07 tsepez Use static_casts for cpdf_type1font bsearch on mac.
2016-06-07 thestig Get rid of NULLs in fpdfsdk/
2016-06-07 thestig Replace IFGAS_Font with underlying concrete type
BUG=
[email protected]
Review-Url: https://codereview.chromium.org/2057493002
Cr-Commit-Position: refs/heads/master@{#398836}
Use HeadlessAsyncDevTooledBrowserTest in HeadlessDevToolsClient tests.
BUG=546953
Review-Url: https://codereview.chromium.org/2050143002
Cr-Commit-Position: refs/heads/master@{#398835}
Implement "create an element" when async for Custom Element V1
This patch implements "create an element" concept[1] step 6.2, when
synchronous custom elements flag is unset.
[1] https://dom.spec.whatwg.org/#concept-create-element
BUG=594918
Review-Url: https://codereview.chromium.org/2043153003
Cr-Commit-Position: refs/heads/master@{#398834}
Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long".
WebIDL's "unsigned long" is a 32-bit type:
https://heycam.github.io/webidl/#idl-unsigned-long
BUG=432739
Review-Url: https://codereview.chromium.org/2006193002
Cr-Commit-Position: refs/heads/master@{#398833}
Remove unnecessary calling offset{Top,Left}
All APIs should work without calling offsetXXX explicitly.
BUG=531990
Review-Url: https://codereview.chromium.org/2039813008
Cr-Commit-Position: refs/heads/master@{#398832}
Convert startup_metric_utils to use mojo.
BUG=577685
[email protected]
Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Review-Url: https://codereview.chromium.org/2022413002
Cr-Original-Commit-Position: refs/heads/master@{#398781}
Cr-Commit-Position: refs/heads/master@{#398831}
Clean-up ui::Event struct traits.
* Removes has_pointer_data()/has_key_data().
* Removes unnessecary cases from UIEventTypeToMojo().
BUG=578206
Review-Url: https://codereview.chromium.org/2046563011
Cr-Commit-Position: refs/heads/master@{#398830}
Fixed callers that modify lists from getPropertyCSSValue()
Fixed callers that get a CSSValueList from getPropertyCSSValue(), then
modify the list before saving it back to the style. This is an actual
behavior change to the more correct behavior (copy a read-only version
of the list out of the style, modify it, then save it back to the
style).
This is pre-work for making StylePropertySet::getPropertyCSSValue return
a const CSSValue*, which will force all callers to implement this
behavior.
BUG=526586
Review-Url: https://codereview.chromium.org/2038373002
Cr-Commit-Position: refs/heads/master@{#398829}
Fix #include path typo from r398580 (SKColor.h -> SkColor.h)
Locally I get an error:
../../chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h:18:10:
fatal error: 'third_party/skia/include/core/SKColor.h' file not found
BUG=None
[email protected]
Review-Url: https://codereview.chromium.org/2048163004
Cr-Commit-Position: refs/heads/master@{#398828}
Clean up layout tests in LayoutTests/shadow-dom/
- Remove "v1-" prefix.
- Clean up styles
- Use makeTestTree() as much as possible
Clean up is not finished. Other clean up CLs will come later.
BUG=531990
Review-Url: https://codereview.chromium.org/2053503003
Cr-Commit-Position: refs/heads/master@{#398827}
bluetooth: remove deprecated BluetoothDevice.connectGATT
BUG=582292
Review-Url: https://codereview.chromium.org/2048043002
Cr-Commit-Position: refs/heads/master@{#398826}
Make sure CSS agent messages flush before testing.
While working on updating active stylesheets as part of the style and
layout tree update in [1], two inspector tests started failing. The
reason was these tests rely on a console message to trigger a step in
the test after the active stylesheets have been pushed to the inspector
client. But even if the stylesheets were updated in InspectorCSSAgent
before the console message was sent, the console message arrived in the
client before the new active stylesheets. The reason was that the
console message is immediately flushed, while the messages from the
InspectorCSSAgent are lazily flushed from WebDevToolsAgentImpl::
didProcessTask.
I tried to force the active stylesheet update with a forced layout tree
update like this:
document.documentElement.offsetTop;
console.log(...);
But, due the console.log message being dispatched first as described
above, I ended up postponing the console.log with a rAF which means it
will run in a later task and the didProcessTask will trigger in between
to flush the active stylesheet message(s).
Note that this was not currently causing any failures. It's done in
preparation for landing changes for 567021 without breaking anything.
Looking at TestExpectations, I noticed crbug.com/597572, which might be
a similar issue.
[1] https://codereview.chromium.org/1913833002/
[email protected],[email protected]
BUG=567021
Review-Url: https://codereview.chromium.org/2049283002
Cr-Commit-Position: refs/heads/master@{#398825}
Worker: Add UMA to record an exit code of WorkerThread
BUG=616721
Review-Url: https://codereview.chromium.org/2045403002
Cr-Commit-Position: refs/heads/master@{#398824}
DevTools: Make sure microtasks are run before closing the FunctionCall event.
follow up fix after https://chromium.googlesource.com/chromium/src/+/7811435c7a6f93b2f016788e5a963324a8f0a854
Review-Url: https://codereview.chromium.org/2056523003
Cr-Commit-Position: refs/heads/master@{#398823}
Make blocking of nested message loop causing APIs during microtasks experimental
BUG=605517
[email protected]
Review-Url: https://codereview.chromium.org/2050623002
Cr-Commit-Position: refs/heads/master@{#398822}
Use vector icon for Ash shelf launcher
Introduce new vector icons for the launcher in
the material design shelf, which is currently
off by default behind --ash-md. This CL also
adds support for drawing elliptical arcs in
.icon files, which are needed for this
particular icon.
BUG=595015,605643,617289
TEST=manual
Review-Url: https://codereview.chromium.org/2002293002
Cr-Commit-Position: refs/heads/master@{#398821}
Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.
In JavaScript, this object is just a base CSSStyleValue as per the
spec: https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects
BUG=545318
Review-Url: https://codereview.chromium.org/2038773002
Cr-Commit-Position: refs/heads/master@{#398820}
Update V8 to version 5.3.188.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6ee43395..a0c1662b
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2048193003
Cr-Commit-Position: refs/heads/master@{#398819}
WebScrollbarThemeClientImpl should not be DisplayItemClient
WebScrollbarThemeClientImpl inherited DisplayItemClient from
ScrollbarThemeClient but it is never used as a DisplayItemClient.
Let Scrollbar instead of ScrollbarThemeClient inherit
DisplayItemClient, and use Scrollbar type in ScrollbarTheme
paint methods.
This avoids the need to let WebScrollbarThemeClientImpl follow
the rules of DisplayItemClient caching.
Review-Url: https://codereview.chromium.org/2045963003
Cr-Commit-Position: refs/heads/master@{#398818}
Fix chrome://snippets-internals crashing in incognito mode.
NTPSnippetsService cannot be created in incognito. This was not previously reflected. The CL makes the internals page not exist in incognito (chrome shows the standard "This site can't be reached" error page).
BUG=617796
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2042273002
Cr-Commit-Position: refs/heads/master@{#398817}
Revert of Convert startup_metric_utils to use mojo. (patchset #6 id:240001 of https://codereview.chromium.org/2022413002/ )
Reason for revert:
Breaks mac compilation.
Original issue's description:
> Convert startup_metric_utils to use mojo.
>
> BUG=577685
> [email protected]
>
> Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
> Cr-Commit-Position: refs/heads/master@{#398781}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577685
Review-Url: https://codereview.chromium.org/2048033004
Cr-Commit-Position: refs/heads/master@{#398816}
Change the CSSProperty() constructors to take a const CSSValue&
Change the CSSProperty() constructors to take a const CSSValue& instead
of a const CSSValue*. Since CSSProperty objects cannot store null
CSSValues, this is more semantically correct and safe.
BUG=526586
Review-Url: https://codereview.chromium.org/2049383002
Cr-Commit-Position: refs/heads/master@{#398815}
Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.
We can measure the effect of the speculatively launch of Service Workers on UI-events by this metric.
BUG=616502
Review-Url: https://codereview.chromium.org/2039743003
Cr-Commit-Position: refs/heads/master@{#398814}
Mark shouldMarkObject(), arenaForNormalPage() accessors as const.
Also remove some redundant checkHeader() asserts while doing a code
tidying pass.
R=
BUG=
Review-Url: https://codereview.chromium.org/2054673002
Cr-Commit-Position: refs/heads/master@{#398813}
Update V8 to version 5.3.186.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1fc749d7..6ee43395
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2045173005
Cr-Commit-Position: refs/heads/master@{#398812}
Add more pdf codec fuzzers.
[email protected],[email protected]
BUG=617659,616842,616841,616839
Review-Url: https://codereview.chromium.org/2043313003
Cr-Commit-Position: refs/heads/master@{#398811}
Cleanup: Fix some nits in printing::Metafile.
Review-Url: https://codereview.chromium.org/2050723003
Cr-Commit-Position: refs/heads/master@{#398810}
Check DisplayItemClient aliveness when copying subsequence
BUG=609218
Review-Url: https://codereview.chromium.org/2046183002
Cr-Commit-Position: refs/heads/master@{#398809}
Handle 'visibility:collapse' for SVG shapes/images/text-decorations
SVG shapes/images/text-decoration does not handle 'visibility:collapse'
properly. It was just handled only 'visibility:hidden'.
BUG=604687
Review-Url: https://codereview.chromium.org/2042703002
Cr-Commit-Position: refs/heads/master@{#398808}
Roll src/third_party/catapult/ 8ff23141e..20c004c9f (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ff23141e1df..20c004c9fccd
$ git log 8ff23141e..20c004c9f --date=short --no-merges --format='%ad %ae %s'
BUG=618156
[email protected]
Review-Url: https://codereview.chromium.org/2044363003
Cr-Commit-Position: refs/heads/master@{#398807}
Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr.
Currently, HostContentSettingsMap::SetWebsiteSettingDefaultScope
takes a raw base::Value*, and its clients typically release() a
std::unique_ptr<base::Value> when calling it. However, this method
returns without doing anything if provided with an invalid primary or
secondary URL pattern (e.g. the view source page). When this happens,
the base::Value is leaked, as it has been released() by its previous
owner without being taken into a unique_ptr in
SetWebsiteSettingsDefaultScope.
This CL eliminates the leak by making the method take a std::unique_ptr,
and adjusting its call sites to use either std::move or base::WrapUnique.
BUG=618529
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2054623002
Cr-Commit-Position: refs/heads/master@{#398806}
Add an API to get total size of Drive cache including non-evictable ones.
The API is needed to show the total size of Drive cache in storage manager.
This CL also changes the type of cache size to int64_t, to be consistent with functions under base/files.
BUG=591958
TEST=manually
Review-Url: https://codereview.chromium.org/2048993002
Cr-Commit-Position: refs/heads/master@{#398805}
Make ResolvedVariableChecker store const CSSValues
Make ResolvedVariableChecker store const CSSValues instead of regular
CSSValues. This is an entirely mechanical change that is pre-work for
making CSSPropertyParser::parseSingleValue return a const CSSValue*.
[email protected]
BUG=526586
Review-Url: https://codereview.chromium.org/2040813002
Cr-Commit-Position: refs/heads/master@{#398804}
Add missing include
This include is required for INT_MAX constant used in this file.
Currently this compiles without this statement because the header gets
pulled through WTF dependencies.
BUG=
Review-Url: https://codereview.chromium.org/2051653002
Cr-Commit-Position: refs/heads/master@{#398803}
Change ahem.js logic to make tests unflaky
BUG=392046, 618179
Review-Url: https://codereview.chromium.org/2047263002
Cr-Commit-Position: refs/heads/master@{#398802}
Upstream: ChildProcessLauncher connects renderer processes of WebAPKs.
A refactoring is done in ChildProcessLauncher to have a map for inSandboxed
ChildConnectionAllocators. It allows WebAPKs' renderer services are assigned
to a different ChildConnectionAllocator depending on the package name.
We use ChildProcessCreationParams to plumb in WebAPK's package name into
ChildProcessLauncher. So the allocator knows which application's renderer
services to connect, and the maximum number of services that are allowed
by that application.
Always initialize ChildProcessCreationParams.
BUG=609122
Review-Url: https://codereview.chromium.org/2017963003
Cr-Commit-Position: refs/heads/master@{#398801}
Include Web Animations when updating composited neutral keyframes
This change includes Web Animations along side CSS Animations for updating
neutral compositor keyframes.
BUG=617503
Review-Url: https://codereview.chromium.org/2039133002
Cr-Commit-Position: refs/heads/master@{#398800}
bluetooth: remove deprecated BluetoothDeviceInstanceId
BUG=548347
Review-Url: https://codereview.chromium.org/2042213004
Cr-Commit-Position: refs/heads/master@{#398799}
Add android-chromium as a browser type to GPU test expectations.
Update previous expectations specific to android-content-shell to
include android-chromium.
BUG=616392
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
Review-Url: https://codereview.chromium.org/2050093002
Cr-Commit-Position: refs/heads/master@{#398798}
Default the PacHttpsUrlStrippingEnabled policy to False for Chrome OS enterprise users.
(The plan is to control rollout from the server side, out of concern over compatibility.)
BUG=616396
Review-Url: https://codereview.chromium.org/2036983004
Cr-Commit-Position: refs/heads/master@{#398797}
UseCounter: Count form submission in orphan tree.
BUG=618526
[email protected]
Review-Url: https://codereview.chromium.org/2050973002
Cr-Commit-Position: refs/heads/master@{#398796}
Remove descriptions for Android Debug GPU bots.
Delete now-unreferenced MB configs.
BUG=617848
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2052703002
Cr-Commit-Position: refs/heads/master@{#398795}
IntersectionObserver: Warn when target is not a descendant of root.
BUG=617393
[email protected]
Review-Url: https://codereview.chromium.org/2048853002
Cr-Commit-Position: refs/heads/master@{#398794}
Add GetApplicationsSize to storage_manager.mojom
This CL removes GetPrivateVolumes RPC as well.
BUG=611651
BUG=b/27601511
Review-Url: https://codereview.chromium.org/2035793005
Cr-Commit-Position: refs/heads/master@{#398793}
arc: Slightly clarify comments.
BUG=None
TEST=Build succeeds.
Review-Url: https://codereview.chromium.org/2044233003
Cr-Commit-Position: refs/heads/master@{#398792}
Roll src/third_party/skia/ 28215d44b..a9e878c83 (4 commits).
https://chromium.googlesource.com/skia.git/+log/28215d44b3f9..a9e878c83699
$ git log 28215d44b..a9e878c83 --date=short --no-merges --format='%ad %ae %s'
2016-06-08 msarett Optimize color xforms with 2.2 gammas for SSE2
2016-06-08 herb Use faster case for on tile sampling, and a little clean up. This has been a sampling bug and so was bypassed using "false &&". Found the sampling bug and added the case back in.
2016-06-08 scroggo Stop trying to build files that are not there
2016-06-08 egdaniel Add GpuCommandBuffer support.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2054663002
Cr-Commit-Position: refs/heads/master@{#398791}
Clean-up blink_idl_parser
- Move p_CallbackOrInterface to the base parser
- Remove p_TypeSuffix. This is already handled by the base parser
BUG=617899
Review-Url: https://codereview.chromium.org/2050823003
Cr-Commit-Position: refs/heads/master@{#398790}
Disable 4 and 8 digit hex CSS colors
New compat concerns have been raised with 4 and 8 digit HEX color
values in CSS. In particular, a targetSdk quirk needs to be added
for Android WebView to avoid breaking Android apps.
Demote this feature to "experimental" status until an owner can be found.
BUG=618518, 76362
Review-Url: https://codereview.chromium.org/2047413003
Cr-Commit-Position: refs/heads/master@{#398789}
Move quads.mojom from Mus to cc
This CL moves quads.mojom closer to the types they will map to along with
other cc mojoms. This CL also updates the module name to cc.mojom, and updates
Pass => RenderPass, Quad => DrawQuad to better match cc naming.
BUG=611802
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2056483002
Cr-Commit-Position: refs/heads/master@{#398788}
Updating remoting_start_host to use remoting_core.dll
The remoting_start_host binary is much larger than other exes in the Windows
MSI (~5MB vs. 100KB). This is because it links in a bunch of code we
already include in remoting_core.dll.
This change moves the shared code into remoting_core.dll and sets up the
remoting_start_host binary to use a shared library for other platforms if we
decide to do so later on. It also updates the information that is stamped on
the windows exe so it reflects the name and purpose of the tool.
BUG=617182
Review-Url: https://codereview.chromium.org/2049173003
Cr-Commit-Position: refs/heads/master@{#398787}
Roll closure compiler
Change log:
https://github.com/google/closure-compiler/compare/64992fc873fc7294553b43195c2124541cb11870...9a92cacf1d661ee7a19cea16ea2ad860814e22a2
chrome_extensions.js: 6cf8dac8c8e3d522ec23caa5ee60658419835d4f -> 93f22f4f3e69632d21ec562782e95faf5332b2e0
Also fixes some compilation issues regarding HTMLElement#remove()
conflicting with custom, application-specific remove implementations.
Also, TIL that HTMLSelectElement#remove() is a thing.
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/2049373002 .
Cr-Commit-Position: refs/heads/master@{#398786}
Auto-rebaseline for r398764
https://chromium.googlesource.com/chromium/src/+/363e90a4d
BUG=611462
[email protected]
Review URL: https://codereview.chromium.org/2049393002 .
Cr-Commit-Position: refs/heads/master@{#398785}
media: Remove MockDemuxerStreamVector from RendererImplTest
This was added back when media::RendererImpl was born. But it seems
this memeber is never useful in the test.
Review-Url: https://codereview.chromium.org/2048163003
Cr-Commit-Position: refs/heads/master@{#398784}
[Chromoing] Fix DCHECK when shutting down It2Me host from client side
This change is to fix a DCHECK issue in It2Me scenario. remote_assistance_host
triggers a DCHECK failure if client disconnects the connection. So this change
modified It2MeHost::Shutdown function to return directly if current state is
kDisconnected. See bug for details.
BUG=617474
Review-Url: https://codereview.chromium.org/2040353002
Cr-Commit-Position: refs/heads/master@{#398783}
Disable dx --incremental for libraries with only 1 .java file
The theory is that there is a bug for libraries with only a single .java
file.
BUG=617935,616075
Review-Url: https://codereview.chromium.org/2045313002
Cr-Commit-Position: refs/heads/master@{#398782}
Convert startup_metric_utils to use mojo.
BUG=577685
[email protected]
Review-Url: https://codereview.chromium.org/2022413002
Cr-Commit-Position: refs/heads/master@{#398781}
arc: Clear the ARC task list when ARC get disabled.
BUG=b:29154797
TEST=trybots
TEST=Manually tested
Review-Url: https://codereview.chromium.org/2043293002
Cr-Commit-Position: refs/heads/master@{#398780}
Use public handle API to transfer handle attachments.
And remove embedder includes where not needed.
BUG=604282
Review-Url: https://codereview.chromium.org/2040383002
Cr-Commit-Position: refs/heads/master@{#398779}
Fix jmake root_build_dir vs root_out_dir
BUG=616819
Review-Url: https://codereview.chromium.org/2037113002
Cr-Commit-Position: refs/heads/master@{#398778}
Cleanup: Remove VersionUpdater::RelaunchBrowser interface method.
Specifically:
- Introducing a chrome::AttemptRelaunch() method.
- Removing VersionUpdater::RelaunchBrowser() method, since the extra
level of indirection seems unnecessary.
This is in preparation of reducing the number of "Restart" codepaths in MD
Settings.
BUG=617830
Review-Url: https://codereview.chromium.org/2039273003
Cr-Commit-Position: refs/heads/master@{#398777}
[Reland] Mojo: Eliminate duplicate C API symbols
This gets rid of the duplicate definitions of public
Mojo C API symbols, instead making mojo/public/c/system
the singular source of these definitions. This allows
targets to be linked against mojo/public libraries
without requiring any additional EDK dependencies at
build time.
To facilitate this the EDK uses the same set of API
thunks as the public library, and the public library
exposes a special embedder API (distinct from the DSO
MojoSetSystemThunks call used by the native app loader)
for setting these thunks. The MojoSetSystemThunks API
is moved to a module which is only linked directly into
app DSOs.
Because mojo/public/c/system and mojo/edk/system are
now both components, and because there are no longer
redundant exports between the two, it's now safe for
targets to depend on either one or both of them as
needed without encountering duplicate definitions.
Also some opportunistic cleanup of Mojo build rules.
Reland of https://codereview.chromium.org/2044023004
Previous failures were caused by the mojo/public/c/system
component using "system" as its name, breaking -lsystem
behavior in some linking scenarios. This reland changes
the output_name of that target.
BUG=612500
[email protected]
Review-Url: https://codereview.chromium.org/2049773004
Cr-Commit-Position: refs/heads/master@{#398776}
Add LeakDetectorRemoteController as a Mojo service
New class LeakDetectorRemoteController that implements the Mojo
interface LeakDetectorRemote. This class provides a bridge between the
browser and renderer processes. It also allows a single instance of
LeakDetectorController to provide leak detector params to the renderer
process and receive leak reports from the renderer process.
The renderer process client will be implemented in a future CL.
BUG=chromium:615223
Review-Url: https://codereview.chromium.org/2030883004
Cr-Commit-Position: refs/heads/master@{#398775}
Snap content to the top level window on chromeos
BUG=618426
TEST=manual
Review-Url: https://codereview.chromium.org/2056503002
Cr-Commit-Position: refs/heads/master@{#398774}
target_cpu -> current_cpu in chromeos/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2038083003
Cr-Commit-Position: refs/heads/master@{#398773}
Revert of Limit foreign fetch to only intercept requests made from secure contexts. (patchset #2 id:40001 of https://codereview.chromium.org/2032653003/ )
Reason for revert:
ResourceRequest::initiated_in_secure_context should have a default value, now it's causing failures on some MSAN bots
Original issue's description:
> Limit foreign fetch to only intercept requests made from secure contexts.
>
> Implements step 5 of "Handle Foreign Fetch" in [1]
>
> [1]: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on-foreign-fetch-request-algorithm
>
> BUG=540509
>
> Committed: https://crrev.com/dd933bda0baa6a13ab0120f0056a2b783e459efb
> Cr-Commit-Position: refs/heads/master@{#398752}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=540509
Review-Url: https://codereview.chromium.org/2049723004
Cr-Commit-Position: refs/heads/master@{#398772}
Remove HTML5 menu tag feature from experimental set
There are website compat issues with this feature on sites that use their
own <menuitem> tags (especially developer.apple.com). Remove it from
the "experimental" set until there's a concrete plan in place to either
ship or resolve the issue to prevent ongoing issues for users running
with this flag enabled.
Note that you can always run chromium with
--enable-blink-features=ContextMenu in order to get this feature.
BUG=412945
Review-Url: https://codereview.chromium.org/2049093003
Cr-Commit-Position: refs/heads/master@{#398771}
Add a new way to record Rappor metrics for MIDI permissions.
Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.
Also, rappor.xml is updated that was missed in the last change.
BUG=465661
[email protected]
Review-Url: https://codereview.chromium.org/2038403002
Cr-Commit-Position: refs/heads/master@{#398770}
Updating trunk VERSION from 2763.0 to 2764.0
Cr-Commit-Position: refs/heads/master@{#398769}
Quit the test child message loop on connection error.
This de-flakes ipc_mojo_unittests. The test were failing because the
child message handler called QuitWhenIdle, and the the listener's error
handler could be called before the loop is idled.
BUG=617938
Review-Url: https://codereview.chromium.org/2055683002
Cr-Commit-Position: refs/heads/master@{#398768}
[refactor] Remove an unnecessary line of code.
Remove an unnecessary line of code.
BUG=578168
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2056553002
Cr-Commit-Position: refs/heads/master@{#398767}
Manual refactor of few more stragglers to enum-based WaitableEvent constructor.
Found a couple more sites with regex "(WaitableEvent|event_)\((true|false),", hoping those are the last ones..!
BUG=612843
[email protected]
[email protected]
(Francois please fact check me, I'm TBRing dana for otherwise mechanical change)
Review-Url: https://codereview.chromium.org/2054613002
Cr-Commit-Position: refs/heads/master@{#398766}
Explicitly serialise platform file attachments instead of doing them implicitly as a mojo handle attachment.
This change is intended to make it clearer how platform file attachments
are serialised and deserialised under ChannelMojo.
BUG=604282
Review-Url: https://codereview.chromium.org/2047953002
Cr-Commit-Position: refs/heads/master@{#398765}
Add Settings::useDefaultImageInterpolationQuality and use it in repaint tests
to enable reftests containing scaled images.
BUG=611462
Review-Url: https://codereview.chromium.org/2052563002
Cr-Commit-Position: refs/heads/master@{#398764}
Use consistent naming for Webrtc* classes.
Most WebRTC-specific classes in remoting have Webrtc prefix, while
some were using WebRtc. Renamed all of them to use Webrtc prefix
consistently.
Review-Url: https://codereview.chromium.org/2049723003
Cr-Commit-Position: refs/heads/master@{#398763}
[MD History] Disable MD History for supervised users.
This CL disables MD History for supervised users and users with
grouped history enabled. This CL also fixes a bug where the groupByDomain
variable didn't consider whether the user was a supervised user.
BUG=589357
[email protected]
Review-Url: https://codereview.chromium.org/2034473003
Cr-Commit-Position: refs/heads/master@{#398762}
MediaCaptureFromElement: change flag from test to experimental
... so it can be enabled with the chrome://flags
Experimental Web Platform features and used
by external dapper and jaunty developers.
BUG=569976, 575492
Review-Url: https://codereview.chromium.org/2045883005
Cr-Commit-Position: refs/heads/master@{#398761}
Roll src/third_party/catapult/ 901f7edd7..8ff23141e (14 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/901f7edd757b..8ff23141e1df
$ git log 901f7edd7..8ff23141e --date=short --no-merges --format='%ad %ae %s'
BUG=552376,552376,613706,617849,616483,616832
[email protected]
Review-Url: https://codereview.chromium.org/2048953003
Cr-Commit-Position: refs/heads/master@{#398760}
Implement cc::FilterOperations StructTraits
BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2047573005
Cr-Commit-Position: refs/heads/master@{#398759}
CC Animation: Stop using KeyframedFloatAnimationCurve in TopControlsManager.
Fun fact: CubicBezierTimingFunction::CreatePreset(CubicBezierTimingFunction::EaseType::EASE)
was not used since the last keyframe's timing function
is never active.
Use simple lerp instead of two FloatKeyframes with linear timing function.
TopControlsManager shouldn't depend on cc/animation.
BUG=575053
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2042963002
Cr-Commit-Position: refs/heads/master@{#398758}
Remove (already-hidden) global fullscreen / mouselock settings.
This UI was already hidden. This just removes the HTML code for those
radio buttons, as well as the unused code for showing these buttons, and
the strings.
BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2045163002
Cr-Commit-Position: refs/heads/master@{#398757}
Permissions: Allow control of individual requests in media permission infobars
This adds toggle switches to Camera and Microphone permission requests,
allowing the permissions to be allowed/blocked independently of each
other.
BUG=458606
Review-Url: https://codereview.chromium.org/2019573002
Cr-Commit-Position: refs/heads/master@{#398756}
Speed up InvalidationRegion
Staging invalidation rectangles in a vector allows us to skip building
a complex SkRegion for cases with many invalidations (> 256). For cases
with fewer invalidations we will still build a full SkRegion.
[email protected]
BUG=606069
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2054473002
Cr-Commit-Position: refs/heads/master@{#398755}
Restart the browser after unexpected test failures or flakes.
This helps avoid the situation where the browser gets stuck in a bad
state between runs.
Tested locally against the real browser using failure injection, as well
as via the slightly-expanded unit test.
BUG=352807
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2033883003
Cr-Commit-Position: refs/heads/master@{#398754}
NQE: Allow algorithm to be set using variation params
This CL provides the ability to use different algorithms for
computing effective connection type. The algorithm to use
can be set using field trial params. If field trial params
are unavailable (e.g., at first run), then a default value
is used.
The existing algorithm was also modified to be exactly same
as what data reduction proxy is currently is using.
Once this CL lands, the server side CL needs to land to set
the variation param. Then, GetEffectiveConnectionType() API
will be ready for use by DRP and custom fonts.
BUG= 615551,569497
Review-Url: https://codereview.chromium.org/2032443003
Cr-Commit-Position: refs/heads/master@{#398753}
