Publish DEPS for Chromium 53.0.2763.0
Limit foreign fetch to only intercept requests made from secure contexts.
Implements step 5 of "Handle Foreign Fetch" in [1]
[1]: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on-foreign-fetch-request-algorithm
BUG=540509
Review-Url: https://codereview.chromium.org/2032653003
Cr-Commit-Position: refs/heads/master@{#398752}
Fix jetstream unreferenced tab variable.
BUG=618513
NOTRY=true
Review-Url: https://codereview.chromium.org/2051673003
Cr-Commit-Position: refs/heads/master@{#398751}
mash: Move shelf menu code to //ash/common/shelf
It no longer has non-common dependencies.
I'll TBR since it's a purely mechanical file move.
BUG=615155
TEST=compiles
[email protected]
Review-Url: https://codereview.chromium.org/2046563012
Cr-Commit-Position: refs/heads/master@{#398750}
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim
Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.
BUG=617312
Review-Url: https://codereview.chromium.org/2045873002
Cr-Commit-Position: refs/heads/master@{#398749}
Optimize tab switcher border PNG files
Total size of new tab switcher border assets reduced by 72%; 9256 to
2580 bytes.
BUG=606612
Review-Url: https://codereview.chromium.org/2051463003
Cr-Commit-Position: refs/heads/master@{#398748}
Send Navigation notifications to clients.
This teaches clients about Navigation entries & should eventually allow them to add a client lib which replicates the in-service NavigationController.
Adds back/forward dropdown menus to the browser app.
[email protected]
Review-Url: https://codereview.chromium.org/2055553002
Cr-Commit-Position: refs/heads/master@{#398747}
Revert of Remove enable/disable wheel gestures setting. (patchset #3 id:40001 of https://codereview.chromium.org/2047093002/ )
Reason for revert:
Caused RenderWidgetHostViewMacTest.IgnoreEmptyUnhandledWheelEventWithWheelGestures failure on build:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/25325
See
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/25325
Test output:
"""
[ RUN ] RenderWidgetHostViewMacTest.IgnoreEmptyUnhandledWheelEventWithWheelGestures
../../content/browser/renderer_host/render_widget_host_view_mac_unittest.mm:966: Failure
Value of: view_delegate.get().unhandledWheelEventReceived
Actual: ''
Expected: __objc_yes
Which is: '?' (1)
[3372:1287:0608/164121:1128775946716:FATAL:surface_manager.cc(43)] Check failed: namespace_client_map_.size() == 0u (1 vs. 0)
"""
Original issue's description:
> Remove enable/disable wheel gestures setting.
>
> Since wheel gesture based scrolling has shipped and the code has been
> removed from blink we can remove the runtime setting.
>
> BUG=598798
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f
> Cr-Commit-Position: refs/heads/master@{#398716}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=598798
Review-Url: https://codereview.chromium.org/2050033002
Cr-Commit-Position: refs/heads/master@{#398746}
Don't include wayland_object.h from wayland_display.cc
It was already included in wayland_display.h
BUG=none
Review-Url: https://codereview.chromium.org/2040373004
Cr-Commit-Position: refs/heads/master@{#398745}
[Offline Pages] Filtering expired pages and fix consistency check.
Filtering expired pages when querying offline pages. Using expiring
instead of removing page entries in consistency check. Also will remove
files in archive folder to which have no page entry pointing.
BUG=616622
Review-Url: https://codereview.chromium.org/2041983006
Cr-Commit-Position: refs/heads/master@{#398744}
Record precache periodic task interval
Precache periodic task is invoked by GCMNetworkManager when the
conditions are right for precaching. The interval between successive
task invocations should be logged.
BUG=618386
Review-Url: https://codereview.chromium.org/2047573007
Cr-Commit-Position: refs/heads/master@{#398743}
Clean up PdfMetafileSkia
- Move printing::PdfMetafileSkia::SaveToFD to the single place it is
called.
- Simplify Page struct.
- Remove unnecessary includes.
- Factor out MakePdfDocument() in advance of supporting more document
types provided by Skia.
Review-Url: https://codereview.chromium.org/2024813005
Cr-Commit-Position: refs/heads/master@{#398742}
Roll ANGLE 07529ff..768996c
https://chromium.googlesource.com/angle/angle.git/+log/07529ff..768996c
BUG=617410
TEST=bots
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2042333005
Cr-Commit-Position: refs/heads/master@{#398741}
ash: Remove broken OS update system tray "nagger" popup
See bug for details. We used to show a "nag" popup if you had an update
pending and your shelf had been hidden for > 24 hours. The feature has been
broken for a while and after discussing with abodenha@ we've decided to
remove it.
This is a manual revert of http://crrev.com/134812
BUG=122641
TEST=none
Review-Url: https://codereview.chromium.org/2051643002
Cr-Commit-Position: refs/heads/master@{#398740}
[Mac/GN] dSYM output always goes in root_out_dir, so specify it in linker outputs.
This was causing overbuild for targets that override the output directory,
since the linker_driver.py is configured to place dSYMs in root_out_dir, but
the linker output was listed in the target_out_dir.
BUG=330301,431177
[email protected]
Review-Url: https://codereview.chromium.org/2049003004
Cr-Commit-Position: refs/heads/master@{#398739}
Add unit tests for the Background Scheduler.
Adding the unit tests required a lot of related changes to be able to do dependency injection, and adding some stub classes. The SchedulerBridgeInterface allows us to stub out the BackgroundSchedulerBridge, and we added a shadow class for GcmNetworkManager.
This work is described at go/chrome-background-offlining.
BUG=612325
Review-Url: https://codereview.chromium.org/2030773002
Cr-Commit-Position: refs/heads/master@{#398738}
Add GetAccessibilityDelegate() to WmShell
Wires up in overview, updates overview to use WmShell in a couple of
other places and updates DEPS for overview.
BUG=581868
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2043883007
Cr-Commit-Position: refs/heads/master@{#398737}
BridgedContentView: Modify IsTextRTL to use GetFirstStrongCharacterDirection.
Currently, IsTextRTL method in BridgedContentView uses
base::i18n::GetStringDirection to get the string text direction. This is
inconsistent with RenderText::GetTextDirection. This CL modifies IsTextRTL to
use base::i18n::GetFirstStrongCharacterDirection to ensure consistency with
RenderText::GetTextDirection.
This also necessitates modifying SendHomeEvent and SendEvent in
textfield_unittest.cc, to prevent the tests TextfieldTest.HitOutsideTextAreaTest
and TextfieldTest.HitOutsideTextAreaInRTLTest from regressing on MacViews. This
is because currently, SendHomeEvent and SendEndEvent correspond to logical
direction on other platforms but visual direction on Mac.
The reason that the tests TextfieldTest.HitOutsideTextAreaTest and
TextfieldTest.HitOutsideTextAreaInRTLTest passed up-till now is that the
incorrect IsTextRTL and Send{Home/End}Event implementations cancelled each other
out. IsTextRTL depends on GetStringDirection currently, and hence it always
returned false for text of mixed directionality. A SendHomeEvent would do a
Cmd+Left which would generate a moveToLeftEndOfLine. Since IsTextRTL returned
false, a moveToLeftEndOfLine mapped to a moveToBeginningOfLine in
BridgedContentView. Hence a Send{Home/End}Event mapped to
moveTo{Beginning/End}OfLine, the two incorrect implementations cancelling each
other out.
BUG=618184
Review-Url: https://codereview.chromium.org/2050583002
Cr-Commit-Position: refs/heads/master@{#398736}
mash: Migrate shelf menus to wm common types
This is a dependency of ShelfView.
* Inject WmShelf into Shelf and ShelfView to start breaking up dependencies on
Shelf.
* Change ShellDelegate::CreateContextMenu() to use WmShelf.
* Allow WmShelf to manipulate auto-hide state.
* Move shelf menu UMA stats to common.
I'll move the files into //ash/common in a separate CL so that the changes to
shelf_alignment_menu.cc don't look like a rewrite.
BUG=615155
TEST=existing ash_unittests and chrome unit_tests
Review-Url: https://codereview.chromium.org/2046843005
Cr-Commit-Position: refs/heads/master@{#398735}
Fix wake_on_wifi_manager_unittest compile issue
StrictMock is templated on a class here, but it looks like
we tried to pass in the constructor instead.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2049113003
Cr-Commit-Position: refs/heads/master@{#398734}
target_cpu -> current_cpu in media/gpu/BUILD.gn, media/cdm/ppapi/cdm_paths.gni
BUG=616819
Review-Url: https://codereview.chromium.org/2038563004
Cr-Commit-Position: refs/heads/master@{#398733}
Log errors in FFmpegDemuxer::OnReadFrameDone
Review-Url: https://codereview.chromium.org/2047033002
Cr-Commit-Position: refs/heads/master@{#398732}
Add support for plane offsets to NativePixmap/GbmBuffer.
GBM buffers can have different file descriptors and different offsets
for different planes.
This change adds offsets and also changes NativePixmap interface and
NativePixmapHandle accordingly.
TEST=crrev.com/2040803002 will use and test this patch.
NOTRY=true
Review-Url: https://codereview.chromium.org/2034353002
Cr-Commit-Position: refs/heads/master@{#398731}
Make chrome sync response compression as default
BUG=509728
Review-Url: https://codereview.chromium.org/2046493007
Cr-Commit-Position: refs/heads/master@{#398730}
Fix DrMemory test for NativeDesktopMediaListTest.UpdateThumbnail
BUG=612590
Review-Url: https://codereview.chromium.org/2045983004
Cr-Commit-Position: refs/heads/master@{#398729}
[css-grid] Fix definite/indefinite size detection for abspos elements
LayoutBox::percentageLogicalHeightIsResolvable() was not working fine
to check if a positioned grid container has definite/indefinite height.
The positioned grid container only has definite height when it has
a fixed height or the offset properties (top and bottom) are non-auto.
The patch fixes LayoutBox::computePercentageLogicalHeight()
to take this into account for grid items too.
BUG=538513
TEST=fast/css-grid-layout/flex-item-grid-container-percentage-rows.html
Review-Url: https://codereview.chromium.org/2047093004
Cr-Commit-Position: refs/heads/master@{#398728}
Update V8 to version 5.3.184.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/76fc8514..1fc749d7
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2049963002
Cr-Commit-Position: refs/heads/master@{#398727}
Add rdevlin.cronin as extensions/browser/DEPS owner
BUG=None
Review-Url: https://codereview.chromium.org/2039123002
Cr-Commit-Position: refs/heads/master@{#398726}
ChromeOS: Update OOBE shelf on gaia screen reload.
This CL fixes the problem when shelf state is not updated after
OOBE gaia screen reload.
BUG=588099
TEST=none
Review-Url: https://codereview.chromium.org/2049633002
Cr-Commit-Position: refs/heads/master@{#398725}
Render the material design shelf backgrounds without assets
For the material design shelf (currently off by default
behind --ash-md), render the following backgrounds without
the use of PNG assets:
* Overflow button
* Keyboard button
* Notifications button
* System tray
* Overview mode button
* Dock window manager
* Shelf
* Shelf overflow bubble
This CL also removes dead code found in the background-painting
logic across various Ash UI surfaces. Furthermore,
the black bar is not shown at the bottom of the
material design shelf (this bar formerly contained
the horizontal white activity indicator bars).
BUG=612583, 617293, 617279
TEST=manual
Review-Url: https://codereview.chromium.org/2035313002
Cr-Commit-Position: refs/heads/master@{#398724}
Enabling WPT serve informational bot on chromium_fyi waterfall
BUG=581386
Committed: https://chromium.googlesource.com/chromium/tools/build/+/943f1294c4cf8ab9ee92dde42e312f21bfd83d3e
Review-Url: https://codereview.chromium.org/2032903005
Cr-Commit-Position: refs/heads/master@{#398723}
PlzNavigate: fix WebContentsImplTest.DirectNavigationToViewSourceWebUI
This CL fixes WebContentsImplTest.DirectNavigationToViewSourceWebUI. The test
in its current form only works because it is missing a call to
DidStartProvsionalLoad, which means that no handle is created for the
navigation. On commit, the pending NavigationEntry is reset, and a new one is
created with no virtual url and a rewritten url used for the title. In
PlzNavigate, we have a handle, so the pending entry with the viewsource virtual
url is kept, and the virtual url is displayed as a title. The CL fixes that by
adding the missing DidStartProvsionalLoad and updating the title expectations.
BUG=439423
Review-Url: https://codereview.chromium.org/2046843004
Cr-Commit-Position: refs/heads/master@{#398722}
[Mac] Dismiss an open page info dialog when the location icon is clicked.
On views platforms, clicking the location (lock) icon opens the page
info dialog. Clicking the icon again dismisses the dialog. Currently,
the same actions on Mac "refreshes" the dialog in place, with a strange
animation caused by the original dialog disappearing and a new one
taking its place immediately.
This CL makes the Cocoa and toolkit-views page info dialogs on Mac
behave consistently with views platforms, so that clicking the location
icon when the dialog is open dismisses the dialog.
BUG=59289
TEST=Open Chrome on Mac, and navigate to a page. Click on the lock
icon to open the page info dialog. Click on the icon again and the
dialog should dismiss, rather than refresh in place. The same
behaviour should apply to the toolkit-views and MacViews-WebUI
browsers.
Review-Url: https://codereview.chromium.org/2041723002
Cr-Commit-Position: refs/heads/master@{#398721}
tab capture: Fix capturing a background tab under aura.
When a tab is being streamed, it needs to remain attached to the
compositor (i.e. it needs to be attached to a root window), so that it
receives the will-draw messages (more specifically, DelegatedFrameHost
receives the cc::SurfaceFactoryClient::WillDrawSurface() calls) from
the compositor. There already was a workaround as WindowAdoptionAgent
for aura for streaming offscreen tabs. Adapt that to work for both
offscreen and detached tabs.
BUG=616975
Review-Url: https://codereview.chromium.org/2048073002
Cr-Commit-Position: refs/heads/master@{#398720}
Disable icf on chromecast android x86 builds.
The current icf settins result in segfaults in clang/gold, so disable
them.
BUG= 576197, internal b/28941634
Change-Id: I8d8a8fa2d3b6537a302c8a884897d27632dea6f6
Review-Url: https://codereview.chromium.org/2043003003
Cr-Commit-Position: refs/heads/master@{#398719}
Add mb_config and test descriptions for Release Android GPU bots.
The Debug bots' descriptions will be removed once the waterfalls are
restarted.
BUG=617848
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Review-Url: https://codereview.chromium.org/2054533003
Cr-Commit-Position: refs/heads/master@{#398718}
Add support for MAC address randomization
This is a feature in shill/wpa_supplicant to hide MAC addresses
while probing before we are actually connected, making it a little
more difficult to track users' devices by hardware MAC address.
The feature should be disabled for enterprise-enrolled devices
but enabled otherwise.
BUG=579598
[email protected]
Review-Url: https://codereview.chromium.org/2040603002
Cr-Commit-Position: refs/heads/master@{#398717}
Remove enable/disable wheel gestures setting.
Since wheel gesture based scrolling has shipped and the code has been
removed from blink we can remove the runtime setting.
BUG=598798
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2047093002
Cr-Commit-Position: refs/heads/master@{#398716}
kiosk: Enable required_platform_version key on stable
BUG=618377
Review-Url: https://codereview.chromium.org/2048433004
Cr-Commit-Position: refs/heads/master@{#398715}
[Chromecast] Implement audio filter and default passthrough filter
BUG=internal b/28928723
TEST=none
Review-Url: https://codereview.chromium.org/2052653002
Cr-Commit-Position: refs/heads/master@{#398714}
Roll buildtools 8dd3c8e39a..099f1da55b
In order to roll GN a8e5d2e327..b0b4c0099b (r396969:r398658) and pick up
the following changes:
63a623c Fix generation of Xcode project.
8161ecd Improve the "gn path" command.
e9efe32 Fix documentation for "pool" object in gn binary.
40451c5 Add support for user defined "pool" to GN.
0e85587 Fix doc on "Multiple outputs" for runtime_deps.
5797920 [Mac/iOS/GN] Document the new rules for create_bundle and runtime_deps.
4feb71fc [GN] Adding missing source type for extension .appex.
3dbb1f6 Migrate WaitableEvent to enum-based constructor in tools/
[email protected]
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg
Review-Url: https://codereview.chromium.org/2049703003
Cr-Commit-Position: refs/heads/master@{#398713}
Use monotonic time to record the touch input latency in Blink.
Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime
instead of currentTime to record the touch event latency in Blink.
BUG=617984
Review-Url: https://codereview.chromium.org/2044923004
Cr-Commit-Position: refs/heads/master@{#398712}
Fix arc_auth_service_unittest compile issue
The literal "false" was getting implicitly converted into NULL,
which caused a type conversion issue further down the line after
some template and macro expansion of the gtest utilities.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2049453004
Cr-Commit-Position: refs/heads/master@{#398711}
Prevent playback looping after pause.
Check is_playing_ vatiable in WMPA::OnPlaybackComplete
before restarting the player.
BUG=616772
Review-Url: https://codereview.chromium.org/2053473002
Cr-Commit-Position: refs/heads/master@{#398710}
Add support for inexact resize on X11
Support switching between existing modes when XRandR is available but
exact resize is not.
BUG=596125
Review-Url: https://codereview.chromium.org/2004613002
Cr-Commit-Position: refs/heads/master@{#398709}
Site Settings Desktop: Implement media picker for camera/mic categories.
BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2039833004
Cr-Commit-Position: refs/heads/master@{#398708}
Update CertVerifier::Verify to use RequestParams instead
CertVerifier::Verify() has some inconsistencies with
respect to how it handles additional trust anchors, which
complicates the layering and the caching.
Rather than just add an additional parameter to Verify(),
convert everything to use RequestParams, which also defines how
the caching/hashing is done.
BUG=612655
TBR=brettw
Review-Url: https://codereview.chromium.org/1994353002
Cr-Commit-Position: refs/heads/master@{#398707}
Upstream: Create WebAPK when user selects "Add to Home screen"
This CL makes "Add to Home Screen" create a WebAPK when a user runs Chrome with
the --enable-webapk command line flag and:
- Selects "Add to Home screen" from the app menu for a web app compatible app
OR
- Selects "Add to Home screen" from "Add to Home screen" infobar
BUG=609122
Review-Url: https://codereview.chromium.org/2031213004
Cr-Commit-Position: refs/heads/master@{#398706}
views/mus: Run some more tests from views_unittests in mus.
BUG=577274
Review-Url: https://codereview.chromium.org/2010083002
Cr-Commit-Position: refs/heads/master@{#398705}
Change //build/config/compiler:optimize_max to use -O3.
Certain components (e.g., v8) really want to be compiled with -O3,
but the current ":optimize_max" setting just used -O2. Since "max"
should theoretically mean "max", let's try making it be -O3 across
the board and see what happens.
[email protected]
BUG=616031
Review-Url: https://codereview.chromium.org/2048163002
Cr-Commit-Position: refs/heads/master@{#398704}
Update WebGL2 conformance test expectations on Linux AMD/Intel.
BUG=
TEST=
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2051623002
Cr-Commit-Position: refs/heads/master@{#398703}
Add cert_verify_tool utility to verify certs from command line.
BUG=167789
Review-Url: https://codereview.chromium.org/2016503002
Cr-Commit-Position: refs/heads/master@{#398702}
Mojo C++ bindings: Add an alias Foo::DataView for FooDataView.
This is useful when you need to write a partially specialized StructTraits to
work with both mojom::Foo and mojom::blink::Foo.
BUG=577686
Review-Url: https://codereview.chromium.org/2044233005
Cr-Commit-Position: refs/heads/master@{#398701}
MD User Manager: Change button background/text color in disabled state
BUG=618152
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2051473002
Cr-Commit-Position: refs/heads/master@{#398700}
Add token field to ClientSafeBrowsingReportReqeust.
In order to calculate CTRs of bad downloads, safe browsing needs information to
link ClientSafeBrowsingReportRequest (for downloads) and ClientDownloadResponse.
To achieve this, we add a token field to identify its corresponding
ClientDownloadResponse in the ClientSafeBrowsingReportRequest, and propagate it
with the same string in ClientDownloadResponse.token.
Also add a new download report type (DANGEROUS_DOWNLOAD_BY_API) to separately
track CTR of dangerous downloads go through download API.
BUG=615511
Review-Url: https://codereview.chromium.org/2029903002
Cr-Commit-Position: refs/heads/master@{#398699}
Don't get full hashes when there are no matching prefixes
R=vakh
BUG=611316
Review-Url: https://codereview.chromium.org/2040313003
Cr-Commit-Position: refs/heads/master@{#398698}
Roll src/third_party/skia/ 2a437e645..28215d44b (2 commits).
https://chromium.googlesource.com/skia.git/+log/2a437e64593a..28215d44b3f9
$ git log 2a437e645..28215d44b --date=short --no-merges --format='%ad %ae %s'
2016-06-08 brianosman Support running Viewer via android_gdb_app
2016-06-08 brianosman Fix mipmap generation on Nexus 5x & 6p devices.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2049253002
Cr-Commit-Position: refs/heads/master@{#398697}
Change Android GPU tests to use Chromium instead of content_shell.
As an added benefit, this should allow some of the multi-tab GPU tests
to be enabled on Android.
BUG=616392
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2046833003
Cr-Commit-Position: refs/heads/master@{#398696}
Fix restore windows chrome icon has no running status bar on shelf
The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it.
BUG=616179
TEST=manually test sees bug fixed
Review-Url: https://codereview.chromium.org/2051503002
Cr-Commit-Position: refs/heads/master@{#398695}
Unittests for ui::Event struct traits.
* Adds EchoEvent() to ui.mojom.TraitsTestService and uses it to verify
that we get the same event when we serialize and then deserialize an event.
* Fixes deserialization of tilt values.
* Changes constructor of ui::PointerEvent.
BUG=578206
Review-Url: https://codereview.chromium.org/2048513004
Cr-Commit-Position: refs/heads/master@{#398694}
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent
BUG=612843
NO_DEPENDENCY_CHECKS=true
Review-Url: https://codereview.chromium.org/2052593002
Cr-Commit-Position: refs/heads/master@{#398693}
Implement cc::FilterOperation StructTraits
FilterOperation is used by RenderPassDrawQuad whcih is used by CompostiorFrame.
This CL allows FilterOperation to be serialized over mojo.
BUG=611802
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2042413003
Cr-Commit-Position: refs/heads/master@{#398692}
Add BlitFramebuffer command buffer validation.
This makes deqp/functional/gles3/negativebufferapi.html pass.
BUG=429053
TEST=webgl2_conformance
[email protected],[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2050553002
Cr-Commit-Position: refs/heads/master@{#398691}
Add the Cryptohome.TpmResults histogram
After this CL: https://chromium-review.googlesource.com/#/c/349425/ has
landed, we need to add the TpmResults and its enum values.
BUG=430125
Review-Url: https://codereview.chromium.org/2043463002
Cr-Commit-Position: refs/heads/master@{#398690}
Manual refactor to enum-based WaitableEvent for remaining mac/ios files
BUG=612843
NO_DEPENDENCY_CHECKS=true
[email protected]
[email protected]
(Francois please fact check me, I'm TBRing dana for otherwise mechanical change)
Review-Url: https://codereview.chromium.org/2056443002
Cr-Commit-Position: refs/heads/master@{#398689}
Move ash/material_design to ash/common/material_design
Move ash/material_design files to a new
directory in ash/common.
BUG=618306
TEST=none
Review-Url: https://codereview.chromium.org/2047273003
Cr-Commit-Position: refs/heads/master@{#398688}
[Media Router] Assign each route a current cast mode if possible
This change gives each media route in the WebUI a current cast mode
value if its media source corresponds to one of the currently available
cast modes. This is to prevent showing the 'cast' button that allows
replacing the route when the new route would effectively be a copy of
the original route.
BUG=614144
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2040883002
Cr-Commit-Position: refs/heads/master@{#398687}
MruWindowTrackerTest for mash
BUG=617789,618058
TEST=test only change
[email protected]
Review-Url: https://codereview.chromium.org/2046633006
Cr-Commit-Position: refs/heads/master@{#398686}
Move 'frame-src' CSP checks into FrameFetchContext.
Currently, we're doing 'frame-src' checks inside 'FrameLoader', which
ends up being too early in the navigation cycle to handle the results
of 'upgrade-insecure-requests'. Happily, we've refactored enough of the
loading code in the last ~3 years that we can pretty easily move this
check into 'FrameFetchContext::canRequest' alongside the rest of CSP.
BUG=615910
Review-Url: https://codereview.chromium.org/2022083002
Cr-Commit-Position: refs/heads/master@{#398685}
Auto-rebaseline for r398645
https://chromium.googlesource.com/chromium/src/+/142a5307d
BUG=618402
[email protected]
Review URL: https://codereview.chromium.org/2052683002 .
Cr-Commit-Position: refs/heads/master@{#398684}
[Media Router] Close dialog after resolving presentation request
This change causes the Media Router dialog to close after it resolves a
route that is from a presentation request. This prevents the dialog from
staying open (by the user keeping their mouse over it) and reusing the
same presentation request for another route request (which is an error).
BUG=617321
[email protected]
Review-Url: https://codereview.chromium.org/2038423006
Cr-Commit-Position: refs/heads/master@{#398683}
Auto-rebaseline for r398650
https://chromium.googlesource.com/chromium/src/+/cbe578b0c
BUG=618402
[email protected]
Review URL: https://codereview.chromium.org/2056543002 .
Cr-Commit-Position: refs/heads/master@{#398682}
Fix 2D canvas entiring invalid state when painted during hibernation
painting a canvas while the canvas is in a hibernation state was causing
the canvas to allocate a non-accelerated surface backing, which would
later cause GPU texture preparation to fail after exiting from hibernation.
This fix prevents "Canvas2DLayerBridge::newImageSnapshot()" from triggering
the creation of a surface whil the canvas is in a hibernating state.
BUG=613513
Review-Url: https://codereview.chromium.org/2051513002
Cr-Commit-Position: refs/heads/master@{#398681}
[css-grid] Fix definite/indefinite size detection on block axis
LayoutBox::hasDefiniteLogicalHeight() was wrong as
it was not taking into account several cases
where the height is definite/indefinite.
E.g. it was not checking the special situations for flex items,
that despite of having height "auto" can definite sometimes.
As the method was buggy, this patch is directly removing it
and using LayoutBox::percentageLogicalHeightIsResolvable() instead.
Add new test to check that the flexbox case works as expected.
BUG=617876
TEST=fast/css-grid-layout/flex-item-grid-container-percentage-rows.html
Review-Url: https://codereview.chromium.org/2037383002
Cr-Commit-Position: refs/heads/master@{#398680}
Implement pointer lock API for out-of-process iframes.
This patch moves the MouseLockDispatcher from RenderView to RenderWidget and
implements the necessary plumbing to allow pointer locking from out-of-process
iframes.
TEST=Manual test please:
Navigate to http://scheib.github.io/HTMLMisc/PointerLockAndFullscreen-iframes.html
and verify that toggling pointer lock from all iframes work
as well as exiting* pointer lock. Verify that the mouse
movement continues to be tracked in the frame that locked
the pointer.
* Exiting can be done by ESC key, ALT-TAB (on Mac Command
Tab), Windows key to bring up start menu etc.
BUG=601926,419087
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1980133002
Cr-Commit-Position: refs/heads/master@{#398679}
Create a KeyboardEventManager class
Extract Keyboard related logic and events from
EventHandler and put it in a dedicate class.
BUG=616836
Review-Url: https://codereview.chromium.org/2036643003
Cr-Commit-Position: refs/heads/master@{#398678}
cc: Separate raster and decode prepaint regions.
This patch separates raster and decode distances to be
independent of each other. Specifically, any tile in prepaint
that is further than 1000 screen space pixels from the
viewport will not be rasterized. Instead, we will pull out
the images on those tiles and predecode those instead.
R=enne, ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2007163002
Cr-Commit-Position: refs/heads/master@{#398677}
Bump smaller tests to only require 4 devices.
NOTRY=True
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2055533002
Cr-Commit-Position: refs/heads/master@{#398676}
DevTools: update V8Inspector to work with the new v8_inspector API.
BUG=580337
NOTRY=true
Review-Url: https://codereview.chromium.org/2044343002
Cr-Commit-Position: refs/heads/master@{#398675}
Do not build the IPC fuzzer on chromium.lkgr debug bots.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2047323003
Cr-Commit-Position: refs/heads/master@{#398674}
DevTools: introduce browser domain for basic target discovery.
TBR=reillyg trivial change to internal function signature.
NOTRY=true
Review-Url: https://codereview.chromium.org/2047833002
Cr-Commit-Position: refs/heads/master@{#398673}
Add web platform pointerevents tests to Layouttest
Adding two of the tests and using eventsender and
gpu benchmarking to give inputs automatically to
them.
BUG=612924
Review-Url: https://codereview.chromium.org/1994683004
Cr-Commit-Position: refs/heads/master@{#398672}
Update V8 to version 5.3.183.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/af2ed87b..76fc8514
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2049193002
Cr-Commit-Position: refs/heads/master@{#398671}
Upstream: Only allow Chrome to use the WebAPK service
This CL checks the uid of the process calling into the WebAPK service against a
whitelist prior to allowing the WebAPK service to be used.
BUG=524670
TBR=hanxi (TBR for testing/ dependency in libs/runtime_library/junit)
R=rsesek
Review-Url: https://codereview.chromium.org/2028413002
Cr-Commit-Position: refs/heads/master@{#398670}
Fixes for turning on offliner request.
BUG=601173
Review-Url: https://codereview.chromium.org/2048923002
Cr-Commit-Position: refs/heads/master@{#398669}
Make the focus, caret, and cursor highlights fade out.
To minimize the distraction from having these highlights on the screen,
make all of them behave similarly to the cursor highlight and just fade
in quickly when changing, and then fade out slowly.
Because this conflicts with how the focus ring behaves when spoken
feedback is on, add a separate mode for that focus ring behavior.
BUG=314889
Review-Url: https://codereview.chromium.org/2046563009
Cr-Commit-Position: refs/heads/master@{#398668}
Revert of Only trigger session restore logic for urls if it is not first run. (patchset #2 id:20001 of https://codereview.chromium.org/2040193003/ )
Reason for revert:
broke tests in official builds
Original issue's description:
> Only trigger session restore logic for urls if it is not first run.
>
> The current logic trumped over start up urls specified in master_prefs
> because session restore simply ignored them. Instead of adding them to
> session restore we gate session restore logic on the absence of the
> first run flag. There should be no session to restore in this case anyway.
> Even if the user manually used the --force-first-run it makes sense to
> disregard the session restore code as this sounds more in line with the
> flag name.
>
> BUG=419580
> TEST=StartupBrowserCreatorFirstRunTest.FirstRunTabsWithRestoreSession
>
> Committed: https://crrev.com/da14eddd225351ab39f35acea8daf1b59d3fe4e5
> Cr-Commit-Position: refs/heads/master@{#398512}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=419580
Review-Url: https://codereview.chromium.org/2049263002
Cr-Commit-Position: refs/heads/master@{#398667}
target_cpu -> current_cpu in build/config/sanitizers/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2041433002
Cr-Commit-Position: refs/heads/master@{#398666}
Moving prefs observer code form ChromeLauncherController into a separate class.
BUG=NONE
Review-Url: https://codereview.chromium.org/2042843004
Cr-Commit-Position: refs/heads/master@{#398665}
clang-tidy WaitableEvent refactor (ChromeOS side)
BUG=612843
[email protected]
(purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO)
Review-Url: https://codereview.chromium.org/2056493002
Cr-Commit-Position: refs/heads/master@{#398664}
gpu: Disallow null client ids in Gen* functions
Gen* functions never return 0 as a valid id. Do not accept 0 as a valid id from an untrusted client.
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2043983002
Cr-Commit-Position: refs/heads/master@{#398663}
Roll src/third_party/skia/ 7942f22c6..2a437e645 (4 commits).
https://chromium.googlesource.com/skia.git/+log/7942f22c607c..2a437e64593a
$ git log 7942f22c6..2a437e645 --date=short --no-merges --format='%ad %ae %s'
2016-06-08 liyuqian Provide filter when there are many options
2016-06-08 csmartdalton Replace targetHasUnifiedMultisampling in GrPB constructor
2016-06-08 bsalomon When setting up a copySurface dst texture make the orientation match the src when glBlitFramebuffer requires it
2016-06-08 msarett Modify QCMS test to match use by Chrome
BUG=618122
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2044293003
Cr-Commit-Position: refs/heads/master@{#398662}
Update GN docs about target_cpu to encourage use of current_cpu
BUG=616819
Review-Url: https://codereview.chromium.org/2038733003
Cr-Commit-Position: refs/heads/master@{#398661}
Revert of service worker: Don't control a subframe of an insecure context (patchset #21 id:440001 of https://codereview.chromium.org/2009453002/ )
Reason for revert:
ServiceWorkerProviderHost::SetControllerVersionAttribute CHECK is firing in release builds: https://crbug.com/618365
Original issue's description:
> service worker: Don't control a subframe of an insecure context
>
> We must check isSecureContext when creating the network provider to
> adhere to https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged.
>
> We already did this for getRegistration(), register(), unregister() but must
> also do this when deciding whether to control an in-scope document.
>
> BUG=607543
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/59a2e54eeb0e61971a0c27c44c54dd0c30b5d06d
> Cr-Commit-Position: refs/heads/master@{#398229}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=607543
Review-Url: https://codereview.chromium.org/2055433002
Cr-Commit-Position: refs/heads/master@{#398660}
Add DisableIf annotation to EME test
EME test does not pass on AOSP Android, therefore, add DisableIf annotation to
it (from BaseInstrumentationTestRunner)
Reorganized BaseInstrumentationTestRunner so it doesn't include anything
unrelated to WebViewLayout Testing.
BUG=607350
Review-Url: https://codereview.chromium.org/1952573002
Cr-Commit-Position: refs/heads/master@{#398659}
Add role lists to ChromeVox.
- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus
BUG=617670
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2042083002
Cr-Commit-Position: refs/heads/master@{#398658}
Manual refactor to enum-based WaitableEvent for remaining _win files
BUG=612843
[email protected]
[email protected]
(Francois please fact check me, I'm TBRing dana for otherwise mechanical change)
Review-Url: https://codereview.chromium.org/2047163003
Cr-Commit-Position: refs/heads/master@{#398657}
StructTraits optimizations
Pass more things by const reference and read directly into output.
BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2047963004
Cr-Commit-Position: refs/heads/master@{#398656}
Remove type converters for ui::Event.
We are using struct traits for serializing/deserializing ui::Event and don't
need type converters anymore.
BUG=578206
Review-Url: https://codereview.chromium.org/2048633004
Cr-Commit-Position: refs/heads/master@{#398655}
Promote DCHECK to CHECK to help track down crashes.
BUG=595980
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2045283003
Cr-Commit-Position: refs/heads/master@{#398654}
Remove IPC::ParamTraits for ui::Event.
We decided to use struct traits for ui::Event and don't need the param traits
anymore.
This CL reverts the changes we don't need anymore in the following CLs:
* https://codereview.chromium.org/1695783002/
* https://codereview.chromium.org/1800633002/
BUG=584687
Review-Url: https://codereview.chromium.org/2049053003
Cr-Commit-Position: refs/heads/master@{#398653}
Migrate WaitableEvent to enum-based constructor for callsites using non-inlined bools.
As expected: clang-tidy couldn't auto-refactor those non-inlined bools
BUG=612843
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NO_DEPENDENCY_CHECKS=true
TBR=Have owners approval, skipping NO_DEPENDENCY_CHECKS bug for presubmit (http://crbug.com/616912)
Review-Url: https://codereview.chromium.org/2052573002
Cr-Commit-Position: refs/heads/master@{#398652}
Always disable session invalidations when not on the recent tabs page
This CL removes checking for the AndroidSessionNotifications field trial
Review-Url: https://codereview.chromium.org/2022303002
Cr-Commit-Position: refs/heads/master@{#398651}
Rebase two layout tests on Win10
Failure here:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11104
BUG=618402
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2048783003
Cr-Commit-Position: refs/heads/master@{#398650}
Use correct URL in Authenticator webview loadabort event handler
Fix to use the URL whose load was aborted, instead of the current
webview URL (which could be updated multiple times and therefore does
not necessarily correspond to this loadabort event).
This is just a cleanup fix, because the passed URL was anyway not used
by the listeners in the current code.
BUG=
TEST=manual: add logging to 'loadAbort' Authenticator event
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2052503002
Cr-Commit-Position: refs/heads/master@{#398649}
Move leak_detector_controller to its own directory
This new directory will hold future code that relates to the leak
detector as well.
BUG=chromium:615223
TEST=unit tests pass
Review-Url: https://codereview.chromium.org/2047163002
Cr-Commit-Position: refs/heads/master@{#398648}
Mark fast/js/regress/to-int32-boolean.html as timeout
This test seems to be timed out in multiple bots
BUG=618399
NOTRY=true
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2054493002
Cr-Commit-Position: refs/heads/master@{#398647}
Revert of Mojo: Eliminate duplicate C API symbols (patchset #1 id:1 of https://codereview.chromium.org/2048053003/ )
Reason for revert:
trying to revert again, and then clobber. seemed to have fixed the error locally
Original issue's description:
> Reland of Mojo: Eliminate duplicate C API symbols (patchset #1 id:1 of https://codereview.chromium.org/2047813003/ )
>
> Reason for revert:
> Reverting this didn't fix the failure after all
>
> Original issue's description:
> > Revert of Mojo: Eliminate duplicate C API symbols (patchset #3 id:80001 of https://codereview.chromium.org/2044023004/ )
> >
> > Reason for revert:
> > tentative revert due to linker errors. this doesn't make sense. nothing makes sense. RIP sanity
> >
> > Original issue's description:
> > > Mojo: Eliminate duplicate C API symbols
> > >
> > > This gets rid of the duplicate definitions of public
> > > Mojo C API symbols, instead making mojo/public/c/system
> > > the singular source of these definitions. This allows
> > > targets to be linked against mojo/public libraries
> > > without requiring any additional EDK dependencies at
> > > build time.
> > >
> > > To facilitate this the EDK uses the same set of API
> > > thunks as the public library, and the public library
> > > exposes a special embedder API (distinct from the DSO
> > > MojoSetSystemThunks call used by the native app loader)
> > > for setting these thunks. The MojoSetSystemThunks API
> > > is moved to a module which is only linked directly into
> > > app DSOs.
> > >
> > > Because mojo/public/c/system and mojo/edk/system are
> > > now both components, and because there are no longer
> > > redundant exports between the two, it's now safe for
> > > targets to depend on either one or both of them as
> > > needed without encountering duplicate definitions.
> > >
> > > Also some opportunistic cleanup of Mojo build rules.
> > >
> > > BUG=612500
> > >
> > > Committed: https://crrev.com/464e306a82ead839f02f1930a684400228b72495
> > > Cr-Commit-Position: refs/heads/master@{#398605}
> >
> > [email protected]
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=612500
> >
> > Committed: https://crrev.com/e8e242161954d86ce8e064f8a6515bc818d5b600
> > Cr-Commit-Position: refs/heads/master@{#398614}
>
> [email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=612500
>
> Committed: https://crrev.com/26ec28cabbdcc430483d5f4996b3afaafb1ba1bf
> Cr-Commit-Position: refs/heads/master@{#398622}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500
Review-Url: https://codereview.chromium.org/2054513002
Cr-Commit-Position: refs/heads/master@{#398646}
Rebaseline fast/images/color-profile-reflection.html
BUG=618402
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2051553002
Cr-Commit-Position: refs/heads/master@{#398645}
ios: Default GYP_GENERATORS to ninja, and error out if GYP_GENERATORS is xcode
m51 has shipped to stable, so nothing / nobody should still use
Xcode for building chrome/ios.
BUG=336575
Review-Url: https://codereview.chromium.org/2050793002
Cr-Commit-Position: refs/heads/master@{#398644}
Disable page_cycler(_v2).typical_25 on Nexus 5X WebView
[email protected]
BUG=616781
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2042323002
Cr-Commit-Position: refs/heads/master@{#398643}
Add UMA for rtcp-mux policy.
Add a function to WebRTCPeerConnectionHandler to log the selected Rtcp-mux policy.
Rtcp-mux policy is recorded after parsing the RTCConfiguration when creating the RTCPeerConnection object.
Review-Url: https://codereview.chromium.org/2013573005
Cr-Commit-Position: refs/heads/master@{#398642}
Mark printing/thead-repeats-at-top-of-each-page.html as failure
printing/thead-repeats-at-top-of-each-page.html
virtual/threaded/printing/thead-repeats-at-top-of-each-page.html
fails on Win10 even after rebaseline
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11102
BUG=618082
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2045013006
Cr-Commit-Position: refs/heads/master@{#398641}
IntersectionObserver: throw exceptions as spec mandates.
BUG=617396
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2046973003
Cr-Commit-Position: refs/heads/master@{#398640}
Add 64-bit bisect bot configs.
Renaming some bots in https://codereview.chromium.org/1972023002/ .
BUG=611484
Review-Url: https://codereview.chromium.org/2046823002
Cr-Commit-Position: refs/heads/master@{#398639}
Update WebGL2 conformanc test expectations for Linux NVidia with ANGLE
BUG=618408
TEST=linux gpu bot
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2055493002
Cr-Commit-Position: refs/heads/master@{#398638}
Reland of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #1 id:1 of https://codereview.chromium.org/2044253004/ )
Reason for revert:
around and around we go :D
Original issue's description:
> Revert of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #2 id:20001 of https://codereview.chromium.org/2043963005/ )
>
> Reason for revert:
> Didn't fix anything.
>
> Original issue's description:
> > cc : Make LayerImpl destruction independent of tree hierarchy
> >
> > Instead of deleting all layers when the root is deleted, we delete
> > all layers when the layer tree impl is shutdown.
> >
> > BUG=617791
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/e536d2292fa548ee6231ff23ac65203c261e4a14
> > Cr-Commit-Position: refs/heads/master@{#398606}
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=617791
>
> Committed: https://crrev.com/ef1625ae9feafee9ddaa2a58b9476175d7956b8b
> Cr-Commit-Position: refs/heads/master@{#398633}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617791
Review-Url: https://codereview.chromium.org/2049883002
Cr-Commit-Position: refs/heads/master@{#398637}
Remove SkDevice, obsolete constructor
We already have all the API we need to rewrite skia_utils_mac without
referring to the to-be-deprecated SkBaseDevice or its
BitmapPlatformDevice subclasses. Also get rid of a constructor that
was marked "TODO: delete this" and all of the expensive code behind
it which was *only* activated by unit tests.
[email protected]
BUG=543755
Review-Url: https://codereview.chromium.org/2001653002
Cr-Commit-Position: refs/heads/master@{#398636}
We did not set the pointer type for WebMouseEvent, which is created from NSEvent in
WebMouseEventBuilder::Build. Now we set the pointer type based on the NSEvent's
type to see if it is a tablet event or subtype of a mouse event to see its input device.
Reference:
https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/EventOverview/EventObjectsTypes/EventObjectsTypes.html#//apple_ref/doc/uid/10000060i-CH4-SW4
BUG=615122
Review-Url: https://codereview.chromium.org/2022843002
Cr-Commit-Position: refs/heads/master@{#398635}
Add ArrayTraits<CArray<T>> utility template
This CL adds a utility ArrayTraits class to read and write from and into a c array from StructTraits.
This CL also deletes duplicate code across various traits.
BUG=611802
[email protected], [email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2046563005
Cr-Commit-Position: refs/heads/master@{#398634}
Revert of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #2 id:20001 of https://codereview.chromium.org/2043963005/ )
Reason for revert:
Didn't fix anything.
Original issue's description:
> cc : Make LayerImpl destruction independent of tree hierarchy
>
> Instead of deleting all layers when the root is deleted, we delete
> all layers when the layer tree impl is shutdown.
>
> BUG=617791
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/e536d2292fa548ee6231ff23ac65203c261e4a14
> Cr-Commit-Position: refs/heads/master@{#398606}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617791
Review-Url: https://codereview.chromium.org/2044253004
Cr-Commit-Position: refs/heads/master@{#398633}
Reland of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #1 id:1 of https://codereview.chromium.org/2054483002/ )
Reason for revert:
Didn't fix anything
Original issue's description:
> Revert of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #2 id:20001 of https://codereview.chromium.org/2043963005/ )
>
> Reason for revert:
> Tentative revert for strange linker failures:
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/156821
>
> I already tried reverting the other CL in the blame list (mine) with no success. Doesn't make sense that this CL would cause it either, but just ruling it out. I'll revert the revert if the builder stays red.
>
> Original issue's description:
> > cc : Make LayerImpl destruction independent of tree hierarchy
> >
> > Instead of deleting all layers when the root is deleted, we delete
> > all layers when the layer tree impl is shutdown.
> >
> > BUG=617791
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/e536d2292fa548ee6231ff23ac65203c261e4a14
> > Cr-Commit-Position: refs/heads/master@{#398606}
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=617791
>
> Committed: https://crrev.com/f3a9e5397cce794930f73f6c6a43c0621ecf06a6
> Cr-Commit-Position: refs/heads/master@{#398623}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617791
Review-Url: https://codereview.chromium.org/2048863003
Cr-Commit-Position: refs/heads/master@{#398632}
blacklist some devices with buggy MediaCodec support
Some old Samsung devices have buggy support for MediaCodec, better fallback to MediaPlayer for them.
BUG=615872
[email protected],[email protected]
TEST=Play several youtube videos sequentially in the same tab on Samsung Galaxy S3 phone
Review-Url: https://codereview.chromium.org/2028433002
Cr-Commit-Position: refs/heads/master@{#398631}
[tools/perf] Delete unused variable
BUG=475714
Review-Url: https://codereview.chromium.org/1914233003
Cr-Commit-Position: refs/heads/master@{#398630}
Enable GpuRasterization.ConcavePaths on Nexus devices
Enable GpuRasterization.ConcavePaths on Nexus devices.
The test inspects browser screenshot pixels.
In order to take a screenshot, device pixel ratio is used
to scale the screenshot rect.
In order to correlate logical pixels to physical pixels with device
pixel ratio, viewport scale needs to be set to 1.
BUG=617805
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2045993004
Cr-Commit-Position: refs/heads/master@{#398629}
Fix bug in EOF handling during payload reads and writes.
Fix bug in EOF handling during payload reads and writes.
Add new regression tests to exercise that functionality.
Factor out socket read/write calls into DoRead()/DoWrite(), which manage the mapping from the zero EOF return value to net::ERR_CONNECTION_CLOSED.
[email protected]
BUG=617729
Review-Url: https://codereview.chromium.org/2040263002
Cr-Commit-Position: refs/heads/master@{#398628}
Check for registry and extension existence before web_accessible_resources.
BUG=618300
Review-Url: https://codereview.chromium.org/2048693004
Cr-Commit-Position: refs/heads/master@{#398627}
Roll src/third_party/skia/ 9a6cf800b..7942f22c6 (3 commits).
https://chromium.googlesource.com/skia.git/+log/9a6cf800bc39..7942f22c607c
$ git log 9a6cf800b..7942f22c6 --date=short --no-merges --format='%ad %ae %s'
2016-06-08 csmartdalton Fix instances where hwaa was wrong for mixed samples
2016-06-08 martina.kollarova Document dm error about missing skps
2016-06-08 herb Handle single pixel case on tiled.
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2050723002
Cr-Commit-Position: refs/heads/master@{#398626}
Shift rdsmith@ to watching all of content/browser/loader.
BUG=None
Review-Url: https://codereview.chromium.org/2047423002
Cr-Commit-Position: refs/heads/master@{#398625}
Fix SAML single-password scrapping authenticating with an empty password
Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.
BUG=618279,617962
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2049103002
Cr-Commit-Position: refs/heads/master@{#398624}
Revert of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #2 id:20001 of https://codereview.chromium.org/2043963005/ )
Reason for revert:
Tentative revert for strange linker failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/156821
I already tried reverting the other CL in the blame list (mine) with no success. Doesn't make sense that this CL would cause it either, but just ruling it out. I'll revert the revert if the builder stays red.
Original issue's description:
> cc : Make LayerImpl destruction independent of tree hierarchy
>
> Instead of deleting all layers when the root is deleted, we delete
> all layers when the layer tree impl is shutdown.
>
> BUG=617791
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/e536d2292fa548ee6231ff23ac65203c261e4a14
> Cr-Commit-Position: refs/heads/master@{#398606}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617791
Review-Url: https://codereview.chromium.org/2054483002
Cr-Commit-Position: refs/heads/master@{#398623}
Reland of Mojo: Eliminate duplicate C API symbols (patchset #1 id:1 of https://codereview.chromium.org/2047813003/ )
Reason for revert:
Reverting this didn't fix the failure after all
Original issue's description:
> Revert of Mojo: Eliminate duplicate C API symbols (patchset #3 id:80001 of https://codereview.chromium.org/2044023004/ )
>
> Reason for revert:
> tentative revert due to linker errors. this doesn't make sense. nothing makes sense. RIP sanity
>
> Original issue's description:
> > Mojo: Eliminate duplicate C API symbols
> >
> > This gets rid of the duplicate definitions of public
> > Mojo C API symbols, instead making mojo/public/c/system
> > the singular source of these definitions. This allows
> > targets to be linked against mojo/public libraries
> > without requiring any additional EDK dependencies at
> > build time.
> >
> > To facilitate this the EDK uses the same set of API
> > thunks as the public library, and the public library
> > exposes a special embedder API (distinct from the DSO
> > MojoSetSystemThunks call used by the native app loader)
> > for setting these thunks. The MojoSetSystemThunks API
> > is moved to a module which is only linked directly into
> > app DSOs.
> >
> > Because mojo/public/c/system and mojo/edk/system are
> > now both components, and because there are no longer
> > redundant exports between the two, it's now safe for
> > targets to depend on either one or both of them as
> > needed without encountering duplicate definitions.
> >
> > Also some opportunistic cleanup of Mojo build rules.
> >
> > BUG=612500
> >
> > Committed: https://crrev.com/464e306a82ead839f02f1930a684400228b72495
> > Cr-Commit-Position: refs/heads/master@{#398605}
>
> [email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=612500
>
> Committed: https://crrev.com/e8e242161954d86ce8e064f8a6515bc818d5b600
> Cr-Commit-Position: refs/heads/master@{#398614}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500
Review-Url: https://codereview.chromium.org/2048053003
Cr-Commit-Position: refs/heads/master@{#398622}
[perf] Re-enable system_health.memory_* benchmarks
Hopefully, the perf dashboard infrastructure will now be able to handle
the amount of data generated by the benchmark.
Nevertheless, we throw away all Numeric statistics (standard deviation,
sum, count, max, min and percentiles) except for the average using the
trick from https://codereview.chromium.org/2005233002/. This should
reduce the amount of data pushed to the dashboard approximately 6 times.
BUG=589726,610962,617117,catapult:#2340
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2012743002
Cr-Commit-Position: refs/heads/master@{#398621}
[perf] Prepare benchmarks for memory metric normalization
This is patch is necessary so that benchmarks using the memory metric
wouldn't stop reporting values once
https://codereview.chromium.org/2018503002/ lands.
BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2044853002
Cr-Commit-Position: refs/heads/master@{#398620}
Renaming CreateAdvertisementData() by AdvertisementData().
CreateAdvertisementData() doesn't return an object that should be released
anymore.
BUG=NONE
Review-Url: https://codereview.chromium.org/2041643002
Cr-Commit-Position: refs/heads/master@{#398619}
Remove the default wheel event handler from blink.
Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.
Also remove the WebSetting for wheel gesture support.
BUG=598798
Review-Url: https://codereview.chromium.org/2049493002
Cr-Commit-Position: refs/heads/master@{#398618}
Update V8 to version 5.3.182.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ff6dd4f4..af2ed87b
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2045353003
Cr-Commit-Position: refs/heads/master@{#398617}
exo: Avoid cross-fade animations for window without a configure callback.
When transitioning in/out of maximized or fullscreen mode we need to
make sure we have a configure callback before we allow the default
cross-fade animations. The configure callback provides a mechanism for
the client to inform us that a frame has taken the state change into
account and without this cross-fade animations are unreliable.
BUG=549781
TEST=exo_unittests
Review-Url: https://codereview.chromium.org/2049623002
Cr-Commit-Position: refs/heads/master@{#398616}
Add UMA histograms IOSurface creation and binding to a GL texture
There are reports that these calls sometimes hang for tens of
milliseconds. These reports appear to be coming from particular OS and
GPU combinations, using particular features.
These histograms will allow us to test these hypotheses.
BUG=580616
Review-Url: https://codereview.chromium.org/2044683003
Cr-Commit-Position: refs/heads/master@{#398615}
Revert of Mojo: Eliminate duplicate C API symbols (patchset #3 id:80001 of https://codereview.chromium.org/2044023004/ )
Reason for revert:
tentative revert due to linker errors. this doesn't make sense. nothing makes sense. RIP sanity
Original issue's description:
> Mojo: Eliminate duplicate C API symbols
>
> This gets rid of the duplicate definitions of public
> Mojo C API symbols, instead making mojo/public/c/system
> the singular source of these definitions. This allows
> targets to be linked against mojo/public libraries
> without requiring any additional EDK dependencies at
> build time.
>
> To facilitate this the EDK uses the same set of API
> thunks as the public library, and the public library
> exposes a special embedder API (distinct from the DSO
> MojoSetSystemThunks call used by the native app loader)
> for setting these thunks. The MojoSetSystemThunks API
> is moved to a module which is only linked directly into
> app DSOs.
>
> Because mojo/public/c/system and mojo/edk/system are
> now both components, and because there are no longer
> redundant exports between the two, it's now safe for
> targets to depend on either one or both of them as
> needed without encountering duplicate definitions.
>
> Also some opportunistic cleanup of Mojo build rules.
>
> BUG=612500
>
> Committed: https://crrev.com/464e306a82ead839f02f1930a684400228b72495
> Cr-Commit-Position: refs/heads/master@{#398605}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500
Review-Url: https://codereview.chromium.org/2047813003
Cr-Commit-Position: refs/heads/master@{#398614}
Remove unused NQE histograms
All these histograms have been replaced by other histograms.
BUG=615929,608587,608585
Review-Url: https://codereview.chromium.org/2036453003
Cr-Commit-Position: refs/heads/master@{#398613}
[Cronet] Make StartNetLog and StopNetLog synchronous in Cronet
CronetEngine.StartNetLogToFile and StopNetLog post asynchronous tasks to the
network thread. This results truncated logs if executing those tasks is slow on
the network thread. Since NetLog is a global and thread-safe, this CL creates
and tears down WriteToFileNetLogObserver on the calling Java thread. The access
to WriteToFileNetLogObserver is protected by a lock to ensure thread safety.
BUG=617632
Review-Url: https://codereview.chromium.org/2035313008
Cr-Commit-Position: refs/heads/master@{#398612}
sandwich: Fix an assertion failure cause by bad initiator inference
Devtools' inference of request initiatior is not that reliable,
loading to some javascript originated resources marked as
initiated from the parser.
This CL removes an assertion in sandwich_prefetch.py to not
unecessarly fail on some URLs where it happens more often.
BUG=582080
Review-Url: https://codereview.chromium.org/2043413002
Cr-Commit-Position: refs/heads/master@{#398611}
views/mus: Chaneg how Widget activation works in mus.
Install an aura::client::FocusClient implementation on NativeWidgetMus's aura
window-tree which focuses the mus::Window when the aura::Window is focused.
This change allows running some tests in views/focus/focus_manager_unittest.cc
under mus.
BUG=577274
Review-Url: https://codereview.chromium.org/2049723002
Cr-Commit-Position: refs/heads/master@{#398610}
Add option to android test_runner to specify what devices to run on.
BUG=612360
Review-Url: https://codereview.chromium.org/2045583004
Cr-Commit-Position: refs/heads/master@{#398609}
[chromedriver] Drop support for M49 and add 52.
BUG=
Review-Url: https://codereview.chromium.org/2041813005
Cr-Commit-Position: refs/heads/master@{#398608}
[MIPS] Don't use Gold for mipsel Android
Accidentally enabled Gold for mipsel Android in
https://codereview.chromium.org/2027173002/
Fixing it here.
BUG=webrtc:5977
Review-Url: https://codereview.chromium.org/2048063002
Cr-Commit-Position: refs/heads/master@{#398607}
cc : Make LayerImpl destruction independent of tree hierarchy
Instead of deleting all layers when the root is deleted, we delete
all layers when the layer tree impl is shutdown.
BUG=617791
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2043963005
Cr-Commit-Position: refs/heads/master@{#398606}
Mojo: Eliminate duplicate C API symbols
This gets rid of the duplicate definitions of public
Mojo C API symbols, instead making mojo/public/c/system
the singular source of these definitions. This allows
targets to be linked against mojo/public libraries
without requiring any additional EDK dependencies at
build time.
To facilitate this the EDK uses the same set of API
thunks as the public library, and the public library
exposes a special embedder API (distinct from the DSO
MojoSetSystemThunks call used by the native app loader)
for setting these thunks. The MojoSetSystemThunks API
is moved to a module which is only linked directly into
app DSOs.
Because mojo/public/c/system and mojo/edk/system are
now both components, and because there are no longer
redundant exports between the two, it's now safe for
targets to depend on either one or both of them as
needed without encountering duplicate definitions.
Also some opportunistic cleanup of Mojo build rules.
BUG=612500
Review-Url: https://codereview.chromium.org/2044023004
Cr-Commit-Position: refs/heads/master@{#398605}
Auto-rebaseline for r398556
https://chromium.googlesource.com/chromium/src/+/2feb7b70f
BUG=436475
[email protected]
Review URL: https://codereview.chromium.org/2045393002 .
Cr-Commit-Position: refs/heads/master@{#398604}
Moves ShellObserver to ash/common
BUG=581868
TEST=none
[email protected], [email protected], [email protected]
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2047373002
Cr-Commit-Position: refs/heads/master@{#398603}
In DevicePermissionsDialogView disable Connect button if no device selected
When no device selected in the dialog, the "Connect" button needs to be
disabled.
BUG=613596
Review-Url: https://codereview.chromium.org/2045093002
Cr-Commit-Position: refs/heads/master@{#398602}
Reland #2: Move side-loaded test data /sdcard -> /sdcard/gtestdata
Reason for reland:
- content_browsertests and component_browsertests updated to
clear the correct private data directory between test runs.
Uses delete_device_stale=True when pushing. This will prevent tests
mistakenly passing when they depend on stale data files from a previous test.
[email protected],[email protected],[email protected],[email protected]
BUG=607169,617213,616155
Review-Url: https://codereview.chromium.org/2043803003
Cr-Commit-Position: refs/heads/master@{#398601}
IntersectionObserver: use border bounding box for target rect.
BUG=617392
[email protected]
Review-Url: https://codereview.chromium.org/2046113002
Cr-Commit-Position: refs/heads/master@{#398600}
Moves MruWindowTracker to WmShell
We could also go with a ShellCommon and keep WmShell pure virtual, but
as this code is temporary I'm ok with making WmShell not pure virtual.
BUG=617789
TEST=covered by tests
[email protected]
Review-Url: https://codereview.chromium.org/2041423002
Cr-Commit-Position: refs/heads/master@{#398599}
[Android] Add expectations to flaky style-access-during-imageChanged-crash.html test
The test is already marked as either crashing or passing.
Add 'failure' expectation, because it fails occasionally on
the WebKit Android (Nexus 4) bot.
BUG=618349
[email protected],[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2044333003
Cr-Commit-Position: refs/heads/master@{#398598}
Add AntiVirus information to the system profile.
Collection happens after Google Update data has been collected and
before drive metrics data, on the FILE thread.
BUG=615154
TEST=unit_tests
TEST=manual, check system profile contains AV information via logging.
Review-Url: https://codereview.chromium.org/2009773007
Cr-Commit-Position: refs/heads/master@{#398597}
Fix a bug in ServiceWorkerPageLoadMetricsObserver and add unit tests.
PageLoad.Clients.ServiceWorker.DocumentTiming.NavigationToLoadEventFired.inbox UMA is not correctly measured.
BUG=611283
Review-Url: https://codereview.chromium.org/2050603002
Cr-Commit-Position: refs/heads/master@{#398596}
Move IPC fuzzer switches and helpers from chrome/common to content/common.
BUG=607649
Review-Url: https://codereview.chromium.org/2043933002
Cr-Commit-Position: refs/heads/master@{#398595}
Roll src/third_party/skia/ 2feb0938d..9a6cf800b (1 commit).
https://chromium.googlesource.com/skia.git/+log/2feb0938dcf2..9a6cf800bc39
$ git log 2feb0938d..9a6cf800b --date=short --no-merges --format='%ad %ae %s'
2016-06-08 egdaniel Subclass GrVkCommandBuffer into Primary and Secondary CommandBuffers.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2053433002
Cr-Commit-Position: refs/heads/master@{#398594}
Roll src/third_party/catapult/ b7c8c4252..901f7edd7 (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b7c8c42523e2..901f7edd757b
$ git log b7c8c4252..901f7edd7 --date=short --no-merges --format='%ad %ae %s'
BUG=552376,472699
[email protected]
Review-Url: https://codereview.chromium.org/2043263005
Cr-Commit-Position: refs/heads/master@{#398593}
Update V8 to version 5.3.177.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/13258f93..ff6dd4f4
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2050663002
Cr-Commit-Position: refs/heads/master@{#398592}
Roll src/third_party/ffmpeg/ 7f03319b9..bcb8b67b8 (1 commit).
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/7f03319b9d5a..bcb8b67b8b97
$ git log 7f03319b9..bcb8b67b8 --date=short --no-merges --format='%ad %ae %s'
2016-05-28 michael Cherry-picking overflow related security fixes/undefined behaviors
BUG=614034
Review-Url: https://codereview.chromium.org/2047893002
Cr-Commit-Position: refs/heads/master@{#398591}
Add SurfaceSequence mojom file to cc/ipc and edit corresponding GYP file
This patch is to facilitate landing a new mojo service in another patch
(https://codereview.chromium.org/2036663003/) which requires
to import both surface_id and surface_sequence in mojom files. It adds
surface_sequence.mojom and include both it and surface_id.mojom into GYP
compilation (Currently it's only included in GN build).
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2043833002
Cr-Commit-Position: refs/heads/master@{#398590}
Prevent PassphraseDialogFragment from modifying the default AlertDialogEditText background Drawable.
BUG=602943
Review-Url: https://codereview.chromium.org/2045203002
Cr-Commit-Position: refs/heads/master@{#398589}
Switch the file-type pusher to invoke Ninja
R=vakh
BUG=616141
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2040053002
Cr-Commit-Position: refs/heads/master@{#398588}
clovis: Add default tracing categories to trace_task_handler.py.
This is needed following https://codereview.chromium.org/2047463002.
Review-Url: https://codereview.chromium.org/2050703002
Cr-Commit-Position: refs/heads/master@{#398587}
target_cpu -> current_cpu in base/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2033393003
Cr-Commit-Position: refs/heads/master@{#398586}
[GN] Configure a pool for copy_bundle_data and compile_xcassets tools.
Reduce the number of tasks using the copy_bundle_data and compile_xcassets
tools as they can cause lots of I/O contention when invoking ninja with a
large number of parallel jobs (e.g. when using distributed build like goma).
Use the same depth as the link_pool (but in a separate pool).
BUG=612786
Review-Url: https://codereview.chromium.org/2018553003
Cr-Commit-Position: refs/heads/master@{#398585}
Fix generation of Xcode project.
Issue https://codereview.chromium.org/2005483002 changed the code to
use FindExtension() instead of base::FilePath::Extension() but did
not accomodate for the fact that the extension is now returned without
the leading dot.
Fix this by changed all the extension values used for comparison to
not include the leading dot either. This restore the source indexation
when opening the project with Xcode.
BUG=297668
Review-Url: https://codereview.chromium.org/2046373002
Cr-Commit-Position: refs/heads/master@{#398584}
[Android] Disable flaky BattOrCases telemetry_perf_unittest
Flakes on Android Tests bot.
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests
BUG=618330
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
NOTRY=true
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2049113002
Cr-Commit-Position: refs/heads/master@{#398583}
Remove paths in WPTServeExpectations that no longer exist.
After the last import, we got a few new lint errors for tests that don't exist now:
--lint-test-files warnings:
LayoutTests/WPTServeExpectations:17 Path does not exist. imported/wpt/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html
LayoutTests/WPTServeExpectations:18 Path does not exist. imported/wpt/html/editing/focus/document-level-focus-apis/document-level-apis.html
LayoutTests/WPTServeExpectations:31 Path does not exist. imported/wpt/html/semantics/selectors/pseudo-classes/focus.html
This change removes those lines from WPTServeExpectations.
Review-Url: https://codereview.chromium.org/2047153002
Cr-Commit-Position: refs/heads/master@{#398582}
Roll WebGL f43726c..0e41a33
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f43726c..0e41a33
BUG=
NOTRY=true
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2041193007
Cr-Commit-Position: refs/heads/master@{#398581}
Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Provider.
When the user presses Ctrl-K or Ctrl-E:
Transition the user into keyword mode using their default search provider. Pressing Ctrl-K will give the omnibox focus, and will display "Search Google:" on the left. If the user has already entered text into the omnibox and presses Ctrl-K, their text will be preserved, but they will be transitioned into keyword mode anyway. If the user is already in keyword mode (even if it's with a non-default search provider), the text they have entered will become selected. Upon pressing backspace, they will be left with an empty omnibox.
When the user types '?' into the omnibox:
If the user types or pastes a '?' at the beginning of their (possibly empty) input text, transition them into keyword mode with their default search provider. Upon pressing backspace, the omnibox will be left '?' (and their input).
Remove forced queries. We should be able to search for '?' directly.
BUG=267629,592540
Review-Url: https://codereview.chromium.org/1855423003
Cr-Commit-Position: refs/heads/master@{#398580}
Roll WebRTC 13067:13070
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f20a14b..393886f
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2049093002
Cr-Commit-Position: refs/heads/master@{#398579}
Improves computation of IAccessible2 Hypertext.
1. Ensures that children that are in a different subtree are included in IA2 Hypertext.
2. Stops exposing the value of a rich text control in IA2 Hypertext.
BUG=614570
TESTED=NVDA,browser test
[email protected]
Review-Url: https://codereview.chromium.org/2040523002
Cr-Commit-Position: refs/heads/master@{#398578}
target_cpu -> current_cpu in remoting/android/BUILD.gn, remoting_apk_tmpl.gni
BUG=616819
Review-Url: https://codereview.chromium.org/2038113002
Cr-Commit-Position: refs/heads/master@{#398577}
Mark KioskTest.LaunchAppNetworkDownConfigureNotAllowed failure on Chrome OS
BUG=618326
[email protected]
Review-Url: https://codereview.chromium.org/2048713004
Cr-Commit-Position: refs/heads/master@{#398576}
Add a buildflag to use the handle verifier in a per module mode.
The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
Cr-Commit-Position: refs/heads/master@{#398361}
BUG=618205
Review-Url: https://codereview.chromium.org/1977833003
Cr-Commit-Position: refs/heads/master@{#398575}
Auto-rebaseline for r398545
https://chromium.googlesource.com/chromium/src/+/67a46a72b
BUG=618082
[email protected]
Review URL: https://codereview.chromium.org/2043383002 .
Cr-Commit-Position: refs/heads/master@{#398574}
target_cpu -> current_cpu in chrome/android/chrome_public_apk_tmpl.gni
BUG=616819
Review-Url: https://codereview.chromium.org/2039523002
Cr-Commit-Position: refs/heads/master@{#398573}
Switch the default mode for content verification to ENFORCE_STRICT
This includes adding a class that can be used to ignore content
verification failures in tests which needed to be used in a couple of
places.
BUG=601512
Review-Url: https://codereview.chromium.org/2038213003
Cr-Commit-Position: refs/heads/master@{#398572}
Add basic SkBitmap StructTraitsTest.
BUG=618103
TEST=automated
[email protected]
Review-Url: https://codereview.chromium.org/2044313002
Cr-Commit-Position: refs/heads/master@{#398571}
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn
and gpu/tools/compositor_model_bench/BUILD.gn
target_cpu does not differ based on the current toolchain,
so it should basically never be used.
BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2031403002
Cr-Commit-Position: refs/heads/master@{#398570}
target_cpu -> current_cpu in cc/BUILD.gn
BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2035753005
Cr-Commit-Position: refs/heads/master@{#398569}
MD User Manager: Save "add person" page state when navigating to "learn more" page and back.
It does so by not detaching the "add person" element from the page when either "add person" or "learn more" pages are visible.
BUG=610448
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2040003003
Cr-Commit-Position: refs/heads/master@{#398568}
target_cpu -> current_cpu in build/config/compiler/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2034133002
Cr-Commit-Position: refs/heads/master@{#398567}
target_cpu -> current_cpu in chrome/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2031953004
Cr-Commit-Position: refs/heads/master@{#398566}
target_cpu -> current_cpu in mojo/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2031923004
Cr-Commit-Position: refs/heads/master@{#398565}
target_cpu -> current_cpu in tools/perf/chrome_telemetry_build/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2041443002
Cr-Commit-Position: refs/heads/master@{#398564}
target_cpu -> current_cpu in components/BUILD.gn
BUG=616819
Review-Url: https://codereview.chromium.org/2035113003
Cr-Commit-Position: refs/heads/master@{#398563}
Roll src/third_party/catapult/ 76c85eb0a..b7c8c4252 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/76c85eb0ad15..b7c8c42523e2
$ git log 76c85eb0a..b7c8c4252 --date=short --no-merges --format='%ad %ae %s'
BUG=617547
[email protected]
Review-Url: https://codereview.chromium.org/2052463002
Cr-Commit-Position: refs/heads/master@{#398562}
Fix Document::firstPartyForCookies() for OOPIFs.
The current usage of topDocument() in firstPartyForCookies() isn't
correct, since topDocument() doesn't actually always return the top
frame's Document, even when it's local. For example, this will happen
when called from the bottom frame in an A-B-A hierarchy.
In addition, when the top frame is remote, topDocumentURL should use
the top frame's origin, rather than the current frame's origin.
BUG=617677
Review-Url: https://codereview.chromium.org/2046593003
Cr-Commit-Position: refs/heads/master@{#398561}
PlzNavigate: update test filters
This CL updates the test filters for the FYI bot LinuxBrowserSideNavigation.
Making this NOTRY since there are no code changes and this is for an FYI bot.
BUG=475027,576261
[email protected]
NOTRY=TRUE
Review-Url: https://codereview.chromium.org/2049763002
Cr-Commit-Position: refs/heads/master@{#398560}
[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)
This CL relands the original issue https://codereview.chromium.org/1652483002/,
with modifications and for aura only (Linux, Windows, etc.). T
A TextInputManager is introduced which owned by the RenderWidgetHostDelegate
(mostly, WebContentsImpl). Each RWHV will observe the TextInputManager for its destruction
and lifetime while the TextInputManager observers all the RWHVs on the tab.
The role of the TextInputManager is to bookkeep and store TextInputState from all RWHV and
provide the correct TextInputState and the RWHV with active TextInputState at anytime. These
information are used by the tab-RWHV in handling IME related tasks.
This CL also adds several tests and some utility methods to help testing IME and TextInputState
for OOPIF.
BUG=578168, 602723
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1948343002
Cr-Commit-Position: refs/heads/master@{#398559}
Enable per thread heap for database thread
BUG=591606
Committed: https://crrev.com/993e3a74102e0843bebb2f52de1a904f151843d4
Review-Url: https://codereview.chromium.org/1909813002
Cr-Original-Commit-Position: refs/heads/master@{#397383}
Cr-Commit-Position: refs/heads/master@{#398558}
[Android] Disable two failing VideoPlayTillCompletion media unit tests.
Both MediaCodecDecoderTest.VideoPlayTillCompletion and
MediaCodecPlayerTest.VideoPlayTillCompletion are currently
failing on the release-phone bot.
BUG=618274
[email protected],[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2047303002
Cr-Commit-Position: refs/heads/master@{#398557}
Enable filter-based -webkit-box-reflect.
BUG=436475
Review-Url: https://codereview.chromium.org/2046883003
Cr-Commit-Position: refs/heads/master@{#398556}
arc: Correctly restart after Chrome crash
It turns out that the path taken by normal Chrome initialization and
recovery after a crash are vastly different, and we were not
initializing ARC in the latter case. This change now notifies ARC of the
Profile availability and starts correctly.
BUG=b/26757860
TEST=chrome://inducebrowsercrashforrealz
Review-Url: https://codereview.chromium.org/2041083003
Cr-Commit-Position: refs/heads/master@{#398555}
Roll src/third_party/skia/ dae6b9770..2feb0938d (1 commit).
https://chromium.googlesource.com/skia.git/+log/dae6b97705fd..2feb0938dcf2
$ git log dae6b9770..2feb0938d --date=short --no-merges --format='%ad %ae %s'
2016-06-08 egdaniel Add support for finding/creating general GrVkRenderPass from the VkResourceProvider.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2042043005
Cr-Commit-Position: refs/heads/master@{#398554}
Wait for correct callback in CustomTabActivityTestBase
CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.
BUG=618064
Review-Url: https://codereview.chromium.org/2039773006
Cr-Commit-Position: refs/heads/master@{#398553}
Remove use of deprecated MessageLoop methods in net.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2034473005
Cr-Commit-Position: refs/heads/master@{#398552}
Prefetch active tab state.
- Store the active tab id as a shared preference every time the tab
list is saved.
- Add a new AsyncTask to prefetch the previous active tab's TabState.
The results of this task is used instead of synchronously restoring
the active tab's TabState on startup.
- Currently, if the active tab model is incognito, then this will not
speed up startup. The active incognito tab (if any) can be
considered for prefetching later.
BUG=612574, 149625
Review-Url: https://codereview.chromium.org/2028683003
Cr-Commit-Position: refs/heads/master@{#398551}
Roll WebRTC 13031:13067
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8a95a05..f20a14b
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2045053003
Cr-Commit-Position: refs/heads/master@{#398550}
Remove use of deprecated MessageLoop methods in crypto.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2033193002
Cr-Commit-Position: refs/heads/master@{#398549}
Revert of [webnfc] Implement push() method in blink nfc module. (patchset #17 id:380001 of https://codereview.chromium.org/1708543002/ )
Reason for revert:
The tests:
nfc/mock-nfc.html
nfc/push.html
added by this CL timed out on these two bots:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/65781
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/18764
Original issue's description:
> [webnfc] Implement push() method in blink nfc module.
>
> This patch implements nfc.push() and nfc.cancelPush() methods in nfc module.
>
> https://w3c.github.io/web-nfc/#dom-nfc-push
> https://w3c.github.io/web-nfc/#dom-nfc-cancelpush
>
> Mock mojo service and simple layout test is added to validate input parameters
> as well as conversion between WebNFC and corresponding mojo data structures.
>
> BUG=520391
>
> Committed: https://crrev.com/5058e32db5582978f60a28bc0ccbeed0a7421283
> Cr-Commit-Position: refs/heads/master@{#398538}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=520391
Review-Url: https://codereview.chromium.org/2052473002
Cr-Commit-Position: refs/heads/master@{#398548}
Revert of Mark printing/thead-repeats-at-top-of-each-page.html as failing on Win10 (patchset #1 id:1 of https://codereview.chromium.org/2049013002/ )
Reason for revert:
Trybots are unhappy and did not flag it in the CQ.
LayoutTests/TestExpectations:1329 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:1075 and LayoutTests/TestExpectations:1329. printing/thead-repeats-at-top-of-each-page.html
LayoutTests/TestExpectations:1330 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:1076 and LayoutTests/TestExpectations:1330. virtual/threaded/printing/thead-repeats-at-top-of-each-page.html
Original issue's description:
> Mark printing/thead-repeats-at-top-of-each-page.html as failing on Win10
>
> BUG=618082,24826
> [email protected]
> NOTRY=true
>
> Committed: https://crrev.com/51ddb081cea0371a8dd329a7cfe2a6973f11b661
> Cr-Commit-Position: refs/heads/master@{#398540}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618082,24826
Review-Url: https://codereview.chromium.org/2049073002
Cr-Commit-Position: refs/heads/master@{#398547}
Roll src/third_party/catapult/ 07ffcecfd..76c85eb0a (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/07ffcecfda93..76c85eb0ad15
$ git log 07ffcecfd..76c85eb0a --date=short --no-merges --format='%ad %ae %s'
BUG=618174
[email protected]
Review-Url: https://codereview.chromium.org/2052453002
Cr-Commit-Position: refs/heads/master@{#398546}
Rebaseline printing/thead-repeats-at-top-of-each-page.html again
It seems that after this rebaseline CL:
https://codereview.chromium.org/2042583002
This test is still missing its expected test result on Win 10. This CL
sends another rebaseline.
See failure here for details:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
BUG=618082
Review-Url: https://codereview.chromium.org/2044393002
Cr-Commit-Position: refs/heads/master@{#398545}
Listen for sync status change to update sync error icon in SigninPreference
BUG=617874
Review-Url: https://codereview.chromium.org/2047863002
Cr-Commit-Position: refs/heads/master@{#398544}
Sets allowThreadDiskReads in hasOAuth2RefreshToken for RefreshTokenIsAvailable
On Android, RefreshTokenIsAvailable is called before user signed in to prefetch user info. So check with the accounts in Android is the most convenient and reliable way to implement it.
BUG=617309
Review-Url: https://codereview.chromium.org/2049473002
Cr-Commit-Position: refs/heads/master@{#398543}
Add a preference for disabling vibration in notifications.
Settings > Site settings > Notifications > Vibrate
Screenshot: http://imgur.com/Dt2XwUI
BUG=543534
Review-Url: https://codereview.chromium.org/2039953002
Cr-Commit-Position: refs/heads/master@{#398542}
Clovis: add queueing information to report.
Adds queuing metrics and updates the bigquery schema appropriately. Slight
change in queuing_lens to make debugging easier (too many generators are
annoying...).
Review-Url: https://codereview.chromium.org/2048023002
Cr-Commit-Position: refs/heads/master@{#398541}
Mark printing/thead-repeats-at-top-of-each-page.html as failing on Win10
BUG=618082,24826
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2049013002
Cr-Commit-Position: refs/heads/master@{#398540}
Modelled on base/base64url.h.
Modifies chrome/installer/util/shell_util to use this component.
It will soon be used by components/certificate_transparency as well.
Discussion:
https://groups.google.com/a/chromium.org/forum/?pli=1#!topic/chromium-dev/pieHLJZZE7k
BUG=612439
Review-Url: https://codereview.chromium.org/2017123002
Cr-Commit-Position: refs/heads/master@{#398539}
[webnfc] Implement push() method in blink nfc module.
This patch implements nfc.push() and nfc.cancelPush() methods in nfc module.
https://w3c.github.io/web-nfc/#dom-nfc-push
https://w3c.github.io/web-nfc/#dom-nfc-cancelpush
Mock mojo service and simple layout test is added to validate input parameters
as well as conversion between WebNFC and corresponding mojo data structures.
BUG=520391
Review-Url: https://codereview.chromium.org/1708543002
Cr-Commit-Position: refs/heads/master@{#398538}
Revert of Use element id's for animations (patchset #34 id:650001 of https://codereview.chromium.org/1973083002/ )
Reason for revert:
This caused: https://bugs.chromium.org/p/chromium/issues/detail?id=618286
Original issue's description:
> Use element id's for animations.
>
> The goal of this CL is to migrate cc's animation code
> away from layer id's in anticipation of SPv2. The ids
> chosen are a minor tweak on DOMNodeIds for blink.
>
> Other clients of cc may essentially continue using
> their respective layer id's as identifiers. cc itself
> remains ignorant of the semantic meaning of these ids,
> treating them as an opaque identifier.
>
> This change is extremely similar to loyso@'s earlier
> CL crrev.com/1944623002, the significant difference
> being the scheme for choosing the ids.
>
> Notable changes in this CL
> * Introduces an ElementId structure.
> * Augments DOMNodeIds in order to handle sub elements (eg, for scroll and link highlight layers).
> * Removal of ElementLayers from cc
>
> BUG=616542
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d
> Cr-Commit-Position: refs/heads/master@{#398366}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616542
Review-Url: https://codereview.chromium.org/2049063002
Cr-Commit-Position: refs/heads/master@{#398537}
Update V8 to version 5.3.175.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/481e002d..13258f93
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2047323002
Cr-Commit-Position: refs/heads/master@{#398536}
[css-grid] Percentage columns can always be resolved during layout
The issue is that the inline size of the grid container
is only indefinite while we're computing the intrinsic sizes.
During layout we should be able to resolve the percentage tracks
against that size.
This makes Grid Layout compatible with regular blocks regarding
how inline percentages are resolved.
The patch passes the SizingOperation enum to LayoutGrid::gridTrackSize().
That way we can know if we're computing the intrinsic sizes or not.
It also gets rid of LayoutBox::hasDefiniteLogicalWidth()
as it was wrong and not needed actually.
Created a new test verifying the expected behavior. Updated the results
in a few tests too.
BUG=616716
TEST=fast/css-grid-layout/grid-container-percentage-columns.html
Review-Url: https://codereview.chromium.org/2033033002
Cr-Commit-Position: refs/heads/master@{#398535}
Skeleton of the Safe Browsing Subresource Filter.
This CL lays down the foundation for future work on the subresource filter
component. See the 'intent to implement' posted to security-dev@, under the
title "Extend Safe Browsing protection to embedded sub-resources".
In response to finding that many users proceed through Safe Browsing warning
interstitials that are displayed when the site ahead contains deceptive
embedded content, we would like provide another layer of protection for these
users. After the interstitial has been shown, clicked through and when the
actual content on the page is loaded, this component will be used to filter
network requests for some embedded sub-resources on these sites.
This CL concerns itself merely with adding the skeleton of the architecture,
plus a mock filter to be used in browsertests that disallows all subresource
loads. The component is disabled and has no effect in production code.
BUG=609747
[email protected]
Review-Url: https://codereview.chromium.org/2022783002
Cr-Commit-Position: refs/heads/master@{#398534}
Adds benchmarks to measure code size reductions when using ignition.
Adds two benchmarks to measure the code size reductions in ignition.
The benchmarks run the same set of pages, once with ignition flag enabled
and once without ignition flag. This allows us to measure the code
size measurements in ignition.
BUG=v8:5019
LOG=N
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/1982393002
Cr-Commit-Position: refs/heads/master@{#398533}
Roll src/third_party/skia/ 2af4599b5..dae6b9770 (1 commit).
https://chromium.googlesource.com/skia.git/+log/2af4599b5c51..dae6b97705fd
$ git log 2af4599b5..dae6b9770 --date=short --no-merges --format='%ad %ae %s'
2016-06-08 caryclark fix pathops fuzz bugs
BUG=617586,617635
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2048983003
Cr-Commit-Position: refs/heads/master@{#398532}
tools/android/loading: Add predicted NoStatePrefetch ms to report.py
This CL adds the predicted time to user satisfaction of a load with
NoStatePrefetch enabled to report.py.
Review-Url: https://codereview.chromium.org/2046983002
Cr-Commit-Position: refs/heads/master@{#398531}
Added CEReactions tag to disableRemotePlayback attribute
BUG=None
Review-Url: https://codereview.chromium.org/2050633002
Cr-Commit-Position: refs/heads/master@{#398530}
[CacheStorage] Clean up CacheStorageCache lifetimes
CacheStorageCache refptrs are held in callbacks to cache operations, meaning that they won't be destructed
on profile shutdown. This CL moves the refptrs to member variables so that they will.
BUG=617683
Review-Url: https://codereview.chromium.org/2040173002
Cr-Commit-Position: refs/heads/master@{#398529}
Roll src/third_party/catapult/ 91544e364..07ffcecfd (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/91544e36495b..07ffcecfda93
$ git log 91544e364..07ffcecfd --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2045213002
Cr-Commit-Position: refs/heads/master@{#398528}
tools/android/loading: Make task_manager.ListResumingTasksToFreeze returning an ordered list
Before, task_manager.ListResumingTasksToFreeze was returning a set
of tasks, but that could led to tests failures when testing resuming
file content in task_manager_unittest.CommandLineControlledExecutionTest.
This CL fixes this issue by ordering returning list of tasks to freeze
ordered as they were discovered by the depth first browsing.
BUG=582080
Review-Url: https://codereview.chromium.org/2047513003
Cr-Commit-Position: refs/heads/master@{#398527}
sandwich: Log to different file at each run.
BUG=582080
Review-Url: https://codereview.chromium.org/2044703003
Cr-Commit-Position: refs/heads/master@{#398526}
Revert of Remove suppressions for bug 258479 (races in SamplingStateScope::set()) (patchset #1 id:1 of https://codereview.chromium.org/2039923003/ )
Reason for revert:
The bug hasn't actually been fixed.
Original issue's description:
> Remove suppressions for bug 258479 (races in SamplingStateScope::set())
>
> BUG=258479
> [email protected]
>
> Committed: https://crrev.com/8ce4772a273e2f594c9c1410211caf2dcae3446f
> Cr-Commit-Position: refs/heads/master@{#398515}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=258479
Review-Url: https://codereview.chromium.org/2046953003
Cr-Commit-Position: refs/heads/master@{#398525}
More Dr. Memory suppressions:
-- UAF errors in WebRtcMediaRecorderTest.MediaRecorderStartWithTimeSlice/2
(issue 618265)
-- updated the suppression for issue 398547 (uninit value passed to
NtWriteFile)
BUG=398547,618265
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2048013002
Cr-Commit-Position: refs/heads/master@{#398524}
Update V8 to version 5.3.174.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8f5b9d25..481e002d
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2043323002
Cr-Commit-Position: refs/heads/master@{#398523}
Add a "not signed in" condition to the Sync promo in the password bubble.
BUG=615825
Review-Url: https://codereview.chromium.org/2049503004
Cr-Commit-Position: refs/heads/master@{#398522}
VEA Test: revert timestamp test
Reverting timestamp unit test in VEA would make the broken VEA tests
pass. I will fix the test in another CL.
BUG=614925
TEST=VEA tests pass
Review-Url: https://codereview.chromium.org/2044203003
Cr-Commit-Position: refs/heads/master@{#398521}
Remove the list of reliability tests URLs
We don't have reliability tests anymore.
BUG=45482
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2049653003
Cr-Commit-Position: refs/heads/master@{#398520}
Explicit management of FrameSelection availability
This patch makes |FrameSelection| availability explicitly by observing document
attach/detach with introducing |FrameSelection::isAvailable| and checking it
before using |FrameSelection| to avoid using unavailable |FrameSelection| for
improving code health.
The lifetime of |FrameSelection| is as same as |LocalFrame|, but it is
available during associated |Document| object is attached to |LayoutView|.
Before this patch, Blink uses unavailable |FrameSeleciton| in some code path,
e.g. callbacks invoked by |FrameSelection::prepareDestructor| via setting
null positions to selection for resetting, and |SelectionController| attempts
to use |FrameSelection| associated to detached |Document|.
After this patch, |FrameSelection| holds pointer to attached |Document| or
|nullptr| to indicate availability of |FrameSelection|.
Note: I considered to make |DOMWindow| to own |FrameSelection| for avoiding to
observe document attach/detach, but I didn't. Because lifetime of |DOMWindow|
isn't as same as |Document|, e.g. |DOMWindow| is constructed before |Document|
and lifetime of |DOMWindow| is longer than |LayoutView| of |Document|. Given
that, I need to observer attach/detach and it isn't simpler than this patch.
BUG=n/a
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2001083002
Cr-Commit-Position: refs/heads/master@{#398519}
Create new directory for budget_service.
The budget service is going to be expanded in the future.
Rather than pollute the push_messaging directory with the
general purpose budget service, this separates it out into
its own directory.
BUG=617971
Review-Url: https://codereview.chromium.org/2039283002
Cr-Commit-Position: refs/heads/master@{#398518}
Update V8 to version 5.3.172.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0fc60462..8f5b9d25
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2045173002
Cr-Commit-Position: refs/heads/master@{#398517}
Enhanced the SquareInkDropRipple to be able to draw a circle for the ACTIVATED/DEACTIVATED states.
The Material Design app launcher is going to have a circular shape and
will conflict with the SquareInkDropRipple's current rounded rectangle
activated/deactivated states.
BUG=612567
Review-Url: https://codereview.chromium.org/2047913002
Cr-Commit-Position: refs/heads/master@{#398516}
Remove suppressions for bug 258479 (races in SamplingStateScope::set())
BUG=258479
[email protected]
Review-Url: https://codereview.chromium.org/2039923003
Cr-Commit-Position: refs/heads/master@{#398515}
Updated description for Managed Bookmarks policy.
Added an example for how to set the toplevel folder name.
BUG=614831
Review-Url: https://codereview.chromium.org/2031543002
Cr-Commit-Position: refs/heads/master@{#398514}
ppapi: PPB_VpnProvider: Implement Resource Stub
BUG=506490
Review-Url: https://codereview.chromium.org/1931513002
Cr-Commit-Position: refs/heads/master@{#398513}
Only trigger session restore logic for urls if it is not first run.
The current logic trumped over start up urls specified in master_prefs
because session restore simply ignored them. Instead of adding them to
session restore we gate session restore logic on the absence of the
first run flag. There should be no session to restore in this case anyway.
Even if the user manually used the --force-first-run it makes sense to
disregard the session restore code as this sounds more in line with the
flag name.
BUG=419580
TEST=StartupBrowserCreatorFirstRunTest.FirstRunTabsWithRestoreSession
Review-Url: https://codereview.chromium.org/2040193003
Cr-Commit-Position: refs/heads/master@{#398512}
Remove tools/valgrind/tsan_v2, which is no longer used
BUG=None
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2046383002
Cr-Commit-Position: refs/heads/master@{#398511}
Remove the suppression for issue 363999 (race on thread_local_.debugger_entry_ in v8::internal::Debug)
BUG=363999
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2043963006
Cr-Commit-Position: refs/heads/master@{#398510}
[Password Generation] Handle not only DidFinishDocumentLoad in PasswordGenerationAgent, but also DidFinishLoad
DidFinishDocumentLoad event happens too early, i.e. some forms might be still unavailable. For example, if some Javascript stuff is involved. See https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameClient.h. DidFinishDocumentLoad is triggered before Javascript work. The solution is to handle DidFinishLoad that is triggered after Javascript work.
This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is also necessary. So, this CL introduces handling both events (DidFinishDocumentLoad and DidFinishLoad)
There are no tests for the given change, because it is very hard to catch the difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is possible, the test will be probably flaky.
BUG=617893
Review-Url: https://codereview.chromium.org/2048603002
Cr-Commit-Position: refs/heads/master@{#398509}
Remove the use of OwnedPtrDeleter in WebHelperPlugin.
It's hard to mechanically replace specializations of OwnedPtrDeleter<T>
to std::unique_ptr equivalents. Therefore, they are converted to
std::unique_ptr manually.
A new typedef WebHelperPluginUniquePtr is created so people can always
use std::unique_ptr with a correct deleter.
BUG=617504
Review-Url: https://codereview.chromium.org/2041263002
Cr-Commit-Position: refs/heads/master@{#398508}
[DurableStorage] Enable origin trial on workers
BUG=617232
Review-Url: https://codereview.chromium.org/2036103003
Cr-Commit-Position: refs/heads/master@{#398507}
Update V8 to version 5.3.171.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f960f961..0fc60462
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2047713003
Cr-Commit-Position: refs/heads/master@{#398506}
Change CSSValueList::item() to return a const CSSValue&
Change CSSValueList::item() to return a const CSSValue& instead of const
CSSValue*. Since CSSValueLists should not store nullptrs, this is more
semantically correct and safe.
BUG=526586
Review-Url: https://codereview.chromium.org/2044433002
Cr-Commit-Position: refs/heads/master@{#398505}
Delete unused code for exclusive access permission prompting.
On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.
BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2004353002
Cr-Commit-Position: refs/heads/master@{#398504}
Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the StyleValueFactory.
Also rename StylePropertyMap::StyleValueVector to just
CSSStyleValueVector.
This is in preparation for adding logic to build more types of
CSSStyleValues and TransformComponents out of CSSValues. It doesn't
make sense for the StylePropertyMap to contain all the logic around
different properties.
BUG=545318
Review-Url: https://codereview.chromium.org/2042943003
Cr-Commit-Position: refs/heads/master@{#398503}
Fix CSSValueList::copy() to use the vector assignment operator
Fix CSSValueList::copy() to use the vector assignment operator,
rather than copy the items one-by-one.
Review-Url: https://codereview.chromium.org/2034393005
Cr-Commit-Position: refs/heads/master@{#398502}
Disable ImageDecoderBrowserTest.StartAndKillProcess on Linux ASan/LSan
BUG=618206
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2046343002
Cr-Commit-Position: refs/heads/master@{#398501}
[iOS] Allow passing "info_plist_target" to "test" template.
The "test" template forwards its arguments to "ios_app_bundle" that
supports either "info_plist" or "info_plist_target". As those two
parameters are exclusive, do not define "info_plist" in the "test"
template if "info_plist_target" is defined by invoker.
The "info_plist_target" is generally used when the Info.plist file
need to be preprocessed using build/mac/tweak_info_plist.py which
is necessary for some downstream iOS tests.
BUG=603101
Review-Url: https://codereview.chromium.org/2040223002
Cr-Commit-Position: refs/heads/master@{#398500}
[tracing] Support background mode in dom storage memory dumps
Provide just total numbers for background mode dumps in dom storage.
The storage could be using memory for commit batches along with the
storage maps. So, add the size to tracing.
BUG=613198, 605785
TBR=michaeln
Review-Url: https://codereview.chromium.org/1950893003
Cr-Commit-Position: refs/heads/master@{#398499}
Roll src/third_party/catapult/ c59289db8..91544e364 (10 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c59289db852f..91544e36495b
$ git log c59289db8..91544e364 --date=short --no-merges --format='%ad %ae %s'
BUG=618008,612360
[email protected]
Review-Url: https://codereview.chromium.org/2050593002
Cr-Commit-Position: refs/heads/master@{#398498}
Introduce WebInsecureRequestPolicy.
This is the first step towards moving some of 'Upgrade-Insecure-Requests'
enforcement up to the browser process. It introduces WebInsecureRequestPolicy
which aims to represent both 'Upgrade-Insecure-Requests' and
'Block-All-Mixed-Content' as a single bitfield, as they're really two sides
of the same coin.
This patch uses the new type inside of //core/frame/csp. The next patch
will extend usage to 'SecurityContext' (which has a number of dependencies
including 'DocumentInit', 'FrameLoader' and etc, which makes it appealing
to split out). That will be followed by a patch which replicates the new
data to remote frames.
With that infrastructure in place, upgrading requests during redirects should
be (somewhat) straightforward.
[Step 1]: This patch.
[Step 2]: https://codereview.chromium.org/2040133003
[Step 3]: https://codereview.chromium.org/2046733003
BUG=617947
[email protected]
Review-Url: https://codereview.chromium.org/2046523005
Cr-Commit-Position: refs/heads/master@{#398497}
Revert of Add a buildflag to use the handle verifier in a per module mode. (patchset #9 id:180001 of https://codereview.chromium.org/1977833003/ )
Reason for revert:
ScopedHandleTest.* tests fail to die on try bots.
BUG=618205
Original issue's description:
> Add a buildflag to use the handle verifier in a per module mode.
>
> The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
>
> Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
> Cr-Commit-Position: refs/heads/master@{#398361}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2047013003
Cr-Commit-Position: refs/heads/master@{#398496}
Update V8 to version 5.3.170.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/19e4d1a5..f960f961
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2040343003
Cr-Commit-Position: refs/heads/master@{#398495}
Change CSSValueList::append() to take a const CSSValue&
Change CSSValueList::append() to take a const CSSValue& instead of const
CSSValue*. Since CSSValueLists should not store nullptrs, this is more
semantically correct and safe. This is also a logical first step to
change CSSValueList::item() to return a const CSSValue& as well.
BUG=526586
Review-Url: https://codereview.chromium.org/2038393002
Cr-Commit-Position: refs/heads/master@{#398494}
Removed deprecated method CSSValueList::itemWithBoundsCheck()
Removed deprecated CSSValueList::itemWithBoundsCheck() and the last
remaining callsite.
[email protected]
Review-Url: https://codereview.chromium.org/2035333002
Cr-Commit-Position: refs/heads/master@{#398493}
Make MockTextInputClient inherit from ui::DummyTextInputClient.
Currently MockTextInputClient implements ui::TextInputClient (a pure virtual
interface) without providing any specialized functionality. This CL makes
MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate
code.
BUG=None
Review-Url: https://codereview.chromium.org/2044593004
Cr-Commit-Position: refs/heads/master@{#398492}
Improve the "gn path" command.
Previously, GN path would find all paths between the two targets, count them for statistical purposes, sort them, and print the shortest (or all of them if requested).
Unfortunately, there are many hundred millions of unique paths between two targets like //chrome and //base and it would take a long time and eventually run out of address space counting them all.
This patch changes the algorithm from depth-first to breadth-first search, and doesn't traverse or count a target if that target was already found to have a path to the destination. The result is the path from //chrome to //base finds 65 paths which makes the algorithm run instantly and the output with --all is much more useful.
Review-Url: https://codereview.chromium.org/2037303002
Cr-Commit-Position: refs/heads/master@{#398491}
Simplify contextDestroyed() notifications.
With all lifetime observers now being managed by Oilpan, the
handling of the destruct notification can be made simpler.
R=
BUG=
Review-Url: https://codereview.chromium.org/2045703004
Cr-Commit-Position: refs/heads/master@{#398490}
Auto-rebaseline for r398475
https://chromium.googlesource.com/chromium/src/+/f867673f2
BUG=374643
[email protected]
Review URL: https://codereview.chromium.org/2041013005 .
Cr-Commit-Position: refs/heads/master@{#398489}
Moves ash::user::LoginStatus to ash/common
BUG=581868
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2041233005
Cr-Commit-Position: refs/heads/master@{#398488}
test_converter: Do not add extra spaces in comments.
Review-Url: https://codereview.chromium.org/2049523003
Cr-Commit-Position: refs/heads/master@{#398487}
exo: Don't set window bounds unless they actually change.
Setting the window bounds causes a lot of unnecessary work redoing
window layout and forces an unnecessary browser commit.
Review-Url: https://codereview.chromium.org/2033213002
Cr-Commit-Position: refs/heads/master@{#398486}
Avoid modifying a request queue in copresence::RpcHandler while searching it
BUG=616989
Review-Url: https://codereview.chromium.org/2046313002
Cr-Commit-Position: refs/heads/master@{#398485}
Add checks for negative heights and widths to gfx struct traits.
Review-Url: https://codereview.chromium.org/2048893002
Cr-Commit-Position: refs/heads/master@{#398484}
Record scores of distillability and long article in UMA
BUG=617769
Review-Url: https://codereview.chromium.org/2021643002
Cr-Commit-Position: refs/heads/master@{#398483}
exo: Make sure widget bounds are correct after a fullscreen state change.
Move handling of widget bounds adjustments when initial bounds
were specificed into UpdateWidgetBounds() to prevent it from
incorrectly moving widget in fullscreen or maximized mode.
BUG=549781
TEST=exo_unittests
Review-Url: https://codereview.chromium.org/2045133002
Cr-Commit-Position: refs/heads/master@{#398482}
Move LayoutTree snapshots to blink.debug.layout.trees category
This reduces overhead of blink.debug.layout category, which is
needed to compute First Meaningful Paint.
BUG=615605
Review-Url: https://codereview.chromium.org/2046973004
Cr-Commit-Position: refs/heads/master@{#398481}
DevTools: Add stub protocol.json for discovery of new split protocol
BUG=580337
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2047183002
Cr-Commit-Position: refs/heads/master@{#398480}
ThreadHeap should be deleted when all threads detach.
BUG=617141
Review-Url: https://codereview.chromium.org/2045123002
Cr-Commit-Position: refs/heads/master@{#398479}
Roll src/third_party/skia/ 4dbbd0431..2af4599b5 (1 commit).
https://chromium.googlesource.com/skia.git/+log/4dbbd04314cc..2af4599b5c51
$ git log 4dbbd0431..2af4599b5 --date=short --no-merges --format='%ad %ae %s'
2016-06-07 lsalzman A Mozilla developer ran the µmix static analyzer on its codebase and incidentally found some issues regarding null checks in Skia. This fixes the issues that were found.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2047943002
Cr-Commit-Position: refs/heads/master@{#398478}
cc: Add traces for identification of raster buffer.
This patch adds traces in Playback() function depicting which raster
buffer provider is used.
BUG=599863
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2045743003
Cr-Commit-Position: refs/heads/master@{#398477}
MD WebUI: Add loading spinner to cr-toolbar, hook into MD History toolbar
Adds a processing spinner which is visible when the search bar is open,
and hooks it into MD History so that it is shown when loading data from
a search. It is not shown when incrementally loading new data in the
infinite list.
BUG=610609
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2032313002
Cr-Commit-Position: refs/heads/master@{#398476}
Regenerate text-autosizing mac baselines to fix image diff errors
Two tests have png expectations that consistently generate an error
message on mac:
fast/text-autosizing/tables/table-with-inline-block.html
fast/text-autosizing/supercluster-multiple-layout.html
The error message is:
Image diff returned an exit code of 2. See http://crbug.com/278596
The mac expectation files appear to actually be corrupt:
LayoutTests/platform/mac/fast/text-autosizing/supercluster-multiple-layout-expected.png
LayoutTests/platform/mac/fast/text-autosizing/tables/table-with-inline-block-expected.png
I generated these a long time ago and may have made a mistake. This
patch removes the files and marks them to generate new baselines.
BUG=374643
Review-Url: https://codereview.chromium.org/2046223002
Cr-Commit-Position: refs/heads/master@{#398475}
Address a crash under -[NSWindow close] via a WeakPtr PostTask from Browser::TabStripEmpty()
This is the #1 browser crash for Mac in current Beta - 52.0.2743.24. The
stacks all have in common a Posted Task that's triggering -[NSWindow
close] via a base::WeakPtr<Browser>. This only happens via
Browser::TabStripEmpty().
The WeakPtr is only nerfed when BrowserWindowController's dealloc fully
completes. It seems plausible that this can be after the NSWindow's
dealloc fully completes, leading to an invalid access. One would hope
that [NSWindowController window] returns nil once the controlled window
is destroyed, but this seems to not be guaranteed.
To (speculatively) fix, set a flag when the controlled window invokes
-[NSWindowController windowWillClose]. The window shouldn't be accessed
after this. Ensure the C++ BrowserWindowCocoa shim returns nil in this
case for the window, even if -[NSWindowController window] doesn't.
BUG=616701
Review-Url: https://codereview.chromium.org/2041213002
Cr-Commit-Position: refs/heads/master@{#398474}
Revert of Simplify import-w3c-tests: support exactly one argument. (patchset #7 id:120001 of https://codereview.chromium.org/1998413002/ )
Reason for revert:
This seems to have caused consecutive webkit python test failures. Probably there should be an easy fix but let me revert this for now.
{
"failures": [
"webkitpy/w3c/test_importer_unittest/TestImporterTest/test_does_not_import_reftest"
],
"valid": true
}
Original issue's description:
> Simplify import-w3c-tests: support exactly one argument.
>
> Specifically, take the source repo path (top of repo) as the required argument, and don't support importing single subdirectories.
>
> Reason:
>
> 1. Using the current directory as the top of repo may be a bit confusing.
>
> 2. In the future, I believe we want some kind of auto-updater that updates everything at once and we won't need to support importing individual directories. At present, I believe the only thing that uses import-w3c-tests is update-w3c-deps which, which doesn't currently have an option for updating just one subdirectory.
>
> Committed: https://crrev.com/868f94e75ad4b86b2a8a6c15b694cde508af91ee
> Cr-Commit-Position: refs/heads/master@{#398437}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2048953002
Cr-Commit-Position: refs/heads/master@{#398473}
CC Animation: Create AnimationHost externally.
This will allow us to replace AnimationHost with an abstract
MutatorHost interface in CC.
BUG=575053
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2024393002
Cr-Commit-Position: refs/heads/master@{#398472}
Add 'selected' boolean to 'ShippingOption'
ShippingOption.selected is a new boolean member variable used in
PaymentRequest.
"This is set to true to indicate that this is the default selected
ShippingOption in a sequence. User agents should display this option by
default in the user interface."
The website now has a more powerful way to specify the selected shipping
option. Prior to this patch, specifying a single shipping option would
result in that option being selected as the default. After this patch,
only the option that has "selected: true" is selected by default. This
makes calculation of totals more deterministic, as the web developer now
knows which shipping option is selected in UI.
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-shippingoption
https://github.com/w3c/browser-payment-api/commit/684603787c80d46d06b76f73b00a28a938e4b291
BUG=616948
Review-Url: https://codereview.chromium.org/2045833002
Cr-Commit-Position: refs/heads/master@{#398471}
Add initial baselines for enable-slimming-paint-v2 FlagExpectations
This patch adds an initial set of baselines (linux-debug only) for
tests run with --additional-driver-flag=--enable-slimming-paint-v2.
All but the compositing, fast, and svg directories have been skipped.
To run tests for spv2:
run-webkit-tests --debug --additional-driver-flag=--enable-slimming-paint-v2
BUG=601275
Review-Url: https://codereview.chromium.org/2048823003
Cr-Commit-Position: refs/heads/master@{#398470}
Updating trunk VERSION from 2762.0 to 2763.0
Cr-Commit-Position: refs/heads/master@{#398469}
ResourceFetcher: fix an assertion failure on defered resource revalidation
On revalidating resources, e.g. for page reloads, if two initiators
exist and the loading is defered, both initiators get 'Revalidate'
revalidation policy in ResourceFetcher::requestResource() then it
results in an assertion failure to initialize the resource as a cache
validator.
BUG=616358
Review-Url: https://codereview.chromium.org/2039893002
Cr-Commit-Position: refs/heads/master@{#398468}
Roll src/third_party/skia/ 50bcb189f..4dbbd0431 (1 commit).
https://chromium.googlesource.com/skia.git/+log/50bcb189f878..4dbbd04314cc
$ git log 50bcb189f..4dbbd0431 --date=short --no-merges --format='%ad %ae %s'
2016-06-07 halcanary SkLeanWindows.h: #include "Windows.h" fewer places
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2047193002
Cr-Commit-Position: refs/heads/master@{#398467}
Fix chrome_telemetry_build's GN dependencies for Mac OS X.
(taking over from caseq's https://codereview.chromium.org/2037773005/ )
The previous bug workaround for Issue 536192 should no longer be
necessary.
Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.
BUG=599776
Review-Url: https://codereview.chromium.org/2048563002
Cr-Commit-Position: refs/heads/master@{#398466}
Make CSSValueList store const CSSValues
Make CSSValueList store a vector of Member<const CSSValue> instead of
Member<CSSValue>. This also involved updating
ComputedStyleCSSValueMapping::get() to return a const CSSValue* in the
same patch (both changes require eachother to be const). This patch is
entirely mechanical and just adds consts to all callsites that are
needed.
BUG=526586
Review-Url: https://codereview.chromium.org/2032243003
Cr-Commit-Position: refs/heads/master@{#398465}
Send 'key' from fake keyboard events generated by file_manager.
With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.
BUG=607349
Review-Url: https://codereview.chromium.org/2046143002
Cr-Commit-Position: refs/heads/master@{#398464}
Make Android toolchains work when current_toolchain != target_toolchain
"android_tool_prefix" within the toolchain definitions was always being
keyed off of target_cpu rather than the toolchain cpu.
BUG=616819
Review-Url: https://codereview.chromium.org/2036263002
Cr-Commit-Position: refs/heads/master@{#398463}
[Sync] Display correct message for actionable error
When server returns actionable error corresponding message should be
shown on settings page. Today generic unrecoverable error is shown.
In this change if unrecoverable error is accompanied by actionable error
message for actionable error is returned.
BUG=595094
[email protected]
Review-Url: https://codereview.chromium.org/2044003005
Cr-Commit-Position: refs/heads/master@{#398462}
Add permission reporter skeleton for permission action reporting to SafeBrowsing servers.
BUG=613883
Review-Url: https://codereview.chromium.org/2024753002
Cr-Commit-Position: refs/heads/master@{#398461}
Android WebView: Always send memory policy from Browser to Renderer.
Early out on the Browser side does not work because the IPC message send could
succeed even if the output surface in question is not yet bound to client and
registered with the SynchronousCompositorRegistry.
BUG=613781
Review-Url: https://codereview.chromium.org/2035993003
Cr-Commit-Position: refs/heads/master@{#398460}
Roll PDFium f7e108b..759de38
https://pdfium.googlesource.com/pdfium.git/+log/f7e108b..759de38
BUG=616841,616842,617659,616839
TEST=bots
[email protected]
Review-Url: https://codereview.chromium.org/2050543002
Cr-Commit-Position: refs/heads/master@{#398459}
Avoid holding |incoming_queue_lock_| while waking up the message loop.
When constraining chrome to a limited number of cores (read: 2), it
appears that the write syscall that wakes up the message loop thread
may take a significant amount of time (>80ms) despite being a non-blocking
write. During that time, if |incoming_queue_lock_| is being held, any other
thread that tried to post a task to that message queue will be blocked in
trying to acquire that lock.
Review-Url: https://codereview.chromium.org/1991623002
Cr-Commit-Position: refs/heads/master@{#398458}
This is 1 of 2 checks in for making ModelTypeStore supports
multiple datatypes.
This one will add ModelType's toor tag as a prefix for keys
in leveldb.
Next check in will make only one ModelTypeStore to be created
if there are multiple datatypes.
BUG=615214
Review-Url: https://codereview.chromium.org/2018623002
Cr-Commit-Position: refs/heads/master@{#398457}
Revert of Switch CrWinClang to gn again. (patchset #1 id:1 of https://codereview.chromium.org/2043743003/ )
Reason for revert:
goma miscompiles things in optimized clang-cl builds if -imsvc is used (which the gn build uses but the gyp build doesn't), see https://crbug.com/618038
Original issue's description:
> Switch CrWinClang to gn again.
>
> This relands parts of https://codereview.chromium.org/1947183004/
> Now that clobber runs as a separate step before runhooks, swarming should work
> on gn clobber bots.
>
> BUG=498033
>
> Committed: https://crrev.com/9b6d81f1e5b090fbc9eabc88972d1e6cc4369c94
> Cr-Commit-Position: refs/heads/master@{#398148}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=498033
Review-Url: https://codereview.chromium.org/2049583002
Cr-Commit-Position: refs/heads/master@{#398456}
PaymentRequest: Sync up PaymentAddress with the payment request spec.
Some attributes in PaymentAddress was renamed and added. This CL syncs up
the PaymentAddress with the spec[1].
[1] https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentaddress-interface
BUG=617190
Review-Url: https://codereview.chromium.org/2039863002
Cr-Commit-Position: refs/heads/master@{#398455}
Update Port.is_wpt_test to check for wpt instead of web-platform-tests.
BUG=611762
Review-Url: https://codereview.chromium.org/2044293002
Cr-Commit-Position: refs/heads/master@{#398454}
Roll src/third_party/skia/ ddc2cd6a1..50bcb189f (1 commit).
https://chromium.googlesource.com/skia.git/+log/ddc2cd6a1f55..50bcb189f878
$ git log ddc2cd6a1..50bcb189f --date=short --no-merges --format='%ad %ae %s'
2016-06-07 mtklein Revert of Move immintrin/arm_neon includes to where they are used. (patchset #2 id:20001 of https://codereview.chromium.org/2045633002/ )
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2047173002
Cr-Commit-Position: refs/heads/master@{#398453}
Updates the preference flag for HaTS on the user interaction.
If the user dismisses the notification or chooses to take the survey,
the preference flag is updated with the latest timestamp.
Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS
Review-Url: https://codereview.chromium.org/2027363002
Cr-Commit-Position: refs/heads/master@{#398452}
mash: Move //ash/session to //ash/common/session
* Add GetSessionStateDelegate() accessor to WmShell
* Remove existing WmShell wrapper functions for SessionStateDelegate
* Add a stub SessionStateDelegate to //ash/mus
* Move the files
* Clean up some #includes along the way
BUG=615155
TEST=existing ash_unittests and chrome unit_tests
Review-Url: https://codereview.chromium.org/2041233004
Cr-Commit-Position: refs/heads/master@{#398451}
MD Settings: Set language strings conditionally on OS
On Chrome OS, the language section should be titled "Language and input".
Also includes enclosing language strings in <if>s for strings that are
only used on certain platforms.
BUG=601555
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2037243003
Cr-Commit-Position: refs/heads/master@{#398450}
[ios] Added const version of web::WebTestWithWebController::web_state().
This way web_state() can be called from const methods.
BUG=None
Review-Url: https://codereview.chromium.org/2042093002
Cr-Commit-Position: refs/heads/master@{#398449}
Remove the simplified-fullscreen-ui flag on Android.
Now the flag is permanently enabled. Cleaned up some code that is no
longer used because of this change. The FullscreenInfoBarDelegate class
is no longer used but this will be deleted in a follow-up CL.
BUG=610900
Review-Url: https://codereview.chromium.org/2008813002
Cr-Commit-Position: refs/heads/master@{#398448}
Removes blimp browser tests from chromium.fyi.
The Blimp FYI slave is being moved to chromium.linux in https://codereview.chromium.org/2044513004/
BUG=617802
Review-Url: https://codereview.chromium.org/2042133003
Cr-Commit-Position: refs/heads/master@{#398447}
[Sync] Call ModelTypeService::DisableSync when USS type is disabled
When datatype is disabled or sync is disabled as part of sign out
NonBlockingDataTypeController should call ModelTypeService::DisableSync
to let it clear sync metadata from store.
In this change:
- I added SyncPrefs to NonBlockingDataTypeController (NBDTC).
- NBDTC calls ModelTypeService::DisableSync from Stop().
I noticed that UI and NonUI ModelTypeController tests overlap
significantly and created non_blocking_data_type_controller_unittest.cc
with plans to migrate there all common tests from above two files.
Also change includes random cleanups that I noticed.
BUG=584365
[email protected]
Review-Url: https://codereview.chromium.org/2042283003
Cr-Commit-Position: refs/heads/master@{#398446}
Revert of Revert cursor changes to RenderWidgetHostViewAura. (patchset #2 id:20001 of https://codereview.chromium.org/2027693003/ )
Reason for revert:
Speculative revert for very small likelihood of causing elevated crash rates as detailed in https://bugs.chromium.org/p/chromium/issues/detail?id=616399
Original issue's description:
> Revert cursor changes to RenderWidgetHostViewAura.
>
> This is a selective revert of one file from
> https://codereview.chromium.org/1945423002, which was breaking cursor
> changes on zoom in/zoom out on the Linux version of chrome.
>
> BUG=602727,614654
>
> Committed: https://crrev.com/b9020bacdaff760ec0acc4fc5e9db9239438636d
> Cr-Commit-Position: refs/heads/master@{#396977}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=602727,614654
Review-Url: https://codereview.chromium.org/2042213003
Cr-Commit-Position: refs/heads/master@{#398445}
Add tests of state changes for :defined() selector
BUG=594918
Review-Url: https://codereview.chromium.org/2039103004
Cr-Commit-Position: refs/heads/master@{#398444}
Update WebGL2 conformance test expectations
BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2047703002
Cr-Commit-Position: refs/heads/master@{#398443}
Add the option --build-number to BaseInternalRebaselineCommand.
BUG=474273
Review-Url: https://codereview.chromium.org/2015253002
Cr-Commit-Position: refs/heads/master@{#398442}
Set FLAGS_shift_quic_cubic_epoch_when_app_limited to false.
[email protected]
BUG=618144
Review-Url: https://codereview.chromium.org/2050533002
Cr-Commit-Position: refs/heads/master@{#398441}
[libfuzzer] enabling mpeg2ts fuzzers
These fuzzers are already created by media team in //testing/libfuzzer/fuzzers
but building them is disabled on CF.
BUG=539572
Review-Url: https://codereview.chromium.org/2030243002
Cr-Commit-Position: refs/heads/master@{#398440}
Moved vr_service.mojom from blink to device
BUG=612342
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2041003003
Cr-Commit-Position: refs/heads/master@{#398439}
Remove download resumption feature flag.
The feature is now available by default. We no longer need a feature
flag.
BUG=7648
Review-Url: https://codereview.chromium.org/2044233002
Cr-Commit-Position: refs/heads/master@{#398438}
Simplify import-w3c-tests: support exactly one argument.
Specifically, take the source repo path (top of repo) as the required argument, and don't support importing single subdirectories.
Reason:
1. Using the current directory as the top of repo may be a bit confusing.
2. In the future, I believe we want some kind of auto-updater that updates everything at once and we won't need to support importing individual directories. At present, I believe the only thing that uses import-w3c-tests is update-w3c-deps which, which doesn't currently have an option for updating just one subdirectory.
Review-Url: https://codereview.chromium.org/1998413002
Cr-Commit-Position: refs/heads/master@{#398437}
Add RELEASE_ASSERT(!needsLayout()) in FrameView::layout()
Now we know that the failure of RELEASE_ASSERT(!needslayout())
in FrameView is because that FrameView::layout() returns with
dirty layout in some cases. Add RELEASE_ASSERT(!needslayout())
in FrameView::layout() to find the detail reasons.
BTW, let adjustViewSizeAndLayout() return a bool indicating if
a layout is actually done to avoid duplicated work after the
function in FrameView::layout().
BUG=590856
Review-Url: https://codereview.chromium.org/2041983004
Cr-Commit-Position: refs/heads/master@{#398436}
CC Animation: Let PageScaleAnimation uses gfx::CubicBezier curve.
So it doesn't depend on cc/animation (TimingFunction).
BUG=575053
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2043603003
Cr-Commit-Position: refs/heads/master@{#398435}
[MD settings] redesign of side nav
This CL reworks the side nav menu to remove the 'basic' menu label while
keeping the items in the basic menu displayed. The 'advanced' page is
now toggled separately from the basic page. An 'Advanced' toggle button
has also been added to the content area which will expand or collapse
the advanced settings.
BUG=593989
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2008843003
Cr-Commit-Position: refs/heads/master@{#398434}
Blimp: change logger to use switch/case for types.
The current design of the logger allows for logging "modules" to
be loaded into a dynamic map. This functionality is not providing
any benefit at the moment, and it prevents the compiler from performing
enum coverage checks at compile time. This CL changes the dynamic
behavior to use a switch block instead.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2026053002
Cr-Commit-Position: refs/heads/master@{#398433}
Rename BufferFormat::YUV_420 to YVU_420.
YUV_420 buffer format was introduced with the intention of using it in
conjunction with WebRTC.
This hasn't happend yet, but chrome now needs to import YVU_420 buffers
from exo (crrev.com/2046743002).
YVU_420 format is also supported by intel on mesa, while YUV_420 is not.
This patch renames BufferFormat::YUV_420, that is not being used, to YVU_420
that is going to be used soon.
BUG=b/27244278
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2040143002
Cr-Commit-Position: refs/heads/master@{#398432}
Temporarily fail the deqp_functional_gles3_vertexarrays test on linux.
BUG=618139
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Review-Url: https://codereview.chromium.org/2048623003
Cr-Commit-Position: refs/heads/master@{#398431}
Reset fullscreen page scale constraints when exiting fullscreen via navigation.
When we exit fullscreen via navigation we no longer have a Document when we go
call didExitFullscreen so fullscreen constraints were never removed. Always
remove them when exiting fullscreen.
BUG=499721
Review-Url: https://codereview.chromium.org/2044073002
Cr-Commit-Position: refs/heads/master@{#398430}
arc: Fix crash on Agree button click.
TEST=Cannot reproduce crash anymore.
BUG=b/28932980
Review-Url: https://codereview.chromium.org/2047143002
Cr-Commit-Position: refs/heads/master@{#398429}
Record NQE accuracy at main frame requests
At each main frame request, NQE estimates are preserved
locally. Then, the observed network quality is computed
from the observations received in the next 15, 30 and 60
seconds. The preserved estimates are compared against the
observed estimates, and the computed accuracy is recorded
using UMA.
Design doc here: https://docs.google.com/document/d/18dA6DmUdh8DxwWutR-hFcd2K4yVJvqDIot6291etf6E/view
BUG=615551
Review-Url: https://codereview.chromium.org/2020353002
Cr-Commit-Position: refs/heads/master@{#398428}
mac: Remove GPU bug workarounds for OS X versions before 10.9
BUG=579255
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2045663002
Cr-Commit-Position: refs/heads/master@{#398427}
Run tests on forthcoming Nexus 6P bot.
BUG=490984
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Review-Url: https://codereview.chromium.org/2046903002
Cr-Commit-Position: refs/heads/master@{#398426}
Mac low power video: Support child windows, sheets, and transitions
We do not want to use the fullscreen low power window when we have
a child window, an active sheet, or we are in a fullscreen transition.
Add listeners for these changes, and make them call into the
FullscreenLowPowerCoordinatorCocoa.
Add two exceptions for child windows that were determined empirically
(toolbar and a 1x1 bubble).
Also update the fullscreen low power window to not be in the window
cycle or the window list.
BUG=594460
Review-Url: https://codereview.chromium.org/2040253003
Cr-Commit-Position: refs/heads/master@{#398425}
[DevTools] Fix front_end compilation after protocol split
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2049453003
Cr-Commit-Position: refs/heads/master@{#398424}
Silencing console messages during some layout tests.
The console messages emitted during the modified tests were different
with and without --site-per-process flag. The tests are able to verify
the expected behavior without depending on presence of absence of the
console message, and therefore the console output has been silenced to
unify test output between runs with and without --site-per-process flag.
BUG=617288
Review-Url: https://codereview.chromium.org/2042043002
Cr-Commit-Position: refs/heads/master@{#398423}
Honour PartitionAllocReturnNull flag when MEMORY_TOOL_REPLACES_ALLOCATOR
Previously, for builds defining MEMORY_TOOL_REPLACES_ALLOCATOR, the
PartitionAllocReturnNull flag was not respected. This can causes problems on
cluster-fuzz, due to generating valid scripts which ought to just throw a
RangeError (as they do in ordinary builds) rather than crashing.
BUG=617628
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2044673003
Cr-Commit-Position: refs/heads/master@{#398422}
[libfuzzer] roll libfuzzer to 0475f06
Changes:
0475f06 [LibFuzzer] Split the fuzzer-oom.test into two tests.
bf0fc25 [libfuzzer] custom crossover interface function.
c028617 [libfuzzer] prune_corpus option for disabling pruning during the
load.
e627627 [LibFuzzer] s/dataflow sanitizer/DataflowSanitizer/
09ac6ef [LibFuzzer] Disable building and running LSan tests on Apple
platforms because LSan is not currently supported.
f6a708e [LibFuzzer] Provide stub implementation of
__sanitizer_cov_trace_pc_indir
47e9063 [libfuzzer] hiding custom mutator handling in
MutationDispatcher.
23b94e4 [libfuzzer] splitting fuzzer.test
https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/428b5cb..0475f06
BUG=539572
Review-Url: https://codereview.chromium.org/2045903003
Cr-Commit-Position: refs/heads/master@{#398421}
Use ChannelMojo for pepper plugin processes.
BUG=604282
Review-Url: https://codereview.chromium.org/2021103004
Cr-Commit-Position: refs/heads/master@{#398420}
Auto-rebaseline for r398403
https://chromium.googlesource.com/chromium/src/+/e0e6a47e4
BUG=390040
[email protected]
Review URL: https://codereview.chromium.org/2045843003 .
Cr-Commit-Position: refs/heads/master@{#398419}
WebGL expectations: remove suppression for ANGLE deqp gles3 uniformapi
BUG=angleproject:1401
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2034783004
Cr-Commit-Position: refs/heads/master@{#398418}
Fix test_converter.py to no longer alter end-tag case
BUG=526898
Review-Url: https://codereview.chromium.org/2046663003
Cr-Commit-Position: refs/heads/master@{#398417}
Roll src/third_party/skia/ 3db202812..ddc2cd6a1 (5 commits).
https://chromium.googlesource.com/skia.git/+log/3db2028126e1..ddc2cd6a1f55
$ git log 3db202812..ddc2cd6a1 --date=short --no-merges --format='%ad %ae %s'
2016-06-07 csmartdalton Fix dashing bug where hwaa was unintentionally disabled
2016-06-07 brianosman Switch to a whitelist for manual mip-map generation
2016-06-07 liyuqian Implement Raster Backend on Android Viewer App
2016-06-07 senorblanco Fix for rare crash in Poly::addEdge().
2016-06-07 bsalomon Make GrShape use the original path when path effect fails.
BUG=617907
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2045983003
Cr-Commit-Position: refs/heads/master@{#398416}
Use --filelist as arg for all the individual files for create-bundle.py.
This simplifies argument handling since the Dockerfile and startup
script are handled exactly in the same manner. This will also
simplify the inclusion of a base Dockerfile as planned.
BUG=616945
Review-Url: https://codereview.chromium.org/2048823002
Cr-Commit-Position: refs/heads/master@{#398415}
Rename MediaCodecBridge::Reset() to Flush()
MediaCodec has both a flush() and reset() but MediaCodecBridge::Reset()
calls MediaCodec#flush(), which is a bit confusing, e.g., two of the
call sites actually have a comment saying that Reset() calls flush().
BUG=618004
Review-Url: https://codereview.chromium.org/2047003003
Cr-Commit-Position: refs/heads/master@{#398414}
Reland "Implement ui::ClipboardMus."
Should fix size_t conversion issues.
Original issue's description:
> Implement ui::ClipboardMus.
>
> This lets chrome in mash read and write from the mus server's clipboard.
>
> BUG=581460
>
> Committed: https://crrev.com/bbc764eb7a7c1937d26f43f6087604ebc2d048ad
> Cr-Commit-Position: refs/heads/master@{#398351}
[email protected],[email protected],[email protected]
BUG=581460
Review-Url: https://codereview.chromium.org/2044973002
Cr-Commit-Position: refs/heads/master@{#398413}
Disabled the failed test MediaGalleriesPlatformAppBrowserTest.GetMetadata.
BUG=618121
[email protected]
Review-Url: https://codereview.chromium.org/2044593005
Cr-Commit-Position: refs/heads/master@{#398412}
[Android] Make @DisableIf.Build work on classes.
BUG=617777
Review-Url: https://codereview.chromium.org/2047113002
Cr-Commit-Position: refs/heads/master@{#398411}
Fix test_importer.py to skip files named reftest.list and add test
BUG=582838
Review-Url: https://codereview.chromium.org/2045013002
Cr-Commit-Position: refs/heads/master@{#398410}
Refactor the naming scheme of Deserialize* functions in form_field_data.cc
This is needed for https://codereview.chromium.org/2022123002/.
BUG=614280
Review-Url: https://codereview.chromium.org/2044503002
Cr-Commit-Position: refs/heads/master@{#398409}
Separate CDM test constants from test_support.
By breaking thest constants out of pepper_cdm_test_helper and moving them to a new target, load_library_perf_test can depend on the new target rather than all of Chrome test support. Chrome test support includes basically all of Chrome and Blink. This improves 32-bit Windows official build link time of load_library_perf_tests.exe from 354 seconds to 15 seconds.
The structure of the GYP build was kept unchanged. GYP has less of an issue due to its use of static libraries and we can keep the simpler structure
Review-Url: https://codereview.chromium.org/2048783002
Cr-Commit-Position: refs/heads/master@{#398408}
Fix crash when closing a window with an associated widget child
This is a similar issue to
https://codereview.chromium.org/1644863003/
When closing some windows, the following occurs:
- WebContentsImpl enters its destructor
- a widget fires OnWidgetDestroying
- an AXWidgetObjWrapper gets destroyed
- WebContentsImpl fires an ax event
- the ax serializer walks the aura window and gets the widget "child" of the aura window
- a new AXWidgetObjWrapper gets created
- the widget's OnWidgetDestroying finishes and widget is destroyed
- WebContentsImpl exits its destructor
- the AXWidgetObjWrapper instance is now wrapping a deallocated widget
- future access to the AXWidgetObjWrapper causes a uaf.
BUG=617020
Review-Url: https://codereview.chromium.org/2044123003
Cr-Commit-Position: refs/heads/master@{#398407}
Converts ShellObserver from aura::Window to ash::WmWindow
BUG=581868
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2041423003
Cr-Commit-Position: refs/heads/master@{#398406}
Allow deletion of profiles in the old user manager when all profiles are locked
BUG=617016
Signed-off-by: mahmadi <[email protected]>
Review-Url: https://codereview.chromium.org/2046783002
Cr-Commit-Position: refs/heads/master@{#398405}
Sanitize JSON string before parsing it.
This patch makes PaymentRequestImpl use JsonSanitizer.santize() to
validate and sanitize the JSON string before parsing it.
BUG=617634
Review-Url: https://codereview.chromium.org/2039303002
Cr-Commit-Position: refs/heads/master@{#398404}
Add an inner border bleed layout test
The inner border clip introduces noticeable bleeding when not
pixel-aligned (due to AA seaming artifacts). Add a test to illustrate
the issue.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2039583002
Cr-Commit-Position: refs/heads/master@{#398403}
Moves ash/accessibility_delegate into common
And the default implementation.
BUG=581868
TEST=none
[email protected]
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2047053002
Cr-Commit-Position: refs/heads/master@{#398402}
font_warmup_win_unittest: do not assume Skia's headers include windows.h
Review-Url: https://codereview.chromium.org/2042383002
Cr-Commit-Position: refs/heads/master@{#398401}
Fix documentation for "pool" object in gn binary.
Followup to comments on https://codereview.chromium.org/2006923004/.
BUG=612786
Review-Url: https://codereview.chromium.org/2045713003
Cr-Commit-Position: refs/heads/master@{#398400}
Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists
This patch fixes removeFloatingOrPositionedChildFromBlockLists fails to
remove floats when their containing block is LayoutView.
BUG=613869
Review-Url: https://codereview.chromium.org/2042353002
Cr-Commit-Position: refs/heads/master@{#398399}
tracing: ensure __metadata events are always added to the trace
This is a temporary workaround to deal with the fact that some
metadata events, such as TRACE_EVENT_CLOCK_SYNC_*, are not added to
the trace if the category filter disables the default categories (-*).
A proper long-term fix is being discussd in the attached bug.
BUG=618054
Review-Url: https://codereview.chromium.org/2047793002
Cr-Commit-Position: refs/heads/master@{#398398}
Roll src/third_party/skia/ 12dfaaa53..3db202812 (1 commit).
https://chromium.googlesource.com/skia.git/+log/12dfaaa53c23..3db2028126e1
$ git log 12dfaaa53..3db202812 --date=short --no-merges --format='%ad %ae %s'
2016-06-07 mtklein linear -> sRGB: use fast approximate sqrt()
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2048583004
Cr-Commit-Position: refs/heads/master@{#398397}
Revert profiler instrumentations added in cl 1069403004, except for the very top level one. Reasons are:
1. The instrumentations were added for debugging information, and was planned to be removed.
2. Profiler data should be gradually replaced by sampling profiler.
3. Almost no people look at the profiler data now.
4. The early instrumentation at Chrome startup might cause Chrome crash crbug/616144 (unknown, but removing a suspect).
BUG=616144
Review-Url: https://codereview.chromium.org/2045593003
Cr-Commit-Position: refs/heads/master@{#398396}
Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.
All subclasses must implement the method, even if it should be empty.
This would ensure the compiler makes a developer aware of the lifecycle
concerns around RenderFrame/RenderView, and avoid the unintended
transfering ownership when inheriting the observer interface.
BUG=616214
Review-Url: https://codereview.chromium.org/2034153002
Cr-Commit-Position: refs/heads/master@{#398395}
[Offline pages] Create offline internals page for android
BUG=609570
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2003883002
Cr-Commit-Position: refs/heads/master@{#398394}
Exposed entry point for Android settings in chrome://settings
BUG=b/28017599
TEST=manual
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2035233002
Cr-Commit-Position: refs/heads/master@{#398393}
QUIC/cronet - Fix crash bug b/28676259. Handle session_ being a nullptr.
[email protected]
Review-Url: https://codereview.chromium.org/2044923003
Cr-Commit-Position: refs/heads/master@{#398392}
PlzNavigate: fix WebContentsImplBrowserTest.ViewSourceWebUI
This CL changes the URL used in the test to a URL that is actually recognized
as a WebUI URL by the RenderFrameHostManager. Otherwise, we don't set up the
data source for the WebUI, and the navigation fails when the network stack
tries to access it based on the fact that the scheme is chrome://.
BUG=475027
Review-Url: https://codereview.chromium.org/2041333002
Cr-Commit-Position: refs/heads/master@{#398391}
cc: Compute mask draw properties directly
This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.
BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2048723002
Cr-Commit-Position: refs/heads/master@{#398390}
Remove dependency on webrtc Mocks from ipc_desktop_environment_unittest.cc
The mock needs to be changed in https://codereview.webrtc.org/1988783003/,
so the test compilation breaks with that change.
BUG=webrtc:5950
Review-Url: https://codereview.chromium.org/2038833002
Cr-Commit-Position: refs/heads/master@{#398389}
clang-tidy WaitableEvent refactor (Android side)
BUG=612843
[email protected]
(purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO)
Review-Url: https://codereview.chromium.org/2041033003
Cr-Commit-Position: refs/heads/master@{#398388}
[Chromoting]Use google:remoting namespace to export remoting specific error code.
Jingle does not provide enough error codes for chromoting. So this change is to
add an error-code tag under 'google:remoting' namespace in JingleMessage, and
export chromoting specific error code under this node and namespace.
BUG=616156
Review-Url: https://codereview.chromium.org/2026123002
Cr-Commit-Position: refs/heads/master@{#398387}
Removing ash::Shelf::shelf_model()
Follow up for crrev.com/2039543002.
BUG=NONE
Review-Url: https://codereview.chromium.org/2039253002
Cr-Commit-Position: refs/heads/master@{#398386}
Add code and key into the browser test key simulation methods.
With the soon to be removal of keyboardIdentifier it is necessary
that events generated from the test suites actually have the correct
key value.
BUG=607349
Review-Url: https://codereview.chromium.org/2048533002
Cr-Commit-Position: refs/heads/master@{#398385}
Remove base/move.h
It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.
BUG=566182
Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
Review-Url: https://codereview.chromium.org/2038273002
Cr-Original-Commit-Position: refs/heads/master@{#398237}
Cr-Commit-Position: refs/heads/master@{#398384}
Move the routing-info inside the jingle element.
Previously, routing info are encoded in the iq node. When the host is
offline, the talk network responds with an error IQ that doesn't get
relayed to the client because it doesn't have the routing info that the
signaling service needs.
Since an error IQ always contain the original request, by moving the
routing info inside the original jingle request, we can reliably route
the error message back to the client.
Review-Url: https://codereview.chromium.org/2042513002
Cr-Commit-Position: refs/heads/master@{#398383}
Re-enable SSLUITest.TestUnauthenticatedFrameNavigation
The test no longer seems flaky.
BUG=43437
Review-Url: https://codereview.chromium.org/2045653002
Cr-Commit-Position: refs/heads/master@{#398382}
Change the timer to record the actual drawing time
Currently in the BaseRenderingContext2D.cpp, we put the scoped timer at
the very beginning of some API functions. But that includes timing for
some early exits cases. This CL makes changes such that we do not record
the time for the early exits cases
BUG=612585
Review-Url: https://codereview.chromium.org/2047643004
Cr-Commit-Position: refs/heads/master@{#398381}
Replicate more dump_foo layout test runtime flags across OOPIFs.
BUG=587175
Review-Url: https://codereview.chromium.org/2043923002
Cr-Commit-Position: refs/heads/master@{#398380}
Implement sk_sp<SkImageFilter> StructTraits
RenderPassDrawQuads need to be able to ship cc::FilterOperations which use
sk_sp<SkImageFilter>. This CL makes it possible to serialize and deserialize
them over mojo.
BUG=611802
Review-Url: https://codereview.chromium.org/2040233002
Cr-Commit-Position: refs/heads/master@{#398379}
Don't restore screen resolution in curtain mode.
Restoring the resolution could mess up the user's window layout if they
disconnect and reconnect, and both OS X and Windows will restore the
screen resolution if the user does log back in from the console.
Review-Url: https://codereview.chromium.org/2023433003
Cr-Commit-Position: refs/heads/master@{#398378}
[Media Router] Add a policy to enable/disable Media Router.
- Add policy "EnableMediaRouter". The default (if not set) will be to
enable Media Router.
-- EnableMediaRouter will be a user level policy that affects Chrome,
Chrome OS, and Android.
-- Mandatory policy.
- Add logic in media_router::MediaRouterEnabled() to check if the
corresponding preference is set from a mandatory policy. If so, return
that value. Otherwise, check the existing FeatureSwitch (or return true
on Android). If not set, or if not set from mandatory policy, then the
preference is ignored.
- Reordered the logic in the function to share common logic between
desktop and Android.
BUG=558453
Review-Url: https://codereview.chromium.org/2035903002
Cr-Commit-Position: refs/heads/master@{#398377}
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|
|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.
|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.
Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.
Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ
Review-Url: https://codereview.chromium.org/2022863002
Cr-Commit-Position: refs/heads/master@{#398376}
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted InkDropDelegates.
Common responsibility was split between the InkDropDelegate and the
InkDropHostView. This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.
This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.
BUG=None
TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*
Review-Url: https://codereview.chromium.org/2041033002
Cr-Commit-Position: refs/heads/master@{#398375}
cc: Remove some unused layers from layer_tree_host_pixeltest_filters.
A child of these layers is passed to the pixel test runner, and so these layers
named "root" are actually detached from the layer tree when the test runs.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2048753002
Cr-Commit-Position: refs/heads/master@{#398374}
Copies MruWindowTrackerTest over for mash
This is an exact copy of that for aura (with includes sanitized for
check deps). I'm copying this first so it's easy to see what changes.
I'm TBRing as this is just a file copy, and the file isn't compiled
yet.
BUG=617789
TEST=test only change
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2042423002
Cr-Commit-Position: refs/heads/master@{#398373}
Background tracing: Include which rule triggered in the trace metadata
[email protected]
Review-Url: https://codereview.chromium.org/2040273002
Cr-Commit-Position: refs/heads/master@{#398372}
Temporarily disable ClipPathDisplayItem accounting for GPU veto
The GPU veto is persistent per root layer. Reverting
http://crrev.com/2013723002 while we sort some regressions out.
BUG=603969
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2039373003
Cr-Commit-Position: refs/heads/master@{#398371}
Fix race when HTMLMediaElement.play() is called just after pause().
The consequence is that the Promise returned by play() is rejected by
the task created by pause(). The fix is to associate the tasks with a
list of promises.
BUG=593273
Review-Url: https://codereview.chromium.org/1865933002
Cr-Commit-Position: refs/heads/master@{#398370}
Don't create redundant ThreadData for Worker Threads
Before creating tracked_objects::ThreadData for a thread, see if it's a
WorkerThread. If is, try reusing ThreadData instance for previously
finished WorkerThread.
This stops unneccessary |ThreadData| instance to be created, reduces a
small portion of memory usage, especially on long running renderer
processes.
BUG=599820
Review-Url: https://codereview.chromium.org/1845753006
Cr-Commit-Position: refs/heads/master@{#398369}
ARC: Notify ARC when wifi is enabled or disabled
This will cover both cases: a) when the state change was initiated by
ARC, and b) when the state change was initiated by Chrome (or policy).
BUG=b/27248920
TEST=enable/disable wifi from Chrome, and watch logcat for debug prints
Review-Url: https://codereview.chromium.org/2029393007
Cr-Commit-Position: refs/heads/master@{#398368}
Reland of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #1 id:1 of https://codereview.chromium.org/2044643003/ )
Reason for revert:
Reverting the revert, as the speculation of this CL being the root cause did not pan out - https://bugs.chromium.org/p/chromium/issues/detail?id=616989#c36.
Original issue's description:
> Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id:100001 of https://codereview.chromium.org/2028873002/ )
>
> Reason for revert:
> Speculative revert of this CL to check if it is the root cause of https://crbug.com/616989.
>
> Original issue's description:
> > Fix event page process cleanup when running in --isolate-extensions mode.
> >
> > With --isolate-extensions, navigations can start in one RenderFrameHost
> > and complete in another. This was not possible to happen with extensions
> > related RenderFrameHosts in the past, so the code wasn't able to handle
> > it. This CL refactors the OnNetworkRequest(Started|Stopped) to use the
> > navigation request id as the stable identifier instead of the associated
> > RenderFrameHost.
> >
> > BUG=612668
> >
> > Committed: https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8
> > Cr-Commit-Position: refs/heads/master@{#397328}
>
> [email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=612668
>
> Committed: https://crrev.com/3cae185174cf799005ee4d4f6147e01fad45e354
> Cr-Commit-Position: refs/heads/master@{#398185}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612668
Review-Url: https://codereview.chromium.org/2040293002
Cr-Commit-Position: refs/heads/master@{#398367}
Use element id's for animations.
The goal of this CL is to migrate cc's animation code
away from layer id's in anticipation of SPv2. The ids
chosen are a minor tweak on DOMNodeIds for blink.
Other clients of cc may essentially continue using
their respective layer id's as identifiers. cc itself
remains ignorant of the semantic meaning of these ids,
treating them as an opaque identifier.
This change is extremely similar to loyso@'s earlier
CL crrev.com/1944623002, the significant difference
being the scheme for choosing the ids.
Notable changes in this CL
* Introduces an ElementId structure.
* Augments DOMNodeIds in order to handle sub elements (eg, for scroll and link highlight layers).
* Removal of ElementLayers from cc
BUG=616542
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1973083002
Cr-Commit-Position: refs/heads/master@{#398366}
Revert of Implement ui::ClipboardMus. (patchset #23 id:440001 of https://codereview.chromium.org/2011833003/ )
Reason for revert:
Broke Win x64 (dbg) due to size_t -> int conversion.
Original issue's description:
> Implement ui::ClipboardMus.
>
> This lets chrome in mash read and write from the mus server's clipboard.
>
> BUG=581460
>
> Committed: https://crrev.com/bbc764eb7a7c1937d26f43f6087604ebc2d048ad
> Cr-Commit-Position: refs/heads/master@{#398351}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581460
Review-Url: https://codereview.chromium.org/2047703003
Cr-Commit-Position: refs/heads/master@{#398365}
JniPairingSecretFetcher currently runs on the UI thread but the secret
fetching callback will be run on the network thread. Per wez@'s suggestion
it will be more straightforward if the class runs on network thread and
post task to UI thread to fetch the secret.
Doc: https://docs.google.com/document/d/1ZK-UQSC_rTjNsBa_MFbCmCh3fQRPFuVAwKhWnTZqc_Q/edit?usp=sharing
BUG=614242
Review-Url: https://codereview.chromium.org/2047613002
Cr-Commit-Position: refs/heads/master@{#398364}
Fix the empty shelf item title of PlayStore App.
BUG=b/29182209
Review-Url: https://codereview.chromium.org/2044183003
Cr-Commit-Position: refs/heads/master@{#398363}
Replicating can_open_windows layout tests runtime flag across OOPIFs.
BUG=617288, 587175
Review-Url: https://codereview.chromium.org/2039313002
Cr-Commit-Position: refs/heads/master@{#398362}
Add a buildflag to use the handle verifier in a per module mode.
The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
Review-Url: https://codereview.chromium.org/1977833003
Cr-Commit-Position: refs/heads/master@{#398361}
Add a missing test to GN builds.
https://codereview.chromium.org/1974153002/ added this test
but didn't add it to the GN build.
BUG=431177
Review-Url: https://codereview.chromium.org/2041193002
Cr-Commit-Position: refs/heads/master@{#398360}
Rename and re-enable TestHTTPSExpiredCertAndDontProceed
Also use a server with name-mismatch error instead of expired cert so that we don't get the "Got unexpected cert error" warning. Make this warning a hard failure instead.
BUG=43575,280537
Review-Url: https://codereview.chromium.org/2042893002
Cr-Commit-Position: refs/heads/master@{#398359}
Update V8 to version 5.3.166.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/53261a81..19e4d1a5
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2041373002
Cr-Commit-Position: refs/heads/master@{#398358}
Enable GN angle_perftests.
BUG=537008,617992
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2046853003
Cr-Commit-Position: refs/heads/master@{#398357}
Roll src/third_party/skia/ 06115ee43..12dfaaa53 (4 commits).
https://chromium.googlesource.com/skia.git/+log/06115ee4300e..12dfaaa53c23
$ git log 06115ee43..12dfaaa53 --date=short --no-merges --format='%ad %ae %s'
2016-06-07 mtklein Move immintrin/arm_neon includes to where they are used.
2016-06-07 egdaniel Refactor creation of GrVkRenderPasses to make them move general
2016-06-07 bsalomon Make GrDashEffect take a AA mode enum. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042923003
2016-06-07 liyuqian Show FPS in UI state
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2043903003
Cr-Commit-Position: refs/heads/master@{#398356}
[Sync] Remove NOTREACHED that causes flakes in Android tests.
It doesn't seem to actually need to be there. The comment even says that
branch can happen and doesn't seem to mention it being a problem.
Specifically, I have seen this cause SyncTest.testRename to flake
locally.
BUG=588050,595893
Review-Url: https://codereview.chromium.org/2044213002
Cr-Commit-Position: refs/heads/master@{#398355}
Roll ANGLE c8ec0b2..07529ff
https://chromium.googlesource.com/angle/angle.git/+log/c8ec0b2..07529ff
BUG=
[email protected]
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2045773002
Cr-Commit-Position: refs/heads/master@{#398354}
Forward various V8 UseCounters through Chrome
These UseCounters test for usage of legacy JavaScript features and
slow paths through V8.
BUG=v8:4973
Review-Url: https://codereview.chromium.org/1986413002
Cr-Commit-Position: refs/heads/master@{#398353}
Add [CEReactions] IDL attributes for Custom Elements V1
This patch adds:
* [CEReactions] support in IDL parser.
https://html.spec.whatwg.org/multipage/scripting.html#cereactions
* [CEReactions] attributes to IDL from the following specs:
https://dom.spec.whatwg.org/
https://html.spec.whatwg.org/
https://w3c.github.io/DOM-Parsing/
https://w3c.github.io/selection-api/
BUG=594918
Review-Url: https://codereview.chromium.org/2043503002
Cr-Commit-Position: refs/heads/master@{#398352}
Implement ui::ClipboardMus.
This lets chrome in mash read and write from the mus server's clipboard.
BUG=581460
Review-Url: https://codereview.chromium.org/2011833003
Cr-Commit-Position: refs/heads/master@{#398351}
Move GLContext creation from //ui/gl to //ui/gl/init.
Move the code that performs GLContext creation to the new target. Remove
the old code and delete the static method from GLContext entirely.
This adds gl_factory_<platform>.cc files for all platforms. These
platform specific files will have GLSurface creation code added next.
Add InitializeGLContext() function to simplify a common pattern that is
repeated frequently. When a new GLContext is created, it's wrapped in a
scoped_refptr and then initialized. If initialization fails nullptr is
returned instead. Encapsulate this logic into a function instead of
repeating it.
There is one code change in GLSurfaceEGL::InitalizeOneOff(). It creates
a GLContext to test if surfaceless contexts are supported. It can no
longer use the deleted method in GLContext. All platforms that hit this
code path will end up creating a GLContextEGL, so just directly
instantiate it.
This change is part of step two from the associated bug.
BUG=611142
Review-Url: https://codereview.chromium.org/2037793002
Cr-Commit-Position: refs/heads/master@{#398350}
mash: Migrate SessionStateDelegate interface to wm common types
Not much changed here, as the only interesting implementation is in chrome.
BUG=615155
TEST=existing ash_unittests and chrome unit_tests
Review-Url: https://codereview.chromium.org/2042333002
Cr-Commit-Position: refs/heads/master@{#398349}
Remove traces of USE_NSS_CERTS from crypto/
NSS is no longer an option as the cryptographic service
provider - all platforms have transitioned to using BoringSSL. Any remaining files in crypto/ that use NSS will always have USE_NSS_CERTS set.
This also fixes some unit tests that used the wrong ifdefs once
everything was converted to use BoringSSL.
BUG=604728
Review-Url: https://codereview.chromium.org/2046863002
Cr-Commit-Position: refs/heads/master@{#398348}
remove google account requirement on the client for local testing
1) What used to happen before this CL?
Even when the user provides the engine ip, port, transport protocol and
token in the command line, he/she still needs to enter a google account
although in the c++ code, it doesn't use the token generated by GAIA.
2) Why was that bad? What kind of trouble did that get us into?
It's not feasible to automate entering account from the bot. It'll
keep us from doing UI-related automation testing.
3) What does this CL do to make it better?
It checks the command line flag from the java code, so that if engine ip
etc are provided by the command line, a google account is not needed.
BUG=602826
Review-Url: https://codereview.chromium.org/2034953002
Cr-Commit-Position: refs/heads/master@{#398347}
android: Disable DexLoaderTests
Failing on main waterfall. See bug for details.
BUG=617935
[email protected]
Review-Url: https://codereview.chromium.org/2048593003
Cr-Commit-Position: refs/heads/master@{#398346}
Make field trials activated in the GPU process be reflected in browser.
This allows field trials that are queried in the GPU process be
reflected in UMA and crash reports. Currently, they are being
omitted.
This follows https://codereview.chromium.org/2020413002 - which
refactored this functionality out of the renderer process code, so that
it could be re-used (i.e. in this CL). One modification is made to that
refactoring, which is removing the sending of the IPC message from
the syncer class, since GPU and renderer processes require different
IPC messages.
BUG=616171
Review-Url: https://codereview.chromium.org/2034933002
Cr-Commit-Position: refs/heads/master@{#398345}
cc: Clear always_use_active_tree_opacity_effect_ids
When we rebuild property trees.
BUG=617826
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2044803002
Cr-Commit-Position: refs/heads/master@{#398344}
views/mus: Have explicit ownership of views::WindowManagerConnection.
[email protected] for API call update in //services/navigation
BUG=none
Review-Url: https://codereview.chromium.org/2026623002
Cr-Commit-Position: refs/heads/master@{#398343}
Postpone JS calls from CoreOobeHandler until the JS side gets initialized
This fixes a race between loading JavaScript code and calling methods from it.
The race was caused by CoreOobeHandler class whose methods (like ReloadContent)
called JavaScript methods directly, while there was a possibility that JavaScript
files defining them were not loaded yet.
This was observed, for example, when running tests inherited from
LoginManagerTest, as the form of the following errors printed into console:
* [ERROR:CONSOLE(1)] "Uncaught ReferenceError: cr is not defined", source: (1)
* [ERROR:CONSOLE(1)] "Uncaught TypeError: Cannot read property 'reloadContent'
of undefined", source: (1)
This CL adds a new condition that doesn't allow to call JS methods until
'screenStateInitialize' message is received from JS side. Any attempts to call
JS method too early are deferred and executed when the 'screenStateInitialize'
is finally received.
BUG=614805
TEST=manual: run login-related tests and check that no JavaScript errors appear in the console.
Review-Url: https://codereview.chromium.org/2042283002
Cr-Commit-Position: refs/heads/master@{#398342}
Drop FilterEffectBuilder::m_referenceFilters
The job of this Vector used to be to keep a reference to the nested
"reference" filters, to avoid them being destroyed. The entire filter
graph/chain is now on the GC heap, and traced via
FilterEffectBuilder::m_lastEffect, so this additional reference is of no
use.
Review-Url: https://codereview.chromium.org/2043013002
Cr-Commit-Position: refs/heads/master@{#398341}
setup_toolchain.py: Fix the path to win_sdk/bin/SetEnv*.json
The 'bin' part should be lowercase. This matters on case-sensitive
filesystems, such as those commonly used on Linux.
BUG=495204
Review-Url: https://codereview.chromium.org/2046633005
Cr-Commit-Position: refs/heads/master@{#398340}
Suppress GpuRasterization.ConcavePaths on Nexus 9.
The test's failing because of a legitimate bug. This suppression should
be removed after the bug's fixed.
BUG=617805
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2046523006
Cr-Commit-Position: refs/heads/master@{#398339}
Disable tests failing under Dr. Memory
ServiceWorkerProviderHostTest.ContextSecurity
BUG=618015
[email protected]
Review URL: https://codereview.chromium.org/2043123002 .
Cr-Commit-Position: refs/heads/master@{#398338}
Moves MruWindowTracker into common
BUG=617789
TEST=covered by tests
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2045793002
Cr-Commit-Position: refs/heads/master@{#398337}
Document markers such as spelling mistakes should not only be present on element nodes that are editable.
1. Static-text nodes on which spelling markings usually appear, are not element nodes.
2. Editable state shouldn't matter, because for one thing find results may not be editable.
BUG=508320
TESTED=Jaws
[email protected]
Review-Url: https://codereview.chromium.org/2045753002
Cr-Commit-Position: refs/heads/master@{#398336}
Update Win8 webgl2 conformance test expectations.
BUG=
TEST=win8 bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2049433002
Cr-Commit-Position: refs/heads/master@{#398335}
Speculative fix to solve VideoLayer crashes.
The code as written appears to be racy if setWebLayer() triggers
anything on the compositor thread; avoid this.
BUG=595980
TEST=TBD if this fixes the issue.
Review-Url: https://codereview.chromium.org/2045813002
Cr-Commit-Position: refs/heads/master@{#398334}
cc: Visible Rect Calculation use RectF between transformations
Currently visible rect calculation expands to enclosing rect in target
space, and then transform to layer space, and expand to enclosing rect
in layer space again. Remove the first expansion to rect.
R=ajuma
BUG=594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2015653002
Cr-Commit-Position: refs/heads/master@{#398333}
Blimp: Removed sending redundant RESIZE message to engine
At the startup, the blimp client sends a RESIZE message to the engine
with size 0x0 which is not useful for the engine. Removed sending of
this message. The correct display size is sent later when the native
android view inflates to its correct size.
BUG=617278
Review-Url: https://codereview.chromium.org/2046453003
Cr-Commit-Position: refs/heads/master@{#398332}
clang-tidy WaitableEvent refactor (Windows side)
Many PCH errors while running clang-tidy on Windows but still generated
a couple fixes.
Also some NACL changes per this being the first build with enabled_nacl
(had forgotten in Linux change @ https://codereview.chromium.org/2024723002/)
BUG=612843
[email protected] (purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO)
Review-Url: https://codereview.chromium.org/2039943005
Cr-Commit-Position: refs/heads/master@{#398331}
Fix the .ycm_extra_conf.py and SublimeText documentation.
There were a few broken links in the documentation and the provided
YCM template would not load properly in Sublime Text 3 on windows.
Lastly make the unit presubmit test pass on Windows too.
BUG=NONE
TEST=chromium.ycm_extra_conf_unittest.py
Review-Url: https://codereview.chromium.org/2039923002
Cr-Commit-Position: refs/heads/master@{#398330}
Fix a compilation issue in main_dll_loader_win.cc
https://codereview.chromium.org/2031833002/ has changed the signature of
GetIsPerUserInstall (it uses a string16 instead of a FilePath) but one of
its usage hasn't been updated.
BUG=617013
Review-Url: https://codereview.chromium.org/2041943003
Cr-Commit-Position: refs/heads/master@{#398329}
Replace ui::LatencyInfo::InputCoordinate with gfx::PointF
This reduces code duplication and makes the world a happier place.
BUG=611802
[email protected]
Committed: https://crrev.com/cc016ede169b3f1a9d7153a27eadd6d8ead52e1a
Review-Url: https://codereview.chromium.org/2039853004
Cr-Original-Commit-Position: refs/heads/master@{#398278}
Cr-Commit-Position: refs/heads/master@{#398328}
Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #12 id:220001 of https://codereview.chromium.org/1951193002/ )
Reason for revert:
Failing context_lost_tests on mac: https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/9301
Failing webgl_conformance_tests on Nexus 5:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%205%29/builds/486
and Nexus 6: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%206%29/builds/585
Original issue's description:
> cc: Add mailbox support to ResourceProvider write locks.
>
> This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
> requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
> ensures that the texture id for the mailbox is destroyed after use on
> the worker context.
>
> This CL also includes the following cleanup:
> 1. ResourceProvider locks don't keep resource pointers around.
> 2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
> 3. GpuRasterizer is folded back into GpuRasterBufferProvider.
> 4. TileTaskManager does not own RasterBufferProvider.
>
> BUG=525259
> [email protected]
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2
> Cr-Commit-Position: refs/heads/master@{#398204}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525259
Review-Url: https://codereview.chromium.org/2046033002
Cr-Commit-Position: refs/heads/master@{#398327}
Refactor rel32 searching process for x64 to make it more similar to x86.
I created a base class Rel32Finder from which derives both Rel32FinderX86 and Rel32Finder64.
This makes ParseRel32RelocsFromSection method more similar in x64 and x86.
Note that I removed the Win32 part of the name because it may be used by DisassemblerElf.
I created test cases for Rel32FinderX64 which extends those for Rel32FinderX86.
BUG=617965
Review-Url: https://codereview.chromium.org/2008253004
Cr-Commit-Position: refs/heads/master@{#398326}
Reland of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2040143003/ )
Reason for revert:
The test is more correct than it was. Chrome on the Nexus 9 is broken. Let's add a suppression instead of reverting the test.
Original issue's description:
> Revert of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2042143002/ )
>
> Reason for revert:
> Broke the GpuRasterization.ConcavePaths test on Nexus 9. https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%209%29/builds/1470
>
> Original issue's description:
> > Strengthen GpuRasterizationConcavePathsPagetest test.
> >
> > This test was passing when the entire 'pacman' image area was filled
> > with the 'interior' color. This change ensures that we test pixels on
> > the exterior and interior of the paths, within the pacman's bounds.
> >
> > [email protected]
> > BUG=617805
> > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa
> > Cr-Commit-Position: refs/heads/master@{#398234}
>
> [email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=617805
>
> Committed: https://crrev.com/f11e62040635b57dccb826c1124ba53afc485792
> Cr-Commit-Position: refs/heads/master@{#398317}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617805
Review-Url: https://codereview.chromium.org/2046023002
Cr-Commit-Position: refs/heads/master@{#398325}
Support for bundling Chromium unittests into a tarball.
Without this change only the engine binary can be bundled in this way.
This change allows all the required files to successfully run in a
docker container can be bundled together in a tarball and uploaded to a
new location. This makes the process of exporting tests this way easily
repeatable and automatable.
This builds on the manifest generation work of
https://codereview.chromium.org/1997493002/
BUG=613000,608487,608483
Review-Url: https://codereview.chromium.org/2028353003
Cr-Commit-Position: refs/heads/master@{#398324}
Fix version format used on iOS by build/mac/tweak_info_plist.py.
Chrome on iOS uses different format by default for the "CFBundleVersion"
and "CFBundleShortVersionString" Info.plist values.
Change _AddVersionKeys function to take as parameter a dictionary from
Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and
@PATCH@ patterns to represent the different component of the version,
and pass a different dictionary depending on the platform.
Refactor how the version is extracted using the build/util/version.py
script (it was invoked twice, but the second invocation can be removed
as the output needs to be post-processed).
BUG=502295,616750
Review-Url: https://codereview.chromium.org/2044893002
Cr-Commit-Position: refs/heads/master@{#398323}
Site Settings Desktop: Fix NOTREACHED when group name is unregistered.
BUG=617724
Review-Url: https://codereview.chromium.org/2048633002
Cr-Commit-Position: refs/heads/master@{#398322}
Whitelist themes in CSP of chrome://newtab
BUG=617499
Review-Url: https://codereview.chromium.org/2040903002
Cr-Commit-Position: refs/heads/master@{#398321}
Don't initialize ash::TouchTransformerController in mash.
Event processing doesn't happen in the ash process in the context of
mash. The TouchTransformerController shouldn't be initialized in the ash
process as a result. Equivalent logic will need to move into the mus-ws
process in the future.
BUG=none
Review-Url: https://codereview.chromium.org/2044163002
Cr-Commit-Position: refs/heads/master@{#398320}
Remove the use of OwnedPtrDeleter in ImageDecoder.
It's hard to mechanically replace specializations of OwnedPtrDeleter<T>
to std::unique_ptr equivalents. Therefore, they are converted to
std::unique_ptr manually.
New typedefs named XXXXUniquePtr is introduced so people can always use
std::unique_ptr with a correct deleter.
BUG=617504
Review-Url: https://codereview.chromium.org/2037373002
Cr-Commit-Position: refs/heads/master@{#398319}
Add PKCS#8 ECPrivateKey export/import functions.
Also const-correct a few functions and add some missing error tracers.
Deprecate the old ones. Also const-correct a few functions and add some missing
error tracers. Future work migrate existing serializations to the new format.
BUG=603319
Review-Url: https://codereview.chromium.org/1935053003
Cr-Commit-Position: refs/heads/master@{#398318}
Revert of Strengthen GpuRasterizationConcavePathsPagetest test. (patchset #1 id:1 of https://codereview.chromium.org/2042143002/ )
Reason for revert:
Broke the GpuRasterization.ConcavePaths test on Nexus 9. https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%209%29/builds/1470
Original issue's description:
> Strengthen GpuRasterizationConcavePathsPagetest test.
>
> This test was passing when the entire 'pacman' image area was filled
> with the 'interior' color. This change ensures that we test pixels on
> the exterior and interior of the paths, within the pacman's bounds.
>
> [email protected]
> BUG=617805
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/3b4f64f3c1564a04a688ea3fcefe3f5c4fe339fa
> Cr-Commit-Position: refs/heads/master@{#398234}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617805
Review-Url: https://codereview.chromium.org/2040143003
Cr-Commit-Position: refs/heads/master@{#398317}
Ink Drop is visibly shown when right-clicking and dragging on the toolbar custom button. According to the report, the button should be non-reactive and show no visible signs of being clicked on.
BUG=617764
Review-Url: https://codereview.chromium.org/2042883003
Cr-Commit-Position: refs/heads/master@{#398316}
Converts MruWindowTracker to work with common types
BUG=617789
TEST=covered by tests
[email protected]
Review-Url: https://codereview.chromium.org/2042913002
Cr-Commit-Position: refs/heads/master@{#398315}
Zero closed ThreadCondition handles
The ThreadCondition constructor checks for failed calls to CreateMutex
and CreateSemaphore, but if they are detected it closes the handles
without zeroing them. This change zeroes them to avoid unpredictable
behavior from use-after-close.
The change also checks for nullptr before closing them in the destructor
in order to keep handle verifiers happy.
BUG=615306
Review-Url: https://codereview.chromium.org/2043553003
Cr-Commit-Position: refs/heads/master@{#398314}
[NTP Snippets] The snippets header stay 10dp from the first card.
BUG=616725
Review-Url: https://codereview.chromium.org/2045953002
Cr-Commit-Position: refs/heads/master@{#398313}
Move GCM browser initialization to chrome layer.
The only java-side user of GCMDriver is ChromeGcmListenerService.java
so rather than use BrowserStartupController and doing all the
necessary initialization (like PathUtils) separately, use the unified
ChromeBrowserInitializer path instead.
Tested codepath according to: http://crbug.com/585421#c7
BUG=583086
Review-Url: https://codereview.chromium.org/2043703003
Cr-Commit-Position: refs/heads/master@{#398312}
Rename WrapperTypeInfo.getHeader to getHeapObjectHeader
So it is in sync with the naming in generated bingings classes.
LOG=no
BUG=468240
Review-Url: https://codereview.chromium.org/2048563003
Cr-Commit-Position: refs/heads/master@{#398311}
Fixes ASan crash for an embedded Blink-in-JS component.
In the test case (in this patch) it appears the Blink-in-JS component tries to run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script execution is forbidden." (probably because it is being created in this weird place?)
This patch re-adds the simple check that was removed in https://codereview.chromium.org/1885833002 which checked if the toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).
BUG=617104
Review-Url: https://codereview.chromium.org/2039333002
Cr-Commit-Position: refs/heads/master@{#398310}
Update V8 to version 5.3.164.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f6e44438..53261a81
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2048663002
Cr-Commit-Position: refs/heads/master@{#398309}
Revert of Replace ui::LatencyInfo::InputCoordinate with gfx::PointF (patchset #6 id:90001 of https://codereview.chromium.org/2039853004/ )
Reason for revert:
This appears to have broken the Windows GPU debug builder. First broken build: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/40788
Original issue's description:
> Replace ui::LatencyInfo::InputCoordinate with gfx::PointF
>
> This reduces code duplication and makes the world a happier place.
>
> BUG=611802
> [email protected]
>
> Committed: https://crrev.com/cc016ede169b3f1a9d7153a27eadd6d8ead52e1a
> Cr-Commit-Position: refs/heads/master@{#398278}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=611802
Review-Url: https://codereview.chromium.org/2048673002
Cr-Commit-Position: refs/heads/master@{#398308}
Add CORE_EXPORT to freezeV8Object() in V8Binding.
Some IDLs in modules requires FrozenArray<>. (e.g. PaymentAddress.idl)
To use it in modules directory, we should export freezeV8Object() function.
BUG=617919
Review-Url: https://codereview.chromium.org/2044083002
Cr-Commit-Position: refs/heads/master@{#398307}
Remove use of deprecated MessageLoop methods in google_apis.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2033203002
Cr-Commit-Position: refs/heads/master@{#398306}
[Layout API] Migrate TextAutosizer to block layout API
There are several references to document->layoutView() which can be
converted directly to document->layoutViewItem(), but there is one
that needs to use the block layout API shim introduced in
<https://codereview.chromium.org/2032023003>. It passes the layout
object around through several functions and uses a number of methods
that are not part of the API yet. As this file is already in core/layout
and I'm only converting enough to get rid of the document->layoutView
method, I see no reason to pollute the API with a raft of new methods.
BUG=499321
Review-Url: https://codereview.chromium.org/2041103002
Cr-Commit-Position: refs/heads/master@{#398305}
DevTools: rename InspectorResourceAgent to InspectorNetworkAgent.
TBR=alph
Review-Url: https://codereview.chromium.org/2044623003
Cr-Commit-Position: refs/heads/master@{#398304}
Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"
Reason for reland:
No longer fails on chromeos host
Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.
First attempt:
https://codereview.chromium.org/1968993002
TBR=agrieve
BUG=609219
Review-Url: https://codereview.chromium.org/2036633003
Cr-Commit-Position: refs/heads/master@{#398303}
Adding Event.Latency.Browser.WheelUI, Passing latency_info to ProcessMouse/MouseWheelEvent functions.
I had to change processMouseEvent and ProcessMouseWheelEvent functions to carry latency info for mouse/mouseWheel events. The latency_info was needed for the Event.Latency.Browser.WheelUI histogram.
Many files are modified due to propagation of the two function signature changes and/or overridden functions.
BUG=565346
TEST=MouseEventLatencyUIComponentExists,
MouseWheelEventLatencyUIComponentExists
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1993383002
Cr-Commit-Position: refs/heads/master@{#398302}
MD User Manager: Moves user pod strings with product names to respective string resource files
BUG=617744
Review-Url: https://codereview.chromium.org/2046733002
Cr-Commit-Position: refs/heads/master@{#398301}
Fix a crash on Pixel.
In some build, the base::Passed(&channel_handle) is executed before
channel_handle.get(). So the first callback function
GpuServiceMus::EstablishGpuChannelOnGpuThread gets a nullptr for the
channel_handle. Fix the problem by using raw pointer directly.
BUG=586390
Review-Url: https://codereview.chromium.org/2044883002
Cr-Commit-Position: refs/heads/master@{#398300}
Roll src/third_party/skia/ ee295645b..06115ee43 (1 commit).
https://chromium.googlesource.com/skia.git/+log/ee295645bd91..06115ee4300e
$ git log ee295645b..06115ee43 --date=short --no-merges --format='%ad %ae %s'
2016-06-07 bsalomon Get segment masks from GrShape. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2046753002
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2044873002
Cr-Commit-Position: refs/heads/master@{#398299}
Pass --loader-base-dir in jinja_template to make webrtc happy
Without this explicit flag, the base-dir ends up as //chromium/src
within a webrtc checkout rather than //.
BUG=webrtc:5956
Review-Url: https://codereview.chromium.org/2046523003
Cr-Commit-Position: refs/heads/master@{#398298}
Upstream the grammer for union types to idl_parser
There is no reason to put it in blink_idl_parser.py
BUG=617899
Review-Url: https://codereview.chromium.org/2048613002
Cr-Commit-Position: refs/heads/master@{#398297}
mb: Allow overriding the path to the gyp script
This allows changing the path to make this script usable
in other projects than chromium.
BUG=616035
Review-Url: https://codereview.chromium.org/2038483002
Cr-Commit-Position: refs/heads/master@{#398296}
Fix build/apk_test.gypi since webrtc still requires it.
It was broken by https://codereview.chromium.org/1975153003
BUG=webrtc:5956
Review-Url: https://codereview.chromium.org/2041723006
Cr-Commit-Position: refs/heads/master@{#398295}
Update V8 to version 5.3.160.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cba1fdd4..f6e44438
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2043963003
Cr-Commit-Position: refs/heads/master@{#398294}
AVDACodecImages keep their backing SurfaceTexture alive
Previously, when destructing an AVDA, we had to delete the
AVDACodecImages attached to the PictureBuffer textures, and
use a fragile method of copying the SurfaceTexture buffer
and creating egl images to make sure those PictureBuffer
textures didn't become unbacked.
Now the AVDACodecImages are kept alive by the Textures
they're bound to, and they keep a ref to AVDASharedState
which contains the shared SurfaceTexture and its platform
texture. The AVDASharedState destructor cleans up the
SurfaceTexture and deletes the platform texture.
BUG=533630,614090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2005103004
Cr-Commit-Position: refs/heads/master@{#398293}
Build rule for PDFium XFA PNG fuzzer
BUG=616838
Review-Url: https://codereview.chromium.org/2041023002
Cr-Commit-Position: refs/heads/master@{#398292}
binding: Makes V8CustomEvent use V8PrivateProperty instead of V8HiddenValue.
BUG=
Review-Url: https://codereview.chromium.org/2041013003
Cr-Commit-Position: refs/heads/master@{#398291}
[NTP Snippets] Unschedule fetches when the service should be disabled
The snippet service is now able to switch between being enabled
or disabled, properly notifying its observers and releasing
unecessary resources
BUG=608913
Review-Url: https://codereview.chromium.org/2000233002
Cr-Commit-Position: refs/heads/master@{#398290}
PlzNavigate: update test expectations
This CL updates the test expectations for the FYI bot Linux Browser Side
Navigation. This follows changes in the ServiceWorker code, that caused it to
completely stopped working with PlzNavigate enabled. Since full support is not
actually there, just excluding the tests for now.
Making it no try, since there no actual code changes and it's for an FYI bot.
BUG=475027,504347,576261
[email protected]
NOTRY=TRUE
Review-Url: https://codereview.chromium.org/2043043002
Cr-Commit-Position: refs/heads/master@{#398289}
gpu: Allow framebuffers with mixed samples if the hw supports it
Allow framebuffers with mixed samples if the hw supports it.
The commit "Check samples matching for framebuffer attachments."
regressed this.
The HW that support this include NVIDIA GTX 980 (desktop, "GM20X" chips)
and SHIELD TV (Android, "X1" chips).
BUG=429053
TEST=gl_tests --gtest_filter=CHROMIUMFramebufferMixedSamplesTest*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2031263002
Cr-Commit-Position: refs/heads/master@{#398288}
Parse PopularSites JSON on iOS too.
Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.
BUG=603026
Review-Url: https://codereview.chromium.org/2045563002
Cr-Commit-Position: refs/heads/master@{#398287}
Pack repeated code in tex(Sub)Image2D and texSubImage3D into helper func
There are some repeated code in these functions and the only diff amongest
them is whether it gives "texImage2D" or "texSubImage2D" or "texSubImage3D".
This CL packs the repeated part into helper function. After this, when
we make changes to these functions in the future, we would only need to
change one place instead of 3 places. Also, this will reduce potential
bugs in the code. For example, at this moment, line 4131 in
WebGLRenderingContextBase.cpp (texImage2D) does this:
if (imageForRender && imageForRender->isSVGImage())
while line 1095 in WebGL2RenderingContextBase.cpp (texSubImage3D) does:
if (imageForRender->isSVGImage())
which doesn't do a null check on imageForRender.
This change can certainly prevent bugs like this.
For this change, we just need to make sure that all bots are green.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2025703002
Cr-Commit-Position: refs/heads/master@{#398286}
tools/android/loading Add instructions to deploy to staging frontend.
Review-Url: https://codereview.chromium.org/2041323002
Cr-Commit-Position: refs/heads/master@{#398285}
Remove use of deprecated MessageLoop methods in sql.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2033693004
Cr-Commit-Position: refs/heads/master@{#398284}
[Android] Specify compositor tab title size in scaled pixels.
This lets Resources do the size calculations, and also fixes an issue where the
font scaling factor would be applied twice for >600dp screens
(chrome/android/java/res/values-sw600dp/dimens.xml already specifies the size
in sp).
Review-Url: https://codereview.chromium.org/2033683002
Cr-Commit-Position: refs/heads/master@{#398283}
Remove use of deprecated MessageLoop method in ios.
This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2035953002
Cr-Commit-Position: refs/heads/master@{#398282}
Revert of Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness (patchset #3 id:60001 of https://codereview.chromium.org/2033953002/ )
Reason for revert:
looks like this broke the Android Tests (dbg) bot
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)
also see crbug.com/617935
Original issue's description:
> Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness
>
> There seems to be data cached by the OS which is not deleted by
> DexLoader#deleteCachedDexes() which is causing the test to be flaky.
> This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test
> DexLoader#deleteCachedDexes() in a scenario which is closer to how the function
> is used in production.
>
> The test used to test that calling DexLoader#deleteCachedDexes() would make
> DexLoader#load() load a dex file from scratch.
>
> The CL changes the test to test that:
> - DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local
> data directory
> - It is possible to use reuse a data directory to load several dexes
>
> BUG=616923
>
> Committed: https://crrev.com/c59b7de12ab8878ddfe4df4fe5cd91b0d526b8c2
> Cr-Commit-Position: refs/heads/master@{#398198}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616923
Review-Url: https://codereview.chromium.org/2041333003
Cr-Commit-Position: refs/heads/master@{#398281}
[Skia] Add support for both CPU and GPU nanobench runs
BUG=skia:5398
# For minor change to ct_skps.isolate
TBR=maruel
NOTRY=true
Review-Url: https://codereview.chromium.org/2048623002
Cr-Commit-Position: refs/heads/master@{#398280}
Revert of Use /LTCG:Incremental to speed up the non-clobber official builds. (patchset #2 id:20001 of https://codereview.chromium.org/2045683002/ )
Reason for revert:
I'm seeing some compiler issue on the Win perf builders (https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9316/steps/compile/logs/stdio) :
fatal error C1001: An internal error has occurred in the compiler
BUG=616946
Original issue's description:
> Use /LTCG:Incremental to speed up the non-clobber official builds.
>
> /LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.
>
> Committed: https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800
> Cr-Commit-Position: refs/heads/master@{#398153}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2035313007
Cr-Commit-Position: refs/heads/master@{#398279}
Replace ui::LatencyInfo::InputCoordinate with gfx::PointF
This reduces code duplication and makes the world a happier place.
BUG=611802
[email protected]
Review-Url: https://codereview.chromium.org/2039853004
Cr-Commit-Position: refs/heads/master@{#398278}
tools/android/loading Fix precision and formatting issues in frontend
Fix rounding issue:
int(x + 0.5) does not round up correctly.
This should be round(x+0.5) or math.ceil(x).
Fix formatting issue: the timeout is a float, and should be printed
using %f instead of %i.
Review-Url: https://codereview.chromium.org/2037373003
Cr-Commit-Position: refs/heads/master@{#398277}
Fix re-usage of stale cached WebPreferences in RenderViewHost.
During layout tests when preferences were being overriden they were not
being properly being used as the cached WebPreferences on the
RenderViewHost was not updated. This change fixes that and changes the way
spatial navigation is enabled in layout tests to adapt to this change.
This is an initial change to support the moving of mixed content checks to
the browser.
BUG=576270
Review-Url: https://codereview.chromium.org/2042763002
Cr-Commit-Position: refs/heads/master@{#398276}
Clean up markClientsAndObserversFinished().
Simplify transferring a counted element entry from one set to another.
To do so, add generalized version of add() over HashCountedSet that lets
the caller specify a count.
R=
BUG=
Review-Url: https://codereview.chromium.org/2045883002
Cr-Commit-Position: refs/heads/master@{#398275}
[libfuzzer] Add fuzzer for third_party/hunspell with dictionary.
Ported from google3 with minor changes.
[email protected], [email protected], [email protected], [email protected], [email protected]
BUG=539572
Review-Url: https://codereview.chromium.org/2012443002
Cr-Commit-Position: refs/heads/master@{#398274}
Maintain wrapper tracing deque in ScriptWrappableVisitor
This cl uses updated V8 api which will be easier to work with incrementally
(althrough it is not used incrementally at the moment). For that
ScriptWrappableVisitor now has to maintain his marking deque.
LOG=no
BUG=468240
Review-Url: https://codereview.chromium.org/2044023002
Cr-Commit-Position: refs/heads/master@{#398273}
[iOS] Remove dependency third_party/WebKit on iOS.
Chrome on iOS now requires mojo for WebUI which has an optional dependency
on third_party/WebKit. Chrome on iOS cannot depends on third_party/WebKit,
so only enable those optional dependencies if target OS is not iOS.
Fixes the following build failures when building with clang Xcode (which
is only done by downstream release bots as we do not have capacity to run
it on each commit):
error: unable to load plugin 'third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib': 'dlopen(third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib, 9): Symbol not found: __ZN4llvm8RegistryIN5clang15PluginASTActionEE4HeadE
Referenced from: third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib
To prevent further dependencies on third_party/WebKit to creep in change
third_party/WebKit/Source/{config.gyp,wtf/wtf.gyp} to not define any
target when target OS is iOS (in order to generate errors when running
"gclient runhooks").
This is similar to corresponding GN changes in issue
https://codereview.chromium.org/2004743002/.
BUG=616750
Review-Url: https://codereview.chromium.org/2036683002
Cr-Commit-Position: refs/heads/master@{#398272}
Re-enable IndexedDB tests that weren't really flaky
The following tests were marked flaky in https://crbug.com/616100 and
https://crbug.com/616155:
- IndexedDBBrowserTest.GetAllMaxMessageSize
- IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest
- IndexedDBBrowserTest.DeleteCompactsBackingStore
But they're not so much flaky, as genuinely broken since
https://codereview.chromium.org/2018663002 landed. That patch will soon
be fixed or reverted now that it has been identified as the root cause.
BUG=616155,616100
[email protected]
Review-Url: https://codereview.chromium.org/2044533002
Cr-Commit-Position: refs/heads/master@{#398271}
Update V8 to version 5.3.157.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/412fea1c..cba1fdd4
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2047653002
Cr-Commit-Position: refs/heads/master@{#398270}
Roll buildtools 1a6b666652..8dd3c8e39a
In order to roll GN a8e5d2e327..c0f67c5511 (r396969:r398260) and pick up
the following changes:
40451c5 Add support for user defined "pool" to GN.
0e85587 Fix doc on "Multiple outputs" for runtime_deps.
5797920 [Mac/iOS/GN] Document the new rules for create_bundle and runtime_deps.
4feb71fc [GN] Adding missing source type for extension .appex.
3dbb1f6 Migrate WaitableEvent to enum-based constructor in tools/
[email protected]
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg
Review-Url: https://codereview.chromium.org/2045913002
Cr-Commit-Position: refs/heads/master@{#398269}
V4L2VDA: Typo fix
Fix typo in TryToSetupDecodeOnSeparateThread method to set
decode_client_ properly in V4L2VideoDecodeAccelerator and
V4L2SliceVideoDecodeAccelerator classes.
BUG=
Review-Url: https://codereview.chromium.org/2044033002
Cr-Commit-Position: refs/heads/master@{#398268}
[Android backup] Sync settings, and new to old version restore
Backup and restore the sync settings. Also enable restore to an
older version of Chrome than the backed up version.
BUG=616477
BUG=613205
Review-Url: https://codereview.chromium.org/2047473003
Cr-Commit-Position: refs/heads/master@{#398267}
Remove yet another obsolete MSVC workaround.
The workaround is no longer necessary.
BUG=617504
Review-Url: https://codereview.chromium.org/2048583003
Cr-Commit-Position: refs/heads/master@{#398266}
Move StyleSheetResourceClient to Oilpan heap
BUG=587663
Review-Url: https://codereview.chromium.org/2031973002
Cr-Commit-Position: refs/heads/master@{#398265}
Plumb TransformValue into the 'transform' property of StylePropertyMap.
This allows TransformValues to be inserted into the
InlineStylePropertyMap. It does not yet allow them to be retrieved from
any of the StylePropertyMaps. I'm working on that in
https://codereview.chromium.org/2039093003.
BUG=545318
Review-Url: https://codereview.chromium.org/2048483002
Cr-Commit-Position: refs/heads/master@{#398264}
Truncate long file name with ellipsis.
BUG=524114
TEST=manually
Review-Url: https://codereview.chromium.org/2027553006
Cr-Commit-Position: refs/heads/master@{#398263}
Set tracing categories explicitly in Clovis and Sandwich
Also restrict the categories in Sandwich to reduce the size of traces by 2x.
BUG=582080
Review-Url: https://codereview.chromium.org/2047463002
Cr-Commit-Position: refs/heads/master@{#398262}
Remove unused code in DeferredLegacyStyleInterpolation
Review-Url: https://codereview.chromium.org/2042213002
Cr-Commit-Position: refs/heads/master@{#398261}
Sandbox detached iframes a bit more
Disallow cross-origin wrapper creation from them
BUG=616225
[email protected]
Review-Url: https://codereview.chromium.org/2042743002
Cr-Commit-Position: refs/heads/master@{#398260}
Update V8 to version 5.3.154.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/80d06aa4..412fea1c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2047643002
Cr-Commit-Position: refs/heads/master@{#398259}
serviceworker-notification-properties.html no longer leaks
Fixed by a revert in V8:
https://chromium.googlesource.com/v8/v8/+/9b606523b5e210f60c4260ee5f50a54e8f07adbd
BUG=617137
TBR=jbroman
NOTRY=true
Review-Url: https://codereview.chromium.org/2040153002
Cr-Commit-Position: refs/heads/master@{#398258}
Revert of Flip more Win bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2030823002/ )
Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a false alarm)
Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/7879/steps/compile/logs/stdio
C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome chrome_official_builder_no_unittests -j200
ninja: Entering directory `C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'
Original issue's description:
> Flip more Win bots to GN.
>
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
>
> [email protected]
> BUG=605319
>
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319
Review-Url: https://codereview.chromium.org/2046913002
Cr-Commit-Position: refs/heads/master@{#398257}
Delete unused password_bubble_experiment_unittest.cc
Review-Url: https://codereview.chromium.org/2046493003
Cr-Commit-Position: refs/heads/master@{#398256}
Remove obsolete friend declarations for MSVC.
These friend declarations were added because MSVC had a bug around the
visibility of nested classes. They are no longer necessary.
BUG=617504
Review-Url: https://codereview.chromium.org/2041273002
Cr-Commit-Position: refs/heads/master@{#398255}
Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose()
WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*),
but I think the issue had existed only in the transition period.
This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose().
(*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912625b89ba97bb
BUG=
Review-Url: https://codereview.chromium.org/2024033002
Cr-Commit-Position: refs/heads/master@{#398254}
DevTools: make LiveSASS experiment public
BUG=none
R=pfeldman
Review-Url: https://codereview.chromium.org/2019143002
Cr-Commit-Position: refs/heads/master@{#398253}
[MD History] Add search for synced devices.
This CL implements a simple search that matches the functionality of the
original history page.
This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.
BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2022003002
Cr-Commit-Position: refs/heads/master@{#398252}
mojo ArrayTraits<T>::Resize returns bool indicating success
ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.
BUG=611802
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2045723002
Cr-Commit-Position: refs/heads/master@{#398251}
Split SocketWatcher and SocketWatcherFactory out of NQE
This is a simple refactoring CL, and does not involve any
functionality change.
BUG=616302
Review-Url: https://codereview.chromium.org/2024813003
Cr-Commit-Position: refs/heads/master@{#398250}
Replace info.This() with info.Holder()
If the object is not window, info.This() == info.Holder(). Hence, we can just replace
info.This() with info.Holder().
If the object is window, info.Holder() is the inner window and info.This() is the outer window.
However, all accesses to the outer window are redirected to the inner window.
Hence, the replacement doesn't change any behavior.
BUG=
Review-Url: https://codereview.chromium.org/2042943002
Cr-Commit-Position: refs/heads/master@{#398249}
[CSS Typed OM] Rename StyleValue -> CSSStyleValue
This matches the most recent update of the spec:
https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects
BUG=545318
Review-Url: https://codereview.chromium.org/2036893003
Cr-Commit-Position: refs/heads/master@{#398248}
Update V8 to version 5.3.153.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a4540654..80d06aa4
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2046893002
Cr-Commit-Position: refs/heads/master@{#398247}
Validate bound buffer for draw calls
DrawArrays or drawElements should generate invalid operation error if no
buffer is bound to enabled attribution. Refer WebGL 1.0 spec for details
in section 6.5 "Enabled Vertex Attributes and Range Checking".
BUG=295792
TEST=conformance2/vertex_arrays/vertex-array-object.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2019513004
Cr-Commit-Position: refs/heads/master@{#398246}
Prevent display going to sleep while taking a screenshot
On MacOS, GrabViewSnapshot() call would block for the duration of
display/GPU sleep which leads to protocol client to wait and tests
to time out when power saving is engaged. This prevents power saving
while there are pending screenshot requests.
BUG=599776
Review-Url: https://codereview.chromium.org/2044783002
Cr-Commit-Position: refs/heads/master@{#398245}
SELECT popup: Fix a crash by DOM mutation during opening popup.
A mutation callback can be called after MutationObserver is disconnected
because MutationRecords are queued.
BUG=617578
Review-Url: https://codereview.chromium.org/2040123002
Cr-Commit-Position: refs/heads/master@{#398244}
Add callbacks to ScriptCustomElementDefinition
This patch adds callbacks and observedAttributes to
ScriptCustomElementDefinition, as defined in the Element Definition
spec[1].
[1] https://html.spec.whatwg.org/multipage/scripting.html#element-definition
BUG=594918
TEST=imported/wpt/custom-elements/custom-elements-registry/define.html
Review-Url: https://codereview.chromium.org/2024073002
Cr-Commit-Position: refs/heads/master@{#398243}
mus: Initialize WindowManagerConnection in chrome instead of in content.
BUG=none
Review-Url: https://codereview.chromium.org/2027093002
Cr-Commit-Position: refs/heads/master@{#398242}
Skip two WebGL 2.0 conformance tests on Win Intel.
The following two tests are causing graphical corruption and other
strange behaviors:
WebglConformance.conformance2_textures_misc_copy_texture_image
WebglConformance.deqp_functional_gles3_texturespecification_teximage3d_depth_pbo
BUG=617449
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2048453003
Cr-Commit-Position: refs/heads/master@{#398241}
Correcting the usage of returning Size object
For returning Size params, we don't have to create a Rect
object. Instead returning Size value directly.
BUG=
Review-Url: https://codereview.chromium.org/2045443002
Cr-Commit-Position: refs/heads/master@{#398240}
Revert of Remove base/move.h (patchset #4 id:60001 of https://codereview.chromium.org/2038273002/ )
Reason for revert:
This breaks the Windows build on the waterfall.
The error log is:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/202064/steps/compile%20%28with%20patch%29/logs/stdio
FAILED: obj/ash/mus/lib/shelf_layout_impl.obj
ninja -t msvc -e environment.x86 -- E:\b\build\slave\cache\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ash/mus/lib/shelf_layout_impl.obj.rsp /c ../../ash/mus/shelf_layout_impl.cc /Foobj/ash/mus/lib/shelf_layout_impl.obj /Fd"obj/ash/mus/lib_cc.pdb"
e:\b\build\slave\win\build\src\base\template_util.h(65): error C2718: 'ui::LatencyInfo': actual parameter with requested alignment of 8 won't be aligned
e:\b\build\slave\win\build\src\base\template_util.h(86): note: see reference to class template instantiation 'base::internal::IsAssignableImpl<Lvalue,Rvalue,false>' being compiled
with
[
Lvalue=ui::LatencyInfo &,
Rvalue=ui::LatencyInfo &&
]
e:\b\build\slave\win\build\src\base\template_util.h(103): note: see reference to class template instantiation 'base::is_assignable<ui::LatencyInfo &,ui::LatencyInfo &&>' being compiled
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\lib\template_util.h(58): note: see reference to class template instantiation 'base::is_move_assignable<T>' being compiled
with
[
T=ui::LatencyInfo
]
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\array.h(34): note: see reference to class template instantiation 'mojo::internal::IsMoveOnlyType<MojomType>' being compiled
with
[
MojomType=ui::LatencyInfo
]
e:\b\build\slave\win\build\src\out\debug\gen\cc\ipc\compositor_frame_metadata.mojom.h(121): note: see reference to class template instantiation 'mojo::Array<ui::LatencyInfo>' being compiled
Original issue's description:
> Remove base/move.h
>
> It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.
>
> BUG=566182
>
> Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
> Cr-Commit-Position: refs/heads/master@{#398237}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=566182
Review-Url: https://codereview.chromium.org/2047633002
Cr-Commit-Position: refs/heads/master@{#398239}
Roll src/third_party/catapult/ 5ede943f9..c59289db8 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5ede943f9a5e..c59289db852f
$ git log 5ede943f9..c59289db8 --date=short --no-merges --format='%ad %ae %s'
BUG=617838
[email protected]
Review-Url: https://codereview.chromium.org/2042953002
Cr-Commit-Position: refs/heads/master@{#398238}
Remove base/move.h
It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.
BUG=566182
Review-Url: https://codereview.chromium.org/2038273002
Cr-Commit-Position: refs/heads/master@{#398237}
Check new display item list committed when destructing PaintController
BUG=616700
Review-Url: https://codereview.chromium.org/2038873002
Cr-Commit-Position: refs/heads/master@{#398236}
Resubmission of sashab's patch: Make CSSComputedStyledeclaration::getPropertyCSSValue return const
Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.
This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.
Original patch is here:
https://codereview.chromium.org/2034013002
BUG=526586
Review-Url: https://codereview.chromium.org/2046463003
Cr-Commit-Position: refs/heads/master@{#398235}
Strengthen GpuRasterizationConcavePathsPagetest test.
This test was passing when the entire 'pacman' image area was filled
with the 'interior' color. This change ensures that we test pixels on
the exterior and interior of the paths, within the pacman's bounds.
[email protected]
BUG=617805
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2042143002
Cr-Commit-Position: refs/heads/master@{#398234}
[PCv2] Reduce page_set repeat 3->2
This CL reduces number of page_set iterations in PCv2,
to make the test run fit <60min in slow bots such as "Nexus 5 Perf".
Before this CL, PCv2 ran a URL 6 times, where as PCv1 ran a URL 3 times.
Which made a single page_cycler_v2.typical25 run take >60min, which caused
timeout on the perf bots.
BUG=617004
[email protected]
Review-Url: https://codereview.chromium.org/2041253002
Cr-Commit-Position: refs/heads/master@{#398233}
arc: Send cryptohome ID on starting ARC instance.
We are soon moving android-data directory from the current
fixed path (/home/chronos/user/android-data) to a path inside
mounted cryptohome (/home/root/<CryptohomeID>/android-data).
To prepare for that change, we start sending cryptohome ID in
StartArcInstance() D-Bus method.
Since we do not use |socket_path| parameter at all in
session_manager today, we will reuse it to pass the cryptohome ID.
BUG=b:26700652
TEST=trybot
TEST=ARC boots
Review-Url: https://codereview.chromium.org/2023803003
Cr-Commit-Position: refs/heads/master@{#398232}
Added r396173 to .git-blame-ignore-revs.
Large mechanical rename change; should be ignored in git hyper-blame.
BUG=none
Review-Url: https://codereview.chromium.org/2015123002
Cr-Commit-Position: refs/heads/master@{#398231}
Upload textures through GPU path to non-8-bit color formats won't work in WebGL2
This is because we use copyTexImage to do the GPU to GPU copying, but in ES3
it is limited that source/destination color format component sizes have to match.
We can lift this limitation once we implement a different path where shaders are
used to do the copying instead of copyTexImage.
BUG=429053
TEST=gpu_bots
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2040773002
Cr-Commit-Position: refs/heads/master@{#398230}
service worker: Don't control a subframe of an insecure context
We must check isSecureContext when creating the network provider to
adhere to https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged.
We already did this for getRegistration(), register(), unregister() but must
also do this when deciding whether to control an in-scope document.
BUG=607543
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2009453002
Cr-Commit-Position: refs/heads/master@{#398229}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //dbus
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2037833003
Cr-Commit-Position: refs/heads/master@{#398228}
Manual rebaseline for crbug.com/591832
BUG=591832
Review URL: https://codereview.chromium.org/2048573002 .
Cr-Commit-Position: refs/heads/master@{#398227}
Fix black frames on segment boundaries in H/W decoded h.264 video on windows.
When we detect a segment boundary we reinitialize the decoder. Currently
on Windows that results in tearing down the decoder instance the
D3D9/D3D11 device objects, the output picture buffers etc.
We don't need to tear down the output picture buffers and the d3d device
objects. This fixes the black frame which shows up due to the picture
buffers getting destroyed and new ones getting created.
In any case if the resolution changes we do request new output buffers
anyways.
I tested the test case in bug 594266 which was the reason for the config
change code in the first place. That still works in D3d9 and D3D11.
BUG=616349
Review-Url: https://codereview.chromium.org/2040093002
Cr-Commit-Position: refs/heads/master@{#398226}
Remove asserts inserted to diagnose bug 537922
The assert is no longer hit in WebGL conformance tests.
It seems that the bug is already fixed.
BUG=537922
Review-Url: https://codereview.chromium.org/2024013002
Cr-Commit-Position: refs/heads/master@{#398225}
Remove use of deprecated MessageLoop methods in content.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2034663003
Cr-Commit-Position: refs/heads/master@{#398224}
Roll src/third_party/catapult/ 619acd2c5..5ede943f9 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/619acd2c51c4..5ede943f9a5e
$ git log 619acd2c5..5ede943f9 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2046873002
Cr-Commit-Position: refs/heads/master@{#398223}
Implement cc::CompositorFrameMetadata StructTraits
This CL replaces the simple mus CompositorFrameMetadata struct with a
full fidelity struct along with StructTraits. w00t! Soon full fidelity
CompositorFrames in Mus without extra copies!
BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2042643002
Cr-Commit-Position: refs/heads/master@{#398222}
Use ChannelMojo for the utility process.
BUG=604282,597124
Review-Url: https://codereview.chromium.org/1959313002
Cr-Commit-Position: refs/heads/master@{#398221}
Remove unused argument from WebContentsImpl::IsFullscreenForCurrentTab.
BUG=550497
Review-Url: https://codereview.chromium.org/2044743002
Cr-Commit-Position: refs/heads/master@{#398220}
Migrate WaitableEvent to enum-based constructor in ppapi/nacl_irt
Changes made manually because clang-tidy doesn't interact well with cross-compile.
BUG=612843
Review-Url: https://codereview.chromium.org/2043893002
Cr-Commit-Position: refs/heads/master@{#398219}
Limit the number of ARC codec
BUG=b/28157714
TEST=create too much ARC codecs and it should fail when reach limit
Review-Url: https://codereview.chromium.org/2036723002
Cr-Commit-Position: refs/heads/master@{#398218}
MD Settings: Responsive sub-page width
The width only needs to be set explicitly during animations, when the card
is position: fixed.
BUG=608134
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2041073002
Cr-Commit-Position: refs/heads/master@{#398217}
Removing unused SetBrowserContext
This method is no longer used, and should be removed.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2046713002
Cr-Commit-Position: refs/heads/master@{#398216}
Flip LKGR/ClusterFuzz, WebKit MSAN bots back to GYP.
There were a couple of build file issues that broke the ASAN Debug
bot and the MSAN bots on the lkgr waterfall. This CL fixes those issues,
and also flips the MSAN bots back to GYP since the main MSAN bots
are still kinda broken and it's easier to keep them all consistent.
[email protected]
BUG=605732
Review-Url: https://codereview.chromium.org/2048513002
Cr-Commit-Position: refs/heads/master@{#398215}
Updating trunk VERSION from 2761.0 to 2762.0
Cr-Commit-Position: refs/heads/master@{#398214}
Remove the use of OwnedPtrDeleter in WebMessagePortChannel.
It's hard to mechanically replace specializations of OwnedPtrDeleter<T>
to std::unique_ptr equivalents, so they are converted manually.
A new typedef WebMessagePortChannelUniquePtr is introduced so people can
always use std::unique_ptr with a correct deleter.
BUG=617504
Review-Url: https://codereview.chromium.org/2043583002
Cr-Commit-Position: refs/heads/master@{#398213}
Fix FTP directory listing page error by adding "language" key
Also shuffle some test code around so bugs like this can be more easily
noticed by bots.
[email protected]
BUG=615626
Review-Url: https://codereview.chromium.org/2032903004
Cr-Commit-Position: refs/heads/master@{#398212}
Implement LatencyInfo StructTraits
This CL implements LatencyInfo mojom types, and associated
StructTraits for serialization and deserialization. This will be used
by cc::CompositorFrameMetadata and ultimately cc::CompositorFrame
serialization/deserialization over mojo.
BUG=611802
Review-Url: https://codereview.chromium.org/2040733002
Cr-Commit-Position: refs/heads/master@{#398211}
Flip win_chromium_rel_ng back to GYP, re-add win8_chromium_ng to CQ.
This CL reverts r397982 ( https://codereview.chromium.org/2032613004 )
and also flips the main win CQ bots back to GYP. This will hopefully
get the cycle time and capacity issues for the CQ back under control.
[email protected], [email protected]
BUG=617837
Review-Url: https://codereview.chromium.org/2035413004
Cr-Commit-Position: refs/heads/master@{#398210}
CC Animation: Activate/deactivate ElementAnimations on Layer addition/removal.
This is a CC-side fix which can be useful for all CC clients.
Blink side: We will need to fix the race in CompositedLayerMapping destruction vs. CompositorAnimationPlayer detachment separately.
BUG=615471
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2042713002
Cr-Commit-Position: refs/heads/master@{#398209}
Roll src/third_party/catapult/ 2b7a13d86..619acd2c5 (4 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2b7a13d86594..619acd2c51c4
$ git log 2b7a13d86..619acd2c5 --date=short --no-merges --format='%ad %ae %s'
BUG=616832
[email protected]
Review-Url: https://codereview.chromium.org/2041203002
Cr-Commit-Position: refs/heads/master@{#398208}
[css] Don't let table parts be layout boundaries
This fixes another crash when table parts are set as containment roots.
<table> elements still don't honor layout containment when calculating
their dimensions, though.
BUG=616643
Review-Url: https://codereview.chromium.org/2046813002
Cr-Commit-Position: refs/heads/master@{#398207}
[tracing] Fix light dump of partition alloc dump provider
Partition Alloc dump provider dumps bucket stats for the case of
DirectMap objects even for ligth dumps. This CL fixes this issue.
BUG=613198
Review-Url: https://codereview.chromium.org/2045643002
Cr-Commit-Position: refs/heads/master@{#398206}
Update V8 to version 5.3.152.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ed4b5d5..a4540654
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2040103002
Cr-Commit-Position: refs/heads/master@{#398205}
cc: Add mailbox support to ResourceProvider write locks.
This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
ensures that the texture id for the mailbox is destroyed after use on
the worker context.
This CL also includes the following cleanup:
1. ResourceProvider locks don't keep resource pointers around.
2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
3. GpuRasterizer is folded back into GpuRasterBufferProvider.
4. TileTaskManager does not own RasterBufferProvider.
BUG=525259
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1951193002
Cr-Commit-Position: refs/heads/master@{#398204}
Adds blimp browser tests to run on Chromium.linux.
BUG=602407
Review-Url: https://codereview.chromium.org/2042873004
Cr-Commit-Position: refs/heads/master@{#398203}
Enable NonValidatingReloadOnRefreshContent v1/v2 for testing
To expand field trials, enable flags on waterfall for testing.
BUG=591245
Review-Url: https://codereview.chromium.org/2045463002
Cr-Commit-Position: refs/heads/master@{#398202}
mac: Delete some pre-OS X 10.9 code in blink
No intended behavior change.
BUG=579255
Review-Url: https://codereview.chromium.org/2043883002
Cr-Commit-Position: refs/heads/master@{#398201}
Rework how MB and GN handle concurrent links.
The Mac and iOS GN bots don't currently limit the number of concurrent
links. The official continuous win bots aren't on MB because they can't
limit the number of concurrent links through MB.
This CL adds a 'concurrent_links' arg to GN, which calls the
get_concurrent_links script to get the appropriate default value
(making this consistent across platforms), and also adds a hack
to MB to translate a gyp_link_concurrent "GYP_DEFINE" to the
GYP_LINK_CONCURRENCY env var.
The CL also adds a test for this MB hack and the similar, already existing
LLVM_FORCE_HEAD_REVISION hack.
[email protected], [email protected]
BUG=602480, 611491, 616390
Review-Url: https://codereview.chromium.org/2031233002
Cr-Commit-Position: refs/heads/master@{#398200}
Include <wchar.h> for mbstate_t.
mbstate_t is defined in <wchar.h>, which is often indirectly included
through <string>. However, that's not true for all implementations of
C++ standard library. This CL adds the missing inclusion of <wchar.h> in
base/strings/string16.h for the definition of mbstate_t.
BUG=None
Review-Url: https://codereview.chromium.org/2041633002
Cr-Commit-Position: refs/heads/master@{#398199}
Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness
There seems to be data cached by the OS which is not deleted by
DexLoader#deleteCachedDexes() which is causing the test to be flaky.
This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test
DexLoader#deleteCachedDexes() in a scenario which is closer to how the function
is used in production.
The test used to test that calling DexLoader#deleteCachedDexes() would make
DexLoader#load() load a dex file from scratch.
The CL changes the test to test that:
- DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local
data directory
- It is possible to use reuse a data directory to load several dexes
BUG=616923
Review-Url: https://codereview.chromium.org/2033953002
Cr-Commit-Position: refs/heads/master@{#398198}
[Android] Ensure perf test runner does not create shards for blacklisted devices.
BUG=617559
Review-Url: https://codereview.chromium.org/2039363002
Cr-Commit-Position: refs/heads/master@{#398197}
Plumb decoded video pixel format from GPU process to renderer.
This allows the renderer to correctly interpret NV12 and other pixel formats.
BUG=574292
Committed: https://crrev.com/1ace3b00d9dad163255b8e73deaad53c0a43a79a
Review-Url: https://codereview.chromium.org/1942123002
Cr-Original-Commit-Position: refs/heads/master@{#396634}
Cr-Commit-Position: refs/heads/master@{#398196}
Moving Windows Breakpad restart logic to lower layer.
Currently this logic needs to be copied and called every time
chrome::AttemptRestart() is called. Moving it within chrome::AttemptRestart()
allows it to be reused. Moreover, it seems that calling
chrome::AttemptRestart() without the said logic (there are such occurrences),
is not correct.
This is in preparation of reducing the number of "Restart" codepaths in MD
Settings.
BUG=617830
Review-Url: https://codereview.chromium.org/2033173002
Cr-Commit-Position: refs/heads/master@{#398195}
Make ExternalNavigationHandler#intentsHaveSameResolvers() faster
ExternalNavigationHandler#intentsHaveSameResolvers() will be called on each
WebAPK navigation. Removing the duplicate call to
PackageManager#queryIntentActivities() saves 2ms per navigation.
BUG=609122
TEST=None
Review-Url: https://codereview.chromium.org/2035203002
Cr-Commit-Position: refs/heads/master@{#398194}
Restore PaintLayerScrollableArea::ScrollbarManager::canDetach behavior.
This CL mistakenly disabled the 'detach' behavior for ScrollbarManager:
https://codereview.chromium.org/1930183002
... because it seemed like DelayScrollPositionClampScope would be sufficient
to preserve all the necessary state for scrollbars as they were added and
removed during the multiple layout passes of flex layout. However, that
was premature: even though the scroll positions were preserved, destroying
and recreating scrollbars during layout will invalidate the
ScrollingCoordinator's mapping from Scrollbar to WebScrollbarLayer.
One side effect is that if a scroll event handler forces layout to run during
a scrollbar drag, and the Scrollbar/WebScrollbarLayer association is broken,
then the compositor will think that the scrollbar drag has ended, even though
mouse-up has not yet happened.
This CL also sneaks in a tiny optimization: if auto scrollbars are frozen,
then childFlexBasSizeRequiresLayout should not return true due to the child
having auto scrollbars (since the scrollbars cannot change).
BUG=617498
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2042923002
Cr-Commit-Position: refs/heads/master@{#398193}
[Chromoting] Decouple DesktopView and TouchInputHandler
This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.
This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.
BUG=615277
Review-Url: https://codereview.chromium.org/2035303002
Cr-Commit-Position: refs/heads/master@{#398192}
exo: Implement Surface::SetSurfaceLayerContents
BUG=610086
Review-Url: https://codereview.chromium.org/2046493005
Cr-Commit-Position: refs/heads/master@{#398191}
Implement iterable<DOMString, (StyleValue or sequence<StyleValue>)> for InlineStylePropertyMap
Spec: https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap
BUG=545318
Review-Url: https://codereview.chromium.org/1874623002
Cr-Commit-Position: refs/heads/master@{#398190}
Fix web_accesible_resources enforcement for Site Isolation.
When --isolate-extensions or --site-per-process modes are enabled, all
extensions frames run in extension processes and are not mixed in regular
web renderers. This causes a problem with security checks for
web_accessible_resources, which allow all navigations to extension pages
when they are performed in extension process. This is no longer true and
this patch addresses this by using a NavigationThrottle to perform the
proper checks on the UI thread (also PlzNavigate compatible).
BUG=616488
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2042483002
Cr-Commit-Position: refs/heads/master@{#398189}
Update MB config with missing builder entries, etc.
It had been a while since I'd run `mb audit` and there were
a few new builders that didn't have entries. This adds those,
removes some builders that are gone, and fixes some typos.
[email protected]
BUG=605732
Review-Url: https://codereview.chromium.org/2047583002
Cr-Commit-Position: refs/heads/master@{#398188}
Correct frame timestamps in VTVideoEncodeAccelerator
This CL corrects the timestamp sent with the encoded frame data from
VTVideoEncodeAccelerator. Recently, this functionality is added to the
VEA interface and we can use the frame's original capture timestamp.
BUG=350106
TEST=AppRTC loopback in Macbook Air.
Review-Url: https://codereview.chromium.org/2039423002
Cr-Commit-Position: refs/heads/master@{#398187}
Multi-Process Find-in-Page.
This patch completes the implementation of multi-process find-in-page, as described in the design doc: https://docs.google.com/document/d/12S_6X2MWWLoyJslajcajL2ELU7zhodPxMOxa8Bg4Wg0/view
BUG=457440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1959183002
Cr-Commit-Position: refs/heads/master@{#398186}
Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id:100001 of https://codereview.chromium.org/2028873002/ )
Reason for revert:
Speculative revert of this CL to check if it is the root cause of https://crbug.com/616989.
Original issue's description:
> Fix event page process cleanup when running in --isolate-extensions mode.
>
> With --isolate-extensions, navigations can start in one RenderFrameHost
> and complete in another. This was not possible to happen with extensions
> related RenderFrameHosts in the past, so the code wasn't able to handle
> it. This CL refactors the OnNetworkRequest(Started|Stopped) to use the
> navigation request id as the stable identifier instead of the associated
> RenderFrameHost.
>
> BUG=612668
>
> Committed: https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8
> Cr-Commit-Position: refs/heads/master@{#397328}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=612668
Review-Url: https://codereview.chromium.org/2044643003
Cr-Commit-Position: refs/heads/master@{#398185}
Previous code change 2018643002 (for user menu redesign) modified code on the spot and did not put the changes behind any flag. This CL is to:
1. add flags for the previous code change;
2. add back some of the deleted resources as they will still be used when the flag is not turned on.
BUG=615893
Review-Url: https://codereview.chromium.org/2034093003
Cr-Commit-Position: refs/heads/master@{#398184}
Rename BookmarkActivityBase -> SynchronousInitializationActivity
Needed for downloads UI.
BUG=616324
Review-Url: https://codereview.chromium.org/2039413003
Cr-Commit-Position: refs/heads/master@{#398183}
Create EarlGrey wait utility.
EarlGrey typically handles synchronization with the UI, but it is
useful when manipulating non-UI APIs to be able to wait for a certain
state.
BUG=610837
Review-Url: https://codereview.chromium.org/2044433003
Cr-Commit-Position: refs/heads/master@{#398182}
Remove obsolete friend declarations for MSVC.
These friend declarations were added because MSVC had a bug around the
visibility of nested classes. They are no longer necessary.
BUG=617504
Review-Url: https://codereview.chromium.org/2043633002
Cr-Commit-Position: refs/heads/master@{#398181}
Remove embedder param for SetNotificationSettingForOrigin
Notifications content settings don't consider the embedding origin
when updating the content setting values. Remove unused embedder
param in SetNotificationSettingForOrigin.
Review-Url: https://codereview.chromium.org/2035323002
Cr-Commit-Position: refs/heads/master@{#398180}
exo: Allow updating cc::Surface viewport and crop state independently.
This was added for the texture-layer code but not the surface layer. If
the viewport is changed but a new buffer isn't attached then the old
resource information will be re-sent with the new Surface. The
SurfaceFactory will handle refcounting uses of the buffer.
Review-Url: https://codereview.chromium.org/2032173002
Cr-Commit-Position: refs/heads/master@{#398179}
mash: Move shelf model and item classes to ash/common/shelf
ShelfModel, ShelfItemDelegate and ShelfItemDelegate have no dependencies on
ash::Shell, ash::RootWindowController or aura::Window so they can be moved
as-is.
No functional changes.
BUG=615155
TEST=compiles
Review-Url: https://codereview.chromium.org/2046513003
Cr-Commit-Position: refs/heads/master@{#398178}
Add clang_tot config to 'CFI Linux ToT' bot.
Otherwise, GN does not get that it's a ToT build and the build dir
is not clobbered.
BUG=617771
Review-Url: https://codereview.chromium.org/2039103003
Cr-Commit-Position: refs/heads/master@{#398177}
Replace tab switcher borders with single asset
This change replaces the two tab switcher borders that existed
(standard and incognito) with a single white one that can be tinted
to any color it needs to be.
BUG=606612
Review-Url: https://codereview.chromium.org/2045733002
Cr-Commit-Position: refs/heads/master@{#398176}
Update V8 to version 5.3.150.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f8c7729d..7ed4b5d5
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2044713002
Cr-Commit-Position: refs/heads/master@{#398175}
Only Register() platform specific content settings types on different platforms
Content settings are not used on all platforms. Some content settings are only
used on desktop platforms, or desktop and android. We shouldn't register these
types on other platforms that aren't using them, so that we don't create unused
prefs for them and more importantly so that we don't sync settings to these
platforms which would go unused but be a potential privacy concern.
In this CL, an enum WebsiteSettingsInfo::Platform is added and used when
registering content settings to indicate which platform set it is applied to.
BUG=604632
Review-Url: https://codereview.chromium.org/1991623005
Cr-Commit-Position: refs/heads/master@{#398174}
Don't keep a separate m_revalidatingRequest on Resource
Have Resource::setRevalidatingRequest() just overwrite
m_resourceRequest, and keep an m_isRevalidating bit to track
whether a revalidation is progress.
Ideally we'd get to a point where the m_isRevalidating bit
isn't needed, or at least doesn't need to be accessible
outside of Resource and its subclasses.
BUG=
Review-Url: https://codereview.chromium.org/1997833002
Cr-Commit-Position: refs/heads/master@{#398173}
Adds jamescook to ash/OWNERS
[email protected]
[email protected]
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2040803006
Cr-Commit-Position: refs/heads/master@{#398172}
Roll WebGL ba8c5aa..f43726c
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/ba8c5aa..f43726c
BUG=
TEST=bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2043913002
Cr-Commit-Position: refs/heads/master@{#398171}
exo: Keep order of functions in .h and .cc files consistent.
No change in logic.
BUG=549781
[email protected]
Review-Url: https://codereview.chromium.org/2048453002
Cr-Commit-Position: refs/heads/master@{#398170}
Removing WinXP and Vista specific code from Chromoting.
Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.
BUG=607676
Review-Url: https://codereview.chromium.org/2037163002
Cr-Commit-Position: refs/heads/master@{#398169}
Allow about:blank to be considered in-page if origin matches.
This is necessary in cases that document.write changes the effective
URL of the about:blank page, and then the user goes back.
BUG=446959
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2032903007
Cr-Commit-Position: refs/heads/master@{#398168}
[UI Views] Unset the extension keybinding registry on frame destruction
Some destruction flows don't seem to call OnWidgetActivationChanged
before destroying the window, which causes the extension keybinding
registry reference in the global registry to become stale. Update the
active registry on deletion.
BUG=616970
Review-Url: https://codereview.chromium.org/2046653002
Cr-Commit-Position: refs/heads/master@{#398167}
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.
cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.
Review-Url: https://codereview.chromium.org/2040473002
Cr-Commit-Position: refs/heads/master@{#398166}
Typed CSSOM: Rename Matrix to CSSMatrix and MatrixTransformComponent to CSSMatrixTransformComponent.
I didn't rename MatrixTranformComponent to CSSMatrix because WebKitCSSMatrix is implemented as CSSMatrix.
Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#cssmatrix
Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159
BUG=610173
Review-Url: https://codereview.chromium.org/2038453002
Cr-Commit-Position: refs/heads/master@{#398165}
Roll src/third_party/skia/ dc27a648d..ee295645b (2 commits).
https://chromium.googlesource.com/skia.git/+log/dc27a648d2ff..ee295645bd91
$ git log dc27a648d..ee295645b --date=short --no-merges --format='%ad %ae %s'
2016-06-06 bsalomon Make GrShape track the winding direction and starting point for rrect types. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042813002
2016-06-06 brianosman Add new SkSourceGammaTreatment enum, used in situations like mipmap construction, where we need to know if we should respect (vs. ignore) the gamma encoding of sRGB tagged images. Plumb that extensively.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2047533003
Cr-Commit-Position: refs/heads/master@{#398164}
[Chromecast] Buildfix in Android PR codepath
Another mistake in https://codereview.chromium.org/2032923002/
|persistent_license_support_| was unused on Android. Rather than
adding more ifdefs, just check that the caller isn't setting this
to true on Android.
BUG=
Review-Url: https://codereview.chromium.org/2043763002
Cr-Commit-Position: refs/heads/master@{#398163}
Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF types.
BUG=583738
Review-Url: https://codereview.chromium.org/2038413003
Cr-Commit-Position: refs/heads/master@{#398162}
[iOS/GN] Allow overriding parameters of "ios_app_bundle" in "test" template.
Allow the caller of the "test" template from //testing/test.gni to override
some of the parameters or to provide additional values. This is required by
downstream iOS tests.
BUG=603100
Review-Url: https://codereview.chromium.org/2043843003
Cr-Commit-Position: refs/heads/master@{#398161}
Add a histogram for tracking the response codes and error codes when trying the fetch hash-prefix updates from the Pver4 SafeBrowsing service.
BUG=543161, 616603
Review-Url: https://codereview.chromium.org/2029753002
Cr-Commit-Position: refs/heads/master@{#398160}
Use ContextUtils#getApplicationContext() instead of passing Context to ShortcutHelper
BUG=609122
Review-Url: https://codereview.chromium.org/2038983002
Cr-Commit-Position: refs/heads/master@{#398159}
aw: Disable full screen tests on M
Look to just be super flaky. Failure on different test each time.
BUG=615483
Review-Url: https://codereview.chromium.org/2046773002
Cr-Commit-Position: refs/heads/master@{#398158}
Removed ctrl-shift-p from the keyboard
shortcut overlay.
BUG=608315
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1977183002
Cr-Commit-Position: refs/heads/master@{#398157}
Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const (patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )
Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15: error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue of type 'const blink::CSSValue *'
CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20TSan%20Builder/builds/23734/steps/compile/logs/stdio
Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
>
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
>
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
>
> BUG=526586
>
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586
Review-Url: https://codereview.chromium.org/2042113002
Cr-Commit-Position: refs/heads/master@{#398156}
Add user agent to System Context Getter as suggested by metrics team.
Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.
Setting this value will allow for processing and display of metrics
for Blimp.
BUG=592757
Review-Url: https://codereview.chromium.org/2041933002
Cr-Commit-Position: refs/heads/master@{#398155}
Remove use of deprecated MessageLoop methods in rlz.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2033863003
Cr-Commit-Position: refs/heads/master@{#398154}
Use /LTCG:Incremental to speed up the non-clobber official builds.
/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.
Review-Url: https://codereview.chromium.org/2045683002
Cr-Commit-Position: refs/heads/master@{#398153}
Refactor ResizingHostObserver tests
Remove a couple of possible sources of dangling pointers and make the
tests cleaner and more compact.
Review-Url: https://codereview.chromium.org/2038183002
Cr-Commit-Position: refs/heads/master@{#398152}
Make CSSComputedStyledeclaration::getPropertyCSSValue return const
Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.
This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.
BUG=526586
Review-Url: https://codereview.chromium.org/2034013002
Cr-Commit-Position: refs/heads/master@{#398151}
[MD settings] google-grey to paper-grey
This CL replaces some uses of the non-existent
--google-grey-600 with --paper-grey-600
BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2010283003
Cr-Commit-Position: refs/heads/master@{#398150}
Remove use of deprecated MessageLoop methods in blimp.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2034703003
Cr-Commit-Position: refs/heads/master@{#398149}
Switch CrWinClang to gn again.
This relands parts of https://codereview.chromium.org/1947183004/
Now that clobber runs as a separate step before runhooks, swarming should work
on gn clobber bots.
BUG=498033
Review-Url: https://codereview.chromium.org/2043743003
Cr-Commit-Position: refs/heads/master@{#398148}
Prevent synchronous image change notifications during paint
Image changed notifications are used by animated images to notify
LayoutObject clients that they need to repaint. These notifications
typically result in paint invalidations. Animated bitmap images have
some logic[1] to handle "falling behind" which would synchronously
fire image changed notifications during paint. This results in missed
paint invalidations as well as a changing layout tree out from under
the paint system.
This patch moves the synchronous image change notifications to an
immediate task which occurs after paint has completed.
[1] When painting animated gifs on a heavily loaded system (or a debug
build), pauses in the system can cause the animation to get behind.
When this happens, we want to advance the animation and catch-up but
prevent the next frame from using the same catch-up logic which could
get us in an infinite catch-up loop.
BUG=616700
Review-Url: https://codereview.chromium.org/2038243002
Cr-Commit-Position: refs/heads/master@{#398147}
Flip Win bots on tryserver.chromium.perf to GN.
[email protected]
BUG=605318
Review-Url: https://codereview.chromium.org/2045693003
Cr-Commit-Position: refs/heads/master@{#398146}
[Android] Ensure test names are unique during retry determination.
BUG=604568
Review-Url: https://codereview.chromium.org/2032253004
Cr-Commit-Position: refs/heads/master@{#398145}
Revert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #12 id:220001 of https://codereview.chromium.org/2005013002/ )
Reason for revert:
Causes blank tabs, tab switching perf tests
BUG=617497,617427
Original issue's description:
> mac: ensure ui::Compositor exists for visible RWHVs
>
> RenderWidgetHostViewMac is careful about creating ui::Compositor and so
> currently only does this in Show and SwapCompositorFrame. However, if
> it the RenderWidgetHostView is created while the RenderWidgetHost is
> visible, then Show will early out and never create a ui::Compositor.
>
> This causes problems with begin frame scheduling, which wants to have
> the Display (which is created as part of creating the ui::Compositor's
> output surface currently) own the real begin frame source that drives
> everything. In that world, if no ui::Compositor exists, no frames ever
> are sent or swapped. So, the ui::Compositor needs to be created first.
>
> Also, if the ui::Compositor is correctly created during Show (or the
> constructor), then there's no need to ensure that it exists during
> swap compositor frame, and so that can be safely removed.
>
> [email protected],[email protected]
>
> Committed: https://crrev.com/9af6c23da7070f9423d5cf25856ed27f7d5d8e5e
> Cr-Commit-Position: refs/heads/master@{#397755}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review-Url: https://codereview.chromium.org/2040013002
Cr-Commit-Position: refs/heads/master@{#398144}
telemetry, mac: Add more simple scrolling power tests.
These tests measure the no-gpu and disable-mac-overlays cases.
BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2034123002
Cr-Commit-Position: refs/heads/master@{#398143}
Script to inline shader into C header file
OpenGL compiles shader code as text at runtime. It is inconvienent to
edit shader code as const char[] inside the C++ source code.
This CL contains script that reads file contents, turns them into const
char[], and combine them into a header file.
BUG=385924
Review-Url: https://codereview.chromium.org/2036023003
Cr-Commit-Position: refs/heads/master@{#398142}
Changed two icons for desktop user menu on Linux/Windows:
1. Changed the icon for the "Manage people" button;
2. Changed the icon for sync error on the titlebar.
See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz
This CL is dependent on https://codereview.chromium.org/2028473002/
BUG=615893
Review-Url: https://codereview.chromium.org/2019053002
Cr-Commit-Position: refs/heads/master@{#398141}
Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1 id:1 of https://codereview.chromium.org/2037853002/ )
Reason for revert:
MessageLoopForIO::current() has a DCHECK but ThreadTaskRunnerHandle::Get() doesn't. See discussion https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Wj_cNO2l2qE
Original issue's description:
> Remove use of deprecated MessageLoop methods in ipc.
>
> MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
> are deprecated. This CL makes the following replacements to
> remove some uses of these methods:
>
> "MessageLoop(ForUI|ForIO)::current()->PostTask" ->
> "ThreadTaskRunnerHandle::Get()->PostTask"
> "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
> "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
> "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
> "ThreadTaskRunnerHandle::Get()->DeleteSoon"
> "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
> "ThreadTaskRunnerHandle::Get()->ReleaseSoon"
>
> In files where these replacements are made, it adds these includes:
> #include "base/location.h"
> #include "base/single_thread_task_runner.h"
> #include "base/threading/thread_task_runner_handle.h"
>
> And removes this include if it is no longer required:
> #include "base/message_loop/message_loop.h"
>
> Why ThreadTaskRunnerHandle::Get() instead of
> MessageLoop::current()->task_runner()?
> - The two are equivalent on threads that run a MessageLoop.
> - MessageLoop::current() doesn't work in base/task_scheduler
> because the scheduler's thread don't run MessageLoops.
> This CL will therefore facilitate the migration of browser
> threads to base/task_scheduler.
>
> Steps to generate this patch:
> 1. Run message_loop_cleanup.py (see code on the bug).
> 2. Run tools/sort-headers.py on modified files.
> 3. Run git cl format.
>
> BUG=616447
> [email protected]
>
> Committed: https://crrev.com/2eb9714a01e03a8b091a8ea34f023e24f62e5a9f
> Cr-Commit-Position: refs/heads/master@{#398040}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616447
Review-Url: https://codereview.chromium.org/2038363004
Cr-Commit-Position: refs/heads/master@{#398140}
Roll src/third_party/catapult/ 8f31b02e7..2b7a13d86 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8f31b02e7cdf..2b7a13d86594
$ git log 8f31b02e7..2b7a13d86 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2044663002
Cr-Commit-Position: refs/heads/master@{#398139}
[Android] Revert the NDK back to r10e.
BUG=599327
Review-Url: https://codereview.chromium.org/2040043002
Cr-Commit-Position: refs/heads/master@{#398138}
Revert of Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata (patchset #3 id:300001 of https://codereview.chromium.org/2018663002/ )
Reason for revert:
Breaking quota-related tests in content_browsertests
https://crbug.com/617213
Original issue's description:
> Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root
>
> Reason for reland:
> Updated webview tests that broke (WebViewLayoutTest.java)
>
> And use delete_device_stale=True when pushing. This will prevent tests
> mistakenly passing when they depend on stale data files from a previous test.
>
> [email protected],[email protected],[email protected]
> BUG=607169
>
> Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6
> Cr-Commit-Position: refs/heads/master@{#396479}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=607169,617213,616155
Review-Url: https://codereview.chromium.org/2044523003
Cr-Commit-Position: refs/heads/master@{#398137}
Remove WebFontsIntervention flag from fieldtrial testing config
The feature was already shipped, and there is no relevant trial
on trunk source code.
Note: This configuration looks wrong. Since the study used FeatureList
API, it should have an enable_features field to enable it correctly.
BUG=n/a
Review-Url: https://codereview.chromium.org/2046463002
Cr-Commit-Position: refs/heads/master@{#398136}
Update V8 to version 5.3.145.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6aed5443..f8c7729d
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2039963002
Cr-Commit-Position: refs/heads/master@{#398135}
Check stack pointer to be inside stack when unwinding.
TraceStackFramePointers() function, which unwinds stack using frame pointers,
sometimes crashes on Android when it dives deep into JVM internals and finds
bad stack pointer there. See details here: crbug.com/602701#c18
This CL adds checks to make sure only valid stack pointers are dereferenced.
BUG=602701
Review-Url: https://codereview.chromium.org/1975393002
Cr-Commit-Position: refs/heads/master@{#398134}
Add dialog to edit and save credit cards.
Tests included for dialog.
Screenshots in bug.
BUG=607348
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2015463003
Cr-Commit-Position: refs/heads/master@{#398133}
Use WeakPtrFactory in net::BidirectionalStream when posting task
This CL uses WeakPtrFactory to post task in
net::BidirectionalStream.
BUG=606394
Review-Url: https://codereview.chromium.org/2043863002
Cr-Commit-Position: refs/heads/master@{#398132}
Remove unused iOS assembly
[email protected]
Review-Url: https://codereview.chromium.org/2047483002
Cr-Commit-Position: refs/heads/master@{#398131}
Use mus::MojoGpuMemoryBufferManager in mus::GpuService.
BUG=586390
Review-Url: https://codereview.chromium.org/2020293003
Cr-Commit-Position: refs/heads/master@{#398130}
skia/ext: do not assume Skia's headers include windows.h
Review-Url: https://codereview.chromium.org/2041113002
Cr-Commit-Position: refs/heads/master@{#398129}
Log First User Interaction in Page Load Metrics
Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit
BUG=612422
Review-Url: https://codereview.chromium.org/1984173002
Cr-Commit-Position: refs/heads/master@{#398128}
Roll src/third_party/skia/ 09f5cd44a..dc27a648d (4 commits).
https://chromium.googlesource.com/skia.git/+log/09f5cd44ae30..dc27a648d2ff
$ git log 09f5cd44a..dc27a648d --date=short --no-merges --format='%ad %ae %s'
2016-06-06 msarett Add SkDefaultXform as a catch-all to handle color conversions
2016-06-06 scroggo Use Options object passed to startScanlineDecode
2016-06-06 scroggo Revert of Make SkPngCodec decode progressively. (patchset #26 id:520001 of https://codereview.chromium.org/1997703003/ )
2016-06-06 msarett Gamma sanity checks
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2043873002
Cr-Commit-Position: refs/heads/master@{#398127}
cc: Use FilterOperations::MapRect in RenderSurfaceImpl::DrawableContentRect.
GetOutsets provided imprecise -- or possibly incorrect -- outsets for certain
reference filters, such as <feOffset>. Instead RenderSurfaceImpl should
explicitly specify that it wants forward mapping here.
Also fix this to incorporate scale factors in the filter rect calculations
(e.g. due to a high DPI display), and add unit tests.
BUG=600821
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2018983003
Cr-Commit-Position: refs/heads/master@{#398126}
Drop unnecessary override of OnWindowBoundsChanged in NativeWidgetMus::MusWindowObserver
[email protected]
BUG=617315
Review-Url: https://codereview.chromium.org/2040783002
Cr-Commit-Position: refs/heads/master@{#398125}
Remove unnecessary posted task in cast_transport.cc.
The original author can't remember why this post was necessary. Since
the actual result callback is posted immediately afterwards any
side-effects (such as synchronizing with another message loop) should
already be achieved.
Review-Url: https://codereview.chromium.org/2044603002
Cr-Commit-Position: refs/heads/master@{#398124}
Remove use of deprecated MessageLoop methods in device.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2031743005
Cr-Commit-Position: refs/heads/master@{#398123}
Show/Hide the Arc App windows and corresponding shelf items when switching between desktops.
BUG=b/27776147
Review-Url: https://codereview.chromium.org/2033373003
Cr-Commit-Position: refs/heads/master@{#398122}
Try to tolerate running on contexts with SIGPIPE enabled.
Although Chromium wisely disables this ancient UNIX bug, the net stack is part
of Cronet which may be used in other consumers. Rather than modify the global
signal dispositions (bad manners for a library) or propagate this requirement
to the callers (also bad manners, if sound), make an attempt to suppress the
signal on a per-socket basis.
Unfortunately, iOS/OSX and Linux kindly have different APIs for this, so we
need to touch two places.
BUG=467132
Review-Url: https://codereview.chromium.org/2034433002
Cr-Commit-Position: refs/heads/master@{#398121}
Set User-Agent and Accept-Language request headers for PWS requests
The HTTP request headers normally used by Chrome for Android are
generated in the native layer. We do not want to load native when the
Physical Web is resolving URLs in the background, so we cannot access
these values directly. Instead, they are reconstructed from values
accessible from the Java layer.
BUG=607660
Review-Url: https://codereview.chromium.org/1989963003
Cr-Commit-Position: refs/heads/master@{#398120}
Do not cancel precache periodic GCM task if current network is non-WiFi
Only the network prediction enabled preference should be used to
schedule or cancel periodic GCM task. The GCM task itself will run only
when suitable for precaching.
BUG=616956
Review-Url: https://codereview.chromium.org/2037913002
Cr-Commit-Position: refs/heads/master@{#398119}
Integrate new MD update menu icons. Initial cut.
BUG=584342
Review-Url: https://codereview.chromium.org/1966643002
Cr-Commit-Position: refs/heads/master@{#398118}
Reland: ImageCapture: move mojom from WebKit/public to media/
Reverted after its own LayoutTests timed out in WebKit Win7 bot.
This is due to media/mojo/interfaces not being in the generated
bindings path, and that's being addressed in
https://codereview.chromium.org/2045573002/.
Original landed as https://crrev.com/2027023002
Original description ---------------------------------------------------
ImageCapture: move mojom from WebKit/public to media/
This CL moves image_capture.mojom from
{third_party/WebKit/public/platform/modules => media/mojo/interfaces}
so the generated data types (e.g. PhotoCapabilities{Ptr})
can be used from both Blink and media/capture locations.
Also capture.gypi is trivially relocated to capture/ folder.
Note that gyp files are -yay!- close to being finally
removed.
BUG=518807
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
[email protected], [email protected], [email protected], [email protected], [email protected] (no code changes).
Review-Url: https://codereview.chromium.org/2040963004
Cr-Commit-Position: refs/heads/master@{#398117}
Modifications for recording whether UMA/Crash default state for iOS.
BUG=612828
Review-Url: https://codereview.chromium.org/2014463003
Cr-Commit-Position: refs/heads/master@{#398116}
Record start up latency of DOM distiller viewer
BUG=617701
Review-Url: https://codereview.chromium.org/2011213002
Cr-Commit-Position: refs/heads/master@{#398115}
Remove unused forward decls from render_frame.h
RenderFrame no longer knows about WebElement or WebNode, yay!
R=esprehn
BUG=
Review-Url: https://codereview.chromium.org/2002683002
Cr-Commit-Position: refs/heads/master@{#398114}
Bump timeout for chrome_public_test_apk.
BUG=589168
Review-Url: https://codereview.chromium.org/2041973002
Cr-Commit-Position: refs/heads/master@{#398113}
Shard content_browser to avoid MSVS 2 GB limitation.
A change to enable WPO for the x64 Win official builds caused
content_browserto expand beyond 2 GB which caused these errors:
obj\content\content_browser.lib : fatal error LNK1107: invalid or
corrupt file: cannot read at 0xEAE7739
msvs_shard is a way of breaking up a library to avoid this limitation.
This issue doesn't affect the GN builds (because they use a sourceset
concept instead of these huge static libraries).
[email protected]
BUG=616946
Review-Url: https://codereview.chromium.org/2046573003
Cr-Commit-Position: refs/heads/master@{#398112}
mac: Simplify sdk_forward_declarations.h
MAC_OS_X_VERSION_MIN_REQUIRED corresponds to -mmacosx-version-min, which
we currently set to 10.7 (and plan to set to 10.9 eventually, after fixing
deprecation warnings).
MAC_OS_X_VERSION_MAX_ALLOWED corresponds to the SDK used to compile
chrome. We currently require the 10.10 SDK.
Remove all code in sdk_forward_declarations that's no longer necessary.
No behavior change.
BUG=579255
Review-Url: https://codereview.chromium.org/2046693002
Cr-Commit-Position: refs/heads/master@{#398111}
[spv2] Account for flipped writing modes in paint offset
Flipped writing modes cause an object's offset to be flipped relative
to its parent. This patch switches from using locationOffset to
topLeftLocation which includes writing mode handling. This matches
similar logic in PaintLayer::updateLayerPosition. A comment has been
added about removing unnecessary craws back up the tree for calculating
containing blocks.
With this patch, all fast/block/positioning tests pass, modulo our lack
of multicolumn fragment painting.
BUG=614257
Review-Url: https://codereview.chromium.org/2031873005
Cr-Commit-Position: refs/heads/master@{#398110}
DNS: Expose stale results through HostResolverImpl.
Once the HostCache exposes stale results, plumb them through the
HostResolverImpl for callers who want them.
BUG=605138
Review-Url: https://codereview.chromium.org/1903263002
Cr-Commit-Position: refs/heads/master@{#398109}
Remove use of deprecated MessageLoop methods in mojo.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2029413004
Cr-Commit-Position: refs/heads/master@{#398108}
StructTraits to map mus::mojom::Event to unique_ptr<ui::Event>.
This CL defines StructTraits<mus::mojom::Event, unique_ptr<ui::Event>>. With
this mojo automatically uses unique_ptr<ui::Event> instead of mus::mojom::Event
when generating C++ header files for mojom interfaces, and events are
automatically serializied/deserialized and validated when sending/receiving over
mojo IPC.
BUG=578206
Review-Url: https://codereview.chromium.org/1939133002
Cr-Commit-Position: refs/heads/master@{#398107}
Add suppressions for Dr. Memory failures.
BUG=617740
[email protected],[email protected]
Review URL: https://codereview.chromium.org/2040963006 .
Cr-Commit-Position: refs/heads/master@{#398106}
mash: Move WmShelfAura ownership to RootWindowController and init it earlier
This will allow it to be used in status tray initialization code. In particular:
* It can wrap actions handled by ShelfWidget and ShelfLayoutManager
(e.g. GetAutoHideState)
* It can have observers similar to ShelfLayoutManagerObserver
(OnAutoHideStateChanged)
It's also more similar to how ash::mus::RootWindowController owns WmShelfMus.
BUG=615155
TEST=ash_unittests
Review-Url: https://codereview.chromium.org/2041583004
Cr-Commit-Position: refs/heads/master@{#398105}
[DevTools] Added missing inputs for protocol_version action
[email protected]
Review-Url: https://codereview.chromium.org/2044563002
Cr-Commit-Position: refs/heads/master@{#398104}
Enable a few shader related webgl2 deqp tests.
BUG=
TEST=gpu bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2044593002
Cr-Commit-Position: refs/heads/master@{#398103}
Support underline on Linux again.
BUG=617055
https://codereview.chromium.org/1819753003/ accidentally removed
UNDERLINE style support on Linux. This CL fixes the issue.
Review-Url: https://codereview.chromium.org/2031223003
Cr-Commit-Position: refs/heads/master@{#398102}
Disable flaky tests under Dr. Memory.
VibrationTest.CancelVibrationFromMainFrameWhenMainFrameIsReloaded
BUG=617727
[email protected]
Review URL: https://codereview.chromium.org/2047503002 .
Cr-Commit-Position: refs/heads/master@{#398101}
cc : Add layer_list to LayerTreeImpl and build it for tests
Right now, we do a layer tree walk for iteration over all
layers on impl-side (LayerListIterator). Once we start
pushing layer list instead of layer tree during
commit/activation, we will use layer_list instead(layers
will be added to layer_list in stacking order during
commit/activation). A lot of tests build layer
tree on the impl-side and don't go through
commit/activation. So, we need to explicitly build the
layer_list for these tests.
BUG=617366
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2032303004
Cr-Commit-Position: refs/heads/master@{#398100}
Remove use of deprecated MessageLoop methods in gpu.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2035943002
Cr-Commit-Position: refs/heads/master@{#398099}
Rename NetworkChangeNotifierAutoDetect.Observer.updateActiveNetworkList
Rename it to purgeActiveNetworkList which better reflects its actual
function. It only purges the list of inactive networks, and does
not add to the list.
R=xunjieli
Review-Url: https://codereview.chromium.org/1967373003
Cr-Commit-Position: refs/heads/master@{#398098}
Surface sync error icon if sync is off may be unintentional
This CL is a strength of https://codereview.chromium.org/1952853005/.
BUG=607695
Review-Url: https://codereview.chromium.org/2032043002
Cr-Commit-Position: refs/heads/master@{#398097}
Revert of Re-enable WebGL Image Chromium. (patchset #3 id:40001 of https://codereview.chromium.org/2025973002/ )
Reason for revert:
I'm observing a behavior difference between the Image CHROMIUM and non-Image CHROMIUM path. Turning off Image CHROMIUM while I investigate.
https://bugs.chromium.org/p/chromium/issues/detail?id=617249#c5
Original issue's description:
> Re-enable WebGL Image Chromium.
>
> This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM,
> and turns on IOSurface backed WebGL by default.
>
> BUG=581777
>
> Committed: https://crrev.com/801f15833c140f120a2f5baed88645cb0619ab86
> Cr-Commit-Position: refs/heads/master@{#397603}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=581777
Review-Url: https://codereview.chromium.org/2041053002
Cr-Commit-Position: refs/heads/master@{#398096}
[SPv2] Paint invalidation in PreWalkTreeWalk, plumbed on PaintInvalidationState
It's temporarily plumbed on PaintInvalidationState to let it work for spv2.
Will gradually switch to new code, using the paint property data collected
by PaintPropertyTreeBuilder.
Enable SlimmingPaintInvalidation by default when spv2 is enabled.
BUG=510908
Review-Url: https://codereview.chromium.org/2033183002
Cr-Commit-Position: refs/heads/master@{#398095}
Split RenderViewContextMenu code into functions
This should be a behavior no-op. The nontrivial "is enabled" and "execute"
commands are now split into helper functions using a consistent style. This
helps make the multi-hundred-line-long switch statements more manageable.
Review-Url: https://codereview.chromium.org/2035033003
Cr-Commit-Position: refs/heads/master@{#398094}
Ignore exceptions from MediaDrmBridge.closeSession()
It seems some implementations thow an undocumented exception
from MediaDrm.closeSession(). This CL catches and ignores all
of them.
BUG=611865
Review-Url: https://codereview.chromium.org/2038193003
Cr-Commit-Position: refs/heads/master@{#398093}
net::WindowedFilterTest: Add explicit overflow checks
Aggressive inlining causes -Wstrict-overflow to be triggered.
BUG=616957
BUG=internal b/29059135
Review-Url: https://codereview.chromium.org/2036613002
Cr-Commit-Position: refs/heads/master@{#398092}
Support link hovering.
[email protected]
Review-Url: https://codereview.chromium.org/2038143003
Cr-Commit-Position: refs/heads/master@{#398091}
Get the correct number of pages to paint a fixed object on.
Fix off-by-one error in https://crrev.com/385513
BUG=617553
Review-Url: https://codereview.chromium.org/2040963002
Cr-Commit-Position: refs/heads/master@{#398090}
[MD settings] scroll to section find host
This CL fixes an issue with the scroll to section not finding its host
element. A unit test has also been added to detect the issue.
BUG=616186
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2022893003
Cr-Commit-Position: refs/heads/master@{#398089}
Remove use of deprecated MessageLoop methods in extensions.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2036863002
Cr-Commit-Position: refs/heads/master@{#398088}
Adding missing manifests to gn-built executables
Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds manifests to two executables.
[email protected]
BUG=602505
Review-Url: https://codereview.chromium.org/2021113003
Cr-Commit-Position: refs/heads/master@{#398087}
DevTools: restore protocol OWNERS restriction.
TBR=dgozman
Review-Url: https://codereview.chromium.org/2038363003
Cr-Commit-Position: refs/heads/master@{#398086}
[Remoting Android] Releases |secret_fetcher_| in DisconnectFromHost()
In some situations the same JniClient will be used for multiple connections
where ConnectToHost()->DisconnectFromHost()->ConnectToHost() will be called.
In ConnectToHost() we DCHECK !secret_fetcher_ but don't release it in
DisconnectFromHost(), which fails the DCHECK.
This CL solves this problem by resetting |secret_fetcher_| in
DisconnectFromHost(). However, we still need to investigate why JniClient
is being used for multiple connections.
BUG=617471
Review-Url: https://codereview.chromium.org/2046663002
Cr-Commit-Position: refs/heads/master@{#398085}
Revert of In official builds, let CHECK(false) crash instead of calling BreakDebugger. (patchset #2 id:20001 of https://codereview.chromium.org/1982123002/ )
Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.
BUG=599867,614865
Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
>
> This should save some binary size and make things a bit faster, without ill
> effects.
>
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
>
> BUG=599867
>
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867
Review-Url: https://codereview.chromium.org/2046593002
Cr-Commit-Position: refs/heads/master@{#398084}
Fix initialization of AudioTrack related output parameters
Since AudioCodecBridge::ConfigureAndStart creates AudioTrack
instance with config parameters, we need to initialize the
output parameters with the same values before we get
OnOutputFormatChanged().
Without this step the some changes between config and actual
parameters will be undetected, for instance before this change
(1) config_num_channels = 2, output_num_channels = 2
old output value was 0, unnecessary AudioTrack recreation
(2) config_num_channels = 1, output_num_channels = 2
old output value was 2, no change detected here but
AudioTrack was created with num_channels = 1
BUG=none
Review-Url: https://codereview.chromium.org/2042563002
Cr-Commit-Position: refs/heads/master@{#398083}
Remove use of deprecated MessageLoop methods in sync.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2033933002
Cr-Commit-Position: refs/heads/master@{#398082}
Mark container chain of out-of-flow objects for layout correctly.
This was an error in the refactoring at https://codereview.chromium.org/1323313004.
BUG=615056
Review-Url: https://codereview.chromium.org/2042623002
Cr-Commit-Position: refs/heads/master@{#398081}
Remove unused InspectorFrontend declarations.
There seems to be nothing called InspectorFrontend. Removed unused
forward declarations for it and changed comments to say "frontend"
instead.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2046433002
Cr-Commit-Position: refs/heads/master@{#398080}
Use a FontPlatformData pointer for FontDataCache's key
FontDataCache's key data type was a full FontPlatformData object, not a
pointer to one The value type of that cache is a SimpleFontData object,
which in itself stores a FontPlatformData object type.
If we want to manage memory related to font blobs (OpenType tables, web
font file buffers) we need to come to a situation where the lifecycle of
FontPlatformData objects is absolutely clear.
Previously, adding to the FontDataCache meant one copy of
FontPlatformData for the cache key, and one for the value as an owned
member of SimpleFontData.
In this situation, it is much harder to keep track of where we keep
FontPlatformData objects.
FontPlatformData objects keep a RefPtr<HarfBuzzFace>, which in turn
keeps hb_font objects, which keep references to OpenType tables copied
from Skia. If we cannot destroy FontPlatformData objects after use, we
cannot free the corresponding copied OpenType tables - so over the
lifetime of the renderer we're leaking OpenType table data for stale
FontPlatformData objects.
This is a first step towards fixing this situation and gaining better
control over the lifecylce of FontPlatformData objects.
BUG=617568
R=eae,tzik,bashi
Review-Url: https://codereview.chromium.org/2031363002
Cr-Commit-Position: refs/heads/master@{#398079}
cc: Separate computation of clip rect and visible rect to two functions
Separate clip rect and visible rect calculation so visible rect logic
would be easier to follow.
R=ajuma
BUG=594675
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2008283003
Cr-Commit-Position: refs/heads/master@{#398078}
[Offlining] Updates the tab helper to use the async OfflinePageModel API
Adds a test to make sure sequential navs are handled correctly, and also add histogram checks to all tab helper tests.
BUG=589526
Review-Url: https://codereview.chromium.org/2040573002
Cr-Commit-Position: refs/heads/master@{#398077}
Delete no longer used "Linux CT Top1K RR Perf" bot
Context:
This bot has not been running for about 2 months now. When it was running it did not generate any useful alerts.
These files were originally added in https://codereview.chromium.org/1410353007/
# Failing with missing LGTM from OWNER for chrome/ct_top1k.isolate even though M-A LGTM'ed.
TBR=maruel
BUG=skia:4503
Review-Url: https://codereview.chromium.org/2039973002
Cr-Commit-Position: refs/heads/master@{#398076}
Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|.
MediaStreamDispatcher::OnDeviceStopped() may delete the same element
twice from |label_stream_map_| and causes the crash.
BUG=616884
Review-Url: https://codereview.chromium.org/2035993002
Cr-Commit-Position: refs/heads/master@{#398075}
Fixed inconsistency with tray icon and user pod on lock screen.
Account now switches when focus changes, not just updated wallpaper.
BUG=614926
Review-Url: https://codereview.chromium.org/2035753003
Cr-Commit-Position: refs/heads/master@{#398074}
The previous CL was built around a test case I had made myself (there was no real life example). I found one and realized the type should be "text" and not "input".
Related CL: https://codereview.chromium.org/2025063002/
BUG=616174
TEST=AutofillFieldTest
Review-Url: https://codereview.chromium.org/2041863003
Cr-Commit-Position: refs/heads/master@{#398073}
[Extensions] Observe unloading extensions in the TabHelper
The extension TabHelper can have an associated extension if the
WebContents holds a hosted app. Watch for that extension being
unloaded and reset the reference to the extension if it is so that
we don't UAF it.
BUG=616057
BUG=616113
Review-Url: https://codereview.chromium.org/2037873002
Cr-Commit-Position: refs/heads/master@{#398072}
Cleanup naming issue with content::VideoFrameProvider
The name content::VideoFrameProvider was easy to cause confusion with
cc:VideoFrameProvider. Furthermore, the methods provided in the
content::VideoFrameProvider are not specific to Video, which makes the
name somewhat unsuitable.
List of changes:
* Moved the typedef content::VideoFrameProvider::RepaintCB out to a new
file and renamed it to VideoFrameCallback.
* Renamed interface VideoFrameProvider to PausableStream
* Renamed method Play() to Resume()
BUG=526835
Review-Url: https://codereview.chromium.org/2005053006
Cr-Commit-Position: refs/heads/master@{#398071}
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe
This is just a mechanical rename and reformat. The rename is good because:
1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
is responsible for knowing when it is safe to call.
2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.
3) The change makes the above two points clear to coders not to use
WebUI directly unless they know what they are doing.
In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.
See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo8yy68TN_FUhUzRz7Q/edit?usp=sharing
BUG=602523
Review-Url: https://codereview.chromium.org/1995113002
Cr-Commit-Position: refs/heads/master@{#398070}
views/mus: Create the BitmapUploader only when needed.
BitmapUploader is needed only for chrome when it uses software rendering. So
instead of always creating a BitmapUploader (which creates an extra surface for
the window) for every widget, create it only when needed.
BUG=none
Review-Url: https://codereview.chromium.org/2040453002
Cr-Commit-Position: refs/heads/master@{#398069}
Reject calcs with both lengths and percentages in radial-gradient
Reject calcs with both lengths and percentages in radial-gradient,
while for ellipse both length and percentage are allowed, they are
not allowed at the same time [1].
[1] https://drafts.csswg.org/css-images-3/#radial-gradients
Review-Url: https://codereview.chromium.org/1935173002
Cr-Commit-Position: refs/heads/master@{#398068}
Fire visualviewportchanged event on window rather than document
In https://codereview.chromium.org/2025393003/ I moved the visualViewport object
from document onto window but forgot to move the event to fire on the window
instead.
BUG=595826
Review-Url: https://codereview.chromium.org/2034313002
Cr-Commit-Position: refs/heads/master@{#398067}
Makes ash/mus use RootWindowControllerCommon
BUG=none
TEST=covered by tests
[email protected]
Review-Url: https://codereview.chromium.org/2033843003
Cr-Commit-Position: refs/heads/master@{#398066}
Revert of Suppress -Wnonportable-include-path on clang tot bots (patchset #2 id:20001 of https://codereview.chromium.org/2040533003/ )
Reason for revert:
The Clang warning was removed again in r271761.
Original issue's description:
> Suppress -Wnonportable-include-path on clang tot bots
>
> BUG=617318
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2bc751024e4ddf3f50594abdbf3c54b77df84562
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617318
Review-Url: https://codereview.chromium.org/2043813002
Cr-Commit-Position: refs/heads/master@{#398065}
Remove use of deprecated MessageLoop methods in cc.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2034913002
Cr-Commit-Position: refs/heads/master@{#398064}
Revert of Specify direct dependency of //components/crash on kasko_features.h (patchset #1 id:1 of https://codereview.chromium.org/2038473002/ )
Reason for revert:
It's breaking the official win-asan builder (https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/268)
Original issue's description:
> Specify direct dependency of //components/crash on kasko_features.h
>
> //components/crash/content/app has a public dependency on the generated
> header kasko_features.h. However, the GYP and GN files specify this
> dependency only transitively via a dependency on //third_party/kasko
> (which //components/crash/content/app does not actually depend on). This
> CL changes the dependency to be directly on
> //third_party/kasko:kasko_features as a speculative fix for the build
> failures listed in crbug.com/611319. Note that in any case this change
> is correct (whether it ends up resolving the flaky build failures or no).
>
> BUG=611319
> TBR=pmonette
>
> Committed: https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc
> Cr-Commit-Position: refs/heads/master@{#397390}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=611319
Review-Url: https://codereview.chromium.org/2047473002
Cr-Commit-Position: refs/heads/master@{#398063}
Remove use of deprecated MessageLoop methods in remoting.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2031083002
Cr-Commit-Position: refs/heads/master@{#398062}
WebAudio: record whether user gesture was available and provided.
We are looking into a more consistent audio playback on mobile and want
to see whether implementing Safari iOS behaviour in Chrome Android would
break websites.
BUG=616807
Review-Url: https://codereview.chromium.org/2031393003
Cr-Commit-Position: refs/heads/master@{#398061}
Limit tracked values in long running gmail benchmarks to V8 specific
values and the overall renderer memory stats.
BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2030343002
Cr-Commit-Position: refs/heads/master@{#398060}
Avoid RefPtr cycle between FontPlatformData and HarfBuzzFace
When retrieving getScaledFont() from HarfBuzzFace we were creating a
SimpleFontData and assigning it to the HarfBuzzFontData object that is
kept as the user data pointer for HarfBuzz callbacks. This introduces a
reference counting cycle since SimpleFontData owns the FontPlatformData
it was created from, and harfBuzzFace() is retrieved from
FontPlatformData itself.
Since getScaledFont() is called on a HarfBuzzFace instance that is
retrieved from FontPlatformData and only used for one shaping iteration,
reducing the link to SimpleFontData to a non owning pointer should be
acceptable.
BUG=617637
R=eae,tzik,kojii
Review-Url: https://codereview.chromium.org/2039263002
Cr-Commit-Position: refs/heads/master@{#398059}
PaymentRequest: Provide shippingAddress in PaymentResponse.
The shippingAddress attribute was already added by this issue[1] but current
implementation isn't supporting the attribute yet. So, we should provide the
attribute in PaymentResponse.
[1] https://github.com/w3c/browser-payment-api/pull/139
BUG=617194
Review-Url: https://codereview.chromium.org/2038333002
Cr-Commit-Position: refs/heads/master@{#398058}
Removing SAS gyp variables since they are no longer used by Chromoting.
Chromoting no longer relies on the sas.dll so we can clean up some of the
build files and remove these variables.
BUG=
Review-Url: https://codereview.chromium.org/2030423002
Cr-Commit-Position: refs/heads/master@{#398057}
Roll src/third_party/skia/ 38d1adf1f..09f5cd44a (4 commits).
https://chromium.googlesource.com/skia.git/+log/38d1adf1f7f4..09f5cd44ae30
$ git log 38d1adf1f..09f5cd44a --date=short --no-merges --format='%ad %ae %s'
2016-06-06 scroggo Prefix png functions
2016-06-06 jvanverth Use intptr_t for onTouch argument.
2016-06-06 scroggo Update pnglibconf.h
2016-06-06 msarett Use SK_TEST_QCMS to mark qcms test code
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2043643003
Cr-Commit-Position: refs/heads/master@{#398056}
Remove use of deprecated MessageLoop methods in android_webview.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2030193003
Cr-Commit-Position: refs/heads/master@{#398055}
Fix misspelling in txt_to_polymer_grdp.py.
Review-Url: https://codereview.chromium.org/2039043002
Cr-Commit-Position: refs/heads/master@{#398054}
Flip linux clang tot bots to GN.
[email protected]
BUG=605732
Review-Url: https://codereview.chromium.org/2000413002
Cr-Commit-Position: refs/heads/master@{#398053}
Roll PDFium c324646..f7e108b
https://pdfium.googlesource.com/pdfium.git/+log/c324646..f7e108b
BUG=427616,616253,616838,613623
[email protected]
TEST=bots
Review-Url: https://codereview.chromium.org/2046623002
Cr-Commit-Position: refs/heads/master@{#398052}
Roll src/third_party/catapult/ 0c6dbf87b..8f31b02e7 (4 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0c6dbf87bab3..8f31b02e7cdf
$ git log 0c6dbf87b..8f31b02e7 --date=short --no-merges --format='%ad %ae %s'
BUG=552376,617174
[email protected]
Review-Url: https://codereview.chromium.org/2039933002
Cr-Commit-Position: refs/heads/master@{#398051}
Implement the UI logic behind the Sign In promo in the password bubble.
BUG=615825
Review-Url: https://codereview.chromium.org/2036323002
Cr-Commit-Position: refs/heads/master@{#398050}
Making cookies eviction quotas match spec
According to the section 3 and section 5 in
https://tools.ietf.org/html/draft-west-cookie-priority-
00#section-3, the old cookie monster implementation doesn't
maintain priority quotas correctly.
This CL makes sure there will always be at least 30 low
priority cookies, 50 mid priority and 70 high priority
cookies if there had been enough of them before the eviction.
Please note, secure cookies are more important than non-secure
per https://tools.ietf.org/html/draft-west-leave-secure-cookies-alone.
A small example: if there are 70 cookies:
37 non-secure low priority and 33 secure low priority
cookies, 37 non-secure cookies are deleted during the first
round and other 3 secure low priority cookies are deleted
during the following round preserving 30 low priority
cookies according to the quota of those specific cookies.
For a bigger example that fully complies with the
implementation, check the unittests.
Before the fix, the unittests were just adjusted to the
behavior of cookies eviction.
For example, if we take the following unittest:
Round 1 => 10L; round 2 => 11M, 10L; round 3 => none.
TestPriorityCookieCase(cm.get(), "11HN 10MN 20LN 110MN 20LN
10HN", 20U,109U, 21U, 150U, 0U);
The problem here was that there were only 40 low priority
cookies, but the quota was not preserved for those cookies.
First, 10 low priority cookies were deleted and then more 10
low priority cookies were deleted leaving only 20 of them,
which was less than the quota (30 low priority cookies).
It happened because the eviction algorithm didn't know how
many cookies of a specific priority were deleted and
it had always started to delete all the cookies from the
beginning of the container removing even those cookies
that shouldn't have been deleted.
After we land this CL, we can have cookies in any order and
high priority cookies will be eventually deleted in order
to avoid excess of high priority cookies by some
applications within the same domain. Thus, after the
eviction algorithm runs, we should have at least 30 low, 50
mid and 70 high priority cookies if we had sufficient
amount of them in the beginning.
BUG=609550
Review-Url: https://codereview.chromium.org/1976073002
Cr-Commit-Position: refs/heads/master@{#398049}
Rename RootScroller class to RootScrollerController.
Its weird that the rootScroller property on document takes an Element but the
RootScroller object is really a manager class. Rename it to make this more clear
and prevent confusion.
BUG=505516
Review-Url: https://codereview.chromium.org/2040693002
Cr-Commit-Position: refs/heads/master@{#398048}
Remove use of deprecated MessageLoop methods in media.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2029403004
Cr-Commit-Position: refs/heads/master@{#398047}
[Mac/GN] When using debug_devtools=true, bundle the inspector resources using a symlink.
BUG=616657
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2038593002
Cr-Commit-Position: refs/heads/master@{#398046}
[Cronet] Send request headers automatically in bidirectional stream on iOS.
BUG=599902
Review-Url: https://codereview.chromium.org/2039943002
Cr-Commit-Position: refs/heads/master@{#398045}
Remove the last vestiges of RC4.
We've branched for 53 now, so the admin policy for enabling RC4 has
expired. Remove it completely.
Farewell, RC4. There was a time when you saved us from the beast and
rabid poodles. By luck, you didn't have triskaidekaphobia, unlike our
other friends who chained blocks together. (Boy are they annoying.
It'd be wonderful if we could ditch them someday.)
But you always had your biases, which made it hard to trust you with
secrets. Now we have new friends who do the cha-cha twenty times a
day and learned counting from some French mathematician. We just
don't have room for you anymore.
BUG=375342
Review-Url: https://codereview.chromium.org/2030263002
Cr-Commit-Position: refs/heads/master@{#398044}
tools/android/loading Add timestamps to backend logs.
Review-Url: https://codereview.chromium.org/2039723003
Cr-Commit-Position: refs/heads/master@{#398043}
Refactoring: Use in-class member initialization in EditingStyle.h
It allows to remove common initialization lists in constructors.
BUG=none
Review-Url: https://codereview.chromium.org/2034303004
Cr-Commit-Position: refs/heads/master@{#398042}
tools/android/loading Switch from multiprocessing Pool to Process
Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.
Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.
Review-Url: https://codereview.chromium.org/2037073002
Cr-Commit-Position: refs/heads/master@{#398041}
Remove use of deprecated MessageLoop methods in ipc.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2037853002
Cr-Commit-Position: refs/heads/master@{#398040}
[gin] Add V8IgnitionLowEnd experiment
Adds an experimental option to enable Ignition for low-end Android
devices.
BUG=v8:4868
Review-Url: https://codereview.chromium.org/2039793003
Cr-Commit-Position: refs/heads/master@{#398039}
Flip Linux bots on chromium.lkgr to GN.
[email protected], [email protected]
BUG=605732
Review-Url: https://codereview.chromium.org/2006173002
Cr-Commit-Position: refs/heads/master@{#398038}
Roll src/third_party/skia/ 55fdcccf0..38d1adf1f (2 commits).
https://chromium.googlesource.com/skia.git/+log/55fdcccf01d4..38d1adf1f7f4
$ git log 55fdcccf0..38d1adf1f --date=short --no-merges --format='%ad %ae %s'
2016-06-06 liyuqian Allow animation in Android viewer
2016-06-06 msarett Name parametric gamma curve types
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2047433002
Cr-Commit-Position: refs/heads/master@{#398037}
Refactor nonce support to correctly handle report-only policy.
In order to correctly handle report-only, we need to stop thinking of
nonces as a one-time bypass in 'ScriptLoader', and start thinking of it
as an ongoing check associated with a request (as it's specced in
https://w3c.github.io/webappsec-csp/#script-src-algorithms). This patch
moves nonce checking into 'FrameFetchContext::canRequest' by attaching
it to 'ResourceLoaderOptions', and using that new data inside the
'ContentSecurityPolicy::allow*' checks to ensure that each active policy
gets a crack at reporting violations.
To prevent regression, this patch adds a number of unit tests, moves
the existing nonce layout tests to a separate directory, and adds a
few layout tests as well.
BUG=614416,611652,614802
Review-Url: https://codereview.chromium.org/2020223002
Cr-Commit-Position: refs/heads/master@{#398036}
Add video width and height to getSettings.
BUG=617142
Review-Url: https://codereview.chromium.org/2037573004
Cr-Commit-Position: refs/heads/master@{#398035}
Update V8 to version 5.3.144.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dbae8a5c..6aed5443
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2043733002
Cr-Commit-Position: refs/heads/master@{#398034}
Flip more Win bots to GN.
This flips the remaining Win builders on the chromium, chromium.chrome,
and chromium.perf waterfalls, as well as the matching trybots. The
remaining GYP win builders are FYI bots, memory bots, and the official
builders; the latter should be flipped ASAP after this lands to avoid
any skew.
[email protected]
BUG=605319
Review-Url: https://codereview.chromium.org/2030823002
Cr-Commit-Position: refs/heads/master@{#398033}
sandwich: Uplift for production use.
This CL contains several change to uplift sandwich:
1) Finds Android DeviceUtil object from device serial only once
per command line to speed up sandwich graph generation.
2) Makes SandwichRunner.output_dir mandatory so it can always dumps
error files in case of error or intermittent failures.
3) Lets AndroidChromeController dismiss crash dialogs when browser
or renderer process crashes.
BUG=582080
Review-Url: https://codereview.chromium.org/2040993002
Cr-Commit-Position: refs/heads/master@{#398032}
Do not crash on null stream in writing to bidirectional streams
When SendData/SendvData is called, it might be that OnClose
has been invoked without an error, in which case
BidirectionalStream::Delegate::OnFailed would not have been
invoked. This is theoretically possible, but I am not
aware if such case would exist.
This CL removes the assumption that SendData/SendvData
is only called when stream is alive. If stream is
destroyed, propagate that as an ERR_UNEXPECTED to caller,
instead of crashing with a segfault.
BUG=606394
Review-Url: https://codereview.chromium.org/2032733002
Cr-Commit-Position: refs/heads/master@{#398031}
Allow the exact DOM Code value to be sent from layout tests.
With the conversion to keyIdentifier there are some issues that need
to be fixed with layout tests. Add the exact string identifiers to
event_sender so that it is clear between the LayoutTests
and the implementation the identifier can be the same.
BUG=607349
Review-Url: https://codereview.chromium.org/2039233002
Cr-Commit-Position: refs/heads/master@{#398030}
Clamp radial gradient end radii
Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.
BUG=616993
[email protected]
Review-Url: https://codereview.chromium.org/2041653002
Cr-Commit-Position: refs/heads/master@{#398029}
Roll src/third_party/catapult/ f58ecb641..0c6dbf87b (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f58ecb6416a4..0c6dbf87bab3
$ git log f58ecb641..0c6dbf87b --date=short --no-merges --format='%ad %ae %s'
BUG=617174
[email protected]
Review-Url: https://codereview.chromium.org/2035403003
Cr-Commit-Position: refs/heads/master@{#398028}
Roll breakpad to pick up Android x86 fix.
BUG=599327
Review-Url: https://codereview.chromium.org/2046573002
Cr-Commit-Position: refs/heads/master@{#398027}
Introduce UserHiveVisitor for performing operations on local users' registry hives.
BUG=none
[email protected]
Review-Url: https://codereview.chromium.org/2027063002
Cr-Commit-Position: refs/heads/master@{#398026}
We hard coded the pointer type as mouse in ui::GetMousePointerDetailsFromNative
for events sending from Windows. Now we use a mouse message from GetMessageExtraInfo to decide
the actual input device type.
GetMessageExtraInfo needs to be mask-checked against 0xFFFFFF00, and then compared
with 0xFF515700. True when this mouse message was generated by a Tablet PC pen or touch
screen. Otherwise it is from a mouse device. Additionally, in Windows Vista or later,
the eighth bit, masked by 0x80, is used to differentiate
touch input from pen input
(0 = pen, 1 = touch).
Reference:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms703320(v=vs.85).aspx
BUG=614820
Review-Url: https://codereview.chromium.org/2020143003
Cr-Commit-Position: refs/heads/master@{#398025}
Add time measurement for deferred handler.
BUG=614452
Review-Url: https://codereview.chromium.org/2034833002
Cr-Commit-Position: refs/heads/master@{#398024}
Roll src/third_party/skia/ 401e77cfe..55fdcccf0 (1 commit).
https://chromium.googlesource.com/skia.git/+log/401e77cfe126..55fdcccf01d4
$ git log 401e77cfe..55fdcccf0 --date=short --no-merges --format='%ad %ae %s'
2016-06-06 robertphillips Remove GrRenderTarget from GrPipelineBuilder
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2037403002
Cr-Commit-Position: refs/heads/master@{#398023}
mac/gn: Make sure components_unittests contain the same tests in gyp and gn builds.
Also switch bits of components_unittests's gn file from the
"include everything, conditionally exclude some bits again"
to the "include only what you need" pattern that's preferred
in gn files.
BUG=431177
Review-Url: https://codereview.chromium.org/2034083003
Cr-Commit-Position: refs/heads/master@{#398022}
sandwich: Merge cache-validation.json and urls-for-resources.json tasks
Before in the NoState-Prefetch benchmark tasks graph, Sandwich had
the common/cache-validation.json tasks as a leaf. But it could
lead to issue when selecting final tasks with -e REGEX, and
but forgetting to have the regex matching this important task as
well as the subset of task the user initially wanted to run.
This CL addresses this issue by merging the previous tasks
common/cache-validation.json and common/urls-for-resources.json
into a single common/patched-cache-validation.json tasks, and
have all the benchmark subgraphs depending on them so we are
sure to always run the cache validation at least once before the
benchmark runs.
This CL take this oportunity to output further statistics in the
CSV related to the cache genration such as the number of
sub-resources of an URL, the number of expected cached resources
and the actual number of successfully cached resources, to
identify at scale on many URLs from the CSVs potential issues
the WPR patcher could still have on some webpages.
Moreover, this CL take this change in the extract metrics task
change as an opportunity to parse the fat loading trace JSON
file only once per URL repeat row, in order to make theses tasks
faster.
BUG=582080
Review-Url: https://codereview.chromium.org/2033093002
Cr-Commit-Position: refs/heads/master@{#398021}
Apply netty-tcnative patch
Change DEPS to reference a new netty-tcnative commit that contains
David's patch:
"Don't reach into BoringSSL's SSL structs. Doing so is deprecated
and will break in the future."
Review-Url: https://codereview.chromium.org/2038063003
Cr-Commit-Position: refs/heads/master@{#398020}
[Chromecast] Add free memory UMA histograms
MeminfoMemFree is currently recorded by sysmon; the problem with this is
we don't get the data for all devices. MemFreeDerived is newly relevant
for new memory pressure heuristic.
BUG=internal b/26029747
Review-Url: https://codereview.chromium.org/2028233002
Cr-Commit-Position: refs/heads/master@{#398019}
[Clean-up] Remove unused codes
It doesn't look like this code is used and besides AutofillExternalDelegate::has_shown_popup_for_current_edit_ looks like same variable.
Review-Url: https://codereview.chromium.org/2040933002
Cr-Commit-Position: refs/heads/master@{#398018}
Update V8 to version 5.3.143.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f6e084e..dbae8a5c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2044453002
Cr-Commit-Position: refs/heads/master@{#398017}
Roll src/third_party/catapult/ f6720c26f..f58ecb641 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f6720c26fcd4..f58ecb6416a4
$ git log f6720c26f..f58ecb641 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2041753003
Cr-Commit-Position: refs/heads/master@{#398016}
Bump Flatbuffers version
BUG=617063
Review-Url: https://codereview.chromium.org/2035683003
Cr-Commit-Position: refs/heads/master@{#398015}
[Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's
Keeps the V8 wrappers alive as long as there're event listeners or pending
promises and such.
BUG=616761
TEST=manual, see repro steps in the bug
Review-Url: https://codereview.chromium.org/2038573002
Cr-Commit-Position: refs/heads/master@{#398014}
Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader
This cl replaces traceWrappers method with getHeader. The motivation for the
original traceWrappers method was only to get HeapObjectHeader anyway, and this
refactoring simplifies current code and makes further enhancements (such as
incremental tracing :) easier.
LOG=no
BUG=468240
Review-Url: https://codereview.chromium.org/2045453002
Cr-Commit-Position: refs/heads/master@{#398013}
Auto-rebaseline for r398004
https://chromium.googlesource.com/chromium/src/+/4095e6cfa
BUG=603137
[email protected]
Review URL: https://codereview.chromium.org/2046513002 .
Cr-Commit-Position: refs/heads/master@{#398012}
tools/android/loading: Output cost of requests in report.py
This CL adds the tracking of the following per-user-lens metrics in report.py:
- Cumulative cost of requests
- Cumulative cost of preloaded requests
This provides extra insight over just having the number of such requests.
Review-Url: https://codereview.chromium.org/2039853003
Cr-Commit-Position: refs/heads/master@{#398011}
Make CSSProperty store a const CSSValue
Make CSSProperty store a Member<const CSSValue>, instead of a
Member<CSSValue>. This is pre-work for making CSSValueLists store const
CSSValues.
BUG=526586
Review-Url: https://codereview.chromium.org/2037973002
Cr-Commit-Position: refs/heads/master@{#398010}
Add a libfuzzer for usrsctp, an SCTP userland stack.
Usrsctp is used in WebRTC to handle packets in the data channel.
BUG=
Review-Url: https://codereview.chromium.org/2039483003
Cr-Commit-Position: refs/heads/master@{#398009}
PlzNavigate: fix RenderViewImplTest.OnNavigationHttpPost
This CL fixes RenderViewImplTest.OnNavigationHttpPost when PlzNavigate is
enabled by having RenderFrameImpl::NavigateInternal chose to use LoadDataURL
instead of WebLocalFrame::load in the same cases as what the current
architecture is doing.
It also ensures that the WebURLLoader will not replace the ResourceResponse it
receives with one provided by the browser when loading a data url. In this
case, the browser has no response to provide. so we should use the one
generated by the HandleDataURL task.
BUG=475027
Review-Url: https://codereview.chromium.org/2037733002
Cr-Commit-Position: refs/heads/master@{#398008}
Update V8 to version 5.3.140.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b32933fb..4f6e084e
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2039203002
Cr-Commit-Position: refs/heads/master@{#398007}
CSP: Add line numbers to reports whenever we have them.
Following up on https://codereview.chromium.org/2020053002, we have
line numbers in a variety of cases today, but we're only dumping them
into the reports when a script file generated the error. This patch
ensures that line/column data is appended whenever it's available.
BUG=615862
Review-Url: https://codereview.chromium.org/2032793004
Cr-Commit-Position: refs/heads/master@{#398006}
Enable accessible name of a control to include multiple <label> elements.
The spec allows a form control element to have multiple <label> elements,
but we only supported one in accessibility code. Fix it by switching to
using the LabelableElement interface rather than some redundant code that
kept track of label elements in TreeScope, which allows us to get rid of
that now-unused code.
BUG=573494
Review-Url: https://codereview.chromium.org/1939303002
Cr-Commit-Position: refs/heads/master@{#398005}
Addendum to OpenType feature detection simplification
Addressing Behdad's review comment.
Reland after revert in 3d9eeeefe, test expectation can
be rebaselined. Landing TBR, since previously LGTM'ed
in https://codereview.chromium.org/2026433002
BUG=603137
TBR=behdad
Review-Url: https://codereview.chromium.org/2040923002
Cr-Commit-Position: refs/heads/master@{#398004}
Store ScriptWrappableVisitor in V8PerIsolateData
Store a reference of ScriptWrappableVisitor also in V8PerIsolateData so it can
be accessed from blink code easily (for example when oilpan will want to trace
ScriptWrappableVisitor's marking deque :)
LOG=no
BUG=468240
Review-Url: https://codereview.chromium.org/2033583007
Cr-Commit-Position: refs/heads/master@{#398003}
Change ImmutableStylePropertySet to store const CSSValue
Change ImmutableStylePropertySet to store const CSSValue instead of just
CSSValue. This is pre-work for making CSSProperty store const CSSValues.
BUG=526586
Review-Url: https://codereview.chromium.org/2032613007
Cr-Commit-Position: refs/heads/master@{#398002}
Get non indexed property names for dense array serialization.
Although we already have all own property names to judge if the serializing
array is dense or sparse, getting non indexed ones again for dense arrays
improves performance of serialization of large scale dense arrays.
(For small size arrays and sparse arrays, this CL does not change the performance.)
This CL improves a micro-benchmark score of PerformanceTests/Bindings/serialize-array.html
from 430ms to 260ms on my local machine.
https://chromeperf.appspot.com/report?sid=96d5e4ae4e5a4085541ab88e8672b8836d57d223b759a3d5406a06c0b1a65420
BUG=148757
Review-Url: https://codereview.chromium.org/2037583002
Cr-Commit-Position: refs/heads/master@{#398001}
Remove pre-Oilpan protections from LocalFileSystem.
R=
BUG=
Review-Url: https://codereview.chromium.org/2039713002
Cr-Commit-Position: refs/heads/master@{#398000}
Improve the HeapListHashSet no-weakness static assert message.
Mention the alternate HeapLinkedHashSet<> if WeakMember<>s are
attempted used with HeapListHashSet<>; for non-trivial reasons,
we only support weakness with the former.
R=
BUG=614112
Review-Url: https://codereview.chromium.org/2034423002
Cr-Commit-Position: refs/heads/master@{#397999}
Add logging to remote commands
BUG=602572
Review-Url: https://codereview.chromium.org/1923943003
Cr-Commit-Position: refs/heads/master@{#397998}
tools/android/loading: Create UserLens for PLT
This CL creates a UserSatisfiedLens for page load time (PLT) and
refactors report.py to use this new lens. The motivation is to avoid
having to duplicate code tracking metrics for PLT and other user
satisfied events.
This change is not backwards compatible as it changes the names of some
of the keys in report generation.
Review-Url: https://codereview.chromium.org/2032013002
Cr-Commit-Position: refs/heads/master@{#397997}
Remove the use of OwnedPtrDeleter in HarfBuzzFace.
It's hard to mechanically replace specializations of OwnedPtrDeleter<T>
to std::unique_ptr equivalents. Therefore, they are converted to
std::unique_ptr manually.
The specializations in HarfBuzzFace.h are only used from
HarfBuzzFace.cpp, so the new deleters are added in .cpp file. New
typedefs are created so people can always use std::unique_ptr with a
correct deleter.
BUG=617504
Review-Url: https://codereview.chromium.org/2043613002
Cr-Commit-Position: refs/heads/master@{#397996}
gn: Add all v8 targets to gn_all
BUG=chromium:474921
Review-Url: https://codereview.chromium.org/2031063002
Cr-Commit-Position: refs/heads/master@{#397995}
exo: Fix surface origin offset.
GetWindowBoundsInScreen() should never be used to determine
the surface origin as it takes ancestor transforms into
account. Surface origin should be relative to widget window
bounds as they are not affected by transforms.
BUG=549781
TEST=exo_unittests
[email protected]
Review-Url: https://codereview.chromium.org/2045433002
Cr-Commit-Position: refs/heads/master@{#397994}
Make removeChild/remove faster with active Range objects
This patch makes |Node#removeChild()| and |Node#remove()| faster when
there are active Range objects in document by using DOM tree version as
offset validity instead of invalid offset value on node removal, which is
done by |Range::nodeChildrenChanged()| via
|Document::updateRangesAfterChildrenChanged()|.
This patch is similar to http://crrev.com/2034023003, which makes appendChild
and insertBefore faster.
On my Linux box, "remove-child-with-ranges.html" (with 1000 |Range| objects)
results are:
w/patch:
avg 0.96 runs/s, median 1.00 runs/s, min 0.80 runs/s, max 1.03 runs/s
w/o patch:
avg 0.69 runs/s, median 0.71 runs/s, min 0.56 runs/s, max 0.76 runs/s
BUG=n/a
TEST=PerformanceTests/Mutation/remove-child-with-ranges.html
Review-Url: https://codereview.chromium.org/2039113003
Cr-Commit-Position: refs/heads/master@{#397993}
Implement ComputedStylePropertyMap for Typed OM.
Spec: https://drafts.css-houdini.org/css-typed-om/#computed-stylepropertymap-objects
Uses a partial IDL interface to attach a getComputedStyleMap method to
window.
Implements the getAll and getProperties.
Moved has() up into the base class from InlineStylePropertyMap.
Not implemented: iteration
BUG=545318
Review-Url: https://codereview.chromium.org/1849653003
Cr-Commit-Position: refs/heads/master@{#397992}
Remove unused function CSSValueList::prepend()
Review-Url: https://codereview.chromium.org/2041773002
Cr-Commit-Position: refs/heads/master@{#397991}
Suspend more task queues for background renderers (experimental)
Backgrounded-tab suspending was introduced at crrev/1914143002, where
only the timer task queue was suspended. We knew this was not enough and
we need to suspend more task queues to prevent the return of purged
cache.
This CL adds the feature to suspend these task queues besides timer task
queues when backgrounded-tab suspending starts:
* default_loading_tq
* frame_loading_tq
The above task queues might call V8 functions, which means any purged cache
can be reverted.
This CL doesn't suspend "default_tq" (which we can't suspend since this
conveys critial tasks) and "idle_tq" (which I think is not harmful for
purged caches), "control_(after_wakeup_)tq" (which is only for internal
scheduler housekeeping tasks) and "compositor_tq" (which is not used when
the renderer is backgrounded).
BUG=607077
TEST=n/a
Review-Url: https://codereview.chromium.org/2017763003
Cr-Commit-Position: refs/heads/master@{#397990}
AppCache: Check whether AppCacheStorageImpl is enabled before calling disk_cache()
BUG=617200
Review-Url: https://codereview.chromium.org/2040833002
Cr-Commit-Position: refs/heads/master@{#397989}
Add documentation of SafePointBarrier internal state.
Renamed |m_canResume| to |m_parkingRequested| while doing so,
its (inverted) meaning seems clearer imho in this context.
R=
BUG=
Review-Url: https://codereview.chromium.org/2039793002
Cr-Commit-Position: refs/heads/master@{#397988}
Make appendChild/insertBefore faster with active Range objects
This patch makes |Node#appendChild()| and |Node#insertBefore()| faster when
there are active Range objects in document.
Before this path, we iterate over all active |Range| objects to make there
cached offset invalid for each |appendChild()| and |insertBefore()|.
From this patch, we use both DOM tree version and invalid value of
|m_offsetInContainer| as invalid offset marker to avoid iterating over
all active |Range| objects. This makes execution of speed of |appendChild()| and
|insertBefore()| independent from number of active |Range| objects.
On my Linux box, "append-child-with-ranges.html" (with 100 |Range| objects)
results are:
w/patch:
avg 13.4ms, median 14 ms, min 10ms, max 21ms
w/o patch:
avg 42.1ms, median 42ms, min 38ms, max 49ms
Note: This patch is inspired by esphren@'s comments regarding to crbug/613658
and based on kouhei@'s great idea and strong push.
BUG=n/a
TEST=PerformanceTests/Mutation/append-child-with-ranges.html
Review-Url: https://codereview.chromium.org/2034023003
Cr-Commit-Position: refs/heads/master@{#397987}
Implement StringImpl sharing for StringView::toString().
Prior to https://codereview.chromium.org/2007103003 StringBuilder had an
optimization that would share the StringImpl when calling append() with
a String the first time. This meant that doing element.textContent on
an Element with a single Text node child wouldn't need to string copy.
The optimization also helps the parser, removing a string copy when
flushing text in the HTML parser (flushPendingText) when there's a
single text that was appended, and the text is a reasonable length
(<= 65536 bytes).
This optimization further helps any code that would potentially append
an AtomicString to a StringBuilder and then do toAtomicString()
or toString() by ensuring we return the same AtomicString again
avoiding a bunch of work, and allowing the atomic string optimization
to propagate to the result.
This patch restores the StringBuilder optimization by adding a
StringImpl* member to StringView and allowing toString() and
toAtomicString() to return that member when the offset is zero and the
length is the same as the input string.
This patch also collapses the m_is8Bit flag into the m_impl by just
reusing the field to know if the StringView is 8bit. We now store the
shared empty 8bit or 16bit strings in the impl field for views created
from sources that are not backed by StringImpl. Doing this keeps the
StringView class to be only 2 ptrs and an unsigned wide.
I also further simplified the code by using the union members directly
and by adding a void* bytes() getter to StringImpl which removed the
branch on is8Bit for the common case of constructing a StringView from
a String or StringImpl with no offset, and the full length.
BUG=615174
Review-Url: https://codereview.chromium.org/2033293002
Cr-Commit-Position: refs/heads/master@{#397986}
Made ElementStyleResources store const CSSSVGDocumentValues
Made ElementStyleResources store const CSSSVGDocumentValues in
m_pendingSVGDocuments, meaning that addPendingSVGDocument() can take a
const CSSSVGDocumentValue* instead of a regular pointer. This was
required so that FilterOperationResolver::createFilterOperations() can
use the non-const call to CSSValueList::item().
This also involved making CSSSVGDocumentValue::load() a const method and
marking CSSSVGDocumentValue's cache-related members as mutable.
BUG=526586
Review-Url: https://codereview.chromium.org/2038443003
Cr-Commit-Position: refs/heads/master@{#397985}
Attribute Stuff to Frames with FrameBlamer
This patch attributes the cost of the following functions to individual frames:
- FrameView::updateStyleAndLayoutIfNeededRecursiveInternal
- PageAnimator::serviceScriptedAnimations
- V8ScriptRunner::callFunction
The above attribution is built on a new helper class ScopedFrameBlamer, a
wrapper of a LocalFrame's frame blame context, for automatically calling the
blame context's Enter() and Leave() functions when we enter/exit a scope.
Design doc: https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8APtI/edit?usp=sharing
BUG=546021
Review-Url: https://codereview.chromium.org/2028523002
Cr-Commit-Position: refs/heads/master@{#397984}
Cache the result of isScopedInV0 flag in Event object
This makes the micro benchmarks (PerformanceTests/Events/) slightly faster.
BUG=531990,617113
Review-Url: https://codereview.chromium.org/2034413002
Cr-Commit-Position: refs/heads/master@{#397983}
Move remaining tests on win GN bots to main bots and update CQ
There were a few test steps running only on the Win8 Aura
bot, which was the original GN bot. This CL makes sure
they run on the main Windows x86 and x64 bots now that
they are also using GN.
This CL also takes win8_chromium_ng out of the CQ since
it's now redundant.
[email protected], [email protected]
BUG=605318
Review-Url: https://codereview.chromium.org/2032613004
Cr-Commit-Position: refs/heads/master@{#397982}
Update V8 to version 5.3.139.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b94ab6fc..b32933fb
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2035353002
Cr-Commit-Position: refs/heads/master@{#397981}
[mojo-edk] Make the Mojo EDK compile under NaCl.
BUG=604282
Review-Url: https://codereview.chromium.org/2039713004
Cr-Commit-Position: refs/heads/master@{#397980}
Reduced the callers to the non-const version of CSSValueList::item()
Reduced the callers to the non-const version of CSSValueList::item().
All non-trivial callsites were changed to use the const version of the
item() method. This is pre-work to remove the non-const version
altogether.
Remaining callsites either require CSSValueList::append() to take a
const pointer (which would require CSSValueList to actually store
Member<const CSSValue>s), or require some other cascading const change.
NOTE: This patch also involved making CSSFontFaceSrcValue::fetch() a
const method, and making the cached member m_fetched mutable.
BUG=526586
Review-Url: https://codereview.chromium.org/2036943002
Cr-Commit-Position: refs/heads/master@{#397979}
[mojo-edk] Bind a child token to child launches and port reservations.
This allows the EDK to close reserved ports when a child launch fails, by
being able to associate channels to reserved ports.
BUG=589859
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2019973002
Cr-Commit-Position: refs/heads/master@{#397978}
Change CSSValueList::removeAll and hasValue to take const CSSValue&
Change CSSValueList::removeAll and CSSValueList::hasValue to take const
references instead of pointers. This is more semantically correct and
safe, and is good pre-work for making CSSValueList::item() return const
references.
BUG=526586
Review-Url: https://codereview.chromium.org/2033583006
Cr-Commit-Position: refs/heads/master@{#397977}
exo: Implement version 2 of remote shell interface.
Adds support for maximize and minimize as well as allowing the
client to request that window is made fullscreen.
BUG=549781
TEST=exo_unittests
Review-Url: https://codereview.chromium.org/2040743002
Cr-Commit-Position: refs/heads/master@{#397976}
Roll src/third_party/catapult/ 3835bca70..f6720c26f (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3835bca70508..f6720c26fcd4
$ git log 3835bca70..f6720c26f --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2041733002
Cr-Commit-Position: refs/heads/master@{#397975}
Move xhtml-mathml-dtd-entity-support.htm to NeverFixTests.
The test accesses w3c.github.io. We don't allow it in testing.
BUG=617154
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2039763002
Cr-Commit-Position: refs/heads/master@{#397974}
Fixed overlapping subtle notifications on Mac.
Can happen when a fullscreen/pointer-lock bubble and a new-back-shortcut
bubble are visible at the same time. Now the new bubble will dismiss the
old bubble (which is the behaviour on Views platforms).
BUG=615971
Review-Url: https://codereview.chromium.org/2028963002
Cr-Commit-Position: refs/heads/master@{#397973}
Flip Linux memory, memory.fyi ASAN, TSAN bots to GN.
and the matching tryservers on chromium.linux ...
[email protected], [email protected]
BUG=605732
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_asan_rel_ng,linux_chromium_tsan_rel_ng
Review-Url: https://codereview.chromium.org/2035533002
Cr-Commit-Position: refs/heads/master@{#397972}
H264Decoder: work around nonconforming streams with consecutive IDRs.
Per H264 spec, idr_pic_id should differ for two consecutive IDRs in the
stream. Unfortunately, not all streams conform to this requirement. Work
around this by checking first_mb_in_slice in these cases and trigger
a new picture if the second IDR slice starts with 0th macroblock.
BUG=chrome-os-partner:52181,580064,b/28032676,b/29061984
TEST=various problematic streams from bug reports,crosvideo.appspot,vdatest
Review-Url: https://codereview.chromium.org/2032323002
Cr-Commit-Position: refs/heads/master@{#397971}
Make ScriptRegexp for email address a member of EmailInputType.
Make it a data member of EmailInputType instead of a function-local static variable.
- Move EmailInputType constructor implementation to the .cpp file to void to include
ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to convertEmailAddressToASCII() and
isValidEmailAddress() and add createEmailRegexp() for ease of unit testing.
BUG=597530
Review-Url: https://codereview.chromium.org/2037963002
Cr-Commit-Position: refs/heads/master@{#397970}
Use InkDropHostView::ink_drop_delegate_ everywhere
Now that InkDropHostView as the base class for all ripple-enabled
classes took ownership of ink drop delegate, no other class needs to
have its own ink drop delegate.
BUG=none
Review-Url: https://codereview.chromium.org/2031763005
Cr-Commit-Position: refs/heads/master@{#397969}
exo: Handle cross-fade animations properly.
Cross-fade animations used for example when maximizing a
window will recreate the layer hierarchy and cross fade between
the old layers and the new layers. This relies on the contents
of the new layers being updated within some amount of time.
Produce new texture mailboxes when a layer is recreated until
we have an interface that provides some guarantee that the
client will.
BUG=549781
TEST=exo_unittests
Review-Url: https://codereview.chromium.org/2041663002
Cr-Commit-Position: refs/heads/master@{#397968}
Fix use-after-free in UseProgram and DetachShader
After a shader or program is marked for deletion, until it's not in use any
more, it can still be operated upon. We need to ensure we don't accidentally
delete tracking objects.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2035223002
Cr-Commit-Position: refs/heads/master@{#397967}
Roll src/third_party/catapult/ be4159a15..3835bca70 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/be4159a15b3e..3835bca70508
$ git log be4159a15..3835bca70 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2038343002
Cr-Commit-Position: refs/heads/master@{#397966}
[Fetch API] Cancel loading when the worker is terminating.
BodyStream assumes controller() returns a non-null pointer as long as
|m_reader| is non-null. But that assumption will break if the constructor
exits early when the worker is terminating. This CL clears |m_reader| in
such a case to keep the assumption.
BUG=616985
Review-Url: https://codereview.chromium.org/2036963002
Cr-Commit-Position: refs/heads/master@{#397965}
Make ChannelMojo compile under NaCl.
BUG=604282
Review-Url: https://codereview.chromium.org/2037773003
Cr-Commit-Position: refs/heads/master@{#397964}
Not show the launcher during Chrome app installation
We are currently showing notifications during Chrome app installation from CWS, so we don't need to show the launcher.
BUG=606843
TEST=manual test
Review-Url: https://codereview.chromium.org/2032743003
Cr-Commit-Position: refs/heads/master@{#397963}
Updating trunk VERSION from 2760.0 to 2761.0
Cr-Commit-Position: refs/heads/master@{#397962}
Mojo C++ bindings: rename ArrayValidateParams for clarity
BUG=616649
TESTED=mojo/edk/test:mojo_public_bindings_unittests
Review-Url: https://codereview.chromium.org/2030873002
Cr-Commit-Position: refs/heads/master@{#397961}
Use GetPermissionStatus instead of DesktopNotificationProfileUtil::GetContentSetting
DesktopNotificationProfileUtil::GetContentSetting() will call directly into
HostContentSettingsMap::GetContentSetting() and thus miss some checks in
permission layer.
In this CL DesktopNotificationProfileUtil::GetContentSetting()is removed and all
its call sites are changed to call PermissionManager::GetPermissionStatus().
Review-Url: https://codereview.chromium.org/2020063003
Cr-Commit-Position: refs/heads/master@{#397960}
Convert MimeRegistry to use mojo.
This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.
BUG=577685
Review-Url: https://codereview.chromium.org/2024363002
Cr-Commit-Position: refs/heads/master@{#397959}
Recursively defining custom elements should not lead to redefinition
See https://github.com/whatwg/html/issues/1329
BUG=594918
Review-Url: https://codereview.chromium.org/2029923003
Cr-Commit-Position: refs/heads/master@{#397958}
Mojo: Add a C++-style SharedBuffer API.
Review-Url: https://codereview.chromium.org/2036053002
Cr-Commit-Position: refs/heads/master@{#397957}
Add missing curlies in CocoaDragDropDataProvider
Otherwise the |data_| member is actually static (and causes a static
initializer).
BUG=599585
[email protected]
Review-Url: https://codereview.chromium.org/2039723002
Cr-Commit-Position: refs/heads/master@{#397956}
Validate map keys in C++ Mojo bindings
BUG=616649
TESTED=mojo_public_bindings_unittests
Review-Url: https://codereview.chromium.org/2036623002
Cr-Commit-Position: refs/heads/master@{#397955}
Convert track-webvtt-tc[006,007,011] tests to testharness.js
Cleaning up track-webvtt-tc[006,007,011] tests in
media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
Updated track-webvtt-tc006-cue-identifiers.html and
track-webvtt-tc007-cue-no-id.html to reflect that "-->"
is now allowed in cue identifiers.
Updated track-webvtt-tc011-blank-lines.html to reflect that a
timing line always starts a new cue in absence of a separating line.
BUG=588956
Review-Url: https://codereview.chromium.org/2042613002
Cr-Commit-Position: refs/heads/master@{#397954}
Roll src/third_party/skia/ 863689c3f..401e77cfe (1 commit).
https://chromium.googlesource.com/skia.git/+log/863689c3f468..401e77cfe126
$ git log 863689c3f..401e77cfe --date=short --no-merges --format='%ad %ae %s'
2016-06-05 milko.leporis MIPS32r2: Fix Chromium runtime crash
BUG=130022
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2041693002
Cr-Commit-Position: refs/heads/master@{#397953}
Update GN files w/ changes needed to make sanitizers work.
This is a set of build changes that are needed to make the
sanitizers (and sanitizer bots) work correctly. This change
should have no functional effect on the bots, since none of
the sanitizer bots are using GN yet; a follow-on CL will flip
the bots to GN.
[email protected], [email protected], [email protected]
BUG=605732, 573288
Review-Url: https://codereview.chromium.org/2031903002
Cr-Commit-Position: refs/heads/master@{#397952}
Remove unused constant history::kThumbnailsFilename.
The migration from Thumbnails to Favicons has been done for many years.
BUG=617226
Review-Url: https://codereview.chromium.org/2040553002
Cr-Commit-Position: refs/heads/master@{#397951}
Roll src/third_party/skia/ fa8e40b59..863689c3f (3 commits).
https://chromium.googlesource.com/skia.git/+log/fa8e40b59fb6..863689c3f468
$ git log fa8e40b59..863689c3f --date=short --no-merges --format='%ad %ae %s'
2016-06-05 update-skps Update SKP version
2016-06-04 herb Add the ability to handle premul and swizzle src bitmap data.
2016-06-04 rmistry Test PDFium bot again
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2040793002
Cr-Commit-Position: refs/heads/master@{#397950}
Drop diagnostics reference to out-dated database.
In 2010, the Thumbnails database was migrated to Favicons. The
diagnostics code still refers to Thumbnails. At some point, Thumbnails
has become a directory containing a leveldb. Attempting to open a
directory as a SQLite database fails with SQLITE_CANTOPEN, causing the
diagnostics code to generate red herrings.
Rename the "thumbnails" cases to "favicons". Also add in "Top Sites",
which was missing from the diagnostics code.
BUG=617226
Review-Url: https://codereview.chromium.org/2038933002
Cr-Commit-Position: refs/heads/master@{#397949}
Convert track-webvtt-tc[013-015] tests to testharness.js
Cleaning up track-webvtt-tc[013-015] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2043513002
Cr-Commit-Position: refs/heads/master@{#397948}
[DevTools] Remove unnecessary knowledge about console from core.
BUG=613882
Review-Url: https://codereview.chromium.org/2037593004
Cr-Commit-Position: refs/heads/master@{#397947}
Fix misspelling in signin_screen_handler.cc.
Review-Url: https://codereview.chromium.org/2039633003
Cr-Commit-Position: refs/heads/master@{#397946}
Fix NativePixmap internalformat for testing.
In crrev.com/2037983003 we restricted the combination of allowed BufferFormat
and internalformat to those that are used in the compositor.
We left the wrong pair in one test.
TEST='gl_unittests --gtest_also_run_disabled_tests' on samus
Review-Url: https://codereview.chromium.org/2040753002
Cr-Commit-Position: refs/heads/master@{#397945}
Landing recent QUIC changes until 5/28/2016 16:51 UTC
relnote: Deprecate gfe2_reloadable_flag_quic_max_pacing_rate.
Merge internal change: 122995739
https://codereview.chromium.org/2031653004/
relnote: Makes QuicDispatcher::DeleteSessions virtual. No behavior change.
Merge internal change: 122997673
https://codereview.chromium.org/2029983003/
relnote: Simplify GeneralLossAlgorithm by using shift instead of division. No functional change. Protected by FLAGS_quic_adaptive_loss_recovery.
Merge internal change: 123103252
https://codereview.chromium.org/2034783002/
relnote: Adds a test similar to HpackDecoderTest.HandleHeaderRepresentation to ensure good coverage of SpdyUtils::CopyAndValidateHeaders.
Merge internal change: 123142357
https://codereview.chromium.org/2033163002/
relnote: Add an optimized write path for QUIC. Protected by FLAGS_quic_use_optimized_write_path.
Saves 5% CPU at peak according to uStreamer load test based profiling.
Merge internal change: 123231187
https://codereview.chromium.org/2032123002/
relnote: Disabling FLAGS_quic_reply_to_rej in the test it breaks.
Merge internal change: 123314867
https://codereview.chromium.org/2034853002/
relnote: Change GetOrCreateDynamicStream static stream check to a DCHECK. No functional change. Not flag protected.
std::unordered_map lookups account for 2% of the total GFE CPU, which is ~10%
of the cost of QUIC incoming packet processing today.
Merge internal change: 123317583
https://codereview.chromium.org/2037803002/
relnote: Make QuicCryptoServerStream take a QuQuicServerSessionBase* in the constructor instead of a QuicSession*.
Also changes TestQuicLoasServerSession to extend from QuicServerSessionBase
instead of QuicSpdySession, and in the process change the way the crypto stream
is created.
Merge internal change: 123341876
https://codereview.chromium.org/2036783003/
relnote: Add QuicDispatcher::OnUnauthenticatedPublicHeader() method. No functional change.
Merge internal change: 123375033
https://codereview.chromium.org/2033153003/
relnote: Replaces QUIC's recent_min_rtt implementation in RttStats with a WindowedFilter.
Merge internal change: 123447583
https://codereview.chromium.org/2038883002/
relnote: Fix a QUIC test that had random packet loss, but the expectation was set to no packet loss.
Merge internal change: 123459798
https://codereview.chromium.org/2035963004/
relnote: Rename QuicServerSessionVisitor to QuicServerSessionBase::Visitor. No behavior change.
Merge internal change: 123498171
https://codereview.chromium.org/2041453002/
relnote: Generate server designated connection IDs in a new QuicServerSessionBase::Helper object, owned by the dispatcher, instead of in the crypto stream, to facilitate cheap stateless rejects (which do not have a crypto stream). Protected by FLAGS_quic_dispatcher_creates_id.
Merge internal change: 123500687
https://codereview.chromium.org/2039643002/
relnote: Disable FLAGS_quic_only_one_sending_alarm, since it breaks QUIC time loss detection.
https://codereview.chromium.org/2032343003/
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2037893005
Cr-Commit-Position: refs/heads/master@{#397944}
Convert media-ended*, media-extension* and media-load* tests to testharness.js
Cleaning up media-ended*, media-extension* and media-load* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2043473002
Cr-Commit-Position: refs/heads/master@{#397943}
third_party: Update to version 2 of remote_shell_protocol.
Adds support for maximize and minimize as well as allowing the
client to request that window is made fullscreen.
BUG=549781
[email protected]
Review-Url: https://codereview.chromium.org/2033713004
Cr-Commit-Position: refs/heads/master@{#397942}
SVGFE{Spot,Distant,Point}LightElement can have non-SVGFE*Lighting parent
Replace ASSERT_NOT_REACHED with a return statement. We already
thoroughly check for valid parent type and only notify them if so.
BUG=518649
Review-Url: https://codereview.chromium.org/2031353002
Cr-Commit-Position: refs/heads/master@{#397941}
Link to the Chromium git repo, not the old Blink svn repo, in layout test results.
BUG=617246
Review-Url: https://codereview.chromium.org/2038133002
Cr-Commit-Position: refs/heads/master@{#397940}
Convert track-webvtt-tc[027-029] tests to testharness.js
Cleaning up track-webvtt-tc[027-029] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2030383002
Cr-Commit-Position: refs/heads/master@{#397939}
Updating trunk VERSION from 2759.0 to 2760.0
Cr-Commit-Position: refs/heads/master@{#397938}
ash: Remove "transparent_insets" window state.
This is a revert of 5f04ed74e6ef9ca936c2ed344cd158bed6a7528f.
This is no longer needed for the hybrid window management
mechanisms used by some exo clients.
BUG=604773
TEST=manual
[email protected]
Review-Url: https://codereview.chromium.org/2038293002
Cr-Commit-Position: refs/heads/master@{#397937}
Roll src/third_party/skia/ 7062d01a3..fa8e40b59 (1 commit).
https://chromium.googlesource.com/skia.git/+log/7062d01a338d..fa8e40b59fb6
$ git log 7062d01a3..fa8e40b59 --date=short --no-merges --format='%ad %ae %s'
2016-06-04 rmistry Test PDFium bot
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2037293002
Cr-Commit-Position: refs/heads/master@{#397936}
Select precache resources based on field trial experiment group
Resource manifest will include bitset of the resources to be fetched
based on the fieldtrial experiment id.
BUG=616675
Review-Url: https://codereview.chromium.org/2037523002
Cr-Commit-Position: refs/heads/master@{#397935}
Implement the script parts of custom element upgrade steps.
BUG=594918
Committed: https://crrev.com/ee58801ba1e4a49cc2eea50d970444c7eeff9593
Review-Url: https://codereview.chromium.org/2035623002
Cr-Original-Commit-Position: refs/heads/master@{#397676}
Cr-Commit-Position: refs/heads/master@{#397934}
[GN] Define //ios/{chrome/test,web}:run_all_unittests.
Define source_set targets with ios/{chrome,web}/test/run_all_unittests.cc
to simplify writing new test target using those test runners.
BUG=459705
Review-Url: https://codereview.chromium.org/2037273002
Cr-Commit-Position: refs/heads/master@{#397933}
Update related bug IDs for expected WebGL 2 conformance test failures.
BUG=
TEST=
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2039063002
Cr-Commit-Position: refs/heads/master@{#397932}
DevTools: follow-up to 580337, fix gyp files for uploader.
BUG=580337
TBR=dgozman
NOTRY=true
Review-Url: https://codereview.chromium.org/2038283002
Cr-Commit-Position: refs/heads/master@{#397931}
Roll WebGL 97d0194..ba8c5aa
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/97d0194..ba8c5aa
BUG=
TEST=bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2042593002
Cr-Commit-Position: refs/heads/master@{#397930}
[ChromeDriver] Release chromedriver version 2.22
BUG=
Review-Url: https://codereview.chromium.org/2013333003
Cr-Commit-Position: refs/heads/master@{#397929}
Fix crash in blocked input event warning.
If event does not come from JS, we should enter the context scope.
BUG=617229
Review-Url: https://codereview.chromium.org/2039453003
Cr-Commit-Position: refs/heads/master@{#397928}
Fix Win baselines for r397915
https://chromium.googlesource.com/chromium/src/+/81c0fc6d4
BUG=24826
[email protected]
Review-Url: https://codereview.chromium.org/2040713002
Cr-Commit-Position: refs/heads/master@{#397927}
Fix Win baselines for r397912
https://chromium.googlesource.com/chromium/src/+/59fd991c4
BUG=416535
[email protected]
Review-Url: https://codereview.chromium.org/2041613002
Cr-Commit-Position: refs/heads/master@{#397926}
Update thread-local weak processing comments following r397904.
R=haraken
BUG=611702
NOTRY=true
Review-Url: https://codereview.chromium.org/2040703002
Cr-Commit-Position: refs/heads/master@{#397925}
Correcting doxygen comment of onDownloadCancelled() method.
This change takes care of correcting the parameter comment of
onDownloadCancelled() method.
BUG=
Review-Url: https://codereview.chromium.org/2029973002
Cr-Commit-Position: refs/heads/master@{#397924}
Updated Win10 baselines for SVG shape-rendering tests
svg/custom/use-referencing-nonexisting-symbol.svg
svg/custom/shape-rendering.svg
Baselines are the same as the Win7 ones.
[email protected]
BUG=614063
Review-Url: https://codereview.chromium.org/2036163002
Cr-Commit-Position: refs/heads/master@{#397923}
Make the ResourcePriorities experiment change permanent
The ResourcePriorities change launched to stable through Finch so it can
now be removed and backed into the code.
The launched configuration was (11011_1_1_10) which is the following:
fetchDeferLateScripts true
fetchDeferLateScripts true
fetchIncreaseAsyncScriptPriority false
fetchIncreasePriorities true
fetchEnableLayoutBlockingThreshold true
fetchLayoutBlockingThreshold 1
fetchMaxNumDelayableWhileLayoutBlocking 1
fetchMaxNumDelayableRequests 10
BUG=317785, 517902, 517904, 521744
Review-Url: https://codereview.chromium.org/1936303002
Cr-Commit-Position: refs/heads/master@{#397922}
Impl mus::mojom::GpuService to enable using Chrome IPC version gpu CmdBuf in mus
* Implements mus::mojo::GpuService which allows clients requesting a gpu IPC::ChannelHandle from mus, and then use it to construct GpuChannelHost and CommandBufferProxyImpl.
* Uses the Chrome IPC CmdBuf in mus::GLES2Context.
* Adds --use-chrome-gpu-command-buffer-in-mus flag which is used for switching between mojo CmdBuf and Chrome IPC CmdBuf.
* Tested with ./out/mus_Debug/mojo_runner mojo:mus_demo
Known issues:
* The singleton mus::GpuService doesn't work for component build.
* GpuMemoryBuffer is not implemented. The mash crashes because of it.
BUG=586390
Review-Url: https://codereview.chromium.org/1976703003
Cr-Commit-Position: refs/heads/master@{#397921}
Migrate WaitableEvent to enum-based constructor in chrome/
Change automated with clang-tidy (details @ https://crbug.com/612843#c13)
BUG=612843
Review-Url: https://codereview.chromium.org/2021393004
Cr-Commit-Position: refs/heads/master@{#397920}
Auto-rebaseline for r397915
https://chromium.googlesource.com/chromium/src/+/81c0fc6d4
BUG=24826
[email protected]
Review URL: https://codereview.chromium.org/2042583002 .
Cr-Commit-Position: refs/heads/master@{#397919}
[tracing] Sanitize process memory dump names for background mode
For background mode:
1. ProcessMemoryDump knows the level of detail.
2. It checks for dump name to be present in whitelist. If not then
returns a dummy mad. The strings are stripped of numbers (ids) and
checked against a whitelist of dump names.
3. Disable creating new dumps just to mark suballocations.
4. Disable creation of global allocator dumps.
5. Disable string attributes in allocator dumps.
Also creates a new whitelist file to handle whitelisting logic.
BUG=613198
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2006943003
Cr-Commit-Position: refs/heads/master@{#397918}
Add support for user defined "pool" to GN.
Allow user to define pool of limited size to limit the number of
concurrent tasks that are executed for a given set of tools. The
pool object directly correspond to a ninja pool and can be shared
by multiple targets.
Design document:
https://docs.google.com/document/d/1b598i4WmeFOe3_iRBrjPKSXdcR5R32UPtgxqKmoY2-M/view
BUG=612786
Review-Url: https://codereview.chromium.org/2006923004
Cr-Commit-Position: refs/heads/master@{#397917}
Update V8 to version 5.3.138.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9ceb2d30..b94ab6fc
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2038263003
Cr-Commit-Position: refs/heads/master@{#397916}
Display table header groups at the top of each page
FF, IE and Edge all repeat a table header group at the top of each printed page.
This area is underspecified but after some discussion in the bug we agreed to
repeat the header group if it has break-inside:avoid. We make this the default
style for theads when printing.
BUG=24826
Review-Url: https://codereview.chromium.org/2021703002
Cr-Commit-Position: refs/heads/master@{#397915}
Auto-rebaseline for r397912
https://chromium.googlesource.com/chromium/src/+/59fd991c4
BUG=416535
[email protected]
Review URL: https://codereview.chromium.org/2037263002 .
Cr-Commit-Position: refs/heads/master@{#397914}
Improve CopyTex{Sub}Image2D format validation.
1) Unify the validation code into a helper function.
2) In ES3, for sized formats, the read_format and internal_format's color bits
have to match exactly.
BUG=429053
TEST=gpu_unittests,webgl{2}_conformance
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2029803002
Cr-Commit-Position: refs/heads/master@{#397913}
Invalidate only non-scrolling layers for non-scrolling content.
BUG=416535
Review-Url: https://codereview.chromium.org/2039503002
Cr-Commit-Position: refs/heads/master@{#397912}
MacViewsBrowser: Provide a stub for ChromeExtensionChooserDialog::ShowDialog()
Fixes a MacViewsBrowser link error after r397320, starting at
http://go/macviewsbuilder/builds/11045, like
Undefined symbols for architecture x86_64:
"ChromeExtensionChooserDialog::ShowDialog(ChooserController*) const", referenced from:
ChromeExtensionBluetoothChooser::ChromeExtensionBluetoothChooser
MacViewsBrowser needs a ShowDialog() symbol, which will provide the
toolkit-views implementation when it's ready.
BUG=425229, 613638
[email protected]
Review-Url: https://codereview.chromium.org/2036033003
Cr-Commit-Position: refs/heads/master@{#397911}
Set up background memory light tracing field trials
This CL introduces a BENCHMARK_MEMORY_LIGHT mode for background field
trials to enable memory-infra category in BACKGROUND mode. The
background tracing controller disables the periodic memory dumps and
takes a single memory snapshot when a light preset is passed.
Since the BACKGROUND mode in memory-infra is restricted only to
whitelisted dump providers (currently empty), this tracing mode causes
very low overhead (currently none) on the user experience.
BUG=613198
Review-Url: https://codereview.chromium.org/2034553002
Cr-Commit-Position: refs/heads/master@{#397910}
mash: Move wm_shelf_types.h into shelf_types.h
Cleanup from https://codereview.chromium.org/2036353002/ done separately to
preserve history.
BUG=615155
TEST=compiles
Review-Url: https://codereview.chromium.org/2032253003
Cr-Commit-Position: refs/heads/master@{#397909}
Cleanup: Initialize GURL by moving std::string
Previously it used string::swap, but std::move is more effective in this case.
BUG=367418
TEST=
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/1360533002
Cr-Commit-Position: refs/heads/master@{#397908}
mash: Move ash/common/wm/shelf to ash/common/shelf
* Collapse wm_shelf_constants.h with shelf_constants.h
* Start collapsing wm_shelf_types.h with shelf_types.h. This will be done in
two steps to preserve rename history.
* Move the other files as-is
No functional changes.
BUG=615155
TEST=compiles
Review-Url: https://codereview.chromium.org/2036353002
Cr-Commit-Position: refs/heads/master@{#397907}
Handle all context lost reasons when determining guilt of domain.
This avoids a NOTREACHED() in the previous code. Verified that addition
of new constants without updating the switch statement will cause a
compile failure.
BUG=615113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2029293002
Cr-Commit-Position: refs/heads/master@{#397906}
[tools/perf] Make pages in typical_25 page_set to wait for load event to triggered
BUG=617004
Review-Url: https://codereview.chromium.org/2033813005
Cr-Commit-Position: refs/heads/master@{#397905}
Reset ThreadState weak callback stack before GCing.
In the event a thread gets to participate in more than
one GC before it manages to leave its safe point, clear
out its weak callback stack before initiating a new
GC. Otherwise we risk keeping around weak callbacks to
duplicate or dead objects.
R=
BUG=611702
Review-Url: https://codereview.chromium.org/2036803004
Cr-Commit-Position: refs/heads/master@{#397904}
Updating histogram owners for team changes.
BUG=None
TEST=None
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/1858123002
Cr-Commit-Position: refs/heads/master@{#397903}
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros
Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in mediasource module.
WTF_LOG -> DVLOG
ASSERT -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
BUG=596522
Review-Url: https://codereview.chromium.org/2002073002
Cr-Commit-Position: refs/heads/master@{#397902}
Fix webview crash on attempt to scroll.
This fixes crash of webview when its content is scrolled using
2-fingers gesture via touchpad or using touchscreen.
BUG=615512
TEST=Manually on device using Arc++ OptIn UI, ToS is scrolled
as expected using touchscreen or touchpad, no crashes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2015373002
Cr-Commit-Position: refs/heads/master@{#397901}
[Payments] Add ability to show additional text for OptionSections
* Add ability to display additional text above the PaymentOption
lists.
* Shipping address section now has the option to display text
saying that the user needs to select a shipping address to
update the shipping options.
* Optional shipping address section text disappears once the
user selects an option.
BUG=603635
Review-Url: https://codereview.chromium.org/2040623002
Cr-Commit-Position: refs/heads/master@{#397900}
Add CertIssuerSource interface and CertIssuerSourceStatic implementation.
The CertIssuerSource interface will provide an abstraction for the path builder to
lookup issuers without needing to know the details of how.
CertIssuerSourceStatic is a simple implementation useful for providing a fixed set,
for example the certs received during the TLS handshake.
BUG=410574
Review-Url: https://codereview.chromium.org/2030693002
Cr-Commit-Position: refs/heads/master@{#397899}
Roll src/third_party/skia/ 862dae548..7062d01a3 (1 commit).
https://chromium.googlesource.com/skia.git/+log/862dae548a8e..7062d01a338d
$ git log 862dae548..7062d01a3 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 bungeman More Unref GrXPFactory.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2043463003
Cr-Commit-Position: refs/heads/master@{#397898}
StreamTextureImages can now override a Texture's service id
Previously Textures could have an unowned service id, which is used in
place of their service id, except that its lifetime is managed
externally. The use case this is AVDACodecImages, which use a single
SurfaceTexture to back multiple Textures.
This change more explicitly ties the unowned service id concept to
StreamTextureImages, and makes it possible to have StreamTextureImages
own the lifetime of the unowned service id (now called the stream
texture service id), by resetting the service id back to its original
value if a non-StreamTextureImage is bound. If this were not done and a
new image was bound to a level that previously had a
StreamTextureImage, the service id would still be the unowned stream
texture service id, but the StreamTextureImage would be deleted. That
meant it was previously not possible for StreamTextureImages to own the
lifetime of the unowned service id without possibly leaving the
Texture in an invalid state.
Now we can have multiple AVDACodecImages, bound to different Textures,
share a SurfaceTexture service id and safely delete the texture when all
of the AVDACodecImages are destructed.
This CL also adds Texture::SetLevelImageState for setting only the
ImageState and not changing the bound image.
BUG=614090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2014313002
Cr-Commit-Position: refs/heads/master@{#397897}
Updating trunk VERSION from 2758.0 to 2759.0
Cr-Commit-Position: refs/heads/master@{#397896}
[DevTools] Remove obsolete methods from V8InjectedScriptHost
BUG=595206
[email protected]
Review-Url: https://codereview.chromium.org/2043453002
Cr-Commit-Position: refs/heads/master@{#397895}
Process HTTP/2 ALTSVC frames.
BUG=617177
Review-Url: https://codereview.chromium.org/2031373002
Cr-Commit-Position: refs/heads/master@{#397894}
[Payments] Partially refactor the PaymentRequestUI
Recombine the two XML layouts and add logic for adjusting them,
depending on what we're displaying.
BUG=603635
Review-Url: https://codereview.chromium.org/2041483002
Cr-Commit-Position: refs/heads/master@{#397893}
Implement cc::Selection<gfx::SelectionBound> StructTraits
BUG=611802
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2041503002
Cr-Commit-Position: refs/heads/master@{#397892}
ServiceWorker: Fix the argument of ctor of Response
The first argument to Response constructor should be the body while
currently passing the header. This patch fixed it and updated the
pageset.
BUG=614985
Review-Url: https://codereview.chromium.org/2032893003
Cr-Commit-Position: refs/heads/master@{#397891}
Roll src/third_party/catapult/ 71d985b3c..be4159a15 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/71d985b3c851..be4159a15b3e
$ git log 71d985b3c..be4159a15 --date=short --no-merges --format='%ad %ae %s'
BUG=613706
[email protected]
Review-Url: https://codereview.chromium.org/2035133004
Cr-Commit-Position: refs/heads/master@{#397890}
Roll src/third_party/skia/ 69df02062..862dae548 (1 commit).
https://chromium.googlesource.com/skia.git/+log/69df0206252c..862dae548a8e
$ git log 69df02062..862dae548 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 robertphillips Add ability to rotate light direction in drawLitAtlas Sample slide
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2034843005
Cr-Commit-Position: refs/heads/master@{#397889}
Refactor scroll updates during flexbox layout.
When there are nested flexboxes, the current code does some O(N^2)
work to update scrolling information after flexing has finished. This
change streamlines the process for performing flex layout and updating
scrollbars into three distinct phases, controlled by the highest-level
flexbox in the layout tree:
1. Perform flex layout on descendants; any blocks with overflow:auto
scrollbars may add/remove scrollbars, but they will not run the normal
second-pass layout after changing scrollbars, and they will not clamp
their existing scroll positions.
2. If, during the first pass, any descendant added or removed
scrollbars, run a second flex layout pass, but don't allow any
descendants to add or remove scrollbars.
3. After the second pass, go through and clamp the scroll positions
on all scrolling descendants.
BUG=593209,600036
Review-Url: https://codereview.chromium.org/1930183002
Cr-Commit-Position: refs/heads/master@{#397888}
[DevTools] Improve MainThreadDebugger::memoryInfo
Use context->Global() instead of CreationContext in MainThreadDebugger::memoryInfo.
BUG=616225
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2034203002
Cr-Commit-Position: refs/heads/master@{#397887}
MessagePumpForGpu - reduce potential work starvation
MessagePumpForGpu has been on Canary for a few days and I
am still assessing whether it is better than standard
MessagePumpForUI in terms of reducing [GPU hang] crashes.
While it has eliminated hangs with some signatures the
rate of hangs in WaitForWork has increased.
When experimenting with MsgWaitForMultipleObjectsEx I
realized that it favors messages over events - when an
event is signaled and a message is available in the queue
it returns a result that indicates a message even when
the message doesn't belong to a current thread (e.g. a
browser UI message). With a high volume of messages it
might be possible for WaitForWork to keep looping and
starve the work processing. It is possible with Direct
Composition where some of UI input messages have to go
through the GPU process message loop because its D3D
surface window covers the entire browser window.
The fix is to do an additional check for the event. Please
note that this is a much less common code path so this
shouldn't affect performance much in scenarios like
video playback. Also I've added some diagnostics code to
help with crash dump analysis.
BUG=588798,596190
Review-Url: https://codereview.chromium.org/2036603002
Cr-Commit-Position: refs/heads/master@{#397886}
[Android] Roll the NDK to r11c.
Also rolls breakpad to pick up an NDK fix.
BUG=599327
Review-Url: https://codereview.chromium.org/1991343002
Cr-Commit-Position: refs/heads/master@{#397885}
Revert of Enable per thread heap for database thread (patchset #12 id:220001 of https://codereview.chromium.org/1909813002/ )
Reason for revert:
This CL is causing a top #1 crasher.
https://bugs.chromium.org/p/chromium/issues/detail?id=617141
Original issue's description:
> Enable per thread heap for database thread
>
> BUG=591606
>
> Committed: https://crrev.com/993e3a74102e0843bebb2f52de1a904f151843d4
> Cr-Commit-Position: refs/heads/master@{#397383}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=591606
Review-Url: https://codereview.chromium.org/2037233002
Cr-Commit-Position: refs/heads/master@{#397884}
DevTools: split protocol.json into files per domain.
BUG=580337
NOTRY=true
Review-Url: https://codereview.chromium.org/2035653005
Cr-Commit-Position: refs/heads/master@{#397883}
Make click targets inside links work.
There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
[email protected]
Review-Url: https://codereview.chromium.org/2043433002
Cr-Commit-Position: refs/heads/master@{#397882}
[ios] Cleanup resource bundle in WebTestSuite::Shutdown.
BUG=None
Review-Url: https://codereview.chromium.org/2037763002
Cr-Commit-Position: refs/heads/master@{#397881}
[Mac/GN] Implement dSYM generation and stripping.
This creates a new script called the linker driver, which runs all three
steps of linking: the image link, debug info link, and stripping. In GYP,
the last two steps were handled as postbuilds, but GN lacks those. Instead,
the linker driver performs all three operations in one build step.
BUG=330301,431177
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/1999513002
Cr-Commit-Position: refs/heads/master@{#397880}
[Chromecast] Fix small typo in Playready codepath
This wasn't caught because it's not compiled by default.
BUG=
Review-Url: https://codereview.chromium.org/2037213003
Cr-Commit-Position: refs/heads/master@{#397879}
gl: Add reveman as an owner for gl/test/*gl_image*.
Review-Url: https://codereview.chromium.org/2034303003
Cr-Commit-Position: refs/heads/master@{#397878}
Switch to currentTimeMillis, persist task
Since we are persisting our GCM Network Manager task across reboots,
we need to switch to a type of time that will work reliably across
reboots.
We consisered SystemClock.elapsedRealtime, but we think that bad UMA
samples will be more likely from reboots than the user adjusting
wall clock time.
BUG=612325
Review-Url: https://codereview.chromium.org/2037213002
Cr-Commit-Position: refs/heads/master@{#397877}
gl: Check format is valid given an internal format.
GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.
This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).
TEST='gl_unittests --gtest_also_run_disabled_tests' on samus
Review-Url: https://codereview.chromium.org/2037983003
Cr-Commit-Position: refs/heads/master@{#397876}
Update V8 to version 5.3.137.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a352c80b..9ceb2d30
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2036273003
Cr-Commit-Position: refs/heads/master@{#397875}
sync compositor: Remove begin frame source
Share the same BeginFrameSource implementation with chrome.
The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.
Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.
This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.
BUG=609977
Review-Url: https://codereview.chromium.org/1969263004
Cr-Commit-Position: refs/heads/master@{#397874}
Initialize stub platform window bounds to those of its mus::Window.
Fixes a regression from https://codereview.chromium.org/2009853002
IDK why it matters or if it relates to [still] broken window dragging.
TODO: Fix wallpaper picker dragging (not broken by same CL)...
BUG=557405
TEST=wallpaper picker shows for "Set wallpaper..." in mash.
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2037013003
Cr-Commit-Position: refs/heads/master@{#397873}
[Offline Pages] Fix crash due to table inconsistency.
Adding logic to add a column if there wasn't one when upgrading.
BUG=615549
Review-Url: https://codereview.chromium.org/2019333008
Cr-Commit-Position: refs/heads/master@{#397872}
Move //components/ui/zoom to top-level under //components
There is no pattern in //components of organizing individual
components by logical module. This patch moved
//components/ui/zoom to top-level under //components.
BUG=615568
Review-Url: https://codereview.chromium.org/2019423005
Cr-Commit-Position: refs/heads/master@{#397871}
Add slide in/slide out transition for Herb CCTs
BUG=613685
Review-Url: https://codereview.chromium.org/2037223002
Cr-Commit-Position: refs/heads/master@{#397870}
Replace frame-src with child-src in WebUI CSP
"frame-src" is deprecated, and is replaced by "child-src".
BUG=81636, 336788
Review-Url: https://codereview.chromium.org/2012393003
Cr-Commit-Position: refs/heads/master@{#397869}
Prefer device type instead of machine name for scale factor overrides.
This will make the Maps test work on Android bots on the commit queue.
BUG=616297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2037933003
Cr-Commit-Position: refs/heads/master@{#397868}
Add 'total' field to 'PaymentDetails'.
This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:
* 'total' is required.
* 'total.value' cannot start with '-'.
* Undefined and empty 'displayItems' are OK.
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f
This patch also removes the no-longer-used 'id' from display items in
several tests.
BUG=616568
Review-Url: https://codereview.chromium.org/2030193002
Cr-Commit-Position: refs/heads/master@{#397867}
Add a debug view to the browser that allows various navigation features to be used.
Adds a simple Interstitial API.
[email protected]
Review-Url: https://codereview.chromium.org/2039613002
Cr-Commit-Position: refs/heads/master@{#397866}
Remove FilePath usage from the CrashReporterClient interface on Windows.
The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.
Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.
I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.
The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient
BUG=604923
Review-Url: https://codereview.chromium.org/2031833002
Cr-Commit-Position: refs/heads/master@{#397865}
Roll src/third_party/boringssl/src bbd43b5e9..0fc7df55c
https://boringssl.googlesource.com/boringssl/+log/bbd43b5e90c073a3c8b719d538a273fe683b9944..0fc7df55c04e439e765c32a4dd93e43387fe40be
[email protected]
BUG=none
Review-Url: https://codereview.chromium.org/2034043003
Cr-Commit-Position: refs/heads/master@{#397864}
Add new ParsedCertificate class, move TrustStore to own file.
This consolidates the certificate parsing from various places in
verify_certificate_chain.cc into a single class that pre-parses all the
important information.
The relevant places are all changed to use the new ParsedCertificate
class, and TrustStore is separated into its own file.
BUG=410574
Review-Url: https://codereview.chromium.org/1976433002
Cr-Commit-Position: refs/heads/master@{#397863}
Roll src/third_party/catapult/ ccb73566f..71d985b3c (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ccb73566fef2..71d985b3c851
$ git log ccb73566f..71d985b3c --date=short --no-merges --format='%ad %ae %s'
BUG=546021,616832
[email protected]
Review-Url: https://codereview.chromium.org/2039653002
Cr-Commit-Position: refs/heads/master@{#397862}
Fix wtf::PairHashTraits to support types with isEmptyValue.
Types such as RefPtr<P> provide a custom isEmptyValue function in their
HashTraits. This fixes the std::pair HashTraits to support using such
types in a std::pair.
Review-Url: https://codereview.chromium.org/2042453002
Cr-Commit-Position: refs/heads/master@{#397861}
Make ChromeVox cursor robust to deleted nodes
If a node becomes invalid, the cursor snaps to the nearest valid ancestor.
Fixing this uncovered a lot of places where we were assuming that a cursor's
node must be valid, but it's possible that even with this new check that
a cursor could still be invalid, so I added checks in a lot of places.
BUG=613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2007183002
Cr-Commit-Position: refs/heads/master@{#397860}
Revert of Mark some AwContentsClientFullScreenTest tests flaky. (patchset #2 id:20001 of https://codereview.chromium.org/2011453002/ )
Reason for revert:
Avoid disabling these tests on CQ
Original issue's description:
> Mark some AwContentsClientFullScreenTest tests flaky.
>
> BUG=614318
>
> Committed: https://crrev.com/22a7f8467da532e4ab9f07256de4a11e93888341
> Cr-Commit-Position: refs/heads/master@{#395588}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=614318
Review-Url: https://codereview.chromium.org/2039463004
Cr-Commit-Position: refs/heads/master@{#397859}
Remove ListValue::Append(new {Fundamental,String}Value(...)) usage in //chrome (part 2)
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
This wasn't included in the original CL because the clang tool got
confused when processing this file. It turns out true and false can be
macros!
BUG=581865
Review-Url: https://codereview.chromium.org/2041513002
Cr-Commit-Position: refs/heads/master@{#397858}
Make NativePixmap unittests use TEXTURE_EXTERNAL_OES.
NativePixmap unittests were incorrectly using TEXTURE_2D target.
TEST='gl_unittests --gtest_also_run_disabled_tests' on samus
Review-Url: https://codereview.chromium.org/2038133004
Cr-Commit-Position: refs/heads/master@{#397857}
Enable RTCVideoDecoder SW H264 fallback only when it is available
Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.
BUG=615513
Review-Url: https://codereview.chromium.org/2024303003
Cr-Commit-Position: refs/heads/master@{#397856}
Replace cc::ViewportSelectionBound with ui::SelectionBound
We'd like to be able to fully serialize CompositorFrames over
mojo. CompositorFrameMetadata has a
cc::ViewportSelection(Bound), which closely resembles
gfx::SelectionBound. This CL works towards unifying these
structs to reduce code duplication.
BUG=611802
TBR=piman@ for content changes.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2030033003
Cr-Commit-Position: refs/heads/master@{#397855}
Makes mojo:ash resources include ash/resources
The combined wm/shell now needs ash/resources too.
BUG=616265
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2039633002
Cr-Commit-Position: refs/heads/master@{#397854}
Launch WebAPK if notification opens URL within WebAPK scope
BUG=609122
Review-Url: https://codereview.chromium.org/2010633004
Cr-Commit-Position: refs/heads/master@{#397853}
Roll src/third_party/skia/ adf5afa62..69df02062 (6 commits).
https://chromium.googlesource.com/skia.git/+log/adf5afa628ad..69df0206252c
$ git log adf5afa62..69df02062 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 bungeman Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR.
2016-06-03 bungeman Unref GrXPFactory.
2016-06-03 cblume SkMipMap::ComputeLevelSize to return SkISize
2016-06-03 csmartdalton Don't use complex blend mode for shapes gm
2016-06-03 cblume Plumbing mipmaps to the point of creation.
2016-06-03 robertphillips Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack
BUG=578304,578304
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2032133004
Cr-Commit-Position: refs/heads/master@{#397852}
Use hasRareData() rather than null-checking elementRareData().
[email protected],[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2010683002
Cr-Commit-Position: refs/heads/master@{#397851}
Add smoke test for UsbService::GetDevices.
This test initializes the USB service and calls GetDevices() to exercise
the native USB device enumeration path on all platforms. Since we cannot
guarantee that a particular piece of hardware is connected the result
of this call is not checked. Tested enabled by --enable-gadget-tests
provide deeper converage when matching hardware is available.
BUG=None
Review-Url: https://codereview.chromium.org/2032303003
Cr-Commit-Position: refs/heads/master@{#397850}
Check Android version before calling UsbInterface.getAlternateSetting()
This method (and support for alternate interface settings in general)
was only added in API level 21. We must assume that only the default
alternate interface will be reported in older API levels.
BUG=617032
Review-Url: https://codereview.chromium.org/2041553002
Cr-Commit-Position: refs/heads/master@{#397849}
Getting rid of ChromeLauncherController::model().
Also updating comments/error output:
BrowserLauncherItemController -> BrowserShortcutLauncherItemController.
BUG=NONE
Review-Url: https://codereview.chromium.org/2039543002
Cr-Commit-Position: refs/heads/master@{#397848}
Mac: Make ScopedTypeRef require explicit constructors
Style guide requires explicit constructors.
Prior to this patch, a T* can be passed into a function that requires
a scoped_nsobject<T>, and the object will be released but not retained.
Also make the copy constructor that takes a different typename more
generic, allowing for different types (e.g, subclasses) in addition to
different traits.
Clean up all instances where we relied on this behavior.
BUG=
Review-Url: https://codereview.chromium.org/2028823003
Cr-Commit-Position: refs/heads/master@{#397847}
Fix use-before-new issue in TestCastSocket.
A reference to capturing_net_log_ was passed into the base class constructor
and used before it was fully initialized. For the derived class the initialization
of the members happens stronly after the base constructors completed.
This fixes a bug found by UBSan Vptr.
BUG=617206
Review-Url: https://codereview.chromium.org/2042493002
Cr-Commit-Position: refs/heads/master@{#397846}
Move document.visualViewport to window.visualViewport
The `window` object is a more natural place for the visualViewport API. The
original concern was causing breaking changes since this would clash with any
variable in the global scrope called `visualViewport` but a search through
httpArchive found that this is unlikely to be an issue.
BUG=595826
Review-Url: https://codereview.chromium.org/2025393003
Cr-Commit-Position: refs/heads/master@{#397845}
Add Expect-Staple to preload list
BUG=598021
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/2034843003 .
Cr-Commit-Position: refs/heads/master@{#397844}
Rename InkDropHover to InkDropHighlight
Most uses of "hover" become "highlight", but SetHovered still refers to
the logical state of mouse hover so that remains unaltered.
BUG=none
Review-Url: https://codereview.chromium.org/2034963002
Cr-Commit-Position: refs/heads/master@{#397843}
MD Site Settings: Implement the third-party checkbox for Cookies.
BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2031833003
Cr-Commit-Position: refs/heads/master@{#397842}
sync compositor: Remove sync input path
Remove kSyncInputForSyncCompositor switch and all code behind it. M51
shipped without it and looks fine, so remove all the code.
BUG=545628
Review-Url: https://codereview.chromium.org/1974133002
Cr-Commit-Position: refs/heads/master@{#397841}
Re-enable AppMenuTest#testChangingOrientationHidesMenu()
BUG=458193
Review-Url: https://codereview.chromium.org/2033883002
Cr-Commit-Position: refs/heads/master@{#397840}
Move GL one-off initialization code.
Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.
This change is part of step two from the associated bug.
BUG=611142
Review-Url: https://codereview.chromium.org/2024953002
Cr-Commit-Position: refs/heads/master@{#397839}
[libfuzzer] remove icu fuzzers (moved to //third_party/icu/fuzzers).
(Counterpart to https://codereview.chromium.org/1995823002)
BUG=539572
Review-Url: https://codereview.chromium.org/1995833002
Cr-Commit-Position: refs/heads/master@{#397838}
Make it so chrome manifests are built if aura is set
This way a clean built of mash:all and chrome results in opening
chrome.
BUG=none
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2034263002
Cr-Commit-Position: refs/heads/master@{#397837}
Auto-rebaseline for r397799
https://chromium.googlesource.com/chromium/src/+/28307938a
BUG=465096
[email protected]
Review URL: https://codereview.chromium.org/2037933004 .
Cr-Commit-Position: refs/heads/master@{#397836}
Auto-rebaseline for r397752
https://chromium.googlesource.com/chromium/src/+/91e2b1e30
BUG=333011
[email protected]
Review URL: https://codereview.chromium.org/2036203006 .
Cr-Commit-Position: refs/heads/master@{#397835}
Add Static Initializer for leak detector TLS
This is optional for running leak detector on browser process, but later
it will be necessary to run on renderer process. By initializing the
pthread TLS system early, we avoid initializing it from within an alloc
hook function, in which case it would go into a recursive call loop.
BUG=chromium:615223
Review-Url: https://codereview.chromium.org/2023133003
Cr-Commit-Position: refs/heads/master@{#397834}
Use int32_t for duration property of toast
To match it with the API. Android and mojo API use 32bit int for this property.
BUG=none
Review-Url: https://codereview.chromium.org/2031973003
Cr-Commit-Position: refs/heads/master@{#397833}
Prevent renderer kills for in-page navigations on subframes.
This switches HistoryController and HistoryEntry to look at the last
committed WebHistoryItem for a frame rather than assuming that the
whole HistoryEntry accurately reflects the state of the page. The
previous logic led to NC_IN_PAGE_NAVIGATION renderer kills when going
back cross-site in ways that looked in-page to the HistoryEntry.
This CL does not yet fix the kills that happen in FrameNavigationEntry
modes, which are covered by the BackTwiceToIframeWithContent test.
Those will be fixed in a follow-up CL.
BUG=612713
TEST=Fewer NC_IN_PAGE_NAVIGATION kills.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2023013002
Cr-Commit-Position: refs/heads/master@{#397832}
[Chromecast] Log playback stall event.
BUG=internal b/26496758
Review-Url: https://codereview.chromium.org/2032813002
Cr-Commit-Position: refs/heads/master@{#397831}
[Mac/GN] Include WidevineCdm for Chrome builds.
BUG=615486
[email protected]
Review-Url: https://codereview.chromium.org/2033923002
Cr-Commit-Position: refs/heads/master@{#397830}
Fix ResumableTCPSocket destruction.
ResumableTCPSocket sets a read_callback_ that points to
TCPSocketEventDispatcher::ReadCallback. This callback gets called
from ~TCPSocket, when ~ResumableTCPSocket already completed,
and it calls ResumableTCPSocket methods (which are already illegal to call).
The fix just calls Disconnect from ~ResumableTCPSocket which clears the
callback and all the state that relies on ResumableTCPSocket members.
This fixes a bug found with UBSan Vptr.
BUG=617199
Review-Url: https://codereview.chromium.org/2034233002
Cr-Commit-Position: refs/heads/master@{#397829}
Moving VR service from /content/browser to /device
BUG=612342
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2029703002
Cr-Commit-Position: refs/heads/master@{#397828}
[Chromecast] Make EME persistent license support optional
The recent refactoring from KeySystemsInfo meant we lost the option
to control whether persistent license support is enabled (see linked
bug). Add the option back into the new system.
BUG=internal b/28844432
Review-Url: https://codereview.chromium.org/2032923002
Cr-Commit-Position: refs/heads/master@{#397827}
Remove NTP Favicon flag.
BUG=none
Review-Url: https://codereview.chromium.org/2025153002
Cr-Commit-Position: refs/heads/master@{#397826}
Refactor accessible focus ring code so the layers are animation observers.
I'd like to make more of the focus ring layers animate, so it will be
simpler if the layers are animation observers and keep track of their own
compositor, rather than storing them all in AccessibilityFocusRingController.
I'm assuming it's not too expensive to have OnAnimationStep() called for a
layer that doesn't need to animate all the time. If that's not true, this
refactoring would make it easier to add StartAnimating and StopAnimating
methods to FocusRingLayer for better efficiency.
BUG=314889
Review-Url: https://codereview.chromium.org/2038093003
Cr-Commit-Position: refs/heads/master@{#397825}
Support tooltips in GuestViews with "--use-cross-process-frames-for-guests" flag.
This was just a matter of plumbing the text to the right place.
BUG=609932
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2041493002
Cr-Commit-Position: refs/heads/master@{#397824}
Suppress -Wnonportable-include-path on clang tot bots
BUG=617318
[email protected]
Review URL: https://codereview.chromium.org/2040533003 .
Cr-Commit-Position: refs/heads/master@{#397823}
Fixed interactive ui test regression
BUG=617056
Review-Url: https://codereview.chromium.org/2034893003
Cr-Commit-Position: refs/heads/master@{#397822}
Add bug number for http/tests/security/frameNavigation/not-opener.html in site-per-process
BUG=617288
NOTRY=true
Review-Url: https://codereview.chromium.org/2037773004
Cr-Commit-Position: refs/heads/master@{#397821}
Shuffles and renames ash/common/wm classes
WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.
BUG=616265
TEST=none
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2035543004
Cr-Commit-Position: refs/heads/master@{#397820}
Add five new top level categories and corresponding entries on the Site Details page.
Automatic downloads
Background sync
Key generation
Plugins
Unsandboxed plugin access
Also changed it so that, in JS land, the Category variable is a string, because the enum value of the ContentSettingsTypes is variable depending on platform, so we don't want to be hardcoding those in JS. This is similar to the Allow/Block values (the PermissionValues enum), which used to be ints, but are now converted int <-> string on the JS/C++ boundary.
TBR=sky
BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2021343003
Cr-Commit-Position: refs/heads/master@{#397819}
Remove IDS_WEBSITE_SETTINGS_{MALWARE,PHISHING} since they're unused.
[email protected]
Review-Url: https://codereview.chromium.org/2036133003
Cr-Commit-Position: refs/heads/master@{#397818}
mac/gn: Add tests to media_unittests missing in gn build.
BUG=431177
Review-Url: https://codereview.chromium.org/2033893006
Cr-Commit-Position: refs/heads/master@{#397817}
Enable CSP on more WebUI pages
Overriding ShouldAddContentSecurityPolicy() to disable CSP is considered
a bug. Enabling CSP while overriding GetContentSecurityPolicyScriptSrc()
to have relaxed rule is better.
BUG=81636
Review-Url: https://codereview.chromium.org/2003963004
Cr-Commit-Position: refs/heads/master@{#397816}
Show dropdown button in download shelf items for malicious DLs.
Dangerous ones still don't show the button.
This was an oversight concerning the difference between malicious and
dangerous.
BUG=616615
Review-Url: https://codereview.chromium.org/2029363002
Cr-Commit-Position: refs/heads/master@{#397815}
Update V8 to version 5.3.135.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9cdf7a6f..a352c80b
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2038093004
Cr-Commit-Position: refs/heads/master@{#397814}
[libfuzzer] roll icu to ffa4b6704cf5cc9fec9485731f24a05b2ba94bca
Has only one libfuzzer-related change:
ffa4b67 [libfuzzer] adding //base to more targets.
No changes to the library.
BUG=
Review-Url: https://codereview.chromium.org/2030763003
Cr-Commit-Position: refs/heads/master@{#397813}
Implement cc::SharedQuadState StructTraits
BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2032643002
Cr-Commit-Position: refs/heads/master@{#397812}
Mojo C++ bindings: handle double peer endpoint closed event for the same endpoint.
BUG=None
Review-Url: https://codereview.chromium.org/2037793003
Cr-Commit-Position: refs/heads/master@{#397811}
asan/win: Unbreak build after https://codereview.chromium.org/2008553007/
..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(20,11):
error: unused variable 'kIterations' [-Werror,-Wunused-const-variable]
const int kIterations = 20;
^
..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(21,11):
error: unused variable 'kSizeBig' [-Werror,-Wunused-const-variable]
const int kSizeBig = 200 * 1024 * 1024 / sizeof(int); // 200MB
^
BUG=82385
TBR=huangs
Review-Url: https://codereview.chromium.org/2036393002
Cr-Commit-Position: refs/heads/master@{#397810}
Enable two webgl2 conformance tests.
BUG=617290
TEST=gpu bots
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2032063004
Cr-Commit-Position: refs/heads/master@{#397809}
Add a policy for disabling the stripping of PAC URLs.
The default is to strip https:// URLs before submitting them to PAC scripts.
This CL introduces the policy "PacHttpsUrlStrippingEnabled" for disabling this security feature.
Setting the policy to "false" causes Chrome to no longer strip https:// URLs before sending them to PAC scripts. This applies to all profiles, and all PAC scripts (including those discovered through WPAD, and those delivered over an insecure transport).
The intent of this policy is to help enterprises with a compatibility problem transition.
BUG=616396
[email protected]
Review-Url: https://codereview.chromium.org/2030193004
Cr-Commit-Position: refs/heads/master@{#397808}
Implement WebContents.downloadImage() on Java side
This CL bridges the native WebContents::DownloadImage to Java. We are planning to use the method for fetching artwork images (WIP) in MediaMetadata and show them in Android media notification.
Related CLs:
https://codereview.chromium.org/2013813002/
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2009243002/ (most relevant one)
BUG=616411
Review-Url: https://codereview.chromium.org/2014553002
Cr-Commit-Position: refs/heads/master@{#397807}
[Offline Pages] Removing client in storage manager.
Removing OfflinePageStorageManager::Client and merging into
OfflinePageModel. Also fixed some related minor issues and tests.
BUG=615165
Review-Url: https://codereview.chromium.org/2026843003
Cr-Commit-Position: refs/heads/master@{#397806}
Fix color of looking glass when searching on remote NTP.
BUG=616191
Review-Url: https://codereview.chromium.org/2028933002
Cr-Commit-Position: refs/heads/master@{#397805}
Delete bad baselines
BUG=616485
Review-Url: https://codereview.chromium.org/2035743003
Cr-Commit-Position: refs/heads/master@{#397804}
Don't call WebCacheManager::Remove(RPH_id) to clear webview's cache.
We already call WebCacheManager::ClearCacheForProcess(RPH_id), which
seems to be sufficient in my local testing.
I remember that clearing webview cache didn't seem to work without calling
WCM::Remove() when I implemented it.
After r380598, Calling WCM::Remove also deletes mojo service associated
with the RPH, so the next call to WCM::Remove with the same RPH will
result in a nullptr access.
BUG=615429
Test=Added a test, see http://crbug.com/615429#c2 for repro.
Review-Url: https://codereview.chromium.org/2033993002
Cr-Commit-Position: refs/heads/master@{#397803}
Reland of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2038613003/ )
Reason for revert:
As expected, didn't stop the crashes =)
Original issue's description:
> Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2025103003/ )
>
> Reason for revert:
> Speculatively reverting to fix release-blocking crash.
>
> Original issue's description:
> > ExtensionFunction: don't pass ownership of base::Value by raw pointer.
> >
> > BUG=581865
> > [email protected]
> > [email protected]
> >
> > Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79
> > Cr-Commit-Position: refs/heads/master@{#397284}
>
> [email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=581865
>
> Committed: https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f
> Cr-Commit-Position: refs/heads/master@{#397533}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865
Review-Url: https://codereview.chromium.org/2038083004
Cr-Commit-Position: refs/heads/master@{#397802}
MacViews: Implemented Drag & Drop
Created a Drag & Drop client on Mac that bridges between the Views
and native OSX's drag and drop. This approach is based on the Aura
approach.
BUG=599585
TEST= Run the view unit test: DragDropClientMacTest
Review-Url: https://codereview.chromium.org/1964283002
Cr-Commit-Position: refs/heads/master@{#397801}
Fix value_cleanup to handle cases where arg_expr is a macro.
Apparently true and false are macros!
BUG=581865
[email protected]
Review URL: https://codereview.chromium.org/2036413003 .
Cr-Commit-Position: refs/heads/master@{#397800}
Percent height content should respect the fixed height of its containing cell
Reland: https://codereview.chromium.org/992483002
When an element in a cell has a percent height and the cell has a fixed height we
currently let the element ignore the height on the cell and instead let its content
determine the height of the cell (and the row).
Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.
https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html
BUG=465096,468699
Review-Url: https://codereview.chromium.org/2037783002
Cr-Commit-Position: refs/heads/master@{#397799}
Removing the sas.dll dependency from the Chromoting MSI
The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS). Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this. Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.
Removing this dependency also cleans up our code and reduces our pacakge size.
I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.
BUG=606385
Review-Url: https://codereview.chromium.org/2033683003
Cr-Commit-Position: refs/heads/master@{#397798}
[libfuzzer] content/renderer fuzzer.
BUG=539572
Review-Url: https://codereview.chromium.org/2029323005
Cr-Commit-Position: refs/heads/master@{#397797}
Chrome OS highlighting: show only focus or caret, never both.
When the text caret is visible, show that highlight, otherwise if something
has focus, show the focus highlight - never both since they too often
overlap.
BUG=314889
Review-Url: https://codereview.chromium.org/2036343003
Cr-Commit-Position: refs/heads/master@{#397796}
Exclude failing tests on DrMemory bot.
BUG=616837,617268
[email protected]
Review URL: https://codereview.chromium.org/2032613009 .
Cr-Commit-Position: refs/heads/master@{#397795}
SkFontConfigInterface createTypeface to makeTypeface.
The createTypeface method (which returned a bare pointer to a reference
counted object) is being replaced with makeTypeface (which returns a
smart pointer to a reference counted object). This removes some manual
reference counting in Chromium and allows for removing the deprecated
createTypeface method.
Review-Url: https://codereview.chromium.org/2037133002
Cr-Commit-Position: refs/heads/master@{#397794}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2037933002
Cr-Commit-Position: refs/heads/master@{#397793}
[Media Router WebUI] Rename close route event in html
The event name used in media_router_container.html for closing routes
was not renamed by the previous change.
BUG=614144
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2036383002
Cr-Commit-Position: refs/heads/master@{#397792}
exo: Remove support for scaler interface from wayland bindings.
This is no longer used and has been replaced by the viewporter
interface.
BUG=549781
Review-Url: https://codereview.chromium.org/2030023003
Cr-Commit-Position: refs/heads/master@{#397791}
Fix a bug with the Chrome legacy window at times becoming a top level window with a non functional button in the taskbar.
This bug typically occurs if the legacy window stays around after it is
removed from the original root window.
It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.
Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.
BUG=616410
Review-Url: https://codereview.chromium.org/2031213002
Cr-Commit-Position: refs/heads/master@{#397790}
[Layout API] Introduce Layout API shim and use in LayerClipRecorderTest.cpp
There are a few final obstacles to removing Document::layoutView() and
FrameView::layoutView(), and they require the use of a shim to bust
through the block layout API. In LayerClipRecorderTest, it gets a
reference to the document's layout view and later passes it to
LayoutObjectDrawingRecorder::useCachedDrawingIfPossible, which in turn
passes it to DrawingRecorder::useCachedDrawingIfPossible, which is
defined in platform/ and can not have a hard dependency on the block
layout API.
BUG=499321
Review-Url: https://codereview.chromium.org/2036213002
Cr-Commit-Position: refs/heads/master@{#397789}
cc: Make tile manager not be a pointer on layer tree host impl.
This patch makes tile manager a non-pointer so that it's clear that
it persists for the lifetime of layer tree host impl.
R=enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2036343002
Cr-Commit-Position: refs/heads/master@{#397788}
Roll src/third_party/catapult/ 80132ac69..ccb73566f (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/80132ac6935a..ccb73566fef2
$ git log 80132ac69..ccb73566f --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2040493002
Cr-Commit-Position: refs/heads/master@{#397787}
[chromedriver] Drop official support for Chrome 50 on linux32.
The debug build that we're testing against is buggy and crashing on our
buildbot, so we're not able to test against this continuously. I've manually run
java tests against gs://chromium-browser-snapshots/Linux/378110 and don't see
any problems.
BUG=chromedriver:1390
[email protected]
Review-Url: https://codereview.chromium.org/2029393006
Cr-Commit-Position: refs/heads/master@{#397786}
Stop asynchronously deleting the network manager in P2PPortAllocator.
WebRTC now calls the PortAllocator destructor from the correct thread,
so this is no longer necessary.
Review-Url: https://codereview.chromium.org/1976263002
Cr-Commit-Position: refs/heads/master@{#397785}
mac/gn: Build performance_browser_tests
With this, all *tests binaries built in the gyp build are also built
in the gn build on Mac (except remoting).
Also remove an unused js2webui rule in the gyp version of the target:
The target doesn't contain any .js files.
BUG=431177
Review-Url: https://codereview.chromium.org/2035083003
Cr-Commit-Position: refs/heads/master@{#397784}
Bump timeouts for Android N5X Swarm Builder.
BUG=589168
Review-Url: https://codereview.chromium.org/2041473002
Cr-Commit-Position: refs/heads/master@{#397783}
Revert of Make click targets inside links work. (patchset #1 id:1 of https://codereview.chromium.org/2030413002/ )
Reason for revert:
Failing on Mac 10.11 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/2237
Error message is:
Harness Error. harness_status.status = 2 , harness_status.message = null
Sorry to revert this again. :(
Original issue's description:
> Make click targets inside links work.
>
> There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
> For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
> BUG=615904
> [email protected]
>
> Committed: https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5
> Cr-Commit-Position: refs/heads/master@{#397760}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615904
Review-Url: https://codereview.chromium.org/2036943003
Cr-Commit-Position: refs/heads/master@{#397782}
Fix the double-tap to click gesture in touch accessibility mode.
Originally Chrome OS's touch accessibility support was implemented purely
as an event rewriter. Tapping the screen generates a mouse move event,
which announces the object under the finger without clicking it, and then
double-tapping anywhere on the screen generates a click at the last point
where the user tapped. It's also possible to trigger clicks and drags by
more advanced means.
This worked well for touch exploration alone, but it's also possible for
the current accessibility object to move due to a gesture (to move to the
next or previous object on the screen, for example) or due to input focus
moving. In those cases, a double-tap was sending a simulated click to the
wrong point - it was sending it to the last touch exploration point, rather
than to the current accessibility object.
This change fixes this behavior by changing how the touch accessibility
support works.
First, it introduces the concept of the anchor point, which is the point
where the next simulated click will go. Initially this is set via touch
exploration, however now as soon as ChromeVox identifies the object under
the finger, it sends the center point of that object as the new explicit
anchor point, and that point overrides the touch exploration point for the
duration of this touch.
Second, when the user does a discrete gesture to click on the current anchor
point (double-tap, split-tap, or single-tap), it sends a gesture command
to ChromeVox, allowing ChromeVox to directly activate the current object.
However, if the user holds their finger down, it still passes through the
touch events so dragging and long-pressing are possible.
Third, it simplifies "split tap" support where you can tap a second finger
as a shortcut to clicking. That support now only supports a basic click and
not a long-press or drag.
BUG=513713,613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2007863004
Cr-Commit-Position: refs/heads/master@{#397781}
Enable pylint warnings on presubmit checks.
In http://crbug.com/493941, it was mentioned that we could fix all current pylint warnings before enabling pylint warnings in the presubmit -- but actually we could also enable warnings in the presubmit now without causing any problems; pylint will only print warnings about lines that are changed in a CL, and turning on warnings now could be potentially helpful in cleaning up the code.
And turning on pylint warnings in check-webkit-style and the presubmit is just a one line change; any reason not to just do it now?
NOPRESUBMIT=true
BUG=493941
Review-Url: https://codereview.chromium.org/2010173003
Cr-Commit-Position: refs/heads/master@{#397780}
Forwarding POST body into renderer after a cross-site transfer.
After this CL, ResourceRequestBody from ResourceHostMsg_Request
will get sent after a cross-site transfer in FrameMsg_Navigate:
- ResourceDispatcherHostImpl::BeginRequest stores
ResourceHostMsg_Request::request_body into
ResourceRequestInfoImpl::body_
- NavigationResourceThrottle::WillStartRequest forwards
ResourceRequestInfoImpl::body_ into a call to
NavigationHandleImpl::WillStartRequest, where the body gets stored in
NavigationHandleImpl::resource_request_body_
- NavigationHandleImpl::WillRedirectRequest takes care to
reset the body if a redirect changed the method to a non-POST.
(see also https://crbug.com/582211#c22).
- RenderFrameHostManager::OnCrossSiteResponse forwards
NavigationHandleImpl::resource_request_body_ into the call to
NavigatorImpl::RequestTransferURL. The body is used to set
the proper method on FrameNavigationEntry and used to populate
CommonNavigationParams.
BUG=582211, 613004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1956383003
Cr-Commit-Position: refs/heads/master@{#397779}
Fixed up root scroller API to be more webby
-Removed document.setRootScroller and replaced it by making the
document.rootScroller attribute writable.
-Moved the RootScroller object from FrameHost into Document. Now each
Document has its own RootScroller object which manages the rootScroller
for that Document. This means each iframe on the page will have its own
rootScroller. I've allowed setting it from iframes now too, making the
API more composable; setting a rootScroller on an iframe's Document
simply doesn't change any behavior.
-Made the rootScroller "sticky". Previously, if the current rootScroller
becomes invalid (for example, the rootScroller Element becomes
display:none) it would reset to the default element. With this CL, we'll
use the default while the rootScroller is invalid, but we keep the
rootScroller set. When it becomes valid again, we'll use it again. This
is done by making RootScroller::m_rootScroller the Element the page has
set as the root scroller. RootScroller::m_effectiveRootScroller is the
Element we're using internally to handle viewport actions.
-Changed the criteria for a valid rootScroller. Elements in an iframe can
now be used. Only elements that exactly fill the viewport are considered
valid.
BUG=505516
Review-Url: https://codereview.chromium.org/1970763002
Cr-Commit-Position: refs/heads/master@{#397778}
Update V8 to version 5.3.132.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a9e2bf5a..9cdf7a6f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2038103002
Cr-Commit-Position: refs/heads/master@{#397777}
[Mac] Fix |keyCode| for Shift+Num0..9 on JIS keyboard
JIS keyboard produces different characters for Shift+Num0..9,
which is incorrectly handled by |KeyboardCodeFromCharCode()| and
results in wrong |keyCode|.
This CL maps |keyCode| for Num0..9 based on |NSEvent::keyCode|, which matches FF's logic:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode#Printable_keys_in_standard_position
We want this issue fixed because it's affecting "Command+Shift+2/7" hotkeys among Japanese Gmail users.
This CL also adds tests for |keyCode| on different keyboard&InputSource combinations.
Example issue before CL:
On US layout - Shift+Num7 generates |keyCode| 55 (VKEY_7).
On JIS layout - Shift+Num7 generates |keyCode| 222 (VKEY_OEM_7) because the produced character is |'|.
After CL:
Both are 55 (VKEY_7), which matches Firefox and Edge.
BUG=440066
Review-Url: https://codereview.chromium.org/2035453003
Cr-Commit-Position: refs/heads/master@{#397776}
Support converting utf-16 files when importing w3c tests
Previously, the test converter assumed that input files are always valid utf-8;
this change makes the converter also support utf-16 files. There are some files
in the wpt repo that are not valid utf-8 but are valid utf-16, e.g.
web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/utf-16be.html.
BUG=463001
Review-Url: https://codereview.chromium.org/2037743002
Cr-Commit-Position: refs/heads/master@{#397775}
Set value of always_show_context_menu_on_touch in WebSettings
Previous CL forgot to set the value of always_show_context_menu_on_touch.
This CL fixes that.
BUG=616971
Review-Url: https://codereview.chromium.org/2037923002
Cr-Commit-Position: refs/heads/master@{#397774}
Blimp presubmit to check for unit tests on new .cc files.
BUG=612498,543268
TEST=Added the files blimp/science.cc, blimp/science_unittest.cc, blimp/science2.cc, blimp/science2_unittest.cc, blimp/science_browsertest.cc, and science.cc. Verified that blimp/science.cc was flagged for missing unit tests.
Review-Url: https://codereview.chromium.org/2005023002
Cr-Commit-Position: refs/heads/master@{#397773}
Implement gfx::SelectionBound StructTraits
This will be needed by the cc::CompositorFrameMetadata StructTraits.
BUG=611802
Review-Url: https://codereview.chromium.org/2040483003
Cr-Commit-Position: refs/heads/master@{#397772}
net: migrate CreateMonsterFromStoreForGC() to CanonicalCookies::Create method
This patch converts the usage of CanonicalCookie's constructor in
CreateMonsterFromStoreForCG() to CanonicalCookie's Create() method.
We are doing this because Create() is more robust, as it does
validation of the parameters and return NULL as an error signal
if they fail to comply with the checks.
BUG=57061
TEST=net_unittests
[email protected]
Review-Url: https://codereview.chromium.org/2030233002
Cr-Commit-Position: refs/heads/master@{#397771}
[Mac/iOS/GN] Add //build/toolchain/mac/filter_libtool.py.
This moves another step performed by gyp-mac-tool into a standalone script.
BUG=616813
[email protected]
Review-Url: https://codereview.chromium.org/2033503003
Cr-Commit-Position: refs/heads/master@{#397770}
[Chromoting] Final SelfRemovableParameterRunnable
This is a trivial change to make Event.SelfRemovableParameterRunnable final.
BUG=615277
Review-Url: https://codereview.chromium.org/2033573002
Cr-Commit-Position: refs/heads/master@{#397769}
Roll src/third_party/skia/ 2cee90284..adf5afa62 (8 commits).
https://chromium.googlesource.com/skia.git/+log/2cee902847a9..adf5afa628ad
$ git log 2cee90284..adf5afa62 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 robertphillips Add SampleApp slide with animating lightmapped objects & transparency
2016-06-03 herb Add gm for displaying different variants of 8888 bitmaps and fix a small rejection case for sprite blitters.
2016-06-03 caryclark fix windows assert
2016-06-03 scroggo Fix undefined behavior in libpng
2016-06-03 halcanary SkPDF: handle unpremul right
2016-06-03 csmartdalton Abandon offset support with texel buffers
2016-06-03 liyuqian Add Softkey UIState to Viewer
2016-06-03 csmartdalton Support ARB extensions for indirect drawing
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2037753004
Cr-Commit-Position: refs/heads/master@{#397768}
Fix arm64 linux compilation errors.
Fixes 'undeclared identifier __NR_access/__NR_open' compile errors.
__NR_access and __NR_open don't exist on ARM64. So, like the earlier
code in same file, added __NR_access and __NR_open case under
!defined(__aarch64__) check.
BUG=613452
Review-Url: https://codereview.chromium.org/1996273002
Cr-Commit-Position: refs/heads/master@{#397767}
cc: Add four new histograms for gpu image decode/upload usage tracking.
This patch adds the following new histograms:
Renderer4.GpuImageDecodeState
=============================
This records the state of the software decode used for gpu upload.
Specifically, it identifies whether the decode was used or not used and
whether it was used/wasted once or several times. The possible states
are all combinations of those values:
- Used, once
- Wasted, once
- Used, relocked
- Wasted, relocked
Renderer4.GpuImageDecodeState.FirstLockWasted
=============================================
This indicates whether the first lock of the decode described above was
used. This is important, since if we waste the first decode, we lose
the guarantee that we can relock and upload this without doing more work
Renderer4.GpuImageUploadState.Used
==================================
This indicates whether the uploaded image was used in raster.
Renderer4.GpuImageUploadState.FirstRefWasted
============================================
This indicates whether the uploaded image was used during the first
ref. In other words, if the ref reached 0 for the first time without
the image being used, this would record "true, it was wasted".
R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2036553002
Cr-Commit-Position: refs/heads/master@{#397766}
Push the chrome browser of the selected tab to the front of the screen,
BUG=605340
Review-Url: https://codereview.chromium.org/2035863002
Cr-Commit-Position: refs/heads/master@{#397765}
Move _baseline_name to test_result_writer.py.
This function is more closely related to the code in test_result_writer.py than the code in rebaseline.py; however it wouldn't be simpler to make this function a method of TestResultWriter, since the TestResultWriter constructor takes several arguments which are not relevant to the baseline_name function.
Review-Url: https://codereview.chromium.org/2021743002
Cr-Commit-Position: refs/heads/master@{#397764}
Reduce LayoutSVGResource*Gradient building dependency on GradientData
The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.
BUG=614368
Review-Url: https://codereview.chromium.org/2031053004
Cr-Commit-Position: refs/heads/master@{#397763}
Remove XP-specific logic in url_request_unittest.cc.
There is no longer a need to filter out ECDSA.
BUG=none
Review-Url: https://codereview.chromium.org/2037883002
Cr-Commit-Position: refs/heads/master@{#397762}
Add logger for ImeFeature messages.
BUG=615588
Review-Url: https://codereview.chromium.org/2018243002
Cr-Commit-Position: refs/heads/master@{#397761}
Make click targets inside links work.
There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
[email protected]
Review-Url: https://codereview.chromium.org/2030413002
Cr-Commit-Position: refs/heads/master@{#397760}
mus: Make --use-mus-in-renderer work again.
. It is necessary to send the --use-mus-in-renderer flag to the renderer.
. Allow content_browser to connect to the renderer and get a handle to
a RenderWidgetWindowTreeClientFactory.
BUG=none
Review-Url: https://codereview.chromium.org/2037533002
Cr-Commit-Position: refs/heads/master@{#397759}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2030833003
Cr-Commit-Position: refs/heads/master@{#397758}
Roll src/third_party/catapult/ 37cec23b5..80132ac69 (3 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/37cec23b5d25..80132ac6935a
$ git log 37cec23b5..80132ac69 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2040483002
Cr-Commit-Position: refs/heads/master@{#397757}
Fix Hiding Issue with Certificate Viewer Mac
Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.
Added logic that calculates the x and y position offset of the dialog
when it unhides.
BUG=611603
Review-Url: https://codereview.chromium.org/2034993002
Cr-Commit-Position: refs/heads/master@{#397756}
mac: ensure ui::Compositor exists for visible RWHVs
RenderWidgetHostViewMac is careful about creating ui::Compositor and so
currently only does this in Show and SwapCompositorFrame. However, if
it the RenderWidgetHostView is created while the RenderWidgetHost is
visible, then Show will early out and never create a ui::Compositor.
This causes problems with begin frame scheduling, which wants to have
the Display (which is created as part of creating the ui::Compositor's
output surface currently) own the real begin frame source that drives
everything. In that world, if no ui::Compositor exists, no frames ever
are sent or swapped. So, the ui::Compositor needs to be created first.
Also, if the ui::Compositor is correctly created during Show (or the
constructor), then there's no need to ensure that it exists during
swap compositor frame, and so that can be safely removed.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2005013002
Cr-Commit-Position: refs/heads/master@{#397755}
Import wpt@1b61dad2be6c5100beb565e91c58b8c1084b3c7d
Whitelist pointer event manual tests in the import process
Using update-w3c-deps in Chromium c517903e4714fac5e85e9e38fb7316d5df36cc46.
BUG=612924
Review-Url: https://codereview.chromium.org/2020083002
Cr-Commit-Position: refs/heads/master@{#397754}
[chromedriver] Check if chrome_path is None (Android uses package name instead).
BUG=
[email protected]
Review-Url: https://codereview.chromium.org/2039533002
Cr-Commit-Position: refs/heads/master@{#397753}
Color emoji tests
Add tests and Win10 expectations for color emoji.
Also fix an expectation for emoji fallback test to look for the color
emoji font first, which will be present on Win10, but not on Win7.
Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/
BUG=333011
Review-Url: https://codereview.chromium.org/2003853002
Cr-Commit-Position: refs/heads/master@{#397752}
Move close button to right in the PW Activity
This change moves the close button to the far right in the Physical Web
ListUrlsActivity.
BUG=603132
Review-Url: https://codereview.chromium.org/2027033002
Cr-Commit-Position: refs/heads/master@{#397751}
Change test_importer.py to skip importing files named OWNERS
BUG=584660
Review-Url: https://codereview.chromium.org/2032943003
Cr-Commit-Position: refs/heads/master@{#397750}
Create ForTesting method rather than declaring a dozen "friend" classes.
BUG=546019
Review-Url: https://codereview.chromium.org/2036643004
Cr-Commit-Position: refs/heads/master@{#397749}
Renames mojo:desktop_wm to mojo:ash
BUG=616265
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2037033004
Cr-Commit-Position: refs/heads/master@{#397748}
Null-check PaintLayerScrollableArea lookup.
BUG=616633
Review-Url: https://codereview.chromium.org/2037093002
Cr-Commit-Position: refs/heads/master@{#397747}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2037703004
Cr-Commit-Position: refs/heads/master@{#397746}
[iOS] Add support for iOS to build/mac/tweak_info_plist.py.
In order to allow Chrome on iOS to use build/mac/tweak_info_plist.py,
add options required to control the format of the generated plist file
(--format), the product reported to breakpad (--platform) and a way to
override some portion of the version string (--version-overrides).
This is required to allow Chrome on iOS to migrate from it old fork of
tweak_info_plist shell script and to incorporate tweak_info_plist.py
in the GN build.
BUG=502295
Review-Url: https://codereview.chromium.org/2037043002
Cr-Commit-Position: refs/heads/master@{#397745}
cc: Make LayerTreeImpl dump layer list to FrameViewer and Devtools
As compositor will no longer know tree hierarchy information, it is
expected to dump a layer list instead of a layer tree to chrome tracing.
The value root_layer is also deleted because it is used to judge whether
the dumped layer_tree_impl has a list or not on the FrameViewer side.
Chrome://tracing will show a layer_tree_impl without depth, this is
expected.
This CL is blocked by Issue 1947553002, and potentially influenced by
the LayerTreeImpl's JSON issue.
Devtools need to deal with the new format information. On the devtools
side, we make the first drawsContent layer "contentRoot" and treat all
other layers as the contentRoot's child.
BUG=605940
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1945813002
Cr-Commit-Position: refs/heads/master@{#397744}
headless: Implement screenshot capturing
(based on patch from skyostil@, also sets default window size to 800x600 to enable basic snapshot support)
With the --screenshot option, headless shell will save a PNG screenshot
of the loaded page.
patch from issue 2000723002 at patchset 1 (http://crrev.com/2000723002#ps1)
BUG=546953
Review-Url: https://codereview.chromium.org/2035733002
Cr-Commit-Position: refs/heads/master@{#397743}
WebGL: Mark glsl-mat4-to-mat3 flaky on Win/D3D9.
This test is causing problems for the ANGLE CQ.
BUG=617148
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2032413002
Cr-Commit-Position: refs/heads/master@{#397742}
[DomKey] Use VK->DomKey mapping for non-printable keys
The original DomCode+flags->DomKey mapping causes issue when the application
generates mismatched keyCode + scanCode, or missing scanCode entirely.
(e.g. keyboard-rewrite softwares that only modifies keyCode)
A better solution is to use VK+flags->DomKey mapping (for both printable
and non-printable keys).
This CL is the first step for the non-printable keys, where a fixed table
for general non-printable keys was introduced. And there will be follow up CLs
to handle other language-specific cases and printable keys.
BUG=612749
Review-Url: https://codereview.chromium.org/2025733002
Cr-Commit-Position: refs/heads/master@{#397741}
Use #969696 as (dark) text hint color in the Android omnibox.
BUG=616710
Review-Url: https://codereview.chromium.org/2032713004
Cr-Commit-Position: refs/heads/master@{#397740}
Hook up Chrome's wallpaper picker for mash.
Add wallpaper.mojom for ash_sysui<->chrome interaction.
Implement WallpaperController in ash_sysui UserWallpaperDelegateMus.
Implement minimal new ChromeWallpaperHelper in chrome.
(lets chrome set mash wallpaper, mash trigger chrome wallpaper picker)
Add SetWallpaper helper for WallpaperManager to work in mash too.
Remove sysui_application.cc debug wallpaper initialization.
Bail early on WindowStateManager::[Minimize|Restore]InactiveWindows.
Workaround DesktopBackgroundController shell usage.
TODO: Fix picker regression from codereview.chromium.org/2009853002
TODO: Fix wallpaper_manager.cc's other Shell::GetInstance uses.
TODO: Fix DesktopBackgroundController display size checks in Mash.
TODO: Implement window hide/restore for wallpaper picker.
TODO: Implement missing UserWallpaperDelegateMus functionality.
BUG=557405,613657,613707
TEST=Chrome OS wallpaper works with or without --mash flag; right click mash desktop -> "Set wallpaper..." works.
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/1984433002
Cr-Commit-Position: refs/heads/master@{#397739}
Modify ImageTransportSurfaceOverlayMac to allow pipelining
This change allows 1 additional frame of pipelining in
ImageTransportSurfaceOverlayMac by switching from a glFinish based
approach to a glFence based one.
Tested for CA framerate regressions - the following cases starve CA
when used with a simple glFlush. This solution (and the previous
glFinish) appear to successfully prevent CA starvation:
Animometer - bouncing png images:
https://trac.webkit.org/export/HEAD/trunk/PerformanceTests/Animometer/developer.html?test-interval=20&display=progress-bar&controller=adaptive&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=SVGsuite&test-name=SVGbouncingPNGimages&complexity=200
Both glFinish and glFence produce ~50 fps in CA/Chrome.
WebGL Liquid Face:
http://alteredqualia.com/xg/examples/liquid_face.html
For liquid face, note that with the glFinish, CA framerate is slightly
higher than Chrome reported framerate (20 vs 15) - with the new
approach, they match more closely (16 vs 15). This may be a negative,
but is still much better than the starvation which is seen with glFlush (5
vs 15).
Improvements:
Telemetry smoothness.top_25_smooth: This change produces good
improvements in first_gesture_scroll_update_latency,
mean_input_event_latency, and mean_main_thread_scroll_latency,
without any significant regressions. See:
https://drive.google.com/file/d/0B2nwXDxTDpGGU215X2xYTE9Bdnc/view?usp=sharing
Animometer Benchmark: This change produces good improvements in a
number of animometer benchmarks. See:
https://docs.google.com/spreadsheets/d/1qK6LfDVMKydbKfkGEi1DuGoSqY2wPJAjPiAL1CCUW-4/edit?usp=sharing
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2028303002
Cr-Commit-Position: refs/heads/master@{#397738}
Refine ChromeVox's treatment of containers
1. merge ignored containers and ignored leaf nodes into one predicate
2. only visit containers that are also visited by the provided predicate. For example, an element will match against a focusable toolbar, but a line won't.
3. scan the initial subtree of a node when moving to the next node if either of the following are true:
the node is a container or
the node doesn't match the predicate (e.g. element).
This takes care of syncing when the current range is on an arbitrary position in the tree.
When moving backwards, the leaf predicate restricts how deeply the backwards movement syncs downwards in the tree.
BUG=613473
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2028173003
Cr-Commit-Position: refs/heads/master@{#397737}
Roll src/third_party/skia/ 9d19cc6ca..2cee90284 (3 commits).
https://chromium.googlesource.com/skia.git/+log/9d19cc6ca4de..2cee902847a9
$ git log 9d19cc6ca..2cee90284 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 msarett Add color correction benchmark - with comparison to qcms
2016-06-03 msarett Fix uses of SkImageInfo in BRD to preserve color space info
2016-06-03 jcgregorio skiaserve: Add a flag to control hosted mode, i.e. when running on debugger.skia.org.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2037033003
Cr-Commit-Position: refs/heads/master@{#397736}
Empty SVG viewbox should be treated invalid
If SVG viewbox is explicitly empty, it should be
treated as invalid value.
BUG=608413
Review-Url: https://codereview.chromium.org/2037573002
Cr-Commit-Position: refs/heads/master@{#397735}
[Material][Mac] Adjustments to the Omnibox decorations
BUG=613788,611113
Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}
Move header block size limit from HpackDecoder to HeaderCoalescer.
* Remove the limit on amount of encoded HPACK data (kMaxDecodeBufferSize) from HpackDecoder, proteced by FLAGS_chromium_http2_flag_remove_hpack_decode_buffer_size_limit.
* Implement limit in HeaderCoalescer. Same value, 256 kB. (Though counted somewhat differently.)
* Add regression test.
This CL lands server change 123642200 by rjshade.
BUG=488484
Review-Url: https://codereview.chromium.org/2031523002
Cr-Commit-Position: refs/heads/master@{#397733}
Treat % as a non-canoncial character
BUG=613689
Review-Url: https://codereview.chromium.org/2036493005
Cr-Commit-Position: refs/heads/master@{#397732}
Roll src/third_party/catapult/ 90899c6d4..37cec23b5 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/90899c6d475e..37cec23b5d25
$ git log 90899c6d4..37cec23b5 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2038093002
Cr-Commit-Position: refs/heads/master@{#397731}
Add UMA to measure request latency time.
Now that we are actually using the scheduler and GCM Network Manager,
add the UMA to measure how long the user's request took from request
until the network came back.
BUG=597364
Review-Url: https://codereview.chromium.org/2032833002
Cr-Commit-Position: refs/heads/master@{#397730}
Adding specific bugs for layout test failures with --site-per-process flag.
BUG=615156, 616608, 616626
Review-Url: https://codereview.chromium.org/2037743003
Cr-Commit-Position: refs/heads/master@{#397729}
Update V8 to version 5.3.129.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a110c042..a9e2bf5a
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2030393002
Cr-Commit-Position: refs/heads/master@{#397728}
[iOS/GN] Add support for info_plist_target to ios_info_plist.
Chrome on iOS needs to use tweak_info_plist, so port support
for info_plist_target from mac_info_plist to ios_info_plist.
BUG=617134
Review-Url: https://codereview.chromium.org/2033403003
Cr-Commit-Position: refs/heads/master@{#397727}
Offline Pages: Remove leftover file if MHTML generation error occurred.
BUG=613761
Review-Url: https://codereview.chromium.org/2028263003
Cr-Commit-Position: refs/heads/master@{#397726}
Add generated and hand-written passthrough command handlers with stub Doers.
Use the build_gles2_cmd_buffer.py script to generate as many handlers as
possible and hand-write the rest.
BUG=602688
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2012533004
Cr-Commit-Position: refs/heads/master@{#397725}
Mark sync.FirstRunTest#testSignIn flaky
It failed in builds 34692 34643 34619 34598 of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29
BUG=616456
[email protected]
Review-Url: https://codereview.chromium.org/2039463002
Cr-Commit-Position: refs/heads/master@{#397724}
[ios] Added WebTestWithWebController::web_state.
Subclasses of WebTestWithWebController should use WebState where
possible.
BUG=616244
Review-Url: https://codereview.chromium.org/2032903002
Cr-Commit-Position: refs/heads/master@{#397723}
Previously the inheritance for WorkletGlobalScopes was:
core/workers/WorkerOrWorkletGlobalScope
-> core/workers/MainThreadWorkletGlobalScope
-> modules/worklet/WorkletGlobalScope
With ThreadedWorkletGlobalScope, not all global scopes will exist on the main thread.
MainThreadWorkletGlobalScope exists in core/workers as the MainThreadDebugger & friends need to access it's LocalFrame from core/
The new inheritance is:
core/workers/WorkerOrWorkletGlobalScope
-> core/workers/WorkletGlobalScope
-> core/workers/MainThreadWorkletGlobalScope
This moves WorkletGlobalScope into core and a few other classes. ThreadedWorkletGlobalScope will exist in modules and inherit from WorkletGlobalScope.
Implementation Doc:
https://docs.google.com/document/d/14hEO_BqQRBne3tBD2xghEEo02nz2csLqY4SS6x6rmjA/edit
BUG=567358
Review-Url: https://codereview.chromium.org/2029163002
Cr-Commit-Position: refs/heads/master@{#397722}
Reland of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #1 id:1 of https://codereview.chromium.org/2033323003/ )
Reason for revert:
Clankium failures should not revert Chromium. The correct course of action is to fix-up the Clankium code, into which Chromium developers have no visibility.
Original issue's description:
> Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #12 id:620001 of https://codereview.chromium.org/1982623002/ )
>
> Reason for revert:
> This broke the downstream clang-clankium-tot-builder, since PersonalDataManager at least is used by downstream autofill code to get profiles and credit cards: https://goto.google.com/kneae
>
> Original issue's description:
> > Sorted the profiles and credit cards to be used in PaymentRequest.
> >
> > Also added test methods to set the use count and use date of profiles and cards.
> >
> > BUG=609864
> > TEST=PersonalDataManagerTestJava
> >
> > Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2
> > Cr-Commit-Position: refs/heads/master@{#397562}
>
> [email protected],[email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=609864
>
> Committed: https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e
> Cr-Commit-Position: refs/heads/master@{#397679}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609864
Review-Url: https://codereview.chromium.org/2039493002
Cr-Commit-Position: refs/heads/master@{#397721}
[HttpCache] Record age of validated and updated stale cache entries
It would be good to know the correlation between an entry's age and its
likelihood to be validated vs updated. This CL adds two new metrics which
record the stale entry's age (as a percentage of freshness) when it's validated
and when it's updated.
BUG=614355
Review-Url: https://codereview.chromium.org/2036123003
Cr-Commit-Position: refs/heads/master@{#397720}
Fix some MultiplexRouter behavior for sync messages
Two small fixes:
- ProcessTasks was unintentionally scoping the
interface id for a sync message task, so
an unprocessed task would then get pushed
back onto the queue for kInvalidInterfaceId
- Unprocessed task pointer was being pushed back
onto the sync message queue after moving the
task ptr back into the task queue, so the sync
message queue entry would always be null.
Also minor cleanup to ProcessFirstSyncMessageForEndpoint
to wipe out empty entries in sync_message_tasks_ when
possible.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2035893003
Cr-Commit-Position: refs/heads/master@{#397719}
Remove SkTypeface_fake.cpp.
This file was added when Skia was first converted to DEPS from being
checked-in. It is no longer built and contains nothing of interest to
modern Skia.
Review-Url: https://codereview.chromium.org/2034783003
Cr-Commit-Position: refs/heads/master@{#397718}
Mojo C++ bindings: more consistent Clone() and Equals().
With this change, the Clone() and Equals() methods of structs/unions/maps/arrays call Clone() and Equals() of elements if available, otherwise fall back on copy and == operator of elements.
BUG=616527
Review-Url: https://codereview.chromium.org/2031823002
Cr-Commit-Position: refs/heads/master@{#397717}
Move expectation for serviceworker-notification-properties.html leak to LeakExpectations.
The current expectation is for flaky failure, but a leak was observed.
BUG=617137
[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2032423002
Cr-Commit-Position: refs/heads/master@{#397716}
MD User Manager: Fixes flaky tests
1) Call setTimeout after each test.
user_manager.js includes a bunch of other js files that do operations asynchronously. This is to make sure those operations are done after each test.
2) Do not clear <body> before the tests execute.
js files included in the user_manager.js expect some elements to exist on the page. Therefore we can't test MD User Manager Polymer elements in isolation.
BUG=563722
Review-Url: https://codereview.chromium.org/2036763003
Cr-Commit-Position: refs/heads/master@{#397715}
Disable DumpAccessibilityEventsTest.* on Win
The tests are flaky on Windows 8.
[email protected]
BUG=617146
Review-Url: https://codereview.chromium.org/2034103002
Cr-Commit-Position: refs/heads/master@{#397714}
Roll src/third_party/skia/ 6fb2391b2..9d19cc6ca (1 commit).
https://chromium.googlesource.com/skia.git/+log/6fb2391b2cc8..9d19cc6ca4de
$ git log 6fb2391b2..9d19cc6ca --date=short --no-merges --format='%ad %ae %s'
2016-06-03 borenet Add Android device type for NVIDIA Shield
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2030023004
Cr-Commit-Position: refs/heads/master@{#397713}
[Android] Update native_test.gyp to fix webrtc.
webrtc's attempts to roll its chromium revision have failed for the last
week (!) due to https://codereview.chromium.org/1975153003.
BUG=
[email protected]
Review-Url: https://codereview.chromium.org/2035093002
Cr-Commit-Position: refs/heads/master@{#397712}
Make changing a record's type an atomic operation.
Accessing the type_id is generally thread-safe within the PMA
code because it is only accessed once the memory is owned to
the exclusion of any other allocator. The same can't be said,
however, once access to it is given to a caller and so
protection needs to be added so that callers can't introduce
race conditions due to their inter-process thread-unsafety.
BUG=546019
Review-Url: https://codereview.chromium.org/2034813003
Cr-Commit-Position: refs/heads/master@{#397711}
Map ET_POINTER_MOVED to ET_MOUSE_DRAGGED when a mouse button is down.
BUG=615094
Review-Url: https://codereview.chromium.org/2033743003
Cr-Commit-Position: refs/heads/master@{#397710}
Roll src/third_party/catapult/ c502262d9..90899c6d4 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c502262d988b..90899c6d475e
$ git log c502262d9..90899c6d4 --date=short --no-merges --format='%ad %ae %s'
BUG=616865
[email protected]
Review-Url: https://codereview.chromium.org/2035083002
Cr-Commit-Position: refs/heads/master@{#397709}
Update V8 to version 5.3.127.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e56ad567..a110c042
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2038063002
Cr-Commit-Position: refs/heads/master@{#397708}
Add new InputDeviceManager interface.
This interface contains the methods from DeviceDataManager that we want
to expose in multiple processes for mash.
A different implementation of the interface will be required to mirror
input device state. This will come in a follow up CL.
InputDeviceManager holds a non-owning static pointer to an
implementation. This allows client code to be agnostic to which
implementation they are using.
Update client code that uses DeviceDataManager to get information about
input-devices to use InputDeviceManager instead. This should have
identical functionality in cash and be suitable for use with mash.
There is client code where DeviceDataManager is used for information
about touch transforms or where DeviceDataManager state is manipulated
in tests. These cases are beyond the scope of InputDeviceManager and
client code was not updated here.
BUG=601981
Review-Url: https://codereview.chromium.org/2028593004
Cr-Commit-Position: refs/heads/master@{#397707}
Adds code_and_metadata_size statistics when collecting v8 heap statistics.
To measure the overall size of code along with its metadata, we add
a new category called code_and_metadata_size. This data is collected by
scanning the heap for code/bytecode objects. V8 exposes an explicit API
to obtain this data. It should be used with caution as it could be slow.
It involves scanning the heap to collect this data. This data is collected
only when memory-infra.v8.code_stats is enabled.
BUG=v8:4280
LOG=N
Review-Url: https://codereview.chromium.org/1929523002
Cr-Commit-Position: refs/heads/master@{#397706}
[libfuzzer] Roll LibFuzzer feca8e5..428b5cb.
https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/feca8e5..428b5cb
[email protected]
BUG=539572
Review-Url: https://codereview.chromium.org/2033403004
Cr-Commit-Position: refs/heads/master@{#397705}
Remove Quirks flag, limit server retries
BUG=598841
TEST=Check that disable-quirks-client is no longer on the experimental
flags list.
This removes the disable-quirks-client command line flag, and places a
limit of 10 on the number of times (with exponential backoff) that
Chrome OS will attempt to contact the Quirks server in one session.
Review-Url: https://codereview.chromium.org/2016883003
Cr-Commit-Position: refs/heads/master@{#397704}
Disable http/tests/notifications/serviceworker-notification-properties.html on Linux
It has a leak reported. More info on the bug.
[email protected]
NOTRY=true
BUG=617137
Review-Url: https://codereview.chromium.org/2036153003
Cr-Commit-Position: refs/heads/master@{#397703}
Remove use of deprecated MessageLoop methods in gin.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2035933002
Cr-Commit-Position: refs/heads/master@{#397702}
Introduce the Blink NotificationService, move permission checks there
This introduces the Mojo NotificationService in Blink and moves
permission checks over from the IPC code-path to the Mojo code-path.
This CL is a re-land of the original CL that was reverted because of
crash reports: https://codereview.chromium.org/1948223004/. In
addition, it removes usage of WeakPtr as pointed out by yszhen@.
TBR=esprehn, jam, dcheng, mvanouwerkerk, haraken
BUG=595685
Review-Url: https://codereview.chromium.org/2003023002
Cr-Commit-Position: refs/heads/master@{#397701}
Update V8 to version 5.3.123.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9970e067..e56ad567
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2035853004
Cr-Commit-Position: refs/heads/master@{#397700}
Fix incorrect test specification
Apparently, the Retina specifier was missing when disabling
tables/mozilla/bugs/bug30692.html on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/.
NOTRY=true
[email protected]
BUG=617033
Review-Url: https://codereview.chromium.org/2032093003
Cr-Commit-Position: refs/heads/master@{#397699}
Roll WebRTC 13026:13031
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/91e542d..8a95a05
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2030363002
Cr-Commit-Position: refs/heads/master@{#397698}
Clear media query rulesets on page zoom changes.
Otherwise, resolution media queries won't update properly when page
zoom changes. Changing the deviceScaleFactor already did this. Also,
matchMedia listeners already worked.
BUG=617095
Review-Url: https://codereview.chromium.org/2038793002
Cr-Commit-Position: refs/heads/master@{#397697}
Use logical instead of on-the-wire HTTP/2 weight values.
Modify SpdyPriorityIR and SpdyFramerVisitorInterface::OnPriority() to use
actual/logical HTTP/2 weight values in the range [1, 256], as opposed to the
on-the-wire representation as ints in the range [0, 255]. (The difference
between the on-the-wire and actual weight value is specified in
https://tools.ietf.org/html/rfc7540#section-6.3).
Also remove legacy SpdyFramer methods MapPriorityToWeight() and
MapWeightToPriority(), which used on-the-wire weight values, and are superceded
by the Spdy3PriorityToHttp2Weight() and Http2WeightToSpdy3Priority() functions
in spdy_priority.{h,cc}.
This CL lands server changes 116911302 by mpw
and 123774531 and 123892187 by bnc.
BUG=488484
Committed: https://crrev.com/7aec5276f9b0c5bf481f92494f537967828b61eb
Cr-Commit-Position: refs/heads/master@{#397557}
Review-Url: https://codereview.chromium.org/2035653002
Cr-Commit-Position: refs/heads/master@{#397696}
Avoid unneeded hashmap lookups in ensureObjectPaintProperties()
Use HashMap::add()/AddResult to minimize the number of lookups when
the entry is not present.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2033903002
Cr-Commit-Position: refs/heads/master@{#397695}
Remove use of deprecated MessageLoop methods in chromecast.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
[email protected]
Review-Url: https://codereview.chromium.org/2032203002
Cr-Commit-Position: refs/heads/master@{#397694}
[NTP Snippets] Set the snippets header height to 40dp
BUG=616725
Review-Url: https://codereview.chromium.org/2035053002
Cr-Commit-Position: refs/heads/master@{#397693}
[tools/perf] Move system_health_stories to system_health.loading_stories module
Rationale: we know that it's almost impossible to have 1 single
system_health story set, hence the current direction is to create multiple
stories set for key user actions. In the future, the
page_sets/system_health_stories/ folder can contain these extra
story_sets:
loading
scrolling & animation
multi_tabs
...
BUG=615382, 589726
Review-Url: https://codereview.chromium.org/2033693005
Cr-Commit-Position: refs/heads/master@{#397692}
MIPS64EL: Add clang compile flags for MIPS64r6
Adding clang flags for mips64r6 Android in gn and gyp (plus correcting mips32r6 flags in gyp),
though gyp is obsolete.
BUG=compile error
TEST=gn gen out-gn/mips64-android --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\" chrome_public_apk_use_chromium_linker=false is_clang=true"
ninja -C out-gn/mips64-android chrome_public_apk
Review-Url: https://codereview.chromium.org/2030003002
Cr-Commit-Position: refs/heads/master@{#397691}
Revert of [Chromedriver] Disable Java tests for Chrome 50 (patchset #1 id:1 of https://codereview.chromium.org/2032293002/ )
Reason for revert:
still causing crashes, these seem unrelated to the sandbox crash
Original issue's description:
> Reland of [Chromedriver] Disable Java tests for Chrome 50 (patchset #1 id:1 of https://codereview.chromium.org/2030753002/ )
>
> Reason for revert:
> Disabling tests again now that the sandbox issue appears to have been resolved (crrev.com/611886).
>
> Original issue's description:
> > Revert of [Chromedriver] Disable Java tests for Chrome 50 (patchset #2 id:20001 of https://codereview.chromium.org/2023303002/ )
> >
> > Reason for revert:
> > This CL causes random Java test failures on all desktop chromedriver bots.
> >
> > Original issue's description:
> > > [Chromedriver] Disable Java tests for Chrome 50
> > >
> > > BUG=chromedriver:1390
> > >
> > > Committed: https://crrev.com/5aaeb1c5aa8e862fc29ce0ea8237cc62abd2a0d1
> > > Cr-Commit-Position: refs/heads/master@{#397177}
> >
> > [email protected]
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=chromedriver:1390
> >
> > Committed: https://crrev.com/db5ed1e467aac345be87afaf24821a6b517f20ca
> > Cr-Commit-Position: refs/heads/master@{#397268}
>
> [email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=chromedriver:1390
>
> Committed: https://crrev.com/80a8bda52f9096c2a7f94ed5345a60d97c11b258
> Cr-Commit-Position: refs/heads/master@{#397628}
[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromedriver:1390
Review-Url: https://codereview.chromium.org/2038773003
Cr-Commit-Position: refs/heads/master@{#397690}
Removing parsing of text from pasteboard.
This patch modifies logic for drag and dropping text that can be parsed
as URL. Previously pasteboard would unconditionally answer that it
contains URL. For some cases it is better to process such text using
PasteAndGo logic.
[email protected], [email protected]
BUG=610620
Review-Url: https://codereview.chromium.org/2014733003
Cr-Commit-Position: refs/heads/master@{#397689}
tools/android/loading Compute instance count and timeout automatically
This CL introduces automatic computation of the instance
count and the timeout.
It tries to allocate enough instances to finish the job in
30 minutes.
If there are not enough instances available (because of quota
limits), then it uses all the available instances.
An estimation of the duration of the task is also now
displayed.
It should be almost always 30 minutes.
It can be more if there are not enough available instances,
and less if the task is very small.
Review-Url: https://codereview.chromium.org/2030033002
Cr-Commit-Position: refs/heads/master@{#397688}
Update Win7 baseline for fast/text/emoji-web-font.html
[email protected]
BUG=616969
Review-Url: https://codereview.chromium.org/2033403002
Cr-Commit-Position: refs/heads/master@{#397687}
Delete remaining unused function definitionss from CSSPrimitiveValue header
These functions were removed from the cpp file in
https://codereview.chromium.org/2002383002.
BUG=605792,606695
Review-Url: https://codereview.chromium.org/2036923002
Cr-Commit-Position: refs/heads/master@{#397686}
Add WTF::wrapArrayUnique().
The work of converting existing usage of OwnPtr has turned out that we
need to have an equivalent of adoptArrayPtr() for std::unique_ptr.
BUG=582354
Review-Url: https://codereview.chromium.org/2031253002
Cr-Commit-Position: refs/heads/master@{#397685}
Disable page_cycler_v2.typical_25 on Android One and Nexus 5X
[email protected]
BUG=615178,616781
Review-Url: https://codereview.chromium.org/2030243003
Cr-Commit-Position: refs/heads/master@{#397684}
[Loader] Add asserts about revalidation and redirects
After https://codereview.chromium.org/2011283002/ and
https://codereview.chromium.org/2017883002/, redirect chain must be empty
when revalidation starts or during revalidation is ongoing.
This CL adds asserts to verify that.
BUG=613971, 614989
Review-Url: https://codereview.chromium.org/2020253002
Cr-Commit-Position: refs/heads/master@{#397683}
Disable tables/mozilla/bugs/bug30692.html on Mac10.11
The test fails on Mac 10.11 after auto-rebaseline, see the bug for more info.
[email protected]
BUG=617033
Added NOTRY, because there is a lot of other breakage in Blink currently.
NOTRY=true
Review-Url: https://codereview.chromium.org/2031243002
Cr-Commit-Position: refs/heads/master@{#397682}
Set Event.composed flag correctly for some of UA UIEvents
See https://github.com/w3c/webcomponents/issues/513 for the context.
See also the previous CL: https://codereview.chromium.org/2012423004, where
Event.composed was introduced.
The change is visible only when Shadow DOM v1 is used.
BUG=531990,616654
Review-Url: https://codereview.chromium.org/2030243004
Cr-Commit-Position: refs/heads/master@{#397681}
Revert of Implement the script parts of custom element upgrade steps. (patchset #2 id:20001 of https://codereview.chromium.org/2035623002/ )
Reason for revert:
Speculative revert for breaking Win compile, will follow-up on the bug with more details soon.
Original issue's description:
> Implement the script parts of custom element upgrade steps.
>
> BUG=594918
>
> Committed: https://crrev.com/ee58801ba1e4a49cc2eea50d970444c7eeff9593
> Cr-Commit-Position: refs/heads/master@{#397676}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594918
Review-Url: https://codereview.chromium.org/2032373002
Cr-Commit-Position: refs/heads/master@{#397680}
Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #12 id:620001 of https://codereview.chromium.org/1982623002/ )
Reason for revert:
This broke the downstream clang-clankium-tot-builder, since PersonalDataManager at least is used by downstream autofill code to get profiles and credit cards: https://goto.google.com/kneae
Original issue's description:
> Sorted the profiles and credit cards to be used in PaymentRequest.
>
> Also added test methods to set the use count and use date of profiles and cards.
>
> BUG=609864
> TEST=PersonalDataManagerTestJava
>
> Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2
> Cr-Commit-Position: refs/heads/master@{#397562}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609864
Review-Url: https://codereview.chromium.org/2033323003
Cr-Commit-Position: refs/heads/master@{#397679}
Update V8 to version 5.3.121.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5298d6e1..9970e067
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2034043002
Cr-Commit-Position: refs/heads/master@{#397678}
Roll src/third_party/catapult/ 5bb047a8a..c502262d9 (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5bb047a8a69a..c502262d988b
$ git log 5bb047a8a..c502262d9 --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2036013003
Cr-Commit-Position: refs/heads/master@{#397677}
Implement the script parts of custom element upgrade steps.
BUG=594918
Review-Url: https://codereview.chromium.org/2035623002
Cr-Commit-Position: refs/heads/master@{#397676}
tools/android/loading: Allow disabling tracing categories
This CL adds the ability to disable categories that are enabled by default.
There is no reason not to support this now that a trace contains the
information of the categories that were enabled while producing the trace.
Review-Url: https://codereview.chromium.org/2037993002
Cr-Commit-Position: refs/heads/master@{#397675}
[Password Manager] Sending generated vote even if generation popup was shown, but the user didn't use the generated password
BUG=552420
Review-Url: https://codereview.chromium.org/1999093002
Cr-Commit-Position: refs/heads/master@{#397674}
headless: Migrate to URLRequestContextBuilder
Migrate to using URLRequestContextBuilder, which lets us remove a lot of
redundant network setup code.
BUG=616475
Review-Url: https://codereview.chromium.org/2033773002
Cr-Commit-Position: refs/heads/master@{#397673}
Roll WebRTC 13018:13026
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/0b3ccdb..91e542d
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2034023002
Cr-Commit-Position: refs/heads/master@{#397672}
Move CSSValuePool logic into CSSValue constructors
Remove all constructors from CSSValuePool, moving the logic out into
their respective CSSValue constructors. This way, callers don't need to
remember to use the CSSValue pool - it's handled automatically in each
class.
The CSSValuePool is still retained as a separate class to keep the
thread-safe logic centralized.
BUG=523893
Review-Url: https://codereview.chromium.org/2015463002
Cr-Commit-Position: refs/heads/master@{#397671}
PaymentRequest: Rename ShippingAddress to PaymentAddress.
Rename the address type since it will likely be used for other purpose.
Related spec links:
[1] https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentaddress-interface
[2] https://github.com/w3c/browser-payment-api/commit/576550c4de9f47feb889f8f7e587b2853e2da668
BUG=none
Review-Url: https://codereview.chromium.org/2020913002
Cr-Commit-Position: refs/heads/master@{#397670}
Fix WebRtcFrameScheduler to wait for first key frame request.
Previous the scheduler would start capturing before the stream is
negotiated, which was causing first few frames to be dropped. Now it
waits for the first key frame request.
BUG=616637
Review-Url: https://codereview.chromium.org/2035803002
Cr-Commit-Position: refs/heads/master@{#397669}
Disable some flaky WebUI tests on Win
These tests:
AdvancedSettingsWebUITest.testAdvancedSettingsShown
AutofillOptionsWebUITest.testOpenAutofillOptions
More info on the bug.
[email protected], [email protected]
BUG=617066
Review-Url: https://codereview.chromium.org/2036753003
Cr-Commit-Position: refs/heads/master@{#397668}
Shrink weak hash tables when adding elements, if needed.
Hash tables containing weak references tend to be asymmetrically
handled -- Blink "user code" will add elements to the hash table,
with the garbage collector taking care of removing references
to elements that have no other strong references to keep them
alive. The weak processing of hash tables isn't capable of
shrinking and allocate a new hash table backing store while
running, hence the table entries are only cleared.
Blink code will rarely do manual removals from these
collections, which gives the hash table no opportunity
to actually shrink the capacity of the backing store.
This can lead to hash tables with a very low load factor,
the majority of the entries be deleted and empty slots.
To allow for shrinking to happen over hash tables with
weak references, add() will check if shrinking is required.
R=
BUG=
Review-Url: https://codereview.chromium.org/2034883002
Cr-Commit-Position: refs/heads/master@{#397667}
Disable ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose on Win
It has been flaky on Win 7.
[email protected],[email protected],[email protected]
BUG=617056
Review-Url: https://codereview.chromium.org/2033333002
Cr-Commit-Position: refs/heads/master@{#397666}
SafeBrowsing: Change the api ThreatMetadata storage to a set.
This will avoid having duplicate permissions in the results.
BUG=561867
Review-Url: https://codereview.chromium.org/2012613005
Cr-Commit-Position: refs/heads/master@{#397665}
Revert of Switch WTF::find on LChar to use memchr. (patchset #1 id:1 of https://codereview.chromium.org/1948543004/ )
Reason for revert:
LSAN and MSAN bots appear unhappy:
http/tests/media/media-source/mediasource-is-type-supported.html
crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: =================================================================
STDERR: ==4==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000982af at pc 0x00000045811f bp 0x7fff2f309830 sp 0x7fff2f308fe0
STDERR: READ of size 5006 at 0x6030000982af thread T0 (content_shell)
STDERR: #0 0x45811e in memchr ??:0
STDERR: #1 0x3c5c419 in find third_party/WebKit/Source/wtf/text/StringImpl.h:532:9
STDERR: #2 0x3c5c419 in find third_party/WebKit/Source/wtf/text/StringImpl.h:660:0
STDERR: #3 0x3c5c419 in find third_party/WebKit/Source/wtf/text/WTFString.h:214:0
STDERR: #4 0x3c5c419 in find third_party/WebKit/Source/wtf/text/WTFString.h:215:0
STDERR: #5 0x3c5c419 in parameter third_party/WebKit/Source/platform/ContentType.cpp:50:0
STDERR: #6 0x8d64b7d in isTypeSupported third_party/WebKit/Source/modules/mediasource/MediaSource.cpp:244:33
STDERR: #7 0x9251198 in isTypeSupportedMethod ./out/Release/gen/blink/bindings/modules/v8/V8MediaSource.cpp:234:32
STDERR: #8 0x9251198 in isTypeSupportedMethodCallback ./out/Release/gen/blink/bindings/modules/v8/V8MediaSource.cpp:239:0
STDERR: #9 0x444b759 in Call v8/src/api-arguments.cc:16:3
(https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_ASAN/24421/layout-test-results/results.html)
Original issue's description:
> Switch WTF::find on LChar to use memchr.
>
> BUG=607208
>
> Committed: https://crrev.com/c9f9af30569ac2cd353e234f569052db6ab436f4
> Cr-Commit-Position: refs/heads/master@{#397568}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607208
Review-Url: https://codereview.chromium.org/2036993002
Cr-Commit-Position: refs/heads/master@{#397664}
Revert of ImageCapture: move mojom from WebKit/public to media/ (patchset #4 id:60002 of https://codereview.chromium.org/2027023002/ )
Reason for revert:
Appears to cause:
imagecapture/getphotocapabilities.html
imagecapture/takephoto.html
to timeout.
(https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/42976/layout-test-results/results.html)
Original issue's description:
> ImageCapture: move mojom from WebKit/public to media/
>
> This CL moves image_capture.mojom from
> {third_party/WebKit/public/platform/modules => media/mojo/interfaces}
> so the generated data types (e.g. PhotoCapabilities{Ptr})
> can be used from both Blink and media/capture locations.
>
> Also capture.gypi is trivially relocated to capture/ folder.
>
> Note that gyp files are -yay!- close to being finally
> removed.
>
> BUG=518807
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> Committed: https://crrev.com/64aec45d94682ae3b38c0f1c18ff74cd937ff9b5
> Cr-Commit-Position: refs/heads/master@{#397644}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807
Review-Url: https://codereview.chromium.org/2034003002
Cr-Commit-Position: refs/heads/master@{#397663}
NTPSnippetsDatabase: support multiple concurrent loads
(follow-up to https://codereview.chromium.org/1987333003)
So far, there are no multiple loads (yet), but this removes a weird wrinkle
from the API and doesn't really make anything any more complex.
BUG=605870
Review-Url: https://codereview.chromium.org/2033723002
Cr-Commit-Position: refs/heads/master@{#397662}
Allow transitions on background-size with positionally matched keywords
This change allows CSS transitions to interpolate between lists with
matching keywords.
This affects interpolation for the following properties:
- border-image-width
This property is not animatable according to spec:
https://drafts.csswg.org/css-backgrounds-3/#the-border-image-width
- background-size
Values are now interpolable if their keywords are positionally matched:
https://github.com/w3c/csswg-drafts/commit/a5f9de921fa7834c79ee15660d9d86528bce1607
- -webkit-background-size
- -webkit-mask-size
These mirror the animation behaviour of background-size.
This change only affects CSS Transitions for the sake of a small mergable patch.
CSS Animations behaviour will be brought in line in a separate patch.
This change ensures we have compatible behaviour with other browsers for
transitioning between single length background-size values e.g.
"background-size: 50%" to "background-size: 100%"
BUG=616072
Review-Url: https://codereview.chromium.org/2027933002
Cr-Commit-Position: refs/heads/master@{#397661}
Upgrade in-document custom elements when an element is defined.
BUG=594918
Review-Url: https://codereview.chromium.org/2023093003
Cr-Commit-Position: refs/heads/master@{#397660}
Change text size in Android omnibox suggestions to 16sp.
Also, get rid of some manual size calculations in SuggestionView.
Before: https://i.imgur.com/upCukiB.png
After: https://i.imgur.com/6YELA3L.png
BUG=614165
Review-Url: https://codereview.chromium.org/2020403003
Cr-Commit-Position: refs/heads/master@{#397659}
Preparing for characteristics discovery
Mock services should be removed when simulating disconnect.
Renaming -[MockCBPeripheral didDiscoverWithError:] into
-[MockCBPeripheral didDiscoverServicesWithError:].
BUG=None
Review-Url: https://codereview.chromium.org/2026193002
Cr-Commit-Position: refs/heads/master@{#397658}
Roll src/third_party/catapult/ 347d0200c..5bb047a8a (1 commit).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/347d0200ca51..5bb047a8a69a
$ git log 347d0200c..5bb047a8a --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2035033002
Cr-Commit-Position: refs/heads/master@{#397657}
Auto-rebaseline for r397648
https://chromium.googlesource.com/chromium/src/+/f4e652e16
BUG=616969
[email protected]
Review URL: https://codereview.chromium.org/2036093002 .
Cr-Commit-Position: refs/heads/master@{#397656}
Make StyleBuilder take const CSSValue&
Make StyleBuilder take const CSSValue& instead of CSSValue*. This is
more semantically correct and safe, and is now possible since
StyleBuilderFunctions takes const CSSValue&s.
BUG=526586
Review-Url: https://codereview.chromium.org/2033893003
Cr-Commit-Position: refs/heads/master@{#397655}
:in-range and :out-of-range CSS selectors should check 'have range limitations.'
Spec.: https://html.spec.whatwg.org/multipage/scripting.html#selector-in-range
These CSS selectors should work only if |min| or |max| attribute has a valid value
except for input[type=range] which has default minimum/maximum values.
BUG=603268
Review-Url: https://codereview.chromium.org/2033323002
Cr-Commit-Position: refs/heads/master@{#397654}
Update V8 to version 5.3.120.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bad41a76..5298d6e1
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2033303002
Cr-Commit-Position: refs/heads/master@{#397653}
Remove base::Tuple
base::Tuple has been an alias of std::tuple for the migration. And this
CL completes the migration by:
- Replace base::Tuple with std::tuple,
- Replace base::MakeTuple with std::make_tuple,
- Replace base::get with std::get,
- Remove base::Tuple, base::MakeTuple, base::get and base::MakeRefTuple
BUG=554987
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2023243002
Cr-Commit-Position: refs/heads/master@{#397652}
Since these hidden/overrides are not used in cras_unified_unittest, we can safely delete them.
BUG=616875
TEST=unittest passes after the change
Review-Url: https://codereview.chromium.org/2032183002
Cr-Commit-Position: refs/heads/master@{#397651}
Make revalidation to fail when received a redirect response
BUG=614989
Review-Url: https://codereview.chromium.org/2017883002
Cr-Commit-Position: refs/heads/master@{#397650}
service worker: Avoid starting up for activation during shutdown
Activation is prone to start failures due to browser shutdown, since
it's triggered when tabs close. This patch:
- Delays activation for a second, when triggered by tab close
- Tries to detect when shutdown happened when activation fails
BUG=600226
Review-Url: https://codereview.chromium.org/2027583002
Cr-Commit-Position: refs/heads/master@{#397649}
Avoid one temporary copy on web fonts decoding
Before this CL, we allocated a temporary SharedBuffer to store decoded
font data. Since the decoded data is only used to create SkTypeface we don't
need to have such abstraction. Create SkTypeface directly from the decoded
data. This CL also renamed and moved platform/fonts/opentype/OpenTypeSanitizer
to platform/fonts/WebFontDecoder for better naming.
BUG=616969
Review-Url: https://codereview.chromium.org/2032943002
Cr-Commit-Position: refs/heads/master@{#397648}
Remove 'unsafe-redirect' measurement.
1. We've removed this notion from the spec; it was a bad idea.
2. The numbers were way too high anyway: ~0.8%[1]
Removing the counter also lets us marginally simplify
'FrameFetchContext::canRequestInternal'.
[1]: https://www.chromestatus.com/metrics/feature/timeline/popularity/709
[email protected]
Review-Url: https://codereview.chromium.org/2033693002
Cr-Commit-Position: refs/heads/master@{#397647}
Mac: Move remote layer use to GpuOutputSurfaceMac
Move the logic for managing remote layers from AcceleratedWidgetMac
to GpuOutputSurfaceMac. Change AcceleratedWidgetMac's interface to take
CALayers for new content, not remote handles (CAContextIDs).
In future patches, GpuOutputSurfaceMac will instantiate a
CALayerTreeCoordinatorMac locally (as opposed to in the GPU process),
and will present the resulting CALayers directly.
BUG=604052
Review-Url: https://codereview.chromium.org/2018793002
Cr-Commit-Position: refs/heads/master@{#397646}
Only SchedulePaint on ShelfWidget if background changes.
This is called whenever a toplevel window is moved, and was always doing
a SchedulePaint even if no property changed. The BackgroundAnimator will
do an UpdateBackground if the alpha changes, so the higher-level
SchedulePaint is redundant.
BUG=614193
Review-Url: https://codereview.chromium.org/2012063002
Cr-Commit-Position: refs/heads/master@{#397645}
ImageCapture: move mojom from WebKit/public to media/
This CL moves image_capture.mojom from
{third_party/WebKit/public/platform/modules => media/mojo/interfaces}
so the generated data types (e.g. PhotoCapabilities{Ptr})
can be used from both Blink and media/capture locations.
Also capture.gypi is trivially relocated to capture/ folder.
Note that gyp files are -yay!- close to being finally
removed.
BUG=518807
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
Review-Url: https://codereview.chromium.org/2027023002
Cr-Commit-Position: refs/heads/master@{#397644}
Add ability to toggle passive state on an individual event listener.
Add a button to allow the toggle of the passive state on a listener.
It is not implemented for framework listeners yet since this will likely
interfere with the dipsatching of events in jquery if it was enabled.
BUG=615480
Review-Url: https://codereview.chromium.org/2022503002
Cr-Commit-Position: refs/heads/master@{#397643}
Add scroll threshold for app list for mouse wheel events.
This CL fixes an issue with touchpad events being read as mousewheel
events and causing jank on touchpad scroll in the app list. Instead of
figuring out the whole stack and why the wrong event is coming in, just
use the scroll threshold everywhere.
BUG=594264
Review-Url: https://codereview.chromium.org/2029993002
Cr-Commit-Position: refs/heads/master@{#397642}
Refactor ClipRecorder to take an IntRect instead of a LayoutRect
ClipRecorder silently pixel snapped its LayoutRect clip even though
almost all callers are actually clipping an IntRect. This patch pushes
all clip snapping up to the clip recorder callsites.
The remaining pixel snapping cases may seem like they should be using
enclosingIntRect(), but changing these cases results in real pixel test
failures.
BUG=440288
Review-Url: https://codereview.chromium.org/2038663002
Cr-Commit-Position: refs/heads/master@{#397641}
[DevTools] Added missing timeline_model/module.json
This module was added in https://codereview.chromium.org/2018713003.
Without it in devtools_module_json_files layout test debugging via remote debugging doesn't work.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2038683003
Cr-Commit-Position: refs/heads/master@{#397640}
[tracing] Only add totals from discardable memory in background mode
For background tracing mode only totals can be added to the trace to
keep traces light. So only add total numbers from discardable memory
dump provider.
BUG=613198
Review-Url: https://codereview.chromium.org/2012763004
Cr-Commit-Position: refs/heads/master@{#397639}
Add ServiceWorker.StartWorker.Time UMA breakdown by EventType
BUG=561209
Review-Url: https://codereview.chromium.org/2025603002
Cr-Commit-Position: refs/heads/master@{#397638}
Merge subprocess metrics into global StatisticsRecorder.
BUG=546019
Review-Url: https://codereview.chromium.org/2023253002
Cr-Commit-Position: refs/heads/master@{#397637}
Fix pylint unused-* warnings in webkitpy/tool.
This includes:
unused-variable
unused-argument
unused-import
In some cases, unused arguments are there for method because the argument is required by the superclass or may be used in subclasses; in these cases I added a pylint disable pragma comment.
BUG=598897
Review-Url: https://codereview.chromium.org/2019923002
Cr-Commit-Position: refs/heads/master@{#397636}
the sanitizer builders expect d8 to be build. Make that explicit.
BUG=609107
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2018423002
Cr-Commit-Position: refs/heads/master@{#397635}
Add UMA to track time between preload discovery and first bytes of response
BUG=603274
Review-Url: https://codereview.chromium.org/2020323003
Cr-Commit-Position: refs/heads/master@{#397634}
H264POC: Re-compute PicOrderCnt for duplicate frame_nums.
Some videos violate the H.264 spec by having sequential frames with the
same |frame_num|. This CL changes H264POC to match the behavior of
H264Decoder in that case.
BUG=615289
Review-Url: https://codereview.chromium.org/2011353003
Cr-Commit-Position: refs/heads/master@{#397633}
Roll src/third_party/catapult/ 3a308b4e6..347d0200c (2 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3a308b4e6d56..347d0200ca51
$ git log 3a308b4e6..347d0200c --date=short --no-merges --format='%ad %ae %s'
[email protected]
Review-Url: https://codereview.chromium.org/2030273002
Cr-Commit-Position: refs/heads/master@{#397632}
Convert track-webvtt-tc[030-032] tests to testharness.js
Cleaning up track-webvtt-tc[030-032] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2035753002
Cr-Commit-Position: refs/heads/master@{#397631}
MediaRecorder: parameterise certain browsertests by video codec and/or encode accelerator
Extended certain test to use VP8, VP9 and H264, with and without
video encode accelerator.
BUG=614235
Review-Url: https://codereview.chromium.org/2027323003
Cr-Commit-Position: refs/heads/master@{#397630}
Auto-rebaseline for r397582
https://chromium.googlesource.com/chromium/src/+/3feed678d
BUG=547938
[email protected]
Review URL: https://codereview.chromium.org/2036063002 .
Cr-Commit-Position: refs/heads/master@{#397629}
Reland of [Chromedriver] Disable Java tests for Chrome 50 (patchset #1 id:1 of https://codereview.chromium.org/2030753002/ )
Reason for revert:
Disabling tests again now that the sandbox issue appears to have been resolved (crrev.com/611886).
Original issue's description:
> Revert of [Chromedriver] Disable Java tests for Chrome 50 (patchset #2 id:20001 of https://codereview.chromium.org/2023303002/ )
>
> Reason for revert:
> This CL causes random Java test failures on all desktop chromedriver bots.
>
> Original issue's description:
> > [Chromedriver] Disable Java tests for Chrome 50
> >
> > BUG=chromedriver:1390
> >
> > Committed: https://crrev.com/5aaeb1c5aa8e862fc29ce0ea8237cc62abd2a0d1
> > Cr-Commit-Position: refs/heads/master@{#397177}
>
> [email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromedriver:1390
>
> Committed: https://crrev.com/db5ed1e467aac345be87afaf24821a6b517f20ca
> Cr-Commit-Position: refs/heads/master@{#397268}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromedriver:1390
Review-Url: https://codereview.chromium.org/2032293002
Cr-Commit-Position: refs/heads/master@{#397628}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //sync
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2034503003
Cr-Commit-Position: refs/heads/master@{#397627}
Make updateMarkerRenderedRect() to dispose temporary Range object after use
This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to
dispose temporary |Range| object after use to prevent increasing number of
active |Range| object for avoiding slow down of DOM mutation operations.
Note: This patch is a temporary solution, we'll have |EphemeralRange| version
later.
BUG=613658
TEST=n/a; This is temporary solution, we'll have another solution later.
Review-Url: https://codereview.chromium.org/2034753003
Cr-Commit-Position: refs/heads/master@{#397626}
[Fetch API] Request's JS wrapper should be kept alive in FetchEvent
From the same reason as [1], we need to keep blink::Request's wrapper
in FetchEvent and ForeignEvent's wrappers. This CL adds hidden
values in order to teach v8 the dependency.
1: https://crrev.com/d4b43c621eb323605c258a1a7f238bf9d6fb7523
BUG=614272
Review-Url: https://codereview.chromium.org/2025143003
Cr-Commit-Position: refs/heads/master@{#397625}
Switch font proxy message filter to run on FILE_USER_BLOCKING thread
Speculative fix for 594967. Since the bug seems to occur or be worse when
downloading images or files, it might be due to the file thread being busy.
Since all the IO the font proxy does is fast it should have little impact
on responsiveness, and not blocking on other IO will improve renderer
responsiveness.
BUG=594967
Review-Url: https://codereview.chromium.org/2028163002
Cr-Commit-Position: refs/heads/master@{#397624}
Record offline histograms with suffix via Histogram::FactoryGet
Also move all offline client namespace constants into one central place.
BUG=616231
[email protected]
Committed: https://crrev.com/8ccbcdc96179ab65038e17cdbddc149e28754830
Cr-Commit-Position: refs/heads/master@{#397233}
Review-Url: https://codereview.chromium.org/2022283003
Cr-Commit-Position: refs/heads/master@{#397623}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //ipc
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2036003002
Cr-Commit-Position: refs/heads/master@{#397622}
MD Settings: remove @apply(--layout*); in settings
--layout mixins just have cross-platform versions of flex box stuff,
which is not useful in Chrome-only UI.
[email protected]
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2029833002
Cr-Commit-Position: refs/heads/master@{#397621}
Do not use a non-standard label attribute in shadow-dom.js
See https://codereview.chromium.org/2030513002#msg22 for the context.
Use id, instead of label.
BUG=531990
Review-Url: https://codereview.chromium.org/2036933002
Cr-Commit-Position: refs/heads/master@{#397620}
[chromoting] Use Event to render feedback animations.
This change moves FeedbackAnimator into a standalone class, with a startAnimation static function to register a SelfRemovableParameterRunnable into onPaint event of DesktopView. After animation finishes, the SelfRemovableParameterRunnable will be removed from onPaint event automatically.
This change is part of Chromoting Android Client Refactor work. A design doc can
be found at https://goo.gl/MA6zjx.
BUG=615277
Review-Url: https://codereview.chromium.org/2023133002
Cr-Commit-Position: refs/heads/master@{#397619}
[DevTools] Fix problem with loading source maps
Encode not utf8 chunk as base 64 and then decode it on frontend side.
BUG=611328
[email protected]
Review-Url: https://codereview.chromium.org/2032013003
Cr-Commit-Position: refs/heads/master@{#397618}
Update V8 to version 5.3.119.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/732d1cca..bad41a76
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2037703003
Cr-Commit-Position: refs/heads/master@{#397617}
Handle uncommitted PaintController in DisplayItemClient aliveness tracking
crbug.com/616700 is a case that PaintController is not committed before
destructed.
Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.
Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.
[1] https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3ADisplayItemClient%3A%3A~DisplayItemClient%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=aa1bbf9c00000000&index=3#0
BUG=609218,616700
Review-Url: https://codereview.chromium.org/2027333004
Cr-Commit-Position: refs/heads/master@{#397616}
Blink Compositor Animation: Erase CompositorAnimationsImpl.h
Make CompositorAnimations class STATIC_ONLY.
BUG=577016
Review-Url: https://codereview.chromium.org/2023143002
Cr-Commit-Position: refs/heads/master@{#397615}
Consider start time for frame painting and fix naming in test.
These changes were accidentally dropped from the final commit after
approval in previous review: https://codereview.chromium.org/2007463005
BUG=614099
TBR=xhwang
Review-Url: https://codereview.chromium.org/2034903002
Cr-Commit-Position: refs/heads/master@{#397614}
Updating trunk VERSION from 2757.0 to 2758.0
Cr-Commit-Position: refs/heads/master@{#397613}
Adding scoped_nsobject for MockCBService
BUG=None
Review-Url: https://codereview.chromium.org/2025013003
Cr-Commit-Position: refs/heads/master@{#397612}
Fix unit of a UMA
This is a follow-up CL of http://crrev.com/2003293003/
WindowProxy::initialize is measured in us, while UMA page displayed it in ms.
This CL changes to use us (microseconds) in UMA page.
BUG=325923, 588893
Review-Url: https://codereview.chromium.org/2031993002
Cr-Commit-Position: refs/heads/master@{#397611}
LockCompositingSurface to make sure frame is not evicted.
1.LockCompositingSurface before placing a CopyOutputRquest on SurfaceLayer.
2.When receiving texture as response in PrepareTextureCopyOutputResult call
UnlockCompositingSurface.
3.Do early return if checks are not met.
4.Now CopyFromCompositingSurface internally locks and unlocks the surface when
needed, so remove any external lock/unlock usage.
BUG=NONE.
Review-Url: https://codereview.chromium.org/2021003002
Cr-Commit-Position: refs/heads/master@{#397610}
CC Animation: Erase EaseTimingFunction helpers.
Ease*TimingFunction are static-only helpers, unrelated to base class
TimingFunction.
BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2032643003
Cr-Commit-Position: refs/heads/master@{#397609}
Use plural formats and native digits
With codesearch, look for '<ex>[0-9]+</ex> file:grd'. Review each of
matches and change them to use plural formats(C++), toLocaleString(JavaScript),
or other i18n-safe ways.
Moreover, change GetStringFUTF16Int() to use 'FormatNumber' instead
of Int*ToString(). Call sites of GetStringFUTF16Int() were reviewed
Where native digits are not appropriate (non-UI), call sites were
adjusted.
Besides, add a warning about 'ASCII digits vs native digits' to
base/strings/string_number_conversions.h and add more details
on GetPlural* to ui/base/l10n/l10n_util.h.
BUG=613331
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.blink:linux_blink_rel,mac_blink_rel
Review-Url: https://codereview.chromium.org/2002783002
Cr-Commit-Position: refs/heads/master@{#397608}
Implement gfx::Vector2d and gfx::Vector2dF StructTraits
These are needed for cc::CompositorFrameMetadata
BUG=611802
Review-Url: https://codereview.chromium.org/2033583002
Cr-Commit-Position: refs/heads/master@{#397607}
MacViews: Treat Ctrl+LeftClick as RightClick on Mac.
Alters EventFlagsFromNSEventWithModifiers to check for Ctrl in the
NSEvent modifierFlags and make a left click a right click. Removes the
Ctrl modifier in such cases.
Mac lets you disable "secondary click" completely in Trackpad settings,
which leaves Ctrl+Click as the only way to "right"-click, so we should
support this. There isn't a system setting that disables Ctrl+Click.
Apart from MacViews, EventFlagsFromNSEventWithModifiers is currently
used by the browser back button and (when DevTools is attached) the
reload button, but only for feeding modifiers to
ui::MenuModel::ActivatedAt(index, flags). They use
ui::DispositionFromEventFlags(..) which only cares about middle-clicks
(and -for Mac- the Command modifier, which isn't altered by this CL) so
there's no behaviour change for Cocoa with this CL.
The browser back button itself (a ClickHoldButtonCell) still doesn't
respect Ctrl+LeftClick (http://crbug.com/616357). But that's orthogonal.
BUG=616650
Review-Url: https://codereview.chromium.org/2025943003
Cr-Commit-Position: refs/heads/master@{#397606}
Remove pepper_messages.h.
BUG=616963
Review-Url: https://codereview.chromium.org/2024403002
Cr-Commit-Position: refs/heads/master@{#397605}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //gpu
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2036723003
Cr-Commit-Position: refs/heads/master@{#397604}
Re-enable WebGL Image Chromium.
This CL makes DrawingBuffer use the newly added DescheduleUntilFinishedCHROMIUM,
and turns on IOSurface backed WebGL by default.
BUG=581777
Review-Url: https://codereview.chromium.org/2025973002
Cr-Commit-Position: refs/heads/master@{#397603}
Update WindowTreeClientImpl OnWindowDestroying
Update capture handling, forcing the queue to revert to null capture is incorrect. The in flight queue is listening for window destruction, and updates the revert target appropriately.
Capture does not need to be explicitly released here. mus::Window removes focus upon destruction. The in flight queue listens for this to update revert target appropriately.
TEST=views_mus_unittests, mus_public_unittests
BUG=611983
Review-Url: https://codereview.chromium.org/2021383002
Cr-Commit-Position: refs/heads/master@{#397602}
Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available"
Because we came across issues in some CrOS platforms in HW H264 encode,
we decided to revert this CL such that HW H264 is only enabled for MacOSX.
Please see the bug below for details.
BUG=615272
Review-Url: https://codereview.chromium.org/2030833002
Cr-Commit-Position: refs/heads/master@{#397601}
WebAPKs: Open links which are outside of WebAPK scope in Chrome not in WebAPK
BUG=609122
TEST=ExternalNavigationHandlerTest.*
Review-Url: https://codereview.chromium.org/2005053002
Cr-Commit-Position: refs/heads/master@{#397600}
Disable flaky SendCloseFrameWhenTabIsClosed
TBR=rsleevi
BUG=616958
Review-Url: https://codereview.chromium.org/2038713002
Cr-Commit-Position: refs/heads/master@{#397599}
[Mac][Material Design] Fix MD bookmarks button focus ring regression.
After the Material Design changes to the bookmarks bar the focus rings
no longer align with the button images.
[email protected]
BUG=613124
Review-Url: https://codereview.chromium.org/2030233003
Cr-Commit-Position: refs/heads/master@{#397598}
Mojo + WebUI: Cleanup chrome://omnibox.
- Stop creating a new delegate on every startOmniboxQuery() call.
- Reduce boilerplate setup code by using the new
connection.bindStubDerivedImpl() method.
- Rename interface name mojom::OmniboxUIHandlerMojo to
mojom::OmniboxPageHandler
This cleanup converts the chrome://omnibox WebUI to follow the pattern used in
chrome://plugins to establish 2-way communication between JS and C++.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2025143002
Cr-Commit-Position: refs/heads/master@{#397597}
Ignore null events sent from GestureDetector
BUG=613069
Review-Url: https://codereview.chromium.org/2025403002
Cr-Commit-Position: refs/heads/master@{#397596}
Update the documentation for NetLog's ThreadSafeObserver to better explain the guarantees around threading.
Review-Url: https://codereview.chromium.org/2029253004
Cr-Commit-Position: refs/heads/master@{#397595}
[Extensions] DCHECK that ExtensionFunctions respond (and only once)
If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.
Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.
One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.
BUG=616593
[email protected] (c/b/chromeos, c/b/ui/webui/chromeos)
[email protected] (c/b/policy)
[email protected] (c/t/ppapi)
Review-Url: https://codereview.chromium.org/2017113002
Cr-Commit-Position: refs/heads/master@{#397594}
Fix MockFileSystem.walk and add test.
BUG=616529
Review-Url: https://codereview.chromium.org/2029823002
Cr-Commit-Position: refs/heads/master@{#397593}
cc: Convert some more GPU IDC functionality to member functions.
This patch moves uplodaded data access to be behind functions. The
intent here is to be able to add usage statistics and it makes it a lot
easier to add if the access is guarded through a set of functions.
R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2020203005
Cr-Commit-Position: refs/heads/master@{#397592}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //content
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2036893002
Cr-Commit-Position: refs/heads/master@{#397591}
Some existing tests started failing after color fonts landed. Not sure why the tryjob didn't catch them. Adding new baselines in any case.
BUG=616692
Review-Url: https://codereview.chromium.org/2036843002
Cr-Commit-Position: refs/heads/master@{#397590}
[ios Mojo] Renamed service provider to service registry.
This name matches other platforms, which made the change here:
https://codereview.chromium.org/1827473002
BUG=None
Review-Url: https://codereview.chromium.org/2031893003
Cr-Commit-Position: refs/heads/master@{#397589}
MD Site Settings: Add icons for a few categories.
BUG=614277, 614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2030203002
Cr-Commit-Position: refs/heads/master@{#397588}
ash: Remove aura dependencies from ash/system/web_notification
* Switch to common wm:WmWindow types.
* Convert unit tests to use views::Widget instead of aura::Window
No functional changes.
TODO: Figure out how to set window parents in ui/message_center without
using aura.
BUG=615155
TEST=existing ash_unittests
Review-Url: https://codereview.chromium.org/2033833002
Cr-Commit-Position: refs/heads/master@{#397587}
Extract analyze-baselines command out of rebaseline.py.
BUG=616967
Review-Url: https://codereview.chromium.org/2019243002
Cr-Commit-Position: refs/heads/master@{#397586}
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc
We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.
BUG=611802
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2034863002
Cr-Commit-Position: refs/heads/master@{#397585}
Blimp: Reduced logging serverity for assignment error
Blimp client currently crashes with a fatal error message when there is
a client-engine version mismatch. The crash is so fast that it doesn't
give a chance for the user to try connecting with a different assigner.
Reduced the logging level from FATAL to ERROR for assigner response.
BUG=615205
Review-Url: https://codereview.chromium.org/2033273002
Cr-Commit-Position: refs/heads/master@{#397584}
Notifications: Remove unused resources.
BUG=613358
Review-Url: https://codereview.chromium.org/2029643002
Cr-Commit-Position: refs/heads/master@{#397583}
Fix the interop issue for list-style:inside items. W3C spec http://www.w3.org/TR/css3-lists/#ua-stylesheet recommends 1em margin for markers. Unlike other browsers (verified with Edge and Firefox) Chrome does not follow UA stylesheet recommendation.
The fix is temporarily landed in LayoutListMarker.cpp. Default UA CSS should be moved to WebKit/Source/core/css/html.css after crbug.com/457718 is fixed.
BUG=547938
Review-Url: https://codereview.chromium.org/2023433002
Cr-Commit-Position: refs/heads/master@{#397582}
Retry icon fetching after intent_helper is ready.
* Modify ActivityIconLoader::GetActivityIcon() so it returns
an error code.
* Modify ArcProcessTask so it calls GetActivityIcon() again
when the function returns a temporary error.
BUG=616159
TEST=All ARC tasks in Task Manager have their icons
Review-Url: https://codereview.chromium.org/2034543003
Cr-Commit-Position: refs/heads/master@{#397581}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //chrome
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2030013003
Cr-Commit-Position: refs/heads/master@{#397580}
[Sync] Fix minor credit card sync UI glitch on Android.
BUG=615519
Review-Url: https://codereview.chromium.org/2035893002
Cr-Commit-Position: refs/heads/master@{#397579}
Roll src/third_party/catapult/ 857c0b7e4..3a308b4e6 (12 commits).
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/857c0b7e4db6..3a308b4e6d56
$ git log 857c0b7e4..3a308b4e6 --date=short --no-merges --format='%ad %ae %s'
BUG=352807,616832,608414,616483
[email protected]
Review-Url: https://codereview.chromium.org/2033963002
Cr-Commit-Position: refs/heads/master@{#397578}
Add a disclaimer to the Help page when user switches to dev channel
This adds a warning message to the channel section in the help page to
be shown when the dev-channel is selected.
Screenshot: https://drive.google.com/file/d/0B076wceBjPqTOW1VeHpZV3R3UUU/view?usp=sharing
BUG=616796
TEST=manually by going to chrome://chrome and changing the channel to dev.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2033253002
Cr-Commit-Position: refs/heads/master@{#397577}
Rename 'items' into 'displayItems' in PaymentDetails.
This patch renames PaymentDetails.items into PaymentDetails.displayItems
to follow the spec updates. This patch does not introduce 100%
compliance with the spec. It is a simple search-and-replace patch.
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f
BUG=587995
Review-Url: https://codereview.chromium.org/2028603004
Cr-Commit-Position: refs/heads/master@{#397576}
Blimp Engine is based on Linux with USE_AURA, and its client is an Android app. It is desirable for end users to see the same Chrome Android external popup menu handling.
Thus, add USE_EXTERNAL_POPUP_MENU flag so that Blimp Engine can follow the same code path of the external Android popup menus before it reaches WebContentsView.
BUG=598764
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1992393002
Cr-Commit-Position: refs/heads/master@{#397575}
Turn on swarming for all Android tests on linux_android_rel_ng.
BUG=525873
NOTRY=true
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2032263002
Cr-Commit-Position: refs/heads/master@{#397574}
Print an error if browser start fails due to no X display.
Review-Url: https://codereview.chromium.org/2035763002
Cr-Commit-Position: refs/heads/master@{#397573}
Update V8 to version 5.3.117.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5bca5221..732d1cca
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2034943002
Cr-Commit-Position: refs/heads/master@{#397572}
Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools
The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()
BUG=581865
Review-Url: https://codereview.chromium.org/2036013002
Cr-Commit-Position: refs/heads/master@{#397571}
SafeBrowsing: Implement cache eviction for API full hash results.
BUG=561867
Review-Url: https://codereview.chromium.org/2009133005
Cr-Commit-Position: refs/heads/master@{#397570}
Moves mash/wm into ash/mus
Namespaces have been updated as well. Unfortunately this necessitated
::mus in lots of places.
BUG=616265
TEST=none
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2029883002
Cr-Commit-Position: refs/heads/master@{#397569}
Switch WTF::find on LChar to use memchr.
BUG=607208
Review-Url: https://codereview.chromium.org/1948543004
Cr-Commit-Position: refs/heads/master@{#397568}
[Cronet]Make delaying sending request headers explicit in bidirectional stream
Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.
This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.
BUG=599902
Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
Roll src/third_party/skia/ f95ff4a37..6fb2391b2 (10 commits).
https://chromium.googlesource.com/skia.git/+log/f95ff4a37aba..6fb2391b2cc8
$ git log f95ff4a37..6fb2391b2 --date=short --no-merges --format='%ad %ae %s'
2016-06-02 scroggo Make SkPngCodec decode progressively.
2016-06-02 scroggo Check libpng directly into third_party/
2016-06-02 halcanary SkMultiPictureDocument & SkMultiPictureDocumentReader
2016-06-02 reed add MakeS32 helper to SkImageInfo, fix named-gamma constructor bug
2016-06-02 liyuqian Implement OpenGL backend in Android viewer app
2016-06-02 brianosman Fix argument parsing in android app launcher script
2016-06-02 senorblanco Tessellator: stop copying vertices into Polys and Monotones.
2016-06-02 robertphillips Adjust tolerance for when Ganesh stroked-line-as-rect optimization kicks in
2016-06-02 bungeman Remove SK_SUPPORT_LEGACY_TYPEFACE_MAKE_FROM_NAME.
2016-06-02 brianosman Exclude Mali devices from manual mip-mapping.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2031933003
Cr-Commit-Position: refs/heads/master@{#397566}
Add unit tests for ArcBridgeService::RemoveObserver()
to make sure that passing unknown pointers to the function is
harmless. https://codereview.chromium.org/2034543003/ for example
relies on the behavior.
BUG=None
TEST=try
Review-Url: https://codereview.chromium.org/2031143002
Cr-Commit-Position: refs/heads/master@{#397565}
telemetry: Add scrolling power test.
The test creates a page full of text and slowly scrolls it using
requestAnimationFrame.
BUG=616811
Review-Url: https://codereview.chromium.org/1998433003
Cr-Commit-Position: refs/heads/master@{#397564}
Make rebaseline_unittest only use test- ports.
BUG=279494
Review-Url: https://codereview.chromium.org/2017783002
Cr-Commit-Position: refs/heads/master@{#397563}
Sorted the profiles and credit cards to be used in PaymentRequest.
Also added test methods to set the use count and use date of profiles and cards.
BUG=609864
TEST=PersonalDataManagerTestJava
Review-Url: https://codereview.chromium.org/1982623002
Cr-Commit-Position: refs/heads/master@{#397562}
Revert of Use logical instead of on-the-wire HTTP/2 weight values. (patchset #2 id:20001 of https://codereview.chromium.org/2035653002/ )
Reason for revert:
Broke the mac build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/156064
Original issue's description:
> Use logical instead of on-the-wire HTTP/2 weight values.
>
> Modify SpdyPriorityIR and SpdyFramerVisitorInterface::OnPriority() to use
> actual/logical HTTP/2 weight values in the range [1, 256], as opposed to the
> on-the-wire representation as ints in the range [0, 255]. (The difference
> between the on-the-wire and actual weight value is specified in
> https://tools.ietf.org/html/rfc7540#section-6.3).
>
> Also remove legacy SpdyFramer methods MapPriorityToWeight() and
> MapWeightToPriority(), which used on-the-wire weight values, and are superceded
> by the Spdy3PriorityToHttp2Weight() and Http2WeightToSpdy3Priority() functions
> in spdy_priority.{h,cc}.
>
> This CL lands server changes 116911302 by mpw
> and 123774531 and 123892187 by bnc.
>
> BUG=488484
>
> Committed: https://crrev.com/7aec5276f9b0c5bf481f92494f537967828b61eb
> Cr-Commit-Position: refs/heads/master@{#397557}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488484
Review-Url: https://codereview.chromium.org/2023353005
Cr-Commit-Position: refs/heads/master@{#397561}
[Autofill] Remove unused class FindByPhone.
BUG=None
TEST=Existing
Review-Url: https://codereview.chromium.org/2037753002
Cr-Commit-Position: refs/heads/master@{#397560}
cursor renderer: Fix null pointer dereference
It appears the activation client on a root window could be null in some
scenarios (perhaps in some state of window being closed ?). Adds a check
to avoid the dereference when it is null.
BUG=616632
Review-Url: https://codereview.chromium.org/2037663004
Cr-Commit-Position: refs/heads/master@{#397559}
mash: Remove aura references from ash/system/user (for status tray menu)
This is part of the migration to ash/common types.
No functional changes.
BUG=existing ash_unittests, system shuts down cleanly even with add user menu
open
Review-Url: https://codereview.chromium.org/2034913003
Cr-Commit-Position: refs/heads/master@{#397558}
Use logical instead of on-the-wire HTTP/2 weight values.
Modify SpdyPriorityIR and SpdyFramerVisitorInterface::OnPriority() to use
actual/logical HTTP/2 weight values in the range [1, 256], as opposed to the
on-the-wire representation as ints in the range [0, 255]. (The difference
between the on-the-wire and actual weight value is specified in
https://tools.ietf.org/html/rfc7540#section-6.3).
Also remove legacy SpdyFramer methods MapPriorityToWeight() and
MapWeightToPriority(), which used on-the-wire weight values, and are superceded
by the Spdy3PriorityToHttp2Weight() and Http2WeightToSpdy3Priority() functions
in spdy_priority.{h,cc}.
This CL lands server changes 116911302 by mpw
and 123774531 and 123892187 by bnc.
BUG=488484
Review-Url: https://codereview.chromium.org/2035653002
Cr-Commit-Position: refs/heads/master@{#397557}
[MD Feedback] Add basic chrome://feedback dialog.
This adds a basic dialog delegate and controller to house the feedback WebUI. The dialog is not anchored or constrained to any other browser window.
Show() is only implemented for views. Mac will be done in a separate patch.
BUG=615533
Review-Url: https://codereview.chromium.org/2021753005
Cr-Commit-Position: refs/heads/master@{#397556}
Ink Drop now tracks whether mouse is over the control or not:
BUG=538238
Review-Url: https://codereview.chromium.org/2021583002
Cr-Commit-Position: refs/heads/master@{#397555}
Simplify StructTraits tests
Using sync method calls simplifies unit tests. I've switched the exists
tests over.
BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2030173002
Cr-Commit-Position: refs/heads/master@{#397554}
Override isolate targets for gtests on Android bots.
For the swarmed Nexus 5X bot, this should get rid of the "_apk"
suffixes being added by recipes.
BUG=616297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Review-Url: https://codereview.chromium.org/2033973002
Cr-Commit-Position: refs/heads/master@{#397553}
[tracing] Support background mode in skia memory dump provider
Background mode requires quick dump and just the totals, to be
able to collect traces in the background for all users.
Skia dump provider adds just the cache sizes in background mode.
BUG=613198
Review-Url: https://codereview.chromium.org/2015763003
Cr-Commit-Position: refs/heads/master@{#397552}
[MD Settings Passwords] Make password exceptions copy-able.
No visible UI change, just making the exception url copy-able.
BUG=595538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2037833002
Cr-Commit-Position: refs/heads/master@{#397551}
Disable CrOS VEA for Media Recorder
After coming across to certain bugs on different CrOS platforms, we decided to
do manuel tests before enabling HW VEA for CrOS.
BUG=616659
Review-Url: https://codereview.chromium.org/2035593002
Cr-Commit-Position: refs/heads/master@{#397550}
Auto-rebaseline for r397528
https://chromium.googlesource.com/chromium/src/+/c11388142
BUG=616634
[email protected]
Review URL: https://codereview.chromium.org/2034863003 .
Cr-Commit-Position: refs/heads/master@{#397549}
Auto-rebaseline for r397515
https://chromium.googlesource.com/chromium/src/+/d88f5fb93
BUG=616287
[email protected]
Review URL: https://codereview.chromium.org/2031053003 .
Cr-Commit-Position: refs/heads/master@{#397548}
Prevent use of GPU IDC in Resourceless Software Draw
An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.
This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.
BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2035913002
Cr-Commit-Position: refs/heads/master@{#397547}
Implement ui/gfx/geometry StructTraits unit tests
This CL also fixes a bug where SizeF had int32 types instead of floats.
BUG=611802
Review-Url: https://codereview.chromium.org/2037453002
Cr-Commit-Position: refs/heads/master@{#397546}
[Chromoting] Minor changes to TapGestureDetector
This change finals several fields in TapGestureDetector, and fixes potential
issue which impacts long press position, and causing it not to be updated.
BUG=615277
Review-Url: https://codereview.chromium.org/2032883002
Cr-Commit-Position: refs/heads/master@{#397545}
Decrease SAML webview with camera timeout to 90 seconds
The hard timeout for the SAML flow having an active camera capture is
now 90 seconds.
BUG=616756
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2033113002
Cr-Commit-Position: refs/heads/master@{#397544}
cc : Fix hit testing bug in resourceless software draw mode
Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.
BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2033163003
Cr-Commit-Position: refs/heads/master@{#397543}
PlzNavigate: fix a NavigationControllerBrowserTest
This CL fixes
NavigationControllerBrowserTest.BackFromPageWithReplaceStateInBeforeUnload when
run with PlzNavigate enabled. Using a StallManager on the url means that the
NavigationRequest will never complete, but it is not cancelled by the commit of
the ReplaceState in the BeforeUnload event. Therefore the
TestNavigationObserver never registers the navigation as complete. It only does
so in the current architecture because the replace state causes the renderer to
send a DidStopLoading, which makes the RenderFrameHost thinks it stopped
loading, even though it is still loading the back navigation.
Switching to a TestNavigationManager that will pause when the request hits the
network allows use to pause the navigation after the BeforeUnload event
executed but before the back navigation commits, and work in both
architectures.
BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2035723002
Cr-Commit-Position: refs/heads/master@{#397542}
[tools/perf] Improve the regex to find the commited revision
Add "\n" to the begin of the regex that find commit revision so we don't match
text fields of the case of relanded revision got quoted.
BUG=616868
[email protected]
Review-Url: https://codereview.chromium.org/2034573005
Cr-Commit-Position: refs/heads/master@{#397541}
Change all remaining callers of callingDOMWindow to currentDOMWindow
The reasoning for using callingDOMWindow was that the API calls were assumed
to always switch the context, but they do not.
BUG=541703,585871
Review-Url: https://codereview.chromium.org/1974313002
Cr-Commit-Position: refs/heads/master@{#397540}
[Android] Add support for Partner bookmarks to Chrome bookmark widget
Before this CL, the current folder of the widget is stored as a long in
the shared preferences. Now it will be stored as a String that can be
serialized directly into a BookmarkId object. The advantage of storing
strings is that it carries sufficient info about whether a bookmark is a
partner bookmark.
BUG=613171
Review-Url: https://codereview.chromium.org/2031893002
Cr-Commit-Position: refs/heads/master@{#397539}
Add GN configs for -fsanitizer=null.
This allows to sanitize null pointer accesses and
could increase readability of the messages from UBSan Vptr bot
(once enabled there).
BUG=616268,616870
Review-Url: https://codereview.chromium.org/2028383006
Cr-Commit-Position: refs/heads/master@{#397538}
Change a couple SetVisible overrides to VisibilityChanged
Since they aren't changing the behavior of SetVisible it doesn't
make sense to override that function. This also fixes a bug where
BookmarkBarView wasn't calling through to its parent class's
implementation of SetVisible (AccessiblePaneView).
BUG=none
Review-Url: https://codereview.chromium.org/2028383003
Cr-Commit-Position: refs/heads/master@{#397537}
Revert of Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile (patchset #1 id:20001 of https://codereview.chromium.org/2024733003/ )
Reason for revert:
This CL causes memory.blink_memory_mobile to fail on Android perf bots. See http://crbug.com/616861
Original issue's description:
> Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/c39b0cc8a516de1fa57d032dc0135a4eadfe2c9e
> Cr-Commit-Position: refs/heads/master@{#397358}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2038703002
Cr-Commit-Position: refs/heads/master@{#397536}
Remove overeager DCHECK in SnapshotController.
The DCHECK is not needed because indeed the state of the controller can be 'kReady' as a result
of calling Reset() on it. The scenario can be as following:
- snapshot started
- page is navigated while snapshot is in progress. This causes immediate Reset() on SnapshotController.
- This may or may not cancel snapshot, but ultimately the RecentTabHelper will report that snapshot is completed.
If the Reset() above already happened, the DCHECK will fire. It should not, since
this is normal conditions.
Also updated RecentTabHelper to stop posted tasks related to previous snapshot when page is re-navigated.
Removed chack for IsErrorPage() since it will be done later by checking CanSavePage anyways.
BUG=616570
Review-Url: https://codereview.chromium.org/2030793002
Cr-Commit-Position: refs/heads/master@{#397535}
Remove LayoutBlockFlow::clipOutFloatingObjects and ClipScope
These are no longer used.
[email protected]
Review-Url: https://codereview.chromium.org/2037663003
Cr-Commit-Position: refs/heads/master@{#397534}
Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2025103003/ )
Reason for revert:
Speculatively reverting to fix release-blocking crash.
Original issue's description:
> ExtensionFunction: don't pass ownership of base::Value by raw pointer.
>
> BUG=581865
> [email protected]
> [email protected]
>
> Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79
> Cr-Commit-Position: refs/heads/master@{#397284}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865
Review-Url: https://codereview.chromium.org/2038613003
Cr-Commit-Position: refs/heads/master@{#397533}
Add hooks in SpdyFramer to call an alternate decoder.
This supports evaluating the new HTTP/2 decoder. Includes
NestedSpdyFramerDecoder, which allows testing of the hooks. Protected by
FLAGS_use_nested_spdy_framer_decoder.
This CL lands server change 117601606 by jamessynge and 123894799 by bnc.
BUG=488484
Review-Url: https://codereview.chromium.org/2030473003
Cr-Commit-Position: refs/heads/master@{#397532}
Add mb_config.pyl and test list entries for swarmed Nexus 5X bot.
BUG=616297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Review-Url: https://codereview.chromium.org/2030853004
Cr-Commit-Position: refs/heads/master@{#397531}
Remove obsolete StoragePartition check from old iframe signin path.
For now, leave the UI thread hop in place for DevTools URLs, due
to issue 616641.
BUG=614808, 616282, 616641
TEST=Signin and Mac DevTools still work.
Review-Url: https://codereview.chromium.org/2033563002
Cr-Commit-Position: refs/heads/master@{#397530}
Clear ui::Layer damaged_region_ after commit.
This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.
BUG=610086
Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
Review-Url: https://codereview.chromium.org/2018223002
Cr-Commit-Position: refs/heads/master@{#397529}
Adjust for composited scrolling when invalidating paint rectangles.
BUG=616634
Review-Url: https://codereview.chromium.org/2037713002
Cr-Commit-Position: refs/heads/master@{#397528}
Clear logging in Widevine CDM and default component installer
The bug has been fixed. Conventing LOG(WARNING)s into DLOG(WARNING)s.
BUG=614745
TEST=No functionality change.
Review-Url: https://codereview.chromium.org/2036583002
Cr-Commit-Position: refs/heads/master@{#397527}
Replace 0x42 with 0x420 in ThreadDelegateForNewHandlerTest
On GCC -O2, the comparison operator between realloc's result
and the uintptr_t 0x42 is optimized away.
0x42 is not aligned, so the compiler assumes realloc cannot return this value.
BUG=616860
BUG=internal b/28801531
Review-Url: https://codereview.chromium.org/2032753002
Cr-Commit-Position: refs/heads/master@{#397526}
ReaderModePanel.onSizeChanged: remove unneeded panel resize
ReaderModePanel and the OverlayPanelBase are getting called for onSizeChanged
by the CompositorViewHolder even when there is no size change.
This causes animations in progress to be cancelled and that can prevent the
ContextualSearchPanel from showing when it should.
There is old code in ReaderMode#onSizeChanged that propagates the size-change
that is no longer needed. Removing this old code fixes this bug.
BUG=615777
Review-Url: https://codereview.chromium.org/2029953002
Cr-Commit-Position: refs/heads/master@{#397525}
Adds logging of connection migration events to net log.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2022403002
Cr-Commit-Position: refs/heads/master@{#397524}
MD Settings: About page, implement obsolete/end-of-the-line status.
BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2029453002
Cr-Commit-Position: refs/heads/master@{#397523}
[Mac][Material Design] Fix regression allowing chevron button dragging.
A recent regression left the bookmarks bar's chevron button draggable
when it should not be.
[email protected]
BUG=616412
Review-Url: https://codereview.chromium.org/2035843003
Cr-Commit-Position: refs/heads/master@{#397522}
[chromedriver] Pass --no-sandbox to chrome for java tests on linux32 bot.
BUG=611886
[email protected]
Review-Url: https://codereview.chromium.org/2036793003
Cr-Commit-Position: refs/heads/master@{#397521}
content: Increase image decode budget on > 4GB ram machines.
This patch increases the locked image decode budget to 256MB on machines
with 4GB of ram or more.
Note that this also modifies the gpu image decode cache, although it
wouldn't be using RAM. RAM is used as a proxy to qualify this machine
as "good".
R=ericrk, vmiura, enne
Review-Url: https://codereview.chromium.org/2013523003
Cr-Commit-Position: refs/heads/master@{#397520}
OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl.
[Tried to move CanSavePage to OfflinePageUtils but still want to use in components. In the process discovered other cleanup to do on that method.]
BUG=615165
Review-Url: https://codereview.chromium.org/2023293002
Cr-Commit-Position: refs/heads/master@{#397519}
When Chrome app tries to open a camera/mic for the first time
on Android, the pop-up runtime permission dialogue will cause
activities onStart/Stop events. Chrome will release/resume
camera device accordingly. But if activity onStart event
comes after we start to open the camera and before we get
onDeviceStarted callback, we will wrongly resume the same device which will fail with exception.
In this cl, we will check if the resumed device is already
in the start queue. Also move one function to public for
unittests which can catch the scenario in this BUG.
BUG=615557
TESt=trybots and manual test by doing a apprtc test on a N
device with building later than NRD45.
Review-Url: https://codereview.chromium.org/2029933002
Cr-Commit-Position: refs/heads/master@{#397518}
Material WebUI: cr-slider element for intelligent range mapping
Most sliders don't correspond 1:1 with a range of values. For instance,
we curate a range of valid values for pointer sensitivity, then map these
to a linear slider.
<cr-slider> takes an array of values corresponding to slider indices, and
binds the value of the <paper-slider> it wraps to the host element's property.
This simplifies the logic that was duplicated in keyboard.html and
appearance_fonts_page.html. It also fixes a rare edge case when a pref value
updates while the slider is being dragged.
BUG=611949
TEST=CrElementsBrowserTest.CrElements
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1967913002
Cr-Commit-Position: refs/heads/master@{#397517}
Don't use WPO for the Clang builds.
BUG=490934,598772
Review-Url: https://codereview.chromium.org/2033913002
Cr-Commit-Position: refs/heads/master@{#397516}
Disallow fragmentation of composited content.
BUG=616287
Review-Url: https://codereview.chromium.org/2028893002
Cr-Commit-Position: refs/heads/master@{#397515}
Combine PaintPropertyTreeBuilderRootContext into PaintPropertyTreeBuilder
[email protected]
Review URL: https://codereview.chromium.org/2036533002 .
Cr-Commit-Position: refs/heads/master@{#397514}
Unit tests for safe_browsing::V4Database class
BUG=543161
Review-Url: https://codereview.chromium.org/2012493003
Cr-Commit-Position: refs/heads/master@{#397513}
Fix history page middle click action
Send synthetic middle click in history page and also
prevent default it as the links in history page will
trigger twice if we don't prevent default it.
BUG=609020
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2018943003
Cr-Commit-Position: refs/heads/master@{#397512}
Disable LanguageOptionsDictionaryDownloadWebUITest.testdictionaryDownloadRetry on Windows.
It flakily fails the accessibility audit on Windows.
BUG=616791
[email protected]
Review-Url: https://codereview.chromium.org/2032893004
Cr-Commit-Position: refs/heads/master@{#397511}
Remove the stdout clutter from gen_file_type_proto.py
BUG=616141
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2032793002
Cr-Commit-Position: refs/heads/master@{#397510}
Update V8 to version 5.3.116.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/086f77db..5bca5221
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2037643003
Cr-Commit-Position: refs/heads/master@{#397509}
[tools/perf] Move dummy_page.html to dummy_pages/dummy_page.html
This is to make a consistent style of how we store the static
content in tools/perf/ directory.
Review-Url: https://codereview.chromium.org/2028383005
Cr-Commit-Position: refs/heads/master@{#397508}
Exclude failing test on DrMemory bot
BUG=616837
[email protected]
Review-Url: https://codereview.chromium.org/2038653002
Cr-Commit-Position: refs/heads/master@{#397507}
base::Value cleanup: add simple Clang tool for structured cleanups
Rewrites base::ListValue::Append(new base::StringValue(...)) and
base::ListValue::Append(new base::FundamentalValue(...)) to use
base::ListValue::Append{Boolean,Integer,Double,String} instead.
BUG=581865
[email protected]
Review URL: https://codereview.chromium.org/2032983002 .
Cr-Commit-Position: refs/heads/master@{#397506}
Block webpages from navigating to view-source URLs.
This CL blocks navigations to view-source URLs initiated by a page via window.location, window.open, A tag, etc. It still allows user initiated navigations such as directly entering the URL, clicking "view page source" or "open in new tab" in the context menu.
BUG=247151,606619
Review-Url: https://codereview.chromium.org/1917073002
Cr-Commit-Position: refs/heads/master@{#397505}
HttpStreamParser: Don't reuse sockets which receive unparsed data.
If HttpStreamParser has extra data left over after consuming a valid
HTTP/1.x response on a socket, it would still allow the socket to be
reused if it was connected and idle. Since we have no idea what the
data actually was, this just seems like a bad idea. This CL changes
that behavior, so such sockets are no longer considered reuseable.
This does have the downside of papering over server bugs, but it
still seems like the right way to go.
BUG=603140
Review-Url: https://codereview.chromium.org/1884943003
Cr-Commit-Position: refs/heads/master@{#397504}
Set Deduplicators in ProcessMemoryDumpTest.TakeAllDumpsFrom
We need to set them to avoid null pointer dereference.
BUG=616268
Review-Url: https://codereview.chromium.org/2032803002
Cr-Commit-Position: refs/heads/master@{#397503}
[Mac][Material Design] Fix strange Apps button highlight in dark themes.
The button needs to be set to not show highlighting.
[email protected]
BUG=616406
Review-Url: https://codereview.chromium.org/2031023002
Cr-Commit-Position: refs/heads/master@{#397502}
Fix MotionEvent conversion unit test to use valid tilt angles.
Motion event tilt angles must be within a range from 0 to PI according to
http://developer.android.com/reference/android/view/MotionEvent.html#AXIS_TILT
BUG=514360
Review-Url: https://codereview.chromium.org/1499873002
Cr-Commit-Position: refs/heads/master@{#397501}
bluetooth: Rename device's GetName to GetNameForDisplay
This change prepares for Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.
It is desired for GetName to return the actual device name. To prepare
for that this change renames the previous GetName behavior to
GetNameForDisplay.
http://crrev.com/2017393002 GetName -> GetNameForDisplay <<< This change.
http://crrev.com/2009753002 New GetName
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated
BUG=615720
TBR=jam
For method rename refactor crossing many disparate owners.
Review-Url: https://codereview.chromium.org/2017393002
Cr-Commit-Position: refs/heads/master@{#397500}
Mark exo Surface's RenderPass as having a transparent background.
Normally this doesn't matter, but if this is actually rendered as a
separate RenderPass (which seems to happen on closing the window), this
flag ensures that the framebuffer is properly cleared.
Review-Url: https://codereview.chromium.org/2032853002
Cr-Commit-Position: refs/heads/master@{#397499}
Update selection region style
* use simple gray region
* use gray for unselected regions instead.
* use darker gray for unselected region
* Instead of using platform cursor, draw pseudo cursor when selecting region
BUG=608269
Review-Url: https://codereview.chromium.org/1997193002
Cr-Commit-Position: refs/heads/master@{#397498}
Remove use of deprecated MessageLoop methods in chrome/.
MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:
"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
"ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
"ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
"ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
"ThreadTaskRunnerHandle::Get()->ReleaseSoon"
In files where these replacements are made, it adds these includes:
#include "base/location.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
- The two are equivalent on threads that run a MessageLoop.
- MessageLoop::current() doesn't work in base/task_scheduler
because the scheduler's thread don't run MessageLoops.
This CL will therefore facilitate the migration of browser
threads to base/task_scheduler.
Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG=616447
Review-Url: https://codereview.chromium.org/2033753002
Cr-Commit-Position: refs/heads/master@{#397497}
Exit immediately on failure to allocate SharedMemory.
Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The existence of the FastShutdown path means that any
message might fail. Either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.
BUG=615121
Review-Url: https://codereview.chromium.org/2028833003
Cr-Commit-Position: refs/heads/master@{#397496}
MD User Manager: Material Design product logos
BUG=610575, 563722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/7c757a0d5d4646198b18a88716f31793dee5e7ed
Cr-Commit-Position: refs/heads/master@{#397393}
Review-Url: https://codereview.chromium.org/2017563003
Cr-Commit-Position: refs/heads/master@{#397495}
Update WebGL2 conformance test expectations.
BUG=
TEST=linux nvidia/amd bots on GPU FYI green
[email protected]
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2028253003
Cr-Commit-Position: refs/heads/master@{#397494}
Sync LeakExpectations following r397405.
TBR=guidou,pkasting
BUG=589802
NOTRY=true
Review-Url: https://codereview.chromium.org/2037613003
Cr-Commit-Position: refs/heads/master@{#397493}
Fixes losing focus while space bar pressed.
BUG=615520
Review-Url: https://codereview.chromium.org/2017833003
Cr-Commit-Position: refs/heads/master@{#397492}
Update third_party/protobuf to protobuf-v3.0.0-beta-3
This is a minor update that incorporates some of our local patches. It also
introduces lite support for proto3 language.
It also incorporates a patch that reduces amount of memory
used by proto messages, at a cost of increased binary size.
For mobile, the binary size grows by ~20 KB with significant memory usage reduction:
http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-27_17-22-13
For desktop, the binary size grows by ~200 KB with similar reduction.
BUG=607751
Review-Url: https://codereview.chromium.org/1983203003
Cr-Commit-Position: refs/heads/master@{#397491}
Use GL_RGBA renderbuffer for antialiased, no-alpha DrawingBuffers.
Intel GPUs suffer performance penalties with GL_RGB multisampled renderbuffers.
This CL turns on GL_RGB emulation for those GPUs.
BUG=607130
Review-Url: https://codereview.chromium.org/1952913002
Cr-Commit-Position: refs/heads/master@{#397490}
Properly create zero-initialized local memory.
Previous code used memset() to zero the memory which forces
the pages to be realized and always adds the complete size
to the process's working set.
BUG=612470
Review-Url: https://codereview.chromium.org/2016013003
Cr-Commit-Position: refs/heads/master@{#397489}
[Layout API] Use contentLayoutItem() in LocalFrame
There are several references to contentLayoutObject() which can be replaced
1-1 with contentLayoutItem(). No new API methods are required.
BUG=499321
Review-Url: https://codereview.chromium.org/2032023003
Cr-Commit-Position: refs/heads/master@{#397488}
Make multi-gpu tests independent of intermittent display changes on OSX
For currently unknown reasons the display change callback is triggered
with kCGDisplayAddFlag flag while running the gpu tests. Since it might
change the active gpu at any time it can make the tests fail.
For now let's make the tests reliable but further investigation on the
callback will follow.
BUG=616759
[email protected], [email protected], [email protected]
Review-Url: https://codereview.chromium.org/2034763002
Cr-Commit-Position: refs/heads/master@{#397487}
Enable gn check of some //media files
Now that some subdirectories are clean, prevent regressions.
BUG=599578
Review-Url: https://codereview.chromium.org/1983503002
Cr-Commit-Position: refs/heads/master@{#397486}
Add ScrollManager class
Extract scrolling and resizing related logic
from EventHandler and put it in a dedicated
class.
BUG=615079
Review-Url: https://codereview.chromium.org/2010133003
Cr-Commit-Position: refs/heads/master@{#397485}
tracing: Reduce memory usage of heap_profiler_allocation_register_unittest.cc
This test was causing flakiness on low-memory devices as it tries to allocate
~600 MB of virtual memory. Turns out the test doesn't really need it all that.
Reducing the number of cells allocated to 54 MB.
BUG=608354
Review-Url: https://codereview.chromium.org/2037603002
Cr-Commit-Position: refs/heads/master@{#397484}
Handle case where WINDOWSSDKDIR is not set
If DEPOT_TOOLS_WIN_TOOLCHAIN=0 and vcvarsall.bat has not been run then
WINDOWSSDKDIR will probably not be set and copying cdb\cdb.exe will fail
when copy_cdb_to_output.py tries to read WINDOWSSDKDIR from environ.
This change handles that case by using the default SDK location.
BUG=616146
Review-Url: https://codereview.chromium.org/2030723002
Cr-Commit-Position: refs/heads/master@{#397483}
Update V8 to version 5.3.114.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fe6d660e..086f77db
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2036793002
Cr-Commit-Position: refs/heads/master@{#397482}
Hide media sinks that don't have a name in the cast system tray.
This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later.
BUG=616683
Review-Url: https://codereview.chromium.org/2029963002
Cr-Commit-Position: refs/heads/master@{#397481}
media: AVDA::QueueInput/DequeueOutput bail if state_ is invalid
Previously AVDA::DoIOTask() checked that state_ was valid before
calling QueueInput and DequeueOutput. Now, because we call them
multiple times in a row, it's possible for state_ to change and
for it to be no longer valid to call them. This CL adds early
returns when the state is invalid.
BUG=612343,612264
Review-Url: https://codereview.chromium.org/2029373002
Cr-Commit-Position: refs/heads/master@{#397480}
Reload gaia page to show proxy auth dialog.
Before, If network has changed to the one that requires
proxy authentication, proxy authentication dialog is not shown automatically.
User has to click "try to sign in again" to get the dialog.
In this patch, we will automatically reload gaia page
that will bring "Proxy authentication" dialog to the user.
To prevent network flakiness, we will do it at most 3 times.
BUG=589268
TEST=manual
Review-Url: https://codereview.chromium.org/2022533003
Cr-Commit-Position: refs/heads/master@{#397479}
Add a FakeImeFeatureDelegate to the Linux client.
The BlimpClientSession creates an ImeFeature which requires that a
Delegate be provided before the first IME message is received. Since the
Linux client is for developer testing only, we add a fake delegate which
just logs the IME show/hide requests.
This CL also corrects some BlimpMessageProcessor::ProcessMessage()
overrides to be public.
BUG=615584
Review-Url: https://codereview.chromium.org/2023613002
Cr-Commit-Position: refs/heads/master@{#397478}
Update description of "Highlight mouse cursor" feature based on UI review
BUG=314889
[email protected]
Review-Url: https://codereview.chromium.org/2036553006
Cr-Commit-Position: refs/heads/master@{#397477}
Update mb.py to support gn directories with no args.gn
A newly generated gn directory doesn't have an args.gn file so mb.py
needs to account for that. This is done by using toolchain.ninja to
identify a gn directory, and by teaching GNValsFromDir to handle a
missing args.gn file. The unittest was also updated to provide the
toolchain.ninja file.
BUG=616631
Review-Url: https://codereview.chromium.org/2027823002
Cr-Commit-Position: refs/heads/master@{#397476}
Deprecate sign-in from share.
In iOS7 and before, sharing could trigger the sign-in flow.
This is not possible anymore in iOS 9.
Downstream CL: https://chromereviews.googleplex.com/432527013/
BUG=608337
Review-Url: https://codereview.chromium.org/2020023002
Cr-Commit-Position: refs/heads/master@{#397475}
Added instructions on how to use code coverage.
Added coverage.md file for emma code coverage instructions for both
instrumentation and junit tests.
BUG=608085
Review-Url: https://codereview.chromium.org/2031743002
Cr-Commit-Position: refs/heads/master@{#397474}
[Mac][Material Design] Fix regression with infobar border.
This cl fixes a regression where infobars no longer displayed their
border.
[email protected]
BUG=615312
Review-Url: https://codereview.chromium.org/2029893002
Cr-Commit-Position: refs/heads/master@{#397473}
Roll src/third_party/skia/ 2122c5508..f95ff4a37 (2 commits).
https://chromium.googlesource.com/skia.git/+log/2122c55084b8..f95ff4a37aba
$ git log 2122c5508..f95ff4a37 --date=short --no-merges --format='%ad %ae %s'
2016-06-02 cblume Add getting the size of a given mipmap level.
2016-06-02 brianosman Add a caps bit to enable/disable the new manual mip-mapper
BUG=578304
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2036783002
Cr-Commit-Position: refs/heads/master@{#397472}
Adding basic unittest manifest generation to blimp/BUILD.gn along with appropriate blacklist.
Currently there is no manifest generated for any unittests. Manifests are used to ensure all required files are bundled into a tarball for export and later use with docker.
This change adds targets to create manifests for //blimp:blimp_unittests and //base:base_unittests. The next step would be to use these manifests to bundle the tests into tarballs for export.
BUG=613000
Review-Url: https://codereview.chromium.org/1997493002
Cr-Commit-Position: refs/heads/master@{#397471}
[Android Bookmark] Remove a faulty assertion
onBookmarkDelegateInitialized() can be called many times on a single
BookmarkRow, if this row is reused in RecyclerView.
BUG=593115
Review-Url: https://codereview.chromium.org/2034483002
Cr-Commit-Position: refs/heads/master@{#397470}
[GN] Add script to compile assets catalog without using tools/gyp.
Implement the assets catalog compilation without using mac_tool.py
from tools/gyp in order to make //build independent from the rest
of Chromium checkout.
BUG=616813
Review-Url: https://codereview.chromium.org/2023223002
Cr-Commit-Position: refs/heads/master@{#397469}
Paint first frame faster, don't crash with no frames during EOS.
Since we're no longer using the sink to paint the first frame, it's
easier to start painting the first frame as soon as we know it's
"a sure thing." Which is when we (1) have at least two frames
queued, or (2) the first frame has a timestamp >= start timestamp,
or (3) know that no more frames are coming.
As part of this, fixes a nullptr crash caused by deciding if EOS
should be triggered before removing frames for underflow, which
leaves painting with no frames.
Additionally adds a unique identifier to VideoFrames to resolve
incorrect caching issues that the above changes exposed.
BUG=614099
TEST=new unittest
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2007463005
Cr-Commit-Position: refs/heads/master@{#397468}
Remove references to network_hints::UrlList and network_hints::NameList
This patch removes typedefs from network_hints, in preparation on its
removal (in favor of mojo IPC from Blink to content).
BUG=610750
Review-Url: https://codereview.chromium.org/2038463004
Cr-Commit-Position: refs/heads/master@{#397467}
Add dpranke as an OWNER to PRESUBMIT.py, //infra .
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2031943002
Cr-Commit-Position: refs/heads/master@{#397466}
Removes static_assert from last patch
It's no longer interesting in this file.
BUG=none
TEST=none
[email protected]
Review-Url: https://codereview.chromium.org/2027383002
Cr-Commit-Position: refs/heads/master@{#397465}
[Mac/GN] Build and run interactive_ui_tests and sync_integration_tests.
BUG=431177
[email protected]
Review-Url: https://codereview.chromium.org/2029723003
Cr-Commit-Position: refs/heads/master@{#397464}
PrePaintTreeWalk should walk multicol spanner through the placeholder
The LayoutObject of a multicol spanner is placed in the layout tree
according to the DOM order, but it actually belongs to the multicol
container, not its DOM hierarchy. During PrePaintTreeWalk we should
follow the link from the placeholder to the spanner, instead of in
layout tree order.
Review-Url: https://codereview.chromium.org/2031923002
Cr-Commit-Position: refs/heads/master@{#397463}
[Sync] Random cleanups
Removing redundant or unused code:
- Checks in AutofillDataTypeController::StartAssociating repeat the ones
from NonUIDataTypeController
- There is no need to pass ClearDataOption to SyncEncryptionHanlder, it
is not used there.
BUG=
[email protected]
Review-Url: https://codereview.chromium.org/2024303002
Cr-Commit-Position: refs/heads/master@{#397462}
Remove Net.SSL_KeyExchange.RSA.
The "key exchange info" field doesn't give much for plain RSA. The RSA key size
can be determined in other ways. Such a metric should be in the certificate
verifier logic, and this version won't help with any certificate verifier
decisions since it omits most key exchanges.
BUG=614104
Review-Url: https://codereview.chromium.org/2022353002
Cr-Commit-Position: refs/heads/master@{#397461}
Enable WPO for the x64 Official builds.
BUG=490934
Review-Url: https://codereview.chromium.org/2018293002
Cr-Commit-Position: refs/heads/master@{#397460}
Clean up some stale entries in //testing/buildbot.
[email protected]
BUG=
Review-Url: https://codereview.chromium.org/2028343003
Cr-Commit-Position: refs/heads/master@{#397459}
Disable video overlay for WebView
Video overlay for embedded videos (aka hole punching)
is a hidden API in WebSettings that we plan to remove.
Disabling it to verify that nobody uses it.
BUG=616583
Review-Url: https://codereview.chromium.org/2026423002
Cr-Commit-Position: refs/heads/master@{#397458}
[Media Router] Allow casting new media to sink with existing route.
This change allows for one button push to stop casting to a sink and
then immediately create a new route to the same sink with the selected
source. The makes the user experience smoother by not making them stop
the current cast and then start a new one manually in two stops.
Some shortcomings of this change that will be addressed in the future:
- At least for mirroring, it's possible to avoid stopping the route and
just switch the stream sources. This probably requires adding a new
API to the extension.
- The button will currently allow users to re-cast the current source,
stopping the current route and starting a new one, even though this
isn't necessary. When both the old and new sources are tabs, the tab
IDs could be checked, but other cases would have to be handled in MR
or the extension.
BUG=614144
[email protected], [email protected], [email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2002293003
Cr-Commit-Position: refs/heads/master@{#397457}
ChromotingJniInstance has been a ref-counted class running on multiple threads, which has obscured deletion behavior. This CL drops its ref-counted support and pulls non-network-thread logics out of the class.
Doc: https://docs.google.com/document/d/1ZK-UQSC_rTjNsBa_MFbCmCh3fQRPFuVAwKhWnTZqc_Q/edit?usp=sharing
BUG=614242
Review-Url: https://codereview.chromium.org/2007123003
Cr-Commit-Position: refs/heads/master@{#397456}
Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA""
This reverts commit e3a06a21aa1a7adfaef988488cdbcccbfa9a2ef6.
This CL breaks all PFQ at the BuildPackages stage. See the infomational builder https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/19533 as an example.
[email protected]
BUG=616798
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review URL: https://codereview.chromium.org/2034473004 .
Cr-Commit-Position: refs/heads/master@{#397455}
arc: Fix multiple Play Store icons in shelf.
BUG=b/29068435
TEST=Manually on device, duplicate Play Store icons no longer
appear on app install from Play Store.
Review-Url: https://codereview.chromium.org/2020273004
Cr-Commit-Position: refs/heads/master@{#397454}
Run format-webkit on webkitpy code (without string conversion).
This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.
Specifically:
./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' | grep -v thirdparty)
Also ran the same command on the Python files in Tools/Scripts.
BUG=598897
Review-Url: https://codereview.chromium.org/2014063002
Cr-Commit-Position: refs/heads/master@{#397453}
Remove SK_SUPPORT_LEGACY_TYPEFACE_MAKE_FROM_NAME.
This define was added for staging a Skia change and can now be removed.
Review-Url: https://codereview.chromium.org/2032033002
Cr-Commit-Position: refs/heads/master@{#397452}
Add an experiment for the default browser infobar on Windows 10
Add an experiment called StickyDefaultBrowserInfobar that keeps the
infobar opens as long as the user haven't made a choice in the Windows
settings or until 2 minutes elapsed, whichever come first.
BUG=576490
Review-Url: https://codereview.chromium.org/1974153002
Cr-Commit-Position: refs/heads/master@{#397451}
Make CronetHttpURLConnection#setConnectTimeout silently fail
This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.
The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).
BUG=611851
Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
[Chromecast] Fix lint issue with missing includes.
cast_metrics_test_helper.cc was using string but not including the
proper header.
BUG=None
Review-Url: https://codereview.chromium.org/1777893002
Cr-Commit-Position: refs/heads/master@{#397449}
Remove some unused suppressions from checklicenses.py.
Review-Url: https://codereview.chromium.org/2028393002
Cr-Commit-Position: refs/heads/master@{#397448}
Roll src/third_party/skia/ 99600d0a1..2122c5508 (3 commits).
https://chromium.googlesource.com/skia.git/+log/99600d0a158e..2122c55084b8
$ git log 99600d0a1..2122c5508 --date=short --no-merges --format='%ad %ae %s'
2016-06-02 brianosman Fix incorrect parameter in new benchmark.
2016-06-02 brianosman Manually generated sRGB mipmaps, with successively smaller draws.
2016-06-02 robertphillips Handle stroked single line special case in Ganesh
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review-Url: https://codereview.chromium.org/2030943002
Cr-Commit-Position: refs/heads/master@{#397447}
Update V8 to version 5.3.112.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9c2ce70c..fe6d660e
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2036733002
Cr-Commit-Position: refs/heads/master@{#397446}
Modify WriteScheduler and subclasses to use SpdyStreamPrecedence.
This CL lands server change 119099214 by mpw.
BUG=488484
Review-Url: https://codereview.chromium.org/2031663002
Cr-Commit-Position: refs/heads/master@{#397445}
Remove events from the AudioParam timeline that are in the past
When running the AudioParam event timeline, remove events that were
skipped because they were in the past. This keeps the event list
reasonably short.
BUG=526862
TEST=correctness covered by existing tests, run test from bug report
to verify CPU usage doesn't constantly increase.
Review-Url: https://codereview.chromium.org/2031723002
Cr-Commit-Position: refs/heads/master@{#397444}
Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.
After this CL, blink::FrameTree::m_uniqueName is guaranteed to be truly
unique (within a given frame tree) except when:
- The frame tree temporarily contains both an old and a new provisional frame.
- The frame tree spans multiple renderer processes, which race to assign
the same name to different frames (https://crbug.com/558680#c14).
BUG=588800
Review-Url: https://codereview.chromium.org/1968213002
Cr-Commit-Position: refs/heads/master@{#397443}
Don't skip a frame when running smooth scroll animation on the main thread
This CL doesn't really fix the flickering in issue 588560, but its still
more correct to go into RunningOnMainThread rather than going into
WaitingToSendToCompositor needlessly.
BUG=588560
Review-Url: https://codereview.chromium.org/2029323003
Cr-Commit-Position: refs/heads/master@{#397442}
Add error messages for canvas creation failures
BUG=591500
[email protected],[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2025373002
Cr-Commit-Position: refs/heads/master@{#397441}
bluetooth: Repopulate chooser with existing devices
Fixes the issue where restarting the scan would not include the
previously discovered devices.
BUG=581544
Review-Url: https://codereview.chromium.org/2026413002
Cr-Commit-Position: refs/heads/master@{#397440}
Upstream: Do not show the add-to-homescreen/install-native-app infobar for WebAPKs
This CL also moves WebappActivity's TabDelegateFactory - WebappDelegateFactory
- to its own file so that WebApkActivity can extend WebappDelegateFactory.
BUG=609122, 614336
Review-Url: https://codereview.chromium.org/2018113002
Cr-Commit-Position: refs/heads/master@{#397439}
Roll WebRTC 12982:13018
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c0150c6..0b3ccdb
TBR=
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
Review-Url: https://codereview.chromium.org/2030003005
Cr-Commit-Position: refs/heads/master@{#397438}
Fix a bug with throttling and timer queue suspension
Both the ThrottlingHelper and timer queue suspension (via
SuspendTimerQueue/ResumeTimerQueue and
SuspendTimerQueueWhenBackgrounded / ResumeTimerQueueWhenForegrounded)
call TaskQueue::SetEnabled and it was possible for the ThrottlingHelper
to re-enable a suspended queue by mistake.
This patch prevents that from happening.
BUG=616052
Review-Url: https://codereview.chromium.org/2028433004
Cr-Commit-Position: refs/heads/master@{#397437}
Adjust representation of liveDocumentSet() to help diagnose instability.
The liveDocumentSet singleton keeps a
Persistent<HeapHashSet<WeakMember<Document>>,
collection of all the currently live documents. Some crashes are
being reported when this HeapHashSet<>'s weak references are
being processed, indicating that the pointer to the hash table
is misshapen.
To potentially throw some light on how that could come to be,
switch representation to PersistentHeapHashSet<WeakMember<Document>>,
which will keep the hash table wrapper off-heap. That could
help determine if we're dealing with an (Oilpan) heap object
overwrite here.
R=
BUG=611702
Review-Url: https://codereview.chromium.org/2033643003
Cr-Commit-Position: refs/heads/master@{#397436}
Mark dedicated-workers-list.html as crashing in leak tests.
Crash begins here:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/20074
BUG=616775
[email protected],[email protected]
NOTRY=true
Review-Url: https://codereview.chromium.org/2030083002
Cr-Commit-Position: refs/heads/master@{#397435}
Revert "Launch credit card upload."
This reverts commit 363fef366636b9eb130d69c188581cd8758fe4ca.
Reason for revert: I forgot that we're planning to use Finch to
geo-restrict this feature while we roll out internationally. Reverting
this CL for now.
BUG=569927
TBR=estade
Review-Url: https://codereview.chromium.org/2034753002
Cr-Commit-Position: refs/heads/master@{#397434}
[css] Bandaid fix for crash when tables and containment mix.
BUG=613907
Review-Url: https://codereview.chromium.org/2037443002
Cr-Commit-Position: refs/heads/master@{#397433}
Clear UIThreadExtensionFunction::render_frame_host_ when RFH is gone.
This regressed in my CL r395494 where I mistakenly put a short circuit
in SetRenderFrameHost. SetRenderFrameHost is called with nullptr RFH
when WebContentsObserver::RenderFrameDeleted() happens (for
non service worker case).
BUG=616119
Test=See clusterfuzz repro, it infrequently reproduces though. But
I was able to verify with this CL that the crash shouldn't happen.
Review-Url: https://codereview.chromium.org/2034543002
Cr-Commit-Position: refs/heads/master@{#397432}
[css-grid] Get rid of AvailableSpaceType enum
The AvailableSpaceType enum was somehow duplicated with the
GridTrackSizing::SizingOperation one.
AvailableSpaceType was always AvailableSpaceIndefinite
when the SizingOperation is IntrinsicSizeComputation;
and the other way around, always AvailableSpaceDefinite
when the SizingOperation is TrackSizing.
So, we can get rid of AvailableSpaceType enum,
and only use SizingOperation to know if we're computing
or not the intrinsic sizes of the grid container.
No new tests, no change of behavior.
BUG=616716
Review-Url: https://codereview.chromium.org/2030803003
Cr-Commit-Position: refs/heads/master@{#397431}
Do not try to load material design paks if not on Mac OS.
This gets rid of (harmless) errors when launching Chrome, which are a little
distracting.
BUG=616421
Review-Url: https://codereview.chromium.org/2028103002
Cr-Commit-Position: refs/heads/master@{#397430}
net: Add fuzzer for HostResolverImpl.
The fuzzer tests it using both a mocked out platform resolver (Which
isn't too exciting), and the built-in DNS resolver, complete with
fuzzed UDP sockets.
This CL introduces a FuzzedHostResolver class that can also be included
as a component for other fuzzers.
Also makes dns_socket_pool.cc less chatty on errors.
BUG=600005
Review-Url: https://codereview.chromium.org/1946793002
Cr-Commit-Position: refs/heads/master@{#397429}
Migrate WaitableEvent to enum-based constructor in read_write_lock_unittest.cc
Just added in https://codereview.chromium.org/1988563002
BUG=612843
[email protected]
NO_DEPENDENCY_CHECKS=true
Review-Url: https://codereview.chromium.org/2034743002
Cr-Commit-Position: refs/heads/master@{#397428}
Revert of Disable accessibility/image-inside-link.html on Mac (patchset #1 id:1 of https://codereview.chromium.org/2028383004/ )
Reason for revert:
I reverted the test altogether for flakiness, but this line was left behind.
https://bugs.chromium.org/p/chromium/issues/detail?id=616768
Original issue's description:
> Disable accessibility/image-inside-link.html on Mac
>
> [email protected]
> BUG=616699
>
> Committed: https://crrev.com/3c31fcd4ee220ea042f269b5214403fb98357f76
> Cr-Commit-Position: refs/heads/master@{#397345}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616699,616768
Review-Url: https://codereview.chromium.org/2033703003
Cr-Commit-Position: refs/heads/master@{#397427}
Blink Compositor Animation: Make Animation and Curve methods non-virtual.
In unit tests for blink/cc integration: Erase gmock usage, check platform compositor data instead.
This will allow us to erase CompositorFactory.
BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2019613002
Cr-Commit-Position: refs/heads/master@{#397426}
Migrate WaitableEvent to enum-based constructor in completion_event.h
Not sure why that one was missed by clang-tidy...
BUG=612843
[email protected]
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2029903003
Cr-Commit-Position: refs/heads/master@{#397425}
Disable IndexedDBBrowserTest.GetAllMaxMessageSize on Android
BUG=616155
R=jsbell
Review-Url: https://codereview.chromium.org/2029193002
Cr-Commit-Position: refs/heads/master@{#397424}
[Extensions] Don't CHECK() on bad pref types in scoped updates
As nice as it would be to be able to CHECK() on a bad pref value type,
we know that users can get into a mangled state with their preferences.
Instead of crashing (in the case of this bug, immediately on startup),
we should just silently ignore the bad values in prefs in release
builds. I'm leaving in DCHECK so that we can still catch this in tests
and the trybots, so that we at least have some coverage of expected
behavior.
BUG=616149
Review-Url: https://codereview.chromium.org/2029093002
Cr-Commit-Position: refs/heads/master@{#397423}
Added two new icons for user menu.
See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.abdhimh1kvzb
These two icons are to be used for the "Manage people" button as well as the sync error icon displayed on titlebar. See how they will be used here: https://codereview.chromium.org/2019053002/
BUG=615893
Review-Url: https://codereview.chromium.org/2028473002
Cr-Commit-Position: refs/heads/master@{#397422}
tools/android/loading: Implement task_manager's --keep-going flag
Despite our best effort, we may still have task failures in Sandwich.
This CL implement the --keep-going command line argument on the task
manager as Make, to continue executing tasks that are not depending
of the tasks that have failed.
BUG=582080
Review-Url: https://codereview.chromium.org/2027163002
Cr-Commit-Position: refs/heads/master@{#397421}
[Android] Attempt to continue on timeout in perf test runner setup.
BUG=596974
Review-Url: https://codereview.chromium.org/2029833003
Cr-Commit-Position: refs/heads/master@{#397420}
Only block http or https doc.written scripts.
The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we restrict
to http and https scripts.
This change doesn't include tests, since there isn't actually any behavior change
here that I can detect. Even though shouldDisallow will return true for data: URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.
BUG=616312
Review-Url: https://codereview.chromium.org/2026983002
Cr-Commit-Position: refs/heads/master@{#397419}
exo: Allow viewport and crop state to be updated independent of contents.
Current code assumes that the contents is always updated when
viewport or crop state changes. This stops making that assumption
for non-surface-layer code and allows the client to update this
state without having to provide new contents.
SurfaceTest.SetViewport/0 test will pass after this change but
SurfaceTest.SetViewport/1 test will fail.
BUG=549781, b/29090558
TEST=exo_unittests --gtest_filter=SurfaceTest.SetViewport/*
Review-Url: https://codereview.chromium.org/2027323004
Cr-Commit-Position: refs/heads/master@{#397418}
tools/android/loading Name the BigQuery table after the data it contains
This CL moves a lot of BigQuery related code into a new file
google_bigquery_helper.py.
It has 2 functional changes:
1) BigQuery tables are now named after the directory which contains the
corresponding traces.
That way, table names are less opaque, and it's easy to know which
table corresponds to which traces.
This change is located in GetBigQueryTableID() in
google_bigquery_helper.py.
2) Before starting a report task, we now check that the table does not
already exist. This is necessary since table names are no longer
unique. For example, if someone runs twice the same report task,
the same table name is used, which is most likely not expected and
would lead to duplicated entries in the table.
This change is located in GetTaskURL() in clovis_frontend.py.
Review-Url: https://codereview.chromium.org/2022033002
Cr-Commit-Position: refs/heads/master@{#397417}
Revert of Make click targets inside links work. (patchset #4 id:60001 of https://codereview.chromium.org/2021953002/ )
Reason for revert:
Flakily timing out:
https://bugs.chromium.org/p/chromium/issues/detail?id=616768
Original issue's description:
> Make click targets inside links work.
>
> There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
> For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
> BUG=615904
> [email protected]
>
> Committed: https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e
> Cr-Commit-Position: refs/heads/master@{#397211}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615904,616768
Review-Url: https://codereview.chromium.org/2035583003
Cr-Commit-Position: refs/heads/master@{#397416}
Add an entry to watchlist
BUG=
Review-Url: https://codereview.chromium.org/2025383003
Cr-Commit-Position: refs/heads/master@{#397415}
Migrate WaitableEvent to enum-based constructor in thread_watcher_unittest.cc
And fix presubmit checks about usage of static strings.
(and also get rid of constant for thread ID constants..)
BUG=612843
NO_DEPENDENCY_CHECKS=true
[email protected] (to bypass incorrect owner presubmit inherited from dependency)
Review-Url: https://codereview.chromium.org/2034713002
Cr-Commit-Position: refs/heads/master@{#397414}
Mustash: protect against null ash::Shell when launching apps from app list.
BUG=NONE
Review-Url: https://codereview.chromium.org/2029773002
Cr-Commit-Position: refs/heads/master@{#397413}
Add metrics for Google Docs Offline extension
BUG=616572
Review-Url: https://codereview.chromium.org/2027723004
Cr-Commit-Position: refs/heads/master@{#397412}
Adds unit tests for Offliner SavePage implementation.
BUG=601173
Review-Url: https://codereview.chromium.org/2016313003
Cr-Commit-Position: refs/heads/master@{#397411}
Update V8 to version 5.3.109.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9367ff9a..9c2ce70c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2029413003
Cr-Commit-Position: refs/heads/master@{#397410}
Enable QUIC v33
Review-Url: https://codereview.chromium.org/2023403002
Cr-Commit-Position: refs/heads/master@{#397409}
Fixed FloodFillInkDropRipple center points for instances that have a clip bounds at an origin other than (0,0).
The FloodFillInkDropRipple::CalculateTransform() function was applying
translations between the different coordinate spaces in the wrong order.
BUG=None
TEST=FloodFillInkDropRippleTest.TransformedCenterPointForIrregularClipBounds
Review-Url: https://codereview.chromium.org/2020793002
Cr-Commit-Position: refs/heads/master@{#397408}
[vim/ycm] Better defaults for new test files.
When visiting a new _test.cc, _browsertest.cc, _unittest.cc etc. file,
chromium.ycm_extra_conf determined the compiler options based on
base/logging.cc. This resulted in ycmd failing to locate some gtest
include files. While the correct flags won't be known until the file
shows up in the ninja build files, until then we can do slightly better
by using base/logging_unittest.cc as the default for test files to avoid
some of the brokenness.
[email protected]
BUG=none
Review-Url: https://codereview.chromium.org/2035443002
Cr-Commit-Position: refs/heads/master@{#397407}
[DevTools] Add removeFunction to EventListener protocol object
With this change CommandLineAPI getEventListeners and protocol getEventListeners methods use the same way to provide remove function. One redundant roundtrip is removed from frontend side.
BUG=595206
[email protected]
Review-Url: https://codereview.chromium.org/2034533002
Cr-Commit-Position: refs/heads/master@{#397406}
Delay leak reporting until worker in-process proxies have been finalized.
If a document creates a number of workers, terminating these and having
their destruction ripple all the way back to the in-process proxy objects
isn't immediate. But something that needs to complete before the leak
detector can initiate reporting -- an in-process proxy object maintains a
strong reference to the document, and would generate a leak if not
destructed and its garbage having been collected afterwards.
Address the reliability of multi worker shutdown by maintaining a
counter of how many in-process proxy objects are still alive and run
GCs until it drops to zero. Do that at most two times around.
R=haraken,kouhei
BUG=589802, 616714
Review-Url: https://codereview.chromium.org/2026993004
Cr-Commit-Position: refs/heads/master@{#397405}
Add Layout Test suppression to unblock Skia roll
BUG=616752
Review-Url: https://codereview.chromium.org/2033083002
Cr-Commit-Position: refs/heads/master@{#397404}
Change custom_passphrase_instructions to a TextViewWithClickableSpans.
BUG=599800
Review-Url: https://codereview.chromium.org/2029783004
Cr-Commit-Position: refs/heads/master@{#397403}
Avoid unnecessary uses of GarbageCollectedFinalized<>.
R=
BUG=
Review-Url: https://codereview.chromium.org/2027333003
Cr-Commit-Position: refs/heads/master@{#397402}
binding: Supports V8PrivateProperty::getOrUndefined.
Adds getOrUndefined() as a fast version of get() for the clients
that do not need to care about the difference between
a) the private property has not yet been set, and
b) the private property was intentionally set to undefined.
BUG=616618
Review-Url: https://codereview.chromium.org/2035713002
Cr-Commit-Position: refs/heads/master@{#397401}
arc: Re-enable window animations.
This is no longer needed as window manager integration works
well enough now that standard UI animations can be used.
TEST=Manual
BUG=
Review-Url: https://codereview.chromium.org/2022963002
Cr-Commit-Position: refs/heads/master@{#397400}
Revert of MD User Manager: Material Design product logos (patchset #2 id:20001 of https://codereview.chromium.org/2017563003/ )
Reason for revert:
Suspected breakage of compilation in https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/7691, see log attached in http://crbug.com/610575#c14
Original issue's description:
> MD User Manager: Material Design product logos
>
> BUG=610575, 563722
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/7c757a0d5d4646198b18a88716f31793dee5e7ed
> Cr-Commit-Position: refs/heads/master@{#397393}
[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610575, 563722
Review-Url: https://codereview.chromium.org/2038543002
Cr-Commit-Position: refs/heads/master@{#397399}
Convert media-cont* and media-element* tests to testharness.js
Cleaning up media-cont* and media-element* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2031783002
Cr-Commit-Position: refs/heads/master@{#397398}
Fix an unitialized variable warning in Brotli.
Correspond to https://github.com/google/brotli/commit/c6d38e94cbf9ec094b1e84f6a3a675c9dc42fbed
Review-Url: https://codereview.chromium.org/2027873006
Cr-Commit-Position: refs/heads/master@{#397397}
Implement the Chrome Sign-in promo bubble for password manager on Views.
The bubble is never popped up at the moment. The CL only implements the UI elements.
BUG=615825
Review-Url: https://codereview.chromium.org/2033713002
Cr-Commit-Position: refs/heads/master@{#397396}
Creates a flag to be used for the desktop user menu revamp project.
Testing was done on the chrome://flags page as well as to use switches::IsRedesignedDesktopUserMenu().
BUG=615893
Review-Url: https://codereview.chromium.org/2031763002
Cr-Commit-Position: refs/heads/master@{#397395}
In PopularSites, parse (not sanitize) JSON safely.
All that JSON sanitization does is to parse it safely and then
reserialize it. For supporting unsafe JSON on iOS, it makes more sense
to me to inject a JSON parser (as we do in ntp_snippets), rather than a
JSON sanitizer. Then, we do the reserialization ourselves.
(this doesn't yet make the parser injectable)
BUG=603026
Review-Url: https://codereview.chromium.org/2031603002
Cr-Commit-Position: refs/heads/master@{#397394}
MD User Manager: Material Design product logos
BUG=610575, 563722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2017563003
Cr-Commit-Position: refs/heads/master@{#397393}
Set default width/height of pointer events to 1
BUG=608459
Review-Url: https://codereview.chromium.org/2024243002
Cr-Commit-Position: refs/heads/master@{#397392}
Updating trunk VERSION from 2756.0 to 2757.0
Cr-Commit-Position: refs/heads/master@{#397391}
Specify direct dependency of //components/crash on kasko_features.h
//components/crash/content/app has a public dependency on the generated
header kasko_features.h. However, the GYP and GN files specify this
dependency only transitively via a dependency on //third_party/kasko
(which //components/crash/content/app does not actually depend on). This
CL changes the dependency to be directly on
//third_party/kasko:kasko_features as a speculative fix for the build
failures listed in crbug.com/611319. Note that in any case this change
is correct (whether it ends up resolving the flaky build failures or no).
BUG=611319
TBR=pmonette
Review-Url: https://codereview.chromium.org/2038473002
Cr-Commit-Position: refs/heads/master@{#397390}
Convert track-webvtt-tc[019-021] tests to testharness.js
Cleaning up track-webvtt-tc[019-021] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2029663002
Cr-Commit-Position: refs/heads/master@{#397389}
Integrate InstanceID with GCM crypto provider
It's now possible to get per-token encryption information from an
InstanceID; and this is automatically removed when DeleteToken or
DeleteID are called.
Part of a series of patches:
1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype
2. https://codereview.chromium.org/1830983002 adds JNI bindings
3. https://codereview.chromium.org/1829023002 adds fake and test
4. https://codereview.chromium.org/1899753002 fixes strict mode violations
5. https://codereview.chromium.org/1854093002 enables InstanceID by default
6. https://codereview.chromium.org/1953273002 extends the GCMKeyStore
7. this patch
8. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs
BUG=589461
Review-Url: https://codereview.chromium.org/1923953002
Cr-Commit-Position: refs/heads/master@{#397388}
[chromedriver] Pass --no-sandbox to chrome on linux32 bot.
BUG=611886
[email protected]
Review-Url: https://codereview.chromium.org/2035523002
Cr-Commit-Position: refs/heads/master@{#397387}
Migrate WaitableEvent to enum-based constructor in content/
Change automated with clang-tidy (details @ https://crbug.com/612843#c13)
BUG=612843
Review-Url: https://codereview.chromium.org/2026253003
Cr-Commit-Position: refs/heads/master@{#397386}
Migrate WaitableEvent to enum-based constructor in components/
Change automated with clang-tidy (details @ https://crbug.com/612843#c13)
BUG=612843
Review-Url: https://codereview.chromium.org/2028193002
Cr-Commit-Position: refs/heads/master@{#397385}
Moves RootWindowControllerCommon and LayoutManager to common
I would have done with the last patch, but git wasn't picking up the
move correctly.
BUG=none
TEST=none
[email protected]
[email protected]
Review-Url: https://codereview.chromium.org/2025413002
Cr-Commit-Position: refs/heads/master@{#397384}
Enable per thread heap for database thread
BUG=591606
Review-Url: https://codereview.chromium.org/1909813002
Cr-Commit-Position: refs/heads/master@{#397383}
Migrate WaitableEvent to enum-based constructor in net/
Change automated with clang-tidy (details @ https://crbug.com/612843#c13)
BUG=612843
Review-Url: https://codereview.chromium.org/2030663002
Cr-Commit-Position: refs/heads/master@{#397382}
Migrate WaitableEvent to enum-based constructor in storage/
Change automated with clang-tidy (details @ https://crbug.com/612843#c13)
BUG=612843
[email protected]
Review-Url: https://codereview.chromium.org/2031703002
Cr-Commit-Position: refs/heads/master@{#397381}
Update V8 to version 5.3.108.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b6b02328..9367ff9a
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2031743004
Cr-Commit-Position: refs/heads/master@{#397380}
gpu: Increase Skia resource cache item limit
Increase Skia GrContext resource cache item limit.
MS Chalkboard test case has 2400 paths. The old limit
would cause path cache trashing when the scene was
played back.
Fixes slowness on
smoothness.gpu_rasterization.tough_path_rendering_cases
on hardware that has GL API level path rendering enabled.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2020013002
Cr-Commit-Position: refs/heads/master@{#397379}
[chrome.displaySource] Fix display source to use the current VEA API.
Accept the capturer timestamp as a parameter in BitstreamBufferReady()
also in display source extension as per new VideoEncodeAccelerator API.
BUG=242107,350106
Review-Url: https://codereview.chromium.org/2033533003
Cr-Commit-Position: refs/heads/master@{#397378}
Convert media-captions-* and media-constants-* tests to testharness.js
Cleaning up media-captions-* and media-constants-* tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.
BUG=588956
Review-Url: https://codereview.chromium.org/2031503002
Cr-Commit-Position: refs/heads/master@{#397377}
Disable FormAutofillTest.WebFormElementToFormDataTooManyFields on Mac and CrOS
[email protected]
BUG=616730
Review-Url: https://codereview.chromium.org/2025423004
Cr-Commit-Position: refs/heads/master@{#397376}
Rename FrameFetchContext::ensureLoaderForNotifications.
Rename the helper method |ensureLoaderForNotifications| to |masterDocumentLoader| in FrameFetchContext.
This makes it consistent with terminology coined in https://www.w3.org/TR/html-imports/, and removes the confusion introduced by using the `ensure` prefix even though the method did not exhibit "create-if-not-exists" behavior.
BUG=274173
Review-Url: https://codereview.chromium.org/2030883002
Cr-Commit-Position: refs/heads/master@{#397375}
Migrate WaitableEvent to enum-based constructor in dbus/
Change automated with clang-tidy (details @ https://crbug.com/612843#c13)
BUG=612843
Review-Url: https://codereview.chromium.org/2030653002
Cr-Commit-Position: refs/heads/master@{#397374}
Reland of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2030913002/ )
Reason for revert:
This revert was speculative and the test proved to be too flaky for the revert results to be conclusive.
Sorry for the noise, relanding.
Original issue's description:
> Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ )
>
> Reason for revert:
> Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots.
> For more info see:
> BUG=616730
>
> Original issue's description:
> > Stopped WebVR from being partially enabled during testing.
> >
> > Should prevent repeated instances of "blink::mojom::VRService not found" in test
> > logs.
> >
> > BUG=614752
> >
> > Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
> > Cr-Commit-Position: refs/heads/master@{#397335}
>
> [email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=614752
>
> Committed: https://crrev.com/8d4d2467316e320d44d59db7113d6474549bf617
> Cr-Commit-Position: refs/heads/master@{#397372}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616730
Review-Url: https://codereview.chromium.org/2030023002
Cr-Commit-Position: refs/heads/master@{#397373}
Revert of Stopped WebVR from being partially enabled during testing. (patchset #1 id:1 of https://codereview.chromium.org/2029843002/ )
Reason for revert:
Speculative revert, may have broken FormAutofillTest.WebFormElementToFormDataTooManyFields on ASAN bots.
For more info see:
BUG=616730
Original issue's description:
> Stopped WebVR from being partially enabled during testing.
>
> Should prevent repeated instances of "blink::mojom::VRService not found" in test
> logs.
>
> BUG=614752
>
> Committed: https://crrev.com/8f7b25a40b187d5214eafdc86190b811c247580a
> Cr-Commit-Position: refs/heads/master@{#397335}
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=614752
Review-Url: https://codereview.chromium.org/2030913002
Cr-Commit-Position: refs/heads/master@{#397372}
'SecurityPolicyViolation' event data errors.
This patch fixes two small bugs with the data delivered in the
SecurityPolicyViolation event object:
1. 'blockedURI' is now 'inline' or 'eval' for those kinds of violations.
2. 'lineNumber' is populated correctly for inline violations.
BUG=615862
[email protected]
Review-Url: https://codereview.chromium.org/2020053002
Cr-Commit-Position: refs/heads/master@{#397371}
Add security OWNERs to mojo directories.
BUG=none
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2032723002
Cr-Commit-Position: refs/heads/master@{#397370}
[PCv1] Avoid using dot in metrics name
Before this CL, the PCv1 emitted value names contained '.'.
The Chrome Performance Dashboard treats '.' in the value name specially,
thus messed up the graph views.
This CL workarounds the issue by renaming the value names to not contain
any '.'.
BUG=chromium:616342
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Review-Url: https://codereview.chromium.org/2029483002
Cr-Commit-Position: refs/heads/master@{#397369}
Allow various font weights in gfx. These changes make Chromium's gfx::Font more closely match native font APIs &
capabilities.
BUG=597533
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1819753003
Cr-Commit-Position: refs/heads/master@{#397368}
[NTP Snippets] Persist snippets in a LevelDB instead of prefs
BUG=605870
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1987333003
Cr-Commit-Position: refs/heads/master@{#397367}
SafeBrowsing: Implement cache lookup for full hash checks
BUG=561867,543161
Review-Url: https://codereview.chromium.org/2009183002
Cr-Commit-Position: refs/heads/master@{#397366}
Disable svg/filters/filtered-animated-image-crash.html on Linux ASAN
[email protected]
BUG=616700
Review-Url: https://codereview.chromium.org/2033433003
Cr-Commit-Position: refs/heads/master@{#397365}
cc::SharedQuadState: drop CopyFrom and add copy constructor
In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.
BUG=611802
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2029813002
Cr-Commit-Position: refs/heads/master@{#397364}
Added code to make sure that the budget service does sane things if the clock rolls backwards.
BUG=602244
Review-Url: https://codereview.chromium.org/2020263002
Cr-Commit-Position: refs/heads/master@{#397363}
[tools/perf] Remove smoothness.tough_scrolling_while_zoomed_in_cases benchmark
BUG=609523
Review-Url: https://codereview.chromium.org/2035553002
Cr-Commit-Position: refs/heads/master@{#397362}
Revert of Disabling HD video quality tests on win7. (patchset #1 id:1 of https://codereview.chromium.org/2008583004/ )
Reason for revert:
The charCode regression has been fixed, so the tests should work now.
Original issue's description:
> Disabling HD video quality tests on win7.
>
> A labs engineer probably needs to look at the GL drivers on the bot.
> The problem only affects HD tests on Win 7.
>
> BUG=613947
> [email protected]
>
> Committed: https://crrev.com/9547bb36ce85227ef99e6ac31d923669d97b2177
> Cr-Commit-Position: refs/heads/master@{#395562}
[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=613947
Review-Url: https://codereview.chromium.org/2032993002
Cr-Commit-Position: refs/heads/master@{#397361}
Update V8 to version 5.3.107.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a0024e59..b6b02328
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2027393003
Cr-Commit-Position: refs/heads/master@{#397360}