Publish DEPS for Chromium 52.0.2743.49
Incrementing VERSION to 52.0.2743.49
Cr-Commit-Position: refs/branch-heads/2743@{#441}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix extension installed bubble sizing for cases where there's no body text.
BUG=618983
Review-Url: https://codereview.chromium.org/2070883002
Cr-Commit-Position: refs/heads/master@{#400204}
(cherry picked from commit eb814f63fb1f396192cee63a86feb2582716bdcc)
Review URL: https://codereview.chromium.org/2089853003 .
Cr-Commit-Position: refs/branch-heads/2743@{#440}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Split to use two different ID for the two different checkbox in two different subview. Currently the code always listen to the checkbox created in the advanced view. so even if user click to check/uncheck the box in the before view, the code listen to the value of the checkbox inside the advanced view which was not shown to the user.
BUG=620921
Review-Url: https://codereview.chromium.org/2074983003
Cr-Commit-Position: refs/heads/master@{#400797}
(cherry picked from commit bf4dd975949936a88973a42df91639cec18d0d2e)
Review URL: https://codereview.chromium.org/2088053002 .
Cr-Commit-Position: refs/branch-heads/2743@{#439}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add user actions for when a CCT is started (either initially or refocused).
BUG=611790
Review URL: https://codereview.chromium.org/2087623005 .
Review-Url: https://codereview.chromium.org/2070133003
Cr-Original-Commit-Position: refs/heads/master@{#400301}
Cr-Commit-Position: refs/branch-heads/2743@{#438}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add user actions for how website settings are triggered.
We hope this will show in what user sequences this dialog is typically
used.
BUG=611790
Review URL: https://codereview.chromium.org/2077413006 .
Review-Url: https://codereview.chromium.org/2068013002
Cr-Original-Commit-Position: refs/heads/master@{#399976}
Cr-Commit-Position: refs/branch-heads/2743@{#437}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Show dropdown button in download shelf items for malicious DLs. Dangerous ones still don't show the button.
This was an oversight concerning the difference between malicious and
dangerous.
BUG=616615
Review-Url: https://codereview.chromium.org/2029363002
Cr-Commit-Position: refs/heads/master@{#397815}
(cherry picked from commit 64acfeb29cfa3ac2dd7e98d3946fafce7ae2aeaa)
Review URL: https://codereview.chromium.org/2087013002 .
Cr-Commit-Position: refs/branch-heads/2743@{#436}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
ReaderModePanel.onSizeChanged: remove unneeded panel resize
ReaderModePanel and the OverlayPanelBase are getting called for onSizeChanged
by the CompositorViewHolder even when there is no size change.
This causes animations in progress to be cancelled and that can prevent the
ContextualSearchPanel from showing when it should.
There is old code in ReaderMode#onSizeChanged that propagates the size-change
that is no longer needed. Removing this old code fixes this bug.
BUG=615777
Review-Url: https://codereview.chromium.org/2029953002
Cr-Commit-Position: refs/heads/master@{#397525}
(cherry picked from commit 15c42ee487cca2ad3554a953957e973eae79d2a1)
Review URL: https://codereview.chromium.org/2081313002 .
Cr-Commit-Position: refs/branch-heads/2743@{#435}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[CacheStorage] Don't call GetUsageAndQuota from a scheduled operation
Merge into M52.
Scheduled operations run sequentially. GetUsageAndQuota() can sometimes create
a new Size() scheduled operation, so calling it while in a scheduled operation
can result in a hung CacheStorage. This CL moves the calls to GetUsageAndQuota
to just before the operations are scheduled. This means that the size estimate
is less accurate, as it's determined potentially well before the operation runs.
BUG=620713
Review-Url: https://codereview.chromium.org/2085583002
Cr-Commit-Position: refs/heads/master@{#401001}
(cherry picked from commit 36dc82c2b7539b33b63cb6f967feae265625d178)
Review URL: https://codereview.chromium.org/2081283002 .
Cr-Commit-Position: refs/branch-heads/2743@{#434}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Prevent a crash where CSS containment assumed a layer would be created
SVG has different PaintLayer semantics and does not currently use
PaintLayers. This patch fixes a crash where CSS containment assumed
a layer would be present for an SVG text node.
Additionally, the DCHECK in ~BoxClipper has been updated to match the
conditional in the BoxClipper constructor.
BUG=613929
Review-Url: https://codereview.chromium.org/2062643002
Cr-Commit-Position: refs/heads/master@{#399383}
(cherry picked from commit fd5d6b3400f54cee4a84fa24a43298d345e96463)
Review URL: https://codereview.chromium.org/2084083002 .
Cr-Commit-Position: refs/branch-heads/2743@{#433}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Query the existence other forms of browsing history.
This CL implements the query for other forms of browsing history, which
is necessary to show the notices in the Clear Browsing Data dialog on
all platforms. Previously, the query was represented by a dummy method
WebHistoryService::HasOtherFormsOfBrowsingHistory(), but now we have an
actual endpoint on the Sync server to answer the query.
More detailed description of the change:
1. sync/protocol/
Adapt history_status.proto from cl/122116426 and add it to Chromium code.
2. components/history/
Replace the dummy method WebHistoryService::HasOtherFormsOfBrowsingHistory()
with the actual request QueryOtherFormsOfBrowsingHistory(). We use most of
the existing WebHistoryService insfrastructure, but ReadResponse is replaced
by MessageLite::ParseFromString() since we're receiving a protobuf.
Furthermore, the query URL is not static, as in other WebHistoryService calls,
but has to be generated from the browser user agent and channel.
3. components/browsing_data_ui/
Update the logic to include calls to QueryOtherFormsOfBrowsingHistory().
This call and QueryWebAndAppActivity() call should run in parallel to save
time, since they are both HTTP requests.
4. chrome/
Provide the user agent string and the channel info from
the Desktop and Android callsites (iOS is in a different
codebase)
BUG=614652
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/1983073002
Cr-Commit-Position: refs/heads/master@{#395894}
(cherry picked from commit 6d43c1934d9a3a090e16a1346a2ada29b7e1a86c)
Review URL: https://codereview.chromium.org/2087883002 .
Cr-Commit-Position: refs/branch-heads/2743@{#432}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix for running Chrome under a service token. This patch fixes an issue with the handling of the default DACL when running Chrome under a service token, such as Local System. These tokens don't always have an assigned logon session SID, which would cause the DACL lockdown process to fail.
BUG=615396
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TEST=1. Download PSTools from https://technet.microsoft.com/en-us/sysinternals/pstools.aspx
2. Run cmd.exe as an administrator
3. Run the command 'psexec -s -i c:\path\to\chrome.exe'
4. Verify that the browser is useable
Review-Url: https://codereview.chromium.org/2061703002
Cr-Commit-Position: refs/heads/master@{#399529}
(cherry picked from commit 6ac615dfd11e86b1ce7766e1de263ce3d2e3b727)
Review URL: https://codereview.chromium.org/2081203003 .
Cr-Commit-Position: refs/branch-heads/2743@{#431}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52] gpu: Fix MailboxManagerSync corner case NPE
The DCHECK image implies image_buffer doesn't actually hold in theory.
Although not sure how it happens in practice.
BUG=621655
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2084753002
Cr-Commit-Position: refs/heads/master@{#400869}
(cherry picked from commit ddeec57160fa6a63ce516295d6af28d14a3d6760)
Review URL: https://codereview.chromium.org/2081213002 .
Cr-Commit-Position: refs/branch-heads/2743@{#430}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Fix bookmark chevron button focus ring location.
This cl adjusts the bookmark bar's chevron button's focus ring, which
is 2pt too low.
[email protected]
BUG=617511
Review-Url: https://codereview.chromium.org/2074503002
Cr-Commit-Position: refs/heads/master@{#400309}
(cherry picked from commit ce0f71bffa40beb738e2579efd91d3a0260dd010)
Review URL: https://codereview.chromium.org/2089653002 .
Cr-Commit-Position: refs/branch-heads/2743@{#429}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Roll src/breakpad/src/ 33a43757f..5aac5eabb (2 commits).
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/33a43757f6da..5aac5eabb0fd
$ git log 33a43757f..5aac5eabb --date=short --no-merges --format='%ad %ae %s'
2016-05-23 tobiasjs Functions only called by DumpFreeSpace need to be conditionally compiled.
2016-05-23 primiano Add statistics about free space to microdump format.
[email protected]
BUG=525938
Review-Url: https://codereview.chromium.org/2002073004
Cr-Commit-Position: refs/heads/master@{#395382}
(cherry picked from commit 128a234aeddac1539ae51334a467122cc94ef852)
Review URL: https://codereview.chromium.org/2085943003 .
Cr-Commit-Position: refs/branch-heads/2743@{#428}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[merge-m52] Do not SchedulePaint() inside views::Label::OnPaint()
View::SchedulePaint() shouldn't be called inside an OnPaint() method. At
best it wastes computation doing a follow-up, redundant paint. On Mac
it's causing a weird interaction with transparent backgrounds for
strings of particular lengths on retina screens.
For performance, MaybeBuildRenderTextLines() is always deferred until a
Paint. It calls RecalculateColors() to apply colors to the lines it
newly creates, and that schedules a paint. But
MaybeBuildRenderTextLines() just needs to apply the colors that have
already been calculated.
So, to fix, split RecalculateColors() into the color calculation and
ApplyTextColors(), which can be called from OnPaint().
BUG=604092
TEST=On a retina-screen Mac with a fresh profile, navigate (e.g. to
chrome://version), then press Backspace, The "Press <key> to go back"
popup should appear and it should have a consistent, transparent
background.
Review-Url: https://codereview.chromium.org/2065003002
Cr-Commit-Position: refs/heads/master@{#400273}
(cherry picked from commit 2b40c5ca82b21f503cc7cc75ac101f1d2b710fc1)
Review URL: https://codereview.chromium.org/2085623006 .
Cr-Commit-Position: refs/branch-heads/2743@{#427}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Handle NullPointerException when there is no active network
BUG=619075
(cherry picked from commit 0a48c1697d2eb0aff7d9476b85487135e9e8fb96)
Review-Url: https://codereview.chromium.org/2058883002
Cr-Original-Commit-Position: refs/heads/master@{#399294}
Cr-Commit-Position: refs/branch-heads/2743@{#426}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Rename 'unsafe-dynamic' to 'strict-dynamic'
In line with the spec change and discussion on WebAppSec:
https://github.com/w3c/webappsec-csp/commit/3476890664ada8efe2122301e6a4901cb12b520e
BUG=589380
[email protected]
Review-Url: https://codereview.chromium.org/2082613002
Cr-Commit-Position: refs/heads/master@{#400763}
(cherry picked from commit b38a96dd8b5e1deb3d4de631f002630c8735eb00)
Review URL: https://codereview.chromium.org/2083983002 .
Cr-Commit-Position: refs/branch-heads/2743@{#425}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "Menulist SELECT element should update layout when an OPTION content is changed." to M52.
r374629 exposed this bug. Before r374629, removing OPTION content triggered style
recalc and layout for the SELECT element. Now we need to ask for layout manually.
BUG=619837
Review-Url: https://codereview.chromium.org/2075533002
Cr-Commit-Position: refs/heads/master@{#400395}
(cherry picked from commit 717d9d1c80c2925b3781b417f9d9ab44fc04bc29)
Review URL: https://codereview.chromium.org/2084833002 .
Cr-Commit-Position: refs/branch-heads/2743@{#424}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.48
Cr-Commit-Position: refs/branch-heads/2743@{#423}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix broken merge for M52 branch.
New code missed non-merged refactoring.
BUG=621737,620478
(cherry picked from commit ce790c6362b892134ca51a76cf7a7f365f627b47)
Review URL: https://codereview.chromium.org/2085843002 .
Cr-Commit-Position: refs/branch-heads/2743@{#422}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Isolate progress bar theme logic
This change further isolates the logic used to color the indeterminate
animation and fixes an issue in custom tabs. For dark themes the theme
color was set before the animation was initialized causing the color
to be incorrect. The solution is to cache the theme color when it is
set and use it during initialization if available.
BUG=619099
Review-Url: https://codereview.chromium.org/2066683004
Cr-Commit-Position: refs/heads/master@{#400000}
(cherry picked from commit 33bc157bbcbb67aa43743fb2b7c9220737cdc679)
Review URL: https://codereview.chromium.org/2081083002 .
Cr-Commit-Position: refs/branch-heads/2743@{#421}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.47
Cr-Commit-Position: refs/branch-heads/2743@{#420}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge M52: "Freeze media time and audio rendering when the system suspends."
Allows us to avoid unexpected differences between what the audio
renderer and video renderer think the current time is. Causes the
wall clock time calculations to return false for "is time moving."
With this information the video renderer (and other callers) can
accurately act upon frozen moments and not expire frames due to
a difference of opinion on what the current time is (audio only
updates its base every Render() call).
BUG=620478
TEST=new unittests
Review-Url: https://codereview.chromium.org/2072843002
Cr-Commit-Position: refs/heads/master@{#400454}
(cherry picked from commit e3fb958aa538c5b146afea7f9df498a579d3e5a4)
Review URL: https://codereview.chromium.org/2089503002 .
Cr-Commit-Position: refs/branch-heads/2743@{#419}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix event warning crash when a listener is removed while dispatching event
Also, expose TestRunner.setDumpConsoleMessages() to tests to control whether
console messages are included into the test output.
BUG=612377
TBR=dgozman
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/1989103006
Cr-Commit-Position: refs/heads/master@{#395653}
(cherry picked from commit cb2227837d5d0e6a59e73eb62e56d53534a69386)
Review-Url: https://codereview.chromium.org/2078873003
Cr-Commit-Position: refs/branch-heads/2743@{#418}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[TTS] Fix the Quick Answer Caption in RTL languages.
When invalidate is called a new snapshot is taken. However it's possible
for the renderer to try to render during the invalid period. In this case
it may show the previous snapshot.
A previous attempt to fix this issue tried to snapshot a blank image,
but that caused a possibility of showing a blank image without overwriting
with a valid image, which we never saw until looking at RTL (which is
presumably slower taking a snapshot).
Exposing ViewResourceInflater#onEndCapture to subclasses to allow waiting for the capture of
the new snapshot to complete.
Added a new caption visibility property to the ContextualSearchLayer to control whether the resource for the caption is available, which allows a snapshot. Now the Caption Control checks whether a snapshot is complete before
returning a valid opacity.
BUG=610675, 608914
Review-Url: https://codereview.chromium.org/2038753005
Cr-Commit-Position: refs/heads/master@{#399344}
(cherry picked from commit 49a9b98d8821ddfb33f0e88415c88b2f27906416)
Review URL: https://codereview.chromium.org/2078393007 .
Cr-Commit-Position: refs/branch-heads/2743@{#417}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix build after bad merge
BUG=621661
TBR=mmohammad
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/2088513002 .
Cr-Commit-Position: refs/branch-heads/2743@{#416}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
SDCH: Fix case where a dictionary request fails after receiving data.
BUG=620858
Review-Url: https://codereview.chromium.org/2072863004
Cr-Commit-Position: refs/heads/master@{#400424}
(cherry picked from commit b6d05fc95fda596ffec9d7f23ea75c1699755b5a)
Review URL: https://codereview.chromium.org/2081823002 .
Cr-Commit-Position: refs/branch-heads/2743@{#415}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Fix problem with tab close button redraw.
With a theme installed the close button's "x" can have a different
color for the tab active and inactive states. This cl forces the close
button to redraw on tab state change so that it displays the "x" in the
correct color.
[email protected]
BUG=616008
Review-Url: https://codereview.chromium.org/2073523002
Cr-Commit-Position: refs/heads/master@{#400162}
(cherry picked from commit 29bd2eed90a5c548ce737aa09225952bfab22461)
Review URL: https://codereview.chromium.org/2080973002 .
Cr-Commit-Position: refs/branch-heads/2743@{#414}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable 4 and 8 digit hex CSS colors
New compat concerns have been raised with 4 and 8 digit HEX color
values in CSS. In particular, a targetSdk quirk needs to be added
for Android WebView to avoid breaking Android apps.
Demote this feature to "experimental" status until an owner can be found.
BUG=618518, 76362
Review-Url: https://codereview.chromium.org/2047413003
Cr-Commit-Position: refs/heads/master@{#398789}
(cherry picked from commit b7bc5783027ae86ff6eb6912d0a6112cda6a8814)
Review URL: https://codereview.chromium.org/2086433003 .
Cr-Commit-Position: refs/branch-heads/2743@{#413}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Don't set a default action for ToolbarActionsBarBubbles.
This isn't totally correct; some of these bubbles should have defaults
and some should not. But this was the behavior previous to dc0d234f7c87
so the more conservative approach is to revert to the old behavior and
later change/improve individual bubbles that should have defaults by
adding them.
This patch is designed to be easy/safe to merge to M52.
BUG=621122
Review-Url: https://codereview.chromium.org/2076993002
Cr-Commit-Position: refs/heads/master@{#400503}
(cherry picked from commit 0013e8398ca2cb80185a08bcf14358bc4310b27a)
Review URL: https://codereview.chromium.org/2084713002 .
Cr-Commit-Position: refs/branch-heads/2743@{#412}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable partial swap on VirtualBox on Linux.
It looks like the GL driver exposes the GLX_MESA_copy_sub_buffer
extension, but GetProcAddress("glXCopySubBufferMESA") incorrectly
returns null.
BUG=613722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2002753002
Cr-Commit-Position: refs/heads/master@{#395486}
(cherry picked from commit 72e829d44ebea9010a95409aecbcf2dd92aa52cb)
Review URL: https://codereview.chromium.org/2088483002 .
Cr-Commit-Position: refs/branch-heads/2743@{#411}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to 2743 "Gracefully handle GpuChannelManager::GetDefaultOffscreenSurface failure"
> BUG=618467
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2078593003
> Cr-Commit-Position: refs/heads/master@{#400297}
(cherry picked from commit 89d5065c918e90c43c98c75e3e3868f929d7af93)
[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/2084593003 .
Cr-Commit-Position: refs/branch-heads/2743@{#410}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix the frame freezing issue observed during a config change in the H.264 decoder on Windows
Merging to M52
We need to drain the decoder of any pending output before tearing down the
instance of the decoder and recreating it during a configuration change.
Draining the decoder is done as part of a Flush operation. However this is
a decoder initiated flush which requires the following
1. Don't process pending input in this case as that is what caused the
config change.
2. Don't notify the client about the completion of the flush operation.
Added a member variable processing_config_change_ to track this state. We
mimic most of the logic we have to process the pending_flush_ state when
this flag is set.
BUG=616349
Review-Url: https://codereview.chromium.org/2065323002
Cr-Commit-Position: refs/heads/master@{#400023}
(cherry picked from commit ec68dd1bde3f2049975d8aa194525983d4a93688)
Review URL: https://codereview.chromium.org/2081643003 .
Cr-Commit-Position: refs/branch-heads/2743@{#409}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Extensions UI] Fix a bug with removing a popped out extension
Fix a bug where removing a popped out extension would cause a crash.
This would only really happen with media router (cast), since all other
extensions are removed asynchronously and would pop themselves back into
the overflow. Add a test.
BUG=599467
Review-Url: https://codereview.chromium.org/2055423002
Cr-Commit-Position: refs/heads/master@{#399467}
(cherry picked from commit 6f3604a4335c823274bb08753277a1dfc5d7b3d4)
Review URL: https://codereview.chromium.org/2080393002 .
Cr-Commit-Position: refs/branch-heads/2743@{#408}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix and clean up application context in webview.
- Move responsibility of application context initialization in
AwBrowserProcess to caller to prevent double initialization.
- Switch to using ContextUtils.getApplicationContext for methods that
only need the application context. Ensures the wrapped context is
always used.
- Move away from using mWebViewDelegate.getApplication as that
returns the raw unwrapped application object.
BUG=620790
Review-Url: https://codereview.chromium.org/2076623002
Cr-Commit-Position: refs/heads/master@{#400664}
(cherry picked from commit 3680ea1ea5f72a714dc3e9d690263a29ca68d0ec)
Review URL: https://codereview.chromium.org/2080853002 .
Cr-Commit-Position: refs/branch-heads/2743@{#407}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
M52: PDF: Always call FPDFAvail_IsDocAvail() when loading.
BUG=613704
Review-Url: https://codereview.chromium.org/2006793003
Cr-Commit-Position: refs/heads/master@{#400286}
(cherry picked from commit 0968faa3214a03bc763d15fd66943ff3bcaf75d5)
Review URL: https://codereview.chromium.org/2080313003 .
Cr-Commit-Position: refs/branch-heads/2743@{#406}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
M52: Roll DEPS for sfntly to 468cad5.
[email protected]
BUG=614934
Review-Url: https://codereview.chromium.org/2060023003
Cr-Commit-Position: refs/heads/master@{#399363}
(cherry picked from commit e40502b71c9bd4f548118550952afd5d6a158bc4)
Review URL: https://codereview.chromium.org/2082643003 .
Cr-Commit-Position: refs/branch-heads/2743@{#405}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to 2743 "[DevTools] Implement WebDevToolsAgentClient::createClientMessageLoop for shared and service workers."
> [DevTools] Implement WebDevToolsAgentClient::createClientMessageLoop for shared and service workers.
>
> We ask random WebDevToolsAgentClient implementation for the message loop. If that happens to be a worker (for example, it could be alone in the process), message loop is null which leads to crash.
>
> BUG=614490
> [email protected]
>
> Review-Url: https://codereview.chromium.org/2061763003
> Cr-Commit-Position: refs/heads/master@{#399878}
(cherry picked from commit 2c10262a00eb7b81d18874f85bbddd774d0068f5)
[email protected]
Review URL: https://codereview.chromium.org/2080833002 .
Cr-Commit-Position: refs/branch-heads/2743@{#404}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
(Merge m52) Fix a bug with throttling and timer queue suspension
Both the ThrottlingHelper and timer queue suspension (via
SuspendTimerQueue/ResumeTimerQueue and
SuspendTimerQueueWhenBackgrounded / ResumeTimerQueueWhenForegrounded)
call TaskQueue::SetEnabled and it was possible for the ThrottlingHelper
to re-enable a suspended queue by mistake.
This patch prevents that from happening.
BUG=616052
Review-Url: https://codereview.chromium.org/2028433004
Cr-Commit-Position: refs/heads/master@{#397437}
(cherry picked from commit 22ca5b9bce1453364fdb32979af7175ccf234e15)
Review URL: https://codereview.chromium.org/2080563003 .
Cr-Commit-Position: refs/branch-heads/2743@{#403}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to 2743 "[DevTools] Clear WebDevToolsAgentImpl::m_client when detaching the frame."
> [DevTools] Clear WebDevToolsAgentImpl::m_client when detaching the frame.
>
> Since WebDevToolsAgentImpl is GarbageCollected, we cannot be sure
> it won't survive long enough after frame detach, which renders m_client
> invalid.
>
> This is a speculative crash fix, which is not reproducible locally.
>
> BUG=614490
>
> Review-Url: https://codereview.chromium.org/2006393002
> Cr-Commit-Position: refs/heads/master@{#395977}
(cherry picked from commit 0f947b84b5a9b6686aea25b1cc030c0ed7890194)
[email protected]
Review URL: https://codereview.chromium.org/2078333003 .
Cr-Commit-Position: refs/branch-heads/2743@{#402}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[m52] Make Alt-Svc: clear work with canonical hosts
BUG=620482
Review-Url: https://codereview.chromium.org/2069203003
Cr-Commit-Position: refs/heads/master@{#400060}
(cherry picked from commit 0c49a120616a28296dd457a023b63a65be94a15b)
Review URL: https://codereview.chromium.org/2080803002 .
Cr-Commit-Position: refs/branch-heads/2743@{#401}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac] Fix Toolbar glimpse during fullscreen transition
BUG=618594, 615810
Review-Url: https://codereview.chromium.org/2078733002
Cr-Commit-Position: refs/heads/master@{#400450}
(cherry picked from commit 04542485cce24e64e794c1dfd47d97fa5fbdf20c)
Review URL: https://codereview.chromium.org/2080793002 .
Cr-Commit-Position: refs/branch-heads/2743@{#400}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
aw: Try to turn crash into java exception
Since I can't work out why things are null in native code anymore.
BUG=618807
Review-Url: https://codereview.chromium.org/2076633002
Cr-Commit-Position: refs/heads/master@{#400690}
(cherry picked from commit c731f40f3bfbcdd77bab19a0a45cd2f23e86bd6e)
Review URL: https://codereview.chromium.org/2080323002 .
Cr-Commit-Position: refs/branch-heads/2743@{#399}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Reinstate evil hack to suppress permission warnings for searchProvider
(mostly a revert of https://codereview.chromium.org/1774103002/ )
BUG=619759
Original issue's description:
> Cleanup: remove evil hack to suppress permission warnings for searchProvider
>
> BUG=533086
>
> Committed: https://crrev.com/3e7756c7d39828136744fe7dffe1104eb5433843
> Cr-Commit-Position: refs/heads/master@{#379840}
Review-Url: https://codereview.chromium.org/2071293002
Cr-Commit-Position: refs/heads/master@{#400436}
(cherry picked from commit 0412744604981ba5d11ef68dfa356ed3d509fc21)
Review URL: https://codereview.chromium.org/2086523002 .
Cr-Commit-Position: refs/branch-heads/2743@{#398}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52] Use correct origin when prompting for proxy authentication.
Since M49, Chrome has been prompting for proxy authentication
credentials using the target origin instead of the origin of the proxy
server. Even if the proxy origin was displayed correctly, a mischievous
network operator could still spoof the proxy server origin. To mitigate
these problems, this CL:
* Fixes the origin used in the proxy authentication login prompt to use
the origin of the proxy server.
* Indicate if the proxy server connection is insecure.
* Always throw up an interstitial and clear the omnibox when showing a
proxy auth prompt.
* Use the correct origin when saving proxy authentication credentials.
BUG=613626, 620737
Review-Url: https://codereview.chromium.org/2067933002
Cr-Commit-Position: refs/heads/master@{#400247}
(cherry picked from commit 098c009df7a4ddc5c23d4d3c9dccf5eff1f24c98)
Review URL: https://codereview.chromium.org/2082513003 .
Cr-Commit-Position: refs/branch-heads/2743@{#397}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Re-enable extensions disabled due to permission increase if they have all permissions
BUG=616474
Review-Url: https://codereview.chromium.org/2019423007
Cr-Commit-Position: refs/heads/master@{#399876}
(cherry picked from commit 6e51bca1d4a7213bbf926104457eb3e2a22f6999)
Review URL: https://codereview.chromium.org/2084613002 .
Cr-Commit-Position: refs/branch-heads/2743@{#396}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Log First User Interaction in Page Load Metrics
Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit
BUG=612422
NOPRESUBMIT=true
NOTRY=true
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/1984173002
Cr-Commit-Position: refs/heads/master@{#398128}
(cherry picked from commit 48cac60dbb50219805cc59e04ad50022c0288bc7)
Review-Url: https://codereview.chromium.org/2086453002
Cr-Commit-Position: refs/branch-heads/2743@{#395}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Extensions: Add test for granting nuisance and implied permissions on update
This is the test that should have accompanied https://codereview.chromium.org/1995533002
BUG=603822,616474
Review-Url: https://codereview.chromium.org/2025303002
Cr-Commit-Position: refs/heads/master@{#397344}
(cherry picked from commit fef128daf132927b488fea58466ab834ccf7e1b7)
Review URL: https://codereview.chromium.org/2083583002 .
Cr-Commit-Position: refs/branch-heads/2743@{#394}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Set text anti-aliasing settings at PPAPI plugin process on Windows.
This patch will enable text anti-aliasing to call the following methods:
* blink::WebFontRendering::setAntialiasedTextEnabled
* blink::WebFontRendering::setLCDTextEnabled
This patch will also get anti-aliasing settings from
gfx::GetFontRenderParams method.
BUG=615375
TEST=If [Smooth edges of screen fonts] at advanced system settings is
enabled, text in flash is anti-aliased. If disabled, text is aliased.
Review-Url: https://codereview.chromium.org/2048563004
Cr-Commit-Position: refs/heads/master@{#399073}
(cherry picked from commit 90d6c375486700b6965665189853549c96716efa)
Review URL: https://codereview.chromium.org/2081643002 .
Cr-Commit-Position: refs/branch-heads/2743@{#393}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add md5 checksum for MediaTek platform for VDA unittests.
BUG=chrome-os-partner:54314
TEST=Run VDA thumbnail test on oak.
Review-Url: https://codereview.chromium.org/2062703002
Cr-Commit-Position: refs/heads/master@{#399681}
(cherry picked from commit cff35a5637cbb712f95837010e9696873ebe5b8e)
Review URL: https://codereview.chromium.org/2080583002 .
Cr-Commit-Position: refs/branch-heads/2743@{#392}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.46
Cr-Commit-Position: refs/branch-heads/2743@{#391}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.45
Cr-Commit-Position: refs/branch-heads/2743@{#390}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.44
Cr-Commit-Position: refs/branch-heads/2743@{#389}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Mac: Disable visual effects when fullscreen
These effects result in substantially higher power consumption.
Make the change in didEnter/willExit (as opposed to adjustUIForExiting/
ExitingFullscreen) because we want the effect to go away only while the
window is fullscreen (not during the transition).
BUG=620433
Review-Url: https://codereview.chromium.org/2071973002
Cr-Commit-Position: refs/heads/master@{#400308}
(cherry picked from commit 208098685cf35d3bb995cb365d204f0a65381ad3)
Review URL: https://codereview.chromium.org/2074933006 .
Cr-Commit-Position: refs/branch-heads/2743@{#388}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Change back to destroy the CDM synchronously
Outstanding promises may get rejected due to blink garbage collection
destroying all the remaining EME objects when they are no longer
referenced. The original fix destroyed the CDM asynchronously.
However, that causes problems as the CDM may hold references to
objects owned by RenderFrameImpl, and they may get accessed after
~RenderFrameImpl.
This fix posts a task to reject the promise asynchronously. That way
any outstanding promises that need to be rejected are handled after
gc is done. It affects all EME promise rejections (from Chromium).
Resolving promises is still done synchronously as there may be events
already posted that need to happen only after the promise is resolved.
BUG=597355
TEST=existing EME tests still pass
Review-Url: https://codereview.chromium.org/1987883002
Cr-Commit-Position: refs/heads/master@{#398986}
(cherry picked from commit 3135b5eec1c39fb213cbf906f81553efa8cbaf67)
Review URL: https://codereview.chromium.org/2078833004 .
Cr-Commit-Position: refs/branch-heads/2743@{#387}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Reset indeterminate animation width to 0 when canceled
This change also resets the target for the progress bar when
it finishes. In most cases the target progress is reset by
having 0 sent by the tab, however, if the progress bar is not
yet showing this signal is ignored. The result of this change
is the progress bar not hanging on some sites.
BUG=618489
Review-Url: https://codereview.chromium.org/2071103002
Cr-Commit-Position: refs/heads/master@{#400497}
(cherry picked from commit 124f0f67fd3a00684516430b767e65830a5083f7)
Review URL: https://codereview.chromium.org/2080473002 .
Cr-Commit-Position: refs/branch-heads/2743@{#386}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Updated the EV cert update, Keyword search, and Popup blocking decorations with the new specs
BUG=611113
Review-Url: https://codereview.chromium.org/1990703002
Cr-Commit-Position: refs/heads/master@{#395108}
(cherry picked from commit a76a3173e38bb3fab808ce5cdbf651d169f9194f)
Review URL: https://codereview.chromium.org/2075293002 .
Cr-Commit-Position: refs/branch-heads/2743@{#385}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Adjust cutoff for detecting a "dark" theme.
Chrome looks at the whiteComponent of a theme's custom toolbar color to
decide if the theme is "dark." The line between ligth and dark is an
empirical value - this cl adjusts the cutoff in hopes of getting closer
to the right value.
[email protected]
BUG=614806,617993
Review-Url: https://codereview.chromium.org/2068243002
Cr-Commit-Position: refs/heads/master@{#400168}
(cherry picked from commit f4acec7a4f8fe1e3e50785a7a601499c2f7619b5)
Review URL: https://codereview.chromium.org/2077743004 .
Cr-Commit-Position: refs/branch-heads/2743@{#384}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
DatabaseTracker: Use 'raw' string as key for origin
Prior to r382660 the WebSQL implementation used DatabaseIdentifiers, and
a serialization was used as the key in maps. This was changed to take
SecurityOrigins instead and the serialization via toString(). This
introduced additional special cases e.g. "null" for file:// origins in
some cases, leading to mismatches between setting and lookup in the
map depending on when the SecurityOrigin was minted. To fix, use
toRawString() within the DatabaseTracker which matches the old behavior.
Similarly, use toRawString() when serializing an origin for posting
across threads.
BUG=618381
[email protected]
Review-Url: https://codereview.chromium.org/2050803005
Cr-Commit-Position: refs/heads/master@{#399743}
(cherry picked from commit 1667e9b86e2ede1e6267db73445478b447cca2e8)
Review URL: https://codereview.chromium.org/2080463002 .
Cr-Commit-Position: refs/branch-heads/2743@{#383}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add support for user certificates in Android N.
BUG=616511
Review-Url: https://codereview.chromium.org/2059943003
Cr-Commit-Position: refs/heads/master@{#399320}
(cherry picked from commit 385f7c9450a1182335fb41578d24116b548cbdc6)
Review URL: https://codereview.chromium.org/2077073002 .
Cr-Commit-Position: refs/branch-heads/2743@{#382}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Auto-rebaseline for r400366
https://chromium.googlesource.com/chromium/src/+/e52c57c45
BUG=619973
[email protected]
Review URL: https://codereview.chromium.org/2073073002 .
Cr-Commit-Position: refs/heads/master@{#400388}
(cherry picked from commit 757686ec13f667253c9ecc47597e4a8502f720be)
Review URL: https://codereview.chromium.org/2078903003 .
Cr-Commit-Position: refs/branch-heads/2743@{#381}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Rebaseline non-square scrollbar button tests on Windows. Add NeedsManualRebaseline for Linux since the rebaseline bot is currently broken.
BUG=619973
TBR=dmazzoni
Review-Url: https://codereview.chromium.org/2063253002
Cr-Commit-Position: refs/heads/master@{#399770}
(cherry picked from commit dd64c13101faffeb0094dbd5a5bd6dd79f34515c)
Review URL: https://codereview.chromium.org/2078013002 .
Cr-Commit-Position: refs/branch-heads/2743@{#380}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Draw nicer arrows when the scrollbar buttons are not square.
Before they would look squished or messed up, but with this patch
their bounding box is always square so we'll get the nice pixel pyramids
that we want. This shouldn't change anything visually for the normal
square scrollbar buttons.
BUG=614297
Review-Url: https://codereview.chromium.org/2009733002
Cr-Commit-Position: refs/heads/master@{#399626}
(cherry picked from commit 91cbc6d7c2f02771ee3640a4b2f3376029b3bab0)
Review URL: https://codereview.chromium.org/2075213002 .
Cr-Commit-Position: refs/branch-heads/2743@{#379}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
CHECK that Resource request/response urls are equalIgnoringFragmentIdentifer, not equal
BUG=618967
TEST=ResourceTest.RevalidateWithFragment
Review-Url: https://codereview.chromium.org/2061843002
Cr-Commit-Position: refs/heads/master@{#399589}
(cherry picked from commit 9a5635c505fc5b93036793d5b2abe6793b0c5d80)
Review URL: https://codereview.chromium.org/2074003003 .
Cr-Commit-Position: refs/branch-heads/2743@{#378}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Handle null transfer buffers for USB transfer errors.
Recent refactoring of //device/usb has introduced the possibilty of a
failed transfer request producing a null transfer buffer. This patch
updates usb_api.cc to handle this case and the tests to cover it.
BUG=619416
Review-Url: https://codereview.chromium.org/2069163002
Cr-Commit-Position: refs/heads/master@{#399975}
(cherry picked from commit 8ef21d18b67d26b64d981cac45069fa8c4ff3370)
Review URL: https://codereview.chromium.org/2071263002 .
Cr-Commit-Position: refs/branch-heads/2743@{#377}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Don't use selection bounds to paint document marker
If there is no selection, selection bounds may exceed the paint
invalidation rect.
The original reason of using selection bounds to paint document
marker "when the selection and this highlight are on the same word
there are no pieces sticking out" no longer applies because we don't
allow selection and document markers at the same time.
BUG=619633
Review URL: https://codereview.chromium.org/2073993002 .
Review-Url: https://codereview.chromium.org/2065723002
Cr-Original-Commit-Position: refs/heads/master@{#400080}
Cr-Commit-Position: refs/branch-heads/2743@{#376}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.43
Cr-Commit-Position: refs/branch-heads/2743@{#375}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
media: Fix a typo in PipelineError rappor reporting
Apparently I was missing a "." :(
BUG=607949
TEST=Verified the name is correct now.
Review-Url: https://codereview.chromium.org/2061393002
Cr-Commit-Position: refs/heads/master@{#399846}
(cherry picked from commit 0b81daa043ac6c4aeecd2a99aa055ac20fdc6511)
Review URL: https://codereview.chromium.org/2072953002 .
Cr-Commit-Position: refs/branch-heads/2743@{#374}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[M-52] Catch IllegalArgumentException during MediaCodec::start().
MediaCodec::start sometimes throws IllegalArgumentException, though
the documentation doesn't describe this. Crash reports indicate
nothing terribly useful, except that sometimes AVDA destruction is
pending on another thread, indicating that mediaserver has stopped
responding. Many crash reports don't show this, however.
Some others show messages about mediaserver crashing.
This CL won't fix the underlying problem(s), but will prevent the
browser from crashing.
This is a merge of https://codereview.chromium.org/2067363002
BUG=611502
[email protected]
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2077673002
Cr-Commit-Position: refs/branch-heads/2743@{#373}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[ios] Fixed dialogs suppression.
The issue happened in the following scenario:
- uer typed in the omnibox to trigger preload
- preload Tab set shouldSuppressDialogs to YES
- web view did not exist so suppression was postponed until the load
- user tapped Go to promote preload Tab to real Tab
- preload Tab set shouldSuppressDialogs to NO
- page loaded and postponed suppression suppresses the dialods
This change always cancels postoned suppression if
shouldSuppressDialogs was set to NO.
BUG=618831
Review-Url: https://codereview.chromium.org/2072553002
Cr-Commit-Position: refs/heads/master@{#400020}
(cherry picked from commit fc51dd2482615bab3c156bcd5d3744d146be84ee)
Review URL: https://codereview.chromium.org/2071023002 .
Cr-Commit-Position: refs/branch-heads/2743@{#372}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Enable the translate bubble to be dismissed when user ignores it.
Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.
Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.
BUG=619192
Review-Url: https://codereview.chromium.org/2061523002
Cr-Commit-Position: refs/heads/master@{#399543}
(cherry picked from commit 153dc6af7e1ac70671eefd48faed85c85cb151f0)
Review URL: https://codereview.chromium.org/2074913002 .
Cr-Commit-Position: refs/branch-heads/2743@{#371}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix shutdown crash in settings app monitor.
Don't assume that the caller's task runner will outlive the monitor.
BUG=611827
[email protected]
Review-Url: https://codereview.chromium.org/2065673002
Cr-Commit-Position: refs/heads/master@{#399528}
(cherry picked from commit 2c76bfb795b85473a03397b185dce94f7c263de3)
[email protected]
Review URL: https://codereview.chromium.org/2070933002 .
Cr-Commit-Position: refs/branch-heads/2743@{#370}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Report user actions for interactions with the Windows Settings app.
BUG=611827
Review-Url: https://codereview.chromium.org/2003553003
Cr-Commit-Position: refs/heads/master@{#396184}
(cherry picked from commit c291eea8c3fe6ff78ee8c653063aff619fab21b2)
[email protected]
Review URL: https://codereview.chromium.org/2077583003 .
Cr-Commit-Position: refs/branch-heads/2743@{#369}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Material][Mac] Replace the default favicon with a vector
BUG=618742
Review-Url: https://codereview.chromium.org/2052153002
Cr-Commit-Position: refs/heads/master@{#399930}
(cherry picked from commit b2557875f1783f455212f45fdd85fcd3af9b35f6)
Review URL: https://codereview.chromium.org/2072833002 .
Cr-Commit-Position: refs/branch-heads/2743@{#368}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[css-flexbox] Fix handling of borders/padding for abspos items
We can't use the flowAware functions for these because they are
unaffected by the flex-direction. Use regular block functions instead.
[email protected]
BUG=617287
Review-Url: https://codereview.chromium.org/2052243003
Cr-Commit-Position: refs/heads/master@{#399896}
(cherry picked from commit 7640d892c09f7f8307648de38ca2e29a625dcc10)
Review URL: https://codereview.chromium.org/2065383005 .
Cr-Commit-Position: refs/branch-heads/2743@{#367}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Sharpen ImeThread failure detection and prevent infinite wait
We lose window focus when the user enters overview mode or goes to the
launcher, or even when the user peeks the notification bar.
When this happens, it is natural that Android framework does not activate
input method, but we've been recording non-activation as a failure.
One way to fix this is to add window and view focus checks, but is not
a complete solution. Since InputMethodManagerService checks the window
focus by directly calling WindowManagerService#inputMethodClientHasFocus(),
and the window focus change gets propagated to the View through View's
message loop, we may need to wait one more message loop before calling
View#hasWindowFocus().
Also, this CL prevents infinite wait in case previous InputConnection
waits for text input state update while the InputConnection got replaced
by a new InputConnection.
BUG=617912
Review-Url: https://codereview.chromium.org/2062033002
Cr-Commit-Position: refs/heads/master@{#400077}
(cherry picked from commit fb71d3f0729c67a7e3fedd9ff0ab5d860870fd1f)
Review URL: https://codereview.chromium.org/2074593002 .
Cr-Commit-Position: refs/branch-heads/2743@{#366}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.42
Cr-Commit-Position: refs/branch-heads/2743@{#365}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to M52] Fix SAML single-password scrapping authenticating with an empty password
Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.
[email protected]
BUG=618279,617962
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2049103002
Cr-Commit-Position: refs/heads/master@{#398624}
(cherry picked from commit ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449)
Review URL: https://codereview.chromium.org/2074433002 .
Cr-Commit-Position: refs/branch-heads/2743@{#364}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
binding: Fixes the fallback mechanism of Document's named properties.
The old implementation only works for
a) there is a hidden prototype, and documentWrapper->GetPrototype()
actually returns itself, or
b) fallbacked attributes are data-type properties.
Since we made attributes be accessor-type properties _and_ removed
the hidden prototype, the old implementation no longer works.
Fixed the issue using V8's GetRealNamedPropertyInPrototypeChain().
BUG=619036
Review-Url: https://codereview.chromium.org/2065523002
Cr-Commit-Position: refs/heads/master@{#399461}
(cherry picked from commit cccf8630bac25057f6afd30febf8c428cd486b8c)
Review URL: https://codereview.chromium.org/2070463002 .
Cr-Commit-Position: refs/branch-heads/2743@{#363}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Reland "Respect the order of input messages from browser to renderer"
Fixed build error.
>>
When we call InputConnection#setSelection and other methods together,
the order sometimes does not get kept. The reason is that
SetEditableSelectionOffsets is a frame message while all the others are
input messages, and they go to different message queues.
In addition, RenderViewImpl is the only who registers its routing ID
through InputHandlerManager::AddInputHandler() call. RenderFrameImpl,
on the other hand, does not register itself.
Once routing ID is registered, InputEventFilter will post input messages to
compositor impl thread first (such that scrolling can happen inside
compositor impl thread and keep in line with other input message handling
order).
We fix this by
1) Changing SetEditableSelectionOffsets from FrameMsg to InputMsg.
(Now there is no remaining frame messages in ime_adapter_android.cc.)
2) Change DidAddInputHandler() and DidRemoveInputHandler() names to
RegisterRoutingID() and UnregisterRoutingID(), respectively.
3) Register RenderFrame's routing ID at InputEventFilter.
BUG=601707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1877073003
Cr-Commit-Position: refs/heads/master@{#399404}
(cherry picked from commit d659e20ed5d564cca67934147b481a32a59f3f6a)
Review URL: https://codereview.chromium.org/2060713002 .
Review URL: https://codereview.chromium.org/2065333002 .
Cr-Original-Commit-Position: refs/branch-heads/2743@{#330}
Cr-Original-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Cr-Commit-Position: refs/branch-heads/2743@{#362}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
