Publish DEPS for Chromium 52.0.2743.41
Incrementing VERSION to 52.0.2743.41
Cr-Commit-Position: refs/branch-heads/2743@{#361}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[UI Views] Unset the extension keybinding registry on frame destruction
Some destruction flows don't seem to call OnWidgetActivationChanged
before destroying the window, which causes the extension keybinding
registry reference in the global registry to become stale. Update the
active registry on deletion.
BUG=616970
Review-Url: https://codereview.chromium.org/2046653002
Cr-Commit-Position: refs/heads/master@{#398167}
(cherry picked from commit fbcfdaeb71885d8081579746bedfbc6c5b813f11)
Review URL: https://codereview.chromium.org/2061383002 .
Cr-Commit-Position: refs/branch-heads/2743@{#360}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Set FLAGS_shift_quic_cubic_epoch_when_app_limited to false.
[email protected]
BUG=618144
Review-Url: https://codereview.chromium.org/2050533002
Cr-Commit-Position: refs/heads/master@{#398441}
(cherry picked from commit a7932f6f652d7a985d9bec588edf6349cf533d23)
Review URL: https://codereview.chromium.org/2069883003 .
Cr-Commit-Position: refs/branch-heads/2743@{#359}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add heuristics to limit showing of new backspace UI bubble.
This restricts the bubble to showing 5 times, and only showing when users
trigger backspace twice within three seconds (which likely indicates "hey, why
isn't the browser going back").
The bubble is also immediately hidden (by fading out) if the user successfully
navigates back or forward (by any means) while it's showing.
BUG=610039,615760
TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds. After the UI is shown 5 times, it should not appear again.
TBR=phajdan.jr
Review-Url: https://codereview.chromium.org/2041293002
Cr-Commit-Position: refs/heads/master@{#399114}
(cherry picked from commit 36aa72944195f579454c1d3abea5045219fd685a)
Review URL: https://codereview.chromium.org/2065283002 .
Cr-Commit-Position: refs/branch-heads/2743@{#358}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add timeout to swap fence
In some cases (mainly on Mac OS 10.9), it appears that a glFence
may never pass. To work around this issue (and make the code more
robust in similar cases), a 32ms timeout has been added, after which
we will just call glFinish rather than continuing to wait on the fence.
Will add an UMA stat in a follow-up CL to make sure this is very rare
on 10.9 - if this turns out to be at all common, we should probably
modify 10.9 to indicate that it doesn't support glFence.
BUG=618075
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2064853002
Cr-Commit-Position: refs/heads/master@{#399598}
(cherry picked from commit d84042a6b9b061fd319c0068bdd0c786a16fcc85)
Review URL: https://codereview.chromium.org/2065223003 .
Cr-Commit-Position: refs/branch-heads/2743@{#357}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "Track password field id so it can be used to improve uniqueness of passwordId"
> BUG=618717
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2053393003
> Cr-Commit-Position: refs/heads/master@{#399266}
> (cherry picked from commit 8623bfce0e587884b73a85e0106059a46d598f2d)
Review URL: https://codereview.chromium.org/2065223002 .
Cr-Commit-Position: refs/branch-heads/2743@{#356}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Updating XTBs based on .GRDs from branch 2743
Cr-Commit-Position: refs/branch-heads/2743@{#355}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert "Do not suppress referrers for '<a ... rel="noopener">'." on M52 branch
The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.
BUG=618532,619856
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/2063283002 .
Cr-Commit-Position: refs/branch-heads/2743@{#354}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix for sync filesystem app crash.
Previously removing the SafePointScope had a risk of producing a dead lock if the following scenario happens:
1) The main thread starts a GC and tries to stop all other threads.
2) The worker thread is waiting on a signal without entering the SafePointScope. The main thread cannot stop the worker thread forever and thus cannot make progress. Dead lock.
However, (to avoid this kind of dead lock) code has been added to timeout the GC if the GCing thread fails at stopping other threads within 100 ms. So not entering SafePointScope will just cause the timeout -- it won't cause a dead lock.
This fixes a hard-to-reproduce timing bug that's been a big concern of one of our partners.
BUG=592124,608603
TEST=manual
Review-Url: https://codereview.chromium.org/2009093002
Cr-Commit-Position: refs/heads/master@{#399265}
(cherry picked from commit f466a07e32ce1c8083dc726c7391e68b2ff2e7b0)
Review URL: https://codereview.chromium.org/2065823003 .
Cr-Commit-Position: refs/branch-heads/2743@{#353}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix generation of inner_url in GURL::Replacements.
It was being created using a combination of the old and new URLs,
instead of just using the new URL.
BUG=615820
Review-Url: https://codereview.chromium.org/2029213002
Cr-Commit-Position: refs/heads/master@{#399501}
(cherry picked from commit 73cea7e4afe9d7ffc45cecc80da954a481bbb48d)
Review URL: https://codereview.chromium.org/2062183002 .
Cr-Commit-Position: refs/branch-heads/2743@{#352}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Prevent error when route becomes null
Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.
BUG=614144
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2053743002
Cr-Commit-Position: refs/heads/master@{#399281}
(cherry picked from commit 16bc9a232bd6ef00891eb061687d23f77ee29efd)
Review-Url: https://codereview.chromium.org/2065023002
Cr-Commit-Position: refs/branch-heads/2743@{#351}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert "Respect the order of input messages from browser to renderer"
This reverts commit 17ab5a827acb2ae1dbf1a53181d0dd09a0769766.
Causing build failures.
BUG=619820,601707
Cr-Commit-Position: refs/branch-heads/2743@{#350}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists
This patch fixes removeFloatingOrPositionedChildFromBlockLists fails to
remove floats when their containing block is LayoutView.
BUG=613869
Review-Url: https://codereview.chromium.org/2042353002
Cr-Commit-Position: refs/heads/master@{#398399}
(cherry picked from commit fac93418b4bcf2f8c7480696567db3e2d12d467b)
Review URL: https://codereview.chromium.org/2064743003 .
Cr-Commit-Position: refs/branch-heads/2743@{#349}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Do not suppress referrers for '<a ... rel="noopener">'.
The current implementation of 'noopener' correctly split the referrer
and opener states in Blink, but missed a spot higher up the stack where
the two were still conflated. This patch fixes that issue, adds tests
to ensure we don't regress, and refactors the Blink-side code a bit so
that we're no longer passing the data around twice.
BUG=618532
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2058693002
Cr-Commit-Position: refs/heads/master@{#399391}
(cherry picked from commit 4c82bb5386376f64c2a8eb9258ea397cba04b7d1)
Review URL: https://codereview.chromium.org/2067753002 .
Cr-Commit-Position: refs/branch-heads/2743@{#348}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Assign each route a current cast mode if possible
This change gives each media route in the WebUI a current cast mode
value if its media source corresponds to one of the currently available
cast modes. This is to prevent showing the 'cast' button that allows
replacing the route when the new route would effectively be a copy of
the original route.
BUG=614144
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2040883002
Cr-Commit-Position: refs/heads/master@{#398687}
(cherry picked from commit a47d5b0506c1183d501767d17ffec02ca419ea76)
Review-Url: https://codereview.chromium.org/2068593002
Cr-Commit-Position: refs/branch-heads/2743@{#347}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fixed overlapping subtle notifications on Mac.
Can happen when a fullscreen/pointer-lock bubble and a new-back-shortcut
bubble are visible at the same time. Now the new bubble will dismiss the
old bubble (which is the behaviour on Views platforms).
BUG=615971
Review-Url: https://codereview.chromium.org/2028963002
Cr-Commit-Position: refs/heads/master@{#397973}
(cherry picked from commit e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f)
Review URL: https://codereview.chromium.org/2063103002 .
Cr-Commit-Position: refs/branch-heads/2743@{#346}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.40
Cr-Commit-Position: refs/branch-heads/2743@{#345}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Updating XTBs based on .GRDs from branch 2743
Cr-Commit-Position: refs/branch-heads/2743@{#344}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Rename close route event in html
The event name used in media_router_container.html for closing routes
was not renamed by the previous change.
BUG=614144
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2036383002
Cr-Commit-Position: refs/heads/master@{#397792}
(cherry picked from commit e3c5d24288f9029a7ef82d6892f9d9afbb4fc607)
Review-Url: https://codereview.chromium.org/2061043002
Cr-Commit-Position: refs/branch-heads/2743@{#343}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add UMA for studying download cancellation reasons
We found high cancellation rate with new download experiment.
This CL is to study why user cancels the download
[email protected]
BUG=618864
Review-Url: https://codereview.chromium.org/2058593002
Cr-Commit-Position: refs/heads/master@{#399521}
(cherry picked from commit 8211e681b8a98df75bf56e05d30d4179033cee3e)
Review URL: https://codereview.chromium.org/2061063002 .
Cr-Commit-Position: refs/branch-heads/2743@{#342}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Update selection region style
* use simple gray region
* use gray for unselected regions instead.
* use darker gray for unselected region
* Instead of using platform cursor, draw pseudo cursor when selecting region
BUG=608269
Review-Url: https://codereview.chromium.org/1997193002
Cr-Commit-Position: refs/heads/master@{#397498}
(cherry picked from commit ef6f5af980b06e664d0cd9dc7cb578d6862b6c36)
Review URL: https://codereview.chromium.org/2030253004 .
Cr-Commit-Position: refs/branch-heads/2743@{#341}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Allow casting new media to sink with existing route.
This change allows for one button push to stop casting to a sink and
then immediately create a new route to the same sink with the selected
source. The makes the user experience smoother by not making them stop
the current cast and then start a new one manually in two stops.
Some shortcomings of this change that will be addressed in the future:
- At least for mirroring, it's possible to avoid stopping the route and
just switch the stream sources. This probably requires adding a new
API to the extension.
- The button will currently allow users to re-cast the current source,
stopping the current route and starting a new one, even though this
isn't necessary. When both the old and new sources are tabs, the tab
IDs could be checked, but other cases would have to be handled in MR
or the extension.
BUG=614144
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2002293003
Cr-Commit-Position: refs/heads/master@{#397457}
(cherry picked from commit 4680358215ff217eb6b0073c4be2243738369957)
Review-Url: https://codereview.chromium.org/2062913002
Cr-Commit-Position: refs/branch-heads/2743@{#340}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
cc: Fix for synced property main thread updates with MFBA.
Main thread before activation allows sending BeginMainFrames while there
is a pending tree. In this mode pulling deltas from SyncedProperty for
BeginMainFrame should not be incorrect in between commit and activation
of a previous frame.
BUG=616086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2035543003
Cr-Commit-Position: refs/heads/master@{#399079}
(cherry picked from commit d2580f5c4fd242f3b0bfe03fbad71e4db5b5fa08)
Review URL: https://codereview.chromium.org/2062963002 .
Cr-Commit-Position: refs/branch-heads/2743@{#339}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to M52]: Add the Cryptohome.TpmResults histogram
After this CL: https://chromium-review.googlesource.com/#/c/349425/ has
landed, we need to add the TpmResults and its enum values.
[email protected]
BUG=430125
Review-Url: https://codereview.chromium.org/2043463002
Cr-Commit-Position: refs/heads/master@{#398690}
(cherry picked from commit 1e051c9c294cfb2d8c4125ca1cc6b3304c95ea17)
Review URL: https://codereview.chromium.org/2060953003 .
Cr-Commit-Position: refs/branch-heads/2743@{#338}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Remove flex layout from cast button
The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.
BUG=618508
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2049953003
Cr-Commit-Position: refs/heads/master@{#399003}
(cherry picked from commit b4a9571b30800a635327ab6fe40eb8014901f8e0)
Review-Url: https://codereview.chromium.org/2059353002
Cr-Commit-Position: refs/branch-heads/2743@{#337}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Mark the Izenpe log as Disqualified
The Izenpe Log should be disqualified as of 2016-05-30
BUG=614656
[email protected]
Review-Url: https://codereview.chromium.org/2015493002
Cr-Commit-Position: refs/heads/master@{#396646}
(cherry picked from commit db47cd8c36459274d5634ae462059ee4a7e6434e)
Review URL: https://codereview.chromium.org/2060413002 .
Cr-Commit-Position: refs/branch-heads/2743@{#336}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
aw: Add missing destroy check
BUG=618807
Review-Url: https://codereview.chromium.org/2052023002
Cr-Commit-Position: refs/heads/master@{#399083}
(cherry picked from commit da412bea2a14e2b4203fffb071075c8115a22cb1)
Review URL: https://codereview.chromium.org/2059273002 .
Cr-Commit-Position: refs/branch-heads/2743@{#335}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable PDFium XFA forms.
There have been a lot of bugs found/reported.
BUG=62400,619061
Review-Url: https://codereview.chromium.org/2052163002
Cr-Commit-Position: refs/heads/master@{#399109}
(cherry picked from commit 01c031ab48e032bc73aa39f1d5871ed3b9d4c7e5)
Review URL: https://codereview.chromium.org/2065613003 .
Cr-Commit-Position: refs/branch-heads/2743@{#334}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
H264Decoder: work around nonconforming streams with consecutive IDRs.
Per H264 spec, idr_pic_id should differ for two consecutive IDRs in the
stream. Unfortunately, not all streams conform to this requirement. Work
around this by checking first_mb_in_slice in these cases and trigger
a new picture if the second IDR slice starts with 0th macroblock.
BUG=chrome-os-partner:52181,580064,b/28032676,b/29061984
TEST=various problematic streams from bug reports,crosvideo.appspot,vdatest
Review-Url: https://codereview.chromium.org/2032323002
Cr-Commit-Position: refs/heads/master@{#397971}
(cherry picked from commit bd1db4598073eb2428abaf0d76449eab0ced71e7)
Review URL: https://codereview.chromium.org/2060763002 .
Cr-Commit-Position: refs/branch-heads/2743@{#333}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix source file read error in VEA unittest
base::ReadFile always reads file from beginning.
Use base::File instead.
BUG=chrome-os-partner:41833
TEST=run video_HangoutHardwarePerf.vp8 and passed. Also check the
encoded output.
Review-Url: https://codereview.chromium.org/2032453002
Cr-Commit-Position: refs/heads/master@{#397340}
(cherry picked from commit a6bd1f748d1bbedc98527df5c9e085b62fd57223)
Review URL: https://codereview.chromium.org/2065483002 .
Cr-Commit-Position: refs/branch-heads/2743@{#332}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Remove base::MemoryMappedFile in VEA unittest
Since MemoryMappedFile caused kernel panic, replace it by a large
buffer. We also don't have to create a temporary file for aligned
input file.
BUG=chrome-os-partner:41833
TEST=run video_HangoutHardwarePerf.vp8 and passed.
Review-Url: https://codereview.chromium.org/1994063002
Cr-Commit-Position: refs/heads/master@{#395300}
(cherry picked from commit a1e9b246e01fd323ec97b75cb63f243def943bf0)
Review URL: https://codereview.chromium.org/2054403002 .
Cr-Commit-Position: refs/branch-heads/2743@{#331}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Respect the order of input messages from browser to renderer
When we call InputConnection#setSelection and other methods together,
the order sometimes does not get kept. The reason is that
SetEditableSelectionOffsets is a frame message while all the others are
input messages, and they go to different message queues.
In addition, RenderViewImpl is the only who registers its routing ID
through InputHandlerManager::AddInputHandler() call. RenderFrameImpl,
on the other hand, does not register itself.
Once routing ID is registered, InputEventFilter will post input messages to
compositor impl thread first (such that scrolling can happen inside
compositor impl thread and keep in line with other input message handling
order).
We fix this by
1) Changing SetEditableSelectionOffsets from FrameMsg to InputMsg.
(Now there is no remaining frame messages in ime_adapter_android.cc.)
2) Change DidAddInputHandler() and DidRemoveInputHandler() names to
RegisterRoutingID() and UnregisterRoutingID(), respectively.
3) Register RenderFrame's routing ID at InputEventFilter.
BUG=601707
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/1877073003
Cr-Commit-Position: refs/heads/master@{#399404}
(cherry picked from commit d659e20ed5d564cca67934147b481a32a59f3f6a)
Review URL: https://codereview.chromium.org/2060713002 .
Cr-Commit-Position: refs/branch-heads/2743@{#330}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.39
Cr-Commit-Position: refs/branch-heads/2743@{#329}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.38
Cr-Commit-Position: refs/branch-heads/2743@{#328}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Close dialog after resolving presentation request
This change causes the Media Router dialog to close after it resolves a
route that is from a presentation request. This prevents the dialog from
staying open (by the user keeping their mouse over it) and reusing the
same presentation request for another route request (which is an error).
BUG=617321
[email protected]
Review-Url: https://codereview.chromium.org/2038423006
Cr-Commit-Position: refs/heads/master@{#398683}
(cherry picked from commit cbe9df4959c78e3d8a4fbaa1fef5ccde9b4c0f3f)
Review URL: https://codereview.chromium.org/2060433004 .
Cr-Commit-Position: refs/branch-heads/2743@{#327}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Move the routing-info inside the jingle element.
Previously, routing info are encoded in the iq node. When the host is
offline, the talk network responds with an error IQ that doesn't get
relayed to the client because it doesn't have the routing info that the
signaling service needs.
Since an error IQ always contain the original request, by moving the
routing info inside the original jingle request, we can reliably route
the error message back to the client.
Review-Url: https://codereview.chromium.org/2042513002
Cr-Commit-Position: refs/heads/master@{#398383}
(cherry picked from commit 046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74)
BUG=618143
Review URL: https://codereview.chromium.org/2061503002 .
Cr-Commit-Position: refs/branch-heads/2743@{#326}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix background show logic for UI compositor
The logic that determined whether or not to show the background
of the root layer is no longer applicable due to the toolbar layer
always being a parent to the content. This change updates the
background visibility logic in for StaticTabSceneLayer to look at
the root layer.
BUG=615365
Review-Url: https://codereview.chromium.org/2040513002
Cr-Commit-Position: refs/heads/master@{#399311}
(cherry picked from commit ab5f51e2c8f06447cdcff9b30a145c6649f98ba8)
Review URL: https://codereview.chromium.org/2060653002 .
Cr-Commit-Position: refs/branch-heads/2743@{#325}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.37
Cr-Commit-Position: refs/branch-heads/2743@{#324}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix DropdownPopupWindow's position in Android N.
In Android N, the framework will read view.getLeft() and view.getTop() to
determine where to put the drop down, and if the anchor view is not on screen,
the parent view will be scrolled to make it on screen (by means of
requestChildRectangleOnScreen).
setLayoutParams() is not enough to change left and top values of the anchorView
immediately. Show()ing the ListPopupWindow immediately after setLayoutParams()
will show the popup window in the wrong location, and also cause the parent view
to be improperly scrolled.
Call postShow() to put show() after when the layout of the anchor view is
changed.
Initial selection has to be set after show() is actually called,
because getListView() is null until the ListPopupWindow is shown.
BUG=614746
Review-Url: https://codereview.chromium.org/2049523005
Cr-Commit-Position: refs/heads/master@{#399274}
(cherry picked from commit 87634341cb230c465a1d2c5cdb09f79c0a97bc08)
Review URL: https://codereview.chromium.org/2057403002 .
Cr-Commit-Position: refs/branch-heads/2743@{#323}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix gfx > gl name change missed in rebase
When rebasing 0860d25a7da18c7f7c6e5d038f0d74dac368b452 for merge, I
missed the gfx > gl name change which had happened on ToT. This change
adjusts gl > gfx for the release branch.
TBR=ccameron
Review URL: https://codereview.chromium.org/2062573002 .
Cr-Commit-Position: refs/branch-heads/2743@{#322}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material]Update the text color on Guest Mode Chip
BUG=618506
Review-Url: https://codereview.chromium.org/2050303003
Cr-Commit-Position: refs/heads/master@{#398995}
(cherry picked from commit bb1df9d42a87c280c4add2366c51fa2e8bff8f36)
Review URL: https://codereview.chromium.org/2062563002 .
Cr-Commit-Position: refs/branch-heads/2743@{#321}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Modify ImageTransportSurfaceOverlayMac to allow pipelining
This change allows 1 additional frame of pipelining in
ImageTransportSurfaceOverlayMac by switching from a glFinish based
approach to a glFence based one.
Tested for CA framerate regressions - the following cases starve CA
when used with a simple glFlush. This solution (and the previous
glFinish) appear to successfully prevent CA starvation:
Animometer - bouncing png images:
https://trac.webkit.org/export/HEAD/trunk/PerformanceTests/Animometer/developer.html?test-interval=20&display=progress-bar&controller=adaptive&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=SVGsuite&test-name=SVGbouncingPNGimages&complexity=200
Both glFinish and glFence produce ~50 fps in CA/Chrome.
WebGL Liquid Face:
http://alteredqualia.com/xg/examples/liquid_face.html
For liquid face, note that with the glFinish, CA framerate is slightly
higher than Chrome reported framerate (20 vs 15) - with the new
approach, they match more closely (16 vs 15). This may be a negative,
but is still much better than the starvation which is seen with glFlush (5
vs 15).
Improvements:
Telemetry smoothness.top_25_smooth: This change produces good
improvements in first_gesture_scroll_update_latency,
mean_input_event_latency, and mean_main_thread_scroll_latency,
without any significant regressions. See:
https://drive.google.com/file/d/0B2nwXDxTDpGGU215X2xYTE9Bdnc/view?usp=sharing
Animometer Benchmark: This change produces good improvements in a
number of animometer benchmarks. See:
https://docs.google.com/spreadsheets/d/1qK6LfDVMKydbKfkGEi1DuGoSqY2wPJAjPiAL1CCUW-4/edit?usp=sharing
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2028303002
Cr-Commit-Position: refs/heads/master@{#397738}
(cherry picked from commit 54e8e3975826ceb886a7e0d8ec07bb38b1192311)
BUG=
Review URL: https://codereview.chromium.org/2063513002 .
Cr-Commit-Position: refs/branch-heads/2743@{#320}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Record start up latency of DOM distiller viewer
BUG=617701
Review-Url: https://codereview.chromium.org/2011213002
Cr-Commit-Position: refs/heads/master@{#398115}
(cherry picked from commit b744ad3dc31c3d441687e9b99fac3eee22e90e32)
Review URL: https://codereview.chromium.org/2060583002 .
Cr-Commit-Position: refs/branch-heads/2743@{#319}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Log some information about the state of the homepage on Android.
BUG=612653
Review URL: https://codereview.chromium.org/2054983004 .
Review-Url: https://codereview.chromium.org/2006023002
Cr-Original-Commit-Position: refs/heads/master@{#397046}
Cr-Commit-Position: refs/branch-heads/2743@{#318}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Check for empty panel state in animations
This change reverts the boolean added checking if an animation
had been added and checks for a null panel state. It is
suspected that this is the result of some animation not directly
related to panel state finishing before the panel is assigned a
state.
BUG=616898, 616856, 614905, 613945
Review-Url: https://codereview.chromium.org/2037523004
Cr-Commit-Position: refs/heads/master@{#399064}
(cherry picked from commit 5dd38cf3f903058eacb5bd5629ce2c6e3801fd75)
Review URL: https://codereview.chromium.org/2056363002 .
Cr-Commit-Position: refs/branch-heads/2743@{#317}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Added missing pen tilt when creating PointerEvent from ME.
Added back the missing plumbing. Also added EventSender support to pass stylus
info for testing.
BUG=593850
Review-Url: https://codereview.chromium.org/2043053002
Cr-Commit-Position: refs/heads/master@{#398933}
(cherry picked from commit abca6ff6e9ffb9791242701d4499e0144ed94283)
Review URL: https://codereview.chromium.org/2054123002 .
Cr-Commit-Position: refs/branch-heads/2743@{#316}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to M52] [Retry] Fix the browser crash when changing wallpaper with chrome.wallpaper API.
The original CL https://codereview.chromium.org/1986583002/ was reverted in
https://codereview.chromium.org/1984953005/ because of memory leak detected in
the test function getThumbnailAferSetWallpaper().
BUG=608895
[email protected]
Review-Url: https://codereview.chromium.org/1989653002
Cr-Commit-Position: refs/heads/master@{#396411}
(cherry picked from commit fffb22c1b808e247ce67cb35793b57ddb35bf1d0)
Review URL: https://codereview.chromium.org/2058833002 .
Cr-Commit-Position: refs/branch-heads/2743@{#315}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Android, Settings] Fix NPE when both media related site settings are enabled
Only look for AUTOPLAY preference if it's the only one enabled.
BUG=618439
TEST=manual
Review-Url: https://codereview.chromium.org/2052613002
Cr-Commit-Position: refs/heads/master@{#398908}
(cherry picked from commit bf6c1f850a7b75b5992d3f99d7a8b3d8f0488b24)
Review URL: https://codereview.chromium.org/2057143002 .
Cr-Commit-Position: refs/branch-heads/2743@{#314}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[merge-m52] Mac: Retain the child NSWindow in WidgetOwnerNSWindowAdapter before invoking close
AppKit has gotten better at handling the last reference to an NSWindow
going away inside -[NSWindow close]. However, on 10.9, bad things can
happen if we don't retain the NSWindow being closed until after the
-[NSWindow close] call returns.
WidgetOwnerNSWindowAdapter::OnWindowWillClose() wasn't doing this. The
result: in some codepaths, a zombie access under the close call.
To fix, retain the window being closed.
BUG=616701
TEST=On OSX 10.9, have one browser tab, navigate to a page (e.g.
chrome://version), then press Backspace. The "Press Cmd+Left to go back"
bubble should appear. Wait for it to fade out completely. Then close the
tab via the tabstrip. Chrome shouldn't crash.
Review-Url: https://codereview.chromium.org/2056593002
Cr-Commit-Position: refs/heads/master@{#398890}
(cherry picked from commit 6777bcc56aff3a1dc27fb0adced9a462b22e4e33)
Review URL: https://codereview.chromium.org/2056273002 .
Cr-Commit-Position: refs/branch-heads/2743@{#313}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Do not update, and return the previous matrix if surface_texture_ is null.
surface_texture_ should only be null during stub destruction; returning
the previous matrix will allow the last frame to be redrawn correctly.
BUG=614224
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2016643002
Cr-Commit-Position: refs/heads/master@{#396442}
(cherry picked from commit 42b137d8600104c1853de10626f6ef1e15e972ab)
Review URL: https://codereview.chromium.org/2058613003 .
Cr-Commit-Position: refs/branch-heads/2743@{#312}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix race when HTMLMediaElement.play() is called just after pause().
The consequence is that the Promise returned by play() is rejected by
the task created by pause(). The fix is to associate the tasks with a
list of promises.
BUG=593273
[email protected]
Review-Url: https://codereview.chromium.org/1865933002
Cr-Commit-Position: refs/heads/master@{#398370}
(cherry picked from commit 3a82d82079ca79cddd932eb77f924db5428885b9)
Review URL: https://codereview.chromium.org/2053333002 .
Cr-Commit-Position: refs/branch-heads/2743@{#311}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Default the PacHttpsUrlStrippingEnabled policy to False for Chrome OS enterprise users.
(The plan is to control rollout from the server side, out of concern over compatibility.)
BUG=616396
Review-Url: https://codereview.chromium.org/2036983004
Cr-Commit-Position: refs/heads/master@{#398797}
(cherry picked from commit 20733647674a30aca99305ebfcfbabc16a8ef958)
Review URL: https://codereview.chromium.org/2059673002 .
Cr-Commit-Position: refs/branch-heads/2743@{#310}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add a policy for disabling the stripping of PAC URLs.
The default is to strip https:// URLs before submitting them to PAC scripts.
This CL introduces the policy "PacHttpsUrlStrippingEnabled" for disabling this security feature.
Setting the policy to "false" causes Chrome to no longer strip https:// URLs before sending them to PAC scripts. This applies to all profiles, and all PAC scripts (including those discovered through WPAD, and those delivered over an insecure transport).
The intent of this policy is to help enterprises with a compatibility problem transition.
BUG=616396
[email protected]
Review-Url: https://codereview.chromium.org/2030193004
Cr-Commit-Position: refs/heads/master@{#397808}
(cherry picked from commit 9f7ea64cf573101c01ddcf020b87c63089038834)
Review URL: https://codereview.chromium.org/2059513003 .
Cr-Commit-Position: refs/branch-heads/2743@{#309}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Sanitize https:// URLs before sending them to PAC scripts.
This additionally strips the path and query components for https:// URL (embedded identity and reference fragment were already being stripped).
For debugging purposes this behavior can be disabled with the command line flag --unsafe-pac-url.
BUG=593759
[email protected]
Review URL: https://codereview.chromium.org/1996773002 .
Cr-Commit-Position: refs/heads/master@{#395266}
(cherry picked from commit 81357b39c643fc746517fd6ce5cb2076b7ddc3f4)
Review URL: https://codereview.chromium.org/2058683002 .
Cr-Commit-Position: refs/branch-heads/2743@{#308}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "UseCounter: Count form submission in orphan tree." to M52
BUG=618526
[email protected]
Review-Url: https://codereview.chromium.org/2050973002
Cr-Commit-Position: refs/heads/master@{#398796}
(cherry picked from commit 762e6b648bd89034b9b611f40346644487378ad7)
Review URL: https://codereview.chromium.org/2057013002 .
Cr-Commit-Position: refs/branch-heads/2743@{#307}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Decrease SAML webview with camera timeout to 90 seconds
The hard timeout for the SAML flow having an active camera capture is
now 90 seconds.
BUG=616756
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2033113002
Cr-Commit-Position: refs/heads/master@{#397544}
(cherry picked from commit bde2dd5a2bc77e83cf1bb0447d2980d9edec495d)
Review URL: https://codereview.chromium.org/2057893002 .
Cr-Commit-Position: refs/branch-heads/2743@{#306}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.36
Cr-Commit-Position: refs/branch-heads/2743@{#305}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[DevTools] Attach all ServiceWorkers that match the origin.
BUG=613072,543104
Review-Url: https://codereview.chromium.org/2000563002
Cr-Commit-Position: refs/heads/master@{#395085}
(cherry picked from commit f4215d06fb2c4f27e3ba81a7089c4816ecc8dab1)
Review URL: https://codereview.chromium.org/2056953002 .
Cr-Commit-Position: refs/branch-heads/2743@{#304}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[DurableStorage] Enable origin trial on workers
BUG=617232
Review-Url: https://codereview.chromium.org/2036103003
Cr-Commit-Position: refs/heads/master@{#398507}
(cherry picked from commit dbbd7185733554086e32d8a24349898816e28157)
Review URL: https://codereview.chromium.org/2053943002 .
Cr-Commit-Position: refs/branch-heads/2743@{#303}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
We did not set the pointer type for WebMouseEvent, which is created from NSEvent in WebMouseEventBuilder::Build. Now we set the pointer type based on the NSEvent's type to see if it is a tablet event or subtype of a mouse event to see its input device.
Reference:
https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/EventOverview/EventObjectsTypes/EventObjectsTypes.html#//apple_ref/doc/uid/10000060i-CH4-SW4
BUG=615122
Review-Url: https://codereview.chromium.org/2022843002
Cr-Commit-Position: refs/heads/master@{#398635}
(cherry picked from commit 74a646d254f3836d7df802857b5a926adc4ec87b)
Review URL: https://codereview.chromium.org/2056053002 .
Cr-Commit-Position: refs/branch-heads/2743@{#302}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use monotonic time to record the touch input latency in Blink.
Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime
instead of currentTime to record the touch event latency in Blink.
BUG=617984
Review-Url: https://codereview.chromium.org/2044923004
Cr-Commit-Position: refs/heads/master@{#398712}
(cherry picked from commit c5707d4d2131cf90f2fe8c9887a1c95c83a12812)
Review URL: https://codereview.chromium.org/2059523002 .
Cr-Commit-Position: refs/branch-heads/2743@{#301}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52] Component updater for FileTypePolicies.
BUG=596555
Review-Url: https://codereview.chromium.org/1986403002
Cr-Commit-Position: refs/heads/master@{#396542}
(cherry picked from commit 070d6316bbea3e3ed648c84648391c47439e2c9c)
Review URL: https://codereview.chromium.org/2051213002 .
Cr-Commit-Position: refs/branch-heads/2743@{#300}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Fix MD bookmarks button focus ring regression.
After the Material Design changes to the bookmarks bar the focus rings
no longer align with the button images.
[email protected]
BUG=613124
Review-Url: https://codereview.chromium.org/2030233003
Cr-Commit-Position: refs/heads/master@{#397598}
(cherry picked from commit b8e8a8f7a7fc3f66e0bc149602d8abac251b0304)
Review URL: https://codereview.chromium.org/2051973002 .
Cr-Commit-Position: refs/branch-heads/2743@{#299}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.
After this CL, blink::FrameTree::m_uniqueName is guaranteed to be truly
unique (within a given frame tree) except when:
- The frame tree temporarily contains both an old and a new provisional frame.
- The frame tree spans multiple renderer processes, which race to assign
the same name to different frames (https://crbug.com/558680#c14).
BUG=588800
Review-Url: https://codereview.chromium.org/1968213002
Cr-Commit-Position: refs/heads/master@{#397443}
(cherry picked from commit 201638819dd4aa0c3b18bf3fe64c3a8a6256c44c)
Review URL: https://codereview.chromium.org/2051963002 .
Cr-Commit-Position: refs/branch-heads/2743@{#298}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable FLAGS_quic_only_one_sending_alarm, since it breaks QUIC time
loss detection.
[email protected],[email protected]
BUG=618048
Original CL that was reviewed and landed in Canary:
https://codereview.chromium.org/2032343003/
Merged CL: https://codereview.chromium.org/2037893005
Review URL: https://codereview.chromium.org/2050463005 .
Cr-Commit-Position: refs/branch-heads/2743@{#297}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
cc: Clear always_use_active_tree_opacity_effect_ids
When we rebuild property trees.
BUG=617826
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2044803002
Cr-Commit-Position: refs/heads/master@{#398344}
(cherry picked from commit 8013559b9c20153c8ed18f24179841025c6587f6)
Review URL: https://codereview.chromium.org/2050623006 .
Cr-Commit-Position: refs/branch-heads/2743@{#296}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Add a policy to enable/disable Media Router.
- Add policy "EnableMediaRouter". The default (if not set) will be to
enable Media Router.
-- EnableMediaRouter will be a user level policy that affects Chrome,
Chrome OS, and Android.
-- Mandatory policy.
- Add logic in media_router::MediaRouterEnabled() to check if the
corresponding preference is set from a mandatory policy. If so, return
that value. Otherwise, check the existing FeatureSwitch (or return true
on Android). If not set, or if not set from mandatory policy, then the
preference is ignored.
- Reordered the logic in the function to share common logic between
desktop and Android.
BUG=558453
Review-Url: https://codereview.chromium.org/2035903002
Cr-Commit-Position: refs/heads/master@{#398377}
(cherry picked from commit c2b6c183b1817720f946b3c6378e3479d9083722)
Review URL: https://codereview.chromium.org/2048123003 .
Cr-Commit-Position: refs/branch-heads/2743@{#295}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "kiosk: Enable required_platform_version key on stable"
> BUG=618377
>
> Review-Url: https://codereview.chromium.org/2048433004
> Cr-Commit-Position: refs/heads/master@{#398715}
> (cherry picked from commit f1c093508327909789e7f4ef322a9c391fadf93a)
Review URL: https://codereview.chromium.org/2057673002 .
Cr-Commit-Position: refs/branch-heads/2743@{#294}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media, Autoplay] Add UMA to record autoplay source
This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.
BUG=617948
Review-Url: https://codereview.chromium.org/2044373002
Cr-Commit-Position: refs/heads/master@{#398855}
(cherry picked from commit b69344ad79fc2e36f8eea0e8f0fad3905395cb48)
Review URL: https://codereview.chromium.org/2056743002 .
Cr-Commit-Position: refs/branch-heads/2743@{#293}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix chrome://snippets-internals crashing in incognito mode.
NTPSnippetsService cannot be created in incognito. This was not
previously reflected. The CL makes the internals page not exist in
incognito (chrome shows the standard "This site can't be reached" error
page).
BUG=617796
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2042273002
Cr-Commit-Position: refs/heads/master@{#398817}
(cherry picked from commit dca471a13943862a41ac51e9561ea734b02ce8d8)
Review-Url: https://codereview.chromium.org/2048373002
Cr-Commit-Position: refs/branch-heads/2743@{#292}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M-52] Verify PPAPI initiated downloads against SafeBrowsing.
PPAPI support for saving a file locally doesn't lend itself easily to
integrating with the Chromium DownloadManager. Hence, it also doesn't
integrate well with SafeBrowsing.
This patch introduces a new SafeBrowsing server ping based on the source
information available at PPAPI download initiation. It also removes the
server-side experiment which controlled the types of files that can be
downloaded via PPAPI.
BUG=533579
Review-Url: https://codereview.chromium.org/1846783002
Cr-Commit-Position: refs/heads/master@{#395088}
(cherry picked from commit ef1f387247a7d243157d2dd576cce10c16cf09ad)
Review URL: https://codereview.chromium.org/2045183003 .
Cr-Commit-Position: refs/branch-heads/2743@{#291}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
AVDACodecImages keep their backing SurfaceTexture alive
Previously, when destructing an AVDA, we had to delete the
AVDACodecImages attached to the PictureBuffer textures, and
use a fragile method of copying the SurfaceTexture buffer
and creating egl images to make sure those PictureBuffer
textures didn't become unbacked.
Now the AVDACodecImages are kept alive by the Textures
they're bound to, and they keep a ref to AVDASharedState
which contains the shared SurfaceTexture and its platform
texture. The AVDASharedState destructor cleans up the
SurfaceTexture and deletes the platform texture.
BUG=533630,614090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2005103004
Cr-Commit-Position: refs/heads/master@{#398293}
(cherry picked from commit 3e465933721f2732fc422029529b80fc9784e812)
Review URL: https://codereview.chromium.org/2049053004 .
Cr-Commit-Position: refs/branch-heads/2743@{#290}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.35
Cr-Commit-Position: refs/branch-heads/2743@{#289}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "SELECT popup: Fix a crash by DOM mutation during opening popup." to M52 branch.
A mutation callback can be called after MutationObserver is disconnected
because MutationRecords are queued.
BUG=617578
Review-Url: https://codereview.chromium.org/2040123002
Cr-Commit-Position: refs/heads/master@{#398244}
(cherry picked from commit 6d47f4e6911287f41bbad2f1456b19bc59b8d6fe)
Review URL: https://codereview.chromium.org/2050923002 .
Cr-Commit-Position: refs/branch-heads/2743@{#288}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
media: Remove code from AVDA and friends for detaching the SurfaceTexture
We recently made a change to always attach the SurfaceTexture when it's
created and to never detach it (https://codereview.chromium.org/1992253004)
This change cleans up code that we no longer need after that change.
BUG=602840
Review-Url: https://codereview.chromium.org/2009063002
Cr-Commit-Position: refs/heads/master@{#395979}
(cherry picked from commit ef9697eeaae95b2760468e363a58dcfb8daa9333)
Review URL: https://codereview.chromium.org/2050463004 .
Cr-Commit-Position: refs/branch-heads/2743@{#287}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
StreamTextureImages can now override a Texture's service id
Previously Textures could have an unowned service id, which is used in
place of their service id, except that its lifetime is managed
externally. The use case this is AVDACodecImages, which use a single
SurfaceTexture to back multiple Textures.
This change more explicitly ties the unowned service id concept to
StreamTextureImages, and makes it possible to have StreamTextureImages
own the lifetime of the unowned service id (now called the stream
texture service id), by resetting the service id back to its original
value if a non-StreamTextureImage is bound. If this were not done and a
new image was bound to a level that previously had a
StreamTextureImage, the service id would still be the unowned stream
texture service id, but the StreamTextureImage would be deleted. That
meant it was previously not possible for StreamTextureImages to own the
lifetime of the unowned service id without possibly leaving the
Texture in an invalid state.
Now we can have multiple AVDACodecImages, bound to different Textures,
share a SurfaceTexture service id and safely delete the texture when all
of the AVDACodecImages are destructed.
This CL also adds Texture::SetLevelImageState for setting only the
ImageState and not changing the bound image.
BUG=614090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2014313002
Cr-Commit-Position: refs/heads/master@{#397897}
(cherry picked from commit e8d35a561423eb3e4520b0ae1fe5a945a62c70af)
Review URL: https://codereview.chromium.org/2051633002 .
Cr-Commit-Position: refs/branch-heads/2743@{#286}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDeviceStopped() may delete the same element twice from |label_stream_map_| and causes the crash.
BUG=616884
[email protected]
Review-Url: https://codereview.chromium.org/2035993002
Cr-Commit-Position: refs/heads/master@{#398075}
(cherry picked from commit c4ef1a4e478937783c303b8a712e9fef0457ac60)
Review URL: https://codereview.chromium.org/2049293002 .
Cr-Commit-Position: refs/branch-heads/2743@{#285}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add CHECKs on Windows to ExtensionWebRequestEventRouter::RemoveEventListener
BUG=589735
Review-Url: https://codereview.chromium.org/2002953002
Cr-Commit-Position: refs/heads/master@{#395324}
(cherry picked from commit 681fce4a25952d4d43128ff62db4d06f51bd938a)
Review URL: https://codereview.chromium.org/2049913002 .
Cr-Commit-Position: refs/branch-heads/2743@{#284}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fixes ASan crash for an embedded Blink-in-JS component.
In the test case (in this patch) it appears the Blink-in-JS component tries to run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script execution is forbidden." (probably because it is being created in this weird place?)
This patch re-adds the simple check that was removed in https://codereview.chromium.org/1885833002 which checked if the toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).
BUG=617104
Review-Url: https://codereview.chromium.org/2039333002
Cr-Commit-Position: refs/heads/master@{#398310}
(cherry picked from commit 2deeee5b5604eb997fa053a1b6ab4268c662596f)
Review URL: https://codereview.chromium.org/2049163003 .
Cr-Commit-Position: refs/branch-heads/2743@{#283}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Material][Mac] Adjustments to the Omnibox decorations
BUG=613788,611113
Review-Url: https://codereview.chromium.org/2002103003
Cr-Commit-Position: refs/heads/master@{#397734}
(cherry picked from commit 7de0ca5b7f66e36c74df676b9c0fbe2dc10364dd)
Review URL: https://codereview.chromium.org/2050623004 .
Cr-Commit-Position: refs/branch-heads/2743@{#282}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Handle precache GCM task scheduling failures
GCMNetworkManager schedule/cancel task calls can fail if
ChromeBackgroundService has not registered as GcmTaskService yet.
Handle these failures gracefully. Later these failures should be
tracked via UMA.
BUG=605384
Review-Url: https://codereview.chromium.org/1958923002
Cr-Commit-Position: refs/heads/master@{#395531}
(cherry picked from commit 8be4fb8042f369d4dcfbdcad307792dea115bd02)
Review URL: https://codereview.chromium.org/2044303003 .
Cr-Commit-Position: refs/branch-heads/2743@{#281}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to M52] AppCache: Check whether AppCacheStorageImpl is enabled before calling disk_cache()
BUG=617200
Review-Url: https://codereview.chromium.org/2040833002
Cr-Commit-Position: refs/heads/master@{#397989}
(cherry picked from commit 9a7f903e95b9ff3b16dc18b8ab6d6eaa4f1a987d)
Review URL: https://codereview.chromium.org/2045043003 .
Cr-Commit-Position: refs/branch-heads/2743@{#280}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
We hard coded the pointer type as mouse in ui::GetMousePointerDetailsFromNative for events sending from Windows. Now we use a mouse message from GetMessageExtraInfo to decide the actual input device type.
GetMessageExtraInfo needs to be mask-checked against 0xFFFFFF00, and then compared
with 0xFF515700. True when this mouse message was generated by a Tablet PC pen or touch
screen. Otherwise it is from a mouse device. Additionally, in Windows Vista or later,
the eighth bit, masked by 0x80, is used to differentiate
touch input from pen input
(0 = pen, 1 = touch).
Reference:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms703320(v=vs.85).aspx
BUG=614820
Review-Url: https://codereview.chromium.org/2020143003
Cr-Commit-Position: refs/heads/master@{#398025}
(cherry picked from commit 16ac979eddbdd5ccc045092c1260e42dd38191f6)
Review URL: https://codereview.chromium.org/2039813006 .
Cr-Commit-Position: refs/branch-heads/2743@{#279}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Listen for sync status change to update sync error icon in SigninPreference
BUG=617874
Review-Url: https://codereview.chromium.org/2047863002
Cr-Commit-Position: refs/heads/master@{#398544}
(cherry picked from commit 58a7f39e35e6edd3267b491ee8aed3f26323bc77)
Review URL: https://codereview.chromium.org/2052483002 .
Cr-Commit-Position: refs/branch-heads/2743@{#278}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Android backup] Sync settings, and new to old version restore
Backup and restore the sync settings. Also enable restore to an
older version of Chrome than the backed up version.
BUG=616477
BUG=613205
Review-Url: https://codereview.chromium.org/2047473003
Cr-Commit-Position: refs/heads/master@{#398267}
(cherry picked from commit afa2077192b4c38c3f828c29628c54f0339f3534)
Review URL: https://codereview.chromium.org/2043303002 .
Cr-Commit-Position: refs/branch-heads/2743@{#277}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Fix strange Apps button highlight in dark themes.
The button needs to be set to not show highlighting.
[email protected]
BUG=616406
Review-Url: https://codereview.chromium.org/2031023002
Cr-Commit-Position: refs/heads/master@{#397502}
(cherry picked from commit f9cb6c37c2528abe53a22ef943e61764a1de9181)
Review URL: https://codereview.chromium.org/2044923005 .
Cr-Commit-Position: refs/branch-heads/2743@{#276}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Loader] Add asserts about revalidation and redirects
After https://codereview.chromium.org/2011283002/ and
https://codereview.chromium.org/2017883002/, redirect chain must be empty
when revalidation starts or during revalidation is ongoing.
This CL adds asserts to verify that.
BUG=613971, 614989
Review-Url: https://codereview.chromium.org/2020253002
Cr-Commit-Position: refs/heads/master@{#397683}
(cherry picked from commit d0753f72046d160bc34584a47eb3f3a3c56daff1)
Review URL: https://codereview.chromium.org/2046923002 .
Cr-Commit-Position: refs/branch-heads/2743@{#275}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.34
Cr-Commit-Position: refs/branch-heads/2743@{#274}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[M52] Fix android test compile
For https://codereview.chromium.org/2047673002/ x2
BUG=613147
Review URL: https://codereview.chromium.org/2043233002 .
Cr-Commit-Position: refs/branch-heads/2743@{#273}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[M52] Android build fix
For https://codereview.chromium.org/2047673002/
BUG=613147
Review URL: https://codereview.chromium.org/2043223002 .
Cr-Commit-Position: refs/branch-heads/2743@{#272}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.33
Cr-Commit-Position: refs/branch-heads/2743@{#271}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to M52: Fix a bug with the Chrome legacy window at times becoming a top level window with a non functional button in the taskbar.
This bug typically occurs if the legacy window stays around after it is
removed from the original root window.
It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.
Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.
BUG=616410
Review-Url: https://codereview.chromium.org/2031213002
Cr-Commit-Position: refs/heads/master@{#397790}
(cherry picked from commit b35c046639c244df4a954a791e24cfe7d5270daa)
Review URL: https://codereview.chromium.org/2040333002 .
Cr-Commit-Position: refs/branch-heads/2743@{#270}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Show DataUse UI only on non-roaming cellular connections
BUG=574525
Review-Url: https://codereview.chromium.org/2006803005
Cr-Commit-Position: refs/heads/master@{#396080}
(cherry picked from commit ad6c59ad6e37a6165d580680a4333446ba4ac43c)
Review URL: https://codereview.chromium.org/2045913003 .
Cr-Commit-Position: refs/branch-heads/2743@{#269}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Support for back-forward navigations in DataUseTabModel
Current behavior is that data usage tracking state does not change for
back-forward navigations. Instead data usage tracking should take the
same matching rule label as the initial navigation, for back-forward
navigations.
BUG=611595
Review-Url: https://codereview.chromium.org/1987303002
Cr-Commit-Position: refs/heads/master@{#396033}
(cherry picked from commit 314d5910b4af2ff0913ddedc4bebf6ad2d10988b)
Review URL: https://codereview.chromium.org/2044223003 .
Cr-Commit-Position: refs/branch-heads/2743@{#268}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Allow about:blank to be considered in-page if origin matches.
This is necessary in cases that document.write changes the effective
URL of the about:blank page, and then the user goes back.
BUG=446959
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2032903007
Cr-Commit-Position: refs/heads/master@{#398168}
(cherry picked from commit f164daa4f2973cba2f0654d3715e47638a8de920)
Review URL: https://codereview.chromium.org/2039233004 .
Cr-Commit-Position: refs/branch-heads/2743@{#267}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
WebAudio: record whether user gesture was available and provided.
We are looking into a more consistent audio playback on mobile and want
to see whether implementing Safari iOS behaviour in Chrome Android would
break websites.
BUG=616807
Review-Url: https://codereview.chromium.org/2031393003
Cr-Commit-Position: refs/heads/master@{#398061}
(cherry picked from commit 9eeee90e6f8d52fce0b3645f933796abc13fe891)
Review URL: https://codereview.chromium.org/2046933003 .
Cr-Commit-Position: refs/branch-heads/2743@{#266}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[css-flexbox] logical widths are always definite.
Per guidance from the CSS working group we should always treat widths
as definite, which allows us to simplify & speed up some code in
Flexbox.
See also https://lists.w3.org/Archives/Public/www-style/2016May/0135.html
which I believe covers all the cases where they might not be (=shrinkwrapping).
Because this means that for widths we always use the actual width of the
element for percentage calculations, we can remove some code from LayoutBox too.
BUG=595361
Review-Url: https://codereview.chromium.org/2022553002
Cr-Commit-Position: refs/heads/master@{#396584}
(cherry picked from commit 237e6796e049700ccb7adf105d3f95ba9572e66c)
Review URL: https://codereview.chromium.org/2047743002 .
Cr-Commit-Position: refs/branch-heads/2743@{#265}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52] Never detach SurfaceTexture from the GL context for AVDA.
This is a merge of https://codereview.chromium.org/1992253004 .
It seems to crash more than it helps. Since most devices use virtual
GL contexts anyway, for which detach has no benefit, just turn it off
entirely. At worst, it's an extra context switch. If we find
devices which don't use virtual contexts and on which we can detach
safely, we might whitelist them.
BUG=602840
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOPRESUBMIT=true
NOTRY=true
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2041393002
Cr-Commit-Position: refs/branch-heads/2743@{#264}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "Fix webview crash on attempt to scroll."
> This fixes crash of webview when its content is scrolled using
> 2-fingers gesture via touchpad or using touchscreen.
>
> BUG=615512
> TEST=Manually on device using Arc++ OptIn UI, ToS is scrolled
> as expected using touchscreen or touchpad, no crashes.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2015373002
> Cr-Commit-Position: refs/heads/master@{#397901}
> (cherry picked from commit d92694016e4cc9f7812894aa60eb4d36de6cd381)
Review URL: https://codereview.chromium.org/2046843003 .
Cr-Commit-Position: refs/branch-heads/2743@{#263}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[M52] Avoid glEGLImageTargetTexture2DOES on Mali-400 on Android.
This is a merge of https://codereview.chromium.org/1992953002
AVDA uses glEGLImageTargetTexture2DOES to copy images out of the
SurfaceTexture before teardown. However, this seems to crash on
devices with a Mal-400 gpu running lollipop. It was already skipped
on <= KitKat due to the SurfaceTexture::Detach workaround.
This Cl removes the dependence on the Detach workaround, and adds one
for all Mali-400 devices on all versions of android.
BUG=610516
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOPRESUBMIT=true
NOTRY=true
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/2044473004
Cr-Commit-Position: refs/branch-heads/2743@{#262}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Prevent renderer kills for in-page navigations on subframes.
This switches HistoryController and HistoryEntry to look at the last
committed WebHistoryItem for a frame rather than assuming that the
whole HistoryEntry accurately reflects the state of the page. The
previous logic led to NC_IN_PAGE_NAVIGATION renderer kills when going
back cross-site in ways that looked in-page to the HistoryEntry.
This CL does not yet fix the kills that happen in FrameNavigationEntry
modes, which are covered by the BackTwiceToIframeWithContent test.
Those will be fixed in a follow-up CL.
BUG=612713
TEST=Fewer NC_IN_PAGE_NAVIGATION kills.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2023013002
Cr-Commit-Position: refs/heads/master@{#397832}
(cherry picked from commit 225a74338e488576c405e18610298c39244b85f5)
Review URL: https://codereview.chromium.org/2044913002 .
Cr-Commit-Position: refs/branch-heads/2743@{#261}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Android backup] Restore nothing if signed in user isn't valid
If the user was previously not signed in, or if the account doesn't
exist on the new device, then restore nothing.
BUG=613147
Review-Url: https://codereview.chromium.org/1990233002
Cr-Commit-Position: refs/heads/master@{#397135}
(cherry picked from commit 074761b1a1d52efdccd1188841a821fb91249d9e)
Review URL: https://codereview.chromium.org/2047673002 .
Cr-Commit-Position: refs/branch-heads/2743@{#260}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Reland to M-52: Make revalidation to fail when received a redirect response
In addition to the original CL [1], this CL de-Oilpanize DummyClient because
DummyClient is on-heap in M-53 due to [2] but not in M-52.
[1] https://codereview.chromium.org/2017883002
[2] https://codereview.chromium.org/1998073002
BUG=614989
Review-Url: https://codereview.chromium.org/2017883002
Cr-Commit-Position: refs/heads/master@{#397650}
(cherry picked from commit a9531777113bf6e6ea527c1ec34bbb65a128b560)
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/2041723004 .
Cr-Commit-Position: refs/branch-heads/2743@{#259}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Fetch API] Cancel loading when the worker is terminating.
BodyStream assumes controller() returns a non-null pointer as long as
|m_reader| is non-null. But that assumption will break if the constructor
exits early when the worker is terminating. This CL clears |m_reader| in
such a case to keep the assumption.
BUG=616985
Review-Url: https://codereview.chromium.org/2036963002
Cr-Commit-Position: refs/heads/master@{#397965}
(cherry picked from commit 0640dc61545fee051b47174b7c45e0d8928509b9)
Review URL: https://codereview.chromium.org/2045893002 .
Cr-Commit-Position: refs/branch-heads/2743@{#258}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Allow transitions on background-size with positionally matched keywords
This change allows CSS transitions to interpolate between lists with
matching keywords.
This affects interpolation for the following properties:
- border-image-width
This property is not animatable according to spec:
https://drafts.csswg.org/css-backgrounds-3/#the-border-image-width
- background-size
Values are now interpolable if their keywords are positionally matched:
https://github.com/w3c/csswg-drafts/commit/a5f9de921fa7834c79ee15660d9d86528bce1607
- -webkit-background-size
- -webkit-mask-size
These mirror the animation behaviour of background-size.
This change only affects CSS Transitions for the sake of a small mergable patch.
CSS Animations behaviour will be brought in line in a separate patch.
This change ensures we have compatible behaviour with other browsers for
transitioning between single length background-size values e.g.
"background-size: 50%" to "background-size: 100%"
BUG=616072
Review-Url: https://codereview.chromium.org/2027933002
Cr-Commit-Position: refs/heads/master@{#397661}
(cherry picked from commit 8793a7bac4d2d56e38c8bd406920128e1ceb7a9a)
Review URL: https://codereview.chromium.org/2042993002 .
Cr-Commit-Position: refs/branch-heads/2743@{#257}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Check node->layoutObject in CaretBase::caretLayoutObject
In CaretBase::caretLayoutObject(Node* node),
if caretRendersInsideNode(node) calls HTMLMeterElement::canContainRangeEndPoint,
it updates the layout tree. It means LayoutObject for the METER can be deleted.
This is bad design. We should make caret painting algorithm clean.
BUG=608817
Review-Url: https://codereview.chromium.org/1972523002
Cr-Commit-Position: refs/heads/master@{#395822}
(cherry picked from commit e4edfb63d1b068c5ab5dc6b91edf75c108ebc433)
Review URL: https://codereview.chromium.org/2042153002 .
Cr-Commit-Position: refs/branch-heads/2743@{#256}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge M52: "Don't reset the codec state for a flush; this kills the frames."
Causing a reset after flush completes will invalidate all the
vended frames, don't do this. Instead only reset when a reset
should actually occur.
Instead, since this reset is required on JellyBean devices, we
issue the reset upon receipt of the next Decode() call. This
allows the more frequent EOS cases to not trash the last frame
on these devices will config changes will work as before.
A followup CL will move the texture matrix to the shared state
so that we don't accidentally apply the wrong matrix after the
reset case.
BUG=613608
TEST=no more random blue frames.
Review-Url: https://codereview.chromium.org/2000833003
Cr-Commit-Position: refs/heads/master@{#395995}
(cherry picked from commit eb4a8d89c1c1c3ed4b74e2afdee7ccd8dd6558bc)
Review URL: https://codereview.chromium.org/2044773002 .
Cr-Commit-Position: refs/branch-heads/2743@{#255}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Fix regression allowing chevron button dragging.
A recent regression left the bookmarks bar's chevron button draggable
when it should not be.
[email protected]
BUG=616412
Review-Url: https://codereview.chromium.org/2035843003
Cr-Commit-Position: refs/heads/master@{#397522}
(cherry picked from commit 29e90b8c7137c5e83a021a8453de434fc5968255)
Review URL: https://codereview.chromium.org/2046853002 .
Cr-Commit-Position: refs/branch-heads/2743@{#254}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
