Publish DEPS for Chromium 52.0.2743.32
Incrementing VERSION to 52.0.2743.32
Cr-Commit-Position: refs/branch-heads/2743@{#253}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use WeakPtrFactory in net::BidirectionalStream when posting task
This CL uses WeakPtrFactory to post task in
net::BidirectionalStream.
BUG=606394
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2043863002
Cr-Commit-Position: refs/heads/master@{#398132}
(cherry picked from commit 3b6ac70b2c8b7085bade85f46577677a45732005)
Review-Url: https://codereview.chromium.org/2041153002
Cr-Commit-Position: refs/branch-heads/2743@{#252}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to 2743] Exit immediately on failure to allocate SharedMemory.
Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The existence of the FastShutdown path means that any
message might fail. Either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.
BUG=615121
Review-Url: https://codereview.chromium.org/2028833003
Cr-Commit-Position: refs/heads/master@{#397496}
(cherry picked from commit 7eb3f7fe5233455626980c3517f7fa189e6c9675)
Review URL: https://codereview.chromium.org/2045713002 .
Cr-Commit-Position: refs/branch-heads/2743@{#251}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
The previous CL was built around a test case I had made myself (there was no real life example). I found one and realized the type should be "text" and not "input".
Related CL: https://codereview.chromium.org/2025063002/
BUG=616174
TEST=AutofillFieldTest
Review-Url: https://codereview.chromium.org/2041863003
Cr-Commit-Position: refs/heads/master@{#398073}
(cherry picked from commit 0f28ddfb76aff4a18095e19421f6bc1eb3975f0d)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2044653002
Cr-Commit-Position: refs/branch-heads/2743@{#250}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Enable RTCVideoDecoder SW H264 fallback only when it is available
Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.
BUG=615513
Review-Url: https://codereview.chromium.org/2024303003
Cr-Commit-Position: refs/heads/master@{#397856}
(cherry picked from commit 177cc1d1d66346ea9e2e85ecb3d6812e13b11907)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2044643002
Cr-Commit-Position: refs/branch-heads/2743@{#249}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Surface sync error icon if sync is off may be unintentional
This CL is a strength of https://codereview.chromium.org/1952853005/.
BUG=607695
Review-Url: https://codereview.chromium.org/2032043002
Cr-Commit-Position: refs/heads/master@{#398097}
(cherry picked from commit 93018d6d6d5fc9bd3d54addc498d296187af6423)
Review URL: https://codereview.chromium.org/2041093003 .
Cr-Commit-Position: refs/branch-heads/2743@{#248}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix scrollbar buttons on ChromeOS.
Scrollbar buttons aren't supposed to draw on ChromeOS, so they need to
return a size of 0.
BUG=613668
Review-Url: https://codereview.chromium.org/2006643004
Cr-Commit-Position: refs/heads/master@{#396012}
(cherry picked from commit 57decb6dda19498ceec3b3cbdb9d6c6fd0fed001)
Review URL: https://codereview.chromium.org/2042023002 .
Cr-Commit-Position: refs/branch-heads/2743@{#247}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Autofill] Truncate expiration year based on prediction and max length.
Use the prediction type and max length attribute of the field to determine the number (if any) of character to truncate from the start of the expiration year when filling an input field.
BUG=616174
TEST=AutofillFieldTest
Review-Url: https://codereview.chromium.org/2025063002
Cr-Commit-Position: refs/heads/master@{#396956}
(cherry picked from commit 103c242eb62e46367cc80dfbfa71ebbf4f9cbb10)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2029403003
Cr-Commit-Position: refs/branch-heads/2743@{#246}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of In official builds, let CHECK(false) crash instead of calling BreakDebugger. (patchset #2 id:20001 of https://codereview.chromium.org/1982123002/ )
Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.
BUG=599867,614865
Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
>
> This should save some binary size and make things a bit faster, without ill
> effects.
>
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
>
> BUG=599867
>
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}
[email protected],[email protected]
BUG=599867
Review-Url: https://codereview.chromium.org/2046593002
Cr-Commit-Position: refs/heads/master@{#398084}
(cherry picked from commit 6ff194f572f62ff4989aaadc9af6616eb78b954a)
Review URL: https://codereview.chromium.org/2042003002 .
Cr-Commit-Position: refs/branch-heads/2743@{#245}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to M52]Fill the canvas with black background before painting wallpaper.
Merge this CL to M52 on behalf of xiaoyinh@. This change is to fill the canvas
with black background every time before painting a new wallpaper, so that the
new wallpaper with partial transparency won't be painted upon a previous wallpaper.
BUG=606434
[email protected], [email protected]
Review-Url: https://codereview.chromium.org/1996793002
Cr-Commit-Position: refs/heads/master@{#395175}
(cherry picked from commit 5fb57605dc341abde4f2eace5ec578520b74b224)
Review URL: https://codereview.chromium.org/2039173003 .
Cr-Commit-Position: refs/branch-heads/2743@{#244}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Prevent use of GPU IDC in Resourceless Software Draw
An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.
This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.
BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2035913002
Cr-Commit-Position: refs/heads/master@{#397547}
(cherry picked from commit 2af3e47380eb2a2a4ebb3b22c654b1881c722ccc)
Review URL: https://codereview.chromium.org/2041093002 .
Cr-Commit-Position: refs/branch-heads/2743@{#243}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix history page middle click action
Send synthetic middle click in history page and also
prevent default it as the links in history page will
trigger twice if we don't prevent default it.
BUG=609020
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2018943003
Cr-Commit-Position: refs/heads/master@{#397512}
(cherry picked from commit a154aed1a3813cf28c6f477579ed7974a2528570)
Review URL: https://codereview.chromium.org/2040813003 .
Cr-Commit-Position: refs/branch-heads/2743@{#242}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert "Make revalidation to fail when received a redirect response"
This reverts commit bf790b4bd8a2cffb01176399a937a2f100ffadf1.
Reason: Compile failure in RawResourceTest.cpp
BUG=614989
Review URL: https://codereview.chromium.org/2045623002 .
Cr-Commit-Position: refs/branch-heads/2743@{#241}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Hide media sinks that don't have a name in the cast system tray.
This also hides media sinks that have a domain, as a temporary fix to meet privacy requirements. The logic to decide if a sink with a domain should be displayed will be added later.
BUG=616683
Review-Url: https://codereview.chromium.org/2029963002
Cr-Commit-Position: refs/heads/master@{#397481}
(cherry picked from commit cdf25cc62ff3ba880f03e8869f59ddefdc21c89e)
Review URL: https://codereview.chromium.org/2040003002 .
Cr-Commit-Position: refs/branch-heads/2743@{#240}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
When Chrome app tries to open a camera/mic for the first time on Android, the pop-up runtime permission dialogue will cause activities onStart/Stop events. Chrome will release/resume camera device accordingly. But if activity onStart event comes after we start to open the camera and before we get onDeviceStarted callback, we will wrongly resume the same device which will fail with exception. In this cl, we will check if the resumed device is already in the start queue. Also move one function to public for unittests which can catch the scenario in this BUG.
BUG=615557
TESt=trybots and manual test by doing a apprtc test on a N
device with building later than NRD45.
Review-Url: https://codereview.chromium.org/2029933002
Cr-Commit-Position: refs/heads/master@{#397518}
(cherry picked from commit 42be20041869379e6d9f8138d5e3bf9d231902e6)
Review URL: https://codereview.chromium.org/2039913003 .
Cr-Commit-Position: refs/branch-heads/2743@{#239}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Ignore null events sent from GestureDetector
BUG=613069
Review-Url: https://codereview.chromium.org/2025403002
Cr-Commit-Position: refs/heads/master@{#397596}
(cherry picked from commit 6b47d1f7c8eb12b9eeaea3c562076d5817428f5e)
Review URL: https://codereview.chromium.org/2044503003 .
Cr-Commit-Position: refs/branch-heads/2743@{#238}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Make revalidation to fail when received a redirect response
BUG=614989
Review-Url: https://codereview.chromium.org/2017883002
Cr-Commit-Position: refs/heads/master@{#397650}
(cherry picked from commit a9531777113bf6e6ea527c1ec34bbb65a128b560)
Review URL: https://codereview.chromium.org/2042843002 .
Cr-Commit-Position: refs/branch-heads/2743@{#237}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Do not crash on null stream in writing to bidirectional streams
When SendData/SendvData is called, it might be that OnClose
has been invoked without an error, in which case
BidirectionalStream::Delegate::OnFailed would not have been
invoked. This is theoretically possible, but I am not
aware if such case would exist.
This CL removes the assumption that SendData/SendvData
is only called when stream is alive. If stream is
destroyed, propagate that as an ERR_UNEXPECTED to caller,
instead of crashing with a segfault.
BUG=606394
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2032733002
Cr-Commit-Position: refs/heads/master@{#398031}
(cherry picked from commit 707f895efd414219d609533e82be1ffc60fd9788)
Review-Url: https://codereview.chromium.org/2046613002
Cr-Commit-Position: refs/branch-heads/2743@{#236}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Do not initiate revalidation of Resource with redirects from MemoryCache
BUG=613971
Review-Url: https://codereview.chromium.org/2011283002
Cr-Commit-Position: refs/heads/master@{#397064}
(cherry picked from commit 64ad58e1d8451857f6a763651727c9d39375ea3b)
Review URL: https://codereview.chromium.org/2044483002 .
Cr-Commit-Position: refs/branch-heads/2743@{#235}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Android, RemotePlayback] Make RemotePlayback classes ActiveScriptWrappable's
Keeps the V8 wrappers alive as long as there're event listeners or pending
promises and such.
BUG=616761
TEST=manual, see repro steps in the bug
Review-Url: https://codereview.chromium.org/2038573002
Cr-Commit-Position: refs/heads/master@{#398014}
(cherry picked from commit 10633dff101889d287c524266420f3b37dc7a23c)
Review URL: https://codereview.chromium.org/2043703002 .
Cr-Commit-Position: refs/branch-heads/2743@{#234}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Smart Lock] Dismiss auto-signin FRE on events from native part.
BUG=609416
Review-Url: https://codereview.chromium.org/1967343002
Cr-Commit-Position: refs/heads/master@{#396375}
(cherry picked from commit c0853f64652ee5527f34f3f97524c1753ddb1e37)
Review URL: https://codereview.chromium.org/2039213002 .
Cr-Commit-Position: refs/branch-heads/2743@{#233}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Fetch API] Request's JS wrapper should be kept alive in FetchEvent
From the same reason as [1], we need to keep blink::Request's wrapper
in FetchEvent and ForeignEvent's wrappers. This CL adds hidden
values in order to teach v8 the dependency.
1: https://crrev.com/d4b43c621eb323605c258a1a7f238bf9d6fb7523
BUG=614272
Review-Url: https://codereview.chromium.org/2025143003
Cr-Commit-Position: refs/heads/master@{#397625}
(cherry picked from commit a153f873d904d8cdd0dafb9507f7a5b560251426)
Review URL: https://codereview.chromium.org/2040823002 .
Cr-Commit-Position: refs/branch-heads/2743@{#232}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.31
Cr-Commit-Position: refs/branch-heads/2743@{#231}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[DevTools] Improve MainThreadDebugger::memoryInfo
Use context->Global() instead of CreationContext in MainThreadDebugger::memoryInfo.
BUG=616225
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2034203002
Cr-Commit-Position: refs/heads/master@{#397887}
(cherry picked from commit 6c932f8010646f4cc13985d05e3cc75f29ea2abb)
Review URL: https://codereview.chromium.org/2043543002 .
Cr-Commit-Position: refs/branch-heads/2743@{#230}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert "Merge to M52: Record offline histograms with suffix via Histogram::FactoryGet"
This reverts commit b58f3022768966477a16419348780ed8c1fa42f0.
Causing compilation failures:
../../components/offline_pages/offline_page_metadata_store_impl.cc: In member function 'void offline_pages::OfflinePageMetadataStoreImpl::LoadDone(const LoadCallback&, bool, std::__1::unique_ptr<std::__1::vector<offline_pages::OfflinePageEntry> >)':
../../components/offline_pages/offline_page_metadata_store_impl.cc:177:37: error: 'kBookmarkNamespace' is not a member of 'offline_pages'
item.client_id.name_space = offline_pages::kBookmarkNamespace;
BUG=616231
Cr-Commit-Position: refs/branch-heads/2743@{#229}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.30
Cr-Commit-Position: refs/branch-heads/2743@{#228}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[DevTools] Fix problem with loading source maps
Encode not utf8 chunk as base 64 and then decode it on frontend side.
BUG=611328
[email protected]
Review-Url: https://codereview.chromium.org/2032013003
Cr-Commit-Position: refs/heads/master@{#397618}
(cherry picked from commit 72c30193f0804fff83ed73d92db7d5fc5df6b186)
Review URL: https://codereview.chromium.org/2039013002 .
Cr-Commit-Position: refs/branch-heads/2743@{#227}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
cc : Fix hit testing bug in resourceless software draw mode
Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.
BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2033163003
Cr-Commit-Position: refs/heads/master@{#397543}
(cherry picked from commit 8d0064fad7a0842a60a61a00ffc58775f8c8f982)
Review URL: https://codereview.chromium.org/2042573002 .
Cr-Commit-Position: refs/branch-heads/2743@{#226}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Make updateMarkerRenderedRect() to dispose temporary Range object after use
This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to
dispose temporary |Range| object after use to prevent increasing number of
active |Range| object for avoiding slow down of DOM mutation operations.
Note: This patch is a temporary solution, we'll have |EphemeralRange| version
later.
BUG=613658
TEST=n/a; This is temporary solution, we'll have another solution later.
Review-Url: https://codereview.chromium.org/2034753003
Cr-Commit-Position: refs/heads/master@{#397626}
(cherry picked from commit 544e48708ee9286a58dfa24e0f29e30cece34f3c)
Review URL: https://codereview.chromium.org/2041493003 .
Cr-Commit-Position: refs/branch-heads/2743@{#225}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Android: Call SetNeedsAnimate() for toolbar animations
Fixes a regression from
https://codereview.chromium.org/1879833002/
The are cases where the frontend drives a toolbar
animation through onVisibleContentOffsetChanged() which
do need to request further commits/draws, so try to disinguish
these.
BUG=608257
Review-Url: https://codereview.chromium.org/2022183005
Cr-Commit-Position: refs/heads/master@{#397252}
(cherry picked from commit 5c9ce08f0086cde9519de46351ce1d1fd3cc3684)
Review URL: https://codereview.chromium.org/2034293003 .
Cr-Commit-Position: refs/branch-heads/2743@{#224}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.29
Cr-Commit-Position: refs/branch-heads/2743@{#223}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Update selection region style
* use simple gray region
* use gray for unselected regions instead.
* use darker gray for unselected region
* Instead of using platform cursor, draw pseudo cursor when selecting region
BUG=608269
Review-Url: https://codereview.chromium.org/1997193002
Cr-Commit-Position: refs/heads/master@{#397498}
(cherry picked from commit ef6f5af980b06e664d0cd9dc7cb578d6862b6c36)
Review URL: https://codereview.chromium.org/2030253004 .
Cr-Commit-Position: refs/branch-heads/2743@{#222}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects on Android and Mac.
BUG=582537
TEST=The "Connecting and disconnecting" section of https://goo.gl/XwzFlR#heading=h.efzd105luqv2.
Review-Url: https://codereview.chromium.org/2008113002
Cr-Commit-Position: refs/heads/master@{#395815}
(cherry picked from commit e7ee2ca3a44637a7dbc964978a74f5cd07865c02)
Review URL: https://codereview.chromium.org/2037173003 .
Cr-Commit-Position: refs/branch-heads/2743@{#221}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Fix regression with infobar border.
This cl fixes a regression where infobars no longer displayed their
border.
[email protected]
BUG=615312
Review-Url: https://codereview.chromium.org/2029893002
Cr-Commit-Position: refs/heads/master@{#397473}
(cherry picked from commit 91226de4de99cf0d7b87b48ddabbb7affcb246e6)
Review URL: https://codereview.chromium.org/2032143005 .
Cr-Commit-Position: refs/branch-heads/2743@{#220}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
ChromeOS: disable ToggleMaximize for login and lock screen.
ChromeOS login and lock screens must be always maximized even on touch devices.
BUG=600756
TEST=none
Review-Url: https://codereview.chromium.org/2013963004
Cr-Commit-Position: refs/heads/master@{#396123}
(cherry picked from commit fcc752dc3c312176fc7dbc88a0b024139cb1d7c9)
Review URL: https://codereview.chromium.org/2040493003 .
Cr-Commit-Position: refs/branch-heads/2743@{#219}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Just use the image skia from resouce bundle for default app icon.
Another issue similar to 605884.
BUG=614992
[email protected]
Review-Url: https://codereview.chromium.org/2012273002
Cr-Commit-Position: refs/heads/master@{#397040}
(cherry picked from commit b801ad2f00aff615076a2a1c22d76b68e61ae687)
Review URL: https://codereview.chromium.org/2034293002 .
Cr-Commit-Position: refs/branch-heads/2743@{#218}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Consider start time for frame painting and fix naming in test.
These changes were accidentally dropped from the final commit after
approval in previous review: https://codereview.chromium.org/2007463005
BUG=614099
TBR=xhwang
Review-Url: https://codereview.chromium.org/2034903002
Cr-Commit-Position: refs/heads/master@{#397614}
(cherry picked from commit 094201df5bbbc6ca093c3c0d6812da1202a53504)
Review URL: https://codereview.chromium.org/2038053003 .
Cr-Commit-Position: refs/branch-heads/2743@{#217}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Paint first frame faster, don't crash with no frames during EOS.
Since we're no longer using the sink to paint the first frame, it's
easier to start painting the first frame as soon as we know it's
"a sure thing." Which is when we (1) have at least two frames
queued, or (2) the first frame has a timestamp >= start timestamp,
or (3) know that no more frames are coming.
As part of this, fixes a nullptr crash caused by deciding if EOS
should be triggered before removing frames for underflow, which
leaves painting with no frames.
Additionally adds a unique identifier to VideoFrames to resolve
incorrect caching issues that the above changes exposed.
BUG=614099
TEST=new unittest
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2007463005
Cr-Commit-Position: refs/heads/master@{#397468}
(cherry picked from commit 046faf603abbd7886bd01bc99078d716145d3680)
Review URL: https://codereview.chromium.org/2036073003 .
Cr-Commit-Position: refs/branch-heads/2743@{#216}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Make painting a single frame a permanent API on VideoRendererSink.
Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().
This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes due having two sink startup points.
BUG=614099, 611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1996763002
Cr-Commit-Position: refs/heads/master@{#395138}
(cherry picked from commit e9c89e91623714fe04fd20c5caaee03dcae021e5)
Review URL: https://codereview.chromium.org/2039443003 .
Cr-Commit-Position: refs/branch-heads/2743@{#215}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Cronet]Make delaying sending request headers explicit in bidirectional stream
Always delaying sending request headers when
disableAutoFlush is not safe (in the case of bidirectional
streaming). Because server might be expecting request
headers before sending a response, while client might only
call SendData/SendvData after server responds.
This CL adds an explicit flag to tell
net::BidirectionalStream when to delay sending request
headers and coalesce them with data frames in
SendData/SendvData.
BUG=599902
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/1992953004
Cr-Commit-Position: refs/heads/master@{#397567}
(cherry picked from commit bcb0f86e685b9d603bebb97e9574e2e0e32948c2)
Review-Url: https://codereview.chromium.org/2031923006
Cr-Commit-Position: refs/branch-heads/2743@{#214}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available"
Because we came across issues in some CrOS platforms in HW H264 encode,
we decided to revert this CL such that HW H264 is only enabled for MacOSX.
Please see the bug below for details.
BUG=615272
Review-Url: https://codereview.chromium.org/2030833002
Cr-Commit-Position: refs/heads/master@{#397601}
(cherry picked from commit d7e93a2d1bae10c260230a1de7c5d9f1f0272d03)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2041543002
Cr-Commit-Position: refs/branch-heads/2743@{#213}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to M52: Record offline histograms with suffix via Histogram::FactoryGet
Also move all offline client namespace constants into one central place.
BUG=616231
[email protected]
Committed: https://crrev.com/8ccbcdc96179ab65038e17cdbddc149e28754830
Cr-Commit-Position: refs/heads/master@{#397233}
Review-Url: https://codereview.chromium.org/2022283003
Cr-Commit-Position: refs/heads/master@{#397623}
(cherry picked from commit 37ab199f7ba4c272d620813c458bc8f524c2c3ba)
Review URL: https://codereview.chromium.org/2036983003 .
Cr-Commit-Position: refs/branch-heads/2743@{#212}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Log BIDIRECTIONL_STREAM_ALIVE before HTTP_STREAM_REQUEST
This CL logs BIDIRECTIONL_STREAM_ALIVE before we start any stream request.
This makes sure that HTTP_STREAM_REQUEST is nested inside
BIDIRECTIONL_STREAM_ALIVE begin and end events.
BUG=516342
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2016863002
Cr-Commit-Position: refs/heads/master@{#397205}
(cherry picked from commit f88028e345674e0e76677164dd415b4dee886590)
Review-Url: https://codereview.chromium.org/2036043003
Cr-Commit-Position: refs/branch-heads/2743@{#211}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Mark the x64 official tests executable as optional in files.cfg.
We don't build these tests anymore on this builder.
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2021953003
Cr-Commit-Position: refs/heads/master@{#396871}
(cherry picked from commit 966c665e43df27a614646f30cf24c262365eced6)
Review URL: https://codereview.chromium.org/2034253002 .
Cr-Commit-Position: refs/branch-heads/2743@{#210}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "Use layout positions for NtpView#getFirstViewMatchingViewType"
Merge https://crrev.com/f229c8468fdf8e90d9e1d97dd8e68a91d3d5c763 to
M52 to fix a ClassCastException crash caused by the wrong view being
returned.
BUG=616843
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2036703003
Cr-Commit-Position: refs/branch-heads/2743@{#209}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec. (patchset #1 id:1 of https://codereview.chromium.org/2032143004/ )
Reason for revert:
Broke the continuous build because of a missing symbol.
https://chromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20beta/builds/3236/steps/compile/logs/stdio
FAILED: obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o.d -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=269902-1 -DENABLE_RLZ -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DTOOLKIT_VIEWS=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DUSE_CUPS '-DI18N_ADDRESS_VALIDATION_DATA_URL="https://i18napis.appspot.com/ssl-aggregate-address/"' -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -Iobj/chrome/browser_ui.gen -Iobj/chrome/browser_ui.gen/chrome -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit/Source -Igen/chrome -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/dist/proto_gen -Igen/policy -Igen/components -Igen/components/strings -I../../third_party/WebKit -Igen/third_party/WebKit -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/zlib -Igen/ui/resources -Igen/content/app/resources/ -I../../third_party/libwebm/source -I../../third_party/opus/src/include -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/re2/src -I../../v8/include -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -Igen/ui/views/resources -I../../third_party/libaddressinput/chromium/override -I../../third_party/libaddressinput/src/cpp/include -Igen/third_party/libaddressinput/ -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonnull -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac_beta/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -fcolor-diagnostics -fno-strict-aliasing -fno-standalone-debug -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -c ../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm -o obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o
../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:583:29: error: no member named 'GetSecureTextColor' in 'OmniboxViewMac'
OmniboxViewMac::GetSecureTextColor(security_level, in_dark_mode);
~~~~~~~~~~~~~~~~^
Original issue's description:
> [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.
>
> This cl changes the Omnibox's stroke in Incognito mode to match the
> recent spec revisions made by sgabriel@.
>
> Changing to the new spec also required switching other MD colors to the
> sRGB color space so that everything matched. The plan was to switch to
> sRGB (which is correct - the calibrated space is not) eventually, but
> to get the Omnibox to look right, now is the time.
>
> [email protected],[email protected]
> BUG=613749
>
> Review-Url: https://codereview.chromium.org/2013183003
> Cr-Commit-Position: refs/heads/master@{#396986}
> (cherry picked from commit 7a7f2e398b53990858d88bc19115c137630795f3)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/793018247051e845ad6754e0344f5f892349237f
[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=613749
Review-Url: https://codereview.chromium.org/2035153002
Cr-Commit-Position: refs/branch-heads/2743@{#208}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Bring Omnibox stroke and MD colors up to spec.
This cl changes the Omnibox's stroke in Incognito mode to match the
recent spec revisions made by sgabriel@.
Changing to the new spec also required switching other MD colors to the
sRGB color space so that everything matched. The plan was to switch to
sRGB (which is correct - the calibrated space is not) eventually, but
to get the Omnibox to look right, now is the time.
[email protected],[email protected]
BUG=613749
Review-Url: https://codereview.chromium.org/2013183003
Cr-Commit-Position: refs/heads/master@{#396986}
(cherry picked from commit 7a7f2e398b53990858d88bc19115c137630795f3)
Review URL: https://codereview.chromium.org/2032143004 .
Cr-Commit-Position: refs/branch-heads/2743@{#207}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable AltSvc from insecure origin.
* Do not parse Alt-Svc response on insecure connections, add regression test.
* Do not follow in-memory Alt-Svc on insecure connections, add regression test.
This CL has a shortcut: |enable_alt_svc_for_insecure_origin|, which is false in
production but true in tests (except for the two regression tests). Adapting
the existing tests is a lot of work, that will come in one or more follow-up
CLs.
[email protected]
BUG=615497
Review-Url: https://codereview.chromium.org/2026863002
Cr-Commit-Position: refs/heads/master@{#397097}
(cherry picked from commit e3dd56f4d98843611954b84fa28c1e884594fd05)
Review URL: https://codereview.chromium.org/2030023005 .
Cr-Commit-Position: refs/branch-heads/2743@{#206}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Android] Add support for Partner bookmarks to Chrome bookmark widget
Before this CL, the current folder of the widget is stored as a long in
the shared preferences. Now it will be stored as a String that can be
serialized directly into a BookmarkId object. The advantage of storing
strings is that it carries sufficient info about whether a bookmark is a
partner bookmark.
BUG=613171
Review-Url: https://codereview.chromium.org/2031893002
Cr-Commit-Position: refs/heads/master@{#397539}
[email protected]
Review URL: https://codereview.chromium.org/2038893002 .
Cr-Commit-Position: refs/branch-heads/2743@{#205}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[css] Bandaid fix for crash when tables and containment mix.
BUG=613907
Review-Url: https://codereview.chromium.org/2037443002
Cr-Commit-Position: refs/heads/master@{#397433}
(cherry picked from commit 0274d37d7fbebbdb95a912255e2015779b03394d)
Review URL: https://codereview.chromium.org/2040463002 .
Cr-Commit-Position: refs/branch-heads/2743@{#204}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Extensions] Don't CHECK() on bad pref types in scoped updates
As nice as it would be to be able to CHECK() on a bad pref value type,
we know that users can get into a mangled state with their preferences.
Instead of crashing (in the case of this bug, immediately on startup),
we should just silently ignore the bad values in prefs in release
builds. I'm leaving in DCHECK so that we can still catch this in tests
and the trybots, so that we at least have some coverage of expected
behavior.
BUG=616149
Review-Url: https://codereview.chromium.org/2029093002
Cr-Commit-Position: refs/heads/master@{#397423}
(cherry picked from commit bf58a7f80e2bb4a1149c20014cc8c2ad8cac7c1d)
Review URL: https://codereview.chromium.org/2036283002 .
Cr-Commit-Position: refs/branch-heads/2743@{#203}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix runtime setting forcing passive event listeners to scroll blocking events.
Previously the runtime settings would apply to all events; make it
restricted to scroll blocking events.
Also adjust the blockedEventsWarning threshold to use this same event
type (it was previously reporting touchend as well; which it shouldn't
have)
BUG=599611
Review-Url: https://codereview.chromium.org/2024913002
Cr-Commit-Position: refs/heads/master@{#396855}
(cherry picked from commit b38d8cc6524ed76a371abb851f97e534aab04926)
Review URL: https://codereview.chromium.org/2029393004 .
Cr-Commit-Position: refs/branch-heads/2743@{#202}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Correctly move permission bubbles after entering / exiting fullscreen.
When full screen is entered or exited the position of the bubble arrow
may need to be updated. This change updates the location, and ensures
the bubble is repainted when the arrow location is updated.
BUG=614928
Review-Url: https://codereview.chromium.org/2036503002
Cr-Commit-Position: refs/heads/master@{#397314}
(cherry picked from commit 2c657c1722cfc92eb307341859a294ff64d6d40a)
Review URL: https://codereview.chromium.org/2036973002 .
Cr-Commit-Position: refs/branch-heads/2743@{#201}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.28
Cr-Commit-Position: refs/branch-heads/2743@{#200}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Keep using the same DPI scale
* Dynamic DSF change is not supported/tested on linux. Jus make sure that it uses the same scale unless restarted.
BUG=615353
[email protected]
Review-Url: https://codereview.chromium.org/2022383002
Cr-Commit-Position: refs/heads/master@{#397171}
(cherry picked from commit 52c96f45954fb726585acd0bac295d801728b22e)
Review URL: https://codereview.chromium.org/2036693003 .
Cr-Commit-Position: refs/branch-heads/2743@{#199}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52] Disable video overlay for WebView
Video overlay for embedded videos (aka hole punching)
is a hidden API in WebSettings that we plan to remove.
Disabling it to verify that nobody uses it.
BUG=616583
TBR=timav
> Review-Url: https://codereview.chromium.org/2026423002
> Cr-Commit-Position: refs/heads/master@{#397458}
Review URL: https://codereview.chromium.org/2036453004 .
Cr-Commit-Position: refs/branch-heads/2743@{#198}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
media: AVDA::QueueInput/DequeueOutput bail if state_ is invalid
Previously AVDA::DoIOTask() checked that state_ was valid before
calling QueueInput and DequeueOutput. Now, because we call them
multiple times in a row, it's possible for state_ to change and
for it to be no longer valid to call them. This CL adds early
returns when the state is invalid.
BUG=612343,612264
Review-Url: https://codereview.chromium.org/2029373002
Cr-Commit-Position: refs/heads/master@{#397480}
(cherry picked from commit 79b7deae415586f31d55268b9847610dde4e272e)
Review URL: https://codereview.chromium.org/2034923002 .
Cr-Commit-Position: refs/branch-heads/2743@{#197}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Lock CrossThreadPersistentRegion until end of weak processing.
Allocating & releasing a CrossThread(Weak)Persistent is something that
all threads are currently allowed, even those not attached to Oilpan and
having no heap of their own. It is however not safe for the set of
CrossThreadPersistents to be altered while a garbage collection is
underway.
Not just while the set of registered persistents are being marked and
traced, but up until and including the processing of weak (persistent)
references that happen after marking. If not, a thread would be able to
release a CrossThreadWeakPersistent node which the weak processing separately
maintains a pointer to, clearing & freeing its allocation. Which would
cause havoc, hence we impose a lock on CrossThreadPersistentRegion while
the marking and global weak processing is being performed -- any thread
attempting to create or free cross-thread persistents will be locked out
for the duration.
Following r396432, the use of CrossThreadPersistents from non-attached threads
has been reduced greatly and is slight.
R=
BUG=610477
Review-Url: https://codereview.chromium.org/2013173002
Cr-Commit-Position: refs/heads/master@{#396540}
(cherry picked from commit 174054b089b91ea41c4baa09bcc7b6762fe42005)
Review URL: https://codereview.chromium.org/2033893002 .
Cr-Commit-Position: refs/branch-heads/2743@{#196}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Bring bookmark hover state, etc. up to spec.
This cl brings the bookmark hover state appearance in various places,
the padding between buttons, and the layout of folder buttons within
folder menus up to spec.
[email protected]
BUG=613279,615224,615163,613086
Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133
Cr-Commit-Position: refs/heads/master@{#396195}
Review-Url: https://codereview.chromium.org/2013523005
Cr-Commit-Position: refs/heads/master@{#396851}
(cherry picked from commit 384032da30351eb07a56b86e9dd38e316add54d6)
Review URL: https://codereview.chromium.org/2034813002 .
Cr-Commit-Position: refs/branch-heads/2743@{#195}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Move MainThreadTaskRunner off Oilpan heap to simplify posting.
Having the Document's MainThreadTaskRunner on the Oilpan heap
is preferable for three reasons:
- Correctly accounts for the MainThreadTaskRunner::m_context
back reference, by having it be traced Member<>.
- The MainThreadTaskRunner must not perform tasks when
it (and the Document) is in the process of being swept.
By having the posted tasks keep a weak persistent reference
to MainThreadTaskRunner, the Oilpan GC will ensure that
the weak references will be cleared once MainThreadTaskRunner
has been deemed garbage.
- Similarly for the timer-initiated running of a
MainThreadTaskRunner's pending tasks. The Timer<> abstraction
takes care of not firing a timer if its owner is an
Oilpan heap object that's about to be swept.
But it is not without downsides:
- A CrossThreadWeakPersistent<> has to be created for every
task closure posted to the main thread, and copying that
persistent reference around while creating the closure,
something that is not without overhead.
- Threads not attached to Oilpan needing to post tasks to
the main thread will have to create these persistents also.
Having that happen when a GC is in progress is hard to support,
as it risks introducing and removing persistent heap references
in ways that interfere with the GC processing the heap.
The latter point is sufficient reason not to require the
allocation of CrossThreadWeakPersistent<>s when posting main
thread tasks, hence MainThreadTaskRunner is moved off the
Oilpan heap. By doing so, the benefits above that the Oilpan GC
infrastructure provided "for free" have to be taken care of
manually. C'est la vie.
R=
BUG=610477
Review-Url: https://codereview.chromium.org/1938313003
Cr-Commit-Position: refs/heads/master@{#396432}
(cherry picked from commit 93ddd5fff7fbe018efc1df2be3fe907103314422)
Review URL: https://codereview.chromium.org/2034713003 .
Cr-Commit-Position: refs/branch-heads/2743@{#194}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.27
Cr-Commit-Position: refs/branch-heads/2743@{#193}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Make CronetHttpURLConnection#setConnectTimeout silently fail
This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.
The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).
BUG=611851
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
(cherry picked from commit 7130ccb5f2fa407a7dd54e221744978475d8b64e)
Review-Url: https://codereview.chromium.org/2037683003
Cr-Commit-Position: refs/branch-heads/2743@{#192}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
bluetooth: Fix logic mistake in DeviceChanged
Fixes an issue in which we always disconnected a device even if the connection
is still active.
BUG=615383
Review-Url: https://codereview.chromium.org/2016973003
Cr-Commit-Position: refs/heads/master@{#396877}
(cherry picked from commit bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775)
Review URL: https://codereview.chromium.org/2032093002 .
Cr-Commit-Position: refs/branch-heads/2743@{#191}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.26
Cr-Commit-Position: refs/branch-heads/2743@{#190}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52] Avoid deleting RenderProcessHostImpl for in-process
This is suspected to be the cause of null pointer crash in Android
WebView when RenderProcessHostImpl::FromID unexpectedly returns null.
Issue is RenderProcessHostImpl::DecrementWorkerRefCount does not
check for run_renderer_in_process() like RemoveRoute. Move the check
to beginning of Cleanup instead.
BUG=616476
Review-Url: https://codereview.chromium.org/2029623002
Cr-Commit-Position: refs/heads/master@{#397235}
(cherry picked from commit 55cb5a389f401a539225c7e7b59197114db5cd29)
Review URL: https://codereview.chromium.org/2036743002 .
Cr-Commit-Position: refs/branch-heads/2743@{#189}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Change ThreadedInputConnection to extend BaseInputConnection
There is an email client app that tries to cast ThreadedInputConnection
to BaseInputConnection. It is their fault, but we do not want to cause
crashes when ImeThread feature gets launched, so here is a workaround.
BUG=616334
Review-Url: https://codereview.chromium.org/2025173003
Cr-Commit-Position: refs/heads/master@{#397302}
(cherry picked from commit 6e6702b79373335ec6ddf966f3d20fd655c0f058)
Review URL: https://codereview.chromium.org/2030863002 .
Cr-Commit-Position: refs/branch-heads/2743@{#188}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.25
Cr-Commit-Position: refs/branch-heads/2743@{#187}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Clean up V8 bindings template code
This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
- Uses custom filters for the attribute list to duplicating complicated logic
between for loops in the template and extra booleans defined in python.
- Adds a unique_by filter to simplify the uniqueness logic in the templates.
- Makes consistent use of the 'runtime_enabled' filter.
- Combines for/endfor and if/endif tags into single for-if/endfor tags.
- Makes use of the jinja2 'groupby' filter to clarify the complex logic for
collecting and grouping runtime features by name.
It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.
[email protected]
Review-Url: https://codereview.chromium.org/2000483002
Cr-Commit-Position: refs/heads/master@{#395067}
(cherry picked from commit b96196730f9ca3f02a60c3e59b58b61bf5c50def)
BUG=584367
Review URL: https://codereview.chromium.org/2029423002 .
Cr-Commit-Position: refs/branch-heads/2743@{#186}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Origin Trials] Install origin trial bindings on V8 context conditionally
This patch removes the call-time check for origin-trial-enabled features,
replacing it with code that installs features into the V8 context as trial
tokens are encountered. This means that experimental features which were previously polluting the global namespaces are now completely unavailable except when enabled by origin trials. (The specific case of pollution caused by Durable Storage is removed from test expectations in this patch)
Origin trials are now initialized after the V8 context, by calling initializeOriginTrials. This calls, through a series of function pointers, the bindings initialization code for core, modules, and optionally internals (for tests).
This patch implements the design at https://docs.google.com/document/d/1vwKD8sUrr5mtktvEwvO_f2KUsNhpcgLMixYXhD8K4KY
BUG=584367
Review-Url: https://codereview.chromium.org/2005433002
Cr-Commit-Position: refs/heads/master@{#396860}
(cherry picked from commit e3f3c54cae7eea91719344411dbfe89a717f2e9f)
Review URL: https://codereview.chromium.org/2032613005 .
Cr-Commit-Position: refs/branch-heads/2743@{#185}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Track whether origin trial feature bindings have been installed
This patch adds to the OriginTrialContext a set of features for which V8
bindings have been installed, and two methods to maintain this set.
In a subsequent CL, we will be changing the origin trial V8 bindings to be installed conditionally after the V8 context is initialized. At that point, these methods are going to be used to track which features have already been added, so that we don't attempt to install any feature twice.
BUG=584367
Review-Url: https://codereview.chromium.org/2003603002
Cr-Commit-Position: refs/heads/master@{#395704}
(cherry picked from commit a8300471d75ffba2c2234e9424a6a68798f5c90e)
Review URL: https://codereview.chromium.org/2030743003 .
Cr-Commit-Position: refs/branch-heads/2743@{#184}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add an installAttribute method for V8 objects
The existing DOM configuration code for installAttribute only applies to object
templates, and is intended for use when setting up the DOM template. This patch
adds a separate method which can be used to add attributes into a specific V8
context, by providing an object instance rather than a template (this parallels
the existing installAccessor code).
This is intended to be used by origin trials, to configure attributes in a
context-dependent manner.
BUG=584367
Review-Url: https://codereview.chromium.org/2002613002
Cr-Commit-Position: refs/heads/master@{#395659}
(cherry picked from commit 9dc629cf5fdd66d747c10c5f0f2e5d4a793eb104)
Review URL: https://codereview.chromium.org/2037493002 .
Cr-Commit-Position: refs/branch-heads/2743@{#183}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add strictmode disk read/write exemption for calls to show hide keyboard
InputMethodManagerService in Android platform sometimes access disk
to record the IME state. This prevents crashes in dev.
BUG=616283
Review-Url: https://codereview.chromium.org/2027923002
Cr-Commit-Position: refs/heads/master@{#397224}
(cherry picked from commit 9cde65f3edabcbcd41e5b581a802672705c69a93)
Review URL: https://codereview.chromium.org/2032873002 .
Cr-Commit-Position: refs/branch-heads/2743@{#182}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.24
Cr-Commit-Position: refs/branch-heads/2743@{#181}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Delay putSearchAtBottom_() until after imports
This change ensures that a call to putSearchAtBottom_() is made after
all the html imports have been completed. This should ensure that the
reference to search.offsetHeight is not zero when it sets margins and
padding.
BUG=614209, 609350
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2008393002
Cr-Commit-Position: refs/heads/master@{#396244}
(cherry picked from commit 39dfd062d8014833796a544e4b778ed811b98325)
Review-Url: https://codereview.chromium.org/2028373002
Cr-Commit-Position: refs/branch-heads/2743@{#180}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
bluetooth: Add option dict to ReadValue/WriteValue dbus call
The BlueZ CL below added option dict to ReadValue and WriteValue.
http://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=93b64d9
As we intend to use BlueZ API change for Gatt server funtionality,
this CL updates Chrome DBus call to match the new BlueZ API by
just append an empty option dict for Gatt client call.
BUG=chromium:614903
TEST=Can read characteristic value from Pixel C keyboard
Review-Url: https://codereview.chromium.org/2016023002
Cr-Commit-Position: refs/heads/master@{#396595}
(cherry picked from commit 672ef3f9e8849b57eb03ef8752b861f410542ac7)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2036483002
Cr-Commit-Position: refs/branch-heads/2743@{#179}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Fix search focus handlers when search is enabled
This change corrects the point of setting the search focus handlers to
be after search first becomes enabled. Previously it was set in ready(),
but since disabling search by default, the handlers weren't correctly
updated.
BUG=592723
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2012593002
Cr-Commit-Position: refs/heads/master@{#395774}
(cherry picked from commit e5e7577ef96ee5fa24c8952e649312dc5427aa42)
Review-Url: https://codereview.chromium.org/2033473002
Cr-Commit-Position: refs/branch-heads/2743@{#178}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Put z-index of search over search results
This change gives the search div tag a z-index so that the mouse can
interact with it when the search results are being shown, which
currently cover the search div with padding.
BUG=615284
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2019543002
Cr-Commit-Position: refs/heads/master@{#396414}
(cherry picked from commit c93f3868acb563e2babd9a64e883ea9832fb471b)
Review-Url: https://codereview.chromium.org/2035473002
Cr-Commit-Position: refs/branch-heads/2743@{#177}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Update element positioning after delayed imports.
This change adds a call to update the positioning of dialog elements
after the delayed html imports have finished. Delaying the imports seems
to cause the first run flow element (which is conditionally templated)
to have an offsetHeight of 0 after it is stamped but before the imports
complete. Adding another update call lets the update correctly see this
element's offsetHeight when it is supposed to be visible.
[email protected]
BUG=612726
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/1996233002
Cr-Commit-Position: refs/heads/master@{#395116}
(cherry picked from commit 2786224a2dd9f8b5d785b589be26500900d9e5b0)
Review-Url: https://codereview.chromium.org/2029783002
Cr-Commit-Position: refs/branch-heads/2743@{#176}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix shelf alignment locking for power button.
Only lock the shelf once the lock animation starts.
(do not lock earlier, on the pre-lock animation start)
Add Alt-L (Lock) and Alt-P (Power) --ash-debug-shortcuts.
BUG=614042
TEST=Quickly tapping power/lock doesn't lock the shelf.
[email protected]
Review-Url: https://codereview.chromium.org/2013933002
Cr-Commit-Position: refs/heads/master@{#396599}
(cherry picked from commit dbd05211a0cbffa1bcd40888503c2cffeeb0d8ea)
Review URL: https://codereview.chromium.org/2035483002 .
Cr-Commit-Position: refs/branch-heads/2743@{#175}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.23
Cr-Commit-Position: refs/branch-heads/2743@{#174}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Modify status bubble text color.
Change from 50% alpha to 60% alpha as starting point (as per sgabriel's
recommendation).
Add a second step where we calculate a readable color. This doesn't
affect the classic theme but makes the text a little darker in some
cases (like GTK mode).
BUG=615175
Review-Url: https://codereview.chromium.org/2018023002
Cr-Commit-Position: refs/heads/master@{#396522}
(cherry picked from commit 480bd209859e7848c6636638d4b4a6804bc6dc4f)
Review URL: https://codereview.chromium.org/2036443002 .
Cr-Commit-Position: refs/branch-heads/2743@{#173}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to 2743 "[DevTools] Flush when sending javascript dialog notifications."
> [DevTools] Flush when sending javascript dialog notifications.
>
> Notifications are sync IPCs, so we have to flush instead of
> relying on task being finished.
>
> BUG=chromedriver:1381
>
> Review-Url: https://codereview.chromium.org/2002223002
> Cr-Commit-Position: refs/heads/master@{#395465}
(cherry picked from commit d876a6483cc612153b246577e80fe2d0dc544847)
[email protected]
Review URL: https://codereview.chromium.org/2028313002 .
Cr-Commit-Position: refs/branch-heads/2743@{#172}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert "When a headset or other application changes the active node's"
This reverts commit 7a0ee45432bf8e1c284216525de2d49421cc3e78.
BUG=614885
[email protected]
Review URL: https://codereview.chromium.org/2031793002 .
Cr-Commit-Position: refs/branch-heads/2743@{#171}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix ProtoPlusDepend/HttpNetworkTransactionTest.AltSvcOverwritesAlternateProtocol.
I'm able to reproduce the test failure reported in the bug locally. This
one-liner fixes it locally.
[email protected]
BUG=616561
Review URL: https://codereview.chromium.org/2027353002 .
Cr-Commit-Position: refs/branch-heads/2743@{#170}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Custom Tabs] Fix a bug that security icon might show for http
If the security icon state changes faster than the time it takes for
Android to relayout, hide animation might be called even before the
security icon's visibility has been flipped. This CL fixes the bug in
this scenario.
BUG=612939
Review-Url: https://codereview.chromium.org/2024173003
Cr-Commit-Position: refs/heads/master@{#396957}
[email protected]
Review URL: https://codereview.chromium.org/2027843003 .
Cr-Commit-Position: refs/branch-heads/2743@{#169}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
cc: Restore the space of interest area padding to be ideal contents space.
This patch ensures that the interest area padding we use is specified in
ideal contents scale, not in screen scale. Effectively this means that
on devices with content scale > 1, we will have a smaller interest area.
This restores the behavior that was changed when the calculation was
moved to the tiling set.
TBR=ericrk, enne
BUG=614990
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2022613002
Cr-Commit-Position: refs/heads/master@{#396602}
(cherry picked from commit 55a6f3c6ead8ab53ff8b0a1ea5953971d3e272a3)
Review URL: https://codereview.chromium.org/2027263003 .
Cr-Commit-Position: refs/branch-heads/2743@{#168}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Handle inconsistent PR_SET_TIMERSLACK_PID values on Android.
This prctl is custom to Android, and depending on the Android kernel
version it has several different values. By random luck, the other
prctl numbers they clobbered do not look super scary (unless there is a
bug involving Intel mpx), so I opted to allow them all instead of
relying on runtime kernel version detection.
BUG=611916
(cherry picked from commit 41db13c68491ee1ab9149ba1bef307b71a19bb39)
Review-Url: https://codereview.chromium.org/2005183002
Cr-Original-Commit-Position: refs/heads/master@{#395737}
Cr-Commit-Position: refs/branch-heads/2743@{#167}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Check for a non-null GrContext on the media::Context3D during paint.
The code checks that a ContextProvider was able to be found by checking
the |gl| field. But if the ContextProvider was created but lost, and
GrContext was not created yet, then it will fail to initialize and be
null. We should avoid trying to use this context then (and not crash).
[email protected]
BUG=612087
Review-Url: https://codereview.chromium.org/2003833002
Cr-Commit-Position: refs/heads/master@{#395222}
(cherry picked from commit 53f7ec90b80cf9c2371c1570d0b1ce2e63332018)
Review URL: https://codereview.chromium.org/2025353002 .
Cr-Commit-Position: refs/branch-heads/2743@{#166}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix bug of posting task inside constructor
Refcounted object is initialized to have zero refcount and will be increased
to 1 in RefCountedThreadSafe::operator=(). There is a chance that
ConnectToHost finishes earlier than operator=(), which drops the refcount to
0 and triggers the d'tor.
Adding sleep(1) after PostTask() shows stable repro of this problem.
This CL fixes this problem by pulling the PostTask code out of the ctor.
BUG=615288
Review-Url: https://codereview.chromium.org/2023113002
Cr-Commit-Position: refs/heads/master@{#396961}
(cherry picked from commit 35c9e62b75248238526386edc44c46794adac095)
Review URL: https://codereview.chromium.org/2029103002 .
Cr-Commit-Position: refs/branch-heads/2743@{#165}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use the same policy to check paint rect for all cell paintings
Because we use object-based invalidation, if an object is not
invalidated, it must draw all or none. For a table cell, it draws
background from container, collapsed borders and own contents from
different callers. We should use the same policy to check paint
rect intersection to ensure all-or-none painting.
BUG=614233
Review-Url: https://codereview.chromium.org/2022653002
Cr-Commit-Position: refs/heads/master@{#396856}
Review URL: https://codereview.chromium.org/2031613002 .
Cr-Commit-Position: refs/branch-heads/2743@{#164}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fallback solution when programmatically open add Google account page failed.
Show alert dialogue and offer a button to open "Settings > Accounts" page.
BUG=610531
Review-Url: https://codereview.chromium.org/2007083003
Cr-Commit-Position: refs/heads/master@{#396206}
(cherry picked from commit ebbe48e439473c95cfe141c78235e65f034015cc)
Review URL: https://codereview.chromium.org/2021343005 .
Cr-Commit-Position: refs/branch-heads/2743@{#163}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable HTTP/2 Alternative Service for different host.
Disable HTTP/2 Alternative Service if origin and alternative have different
hostnames. This is a temporary workaround until https://crbug.com/615413 is
fixed.
BUG=615637
Review-Url: https://codereview.chromium.org/2017323002
Cr-Commit-Position: refs/heads/master@{#396665}
(cherry picked from commit 8bef8da2318c3684b94c866bf194e8c427195b6a)
Review URL: https://codereview.chromium.org/2026293002 .
Cr-Commit-Position: refs/branch-heads/2743@{#162}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Fetch API] BodyStreamBuffer's JS wrapper should be kept alive via its holders
ReadableStreams in Request and Response are implemented with V8 extras, and
the instance is attached to BodyStreamBuffer's JS wrapper. But
that JS wrapper is not exposed to JS but accessed via its holder, i.e.,
Request and Response instances. Hence we need to teach V8 the dependency
manually.
BUG=614272
Review-Url: https://codereview.chromium.org/2017403002
Cr-Commit-Position: refs/heads/master@{#396729}
(cherry picked from commit d4b43c621eb323605c258a1a7f238bf9d6fb7523)
Review URL: https://codereview.chromium.org/2029483003 .
Cr-Commit-Position: refs/branch-heads/2743@{#161}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Added popup that shows the new Back shortcut on Mac.
Implements BrowserWindowCocoa::ShowNewBackShortcutBubble to open the
Views implementation of this bubble (similar to how the fullscreen
bubble works on Mac).
BUG=610039
Review-Url: https://codereview.chromium.org/2017813004
Cr-Commit-Position: refs/heads/master@{#396759}
(cherry picked from commit d8fdd17d87b906d6a0e21bd6366dface55132440)
Review URL: https://codereview.chromium.org/2020273003 .
Cr-Commit-Position: refs/branch-heads/2743@{#160}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add ReloadPageLoadMetricsObserver to have a metrics variant only reloads
To measure reload experiments impact, this change adds
ReloadPageLoadMetricsObserver to report TTFCP variants only for
reload-related page loadings.
BUG=607063
[email protected], [email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2008233002
Cr-Commit-Position: refs/heads/master@{#396395}
(cherry picked from commit d056525caaa71451d25f6113895b376e47177f6e)
Review-Url: https://codereview.chromium.org/2031443002
Cr-Commit-Position: refs/branch-heads/2743@{#159}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.22
Cr-Commit-Position: refs/branch-heads/2743@{#158}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.21
Cr-Commit-Position: refs/branch-heads/2743@{#157}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Updating XTBs based on .GRDs from branch 2743
Cr-Commit-Position: refs/branch-heads/2743@{#156}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Relayout if FrameView::updateViewSize() set needsLayout
BUG=590856
[email protected]
Review URL: https://codereview.chromium.org/2022013004 .
Cr-Commit-Position: refs/heads/master@{#396962}
Review URL: https://codereview.chromium.org/2025173002 .
Cr-Commit-Position: refs/branch-heads/2743@{#155}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Guard against invalid glyph shaping results
HarfBuzz can fail to shape all glyphs and will return a shape result
shorter than the text length along with debug warnings:
[ERROR:HarfBuzzShaper.cpp(375)] HarfBuzz returned empty glyph buffer after shaping.
[ERROR:HarfBuzzShaper.cpp(672)] Shape result extraction failed.
This patch fixes an SVG crash on the U+180E Mongolian vowel separator
by ensuring CachingWordShaper::individualCharacterRanges returns a
vector as long as the text run length. A DCHECK and test have been added
to protect against this crash in the future.
BUG=613915
Review-Url: https://codereview.chromium.org/2020863002
Cr-Commit-Position: refs/heads/master@{#396668}
(cherry picked from commit 433ceaeabee98073e81d552dee947aa6983efd53)
Review URL: https://codereview.chromium.org/2020423002 .
Cr-Commit-Position: refs/branch-heads/2743@{#154}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad
BUG=613266
Review-Url: https://codereview.chromium.org/2006033002
Cr-Commit-Position: refs/heads/master@{#396241}
(cherry picked from commit 1948aefa8901dca0ccb993753fca00b15d2a6e25)
Review URL: https://codereview.chromium.org/2026823003 .
Cr-Commit-Position: refs/branch-heads/2743@{#153}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
DevTools: fix css pretty-print.
The CSS pretty-printing was regressed back in the days when all formatters
were moved to a single content builder.
The content builder assumes that added tokens are "words" - and makes sure
those do not stick together. However, CSS formatter violates this contract.
This patch is a workaround which could be merged.
BUG=614678
R=dgozman
Review-Url: https://codereview.chromium.org/2012953002
Cr-Commit-Position: refs/heads/master@{#396332}
(cherry picked from commit aec0b6fa92b2f2bece418aede111a78b043a0655)
Review URL: https://codereview.chromium.org/2028863002 .
Cr-Commit-Position: refs/branch-heads/2743@{#152}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add a hack to set shouldPaint to true for force-composited iframes.
This works around a FCB chicken-egg problem in which we are unable to properly
start painting floating iframes once they stop being composited.
BUG=610906
Review-Url: https://codereview.chromium.org/2009353003
Cr-Commit-Position: refs/heads/master@{#396287}
(cherry picked from commit 3e010d5a156f8420a7deaae243b9c9323517aef1)
Review URL: https://codereview.chromium.org/2028493003 .
Cr-Commit-Position: refs/branch-heads/2743@{#151}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add Document encoding to header preloaded requests
When resources were preloaded using Link: headers, they weren't requested with
the document's charset, and therefore their decoding might have differed from non-preloaded resources.
This CL fixes that by requesting them with the right encoding.
BUG=615307
Review-Url: https://codereview.chromium.org/2019303002
Cr-Commit-Position: refs/heads/master@{#396735}
(cherry picked from commit 727d4183ad164bd4eaa4bde1c82eadb592e1c41c)
Review URL: https://codereview.chromium.org/2026673003 .
Cr-Commit-Position: refs/branch-heads/2743@{#150}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Only call onAnimationFinished if animation was running
This change only allows functions inside onUpdateAnimation to run if
an animation was actually running. Since Contextual Search and Reader
Mode are now SceneOverlays, the overlay is updated much more
frequently, thus, requiring this change.
BUG=614905, 613945
Review-Url: https://codereview.chromium.org/2015083002
Cr-Commit-Position: refs/heads/master@{#396572}
(cherry picked from commit c819e05e5f5062a078acbf0f1a5cbaad3beafb6a)
Review URL: https://codereview.chromium.org/2022293002 .
Cr-Commit-Position: refs/branch-heads/2743@{#149}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Update iOS WebUI History to use icon.js
Use icon.js in iOS WebUI History, which was factored out of util.js
in https://codereview.chromium.org/1919183005
BUG=614871
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2014743002
Cr-Commit-Position: refs/heads/master@{#396283}
(cherry picked from commit cd199135e935f3c9ce7be0e9954382ab0d2140e9)
Review URL: https://codereview.chromium.org/2026903002 .
Cr-Commit-Position: refs/branch-heads/2743@{#148}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Extensions] Expand capabilities to about:blank iframes within a page
Expand the content capabilies to grant the capabilities to about:blank
iframes within a page that matches the content capabilities entry for
an extension. This is consistent with most web permissions, where
about:blank frames take the permissions from the "parent".
In theory, we could also create a match_about_blank entry in the
manifest for this, but I'm not sure how many use cases there are for
*not* granting permissions to child frames like this.
BUG=599900
Review-Url: https://codereview.chromium.org/1985323002
Cr-Commit-Position: refs/heads/master@{#395744}
(cherry picked from commit d0f2bad624766048836545ab34e13cd7a46c92e8)
Review URL: https://codereview.chromium.org/2028833002 .
Cr-Commit-Position: refs/branch-heads/2743@{#147}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Restore bookmark icons to default favicon.
The Material Design bookmark buttons incorrectly used the
location_bar_http vector icon to display a document icon for the
default favicon. This cl adds default favicon vector icons based on the
original version of the location_bar_http vector, and changes the
bookmark buttons to use them.
[email protected], [email protected]
BUG=614539
Review-Url: https://codereview.chromium.org/2009643003
Cr-Commit-Position: refs/heads/master@{#396020}
(cherry picked from commit a0776f8a55b798c81fc142ea531c9d8a762c2c85)
Review URL: https://codereview.chromium.org/2028593003 .
Cr-Commit-Position: refs/branch-heads/2743@{#146}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
MediaRecorder: fix typo
It mistakenly said VP8 when it should have said VP9.
BUG=613665, 601636
[email protected]
Review-Url: https://codereview.chromium.org/2010413002
Cr-Commit-Position: refs/heads/master@{#396496}
(cherry picked from commit 35bb0d816c17ade12088e67a35a2e9e40c403b01)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2023083002
Cr-Commit-Position: refs/branch-heads/2743@{#145}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Harden LayoutTableSection::dirtiedRows() and dirtiedEffectiveColumns()
Not sure why the bug happens and why it happens on Android only.
Suspect coveredRows/columnedColumns start/end is increased/decreased
when it is already at the end/beginning.
BUG=609222
Review-Url: https://codereview.chromium.org/2009973002
Cr-Commit-Position: refs/heads/master@{#396357}
Review URL: https://codereview.chromium.org/2024233002 .
Cr-Commit-Position: refs/branch-heads/2743@{#144}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix theme colors not updating when navigating back/from the NTP.
This moves to better centralize and isoalte the theme color
tracking. Tab will now be in charge of determining when to
notify its observers about theme color changes.
The previous problem was that TabWebContentsObserver and Tab
were notifying observers and it was a mismatch of who was tracking
the theme colors (in particular with the addition of native pages).
This also removes the additional handling that was being done
in WebContents.java/WebContentsImpl.java as that did not match
the native behavior. The need for non-transparent colors should
be isolated to the chrome component where we are choosing how to
apply them.
BUG=614006
Review-Url: https://codereview.chromium.org/2014433002
Cr-Commit-Position: refs/heads/master@{#396054}
Review URL: https://codereview.chromium.org/2020333003 .
Cr-Commit-Position: refs/branch-heads/2743@{#143}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Refactor to simplify how layerType is stored on PaintLayers.
Instead of caching it on the PaintLayer, delegate to the LayoutBoxModelObject
to compute it on demand. Also remove a useless setter for it.
BUG=610906
Review-Url: https://codereview.chromium.org/2002153007
Cr-Commit-Position: refs/heads/master@{#396096}
(cherry picked from commit 4a1368f4a8cbc725bd4be8e216fc9f717f7b9f8d)
Review URL: https://codereview.chromium.org/2025093002 .
Cr-Commit-Position: refs/branch-heads/2743@{#142}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to 2743 "[DevTools] Draw screen border below screen image when taking screenshot."
> [DevTools] Draw screen border below screen image when taking screenshot.
>
> BUG=613515
>
> Review-Url: https://codereview.chromium.org/2010773002
> Cr-Commit-Position: refs/heads/master@{#396056}
(cherry picked from commit 5a8e343e823740a06acf460131d08dd6f655119b)
[email protected]
Review URL: https://codereview.chromium.org/2026723003 .
Cr-Commit-Position: refs/branch-heads/2743@{#141}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Record the return value of NativeLibraryPreloader.loadLibrary in UMA
BUG=614166
Review-Url: https://codereview.chromium.org/2015533005
Cr-Commit-Position: refs/heads/master@{#396632}
(cherry picked from commit 8369bdb2f158539fae0dc33eff0141394be164e6)
Review URL: https://codereview.chromium.org/2027793002 .
Cr-Commit-Position: refs/branch-heads/2743@{#140}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix an issue that filename is missing in download failure notification
When resuming a download, it is possible that the download is not in
history db.
In this case, native code won't be able to provide the filename.
We need to get the file name from sharedpreferences
[email protected]
BUG=614867
Review-Url: https://codereview.chromium.org/2007983007
Cr-Commit-Position: refs/heads/master@{#396321}
(cherry picked from commit c916d5295b2c636581db6271c242e35bf7394411)
Review URL: https://codereview.chromium.org/2019793002 .
Cr-Commit-Position: refs/branch-heads/2704@{#668}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
(cherry picked from commit 51af006325a102d9a29830fe98dff32ed02824b4)
Review URL: https://codereview.chromium.org/2026003002 .
Cr-Commit-Position: refs/branch-heads/2743@{#139}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Simple Cache: avoid extraneous stream 0 (http header) writes.
These writes were not only wasteful, but they could cause corruption
if the existing EOF record didn't have a key SHA256; the new key
SHA256 would overwrite the existing one corrupting the entry.
BUG=615440
[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2015263002
Cr-Commit-Position: refs/heads/master@{#396533}
(cherry picked from commit 6b66971b761a15a67982bef692619a96f306150d)
Review URL: https://codereview.chromium.org/2021303002 .
Cr-Commit-Position: refs/branch-heads/2743@{#138}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add a feature flag for enabling rendering pipeline throttling
Add a feature flag for rendering pipeline throttling so we can evaluate
its impact using a Finch experiment.
BUG=487937,614983
Review-Url: https://codereview.chromium.org/2014183002
Cr-Commit-Position: refs/heads/master@{#396428}
(cherry picked from commit 5fb28c944ab8cec3e7b1ab0ca866fbc7e242717f)
Review URL: https://codereview.chromium.org/2028563002 .
Cr-Commit-Position: refs/branch-heads/2743@{#137}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
scheduler: Avoid false alerts about expensive task blocking
This patch adjusts the logic for logging a console message when an
expensive task is blocked:
1. Don't log messages when all timer tasks are blocked (e.g., while
waiting for a touchstart response). There's nothing the developer can
do to avoid this type of blocking.
2. Only report blocking for tasks which exceed the 50ms RAIL threshold.
These types of tasks are most likely to cause user visible jank.
Lower blocking thresholds are also used for shorter periods of time,
so shorter tasks are not likely to be deferred for a long time
in any case.
3. Also mention network tasks in the log message.
BUG=613230
Review-Url: https://codereview.chromium.org/2016943003
Cr-Commit-Position: refs/heads/master@{#396467}
(cherry picked from commit c66723959e9a37f1a5bbd821366a2ee24a9537c2)
Review URL: https://codereview.chromium.org/2024823002 .
Cr-Commit-Position: refs/branch-heads/2743@{#136}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Smart Lock] Adds UMA Metrics for actions on Account Chooser.
One account, many accounts case.
BUG=611006
Review-Url: https://codereview.chromium.org/2009773003
Cr-Commit-Position: refs/heads/master@{#396696}
(cherry picked from commit 2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb)
Review URL: https://codereview.chromium.org/2024093002 .
Cr-Commit-Position: refs/branch-heads/2743@{#135}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile.
Do not pass object literals into dispatchMessage API. Always turn it into a string.
BUG=614860
Review-Url: https://codereview.chromium.org/2022673002
Cr-Commit-Position: refs/heads/master@{#396633}
(cherry picked from commit a2b2954002b9f46a902bb23ed6a11ba4c0604096)
Review URL: https://codereview.chromium.org/2018353006 .
Cr-Commit-Position: refs/branch-heads/2743@{#134}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Tune down debugging emergency for clearAnimatedType() a notch
Fixing re-entrancy into the animation code through the garbage
collector is proving to be a non-trivial task. Since we now know more
about the issue, downgrade the RELEASE_ASSERT to a DCHECK to not
affect more users than necessary while getting this bug sorted out.
BUG=613709
Review-Url: https://codereview.chromium.org/2019223003
Cr-Commit-Position: refs/heads/master@{#396705}
(cherry picked from commit 65dd95ea2016653f303fa75cc7736a8c633b7a96)
Review URL: https://codereview.chromium.org/2027533002 .
Cr-Commit-Position: refs/branch-heads/2743@{#133}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Added notification when user presses backspace to use new shortcut.
This adds a new type of notification bubble (based on the "Press Esc to
exit fullscreen" notification) that teaches users the new shortcuts for
Back and Forward when they press Back or Shift+Back.
Only implemented on Views systems (Windows, Linux, Chrome OS).
BUG=610039
Review-Url: https://codereview.chromium.org/1983803002
Cr-Commit-Position: refs/heads/master@{#396138}
(cherry picked from commit 7f3ddc6b70a09c7ae3bcd0d45007e415857fd09c)
Review URL: https://codereview.chromium.org/2023763004 .
Cr-Commit-Position: refs/branch-heads/2743@{#132}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Re-add backspace-goes-back as a default disabled finch trial.
This is just so that we have a kill switch in case this makes it
to stable and there is then unexpected outcry.
BUG=610039
Review-Url: https://codereview.chromium.org/1992003002
Cr-Commit-Position: refs/heads/master@{#395141}
(cherry picked from commit c7e4899df2f7e590de44237b4a2fdfd978ec70df)
[email protected]
Review URL: https://codereview.chromium.org/2024763002 .
Cr-Commit-Position: refs/branch-heads/2743@{#131}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.20
Cr-Commit-Position: refs/branch-heads/2743@{#130}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
