Publish DEPS for Chromium 52.0.2743.19
Incrementing VERSION to 52.0.2743.19
Cr-Commit-Position: refs/branch-heads/2743@{#129}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Avoid hiding --type=gpu-process
Move FeaturesAndFieldTrialFlags to the end of the gpu-process command
line to avoid breaking the pattern and to make process-type
identification easier (and more reliable from ETW traces).
BUG=614502
Review-Url: https://codereview.chromium.org/2013573002
Cr-Commit-Position: refs/heads/master@{#395742}
(cherry picked from commit 3089deef0bd591b699841f9b6b7cc9cd6ec88117)
Review URL: https://codereview.chromium.org/2024703003 .
Cr-Commit-Position: refs/branch-heads/2743@{#128}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Deprecate use of user gestures during scroll-related touch events
See https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nvOg/edit#heading=h.qq59ev3u8fba
Intent to deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2cvwbgZOZZs
This also contains a small tweak to the semantics of the TouchScrollStarted event to trigger it only on the first GestureScrollUpdate (so that it's not triggered when the page consumes all touchmove events).
BUG=611981
Review-Url: https://codereview.chromium.org/1996143002
Cr-Commit-Position: refs/heads/master@{#396215}
(cherry picked from commit adbb8a0133bf42306ac4a533a5478529e5d87895)
Review URL: https://codereview.chromium.org/2027473002 .
Cr-Commit-Position: refs/branch-heads/2743@{#127}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Dispatch middle click manually by tracking mouse
Tracking targets for middle button mousedown event
and fire click event for it on mouse up if necessary.
Note: The click is not finding the common parent of
mousedown and up targets for simplicty and only sends
the click to the target if both down and up happened
on the same node.
BUG=608697
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1963823002
Cr-Commit-Position: refs/heads/master@{#395707}
(cherry picked from commit 88eb1110baafcba070e750866a343e81b6bcc524)
Review URL: https://codereview.chromium.org/2027453002 .
Cr-Commit-Position: refs/branch-heads/2743@{#126}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Check for null to prevent the crash
Also remove the redundant parameter in the function.
BUG=615361
Review-Url: https://codereview.chromium.org/2020673002
Cr-Commit-Position: refs/heads/master@{#396519}
(cherry picked from commit 2139f567e16c062168c9bf9e762c30b59ce7b805)
Review URL: https://codereview.chromium.org/2021903002 .
Cr-Commit-Position: refs/branch-heads/2743@{#125}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Fetch API] Do not call v8 Extra script when the worker is terminating
ReadableStreamOperations assumes v8 Extra scripts cannot return an empty
handle but that assumption breaks when the worker is terminating. This CL
adds some early returns to avoid such issues.
This change is a workaround and should be reverted once the graceful
shutdown mechanism is introduced.
BUG=614272
Review-Url: https://codereview.chromium.org/2006803006
Cr-Commit-Position: refs/heads/master@{#396131}
(cherry picked from commit bef901ae9100f30e3ee2fb185c4197a2de55e4c1)
Review URL: https://codereview.chromium.org/2023813002 .
Cr-Commit-Position: refs/branch-heads/2743@{#124}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Roll libxml to bdec2183f34b37ee89ae1d330c6ad2bb4d76605f
BUG=614405
Review-Url: https://codereview.chromium.org/2010803004
Cr-Commit-Position: refs/heads/master@{#396097}
(cherry picked from commit 3c53598f981660671a93f9f71e52e5bb58a2b64e)
Review URL: https://codereview.chromium.org/2022693002 .
Cr-Commit-Position: refs/branch-heads/2743@{#123}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.18
Cr-Commit-Position: refs/branch-heads/2743@{#122}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fill in the current host name in the Mojo host resolver service when requesting our own IP address.
The V8 proxy resolver uses GetHostName() as the host in the
implementation of myIpAddress(). However, that may not return the
expected hostname when running inside the sandbox. Instead, use the
request's "is_my_ip_address" field to fill in the correct host name in
the browser before forwarding the resolve request to the DNS resolver.
BUG=615084
Review-Url: https://codereview.chromium.org/2011293002
Cr-Commit-Position: refs/heads/master@{#396424}
(cherry picked from commit 3a6cd21dab6a285179b02a05e980091c86545d66)
Review URL: https://codereview.chromium.org/2024553002 .
Cr-Commit-Position: refs/branch-heads/2743@{#121}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Enable AltSvc pooling by default.
* Change enable_alternative_service_with_different_host default value to true in
production.
* Change enable_alternative_service_with_different_host default value to true in
tests.
* Remove kEnableAlternativeServices command line switch.
* Change QUIC field trial parameter "enable_alternative_service_with_different_host"
behavior from enabling if true to disabling if value is false.
BUG=392575
Review-Url: https://codereview.chromium.org/1986633002
Cr-Commit-Position: refs/heads/master@{#396508}
(cherry picked from commit 58f0aa68fb0a15b0af56e7cfdf833ac3108fa00e)
[email protected],[email protected]
Review URL: https://codereview.chromium.org/2019933002 .
Cr-Commit-Position: refs/branch-heads/2743@{#120}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.17
Cr-Commit-Position: refs/branch-heads/2743@{#119}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.16
Cr-Commit-Position: refs/branch-heads/2743@{#118}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.15
Cr-Commit-Position: refs/branch-heads/2743@{#117}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of getComputedStyle should handle over-constrained properties. (patchset #7 id:100001 of https://codereview.chromium.org/1988813002/ )
Reason for revert:
Other vendors didn't implement this yet. And work with the others to either get all to fix or to change the spec.
BUG=614198
Original issue's description:
> getComputedStyle should handle over-constrained properties.
>
> If neither 'left' nor 'right' is 'auto', the position is over-constrained,
> and one of them has to be ignored. If 'direction' property of the
> containing block is 'ltr', the value of 'left' wins and 'right'
> becomes -'left'. If 'direction' of the containing block is 'rtl',
> 'right' wins and 'left' is ignored. Detail is described by
> https://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#relative-positioning
>
> BUG=601118
>
> Committed: https://crrev.com/c8291dea8bfa84ab9a3220fb9f57eb059e913a05
> Cr-Commit-Position: refs/heads/master@{#394780}
[email protected],[email protected],[email protected],[email protected],[email protected]
BUG=601118
Review-Url: https://codereview.chromium.org/2016913003
Cr-Commit-Position: refs/heads/master@{#396470}
(cherry picked from commit 9835ebf3b20d95106a5541e44b297963e0136802)
Review URL: https://codereview.chromium.org/2025523002 .
Cr-Commit-Position: refs/branch-heads/2743@{#116}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.14
Cr-Commit-Position: refs/branch-heads/2743@{#115}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.13
Cr-Commit-Position: refs/branch-heads/2743@{#114}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use initialized canvas to create network icons.
Remove rarely used ctor.
BUG=611616
Review-Url: https://codereview.chromium.org/2016833002
Cr-Commit-Position: refs/heads/master@{#396326}
(cherry picked from commit 07b5fad29dd278dee342363c7562bcec1fd729de)
Review URL: https://codereview.chromium.org/2015083004 .
Cr-Commit-Position: refs/branch-heads/2743@{#113}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Make std::sort predicate in GetUploadedReports a strict weak ordering
Quoting a quote from http://stackoverflow.com/questions/18291620/why-will-stdsort-crash-if-the-comparison-function-is-not-as-operator:
"""
25.4 Sorting and related operations [alg.sorting]
For algorithms other than those described in 25.4.3 to work correctly,
comp has to induce a strict weak ordering on the values.
The term strict refers to the requirement of an irreflexive relation
(!comp(x, x) for all x), and the term weak to requirements that are not
as strong as those for a total ordering, but stronger than those for a
partial ordering.
"""
I think this means that the previous code is violating the required
predicate of "a < b" when a == b. I wouldn't have thought that we'd have
identical .creation_time, but it's possible an implementation does
something like making a copy.
[email protected], [email protected]
BUG=615204
Review-Url: https://codereview.chromium.org/2016093002
Cr-Commit-Position: refs/heads/master@{#396323}
(cherry picked from commit 85f2f3f1b2fc87945a6fa2ad9ef2ce55eeeee71c)
Review URL: https://codereview.chromium.org/2023563002 .
Cr-Commit-Position: refs/branch-heads/2743@{#112}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of Add FrameHost mojo service (patchset #23 id:490001 of https://codereview.chromium.org/1964273002/ )
Reason for revert:
Async request for zoom level doesn't work in all cases https://crbug.com/614348 https://crbug.com/613979.
I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful.
Original issue's description:
> Add FrameHost mojo service
>
> Adds new frame-level service with one initial method to handle host zoom
> level.
>
> This moves zoom level supply from async_resource_handler.cc to being a
> request made when render_frame_impl handles a willSendRequest.
>
> The goal of this change is to remove the dependency of
> content/browser/loader on the rest of content/browser in particular
> here, removing the use of c/b/host_zoom_map_impl.h in
> content/browser/loader/async_resource_handler.cc.
>
> BUG=598073,609607
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911
> Cr-Commit-Position: refs/heads/master@{#394547}
[email protected],[email protected],[email protected],[email protected],[email protected]
BUG=598073,609607,614348,613979
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2007203002
Cr-Commit-Position: refs/heads/master@{#395761}
(cherry picked from commit 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b)
Review URL: https://codereview.chromium.org/2020633003 .
Cr-Commit-Position: refs/branch-heads/2743@{#111}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Ensure observers are notified when an image fails to decode.
BUG=610990
TEST=http/tests/images/restyle-decode-error.html
Review-Url: https://codereview.chromium.org/2009103002
Cr-Commit-Position: refs/heads/master@{#396000}
(cherry picked from commit cbab5f331081a48a4a43a5104b80e5880bf874b9)
Review URL: https://codereview.chromium.org/2014333004 .
Cr-Commit-Position: refs/branch-heads/2743@{#110}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to M52: Update suffix definition in histograms.xml
BUG=615233
Review-Url: https://codereview.chromium.org/2015093002
Cr-Commit-Position: refs/heads/master@{#396526}
(cherry picked from commit f3177f14d4b0cba1228475c3eca0f2417925fb47)
Review URL: https://codereview.chromium.org/2017063004 .
Cr-Commit-Position: refs/branch-heads/2743@{#109}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Domain Reliability: Add a few more Google domains.
BUG=613648
Review-Url: https://codereview.chromium.org/1995393002
Cr-Commit-Position: refs/heads/master@{#395122}
(cherry picked from commit 62bfd35632dadeee692658c8eef6fa375d760b20)
Review URL: https://codereview.chromium.org/2015393002 .
Cr-Commit-Position: refs/branch-heads/2743@{#108}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Explicitly set modification_date when loading server entries from db.
Fixes an issue where the modification_date on server cards and profiles
is always set to base::Time::Now().
BUG=614803
Review-Url: https://codereview.chromium.org/2008253003
Cr-Commit-Position: refs/heads/master@{#396229}
(cherry picked from commit 914445df51cdeae9a867061c32e3b9bbe8784078)
Review URL: https://codereview.chromium.org/2011423003 .
Cr-Commit-Position: refs/branch-heads/2743@{#107}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add metrics for the height of the Ash system menu
Adds two histograms to collect data on the Ash
system menu, recorded each time the system menu
is opened.
* Ash.SystemMenu.Rows: the number of user-visible
rows in the system menu.
* Ash.SystemMenu.PercentageOfWorkAreaHeightCoveredByMenu:
a ratio of the menu's height to the height of the
desktop work area, which indicates how much (if any)
of the menu appears off-screen.
BUG=612982
TEST=manual
Review-Url: https://codereview.chromium.org/1993043002
Cr-Commit-Position: refs/heads/master@{#395402}
(cherry picked from commit 5fc0591fcbf321a31a4e93b8aaff3cc52f2d4064)
Review URL: https://codereview.chromium.org/2019103002 .
Cr-Commit-Position: refs/branch-heads/2743@{#106}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix printing issue of list item with blank first line
The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed crbug.com/614781 for this.
Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.
BUG=614262
TEST=printing/list-item-with-empty-first-line.html
Review-Url: https://codereview.chromium.org/2011863005
Cr-Commit-Position: refs/heads/master@{#396046}
Review URL: https://codereview.chromium.org/2020733002 .
Cr-Commit-Position: refs/branch-heads/2743@{#105}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Clear local Google Payments data when sync is turned off.
Android has a unique functionality of turning off sync entirely without
signing out the user. This can be accomplished in two places:
1) Chrome Settings -> <username> -> Sync -> Sync (toggle)
2) Android Settings -> Accounts -> Google -> Chrome (toggle)
The switches are tied together. When either one of them is switched off,
Chrome stops syncing, as if it's shutting down. Typically, synced data
remains on disk when sync is shut off. Google Payments data is
special---it stays on disk when Chrome is shutting down, but should be
erased in the following situations:
* User signs out
* Users turns off autofill sync
* Users turns off Google Payments sync
* Users turns off sync
The last situation is possible only on Android and is not currently
being handled. This patch handles the last situation by checking
SyncService::CanSyncStart() in
AutofillWalletDataTypeController::StopModels().
This patch adds several Android sync tests and cleans up existing tests
(remove some unused variables, remove exceptions that are not being
thrown).
BUG=611507
Review-Url: https://codereview.chromium.org/1983523002
Cr-Commit-Position: refs/heads/master@{#395356}
(cherry picked from commit 66ac17211c96e3dd930b069245b6ef4e38416de3)
Review URL: https://codereview.chromium.org/2021503002 .
Cr-Commit-Position: refs/branch-heads/2743@{#104}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of Make push notifications register KeepAlives
(patchset #15 id:360001 of
https://codereview.chromium.org/1849153003/ )
Reason for revert:
Caused crashes: https://crbug.com/612815.
Reopening the browser from a notification unregisters
the notification's keepalive before creating the new
browser window, so we get in situations where we try
opening a new browser while the shutdown sequence is
started.
Original issue's description:
> [bgmode] Make push notifications register KeepAlives
>
> A KeepAlive is now registered in the following cases:
> a) There is an in-flight push message
> b) A Notification is being shown by the message center
>
> That will happen on all platforms supporting Chrome's
> background mode.
>
> BUG=585080
>
> Committed: https://crrev.com/f43094f56012798a8bb0144b0e17076abc8c8dd0
> Cr-Commit-Position: refs/heads/master@{#394194}
[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true
BUG=612815
patch from issue 2020563003 at patchset 1 (http://crrev.com/2020563003#ps1)
Review-Url: https://codereview.chromium.org/2016393002
Cr-Commit-Position: refs/branch-heads/2743@{#103}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Set PointerType of pointer event on Windows.
Pointer event's PointerType did not set on Windows for mouse type when converting from
ui::MouseEvent to blink::WebMouseEvent.
In WebMouseEventBuilder::Build for Windows, I set the pointer type of WebMouseEvent.
BUG=605639
Review-Url: https://codereview.chromium.org/1993853002
Cr-Commit-Position: refs/heads/master@{#395999}
(cherry picked from commit 8a78e7138f7fce8ce8bfe75803bbf8c33877da9a)
Review URL: https://codereview.chromium.org/2016383002 .
Cr-Commit-Position: refs/branch-heads/2743@{#102}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Abort sign in if the sign in flow activity was set but no longer visible to the user
The root cause of the below bug: onSaveInstanceState is called when Activity is stopped, after that we can not attach Fragment to it.
BUG=615129
(cherry picked from commit 4ef6f1a97fcca34d88de124bda55e0ad4cee5277)
Review-Url: https://codereview.chromium.org/2013283002
Cr-Original-Commit-Position: refs/heads/master@{#396456}
Cr-Commit-Position: refs/branch-heads/2743@{#101}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix compilation following 49083218d46b483702105b58535db233ecaed922
BUG=615367
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/2018953002 .
Cr-Commit-Position: refs/branch-heads/2743@{#100}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[NTP Snippets] Make NTPSnippetService listen to sync state changes
This allows to reliably communicate the event to the UI and keep
them in sync in a centralized way.
This CL handles sync changes by clearing the displayed snippets
when History Sync is disabled.
BUG=608913
Review-Url: https://codereview.chromium.org/1985143002
Cr-Commit-Position: refs/heads/master@{#395135}
(cherry picked from commit 0fb812618f5ac933b00cb62f4a2a2b683eeae671)
Review URL: https://codereview.chromium.org/2017013003 .
Cr-Commit-Position: refs/branch-heads/2743@{#99}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add metrics for permission prompt acceptance / denial
BUG=603384
Review-Url: https://codereview.chromium.org/1977693003
Cr-Commit-Position: refs/heads/master@{#395800}
(cherry picked from commit 9961477c3819f4fd2ed3ec597287aee83957d709)
Review URL: https://codereview.chromium.org/2017873002 .
Cr-Commit-Position: refs/branch-heads/2743@{#98}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.12
Cr-Commit-Position: refs/branch-heads/2743@{#97}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.11
Cr-Commit-Position: refs/branch-heads/2743@{#96}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Create a LayerDelegate for recreated layers to draw when their content is invalidated.
This is to mitigate the issue where the content of the layer has to be redrawn while dragging a window in another display. This can draw the display items recorded for different device scale factor which can have artifacts, but it's better than empty layer.
The same issue can happen during hiding/showing animation in theory, but I'm leaving them as is because that's very rare and most likely not noticeable.
BUG=604868
TEST=WindowUtilTest.RecreateLayersWithDelegate
[email protected]
Review-Url: https://codereview.chromium.org/1992853002
Cr-Commit-Position: refs/heads/master@{#394993}
(cherry picked from commit e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25)
Review URL: https://codereview.chromium.org/2020493002 .
Cr-Commit-Position: refs/branch-heads/2743@{#95}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Split Media.Controls.Show in .Video and .Audio.
In order to differentiate metrics coming from audio elements versus
coming from video elements.
BUG=613178
Review-Url: https://codereview.chromium.org/1990313002
Cr-Commit-Position: refs/heads/master@{#395618}
(cherry picked from commit 1c446293173e6c5d20ae437e0b83981907b911c9)
Review URL: https://codereview.chromium.org/2018813002 .
Cr-Commit-Position: refs/branch-heads/2743@{#94}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Adjust location of Import Bookmarks textfield.
This change aligns the baselines of the Import Bookmarks text and book-
mark button text.
[email protected]
BUG=613202
Review-Url: https://codereview.chromium.org/2006053005
Cr-Commit-Position: refs/heads/master@{#396050}
(cherry picked from commit 207cf6c07dcd9e9ebcb518a38668e4a08e286d0c)
Review URL: https://codereview.chromium.org/2020453002 .
Cr-Commit-Position: refs/branch-heads/2743@{#93}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use ChromeLauncherActivity to open bookmarks if componentName unknown
If the user entered the bookmarks manager in an odd way, the component name
usually set on the intent may be null. Send the intent through ChromeLauncherActivity
instead of using the null component name to avoid crashing.
BUG=615012
[email protected]
Review-Url: https://codereview.chromium.org/2011033003
Cr-Commit-Position: refs/heads/master@{#396273}
Review URL: https://codereview.chromium.org/2016133002 .
Cr-Commit-Position: refs/branch-heads/2743@{#92}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[ios] Fixed page lifecycle events for fast backforward navigation.
Fast back-forward navigation is a navigation initiated via
|goToBackForwardListItem| and does not hit network for reading the
response. During fast back-forward navigation within the same URL origin
none of WKNavigationDelegate callbacks are called as a result embedder
did not receive any page lifecycle events.
The only change reported by WKWebView is flipping isLoading flag.
This CL correctly updates navigation type for back-forward navigations
and generates missing lifecycle events when WKWebView.loading property
changed to NO.
BUG=577703
Review-Url: https://codereview.chromium.org/1996203002
Cr-Commit-Position: refs/heads/master@{#395355}
(cherry picked from commit 7186eabceeea2f79670ee2551907b8c4436873c6)
Review URL: https://codereview.chromium.org/2018783002 .
Cr-Commit-Position: refs/branch-heads/2743@{#91}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Enables EXTERNAL_COMPONENT extensions in incognito by default.
Currently, the Media Router is in a broken state in incognito: it can talk to the component via the Mojo API, but access to resources (like the Cast SDK, feedbak, and setup) and tab capture is broken. This enables the component in incognito via the extensions system which resolves these issues.
BUG=606495
Review-Url: https://codereview.chromium.org/1991263003
Cr-Commit-Position: refs/heads/master@{#395758}
(cherry picked from commit 4193cc61735abc6d53edb85021222d5e866c2c6d)
Review URL: https://codereview.chromium.org/2010273002 .
Cr-Commit-Position: refs/branch-heads/2743@{#90}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Manually resize OverlayPanel content
Since the OverlayPanel's ContentViewCore is no longer part of the
hierarchy, size change events are not reveived. This change pushes
those events manually.
BUG=612379
Review-Url: https://codereview.chromium.org/1999043003
Cr-Commit-Position: refs/heads/master@{#395950}
(cherry picked from commit e98391b7c4d52973141444e410cbcb2831186c2c)
Review URL: https://codereview.chromium.org/2011163002 .
Cr-Commit-Position: refs/branch-heads/2743@{#89}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Toolbar is a root layer for the UI compositor
This change converts the toolbar layer into its own SceneOverlay.
The SceneOverlay is created and owned by the layout manager and
is added to all layouts before any of the other SceneOverlays.
Doing this places the layer in the content tree.
BUG=612085, 614268
Review-Url: https://codereview.chromium.org/1988023010
Cr-Commit-Position: refs/heads/master@{#396209}
(cherry picked from commit 0c9e11ddad202a35e5b99b2871fe8cc1e5acbc40)
Review URL: https://codereview.chromium.org/2015013002 .
Cr-Commit-Position: refs/branch-heads/2743@{#88}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to 2743] Revert "[Reland 2] Pepper takes ownership of a mailbox before passing it to the texture layer."
The CL has at least one bug, so reverting it from 2743 is the safest course of
action.
BUG=611016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected], [email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/2012303002 .
Cr-Commit-Position: refs/branch-heads/2743@{#87}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Simplify representation of off the record routes in UI.
- Removes offTheRecord field from Route objects in UI. They are unused.
- Removes offTheRecord field from MediaRouterContainer. Instead of
sending the full controller URL for each route to the UI and not show
the controller when we see the container is OTR, we scrub out the the
controller URL before sending the route over to the UI. This also fixes
the issue with broken controller UI in incognito (which was previously
fixed in M51 but regressed in M52).
- We don't need to scrub out the custom controller path in the route
response. It's better to scrub it out in MediaRouterWebUIMessageHandler
so that we can cover the updated route list case as well.
This needs to be in M52.
BUG=590376
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2007653002
Cr-Commit-Position: refs/heads/master@{#395755}
(cherry picked from commit 0077962d346e9e5d1aa68ddedf540694671db103)
Review URL: https://codereview.chromium.org/2012263003 .
Cr-Commit-Position: refs/branch-heads/2743@{#86}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Extensions] Determine NativeMessaging ID solely on the browser process
No need to trust renderers here. We really should do this in more places.
BUG=609286
Review-Url: https://codereview.chromium.org/2006013002
Cr-Commit-Position: refs/heads/master@{#395708}
(cherry picked from commit 364adab6eb1e5d928ddd18ed12c9b2a6338c4d71)
Review URL: https://codereview.chromium.org/2014893003 .
Cr-Commit-Position: refs/branch-heads/2743@{#85}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use Notification#setSubText() instead of setContentInfo() for N
The latter call is not preferred in N.
Cannot use setSubText() on Devices <=N due to setProgress()
[email protected]
BUG=602251
Review-Url: https://codereview.chromium.org/2002313002
Cr-Commit-Position: refs/heads/master@{#395455}
(cherry picked from commit c64e03690e999ac6e325e6e181ecaa6ed1ab6358)
Review URL: https://codereview.chromium.org/2011133002 .
Cr-Commit-Position: refs/branch-heads/2743@{#84}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix a crash when download a DRM file through context menu
This is a regression introduced by
https://codereview.chromium.org/1717783002.
Previously we use URLUtil.guessFileName() to generate file names for
download.
However, to fix crbug/570750, we rely on the native code to pass the
file name.
However, drm download through context menu bypasses the native download
code.
As a result, we need to generate the file name in Java if it is null.
Since content disposition is null, this will not cause the same problem
as reported in crbug/570750.
[email protected]
BUG=608258
Review-Url: https://codereview.chromium.org/2013643002
Cr-Commit-Position: refs/heads/master@{#395750}
(cherry picked from commit 4e33c5d6978752f31ed6702e72e46fdf78cd5565)
Review URL: https://codereview.chromium.org/2016783002 .
Cr-Commit-Position: refs/branch-heads/2743@{#83}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[remoting host] Fix the APT repository setup in the Debian package.
This adds the [arch=] qualifier to the APT sources.list entry for
Chrome Remote Desktop, so that APT no longer reports an error for the
missing 32-bit package. This also corrects a regex used for detecting
the current configuration.
BUG=604469
Review-Url: https://codereview.chromium.org/2011643002
Cr-Commit-Position: refs/heads/master@{#395748}
(cherry picked from commit 20447ead8ba4b9bf3310da0d80a23a199aba1d60)
Review URL: https://codereview.chromium.org/2015973002 .
Cr-Commit-Position: refs/branch-heads/2743@{#82}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
content: Not all memory creation failures are out of memory errors.
It is possible that the child process is shutting down, and the failure is
expected.
BUG=585013
Review-Url: https://codereview.chromium.org/2010563004
Cr-Commit-Position: refs/heads/master@{#395996}
(cherry picked from commit 4e01cbe3db01f86ee5ef3c5acdd84d261501faef)
Review URL: https://codereview.chromium.org/2011093002 .
Cr-Commit-Position: refs/branch-heads/2743@{#81}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge M52][net/auth] Disable use of channel bindings on Posix.
We ran into interoperability issues on Mac OS X clients and MIT Kerberos
servers. (See bug for details). Out of an abundance of caution, we are
reverting to pre M51 behavior for Posix platforms.
[email protected]
BUG=611728
Review-Url: https://codereview.chromium.org/2002063005
Cr-Commit-Position: refs/heads/master@{#395675}
(cherry picked from commit ccb5d4fc7a7e1045bd11fa7710879d4a6df850ed)
Review URL: https://codereview.chromium.org/2014183004 .
Cr-Commit-Position: refs/branch-heads/2743@{#80}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Consistently refer to issue's learn more help page by ID.
When users click on "learn more" on an issue, there should be a new tab opened to the "learn more" link. Currently, some parts of Media Router assume that an Issue keeps track of a URL, whereas other places assume that it keeps track of the help page ID, which would later be concat'd to a help center URL prefix. This mismatch breaks the "learn more" link for any issues created in the extension.
This change makes Issues consistently refer to the help page ID.
Also fix presubmit warnings.
BUG=613242
Review-Url: https://codereview.chromium.org/1993373002
Cr-Commit-Position: refs/heads/master@{#395615}
(cherry picked from commit e68cd12ddd2fcc30c317c5725a5349ba0524be34)
Review URL: https://codereview.chromium.org/2014903002 .
Cr-Commit-Position: refs/branch-heads/2743@{#79}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Simplify notification of a dirty listener.
Instead of the listener updating the dirty state of all panners, just
set a dirty state flag in the listener. Then, when a panner needs
to compute a new azimuth/elevation gain or cone gain, the panner
just checks to see if the listener is dirty.
This gets rid of the data race where both the audio thread and the
main thread are updating the dirty state of a panner. The checking
and setting of the listener state happens on the audio thread.
The race from reading from the hash table of panners in AudioListener
and adding to the table from the main thread is also removed.
BUG=612948, 612955, 613332
TEST=none
Review-Url: https://codereview.chromium.org/2006563003
Cr-Commit-Position: refs/heads/master@{#395738}
(cherry picked from commit a6beb9f31fba1c7892fbfb4911f34e5a13492183)
Review URL: https://codereview.chromium.org/2012773005 .
Cr-Commit-Position: refs/branch-heads/2743@{#78}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Touch scrolling on Wacom tablet is jittery on Mac OSX
Wacom tablets indicate high precision events but don't generate
phase information. The two were tied together for elastic overscroll
on OSX when we moved to using gestures for wheel events.
Add another bit to GestureScrollBegin which indicates the gesture
in fact the device generates inertial phase information.
BUG=610841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
[email protected]
Review-Url: https://codereview.chromium.org/1988053004
Cr-Commit-Position: refs/heads/master@{#395752}
(cherry picked from commit cd3d0eda96dfda663b762517936e54ea7a2b6ece)
Review URL: https://codereview.chromium.org/2011013002 .
Cr-Commit-Position: refs/branch-heads/2743@{#77}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[merge-m52] Avoid clobbering the app list pinned taskbar shortcut on startup (for now).
This is a partial revert of r393415 which removed checking for
--show-app-list from shell_integration_win.cc's GetExpectedAppId(). This
meant that the expected app_id for app launcher shortcuts would now be
the same as regular Chrome.
MigrateTaskbarPinsCallback() then successfully updates the app_id for
the existing App Launcher shortcut, but Windows immediately sees 2
pinned apps for the same app_id and clobbers one of them.
To fix, we need to keep the old app_id around for a bit longer. The
shortcuts will be removed properly in a later milestone (from the
taskbar as well as other places which are not currently clobbered by
coincidence).
BUG=613789
Review-Url: https://codereview.chromium.org/2005163002
Cr-Commit-Position: refs/heads/master@{#395785}
(cherry picked from commit c2c690ab31976ed7bd715709606f736085d6b43e)
Review URL: https://codereview.chromium.org/2012843004 .
Cr-Commit-Position: refs/branch-heads/2743@{#76}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Roll libxml to 8effcb578e0590cc01bbcab0f9dccefc6bdbcdbd
BUG=611953
Review-Url: https://codereview.chromium.org/1994003003
Cr-Commit-Position: refs/heads/master@{#395024}
(cherry picked from commit 1809440f3119353a14bbe1b4b1500c817c2710ce)
Review URL: https://codereview.chromium.org/2015833002 .
Cr-Commit-Position: refs/branch-heads/2743@{#75}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Update cached height for popup notifications after shelf alignment changes
This patch fixes the misaligned notification issue. See the bug for detail.
BUG=606808
TEST=manual tested
Review-Url: https://codereview.chromium.org/2000303003
Cr-Commit-Position: refs/heads/master@{#395795}
(cherry picked from commit 331d88b5161e3c77e302722198bd4bf9180bd5a4)
Review URL: https://codereview.chromium.org/2012183002 .
Cr-Commit-Position: refs/branch-heads/2743@{#74}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
media: Not register MediaClientAndroid in GPU process in in-process mode.
When running the GPU process in-process (in the browser process), we
already have the client registered in the browser prcess in
ChromeBrowserMainPartsAndroid::PreMainMessageLoopRun(). Therefore we
don't need to set it again (which will actually cause a DCHECK).
In the future we should probably have a better way to set this
instead of using a process global variable.
BUG=609905
TEST=Tested with --in-process-gpu flag.
Review-Url: https://codereview.chromium.org/2013683002
Cr-Commit-Position: refs/heads/master@{#395805}
(cherry picked from commit ded3b6e93f4f36cd0facd001a0de884e655c4298)
Review URL: https://codereview.chromium.org/2015813002 .
Cr-Commit-Position: refs/branch-heads/2743@{#73}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Devtools Color: Basic support for #RRGGBBAA and #RGBA
BUG=611687
Review-Url: https://codereview.chromium.org/1986053004
Cr-Commit-Position: refs/heads/master@{#395801}
(cherry picked from commit 97c7757e7ae143f63e5d7281d1a9837338b12562)
Review URL: https://codereview.chromium.org/2013003002 .
Cr-Commit-Position: refs/branch-heads/2743@{#72}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix WebView not to hide soft keyboard on navigation
We were calling ImeAdapter#reset() (now renamed as resetAndHideKeyboard)
whenever navigation occurred. This change was introduced in
https://codereview.chromium.org/1278593004 .
However, there are cases, e.g. email client using WebView, where we don't
want the behavior. (b/27547367)
We will still call resetAndHideKeyboard() when renderer process is gone
as a safety net for ImeThread feature, and hide keyboard through
updateKeyboardVisibility() function.
BUG=601707
Review-Url: https://codereview.chromium.org/2001983002
Cr-Commit-Position: refs/heads/master@{#395535}
(cherry picked from commit cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c)
Review URL: https://codereview.chromium.org/2013983003 .
Cr-Commit-Position: refs/branch-heads/2743@{#71}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.10
Cr-Commit-Position: refs/branch-heads/2743@{#70}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix compile failure on official builder.
A recent patch used the new OwnPtr::reset() method. This change uses
clear() instead, which is the same thing.
BUG=614883
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/2009123004 .
Cr-Commit-Position: refs/branch-heads/2743@{#69}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
QUIC - added disable_delay_tcp_race field trial param to disable
delaying of racing TCP connection.
When this param is set to true, TCP and QUIC connections will be raced
without any delay.
BUG=613259
[email protected]
Review-Url: https://codereview.chromium.org/1998863002/#ps20001
Cr-Commit-Position: refs/heads/master@{#395688}
(cherry picked from commit 977b13bbcc96e7dd1cf500909e29c677e8257776 Patch Set 2 of 1998863002)
Review URL: https://codereview.chromium.org/2009403002 .
Cr-Commit-Position: refs/branch-heads/2743@{#68}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Touch to Search] Fixes Peek Promo regression.
This a regression caused by:
https://codereview.chromium.org/1716653002/
Prior to the regression, when Touch to Search Bar was
peeking and the Peek Promo was showing, touching on the
base page and dragging would cause the base page to scroll,
causing the Bar to be dismissed.
The regression broke this behavior and now when the Peek
Promo is showing, trying to scroll the base page will
actually cause the Touch to Search Panel to be dragged.
This is bad because scrolling is one of the most common
ways of dismissing the Panel.
The problem was that the OverlayPanel was miscalculating
the height of the Bar, not taking into consideration the
height of the Peek Promo. This CL fixes this behavior.
BUG=613235
Review-Url: https://codereview.chromium.org/2006653004
Cr-Commit-Position: refs/heads/master@{#395992}
(cherry picked from commit e30f30bc39902fd29edd9ce950302d0e77f6a4cd)
Review URL: https://codereview.chromium.org/2015593003 .
Cr-Commit-Position: refs/branch-heads/2743@{#67}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.9
Cr-Commit-Position: refs/branch-heads/2743@{#66}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Crash fix: Eliminate duplicate content::MediaStreamSource dtor call.
The root cause was due to a change where MediaStreamVideoCapturerSource
inherited from content::RenderFrameObserver. The default behavior of
RenderFrameObserver is to auto-detruct when the RenderFrame is
destroyed. This resulted in destruction of MSVideoCapturerSource twice:
Once when the RenderFrame was destroyed, and again later when the blink
GC ran a sweep to trigger the second (intended) destruction.
To be clear, the MediaStreamVideoCapturerSource is meant to be owned by
blink::MediaStreamSource, and so it's appropriate for it to be destroyed
at the time the blink GC sweeps the owner object.
This change also restores the use of the pre-finalizer mechanism for
further robustness. This brings the "extra data" implementation of
blink::MediaStreamSource in-line with the known-good one of
blink::MediaStreamComponent.
BUG=612084
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2013993002
Cr-Commit-Position: refs/heads/master@{#396039}
(cherry picked from commit c9ae1f2a233423a4afd802482156878cf458ad20)
Review URL: https://codereview.chromium.org/2010033002 .
Cr-Commit-Position: refs/branch-heads/2743@{#65}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "SELECT popup: Do not update popup content for arbitrary attribute change." to M52.
In the site of crbug.com/615250, mousedown event handler for a SELECT element sets
and deletes id attribute of the SELECT element. We shouldn't try to update popup
content in such case.
BUG=614250
Review-Url: https://codereview.chromium.org/2012653002
Cr-Commit-Position: refs/heads/master@{#395818}
(cherry picked from commit 194ad8e687efc243d3b836a648697aaab394fbf0)
Review URL: https://codereview.chromium.org/2012943002 .
Cr-Commit-Position: refs/branch-heads/2743@{#64}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[2743] [Payments] Fix animation
Make the FocusAnimator request a layout once the
animation completes to put things in the right place.
BUG=603635
TBR=twellington
Review-Url: https://codereview.chromium.org/2008953004
Cr-Commit-Position: refs/heads/master@{#395939}
Review URL: https://codereview.chromium.org/2006803007 .
Cr-Commit-Position: refs/branch-heads/2743@{#63}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Make sure WebRtcAudioSink's fifo always uses 10ms buffers. The documentation is correct in that it talks about 10ms buffers being required but the implementation doesn't ensure that the buffer is always of that size.
BUG=613482
Review-Url: https://codereview.chromium.org/2004853002
Cr-Commit-Position: refs/heads/master@{#395320}
(cherry picked from commit 5b300dc6fa357d7aff10f728c359d52e76cdae62)
Review URL: https://codereview.chromium.org/2005403004 .
Cr-Commit-Position: refs/branch-heads/2743@{#62}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to M52: Ensure LegacyRenderWidgetHostHWND is always created.
Previously, LegacyRenderWidgetHostHWND was only created inside
RenderWidgetHostViewAura::InternalSetBounds, and only if the parent
HWND was known. However, under some circumstances, InternalSetBounds
only gets called once and it gets called *before* the aura Window is
attached, so the legacy win never gets created.
Fix it by also trying to create the legacy win in
RWHVA::AddedToRootWindow().
BUG=613336
Review-Url: https://codereview.chromium.org/1996163002
Cr-Commit-Position: refs/heads/master@{#395649}
(cherry picked from commit a7e78f6f5d453c52313b74de10c5f680aa3d5ee3)
Review URL: https://codereview.chromium.org/2006053006 .
Cr-Commit-Position: refs/branch-heads/2743@{#61}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[M-52] Close bitstream buffer shared memory handles on Android.
AndroidVideoDecodeAccelerator would clear references to pending
bitstream buffers in ::Reset and, implicitly, in the destructor.
However, each of those may have a file descriptor for shared memory
that isn't closed. During a seek, for example, this can cause leaks.
This CL wraps the queue of pending bitstream buffers with a new
BitstreamRecord type, which has a unique_ptr to the (unmapped)
shared memory region, if any. This will automatically close the
underlying handle when the unique_ptr is released. Note that no
expensive operation is performed in creating the shared memory
region. Unless it is later mapped, it just keeps the handle
and ::close()s it on destruction.
This is a merge of https://codereview.chromium.org/2011653002 .
BUG=614489
TEST=observed /proc/fd/[gpu process] while seeking in a video
NOPRESUBMIT=true
NOTRY=true
[email protected]
Review-Url: https://codereview.chromium.org/2008373003
Cr-Commit-Position: refs/branch-heads/2743@{#60}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix size calculation for GoogleUpdate.InfoBar.InternalStorageSizeAvailable
It was casting to int prematurely leading to overflow and wrong values.
Now casts once converted to MB which is far less likely to overflow.
BUG=517839
[email protected]
Review-Url: https://codereview.chromium.org/2014433003
Cr-Commit-Position: refs/heads/master@{#395898}
(cherry picked from commit ab43e12d6bdde387217427bdbae367c81d7bd137)
Review URL: https://codereview.chromium.org/2015683002 .
Cr-Commit-Position: refs/branch-heads/2743@{#59}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Show issue's secondary action when 'dismiss'.
The action type 'dismiss' maps to 0. Currently, we don't check whether it's undefined, but if it is truthy. if(0) is always false. This means that if the secondary button is 'dismiss', it will not be shown.
This was previously not caught as the tests mark non-existent secondary actions as null rather than undefined.
BUG=613253
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/1998013003
Cr-Commit-Position: refs/heads/master@{#395394}
(cherry picked from commit 8d0894e8a5b6c29e97704a62ca75cc1cb412223d)
Review URL: https://codereview.chromium.org/2014673002 .
Cr-Commit-Position: refs/branch-heads/2743@{#58}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Restore apps page shortcut icon in bookmarks bar.
A recent bookmarks bar change caused the apps page shortcut button to
display a document icon instead of the 9 colored dots icon.
[email protected]
BUG=613458
Review-Url: https://codereview.chromium.org/2007103002
Cr-Commit-Position: refs/heads/master@{#395669}
(cherry picked from commit 4faf1132c3d418b065d5600b8ed07f4175b15bfe)
Review URL: https://codereview.chromium.org/2008403002 .
Cr-Commit-Position: refs/branch-heads/2743@{#57}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Change POST-exclusion to idempotent-inclusion
The data saver proxy should only be used for idempotent methods, but
right now it only checks if the method is POST, which leaves out
other non-idempotent methods like PATCH. Instead of excluding POST and
PATCH, this will explicitly check if the method is GET, OPTIONS, HEAD,
PUT, DELETE, or TRACE.
BUG=614078
Review-Url: https://codereview.chromium.org/2001243002
Cr-Commit-Position: refs/heads/master@{#395502}
(cherry picked from commit fbc93e59b496ff6ea423527d1a3579fa8a2d061c)
Review URL: https://codereview.chromium.org/2013763003 .
Cr-Commit-Position: refs/branch-heads/2743@{#56}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Mac][Material Design] Adjust tabstrip Incognito, non-vibrant bg color.
[email protected]
BUG=595502
Review-Url: https://codereview.chromium.org/1992193003
Cr-Commit-Position: refs/heads/master@{#395089}
(cherry picked from commit 74a440eaf0d6a6e6c1c0e1e59365c080e038b113)
Review URL: https://codereview.chromium.org/2010813002 .
Cr-Commit-Position: refs/branch-heads/2743@{#55}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[DurableStorage] Change navigator.storage from RuntimeEnabled to OriginTrialEnabled
BUG=610500
Review-Url: https://codereview.chromium.org/2003763002
Cr-Commit-Position: refs/heads/master@{#395616}
(cherry picked from commit b65341702d2c1210a9385a7c6d4e1f244d023c70)
Review URL: https://codereview.chromium.org/2006903006 .
Cr-Commit-Position: refs/branch-heads/2743@{#54}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.8
Cr-Commit-Position: refs/branch-heads/2743@{#53}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Offline Pages: Add NULL-checks for when the model is NULL (incognito mode)
Recently offline pages was changed to be completely disabled in
incognito profiles, since it is no longer associated with bookmarks, so
some consumers failed to check for null.
BUG=613359
Review-Url: https://codereview.chromium.org/2004473002
Cr-Commit-Position: refs/heads/master@{#395422}
(cherry picked from commit 261c816b0900eec6c3b41277288ccd4020c23f5d)
Review URL: https://codereview.chromium.org/2007113007 .
Cr-Commit-Position: refs/branch-heads/2743@{#52}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Delay PersistentHistogramAllocator creation until it's known to be used.
Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.
BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner
Review-Url: https://codereview.chromium.org/1996843002
Cr-Commit-Position: refs/heads/master@{#395101}
(cherry picked from commit 374d5fe463635dd811d452649b34c6efc578f860)
Review URL: https://codereview.chromium.org/2014543002 .
Cr-Commit-Position: refs/branch-heads/2743@{#51}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Improve console message about deferring long-running timers.
BUG=574343
Review-Url: https://codereview.chromium.org/1997413002
Cr-Commit-Position: refs/heads/master@{#395341}
(cherry picked from commit 097f2cb6d4af73a27d0456a97bf5053f7f7db913)
Review URL: https://codereview.chromium.org/2009793003 .
Cr-Commit-Position: refs/branch-heads/2743@{#50}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add separate UMA histograms for the account chooser with 1/many accounts.
BUG=612501
Review-Url: https://codereview.chromium.org/2002643002
Cr-Commit-Position: refs/heads/master@{#395556}
(cherry picked from commit d7185e01e17811c2e0beafdb88bcc0ad0d286e57)
Review URL: https://codereview.chromium.org/2012723002 .
Cr-Commit-Position: refs/branch-heads/2743@{#49}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Added strings for notification when user presses backspace.
These will be used in a future CL
(https://codereview.chromium.org/1983803002). The strings are being
checked in early to ensure they are in before branch point.
Notry rationale: Tree is broken due to https://crbug.com/613258. All
other tests have passed on trybots.
BUG=610039
NOTRY=true
Review-Url: https://codereview.chromium.org/1995893002
Cr-Commit-Position: refs/heads/master@{#394968}
(cherry picked from commit 8386be414ec1537ad2c033889996f2419b330c42)
Review URL: https://codereview.chromium.org/2009503004 .
Cr-Commit-Position: refs/branch-heads/2743@{#48}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix crash during layout because of text autosizing
Text autosizing may change style of an object, causing problem of code
like the following:
const ComputedStyle& style = object.styleRef();
// This may call text autosizing which changes style of the object.
computeChildPreferredLogicalWidth(object, ...);
// This may reference a deleted object.
style.anyMethod();
TextAutosizer has a mechanism to hold references to the old styles to
avoid problem of raw pointers/references, but the scope seems not big
enough to cover the case of the bug.
BUG=613917
Review-Url: https://codereview.chromium.org/2000423003
Cr-Commit-Position: refs/heads/master@{#395792}
Review URL: https://codereview.chromium.org/2007683005 .
Cr-Commit-Position: refs/branch-heads/2743@{#47}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.7
Cr-Commit-Position: refs/branch-heads/2743@{#46}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add null checks for NodeEventContext::node() and WindowEventContext::window().
Fix a regressino by crrev.com/393784.
This CL has no tests because the code will be removed in a few stable releases.
BUG=613752
Review-Url: https://codereview.chromium.org/1997273002
Cr-Commit-Position: refs/heads/master@{#395528}
(cherry picked from commit 4565f73d4d2e07d7c961e1572a7002aaa24c510d)
Review URL: https://codereview.chromium.org/2013643003 .
Cr-Commit-Position: refs/branch-heads/2743@{#45}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Check subtree paint invalidation when overflow clip status changes
Before https://crrev.com/392652 because we included descendant overflow
into container overflow and the paint invalidation rect covered the
changed part of descendants.
Call setNeedsPaintInvalidationSubtree() to force checking of paint
invalidation of descendants when overflow clip status changes.
The other changes are needed because we need to move
clearPaintInvalidationFlags() after
newPaintInvalidationState.updateForChildren().
Several overriding invalidateTreeIfNeeded() methods in subclasses are
removed because they have been the same as inherited ones after we
changed the paint invalidation tree walk order.
BUG=613475
TEST=paint/invalidation/overflow-hidden-to-visible.html
TEST=paint/invalidation/overflow-visible-to-hidden.html
Review-Url: https://codereview.chromium.org/2000763003
Cr-Commit-Position: refs/heads/master@{#395491}
Review URL: https://codereview.chromium.org/2007003003 .
Cr-Commit-Position: refs/branch-heads/2743@{#44}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
ChannelMojo: Don't signal Channel errors with lock held
This eliminates a lock-order inversion between ChannelMojo
and SyncMessageFilter.
BUG=611338
[email protected]
Review-Url: https://codereview.chromium.org/2000213002
Cr-Commit-Position: refs/heads/master@{#395483}
(cherry picked from commit 06325bce94fafdd8df10ab1d41723a5a36587e0d)
Review URL: https://codereview.chromium.org/2013673002 .
Cr-Commit-Position: refs/branch-heads/2743@{#43}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Cherry-picking hangouts.google.com whitelisting change into M52.
Urgent: whitelist hangouts.google.com further (should've been done in issue 1552383002 from Dec 2015, but...) to allow video effects plugin access; tag on meet.google.com for a similar purpose; tax: refactor whitelist checks into separate thing.
[email protected],[email protected]
BUG=614062
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/1974413003
Cr-Commit-Position: refs/heads/master@{#395172}
(cherry picked from commit 81dcbd6123178d58c5edc53d1453e03f9afa31ca)
Review-Url: https://codereview.chromium.org/2011623002
Cr-Commit-Position: refs/branch-heads/2743@{#42}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add UMA metric for tracking root level listeners for blocking touch.
Adjust histogram to capture on each phase of targeting the event instead
of the old histogram which targeted only where the event handler was
registered.
BUG=604790
Review-Url: https://codereview.chromium.org/1980113002
Cr-Commit-Position: refs/heads/master@{#394982}
(cherry picked from commit 05f9fdad56cd5018c8fb31f1866b232d7444f796)
Review URL: https://codereview.chromium.org/2007733003 .
Cr-Commit-Position: refs/branch-heads/2743@{#41}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Sync] Show "Setup in progress..." if sync is not yet active.
BUG=614177
Review-Url: https://codereview.chromium.org/2006143002
Cr-Commit-Position: refs/heads/master@{#395512}
(cherry picked from commit 2a818f54130d8c93f81490adce5a1e87307bf5f0)
Review URL: https://codereview.chromium.org/2011583002 .
Cr-Commit-Position: refs/branch-heads/2743@{#40}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[remoting android] Update Play Store what's-new text.
Review-Url: https://codereview.chromium.org/1991383003
Cr-Commit-Position: refs/heads/master@{#394964}
(cherry picked from commit ffeff994979fcbf416bfd36072548cbbb989627f)
BUG=614217
Review URL: https://codereview.chromium.org/2004063005 .
Cr-Commit-Position: refs/branch-heads/2743@{#39}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
New Tab Page: Work around potentially long delays if model is not loaded.
This avoids querying for offline pages if the model is not loaded, so
that the maximum possible delay is minimal (once the model is loaded,
all pages are stored in memory).
Additionally checks for null when obtaining the offline page model.
BUG=607573,613359
Review-Url: https://codereview.chromium.org/1982483002
Cr-Commit-Position: refs/heads/master@{#395096}
(cherry picked from commit 9a12ce07eb8c36407ae27beba7b2082229cf5678)
Review URL: https://codereview.chromium.org/2007563005 .
Cr-Commit-Position: refs/branch-heads/2743@{#38}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[mojo-edk] Add some buffer checks and fix UAF on NodeChannel
Adds message sanity checks at the dispatcher layer for
message and data pipes.
Also eliminates potential UAFs on NodeChannel by ensuring
it stays alive through any delegate calls which might have
otherwise deleted it.
BUG=613698
Review-Url: https://codereview.chromium.org/2004763002
Cr-Commit-Position: refs/heads/master@{#395373}
(cherry picked from commit 99a83d5bc1df0c4d6d660dedf45c9b0e14a9df3f)
Review URL: https://codereview.chromium.org/2007943003 .
Cr-Commit-Position: refs/branch-heads/2743@{#37}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.6
Cr-Commit-Position: refs/branch-heads/2743@{#36}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to 2743] Un-Blacklist rooksbas.dll in sandboxed processes.
Blacklisting rooksbas.dll from only the renderer process causes full browser
hangs.
BUG=609262
[email protected]
Review URL: https://codereview.chromium.org/2010513003 .
Cr-Commit-Position: refs/branch-heads/2743@{#35}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.5
Cr-Commit-Position: refs/branch-heads/2743@{#34}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Instrumentation for helping to root-cause MSSource destructor crashes.
Disables optimizations and inlining of certain destructors where the
crash may be occurring. Also adds some "canary" data members to
determine whether memory-stomping is occurring, or destruction is
happening more than once. This all should provide more actionable crash
report data.
This change is temporary, and will be reverted once the root-cause is
identified (see bug for details).
BUG=612084
[email protected],[email protected],[email protected]
Review-Url: https://codereview.chromium.org/2006183002
Cr-Commit-Position: refs/heads/master@{#395574}
(cherry picked from commit 44dfd56360b76fcefa84a65b0f77aaeef7842894)
Review URL: https://codereview.chromium.org/2007803004 .
Cr-Commit-Position: refs/branch-heads/2743@{#33}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of Add a pre-finalizer to MediaStreamSource (patchset #2 id:20001 of https://codereview.chromium.org/1972873003/ )
Reason for revert:
Per discussion in the crbug, we're going to revert these speculative fixes to remove unknowns from further root-cause analysis on the crashes.
https://crbug.com/612084#c38
Original issue's description:
> Add a pre-finalizer to MediaStreamSource
>
> This is a speculative fix for bug 611585 and 611618.
> It looks like that there is a path where ~ExtraData() touches other eagerly-finalized objects.
> So this CL moves the logic to a pre-finalizer.
>
> BUG=611585,611618
>
> Committed: https://crrev.com/8a83e747b7786d85295875ea8fe19270e9b96c5a
> Cr-Commit-Position: refs/heads/master@{#393471}
[email protected],[email protected],[email protected],[email protected]
BUG=611585,611618
Review-Url: https://codereview.chromium.org/2001363002
Cr-Commit-Position: refs/heads/master@{#395571}
(cherry picked from commit 979dff3339e912e4735a65b3776fa0de041930d2)
Review URL: https://codereview.chromium.org/2006283002 .
Cr-Commit-Position: refs/branch-heads/2743@{#32}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Revert of MediaStreamSource::setReadyState should not be called during a pre-finalizer (patchset #1 id:1 of https://codereview.chromium.org/1978183002/ )
Reason for revert:
Per discussion in the crbug, we're going to revert these speculative fixes to remove unknowns from further root-cause analysis on the crashes.
https://crbug.com/612084#c38
Original issue's description:
> MediaStreamSource::setReadyState should not be called during a pre-finalizer
>
> This is a speculative fix for bug 612084.
> MediaStreamSource::dispose calls content::MediaStreamSource's destructor,
> which calls MediaStreamSource::RunStopCallbackAndEndStream(),
> which calls MediaStreamSource::setReadyState, which dispatches events.
> It should be avoided.
>
> BUG=612084
>
> Committed: https://crrev.com/1d844dcc68432429c77a04916908121da9ef4ca2
> Cr-Commit-Position: refs/heads/master@{#393837}
[email protected],[email protected],[email protected]
BUG=612084
Review-Url: https://codereview.chromium.org/2003203002
Cr-Commit-Position: refs/heads/master@{#395474}
(cherry picked from commit d8d744da346e953640288c6f90a4fe0a68f3ef3b)
Review URL: https://codereview.chromium.org/2006973003 .
Cr-Commit-Position: refs/branch-heads/2743@{#31}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix a crash in HttpVaryData::MatchesRequests.
crbug.com/469675 remove an implicit Vary: Cookie for redirected
requests. But some cached redirected requests could still have
HttpVaryData::is_valid_ == true.
Therefore some requests could reach a NOTREACHED() in
HttpVaryData::MatchesRequests() because comparing an HTTP request
vary that have a HttpVaryData::Init() now returning false because
no Vary from the request with a previously cached HttpVaryRequest
that have is_valid_ == true.
BUG=611575
Review-Url: https://codereview.chromium.org/2000123002
Cr-Commit-Position: refs/heads/master@{#395317}
(cherry picked from commit 7ec544a858f4dd2b5b3a0ad0949a1f24f55f10b4)
Review URL: https://codereview.chromium.org/2012463002 .
Cr-Commit-Position: refs/branch-heads/2743@{#30}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix potential crash in FrameView::setScrollOffset
There was a code path that was checking if layoutView was non-null yet
there was a code path that used it unconditionally. The unconditional
path seems to match a crash stack. Move the clearHitTestCache
code path into the conditional.
BUG=611683
Review-Url: https://codereview.chromium.org/2004503003
Cr-Commit-Position: refs/heads/master@{#395260}
(cherry picked from commit 715aea1e3a3cd8a91f43390ec4f2166df3753a11)
Review URL: https://codereview.chromium.org/2010513002 .
Cr-Commit-Position: refs/branch-heads/2743@{#29}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix crash in DeviceManagementService when job is canceled while waiting to retry it.
BUG=613729
Review-Url: https://codereview.chromium.org/2004003002
Cr-Commit-Position: refs/heads/master@{#395563}
(cherry picked from commit 6e4712c4df60596b71fedb68f97aba7204856913)
Review URL: https://codereview.chromium.org/2006803004 .
Cr-Commit-Position: refs/branch-heads/2743@{#28}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Update StartPage signin UMA.
Signin_Signin_FromStartPage has been moved.
Signin_Impression_FromStartPage has been removed.
BUG=608179
Review-Url: https://codereview.chromium.org/1996393002
Cr-Commit-Position: refs/heads/master@{#395292}
(cherry picked from commit 78a396790f43d349ec9f937c453f3e78909ea5b9)
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2000133002
Cr-Commit-Position: refs/branch-heads/2743@{#27}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disable fullscreen global permission setting in Android.
Fixes a bug where fullscreen *looks* disableable but it's actually
always permitted by default. Forces the global slider to always be
turned on (the user cannot switch it to the off position), and changes
the string from "Allowed" to "Always allowed" to communicate that it
cannot be disabled.
This is a stop-gap measure until we can delete the data (and then this
setting UI will be removed entirely). See bug for details.
Only applies when the simplified-fullscreen-ui flag is enabled (which it
is by default).
BUG=611327
Review-Url: https://codereview.chromium.org/1989303005
Cr-Commit-Position: refs/heads/master@{#395513}
(cherry picked from commit 827ed475ee038454ee7dfb2cadba17568fc4a2b5)
Review URL: https://codereview.chromium.org/2006023005 .
Cr-Commit-Position: refs/branch-heads/2743@{#26}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.4
Cr-Commit-Position: refs/branch-heads/2743@{#25}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Ship "Response construction with ReadableStream".
Intent-To-Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0S-jPuCy8ws
BUG=564479, 596832
Review-Url: https://codereview.chromium.org/1993033003
Cr-Commit-Position: refs/heads/master@{#395223}
(cherry picked from commit e0cb6a355deab56251cea1ac5b2bcc4b605c76e2)
Review URL: https://codereview.chromium.org/2008673003 .
Cr-Commit-Position: refs/branch-heads/2743@{#24}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.3
Cr-Commit-Position: refs/branch-heads/2743@{#23}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Remoting Android] Put Icons and Credits on Navigation Menu
* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.
BUG=548929
Review-Url: https://codereview.chromium.org/1997793002
Cr-Commit-Position: refs/heads/master@{#394998}
(cherry picked from commit a217e5a71255f8adc60f491ce4bf6b5cacad564b)
Review URL: https://codereview.chromium.org/2008793002 .
Cr-Commit-Position: refs/branch-heads/2743@{#22}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
QUIC - Pass remote_address_ if address is not specified in UDPSocketWin::Write()
call. WSASendTo API call requires address and tsvipcli.dll crashes if
address is NULL.
Revered the changes to disable QUIC when tsvipcli.dll is loaded.
https://codereview.chromium.org/1999893002/
BUG=471986
[email protected]
Review-Url: https://codereview.chromium.org/2002713003
Cr-Commit-Position: refs/heads/master@{#395237}
(cherry picked from commit b01cd3b37e9daff57a621bcd6efd640cddac6d1e)
Review URL: https://codereview.chromium.org/2007773002 .
Cr-Commit-Position: refs/branch-heads/2743@{#21}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Represent lines using LayoutUnit in LineWidth
Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.
This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.
[email protected]
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html
Review-Url: https://codereview.chromium.org/1995103002
Cr-Commit-Position: refs/heads/master@{#394955}
(cherry picked from commit 60bec7228df8e6114c75586ed3e3a45042b713eb)
Review URL: https://codereview.chromium.org/2003173002 .
Cr-Commit-Position: refs/branch-heads/2743@{#20}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router WebUI] Disable search by default.
This change disables the search feature by default, only enabling it for
exceptionally long sink lists and when pseudo sinks are available.
Whether search is enabled is determined when the list of available sinks
is updated. Once it has been enabled, it will not be disabled for the
rest of the life of the dialog.
[email protected], [email protected]
BUG=612969
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/1993003002
Cr-Commit-Position: refs/heads/master@{#395128}
(cherry picked from commit 4d46c6973164274ba1e67242eae30bbc9050fce0)
Review-Url: https://codereview.chromium.org/2004133002
Cr-Commit-Position: refs/branch-heads/2743@{#19}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge to M52: Block network requests coming from loading MHTML files
The MHTML files loaded locally should be self contained. It should
not issue any network requests.
BUG=586034
Review-Url: https://codereview.chromium.org/1843343002
Cr-Commit-Position: refs/heads/master@{#395241}
(cherry picked from commit 7f5d61af3ec5b0ec55f708111e5845aee0886cba)
Review URL: https://codereview.chromium.org/2001093004 .
Cr-Commit-Position: refs/branch-heads/2743@{#18}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Use a black background on resize in Android N multi-window mode
Set the window background to black instead of null on N+, so
that the resizing background color is black.
BUG=602366
[email protected]
Review-Url: https://codereview.chromium.org/1987683003
Cr-Commit-Position: refs/heads/master@{#395179}
Review URL: https://codereview.chromium.org/2006003002 .
Cr-Commit-Position: refs/branch-heads/2743@{#17}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Media Router] Remove MR FeatureSwitch's dependency on EAR.
The ExtensionActionRedesign field trial expires after M51, and the
feature is already enabled by default. We should remove MR's dependency
on it.
Also, remove media_router_with_cast_extension FeatureSwitch as it's no
longer used.
BUG=613252
Review-Url: https://codereview.chromium.org/1996123002
Cr-Commit-Position: refs/heads/master@{#395165}
(cherry picked from commit 9013e165f40d23f8fd28424f157fa4bb3805d018)
Review URL: https://codereview.chromium.org/1997423003 .
Cr-Commit-Position: refs/branch-heads/2743@{#16}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Quota: Add metrics about the age and amount of data stored in temporary storage, and a metric about the computed quota for an origin using temporary storage.
Quota.AgeOfOriginInDays
Quota.AgeOfDataInDays
Quota.QuotaForOrigin
BUG=605753
Review-Url: https://codereview.chromium.org/1992813004
Cr-Commit-Position: refs/heads/master@{#394970}
(cherry picked from commit 78bab80f86194d0b4983aa42b5e11ea3fca3d0f2)
Review URL: https://codereview.chromium.org/2007663002 .
Cr-Commit-Position: refs/branch-heads/2743@{#15}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Merge to 2743] Blacklist rooksbas.dll in sandboxed processes
This is a source of many renderer hangs. See bug for more details.
BUG=609262
Review-Url: https://codereview.chromium.org/2004573003
Cr-Commit-Position: refs/heads/master@{#395377}
(cherry picked from commit 9a3648a17691625a13ee8acdb798813280193fb3)
Review URL: https://codereview.chromium.org/2007673002 .
Cr-Commit-Position: refs/branch-heads/2743@{#14}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Add a null check in ConnectivityManagerDelegate.getNetworkState
ConnectivityManager.getNetworkInfo can return null if the Network is invalid.
This CL adds a null check so we don't crash with a NullPointerException when
invoking networkInfo.getType()
BUG=613599
[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2003503003
Cr-Commit-Position: refs/heads/master@{#395375}
(cherry picked from commit ff2ec75896222f8a2ddc6b9e1551276929a0b671)
Review-Url: https://codereview.chromium.org/2003063003
Cr-Commit-Position: refs/branch-heads/2743@{#13}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Move ChildProcessCreationParams out of ChildProcessLauncher
Because ChildProcessLauncher's static methods can't be initailized in
Application.onCreate().
BUG=612486,592722
Review-Url: https://codereview.chromium.org/1997763003
Cr-Commit-Position: refs/heads/master@{#395124}
(cherry picked from commit 20736267093e102699c508e82425f65db64d522b)
Review URL: https://codereview.chromium.org/2008633002 .
Cr-Commit-Position: refs/branch-heads/2743@{#12}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Enable main frame before activation on waterfall.
This CL enables the main frame before activation on the waterfall so
that we have adequate coverage while we launch this via Finch.
[email protected]
BUG=612596
Review-Url: https://codereview.chromium.org/1988413003
Cr-Commit-Position: refs/heads/master@{#395206}
(cherry picked from commit 36a74489ec5e4fb898a7984398ad79b3798f70d7)
Review URL: https://codereview.chromium.org/2000293002 .
Cr-Commit-Position: refs/branch-heads/2743@{#11}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
cc: Fix overwriting of commit completion event in MFBA mode.
In main frame before activation (MFBA) mode the following sequence was
problematic:
1. Commit
2. BeginMainFrame
3. StartCommitOnImpl with hold_commit_for_activation=1 (second commit)
4. NotifyReadyToActivate (first commit)
5. Activate (first commit)
6. Commit (second commit)
StartCommitOnImpl will overwrite the completion event and associated
flag that's used in the previous frame's activation. The activation
would then signal the second commit's completion event and that commit
would later crash due to accessing a null completion event.
Added a test specifically for this case and also made the existing test
for hold_commit_for_activation more robust.
[email protected]
BUG=613007
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/2000493002
Cr-Commit-Position: refs/heads/master@{#395185}
(cherry picked from commit 2237c9b93be8a4f6c106149f714b4b88856c4549)
Review URL: https://codereview.chromium.org/2003103002 .
Cr-Commit-Position: refs/branch-heads/2743@{#10}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Sync] Ensure the user has a chance to change their settings on Android.
Using onCreate and onDestroy means that the user can go into the Google
Activity Controls or Sync settings subpages without triggering sync.
Note that leaving the sync page will still cause sync to start, but at
that point it seems safe to assume the settings are good.
BUG=613340
Review-Url: https://codereview.chromium.org/1988133005
Cr-Commit-Position: refs/heads/master@{#395081}
(cherry picked from commit 0acf90ed8a771fd3129fbbca5e1ec898e0430336)
Review URL: https://codereview.chromium.org/2008623002 .
Cr-Commit-Position: refs/branch-heads/2743@{#9}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix the incognito notification if you are in the tab switcher.
The problem is the default close all action allows the behavior
to be delegated out (in particular to the tab switcher UI) that
delays actually closing the tabs. By removing the ability to
delegate the close all, we ensure the tab count reaches 0 as
we expect in the code.
BUG=613524
Review-Url: https://codereview.chromium.org/1996883003
Cr-Commit-Position: refs/heads/master@{#395178}
Review URL: https://codereview.chromium.org/2004983002 .
Cr-Commit-Position: refs/branch-heads/2743@{#8}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Fix BitrateAdjuster issues in VTVideoEncodeAccelerator
This CL addresses the bug below, where BitrateAdjuster would continue
dropping the frame rate when bandwidth estimator kicks in.
BUG=597095
Review-Url: https://codereview.chromium.org/2000853002
Cr-Commit-Position: refs/heads/master@{#395208}
(cherry picked from commit 2e5139a27bc056aecb53df143b85ee191f6a86e6)
NOTRY=true
NOPRESUBMIT=true
[email protected]
Review-Url: https://codereview.chromium.org/2008583002
Cr-Commit-Position: refs/branch-heads/2743@{#7}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.2
Cr-Commit-Position: refs/branch-heads/2743@{#6}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
[Offline pages] Fixing website settings crash
* Removing annotation that prevents jni from finding the method.
BUG=613700
Review-Url: https://codereview.chromium.org/2003673003
Cr-Commit-Position: refs/heads/master@{#395204}
(cherry picked from commit c61217944d70f81ef03b7921ed02624038ca69e8)
Review URL: https://codereview.chromium.org/2006753002 .
Cr-Commit-Position: refs/branch-heads/2743@{#5}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
SimpleCache: open with fewer seeks.
There's usually no reason to read the file header before reading the
stream 0 (headers) data when opening a simple cache entry. By not doing
so, seeks in the critical path of the loading headers are reduced, which
should speed up http caching performance.
To be careful, the headers are still checked when the first read of data
(if any) is performed. This delays detecting hash collisions in the
cache, because the header data is required to compare keys (instead of
just hashes).
To compensate for the later key comparison, a SHA256 of the key is
stored as an optional prefix to the end of file record. This is used to
validate the key is correct before returning headers to the client.
Because the key checking logic is now totally migrated back into the
SimpleSynchronousEntry, we can return to reporting on key matching in
the SyncOpenResult histograms.
[email protected],[email protected],[email protected]
BUG=611732
Review-Url: https://codereview.chromium.org/1977863003
Cr-Commit-Position: refs/heads/master@{#395083}
(cherry picked from commit 9f15f2258d7cae8cd12cb4ef7143ad648a958333)
Review URL: https://codereview.chromium.org/2004913002 .
Cr-Commit-Position: refs/branch-heads/2743@{#4}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Disallow throttling while running requestAnimationFrame callbacks
If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.
This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.
BUG=607336
Review-Url: https://codereview.chromium.org/1994133002
Cr-Commit-Position: refs/heads/master@{#395054}
(cherry picked from commit afdf51c967149db6bd8d6a533886efc957435e18)
Review URL: https://codereview.chromium.org/2003993002 .
Cr-Commit-Position: refs/branch-heads/2743@{#3}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Merge "Count usage of :read-only and :read-write CSS selectors." to M52
This CL has no user-visible behavior changes.
BUG=613378
[email protected]
Review-Url: https://codereview.chromium.org/1999493003
Cr-Commit-Position: refs/heads/master@{#394989}
(cherry picked from commit 0ad2dca465ede4f0bef9a4ff5f5acc04da4979a1)
Review URL: https://codereview.chromium.org/1997283002 .
Cr-Commit-Position: refs/branch-heads/2743@{#2}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Incrementing VERSION to 52.0.2743.1
Cr-Commit-Position: refs/branch-heads/2743@{#1}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
