Publish DEPS for Chromium 51.0.2704.79
Incrementing VERSION to 51.0.2704.79
Cr-Commit-Position: refs/branch-heads/2704@{#690}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
DevTools: fix css pretty-print.
The CSS pretty-printing was regressed back in the days when all formatters
were moved to a single content builder.
The content builder assumes that added tokens are "words" - and makes sure
those do not stick together. However, CSS formatter violates this contract.
This patch is a workaround which could be merged.
BUG=614678
R=dgozman
Review-Url: https://codereview.chromium.org/2012953002
Cr-Commit-Position: refs/heads/master@{#396332}
(cherry picked from commit aec0b6fa92b2f2bece418aede111a78b043a0655)
Review URL: https://codereview.chromium.org/2023183002 .
Cr-Commit-Position: refs/branch-heads/2704@{#689}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.78
Cr-Commit-Position: refs/branch-heads/2704@{#688}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad
BUG=613266
Review-Url: https://codereview.chromium.org/2006033002
Cr-Commit-Position: refs/heads/master@{#396241}
(cherry picked from commit 1948aefa8901dca0ccb993753fca00b15d2a6e25)
Review URL: https://codereview.chromium.org/2021373003 .
Cr-Commit-Position: refs/branch-heads/2704@{#687}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.77
Cr-Commit-Position: refs/branch-heads/2704@{#686}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Fix crash during layout because of text autosizing
Text autosizing may change style of an object, causing problem of code
like the following:
const ComputedStyle& style = object.styleRef();
// This may call text autosizing which changes style of the object.
computeChildPreferredLogicalWidth(object, ...);
// This may reference a deleted object.
style.anyMethod();
TextAutosizer has a mechanism to hold references to the old styles to
avoid problem of raw pointers/references, but the scope seems not big
enough to cover the case of the bug.
BUG=613917
Review-Url: https://codereview.chromium.org/2000423003
Cr-Commit-Position: refs/heads/master@{#395792}
Review URL: https://codereview.chromium.org/2007683005 .
(cherry picked from commit 39f8156a4ab8ea2b3fe8820de460d321a1632521)
Cr-Original-Commit-Position: refs/branch-heads/2743@{#47}
Cr-Original-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}
Cr-Commit-Position: refs/branch-heads/2704@{#685}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.76
Cr-Commit-Position: refs/branch-heads/2704@{#684}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Fix positioning of widgets
The BrowserPlugin updateGeometry code was only sending a UpdateGeometry message to its host if the rect was the _same_ as the previous rect. This required two calls to the method in order to get the message sent, and no doubt resulted in the message being sent every time the geometry was the same and never when it was different.
[email protected], [email protected]
BUG=555201,596494
Review-Url: https://codereview.chromium.org/1958903005
Cr-Commit-Position: refs/heads/master@{#394808}
(cherry picked from commit b999309cd9ace1b703df73ed50d1c0d9efde90fa)
Review URL: https://codereview.chromium.org/2021363002 .
Cr-Commit-Position: refs/branch-heads/2704@{#683}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
DevTools: Fix Maximum call stack size exceeded error while retrieving CPU profile.
Do not pass object literals into dispatchMessage API. Always turn it into a string.
BUG=614860
Review-Url: https://codereview.chromium.org/2022673002
Cr-Commit-Position: refs/heads/master@{#396633}
(cherry picked from commit a2b2954002b9f46a902bb23ed6a11ba4c0604096)
Review URL: https://codereview.chromium.org/2024813002 .
Cr-Commit-Position: refs/branch-heads/2704@{#682}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Revert of Pseudo and non pseudo elements should return correct computed content value (patchset #14 id:260001 of https://codereview.chromium.org/1812763002/ )
Reason for revert:
BUG=609848
A lot of sites in production are depending on content returning an empty string.
Original issue's description:
> Pseudo and non pseudo elements should return correct computed content value
>
> This patch makes sure that content computes to "normal" for elements
> (not pseudo elements) and to "none" if the specified value of pseudo
> elements ::before and ::after is "normal."
>
> This patch makes us interoperable with all other browsers for the
> case of pseudo elements :before and ::after where the specified value
> is "normal".
>
> With regards to non psuedo elements we are now interoperable with IE
> and the spec and return "normal" for the computed content all all non
> psuedo elements.
> Other browsers are inconcistent on this behaviour:
> 1. Edge returns an empty string for non pseudo elements
> 2. FF returns none for non pseudo elements.
>
> The spec implemented is given here:
> https://drafts.csswg.org/css2/generate.html#content
>
> BUG=597500
>
> Committed: https://crrev.com/aaeefae6c3a945e7fcfef382c3a82002ffae0e19
> Cr-Commit-Position: refs/heads/master@{#383949}
[email protected],[email protected]
BUG=597500
Review-Url: https://codereview.chromium.org/1977323002
Cr-Commit-Position: refs/heads/master@{#394729}
(cherry picked from commit bd9df7c452f9a6aadc49214a4a09451fc726be92)
Review URL: https://codereview.chromium.org/2021163002 .
Cr-Commit-Position: refs/branch-heads/2704@{#681}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.75
Cr-Commit-Position: refs/branch-heads/2704@{#680}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
gpu: Increase watchdog timeout to 15s on Windows.
We are seeing a number of hangs in D3DCompile on Windows. Some signs
point to potentially very slow shader compiles, which are triggering
the GPU watchdog to kill the process. We can increase the timeout
and watch the logs to see if the hangs lighten.
BUG=600464
Review-Url: https://codereview.chromium.org/1985183002
Cr-Commit-Position: refs/heads/master@{#394870}
(cherry picked from commit 7972ff7f8572cad88f9451ddfaa2f41db3b7d4e5)
Review URL: https://codereview.chromium.org/2017413003 .
Cr-Commit-Position: refs/branch-heads/2704@{#679}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Fill in the current host name in the Mojo host resolver service when requesting our own IP address.
The V8 proxy resolver uses GetHostName() as the host in the
implementation of myIpAddress(). However, that may not return the
expected hostname when running inside the sandbox. Instead, use the
request's "is_my_ip_address" field to fill in the correct host name in
the browser before forwarding the resolve request to the DNS resolver.
BUG=615084
Review-Url: https://codereview.chromium.org/2011293002
Cr-Commit-Position: refs/heads/master@{#396424}
(cherry picked from commit 3a6cd21dab6a285179b02a05e980091c86545d66)
Review URL: https://codereview.chromium.org/2025623002 .
Cr-Commit-Position: refs/branch-heads/2704@{#678}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.74
Cr-Commit-Position: refs/branch-heads/2704@{#677}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.73
Cr-Commit-Position: refs/branch-heads/2704@{#676}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.72
Cr-Commit-Position: refs/branch-heads/2704@{#675}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
[Merge to M51] Fix the issue that Apps window keeps moving down to the right when reopened.
It's merged into M51 on behalf of warx@. Hide animation may have changed the transform, when recreating layer if we don't reset the transform, the installed transform from last hiding animation (such as a closing window operation) will cause window bounds changed.
BUG=602661
[email protected]
TEST=add unittest in visibility_controller
Review-Url: https://codereview.chromium.org/1986963003
Cr-Commit-Position: refs/heads/master@{#394340}
(cherry picked from commit ac95109db90a079c1d56bc61b5a2b27b2b2fae63)
Review URL: https://codereview.chromium.org/2020563006 .
Cr-Commit-Position: refs/branch-heads/2704@{#674}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.71
Cr-Commit-Position: refs/branch-heads/2704@{#673}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
[Merge to 2704] content: Not all memory creation failures are out of memory errors.
> It is possible that the child process is shutting down, and the failure is
> expected.
>
> BUG=585013
>
> Review-Url: https://codereview.chromium.org/2010563004
> Cr-Commit-Position: refs/heads/master@{#395996}
> (cherry picked from commit 4e01cbe3db01f86ee5ef3c5acdd84d261501faef)
BUG=585013
[email protected]
Review URL: https://codereview.chromium.org/2019123002 .
Cr-Commit-Position: refs/branch-heads/2704@{#672}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.70
Cr-Commit-Position: refs/branch-heads/2704@{#671}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
MediaVideoStreamTrack should store weak reference to the media source. Since MediaVideoStreamSource cann't guarantee to outlive MediaVideoStreamTrack, directly using its raw pointer might cause the incorrect use of MediaVideoStreamSource after it is destructed.
BUG=612049
Review-Url: https://codereview.chromium.org/1981113002
Cr-Commit-Position: refs/heads/master@{#394319}
(cherry picked from commit 339f60de6b251ae9872fa2c690439aee309b7ea2)
Review URL: https://codereview.chromium.org/2011163004 .
Cr-Commit-Position: refs/branch-heads/2704@{#670}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Revert "Make the video layer contents visible in OverlayFullscreenVideo mode"
This reverts commit e779e5a0f7e8bab98dab472cdbb29a850294a34b.
Cr-Commit-Position: refs/branch-heads/2704@{#669}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Fix an issue that filename is missing in download failure notification
When resuming a download, it is possible that the download is not in
history db.
In this case, native code won't be able to provide the filename.
We need to get the file name from sharedpreferences
[email protected]
BUG=614867
Review-Url: https://codereview.chromium.org/2007983007
Cr-Commit-Position: refs/heads/master@{#396321}
(cherry picked from commit c916d5295b2c636581db6271c242e35bf7394411)
Review URL: https://codereview.chromium.org/2019793002 .
Cr-Commit-Position: refs/branch-heads/2704@{#668}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.69
Cr-Commit-Position: refs/branch-heads/2704@{#667}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Abort sign in if the sign in flow activity was set but no longer visible to the user
The root cause of the below bug: onSaveInstanceState is called when Activity is stopped, after that we can not attach Fragment to it.
BUG=615129
(cherry picked from commit 4ef6f1a97fcca34d88de124bda55e0ad4cee5277)
Review-Url: https://codereview.chromium.org/2013283002
Cr-Original-Commit-Position: refs/heads/master@{#396456}
Cr-Commit-Position: refs/branch-heads/2704@{#666}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.68
Cr-Commit-Position: refs/branch-heads/2704@{#665}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.67
Cr-Commit-Position: refs/branch-heads/2704@{#664}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.66
Cr-Commit-Position: refs/branch-heads/2704@{#663}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Fix size calculation for GoogleUpdate.InfoBar.InternalStorageSizeAvailable
It was casting to int prematurely leading to overflow and wrong values.
Now casts once converted to MB which is far less likely to overflow.
BUG=517839
[email protected]
Review-Url: https://codereview.chromium.org/2014433003
Cr-Commit-Position: refs/heads/master@{#395898}
(cherry picked from commit ab43e12d6bdde387217427bdbae367c81d7bd137)
Review URL: https://codereview.chromium.org/2017573002 .
Cr-Commit-Position: refs/branch-heads/2704@{#662}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.65
Cr-Commit-Position: refs/branch-heads/2704@{#661}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Use Notification#setSubText() instead of setContentInfo() for N
The latter call is not preferred in N.
Cannot use setSubText() on Devices <=N due to setProgress()
[email protected]
BUG=602251
Review-Url: https://codereview.chromium.org/2002313002
Cr-Commit-Position: refs/heads/master@{#395455}
(cherry picked from commit c64e03690e999ac6e325e6e181ecaa6ed1ab6358)
Review URL: https://codereview.chromium.org/2011563005 .
Cr-Commit-Position: refs/branch-heads/2704@{#660}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Remove second-weak callbacks from V8AbstractEventListener
Second-weak callbacks are unsafe with Oilpan because the following scenario can happen:
1) V8 calls the first-weak callback for a wrapper X.
2) V8 drops X from a list scanned by PersistentWrapperVisitor.
3) Oilpan triggers a GC. It traces all wrappers with PersistentWrapperVisitor. X is not traced. X's corresponding DOM object gets collected.
4) V8 calls the second-weak callback for X. It crashes.
BUG=602276
Review URL: https://codereview.chromium.org/1877153002
Cr-Commit-Position: refs/heads/master@{#386587}
(cherry picked from commit f0cabf25d6d285c0f26a532681ce5070038fd356)
Review URL: https://codereview.chromium.org/2009013003 .
Cr-Commit-Position: refs/branch-heads/2704@{#659}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Merge to 2704 "[DevTools] Sanitize remoteFrontendUrl for old frontends."
>[DevTools] Sanitize remoteFrontendUrl for old frontends.
>
>BUG=607939
>
>Review-Url: https://codereview.chromium.org/1983933002
>Cr-Commit-Position: refs/heads/master@{#393952}
[email protected]
(cherry picked from commit c5eecf67fd8d5e8d24d2d4d9489753d2c8cf6c59)
Review URL: https://codereview.chromium.org/2010783002 .
Cr-Commit-Position: refs/branch-heads/2704@{#658}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
Incrementing VERSION to 51.0.2704.64
Cr-Commit-Position: refs/branch-heads/2704@{#657}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}
