Publish DEPS for Chromium 47.0.2526.25
Incrementing VERSION to 47.0.2526.25
Cr-Commit-Position: refs/branch-heads/2526@{#170}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Sync: fix for the code that checks whether the initial download has completed
The code that detects whether the initial download has completed for
a type had been inadvertently broken by https://codereview.chromium.org/1142423006/
This fix changes Directory::InitialSyncEndedForType back to the
original implementation and adds special handling for implicitly created
root folders (i.e. root folders auto-created locally by the update
handling code). Since the locally created root folders don't get applied
with the rest of downloaded nodes, their base version has to be
explicitly changed from CHANGES_VERSION to some other value at
the end of update application process. That would to indicate that at
least one update has been applied for the type and be consistent with
how the server generated root folders are handled.
BUG=540814
Review URL: https://codereview.chromium.org/1393633003
Cr-Commit-Position: refs/heads/master@{#353913}
(cherry picked from commit b691b7a0f29e7ebafad5fadb8a6d59cce8cff279)
[email protected]
Review URL: https://codereview.chromium.org/1414103002 .
Cr-Commit-Position: refs/branch-heads/2526@{#169}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Android's TextView performs poorly on very long strings. Low-end devices perform even worse and also produce UI glitches on strings longer than 4K. This change limits maximum displayable length of a URL on both high-end and low-end devices.
BUG=540689
Review URL: https://codereview.chromium.org/1400663002
Cr-Commit-Position: refs/heads/master@{#354058}
(cherry picked from commit 6374e93a56a728d110be89e1c6d645cce291590d)
Review URL: https://codereview.chromium.org/1413243002 .
Cr-Commit-Position: refs/branch-heads/2526@{#168}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Don't trigger external intents on same-host form submit.
Treat form-submit the same way we treat link clicks on a page.
BUG=542179
[email protected]
Review URL: https://codereview.chromium.org/1411563003
Cr-Commit-Position: refs/heads/master@{#354606}
(cherry picked from commit fab4db1d9b86a50b2de98164988f326ed96f9a4a)
Review URL: https://codereview.chromium.org/1414643004 .
Cr-Commit-Position: refs/branch-heads/2526@{#167}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Tentative fix for crash after selection handle releases capture
When user releases a selection handle, the handle releases its capture
which in turn generates an ET_MOUSE_CAPTURE_CHANGED event. Normally,
this event should be ignored by touch selection controller as cursor
client should report mouse events as disabled. Apparently, this is not
always the case on Windows. Since there is no repro steps for the crash
its hard to diagnose the root cause of the issue. Hopefully, this
tentative fix will resolve the issue. Some diagnostic code is also added
just in case this patch does not fix the issue.
BUG=459423
Review URL: https://codereview.chromium.org/1394913002
Cr-Commit-Position: refs/heads/master@{#354552}
(cherry picked from commit 691004dca491d7c08a5ee4c1f94ea79f066d3f47)
Review URL: https://codereview.chromium.org/1418443004 .
Cr-Commit-Position: refs/branch-heads/2526@{#166}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Mac: Fix display when using DisplayLink USB adapters
When allocating single-plane IOSurfaces, specify the bytes per element
using kIOSurfaceBytesPerElement instead of specifying it for the first
plane using kIOSurfacePlaneBytesPerElement.
For reference, DisplayLink drivers do indeed support the key
kIOSurfacePlaneBytesPerElement, but only use it when the format has
more than one plane.
BUG=527556
TBR=reveman
Review URL: https://codereview.chromium.org/1409713003
Cr-Commit-Position: refs/heads/master@{#354690}
(cherry picked from commit c242143ee361bfcdb517fa8c503f4b93c1e7b4da)
Review URL: https://codereview.chromium.org/1411373002 .
Cr-Commit-Position: refs/branch-heads/2526@{#165}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge "Webapps splashscreen: hide the splashscreen if the renderer process crashes."
Instead of showing a splashscreen for ever, the user will then be able
to see the sad face and reload the page eventually.
Tests will be part of https://codereview.chromium.org/1405023002
BUG=543604
[email protected]
Review URL: https://codereview.chromium.org/1408543003
Cr-Commit-Position: refs/heads/master@{#354804}
(cherry picked from commit 037cbdff2c4f1cbf3e32bc256bdfeed5b434067f)
Review URL: https://codereview.chromium.org/1409003003 .
Cr-Commit-Position: refs/branch-heads/2526@{#164}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Crash-fix: AuraWindowCaptureMachine WeakPtrs managed/used only on UI thread
A crash report showed that code in content::AuraWindowCaptureMachine
could be executing on the UI thread after the class has been destroyed
on the video capture device thread. This was because the WeakPtrs were
being dereferenced successfully on the UI thread, allowing the UI thread
to proceed, but then being invalidated on the video capture device
thread while the UI thread was still executing code.
This change fixes the problem by making sure all WeakPtrs are created,
used, and invalidated on the UI thread only. Added a few
"documentative" DCHECKs to clarify which class methods are meant to run
on the UI thread.
BUG=chrome-os-partner:46077
Review URL: https://codereview.chromium.org/1385423005
Cr-Commit-Position: refs/heads/master@{#353652}
(cherry picked from commit 3b7e88239d6bea8a0387d75e42f456bbc2b9457f)
Review URL: https://codereview.chromium.org/1412273002 .
Cr-Commit-Position: refs/branch-heads/2526@{#163}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Place RELEASE_ASSERTs to diagnose ScriptPromiseProperty crashes
BUG=543055
[email protected]
Review URL: https://codereview.chromium.org/1404103002
Cr-Commit-Position: refs/heads/master@{#354250}
(cherry picked from commit 9e69cf376800d62e0258f20ab4fcd44b678e3999)
Review URL: https://codereview.chromium.org/1416533002 .
Cr-Commit-Position: refs/branch-heads/2526@{#162}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
<select>: Fix a bug that 'change' event is not dispatched after updating selection programatically.
HTMLSelectElement::selectOption() should update m_lastOnChangeOption
even if event dispatching is not requested.
We also need to update HTMLSelectElement::setValue() so that it delegates
event dispatching to selectOption().
If we don't, dispatchInputAndChangeEventForMenuList() in setValue() never
dispatches events because m_lastOnChangeOption is updated in
selectOption() called by setSelectedIndex().
requiresUserGesture flag of dispatchInputAndChangeEventForMenuList() is
unnecessary now because setValue() adopts UserDriven flag.
BUG=441161
Review URL: https://codereview.chromium.org/1400283003
Cr-Commit-Position: refs/heads/master@{#354201}
(cherry picked from commit a3028f43315065a6b277c1aa1131a660b0afa2f1)
Review URL: https://codereview.chromium.org/1411903004 .
Cr-Commit-Position: refs/branch-heads/2526@{#161}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Don't cancel animation timer when servicing animations
Animations with delays will trigger a timer to service the animation at
its start time. On demand animation servicings were indiscriminately
cancelling this timer resulting in the delayed animation's start time
being missed.
This change makes us not cancel the timer when we service animations
and fixes the bug.
BUG=543346
Review URL: https://codereview.chromium.org/1394783007
Cr-Commit-Position: refs/heads/master@{#354469}
(cherry picked from commit 75f970852e6e9eb9823008bb7bdad3859ccd20a5)
Review URL: https://codereview.chromium.org/1412993002 .
Cr-Commit-Position: refs/branch-heads/2526@{#160}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
(M47) Improve error code for service worker bailing due to no update found
(This is a manual merge of 0b02872b since SWWriteToCacheJob changed a
lot between M47 and M48.)
ServiceWorkerWriteToCacheJob is the URLRequestJob responsible for
fetching and writing the updated script. It fails with network
error when it wants to abort the update because the new script is
the same as the old one.
Currently that results in ERR_FAILED errors appearing in the
DevTools console and netlog, which is confusing and hard
to debug because that error also occurs for actual network errors.
This patch changes the error to FILE_EXISTS, so it's
more clear why the job "failed".
BUG=541797
TBR=nhiroki
Review URL: https://codereview.chromium.org/1411513004 .
Cr-Commit-Position: refs/branch-heads/2526@{#159}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.24
Cr-Commit-Position: refs/branch-heads/2526@{#158}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge "Webapps splashscreen: hide the splashscreen after the page has fully loaded."
There are situations where the WebContents isn't notified of a first
visually non empty paint. In these rare situations, the splashscreen
will stay visible forever. As a safety net, the splashscreen will be
hidden when the page is fully loaded. At that point, there should have
been a first paint or it will happen at the very next layout.
The tests will be added as part of https://codereview.chromium.org/1405023002
BUG=531519,542626
[email protected]
Review URL: https://codereview.chromium.org/1405413002
Cr-Commit-Position: refs/heads/master@{#354681}
(cherry picked from commit 8efe0f049baac8abec82ef22b0a522fbf8da5e43)
Review URL: https://codereview.chromium.org/1412053002 .
Cr-Commit-Position: refs/branch-heads/2526@{#157}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merges fix to BrowserAccessibility::PlatformGetDeepestLastChild to m47.
Justification:
Serious crashing bug for Voiceover users on the Mac.
NOTRY=true
NOPRESUBMIT=true
BUG=531269
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1398853004
Cr-Commit-Position: refs/heads/master@{#353658}
(cherry picked from commit 8f7785b44baf083faa51e0a82f4638c19411ad4b)
Review URL: https://codereview.chromium.org/1413813002
Cr-Commit-Position: refs/branch-heads/2526@{#156}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.23
Cr-Commit-Position: refs/branch-heads/2526@{#155}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Don't widen selection paint rect for linebreaks.
BUG=543309
TBR=pdr
Review URL: https://codereview.chromium.org/1407003002
Cr-Commit-Position: refs/heads/master@{#354434}
(cherry picked from commit 165f41b96b1957fbf63375d670224baecd9acaa7)
Review URL: https://codereview.chromium.org/1412833003 .
Cr-Commit-Position: refs/branch-heads/2526@{#154}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Avoid a crash in downloading when tab has already been closed
Since we are now running file operations in the background thread,
some of the onPostExecute() code in ChromeDownloadDelegate may be called
after Tab has been destroyed.
We can avoid such crashes by nulling out Tab when it's destroyed.
BUG=537820
Review URL: https://codereview.chromium.org/1379963002
Cr-Commit-Position: refs/heads/master@{#354408}
(cherry picked from commit f2248350cbf9eb0acf97a028d4932c36287eaa26)
Review URL: https://codereview.chromium.org/1403293005 .
Cr-Commit-Position: refs/branch-heads/2526@{#153}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.22
Cr-Commit-Position: refs/branch-heads/2526@{#152}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge "Invalidate non-self-painting-layer descendants when creating a layer"
When a layer is created, its descendants may change paint invalidation
container. For example, previously the descendants had a containing
layer which is composited but was not a stacking context, and now their
paint invalidation container becomes the nearest stacking context
ancestor.
The real bug status is hard to reproduce with a test because it depends
on reuse of display item client addresses (deleted display item client
not invalidated on the correct paint invalidation container, then a new
display item client is created at the same address which will be treated
as validly cached).
BUG=541544
TEST=paint/invalidation/invalidate-descendants-when-receiving-paint-layer.html
> Review URL: https://codereview.chromium.org/1403963002
> Cr-Commit-Position: refs/heads/master@{#354202}
Review URL: https://codereview.chromium.org/1408803006 .
Cr-Commit-Position: refs/branch-heads/2526@{#151}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge 'Fix extension geolocation permission requests'
This is a temporary, minimal fix for crbug.com/534631 that also prevents
the crashes we saw with crbug.com/457091. It's very minimal because it
needs to be merged to 46 at the very last second.
BUG=534631,457091
[email protected]
Review URL: https://codereview.chromium.org/1393883003
Cr-Commit-Position: refs/heads/master@{#352961}
(cherry picked from commit c8e77515c144383ca322516fd68f602197895f86)
Review URL: https://codereview.chromium.org/1412443004 .
Cr-Commit-Position: refs/branch-heads/2526@{#150}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Set UrlRequestContextBuilder.use_alternative_services to false in Cronet legacy API.
BUG=543366
Review URL: https://codereview.chromium.org/1413713002
[email protected]
Cr-Commit-Position: refs/heads/master@{#354580}
(cherry picked from commit 0b7b667669188b095bd450b307269f5c501a756a)
Review URL: https://codereview.chromium.org/1411893002 .
Cr-Commit-Position: refs/branch-heads/2526@{#149}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Set UrlRequestContextBuilder.use_alternative_services to false in Cronet.
BUG=543366
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1408673002 .
Cr-Commit-Position: refs/heads/master@{#354265}
(cherry picked from commit c7c98cba2b33706dfc90acf8d60aa6f747a804b5)
Review URL: https://codereview.chromium.org/1408053004 .
Cr-Commit-Position: refs/branch-heads/2526@{#148}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Remove arbitrary fractional rounding in viewport scroll.
This rounding was arbitrary but previous naive attempts to remove it resulted
in top control jittering so it was left in. With the viewport scroll order
change in r348988, this caused fractional scrolls to be dropped completely.
Removing it now though doesn't seem to cause the top control problem.
BUG=539334
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1387333003
Cr-Commit-Position: refs/heads/master@{#352945}
(cherry picked from commit 49c85a92156ec9f794f6c57c3f2d2ab2aa981f94)
Review URL: https://codereview.chromium.org/1414503002 .
Cr-Commit-Position: refs/branch-heads/2526@{#147}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Do high-quality resizes for notification images.
Use gfx::ImageSkiaOperations::CreateResizedImage() with
RESIZE_BEST when resizing notification images to 80x80
before painting them.
Previously, gfx::Canvas::DrawImageInt() was used, but this
results in poor results with some large images.
BUG=543658
Review URL: https://codereview.chromium.org/1404333002
Cr-Commit-Position: refs/heads/master@{#354310}
(cherry picked from commit ac4ebe021dd185d7a86e930a623891619a415f1d)
Review URL: https://codereview.chromium.org/1405103004 .
Cr-Commit-Position: refs/branch-heads/2526@{#146}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Recompute non-fast scrolling regions when a scroller gains or loses a cc layer.
If a scrollable area loses its composited layer without a relayout (e.g., after
an animation) we fail to set ScrollingCoordinator::m_scrollGestureRegionIsDirty.
This means cc will still try to handle scroll events, when it should be
forwarding them to the main thread.
BUG=524687
Review URL: https://codereview.chromium.org/1403203003
Cr-Commit-Position: refs/heads/master@{#354235}
(cherry picked from commit 2c49844b06e975a308257b103e85a50f13563e4d)
Review URL: https://codereview.chromium.org/1408163002 .
Cr-Commit-Position: refs/branch-heads/2526@{#145}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Use a custom Painter to draw gtk buttons
ImagePainter was designed to be used with internal assets, so its use in
libgtk2ui ended up causing a few weird regressions, along with being
awkward in general. Instead, let's just subclass our own Painter for
drawing gtk buttons.
BUG=534280,542410
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1394523005
Cr-Commit-Position: refs/heads/master@{#353852}
(cherry picked from commit 777e546ede7902e01b731a26da0565d80ef034c4)
Review URL: https://codereview.chromium.org/1408153002 .
Cr-Commit-Position: refs/branch-heads/2526@{#144}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Roll harfbuzz-ng to 1.0.5
Update the bundled version of harfbuzz-ng in third_party to 1.0.5.
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1401363002
Cr-Commit-Position: refs/heads/master@{#353793}
(cherry picked from commit 98eef9ffcf1f49bcef3fed5f3d1a09d844ef8f02)
BUG=526101
Review URL: https://codereview.chromium.org/1408003004 .
Cr-Commit-Position: refs/branch-heads/2526@{#143}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Whitelist the HP printer driver for public sessions
This CL allows the HP printer driver extension to be used in public
sessions.
BUG=526770
TEST=None
Review URL: https://codereview.chromium.org/1388343006
Cr-Commit-Position: refs/heads/master@{#354279}
(cherry picked from commit e965561099208a573042c5a2ae132faf53c1b299)
Review URL: https://codereview.chromium.org/1410773004 .
Cr-Commit-Position: refs/branch-heads/2526@{#142}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.21
Cr-Commit-Position: refs/branch-heads/2526@{#141}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Merge M47] IsGaiaReauthenticationForm should get hidden fields...
...but those are currently filtered out in the construction of SyntheticForm.
This CL gets rid of that filtering. Unfortunately, it would be very complicated to test this:
In order to trigger the filtering, the test would have to simulate that the current document origin is the same as the GAIA origin (accounts.google.com).
Unfortunately, GAIA origin is set very early during Chrome start-up, in particular earlier that the test-server (used in browser tests) starts and generates its hostname. So changing GAIA origin is unlikely. But changing the frame origin also is not really possible, as far as vabr knows. This filtering code is slated for refactoring soon, and should be moved from renderer to browser, so instead of investing a lot of effort to make testing possible now, let's keep it as a TODO for the new location.
[email protected]
BUG=543006
Review URL: https://codereview.chromium.org/1404113002
Cr-Commit-Position: refs/heads/master@{#354053}
(cherry picked from commit 2d5b1bb0272d38cda7e0bd1027f6f65f7acc9f79)
Review URL: https://codereview.chromium.org/1408093002 .
Cr-Commit-Position: refs/branch-heads/2526@{#140}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Test clean-up for IsGaiaReauthenticationForm
This CL separates the test-case data from the test execution in IsGaiaReauthenticationForm. It also switches IsGaiaReauthenticationForm to use std::vector instead of WebVector. The former is the default choice in Chromium, and the latter should only be used for communicating with Blink.
This CL is a prerequisite of https://codereview.chromium.org/1404113002/, a fix for how control_elements are generated for IsGaiaReauthenticationForm.
[email protected]
BUG=543006
Review URL: https://codereview.chromium.org/1398403008
Cr-Commit-Position: refs/heads/master@{#354019}
(cherry picked from commit 4bbb64de79e4a0987e2d4957cc6a1b0b25be783a)
Review URL: https://codereview.chromium.org/1413613002 .
Cr-Commit-Position: refs/branch-heads/2526@{#139}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add new accessibility event for document selection.
This adds a new event that gets fired on the document node when document
selection (including selection in a text field) changes. Currently,
the existing text selection event is sent on the focused node as well,
to preserve backwards compatibility.
The new event is exposed in the chrome.automation API.
BUG=537672
Review URL: https://codereview.chromium.org/1394503002
Cr-Commit-Position: refs/heads/master@{#353816}
(cherry picked from commit 7202ca4cfd0c01f19201d9f42bee90532d62f73d)
Review URL: https://codereview.chromium.org/1409103003 .
Cr-Commit-Position: refs/branch-heads/2526@{#138}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.20
Cr-Commit-Position: refs/branch-heads/2526@{#137}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.19
Cr-Commit-Position: refs/branch-heads/2526@{#136}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Media Galleries: Add usage statistics for getMetadata, Picasa, etc.
Adds usage statistics for:
- getMetadata call
- getAllGalleryWatch call
- removeAllGalleryWatch call
- iPhoto file systems
- Picasa file systems
- iTunes file systems
This uses an existing histogram. It just adds some new buckets.
BUG=542912
Review URL: https://codereview.chromium.org/1400133004
Cr-Commit-Position: refs/heads/master@{#354148}
(cherry picked from commit e8888a62661316c1af14647300f2bd2bf0550b21)
Review URL: https://codereview.chromium.org/1410663002 .
Cr-Commit-Position: refs/branch-heads/2526@{#135}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
android: Fix GLContext creation race
https://codereview.chromium.org/1371523003/ introduced the
possibility of creating an OutputSurface from SetVisible(true).
We have to make sure the surface_id is registered at that point.
BUG=517279
NOTRY=True
Review URL: https://codereview.chromium.org/1402383002
Cr-Commit-Position: refs/heads/master@{#354346}
(cherry picked from commit e018d323cd0064ae5c3ddd504e7cb4744e9adba0)
Review URL: https://codereview.chromium.org/1411533002 .
Cr-Commit-Position: refs/branch-heads/2526@{#134}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Contextual Search] Fixes ContentView regressions.
This CL fixes important regressions in the way ContentViews
are rendered in Contextual Search.
All loaded searches were being made visible, even when the
user didn't interact with the Panel. Now there's no way to
control the visibility of the Content from outside its class.
Instead, consumers should call acknowledgeIntentToShowContent()
to signal that there's an intent to show the Content, but only
the Content will actually control its visibility, which makes
the code more robust.
Also, the OverlayPanelContent class wasn't properly clearing
its internal states, which was causing other bugs. These bugs
happened, in part, because we are exposing methods to create
and destroy the ContentView. Also, tests were not creating
ContentViews, which the made the code confusing.
So, instead of making such method public, so they can be
overriden by tests (in order to keep track of whether
ContentViews have been created), now those methods are
private, and a new method didCreateContentView() has
been exposed so that the tests can assert the ContentView's
existence.
BUG=542785
BUG=542786
BUG=542790
Cr-Commit-Position: refs/heads/master@{#354161}
(cherry picked from commit 9893e6aff9f1811ca5e0e3b3ab4f9fac19afec92)
Review URL: https://codereview.chromium.org/1409763002 .
Cr-Commit-Position: refs/branch-heads/2526@{#133}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Handle upgrade case from previous MSI install.
An MSI install leaves behind a master_preferences file. Use that
information to update version numbers when auto-updates are installed.
BUG=67348
[email protected]
Review URL: https://codereview.chromium.org/1351453006
Cr-Commit-Position: refs/heads/master@{#353459}
(cherry picked from commit fe3fb71878ba25c963b6a3259ba948bdc828e44a)
Review URL: https://codereview.chromium.org/1410563002 .
Cr-Commit-Position: refs/branch-heads/2526@{#132}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Contextual Search] Fixes logPromoOutcome logic and improves performance.
Fixes logPromoOutcome logic, which wasn't properly logging
promo acceptances.
Improves performance by caching whether promo is available.
BUG=539939
BUG=539942
Cr-Commit-Position: refs/heads/master@{#353820}
(cherry picked from commit 52aabd1632ea29cae5b250b23842ecb54102dce7)
Review URL: https://codereview.chromium.org/1406973002 .
Cr-Commit-Position: refs/branch-heads/2526@{#131}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Remove CompositedLayerMapping::hasUnpositionedOverflowControlsLayers.
"!layer->drawsContent()" is not a good indicator of whether a scrollbar
GraphicsLayer's geometry is up to date, for two reasons:
(1) Coordinated scrollbars (backed by a WebScrollbarLayer) have m_drawsContent
== false at all times, so they are already having their geometry recomputed
on every compositing update.
(2) ScrollingCoordinator will call setDrawsContent(true) on a newly created
scrollbar layer, if the scrollbar is visible but disabled. This tricks
hasUnpositionedOverflowControlsLayers into thinking the scrollbar has
already been positioned, when it hasn't.
GraphicsLayerUpdater now calls positionOverflowControls whenever the PaintLayer
has a ScrollableArea.
BUG=541119
Review URL: https://codereview.chromium.org/1405683002
Cr-Commit-Position: refs/heads/master@{#354049}
(cherry picked from commit 7c4128b0865b0cf6dad79465f05a86882087b697)
Review URL: https://codereview.chromium.org/1403973003 .
Cr-Commit-Position: refs/branch-heads/2526@{#130}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Support Android username-only credentials.
They are collected implicitly and should be treated specially.
The local credentials without password are just ignored by both the form autofill and Credential Manager API. The federated credentials can be used by the API. However, they shouldn't be used for auto signin.
BUG=527073
Review URL: https://codereview.chromium.org/1375883002
Cr-Commit-Position: refs/heads/master@{#354021}
(cherry picked from commit ee98c3b98d1b34e8a16543ccbcdf69168f8af56b)
Review URL: https://codereview.chromium.org/1394303009 .
Cr-Commit-Position: refs/branch-heads/2526@{#129}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Omit PrecacheService BroadcastReceivers on Stable/Work channels.
It's not clear how much overhead these add, but we don't intend to run
on stable for the foreseeable future, so elide them for now.
BUG=309216
TBR=bengr
Review URL: https://codereview.chromium.org/1403583002
Cr-Commit-Position: refs/heads/master@{#353736}
(cherry picked from commit b51e3dc80c0a9ce125c36f1adb2277e579217867)
Review URL: https://codereview.chromium.org/1386323008 .
Cr-Commit-Position: refs/branch-heads/2526@{#128}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Password Manager] Pass origin of the form which was autofilled in order to display it in management bubble.
Currently password management bubble uses the origin of the first
matching form from password store in order to determine if we should
present form origin to user or not. Instead we should show URL of the
form, where credentials were autofilled.
BUG=539889
Review URL: https://codereview.chromium.org/1402803002
[email protected],[email protected]
Cr-Commit-Position: refs/heads/master@{#353980}
(cherry picked from commit 28139e2acc6a1d23adb00f0d1ae3ececf2a8da91)
Review URL: https://codereview.chromium.org/1394283004 .
Cr-Commit-Position: refs/branch-heads/2526@{#127}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
ChromeOS: PasswordChanged event sould not modify display name.
PasswordChanged is intermediate event, so ExistingUserController state
should not be reset on receiving it.
BUG=507779
TEST=manual
Review URL: https://codereview.chromium.org/1401873002
Cr-Commit-Position: refs/heads/master@{#353968}
(cherry picked from commit b14198f949c3bcbb8e4412c7764f640b71a2a781)
[email protected]
Review URL: https://codereview.chromium.org/1409513004 .
Cr-Commit-Position: refs/branch-heads/2526@{#126}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Merge to M47] Add a null check in CompositedLayerMapping::notifyTextPainted
This prevents crash when the associated LayoutObject is anonymous.
BUG=540987,520410
Review URL: https://codereview.chromium.org/1393273002
Cr-Commit-Position: refs/heads/master@{#353442}
(cherry picked from commit 15921cdc1818ffdeb2583b2ff321fd13ca1220c6)
Review URL: https://codereview.chromium.org/1408693002 .
Cr-Commit-Position: refs/branch-heads/2526@{#125}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Merge to M47] Add "time to first text paint" to PageLoadMetrics system
This adds PageLoad.Timing2.NavigationToFirstTextPaint(.BG) UMA histogram which
measures the time between navigation start to first non-blank text paint.
BUG=520410
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1376643002
Cr-Commit-Position: refs/heads/master@{#352770}
(cherry picked from commit dcc645d4800a86840a2a84ec1cf37019d7736d81)
Review URL: https://codereview.chromium.org/1402283002 .
Cr-Commit-Position: refs/branch-heads/2526@{#124}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to M47: Gallery: select multiple images with shift key.
BUG=541073
TEST=browser_tests:GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads
Review URL: https://codereview.chromium.org/1402813003
Cr-Commit-Position: refs/heads/master@{#353715}
(cherry picked from commit fcb03f427681a8792aa55aa91b1c052b249d7e55)
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1396253007 .
Cr-Commit-Position: refs/branch-heads/2526@{#123}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
DataConsumerTee::DestinationReader fails to acquire lock
The statement
MutexLocker(mutex);
creates a mutex locker as a temporary object, but the object should be bound
to a named variable in order to protect computation in the scope.
BUG=542642
Review URL: https://codereview.chromium.org/1401953002
Cr-Commit-Position: refs/heads/master@{#353747}
(cherry picked from commit fb5988f3305e432bb2667ceaf6f29d1df8a118e0)
Review URL: https://codereview.chromium.org/1404903003 .
Cr-Commit-Position: refs/branch-heads/2526@{#122}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Increased time limit for GAIA frame loading.
The time limit was increased from 7 to 60 seconds.
As far as understood, we had 60 seconds time limit for loading in the past, and
7 seconds time limit served another purpose (starting lazy captive portal
check). At some point this behaviour was erroneously changed, and we started
interrupt GAIA loading after 7 seconds.
BUG=507691
TEST=manually
Review URL: https://codereview.chromium.org/1391983004
Cr-Commit-Position: refs/heads/master@{#353623}
(cherry picked from commit 3b544273db27f39a2cce1ece8af92d0e7eb4ac7c)
Review URL: https://codereview.chromium.org/1404833003 .
Cr-Commit-Position: refs/branch-heads/2526@{#121}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Delete box painting optimizations that depend on the interest rect.
Such optimizations are no longer legal in Slimming Paint. (See crbug.com/541817 for more on that point.)
BUG=541098,541817
[email protected]
Review URL: https://codereview.chromium.org/1399163002
Cr-Commit-Position: refs/heads/master@{#353571}
(cherry picked from commit fd75e9942198e2f00d5713ab7bd44c12b0f3cab2)
Review URL: https://codereview.chromium.org/1405893002 .
Cr-Commit-Position: refs/branch-heads/2526@{#120}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.18
Cr-Commit-Position: refs/branch-heads/2526@{#119}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Enlarge default favicon to match its old dimensions.
This regressed in https://codereview.chromium.org/1304833003/ .
This also updates the 32x32 and 64x64 favicons to match the 16x16 one.
BUG=505953
TEST=Open about:blank, the favicon in the tab shouldn't look undersized
TBR=oshima
Review URL: https://codereview.chromium.org/1395273006
Cr-Commit-Position: refs/heads/master@{#353926}
(cherry picked from commit 8b17c6f96ad2a4674be95d280221cfb38138435d)
Review URL: https://codereview.chromium.org/1408593003 .
Cr-Commit-Position: refs/branch-heads/2526@{#118}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.17
Cr-Commit-Position: refs/branch-heads/2526@{#117}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Allow data reduction proxy tests to pass in the value of Time::Now().
The API to get historical data usage pads the result with empty buckets
to ensure that the last value always corresponds to the current interval.
This makes the API hard to test since its result depends on the exact
time it is called. Tests can now pass in current time so that the
response of the API is deterministic.
BUG=539646
Review URL: https://codereview.chromium.org/1386013002
Cr-Commit-Position: refs/heads/master@{#353439}
(cherry picked from commit 79cc77c2a862e0e3ecc06a7b24e34b7958aa1846)
Review URL: https://codereview.chromium.org/1405833002 .
Cr-Commit-Position: refs/branch-heads/2526@{#116}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Speculative fix for the failure to initialize PPB_VideoDecoder.
PPB_VideoDecoder API sometimes fails initialization with
PP_ERROR_NOTSUPPORTED error. It's suspected that this problem
is related to http://crrev.com/344391 . After that CL the plugin
attempts to detect when new version of the interface is supported
and tries to use it instead of the old version. It appears that
in some cases the plugin may be using newer version, while it's
not actually enabled in the browser. It's not clear why that
happens. With this CL the plugin will always be using old version
of the interface.
BUG=533890
Review URL: https://codereview.chromium.org/1372293002
Cr-Commit-Position: refs/heads/master@{#353772}
(cherry picked from commit 9ebbe4a764585a8ba96a8e383e6d9655ea6cba96)
Review URL: https://codereview.chromium.org/1404843002 .
Cr-Commit-Position: refs/branch-heads/2526@{#115}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Blacklist rooksbas.dll in sandboxed processes
This is a huge source of crashes and hangs. The below
bug is representative. Query crash for a longer list
BUG=537647
[email protected]
Review URL: https://codereview.chromium.org/1391583004
Cr-Commit-Position: refs/heads/master@{#352723}
(cherry picked from commit bccf4d75f7e9eaa4cc0f0aa0ff223e2e9f3b71e1)
Review URL: https://codereview.chromium.org/1400693003 .
Cr-Commit-Position: refs/branch-heads/2526@{#114}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Use SSL_get_cipher_by_value to disable cipher suites.
The old logic was rather messy due to OpenSSL being unable to look up ciphers
by ID. BoringSSL, however, has a perfectly reasonable function to look up
cipher suites by value. Clean up the logic to not rely on SSL_get_ciphers. This
fixes a bug where TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 was not blacklistable
by command-line; at the time the blacklist code ran,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 is not in the list.
BUG=542322
Review URL: https://codereview.chromium.org/1395393002
Cr-Commit-Position: refs/heads/master@{#353566}
(cherry picked from commit 9b4a9b9cbdbda996aaf9bf8c95fca674e1ccdbb8)
[email protected]
Review URL: https://codereview.chromium.org/1403703006 .
Cr-Commit-Position: refs/branch-heads/2526@{#113}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to 2526: [DevTools] Do not access DOMDebugger when it's not available.
> [DevTools] Do not access DOMDebugger when it's not available.
>
> BUG=540048
>
> Review URL: https://codereview.chromium.org/1388213002
>
> Cr-Commit-Position: refs/heads/master@{#353208}
(cherry picked from commit 68551e59e65f8ae8fed6e796e0a75924330ea91c)
Review URL: https://codereview.chromium.org/1390113005 .
Cr-Commit-Position: refs/branch-heads/2526@{#112}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
UMA and Telemetry for separate checkerboarded area has recording or not
Adds UMA and Telemetry support for counting checkerboarded area in
pixels, and separate checkerboarded content area that has recording and
checkerboarded content area that does not have recording.
BUG=535732
R=enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1377583004
Cr-Commit-Position: refs/heads/master@{#352407}
(cherry picked from commit ee31fcdc94807bc20cdf2363da60d61d586f0770)
Review URL: https://codereview.chromium.org/1404583003 .
Cr-Commit-Position: refs/branch-heads/2526@{#111}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to 2526: [DevTools] Hide request blocking behind an experiment and do not persist throttling.
> [DevTools] Hide request blocking behind an experiment and do not persist throttling.
>
> BUG=541724
>
> Review URL: https://codereview.chromium.org/1400773004
>
> Cr-Commit-Position: refs/heads/master@{#353461}
(cherry picked from commit 85784ed8cac303d605a9bd52a860b9693b12e8ec)
Review URL: https://codereview.chromium.org/1394003007 .
Cr-Commit-Position: refs/branch-heads/2526@{#110}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
cc: Fix ScrollbarLayer overflow
During clamping to the max texture size, if scaling saturates
scaled_bounds width or height to MAX_INT, then we weren't clamping
correctly for bounds().height() > width.
BUG=541528
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1402653002
Cr-Commit-Position: refs/heads/master@{#353633}
(cherry picked from commit 99d9eeb9ad625be61df8e960e03284136b2bc769)
Review URL: https://codereview.chromium.org/1405773002 .
Cr-Commit-Position: refs/branch-heads/2526@{#109}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
WebApps: send error message to the console if the downloaded icon from Manifest can't be used.
This is in order to reduce confusion when an icon resource was correctly
downloaded (ie. not a 4xx) but wasn't a valid icon or wasn't matching
the Manifest metadata (eg. different size or format).
BUG=542373
[email protected]
Review URL: https://codereview.chromium.org/1387293005
Cr-Commit-Position: refs/heads/master@{#353732}
(cherry picked from commit 1bcd044b1ab5d2ca9d71782e056b3eb61ecb809d)
Review URL: https://codereview.chromium.org/1400333003 .
Cr-Commit-Position: refs/branch-heads/2526@{#108}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
AutofillPreferences: Modify UI only when it's available.
If an autofill profile changes when AutofillPreferences fragment is
alive, but its view has been destroyed, then AutofillPreferences crashes
as it tries to update the destroyed view. The fix is to start observing
profile changes in onActivityCreated and stop in onDestroyView.
http://developer.android.com/reference/android/app/Fragment.html#Lifecycle
BUG=539962
Review URL: https://codereview.chromium.org/1394003005
Cr-Commit-Position: refs/heads/master@{#353942}
(cherry picked from commit 7a320d9e42ea2648c07fd7770b157332f15af324)
Review URL: https://codereview.chromium.org/1399553005 .
Cr-Commit-Position: refs/branch-heads/2526@{#107}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
cc: Ensure animations schedule a layer update
If a main thread animation changes either the transform or opacity of
a layer, tree, we should perform a layer update to ensure any newly
exposed content gets painted.
BUG=535798
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/1366403006
Cr-Commit-Position: refs/heads/master@{#353723}
(cherry picked from commit e5cd474f9a30f5207b568e39a977bafe0377075a)
Review URL: https://codereview.chromium.org/1399053005 .
Cr-Commit-Position: refs/branch-heads/2526@{#106}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
WebApps splashscreen: show Manifest theme_color while loading.
This is fixing a regression caused by
https://codereview.chromium.org/1375693002
This is also including follow-up fix from trunk:
https://codereview.chromium.org/1388393006
BUG=542773
[email protected]
Review URL: https://codereview.chromium.org/1403683006
Cr-Commit-Position: refs/heads/master@{#353862}
(cherry picked from commit 63fc0e7e58f974b6b4b685f079357e8bda8bd432)
Review URL: https://codereview.chromium.org/1405633005 .
Cr-Commit-Position: refs/branch-heads/2526@{#105}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
MediaSession: add UMA counting active time and interruptions for a session.
This is adding a MediaSessionUmaHelper class that counts how long a
session has been active (excluding suspended time) and send metrics
regarding how many times and why a session has been interrupted.
BUG=539937
Review URL: https://codereview.chromium.org/1373263003
Cr-Commit-Position: refs/heads/master@{#353783}
(cherry picked from commit 774077aec54a6c8fb5df256299d2f62059505a8c)
Review URL: https://codereview.chromium.org/1401613004 .
Cr-Commit-Position: refs/branch-heads/2526@{#104}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to M47: Gallery.app: do not switch mode with Enter key if not for a thumbnail.
BUG=540562
TEST=browser_tests:GalleryBrowserTest.DeleteAllImagesInThumbnailModeWith(Enter|Delete)Key
Review URL: https://codereview.chromium.org/1400803002
Cr-Commit-Position: refs/heads/master@{#353249}
(cherry picked from commit 9e992920e4461045506b46b3419f42d86cde5651)
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1403963005 .
Cr-Commit-Position: refs/branch-heads/2526@{#103}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.16
Cr-Commit-Position: refs/branch-heads/2526@{#102}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.15
Cr-Commit-Position: refs/branch-heads/2526@{#101}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Don't invoke ConnectToService factory on invalid handles
This prevents ServiceRegistryImpl from invoking service
factories on invalid interface requests, since it's possible
to receive an invalid handle under certain conditions (see
discussion on https://codereview.chromium.org/1399883003/).
BUG=542062,534719
[email protected]
Review URL: https://codereview.chromium.org/1399883004
Cr-Commit-Position: refs/heads/master@{#353622}
(cherry picked from commit 48ff4db943af19ef31c5eaa9ab119b1568db9b7e)
Review URL: https://codereview.chromium.org/1390963004 .
Cr-Commit-Position: refs/branch-heads/2526@{#100}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Adjust MB/Flush on Adreno from 4MB > 1MB
Currently one copy tile task worker pool will upload up to 4MB of
textures before flushing. This causes the GL driver caches on Adreno
devices to grow more than they used to in the previous Async upload
path.
This CL adjusts this value down to 1MB on Adreno devices, which yields
cache growth similar to that in M46.
BUG=542478,541279
Review URL: https://codereview.chromium.org/1401173005
Cr-Commit-Position: refs/heads/master@{#353825}
(cherry picked from commit b68bff6b499d763ac0dce82ff55ad955f4020ac7)
Review URL: https://codereview.chromium.org/1403793005 .
Cr-Commit-Position: refs/branch-heads/2526@{#99}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Revert "Extracts more information from serial devices on Windows"
This reverts commit e940c46e8e7b40367a4c151656550693476ea870.
The CL being reverted has caused a regression on Windows where
Arduino serial devices that were showing up before are no
longer showing up. I think that it makes sense to take a more
reasoned approach here and use a combination of the old method
and the new method until we're sure that the new method of
enumerating serial devices is strictly better than the old.
(We can verify this using UMA metrics.) For now, though, we'll
just want to eliminate the regression.
This CL will also need need to be cherrypicked onto current
release branches.
BUG=540889
Review URL: https://codereview.chromium.org/1395023002
Cr-Commit-Position: refs/heads/master@{#353212}
(cherry picked from commit cbca414b1aae0e5fae37a651d854132ef9138a9b)
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1398383005
Cr-Commit-Position: refs/branch-heads/2526@{#98}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Revert "Extracts more information from serial devices on Mac"
This reverts commit d1540f60edad27a6599b000e80413dce5f5b224a.
A similar CL to the one being reverted has caused a regression on
Windows where Arduino serial devices that were showing up before are no
longer showing up. I think that it makes sense to take a more
reasoned approach here and use a combination of the old method
and the new method until we're sure that the new method of
enumerating serial devices is strictly better than the old.
(We can verify this using UMA metrics.) For now, though, we'll
just want to eliminate any chance of regression.
This CL will also need need to be cherrypicked onto current
release branches.
BUG=540889
Review URL: https://codereview.chromium.org/1398923002
Cr-Commit-Position: refs/heads/master@{#353213}
(cherry picked from commit 2251715f036cd70ab4c24f3cfb180c0c75f61726)
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1398373005
Cr-Commit-Position: refs/branch-heads/2526@{#97}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merged: Do not skip late video frames in MediaCodecPlayer
The current MediaSourcePlayer works the same, i.e. renders
all late video frames the moment they are available.
BUG=407577, 540046
TBR=timav
> Review URL: https://codereview.chromium.org/1382293002
> Cr-Commit-Position: refs/heads/master@{#352431}
Review URL: https://codereview.chromium.org/1405463005 .
Cr-Commit-Position: refs/branch-heads/2526@{#96}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Extensions] Fix a bug in warning bubbles not showing
Fix a bug where the dev mode warning suspicious extension warning bubbles
wouldn't show properly.
Also clean up a little bit of the bubble architecture.
BUG=540907
Review URL: https://codereview.chromium.org/1395793002
Cr-Commit-Position: refs/heads/master@{#353403}
(cherry picked from commit db7f2c733514d6d3b4041f587220fff070109404)
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1406603002 .
Cr-Commit-Position: refs/branch-heads/2526@{#95}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add UMA for MediaThrottleInfoBar
This change collects the following UMAs:
1. How many consecutive media server crashes has been encountered before we reset the counter
2. What is the user response to media throttle infobar
TBR=tedchoc, isherman
BUG=532745
Review URL: https://codereview.chromium.org/1398503002
Cr-Commit-Position: refs/heads/master@{#353576}
(cherry picked from commit 3e0ea85f92cbe3bb3f813321e5b20b5beb9a1e23)
Review URL: https://codereview.chromium.org/1403763004 .
Cr-Commit-Position: refs/branch-heads/2526@{#94}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Exclude third_party/WebKit from root presubmits.
This avoids running the chromium's src/PRESUBMIT.py for
third_party/WebKit. This is required after crrev.com/1382993004
which has un-blacklisted third_party/WebKit from the depot_tools
blacklist.
The final effect of this CL + crrev.com/1382993004 (depot_tools)
should bring back to the original pre-merge state.
BUG=539835,539768
Review URL: https://codereview.chromium.org/1391593002
Cr-Commit-Position: refs/heads/master@{#352584}
(cherry picked from commit 0166ccc8ad4d92809632f0555206de415b725698)
[email protected]
Review URL: https://codereview.chromium.org/1398923003 .
Cr-Commit-Position: refs/branch-heads/2526@{#93}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add metrics to check how often the Cast overlay button is shown and clicked.
This is also doing some code clean-up.
We do not record why the Cast button overlay is shown. There are two
reasons today: there isn't enough space for the regular button or the
video element is using custom controls.
This is also including the follow-up from:
https://codereview.chromium.org/1395353002
BUG=540743
[email protected]
Review URL: https://codereview.chromium.org/1391983002
Cr-Commit-Position: refs/heads/master@{#353201}
(cherry picked from commit 8753a397b473476f4962c93ad1f728c9ccde766e)
Review URL: https://codereview.chromium.org/1394383003 .
Cr-Commit-Position: refs/branch-heads/2526@{#92}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Syncing the remote devices after the SmartLock setup is completed.
This CL also force re-loading the device when the sync is done after the setup is completed.
BUG=541170
Review URL: https://codereview.chromium.org/1390253002
Cr-Commit-Position: refs/heads/master@{#353251}
(cherry picked from commit cc0f8c9936c84961839f32cec3cc51e70b92fca0)
Review URL: https://codereview.chromium.org/1395493006 .
Cr-Commit-Position: refs/branch-heads/2526@{#91}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
scheduler: Avoid recursive locking when posting tasks into the past
If task A was posted into the past on a queue which already had another
task B scheduled to execute at another (different) point in the past,
the TaskQueueManager would try to call back into the same task queue to
synchronously move task B into the incoming queue. This caused a
deadlock because the call to post task A was still holding the
TaskQueueImpl lock at this point.
Fix by removing the fast path for handling delayed tasks that are in the
past. This simplifies the code with a small latency impact to delayed
work posted into the past (which generally only happens for timer tasks
when a tab is backgrounded).
BUG=531363
Review URL: https://codereview.chromium.org/1388263003
[email protected]
Cr-Commit-Position: refs/heads/master@{#353509}
(cherry picked from commit 3d9a9fc2d3a9944d34980750fbc748b1e4cc19a4)
Review URL: https://codereview.chromium.org/1399443003 .
Cr-Commit-Position: refs/branch-heads/2526@{#90}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
(M47) Time out service workers that take too long to stop
User reports and UMA indicate service workers
sometimes get wedged in STOPPING state, seemingly
indefinitely.
This patch allows the timeout mechanism to
handle the stalled in stopping case. When detected,
the worker thread is "detached", meaning even if
it comes back to life and sends the browser messages
through to embedded worker registry, they are ignored.
BUG=509904
Review URL: https://codereview.chromium.org/1395443002
Cr-Commit-Position: refs/heads/master@{#353329}
(cherry picked from commit 7d6c8353036af4b064206e34bde6ac35911d7fe0)
Review URL: https://codereview.chromium.org/1391993005 .
Cr-Commit-Position: refs/branch-heads/2526@{#89}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Send verification to browser side in ppapi socket when buffer has been read from shared memory.
Also remove dcheck for low latency in AIRH DoCreateStream.
This depends on reverting https://chromium.googlesource.com/chromium/src.git/+/bd6bf6551daa391e301ee00e23d3b86a81dd8f8d
BUG=531635
Review URL: https://codereview.chromium.org/1404453002
Cr-Commit-Position: refs/heads/master@{#353703}
(cherry picked from commit 95e37d6f952eb1dc12cfc5d0336cf240c4ec4fde)
Review URL: https://codereview.chromium.org/1401743003 .
Cr-Commit-Position: refs/branch-heads/2526@{#88}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix hotwording's use of a deprecated function.
MediaStream.stop() has been removed in M47.
BUG=538894
Review URL: https://codereview.chromium.org/1389263003
Cr-Commit-Position: refs/heads/master@{#353487}
(cherry picked from commit 57d22bf475e934c0f249b9a017af8d82e76bdb26)
Review URL: https://codereview.chromium.org/1400133002 .
Cr-Commit-Position: refs/branch-heads/2526@{#87}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Make selection shadow boundaries adjustment to work correctly
This patch makes all call sites of |createWithoutValidation()| of
|VisibleSelectionTemplate| to pass parameters in right order, base, extent,
start, end, TextAffinity, isDirectional, as same as constructor.
This patch also introduces a test case for
|setNonDirectionalSelectionIfNeeded()| in |FrameSelection| class causing
shadow boundaries adjustment with making |FrameSelectionTest| to be derived
from |EditingTestBase| for ease of writing test cases.
Note: This patch fixes regression introduced by http://crrev.com/1384453002
BUG=540811
TEST=webkit_unit_tests --gtest_filter=FrameSelectionTest.setNonDirectionalSelectionIfNeeded
Review URL: https://codereview.chromium.org/1394203002
Cr-Commit-Position: refs/heads/master@{#353232}
(cherry picked from commit 09fd3e7415fedf9e67de0889ff08f6b1dd03580b)
Review URL: https://codereview.chromium.org/1393883005 .
Cr-Commit-Position: refs/branch-heads/2526@{#86}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.14
Cr-Commit-Position: refs/branch-heads/2526@{#85}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add dependency on gfx_vector_icons to autofill_core_browser
autofill_cc_infobar_delegate.cc which is built as part of
autofill_core_browser uses generated vector_icons.h, there
should be an explicit dependency otherwise builds succeed
randomly.
Review URL: https://codereview.chromium.org/1394603003
Cr-Commit-Position: refs/heads/master@{#353305}
(cherry picked from commit f94776e2fcf18c26af89dd4870f7114c8e87538d)
Review URL: https://codereview.chromium.org/1394743003 .
Cr-Commit-Position: refs/branch-heads/2526@{#84}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to M47: PDF: Add an additional check for file:// navigation.
BUG=533520
Review URL: https://codereview.chromium.org/1385423004
Cr-Commit-Position: refs/heads/master@{#353314}
(cherry picked from commit 61f7da7456ecb7577d841e6f7d6b5e7950d45b48)
Review URL: https://codereview.chromium.org/1395493004 .
Cr-Commit-Position: refs/branch-heads/2526@{#83}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Find In Page doesn't correctly highlight wrapped text.
With "white-space: pre-wrap" texts which consist line break,
we get 3 ranges for documentMarker (+ve, +ve) (-ve, +ve) and (-ve, +ve).
So, when we pass -ve offset to SimpleShaper::advance which takes unsigned
value, it converts the -ve offset to very large unsigned value.
Because of this, Font::selectionRectForText "width" comes as "0",
hence no highlight after line break.
Changed SimpleShaper::advance to take int instead of unsigned.
BUG=521047
TBR=pdr
Please Note: It was regression caused by https://codereview.chromium.org/608413002
Review URL: https://codereview.chromium.org/1394833002
Cr-Commit-Position: refs/heads/master@{#353100}
(cherry picked from commit bb8a0772750a23c96d210d8e54cee4b4327611ad)
Review URL: https://codereview.chromium.org/1403793002 .
Cr-Commit-Position: refs/branch-heads/2526@{#82}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Support RTL and vertical writing mode for newline selection highlighting.
BUG=474759
TBR=pdr
Review URL: https://codereview.chromium.org/1386543002
Cr-Commit-Position: refs/heads/master@{#352498}
(cherry picked from commit b8ee31e019fb8170f065cfff8f15a34f2fc52202)
Review URL: https://codereview.chromium.org/1395413002 .
Cr-Commit-Position: refs/branch-heads/2526@{#81}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Updating XTBs based on .GRDs from branch 2526
Cr-Commit-Position: refs/branch-heads/2526@{#80}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Revert from M47: "When in HTML5 fullscreen, the tabs and omnibox should not show"
> When in HTML5 fullscreen, the tabs and omnibox should not show
> up when the mouse hovers at the top.
>
> This code review adds a Sliding Style in Presentation Mode controller
> for this case,
>
> BUG=519763
>
> Review URL: https://codereview.chromium.org/1331903003
BUG=541725
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1396073004 .
Cr-Commit-Position: refs/branch-heads/2526@{#79}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Report connection cancellation due to host version mismatch.
BUG=539927
TBR=jamiewalch
Review URL: https://codereview.chromium.org/1395893003
Cr-Commit-Position: refs/heads/master@{#353378}
(cherry picked from commit 6128404bfc3e3f07e86627049d10293d274ab08f)
Review URL: https://codereview.chromium.org/1396333002 .
Cr-Commit-Position: refs/branch-heads/2526@{#78}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
ButtonCompat: handle missing StateListAnimator gracefully.
ButtonCompat can crash on custom ROMs, when using a framework like Xposed, and
potentially on future versions of Android, because it assumes that the
Widget.Material.Button style contains a stateListAnimator attribute. This is
actually a dangerous assumption, since a future version of Android could change
Widget.Material.Button.
This CL handles this situation gracefully by simply not using a
StateListAnimator on the button if Widget.Material.Button doesn't contain a
stateListAnimator attribute.
BUG=525511
Review URL: https://codereview.chromium.org/1390883007
Cr-Commit-Position: refs/heads/master@{#353454}
(cherry picked from commit 399439d551c3bd915fe180b8c0f3f8e0078623b5)
Review URL: https://codereview.chromium.org/1396323004 .
Cr-Commit-Position: refs/branch-heads/2526@{#77}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Report the Auth method for me2me connections.
As of M46, 20% of the connection failure are due to invalid access code.
We should record the auth method so we can understand if there are
correlations between auth failures and auth methods.
Summary of changes:
1. Reports the AuthMethod in CredentialsProvider.
2. Adds an unittest.
3. Merge the enum remoting.MockClientPlugin.AuthMethod
with remoting.ChromotingEvent.AuthMethod
BUG=539928
TBR=jamiewalch
Review URL: https://codereview.chromium.org/1397463003
Cr-Commit-Position: refs/heads/master@{#353345}
(cherry picked from commit cb01fddc7697aa1fdbda295d9503c88614d85291)
Review URL: https://codereview.chromium.org/1401133002 .
Cr-Commit-Position: refs/branch-heads/2526@{#76}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Protect affiliation-based matches on corresponding web sites.
BUG=539879
[email protected]
Review URL: https://codereview.chromium.org/1393003002
Cr-Commit-Position: refs/heads/master@{#353049}
(cherry picked from commit 493a1b68b97379cc6acd9a740f236ac007edb591)
Review URL: https://codereview.chromium.org/1396323003 .
Cr-Commit-Position: refs/branch-heads/2526@{#75}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Update chrome://webrtc-internals audio recordings info text.
Also set max width of that paragraph.
This is a follow-up to https://codereview.chromium.org/1272223003/
BUG=516584,541286
Review URL: https://codereview.chromium.org/1399713003
Cr-Commit-Position: refs/heads/master@{#353518}
(cherry picked from commit ecdd295dfbcc389b77f0b82a5788f27b92ba6d87)
Review URL: https://codereview.chromium.org/1396313003 .
Cr-Commit-Position: refs/branch-heads/2526@{#74}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add a method for programmatically causing WebView to generate a minidump.
In certain (as yet undiagnosed) circumstances it seems possible
for WebView instances to appear to become unresponsive, without
crashing. In order to debug this case, add
AwDebug.dumpWithoutCrashing(File) - which allows a caller to use
the breakpad minidump mechanism to produce a dump that can be
processed to extract useful information about the state of the
WebView threads.
(NOPRESUBMIT to bypass ScopedAllowIO restriction; per comment in
aw_debug.cc, this is meant to be used when WebView is in an
undefined state, and posting I/O to another thread is impossible)
BUG=537579
NOPRESUBMIT=TRUE
NOTRY=TRUE
Review URL: https://codereview.chromium.org/1384823004
Cr-Commit-Position: refs/heads/master@{#353504}
(cherry picked from commit 26bcca1cafa64ca66c45490a1b7efd9ca58bc414)
Review URL: https://codereview.chromium.org/1389283004 .
Cr-Commit-Position: refs/branch-heads/2526@{#73}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Browser test for Goodies Displayer
BUG=522666
Browser test to verify that Goodies promo page appears when
appropriate on first display of browser.
This file was originally included and reviewed in
https://codereview.chromium.org/1378393004/#ps1
The test itself has been separated here from other code changes.
Review URL: https://codereview.chromium.org/1399553002
Cr-Commit-Position: refs/heads/master@{#353151}
(cherry picked from commit 1f16d005c233ec4d0e7816617b30b36339bf863b)
Review URL: https://codereview.chromium.org/1397323003 .
Cr-Commit-Position: refs/branch-heads/2526@{#72}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.13
Cr-Commit-Position: refs/branch-heads/2526@{#71}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.12
Cr-Commit-Position: refs/branch-heads/2526@{#70}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.11
Cr-Commit-Position: refs/branch-heads/2526@{#69}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Notifications: Fixes crash due to re-entrancy of MarkSinglePopupAsShown.
Due to the interaction between notification blockers and MessageCenterObservers,
it was possible to get a reentrancy condition in MessageCenterImpl that would
try to dereference a NULL pointer.
BUG=538321
Review URL: https://codereview.chromium.org/1391493002
Cr-Commit-Position: refs/heads/master@{#353101}
(cherry picked from commit 1640cb731b35b93d2e4c0d05b90c56908997b5e9)
Review URL: https://codereview.chromium.org/1398223002 .
Cr-Commit-Position: refs/branch-heads/2526@{#68}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Merge to M47] Add net_logging for Safe Browsing, using a separate Source.
Since events are added only for async checks, they rarely show up
on desktop but always show up on Android.
BUG=519743
Review URL: https://codereview.chromium.org/1379703002
Cr-Commit-Position: refs/heads/master@{#352343}
(cherry picked from commit 3fe24b327f8687a8a818cf9bae3e5feb5062b6f7)
Review URL: https://codereview.chromium.org/1402583002 .
Cr-Commit-Position: refs/branch-heads/2526@{#67}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Double merge:
1 - Fix broken search engine detection
BUG=540854
Review URL: https://codereview.chromium.org/1390333002
Cr-Commit-Position: refs/heads/master@{#352970}
(cherry picked from commit 230a6cc1034e196f24425502c50cd3d395995f2e)
2 - Fix explicit search engine adding (window.external.AddSearchProvider)
This was broken by 230a6cc1034e196 --- we actually need both
OnMessageReceived functions because the AddSearchProvider IPC is still
the RenderView-specific version (only <link> was updated to the
RenderFrame-specific IPC).
BUG=540854
Review URL: https://codereview.chromium.org/1396903002
Cr-Commit-Position: refs/heads/master@{#353142}
(cherry picked from commit 959263e7afa929c869381ed5d8e88ef25ae5fbae)
Review URL: https://codereview.chromium.org/1396013003 .
Cr-Commit-Position: refs/branch-heads/2526@{#66}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Remove title from date picker dialog.
On Android L+, the date picker dialog uses a design that looks bad with
a title at the top. By default, the DatePickerDialog on L+ doesn't show
a title. However, Chrome triggers a bug in DatePickerDialog (by calling
updateDate() before the dialog has been shown), which causes the title to
appear. This CL works around that bug.
BUG=541350
Review URL: https://codereview.chromium.org/1395913003
Cr-Commit-Position: refs/heads/master@{#353343}
(cherry picked from commit 1bf5ae0bedabc2ec5110e798b9dcc8e3466c7f7f)
Review URL: https://codereview.chromium.org/1397153002 .
Cr-Commit-Position: refs/branch-heads/2526@{#65}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Remove stash_client.js dependency on unload_event.js
unload_event is problematic because it runs JS at inopportune times, in the
main world. This allows arbitrary web content to run JS at a time when
certain invariants in Blink may not hold true.
Unfortunately, the mojo version of the serial API depends on stash_client's
current implementation. Fortunately, it's not actually used in release yet.
BUG=537660
Review URL: https://codereview.chromium.org/1381563007
Cr-Commit-Position: refs/heads/master@{#352231}
(cherry picked from commit 4dcf62a421fce8a8bd715d5dd6ff9d8f52557eae)
Review URL: https://codereview.chromium.org/1396153002 .
Cr-Commit-Position: refs/branch-heads/2526@{#64}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix cannot launch new window from hamburger menu.
The |launchData| is null when this is invoked from
an IPC (e.g. the new window menu item). We do not
have the same problem on public session in ChromeOS
as the menu is not present.
BUG=540915
TBR=jamiewalch
Review URL: https://codereview.chromium.org/1395563003
Cr-Commit-Position: refs/heads/master@{#353096}
(cherry picked from commit 0b6fcd197da94a1f2537c2deab8807f2f140f0db)
Review URL: https://codereview.chromium.org/1397143002 .
Cr-Commit-Position: refs/branch-heads/2526@{#63}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Disable new tab animations on svelte.
This was accidentally removed in some cleanup downstream.
BUG=531785
Use the tab URL as a fallback title on the svelte tab switcher.
Currently if you open tabs in the background in svelte, the title
in the tab switcher is "Loading..." until you access it. This
changes it to use the URL if available.
BUG=None
Review URL: https://codereview.chromium.org/1399603002
Review URL: https://codereview.chromium.org/1398843002
Cr-Commit-Position: refs/heads/master@{#353189}
Cr-Commit-Position: refs/heads/master@{#353185}
Review URL: https://codereview.chromium.org/1399073002 .
Cr-Commit-Position: refs/branch-heads/2526@{#62}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix an issue that an invalid surface could be passed to MediaPlayerBridge
When entering fullscreen, setVideoSurface() can be called before
OnMediaPrepared().
It is then possible that user immediately exits fullscreen video.
In that case, when onMediaPrepared() is called, the surface is already
released.
We need to check whether a surface is valid or not before passing it to
MediaPlayer.
TBR=sievers
BUG=540990
Review URL: https://codereview.chromium.org/1398703003
Cr-Commit-Position: refs/heads/master@{#353219}
(cherry picked from commit ddcd5f8b7c909bd437576411498008d4450239da)
Throttle media decoding after excessive Android media server crashes
This change adds a watch dog player to listen to android MediaServer
crashes.
When the number of crashes reaches a certain threshold,
all media decoding using Android MediaPlayer/MediaCodec will be throttled.
This will throttle both media and webaudio implementation.
BUG=532745
Review URL: https://codereview.chromium.org/1372203002
Cr-Commit-Position: refs/heads/master@{#352740}
(cherry picked from commit b2341d25796fe6f94fb9a2d00104f2f88ca67a7c)
Review URL: https://codereview.chromium.org/1393673005 .
Cr-Commit-Position: refs/branch-heads/2526@{#61}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Throttle media decoding after excessive Android media server crashes
This change adds a watch dog player to listen to android MediaServer
crashes.
When the number of crashes reaches a certain threshold,
all media decoding using Android MediaPlayer/MediaCodec will be throttled.
This will throttle both media and webaudio implementation.
BUG=532745
TBR=tedchoc, jochen, cpu,
Review URL: https://codereview.chromium.org/1372203002
Cr-Commit-Position: refs/heads/master@{#352740}
(cherry picked from commit b2341d25796fe6f94fb9a2d00104f2f88ca67a7c)
Review URL: https://codereview.chromium.org/1394793003 .
Cr-Commit-Position: refs/branch-heads/2526@{#60}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Added Network Quality Estimator Real-time interface to Cronet
BUG=502423
Review URL: https://codereview.chromium.org/1273173002
Cr-Commit-Position: refs/heads/master@{#352732}
(cherry picked from commit f1b6738e27e2e31e5f8da99f3367ccb3d3c2911f)
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1397843002 .
Cr-Commit-Position: refs/branch-heads/2526@{#59}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Devtools: Fix resume button in overlay
BUG=538892
Review URL: https://codereview.chromium.org/1397633002
Cr-Commit-Position: refs/heads/master@{#352996}
(cherry picked from commit ac0b00a011dac09c5d6ac69ba990902018c0384b)
Review URL: https://codereview.chromium.org/1403513002 .
Cr-Commit-Position: refs/branch-heads/2526@{#58}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Increase Web Notification timeout to 20 seconds
Data from partners suggests this improves re-engagement. We intend to
revisit this in m48 with a Finch experiment.
BUG=530697
Review URL: https://codereview.chromium.org/1395483002
Cr-Commit-Position: refs/heads/master@{#352904}
(cherry picked from commit 07e31a310e07d3aa8a07c45670e70e89094317b7)
Review URL: https://codereview.chromium.org/1395103002 .
Cr-Commit-Position: refs/branch-heads/2526@{#57}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge: Fix crash while trying to close a file which has not been opened.
The code wrongly assumed that aborted requests for opening files would return
a file handle equal to -1, while 0 is used.
This CL fixes all occurences of -1 used as undefined file handle, so only 0
is used.
Also, assigning the file handle in ScopedFileOpener is done only when opening
is successful.
The code had been tested, but a testing stub TestingFileSystem implementation
used -1 for undefined file handles, not 0 as used in the real implementation.
TEST=unit_tests: *ScopedFileOpener*CloseAfterAborting*
BUG=530119
Review URL: https://codereview.chromium.org/1382333002
Cr-Commit-Position: refs/heads/master@{#352306}
(cherry picked from commit 1758076abc9616ac423d14a202044c707e8c9442)
Review URL: https://codereview.chromium.org/1398703006 .
Cr-Commit-Position: refs/branch-heads/2526@{#56}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Material PDF: Improve visibility of loading bar
Switches the progress bar to a thin blue line across the bottom of the
PDF toolbar. Also makes the document filename visible in the toolbar as
the document is loading.
BUG=538487
Review URL: https://codereview.chromium.org/1386033004
Cr-Commit-Position: refs/heads/master@{#352781}
(cherry picked from commit d94201a1317bbf73fa7cf35710728ca9622ec502)
[email protected]
Review URL: https://codereview.chromium.org/1395433004 .
Cr-Commit-Position: refs/branch-heads/2526@{#55}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.10
Cr-Commit-Position: refs/branch-heads/2526@{#54}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
(Merging to M47) Add a flag use_software_compositing to the Widget::InitParams structure
This flag when set will force the widget to use the software compositor on Windows. Currently only the menu
omnibox drop down and status bubble widgets set this flag. The flag defaults to false.
This removes the old hack of using the menu type to determine whether the software compositor should be used
on Windows.
BUG=508717
TBR=sky
Review URL: https://codereview.chromium.org/1380973003
Cr-Commit-Position: refs/heads/master@{#352405}
(cherry picked from commit 82c3ae62ef39c74658610a3f4b28cc99c9c60287)
Review URL: https://codereview.chromium.org/1395003002 .
Cr-Commit-Position: refs/branch-heads/2526@{#53}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix NTP side-swipe.
Set the theme-color of the NTP with a logo to COLOR.White
BUG=535235
[email protected]
Review URL: https://codereview.chromium.org/1390903005 .
Cr-Commit-Position: refs/branch-heads/2526@{#52}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Improve reconnect behavior.
Summary of changes:
1. Dispose the desktop activity before reconnecting, otherwise
the desktop activity will be set to null AFTER the
re-connection.
2. Drop the session after 30s of suspension as we cannot
recover from the connection loss after 30s.
3. Add an integration test for the reconnect behavior.
4. Implements a NetworkConnectivityDetector that provides a
reliability way of detecting network connectivity with
unittest.
5. Simplify the SmartReconnector to use NetworkConnectivityDetector.
6. Add a dispose method on AutoRetryXhr.
BUG=537812,536877
TBR=jamiewalch
Review URL: https://codereview.chromium.org/1382593007
Cr-Commit-Position: refs/heads/master@{#352948}
(cherry picked from commit bdf351e541afa34f8fcf178a7f86ea548d436f6f)
Review URL: https://codereview.chromium.org/1394553003 .
Cr-Commit-Position: refs/branch-heads/2526@{#51}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Material PDF: Replace paper-tooltip with native title-attribute tooltips
Paper-tooltip has some minor design and behavior problems which make it
poorly suited to Material PDF at the moment.
BUG=489715,537166,537082,536677,535951
Review URL: https://codereview.chromium.org/1388873002
Cr-Commit-Position: refs/heads/master@{#352545}
(cherry picked from commit a65ad8d1b7a9090ecaafde5a93c2a45076744847)
[email protected]
Review URL: https://codereview.chromium.org/1397943002 .
Cr-Commit-Position: refs/branch-heads/2526@{#50}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merged: Fix MediaStatistics race condition with MediaSourcePlayer
Right now the MediaStatistics object can be accessed by
MediaDecoderJob on the decoder thread even after the MediaStatistics
is deleted on UI thread together with the MediaSourcePlayer that
owns it.
This CL propagates the late frame event to the MediaDecoderCallback()
which then accesses the MediaStatistics solely on UI thread.
If the MediaSourcePlayer is deleted the MediaDecoderCallback won't
reach the destination because of a weak pointer.
The parallel MediaCodecPlayer should not have this problem because
there decoder threads are always stopped before the player deletion.
BUG=407577, 539685
TBR=timav, qinmin
> Review URL: https://codereview.chromium.org/1385313002
> Cr-Commit-Position: refs/heads/master@{#352929}
Review URL: https://codereview.chromium.org/1396963002 .
Cr-Commit-Position: refs/branch-heads/2526@{#49}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Goodies Displayer: Code improvements and plumbing for browser tests
BUG=522666
TEST=Same as
https://codereview.chromium.org/1345093004
The CL originally contained the browser test itself. That was separated out in Patch Set#2, and will follow as a subsequent CL.
Review URL: https://codereview.chromium.org/1378393004
Cr-Commit-Position: refs/heads/master@{#352710}
(cherry picked from commit b7411ef6fdbf05b387fa278f3bdb25bc956fea6f)
Review URL: https://codereview.chromium.org/1395913002 .
Cr-Commit-Position: refs/branch-heads/2526@{#48}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Show password generation pop-up after page refresh.
Password generation agent assumes that navigation to a new page or page
refresh will clear the form cache and re-query the autofill server. This
assumption broke after http://crrev.com/ffc78e28 started ignoring page
refresh. The result was unavailability of the password generation pop-up
after page refresh.
This patch restores the previous behavior of clearing the form cache on
page refresh. This triggers re-querying of the autofill server and
correctly showing password generation pop-ups.
BUG=530569
TEST=Open facebook.com, refresh, password generation should be available.
Review URL: https://codereview.chromium.org/1392633002
Cr-Commit-Position: refs/heads/master@{#352958}
(cherry picked from commit 6f1f93c861eb9241bc5aef0c0e1a46516c5d6520)
Review URL: https://codereview.chromium.org/1398883002 .
Cr-Commit-Position: refs/branch-heads/2526@{#47}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Android] Fix a timing issue on startup that could leave the UI inoperable.
If you start up Chrome on Android, immediately hit the home button,
wait long enough for the native libraries to fully load, and then return
to Chrome, it will sometimes leave the UI unfunctional with no tab
content shown. You'll be able to focus the omnibox, but nothing beyond
that works.
This was caused by a slightly different timing of the predraw listener
used to signal first draw and the activities logic of determining
whether the first draw occured. This removes the activities handling
and makes the predraw listener the only signal.
BUG=538341
Review URL: https://codereview.chromium.org/1384373002
Cr-Commit-Position: refs/heads/master@{#352934}
Review URL: https://codereview.chromium.org/1398813002 .
Cr-Commit-Position: refs/branch-heads/2526@{#46}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Presentation API: Presentation interface shouldn't be an EventTarget.
The spec changed (moved events to PresentationRequest) but we forgot to
remove the EventTarget inheritance. This CL is a simple one that removes
the web visible EventTarget inheritance so we can cherry-pick to M47.
Another CL will do the cleanup in the C++ code.
BUG=539883
[email protected]
Review URL: https://codereview.chromium.org/1388103002
Cr-Commit-Position: refs/heads/master@{#352871}
(cherry picked from commit e94eba9941d057b79c53e412fac77ca071502408)
Review URL: https://codereview.chromium.org/1393183003 .
Cr-Commit-Position: refs/branch-heads/2526@{#45}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Presentation API: remove navigator.presentation.connection.
This is no longer part of the specification and need to be removed.
BUG=539855
[email protected]
Review URL: https://codereview.chromium.org/1388953002
Cr-Commit-Position: refs/heads/master@{#352860}
(cherry picked from commit 64517f54f42ffa182ecade9af5ce7cb6e9719bee)
Review URL: https://codereview.chromium.org/1393363002 .
Cr-Commit-Position: refs/branch-heads/2526@{#44}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Android] Fix most visited thumbnail scaling.
This fixes a bug where thumbnails for most visited sites on the NTP were
incorrectly scaled and cropped. Previously, these thumbnails were just
cutouts of the upper left corner of the page. Now, the thumbnails are
scaled down screenshots of the entire page, just like on desktop.
This change moves some of the capturing logic from the Java side of
ThumbnailTabHelper to the C++ side, and eliminates some roundtrips
between C++ and Java. Of special note, we're no longer converting
thumbnails from SkBitmaps to Java Bitmaps and back to SkBitmaps before
storing them in the thumbnail database.
BUG=534668
Review URL: https://codereview.chromium.org/1393673002
Cr-Commit-Position: refs/heads/master@{#352937}
(cherry picked from commit 4b0739defcac390878c6a692a387be2b3fb65e29)
Review URL: https://codereview.chromium.org/1397813002 .
Cr-Commit-Position: refs/branch-heads/2526@{#43}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.9
Cr-Commit-Position: refs/branch-heads/2526@{#42}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fixing EasyUnlockAuthAttempt to correctly unlock the screen.
When the |kEnableBluetoothLowEnergyDiscovery| flag is set, the
easy_unlock background app is loaded, but does not register any event
listener.
So, when an auth attempt is started the call to
|app_manager_->SendAuthAttemptEvent()| returns false, as there is no
listener to the |screenlock::OnAuthAttempted| event.
BUG=539830
Review URL: https://codereview.chromium.org/1388083002
Cr-Commit-Position: refs/heads/master@{#352809}
(cherry picked from commit 8c0e608099033b74db97c5777091084c9f90cd77)
Review URL: https://codereview.chromium.org/1399563002 .
Cr-Commit-Position: refs/branch-heads/2526@{#41}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix layout problem during supervised user creation.
The problem was caused by a blink change, which modified the behavior of the old, deprecated, and never-quite-fully-defined -webkit-box.
BUG=537947
Review URL: https://codereview.chromium.org/1395473002
Cr-Commit-Position: refs/heads/master@{#352843}
(cherry picked from commit 6d6e7e1e6321a5ec2539c0ec13e6cd1222d513f0)
Review URL: https://codereview.chromium.org/1394873002 .
Cr-Commit-Position: refs/branch-heads/2526@{#40}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add missing header
Fixing ios official after https://codereview.chromium.org/1382143004
BUG=508014
Review URL: https://codereview.chromium.org/1390713002
Cr-Commit-Position: refs/heads/master@{#352571}
(cherry picked from commit 5b5ced3b34e6c84dbf0f411d1a79bd5eadb174f1)
Review URL: https://codereview.chromium.org/1395583003 .
Cr-Commit-Position: refs/branch-heads/2526@{#39}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
This CL fixes the issue with login using alternative e-mails.
If new user is added, we lookup if it already exists by e-mail.
This CL also adds lookup by gaia_id, and adds gaia_id support
for telemetry test API.
BUG=535369
TEST=manual
Committed: https://crrev.com/0f37b696b7a814d4157401c304643594a4ae9731
Cr-Commit-Position: refs/heads/master@{#351482}
Review URL: https://codereview.chromium.org/1370913002
Cr-Commit-Position: refs/heads/master@{#352574}
(cherry picked from commit b3b38a1ef3e858d0f8dc0b2c2ea96aabb9688647)
[email protected]
Review URL: https://codereview.chromium.org/1394723002 .
Cr-Commit-Position: refs/branch-heads/2526@{#38}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.8
Cr-Commit-Position: refs/branch-heads/2526@{#37}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix regression with background tab alpha region.
I introduced an off-by-one error in the calculation of the rectangle. Based on
a better understanding of how I want to use the tab insets in both normal and
material modes, switched to using these to calculate the relevant region, which
fixes the error and should continue to work once I land the MD tabstrip.
BUG=538446
TEST=Run Chrome on Windows 7, open some background tabs, ensure they dont' have a bright line at the bottom.
[email protected]
Review URL: https://codereview.chromium.org/1393683002 .
Cr-Commit-Position: refs/heads/master@{#352749}
(cherry picked from commit 60eb53948ec424a8363159cd93c5549785e6aaf2)
Review URL: https://codereview.chromium.org/1392093002 .
Cr-Commit-Position: refs/branch-heads/2526@{#36}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Setting chrome as the default browser is now fixed on Windows 10
BUG=531649
Review URL: https://codereview.chromium.org/1349163008
Cr-Commit-Position: refs/heads/master@{#352526}
(cherry picked from commit f89ac7c739d5b0ba039af8cabac76a74ff3b2b54)
[email protected]
Review URL: https://codereview.chromium.org/1397563002 .
Cr-Commit-Position: refs/branch-heads/2526@{#35}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix toolbar_layer bounds size.
We modify the size of resource padding to include the padding of the
tab strip, however the toolbar_layer should include the tab strip in
its bounds.
This fixes the flickering when we enable shadow clipping for one frame.
This is a hack around another fix https://chromiumcodereview.appspot.com/1379123003
BUG=482207
[email protected]
Review URL: https://codereview.chromium.org/1390303002 .
Cr-Commit-Position: refs/branch-heads/2526@{#34}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Don't select the composition in finishComposition when not dirty.
The selectComposition() call in finishComposition is purely to select
the text to clobber, so in the non-dirty path where we don't clobber the
text, we shouldn't be touching the selection either.
NOTRY=true
BUG=539973
Review URL: https://codereview.chromium.org/1385403002
Cr-Commit-Position: refs/heads/master@{#352778}
(cherry picked from commit 8d68c13948bbc558636ebc5fd5b3f4168ebe3ade)
Review URL: https://codereview.chromium.org/1390283002 .
Cr-Commit-Position: refs/branch-heads/2526@{#33}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix in-progress download icon
Partial revert of r351375
[email protected]
[email protected]
BUG=539241
TEST=manual
Review URL: https://codereview.chromium.org/1387203003
Cr-Commit-Position: refs/heads/master@{#352626}
(cherry picked from commit d199007ce24efaa1282783fc880ffe7b7ea00d81)
Review URL: https://codereview.chromium.org/1393063002 .
Cr-Commit-Position: refs/branch-heads/2526@{#32}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix custom tabs toolbar height.
BUG=539951
[email protected]
Review URL: https://codereview.chromium.org/1391333002 .
Cr-Commit-Position: refs/branch-heads/2526@{#31}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.7
Cr-Commit-Position: refs/branch-heads/2526@{#30}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Revert "Use resource throttle to implement shouldOverrideUrlLoading, core change"
Reverting because of crbug.com/534758, to fix that bug we will have to
make a blink change adding a callback (or changing the existing callback
) to let WebView know when a document is not longer loading. The current
callback DidFinishLoad does not fire if a new load is in its provisional
state, which is sometimes the case if we load a webpage containing a
redirect in the form of a href assignment: window.location.href = '...'.
This revert was not clean because of the transition to using
NavigationThrottles over in https://codereview.chromium.org/1363483007
This reverts commit 777bb78a111aee919e07f5206267915a87639f88.
[email protected],[email protected]
NOPRESUBMIT=true
NOTRY=true
BUG=534758
Review URL: https://codereview.chromium.org/1375993004
Cr-Commit-Position: refs/heads/master@{#352318}
(cherry picked from commit e5c3091df04749b232359b6ef22938006af840d5)
Review URL: https://codereview.chromium.org/1383373003
Cr-Commit-Position: refs/branch-heads/2526@{#29}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
crazy linker: Alter search for zip EOCD start
When loading directly from APK, begin searching backwards
for the zip EOCD record signature at size of EOCD record
bytes before the end of the file.
BUG=537205
[email protected]
Review URL: https://codereview.chromium.org/1390553002 .
Cr-Commit-Position: refs/heads/master@{#352577}
(cherry picked from commit d9e316238aee59acf665d80b544cf4e1edfd3349)
Review URL: https://codereview.chromium.org/1393813003 .
Cr-Commit-Position: refs/branch-heads/2526@{#28}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Do not allow federated logins saved from Android apps to be affiliated matches.
BUG=539833
[email protected],[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1385563007
Cr-Commit-Position: refs/heads/master@{#352589}
(cherry picked from commit 4e13fe538e97fefaa9044b70e152a3c5c808fd36)
Review URL: https://codereview.chromium.org/1394443002 .
Cr-Commit-Position: refs/branch-heads/2526@{#27}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Disable download notification by default
We need to disable the feature on the M47 branch. To do it, this patch disables it on ToT to merge the patch to the branch.
This is the cherry-pick of crrev.com/175c6d056fdf13de95531b780659ef0692260e1d
BUG=539383
TEST=manually tested
[email protected]
Review URL: https://codereview.chromium.org/1385013003
Cr-Commit-Position: refs/heads/master@{#352370}
(cherry picked from commit f45884bb2ffe5011ea47aa6c274873394d57fcfe)
Review URL: https://codereview.chromium.org/1386423002 .
Cr-Commit-Position: refs/branch-heads/2526@{#26}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
ChromeOS: Fix crash in TimezoneSettingsImpl::SetTimezone.
File manager should unsuscribe from TimezoneSettings on shutdown.
BUG=534638
TEST=manual
Review URL: https://codereview.chromium.org/1378223004
[email protected]
Cr-Commit-Position: refs/heads/master@{#352560}
(cherry picked from commit 7014fec66ccde8f17e9b3c96b05d6b2c3709a0a5)
Review URL: https://codereview.chromium.org/1388313002 .
Cr-Commit-Position: refs/branch-heads/2526@{#25}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Make the hotword promo work for images.google.com.
On eligible devices, the hotword promo will now be shown on
images.google.com, just like on other Google search pages.
BUG=539726
Review URL: https://codereview.chromium.org/1383133005
Cr-Commit-Position: refs/heads/master@{#352523}
(cherry picked from commit f0abd90ba5e64dd26933125ea84f7e620f099002)
[email protected]
Review URL: https://codereview.chromium.org/1390103002 .
Cr-Commit-Position: refs/branch-heads/2526@{#24}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Show a red icon in connection info for 2017 SHA-1.
Also:
- Rename SHA1 deprecation-related constants to use MAJOR vs. MINOR instead of BROKEN vs. WARNING.
- Update the strings to distinguish between 2016 and 2017 (using the strings from the DevTools Security panel).
BUG=501904
Review URL: https://codereview.chromium.org/1380363002
Cr-Commit-Position: refs/heads/master@{#352459}
(cherry picked from commit cc53de2b2ed19e10fdfe26eb8b32b38d046e4835)
Review URL: https://codereview.chromium.org/1393663002 .
Cr-Commit-Position: refs/branch-heads/2526@{#23}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to M47: Use the new PDFium init API.
This is a manual, partial merge of https://crrev.com/352254 AKA
commit b331e81dd0357eb0c483cfac3e3fe2a594fe54ef
[email protected]
Original Review URL: https://codereview.chromium.org/1383783003
BUG=531339
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1391763002
Cr-Commit-Position: refs/branch-heads/2526@{#22}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge to 2526: [DevTools] Do not show blocked resource twice if it was preloaded.
> [DevTools] Do not show blocked resource twice if it was preloaded.
>
> BUG=535047
>
> Review URL: https://codereview.chromium.org/1380243002
>
> Cr-Commit-Position: refs/heads/master@{#352446}
(cherry picked from commit f1e3f3902ca40c3b81a2c4a8a6057f16db410898)
Review URL: https://codereview.chromium.org/1386293002 .
Cr-Commit-Position: refs/branch-heads/2526@{#21}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
[Presentation API, Android, Cast] Remove the detached route once the joined route was created.
This prevents us from keeping more than one route when a page is reloaded.
BUG=538621
Review URL: https://codereview.chromium.org/1375083004
Cr-Commit-Position: refs/heads/master@{#352590}
(cherry picked from commit f9f1dd9352c9e2ef8305ce7d29e5575a2c1c80a5)
Review URL: https://codereview.chromium.org/1383983005 .
Cr-Commit-Position: refs/branch-heads/2526@{#20}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Implementing joining Cast routes
Don't close the route when the presentation session is detached.
Implement joinRoute in ChromeMediaRouter.
Respect various Cast join policies and "auto-join" presentation id.
Pass the tab id and origin from create route to RouteController for that.
Rename SessionWrapper to CastRouteController.
BUG=538621
Review URL: https://codereview.chromium.org/1379403002
Cr-Commit-Position: refs/heads/master@{#352583}
(cherry picked from commit 164135f3ab335aeeeb0c2cccf7b0b2a80ae4693d)
Review URL: https://codereview.chromium.org/1385563008 .
Cr-Commit-Position: refs/branch-heads/2526@{#19}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Delete data usage from Data Saver when browsing history is cleared.
The data reduction proxy component can maintain detailed data usage.
This cl clears this information when browsing data is cleared with the
browsing history checkbox checked.
BUG=534946
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng
Committed: https://crrev.com/f7530c056309d44cee18533276f4237f97205686
Cr-Commit-Position: refs/heads/master@{#352111}
Review URL: https://codereview.chromium.org/1378113002
Cr-Commit-Position: refs/heads/master@{#352371}
(cherry picked from commit c122f3a42de75889a900e30dc9d30f23e3f7b786)
Review URL: https://codereview.chromium.org/1379033004 .
Cr-Commit-Position: refs/branch-heads/2526@{#18}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Merge "Invalidate plugin when unavailable reason changes"
BUG=501187
TEST=paint/invalidation/unavailable-plugin-crash.html
> Review URL: https://codereview.chromium.org/1386743002
> Cr-Commit-Position: refs/heads/master@{#352243}
Review URL: https://codereview.chromium.org/1389803004 .
Cr-Commit-Position: refs/branch-heads/2526@{#17}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Update compositor IsActive when view visibility changes.
When WebView enables blink page visibility API, View visibility factors
into calculating WebView's visibility and the compositor's "is_active" state.
WebView apps might put WebView invisible when loading a URL and set
the view to be visible onPageFinished. WebView needs to make the
compositor active when that happens.
BUG=520089
Review URL: https://codereview.chromium.org/1381913004
Cr-Commit-Position: refs/heads/master@{#352483}
(cherry picked from commit 13dafe7dab6be582781b026df6198721a02475e1)
Review URL: https://codereview.chromium.org/1386153003 .
Cr-Commit-Position: refs/branch-heads/2526@{#16}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Call EnsureNSSHttpIOInit in the chimera build.
Otherwise we end up using the default NSS client and not
SystemURLRequestContext.
This is a minimal fix to be merged onto release branches.
A follow-up will revise this to be somewhat less error-prone.
BUG=539520
TEST=Open about:net-internals on Linux or Chrome OS
Visit https://incomplete-chain.badssl.com/ in a new tab
The Events tab of about:net-internals should show a fetch for http://crt.comodoca.com/COMODORSADomainValidationSecureServerCA.crt
Review URL: https://codereview.chromium.org/1384343002
Cr-Commit-Position: refs/heads/master@{#352536}
(cherry picked from commit a477a70ad63769c456ed87b78830e2ccbf75d583)
[email protected]
Review URL: https://codereview.chromium.org/1385473003 .
Cr-Commit-Position: refs/branch-heads/2526@{#15}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Add UMA stats for "remove user" on Chrome OS
With this CL, we collect stats whenever "remove user" is clicked on the
login screen or on the settings page.
BUG=539297
TEST=Manual
Review URL: https://codereview.chromium.org/1382363002
Cr-Commit-Position: refs/heads/master@{#352321}
(cherry picked from commit e1e425d84772b6eaa4321c989bd04686c9e743d0)
Review URL: https://codereview.chromium.org/1388483005 .
Cr-Commit-Position: refs/branch-heads/2526@{#14}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
WebMediaPlayerAndroid: create all texture bits if needed on a MediaPlayerPlay signal.
When the MediaPlayerPlay signal is sent, the WebMediaPlayer might no
longer have a valid stream texture proxy and peer for it. We need to
make sure it is correctly set, the same way would if the user presses
the play button.
A real example where this fails is if a MediaSession resumes a video
that was being played fullscreen and left the fullscreen state. It will
resume in a non fullscreen state but the WebMediaPlayerAndroid instance
will not be reset correctly.
BUG=535137
[email protected]
Review URL: https://codereview.chromium.org/1384273002
Cr-Commit-Position: refs/heads/master@{#352380}
(cherry picked from commit 9061e0756c36fbf65b90c652fdb1ccc4c832ac62)
Review URL: https://codereview.chromium.org/1387653004 .
Cr-Commit-Position: refs/branch-heads/2526@{#13}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.6
Cr-Commit-Position: refs/branch-heads/2526@{#12}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Revert "Flip the official Linux x64 chrome builder from GYP to GN."
This reverts commit 91a7ca6046d9b8a80696d68a98f0f9a094bdbe1b.
[email protected]
BUG=538972
Review URL: https://codereview.chromium.org/1387063002 .
Cr-Commit-Position: refs/branch-heads/2526@{#11}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Incrementing VERSION to 47.0.2526.5
Cr-Commit-Position: refs/branch-heads/2526@{#10}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Fix XP builds after r352208.
I had a temporary use of a Vista+ function that I forgot to switch to the wrapper. Also GetFileInformationByHandleEx has to be wrapped.
[email protected]
BUG=478251
Review URL: https://codereview.chromium.org/1389513002
Cr-Commit-Position: refs/heads/master@{#352238}
(cherry picked from commit f2a730174378e9cb79abf9cdc14976aefe807127)
Review URL: https://codereview.chromium.org/1383053004 .
Cr-Commit-Position: refs/branch-heads/2526@{#9}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
Offset the toolbar background by tab strip height on tablets.
BUG=539244
[email protected]
Review URL: https://codereview.chromium.org/1389753002 .
Cr-Commit-Position: refs/branch-heads/2526@{#8}
Cr-Branched-From: cb947c0153db0ec02a8abbcb3ca086d88bf6006f-refs/heads/master@{#352221}
