Publish DEPS for Chromium 47.0.2508.0
Roll src/third_party/WebKit cb2fc66:3f5ec21 (svn 202160:202162)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb2fc66..3f5ec21
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332403003
Cr-Commit-Position: refs/heads/master@{#348482}
ozone: drm: Crash immediately if no usable GPU is found
If we get past here without finding the primary DRM device, it'll crash
later with a less useful message.
Review URL: https://codereview.chromium.org/1335193004
Cr-Commit-Position: refs/heads/master@{#348481}
Prevent Task Manager from appearing twice in Mac Window menu.
The Window menu contains a Task Manager item that reveals the Task
Manager panel. But once revealed, a second Task Manager item appears at
the bottom of the Window menu. This change prevents the Task Manager
from appearing a second time at the bottom of the menu.
BUG=529966
Review URL: https://codereview.chromium.org/1335973003
Cr-Commit-Position: refs/heads/master@{#348480}
Change TranslateHelper to use DidStartProvisionalLoad.
Instead of an IPC-driven Navigate, let's use a more gentle
(and accurate) DidStartProvisionalLoad, which comes up from
Blink-side.
BUG=521166
R=andrewhayden,creis,thakis
Review URL: https://codereview.chromium.org/1324503004
Cr-Commit-Position: refs/heads/master@{#348479}
binutils: Embed a relative path to the LLVM lib directory in binaries' rpaths.
This ensures that the correct version of libstdc++ is loaded by gold
before it loads the LLVM LTO plugin. See bug for details.
BUG=521143
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330433002
Cr-Commit-Position: refs/heads/master@{#348478}
Fixes for 32-bit official GN build.
Uses the host toolchain for the dump symbol and stack walk utilities.
Remove the dummy nacl target when nacl is disabled. Previously there was a dummy nacl target but no dummy nacl_helper target. They should be consistent. It turns out we use neither when nacl is disabled, so I removed the existing one.
Unrelated: Update GN quick start with a link to the new sites page I made
for build arguments.
Review URL: https://codereview.chromium.org/1339653004
Cr-Commit-Position: refs/heads/master@{#348477}
Roll src/third_party/WebKit 8b54c1f:cb2fc66 (svn 202157:202160)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8b54c1f..cb2fc66
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336053003
Cr-Commit-Position: refs/heads/master@{#348476}
Remove a bunch of unreferenced resource images.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1339773002
Cr-Commit-Position: refs/heads/master@{#348475}
ipc: Convert k(u)int*max types from basictypes.h to std::numeric_limits variants.
As the types from basictypes.h are deprecated this moves them to
std::numeric_limits from <limits> or when necessary to the (U)INTx_{MIN,MAX} macros from <stdint.h>.
BUG=138542
TEST=ipc_tests
[email protected]
Review URL: https://codereview.chromium.org/1331673002
Cr-Commit-Position: refs/heads/master@{#348474}
Removes some dead code from Frame
BUG=none
TEST=none
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1342463003
Cr-Commit-Position: refs/heads/master@{#348473}
Remove relative include config from sqlite.
These include_dir directives were in place to allow Blink's WebDatabase
implementation to refer to <sqlite3.h>, presumably part of the WebKit
heritage.
Minor BUILD.gn automated reformat.
BUG=526828
Review URL: https://codereview.chromium.org/1307783007
Cr-Commit-Position: refs/heads/master@{#348472}
[Autofill] Compare Autofill profiles using canonicalized address line concatenation.
The field comparison will now compare a concatenation of the two address lines. It will not take punctuation into account anymore. This will avoid creating duplicate profiles that have the same effective address.
BUG=
Review URL: https://codereview.chromium.org/1310703004
Cr-Commit-Position: refs/heads/master@{#348471}
Update internet page to use settings-page
This also eliminates any remaining references to MoreRouting and the unused settings_page_header files.
BUG=521040
For more_routing_externs.js:
[email protected]
Review URL: https://codereview.chromium.org/1331293004
Cr-Commit-Position: refs/heads/master@{#348470}
cc: Refactor SurfaceHittest for readability
BUG=492389
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1327073002
Cr-Commit-Position: refs/heads/master@{#348469}
Reland: content_{renderer,tests}.gypi cleanup of plugin+webrtc sources
Relanding after adding the missing BUILD.gn configuration.
[email protected], rationale: this patch is equivalent
to the already LGTMd plus some stale .gyp code removal.
Original description ---------------------------------------------------
content_{renderer,tests}.gypi cleanup of plugin+webrtc sources
Moving around some files after renaming made more evident
what they do.
BUG=525817, 530330
Committed: https://crrev.com/fc3c2df218caee93a913612a6ad6ef84f6169d0c
Cr-Commit-Position: refs/heads/master@{#348232}
Review URL: https://codereview.chromium.org/1335033003
Cr-Commit-Position: refs/heads/master@{#348468}
Adding a 2nd line (status line) to host list items.
BUG=467142
Review URL: https://codereview.chromium.org/1161313004
Cr-Commit-Position: refs/heads/master@{#348467}
Make cvox2 feedback more robust when focusing a text field.
The editable text handler was speaking unnecessarily on focus.
Modifies MockFeedback to allow us to assert that a certain utterance is not
spoken at a given place in the sequence.
Depends on: https://codereview.chromium.org/1302763002/
BUG=none
Review URL: https://codereview.chromium.org/1318683002
Cr-Commit-Position: refs/heads/master@{#348466}
Add UMA stats for SBIRS StateStore loading
BUG=529843
Review URL: https://codereview.chromium.org/1334723002
Cr-Commit-Position: refs/heads/master@{#348465}
Remove shrikant@ from DWrite ownership after his departure
BUG=:-(
[email protected]
Review URL: https://codereview.chromium.org/1337113003
Cr-Commit-Position: refs/heads/master@{#348464}
The ZoomManager assumes that the zoom level is initially at
the current browser default zoom level.
So when we try to set the zoom level to the browser default
zoom level, ZoomManager does nothing.
We now initialize ZoomManager with the actual initial zoom level
(the zoom level at the time the plugin is first run).
For example, if the 'Let me choose when to run plugin content' option
is selected in the content settings, we change the zoom level before
the pdf viewer is run, and then run the pdf viewer, then the current
zoom level will differ from the browser default zoom level.
BUG=492973
Review URL: https://codereview.chromium.org/1321823005
Cr-Commit-Position: refs/heads/master@{#348463}
Expose domKey to WebInputEvents created by aura.
Set the domKey appropriately from aura events.
BUG=227231
Review URL: https://codereview.chromium.org/1336033002
Cr-Commit-Position: refs/heads/master@{#348462}
Fix stability histogram values to match histograms.xml
BUG=526198
Review URL: https://codereview.chromium.org/1337113002
Cr-Commit-Position: refs/heads/master@{#348461}
Do not set socket recorder in incognito
BUG=498380, 497899
Review URL: https://codereview.chromium.org/1336063002
Cr-Commit-Position: refs/heads/master@{#348460}
ipc: Update Message::FindNext to parse brokered attachments.
The method Message::FindNext now takes an output parameter NextMessageInfo which
contains additional metadata needed for generating brokered attachments.
BUG=493414
Review URL: https://codereview.chromium.org/1308613006
Cr-Commit-Position: refs/heads/master@{#348459}
Fix back button in Contextual Search for svelte devices.
Switching from FROM_MENU_OR_OVERVIEW to FROM_LINK makes the
back button return the user from the promoted tab to the parent tab.
BUG=399317
Review URL: https://codereview.chromium.org/1338583002
Cr-Commit-Position: refs/heads/master@{#348458}
Roll src/third_party/WebKit d63c607:8b54c1f (svn 202156:202157)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d63c607..8b54c1f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336073002
Cr-Commit-Position: refs/heads/master@{#348457}
Don't process tree change events for ChromeVox Classic.
We get duplicated alert announcements because both Next and Classic are reading the alert.
BUG=475692
Review URL: https://codereview.chromium.org/1341483002
Cr-Commit-Position: refs/heads/master@{#348456}
Roll src/third_party/WebKit 844f48e:d63c607 (svn 202154:202156)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/844f48e..d63c607
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1341493002
Cr-Commit-Position: refs/heads/master@{#348455}
Stop implicit conversion from Rect to RectF.
Fixes a few more cases in:
- ui/ozone
- mandoline
- image_transport_surface_overlay_mac
NOTRY=true
TBR=ccameron, sky
BUG=342848
Review URL: https://codereview.chromium.org/1333323004
Cr-Commit-Position: refs/heads/master@{#348454}
MD Downloads: disable search icon button when search is showing
[email protected]
BUG=526925
Review URL: https://codereview.chromium.org/1333223002
Cr-Commit-Position: refs/heads/master@{#348453}
android: Include rect_f.h to use RectF.
The file includes rect.h now but that's the wrong one.
[email protected]
NOTRY=true
BUG=342848
Review URL: https://codereview.chromium.org/1338783003
Cr-Commit-Position: refs/heads/master@{#348452}
Disable WebViewTest.TestConfirmDialog on Mac
BUG=530660
[email protected]
Review URL: https://codereview.chromium.org/1341433002
Cr-Commit-Position: refs/heads/master@{#348451}
DeviceUtils: Fix crash when creating error message for a non-userdebugdevice
BUG=
Review URL: https://codereview.chromium.org/1339683002
Cr-Commit-Position: refs/heads/master@{#348450}
Exclude PolicyTest.ForceSafeSearch and PolicyTest.URLBlacklist which time out under DrMemory.
BUG=530696
[email protected]
Review URL: https://codereview.chromium.org/1342443002
Cr-Commit-Position: refs/heads/master@{#348449}
[Cronet] Include usage pages for Javadoc
Include "use" option to generate usage pages in Javadoc.
Review URL: https://codereview.chromium.org/1334323002
Cr-Commit-Position: refs/heads/master@{#348448}
Roll src/third_party/WebKit 5bac3c9:844f48e (svn 202153:202154)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5bac3c9..844f48e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336833003
Cr-Commit-Position: refs/heads/master@{#348447}
[ChromeDriver] Enable java tests for webview_shell
BUG=chromedriver:645
Review URL: https://codereview.chromium.org/1332163002
Cr-Commit-Position: refs/heads/master@{#348446}
Exclude 2 VideoRendererImplTests that fail on Mac Valgrind.
BUG=530688
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333323005
Cr-Commit-Position: refs/heads/master@{#348445}
[Cronet] Catch IllegalArgumentException when assertions are disabled
If assertions are disabled, testInvalidLoadState will not
catch an assertion error. This CL adds an additional catch statement for
IllegalArgumentException, which should be thrown in case of invalid inputs.
Review URL: https://codereview.chromium.org/1337083003
Cr-Commit-Position: refs/heads/master@{#348444}
Rebaseline global-interface-listing-expected.txt
Due to:
Issue 1290753002: Rename InputDevice to InputDeviceCapabilities and sourceDevice to sourceCapabilities
--> potential undesired exposure, crbug.com/530683
Issue 1291723004: Remove all support for <applet> handling in Chrome.
Issue 1323073005: Remove Element.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight
Issue 1325293004: CacheStorage: Enable Cache.matchAll() by default
BUG=506603,530683
[email protected]
Review URL: https://codereview.chromium.org/1335233002
Cr-Commit-Position: refs/heads/master@{#348443}
Handle ActivityNotFoundException when selecting client cert
Calling KeyChain#choosePrivateKeyAlias calls through to
Context#startActivity, which can throw an ActivityNotFoundException.
This change catches that exception and, instead of crashing, shows a
dialog that explains that selecting client certs is not supported on
that platform.
TEST=SSLClientCertificateRequestTest
BUG=529513
Review URL: https://codereview.chromium.org/1327103003
Cr-Commit-Position: refs/heads/master@{#348442}
Fix possible reconcilor loop when the primary account is in an auth error state.
BUG=516070,529439
Review URL: https://codereview.chromium.org/1264143003
Cr-Commit-Position: refs/heads/master@{#348441}
Revert of Optimize for TouchStart responsiveness (patchset #22 id:410001 of https://codereview.chromium.org/1320633002/ )
Reason for revert:
adds flaky test, causes other test to be flaky
BUG=530250
Original issue's description:
> Optimize for TouchStart responsiveness by modeling what the user is doing.
> We have come to realize that TouchStart responsiveness is really critical
> for a good user experience.
>
> This patch introduces a (initially very simple) system for modeling
> what the user is doing and predicting when they are likely to initiate a
> new gesture (taps are ignored). We order task priority accordingly.
>
> In addition we extend the estimation of task cost to loading tasks
> which are often a significant source of jank.
>
> Load tasks can be very long (easily up to 1000ms). There is
> no good way to cooperatively schedule such a task but the
> least worst user experience seems to be if we get them out
> of the way as fast as possible. Ideally we'd prioritize them
> but the order of IPC and LoadingTasks currently needs to
> be more or less in lockstep. Instead we deprioritize compositor
> tasks inside a compositor gesture, which has the effect of
> prioritizing other work.
>
> Expected changes on Perf bots:
> 1. first_gesture_scroll_update_latency in smoothness.scrolling_tough_ad_cases
> should go down. This should be highly user visible.
> 2. It's possible some compositor metrics such as queueing_durations
> may regress. I don't expect this to be user visible.
>
> BUG=510398
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/464b1a5144ddb5135dad845aceb5b1f074221387
> Cr-Commit-Position: refs/heads/master@{#347937}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510398
Review URL: https://codereview.chromium.org/1337993002
Cr-Commit-Position: refs/heads/master@{#348440}
Roll src/third_party/WebKit 4ea5d75:5bac3c9 (svn 202150:202153)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4ea5d75..5bac3c9
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1338633003
Cr-Commit-Position: refs/heads/master@{#348439}
Avoid crashing when going back/forward to debug URLs on a sad WebUI tab.
Moves the check for this case later so it applies to back/forward as well
as new navigations.
BUG=477606
TEST=See bug for repro steps.
Review URL: https://codereview.chromium.org/1335843002
Cr-Commit-Position: refs/heads/master@{#348438}
roll ffmpeg
Picks up https://chromium-review.googlesource.com/#/c/299370/
"Fix warning flags after https://chromium-review.googlesource.com/#/c/296470/"
BUG=491209
TBR=brettw
Review URL: https://codereview.chromium.org/1333423002 .
Cr-Commit-Position: refs/heads/master@{#348437}
Add default clause to a switch case.
This enum is defined in WebRTC and could change independently.
BUG=
Review URL: https://codereview.chromium.org/1338543002
Cr-Commit-Position: refs/heads/master@{#348436}
unbreak no-webrtc builds
https://codereview.chromium.org/1330873002 broke builds with webrtc
disabled.
BUG=262211
Review URL: https://codereview.chromium.org/1340483002
Cr-Commit-Position: refs/heads/master@{#348435}
Clean up WebContents on tab close
This change adds an observer to a tab that reader mode is
active in to watch for tab close/destruction. This allows
reader mode to clean up any remaining WebContents it may
have been using.
BUG=496653
Review URL: https://codereview.chromium.org/1333203002
Cr-Commit-Position: refs/heads/master@{#348434}
Increases security checks of finding target frame
And adds a test.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1333333004
Cr-Commit-Position: refs/heads/master@{#348433}
Un-nest GN configs in breakpad build file.
We're making configs nested in targets illegal.
[email protected]
Review URL: https://codereview.chromium.org/1339723002
Cr-Commit-Position: refs/heads/master@{#348432}
Roll src/third_party/WebKit 0e42285:4ea5d75 (svn 202147:202150)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0e42285..4ea5d75
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334373003
Cr-Commit-Position: refs/heads/master@{#348431}
Increase mac_chromium_gn_rel to 50% of the CQ.
I believe we should have enough VMs to run this bot
as part of the CQ now, so let's ramp it up and see?
[email protected]
BUG=439402
Review URL: https://codereview.chromium.org/1327363004
Cr-Commit-Position: refs/heads/master@{#348430}
Remove MigrateNetworkPredictionUserPrefs().
Remove predictive network action preference migration code on non-Android
platforms after one year.
BUG=526773
Review URL: https://codereview.chromium.org/1320613006
Cr-Commit-Position: refs/heads/master@{#348429}
Roll src/third_party/skia 951d854:465283c
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/951d854..465283c
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
465283c [email protected] Remove batchtracker
ae48877 [email protected] increase resource image-cache size to test perf
Review URL: https://codereview.chromium.org/1332423003
Cr-Commit-Position: refs/heads/master@{#348428}
Update OWNERS file now that Chris has left the project.
TBR=sgurun
Review URL: https://codereview.chromium.org/1315443013
Cr-Commit-Position: refs/heads/master@{#348427}
Add test_runner API to set the value of an accessibility object.
BUG=530032
Review URL: https://codereview.chromium.org/1336013002
Cr-Commit-Position: refs/heads/master@{#348426}
Disable the flaky TabCaptureApiTest.TabIndicator test.
[email protected]
BUG=530657
Review URL: https://codereview.chromium.org/1335203003
Cr-Commit-Position: refs/heads/master@{#348425}
Roll src/third_party/WebKit 53c8227:0e42285 (svn 202145:202147)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/53c8227..0e42285
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335823003
Cr-Commit-Position: refs/heads/master@{#348424}
Add LOAD_DO_NOT_SEND_AUTH_DATA to PrecacheFetcher.
This is needed for proper "privacy mode". This may break URLs with
"user:pass@" in them, so a change is being introduced in the pipeline
that filters such URLs out.
BUG=309216
Review URL: https://codereview.chromium.org/1335743002
Cr-Commit-Position: refs/heads/master@{#348423}
mandoline: Set up WebViewTest and add a basic test.
BUG=526268
Review URL: https://codereview.chromium.org/1333963003
Cr-Commit-Position: refs/heads/master@{#348422}
ipc: Make sure that ChannelReader is destroyed correctly.
ChannelReader observes the attachment broker, which it gets from a subclass.
Before the subclass is destroyed, ChannelReader must stop observing the
attachment broker.
BUG=493414
Review URL: https://codereview.chromium.org/1321803003
Cr-Commit-Position: refs/heads/master@{#348421}
Revert "[Android WebView] Enable Network Information API"
This reverts commit 7d01bcecee8bda46001ac56a5e38574a9084679b.
Reverting, as it has been confirmed that this patch causes intermittent
ERR_NETWORK_CHANGED errors.
BUG=529434
[email protected]
Review URL: https://codereview.chromium.org/1339653003
Cr-Commit-Position: refs/heads/master@{#348420}
Refactor DeviceUtils.Install and InstallSplitApk to use the same helper
Motivated by Install() getting a new permissions attribute without
InstallSplitApk() being updated (http://crrev.com/de468d72d9e)
There is also a sematic change:
- When a previous install is present and reinstall=False, we used to
check if the install on-device was identical and no-op in this case.
Now, we do an uninstall + install regardless of whether the on-device
version is identical. This new behaviour is more correct since it
guarantees that no stale data will be present when reinstall=False.
BUG=
Review URL: https://codereview.chromium.org/1337073002
Cr-Commit-Position: refs/heads/master@{#348419}
[Android] Don't use a device blacklist if one isn't provided. (RELAND 2)
original: https://codereview.chromium.org/1314823011
reland 1: https://codereview.chromium.org/1304303006
BUG=517709
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331213004
Cr-Commit-Position: refs/heads/master@{#348418}
Revert of Try changing LockImpl to not have a spin count to see how it affects performance. (patchset #1 id:1 of https://codereview.chromium.org/1333053002/ )
Reason for revert:
didn't make any difference
Original issue's description:
> Try changing LockImpl to not have a spin count to see how it affects performance.
>
> This was last change 7 years ago, and we have grown a lot of usages of locks since then. Since we don't use pthread_spin_lock on posix, I'm curious how this affects performance today on Windows.
>
> Committed: https://crrev.com/00c9ca679badffc7584439fff00f18cb3977d5da
> Cr-Commit-Position: refs/heads/master@{#348280}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1340653003
Cr-Commit-Position: refs/heads/master@{#348417}
Roll src/third_party/WebKit 840b506:53c8227 (svn 202144:202145)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/840b506..53c8227
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1340653002
Cr-Commit-Position: refs/heads/master@{#348416}
Fix md5sum.py crashing when trying to delete non-existent md5sum directory
"rm -rf foo/" fails, but "rm -rf foo" succeeds
BUG=
Review URL: https://codereview.chromium.org/1332373002
Cr-Commit-Position: refs/heads/master@{#348415}
chrome: Remove unneeded dependencies on libevent library.
Nothing in chrome/ seems to be including from third_party/libevent.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1334723003
Cr-Commit-Position: refs/heads/master@{#348414}
Push API: do not unregister from BackgroundModeManager from Shutdown.
If we're in Shutdown the whole browser is tearing down, and moments
after Shutdown is called BackgroundModeManager itself will be destroyed.
This avoids unhooking auto launch on login and auto loading of the profile.
This also avoids doing extra work during shutdown.
BUG=527036
Review URL: https://codereview.chromium.org/1302313012
Cr-Commit-Position: refs/heads/master@{#348413}
Add GL_CHROMIUM_screen_space_antialiasing to support alternative AA
MSAA is very expensive on some platforms. We introduce extention
GL_CHROMIUM_screen_space_antialiasing to support other antialiasing
approach. It will perform antialiasing to the color attachments of
the currently bound draw framebuffer. As an example, we implement it
using GL_INTEL_framebuffer_CMAA which results in similar quality of
MSAA at better performance.
The blink side change is in below link:
https://codereview.chromium.org/1301923002
BUG=524285
Review URL: https://codereview.chromium.org/1298523003
Cr-Commit-Position: refs/heads/master@{#348412}
Roll src/third_party/WebKit 19c92bc:840b506 (svn 202140:202144)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/19c92bc..840b506
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1338813002
Cr-Commit-Position: refs/heads/master@{#348411}
Reinstantiate EditableTextHandler instance on focus change.
BUG=525649
Review URL: https://codereview.chromium.org/1326363002
Cr-Commit-Position: refs/heads/master@{#348410}
Remove iOS references in chrome_browser_main_extra_parts_profiles.cc
This file is not compiled on iOS.
BUG=none
Review URL: https://codereview.chromium.org/1319453007
Cr-Commit-Position: refs/heads/master@{#348409}
Partially fix compilation of chrome with Xcode 7 (OS X 10.11 SDK).
Use a local variable so that Xcode knows which -setDelegate: method
is invoked (it seems that -[NSApplication sharedApplication] return
value is sub-typed).
Fixes the following error (only the listing the first few lines):
../../chrome/app_shim/chrome_main_app_mode_mac.mm:159:3: error: multiple methods named 'setDelegate:' found [-Werror,-Wobjc-multiple-method-names]
[[NSApplication sharedApplication] setDelegate:delegate_];
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:167:56: note: using
@property (nullable, assign) id<NSApplicationDelegate> delegate;
^~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSFileManager.h:129:57: note: also found
@property (nullable, assign) id <NSFileManagerDelegate> delegate NS_AVAILABLE(10_5, 2_0);
^~~~~~~~
BUG=517914
Review URL: https://codereview.chromium.org/1339563003
Cr-Commit-Position: refs/heads/master@{#348408}
DebugVisualizers: Add blink:WebString
Simple visualizer for WebString
Review URL: https://codereview.chromium.org/1338563002
Cr-Commit-Position: refs/heads/master@{#348407}
Add test specs for new Linux, Mac and Windows ANGLE trybots.
BUG=504872
Review URL: https://codereview.chromium.org/1332093002
Cr-Commit-Position: refs/heads/master@{#348406}
Allows about:blank to load in current tab without going to server
about:blank navigations shouldn't require going to the server as they
are considered same origin.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1337883003
Cr-Commit-Position: refs/heads/master@{#348405}
Roll src/third_party/WebKit 0651df3:19c92bc (svn 202139:202140)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0651df3..19c92bc
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337083002
Cr-Commit-Position: refs/heads/master@{#348404}
Roll src/third_party/WebKit 3d76e0f:0651df3 (svn 202138:202139)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d76e0f..0651df3
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1338793002
Cr-Commit-Position: refs/heads/master@{#348403}
[Chromecast] Allow CCBrowserClient impls access to URLRequestContextFactory.
[email protected]
BUG=internal b/23761158
Review URL: https://codereview.chromium.org/1335083003
Cr-Commit-Position: refs/heads/master@{#348402}
Roll src/third_party/WebKit e03513a:3d76e0f (svn 202137:202138)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e03513a..3d76e0f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1340543003
Cr-Commit-Position: refs/heads/master@{#348401}
Stop building FilePathWatcher on iOS.
Stop using FilePathWatcher on iOS as it does not works on iOS devices
as can be seen when running the unit tests that never finish as no
events are reported.
Remove the only usage of FilePathWatcher that was present on iOS. This
does not change the behaviour since previously even in case of changes
to /etc/hosts, the watcher was never informed of any changes. Moreover
the file is not editable by the user and so the file will only change
after OS upgrade (which requires an app restart) or due to a list of
static hosts send as part of dynamic IP negociation (i.e. after a local
IP change).
BUG=477102
Review URL: https://codereview.chromium.org/1304233004
Cr-Commit-Position: refs/heads/master@{#348400}
Use DesktopMediaID instead of an integer id as input of
DesktopMediaList::SetVewDialgoWindowId()
Fixed for bug 513490 DesktopMediaList::setviewDialogWindowId() should take the entire DesktopMediaID as an argument
BUG=513490
Review URL: https://codereview.chromium.org/1321353004
Cr-Commit-Position: refs/heads/master@{#348399}
Roll src/third_party/WebKit 99b5275:e03513a (svn 202136:202137)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/99b5275..e03513a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1340633002
Cr-Commit-Position: refs/heads/master@{#348398}
Remove Deep Memory Profiler commandline tools from tree
The tool no longer works nor is maintained.
BUG=490464
Review URL: https://codereview.chromium.org/1336993003
Cr-Commit-Position: refs/heads/master@{#348397}
Revert of Remove RenderViewObserver as RendererCldDataProviderFactory arg. (patchset #1 id:1 of https://codereview.chromium.org/1310303007/ )
Reason for revert:
Breaks DataFileRendererCldDataProviderthat's not currently built, but will be in the future.
Original issue's description:
> Remove RenderViewObserver as RendererCldDataProviderFactory arg.
>
> It is not used and will just be in the way of moving TranslateHelper
> to be a RenderFrameObserver.
>
> BUG=521116
> [email protected]
>
> Committed: https://crrev.com/0252669f88c5ad3faa51d8376e5bfdbd12b76ceb
> Cr-Commit-Position: refs/heads/master@{#348330}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521116
Review URL: https://codereview.chromium.org/1337043002
Cr-Commit-Position: refs/heads/master@{#348396}
Make TabModelSelectorTabObserverTest use TabModelImpl instead of TabModelBase
This CL makes TabModelSelectorTabObserverTest use TabModelImpl instead of
TabModelBase in preparation for merging TabModelImpl and TabModelBase.
BUG=530328
TEST=None
Review URL: https://codereview.chromium.org/1332103002
Cr-Commit-Position: refs/heads/master@{#348395}
Disabled WebViewTest.Dialog_TestConfirmDialogDefaultGCCancel in debug.
After https://src.chromium.org/viewvc/blink?revision=202123&view=revision,
WebViewTest.Dialog_TestConfirmDialogDefaultGCCancel started failing on
debug bots.
See https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/47034,
for example.
Ulan volunteered to investigate.
BUG=530593
[email protected]
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1334283002
Cr-Commit-Position: refs/heads/master@{#348394}
Roll src/third_party/WebKit 322aa52:99b5275 (svn 202135:202136)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/322aa52..99b5275
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337033003
Cr-Commit-Position: refs/heads/master@{#348393}
Remove clang type profiler and deep memory profiler.
Looks like it's no longer functional and unused.
BUG=490464
TBR=jochen
Review URL: https://codereview.chromium.org/1331973002
Cr-Commit-Position: refs/heads/master@{#348392}
Update V8 to version 4.7.46.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43c80329..7f27721a
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335963002
Cr-Commit-Position: refs/heads/master@{#348391}
Roll src/third_party/WebKit e4a9a0e:322aa52 (svn 202134:202135)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e4a9a0e..322aa52
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1340583002
Cr-Commit-Position: refs/heads/master@{#348390}
Roll src/third_party/WebKit 19d896f:e4a9a0e (svn 202133:202134)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/19d896f..e4a9a0e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332353002
Cr-Commit-Position: refs/heads/master@{#348389}
Simple client side heuristics for checking username.
Do not use text field on change password forms if it contains only small number. It's unlikely that this is username, probably it's some service information which JavaScript uses for some purpose. This will fix change password support on facebook.com.
Also this CL contains a small fix with UI bubble, namely do not to show "no username" in Save Bubble. It was already implemented for change password forms, and currently it expands this for any "no username" credentials.
BUG=530082
Review URL: https://codereview.chromium.org/1331043002
Cr-Commit-Position: refs/heads/master@{#348388}
Remove outdated TODOs for issue 337824.
BUG=337824
Review URL: https://codereview.chromium.org/1330233005
Cr-Commit-Position: refs/heads/master@{#348387}
Roll src/third_party/WebKit 401895e:19d896f (svn 202132:202133)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/401895e..19d896f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334263002
Cr-Commit-Position: refs/heads/master@{#348386}
Use #if DCHECK_IS_ON() in base/synchronization/*
Use #if DCHECK_IS_ON() instead of
(!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) in
base/synchronization/* because it is same thing
and more succinct and centralized.
Review URL: https://codereview.chromium.org/1325673004
Cr-Commit-Position: refs/heads/master@{#348385}
Avoid warnings in NetworkQualityEstimatorTest.TestCaching
Gets rid of the following compilation errors:
../../net/base/network_quality_estimator_unittest.cc:465:118: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression]
../../net/base/network_quality_estimator_unittest.cc:476:118: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression]
Review URL: https://codereview.chromium.org/1335943002
Cr-Commit-Position: refs/heads/master@{#348384}
Roll src/third_party/WebKit 862de15:401895e (svn 202131:202132)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/862de15..401895e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332333002
Cr-Commit-Position: refs/heads/master@{#348383}
Roll src/third_party/WebKit 0339e6f7:862de15 (svn 202130:202131)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0339e6f7..862de15
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334243003
Cr-Commit-Position: refs/heads/master@{#348382}
Webview Layout Test failure on Android
Unexpected new webview interfaces found.
CSSNamespaceRule support was added in
https://codereview.chromium.org/1321943002.
This patch updates the interface declaration
for the same in android webview expected file.
BUG=529790, 389549, 506603
Review URL: https://codereview.chromium.org/1336463002
Cr-Commit-Position: refs/heads/master@{#348381}
Roll src/third_party/WebKit 0607abb:0339e6f7 (svn 202129:202130)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0607abb..0339e6f7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333273002
Cr-Commit-Position: refs/heads/master@{#348380}
[NaCl SDK] Fix stat structure mismatch in kernel_wrap_irt_ext.c
This change means that all nacl_io tests now pass
under glibc/arm.
R=binji
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
Review URL: https://codereview.chromium.org/1334453003
Cr-Commit-Position: refs/heads/master@{#348379}
Roll src/third_party/WebKit 3cf9f49:0607abb (svn 202128:202129)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3cf9f49..0607abb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1338723002
Cr-Commit-Position: refs/heads/master@{#348378}
Roll src/third_party/WebKit 93c7d5e:3cf9f49 (svn 202127:202128)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/93c7d5e..3cf9f49
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337003002
Cr-Commit-Position: refs/heads/master@{#348377}
Roll src/third_party/WebKit b1b2c28:93c7d5e (svn 202126:202127)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b1b2c28..93c7d5e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335953002
Cr-Commit-Position: refs/heads/master@{#348376}
content: Populate WebPointerProperties with stylus details from ui::MouseEvent
ui::MouseEvent now holds values needed for implementing stylus support with
Pointer Events. This change populates the WebPointerProperties values with the
details from the MouseEvent's PointerDetails.
TEST=content_tests:TestMakeWebMouse[Wheel]Event
BUG=516706
Review URL: https://codereview.chromium.org/1266643002
Cr-Commit-Position: refs/heads/master@{#348375}
Roll src/third_party/WebKit 34b529b:b1b2c28 (svn 202124:202126)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/34b529b..b1b2c28
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336983002
Cr-Commit-Position: refs/heads/master@{#348374}
[tracing] Add test for memory-infra startup tracing
This is a follow-up to crrev.com/1333873002 that introduced
support to startup tracing.
Also this change refactors the TraceConfig JSON used by
various memory-infra tests (in and out of base) into a
test_util.h file.
Furthermore this change fixes a off-by-one mistake in the
periodic scheduler (and its test).
BUG=524057
Review URL: https://codereview.chromium.org/1335503003
Cr-Commit-Position: refs/heads/master@{#348373}
Fix the compatible version semantics in LoginDatabase.
BUG=None
BASE=1328743006
Review URL: https://codereview.chromium.org/1305163011
Cr-Commit-Position: refs/heads/master@{#348372}
Only grant permissions to new extensions from sync if they have the expected version
TBRing a trivial change to theme_syncable_service.cc
[email protected]
BUG=529278
Review URL: https://codereview.chromium.org/1330163002
Cr-Commit-Position: refs/heads/master@{#348371}
Clear webapp storage when site data is cleared
From a privacy perspective, all webapp data should be cleared
when site data is cleared by the user. Add the functionality
to do this.
Note: this CL does not delete the files themselves but no
identifying information about either the webapp or the user
is left in the SharedPreferences so there should be no problem.
This is because of a platform limitation which does not allow
SharedPreference consumers to delete the SharedPreference
file.
BUG=508627
Review URL: https://codereview.chromium.org/1329083002
Cr-Commit-Position: refs/heads/master@{#348370}
Calculate metrics regarding password reuse in a more efficient manner.
Calculating these metrics involves counting, for each stored account, the number of other accounts that are reusing the same password. The numbers are further split based on whether each of the accounts are for HTTP or HTTPS sites, and whether the "other" account is for the same domain, a public suffix matching domain, or a different domain.
Because the old implementation relied on IsPublicSuffixDomainMatch() to tell if two domains were PSL matches (i.e. relied on using a binary comparison operator for finding equivalence classes), it necessarily involved nested for-loops, and had a complexity of O(n^2), where n is the number of accounts, with a high constant factor. This proved to take several tenths of seconds for users with lots of passwords.
This CL improves on performance in two ways:
-- It pre-calculates and caches the registry controlled portions of domains for each account, using only O(n) calls to GetRegistryControlledDomain(), which is the term that has the highest constant factor.
-- Instead of enumerating over all "other" accounts for each account, the new solution first groups accounts by domain and by registry controlled domain, then calculates the total number of accounts in each of these groups plus the grand totals, and finally uses the inclusion-exclusion principle to derive the desired numbers. This has a total complexity of only O(n*log(n)).
BUG=517422
Review URL: https://codereview.chromium.org/1330333002
Cr-Commit-Position: refs/heads/master@{#348369}
Update V8 to version 4.7.45.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3070cd78..43c80329
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337813003
Cr-Commit-Position: refs/heads/master@{#348368}
Roll src/third_party/WebKit 7993ac8:34b529b (svn 202122:202124)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7993ac8..34b529b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1340503002
Cr-Commit-Position: refs/heads/master@{#348367}
Add provider column to certificate selection dialogs.
Now that certificates can be provided by extensions, the client certificate selection dialogs have to show the user where a certificate comes from.
This change adds a new column 'Provider' that will show the name of the extension providing the certificate.
BUG=514575
Review URL: https://codereview.chromium.org/1332473004
Cr-Commit-Position: refs/heads/master@{#348366}
Guard usage of kEnableMediaRouter with ENABLE_MEDIA_ROUTER
Definition of kEnableMediaRouter is guarded with ENABLE_MEDIA_ROUTER.
All usages also should be guarded with this switch.
Review URL: https://codereview.chromium.org/1219063014
Cr-Commit-Position: refs/heads/master@{#348365}
Roll src/third_party/WebKit 517ad2f:7993ac8 (svn 202121:202122)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/517ad2f..7993ac8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1338673002
Cr-Commit-Position: refs/heads/master@{#348364}
Eliminate BaseSessionServiceDelegateImpl
PersistentTabRestoreService::Delegate is slated for componentization. However,
it inherits from BaseSessionServiceDelegateImpl, which contains //chrome-level
functionality.
This CL eliminates BaseSessionServiceDelegateImpl, instead having
PersistentTabRestoreService::Delegate and SessionService each inherit directly
from BaseSessionServiceDelegate. The one non-trivial method in
BaseSessionServiceDelegateImpl (ShouldTrackEntry()) is pulled out into a
standalone //chrome-level util function to avoid code duplication between
ChromeTabRestoreServiceClient and SessionService.
BUG=530165
Review URL: https://codereview.chromium.org/1331173002
Cr-Commit-Position: refs/heads/master@{#348363}
[iOS] Remove the kEnableReferrers pref.
This preference is unused.
Review URL: https://codereview.chromium.org/1340473003
Cr-Commit-Position: refs/heads/master@{#348362}
Simplify SendRequest of Extension API calls.
Before, the request id was fetched in a separate native call.
Now, the request id is returned by the startRequest function.
Review URL: https://codereview.chromium.org/1331063002
Cr-Commit-Position: refs/heads/master@{#348361}
Gallery: remove CSS for mosaic mode.
Since mosaic mode is replaced with thumbnail mode, we can remove these
CSS.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1336943002
Cr-Commit-Position: refs/heads/master@{#348360}
Roll src/third_party/WebKit a916ad1:517ad2f (svn 202120:202121)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a916ad1..517ad2f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335883002
Cr-Commit-Position: refs/heads/master@{#348359}
Roll src/third_party/WebKit 9ff6d11:a916ad1 (svn 202119:202120)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9ff6d11..a916ad1
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335073003
Cr-Commit-Position: refs/heads/master@{#348358}
Reland of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket
(patchset #17 id:500001 of https://codereview.chromium.org/736653002/ )
The original CL is reverted (https://codereview.chromium.org/1333153002/):
> Reason for revert:
> New test on the reference build causing Linux and Mac perf bots to fail.
> http://crbug.com/530374
This relanding CL disables blink_perf.pywebsocket tests on reference builds
because some tests require Chromium 42, which is newer than reference builds.
> This CL adds blink_perf.pywebsocket, in which
> - Pywebsocket server is started at localhost:8001, and
> - Browser option --disable-web-security is added,
> because we need cross-origin accesses between
> memory_cache_http_server and pywebsocket server.
>
> [1/2] PerformanceTests scripts: https://codereview.chromium.org/738753002/
> [2/2] Telemetry: This CL
BUG=432408, 530374
[email protected]
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect
Review URL: https://codereview.chromium.org/1331403002
Cr-Commit-Position: refs/heads/master@{#348357}
Update V8 to version 4.7.44.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4b85d844..3070cd78
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334913002
Cr-Commit-Position: refs/heads/master@{#348356}
Roll src/third_party/WebKit a452221:9ff6d11 (svn 202117:202119)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a452221..9ff6d11
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1339573002
Cr-Commit-Position: refs/heads/master@{#348355}
Roll src/third_party/WebKit b3ecde4:a452221 (svn 202116:202117)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b3ecde4..a452221
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333203003
Cr-Commit-Position: refs/heads/master@{#348354}
ServiceWorker: Make WebServiceWorkerRegistration refcounted (3)
This is one of preliminary patches for making APIs (eg. register()) that return
ServiceWorkerRegistration object return the same JS object if it's available.
(1) Chromium: https://codereview.chromium.org/1318903013/
(2) Blink: https://codereview.chromium.org/1307733004/
(3) Chromium: THIS PATCH
(4) Blink: https://codereview.chromium.org/1312703005/
This CL...
- implements WebServiceWorkerRegistration::Handle,
- makes WebServiceWorkerRegistration refcounted, and
- passes the handle into Blink instead of WebServiceWorkerRegistration
(See the CL (2) for the context of these changes)
BUG=523904
Review URL: https://codereview.chromium.org/1303363007
Cr-Commit-Position: refs/heads/master@{#348353}
Roll src/third_party/WebKit a0393e5:b3ecde4 (svn 202115:202116)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a0393e5..b3ecde4
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336913002
Cr-Commit-Position: refs/heads/master@{#348352}
Various minor tab code cleanups, mostly around pinned tabs.
* Constants don't need to be both inside an anonymous namespace _and_ static.
* Change the pinned tab width constant from a whole-tab-width value to a width
of just the interior content (between the left and right edges). This makes
it easier to figure out how to update the pinned tab width if the edge asset
sizes change (as they will in Material Design) and is closer to how we size
normal tabs.
* Change constant for how big a pinned tab needs to be to render as normal from
an absolute size to a relative one. This makes the code using this a little
simpler.
* Add a helper function for whether a tab should be rendered as pinned, since
several places were doing the same thing.
* There's no reason to have both GetBasicMinimumUnselectedSize() and
GetMinimumUnselectedSize(). Condense to just the latter.
* Simplify various functions.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1331803002
Cr-Commit-Position: refs/heads/master@{#348351}
Roll src/third_party/WebKit c0b53c2:a0393e5 (svn 202114:202115)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c0b53c2..a0393e5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334153003
Cr-Commit-Position: refs/heads/master@{#348350}
Automated Commit: Committing new LKGM version 7445.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#348349}
Roll src/third_party/WebKit 117ac0c:c0b53c2 (svn 202111:202114)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/117ac0c..c0b53c2
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335113002
Cr-Commit-Position: refs/heads/master@{#348348}
Roll src/third_party/WebKit bd17bb7:117ac0c (svn 202110:202111)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bd17bb7..117ac0c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331423002
Cr-Commit-Position: refs/heads/master@{#348347}
[Download Notification] Remove the group download notification
We've decided to go without the group notification. This patch removes the groups download notification and modifies the tests.
BUG=527924
TEST=manual tested. Browser_tests pass.
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1326773004
Cr-Commit-Position: refs/heads/master@{#348346}
Do not limit address space when any of the sanitizers (or coverage) are enabled.
BUG=530432
Review URL: https://codereview.chromium.org/1338533003
Cr-Commit-Position: refs/heads/master@{#348345}
Roll src/third_party/WebKit 38cfa22:bd17bb7 (svn 202108:202110)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/38cfa22..bd17bb7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1338643002
Cr-Commit-Position: refs/heads/master@{#348344}
Remove MessagePumpForIO entry from CFI blacklist
This should no longer be needed.
BUG=520732
[email protected]
Review URL: https://codereview.chromium.org/1329353002
Cr-Commit-Position: refs/heads/master@{#348343}
Remove use of JSONReader::DeprecatedRead from printer_job_queue_handler_unittest.cc
Remove use of deprecated function DeprecatedRead from
chrome/service/cloud_print/printer_job_queue_handler_unittest.cc
Also make PrinterJobQueueHandlerTest to use scoped_ptr
BUG=523194
Review URL: https://codereview.chromium.org/1316923003
Cr-Commit-Position: refs/heads/master@{#348342}
Roll src/third_party/WebKit e354095:38cfa22 (svn 202107:202108)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e354095..38cfa22
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335833002
Cr-Commit-Position: refs/heads/master@{#348341}
Roll src/third_party/WebKit be75a8c:e354095 (svn 202106:202107)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/be75a8c..e354095
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337833003
Cr-Commit-Position: refs/heads/master@{#348340}
Initial gtk3 support
Currently we're sticking with deprecated apis to make it easier to support both gtk2 and gtk3. If Chrome ever drops gtk2 support, it might be a good idea to do a complete port.
BUG=132847
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1234223005
Cr-Commit-Position: refs/heads/master@{#348339}
MediaRecorderHandler: connecting Blink factory method to content/
MediaRecorderHandler changes to implementing WebMediaRecorderHandler;
content/ overrides Blink's createMediaRecorderHandler().
context: MediaRecorderHandler is the Blink-orchestrated class
implementing MediaStream Recorder API (see below). It plugs
together an existing MediaStreamVideoTrack to a new
VideoTrackRecorder-WebmMuxer pair. When MSVTrack passes
frames, these get encoded, muxed, and the result is sent to
Blink. See DD @ https://goo.gl/vSjzC5 (*) for the plan. The
previous CL http://crrev.com/1313603004 landed
MediaRecorderHandler, this one allows for its activation.
(*) Used to be https://goo.gl/kreaQj
Depends on https://crrev.com/1319473016 to disable
Blink tests, that after landing-rolling, should be updated and
reenabled.
BUG=262211
Review URL: https://codereview.chromium.org/1330873002
Cr-Commit-Position: refs/heads/master@{#348338}
Improve VideoCaptureImpl unittest.
This patch includes 2 improvements on VideoCaptureImpl unittest.
- Added "BufferReceived" unittest to check when buffer is received.
- Added "BufferReceivedAfterStop" unittest to check when buffer is received after stop.
BUG=522145
Review URL: https://codereview.chromium.org/1314483003
Cr-Commit-Position: refs/heads/master@{#348337}
Fix crash in SpeechRecognizerImpl introduced in AudioParams refactor.
Introduced here:
https://codereview.chromium.org/1304973005/diff/50001/content/browser/speech/speech_recognizer_impl.cc
BUG=530027
[email protected]
Review URL: https://codereview.chromium.org/1337823002
Cr-Commit-Position: refs/heads/master@{#348336}
Roll src/third_party/WebKit 1a1bea9:be75a8c (svn 202105:202106)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1a1bea9..be75a8c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333233002
Cr-Commit-Position: refs/heads/master@{#348335}
Roll src/third_party/WebKit a4ceae5:1a1bea9 (svn 202104:202105)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a4ceae5..1a1bea9
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337783003
Cr-Commit-Position: refs/heads/master@{#348334}
net: Remove libevent entry from DEPS file.
Nothing in net/ seems to be including from third_party/libevent.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1332883003
Cr-Commit-Position: refs/heads/master@{#348333}
Roll src/third_party/skia 83da2e2:951d854
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/83da2e2..951d854
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
951d854 [email protected] Revert of Parallel cache - preliminary (patchset #23 id:440001 of https://codereview.chromium.org/1264103003/ ) Also reverts https://codereview.chromium.org/1333003002/ which was layered on top.
Review URL: https://codereview.chromium.org/1337773002
Cr-Commit-Position: refs/heads/master@{#348332}
Roll src/third_party/WebKit ed9a02d:a4ceae5 (svn 202102:202104)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed9a02d..a4ceae5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337813002
Cr-Commit-Position: refs/heads/master@{#348331}
Remove RenderViewObserver as RendererCldDataProviderFactory arg.
It is not used and will just be in the way of moving TranslateHelper
to be a RenderFrameObserver.
BUG=521116
[email protected]
Review URL: https://codereview.chromium.org/1310303007
Cr-Commit-Position: refs/heads/master@{#348330}
Bring third_party/sqlite/BUILD.gn into parity with sqlite.gyp.
Pull in missing defines and comments on the defines.
Add USE_PREAD for Posix and HAVE_MALLOC_USABLE_SIZE for Linux.
BUG=489784
Review URL: https://codereview.chromium.org/1304033006
Cr-Commit-Position: refs/heads/master@{#348329}
Roll src/third_party/WebKit 62f1c52:ed9a02d (svn 202100:202102)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/62f1c52..ed9a02d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336893002
Cr-Commit-Position: refs/heads/master@{#348328}
MD Downloads: prevent search text from overlapping with the cancel search (X)
[email protected]
BUG=526922
Review URL: https://codereview.chromium.org/1336843002
Cr-Commit-Position: refs/heads/master@{#348327}
Roll src/third_party/WebKit 44711c6:62f1c52 (svn 202098:202100)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/44711c6..62f1c52
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332213002
Cr-Commit-Position: refs/heads/master@{#348326}
Roll src/third_party/WebKit d9274ad:44711c6 (svn 202095:202098)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d9274ad..44711c6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335803003
Cr-Commit-Position: refs/heads/master@{#348325}
Get GenericScopedHandle::Set to preserve LastError code
Code like this is elegant and clean and common in Chrome:
event_.Set(CreateEvent(NULL, FALSE, FALSE, wname.c_str()));
if (event_.Get() && GetLastError() != ERROR_ALREADY_EXISTS) {
However it will behave incorrectly if event_.Set() zeroes out the
Windows LastError code, which VC++ 2015 frequently does. This change
avoids that.
[email protected]
BUG=528394,529981,440500
Review URL: https://codereview.chromium.org/1320673016
Cr-Commit-Position: refs/heads/master@{#348324}
Port CFI build configuration to GN.
BUG=464797
[email protected]
Review URL: https://codereview.chromium.org/1326053003
Cr-Commit-Position: refs/heads/master@{#348323}
Updating trunk VERSION from 2507.0 to 2508.0
Cr-Commit-Position: refs/heads/master@{#348322}
Roll src/third_party/WebKit 6801073:d9274ad (svn 202093:202095)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6801073..d9274ad
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334103002
Cr-Commit-Position: refs/heads/master@{#348321}
[Chromecast] Raise Cast's BrowserCdmFactory creation to CCBrowserClient.
This allows removing another method that's chosen at link time
(CreatePlatformBrowserCdm), allowing us to avoid requiring singleton access
of some structures internally.
[email protected],[email protected]
BUG=internal b/23761158
Review URL: https://codereview.chromium.org/1333193002
Cr-Commit-Position: refs/heads/master@{#348320}
Roll src/third_party/WebKit 4dbf440:6801073 (svn 202090:202093)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4dbf440..6801073
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335813002
Cr-Commit-Position: refs/heads/master@{#348319}
Roll src/third_party/skia 2bd5d02:83da2e2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2bd5d02..83da2e2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
83da2e2 [email protected] Revert of use new shuffle to speed up affine matrix mappts (patchset #3 id:40001 of https://codereview.chromium.org/1333983002/ )
85d9178 [email protected] Use SkImageCacherator in SkImages
e70afc9 [email protected] use new shuffle to speed up affine matrix mappts
Review URL: https://codereview.chromium.org/1336803002
Cr-Commit-Position: refs/heads/master@{#348318}
Restore moving to the next Autofill form element on iPads running iOS 9.
In this case, the keyboard's next element button is located not on the
keyboard accessory but on the shortcut bar (part of the new
UITextInputAssistantItem).
BUG=529954
Review URL: https://codereview.chromium.org/1334073002
Cr-Commit-Position: refs/heads/master@{#348317}
Roll src/third_party/WebKit 3fd6c41:4dbf440 (svn 202089:202090)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3fd6c41..4dbf440
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336853002
Cr-Commit-Position: refs/heads/master@{#348316}
Change MSVS visualizers to query y, width and height on WebRect.
Previously these properties all mapped to x.
[email protected]
Review URL: https://codereview.chromium.org/1331313003
Cr-Commit-Position: refs/heads/master@{#348315}
Remove STP from third_party
Unresolved upstream issues have blocked my plans to use STP in
sandbox_linux_unittests for long enough that I've decided to abandon
them (at least for the foreseeable future), so no point in keeping
this unused code around at the moment.
BUG=414363
[email protected]
Review URL: https://codereview.chromium.org/1308063009
Cr-Commit-Position: refs/heads/master@{#348314}
Add ability to gather metrics to BubbleManager.
Give BubbleManager the ability to collect close reason and display time
for each for each bubble type. Display time is not separated by bubble
type.
BUG=496955
Review URL: https://codereview.chromium.org/1287323003
Cr-Commit-Position: refs/heads/master@{#348313}
Roll src/third_party/WebKit f51bda2:3fd6c41 (svn 202085:202089)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f51bda2..3fd6c41
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337753002
Cr-Commit-Position: refs/heads/master@{#348312}
BrowserPluginGuest should carry the correct text input states when notifying the text input type changed.
Especially for show_ime_if_needed value. Always passing false caused the bug.
BUG=528512
TEST=The bug not repro with this cl.
Review URL: https://codereview.chromium.org/1332753002
Cr-Commit-Position: refs/heads/master@{#348311}
Exclude WakeEventPageTest.ClosedEventPage under DrMemory for flakiness.
BUG=530404
[email protected]
Review URL: https://codereview.chromium.org/1337713002
Cr-Commit-Position: refs/heads/master@{#348310}
Roll src/third_party/WebKit 64cf2f8:f51bda2 (svn 202084:202085)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/64cf2f8..f51bda2
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335063002
Cr-Commit-Position: refs/heads/master@{#348309}
Rename WebSourceBuffer::abort -> resetParserState
As discussed in https://codereview.chromium.org/1013923002/, we could
rename WebSourceBuffer::abort into WebSourceBuffer::resetParserState to
avoid confusion that it's not the same thing as SourceBuffer::abort, and
just one of the steps of the MSE abort algorithm.
BUG=529497
Review URL: https://codereview.chromium.org/1312763014
Cr-Commit-Position: refs/heads/master@{#348308}
test_runner: Add TestInfoExtractor to get the list of test-urls.
Move the code to read the list of layout-tests to run into the test_runner
component. Use this from layout-test runner in both content_shell and web_view.
BUG=478250
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1312693007 .
Cr-Commit-Position: refs/heads/master@{#348307}
Roll src/third_party/WebKit d4aab0d:64cf2f8 (svn 202083:202084)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d4aab0d..64cf2f8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335803002
Cr-Commit-Position: refs/heads/master@{#348306}
Roll src/third_party/WebKit 0046ee1:d4aab0d (svn 202082:202083)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0046ee1..d4aab0d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332183002
Cr-Commit-Position: refs/heads/master@{#348305}
add SK_SUPPORT_LEGACY_NEWFROMGENERATOR to prepare for skia change
BUG=
TBR=
Review URL: https://codereview.chromium.org/1333183002
Cr-Commit-Position: refs/heads/master@{#348304}
For the upcoming "registration.done" feature the BackgroundSyncManager's clients will want to know about the state of registrations even after the BackgroundSyncManager has finished firing them. To prepare for that, this CL does the following:
1) BackgroundSyncManager now internally reference counts each registration it exposes to the client via RefCountedRegistration so that the client can reference a completed registration
2) BackgroundSyncManager returns BackgroundSyncRegistrationHandle to clients, which call BackgroundSyncManager::ReleaseRegistrationHandle when deleted (ensuring that all client-exposed registrations are released).
3) BackgroundSyncServiceImpl holds onto Client registrations until the renderer has signaled that it is done with them.
4) Moved Unregister to the new BackgroundSyncRegistrationHandle class (a la the javascript API). This makes it clear when it's safe for the client to delete its ClientBackgroundSyncRegisration (when it no longer needs to call unregister).
5) Added a few tests, and removed redundant sync browser tests from the service_workerbrowser_tests that are now covered in background_sync_browsertests.cc
Patch 1 [Blink]: https://codereview.chromium.org/1279323002/
Patch 2 [Browser]: this
Patch 3 [Blink cleanup]: https://codereview.chromium.org/1285653002/
BUG=502214
Review URL: https://codereview.chromium.org/1282013004
Cr-Commit-Position: refs/heads/master@{#348303}
Enable nacl on 32-bit x86 linux GN builds.
It looks like the only thing missing at this point was to correct
the path to the host build of tls_edit when linking the IRT.
[email protected], [email protected]
BUG=512882
Review URL: https://codereview.chromium.org/1338483002
Cr-Commit-Position: refs/heads/master@{#348302}
Implemented some utility functions for traversing the accessibility tree.
To be used for refactoring ntext navigation, e.g. move by word, and for text styles.
BUG=521021
[email protected]
Review URL: https://codereview.chromium.org/1296763002
Cr-Commit-Position: refs/heads/master@{#348301}
Roll WebRTC 9918:9920, Libjingle 9915:9920
WebRTC 9918:9920
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8f226a6..0938a04
Libjingle 9915:9920
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/f150b27..df5ede1
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1333043002
Cr-Commit-Position: refs/heads/master@{#348300}
sandbox/linux/bpf_dsl: collapse similar ResultExprImpl subclasses
Allow, Error, Kill, and Trace are all very similar as they just invoke
pc->Return with appropriate SECCOMP_RET_* values, so instead compute
that value once ahead of time. Saves a little bit of program size.
BUG=414363
Review URL: https://codereview.chromium.org/1305323002
Cr-Commit-Position: refs/heads/master@{#348299}
Roll PDFium 0d0935d..89d8b46
https://pdfium.googlesource.com/pdfium.git/+log/0d0935d..89d8b46
BUG=527174
[email protected]
Review URL: https://codereview.chromium.org/1335783002
Cr-Commit-Position: refs/heads/master@{#348298}
Disable TouchActionBrowserTest.DefaultAuto on DrMemory where it's flaky.
BUG=376668
[email protected]
Review URL: https://codereview.chromium.org/1333173002
Cr-Commit-Position: refs/heads/master@{#348297}
Add date mismatch logging.
BUG=528647
Review URL: https://codereview.chromium.org/1334973002
Cr-Commit-Position: refs/heads/master@{#348296}
Roll src/third_party/WebKit 39d49ed:0046ee1 (svn 202080:202082)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/39d49ed..0046ee1
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331333002
Cr-Commit-Position: refs/heads/master@{#348295}
Add scoped_ptr-safe base::Value to Dictionary/List conversion functions.
This change adds two static From() functions to the DictionaryValue and
ListValue classes which take a scoped_ptr to a Value and either convert
it to a scoped_ptr to a DictionaryValue or ListValue, or return nullptr.
These are intended to replace the existing pattern,
make_scoped_ptr(static_cast<base::DictionaryValue*>(value.release()))
with the shorter and safer alternative,
base::DictionaryValue::From(value.Pass())
Instances of this pattern in //extensions have been converted as
examples.
Review URL: https://codereview.chromium.org/1308013005
Cr-Commit-Position: refs/heads/master@{#348294}
HSTS Preload List: Add fi and hana.ondemand.com, remove noobs-r-us.co.uk.
BUG=527947
[email protected]
Review URL: https://codereview.chromium.org/1334023002
Cr-Commit-Position: refs/heads/master@{#348293}
[Android] grant READ_EXTERNAL_STORAGE permission when adding WRITE_EXTERNAL_STORAGE.
BUG=529897
Review URL: https://codereview.chromium.org/1335673004
Cr-Commit-Position: refs/heads/master@{#348292}
WebRTC render smoothness test shows on windows platform the timestamps on the video frames are quite irregular. The reason is that we read the system clock time, when the frame is available to chromium, but the system clock may not be high definition.
In this CL, we changed the behavior to reading timestamp from the capture driver.
BUG=529949
TEST=all unit test and browser test passing, apprtc working as before.
Review URL: https://codereview.chromium.org/1324683004
Cr-Commit-Position: refs/heads/master@{#348291}
Add blink embedder APIs for DomKey conversion.
Implement the platform APIs for DomKey conversion.
BUG=227231
Review URL: https://codereview.chromium.org/1337503002
Cr-Commit-Position: refs/heads/master@{#348290}
Revert of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket (patchset #17 id:500001 of https://codereview.chromium.org/736653002/ )
Reason for revert:
New test on the reference build causing Linux and Mac perf bots to fail. http://crbug.com/530374
Original issue's description:
> [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket
>
> This CL adds blink_perf.pywebsocket, in which
> - Pywebsocket server is started at localhost:8001, and
> - Browser option --disable-web-security is added,
> because we need cross-origin accesses between
> memory_cache_http_server and pywebsocket server.
>
> [1/2] PerformanceTests scripts: https://codereview.chromium.org/738753002/
> [2/2] Telemetry: This CL
>
> BUG=432408
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect
>
> Committed: https://crrev.com/ab513a3c1d3c7a14b55f26f6978ac31ffe530e00
> Cr-Commit-Position: refs/heads/master@{#348149}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=432408,530374
Review URL: https://codereview.chromium.org/1333153002
Cr-Commit-Position: refs/heads/master@{#348289}
Disable MenuItemViewTestRemove11.RemoveItem11 on Window
BUG=523255
Review URL: https://codereview.chromium.org/1336773002
Cr-Commit-Position: refs/heads/master@{#348288}
Rename MockMediaSource.Abort into Shutdown
Also call ChunkDemuxer.Abort before shutting down the demuxer to test
that logic as well.
BUG=none
Review URL: https://codereview.chromium.org/1318643005
Cr-Commit-Position: refs/heads/master@{#348287}
Roll src/third_party/WebKit 2da7f42:39d49ed (svn 202079:202080)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2da7f42..39d49ed
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337663002
Cr-Commit-Position: refs/heads/master@{#348286}
Fix Linux installer dependencies on nacl_helper.
if nacl was disabled, the installer would still pull in a dependency
on nacl_helper, causing build issues.
[email protected], [email protected]
BUG=512882
Review URL: https://codereview.chromium.org/1332073002
Cr-Commit-Position: refs/heads/master@{#348285}
Roll src/third_party/WebKit f64e3eb:2da7f42 (svn 202078:202079)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f64e3eb..2da7f42
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1339483002
Cr-Commit-Position: refs/heads/master@{#348284}
Update browser code to use new enum names for WebConnectionType
1) https://codereview.chromium.org/1333613004
2) https://codereview.chromium.org/1310343010 (this)
3) https://codereview.chromium.org/1326543004
Review URL: https://codereview.chromium.org/1310343010
Cr-Commit-Position: refs/heads/master@{#348283}
Escape "--" in markdown rendering for GN reference docs.
Gitiles has a "feature" in its markdown rendering engine where if it
encounters the string "--" in a non-code context it will replace it with
an em dash; this is usually undesirable in the GN documentation, where
we want to refer to command line flags like --args explicitly.
Working around this properly would likely require either a much more
complicated parser handling markdown output of strings to track context,
or updating the source text to somehow indicate what should be escaped
and what shouldn't, or both.
We can, however, probably achieve a reasonable compromise by making sure
that we don't escape the dashes when they are part of a header string,
since the rest of the GN reference markdown output shows up as code
blocks anyway.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1301423006
Cr-Commit-Position: refs/heads/master@{#348282}
Prevent blink from modifying VideoLayer content opaqueness
The video itself determines the content opacity of the layer, so ignore blink's setOpaque and only honor the WebMediaPlayer's.
BUG=526913
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1313863008
Cr-Commit-Position: refs/heads/master@{#348281}
Try changing LockImpl to not have a spin count to see how it affects performance.
This was last change 7 years ago, and we have grown a lot of usages of locks since then. Since we don't use pthread_spin_lock on posix, I'm curious how this affects performance today on Windows.
Review URL: https://codereview.chromium.org/1333053002
Cr-Commit-Position: refs/heads/master@{#348280}
Fix the mandoline pdfviewer app
Minor patch to the mandoline pdfviewer needs to bind the Surface interface
and construct complete CompositorFrame instances.
BUG=530268
Review URL: https://codereview.chromium.org/1334943004
Cr-Commit-Position: refs/heads/master@{#348279}
Roll src/third_party/WebKit 3b01100:f64e3eb (svn 202077:202078)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3b01100..f64e3eb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334993002
Cr-Commit-Position: refs/heads/master@{#348278}
DevTools: issue detach notification when frontend api connection is kicked out.
BUG=456547
Review URL: https://codereview.chromium.org/1337523002
Cr-Commit-Position: refs/heads/master@{#348277}
roll libyuv r1480 to r1481
r1481 re-enables AVX2 for YUV to RGB conversions.
BUG=libyuv:472,libyuv:489,libyuv:488
Review URL: https://codereview.chromium.org/1321503004
Cr-Commit-Position: refs/heads/master@{#348276}
Add Smart Lock warm welcome on Windows.
BUG=527702
Review URL: https://codereview.chromium.org/1334813002
Cr-Commit-Position: refs/heads/master@{#348275}
Revert of Check the tab ID before delivering an extension message. (patchset #4 id:60001 of https://codereview.chromium.org/1318153002/ )
Reason for revert:
Speculative revert, this may cause compile failure on [precise32, precise64] stable
BUG=530347
Original issue's description:
> Check the tab ID before delivering an extension message.
>
> r335753 changed extension messaging to use RenderFrames, which had the
> side-effect of delivering messages to every RenderFrame in a process,
> which may include other tabs.
>
> This patch fixes that by sending the target tab ID along with the message. A
> more principled fix would have been to track RenderFrames on the browser and
> send to precisely the right ones, but this would need to be part of a more
> comprehensive refactor.
>
> I also fixed up ExtensionApiTest.Connect and re-enabled, which was disabled
> years ago due to flakiness. Hopefully my test JS changes will fix that.
>
> BUG=520303
> [email protected], [email protected]
>
> Committed: https://crrev.com/1344c7dfde448d4b80693f597b02993b7f6bbd5b
> Cr-Commit-Position: refs/heads/master@{#346176}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=520303
Review URL: https://codereview.chromium.org/1339463002
Cr-Commit-Position: refs/heads/master@{#348274}
Don't implicitly convert Rect to RectF in mandoline and ui.
This fixes some more implicit conversions in:
- mandoline's desktop browser window
- views unittests
- android snapshot
[email protected]
BUG=342848
Review URL: https://codereview.chromium.org/1337593003
Cr-Commit-Position: refs/heads/master@{#348273}
Roll src/third_party/WebKit 3e609d8:3b01100 (svn 202074:202077)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e609d8..3b01100
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332123002
Cr-Commit-Position: refs/heads/master@{#348272}
Pass in the metric name to log to UMA and use a different metric name for CSD model download result.
Follow-up from: https://codereview.chromium.org/1289033002#msg26
BUG=477389
Review URL: https://codereview.chromium.org/1326993003
Cr-Commit-Position: refs/heads/master@{#348271}
Roll src/third_party/WebKit f9cb567:3e609d8 (svn 202073:202074)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f9cb567..3e609d8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336743003
Cr-Commit-Position: refs/heads/master@{#348270}
Reland: Adds multilingual support to the language_options_handler.
Originally committed in https://crrev.com/d649b32 by Julius Alexander and
reverted in https://crrev.com/df5cc80 due to GN not picking up changes in
language_options_handler. GN has been fixed, so relanding.
BUG=5102
Review URL: https://codereview.chromium.org/1331243002
Cr-Commit-Position: refs/heads/master@{#348269}
Add secure QUIC support to quic_server
Review URL: https://codereview.chromium.org/1330383002
Cr-Commit-Position: refs/heads/master@{#348268}
Roll src/third_party/skia e66fec2:2bd5d02
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e66fec2..2bd5d02
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
2bd5d02 [email protected] Add simd.md to document Skia SIMD code / plans.
83e599a [email protected] Correct a possible free after use.
a1c0ee4 [email protected] SkNx_shuffle
Review URL: https://codereview.chromium.org/1337453004
Cr-Commit-Position: refs/heads/master@{#348267}
Fix GN auto-roller to handle results from buildbucket-initiated jobs.
It looks like we can get returned a try job state value of -1 now
when the try jobs are run through buildbucket instead of rietveld,
so this change updates the status mapping accordingly.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1336713002
Cr-Commit-Position: refs/heads/master@{#348266}
Fix gn_all, net_unittests build on GN ios.
Stray references to v8 components had gotten in.
[email protected]
Review URL: https://codereview.chromium.org/1311453010
Cr-Commit-Position: refs/heads/master@{#348265}
Make sure cflags is forwarded in the ios_app executable template.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1314413006
Cr-Commit-Position: refs/heads/master@{#348264}
shortcuts: fix dimension rounding issues and standardise names/types
On some devices, rounding issues cause the ideal size to be slightly smaller
than expected. Fix this by keeping the dimension retrieved as a float
before dividing by the density to reduce loss of precision.
Moreover, standardise naming and types of px/dp units in Manifest* classes
to make more explicit the rounding from dp -> px as well as reduce confusion
by using multiple names for the same terminology.
This CL also reverts https://codereview.chromium.org/1310663007/ since it was
fixing the test failures by adding some slop.
BUG=529543
Review URL: https://codereview.chromium.org/1323893003
Cr-Commit-Position: refs/heads/master@{#348263}
Content settings: remove some plugin-related code/resources when... there are no plugins
[email protected]
BUG=522694
Review URL: https://codereview.chromium.org/1308973004
Cr-Commit-Position: refs/heads/master@{#348262}
Removed 'anonymous' from namespace, added whitespace in thread_restrictions.cc
BUG=
Review URL: https://codereview.chromium.org/1337573002
Cr-Commit-Position: refs/heads/master@{#348261}
Roll src/third_party/WebKit 44f35fd:f9cb567 (svn 202072:202073)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/44f35fd..f9cb567
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334953002
Cr-Commit-Position: refs/heads/master@{#348260}
Remove linux_chromium_gn_rel from the chromium CQ.
Since linux_chromium_rel_ng has been flipped from GYP->GN,
this bot is redundant. This CL takes it out of the CQ, and we can
then remove the builder altogether in subsequent changes.
[email protected]
BUG=432959
Review URL: https://codereview.chromium.org/1338473002
Cr-Commit-Position: refs/heads/master@{#348259}
Revert of Make checkboxes/radio buttons larger on Android (patchset #1 id:1 of https://codereview.chromium.org/1330853002/ )
Reason for revert:
This is breaking the web: https://code.google.com/p/chromium/issues/detail?id=530040
Original issue's description:
> Make checkboxes/radio buttons larger on Android
>
> In order to make interacting with checkboxes and radio buttons easier
> with touch, their default size is changed from 13px by 13px (in which
> 1px in each dimension is for the drop shadow) to 16px by 16px (in which
> 2px in each dimension is for a padding around them, including the dorp
> shadow). For non-Android cases, an extra pixel padding is added to each
> dimension to compelete the padding around them and make checkboxes and
> radio buttons centered properly inside their client rects.
>
> BUG=459055
>
> Committed: https://crrev.com/c43b29634e408c0f24d10037fae249f7d8cd2201
> Cr-Commit-Position: refs/heads/master@{#348016}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459055
Review URL: https://codereview.chromium.org/1338493003
Cr-Commit-Position: refs/heads/master@{#348258}
[Custom Tabs]Introduce the url scaling animation
This CL lets the urlbar to animate from large to small, when custom tab
is launching the first given URL. After the scaling animation, the title
bar will fade in.
BUG=505620
Review URL: https://codereview.chromium.org/1329793002
Cr-Commit-Position: refs/heads/master@{#348257}
Fix Data Saver promo crash on pre-L devices.
BUG=530033
Review URL: https://codereview.chromium.org/1335733002
Cr-Commit-Position: refs/heads/master@{#348256}
[Sync] Introduce ModelTypeStore interface
In this change:
- Add empty ModelTypeStore interface
- Pass WeakPtr to store into ModelTypeProcessorImpl::ctor.
BUG=517663
[email protected]
Review URL: https://codereview.chromium.org/1311363009
Cr-Commit-Position: refs/heads/master@{#348255}
Add tracing to AndroidVideoDecodeAccelerator
BUG=516845
Review URL: https://codereview.chromium.org/1331233002
Cr-Commit-Position: refs/heads/master@{#348254}
Extracts more information from serial devices on Mac
At rockot@'s suggestion, I tested this with a small Chrome app that I
wrote (https://github.com/zeptonaut/serial-device-enumerator-app) that
opens a window showing all information that Chrome knows about serial
devices. We chose this route over unit tests because we didn't think
it was wise to write unit tests that assumed specific devices were
plugged into our test servers.
As far as devices, I used an FTDI Chipset High Speed USB 2.0 to Serial
RS-232 DB-9 Converter. This was useful because it's one of not-so-many
devices that has both serial properties (dialin and callout paths) and
USB properties (vendor ID, device ID, and product string).
BUG=522217
Review URL: https://codereview.chromium.org/1306733008
Cr-Commit-Position: refs/heads/master@{#348253}
net: Remove code for session cookie deletion experiment.
The original experiment attempted to measure the effect of deleting session
cookies at shutdown on startup time. This experiment was flawed, because there
are several cases where Chrome doesn't want to delete session cookies during
shutdown.
BUG=488314
Review URL: https://codereview.chromium.org/1333033002
Cr-Commit-Position: refs/heads/master@{#348252}
Disable rei.com on oopif benchmarks.
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect
BUG=522870
Review URL: https://codereview.chromium.org/1334733002
Cr-Commit-Position: refs/heads/master@{#348251}
MediaCodecPlayer - tests data is always 4 units
This is a potential fix for AVPrerollVideoEndsWhilePrerolling test.
Before this change the last data chunk could have less than four
access units. For the video stream with different decoder
and presentation order this might have caused invalid data
generation, i.e. the chunk (I P EOS) instead of expected (I P B EOS).
We believe that the missing B frame sometimes caused the blocking of
video decoder (it waits forever for B frame even after receiving EOS).
This change modifies the data generator such that the chunks
always have four access units, thus for last video chunk we
automatically get correct frame sequence (I P B EOS). Because we
now extend the data to fill the 4-unit chunk the
actual stream duration will exceed the requested one.
Manually reverted most of the logs added in
https://codereview.chromium.org/1318933005 and
https://codereview.chromium.org/1325153005
Removed one DCHECK about the current state in OnDecoderDrained
- the assumption was incorrect.
BUG=407577, 526755
Review URL: https://codereview.chromium.org/1317893005
Cr-Commit-Position: refs/heads/master@{#348250}
Convert remaining frame tests to create FrameTreeClients via mojo
Old way was injecting FrameTreeClient implementation rather than
having it come via mojo. New way better matches what really happens,
and means can cleanup some code in FrameTree.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1332033002
Cr-Commit-Position: refs/heads/master@{#348249}
Remove the SkBitmap-based CC fake/mock methods
After http://crrev.com/1314353005 almost all unit tests are using the
SkImage-based API.
Convert the remaining clients, and remove the SkBitmap API entirely.
[email protected],[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1335503005
Cr-Commit-Position: refs/heads/master@{#348248}
Revert of content_{renderer,tests}.gypi cleanup of plugin+webrtc sources (patchset #1 id:1 of https://codereview.chromium.org/1327353002/ )
Reason for revert:
Speculative revert since this may break mac gn trybots
BUG=530330
Original issue's description:
> content_{renderer,tests}.gypi cleanup of plugin+webrtc sources
>
> Moving around some files after renaming made more evident
> what they do.
>
> BUG=525817
>
> Committed: https://crrev.com/fc3c2df218caee93a913612a6ad6ef84f6169d0c
> Cr-Commit-Position: refs/heads/master@{#348232}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525817
Review URL: https://codereview.chromium.org/1336693003
Cr-Commit-Position: refs/heads/master@{#348247}
Force swap buffers when re-creating the buffers
The SwapResult provides a way to signal when the buffers are no longer
adequate and need to be re-allocated. Currently the surfaceless
implementation of the GpuBrowserCompositorOutputSurface will re-allocate
the buffers, however it doesn't swap again. Since the previous buffer
was rejected the display is showing an old frame.
BUG=511446
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1327343003
Cr-Commit-Position: refs/heads/master@{#348246}
chrome: Fix Android dependency issues.
The chrome/browser/tracing/chrome_tracing_delegate.cc source file
uses the BrowserList class, which is unavailable on Android. Similarly,
chrome/browser/ui/webui/foreign_session_handler.cc uses NewTabUI, which is
also unavailable on Android. This causes link failures when using LTO. To
fix this, do not compile these files when targeting Android.
Introduces a small functional change: we no longer register preferences for
ChromeTracingDelegate on Android. I don't know enough about the preferences
system to know if this is important.
There is a browser test for this component in
chrome_tracing_delegate_browsertest.cc, but according to crbug.com/384724
the browser tests aren't used on Android so this shouldn't matter.
BUG=469376
[email protected]
Review URL: https://codereview.chromium.org/1289103003
Cr-Commit-Position: refs/heads/master@{#348245}
Stop compiling global error code on Android
(no behavioral change)
BUG=136506
Review URL: https://codereview.chromium.org/1327843002
Cr-Commit-Position: refs/heads/master@{#348244}
Added and implemented URLRequest::GetTotalSentBytes.
Added and implemented URLRequest::GetTotalSentBytes,
URLRequestJob::GetTotalSentBytes, and
HttpTransaction::GetTotalSentBytes, which count the number of bytes sent
over the network, similar to GetTotalReceivedBytes.
BUG=518897
Review URL: https://codereview.chromium.org/1327763003
Cr-Commit-Position: refs/heads/master@{#348243}
Fix spacing within location bar bubbles
Modify IconLabelBubbleView::GetSizeForLabelWidth()
to avoid computing a larger size than is necessary
for the icon and text within a location bar bubble.
BUG=529715
TEST=manual
Review URL: https://codereview.chromium.org/1336663002
Cr-Commit-Position: refs/heads/master@{#348242}
Detect missing files when doing bower updates
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/1337533002
Cr-Commit-Position: refs/heads/master@{#348241}
cc: Consolidate calls to the root scroll dalegate UpdateRootLayerState.
There's 2 different ways we call this function. Sometimes we call it
directly, and pass it the TotalScrollOffset.
Sometimes we call LayerTreeImpl::UpdateRootScrollOffsetDelegate() and
it computes the equivalent of TotalScrollOffset.
This merges them to all just call UpdateRootScrollOffsetDelegate() and
make that function use TotalScrollOffset().
R=boliu, jdduke
BUG=522658
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1315373006
Cr-Commit-Position: refs/heads/master@{#348240}
Roll src/third_party/WebKit 2bae2a5:44f35fd (svn 202071:202072)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2bae2a5..44f35fd
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331903004
Cr-Commit-Position: refs/heads/master@{#348239}
Roll src/third_party/skia 059dffa:e66fec2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/059dffa..e66fec2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
e66fec2 [email protected] fix missing clipmaskmanager
a10bb86 [email protected] make a shallow-copy so we don't get racy trying to lock/unlock our private bitmap
eef3c5b [email protected] Fix texture creation on stencil format test code
4e8a09d [email protected] Port SkMatrix opts to SkOpts.
b3b9aec [email protected] Remove GrClipTarget
ad792c1 [email protected] Simplify installation of pipeling into GrDrawBatch in GrDrawTarget
f238469 [email protected] Late creation of GrPathProcessor
512be53 [email protected] Cleanup GrDrawTarget now that all paths lead to GrBatch
4a37d08 [email protected] Port SkBlitRow::Color32 to SkOpts.
d69ece6 [email protected] DM: add --key and --properties to PNG description field.
a82bf95 [email protected] Fix leak of path ranges
ff1d547 [email protected] Calculate pixel config and stencil fmt pairs once per pixel config.
6c6f658 [email protected] Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessing the same GrContext to read back GPU input data
Review URL: https://codereview.chromium.org/1334823003
Cr-Commit-Position: refs/heads/master@{#348238}
Make sure RendererTasks favicons and titles are updated at the right time.
We used to listen to WebContentsObserer::TitleWasSet() which didn't work
for web pages that don't have title. We also used ti listen to
WebContentsObserver::DidUpdateFaviconURL() which doesn't necessarily
mean that the favicon is ready to be caches by RendererTasks.
This CL fixes these issues.
[email protected]
BUG=528924,527098
Review URL: https://codereview.chromium.org/1334503002
Cr-Commit-Position: refs/heads/master@{#348237}
Update V8 to version 4.7.43.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d683bfc..4b85d844
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330313002
Cr-Commit-Position: refs/heads/master@{#348236}
Change toolbar height for material design on Ash
Render the tabstrip separator line
programmatically as 1 device pixel
(regardless of device scale factor) for
material design. This results in a
toolbar height of 37px for 'material'
and 41px for 'material hybrid', which
is the distance between the bottom
toolbar/content separator (inclusive)
and the tabstrip separator (exclusive).
BUG=527969
TEST=manual
R=pkasting
TBR=pkotwicz
Review URL: https://codereview.chromium.org/1322323006
Cr-Commit-Position: refs/heads/master@{#348235}
Sandbox: Reenable tests that were disabled "temporarily" 2 years ago.
BUG=305815
Review URL: https://codereview.chromium.org/1291793003
Cr-Commit-Position: refs/heads/master@{#348234}
Roll src/third_party/WebKit 169e2a86:2bae2a5 (svn 202069:202071)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/169e2a86..2bae2a5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335663003
Cr-Commit-Position: refs/heads/master@{#348233}
content_{renderer,tests}.gypi cleanup of plugin+webrtc sources
Moving around some files after renaming made more evident
what they do.
BUG=525817
Review URL: https://codereview.chromium.org/1327353002
Cr-Commit-Position: refs/heads/master@{#348232}
Limit overlap between BubbleManager and BaseBubbleController.
The BubbleManager will be responsible for notifying bubbles of events
that can cause a bubble to close. The BaseBubbleController also notifies
the UI. This CL removes duplicate notifications on cocoa.
BUG=496955
Review URL: https://codereview.chromium.org/1328873002
Cr-Commit-Position: refs/heads/master@{#348231}
Increase log level in DecoderBufferQueue from 1 to 2
This log message is emitted when buffers that are appended
by the demuxer (in decode order) have out of order
presentation timestamps. There is no requirement that the
decode order matches the presentation timestamp order so
this log message too noisy for some streams.
Review URL: https://codereview.chromium.org/1333973002
Cr-Commit-Position: refs/heads/master@{#348230}
ipc: Add the inner class OutputElement to Channel.
OutputElement is a wrapper around messages that are going to be written to the
underlying OS IPC mechanism. It can wrap either a Message, or a data buffer
which contains serialized attachment broker metainformation.
BUG=493414
Review URL: https://codereview.chromium.org/1309003003
Cr-Commit-Position: refs/heads/master@{#348229}
Remove unused code in InlineLoginHandlerImpl.
BUG=None
Review URL: https://codereview.chromium.org/1330163009
Cr-Commit-Position: refs/heads/master@{#348228}
Roll src/third_party/WebKit f200a07:169e2a86 (svn 202068:202069)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f200a07..169e2a86
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327313003
Cr-Commit-Position: refs/heads/master@{#348227}
Fix NaCl IRT copy in GN chrome build.
When we build the IRT in GN, it gets built into
out/*/irt_x64/nacl_irt.nexe, but it needs to be copied
to out/*/nacl_irt_x86_64.nexe.
There were two places in the GN build that depended on
the IRT; the chrome dependency only depended on the toolchain-specific
location, and the browser_tests dependency only worked if
the nacl browsertests are enabled (which they currently aren't,
by default).
As a result, we may not get the IRT build into the right
location, and the 'nacl_integration' build step might fail (though
it might succeed if it happened to find an old binary lying around).
Fixing the chrome dependency should cause the nacl_integration
step to pass again.
[email protected], [email protected], [email protected]
BUG=529988
Review URL: https://codereview.chromium.org/1338453002
Cr-Commit-Position: refs/heads/master@{#348226}
[ChromeDriver] Disable BasicMouseInterfaceTest.* java tests for chrome_beta
BUG=chromedriver:1220
Review URL: https://codereview.chromium.org/1334723004
Cr-Commit-Position: refs/heads/master@{#348225}
Modified RenderFrameObserver API
We add a method to RenderFrameObserver in order to propogate
notifications out of Blink to chrome/. This is detailed in the design document https://docs.google.com/document/d/1bBO5JjQhOYjiLx_XpajIsV3vQt-h-0faKpQYM5dXdig
BUG=382542
Review URL: https://codereview.chromium.org/1289053003
Cr-Commit-Position: refs/heads/master@{#348224}
Call SkGraphics::Init for in-process V2
Previous attempt called SkGraphics::Init in renderer init, which races
with browser side code that uses skia.
Also noticed that nothing ever calls SkGraphics::Init on browser side,
so this patch calls it in browser process init.
For single-process, RendererMain doesn't run, so SkGraphics::Init is
called once. For multi-process, SkGraphics::Init is not called in both
browser and renderer processes.
BUG=525844
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_tsan_rel_ng
Review URL: https://codereview.chromium.org/1336673002
Cr-Commit-Position: refs/heads/master@{#348223}
Makes all tests isolated for now
There are race conditions to do otherwise. Until they are sorted out,
we should run isolated, otherwise we're going to have flake.
BUG=529487
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1303303005
Cr-Commit-Position: refs/heads/master@{#348222}
[blimp] Fix Android build and add blimp to waterfall and trybots.
This CL fixes building blimp_apk, and changes Android to also use the
meta-target 'blimp' to be able to build all prod-code.
In addition, to ensure there are no more regressions, this adds the
blimp target to main waterfall and trybots for Linux and Android.
BUG=None
Review URL: https://codereview.chromium.org/1332993002
Cr-Commit-Position: refs/heads/master@{#348221}
Remove slot unlock from selection dialog on ChromeOS.
The client certificate selection dialogs called code to unlock NSS slots containing the certificates.
On ChromeOS this isn't required and thus can be removed from compilation.
BUG=514575
Review URL: https://codereview.chromium.org/1331593002
Cr-Commit-Position: refs/heads/master@{#348220}
Remove unused code in CalculateVisibleRects
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1332923004
Cr-Commit-Position: refs/heads/master@{#348219}
- Remove typingmonitor.cc/.h from build config.
- Add mediacontroller.cc/.h to build config.
BUG=webrtc:4690
Review URL: https://codereview.chromium.org/1321853008
Cr-Commit-Position: refs/heads/master@{#348218}
Roll ANGLE 54c311f..4a69356
https://chromium.googlesource.com/angle/angle.git/+log/54c311f..4a69356
BUG=530226
TEST=bots
TBR=jmadill
Review URL: https://codereview.chromium.org/1336623002
Cr-Commit-Position: refs/heads/master@{#348217}
Roll src/third_party/WebKit 9b5484c:f200a07 (svn 202067:202068)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b5484c..f200a07
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330353007
Cr-Commit-Position: refs/heads/master@{#348216}
Add the proper dependencies for an internal build of cast_shell.
This includes adding cast_shell_internal and cleaning up some TODOs.
BUG=516899
Review URL: https://codereview.chromium.org/1330353005
Cr-Commit-Position: refs/heads/master@{#348215}
NACL_IO: Split handle locks.
Under linux it is possile for a single fd to allow Thread A to block on
reading from a fd while Thread B writes to the same fd.
Read-like operations now use an input_lock_. Write-like operations under
an output_lock_. Handle and attributes remain on the handle_lock_.
Added the inverse of AUTO_LOCK; AUTO_UNLOCK which unlocks until end of
scope and then re-locks.
See
https://android.googlesource.com/platform/system/core/+/master/adb/transport.cpp
for an example use, specifically, the read and write threads use the
same t->fd.
BUG=516764
Review URL: https://codereview.chromium.org/1321883003
Cr-Commit-Position: refs/heads/master@{#348214}
removed variable re-declaration.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1321253007
Cr-Commit-Position: refs/heads/master@{#348213}
[DevTools] Reload from browser for view source mode.
BUG=529681
Review URL: https://codereview.chromium.org/1319973014
Cr-Commit-Position: refs/heads/master@{#348212}
Add missing histogram values for <webview>'s WebRequest API events.
This prevents hitting NOTREACHED() when calling .addListener on those
events.
BUG=528853
Test=Hangouts app should work in debug chromium. See bug for details.
Review URL: https://codereview.chromium.org/1315713010
Cr-Commit-Position: refs/heads/master@{#348211}
Load material design pak files into ResourceBundle on Windows
Load chrome_material_{100,200}_percent.pak,
the pak files containing material design
assets for browser top chrome, into ResourceBundle
on startup for Windows. Note this will only
load the assets for development builds; the
material assets will not be available on
official builds until crbug.com/505796 is
resolved.
BUG=505595
TEST=none
Review URL: https://codereview.chromium.org/1324753003
Cr-Commit-Position: refs/heads/master@{#348210}
Roll src/third_party/WebKit a9a555c:9b5484c (svn 202066:202067)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a9a555c..9b5484c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330333003
Cr-Commit-Position: refs/heads/master@{#348209}
Don't Allow Service Workers for Unloaded Extensions
Extensions are interesting, in that they can be unloaded and reloaded,
and their state should be the same after this (especially since it can
happen on every browser start/stop). Any service workers that an
extension has should not be running during the time that the extension
is not loaded, but on reload, these workers should be put in place again,
and should maintain their cache.
For this, check if the extension is loaded in AllowServiceWorkers(), and
stop any running service workers when the extension is unloaded.
BUG=519326
[email protected] (small changes to misc content/ files)
Review URL: https://codereview.chromium.org/1313213002
Cr-Commit-Position: refs/heads/master@{#348208}
Fix content verification failures on unusual content script paths
If content script paths had a leading "./" in them, we'd fail to find
expected hashes for them because we weren't properly stripping the
leading junk from the relative path.
BUG=437675
Review URL: https://codereview.chromium.org/1315713009
Cr-Commit-Position: refs/heads/master@{#348207}
[sessions] Remove most knowledge of //chrome from core tab restore code
As part of the effort to componentize tab restore code, this CL removes most remaining knowledge of //chrome from that code, replacing it with abstraction through TabRestoreServiceClient:
- Profile::GetPath()
- Metrics for recording extensions apps launching
- Usage of //chrome-level URL constant
BUG=528883
Review URL: https://codereview.chromium.org/1309363007
Cr-Commit-Position: refs/heads/master@{#348206}
Roll src/third_party/WebKit b0b593a:a9a555c (svn 202065:202066)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b0b593a..a9a555c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335503007
Cr-Commit-Position: refs/heads/master@{#348205}
Misc clean up in browser_shutdown.cc.
- Rename globals from foo_ to g_foo.
- Use range for-loops / etc.
Review URL: https://codereview.chromium.org/1319513003
Cr-Commit-Position: refs/heads/master@{#348204}
Bubble watchlist.
- Add components/bubble/ to bubble directories.
- Add rouslan/hcarmona/groby to bubble watchlist recipients.
- Remove 'watch' from rouslan's email address.
- Remove aclicet from watchlist.
BUG=NONE
Review URL: https://codereview.chromium.org/1330233006
Cr-Commit-Position: refs/heads/master@{#348203}
Add functions to let tests read and control the Bluetooth chooser state.
These functions are specified at https://webbluetoothcg.github.io/web-bluetooth/tests/.
See tests using this in https://codereview.chromium.org/1304353004/.
BUG=500989
Review URL: https://codereview.chromium.org/1325953002
Cr-Commit-Position: refs/heads/master@{#348202}
[Sync] isSyncInitialized -> isBackendInitialized on Android.
BUG=497518
Review URL: https://codereview.chromium.org/1333573004
Cr-Commit-Position: refs/heads/master@{#348201}
Roll src/third_party/WebKit 15071ee:b0b593a (svn 202064:202065)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/15071ee..b0b593a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327343002
Cr-Commit-Position: refs/heads/master@{#348200}
MD Downloads: move "Controlled by Extension" to data binding
[email protected]
BUG=526577
Review URL: https://codereview.chromium.org/1333753002
Cr-Commit-Position: refs/heads/master@{#348199}
Invert the flag for prefixed EME.
Once the Blink change lands, the prefixed EME APIs will be disabled by default.
They can be enabled with the enable-prefixed-encrypted-media flag.
BUG=451117
Review URL: https://codereview.chromium.org/1327113002
Cr-Commit-Position: refs/heads/master@{#348198}
[GN] Remove cflags_c from objc and cflags_cc from objcxx toolchains
//build/config/compiler/BUILD.gn has the following lines which make the declarations in the toolchains superfluous:
# Pass the same C/C++ flags to the objective C/C++ compiler.
cflags_objc += cflags_c
cflags_objcc += cflags_cc
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/1335503006
Cr-Commit-Position: refs/heads/master@{#348197}
Makes FrameTree delete a frame if the embedded app disconnects
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1331983002
Cr-Commit-Position: refs/heads/master@{#348196}
Exposing a new chrome.bluetoothPrivate.pair JS API.
This CL exposes a new private javascript API in bluetoothPrivate. This
method triggers connection and pairing with a remote bluetooth (both
low energy and classic) device.
In order to pair with a given device, it's necessary to first register
a listener for the |bluetoothPrivate.onPairing| event. The pairing
request can then be replied using |bluetoothPrivate.setPairingResponse|.
The |bluetoothPrivate.pair| callback will be called once the call is
completed, with eventual an error register in |runtime.lastError|. If
the remote device is already paired the call will succeed (eventually
connecting the devices) without a |bluetoothPrivate.onPairing| event
being fired.
TEST=manual and browser tests
BUG=528270
Review URL: https://codereview.chromium.org/1310083005
Cr-Commit-Position: refs/heads/master@{#348195}
Allow 'chrome-extension:' URLs to bypass content settings (1/2)
We changed the behavior of 'Document::firstPartyForCookies' to return an
empty URL in the case where any URL in the ancestor chain doesn't match
the current document's URL. Previously, we'd simply return the top-level
document's URL.
This means that the content-settings bypass check in
'ContentSettingsObserver::IsWhitelistedForContentSettings' sees an empty
URL as opposed to a 'chrome-extension://' URL for cases in which an
extension loads a resource, so content settings are applied as per usual.
This breaks things fairly badly for folks who have turned on third-party
cookie blocking.
In these patches, we introduce a new scheme registry for those schemes
which ought to override Blink's concept of "first-party" when they're
loaded into the top-level browsing context.
Patch 1 (Blink): https://codereview.chromium.org/1305253012
Patch 2 (Chromium): [This patch]
BUG=527963
[email protected]
Review URL: https://codereview.chromium.org/1332563006
Cr-Commit-Position: refs/heads/master@{#348194}
Add a new flag to assist in landing optimization update.
This is as described in the new comment to assist in updating V8 so https://codereview.chromium.org/1324623005/ can be landed.
TBR=dpranke
Review URL: https://codereview.chromium.org/1330423002
Cr-Commit-Position: refs/heads/master@{#348193}
Roll src/third_party/WebKit 51f611e:15071ee (svn 202061:202064)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/51f611e..15071ee
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331993003
Cr-Commit-Position: refs/heads/master@{#348192}
Landing Recent QUIC changes until 8/26/2015 19:47 UTC.
Fix code relying on undocumented SimpleAtoi quirk, which caused rollback
of cl/101239633. The quirk was that if an input contained null byte,
everything past this byte would be silently ignored; this behavior will
soon be removed.
relnote: n/a (only affects tests)
passes with strings change patched in.
Ported this server side change to keep code similar to internal code.
Merge internal change: 101605155
https://codereview.chromium.org/1308323012/
relnote: clang_tidy (tidy up). Fixed include order.
Merge internal change: 101595102
https://codereview.chromium.org/1321663007/
relnote: Deprecate FLAGS_quic_allow_ip_migration.
Merge internal change: 101489487
https://codereview.chromium.org/1334583002/
relnote: Cache-align the encryption buffer in QuicPacketGenerator::SerializeAndSendPacket.
The optimized crypto algorithms operate best on aligned memory. This
saves about 0.6% wall time and 0.6% CPU time in QUIC.
Merge internal change: 101462412
https://codereview.chromium.org/1327743005/
relnote: Close the QUIC connection when a packet is about to be sent out
of order instead of attempting to send it.
Merge internal change: 101391398
https://codereview.chromium.org/1304833006/
relnote: Deprecate FLAGS_quic_dont_write_when_flow_unblocked.
Merge internal change: 101389540
https://codereview.chromium.org/1329693006/
relnote: Don't add burst tokens to QUIC's PacingSender when in recovery.
Reduces over-aggressive sending at small CWNDs.
Merge internal change: 101384906
https://codereview.chromium.org/1313623006/
[email protected]
Review URL: https://codereview.chromium.org/1335443002
Cr-Commit-Position: refs/heads/master@{#348191}
Fix tab close button position calculation to make sense.
The close button is padded on either side so that in touch mode its hit test area will be bigger. Basically, the left padding area covers a bit of the gap between title and close button; the close button itself extends to the right edge of the tab's "interior content" area (a region called |lb| in the code); then the right padding extends to the right edge of the tab.
However, the math the old code used to implement this made no sense. It placed the beginning of the left padding region at lb.width(), which isn't a meaningful coordinate in the local coordinate space of the tab, since |lb| is inset from the tab bounds on both sides and thus doesn't start at 0. It's possible the code meant to use lb.right() instead of lb.width(), but doing this would have pushed the close button over into the region of the tab reserved for the trailing edge graphic. So I don't know what the code was meant to do. (The calculation for the right side padding amount is torturous if read on its own; instead read it as simply computing "however much padding is needed to reach the right side of the tab, given the left side padding and X coordinate of the close button that are calculated above and below".)
The new code is more direct. The close button's right edge (ignoring padding) is placed flush against the right edge of |lb|. Then the padding on either side is a simple constant.
The reason the old code wasn't noticed as being wrong was because, in 100% mode, the practical difference between the old code and new code is just 1 pixel: the distance from the right side of the close button to the right side of the tab was 18 px, while the width of the right hand graphic (kRightPadding) is 17 px. Since the close button also has whitespace inside its graphic, it doesn't visually align flush with the upper right corner of the tab anyway, so it was quite difficult to tell that the offset between close button and corner was 1 pixel too large.
The reason for this tiny discrepancy, however, is just an artifact of the close button size and the sizes of the various padding constants here, especially kLeftPadding and kRightPadding. When updating the code for Material Design, which uses very different padding values, the old code miscalculated the close button position quite noticeably. The new code works for both MD and non-MD cases.
P.S.: Boo to the unittests here, which seem brittle and possibly worse than having no tests given the hardcoding of values all over the place. These are going to break really badly in the Material Design rework...
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1334643002
Cr-Commit-Position: refs/heads/master@{#348190}
Change tab offset constant to tab overlap constant and add getter in TabStrip.
Referring to the overlap between two tabs makes more sense intuitively than
talking about the offset of the second tab's left edge from the first tab's end.
It's also a little clearer in code since you're never subtracting a negative
number.
The getter in TabStrip isn't currently interesting (just returns a constant),
but will make more sense once this value is parametrized for the Material
Design work.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1327233002
Cr-Commit-Position: refs/heads/master@{#348189}
Don't draw a visible separator atop the bookmarks bar in fullscreen mode.
The actual implementation of this is simple: just always overlap the toolbar by
the same amount, instead of not overlapping it in fullscreen mode. Then in
fullscreen mode the separator will be offscreen.
The bookmark bar height doesn't change, as the overlap is added to the desired
height, so the only visual effect is to not have a random separator at the top
of the screen.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1330163008
Cr-Commit-Position: refs/heads/master@{#348188}
Remove MPL/GPL/LGPL license block from download_extensions.cc
The license block was originally believed to apply to the list of
dangerous file types. After reconsideration the original list of files
was deemed uncopyrightable and the lookup logic is governed under
Chromium's LICENSE.
BUG=none
Review URL: https://codereview.chromium.org/1326783004
Cr-Commit-Position: refs/heads/master@{#348187}
Throw errors for nested targets in GN.
People sometimes nest targets or configs, usually with the assumption that
this limits the visibility of a config to within a target. But this nesting
provides no visibility restrictions over declaring it outside of a block.
For clarity, force certain types of blocks to be non-nested.
Adds missing ordering documentation to the ldflags variable.
Review URL: https://codereview.chromium.org/1314773005
Cr-Commit-Position: refs/heads/master@{#348186}
Disable java test ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement
BUG=chromedriver:998
Review URL: https://codereview.chromium.org/1327293003
Cr-Commit-Position: refs/heads/master@{#348185}
Remove memory.idle_multi_tab benchmark because it is too noisy.
BUG=495022
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect
Review URL: https://codereview.chromium.org/1333923002
Cr-Commit-Position: refs/heads/master@{#348184}
Mandoline: Speculative Fix for Flaky tests + Cleanup
The SubmitCompositorFrame callback is called during destruction if there's a
CompositorFrame in flight. At that point, the DefaultDisplayManager is invalid
and crashes. This CL gives DisplayManager a WeakPtrFactory to avoid a call back
during destruction.
This CL also cleans up TopLevelDisplayClient.
BUG=492389
Review URL: https://codereview.chromium.org/1330193002
Cr-Commit-Position: refs/heads/master@{#348183}
Revert of Call SkGraphics::Init for in-process renderer init (patchset #1 id:1 of https://codereview.chromium.org/1325303005/ )
Reason for revert:
Appears to have broken TSan: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/10185/steps/content_browsertests/logs/stdio
==================
WARNING: ThreadSanitizer: data race (pid=15737)
Write of size 8 at 0x00000672dc40 by thread T23:
#0 SkOpts::Init_ssse3() third_party/skia/src/opts/SkOpts_ssse3.cpp:17:26 (content_browsertests+0x0000016e79f6)
#1 init third_party/skia/src/core/SkOpts.cpp:69:34 (content_browsertests+0x000001423968)
#2 sk_once_no_arg_adaptor third_party/skia/include/core/SkOnce.h:127 (content_browsertests+0x000001423968)
#3 sk_once_slow<SkOnceFlag, void (*)()> third_party/skia/include/core/SkOnce.h:76 (content_browsertests+0x000001423968)
#4 SkOnce<SkOnceFlag, void (*)()> third_party/skia/include/core/SkOnce.h:114 (content_browsertests+0x000001423968)
#5 SkOnce<void (*)()> third_party/skia/include/core/SkOnce.h:120 (content_browsertests+0x000001423968)
#6 SkOnce third_party/skia/include/core/SkOnce.h:131 (content_browsertests+0x000001423968)
#7 SkOpts::Init() third_party/skia/src/core/SkOpts.cpp:77 (content_browsertests+0x000001423968)
#8 SkGraphics::Init() third_party/skia/src/core/SkGraphics.cpp:49:5 (content_browsertests+0x0000014124e1)
#9 content::RenderProcessImpl::RenderProcessImpl() content/renderer/render_process_impl.cc:47:3 (content_browsertests+0x000004d8cf6e)
#10 content::InProcessRendererThread::Init() content/renderer/in_process_renderer_thread.cc:23:29 (content_browsertests+0x000004d8cd4b)
#11 base::Thread::ThreadMain() base/threading/thread.cc:242:3 (content_browsertests+0x000000edc4d6)
#12 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:64:3 (content_browsertests+0x000000ed6de8)
Previous read of size 8 at 0x00000672dc40 by thread T14:
#0 SkBlitMask::BlitColor(SkPixmap const&, SkMask const&, SkIRect const&, unsigned int) third_party/skia/src/core/SkBlitMask_D32.cpp:59:9 (content_browsertests+0x0000016cca1a)
#1 SkARGB32_Opaque_Blitter::blitMask(SkMask const&, SkIRect const&) third_party/skia/src/core/SkBlitter_ARGB32.cpp:188:9 (content_browsertests+0x0000015967f1)
#2 blitMask third_party/skia/src/core/SkDrawProcs.h:50:13 (content_browsertests+0x00000140beee)
#3 D1G_RectClip(SkDraw1Glyph const&, long, long, SkGlyph const&) third_party/skia/src/core/SkDraw.cpp:1490 (content_browsertests+0x00000140beee)
#4 SkDraw::drawPosText(char const*, unsigned long, float const*, int, SkPoint const&, SkPaint const&) const third_party/skia/src/core/SkDraw.cpp:1796:21 (content_browsertests+0x00000140dfe2)
#5 SkBitmapDevice::drawPosText(SkDraw const&, void const*, unsigned long, float const*, int, SkPoint const&, SkPaint const&) third_party/skia/src/core/SkBitmapDevice.cpp:348:5 (content_browsertests+0x00000157ab25)
#6 SkCanvas::onDrawPosText(void const*, unsigned long, SkPoint const*, SkPaint const&) third_party/skia/src/core/SkCanvas.cpp:2432:9 (content_browsertests+0x0000013fd87b)
#7 SkCanvas::drawPosText(void const*, unsigned long, SkPoint const*, SkPaint const&) third_party/skia/src/core/SkCanvas.cpp:2507:5 (content_browsertests+0x0000013fe4a3)
#8 draw<SkRecords::DrawPosText> third_party/skia/src/core/SkRecordDraw.cpp:109:1 (content_browsertests+0x000001454931)
#9 operator()<SkRecords::DrawPosText> third_party/skia/src/core/SkRecordDraw.h:60 (content_browsertests+0x000001454931)
#10 void SkRecord::Record::visit<void, SkRecords::Draw>(SkRecords::Draw&) const third_party/skia/src/core/SkRecord.h:170 (content_browsertests+0x000001454931)
#11 visit<void, SkRecords::Draw> third_party/skia/src/core/SkRecord.h:52:16 (content_browsertests+0x0000014524b2)
#12 SkRecordDraw(SkRecord const&, SkCanvas*, SkPicture const* const*, SkDrawable* const*, int, SkBBoxHierarchy const*, SkPicture::AbortCallback*) third_party/skia/src/core/SkRecordDraw.cpp:55 (content_browsertests+0x0000014524b2)
#13 SkBigPicture::playback(SkCanvas*, SkPicture::AbortCallback*) const third_party/skia/src/core/SkBigPicture.cpp:37:5 (content_browsertests+0x000001578047)
#14 SkCanvas::onDrawPicture(SkPicture const*, SkMatrix const*, SkPaint const*) third_party/skia/src/core/SkCanvas.cpp:2800:5 (content_browsertests+0x00000140065d)
#15 SkCanvas::drawPicture(SkPicture const*, SkMatrix const*, SkPaint const*) third_party/skia/src/core/SkCanvas.cpp:2770:13 (content_browsertests+0x000001400460)
#16 drawPicture third_party/skia/include/core/SkCanvas.h:996:9 (content_browsertests+0x000001896568)
#17 cc::DrawingDisplayItem::Raster(SkCanvas*, gfx::Rect const&, SkPicture::AbortCallback*) const cc/playback/drawing_display_item.cc:51 (content_browsertests+0x000001896568)
#18 cc::DisplayItemList::Raster(SkCanvas*, SkPicture::AbortCallback*, gfx::Rect const&, float) const cc/playback/display_item_list.cc:110:7 (content_browsertests+0x00000189432d)
#19 cc::DisplayListRasterSource::RasterCommon(SkCanvas*, SkPicture::AbortCallback*, gfx::Rect const&, gfx::Rect const&, float) const cc/playback/display_list_raster_source.cc:121:5 (content_browsertests+0x00000198c38e)
#20 cc::DisplayListRasterSource::PlaybackToCanvas(SkCanvas*, gfx::Rect const&, gfx::Rect const&, float) const cc/playback/display_list_raster_source.cc:99:3 (content_browsertests+0x00000198c45e)
#21 cc::TileTaskWorkerPool::PlaybackToMemory(void*, cc::ResourceFormat, gfx::Size const&, unsigned long, cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, float, bool) cc/raster/tile_task_worker_pool.cc:207:5 (content_browsertests+0x00000199a6e4)
#22 cc::OneCopyTileTaskWorkerPool::PlaybackAndCopyOnWorkerThread(cc::Resource const*, cc::ResourceProvider::ScopedWriteLockGL const*, cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, float, bool, unsigned long, unsigned long) cc/raster/one_copy_tile_task_worker_pool.cc:410:7 (content_browsertests+0x000001994418)
#23 cc::(anonymous namespace)::RasterBufferImpl::Playback(cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long, float, bool) cc/raster/one_copy_tile_task_worker_pool.cc:51:5 (content_browsertests+0x000001996b6c)
#24 Raster cc/tiles/tile_manager.cc:129:5 (content_browsertests+0x0000018ce4e8)
#25 cc::(anonymous namespace)::RasterTaskImpl::RunOnWorkerThread() cc/tiles/tile_manager.cc:90 (content_browsertests+0x0000018ce4e8)
#26 cc::TaskGraphRunner::RunTaskWithLockAcquired() cc/raster/task_graph_runner.cc:418:5 (content_browsertests+0x0000018a9f20)
#27 cc::TaskGraphRunner::Run() cc/raster/task_graph_runner.cc:361:5 (content_browsertests+0x0000018a9617)
#28 content::(anonymous namespace)::RasterThread::Run() content/browser/compositor/gpu_process_transport_factory.cc:86:25 (content_browsertests+0x000004a06a03)
#29 base::SimpleThread::ThreadMain() base/threading/simple_thread.cc:66:3 (content_browsertests+0x000000edb6d2)
#30 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:64:3 (content_browsertests+0x000000ed6de8)
Location is global 'SkOpts::blit_mask_d32_a8' of size 8 at 0x00000672dc40 (content_browsertests+0x00000672dc40)
Thread T23 'Chrome_InProcRendererThread' (tid=15780, running)
Thread T14 'CompositorTileW' (tid=15755, running)
SUMMARY: ThreadSanitizer: data race third_party/skia/src/opts/SkOpts_ssse3.cpp:17:26 in SkOpts::Init_ssse3()
==================
Original issue's description:
> Call SkGraphics::Init for in-process renderer init
>
> Move the call from RendererMain to RenderProcessImpl constructor so it
> is called for both in-process and multi-process. This is important for
> Android WebView to initialize skia correctly.
>
> BUG=525844
>
> Committed: https://crrev.com/1d9e341d0acaf4bdd6c8ccc8ffe1328578aab62d
> Cr-Commit-Position: refs/heads/master@{#347974}
[email protected],[email protected],[email protected]
BUG=525844
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_tsan_rel_ng
Review URL: https://codereview.chromium.org/1332953002
Cr-Commit-Position: refs/heads/master@{#348182}
certificateProvider: Add missing OWNERS file for API folder.
BUG=514575
Review URL: https://codereview.chromium.org/1332833002
Cr-Commit-Position: refs/heads/master@{#348181}
[Sync] Clean up Android IsPassphraseRequiredForDecryption logic.
The logic in this function made it so that we did not prompt for a
passphrase for users that were in the IMPLICIT or FROZEN_IMPLICIT
encryption state with their only the PASSWORD data type being encrypted.
Given the recent change to only prompt a user for a passphrase once per
version, we have decided to remove this exception.
BUG=497518
Review URL: https://codereview.chromium.org/1314333005
Cr-Commit-Position: refs/heads/master@{#348180}
Stop net_unittests from crashing on OpenEntry failures
Even unit tests should avoid crashing, to avoid complicating failures.
This fixes a pair of crashes that were seen when running net_unittests
when built with VS 2015.
[email protected]
BUG=528394
Review URL: https://codereview.chromium.org/1320303008
Cr-Commit-Position: refs/heads/master@{#348179}
[Sync] Clean up PSS boolean getters for consistency.
When cleaning up ProfileSyncServiceAndroid I noticed these inconsistencies
but it seemed like PSS was the one that should be changed, not PSSA.
Renames:
- EncryptEverythingEnabled -> IsEncryptEverythingEnabled
- EncryptEverythingAllowed -> IsEncryptEverythingAllowed
- FirstSetupInProgress -> IsFirstSetupInProgress
- backend_initialized -> IsBackendInitialized
- setup_in_progress -> IsSetupInProgress
BUG=497518
TBR=rogerta,stevenjb,pam,sdefresne
Review URL: https://codereview.chromium.org/1321903005
Cr-Commit-Position: refs/heads/master@{#348178}
[Password Manager] Replaces "this site" in the managed passwords buble.
If domains of the user-visible URL (i.e. the one seen in the omnibox) and the managed passwords origin URL differ, "this site" in the buble's title is replaced with the password domain.
BUG=465681
Review URL: https://codereview.chromium.org/1332803002
Cr-Commit-Position: refs/heads/master@{#348177}
Fix sync compositor root fling
Need to unset need_animate_input_ before calling SynchronouslyAnimate,
since calling SynchronouslyAnimate can set need_animate_input_ again for
the next animation tick.
BUG=530124
R=danakj, jdduke
Review URL: https://codereview.chromium.org/1334773002
Cr-Commit-Position: refs/heads/master@{#348176}
[Android WebView] Fix a couple of typos
Fix a couple of typos in variable names/commentary introduced in:
https://codereview.chromium.org/1315633003/
No functional effect.
BUG=156062
Review URL: https://codereview.chromium.org/1331943002
Cr-Commit-Position: refs/heads/master@{#348175}
Revert of [Android] Don't use a device blacklist if one isn't provided. (RELAND) (patchset #3 id:40001 of https://codereview.chromium.org/1304303006/ )
Reason for revert:
broke the gpu bots again? https://code.google.com/p/chromium/issues/detail?id=530242
Original issue's description:
> [Android] Don't use a device blacklist if one isn't provided. (RELAND)
>
> This is a reland of https://codereview.chromium.org/1314823011
>
> BUG=517709
>
> Committed: https://crrev.com/7555cbb5daf4fb30cb56de9ed4dd8bcd565b5cf6
> Cr-Commit-Position: refs/heads/master@{#348158}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517709
Review URL: https://codereview.chromium.org/1334803002
Cr-Commit-Position: refs/heads/master@{#348174}
Roll src/third_party/WebKit 50770f1:51f611e (svn 202060:202061)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/50770f1..51f611e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334783002
Cr-Commit-Position: refs/heads/master@{#348173}
[Telemetry] Update the ConfindenceInterval calculation in results.html to use
provided std from value.
BUG=516344
Review URL: https://codereview.chromium.org/1309143006
Cr-Commit-Position: refs/heads/master@{#348172}
Remove connection type from PerConnectionDataUsage proto.
For V1 of Data Saver, we will not breakdown data usage by connection
type since this data is not always accurate. We plan to explore this
breakdown for future versions, so keeping the PerConnectionDataUsage
in the schema.
Tests for RecordDataUsage and GetDataUsage in compression stats.
BUG=482442
Review URL: https://codereview.chromium.org/1319873006
Cr-Commit-Position: refs/heads/master@{#348171}
IPC fuzzer: fix a compile failure from refactoring of media::AudioParameters.
Caused by https://crrev.com/2e2f1c71bec505f3ae9d718dd8e875fedd4962e7
[email protected]
Review URL: https://codereview.chromium.org/1335673003
Cr-Commit-Position: refs/heads/master@{#348170}
Make logging of incoming invalidations more verbose.
Currently, when logging an incoming invalidation, the only thing that is logged
is the account, the authority and: android.util.MapCollections$KeySet@...
This CL changes it so it instead logs a debug version of the invalidation, on
the form:
objectSrc:1004,objectId:SESSION,version:1443812489012310,payload(length):50
Compared to toString(), this debug string prints the length of the payload
instead of the whole payload.
In addition, it fixes the log tag for the InvalidationClientService to use the
same as other invalidation-related classes: cr.invalidation.
The current implementation creates a throwaway PendingInvalidation to do the
logging based on the incoming bundle. With a little bit larger change, it could
probably be possible to log this earlier in the process and going from
individual variables to PendingInvalidation and then to a log string and the
Bundle to be used for the sync request. However, this CL hooks in at the same
point as where we currently log what we have.
BUG=529957
Review URL: https://codereview.chromium.org/1331743002
Cr-Commit-Position: refs/heads/master@{#348169}
[tracing] Fix MemoryDumpManager to support startup tracing
This CL simplifies a lot the design of the MemoryDumpManager (MDM)
initialization (\o/). Before this change the MDM had a two-stage
initialization: 1. Initialize() that was registering to the
TraceLog enabled stateobserver; 2. SetDelegate() that was setting
the inversion-of-control delegate.
This design was fragile as it required to think about the two possible
sequences of events (1 -> 2 or 2 -> 1) and not really necessary.
The simplification herein introduced consists in:
- Drop the IsCoordinatorProcess() method from the delegate. That
information is not supposed to change over time and is known
at MDM initialization time.
- Merge the SetDelegate() into the Initialize() call. There is no
point allowing to initialize the MDM without a delegate, so
why bother? Moved all the initialization to the point where the
delegate (concretelly the TracingControllerImpl) is ready.
As a side effect, startup tracing now works properly (tests are
coming in a separate CL).
BUG=524057
TEST=--trace-startup=-*,disabled-by-default-memory-infra --trace-startup-file=/tmp/startup.json
Review URL: https://codereview.chromium.org/1333873002
Cr-Commit-Position: refs/heads/master@{#348168}
Roll src/third_party/WebKit d2c84b4:50770f1 (svn 202059:202060)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d2c84b4..50770f1
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327293002
Cr-Commit-Position: refs/heads/master@{#348167}
Memory-infra: Change "objects_count" to "object_count" in category name.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1334673004
Cr-Commit-Position: refs/heads/master@{#348166}
Roll src/third_party/WebKit 2254064:d2c84b4 (svn 202058:202059)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2254064..d2c84b4
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330373002
Cr-Commit-Position: refs/heads/master@{#348165}
Roll src/third_party/WebKit d3a4736:2254064 (svn 202057:202058)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d3a4736..2254064
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329343003
Cr-Commit-Position: refs/heads/master@{#348164}
Roll pdfium 4ea0e6b:0d0935d
0d0935d Fix JS_GetArrayElement to not return an empty handle on success
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1327253002
Cr-Commit-Position: refs/heads/master@{#348163}
Suppress flaky oes_element_index_uint failures on Linux NVIDIA.
Please remove this suppression once the underlying bug is fixed.
BUG=524144
[email protected],[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/1304203013
Cr-Commit-Position: refs/heads/master@{#348162}
Roll src/third_party/skia cb1ccfd:059dffa
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cb1ccfd..059dffa
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
059dffa [email protected] There's a set probability that a linear pipeline of random procs will be created (old behavior), or a pipeline with a single proc tree (added behavior).
ce79a3a [email protected] Initialize subrun variables to make Valgrind happy
32ab260 [email protected] Revert of Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessin… (patchset #1 id:1 of https://codereview.chromium.org/1329313002/ )
eb662bc [email protected] Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessing the same GrContext to read back GPU input data
Review URL: https://codereview.chromium.org/1336593002
Cr-Commit-Position: refs/heads/master@{#348161}
Roll src/breakpad/src 00915090d..027db3c04
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/00915090d0511189d2d41818cbf617e7cc1426f9..027db3c04fbea96f3efa8e1f722ffff11b19a085
027db3c Fix regression on x86 for "Fix compile error with Windows clang"
dda35d5 The "CPU architecture" field is being filled from the wrong part of
c942aa4 Add check for Linux minidump ending on bad write for exploitability rating.
5d35c17 Don't use strtok_s for mingw builds
BUG=
Review URL: https://codereview.chromium.org/1334693002
Cr-Commit-Position: refs/heads/master@{#348160}
Roll WebRTC 9914:9918, Libjingle 9914:9915
WebRTC 9914:9918
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/49d8ddc..8f226a6
Libjingle 9914:9915
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d5605f8..f150b27
TBR=
BUG=
Review URL: https://codereview.chromium.org/1337473002
Cr-Commit-Position: refs/heads/master@{#348159}
[Android] Don't use a device blacklist if one isn't provided. (RELAND)
This is a reland of https://codereview.chromium.org/1314823011
BUG=517709
Review URL: https://codereview.chromium.org/1304303006
Cr-Commit-Position: refs/heads/master@{#348158}
Roll src/third_party/WebKit 2f4214f:d3a4736 (svn 202056:202057)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2f4214f..d3a4736
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331163002
Cr-Commit-Position: refs/heads/master@{#348157}
Ensure that data is not overwritten in the audio input shared memory ring buffer that sits on the browser/renderer boundary.
This is for "low-latency" audio input streams only.
* The reading side (renderer) signals back to the writing side over the socket that it has read a buffer.
* The writing side receives the verifications and checks that there is room in the ring buffer before writing so that no data is overwritten.
* If the ring buffer is full, log error and drop the data.
* Report UMA stats of how many drops we had when the audio input stream is destroyed.
* Make SyncSocket::Peek virtual to be able to override in test mocks.
* Some refactoring of AudioInputSyncWriter to be able to test it.
* Add a new unit test for AudioInputSyncWriter.
BUG=523224
NOTRY=true
Review URL: https://codereview.chromium.org/1302423006
Cr-Commit-Position: refs/heads/master@{#348156}
Temporarily disabling WebRTC 720p video quality test on Windows.
[email protected]
BUG=webrtc:4986
Review URL: https://codereview.chromium.org/1335653002
Cr-Commit-Position: refs/heads/master@{#348155}
Roll src/third_party/WebKit a8a2047:2f4214f (svn 202055:202056)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a8a2047..2f4214f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337493002
Cr-Commit-Position: refs/heads/master@{#348154}
Roll src/third_party/WebKit 98fd289:a8a2047 (svn 202054:202055)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/98fd289..a8a2047
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331133002
Cr-Commit-Position: refs/heads/master@{#348153}
[Android] Fix low-battery blacklisting in device_status_check.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1337463002
Cr-Commit-Position: refs/heads/master@{#348152}
Roll src/third_party/WebKit 1137919:98fd289 (svn 202052:202054)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1137919..98fd289
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1337483002
Cr-Commit-Position: refs/heads/master@{#348151}
MIPS: Add MAP_STACK definition for MIPS
Eventhough nonsfi is not yet supported for MIPS
this definition is needed to compile Chromium
with enabled native client.
TEST=Build Chromium with enabled native client using clang.
BUG=130022
Review URL: https://codereview.chromium.org/1318193004
Cr-Commit-Position: refs/heads/master@{#348150}
[Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket
This CL adds blink_perf.pywebsocket, in which
- Pywebsocket server is started at localhost:8001, and
- Browser option --disable-web-security is added,
because we need cross-origin accesses between
memory_cache_http_server and pywebsocket server.
[1/2] PerformanceTests scripts: https://codereview.chromium.org/738753002/
[2/2] Telemetry: This CL
BUG=432408
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect
Review URL: https://codereview.chromium.org/736653002
Cr-Commit-Position: refs/heads/master@{#348149}
Roll src/third_party/WebKit 4364aba:1137919 (svn 202051:202052)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4364aba..1137919
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332803003
Cr-Commit-Position: refs/heads/master@{#348148}
Hide existing StrictMode violations.
While we work on to resolve these known StrictMode
violations, it's a poor experience for dogfooders to see
these every time they are triggered. It is still
important for developers and dogfooders to see and report
newly introduced violations with the StrictMode red border
flash.
BUG=508615,525781,525785,527415,527429
Review URL: https://codereview.chromium.org/1334533004
Cr-Commit-Position: refs/heads/master@{#348147}
Roll src/third_party/WebKit ef6eb52:4364aba (svn 202050:202051)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef6eb52..4364aba
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331913002
Cr-Commit-Position: refs/heads/master@{#348146}
perf: Update WebGL ad pages
BUG=498160
Review URL: https://codereview.chromium.org/1332783003
Cr-Commit-Position: refs/heads/master@{#348145}
Roll src/third_party/WebKit fd907d5:ef6eb52 (svn 202049:202050)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fd907d5..ef6eb52
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330323002
Cr-Commit-Position: refs/heads/master@{#348144}
Roll src/third_party/WebKit f437389:fd907d5 (svn 202048:202049)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f437389..fd907d5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331833005
Cr-Commit-Position: refs/heads/master@{#348143}
[AndroidWebViewShell] Add MediaStream API layout tests.
Add two layout tests for the MediaStream API (aka getUserMedia).
The tests check correctness of callbacks for the following cases:
- when permissions are denied
- success case (i.e. getUserMedia succeeds).
This patch also adds the 'shouldBe' and related JavaScript
testing primitives and the ability to grant/deny permissions in
tests.
BUG=515926
Review URL: https://codereview.chromium.org/1314033003
Cr-Commit-Position: refs/heads/master@{#348142}
Revert "Revert of Add support for converting I420 software frames into NV12 hardware frames (patchset #6 id:140001 of https://codereview.chromium.org/1307853003/ )"
This reverts commit 9fbd81e3c8adf06f9a77d917050eb99f2cdad3c3.
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524582
Review URL: https://codereview.chromium.org/1332733003
Cr-Commit-Position: refs/heads/master@{#348141}
Revert "Revert of Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities (patchset #3 id:60001 of https://codereview.chromium.org/1325303004/ )"
This reverts commit b03c8d21c492c866080713eec568757e55660d10.
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=508413
Review URL: https://codereview.chromium.org/1336553002
Cr-Commit-Position: refs/heads/master@{#348140}
ServiceWorker: Make WebServiceWorkerRegistration refcounted (1)
This is one of preliminary patches for making APIs (eg. register()) that return
ServiceWorkerRegistration object return the same JS object if it's available.
(1) Chromium: THIS PATCH
(2) Blink: https://codereview.chromium.org/1307733004/
(3) Chromium: https://codereview.chromium.org/1303363007/
(4) Blink: https://codereview.chromium.org/1312703005/
This CL makes ServiceWorkerDispatcher pass a registration object into
WebCallbacks::onSuccess() not as WebPassOwnPtr<WebSWRegistrationImpl> but as
WebPassOwnPtr<WebSWRegistration>.
<Background of this change>
To switch callback interfaces derived from WebCallbacks in the third patch,
the second patch will define overloaded functions as follows...
- WebCallbacksDerived::onSuccess(WebPassOwnPtr<WebSWR>)
- WebCallbacksDerived::onSuccess(WebPassOwnPtr<OtherType>)
With these overloaded functions, a compiler fails the overload resolution[1]
because conversion from WebPassOwnPtr<WebSWRImpl> to WebPassOwnPtr<WebSWR> is
not supported by the machinery of WebPassOwnPtr. To help the compiler to
select an appropriate function, this CL makes the caller of overloaded
functions pass more exact typed object (ie, WebSWRegistration).
[1] http://en.cppreference.com/w/cpp/language/overload_resolution
BUG=523904
Review URL: https://codereview.chromium.org/1318903013
Cr-Commit-Position: refs/heads/master@{#348139}
Roll src/third_party/WebKit aed918b:f437389 (svn 202045:202048)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aed918b..f437389
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331883002
Cr-Commit-Position: refs/heads/master@{#348138}
Permission messages: Move strings from extensions_strings.grd to generated_resources.grd
This CL moves most IDS_EXTENSION_PROMPT_WARNING_* strings out of extensions_strings.grd. A few have to remain for now, see TODO in extensions/common/permissions/permission_message_util.cc.
Also wraps the strings into an
<if expr="enable_extensions">
so they won't be included when we don't have extensions (e.g. on Android).
BUG=None
Review URL: https://codereview.chromium.org/1321363002
Cr-Commit-Position: refs/heads/master@{#348137}
Move Singleton and related structs to namespace base
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
[email protected]
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
[iOS] Upstream cookie utils
Review URL: https://codereview.chromium.org/1329403002
Cr-Commit-Position: refs/heads/master@{#348135}
Roll src/third_party/WebKit ad3a191:aed918b (svn 202044:202045)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ad3a191..aed918b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331863002
Cr-Commit-Position: refs/heads/master@{#348134}
Perform password import from Keychain in the muted mode.
This will decrese the amount of times the Keychain prompt is shown to the user.
BUG=514838
Review URL: https://codereview.chromium.org/1330293002
Cr-Commit-Position: refs/heads/master@{#348133}
Rename avatar_url to icon_url in LoginDatabase.
BUG=505445
Review URL: https://codereview.chromium.org/1328743006
Cr-Commit-Position: refs/heads/master@{#348132}
permissions: Remove origin from permission_request_id
It is not needed and moreover, it makes life difficult for
introduction of multiple permissions. The comment about
uniqueness being based on origin is no longer relevant so
can be removed.
BUG=516626
Review URL: https://codereview.chromium.org/1325923003
Cr-Commit-Position: refs/heads/master@{#348131}
AccessibilityManager must be deleted after ash Shell, but before InputMethodManager.
session_state_observer_ needs to be deleted before the Shell goes away, so we do it in OnAppTerminating.
BUG=chromium:515097
Review URL: https://codereview.chromium.org/1316793004
Cr-Commit-Position: refs/heads/master@{#348130}
Roll WebRTC 9890:9914, Libjingle 9885:9914
WebRTC 9890:9914
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/e3f2eba..49d8ddc
Libjingle 9885:9914
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/531209a..d5605f8
TBR=
BUG=
Review URL: https://codereview.chromium.org/1335523002
Cr-Commit-Position: refs/heads/master@{#348129}
Roll src/third_party/WebKit 6118797:ad3a191 (svn 202043:202044)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6118797..ad3a191
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335573002
Cr-Commit-Position: refs/heads/master@{#348128}
ServiceWorker: Fix outdated TRACE_EVENT name
ServiceWorkerScriptContext was merged into ServiceWorkerContextClient by
https://codereview.chromium.org/1136323003
BUG=n/a
Review URL: https://codereview.chromium.org/1332793002
Cr-Commit-Position: refs/heads/master@{#348127}
Removed archived history file deletion on browser start
Remove delete of archived history file on browser start.
Archived history file usage was removed since M37.
BUG=359377
[email protected]
Review URL: https://codereview.chromium.org/1311403011
Cr-Commit-Position: refs/heads/master@{#348126}
Roll src/third_party/WebKit bc0bcd9:6118797 (svn 202042:202043)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bc0bcd9..6118797
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331023004
Cr-Commit-Position: refs/heads/master@{#348125}
Files.app: Update drive sync error message to avoid confusion.
"Please try again later." doesn't make sense, as there is no explicit way to try sync again by the user.
BUG=523401
TEST=manually
Review URL: https://codereview.chromium.org/1335513002
Cr-Commit-Position: refs/heads/master@{#348124}
Roll src/third_party/WebKit 1fb83d7:bc0bcd9 (svn 202040:202042)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fb83d7..bc0bcd9
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329423002
Cr-Commit-Position: refs/heads/master@{#348123}
Roll src/third_party/WebKit 3acf2aa:1fb83d7 (svn 202039:202040)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3acf2aa..1fb83d7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335533002
Cr-Commit-Position: refs/heads/master@{#348122}
Roll src/third_party/WebKit 57a913f:3acf2aa (svn 202038:202039)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/57a913f..3acf2aa
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331823002
Cr-Commit-Position: refs/heads/master@{#348121}
Revert of Add support for converting I420 software frames into NV12 hardware frames (patchset #6 id:140001 of https://codereview.chromium.org/1307853003/ )
Reason for revert:
We suspect this CL caused a WebRTC browser test to start failing.
The failures are consistent and started here:
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21330
Original issue's description:
> Add support for converting I420 software frames into NV12 hardware frames
>
> Enhance MaybeCreateHardwareFrame() to be able to create a NV12 hardware
> frame backed by a YUV_420_BIPLANAR GpuMemoryBuffer.
>
> This code path is not enabled yet.
>
> BUG=524582
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/422d099ed5b8439b92d198deb84d4528c14ccc0c
> Cr-Commit-Position: refs/heads/master@{#347864}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524582
Review URL: https://codereview.chromium.org/1327243002
Cr-Commit-Position: refs/heads/master@{#348120}
Roll PDFium 640c395..4ea0e6b
https://pdfium.googlesource.com/pdfium.git/+log/640c395..4ea0e6b
BUG=507316,529310
[email protected]
Review URL: https://codereview.chromium.org/1335493002
Cr-Commit-Position: refs/heads/master@{#348119}
Files.app: add cut operation to context menu of directory tree.
BUG=502171
TEST=browser_tests:DirectoryTreeContextMenu/FileManagerBrowserTest.Test/*
Review URL: https://codereview.chromium.org/1331013002
Cr-Commit-Position: refs/heads/master@{#348118}
Roll src/third_party/WebKit 9470039:57a913f (svn 202037:202038)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9470039..57a913f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334663002
Cr-Commit-Position: refs/heads/master@{#348117}
Roll src/third_party/WebKit 4a6816a:9470039 (svn 202036:202037)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a6816a..9470039
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333803002
Cr-Commit-Position: refs/heads/master@{#348116}
Change fallback ninja output_dir detection to test dirs matching out*/.
BUG=
Review URL: https://codereview.chromium.org/1326333002
Cr-Commit-Position: refs/heads/master@{#348115}
Roll src/third_party/WebKit 2d8e13f:4a6816a (svn 202035:202036)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2d8e13f..4a6816a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331023003
Cr-Commit-Position: refs/heads/master@{#348114}
Make gyp_flag_compare.py work on Windows
BUG=
Review URL: https://codereview.chromium.org/1319063004
Cr-Commit-Position: refs/heads/master@{#348113}
Roll src/third_party/WebKit f7a9d5b:2d8e13f (svn 202034:202035)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f7a9d5b..2d8e13f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332763002
Cr-Commit-Position: refs/heads/master@{#348112}
Automated Commit: Committing new LKGM version 7442.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#348111}
Roll src/third_party/WebKit 43f8946:f7a9d5b (svn 202033:202034)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/43f8946..f7a9d5b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336513002
Cr-Commit-Position: refs/heads/master@{#348110}
Roll src/third_party/WebKit aab3169:43f8946 (svn 202031:202033)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aab3169..43f8946
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331023002
Cr-Commit-Position: refs/heads/master@{#348109}
ServiceWorker: Clarify the relationship among ServiceWorkerRegistration and its derivatives
To clarify the relationship among ServiceWorkerRegistration and its derivatives,
this CL adds implementation comments.
BUG=n/a
Review URL: https://codereview.chromium.org/1306683006
Cr-Commit-Position: refs/heads/master@{#348108}
Remove use of JSONReader::DeprecatedRead from chrome/browser
Remove use of deprecated function DeprecatedRead from chrome/browser
BUG=523194
Review URL: https://codereview.chromium.org/1311773012
Cr-Commit-Position: refs/heads/master@{#348107}
Roll src/third_party/WebKit c8f1b7f:aab3169 (svn 202030:202031)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c8f1b7f..aab3169
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329373002
Cr-Commit-Position: refs/heads/master@{#348106}
Remove an unnecessary qualifier.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1315643010
Cr-Commit-Position: refs/heads/master@{#348105}
Roll src/third_party/WebKit f9e4789:c8f1b7f (svn 202029:202030)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f9e4789..c8f1b7f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333783002
Cr-Commit-Position: refs/heads/master@{#348104}
Ramove use of JSONReader::DeprecatedRead from chromeos/
Remove use of deprecated function DeprecatedRead from chromeos/
BUG=523194
Review URL: https://codereview.chromium.org/1328233002
Cr-Commit-Position: refs/heads/master@{#348103}
Update V8 to version 4.7.42.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/269aeca5..3d683bfc
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336473002
Cr-Commit-Position: refs/heads/master@{#348102}
Roll src/third_party/WebKit 938bf33:f9e4789 (svn 202028:202029)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/938bf33..f9e4789
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332733002
Cr-Commit-Position: refs/heads/master@{#348101}
MD Downloads: reduce <paper-item> height in overflow menu
Based on bettes@' feedback
[email protected]
BUG=425626
Review URL: https://codereview.chromium.org/1333763002
Cr-Commit-Position: refs/heads/master@{#348100}
Introduce TabRestoreServiceClient and //chrome implementation.
Core tab restore code from //chrome/browser/sessions is targeted for
componentization in order to cleanly integrate with iOS. To achieve this goal,
the code needs to be cleaned of //content and //chrome dependencies. This CL
introduces the TabRestoreServiceClient interface, which is an abstraction of
Profile for usage within the core tab restore code. It also adds initial usage
of this interface to eliminate knowledge of //chrome-level factories and the
//chrome-level SessionService from PersistentTabRestoreService. Finally, it
moves the //chrome-level static functions for creating a TabRestoreService out
of the classes to be componentized and into TabRestoreServiceFactory.
BUG=528883
Review URL: https://codereview.chromium.org/1319473014
Cr-Commit-Position: refs/heads/master@{#348099}
Reland "Make blimp/common:blimp_common compile for Linux."
This reverts commit 7d445bc580b1de93263235d16a28731cc54b8916.
In addition to the compilation fix, it fixes the following GN issues:
- Moves blimp_apk from 'both_gn_and_gyp' group to 'gn_only'.
- Adds a top-level blimp GN group.
- Ensures //blimp is built on linux.
The previous CL landed after: https://codereview.chromium.org/1314353005
which made it break the build.
Original review: https://codereview.chromium.org/1329323002/
(also same as patch set 1)
Revert review: https://codereview.chromium.org/1331773002
BUG=None
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330223002
Cr-Commit-Position: refs/heads/master@{#348098}
Fill in mic_positions property.
BUG=451188
Review URL: https://codereview.chromium.org/1320923005
Cr-Commit-Position: refs/heads/master@{#348097}
Add VS Debug Visualizer for layout and font classes
This patch adds major layout and font classes to Visual Studio Debug
Visualizer, specifically:
* LayoutObject shows its corresponding node.
* InlineBox, BidiRun, and LineLayoutItem shows its corresponding
LayoutObject.
* TextRun shows its text.
* SimpleFontData and FontPlatformData shows family name and size.
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1331793002
Cr-Commit-Position: refs/heads/master@{#348096}
Roll src/third_party/WebKit ff80234:938bf33 (svn 202027:202028)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ff80234..938bf33
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332713002
Cr-Commit-Position: refs/heads/master@{#348095}
Roll src/third_party/WebKit d39d5df:ff80234 (svn 202026:202027)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d39d5df..ff80234
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1335473002
Cr-Commit-Position: refs/heads/master@{#348094}
Roll src/third_party/WebKit 072dc76:d39d5df (svn 202023:202026)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/072dc76..d39d5df
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336483002
Cr-Commit-Position: refs/heads/master@{#348093}
roll libyuv r1480 to r1481 for sanitizer.gni import in the GN build.
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/1315093004
Cr-Commit-Position: refs/heads/master@{#348092}
Add a flag to enable testing of WebUSB by bypassing the permssions UI.
The permissions UI for WebUSB is not yet implemented. This flag bypasses
the need for a site to call navigator.usb.requestDevice to prompt the
user for access to USB device before calling navigator.usb.getDevices.
As such it is a Bad Flag(TM) but the risk is still rather low because
the device is still required to have a set of WebUSB descriptors
granting the site's origin access.
BUG=529950
Review URL: https://codereview.chromium.org/1333703002
Cr-Commit-Position: refs/heads/master@{#348091}
Roll src/third_party/WebKit cfe2a8d:072dc76 (svn 202022:202023)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cfe2a8d..072dc76
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334633002
Cr-Commit-Position: refs/heads/master@{#348090}
Revert of Make blimp/common:blimp_common compile for Linux. (patchset #3 id:40001 of https://codereview.chromium.org/1329323002/ )
Reason for revert:
Broke Linux GN build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/5564/steps/compile/logs/stdio
FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/blimp/common/blimp_common/blimp_layer_tree_settings.o.d -DBLIMP_COMMON_IMPLEMENTATION=1 -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=245965-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGL_GLEXT_PROTOTYPES -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DMESA_EGL_NO_X11_HEADERS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/mesa/src/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -m64 -march=x86-64 -funwind-tables -fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -Wno-shift-negative-value -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O2 -fno-ident -fdata-sections -ffunction-sections -g0 -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../blimp/common/compositor/blimp_layer_tree_settings.cc -o obj/blimp/common/blimp_common/blimp_layer_tree_settings.o
../../blimp/common/compositor/blimp_layer_tree_settings.cc:140:13: error: no member named 'gather_pixel_refs' in 'cc::LayerTreeSettings'
settings->gather_pixel_refs = false;
~~~~~~~~ ^
../../blimp/common/compositor/blimp_layer_tree_settings.cc:145:15: error: no member named 'gather_pixel_refs' in 'cc::LayerTreeSettings'
settings->gather_pixel_refs = num_raster_threads > 1;
~~~~~~~~ ^
2 errors generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> Make blimp/common:blimp_common compile for Linux.
>
> In addition to the compilation fix, it fixes the following GN issues:
> - Moves blimp_apk from 'both_gn_and_gyp' group to 'gn_only'.
> - Adds a top-level blimp GN group.
> - Ensures //blimp is built on linux.
>
> BUG=None
>
> Committed: https://crrev.com/6aeec514d33506a479fac1e5e1c7fe49927b5f81
> Cr-Commit-Position: refs/heads/master@{#348086}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1331773002
Cr-Commit-Position: refs/heads/master@{#348089}
Roll src/third_party/WebKit 3d781c7:cfe2a8d (svn 202020:202022)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d781c7..cfe2a8d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1336453002
Cr-Commit-Position: refs/heads/master@{#348088}
Chromecast: Checks if default codec type is supported
This is a temporary solution to unblock cast built from chromium
upstream to check if default codec type is supported if OEM shared
library implementation returns MediaCodecSupportShlib::kDefault.
This can be reverted once the code is able to wire to chrome media
MimeUtil component.
BUB= b/22465408
Review URL: https://codereview.chromium.org/1329333002
Cr-Commit-Position: refs/heads/master@{#348087}
Make blimp/common:blimp_common compile for Linux.
In addition to the compilation fix, it fixes the following GN issues:
- Moves blimp_apk from 'both_gn_and_gyp' group to 'gn_only'.
- Adds a top-level blimp GN group.
- Ensures //blimp is built on linux.
BUG=None
Review URL: https://codereview.chromium.org/1329323002
Cr-Commit-Position: refs/heads/master@{#348086}
Fix android build.
This regressed in #347962.
TEST=Build clank with enable_plugins=1.
BUG=None.
Review URL: https://codereview.chromium.org/1305413008
Cr-Commit-Position: refs/heads/master@{#348085}
Roll src/third_party/WebKit 9b47923:3d781c7 (svn 202018:202020)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b47923..3d781c7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1334623002
Cr-Commit-Position: refs/heads/master@{#348084}
Disallows connections from embedding into their root
Doing so implicitly severs their connection with the
viewmanager. Additionally it seems as though only the owner of the
view (or the embed root) should be able to embed.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1308553008
Cr-Commit-Position: refs/heads/master@{#348083}
Use IOMessageLoop in a SyncFileSystem test
CFI check detects a bad downcast for this.
BUG=520732
Review URL: https://codereview.chromium.org/1311673017
Cr-Commit-Position: refs/heads/master@{#348082}
Updating trunk VERSION from 2506.0 to 2507.0
Cr-Commit-Position: refs/heads/master@{#348081}
[Chromecast] Add cast_version_header dependency from CastSysInfoAndroid.
CastSysInfoAndroid uses version.h, which is a build-time race.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/1329303003
Cr-Commit-Position: refs/heads/master@{#348080}
Roll src/third_party/WebKit 093961d:9b47923 (svn 202017:202018)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/093961d..9b47923
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333743002
Cr-Commit-Position: refs/heads/master@{#348079}
Suppress flaky glsl_construct_vec_mat_index failures on Windows.
These are blocking valid CQ jobs. Please remove this suppression once
the underlying bug has been fixed.
BUG=525188
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333623004
Cr-Commit-Position: refs/heads/master@{#348078}
[Cleanup] Fix incorrect histogram enum numbering for the extensions events histogram.
This fixes a typo from https://codereview.chromium.org/1274753006/
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1333713002
Cr-Commit-Position: refs/heads/master@{#348077}
Roll src/third_party/skia 7628967:cb1ccfd
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7628967..cb1ccfd
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
cb1ccfd [email protected] SK_API on GrWrapTextureInBitmap
8e74046 [email protected] Remove race.
25507d9 [email protected] fix leaked picture
9583ab9 [email protected] don't peek w/o first acquiring the lock
6651a32 [email protected] Reland of more zero-length changes for svg compatibility (patchset #1 id:1 of https://codereview.chromium.org/1334543002/ )
809e5af [email protected] Brian requested a new namespace for factories that create fragment processors that combine 2 things with a xfermode. This way, we can change the implementation of these factories in the future to not use GrComposeEffect if desired.
bf29888 [email protected] Parallel cache.
Review URL: https://codereview.chromium.org/1333713004
Cr-Commit-Position: refs/heads/master@{#348076}
Revert of Expose distiller functions to JavaScript (patchset #14 id:260001 of https://codereview.chromium.org/1231083007/ )
Reason for revert:
Broke GN compile
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/9325
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/12931
[569/575] LINK(DLL) chrome.dll chrome.dll.lib
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp
content_renderer.lib(distiller_native_javascript.obj) : error LNK2005: "public: static class v8::Object * __cdecl v8::Object::Cast(class v8::Value *)" (?Cast@Object@v8@@SAPAV12@PAVValue@2@@Z) already defined in v8.dll.lib(v8.dll)
Original issue's description:
> Expose distiller functions to JavaScript
>
> This change adds two mojo services; one for notifying a RenderFrame
> that it is working on a distiller page and one for allowing distiller
> JavaScript functions to access the browser. This CL only exposes a
> single function "distiller.echo".
>
> BUG=
>
> Committed: https://crrev.com/c5fc07ec3016dc3fb0d58c6869f1fc9bedb8b3a7
> Cr-Commit-Position: refs/heads/master@{#347951}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1336433002
Cr-Commit-Position: refs/heads/master@{#348075}
Remove CONTENT_SETTINGS_NUM_TYPES (part 3)
To make it possible to make ContentSettingsTypes no longer an enum we need to
remove the occurrences of iterations over it. This CL removes occurences from
content_settings_handler.cc and does some cleanup. Rather than iterating over
ContentSettingsType, we instead create a list of content settings types that
have exceptions and iterate over this. This is more scalable and easier to
understand because exceptions may not be relevant for many ContentSettingsTypes.
BUG=526932
Review URL: https://codereview.chromium.org/1323953005
Cr-Commit-Position: refs/heads/master@{#348074}
Simulate turning on PluginPowerSaver via Finch
[email protected]
BUG=478918
Review URL: https://codereview.chromium.org/1301373006
Cr-Commit-Position: refs/heads/master@{#348073}
Specify sa_restorer on x86-32.
BUG=527209
Review URL: https://codereview.chromium.org/1306113006
Cr-Commit-Position: refs/heads/master@{#348072}
DevTools: only stop tracing on f/e detach if front-end has started tracing (again)
This effectively reverts 3e551c642d784011a9bbfc655116451147b76674 an re-lands
https://codereview.chromium.org/1222943002/ as the origianl CL was wrongly
identified as the culprit of "Tracing is not started" bug fixed by
https://codereview.chromium.org/1314783010/
Drive-by: remove unused protocol compatibility override.
BUG=507670
Review URL: https://codereview.chromium.org/1321133004
Cr-Commit-Position: refs/heads/master@{#348071}
Roll src/third_party/WebKit a2f2e15d:093961d (svn 202015:202017)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a2f2e15d..093961d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325233006
Cr-Commit-Position: refs/heads/master@{#348070}
Android Chromoting: Fix color problem.
BUG=516871
Review URL: https://codereview.chromium.org/1326383003
Cr-Commit-Position: refs/heads/master@{#348069}
Roll src/third_party/WebKit cc8fa7d:a2f2e15d (svn 202014:202015)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cc8fa7d..a2f2e15d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333733002
Cr-Commit-Position: refs/heads/master@{#348068}
MD Downloads: compute description and tag via data binding
[email protected]
BUG=526577
Review URL: https://codereview.chromium.org/1303993006
Cr-Commit-Position: refs/heads/master@{#348067}
Address various problems with large Intents
* Add utility functions for determining how big an Intent is and whether
it's probably too big to pass to Android.
* Combine the IntentHandler and ExternalNavigationDelegateImpl's
implementations of willChromeHandleIntent.
* Document Intents will no longer pass the URL in the Intent itself if the
Intent it deemed too large. Instead, it does what Incognito tabs do and
passes the URL in the AsyncTabCreationParams. This means that these
can't be retargeted by home page shortcuts, but the number of users who
would notice is trivially tiny. Added a unit test to check.
* AsyncDocumentLauncher now checks to see if an Activity couldn't be
launched and continues its launching pipeline if it encounters one.
BUG=526238
TEST=DocumentModeTest.testBehemothUrlWindowOpen
Review URL: https://codereview.chromium.org/1327983002
Cr-Commit-Position: refs/heads/master@{#348066}
Roll src/third_party/WebKit 7a2b3de:cc8fa7d (svn 202013:202014)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7a2b3de..cc8fa7d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1303103009
Cr-Commit-Position: refs/heads/master@{#348065}
Roll ffmpeg deps.
Two changes, GN build-related only. These should both be NOPS from a behavior standpoint, they just enable some new structuring of the build in followup patches.
c529ed4e Support new GN symbol and optimization configs.
6f7f37e8 Move configs out of targets in GN build files.
[email protected]
Review URL: https://codereview.chromium.org/1330543003
Cr-Commit-Position: refs/heads/master@{#348064}
input: Avoid a round trip for OnRootLayerDelegatedScrollOffsetChanged.
Currently the SynchronousCompositorImpl knows the offset changed, so
it calles the InputHandler (LayerTreeHostImpl) which calls the
LayerTreeImpl. Then LayerTreeImpl needs to know the offset, so it calls
back to the SynchronousCompositorImpl through the
LayerScrollOffsetDelegate.
Just pass the offset to OnRootLayerDelegatedScrollOffsetChanged to
make this simpler and avoid the anti-pattern of having class A call
class B just to have class B get data from class A.
R=boliu, jdduke
BUG=522658
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1334573002
Cr-Commit-Position: refs/heads/master@{#348063}
Rebase for https://codereview.chromium.org/1310883012/
BUG=526748
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325603010
Cr-Commit-Position: refs/heads/master@{#348062}
PDF: Strip whitespace when determining whether a PDF's title is empty.
Currently, if a PDF title contains only whitespace, that
whitespace-only title is displayed in the UI instead of the last path
component. With this change, a title containing only whitespace is
ignored just as an empty title is.
BUG=527309
Review URL: https://codereview.chromium.org/1316873006
Cr-Commit-Position: refs/heads/master@{#348061}
Roll src/third_party/WebKit 2e27212:7a2b3de (svn 202012:202013)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2e27212..7a2b3de
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1305413007
Cr-Commit-Position: refs/heads/master@{#348060}
Pepper: Detach PPB_AudioShared thread state when joining thread.
Since we drop the proxy lock when we join the thread, move relevant thread state from the PPB_AudioShared instance so any plugin calls won't be able to access the joined thread.
BUG=527759
Review URL: https://codereview.chromium.org/1325343004
Cr-Commit-Position: refs/heads/master@{#348059}
Android Chromoting: Add disconnectFromHost when back keyboard is invoked.
BUG=516871
Review URL: https://codereview.chromium.org/1328203004
Cr-Commit-Position: refs/heads/master@{#348058}
[Extensions UI Mac] Fix resizing logic when highlighting the actions container
The logic here was inverted - resizing should be allowed only if not resizing.
BUG=529955
Review URL: https://codereview.chromium.org/1321223004
Cr-Commit-Position: refs/heads/master@{#348057}
Android Chromoting: Replace eye point with cursor.
BUG=516871
Review URL: https://codereview.chromium.org/1310513011
Cr-Commit-Position: refs/heads/master@{#348056}
Roll ANGLE e6432c8..54c311f
https://chromium.googlesource.com/angle/angle.git/+log/e6432c8..54c311f
BUG=
TEST=bots
NOTRY=true
Review URL: https://codereview.chromium.org/1325603009
Cr-Commit-Position: refs/heads/master@{#348055}
content: Remove an implicit assumption of resource_dispatcher.cc.
The implementation of ResourceDispatcher::OnMessageReceived() assumed that a
call to FlushDeferredMessages(request_id) would not invalidate the iterator
obtained from GetPendingRequestInfo(request_id). As far as I can tell, this
assumption relies on implicit behavior of consumers of ResourceDispatcher. I've
removed this assumption by adding a second call to
GetPendingRequestInfo(request_id) following the call to
FlushDeferredMessages(request_id).
BUG=527588
Review URL: https://codereview.chromium.org/1306283007
Cr-Commit-Position: refs/heads/master@{#348054}
html_viewer/web_view: An app for running layout-tests.
The standalone app (layout_test_runner) can be used as a driver with the
run-webkit-tests script in blink to run the layout tests. A brief explanation
of how it works:
. The app launches mojo:web_view_test_runner.
. In system-check mode, the mojo:web_view_test_runner app terminates when the
view-tree host comes up successfully, instead of loading any pages.
. LayoutTestHTMLViewer installs a callback on WebTestInterfaces to run a callback
when the test stops running.
. When a test stops running, LayoutTestHTMLViewer notifies the
mojo:web_view_test_runner app about it through the LayoutTestRunner interface.
Command:
./third_party/WebKit/Tools/Scripts/run-webkit-tests \
--driver-name=layout_test_runner \
--additional-driver-flag=--content-handlers=text/html,mojo:layout_test_html_viewer \
--debug \
--target=Debug_gn \
fast/events/touch/create-touch-event.html
Only text-only tests are supported right now. Pixel/audio output are yet to be
done. Some stats:
. fast/dom: 1434 passes out of 1963 tests.
. fast/events: 449 passes out of 738 tests.
. fast/events/touch: 99 passes out of 131 tests.
BUG=478250
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1308973005 .
Cr-Commit-Position: refs/heads/master@{#348053}
Roll src/third_party/WebKit 1b4a5ed:2e27212 (svn 202010:202012)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1b4a5ed..2e27212
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331463005
Cr-Commit-Position: refs/heads/master@{#348052}
cc: Delete SidecarListContainer.
Using its features to support Blink display item lists is not longer part of the
plan of record.
BUG=529859
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1319973013
Cr-Commit-Position: refs/heads/master@{#348051}
Undo scroll snap on to_parent at the start of new frame.
We need to undo the scroll snap baked into to_parent from the
previous frame as we need the unsnapped to_parent to calculate
the current frame screen space and draw transforms.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1331453002
Cr-Commit-Position: refs/heads/master@{#348050}
DevTools: preserve DevTools window when remote connection is lost, but close the agent host.
BUG=456547
Review URL: https://codereview.chromium.org/1308553006
Cr-Commit-Position: refs/heads/master@{#348049}
Roll src/third_party/WebKit 4aace46:1b4a5ed (svn 202009:202010)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4aace46..1b4a5ed
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319293005
Cr-Commit-Position: refs/heads/master@{#348048}
Move tab hit-test mask computation into tab.cc.
This was the only file calling this function, and defining it as a member will
be useful in upcoming Material Design changes.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1315563005
Cr-Commit-Position: refs/heads/master@{#348047}
Wrapped the standard window buttons in a custom view so that they
will draw the icons when the mouse hovers over them.
BUG=496688
Review URL: https://codereview.chromium.org/1306163006
Cr-Commit-Position: refs/heads/master@{#348046}
Move security error resources into security_interstitials component
BUG=488673
Review URL: https://codereview.chromium.org/1329903002
Cr-Commit-Position: refs/heads/master@{#348045}
Fix an issue that there is no app to handle ACTION_VIEW_DOWNLOADS
BUG=529346
Review URL: https://codereview.chromium.org/1327063004
Cr-Commit-Position: refs/heads/master@{#348044}
Add null check in WebExternalBitmapImpl::pixels.
This should work around problems with zero-sized canvases.
BUG=520417
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1325783008
Cr-Commit-Position: refs/heads/master@{#348043}
Reset webusb detector before browser client.
This patch modified code to reset webusb detector before browser
client, and added explicit keyword to WebUsbDetector constructor.
BUG=492204
Review URL: https://codereview.chromium.org/1332663002
Cr-Commit-Position: refs/heads/master@{#348042}
Re-enable the java tests for Android
BUG=chromedriver:441,chromedriver:526,chromedriver:527,chromedriver:998
Review URL: https://codereview.chromium.org/1311303005
Cr-Commit-Position: refs/heads/master@{#348041}
MD Downloads: compute content classes via data binding
Also use dom-if to remove a bunch of dangerous nodes
BUG=526577
[email protected]
Review URL: https://codereview.chromium.org/1305063012
Cr-Commit-Position: refs/heads/master@{#348040}
[Courgette] Store delta encoding as signed int32.
Owing to AdjustmentMethod permuting Rel32Address items, difference of
successive items may be negative. Previously Courgette stores deltas
vectors using uint32, so negative values can take 5 bytes each.
This CL changes storage of deltas vectors to signed int32. Experiment
(goo.gl/vvVADx) shows total diff file reduction of ~3%, and zipped
diff file reduction of ~1.5%.
We apply the same change for Abs32Address items for consistency.
Review URL: https://codereview.chromium.org/1328703002
Cr-Commit-Position: refs/heads/master@{#348039}
Suppress oes_texture_half_float_with_video test failure on Retina bots.
This WebGL conformance test is failing intermittently, kicking valid try
jobs out of the CQ. Please remove this suppression once the bug is
fixed.
BUG=524717
Review URL: https://codereview.chromium.org/1311393011
Cr-Commit-Position: refs/heads/master@{#348038}
MediaRecorderHandler (video part) and unittests
MediaRecorderHandler is Blink-orchestrated class implementing
MediaRecorder API (see below). It plugs together an existing
MediaStreamVideoTrack to a new VideoTrackRecorder-WebmMuxer
pair. When MSVTrack passes frames, these get encoded, muxed,
and the result is sent to Blink.
A *note on threading*: As is customary in MediaStream* and
derived classes, all configuration happens on Main Render thread
while frame manipulation and forwarding happens on Render IO
thread [1]. Moreover, all objects can be, and often are, destroyed in
asynchronous and unexpected ways from Blink. This forces
ref-counting for VideoTrackRecorder::VpxEncoder. This is the
also the reason behind the change in WebmMuxer to 2-threaded.
See DD @ https://goo.gl/vSjzC5 (*) for the plan.
(*) Used to be https://goo.gl/kreaQj
[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/media/media_stream_video_track.cc&sq=package:chromium&type=cs&l=155&rcl=1440530828
BUG=262211
Review URL: https://codereview.chromium.org/1313603004
Cr-Commit-Position: refs/heads/master@{#348037}
Roll src/third_party/WebKit 6c137a7:4aace46 (svn 202008:202009)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6c137a7..4aace46
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325893004
Cr-Commit-Position: refs/heads/master@{#348036}
Sync: Remove NonBlockingDataTypeManager and any ProfileSyncService code related to it.
This is cleanup of the code specific to NonBlockingDataTypeManager
that shouldn't be needed anymore with the new implementation
based on DataTypeManager shared between the regular datatypes
and USS datatypes.
Please note that there currently no unit tests for
NonBlockingDataTypeManager and no tests for the methods
removed from ProfileSyncService. There are unit tests for
NonBlockingDataTypeController that use the class directly
without the manager.
NonBlockingDataTypeController remains unchanged for now.
I'll change it in a separate change.
BUG=515962
Review URL: https://codereview.chromium.org/1315063008
Cr-Commit-Position: refs/heads/master@{#348035}
Roll src/third_party/WebKit b4168eb:6c137a7 (svn 202006:202008)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b4168eb..6c137a7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1320673015
Cr-Commit-Position: refs/heads/master@{#348034}
Refactor password bubble experiment unittests.
[email protected]
BUG=527702
Review URL: https://codereview.chromium.org/1328163002
Cr-Commit-Position: refs/heads/master@{#348033}
[Chromecast] Moves remote debugging start decision into CastContentBrowserClient.
This makes it a runtime decision based on CCBC rather than linking in separate
method definition.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/1318393006
Cr-Commit-Position: refs/heads/master@{#348032}
Let WebRTC notification not show "touch to return" in custom tab
If the WebRTC is initiated from a custom tab, there is no way to return
to the tab by clicking the notification. This CL fixes the string
discrepency by removing it.
BUG=524855
Review URL: https://codereview.chromium.org/1327193004
Cr-Commit-Position: refs/heads/master@{#348031}
Add a missing mock getColor method override.
BUG=529882
Review URL: https://codereview.chromium.org/1328383002
Cr-Commit-Position: refs/heads/master@{#348030}
Don't early out in OnSwapCompositorFrame() if LatencyInfo::Verify() fails
LatencyInfo::Verify(vector<LatencyInfo>&) checks on the size of the
vector to rule out potential compromised renderer sending large
malicious payload through LatencyInfo IPC. We run into this problem
that extremely slow renderer can also accumulate large number of
LatencyInfo that exceeds our threshold. In this case, lets only
clear that vector<LatencyInfo> but do not early out in browser side
compositor frame processing which might stall the whole rendering
pipeline. Also issue a global scope instant trace event to mark
that something is really going wrong here.
BUG=529820
Review URL: https://codereview.chromium.org/1328403002
Cr-Commit-Position: refs/heads/master@{#348029}
Fix glBindUniformLocationCHROMIUM conflicts situation.
Right now, if we accidentally bind two active uniforms to the same
location, no error will occur. To me that's bad behavior, because if the
developer makes a mistake, it won't be caught as is, but some mysterious
behaviors that might take some debugging time to figure out.
As I see it, there is really no reason we should not fail link if a
conflict exists.
BUG=529518
TEST=gl_tests
[email protected]
Review URL: https://codereview.chromium.org/1330123002
Cr-Commit-Position: refs/heads/master@{#348028}
Prevent crash in UpdateClient when passed an empty list of ids
Also while adding a test for this, I did a little refactoring to cut
down a bit on copy/paste code duplication in update_client_unittest.cc.
BUG=490418
Review URL: https://codereview.chromium.org/1312193004
Cr-Commit-Position: refs/heads/master@{#348027}
Roll src/third_party/WebKit 94af568:b4168eb (svn 202005:202006)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/94af568..b4168eb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330183002
Cr-Commit-Position: refs/heads/master@{#348026}
Preliminary change for new rtc rendering algorithm:
1. Add trace flags for smoothness testing
2. Propagate render_time calculated in Jitter Buffer to media::VideoFrame for new rendering algorithm to use.
3. Move invalidation trigger to compositor thread.
This is a recommit of CL 1265433003, the original CL was reverted because it breaks Blink Layout tests and it crashes hangout for HW accelerated RTC.
BUG=514873,525866,525264
[email protected],[email protected],[email protected],[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:win_blink_rel
Review URL: https://codereview.chromium.org/1320183003
Cr-Commit-Position: refs/heads/master@{#348025}
[Android] Reenable ChromeSigninUtilsTest
Permissions are now set when installing an apk.
https://codereview.chromium.org/1316803004/
This undoes the disabling in cls:
https://codereview.chromium.org/1305863003
https://codereview.chromium.org/1286013003
BUG=520847
Review URL: https://codereview.chromium.org/1329063005
Cr-Commit-Position: refs/heads/master@{#348024}
Disable flaky BindingManagerIntegrationTest.testRestoreSharedRenderer
The test appears to flake on instrumentation-yakju-clankium
BUG=529920
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1315713012
Cr-Commit-Position: refs/heads/master@{#348023}
Roll src/third_party/WebKit 7bf0c31:94af568 (svn 202004:202005)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7bf0c31..94af568
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331713002
Cr-Commit-Position: refs/heads/master@{#348022}
In current design, chrome.webcamPrivate.reset(id, {pan: 0, tilt: 0, zoom: 0}) does the same thing as
chrome.webcamPrivate.reset(id, {pan: 1, tilt: 1, zoom: 1}), which resets pan &tilt & zoom.
It might cause confusion, as seen in crbug.com/526893.
BUG=None
Review URL: https://codereview.chromium.org/1328943003
Cr-Commit-Position: refs/heads/master@{#348021}
events: Avoid implicit conversion from Rect to RectF in events_unittests
[email protected]
BUG=342848
Review URL: https://codereview.chromium.org/1331693002
Cr-Commit-Position: refs/heads/master@{#348020}
Use checked_cast<> to avoid compile errors on Windows
BUG=528975
TEST=compiles
Review URL: https://codereview.chromium.org/1326413003
Cr-Commit-Position: refs/heads/master@{#348019}
Add WATCHLISTS entries for blimp
BUG=
Review URL: https://codereview.chromium.org/1329263002
Cr-Commit-Position: refs/heads/master@{#348018}
DevTools: expose wired front-end API for editors interop [chrome]
BUG=529471
TBR=lcwu,mnaganov
Review URL: https://codereview.chromium.org/1327543004
Cr-Commit-Position: refs/heads/master@{#348017}
Make checkboxes/radio buttons larger on Android
In order to make interacting with checkboxes and radio buttons easier
with touch, their default size is changed from 13px by 13px (in which
1px in each dimension is for the drop shadow) to 16px by 16px (in which
2px in each dimension is for a padding around them, including the dorp
shadow). For non-Android cases, an extra pixel padding is added to each
dimension to compelete the padding around them and make checkboxes and
radio buttons centered properly inside their client rects.
BUG=459055
Review URL: https://codereview.chromium.org/1330853002
Cr-Commit-Position: refs/heads/master@{#348016}
CertificateProviderService: Expose certificate lookup.
This certificate lookup is required for the upcoming UI changes.
BUG=514575
Review URL: https://codereview.chromium.org/1330003002
Cr-Commit-Position: refs/heads/master@{#348015}
Move the AnimateInput paths for WebView around to not path through cc.
They don't need to go through cc, so let's not and this lets cc reason
about when/how things happen better.
Adds 2 new interfaces:
- SynchronousInputHandlerProxy. A limited view of the InputHandlerProxy
given out to WebView to control animating timing. It lets WebView call
SynchronouslyAnimate() to do animations. And if cc tried to also animate,
we'd hit a DCHECK.
- SynchronousInputHandler. An interface given to the InputHandlerProxy
as an alternate place to handle requests for animation. When it's
present animate requests go there instead of the usual InputHandler.
R=boliu, enne, hush, jdduke, sievers
BUG=522658
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1307203003
Cr-Commit-Position: refs/heads/master@{#348014}
Autofill: Make the iOS JS extractNewForms() more like the C++ version.
BUG=427614
Review URL: https://codereview.chromium.org/1314893009
Cr-Commit-Position: refs/heads/master@{#348013}
Roll src/third_party/WebKit 2447536:7bf0c31 (svn 202002:202004)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2447536..7bf0c31
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331473006
Cr-Commit-Position: refs/heads/master@{#348012}
Adds better security checking to OnCreatedFrame()
Not quite perfect, but better.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1323233004
Cr-Commit-Position: refs/heads/master@{#348011}
Fix HE-AAC parsing issue
For HE-AAC, the actual profile is in the extension config.
BUG=527411
Review URL: https://codereview.chromium.org/1317523004
Cr-Commit-Position: refs/heads/master@{#348010}
Roll src/third_party/WebKit e50a534:2447536 (svn 202001:202002)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e50a534..2447536
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1315643007
Cr-Commit-Position: refs/heads/master@{#348009}
Roll src/third_party/skia a5783ae:7628967
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a5783ae..7628967
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
7628967 [email protected] add picture-image variant
61a81e3 [email protected] Mimic Chrome better in our GYPs.
4228c1f [email protected] switch over to using images
9a50174 [email protected] Specialize SkOncePtr<T[]>.
af2533a [email protected] Make GrProcessorDataManager a noop
1fcc01c [email protected] GrPathRangeBatch
5ca4fa3 [email protected] Revert of more zero-length changes for svg compatibility (patchset #6 id:100001 of https://codereview.chromium.org/1330623003/ )
6c59d80 [email protected] Port uses of SkLazyPtr to SkOncePtr.
336cda3 [email protected] wire up incNumDraws
2a24338 [email protected] GM: replace boilerplate with macros
157e648 [email protected] Detach cache in DF routines rather than passing it in.
fe81e2d [email protected] Make SkGraphics::Term a no-op, stop calling it.
d9b8d7a [email protected] Revert of Make SkGraphics::Term a no-op, stop calling it. (patchset #2 id:20001 of https://codereview.chromium.org/1329853005/ )
2ac6793 [email protected] Revert of Port uses of SkLazyPtr to SkOncePtr. (patchset #7 id:110001 of https://codereview.chromium.org/1322933005/ )
62fb1ba [email protected] more zero-length changes for svg compatibility
a1254ac [email protected] Port uses of SkLazyPtr to SkOncePtr.
Review URL: https://codereview.chromium.org/1330933003
Cr-Commit-Position: refs/heads/master@{#348008}
Override AppBannerClient::OnDestruct to be a no-op.
RenderFrameObserver::OnDestruct is called by the RenderFrameImpl
destructor, and by default this method deletes the observer. However,
RenderFrameImpl also holds a scoped pointer to AppBannerClient, which is
a RenderFrameObserver. This CL overrides AppBannerClient::OnDestruct to
be a no-op, preventing a double-call to the AppBannerClient destructor
and the associated renderer crashes.
BUG=519090
Review URL: https://codereview.chromium.org/1328323002
Cr-Commit-Position: refs/heads/master@{#348007}
aura: Don't implicitly convert Rect to RectF in aura_unittests.
TBR=sky
BUG=342848
Review URL: https://codereview.chromium.org/1321333005
Cr-Commit-Position: refs/heads/master@{#348006}
Fix ScopedPtrMap with custom Compare.
Copy operator, assignment operator and swap ignored the Compare template argument.
BUG=529201
Review URL: https://codereview.chromium.org/1328203002
Cr-Commit-Position: refs/heads/master@{#348005}
Roll src/third_party/WebKit bf4ba50:e50a534 (svn 202000:202001)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bf4ba50..e50a534
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329023004
Cr-Commit-Position: refs/heads/master@{#348004}
MD Downloads: compute card elevation via data binding
[email protected]
BUG=526577
Review URL: https://codereview.chromium.org/1331573003
Cr-Commit-Position: refs/heads/master@{#348003}
Update V8 to version 4.7.41.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/25971677..269aeca5
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1324683003
Cr-Commit-Position: refs/heads/master@{#348002}
ozone: Don't implicitly convert Rect to RectF.
[email protected]
BUG=342848
Review URL: https://codereview.chromium.org/1318893004
Cr-Commit-Position: refs/heads/master@{#348001}
Mandoline: support IME for HTMLWidgetRootLocal & HTMLWidgetLocalRoot.
Abstract IME related code from HTMLWidgetRootLocal to a helper class,
and use it in both HTMLWidgetRootLocal and HTMLWidgetLocalRoot.
BUG=498624
Review URL: https://codereview.chromium.org/1325833009
Cr-Commit-Position: refs/heads/master@{#348000}
Ignore leaf group nodes.
BUG=525865
Review URL: https://codereview.chromium.org/1319123005
Cr-Commit-Position: refs/heads/master@{#347999}
Convert DeviceManagerDelegate to PermissionProvider mojo interface.
This changes the device::usb::DeviceManager service so that instead of
expecting a C++ implementation of the DeviceManagerDelegate interface it
depends on the client connecting to the devices app to provide an
implementation of the PermissionProvider mojo service interface. This
will allow the permissions checker to be injected by the FrameMojoShell
when a renderer requests a connection to the devices app.
BUG=492204
Review URL: https://codereview.chromium.org/1316203006
Cr-Commit-Position: refs/heads/master@{#347998}
Replace ViewMsg_DidChangeBodyBackgroundColor with a frame metadata field.
This cleans out an Android-specific IPC. Doing it this way should also
allow more perfect synchronization (although we hadn't observed the
previous lack of synchronization to cause any visible bugs in practice).
BUG=527284
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1311093007
Cr-Commit-Position: refs/heads/master@{#347997}
Change http download links to https.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1326303003 .
Cr-Commit-Position: refs/heads/master@{#347996}
Roll src/third_party/WebKit 4b235a6:bf4ba50 (svn 201997:202000)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4b235a6..bf4ba50
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325943005
Cr-Commit-Position: refs/heads/master@{#347995}
[Extensions Page MD] Stub out a materialized extensions page
Create a stub page for a materialized extensions page.
BUG=529395
Review URL: https://codereview.chromium.org/1319163004
Cr-Commit-Position: refs/heads/master@{#347994}
Roll src/third_party/WebKit ea268f5:4b235a6 (svn 201996:201997)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ea268f5..4b235a6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312733005
Cr-Commit-Position: refs/heads/master@{#347993}
Revert of Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities (patchset #3 id:60001 of https://codereview.chromium.org/1325303004/ )
Reason for revert:
Temptative fix for
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester
timeout on
WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQuality/1
after 21330.
Original issue's description:
> Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities
>
> This format is already supported in the rest of the capture path.
> Bluefish 444 is the capture card using it.
>
> BUG=508413
> TEST=Capture using a Bluefish 444 capture card
>
> Committed: https://crrev.com/6015405a94b144471eb0128779ad3c107192f445
> Cr-Commit-Position: refs/heads/master@{#347861}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=508413
Review URL: https://codereview.chromium.org/1332653005
Cr-Commit-Position: refs/heads/master@{#347992}
Re-enable BrowserTest.RestorePinnedTabs.
Assertion doesn't seem to repro. 5 years is a long time.
BUG=38522
Review URL: https://codereview.chromium.org/1314583005
Cr-Commit-Position: refs/heads/master@{#347991}
Improved eventSender handling of non-consecutive touch ids.
After event_sender sees a sequence of touch-cancels or
touch-releases that makes the current touch ids
non-consecutive, it can create duplicate touch-ids for newly
added touch points. See the bug for details. This CL fixes
this problem.
Moreover, event_sender cleans its cache of released touches
but not the canceled ones in SendCurrentTouchEvent. This CL
takes care of this too.
BUG=529807
Review URL: https://codereview.chromium.org/1317733006
Cr-Commit-Position: refs/heads/master@{#347990}
Roll src/third_party/WebKit 52dc538:ea268f5 (svn 201995:201996)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/52dc538..ea268f5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331683002
Cr-Commit-Position: refs/heads/master@{#347989}
Roll src/third_party/WebKit f688398:52dc538 (svn 201994:201995)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f688398..52dc538
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329883005
Cr-Commit-Position: refs/heads/master@{#347988}
Wean PhishingDOMFeatureExtractor off RenderView.
The PhishingDOMFeatureExtractor does not need to know about
a RenderView. It is completely okay with just receiving a
WebDocument at the time of extraction.
BUG=521166
R=noelutz
Review URL: https://codereview.chromium.org/1325103009
Cr-Commit-Position: refs/heads/master@{#347987}
Roll src/third_party/WebKit 5dc6c7a:f688398 (svn 201993:201994)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5dc6c7a..f688398
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1313673006
Cr-Commit-Position: refs/heads/master@{#347986}
Convert pixel_ref_map -> discardable_image_map
As blink now only creates discardable images (not discardable
bitmaps/pixelrefs, we need to track the images.
(based on reed's http://crrev.com/1318323003)
BUG=527246
[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1314353005
Cr-Commit-Position: refs/heads/master@{#347985}
Renames mandoline_frame_apptests to web_view_apptests
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1323333004
Cr-Commit-Position: refs/heads/master@{#347984}
ui: Stop converting Rect to RectF implicitly in native_theme_win.cc
TBR=sky
BUG=342848
Review URL: https://codereview.chromium.org/1334553002
Cr-Commit-Position: refs/heads/master@{#347983}
Roll src/third_party/WebKit a939e61:5dc6c7a (svn 201992:201993)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a939e61..5dc6c7a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1320863006
Cr-Commit-Position: refs/heads/master@{#347982}
Android Chromoting: Swap height and width.
BUG=516871
Review URL: https://codereview.chromium.org/1324153006
Cr-Commit-Position: refs/heads/master@{#347981}
Revert of Refactor connection_security into SecurityStateModel (patchset #17 id:360001 of https://codereview.chromium.org/1314843007/ )
Reason for revert:
We need to call SecurityStateChanged() in a few more places to avoid a crash and some UI bugs. See bugs 529664 and 529872.
Original issue's description:
> Refactor connection_security into SecurityStateModel
>
> This CL refactors the connection_security namespace (a namespace of
> statics) into SecurityStateModel, a class attached to a WebContents that
> drives the security UI for that WebContents. The SecurityStateModel
> provides high-level security information about a page or request, with
> the goal of reducing code duplication across various security UI
> elements.
>
> In this first CL, I've introduced the SecurityStateModel and am using it
> to drive the omnibox/lock icon, but have not yet adapted WebsiteSettings
> to use a SecurityStateModel.
>
> BUG=528034
> [email protected]
>
> Committed: https://crrev.com/83a81afbef8f265815cb6c6a48690511825a1ce5
> Cr-Commit-Position: refs/heads/master@{#347775}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=528034
Review URL: https://codereview.chromium.org/1324293003
Cr-Commit-Position: refs/heads/master@{#347980}
Remove Skia layout test suppressions
BUG=528262
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
This cannot land until after the DEPS roll has landed and the autorebaselines have occurred (https://codereview.chromium.org/1323753003/ Rebaseline Skia-suppressed layout tests).
Review URL: https://codereview.chromium.org/1323943010
Cr-Commit-Position: refs/heads/master@{#347979}
Add WillDestroyUsbService method to UsbService::Observer interface.
This method will assist objects that observe the UsbService in removing
their observers before the UsbService is shut down.
Review URL: https://codereview.chromium.org/1324093004
Cr-Commit-Position: refs/heads/master@{#347978}
[Sync] Componentize synced_window_delegate(s_getter).
BUG=512472
TBR=dtrainor
Review URL: https://codereview.chromium.org/1279533002
Cr-Commit-Position: refs/heads/master@{#347977}
API to expose data usage history in the UI thread.
Flush unsaved data usage to disk and then read all stored data usage.
Data usage is returned in a vector sorted in chronological order and
the last entry contains data usage for current interval.
BUG=482442
Review URL: https://codereview.chromium.org/1319863005
Cr-Commit-Position: refs/heads/master@{#347976}
Enable asm compilation in libjpeg_turbo on Linux.
[email protected], [email protected]
BUG=528437
Review URL: https://codereview.chromium.org/1322853006
Cr-Commit-Position: refs/heads/master@{#347975}
Call SkGraphics::Init for in-process renderer init
Move the call from RendererMain to RenderProcessImpl constructor so it
is called for both in-process and multi-process. This is important for
Android WebView to initialize skia correctly.
BUG=525844
Review URL: https://codereview.chromium.org/1325303005
Cr-Commit-Position: refs/heads/master@{#347974}
[Contextual Search] Invalidate search term resource adapter in OnDraw
The search term text view wasn't getting drawn correctly for RTL text.
Wrapping it in a frame layout and invalidating the ResourceAdapter in
an OnDrawListener for the search term view ensures the view is
measured correctly before the ResourceAdapter is invalidated.
BUG=528166
Review URL: https://codereview.chromium.org/1325103008
Cr-Commit-Position: refs/heads/master@{#347973}
Dispatch DRP IPC call from renderer main thread
This ensures that the DRP performance timing histograms are
recorded even when user navigates to a different page. Please
see the bug for more details.
BUG=525329
Review URL: https://codereview.chromium.org/1315303002
Cr-Commit-Position: refs/heads/master@{#347972}
Roll src/third_party/WebKit 62591a8:a939e61 (svn 201989:201992)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/62591a8..a939e61
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330943002
Cr-Commit-Position: refs/heads/master@{#347971}
Mark some interactive ui tests as flaky on Windows.
See:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41603
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41598
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41597
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41586
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41601
[email protected]
BUG=523255
Review URL: https://codereview.chromium.org/1329293002
Cr-Commit-Position: refs/heads/master@{#347970}
Roll src/third_party/WebKit 18ea028:62591a8 (svn 201988:201989)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/18ea028..62591a8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1310913005
Cr-Commit-Position: refs/heads/master@{#347969}
cc: Stop converting Rect to RectF implicitly in overlay tests.
TBR=alexst
BUG=342848
Review URL: https://codereview.chromium.org/1309603007
Cr-Commit-Position: refs/heads/master@{#347968}
Roll src/third_party/WebKit 6a33e62:18ea028 (svn 201987:201988)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6a33e62..18ea028
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327113003
Cr-Commit-Position: refs/heads/master@{#347967}
Add [email protected] to various guest_view/web_view OWNERS.
BUG=none
Review URL: https://codereview.chromium.org/1333663002
Cr-Commit-Position: refs/heads/master@{#347966}
Roll src/third_party/WebKit fcbf93b:6a33e62 (svn 201986:201987)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fcbf93b..6a33e62
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327143003
Cr-Commit-Position: refs/heads/master@{#347965}
[tracing] Fix MemoryDumpManager periodic scheduler and improve tests
This a cleanup CL in preparation of next changes to memory-infra.
- Add much more coverage to the TraceConfig-related tests as this is
very critical to avoid regressions in either the chrome://tracing
UI and telemetry w.r.t. periodic dumps.
- Refactor the tests to use sane and readable in-line expectations
instead of the awkward back and forths between test fixtures
and MockDumpProvvider.
- Minor fix in the loogic which schedules periodic dumps in the
MemoryDumpManager. If ligh_period=1ms and heavy_period=4ms,
the sequence sholud be HLLLHLLL, not HLLLLHLLLL as it was
before this change.
- Normalize the "virtual_size" column in the malloc dump provider.
BUG=518823,499731
Review URL: https://codereview.chromium.org/1306843006
Cr-Commit-Position: refs/heads/master@{#347964}
Remove discard_first_result from page_test.
It is unused and broken.
BUG=529828
Review URL: https://codereview.chromium.org/1307123005
Cr-Commit-Position: refs/heads/master@{#347963}
Implement dynamic software fallback in PPB_VideoDecoder API.
Hardware decoder are usually limited in which types of streams they can
handle. Particularly they often limit stream resolution. But the decoder
API doesn't expose any of these details. As result decoding fails when
a frame that's is too big is sent to the decoder.
Now whenever hardware decoder returns an error PepperVideoDecoderHost
tries to decode the same data using software decoder.
BUG=514906
Review URL: https://codereview.chromium.org/1303183003
Cr-Commit-Position: refs/heads/master@{#347962}
Move VideoCodec/VideoCodecProfile enums into video_codecs.h
As discussed on HEVC CL https://codereview.chromium.org/816353010/
we could move VideoCodec/VideoCodecProfile enums into a separate
header video_codecs.h, since we don't always need the full
VideoDecoderConfig.
BUG=none
Review URL: https://codereview.chromium.org/1333573003
Cr-Commit-Position: refs/heads/master@{#347961}
Remove "API proposal for chrome.app.window to intercept all keys."
This reverts commit c811bb98b489b67a5f85ed79d7acd288533a080d.
The commit is reverted as it was decided to not add the API to platform.
Disabling presubmit to bypass enum edit check that fails as the enum value is renamed to kDelete_.
NOPRESUBMIT=true
BUG=166928
Review URL: https://codereview.chromium.org/1316013004
Cr-Commit-Position: refs/heads/master@{#347960}
Roll ANGLE a0a9e12..e6432c8
https://chromium.googlesource.com/angle/angle.git/+log/a0a9e12..e6432c8
BUG=525188
[email protected],[email protected]
TEST=bots
Review URL: https://codereview.chromium.org/1330923002
Cr-Commit-Position: refs/heads/master@{#347959}
Roll src/third_party/WebKit d0a7a1a:fcbf93b (svn 201984:201986)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d0a7a1a..fcbf93b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319783008
Cr-Commit-Position: refs/heads/master@{#347958}
[Media Router] Clean up WebUI route map rebuilding logic.
Each route is now tagged with |for_display|. MR filters through them such that the WebUI only gets a list of routes that we want to show. We expect that only one route per sink is passed along to the WebUI.
This change simplifies the WebUI to reflect these changes. This also adds logging in MediaRouterUI if there are are routes to show that both have the same sink id.
BUG=510300, 520557
Review URL: https://codereview.chromium.org/1315063010
Cr-Commit-Position: refs/heads/master@{#347957}
shortcut: utilize the user provided title in the add to homscreen Toast
Using the domain can be confusing as subdomains are excluded. Showing the full
origin is also an option but can end up being too long.
Utilise the user screened title as we know this to be secure as the user
has reviewed it.
BUG=524019
Review URL: https://codereview.chromium.org/1333613003
Cr-Commit-Position: refs/heads/master@{#347956}
Settings Rewrite: Implement Breadcrumb
Implements the breadcrumb functionality. No styling or placement in this patch.
BUG=425627
Review URL: https://codereview.chromium.org/1325753005
Cr-Commit-Position: refs/heads/master@{#347955}
Roll src/third_party/WebKit 1fe2058:d0a7a1a (svn 201983:201984)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fe2058..d0a7a1a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1303333008
Cr-Commit-Position: refs/heads/master@{#347954}
Report crashes in setup.exe as coming from the same product as the browser.
This regressed in r256585 when the product name of setup.exe changed in
its resource.
BUG=526710
[email protected]
Review URL: https://codereview.chromium.org/1321853010
Cr-Commit-Position: refs/heads/master@{#347953}
Removes obsolete/unnecessary preprocessing from tts_background.js.
TEST=verify each of the removed preprocessing examples in tts_background_test for camelCase and acronyms pronounce correctly using the latest tts bits on chrome OS.
BUG=526513
Review URL: https://codereview.chromium.org/1329973003
Cr-Commit-Position: refs/heads/master@{#347952}
Expose distiller functions to JavaScript
This change adds two mojo services; one for notifying a RenderFrame
that it is working on a distiller page and one for allowing distiller
JavaScript functions to access the browser. This CL only exposes a
single function "distiller.echo".
BUG=
Review URL: https://codereview.chromium.org/1231083007
Cr-Commit-Position: refs/heads/master@{#347951}
Reland of Fix crash on signing in when Google Play Services is out of date. (patchset #1 id:1 of https://codereview.chromium.org/1330043002/ )
Reason for revert:
Updated downstream test.
Original issue's description:
> Revert of Fix crash on signing in when Google Play Services is out of date. (patchset #6 id:100001 of https://codereview.chromium.org/1321633002/ )
>
> Reason for revert:
> The sign in tests are failing downstream and this appears to be the most likely candidate.
>
> Original issue's description:
> > Fix crash on signing in when Google Play Services is out of date.
> >
> > BUG=525289
> >
> > Committed: https://crrev.com/3e39b48298400c91d2310c1d04fae1b7c6f9bcb3
> > Cr-Commit-Position: refs/heads/master@{#347373}
>
> [email protected],[email protected],[email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=525289
>
> Committed: https://crrev.com/d4c04f4ca1b4cb0c97f0945c281916fdc6c29c36
> Cr-Commit-Position: refs/heads/master@{#347727}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525289
Review URL: https://codereview.chromium.org/1308003006
Cr-Commit-Position: refs/heads/master@{#347950}
[MD settings] changing currentRoute property to Object
This CL changes the currentRoute property from an Array (which is incorrect, per Tommy) to an Object.
BUG=425627
Review URL: https://codereview.chromium.org/1321033004
Cr-Commit-Position: refs/heads/master@{#347949}
Add new Autocomplete match type for clipboard url provider.
BUG=523951
Review URL: https://codereview.chromium.org/1310203003
Cr-Commit-Position: refs/heads/master@{#347948}
[tracing] Consolidate v8 reporting in memory-infra
The overall plan is to make it so that all the memory-infra dumpers report,
in the "size" column, an estimation of amount of resident memory that
is causing pressure to the system.
Before this CL the v8 dumper was reporting the virtual memory size,
which is generally higher that the actual resident memory.
This CL normalizes the situation.
Also, the detailed dump about the heap objects at last GC is renamed
to reflect the information, in lack of a better solution (see
crbug.com/498779).
BUG=481504,476013
Review URL: https://codereview.chromium.org/1307173008
Cr-Commit-Position: refs/heads/master@{#347947}
Add versions to the dependency_manager.
BUG=510231
Review URL: https://codereview.chromium.org/1305973013
Cr-Commit-Position: refs/heads/master@{#347946}
Minor code/doc cleanup of SpdyPriorityTree, no functional change.
- Update doc comment to state that Nodes can have multiple children.
- Make Node struct and some related methods private.
- Initialize Node members inline.
- Use nullptr instead of NULL.
This CL lands server change 101618261 by mpw.
BUG=488484
Review URL: https://codereview.chromium.org/1328663002
Cr-Commit-Position: refs/heads/master@{#347945}
Added @Deprecated annotation to fix errorprone error.
Fixed error (http://errorprone.info/bugpattern/DepAnn) causing
errorprone builds to fail.
BUG=485599
Review URL: https://codereview.chromium.org/1318153008
Cr-Commit-Position: refs/heads/master@{#347944}
Roll src/third_party/WebKit ca3285a:1fe2058 (svn 201981:201983)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ca3285a..1fe2058
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1310513009
Cr-Commit-Position: refs/heads/master@{#347943}
MD Downloads: use computed data binding to hide removal (X)
[email protected]
BUG=526577
Review URL: https://codereview.chromium.org/1302293008
Cr-Commit-Position: refs/heads/master@{#347942}
Roll src/third_party/WebKit 08686c6:ca3285a (svn 201980:201981)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/08686c6..ca3285a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333643002
Cr-Commit-Position: refs/heads/master@{#347941}
Remove internal Skia header from skia_memory_dump_provider.cc
Luckily, it looks like it includes the header but doesn't actually need it.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1333603003
Cr-Commit-Position: refs/heads/master@{#347940}
Remove the remaining theme-related state from the chrome://apps HTML
This CL removes the hasattribution attribute from the chrome://apps HTML.
All of the other theme-controlled chrome://apps styling is set via a CSS
stylesheet which is regenerated each time that chrome://apps is loaded.
Moving the remaining theme-related styling out of the HTML and into the
stylesheet makes the code more readable
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/1333483003
Cr-Commit-Position: refs/heads/master@{#347939}
[Android] Persist ordering of NTP suggestions.
Persist order of NTP suggestions by storing them in preferences.
Previously the order was guided by popular sites unless the personal
suggestions are completely different.
This is wrong in two important cases namely:
-Users who get into the popular suggestions experiment for the first time.
-When the popular suggestions are updated.
BUG=528915
Review URL: https://codereview.chromium.org/1330773002
Cr-Commit-Position: refs/heads/master@{#347938}
Optimize for TouchStart responsiveness by modeling what the user is doing.
We have come to realize that TouchStart responsiveness is really critical
for a good user experience.
This patch introduces a (initially very simple) system for modeling
what the user is doing and predicting when they are likely to initiate a
new gesture (taps are ignored). We order task priority accordingly.
In addition we extend the estimation of task cost to loading tasks
which are often a significant source of jank.
Load tasks can be very long (easily up to 1000ms). There is
no good way to cooperatively schedule such a task but the
least worst user experience seems to be if we get them out
of the way as fast as possible. Ideally we'd prioritize them
but the order of IPC and LoadingTasks currently needs to
be more or less in lockstep. Instead we deprioritize compositor
tasks inside a compositor gesture, which has the effect of
prioritizing other work.
Expected changes on Perf bots:
1. first_gesture_scroll_update_latency in smoothness.scrolling_tough_ad_cases
should go down. This should be highly user visible.
2. It's possible some compositor metrics such as queueing_durations
may regress. I don't expect this to be user visible.
BUG=510398
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1320633002
Cr-Commit-Position: refs/heads/master@{#347937}
This patch allows the webview.partitions.accessible_resources entry in chrome app manifests to work fully as intended.
Previously, web pages attempting to use resources specified as webview accessible would fail to load those resources. This happened because a check in the renderer would stop the resource request from being made before the request ever reached the browser process where the webview accessible resources are checked in the manifest. This patch corrects this problem by propagating webview partition IDs to webview guest renderer processes, so that they can check the correct entry in the manifest for accessible resources and allow valid requests to go through to the browser process.
BUG=460797
Review URL: https://codereview.chromium.org/1312653003
Cr-Commit-Position: refs/heads/master@{#347936}
Roll src/third_party/WebKit a1089e6:08686c6 (svn 201979:201980)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a1089e6..08686c6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1307193004
Cr-Commit-Position: refs/heads/master@{#347935}
Make SpdySessionTests robust agains DoReadLoop yielding early.
Create mock time function to simulate infinitely fast reads so that the timeout
yield mechanism in SpdySession::DoReadLoop introduced in
https://crrev.com/1214833006 does not upset tests.
BUG=527544
Review URL: https://codereview.chromium.org/1326923003
Cr-Commit-Position: refs/heads/master@{#347934}
Force buffer re-allocation when the backing display changes
When the user changes the primary display and both displays have the
same resolution, the buffers are never re-allocated. It is then possible
to encounter the following scenario:
Surface 1 scans out on display A and surface 2 scans out on display B.
When surface 1 moves to display B and surface 2 to display A there is no
guarantee that either surface will force re-draws. If, say, surface 1
starts page flipping it is possible that it would start re-using the
buffer currently shown on display A which could cause the GPU process to
wait for display A to release the buffer. At this point the GPU main
thread is blocked waiting without a possibility to progress since
surface 2 cannot use the GPU to update. Eventually the watchdog kills
the GPU process which causes the surfaces to be reallocated and progress
to continue.
BUG=511446
Review URL: https://codereview.chromium.org/1334483002
Cr-Commit-Position: refs/heads/master@{#347933}
Add logging to profile downloader to diagnose Android FR issue.
This is a very temporary fix that will be reverted in a few days when the additional information has been used to pinpoint the bug.
BUG=500854
Review URL: https://codereview.chromium.org/1326273003
Cr-Commit-Position: refs/heads/master@{#347932}
Remove unused IDS_MEDIA_NOTIFICATION_TEXT_NO_LINK.
Follow-up from https://codereview.chromium.org/1326163002
BUG=None
Review URL: https://codereview.chromium.org/1330163006
Cr-Commit-Position: refs/heads/master@{#347931}
Add iOS specific function to register preferences.
iOS cannot use chrome/browser/prefs/browser_prefs.cc and the file will
not be componentized as it is embedder specific, so provide an iOS
implementation based on it.
BUG=513323
Review URL: https://codereview.chromium.org/1306673004
Cr-Commit-Position: refs/heads/master@{#347930}
Adds connection id to the ViewTree::Embed() callback
I'm going to use this in frames for further validation.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1317893006
Cr-Commit-Position: refs/heads/master@{#347929}
Roll src/third_party/WebKit 57aef96:a1089e6 (svn 201978:201979)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/57aef96..a1089e6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312453006
Cr-Commit-Position: refs/heads/master@{#347928}
Update V8 to version 4.7.40.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/242115ba..25971677
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1320683005
Cr-Commit-Position: refs/heads/master@{#347927}
Roll src/third_party/WebKit 3c1b001:57aef96 (svn 201977:201978)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3c1b001..57aef96
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309563009
Cr-Commit-Position: refs/heads/master@{#347926}
Remove trailing backslash in comment causing multiline comment warning on chromeos_amd64.
BUG=514575
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1309363008 .
Cr-Commit-Position: refs/heads/master@{#347925}
[Presentation API, Android] Support for app messages
Recognizes Cast application specific messages and forwards the messages back
and forth.
BUG=524131
Review URL: https://codereview.chromium.org/1305213008
Cr-Commit-Position: refs/heads/master@{#347924}
jni: Forbid inappropriate JNI parameter conversions.
Don't allow JavaParamRefs to be used to construct ScopedJavaLocalRefs.
This leads to incorrect reference handling behaviour, since parameters
are not allowed to be deleted. Instead code should simply pass the
JavaParamRef by reference; functions should be taking "const JavaRef&"
for input which is compatible.
Fix the cases in the code where this conversion is currently being
relied upon.
BUG=506850
Review URL: https://codereview.chromium.org/1326763009
Cr-Commit-Position: refs/heads/master@{#347923}
Roll src/third_party/WebKit 52503da:3c1b001 (svn 201976:201977)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/52503da..3c1b001
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1322883004
Cr-Commit-Position: refs/heads/master@{#347922}
Roll src/third_party/WebKit 8139f33:52503da (svn 201975:201976)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8139f33..52503da
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333633002
Cr-Commit-Position: refs/heads/master@{#347921}
Popular sites on the NTP: check that experiment group StartsWith (rather than IS) "Enabled"
This will give us the option of creating additional "enabled" groups in the future
BUG=516618
Review URL: https://codereview.chromium.org/1314503008
Cr-Commit-Position: refs/heads/master@{#347920}
Roll src/third_party/WebKit d9c6159:8139f33 (svn 201974:201975)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d9c6159..8139f33
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312633006
Cr-Commit-Position: refs/heads/master@{#347919}
cygprofile: increase timeouts to allow showing web contents
Also doing a fork() changes thread id (syscall gettid), which breaks the
assumptions in cygprofile.cc, disabled a fork in library_prefetcher.
Verified: with these changes the instrumented build is able to display the
contents of 'https://google.com'. It does not finish loading though, which is
probably due to some other timeouts.
BUG=503613
Review URL: https://codereview.chromium.org/1325053009
Cr-Commit-Position: refs/heads/master@{#347918}
Roll src/third_party/WebKit 3aea697:d9c6159 (svn 201973:201974)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3aea697..d9c6159
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330163003
Cr-Commit-Position: refs/heads/master@{#347917}
Add new certificateProvider extension API.
BUG=514575
Review URL: https://codereview.chromium.org/1232553003
Cr-Commit-Position: refs/heads/master@{#347916}
Roll src/third_party/WebKit 9d2dfea:3aea697 (svn 201972:201973)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9d2dfea..3aea697
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309563008
Cr-Commit-Position: refs/heads/master@{#347915}
Revert "Add sbox tests related to warming up of locales."
Speculative revert of https://codereview.chromium.org/1324523008.
After that CL, multiple XP bots started failing in strange ways on content_browsertests, sync_integration_tests, and telemetry_tests.
BUG=464430
[email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1328353002 .
Cr-Commit-Position: refs/heads/master@{#347914}
[MacViews] Show comboboxes with a native NSMenu
The positioning and fancy scrolling behavior of native Combobox popup
menus on Mac is fiddly to replicate. We already show context menus in
MacViews with NSMenu, and it's straightforward to adapt combobox menus
to be shown with NSMenu APIs as well, so long as the menu is backed by a
ui::MenuModel.
To achieve the positioning with NSMenu APIs, an NSView is required for
the anchor. For this, insert a temporary, hidden NSButton in the window
which is removed as soon as the menu is dismissed.
BUG=522365
Review URL: https://codereview.chromium.org/1321023005
Cr-Commit-Position: refs/heads/master@{#347913}
Fix sbox_validation_tests & Make isolate_driver.py include the executable itself
This is a redo of https://codereview.chromium.org/1245873002 c6649f2e014a24a909
with fix for Official build.
Further reduce the boilerplate in .isolate files and is necessary to add debug
symbols, to be done in a follow up.
Slightly accelerate ninja file parsing by blacklisting more extensions.
sbox_validation_tests wasn't run on Windows since
https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL
uncovered this copy-paste error.
[email protected]
BUG=98637
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1320793004
Cr-Commit-Position: refs/heads/master@{#347912}
Roll src/third_party/WebKit 3fbf7d6:9d2dfea (svn 201971:201972)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3fbf7d6..9d2dfea
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327133002
Cr-Commit-Position: refs/heads/master@{#347911}
Created HostContentSettingsMapFactory
Did my best to plug it into the build system as well.
BUG=112530
Review URL: https://codereview.chromium.org/1315143003
Cr-Commit-Position: refs/heads/master@{#347910}
Roll src/third_party/WebKit c9056fb:3fbf7d6 (svn 201970:201971)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c9056fb..3fbf7d6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1326373004
Cr-Commit-Position: refs/heads/master@{#347909}
Add simple URL filtering to webview
Add support for policies, the first 2 implemented here being
URLBlacklist and URLWhitelist.
They are to be set via app restrictions on the embedder app,
by prefixing the policy name with "com.android.browser:"
BUG=506808
[email protected]
Review URL: https://codereview.chromium.org/1234943010
Cr-Commit-Position: refs/heads/master@{#347908}
[Presentation API,Android] Support for basic Cast commands.
Support for launching/stopping Cast applications and basic media commands
(e.g. LOAD, PLAY, PAUSE).
BUG=524131
TEST=storage.googleapis.com/castapi/CastHelloVideo/index.html
Review URL: https://codereview.chromium.org/1305223012
Cr-Commit-Position: refs/heads/master@{#347907}
Disable IndexedDBBrowserTestWithGCExposed.BlobDidAckPrefetch on Linux.
The test has been very flaky on Linux over the course of several days now.
BUG=459835
[email protected]
Review URL: https://codereview.chromium.org/1308893006
Cr-Commit-Position: refs/heads/master@{#347906}
Roll src/third_party/WebKit 289def0:c9056fb (svn 201969:201970)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/289def0..c9056fb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1318793008
Cr-Commit-Position: refs/heads/master@{#347905}
[iOS] Platform-specific implementation of net::NetworkDelegate
BUG=513323
Review URL: https://codereview.chromium.org/1309963005
Cr-Commit-Position: refs/heads/master@{#347904}
Roll src/third_party/WebKit 0889aa3:289def0 (svn 201968:201969)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0889aa3..289def0
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333613002
Cr-Commit-Position: refs/heads/master@{#347903}
Roll src/third_party/WebKit 6bc2409:0889aa3 (svn 201966:201968)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6bc2409..0889aa3
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309313010
Cr-Commit-Position: refs/heads/master@{#347902}
Reland of Fix typo in install-sysroot.py (patchset #1 id:1 of https://codereview.chromium.org/1315773003/ )
Reason for revert:
The check_licenses script has been fixed, and it cycled green:
https://build.chromium.org/p/chromium/builders/Linux/builds/66708
Original issue's description:
> Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ )
>
> Reason for revert:
> Caused check_licenses to fail:
>
> https://build.chromium.org/p/chromium/builders/Linux/builds/66701
>
> Original issue's description:
> > Fix typo in install-sysroot.py
> >
> > install-sysroot.py was intended to default to installing
> > the sysroot ia32, but within this script 'i386' is used to
> > refer to this architecture.
> >
> > This most likely went unnoticed since the ia32 builder
> > either use branding=Official, or explicitly set
> > use_sysroot=1, or have a complete set of packages for
> > cross building on the host system.
> >
> > BUG=504446
> >
> > Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> > Cr-Commit-Position: refs/heads/master@{#347821}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=504446
>
> Committed: https://crrev.com/3b27a2de111759359162bcad49753e17ee1cf002
> Cr-Commit-Position: refs/heads/master@{#347839}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1324853005
Cr-Commit-Position: refs/heads/master@{#347901}
gn: fix documentation typo
s/currebt/current/
TBR=brettw
Review URL: https://codereview.chromium.org/1318963007
Cr-Commit-Position: refs/heads/master@{#347900}
Roll src/third_party/WebKit 8ee8faa:6bc2409 (svn 201965:201966)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8ee8faa..6bc2409
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327123002
Cr-Commit-Position: refs/heads/master@{#347899}
Enable TestLoadingPublicUsersFromLocalState
Ran this test 100 times locally with no failures. Didn't fail on bots either
BUG=393708
Review URL: https://codereview.chromium.org/1319373003
Cr-Commit-Position: refs/heads/master@{#347898}
Roll src/third_party/WebKit 94c04b8:8ee8faa (svn 201964:201965)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/94c04b8..8ee8faa
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1320333005
Cr-Commit-Position: refs/heads/master@{#347897}
Use EnumerateHeaderLines to parse added headers in webRequest API
The responseHeaders that are passed to the webRequest.onHeadersReceived
event are generated by the GetResponseHeadersList method. This method
enumerates the headers using HttpResponseHeaders::EnumerateHeaderLines,
which skips over commas in header values.
But the return value of the webRequest.onHeadersReceived handler is
parsed by HttpResponseHeaders:EnumerateHeader, which stops at commas.
So, if the original response header contains a comma, and the extension
returns the response headers in unmodified form, it was still mistakenly
flagged as modified. This results in duplication of headers.
To fix this, the return value is now parsed using EnumerateHeaderLines.
BUG=526367
TEST=unit_tests --gtest_filter=ExtensionWebRequestHelpersTest.*
Review URL: https://codereview.chromium.org/1315643005
Cr-Commit-Position: refs/heads/master@{#347896}
Roll src/third_party/WebKit bda1fe3e:94c04b8 (svn 201962:201964)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bda1fe3e..94c04b8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309423005
Cr-Commit-Position: refs/heads/master@{#347895}
Roll src/third_party/WebKit 26e7263:bda1fe3e (svn 201960:201962)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/26e7263..bda1fe3e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1310163005
Cr-Commit-Position: refs/heads/master@{#347894}
Excluded sysroot directories from checklicences.py
BUG=
Review URL: https://codereview.chromium.org/1329243002
Cr-Commit-Position: refs/heads/master@{#347893}
[Ozone] Fix SingleOnTop issue by checking if the quad is clipped.
Video quad may be clipped.
We need to check that before use overlay
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1311013002
Cr-Commit-Position: refs/heads/master@{#347892}
Roll src/third_party/WebKit fb9c61d:26e7263 (svn 201946:201960)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fb9c61d..26e7263
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1331653002
Cr-Commit-Position: refs/heads/master@{#347891}
Removed deprecated function IsRTLUILayout().
Review URL: https://codereview.chromium.org/1320353003
Cr-Commit-Position: refs/heads/master@{#347890}
Add a test for downloading a file in a new tab multiple times
BUG=481758
Review URL: https://codereview.chromium.org/1320323006
Cr-Commit-Position: refs/heads/master@{#347889}
Remove CONTENT_SETTINGS_NUM_TYPES (part 2)
To make it possible to make ContentSettingsTypes no longer an enum we need
to remove the occurrences of iterations over it. This CL removes occurences
from chrome/browser/ui/content_settings and does some cleanup. Rather than
switching on ContentSettingsType, we instead create a list of content settings
types that have bubbles and iterate over that.
The list of nib paths in content_setting_bubble_cocoa.mm has been updated to
include CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC/CAMERA to match the list of
bubble types.
location_bar_view.cc has been changed not to iterate over entire enum anymore
because it only needed to iterate over the list of types that have bubbles.
BUG=526932
Review URL: https://codereview.chromium.org/1312053006
Cr-Commit-Position: refs/heads/master@{#347888}
Only user gesture focus change and mouse click show autofill.
BUG=428087
Review URL: https://codereview.chromium.org/1304923002
Cr-Commit-Position: refs/heads/master@{#347887}
Deflake CustomLauncherPageBrowserTest.EventsActivateSwitchToCustomPage on ChromeOS Buildspec Tests
The failure doesn't reproduce with --enable-pixel-output-in-tests, so I
don't really know what's going on. But I suspect that since ChromeOS
only checks the *target* visibility, it's possible for the app list to
not be fully shown.
One case this could happen is on official/buildspec builders which
have more icons to load, and so the delayed-icon-load steps used
for ChromeOS via AppListMainView::ShowAppListWhenReady() end up
taking longer.
Explicitly showing the app list ensures the app list is visible
before the event generator tries to use it to generate mouse coordinates.
BUG=525128
Review URL: https://codereview.chromium.org/1308663007
Cr-Commit-Position: refs/heads/master@{#347886}
Remove use of JSONReader::DeprecatedRead from common_extension_api_unittest.cc
Remove use of deprecated function DeprecatedRead
from chrome/common/extensions/api/common_extension_api_unittest.cc
BUG=523194
Review URL: https://codereview.chromium.org/1321313004
Cr-Commit-Position: refs/heads/master@{#347885}
Roll src/third_party/WebKit 9e49999:fb9c61d (svn 201944:201946)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9e49999..fb9c61d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1318113006
Cr-Commit-Position: refs/heads/master@{#347884}
Assume crashed RenderWidgetHost to be invisible
On Android, we assume dead RenderWidgetHost to be invisible to correctly
keep the priority of a restored renderer.
Instead, we set the correct visibility when it is restored.
BUG=522795
Review URL: https://codereview.chromium.org/1308623003
Cr-Commit-Position: refs/heads/master@{#347883}
Update V8 to version 4.7.39.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ab6f1f01..242115ba
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312193005
Cr-Commit-Position: refs/heads/master@{#347882}
Fix integration test failure caused by issue/1303993003.
issue/1303993003 renames Media Router route "title" field to
"description".
BUG=
Review URL: https://codereview.chromium.org/1305163009
Cr-Commit-Position: refs/heads/master@{#347881}
[Sync] Use ModelTypeProcessor instead of ModelTypeProcessorImpl.
This CL doesn't touch ModelTypeProcessorImpl in DataTypeController
because ModelTypeProcessor doesn't have the functionality for it.
Those uses will be removed in a separate refactor.
Also fixes a bunch of incorrect variable names.
BUG=517953
Review URL: https://codereview.chromium.org/1321613003
Cr-Commit-Position: refs/heads/master@{#347880}
MD Downloads: remove malware nodes from DOM if a download isn't malware
[email protected]
BUG=526577
Review URL: https://codereview.chromium.org/1328263004
Cr-Commit-Position: refs/heads/master@{#347879}
ServiceWorker: Drop statechange events if WebServiceWorkerProxy is not ready
This is a quick fix for http://crbug.com/507110
BUG=507110
Review URL: https://codereview.chromium.org/1325143004
Cr-Commit-Position: refs/heads/master@{#347878}
CC Animations: Allow timelines and players without host to support non-compositingMode
We have a situation with DeprecatedPaintLayerCompositor where it will never be in "compositingMode" (for a page with SVGImageChromeClient/EmptyClient)
BUG=394777
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1322853003
Cr-Commit-Position: refs/heads/master@{#347877}
[Android][telemetry] Break logging deadlock in AppCrashException. (RELAND)
This is a reland of https://codereview.chromium.org/1328093006
BUG=
Review URL: https://codereview.chromium.org/1328303004
Cr-Commit-Position: refs/heads/master@{#347876}
Don't crash the browser when a webui page misbehaves
Just ignore the call (which is what would happen anyways), and upload a
minidump
BUG=516690
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332513002
Cr-Commit-Position: refs/heads/master@{#347875}
Use scan codes when sending keyboard events froms physical keyboard.
Previously android app was using key code when sending keyboard events.
That approach doesn't work well with physical keyboard when using
layout other than QWERTY. Fixed the client to use scan codes, so that
the events are always send correctly and layout mapping is applied
only on the client.
BUG=475713
Review URL: https://codereview.chromium.org/1321223003
Cr-Commit-Position: refs/heads/master@{#347874}
Add chrome.virtualKeyboardPrivate.setHotrodKeyboard api
BUG=524291
Review URL: https://codereview.chromium.org/1315233006
Cr-Commit-Position: refs/heads/master@{#347873}
Popular sites on the NTP: add thumbnails!
BUG=516618
Review URL: https://codereview.chromium.org/1314493013
Cr-Commit-Position: refs/heads/master@{#347872}
QUIC - Disable QUIC when there is bad packet loss rate (50% of the
packets are lost) for 4 consecutive crypto handshakes.
For a session, during crypto handshake if there is a bad packet loss
rate, then we mark that QUIC is recently broken for that host/port.
We disable QUIC and close that connections if 4 consecutive handshakes
have bad packet loss rate. QUIC was disabled for 0.002% of the time.
We have been running the above experiment in M45 (in Canary, Dev and
Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is
faster by 4.4% (for data aggreagted for 28 days) when this experiment
was enabled.
[email protected]
Review URL: https://codereview.chromium.org/1326763007
Cr-Commit-Position: refs/heads/master@{#347871}
Files.app: Reset hidden state of default commands when input elements are focused.
paste command's hidden property is set true when one directory is focused.
However, it will not be reset when an input is focused just after on directory is focused,
because different handler (forceDefaultHandler) handles canExecute event when inputs are focused.
All cut/copy/paste/delete commands should be shown in input element,
so this CL reset the hidden property of them.
BUG=528843
TEST=manually tested on rename input, search input, and filename input on save-as dialog.
Review URL: https://codereview.chromium.org/1312583009
Cr-Commit-Position: refs/heads/master@{#347870}
Fix splash screen tests by adding rounding slop.
BUG=529543
Review URL: https://codereview.chromium.org/1310663007
Cr-Commit-Position: refs/heads/master@{#347869}
Implement SSLConfigService::Observer in QuicStreamFactory
When channel IDs are deleted, QUIC sessions need to be close to avoid reusing the old channel ID.
Review URL: https://codereview.chromium.org/1320423011
Cr-Commit-Position: refs/heads/master@{#347868}
Use a ui::MenuModel in views::Combobox
views::Combobox currently does its own menu-building rather than using a
ui::MenuModel. However, the only thing missing from MenuModel is the
ability to set a minimum menu width. (Combobox currently does this by
adding an invisible SubmenuView with a given width.)
Moving the menu building out of Combobox allows Mac to build a native
menu instead, which gives a much nicer menu experience there. In
particular, Comboboxes on Mac center the menu over the button vertically,
and have fancy scrolling/repositioning mechanisms when the menu is shown
near the edge of the screen.
This CL adds an Adapter class that adapts a ui::ComboboxModel to the
ui::MenuModel interface, allowing views:Comboxbox to be simplified
elsewhere. MenuRunnerImplCocoa will be extended to support comboboxes in
a follow-up. For the minimum width, MenuController::CalculateMenuBounds()
can just use the width of the anchor rectangle for the same effect.
Note that TranslateBubbleView is the only user of
Combobox::STYLE_ACTION. TranslateBubbleView puts a separator after the
first item which Combobox always removes. MenuModel::IsVisibleAt() isn't
checked for separators, so simply don't add the separator to keep things
simple.
BUG=522365
Review URL: https://codereview.chromium.org/1310903004
Cr-Commit-Position: refs/heads/master@{#347867}
Add webusb notification UI unit tests
This patch added webusb notification UI unit tests code.
BUG=492204
Review URL: https://codereview.chromium.org/1326003006
Cr-Commit-Position: refs/heads/master@{#347866}
Deprecating high-conflict accelerators
This CL designs a framework for deprecated accelerators.
In this CL we deprecate the following accelerators:
- Lock Screen: Ctrl+Shift+L --> Search+L
- Task Manager: Shift+Esc --> Search+Esc
The old accelerators are still enabled, but the user is shown a
notification message telling him about the new accelerator.
UMA stats are recorded for both old and new accelerators.
Keyboard overlay has been updated.
BUG=492454,486198,498565,405317,503351
TEST=manually, ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*,
ash_unittests --gtest_filter=AcceleratorTableTest.CheckDeprecatedAccelerators
Committed: https://crrev.com/c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b
Cr-Commit-Position: refs/heads/master@{#335410}
Review URL: https://codereview.chromium.org/1177773002
Cr-Commit-Position: refs/heads/master@{#347865}
Add support for converting I420 software frames into NV12 hardware frames
Enhance MaybeCreateHardwareFrame() to be able to create a NV12 hardware
frame backed by a YUV_420_BIPLANAR GpuMemoryBuffer.
This code path is not enabled yet.
BUG=524582
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1307853003
Cr-Commit-Position: refs/heads/master@{#347864}
Drop Hixie76 support from WebSocketServer.
BUG=523228
Review URL: https://codereview.chromium.org/1310853004
Cr-Commit-Position: refs/heads/master@{#347863}
Files.app: split query into AND conditioned keywords in metadata search.
BUG=514853
TEST=unit_tests:SearchMetadataTest.*;SearchMetadataSimpleTest.*
Review URL: https://codereview.chromium.org/1321553003
Cr-Commit-Position: refs/heads/master@{#347862}
Win Video Capture: add UYVY pixel format to Cr sink filter pin capabilities
This format is already supported in the rest of the capture path.
Bluefish 444 is the capture card using it.
BUG=508413
TEST=Capture using a Bluefish 444 capture card
Review URL: https://codereview.chromium.org/1325303004
Cr-Commit-Position: refs/heads/master@{#347861}
Roll src/third_party/skia 036fd8e:a5783ae
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/036fd8e..a5783ae
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
a5783ae [email protected] Provides various implementations of Android's SkBitmapRegionDecoder.
Review URL: https://codereview.chromium.org/1326383002
Cr-Commit-Position: refs/heads/master@{#347860}
Disable the extension service worker checks that are crashing the renderer.
They're triggering for hosted apps, which is a bug. It's still not correct and
that will be fixed soon, but in the meantime don't crash.
BUG=525965, 529516
[email protected]
Review URL: https://codereview.chromium.org/1328313002
Cr-Commit-Position: refs/heads/master@{#347859}
Make IsGestureTyping enabled on by default.
BUG=527500
Review URL: https://codereview.chromium.org/1321543010
Cr-Commit-Position: refs/heads/master@{#347858}
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().
BUG=464430
Review URL: https://codereview.chromium.org/1324523008
Cr-Commit-Position: refs/heads/master@{#347857}
Dynamically create Gaia accounts when running E2E sync integration tests.
Tests would request a new Gaia account only when running
against external servers AND when no --sync-user-for-test
flag is present.
BUG=525165
Review URL: https://codereview.chromium.org/1306163003
Cr-Commit-Position: refs/heads/master@{#347856}
Updating trunk VERSION from 2505.0 to 2506.0
Cr-Commit-Position: refs/heads/master@{#347855}
Roll src/third_party/WebKit 46b16a4:9e49999 (svn 201943:201944)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/46b16a4..9e49999
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1321293004
Cr-Commit-Position: refs/heads/master@{#347854}
Disable PrecacheLauncher and ExternalPrerenderHandler tests on svelte
These tests depend on prerender feature which is disabled on svelte devices.
BUG=529490
Review URL: https://codereview.chromium.org/1305063010
Cr-Commit-Position: refs/heads/master@{#347853}
Ethersuggest++ stopped working on CR44. https://codereview.chromium.org/1189033002/patch/20001/30002 made the change in such a way that current URL is not sent to GWS. More details can be found in the bug.
BUG=529447
Review URL: https://codereview.chromium.org/1305163010
Cr-Commit-Position: refs/heads/master@{#347852}
MD Downloads: wrap some <paper-buttons>s in <template is="dom-if">
This reduces the DOM nodes in the page roughly in half, and I haven't
even started on the dangerous ones yet :).
[email protected]
BUG=526577
Review URL: https://codereview.chromium.org/1325853006
Cr-Commit-Position: refs/heads/master@{#347851}
Make FilteredMemoryPressureCalculator injected dependencies externally owned.
This makes final integration with the MemoryPressureMonitor easier, as it will own a single TickClock which can be injected down the entire stack of dependencies.
BUG=520962
Review URL: https://codereview.chromium.org/1317353006
Cr-Commit-Position: refs/heads/master@{#347850}
Add a check for null returns from SpellChekerSessonBridge#create().
When a spell checker service is not available on a device (e.g. Samsung S4)
Android will return a null object and thus SpellCheckerSessionBride will
return null. This CL adds early returns for such cases.
BUG=529355
Review URL: https://codereview.chromium.org/1310093007
Cr-Commit-Position: refs/heads/master@{#347849}
Fix vectorized icon for PPAPI broker website setting icon
[!] instead of [x] badge
BUG=505953
Review URL: https://codereview.chromium.org/1309063006
Cr-Commit-Position: refs/heads/master@{#347848}
Disable extension Panels on Dev and Canary, except for the whitelist
They're already disabled on Beta and Stable channels. Leaving them
enabled in Dev/Canary confuses users and makes people suspect
regressions.
After this, panels are only enabled when --enable-panels is set in
chrome://flags and for the whitelist (Hangouts).
CL also tries to consolidate all the Hangouts extension IDs scattered
around the codebase.
BUG=467808, 526708
Review URL: https://codereview.chromium.org/1329033002
Cr-Commit-Position: refs/heads/master@{#347847}
roll libyuv from r1475 to r1478 for new J420 function.
J420ToABGR is impliemented using I420ToABGR with a jpeg color matrix parameter.
BUG=libyuv:470
Review URL: https://codereview.chromium.org/1321023006
Cr-Commit-Position: refs/heads/master@{#347846}
Roll src/third_party/WebKit dd364bc:46b16a4 (svn 201942:201943)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd364bc..46b16a4
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1320563005
Cr-Commit-Position: refs/heads/master@{#347845}
Fix GetFramebufferAttachmentParameteriv command handling.
Blink side CL: https://codereview.chromium.org/1303343009/
BUG=527249
TEST=conformance2/state/gl-object-get-calls.html related parts pass
[email protected]
Review URL: https://codereview.chromium.org/1319453010
Cr-Commit-Position: refs/heads/master@{#347844}
Roll src/third_party/WebKit b34cb4e:dd364bc (svn 201941:201942)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b34cb4e..dd364bc
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312833012
Cr-Commit-Position: refs/heads/master@{#347843}
Correct PROCESS_BASIC_INFORMATION for 64 bit Windows.
Based on the structure given at https://msdn.microsoft.com/en-us/library/windows/desktop/ms684280(v=vs.85).aspx.
BUG=528450
Review URL: https://codereview.chromium.org/1328703003
Cr-Commit-Position: refs/heads/master@{#347842}
Pretty print field trials
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1308693013
Cr-Commit-Position: refs/heads/master@{#347841}
[Sync] Remove static methods on SyncedWindowDelegate.
Before, two static methods (GetAll and FindByID) were declared
on SyncedWindowDelegate but defined in platform specific files.
Now, those methods exist on SyncedWindowDelegatesGetter so
they can use polymorphism for platform specificity.
SyncedTabDelegate was the biggest challenge since it is not
really accessible when constructed to pass the getter in.
Instead, the SyncedWindowDelegatesGetter is set in
SyncedTabDelegate::ImplFromWebContents, before anything
else uses the object as a SyncedTabDelegate.
This CL is a prerequisite to componentizing SyncedWindowDelegate
and SyncedWindowDelegatesGetter.
BUG=512472
Review URL: https://codereview.chromium.org/1310373009
Cr-Commit-Position: refs/heads/master@{#347840}
Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ )
Reason for revert:
Caused check_licenses to fail:
https://build.chromium.org/p/chromium/builders/Linux/builds/66701
Original issue's description:
> Fix typo in install-sysroot.py
>
> install-sysroot.py was intended to default to installing
> the sysroot ia32, but within this script 'i386' is used to
> refer to this architecture.
>
> This most likely went unnoticed since the ia32 builder
> either use branding=Official, or explicitly set
> use_sysroot=1, or have a complete set of packages for
> cross building on the host system.
>
> BUG=504446
>
> Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406
> Cr-Commit-Position: refs/heads/master@{#347821}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1315773003
Cr-Commit-Position: refs/heads/master@{#347839}
sandbox/linux/bpf_dsl: eliminate implicit dependency on C++ compiler behavior
For the expression F(G(), H()), C++ does not guarantee whether G() or
H() will be evaluated first. Apparently the system compiler on Chrome
OS makes a different decision than on Ubuntu, which causes the golden
file tests introduced by https://crrev.com/1306723002 (which were
generated on Ubuntu) to fail on Chrome OS.
Easy fix: rewrite the expression as
g = G()
h = H()
F(g, h)
to avoid any compiler behavior dependency.
BUG=529480
Review URL: https://codereview.chromium.org/1327693005
Cr-Commit-Position: refs/heads/master@{#347838}
Revert of [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException. (patchset #2 id:20001 of https://codereview.chromium.org/1328093006/ )
Reason for revert:
somehow managed to break Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/30632/steps/telemetry_unittests/logs/stdio
Original issue's description:
> [Android][telemetry] Break logging deadlock when attempting to log an AppCrashException.
>
> BUG=
>
> Committed: https://crrev.com/e1bf30fc53406ba3bc1b302e87ecda6e3ad2025d
> Cr-Commit-Position: refs/heads/master@{#347816}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1314953011
Cr-Commit-Position: refs/heads/master@{#347837}
Roll src/third_party/WebKit 3e944fd:b34cb4e (svn 201938:201941)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e944fd..b34cb4e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329143005
Cr-Commit-Position: refs/heads/master@{#347836}
Use DCHECK_CURRENTLY_ON in content/
Review URL: https://codereview.chromium.org/1312843012
Cr-Commit-Position: refs/heads/master@{#347835}
Add HSTS preload list submissions as of 2015-09-08.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1320983006
Cr-Commit-Position: refs/heads/master@{#347834}
Add ability for a BubbleReference to update the BubbleUI.
BubbleManager doesn't always know when to update a bubble.
Ex: Bubble needs to change label from "Translating..." to "Translated".
Also fix naming from UI -> Ui
BUG=496955
Review URL: https://codereview.chromium.org/1310483003
Cr-Commit-Position: refs/heads/master@{#347833}
Switch EME content browser tests to unprefixed EME.
Prefixed EME is deprecated.
BUG=451117
Review URL: https://codereview.chromium.org/1322443005
Cr-Commit-Position: refs/heads/master@{#347832}
Implement an openssl version of a QUIC ProofSource.
BUG=525144,514472
Review URL: https://codereview.chromium.org/1309813003
Cr-Commit-Position: refs/heads/master@{#347831}
Roll src/third_party/skia 87a5c9f:036fd8e
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87a5c9f..036fd8e
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
036fd8e [email protected] Added TestCreate for SkComposeShader; will pick two random child procs that don't have children of their own. This prevents creating an arbitrarily large tree of procs. Also, it will choose a random coefficient mode for the xfermode.
894a2e4 [email protected] skia: Initialize value passed to GetShaderiv in GLBench
925979f [email protected] Make SkGraphics::Term a no-op, stop calling it.
Review URL: https://codereview.chromium.org/1323153003
Cr-Commit-Position: refs/heads/master@{#347830}
Fix use after free in SearchResultTileItemView
BUG=528325
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1313353007
Cr-Commit-Position: refs/heads/master@{#347829}
Roll src/third_party/WebKit c30c899:3e944fd (svn 201935:201938)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c30c899..3e944fd
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1328313003
Cr-Commit-Position: refs/heads/master@{#347828}
[Telemetry] Set telemetry's run_test verbosity to 3
BUG=457446
Review URL: https://codereview.chromium.org/1318003007
Cr-Commit-Position: refs/heads/master@{#347827}
base: Fix an inefficiency in base::Pickle that caused extraneous allocations.
The Resize() method is supposed to be passed the size of the payload, not
including the header. In the copy constructor, it was being passed the size of
the payload plus the header.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1327523006 .
Cr-Commit-Position: refs/heads/master@{#347826}
Roll src/third_party/WebKit a717754:c30c899 (svn 201933:201935)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a717754..c30c899
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319263003
Cr-Commit-Position: refs/heads/master@{#347825}
Proposing new CHROMIUM_sync_point API.
BUG=514815
Review URL: https://codereview.chromium.org/1323263005
Cr-Commit-Position: refs/heads/master@{#347824}
Merge ChromeMainDelegateStagingAndroid into ChromeMainDelegateAndroid.
A follow-up CL will delete the remnants of
ChromeMainDelegateStagingAndroid once downstream dependencies have been
updated.
BUG=526335
Review URL: https://codereview.chromium.org/1320253002
Cr-Commit-Position: refs/heads/master@{#347823}
Stop processing menuListValueChanged events.
This event gets fired upon the popup button that hosts the menulist. In processing this event, we output feedback that stomps on a focus event (which targets the desired selected menulist option).
BUG=525648
Review URL: https://codereview.chromium.org/1321823004
Cr-Commit-Position: refs/heads/master@{#347822}
Fix typo in install-sysroot.py
install-sysroot.py was intended to default to installing
the sysroot ia32, but within this script 'i386' is used to
refer to this architecture.
This most likely went unnoticed since the ia32 builder
either use branding=Official, or explicitly set
use_sysroot=1, or have a complete set of packages for
cross building on the host system.
BUG=504446
Review URL: https://codereview.chromium.org/1317973005
Cr-Commit-Position: refs/heads/master@{#347821}
Pass a BubbleReference to BubbleUI::Show.
Moved the BubbleReference to its own file to avoid having to include
bubble_manager.h everywhere.
The BubbleUI needs to be able to notify the bubble manager when it needs
to be closed.
BUG=496955
Review URL: https://codereview.chromium.org/1323133002
Cr-Commit-Position: refs/heads/master@{#347820}
[Mac] Remove extraneous Bookmarks menu from menu bar when running apps from launcher.
When Chrome is closed, opening a bookmark app from the app launcher on
Mac leads to an additional Bookmarks menu appearing on the left of the
Mac menu bar. The issue only manifests itself under these exact
circumstances.
The problem appears to be caused by a bug in AppKit. Calling setSubmenu
on a *hidden* NSMenuItem with a *different* NSMenu to the current
submenu leads to the NSMenuItem becoming non-hidden. This precise
situation occurs when caching the bookmark menu on Mac, which is done to
improve profile switching performance.
This CL removes the extra Bookmarks menu by saving the hidden state of
the menu prior to caching, setting the menu to be visible, allowing the
existing caching to run, and then resetting the hidden state once
caching is complete. It is insufficient to skip setting the menu to be
visible in this process.
BUG=497813
Review URL: https://codereview.chromium.org/1308983009
Cr-Commit-Position: refs/heads/master@{#347819}
roll libyuv from r1475 to r1480.
includes new functionality of J420ToABGR and H420ToARGB/ABGR.
[email protected]
BUG=libyuv:488
Review URL: https://codereview.chromium.org/1315893005
Cr-Commit-Position: refs/heads/master@{#347818}
[NaCl SDK] Add msan support to SDK build system
Also fix config name for asan builds
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
Review URL: https://codereview.chromium.org/1331443008
Cr-Commit-Position: refs/heads/master@{#347817}
[Android][telemetry] Break logging deadlock when attempting to log an AppCrashException.
BUG=
Review URL: https://codereview.chromium.org/1328093006
Cr-Commit-Position: refs/heads/master@{#347816}
[Telemetry] Update pyfakefs to latest revision.
BUG=https://github.com/jmcgeheeiv/pyfakefs/issues/50
Review URL: https://codereview.chromium.org/1313163007
Cr-Commit-Position: refs/heads/master@{#347815}
Implemented HEVC video demuxing and parsing
Chromecast team is interested in adding HEVC/H265 video codec support. Since we are using hardware decoders on our platforms, we don't need to add software decoder, but we still need to be able to demux and parse HEVC in mp4 containers. HEVC is very similar to H264 in many aspects, so we can reuse a lot of the existing H264 functionality.
BUG=454948
Review URL: https://codereview.chromium.org/816353010
Cr-Commit-Position: refs/heads/master@{#347814}
Update the alignment of the chrome://apps theme attribution when theme is installed
This CL updates the alignment of the theme attribution on any open
chrome://apps pages when the user installs a new theme.
BUG=523497
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/1312163007
Cr-Commit-Position: refs/heads/master@{#347813}
android: Include insets_f.h where gfx::InsetsF is used.
TBR=jdduke
BUG=342848
Review URL: https://codereview.chromium.org/1330843003
Cr-Commit-Position: refs/heads/master@{#347812}
Fix incorrect expectations for GLES CTS on Intel.
[email protected]
BUG=490149
Review URL: https://codereview.chromium.org/1323253005
Cr-Commit-Position: refs/heads/master@{#347811}
Video to canvas: don't draw if a SkImage can't be created.
Skia can return nullptr from NewFromAdoptedTexture and NewFromYUVTexturesCopy after
a context loss.
If this happens SkCanvasVideoRenderer should not draw anything instead of crashing.
BUG=526615
Review URL: https://codereview.chromium.org/1325173005
Cr-Commit-Position: refs/heads/master@{#347810}
extensions: Avoid using WebString in Dispatcher::Dispatcher()
We can't use Blink public APIs in the constructor of Dispatcher because
Blink is not initialized when we create Dispatcher. See [1] for details.
[1] https://codereview.chromium.org/1182083006/
BUG=501171
Review URL: https://codereview.chromium.org/1309843013
Cr-Commit-Position: refs/heads/master@{#347809}
[Android] Move perf utilities into devil.
BUG=476719
Review URL: https://codereview.chromium.org/1332603002
Cr-Commit-Position: refs/heads/master@{#347808}
Create MemoryPressureStatsCollector.
This helper class will be used by the MemoryPressureMonitor to report memory pressure statistics via UMA.
BUG=520962
Review URL: https://codereview.chromium.org/1310043004
Cr-Commit-Position: refs/heads/master@{#347807}
Revert "Reset the default browser choice on windows 10 on install"
This reverts commit 9ccf9d86e29f16aabdad65e13b09ac372355f18b.
BUG=521191
[email protected]
Review URL: https://codereview.chromium.org/1315233005
Cr-Commit-Position: refs/heads/master@{#347806}
Mac Overlays: Allow multiple overlays with sandwich strategy.
Allow multiple videos to be promoted to overlays, as long as they don't overlap.
BUG=527222
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1304053016
Cr-Commit-Position: refs/heads/master@{#347805}
Roll cacheinvalidation to include bug fixes for client release 20150819.
BUG=529225
Review URL: https://codereview.chromium.org/1330833003
Cr-Commit-Position: refs/heads/master@{#347804}
Roll src/third_party/WebKit 309ac7a:a717754 (svn 201932:201933)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/309ac7a..a717754
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1318113005
Cr-Commit-Position: refs/heads/master@{#347803}
Roll src/third_party/skia 8fd97ea:87a5c9f
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8fd97ea..87a5c9f
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
87a5c9f [email protected] Add number of draws to GrGpu stats
00c3252 [email protected] Update documentation of colors on Status.
0f0af23 [email protected] Revert[2] of "switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE"
90e8ab7 [email protected] Re-enable nvpr text rendering in DM.
54a6b1a [email protected] emitChild() used to generate a mangled outputColor based on the parent's outputColor; now it just accepts an outputColor string. It's now up to the programmer to declare outputColors if needed before emitting child code.
43fe618 [email protected] refactor parts of SkGr.cpp for use by SkImages
bbd4018 [email protected] Port SkLazyFnPtr users to SkOncePtr.
a5f46e1 [email protected] Comments: note existance of SkImage::newShader next to CreateBitmapShader
189aef7 [email protected] Create module system for VisualBench
Review URL: https://codereview.chromium.org/1319273004
Cr-Commit-Position: refs/heads/master@{#347802}
Avoid implicit conversion from Rect to RectF in events and gfx tests.
TBR=sky
BUG=342848
Review URL: https://codereview.chromium.org/1328283003
Cr-Commit-Position: refs/heads/master@{#347801}
Roll src/third_party/WebKit aaeefad:309ac7a (svn 201930:201932)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aaeefad..309ac7a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1324553005
Cr-Commit-Position: refs/heads/master@{#347800}
Use DCHECK_CURRENTLY_ON() in chrome/ and android_webview/
Review URL: https://codereview.chromium.org/1329093002
Cr-Commit-Position: refs/heads/master@{#347799}
New illustrations for the Data Reduction Proxy promo
Also, fix the button alignment.
BUG=470433, 527266
Review URL: https://codereview.chromium.org/1303213004
Cr-Commit-Position: refs/heads/master@{#347798}
Disable BrowserTest.InterstitialCancelsGuestViewDialogs on Site Isolation FYI bots.
BUG=529353
[email protected]
Review URL: https://codereview.chromium.org/1326893007
Cr-Commit-Position: refs/heads/master@{#347797}
[Password Manger] Fix bug in link to passwords.google.com
BUG=524397
Review URL: https://codereview.chromium.org/1312533005
Cr-Commit-Position: refs/heads/master@{#347796}
Roll src/third_party/WebKit a3ab63c:aaeefad (svn 201929:201930)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a3ab63c..aaeefad
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1328263003
Cr-Commit-Position: refs/heads/master@{#347795}
Prevent the user from hiding all Task Manager columns.
Currently it's possible to hide all of the columns in the Task Manager
table. The Task Manager is useless with zero visible columns, so this
change ensures that at least one column remains visible at all times.
BUG=518914
Review URL: https://codereview.chromium.org/1296693002
Cr-Commit-Position: refs/heads/master@{#347794}
Update V8 to version 4.7.38.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/70cb6205..ab6f1f01
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309513009
Cr-Commit-Position: refs/heads/master@{#347793}
Update suppression for IPC::SyncChannel::CreateSyncMessageFilter leak.
Commit 7cfec02ca8fe958b480bab2a92c6914d05d76f29 changed the signature
for content::GpuChannelHost::Create, breaking the old suppression entry.
BUG=345432
[email protected]
Review URL: https://codereview.chromium.org/1316753004
Cr-Commit-Position: refs/heads/master@{#347792}
cast_benchmarks: Fix broken behavior
There were two main problems with cast_benchmarks:
1. The initialization tried to use a RunLoop to handle
the closure of initialization of audio and video. Since this
is a fake task runner, the program would just wait forever
given the task runner was not executing tasks.
2. The RTP timestamps on all the frames were fixed! This could
have been a result of modifications to other pieces of code
while cast_benchmarks was unused
This CL fixes both the above behaviors and additionally leverages
existing default config API used by the cast_simulator.
There is a lot of potential cleanup here, but we dont attempt that
in this CL.
BUG=527853
Test=Ran cast_benchmark with --single_run and in full vector space
without any options to completion.
Review URL: https://codereview.chromium.org/1311403006
Cr-Commit-Position: refs/heads/master@{#347791}
Roll src/third_party/WebKit 53410a9:a3ab63c (svn 201928:201929)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/53410a9..a3ab63c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319573004
Cr-Commit-Position: refs/heads/master@{#347790}
[Media Router] Show different icons based on sink type.
BUG=526251, 501452
Review URL: https://codereview.chromium.org/1309623005
Cr-Commit-Position: refs/heads/master@{#347789}
Adding UMA for SRT prompt from menu
BUG=503607
Review URL: https://codereview.chromium.org/1330733002
Cr-Commit-Position: refs/heads/master@{#347788}
[Android] Set permission when installing apks.
To support M testing, we need to explicilty grant permissions to apps
when we install them.
BUG=
Review URL: https://codereview.chromium.org/1316803004
Cr-Commit-Position: refs/heads/master@{#347787}
Make UsbEventRouter depend explicitly on EventRouter.
UsbEventRouter's existing dependencies should already create an
implicit dependency on EventRouter but this is the only explanation I
can see for the crashes reported in UsbEventRouter::Shutdown.
BUG=528498
Review URL: https://codereview.chromium.org/1329003002
Cr-Commit-Position: refs/heads/master@{#347786}
[Android] Improve error messaging for amp failures.
Currently, it will double report test failures, and
will improperly report crashes without a long message.
BUG=512305
Review URL: https://codereview.chromium.org/1311783005
Cr-Commit-Position: refs/heads/master@{#347785}
Fix OOPIF rendering on HiDPI devices.
When creating the backing surface, we need to multiply the frame rect by
the device scale factor.
BUG=522237
Review URL: https://codereview.chromium.org/1325063005
Cr-Commit-Position: refs/heads/master@{#347784}
Avoid rendering the performance overlay on unmappable video frames
BUG=529376
Review URL: https://codereview.chromium.org/1330833002
Cr-Commit-Position: refs/heads/master@{#347783}
webapps: allow usage of recents icon on splash screen
If the recents icon is big enough such that it can be shown
on the splash screen, then utilize it.
This CL establishes allows the worst possible case where
there is no splash screen icon available to display so we
use the recents icon as long as it is not too sub-optimal.
This CL is an intermediary one before
https://codereview.chromium.org/1308533006 which allows the
splash screen image to be all sizes inbetween the ideal
size and the lowest possible size of 48dp (which is the
same as the home screen/recents icon size).
BUG=508627
Review URL: https://codereview.chromium.org/1326643007
Cr-Commit-Position: refs/heads/master@{#347782}
Refactor AudioParameters member setting.
Permit AudioParameters members to be set individually. Allows us to:
- Cut back to the one non-default constructor which is frequently used.
- Remove a bunch of boilerplate in the common case of updating one
member.
- Make adding future optional members (e.g. mic_positions)
transparent to most callers.
Maintain the Reset method but remove the channels parameter to have it
mirror the constructor.
Make it clear that channels_ is only required to be set explicitly with
CHANNEL_LAYOUT_DISCRETE.
BUG=497001
Review URL: https://codereview.chromium.org/1304973005
Cr-Commit-Position: refs/heads/master@{#347781}
MediaCodecPlayer - preroll and reconfiguration fixes
Now the decision to do preroll is controlled by two variables:
the preroll timestamp, which is set by seek, and the MediaCodec
state "is_prepared" - it is considered prepared after we got
the output buffer.
With these changes preroll won't be done again if the decoder is
already prerolled (thus there might be a case where only one
stream is prerolled, e.g. the one that is drained, for 2 streams
A/V playback). Also the preroll timestamp is not reset when the
preroll starts, only when it is done or flush happens.
Added more unit tests for decoder reconfiguration.
BUG=407577
Review URL: https://codereview.chromium.org/1312103006
Cr-Commit-Position: refs/heads/master@{#347780}
Misc cleanup for RenderWidgetHostImpl.
- Remove unneeded forward-decl and includes
- Switch typedef to using statements
- Use stdint int types
- Mark a couple member variables const
- Simplify if (foo) { ... return; } else {} patterns
- Fix lint errors
Review URL: https://codereview.chromium.org/1304093007
Cr-Commit-Position: refs/heads/master@{#347779}
Roll src/third_party/skia 1512029:8fd97ea
Manual roll with build fixes.
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1512029..8fd97ea
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Commits in this roll:
8fd97ea [email protected] Revert of Provides multiple implementations of Android's SkBitmapRegionDecoder
ff390c9 [email protected] Revert of switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE
Review URL: https://codereview.chromium.org/1309373006
Cr-Commit-Position: refs/heads/master@{#347778}
Roll src/third_party/WebKit f7d0f96:53410a9 (svn 201927:201928)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f7d0f96..53410a9
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1308543008
Cr-Commit-Position: refs/heads/master@{#347777}
Fix BrowserMainLoop NSS ifdef for iOS.
This file is still built on iOS. No bots broke but to avoid accidentally
changing behavior, use the more general USE_NSS_CERTS || !USE_OPENSSL
condition.
BUG=528468
Review URL: https://codereview.chromium.org/1328253002
Cr-Commit-Position: refs/heads/master@{#347776}
Refactor connection_security into SecurityStateModel
This CL refactors the connection_security namespace (a namespace of
statics) into SecurityStateModel, a class attached to a WebContents that
drives the security UI for that WebContents. The SecurityStateModel
provides high-level security information about a page or request, with
the goal of reducing code duplication across various security UI
elements.
In this first CL, I've introduced the SecurityStateModel and am using it
to drive the omnibox/lock icon, but have not yet adapted WebsiteSettings
to use a SecurityStateModel.
BUG=528034
[email protected]
Review URL: https://codereview.chromium.org/1314843007
Cr-Commit-Position: refs/heads/master@{#347775}
Implement PlatformUtil::OpenExternal() so that mailto: can work
Clicking a mailto link inside an iframe doesn't work on android.
This is because PlatformUtil::OpenExternal() is not implemented.
This CL adds the implementation for this feature.
BUG=523491
Review URL: https://codereview.chromium.org/1310873003
Cr-Commit-Position: refs/heads/master@{#347774}
Roll src/third_party/WebKit ef4d70c:f7d0f96 (svn 201924:201927)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef4d70c..f7d0f96
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1303103008
Cr-Commit-Position: refs/heads/master@{#347773}
QUIC - Cancel loading of server config from disk cache if it takes longer
than 50ms. When we ran the initial experiments with 50ms as the timeout
QUIC performed better than when there is no cancellation. We always
cancel if disk read takes more than 0.25 RTT. This change puts an upper
bound for the cancellation time.
[email protected]
Review URL: https://codereview.chromium.org/1319453008
Cr-Commit-Position: refs/heads/master@{#347772}
media: Stop converting Rect to RectF implicitly in media_unittests.
TBR=dalecurtis
BUG=342848
Review URL: https://codereview.chromium.org/1305353012
Cr-Commit-Position: refs/heads/master@{#347771}
Plumb smooth scrolling in Chromium compositor
Android WebView uses android.widget.OverScroller#startScroll
implement pageUp/pageDown. Since blink internally knows how
to do a smooth scroll via page scale animation, WebView just
need to send an IPC to blink with the target position and
duration.
The blink change to support smooth scroll:
https://codereview.chromium.org/1251473003
BUG=378984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1251323002
Cr-Commit-Position: refs/heads/master@{#347770}
Infobar MD refresh: close button.
For now, like the find bar, there is no hover or pressed state (see crbug.com/523356)
BUG=520266
[email protected]
Review URL: https://codereview.chromium.org/1322583006
Cr-Commit-Position: refs/heads/master@{#347769}
[Custom tab]Fix a bug that clicking media notification opens blank tab
This CL lets Tab#createBringTabToFrontIntent() return null if the given
tab id belongs to a custom tab. A "clickable" notion is introduced here
to describe notifications that do not carry a content intent.
BUG=524855
Review URL: https://codereview.chromium.org/1328663003
Cr-Commit-Position: refs/heads/master@{#347768}
Use DCHECK_CURRENTLY_ON in extensions/
Review URL: https://codereview.chromium.org/1328173002
Cr-Commit-Position: refs/heads/master@{#347767}
Revert "BadMessage on unauthorized header request from renderer"
This reverts commit 41f132e4a0ed599b090ec1070451d970cb5bbbf4.
Had to manually revert this cause of the big upload size.
Context: https://codereview.chromium.org/1325533002/
BUG=528932,528942
Review URL: https://codereview.chromium.org/1320423012
Cr-Commit-Position: refs/heads/master@{#347766}
Revert of Re-enable renderer partial raster by default. (patchset #1 id:1 of https://codereview.chromium.org/1326103002/ )
Reason for revert:
Exposes caret invalidation bugs (http://crbug.com/528922).
Original issue's description:
> Re-enable renderer partial raster by default.
>
> If you see 1-pixel repainting issues with this CL in the blame list, it is
> likely at fault. This CL should revert cleanly if needed.
>
> BUG=492754
>
> Committed: https://crrev.com/f11aee0769a5a1d37ce4c601dcb2b27dd1338fa7
> Cr-Commit-Position: refs/heads/master@{#347307}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=492754,528922
Review URL: https://codereview.chromium.org/1329163002
Cr-Commit-Position: refs/heads/master@{#347765}
net/dns: Remove unneeded net_util.h includes from header files.
Usually it is only needed in source files because net_util.h is a collection
of free functions.
BUG=None
TEST=net_unittests
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1311353009
Cr-Commit-Position: refs/heads/master@{#347764}
Roll src/tools/swarming_client/ to 49f046853671bbd5ab65509a8049d36ac0224714.
$ git log 2866a2253..49f046853 --date=short --format='%ad %ae %s'
2015-09-03 maruel Fix isolated testing.
2015-09-03 maruel Revert "Isolated task support in Endpoints API: client side (3/3)" and fixes
2015-09-03 phajdan.jr Print JSON exception in json_request
2015-09-02 maruel Fix regression in 71063f71840: time format now includes microseconds.
2015-09-02 maruel Fix regression in 71063f71840: exit code handling for swarming.py.
2015-09-02 maruel Isolated task support in Endpoints API: client side (3/3)
2015-09-02 maruel Fix unicode support once for all.
2015-09-01 maruel Silence UnicodeEncodeError in make_tree_deleteable().
2015-08-12 maruel Add run_isolate.py --json flag.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1313783010
Cr-Commit-Position: refs/heads/master@{#347763}
Fix for race condition during Sync shutdown causing crash in NonUIDataTypeController
The fix is to access UserShare* via SyncService while on UI tread and
avoid accessing it later when it might already be destroyed.
BUG=528368
Review URL: https://codereview.chromium.org/1311473011
Cr-Commit-Position: refs/heads/master@{#347762}
Bypass QUIC proxy on ERR_MSG_TOO_BIG
BUG=526774
Review URL: https://codereview.chromium.org/1306813007
Cr-Commit-Position: refs/heads/master@{#347761}
Mac: Fix missing toolbar buttons focus ring on 10.8
Change toolbar buttons to be bordered to make the new style "automatic focus ring"
work on 10.8.
AppKit skipped the focus ring on these buttons because it's a button without a
border, image, or label.
Toolbar.xib changes: checked the "Bordered" checkboxes on all the toolbar buttons
(back, forward, reload, home, wrench).
BUG=527662
Review URL: https://codereview.chromium.org/1308993009
Cr-Commit-Position: refs/heads/master@{#347760}
dbus/debugd: Add method for org.chromium.debugd.GetPerfOutput
This method will replace org.chromium.debug.GetRandomPerfOutput.
Unfortunately, the C++ method name "GetPerfOutput" was used for
the DBus method name "GetRandomPerfOutput", which means the most
appropriate name is taken. Since the DBus method "GetPerfOutput" will
soon be removed, I've overloaded the C++ method "GetPerfOutput" to call the
DBus method "GetPerfOutput". The difference betweeen these two methods
is that the new one takes a vector<string> containing the perf arguments
to call, whereas the old one makes a random selection of perf arguments.
The two methods have the same output type, and so share the
OnGetPerfOutput callback, and the GetPerfOutputCallback type.
Review URL: https://codereview.chromium.org/1332453002
Cr-Commit-Position: refs/heads/master@{#347759}
[Media Router] Filter non-display MediaRoutes before sending them to the UI.
Modify UIMediaRoutesObserver to filter out non-display routes before sending
them to MediaRouterWebUIMessageHandler for JS version and sending to WebUI.
This ensures no non-display routes will make it to WebUI.
Move declaration of UIMediaRoutesObserver to media_router_ui.h so it can be
tested.
BUG=510300
Review URL: https://codereview.chromium.org/1305143005
Cr-Commit-Position: refs/heads/master@{#347758}
Roll src/third_party/WebKit 1aa260f:ef4d70c (svn 201923:201924)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1aa260f..ef4d70c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1315873004
Cr-Commit-Position: refs/heads/master@{#347757}
Show hosted app requests to extensions
BUG=526413
TEST=browser_tests --gtest_filter=ExtensionWebRequestApiTest.HostedAppRequest
Review URL: https://codereview.chromium.org/1311543005
Cr-Commit-Position: refs/heads/master@{#347756}
Fix for --ignore-gpu-blacklist not working from flags UI on Linux
This bug was caused by https://codereview.chromium.org/1215703006/:
chrome://flags sets --ignore-gpu-blacklist in PreCreateThreads, so
GpuDataManagerImpl must be initialized after that.
This is a revert of 4261a351be92e315109dcc12134e0e55667ca4eb plus
an alternative approach to the original CL's problem: we now defer
GPU process creation on Cast so that setting Cast GL strings in
GpuDataManager doesn't race against GPU process creation.
BUG=509336
Review URL: https://codereview.chromium.org/1320443014
Cr-Commit-Position: refs/heads/master@{#347755}
Don't clobber the download metadata file when downloading a file for which we don't send a ClientDownloadRequest.
BUG=23788643
Review URL: https://codereview.chromium.org/1320713004
Cr-Commit-Position: refs/heads/master@{#347754}
Add VideoFrame::CreateZeroInitializedFrame
BUG=514759, 526441
Review URL: https://codereview.chromium.org/1313413010
Cr-Commit-Position: refs/heads/master@{#347753}
NaCl: Update revision in DEPS, 495bd47 -> 2bc21a8
This pulls in the following Native Client changes:
edd8d54: ([email protected]) Fix declared signature of _user_start to match nacl_entry_func_t
e861ae4: ([email protected]) Mark Clang-based toolchain as such and vice-versa
1621328: ([email protected]) Force SCons to use GN-built IRT for running GN tests
b873d9c: ([email protected]) Remove TODO about using NaClBlockIfCommandChannelExists in sel_main_chrome
5f48066: ([email protected]) Update revision for PNaCl
476db67: ([email protected]) [MIPS] Save $gp before jumping into NaClSyscallCSegHook
d3cf7ab: ([email protected]) Use committer list from chrome-infra-auth
16647d4: ([email protected]) Remove most remnants of Android from DEPS and bot setup
6ddc26e: ([email protected]) Update chrome_rev
2bc21a8: ([email protected]) Switch to using the pinned GN //build files from chromium.
Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/495bd47427a144f90c2340890c265bb39eccca12..2bc21a8056f49f45d183d58481277d889097ad06
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/1308893004
Cr-Commit-Position: refs/heads/master@{#347752}
Rename Media Router route "title" field to "description".
Renaming field for uniformity.
Review URL: https://codereview.chromium.org/1303993003
Cr-Commit-Position: refs/heads/master@{#347751}
No StrictMode for stable on userdebug devices.
Some users always run userdebug android builds. Since they
likely do not work on Chrome and are not dogfooding, it
is annoying for them to see StrictMode violations in Chrome
on Android and not be able to do anything about it.
BUG=527851,149471
Review URL: https://codereview.chromium.org/1330053002
Cr-Commit-Position: refs/heads/master@{#347750}
Restore old bookmark bar folders on win non-MD.
Still available on win with --top-chrome-md flag, and used elsewhere by
default. This behavior approved by sgabriel.
BUG=527923
Review URL: https://codereview.chromium.org/1319283004
Cr-Commit-Position: refs/heads/master@{#347749}
Vectorize register protocol handler icon.
BUG=505953
Review URL: https://codereview.chromium.org/1322583005
Cr-Commit-Position: refs/heads/master@{#347748}
[Contextual Search] Adjust spacing according to spec
BUG=528332
Review URL: https://codereview.chromium.org/1308163008
Cr-Commit-Position: refs/heads/master@{#347747}
Revert of [Courgette] Adding CourgetteConfig singleton and --experimental flag. (patchset #5 id:80001 of https://chromiumcodereview.appspot.com/1306193004/ )
Reason for revert:
The original CL assumes Courgette had to deal with forward/backward compatibility issues.
Turns out that (as seen in http://crbug.com/459505):
- Courgette executable is shipped with new releases.
- This allows Courgette workflow to proceed without being tied down to legacy.
These new (to huangs@) facts render the original CL redundant.
Original issue's description:
> [Courgette] Adding CourgetteConfig singleton and --experimental flag.
>
> This prepare for upcoming experiments to reduce patch size. We want to
> avoid disrupting existing functionality.
>
> Committed: https://crrev.com/fc0511d9067759336f42d04e918e8a3ce0b84376
> Cr-Commit-Position: refs/heads/master@{#346746}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1323263007
Cr-Commit-Position: refs/heads/master@{#347746}
Roll src/third_party/WebKit 632e3d5:1aa260f (svn 201922:201923)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/632e3d5..1aa260f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1315253004
Cr-Commit-Position: refs/heads/master@{#347745}
Set LoFi prefs after DRP prefs are set
InitializeLoFiPrefs() checks if data reduction proxy is
enabled or not. IsDataReductionProxyEnabled() determines
if DRP is enabled by reading spdy_proxy_auth_enabled_.
So, LoFi prefs should be initialized after
spdy_proxy_auth_enabled_ has been initialized.
Initialization of spdy_proxy_auth_enabled_ happens
in DataReductionProxySettings::InitPrefMembers().
So, we should call InitializeLoFiPrefs() after
InitPrefMembers(). Also, design-wise, it seems better to
initialize LoFi prefs after DRP prefs are initialized.
BUG=528527
Review URL: https://codereview.chromium.org/1330583003
Cr-Commit-Position: refs/heads/master@{#347744}
[Media Router] Remove obsolete code from media_router_bindings.js
- Remove unused functions onRouteResponseError/onRouteResponseReceived
- Remove redundant argument from onRoutesUpdated. Note it can be
further simplified by removing the input arg if we end up not needing
a MediaSink object in a MediaRoute.
BUG=527100
Review URL: https://codereview.chromium.org/1323723003
Cr-Commit-Position: refs/heads/master@{#347743}
Android Chromoting: Add photosphere for the background.
- Replace skybox with photosphere for the backgroud drawing.
- Disable the VertexAttribArray when finishs drawing object in opengl
BUG=516871
Review URL: https://codereview.chromium.org/1327963003
Cr-Commit-Position: refs/heads/master@{#347742}
Add myself to extensions webui OWNERS
Review URL: https://codereview.chromium.org/1330033005
Cr-Commit-Position: refs/heads/master@{#347741}
* Changing crash report limitation logic to have more control over extreme cases.
Introducing total limit of 5MB uploads per week on cellular connection and increasing the individual report limit to b3 2MB instead of previous 1MB.
All limitations apply when user is in the experimental group and on cellular connection.
Note that this limitations will not affect median users as they upload only 1 report per month approximately of size 400KB.
* In order to fix warnings on MinidumpUploadCallable.java this CL also upgrades logging lib for this file from android.util.Log to org.chromium.base.Log along with necessary changes.
BUG=455847
Review URL: https://codereview.chromium.org/1317013003
Cr-Commit-Position: refs/heads/master@{#347740}
[Chromecast] Lowers CastService out of chromecast/browser/.
This creates a chromecast/service/ directory with no dependencies on content/.
[email protected],[email protected]
BUG=internal b/23761158
Review URL: https://codereview.chromium.org/1319273003
Cr-Commit-Position: refs/heads/master@{#347739}
Roll src/third_party/WebKit 8cc7417:632e3d5 (svn 201921:201922)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8cc7417..632e3d5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333523003
Cr-Commit-Position: refs/heads/master@{#347738}
Add a network handler to ServiceWorkerDevToolsAgentHost.
BUG=525713
Review URL: https://codereview.chromium.org/1314513009
Cr-Commit-Position: refs/heads/master@{#347737}
mac: Add a hack to condition_variable_posix.cc to avoid a crash.
The Darwin pthreads subsystem has a bug that can cause the program to crash if a
conditional variable is destroyed after it has been signalled, but before it has
been waited on. This hack is a solution proposed by Apple in its own developer
forums.
BUG=517681
Review URL: https://codereview.chromium.org/1323293005
Cr-Commit-Position: refs/heads/master@{#347736}
Move setting access policy to WebView
This way anyone creating a WebView doesn't have to remember this.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1305393007
Cr-Commit-Position: refs/heads/master@{#347735}
Delete unused preconnect API implementation
Corresponding with https://codereview.chromium.org/1321193004/
this is the Chrome side of the same unused API calls deletion.
BUG=
Review URL: https://codereview.chromium.org/1317743008
Cr-Commit-Position: refs/heads/master@{#347734}
Revert of Fix cronet crash on calling IsDataReductionProxyEnabled (patchset #4 id:60001 of https://codereview.chromium.org/1308923003/ )
Reason for revert:
This does not help in fixing the cronet crash. Also, it is
calling data_reduction_proxy_service->GetWeakPtr() after
data_reduction_proxy_service has been Passed. After the
ownership is passed, data_reduction_proxy_service is
null.
Original issue's description:
> Fix cronet crash on calling IsDataReductionProxyEnabled
>
> BUG=526776
>
> Committed: https://crrev.com/3b63265bd7f9004f215f40b80bb1f506294e7788
> Cr-Commit-Position: refs/heads/master@{#347295}
BUG=528527
Review URL: https://codereview.chromium.org/1304983007
Cr-Commit-Position: refs/heads/master@{#347733}
Move failed renderer launches to a separate counter in stability proto.
Corresponding server side change is cl/102361136.
BUG=528355,526198
TEST=unit_tests
Review URL: https://codereview.chromium.org/1306753008
Cr-Commit-Position: refs/heads/master@{#347732}
Roll src/third_party/WebKit bb129e6:8cc7417 (svn 201920:201921)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bb129e6..8cc7417
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1313353008
Cr-Commit-Position: refs/heads/master@{#347731}
iOS Autofill: Port several heuristics improvements.
https://crrev.com/315688 : Do not infer labels from divs with
autofillable fields.
https://crrev.com/316172 : Improve inferring label from divs
https://crrev.com/320860 : Search for standalone label tags while
looking through divs.
https://crrev.com/321249 : Improve the order of heuristics to apply when
inferring labels.
BUG=427614
Review URL: https://codereview.chromium.org/1314513010
Cr-Commit-Position: refs/heads/master@{#347730}
Disable newly added test BrowserTest.ChangeDisplayMode
It's flaky per http://chromium-try-flakes.appspot.com/search?q=BrowserTest.ChangeDisplayMode, which is all the try runs which the test failed with 3 retries, and then passed in another try run for the same patchset (i.e. not patch's fault).
BUG=471703
[email protected]
Review URL: https://codereview.chromium.org/1315323009
Cr-Commit-Position: refs/heads/master@{#347729}
Make isPluginDocument() checks for main frames OOPIF-friendly.
Several places assumed that the top frame on a page will always be a
LocalFrame and made calls like
frame->view()->mainFrame()->document().isPluginDocument(). This
breaks with --site-per-process, where the top frame may be a
RemoteFrame with no document().
A few uses of isPluginDocument() on the main frame already checked
whether the main frame is a LocalFrame first, and this CL cleans up
the remaining references to do the same.
BUG=526207
Review URL: https://codereview.chromium.org/1305213006
Cr-Commit-Position: refs/heads/master@{#347728}
Revert of Fix crash on signing in when Google Play Services is out of date. (patchset #6 id:100001 of https://codereview.chromium.org/1321633002/ )
Reason for revert:
The sign in tests are failing downstream and this appears to be the most likely candidate.
Original issue's description:
> Fix crash on signing in when Google Play Services is out of date.
>
> BUG=525289
>
> Committed: https://crrev.com/3e39b48298400c91d2310c1d04fae1b7c6f9bcb3
> Cr-Commit-Position: refs/heads/master@{#347373}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525289
Review URL: https://codereview.chromium.org/1330043002
Cr-Commit-Position: refs/heads/master@{#347727}
Roll src/third_party/WebKit 84c89bc:bb129e6 (svn 201918:201920)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/84c89bc..bb129e6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1311873005
Cr-Commit-Position: refs/heads/master@{#347726}
Roll src/third_party/WebKit faa558b:84c89bc (svn 201917:201918)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/faa558b..84c89bc
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1323943013
Cr-Commit-Position: refs/heads/master@{#347725}
Converts BrowserCommand to an enum class
And makes naming match style guide.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1312203005
Cr-Commit-Position: refs/heads/master@{#347724}
view-manager: Update focused view before triggering focus-change observer callbacks.
It is necessary to actually change the focus before calling the focus-change
observer callbacks to make sure the callbacks get the correct value from
focus-related API calls (e.g. View::HasFocus() etc.).
BUG=none
Review URL: https://codereview.chromium.org/1314823013
Cr-Commit-Position: refs/heads/master@{#347723}
Treat U+2028 and U+2029 as special code points when escaping for JSON.
BUG=525832
Review URL: https://codereview.chromium.org/1325253002
Cr-Commit-Position: refs/heads/master@{#347722}
view-manager: Make sure event is dispatched to the correct ViewTree.
If a target view is an embed root, then dispatch the event to the embedded ViewTree,
not the owner.
BUG=none
Review URL: https://codereview.chromium.org/1313653006
Cr-Commit-Position: refs/heads/master@{#347721}
[Android] Add a custom pylintrc for build/android/.
The default depot_tools pylintrc disables some checks that we can
reasonably enable in build/android/. This CL does so.
BUG=
Review URL: https://codereview.chromium.org/1315743004
Cr-Commit-Position: refs/heads/master@{#347720}
Fixed crx_location for auto launched kiosk apps.
Changed crx_location for managed auto launched kiosk apps to EXTERNAL_POLICY.
BUG=522047
Review URL: https://codereview.chromium.org/1300333002
Cr-Commit-Position: refs/heads/master@{#347719}
Add impression/click pings to MostLikely suggestions on SuggestionsService/LocalNTP
BUG=514752
Review URL: https://codereview.chromium.org/1312103005
Cr-Commit-Position: refs/heads/master@{#347718}
Make password suggestion dropdown on password fields less annoying
This CL makes suggestion dropdown on password field (not username field) will be shown only when password field is empty or it was autofilled. So if the user wants to type password manually we will not bother her.
BUG=522689
Review URL: https://codereview.chromium.org/1323993006
Cr-Commit-Position: refs/heads/master@{#347717}
Roll src/third_party/WebKit 7534ff6:faa558b (svn 201916:201917)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7534ff6..faa558b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1326593007
Cr-Commit-Position: refs/heads/master@{#347716}
[Extension Page UI] chrome://extensions after closing overlay
When overlays(command overlay for now) on extension ui page are closed,
the url should be changed to chrome://extensions.
TEST=browser_tests --gtest_filter=SettingsCommandsExtensionSettingsWebUITest.extensionSettingsUri
BUG=525621
[email protected]
Review URL: https://codereview.chromium.org/1330563003
Cr-Commit-Position: refs/heads/master@{#347715}
[Extensions Toolbar] Take out the blue hot dogs
The blue hotdogs were used to show an overflowed action wanted to run, but these
have been deemed very weird. Take them out.
BUG=417441
[email protected]
Review URL: https://codereview.chromium.org/1331473002
Cr-Commit-Position: refs/heads/master@{#347714}
[Android] Minor fixes for device_status_check.
This includes:
- catching IOError on failure to reset USB
- adding newlines to the bot status output
BUG=
Review URL: https://codereview.chromium.org/1314123005
Cr-Commit-Position: refs/heads/master@{#347713}
Disable dromaeo.jslibmodifyjquery on Windows 8
BUG=529330
NOTRY=true
Review URL: https://codereview.chromium.org/1325053007
Cr-Commit-Position: refs/heads/master@{#347712}
Add --verbose flag to incremental_install.py
BUG=520082
Review URL: https://codereview.chromium.org/1326813003
Cr-Commit-Position: refs/heads/master@{#347711}
[iOS] Re-enable JSON parsing in PromoResourceService
Following the WebResource componentization, the parsing of JSON resource
has to be updated on iOS.
The JSON parsing code was removed:
https://codereview.chromium.org/1291543004/diff/120001/ios/chrome/browser/web_resource/ios_web_resource_service.cc
This CL re-adds the code, adapted to the new architecture.
BUG=526299
Review URL: https://codereview.chromium.org/1310173009
Cr-Commit-Position: refs/heads/master@{#347710}
Switch a USE_OPENSSL to OS_ANDROID.
No change in behavior, except that if this code is built in a configuration where
we don't know how to instantiate ClientCertStore, we should hit that #error and
find out.
BUG=none
Review URL: https://codereview.chromium.org/1311223005
Cr-Commit-Position: refs/heads/master@{#347709}
Change Ash frame colours for material design
Change colours of the material design browser
frame for Ash in both regular and
incognito modes.
BUG=525076,527921
TEST=manual
R=oshima
TBR=pkotwicz
Review URL: https://codereview.chromium.org/1308413008
Cr-Commit-Position: refs/heads/master@{#347708}
Roll src/third_party/WebKit 07d4530:7534ff6 (svn 201915:201916)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/07d4530..7534ff6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1303323006
Cr-Commit-Position: refs/heads/master@{#347707}
Roll src/third_party/WebKit dbece11:07d4530 (svn 201914:201915)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dbece11..07d4530
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1322723005
Cr-Commit-Position: refs/heads/master@{#347706}
Revert of command_buffer: Implement EXT_multisample_compatibility (patchset #9 id:160001 of https://codereview.chromium.org/1231673006/ )
Reason for revert:
Breaking the EXTMultisampleCompatibilityTest.DrawAndResolve test on AMD.
EXTMultisampleCompatibilityTest.DrawAndResolve:
../../gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:208: Failure
Value of: r
Actual: '\x80' (128)
Expected: 255u
Which is: 255
../../gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:209: Failure
Value of: g
Actual: '\x80' (128)
Expected: 0u
Which is: 0
../../gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:225: Failure
Value of: r
Actual: '\x80' (128)
Expected: 255u
Which is: 255
../../gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:227: Failure
Value of: b
Actual: '\x80' (128)
Expected: 0u
Which is: 0
Original issue's description:
> command_buffer: Implement EXT_multisample_compatibility
>
> Implement EXT_multisample_compatibility OpenGL ES extension in command
> buffer.
>
> Skia needs this in order to enable and disable multisampling when
> using GL path rendering.
>
> BUG=506765
>
> Committed: https://crrev.com/e3237bbb682e52f92d5bd18dcab672677e4e3bc4
> Cr-Commit-Position: refs/heads/master@{#346847}
>
> Committed: https://crrev.com/28e57fb8caf8c0daf4be0692777aa9229cfdaa8b
> Cr-Commit-Position: refs/heads/master@{#347390}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=506765, 529315
Review URL: https://codereview.chromium.org/1333493004
Cr-Commit-Position: refs/heads/master@{#347705}
Replacing constant returned values with constant references.
BUG=393155
Review URL: https://codereview.chromium.org/1310633007
Cr-Commit-Position: refs/heads/master@{#347704}
Update Crashpad to 28c5da90807588a0abfbd4e76f0289c3fca068f7
86419cf7881b Port CrashReportUploadThread to Windows
4f2d2018de3d Fix port of CrashReportUploadThread to windows
6645a6924025 asan: Fix invalid memory access in
UniversalExceptionRaise()
b1d78336004e Use EXPECT_STREQ(a, b) when a and b are both const char*
3b6e5613cb99 asan: Bypass the “nearby PC” check
899821d4c791 Fix -Winconsistent-missing-override in
CrashReportUploadThread
5064aeb78477 Use -[NSNumber numberWithDouble:] for doubles
34aef02cc725 ubsan: Don’t call v[0] on empty vectors
b70d3029874f Add a few more expectations to crashpad_util_test
InRangeCast
f21b7401713c asan: Don’t pad the CrashpadInfo struct with a red zone
78bba8808b9b win: Pass WINHTTP_FLAG_SECURE when necessary
3ef04d14f2fd Implement ModuleSnapshotWin::UUID
754cc3609caa win x86: a few trivial compile fixes when
GYP_DEFINES=target_arch=ia32
6978bf7646df win: Crash handler server
5de461e8c8d9 Refactor handler/main for Windows, implement
CrashHandlerExceptionServer
9086d25ce8b0 Don’t trigger EXC_CORPSE_NOTIFY on OS X 10.11
1c7843bd44b9 Fix relative path in crashpad_handler.ad
28c5da908075 win: Add version to client registration request
Review URL: https://codereview.chromium.org/1316783009
Cr-Commit-Position: refs/heads/master@{#347703}
Roll src/third_party/WebKit b19e84f:dbece11 (svn 201912:201914)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b19e84f..dbece11
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1322323007
Cr-Commit-Position: refs/heads/master@{#347702}
Componentize CertificateErrorReport and CertificateErrorReporter
BUG=516697
Committed: https://crrev.com/93df64e3cdc40d6a30f7944e211e334ce1880cf7
Cr-Commit-Position: refs/heads/master@{#347551}
Review URL: https://codereview.chromium.org/1302423003
Cr-Commit-Position: refs/heads/master@{#347701}
Roll src/third_party/skia a3434d8:1512029
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a3434d8..1512029
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
1512029 [email protected] skia: use msaaConfigAttribList for SkOSWindow_win
Review URL: https://codereview.chromium.org/1311343006
Cr-Commit-Position: refs/heads/master@{#347700}
Use country code to get country specific suggestion if default search engine is Google
BUG=528188
Review URL: https://codereview.chromium.org/1326493004
Cr-Commit-Position: refs/heads/master@{#347699}
CREDENTIAL: TLS errors block returning credentials.
We should not return credentials to pages with TLS errors, in the same
way that we don't autofill credentials in these scenarios.
BUG=529154
[email protected]
Review URL: https://codereview.chromium.org/1316663005
Cr-Commit-Position: refs/heads/master@{#347698}
Roll src/third_party/WebKit 9799b44:b19e84f (svn 201910:201912)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9799b44..b19e84f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329083003
Cr-Commit-Position: refs/heads/master@{#347697}
Remove use of JSONReader::DeprecatedRead from components/
Remove use of deprecated function DeprecatedRead from components/
Also made some refactoring
components/webcrypto/test/test_helpers.cc/h
BUG=523194
Review URL: https://codereview.chromium.org/1323923002
Cr-Commit-Position: refs/heads/master@{#347696}
Roll WebRTC 9867:9890, Libjingle 9867:9885
WebRTC 9867:9890
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/22fd889..e3f2eba
Libjingle 9867:9885
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/ca717fa..531209a
Additional Chromium changes:
Updated MockTransportChannel to compile with the latest webrtc changes.
[email protected], [email protected], [email protected]
BUG=
Review URL: https://codereview.chromium.org/1317973006
Cr-Commit-Position: refs/heads/master@{#347695}
CREDENTIAL: Teach the API about affiliated credentials.
This patch injects AffiliatedMatchHelper logic into the Credential
Manager API's dispatcher code so that calls to `get()` will correctly
populate the list of credentials which we offer to users with those that
they've saved on affiliated platforms.
BUG=528312
[email protected]
Review URL: https://codereview.chromium.org/1311323006
Cr-Commit-Position: refs/heads/master@{#347694}
Remove use of JSONReader::DeprecatedRead from content
Remove use of deprecated function DeprecatedRead from content
BUG=523194
Review URL: https://codereview.chromium.org/1329053002
Cr-Commit-Position: refs/heads/master@{#347693}
Update V8 to version 4.7.37.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a774ef3e..70cb6205
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330823003
Cr-Commit-Position: refs/heads/master@{#347692}
Roll src/third_party/WebKit bd02550:9799b44 (svn 201908:201910)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bd02550..9799b44
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1311913008
Cr-Commit-Position: refs/heads/master@{#347691}
ConstrainedWindowSheetController doesn't manage visibility by itself.
Class WebContentsModalDialogManager calls
SingleWebContentsDialogManager::Hide() and Show() when
an user switches between tabs, therefore special method
[ConstrainedWindowSheetController parentViewDidBecomeActive]
seems excessive and it was removed in this CL.
BUG=None
Review URL: https://codereview.chromium.org/1279493004
Cr-Commit-Position: refs/heads/master@{#347690}
Implement Tier 2 of Cookie handling for Mirror on WKBling.
AccountConsistencyService now adds the X-CHROME-CONNECTED cookie on all
the Google domains the user shows intent to navigate to.
The set of those domains is backed by a pref to correctly clean up all
domains if necessary after a restart.
Details (Google only): go/bling-mirror-cookie-handling
BUG=513650
Review URL: https://codereview.chromium.org/1324373002
Cr-Commit-Position: refs/heads/master@{#347689}
Roll src/third_party/WebKit 836a548:bd02550 (svn 201907:201908)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/836a548..bd02550
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1328183003
Cr-Commit-Position: refs/heads/master@{#347688}
Roll src/third_party/WebKit adac218:836a548 (svn 201906:201907)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/adac218..836a548
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1323573006
Cr-Commit-Position: refs/heads/master@{#347687}
Stop building components dependending on //content on iOS.
Chrome for iOS should not depends on //content, so stop compiling
components/metrics/{gpu,profiler} on iOS as they depends on //content.
BUG=None
Review URL: https://codereview.chromium.org/1309143005
Cr-Commit-Position: refs/heads/master@{#347686}
Roll src/third_party/WebKit 4f41dc7:adac218 (svn 201905:201906)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4f41dc7..adac218
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330763003
Cr-Commit-Position: refs/heads/master@{#347685}
Sort file list in ios/chrome/ios_chrome.gyp.
Sorted with "tools/sort_sources.py ios/chrome/ios_chrome.gyp".
BUG=None
Review URL: https://codereview.chromium.org/1314473009
Cr-Commit-Position: refs/heads/master@{#347684}
Allow bookmark app icons to be resized down arbitrarily.
This change removes the restriction that icons for bookmark apps are
only allowed to be resized at most once to the nearest smallest size.
Originally, this requirement was made to reduce the number of resizes,
and allow the display code to resize icons as necessary. However, this
complicated the icon logic for a small reduction in the size of bookmark
apps. This CL removes the restriction and allows icons to be resized
downwards as many times as is necessary to fill all of the required
icon sizes necessary for a bookmark app. This addresses a bug where
the bookmark app installation bubble would have no icon displayed on
views platforms when a 48x48px icon was not provided.
Large icons are explicitly resized down to fill any required
smaller icon sizes that are missing. Icons are generated where no large
enough icon exists to resize. Additional tests are added to verify the
new icon generation and resizing behaviour.
BUG=526900
Review URL: https://codereview.chromium.org/1311353013
Cr-Commit-Position: refs/heads/master@{#347683}
Fix name of constants in ios/chrome/app/strings/ios_strings.grd.
All iOS specific strings should be referenced by a constant named
IDS_IOS_* so fix the newly introduced constants to use the correct
name.
BUG=None
Review URL: https://codereview.chromium.org/1330813003
Cr-Commit-Position: refs/heads/master@{#347682}
Roll src/third_party/WebKit d1347e4:4f41dc7 (svn 201904:201905)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d1347e4..4f41dc7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1316903004
Cr-Commit-Position: refs/heads/master@{#347681}
Roll src/third_party/WebKit 758ca3e:d1347e4 (svn 201903:201904)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/758ca3e..d1347e4
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329113002
Cr-Commit-Position: refs/heads/master@{#347680}
Correctly escape headers and URL in GaiaAuthFetcherIOS.
BUG=495597
Review URL: https://codereview.chromium.org/1313413011
Cr-Commit-Position: refs/heads/master@{#347679}
Roll src/third_party/WebKit 8021ac7:758ca3e (svn 201902:201903)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8021ac7..758ca3e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333493003
Cr-Commit-Position: refs/heads/master@{#347678}
Roll src/third_party/WebKit 60b23f3:8021ac7 (svn 201901:201902)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/60b23f3..8021ac7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1328193002
Cr-Commit-Position: refs/heads/master@{#347677}
Roll src/third_party/WebKit 9008866:60b23f3 (svn 201900:201901)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9008866..60b23f3
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1305063009
Cr-Commit-Position: refs/heads/master@{#347676}
Ensure favicon images are correctly used and downloaded when syncing bookmark apps.
Currently, bookmark apps use a FaviconDownloader to grab icon images
from a site when installed for the first time. When a bookmark app
syncs, it uses a BitmapFetcher on the second machine to grab icon
images. BitmapFetcher is not able to extract multiple images from
a favicon file. This incongruity leads to a number of issues:
1. Bookmark apps added on one machine may fail to sync to another
machine. On sync, the second machine tries to download icons, but
some specified icons cannot be downloaded as they are stuck in the
favicon file and not extracted properly. Combined with a recent fix to
stop generating bookmark app icons when a larger alternative is
available (https://codereview.chromium.org/1165643003), this leads
to an error where app installation fails due to missing icon files
(not downloaded and not generated because a larger one is there).
2. Bookmark apps added on one machine successfully sync to another
machine, but the icons are not synced and degraded auto-generated
icons are used in their place (icon of the required size couldn't be
downloaded, no larger icon was available, so all icons were generated).
This CL addresses all of these icon-related issues by using a
FaviconDownloader in place of BitmapFetcher. This necessitates
spinning up a web contents process to download icons during bookmark
app sync.
BUG=523515
Review URL: https://codereview.chromium.org/1306683004
Cr-Commit-Position: refs/heads/master@{#347675}
Roll src/third_party/WebKit 92881d2:9008866 (svn 201898:201900)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/92881d2..9008866
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333493002
Cr-Commit-Position: refs/heads/master@{#347674}
Roll src/third_party/WebKit 68b6636:92881d2 (svn 201897:201898)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/68b6636..92881d2
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1323253004
Cr-Commit-Position: refs/heads/master@{#347673}
Roll src/third_party/WebKit e78a7fa:68b6636 (svn 201896:201897)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e78a7fa..68b6636
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319693003
Cr-Commit-Position: refs/heads/master@{#347672}
Roll src/third_party/WebKit 423841c:e78a7fa (svn 201895:201896)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/423841c..e78a7fa
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332563002
Cr-Commit-Position: refs/heads/master@{#347671}
Roll src/third_party/WebKit c9077c8:423841c (svn 201894:201895)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c9077c8..423841c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312493008
Cr-Commit-Position: refs/heads/master@{#347670}
Roll src/third_party/WebKit 35964dc:c9077c8 (svn 201893:201894)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/35964dc..c9077c8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312643009
Cr-Commit-Position: refs/heads/master@{#347669}
Roll src/third_party/WebKit e56ddba:35964dc (svn 201892:201893)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e56ddba..35964dc
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1305973012
Cr-Commit-Position: refs/heads/master@{#347668}
Roll src/third_party/WebKit bf3b982:e56ddba (svn 201891:201892)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bf3b982..e56ddba
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1306893009
Cr-Commit-Position: refs/heads/master@{#347667}
Roll src/third_party/WebKit 2c51279:bf3b982 (svn 201890:201891)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2c51279..bf3b982
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1330803002
Cr-Commit-Position: refs/heads/master@{#347666}
[pywebsocket] Migrate to GitHub: update DEPS and README.chromium
DEPS:
- URL is moved to the mirror from GitHub.
- Revision is updated to the latest.
Changes: https://chromium.googlesource.com/external/github.com/google/pywebsocket.git/+log/cdc6a19..09d8427
README.chromium:
- URL is moved to GitHub.
- License File is updated due to file name change in pywebsocket.
- License is renamed to pass the presubmit test.
Review URL: https://codereview.chromium.org/1314013006
Cr-Commit-Position: refs/heads/master@{#347665}
Update V8 to version 4.7.36.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/882a8747..a774ef3e
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329693004
Cr-Commit-Position: refs/heads/master@{#347664}
Roll src/third_party/WebKit 6fc95f1:2c51279 (svn 201889:201890)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6fc95f1..2c51279
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1313543003
Cr-Commit-Position: refs/heads/master@{#347663}
Roll src/third_party/WebKit 54680e5:6fc95f1 (svn 201886:201889)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/54680e5..6fc95f1
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1301393013
Cr-Commit-Position: refs/heads/master@{#347662}
content/gpu: Groundwork for gpu stream priorities.
This CL adds support for gpu stream priorities. A stream gets its
priority when the first command buffer on that stream is created. The
stream exists until the last command buffer on that stream exists.
There are three priority levels: real-time, normal and low. Creating
streams with real-time priority requires the gpu channel to have that
capability.
There's some error checking so that clients do not set an incorrect
priority on an existing stream.
BUG=514813
[email protected]
Review URL: https://codereview.chromium.org/1329513002
Cr-Commit-Position: refs/heads/master@{#347661}
Stop and unregister all service workers in the end of SW related LayoutTests.
BUG=506039
Committed: https://crrev.com/c5d15a6f621b4ec469f24733148ca2107fea68d0
Cr-Commit-Position: refs/heads/master@{#347358}
Review URL: https://codereview.chromium.org/1323533002
Cr-Commit-Position: refs/heads/master@{#347660}
Updating trunk VERSION from 2504.0 to 2505.0
Cr-Commit-Position: refs/heads/master@{#347659}
Roll src/third_party/WebKit b129516:54680e5 (svn 201885:201886)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b129516..54680e5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1322133004
Cr-Commit-Position: refs/heads/master@{#347658}
Reland: Gallery: skip to write thumbnail data if there isn't enough space.
The original CL is the following and it has an issue that unit test
fails on Debug build. With this CL, in addition to the original CL,
fixed the unit test by measuring the thumbnail size at runtime.
The original CL:
patch from issue 1304933004 at patchset 60001 (http://crrev.com/1304933004#ps60001)
Committed: https://crrev.com/475854c54374f59e702784c423e8fd45cf822542
Cr-Commit-Position: refs/heads/master@{#346820}
Reverted by: crrev.com/1309983007
BUG=526904
TEST=browser_tests:GalleryJsTest.ExifEncoderTest
Review URL: https://codereview.chromium.org/1330643004
Cr-Commit-Position: refs/heads/master@{#347657}
Roll src/third_party/WebKit 0908604:b129516 (svn 201883:201885)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0908604..b129516
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1332533002
Cr-Commit-Position: refs/heads/master@{#347656}
Roll src/third_party/WebKit c7df6b9:0908604 (svn 201882:201883)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7df6b9..0908604
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325043004
Cr-Commit-Position: refs/heads/master@{#347655}
Roll src/third_party/WebKit 35c22cf:c7df6b9 (svn 201881:201882)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/35c22cf..c7df6b9
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1314873007
Cr-Commit-Position: refs/heads/master@{#347654}
Update generateMipmap to ES3 semantic in command buffer
ES3 supports generateMipmap works with partial levels. This CL makes
generateMipmap can use base level texture image to generate texture
image for other level.
BUG=429053
Review URL: https://codereview.chromium.org/1320443006
Cr-Commit-Position: refs/heads/master@{#347653}
Fix memory leak of PreviewModeClient in PDF
Previously, in print preview, we would construct a new PreviewModeClient and
pass it to the PDFEngine, however the PDFEngine does not maintain ownership
of the client passed in. Instead OutOfProcessInstance should maintain ownership
which is fixed by this CL.
BUG=522286
Review URL: https://codereview.chromium.org/1323943011
Cr-Commit-Position: refs/heads/master@{#347652}
Update material design icons for incognito and omnibiox
Update some assets used for the material
design incognito mode in Ash and the
omnibox dropdown.
BUG=518937,528075
TEST=manual
Review URL: https://codereview.chromium.org/1324763006
Cr-Commit-Position: refs/heads/master@{#347651}
Roll src/third_party/WebKit 8cbbf4a:35c22cf (svn 201880:201881)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8cbbf4a..35c22cf
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1313003006
Cr-Commit-Position: refs/heads/master@{#347650}
Revert of Implement "Look Up In Dictionary" context menu item asynchronously. (patchset #6 id:100001 of https://codereview.chromium.org/1313553006/ )
Reason for revert:
Caused regression crbug.com/528929.
Original issue's description:
> Implement "Look Up In Dictionary" context menu item asynchronously. (OS X)
>
> Reduces the number of callers of the synchronous IPC in
> TextInputClientMac::GetAttributedSubstringFromRange() (so that eventually we can
> remove it).
>
> BUG=121917
> TEST=Verified "Look Up in Dictionary" by context menu feature works well.
>
> Committed: https://crrev.com/cabb6815f85f0e6297a55eb313a8e11373e2da9e
> Cr-Commit-Position: refs/heads/master@{#347306}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=121917
Review URL: https://codereview.chromium.org/1306713007
Cr-Commit-Position: refs/heads/master@{#347649}
Roll src/third_party/WebKit d9b1051:8cbbf4a (svn 201879:201880)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d9b1051..8cbbf4a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309343007
Cr-Commit-Position: refs/heads/master@{#347648}
Remove the ContentSettingsTypeHistogram enum
Previously when adding a new ContentSettingsType it was required to add a new
entry to ContentSettingsTypeHistogram. However, we don't really need a new
enum, we just need an ordering of ContentSettingsTypes to give an index which
will be used as the histogram value. This CL replaces the enum with an array of
ContentSettingsTypes that gives this order. This is required as we head toward
making ContentSettingsType not be an enum.
Upon reflection, it would be even better to use a sparse histogram here with
the histogram value being a hash of the content settings type name. However
this would require more work (mainly to write a tool to update histograms.xml)
so its left for the future.
BUG=512683
Review URL: https://codereview.chromium.org/1315383005
Cr-Commit-Position: refs/heads/master@{#347647}
Split page-capturing code into PageInfo class.
In preparation for migrating page-capturing logic to
ChromeRenderFrameObserver, organize all of it into
a separate clas, PageInfo.
R=dcheng,thakis
BUG=521166
Review URL: https://codereview.chromium.org/1307173010
Cr-Commit-Position: refs/heads/master@{#347646}
Roll src/third_party/skia 2d126b5:a3434d8
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2d126b5..a3434d8
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
a3434d8 [email protected] Add skstd::unique_ptr and use it.
Review URL: https://codereview.chromium.org/1306953008
Cr-Commit-Position: refs/heads/master@{#347645}
Roll src/third_party/WebKit d41951c:d9b1051 (svn 201878:201879)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d41951c..d9b1051
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1324223005
Cr-Commit-Position: refs/heads/master@{#347644}
Update V8 to version 4.7.35.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/23c97e70..882a8747
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1313513011
Cr-Commit-Position: refs/heads/master@{#347643}
Roll src/third_party/skia 10522ff:2d126b5
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/10522ff..2d126b5
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
2d126b5 [email protected] switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE
Review URL: https://codereview.chromium.org/1307363010
Cr-Commit-Position: refs/heads/master@{#347642}
Roll src/third_party/WebKit 95e1018:d41951c (svn 201877:201878)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/95e1018..d41951c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1302183009
Cr-Commit-Position: refs/heads/master@{#347641}
remove SK_SUPPORT_LEGACY_SHADERBITMAPTYPE flag
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1307163006
Cr-Commit-Position: refs/heads/master@{#347640}
Roll src/third_party/skia 3e9a452:10522ff
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3e9a452..10522ff
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
10522ff [email protected] Scanline decoding for gifs
Review URL: https://codereview.chromium.org/1326703005
Cr-Commit-Position: refs/heads/master@{#347639}
Add an ONC property for disabling net technologies
This CL maps an ONC property for disabling network technologies.
BUG=426390
Review URL: https://codereview.chromium.org/1306813008
Cr-Commit-Position: refs/heads/master@{#347638}
win/clang: Try to fix build after https://codereview.chromium.org/1243293003
chrome\browser\safe_browsing\incident_reporting\platform_state_store.cc(139,11):
error: enumeration value 'NUM_RESULTS' not handled in switch
[-Werror,-Wswitch]
switch (result) {
^
BUG=82385,496744
TBR=grt
Review URL: https://codereview.chromium.org/1320093003 .
Cr-Commit-Position: refs/heads/master@{#347637}
ExtensionSyncService: Properly differentiate between "pending install" and "pending update".
For pending updates, store only the new version, as opposed to the whole ExtensionSyncData.
Also includes some semi-related cleanup: Make a bunch of tests use the public ExtensionSyncService interface, rather than relying on private implementation methods.
BUG=None
Review URL: https://codereview.chromium.org/1321963002
Cr-Commit-Position: refs/heads/master@{#347636}
Roll src/third_party/WebKit f1202ca:95e1018 (svn 201875:201877)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f1202ca..95e1018
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325803004
Cr-Commit-Position: refs/heads/master@{#347635}
[Password Manager tests] Add ability to notify about new failed tests via email.
Adds ability to send warning about failed tests.
BUG=435249
Review URL: https://codereview.chromium.org/1215953005
Cr-Commit-Position: refs/heads/master@{#347634}
asABitmap is deprecated, switch over to (simpler) isABitmap
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=vmpstr
Review URL: https://codereview.chromium.org/1303033002
Cr-Commit-Position: refs/heads/master@{#347633}
Improve comment for Preferences::ApplyPreferences().
There was a bad "in" which I replaced by an "if" and at that occasion
I polished the comment a bit more.
BUG=None
Review URL: https://codereview.chromium.org/1314433013
Cr-Commit-Position: refs/heads/master@{#347632}
Delete Chrome state in registry on uninstall when the user profile is being deleted.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/1327793004
Cr-Commit-Position: refs/heads/master@{#347631}
Roll src/third_party/WebKit 7227c61:f1202ca (svn 201874:201875)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7227c61..f1202ca
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329063003
Cr-Commit-Position: refs/heads/master@{#347630}
[Smart Lock] Implements the condition for controlling Save prompt first run experience.
BUG=527702
Review URL: https://codereview.chromium.org/1310503007
Cr-Commit-Position: refs/heads/master@{#347629}
Roll src/third_party/WebKit 56db356:7227c61 (svn 201871:201874)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/56db356..7227c61
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1315403005
Cr-Commit-Position: refs/heads/master@{#347628}
Expose PasswordStore's AffiliatedMatchHelper.
The Credential Manager API needs access to the affiliated match helper
in order to synthesize credentials for an origin. This patch exposes the
member by changing |HasAffiliatedMatchHelper()| into a getter. No
behavioral changes in this patch.
BUG=528312
Review URL: https://codereview.chromium.org/1333453002
Cr-Commit-Position: refs/heads/master@{#347627}
[Smart lock] Add experiment that will guard settings reconciliation.
Because of complex logic of password manager settings reconciliations we will first run it as an experiment and check that it went smooth and release it to all users afterwards.
BUG=517087
Review URL: https://codereview.chromium.org/1322383003
Cr-Commit-Position: refs/heads/master@{#347626}
webapps: add splashscreen for installed webapps
This is the pinacle of splashscreen: it builds upon the background
color patches, the WebappDataStorage and IconDownload patches and
brings them together to display a splashscreen prior to webapps
loading.
This is a part of a group of CLs:
(1) https://codereview.chromium.org/1286973003
(2) https://codereview.chromium.org/1310223002
(3) https://codereview.chromium.org/1239923002 (this)
BUG=508627
Review URL: https://codereview.chromium.org/1239923002
Cr-Commit-Position: refs/heads/master@{#347625}
Don't rely on getAssets() as a convenience wrapper for getResources().getAssets().
This works around an Android framework inconsistency that arises when
applyOverrideConfiguration is called, resulting in getAssets() and
getResources().getAssets() returning different AssetManager instances.
BUG=521753
Review URL: https://codereview.chromium.org/1325313002
Cr-Commit-Position: refs/heads/master@{#347624}
Roll src/third_party/WebKit 35143b2:56db356 (svn 201870:201871)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/35143b2..56db356
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1329973002
Cr-Commit-Position: refs/heads/master@{#347623}
Add method for suppressing MemoryPressureListener notifications
This patch adds a new static method to MemoryPressureListener which can
be used to start/stop suppressing memory pressure notifications:
// Start suppressing memory pressure notifications.
MemoryPressureListener::SetNotificationsSuppressed(true);
// Stop suppressing memory pressure notifications.
MemoryPressureListener::SetNotificationsSuppressed(false);
This patch represents the first step towards implementing a DevTools API
for suppressing and simulating memory pressure signals in Chrome. The
main use case for this feature is to enforce consistent conditions
across memory measurements. See https://goo.gl/cZFdH3 for more details.
BUG=516776
Review URL: https://codereview.chromium.org/1312163003
Cr-Commit-Position: refs/heads/master@{#347622}
Roll src/third_party/WebKit 82fe6bd:35143b2 (svn 201869:201870)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/82fe6bd..35143b2
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1304073011
Cr-Commit-Position: refs/heads/master@{#347621}
Set display mode for browser
This CL provides content::WebContentsDelegate::GetDisplayMode() implementation for the Browser class.
BUG=521999
BUG=471703
Review URL: https://codereview.chromium.org/1323733002
Cr-Commit-Position: refs/heads/master@{#347620}
Use IAudioClock for QPC timestamps whenever we can for audio input on Windows.
GetBuffer() can return device timestamps that are unreliable (far off from QPC values) and can jump backwards in time.
This reproduced for me while testing with Jabra and Plantronics USB headsets on my Win7 box.
BUG=528894
Review URL: https://codereview.chromium.org/1326713004
Cr-Commit-Position: refs/heads/master@{#347619}
Updating XTBs based on .GRDs from branch master
Cr-Commit-Position: refs/heads/master@{#347618}
Handle X-Chrome-Manage-Accounts header on WKBling.
This adds a policy decider on each web state that monitors Gaia
responses, and notifies its delegate when a response contains the
X-Chrome-Manage-Accounts header.
BUG=513650
Review URL: https://codereview.chromium.org/1324003002
Cr-Commit-Position: refs/heads/master@{#347617}
Roll src/third_party/WebKit 9bbec1c:82fe6bd (svn 201867:201869)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9bbec1c..82fe6bd
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319343005
Cr-Commit-Position: refs/heads/master@{#347616}
CREDENTIAL: Tighten zero-click requirements.
We should sign-in without user mediation only in completely unambigious
circumstances. This patch tighten things up a bit such that multiple
'PasswordForm' objects _always_ prevents zero-click sign-in, rather than
the existing behavior which prevents iff more than one form has the
'skip_zero_click' property set to 'false'.
BUG=528855
[email protected]
Review URL: https://codereview.chromium.org/1312773006
Cr-Commit-Position: refs/heads/master@{#347615}
Roll src/third_party/WebKit 416491e:9bbec1c (svn 201866:201867)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/416491e..9bbec1c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1319793004
Cr-Commit-Position: refs/heads/master@{#347614}
Roll src/third_party/WebKit 92f769a:416491e (svn 201865:201866)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/92f769a..416491e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1315983011
Cr-Commit-Position: refs/heads/master@{#347613}
[iOS] Implementation of HttpUserAgentSettings
BUG=513323
Review URL: https://codereview.chromium.org/1313453005
Cr-Commit-Position: refs/heads/master@{#347612}
Fix dependency on //content from //components/favicon/core.
The favicon component is layered and //components/favicon/core must not
depends on //content. Fix the layering violation by using injection to
pass the base::TaskRunner to use via LargeIconServiceFactory.
The bad dependency was introduced in http://crrev.com/1122103003.
BUG=467712,429756,459705
Review URL: https://codereview.chromium.org/1315953006
Cr-Commit-Position: refs/heads/master@{#347611}
Roll src/third_party/WebKit b49b480:92f769a (svn 201864:201865)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b49b480..92f769a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1317623010
Cr-Commit-Position: refs/heads/master@{#347610}
Roll src/tools/gyp 2b17e0b26..5d01a8cda
https://chromium.googlesource.com/external/gyp.git/+log/2b17e0b26a93e8c9758c23aec6c554da4ca8f0a9..5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c
To pick up the revert in https://chromium.googlesource.com/external/gyp/+/5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c
that breaks certain projects sharing the Chromium build toolchain.
BUG=
Review URL: https://codereview.chromium.org/1304983008
Cr-Commit-Position: refs/heads/master@{#347609}
Roll src/third_party/WebKit f840046:b49b480 (svn 201863:201864)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f840046..b49b480
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1333443003
Cr-Commit-Position: refs/heads/master@{#347608}
Roll src/third_party/WebKit 8cd3347:f840046 (svn 201862:201863)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8cd3347..f840046
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1314613005
Cr-Commit-Position: refs/heads/master@{#347607}
Roll src/third_party/WebKit e047fcc:8cd3347 (svn 201860:201862)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e047fcc..8cd3347
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1327013002
Cr-Commit-Position: refs/heads/master@{#347606}
Implement writing mic audio input data to file for debugging purposes.
This is enabled in chrome://webrtc-internals with the current "enable diagnostic audio recordings" checkbox. The user chooses a base filename, on which extensions are added as:
<base name>.<process id>.source_input.<stream id>.pcm
WebRTCInternals tells all RenderProcessHosts to enable recording, which in turn calls the AudioInputRenderHost. The AIRH tells all AudioInputControllers (if any) to enable recording and gives it a pointer to an AudioInputWriter.
When audio data reaches AIC it tells the AudioInputWriter to write the data to file.
When a new AudioInputController is created in AIRH, the recording status is checked, and if enabled it's enabled for the new AIC.
BUG=516584
NOTRY=true
Review URL: https://codereview.chromium.org/1272223003
Cr-Commit-Position: refs/heads/master@{#347605}
Roll src/third_party/WebKit 4a76155:e047fcc (svn 201859:201860)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a76155..e047fcc
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1316003005
Cr-Commit-Position: refs/heads/master@{#347604}
Roll src/third_party/WebKit 564e66f:4a76155 (svn 201858:201859)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/564e66f..4a76155
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1305083005
Cr-Commit-Position: refs/heads/master@{#347603}
Roll src/third_party/WebKit 7451a36:564e66f (svn 201856:201858)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7451a36..564e66f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1315643006
Cr-Commit-Position: refs/heads/master@{#347602}
Roll src/third_party/WebKit d4c9bdf:7451a36 (svn 201855:201856)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d4c9bdf..7451a36
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1303303004
Cr-Commit-Position: refs/heads/master@{#347601}
Roll src/third_party/WebKit c47bc3a:d4c9bdf (svn 201853:201855)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c47bc3a..d4c9bdf
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1315763005
Cr-Commit-Position: refs/heads/master@{#347600}
vda_unittest: Fix Flush() is not called when decoding is slow.
When |decode_calls_per_second_| is set (not 0), DecodeNextFragment()
will be called at the given rate. When decoding is slow, a
BitstreamBuffer may be released after the last DcodeNextFragment()
being called. In that case, decoder's Flush() will not be called,
and the test will hang forever.
To fix this issue, we call Flush() when all BitstreamBuffers are
processed in NotifyEndOfBitstreamBuffer().
BUG=439831
Test=Run the test on veyron_minnie
patch from issue 791573002 at patchset 80001 (http://crrev.com/791573002#ps80001)
Review URL: https://codereview.chromium.org/1321423004
Cr-Commit-Position: refs/heads/master@{#347599}
Unncessary 'View source code' option is enabled in context menu of the 'Pdf Viewer' app.
If we're viewing in a MimeHandlerViewGuest, that is we have plugin , view source should not be shown.
BUG=523254
Review URL: https://codereview.chromium.org/1305043003
Cr-Commit-Position: refs/heads/master@{#347598}
Material PDF: Variety of minor UI bugfixes
* Fix regression where dropdowns would not be sized correctly on first
open.
* Make page selector only accept numerical inputs
* Position top toolbar z-level above zoom toolbar
* Ellipsize long bookmark names
BUG=527776,527798,526981
Review URL: https://codereview.chromium.org/1310353003
Cr-Commit-Position: refs/heads/master@{#347597}
Update V8 to version 4.7.34.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5d6587c6..23c97e70
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1309623006
Cr-Commit-Position: refs/heads/master@{#347596}
Add MobileModerateBinding experiment to waterfall config
BUG=504634
Review URL: https://codereview.chromium.org/1318043006
Cr-Commit-Position: refs/heads/master@{#347595}
Roll src/third_party/WebKit 56f032d:c47bc3a (svn 201852:201853)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/56f032d..c47bc3a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1324343002
Cr-Commit-Position: refs/heads/master@{#347594}
Roll src/third_party/WebKit 98a4530:56f032d (svn 201851:201852)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/98a4530..56f032d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1323523004
Cr-Commit-Position: refs/heads/master@{#347593}
Remove CONTENT_SETTINGS_NUM_TYPES (part 1)
To make it possible to make ContentSettingsTypes no longer an enum we need to remove the occurrences of iterations over it. This CL makes WebsiteSettingsRegistry iterable and changes some iterations of NUM_TYPES to iterate over the registry instead. Some other occurrences have also been removed.
BUG=526932
Review URL: https://codereview.chromium.org/1312993002
Cr-Commit-Position: refs/heads/master@{#347592}
Simplify creating PasswordFormManager in its test
Adds PasswordFormManager in the most used configuration as a member and replaces the repeted local creation with this member.
Separated tests TestSendNotBlacklistedMessage and TestForceInclusionOfGeneratedPasswords into multiple tests.
BUG=520831
Review URL: https://codereview.chromium.org/1317113006
Cr-Commit-Position: refs/heads/master@{#347591}
Roll src/third_party/WebKit c58159c:98a4530 (svn 201850:201851)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c58159c..98a4530
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1323253003
Cr-Commit-Position: refs/heads/master@{#347590}
Roll src/third_party/skia e3330cf:3e9a452
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e3330cf..3e9a452
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
3e9a452 [email protected] Update SKP version
Review URL: https://codereview.chromium.org/1317623009
Cr-Commit-Position: refs/heads/master@{#347589}
Update V8 to version 4.7.33.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/98f92e83..5d6587c6
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1314433012
Cr-Commit-Position: refs/heads/master@{#347588}
Initialize blink in components_unittests when needed
Some tests in components_unittests depend on blink so they should
initialize blink before running tests.
BUG=501171
Review URL: https://codereview.chromium.org/1304973002
Cr-Commit-Position: refs/heads/master@{#347587}
Roll src/third_party/WebKit 3a70d9a:c58159c (svn 201848:201850)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3a70d9a..c58159c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1316303008
Cr-Commit-Position: refs/heads/master@{#347586}
Updating trunk VERSION from 2503.0 to 2504.0
Cr-Commit-Position: refs/heads/master@{#347585}
Roll src/third_party/WebKit 83b465e:3a70d9a (svn 201847:201848)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/83b465e..3a70d9a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1312813010
Cr-Commit-Position: refs/heads/master@{#347584}
Roll src/third_party/WebKit d39ea6f:83b465e (svn 201846:201847)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d39ea6f..83b465e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1322873003
Cr-Commit-Position: refs/heads/master@{#347583}
Update V8 to version 4.7.32.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cc200dae..98f92e83
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1325393002
Cr-Commit-Position: refs/heads/master@{#347582}
Render top chrome separators at 1px for material design
Render the top chrome separators for material
design at 1px regardless of the device scale factor.
This includes the top and bottom separators of the
detached bookmarks bar, the bottom separator of the
bookmarks bar, and the bottom separator of the toolbar.
Define and call the new static method
BrowserView::Paint1pxHorizontalLine() for
each of these cases.
BUG=525082
TEST=manual
Review URL: https://codereview.chromium.org/1318793004
Cr-Commit-Position: refs/heads/master@{#347581}
view-manager: Each ViewTreeHost has its own event-dispatcher.
Instead of having a single EventDispatcher, have one EventDispatcher for each
ViewTreeHost. The EventDispatcher is responsible for managing accelerators and
dispatching events within the ViewTreeHost which owns it. This allows opening
multiple browser windows without causing accelerator conflicts.
BUG=none
Review URL: https://codereview.chromium.org/1322783002
Cr-Commit-Position: refs/heads/master@{#347580}
Roll WebRTC 9854:9867, Libjingle 9853:9867
WebRTC 9854:9867
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/bc1e16f..22fd889
Libjingle 9853:9867
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/0a55956..ca717fa
TBR=
BUG=
Review URL: https://codereview.chromium.org/1324973005
Cr-Commit-Position: refs/heads/master@{#347579}
Roll src/third_party/WebKit 4e4624a:d39ea6f (svn 201844:201846)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4e4624a..d39ea6f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1331513002
Cr-Commit-Position: refs/heads/master@{#347578}
Roll src/third_party/skia ef2df09:e3330cf
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ef2df09..e3330cf
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
e3330cf [email protected] Revert of Scanline decoding for gifs (patchset #15 id:380001 of https://codereview.chromium.org/1305123002/ )
Review URL: https://codereview.chromium.org/1312443003
Cr-Commit-Position: refs/heads/master@{#347577}
