Publish DEPS for Chromium 46.0.2490.11
Incrementing VERSION to 46.0.2490.11
Cr-Commit-Position: refs/branch-heads/2490@{#102}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix strings for USB and HID device picker dialog title.
Commit 8b581d8b638951f98c0fb0c0116ac18b355b825e updated these strings
but expected the single vs. other selector to be format parameter {0}
instead of parameter {1} so the strings were broken. Nobody noticed.
BUG=526342
Review URL: https://codereview.chromium.org/1318803007
Cr-Commit-Position: refs/heads/master@{#346457}
(Cherry-picked from commit 145dadb727e08c0f68ca0a0921bdd230c02dbcd8.)
[email protected]
Review URL: https://codereview.chromium.org/1328463002 .
Cr-Commit-Position: refs/branch-heads/2490@{#101}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Updating XTBs based on .GRDs from branch 2490
Cr-Commit-Position: refs/branch-heads/2490@{#100}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Android] Dismiss ListPopupWindow carefully in EnhancedBookmarkRow.
In enhanced bookmark main panel, showing ListPopupWindow can detach
a bookmark row since it can make the main RecyclerView scroll.
Added isShowing() check before dismissing and also dismiss at
setBookmarkId(...)
BUG=523927
Review URL: https://codereview.chromium.org/1311893006
Cr-Commit-Position: refs/heads/master@{#346448}
(cherry picked from commit e68198f1ae49f05674f698f0d530bb4ed3fcfea1)
[email protected]
Review URL: https://codereview.chromium.org/1318713006 .
Cr-Commit-Position: refs/branch-heads/2490@{#99}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Updating XTBs based on .GRDs from branch 2490
Cr-Commit-Position: refs/branch-heads/2490@{#98}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix cast private API from crashing the extension on non-CrOS platforms.
This happened because the chrome.cast.devicesPrivate API was defined but there
was no schema available. This CL makes the schema available but keeps it
disabled if the current platform is not CrOS.
BUG=514952
Review URL: https://codereview.chromium.org/1309293003
Cr-Commit-Position: refs/heads/master@{#345226}
(cherry picked from commit ea9fc94b449427c5cf209b40f1bd7c4d00111940)
Review URL: https://codereview.chromium.org/1325693002 .
Cr-Commit-Position: refs/branch-heads/2490@{#97}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Media Router] Disable MR in incognito mode.
This is done via two ways:
1. Return null PresentationServiceDelegate to PresentationServiceImpl.
This effectively means there is no Presentation API implementation
in incognito mode.
2. Disable MediaRouterAction. This is done by omitting
MediaRouterAction while populating the incognito action toolbar menu.
To be extra safe, MediaRouterFactory::GetBrowserContextToUse will be
reverted to default behavior, meaning no MediaRouter will be provided
in incognito mode, rather than redirecting to the original Profile's
MediaRouter instance.
This means there are additional holes that need to be closed to
handle the null case:
- Moved DCHECK for router_ in MediaRouterUI from ctor to Init*().
This is necessary since it's possible for ncognito tab to access
chrome://media-router, but the other aspects for which MediaRouter
is needed will not be reached in incognito mode.
BUG=525215
[email protected]
Review URL: https://codereview.chromium.org/1312433008
Cr-Commit-Position: refs/heads/master@{#346038}
(cherry picked from commit 357397826ad4180b49f504395756a6c86f30b969)
Review URL: https://codereview.chromium.org/1327433004 .
Cr-Commit-Position: refs/branch-heads/2490@{#96}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Revert "Fix broken channel icon in chrome://help on CrOS" and try again
This reverts commit 816405126540e584fe60df9363ce655a4dd97ea9. It fixes
the problem by moving the channel logo logic to a different, static
data source.
The problem stems from loading chrome://settings on a system where switches::AboutInSettingsEnabled() is true, then also trying to load chrome://help-frame. Apparently, these are not mutually exclusive. There are two competing help-frame data sources and one of them is lacking strings. It is mysterious to me why we choose to show a different UI if I do [Wrench Menu -> Settings -> About Chromium OS] versus [Wrench Menu -> About Chromium OS]
BUG=524091,525464
Review URL: https://codereview.chromium.org/1316083003
Cr-Commit-Position: refs/heads/master@{#345911}
(cherry picked from commit 9de363e4a2ee228130bc3466acaaf6bd2beb18c3)
Review URL: https://codereview.chromium.org/1322943002 .
Cr-Commit-Position: refs/branch-heads/2490@{#95}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Mac: Fix cropped button in content settings bubble.
https://codereview.chromium.org/1266583003/ changed the button's title to a
longer string programmatically, which caused the button to be partially
cropped by its GTMWidthBasedTweaker superview.
Fixed by sizing the GTMWidthBasedTweaker superview instead. It will size the
button to fit and then size itself accordingly.
BUG=517397
[email protected]
Review URL: https://codereview.chromium.org/1311423004
Cr-Commit-Position: refs/heads/master@{#345890}
(cherry picked from commit 79fd7e76137d63daca9da5a674cac12ecb306848)
Review URL: https://codereview.chromium.org/1329443002 .
Cr-Commit-Position: refs/branch-heads/2490@{#94}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge AccelerometerReader to support separate iio devices
Upcoming changes to Chromium OS change how accelerometers are presented.
Currently both base and lid accelerometers are presented as a single iio_device. AccelerometerReader would read this file system to get the needed information.
Now they are being separated into different iio_devices. There have been other changes to the underlying file system that needs to be addressed for correct initialization.
This change update AccelerometerReader to handle this new format. While preserving the legacy path for devices on older kernels.
TEST=Manual testing on devices. This was loaded on a device representing both kernel versions.
BUG=515949, chrome-os-partner:40177, 431391
[email protected], [email protected], [email protected]
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1306453003
Cr-Commit-Position: refs/heads/master@{#346148}
(cherry picked from commit 01d453e2ae32b26bb9384853696db55b082302c4)
Review URL: https://codereview.chromium.org/1324523005
Cr-Commit-Position: refs/branch-heads/2490@{#93}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[2490] Keep NTP around when opening Most Visited in Incognito
No reason to specialize this behavior.
BUG=523311
TBR=aurimas
Review URL: https://codereview.chromium.org/1307283003
Cr-Commit-Position: refs/heads/master@{#345175}
Review URL: https://codereview.chromium.org/1320903005 .
Cr-Commit-Position: refs/branch-heads/2490@{#92}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix crash in ExternalNavigationHandler.
This crash could happen when navigating from an http page to a data URI
or some other URI that doesn't have a host. In that case, the referer
URL would be non-null, but the current URL's host would be null, so
currentUri.getHost().equals(previousUri.getHost()) would cause a NPE.
BUG=524715
Review URL: https://codereview.chromium.org/1320573002
Cr-Commit-Position: refs/heads/master@{#345954}
(cherry picked from commit 96633963447efb8d0ad8cd8a5a1335cee6628aec)
Review URL: https://codereview.chromium.org/1317713004 .
Cr-Commit-Position: refs/branch-heads/2490@{#91}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Extensions Page] Only autoscroll on initial load
Instead of autoscrolling (or opening the extension options page) every time the
set of extensions is updated, only do so on first load.
BUG=522877
[email protected]
Review URL: https://codereview.chromium.org/1312323002
Cr-Commit-Position: refs/heads/master@{#346011}
(cherry picked from commit bba4334b48ab7b0443d19e839abaa1e730d43e71)
Review URL: https://codereview.chromium.org/1321213002 .
Cr-Commit-Position: refs/branch-heads/2490@{#90}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Prevent base::debug::BreakDebugger() from being folded by the linker
Linker's ICF feature may merge BreakDebugger() with other functions
and it may confuse the crash report processor.
BUG=508489
[email protected]
Review URL: https://codereview.chromium.org/1316003004
Cr-Commit-Position: refs/heads/master@{#345663}
(cherry picked from commit 56a1591e219ec67f0b9715cd3e79de487bb07076)
Review URL: https://codereview.chromium.org/1324483003 .
Cr-Commit-Position: refs/branch-heads/2490@{#89}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
(Merge to M46) Fix crash with null ServiceWorkerProviderHost in DidDispatchFetchEvent
The provider host is a WeakPtr and can be destroyed if the tab was
closed.
BUG=520857
Review URL: https://codereview.chromium.org/1304033004
Cr-Commit-Position: refs/heads/master@{#345568}
(cherry picked from commit a6c778d2a0525c8891d4f6fbd8cee0b08f087f1b)
TBR=horo
Review URL: https://codereview.chromium.org/1304263010 .
Cr-Commit-Position: refs/branch-heads/2490@{#88}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge: Gallery: fixed CSS of ribbon spacer.
We specified height=100% and padding 4px at top and bottom. It made the
total height of ribbon spacer as 56px while it should be 48px. It caused
the white blank line at the bottom of window.
BUG=523909
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1309753003
Cr-Commit-Position: refs/heads/master@{#345029}
(cherry picked from commit ba4d3e3890684ac129d50e89a617351853f5d762)
Review URL: https://codereview.chromium.org/1321543007 .
Cr-Commit-Position: refs/branch-heads/2490@{#87}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Mac] WrenchMenuController: release the ZoomLevelObserver in browserWillBeDestroyed().
The crash in the bug suggests ZoomLevelObserver is being destroyed after
ui::ZoomEventManager. Explicitly release ZoomLevelObserver in
browserWillBeDestroyed() to avoid this.
BUG=523116
Review URL: https://codereview.chromium.org/1317483002
Cr-Commit-Position: refs/heads/master@{#345476}
(cherry picked from commit df4afaca8692ef9d6a38ecaff5cfe237cdfee2c0)
[email protected]
Review URL: https://codereview.chromium.org/1321543006 .
Cr-Commit-Position: refs/branch-heads/2490@{#86}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Merge] Repair menu border on Desktop Windows and Linux
This regressed in r344651 which assumed MenuConfig::InitAura() was
always called.
Actually, (e.g.) Desktop Linux currently uses only MenuConfig data
member initializers for its values.
So to fix, change MenuConfig::use_outer_border to default to true. Set
it unconditionally to false in MenuConfig::InitAura() (which is only
called for Ash windows), and on mac.
Verified:
- Windows, Linux: border (except in --open-ash),
- chromeos, Mac: no border.
BUG=523914
TEST=Visual
[email protected]
Review URL: https://codereview.chromium.org/1303313005
Cr-Commit-Position: refs/heads/master@{#345479}
(cherry picked from commit 7c7c3d4140fd94d394444102c9e1953b386f291f)
Review URL: https://codereview.chromium.org/1324643002 .
Cr-Commit-Position: refs/branch-heads/2490@{#85}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Incrementing VERSION to 46.0.2490.10
Cr-Commit-Position: refs/branch-heads/2490@{#84}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Incrementing VERSION to 46.0.2490.9
Cr-Commit-Position: refs/branch-heads/2490@{#83}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Allocate new Surface when top controls location changes.
This forces the new contents to be drawn only after the browser compositor has updated its frame. This can increase latency if the browser compositor is slow to update, but allows the renderer to be certain of where its contents are placed on the screen.
BUG=518177
Review URL: https://codereview.chromium.org/1298503004
Cr-Commit-Position: refs/heads/master@{#345217}
(cherry picked from commit b6eeb74b934bb73f18e1a7ca3cef70296f8e4944)
[email protected]
Review URL: https://codereview.chromium.org/1323663002 .
Cr-Commit-Position: refs/branch-heads/2490@{#82}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Incrementing VERSION to 46.0.2490.8
Cr-Commit-Position: refs/branch-heads/2490@{#81}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Remove search icon from contextual search panel.
This icon should no longer be visible. This change removes it from
contextual search panel code.
BUG=526278
[email protected]
Review URL: https://codereview.chromium.org/1310273005 .
Cr-Commit-Position: refs/branch-heads/2490@{#80}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Remove unused Contextual Search paths.
- Search provider icon on the side has launched and the old UI is no longer
needed.
- Arrow UI has launched and the UI is no longer needed.
BUG=526278
[email protected]
Review URL: https://codereview.chromium.org/1320223003 .
Cr-Commit-Position: refs/branch-heads/2490@{#79}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Prevent leaking PDF data cross-origin
BUG=520422
Review URL: https://codereview.chromium.org/1311973002
Cr-Commit-Position: refs/heads/master@{#345267}
(cherry picked from commit fff450abc4e2fb330ba700547a8e6a7b0fb90a6e)
Review URL: https://codereview.chromium.org/1308323007 .
Cr-Commit-Position: refs/branch-heads/2490@{#78}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge to M46 of fix for off-by-one error in Chromoting Connections enumerated histogram max.
BUG=524807
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1307173005
Cr-Commit-Position: refs/heads/master@{#345700}
(cherry picked from commit 0426ad32000abcfe0103210441c83b0d38c32791)
Review URL: https://codereview.chromium.org/1322723002
Cr-Commit-Position: refs/branch-heads/2490@{#77}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix dispatch to notification settings.
The dispatch had to occur before we launched tabbed or document mode
generic activity and it has to finish the launcher activity after
starting the intent.
Tested in document and tabbed mode.
BUG=525868
[email protected]
Review URL: https://codereview.chromium.org/1321683005
Cr-Commit-Position: refs/heads/master@{#346203}
(cherry picked from commit b03532ac27ed8f8776dc4edcbf7bae02507ac003)
Review URL: https://codereview.chromium.org/1319253002 .
Cr-Commit-Position: refs/branch-heads/2490@{#76}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Add Data Saver specific information in user feedback reports.
The following information is now sent in user feedback reports on Android:
- The Data Saver status
- The list of Data Saver proxy servers being used
- The last event which caused the Data Saver to be bypassed (i.e. it would
normally be used but due to some set of circumstances, is not being
used)
This is all information that can be found on the chrome://net-internals#bandwidth
internal page.
BUG=514773
Review URL: https://codereview.chromium.org/1284183003
Cr-Commit-Position: refs/heads/master@{#345515}
(cherry picked from commit a94e4db0d4f054e2e0ab6cc57def904a5d197d31)
Review URL: https://codereview.chromium.org/1325453004 .
Cr-Commit-Position: refs/branch-heads/2490@{#75}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Only LOAD_VALIDATE_CACHE for validated resources.
When fetching an URL with LOAD_VALIDATE_CACHE, if the URL is in the
cache but does not have validation headers (e.g. ETag, Last-Modified),
it will be refetched in its entirety. We don't want that.
Instead, for resource fetches, we fetch the URL first with
LOAD_ONLY_FROM_CACHE, and then confirm that either it is missing or it
has strong validators before re-requesting the URL with
LOAD_VALIDATE_CACHE.
For config and manifest fetches, we fetch the URL normally (without the
LOAD_VALIDATE_CACHE flag), as we don't benefit from revalidation.
In order to effect the above, this change introduces a small state
machine, controlled by the FetchStage enum.
In order to test the above, this change introduces a custom URLFetcherFactory.
This is because FakeURLFetcherFactory lacks a way to fake more than one
response for the same URL.
For test, each of the requests need to be customized in a different way.
Because the URLFetcherFactory API doesn't create an URLFetcher until the URL is
requested, this requires passing around a lambda specifying how to modify it at
create time.
BUG=309216
Review URL: https://codereview.chromium.org/1289683004
Cr-Commit-Position: refs/heads/master@{#344978}
(cherry picked from commit 7953387c1fbfea0beba6d8cada15ebca367b1029)
Review URL: https://codereview.chromium.org/1317033003 .
Cr-Commit-Position: refs/branch-heads/2490@{#74}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Limit the number of characters in drawing titles
Canvas#drawText() doesn't seem to work correctly for very long text.
The 4101st and characters after that are rendered at position 0.
Or this number may have to do with the canvas size.
Since only the first characters are shown to the users anyways, we can
limit the number of characters rendered for titles.
BUG=524390
Review URL: https://codereview.chromium.org/1309303003
Cr-Commit-Position: refs/heads/master@{#345680}
(cherry picked from commit 54af70e772df86e5edbc562a719ac00547fc1ae0)
Review URL: https://codereview.chromium.org/1310773007 .
Cr-Commit-Position: refs/branch-heads/2490@{#73}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Change |use_alternative_service| not to disable Alternate Protocols.
Currently, HttpNetworkSession::Params::use_alternative_service controls both
Alternate Protocols and Alternative Services. However, Alternate Protocols is
fully rolled out, therefore there is not need to disable it.
This CL changes |use_alternative_service| to
* disable parsing Alt-Svc headers (but not Alternate-Protocol ones);
* disable following saved alternative service entries that point to different
hosts (but not ones that point to the same host).
The latter is necessary because a browser session might have this flag enabled
and might save alternative services to disk, which we do not really want to
follow in the next browser session if the flag is disabled. (Ones discovered
through Alt-Svc pointing to the same host will still be respected.)
BUG=524141
Review URL: https://codereview.chromium.org/1310583002
Cr-Commit-Position: refs/heads/master@{#345640}
(cherry picked from commit 54ec34b7c174848672fc3ea08aba7289630df4a3)
[email protected]
Review URL: https://codereview.chromium.org/1315193009 .
Cr-Commit-Position: refs/branch-heads/2490@{#72}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Create alternative service field trial group.
This CL creates the independent AltSvc field trial group that directly controls
|use_alternative_services|. The default is changed to disabled, because Alternative Services is not approved for launch yet.
See https://crrev.com/1310583002 for what |use_alternative_services| does.
See https://crrev.com/1303273002 for what happened to the command line switch "--use-spdy=no-alt-protocols".
BUG=524141
Review URL: https://codereview.chromium.org/1271793003
Cr-Commit-Position: refs/heads/master@{#345944}
(cherry picked from commit d00793801e96b0f8b26c2ef7ba06fea5cc01f13e)
[email protected]
Review URL: https://codereview.chromium.org/1320153004 .
Cr-Commit-Position: refs/branch-heads/2490@{#71}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Android] Add UMA for opening bookmark action types.
User can open a bookmark by
1. Tapping
2. Long-press -> "Open in new tab"
3. Long-press -> "Open in incognito tab"
and we would like to measure how much 2. and 3. are useful.
BUG=525792
Review URL: https://codereview.chromium.org/1311543004
Cr-Commit-Position: refs/heads/master@{#346096}
(cherry picked from commit 61120a01f3b859cb8c8e01f0e3cc4c026577aafd)
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1312783004 .
Cr-Commit-Position: refs/branch-heads/2490@{#70}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix crash in MachOImageReader::Initialize.
If the load_command.cmdsize was smaller than the load_command struct, the range
check would fail, leading to a nullptr dereference.
BUG=524044
Review URL: https://codereview.chromium.org/1308123003
Cr-Commit-Position: refs/heads/master@{#345676}
(cherry picked from commit 56a8db6080af92d8b2afcb75c300606894157f7d)
Review URL: https://codereview.chromium.org/1309413005 .
Cr-Commit-Position: refs/branch-heads/2490@{#69}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Do not ignore back key presses before native library is loaded.
onBackPressed does not get called if we do not call super.onKeyDown().
We were not doing that if UI was not initialized.
[email protected]
BUG=522656
Review URL: https://codereview.chromium.org/1318323002 .
Cr-Commit-Position: refs/branch-heads/2490@{#68}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Bring back the old messages for disabled by admin.
This restores the strings and behavior from Chrome 43.
BUG=514827
Review URL: https://codereview.chromium.org/1310683004
Cr-Commit-Position: refs/heads/master@{#345444}
(cherry picked from commit d1c5933db2114122a7999bca8039572ddfc6f318)
[email protected]
Review URL: https://codereview.chromium.org/1317313002 .
Cr-Commit-Position: refs/branch-heads/2490@{#67}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Show a meaningful error message when updates are disabled by policy.
BUG=514827
TEST=Install system-level Chrome with Google Update on a domain-joined machine, disable manual updates, then navigate to chrome://help. Chrome should display a message indicating that manual updates are disabled without showing a UAC prompt. Now disable all updates and try again. Chrome should display a message indicating that updates are disabled.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1302403004
Cr-Commit-Position: refs/heads/master@{#344954}
(cherry picked from commit 9196d6c99610b85d2007402a2bb46931b7788e67)
[email protected]
Review URL: https://codereview.chromium.org/1324503002 .
Cr-Commit-Position: refs/branch-heads/2490@{#66}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Remove stale-while-revalidate from about:flags
The --enable-stale-while-revalidate flag will do nothing in M46, so
remove it from about:flags to minimise user confusion.
The flag will be restored to about:flags once the new implementation has
landed.
BUG=487902
TEST=unit_tests, manually checked about:flags
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1307573003
Cr-Commit-Position: refs/heads/master@{#345816}
(cherry picked from commit 2994dd0e88924ad26746743071d256f97efa0400)
Review URL: https://codereview.chromium.org/1320123003 .
Cr-Commit-Position: refs/branch-heads/2490@{#65}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix memory corruption in the passwords component due to std::remove_if on ScopedVector.
It was introduced in https://codereview.chromium.org/1278963003/
BUG=525154
[email protected]
Review URL: https://codereview.chromium.org/1314493009
Cr-Commit-Position: refs/heads/master@{#345829}
(cherry picked from commit a506cee0a75c81fcaec550199087c1cfa06ba4c0)
Review URL: https://codereview.chromium.org/1302313010 .
Cr-Commit-Position: refs/branch-heads/2490@{#64}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Disable app banners on ChromeOS.
This feature has not passed launch review for M45.
BUG=491001,525871
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1321723003 .
Cr-Commit-Position: refs/heads/master@{#346052}
(cherry picked from commit e3af34358cad87cb2a3356c3fa08192e73b00f1f)
Review URL: https://codereview.chromium.org/1322623002 .
Cr-Commit-Position: refs/branch-heads/2490@{#63}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Change the behavior of the SRT global error to stay in the menu until explicitly dismissed.
Also add browser test for the SRTFetcher
BUG=503607
Review URL: https://codereview.chromium.org/1234613003
Cr-Commit-Position: refs/heads/master@{#345538}
(cherry picked from commit 68ce916088e765d72309d38e4bb9a2160ad52e9a)
[email protected]
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1310183012 .
Cr-Commit-Position: refs/branch-heads/2490@{#62}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Prevent TranslateInfoBars from crashing when changing languages
* Works around an AppCompat crash by not using a custom TextView
when creating the drop down list.
* Removes spacing, but keeps the background as white (the default
AppCompat TextView background color is the drab gray). Confirmed
with rolfe@ that this is alright.
BUG=523186
TBR=aurimas
Review URL: https://codereview.chromium.org/1305373003
Cr-Commit-Position: refs/heads/master@{#346037}
Review URL: https://codereview.chromium.org/1316373003 .
Cr-Commit-Position: refs/branch-heads/2490@{#61}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Incrementing VERSION to 46.0.2490.7
Cr-Commit-Position: refs/branch-heads/2490@{#60}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Check for storage permission if context menu download is intercepted.
For OMA download initiated through context menu, it is intercepted by DownloadManager in java side.
As a result, it won't go through the native DownloadResourceThrottle to check for storage permissions.
This change fixes the behavior for this special case.
TBR=tedchoc
BUG=525270
Review URL: https://codereview.chromium.org/1317963002
Cr-Commit-Position: refs/heads/master@{#345938}
(cherry picked from commit 947423af5d88cce00fd5eadee3ceac213c310a4c)
Review URL: https://codereview.chromium.org/1313183004 .
Cr-Commit-Position: refs/branch-heads/2490@{#59}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix a crash about opening a folder that was deleted by sync
If a bookmark is deleted by sync, bookmarkNodeRemoved() will not be
called in EBManager.
BUG=523924
Review URL: https://codereview.chromium.org/1311873002
Cr-Commit-Position: refs/heads/master@{#345125}
[email protected]
Review URL: https://codereview.chromium.org/1317183002 .
Cr-Commit-Position: refs/branch-heads/2490@{#58}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Generate a file name for OMA object file if name attribute is missing in dd file
If the name attribute is missing in download descriptor, DownloadManager will
throw an eception when enqueuing a download request to download the OMA object.
Use UrlUtil to generate a file name in this case
TBR=tedchoc
BUG=525710
Review URL: https://codereview.chromium.org/1317133002
Cr-Commit-Position: refs/heads/master@{#345939}
(cherry picked from commit 68d1c3b9aa38cd83aebc7aa9c4ee31a0c00bcdaa)
Review URL: https://codereview.chromium.org/1311353003 .
Cr-Commit-Position: refs/branch-heads/2490@{#57}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix crash in url fading accessibility string.
TextUtils.concat tries to copy over spannable strings and that
is not needed here. Switch to using a pure string concat.
BUG=524679
Review URL: https://codereview.chromium.org/1314893005
Cr-Commit-Position: refs/heads/master@{#345511}
Review URL: https://codereview.chromium.org/1314763010 .
Cr-Commit-Position: refs/branch-heads/2490@{#56}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Custom Tabs]Fix a bug that https is not shown properly
In android SDK M, android:maxLines no longer works with setSelection. If
selection is set to the end, TextView will squeeze the first part to a
previous line. This CL changes the urlbar in Custom Tab to use
singleLine.
BUG=524672
Review URL: https://codereview.chromium.org/1320493003
Cr-Commit-Position: refs/heads/master@{#345530}
[email protected]
Review URL: https://codereview.chromium.org/1321693005 .
Cr-Commit-Position: refs/branch-heads/2490@{#55}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Custom Tabs]Fix a bug that activateContents will pop up a blank chrome
ChromeTab#activateContents brings chrome app to foreground, by sending
an intent to chrome. Yet in CustomTabs, it will generate erroneous
behavior.
BUG=524700
Review URL: https://codereview.chromium.org/1318853002
Cr-Commit-Position: refs/heads/master@{#345784}
[email protected]
Review URL: https://codereview.chromium.org/1301393009 .
Cr-Commit-Position: refs/branch-heads/2490@{#54}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix window.open crashes on custom tabs
Overrides the tabwebcontentdelegate calls that
assumes the presence of a tabcreator which is not there for
custom tabs. Loads the targetUrl on the same page instead.
BUG=524562
Review URL: https://codereview.chromium.org/1308563006
Cr-Commit-Position: refs/heads/master@{#345525}
[email protected]
Review URL: https://codereview.chromium.org/1318983003 .
Cr-Commit-Position: refs/branch-heads/2490@{#53}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge "Use the Chrome icon rather than a bell icon for notifications"
The generic bell icon is deemed to be confusing, as it creates an
association with alarms rather than generic notifications. Use the
Chrome icon instead.
NOTRY=true
NOPRESUBMIT=true
TBR=pennymac
BUG=523990
Review URL: https://codereview.chromium.org/1313593003
Cr-Commit-Position: refs/heads/master@{#345589}
(cherry picked from commit 1598c3b20079643e0fea748797bf4a6e3c015549)
Review URL: https://codereview.chromium.org/1312433007
Cr-Commit-Position: refs/branch-heads/2490@{#52}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Updating XTBs based on .GRDs from branch 2490
Cr-Commit-Position: refs/branch-heads/2490@{#51}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge the fix for the find results bug on the Chrome Sign-in page into 46.
[email protected]
NOPRESUBMIT=true
NOTRY=true
This patch fixes the bug where find results were not showing up in the find bar for the Chrome signin page. This also fixed the same bug (which was not reported) for extension options.
This bug resulted from GuestViews not properly propagating FindReply data to their embedder when handling find requests in place of their embedder.
BUG=524003
Review URL: https://codereview.chromium.org/1310333002
Cr-Commit-Position: refs/heads/master@{#345192}
(cherry picked from commit 9c87a756bf398d12f66e7abb94fade7728f110b1)
Review URL: https://codereview.chromium.org/1310883006
Cr-Commit-Position: refs/branch-heads/2490@{#50}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
customtabs: Fix a crash when clicking on the lock icon.
When the user clicks on the lock icon in a Custom Tab, the click
listener creates a new piece of UI. This inflation fails if the context
passed to WebSiteSettingsPopup#show() is not an Activity.
BUG=524005
Review URL: https://codereview.chromium.org/1318483002
Cr-Commit-Position: refs/heads/master@{#345858}
(cherry picked from commit 63c99439bba3bd258b0c2c3a1ca0b817f26c2c84)
Review URL: https://codereview.chromium.org/1315713004 .
Cr-Commit-Position: refs/branch-heads/2490@{#49}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
uikit_uitls and ui_uitls addditions.
This CL adds some utility functions that enable operating on common
UIKit and CoreGraphics data structures using the language-direction-
independent 'leading' and 'trailing' nomenclature.
These utilities will be used for iOS9 RTL support downstream.
BUG=520568
Review URL: https://codereview.chromium.org/1303013008
Cr-Commit-Position: refs/heads/master@{#345595}
(cherry picked from commit f642199224153f7d81cea1a43b338b5567f2d384)
Move all RTL-related layout utilities into a new file.
This CL moves all of the RTL-related utilities in ui_uitils.h and
uikit_utils.h into a new rtl_geometry.h, per suggestions in other
CLs.
BUG=525021
Review URL: https://codereview.chromium.org/1310553006
Cr-Commit-Position: refs/heads/master@{#345591}
(cherry picked from commit bcaa572e6a7c798b21b47b9aaab2d8eb5f7d9a17)
Updates to LayoutRect API
Updates to the LayoutRect API as suggested by kkhorimoto@ in comments to
https://codereview.chromium.org/1304793002/
- Adds LayoutRectMake constructor.
- Adds LayoutRectZero constant.
- Renames fields: 'contextWidth' -> 'boundingWidth',
'yOrigin' -> 'originY'
- Renames function LayoutRectForRectInRectUsingDirection() ->
LayoutRectForRectInBoundingRectUsingDirection()
- Renames function LayoutRectForRectInRect() ->
LayoutRectForRectInBoundingRect()
- Renames function LayoutRectGetTrailing() ->
LayoutRectGetTrailingEdge()
- Corrects parameter name errors in comments.
BUG=
Review URL: https://codereview.chromium.org/1305013002
(cherry picked from commit c96804c5f6182004b404ad6dccac9ba5f93646d5)
Cr-Original-Commit-Position: refs/heads/master@{#345587}
Cr-Commit-Position: refs/branch-heads/2490@{#48}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Android Media Notifications: apply UI guidance.
Instead of showing the Chrome logo as the MediaSession icon, we use a
plain color.
BUG=524180
[email protected]
Review URL: https://codereview.chromium.org/1319603002
Cr-Commit-Position: refs/heads/master@{#345628}
(cherry picked from commit 9bb53e780f42dc522d1906f53c510e3a8a765e03)
Review URL: https://codereview.chromium.org/1320883002 .
Cr-Commit-Position: refs/branch-heads/2490@{#47}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Android Media Notifications: improve MediaSessionCompat compatibility by using BroadcastReceiver.
It enables media buttons on JB-MR0 and JBR-MR1 which require a BroadcastReceiver.
BUG=514681
[email protected]
Review URL: https://codereview.chromium.org/1313523004
Cr-Commit-Position: refs/heads/master@{#345604}
(cherry picked from commit ceef7c81109eb217eb1e579a0798cd22b3ab59f8)
Review URL: https://codereview.chromium.org/1320873002 .
Cr-Commit-Position: refs/branch-heads/2490@{#46}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
webapps: update recents and status bar color sooner
Currently there is a delay until the native library is loaded for the data
to be updated. There is no reason for this to happen as we have all the
infomation to do so and the native library is not needed to update recents
or the status bar.
Change this so that these items are updated earlier in the initialization
cycle. Moreover, remove an old TODO.
BUG=510402
[email protected]
Review URL: https://codereview.chromium.org/1313063002
Cr-Commit-Position: refs/heads/master@{#345664}
(cherry picked from commit 20e720c1f20135e7af5875a50ad4eeb7fce55dfd)
Review URL: https://codereview.chromium.org/1320863002 .
Cr-Commit-Position: refs/branch-heads/2490@{#45}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Clean the blacklisted form if a user saves a password.
BUG=524386
[email protected]
Review URL: https://codereview.chromium.org/1319503002
Cr-Commit-Position: refs/heads/master@{#345344}
(cherry picked from commit f5f469bfa8fcb7ac176bbd33ad942d2d20f0cc0e)
Review URL: https://codereview.chromium.org/1315323003 .
Cr-Commit-Position: refs/branch-heads/2490@{#44}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Disable the password manager on password reauth forms - in renderer.
This is a temporary solution that will hold until https://codereview.chromium.org/1285133003/ can be landed. The latter depends on further refactoring, and we would like to solve this issue in M46.
BUG=522553
Review URL: https://codereview.chromium.org/1301833006
Cr-Commit-Position: refs/heads/master@{#345575}
(cherry picked from commit 64b2f6b15a04d2a037650d71433eec91d227dac8)
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1318973003 .
Cr-Commit-Position: refs/branch-heads/2490@{#43}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
customtabs: Make sure that the browser process is initialized in mayLaunchUrl().
Since the documentation doesn't force clients to call warmup() before
mayLaunchUrl(), call warmup() for them inside mayLaunchUrl() if
necessary.
BUG=525002
Review URL: https://codereview.chromium.org/1311423003
Cr-Commit-Position: refs/heads/master@{#345590}
(cherry picked from commit d9879f1dc467a031829d5a769f572b99b5c37463)
Review URL: https://codereview.chromium.org/1315893003 .
Cr-Commit-Position: refs/branch-heads/2490@{#42}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Make the NTP apps page respect the enable hosted apps in windows flag.
https://codereview.chromium.org/1300763002/ adds a new flag,
--[enable|disable]-hosted-apps-in-windows on Mac. This flag controls
whether hosted apps are allowed to open in windows independently of
whether the new bookmark app system is enabled.
This CL amends the logic in the NTP apps page to correctly display
the launch options for apps for all permutations of
--[enable|disable]-new-bookmark-apps and
--[enable|disable]-hosted-apps-in-windows. This means that as the
default values change for these options, the NTP will behave
appropriately.
NOTRY=true
NOPRESUBMIT=true
TBR=dbeam
BUG=517682,520361
Review URL: https://codereview.chromium.org/1305653002
Cr-Commit-Position: refs/heads/master@{#344979}
(cherry picked from commit 6710ac59fd1f094d55f734ad9a1eb884bce5fa71)
Review URL: https://codereview.chromium.org/1313553004
Cr-Commit-Position: refs/branch-heads/2490@{#41}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[M46 Merge] Re-add camera and microphone settings to the extensions API.
The reason for removal of camera and microphone content settings from the extension API was that the UI could not correctly show this support.
As of https://codereview.chromium.org/1210173012/, we have a suitable UI, so this can be relanded.
In this CL, we first revert the removal CL (https://codereview.chromium.org/938513004/) in Patchset #1. In the following patchsets, we handle one change that has been made to content settings in the meantime, and that is the possibility to restrict the default content setting to a smaller subset of values than is supported for content setting exceptions of the same content type. This currently only happens in case of camera and microphone, so it was not necessary to handle it in the extensions' API until now.
==================================================
Revert details:
Original issue's description:
> Remove camera and microphone settings from the extensions API.
>
> These were added in CLs 880223002 and 889893002.
> Automatic revert in CLs 925303003 and 933273002 didn't work due to the way how kContentSettingsTypeNames in content_settings_helpers.cc works - we cannot remove an entry from the middle of the list.
>
> Reason for revert:
> Setting the camera and microphone default content settings currently cannot be shown in the UI and will not work exactly the way an app developer might expect it to (due to interference with the MEDIASTREAM content setting).
>
> Reverting this patch until the UI is ready.
>
> BUG=464410
>
> Committed: https://crrev.com/16991f7d102f1c2327587258eabd5e46fc362ec0
> Cr-Commit-Position: refs/heads/master@{#319286}
==================================================
[email protected],[email protected],[email protected]
BUG=464410,455589
Review URL: https://codereview.chromium.org/1296983005
Cr-Commit-Position: refs/heads/master@{#345223}
(cherry picked from commit 270c118e934ce24372117e0b7fba55c6130f1012)
Review URL: https://codereview.chromium.org/1320623003 .
Cr-Commit-Position: refs/branch-heads/2490@{#40}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
NaCl: Update revision in DEPS, 9f6a876 -> 0cf13c0
This pulls in the following Native Client changes:
ff41268: ([email protected]) Clean up IRT build flags in untrusted.gypi
1940bfa: ([email protected]) Build the IRT with nacl-clang for ARM
fe85f88: ([email protected]) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
254c1f3: ([email protected]) untrusted.gypi: IRT/nonsfi build depends on pnacl rather than newlib toolchain
821cf4b: ([email protected]) Reland "Non-SFI mode: Add Linux asynchronous signal support"
6273f35: ([email protected]) Fix ARM IRT gyp dependence rules to depend on the correct toolchain
0cf13c0: ([email protected]) SCons: Clean up so that gtest-all.o doesn't get put in the source directory
Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/9f6a8764c9ae8d491045c27b64634639b815f64a..0cf13c015762a9fc573d2219a30100b8f4bf4cc2
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/1309213002
NOTRY=true
NOPRESUBMIT=true
Cr-Commit-Position: refs/heads/master@{#345174}
(cherry picked from commit 8a71d7e6a093e73a73c034f4de609b749a869067)
Review URL: https://codereview.chromium.org/1317063002
Cr-Commit-Position: refs/branch-heads/2490@{#39}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Incrementing VERSION to 46.0.2490.6
Cr-Commit-Position: refs/branch-heads/2490@{#38}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
mac: Remove fullscreen transition hack and associated logic bug. (Merge to 2490)
The hack was introduced to fix the fullscreen transition back when the tab strip
and content view were sibling views. The hack is no longer necessary, since the
tab strip is not a subview of the content view, so I'm removing all the
associated logic.
There was a bug in the logic that caused the window's contentView to lose its
backing layer.
BUG=523250
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1318873002 .
Cr-Commit-Position: refs/branch-heads/2490@{#37}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
mac: Fix tab strip theme redrawing bug. (Merge to 2490)
The theme of the tab strip wasn't being redrawn as the window started/stopped
being main.
BUG=523495
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1315483005 .
Cr-Commit-Position: refs/branch-heads/2490@{#36}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Minor fixes to registry collecting logic in Incident Service.
Review URL: https://codereview.chromium.org/1309753009
Cr-Commit-Position: refs/heads/master@{#345342}
(cherry picked from commit c20137284a91c870a66aa4abbc4039a34c10278f)
BUG=525157
[email protected]
Review URL: https://codereview.chromium.org/1317923003 .
Cr-Commit-Position: refs/branch-heads/2490@{#35}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Don't crash when new_avatar_button() is missing
I haven't been able to verify but the stack trace is pretty good evidence.
BUG=523198
[email protected]
Review URL: https://codereview.chromium.org/1312603002
Cr-Commit-Position: refs/heads/master@{#345015}
(cherry picked from commit bb219e2268df7b7299bb4ad5f88aa535c1ddad9e)
Review URL: https://codereview.chromium.org/1318843002 .
Cr-Commit-Position: refs/branch-heads/2490@{#34}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Add support for registry data in IncidentReportingService
BUG=525157
Review URL: https://codereview.chromium.org/1304883002
Cr-Commit-Position: refs/heads/master@{#344970}
(cherry picked from commit 23633436ab3dc6f3bd4bf75dbacc993100f61929)
[email protected]
Review URL: https://codereview.chromium.org/1314243002 .
Cr-Commit-Position: refs/branch-heads/2490@{#33}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Reland of move 1 ms rounding up of task delays on Windows
Reason for revert:
The original change was reverted in error. The Webkit Win10 builder has
been hitting multiple failures for a long time. Neither my change nor
the revert affected this. And, the linked build failures (builds/71)
were before my change landed.
By reverting the revert of my undo of a previous change we are putting
the code back to its original state (see original description)
Original issue's description:
> Revert of Remove 1 ms rounding up of task delays on Windows (patchset #1 id:1 of https://codereview.chromium.org/1305873002/ )
>
> Reason for revert:
> Figuring out if this could cause Win10 failures: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/71
>
> Original issue's description:
> > Remove 1 ms rounding up of task delays on Windows
> >
> > Prior to a couple of attempts at fixing bug 487724 the message pump
> > would sometimes end up spinning for up to a ms when waiting for a
> > message's time to arrive. This was unintentional and non-obvious.
> >
> > The eventual fix was to round up the delay time to the next ms.
> > Unfortunately this caused a regression in smoothness.top_25_smooth
> > which has not been resolved (investigation was delayed due to some
> > confusion about the results). Therefore this change reverts both
> > fix attempts in order to leave time for a proper investigation and
> > any necessary fixes.
> >
> > It is worth mentioning that the delay introduced by rounding up to 1
> > ms is actually worse than expected on some operating systems. On Windows
> > 7 a call to Sleep(1) will, if the timer frequency is raised, return
> > within a ms. On Windows 8.1 it will often take two ms to return, which
> > increases the delay. If the timer frequency is at its default interval
> > of 15.625 ms then the delay can be longer.
> >
> > BUG=487724,497536
> >
> > Committed: https://crrev.com/2b1bf190a079709a1a6a769bf86e782423d23121
> > Cr-Commit-Position: refs/heads/master@{#344688}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487724,497536
>
> Committed: https://crrev.com/189fc2149ec370a0a42b1bb63e9b49fa579aa1d7
> Cr-Commit-Position: refs/heads/master@{#344798}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487724,497536
Review URL: https://codereview.chromium.org/1311863002
Cr-Commit-Position: refs/heads/master@{#345110}
(cherry picked from commit 3e74c7c6e2c4d3ca1e9876d81d95c66b7be512b5)
Review URL: https://codereview.chromium.org/1314843005 .
Cr-Commit-Position: refs/branch-heads/2490@{#32}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Update targetSdkVersion to 23.
We moved to Android SDK 23. This CL updates the targetSdkVersion to
match the SDK.
See behavior changes here:
http://developer.android.com/preview/api-overview.html
BUG=522182
[email protected]
Review URL: https://codereview.chromium.org/1285103005
(cherry picked from commit 3b59fc6a0927e3d5f24321125270065f4d3fbf72)
Cr-Original-Commit-Position: refs/heads/master@{#344942}
Cr-Commit-Position: refs/branch-heads/2490@{#31}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix foregrounding of WebappActivity instances
At some point, Clank lost the ability to bring back web apps to
the foreground via a media notification. These appear whenever
a Tab is recording audio or video, and selecting them is
supposed to bring back the Tab to let the user know what Tab is
doing it. Instead the Intent was being redirected by
ChromeLauncherActivity to either the ChromeTabbedActivity or the
DocumentActivity, neither of which knows about the existence of
Tabs owned by WebappActivities.
ChromeLauncherActivity is adjusted so that any Intents fired with
the intention of bringing a specific tab to the foreground first
check if any live WebappActivity instances have a Tab with the
given ID. If so, the WebappLauncherActivity will refire the
Intent required to bring back the WebappActivity to the foreground.
* Adds an additional check for the BRING_TAB_TO_FRONT extra in
ChromeLauncherActivity that checks if WebappActivities need
to be foregrounded.
* Consolidates creation of the Intent to the Tab instead of
being in multiple places.
* Consolidates creation of the WebappActivity Intent to
WebappLauncherActivity.
* Consolidates logic for pulling web app data out of the Intent
into WebappInfo and makes WebappInfo start using the IntentUtils.
* Avoids decompressing the icon into a Bitmap when the WebappInfo
is created, only doing so when the Bitmap is actually requested.
At that point it gets cached.
* Stops saving WebappInfo out to the Bundle; nothing was reading
it anyway. I think this was meant for the reboot persistence
case; we can always add it back if we ever get around to supporting
that.
* Adds a test to WebappModeTest to detect that the Intent
successfully brings back the WebappActivity.
* Consolidates logic in the WebappModeTest.
BUG=522918
TEST=WebappModeTest*
TBR=mlamouri,mariakhomenko
Review URL: https://codereview.chromium.org/1313123006
Cr-Commit-Position: refs/heads/master@{#345626}
Review URL: https://codereview.chromium.org/1308573004 .
Cr-Commit-Position: refs/branch-heads/2490@{#30}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[MediaRouter]Whitelist stable and beta MR extension IDs for tab capture API.
An ununsed Cast extension ID is removed.
[email protected]
BUG=523507
Review URL: https://codereview.chromium.org/1305233005
Cr-Commit-Position: refs/heads/master@{#345421}
(cherry picked from commit 2ad675531397b1043740772fe00b757ba1aa6fc0)
Review URL: https://codereview.chromium.org/1309303004 .
Cr-Commit-Position: refs/branch-heads/2490@{#29}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Update Contextual Search panel shadow.
BUG=524705
Review URL: https://codereview.chromium.org/1310213007
[email protected]
Review URL: https://codereview.chromium.org/1304263005 .
Cr-Commit-Position: refs/branch-heads/2490@{#28}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix menu positioning in Document mode when using hardware menu key.
Document mode was passing incorrect anchor view when using hardware
menu button that was causing menu postioning issues.
BUG=523043
[email protected]
Review URL: https://codereview.chromium.org/1310103005 .
Cr-Commit-Position: refs/branch-heads/2490@{#27}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[sql] Record SQLite memory usage after a week.
Previously landed 10-minute, 1-hour, and 1-day histograms. Based on
those I expect 1-week to get around 20% worse.
BUG=489784
Review URL: https://codereview.chromium.org/1316493006
Cr-Commit-Position: refs/heads/master@{#345366}
(cherry picked from commit 2d48e948d46a3c288e7147867a5978aa647b2344)
Review URL: https://codereview.chromium.org/1320703002 .
Cr-Commit-Position: refs/branch-heads/2490@{#26}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Files.app: Remove accidentally specified color from filename input.
color:red was accidentally specified multiple milestones ago, but apparently it
has become visible by recent spec change of cascading order.
BUG=524119
TEST=manually
[email protected]
Review URL: https://codereview.chromium.org/1313853002
Cr-Commit-Position: refs/heads/master@{#345272}
(cherry picked from commit 8d191c120beb6664eaf71ee8cd48cad8e0c3ebbc)
Review URL: https://codereview.chromium.org/1320593002 .
Cr-Commit-Position: refs/branch-heads/2490@{#25}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Android] Disable selection on enhanced bookmark search row.
Search row shouldn't be selectable but user could select
through a race between opening search view and popup menu selection.
This CL doesn't address the race condition but disables setting
selection state on search rows.
In addition, made mHighlightView and mMoreIcon null if they are not
used to prevent accidental usage.
BUG=524351
Review URL: https://codereview.chromium.org/1302313007
Cr-Commit-Position: refs/heads/master@{#345520}
(cherry picked from commit 697aa1bfd58df7a9911d0b3aed934b898a1c7e84)
[email protected]
Review URL: https://codereview.chromium.org/1317783004 .
Cr-Commit-Position: refs/branch-heads/2490@{#24}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
(Merge to M46) Service workers: Allow HTTPS pages arrived at via HTTP redirect to use SW
This should be allowed. It regressed in https://crrev.com/1db36fd
BUG=522900
TEST=https://codereview.chromium.org/1312723002
Review URL: https://codereview.chromium.org/1315483002
Cr-Commit-Position: refs/heads/master@{#345033}
(cherry picked from commit f72c80b5cbc8c6621f7703036d989b40bd6b31ab)
TBR=ksakamoto
Review URL: https://codereview.chromium.org/1314083002 .
Cr-Commit-Position: refs/branch-heads/2490@{#23}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Add some multi-D Rappor permission metrics for permissions that go through permission_context.
BUG=477833
TBR=nparker
Review URL: https://codereview.chromium.org/1250543002
Cr-Commit-Position: refs/heads/master@{#345248}
(cherry picked from commit d0810751e88e2b0330293108585fa67927ed6c74)
Review URL: https://codereview.chromium.org/1313083004 .
Cr-Commit-Position: refs/branch-heads/2490@{#22}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge to M46 of UMA metrics for Chrome Remote Desktop connection times and state counts.
Add UMA stats for connection times and durations in the Chromoting plugin. Also add UMA counters for each connection-state in the web-app.
BUG=502061
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1305453002
Cr-Commit-Position: refs/heads/master@{#344930}
(cherry picked from commit 49b2fcd7c800c94961c5644b847639dabccdc7e7)
Review URL: https://codereview.chromium.org/1312623005
Cr-Commit-Position: refs/branch-heads/2490@{#21}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Merge to M46 of getting field-trial functionality in Chrome Remote Desktop web-app.
Get Field-Trial for a web-app session and, depending on group returned, enable QUIC & vp9 experiments in web-app.
BUG=448838
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1300213005
Cr-Commit-Position: refs/heads/master@{#344958}
(cherry picked from commit 2b8072b2a5bbbbb6063464b1183b83416f9e2275)
Review URL: https://codereview.chromium.org/1314063002
Cr-Commit-Position: refs/branch-heads/2490@{#20}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Android] Don't signal ActionBar shown for floating ActionModes
Selection action bar visibility is communicated through the
ContentViewClient. This in turn triggers various behaviors, including
hiding and showing the omnibox on tablets. However, the selection
ActionModes are not always action *bars*. In M, there can be
floating ActionModes, for which the action bar notification makes no
sense. For now, avoid signalling ActionBar visbility for such
floating ActionModes.
BUG=524666
Review URL: https://codereview.chromium.org/1320513002
Cr-Commit-Position: refs/heads/master@{#345474}
(cherry picked from commit 2a13556d8522e6d4c11e488133dccdd7d2194f22)
Review URL: https://codereview.chromium.org/1320553003 .
Cr-Commit-Position: refs/branch-heads/2490@{#19}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
MergeDictionaryValues should handle merging value into dictionary correctly.
PrefModelAssociator::MergeDictionaryValues doesn't handle following parameters:
from_value = {"key":0}
to_value = {"key":{"subkey":0}}
In debug build it DCHECKS, in release build it crashes.
The issue is that when calling MergeDictionaryValues recursively it doesn't
ensure that both values are dictionaries.
The change is to add this check.
BUG=495016
[email protected]
Review URL: https://codereview.chromium.org/1303063003
Cr-Commit-Position: refs/heads/master@{#345113}
(cherry picked from commit 2c18a5c731fb6634458c6612d69211d0061a6f1c)
Review URL: https://codereview.chromium.org/1314933003 .
Cr-Commit-Position: refs/branch-heads/2490@{#18}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Contextual Search] Tweak Search Bar/Panel size.
BUG=524617
[email protected]
Review URL: https://codereview.chromium.org/1317783002 .
Cr-Commit-Position: refs/branch-heads/2490@{#17}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Incrementing VERSION to 46.0.2490.5
Cr-Commit-Position: refs/branch-heads/2490@{#16}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
cc: Fix support for RGBA4444 texture format and one-copy.
BUG=524129
TEST=chrome --enable-rgba-4444-textures
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1308533003
Cr-Commit-Position: refs/heads/master@{#345404}
(cherry picked from commit 5b19e03ec9016cbfa7272b9c998babd3e520d596)
Review URL: https://codereview.chromium.org/1310233003 .
Cr-Commit-Position: refs/branch-heads/2490@{#15}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[Android] Supporting floating select ActionModes for web content
Add floating toolbar support for web content selections.
BUG=389153
Review URL: https://codereview.chromium.org/1242613002
Cr-Commit-Position: refs/heads/master@{#345172}
(cherry picked from commit 98a1a3a17168e4b61e723dc973dad81c1190d78a)
Review URL: https://codereview.chromium.org/1312613005 .
Cr-Commit-Position: refs/branch-heads/2490@{#14}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Prevent fling updates from turning off touchstart prioritization
Dispatch of GestureFlingCancel events is always deferred until the touch
sequence has been ack'ed by the main thread. Consequently, a pre-existing
fling animation may continue ticking while the scheduler is still awaits
a proper touchstart response. As the scheduler currently believes such
animations are a valid touchstart response, it will turn off touchstart
priorization. Avoid this by ignoring fling animation updates for the sake
of touchstart response prioritization.
BUG=524514
Review URL: https://codereview.chromium.org/1308413004
Cr-Commit-Position: refs/heads/master@{#345385}
(cherry picked from commit 4639a9feab6d8b71d9369489e6e6e1b99059d43e)
Review URL: https://codereview.chromium.org/1303373004 .
Cr-Commit-Position: refs/branch-heads/2490@{#13}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Histogram to tell if Chrome is brought to foreground by Notifications
Android only for now, but might be extended to desktop later.
Cherry picked from the following patch:
- Review URL: https://codereview.chromium.org/1304323002
- Commit: d0e3e6a15ade75bf87aa1fb4fd660ef106edf219
- Cr-Commit-Position: refs/heads/master@{#345065}
BUG=522966
[email protected]
Review URL: https://codereview.chromium.org/1313933002 .
Cr-Commit-Position: refs/branch-heads/2490@{#12}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
[BackgroundSync] Move read and write of shared preferences to an AsyncTask
Merging into M46
[email protected]
BUG=520105
Review URL: https://codereview.chromium.org/1288593003
Cr-Commit-Position: refs/heads/master@{#345118}
(cherry picked from commit 3fd1c36bf4c6cf03586c74bf95d051787d7c86b2)
Review URL: https://codereview.chromium.org/1312993004 .
Cr-Commit-Position: refs/branch-heads/2490@{#11}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
shouldOverrideUrlLoading should not be called on reloads in WebView
Fix unintented behaviour where shouldOverrideUrlLoading is called for
reloads (in earlier WebView versions shouldOverrideUrlLoading was not
called for reloads and there are apps relying on this behaviour). This
behaviour was introduced in https://codereview.chromium.org/1155713005/.
BUG=522743
NOTRY=true
NOPRESUBMIT=true
(cherry picked from commit 472fe362d7dc76160a1619b17bebc8435e673078)
Review URL: https://codereview.chromium.org/1311213002
Cr-Commit-Position: refs/branch-heads/2490@{#10}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Fix crash caused by concurrent access to framebuffer_combo_complete_map_.
The current implementation of framebuffer completeness testing uses a
single global hash_map as a cache. This leads to races in WebView when
GPU and render threads try to access the cache concurrently.
BUG=518858
Review URL: https://codereview.chromium.org/1278333003
Cr-Commit-Position: refs/heads/master@{#344940}
(cherry picked from commit fc199b47cb5b74c9f2ccf3a6316fc9b7009c6904)
Review URL: https://codereview.chromium.org/1311813002 .
Cr-Commit-Position: refs/branch-heads/2490@{#9}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
MediaDrmBridge: Add ExpirationUpdateListener.
BUG=487435
TEST=Manually tested.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1148323002
Cr-Commit-Position: refs/heads/master@{#344947}
(cherry picked from commit 03ff3f711474448587892acc7c3e1cc05e077b82)
Review URL: https://codereview.chromium.org/1312073002 .
Cr-Commit-Position: refs/branch-heads/2490@{#8}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
MediaDrmBridge: Add KeyStatusChangeListener.
[email protected],[email protected]
BUG=487435
TEST=Manually tested on K and M devices.
Review URL: https://codereview.chromium.org/1145393003
Cr-Commit-Position: refs/heads/master@{#344937}
(cherry picked from commit 7145c98e1549631c05bf62c2bd20b92fe0280ebf)
Review URL: https://codereview.chromium.org/1316593002 .
Cr-Commit-Position: refs/branch-heads/2490@{#7}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
Disable renderer partial raster by default.
It is causing one-pixel lines to be left behind, probably due to a small error
in the invalidation rects being used.
BUG=492754,522797,522922,522920
Review URL: https://codereview.chromium.org/1290133003
Cr-Commit-Position: refs/heads/master@{#344975}
(cherry picked from commit 027a930a4f456a173b5c01d8537185187698caeb)
[email protected]
Review URL: https://codereview.chromium.org/1307943005 .
Cr-Commit-Position: refs/branch-heads/2490@{#6}
Cr-Branched-From: 7790a3535f2a81a03685eca31a32cf69ae0c114f-refs/heads/master@{#344925}
