Publish DEPS for Chromium 46.0.2486.0
Plugin Power Saver: Fix WebViewPlugin crash caused by missing nullptr check.
In the OnZoomChanged observer function, WebViewPlugin does not check that
container_ is non-null. container_ can be nullptr if the zoom changes before
initialization, or during a phase of destruction.
BUG=521013
NOTRY=true
(because linux_chromium_rel_ng trybot acting up)
Review URL: https://codereview.chromium.org/1295913002
Cr-Commit-Position: refs/heads/master@{#343773}
Roll src/third_party/WebKit 47b413a:285b3d7 (svn 200679:200680)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/47b413a..285b3d7
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1299713005
Cr-Commit-Position: refs/heads/master@{#343772}
Remove opaque_browser_frame_view* from ChromeOS builds.
It's not used on ChromeOS and gets culled by the linker when
in a static archive. But in a gn's source set an error manifests.
BUG=481629
Review URL: https://codereview.chromium.org/1296123002
Cr-Commit-Position: refs/heads/master@{#343771}
Roll src/third_party/WebKit 756b20a:47b413a (svn 200677:200679)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/756b20a..47b413a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296203003
Cr-Commit-Position: refs/heads/master@{#343770}
Fix HttpStreamFactoryImplTest lint issues.
BUG=521612
Review URL: https://codereview.chromium.org/1285103003
Cr-Commit-Position: refs/heads/master@{#343769}
Fix aria-label test.
BUG=520946
Review URL: https://codereview.chromium.org/1294963002
Cr-Commit-Position: refs/heads/master@{#343768}
Roll src/third_party/WebKit 857fb3c:756b20a (svn 200675:200677)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/857fb3c..756b20a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1299783002
Cr-Commit-Position: refs/heads/master@{#343767}
Roll src/third_party/WebKit 39bb173:857fb3c (svn 200674:200675)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/39bb173..857fb3c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1300733002
Cr-Commit-Position: refs/heads/master@{#343766}
mandoline: Reland "Sandbox mojo:browser and mojo:omnibox."
This is a straight reland of the previous patch; as the manual
usage of icu was removed in https://codereview.chromium.org/1281343003/.
BUG=492524
Previous Review URL: https://codereview.chromium.org/1282903002
[email protected]
Review URL: https://codereview.chromium.org/1286773002
Cr-Commit-Position: refs/heads/master@{#343765}
Remove items on long press in keyboard accessory.
BUG=428087
Review URL: https://codereview.chromium.org/1281323003
Cr-Commit-Position: refs/heads/master@{#343764}
Create list file for GN target //remoting/webapp:unit_tests
This is needed to avoid problems on platforms that limit the size of a
command line.
This CL also fixes an ordering issue that causes a GN compiler error.
Review URL: https://codereview.chromium.org/1296283002
Cr-Commit-Position: refs/heads/master@{#343763}
Updating XTBs based on .GRDs from branch master
Cr-Commit-Position: refs/heads/master@{#343762}
[chromedriver] Discard pending and scheduled navigations if the URL is unreachable.
This fixes PageLoadingTest.testShouldReturnWhenGettingAUrlThatDoesNotResolve
from the Selenium test suite, which is failing for chrome_shell.
BUG=chromedriver:1167
[email protected]
Review URL: https://codereview.chromium.org/1298053002
Cr-Commit-Position: refs/heads/master@{#343761}
aura: Create a single Env instance for aura_unittests.
Create the Env instance for running the tests in AuraTestSuite. Also fix some
flaky tests that used to install pre-target handlers on the root-window, but
did not remove them. This can cause a crash since root_window() outlives the
pre-target handlers, and synthetic mouse-events can be dispatched to the
root-window during tear-down.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/1287073004 .
Cr-Commit-Position: refs/heads/master@{#343760}
Roll src/third_party/WebKit 852375e:39bb173 (svn 200673:200674)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/852375e..39bb173
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1294223002
Cr-Commit-Position: refs/heads/master@{#343759}
Fix a crash in task_management::NewTaskManagerView::TableModel::CompareValues
Not scoping ui::TableModel::CompareValues properly made it recursive!
[email protected]
BUG=521728
Review URL: https://codereview.chromium.org/1284343006
Cr-Commit-Position: refs/heads/master@{#343758}
Add content_capabilities for test extensions
BUG=521615
[email protected]
Review URL: https://codereview.chromium.org/1287933008
Cr-Commit-Position: refs/heads/master@{#343757}
Roll src/third_party/WebKit 334b761:852375e (svn 200672:200673)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/334b761..852375e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1300713002
Cr-Commit-Position: refs/heads/master@{#343756}
Export dependency on Skia as we reference it from our headers
BUG=skia:4190
Review URL: https://codereview.chromium.org/1296923002
Cr-Commit-Position: refs/heads/master@{#343755}
Roll src/third_party/WebKit e2fde1b:334b761 (svn 200669:200672)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e2fde1b..334b761
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293263002
Cr-Commit-Position: refs/heads/master@{#343754}
Roll src/third_party/WebKit c039951:e2fde1b (svn 200667:200669)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c039951..e2fde1b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1298003006
Cr-Commit-Position: refs/heads/master@{#343753}
Roll src/third_party/WebKit e6a59d0:c039951 (svn 200666:200667)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e6a59d0..c039951
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1298003005
Cr-Commit-Position: refs/heads/master@{#343752}
Roll src/third_party/WebKit bf3c10e:e6a59d0 (svn 200665:200666)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bf3c10e..e6a59d0
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293243002
Cr-Commit-Position: refs/heads/master@{#343751}
Roll src/third_party/WebKit 3427a3b:bf3c10e (svn 200664:200665)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3427a3b..bf3c10e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290423006
Cr-Commit-Position: refs/heads/master@{#343750}
Make an application wrapper around the mandoline/tab stuff.
BUG=
Review URL: https://codereview.chromium.org/1293933002
Cr-Commit-Position: refs/heads/master@{#343749}
clang: Stop patching go.test.
The test no longer runs unless llvm-go is in bin/, and it's only getting
built if llgo is checked out. update.sh/py doesn't check out llgo, so there's
no need to patch this test anymore.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/1288953004 .
Cr-Commit-Position: refs/heads/master@{#343748}
Roll WebRTC 9708:9720, Libjingle 9707:9719
WebRTC 9708:9720
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/09924b6..fe60872
Libjingle 9707:9719
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/ebc3027..0b9cfee
TBR=sergeyu
BUG=505316
Review URL: https://codereview.chromium.org/1284353005 .
Cr-Commit-Position: refs/heads/master@{#343747}
Allow overriding Chromium-branded Android resources.
The chrome_java target includes several resources that are specific to a
Chromium-branded build (e.g. the Chromium icon and app name). It's now
possible to set a value for the GYP/GN variable
android_branding_res_dirs to override the directory in which these
branding resources live. This enables easy swapping of the resources
when building, e.g., a Google Chrome-branded build.
[email protected]
[email protected]
BUG=520794,474747
Review URL: https://codereview.chromium.org/1301613002 .
Cr-Commit-Position: refs/heads/master@{#343746}
Add CFI blacklist entries for Android/libc++.
BUG=469376
[email protected]
Review URL: https://codereview.chromium.org/1301443002
Cr-Commit-Position: refs/heads/master@{#343745}
Pre-emptive fix for new protobuf version.
Xlib.h #defines "Status", which then breaks .pb.h files.
BUG=none
TEST=none
TBR=wez
Review URL: https://codereview.chromium.org/1298753002
Cr-Commit-Position: refs/heads/master@{#343744}
Roll src/third_party/WebKit 3d672bd:3427a3b (svn 200660:200664)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d672bd..3427a3b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293183004
Cr-Commit-Position: refs/heads/master@{#343743}
Add a ShadowingAtExitManager in the base TestSuite and reset it after every test.
This ensures that any singletons or (non-leaky) lazy instances creating during a test are destroyed afterwards, which reduces the risk of modifying global state between tests.
BUG=nope
Review URL: https://codereview.chromium.org/1285853002
Cr-Commit-Position: refs/heads/master@{#343742}
Roll libvpx 19bcff86:3fe1b2a1
3fe1b2a Build libvpx with -Wno-unused-function.
50acad8 Re-enable LLVM LTO on Neon targets.
BUG=469376,505316
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1299463003 .
Cr-Commit-Position: refs/heads/master@{#343741}
Roll ffmpeg 83373252:3651d8ef
3651d8e Build ffmpeg with -Wno-unused-function.
afa8481 Use incompatible pointer config.
27114d7 Use allocator in DLL builds on Windows if "win_use_allocator_shim" is enabled.
3e111de Export "av_max_alloc", used
cc8ab10 Fix Mac compile warnings for GN build; clean up formatting
BUG=505316
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1300653002 .
Cr-Commit-Position: refs/heads/master@{#343740}
Mac: Recompute vsync parameters every 10 seconds
Continuously running the display link thread is expensive, but the vsync
parameters skew very quickly (about 0.1 msec per second, which will get
you a half-vsync off in a minute).
Strike a compromise by running the display link for a single tick, every
ten seconds.
BUG=510252
Review URL: https://codereview.chromium.org/1298513004
Cr-Commit-Position: refs/heads/master@{#343739}
Change LatencyInfo to use Flow API v2.
BUG=https://github.com/catapult-project/catapult/issues/1079
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1291243002
Cr-Commit-Position: refs/heads/master@{#343738}
Updating XTBs based on .GRDs from branch master
Cr-Commit-Position: refs/heads/master@{#343737}
clang/win: Enable -Wswitch.
BUG=505308
Review URL: https://codereview.chromium.org/1294003002
Cr-Commit-Position: refs/heads/master@{#343736}
Add a few more entries to CFI blacklist.
BUG=chromium:520760,chromium:520732,chromium:457523,chromium:517959,chromium:515347
Review URL: https://codereview.chromium.org/1298473003
Cr-Commit-Position: refs/heads/master@{#343735}
[Chromecast] Add a second external metrics collector for platform.
We need to separate platorm and cast_receiver metrics.
Set path in ExternelMetrics constructor from an argument
instead of a fixed path to be able to collect platform
and cast_receiver external metrics separately.
BUG=internal b/19639924
Review URL: https://codereview.chromium.org/1296713003
Cr-Commit-Position: refs/heads/master@{#343734}
Roll src/third_party/WebKit ed56d41:3d672bd (svn 200659:200660)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed56d41..3d672bd
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288203003
Cr-Commit-Position: refs/heads/master@{#343733}
[chromedriver] Track if the load event has fired for the current execution context.
If we haven't seen a load event yet, but we're still expecting one, keep
waiting. This prevents ChromeDriver commands from returning prematurely.
We also need to be careful to avoid waiting for the load event if we've called
window.stop() due to a timeout. Calling window.stop() will prevent the load
event from firing, so if the page has timed out, don't wait for the load event.
BUG=chromedriver:1167
[email protected]
Review URL: https://codereview.chromium.org/1294163002
Cr-Commit-Position: refs/heads/master@{#343732}
Fixes crash in Array converters
You can't call front() if the array is empty
BUG=none
TEST=covered by tests
[email protected]
Review URL: https://codereview.chromium.org/1289823007
Cr-Commit-Position: refs/heads/master@{#343731}
Roll src/third_party/WebKit 1cecc66:ed56d41 (svn 200658:200659)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1cecc66..ed56d41
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1284353004
Cr-Commit-Position: refs/heads/master@{#343730}
mac: Redraw bookmark bar view buttons when the bookmark bar changes size.
This prevents the detached bookmark bar on the NTP from failing to draw its
buttons correctly. See the bug for more details.
BUG=521025
Review URL: https://codereview.chromium.org/1288603004
Cr-Commit-Position: refs/heads/master@{#343729}
Remove the Activity Log UMA statistics
BUG=517489
Review URL: https://codereview.chromium.org/1284423003
Cr-Commit-Position: refs/heads/master@{#343728}
Roll src/third_party/WebKit c457d53:1cecc66 (svn 200656:200658)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c457d53..1cecc66
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293213002
Cr-Commit-Position: refs/heads/master@{#343727}
Check destruction after didReceiveData() in ServeAsynchronousRequest()
In addition to didReceiveResponse(), didReceiveData() can also results in
WebURLLoaderMock destruction and thus a check for destruction is needed in
WebURLLoaderMock::ServeAsynchronousRequest().
This CL replaces the destruction detection by |this_deleted_| with WeakPtr.
BUG=515850
Review URL: https://codereview.chromium.org/1274733002
Cr-Commit-Position: refs/heads/master@{#343726}
Keyboard accessory icons for card scan and settings.
BUG=428087
Review URL: https://codereview.chromium.org/1291703006
Cr-Commit-Position: refs/heads/master@{#343725}
Support latching modifier keys under Ozone
Some keyboard layouts have 'latching' keys, which either apply
a modifier while held down (like normal modifiers), or, if no
non-modifier is pressed while the latching key is down, apply
the modifier to the next non-modifier keypress. Under Ozone the
stateless layout model requires this to be handled explicitly.
BUG=518237
TEST=manual on device
Review URL: https://codereview.chromium.org/1291453003
Cr-Commit-Position: refs/heads/master@{#343724}
Roll src/third_party/skia f433bb2:6a91ad2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f433bb2..6a91ad2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
6a91ad2 [email protected] remove unused code
Review URL: https://codereview.chromium.org/1292873003
Cr-Commit-Position: refs/heads/master@{#343723}
Roll src/third_party/WebKit 138ae7e:c457d53 (svn 200655:200656)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/138ae7e..c457d53
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1300673002
Cr-Commit-Position: refs/heads/master@{#343722}
Add Rappor metrics to capture URLs explicitly navigated to by the user.
This also adds a RapporServiceBridge that exposes the RapporService in Java.
BUG=521030
Review URL: https://codereview.chromium.org/1298473002
Cr-Commit-Position: refs/heads/master@{#343721}
Treat failure to parse certificates as SSL protocol errors.
Right now, failure to parse certificates map to ERR_SSL_PROTOCOL_ERROR
(or ERR_FAILED in NSS because our error-mapping logic isn't very good
for either case), however since we use two certificate libraries
together, it's possible for BoringSSL to accept a certificate while
the platform doesn't. (Especially so because BoringSSL is still using
OpenSSL's legacy X.509 stack which is very shoddy. Also Windows will
refuse to parse things like certificates which expire on 0001-01-01.)
Today, this results in ERR_CERT_INVALID (IsCertificateError gives true)
with a NULL X509Certificate, crashing everywhere. Instead, these errors
should be treated the same as if BoringSSL internally rejected the
certificate. Map them to a new error code (for ease of debugging),
ERR_SSL_SERVER_CERT_BAD_FORMAT. IsCertificateError will return false
for this error.
We should now actually maintain the invariant that IsCertificateError
implies there is a certificate available.
The user-visible error page just inherits ERR_SSL_PROTOCOL_ERROR's
strings, as there is no meaningful difference between "BoringSSL
rejected the cert" and "BoringSSL rejected the cert but Windows didn't".
Likewise, this error is unrecoverable, matching ERR_SSL_PROTOCOL_ERROR.
This removes support for using SSLClientSocket in an environment
where X509Certificates cannot be created. With remoting no longer using
the internal plugin, this is no longer necessary.
BUG=91341
Review URL: https://codereview.chromium.org/1286793002
Cr-Commit-Position: refs/heads/master@{#343720}
Roll src/third_party/WebKit bdb0220:138ae7e (svn 200654:200655)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bdb0220..138ae7e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1294153002
Cr-Commit-Position: refs/heads/master@{#343719}
Roll src/third_party/WebKit 9b004eb:bdb0220 (svn 200653:200654)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b004eb..bdb0220
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297923003
Cr-Commit-Position: refs/heads/master@{#343718}
Fix spdy_test_util_common.cc lint issue.
Also git cl format.
BUG=521644
Review URL: https://codereview.chromium.org/1290913007
Cr-Commit-Position: refs/heads/master@{#343717}
Fix SpdyNetworkTransactionTest lint issue.
BUG=521643
Review URL: https://codereview.chromium.org/1288973004
Cr-Commit-Position: refs/heads/master@{#343716}
Change variation param for LoFi
BUG=470596
Review URL: https://codereview.chromium.org/1290783004
Cr-Commit-Position: refs/heads/master@{#343715}
Move "cast" extension whitelist JSON entry to a more appropriate
directory.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/1283133005
Cr-Commit-Position: refs/heads/master@{#343714}
Roll src/third_party/WebKit 9ee7505:9b004eb (svn 200652:200653)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9ee7505..9b004eb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1299683003
Cr-Commit-Position: refs/heads/master@{#343713}
[Telemetry] Make sure telemetry's logging.basicConfig is called first
Review URL: https://codereview.chromium.org/1301603002
Cr-Commit-Position: refs/heads/master@{#343712}
Add self to build/OWNERS.
As suggested in https://codereview.chromium.org/1292753002
BUG=
Review URL: https://codereview.chromium.org/1301593002
Cr-Commit-Position: refs/heads/master@{#343711}
content: Fix bad casts from thread-local pointers.
The classes GeofencingDispatcher, ServiceWorkerDispatcher and
BluetoothDispatcher all follow a similar pattern of maintaining a
thread-local pointer that is set to integer 1 for deleted objects. This
is incompatible with Clang's bad cast checker, which assumes that
non-zero object pointers to objects of dynamic type are valid. Fix
this by maintaining the thread-local pointer as a void*, and casting
to the relevant type only if the pointer is valid.
BUG=507755
[email protected]
Review URL: https://codereview.chromium.org/1284983003
Cr-Commit-Position: refs/heads/master@{#343710}
Reduce conversion template use for StringPiece.
Use StringPiece to get to base::String rather than attempt a
mojo::TypeConversion directly from a StringPiece.
BUG=521216
TEST=Compile successfully
Review URL: https://codereview.chromium.org/1296023002
Cr-Commit-Position: refs/heads/master@{#343709}
Roll src/third_party/WebKit 2c752be:9ee7505 (svn 200651:200652)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2c752be..9ee7505
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1298743003
Cr-Commit-Position: refs/heads/master@{#343708}
Android Media Notification: add stop button for Android pre-L.
Starting from Android L, it is possible to dismiss the notification
when the service is no longer in foreground.
This change allows users of Android J and K to use a STOP button which
will pause the media playback and dismiss the notification. The downside
is a reduced area to show the media information.
BUG=515129
Review URL: https://codereview.chromium.org/1297763002
Cr-Commit-Position: refs/heads/master@{#343707}
[Android] Mark remaining CustomTabExternalNavigationTests as flaky.
BUG=519613
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289813006
Cr-Commit-Position: refs/heads/master@{#343706}
Fix IOThread lint issues.
BUG=521605
Review URL: https://codereview.chromium.org/1287933006
Cr-Commit-Position: refs/heads/master@{#343705}
Fetch and cache the number of cores before sandbox initialization.
This is necessary on Linux since trying to get this information after the sandbox has been enabled, will give incorrect information (always 1).
BUG=176522,521621
Review URL: https://codereview.chromium.org/1291583003
Cr-Commit-Position: refs/heads/master@{#343704}
Fix HttpNetworkTransactionTest lint issues.
Plus git cl format.
BUG=521610
Review URL: https://codereview.chromium.org/1292303004
Cr-Commit-Position: refs/heads/master@{#343703}
Attempted to update the force mic volume binary to a freshly built one.
BUG=521564
Review URL: https://codereview.chromium.org/1299673002
Cr-Commit-Position: refs/heads/master@{#343702}
Roll src/third_party/skia 29553b3:f433bb2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/29553b3..f433bb2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
f433bb2 [email protected] SkPaintFilterCanvas should inherit the target canvas state
340f307 [email protected] Fix webp compile warnings on windows
Review URL: https://codereview.chromium.org/1287933007
Cr-Commit-Position: refs/heads/master@{#343701}
Convert components/tracing from static lib to component
This is a prerequisite for https://crrev.com/1292583002.
BUG=518823
Review URL: https://codereview.chromium.org/1298683002
Cr-Commit-Position: refs/heads/master@{#343700}
Roll src/third_party/WebKit 82f1a8d:2c752be (svn 200650:200651)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/82f1a8d..2c752be
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293163002
Cr-Commit-Position: refs/heads/master@{#343699}
Adding [email protected] as an owner of AppleScript
Adding [email protected] as a OWNER for AppleScript
BUG=
Review URL: https://codereview.chromium.org/1290783002
Cr-Commit-Position: refs/heads/master@{#343698}
Roll src/third_party/WebKit ed6c93b:82f1a8d (svn 200649:200650)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed6c93b..82f1a8d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292753003
Cr-Commit-Position: refs/heads/master@{#343697}
<webview>: Add better loadabort reason messages
BUG=341097
Note: ERR_INVALID_URL and ERR_DISALLOWED_SCHEME are not defined in webview tag docs (https://developer.chrome.com/apps/tags/webview#event-loadabort)
Review URL: https://codereview.chromium.org/1292353003
Cr-Commit-Position: refs/heads/master@{#343696}
Roll src/third_party/WebKit 89102e6:ed6c93b (svn 200647:200649)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/89102e6..ed6c93b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297833004
Cr-Commit-Position: refs/heads/master@{#343695}
customtabs: Fix the background process check.
The test is inverted in the current version. Facepalm.
BUG=517527
Review URL: https://codereview.chromium.org/1287713004
Cr-Commit-Position: refs/heads/master@{#343694}
Content settings clean-up: removing unused include
BUG=399895
Review URL: https://codereview.chromium.org/747953002
Cr-Commit-Position: refs/heads/master@{#343693}
Roll src/third_party/WebKit e3be828:89102e6 (svn 200646:200647)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e3be828..89102e6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296483004
Cr-Commit-Position: refs/heads/master@{#343692}
Deflake ContentViewCoreSelectionTest.testSelectActionBarPasswordPaste
The previous version of the test was racy and sensitive to text handle
positions when interacting with DOM nodes. Modify the test with the
proper sync points to properly test pasting into password fields.
BUG=518848
Review URL: https://codereview.chromium.org/1296473002
Cr-Commit-Position: refs/heads/master@{#343691}
Don't reload twice in key_mobile_sites
The Linkedin and WoW wiki pages in key_mobile_sites reload themselves
before scrolling to take advantage of the browser's shader cache.
However this reload is currently implemented as a reload plus a
navigation. Since the navigation has more or less the same effect as a
reload, the reload step is redundant.
This patch removes the explicit reload step. This will make the
benchmark slightly faster, and with any luck, make it less flaky[1] on
some downstream bots.
Note that replacing the second navigation with just the reload doesn't
work because the reload does not reset the scroll offset, leaving us at
the bottom of the page.
[1] https://go/lhivi
Review URL: https://codereview.chromium.org/1296223002
Cr-Commit-Position: refs/heads/master@{#343690}
Roll src/third_party/skia 4a75dd3:29553b3
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4a75dd3..29553b3
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
29553b3 [email protected] Revert of drawBitmapImage can batch across AA rects (patchset #5 id:80001 of https://codereview.chromium.org/1293543002/ )
0d4bcea [email protected] drawBitmapImage can batch across AA rects
Review URL: https://codereview.chromium.org/1298713002
Cr-Commit-Position: refs/heads/master@{#343689}
Android Media Notification: stop the MediaSession when dismissed.
The current behaviour is to simply dismiss the notification but the
WebContents and content::MediaSession will consider the session still
running while the user's intent was to actually stop it. As a result,
the WebContents will still receive notification about the session
changes, for example, when Chrome will lose/re-gain audio focus. These
notifications will re-introduce the Notification (in a paused state).
BUG=515129
Review URL: https://codereview.chromium.org/1294863002
Cr-Commit-Position: refs/heads/master@{#343688}
Roll src/third_party/WebKit 37b70da:e3be828 (svn 200645:200646)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/37b70da..e3be828
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285183007
Cr-Commit-Position: refs/heads/master@{#343687}
Ensure we pass on the --no-sandbox to the callstack browser tests when it's specified for TSAN.
Also disable the tests for official builds, since we don't open the security holes required for symbolization there.
BUG=521465,521554,517488
[email protected]
Review URL: https://codereview.chromium.org/1291343003
Cr-Commit-Position: refs/heads/master@{#343686}
Popular sites on the NTP: Try to keep the ordering constant
The popular suggestions determine the order, but are still replaced by personal suggestions when they exist.
BUG=516618
Review URL: https://codereview.chromium.org/1291163004
Cr-Commit-Position: refs/heads/master@{#343685}
Componentize variations_request_scheduler*
These files are shared with iOS. They have no problematic dependencies, so
componentization is straightforward.
BUG=516660
TBR=phajdan.jr
Review URL: https://codereview.chromium.org/1283443002
Cr-Commit-Position: refs/heads/master@{#343684}
Rebaseline global-interface-listing-expected.txt
Due to crrev.com/1289803002 (Enable ServiceWorkerPerformanceTimeline flag for stable)
BUG=506603
[email protected]
Review URL: https://codereview.chromium.org/1291323003
Cr-Commit-Position: refs/heads/master@{#343683}
Roll src/third_party/WebKit f91cf5f:37b70da (svn 200644:200645)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f91cf5f..37b70da
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1294953003
Cr-Commit-Position: refs/heads/master@{#343682}
This is a field trial for experimenting with several different resource scheduling changes (individually controllable):
- Increasing the priority of fonts
- Decreasing the priority of late-body scripts
- Increasing the priority of Async JS
- Reducing the contention during the initial load of head resources
Doc that describes the rationale behind all of the changes is here: https://docs.google.com/document/d/1bCDuq9H1ih9iNjgzyAL0gpwNFiEP4TZS-YLRp_RuMlc/edit?usp=sharing
Blink side of the change is here: https://codereview.chromium.org/1246493002/
BUG=317785, 517902, 517904
Review URL: https://codereview.chromium.org/1230133005
Cr-Commit-Position: refs/heads/master@{#343681}
Add melandory@ as OWNER of password manager Android files
malndory@ worked with these files a lot, and is an Android go-to person in the password manager team in our office.
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/1296953002
Cr-Commit-Position: refs/heads/master@{#343680}
Mandoline: Enable Android software keyboard for the Omnibox.
BUG=498624
Review URL: https://codereview.chromium.org/1286383003
Cr-Commit-Position: refs/heads/master@{#343679}
Add dvadym to password manager OWNERS
Vadym has worked on and understood the password manager code for some time now, he'll make a valuable owner.
[email protected],[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/1299653002
Cr-Commit-Position: refs/heads/master@{#343678}
Add GenericSharedMemoryId and use w/ GpuMemoryBuffer
Adds a GenericSharedMemoryId type which will be used to track various types of shared memory (SharedBitmap, IOSurface, base::SharedMemory).
Wire up GpuMemoryBufferManager so that GpuMemoryBufferId is just a typedef of this type, setting up for further integration in the future.
Note regarding message changes - We needed a way for all GenericSharedMemoryIds used by a process to be unique. Currently a renderer process sometimes internally allocates shared memory and sometimes asks the browser process to do so. In order to allow for consistent naming, we cause the Renderer process to provide an ID to the browser when asking the browser to allocate on its behalf.
+tsepez for message changes.
+piman for content/gpu changes
+danakj/reveman for other changes.
[email protected]
BUG=512534
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1280513002
Cr-Commit-Position: refs/heads/master@{#343677}
Revert of gpu: workaround force_cube_map_positive_x_allocation fixes Android crash. (patchset #10 id:180001 of https://codereview.chromium.org/1280163004/ )
Reason for revert:
Causing failures on the Linux AMD GPU FYI bot.
[ RUN ] GLCubeMapTextureTests/GLCubeMapTextureTest.ReadPixelsFromIncompleteFBO/5
Received signal 11 SEGV_MAPERR 000000000058
#0 0x000000486a35 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fe9b624ecb0 <unknown>
#2 0x7fe9b31f6b9e <unknown>
#3 0x7fe9b3209948 <unknown>
#4 0x7fe9b31d9d02 <unknown>
#5 0x7fe9b31d426e <unknown>
#6 0x7fe9b2fec29b <unknown>
#7 0x7fe9b268badd <unknown>
#8 0x0000005138c6 gpu::gles2::Framebuffer::GetStatus()
#9 0x000000537936 gpu::gles2::GLES2DecoderImpl::CheckFramebufferValid()
Original issue's description:
> gpu: workaround force_cube_map_positive_x_allocation fixes Android crash.
>
> Adreno Android (e.g. Nexus5) crashes on allocating a cube map texture bound to FBO, if
> the CUBE_MAP_POSITIVE_X texture is not allocated yet. The Workaround forces to allocate
> the CUBE_MAP_POSITIVE_X texture.
>
> Add new unittests to prevent regression. ANGLE crashes on GLCubeMapTextureTest.ReadPixels
> It's will be fixed in ANGLE project.
>
> TEST=gl_tests.GLCubeMapTextureTests.*
> BUG=518889
>
> Committed: https://crrev.com/1eebeac3e05c2035139c04226b34cef745cfd822
> Cr-Commit-Position: refs/heads/master@{#343600}
[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518889
Review URL: https://codereview.chromium.org/1293123002
Cr-Commit-Position: refs/heads/master@{#343676}
Lock video controls' position during fullscreen
Problem:
Video controls can be scrolled (moved) when
an Android WebView does fullscreen-video.
Solution:
When visual viewport's scrolling is disabled
using setUserScrollable(false, false), do
also disable over-scrolling (do not send
overscroll-events to the Android WebView).
BUG=448738
TEST=
1. Start com.android.browser and go to
http://robnyman.github.io/fullscreen/ .
2. Start video playback.
3. Go fullscreen on video.
4. Fling the screen.
5. Notice 1: Video controls cannot move.
6. Notice 2: No "over glow" (compare with
Android Chrome or Lollipop's WebView).
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1228423002
Cr-Commit-Position: refs/heads/master@{#343675}
[Presentation API, Android] Implemented media sinks observers for Cast
Second try of landing https://codereview.chromium.org/1288083002
I didn't find the reason the tests fail on the bots so I will submit them later.
BUG=517091
Review URL: https://codereview.chromium.org/1293683004
Cr-Commit-Position: refs/heads/master@{#343674}
Added bartfab & atwilson as DeviceLocalAccount per-file owners
BUG=none
Review URL: https://codereview.chromium.org/1289193002
Cr-Commit-Position: refs/heads/master@{#343673}
Popular sites on the NTP: Allow blacklisting
This re-uses the existing TopSites blacklist, which is now updated even when the SuggestionsService is active.
BUG=516618
Review URL: https://codereview.chromium.org/1290723002
Cr-Commit-Position: refs/heads/master@{#343672}
Let PasswordFormManagerTest have an instance of the TestPasswordManager as a member
Replace the repeated local creation of the same class over again.
Also provide a non-null PasswordManager to every PasswordFormManager. This will be important in the coming CLs where calling SimulateMatchingPhase on a PasswordFormManager will be replaced with calling OnGetPasswordStoreResults, which dereferences the passed PasswordManager.
BUG=520831
Review URL: https://codereview.chromium.org/1296823002
Cr-Commit-Position: refs/heads/master@{#343671}
Roll src/third_party/WebKit a6aa09b:f91cf5f (svn 200643:200644)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a6aa09b..f91cf5f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296213002
Cr-Commit-Position: refs/heads/master@{#343670}
Roll src/third_party/WebKit 9245dc2:a6aa09b (svn 200642:200643)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9245dc2..a6aa09b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1294103003
Cr-Commit-Position: refs/heads/master@{#343669}
Componentize OmniboxMetricsProvider for sharing with iOS
The class has no problematic dependencies, so componentization is
straightforward.
BUG=508022
Review URL: https://codereview.chromium.org/1274393002
Cr-Commit-Position: refs/heads/master@{#343668}
[Download Notification] Sort items in the group notification
This patch makes the items in the group notification sorted by their download id in descending order, so that the newest item is at the top.
BUG=518044
TEST=Modified borowser_test passes
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1287803003
Cr-Commit-Position: refs/heads/master@{#343667}
Roll src/third_party/WebKit 0a67770:9245dc2 (svn 200641:200642)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a67770..9245dc2
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1284033004
Cr-Commit-Position: refs/heads/master@{#343666}
Roll src/third_party/WebKit 05e9d95:0a67770 (svn 200640:200641)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/05e9d95..0a67770
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292163004
Cr-Commit-Position: refs/heads/master@{#343665}
Roll src/third_party/WebKit 6b31dcf:05e9d95 (svn 200639:200640)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6b31dcf..05e9d95
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297943002
Cr-Commit-Position: refs/heads/master@{#343664}
Revert "Ensure fullscreen media control bar is persistent"
Above CL is no longer needed. After a revert, the zoom-
problem does no longer exist. Let's revert to reduce
complexity.
When video enters fullscreen the inner viewport is not
scrollable (and thus not zoomable) so we don't need
to suppress pinch-zoom up in ContentVideoView anymore.
BUG=448738
TEST=Media controls cannot be zoomed during fullscreen
video in neither ChromePublic nor com.android.browser.
Review URL: https://codereview.chromium.org/1295453003
Cr-Commit-Position: refs/heads/master@{#343663}
Remove listening of OMNIBOX_OPENED_URL from metrics code
I am working to eliminate this notification entirely, as its usage is impeding
iOS upstreaming (see bug for details). This CL replaces its usage in
//chrome/browser/metrics with usage of OmniboxEventGlobalTracker.
BUG=517885
Review URL: https://codereview.chromium.org/1282473002
Cr-Commit-Position: refs/heads/master@{#343662}
Move variations prefs into the variations component
These prefs are used by variations code that is targeted for componentization.
BUG=382865
TBR=thakis
Review URL: https://codereview.chromium.org/1265423003
Cr-Commit-Position: refs/heads/master@{#343661}
Roll src/third_party/WebKit 543711f:6b31dcf (svn 200638:200639)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/543711f..6b31dcf
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292283003
Cr-Commit-Position: refs/heads/master@{#343660}
Roll src/third_party/WebKit fd0c470:543711f (svn 200637:200638)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fd0c470..543711f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296893003
Cr-Commit-Position: refs/heads/master@{#343659}
Remove the debug outputs
The patch I added to fix the flakiness contained the debug outputs. This patch removes them.
BUG=521494
TESTnone
[email protected]
Review URL: https://codereview.chromium.org/1295093004
Cr-Commit-Position: refs/heads/master@{#343658}
Fixing an unlocking bug in ProximityAuthBleSystem.
Currently, when the ProximityAuthBleSystem is active (i.e. the
--enable-proximity-auth-bluetooth-low-energy-discovery flag is set)
even when the UI display an unlock state, we are not able to
unlock the screen. Pressing space leaves the screen locked.
This CL fixes this issue.
BUG=
Review URL: https://codereview.chromium.org/1297673002
Cr-Commit-Position: refs/heads/master@{#343657}
dbus: Suppress "Rejecting a message from a wrong sender" error from ObjectManager
The error message was a false alarm that was polluting the log file.
ObjectManager::HandleMessage() is called for *every instance of ObjectManager*
whenever a message is delivered. It's the right thing for an ObjectManager instance
to ignore a signal that the instance is not interested in.
Note that the service owner name change is handled via
ObjectManager::NameOwnerChanged(), that's set up in the ObjectManager's constructor
hence ObjectManager can handle name owner changes.
BUG=507206
TEST=enable/disable Bluetooth and confirm that the error message is no longer emitted in the log file.
Review URL: https://codereview.chromium.org/1297903002
Cr-Commit-Position: refs/heads/master@{#343656}
Roll src/third_party/WebKit 2e7167b:fd0c470 (svn 200636:200637)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2e7167b..fd0c470
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1294073002
Cr-Commit-Position: refs/heads/master@{#343655}
Fix a wrong histogram name in BrowsingDataRemover.
In histograms.xml, this histogram is named History.ClearBrowsingData.UserDeletedCookieOrCache. However, in BrowsingDataRemover, it is referred to without the "History." prefix.
In other words, embarrassingly, we have no data for the past two weeks.
BUG=514592
Review URL: https://codereview.chromium.org/1290893003
Cr-Commit-Position: refs/heads/master@{#343654}
Roll src/third_party/WebKit b59996d:2e7167b (svn 200634:200636)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b59996d..2e7167b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287113005
Cr-Commit-Position: refs/heads/master@{#343653}
Revert of Record the XMPP error in remoting.FormatIq. (patchset #4 id:60001 of )
Reason for revert:
Win x64 GN bot failure.
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool action-wrapper environment.x86 __remoting_webapp_build_unittest___build_toolchain_win_x64__rule.rsp
The command line is too long.
Original issue's description:
> Record the XMPP error in remoting.FormatIq.
>
> This CL
> 1. Records the XMPP error type, jingle_action and error condition
> in remoting.FormatIq.
> This error is later extracted by the ClientSession to upload along
> with session state change events.
>
> We choose to record the error in the webapp instead of the plugin to
> avoid adding new contract between the webapp and the plugin just for
> the sake of debugging, especially when we are so close to branch point.
> 2. Removes some legacy fields in the FormatIq to avoid parse errors.
> 3. Parses the error before the original jingle message. This ensures
> addition of unrecognized Jingle fields like QUIC will not break the
> error parsing.
>
> BUG=509070
>
> Committed: dba42ad74eb89a6663304462e6538ba568
> Cr-Commit-Position: refs/heads/master@{#343532}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509070,521522
Review URL: https://codereview.chromium.org/1293103002
Cr-Commit-Position: refs/heads/master@{#343652}
Clean up the mediastream migration pref.
We removed the mediastream->camera/mic migration code from content_settings::DefaultProvider, but didn't clean up the associated preference.
BUG=443799
Review URL: https://codereview.chromium.org/1255243004
Cr-Commit-Position: refs/heads/master@{#343651}
Fix flakiness in MultiProfileDownloadNotificationTest.DownloadMultipleFiles
We need to add a handler before the url request
BUG=521494
TEST=Run browser_tests 10 times and all pass
[email protected]
Review URL: https://codereview.chromium.org/1294063002
Cr-Commit-Position: refs/heads/master@{#343650}
Update per-file password_manager* to match component OWNERS
The per-file password_manager* owners in //components/OWNERS should match //components/password_manager/OWNERS.
BUG=None
Review URL: https://codereview.chromium.org/1301553002
Cr-Commit-Position: refs/heads/master@{#343649}
Open from clipboard: Support nil clipboard
Starting with iOS9 beta 5, the clipboard string can be nil in some
circonstances.
Consider this as a temporary access error and not a pasteboard change.
Review URL: https://codereview.chromium.org/1293693006
Cr-Commit-Position: refs/heads/master@{#343648}
Gallery: fix a bug that overwrite original checkbox does not work.
BUG=521502
TEST=manually tested as described in the issue.
Review URL: https://codereview.chromium.org/1296013003
Cr-Commit-Position: refs/heads/master@{#343647}
Roll src/third_party/WebKit a201b99:b59996d (svn 200633:200634)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a201b99..b59996d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296873002
Cr-Commit-Position: refs/heads/master@{#343646}
Add owners for ios/public/provider/chrome/browser/signin.
This CL adds msarda and bzanotti owners for
ios/public/provider/chrome/browser/signin.
BUG=NONE
Review URL: https://codereview.chromium.org/1298653002
Cr-Commit-Position: refs/heads/master@{#343645}
Makes QueryHistory take a const ref& rather then a value
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1294733004
Cr-Commit-Position: refs/heads/master@{#343644}
Include missing header in signin_header_helper.h.
The struct ManageAccountsParams has different entries on iOS than
on other platforms. This CL includes |build/build_config.h| to ensure
that OS_IOS macro is correctly defined.
The crash occurred because clients and implementation had a different
view of the struct ManageAccountsParams.
BUG=520957
Review URL: https://codereview.chromium.org/1287933004
Cr-Commit-Position: refs/heads/master@{#343643}
Fixing BluetoothLowEnergyConnectionFinder reconnection bug.
We should not remove the |adapter_| observer when |HandleDeviceUpdated|
is called. Otherwise, if the current connection fails, we don't try to
connect again, as no |DeviceChanged| notification is fired.
BUG=
Review URL: https://codereview.chromium.org/1298433002
Cr-Commit-Position: refs/heads/master@{#343642}
Make testDone unavailable for chromevox tests.
the testDone function is easy to use incorrectly and is from now on
banned from chromevox tests. This cl removes all uses and adjsuts
some tests accordingly. As a result, some chromevox next tests are
disabled (because they never ran properly and are actually broken).
This also fixes a race in the code that determines if chromevox classic
should be enabled in a content script or not. This affected tests
since they load multiple tabs simultaneously, but could also happen
in actual usage since the time window for the race to trigger is on the
order of seconds.
BUG=520938,520940,520946
Review URL: https://codereview.chromium.org/1295773002
Cr-Commit-Position: refs/heads/master@{#343641}
Unit test need not provide a Default.png file.
testing/gtest.gyp already provides a Default.png in "mac_bundle_resources"
so tests dependening on that target need not provide such a file otherwise
we get a warning from ninja due to multiple rules generating the same
output.
Fix the following warning:
ninja: warning: multiple rules generate crnet_test.app/Default.png. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
TEST=Delete out/Debug/crnet_test.app, rebuild it with the patch applied and
check that 1. the warning is no longer displayed, 2. that a file named
out/Debug/crnet_test.app/Default.png exists.
BUG=520560
Review URL: https://codereview.chromium.org/1294753002
Cr-Commit-Position: refs/heads/master@{#343640}
Roll src/third_party/WebKit 7d4ef9b:a201b99 (svn 200630:200633)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7d4ef9b..a201b99
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297923002
Cr-Commit-Position: refs/heads/master@{#343639}
Roll src/third_party/WebKit 9d89447:7d4ef9b (svn 200628:200630)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9d89447..7d4ef9b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293643003
Cr-Commit-Position: refs/heads/master@{#343638}
Add engedy@ to password manager OWNERS
BUG=None
Review URL: https://codereview.chromium.org/1287913003
Cr-Commit-Position: refs/heads/master@{#343637}
Disable ContentBrowserTest.RendererCrashCallStack on XP and Win component build.
For XP, we know stdout redirection doesn't work.
For win component, PDBs aren't sent to swarming.
BUG=521459
[email protected]
Review URL: https://codereview.chromium.org/1301513002
Cr-Commit-Position: refs/heads/master@{#343636}
Suppress -Woverloaded-virtual for mesa's glsl library.
BUG=505301
Review URL: https://codereview.chromium.org/1298573002
Cr-Commit-Position: refs/heads/master@{#343635}
Update expectations for a 0.02% size regression for chrome/chrome.
Cr-Commit-Position: refs/heads/master@{#343634}
Roll src/third_party/WebKit 9c9c4ae:9d89447 (svn 200627:200628)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9c9c4ae..9d89447
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1297893002
Cr-Commit-Position: refs/heads/master@{#343633}
Roll PDFium 24fbf13..fdc8f43
https://pdfium.googlesource.com/pdfium.git/+log/24fbf13..fdc8f43
BUG=505316
[email protected]
TBR=thestig
Review URL: https://codereview.chromium.org/1285343003 .
Cr-Commit-Position: refs/heads/master@{#343632}
text-input: Replaces unordered_map with base::hash_map.
According to a comment at
https://codereview.chromium.org/430463005/diff/160001/ui/events/x/keysym_to_unicode.cc#newcode38
replace unordered_map with base::hash_map.
BUG=
Review URL: https://codereview.chromium.org/1294703003
Cr-Commit-Position: refs/heads/master@{#343631}
Update sizes
Cr-Commit-Position: refs/heads/master@{#343630}
Roll src/third_party/WebKit 17522b4:9c9c4ae (svn 200625:200627)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/17522b4..9c9c4ae
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1287183003
Cr-Commit-Position: refs/heads/master@{#343629}
Update fade classes even if the range of visible items are not changed.
BUG=520473
TEST=None
Review URL: https://codereview.chromium.org/1288123003
Cr-Commit-Position: refs/heads/master@{#343628}
Remove the array keyed off ContentSettingsType in PolicyProvider and replace with a map
The array of managed default prefs which is keyed to ContentSettingsType is
fairly sparsely populated. Rather than have it keyed to ContentSettingsType,
instead create an array which maps ContentSettingsType to the default policy
pref name (similar to what we do for the Allowed/Blocked URL prefs). This
means that when a new content setting is added, this array doesn't need to be
updated.
I did consider adding this to WebsiteSettingsInfo but it seems like the
exception (rather than the rule) to add a new policy pref. Also there are
some inconsistencies which make it hard to do this cleanly, e.g. the
same mediastream pref is used for both camera and mic). I would rather
leave this to a later cleanup.
BUG=512683
Review URL: https://codereview.chromium.org/1276683004
Cr-Commit-Position: refs/heads/master@{#343627}
Print stack traces in browser tests when any process crashes, or an assert fires.
The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from processes on all platforms and not just Linux (i.e. to be able to debug the large flakiness that occurred last week). This is disabled for official builds.
Also make release (non-official) builds print the callstack on asserts, just like debug builds. This makes it easier to debug test failures on the CQ (for example, DCHECKs for non-threadsafe usage of pointers).
Add a regression test that both renderer and browser process crashes print the callstack.
BUG=517488,358267,521148
NOPRESUBMIT=true
Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975
Cr-Commit-Position: refs/heads/master@{#343240}
Review URL: https://codereview.chromium.org/1291553003
Cr-Commit-Position: refs/heads/master@{#343626}
Roll src/third_party/WebKit 5baf25d:17522b4 (svn 200623:200625)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5baf25d..17522b4
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1292383006
Cr-Commit-Position: refs/heads/master@{#343625}
Revert of Enable and fix tests after page serializer merge (patchset #1 id:1 of https://codereview.chromium.org/1219923010/ )
Reason for revert:
Needs to revert Blink 198503, which this depends on.
Original issue's description:
> Enable and fix tests after page serializer merge
>
> Enable and fix two SavePageBrowserTests and two BrowserEncodingTest that
> where removed in <https://codereview.chromium.org/1218743006/> in
> preparation of the page serializer merger in
> <https://codereview.chromium.org/1177733003/>.
>
> Patch from [email protected]
>
> [email protected], [email protected]
> BUG=328354
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bbf281076da0c593ec9d586eb78b2498581d070e
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=328354,510422
Review URL: https://codereview.chromium.org/1301503003 .
Cr-Commit-Position: refs/heads/master@{#343624}
Roll src/third_party/WebKit 90b25ae:5baf25d (svn 200622:200623)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/90b25ae..5baf25d
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1300513004
Cr-Commit-Position: refs/heads/master@{#343623}
Revert of Enable and fix tests after page serializer merge (patchset #1 id:1 of https://codereview.chromium.org/1228033002/ )
Reason for revert:
Need to revert Blink 198151, which this depends on.
Original issue's description:
> Enable and fix tests after page serializer merge
>
> Re-enable tests that was disabled in DomSerializerTests in
> https://codereview.chromium.org/106023004 and
> https://codereview.chromium.org/115163002 due to the page serializer
> merges.
>
> [email protected]
> BUG=328354
>
> Committed: https://crrev.com/95a0afbeed27726ba4661262c97f1ac57a87318c
> Cr-Commit-Position: refs/heads/master@{#338339}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=328354,510422
Review URL: https://codereview.chromium.org/1296133002
Cr-Commit-Position: refs/heads/master@{#343622}
Updating trunk VERSION from 2485.0 to 2486.0
Cr-Commit-Position: refs/heads/master@{#343621}
Introduce TabStripModelStatsRecorder class to record tab interaction stats
This CL introduces TabStripModelStatsRecorder class.
TabStripModelStatsRecorder will be used to hook TabStripModelObserver
callbacks to record user tab interaction stats.
The TabStripModelStatsRecorder class is instantiated once per browser
process via UMABrowsingActivityObserver, and it observes BrowserList
to register itself as TabStripModelObserver for all chrome windows.
BUG=517335
Review URL: https://codereview.chromium.org/1286433004
Cr-Commit-Position: refs/heads/master@{#343620}
Roll src/third_party/WebKit f77b3f0:90b25ae (svn 200621:200622)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f77b3f0..90b25ae
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1296823003
Cr-Commit-Position: refs/heads/master@{#343619}
Roll src/third_party/WebKit 85bfb3f:f77b3f0 (svn 200620:200621)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/85bfb3f..f77b3f0
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1293073002
Cr-Commit-Position: refs/heads/master@{#343618}
Roll src/third_party/WebKit 56fba16:85bfb3f (svn 200619:200620)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/56fba16..85bfb3f
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1301503002
Cr-Commit-Position: refs/heads/master@{#343617}
Roll src/third_party/WebKit f190969:56fba16 (svn 200618:200619)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f190969..56fba16
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1290223004
Cr-Commit-Position: refs/heads/master@{#343616}
Roll src/third_party/WebKit 6e8e782:f190969 (svn 200617:200618)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6e8e782..f190969
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1285383003
Cr-Commit-Position: refs/heads/master@{#343615}
[Telemetry] Add filename & funcname to telemetry log.
This makes it handy to figure where the log comes from.
[email protected]
Review URL: https://codereview.chromium.org/1288553005
Cr-Commit-Position: refs/heads/master@{#343614}
Disable flaky FtpBrowserTest.DirectoryListingNavigation on Windows.
BUG=521409
[email protected]
Review URL: https://codereview.chromium.org/1287953004
Cr-Commit-Position: refs/heads/master@{#343613}
Disable ExtensionApiTest.TabMuted as it's flaky.
BUG=521410
[email protected]
Review URL: https://codereview.chromium.org/1291623003
Cr-Commit-Position: refs/heads/master@{#343612}
Reland of [Download Notification] Update notification as progress type on complete/cancel
The original patch had committed in https://crrev.com/e9f08c08, but was reverted due to the test flakiness. So I fixed it by modifying the test and try relanding the patch.
(original description)
[Download Notification] Update notification as progress type on complete/cancel
We have had the code showing notification as progress type once before showing it as base type. But it didn't work due to a bug (see the comment in the review for detail). This patch fixes it and refactor the code to make the code clear.
BUG=518698
TEST=manually tested
[email protected]
Review URL: https://codereview.chromium.org/1300553002
Cr-Commit-Position: refs/heads/master@{#343611}
Use PasswordFormManagerTest::client instead of local client in tests
Locally defined clients were the same as PasswordFormManagerTest::client
BUG=520831
Review URL: https://codereview.chromium.org/1288553004
Cr-Commit-Position: refs/heads/master@{#343610}
Replaced GetPendingCredentials with PasswordFormManager::pending_credentials
BUG=520831
Review URL: https://codereview.chromium.org/1294023002
Cr-Commit-Position: refs/heads/master@{#343609}
Route browser reload command to DevTools if present.
DevTools augments reloading with extra actions like recording the timeline.
Let reload go through DevTools if browser command triggered it, similarly to
how it already goes for Ctrl+R shortcut.
BUG=521057
Review URL: https://codereview.chromium.org/1292403004
Cr-Commit-Position: refs/heads/master@{#343608}
Focus DONE button on last Enterprise Enrollment card
BUG=514207
TEST=Go through new Enterprise Enrollment flow. Upon successful signin
("...successfully enrolled..."), the DONE button should start with
focus, and respond to the ENTER key. Also, upon failure (e.g. trying
EE with a non-enterprise account), the TRY AGAIN button should also
start with focus.
Review URL: https://codereview.chromium.org/1289983005
Cr-Commit-Position: refs/heads/master@{#343607}
[Download Notification] Match status strings in DownloadItemNotification with the UX mock
This patch changes the strings in download notification, to match them with the spec. This patch introduces the methods for the status text in download notification, instead of using the common method with the download tray, to show the dedicated strings to download notification.
BUG=518040
TEST=manually tested
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1277413003
Cr-Commit-Position: refs/heads/master@{#343606}
Roll src/third_party/WebKit 1f0977b:6e8e782 (svn 200616:200617)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1f0977b..6e8e782
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1295733003
Cr-Commit-Position: refs/heads/master@{#343605}
Roll src/third_party/WebKit 834c643:1f0977b (svn 200614:200616)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/834c643..1f0977b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1289083005
Cr-Commit-Position: refs/heads/master@{#343604}
Revert of Print stack traces in child processes when browser tests failed. (patchset #5 id:80001 of https://codereview.chromium.org/1291553003/ )
Reason for revert:
This is unfortunately breaking Windows 10 in a major way. I did a local bisect and narrowed it down to this CL.
BUG=521242
Original issue's description:
> Print stack traces in child processes when browser tests failed.
>
> The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds.
>
> BUG=517488,358267
>
> Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975
> Cr-Commit-Position: refs/heads/master@{#343240}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517488,358267
Review URL: https://codereview.chromium.org/1299583002
Cr-Commit-Position: refs/heads/master@{#343603}
[Android] Revise recovery logic in device_status_check.
The current logic seems to be causing problems on the N6 perf bot:
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf
BUG=
Review URL: https://codereview.chromium.org/1299573002
Cr-Commit-Position: refs/heads/master@{#343602}
Roll src/third_party/skia 8a41adb:4a75dd3
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8a41adb..4a75dd3
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
4a75dd3 [email protected] Update SKP version
Review URL: https://codereview.chromium.org/1295793003
Cr-Commit-Position: refs/heads/master@{#343601}
gpu: workaround force_cube_map_positive_x_allocation fixes Android crash.
Adreno Android (e.g. Nexus5) crashes on allocating a cube map texture bound to FBO, if
the CUBE_MAP_POSITIVE_X texture is not allocated yet. The Workaround forces to allocate
the CUBE_MAP_POSITIVE_X texture.
Add new unittests to prevent regression. ANGLE crashes on GLCubeMapTextureTest.ReadPixels
It's will be fixed in ANGLE project.
TEST=gl_tests.GLCubeMapTextureTests.*
BUG=518889
Review URL: https://codereview.chromium.org/1280163004
Cr-Commit-Position: refs/heads/master@{#343600}
Automated Commit: Committing new LKGM version 7366.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#343599}
Resize a RemoteFrame's RWHView when we get notified of a resize from blink.
This is dependent on blink CL:
https://codereview.chromium.org/1273743004/
BUG=517291
Test=With --site-per-process, load a cross origin <iframe>, resize it
using JavaScript, e.g.
document.querySelector('iframe').style.width = '400px';
Notice that
1) this should not clip the iframe if new width is smaller.
2) this should not introduce gutter around the iframe if the new width is larger.
Review URL: https://codereview.chromium.org/1272573007
Cr-Commit-Position: refs/heads/master@{#343598}
Updating trunk VERSION from 2484.0 to 2485.0
Cr-Commit-Position: refs/heads/master@{#343597}
[2/3 chromium] Support redirect option of Request and "opaqueredirect" response type.
https://crbug.com/510650#c4 describes the details of the data flow.
1/3 blink: https://codereview.chromium.org/1265133002/
2/3 chromium: This
3/3 blink: https://codereview.chromium.org/1280733002/
BUG=510650,517837
Review URL: https://codereview.chromium.org/1271733002
Cr-Commit-Position: refs/heads/master@{#343596}
Roll src/third_party/WebKit be0ec31:834c643 (svn 200613:200614)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/be0ec31..834c643
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1290563004
Cr-Commit-Position: refs/heads/master@{#343595}
Roll src/third_party/skia fb28cd2:8a41adb
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fb28cd2..8a41adb
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
8a41adb [email protected] support both box and circle lcd
5f629b4 [email protected] show LCD on max fat-zoom
0b3a28b [email protected] Update SKP version
Review URL: https://codereview.chromium.org/1289143003
Cr-Commit-Position: refs/heads/master@{#343594}
Roll src/third_party/WebKit 565a79c:be0ec31 (svn 200612:200613)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/565a79c..be0ec31
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1293043003
Cr-Commit-Position: refs/heads/master@{#343593}
Roll src/third_party/WebKit 7f90864:565a79c (svn 200611:200612)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7f90864..565a79c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1290243004
Cr-Commit-Position: refs/heads/master@{#343592}
Roll src/third_party/WebKit d565cd3:7f90864 (svn 200610:200611)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d565cd3..7f90864
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1300523003
Cr-Commit-Position: refs/heads/master@{#343591}
Roll src/third_party/skia a83eead:fb28cd2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a83eead..fb28cd2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
fb28cd2 [email protected] Revert[7] "move some public headers into private"
bb88674 [email protected] increase zoom in fatbits
e027169 [email protected] Revert[6] "move some public headers into private"
Review URL: https://codereview.chromium.org/1291163005
Cr-Commit-Position: refs/heads/master@{#343590}
Roll src/third_party/WebKit 5271cec:d565cd3 (svn 200609:200610)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5271cec..d565cd3
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1295033002
Cr-Commit-Position: refs/heads/master@{#343589}
Roll src/third_party/WebKit fb3ec4e:5271cec (svn 200608:200609)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fb3ec4e..5271cec
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1295023002
Cr-Commit-Position: refs/heads/master@{#343588}
Android Media Notification: start a MediaSession when the notification is visible.
While the Media Notification is visible, Chromium will hold an active
MediaSession. It will intercept play/pause events and put the
title/origin in the MediaSession information.
This CL allows using headset controls and Android Wear devices to
interact with the playing media.
The MediaSession is created using the application icon. This might change
in the future.
BUG=514681
Review URL: https://codereview.chromium.org/1288803002
Cr-Commit-Position: refs/heads/master@{#343587}
Update V8 to version 4.6.77.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f38c251e..73455e0d
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1300503002
Cr-Commit-Position: refs/heads/master@{#343586}
Roll src/third_party/WebKit eecce8b:fb3ec4e (svn 200606:200608)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/eecce8b..fb3ec4e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1296563003
Cr-Commit-Position: refs/heads/master@{#343585}
Roll src/third_party/WebKit 53687f1:eecce8b (svn 200605:200606)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/53687f1..eecce8b
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1293983002
Cr-Commit-Position: refs/heads/master@{#343584}
Roll src/third_party/WebKit e24ce1c:53687f1 (svn 200604:200605)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e24ce1c..53687f1
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1298563002
Cr-Commit-Position: refs/heads/master@{#343583}
Roll src/third_party/WebKit a8d11b2:e24ce1c (svn 200603:200604)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a8d11b2..e24ce1c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/1296063002
Cr-Commit-Position: refs/heads/master@{#343582}
Automated Commit: Committing new LKGM version 7363.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#343581}
Roll src/third_party/WebKit aa45805:a8d11b2 (svn 200602:200603)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aa45805..a8d11b2
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292353008
Cr-Commit-Position: refs/heads/master@{#343580}
Roll src/third_party/WebKit ad3551a3:aa45805 (svn 200601:200602)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ad3551a3..aa45805
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296723003
Cr-Commit-Position: refs/heads/master@{#343579}
Roll src/third_party/WebKit e93911a:ad3551a3 (svn 200600:200601)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e93911a..ad3551a3
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293003003
Cr-Commit-Position: refs/heads/master@{#343578}
Roll src/third_party/WebKit 6c70944:e93911a (svn 200599:200600)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6c70944..e93911a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293003002
Cr-Commit-Position: refs/heads/master@{#343577}
Roll src/third_party/WebKit b5a7b06:6c70944 (svn 200598:200599)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b5a7b06..6c70944
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292993002
Cr-Commit-Position: refs/heads/master@{#343576}
Roll src/third_party/WebKit fce8150:b5a7b06 (svn 200597:200598)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fce8150..b5a7b06
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296053002
Cr-Commit-Position: refs/heads/master@{#343575}
PDF: Use the z-order when there is a link and widget overlaps.
BUG=515837
Review URL: https://codereview.chromium.org/1274413002
Cr-Commit-Position: refs/heads/master@{#343574}
Roll src/third_party/WebKit 66e15eb:fce8150 (svn 200596:200597)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/66e15eb..fce8150
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1296763004
Cr-Commit-Position: refs/heads/master@{#343573}
Roll src/third_party/WebKit 9d06f2c:66e15eb (svn 200595:200596)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9d06f2c..66e15eb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295833005
Cr-Commit-Position: refs/heads/master@{#343572}
Adding myself to the AUTHORS List
Review URL: https://codereview.chromium.org/1292773002
Cr-Commit-Position: refs/heads/master@{#343571}
Update V8 to version 4.6.76.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/14316f3c..f38c251e
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297853003
Cr-Commit-Position: refs/heads/master@{#343570}
Roll src/third_party/WebKit d3adbd3:9d06f2c (svn 200594:200595)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d3adbd3..9d06f2c
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1291723006
Cr-Commit-Position: refs/heads/master@{#343569}
Roll src/third_party/WebKit c795a08:d3adbd3 (svn 200593:200594)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c795a08..d3adbd3
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292693005
Cr-Commit-Position: refs/heads/master@{#343568}
Mac Overlays: Send vsync parameters directly
The previous attempt was to send the display ID, but, there are two
things to contend with.
1. VSync parameters change wildly -- sometimes a half-interval just
disappears ... so you need to update your VSync parameters often, or
they'll be wrong.
2. Computing the VSync parameters is expensive because it creates a
display link thread, and so on.
This idea of creating a display link for the browser and the gpu,
and hoping that they'd stay in sync, wasn't a good idea. Just send the
parameters directly. We'll need to add some smarts to DisplayLinkMac to
ensure that they're updated frequently.
BUG=515696
Review URL: https://codereview.chromium.org/1297473003
Cr-Commit-Position: refs/heads/master@{#343567}
add dependency on skia since we use its headers
BUG=skia:4190
Review URL: https://codereview.chromium.org/1292623002
Cr-Commit-Position: refs/heads/master@{#343566}
Roll PDFium to 24fbf13
24fbf13 Add new public APIs to find the z-order for links and widgets.
cb62e76 Don't bother checking pointers before delete[] and FX_Free().
0f6b51c Use override in more classes in fpdfsdk/
c2c3f7b Use override in more classes in core/
c6540e0 Cleanup: Remove unused CPDF_Metadata::m_pDoc.
f372567 CPDF_ModuleMgr::m_SecurityHandlerMap only used by dead code.
d5d35bc Fix build after commit 22ece1a. Too many if's.
22ece1a Remove last uses of FOXIT_CHROME_BUILD.
45c910f Cleanup: s/Torelance/Tolerance/
dbf5f4c OutputText() is dead code.
b0b1a8b Tidy up JS_Object.h and JS_Object.cpp.
2a0a26c Kill JS_TIMER_MAPARRAY
c9a05f1 Cleanup: Remove unused CPDF_Stream::Clone().
ae35176 Make standalone PDFium DEPS pull clang-format.
388a3b0 Remove if checks after new.
5312f9a Suppress -Wunused-function for pdfium's third-party libraries.
9311163 Allow external font-path configuration from pdfium_test.
98367f3 Revert "Allow external font-path configuration from pdfium_test."
d8b5e73 Allow external font-path configuration from pdfium_test.
e42e23f Fix a small leak in CPDF_DataAvail::CheckTrailer().
b4c2167 Fix some sign comparison warnings.
1e2ece0 Remove dead code from CPDF_Metadata. Add missing nullptr check.
[email protected]
BUG=505316,515837
Review URL: https://codereview.chromium.org/1291193003
Cr-Commit-Position: refs/heads/master@{#343565}
Roll src/third_party/WebKit f3d8d43:c795a08 (svn 200591:200593)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f3d8d43..c795a08
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289373003
Cr-Commit-Position: refs/heads/master@{#343564}
Roll src/third_party/WebKit fbdfe92:f3d8d43 (svn 200577:200591)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fbdfe92..f3d8d43
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292983002
Cr-Commit-Position: refs/heads/master@{#343563}
Add ortuno and me to the Web Bluetooth owners files so we can make progress during scheib vacations.
Review URL: https://codereview.chromium.org/1294543004
Cr-Commit-Position: refs/heads/master@{#343562}
Updating trunk VERSION from 2483.0 to 2484.0
Cr-Commit-Position: refs/heads/master@{#343561}
Add logging for crash_service issues.
BUG=510231
Review URL: https://codereview.chromium.org/1287233003
Cr-Commit-Position: refs/heads/master@{#343560}
Roll src/third_party/WebKit 8858355:fbdfe92 (svn 200574:200577)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8858355..fbdfe92
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290173006
Cr-Commit-Position: refs/heads/master@{#343559}
Change the new-task-manager flag so that the new implementation is enabled by default for all users.
Unless the user explicitly specifies the desire to revert back to the
old implementation using the flag, the new implementation should be
enabled by default.
[email protected]
BUG=520776,471006
Review URL: https://codereview.chromium.org/1293813005
Cr-Commit-Position: refs/heads/master@{#343558}
Fix bounds checks in USB string parsing and add more tests.
This patch fixes a bounds checking error that allowed a string
descriptor with a bLength of 1 to cause -1 to be passed to the
base::string16 constructor. In the process parsing of USB string
descriptors and WebUSB URL descriptors has been moved out of
usb_service_impl.cc so that it can be properly tested.
BUG=521121
Review URL: https://codereview.chromium.org/1292973002
Cr-Commit-Position: refs/heads/master@{#343557}
[Contextual Search] Fix selection-related flaky tests.
Updates instrumentation tests in ContextualSearchManagerTest
that repeatedly establish and dissolve a selection to wait until
the selection is completely clear, by listening to notification
from the renderer.
Also fix a test that was not clearing the previous long-press
selection.
Now there should only be two flaky tests:
testTapSearchBarPromotesToTab,
testDisembodiedBar (which is a true failure?).
Leaving all FLAKY_TEST annotations unchanged for now, so
we can verify that the flakes have truely been fixed on all
platforms.
BUG=487005
Review URL: https://codereview.chromium.org/1290923002
Cr-Commit-Position: refs/heads/master@{#343556}
Compute blend_mode outside CDP
BUG=497817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1296713002
Cr-Commit-Position: refs/heads/master@{#343555}
[Telemetry/perf] Disable smoke coverage for memory benchmarks due to flakiness
BUG=513767
[email protected]
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1296003003
Cr-Commit-Position: refs/heads/master@{#343554}
Call VideoFrameProviderImpl::DidReceiveFrame when background render completes.
VideoFrameCompositor::OnRendererStateUpdate(true) may run and do a background render after BeginFrame but before the compositor frame is actually drawn. It needs to do DidReceiveFrame so that the layer's update_rect contains the entire video, because UpdateCurrentFrame won't be called and won't modify the update rect until the next BeginFrame.
BUG=515887
Review URL: https://codereview.chromium.org/1299523002
Cr-Commit-Position: refs/heads/master@{#343553}
Ensure proper ordering of app window request block/unblock
This fixes a race in app window initialization which could
cause resources to be permanently blocked from loading on
behalf of the renderer.
BUG=520750
[email protected] for tabs
[email protected] for IPC message (symbol rename only)
Review URL: https://codereview.chromium.org/1294923002
Cr-Commit-Position: refs/heads/master@{#343552}
chrome.tabs API: muted+mutedCause --> MutedInfo struct, and launch
This change adds structure to the muted state provided via the
chrome.tabs API. Before this change, there were two fields in the Tab
object, muted and mutedCause, the latter of which was an overloaded
string field. After this change, the two fields are replaced with a
single MutedInfo struct. The struct itself contains three fields:
the "muted" boolean, an enumerated "reason", and an "extensionId" string
that is only set if the muted state change was caused by an extension.
As this is the last functional issue for these new API properties, this
change also makes them on-by-default, for read and update.
BUG=438903
Review URL: https://codereview.chromium.org/1291273002
Cr-Commit-Position: refs/heads/master@{#343551}
Fixing variable name typo ('Parition' -> Partition).
BUG=
Review URL: https://codereview.chromium.org/1284403002
Cr-Commit-Position: refs/heads/master@{#343550}
net: Add a few extra operations to the dump_cache tool.
This adds options to dump all entries on a csv format, follow the
LRU lists, dump the allocation bitmaps and dump any cache block.
Basically it should be possible to fully inspect internal structures.
BUG=none
TEST=none (this is just a tool).
Review URL: https://codereview.chromium.org/1291133002
Cr-Commit-Position: refs/heads/master@{#343549}
Fix flakiness in postMessage-related SitePerProcessBrowserTests.
See https://crbug.com/518729 for the complete description.
This CL fixes two underlying issues for flakiness in
SitePerProcessBrowserTest.PostMessageWithSubframeOnOpenerChain:
1. ExecuteScript* wasn't properly dealing with
domAutomationController messages that might have arrived right after
the expected response to ExecuteScript*, but before its message loop
shut down.
2. DOMMessageQueue was instantiated after the ExecuteScript* in the
test, causing it to never see the message it was waiting for if it
happened to arrive on ExecuteScript's message loop above.
BUG=518729
Review URL: https://codereview.chromium.org/1297713004
Cr-Commit-Position: refs/heads/master@{#343548}
Add dependency_manager initialization to binary_manager
BUG=510231
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Committed: https://crrev.com/f592ba18312f43fe4186cc526db00960a1db0b48
Cr-Commit-Position: refs/heads/master@{#343320}
Review URL: https://codereview.chromium.org/1280903003
Cr-Commit-Position: refs/heads/master@{#343547}
Remove color highlighting from the security summary (in the OIB) on desktop.
BUG=514431
Review URL: https://codereview.chromium.org/1292193003
Cr-Commit-Position: refs/heads/master@{#343546}
[Android] Make enhanced bookmark editing UI more straightforward.
- We didn't save when a dialog is dismissed by tapping outside on
tablet, which can be also confusing as there is no save UI concept.
So save onPause always.
- User should know when we won't save what user typed if it fails
validation. But blocking dialog exit is too invasive, and sometimes
we don't have a control (tapping outside on tablet.) So show warning
as user types.
BUG=510253
Review URL: https://codereview.chromium.org/1295613002
Cr-Commit-Position: refs/heads/master@{#343545}
Record the RTT for empty packets.
BUG=510646
Review URL: https://codereview.chromium.org/1255273003
Cr-Commit-Position: refs/heads/master@{#343544}
Mandoline: Move global Surfaces state to SurfacesState object
This CL makes the following changes:
1. Global Surfaces state has been moved to a SurfacesState object.
2. Surfaces objects have been decoupled from the SurfacesServiceApplication.
3. Cleaned up lifetime management of various Surfaces services to match idioms
used in the View Manager.
BUG=492389
Review URL: https://codereview.chromium.org/1293883003
Cr-Commit-Position: refs/heads/master@{#343543}
Reenable tests which were disabled due to flakiness on Windows trybots.
The cause has been reverted.
BUG=517018
Review URL: https://codereview.chromium.org/1290173005
Cr-Commit-Position: refs/heads/master@{#343542}
Disable flaky PolicyWatcherTest.TestRealChromotingPolicy on ASAN.
BUG=517918
[email protected]
Review URL: https://codereview.chromium.org/1283463002
Cr-Commit-Position: refs/heads/master@{#343541}
Correctly reset theme color on NTP.
Native pages did not receive onThemeColorChange when they get loaded,
therefore ToolbarDataProvider gave incorrect theme information to the
URL bar on the native page after the user navigated away from a themed
page.
Also grammar police was here.
BUG=520488
Review URL: https://codereview.chromium.org/1295653004
Cr-Commit-Position: refs/heads/master@{#343540}
Rewrite SpellCheckWord to take an offset arg and return an enum.
For multilingual spellchecking, SpellCheckWord should return an enum for
correct spelling, misspelling, and skippable words. Also, in an effort
make spellchecking clearly, an offset argument has been added to the
SpellCheckWord functions.
BUG=5102
Review URL: https://codereview.chromium.org/1288143004
Cr-Commit-Position: refs/heads/master@{#343539}
bluetooth: Add histograms for readValue and writeValue outcomes
Histograms added:
- Characteristic.ReadValue.Outcome: Outcome of a call to readValue
- Characteristic.WriteValue.Outcome: Outcome of a call to writeValue
BUG=499636
Review URL: https://codereview.chromium.org/1294473006
Cr-Commit-Position: refs/heads/master@{#343538}
[Proximity Auth] Port the UnlockManager class.
This ports most of the code, with a few TODOs remaining for future CLs.
BUG=501626
[email protected]
Review URL: https://codereview.chromium.org/1239193005
Cr-Commit-Position: refs/heads/master@{#343537}
Revert "SessionManagerClient::RestartJob: Use argv instead of string."
This speculatively reverts commit fb4a4c60596d52a2f3ab26ab94399d3ebd5a64c1.
For details please see crbug.com/520311
NOTRY=true
TBR=mnissler
BUG=chromium:520311, chromium:433172
TEST=compiles
Review URL: https://codereview.chromium.org/1289393002
Cr-Commit-Position: refs/heads/master@{#343536}
Switch the order of IFrame and webview.
showAddUserForTesting is not necessary for webview login.
The plan is to deprecate IFrame altogether in M47.
BUG=500103
Review URL: https://codereview.chromium.org/1294483004
Cr-Commit-Position: refs/heads/master@{#343535}
Update full-form autofill config to always query the field trial state.
This is necessary for correct metrics reporting. Also, add a comment to FindFullName in field_trial.h mentioning its role in metrics reporting.
BUG=504644
Review URL: https://codereview.chromium.org/1291073005
Cr-Commit-Position: refs/heads/master@{#343534}
Roll src/third_party/WebKit 83da2f8:8858355 (svn 200571:200574)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/83da2f8..8858355
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288953005
Cr-Commit-Position: refs/heads/master@{#343533}
Record the XMPP error in remoting.FormatIq.
This CL
1. Records the XMPP error type, jingle_action and error condition
in remoting.FormatIq.
This error is later extracted by the ClientSession to upload along
with session state change events.
We choose to record the error in the webapp instead of the plugin to
avoid adding new contract between the webapp and the plugin just for
the sake of debugging, especially when we are so close to branch point.
2. Removes some legacy fields in the FormatIq to avoid parse errors.
3. Parses the error before the original jingle message. This ensures
addition of unrecognized Jingle fields like QUIC will not break the
error parsing.
BUG=509070
Review URL: https://codereview.chromium.org/1289333004
Cr-Commit-Position: refs/heads/master@{#343532}
[Offline pages] Wiring saving and opening offline page
Changes:
1) Added the logic in EnhancedBookmarksModel to wait for OfflinePagesBridge being loaded if it is enabled
2) Supported adding a new offline page. To do this, a new asynchronous method addBookmarkAsync is added to EnhancedBookmarksModel.
3) Supported launching an offline page. getBookmarkLaunchUrl, that returns the launch url, is added to EnhancedBookmarksModel.
BUG=491352
TEST=tests added and updated
Review URL: https://codereview.chromium.org/1285313003
Cr-Commit-Position: refs/heads/master@{#343531}
Pre-emptive fix for new protobuf version.
Xlib.h #defines "Status", which then breaks .pb.h files.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1294973002
Cr-Commit-Position: refs/heads/master@{#343530}
Roll src/third_party/WebKit 863fdd1:83da2f8 (svn 200569:200571)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/863fdd1..83da2f8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289403002
Cr-Commit-Position: refs/heads/master@{#343529}
Switch DataReductionProxyResourceThrottle::MaybeCreate() from SchemeIsSecure() to SchemeIsCryptographic().
BUG=362214
Review URL: https://codereview.chromium.org/1288733003
Cr-Commit-Position: refs/heads/master@{#343528}
MD downloads: update card design based on bettes@' feedback
[email protected]
BUG=520725
Review URL: https://codereview.chromium.org/1296713004
Cr-Commit-Position: refs/heads/master@{#343527}
Remove the CHECK from the DirectManipulationHelper::Activate function as it is firing in Canary on Windows 10.
Crash dump analysis reveals the error code to be E_UNEXPECTED. Some disassembling into the Direct Manipulation Activate
function did not reveal a code path where the above error is returned. Based on the crash dump analysis it looks like
Activate is called on a window which is visible but has 0 dimensions which could possibly be triggering this.
In any case it is also possible that calling Activate multiple times on a window may be triggering this. I was unable to repro the crash though.
Proposed fixes include :-
1. Remove the CHECK from the DirectManipulationHelper::Activate function.
2. Add a new function DirectManipulationHelper::Deactivate which deactivates Direct manipulation processing on the window.
This is called from views and content when the window is hidden.
BUG=520492
Review URL: https://codereview.chromium.org/1295683003
Cr-Commit-Position: refs/heads/master@{#343526}
Fix broken constructor causing valgrind bot to fail from r343435
BUG=460595
Review URL: https://codereview.chromium.org/1289903003
Cr-Commit-Position: refs/heads/master@{#343525}
Settings: Implement sub-subpages, and clean up some animations.
BUG=425627
Review URL: https://codereview.chromium.org/1290583002
Cr-Commit-Position: refs/heads/master@{#343524}
Revert of Move linux_arm_compile from 100% CQ experiment to full CQ member (patchset #3 id:40001 of https://codereview.chromium.org/1139963003/ )
Reason for revert:
This configuration is very flaky now.
BUG=521162,521165
Original issue's description:
> Move linux_arm_compile from 100% CQ experiment to full CQ member
>
> BUG=384104
>
> Committed: https://crrev.com/a2caf9a3a0cb9d0f79c028af3aa7122e90912a7d
> Cr-Commit-Position: refs/heads/master@{#333738}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=384104
Review URL: https://codereview.chromium.org/1295893004
Cr-Commit-Position: refs/heads/master@{#343523}
Add finch testing configs for CaptivePortalInterstitial.
BUG=335933,b/97629992
Review URL: https://codereview.chromium.org/1281483007
Cr-Commit-Position: refs/heads/master@{#343522}
Roll src/third_party/WebKit 5072f6a:863fdd1 (svn 200568:200569)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5072f6a..863fdd1
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292953002
Cr-Commit-Position: refs/heads/master@{#343521}
Improve docs for received_response_content_length.
Clarify what it returns and when its valid. Remove the comment about
only being valid for certain protocols.
BUG=
Review URL: https://codereview.chromium.org/1292543003
Cr-Commit-Position: refs/heads/master@{#343520}
media: Report low delay mode to UMA and MediaLog.
TEST=Verified in about://histograms and about://media-internals.
Review URL: https://codereview.chromium.org/1296533002
Cr-Commit-Position: refs/heads/master@{#343519}
Don't trigger HW acceleration from Toasts on low-end devices.
BUG=520600
Review URL: https://codereview.chromium.org/1276523003
Cr-Commit-Position: refs/heads/master@{#343518}
Streamline opening of omnibox.
Reuses existing view if one was around.
BUG=none
Review URL: https://codereview.chromium.org/1297733002
Cr-Commit-Position: refs/heads/master@{#343517}
Send connection setup results using XHRs.
This allows them to be sent immediately, rather than only when the session
starts, which will give us insight into cases where both signal strategies
fail. It also simplifies the code a little.
Review URL: https://codereview.chromium.org/1285213006
Cr-Commit-Position: refs/heads/master@{#343516}
Set 'display-mode' media query to 'standalone' for webapps started from the Android launcher
BUG=471703
Review URL: https://codereview.chromium.org/1287293003
Cr-Commit-Position: refs/heads/master@{#343515}
Add owner for components/offline_pages
BUG=none
Review URL: https://codereview.chromium.org/1289723004
Cr-Commit-Position: refs/heads/master@{#343514}
[Telemetry] Remove android_test_runner from telemetry dependencies since its no longer needed
BUG=472672
Review URL: https://codereview.chromium.org/1292713002
Cr-Commit-Position: refs/heads/master@{#343513}
Makes OOPIFs the default
I'll nuke the old code path soonish.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1294473008
Cr-Commit-Position: refs/heads/master@{#343512}
Don't elide what likely is Andriod system stacks.
BUG=517988
Review URL: https://codereview.chromium.org/1292833004
Cr-Commit-Position: refs/heads/master@{#343511}
[Android] Fix compile targets for telemetry_unittests on Android.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/1295893003
Cr-Commit-Position: refs/heads/master@{#343510}
Android: Remove red highlight from the origin info bubble security summary.
This improves consistency between platforms.
BUG=514431
Review URL: https://codereview.chromium.org/1295903002
Cr-Commit-Position: refs/heads/master@{#343509}
Roll src/third_party/WebKit 8e22a4e:5072f6a (svn 200567:200568)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8e22a4e..5072f6a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285413005
Cr-Commit-Position: refs/heads/master@{#343508}
Further cleanup of some assets
These ones got missed in my recent passes
BUG=none
Review URL: https://codereview.chromium.org/1294833005
Cr-Commit-Position: refs/heads/master@{#343507}
cc: Make HiDPI devices use 4 MSAA samples for GPU rasterization by default.
In order to detect the DPI, move the default MSAA samples computation
from CompositorUtil to LayerTreeHostImpl. Use -1 to signify "no
command line flag specified" (= auto-compute MSAA samples from DPI),
so 0 can continue to mean MSAA was explicitly disabled on the command
line, or in about:flags.
BUG=520243
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1284343003
Cr-Commit-Position: refs/heads/master@{#343506}
Typo fix "iceburg" to "iceberg".
BUG=517296
[email protected]
Review URL: https://codereview.chromium.org/1295993002
Cr-Commit-Position: refs/heads/master@{#343505}
Implement common stats-update method for use by multiple video-renderers.
Move driving of uploading UMA stats to ChromotingStats, using callbacks defined in ChromotingInstance.
Also add UMA histograms for latency metrics.
BUG=508602
Committed: https://crrev.com/d4abf8724d7dc81eb816d86c8ae82d799aafabda
Cr-Commit-Position: refs/heads/master@{#343339}
Review URL: https://codereview.chromium.org/1253193003
Cr-Commit-Position: refs/heads/master@{#343504}
Remove #if around PIXEL_FORMAT_NV12
PIXEL_FORMAT_NV12 is only supported on Mac and ChromeOS, but we can still allow
it to be part of the enum.
BUG=510260
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1288003004
Cr-Commit-Position: refs/heads/master@{#343503}
Roll src/third_party/WebKit e4b306e:8e22a4e (svn 200566:200567)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e4b306e..8e22a4e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297483003
Cr-Commit-Position: refs/heads/master@{#343502}
Sandbox: Reenable test that was flaking for being too slow.
The timeouts were increased long time ago so presumably this test should not
fail anymore.
There is no information about why UnloadAviCapDllWithPatching was flaky, but
I'm assuming the same cause of the other two unload tests.
BUG=38404, 137652
Review URL: https://codereview.chromium.org/1299503002
Cr-Commit-Position: refs/heads/master@{#343501}
[Android] Move out LargeIconBridge from EnhancedBookmarkModel.
LargeIconBridge is not tied to EnhancedBookmarkModel logically so
doesn't need to be there.
BUG=None
Review URL: https://codereview.chromium.org/1297483002
Cr-Commit-Position: refs/heads/master@{#343500}
Added two telemetry experiments to measure the latency and data saving when the chrome proxy is bypassed.
BUG=520772
Review URL: https://codereview.chromium.org/1294583005
Cr-Commit-Position: refs/heads/master@{#343499}
Fixed the bug in calculating the request duration in live_tests and integration_tests of Flywheel.
BUG=520675
Review URL: https://codereview.chromium.org/1289083004
Cr-Commit-Position: refs/heads/master@{#343498}
Sandbox: Reenable tests that were flaking for being too slow.
The timeouts were increased long time ago so presumably these tests should not
fail anymore.
BUG=137652
Review URL: https://codereview.chromium.org/1294823003
Cr-Commit-Position: refs/heads/master@{#343497}
Roll src/third_party/WebKit da89974:e4b306e (svn 200565:200566)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/da89974..e4b306e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295983002
Cr-Commit-Position: refs/heads/master@{#343496}
[Eraser strings] Remove unused app launcher strings
BUG=none
TEST=it compiles
Review URL: https://codereview.chromium.org/1292863002
Cr-Commit-Position: refs/heads/master@{#343495}
Render Surface is_clipped from Property Trees
Render Surface is_clipped is computed in CDP. This patch
computes it using property trees and checks that property
tree computation matches CDP computation.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1292473005
Cr-Commit-Position: refs/heads/master@{#343494}
Use warning icon in card unmask prompt.
BUG=505953
[email protected]
Review URL: https://codereview.chromium.org/1288203002
Cr-Commit-Position: refs/heads/master@{#343493}
Remove file contents.
depot_tools/patch.py has a bug that results in changes like this turning into
file deletions on the tryservers. As a workaround to make tryjobs including
this change stop failing, land this first. Since the file is already "empty",
this shouldn't break anything.
BUG=none
TEST=none
TBR=scottmg
Review URL: https://codereview.chromium.org/1298483005 .
Cr-Commit-Position: refs/heads/master@{#343492}
Remove PerformanceMonitor strings
The performance monitor has been dead for awhile, but looks like these weren't
ripped up with the rest. Kill 'em!
Review URL: https://codereview.chromium.org/1293893002
Cr-Commit-Position: refs/heads/master@{#343491}
Roll src/third_party/WebKit 13cc8ed:da89974 (svn 200564:200565)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/13cc8ed..da89974
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285133007
Cr-Commit-Position: refs/heads/master@{#343490}
[Android] Don't save partner bookmark url.
Partner bookmark URL is not editable.
BUG=520726
Review URL: https://codereview.chromium.org/1283293005
Cr-Commit-Position: refs/heads/master@{#343489}
Roll src/third_party/WebKit fce015a:13cc8ed (svn 200562:200564)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fce015a..13cc8ed
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297763003
Cr-Commit-Position: refs/heads/master@{#343488}
QUIC - bug fix for quic_client - start the packet_reader if it is not
started. Fix provided by Dmitry Adamushko <[email protected]>.
[email protected]
Review URL: https://codereview.chromium.org/1295853002
Cr-Commit-Position: refs/heads/master@{#343487}
Add a function for parsing RFC 5280's "Certificate".
BUG=410574
Review URL: https://codereview.chromium.org/1288193003
Cr-Commit-Position: refs/heads/master@{#343486}
Roll src/third_party/WebKit 5e4cba5:fce015a (svn 200561:200562)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5e4cba5..fce015a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290093006
Cr-Commit-Position: refs/heads/master@{#343485}
Implement Precache.Fetch.TimeToComplete.
Reports time, in milliseconds, to complete a prefetch run. Only applies
to non-cancelled runs (those for which PercentCompleted is 100).
BUG=499532
Review URL: https://codereview.chromium.org/1295723002
Cr-Commit-Position: refs/heads/master@{#343484}
Sandbox: Check on NTClose failure.
This also slightly improves error handling and removes duplicated logging from
ResolveSymbolicLink.
BUG=480639
Review URL: https://codereview.chromium.org/1288613003
Cr-Commit-Position: refs/heads/master@{#343483}
Make VS2015 component builds work on swarming.
BUG=440500
Review URL: https://codereview.chromium.org/1252353005
Cr-Commit-Position: refs/heads/master@{#343482}
Roll src/third_party/WebKit 0c3c8f8:5e4cba5 (svn 200560:200561)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c3c8f8..5e4cba5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289363004
Cr-Commit-Position: refs/heads/master@{#343481}
Roll src/third_party/skia 6fbdeef:a83eead
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6fbdeef..a83eead
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
a83eead [email protected] Revert of stop dropping AA when rect stays rect (patchset #8 id:140001 of https://codereview.chromium.org/1295523002/ )
f5fb939 [email protected] SkPDF: Move SkFlate into src/pdf (part 3/3)
9a106ba [email protected] A bit of misc cleanup.
090ae8e [email protected] fix valgrind issue
40ac15a [email protected] fix viewmatrix mapping in AAFillRect
540e488 [email protected] Add include paths in gputest.gyp for use by additional gpu tests.
820bffb [email protected] Build all GMs on Android.
cc2feb1 [email protected] Support more swizzles to 565 in SkCodec
8f4ba76 [email protected] SkScaledCodec class
1bef9f5 [email protected] stop dropping AA when rect stays rect
b0a32cc [email protected] Revert of SkScaledCodec class (patchset #35 id:680001 of https://codereview.chromium.org/1260673002/ )
2ba7099 [email protected] Add GM to test drawing atlas case
Review URL: https://codereview.chromium.org/1288003005
Cr-Commit-Position: refs/heads/master@{#343480}
Add fieldtrial config entry for QUIC for chromeos, ios and android.
[email protected]
Review URL: https://codereview.chromium.org/1298493002
Cr-Commit-Position: refs/heads/master@{#343479}
Adding cope to address a race condition
In about 5% of runs the client fails to connect to the
server because the server hasn't fully started yet.
BUG=
Review URL: https://codereview.chromium.org/1292803002
Cr-Commit-Position: refs/heads/master@{#343478}
Remove the old WebMediaSourceImpl::addSourceBuffer overload
Complete the transition to using the new addSourceBuffer overload
that takes codecs as an unparsed string.
BUG=none
Review URL: https://codereview.chromium.org/1282883004
Cr-Commit-Position: refs/heads/master@{#343477}
Remove menu from ash / Windows shelf / taskbar to install ephemeral app.
BUG=517735
Review URL: https://codereview.chromium.org/1290303002
Cr-Commit-Position: refs/heads/master@{#343476}
Roll src/third_party/WebKit 25c8210:0c3c8f8 (svn 200559:200560)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/25c8210..0c3c8f8
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295833004
Cr-Commit-Position: refs/heads/master@{#343475}
Modify languageSettingsPrivate IDL and flesh out stub implementation
While implementing this API, I've come across some API changes I'd like to
make before submitting the actual implementation.
This also introduces the stub event router delegate and brings the stubs
closer to what the implementation looks like.
The implementation CL will be posted after this one:
https://codereview.chromium.org/1283603002/
BUG=479043
Review URL: https://codereview.chromium.org/1274753006
Cr-Commit-Position: refs/heads/master@{#343474}
Proof-read comments in src/url/.
Review URL: https://codereview.chromium.org/1270443006
Cr-Commit-Position: refs/heads/master@{#343473}
Implement base class of NetworkQualityProvider
-- Added base class of NetworkQualityProvider:
net/base/network_quality_provider.{h, cc}.
This will be
used by net stack to interact with NQP.
-- NetworkQualityEstimator is notified by NQP when
an updated value is available.
BUG=472685
Review URL: https://codereview.chromium.org/1285693002
Cr-Commit-Position: refs/heads/master@{#343472}
Roll src/third_party/WebKit 8d3e1cb:25c8210 (svn 200558:200559)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8d3e1cb..25c8210
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292403005
Cr-Commit-Position: refs/heads/master@{#343471}
Explicitly include SkDrawLooper.h.
This was being transitively included through a file from which I'd like
to remove it in Skia.
BUG=
Review URL: https://codereview.chromium.org/1289623011
Cr-Commit-Position: refs/heads/master@{#343470}
Avoid mixed-content errors in Cronet javadocs
Review URL: https://codereview.chromium.org/1292833003
Cr-Commit-Position: refs/heads/master@{#343469}
Allow script to request durable storage permission (chrome side)
- Entry point from blink is PermissionDispatcher::requestPermission
- IPC is handled internally by the permission service
- Permission service stores user's choice in content settings
Corresponding Blink change, which must land first, is
https://codereview.chromium.org/1154573005/
BUG=482814
Review URL: https://codereview.chromium.org/1164073005
Cr-Commit-Position: refs/heads/master@{#343468}
Add variation parameter for config URL.
This allows us to vary top_sites_count and forced_site per experiment.
BUG=309216
Review URL: https://codereview.chromium.org/1296503002
Cr-Commit-Position: refs/heads/master@{#343467}
Add rappor metrics for navigations to data: URLs.
BUG=492773
Review URL: https://codereview.chromium.org/1294703002
Cr-Commit-Position: refs/heads/master@{#343466}
Update V8 to version 4.6.75.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c9c63eaa..14316f3c
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285213003
Cr-Commit-Position: refs/heads/master@{#343465}
Add GN targets for "setup" and "mini_installer".
These compile but need more verification before we can call them 100% complete (this is bug 520289).
This fixes the size_t conversion warnings in these targets and removes the warning suppression from the GYP build.
Review URL: https://codereview.chromium.org/1288223002
Cr-Commit-Position: refs/heads/master@{#343464}
Enable QUIC support in chromoting
- Added GetQuicChannelFactory() in JingleSession, so now it's possible
to create channels over QUIC.
- SessionConfig was updated to support QUIC-based transport. PseudoTCP
is still used by default.
- ContentDescription class is updated to exchange QuicConfig blobs
generated by QuicChannelFactory.
- ChromotingInstance allows to enable QUIC by enabling "quic"
experiment in the webapp.
BUG=448838
Review URL: https://codereview.chromium.org/1277093006
Cr-Commit-Position: refs/heads/master@{#343463}
[Download Notification] Match status strings in DownloadGroupNotification with the UX mock
This patch changes the strings in download notification, to match them with the spec. This patch introduces the methods for the status text in download notification, instead of using the common method with the download tray, to show the dedicated strings to download notification.
BUG=519018
TEST=manually tested
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1276903005
Cr-Commit-Position: refs/heads/master@{#343462}
[Telemetry] Remove the cache decorator in support_binaries
BUG=510231
Review URL: https://codereview.chromium.org/1292403002
Cr-Commit-Position: refs/heads/master@{#343461}
Converts layout test harness to OOPIFs
I'm going to make OOPIF the default soon. This makes the layout test
running code work with OOPIFs (only).
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1292183003
Cr-Commit-Position: refs/heads/master@{#343460}
Mac Overlays: Make ImageTransportSurfaceOverlayMac observe GPU switches
When the GPU switches, create a new OpenGL context, to see which GL
renderer it uses. Whenever a context is made current to the surface,
ensure that the context is using the appropriate renderer.
Ideally, the GpuSwitchingManager should be able to tell the observers
which GL renderer to use, but that is not currently wired up.
BUG=519097
Committed: https://crrev.com/0009e1ea4154c5a20fffa3cf47b0b29c23a6f7e2
Cr-Commit-Position: refs/heads/master@{#343277}
Review URL: https://codereview.chromium.org/1291703002
Cr-Commit-Position: refs/heads/master@{#343459}
Refactor parent and anchor logic into the bubble controller.
This refactoring will make it easier to make changes for the bubble API
by consolidating this logic.
[email protected]
BUG=496955
Review URL: https://codereview.chromium.org/1291653002
Cr-Commit-Position: refs/heads/master@{#343458}
Roll src/third_party/WebKit 14329df:8d3e1cb (svn 200557:200558)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/14329df..8d3e1cb
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1299473002
Cr-Commit-Position: refs/heads/master@{#343457}
Revert of [tracing] Add browser-side tests for memory dumps. (patchset #2 id:20001 of https://codereview.chromium.org/1295753002/ )
Reason for revert:
This CL flakily causes failures on try bots, specifically in SingleProcessMemoryTracingTest.BrowserInitiatedSingleDump:
c:\b\build\slave\win_builder__dbg_\build\src\content\browser\tracing\memory_tracing_browsertest.cc(142): error: Mock function called more times than expected - returning default value.
Function call: OnMemoryDump(@3286BA0C 4-byte object \u003C01-00 00-00>, 3286B920)
Returns: false
Expected: to be called once
Actual: called twice - over-saturated and active
On Win7 - https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40855
and ../../content/browser/tracing/memory_tracing_browsertest.cc:148: Failure
Value of: last_callback_success_
Actual: false
Expected: true
on Mac 10.8: https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/6628
Original issue's description:
> [tracing] Add browser-side tests for memory dumps.
>
> This is a rebase of https://codereview.chromium.org/1064413002. The
> `OverlappingRequests` test has been removed.
>
> Committed: https://crrev.com/a4c2539f13510a650d51e65204ea52426979659c
> Cr-Commit-Position: refs/heads/master@{#343408}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1294833004
Cr-Commit-Position: refs/heads/master@{#343456}
[Android] Mark a CustomTabExternalNavigationTest as flaky.
BUG=519613
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293883004
Cr-Commit-Position: refs/heads/master@{#343455}
Roll src/third_party/WebKit 70f7cd0:14329df (svn 200556:200557)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/70f7cd0..14329df
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292853002
Cr-Commit-Position: refs/heads/master@{#343454}
Specify material design constants for omnibox dropdown in ThemeProvider
Move the layout constants for the material design
omnibox dropdown into ThemeProvider, and specify
the values for the material and material hybrid
variants.
BUG=519507
TEST=none
R=pkasting
TBR=pkotwicz
Review URL: https://codereview.chromium.org/1289823004
Cr-Commit-Position: refs/heads/master@{#343453}
move V2 classes in chrome/engine to syncer_v2 namespace
BUG=516512
Review URL: https://codereview.chromium.org/1285443002
Cr-Commit-Position: refs/heads/master@{#343452}
bluetooth: Add histograms and logging for getCharacteristic
Histograms:
- GetCharacteristic.Characteristic: UUID of Characteristic
- GetCharacteristic.Outcome: Outcome of the call to GetCharacteristic.
BUG=499636
Review URL: https://codereview.chromium.org/1286883002
Cr-Commit-Position: refs/heads/master@{#343451}
Roll src/third_party/WebKit e027991:70f7cd0 (svn 200554:200556)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e027991..70f7cd0
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295753005
Cr-Commit-Position: refs/heads/master@{#343450}
aw: Minor trace event name fix
Old event name is obviously copied without being changed.
BUG=
Review URL: https://codereview.chromium.org/1294843002
Cr-Commit-Position: refs/heads/master@{#343449}
[Telemetry] [Android] Improve local selection of port for forwarder.
Same as https://codereview.chromium.org/1292643002/ but only for android.
BUG=
Review URL: https://codereview.chromium.org/1291413002
Cr-Commit-Position: refs/heads/master@{#343448}
Implement QuicChannel and QuicChannelFactory
QuicChannelFactory implements StreamChannelFactory to create channels
over a QUIC connection.
The new code will be hooked up in a separate CL.
BUG=448838
Review URL: https://codereview.chromium.org/1273233002
Cr-Commit-Position: refs/heads/master@{#343447}
Roll src/third_party/WebKit 0005c6e:e027991 (svn 200553:200554)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0005c6e..e027991
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292403003
Cr-Commit-Position: refs/heads/master@{#343446}
Renames FrameTreeClient::PostMessage to OnPostMessageEvent
To name something PostMessage on windows requires lots of undefs that
are tricky to get right with generated code. I'm changing the name so
that it doesn't conflict.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1283403003
Cr-Commit-Position: refs/heads/master@{#343445}
Rename password_manager::StoreResultFilter to CredentialsFilter
The API will soon have more methods than just filtering store results.
This is part of making the sync implementation of this API a BrowserContextKeyedService, which has been split into multiple CLs to make reviewing easier:
1. Rename the API. [this CL]
2. Introduce the service. [WIP, https://codereview.chromium.org/1282023002/]
BUG=515108,474577,514230
Review URL: https://codereview.chromium.org/1293763002
Cr-Commit-Position: refs/heads/master@{#343444}
Rewrite HpackRoundTripTest::RandomizedExamples.
Rewrite HpackRoundTripTest::RandomizedExamples in preparation for replacing
SpdyHeaderBlock with an ordered data structure.
This CL lands server change 100597159 by rjshade.
BUG=443287
Review URL: https://codereview.chromium.org/1291423002
Cr-Commit-Position: refs/heads/master@{#343443}
ResourceScheduler: remove dependency on ResourceRequestInfo and request_id
For async revalidations to work independently of
ResourceDispatcherHostImpl after creation, it is necessary that they
have no ResourceRequestInfoImpl objects attached to them.
However, we still need ResourceScheduler to be able to schedule these
requests.
This CL makes ScheduledResourceRequest a public interface which is
returned by ResourceScheduler::ScheduleResource(). The code to handle
ResourceHostMsg_DidChangePriority is now inside
ResourceDispatcherHostImpl instead of being delegated to
ResourceMessageDelegates.
A pointer to the ScheduledResourceRequest is attached to the URLRequest
so that ResourceDispatcherHostImpl can retrieve it when a
DidChangePriority message is received.
BUG=348877
TEST=content_unittests
Review URL: https://codereview.chromium.org/1285863003
Cr-Commit-Position: refs/heads/master@{#343442}
Change HPACK decoder to directly update cookie value.
Change HPACK decoder to directly update cookie value in internal map, rather
than storing incremental changes and updating map at end. This is in
preparation for switching SpdyHeaderBlock to be an ordered data structure. The
decoder must insert the "cookie" header at the right point, rather than waiting
until all other headers have been processed.
This CL lands server change 100610321 by rjshade.
BUG=443287
Review URL: https://codereview.chromium.org/1290913005
Cr-Commit-Position: refs/heads/master@{#343441}
Stop using typedef in hpack decoder. No behavior change.
This CL lands server change 100606715 by rjshade.
BUG=488484
Review URL: https://codereview.chromium.org/1284143005
Cr-Commit-Position: refs/heads/master@{#343440}
Add enum SpdyHeaderValidatorType::RESPONSE_TRAILER.
In enum SpdyHeaderValidatorType, rename RESPONSE to RESPONSE_HEADER, and add
RESPONSE_TRAILER.
This CL lands server change 100141054 by mpw.
BUG=422958
Review URL: https://codereview.chromium.org/1294813002
Cr-Commit-Position: refs/heads/master@{#343439}
Implement handler method for DevTools getCertificateDetails.
BUG=502118
Review URL: https://codereview.chromium.org/1258523002
Cr-Commit-Position: refs/heads/master@{#343438}
Fix Custom Action Bar for custom tabs on tablet
Custom tabs on tablet is special in that it does not have a tab strip.
Therefore ContextualMenuBar will calculate the wrong offset when
animating the bar.
BUG=510284
Review URL: https://codereview.chromium.org/1292693002
Cr-Commit-Position: refs/heads/master@{#343437}
Roll src/third_party/WebKit 64a239a:0005c6e (svn 200551:200553)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/64a239a..0005c6e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295833003
Cr-Commit-Position: refs/heads/master@{#343436}
Add support for Flash Player Component updates on Linux
This change adds support for Flash Player Component updates on Linux.
It enables the component updater on Linux, and creates a hints file that
the zygote will use to locate and preload the latest component updated flash.
This should not affect component update OS X and Windows, however, because
it forks the update path on Linux from those platforms, there is a risk of a bug
that could affect component update on OS X and Windows.
BUG=460595
Review URL: https://codereview.chromium.org/1261333004
Cr-Commit-Position: refs/heads/master@{#343435}
Roll src/third_party/WebKit 431bd36:64a239a (svn 200550:200551)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/431bd36..64a239a
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295753004
Cr-Commit-Position: refs/heads/master@{#343434}
net: Remove dump-to-files from dump_cache.
There's no need for this code. See the bug for more details.
BUG=520712
Review URL: https://codereview.chromium.org/1292443003
Cr-Commit-Position: refs/heads/master@{#343433}
Revert of Rebase layout tests after changes to AARect (patchset #1 id:1 of https://codereview.chromium.org/1289333002/ )
Reason for revert:
Caused lint errors on WebKit Mac
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/40027/steps/webkit_lint/logs/stdio
Original issue's description:
> Rebase layout tests after changes to AARect
>
> BUG=521012
>
> Committed: https://crrev.com/fde02559a6b514c66cc7a56b2b7b94a81ea3d07f
> Cr-Commit-Position: refs/heads/master@{#343427}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521012
Review URL: https://codereview.chromium.org/1295833002
Cr-Commit-Position: refs/heads/master@{#343432}
Move DiscardNonCommittedItems to NavigationManager's public interface.
This CL also renames DiscardNonCommittedEntries to
DiscardNonCommittedItems.
BUG=516982
Review URL: https://codereview.chromium.org/1287793002
Cr-Commit-Position: refs/heads/master@{#343431}
Revert of [Android] Add a java.lang.System wrapper. (patchset #2 id:20001 of https://codereview.chromium.org/1283543003/ )
Reason for revert:
This doesn't actually work.
Original issue's description:
> [Android] Add a java.lang.System wrapper.
>
> Add a basic JNI wrapper for java.lang.System. Expose just the
> getProperty() method, eliminating a deprecated __system_property_get
> usage as well as a seperate System.getProperty wrapper.
>
> The remaining uses of __system_property_get will be removed in
> https://codereview.chromium.org/1236283002/.
>
> BUG=392196, 392191
>
> Committed: https://crrev.com/130c6bf9db16a69fca8488da8e15e978470e7e8b
> Cr-Commit-Position: refs/heads/master@{#343245}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=392196, 392191
Review URL: https://codereview.chromium.org/1294883002
Cr-Commit-Position: refs/heads/master@{#343430}
Move MIDI permission status checking out of Blink
* Previously, Blink used to handle MIDI and other theoretical "Constant Permissions"
(i.e. permissions which are always approved or denied)
* With the arrival of request multiple, coordination of permission responses needs
to happen entirely in Chrome so movement of the code to here makes a lot more
sense.
* Therefore, from now on, all "Constant Permissions" are handled by
permission_manager and nowhere else.
BUG=516626
Review URL: https://codereview.chromium.org/1280483004
Cr-Commit-Position: refs/heads/master@{#343429}
[Android] Add telemetry_unittests to the trial bot.
BUG=
Review URL: https://codereview.chromium.org/1294623002
Cr-Commit-Position: refs/heads/master@{#343428}
Rebase layout tests after changes to AARect
BUG=521012
Review URL: https://codereview.chromium.org/1289333002
Cr-Commit-Position: refs/heads/master@{#343427}
Implement a smoother animation for exiting full screen on OSX 10.10 with AppKit.
Modified BrowserWindowEnterFullscreenTransition class so that it contains the
animations for entering and exiting fullscreen.
Added a lock and overrode some methods in FramedBrowserWindow to prevent AppKit
from changing the style mask and the size of the window before the end of the
exit animation
A method is added to FullSizeWindow to allow us to force the
contentView to resize
BUG= 519735
Review URL: https://codereview.chromium.org/1276383004
Cr-Commit-Position: refs/heads/master@{#343426}
Adds components/history tests to BUILD.gn
Not sure why they weren't added previously.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1296623003
Cr-Commit-Position: refs/heads/master@{#343425}
Roll src/third_party/WebKit 86dc467:431bd36 (svn 200548:200550)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/86dc467..431bd36
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292383003
Cr-Commit-Position: refs/heads/master@{#343424}
bluetooth: Move histogram related code to its own file
Histograms' code was starting to become a significant portion of
bluetooth_dispatcher_host. This change moves it to its own class.
BUG=499636
Review URL: https://codereview.chromium.org/1265323004
Cr-Commit-Position: refs/heads/master@{#343423}
Roll ANGLE b4b0b48..6d51c70
https://chromium.googlesource.com/angle/angle.git/+log/b4b0b48..6d51c70
BUG=487341
[email protected],[email protected]
TEST=bots
Review URL: https://codereview.chromium.org/1294733003
Cr-Commit-Position: refs/heads/master@{#343422}
Small language fix as indicated by the interpreters.
BUG=
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1294833002
Cr-Commit-Position: refs/heads/master@{#343421}
Add assets for material design omnibox dropdown shadows
Specify new asset IDs and add asset files
for the shadows along the top and bottom edges
of the material design omnibox dropdown.
BUG=520994
TEST=none
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1292623003
Cr-Commit-Position: refs/heads/master@{#343420}
Fix setting list prefs in settingsPrivate.setPref.
Also simplifies the code a bit.
BUG=388460
[email protected]
Review URL: https://codereview.chromium.org/1291233002
Cr-Commit-Position: refs/heads/master@{#343419}
[MD settings] fix for missing certificate manager string
BUG=425627
Review URL: https://codereview.chromium.org/1290093003
Cr-Commit-Position: refs/heads/master@{#343418}
Cronet API and Javadoc clean up
All changes should be non-functional, though some APIs have
been renamed so embedders will need to be updated.
1) Link up basic Java types
2) Hide a slew of Cronet Java classes that are simply
implementations of other public APIs
3) Add {@code } in lots of places
4) Lots and lots of little corrections
5) Make javadocs better conform to Android's style rules
6) Add javadocs in places where they should be
7) Rework lots of things
8) Hide internal-only methods
9) Rename SPDY->HTTP2
10) Remove enums (I'll try adding IntDef later)
11) Add a PRESUBMIT.py so formatting is consistent
Review URL: https://codereview.chromium.org/1277553002
Cr-Commit-Position: refs/heads/master@{#343417}
Roll src/third_party/WebKit d3c1442:86dc467 (svn 200547:200548)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d3c1442..86dc467
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287003008
Cr-Commit-Position: refs/heads/master@{#343416}
Pass enable_topchrome_md as a grit define
Specify enable_topchrome_md as a grit define, which
will be used to specify new asset IDs which
are only applicable to platforms affected by
the material design refresh in browser top chrome.
BUG=520992
TEST=none
Review URL: https://codereview.chromium.org/1299433002
Cr-Commit-Position: refs/heads/master@{#343415}
scheduler: Remove the null scheduler
Remove the null scheduler and the ability to turn the Blink scheduler
off. Since many subsystems such as input handling and v8 garbage
collection have been integrated to the scheduler, it no longer makes
much sense to try and run Chrome with the scheduler disabled.
[email protected]
Review URL: https://codereview.chromium.org/1287393002
Cr-Commit-Position: refs/heads/master@{#343414}
OWNERs file for external estimates provider
Adding OWNERs file for the upstream code for external
estimates provider in chrome/browser/android/net/ and
chrome/android/java/src/org/chromium/chrome/browser/net/qualityprovider/.
Both the OWNERs files are similar to
chrome/browser/net/OWNERS except for minor changes.
BUG=472685
Review URL: https://codereview.chromium.org/1291153002
Cr-Commit-Position: refs/heads/master@{#343413}
Reducing the verbosity of some process methods.
BUG=
Review URL: https://codereview.chromium.org/1285313002
Cr-Commit-Position: refs/heads/master@{#343412}
Add mixed content and secure URL info to SecurityStyleExplanations
content::SecurityStyleExplanations is used to convey an explanation for
the lock icon (calculated by //chrome) to the DevTools security panel
(whose protocol handler is in //content).
To be able to more flexibly explain mixed content in the security panel,
this CL gives the security panel more structured information than the
opaque human-readable mixed content string that it was previously
getting. Namely, this CL gives devtools information about whether mixed
content was displayed/run on the page (so that the security panel can
display a link to the Network panel to show mixed resources), and what
security style //chrome uses to represent displaying/running insecure
content (so that the security panel can display the appropriate icon
next to a list of mixed resources).
This CL also adds a |scheme_is_cryptographic| boolean field to the information
that the security panel gets. This is to allow devtools to unambiguously
distinguish HTTP page loads from HTTPS, now that
SECURITY_STYLE_UNAUTHENTICATED is no longer reserved for HTTP only (see
https://crbug.com/513863).
The corresponding Blink changes (must land first) are in crrev.com/1275723005
BUG=518065,517186
Review URL: https://codereview.chromium.org/1275793004
Cr-Commit-Position: refs/heads/master@{#343411}
Allow access to /System/Library/Exensions on El Capitan+ to solve GPU crashes.
While in the sandbox profiles, I also cleaned up some comments and formatting
problems.
BUG=515280
Review URL: https://codereview.chromium.org/1285423003
Cr-Commit-Position: refs/heads/master@{#343410}
Roll src/third_party/WebKit 87c47e6:d3c1442 (svn 200546:200547)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/87c47e6..d3c1442
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1298463002
Cr-Commit-Position: refs/heads/master@{#343409}
[tracing] Add browser-side tests for memory dumps.
This is a rebase of https://codereview.chromium.org/1064413002. The
`OverlappingRequests` test has been removed.
Review URL: https://codereview.chromium.org/1295753002
Cr-Commit-Position: refs/heads/master@{#343408}
Cronet perf test: inform pylib of build type.
This fixes a recent breakage in the Cronet perf test occuring
because pylib.device.device_utils now requires build type to be set.
Review URL: https://codereview.chromium.org/1289623012
Cr-Commit-Position: refs/heads/master@{#343407}
content: common: fix missing mojo dependency in GN build
content/common/mojo/service_registry_impl.cc requires the mojo type
converters from mojo/common:common_base.
../../third_party/mojo/src/mojo/public/cpp/bindings/string.h:40: error: undefined reference to 'mojo::TypeConverter<mojo::String, base::BasicStringPiece<std::string> >::Convert(base::BasicStringPiece<std::string> const&)'
BUG=none
Review URL: https://codereview.chromium.org/1298443003
Cr-Commit-Position: refs/heads/master@{#343406}
Roll src/third_party/WebKit ed7f598:87c47e6 (svn 200544:200546)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed7f598..87c47e6
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1298453002
Cr-Commit-Position: refs/heads/master@{#343405}
Roll src/third_party/WebKit 74fa823:ed7f598 (svn 200543:200544)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/74fa823..ed7f598
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289693009
Cr-Commit-Position: refs/heads/master@{#343404}
Update preloaded Dropbox pins
* Add additional dropbox domains
* Set includeSubdomains for dropbox pins
* Add a preloaded report-uri for dropbox pins
BUG=
Review URL: https://codereview.chromium.org/1291183002
Cr-Commit-Position: refs/heads/master@{#343403}
Disable ChromeSigninUtilsTest.
BUG=520847
Review URL: https://codereview.chromium.org/1286013003
Cr-Commit-Position: refs/heads/master@{#343402}
Add httplib2 (in catapult) to list of exceptions in checklicenses.py.
Review URL: https://codereview.chromium.org/1288153002
Cr-Commit-Position: refs/heads/master@{#343401}
Roll src/third_party/WebKit 45c9944:74fa823 (svn 200542:200543)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/45c9944..74fa823
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297693002
Cr-Commit-Position: refs/heads/master@{#343400}
Do not call FaviconHandler::OnUpdateFaviconURL() if there is no last committed navigation entry
This CL is preparation for https://codereview.chromium.org/1272413002/
BUG=517089, 520759
TEST=None
Review URL: https://codereview.chromium.org/1287853002
Cr-Commit-Position: refs/heads/master@{#343399}
Plugin Placeholders: Restore to default disallow loading, explicit allow.
In https://codereview.chromium.org/1126073003, I switched plugin placeholders to be default allow loading, with explicit disallows.
This was a mistake, as I missed some cases with default disallow, and caused (securityish) bug below.
This CL reverts it to default-disallow, and adds explicit allow calls where they existed previously.
BUG=518798
Review URL: https://codereview.chromium.org/1290233002
Cr-Commit-Position: refs/heads/master@{#343398}
Plugin Power Saver: Fix Mac crash caused by WebViewPlugin double destruction.
There's Mac crashes on WebViewPlugin. I believe this is because WebViewPlugin
was made (by me) into a RenderViewObserver. RenderViewObserver destroys itself
along with the parent RenderView. However, WebViewPlugin has its own destruction
mechanism and does not need this automatic destruction.
In fact, I believe the crash is caused by WebViewPlugin being destroyed twice.
This patch fixes this by opting WebViewPlugin out of the normal automatic
RenderViewObserver destruction mechanism.
BUG=520433
Review URL: https://codereview.chromium.org/1294643002
Cr-Commit-Position: refs/heads/master@{#343397}
aw: Page visiblity behind switch
Enable page visibility behind a command line switch. There should be
no change in behavior if enable-page-visibility switch is missing.
When it's added:
* Visibility is changed to
(view visible) && (!attached or window visible) && (!onPause-ed)
The existing implementation is simply !onPaused.
* Pass page visibility signal into blink, and in turn, the compositor.
BUG=520089
Review URL: https://codereview.chromium.org/1291653004
Cr-Commit-Position: refs/heads/master@{#343396}
Add top level touch handlers to scrolling tough ad cases
Most ads have touch event handlers, which can cause jank when you scroll
a page by grabbing one of the ads on it. We want to minimize the amount
of jank caused by this, and the first step is to get better metrics
about it.
The scrolling tough ad cases already occasionally trigger this type of
jank by scrolling over an ad. However that happens randomly depending on
where the scroll gestures happen to be initiated. This patch makes the
worst case deterministic by adding a top level touch handler on the
document, causing all scrolls to initially go via the main thread.
BUG=510398
Review URL: https://codereview.chromium.org/1293573002
Cr-Commit-Position: refs/heads/master@{#343395}
Remove unused #include in chrome/common/variations/variations_util.cc.
Nothing from chrome/common/child_process_logging.h is used and thus
the #include is obsolete and can be removed.
BUG=None
Review URL: https://codereview.chromium.org/1294803002
Cr-Commit-Position: refs/heads/master@{#343394}
[ETW Export] Add polling for ETW keyword.
This adds a background low-priority thread for each process that monitors the keyword and adjusts the categories accordingly. This allows users to start profiling (using UIForETW or Xpef directly) and specify which categories to enable, without having to restart Chrome.
Notes:
- TraceEventETWExport is a friend of TraceLog (see comment in code).
- ETW exporting still needs to be enabled using the command line or in about:flags.
BUG=491909
Review URL: https://codereview.chromium.org/1279353002
Cr-Commit-Position: refs/heads/master@{#343393}
Roll src/third_party/WebKit dd9628e:45c9944 (svn 200541:200542)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd9628e..45c9944
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288033007
Cr-Commit-Position: refs/heads/master@{#343392}
Componentize chrome/common/experiment_labels.{cc,h} and tests.
Move both chrome/common/experiment_labels.{cc,h} and the corresponding
unit tests into components/variations as they only depends on //base
and the component.
BUG=520070
Review URL: https://codereview.chromium.org/1290173004
Cr-Commit-Position: refs/heads/master@{#343391}
chrome/installer: Remove unused GetNetworkStatsServer() method.
Nobody seems to be calling it, so lets remove it.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1290283002
Cr-Commit-Position: refs/heads/master@{#343390}
Mandoline: Factor Out MemoryTrackerStub to GpuMemoryTracker
This CL makes no change in functionality but we eventually need to implement
a proper memory tracker, and cc::Display will need this once the patch to merge
surfaces with views lands.
BUG=492389
Review URL: https://codereview.chromium.org/1293833002
Cr-Commit-Position: refs/heads/master@{#343389}
[Cronet] Set QUIC hints expiration date to Time::Max.
QUIC hints expiration date should be base::Time::Max(), but a bug prevented
HttpServerPropertiesManager to serialize this value without crashing. This bug
was fixed by https://crrev.com/1275663002, so now QUIC hints expiration can be
changed back to base::Time::Max().
This CL essentially reverts https://crrev.com/1266263002.
BUG=516034
Review URL: https://codereview.chromium.org/1290373002
Cr-Commit-Position: refs/heads/master@{#343388}
Update use counters
Ran update_use_counter_feature_enum.py to sync histograms.xml with
UseCounter.h
[email protected]
Review URL: https://codereview.chromium.org/1291203002 .
Cr-Commit-Position: refs/heads/master@{#343387}
Fix a crash in TrayRotationLock::OnRotationLockChanged
When the StatusAreaWidget is being shutdown, tray views are deleted before their
owning TrayImageItems.
During this process updates to the rotation lock can cause TrayRotationLock to
attempt to access the now destroyed tray view.
Updated TrayRotationLock to exit OnRotationLockChanged early if there is no tray
view.
TEST=TrayRotationLockTest.LockUpdatedDuringDesctruction
BUG=516498
Review URL: https://codereview.chromium.org/1281903004
Cr-Commit-Position: refs/heads/master@{#343386}
[telemetry] Re-enable TracingBackendMemoryTest.testDumpMemorySuccess
The test was recently disabled due to flakiness
(https://codereview.chromium.org/1291533003/). The issue
(crbug.com/520663) that was most likely causing it to be flaky has now
been fixed (https://codereview.chromium.org/1290333003).
BUG=520544,499731
Review URL: https://codereview.chromium.org/1287763003
Cr-Commit-Position: refs/heads/master@{#343385}
Disable flaky ErrorConsoleBrowserTest.
This test had been renabled by crrev.com/1284743004; the other tests
re-enabled there are fine, but
ErrorConsoleBrowserTest.BrowserActionRuntimeError still fails flaky XP.
BUG=517029
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1296613002
Cr-Commit-Position: refs/heads/master@{#343384}
Roll src/third_party/WebKit 1f46267:dd9628e (svn 200540:200541)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1f46267..dd9628e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290423004
Cr-Commit-Position: refs/heads/master@{#343383}
Remove DCHECK in PasswordManager::OnPasswordFormsRendered
This DCHECK seems not to be correct, more info on the bug.
[email protected]
BUG=520953
Review URL: https://codereview.chromium.org/1291363002
Cr-Commit-Position: refs/heads/master@{#343382}
Allow Constrained Window to specify a styleMask at initialization.
Mac OS Yosemite doesn't honor styleMask if set after window creation.
This CL adds a way to specify the masks when creating a
ConstrainedWindowCustomWindow.
BUG=520637
Review URL: https://codereview.chromium.org/1284103005
Cr-Commit-Position: refs/heads/master@{#343381}
Clip Rect From Property Trees
Clip Rect is computed in CDP. This patch
computes it using property trees and checks that property
tree computation matches CDP computation.
BUG=497817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1291653003
Cr-Commit-Position: refs/heads/master@{#343380}
Roll src/third_party/WebKit 452664e:1f46267 (svn 200539:200540)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/452664e..1f46267
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290943003
Cr-Commit-Position: refs/heads/master@{#343379}
Roll src/third_party/WebKit c936ac9:452664e (svn 200538:200539)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c936ac9..452664e
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1295813002
Cr-Commit-Position: refs/heads/master@{#343378}
Roll src/third_party/skia e844530:6fbdeef
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e844530..6fbdeef
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
6fbdeef [email protected] Revert of Paranoid temporary check that Chrome's building with SSE2 on all Windows builders. (patchset #1 id:1 of https://codereview.chromium.org/1283183004/ )
b157917 [email protected] SkScaledCodec class
Review URL: https://codereview.chromium.org/1290393003
Cr-Commit-Position: refs/heads/master@{#343377}
Do not send messages to active tab when sending messages from background to content.
Given a tab containing a webview, tab.sendMessage does not propagate the message down to the webview. As a result, we need to broadcast the message to all ports. The port cache includes the tab as well as the webview.
Review URL: https://codereview.chromium.org/1280463004
Cr-Commit-Position: refs/heads/master@{#343376}
Update V8 to version 4.6.74.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee251f04..c9c63eaa
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297613002
Cr-Commit-Position: refs/heads/master@{#343375}
Add helper method to determine the current application horizontal size classes.
BUG=518787
[email protected]
Review URL: https://codereview.chromium.org/1285123004
Cr-Commit-Position: refs/heads/master@{#343374}
Roll src/third_party/WebKit e2f1087:c936ac9 (svn 200537:200538)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e2f1087..c936ac9
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290413002
Cr-Commit-Position: refs/heads/master@{#343373}
[telemetry] Restore console.time at the end of TracingControllerTest.testModifiedConsoleTime
This patch fixes the associated bug by ensuring that console.time is
restored and tracing stopped at the end of the test.
BUG=520663
Review URL: https://codereview.chromium.org/1290333003
Cr-Commit-Position: refs/heads/master@{#343372}
Disable blink_perf.canvas on the reference build
The benchmark is generating garbage values on the reference build,
leading to a failure when we try to compute the standard deviation of
the results.
BUG=520092
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1292063006
Cr-Commit-Position: refs/heads/master@{#343371}
jni_generator: Wrap all native methods in stubs.
Instead of only wrapping native methods which call C++ methods, wrap
them all. This doesn't require any changes to the implementations, but
makes the handling of the two kinds of method more consistent in
preparation for introducing return type/parameter wrapping in future
changes.
This also changes the way that some of the stub code is generated to
make it less different depending whether native exports are in use, and
moves "extern "C"" declarations to be on only the specifically exported
symbols instead of applying to all forward declarations.
BUG=519562
[email protected]
Review URL: https://codereview.chromium.org/1279163006 .
Cr-Commit-Position: refs/heads/master@{#343370}
Roll src/third_party/WebKit f273fa5:e2f1087 (svn 200535:200537)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f273fa5..e2f1087
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289263002
Cr-Commit-Position: refs/heads/master@{#343369}
[Eraser strings] Remove unused Supervised User infobar and corresponding strings
BUG=None
Review URL: https://codereview.chromium.org/1288973003
Cr-Commit-Position: refs/heads/master@{#343368}
Roll src/third_party/WebKit 3ee1517:f273fa5 (svn 200534:200535)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3ee1517..f273fa5
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293783002
Cr-Commit-Position: refs/heads/master@{#343367}
Create a about handler component.
Create a about handler component.
The following files ::
chrome/browser/net/about_protocol_handler.*
net/url_request/url_request_about_job.*
moved to new component: components/about_handler.
Also added GYP and GN file for same.
BUG=516695
Review URL: https://codereview.chromium.org/1284173003
Cr-Commit-Position: refs/heads/master@{#343366}
Roll src/third_party/WebKit 09f3708:3ee1517 (svn 200533:200534)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/09f3708..3ee1517
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293693004
Cr-Commit-Position: refs/heads/master@{#343365}
Revert of [Telemetry] Improve local selection of port for forwarder. (patchset #1 id:1 of https://codereview.chromium.org/1292643002/ )
Reason for revert:
Speculative revert. All the XP reference builds started failing to connect to the browser after t his landed, e.g., http://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%281%29/builds/5271
Original issue's description:
> [Telemetry] Improve local selection of port for forwarder.
>
> Based on Ned's CL at https://codereview.chromium.org/1253393004/
> with a slight modification to make it so sockets do not fail to bind
> for being in the CLOSE_WAIT state.
>
> BUG=
>
> Committed: https://crrev.com/301c2a2213ce0bc50b2c5d777c5b63c4bde3eea1
> Cr-Commit-Position: refs/heads/master@{#343335}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1288933003
Cr-Commit-Position: refs/heads/master@{#343364}
Roll src/third_party/WebKit d5bb07d:09f3708 (svn 200530:200533)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d5bb07d..09f3708
Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.
NOTRY=true
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289623008
Cr-Commit-Position: refs/heads/master@{#343363}
Roll WebRTC 9703:9708, Libjingle 9703:9707
WebRTC 9703:9708
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/fa79fcc..09924b6
Libjingle 9703:9707
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/7972c68..ebc3027
TBR=
BUG=
Review URL: https://codereview.chromium.org/1287363003
Cr-Commit-Position: refs/heads/master@{#343362}
Roll src/third_party/WebKit 4a13a34:d5bb07d (svn 200520:200530)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a13a34..d5bb07d
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292333002
Cr-Commit-Position: refs/heads/master@{#343361}
Revert of Add dependency_manager initialization to binary_manager (patchset #10 id:230001 of https://codereview.chromium.org/1280903003/ )
Reason for revert:
speculative reverts: break the XP bots
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/39447
Original issue's description:
> Add dependency_manager initialization to binary_manager
>
> BUG=510231
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/f592ba18312f43fe4186cc526db00960a1db0b48
> Cr-Commit-Position: refs/heads/master@{#343320}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510231
Review URL: https://codereview.chromium.org/1296563002
Cr-Commit-Position: refs/heads/master@{#343360}
customtabs: Properly test background cgroup.
This is a follow-up to crrev.com/1287583003 improving the test for
cgroup membership.
BUG=517527
Review URL: https://codereview.chromium.org/1290343002
Cr-Commit-Position: refs/heads/master@{#343359}
Partially reverts "[Telemetry] Remove obsolete dependency. Remove py_trace.py since it's not used any where."
This CL partially reverts crrev.com/9d1576e4edddb590bf43df6a08e8fe39e72f0448
to add the missing dependencies.
The original CL breaks Mac bots http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/6574
BUG=472672
[email protected]
Review URL: https://codereview.chromium.org/1290113003
Review URL: https://codereview.chromium.org/1293743002 .
Cr-Commit-Position: refs/heads/master@{#343358}
Removing return value statement from the function that have void return type.
As the function return type is void so return value not required.
and GetSettingsForOneType() also does not return any value.
Another change is conversion from char* to char array.
BUG=520800
Review URL: https://codereview.chromium.org/1290923003
Cr-Commit-Position: refs/heads/master@{#343357}
translate: Fix Android dependency issue.
The source file data_file_renderer_cld_data_provider.cc depends on CLD2,
but is built regardless of whether cld_version==2 is true. This causes link
failures on Android when using LTO. Fix this by building this source file
only if the dependency exists.
BUG=469376
[email protected]
Review URL: https://codereview.chromium.org/1285333006
Cr-Commit-Position: refs/heads/master@{#343356}
Remove unnecessary #includes in //chrome/browser/prefs.
BUG=520542
Review URL: https://codereview.chromium.org/1285253003
Cr-Commit-Position: refs/heads/master@{#343355}
Drop an obsolete Keychain disclaimer in the import dialog.
BUG=466638
Review URL: https://codereview.chromium.org/1290183002
Cr-Commit-Position: refs/heads/master@{#343354}
Add metrics for tracking LoginDatabase::Init failure.
BUG=419070
Review URL: https://codereview.chromium.org/1285223002
Cr-Commit-Position: refs/heads/master@{#343353}
Vibration API: convert implementation to java mojo-service.
Implement mojo interface VibrationManager on Android
using Java directly instead of using C++ plus JNI.
BUG=439434
TEST=manually test vibration OK
Review URL: https://codereview.chromium.org/1274033002
Cr-Commit-Position: refs/heads/master@{#343352}
Gallery: scale the image not to overlap toolbars and add exit button.
In edit mode,
* scale the image not to overlap the toolbars.
* add exit button.
BUG=520777
TEST=none
Review URL: https://codereview.chromium.org/1291963003
Cr-Commit-Position: refs/heads/master@{#343351}
[tracing] Add WebCache memory usage in Blink to chrome://tracing
WebCache stores the web content downloaded from the internet in
memory. This CL adds memory statistics of WebCache to tracing.
BUG=466141
Review URL: https://codereview.chromium.org/1283793004
Cr-Commit-Position: refs/heads/master@{#343350}
Roll src/third_party/WebKit 14b57e9:4a13a34 (svn 200516:200520)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/14b57e9..4a13a34
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290333002
Cr-Commit-Position: refs/heads/master@{#343349}
HTMLViewer no longer connects to NetworkService interface.
[email protected]
http://crbug.com/510210
Review URL: https://codereview.chromium.org/1290323002
Cr-Commit-Position: refs/heads/master@{#343348}
Mac: Fix Japanese IME regression
This is a partial revert of https://codereview.chromium.org/1240943002.
Setting handling_input_event_ to true in OnImeSetComposition caused this
regression. This was needed to fix Korean IME on 10.11 (crbug.com/500376),
but when I tested with the latest 10.11 beta 15A244d, Korean IMA works just
fine without this change. Looks like Apple fixed something in the latest beta.
BUG=516882,500376
Review URL: https://codereview.chromium.org/1291253002
Cr-Commit-Position: refs/heads/master@{#343347}
Gallery: accessibility fixes.
In Slide mode,
* Add alt attribute to image elements of bottom thumbnails.
In Thumbnail mode,
* Make thumbnails focusable by tab key.
* Focus to selected element.
* Change selected element when focus has changed.
BUG=501153
TEST=none
Review URL: https://codereview.chromium.org/1292483003
Cr-Commit-Position: refs/heads/master@{#343346}
Roll src/third_party/skia 16b9913:e844530
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/16b9913..e844530
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
e844530 [email protected] Paranoid temporary check that Chrome's building with SSE2 on all Windows builders.
Review URL: https://codereview.chromium.org/1292583003
Cr-Commit-Position: refs/heads/master@{#343345}
Update V8 to version 4.6.73.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/48f7882f..ee251f04
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290313002
Cr-Commit-Position: refs/heads/master@{#343344}
Roll src/third_party/WebKit 25f83be:14b57e9 (svn 200512:200516)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/25f83be..14b57e9
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289173002
Cr-Commit-Position: refs/heads/master@{#343343}
net: Cleanup includes of dns_util.h.
These files are not using any of the three functions from dns_util.h.
BUG=None
TEST=net_unittests
[email protected]
Review URL: https://codereview.chromium.org/1286933003
Cr-Commit-Position: refs/heads/master@{#343342}
Revert of Implement common stats-update method for use by multiple video-renderers. (patchset #9 id:550001 of https://codereview.chromium.org/1253193003/ )
Reason for revert:
Caused compile failures on android gpu bots and closed tree.
Original issue's description:
> Implement common stats-update method for use by multiple video-renderers.
> Move driving of uploading UMA stats to ChromotingStats, using callbacks defined in ChromotingInstance.
> Also add UMA histograms for latency metrics.
> BUG=508602
> Committed: https://crrev.com/d4abf8724d7dc81eb816d86c8ae82d799aafabda
> Cr-Commit-Position: refs/heads/master@{#343339}
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=508602
Review URL: https://codereview.chromium.org/1292733002 .
Cr-Commit-Position: refs/heads/master@{#343341}
Roll src/third_party/WebKit 46ff567:25f83be (svn 200502:200512)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/46ff567..25f83be
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1297533003
Cr-Commit-Position: refs/heads/master@{#343340}
Implement common stats-update method for use by multiple video-renderers.
Move driving of uploading UMA stats to ChromotingStats, using callbacks defined in ChromotingInstance.
Also add UMA histograms for latency metrics.
BUG=508602
Review URL: https://codereview.chromium.org/1253193003
Cr-Commit-Position: refs/heads/master@{#343339}
Gallery: add cancel button to crop and brightness operations.
BUG=520126
TEST=none
Review URL: https://codereview.chromium.org/1294433002
Cr-Commit-Position: refs/heads/master@{#343338}
Fix response bytes getters in URLFetcher.
Change URLFetcherCore to read the values for
GetReceivedResponseContentLength() and GetTotalReceivedBytes() after the
request has finished processing, rather than immediately after the
response started. Add tests to verify this.
BUG=
Review URL: https://codereview.chromium.org/1285403002
Cr-Commit-Position: refs/heads/master@{#343337}
Make tab audio indicators theme-aware.
You can test this on, e.g., the Tiesto theme.
BUG=515184
Review URL: https://codereview.chromium.org/1272183005
Cr-Commit-Position: refs/heads/master@{#343336}
[Telemetry] Improve local selection of port for forwarder.
Based on Ned's CL at https://codereview.chromium.org/1253393004/
with a slight modification to make it so sockets do not fail to bind
for being in the CLOSE_WAIT state.
BUG=
Review URL: https://codereview.chromium.org/1292643002
Cr-Commit-Position: refs/heads/master@{#343335}
Service Worker: Factor out NewTabPage from page load count metrics
NewTabPage is dominating our data. This change:
1) Replaces the user action ControlledPageLoad with a histogram PageLoad,
with buckets for NTP and Other.
2) Removes NTP page loads from RAPPOR metric.
BUG=508399
Review URL: https://codereview.chromium.org/1284143002
Cr-Commit-Position: refs/heads/master@{#343334}
More cr.ui.FocusRow simplifications
cr.ui.FocusRow no longer inherits from HTMLDivElement. Instead, it takes
a |root| argument in its constructor and uses |this.root| more.
Before there was lots of type variance. Something would start as a
<div>, then get decorated, but only work because cr.ui.FocusGrid derives
a <div>. This is clearer, more future-proof solution.
BUG=425626,518053
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1282043004
Cr-Commit-Position: refs/heads/master@{#343333}
Disable testTimelineBasedMeasurementGestureAdjustmentSmoke on Win.
BUG=520781
Review URL: https://codereview.chromium.org/1288273003
Cr-Commit-Position: refs/heads/master@{#343332}
relnote: QUIC - Added 'FRTT' connection option to run a finch based
experiment that sets the FEC timeout to 0.25 RTT. This is a temporary
change. Will revert these changes after getting results for this
experiment.
Merge internal change: 100617579
[email protected]
Review URL: https://codereview.chromium.org/1292243002
Cr-Commit-Position: refs/heads/master@{#343331}
Updating trunk VERSION from 2482.0 to 2483.0
Cr-Commit-Position: refs/heads/master@{#343330}
GN: Fix more "Source file not found" errors.
Checked on Linux with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ gn check --force out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' '*' | grep -n10 Source
BUG=502447
TEST=see above
[email protected]
Review URL: https://codereview.chromium.org/1289623007
Cr-Commit-Position: refs/heads/master@{#343329}
Roll src/third_party/skia 8f4fe37:16b9913
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8f4fe37..16b9913
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
16b9913 [email protected] Split GrDrawBatch and GrVertexBatch into their own files
Review URL: https://codereview.chromium.org/1289143002
Cr-Commit-Position: refs/heads/master@{#343328}
Add support for the GYP_CROSSCOMPILE env var to MB.
This is needed to support building the "Linux ARM" configurations w/ MB,
which are cross-compiles but the target os is linux, not android or iOS.
Theoretically it might be needed for a real CrOS compile as well. You
can now specify that a cross-compile is needed with the 'crosscompile'
mixin.
We don't normally need this flag for android and ios builds, because
gyp_chromium sets it for us when target_os={android,ios}.
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1294663002
Cr-Commit-Position: refs/heads/master@{#343327}
Move mac-only resources which should be vectorized into legacy directory
BUG=520324
Review URL: https://codereview.chromium.org/1292603002
Cr-Commit-Position: refs/heads/master@{#343326}
[Android] fix gyp_managed_install
broken by https://codereview.chromium.org/1290173003
BUG=
Review URL: https://codereview.chromium.org/1289083003
Cr-Commit-Position: refs/heads/master@{#343325}
Roll src/third_party/WebKit 32de48f:46ff567 (svn 200499:200502)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/32de48f..46ff567
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289693006
Cr-Commit-Position: refs/heads/master@{#343324}
UMA Histogram for outgoing invalidation messages sent using GCM upstream.
The histogram will be used for tracking the status of outgoing
invalidation messages sent using GCM upstream for Android clients.
BUG=477059
Review URL: https://codereview.chromium.org/1285983003
Cr-Commit-Position: refs/heads/master@{#343323}
Fix overscroll glow when page contents are smaller than viewport.
The overscroll glow effect positioning assumed that the content was always at
least as big as the viewport. When this assumption was violated, the viewport
would appear to "overscroll" its bound, pushing the bottom glow up, since the
positioning code attempts to offset the glow so that it appears to be fixed to
the page contents (and scrolls with it).
This patch artificially expands the content size to be at lesat the size of the
viewport. This is done by inflating the contents to the size of the viewport at
minimum scale, since that's what the scrolling bounds are.
BUG=421652
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1118033002
Cr-Commit-Position: refs/heads/master@{#343322}
SkPDF: Move SkFlate into src/pdf (part 2/3)
This must land after http://crrev.com/1285913002
Motivation: Skia only uses SkFlate.cpp in the SkPDF module, se we now
include it in third_party/skia/gyp/pdf.gypi. After this CL lands,
Skia can move third_party/skia/src/core/SkFlate.{h,cpp} to
third_party/skia/src/pdf, where it belongs.
Review URL: https://codereview.chromium.org/1288053002
Cr-Commit-Position: refs/heads/master@{#343321}
Add dependency_manager initialization to binary_manager
BUG=510231
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1280903003
Cr-Commit-Position: refs/heads/master@{#343320}
Mac Partial Swap: Fix sub-layer rounding issue
The contents rect was calculated using pixels and the frame was
calculated using dips.
If the damage rect is not divisible by the scale factor, then this
gives us a contents rect that doesn't quite line up with the frame that
it's being put in.
Move all calculations to be done using dips instead.
BUG=519995
Review URL: https://codereview.chromium.org/1292173002
Cr-Commit-Position: refs/heads/master@{#343319}
Fix UserSessionManager::Shutdown ordering.
UserSessionManager::Shutdown calls ~TokenHandleFetcher.
~TokenHandleFetcher sometimes calls ProfileOAuth2TokenService when there's a
pending request.
ProfileOAuth2TokenService is a profile KeyedService that gets deleted when
ProfileImpls are deleted.
ProfileImpls are owned by ProfileManager, which is owned by BrowserProcess,
and these get deleted in BrowserProcessImpl::StartTearDown, which is called
by ChromeBrowserMainParts::PostMainMessageLoopRun.
Hence UserSessionManager::Shutdown must be called before PostMainMessageLoopRun,
otherwise we have crashes when UserSessionManager::token_handle_fetcher_
is not null, and there are pending refresh token requests.
BUG=510997
Review URL: https://codereview.chromium.org/1285363003
Cr-Commit-Position: refs/heads/master@{#343318}
Pre-emptive fix for X11 breaking third_party/protobuf roll.
browser_desktop_window_tree_host_x11.h includes a header which includes
Xlib.h, which defines helpful macros like Status, Bool, and True.
Unfortunately, another header included by this file indirectly includes
a generated protobuf which tries to forward declare a class called
'Status'.
As it turns out, sorting the includes to follow the style guide happens
to fix this particular error, since the generated protobuf header is now
included before Xlib.h.
BUG=none
Review URL: https://codereview.chromium.org/1297513002
Cr-Commit-Position: refs/heads/master@{#343317}
Fixed classic Mac menu behavior.
TESTED=unit test,manual testing
BUG=517384
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1278423003
Cr-Commit-Position: refs/heads/master@{#343316}
Revert of Mac Overlays: Make ImageTransportSurfaceOverlayMac observe GPU switches (patchset #1 id:1 of https://codereview.chromium.org/1291703002/ )
Reason for revert:
Broke compile. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9%20%28retina%29/builds/4403
Original issue's description:
> Mac Overlays: Make ImageTransportSurfaceOverlayMac observe GPU switches
>
> When the GPU switches, create a new OpenGL context, to see which GL
> renderer it uses. Whenever a context is made current to the surface,
> ensure that the context is using the appropriate renderer.
>
> Ideally, the GpuSwitchingManager should be able to tell the observers
> which GL renderer to use, but that is not currently wired up.
>
> BUG=519097
>
> Committed: https://crrev.com/0009e1ea4154c5a20fffa3cf47b0b29c23a6f7e2
> Cr-Commit-Position: refs/heads/master@{#343277}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=519097
Review URL: https://codereview.chromium.org/1294733002
Cr-Commit-Position: refs/heads/master@{#343315}
Fix DCHECK in clipboard_mac.mm on session shutdown
Clipboard::Stop was removed in the CL:
https://codereview.chromium.org/930403002/
but the Mac implementation still had a DCHECK in the destructor to assert that
the timer had already been stopped prior to destruction.
I verified that, in It2Me, the destructor is called on the input thread. The
DCHECK was probably an artifact of the old NPAPI days. I also removed the
comment indicating that Start & Inject had to be called on the UI thread. I
found no evidence that NSPasteboard required to be called in the UI thread -
and the clipboard is working.
BUG=
Review URL: https://codereview.chromium.org/1297433003
Cr-Commit-Position: refs/heads/master@{#343314}
Building the New Task Manager UI (Phase 5)
This CL implements the first real observer of the new task manager -- the
NewTaskManagerTableModel that will adapt the new task manager to the requirements
of the TableView. It also implements the NewTaskManagerView.
To test the new task manager, you must run using the --enable-new-task-manager
switch.
[email protected]
BUG=471008, 471007
Review URL: https://codereview.chromium.org/1259703005
Cr-Commit-Position: refs/heads/master@{#343313}
[Contextual Search] Hide CS Bar when selection clears.
There's a corner case where the Bar doesn't hide when the
selection is cleared due to notification related to the
"second tap selects" feature. Now narrowing the condition
to check for a long-press selection before ignoring the
tap. A better fix will be to remove this method, when
we address issue 444114.
BUG=491848
Review URL: https://codereview.chromium.org/1289593002
Cr-Commit-Position: refs/heads/master@{#343312}
ChromeContentsRulesRegistry: encapsulate predicate evaluation state/logic
Moves all logic and state for predicate evaluation into the respective
trackers, so that ChromeContentsRulesRegistry no longer needs to serve
as a middleman for tracker-specific evaluation details.
This is in support of step 6 in the associated bug. No functional change
is intended.
BUG=492946
Review URL: https://codereview.chromium.org/1287373002
Cr-Commit-Position: refs/heads/master@{#343311}
GN fixes for recent changes to media. There has not been an automated GN builder, allowing the files to become stale.
Makes BUILD.gn files current for public TOT clang build. This CL will allow us to spin up an automated builder.
BUG=516899
Bug: b/17615224
Review URL: https://codereview.chromium.org/1283253002
Cr-Commit-Position: refs/heads/master@{#343310}
Fix typo in branding_Chromium
This fixes IT2Me when building the Chromium version of Chromoting.
BUG=
Review URL: https://codereview.chromium.org/1289043003
Cr-Commit-Position: refs/heads/master@{#343309}
[Telemetry] Remove obsolete dependency. Remove py_trace.py since it's not used any where.
BUG=472672
Review URL: https://codereview.chromium.org/1290113003
Cr-Commit-Position: refs/heads/master@{#343308}
Properly name the content shell browser process in traces
In Chrome this is done by content/browser/browser_main.cc, which is not run by the content shell.
R=pfeldman
BUG=
Review URL: https://codereview.chromium.org/1280133003
Cr-Commit-Position: refs/heads/master@{#343307}
Switch android to build with safe_browsing=3 mode,
now that the required GMSCore client lib has landed.
This compiles in the support for safe browsing, but functionality is
gated by the AndroidSafeBrowsing field trial that is
disabled by default.
BUG=474608
Review URL: https://codereview.chromium.org/1290153002
Cr-Commit-Position: refs/heads/master@{#343306}
Roll src/third_party/WebKit 2aacfa3:32de48f (svn 200492:200499)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2aacfa3..32de48f
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290093005
Cr-Commit-Position: refs/heads/master@{#343305}
Move checkbox hack to cr-checkbox
The change to paper-checkbox from
https://codereview.chromium.org/1284033003 broke both the
settings checkbox and cr-checkbox. This moves the fix to
cr-checkbox.
BUG=none
Review URL: https://codereview.chromium.org/1291223002
Cr-Commit-Position: refs/heads/master@{#343304}
Fix test method NewRequestWithRoute()
In the ResourceSchedulerTest fixture, formerly the NewRequestWithRoute()
method had the child and route parameters the wrong way around.
This CL corrects the order of the parameters.
This only affects the
ResourceSchedulerTest.BackgroundRequestStartsImmediately test, which
passed accidentally before, and now passes intentionally.
BUG=
TEST=content_unittests
Review URL: https://codereview.chromium.org/1295593003
Cr-Commit-Position: refs/heads/master@{#343303}
Partial revert of r330042 "Draw the offscreen texture to reflector's surface without extra copy"
Revert the SwapBufferComplete signal back to use sync point, rather than waiting for CompositionStart events on mirroring displays.
Reason for revert:
This is causing flickering (crbug.com/515332).
BUG=515332
Review URL: https://codereview.chromium.org/1275543006
Cr-Commit-Position: refs/heads/master@{#343302}
Rename chrome/utility/safe_browsing/mac/test_utils.* so GN does not complain.
"""
ERROR at //testing/test.gni:189:5: Duplicate object file
executable(target_name) {
^------------------------
The target //chrome/test:unit_tests
generates two object files with the same name:
obj/chrome/test/unit_tests/test_utils.o
It could be you accidentally have a file listed twice in the
sources. Or, depending on how your toolchain maps sources to
object files, two source files with the same name in different
directories could map to the same object file.
In the latter case, either rename one of the files or move one of
the sources to a separate source_set to avoid them both being in
the same target.
"""
[email protected]
Review URL: https://codereview.chromium.org/1287033009
Cr-Commit-Position: refs/heads/master@{#343301}
Add window.gc back to Smoothness.WillNavigateToPageHook
BUG=516525
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1271963002
Cr-Commit-Position: refs/heads/master@{#343300}
cc: Don't mark any tilings low resolution during animation/pinch.
This patch ensures that while we're animating or pinching, we not only
not create low resolution tilings (which was already the case), but we
also don't mark any existing tilings as low resolution.
If we do, this can cause checker flashes when low res becomes high res
again, since we have to reset it due to low quality filters that might
have been applied.
BUG=517749
R=danakj, enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1296453002
Cr-Commit-Position: refs/heads/master@{#343299}
[NaCl SDK] nacl_io: Make the default directory size returned by stat to be 4096
Review URL: https://codereview.chromium.org/1293543006
Cr-Commit-Position: refs/heads/master@{#343298}
Fix MB definitions for Linux Builder (dbg)(32), Linux Tests.
The debug builder needed to be configured to use swarming, and the
Linux Tests bot should match the Linux Builder bot.
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1289093002
Cr-Commit-Position: refs/heads/master@{#343297}
Removed unused WKWebViewConfigurationProvider::HasWebViewConfiguration.
BUG=None
Review URL: https://codereview.chromium.org/1289803008
Cr-Commit-Position: refs/heads/master@{#343296}
Roll src/third_party/skia 0944100:8f4fe37
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0944100..8f4fe37
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
8f4fe37 [email protected] some catchup CL revisions
7e6d9c0 [email protected] Every pixel ref gets its own mutex.
c7993d7 [email protected] Revert of SkScaledCodec class (patchset #34 id:660001 of https://codereview.chromium.org/1260673002/ )
00ba1e0 [email protected] Belt and suspenders for colors in DrawAtlasBatch test
abd30f5 [email protected] Introduce GrBatch subclasses GrDrawBatch and GrVertexBatch to prepare for non-drawing batches
8f34372 [email protected] Extend SkImageGenerator to support natively generated GrTextures. As part of this, added uniqueID() to the generator, and made it be in the same namespace is bitmaps, pixelrefs, images.
5a16cf6 [email protected] Normalize SkXfermode_opts.h argument order as d,s[,aa].
d518ea7 [email protected] SkScaledCodec class
1acf250 [email protected] Fix for VALGRIND DrawAtlas test issue.
e5aaa07 [email protected] Revert of SkScaledCodec class (patchset #32 id:620001 of https://codereview.chromium.org/1260673002/ )
Review URL: https://codereview.chromium.org/1290093004
Cr-Commit-Position: refs/heads/master@{#343295}
cc: Remove SchedulerStateMachine::UpdateState
Also rename UpdateStateOn<Action> to Will<Action> and
call Will<Action> directly from the Scheduler.
This is in preparation of adding a Did<Action> methods
that will allow us to update state immediately
in response to the results of an action.
Update and restructure tests for new interface.
BUG=486072
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1253203003
Cr-Commit-Position: refs/heads/master@{#343294}
[Password Generation] Fix bug in generated password used histogram
Previously the first usage of non-PSL generated password would not be counted.
BUG=519875
Review URL: https://codereview.chromium.org/1283243003
Cr-Commit-Position: refs/heads/master@{#343293}
Roll src/third_party/WebKit e61622f:2aacfa3 (svn 200478:200492)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e61622f..2aacfa3
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1294633002
Cr-Commit-Position: refs/heads/master@{#343292}
Fix typo: subdomian -> subdomain.
BUG=
Review URL: https://codereview.chromium.org/1293623002
Cr-Commit-Position: refs/heads/master@{#343291}
Separating the two tests into different executions.
By specifying the gtest_filter to run the two tests separately, we will be restart the host, which allows for independence between the two tests. If the host is not restarted before the 2nd test, the first connection numbers that it obtains is already a reconnect.
BUG=
Review URL: https://codereview.chromium.org/1295533002
Cr-Commit-Position: refs/heads/master@{#343290}
Revert to zero-initializing buffers for FFmpegVideoDecoder
Following the regression on , I reverted back to PatchSet#5 from [1]
[0] https://code.google.com/p/chromium/issues/detail?id=514759
[1] https://codereview.chromium.org/1227383003
- Modified VideoFramePool::CreateFrame() to zero-initialize newly allocated frames.
BUG=514759
Review URL: https://codereview.chromium.org/1267003004
Cr-Commit-Position: refs/heads/master@{#343289}
Android Chromoting: Use GoogleAuthUtil to fetch OAuth tokens.
The app currently uses android.accounts.AccountManager to obtain an
OAuth access token for fetching the list of hosts. According to
https://developers.google.com/android/guides/http-auth
the recommended process is to use GoogleAuthUtil.
Since the AccountManager callback was previously running on a different
thread, this CL also fixes this thread-safety issue.
BUG=469335
Review URL: https://codereview.chromium.org/1285883002
Cr-Commit-Position: refs/heads/master@{#343288}
Fixed subsample size adjustment in AVC AnnexB conversion
This is a bugfix for crbug.com/519955: The code that updates subsample
sizes in MP4StreamParser::PrepareAVCBuffer is incorrect. It works
correctly only for cases when avc_config.length_size is 4 (which is
actually almost all real-life uses of this code) and when there is only
one NALU per subsample for cases when avc_config.length_size is 1 or 2.
For cases when avc_config.length_size is 1 or 2 and there are multiple
NALUs in some subsample, the calculations are incorrect, we actually
need to update subsample sizes based on how many NALUs were encountered
in each subsample (since AVC::ConvertFrameToAnnexB replaces NALU size
values read from mp4 container with 4-bytes AnnexB codes for each NALU).
BUG=519955
Review URL: https://codereview.chromium.org/1289733002
Cr-Commit-Position: refs/heads/master@{#343287}
Updates to StringSplit implementation
Remove the deprecated StringSplit implementation. The header declarations and all external uses were already removed, but the actual implementation was not removed.
It was still used by SplitStringIntoKeyValuePairs which is now updated to use the new version.
Both the key/value splitter and the substring variants have been updated to avoid many intermediate copies.
Updates the name of a trim whitespace variant in string_util to match the header. This is currently unused but was provided for symmetry before.
Review URL: https://codereview.chromium.org/1291103002
Cr-Commit-Position: refs/heads/master@{#343286}
cc: Plumb more details about pixel refs to tile manager.
This patch plumbs the full pixel ref information (including matrix and
rect) to tile manager. Currently, we still just use the pixel ref
itself, but this will change.
Also modifies unittests to test the rect to be in the expected area.
Changing the unittests also revealed a few bugs that this patch also
addresses.
R=danakj, enne, weiliangc
BUG=516751
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1279843004
Cr-Commit-Position: refs/heads/master@{#343285}
Use CapabilityFilter to restrict what HTMLViewers can connect to.
[email protected]
http://crbug.com/510210
Review URL: https://codereview.chromium.org/1287043004
Cr-Commit-Position: refs/heads/master@{#343284}
[Android] Add UMA histograms to measure context menu actions.
This adds four related histograms to measure how users interact with
context menus. The histograms are ContextMenu.Link, ContextMenu.Image,
ContextMenu.ImageLink, and ContextMenu.Video, and the values are the
various actions that can be taken on each context menu, e.g. "Open in
new tab" or "Save image".
For example, if a user long presses an image and selects "Copy image",
we'll record the "Copy image" event in the ContextMenu.Image histogram.
ContextMenu.ImageLink is used when the user long presses an image which
is also a link. This case is treated specially because its context menu
is currently so long that it needs extra love and investigation.
BUG=483685
Review URL: https://codereview.chromium.org/1267213002
Cr-Commit-Position: refs/heads/master@{#343283}
Provide a GMScore based AccountIdProvider by default.
We don't need a setter since there is a single implementation that is only overridden in tests.
This also prevents cases where we wrongly allowed the getter to return null because of tests.
BUG=519491
Review URL: https://codereview.chromium.org/1290223002
Cr-Commit-Position: refs/heads/master@{#343282}
Oops, add a forgotten 'return' after we send an error due to not finding a frame host.
BUG=500989
Review URL: https://codereview.chromium.org/1292613002
Cr-Commit-Position: refs/heads/master@{#343281}
Make fullscreen disabled by default in custom tab and optional to enable
Adds an extra to CustomTabsIntent to be surfaced by the data provider.
The default is disabled. This sets the related fullscreen manager value
on initialization
BUG=520369
Review URL: https://codereview.chromium.org/1283423002
Cr-Commit-Position: refs/heads/master@{#343280}
Switch AudioRendererAlgorithm to buffer based on time.
It doesn't make sense to buffer based on a frame count when the
amount of time that data represent varies with sample rate; it's
the opposite of what we want. I.e., a 48kHz playback will exhaust
this buffer faster than a 44.1kHz playback.
Instead, switch to time based initial capacity using the sample
rate provided during initialization. This provides a greater
resilience against underflow when video decoding is overloading
the media thread.
At 48kHz we were previously buffering ~171ms and at 44.1kHz we were
buffering ~186ms of audio data. I've chosen a nice round 200ms for
simplicity and since it works well on an Android One device.
BUG=519108
TEST=media_unittests still pass.
Review URL: https://codereview.chromium.org/1278733004
Cr-Commit-Position: refs/heads/master@{#343279}
Add support for H264 and VP9 to AndroidVDA
Previously the AndroidVideoDecodeAccelerator only supported
VP8. Now it has experimental support for VP9 and H264.
BUG=511375,507834
TEST=Manually play h264 src= video in chrome shell
Review URL: https://codereview.chromium.org/1282083003
Cr-Commit-Position: refs/heads/master@{#343278}
Mac Overlays: Make ImageTransportSurfaceOverlayMac observe GPU switches
When the GPU switches, create a new OpenGL context, to see which GL
renderer it uses. Whenever a context is made current to the surface,
ensure that the context is using the appropriate renderer.
Ideally, the GpuSwitchingManager should be able to tell the observers
which GL renderer to use, but that is not currently wired up.
BUG=519097
Review URL: https://codereview.chromium.org/1291703002
Cr-Commit-Position: refs/heads/master@{#343277}
Switch media stream permissions to use IsOriginSecure() instead of SchemeIsSecure().
In particular, note that this means that media permissions are persisted on
http://localhost .
The change also updates the old media stream permission tests (which
were no longer testing anything meaningful).
(This is a reland of https://codereview.chromium.org/1276373004/ with a fixed
test, after it was reverted in https://codereview.chromium.org/1276373004/ )
BUG=295723, 362214, 509844
Review URL: https://codereview.chromium.org/1286363002
Cr-Commit-Position: refs/heads/master@{#343276}
GN: app_list_unittests links on Mac.
Tested on Mac with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ ninja -C out-gn/Release app_list_unittests
BUG=431177
TEST=see above
[email protected]
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1288263002
Cr-Commit-Position: refs/heads/master@{#343275}
[Variations] Add config for Extension dev mode warning and install verification
Add an entry in the config for the ExtensionDeveloperModeWarning and
ExtensionInstallVerification experiments.
BUG=469852
Review URL: https://codereview.chromium.org/1265173003
Cr-Commit-Position: refs/heads/master@{#343274}
Revert of [Download Notification] Update notification as progress type on complete/cancel (patchset #1 id:20001 of https://codereview.chromium.org/1279593003/ )
Reason for revert:
Causes Failure of MultiProfileDownloadNotificationTest.DownloadMultipleFiles
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/7569
(somewhat flakily)
Original issue's description:
> [Download Notification] Update notification as progress type on complete/cancel
>
> We have had the code showing notification as progress type once before showing it as base type. But it didn't work due to a bug (see the comment in the review for detail). This patch fixes it and refactor the code to make the code clear.
>
> BUG=518698
> TEST=manually tested
>
> Committed: https://crrev.com/e9f08c080017f0b8eae92541d265f9cde1d78c06
> Cr-Commit-Position: refs/heads/master@{#343247}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518698
Review URL: https://codereview.chromium.org/1292213002
Cr-Commit-Position: refs/heads/master@{#343273}
media: Refactor SkCanvasVideoRenderer to use SkImages and not SkBitmaps.
Refactor SkCanvasVideoRenderer to use SkImages instead of SkBitmaps as
suggested by the Skia team.
With this patch we remove any explicit reference to SkBitmaps in SkCanvasVideoRenderer.
The cache for the last frame is a SkImage that hides specific implementation
details.
This patch also avoids a copy when VideoFrame is backed by only one native
texture and it's possible to use it it directly to draw it to the canvas
instead of copying it to a temporary texture before drawing.
Additionally, a discardable memory allocator instance has now to be set in
cc main test suite since SkImage uses discardable memory and cc tests uses
SkCanvaSVideoRenderer.
BUG=449197
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1144323003
Cr-Commit-Position: refs/heads/master@{#343272}
Record metrics for extension event dispatch.
This adds the first 5 metrics based on extensions::events::HistogramValue:
* Extensions.Events.Dispatch: recorded every time an event is dispatched.
* Extensions.Events.DispatchToComponent: recorded every time an event is
dispatched to a component extension.
* Extensions.Events.DispatchWithPersistentBackgroundPage: recorded every time
an event is dispatched to an extension with a persistent background page.
* Extensions.Events.DispatchWithRunningEventPage: recorded every time an event
is dispatched to an extension with an event page that was already running.
* Extensions.Events.DispatchWithSuspendedEventPage: recorded every time an event
is dispatched to an extension with an event page that was previously
suspended, and is now no longer suspended.
[email protected], [email protected]
BUG=503402
Review URL: https://codereview.chromium.org/1288753003
Cr-Commit-Position: refs/heads/master@{#343271}
Reenable tests which were disabled while we investigated flakiness on Windows trybots.
The cause had been reverted.
BUG=517488,334372,517018,517029,517307,517309,517484
[email protected]
Review URL: https://codereview.chromium.org/1284143004
Cr-Commit-Position: refs/heads/master@{#343270}
Add apktool and apktool.jar to install-build-deps-android.sh
BUG=452927
[email protected]
Review URL: https://codereview.chromium.org/1287133002
Cr-Commit-Position: refs/heads/master@{#343269}
Remove peerconnection_server from libjingle.gyp
The peerconnection_server examples were moved to webrtc and peerconnction_server
was removed from BUILD.gn. But the target was not removed from the gyp
file. This caused some ninja generators to complain about missing files.
BUG=
Review URL: https://codereview.chromium.org/1290603002
Cr-Commit-Position: refs/heads/master@{#343268}
Telemetry: Add out/Default to the desktop browser search path.
This is the path recommended for the gn build in the get-the-code docs:
https://www.chromium.org/developers/how-tos/get-the-code
BUG=520545
TEST=locally ran run_benchmark
Review URL: https://codereview.chromium.org/1292083002
Cr-Commit-Position: refs/heads/master@{#343267}
Fix uninitialized ax_tree_id_ in BrowserAccessibilityManager constructor.
This has been breaking MSan bots for a week.
BUG=519045
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287403003
Cr-Commit-Position: refs/heads/master@{#343266}
[Cronet] Edit Proguard flags to strip unused
Review URL: https://codereview.chromium.org/1280163005
Cr-Commit-Position: refs/heads/master@{#343265}
Update icons throughout Views avatar menu to vector versions
The icons all look more or less the same. The exception is that some of the warning icons are grey instead of yellow (which looks far better on the light background of the bubble, and matches all other icons).
The incognito guy doesn't have an SVG version yet, so he's left alone.
The avatar button warning icon is still yellow. This button is going to be affected by the MD refresh so this will likely be revisited, but for now we maintain the status quo.
BUG=505953
Review URL: https://codereview.chromium.org/1268403005
Cr-Commit-Position: refs/heads/master@{#343264}
"Simplify Page" print preview option enables
preprocessing of the page using the DOM Distiller.
Rendering happens in a hidden web contents, that lives
in parallel with the originally printed contents.
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/_-zEoPLFKp0
BUG=490809
[email protected], [email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/1125343004 .
Patch from Arjun Patel <[email protected]>.
Cr-Commit-Position: refs/heads/master@{#343263}
Add testing configs for changing the variations fetch interval.
BUG=none
Review URL: https://codereview.chromium.org/1289013002
Cr-Commit-Position: refs/heads/master@{#343262}
Add ReadStream interface, and implementations for file- and memory-backed streams.
BUG=496898
[email protected]
Review URL: https://codereview.chromium.org/1276653004
Cr-Commit-Position: refs/heads/master@{#343261}
Disable time.com in tough_ad_cases
This page is timing out on the Nexus 9.
BUG=520509
Review URL: https://codereview.chromium.org/1291513003
Cr-Commit-Position: refs/heads/master@{#343260}
Update V8 to version 4.6.72.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0dfdcdc5..48f7882f
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1293543005
Cr-Commit-Position: refs/heads/master@{#343259}
Roll src/third_party/skia 9c80b5f:0944100
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9c80b5f..0944100
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
0944100 [email protected] SkScaledCodec class
e516e4f [email protected] fix up batch_spew
Review URL: https://codereview.chromium.org/1292143002
Cr-Commit-Position: refs/heads/master@{#343258}
[Android] Reland of Remove android_commands and android_testrunner.
Original CL: https://codereview.chromium.org/1290773009/
Revert: https://codereview.chromium.org/1288993002/
BUG=267773
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290173003
Cr-Commit-Position: refs/heads/master@{#343257}
Reorder saving tab list state.
When Chrome on Android is terminated, it saves the state of
every open tab in a queue and then saves the list of open
tabs last. If it is killed immediately, there is very little
time and often the list of open tabs are not saved, so no
tab can be restored.
By saving the list of open tabs first, even if Chrome is
killed immediately, at least on restore the user would get
back his opened tabs, albeit without history or per-tab
state since that would still not have finished. This
solution is, however, much better than not having any of
the tabs restored.
BUG=511513
Review URL: https://codereview.chromium.org/1291793002
Cr-Commit-Position: refs/heads/master@{#343256}
Keep track of the timestamps for coalesced events
Events can be coalesced at browser side before being sent to
renderer. Currently when coalescing happens, some events'
timestamp are lost, i.e. we preserve the timestamp from
either the newest event or the oldest event.
In this CL we use the event's LatencyInfo to carry the timestamps of
a small set (up to 2) of the raw events. These timestamp are
used for input latency UMA metric. A heap based container to
carry the timestamp of all the raw input events seems excessive.
So lets use a stack based container with a small fixed-size and
see how it can change the graph pattern of our UMA metrics for
Event.Latency.Renderer2.MouseWheel/GestureScrollUpdate.
BUG=352193
Review URL: https://codereview.chromium.org/1231433006
Cr-Commit-Position: refs/heads/master@{#343255}
Add a passwords counter to the Clear Browsing Data dialog.
The counting is restarted whenever the deletion preference or the contents of the password store change.
This CL also contains some polishing of the parent BrowsingDataCounter class.
BUG=510028
Review URL: https://codereview.chromium.org/1275593002
Cr-Commit-Position: refs/heads/master@{#343254}
Fixes the Khmer test.
The Khmer test shouldn't have spaces between the words.
TEST=*Skippable*Khmer*
BUG=None
Review URL: https://codereview.chromium.org/1285263002
Cr-Commit-Position: refs/heads/master@{#343253}
Polish various portions of the emulator UI.
BUG=520329
[email protected]
Review URL: https://codereview.chromium.org/1287973007
Cr-Commit-Position: refs/heads/master@{#343252}
Roll src/tools/gyp to 6ee91ad8659871916f9aa840d42e1513befdf638.
This is mainly to avoid excessive linker parallelism:
- Reduce DefaultConcurrentLinks from phys/4GB to phys/5GB.
There are three gyp changes pulled in by this CL:
https://chromium.googlesource.com/external/gyp/+log/5122240c..6ee91ad8
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/1262693003
Cr-Commit-Position: refs/heads/master@{#343251}
Forward -isysroot flags to the clang completer.
This flag is used on Mac to identify where system headers are (and doesn't work for me without it).
Review URL: https://codereview.chromium.org/1291003002
Cr-Commit-Position: refs/heads/master@{#343250}
Remove debugging logs
Bug seems to be fixed, remove the logs used to debug it.
BUG=513130
Review URL: https://codereview.chromium.org/1290193002
Cr-Commit-Position: refs/heads/master@{#343249}
Remove now-meaningless Mark Non-Secure As Dubious flag.
Dubious is now presented as Neutral, so this flag does nothing.
Users can still opt in to marking non-secure as non-secure.
BUG=513863
Review URL: https://codereview.chromium.org/1273883002
Cr-Commit-Position: refs/heads/master@{#343248}
[Download Notification] Update notification as progress type on complete/cancel
We have had the code showing notification as progress type once before showing it as base type. But it didn't work due to a bug (see the comment in the review for detail). This patch fixes it and refactor the code to make the code clear.
BUG=518698
TEST=manually tested
Review URL: https://codereview.chromium.org/1279593003
Cr-Commit-Position: refs/heads/master@{#343247}
Componentize kExperimentLabelSeparator & BuildExperimentDateString.
Move kExperimentLabelSeparator & BuildExperimentDateString into
the variations components so that chrome/common/variations can be
componentized in a followup CL (in order to be shared with iOS).
BUG=520070
Review URL: https://codereview.chromium.org/1291763002
Cr-Commit-Position: refs/heads/master@{#343246}
[Android] Add a java.lang.System wrapper.
Add a basic JNI wrapper for java.lang.System. Expose just the
getProperty() method, eliminating a deprecated __system_property_get
usage as well as a seperate System.getProperty wrapper.
The remaining uses of __system_property_get will be removed in
https://codereview.chromium.org/1236283002/.
BUG=392196, 392191
Review URL: https://codereview.chromium.org/1283543003
Cr-Commit-Position: refs/heads/master@{#343245}
Roll third_party/custom_tabs_client.
BUG=516529
Review URL: https://codereview.chromium.org/1286423002
Cr-Commit-Position: refs/heads/master@{#343244}
Add text offset to OnSurroundingTextChanged.
See bug below for proposal doc.
BUG=518921
Review URL: https://codereview.chromium.org/1282823002
Cr-Commit-Position: refs/heads/master@{#343243}
chrome: Remove unnecessary c_str() calls.
This removes the entries found by the following command line:
$ g grep "c_str(" chrome/browser/ui/views
It is not necessary to call c_str() because those functions take
either std::string or base::string16, so the conversion to "const char *"
is pointless.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1288793005
Cr-Commit-Position: refs/heads/master@{#343242}
customtabs: Calling app background query for L MR1+.
In L MR1 and beyond, AM.getRunningAppProcesses() requires a permission
that we don't have (REAL_GET_TASKS) to return results for other
applications. It means that we refuse service requests to everybody in
this case.
This adds an alternative way to get the status of the calling process,
by querying which CPU cgroup the calling process belongs to. Android
uses two cgroups: "/" and "/bg_non_interactive" for background
processes. The cgroups membership can be read through /proc/<pid>/cgroup.
BUG=517527
TESTED=L MR1, user and userdebug devices
Review URL: https://codereview.chromium.org/1287583003
Cr-Commit-Position: refs/heads/master@{#343241}
Print stack traces in child processes when browser tests failed.
The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds.
BUG=517488,358267
Review URL: https://codereview.chromium.org/1291553003
Cr-Commit-Position: refs/heads/master@{#343240}
Roll src/third_party/skia e7d4b2f:9c80b5f
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e7d4b2f..9c80b5f
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
9c80b5f [email protected] Move GrRectBatch to GrBWFillRectBatch and make internal
d5b7563 [email protected] add SkImage::NewFromPicture and a GM to test it
Review URL: https://codereview.chromium.org/1295513002
Cr-Commit-Position: refs/heads/master@{#343239}
Fix warning of using uninitialized variable
TEST=media_unittests
BUG=509500
Review URL: https://codereview.chromium.org/1290443002
Cr-Commit-Position: refs/heads/master@{#343238}
[Android] Limit context menu title to 1024 characters
Recenly the context menu title was made scrollable. However, there are
cases where unreasonably long strings can be fed to the title, leading
to sluggish longpress response and even memory allocation issues.
Provide a reasonable upper bound of 1024 characters for the title.
BUG=516836
Review URL: https://codereview.chromium.org/1274373005
Cr-Commit-Position: refs/heads/master@{#343237}
Slow Reports: Added new category presets
R=dsinclair
BUG=
Review URL: https://codereview.chromium.org/1290833002
Cr-Commit-Position: refs/heads/master@{#343236}
Move chrome/browser/chromeos/drive/job*(.cc|.h) into components/drive.
Test steps:
1. Verify that things still build via GYP (and unit tests pass).
$ GYP_DEFINES="use_goma=1 gomadir=... chromeos=1" gclient sync
$ ninja -C out/Debug -j 150 chrome unit_tests \
interactive_ui_tests browser_tests drive
$ out/Debug/unit_tests
2. Verify that things still build via GN.
$ gn gen out/Default --args='target_os="chromeos" use_goma=true'
$ ninja -C out/Default -j 150 chrome unit_tests \
interactive_ui_tests browser_tests components/drive
TEST=Please see "Test steps" above.
[email protected],[email protected]
BUG=257943, 498951
Review URL: https://codereview.chromium.org/1289813004
Cr-Commit-Position: refs/heads/master@{#343235}
Fixed CRWWKWebControllerWebProcessTest for iOS9.
BUG=518924
Review URL: https://codereview.chromium.org/1290773005
Cr-Commit-Position: refs/heads/master@{#343234}
Test list for CrWinAsanCov tester
BUG=520114
[email protected]
Review URL: https://codereview.chromium.org/1288423002 .
Cr-Commit-Position: refs/heads/master@{#343233}
Add signals to make callback more reliable
Adds notifying the client on
pageLoadFailed: on security error and actual load fail
pageLoadAborted: on user starting new navigation while one is unfinished
tabVisible and tabHidden.
BUG=517894
Review URL: https://codereview.chromium.org/1292493002
Cr-Commit-Position: refs/heads/master@{#343232}
Revert of [Presentation API, Android] Implemented media sinks observers for Cast (patchset #3 id:40001 of https://codereview.chromium.org/1288083002/ )
Reason for revert:
This patch seems to have broke tests on the Android Tests dbg bot.
Both org.chromium.chrome.browser.media.router.ChromeMediaRouterTest#testStartObservingMediaSinks and org.chromium.chrome.browser.media.router.ChromeMediaRouterTest#testStopObservingMediaSinks failed.
Original issue's description:
> Extracts the corresponding Cast application id from the presentation URL
> and initiates background monitoring for compatible devices.
>
> BUG=517091
>
> Committed: https://crrev.com/15f1311aa79bd26bd01126a7646c290ab7107337
> Cr-Commit-Position: refs/heads/master@{#343204}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517091
Review URL: https://codereview.chromium.org/1289693004
Cr-Commit-Position: refs/heads/master@{#343231}
Add {,Non}TopHosts variants of Precache.Latency.
Add Precache.Latency.NonPrefetch.TopHosts, which records the latency
only for non-prefetch requests whose referer is in the top hosts, and
Precache.Latency.NonPrefetch.NonTopHosts, which records the latency for
the rest of the non-prefetch requests. This allows us to evaluate the
effect of precaching on latency only on those requests it has a chance
of improving. Thus, we can better distinguish the effectiveness of the
host selection algorithm from the effectiveness of the manifests.
This adds a HostRankIfAvailable method to HistoryService, in order to expose
the pre-computed TopHosts, as requiring that computation for every request
would be untenable.
This also adds a Control group, where TopHosts is computed for users, but no
resources are prefetched.
BUG=499532
Review URL: https://codereview.chromium.org/1280673004
Cr-Commit-Position: refs/heads/master@{#343230}
Vectorize tab audio/muting image for Views.
BUG=515183
Review URL: https://codereview.chromium.org/1282933003
Cr-Commit-Position: refs/heads/master@{#343229}
[Download Notification] Cache truncated filenames in download group notification
Truncating a filename is heavy operation so the result is worthy to cache.
BUG=512996
TEST=browser_tests passes
Review URL: https://codereview.chromium.org/1252153002
Cr-Commit-Position: refs/heads/master@{#343228}
Revert of QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in (patchset #1 id:1 of https://codereview.chromium.org/1281303002/ )
Reason for revert:
BUG=520301
Original issue's description:
> QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in
> QuicSentPacketManager::MaybeRetransmitTailLossProbe.
>
> BUG=517726
> [email protected]
>
> Committed: https://crrev.com/22f7d9ae62bb4867579032e3cae46dbb5720a8ff
> Cr-Commit-Position: refs/heads/master@{#342694}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517726
Review URL: https://codereview.chromium.org/1287363002
Cr-Commit-Position: refs/heads/master@{#343227}
Give action-links a default role of "link"
[email protected]
BUG=517598
Review URL: https://codereview.chromium.org/1272353006
Cr-Commit-Position: refs/heads/master@{#343226}
Moved undocumented WebKit constants from WC to a separate public header.
This way constants can be reused by a web embedder.
ios/public/provider/net/net_constants.h will be deleted once all clients
switched to use web_kit_constants.h.
BUG=517467
Review URL: https://codereview.chromium.org/1291083003
Cr-Commit-Position: refs/heads/master@{#343225}
[PresentationAPI] Update PresentationDispatcher to use availability URL.
This patch updates PresentationDispatcher to use the availability URL passed
with the observer from Blink to start/stop presentation display availability
listening.
It also removes the no-longer-needed API that passes the URL separately.
This is part 4 of a four-part patch and will land after #3 rolls.
1. [blink] https://codereview.chromium.org/1280713003
2. [content] https://codereview.chromium.org/1266923003
3. [blink] https://codereview.chromium.org/1274333004
4. [content] This patch.
BUG=510814
Committed: https://crrev.com/0033065242a9e2bdd5047196423a25000abf266b
Cr-Commit-Position: refs/heads/master@{#343206}
Review URL: https://codereview.chromium.org/1287043006
Cr-Commit-Position: refs/heads/master@{#343224}
flip_server: Include create_listener.h where needed only.
Only the source files are make using of the functions from this header,
and thus we don't need to include it from the header files.
Also remove a left-behind iosfwd include from create_listener.h.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1288813002
Cr-Commit-Position: refs/heads/master@{#343223}
Remove --disable-text-blobs flag.
This feature has been on for months, so we no longer need a disabling switch.
BUG=377845
Review URL: https://codereview.chromium.org/1284213004
Cr-Commit-Position: refs/heads/master@{#343222}
[Android] Fix partner bookmarks editing bugs.
- Partner bookmark URL is not editable, but in editing dialog, user
could attempt to change.
- Partner bookmarks and folders are not movable, but in editing dialog,
user could attempt to change the parent folder.
- For partner bookmarks, the three-dot menu's edit was disabled
incorrectly instead of move.
- Deleting a partner bookmark inside edit activity didn't work because
partner bookmark delete only notifies bookmarkModelChanged() and we
weren't listening to dismiss the dialog.
BUG=517940
Review URL: https://codereview.chromium.org/1285243003
Cr-Commit-Position: refs/heads/master@{#343221}
Whitelist the cloud debugger chrome app to use the feedback API.
[email protected]
BUG=516527
Review URL: https://codereview.chromium.org/1286553002
Cr-Commit-Position: refs/heads/master@{#343220}
Revert of [Android] Remove android_commands and android_testrunner. (patchset #3 id:40001 of https://codereview.chromium.org/1290773009/ )
Reason for revert:
This seems to have broken the Google Chrome Linux x64 build
Output:
FAILED: cd ../../content; python ../tools/isolate_driver.py check --isolated "../out/Release/telemetry_gpu_unittests.isolated" --isolate "telemetry_gpu_unittests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Release " --extra-variable "version_full=46.0.2482.0" --config-variable "CONFIGURATION_NAME=Release" --config-variable "OS=linux" --config-variable "asan=0" --config-variable "branding=Chrome" --config-variable "chromeos=0" --config-variable "component=static_library" --config-variable "disable_nacl=0" --config-variable "enable_pepper_cdms=1" --config-variable "enable_plugins=1" --config-variable "fastbuild=0" --config-variable "icu_use_data_file_flag=1" --config-variable "internal_gles2_conform_tests=0" --config-variable "kasko=0" --config-variable "libpeer_target_type=static_library" --config-variable "lsan=0" --config-variable "msan=0" --config-variable "target_arch=x64" --config-variable "tsan=0" --config-variable "use_custom_libcxx=0" --config-variable "use_instrumented_libraries=0" --config-variable "use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=1" --config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable "v8_use_external_startup_data=1"
Failed to find an input file: /b/build/slave/google-chrome-rel-linux_64/build/src/third_party/android_testrunner/ is not a directory but ends with "/"
Original issue's description:
> [Android] Remove android_commands and android_testrunner.
>
> Good riddance.
>
> BUG=267773
>
> Committed: https://crrev.com/d71baced2e55f9f102189c490908e3c631a790e2
> Cr-Commit-Position: refs/heads/master@{#343210}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=267773
Review URL: https://codereview.chromium.org/1288993002
Cr-Commit-Position: refs/heads/master@{#343219}
Lo-Fi finch config
BUG=470596
Review URL: https://codereview.chromium.org/1295473002
Cr-Commit-Position: refs/heads/master@{#343218}
Fix 2 ChromeVox next tests that passed without actually running.
The way to create callbacks for async functions in these e2e tests is to
invoke this.newCallback(). See https://codereview.chromium.org/938623003
for more background. If this is not done, the tests will pass silently
before the asyc callbacks get called which means much of the tests don't
run.
This CL fixes two of the tests and marks the rest with TODOs because
they fail and need more debugging when this problem is fixed.
The live region tests are fixed by making paragraph nodes output their descendants
instead of their value property.
BUG=None
Review URL: https://codereview.chromium.org/1288043002
Cr-Commit-Position: refs/heads/master@{#343217}
StoreResultFilter should be able to filter a vector of password forms
Currently it only takes one form after another. For that it needs to keep state between calls for statistics. This CL changes it to processing a vector of forms, and reporting immediately after that, getting rid of the additional state.
Side-effects:
* gets rid of signed int used for bit masking in PasswordFormManager
* removes some private member access to PasswordFormManager from PasswordFormManagerTest
* splits a big test into 3 logical sub-tests
This is a preparation for creating a service in the sync layer.
[email protected]
BUG=515108, 474577, 514230
Review URL: https://codereview.chromium.org/1278963003
Cr-Commit-Position: refs/heads/master@{#343216}
Change ownership of BackgroundSyncServiceImpl to BackgroundSyncContextImpl
Previously BackgroundSyncServiceImpl was deleted by mojo very late on
shutdown (on messageloop destruction). This is way too late. Instead, let the BackgroundSyncContextImpl own them.
BUG=517122
Review URL: https://codereview.chromium.org/1283703003
Cr-Commit-Position: refs/heads/master@{#343215}
Implement AwContentBrowserClient::IsHandledURL
Implemented similarly to ChromeContentBrowserClient. The only trick is that 'false' is still returned for "special" Android file URLs (file:///android_asset/* and file:///android_res/) that should work even if file access is disabled. By returning 'false' from IsHandledURL we bypass the scheme check in ChildProcessSecurityPolicy.
Access to 'file:' scheme is granted to child processes after the first call to WebView.loadDataWithBaseUrl with non-data: base URL.
Access to 'content:' scheme is always granted, as access to it is enabled by default in WebSettings.
BUG=516546
Review URL: https://codereview.chromium.org/1275163004
Cr-Commit-Position: refs/heads/master@{#343214}
Roll src/third_party/skia c8d3f57:e7d4b2f
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c8d3f57..e7d4b2f
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
e7d4b2f [email protected] Simplify parameters passed to path renderers
15f4951 [email protected] add asserts on Sk4px::Map functions that our arrays are non-null.
272b748 [email protected] Minor fix to not save the modeling space rect
2d56303 [email protected] Move willColorBlendWithDst from pipeline builder to GrPipelineOptimizations.
7ef45a1 [email protected] Added mangleString member and onBefore*, onAfter* functions to GrGLFragmentShaderBuilder
Review URL: https://codereview.chromium.org/1295463002
Cr-Commit-Position: refs/heads/master@{#343213}
Clear the selection and insertion flags only upon getting the selection event
The mHasSelection and mHasInsertion flags are being cleared even before the
selection events are received and hence the popup is never hidden.
dismissTextHandles already triggers the selection events to clear the handles.
Hence we dont need to clear them outside the selection event handler.
BUG=520060
Review URL: https://codereview.chromium.org/1283193002
Cr-Commit-Position: refs/heads/master@{#343212}
Revert of [PresentationAPI] Update PresentationDispatcher to use availability URL. (patchset #1 id:1 of https://codereview.chromium.org/1287043006/ )
Reason for revert:
Speculative revert due to failure of linux_arm Compile on the waterfall.
http://build.chromium.org/p/chromium.linux/builders/Linux%20ARM/builds/2277/steps/compile/logs/stdio
[715/4680] RULE yasm genperf for source/patched-yasm/modules/arch/x86/x86regtmod.gperf
FAILED: cd ../../third_party/yasm; ../../out/Release/genversion ../../out/Release/gen/third_party/yasm/version.mac
../../out/Release/genversion: 1: ../../out/Release/genversion: Syntax error: word unexpected (expecting ")")
FAILED: cd ../../third_party/yasm; ../../out/Release/genperf "source/patched-yasm/modules/arch/x86/x86cpu.gperf" "../../out/Release/gen/third_party/yasm/x86cpu.c"
../../out/Release/genperf: 1: ../../out/Release/genperf: Syntax error: word unexpected (expecting ")")
FAILED: cd ../../third_party/yasm; ../../out/Release/genperf "source/patched-yasm/modules/arch/x86/x86regtmod.gperf" "../../out/Release/gen/third_party/yasm/x86regtmod.c"
../../out/Release/genperf: 1: ../../out/Release/genperf: Syntax error: word unexpected (expecting ")")
FAILED: cd ../../ppapi/native_client; python ../../native_client/build/build_nexe.py --root ../.. --product-dir ../../out/Release/xyz --config-name Release -t ../../native_client/toolchain/ --strip-all --arch arm --build newlib_nexe --name ../../out/Release/nacl_irt_arm.nexe --objdir ../../out/Release/obj/ppapi/native_client/nacl_irt.gen/irt-arm/nacl_irt "--include-dirs=../../out/Release/gen/tc_newlib/include ../.. .. \"../../out/Release/gen\" ../../third_party/khronos ../../gpu ../.." "--compile_flags=-Wno-unused-local-typedefs -Wno-psabi -ffunction-sections -fdata-sections -fomit-frame-pointer -fasynchronous-unwind-tables -O2 -g -Wall -fdiagnostics-show-option -Werror " --gomadir /b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_DEFAULT_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=arm\" V8_DEPRECATION_WARNINGS \"CLD_VERSION=2\" \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=242792-1\" UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"USE_CLIPBOARD_AURAX11=1\" ENABLE_ONE_CLICK_SIGNIN ENABLE_PRE_SYNC_BACKUP \"ENABLE_WEBRTC=1\" \"ENABLE_MEDIA_ROUTER=1\" ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" \"ENABLE_TOPCHROME_MD=1\" USE_UDEV DONT_EMBED_BUILD_METADATA FIELDTRIAL_TESTING_ENABLED \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"ENABLE_PRINTING=1\" \"ENABLE_BASIC_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL SAFE_BROWSING_SERVICE __ARMEL__ __arm__ NVALGRIND \"USE_LIBPCI=1\" \"USE_OPENSSL=1\" \"USE_GLIB=1\" \"USE_NSS_CERTS=1\"" "--link_flags=-B../../out/Release/gen/tc_irt/libarm -Wl,--gc-sections -Wl,--start-group -lirt_browser -lpnacl_irt_shim_for_irt -lppapi_proxy_nacl -lppapi_ipc_nacl -lppapi_shared_nacl -lgles2_implementation_nacl -lgles2_cmd_helper_nacl -lgles2_utils_nacl -lcommand_buffer_client_nacl -lcommand_buffer_common_nacl -ltracing_nacl -lgpu_ipc_nacl -lipc_nacl -lbase_nacl -lshared_memory_support_nacl -lsrpc -limc_syscalls -lplatform -lgio -Wl,--end-group -lm " "--source-list=../../out/gypfiles/ppapi/native_client/irt-arm.nacl_irt.source_list.gypcmd" "--tls-edit=../../out/Release/tls_edit" "--irt-linker=../../native_client/build/link_irt.py"
Traceback (most recent call last):
File "../../native_client/build/link_irt.py", line 236, in <module>
sys.exit(Main())
File "../../native_client/build/link_irt.py", line 229, in Main
linker.Link(remaining_args)
File "../../native_client/build/link_irt.py", line 163, in Link
tls_edit_err = self.Run(tls_edit_cmd, possibly_script=False)
File "/b/build/slave/Linux_ARM/build/src/native_client/build/build_nexe_tools.py", line 137, in Run
raise Error('%s\nFAILED: %s' % (' '.join(cmd_line), str(err)))
build_nexe_tools.Error: /b/build/slave/Linux_ARM/build/src/out/Release/tls_edit ../../out/Release/nacl_irt_arm.nexe.debug.raw ../../out/Release/nacl_irt_arm.nexe.debug
FAILED: [Errno 8] Exec format error
Original issue's description:
> [PresentationAPI] Update PresentationDispatcher to use availability URL.
>
> This patch updates PresentationDispatcher to use the availability URL passed
> with the observer from Blink to start/stop presentation display availability
> listening.
>
> It also removes the no-longer-needed API that passes the URL separately.
>
> This is part 4 of a four-part patch and will land after #3 rolls.
>
> 1. [blink] https://codereview.chromium.org/1280713003
> 2. [content] https://codereview.chromium.org/1266923003
> 3. [blink] https://codereview.chromium.org/1274333004
> 4. [content] This patch.
>
> BUG=510814
>
> Committed: https://crrev.com/0033065242a9e2bdd5047196423a25000abf266b
> Cr-Commit-Position: refs/heads/master@{#343206}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510814
Review URL: https://codereview.chromium.org/1290813005
Cr-Commit-Position: refs/heads/master@{#343211}
[Android] Remove android_commands and android_testrunner.
Good riddance.
BUG=267773
Review URL: https://codereview.chromium.org/1290773009
Cr-Commit-Position: refs/heads/master@{#343210}
[AltSvc] Save expiration as int64 string instead of double.
Save alternative service expiration times as int64 in a string instead of
double in HttpServerPropertiesManager::SaveAlternativeServiceToServerPrefs(),
and load expiration time accordingly in
HttpServerPropertiesManager::ParseAlternativeServiceDict(). The reason is that
numeric_limits<int64>::max() can be serialized in JSON, whereas
numeric_limits<double>::max() cannot. That is, this change allows
base::Time::Max() expiration times. Note that JSON does not support int64, so
it has to be converted into a string.
This change might result in unexpected behavior on user installations where
alternative services were persisted to disk as double with earlier versions.
However, as https://crrev.com/1227063002 has not even made it to Beta yet,
this can be safely ignored.
BUG=516034
Review URL: https://codereview.chromium.org/1275663002
Cr-Commit-Position: refs/heads/master@{#343209}
[Android] Ensure popups hidden when ContentViewCore destroyed
Selection-related popups rely on objects (PopupWindows) that may outlive
the ContentViewCore. Prevent actions on such popups after the
ContentViewCore is destroyed by always explicitly hiding and dismissing
them upon ContentViewCore destruction.
BUG=520286
Review URL: https://codereview.chromium.org/1285333003
Cr-Commit-Position: refs/heads/master@{#343208}
Roll src/third_party/WebKit f0650b2:e61622f (svn 200476:200478)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f0650b2..e61622f
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288943002
Cr-Commit-Position: refs/heads/master@{#343207}
[PresentationAPI] Update PresentationDispatcher to use availability URL.
This patch updates PresentationDispatcher to use the availability URL passed
with the observer from Blink to start/stop presentation display availability
listening.
It also removes the no-longer-needed API that passes the URL separately.
This is part 4 of a four-part patch and will land after #3 rolls.
1. [blink] https://codereview.chromium.org/1280713003
2. [content] https://codereview.chromium.org/1266923003
3. [blink] https://codereview.chromium.org/1274333004
4. [content] This patch.
BUG=510814
Review URL: https://codereview.chromium.org/1287043006
Cr-Commit-Position: refs/heads/master@{#343206}
Add UMA and Rappor metrics to capture URLs passed in at startup.
BUG=520098
Review URL: https://codereview.chromium.org/1283243002
Cr-Commit-Position: refs/heads/master@{#343205}
Extracts the corresponding Cast application id from the presentation URL
and initiates background monitoring for compatible devices.
BUG=517091
Review URL: https://codereview.chromium.org/1288083002
Cr-Commit-Position: refs/heads/master@{#343204}
Remove obsolete strings and files for Password Manager.
BUG=503614
Review URL: https://codereview.chromium.org/1292563002
Cr-Commit-Position: refs/heads/master@{#343203}
Disable DeclarativeContentApiTest.RemoveAllRulesAfterExtensionUninstall on Windows
This test is repeatly failing on Windows XP.
BUG=515717
[email protected]
Review URL: https://codereview.chromium.org/1292063005
Cr-Commit-Position: refs/heads/master@{#343202}
[Cronet] Add detail in exception message for duplicate header
Inform caller of the name of the duplicate header in the
exception message.
BUG=432719
Review URL: https://codereview.chromium.org/1284373002
Cr-Commit-Position: refs/heads/master@{#343201}
Disable flaky telemetry.internal.backends.chrome_inspector.tracing_backend_unittest.TracingBackendMemoryTest.testDumpMemorySuccess
BUG=499731
[email protected]
Review URL: https://codereview.chromium.org/1291533003
Cr-Commit-Position: refs/heads/master@{#343200}
Fill only the password field on "no username" credentials in PasswordManager when there is no other credentials stored.
BUG=359315
Review URL: https://codereview.chromium.org/1288343002
Cr-Commit-Position: refs/heads/master@{#343199}
Remove Win8+ condition from HandleOsUpgradeForBrowser().
HandleOsUpgradeForBrowser() used to be only about installing Metro assets.
It's now a lot more about making sure Chrome is properly installed on any
new Windows OS without having to wait for an explicit auto-update to fix things.
BUG=None
Review URL: https://codereview.chromium.org/1277003003
Cr-Commit-Position: refs/heads/master@{#343198}
[mac] Fix unittests on 10.11 that rely on window ordering
In El Capitan, communication with the WindowServer is not immediately
reflected within +[NSApp orderedWindows] and variants as it seems to
be in previous versions of the OS. Let the runloop spin in cases where
window ordering is checked immediately after calls that change it (like
-[NSWindow makeKeyAndOrderFront]).
Affected tests: PanelCocoaTest.ActivatePanel, BrowserWindowFullScreenControllerTest.TestActivate, AppControllerPlatformAppBrowserTest.ActivationFocusesBrowserWindow, WindowAppleScriptTest.WindowOrder, BrowserCrApplicationAppleScriptTest.InsertWindow
BUG=518983
Review URL: https://codereview.chromium.org/1288793004
Cr-Commit-Position: refs/heads/master@{#343197}
Darked the text of user name and email in the profile dialog.
The color of the text is changed from #b4b4b4 to #757575, which sits on a white background.
BUG=519580
Review URL: https://codereview.chromium.org/1287083002
Cr-Commit-Position: refs/heads/master@{#343196}
Roll src/third_party/skia 6e83ac7:c8d3f57
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6e83ac7..c8d3f57
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
c8d3f57 [email protected] Fail early in GrPipeline::CreateAt() if XP creation fails
Review URL: https://codereview.chromium.org/1288003003
Cr-Commit-Position: refs/heads/master@{#343195}
Revert of [scheduler]: Fix a bug with non-nestable tasks. (patchset #2 id:20001 of https://codereview.chromium.org/1287003003/ )
Reason for revert:
Causing crashes on Mac.
BUG=520524
Original issue's description:
> [scheduler]: Fix a bug with non-nestable tasks.
>
> Avoids a DCHECK in TaskQueueImpl::Task::enqueue_order() caused by
> TaskIsOlderThanQueuedTasks being called on an empty task if the previous
> task was a non-nestable task while the scheduler is running on a nested
> message loop.
>
> Committed: https://crrev.com/c0d31ab28e21c048f40584ace3b0a8aca5723c17
> Cr-Commit-Position: refs/heads/master@{#343026}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1287333002
Cr-Commit-Position: refs/heads/master@{#343194}
Roll src/third_party/WebKit 9c8a589:f0650b2 (svn 200475:200476)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9c8a589..f0650b2
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287313002
Cr-Commit-Position: refs/heads/master@{#343193}
Mandoline: move TextInputType converter to blink_text_input_type_converters.*
BUG=498624
Review URL: https://codereview.chromium.org/1288133002
Cr-Commit-Position: refs/heads/master@{#343192}
Restore potentially missing Active Setup keys following an OS upgrade.
Without this change the latest changes to trigger Active Setup on
update to system-level Chromes fail.
Also cleanup some documentation to be more accurate.
BUG=488247
TEST=
1) Install setup.exe --chrome --multi-install --system-level
2) Delete HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Active Setup\Installed Components\{8A69D345-D564-463c-AFF1-A69D9E530F96}
3) As admin, run the command @ HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Google\Update\Clients\{8A69D345-D564-463c-AFF1-A69D9E530F96}\Commands\on-os-upgrade
4) Verify that it restored the key in (2.) and bumped the OS upgrade component (i.e. 43.0.1.0).
Review URL: https://codereview.chromium.org/1274043002
Cr-Commit-Position: refs/heads/master@{#343191}
FillAutofillableLogins and FillBlacklistLogins should remove the duplicate entries on Linux.
These functions are called by Sync. Removing the passwords with identical sync tags should fix the Sync error.
BUG=489766
Review URL: https://codereview.chromium.org/1288663002
Cr-Commit-Position: refs/heads/master@{#343190}
Add hash to OFC pasteboard change detection
Due to a bug in iOS SDK, the change count is not enough to detect
pasteboard change after a reboot.
BUG=510364
Review URL: https://codereview.chromium.org/1288733002
Cr-Commit-Position: refs/heads/master@{#343189}
Remove the array of Provider Names and Provider Source and replace with a map.
Provider Names and Provider Source are in the form of seprate array.
map usage will make it better readability and maintainability.
BUG= 520352
Review URL: https://codereview.chromium.org/1287943006
Cr-Commit-Position: refs/heads/master@{#343188}
Roll src/third_party/skia cc1229c:6e83ac7
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cc1229c..6e83ac7
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
6e83ac7 [email protected] Defer flushes if kPreferNoIO is specified
Review URL: https://codereview.chromium.org/1288913002
Cr-Commit-Position: refs/heads/master@{#343187}
Roll src/third_party/WebKit fd474c6:9c8a589 (svn 200474:200475)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fd474c6..9c8a589
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288353002
Cr-Commit-Position: refs/heads/master@{#343186}
Change the HSTS preload entry for carbonmade.com to include_subdomains: false.
BUG=518717
[email protected]
Review URL: https://codereview.chromium.org/1289923004
Cr-Commit-Position: refs/heads/master@{#343185}
Remove unused IDS_HISTORY_(UN)LOCK_BUTTON strings.
This was missed in https://chromiumcodereview.appspot.com/15415006
BUG=241383
Review URL: https://codereview.chromium.org/1293483002
Cr-Commit-Position: refs/heads/master@{#343184}
More verbose logging on Active Setup uninstall steps.
BUG=518014
Review URL: https://codereview.chromium.org/1281063002
Cr-Commit-Position: refs/heads/master@{#343183}
Remove helper methods no longer needed after https://codereview.chromium.org/1275023005/
Removing them in a separate CL to make that one a smaller merge.
BUG=502363
Review URL: https://codereview.chromium.org/1278883003
Cr-Commit-Position: refs/heads/master@{#343182}
Roll src/third_party/WebKit 9f61c9f:fd474c6 (svn 200472:200474)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9f61c9f..fd474c6
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290803004
Cr-Commit-Position: refs/heads/master@{#343181}
Chromevox next: support braille routing keys.
This adds routing support for doing the default action on any node
and setting the selection in text fields. Multiline text fields and
contentEditable needs more work which I leave for another CL.
BUG=491242
[email protected]
Review URL: https://codereview.chromium.org/1273873003
Cr-Commit-Position: refs/heads/master@{#343180}
Do not force restore shortcuts on OS upgrades.
And update some documentation.
Related helper method to be cleaned in a follow-up CL.
BUG=502363
Review URL: https://codereview.chromium.org/1275023005
Cr-Commit-Position: refs/heads/master@{#343179}
Refactoring ash::SystemTrayDelegate: extracting Clock-related stuff.
SystemTrayDelegate has become a bit of a dumping ground. This CL moves all
Clock-related stuff from systemTrayDelegateChromeOS to new object
chromeos::system::SystemClock .
BUG=513120
TEST=manual
Review URL: https://codereview.chromium.org/1261903005
Cr-Commit-Position: refs/heads/master@{#343178}
Update V8 to version 4.6.71.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/15efd247..0dfdcdc5
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287263002
Cr-Commit-Position: refs/heads/master@{#343177}
Expose Mirror request header builder.
This CL exposes the Mirror request header builder, which is needed
for platforms (e.g iOS's WKWebView) that needs to use the
X-CHROME-CONNECTED cookie instead of the X-Chrome-Connected header.
BUG=513650
Review URL: https://codereview.chromium.org/1288033003
Cr-Commit-Position: refs/heads/master@{#343176}
Roll src/third_party/WebKit 0811bd9:9f61c9f (svn 200468:200472)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0811bd9..9f61c9f
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292003002
Cr-Commit-Position: refs/heads/master@{#343175}
Files.app: Hide status column when Drive volume is disabled or in dialog mode.
BUG=483075
TEST=manually tested
Review URL: https://codereview.chromium.org/1291993002
Cr-Commit-Position: refs/heads/master@{#343174}
Add helper function to share code between //ios and //chrome.
Both implementation of AutocompleteProviderClient used the same code
for HasTabSyncEnabledAndUnencrypted() which is kind of sad. Instead
introduce an helper function to share the code.
BUG=519555
Review URL: https://codereview.chromium.org/1289793002
Cr-Commit-Position: refs/heads/master@{#343173}
command_buffer: Use GLSL core version that matches the OpenGL version
Use GLSL core version that matches OpenGL version as specified in the
corresponding OpenGL specification.
This makes it simpler to support GL extensions that depend on specific
GLSL feature and are specified to be supported on contexts implementing
the GLSL language version.
Using the specified version as opposed to a hand-picked specific version
should minimize the kind of regressions caused by forcing a specific
core GLSL version in the past.
The idea is that when implementing a client-side feature that requires
a specific service-side GLSL feature, the feature_info can just check
the corresponding GL context version. Typically context version of an
extension is selected so that GLSL features match.
Needed in implementing EXT_blend_func_extended in the client. The
service side will be implemented with ARB_blend_func_extended, which
uses custom outputs. Using compatibility output from ANGLE would result
in gl_ built-ins as well as custom outputs, which is not allowed.
BUG=471960
Review URL: https://codereview.chromium.org/1273693002
Cr-Commit-Position: refs/heads/master@{#343172}
Use default verbatim relevance in ClipboardURLProvider.
VerbatimMatchForURL() only uses the default verbatim relevance if
|verbatim_relevance| is negative, so pass -1 instead of 0 for the
|verbatim_relevance|.
BUG=517017
Review URL: https://codereview.chromium.org/1290673003
Cr-Commit-Position: refs/heads/master@{#343171}
Add a info flag set when certs fails to conform to the CT policy.
This is useful for clients that only wants to show CT
info if the certificate is not CT compliant.
BUG=None
Review URL: https://codereview.chromium.org/1287023003
Cr-Commit-Position: refs/heads/master@{#343170}
Android: Add a TraceEvent for ChromeLauncherActivity.onCreate().
This TraceEvent is useful to identify the point at which Chrome starts
executing its own code in startup traces. Note that this will not work
for cold startup, as in this case the native library is not initialized
at this point.
Review URL: https://codereview.chromium.org/1240563004
Cr-Commit-Position: refs/heads/master@{#343169}
Roll src/third_party/WebKit cf6feb8:0811bd9 (svn 200463:200468)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cf6feb8..0811bd9
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287213002
Cr-Commit-Position: refs/heads/master@{#343168}
Use blink::WebDisplayMode in content::Manifest instead of own type
BUG=471703
Review URL: https://codereview.chromium.org/1283653003
Cr-Commit-Position: refs/heads/master@{#343167}
Remove the experimental network configuration extension.
This extension was used during the initial implementation of
the networkingPrivate API but development of it wasn't continued.
Time to remove it.
BUG=520392
Review URL: https://codereview.chromium.org/1282253002
Cr-Commit-Position: refs/heads/master@{#343166}
Roll src/third_party/WebKit b07f2e4:cf6feb8 (svn 200462:200463)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b07f2e4..cf6feb8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290983002
Cr-Commit-Position: refs/heads/master@{#343165}
Remove associated_username() and realm() in PasswordFormManager. Update callsites to use pending_credentials() instead.
BUG=517964
Review URL: https://codereview.chromium.org/1286243002
Cr-Commit-Position: refs/heads/master@{#343164}
Gallery: fix underline style of rename field.
BUG=516468
TEST=none
Review URL: https://codereview.chromium.org/1290993002
Cr-Commit-Position: refs/heads/master@{#343163}
Automated Commit: Committing new LKGM version 7357.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#343162}
Roll src/third_party/WebKit 8bf0afa:b07f2e4 (svn 200451:200462)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8bf0afa..b07f2e4
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1292483002
Cr-Commit-Position: refs/heads/master@{#343161}
Roll src/third_party/WebKit 0e6a5a3:8bf0afa (svn 200444:200451)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0e6a5a3..8bf0afa
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288563003
Cr-Commit-Position: refs/heads/master@{#343160}
Fix closure compile error.
https://codereview.chromium.org/1279423004/ broke the closure compilation.
BUG=run closure compiler
[email protected]
Review URL: https://codereview.chromium.org/1285233003
Cr-Commit-Position: refs/heads/master@{#343159}
Roll src/third_party/skia 58d890b:cc1229c
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/58d890b..cc1229c
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
cc1229c [email protected] Revert "Revert[4] "move some public headers into private""
0010945 [email protected] Revert of Normalize SkXfermode_opts.h argument order as d,s[,aa]. (patchset #1 id:1 of https://codereview.chromium.org/1289903002/ )
72440a3 [email protected] Use forwarding with SkTLazy::init.
65bd7ae [email protected] Add gyp support for new GPU backend
9bc3954 [email protected] Refactor helper function for SkBitmapShader to GrFragmentProcessor
33e00db [email protected] Revert[4] "move some public headers into private"
27801bf [email protected] broken bots war
a50e17a [email protected] Add support for a new GPU interface
082e329 [email protected] Revert of Refactor to put SkXfermode_opts inside SK_OPTS_NS. (patchset #1 id:1 of https://codereview.chromium.org/1286093004/ )
147dc06 [email protected] Add GrAARectBatch which can handle a local matrix
c3021ed [email protected] Add override to GrAAFillRectBatch::onCombineIfPossible
d9e5715 [email protected] SkPDF: Move SkFlate into src/pdf (part 1/3) [reland]
cb02b38 [email protected] Check for xfer barriers in GrBatch, auto-issue barriers in GrGpu
6028a84 [email protected] Normalize SkXfermode_opts.h argument order as d,s[,aa].
b07bee3 [email protected] Refactor to put SkXfermode_opts inside SK_OPTS_NS.
Review URL: https://codereview.chromium.org/1288253002
Cr-Commit-Position: refs/heads/master@{#343158}
Remove captive portal check from oauth2 token fetcher.
BUG=501179
Review URL: https://codereview.chromium.org/1290943002
Cr-Commit-Position: refs/heads/master@{#343157}
Updating trunk VERSION from 2481.0 to 2482.0
Cr-Commit-Position: refs/heads/master@{#343156}
Implement LayerTypeAsString for solid color scrollbar layer.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1286103002
Cr-Commit-Position: refs/heads/master@{#343155}
Adding first performance measurement test to Chromoting Waterfall.
After running about 500 simulations on a swarming bot, I found that the time to authenticate and time between authenticated and connected on the Chromoting Waterfall does not exceed more than 1000 ms each (max for each is 671 ms and 646 ms, respectively). Having a 2000 ms threshold for both measurements is more than enough time to authenticate and connect.
Both Sergey and Anand have checked off on these thresholds to determine whether or not we have a bug.
BUG=
Review URL: https://codereview.chromium.org/1291533002
Cr-Commit-Position: refs/heads/master@{#343154}
Files.app: Add analytics exception event for mount errors.
If mounting a volume fails, an exception will be sent to analytics in the following form.
"mount {errorType} {volumeType}"
errorType will be one of followings:
- timoout(requestFileSystem)
- timeout(resolveIsolatedEntries)
- error
volumeType will be one of followings:
- drive
- downloads
- removable
- mtp
- provided:unknown
- provided:ZipUnpacker
- provided:File System for Dropbox (YT)
- provided:File System for OneDrive (YT)
- provided:SFTP File System (YT)
- provided:Box for Chrome OS
- provided:TED Talks (FB)
- provided:WebDAV File System (YT)
- provided:Cloud Storage (FB)
- provided:Scan (FB)
BUG=511286
TEST=manually test that exceptions are reported to analytics by forcing Files.app to fail to mount volumes.
Review URL: https://codereview.chromium.org/1279423004
Cr-Commit-Position: refs/heads/master@{#343153}
Update V8 to version 4.6.70.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/da355b08..15efd247
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287033007
Cr-Commit-Position: refs/heads/master@{#343152}
Add win8 and win10 recipe configurations for chromium.webkit.
BUG=496259
Review URL: https://codereview.chromium.org/1284333003
Cr-Commit-Position: refs/heads/master@{#343151}
Roll src/third_party/WebKit 3d153a0:0e6a5a3 (svn 200439:200444)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d153a0..0e6a5a3
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286333002
Cr-Commit-Position: refs/heads/master@{#343150}
[refactor] Extract some test helpers for certificate verification unittests.
These functions are re-used further in upcoming changelists.
BUG=410574
Review URL: https://codereview.chromium.org/1290553002
Cr-Commit-Position: refs/heads/master@{#343149}
Remove unused "nosdcard" variants of several strings.
We have several strings with two variants: default and nosdcard. At
build time, grit dutifully converts these strings into Android resources
like so:
<message name="IDS_FOO_product_nosdcard">You have no SD card</message>
<message name="IDS_FOO_product_default">You do have an SD card</message>
becomes
<string name="foo" product="nosdcard">You have no SD card</string>
<string name="foo" product="default">You do have an SD card</string>
However, aapt includes only one variant of the string in the APK,
according to the value of the --product flag. Since we don't pass the
--product flag to aapt, only the default strings get included in the
APK. Hence the nosdcard variants are and have always been unused.
Review URL: https://codereview.chromium.org/1288243002
Cr-Commit-Position: refs/heads/master@{#343148}
bluetooth: Add histograms and logging for getPrimaryService()
Three new histograms:
- GetPrimaryService.Services: Record UUID of the service passed
- GetprimaryService.Time: Record time it took to discover all of the device's services
- GetPrimaryService.Outcome: Record outcome of the getPrimaryService() call
Log:
- If a device is no longer present
- If no services match the UUID passed
BUG=499636
Review URL: https://codereview.chromium.org/1271043002
Cr-Commit-Position: refs/heads/master@{#343147}
Make Type an unmanaged ONC property
This will simplify some of the new Settings UI, allowing us
to read onc.Type directly without parsing a managed dictionary.
BUG=none
Review URL: https://codereview.chromium.org/1284963002
Cr-Commit-Position: refs/heads/master@{#343146}
Updates SpellcheckWordIterator::GetNextWord to return an enum.
GetNextWord should return an enum so we can determine if the iterator
has found chracters that the spellchecker can skip over.
BUG=5102
Review URL: https://codereview.chromium.org/1269343005
Cr-Commit-Position: refs/heads/master@{#343145}
Fix Site Isolation tests.
The SingleProcessTracingBrowserTest.TestMemoryInfra is supposed to test
memory-infra for single process mode. So, running this test with
--site-per-process flag does not make sense. So, disabling the test for
this bot.
[email protected]
BUG=462848
Review URL: https://codereview.chromium.org/1289983004
Cr-Commit-Position: refs/heads/master@{#343144}
Revert of add ConvertYUVAToARGBRow_MMX to media_perftests (patchset #3 id:40001 of https://codereview.chromium.org/1286913002/ )
Reason for revert:
This broke the build:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GN%20Clobber&number=3951
missing libyuv/basic_types.h
Original issue's description:
> Add YUVConvertPerfTest.ConvertYUVAToARGBRow_MMX and YUVConvertPerfTest.I422ToARGBRow_SSSE3 to media_perftests.
> Fix math error when printing results by clearing the MMX state before doing float math.
> BUG=libyuv:473
>
> Committed: https://crrev.com/98e918a3abdfcc2eaae3df9cc3dd9f8225f39edc
> Cr-Commit-Position: refs/heads/master@{#343140}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=libyuv:473
Review URL: https://codereview.chromium.org/1288223003
Cr-Commit-Position: refs/heads/master@{#343143}
bluetooth: Add histograms and logging for connectGATT
Three new histograms:
- ConnectGATT.Outcome: result of connectGATT() call.
- ConnectGATT.TimeFailed: time it takes to fail to connect to a device
- ConnectGATT.TimeSuccess: time it takes to successfully connect to a device
BUG=499636
Review URL: https://codereview.chromium.org/1270603010
Cr-Commit-Position: refs/heads/master@{#343142}
Roll src/third_party/WebKit b4083b2:3d153a0 (svn 200426:200439)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b4083b2..3d153a0
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1283153008
Cr-Commit-Position: refs/heads/master@{#343141}
Add YUVConvertPerfTest.ConvertYUVAToARGBRow_MMX and YUVConvertPerfTest.I422ToARGBRow_SSSE3 to media_perftests.
Fix math error when printing results by clearing the MMX state before doing float math.
BUG=libyuv:473
Review URL: https://codereview.chromium.org/1286913002
Cr-Commit-Position: refs/heads/master@{#343140}
bluetooth: Add histograms and logging for requestDevice()
Four new histograms:
- RequestDevice.Filters.Count: Number of filters used when scanning
- RequestDevice.Filters.Services: Services used when scanning
- RequestDevice.OptionalServices.Count: Number of optionalServices passed.
- RequestDevice.OptionalServices.Services: Optional services
- RequestDevice.UnionOfServices.Count: Number of services used.
- RequestDevice.FilterSize: Number of services in a filter.
One Rename:
Bluetooth.RequestDevice.Outcome -> Bluetooth.Web.RequestDevice.Outcome
Logging:
- VLOG(1) filters used when scanning
- VLOG(1) optional services used when scanning
- VLOG(1) any errors before starting scan
- VLOG(1) devices found and their UUIDs
- VLOG(1) if no devices were found
BUG=499636
Review URL: https://codereview.chromium.org/1261593004
Cr-Commit-Position: refs/heads/master@{#343139}
Exclude chrome://device-emulator from the official build.
BUG=513046
[email protected]
Committed: https://crrev.com/28faa584640fed3ca3e0ae8e5612f84de0cbb59b
Cr-Commit-Position: refs/heads/master@{#343036}
Review URL: https://codereview.chromium.org/1288433004
Cr-Commit-Position: refs/heads/master@{#343138}
Add remaining Linux configs for MB.
This should add the remaining build configs for all of the linux
bots on the tryserver.chromium.linux waterfall.
(We need to add the android and cros bots that are currently
on the tryserver.chromium.linux waterfall to have everything covered).
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1291633005
Cr-Commit-Position: refs/heads/master@{#343137}
Modify devtools python generator to generate chromium-style
'content/browser/devtools/protocol/devtools_protocol_handler_generator.py'
generates code which is not consistent with Chromium Style. This patch
fixes the generator code to use a private destructor and makes the
templated 'RefCounted<T>' class a friend class.
https://www.chromium.org/developers/coding-style/chromium-style-checker-errors#TOC-RefCounted-types-with-public-destructors
BUG=517631
Review URL: https://codereview.chromium.org/1284213003
Cr-Commit-Position: refs/heads/master@{#343136}
[Offline pages] Action bar titles and renaming main menu item
With this patch an offline pages feature turned on:
* Main menu item to display: Saved pages
* All items in the enhanced bookmarks drawer: All saved pages
* Action bar title for all items: All saved pages
* Filter name for offline pages in the drawer: Saved offline
* Action bar header for when the filter is active: Saved offline
BUG=491352
Review URL: https://codereview.chromium.org/1285143005
Cr-Commit-Position: refs/heads/master@{#343135}
Cleanup/ remove unwanted duplicated option on tabs.json
Review URL: https://codereview.chromium.org/1286783002
Cr-Commit-Position: refs/heads/master@{#343134}
Roll src/third_party/WebKit cce53be:b4083b2 (svn 200419:200426)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cce53be..b4083b2
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1291653005
Cr-Commit-Position: refs/heads/master@{#343133}
[Re-land of https://codereview.chromium.org/126492300]
Introduce cross_site_iframe_factory.html, and use it to test the site isolation code in MemoryMetricsDetails under chrome/.
[ See crbug.com/515672 for a screenshot ]
/cross_site_iframe_factory.html?a(b(c, d)) gives you a simple three-level,
four-site iframe test. The trick it uses, is that the query parameter
is parsed and passed recursively to children, so the first level is:
<iframe src="b.com:1234/cross_site_iframe_factory.html?b(c(),d())">
Which then contains the two leaf iframes:
<iframe src="c.com:1234/cross_site_iframe_factory.html?c()">
<iframe src="d.com:1234/cross_site_iframe_factory.html?d()">
To to cut down on noise. ".com" is automatically affixed to the hostname
if a TLD isn't present.
As a convenience, the page supports local preview if loaded via file:// URI.
file:// URIs are technically cross-origin, although --site-per-process doesn't
isolate them today.
Each site has a random (but consistent) background color as a visual aid.
The page contains some crude layout logic to make sure the outer levels
are big enough to fit the inner levels.
The parsing logic is in tree_parser_util.js, which has unittests.
MetricsMemoryDetailsBrowserTest.TestSiteIsolation is a new test
that uses the above facility to creates a bunch of complex iframe
cases, and tests that our process-counting UMA stats are as expected.
BUG=515672
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_10.6_rel_ng;tryserver.chromium.win:win_chromium_vista_rel_ng
[email protected]
Review URL: https://codereview.chromium.org/1264923002
Cr-Commit-Position: refs/heads/master@{#342447}
Review URL: https://codereview.chromium.org/1288433002
Cr-Commit-Position: refs/heads/master@{#343132}
Added Generic Parametrized Testing
Usage and Info in this doc:
https://docs.google.com/a/google.com/document/d/1ItTezv49Idns-r_ZcIJNCLsc3xy0h1uwUMQjCJ9vcCM/edit?usp=sharing
Added a ParameterizedTest annotion with ability to have extra setup and teardown functionality
specific to parameters. Has an array of valid Parameter objects to run. Each Parameter object can
have an array of ParameterArgument objects. ParameterArgument objects can be set to have a default,
otherwise they are required.
CQ-DEPEND=CL:1259253007
Review URL: https://codereview.chromium.org/1219683014
Cr-Commit-Position: refs/heads/master@{#343131}
Remove tab_utils.cc from android build
Also remove a couple pass-throughs from tab_utils.cc. The motivation for this change is to make it clearer that the code in this file is not used on Android, and to make it easier to change the file by removing the need to worry about the Android compile.
BUG=none
Review URL: https://codereview.chromium.org/1291473002
Cr-Commit-Position: refs/heads/master@{#343130}
customtabs: Move the build files for the sample application to Chromium.
Review URL: https://codereview.chromium.org/1270403003
Cr-Commit-Position: refs/heads/master@{#343129}
Remove mIsSelectionBeingModified from Contextual Search
In some cases, the SELECTION_HANDLE_DRAG_STOPPED event comes in before
the last call to handleSelectionChanged(), resulting in the panel's
text being incorrect. handleSelectionChanged() is only called when
the selection has been modified, so setting the text doesn't
need to be dependent on handleSelectionChanged() getting called
in between DRAG_STRATED and DRAG_STARTED events.
BUG=517674
Review URL: https://codereview.chromium.org/1285983002
Cr-Commit-Position: refs/heads/master@{#343128}
Use visible_rect instead of coded_size for Cast video testing.
By using the coded_size, the PSNR and SSIM quality measurements were
including the garbage in the non-visible padding regions of the video
frames.
[email protected]
Review URL: https://codereview.chromium.org/1284353002
Cr-Commit-Position: refs/heads/master@{#343127}
Updates to base unittests so they run correctly in libchrome on Android
Parallel change to https://android-review.googlesource.com/#/c/163293/
(does not include changes being made to base/command_line_unittest
that are fixing temporary runner issues, since the runner is fine here)
BUG= 22884411, 22947438
Review URL: https://codereview.chromium.org/1273243002
Cr-Commit-Position: refs/heads/master@{#343126}
Devices app: Update interfaces, fix threads, add configs
This CL tackles a few small issues with the devices app:
* Interface field names are updated to be more
consistent with WebUSB names.
* The DeviceManager impl no longer uses UsbDevice
objects from the wrong (i.e. non-UsbService) thread.
* DeviceInfos are now populated with all device configs
rather than only the active config.
Additionally the devices app URL is changed to mojo:devices
to be consistent with other Mojo apps.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/1291643003
Cr-Commit-Position: refs/heads/master@{#343125}
Audio UI Refresh
BUG=519880
[email protected]
Review URL: https://codereview.chromium.org/1289723002
Cr-Commit-Position: refs/heads/master@{#343124}
[Mac] Prevent unintended bookmark button hovering changes in scrolling with keyboard.
While we were scrolling bookmark bar menu with up/down keys
(obviously with a large number of bookmarks in a given folder)
mouseEnteredButton was fired due to the scrolling/resizing of
the frame. Now, before scrolling we set a flag to distinguish incorrect
false mouse events from real ones.
The flag resets whenever a real mouse movement happens.
BUG=504199
TEST=Follow these steps (taken from bug report):
1. Create a large number of bookmarks in the bookmarks bar.
2. While viewing the expanded menu, press the down arrow key
repeatedly. Each time scroll occurs, the selection moves back to
the mouse position.
Review URL: https://codereview.chromium.org/1261173003
Cr-Commit-Position: refs/heads/master@{#343123}
content: Terminate with OOM error when failing to map shared memory baked GpuMemoryBuffer.
Improve diagnostics by failing immediately in case of an OOM error
instead of handling these type of failures in the same way as a lost
context situation.
BUG=
Review URL: https://codereview.chromium.org/1283203004
Cr-Commit-Position: refs/heads/master@{#343122}
Remove Android filter file for blink_heap_unittests target.
It is empty.
BUG=339980
TEST=blink_heap_unittests
[email protected]
Review URL: https://codereview.chromium.org/1287913002
Cr-Commit-Position: refs/heads/master@{#343121}
Fix some gn_visibility TODOs.
Tested on Mac with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ ninja -C out-gn/Release gn_visibility
BUG=504076
TEST=see above
[email protected]
Review URL: https://codereview.chromium.org/1283133002
Cr-Commit-Position: refs/heads/master@{#343120}
Revert "[Android] Redirect obsolete chrome:// URLs to NTP."
This reverts commit e124019512f944ad49114dea310531418d53ff7e
(https://codereview.chromium.org/1165613002).
Reason for revert: the CL caused a crash due to calling loadUrl() during
didFailLoad().
BUG=516379
Review URL: https://codereview.chromium.org/1288753002
Cr-Commit-Position: refs/heads/master@{#343119}
Dismiss Contextual Search panel in onToggleFullscreenMode
BUG=517439
Review URL: https://codereview.chromium.org/1286893002
Cr-Commit-Position: refs/heads/master@{#343118}
[Offline pages] Wiring delete page to the offline bridge
Changes:
* Adding delete page functionality to the offline bridge,
* Adding callback for delete page in OfflinePageCallback
* Updating the offline page model to enable deleting pages by
bookmark ID,
* Adding appropriate tests for the bridge and model
* Changing the model to not use a weak pointer when calling
DeleteArchiveFile, as it was causing a DCHECK in IsValid of the ptr.
The call was replaced with a function in an anonymous namespace, to
avoid a this pointer altogether (alternative was to pass unretained)
BUG=491352
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286143008
Cr-Commit-Position: refs/heads/master@{#343117}
aw: Fix capturePicture to ignore scroll offset
capturePicture is supposed to ignore any scroll offsets. The bug is that
need to call DidChangeRootLayerScrollOffset when scroll offset changes.
No point in being fancy or optimizing a deprecated api. Just straight up
call DidChangeRootLayerScrollOffset twice.
BUG=520276
Review URL: https://codereview.chromium.org/1284413003
Cr-Commit-Position: refs/heads/master@{#343116}
Fix the heap-buffer-overflow in linux_asan_chrome_mp build.
It seems in AddressSanitizer(Asan), there is a possibility that a word can be comprised of partial
combining characters or partial surrogate pair. In this case FindValidBoundaryBefore() / FindValidBoundaryAfter()
might return an index that doesn't lie within the segment range, which causes the heap-buffer-overflow error.
BUG=516361
TEST=No crash when trying to open fuzz-142.pdf on Asan chrome build
Review URL: https://codereview.chromium.org/1262273003
Cr-Commit-Position: refs/heads/master@{#343115}
Roll android_tools to get the android support annotations target
This target will be used by the example client to avoid
compile errors in chromium. The current ToT now uses several
annotations added from the support library
BUG=516529
Review URL: https://codereview.chromium.org/1284383002
Cr-Commit-Position: refs/heads/master@{#343114}
Remove app_name.xml.
The resource "@string/app_name" is already defined in
chrome/android/java/res_default/values/channel_constants.xml. No need to
define it twice; in fact, aapt doesn't like if we define it twice.
Review URL: https://codereview.chromium.org/1284423002
Cr-Commit-Position: refs/heads/master@{#343113}
Use regular bubbling scroll for scrolling during pinch gesture.
Scrolls occuring during a pinch gesture, that is, moving the center of pinch
during the gesture, are treated as regular scrolls that bubble from one viewport
layer to the next.
Note, scrolls during a pinch made in order to keep the pinch point centered
remain unchanged: under the --invert-viewport-scroll-order flag, these scrolls
will "pan" the viewport, scrolling *only* the inner viewport.
BUG=433724
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1288773002
Cr-Commit-Position: refs/heads/master@{#343112}
gpu: Remove unneeded dependency from gles2_conform_support.exe
Happened to come across this, so removing it.
Review URL: https://codereview.chromium.org/1287753004
Cr-Commit-Position: refs/heads/master@{#343111}
Implement online reauth UI for Locked Profiles on Mac
This CL implements the Mac UI for online reauth on Mac to match the
flow already implemented on other desktop platforms.
BUG=472596
TEST=
1. Create a supervised user
2. In a regular profile, click on the Avatar button
3. Click on "Exit and Childlock"
4. Select the locked profile and enter the wrong password
5. A window should open allowing online reauth
Review URL: https://codereview.chromium.org/1261433013
Cr-Commit-Position: refs/heads/master@{#343110}
networking.config: Allow access from platform_apps
This grants chrome apps access permission to the networking.config API.
Review URL: https://codereview.chromium.org/1289783002
Cr-Commit-Position: refs/heads/master@{#343109}
[Ozone-Drm] Remove support for handlers in the gpu platform support
This was originally intended to allow individual components (such as
display configuration, window management, ...) to be separated in
different handlers. The consensus was that it is cleaner to just keep
all IPC handling in a single class, so there is no need to support
handlers anymore.
BUG=none
Review URL: https://codereview.chromium.org/1284143003
Cr-Commit-Position: refs/heads/master@{#343108}
Migrate iOS cookies to unencrypted versions.
iOS has protected storage so encrypting cookies is not
necessary. It was done by mistake because I didn't
realize that iOS builds also defined OSX.
Also, fix an issue where failed OS encryption could
result in storing an unpredictable value. If it fails,
store nothing. Similarly, if decryption fails, ignore
the cookie.
BUG=517071
Review URL: https://codereview.chromium.org/1276493002
Cr-Commit-Position: refs/heads/master@{#343107}
Shows a launch spinner next to a sink once it is selected to create a route. The launch spinner survives MR UI closing and re-opening.
Once it is in launch state, a few features are disabled:
* clicking other sink has no effect.
* can not change cast mode.
After a launch attempt succeeds, go straight to route detail view.
Note that MediaRouterMojoImpl supports multiple simultaneous launch attempts. However, MR UI only supports one.
BUG=519667
Review URL: https://codereview.chromium.org/1273423004
Cr-Commit-Position: refs/heads/master@{#343106}
Add bookmark search feature to enhanced bookmark
Frontend:
1. The UI for bookmark search is implemented as a custom substitutable
View, which on phone takes the entire screen and behave as if an activity; on
tablet replaces the content RecyclerView and shows on the right of the screen.
2. The view tansitions are done by ViewSwitchers, which are placed as the root
of eb_main.xml.
3. EnhancedBookmarkSearchRow, a subclass of EnhancedBookmarkBookmarkRow, was
created to show bookmark results.
Backend:
1. We used the same backend that powers omnibox bookmark query. It
traverses the entire bookmark model and gets prefix matching resutls. A maximum
limit of 500 bookmarks is chosen in case of too large query that blocks the UI
thread.
2. Search history is saved in one single Android SharedPreference. Android does
not have a built-in support for saving list of strings; consequently JSONArray
is chosen to help serializing and deserializing.
The majority of the code has been previously reviewed in
https://chrome-internal-review.googlesource.com/#/c/180705/ and
https://chrome-internal-review.googlesource.com/#/c/216387/
BUG=515617
Review URL: https://codereview.chromium.org/1270693004
Cr-Commit-Position: refs/heads/master@{#343105}
Remove the memory wedge experiment code.
The experiment using this feature has been turned OFF since 2015-08-05.
This removes the code introduced in https://codereview.chromium.org/1107963002.
BUG=484198
[email protected]
Review URL: https://codereview.chromium.org/1279103002
Cr-Commit-Position: refs/heads/master@{#343104}
Disable text selection benchmark
It's timing out on android.
[email protected]
BUG=520079
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1283213002
Cr-Commit-Position: refs/heads/master@{#343103}
Remove STATIC_CONST_MEMBER_DEFINITION.
There's a single client of it, and that client becomes shorter by not using
this. Also see discussion on https://codereview.chromium.org/60103005/
and thread "[chromium-dev] Style question: static const members vs enums"
BUG=none
Review URL: https://codereview.chromium.org/1291623002
Cr-Commit-Position: refs/heads/master@{#343102}
More MB fixes in preparation for flipping Linux bots to use MB.
Two more changes. One, importantly, changes the GYP_DEFINE to
enable goma from 'goma=1' to 'use_goma=1'.
The other fixes the linux_full_bisect_builder to mirror the waterfall
bot config and not the tryserver config, and so DCHECKs will not be
enabled.
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1291803004
Cr-Commit-Position: refs/heads/master@{#343101}
[sql] Record memory usage at various periods after startup.
This will be used to track improvements occuring from enabling
memory-mapped I/O.
BUG=489784
Review URL: https://codereview.chromium.org/1283033004
Cr-Commit-Position: refs/heads/master@{#343100}
Remove a reference to IDR_WARNING_ICON
GetIconID() shouldn't be called for CONTENT_SETTINGS_TYPE_PUSH_MESSAGING
BUG=505953
Review URL: https://codereview.chromium.org/1269833002
Cr-Commit-Position: refs/heads/master@{#343099}
aw: Reverse ipc command buffer switch
IPC command buffer is on by default now. Change the switch to revert
back to in-process command buffer instead so it's still useful without
recompiling code.
BUG=509702
Review URL: https://codereview.chromium.org/1287853006
Cr-Commit-Position: refs/heads/master@{#343098}
Fixed Some Issues on AppCacheInternalsUI Source
The fix is related to the CL: https://codereview.chromium.org/1283843003/.
*Removed unnecessary reference to <sstream>
* Used DictionaryValue::SetString rather than ::Set in a few locations.
BUG=None
Review URL: https://codereview.chromium.org/1287043003
Cr-Commit-Position: refs/heads/master@{#343097}
Address Win/Clang style plugin error in hwnd_message_handler.h
This should fix the error below, and also make the code adhere to the comment
in the header: "The WeakPtrFactories below must occur last" :-)
In file included from ..\..\ui\views\win\hwnd_message_handler.cc:5:
..\..\ui/views/win/hwnd_message_handler.h(594,44) : error: [chromium-style]
WeakPtrFactory members which refer to their outer class must be the last member
in the outer class definition.
base::WeakPtrFactory<HWNDMessageHandler> autohide_factory_;
^
BUG=82385
TBR=sky
Review URL: https://codereview.chromium.org/1286273002
Cr-Commit-Position: refs/heads/master@{#343096}
Add various GPU isolates for GN.
This adds support for some of test binaries needed in the
'archive_gpu_tests=true' config of a GYP build:
- content_gl_tests
- gles2_conform_tests
- gl_tests
- tab_capture_end2end_tests
There is still more work to be done (telemetry_gpu_tests,
angle_end2end_tests, angle_deqp_*_tests).
[email protected]
BUG=519778
Review URL: https://codereview.chromium.org/1285063002
Cr-Commit-Position: refs/heads/master@{#343095}
A few more spurious cleanups on ApplicationImpl.
[email protected]
http://crbug.com/519583
Review URL: https://codereview.chromium.org/1288743002
Cr-Commit-Position: refs/heads/master@{#343094}
Add YUV_420_BIPLANAR to gfx::BufferFormat.
Enable it as a supported configuration on Mac.
BUG=510260
TEST=Covered by GpuMemoryBufferImpl::Map and ::PersistentMap.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1282313002
Cr-Commit-Position: refs/heads/master@{#343093}
Roll src/third_party/WebKit c182987:cce53be (svn 200404:200419)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c182987..cce53be
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1290863002
Cr-Commit-Position: refs/heads/master@{#343092}
Remove DCHECK that all removed USB devices must have been enumerated.
This patch removes the assertion that when a device is removed it must be
either in the current enumeration or be in the set of devices currently
being enumerated. This assertion is invalid because a device may, for a
number of possible reasons, fail to be enumerated and thus be in neither
of these sets. Yet, when it is removed there will still be a removal event
generated by libusb.
BUG=520220
Review URL: https://codereview.chromium.org/1288183002
Cr-Commit-Position: refs/heads/master@{#343091}
[Password Manager] Fix a bug where generated passwords are marked as not generated.
BUG=519875
Review URL: https://codereview.chromium.org/1284043002
Cr-Commit-Position: refs/heads/master@{#343090}
Ensure Task Manager's "sort" column is always a visible column.
If the Task Manager is sorting by the contents of the "Task" column,
say, and you hide that column, the Task Manager continues sorting
the table's contents by the Task column. Visually, this means no column
header displays an up/down sort arrow, and there's no apparent logic to
the table's sort order. This change forces the task manager to select a
new column for sorting the table in this situation.
BUG=517937
Review URL: https://codereview.chromium.org/1282593004
Cr-Commit-Position: refs/heads/master@{#343089}
[Contextual Search] Add twellington@ as an owner, and comments about Donn and Pedro being primary reviewers for all CS directories.
BUG=
Review URL: https://codereview.chromium.org/1287003005
Cr-Commit-Position: refs/heads/master@{#343088}
cc: Don't create tiles in a non-ideal tiling.
Non-ideal tilings are not going to be rasterized, so it's a waste to
allocate more tiles for it. Instead, only intersect the interest rect
instead of moving/growing it. This save some allocations on pinch zoom
cases.
BUG=517749
R=danakj
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1284763003
Cr-Commit-Position: refs/heads/master@{#343087}
Android Media Notification: remove ▶ character if at the beginning of the title.
It is also removing trailing/leading spaces in order to increase the
visibility of the title in the notification.
BUG=517873
Review URL: https://codereview.chromium.org/1286943006
Cr-Commit-Position: refs/heads/master@{#343086}
ChromeContentRulesRegistry: remove unnecessary page url related state
Since d20b1f09ea33b915961315a87be322709b533cb0 we've been iterating over
all rules in ChromeContentRulesRegistry::GetMatches, rather than just
those rules matching page url conditions. This actually made redundant
the extra state and logic to short-circuit evaluation of conditions with
page url matches, as IsConditionFulfilled() evaluates the page url
condition first and short-circuits further evaluation anyway.
This change simplifies ChromeContentRulesRegistry by removing the
redundant state and logic, and collapsing all of the condition state
computation and evaluation into a single function.
This is in support of step 6 in the associated bug. No functional change
is intended.
BUG=492946
Review URL: https://codereview.chromium.org/1291613005
Cr-Commit-Position: refs/heads/master@{#343085}
Fix a crash when trying to sign in with an account already signed in.
BUG=515005
Review URL: https://codereview.chromium.org/1285073003
Cr-Commit-Position: refs/heads/master@{#343084}
Replace use of ternary operator in void context.
Use of the ternary operator in a void context is very concise, but not
necessarily readable.
Replace it with a boring, verbose if statement.
BUG=
TEST=net_unittests
Review URL: https://codereview.chromium.org/1283203003
Cr-Commit-Position: refs/heads/master@{#343083}
Add a flow step for when input events are sent from the browser
Current input flow events fail to capture the queueing delay for events
buffered in the browser. Add a flow step for when such input events are
sent, making it clear visually how the queueing delay impacts the event
and its side effects.
BUG=520109
Review URL: https://codereview.chromium.org/1286963005
Cr-Commit-Position: refs/heads/master@{#343082}
Makes HTMLFrame own the View created for a child frame
When an HTMLFrame is created locally (the result of createChildFrame())
then the HTMLFrame needs to own the corresponding View. HTMLFrame can't
delete this View if swapped to remote, as otherwise that would trigger
destruction of the HTMLFrame.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1291613006
Cr-Commit-Position: refs/heads/master@{#343081}
Add CHECKs when a single GpuMemoryBuffer plane is assumed.
Make sure Map() and GetStride() is never called with an array that is too small.
BUG=510260
TEST=No expected behavior change.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1286523002
Cr-Commit-Position: refs/heads/master@{#343080}
Use unique image for lofi testing
I talked to the LoFi folks there's a possibility the test image is being cached on the waterfall (as it's used by many other tests) so we don't see a lofi header in the response. This will fix the issue by using an image unique for lofi.
Also ignore favicon requests when looking for lofi, as there isn't the expectation those will be replaced.
BUG=520146
Review URL: https://codereview.chromium.org/1288143003
Cr-Commit-Position: refs/heads/master@{#343079}
[Media Router] Fix infinite loop issue in ListenForRouteMessages.
We will treat an empty list returned from ListenForRouteMessages to mean
no more messages will come from that route. That means if
OnRouteMessagesReceived is invoked with empty list, then
ListenForRouteMessages should not be called again.
Note that if an observer is added after this happens, it will still
trigger a ListenForRouteMessages, but it will not result in infinite
loop.
Also clarified documentation in .mojom.
BUG=520204
Review URL: https://codereview.chromium.org/1291823002
Cr-Commit-Position: refs/heads/master@{#343078}
Roll src/third_party/WebKit 60589a2:c182987 (svn 200399:200404)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/60589a2..c182987
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288113002
Cr-Commit-Position: refs/heads/master@{#343077}
Add SafeBrowsingResourceThrottle on Android only if field trial is enabled.
This removes the SafeBrowsingResourceThrottleFactory since it was no
longer serving its original purpose, and instead puts the throttle selection
logic into each of SafeBrowsingResourceThrottle and
DataSaverProxyResourceThrottle.
BUG=516901,474608
Review URL: https://codereview.chromium.org/1286433002
Cr-Commit-Position: refs/heads/master@{#343076}
Exposed embedded objects in rich text to browser tests on Windows.
BUG=491027
R=dmazzoni
Review URL: https://codereview.chromium.org/1150413006
Cr-Commit-Position: refs/heads/master@{#343075}
Adding additional logging to help eliminate flakiness
BUG=
Review URL: https://codereview.chromium.org/1291633003
Cr-Commit-Position: refs/heads/master@{#343074}
Add debugging code around BeginPaint() failures in WM_PAINT handler.
BUG=512945
Review URL: https://codereview.chromium.org/1278393003
Cr-Commit-Position: refs/heads/master@{#343073}
Enable page_cycler.typical_25 on Windows Mandoline.
BUG=513789
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1289853003
Cr-Commit-Position: refs/heads/master@{#343072}
Android Media Notification: remove "Playing" and "Paused" strings.
BUG=520158
Review URL: https://codereview.chromium.org/1287033005
Cr-Commit-Position: refs/heads/master@{#343071}
GN: gfx_unittests links on Mac.
Tested on Mac with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ ninja -C out-gn/Release gfx_unittests
BUG=431177
TEST=see above
[email protected]
Review URL: https://codereview.chromium.org/1287753003
Cr-Commit-Position: refs/heads/master@{#343070}
Fix settings page link misalignment
BUG=446683
Review URL: https://codereview.chromium.org/1285893002
Cr-Commit-Position: refs/heads/master@{#343069}
cc: Don't create low resolution tilings on the pending tree.
Since activation requires us to have high resolution tiles (unless
we're out of memory), the low resolution tilings on the pending tree
are very likely to be wasted.
The only time they are not is if we activate and scroll into an area
that was invalidated and neither new high res or new low res was
rasterized yet, but the prepaint on the pending tree did rasterize it.
This case seems very unlikely and rare.
R=danakj, enne, weiliangc
BUG=517227
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1275243003
Cr-Commit-Position: refs/heads/master@{#343068}
Gets //mandoline passing gn check
BUG=none
TEST=none
[email protected]
Committed: https://crrev.com/c202fc81d0b4931cb928672e5cd226e51e501ea9
Cr-Commit-Position: refs/heads/master@{#342890}
Review URL: https://codereview.chromium.org/1278803006
Cr-Commit-Position: refs/heads/master@{#343067}
[MD settings] adding paper-dropdown-menu and paper-submenu
During the initial move from Polymer 0.5 to 1.0, the
paper-dropdown-menu and paper-submenu were left out. They've now been added. These elements will be used
in the Material Design settings pages.
The changes to paper-menu are to help support the
paper-submenu.
The change to paper-checkbox is because I accidentally
added a \n to the js file in my prior CL.
BUG=425627
Review URL: https://codereview.chromium.org/1284033003
Cr-Commit-Position: refs/heads/master@{#343066}
Hook up Bluetooth Low Energy Smart Lock experiment with existing lock screen UI.
If the --enable-proximity-auth-bluetooth-low-energy-discovery flag is set, the
user now can click the user pod to unlock the lock screen rather than
automatically unlocking.
This CL also refactors ProximityAuthBleSystem now that ScreenlockBridge is part
of the proximity_auth component.
BUG=517641
TEST=manual
Review URL: https://codereview.chromium.org/1273153004
Cr-Commit-Position: refs/heads/master@{#343065}
Stop setting --enable-overlay-fullscreen-video on Android
Previously, --enable-overlay-fullscreen-video was used to enable the
blink runtime feature OverlayFullscreenVideo which enabled video to be
efficiently {over,under}-layed on Android. This was set by default on
Android and for layout tests on other platforms. Now the WebMediaPlayer
decides whether overlay fullscreen mode will be used. The blink runtime
feature is renamed to ForceOverlayFullscreenVideo to be used as an
override for running the overlay fullscreen layout tests on non-android
platforms.
This relies on blink changes:
* https://codereview.chromium.org/1254613003
* https://codereview.chromium.org/1278583004
A follow up change will remove the OverlayFullscreenVideo runtime
feature and corresponding command line flag.
BUG=511376,507834
TEST=virtual/android/fullscreen layout tests, manual
Review URL: https://codereview.chromium.org/1286583002
Cr-Commit-Position: refs/heads/master@{#343064}
Add null check to avoid bug.
Unclear how we are ever getting null here, but adding a null check
does no harm, and should prevent the bug.
BUG=519968
Review URL: https://codereview.chromium.org/1283293002
Cr-Commit-Position: refs/heads/master@{#343063}
cc: Add solid color analysis to rasterize_and_record's record_time
This adds record-time solid color analysis (that is, solid color
analysis that's performed on a per-layer basis) to the
record_time metrics computed by rasterize_and_record.
Note to Perf sheriffs: this is expected to increase record_time by
~0.7%.
BUG=518845
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1289583002
Cr-Commit-Position: refs/heads/master@{#343062}
Remove owned views from AXAuraObjCache when widget is deleted.
A follow-up change should notify automation clients, too.
Even then, a CHECK() that an AX obj wrapper exists for a given ID doesn't
make sense because the IPC could have been received after an object was
deleted but before the client was informed of it.
BUG=514728
Review URL: https://codereview.chromium.org/1283593006
Cr-Commit-Position: refs/heads/master@{#343061}
Update V8 to version 4.6.69.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b7b1833c..da355b08
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286223002
Cr-Commit-Position: refs/heads/master@{#343060}
[Android] Add partial output to TimeoutError raised in cmd_helper.
BUG=
Review URL: https://codereview.chromium.org/1284283002
Cr-Commit-Position: refs/heads/master@{#343059}
Media: Introduce addSourceBuffer which takes an unparsed codecs string
Introduce an overload of WebMediaSourceImpl::addSourceBuffer that takes
codecs as an unparsed string and parses it using
media::ParseCodecString. This will allow us to remove the other
overload, which expects a parsed vector of codecs. This will
consolidate parsing of the codecs string in media and will allow
us to remove duplicated parsing code in blink::ContentType::codecs
BUG=none
Review URL: https://codereview.chromium.org/1281663003
Cr-Commit-Position: refs/heads/master@{#343058}
Make find-in-page focus in extension options page
BUG=438317
[email protected]
Review URL: https://codereview.chromium.org/1283223002
Cr-Commit-Position: refs/heads/master@{#343057}
[Android] Check activity finishing at EnhancedBookmark*Activity exit.
When user presses the delete button, the activity is being dismissed,
but if user clicks the back button fast enough, then onBackPressed() is
called while it's exiting. So check isFinishing() at onBackPressed()
BUG=520005
Review URL: https://codereview.chromium.org/1283273003
Cr-Commit-Position: refs/heads/master@{#343056}
GN: Don't explicitly define __ANDROID__ now that clang defines it automatically
BUG=402625
Review URL: https://codereview.chromium.org/1284093002
Cr-Commit-Position: refs/heads/master@{#343055}
Roll src/third_party/android_tools 2bb73b7:334ba2c
Summary of changes available at:
https://chromium.googlesource.com/android_tools/+log/2bb73b7..334ba2c
BUG=511384
Review URL: https://codereview.chromium.org/1291783002
Cr-Commit-Position: refs/heads/master@{#343054}
Move NumberOfPlanesForGpuMemoryBufferFormat to gfx
We will need to call it from media::GpuMemoryBufferVideoFramePool when we
add support for YUV_420_BIPLANAR.
BUG=510260
TEST=No behavior change, only moving code.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/85f29861d095a7c5dcf318053e8349d1efaddbab
Cr-Commit-Position: refs/heads/master@{#342942}
Review URL: https://codereview.chromium.org/1281043006
Cr-Commit-Position: refs/heads/master@{#343053}
[Android] Move remote device platform errors to test run base class.
Currently gtests have logic for detecting platform errors on the remote device
platform. This moves it up to the base class for remote_device_test_run and
adds this functionality to instrumentation test runs.
BUG=485842
Review URL: https://codereview.chromium.org/1279873004
Cr-Commit-Position: refs/heads/master@{#343052}
[Sync] Convert to using auto-generated ModelType.
See http://crrev.com/1247853007 for where the new ModelType was added.
- ModelType is now just represented by an integer.
- ModelType is now located in org.chromium.sync.
- Many of the constants were singular and are now plural to match
the ones in model_type.h.
- ModelTypeSet is removed and a jintArray is used for JNI.
BUG=509788
[email protected]
Review URL: https://codereview.chromium.org/1262413006
Cr-Commit-Position: refs/heads/master@{#343051}
[Sync] Dismiss PassphraseDialogFragment when passphrase is entered from external event
Issue: When PassphraseDialogFragment is opened both from SyncCustomizationFragment
and from notification, entering passphrase in one of them doesn't dismiss the
other.
Solution: allow SyncCustomizationFragment to listen to sync state changes and
dismiss passphrase dialog when it is no longer needed.
In this change:
- Enable updating state on every state change notification from ProfileSyncService,
not just when initialized state changes.
- Check if passphrase is not required and dismiss dialog.
BUG=516975
TEST=Steps below:
- Signin into chrome on Android with account with custom passphrase
- open sync settings ("Passphrase required" notification should appear.
- Tap on "Encryption" in sync settings, passphrase dialog should open.
- Pull down notification and open passphrase dialog from there as well. Enter valid passphrase.
- When dialog from notifications is closed, dialog from sync settings should get dismissed.
Review URL: https://codereview.chromium.org/1280823004
Cr-Commit-Position: refs/heads/master@{#343050}
Roll src/third_party/skia 4b5472b:58d890b
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4b5472b..58d890b
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
58d890b [email protected] All child GrFragmentProcs' transforms and textures will be stored in the root GrFragmentProc in preorder
cc34c41 [email protected] Revert of SkPDF: Move SkFlate into src/pdf (part 1/3) (patchset #1 id:1 of https://codereview.chromium.org/1285913002/ )
d1bc574 [email protected] Update CodexTest to test valid_alpha.
5a4d235 [email protected] Revise DrawAtlasBatch to get rid of one copy when generating the batch.
69a9689 [email protected] Remove trace marker support from GrBufferedDrawTarget
d0375bc [email protected] Fix bmp RLE "bug"
e14c1fe [email protected] SkPDF: Move SkFlate into src/pdf (part 1/3)
65cc3e4 [email protected] C API: add radial, sweep, and two-point conical gradient shaders
b427db1 [email protected] Consolidate SkCodec functions for handling rewind
Review URL: https://codereview.chromium.org/1284293002
Cr-Commit-Position: refs/heads/master@{#343049}
Create overlay candidate validator for Mac.
It will be enabled later when we are ready to turn on video overlays.
BUG=510260
Review URL: https://codereview.chromium.org/1268393005
Cr-Commit-Position: refs/heads/master@{#343048}
Plugin Power Saver: Keep play button centered when zoom level changes.
Previously, if the zoom level was changed on a page without reloading, throttled
Flash plugins with the UI overlay would not resize the UI overlay. This caused
the play button to go off-center.
This patch propagates zoom changes in the outer webview into the plugin
placeholder and keeps the play button centered.
BUG=517554
Review URL: https://codereview.chromium.org/1285713002
Cr-Commit-Position: refs/heads/master@{#343047}
Revert of Exclude chrome://device-emulator from the official build. (patchset #6 id:90001 of https://codereview.chromium.org/1288433004/ )
Reason for revert:
This broke Linux ChromiumOS GN. Need to update GN as well as GYP?
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20%28dbg%29/builds/6332
Original issue's description:
> Exclude chrome://device-emulator from the official build.
>
> BUG=513046
> [email protected]
>
> Committed: https://crrev.com/28faa584640fed3ca3e0ae8e5612f84de0cbb59b
> Cr-Commit-Position: refs/heads/master@{#343036}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513046
Review URL: https://codereview.chromium.org/1289823003
Cr-Commit-Position: refs/heads/master@{#343046}
Remove unused content .rc files.
These were generated and referenced in a few places but seem not to be used. In the GN build such generated .rc files are always compiled and linked, which resulted in duplicate resources.
Review URL: https://codereview.chromium.org/1289883002
Cr-Commit-Position: refs/heads/master@{#343045}
Added myself as an OWNER of extensions/browser/guest_view/.
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/1283233002
Cr-Commit-Position: refs/heads/master@{#343044}
Adding UMA metrics for Applescript commands
Add UMA metrics for Tab and Window Applescript commands
BUG=516757
Review URL: https://codereview.chromium.org/1264653006
Cr-Commit-Position: refs/heads/master@{#343043}
Disable BrowserCloseManagerBrowserTest.TestAddTabDuringShutdown
The test is flaky.
[email protected]
BUG=519646
Review URL: https://codereview.chromium.org/1286143004 .
Cr-Commit-Position: refs/heads/master@{#343042}
Attach security info to redirect responses
The DevTools security panel should show SSL information for each
subresource on the page, including redirects. This CL attaches security
info to the ResourceResponseHead for redirect responses, so that the
security info for redirect responses can be sent to devtools when
enabled.
BUG=519120
Review URL: https://codereview.chromium.org/1275743005
Cr-Commit-Position: refs/heads/master@{#343041}
Roll src/third_party/WebKit f0bff72:60589a2 (svn 200396:200399)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f0bff72..60589a2
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286963004
Cr-Commit-Position: refs/heads/master@{#343040}
Fix HW acceleration of child windows on high-end devices.
BUG=516614
Review URL: https://codereview.chromium.org/1271343005
Cr-Commit-Position: refs/heads/master@{#343039}
Added new command line flag to change the log upload frequency.
--system-log-upload-frequency command line flag is an integer value,
that is the log upload frequency in Milliseconds.
If this flag is not set, the log upload frequency is 12h.
BUG=518879
Review URL: https://codereview.chromium.org/1273723003
Cr-Commit-Position: refs/heads/master@{#343038}
[tracing] Add a browser test for memory-infra in single-process mode
This CL adds an end-to-end browser test with "single-process" mode for
memory-infra. This is added to ensure that memory-infra tracing runs
without crashing in web-view.
BUG=518887
Review URL: https://codereview.chromium.org/1283843002
Cr-Commit-Position: refs/heads/master@{#343037}
Exclude chrome://device-emulator from the official build.
BUG=513046
[email protected]
Review URL: https://codereview.chromium.org/1288433004
Cr-Commit-Position: refs/heads/master@{#343036}
Fix downloads focus bug when pressing Enter on "Pause"
This probably affects other types of things where "clicking"
the control hides it (e.g. "Resume")
[email protected]
BUG=519129
Review URL: https://codereview.chromium.org/1284843003
Cr-Commit-Position: refs/heads/master@{#343035}
explicitly depend on Skia if you use its headers
BUG=skia:4190
Review URL: https://codereview.chromium.org/1289853002
Cr-Commit-Position: refs/heads/master@{#343034}
Ensure AccountManagerHelper uses the correct AccountManagerDelegate.
Assert when initializing the singleton AccountManagerHelper that an instance hasn't been created by default in the getter.
BUG=518830
Review URL: https://codereview.chromium.org/1274203004
Cr-Commit-Position: refs/heads/master@{#343033}
[Android] Log existing controllers on forwarder failure.
BUG=
Review URL: https://codereview.chromium.org/1286193002
Cr-Commit-Position: refs/heads/master@{#343032}
Add |history.scrollRestoration| to the list
This is in anticipation of making the runtime feature stable
Blink CL: https://codereview.chromium.org/1286713003/
BUG=444094
Review URL: https://codereview.chromium.org/1286753003
Cr-Commit-Position: refs/heads/master@{#343031}
Popular sites on the NTP: Favicon improvements
- Check for existing favicons by page URL rather than icon URL to better handle cases where the icon URL changed etc.
BUG=516618
Review URL: https://codereview.chromium.org/1287993002
Cr-Commit-Position: refs/heads/master@{#343030}
Add out-of-line dtor to satisfy Chromium style Clang plugin
Style issue was introduced in http://crrev.com/342962
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288673003
Cr-Commit-Position: refs/heads/master@{#343029}
[Media Router] PSDImpl to stop generating presentation IDs.
PSDImpl no longer generates presentation IDs; MR is the sole generator.
CreateSessionRequest no longer holds the generated presentation ID.
General cleanups of CreateSessionRequest class and unit tests.
BUG=510297
Review URL: https://codereview.chromium.org/1288513002
Cr-Commit-Position: refs/heads/master@{#343028}
Add CrNet integration test framework.
this adds a new target, crnet_test, which builds a standalone binary that runs
CrNet integration tests. Currently there are only two tests, which cover basic
HTTP fetch functionality. Further tests will be added in later CLs.
BUG=422451
Review URL: https://codereview.chromium.org/1235203002
Cr-Commit-Position: refs/heads/master@{#343027}
[scheduler]: Fix a bug with non-nestable tasks.
Avoids a DCHECK in TaskQueueImpl::Task::enqueue_order() caused by
TaskIsOlderThanQueuedTasks being called on an empty task if the previous
task was a non-nestable task while the scheduler is running on a nested
message loop.
Review URL: https://codereview.chromium.org/1287003003
Cr-Commit-Position: refs/heads/master@{#343026}
Roll src/third_party/WebKit 900964e:f0bff72 (svn 200395:200396)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/900964e..f0bff72
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288033002
Cr-Commit-Position: refs/heads/master@{#343025}
Fix waterfall bots to not use fastbuild and add presubmit validation.
Previously both tryservers and waterfall GYP bots were being built w/
fastbuild=1, but we want the non-windows waterfall bots to have
as much debug info as possible. Windows bots should still be
built w/ fastbuild=1, because they take too long to link otherwise.
Also, fix an oversight where the debug waterfall
bots were not configured to use swarming
Also, we would validate that the mb_config.pyl config file was
correct in a unit test, but that wasn't very obvious and now we
have presubmit checks for MB, so move this to a presubmit check
instead.
[email protected]
BUG=481692
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1281773004
Cr-Commit-Position: refs/heads/master@{#343024}
Enable sticky key unit tests under Ozone.
Review URL: https://codereview.chromium.org/1272383005
Cr-Commit-Position: refs/heads/master@{#343023}
Fix shortcut info's title fallback
* https://codereview.chromium.org/1224273003/ introduced a regression where the meta title
tag of a website is ignored when short_name is being set.
* https://codereview.chromium.org/1272563005 introduced a temporary workaround which is
still necessary but does not fix the entire issue.
* This CL fully fixes the issue by adding the fallback to name and short_name of title so
the recents menu will be set correctly.
* This CL also adds test cases to prevent a future regression.
BUG=517647
Review URL: https://codereview.chromium.org/1282853002
Cr-Commit-Position: refs/heads/master@{#343022}
CrNet: add SDCH support
The setSdchEnabled method on CrNet allows an embedder to configure SDCH.
The withPrefStore argument, if non-nil, is the file path to use for SDCH
persistence; if nil, persistence is disabled.
BUG=488678
Review URL: https://codereview.chromium.org/1150133002
Cr-Commit-Position: refs/heads/master@{#343021}
Roll src/third_party/skia 9cdcabe:4b5472b
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9cdcabe..4b5472b
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
4b5472b [email protected] Add ability to pass in an optional path to additional unit tests to run.
37eb184 [email protected] Move AAFillRect into CPP for templatization
Review URL: https://codereview.chromium.org/1284243002
Cr-Commit-Position: refs/heads/master@{#343020}
VideoCaptureManager: Release video capture device if there is no active clients
We currently keep the capture device open if we have paused clients. Instead, we should release the capture device and reopen it when we get an active client.
BUG=501764,493108,417659
Review URL: https://codereview.chromium.org/1287063003
Cr-Commit-Position: refs/heads/master@{#343019}
Add bzanotti as an OWNER of components/signin/ios.
BUG=
Review URL: https://codereview.chromium.org/1291773002
Cr-Commit-Position: refs/heads/master@{#343018}
PeerConnectionIdentityStore used instead of PeerConnectionIdentityService; service deleted.
Also removing dependency on webrtc's dtlsidentityservice.cc/h.
This CL is part of an effort to land https://codereview.webrtc.org/1176383004 without breaking Chromium.
See bug for more information.
BUG=webrtc:4899
Review URL: https://codereview.chromium.org/1272763004
Cr-Commit-Position: refs/heads/master@{#343017}
Fix omnibox_event_global_tracker.h inclusion.
Cleaning CL/1278433002
Review URL: https://codereview.chromium.org/1288023002
Cr-Commit-Position: refs/heads/master@{#343016}
[Offline pages] Adding Saved offline filter to Enhanced bookmarks UI
BUG=491352
[email protected]
Review URL: https://codereview.chromium.org/1285013002
Cr-Commit-Position: refs/heads/master@{#343015}
[Offline pages] Adding capability to get page by bookmark Id
Adding capability to get page by bookmark Id in offline page model,
Exposing that capability in offline page bridge,
Adding tests to the offline page model and bridge.
BUG=491352
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1275633005
Cr-Commit-Position: refs/heads/master@{#343014}
Roll src/third_party/WebKit 006f931:900964e (svn 200394:200395)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/006f931..900964e
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288633002
Cr-Commit-Position: refs/heads/master@{#343013}
Roll src/third_party/skia a387a11:9cdcabe
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a387a11..9cdcabe
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
9cdcabe [email protected] Revert[3] "move some public headers into private"
9d20ee5 [email protected] Revert[2] "move some public headers into private"
Review URL: https://codereview.chromium.org/1290553004
Cr-Commit-Position: refs/heads/master@{#343012}
Remove Android filter file for sync_unit_tests.
BUG=339980
TEST=sync_unit_tests
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1282923005
Cr-Commit-Position: refs/heads/master@{#343011}
Android Media Notification: allow user to dismiss while paused.
It is changing the service status to background when the notification
visible but paused. If the notification is dismissed, the service will
be killed.
BUG=515129
Review URL: https://codereview.chromium.org/1281493005
Cr-Commit-Position: refs/heads/master@{#343010}
Eliminating the use of TestPasswordsStore
Eliminating the use of TestPasswordsStore from components/password_manager/core/browser/password_form_manager_unittest.cc
BUG=517457
Review URL: https://codereview.chromium.org/1284943003
Cr-Commit-Position: refs/heads/master@{#343009}
Removed bookmark_image_service
This class is being deprecated as is no longer used.
BUG=None
Review URL: https://codereview.chromium.org/1219713002
Cr-Commit-Position: refs/heads/master@{#343008}
Roll src/third_party/WebKit efb7f29:006f931 (svn 200392:200394)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/efb7f29..006f931
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286943003
Cr-Commit-Position: refs/heads/master@{#343007}
Ensure that we do not receive callbacks after destroying WebView
An app that calls destroy() on a WebView for which a callback is pending
(e.g. onPageFinished) can accidentically use the WebView from that
callback after the destroy method has finished.
To prevent this from happening we now reset the WebView callback
listeners (e.g. WebViewClient) when destroying WebView.
BUG=498796
Review URL: https://codereview.chromium.org/1284923002
Cr-Commit-Position: refs/heads/master@{#343006}
Roll src/third_party/WebKit 4b3f497:efb7f29 (svn 200388:200392)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4b3f497..efb7f29
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287013002
Cr-Commit-Position: refs/heads/master@{#343005}
cc: Make layer updating optional in BeginMainFrame
If no-one has requested a layer update, either by calling
Proxy::SetNeedsUpdateLayers() or Proxy::SetNeedsCommit(), skip computing
the layer update in BeginMainFrame. This reduces the static overhead of
a BeginMainFrame/Commit operation when the layer tree doesn't change.
This change improves efficiency, for example, when a page has a
requestAnimationFrame callback which does not modify the DOM.
BUG=490465
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1255863004
Cr-Commit-Position: refs/heads/master@{#343004}
Update "Aw, Snap" Help Center URLs based on action button shown
Help Center would like to show different content based on whether you have the Reload or Feedback button shown.
BUG=511478
Review URL: https://codereview.chromium.org/1283753003
Cr-Commit-Position: refs/heads/master@{#343003}
webapps: utilize theme color specified in manifest
Currently the manifest spec allows a theme color to be specified. However, we do not parse nor use this currently.
Add the code for parsing the theme color attribute using a newly exposed CSS color parsing API from Blink and then utilize the theme color by setting the recents color.
Note that each page is able to override the manifest color through the use of a meta tag which is currently supported.
BUG=510402
Review URL: https://codereview.chromium.org/1234653004
Cr-Commit-Position: refs/heads/master@{#343002}
Update V8 to version 4.6.68.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/686ae506..b7b1833c
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1283173002
Cr-Commit-Position: refs/heads/master@{#343001}
Componentize tab_node_pool to sync_driver
Move tab_node_pool to the sync_driver component.
Updated gn and gyp file.
BUG=512073
Review URL: https://codereview.chromium.org/1275003003
Cr-Commit-Position: refs/heads/master@{#343000}
Show OSK when physical keyboard is detached
When the user transitions from OSK to physical keyboard then back to
soft keyboard, the soft keyboard does not appear so it's inconvenient.
This change intends to show keyboard for all keyboard related configuration
changes (keyboard type, show and hide status).
BUG=500662
Review URL: https://codereview.chromium.org/1281633004
Cr-Commit-Position: refs/heads/master@{#342999}
Fix some interleaving issues in EmbeddedWorkerInstance.
The embedded worker startup sequence involves thread hopping and async
callbacks, so there's some cases that could cause bugs:
One is detach during startup:
(1) ProcessAllocated sets process_id_
(2) Hop to UI thread for RegisterDevToolsManagerOnUI
(3) The render process dies, detaching and clearing process_id_
(4) UI thread work completes, hops back to SendStartWorker
(5) SendStartWorker tries to send an IPC to process_id -1, hits DCHECK.
Another is calling Stop() during startup:
(1) Call Start()
(2) Hop to UI thread for AllocateProcess
(3) Call Stop()
(4) Stop tries to send an IPC to process_id -1, gets error.
(5) Stop sets status to STOPPING, and will remain in stopping forever.
The fix is to add checks to detect these conditions.
BUG=515759,509904
Review URL: https://codereview.chromium.org/1289443002
Cr-Commit-Position: refs/heads/master@{#342998}
Fix a forgotten return statement in BrowserContentSettingBubbleModelDelegate.
This meant that for bubbles which were invoked for both camera and microphone, we navigated correctly to the default settings page, but then immediately to mediastream exceptions page, which doesn't exist anymore.
NOTE: This test can fail if the settings UI opens in a separate window, but BrowserList does not recognize the window as active yet. Several rounds of testing on trybots suggest that this does not happen. If it in fact does happen, feel free to disable this test. msramek@ can then take another look and restrict it to the same-window case, or fix it to wait for the new window to be focused.
BUG=515376,509962
Review URL: https://codereview.chromium.org/1273683002
Cr-Commit-Position: refs/heads/master@{#342997}
Android: Add locking to a ChildProcessLauncher#sSpareSandboxedConnection access.
Review URL: https://codereview.chromium.org/1284643002
Cr-Commit-Position: refs/heads/master@{#342996}
Roll src/third_party/WebKit 9bfbfc4:4b3f497 (svn 200380:200388)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9bfbfc4..4b3f497
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1291723002
Cr-Commit-Position: refs/heads/master@{#342995}
Arranging the Pref Names in lexicographically order.
This is for arranging the pref names in proper order to get better readability.
BUG=519994
Review URL: https://codereview.chromium.org/1286963002
Cr-Commit-Position: refs/heads/master@{#342994}
Roll WebRTC 9699:9703, Libjingle 9699:9703
WebRTC 9699:9703
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/09346f1..fa79fcc
Libjingle 9699:9703
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/4dd92ac..7972c68
TBR=tommi
Review URL: https://codereview.chromium.org/1290673002
Cr-Commit-Position: refs/heads/master@{#342993}
Pass MotionEvent tool type to Blink.
This maps MotionEvent tool type to PointerEvent pointerType and passes
that to WebTouchPoints.
This CL is a part of a patch series:
1. https://codereview.chromium.org/1253183005/
for new WebPointerProperties fields
2. https://codereview.chromium.org/1260693003/
for eventSender web pointer property support
3. https://codereview.chromium.org/1192463008/
for handling pointer type in Blink event handlers
4. https://codereview.chromium.org/1190013002/ (this)
BUG=514360
Review URL: https://codereview.chromium.org/1190013002
Cr-Commit-Position: refs/heads/master@{#342992}
Upstream iOS implementation of Autocomplete factories.
Provide iOS implementation for AutocompleteClassifier, InMemoryURLIndex
and ShortcutsBackend factories as BrowserStateKeyedServiceFactory.
Provide iOS implementation for AutocompleteProviderClient and
AutocompleteSchemeClassifier.
BUG=516635
Review URL: https://codereview.chromium.org/1277543003
Cr-Commit-Position: refs/heads/master@{#342991}
Fix a few typos in the IPC message macros documentation
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/1284593004
Cr-Commit-Position: refs/heads/master@{#342990}
Add hack to green up WebRTC bots while we investigate bug.
Appears the content_browsertests step fail on the bots because we no
longer print results when the test is disabled. This is an attempt to
green things up so we can investigate the main bug in peace.
BUG=517977
Review URL: https://codereview.chromium.org/1287943003
Cr-Commit-Position: refs/heads/master@{#342989}
Fix bug introduced with https://codereview.chromium.org/1235533002/
Missing !
BUG=None
Review URL: https://codereview.chromium.org/1283693003
Cr-Commit-Position: refs/heads/master@{#342988}
Sending url domain of the requesting application as referer to Speech recognizer.
BUG=519883
Review URL: https://codereview.chromium.org/1272643006
Cr-Commit-Position: refs/heads/master@{#342987}
Add test that service workers stay alive after handling a push event.
Facebook relies on this implementation detail. Until we can support their use
case with a proper API/functionality we should make sure we don't break them.
BUG=517817
Review URL: https://codereview.chromium.org/1286103003
Cr-Commit-Position: refs/heads/master@{#342986}
Roll src/third_party/WebKit 5b4a17b:9bfbfc4 (svn 200367:200380)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5b4a17b..9bfbfc4
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285093002
Cr-Commit-Position: refs/heads/master@{#342985}
Rename BasicURLRequestContext.
The name "BasicURLRequestContext" is misleading, as it is *more* than
just a URLRequestContext. Instead, it's a URLRequestContext with added
storage to contain owned-pointers to the context's components.
This rename better reflects that distinction.
BUG=none
Review URL: https://codereview.chromium.org/1273363006
Cr-Commit-Position: refs/heads/master@{#342984}
Remove remaining legacy SplitString calls.
[email protected] (chromeos)
Review URL: https://codereview.chromium.org/1284833004
Cr-Commit-Position: refs/heads/master@{#342983}
Revert of Upstream iOS implementation of Autocomplete factories. (patchset #2 id:20001 of https://codereview.chromium.org/1277543003/ )
Reason for revert:
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ios/chrome/browser/autocomplete/ios_chrome_browser.autocomplete_scheme_classifier_impl.armv7.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=242792-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_CONFIGURATION_POLICY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DFIELDTRIAL_TESTING_ENABLED -DDISABLE_FTP_SUPPORT=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DUSE_SYSTEM_LIBXML -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=0 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNS_BLOCK_ASSERTIONS=1 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I/Applications/Xcode6.3.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS8.3.sdk/usr/include/libxml2 -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../breakpad/src -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/dist/proto_gen -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -Igen/components/strings -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -isysroot /Applications/Xcode6.3.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS8.3.sdk -Os -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -miphoneos-version-min=7.0 -arch armv7 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/iOS_Device__ninja_/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -c ../../ios/chrome/browser/autocomplete/autocomplete_scheme_classifier_impl.mm -o obj/ios/chrome/browser/autocomplete/ios_chrome_browser.autocomplete_scheme_classifier_impl.armv7.o
../../ios/chrome/browser/autocomplete/autocomplete_scheme_classifier_impl.mm:20:27: error: no member named 'StringToLowerASCII' in namespace 'base'
DCHECK_EQ(scheme, base::StringToLowerASCII(scheme));
~~~~~~^
Original issue's description:
> Upstream iOS implementation of Autocomplete factories.
>
> Provide iOS implementation for AutocompleteClassifier, InMemoryURLIndex
> and ShortcutsBackend factories as BrowserStateKeyedServiceFactory.
>
> Provide iOS implementation for AutocompleteProviderClient and
> AutocompleteSchemeClassifier.
>
> BUG=516635
>
> Committed: https://crrev.com/a3e5ce5bf10b96e24dd4e0440606336f362c3235
> Cr-Commit-Position: refs/heads/master@{#342981}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516635
Review URL: https://codereview.chromium.org/1286123003
Cr-Commit-Position: refs/heads/master@{#342982}
Upstream iOS implementation of Autocomplete factories.
Provide iOS implementation for AutocompleteClassifier, InMemoryURLIndex
and ShortcutsBackend factories as BrowserStateKeyedServiceFactory.
Provide iOS implementation for AutocompleteProviderClient and
AutocompleteSchemeClassifier.
BUG=516635
Review URL: https://codereview.chromium.org/1277543003
Cr-Commit-Position: refs/heads/master@{#342981}
Set TabCreationState lazily in DocumentTab
DocumentTab didn't provide TabCreationState to ChromeTab on other case than restoring frozen tab.
That disables entire UMA collection on the tab.
This CL calculates TabCreationState and initializes TabUma after DocumentTab initialization, so that the tab UMA works correctly.
BUG=517335
Review URL: https://codereview.chromium.org/1280923002
Cr-Commit-Position: refs/heads/master@{#342980}
[Android] Remove unused code in content
This change takes care of cleaning unused and
dead code from content/ files.
BUG=
Review URL: https://codereview.chromium.org/1283843004
Cr-Commit-Position: refs/heads/master@{#342979}
ffmpeg_cdm_video_decoder: s/PIX_FMT/AV_PIX_FMT/
+ PixelFormat -> AVPixelFormat
the versions without a prefix have been deprecated for a few years.
BUG=519105
Review URL: https://codereview.chromium.org/1284793003
Cr-Commit-Position: refs/heads/master@{#342978}
Support SizeClassIdiom on iOS7.
The UITraitEnvironment protocol was not introduced until iOS8, so this
CL creates GetCurrent[Width/Height]SizeClass() functions to ascertain
the size class for use in iOS7.
BUG=519568
Review URL: https://codereview.chromium.org/1282873003
Cr-Commit-Position: refs/heads/master@{#342977}
Add UMAs to measure Android tab state transition
This CL adds TabStateTransferTime and TabStateTransferTarget metrics to Android Chrome.
The metric helps us to predicate which tab is likely to be revisited.
BUG=517335
Review URL: https://codereview.chromium.org/1280293002
Cr-Commit-Position: refs/heads/master@{#342976}
Roll src/third_party/WebKit dc341f2:5b4a17b (svn 200361:200367)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dc341f2..5b4a17b
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1287873002
Cr-Commit-Position: refs/heads/master@{#342975}
Implement blink::Platform::isLowEndDeviceMode()
We enable low end device mode when base::SysInfo::IsLowEndDevice() is
true.
(Blink side CL: https://codereview.chromium.org/1286873002/)
BUG=519146
Review URL: https://codereview.chromium.org/1287813002
Cr-Commit-Position: refs/heads/master@{#342974}
ffmpeg_common: s/PIX_FMT/AV_PIX_FMT/
+ PixelFormat -> AVPixelFormat
the versions without a prefix have been deprecated for a few years
BUG=519105
Review URL: https://codereview.chromium.org/1287533003
Cr-Commit-Position: refs/heads/master@{#342973}
Roll src/third_party/lss 6f97298..4fc9422
This includes the change:
MIPS Android: use asm/sgidefs.h instead of sgidefs.h
which fixes a compile error on MIPS Android.
BUG=512384
Review URL: https://codereview.chromium.org/1286073002
Cr-Commit-Position: refs/heads/master@{#342972}
[chromedriver] When tracking execution contexts, ignore dummy frames.
This reduces flakiness for tests which create a new window and switch to it
mid-way through the page load. Recently, testCanLaunchApp from run_py_tests.py
has been flaky for this reason.
The problem occurs when we switch to a new window that is part-way through the
page load. When the page loading state is unknown, we append a dummy frame to
the page and observe the resulting DevTools events. When the dummy frame is
deleted, so is it's execution context, and if this is the only execution context
that ChromeDriver knows about, it will think a new navigation is pending and
hang.
BUG=chromedriver:1167
[email protected]
Review URL: https://codereview.chromium.org/1287823002
Cr-Commit-Position: refs/heads/master@{#342971}
Revert "[Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher"
This reverts commit a7fc1264e00391787a5c473255c39d4bfbd4bc90.
Reverting to allow reverting the Blink-side patch r200277
https://codereview.chromium.org/1264913002/ which is suspected
of breaking webkit_unit_tests test
CompositorWorkerManagerTest.CreatingSecondDuringTerminationOfFirst
BUG=501569
TBR=annekao,rdevlin.cronin
NOTRY=true
Review URL: https://codereview.chromium.org/1288583003
Cr-Commit-Position: refs/heads/master@{#342970}
Updating trunk VERSION from 2480.0 to 2481.0
Cr-Commit-Position: refs/heads/master@{#342969}
Remove generated .rc files that seem not to be used.
Most grit-generated .rc files are bitrooted and the ones removed in this patch seem not to be used.
This removes the uses of blink_resources.rc. I will remove the generator for this in the WebKit repo in a follow-up.
Review URL: https://codereview.chromium.org/1286023002
Cr-Commit-Position: refs/heads/master@{#342968}
Allow preloaded pins to contain report URIs; remove special-case reporting
This CL processes report URIs in preloaded pins and removes special-case code
for reporting pin violations on Google properties
(FraudulentCertificateReporter and its implementation
ChromeFraudulentCertificateReporter), in favor of a preloaded report
URI.
BUG=445793
Review URL: https://codereview.chromium.org/1267383002
Cr-Commit-Position: refs/heads/master@{#342967}
Move a MediaCodecBridge log
It's not necessarily an error for MediaCodec#dequeueInputBuffer
to return INFO_TRY_AGAIN_LATER, so move the log statement to the
caller.
BUG=519669
Review URL: https://codereview.chromium.org/1281693005
Cr-Commit-Position: refs/heads/master@{#342966}
[telemetry][Android] Tear everything down on Browser creation failure.
BUG=
Review URL: https://codereview.chromium.org/1282903005
Cr-Commit-Position: refs/heads/master@{#342965}
Gallery: show no-images error banner in thumbnail mode.
BUG=517828
TEST=browser_tests:GalleryBrowserTest.DeleteAllImagesInThumbnailModeOn(Downloads|Drive)
Review URL: https://codereview.chromium.org/1272063003
Cr-Commit-Position: refs/heads/master@{#342964}
ffmpeg_aac_bitstream_converter: s/CODEC_ID_AAC/AV_CODEC_ID_AAC/
BUG=519105
Review URL: https://codereview.chromium.org/1287563002
Cr-Commit-Position: refs/heads/master@{#342963}
Improve scroll performance on Windows 10 with high precision touchpads.
Chrome scrolling performance on Windows 10 with high precision touch pads, is very janky and jumpy.
Windows 10 introduces a new API called Direct Manipulation which allows consumers to support smooth
scrolling, panning etc. Mouse wheel messages are dispatched differently based on whether the window
is a Direct manipulation consumer. Microsoft recommends supporting Direct Manipulation on Windows 10
and above.
This is an intial patch to do the bare minimum to register Chrome as a Direct Manipulation consumer.
The associated functionality is provided by the newly added DirectManipulationHelper class which lives
as a member of the LegacyRenderWidgetHostHWND class which ensures that these changes are isolated cleanly.
This does smoothen scrolling on these devices. However there is still work to be done
BUG=517183,517187
Review URL: https://codereview.chromium.org/1283913002
Cr-Commit-Position: refs/heads/master@{#342962}
Update V8 to version 4.6.67.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e348bba6..686ae506
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1283123002
Cr-Commit-Position: refs/heads/master@{#342961}
Roll src/third_party/WebKit 4d062fa:dc341f2 (svn 200356:200361)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4d062fa..dc341f2
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1284063002
Cr-Commit-Position: refs/heads/master@{#342960}
[Telemetry] Isolate the unittest for creating and removing trace config file
BUG=516056
Review URL: https://codereview.chromium.org/1287723003
Cr-Commit-Position: refs/heads/master@{#342959}
Creates BreakIterator::GetWordBreakStatus.
For multilingual spellchecking, we need a function to tell us the
current state of the iterator so we know what the spellchecker needs to
pay attention to. That is, we need to know if we've found a word or
characters that can be skipped over.
TEST=*Skippable*
TEST=*BreakStatus*
BUG=5102
Review URL: https://codereview.chromium.org/1272683002
Cr-Commit-Position: refs/heads/master@{#342958}
Changed behavior when no files require coverage.
The android_coverage recipe expects a result file to be saved to the --out directory
regardless of if there were files requiring code coverage or not. If no files
require coverage, the script will now save an empty object to the output
file instead of returning early.
BUG=
Review URL: https://codereview.chromium.org/1290593002
Cr-Commit-Position: refs/heads/master@{#342957}
projects whose .cc files include skia headers need to explicitly depend on skia
This CL fixes a block to (re)landing https://codereview.chromium.org/1289483002
BUG=skia:4190
[email protected]
Review URL: https://codereview.chromium.org/1274953007
Cr-Commit-Position: refs/heads/master@{#342956}
Turn off -Wl,-z,defs and -fno-rtti when building with CFI diagnostics.
The CFI diagnostic mode requires a runtime library, so we need to disable
-Wl,-z,defs in order to allow DSOs to link with undefined references to the
runtime library, as we do for the other sanitizers which require runtime
libraries.
The diagnostic mode can also issue better diagnostics if RTTI is enabled,
so enable RTTI if the diagnostic mode is enabled.
BUG=512614
[email protected]
Review URL: https://codereview.chromium.org/1243373003
Cr-Commit-Position: refs/heads/master@{#342955}
[Presentation API] Add missing field initialization to
AvailabilityStatus.
Initialize listening_state to INACTIVE in AvailabilityStatus ctor.
BUG=510814
Review URL: https://codereview.chromium.org/1288563002
Cr-Commit-Position: refs/heads/master@{#342954}
Disable warnings when compiling //net/third_party/nss/ssl on iOS.
net/third_party/nss/ssl/sslmutex.c uses sem_init/sem_destroy that
are deprecated (not supported in fact) on iOS. Disable the warning.
BUG=459705
Review URL: https://codereview.chromium.org/1275403003
Cr-Commit-Position: refs/heads/master@{#342953}
build: Enable flags for better stack traces in non-official CFI builds.
BUG=464797
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1289673002
Cr-Commit-Position: refs/heads/master@{#342952}
Roll src/third_party/skia 2ccdb63:a387a11
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2ccdb63..a387a11
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
a387a11 [email protected] Make GrBatch carry its own GrPipeline
3bff474 [email protected] Hopefully fix ios bots BUG=skia:
Review URL: https://codereview.chromium.org/1287743002
Cr-Commit-Position: refs/heads/master@{#342951}
Gate Android Spellchecker behind a chrome switch
This change will reduce/negate the amount of spellchecker IPC
performance overhead encountered when the user hasn't enabled Clank's
Android spellchecker.
BUG=415302
Review URL: https://codereview.chromium.org/1281633002
Cr-Commit-Position: refs/heads/master@{#342950}
Optimize RTL check in ICU to avoid mmap access.
Experiment suggests that we can improve Extensions.ExtensionServiceInitTime
by 15% @ the 75-th percentile by avoiding this mmap access.
Review URL: https://codereview.chromium.org/1281343003
Cr-Commit-Position: refs/heads/master@{#342949}
Revert of Move NumberOfPlanesForGpuMemoryBufferFormat to gfx (patchset #4 id:120001 of https://codereview.chromium.org/1281043006/ )
Reason for revert:
This breaks Win 64 builds:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN
Original issue's description:
> Move NumberOfPlanesForGpuMemoryBufferFormat to gfx
>
> We will need to call it from media::GpuMemoryBufferVideoFramePool when we
> add support for YUV_420_BIPLANAR.
>
> BUG=510260
> TEST=No behavior change, only moving code.
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/85f29861d095a7c5dcf318053e8349d1efaddbab
> Cr-Commit-Position: refs/heads/master@{#342942}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510260
Review URL: https://codereview.chromium.org/1291643002
Cr-Commit-Position: refs/heads/master@{#342948}
Changes lifetime of ApplicationConnection instances.
Before this change, ApplicationConnections were owned by the ApplicationImpl, one created for every call to ConnectToApplication/AcceptConnection. While this makes sense for incoming connections (it doesn't make sense to transfer ownership of the connection to the delegate), it doesn't for outgoing connections.
So we change ConnectToApplication to return a scoped_ptr<ApplicationConnection> which the caller must manage.
[email protected]
http://crbug.com/519583
Review URL: https://codereview.chromium.org/1254383016
Cr-Commit-Position: refs/heads/master@{#342947}
Avoid partial rows of most visited icons on the NTP.
This limits the number of rows of most visited tiles that will be
displayed on the new tab page, and hence ensures that we don't show
partial rows.
Previously on narrow devices, we'd show 8 tiles over three rows, which
feels unbalanced. Now we show just 2 rows (which happens to be 6 tiles).
In non-Google mode, we show 3 rows (up to 12 tiles).
Before:
X X X
X X X
X X
After:
X X X
X X X
BUG=504367
Review URL: https://codereview.chromium.org/1275083003
Cr-Commit-Position: refs/heads/master@{#342946}
Reland of ll WebRTC 9687:9699, Libjingle 9690:9699 (patchset #1 id:1 of https://codereview.chromium.org/1278033005/ )
Reason for revert:
The WebRTC roll is not the cause of the failing tests.
BUG=519610
Original issue's description:
> Revert of Roll WebRTC 9687:9699, Libjingle 9690:9699 (patchset #1 id:1 of https://codereview.chromium.org/1285843002/ )
>
> Reason for revert:
> Looks like this is failing tests. Not sure why it's green in the CQ.. but here's the bug. Let's see if this fixes it: https://code.google.com/p/chromium/issues/detail?id=519610
>
> Original issue's description:
> > Roll WebRTC 9687:9699, Libjingle 9690:9699
> >
> > WebRTC 9687:9699
> >
> > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/380f11e..09346f1
> >
> > Libjingle 9690:9699
> >
> > Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/cc9de75..4dd92ac
> >
> > TBR=tommi
> >
> > Committed: https://crrev.com/888bbf99a19d08f09b95cb5fdfbf1e80d8a979d6
> > Cr-Commit-Position: refs/heads/master@{#342829}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/6a2d1066d7ab5bd4e6c1d3b5bf36a22c0aa95bfa
> Cr-Commit-Position: refs/heads/master@{#342848}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1285013003
Cr-Commit-Position: refs/heads/master@{#342945}
Roll src/third_party/WebKit e353f22:4d062fa (svn 200353:200356)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e353f22..4d062fa
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285003002
Cr-Commit-Position: refs/heads/master@{#342944}
[MD settings] merge polymer 1.0.11; hack for settings checkbox
This is a bower update of Polymer with the current
bower.json settings. I'd like to change the bower.json
settings to bring in more polymer elements. As a
precursor to that, this CL brings the current Polymer
elements up to date (without adding more elements).
While doing some brief testing, I found that the
paper-checkbox had changed in a way the broke the
settings-checkbox. It looks like the settings-checkbox
should be updated/changed to cope, but that is beyond
the scope of this CL. This CL includes a small hack
to fix the settings checkbox along with comments/notes
about the hack and what to do to remove the hack.
BUG=
Review URL: https://codereview.chromium.org/1287713002
Cr-Commit-Position: refs/heads/master@{#342943}
Move NumberOfPlanesForGpuMemoryBufferFormat to gfx
We will need to call it from media::GpuMemoryBufferVideoFramePool when we
add support for YUV_420_BIPLANAR.
BUG=510260
TEST=No behavior change, only moving code.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1281043006
Cr-Commit-Position: refs/heads/master@{#342942}
Fixes coordinate transforms in html_viewer
blink is dip based, views is not. So, we have to be careful when
converting between the two.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1291573002
Cr-Commit-Position: refs/heads/master@{#342941}
Basic integration test case for MR popup dialog.
This test doesn't cover route detail dialog, since I don't know how to
get the object model for route detail dialog, added a TODO for that.
Moreover, it also doesn't cover the failure case, since IssueManager
hasn't been implemented, we should add failure cases to cover it once
IssueManager has been done.
BUG=464227
Review URL: https://codereview.chromium.org/1244993002
Cr-Commit-Position: refs/heads/master@{#342940}
Connects PostMessage() for OOPIFs
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1270313006
Cr-Commit-Position: refs/heads/master@{#342939}
Fix up #ifdefs in crypto/encryptor.h.
This was causing scoped_nss_types.h to be incorrectly included in the chimera
build. (No actual consequence. The header is legal in the chimera, it's just
unnecessary.)
BUG=none
Review URL: https://codereview.chromium.org/1281033003
Cr-Commit-Position: refs/heads/master@{#342938}
Check first run finished before custom tabs feature is used
This avoid connecting to custom tabs service or launching a
custom tab before
the user acknowledges ToS.
BUG=515654
Review URL: https://codereview.chromium.org/1274953006
Cr-Commit-Position: refs/heads/master@{#342937}
[MD settings] Adding mock version of site settings
This CL adds a rough version of the site settings mock up. This is a small step toward a new version of Site Settings.
BUG=517564
Review URL: https://codereview.chromium.org/1280533002
Cr-Commit-Position: refs/heads/master@{#342936}
Re-enable AudioPlayTillCompletion test with logs
Added logs to try to debug on the bot.
TBR=qinmin@
BUG=518900
Review URL: https://codereview.chromium.org/1282713004
Cr-Commit-Position: refs/heads/master@{#342935}
[Download Notification] Set priority to each notification
This patch sets appropriate proprieties to each notification.
BUG=518033
TEST=none
Review URL: https://codereview.chromium.org/1280363003
Cr-Commit-Position: refs/heads/master@{#342934}
Fire layout complete on root to update client on selection attributes.
BUG=519758
Review URL: https://codereview.chromium.org/1289623003
Cr-Commit-Position: refs/heads/master@{#342933}
Fix DevToolsFrameTraceRecorder to match timestamp to contents
We used to wait for extra frame (i.e. defer requesting pixels till next
SwapBuffers) after fixing timestamp and meta-data. Turns out this is
wrong in case of browser compositor, since CopyFromCompositingSurface() requests future pixels, not
past ones -- so introduce a different code path where we always use latest timestamp and meta-data.
BUG=
Review URL: https://codereview.chromium.org/1277133005
Cr-Commit-Position: refs/heads/master@{#342932}
Revert of Adds multilingual support to the language_options_handler. (patchset #6 id:210001 of https://codereview.chromium.org/1280793003/ )
Reason for revert:
Speculative revert for Linux GN failures.
BUG=519860
Original issue's description:
> Adds multilingual support to the language_options_handler.
>
> BUG=5102
>
> Committed: https://crrev.com/d649b32ddb1c8e8c39fb1402c9e471c12f0a15e9
> Cr-Commit-Position: refs/heads/master@{#342901}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=5102
Review URL: https://codereview.chromium.org/1284013002
Cr-Commit-Position: refs/heads/master@{#342931}
Attempt to fix migration again
Hold onto the Callbacks in a static list. Add logs to see the order
in which things are being finalized.
BUG=513130
Review URL: https://codereview.chromium.org/1291523002
Cr-Commit-Position: refs/heads/master@{#342930}
Skip all trace tests for flakiness.
Beginning around 7/31 this test has become increasingly flaky on the
bots. This hasn't been reproducable locally so I am forced to
disable the tests.
[email protected]
BUG=517232
Review URL: https://codereview.chromium.org/1274933002
Cr-Commit-Position: refs/heads/master@{#342929}
gpu: Crash GPU process when context was lost through robustness
This works around both recovery problems in drivers as well as
in our recovery flow (480545).
Note that this is already the default behavior on Windows.
BUG=458269,475676,503414,480545
Review URL: https://codereview.chromium.org/1282973004
Cr-Commit-Position: refs/heads/master@{#342928}
Launch tab muting via context menu command.
Enables tab mute/unmute via the tabstrip context menu as on-by-default
behavior. The audio icon click and extension API remain enabled-by-
experiment only for now.
BUG=360372,438903
TEST=New Mute/Unmute tab context menu item appears and mutes/unmutes selected tab(s). Clicking the audio icon does NOT mute/unmute the tab when the chrome://flags#enable-tab-audio-muting experiment is disabled.
Review URL: https://codereview.chromium.org/1256103003
Cr-Commit-Position: refs/heads/master@{#342927}
Change views external protocol handler dialog to be tab modal.
This also fixes a DCHECK in CreateBrowserModalDialogViews when showing the dialog.
BUG=517758
Review URL: https://codereview.chromium.org/1278053003
Cr-Commit-Position: refs/heads/master@{#342926}
Unflake CustomTabTests
We were adding an observer and eaiting for pageLoadFinished without
first checking that it has already finished. This only waits
if the page isn't loading
BUG=519613
Review URL: https://codereview.chromium.org/1278403008
Cr-Commit-Position: refs/heads/master@{#342925}
Allow intent picker for external schemes
For urls that chrome can handle, a custom tab will not fire the intent
picker. Yet for urls with heterogeneous schemes, chrome cannot load
anyway. In this case, we should show an intent picker, in stead of doing
nothing.
BUG=513522
Review URL: https://codereview.chromium.org/1282063003
Cr-Commit-Position: refs/heads/master@{#342924}
Roll src/third_party/skia 7cdfa8a:2ccdb63
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7cdfa8a..2ccdb63
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
2ccdb63 [email protected] SkPDF: clean up overuse of SK_SUPPORT_PDF
fcaaade [email protected] Switching Skia to chromium's libjpeg-turbo
Review URL: https://codereview.chromium.org/1281503005
Cr-Commit-Position: refs/heads/master@{#342923}
Revert of Gets //mandoline passing gn check (patchset #1 id:1 of https://codereview.chromium.org/1278803006/ )
Reason for revert:
Broke android http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/29201
Original issue's description:
> Gets //mandoline passing gn check
>
> BUG=none
> TEST=none
> [email protected]
>
> Committed: https://crrev.com/c202fc81d0b4931cb928672e5cd226e51e501ea9
> Cr-Commit-Position: refs/heads/master@{#342890}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/1287733002
Cr-Commit-Position: refs/heads/master@{#342922}
Disable more AppBannerDataFetcherBrowserTests
These are flaking on Win7:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40732
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40733
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40747
BUG=517307
[email protected]
Review URL: https://codereview.chromium.org/1289653002 .
Cr-Commit-Position: refs/heads/master@{#342921}
Removed unused mojo_nacl code and GYP targets.
There are subtle generated dependency issues breaking
several bots. The code is upstream in the Mojo repo
at this point and we have no need for the GYP targets
in the foreseeable future.
BUG=519643
[email protected]
Review URL: https://codereview.chromium.org/1279133006
Cr-Commit-Position: refs/heads/master@{#342920}
Roll src/third_party/WebKit 6b9d962:e353f22 (svn 200347:200353)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6b9d962..e353f22
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285743004
Cr-Commit-Position: refs/heads/master@{#342919}
Use the upper-case 'CLEAR FORM' string for keyboard accessory.
BUG=428087
Review URL: https://codereview.chromium.org/1277213004
Cr-Commit-Position: refs/heads/master@{#342918}
Let build/vs_toolchain.py run on non-Windows if requested.
If `build/vs_toolchain.py update --force` is run once on non-Windows, the
script will start keeping a Windows toolchain in depot_tools up-to-date, and
it'll copy runtime dlls into the build directory, and so on. (One can delete
build/win_toolchain.json to disable this behavior again.)
Depends on https://codereview.chromium.org/1284723006
BUG=495204
Review URL: https://codereview.chromium.org/1277913006
Cr-Commit-Position: refs/heads/master@{#342917}
Let client specify content description for custom action button
Per accessibility review, the custom action button should always carry
meaningful content description. This CL adds a key for the custom button
bundle in intent.
BUG=516465
Review URL: https://codereview.chromium.org/1263573011
Cr-Commit-Position: refs/heads/master@{#342916}
Add more track buffer logging to SourceBufferStream.
Track buffer state is useful for debugging issues with MSE playback
when players append media who's timeline overlaps that of previous
appends.
BUG=spawned from discussion of internal b/23015270
Review URL: https://codereview.chromium.org/1273123003
Cr-Commit-Position: refs/heads/master@{#342915}
[Mac] Add gfx::ScreenPoint[To|From]NSPoint.
Similarly to ScreenRect[To|From]NSRect, we want to avoid a proliferation of the
following patterns for doing this conversion:
gfx::Point point(ns_point.x,
NSMaxY([[[NSScreen screens] objectAtIndex:0] frame]) - ns_point.y);
Or alternatively, creating an NSRect, converting with gfx::ScreenRectFromNSRect(),
and taking the origin.
BUG=None
Review URL: https://codereview.chromium.org/1287573002
Cr-Commit-Position: refs/heads/master@{#342914}
Cleanup NQE
Make NetworkQuality private. Remove NetworkQuality from all
public APIs since we decided to have a separate Getter for
each metric.
Future CL will template the Observations/Estimates.
BUG=502415,519637
Committed: https://crrev.com/402963c809947a9a53983cadfcb91b63e3ac87e7
Cr-Commit-Position: refs/heads/master@{#342851}
Review URL: https://codereview.chromium.org/1277483004
Cr-Commit-Position: refs/heads/master@{#342913}
Roll libjpeg_turbo to git hash 631e2dd119d49794e3572b6ca3f16ee39d59f372
Roll libjpeg_turbo for "Patch fix for add jpeg_skip_scanlines() API to libjpeg-turbo"
from https://codereview.chromium.org/1271803002
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
BUG=515694,468914
Review URL: https://codereview.chromium.org/1277913005
Cr-Commit-Position: refs/heads/master@{#342912}
Adds OWNERS file for content/test/data.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1287433002
Cr-Commit-Position: refs/heads/master@{#342911}
Update key_mobile_sites Wikipedia pages to HTTPS.
PERF SHERIFFS: This may cause a change in the performance numbers for
Wikipedia, which will hopefully be reflected in the reference build.
BUG=519034
Review URL: https://codereview.chromium.org/1274333003
Cr-Commit-Position: refs/heads/master@{#342910}
Exclude TrayIMETest.PerformActionOnDetailedView under valgrind, where it crashes.
BUG=516898
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1278803007
Cr-Commit-Position: refs/heads/master@{#342909}
mac, GN: Pass 10.6 as deployment target.
Previously, GN was using the sdk version as the deployment target,
which meant gn-built binaries couldn't run on OS X versions
older than 10.10 after updating the SDK to 10.10.
With this fix, mac GN matches the behavior of Mac GYP.
BUG=463170
Review URL: https://codereview.chromium.org/1285493004
Cr-Commit-Position: refs/heads/master@{#342908}
Separate RenderSurfaceLayerList Generation CalcDrawProps
Use a separate walk to generate RenderSurfaceLayerList that is not
tangled with CalcDrawProps. After CalcDrawProps or its PropertyTrees
equivalence, remove layers that do not draw content from
RenderSurfaceLayerList.
RenderSurfaceLayerList is now only generated on compositor thread when
we are about to draw.
BUG=504466
R=enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1266103002
Cr-Commit-Position: refs/heads/master@{#342907}
Use extension id key to fix ChromeContentRulesRegistry::RemoveAllRulesImpl crash
Revert to using an extension id in the rule storage key. This avoids
having to look up the extension from the id when removing rules, which
can occur on extension update and uninstall. At that point they've been
removed from the ExtensionRegistry and GetInstalledExtension returns
null.
Also don't evaluate rules on remove, since we already are calling the
revert action on any removed rules that are active. And request rule
evaluation on adding rules rather than immediately evaluating them, so
we don't run the same rule's actions twice when a condition tracker
requests rule evaluation.
BUG=517492
Review URL: https://codereview.chromium.org/1278983004
Cr-Commit-Position: refs/heads/master@{#342906}
Speculative crash fix.
Check that native autocomplete controller hasn't been destroyed before
calling classify.
BUG=492509
Review URL: https://codereview.chromium.org/1277713003
Cr-Commit-Position: refs/heads/master@{#342905}
Update V8 to version 4.6.66.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1d0b8962..e348bba6
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1274373004
Cr-Commit-Position: refs/heads/master@{#342904}
Fling boost check last animate time
Due to android webview quirk, fling can be stuck for a long time
without animate events. In that case, fling boost will cause the next
scroll in the same direction to be ignored.
Workaround this problem by checking the last animate timestamp from last
animate when checking whether to enter fling boost mode.
BUG=519075
Review URL: https://codereview.chromium.org/1270283004
Cr-Commit-Position: refs/heads/master@{#342903}
Add tests for native app banners triggered via URLs in manifest.
This CL also adds verificaton of the referrer value that is now
passed to the AppDetailsDelegate during the store query.
BUG=503226
Review URL: https://codereview.chromium.org/1288453002
Cr-Commit-Position: refs/heads/master@{#342902}
Adds multilingual support to the language_options_handler.
BUG=5102
Review URL: https://codereview.chromium.org/1280793003
Cr-Commit-Position: refs/heads/master@{#342901}
Fix reconcilor loop when the primary account is in an auth error state.
This CL changes the reconcilor to not merge accounts which are known to be in some kind of auth error state. If they are not present in the gaia cookie, their absence will not trigger a new reconcile cycle.
Added tests to help detect new code that may introduce a loop.
BUG=516070
Review URL: https://codereview.chromium.org/1267843003
Cr-Commit-Position: refs/heads/master@{#342900}
Revert incorrect part of https://codereview.chromium.org/1250913002.
BUG=459705
Review URL: https://codereview.chromium.org/1285943002
Cr-Commit-Position: refs/heads/master@{#342899}
Update Media Router blocking issue style.
This change includes:
- Remove sad face icon.
- Only show the issue message for blocking issues.
- Update tests.
Changes (pixels, colors, icons) taken from redlines or from offline conversation with UX.
BUG=501452
Review URL: https://codereview.chromium.org/1279423002
Cr-Commit-Position: refs/heads/master@{#342898}
ipc: Add the class HandleWin.
HandleWin is a wrapper around a Windows HANDLE that can be transported across
IPC channels that support attachment brokering. The attachment broker is
responsible for duplicating the HANDLE into the destination process.
BUG=493414
Review URL: https://codereview.chromium.org/1281083004
Cr-Commit-Position: refs/heads/master@{#342897}
Fix the way MB invokes the GYP analyzer.
Also fix a previously broken unittest, add a new unittest, and
make sure the unittests and pylint are run as part of the
presubmit checks.
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1279093004
Cr-Commit-Position: refs/heads/master@{#342896}
Remove net_resources.rc
This seems to not be used.
Review URL: https://codereview.chromium.org/1281483012
Cr-Commit-Position: refs/heads/master@{#342895}
Roll src/third_party/skia 8ee06f2:7cdfa8a
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8ee06f2..7cdfa8a
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
7cdfa8a [email protected] decrement lockcount if we failed to get pixels
4d0d81a [email protected] Add high resolution WallTimer to SampleApp
Review URL: https://codereview.chromium.org/1282693004
Cr-Commit-Position: refs/heads/master@{#342894}
Roll src/third_party/WebKit d47b538:6b9d962 (svn 200340:200347)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d47b538..6b9d962
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285733003
Cr-Commit-Position: refs/heads/master@{#342893}
Reduce DefaultConcurrentLinks from phys/4GB to phys/5GB.
This is copied from the gyp repo, ninja.py:
https://codereview.chromium.org/1255813005
VS 2015 uses about 20% more memory when linking. This caused a
severe page-fault storm on my development machine and subsequent tests
showed that linking could use ~63 GB of RAM (15 parallel links on a
64 GB machine). This suggests that VS 2013 would also be using a lot
of RAM (52.5 GB?) such that very little was left for other
applications or disk cache.
Linker working sets vary wildly but with VS 2013 there are six links
that use over 6 GB of working set and with VS 2015 there are seven.
This change reduces parallel links by 20% (increase RAM-per-linker by
25%). The value can be overridden by setting GYP_LINK_CONCURRENCY.
Tests with VS 2013 showed no statistically significant change in
build times when link concurrency was reduced from 15 to 10 or 12.
Further reductions may be prudent when we switch to VS 2015.
BUG=440500
[email protected]
Review URL: https://codereview.chromium.org/1261073004
Cr-Commit-Position: refs/heads/master@{#342892}
Inform TalkBack users about location of InfoBars
This fixes bug 517642 by adding an AccessibilityEvent that tells the
user where InfoBars can be found.
BUG=517642
Review URL: https://codereview.chromium.org/1278873003
Cr-Commit-Position: refs/heads/master@{#342891}
Gets //mandoline passing gn check
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1278803006
Cr-Commit-Position: refs/heads/master@{#342890}
Remove an unused function.
BUG=505316
Review URL: https://codereview.chromium.org/1275353004
Cr-Commit-Position: refs/heads/master@{#342889}
clang: Compiler tweaks to make android build for x64
BUG=402625
Review URL: https://codereview.chromium.org/1285623003
Cr-Commit-Position: refs/heads/master@{#342888}
Move logic of gyp_chromium into gyp_chromium.py
For historical reasons gyp_chromium.py was launcher script
for gyp_chromium and the python logic lived in the
gyp_chromium. This change moves python code into the
.py file makes the extension-free gyp_chromium a launcher
for gyp_chromium.py.
Review URL: https://codereview.chromium.org/1216863010
Cr-Commit-Position: refs/heads/master@{#342887}
Rename device_bluetooth_strings to bluetooth_strings.
Our translation process doesn't support xtb files that have a different
basename than their corresponding grd file. i.e. the xtb files for
bluetooth_strings.grd need to be named bluetooth_strings_fr.xtb, etc,
not device_bluetooth_strings_fr.xtb.
This discrepancy has prevented translations for bluetooth_strings.grd
from being copied into Chromium. This CL fixes that. (A future update to
the translation process will help prevent situations like this from
occurring silently in the future.)
BUG=518020
[email protected]
Review URL: https://codereview.chromium.org/1279393002
Cr-Commit-Position: refs/heads/master@{#342886}
[NaCl SDK] Convert sdk_update to use argparse
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
R=binji
Review URL: https://codereview.chromium.org/1290503002
Cr-Commit-Position: refs/heads/master@{#342885}
extensions: EventRouter: pass the whole event to WillDispatchCallback
This gives callbacks the ability to alter the filtering_info based on
the process and the event filters of a given listener.
BUG=518745
Review URL: https://codereview.chromium.org/1280013003
Cr-Commit-Position: refs/heads/master@{#342884}
[Courgette] Extract qsufsort module and add tests.
This is to prepare for a follow-up CL to optimize qsufsort(), which
reduces run time by ~40%, and "courgette -gen" run time by ~10%.
Review URL: https://codereview.chromium.org/1272453003
Cr-Commit-Position: refs/heads/master@{#342883}
Roll ANGLE 3dfcdcb..b4b0b48
https://chromium.googlesource.com/angle/angle.git/+log/3dfcdcb..b4b0b48
BUG=
TEST=bots
[email protected]
TBR=jmadill
Review URL: https://codereview.chromium.org/1282143004 .
Cr-Commit-Position: refs/heads/master@{#342882}
Revert of Update V8 to version 4.6.66. (patchset #1 id:1 of https://codereview.chromium.org/1283043002/ )
Reason for revert:
Failing gyp on win x64.
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/12672
FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x64 v8_external_snapshot_target_run_mksnapshot__external__93bfc5871b63718af434b4cbb478e06a..rsp ..\..\v8\tools\gyp
Original issue's description:
> Update V8 to version 4.6.66.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/1d0b8962..e348bba6
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
>
> [email protected],[email protected],[email protected],[email protected]
>
> Committed: https://crrev.com/0ec1cd853c92087053606929e6836fc5e5a49c50
> Cr-Commit-Position: refs/heads/master@{#342875}
[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1291493002
Cr-Commit-Position: refs/heads/master@{#342881}
Make extension error overlay remotely keyboard accessible
[email protected]
BUG=518053
Review URL: https://codereview.chromium.org/1275363003
Cr-Commit-Position: refs/heads/master@{#342880}
device_utils.Install: Calculate host md5s at the same time as device md5s
For ChromeModern.apk, this made adb_install_apk.py ~350ms faster on my
machine
BUG=
Review URL: https://codereview.chromium.org/1286763002
Cr-Commit-Position: refs/heads/master@{#342879}
Plumbing isolate-server and swarming-server up to the controller.
The isolate and swarming servers are consistent throughout a test run. Implicitly adding these values makes for a shorter command line when a test is launched.
BUG=
Review URL: https://codereview.chromium.org/1284893003
Cr-Commit-Position: refs/heads/master@{#342878}
Disable BrowserCloseManagerBrowserTest.TestAddTabWithBeforeUnloadDuringShutdown
The test is flaky.
[email protected]
BUG=519646
Review URL: https://codereview.chromium.org/1287683002 .
Cr-Commit-Position: refs/heads/master@{#342877}
[MacViews] Fix WidgetTest.CloseWidgetWhileAnimating on 10.10 SDK.
This fails with 10.10 SDK because moving a window to 0,0 will cause
it to be clamped so that it doesn't overlap the menu bar. For the
purposes of this test, just move the widget to 100,100.
BUG=378134
Review URL: https://codereview.chromium.org/1277783006
Cr-Commit-Position: refs/heads/master@{#342876}
Update V8 to version 4.6.66.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1d0b8962..e348bba6
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1283043002
Cr-Commit-Position: refs/heads/master@{#342875}
Revert of Cleanup NQE (patchset #5 id:80001 of https://codereview.chromium.org/1277483004/ )
Reason for revert:
Suspected in sizes failures
BUG=519637
Original issue's description:
> Cleanup NQE
>
> Make NetworkQuality private. Remove NetworkQuality from all
> public APIs since we decided to have a separate Getter for
> each metric.
>
> Future CL will template the Observations/Estimates.
>
> BUG=502415
>
> Committed: https://crrev.com/402963c809947a9a53983cadfcb91b63e3ac87e7
> Cr-Commit-Position: refs/heads/master@{#342851}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=502415
Review URL: https://codereview.chromium.org/1277183004
Cr-Commit-Position: refs/heads/master@{#342874}
Roll src/third_party/skia 4cf9e7e:8ee06f2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4cf9e7e..8ee06f2
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
8ee06f2 [email protected] SkPDF: allow PDF module to be disabled in DM and SampleApp
Review URL: https://codereview.chromium.org/1286653006
Cr-Commit-Position: refs/heads/master@{#342873}
Roll src/third_party/WebKit f2395b6:d47b538 (svn 200329:200340)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2395b6..d47b538
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1289543002
Cr-Commit-Position: refs/heads/master@{#342872}
Pass "client_id" param to the enrollment frame.
A "client_id" param passed to GAIA should match a "client_id" that is used for
token exchange afterwards, otherwise token exchange doesn't work. If the param
is not specified, GAIA uses default value, which is the same as official Google
Chrome's "client_id".
We didn't provide "client_id" for enrollment frame, as a result enrollment only
worked in official builds.
BUG=495527
TEST=browser_tests
Review URL: https://codereview.chromium.org/1282393002
Cr-Commit-Position: refs/heads/master@{#342871}
Reland #2: Switch the default build configuration to use the 10.10 SDK.
The first reland caused Webkit layout test errors on 10.8 and 10.9. Those
errors have been fixed.
Original issue's description:
> mac: Switch the default build configuration to use the 10.10 SDK.
>
> This change is intended to be temporary. The goal is to release a Canary
> compiled against the 10.10 SDK, and then to revert this CL.
>
> BUG=463170
>
> Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> Cr-Commit-Position: refs/heads/master@{#340992}
[email protected],[email protected]
BUG=463170, 515836
Review URL: https://codereview.chromium.org/1268803004
Cr-Commit-Position: refs/heads/master@{#342870}
Convert remaining StringToLowerASCII to ToLowerASCII.
Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.
http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
std::string old_header_name_lowercase(name);
where it actually meant
std::string old_header_name_lowercase(old_header_name);
I fixed this.
There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.
There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.
NOPRESUBMIT=true
(for touching code with wstrings)
Review URL: https://codereview.chromium.org/1282363003
Cr-Commit-Position: refs/heads/master@{#342869}
cc: Rebalance tree priorities in SMOOTHNESS_TAKES_PRIORITY
Instead of only rasterizing pending NOW tiles before active
EVENTUALLY tiles, rasterize ALL pending tiles before active
EVENTUALLY tiles.
After rasterizing all pending NOW tiles, we should activate
very soon and won't need the active EVENTUALLY tiles anyway.
BUG=515722
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1275703004
Cr-Commit-Position: refs/heads/master@{#342868}
If there are no local credentials for a locked profile, show sign in button
instead of password field. The user will need to reauth online.
BUG=514589
Review URL: https://codereview.chromium.org/1280813003
Cr-Commit-Position: refs/heads/master@{#342867}
Change precache tests to use HistogramTester.
This allows us to remove a bunch of setup code, makes the tests more
flexible to change in the future, and makes them catch future missing
expectations (by virtue of GetTotalCountsForPrefix).
BUG=
Review URL: https://codereview.chromium.org/1268323005
Cr-Commit-Position: refs/heads/master@{#342866}
Courgette: Remove 2 duplicates calls to std::sort.
There's already a call to std::sort at the end of ParseRelocs. It's a small improvement, but it's still better than nothing :)
BUG=
Review URL: https://codereview.chromium.org/1284733002
Cr-Commit-Position: refs/heads/master@{#342865}
[Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher
Pass the v8::context from the worker thread up to the extensions dispatcher. In the dispatcher, 42 is binded to "chrome" for testing purposes.
Please view https://codereview.chromium.org/1264913002/ for the implementation done in blink.
BUG=501569
Review URL: https://codereview.chromium.org/1256323008
Cr-Commit-Position: refs/heads/master@{#342864}
NaCl: Update revision in DEPS, f14a219 -> 3feb736
This pulls in the following Native Client changes:
ee7f00e: ([email protected]) Report Windows error number for Windows API call failures in thread suspension
5c25b40: ([email protected]) Enable tests/irt_ext for nacl_arm_glibc
0a70cae: ([email protected]) toolchain_build: Explicitly enable all *-nacl targets in binutils
e3b0ace: ([email protected]) Add nacl_dirent.h to the glibc toolchain
440d567: ([email protected]) Update revision for PNaCl
52251a6: ([email protected]) Added check to invalidate addresses within constant pools.
2560b80: ([email protected]) Refactored to remove port from NaClApp, eventually it will be removed entirely.
e35d791: ([email protected]) crash_dump: Fix addr2line output parsing wrt ':'
24d8bba: ([email protected]) validator_ragel: Cope with either line-ending style in run_dis_section_test
8e3dd44: ([email protected]) Default non-glibc SCons builds to nacl-clang
5494f48: ([email protected]) Deploy new nacl_arm_glibc toolchain
5a8384a: ([email protected]) Remove failure for bad mmap address hints.
d5e8cde: ([email protected]) Roll glibc revision in tools/REVISIONS
46bd63f: ([email protected]) toolchain_build: Update binutils and glibc revisions
a31019e: ([email protected]) Deploy new nacl_arm_glibc toolchain
76b0bd4: ([email protected]) Providing some missing POSIX file syscalls
a4f21af: ([email protected]) Fixes flag naming issues in Issue 1234393005: https://codereview.chromium.org/1234393005/
c6f3941: ([email protected]) Unbreaking the toolchain's newlib build
a8413cb: ([email protected]) Implemented new transport for chrome, currently only works with posix.
8ad7b08: ([email protected]) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
a8bd1a6: ([email protected]) Use goma only if --gomadir is set.
9d857b9: ([email protected]) pynacl/file_tools: use unlink if symlink, rmdir if truly a dir
e9d881b: ([email protected]) Update revision for PNaCl
88909c1: ([email protected]) Debug Stub: Always mask sp register on arm before processing packets.
55e0185: ([email protected]) Run gyp builds through compile.py on buildbot.
77df0bf: ([email protected]) Exclude more OS's from goma upload.
0a8a29e: ([email protected]) Don't use 'os' as a variable name...
338a251: ([email protected]) Making gsd uploads have a shorter overwrite window.
19f7f3b: ([email protected]) Debug Stub: Ensure breakpoints are on instr boundaries and not in constant pools.
86a2655: ([email protected]) Remove PNaCl's zero-cost exception support tests
9694cb7: ([email protected]) Remove dead symlinks when merging directories
029d7c4: ([email protected]) Remove PNaCl's zero-cost exception driver support
5d37f54: ([email protected]) Added bundle_lock sequences in arm setjmp implementation and test files
2a209e7: ([email protected]) [MIPS] Finetune the tests for nacl-clang
71a64d2: ([email protected]) PNaCl: Update newlib revision in pnacl/COMPONENT_REVISIONS
4b42863: ([email protected]) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
910b03a: ([email protected]) [MIPS] Follow the ARM method to detect virtual functions
d9cb3a2: ([email protected]) Debug Stub: Added support for arm valiation.
1d2dec3: ([email protected]) [MIPS] Get rid of "used $at without .set noat" warnings/errors
3feb736: ([email protected]) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/f14a2194a8dd85de9304c94d8563e24b7cd45bff..3feb736b8afecd43050c30049d405f824f284836
Remove SIGWINCH defintion from ossignal.h since the new arm/glibc toolchain
now defines this.
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
patch from issue 1281283002 at patchset 1 (http://crrev.com/1281283002#ps1)
Review URL: https://codereview.chromium.org/1281143003
Cr-Commit-Position: refs/heads/master@{#342863}
Fix switch in apptests file
I forgot the --
[email protected]
[email protected]
BUG=none
TEST=test only
Review URL: https://codereview.chromium.org/1285863002
Cr-Commit-Position: refs/heads/master@{#342862}
MSE: Warn when keyframe after track_buffer is significantly in future
Adds logging to chrome://media-internals when an overlapped append of
the currently playing GOP introduces significant delay until keyframe
following the end of the overlap.
Also adds a MockMediaLog and uses it in a StrictMock within
SourceBufferStreamTests to verify the new (and existing)
MediaLog events produced by SourceBufferStreamTests.
Visual example:
First append:
[K..t...........]
2nd append:
[K.......................................][*K....................]...
Since the buffer around 't' from first append is in the middle of being
decoded and rendered when the second append is done, the rest of the
first append's GOP is played and then the stream continues decode at the
next (*) keyframe in time in the 2nd append. The result is frozen video
frame (on the last PTS from the GOP containing t) until time of keyframe
at (*).
Note, once playback of the overlapped GOP containing t is completed, the
overlapped GOP is dropped, and only the buffered media from the second
append is available for replay upon seeking back.
BUG=518069
TEST=no regression. Internal b/23015270 repro demonstrates new log. Added
SourceBufferStreamTest.TrackBuffer_ExhaustionWithSkipForward and
SourceBufferStreamTest.TrackBuffer_ExhaustionAndImmediateNewTrackBuffer
Review URL: https://codereview.chromium.org/1281113002
Cr-Commit-Position: refs/heads/master@{#342861}
Cache device apk checksums in device_utils.py
On my machine, this brings the time to run:
bin/run_base_unittests --gtest-filter PathUtilsTest.TestGetDataDirectory
from ~18 seconds to ~15 seconds
BUG=
Review URL: https://codereview.chromium.org/1234153004
Cr-Commit-Position: refs/heads/master@{#342860}
Add a new SpdyStream::Delegate method to handle trailers
This CL adds a new SpdyStream::Delegate method to surface trailers to
Delegate's implementations. Before this CL, receiving trailers will trigger
a spdy protocol error. However, SpdyHttpStream does not implement
this delegate method as of this CL, so trailers are ignored.
BUG=481033
Review URL: https://codereview.chromium.org/1272283003
Cr-Commit-Position: refs/heads/master@{#342859}
Revert "Convert extensions::SafeBuiltins from a v8::Extension to a NativeHandler."
This reverts commit 68c06a78f74212907faafd985b0bdee67a6d4120.
It caused an iframe performance regression. I plan on re-landing this
after doing some profiling to figure out what exactly the problem is.
[email protected], [email protected]
BUG=517509, 383974
Review URL: https://codereview.chromium.org/1281793003
Cr-Commit-Position: refs/heads/master@{#342858}
Mac Overlays: Fix assert about fences
This code assumed that Destroy would be called before the destructor.
That was not true.
BUG=519122
Review URL: https://codereview.chromium.org/1274953005
Cr-Commit-Position: refs/heads/master@{#342857}
Add Precache.Latency.Overall metric.
This metric records the response latency for requests that don't occur
as part of precaching. The metric is computed in
ChromeNetworkDelegate::OnCompleted and logged in
PrecacheDatabase::RecordURLFetched.
Also, move HistoryService initialization to PrecacheManagerFactory. This is just cleanup now, but will be used in a future commit.
BUG=499532
Review URL: https://codereview.chromium.org/1278693002
Cr-Commit-Position: refs/heads/master@{#342856}
Remove focus event listeners from un-focusable node
This UI used to live in a world where its <ul> element had a tabindex=0
or something. No longer.
[email protected]
BUG=518053
Review URL: https://codereview.chromium.org/1273033004
Cr-Commit-Position: refs/heads/master@{#342855}
Linux: Depend on liberation-fonts package. (try 2)
Without these fonts, text in the built-in PDF viewer may not display
correctly.
Unfortunately we can only do this for the .deb packages at the moment.
There's no common liberation-fonts package for RPMs. See
https://crbug.com/519322.
BUG=369991
Review URL: https://codereview.chromium.org/1274043004
Cr-Commit-Position: refs/heads/master@{#342854}
Removing deprecated test fixtures
The test fixtures that were removed are:
WebTestBase
UIWebViewWebTest
WKWebViewWebTest
They have been renamed in favor of their respective
replacements.
BUG=512910
Review URL: https://codereview.chromium.org/1282873004
Cr-Commit-Position: refs/heads/master@{#342853}
Split out Safe Browsing interstitial metrics by the source of the classification.
This is so when a user enables Data Saver and we're rolling out XLB,
and D.S. routes HTTPS queries through XLB, we can distinguish the two
in the metrics.
Also add performance-related metrics to LocalSafeBrowsingDatabaseManager
for Android, and protect DataReductionProxyResourceProxy from when
safe browsing is disabled.
This also fixes a bug where RecordExtraUserDecisionMetrics() isn't called
except on first-time visits.
BUG=496382
Review URL: https://codereview.chromium.org/1266493006
Cr-Commit-Position: refs/heads/master@{#342852}
Cleanup NQE
Make NetworkQuality private. Remove NetworkQuality from all
public APIs since we decided to have a separate Getter for
each metric.
Future CL will template the Observations/Estimates.
BUG=502415
Review URL: https://codereview.chromium.org/1277483004
Cr-Commit-Position: refs/heads/master@{#342851}
Send GCM id to DMServer
This CL add a device management request to send GCM id after registration to
the server, so that server can maintain a mapping between GCM id and DM token.
BUG=517466
Committed: https://crrev.com/92960c61ee75a5323fc954b9819acca5b684d2aa
Cr-Commit-Position: refs/heads/master@{#342364}
Review URL: https://codereview.chromium.org/1258313002
Cr-Commit-Position: refs/heads/master@{#342850}
Implementation of Audio for the Chrome Os Device Emulator
BUG=516545
Review URL: https://codereview.chromium.org/1274403003
Cr-Commit-Position: refs/heads/master@{#342849}
Revert of Roll WebRTC 9687:9699, Libjingle 9690:9699 (patchset #1 id:1 of https://codereview.chromium.org/1285843002/ )
Reason for revert:
Looks like this is failing tests. Not sure why it's green in the CQ.. but here's the bug. Let's see if this fixes it: https://code.google.com/p/chromium/issues/detail?id=519610
Original issue's description:
> Roll WebRTC 9687:9699, Libjingle 9690:9699
>
> WebRTC 9687:9699
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/380f11e..09346f1
>
> Libjingle 9690:9699
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/cc9de75..4dd92ac
>
> TBR=tommi
>
> Committed: https://crrev.com/888bbf99a19d08f09b95cb5fdfbf1e80d8a979d6
> Cr-Commit-Position: refs/heads/master@{#342829}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1278033005
Cr-Commit-Position: refs/heads/master@{#342848}
Disable ScreenlockPrivateApiTest.LockUnlock under MSan.
BUG=478091
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/1272383006
Cr-Commit-Position: refs/heads/master@{#342847}
Only prime NSS in the sandbox for NSS ports.
This code, if all goes well, can actually be deleted now. But leave it there as
ifdefs for now case we still need to revert the chimera.
Now that no calls to InitNSSSafely and friends are built in USE_OPENSSL ports,
the LoadNSSLibraries calls and /dev/urandom fopen override may be removed. They
were only added to support NSS in the sandbox.
BUG=506323
Review URL: https://codereview.chromium.org/1274483002
Cr-Commit-Position: refs/heads/master@{#342846}
Prefetch requests using LOAD_VALIDATE_CACHE.
This tells the URLFetcher to revalidate the resources (e.g. against
Last-Modified, ETag, etc.). Consequently, in the case of a 304, this
will update the Date/Expires headers in our cache without costing us
network bytes.
BUG=309216
Review URL: https://codereview.chromium.org/1279833007
Cr-Commit-Position: refs/heads/master@{#342845}
Create an initial chrome://supervised-user-internals page
Modeled loosely after the chrome://sync-internals page.
This is fairly basic for now; the plan is to add more functionality as needed.
Screenshot on the bug.
BUG=495093
Review URL: https://codereview.chromium.org/1282533004
Cr-Commit-Position: refs/heads/master@{#342844}
Disable DataReductionProxyConfigServiceClient requests when Data Saver is disabled.
Adds a boolean flag to DataReductionProxyConfigServiceClient to mirror the state of
the Data Saver feature, to ensure that requests to the service are only made if
the Data Svaer feature is enabled by the user.
BUG=518931
Review URL: https://codereview.chromium.org/1279343002
Cr-Commit-Position: refs/heads/master@{#342843}
[Sync] Remove calls to MakeUserAgentForSyncApi.
BUG=512036
Review URL: https://codereview.chromium.org/1258563009
Cr-Commit-Position: refs/heads/master@{#342842}
Reflect the current state in Media Router Action icon.
The four states and scenarios are as following:
- Idle (Not locally casting to a sink).
- Active (Currently locally casting to a sink).
- Warning (Current issue shown to user is of type 'warning').
- Error (Current issue shown to user is of type 'fatal').
This change also adds more Media Router Action icons, as well as update the current idle icons.
Review URL: https://codereview.chromium.org/1268553002
Cr-Commit-Position: refs/heads/master@{#342841}
[Offline pages] Switching getting pages to a synchronous way
* Exposing synchronous way to get offline pages
* Adding offline page model observer interface, with a listener for
model being loaded
* Propagating changes through the bridge
* Updating test to the new model
[email protected],[email protected]
BUG=491352
Review URL: https://codereview.chromium.org/1276423002
Cr-Commit-Position: refs/heads/master@{#342840}
Rebaseline global-interface-listing-expected.txt
Due to crrev.com/1253063006 (Unprefix Resource Timing API)
BUG=506603
[email protected]
Review URL: https://codereview.chromium.org/1277973003
Cr-Commit-Position: refs/heads/master@{#342839}
Remove outdated versions of StartsWith and EndsWith from string_util.cc
It seems that old versions of StartsWith and EndsWith are unused
and can be removed completely.
R=brettw
BUG=none
Review URL: https://codereview.chromium.org/1278973004
Cr-Commit-Position: refs/heads/master@{#342838}
Roll src/third_party/WebKit 2085a03:f2395b6 (svn 200318:200329)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2085a03..f2395b6
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285723005
Cr-Commit-Position: refs/heads/master@{#342837}
Move downloads.FocusRow.shouldFocus to cr.ui.FocusRow.isFocusable
There's nothing downloads-specific about this code and I'd like to
use it in other places.
[email protected]
BUG=425626,518053
Review URL: https://codereview.chromium.org/1281483008
Cr-Commit-Position: refs/heads/master@{#342836}
Roll src/third_party/skia 95d7913:4cf9e7e
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/95d7913..4cf9e7e
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
4cf9e7e [email protected] Revert "move some public headers into private"
eedf0fb [email protected] move some public headers into private
Review URL: https://codereview.chromium.org/1290493002
Cr-Commit-Position: refs/heads/master@{#342835}
Remove unused metric MigrationNssToPem.
This metric was used for a migration. The migration code was removed in
January 2015, see commit 01cbd540b.
BUG=447211
Review URL: https://codereview.chromium.org/1281223002
Cr-Commit-Position: refs/heads/master@{#342834}
Only set precache.last_time when precache ran.
Modify the prefetch run to pass a precacheStarted boolean from the C++ side to
the Java side. If precacheStarted, the precache.last_time pref is set and an
alarm is created for WAIT_UNTIL_NEXT_PRECACHE_MS later. Otherwise, the pref is
not updated, and an alarm is set for INTERACTIVE_STATE_POLLING_PERIOD_MS later.
This should reduce the possibility that a user has to wait an additional 4
hours for the prefetch run, because some precondition for prefetching wasn't
yet met.
BUG=309216
Review URL: https://codereview.chromium.org/1272443002
Cr-Commit-Position: refs/heads/master@{#342833}
Add 949ba8b6a9.dll to Chrome's Browser's blacklist
BUG=
Review URL: https://codereview.chromium.org/1274273006
Cr-Commit-Position: refs/heads/master@{#342832}
[telemetry][Android] Log host tcp ports in use on forward failure.
BUG=
Review URL: https://codereview.chromium.org/1286713004
Cr-Commit-Position: refs/heads/master@{#342831}
Revert of Linux: Depend on liberation-fonts package. (patchset #1 id:1 of https://codereview.chromium.org/1283543004/ )
Reason for revert:
The liberation-fonts package on Fedora is a lie. See https://crbug.com/519322
Original issue's description:
> Linux: Depend on liberation-fonts package.
>
> Without these fonts, text in the built-in PDF viewer may not display correctly.
>
> BUG=369991
>
> Committed: https://crrev.com/8f7b33b2f79917f2cb2f1df9f926575c070dbae1
> Cr-Commit-Position: refs/heads/master@{#342645}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369991
Review URL: https://codereview.chromium.org/1286743002
Cr-Commit-Position: refs/heads/master@{#342830}
Roll WebRTC 9687:9699, Libjingle 9690:9699
WebRTC 9687:9699
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/380f11e..09346f1
Libjingle 9690:9699
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/cc9de75..4dd92ac
TBR=tommi
Review URL: https://codereview.chromium.org/1285843002
Cr-Commit-Position: refs/heads/master@{#342829}
Update PresentationService and PresentationDispatcher availability listening.
This implements per-URL availability listening in PresentationService and PresentationDispatcher. If no URL is provided, the default presentation URL is assumed.
This also renames "presentation URL" to "availability URL" in the relevant methods to align naming with the spec.
The second part of a four-part patch.
1. [blink] https://codereview.chromium.org/1280713003
2. [content] This patch.
3. [blink] A patch to convert Blink to use the new API and remove the old API. (TBD)
4. [content] A patch to remove the implementation of the old API. (TBD)
BUG=510814
Review URL: https://codereview.chromium.org/1266923003
Cr-Commit-Position: refs/heads/master@{#342828}
Roll src/third_party/WebKit d5ff01e:2085a03 (svn 200312:200318)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d5ff01e..2085a03
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1285683003
Cr-Commit-Position: refs/heads/master@{#342827}
Revert of [Android] Make enhanced bookmark editing UI more straightforward. (patchset #8 id:140001 of https://codereview.chromium.org/1230313009/ )
Reason for revert:
http://crbug.com/519368
Original issue's description:
> [Android] Make enhanced bookmark editing UI more straightforward.
>
> - We didn't save when a dialog is dismissed by tapping outside on
> tablet, which can be also confusing as there is no save UI concept.
> So save onPause always.
>
> - User should know when we won't save what user typed if it fails
> validation. But blocking dialog exit is too invasive, and sometimes
> we don't have a control (tapping outside on tablet.) So show warning
> as user types.
>
> BUG=510253
>
> Committed: https://crrev.com/5886fc8beb1ae5714f25a8bb1c76a42bfe88272c
> Cr-Commit-Position: refs/heads/master@{#342719}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=510253
BUT=519368
Review URL: https://codereview.chromium.org/1278963004
Cr-Commit-Position: refs/heads/master@{#342826}
Fix device_utils.SetProp not properly clearing cached value
BUG=
Review URL: https://codereview.chromium.org/1275263004
Cr-Commit-Position: refs/heads/master@{#342825}
Fixing some issues when on Windows.
The sleep and ls commands aren't supported on Windows. I changed them to use
python from the command line to implement a cross-OS version of these. I also
added some additional features to better support running processes remotely.
BUG=
Review URL: https://codereview.chromium.org/1267743005
Cr-Commit-Position: refs/heads/master@{#342824}
Fix UpdateLogin for GNOME password Keyring.
It's a follow up to https://codereview.chromium.org/1280863003/. The bug was that RemoveLogin can remove any password matching the unique key. Therefore, RemoveLogin should be called to clean all the forms with the same sync tag.
BUG=489766
Review URL: https://codereview.chromium.org/1273033006
Cr-Commit-Position: refs/heads/master@{#342823}
Revert of mandoline: Sandbox mojo:browser and mojo:omnibox. (patchset #2 id:20001 of https://codereview.chromium.org/1282903002/ )
Reason for revert:
This broke --enable-multiprocess on mandoline.
Original issue's description:
> mandoline: Sandbox mojo:browser and mojo:omnibox.
>
> BUG=492524
>
> Committed: https://crrev.com/7cd4b784ffd31856b32ada4efd2265a4989fd575
> Cr-Commit-Position: refs/heads/master@{#342725}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=492524
Review URL: https://codereview.chromium.org/1274993003
Cr-Commit-Position: refs/heads/master@{#342822}
Roll src/third_party/skia 5ac42ea:95d7913
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5ac42ea..95d7913
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
95d7913 [email protected] Move Perf documentation to the testing section
Review URL: https://codereview.chromium.org/1281173003
Cr-Commit-Position: refs/heads/master@{#342821}
Fix compilation of //sql:sql_unittests on iOS.
Add new gn argument to control whether Chromium builds sqlite3 or use
the version coming with the system and enable it by default on iOS
were it is the only supported alternative.
Pass necessary defines to compile the "sqlite_regexp" and disable some
warning that are reported for src/ext/icu/icu.c
BUG=459705
Review URL: https://codereview.chromium.org/1276363002
Cr-Commit-Position: refs/heads/master@{#342820}
SupervisedUser SafeSites: Switch to the new SafeSearch API
BUG=475513
Review URL: https://codereview.chromium.org/1277323003
Cr-Commit-Position: refs/heads/master@{#342819}
GN: Use forward_variables_from and remove unnecessary ldflags for cdm_adapter.gni
This is just a simplification, no behavioural change.
Review URL: https://codereview.chromium.org/1276973003
Cr-Commit-Position: refs/heads/master@{#342818}
Add flag to protect password viewing and copying in the Settings->Save Passwords tab.
[email protected]
BUG=159166
Review URL: https://codereview.chromium.org/1284653002
Cr-Commit-Position: refs/heads/master@{#342817}
Switch to WebLeakDetector::Result::numberOfLiveLayoutObjects.
This was renamed from numberOfLiveRenderObjects in February.
https://codereview.chromium.org/899163003
Once this CL lands, the redundant field can be removed from the Blink API.
Review URL: https://codereview.chromium.org/1281363002
Cr-Commit-Position: refs/heads/master@{#342816}
Update documentation of how to use roll-dep in DEPS file.
The roll-dep script no longer deals with SVN revisions and now just rolls to the
latest origin/master.
NOTRY as this is just comments in DEPS.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/1289473002
Cr-Commit-Position: refs/heads/master@{#342815}
Popular sites on the NTP: Favicons!
Follow-up to https://codereview.chromium.org/1265983007/
BUG=516618
Review URL: https://codereview.chromium.org/1272883004
Cr-Commit-Position: refs/heads/master@{#342814}
Roll src/third_party/cld_2/src 85f0ee72b..84b58a5d7
https://chromium.googlesource.com/external/github.com/CLD2Owners/cld2.git/+log/85f0ee72b21ee7009a76476c2c55eafa30f6a378..84b58a5d7690ebf05a91406f371ce00c3daf31c0
BUG=505316
Review URL: https://codereview.chromium.org/1282413003
Cr-Commit-Position: refs/heads/master@{#342813}
Roll src/third_party/WebKit dfa94b7:d5ff01e (svn 200307:200312)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dfa94b7..d5ff01e
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1275833004
Cr-Commit-Position: refs/heads/master@{#342812}
Making PlatformWindowAndroid work with component build
BUG=507792
Review URL: https://codereview.chromium.org/1277543007
Cr-Commit-Position: refs/heads/master@{#342811}
Enable new bookmark apps on Mac.
This also disables opening bookmark apps as windows by default, as there
are outstanding visual issues.
BUG=517682
Review URL: https://codereview.chromium.org/1274673003
Cr-Commit-Position: refs/heads/master@{#342810}
Disabling PreAndPostExistingTaskProviding on Windows due to flakiness.
BUG=519333
[email protected]
Review URL: https://codereview.chromium.org/1285803002
Cr-Commit-Position: refs/heads/master@{#342809}
Replace StringPrintf("%s", ...) with an explicit cast.
StringPrintf("%s", ...) was being used to implicitly cast an unsigned
char* string to a char* string. Use a safer reinterpret_cast<char*>
conversion instead.
BUG=
TEST=compile
Review URL: https://codereview.chromium.org/1278493008
Cr-Commit-Position: refs/heads/master@{#342808}
Roll src/third_party/WebKit ba9d5f1:dfa94b7 (svn 200303:200307)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ba9d5f1..dfa94b7
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1282343003
Cr-Commit-Position: refs/heads/master@{#342807}
Move ClipboardURLProvider into //components/omnibox.
Move ClipboardURLProvider with the other AutocompleteProvider into
//components/omnibox to simplify the construction of the provider
and break circular dependency of open_from_clipboard and omnibox
components.
Introduce a new AutocompleteProvider::Type for this new provider
(AutocompleteProvider::TYPE_CLIPBOARD_URL) with the corresponding
value in OmniboxEventProto enumeration.
Pass the AutocompleteProviderClient to the ClipboardURLProvider
and remove another layer of indirection for the construction of
the AutocompleteMatch.
Add AutocompleteProvider::TYPE_CLIPBOARD_URL to the default list
of providers and construct, if ClipboardRecentContent singleton
exists (currently only implemented on iOS), a ClipboardURLProvider.
Add unit tests for ClipboardURLProvider.
BUG=517134,517017,514225
Review URL: https://codereview.chromium.org/1273013002
Cr-Commit-Position: refs/heads/master@{#342806}
Upstream app_group
Upstream the app_group logic.
BUG=510364
Review URL: https://codereview.chromium.org/1275063002
Cr-Commit-Position: refs/heads/master@{#342805}
Service Worker: Stop using a scoped_ptr for an object to be released immediately.
The original code of the callers of WebCallbacks::onError/onSuccess methods
addressed by this CL create a scoped_ptr and immediately release it to pass a
raw pointer to method. This CL changes it to directly use a raw pointer.
Related comment from nhiroki@: https://codereview.chromium.org/1270513002/diff/20001/content/child/service_worker/service_worker_dispatcher.cc#newcode562
BUG=N/A
Review URL: https://codereview.chromium.org/1275903003
Cr-Commit-Position: refs/heads/master@{#342804}
Fix url_data_manager_ios_backend.cc
This CL adds the missing call to InvalidateWeakPtrs(), as it is done in
the //content implementation. See
https://codereview.chromium.org/1271593002/diff/240001/content/browser/webui/url_data_manager_backend.cc
BUG=518077
Review URL: https://codereview.chromium.org/1289453002
Cr-Commit-Position: refs/heads/master@{#342803}
Gallery: bring overwrite original checkbox back.
This CL removes saved toast with bringing the checkbox back.
BUG=518705, 517981
TEST=browser_tests:GalleryJsTest.GalleryItemTest
Review URL: https://codereview.chromium.org/1283723002
Cr-Commit-Position: refs/heads/master@{#342802}
Update V8 to version 4.6.65.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2261aeaa..1d0b8962
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1273303003
Cr-Commit-Position: refs/heads/master@{#342801}
Migrate to github hosting of CLD2 project.
The revision hash points to the same commit as before, but in the new repo.
A subsequent CL will roll deps forward. This change should be a no-op for
functionality.
BUG=485496
Review URL: https://codereview.chromium.org/1285573002
Cr-Commit-Position: refs/heads/master@{#342800}
Roll src/third_party/WebKit 841bee3:ba9d5f1 (svn 200298:200303)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/841bee3..ba9d5f1
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1281813004
Cr-Commit-Position: refs/heads/master@{#342799}
Files.app: Use Roboto medium for drive banner.
BUG=none
TEST=manually tested
Review URL: https://codereview.chromium.org/1280513005
Cr-Commit-Position: refs/heads/master@{#342798}
Remove a superfluous <li> wrapper on chrome://extensions
[email protected]
BUG=518053
Review URL: https://codereview.chromium.org/1284803004
Cr-Commit-Position: refs/heads/master@{#342797}
Cache the channel information on iOS.
Quick testing reveals that GetChannel() is called twice for every key
press in the Omnibox. Cache the values since they never change during
the application lifetime.
Use dispatch_once() to ensure proper initialization of the values.
BUG=511912
Review URL: https://codereview.chromium.org/1271503002
Cr-Commit-Position: refs/heads/master@{#342796}
Files.app: Set timeout for volume initialization steps.
There are some reports saying that Files.app doesn't launch.
According to the log, it seems Files.app is stuck waiting requestFileSystem or resolveIsolatedEntries during initialization of volumes.
This CL adds timeout for each async calls so that Files.app eventually launches.
BUG=511286
TEST=manually install an extension which doesn't respond on getMetadata, and check that Files.app launches after tiemout.
Review URL: https://codereview.chromium.org/1281563002
Cr-Commit-Position: refs/heads/master@{#342795}
Check for empty security info when sending security info to devtools
Currently, some responses (notably, redirects) can come in to
WebURLLoader without any security info
attached. DeserializeSecurityInfo() does not treat empty strings as a
deserialization error, so in this case we end up trying to extract SSL
information from a connection status of 0. Instead, check for the
empty string upfront and just tell devtools that the security state is
unknown.
Hopefully, we will soon be attaching security info to redirect
responses (https://codereview.chromium.org/1275743005/).
BUG=519120
[email protected]
Review URL: https://codereview.chromium.org/1275513006
Cr-Commit-Position: refs/heads/master@{#342794}
Roll src/third_party/WebKit 36e08bf:841bee3 (svn 200284:200298)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/36e08bf..841bee3
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286693002
Cr-Commit-Position: refs/heads/master@{#342793}
Add a Vp9Parser implementation
Add a class for parsing VP9 bitstreams as described in VP9 draft spec and libvpx.
Also add tests for it to media_unittests.
TEST=media_unittests for Vp9Parser
BUG=509500
Review URL: https://codereview.chromium.org/1258083004
Cr-Commit-Position: refs/heads/master@{#342792}
Returning scoped_ptr<> instead of raw pointer in ProxyConfig::ToValue
BUG=472381
Review URL: https://codereview.chromium.org/1280973004
Cr-Commit-Position: refs/heads/master@{#342791}
[Offline pages] Updating the test that is dependent on environment
BUG=518758
Review URL: https://codereview.chromium.org/1286563002
Cr-Commit-Position: refs/heads/master@{#342790}
Animations: Plumb disable-threaded-animation to blink
Blink part: https://codereview.chromium.org/1253313002/
This allows us to know ahead of time whether threaded animations can be started.
BUG=509482
Review URL: https://codereview.chromium.org/1253133003
Cr-Commit-Position: refs/heads/master@{#342789}
fixup! cc: Handle overflow/underflow in MathUtil::RoundUp/RoundDown
functions.
Simple grammatical correction in function names of RoundUpOverflow
and RoundDownUnderflow.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1286463003
Cr-Commit-Position: refs/heads/master@{#342788}
Rename gridBoundary_ to listContents_.
This is so my cr.ui.FocusRow refactor is easier to review.
[email protected]
BUG=518053
Review URL: https://codereview.chromium.org/1283013003
Cr-Commit-Position: refs/heads/master@{#342787}
The GYP code path for analyze in MB was busted; fix it.
We had not previously tested the GYP codepath for analyze with
--verbose=true, and it turns out that when that ran, we tried
to call a function that didn't exist. This patch fixes that issue.
[email protected]
BUG=481692
NOTRY=true
Review URL: https://codereview.chromium.org/1282393003 .
Cr-Commit-Position: refs/heads/master@{#342786}
Roll src/third_party/WebKit 05b750e:36e08bf (svn 200282:200284)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/05b750e..36e08bf
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1272163004
Cr-Commit-Position: refs/heads/master@{#342785}
Remove some debugging statements I left in crrev.com/1162293008
[email protected]
BUG=none
TEST=less console spam
Review URL: https://codereview.chromium.org/1280413002
Cr-Commit-Position: refs/heads/master@{#342784}
bluetooth: mac: Add VLOGs to diagnose device discovery failures.
We currently do not understand why device discovery is succeeding on
some recent Mac bluetooth chipsets, and failing on others. These VLOGs
will improve our ability to collect reports and gather information from
the CoreBluetooth API usage point of view.
After device/bluetooth Mac Low Energy support is stable. That work is
tracked in https://code.google.com/p/chromium/issues/detail?id=519010
BUG=516608
Review URL: https://codereview.chromium.org/1279373002
Cr-Commit-Position: refs/heads/master@{#342783}
Re-use local variable instead of querySelector()ing it again
[email protected]
BUG=518053
Review URL: https://codereview.chromium.org/1277833003
Cr-Commit-Position: refs/heads/master@{#342782}
Fix UAF in PepperWebPluginImpl
During the call to PepperPluginInstanceImpl, re-entrancy can occur and cause
the PepperPluginInstanceImpl to be destroyed. We should never access it in
this case (inside PepperWebPluginImpl).
Also, it is quite unclear in the code that PepperWebPluginImpl might not also
be destroyed during this re-entrancy. I've added an assert that this is not the
case. If the assert ends up being triggered, we should return early...and there
could be other implications we have to deal with.
BUG=487146
Review URL: https://codereview.chromium.org/1277063005
Cr-Commit-Position: refs/heads/master@{#342781}
Updating trunk VERSION from 2479.0 to 2480.0
Cr-Commit-Position: refs/heads/master@{#342780}
[chromedriver] Don't check DOM.getDocument when loading state is kNotLoading.
This prevents the navigation tracker from hanging when we have downloaded an
item, and when the page is slow to respond.
BUG=chromedriver:1167
[email protected]
Review URL: https://codereview.chromium.org/1286663003
Cr-Commit-Position: refs/heads/master@{#342779}
Handle finish composition on selection by long press
When a user long presses text on an input form, it changes selection
region, and IME apps (Google Latin IME, Samsung IME) calls
finishComposingText() in response to an external selection change.
Long press updates text input info in two steps:
a. Through didChangeSelection (only when selection was changed)
b. Through GestureLongPress
finishComposingText() is disregarded by IME app event suppression
logic. We decided to keep this logic, but it had some issues with the long
press selection case as follows:
1) finishComposingText() was ignored even when Blink side change was empty.
Updates from GestureLongPress and didChangeSelection are almost same,
except that GestureLongPress may show IME. Now we track text input state
changes sent to browser in the renderer, to be able to make
ShouldHandleImeEvent() more permissive in cases where we know browser and
renderer are on the same page WRT state.
2a) The timing of ImeEventAck: we send ImeEventAck immediately after
UpdateImeAdapter(), but this should be moved before the call so that it's
sent before any state change that the msg might trigger when being handled.
2b) ImeEventAck and ConfirmComposition events are racy.
Even though SendEventAck() is called before finishComposingText(),
sometimes (usually) ConfirmComposition event is received before
ImeEventAck event. This happens because they go through different
IPC::Sender, so changed ImeEventAck to go through InputRouter by changing
the message class.
On top of adding an automated test, I've done the following manual tests:
(on Samsung IME and Google Latin IME)
- Long press while selection handles appear.
- Long press while selection handles don't appear (window focus on IME).
- Focus document and long press input text.
- Long press empty selection.
- Touch input form while pressing side button on Samsung Note 4.
BUG=503903
Review URL: https://codereview.chromium.org/1217713002
Cr-Commit-Position: refs/heads/master@{#342778}
Get rid of a couple references to IDR_WARNING
This changes the appearance of the chrome://extensions warning banner (for the better, IMO)
This makes no difference to inspect.css because the version restriction was removed in 794befa4c5 and the css rules were dead code
BUG=505953
Review URL: https://codereview.chromium.org/1284643005
Cr-Commit-Position: refs/heads/master@{#342777}
Assertion shouldn't fail when there is no histogram data.
Adding instead a private flag to keep track of whether Start has been
called or not.
BUG=519080
R=qyearsley,nednguyen
Review URL: https://codereview.chromium.org/1286433003
Cr-Commit-Position: refs/heads/master@{#342776}
Roll src/third_party/WebKit 5c2dfbe:05b750e (svn 200275:200282)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5c2dfbe..05b750e
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286653002
Cr-Commit-Position: refs/heads/master@{#342775}
Implements "chrome://appcache-internals" based on WebUI API
Redid the "chrome://appcache-internals" page so that the new implementation is:
1- Based on "WebUIController" and similar to "chrome://indexed-db-internals".
2- Looks into "all" storage paritions when fetching application cache data.
This was previously reported as a bug since the application cache for <webview>
was not being shown on "chrome://appcache-internals".
BUG=343683
Committed: https://crrev.com/8fc82b21621f21ea8d2d8cb483cb14295d1f6e1f
Cr-Commit-Position: refs/heads/master@{#342671}
Review URL: https://codereview.chromium.org/1191383004
Cr-Commit-Position: refs/heads/master@{#342774}
Mac: Use activateIgnoringOtherApps instead of SetFrontProcessWithOptions to focus app windows
Yet another attempt at finding a workaround for the two-windows-have-key-
status bug that can affect packaged app windows on Mac.
Currently, NativeAppWindowCocoa activates Chrome with
::SetFrontProcessWithOptions() called via +[BrowserWindowUtils
activateWindowForController:]. ChromeNativeAppWindowViewsMac calls
-[NSApplication activateIgnoringOtherApps:YES].
After running with the MacViews app window flag for a month I didn't encounter
this bug. Minutes after disabling the flag and returning to
NativeAppWindowCocoa, I got a repro. (Although, a week later, not a second repro).
SetFrontProcess() is deprecated with the note in HIServices/../Processes.h:
* Deprecated:
* To make your own application frontmost, use
* [[NSApplication sharedApplication] activateIgnoringOtherApps: YES].
SetFrontProcessWithOptions() is deprecated with the note:
* Deprecated:
* See SetFrontProcess().
We lose the `kSetFrontProcessFrontWindowOnly` argument to "bring only the
frontmost non-floating window forward", but a quick check suggests this is the
default for activateIgnoringOtherApps: anyway.
SetFrontProcessWithOptions() has been around since http://crrev.com/6647009
BUG=459306
Review URL: https://codereview.chromium.org/1278073002
Cr-Commit-Position: refs/heads/master@{#342773}
Convert octane test score to float first
to prevent fails on slow devices
BUG=508907
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect
Review URL: https://codereview.chromium.org/1230063007
Cr-Commit-Position: refs/heads/master@{#342772}
Mac: Enable partial swap
This is pretty trivial when using the overlay path. Just create a
new layer for the damage. The partial damage layer can be created,
removed, or resized with basically no cost, because its backing is the
already-existing IOSurface.
As each partial swap comes in, union the existing overlay layer's
rect with the rect of the new partial swap. If this grows "too big",
then do a full swap (which clears the accumulated union). The
constants here are pretty arbitrary.
BUG=474299
Review URL: https://codereview.chromium.org/1271123002
Cr-Commit-Position: refs/heads/master@{#342771}
views: Initialize the aura::Env instance from ViewTestSuite.
Like the other test-suites that use aura (e.g. UnitTestTestSuite,
AuraShellTestSuite), make ViewTestSuite responsible for managing the
aura::Env instance for the tests.
A few of the tests used to create a custom implementation of
PlatformEventSource for the sole purpose of getting access to the
DispatchEvent function. So remove these PlatformEventSource
implementations, and instead introduce a test-api for this. Refactor
X11EventSource so that DispatchEvent() can work correctly in
test-environments, where we cannot set up the cookie data correctly.
BUG=none
Review URL: https://codereview.chromium.org/1283713002
Cr-Commit-Position: refs/heads/master@{#342770}
Make cr.ui.FocusRow inherit from HTMLElement
There's nothing different about the IDL of HTMLDivElement vs HTMLElement
except for the obsolete [align] attribute.[1]
BUG=425626
[email protected]
[1] third_party/WebKit/Source/core/html/HTMLDivElement.idl
NOTRY=true
Review URL: https://codereview.chromium.org/1283873003
Cr-Commit-Position: refs/heads/master@{#342769}
Defer ServiceWorker update checks until after browser startup is complete.
Also implement after startup task deferral more reasonably on android. Now its based on a signal from DeferredStartupHandler.java instead of an arbitrary 10 second timer.
BUG=460265
Review URL: https://codereview.chromium.org/1078283002
Cr-Commit-Position: refs/heads/master@{#342768}
Update V8 to version 4.6.64.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eb3955e2..2261aeaa
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1288433005
Cr-Commit-Position: refs/heads/master@{#342767}
Fix some protobuf issues (unnecessary imports, missing syntax) detected with a
new version of the protobuf compiler.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1279683004
Cr-Commit-Position: refs/heads/master@{#342766}
Roll src/third_party/WebKit bdbfd8c:5c2dfbe (svn 200270:200275)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bdbfd8c..5c2dfbe
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1286563004
Cr-Commit-Position: refs/heads/master@{#342765}
Remove |browser_| from WebsiteSettingsPopupView.
It's only needed to OpenURL(), which WebContents can also do.
Also remove unused headers and forward-decls.
BUG=None.
Review URL: https://codereview.chromium.org/1268243003
Cr-Commit-Position: refs/heads/master@{#342764}
Roll ANGLE 519a5be..3dfcdcb
https://chromium.googlesource.com/angle/angle.git/+log/519a5be..3dfcdcb
BUG=504872,518206,510151
TEST=bots
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1283903002
Cr-Commit-Position: refs/heads/master@{#342763}
Using chromoting_integration_tests.isolate for chromoting test driver.
Added my own launcher and renamed chromoting_integration_tests.isolate to browser_integration_tests.isolate.
I've added chromoting_test_driver_commands_linux.txt to make it easy to add tests and run them for different hosts.
Note: These changes should land after the changes to internal have been made. Some of the files specified in the isolate require those files.
BUG=
Review URL: https://codereview.chromium.org/1272713006
Cr-Commit-Position: refs/heads/master@{#342762}
Pass referrer information to the store for native app banners.
The related application URL is now parsed if it is present in the manifest.
The id is extracted, and compared against any id specified in the manifest,
with an error triggered if they do not match. Any referrer information from
the URL is also extracted, and passed through to the Play Store.
The old AppDetailsDelegate method signature (sans referrer parameter)
is also removed.
BUG=503226
Review URL: https://codereview.chromium.org/1265423005
Cr-Commit-Position: refs/heads/master@{#342761}
Update the Blink test support to use a WebURLLoaderTestDelegate if set.
Some Blink unit tests need finer grained control over the timing and
chunking of the response.
BUG=515876
Review URL: https://codereview.chromium.org/1283473003
Cr-Commit-Position: refs/heads/master@{#342760}
Settings Rewrite: Implement animated subpages for Search.
This patchset implements an animated subpages system. It uses it for Search to subpage into Search Engines.
BUG=425627
Review URL: https://codereview.chromium.org/1268463004
Cr-Commit-Position: refs/heads/master@{#342759}
Make the button in snackbar larger and easier to click
Snackbar button was too small, and in fact the only touchable area was
the text itself. This makes the button hard to touch, especially for
visually impaired personels.
This CL also adds ianwen@ as the owner of snackbar folder.
BUG=NONE
Review URL: https://codereview.chromium.org/1284493002
Cr-Commit-Position: refs/heads/master@{#342758}
Get the MIME type from response headers for DRP bypass stats.
Changes DataReductionProxyBypassStats to get the MIME type for a request
from the response headers instead of from the URLRequestJob, which might
have been destroyed if the request was cancelled.
BUG=517271
Review URL: https://codereview.chromium.org/1282983002
Cr-Commit-Position: refs/heads/master@{#342757}
cc: Disable smoothness for ScrollDelegate
Webview is not able to reliably determine if the AnimateInput
callback will be called. If it is not called, cc risks being
stuck in smoothness mode, which causes other problems.
Disable smoothness for scrolls and flings from the
ScrollDelegate.
BUG=516362
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1270343007
Cr-Commit-Position: refs/heads/master@{#342756}
Disable ExtensionTabsTest.GetAllWindowsAllTypes on DrMemory where it times out.
BUG=519087
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1283913003
Cr-Commit-Position: refs/heads/master@{#342755}
Roll mesa 071d25db04:3918dbd3bc
3918dbd Merge upstream d2458a471094dce70cfa0dc587d762d79c337705
006d2a9 Re-license trace.xsl under MIT license.
c1e0d48 Set up a good codereview.settings file
BUG=505316
Review URL: https://codereview.chromium.org/1280433005
Cr-Commit-Position: refs/heads/master@{#342754}
Roll libyuv from r1459 to r1462.
Contains the following revisions
https://chromium.googlesource.com/libyuv/libyuv/+log/e40384b6..9425c4b0
Primarily improves performance for rotation on odd width images.
BUG=libyuv:464
TESTED=try bots
Review URL: https://codereview.chromium.org/1285643003
Cr-Commit-Position: refs/heads/master@{#342753}
Restrict chrome.runtime.setUninstallURL to http(s)
Disallow URLs other than http(s) in chrome.runtime.setUninstallURL.
And allow empty URLs to be set to clear the uninstallation URL.
Added an optional callback, to know when setting the URL finished (or
failed).
BUG=518827
TEST=browser_tests --gtest_filter=ExtensionApiTest.ChromeRuntimeUninstallURL
[email protected]
Review URL: https://codereview.chromium.org/1282263002
Cr-Commit-Position: refs/heads/master@{#342752}
Fix the wrong location of the mouse exit event
When a window is hidden, the mouse exit event is dispatched to the
hidden window with the last mouse location based on the root window.
The event has incorrect cordinates because the event is translated
with hidden window.
We should use the root window for |DispatchMouseExitAtPoint| at
|DispatchMouseExitToHidingWindow|.
BUG=514548
[email protected]
Review URL: https://codereview.chromium.org/1285453003
Cr-Commit-Position: refs/heads/master@{#342751}
RFC 2459 name comparison.
BUG=410574
Review URL: https://codereview.chromium.org/1125333005
Cr-Commit-Position: refs/heads/master@{#342750}
Add extension event histogram values for messaging, webRequest, and webview.
These didn't make it into my last 5 patches because they needed to be hand
written. Now, everything is plumbed through to the UMA_HISTOGRAM_ENUMERATION
calls - which I will add in a follow-up - so this should be the last of it.
BUG=503402
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1272373003
Cr-Commit-Position: refs/heads/master@{#342749}
Reduce timeout for Android tests from 90m to 60m.
Appears to be too long, especially with retries.
BUG=519023
Review URL: https://codereview.chromium.org/1286593002
Cr-Commit-Position: refs/heads/master@{#342748}
Implement finding BLE connections in chrome://proximity-auth.
This CL also refactors the classic Bluetooth connection finder to use
SeekDeviceByAddress in order to share the ConnectionFinder interface in
ProximityAuthWebUIHandler.
BUG=517641
TEST=manual and unit tests
Review URL: https://codereview.chromium.org/1277483007
Cr-Commit-Position: refs/heads/master@{#342747}
Disable ChromeBrowserMainExtraPartsMetricsTest.VerifyTouchEventsEnabledIsNotRecordedAfterPostBrowserStart under valgrind, where it fails.
BUG=515031
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1284833002
Cr-Commit-Position: refs/heads/master@{#342746}
Reintroduce the WebappActivity bouncer
Consolidating the old WebappManager with the ChromeLauncherActivity doesn't
work well on JB and KK because the ChromeLauncherActivity needs to be visible
in recents (things launch on top of it) while the the WebappManager shouldn't
have been visible.
Reintroduce the WebappManager as the WebappLauncherActivity and use the
taskAffinity="" flag to make sure nothing ever launches on top of it.
Also gets rid of the EXTRA that was used only for re-activating
WebappActivities; the action serves the same purpose.
BUG=517426
Review URL: https://codereview.chromium.org/1281403002
Cr-Commit-Position: refs/heads/master@{#342745}
Adding chrome extension id to various white lists for testing purposes.
BUG=514696
Review URL: https://codereview.chromium.org/1261113004
Cr-Commit-Position: refs/heads/master@{#342744}
Disable the NetErrorTabHelperTest under valgrind. It doesn't handle DeviceDataManagers right.
BUG=515031
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1279363003
Cr-Commit-Position: refs/heads/master@{#342743}
Roll DEPS for PDFium to 3a38491
3a38491 Cleanup: Mark methods with the override keyword.
48f1947 Really Really fix tests broken at 9778206.
57d994c Really fix tests broken at 9778206.
290b235 Fix win unit tests broken at 9778206.
9778206 Fix FXSYS_itoa() implementation.
e65030e Convert all files on the master branch to unix line endings.
4684c83 clang-format all pdfium code, again.
[email protected]
BUG=517854
Review URL: https://codereview.chromium.org/1281423002
Cr-Commit-Position: refs/heads/master@{#342742}
Prevent a thread startup race in ScheduleWorkTest which causes a nullptr dereference of a message pump.
Review URL: https://codereview.chromium.org/1283543007
Cr-Commit-Position: refs/heads/master@{#342741}
Adding DuplicateHandle hook to track down CLOSE_SOURCE issues.
This is an experimental fix, should be reverted if it doesn't provide any insights.
BUG=480639
[email protected],[email protected],[email protected], [email protected]
Review URL: https://codereview.chromium.org/1171653002
Cr-Commit-Position: refs/heads/master@{#342740}
Add information to hash reqest and update request to indicate if user is opted into extended reporting.
BUG=492954
Review URL: https://codereview.chromium.org/1223403005
Cr-Commit-Position: refs/heads/master@{#342739}
Gets gn check working in components/html_viewer
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1276063004
Cr-Commit-Position: refs/heads/master@{#342738}
Support hash-source CSP directive in extensions/apps
Support CSP hashes (http://www.w3.org/TR/2015/CR-CSP2-20150721/#script-src-hash-usage).
The validation is strict and follows the standard by the letter.
Blink also accepts sha1 and URL-encoded base64, but the extension's CSP
validator only accepts the syntax as specified by the CSP2 standard.
This allows the Blink implementation to become standard-compliant in the
future without breaking extensions.
Also, the CSP validator will now preserve the case of the CSP tokens,
mainly because base64 is case-sensitive. And base::StringToLowerASCII
is deprecated, which is another reason to change to base::ToLowerASCII.
BUG=446036
Review URL: https://codereview.chromium.org/1285523002
Cr-Commit-Position: refs/heads/master@{#342737}
Fix DER parsing bugs when parsing GeneralizedTime and UTCTime
BUG=518073,518079
Review URL: https://codereview.chromium.org/1278243002
Cr-Commit-Position: refs/heads/master@{#342736}
Adds a monotonically increasing id to the frame tree
This is needed so that clients can identify when they have applied a
particular change. Also, I'm making it so the originator of a
structure change gets the notification on the client interface of the
change.
Here's an example of what this fixes:
An HTMLViewer with with two local roots, A and B.
B1 is added as a child of B and then removed.
OnFrameAdded() is seen on A and HTMLViewer attempts to add B1
back. But B1 was already removed, so that it shouldn't added it back.
The monotonically increasing id allows html viewer to identify this by
the following. When a frame is removed HTMLFrameTreeManager now adds
the id to a set. The id is removed when OnFrameRemoved is seen (this
necessitates calling OnFrameRemoved on the originator). In
OnFrameAdded if the id is in the removed set the add is ignored.
BUG=479172,490221
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1280393002
Cr-Commit-Position: refs/heads/master@{#342735}
Call RemoveObserver from OnWidgetDestroying
BUG=487693
Review URL: https://codereview.chromium.org/1287463002
Cr-Commit-Position: refs/heads/master@{#342734}
Add fallback for SystemAccountManagerDelegate.hasFeatures
When we do not have GET_ACCOUNTS permission silently return false.
BUG=517807
Review URL: https://codereview.chromium.org/1285553002
Cr-Commit-Position: refs/heads/master@{#342733}
gpu: Allow for null commandline in command_buffer
We're in progress of allowing the command buffer to act as a gl target
for skia, when this happens, we can't assume that there's a command line
Add some null checks.
Review URL: https://codereview.chromium.org/1276683009
Cr-Commit-Position: refs/heads/master@{#342732}
Fix bug in box layout that affects size 0 views.
The layout code would reserve space for between-child-padding for a view
of size 0, but then when actually setting child bounds, ignore that 0
width child and not add the padding. The end result is that horizontal
box layouts with a zero width child would add an additional
between-child-padding amount of padding at the end of the box.
BUG=none
Review URL: https://codereview.chromium.org/1279763005
Cr-Commit-Position: refs/heads/master@{#342731}
Roll src/third_party/WebKit 9e1abe6:bdbfd8c (svn 200263:200270)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9e1abe6..bdbfd8c
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1284793002
Cr-Commit-Position: refs/heads/master@{#342730}
Reland of Start renderer compositor transfer buffer size at 64kB (patchset #1 id:1 of https://codereview.chromium.org/1282103002/ )
Reason for revert:
Revert didn't help spaceport performance, so relanding.
Original issue's description:
> Revert of Start renderer compositor transfer buffer size at 64kB (patchset #1 id:1 of https://codereview.chromium.org/1277633007/ )
>
> Reason for revert:
> Possibly caused a performance regression in spaceport on android:
>
> https://chromeperf.appspot.com/report?sid=465d51c1316259d55197505ab96c58b9e9bc7ac0369e4552b9c2400bcc01ac82&rev=342270
>
> Original issue's description:
> > Start renderer compositor transfer buffer size at 64kB
> >
> > This matches the browser compositor, and shouldn't change performance because texture uploads happen either with GpuMemoryBuffers or on the worker context.
> >
> > Committed: https://crrev.com/fcf7931116f308a93b4c408f223241bd3d43f41a
> > Cr-Commit-Position: refs/heads/master@{#342240}
>
> [email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/8eb5531de0385213f2cdfe82978fa43d1133eb6a
> Cr-Commit-Position: refs/heads/master@{#342487}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1284803003
Cr-Commit-Position: refs/heads/master@{#342729}
[Offline pages] Fixing casing of strings
BUG=491352
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1282373002
Cr-Commit-Position: refs/heads/master@{#342728}
Disable CRWWKWebControllerWebProcessTest.Crash test for iOS9.
This test is failing on all platforms for iOS9.
BUG=518924
Review URL: https://codereview.chromium.org/1286603002
Cr-Commit-Position: refs/heads/master@{#342727}
Set minimum_zoom_scale for PageScrollState tests.
For WKWebView on iOS9 minimum_zoom_scale is 0.25, but on
UIWebView and WKWebView pre-iOS9, it was set to 1. This change
explicitly sets the minimum_zoom_scale for the tests.
BUG=517936
Review URL: https://codereview.chromium.org/1277223003
Cr-Commit-Position: refs/heads/master@{#342726}
mandoline: Sandbox mojo:browser and mojo:omnibox.
BUG=492524
Review URL: https://codereview.chromium.org/1282903002
Cr-Commit-Position: refs/heads/master@{#342725}
Remove an outdated timeupdate hack android uses to start video painting
OnTimeChanged() no longer setDisplayMode(), so this hack is no longer working for quite some time.
Media element should know when to start painting the video frame when playback state changes.
BUG=504773
Review URL: https://codereview.chromium.org/1271313006
Cr-Commit-Position: refs/heads/master@{#342724}
cc: Remove the gradient check from skipping images for low res tiles.
The gradient check was trying to avoid asABitmap() calls which return
a bitmap representation of a gradient. Instead we should only use the
kDefault_BitmapType return value from asABitmap().
R=enne, vmpstr
BUG=516500
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1287523002
Cr-Commit-Position: refs/heads/master@{#342723}
Set skip_service_worker in ServiceWorkerControlleeRequestHandler only for subresource requests.
https://codereview.chromium.org/1274973002/ accidentally changed the
Service Worker behavior of handling redirected page requests.
If we set skip_service_worker for page requests, the final location of redirects
will not correctly be handled by Service Worker.
So this cl change to set |skip_service_worker| only for subresource requests.
https://codereview.chromium.org/1280243002 will add LayoutTests for fallbacked subresource requests.
BUG=517364, 512764, 518713
Review URL: https://codereview.chromium.org/1280133002
Cr-Commit-Position: refs/heads/master@{#342722}
Reland : Add custom tabs tests using intents with non-null sessions
All current tests either test the service side session creation without
launching intents or the UI customization with no sessions. This change
add a trivial test that uses a valid session to launch an intent and also
another more complex test that reloads a new URL in the same tab when the
same session is used inside the intent.
Note that the service side is interfaced directly through CustomTabConnection
and this doesn't exactly replicate the actual scenario since all calls come
from the same process.
Review URL: https://codereview.chromium.org/1278473005
Cr-Commit-Position: refs/heads/master@{#342721}
Add missing 'gpu_tests' config to MB, fix typo in MB.
These errors were discovered when I tried to land
https://codereview.chromium.org/1274043003/.
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1280803003
Cr-Commit-Position: refs/heads/master@{#342720}
[Android] Make enhanced bookmark editing UI more straightforward.
- We didn't save when a dialog is dismissed by tapping outside on
tablet, which can be also confusing as there is no save UI concept.
So save onPause always.
- User should know when we won't save what user typed if it fails
validation. But blocking dialog exit is too invasive, and sometimes
we don't have a control (tapping outside on tablet.) So show warning
as user types.
BUG=510253
Review URL: https://codereview.chromium.org/1230313009
Cr-Commit-Position: refs/heads/master@{#342719}
Polish MD FIP bar.
BUG=512443
Review URL: https://codereview.chromium.org/1278003003
Cr-Commit-Position: refs/heads/master@{#342718}
Exclude AppViewTest.KillGuestCommunicatingWithWrongAppView under DrMemory.
BUG=519039
[email protected]
Review URL: https://codereview.chromium.org/1274193003
Cr-Commit-Position: refs/heads/master@{#342717}
User MessageLoopForIO::WatchFileDescriptor in proces_output_watcher
The main point is to avoid usage of select for observing process'
pseudo-terminal fd. Main problems with select is that it doesn't work
for fd > 1024, which started to be passed to ProcessOutputWatcher.
Added benefit of MessageLoopForIO::WatchFileDescriptor is that it's async,
so it enables us to do some clean up for process proxy thread management.
BUG=495165
TEST=Open a lot of crosh tabs (e.g. ~30). Crosh is started in all of them.
Review URL: https://codereview.chromium.org/1258193002
Cr-Commit-Position: refs/heads/master@{#342716}
Roll src/third_party/skia c699873:5ac42ea
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c699873..5ac42ea
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
5ac42ea [email protected] Make initBatchTracker private, move towards pipeline on batch
4977983 [email protected] Sk4px blit mask.
Review URL: https://codereview.chromium.org/1281373003
Cr-Commit-Position: refs/heads/master@{#342715}
Ensure BrowserCdmManager's promises are safe to call while held.
The raw pointer that CdmPromiseInternal holds to BrowserCdmManager can become
invalidated while the CdmPromiseInternal instance still lives.
This change also forces Cast's BrowserCdm implementation to invoke the
promises on the correct thread (which should have been the case before).
[email protected],[email protected],[email protected]
BUG=internal b/22075780
Review URL: https://codereview.chromium.org/1279213002
Cr-Commit-Position: refs/heads/master@{#342714}
Fix ChromeTabbedActivityHWATest to properly start ChromeTabbedActivities.
Review URL: https://codereview.chromium.org/1277753005
Cr-Commit-Position: refs/heads/master@{#342713}
Disable ExtensionServiceTest.ExternalInstallMultiple under TSan.
Because it uses an in-process utility thread, it has a lot of data races.
BUG=518957,268924,388730
[email protected],[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_tsan_rel_ng
Review URL: https://codereview.chromium.org/1284753002
Cr-Commit-Position: refs/heads/master@{#342712}
Remove "delete this" pattern from UsbContext completely.
This change fixes a much rarer possible use-after-free on USB context
shutdown than commit 3219ab0a9caf806b6dda0fe970869735726a5481. If there
is an event that wakes up the event loop thread after running_ is set to
false then the context could be freed before the attempt to wake it up
with libusb_interrupt_handle_event() is made, instead signaling a freed
object.
This change instead makes it the responsibility of UsbContext to free
the UsbEventHandler once its thread has been joined.
BUG=518749
[email protected]
Review URL: https://codereview.chromium.org/1281373002
Cr-Commit-Position: refs/heads/master@{#342711}
[mac] always show `Look up “Foo”` underneath spelling suggestions
BUG=518905
Review URL: https://codereview.chromium.org/1276343005
Cr-Commit-Position: refs/heads/master@{#342710}
Speculatively exclude SmartSessionRestoreMRUTest.CorrectLoadingOrder on DrMemory.
Even though SmartSessionRestoreMRUTest.PRE_CorrectLoadingOrder is excluded, it's
still running, and I'm theorizing that it's because exclusions don't work well
for PRE tests.
This started turning the bot red in
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%285%29/builds/3805,
but it was failing and yellow before then.
[email protected],[email protected]
BUG=504885
Review URL: https://codereview.chromium.org/1273293004
Cr-Commit-Position: refs/heads/master@{#342709}
Roll src/third_party/WebKit f59db51:9e1abe6 (svn 200259:200263)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f59db51..9e1abe6
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1281393002
Cr-Commit-Position: refs/heads/master@{#342708}
Resets load state when frame is swapped
When a frame is swapped to a new one the loading state needs to be
reset. A swap effectively means a new client is going to be rendering
into the frame, so persisting load state doesn't make sense.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1286573002
Cr-Commit-Position: refs/heads/master@{#342707}
[MD settings] Adding mock version of certificate manager
This CL adds a rough version of the certificate manager mock
up. This is a small step toward a new version of
certificate manager.
BUG=517564
Review URL: https://codereview.chromium.org/1281583002
Cr-Commit-Position: refs/heads/master@{#342706}
Add cr-network-select element for selecting a Chrome OS network
The purpose of this CL is to provide a network select UI for
pages other than Settings, specifically the OOBE Ui.
This CL:
* Moves cr_network_icon and cr_onc_types to cr_elements/network
* Moves cr_network_list and cr_network_list_item to cr_elements/network
* Introduces a cr_network_select wrapper to cr_elements/network
The wrapper implements the networkingPrivate calls required to
connect to a network or show the configure UI for a network.
* Adds cr_network_select to chrome://network to demonstrate it
and provide convenient access within that page while testing.
BUG=515987
Review URL: https://codereview.chromium.org/1277223002
Cr-Commit-Position: refs/heads/master@{#342705}
[Android] Make native pages crash when it is destroyed multiple times.
In this way we will be able to catch such cases more easily.
BUG=513035
Review URL: https://codereview.chromium.org/1257823002
Cr-Commit-Position: refs/heads/master@{#342704}
Drawable Content Rect From Property Trees
Drawable content rect is computed in CDP. This patch
computes it using property trees and checks that property
tree computation matches CDP computation.
BUG=497817
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1241223002
Cr-Commit-Position: refs/heads/master@{#342703}
[Translate] Abstract concept of list of denial times.
Translate plans to experiment with the number of denied requests before
triggering an "always denied". This change abstracts out the hard-coded
assumption of two denials and introduces the concept of a list of denial
times.
In the process, the preference value recording denial times is migrated
from a double to a ListValue.
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/1259793009
Cr-Commit-Position: refs/heads/master@{#342702}
Makes mopy turn off gtest coloring
Without this gtest could turn on coloring, which confuses the code
that searches the output. The specific error I was getting was re was
being passed a regular expression that contained escape sequences,
which triggered an exception in re saying the string wasn't balanced.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1279833003
Cr-Commit-Position: refs/heads/master@{#342701}
IAccessibleText: Made content editables return embedded object information and made all objects include any widespace.
BUG=491027
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1223153002
Cr-Commit-Position: refs/heads/master@{#342700}
Move DNS functions from net_error_info.h into error_page namespace.
This was a TODO for hashimoto. The rest of the file will be moved into
error_page in a separate CL.
BUG=None
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1277213003
Cr-Commit-Position: refs/heads/master@{#342699}
Material design should not use selected versions of assets in omnibox
Currently, the assets used in the omnibox dropdown
are swapped with a 'selected' version of the
asset if the corresponding omnibox row is
highlighted. For material design, the same version
of the asset should be used even if the row
is highlighted.
BUG=518927
TEST=none
Review URL: https://codereview.chromium.org/1274183003
Cr-Commit-Position: refs/heads/master@{#342698}
GN: Use lib.unstripped rather than lib.stripped. Add a toolchain.gni
toolchain.gni introduces:
root_shlib_dir, shlib_prefix, and shlib_extension
The original goal of this change was to put shlibs under lib/ for Linux / Android, since that's where GYP puts them. However, the lack of support for loadable_module (or more specifically - per target output directory) in GN makes this infeasible at the moment.
This change also mitigates a subtle bug where on Android the unstripped .so is used mistakenly instead of the lib.stripped/ version. It also fixes shlib's link_output being set to the unstripped .so rather than the stripped .so (on Android).
BUG=509771
Review URL: https://codereview.chromium.org/1236503002
Cr-Commit-Position: refs/heads/master@{#342697}
Modify Cast Channel logger's method for accessing time.
* Switch from base::TickClock to base::Clock. TickClock's
monotonicity may yield a different time values than the system
clock. Consistency with the system clock is important for
correlating log events across multiple sources.
* Use TimeDelta for computing the microsecond-level delta with the
epoch. The previous solution computed the delta via the
"InternalValue", which is explicitly discouraged in the TimeTicks
documentation.
[email protected]
[email protected]
BUG=518951
Review URL: https://codereview.chromium.org/1282913002
Cr-Commit-Position: refs/heads/master@{#342696}
[Offline pages] Implementing filters in enhanced bookmarks UI
Implementing the missing functionality of applying custom filter to
enhanced bookmarks UI. We need this for offline pages.
BUG=491352
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1276333005
Cr-Commit-Position: refs/heads/master@{#342695}
QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in
QuicSentPacketManager::MaybeRetransmitTailLossProbe.
BUG=517726
[email protected]
Review URL: https://codereview.chromium.org/1281303002
Cr-Commit-Position: refs/heads/master@{#342694}
Roll src/third_party/skia 2a5ca89:c699873
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2a5ca89..c699873
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
c699873 [email protected] Remove GrPipelineOptimizations member from GrPipeline
b7ee1bf [email protected] trivial CL to add drawBatch to GrDrawContext
14205b1 [email protected] Expand functionality of GrRectBatchFactory with AARects
fb69bb3 [email protected] Fix to call SkDelete_array instead of SkDelete to fix ASAN error. [email protected]
Review URL: https://codereview.chromium.org/1283863002
Cr-Commit-Position: refs/heads/master@{#342693}
Fix border resizing on NTP
BUG=495968
Review URL: https://codereview.chromium.org/1287493002
Cr-Commit-Position: refs/heads/master@{#342692}
Refresh Public Suffic List to the latest version
This updates to the now-canonical upstream Github repository at
https://github.com/publicsuffix/list
This updates to the following revision:
3c153e3947dd6ee130c3f8706955281fa9923ed4 (2015-08-07)
[email protected]
BUG=37436
Review URL: https://codereview.chromium.org/1283593002
Cr-Commit-Position: refs/heads/master@{#342691}
[Media Router] Add integration test for join failure.
BUG=510913
Review URL: https://codereview.chromium.org/1266003005
Cr-Commit-Position: refs/heads/master@{#342690}
Revert "Implements "chrome://appcache-internals" based on WebUI API"
This reverts commit 8fc82b21621f21ea8d2d8cb483cb14295d1f6e1f.
BUG=518954
[email protected]
Review URL: https://codereview.chromium.org/1283843003 .
Cr-Commit-Position: refs/heads/master@{#342689}
Add empty implementation of GetSystemMemoryInfo for IOS.
BUG=514221
Review URL: https://codereview.chromium.org/1264683004
Cr-Commit-Position: refs/heads/master@{#342688}
Create DependencyManager API.
This will be used in the telemetry binary_manager for the binary dependencies, and also the archive_info for the wpr and other dependency files.
BUG=510231
Review URL: https://codereview.chromium.org/1273223002
Cr-Commit-Position: refs/heads/master@{#342687}
Roll src/third_party/WebKit af67920:f59db51 (svn 200246:200259)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/af67920..f59db51
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1272143004
Cr-Commit-Position: refs/heads/master@{#342686}
Use sizeof(x) instead of arraysize(x) * sizeof(x[0])
/analyze warned that:
url_formatter.cc(543) : warning C6260: sizeof * sizeof is usually wrong
The code it was complaining about is in fact not wrong, but it is
confusing. The code uses the expression
arraysize(kIdnPrefix) * sizeof(base::char16)
when it would be simpler to use
sizeof(kIdnPrefix)
In addition to being simpler and clearer the sizeof expression doesn't
require knowing the type of kIdnPrefix in order to evaluate its
correctness.
[email protected]
BUG=427616
Review URL: https://codereview.chromium.org/1286503002
Cr-Commit-Position: refs/heads/master@{#342685}
relnote: Flag-protected by FLAGS_enable_quic_stateless_reject_support.
Add QuicClient and QuicTestClient support for stateless rejects.
QuicClient:
If the client receives a stateless reject, it will now re-try the
entire request with a new connection, since presumably any data sent
on the previous connection has been abandoned.
The method for getting a new ConnectionId has also been modified to
take in the server's id, which is necessary for stateless-rejects.
Add separate accounting for num hellos sent, since the underlying
connection may change during a stateless reject.
EndToEndTest:
Modified the end_to_end_test to exercise the new code.
Added a new end_to_end_test to exercise the 0-RTT QuicTestClient
synchronous request methodology. Otherwise, it could easily drift
away from supporting stateless-rejects without anyone's knowledge.
QuicTestClient:
Refactored the synchronous request methodology to share code with the
synchronous "custom" request methodology.
Merge internal change: 99562314
[email protected]
Review URL: https://codereview.chromium.org/1278293002
Cr-Commit-Position: refs/heads/master@{#342684}
Return Windows error code when create-process fails.
COULD_NOT_CREATE_PROCESS makes up about 10% of the setup errors; include the actual DWORD result code returned by ::CreateProcess by placing all result information into the proper location of the Registry for reading by Omaha.
BUG=
Committed: https://crrev.com/135f5f669574bd07eaedaf6b57503984aeb13be8
Cr-Commit-Position: refs/heads/master@{#341938}
Committed: https://crrev.com/41465440adac9c4ca529d42bc685eedb640c8eb7
Cr-Commit-Position: refs/heads/master@{#342528}
Review URL: https://codereview.chromium.org/1247993002
Cr-Commit-Position: refs/heads/master@{#342683}
Fix crash when counting number of open tabs.
When in the background, tab selectors aren't reliable. Early-out in this
case to avoid crashing.
BUG=507452
Review URL: https://codereview.chromium.org/1272263004
Cr-Commit-Position: refs/heads/master@{#342682}
Cleanup some bits in net/test
Fix some header guards and removed an unused file.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/1280363002
Cr-Commit-Position: refs/heads/master@{#342681}
Always play ChromeVox enabled/disabled sounds regardless of system sound enabled flag.
Currently, ChromeVox enabled/disabled sounds depend on a few conditions to be played:
- spoken feedback is enabled
- system sounds enabled flag is on in AccessibilityManager
(this depends on LoginDisplayImpl calling AccessibilityManager::EnableSystemSounds, which itself depends on the login prompt being shown).
This cl makes it so the enable/disable sounds no longer depend on the system sounds enabled flag. In effect, these two sounds are no longer system sounds, but ChromeVox sounds.
BUG=514466
Review URL: https://codereview.chromium.org/1285663002
Cr-Commit-Position: refs/heads/master@{#342680}
Use vector image resources in extension install dialog.
This also fixes this image for non-1x scale factors. This UI is visible
for example when installing the "Rock Solid Scale Reader" app.
BUG=505953
Review URL: https://codereview.chromium.org/1276903003
Cr-Commit-Position: refs/heads/master@{#342679}
Avoid setting effects on output devices if they weren't asked for.
BUG=376796
Review URL: https://codereview.chromium.org/1280663002
Cr-Commit-Position: refs/heads/master@{#342678}
Roll src/third_party/skia d22f37c:2a5ca89
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d22f37c..2a5ca89
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
2a5ca89 [email protected] Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are empty (patchset #1 id:1 of https://codereview.chromium.org/1284693002/ )
91d844d [email protected] Rename GrPipelineInfo to GrPipelineOptimizations
7fc2a26 [email protected] Move GrStrokeRectBatch creation to behind factory
ecd1a69 [email protected] Create GrRectBatchFactory
9d144ac [email protected] This is a speculative fix for the crash on IOS TBR=mtklein
d6b99cc [email protected] [TextBlob] Fall back to TightRunBounds when the font bounds are empty
9ff6425 [email protected] move Stroke Rect and AAFill Rect to their own file
3a26fc8 [email protected] Ensure that android "release" apps are signed with debug key
4f2b331 [email protected] SkPDF: add assert for that SkWStream behaves.
47dfc36 [email protected] Use a factory function to create GrPipeline and remove unused member
Review URL: https://codereview.chromium.org/1275133005
Cr-Commit-Position: refs/heads/master@{#342677}
ApplicationImpl cleanup, part 1:
- Remove ctor that does not take a termination closure.
- Terminate()->Quit()
- QuitNow()->private
[email protected]
BUG=none
Committed: https://crrev.com/46e34f6bc1c8424c383776e5961094c5df5d563b
Cr-Commit-Position: refs/heads/master@{#341028}
Review URL: https://codereview.chromium.org/1266643003
Cr-Commit-Position: refs/heads/master@{#342676}
content/gpu: Lay the groundwork for GPU streams on the client side.
GPU streams are intended as a way of multiplexing multiple streams of
execution on a single GPU channel. This CL lays the ground work on the
client side.
BUG=514809
Review URL: https://codereview.chromium.org/1258913004
Cr-Commit-Position: refs/heads/master@{#342675}
Currently, ResourceProvider memory dumps use IDs which may
collide with other ResourceProviders in the same process. This
patch appends the ResourceProvider pointer, ensuring they don't collide.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1284443003
Cr-Commit-Position: refs/heads/master@{#342674}
[Telemetry] Add telemetry.third_party for importing third-party modules
This CL adds telemetry.third_party, along with telemetry.third_party.mock as
an example of how to expose something through telemetry.third_party. To
complete the example, smoothness_unittest.py has been modified to use the new
method of importing through telemetry.third_party.
Note that as an unavoidable consequence of http://bugs.python.org/issue9072,
importing modules through telemetry.third_party makes it possible to write
things like:
from telemetry import third_party
import mock
but this is an edge case, and it seems like the long-term increase in
productivity that this change adds is worth this semantic oddity.
BUG=517500
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
Review URL: https://codereview.chromium.org/1276173004
Cr-Commit-Position: refs/heads/master@{#342673}
Pre-cache downloads directory path in PathUtils.
When Chrome tabs are swiped away and user starts Chrome again,
their default downloads directory is requested. This causes a
StrictMode policy violation since it results in a ~60ms disk
read. Thus by adding this call to the initial AsyncTask we
save that time when the directory is requested by native.
This must only be called in the browser process as the sandbox
processes do not need to make the call nor can they make the
call(results in NPE).
BUG=508615
Review URL: https://codereview.chromium.org/1281273003
Cr-Commit-Position: refs/heads/master@{#342672}
Implements "chrome://appcache-internals" based on WebUI API
Redid the "chrome://appcache-internals" page so that the new implementation is:
1- Based on "WebUIController" and similar to "chrome://indexed-db-internals".
2- Looks into "all" storage paritions when fetching application cache data.
This was previously reported as a bug since the application cache for <webview>
was not being shown on "chrome://appcache-internals".
BUG=343683
Review URL: https://codereview.chromium.org/1191383004
Cr-Commit-Position: refs/heads/master@{#342671}
cc: Declare high res tilings to not have low res content.
When a was-low-res tiling is made high res, we reset all the tiles, so
we can also reset the flag saying it has low res content in it. That
way we don't continually reset all the tiles in it.
R=enne, vmpstr
BUG=516500
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1274693004
Cr-Commit-Position: refs/heads/master@{#342670}
ipc: Make a common subclass for Channel and ProxyChannel.
Channel and ProxyChannel share some functionality which the attachment broker
code uses. I made a new, shared superclass called Endpoint.
BUG=493414
Review URL: https://codereview.chromium.org/1270683002
Cr-Commit-Position: refs/heads/master@{#342669}
Gets remainder of mojo directory passing gn check
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/1285603002
Cr-Commit-Position: refs/heads/master@{#342668}
Set the custom app icon for devtools in BrowserView::GetWindowIcon()
The purpose of this CL is to reduce the number of places which set the
NavigationEntry's favicon data
BUG=517089
TEST=None
Review URL: https://codereview.chromium.org/1271303003
Cr-Commit-Position: refs/heads/master@{#342667}
[Android] Detect when remote service loses contact with device.
Sometimes the service will lose communication with device.
BUG=512305
Review URL: https://codereview.chromium.org/1277943002
Cr-Commit-Position: refs/heads/master@{#342666}
Roll tools/grit DEPS 1dac9ae:f821b9d
Roll to revision 194, which contains missing
files for a unittest. See
https://codereview.chromium.org/1212703002/
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1285603003
Cr-Commit-Position: refs/heads/master@{#342665}
Update rationale for allowing StrictMode violations.
Since classic to document tab mode upgrade happens only once,
and further migrations are direct user actions in settings,
it is not worthwhile to further optimize this codepath.
Added comments to clarify intent and remove TODO.
BUG=493157
Review URL: https://codereview.chromium.org/1279763008
Cr-Commit-Position: refs/heads/master@{#342664}
[Cronet] Add a README doc for Cronet
This CL adds a README.md for Cronet. It also generates a html
file from the markdown file, and includes the html file as
the overview page in the javadoc.
BUG=428935
Review URL: https://codereview.chromium.org/1180733003
Cr-Commit-Position: refs/heads/master@{#342663}
Remove message asking for hate mail. Got enough.
[email protected]
BUG=none
TEST=less hate mail
Review URL: https://codereview.chromium.org/1281783005
Cr-Commit-Position: refs/heads/master@{#342662}
MD downloads: further simplify cr.ui.FocusRow code
Remove onActiveStateChanged: 1 derived used it to change active class name
[email protected]
BUG=425626
Review URL: https://codereview.chromium.org/1282073002
Cr-Commit-Position: refs/heads/master@{#342661}
[ETW] Add trace-export-events-to-etw to about:flags.
This allows users to activate/deactivate the feature much easier and make it sticky without having to play with shortcuts.
BUG=
Review URL: https://codereview.chromium.org/1280943003
Cr-Commit-Position: refs/heads/master@{#342660}
Replace ToLower calls to the new format
Replaces
base::StringToLowerASCII(string)
with
base::ToLowerASCII(string)
This form is 1:1 search and replace.
A bunch of places did something like this:
std::string foo(something_else);
base::StringToLowerASCII(&foo);
which became:
foo = base::ToLowerASCII(something_else);
A couple places really wanted in-place changing and they became:
foo = base::ToLowerASCII(foo);
There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting).
There was more cleanup in:
chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc
In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case.
NOPRESUBMIT=true
(due to touching code with wstrings)
Review URL: https://codereview.chromium.org/1279123004
Cr-Commit-Position: refs/heads/master@{#342659}
Add constant full page raster + scroll + checkerboard test
We don't currently handle constant full page invalidations
very well while scrolling and checkerboard a ton.
This test will help track upcoming checkerboarding
improvements and make sure we don't regress this particular
devil case.
BUG=486072
Review URL: https://codereview.chromium.org/1268233004
Cr-Commit-Position: refs/heads/master@{#342658}
Cache Storage: restrict access to secure origins (Chromium-side)
Follow-up to https://codereview.chromium.org/1177983007/ to terminate
renderers that send bogus cache storage access requests.
BUG=501380
[email protected],[email protected],[email protected],
Review URL: https://codereview.chromium.org/1192003006
Cr-Commit-Position: refs/heads/master@{#342657}
Notify NQE when the request finishes.
Notify NQE when the request finishes so NQE can keep track of which
requests are active. This would be used in throughput computation
in a later changelist. Also, change the existing notification to
notify NQE only when the headers are received (instead of on
every raw read).
BUG=502430
Review URL: https://codereview.chromium.org/1247723005
Cr-Commit-Position: refs/heads/master@{#342656}
Disable some unittests for MediaCodecPlayer temporarily
Disable till we figure out the reason of failure.
BUG=518900
Review URL: https://codereview.chromium.org/1275323004
Cr-Commit-Position: refs/heads/master@{#342655}
Remove FeatureUtilities.getCustomTabVisible()
Remove FeatureUtilities.getCustomTabVisible() and replace with calls to ChromeActivity.isCustomTab().
The FeatureUtilities value is unreliable (it's not set until onResumeWithNative()), so the activity
method should be used instead.
BUG=515159
Review URL: https://codereview.chromium.org/1265173002
Cr-Commit-Position: refs/heads/master@{#342654}
Fix UAF on libusb thread
BUG=518749
[email protected]
Review URL: https://codereview.chromium.org/1275223005
Cr-Commit-Position: refs/heads/master@{#342653}
Fix a double overflow issue when converting seconds to timeDelta
When converting a double to an int, if that causes overflow, the behavior is undefined.
BUG=514594
Review URL: https://codereview.chromium.org/1278893003
Cr-Commit-Position: refs/heads/master@{#342652}
Atomic: Notify Watcher to observe device fd
we always block on the main thread till the FD becomes
readable. With non-atomic code path, we always wait on a
worker thread to see if the device fd has become readable.
We want to do the same with Atomic, notify watcher to observe
if the device fd is readable in a separate thread (respecting is_sync value)
instead of blocking main thread.
BUG=
Review URL: https://codereview.chromium.org/1282723002
Cr-Commit-Position: refs/heads/master@{#342651}
Updating XTBs based on .GRDs from branch master
Cr-Commit-Position: refs/heads/master@{#342650}
Redesign bluetooth settings interface
[email protected]
BUG=516366
Review URL: https://codereview.chromium.org/1275773005
Cr-Commit-Position: refs/heads/master@{#342649}
Add slimming paint v2 command line switch and pref
(Requires blink change https://codereview.chromium.org/1277313002/)
R=chrishtr,jam
TBR=mkwst (a message field to pass the new pref)
Review URL: https://codereview.chromium.org/1284483002
Cr-Commit-Position: refs/heads/master@{#342648}
Add extra event to Tab.Discarding histogram to track discarding of tabs playing audio.
BUG=514340
Review URL: https://codereview.chromium.org/1275343003
Cr-Commit-Position: refs/heads/master@{#342647}
Swarm interactive_ui_tests on Linux GN.
Review URL: https://codereview.chromium.org/1282273003
Cr-Commit-Position: refs/heads/master@{#342646}
Linux: Depend on liberation-fonts package.
Without these fonts, text in the built-in PDF viewer may not display correctly.
BUG=369991
Review URL: https://codereview.chromium.org/1283543004
Cr-Commit-Position: refs/heads/master@{#342645}
Fix crash in ContextProviderMojo due to uninitialized member variable.
Review URL: https://codereview.chromium.org/1273783005
Cr-Commit-Position: refs/heads/master@{#342644}
This patch allows find-in-page to work on the Chrome signin page.
This is done by allowing any page with a single guest the possibility of handling a find request, and by implementing a way for different GuestView types to specify exactly when a guest of that type should handle a find request in place of its embedder. Right now, only MimeHandlerViews (in the case of PDFs) and WebViews (in the case of the chrome signin page) will potentially handle these requests.
BUG=463799
Review URL: https://codereview.chromium.org/1279833004
Cr-Commit-Position: refs/heads/master@{#342643}
Hooks up cross frame navigation requests
BUG=479172,490221
TEST=covered by tests
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/1280743004
Cr-Commit-Position: refs/heads/master@{#342642}
Update V8 to version 4.6.63.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/83ee1e68..eb3955e2
Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
[email protected],[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/1276513004
Cr-Commit-Position: refs/heads/master@{#342641}
Roll src/third_party/WebKit efb8dd8:af67920 (svn 200244:200246)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/efb8dd8..af67920
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1282833003
Cr-Commit-Position: refs/heads/master@{#342640}
Fix startup race in initializing DevToolsNetworkController.
DevToolsNetworkController is accessible from the UI half of the Profile, which
means that it must be created on the UI thread. It, however, is currently
created on the IO, so this doesn't work.
Instead, split into the single-threaded controller (no need for a Helper class
in unit tests) and a handle which does the cross-thread management. On the UI
thread, only DevToolsNetworkControllerHandle may be used. On the IO thread, a
Handle may be exchanged for the underlying controller.
BUG=515492
Review URL: https://codereview.chromium.org/1279603002
Cr-Commit-Position: refs/heads/master@{#342639}
Increase location disclosure snackbar duration.
This snackbar used to show for 5 seconds, but now shows for 8 seconds
since it has a fair amount of text. In accessibility mode, it shows for
15 seconds.
BUG=515562
Review URL: https://codereview.chromium.org/1272703006
Cr-Commit-Position: refs/heads/master@{#342638}
Mandoline telemetry: remove 'about:blank' hack and allow setting user agent to 'desktop'.
'about:blank' is supported by Mandoline now.
Besides, this CL allows setting user agent to 'desktop' for Mandoline.
Fully supporting the --browser-user-agent-type flag will be in a future
CL.
BUG=513789
Review URL: https://codereview.chromium.org/1281093003
Cr-Commit-Position: refs/heads/master@{#342637}
Remove useless use of StringPrintf("%s", ...)
std::string has a constructor which accepts a C string, so it is not
necessary to use StringPrintf() for this purpose.
BUG=
TEST=compile
Review URL: https://codereview.chromium.org/1274713008
Cr-Commit-Position: refs/heads/master@{#342636}
Add configs that depend on linux builder and linux builder (dbg).
This patch adds MB configs for the bots that try to match
'Linux Builder' and 'Linux Builder (dbg)' on chromium.linux.
This also fixes the Linux Builder definition to make sure swarming
is enabled.
[email protected]
BUG=481692
Review URL: https://codereview.chromium.org/1273943005
Cr-Commit-Position: refs/heads/master@{#342635}
Fix HistogramTester::GetAllSamples when empty.
Fix GetAllSamples to return an empty vector when the histogram has no
samples, instead of crashing.
BUG=
Review URL: https://codereview.chromium.org/1265403003
Cr-Commit-Position: refs/heads/master@{#342634}
Roll src/third_party/skia c5b7df4:d22f37c
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c5b7df4..d22f37c
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
d22f37c [email protected] Wire up testcreate function for GrDrawAtlasBatch
Review URL: https://codereview.chromium.org/1281243002
Cr-Commit-Position: refs/heads/master@{#342633}
Make chrome.settingsPrivate less crashy
Fix a null scoped_ptr dereference error when GetPref is called with a
pref key that doesn't correspond to an existing pref (e.g., if the
whitelist includes platform-specific prefs and getAllPrefs is called,
or getPref is called with an invalid key).
Also provide a meaningful error when getPref is called with a pref key
that does not correspond to an existing pref.
[email protected]
Review URL: https://codereview.chromium.org/1284603002
Cr-Commit-Position: refs/heads/master@{#342632}
Add histograms for usage of some weird HTTP/0.9 "features"
HTTP/0.9 over SSL, HTTP/0.9 on a socket previously used
to receive HTTP/1.x responses.
BUG=472762
Review URL: https://codereview.chromium.org/1281523007
Cr-Commit-Position: refs/heads/master@{#342631}
Roll src/third_party/WebKit d0bbdc6:efb8dd8 (svn 200242:200244)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d0bbdc6..efb8dd8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1275963004
Cr-Commit-Position: refs/heads/master@{#342630}
ui: ozone: add missing files to GN build
https://codereview.chromium.org/1128113011 added new files but forgot
to update the GN build files.
BUG=none
Review URL: https://codereview.chromium.org/1283783002
Cr-Commit-Position: refs/heads/master@{#342629}
Temporarily disabling WebRTC content browsertests under debug.
We seem to be hitting libjingle asserts after the aug 4/5 roll,
disabling the tests while investigating.
BUG=517977
Review URL: https://codereview.chromium.org/1282263003
Cr-Commit-Position: refs/heads/master@{#342628}
Enable new media playback UI for clank.
This CL enables the new media UI for clank, and the associated
clank-specific behavior to hide volme controls more often to
save screen space. Other platforms should not be affected.
To revert to the original UI, please revert only this commit.
The new UI code itself can be found in
https://codereview.chromium.org/1156993013 . The default behavior
of that CL, without this one, will be the original UI for all
platforms, including clank.
BUG=446350, 488625, 487344
Review URL: https://codereview.chromium.org/1266813002
Cr-Commit-Position: refs/heads/master@{#342627}
Avoid using two-phase read with MOJO_READ_DATA_FLAG_ALL_OR_NONE.
The issue is that when we get close to the end of data pipe's buffer, the call may fail because the distance between the read cursor to the end of the buffer is smaller than the requested size. In that case, even if the buffer contains sufficient data (possible because it is circular), such a read request will never succeed.
Please see https://github.com/domokit/mojo/issues/366 for more details.
BUG=513789
Review URL: https://codereview.chromium.org/1281073003
Cr-Commit-Position: refs/heads/master@{#342626}
Fix some HPACK comments, update links to RFC.
This CL lands server change 99395244 by rjshade.
BUG=345769
Review URL: https://codereview.chromium.org/1265413003
Cr-Commit-Position: refs/heads/master@{#342625}
Remove useless use of StringPrintf("%s", ...)
It is not necessary to use StringPrintf() to convert a C string to a
std::string, as std::string has a constructor which will perform the
conversion implicitly.
BUG=
TEST=compiled
Review URL: https://codereview.chromium.org/1280333002
Cr-Commit-Position: refs/heads/master@{#342624}
Reland of Preserve viewport scrolling layer when a fling starts (patchset #1 id:1 of https://codereview.chromium.org/1280113003/ )
Reason for revert:
The revert turned out to be unnecessary.
Original issue's description:
> Revert of Preserve viewport scrolling layer when a fling starts (patchset #2 id:20001 of https://codereview.chromium.org/1225693008/ )
>
> Reason for revert:
> Causes issues with WebView when the embedder overrides computeScroll.
>
> Original issue's description:
> > Preserve viewport scrolling layer when a fling starts
> >
> > A touch fling will lock the scrolling layer to the first layer that
> > scrolls after the animation begins. This can disrupt viewport scrolling
> > if the outer viewport was the originally targetted scroll layer, e.g.,
> > by resetting bookkeeping for scrollbar fade animations. Prevent this
> > by allowing scroll bubbling if the viewport is the locked layer when
> > the fling starts.
> >
> > BUG=507786
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/89192797b50f7e33967445095cd7fa16b78f68e1
> > Cr-Commit-Position: refs/heads/master@{#337747}
>
> [email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=507786,516362
>
> Committed: https://crrev.com/7168c3a89473e240d8d9692fbf21606b58321082
> Cr-Commit-Position: refs/heads/master@{#342514}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507786,516362
Review URL: https://codereview.chromium.org/1284683003
Cr-Commit-Position: refs/heads/master@{#342623}
ash: Add a base-class for interactive-ui-tests in ash.
Introduce AshInteractiveUITestBase for setting up gl, resources, aura for interactive
ui-tests that live in ash.
BUG=none
Review URL: https://codereview.chromium.org/1282433003
Cr-Commit-Position: refs/heads/master@{#342622}
[Android] Convert RestartAdbd to DeviceUtils again.
BUG=267773
Review URL: https://codereview.chromium.org/1282563003
Cr-Commit-Position: refs/heads/master@{#342621}
Turn off query in the omnibox.
Turns off the functionality for Android and iOS.
BUG=517297
Review URL: https://codereview.chromium.org/1270343005
Cr-Commit-Position: refs/heads/master@{#342620}
Mark ContentViewCoreSelectionTest#testSelectActionBarPasswordPaste flaky
BUG=518848
[email protected]
NO_TRY=true
Review URL: https://codereview.chromium.org/1283763002
Cr-Commit-Position: refs/heads/master@{#342619}
Roll src/third_party/WebKit b877cfb:d0bbdc6 (svn 200241:200242)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b877cfb..d0bbdc6
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1281783003
Cr-Commit-Position: refs/heads/master@{#342618}
[DevTools] Report target detached on non-error termination of render process.
BUG=513940
Review URL: https://codereview.chromium.org/1258073002
Cr-Commit-Position: refs/heads/master@{#342617}
[telemetry][Android] Fix tcp port logging on forwarder failure.
See http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf/builds/5102
BUG=
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1281233002
Cr-Commit-Position: refs/heads/master@{#342616}
GC plugin: consider references equal to raw pointers.
Unmanaged raw pointers to managed(GC) classes aren't safe across GCs,
hence fields with raw pointer types to such GCed classes are identified
and reported as errors or warnings.
Extend that checking to also apply to reference pointer types.
R=haraken
BUG=420515
Review URL: https://codereview.chromium.org/1274403002
Cr-Commit-Position: refs/heads/master@{#342615}
Roll src/third_party/skia 021f631:c5b7df4
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/021f631..c5b7df4
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
c5b7df4 [email protected] Remove an unused function.
Review URL: https://codereview.chromium.org/1282723003
Cr-Commit-Position: refs/heads/master@{#342614}
Enable UseDelayAgnosticAEC by default in chromium builds
This also enables this trial in buildbots and such.
BUG=450193
Review URL: https://codereview.chromium.org/1276223003
Cr-Commit-Position: refs/heads/master@{#342613}
Fix suffix OnPSLMatching to OnPSLMatchingRealm with PasswordManager histograms in histograms.xml
[email protected],[email protected]
[email protected]
BUG=517422
Review URL: https://codereview.chromium.org/1282223002
Cr-Commit-Position: refs/heads/master@{#342612}
[iOS] Upstream connection_type_observer_bridge
BUG=429756
Review URL: https://codereview.chromium.org/1271273004
Cr-Commit-Position: refs/heads/master@{#342611}
Roll src/third_party/WebKit 7d8d931:b877cfb (svn 200239:200241)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7d8d931..b877cfb
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1272813004
Cr-Commit-Position: refs/heads/master@{#342610}
Fix a few CHECK_JNI failures.
Passed in jobjects should not be released.
Using ScopedLocalJavaRef(env, jobject) with a parameter passed in from
JNI adopts the jojbect from the param and incorrectly tries to release
it.
Review URL: https://codereview.chromium.org/1278823006
Cr-Commit-Position: refs/heads/master@{#342609}
Ensure that the button to import supervised users is disabled if the custodian is not signed in.
BUG=475494
Review URL: https://codereview.chromium.org/1268903002
Cr-Commit-Position: refs/heads/master@{#342608}
Add VP9 raw bits reader
TEST=media_unittests
BUG=509500
Review URL: https://codereview.chromium.org/1258083003
Cr-Commit-Position: refs/heads/master@{#342607}
Implementing webrtc::DtlsIdentityStoreInterface, which will replace webrtc::DTLSIdentityServiceInterface.
Keeping both the service and store versions during the transition period from service to store.
This is CL is part of an effort to land https://codereview.webrtc.org/1176383004 without breaking Chromium.
See bug for more information.
BUG=webrtc:4899
Review URL: https://codereview.chromium.org/1181013015
Cr-Commit-Position: refs/heads/master@{#342606}
Roll src/third_party/WebKit c7767e6:7d8d931 (svn 200237:200239)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7767e6..7d8d931
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1270293006
Cr-Commit-Position: refs/heads/master@{#342605}
Gallery: fix cursor of buttons.
In addition to edit, view buttons (described in the issue), this CL also
fixes cursor of buttons in the bottom toolbar.
BUG=516629
TEST=none
Review URL: https://codereview.chromium.org/1283723004
Cr-Commit-Position: refs/heads/master@{#342604}
Mac Overlays: Add GPU back-pressure
Issue a GL fence after every SwapBuffers. Do not call -[CALayer
setContents:] with the content being rendered by that SwapBuffers until
the fence has passed.
Query the previous's frame's GL fence at the beginning of each
SwapBuffers. Also issue a callback to query the GL fence at the
mid-point of the VSync period (if there is no subsequent SwapBuffers,
or if the frame takes more than one VSync to render).
Note that waiting for the GL fence to complete before calling -[CALayer
setContents] is not required for correctness -- only the expected content
(everything before the glFlush) will appear in the layer. Rather, the
reason for waiting for the GL fence is to make the time at which the
content will appear on-screen more reliable.
Because there may be multiple calls to SwapBuffers in flight, store the
data necessary to call -[CALayer setContents] in a PendingSwap
structure. Maintain a queue of these structures.
Because the ImageTransportSurface does not know anything about the
VSync period, send the CGDirectDisplayID for the attached display to the
ImageTransportSurface in the AcceleratedSurfaceMsg_BufferPresented IPC
(which is where the CGL renderer ID is already communicated). Send this
information instead of the raw VSync parameters so that the updates to
all windows on a single display may be coalesced into a single callback
in the future.
Note that this display is the display that is used for vsync by the
RenderWidgetHostViewMac, so if vsync is disabled, it will be 0.
Separate gfx::ScopedSetGLToRealGLApi into its own header file to
simplify header orders.
Access the IOSurface of the GLImageIOSurface directly, rather than
using its ScheduleOverlayPlane method. This simplifies things
immediately, in that we can reason about the underlying IOSurface's
lifetime better than weak pointers to images. It will also simplify
the implementation of partial swap and multiple overlays.
BUG=515696
Committed: https://crrev.com/5c207cac73c835b5f362670d6b46333dfae1f4c4
Cr-Commit-Position: refs/heads/master@{#342548}
Review URL: https://codereview.chromium.org/1273563002
Cr-Commit-Position: refs/heads/master@{#342603}
ExtensionSyncService cleanup
Remove the extension_prefs_ and extension_service_ members; just query them on demand.
BUG=None
Review URL: https://codereview.chromium.org/1271273002
Cr-Commit-Position: refs/heads/master@{#342602}
Move Service Worker %2f validation logic from browser into Blink (3)
This patch ensures that a compromised renderer is still unable to
register Service Workers with an invalid scope or scriptURL (see
bug for spec details).
1. (Chromium) https://codereview.chromium.org/1259213002
2. (Blink) https://codereview.chromium.org/1260003003/
3. (Chromium) This CL.
BUG=513622
R=nhiroki, falken
Review URL: https://codereview.chromium.org/1256833004
Cr-Commit-Position: refs/heads/master@{#342601}
Reland of Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium] (patchset #1 id:1 of https://codereview.chromium.org/1258893004/ )
Reason for revert:
LayoutTest failure was fixed by https://codereview.chromium.org/1274973002/
Original issue's description:
> Revert of Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium] (patchset #1 id:40001 of https://codereview.chromium.org/1242953007/)
>
> Reason for revert:
> This broke http/tests/serviceworker/fetch-request-fallback.html, causing failures on 3 bots and timeouts on 18 bots.
>
> See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Ffetch-request-fallback.html&testType=layout-tests
>
> Original issue's description:
> > Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium]
> >
> > We are sending CORS fallback response from the browser process to the page's renderer process, when the ServiceWorker doesn't handle the CORS fetch request.
> > But when the request URL's origin is same as the page's security origin, we can skip the fallback and send the request from the browser process.
> >
> > This change will improve the delay of the CORS fallback for same origin requests, especially when the renderer main thread is busy.
> >
> > 1/2 blink: https://codereview.chromium.org/1243353002/
> > 2/2 chromium: this cl.
> >
> > BUG=512764
> >
> > Committed: https://crrev.com/97b13409b0c601f21f048744fa8e31852b476337
> > Cr-Commit-Position: refs/heads/master@{#341482}
>
> [email protected],[email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=512764
>
> Committed: https://crrev.com/ac2794675706a635dd3e54245c27f64411927a6c
> Cr-Commit-Position: refs/heads/master@{#341499}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=512764
Review URL: https://codereview.chromium.org/1282193002
Cr-Commit-Position: refs/heads/master@{#342600}
Roll src/third_party/WebKit f6a11a8:c7767e6 (svn 200234:200237)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f6a11a8..c7767e6
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1275573003
Cr-Commit-Position: refs/heads/master@{#342599}
Fix typo in name of PasswordManager.TotalAccountsHiRes in histograms.xml.
[email protected]
[email protected], [email protected]
BUG=515822
Review URL: https://codereview.chromium.org/1270293005
Cr-Commit-Position: refs/heads/master@{#342598}
Appease jschuh@ by adding a field trial to move 'plugin' to blockable mixed content.
BUG=513163
Review URL: https://codereview.chromium.org/1260163005
Cr-Commit-Position: refs/heads/master@{#342597}
Forward "include_dirs" to executable target in "ios_app" template.
Many unit tests targets sets "include_dirs" variable. As the "test"
template uses "ios_app" on iOS, the content needs to be forwarded
to the "executable" target since it is the one doing the compilation.
Fixes the following error when running "gn gen" for iOS after adding
//net:net_unittests to the list of targets in //BUILD.gn:
ERROR at //ui/events/BUILD.gn:360:18: Assignment had no effect.
include_dirs = [ "//testing/gmock/include" ]
^---------------------------
You set the variable "include_dirs" here and it was unused before it went
out of scope.
BUG=459705
Review URL: https://codereview.chromium.org/1280983003
Cr-Commit-Position: refs/heads/master@{#342596}
Fix incorrect dependency on "//cc" in "//skia".
iOS cannot depends on //cc (nor //media) so put the dependency behind
an !is_ios condition.
Fix the following error when running "gn gen" for iOS after adding
//skia:skia_unittests to //BUILD.gn:
ERROR at //media/BUILD.gn:697:3: Assignment had no effect.
configs += [ ":media_config" ]
^----------------------------
You set the variable "configs" here and it was unused before it went
out of scope.
Note that the error is the dependency on //media (which is not
supported on iOS).
BUG=459705
Review URL: https://codereview.chromium.org/1279453004
Cr-Commit-Position: refs/heads/master@{#342595}
Added browser tests to chrome.enterprise.deviceAttributes API
Modified the existing tests to use an actual extension.
This allowed adding a new test to ensure that only extensions pre-installed by policy can use the new API.
BUG=502330
Review URL: https://codereview.chromium.org/1281893002
Cr-Commit-Position: refs/heads/master@{#342594}
Make Linux password backends to handle the duplicate logins correctly on Add/Update/Remove.
The CL changes Add/Update/Remove so that they overwrite correctly the multiple credentials with the same sync tag.
The implementation is fixed so the methods don't return false causing a fallback from the Keyring to LoginDatabase.
The tests are strengthened to check the return value for most of the methods.
BUG=489766
Review URL: https://codereview.chromium.org/1280863003
Cr-Commit-Position: refs/heads/master@{#342593}
Editing iOS sources for //net.
Check that the list of files build with gn and gyp are the same.
BUG=BUG=459705
Review URL: https://codereview.chromium.org/1272193002
Cr-Commit-Position: refs/heads/master@{#342592}
Upstream uikit_util additions.
Upstream additions from downstream CL.
BUG=
Review URL: https://codereview.chromium.org/1278653003
Cr-Commit-Position: refs/heads/master@{#342591}
Support XCode's "Right to Left Pseudolanguage" on iOS.
XCode can run apps with a "Right to Left Pseudolanguage" application
language setting, which sets the AppleTextDirection user defaults
key. iOS will treat whatever the current language is as a RTL language
if this key is set. This CL adds a test for this key in
GetTextDirectionForLocale() so that g_icu_text_direction will agree
with iOS about what the current text direction is.
BUG=514625
Review URL: https://codereview.chromium.org/1254933002
Cr-Commit-Position: refs/heads/master@{#342590}
Disable failing android test OfflinePageBridgeTest#testAddOfflinePageAndLoad
BUG=518758
[email protected]
Review URL: https://codereview.chromium.org/1281213002
Cr-Commit-Position: refs/heads/master@{#342589}
Componentize //chrome/browser/prefs/tracked.
Componentize //chrome/browser/prefs/tracked and
updated corresponding .gypi files for same.
Moved the files from //chrome/browser/prefs/tracked
to //components/user_prefs/tracked.
Also added new //components/user_prefs/pref_names.* file and added BUILD.gn for same
BUG=507660
Review URL: https://codereview.chromium.org/1227973003
Cr-Commit-Position: refs/heads/master@{#342588}
Roll src/third_party/WebKit ac85d1f:f6a11a8 (svn 200233:200234)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ac85d1f..f6a11a8
TBR=
Review URL: https://codereview.chromium.org/1281203002
Cr-Commit-Position: refs/heads/master@{#342587}
Add flag to show toolkit-views dialogs on Mac, start with HTTP-Auth.
We want to perform a side-by-side comparison of views and Cocoa using a
representative set of browser dialogs on Mac.
Adds --enable-mac-views-dialogs and a corresponding chrome://flag for this.
Initially, the conversion necessary to optionally provide views-based HTTP-
Auth dialogs on Mac is performed.
Dialogs are typically provided for a platform by providing a cross-platform
function prototype, which is defined either in c/b/ui/views or c/b/ui/cocoa.
To allow a principally Cocoa build to call both, the views definition needs to
be "aliased" to avoid a symbol conflict.
The approach is thus:
- Provide Views-only function prototype aliases in c/b/ui/browser_dialogs.h
- Cocoa includes this to optionally provide a views dialog instead at runtime
- A "fallback" file (c/b/ui/views/browser_dialogs_views.cc) for non-Mac-Cocoa
builds provides the original/unaliased definitions, which always call the
alias.
This approach minimizes disruption to callsites, and keeps most of the create-
dialog logic where it already is. (For example, login_prompt_views.cc, which
doesn't have a corresponding header so moving the logic would be problematic).
It also keeps the "fallback" file simple and mechanical in nature.
For the first dialog, there's a 60kB impact to sizes on Mac. This is partly
due to there being (temporarily) two versions of this dialog, but also because
the first dialog will explore some new codepaths previously culled at link
time (mostly related to views textfields).
BUG=511051
TEST=On Mac, enable the flag and go to an HTTP-Auth site (e.g. apted.net/chat).
The dialog should be views-based: currently it's longer/narrower, but some
simple tweaks (see http://crbug.com/506150#c5) will make them almost
indistinguishable.
Review URL: https://codereview.chromium.org/1274083002
Cr-Commit-Position: refs/heads/master@{#342586}
Roll src/third_party/WebKit 567819d:ac85d1f (svn 200232:200233)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/567819d..ac85d1f
TBR=
Review URL: https://codereview.chromium.org/1279123005
Cr-Commit-Position: refs/heads/master@{#342585}
Correctly round document dimensions before comparing them to window dimensions in PDF viewer
This corrects the computation to determine whether scrollbars will be shown in the
PDF viewer by rounding the document dimensions.
BUG=517333
Review URL: https://codereview.chromium.org/1280233002
Cr-Commit-Position: refs/heads/master@{#342584}
Disable flaky test SitePerProcessBrowserTest.PostMessageWithSubframeOnOpenerChain on windows
This test is particularly flaky on windows.
BUG=518729
[email protected]
Review URL: https://codereview.chromium.org/1282753002
Cr-Commit-Position: refs/heads/master@{#342583}
Web MIDI: add usage metrics
BUG=465661
Review URL: https://codereview.chromium.org/1269813007
Cr-Commit-Position: refs/heads/master@{#342582}
Improve default captioning font test behavior on Lollipop
On Lollipop, captioning fonts are selected in order of precedence
according to the system dialog. As such, if a monospace font is
requested, "sans-serif-monospace" is returned. On KitKat,
"monospace" is returned".
The CaptioningChangeDelegateTest previously only tested the KitKat
behavior, which fails on Lollipop. This updates the tests to
account for the change in logic.
BUG=518003
Review URL: https://codereview.chromium.org/1281923007
Cr-Commit-Position: refs/heads/master@{#342581}
PDF: Use chrome.tabs.update() to navigate, when possible.
BUG=517780
Review URL: https://codereview.chromium.org/1275173004
Cr-Commit-Position: refs/heads/master@{#342580}
Roll src/third_party/WebKit 77aa44c:567819d (svn 200229:200232)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/77aa44c..567819d
TBR=
Review URL: https://codereview.chromium.org/1278033004
Cr-Commit-Position: refs/heads/master@{#342579}
[telemetry][Android] Revise logging on adb forward failure.
BUG=
[email protected],[email protected]
Review URL: https://codereview.chromium.org/1280033005
Cr-Commit-Position: refs/heads/master@{#342578}
CallbackPromiseAdapter types should be more compatible with WebCallbacks (2/3).
This series of CLs makes CallbackPromiseAdapter (CPA) more compatible with
WebCallbacks (WC) in terms of type parameters.
Before this CL, CPA<S, T> corresponded to WC<S::WebType*, T::WebType*>. CPAs
took ownership of passed pointers but there was no place to represent that in
WebCallbacks.
This series of CLs changes that: CPA<S, T> correspond to WC<S::WebType,
T::WebType>. CPA users can specify if he/she wants the parameter ownership by
specifying the type parameter. For example, setting S::WebType to OwnPtr<X>
means it takes ownership. Setting S::WebType to |const X&| means it doesn't
take ownership.
WebCallbacks is exposed to chromium side, so we use WebPassOwnPtr as the
counterpart of PassOwnPtr.
[1] https://codereview.chromium.org/1234603003/
[2] This CL.
[3] https://codereview.chromium.org/1240763002/
BUG=493531
Review URL: https://codereview.chromium.org/1235083006
Cr-Commit-Position: refs/heads/master@{#342577}
Roll src/third_party/skia 41838a0:021f631
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/41838a0..021f631
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Commits in this roll:
021f631 [email protected] api helpers inspired by blink use-cases
Review URL: https://codereview.chromium.org/1277423002
Cr-Commit-Position: refs/heads/master@{#342576}
Roll src/third_party/WebKit 3f691bb:77aa44c (svn 200228:200229)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3f691bb..77aa44c
TBR=
Review URL: https://codereview.chromium.org/1284593002
Cr-Commit-Position: refs/heads/master@{#342575}
Refresh the rest of devices even if some devices get errors.
When resuming the device, DiskMountManager tries to remount all removable
device. However if the removable device was detached during suspend, it
encounters error when calling GetDeviceProperties and it stopps to remount the
all other devices.
The CL changes the behavior so that DiskMountManager continue to remounting even
if it fails to fetch properties of one device.
BUG=514012
TEST=None
Review URL: https://codereview.chromium.org/1281513002
Cr-Commit-Position: refs/heads/master@{#342574}
Updating trunk VERSION from 2478.0 to 2479.0
Cr-Commit-Position: refs/heads/master@{#342573}
Remove deprecated CONTENT_SETTINGS_TYPE_METRO_SWITCH_TO_DESKTOP content setting
This content setting was used for a "Don't ask again" button on the Metro mode infobar, but it appears that got removed at the behest of UI review (https://codereview.chromium.org/23591005) a while ago, so we can remove the setting completely.
BUG=512683
Review URL: https://codereview.chromium.org/1274383002
Cr-Commit-Position: refs/heads/master@{#342572}
Add debug logging to ImeAdapter and change function name
This is a non-functional change to ImeAdapter.java that can help
debug IME issues.
BUG=502151
Review URL: https://codereview.chromium.org/1267293002
Cr-Commit-Position: refs/heads/master@{#342571}
tools/gn: Remove includes of basictypes.h.
We can just use the standard integer types from stdint.h now that our
toolchain supports it and include macros.h for DISALLOW macros.
BUG=138542
TEST=gn and gn_unittests builds
[email protected]
Review URL: https://codereview.chromium.org/1280123005
Cr-Commit-Position: refs/heads/master@{#342570}
Roll thirdparty/class-dump to fix build for the latest Xcode.
This is a reland of https://codereview.chromium.org/1270383005/,
which broke Xcode builds.
BUG=517930
Review URL: https://codereview.chromium.org/1275273003
Cr-Commit-Position: refs/heads/master@{#342569}
