Publish DEPS for Chromium 41.0.2272.57
Incrementing VERSION to 41.0.2272.57
Cr-Commit-Position: refs/branch-heads/2272@{#282}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge "cros: Fix offline login."
> - Fix the wrong arg of gaia_auth offline login;
> - Add test;
>
> BUG=454398,457436
> TEST=LoginTest.GaiaAuthOffline
>
> Review URL: https://codereview.chromium.org/916223002
>
> Cr-Commit-Position: refs/heads/master@{#315993}
> (cherry picked from commit e1aca1a653acacbb118af0bf6982944a1b0740eb)
[email protected]
Review URL: https://codereview.chromium.org/917283002
Cr-Commit-Position: refs/branch-heads/2272@{#281}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.56
Cr-Commit-Position: refs/branch-heads/2272@{#280}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Quick fix for ChromeVox braille flakiness.
The libluis wrapper depends on the load event to fier when
the nacl component is loaded to initialize the braille
translator. Somehow, this doesn't fire during startup unless
a message is sent to the component which causes braille translation
to not work at all, resulting in no braille output on the display
at all.
This is a minimal workaround intended for backporting to the M-41 branch while
the real cause can be investigated and addressed.
BUG=455889
[email protected]
Review URL: https://codereview.chromium.org/905353002
Cr-Commit-Position: refs/heads/master@{#315319}
(cherry picked from commit 25651009b2e8af7a9f484cba914c57352e571750)
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/920013002
Cr-Commit-Position: refs/branch-heads/2272@{#279}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
When sanitizing the referrer in navigation entries, also sanitize the page state
BUG=450589
[email protected]
Review URL: https://codereview.chromium.org/909083002
Cr-Commit-Position: refs/heads/master@{#315556}
(cherry picked from commit 24400c7d90538168bc1c6896418a99484ac9ddfd)
Review URL: https://codereview.chromium.org/923443002
Cr-Commit-Position: refs/branch-heads/2272@{#278}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
MidiManagerUsb should not trust indices provided by renderer.
MidiManagerUsb::DispatchSendMidiData takes |port_index| parameter. As it is
provided by a renderer possibly under the control of an attacker, we must
validate the given index before using it.
BUG=456516
Review URL: https://codereview.chromium.org/907793002
Cr-Commit-Position: refs/heads/master@{#315303}
(cherry picked from commit 5576cbc1d3e214dfbb5d3ffcdbe82aa8ba0088fc)
[email protected]
Review URL: https://codereview.chromium.org/916223003
Cr-Commit-Position: refs/branch-heads/2272@{#277}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.55
Cr-Commit-Position: refs/branch-heads/2272@{#276}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
V4L2SVDA: Drop any pending slices/state in H264Accelerator on reset.
Drop any pending (not yet submitted to hardware) slices on reset.
TEST=vdatest
BUG=chrome-os-partner:35773,chrome-os-partner:36110,chrome-os-partner:36013
Review URL: https://codereview.chromium.org/906253002
Cr-Commit-Position: refs/heads/master@{#315505}
(cherry picked from commit 160ca6a8b1dd5d52505bcf9e7c3dfa696289beb7)
Review URL: https://codereview.chromium.org/916303002
Cr-Commit-Position: refs/branch-heads/2272@{#275}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Android: Don't attempt to read /self/proc/exe during GPU launch
This seems to sometimes fail (it's racy) on certain systems
(Android versions most likely). Skip this call as it's not useful
on Android anyways.
BUG=457595,447735,457900
[email protected]
Review URL: https://codereview.chromium.org/921533002
(cherry picked from commit 7bd544c7b17076f21830be1c543f90d3c6fad53b)
Cr-Original-Commit-Position: refs/heads/master@{#315881}
Cr-Commit-Position: refs/branch-heads/2272@{#274}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "Revert "Android: Fix GPU recovery issues""
This reverts commit 26c81a4a0d763e1f4ca21bbfedec64ca3675acfa.
Reverting original revert, as the issue will hopefully be fixed by a seperate
checkin (https://codereview.chromium.org/921533002/)
Cr-Commit-Position: refs/branch-heads/2272@{#273}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Do not center the app list if an accelerometer is detected.
This logic was originally designed to allow TouchView-enabled devices to
always show the centered app list. However, it gives false positives for
devices with accelerometers that do not support TouchView mode.
Therefore, we are removing this logic.
Devices that support TouchView mode are now explicitly passing the
--enable-centered-app-list flag to Chrome, so they will still show the
centered app list.
TEST=With flag 'enable-experimental-app-list' disabled, open the app
launcher. It should be centered on TouchView-enabled devices, and in the
lower left corner on other devices.
BUG=454570
Review URL: https://codereview.chromium.org/877763005
Cr-Commit-Position: refs/heads/master@{#315713}
(cherry picked from commit df11facbd0dd11a719fe368b6cc4399aeb5b8114)
[email protected],[email protected]
Review URL: https://codereview.chromium.org/915093003
Cr-Commit-Position: refs/branch-heads/2272@{#272}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix ChromeSwitchCompat thumb drawable and tint color
This is a temporary workaround until we can roll the support library with
their fixes for these issues.
BUG=455327
NOTRY=true
Review URL: https://codereview.chromium.org/912533003
Cr-Commit-Position: refs/heads/master@{#315434}
[email protected]
Review URL: https://codereview.chromium.org/916493002
Cr-Commit-Position: refs/branch-heads/2272@{#271}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] ProfileInfoCache: Don't delete ProfileAvatarDownloader while we're being called by it
BUG=453795
[email protected]
Review URL: https://codereview.chromium.org/890873004
Cr-Commit-Position: refs/heads/master@{#313937}
(cherry picked from commit af25550b46f4aaf597420638aa895db7ebe2657f)
Review URL: https://codereview.chromium.org/914423002
Cr-Commit-Position: refs/branch-heads/2272@{#270}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] [Profiles] Send out less profile avatar related notifications
With the new profiles UI and the high res avatar downloading code, we are sending out
waaaay too many OnProfileAvatarChanged notifications. This is particularly terrible on
Windows, where basically on every Chrome startup we refresh all the icons.
Most importantly, we need to stop downloading the avatar files every time profiles get
loaded in the ProfileInfoCache. We did this originally because the avatar files were pretty
volatile, but it's safe to assume they've stopped changing.
Secondly, the only things that care about the high res avatar files are the UserManager
and the profile switcher, so they should get a special notification that this particular
file is ready, rather that annoy all the other listeners who only care about the tiny avatars.
BUG=449569
[email protected]
Review URL: https://codereview.chromium.org/861053004
Cr-Commit-Position: refs/heads/master@{#313593}
(cherry picked from commit 28693ab216bb923b2e3dd1a849ecfa59afe75b18)
Review URL: https://codereview.chromium.org/902403003
Cr-Commit-Position: refs/branch-heads/2272@{#269}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M41 (2272): Make elevation icon size correct in different DPI settings
BUG=449731
Review URL: https://codereview.chromium.org/849543003
Cr-Commit-Position: refs/heads/master@{#312458}
(cherry picked from commit 5a36bfe017b8c4408b8816246e07abcec96e0781)
Review URL: https://codereview.chromium.org/913303003
Cr-Commit-Position: refs/branch-heads/2272@{#268}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add ID to dummy extension during permission check
This is important so that the permissions will be consistent between
the dummy extension and the extension that is about to be installed.
BUG=450896
Review URL: https://codereview.chromium.org/862283002
Cr-Commit-Position: refs/heads/master@{#312686}
(cherry picked from commit a2752c14925409807eb4022ef79dfc736b4a883c)
Review URL: https://codereview.chromium.org/915163002
Cr-Commit-Position: refs/branch-heads/2272@{#267}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.54
Cr-Commit-Position: refs/branch-heads/2272@{#266}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "Android: Fix GPU recovery issues"
This reverts commit 9620196b9c71cc77de096d8d1ea1babc86c717b5.
This looks to be causing a beta blocker crash issue - reverting on
beta branch only
BUG=457595
Cr-Commit-Position: refs/branch-heads/2272@{#265}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Temporary disable VP8 HW video decoding on Android Exynos and MediaTek devices while HW decoder video freezes and distortions are investigated.
NOTRY=true
BUG=446974, https://code.google.com/p/webrtc/issues/detail?id=4056
Review URL: https://codereview.chromium.org/866923003
Cr-Commit-Position: refs/heads/master@{#313094}
(cherry picked from commit 3e7f7d831991be8c6e3213d33bdfae68b0cb686c)
Review URL: https://codereview.chromium.org/886813005
Cr-Commit-Position: refs/branch-heads/2272@{#264}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Most Visited] Also check if ProfileSyncService is done configuring
There is a state where Sync is initialized but not "configured". We now query both before determining if we should verify history sync state.
BUG=435663
Review URL: https://codereview.chromium.org/916443004
(cherry picked from commit cd0b0383e0eefdc8ca7daa6f10200bc9cfc4f0f2)
Cr-Original-Commit-Position: refs/heads/master@{#315652}
Cr-Commit-Position: refs/branch-heads/2272@{#263}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M-41 (2272): For DirectWrite font metrics use the average character width from the TEXTMETRIC structure.
Currently we fetch the average character width from the GetTextExtentPoint32 API for DirectWrite as skia
does not return this value. The width returned by the GetTextExtentPoint32 API is 1 px larger than the one
reported by the TEXTMETRIC structure causing some dialogs like the bookmark editor to display much larger than that
with GDI.
We now use the average character width from the TEXTMETRIC structure while reporting back the metrics for DirectWrite
fonts. Longer term fix is to find out a way to calculate this from DirectWrite. Does not appear to be straigthforward.
Added a TODO to that effect in the code.
BUG=434588
TEST=Updated the PlatformFontWinTest.Metrics_SkiaVersusGDI test to validate the average character widths.
For manual test, launch Chrome and open the bookmark
editor on Windows 7+. Observe that the window size is larger than the window size when using GDI for fonts.
Review URL: https://codereview.chromium.org/875303003
Cr-Commit-Position: refs/heads/master@{#313801}
(cherry picked from commit 0852634071b072ab41e1b255075652cf4c29a0df)
Review URL: https://codereview.chromium.org/903483004
Cr-Commit-Position: refs/branch-heads/2272@{#262}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merging fix for issue 455291
Prevent Meta Info from being overwritten due to reordering of entries.
This fixes a client side issue that contributes to crbug.com/439110.
The code that updates Sync Data with meta info from bookmark model is changed
to verify whether the new meta info is equivalent to the original one to avoid
doing an unnecessary mutation due to reordering of entries. The reordering occurs
due to sorting by key when MetaInfo is retrieved from BookmarkSpecifics in the
first place and added to MetaInfoMap.
BUG=455291
[email protected]
Original Review URL: https://codereview.chromium.org/896073002
Cr-Commit-Position: refs/heads/master@{#314840}
(cherry picked from commit a2ef17dfc09c595f16c5a097fd1a483acb66a481)
Review URL: https://codereview.chromium.org/911193003
Cr-Commit-Position: refs/branch-heads/2272@{#261}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Disable the inconsistent group policy check in the installer.
Leave it to Google Update to decide how to interpret Group Policy
settings.
BUG=none
[email protected], [email protected]
Review URL: https://codereview.chromium.org/915673002
Cr-Commit-Position: refs/branch-heads/2272@{#260}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Correctly clear deprecated "proxy" pref set by data reduction proxy.
Clear empty "proxy" dictionary created by bug in data reduction proxy code.
BUG=448172
Review URL: https://codereview.chromium.org/893333002
Cr-Commit-Position: refs/heads/master@{#314593}
(cherry picked from commit 253dde8ec63036f390dd6315c3e156b0d7ab662b)
Review URL: https://codereview.chromium.org/909013007
Cr-Commit-Position: refs/branch-heads/2272@{#259}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] <webview> fix drag and drop issues.
This CL makes sure following scenarios work properly on mac/linux/cros/win:
1. Dragging and dropping within a <webview> works
2. Dragging from one <webview> to another <webview> works.
3. Dragging from one <webview> and cancelling it by releasing mouse
on non-droppable target works where there can be 3 cases:
a. the release is done within the same <webview>
b. the release is done within a different <webview>
c. the release is done outside of any <webview>, i.e. the embedder.
The key fix here is to call guest RVH->DragSourceSystemDragEnded() correctly
on the guest where the drag was initiated. Calling DragSourceSystemDragEnded()
correctly means we call it in all cases and also make sure we only call it once.
This ensures that the input state of the guest stays correct, otherwise it will go
stale and won't accept any further input events.
The strategy I've used to call DragSourceSystemDragEnded() on a guest RVH when
the following conditions are met:
a. Embedder has seen SystemDragEnded()
b. Embedder has seen DragSourceEndedAt()
c. The guest has seen some drag status update other than WebDragStatusUnknown.
Note that c) should ideally be done differently: The guest has seen at least one of
{WebDragStatusOver, WebDragStatusDrop}. However, if a user drags a source
quickly outside of <webview> bounds, then the BrowserPluginGuest never sees
any of these drag status updates.
[email protected]
BUG=450175
Test=
1) On webview based signin page, try dragging some text from the signin page to user name field, it should now work.
2) Load a chrome app with two <webview>s
e.g. https://github.com/lazyboy/chromium/tree/master/tests/chrome-apps/webview_input
Now see there are two <webview>s, one red and one blue, perform following and expect things to work correctly:
a. select and drag text from red webview, e.g. "this is guest", to an tex box within the same webview, expect it to insert that text to the <input> box.
b. now do the same as a), but drag it to the text box within the second/blue <webview>, expect that text to be inserted.
c. select and drag text from red <webview>, drag it but stay within the red <webview> and release it somewhere where there's no text box, expect the drag operation to be cancelled properly, make sure you can still type in the text box of that <webview>.
d. do the same as c) but release it somewhere in the blue <webview> where there's no input box, expect the same, make sure you can type in both <webview>'s input box.
e. do the same as c), but release it somewhere in the app where there's no input box (white background), expect the same and make sure you can type in both <webview>'s input box.
Review URL: https://codereview.chromium.org/885803002
Cr-Commit-Position: refs/heads/master@{#314356}
(cherry picked from commit f569b4f6c09ba2d9b54fb3e459fbd302b10dd013)
Review URL: https://codereview.chromium.org/909363002
Cr-Commit-Position: refs/branch-heads/2272@{#258}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.53
Cr-Commit-Position: refs/branch-heads/2272@{#257}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Android: Get rid of extra dup()s on launching child processes
This is a regression from [1] which added a dup() call on
the renderer launching process. This CL removes these calls
by reveiling the subtle ownership of the file descriptors.
The original intention here was to completely hide and simplify
the notion of the ownership, at the cost of a few dup() calls.
However, the crash report on the reported bug indicates that
the dup() can fail and it lets the renderer initialization fail,
probably due to some per-process limit of the number of opened files.
[1] https://codereview.chromium.org/585203002
NOTRY=true
[email protected], [email protected]
BUG=455364
Review URL: https://codereview.chromium.org/909553003
Cr-Commit-Position: refs/heads/master@{#315353}
(cherry picked from commit f7302eb74f6e79d5b4e26ea5e9aa4e4eb81a52f1)
Review URL: https://codereview.chromium.org/908253002
Cr-Commit-Position: refs/branch-heads/2272@{#256}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
autofill: bumped pickle version of FormFieldData
Binary format was changed with
https://codereview.chromium.org/734983006.
BUG=450162
Review URL: https://codereview.chromium.org/800543009
Cr-Commit-Position: refs/heads/master@{#312388}
(cherry picked from commit 97dc995002ed64b09d7e49e43039ad243ff68bce)
Review URL: https://codereview.chromium.org/912883002
Cr-Commit-Position: refs/branch-heads/2272@{#255}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Reland of: Only store leading 13 bits of password hash.
Reland of: 862103002 at patchset 120001
Reverted here: https://codereview.chromium.org/875983008/
BUG=454553, 433180
[email protected], [email protected], [email protected], [email protected]
[email protected]
Review URL: https://codereview.chromium.org/900583003
Cr-Commit-Position: refs/heads/master@{#314559}
(cherry picked from commit 6fd469ad55039c45056bbe119b8dac8e4f0a8514)
Review URL: https://codereview.chromium.org/913813002
Cr-Commit-Position: refs/branch-heads/2272@{#254}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Android: Fix GPU recovery issues
a)
The swap accounting is a bit unreliable when the GPU process
crashes or the context is lost. We might end up thinking that
too many swap acks are pending (which will never arrive) and
bail out of CompositorImpl::Composite() early.
Ignore the swap limit when deciding to composite if we know
the context was lost. Then calling Composite() will cause the
output surface to get recreated.
b)
Fix infinite retry loops of which there are two:
One is that we could indefinitely early-out of Composite()
and repost if the GPU process keeps crashing at startup before
LTH ever gets a chance to try create a context.
Fix regression with https://codereview.chromium.org/738983002/
which both removed the LOG(FATAL) for too many successive retry
attempts (used to happen inside LTH), and added a similar retry
loop where we might never call SetOutputSurface and keep
relaunching the GPU process.
Also essentially revert https://codereview.chromium.org/750643003/
to simplify things. We don't need to early-out in Composite()
anymore if the GPU channel is lost. This is handled better in
cc now and we can just attempt to Composite(). It will schedule
OutputSurface creation. Even if we call Composite() again in the
meantime, that should be harmless. And after we eventually call
SetOutputSurface(), this will trigger ScheduleComposite().
BUG=453511,453671,453819,453649,448549
NOTRY=True
Review URL: https://codereview.chromium.org/903933005
Cr-Commit-Position: refs/heads/master@{#315390}
(cherry picked from commit bce21923514e1b1d92d5dd743785830fe9c10ad3)
Review URL: https://codereview.chromium.org/913713003
Cr-Commit-Position: refs/branch-heads/2272@{#253}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Mac: Fix for janky tab dragging/reordering (merge to M41)
-[TabView drawRect:] was called repeatedly to unnecessarily update the glow
that is not changing or should not have changed.
1. Selected tabs don't have glow, so don't redraw on mouseMoved.
2. When dragging an unselected tab, the mouse point relative to the tab view
does not change, so no need to redraw the glow.
3. When a dragged unselected tab slides behind another tab, let the dragged tab
keep the glow instead of the tab in front of it (this is a behavior change).
I think this is the more correct behavior, and we never have to redraw tabs
while dragging.
BUG=452925
[email protected]
Review URL: https://codereview.chromium.org/882193003
Cr-Commit-Position: refs/heads/master@{#313734}
(cherry picked from commit 2dad4dfbdd6fbc846f09766a263739ea6f3439ed)
Review URL: https://codereview.chromium.org/915713002
Cr-Commit-Position: refs/branch-heads/2272@{#252}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Ozone-Dri] Set DPMS to off when disabling a display
Need to turn it off to reduce the power used by the display when idling.
BUG=chrome-os-partner:35458
TEST=Wait for the displays to turn off and check with 'modetest -c' that the DPMS state is off
Review URL: https://codereview.chromium.org/877213005
Cr-Commit-Position: refs/heads/master@{#315111}
(cherry picked from commit 46c8606644c297cd5e7271805192d9df5dd698ce)
Review URL: https://codereview.chromium.org/911133002
Cr-Commit-Position: refs/branch-heads/2272@{#251}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Prevent single-app kiosk mode auto-launch if device is disabled
If a device is disabled, it should show the disabled screen and not
start any sessions. Regular sessions, auto-launch for public sessions
and auto-launch for consumer kiosk mode respected this. Auto-launch
for enterprise kiosk mode takes a different code path that had
slipped through the cracks. The effect was that single-app kiosk mode
would auto-launch even if a device was disabled.
BUG=454005
TEST=New browser test
TBR=antrim
Review URL: https://codereview.chromium.org/882043006
Cr-Commit-Position: refs/heads/master@{#314330}
(cherry picked from commit 0ec3b217448a4c76a77c43e558687df18a61c20e)
Review URL: https://codereview.chromium.org/908963003
Cr-Commit-Position: refs/branch-heads/2272@{#250}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: Fix a crash during aborting of operations on provided file systems.
In case of an abort, a memory corruption was occuring because of a call to
Queue::Complete() after an operation is aborted, which is invalid according to
both documentation and a DCHECK.
This CL fixes the issue by avoiding calling Queue::Complete() for aborted
tasks.
[email protected]
TEST=Tested manually. Try to copy files from a ZIP archive with thousands of
files, and abort during the operation.
BUG=454310
Review URL: https://codereview.chromium.org/882153006
Cr-Commit-Position: refs/heads/master@{#314722}
(cherry picked from commit 33176770fd2364913cb17f251315192b8bf593da)
Review URL: https://codereview.chromium.org/915523002
Cr-Commit-Position: refs/branch-heads/2272@{#249}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Remove use of TextView.getMaxLines to restore ICS compatibility
ElidedTextView uses setMaxLines and getMaxLines to manage expanding and
collapsing the URL bar. getMaxLines was only introduced in API version
16; this CL removes its use and overrides setMaxLines to achieve the
same effect.
BUG=455144
Review URL: https://codereview.chromium.org/899453005
Cr-Commit-Position: refs/heads/master@{#315448}
(cherry picked from commit ebfd2b53b71a6fa9b52b9c1856d89a97a9c0597e)
Committed on behalf of [email protected].
[email protected], [email protected]
Review URL: https://codereview.chromium.org/910093005
Cr-Commit-Position: refs/branch-heads/2272@{#248}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Use floor instead of ceil for the size of the layer for wallpapers.
Otherwise, pixels on the edge of wallpaper may be blended with the pixel outside of the boundary.
BUG=368591
[email protected]
Review URL: https://codereview.chromium.org/871773004
Cr-Commit-Position: refs/heads/master@{#313003}
(cherry picked from commit 8fab1bba6ba22e5a917d8afcc835ec385f59cb2e)
Review URL: https://codereview.chromium.org/911663004
Cr-Commit-Position: refs/branch-heads/2272@{#247}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.52
Cr-Commit-Position: refs/branch-heads/2272@{#246}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Disable D3D11 on systems with AMD switchable graphics.
They may have problems when using hardware video decoding and D3D11 on the discrete gpu.
BUG=451420
[email protected]
Review URL: https://codereview.chromium.org/875403009
Cr-Commit-Position: refs/heads/master@{#315165}
(cherry picked from commit ae441cb44c78cc91ba0169e6b1fa30ebaf968c1f)
Review URL: https://codereview.chromium.org/871013011
Cr-Commit-Position: refs/branch-heads/2272@{#245}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Enumerate all display adapters to detect AMD switchable graphics.
Keying off of the driver manufacturer name doesn't work on some systems, so use SetupAPI to enumerate all installed display adapters to check if both an AMD and Intel display adapter are installed.
BUG=455046,451420
NOPRESUBMIT=true
[email protected]
Review URL: https://codereview.chromium.org/893993006
Cr-Commit-Position: refs/heads/master@{#314923}
(cherry picked from commit dd5bf63e4a1d177137a9c6c641bbc6c4782ef202)
Review URL: https://codereview.chromium.org/895133004
Cr-Commit-Position: refs/branch-heads/2272@{#244}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Android: Fix potential null-ptr deref
BrowserGpuChannelHostFactory::GetGpuChannel() can
return NULL. In particular it already checks
IsLost() and returns NULL if that is the case.
BUG=445945
Review URL: https://codereview.chromium.org/867093004
Cr-Commit-Position: refs/heads/master@{#314683}
(cherry picked from commit 62e2fc7f7dd1d2f29c6299efa1535c8894d4cb4c)
Review URL: https://codereview.chromium.org/872253009
Cr-Commit-Position: refs/branch-heads/2272@{#243}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix DNS Prefetch in Chrome: new message type not added to filter.
[email protected]
BUG=455342
NOTRY=true
Review URL: https://codereview.chromium.org/874163005
Cr-Commit-Position: refs/heads/master@{#314972}
(cherry picked from commit 913b668663b854e3d88dcf42f5e055a94d824fb1)
Review URL: https://codereview.chromium.org/901673003
Cr-Commit-Position: refs/branch-heads/2272@{#242}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.51
Cr-Commit-Position: refs/branch-heads/2272@{#241}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
IndexedDB: Re-enable leveldb manifest reuse.
The new leveldb manifest reuse feature was disabled because the CrOS dev channel
daily error % by channel values increased after this landed in that channel (by
about 3x). Reverting this change did not return the dev channel rates back to
normal. Furthermore the beta channel (with this feature enabled) did not
experience an increase in errors.
Commit details: Returns manifest reuse back to the state introduced in
crrev.com/803603004 (de701ab) which was disabled in two subsequent reverts:
crrev.com/841753003 (ca6c875) and crrev.com/852073002 (617e94e).
BUG=402980
Review URL: https://codereview.chromium.org/899933002
(cherry picked from commit 6bd2fc1919a84eff0141634ccc49483669ab7e37)
Cr-Original-Commit-Position: refs/heads/master@{#314638}
Cr-Commit-Position: refs/branch-heads/2272@{#240}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
GetEffectiveDomain should handle ws scheme as same as http scheme.
CookieMonster::AnyEquivalentCookie asserts that there are no multiple
cookies that are identical to each other. That is achieved by inserting / deleting
cookies carefully, but it goes wrong with WebSocket schemes.
CookieMonster::DoCookieTaskForURL for given URL loads cookies when
cookies for key = cookie_util::GeteEffectiveDomain(scheme, host) is not
yet loaded. When the task ends, it stores loaded cookies and marks the key as
loaded. cookie_util::GetEffectiveDomain consults
egistry_controlled_domains::GetDomainAndRegistry
when http or https schemes are given, whereas it doesn't when ws or wss
schemes are given.
Imagine we are about to load stored cookies for ws://www.example.com/
and http://www.example.com/. As written above, they have different keys:
www.example.com and example.com. So each of them is loaded and it breaks
the assertion.
BUG=370021
[email protected], [email protected]
Review URL: https://codereview.chromium.org/859663003
Cr-Commit-Position: refs/heads/master@{#313706}
(cherry picked from commit 5ca0f699ed11b59167acb32f3fa7c7480630bdcc)
Review URL: https://codereview.chromium.org/911553002
Cr-Commit-Position: refs/branch-heads/2272@{#239}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.50
Cr-Commit-Position: refs/branch-heads/2272@{#238}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.49
Cr-Commit-Position: refs/branch-heads/2272@{#237}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Only increment the history list offset if we are not replacing the current item.
BUG=453708
TEST=as in bug
[email protected]
Review URL: https://codereview.chromium.org/902083002
Cr-Commit-Position: refs/heads/master@{#315060}
(cherry picked from commit 26b1681180785dfcedc55cf0574e43f21de8fb10)
(This cherry-pick omits the test as it does not merge cleanly.)
Review URL: https://codereview.chromium.org/895583008
Cr-Commit-Position: refs/branch-heads/2272@{#236}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.48
Cr-Commit-Position: refs/branch-heads/2272@{#235}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Remove stray newline in tracing.zip filename
The uploaded trace is currently inaccessible because of the stray
newline.
BUG=455782
TEST=upload a feedback report with trace & download tracing.zip
Review URL: https://codereview.chromium.org/869853004
Cr-Commit-Position: refs/heads/master@{#314858}
(cherry picked from commit 14a9aedeebbbc06a23af0087796fb48b4103b3f6)
Review URL: https://codereview.chromium.org/909593002
Cr-Commit-Position: refs/branch-heads/2272@{#234}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Don't create a pairing registry on platforms that don't provide a delegate.
This was broken by https://codereview.chromium.org/834673007. Constructing
a PairingRegistry with a null delegate causes pairing to be offered, but if
selected, the host process will crash.
BUG=455501
[email protected]
Review URL: https://codereview.chromium.org/903963002
Cr-Commit-Position: refs/heads/master@{#314969}
(cherry picked from commit dbec99efb805e22b77b5c2d18a2f21e405fbc5cf)
Review URL: https://codereview.chromium.org/889493004
Cr-Commit-Position: refs/branch-heads/2272@{#233}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Android] Upstreamed Stars UMA from iOS.
There are some UMA strings, enum constants in iOS repository
that can be shared with Android, so moved to components.
BUG=452254
Review URL: https://codereview.chromium.org/891493003
Cr-Commit-Position: refs/heads/master@{#314707}
(cherry picked from commit f0a2c44b48f239ea4e6c4d0571be846a5fc524fa)
[email protected], [email protected]
Review URL: https://codereview.chromium.org/899353003
Cr-Commit-Position: refs/branch-heads/2272@{#232}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.47
Cr-Commit-Position: refs/branch-heads/2272@{#231}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix compile failure in M41 Beta build due to https://codereview.chromium.org/899323002/
BUG=None
TEST=None
TBR=pkotwicz
Review URL: https://codereview.chromium.org/904773002
Cr-Commit-Position: refs/branch-heads/2272@{#230}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Ozone-DRI] Re-enable GBM surface mode support
GBM surface mode requires synchronous page flips at the moment. We need
to set DriWrapper to synchronously page flip.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/847213002
Cr-Commit-Position: refs/heads/master@{#311337}
gpu: media: RenderingHelper: wait for the display & window to be ready
With the display configuration now asynchronous, we can't immediately read the display size. We need to wait until the hardware is probed.
Also the VSyncProvider cannot trigger the given callback until the PlatformWindow is properly setup with the display. We need to wait for it the actually be resized.
BUG=447798
TEST=run video_decode_accelerator_unittest on freon
Review URL: https://codereview.chromium.org/835653005
Cr-Commit-Position: refs/heads/master@{#313473}
gpu: media: unittests: explicitly create a main loop
On Ozone/Freon initializing GL requires a main loop.
BUG=447798
TEST=run video_encode_accelerator_unittest on freon
Review URL: https://codereview.chromium.org/844533003
Cr-Commit-Position: refs/heads/master@{#312341}
Review URL: https://codereview.chromium.org/905613002
Cr-Commit-Position: refs/branch-heads/2272@{#229}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Avoid crashing if multiple target popup is empty.
If the bitmap wasn't allocated, return false instead.
BUG=411505
Review URL: https://codereview.chromium.org/879143002
Cr-Commit-Position: refs/heads/master@{#314009}
(cherry picked from commit 0ed0918111d020972e00feda36ae0b68075d6d0f)
[email protected]
Review URL: https://codereview.chromium.org/869023009
Cr-Commit-Position: refs/branch-heads/2272@{#228}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Don't report DRP request error code UMA when LOAD_BYPASS_PROXY is set.
This fixes a reporting bug with the
DataReductionProxy.RequestCompletionErrorCodes histograms. Previously,
these histograms counted requests that encountered errors when retrying
the request after bypassing the data reduction proxy (e.g. block-once).
This is incorrect because the error did not occur when trying to use the
DRP.
The fix is to ignore requests that completed with the LOAD_BYPASS_PROXY
load flag, since these requests did not use the DRP even if the
proxy_server() in the URLRequest is still set to the DRP.
BUG=454947
Review URL: https://codereview.chromium.org/896793004
Cr-Commit-Position: refs/heads/master@{#314432}
(cherry picked from commit fb93bf47152d82d4403f73fc74b4f560255d16ab)
Review URL: https://codereview.chromium.org/901143004
Cr-Commit-Position: refs/branch-heads/2272@{#227}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge 41] Make PointerDeviceObserver work under Ozone
This CL:
- Makes PointerDeviceObserver get notified when a mouse or touchpad is
plugged in or removed by making PointerDeviceObserver an
InputDeviceEventObserver on ozone only.
- Adds InputDeviceEventObserver::OnMouseDeviceConfigurationChanged() and
InputDeviceEventObserver::OnTouchpadDeviceConfigurationChanged().
- Adds the plumbing from EventFactoryEvdev to notify
InputDeviceEventObservers when a mouse or touchpad is plugged in or
removed.
In a later CL I will make PointerDeviceObserver an InputDeviceEventObserver on
X11 and add the X11 plumbing
BUG=450899
TEST=Manual, see bug
[email protected]
TBR=pkotwicz
Review URL: https://codereview.chromium.org/889403003
Cr-Commit-Position: refs/heads/master@{#314400}
(cherry picked from commit b726eb10541ccd17e678202bc7e502feb0854742)
Review URL: https://codereview.chromium.org/899323002
Cr-Commit-Position: refs/branch-heads/2272@{#226}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge M41: Process WM_ENDSESSION in the traybar icon window.
BUG=441960
Review URL: https://codereview.chromium.org/888693003
Cr-Commit-Position: refs/heads/master@{#313934}
Review URL: https://codereview.chromium.org/905563002
Cr-Commit-Position: refs/branch-heads/2272@{#225}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Don't reconfigure displays when they are suspended
When a Chrome OS device enters suspend, Chrome suspends the displays and
then probes and reconfigures them on resume. However, an increasing
number of Chrome OS devices make use of the dark resume state to perform
some processing without alerting the user that the Chrome OS device has
woken up. Attempting to configure the displays in this state causes the
screen to flash on and off, which can alert the user that their Chrome
OS device is doing something and is generally a bad user experience.
Instead, don't configure the displays in dark resume. They are going to
be probed and reconfigured after a full resume anyway so there should be
no harm in skipping the reconfiguration during a dark resume.
BUG=chrome-os-partner:35253
Review URL: https://codereview.chromium.org/871653002
Cr-Commit-Position: refs/heads/master@{#314494}
(cherry picked from commit 091b5725609144d990930736f6c009ba1a52ae9c)
[email protected], [email protected]
[email protected], [email protected]
Review URL: https://codereview.chromium.org/901723002
Cr-Commit-Position: refs/branch-heads/2272@{#224}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
cc: Fix multiple outstanding output surface requests
SingleThreadProxy was previously not considering
DidFailToInitializeOutputSurface responses as an outstanding
RequestNewOutputSurface call. This would cause the embedder to start
servicing an output surface request, then composite, receive another,
and then have double output surface requests.
The fix is to consider this failure state as a request.
[email protected],[email protected],[email protected]
BUG=444277
Review URL: https://codereview.chromium.org/871743002
Cr-Commit-Position: refs/heads/master@{#313357}
(cherry picked from commit 5232fbbf8df7e06471950a12bc041c766e31a997)
Review URL: https://codereview.chromium.org/896423003
Cr-Commit-Position: refs/branch-heads/2272@{#223}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge M41: [Ozone] Constrain the cursor when overscan insets are set
Constrain the mouse cursor to the painted region of the screen when overscan
insets are set.
BUG=427619
TEST=Manual, see bug
[email protected]
TBR=pkotwicz
Review URL: https://codereview.chromium.org/873563002
Cr-Commit-Position: refs/heads/master@{#313336}
(cherry picked from commit f52514eaab866573a7022cea2da3b93f1c18924d)
Review URL: https://codereview.chromium.org/868983004
Cr-Commit-Position: refs/branch-heads/2272@{#222}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
win: Disable use of FMA3 versions of CRT functions on x64 in libpeerconnection.dll
This is a repetition of what was done to fix the same issue
for chrome.dll here: https://codereview.chromium.org/771183004/
Using the FMA3 path in the CRT math functions is suspected of causing
crashes when disabled at the OS level.
BUG=436603,446983
TBR=tommi,brucedawson
Review URL: https://codereview.chromium.org/813133007
Cr-Commit-Position: refs/heads/master@{#310986}
(cherry picked from commit bbc857dee3d9a87d5d5cc47c6f4fd5e908fffd5b)
Review URL: https://codereview.chromium.org/901893005
Cr-Commit-Position: refs/branch-heads/2272@{#221}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add NULL check before using remote_service in SyncFileSystemService
SyncFileSystemService::remote_service_ may be NULL in shutdown phase,
after SyncFileSystemService::Shutdown is called.
BUG=454279
Review URL: https://codereview.chromium.org/886343003
Cr-Commit-Position: refs/heads/master@{#314484}
(cherry picked from commit 8c2944d39fd07c0fdeea1545ab388073d514370f)
[email protected]
Review URL: https://codereview.chromium.org/901153003
Cr-Commit-Position: refs/branch-heads/2272@{#220}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Make DataFileRendererCldDataProvider's LoadCldData method public.
There's no reason that it needs to be private, and if another class wants to
compose this with additional functionality, it makes sense for it to be public.
BUG=367239
[email protected]
Review URL: https://codereview.chromium.org/845263002
Cr-Commit-Position: refs/heads/master@{#311039}
(cherry picked from commit 3198df3341ca97b92da988f72725cca8ea8b8114)
Review URL: https://codereview.chromium.org/905433002
Cr-Commit-Position: refs/branch-heads/2272@{#219}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fixing crash upon window manager creation
BUG=452608
TEST=existing unit tests
[email protected]
Review URL: https://codereview.chromium.org/890293002
Cr-Commit-Position: refs/heads/master@{#314276}
(cherry picked from commit 388e681bb3df5e658559615fc417473402c32242)
Review URL: https://codereview.chromium.org/897213002
Cr-Commit-Position: refs/branch-heads/2272@{#218}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Hide the taskbar microphone indicator for hotwording.
BUG=453829
Review URL: https://codereview.chromium.org/884773003
Cr-Commit-Position: refs/heads/master@{#314129}
(cherry picked from commit 4ccd7477a19e224aea27cefe35ddaee28b9fab2a)
[email protected],[email protected]
Review URL: https://codereview.chromium.org/896183005
Cr-Commit-Position: refs/branch-heads/2272@{#217}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.46
Cr-Commit-Position: refs/branch-heads/2272@{#216}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] Don't allow profile deletion in Metro mode.
Bad things happen if you delete the profile that started the Metro
process (at best, you crash), since relaunching Metro with a new user
is not supported. Hiding the button selectively depending on the
profile selected is a bit weird, so in Metro mode, hide it for all
profiles.
BUG=448352
[email protected]
Review URL: https://codereview.chromium.org/863063002
Cr-Commit-Position: refs/heads/master@{#313449}
(cherry picked from commit 9a4fcc927bf745d6aab08440e22344b393246492)
Conflicts:
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
Review URL: https://codereview.chromium.org/887203003
Cr-Commit-Position: refs/branch-heads/2272@{#215}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] [Mac] Allow "Enter" to activate the buttons in the new avatar bubble.
Despite this not being the OSX way, users are complaining that Enter doesn't
activate the buttons in the menu, because it used to. I think the easiest
way is to wrap all buttons in a view that responds to Enter, and activates
the button accordingly.
BUG=454467
[email protected]
TEST=Start Chrome with --enable-new-avatar-menu. Open the avatar bubble and
tab through items. Pressing enter should perform the button's action.
Review URL: https://codereview.chromium.org/890143005
Cr-Commit-Position: refs/heads/master@{#314265}
(cherry picked from commit 7286b9d038d6d9f95578ced6de7ebaa788970d1d)
Review URL: https://codereview.chromium.org/903493003
Cr-Commit-Position: refs/branch-heads/2272@{#214}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
