Publish DEPS for Chromium 41.0.2272.45
Incrementing VERSION to 41.0.2272.45
Cr-Commit-Position: refs/branch-heads/2272@{#213}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.44
Cr-Commit-Position: refs/branch-heads/2272@{#212}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge for Android only:
Make GL bindings conditional
>> Review URL: https://codereview.chromium.org/871763002
>> Cr-Commit-Position: refs/heads/master@{#313663}
and
>> Fix incorrect binding spec for multisampled_render_to_texture APIs
>> Review URL: https://codereview.chromium.org/887113003
>> Cr-Commit-Position: refs/heads/master@{#314422}
This checks in a different version for GL and EGL binding
code, just for Android (generated from
ui/gl/generate_bindings_android.py).
For other platforms nothing changes and binding code is generated
in the output directory still.
BUG=438742
[email protected]
Review URL: https://codereview.chromium.org/898763005
Cr-Commit-Position: refs/branch-heads/2272@{#211}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Initialize Android CrashDumpManager earlier
The CrashDumpManagerAndroid instance must be initialized before any
child process is created. This change moves the initialization to
PreThreadsCreate, which at the very least should be before the
PROCESS_LAUNCHER thread (where the potentially evil child processes will
be created). #nocrashes
BUG=439322
Review URL: https://codereview.chromium.org/889083002
Cr-Commit-Position: refs/heads/master@{#314083}
(cherry picked from commit 0a0e4fddc32adad7c90f10dce2eb7c57ef652e89)
Review URL: https://codereview.chromium.org/895163004
Cr-Commit-Position: refs/branch-heads/2272@{#210}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.43
Cr-Commit-Position: refs/branch-heads/2272@{#209}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "Load web contents after tab is created."
This reverts commit ce034956d41aa45f3cab36cc908f79f8b5af481f.
BUG=432562
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/892203008
Cr-Commit-Position: refs/branch-heads/2272@{#208}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Snow has a slow TPM and appears to be slow in general.
Some tests are failing on Snow because cryptohome doesn't unmount in time.
Attempting to increase this timeout to alleviate the issue.
We can revert this patch if it doesn't help.
BUG=449746
TEST=various telemetry-based autotests on Snow
NOTRY=True
Review URL: https://codereview.chromium.org/871923007
Cr-Commit-Position: refs/heads/master@{#313173}
(cherry picked from commit 26be503cdf869b92e7deb2166b8f48dcc51a84d4)
Review URL: https://codereview.chromium.org/896843002
Cr-Commit-Position: refs/branch-heads/2272@{#207}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fixing token repetition bug (M41 merge)
BUG=451598
Re-uploading this CL under my @chromium identity:
https://codereview.chromium.org/888203002
[email protected],[email protected]
Review URL: https://codereview.chromium.org/875843003
Cr-Commit-Position: refs/heads/master@{#314059}
(cherry picked from commit e161db2544453dce6bb0a0859ab8cdf05c405a64)
Review URL: https://codereview.chromium.org/883443004
Cr-Commit-Position: refs/branch-heads/2272@{#206}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Skip direct map from apk check for all Samsung.
If the device manufacturer is Samsung, skip the check for mmap
exec support. This avoids triggering a warning on some devices.
See also:
https://codereview.chromium.org/869593002/
https://codereview.chromium.org/858983002/
https://codereview.chromium.org/857833002/
BUG=448084
Review URL: https://codereview.chromium.org/900553005
(cherry picked from commit b1969b94183f4f4b1e2e6ccbf8221061d2d3e687)
Cr-Original-Commit-Position: refs/heads/master@{#314362}
Cr-Commit-Position: refs/branch-heads/2272@{#205}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Skip direct map from apk check for pre-KitKat Samsung.
If the android build version pre-dates KitKat and the device
manufacturer is Samsung, skip the check for mmap exec support.
This avoids triggering a warning on these devices.
The version check is included because these devices do not show
the warning on later OS builds.
BUG=448084
[email protected]
Review URL: https://codereview.chromium.org/869593002
(cherry picked from commit 78efcc0f7e59612ec717d26ffce92fa643347210)
Cr-Original-Commit-Position: refs/heads/master@{#314156}
Cr-Commit-Position: refs/branch-heads/2272@{#204}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix crash on BLU Life Play devices related to switch preferences.
ChromeSwitchPreference uses setWidgetLayoutResource() to show a Material
switch, but on BLU Life Play devices, this has no effect and the default
switch is shown instead. As a result ChromeSwitchPreference.onBindView()
couldn't find the Material switch and was crashing with a NPE. This
fixes the crash by adding a null check, though these devices will still
show a non-material switch.
BUG=451447
[email protected]
Review URL: https://codereview.chromium.org/894873004
Cr-Commit-Position: refs/heads/master@{#314250}
(cherry picked from commit 796a0bc0a3064f17357460187a02d7b216853e0d)
Review URL: https://codereview.chromium.org/891343012
Cr-Commit-Position: refs/branch-heads/2272@{#203}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M41: When an extension is unloaded, unregister all event listeners, not just the lazy ones.
This fixes a problem where event listeners could stick around for a
short time period after an extension is unloaded, causing problems
with the onInstalled event for a new version of an extension.
BUG=449654
Review URL: https://codereview.chromium.org/877233002
Cr-Commit-Position: refs/heads/master@{#313556}
(cherry picked from commit 1a3586c0467a2e2f3777c060616e787bc9535c19)
[email protected]
Review URL: https://codereview.chromium.org/898743002
Cr-Commit-Position: refs/branch-heads/2272@{#202}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Disable network state reporting.
Update the DeviceStatusCollector to no longer report network state. We will
re-enable this for M42 once we've added code to detect an auto-launched kiosk
session.
BUG=452968
TBR=bartfab
Review URL: https://codereview.chromium.org/885853002
Cr-Commit-Position: refs/heads/master@{#313717}
(cherry picked from commit 00fc37605e1020b8822835d5d1d9025aab76c7f9)
Review URL: https://codereview.chromium.org/893173002
Cr-Commit-Position: refs/branch-heads/2272@{#201}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M41: Add missing NULL checks to NativeViewAccessibilityWin.
IAccessible objects are reference-counted, so the COM object
may persist if the view is deleted. We should always check the
view (which will be nulled when the view is deleted).
BUG=436074
Review URL: https://codereview.chromium.org/872683005
Cr-Commit-Position: refs/heads/master@{#313792}
(cherry picked from commit 6b6714d20c8311b0b0badff0cd783eb6a4bff4bc)
Review URL: https://codereview.chromium.org/896583005
Cr-Commit-Position: refs/branch-heads/2272@{#200}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Speculative fix for RWHVBrowerTests on Mac.
It seems that the cause of the flakes (see bug) is caused by transient
readback failures, which is a normal condition that client code must
tolerate. The purpose of these tests is actually to confirm correct
cropping/scaling behavior; and NOT that every readback must succeed.
Therefore, the tests have been altered to retry the CopyFromXXX()
operations until a successful readback occurs.
Added logging of readback failure reasons to aid in future debugging.
This information will also help to easily determine whether the
implementation is broken, or a test bot is in a bad state, should the
tests fail in the future.
Clean-up: Removed the IsUpperLeftPixelCyan() check, in favor of just
looking at the readback result for a "blank" SkBitmap.
BUG=444237
Review URL: https://codereview.chromium.org/867463002
Cr-Commit-Position: refs/heads/master@{#312684}
(cherry picked from commit bddc0efbcd0379d6b87ac70af1c9a803073d2bff)
Review URL: https://codereview.chromium.org/894303002
Cr-Commit-Position: refs/branch-heads/2272@{#199}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: Allow SW registration only if it's secure AND it's HTTP or HTTPS
BUG=453982
TEST=tested manually
TEST=content_unittests:ServiceWorkerDispatcherHostTest.Register_FileSystem*
Review URL: https://codereview.chromium.org/889323002
Cr-Commit-Position: refs/heads/master@{#314143}
(cherry picked from commit 22394d843a6c36eb2e6d7bdf4fb8e7c4b7ae8d68)
Merge: Service Worker: Improve some exception messages (Chromium).
- Prefix the error messages to indicate the operation
that failed (particularly helps when the error occurs
in a promise chain)
- Add more details to the error messages.
Example improvements:
Before: "URL too long"
After: "Failed to register a ServiceWorker: The
provided scriptURL or scope is too long."
Before: "The scope must be under the directory of the
script URL."
After: "Failed to register a ServiceWorker:
The path of the provided scope ('http://localhost:9898/mysecretpath')
is not under the directory of the provided scriptURL
('http://localhost:9898/resources/empty-worker.js')."
ONLY FILES
content/common/service_worker/service_worker_types.cc
content/common/service_worker/service_worker_types.h
BUG=436928
Review URL: https://codereview.chromium.org/813673005
Cr-Commit-Position: refs/heads/master@{#311428}
(cherry picked from commit 737a4ba8e6a63814c49f6bb5597e238275a3a810)
Review URL: https://codereview.chromium.org/898673002
Cr-Commit-Position: refs/branch-heads/2272@{#198}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
64-bit token fixes (M41 merge)
BUG=453523
[email protected],[email protected]
Review URL: https://codereview.chromium.org/870053008
Cr-Commit-Position: refs/heads/master@{#314023}
(cherry picked from commit 7cf6cbe2f59986f6d87b775d2856cfd799b158fb)
Review URL: https://codereview.chromium.org/892353002
Cr-Commit-Position: refs/branch-heads/2272@{#197}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Cherry-pick part of https://codereview.chromium.org/831523005.
This part is needed for the cherry-pick of
https://code.google.com/p/chromium/issues/detail?id=432562 to work.
BUG=432562
[email protected]
Review URL: https://codereview.chromium.org/895833002
Cr-Commit-Position: refs/branch-heads/2272@{#196}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.42
Cr-Commit-Position: refs/branch-heads/2272@{#195}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Load web contents after tab is created.
In document mode, we used to start loading the web contents of a newly
opened tab before the chrome tab object is ready. This would result in
chrome intercept delegate not being initialized in time to figure out
whether the loaded URL needs to be sent as an intent instead.
This changes the order of operations to create the chrome tab first with
the given web contents and only then initiate the load.
BUG=432562
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/883153002
Cr-Commit-Position: refs/heads/master@{#313966}
(cherry picked from commit 4c55f398def3214369aefa9f2f2e8f5940d3799d)
Review URL: https://codereview.chromium.org/896633003
Cr-Commit-Position: refs/branch-heads/2272@{#194}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Android: Put GPU process in foreground
That makes browser, foreground renderer, and GPU
have a similar priority. Otherwise the GPU process
might drop behind other (even unrelated bg) processes
and get killed too easily.
BUG=448549,453671
[email protected]
Review URL: https://codereview.chromium.org/889013002
Cr-Commit-Position: refs/heads/master@{#314173}
(cherry picked from commit e77a53958cc41a1df157929f492a52c564d37b1e)
Review URL: https://codereview.chromium.org/887563005
Cr-Commit-Position: refs/branch-heads/2272@{#193}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Re-merging into M41 branch 2272: Omnibox: BookmarksProvider: Make Multiple Prefix Matches Work
This code significantly simplies the logic for matching.
Indeed, the old logic was buggy because multiple prefix matches could
results in explosive growth of the list of matches (even if only one
bookmark matches). Reviewer, I would avoid reading and trying to
understand what CombineMatches() and the code that calls it is currently
broken. See the second test case I added. Before this
change, that test never terminates (in the time I waited) and explodes
the machine's memory. Luckily this was rare; there are few reports on
crbug.
It's possible this new code is slower or faster than before (when the
old code behaved correctly). I plan to look at the
Omnibox.Providertime.Bookmarks numbers before and after this change.
TBR=
sky for owners stamp; review it if you feel like
BUG=450850,434604
Review URL: https://codereview.chromium.org/882823004
Cr-Commit-Position: refs/heads/master@{#313574}
(cherry picked from commit 02f304ba896632433d2e91b57c381cca90d4c7b9)
Review URL: https://codereview.chromium.org/878413004
Cr-Commit-Position: refs/branch-heads/2272@{#192}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "Merge to M41 branch 2272: Allow SW registration only if it's secure AND it's HTTP or HTTPS"
This reverts commit 909dea0c7ac38f76acb43f9ea9172ddd747f70f5.
Revert "Omnibox: BookmarksProvider: Make Multiple Prefix Matches Work"
This reverts commit b6fb51542e0b5ef297a660f383e9c16ece379899.
BUG=
Review URL: https://codereview.chromium.org/898593003
Cr-Commit-Position: refs/branch-heads/2272@{#191}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "Omnibox: BookmarksProvider: Make Multiple Prefix Matches Work"
This reverts commit b6fb51542e0b5ef297a660f383e9c16ece379899.
BUG=
Review URL: https://codereview.chromium.org/895553003
Cr-Commit-Position: refs/branch-heads/2272@{#190}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
ozone: evdev: Set modifier flags on touch events
This fixes a regression vs X11 where all touch events are missing
modifier flags.
BUG=450650
TEST=Open http://www.rbyers.net/eventTest.html on link, hold shift, and
tap the touchscreen. Page shows "shift" on the click event line.
Review URL: https://codereview.chromium.org/887743002
Cr-Commit-Position: refs/heads/master@{#313788}
(cherry picked from commit ec64091f736c8ba04a65b518c802ffd0d7b35386)
Review URL: https://codereview.chromium.org/892313002
Cr-Commit-Position: refs/branch-heads/2272@{#189}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Android] Change enhanced bookmark folder structure.
- Top level folders are now all the sub folders of
Bookmark Bar, Mobile, and Others nodes.
- We no longer use Uncategorized.
BUG=453024
Review URL: https://codereview.chromium.org/869193008
Cr-Commit-Position: refs/heads/master@{#314013}
(cherry picked from commit a01c664cd6802d64d212f68d1c9392a4340ca835)
[email protected]
Review URL: https://codereview.chromium.org/894853002
Cr-Commit-Position: refs/branch-heads/2272@{#188}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Omnibox: BookmarksProvider: Make Multiple Prefix Matches Work
This code significantly simplies the logic for matching.
Indeed, the old logic was buggy because multiple prefix matches could
results in explosive growth of the list of matches (even if only one
bookmark matches). Reviewer, I would avoid reading and trying to
understand what CombineMatches() and the code that calls it is currently
broken. See the second test case I added. Before this
change, that test never terminates (in the time I waited) and explodes
the machine's memory. Luckily this was rare; there are few reports on
crbug.
It's possible this new code is slower or faster than before (when the
old code behaved correctly). I plan to look at the
Omnibox.Providertime.Bookmarks numbers before and after this change.
TBR=sky,pkasting
(for owners stamp; review it if you feel like)
BUG=450850,434604
Review URL: https://codereview.chromium.org/882823004
Cr-Commit-Position: refs/heads/master@{#313574}
(cherry picked from commit 02f304ba896632433d2e91b57c381cca90d4c7b9)
Review URL: https://codereview.chromium.org/881653006
Cr-Commit-Position: refs/branch-heads/2272@{#187}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M41 branch 2272: Allow SW registration only if it's secure AND it's HTTP or HTTPS
BUG=453982
TEST=tested manually
TEST=content_unittests:ServiceWorkerDispatcherHostTest.Register_FileSystem*
Review URL: https://codereview.chromium.org/889323002
Cr-Commit-Position: refs/heads/master@{#314143}
(cherry picked from commit 22394d843a6c36eb2e6d7bdf4fb8e7c4b7ae8d68)
Review URL: https://codereview.chromium.org/896563002
Cr-Commit-Position: refs/branch-heads/2272@{#186}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Invalid press events don't create multiple pointers with the same id.
Previously if we got an invalid event stream such as
Press id 0
Press id 0
MotionEventAura would happily add the second pointer. Now we replace
the first pointer with the second pointer.
This work around is required due to crbug.com/373125.
BUG=450880
Review URL: https://codereview.chromium.org/873283003
Cr-Commit-Position: refs/heads/master@{#313116}
(cherry picked from commit b88d572b627a99714051bf057afdb2ead4f58489)
Review URL: https://codereview.chromium.org/867823005
Cr-Commit-Position: refs/branch-heads/2272@{#185}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Correctly track texture cleared state for sharing
When sharing textures in mailboxes using MailboxManagerSync
there's an optimization that if textures are not updated then
there is no need to share it again. However the code that
checks whether textures are updated ignores the cleared
state, causing shared texture to remain uncleared
indefinitely.
Fix by check the cleared state. And add a unit test.
BUG=453199
Review URL: https://codereview.chromium.org/890453002
Cr-Commit-Position: refs/heads/master@{#313814}
(cherry picked from commit 2f4ff4807f5d7805a5658ceb7ba71072152ea6c9)
[email protected]
Review URL: https://codereview.chromium.org/896543002
Cr-Commit-Position: refs/branch-heads/2272@{#184}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix uninitialized timestamps being passed to the gesture lib
The CL corrects a bug where clock_gettime was placed in
a DCHECK call and thus not executed on release builds.
Contributed by [email protected]
BUG=chrome-os-partner:35111
TEST=samus ChromeOS build
Review URL: https://codereview.chromium.org/884313002
Cr-Commit-Position: refs/heads/master@{#313634}
(cherry picked from commit c2467847c97406bc1566a6b65ba40b6284b305e9)
Review URL: https://codereview.chromium.org/895673003
Cr-Commit-Position: refs/branch-heads/2272@{#183}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge of r313189 to M41.
Removes "ui-sans" from the ChromeOS system UI default font list.
The ChromeOS system UI (rendered through HarfBuzz) now
relies on gfx::RenderText::CreateSkiaTypeface(), and
skia actually returns exactly same typeface for
'Noto Sans UI' and 'ui-sans' in the current configuration.
ui-sans is simply redundant.
BUG=444894
[email protected]
Review URL: https://codereview.chromium.org/823003002
Cr-Commit-Position: refs/heads/master@{#313189}
(cherry picked from commit 550404a8be2b84c686ac855204c737233292fd41)
Review URL: https://codereview.chromium.org/890913004
Cr-Commit-Position: refs/branch-heads/2272@{#182}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "[Mac] Fixed bug with notification getting stucked on screen."
> The CL causes crashes.
>
> > This fixes a bug with notifications getting stucked on screen while
> > hovering with mouse old notifications popups and new arrived popups.
> > Source of the problem is popup animation getting stopped, rather when
> > finished.
> >
> > BUG=418053
> > [email protected], [email protected]
> >
> > TEST=see http://crbug.com/418053 for reproduction details.
> >
> > Committed: https://crrev.com/39caad968f9b43d7b24d6c2d75596161a951de68
> > Cr-Commit-Position: refs/heads/master@{#298805}
>
> BUG=423001
>
> Review URL: https://codereview.chromium.org/856633002
>
> Cr-Commit-Position: refs/heads/master@{#312290}
BUG=423001
[email protected]
Review URL: https://codereview.chromium.org/865133003
Cr-Commit-Position: refs/branch-heads/2272@{#181}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] [Win] Fix crash if the profile dir cannot be created
If the profile is NULL, the code will hit the CHECK on line 389 anyway.
BUG=414332
[email protected]
Review URL: https://codereview.chromium.org/878143003
Cr-Commit-Position: refs/heads/master@{#313709}
(cherry picked from commit 82e87d588df3a7334cf542ce68c9614869745f70)
Review URL: https://codereview.chromium.org/897453002
Cr-Commit-Position: refs/branch-heads/2272@{#180}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Make SetDisplayPower() take a callback to signal completion
SetDisplayPower() is called by powerd to turn the panel on. After that
powerd will set the backlight level. Since DisplayConfigurator may be
executing the SetDisplayPower() operation asynchronously, the panel
may still be off when powerd tries to set the backlight level. So
powerd's operation would be ignored by the driver.
BUG=chrome-os-partner:35662
Review URL: https://codereview.chromium.org/886103002
Cr-Commit-Position: refs/heads/master@{#313983}
(cherry picked from commit eebe273b953b5c726473d2af63feb13dd0d5f090)
Review URL: https://codereview.chromium.org/892183003
Cr-Commit-Position: refs/branch-heads/2272@{#179}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] Fix "choose what to sync" in the webview signin
When "Choose what to sync" is clicked, we change the source to 3 in the
gaia continue url.
BUG=452440
[email protected]
Review URL: https://codereview.chromium.org/892493002
(cherry picked from commit ef953dd4a7075adbda2cb5d6fdb366fc9bf4e2e5)
Review URL: https://codereview.chromium.org/899433002
Cr-Commit-Position: refs/branch-heads/2272@{#178}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Allow universal access from file if flag is set and url is file scheme.
BUG=449075
TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation
Review URL: https://codereview.chromium.org/855883002
Cr-Commit-Position: refs/heads/master@{#313051}
(cherry picked from commit 3d426436e10135a99f5e54fe1135767eb55712db)
[email protected]
Review URL: https://codereview.chromium.org/895463003
Cr-Commit-Position: refs/branch-heads/2272@{#177}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.41
Cr-Commit-Position: refs/branch-heads/2272@{#176}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
This is the necessary change in the upstream to fix the issue.
Pipe DidStartNavigationToPendingEntry to WebContentsObserver and TabObserver.
BUG=442726
Review URL: https://codereview.chromium.org/877163005
Cr-Commit-Position: refs/heads/master@{#313866}
(cherry picked from commit 4bd261aa366bb94978366d0081b289b92648b810)
Review URL: https://codereview.chromium.org/890223002
Cr-Commit-Position: refs/branch-heads/2272@{#175}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge "cros: Restrict gaiaURL to be http and https only."
> BUG=453994
>
> Review URL: https://codereview.chromium.org/888173002
>
> Cr-Commit-Position: refs/heads/master@{#314070}
> (cherry picked from commit 86076330c0bb161d7660555c4f514200ca897218)
[email protected]
Review URL: https://codereview.chromium.org/893893002
Cr-Commit-Position: refs/branch-heads/2272@{#174}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.40
Cr-Commit-Position: refs/branch-heads/2272@{#173}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Search] Identity check for New Tab Page should use canonicalized form
Was causing a bug where identities were slightly different.
BUG=453792
Review URL: https://codereview.chromium.org/864223006
Cr-Commit-Position: refs/heads/master@{#313955}
(cherry picked from commit ed8d517fc97a8b0c3542669279b0482727255a32)
Review URL: https://codereview.chromium.org/886233003
Cr-Commit-Position: refs/branch-heads/2272@{#172}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
VP8Decoder: Drop references to reference frames earlier.
Drop references to reference frames before requesting new surfaces to
ensure we don't hold onto them while the Accelerator is changing resolution,
risking reusing a stale buffer.
BUG=chrome-os-partner:35539
TEST=Hangouts, vdatest
Review URL: https://codereview.chromium.org/880773009
Cr-Commit-Position: refs/heads/master@{#313679}
(cherry picked from commit 0f47fc976b37b54583a061b0628f994bf727ba30)
Review URL: https://codereview.chromium.org/892783002
Cr-Commit-Position: refs/branch-heads/2272@{#171}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Update icon.
The 256x256 and 512x512 pngs are not used anywhere, so I deleted them.
BUG=453510
[email protected]
Review URL: https://codereview.chromium.org/890883005
Cr-Commit-Position: refs/heads/master@{#314025}
(cherry picked from commit f53150c7287e14d357dd2671ab5a0bacae443b82)
Review URL: https://codereview.chromium.org/891513003
Cr-Commit-Position: refs/branch-heads/2272@{#170}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.39
Cr-Commit-Position: refs/branch-heads/2272@{#169}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Autofill: Set requirements for number of recognized fields in an autofillable form
BUG=447332
Review URL: https://codereview.chromium.org/853523004
Cr-Commit-Position: refs/heads/master@{#313551}
(cherry picked from commit 97338dbd9d3367fec22d2f690156df85c0b2572b)
Review URL: https://codereview.chromium.org/886183002
Cr-Commit-Position: refs/branch-heads/2272@{#168}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add Errors to user_story_runner to avoid benchmarks staying green when there are archive errors.
BUG=442738
Review URL: https://codereview.chromium.org/799543006
Cr-Commit-Position: refs/heads/master@{#312997}
(cherry picked from commit f420ae317381ca52bf1b1548d1a661b80b0facca)
[Telemetry] Fix WPR files not being downloaded when required.
BUG=
Review URL: https://codereview.chromium.org/834173006
Cr-Commit-Position: refs/heads/master@{#311496}
(cherry picked from commit 672e7140315568e9bfc442770a23fee66e045cb2)
BUG=452247
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/887123002
Cr-Commit-Position: refs/branch-heads/2272@{#167}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge M41: Observe UsbService from the FILE thread in DevicePermissionsManager.
As in the UsbEventRouter the UsbService must be observed from the FILE
thread (until bug 427985 is resolved, which will be soon). This change
fixes a DCHECK(CalledOnValidThread()) in UsbService::AddObserver when
permission to access an ephemeral (no serial number) device is added and
the DevicePermissionsManager starts listening for disconnection of that
device.
BUG=452652
NOTRY=true
Review URL: https://codereview.chromium.org/882813002
(cherry-picked from commit 897bbc219ac773a8a6c5799bc323b9fa8eea0989)
Cr-Commit-Position: refs/heads/master@{#313548}
Review URL: https://codereview.chromium.org/872313004
Cr-Commit-Position: refs/branch-heads/2272@{#166}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix black background in website settings dropdown.
The permission spinner in the website settings popup had a black
background on certain devices. The bug was that the background was a
defined using a <shape> element that didn't have a <solid> element
inside of it (and certain devices default to a black fill color if
<solid> isn't specified).
Rather than fixing the immediate problem, this rewrites the code a bit:
The line under the Spinner is now a View with 1dp height rather than the
background of the Spinner's TextView. As a side-benefit, the underline
now extends all the way to the right edge of the spinner.
BUG=449643
Review URL: https://codereview.chromium.org/870143003
Cr-Commit-Position: refs/heads/master@{#313833}
(cherry picked from commit 168e275c4b6a6f0eb34cea473474fdeb997f588d)
Review URL: https://codereview.chromium.org/888043004
Cr-Commit-Position: refs/branch-heads/2272@{#165}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Move referrer policy to a different field when serializing.
Also try to fix old entries when possible and play nice with older
versions
BUG=450589
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/869613006
Cr-Commit-Position: refs/heads/master@{#313742}
(cherry picked from commit 31d74bdc6a4b3c9e766ae8fc9297f1db8fedff49)
Review URL: https://codereview.chromium.org/885923005
Cr-Commit-Position: refs/branch-heads/2272@{#164}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add missig referrer policies to sanitization code
BUG=450589
[email protected]
Review URL: https://codereview.chromium.org/890473003
Cr-Commit-Position: refs/heads/master@{#313689}
(cherry picked from commit a7a95bebc8874f3cfba15c2ebb6912f6384a106b)
Review URL: https://codereview.chromium.org/887063002
Cr-Commit-Position: refs/branch-heads/2272@{#163}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix referrer policy handling in service workers
BUG=450589
[email protected],[email protected]
Review URL: https://codereview.chromium.org/862053002
Cr-Commit-Position: refs/heads/master@{#313072}
(cherry picked from commit 73fc00d1a4a2006dafc077cdde45a0a69d4c1d13)
Review URL: https://codereview.chromium.org/890973002
Cr-Commit-Position: refs/branch-heads/2272@{#162}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge 313687: Cryptohome: Notify about error in async calls if cryptohome is not ready yet.
BUG=451148
Review URL: https://codereview.chromium.org/880303003
Cr-Commit-Position: refs/heads/master@{#313687}
(cherry picked from commit 7df6f9fc7fcd1c02babf89548ce967bf8605b7f3)
Review URL: https://codereview.chromium.org/887003002
Cr-Commit-Position: refs/branch-heads/2272@{#161}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Video Player] Remove the default id of the video player
Setting the default id causes the regression crbug.com/450095, so this patch removes it.
BUG=450095
TEST=manually tested
[email protected]
Review URL: https://codereview.chromium.org/810483005
Cr-Commit-Position: refs/heads/master@{#312182}
(cherry picked from commit f97f8f3fb09375cf82874a96e5ce45b8c8838182)
Review URL: https://codereview.chromium.org/893533004
Cr-Commit-Position: refs/branch-heads/2272@{#160}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Insert in-process GPU switches on UI thread
For in-process gpu, the CommandLine of the current process is a shared
resource and cannot be safely manipulated on the IO thread.
This moves inserting the gpu command line switches to the UI thread, and
slightly start up. Although still need additional fixes to start up code
to ensure it's safe to manipulate it on UI thread.
This also fixes the bug of inserting gpu switches when GpuProcessHost is
not used, for example in android webview.
BUG=450396
Review URL: https://codereview.chromium.org/865063002
Cr-Commit-Position: refs/heads/master@{#313177}
(cherry picked from commit 6d695e6f5b99b8631e06788d2f9f9f9ed12c057e)
[email protected]
Review URL: https://codereview.chromium.org/889703005
Cr-Commit-Position: refs/branch-heads/2272@{#159}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.38
Cr-Commit-Position: refs/branch-heads/2272@{#158}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix infobar scrolling.
The infobar container became non-scrollable because InfoBarContainer now
ignores all touch events in InfoBarContainer.onTouch(). These touch
events need to be swallowed to prevent them from reaching the webpage,
but they should be swallowed in ContentWrapperView, not in
InfoBarContainer, so that InfoBarContainer (which extends ScrollView)
can be scrolled.
The offending CL: https://codereview.chromium.org/824763002
BUG=453103
Review URL: https://codereview.chromium.org/872113003
Cr-Commit-Position: refs/heads/master@{#313668}
(cherry picked from commit 7ef78075948121486f0061d3f75418d0dfda284c)
Review URL: https://codereview.chromium.org/878393003
Cr-Commit-Position: refs/branch-heads/2272@{#157}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Improve apps v2 upgrade UX
The current v1 web-app allows users to sign in as any user. Some users may
be signed in using a different account than their chrome profile.
When these users upgrade to the v2 app, their host list will be empty and
it is not straightforward why.
This CL shows a migration tip to inform the users to sign-in to their
previous account if necessary.
BUG=369835
TBR=jamiewalch
Review URL: https://codereview.chromium.org/848993002
Cr-Commit-Position: refs/heads/master@{#312549}
(cherry picked from commit ef56d877133d43c368ba50cf3ced6c39ec2f9c6c)
Review URL: https://codereview.chromium.org/883363002
Cr-Commit-Position: refs/branch-heads/2272@{#156}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
PepperVideoSourceHost: Set timestamp of intermediate scaled frame.
TBR=bbudge
BUG=451021
Review URL: https://codereview.chromium.org/868703002
Cr-Commit-Position: refs/heads/master@{#312626}
(cherry picked from commit 8dbe088dee9122e5db470ff10ca2fbbb73bfca15)
Review URL: https://codereview.chromium.org/886603005
Cr-Commit-Position: refs/branch-heads/2272@{#155}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Hide pinch viewport scrollbars when near minimum scale.
This patch prevents the overlay scrollbars from showing up when we're near the
minimum scale. The threshold can be set per-platform; by default it's 0 so the
scrollbars will be visible regardless of the scale. On Windows/Linux/CrOS we'd
like to prevent the scrollbars from overlaying over the window scrollbars so
we set a small non-0 threshold.
BUG=446411
Review URL: https://codereview.chromium.org/877863002
Cr-Commit-Position: refs/heads/master@{#313431}
(cherry picked from commit c784a6f02ed8f2cffe131c2c067c4805cd752610)
Review URL: https://codereview.chromium.org/885063002
Cr-Commit-Position: refs/branch-heads/2272@{#154}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add metric for navigation starting from the time an intent was received
This CL adds two metrics that measure the time between receiving an Android
intent and the commit and completion of a navigation.
BUG=436955
Review URL: https://codereview.chromium.org/809043002
Cr-Commit-Position: refs/heads/master@{#312861}
(cherry picked from commit 8451aa6c32e3d0236266445aa10fab9424b1ac42)
Review URL: https://codereview.chromium.org/887703002
Cr-Commit-Position: refs/branch-heads/2272@{#153}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix controlled setting indicators on network settings page.
This is intentionally not touching IPConfig or DNS, to not change the behavior of these when merging to old branches.
BUG=450787
NOPRESUBMIT=true
[email protected]
Review URL: https://codereview.chromium.org/862263003
Cr-Commit-Position: refs/heads/master@{#312806}
(cherry picked from commit 58b1dd3f0b4ed01d9ceb13f65e7ed2a3fd0370ae)
Review URL: https://codereview.chromium.org/867363005
Cr-Commit-Position: refs/branch-heads/2272@{#152}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.37
Cr-Commit-Position: refs/branch-heads/2272@{#151}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge into M41 branch 2272] Handle Caps Lock for Ozone.
BUG=447277
Review URL: https://codereview.chromium.org/878673004
Cr-Commit-Position: refs/heads/master@{#313341}
(cherry picked from commit 8a5ce90e69b39e9e5a0decb278008dc3e7a85cb7)
Review URL: https://codereview.chromium.org/884903002
Cr-Commit-Position: refs/branch-heads/2272@{#150}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M41: Make Windows accessibility event firing aware of guest / child frames.
Windows-specific fixes for accessibility of out-of-process iframes
and guest frames (e.g. <webview>):
1. When firing an event or doing a bounds calculation, we need to
call functions on the root BrowserAccessibilityManager's delegate
(not on the child frame's delegate).
2. When a MSAA client tries to look up an MSAA object by child ID,
we need to search child frames as well.
BUG=330307, 368298
Review URL: https://codereview.chromium.org/799633007
Cr-Commit-Position: refs/heads/master@{#312080}
(cherry picked from commit 28060a875c0a7fb9bbfe06a0057b4321518599a7)
Review URL: https://codereview.chromium.org/877323007
Cr-Commit-Position: refs/branch-heads/2272@{#149}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge to M41: Fix focus and bounds calculations for guest frames.
Two fixes for accessibility of out-of-process iframes and guest frames
(e.g. <webview>):
1. BrowserAccessibilityManager::GetFocus should return the focused node
from a child frame.
2. BrowserAccessibilityManager::GetLocalBoundsRect and
BrowserAccessibilityCocoa::pointInScreen need to correctly take
child frames into account.
This is sufficient for correct spoken feedback and UI element bounding
rects in VoiceOver when tabbing into and out of an out-of-process iframe
or <webview> guest frame. There may be other bugs, but simple examples
work in VoiceOver now.
BUG=330307,368298
Review URL: https://codereview.chromium.org/849143003
Cr-Commit-Position: refs/heads/master@{#311777}
(cherry picked from commit e8091802505a507bb6c11683fe77cf7b1d455e6d)
Review URL: https://codereview.chromium.org/887503002
Cr-Commit-Position: refs/branch-heads/2272@{#148}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
aura: Fix event dispatch when a 'held' event triggers a menu.
A 'held' event can trigger a menu (and a nested message loop), e.g. when
right-clicking while a menu is already showing. In such scenario, the subsequent
events that come in while the latest menu is up are not transformed correctly,
because the WindowEventDispatcher notices that a held event is in the process of
being dispatched. As a result, the events have incorrect coordinates (especially
when device scale factor is not 1, or when the display is rotated). To fix this,
instead of simply tracking whether a 'held' event is being dispatched or not, we
track the 'held' event itself, and transform all the non-held events.
BUG=425407
[email protected]
[email protected] [since merge]
Review URL: https://codereview.chromium.org/829353005
Cr-Commit-Position: refs/heads/master@{#311651}
(cherry picked from commit 9af9ccd01bb33f591fa6dcdc94393ff0377c4a3a)
Review URL: https://codereview.chromium.org/882253003
Cr-Commit-Position: refs/branch-heads/2272@{#147}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.36
Cr-Commit-Position: refs/branch-heads/2272@{#146}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Disabled animation in indeterminate progress bar.
The animation caused high CPU usage at OOBE, even when progress bar was hidden.
<indeterminate-progress> is used only in Hotrod pairing flow, which is not
released yet, so the animation could be safely disabled for now. <indeterminate-
progress> will be completely replaced by <paper-progress indeterminate> in
scope of http://crbug.com/423363
BUG=450758
NOTRY=true
Review URL: https://codereview.chromium.org/874923003
Cr-Commit-Position: refs/heads/master@{#313262}
(cherry picked from commit ddacbb0e77f0350fe9e832bb36e33267b4918ed5)
Review URL: https://codereview.chromium.org/882153002
Cr-Commit-Position: refs/branch-heads/2272@{#145}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Only report exit funnels for canary and dev channels.
BUG=442526
Review URL: https://codereview.chromium.org/868163002
Cr-Commit-Position: refs/heads/master@{#312911}
Review URL: https://codereview.chromium.org/883653003
Cr-Commit-Position: refs/branch-heads/2272@{#144}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] [PasswordManager] Do not save change password forms
This is a merge of https://crrev.com/312179, approved in http://crbug.com/447558#c11.
Original description:
********************************************
Change password forms are not yet supported in PasswordManager. But after adding pushState support recently, they could be offered to the user for saving.
This CL adds a check to avoid change password forms being saved.
Review URL: https://codereview.chromium.org/812033010
Cr-Commit-Position: refs/heads/master@{#312179}
********************************************
(cherry picked from commit 79a244fb1a52c5f3594e31113d606c80000e90dd)
BUG=447558, 448351
[email protected]
Review URL: https://codereview.chromium.org/884093002
Cr-Commit-Position: refs/branch-heads/2272@{#143}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[content]: Cancel in-flight EndIdlePeriod tasks in Blink Scheduler.
The scheduler will post a delayed EndIdlePeriod task to end the idle period
at the expected time of the next frame draw. If the next WillBeginFrame
is called before this task has been run, then it is possible for the task
to end the next frames idle period. Prevent this by cancelling the in-flight
tasks when EndIdlePeriod is called.
BUG=447478
[email protected]
Review URL: https://codereview.chromium.org/847903004
Cr-Commit-Position: refs/heads/master@{#313038}
(cherry picked from commit c16cee51c7e2fe59896c5883d6c24b1fa67bf752)
Review URL: https://codereview.chromium.org/884053002
Cr-Commit-Position: refs/branch-heads/2272@{#142}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.35
Cr-Commit-Position: refs/branch-heads/2272@{#141}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[android_webview] Add the apk resources to the Android build.
This adds the resources from the apk/ folder to the Android build
to enable removing the downstream resources.
BUG=None
TESTS=android_aosp bot
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/828153004
Cr-Commit-Position: refs/heads/master@{#311268}
(cherry picked from commit 56a8804fce1b48fbf0e02e8ba40536563c3ad349)
Review URL: https://codereview.chromium.org/882843004
Cr-Commit-Position: refs/branch-heads/2272@{#140}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Win] Fix black screen when min/maximizing hidden app window.
On Windows, an app window that is initialized with hidden:true and
state:'maximized' will start visible and maximized, but its content is
all black. This is because maximizing a hidden window on Windows causes
the window to be shown, but this path does not also trigger the content
to show.
This CL is a temporary fix to prevent the above state without changing
the current behavior. App windows that are initially hidden will not
also be maximized, minimized, or fullscreen. On Windows, maximizing or
minimizing hidden app windows will cause them to be shown.
In the long term, we want the behavior on Windows to match CrOS where
calling maximize() on a hidden window does nothing, and the next show()
will show the window maximized.
BUG=436867
Review URL: https://codereview.chromium.org/851233002
Cr-Commit-Position: refs/heads/master@{#312061}
(cherry picked from commit 3d1fd029975c325129474b9d4e262940d99ab375)
[email protected]
Review URL: https://codereview.chromium.org/876413004
Cr-Commit-Position: refs/branch-heads/2272@{#139}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix Security Key proxying.
Gnubby was added a a Capbility in https://codereview.chromium.org/787033003,
but since it is not negotiated between host and client, that's not the right
way to make it configurable.
BUG=448131
[email protected]
Review URL: https://codereview.chromium.org/878573006
Cr-Commit-Position: refs/heads/master@{#313181}
(cherry picked from commit fba61916fc0618e7ed05ccfc7b846311d499c6d2)
Review URL: https://codereview.chromium.org/877243002
Cr-Commit-Position: refs/branch-heads/2272@{#138}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Only release the result of a register request to a tab if it's still the foreground tab when the result is received.
BUG=451165
[email protected],[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/866473009
Cr-Commit-Position: refs/branch-heads/2272@{#137}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix the bookmanager page display issue on MacOS.
This issue has something to do with the splitter button since this button is only used for height matching. But without content in the button, sometime it won't occupy the correct amount of vertical space.
This CL does the fix by putting some content inside the splitter button.
BUG=448007
[email protected]
Review URL: https://codereview.chromium.org/865743002
Cr-Commit-Position: refs/heads/master@{#312708}
Review URL: https://codereview.chromium.org/879023002
Cr-Commit-Position: refs/branch-heads/2272@{#136}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge][Win] The tab strip's opaque background overlaps the avatar button.
The tab strip is actually about 4 px taller than the drawn tab, so when
applying an alpha to make the inactive tabs slightly transparent, this
alpha "leaks" onto the avatar button and adds a transparency to its
bottom border.
I set the background to red to demonstrate this, so here are some screenshots:
Before the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMRXRJRjN2MG41Y0k&authuser=1
After the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMRzJJUmluT2QwSDA&authuser=1
Finally, how the tab strip actually looks like with normal colours:
Before the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMd0F0dWZnby12T0k&authuser=1
After the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMa2o0aUNxaE12ZGs&authuser=1
BUG=430380
[email protected]
TEST=Start Chrome with --enable-new-avatar-menu. The bottom of the avatar
button should look the same throughout (and not have any random transparencies)
Review URL: https://codereview.chromium.org/859303008
Cr-Commit-Position: refs/heads/master@{#312721}
(cherry picked from commit 298156be041512f6d4a78bdba5c90454d3d2dfdb)
Review URL: https://codereview.chromium.org/882723004
Cr-Commit-Position: refs/branch-heads/2272@{#135}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert of Roll DEPS for trace-viewer in m41 to a chrome_m41 branch in google/trace-viewer (patchset #1 id:1 of https://codereview.chromium.org/871313003/)
Reason for revert:
Wrong file changed for DEPS (should be chrome-internal/trunk/tools/buildspec/branches/2272/DEPS). And the new revision 0d5dd07fc24e9ef68772648ed3e9d28533908263 is not mirrored into appropriate chromium trace-viewer repo.
Original issue's description:
> Roll DEPS for trace-viewer in m41 to a chrome_m41 branch in google/trace-viewer
>
> DEPS roll for trace-viewer
> from https://github.com/google/trace-viewer/commit/2e06625efecbc76efa79e7ea5481dabf05daf5cd
> to https://github.com/google/trace-viewer/commit/0d5dd07fc24e9ef68772648ed3e9d28533908263
>
> BUG=448167
> [email protected]
> TBR=nduca, pennymac
>
> Committed: https://chromium.googlesource.com/chromium/src/+/366a69983f0965a77fe95229e04f60745aa32963
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448167
Review URL: https://codereview.chromium.org/878763004
Cr-Commit-Position: refs/branch-heads/2272@{#134}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Make manual zoom mode capable of showing zoom bubble.
Up until now, using ZOOM_MODE_MANUAL would never trigger the zoom bubble
when the zoom level changed. This CL makes the value of can_show_bubble
configurable by the owner of the ZoomController.
BUG=451102
Review URL: https://codereview.chromium.org/841863004
(cherry picked from commit 9595db00572df9284517da710a414f909c0e0c1f)
Cr-Original-Commit-Position: refs/heads/master@{#312679}
Cr-Commit-Position: refs/branch-heads/2272@{#133}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
