Publish DEPS for Chromium 41.0.2272.35
Incrementing VERSION to 41.0.2272.35
Cr-Commit-Position: refs/branch-heads/2272@{#141}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[android_webview] Add the apk resources to the Android build.
This adds the resources from the apk/ folder to the Android build
to enable removing the downstream resources.
BUG=None
TESTS=android_aosp bot
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/828153004
Cr-Commit-Position: refs/heads/master@{#311268}
(cherry picked from commit 56a8804fce1b48fbf0e02e8ba40536563c3ad349)
Review URL: https://codereview.chromium.org/882843004
Cr-Commit-Position: refs/branch-heads/2272@{#140}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Win] Fix black screen when min/maximizing hidden app window.
On Windows, an app window that is initialized with hidden:true and
state:'maximized' will start visible and maximized, but its content is
all black. This is because maximizing a hidden window on Windows causes
the window to be shown, but this path does not also trigger the content
to show.
This CL is a temporary fix to prevent the above state without changing
the current behavior. App windows that are initially hidden will not
also be maximized, minimized, or fullscreen. On Windows, maximizing or
minimizing hidden app windows will cause them to be shown.
In the long term, we want the behavior on Windows to match CrOS where
calling maximize() on a hidden window does nothing, and the next show()
will show the window maximized.
BUG=436867
Review URL: https://codereview.chromium.org/851233002
Cr-Commit-Position: refs/heads/master@{#312061}
(cherry picked from commit 3d1fd029975c325129474b9d4e262940d99ab375)
[email protected]
Review URL: https://codereview.chromium.org/876413004
Cr-Commit-Position: refs/branch-heads/2272@{#139}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix Security Key proxying.
Gnubby was added a a Capbility in https://codereview.chromium.org/787033003,
but since it is not negotiated between host and client, that's not the right
way to make it configurable.
BUG=448131
[email protected]
Review URL: https://codereview.chromium.org/878573006
Cr-Commit-Position: refs/heads/master@{#313181}
(cherry picked from commit fba61916fc0618e7ed05ccfc7b846311d499c6d2)
Review URL: https://codereview.chromium.org/877243002
Cr-Commit-Position: refs/branch-heads/2272@{#138}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Only release the result of a register request to a tab if it's still the foreground tab when the result is received.
BUG=451165
[email protected],[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/866473009
Cr-Commit-Position: refs/branch-heads/2272@{#137}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix the bookmanager page display issue on MacOS.
This issue has something to do with the splitter button since this button is only used for height matching. But without content in the button, sometime it won't occupy the correct amount of vertical space.
This CL does the fix by putting some content inside the splitter button.
BUG=448007
[email protected]
Review URL: https://codereview.chromium.org/865743002
Cr-Commit-Position: refs/heads/master@{#312708}
Review URL: https://codereview.chromium.org/879023002
Cr-Commit-Position: refs/branch-heads/2272@{#136}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge][Win] The tab strip's opaque background overlaps the avatar button.
The tab strip is actually about 4 px taller than the drawn tab, so when
applying an alpha to make the inactive tabs slightly transparent, this
alpha "leaks" onto the avatar button and adds a transparency to its
bottom border.
I set the background to red to demonstrate this, so here are some screenshots:
Before the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMRXRJRjN2MG41Y0k&authuser=1
After the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMRzJJUmluT2QwSDA&authuser=1
Finally, how the tab strip actually looks like with normal colours:
Before the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMd0F0dWZnby12T0k&authuser=1
After the CL:
https://drive.google.com/open?id=0B1B1Up4p2NRMa2o0aUNxaE12ZGs&authuser=1
BUG=430380
[email protected]
TEST=Start Chrome with --enable-new-avatar-menu. The bottom of the avatar
button should look the same throughout (and not have any random transparencies)
Review URL: https://codereview.chromium.org/859303008
Cr-Commit-Position: refs/heads/master@{#312721}
(cherry picked from commit 298156be041512f6d4a78bdba5c90454d3d2dfdb)
Review URL: https://codereview.chromium.org/882723004
Cr-Commit-Position: refs/branch-heads/2272@{#135}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert of Roll DEPS for trace-viewer in m41 to a chrome_m41 branch in google/trace-viewer (patchset #1 id:1 of https://codereview.chromium.org/871313003/)
Reason for revert:
Wrong file changed for DEPS (should be chrome-internal/trunk/tools/buildspec/branches/2272/DEPS). And the new revision 0d5dd07fc24e9ef68772648ed3e9d28533908263 is not mirrored into appropriate chromium trace-viewer repo.
Original issue's description:
> Roll DEPS for trace-viewer in m41 to a chrome_m41 branch in google/trace-viewer
>
> DEPS roll for trace-viewer
> from https://github.com/google/trace-viewer/commit/2e06625efecbc76efa79e7ea5481dabf05daf5cd
> to https://github.com/google/trace-viewer/commit/0d5dd07fc24e9ef68772648ed3e9d28533908263
>
> BUG=448167
> [email protected]
> TBR=nduca, pennymac
>
> Committed: https://chromium.googlesource.com/chromium/src/+/366a69983f0965a77fe95229e04f60745aa32963
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448167
Review URL: https://codereview.chromium.org/878763004
Cr-Commit-Position: refs/branch-heads/2272@{#134}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Make manual zoom mode capable of showing zoom bubble.
Up until now, using ZOOM_MODE_MANUAL would never trigger the zoom bubble
when the zoom level changed. This CL makes the value of can_show_bubble
configurable by the owner of the ZoomController.
BUG=451102
Review URL: https://codereview.chromium.org/841863004
(cherry picked from commit 9595db00572df9284517da710a414f909c0e0c1f)
Cr-Original-Commit-Position: refs/heads/master@{#312679}
Cr-Commit-Position: refs/branch-heads/2272@{#133}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.34
Cr-Commit-Position: refs/branch-heads/2272@{#132}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
GLHelper::CopySubBufferDamage doesn't restore the old framebuffer
This fixes a problem in SW mirror mode where it attempts to copy
out of the temporary framebuffer
NOTRY=true
BUG=434115
Review URL: https://codereview.chromium.org/850543003
Cr-Commit-Position: refs/heads/master@{#312859}
(cherry picked from commit 8371fd8f9c6e15bb2af70da84e2e99005be86564)
Review URL: https://codereview.chromium.org/874763004
Cr-Commit-Position: refs/branch-heads/2272@{#131}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
compositor: Fix texture flipping for SW mirroring with surfaceless
Ozone-surfaceless renders the scene flipped, so the texture contents are
inverted from what they should be. This fixes the mirroring logic to
un-flip the texture when needed, and also to send the right sub-buffer
update rect.
NOTRY=true
BUG=434115
Review URL: https://codereview.chromium.org/846063002
Cr-Commit-Position: refs/heads/master@{#312979}
(cherry picked from commit c6a481fe79e0c4851a576495105edf2600bfe5be)
Review URL: https://codereview.chromium.org/874353004
Cr-Commit-Position: refs/branch-heads/2272@{#130}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add the ability for test contexts to generate unique render & framebuffer IDs
Also, adds tests for that and a test to make sure a non-zero framebuffer
is preserved throughout DrawFrame. This is needed for a new render path
using overlays instead of using the default surface.
NOTRY=true
BUG=434115
Review URL: https://codereview.chromium.org/384053002
Cr-Commit-Position: refs/heads/master@{#312687}
(cherry picked from commit b937bfa4d5eaca4c9ac6ec13715792238cef1b98)
Review URL: https://codereview.chromium.org/881523002
Cr-Commit-Position: refs/branch-heads/2272@{#129}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Remove omnibox watcher.
This is effectively a revert of commit positions 308378 and 307774.
BUG=451173
[email protected],[email protected]
Review URL: https://codereview.chromium.org/872433003
Cr-Commit-Position: refs/heads/master@{#312943}
(cherry picked from commit 9d291627a0309ab645d1bc9dab4646bf2a9119ac)
Review URL: https://codereview.chromium.org/876013002
Cr-Commit-Position: refs/branch-heads/2272@{#128}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix athena compilation on 2272
Port https://codereview.chromium.org/874943002 to the meanwhile delete
athena/
BUG=452396,450547
[email protected]
Review URL: https://codereview.chromium.org/882623002
Cr-Commit-Position: refs/branch-heads/2272@{#127}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Roll DEPS for trace-viewer in m41 to a chrome_m41 branch in google/trace-viewer
DEPS roll for trace-viewer
from https://github.com/google/trace-viewer/commit/2e06625efecbc76efa79e7ea5481dabf05daf5cd
to https://github.com/google/trace-viewer/commit/0d5dd07fc24e9ef68772648ed3e9d28533908263
BUG=448167
[email protected]
TBR=nduca, pennymac
Review URL: https://codereview.chromium.org/871313003
Cr-Commit-Position: refs/branch-heads/2272@{#126}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.33
Cr-Commit-Position: refs/branch-heads/2272@{#125}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: Prevent UAF of RenderFrames from GuestViewContainer
Current the RenderFrame a GuestViewContainer is associated with can be
accessed even after it is destroyed. We should track the destruction with
a RenderFrameObserver and avoid accesses in that case.
BUG=449574
Committed: https://crrev.com/4d29dd615212c539463a4e4a02188aa34d06e96f
Cr-Commit-Position: refs/heads/master@{#312143}
Review URL: https://codereview.chromium.org/822483007
Cr-Commit-Position: refs/heads/master@{#312216}
(cherry picked from commit 569ce1bcb696473c117b8afdc15871183c0052ef)
[email protected]
Review URL: https://codereview.chromium.org/876983002
Cr-Commit-Position: refs/branch-heads/2272@{#124}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix to the GCM Account Tracker flooding on a stale refresh token
As a solution to a problem the Account Tracker will assume a stale
refresh token when it cannot get access token. Backoff logic in
token fetcher handles the case where service might not be reachale
and situations like that.
If the user signs in properly the account will be re-added.
BUG=452131
[email protected]
[email protected], [email protected]
Review URL: https://codereview.chromium.org/878713002
Cr-Commit-Position: refs/heads/master@{#313136}
(cherry picked from commit be981e7796e29eba1ab9c6e7c65d1c56b0840b5f)
Review URL: https://codereview.chromium.org/863173006
Cr-Commit-Position: refs/branch-heads/2272@{#123}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
V4L2SVDA: Don't drop an input buffer on Reset if a frame is pending.
H264Decoder has to wait for the next frame NALUs to be able to discover
frame boundaries, so decode submission is always delayed. If we Reset
while such a frame is pending decode, we will never send it to hardware,
so even though we reclaim the pending output V4L2 buffer, we lose the input.
Fix this by resetting the input queue when finalizing reset.
TEST=vdatests, seektests
BUG=chrome-os-partner:35616
Review URL: https://codereview.chromium.org/865393002
Cr-Commit-Position: refs/heads/master@{#312816}
(cherry picked from commit a795a5a89e7fe776a3f071e635cc6fd1948069e1)
Review URL: https://codereview.chromium.org/879443005
Cr-Commit-Position: refs/branch-heads/2272@{#122}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Remove hardware check that enables always-on hotwording.
BUG=448859
Review URL: https://codereview.chromium.org/805943005
Cr-Commit-Position: refs/heads/master@{#311797}
(cherry picked from commit e014345eab81e39c48956f9dae0cc0c66e170f08)
[email protected],[email protected]
Review URL: https://codereview.chromium.org/876793003
Cr-Commit-Position: refs/branch-heads/2272@{#121}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: Remove tcmalloc on Windows. Restore 2Gb limit and NULL checks.
CLs cherry-picked in this CL are:
74a449cac1340e85b3ef06be59a91fdd29110454
bc1bb9d28de48fe3dd339ed1948bbba9addc4bd9
f0a9f088fb28f4beb0229e599b99c9fdce8de17f
c324546cf857bae485efb9a2d80eec6d50d18ed5
BUG=169327,434397,448456
TEST=base_unittests allocator_unittests
Details:
Restore debug allocator functions.
These are needed for Debug builds when using allocator_shim.
These were accidently removed in r312720.
BUG=451663
TEST=base_unittests, allocator_unittests (Debug, component=static_library)
Review URL: https://codereview.chromium.org/872153002
Cr-Commit-Position: refs/heads/master@{#313108}
(cherry picked from commit c324546cf857bae485efb9a2d80eec6d50d18ed5)
Remove optimize max for allocator shim on Windows. This optimization is no longer needed as we are not using tcmalloc.
LTCG was inlining all the new() operators causing a bloat in mini_installer.exe.
mini_installer.exe:
Before: 40,541,184
After: 40,401,408
courgette patch from 40.0.2214.85 (uncompressed):
Before: 19,846,729
After: 19,714,831
BUG=448456,434397
Review URL: https://codereview.chromium.org/860083002
Cr-Commit-Position: refs/heads/master@{#312777}
(cherry picked from commit f0a9f088fb28f4beb0229e599b99c9fdce8de17f)
Tidy up the allocator shim, which is now Windows only.
Only re-implement the functions that we really need to re-implement to perform our additional checks. Let the CRT do the rest. Mark specifically which functions from which CRT files we are re-implementing. Add missing ones like _query_new_mode.
Fold generic_allocators.cc into allocator_shim_win.cc as this code is now very Windows specific and no point being generic any more.
This is a dependent CL to let ffmpegsumo start using the allocator shims, since it needs _aligned_realloc which the allocator shim never implemented. Instead, let the CRT do this for us, since it just calls our malloc().
BUG=434397,450676,446032,444533
TEST=base_unittests --gtest_filter=SecurityTest.*
TEST=allocator_unittests
Review URL: https://codereview.chromium.org/868533003
Cr-Commit-Position: refs/heads/master@{#312720}
(cherry picked from commit bc1bb9d28de48fe3dd339ed1948bbba9addc4bd9)
Restore the allocator shim on Windows. Add 2Gb limit on allocations via the shim. Remove tcmalloc from Windows.
Restore working tcmalloc_unittests on Linux and allocator_unittests on other platforms. Add Death tests to base_unittests SecurityTests. Fix prep_libc.py to actually strip the objects correctly.
BUG=169327,434397
TEST=base_unittests --gtest_filter=SecurityTest.*
TEST=allocator_unittests, tcmalloc_unittest
Review URL: https://codereview.chromium.org/774683003
Cr-Commit-Position: refs/heads/master@{#311194}
(cherry picked from commit 74a449cac1340e85b3ef06be59a91fdd29110454)
Review URL: https://codereview.chromium.org/873403003
Cr-Commit-Position: refs/branch-heads/2272@{#120}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix accessibility for Switches.
TalkBack doesn't recognize the SwitchCompat class, so it reads events
with that classname as "Checkbox". This works around the bug by marking
accessibility events from SwitchCompat with the Switch class name, which
TalkBack recognizes.
BUG=441702
NOTRY=true
Review URL: https://codereview.chromium.org/868803004
Cr-Commit-Position: refs/heads/master@{#312690}
(cherry picked from commit a9d1caa91d4a8da898c891093845bdd5180ee37e)
Review URL: https://codereview.chromium.org/875193003
Cr-Commit-Position: refs/branch-heads/2272@{#119}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge "kiosk: Close on the last window of kiosk app."
> Helper extension/app could have hidden windows created. Kiosk
> app session should only be bound with the kiosk app's window and
> not affected by them.
>
> BUG=449313
>
> Review URL: https://codereview.chromium.org/873873002
>
> Cr-Commit-Position: refs/heads/master@{#312980}
> (cherry picked from commit 7538ed2a80a3ecbb66527957a2cf2a4af75e3e99)
[email protected]
Review URL: https://codereview.chromium.org/879663002
Cr-Commit-Position: refs/branch-heads/2272@{#118}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge M41: Fix Android USB debugging through DevTools.
First, change 13cf2cfcb5325ecfff98ee8ccde723f22e606d22 introduced a
logic error into AndroidUsbDevice::EnumerateOnFileThread that caused
enumerations to never complete because the BarrierClosure was not
called the correct number of times.
Second, this change may have also exposed an issue (investigated
before) where a libusb_transfer can be cancelled twice, once in
ReleaseInterface and again in CloseInternal. The second cancellation
occurs after the interface has been released and so an invalid handle
is passed to AbortPipe. A cancelled_ member has been added to Transfer
to prevent this from happening.
Some conversions to C++11 range loops (added during debugging to make
the loops clearer) are preserved in this change.
BUG=450007
NOTRY=true
Review URL: https://codereview.chromium.org/864183002
Cr-Commit-Position: refs/heads/master@{#312796}
(cherry picked from commit 6c300b4621621d3154a4606414d4f67fc70b23a9)
Review URL: https://codereview.chromium.org/877853002
Cr-Commit-Position: refs/branch-heads/2272@{#117}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Reject vp8 video having alpha and image planes of different sizes.
Previously we would accept malformed vp8 video files that had alpha and
image planes with different dimensions. Now they result in a decode error.
Also use the alpha image stride when copying the alpha plane, because it
technically doesn't have to be the same as the image stride.
BUG=449958
TEST=ffmpeg_regression_tests
Review URL: https://codereview.chromium.org/858303002
Cr-Commit-Position: refs/heads/master@{#312420}
(cherry picked from commit c1a91a8a6a7132c47a174054f0fb56cc3dc8c069)
[email protected]
Review URL: https://codereview.chromium.org/881533002
Cr-Commit-Position: refs/branch-heads/2272@{#116}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
gpu: Update nvidia workaround to cover Android 5.0.2
Once again, issue remains in Android version 5.0.2.
BUG=438657
Review URL: https://codereview.chromium.org/867893002
Cr-Commit-Position: refs/heads/master@{#312930}
(cherry picked from commit 087a476f516ebbf7461cb8976b5e48e08e19cfcb)
[email protected]
Review URL: https://codereview.chromium.org/865393006
Cr-Commit-Position: refs/branch-heads/2272@{#115}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: BrowserCdmManager: Use weak pointer for MediaDrmBridge callbacks.
Currently we are simply using |this| which is refcounted. This causes circular
referencs and BrowserCdmManager is leaked.
[email protected]
BUG=449608
TEST=Manually tested.
Review URL: https://codereview.chromium.org/855113002
Cr-Commit-Position: refs/heads/master@{#312031}
(cherry picked from commit 89edced64726b7c9776a070a01a07c2d92f9d7a8)
Review URL: https://codereview.chromium.org/878663002
Cr-Commit-Position: refs/branch-heads/2272@{#114}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Android] Temporarily suppress shift modifiers for detected tap gestures
Android's UiAutomator unintentionally bundles the shift modifier with
all accessibliity click MotionEvents. The side-effect is that
accessibility clicks (derived from the MotionEvents) are interpreted
as shift+click, which is not meaningfully implemented on Android.
As a temporary workaround, suppress the standalone shift modifier for
touch-derived tap gestures.
BUG=443247
Review URL: https://codereview.chromium.org/865463002
Cr-Commit-Position: refs/heads/master@{#312385}
(cherry picked from commit 0d264850d7d8b98386db36ca928f99c6418b512d)
Review URL: https://codereview.chromium.org/873973004
Cr-Commit-Position: refs/branch-heads/2272@{#113}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
linux: Exclude size-based configs for Fontconfig defaults.
When querying Fontconfig for default FontRenderParams,
exclude point-size- or pixel-size-based configs.
Family-based configs were already excluded.
BUG=423056
[email protected]
Review URL: https://codereview.chromium.org/810403005
Cr-Commit-Position: refs/heads/master@{#311110}
(cherry picked from commit cacdbdf1c5824614ca13c6af5e99db95f509bde2)
Review URL: https://codereview.chromium.org/871373006
Cr-Commit-Position: refs/branch-heads/2272@{#112}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix anchoring of app modal dialogs on views
We first have to activate the contents before we can query its parent
window. However, we also want to store the currently active window
before activating the contents. Shuffle the code around a bit to achieve
this.
BUG=450547
[email protected]
TEST=as described in the bug
Review URL: https://codereview.chromium.org/871933002
Cr-Commit-Position: refs/heads/master@{#312827}
(cherry picked from commit a2afdec49795431c735f668ed8d93129b155d995)
Review URL: https://codereview.chromium.org/874943002
Cr-Commit-Position: refs/branch-heads/2272@{#111}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge] password_manager::metrics_util::LogUMAHistogramBoolean should upload
This is a merge of https://crrev.com/312395, approved in http://crbug.com/450394#c8.
Original description:
********************************************
Currently, LogUMAHistogramBoolean (unlike LogUMAHistogramEnumeration) does not upload any histograms, because it does not set the kUmaTargetedHistogramFlag.
We need it to upload the histograms, as the very name of the method implies, so this CL adds that flag.
Review URL: https://codereview.chromium.org/790413003
Cr-Commit-Position: refs/heads/master@{#312395}
(cherry picked from commit 063efcf45e7d9ea6eb65ace73220b380d47a591a)
********************************************
BUG=450394
[email protected]
Review URL: https://codereview.chromium.org/877653002
Cr-Commit-Position: refs/branch-heads/2272@{#110}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix the logic for using an HTTP proxy without a tunnel
The logic for determining whether HttpNetworkTransaction was using an HTTP proxy but not tunneled was incorrect for the case of WebSockets. Fix it.
BUG=446459
TEST=net_unittests
[email protected], [email protected]
Review URL: https://codereview.chromium.org/836993002
Cr-Commit-Position: refs/heads/master@{#312073}
(cherry picked from commit 425cf12869fd826d1fceeb5071d3747e88406e6b)
Review URL: https://codereview.chromium.org/870403002
Cr-Commit-Position: refs/branch-heads/2272@{#109}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.32
Cr-Commit-Position: refs/branch-heads/2272@{#108}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Do not invoke DrawFadedString() if it knows it does not fade.
This is intentionally tiny and intended to be merged into M41.
views::Label already knows the size of the text (GetTextSize()
returns the cached size), therefore it knows the current text
does not fade at all.
Since this will avoid the check if the text may fade or not in
gfx::Canvas::DrawFadedString(), this can potentially make
the drawing 2x faster if the text doesn't fade at all.
BUG=451297
[email protected]
TEST=on link_freon, with the bookmark sample in crbug.com/440551
(contains ~15 bookmarks), repaint of bookmark bar is improved
as: ~100msec -> ~55msec
Review URL: https://codereview.chromium.org/870903002
Cr-Commit-Position: refs/heads/master@{#312942}
(cherry picked from commit 887eb46392320c209e507880f8268111c804d99a)
Review URL: https://codereview.chromium.org/856233003
Cr-Commit-Position: refs/branch-heads/2272@{#107}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Crash fix for system-level on-demand updates.
In r306421, I replaced a memset for a struct with an initializer list
so that the compiler would zero it out for us. It turns out that was
bad because BIND_OPTS3 is a derived type, and hence isn't an aggregate
and doesn't follow the normal rules for brace initialization.
BUG=450489
[email protected]
Review URL: https://codereview.chromium.org/869563004
Cr-Commit-Position: refs/heads/master@{#312767}
(cherry picked from commit acb85a2b052671d9f61ccaf357fb44739ac99c1a)
[email protected]
Review URL: https://codereview.chromium.org/871313002
Cr-Commit-Position: refs/branch-heads/2272@{#106}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.31
Cr-Commit-Position: refs/branch-heads/2272@{#105}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Make chrome.webcamPrivate available on stable.
BUG=448157
Review URL: https://codereview.chromium.org/845993004
Cr-Commit-Position: refs/heads/master@{#311148}
(cherry picked from commit e62b1b1ca69fde4fbdc90c6cf586fb8227e02602)
Review URL: https://codereview.chromium.org/873893002
Cr-Commit-Position: refs/branch-heads/2272@{#104}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.30
Cr-Commit-Position: refs/branch-heads/2272@{#103}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Check output_surface_ is not null before calling ForceReclaimResources
BUG=450184
Review URL: https://codereview.chromium.org/859033003
Cr-Commit-Position: refs/heads/master@{#312699}
(cherry picked from commit 2993a080acf3049838a429f4bbf96037ae8c4408)
[email protected]
Review URL: https://codereview.chromium.org/870163003
Cr-Commit-Position: refs/branch-heads/2272@{#102}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Do not pool QUIC sessions when privacy mode mismatches.
BUG=451164
Review URL: https://codereview.chromium.org/868803003
Cr-Commit-Position: refs/heads/master@{#312714}
(cherry picked from commit 09a730fac4fa5075faa85221161ee0b86150c2ae)
Review URL: https://codereview.chromium.org/875583003
Cr-Commit-Position: refs/branch-heads/2272@{#101}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
gpu: Allow virtual context for in-process gpu thread
Virtual context is turned on according to FeatureInfo::Workarounds.
Note that this doesn't work on Android WebView until crbug.com/450396
is fixed.
Review URL: https://codereview.chromium.org/828083005
Cr-Commit-Position: refs/heads/master@{#312308}
(cherry picked from commit d6552661356cafdc55df5e5d6abf378c9065c04c)
[email protected]
BUG=451528
Review URL: https://codereview.chromium.org/874483006
Cr-Commit-Position: refs/branch-heads/2272@{#100}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge 'Disable the new delayed load strategy for PersistentCookieStore.' to 2272.
> I recently introduced a change which caused SQLitePersistentCookieStore to load
> the cookies for one eTLD every 200ms, instead of every 0ms. That change
> appeared to cause a hang during shutdown.
>
> This CL changes the delay from 200ms back to 0ms while I investigate the hang.
>
> BUG=436152, 448910
>
> Review URL: https://codereview.chromium.org/844533005
>
> Cr-Commit-Position: refs/heads/master@{#312903}
BUG=436152, 448910
[email protected]
Review URL: https://codereview.chromium.org/869273005
Cr-Commit-Position: refs/branch-heads/2272@{#99}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Cache viewport rect for tile priority in UpdateTiles
PictureLayerImpls in a tree should continue using the same viewport rect
for tile priority until UpdateTiles() is called with the new value of
viewport rect for tile priority. Otherwise, a PictureLayerImpl could be
in an inconsistent state that could lead to a wrong decision about
AllTilesRequiredForActivationAreReadyToDraw.
This CL caches the viewport rect for tile priority in PictureLayerImpl.
BUG= 449008
Review URL: https://codereview.chromium.org/819643004
Cr-Commit-Position: refs/heads/master@{#312523}
(cherry picked from commit 9178c77a0167ee7c73364b21a6f3a633029b7a44)
Conflicts:
cc/layers/picture_layer_impl.cc
Review URL: https://codereview.chromium.org/872793003
Cr-Commit-Position: refs/branch-heads/2272@{#98}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Don't overwrite Tab title if unnecessary
Messed up the logic slightly when refactoring the code. If a
native page exists, the title should always be the one belonging to the native page.
Original logic located here, in Tab.getTitle():
https://codereview.chromium.org/834723002
BUG=450997
TBR=newt
Review URL: https://codereview.chromium.org/871583004
Cr-Commit-Position: refs/heads/master@{#312698}
Review URL: https://codereview.chromium.org/867343002
Cr-Commit-Position: refs/branch-heads/2272@{#97}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incognito profiles should track their parent's default zoom levels.
This CL adds the necessary machinery to allow incognito profiles to
update their default zoom levels to match that of the parent profile.
BUG=448683
Review URL: https://codereview.chromium.org/858923002
(cherry picked from commit 6febb4ef7865fada055bcbcae8060df1af343a24)
Cr-Original-Commit-Position: refs/heads/master@{#312312}
Cr-Commit-Position: refs/branch-heads/2272@{#96}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge "cros: Partial revert text_defaults.css change."
> Revert the text_defaults.css change for login screens because
> text_default.css does not handle dynamic locale change.
>
> BUG=448987,303849
>
> Review URL: https://codereview.chromium.org/796493007
>
> Cr-Commit-Position: refs/heads/master@{#311949}
> (cherry picked from commit e15d93246056bfe27103f4988d773c059859993a)
[email protected]
Review URL: https://codereview.chromium.org/868053004
Cr-Commit-Position: refs/branch-heads/2272@{#95}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Android WebView] Provide an activity for displaying OSS licenses
The activity is invoked using android.settings.WEBVIEW_LICENSE intent.
Current implementation invokes system HtmlViewer passing it a content URI,
and implements a content provider for serving it.
The licenses file is stored inside the APK compressed, thus requiring
extraction into a temporary folder prior to serving.
The second attempt to land this. Unlike the previous one, does not
terminate project files generation and compilation if there are license
problems with third-party dirs (see the comment in webview_licenses.py).
BUG=448703
Review URL: https://codereview.chromium.org/860693002
Cr-Commit-Position: refs/heads/master@{#312135}
(cherry picked from commit 8d4fbd88af6461eed50ea0c6b49654c6933a3b0d)
Review URL: https://codereview.chromium.org/874473002
Cr-Commit-Position: refs/branch-heads/2272@{#94}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add piping of ShowUnhandledTapUIIfNeeded from Blink.
This change picks up notification from Blink that there was an unhandled tap
that may require some UI response, analyzes some signals, and conditionally
propagates it through Chrome.
The notification is done through a new interface: ContextualSearchClient
instead of using ContentViewClient. The methods in ContentViewClient
have been deprecated and will be removed soon.
Also update the ContentViewCore#onSelectionEvent position parameters
to use integer device pixels instead of float dips.
The associated Blink CL is 819563004.
This feature will be used by Contextual Search.
BUG=412642, 395128, 383502, 403001
Review URL: https://codereview.chromium.org/816953004
Cr-Commit-Position: refs/heads/master@{#311938}
(cherry picked from commit a070f3cec462c97e8e6945623432cd0f939856b8)
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/865403002
Cr-Commit-Position: refs/branch-heads/2272@{#93}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.29
Cr-Commit-Position: refs/branch-heads/2272@{#92}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Handle invalid sync item ordinals when adding OEM folders
Certain edge cases were exposing a lack of proper checking for validity when handling sync ordinals.
[email protected]
BUG=449618
Review URL: https://codereview.chromium.org/866483002
Cr-Commit-Position: refs/heads/master@{#312512}
(cherry picked from commit 109400d4b8009a055fb05b647fe58739741efd67)
Review URL: https://codereview.chromium.org/870643004
Cr-Commit-Position: refs/branch-heads/2272@{#91}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Increase the cache size of fontconfig queries.
As is described in http://crbug.com/440551#c28, the cache size
64 isn't big enough in ChromeOS, usually ChromeOS has fonts as much
as 100. Unsupported glyph can run out this cache with a single
character.
BUG=440551
[email protected], [email protected]
[email protected]
TEST=open data:text/html;charset=UTF8,<title>a%E2%9C%A8</title> and
see the slowness around drawing has gone.
Review URL: https://codereview.chromium.org/796623005
Cr-Commit-Position: refs/heads/master@{#311568}
(cherry picked from commit b18055e3d9b5b026c5c26b1650d38ef1eb4c97e6)
Review URL: https://codereview.chromium.org/866283002
Cr-Commit-Position: refs/branch-heads/2272@{#90}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Android] Fix a flicker in stopping Chrome
Currently, we draw a blank frame as we release resources in onStop().
This can be prevented if we hide the tab when the window gets hidden instead of
on activity stop.
BUG=434401
Review URL: https://codereview.chromium.org/843883002
Cr-Commit-Position: refs/heads/master@{#311809}
(cherry picked from commit e4b1990c9d49fd9734940fa863513ad43b82c6e7)
[email protected]
Review URL: https://codereview.chromium.org/860223002
Cr-Commit-Position: refs/branch-heads/2272@{#89}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Updating XTBs based on .GRDs from branch 2272
Cr-Commit-Position: refs/branch-heads/2272@{#88}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix ONC logic error
A bug in onc_translator_onc_to_shill.cc is triggering a DCHECK when
a property is set in a previously non-existent dictionary.
This is a trivial fix to code that is subtle but clearly incorrect
by inspection.
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/838043003
Cr-Commit-Position: refs/heads/master@{#311357}
(cherry picked from commit 4081b158bd2a8984e0ba3a6457998fd35c72e070)
Review URL: https://codereview.chromium.org/870793002
Cr-Commit-Position: refs/branch-heads/2272@{#87}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Don't freeze lock screen renderer
Freezing the lock screen renderer causes user-visible lag on resume.
Most often this results in keystrokes being dropped and can be an
annoyance. To deal with this have the RendererFreezer not freeze the
lock screen renderer, allowing it to be responsive immediately on
resume.
BUG=chrome-os-partner:35395
Review URL: https://codereview.chromium.org/862863002
Cr-Commit-Position: refs/heads/master@{#312496}
(cherry picked from commit d030c2a71609cb99e74dac7b93341d5ba8d9745e)
[email protected]
Review URL: https://codereview.chromium.org/866153002
Cr-Commit-Position: refs/branch-heads/2272@{#86}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Cast: Handle negative TimeTicks correctly in RTCP packet
RRTR in RTCP packets from the receiver contains timing information used
to reject old RTCP packets.
This NTP timestamp is translated to Chrome's internal TimeTicks object.
In the case when sender's NTP time is ahead of the receiver by a large
value, the TimeTicks value can be negative. This caused all RTCP packets
to be rejected.
This change fix this issue and added unit tests to cover this behavior.
BUG=447742
Review URL: https://codereview.chromium.org/860923002
TBR=hubbe
Cr-Commit-Position: refs/heads/master@{#312335}
(cherry picked from commit 402e5206669870c107b0d6813f09436670572e8e)
Review URL: https://codereview.chromium.org/869573006
Cr-Commit-Position: refs/branch-heads/2272@{#85}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Disable credit card scanning by default.
The flag --enable-credit-card-scan is now required for the credit card
scanning feature. The feature will be re-enabled when the scanning API
is more stable.
BUG=450731
Review URL: https://codereview.chromium.org/866473004
Cr-Commit-Position: refs/heads/master@{#312459}
(cherry picked from commit 27bd482c7dd2e4b0b795e86d6ddda624a6e4abc9)
Review URL: https://codereview.chromium.org/866943002
Cr-Commit-Position: refs/branch-heads/2272@{#84}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: [Ozone] Fix bezels
This CL fixes DriWindow::CanDispatchEvent() to dispatch events in the
touch screen bezel to the correct DriWindow. Events in the touch screen bezel
fall outside of the DriWindow's bounds.
BUG=450086
TEST=Manual, see bug
TBR=pkotwicz
Review URL: https://codereview.chromium.org/870683002
Cr-Commit-Position: refs/branch-heads/2272@{#83}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Revert "Use setProperties for IP Config."
This reverts commit d97aaeeea89b28d50f76fa394231594897549150.
[email protected]
BUG=448495
Review URL: https://codereview.chromium.org/864423003
Cr-Commit-Position: refs/branch-heads/2272@{#82}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
In the CryptoToken extension, don't allow register requests unless they come from the active tab of the focused window.
BUG=449626
[email protected],[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/871523002
Cr-Commit-Position: refs/branch-heads/2272@{#81}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix bug where Settings showed the wrong search engine.
The search engine preference wasn't being updated correctly after the
user changed their search engine due to a bug on older versions of
Android. This adds a workaround for that bug.
BUG=446137
Review URL: https://codereview.chromium.org/859173002
Cr-Commit-Position: refs/heads/master@{#312439}
(cherry picked from commit 9e614a242c34f7605b6068f05f247f07c1ec4dda)
Review URL: https://codereview.chromium.org/871533002
Cr-Commit-Position: refs/branch-heads/2272@{#80}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
The User Manager needs to use profile paths not display names for profile switching
Since profiles can have duplicate names now, the profile path is the only thing that
distinguishes profiles.
Also did some cleanup of const refs.
BUG=448347
[email protected]
TEST=Start Chrome with --enable-new-avatar-menu. Create two profiles with the same
name. You should have no problems switching between the two in the "Switch Person"
overlay.
Review URL: https://codereview.chromium.org/840673004
Cr-Commit-Position: refs/heads/master@{#312139}
(cherry picked from commit e06afd04e8b516f5b5856a706e4b6acf05a2212c)
Review URL: https://codereview.chromium.org/867673002
Cr-Commit-Position: refs/branch-heads/2272@{#79}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Gallery: Prevent from cropping if the aspect ratio button is focused.
Previously if a user push Enter key with focus of the aspect ratio buttons,
cropping is done before changing the aspect ratio, and it causes an exception.
BUG=449455
TEST=None
[email protected]
Review URL: https://codereview.chromium.org/859333002
Cr-Commit-Position: refs/heads/master@{#312504}
(cherry picked from commit a141a6f6ec54e486673891d5406e7ea3cfb48999)
Review URL: https://codereview.chromium.org/871453003
Cr-Commit-Position: refs/branch-heads/2272@{#78}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Ensure proper generation of SSLVersion*Min in cloud_policy.proto.
Work around a grit bug when supported_on ranges specify an end-version by removing the end-version. This is only for landing on M41 branch because it would cause a documentation regression if applied to master.
BUG=450869
[email protected]
Review URL: https://codereview.chromium.org/870623002
Cr-Commit-Position: refs/branch-heads/2272@{#77}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Stop calling AppListFolderView's methods while destructing AppsGridView
Invalidate AppsGridView::folder_delegate_ in ~AppListFolderView()
so that AppsGridView doesn't try to call AppListFolderView's methods during its destruction.
BUG=449973
[email protected]
Review URL: https://codereview.chromium.org/861603002
Cr-Commit-Position: refs/heads/master@{#312162}
(cherry picked from commit 32cbfaa6478f66b93b6d383a58f606960e02441e)
Review URL: https://codereview.chromium.org/869553002
Cr-Commit-Position: refs/branch-heads/2272@{#76}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[WebView] Fix possible stack overflow when exiting fullscreen.
BUG=448032
Review URL: https://codereview.chromium.org/809073008
Cr-Commit-Position: refs/heads/master@{#311050}
(cherry picked from commit de81adf0a1dcca10a26ada9b2509637232cee5ef)
Review URL: https://codereview.chromium.org/868633002
Cr-Commit-Position: refs/branch-heads/2272@{#75}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Restrict registration requests in the CryptoToken extension to coming from the top-level origin only. Don't use the infobar in that case.
BUG=447824
[email protected],[email protected]
Review URL: https://codereview.chromium.org/845083003
Cr-Commit-Position: refs/heads/master@{#310963}
NOTRY=true
Review URL: https://codereview.chromium.org/863003002
Cr-Commit-Position: refs/branch-heads/2272@{#74}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.28
Cr-Commit-Position: refs/branch-heads/2272@{#73}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge fix shortcut creation via Create Application Shortcuts... command.
Some changes related to the new bookmarks app flow, which always creates
an extension, assumed there would always be an extension. This isn't
true for the old application shortcuts (which are currently enabled by
default).
BUG=449412
TBR=jackhou
Review URL: https://codereview.chromium.org/853563006
Cr-Commit-Position: refs/heads/master@{#312164}
(cherry picked from commit 863dc8b59882bf44a1a9da361334cda7efb5a0c0)
Review URL: https://codereview.chromium.org/862253002
Cr-Commit-Position: refs/branch-heads/2272@{#72}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
V4L2SVDA: Pass coded size from decoder and honor size adjusted by the driver.
For VP8, as opposed to H264, the picture size in stream is not given
aligned to macroblocks. Align to macroblocks in the decoder instead of
relying on the driver to align, but also honor the size adjusted by the
driver as long as it is contains the size we requested.
BUG=chrome-os-partner:35459
TEST=non-macroblock-aligned vp8 playback, vdatest
Review URL: https://codereview.chromium.org/852273003
Cr-Commit-Position: refs/heads/master@{#312099}
(cherry picked from commit e970a884cce7faf59f67e104cf40da61513c2598)
Review URL: https://codereview.chromium.org/862013002
Cr-Commit-Position: refs/branch-heads/2272@{#71}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.27
Cr-Commit-Position: refs/branch-heads/2272@{#70}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Updating XTBs based on .GRDs from branch 2272
Cr-Commit-Position: refs/branch-heads/2272@{#69}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.26
Cr-Commit-Position: refs/branch-heads/2272@{#68}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.25
Cr-Commit-Position: refs/branch-heads/2272@{#67}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Setting version to 41.0.2272.24
Cr-Commit-Position: refs/branch-heads/2272@{#66}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.14
Cr-Commit-Position: refs/branch-heads/2272@{#65}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add support for resetting pan and tilt on Logitech webcams.
BUG=447440
Review URL: https://codereview.chromium.org/830673005
Cr-Commit-Position: refs/heads/master@{#311454}
(cherry picked from commit 8ac831dc77372d713059ff92e45bfd392c8b68cc)
Review URL: https://codereview.chromium.org/863803002
Cr-Commit-Position: refs/branch-heads/2272@{#64}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix dangling pointer in OpenSSL NPN fallback.
A copy assignment to |std::string proto| copies data, then |*out| takes its
address, and |proto| goes out of scope, freeing |**out|. This CL replaces that
with a |const char*|, so that |*out| would point to the literal |char[]| defined
in NextProtoToString.
BUG=448428
Review URL: https://codereview.chromium.org/849243003
Cr-Commit-Position: refs/heads/master@{#311732}
(cherry picked from commit 67da3deddd2d80b66310307620d7891a440ae2ce)
[email protected]
Review URL: https://codereview.chromium.org/862753002
Cr-Commit-Position: refs/branch-heads/2272@{#63}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Android] Fix not showing bookmarks under "All items" when not signed in
On Enhanced bookmark mode, there was no bookmark shown under
"All bookmarks" even if user has bookmarks under "Uncategorized", when
user is not signed in.
The reason was that |BookmarksBridge#IsFolderAvailable| filtered out
desktop and others nodes if it's not signed in because we wanted to hide
them for the old bookmark UI.
Anyways, |BookmarksBridge#IsFolderAvailable| is not so relavent at
|BookmarksBridge::GetAllBookmarkIDsOrderedByCreationDate|'s context so
just remove it.
BUG=447360
Review URL: https://codereview.chromium.org/824913003
Cr-Commit-Position: refs/heads/master@{#311134}
(cherry picked from commit a61b5487a760254cb4df9d7acfc71f8cafe2e824)
[email protected]
Review URL: https://codereview.chromium.org/854393003
Cr-Commit-Position: refs/branch-heads/2272@{#62}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[Merge M41] Dispatch mouse wheel events as a result of kGestureTypeScroll if the event was generated by a mouse.
This makes "Ctrl + Mouse wheel" zoom the page on ozone as a side effect.
BUG=450067
TEST=Manual, see bug
TBR=pkotwicz
Review URL: https://codereview.chromium.org/863753002
Cr-Commit-Position: refs/branch-heads/2272@{#61}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Fix bug where UrlBar is focused when entering Reader Mode.
This fixes a bug where entering Reader Mode would cause the URL bar to
gain focus. The problem was that, starting in
https://crrev.com/821393004, Tab.destroyContentViewCore() was removing
the ContentView from the view hierarchy. This caused focus to go
immediately to the URL bar.
BUG=447203
Review URL: https://codereview.chromium.org/833403004
Cr-Commit-Position: refs/heads/master@{#311620}
(cherry picked from commit 7c0fea86f434f4cd1706ff6cc3cbfee709083d5b)
Review URL: https://codereview.chromium.org/862733002
Cr-Commit-Position: refs/branch-heads/2272@{#60}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
[SuggestionsService] Add Variations check for enabling the service
No longer by default for M41.
BUG=450035
TBR=mgiuca
Review URL: https://codereview.chromium.org/855973002
(cherry picked from commit 25cc193f2c398442782e28d105d0cebfa4b89017)
Cr-Original-Commit-Position: refs/heads/master@{#312153}
Cr-Commit-Position: refs/branch-heads/2272@{#59}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Add UMA for TouchToFirstScrollUpdateSwap
TouchToScrollUpdateSwap is currently tracked in UMA. While this is
useful for gauging the typical response time for each event in a scroll
sequence, it is insufficient to indicate the intial scroll response
time. Add a TouchToFirstScrollUpdateSwap which measures the time between
touch event creation for the first GestureScrollUpdate in a sequence and
the frame swap time caused by that first scroll event.
Also remove INPUT_EVENT_LATENCY_SCROLL_UPDATE_RWH_COMPONENT as it is no
longer used on Aura.
BUG=436965
Review URL: https://codereview.chromium.org/827963005
Cr-Commit-Position: refs/heads/master@{#311928}
(cherry picked from commit bf3a626647d8813df8491b8c4babc4442940dadc)
Review URL: https://codereview.chromium.org/861783002
Cr-Commit-Position: refs/branch-heads/2272@{#58}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Patch to merge.
Cr-Commit-Position: refs/branch-heads/2272@{#57}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Skip direct map from apk check for Samsung Mega.
Avoid a warning from Samsung knox by skipping attempts to mmap
the apk file for UMA data. Instead return false, appropriate
since any attempt later to really map the file would similarly
trigger this knox warning.
BUG=448084
Review URL: https://codereview.chromium.org/857833002
Cr-Commit-Position: refs/heads/master@{#312138}
(cherry picked from commit fba86e9cdbf10b89e6b644dbf1451cd67fa53e4f)
[email protected]
Review URL: https://codereview.chromium.org/858983002
Cr-Commit-Position: refs/branch-heads/2272@{#56}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Adds UMA logs for IME switches.
The logs is required to answer this question:
How many times of switching IMEs per day for users that select more than 1 IMEs, in buckets of 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, ... 24, 25+.
BUG=367631, 448625
TEST=Verified on linux_chromeos.
Review URL: https://codereview.chromium.org/817273005
Cr-Commit-Position: refs/heads/master@{#310969}
(cherry picked from commit 1bc6242e8f94f2309ba3128654948aa6bfb4bd03)
Review URL: https://codereview.chromium.org/845233003
Cr-Commit-Position: refs/branch-heads/2272@{#55}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
chrome.identity API: Restrict gaia ID access
This restricts the availability of obfuscated GAIA ID
info (from chrome.identity.getProfileUserInfo) to apps
which specify the identity.email manifest permission.
BUG=415641
Review URL: https://codereview.chromium.org/784283006
Cr-Commit-Position: refs/heads/master@{#311570}
(cherry picked from commit d6084a9790eafe0ca4e980c0a3d10d05566bb383)
Review URL: https://codereview.chromium.org/855383004
Cr-Commit-Position: refs/branch-heads/2272@{#54}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Incrementing VERSION to 41.0.2272.13
Cr-Commit-Position: refs/branch-heads/2272@{#53}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Merge: [Ozone] Fixes the "browser back" key on external keyboards
Fixes the DomCode -> KeyboardCode conversion for DomCode::BROWSER_BACK.
BUG=449741
TEST=Manual, see bug
TBR=pkotwicz
Review URL: https://codereview.chromium.org/820073008
Cr-Commit-Position: refs/branch-heads/2272@{#52}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
Cherry pick into M41 commit e10a825e60bf64c494acc37ebf66868309d86062
"Original CL description:
Remove thread jumping from the geolocation permission context.
This fixes a crash in the browser when the context is freed before from the
callback.
We used to jump to the blocking pool to avoid strict mode violation on startup
but the code has been refactored since then and we no longer hit such strict mode violation.
"
BUG=447282
Review URL: https://codereview.chromium.org/836963004
Cr-Commit-Position: refs/branch-heads/2272@{#51}
Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958}
