Publish DEPS for Chromium 39.0.2145.0
Automated Commit: Committing new LKGM version 6225.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#293090}
[Telemetry] Add option to output Chart JSON summary.
This CL adds an option --chartjson to the test runner to automatically perform
summarization to the specialized Chart JSON format that the perf dashboard has
been modified to accept. Passing --chartjson is mutually exclusive with the --output-formatter
option.
Review URL: https://codereview.chromium.org/531973002
Cr-Commit-Position: refs/heads/master@{#293089}
Blink roll c2d2210:19b5426
https://chromium.googlesource.com/chromium/blink/+log/c2d22105d9f5430670072c9f31712e1eaca8d86b..19b54260b70e697c0dc31e29206cc564d1fbf114
[email protected],[email protected]
Review URL: https://codereview.chromium.org/530343004
Cr-Commit-Position: refs/heads/master@{#293088}
Tweak some DVLOGs in media code.
As a follow up to 792fb3d, brings VideoRendererImpl in
line with AudioRendererImpl and also increases the DVLOG
level for the high-frequency CurrentMediaTime() function.
TBR=xhwang
Review URL: https://codereview.chromium.org/529333002
Cr-Commit-Position: refs/heads/master@{#293087}
Move the warning banner of local disk shortage to the upper side.
BUG=409731,391703
TEST=manually
Review URL: https://codereview.chromium.org/531403002
Cr-Commit-Position: refs/heads/master@{#293086}
Update V8 to version 3.29.38 (based on bleeding_edge revision r23585).
[email protected]
Review URL: https://codereview.chromium.org/526363002
Cr-Commit-Position: refs/heads/master@{#293085}
Skia roll 294739b:937c9c7
https://skia.googlesource.com/skia/+log/294739b848c7103afa92390855175dd0bd1cc2d8..937c9c7eb4e06d4d3bc495e129c7b8103a5d6c0f
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/531393002
Cr-Commit-Position: refs/heads/master@{#293084}
ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean
1. [Blink] https://codereview.chromium.org/515083002/
2. [Chromium] This patch
3. [Blink] https://codereview.chromium.org/512163002/
4. [Chromium] https://codereview.chromium.org/509283003/
BUG=390894
TEST=N/A
Review URL: https://codereview.chromium.org/516823003
Cr-Commit-Position: refs/heads/master@{#293083}
Add truncation to StreamCopyOrMoveImpl and test case.
BUG=410126
TEST=content_unittests
Review URL: https://codereview.chromium.org/536453007
Cr-Commit-Position: refs/heads/master@{#293082}
Adds conversion rule for WebAXRoleFigure
The Related CL:
https://codereview.chromium.org/515843002/
BUG=282040
Review URL: https://codereview.chromium.org/512603003
Cr-Commit-Position: refs/heads/master@{#293081}
mac, yosemite: Resize button causes fullscreen effect.
In Yosemite, no views can be in front of the traffic lights controls. Move the
content view and the tab strip view to the back of the NSThemeFrame.
BUG=408094
Review URL: https://codereview.chromium.org/520733004
Cr-Commit-Position: refs/heads/master@{#293080}
Revert of Replace NPObject usage in ppapi with gin (patchset #28 id:540001 of https://codereview.chromium.org/459553003/)
Reason for revert:
Causing a bunch of top crashes:
go/crash/c383c0c43c093ea1
go/crash/576a27ecf5f32094
go/crash/08fc74881d1819ac
go/crash/a6a00150ba55c0bf
Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e06bc5d896e494b9ec556f0e89dcc523778a1432
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=351636
Review URL: https://codereview.chromium.org/537483002
Cr-Commit-Position: refs/heads/master@{#293079}
Changing the order of weak_ptr_factory in src/ui module, to ensure proper cleanup while object is inactive.
BUG=303818
Review URL: https://codereview.chromium.org/533553002
Cr-Commit-Position: refs/heads/master@{#293078}
easy-unlock: Enable hardlock in states other than AUTHENTICATED
BUG=410111
Review URL: https://codereview.chromium.org/534073003
Cr-Commit-Position: refs/heads/master@{#293077}
Add myself to authors list.
BUG=N/A
Review URL: https://codereview.chromium.org/536763002
Cr-Commit-Position: refs/heads/master@{#293076}
ozone: Add UiThreadGpu for applications that do UI thread GL
The demo does GL on the main thread, which broken since we now depend on
GpuPlatformSupport(Host). Let's deliver these messages directly via a
helper class for those applications.
BUG=409978
TEST=ozone_demo --ozone-platform=gbm on link_freon
NOTRY=true
Review URL: https://codereview.chromium.org/533803003
Cr-Commit-Position: refs/heads/master@{#293075}
Adds hotwording assets and basic opt-in flow to the Hotword Audio Verification app.
BUG=390086
Review URL: https://codereview.chromium.org/521483003
Cr-Commit-Position: refs/heads/master@{#293074}
Use author name and email-id instead of committer information.
BUG=410064
NOTRY=true
Review URL: https://codereview.chromium.org/530213003
Cr-Commit-Position: refs/heads/master@{#293073}
RenderText: Always invalidate layout on style changes and never on color changes
BUG=386749
R=msw
Review URL: https://codereview.chromium.org/522103002
Cr-Commit-Position: refs/heads/master@{#293072}
Blink roll b11cd8b:c2d2210
https://chromium.googlesource.com/chromium/blink/+log/b11cd8b47a088b4da9aca6bfb590075ac4833068..c2d22105d9f5430670072c9f31712e1eaca8d86b
[email protected],[email protected]
Review URL: https://codereview.chromium.org/534913002
Cr-Commit-Position: refs/heads/master@{#293071}
Fix link error when use_ozone=1 and use_aura=1
When use_ozone=1 and use_aura=1, it will produce the following link error:
obj/ui/views/widget/desktop_aura/views.desktop_native_widget_aura.o: In function
`views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&)':
desktop_native_widget_aura.cc: undefined reference to `views::DesktopCursorLoaderUpdater::Create()'
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/510233002
Cr-Commit-Position: refs/heads/master@{#293070}
Add --max-failures command line argument to override that in PageTest.
Needed to try to reproduce intermittent failures on tryservers.
BUG=407976
Review URL: https://codereview.chromium.org/535743002
Cr-Commit-Position: refs/heads/master@{#293069}
XMPP implementation in JavaScript.
This adds XMPP implementation that will be used for signaling in the
webapp instead of WCS. It depends on TLS support added in the TCP API
in Chrome 38.
BUG=274652
Review URL: https://codereview.chromium.org/514343002
Cr-Commit-Position: refs/heads/master@{#293068}
Allow web url https://www.google.com/chrome/devices/goodies.html
BUG=chromium:406628
TEST=manual on daisy
Review URL: https://codereview.chromium.org/512323003
Cr-Commit-Position: refs/heads/master@{#293067}
Experimental app list: Remove start page button.
We're experimenting with a minimal UI and there is no real need to have
this button since you don't need to get back to the start page if you
find yourself on some other page.
BUG=406222
Review URL: https://codereview.chromium.org/527203002
Cr-Commit-Position: refs/heads/master@{#293066}
App-list history cleanup.
This CL centralizes the dependency to content, so that other files
can run independently.
BUG=380875
[email protected]
TEST=build
Review URL: https://codereview.chromium.org/518293002
Cr-Commit-Position: refs/heads/master@{#293065}
Move common VideoPacket initialization into VideoEncoderHelper.
This avoids duplication of common VideoPacket initialization across
multiple encoders, making addition of new fields (e.g. the recently
added shape field) more robust.
Review URL: https://codereview.chromium.org/530243002
Cr-Commit-Position: refs/heads/master@{#293064}
[fsp] Enable the File System Provider API on the dev channel.
The read-only version is pretty much done, so we should let developers use it
on the dev channel for initial feedback.
TEST=browser_tests: *FileSystemProvider*
BUG=248427
Review URL: https://codereview.chromium.org/531463002
Cr-Commit-Position: refs/heads/master@{#293063}
about_flags::ReportCustomFlags() should use signed 32-bit IDs.
On 32-bit architectures UMA Histogram IDs (enum
LoginCustomFlags) are negative. So HistogramBase::Sample
(which is int32_t) should be used.
BUG=408196
TEST=manual
Review URL: https://codereview.chromium.org/509923003
Cr-Commit-Position: refs/heads/master@{#293062}
webkit: Remove canary-webkit-revisions.py script.
Looks like nobody is using this script? Checked in Chromium, Blink and
Buildbot repos.
BUG=338338
TEST=None
[email protected],[email protected]
Review URL: https://codereview.chromium.org/520373002
Cr-Commit-Position: refs/heads/master@{#293061}
Extend the hang monitor timeout when an event ack is received.
The hang monitor is supposed to wait for 30 seconds of inactivity before
deciding that a renderer is not responsive. This CL makes sure that when
waiting for multiple input events, receiving an ack is correctly interpreted
as a responsive renderer (for that moment)
BUG=336198
Review URL: https://codereview.chromium.org/535653002
Cr-Commit-Position: refs/heads/master@{#293060}
Revert of Convert chrome_unscaled_resources to use a qualified path. (patchset #1 id:1 of https://codereview.chromium.org/534013002/)
Reason for revert:
Linux_x64 says: ninja: error: 'gen/chrome/chrome_unscaled_resources.pak', needed by 'gen/repack/resources.pak', missing and no known rule to make it
Original issue's description:
> Convert chrome_unscaled_resources to use a qualified path.
>
> BUG=401588
>
> Committed: https://chromium.googlesource.com/chromium/src/+/01ac77c0ca2f552d4ff44d5f16dad8844eccd516
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=401588
Review URL: https://codereview.chromium.org/533013002
Cr-Commit-Position: refs/heads/master@{#293059}
Add description for ServiceWorker.ScriptSize histogram
Blink-side change: https://codereview.chromium.org/524553002/
BUG=408451
Review URL: https://codereview.chromium.org/525733004
Cr-Commit-Position: refs/heads/master@{#293058}
mojo: Fix the key code for EXECUTE.
BUG=none
Review URL: https://codereview.chromium.org/529163002
Cr-Commit-Position: refs/heads/master@{#293057}
Use shark requisition instead of command line parameter
BUG=None
Review URL: https://codereview.chromium.org/524903003
Cr-Commit-Position: refs/heads/master@{#293056}
Condense RootView::DispatchGestureEvent() to a single loop
Remove the unnecessary code from RootView::DispatchGestureEvent()
by condensing it to a single loop and moving parts of
the implementation into RootView::PreDispatchEvent() and
RootView::PostDispatchEvent().
BUG=404228
TEST=covered by existing unit tests
Review URL: https://codereview.chromium.org/517023004
Cr-Commit-Position: refs/heads/master@{#293055}
Add [email protected] to remoting/OWNERS
[email protected]
Review URL: https://codereview.chromium.org/528123003
Cr-Commit-Position: refs/heads/master@{#293054}
<webview> cleanup: Change self = this to bind(this) in web_view.js
BUG=none
Review URL: https://codereview.chromium.org/530043002
Cr-Commit-Position: refs/heads/master@{#293053}
Convert chrome_unscaled_resources to use a qualified path.
BUG=401588
Review URL: https://codereview.chromium.org/534013002
Cr-Commit-Position: refs/heads/master@{#293052}
Docserver: Add extensionTypes to _api_features.json
Review URL: https://codereview.chromium.org/531973003
Cr-Commit-Position: refs/heads/master@{#293051}
Blink roll 5d18599:b11cd8b
https://chromium.googlesource.com/chromium/blink/+log/5d185994db600614dae243adfb09a7e191208e2a..b11cd8b47a088b4da9aca6bfb590075ac4833068
[email protected],[email protected]
Review URL: https://codereview.chromium.org/529193003
Cr-Commit-Position: refs/heads/master@{#293050}
Omnibox: Prevent Asynchronous Suggestions from Changing Default Match
This is a re-land of
https://codereview.chromium.org/471673002/
which was reverted because it caused a failure in
interactive_ui_tests
InstantExtendedPrefetchTest.SetPrefetchQuery (run #1):
[ RUN ] InstantExtendedPrefetchTest.SetPrefetchQuery
../../chrome/browser/ui/search/instant_extended_interactive_uitest.cc:867: Failure
Value of: SearchProvider::ShouldPrefetch(*( omnibox()->model()->result().default_match()))
Actual: false
Expected: true
[ FAILED ] InstantExtendedPrefetchTest.SetPrefetchQuery, where TypeParam = and GetParam() = (1613 ms)
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=12979
It has two changes:
- revises the failing tests
- does some requested cleanup of the unit tests
The original changelist description follows:
---
Calls to the suggest server may normally result in a new inline
autocompletion. This can be disruptive because it means pressing enter
may bring the user to different places depending on how long he/she
waits after typing the last key.
This change prevents new suggestions from becoming the default match.
In other words, the default match is only allowed to change on a
keystroke, not due to a reply coming back from the server.
The consequence of this change is that if previously we'd show an
inline suggestion on a server reply, now we only show it one keystroke
later. I think this trade-off (one keystroke versus inconsistent
omnibox behavior) is a good one to make.
We still end up with default matches (inline autocompletions within
the omnibox) from the suggest server after this change. Here's an
example of why:
User types "facebo"
We send a suggest server request.
Server asynchronously returns "facebook" as a top suggestion,
beating the server-provided verbatim score for "facebo".
We decide not to show it within the omnibox. It's instead shown
somewhere in the dropdown.
User types "o".
We send a suggest server request.
We reuse our cached suggestions and suggestion scores. <<< THE KEY
We show "facebook" as an inline suggestion because it beats
the default verbatim score that gets assigned to "faceboo".
(This is the score that we assign by default without having
yet received the most recent suggest server response.)
We receive the response, which includes "facebook" as a top
suggestion, beating the server-provided verbatim score
for "faceboo".
We show "facebook" as an inline suggestion. i.e., we decide
not to demote it because it was already being shown inline
TESTED:
unit tests plus interactive tests (facebook.com/l, google.com/a)
BUG=398135
Review URL: https://codereview.chromium.org/481693004
Cr-Commit-Position: refs/heads/master@{#293049}
Replace init_cb in Renderer::Initialize() with base::Closure.
BUG=392236
TEST=Existing tests pass.
Review URL: https://codereview.chromium.org/526653002
Cr-Commit-Position: refs/heads/master@{#293048}
NaCl: Update revision in DEPS, r13675 -> r13679
This pulls in the following Native Client changes:
r13676: (uekawa) Convert to use nacl_exception_* helpers instead of NACL_SYSCALL in tests.
r13677: (hidehiko) Support NONSFI translation on pnacl-ld.py.
r13678: (mseaborn) Use uint32_t for untrusted pointer args: nanosleep() syscall
r13679: (dschuff) Update revision for PNaCl r13658->r13673
BUG=none
[email protected]
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/533953002
Cr-Commit-Position: refs/heads/master@{#293047}
Add more logging to cc scheduler to debug RAF frame loss.
BUG=393331
TEST=bots
[email protected]
Review URL: https://codereview.chromium.org/533973002
Cr-Commit-Position: refs/heads/master@{#293046}
Add UMA to study the effect of defaulting fullscreen video to landscape mode
Added UMAs for:
1) The % of fullscreen video that is opened in portrait mode
2) The % of the video is suited for portrait mode
3) How long does a video play before user rotate the screen to landscape mode
4) How long video plays after user rotate the screen to landscape mode
5) How long does a video play before user rotate to portrait mode
6) The % of a video that the user switched from portrait to landscape mode
BUG=326572
Review URL: https://codereview.chromium.org/297773004
Cr-Commit-Position: refs/heads/master@{#293045}
Add support for file inputs for all guest views
Implement WebContentsDelegate::RunFileChooser in GuestViewBase
so that <input type=file> tags will work correctly within guest views.
BUG=409339
Review URL: https://codereview.chromium.org/531963002
Cr-Commit-Position: refs/heads/master@{#293044}
Remove windows.onCreated hack from Keep Awake extension.
The example extension for the chrome.power API registered a
listener for windows.onCreated to work around an issue where
runtime.onStartup didn't fire on Chrome OS. The underlying
Chrome bug has been fixed now, so the windows.onCreated
workaround is no longer needed.
BUG=222473
TEST=install the extension on Chrome OS and check that
/var/log/power_manager/powerd.LATEST reports an
extension-driven policy change when logging in
Review URL: https://codereview.chromium.org/531953002
Cr-Commit-Position: refs/heads/master@{#293043}
[Athena] Add status icons and system time to the centered home card
BUG=404156
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/483033003
Cr-Commit-Position: refs/heads/master@{#293042}
Roll gyp r1970:1972
r1972: Makes matching of build files work when absolute Matching wasn't
working if paths supplied were absolute.
r1971: Support for custom NM/readelf binaries in your toolchain.
BUG=109173
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/533993002
Cr-Commit-Position: refs/heads/master@{#293041}
Focus the first input when adding a new Autofill cc or address
in chrome://settings
It was mentioned that this was desirable behavior for desktop during the UX review for the linked bug.
BUG=407209
Review URL: https://codereview.chromium.org/516403003
Cr-Commit-Position: refs/heads/master@{#293040}
Add missing histogram description.
This histogram was renamed a while ago :(
BUG=336198
[email protected]
Review URL: https://codereview.chromium.org/531963003
Cr-Commit-Position: refs/heads/master@{#293039}
MacViews: Support continuous scrolling and horizontal scrolling
Add support for continuous devices (Magic Mouse and trackpad) using NSEvent
APIs introduced in 10.7.
Tweak ScrollView/ScrollBar to allow horizontal scrolling from MouseWheel
events.
BUG=363529
Review URL: https://codereview.chromium.org/456913002
Cr-Commit-Position: refs/heads/master@{#293038}
Skia roll 00f30bd:294739b
https://skia.googlesource.com/skia/+log/00f30bdc9e34b013da54b4406f36556c5be8d041..294739b848c7103afa92390855175dd0bd1cc2d8
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/531873004
Cr-Commit-Position: refs/heads/master@{#293037}
net: enable three Comodo roots for EV.
The change enables the following three root certificates for EV:
USERTrust RSA:
-----BEGIN CERTIFICATE-----
MIIF3jCCA8agAwIBAgIQAf1tMPyjylGoG7xkDjUDLTANBgkqhkiG9w0BAQwFADCB
iDELMAkGA1UEBhMCVVMxEzARBgNVBAgTCk5ldyBKZXJzZXkxFDASBgNVBAcTC0pl
cnNleSBDaXR5MR4wHAYDVQQKExVUaGUgVVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNV
BAMTJVVTRVJUcnVzdCBSU0EgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwHhcNMTAw
MjAxMDAwMDAwWhcNMzgwMTE4MjM1OTU5WjCBiDELMAkGA1UEBhMCVVMxEzARBgNV
BAgTCk5ldyBKZXJzZXkxFDASBgNVBAcTC0plcnNleSBDaXR5MR4wHAYDVQQKExVU
aGUgVVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNVBAMTJVVTRVJUcnVzdCBSU0EgQ2Vy
dGlmaWNhdGlvbiBBdXRob3JpdHkwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIK
AoICAQCAEmUXNg7D2wiz0KxXDXbtzSfTTK1Qg2HiqiBNCS1kCdzOiZ/MPans9s/B
3PHTsdZ7NygRK0faOca8Ohm0X6a9fZ2jY0K2dvKpOyuR+OJv0OwWIJAJPuLodMkY
tJHUYmTbf6MG8YgYapAiPLz+E/CHFHv25B+O1ORRxhFnRghRy4YUVD+8M/5+bJz/
Fp0YvVGONaanZshyZ9shZrHUm3gDwFA66Mzw3LyeTP6vBZY1H1dat//O+T23LLb2
VN3I5xI6Ta5MirdcmrS3ID3KfyI0rn47aGYBROcBTkZTmzNg95S+UzeQc0PzMsNT
79uq/nROacdrjGCT3sTHDN/hMq7MkztReJVni+49Vv4M0GkPGw/zJSZrM233bkf6
c0Plfg6lZrEpfDKEY1WJxA3Bk1QwGROs0303p+tdOmw1XNtB1xLaqUkL39iAigmT
Yo61Zs8liM2EuLE/pDkP2QKe6xJMlXzzawWpXhaDzLhn4ugTncxbgtNMs+1b/97l
c6wjOy0AvzVVdAlJ2ElYGn+SNuZRkg7zJn0cTRe8yexDJtC/QV9AqURE9JnnV4ee
UB9XVKg+/XRjL7FQZQnmWEIuQxpMtPAlR1n6BB6T1CZGSlCBst6+eLf8ZxXhyVeE
Hg9j1uliutZfVS7qXMYoCAQlObgOK6nyTJccBz8NUvXt7y+CDwIDAQABo0IwQDAd
BgNVHQ4EFgQUU3m/WqorSs9UgOHYm8Cd8rIDZsswDgYDVR0PAQH/BAQDAgEGMA8G
A1UdEwEB/wQFMAMBAf8wDQYJKoZIhvcNAQEMBQADggIBAFzUfA3P9wF9QZllDHPF
Up/L+M+ZBn8b2kMVn54CVVeWFPFSPCeHlCjtHzoBN6J2/FNQwISbxmtOuowhT6KO
VWKR82kV2LyI48SqC/3vqOlLVSoGIG1VeCkZ7l8wXEskEVX/JJpuXior7gtNn3/3
ATiUFJVDBwn7YKnuHKsSjKCaXqeYalltiz8I+8jRRa8YFWSQEg9zKC7F4iRO/Fjs
8PRF/iKz6y+O0tlFYQXBl2+odnKPi4w2r78NBc5xjeambx9spnFixdjQg3IM8WcR
iQycE0xyNN+81XHfqnHd4blsjDwSXWXavVcStkNr/+XeTWYRUc+ZruwXtuhxkYze
Sf7dNXGiFSeUHM9h4ya7b6NnJSFd5t0dCy5oGzuCr+yDZ4XUmFF0sbmZgIn/f3gZ
XHlKYC6SQK5MNyosycdiyA5d9zZbyuAlJQG03RoHnHcAP9Dc1ew91Pq7P8yF1m9/
qS3fuQL39ZeatTXaw2ewh0qpKJ4jjv9cJ2vhsE/zB+4ALtRZh8tSQZXq9EfX7mRB
VXyNWQKV3WKdwrnuWih0hKWbt5DHDAff9Yk2dDLWKMGwsAvgnEzDHNb842m1R0aB
L6KCq9NjRHDEjf8tM7qtj3u1cIiuPhnPQCjY/MiQu12ZIvVS5ljFH4gxQ+6IHdfG
jjxDah2nGN59PRbxYvnKkKj9
-----END CERTIFICATE-----
USERTrust ECC:
-----BEGIN CERTIFICATE-----
MIICjzCCAhWgAwIBAgIQXIuZxVqUxdJxVt7NiYDMJjAKBggqhkjOPQQDAzCBiDEL
MAkGA1UEBhMCVVMxEzARBgNVBAgTCk5ldyBKZXJzZXkxFDASBgNVBAcTC0plcnNl
eSBDaXR5MR4wHAYDVQQKExVUaGUgVVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNVBAMT
JVVTRVJUcnVzdCBFQ0MgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwHhcNMTAwMjAx
MDAwMDAwWhcNMzgwMTE4MjM1OTU5WjCBiDELMAkGA1UEBhMCVVMxEzARBgNVBAgT
Ck5ldyBKZXJzZXkxFDASBgNVBAcTC0plcnNleSBDaXR5MR4wHAYDVQQKExVUaGUg
VVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNVBAMTJVVTRVJUcnVzdCBFQ0MgQ2VydGlm
aWNhdGlvbiBBdXRob3JpdHkwdjAQBgcqhkjOPQIBBgUrgQQAIgNiAAQarFRaqflo
I+d61SRvU8Za2EurxtW20eZzca7dnNYMYf3boIkDuAUU7FfO7l0/4iGzzvfUinng
o4N+LZfQYcTxmdwlkWOrfzCjtHDix6EznPO/LlxTsV+zfTJ/ijTjeXmjQjBAMB0G
A1UdDgQWBBQ64QmG1M8ZwpZ2dEl23OA1xmNjmjAOBgNVHQ8BAf8EBAMCAQYwDwYD
VR0TAQH/BAUwAwEB/zAKBggqhkjOPQQDAwNoADBlAjA2Z6EWCNzklwBBHU6+4WMB
zzuqQhFkoJ2UOQIReVx7Hfpkue4WQrO/isIJxOzksU0CMQDpKmFHjFJKS04YcPbW
RNZu9YO6bVi9JNlWSOrvxKJGgYhqOkbRqZtNyWHa0V1Xahg=
-----END CERTIFICATE-----
COMODO RSA:
-----BEGIN CERTIFICATE-----
MIIF2DCCA8CgAwIBAgIQTKr5yttjb+Af907YWwOGnTANBgkqhkiG9w0BAQwFADCB
hTELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4G
A1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQxKzApBgNV
BAMTIkNPTU9ETyBSU0EgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwHhcNMTAwMTE5
MDAwMDAwWhcNMzgwMTE4MjM1OTU5WjCBhTELMAkGA1UEBhMCR0IxGzAZBgNVBAgT
EkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMR
Q09NT0RPIENBIExpbWl0ZWQxKzApBgNVBAMTIkNPTU9ETyBSU0EgQ2VydGlmaWNh
dGlvbiBBdXRob3JpdHkwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQCR
6FSS0gpWsawNJN3Fz0RndJkrN6N9I3AAcbxT38T6KhKPS38QVr2fcHK3YX/JSw8X
pz3jsARh7v8Rl8f0hj4K+j5c+ZPmNHrZFGvnnLOFoIJ6dq9xkNfs/Q36nGz637CC
9BR++b7Epi9Pf5l/tfxnQ3K9DADWietrLNPtj5gcFKt+5eNu/Nio5JIk2kNrYrhV
/erBvGy2i/MOjZrkm2xpmfh4SDBF1a3hDTxFYPwyllEnvGfDyi62a+pGx8cgoLEf
Zd5ICLqkTqnyg0Y3hOvozIFIQ2dOciqbXL1MGyiKXCJ7tKuY2e7gUYPDCUZObT6Z
+pUX2nwzV0E8jVHtC7ZcryxjGt9XyD+86V3Em69FmeKjWiS0uqlWPc9vqv9JWL7w
qP/0uK3pN/u6uPQLOvnoQ0IeidiEyxPx2bvhiWC4jChWrBQdnArncevPDt09qZah
SL0896+1DSJMwBGB7FY79tOi4lu3sgQiUpWAk2nojkxl8ZEDLXB0AuqLZxUpaVIC
u9ffUGpVRr+goyhhf3DQw6KqLCGqR84onAZFdr+CGCe01a60y1Dma/RMhnEw6abf
Fobg2P9A3fvQQoh/ozM6LlweQRGBY84YcWsr7KaKtzFcOmpH4MN5WdYgGq/yapiq
crxXStJLnbsQ/LBMQeXtHT1eKJ2czL+zUdqnR+WEUwIDAQABo0IwQDAdBgNVHQ4E
FgQUu69+Aj36pvE8hI6t7jiY7NkyMtQwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB
/wQFMAMBAf8wDQYJKoZIhvcNAQEMBQADggIBAArx1UaEt65Ru2yyTUEUAJNMnMvl
wFTPoCWOAvn9sKIN9SCYPBMtrFaisNZ+EZLpLrqeLppysb0ZRGxhNaKatBYSaVqM
4dc+pBroLwP0rmEdEBsqpIt6xf4FpuHA1sj+nq6PK7o9mfjYcwlYRm6mnPTXJ9OV
2jeDchzTc+CiR5kDOF3VSXkAKRzH7JsgHAckaVd4sjn8OoSgtZx8jb8uk2Intzna
FxiuvTwJaP+EmzzV1gsD41eeFPfR60/IvYcjt7ZJQ3mFXLrrkguhxuhoqEwWsRqZ
CuhTLJK7oQkYdQxlqHvLI7cawiiFwxv/0Cti76R7CZGYZ4wUAc1oBmpjIXUDgIiK
boHGhfKppC3n9KUkEEeDys30jXlYsQab5xoq2Z0B15R97QNKyvDb6KkBPvVWmcke
jkk9u+UJueBPSZI9FoJAzMxZxuY67RIuaTxslbH9qh17f4a+Hg4yRvv7E491f0yL
S0Zj/gA0QHDBw7mh3aZw4gSzQbzpgJHqZJx64SIDqZxubw5lT2yHh17zbqD5daWb
QOhTsiedSrnAdyGN/4fy3ryM7xfft0kL0fJuMAsaDk527RH89elWsn2/x20Kk4yl
0MC2Hb46TpSi125sC8KKfPog88Tk5c0NqMuRkrF8hey1FGlmDoLnzc7ILaZRfyHB
NVOFBkpdn627G190
-----END CERTIFICATE-----
BUG=231900
Review URL: https://codereview.chromium.org/520993002
Cr-Commit-Position: refs/heads/master@{#293036}
Support additional Yubico product IDs.
This feature is intended for launch with devices planned to be available
in the play store, and some of these devices were unintentially missed
from the 38 branch point.
BUG=409282
Review URL: https://codereview.chromium.org/535443002
Cr-Commit-Position: refs/heads/master@{#293035}
Roll ICU to 291774
See https://codereview.chromium.org/497543003
fast/encoding/api/ascii-supersets.html has to be rebaselined because
now that Shift_JIS acts as an ASCII superset.
See https://codereview.chromium.org/513413003/
BUG=277062,404445
TEST=Blink: fast/encoding/* all pass except for
fast/encoding/api/ascii-supersets.html that should fail by *passing*
the test for Shift_JIS, which is expected to fail. Blink layout tests needs
to be updated.
TEST=browser_tests --gtest_filter="*ncoding*"
TEST=In JS console, run the following to check if Europe/Moscow is
3 hrs ahead of UTC after Oct 26 and 4 hrs ahead before that and
if Asia/Kamchatka remains 12 hrs ahead of UTC.
nov1_2014_1500=new Date("11/01/2014 15:00Z")
nov1_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
nov1_2014_1500.toLocaleString("en", {timeZone: "UTC"})
nov1_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
oct24_2014_1500=new Date("10/24/2014 15:00Z")
oct24_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"})
oct24_2014_1500.toLocaleString("en", {timeZone: "UTC"})
oct24_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"})
TEST=net_unittest --gtest_filter="*ilenameUtil*"
TEST=base_unittests --gtest_filter="*Conv*"
[email protected], [email protected]
Review URL: https://codereview.chromium.org/528083002
Cr-Commit-Position: refs/heads/master@{#293034}
ozone: Remove CursorFactoryOzone::SetCursor, GetCursorWindow
Use PlatformWindow::SetCursor instead of CursorFactoryOzone::SetCursor.
The GetCursorWindow() function becomes an implementation detail of the
DRI platform.
BUG=none
TEST=compile, run on cros link_freon
NOTRY=true
Review URL: https://codereview.chromium.org/527293002
Cr-Commit-Position: refs/heads/master@{#293033}
Add more generic filters to the chrome.usb.getDevices API.
Instead of specifying each of the USB vendor and product ID pairs an
app has permission to open this API extension allows filtering of
devices by vendor and product IDs as well as USB interface classes, sub-
classes and protocols. The 'vendorId' and 'productId' properties of
EnumerateDevicesOptions are still supported for backwards compatibility.
BUG=
Review URL: https://codereview.chromium.org/517923002
Cr-Commit-Position: refs/heads/master@{#293032}
Makes sure telemetry test result report is one string (no interruption)
Otherwise there could be logging inserted between [ OK ] and the test name,
and the harness will fail to recognize the test is passing, raising false alarm.
BUG=409968
TEST=telemetry tests
[email protected],[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/530143002
Cr-Commit-Position: refs/heads/master@{#293031}
Landing Recent QUIC Changes.
Ensure the QuicConnection's writer is not write blocked before trying to
write another packet.
Fix for Chrome crash bug 409191.
Merge internal change: 74635422
BUG=409191
Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.
Merge internal change: 74239145
https://codereview.chromium.org/509203003/
Remove PacketType from QUIC because the QUEUED type is not used and the
other types can be reduced to a bool.
Merge internal change: 74148481
https://codereview.chromium.org/515003003/
Don't send a QUIC SCUP message until after handshake confirmed.
A server config update was occasionally being sent before the crypto
handshake was complete, causing the client to close the connection.
Merge internal change: 74132773
https://codereview.chromium.org/516713002/
Change TransmissionInfo's all_transmissions SequenceNumberSet* to
default to NULL, and only be present if there are multiple transmissions.
Estimated to save ~2% of CPU.
Merge internal change: 74076012
https://codereview.chromium.org/509073004/
Log the quic version for internal server tracing.
Not used in production.
Merge internal change: 74069715
https://codereview.chromium.org/514043002/
Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
deque.
Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
on tools/quic/end_to_end_test.cc.
Merge internal change: 74054196
https://codereview.chromium.org/514033002/
Unit test for empty packet closes QUIC connection bug.
Merge internal change: 74041239
https://codereview.chromium.org/495423011/
Log the QUIC transmission type in QUIC internal server trace visitor.
Not used in production.
Merge internal change: 73895739
https://codereview.chromium.org/514023002/
Not used in production. Log whether a QUIC packet sent was a crypto
packet or not for internal server side tracing.
Merge internal change: 73894063
https://codereview.chromium.org/515003002/
Fix a QUIC bug in which PING frames were not being ACK'd.
Merge internal change: 73837644
https://codereview.chromium.org/512933005/
[email protected]
Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949
Review URL: https://codereview.chromium.org/515303003
Cr-Commit-Position: refs/heads/master@{#293030}
Use WaitForDebuggerChildren to let renderer wait for gdb
BUG=378975
Review URL: https://codereview.chromium.org/508493003
Cr-Commit-Position: refs/heads/master@{#293029}
Revert of Add support for Java nano protocol buffers for Android. (patchset #4 id:60001 of https://codereview.chromium.org/511283003/)
Reason for revert:
Breaks some workflows and also should get new quota.
Original issue's description:
> Add support for Java nano protocol buffers for Android.
>
> This CL adds a new dependency on the protocol buffer compiler
> from the android source tree, since this compiler supports
> generating Java files using the nano runtime.
>
> The initial version of this dependency is 2.2.0a, but checked
> out as what the Android 4.4.4 Release 2.0.1 tag points to.
>
> This CL adds a new protoc binary (for compiling protos) that supports
> this, and also adds a Java library with the runtime.
>
> To simplify use of this, it also updates build/protoc_java.gypi to
> support generating nano protos by specifying an optional
> proto_runtime argument. The argument defaults to 'lite' which does
> the same thing as before this change, and setting it to 'nano'
> generates the new style Java files.
>
> The plan is to quickly deprecate the 'lite' runtime for Java, since
> it is too big and uses too many methods.
>
> BUG=377891
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d8ae0a79834531e41912de44b9e212ffa7eb2785
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=377891
Review URL: https://codereview.chromium.org/534703004
Cr-Commit-Position: refs/heads/master@{#293028}
Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric
Convert method.
Also added a ConvertTo<X> helper function.
Also changed it from class to struct, since every method was public.
BUG=406492
Review URL: https://codereview.chromium.org/507173003
Cr-Commit-Position: refs/heads/master@{#293027}
Fix wm_flow_app so that it uses MojoMain() directly.
[email protected]
BUG=none
Review URL: https://codereview.chromium.org/533933002
Cr-Commit-Position: refs/heads/master@{#293026}
net: add (www.)honeybadger.io to HSTS preload.
Cr-Commit-Position: refs/heads/master@{#293025}
Add a landmine for crbug.com/408192
[email protected]
Review URL: https://codereview.chromium.org/529183004
Cr-Commit-Position: refs/heads/master@{#293024}
Run athena on chrome
There are more work needs to be finished, but this should at least allow us to implement login UI
* Added chrome version of ExtensionsDelegate and AppActivity
* introduce use_athena gyp flag
* disabled features/code path that does not work yet on athena. Filed bugs to keep track of them.
BUG=397167
[email protected], [email protected]
Review URL: https://codereview.chromium.org/514293003
Cr-Commit-Position: refs/heads/master@{#293023}
Blacklist GPU rasterization on Nexus 10.
[email protected],[email protected]
BUG=407144
Review URL: https://codereview.chromium.org/536583002
Cr-Commit-Position: refs/heads/master@{#293022}
Enable linking Chrome in the GN build.
Review URL: https://codereview.chromium.org/532913002
Cr-Commit-Position: refs/heads/master@{#293021}
Add whitelisted permission for access to Universal 2nd Factor devices.
This permission allows an application to access any connected U2F device
(as identified by its HID Usage Page) through the chrome.hid API.
BUG=374307
Review URL: https://codereview.chromium.org/518963002
Cr-Commit-Position: refs/heads/master@{#293020}
Fix crash when using title drag on a window opened while split view is active.
This CL also centralizes setting the activity's bounds and transform while in
split view to SplitViewController::UpdateLayout(). In particular, the bounds of
an activity are now correct even if it is opened while some other activity is
animating into split view
BUG=405964
TEST=WindowManagerTest.NewWindowBounds
Review URL: https://codereview.chromium.org/513313003
Cr-Commit-Position: refs/heads/master@{#293019}
Enable forced extension updates on NaCl arch mismatch
This makes extensions aware of the platforms for which
they have platform-specific resources installed, if any.
This also hooks up the extension update code with some
additional logic to place an extension in forced-update
mode if it has platform-specific resources which don't
match the current NaCl architecture.
BUG=409948
TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed.
Review URL: https://codereview.chromium.org/516293007
Cr-Commit-Position: refs/heads/master@{#293018}
[Telemetry] Add recognition for OS X 10.10 Yosemite
BUG=409919
Review URL: https://codereview.chromium.org/533443003
Cr-Commit-Position: refs/heads/master@{#293017}
Move kWebstoreAppId constant to//extensions.
BUG=352293
Review URL: https://codereview.chromium.org/515563003
Cr-Commit-Position: refs/heads/master@{#293016}
[Android] Allow passing in extra intent flags for share menu item.
BUG=409104
b/17294369
NOTRY=true
Review URL: https://codereview.chromium.org/510023003
Cr-Commit-Position: refs/heads/master@{#293015}
ScopedPtrVector change back const_iterator typedef
Calling begin() const and end() const function in ScopedPtrVector has
compiler error with const_iterator. Change back from const T* to T*.
Also since cpplint complains has to change a reference to pointer.
Review URL: https://codereview.chromium.org/534743002
Cr-Commit-Position: refs/heads/master@{#293014}
Blink roll 07cfde2:5d18599
https://chromium.googlesource.com/chromium/blink/+log/07cfde2700209d53893a4f7be2b52a3a25355740..5d185994db600614dae243adfb09a7e191208e2a
[email protected],[email protected]
Review URL: https://codereview.chromium.org/527233004
Cr-Commit-Position: refs/heads/master@{#293013}
Instrumented libraries: build freetype again.
It was inadvertently disabled in r287058.
BUG=313751
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/528053003
Cr-Commit-Position: refs/heads/master@{#293012}
Add a histogram to log the size of an UMA upload.
This is better than the existing pair of histograms
UMA.ProtoCompressionRatio and UMA.ProtoGzippedKBSaved
which require manual calculation to get at the approx.
value.
BUG=409179
Review URL: https://codereview.chromium.org/523153002
Cr-Commit-Position: refs/heads/master@{#293011}
Adds plumbing for always requiring handshake confirmation in QUIC, for use in Finch field trials.
BUG=
Review URL: https://codereview.chromium.org/524463004
Cr-Commit-Position: refs/heads/master@{#293010}
[Android] Add missing @VisibleForTesting annotations.
Proguard strips these methods if they are not annotated because they
are only used in tests.
TBR=brettw
BUG=163393
Review URL: https://codereview.chromium.org/528963003
Cr-Commit-Position: refs/heads/master@{#293009}
Remove DistilledPageInfo and related structs.
The DistilledPageInfo and related structs are unnecessary, and it is possible
to pass the DomDistillerResult proto around instead. Currently they contain the
same data, and it is all just copied over.
Removing this intermediate step simplifies the code and makes it easier to add
more data to the DomDistillerResult proto and passing it through to
DistilledPageProto.
BUG=409274
Review URL: https://codereview.chromium.org/493853006
Cr-Commit-Position: refs/heads/master@{#293008}
bisect-builds.py: Fix broken chromium changelog URL to new URL.
BUG=None
NOTRY=True
Review URL: https://codereview.chromium.org/521993002
Cr-Commit-Position: refs/heads/master@{#293007}
Add ability to pass decryption key id to CreateSecureMessage method
This should enable the message receiver to identify a key to be used for
message decryption.
BUG=409099
(depends on https://codereview.chromium.org/513013003/)
Review URL: https://codereview.chromium.org/518643002
Cr-Commit-Position: refs/heads/master@{#293006}
Skia roll 98d709b:00f30bd
https://skia.googlesource.com/skia/+log/98d709bc8d0761df8e0ad35e92c06e500f0be50d..00f30bdc9e34b013da54b4406f36556c5be8d041
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/528023002
Cr-Commit-Position: refs/heads/master@{#293005}
Add some more libjingle targets to the GN build.
Add usrsctp. Make Windows version configurable for this in the build.
direct_dependent_configs for libsrtp.
[email protected]
Review URL: https://codereview.chromium.org/534713003
Cr-Commit-Position: refs/heads/master@{#293004}
Revert of Add LatencyInfo support for Surfaces. (patchset #3 id:40001 of https://codereview.chromium.org/511423004/)
Reason for revert:
Failed compile here: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/12959/steps/compile/logs/stdio
Original issue's description:
> Add LatencyInfo support for Surfaces.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/30ea8cb30b9e0d6fcd037bc434b29bac41196e5e
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/533913003
Cr-Commit-Position: refs/heads/master@{#293003}
Go away on odd push and already seen push stream ids
BUG=377538
[email protected]
TEST=SpdyNetworkTransactionTest.GoAwayOnPushStreamIdLesserOrEqualThanLastAccepted
SpdyNetworkTransactionTest.GoAwayOnOddPushStreamId
Review URL: https://codereview.chromium.org/511283005
Cr-Commit-Position: refs/heads/master@{#293002}
cc: Decrease transfer buffer memory limit to a single frame of uploads.
This memory limit is a lowest-common-denominator type value that should
work for more-or-less all platforms. Currently this value causes
impl-side painting to increase the size of the renderer process resident
memory, which is causing memory regressions on the perf bots.
But, having enough memory for 2 frames seems excessive as the baseline
since in the common case we need to upload resources for the next
compositor deadline that will be presented at the next vsync. So, remove
the 2x multiplier from this constant value.
R=reveman
BUG=407193
Review URL: https://codereview.chromium.org/522023002
Cr-Commit-Position: refs/heads/master@{#293001}
Remove ShellPtrWatcher details from public header
BUG=
Review URL: https://codereview.chromium.org/535543002
Cr-Commit-Position: refs/heads/master@{#293000}
binarysize tool: Cleaning up some progress output.
R=primiano
BUG=
Review URL: https://codereview.chromium.org/399683004
Cr-Commit-Position: refs/heads/master@{#292999}
Add LatencyInfo support for Surfaces.
BUG=
Review URL: https://codereview.chromium.org/511423004
Cr-Commit-Position: refs/heads/master@{#292998}
Allow key events to continue propagation for commands without any event listeners.
Rather than complicating the API with proposals of key re injection, or runtime registration/deregistration (which we might want for other reasons in the future), here's a very simple change that would probably give us the same functionality. If an extension remove all chrome.commands.onCommand listeners, then they will no longer receive the onCommand event and thereafter, the browser should continue propagating the key event and not drop it. I think this is actually the correct behavior, but also allows extension authors to have a little more control over when a command should be processed.
BUG=407163
Review URL: https://codereview.chromium.org/504183004
Cr-Commit-Position: refs/heads/master@{#292997}
athena: Change the load progress color to #1759CD.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/535593002
Cr-Commit-Position: refs/heads/master@{#292996}
MediaGalleriesGalleryWatchApiTest: Enable tests that were disabled.
They should no longer be flaky/crashing because the underlying watch manager is
new, shiny, and more stable.
BUG=390979
Review URL: https://codereview.chromium.org/530703003
Cr-Commit-Position: refs/heads/master@{#292995}
Docserver: Add @Cache annotation to CompiledFileSystem
This is the first in a series of CLs intended to reduce the amount of caching
in docserver code. The @Cache annotation is used to indicate that compiled data
should be cached in CompiledFileSystem.
NOTRY=True
Review URL: https://codereview.chromium.org/521693003
Cr-Commit-Position: refs/heads/master@{#292994}
Add UMA histogram to count hard revokes of user certificate error decisions.
In https://codereview.chromium.org/473643002/ we added a button for users in the
"Remember Certificate Error Decisions" experiment to allow them to revoke their
decision to bypass an SSL error for a given host. This commit adds an UMA
histogram to count how often a hard revoke actually occurs.
BUG=262615
[email protected]
Review URL: https://codereview.chromium.org/476513002
Cr-Commit-Position: refs/heads/master@{#292993}
[Android] Always request BeginFrame when touch received
Android's vsync listener will now only dispatch a BeginFrame message if
such was requested. This exposed a hole in our BeginFrame request
pipeline, where short-circuited touch forwarding would bypass the vsync
request. Instead, always request the BeginFrame if a touch event was
received from the platform, potentially reducing the first frame's
latency when the page lacks a touch handler.
latency.
BUG=408377
Review URL: https://codereview.chromium.org/535453002
Cr-Commit-Position: refs/heads/master@{#292992}
Fixes compile error
Without this I get compile errors in motion_event_web.cc because M_PI
is undeclared.
BUG=409940
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/533863002
Cr-Commit-Position: refs/heads/master@{#292991}
Move basic string operations to ui/app_list/search
BUG=380875
[email protected]
TEST=build succeeds
Review URL: https://codereview.chromium.org/522683003
Cr-Commit-Position: refs/heads/master@{#292990}
PERF SHERIFF: This CL changes the tough_energy_cases test.
Recorded additional tough_energy_cases.
Moved all test cases to codepen, so they're easy to edit and all http.
BUG= 386152
Review URL: https://codereview.chromium.org/506063002
Cr-Commit-Position: refs/heads/master@{#292989}
Use IsRenderViewLive() to test for SadTab in ZoomController.
In a previous attempt to prevent SadTab pages from being zoomable we
attempted to use RenderProcessHost::HasConnection, but this fails in
the case where a new tab can be started in the same RenderProcessHost
while the SadTab is still visible. This CL switches to testing to see
if the RenderView for the tab in question is live in order to avoid
this problem.
BUG=407562
Review URL: https://codereview.chromium.org/529993002
Cr-Commit-Position: refs/heads/master@{#292988}
Fix reference to apps/manifest/bluetooth API
NOTRY=True
Review URL: https://codereview.chromium.org/509253003
Cr-Commit-Position: refs/heads/master@{#292987}
Enable castv2 perf tests again
.. and switch evil network profile for bad network profile
BUG=356842
Review URL: https://codereview.chromium.org/511393007
Cr-Commit-Position: refs/heads/master@{#292986}
[Findit] Fix threading.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/525433003
Cr-Commit-Position: refs/heads/master@{#292985}
Remove NPAPI from DEPS.
Review URL: https://codereview.chromium.org/530523002
Cr-Commit-Position: refs/heads/master@{#292984}
Only target ui::ET_GESTURE_END to the default gesture handler
If no gesture handler has been established prior to RootView
receiving a ui::ET_GESTURE_END event, do not perform any
targeting based on the event's location (and therefore do not
dispatch this event to any view); GESTURE_END should only
ever be targeted and dispatched to the gesture handler set
by a previous gesture.
BUG=409918
TEST=ViewTargeterTest.ViewTargeterForGestureEvents,
WidgetTest.GestureBeginAndEndEvents,
WidgetTest.DisabledGestureEventTarget
Review URL: https://codereview.chromium.org/533793002
Cr-Commit-Position: refs/heads/master@{#292983}
Further cleanup of RenderText
Remove redundant data member and include.
Followup after https://codereview.chromium.org/493363006
BUG=388084
Review URL: https://codereview.chromium.org/527103003
Cr-Commit-Position: refs/heads/master@{#292982}
Revert "[Sync] Move DataTypeStatusTable ownership into DataTypeManager."
This reverts commit fe2ae5fbf23243039bdc94f8f8672bc371f5339f.
BUG=368834,409965
TBR=zea,scottmg
Review URL: https://codereview.chromium.org/534733002
Cr-Commit-Position: refs/heads/master@{#292981}
Remove network_prediction_enabled from profile_io_data.
Cleanup: This member has been obsoleted by https://crrev.com/516443002.
BUG=334602
Review URL: https://codereview.chromium.org/520613004
Cr-Commit-Position: refs/heads/master@{#292980}
Minor fixes for the GN Windows build.
[email protected]
Review URL: https://codereview.chromium.org/533853002
Cr-Commit-Position: refs/heads/master@{#292979}
Fix Chrome linker errors in GN build.
This fixes all non-RTC-related linker errors for Chrome.
[email protected]
Review URL: https://codereview.chromium.org/533743004
Cr-Commit-Position: refs/heads/master@{#292978}
Fix SelectFaviconFramesTest on Nexus 5
BUG=407561
TEST=Tests pass in Nexus 5
Review URL: https://codereview.chromium.org/521393002
Cr-Commit-Position: refs/heads/master@{#292977}
Add testonly flag to GN
This also reworks visibility so both it and the testonly flag are checked when
a target is marked resolved, rather than when it is written out. The previous
code would not check visibility when doing non-"gen" commands like "check",
which is counterintuitive.
This change required OnResolved to be able to report a failure, which required
updating many callers. But it makes visibility mush easier to test, so I
added some additional visibility tests.
BUG=357779
[email protected]
Review URL: https://codereview.chromium.org/524623005
Cr-Commit-Position: refs/heads/master@{#292976}
[Android] Check whether MockGrantCredentialsPermissionsActivity can be started.
BUG=406596
Review URL: https://codereview.chromium.org/467363004
Cr-Commit-Position: refs/heads/master@{#292975}
Deprecate old Safe Browsing reporting opt-ins
The old prefs are no longer needed; M39 should be a sufficiently long
transition time period.
BUG=384668
[email protected]
Review URL: https://codereview.chromium.org/512083002
Cr-Commit-Position: refs/heads/master@{#292974}
Skia roll 871dca8:98d709b
https://skia.googlesource.com/skia/+log/871dca8ea99f49b8bbf118d0ccbd9da0c59467c3..98d709bc8d0761df8e0ad35e92c06e500f0be50d
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/529083002
Cr-Commit-Position: refs/heads/master@{#292973}
Ignore persisent settings on SPDY4.
SpdySession::SendInitialData() now only retrieves and sends server-persisted
SPDY settings for SPDY/3.1 and below.
BUG=408348
Review URL: https://codereview.chromium.org/515353002
Cr-Commit-Position: refs/heads/master@{#292972}
Adding Text Selection Action Bar Unit Test cases.
Currently there is not enough unit test cases available to cover
the functionality of Text Selection Action Bar. In this patch covering
essentail unit test cases for the same.
BUG=
Review URL: https://codereview.chromium.org/521583003
Cr-Commit-Position: refs/heads/master@{#292971}
Revert of Add Keys() function to ServiceWorkerCache. (patchset #13 id:280001 of https://codereview.chromium.org/477973002/)
Reason for revert:
Failing on content_unittests
EmptyKeys_1
TwoKeys_1
TwoKeysThenOne_1
on Linux ASAN LSAN
Original issue's description:
> Add Keys() function to ServiceWorkerCache.
>
> Other changes:
> * Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf. This is used by Match() and Keys().
>
>
> BUG=392621
>
> Committed: https://chromium.googlesource.com/chromium/src/+/02812f0a3edcacca1f7e05ea0a47cb3d8c6025e1
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=392621
Review URL: https://codereview.chromium.org/534683002
Cr-Commit-Position: refs/heads/master@{#292970}
Add tests for Chromium Mac 10.10 on FYI
BUG=388749
Review URL: https://codereview.chromium.org/520913004
Cr-Commit-Position: refs/heads/master@{#292969}
Use standardized and extendable accelerometer update type.
Updates the type used when delivering accelerometer updates in ash to:
- support a variable number of accelerometers
- be measured in m/s^2
- use axes consistent with the web device motion API.
BUG=380831
TEST=MaximizeModeController unit tests still pass.
TEST=Run on a touchview device and verify that entering / exiting touchview as well as screen rotation still works.
Review URL: https://codereview.chromium.org/500613003
Cr-Commit-Position: refs/heads/master@{#292968}
Fix UI glitches in the new avatar bubble
1. the ruler lines in the "not claire" view on mac is not full width.
2. the title cards on windows has extra padding at the top.
BUG=406618
Review URL: https://codereview.chromium.org/516163003
Cr-Commit-Position: refs/heads/master@{#292967}
Fix crash on ChromeOS: ActiveUserChanged might happen before profile is created.
BUG=407375
TEST=manual
Review URL: https://codereview.chromium.org/527353002
Cr-Commit-Position: refs/heads/master@{#292966}
Add support for Java nano protocol buffers for Android.
This CL adds a new dependency on the protocol buffer compiler
from the android source tree, since this compiler supports
generating Java files using the nano runtime.
The initial version of this dependency is 2.2.0a, but checked
out as what the Android 4.4.4 Release 2.0.1 tag points to.
This CL adds a new protoc binary (for compiling protos) that supports
this, and also adds a Java library with the runtime.
To simplify use of this, it also updates build/protoc_java.gypi to
support generating nano protos by specifying an optional
proto_runtime argument. The argument defaults to 'lite' which does
the same thing as before this change, and setting it to 'nano'
generates the new style Java files.
The plan is to quickly deprecate the 'lite' runtime for Java, since
it is too big and uses too many methods.
BUG=377891
Review URL: https://codereview.chromium.org/511283003
Cr-Commit-Position: refs/heads/master@{#292965}
net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#292964}
Lengthen lastchange VERSION string to show full hash and commit position.
Now that the DMServer has been fixed to accept 'agent' strings longer than
64 characters (http://crbug.com/406948), we can re-lengthen the string
produced by lastchange.py to include both the full git hash and the
Cr-Commit-Position.
[email protected], [email protected]
BUG=406783
Review URL: https://codereview.chromium.org/527103004
Cr-Commit-Position: refs/heads/master@{#292963}
[Sync] Move DataTypeStatusTable ownership into DataTypeManager.
The DataTypeManager now maintains its own status table, which it posts a copy
of on each configuration completion. This makes testing configuration results
easier as we can now just check the type status table, and makes the DTM
more self contained.
To make this work a HistoryDeleteDirectives datatype controller was added to
encapsulate the encryption dependency the type has. Additionally, the PSS
is now able to tell the DTM to reset type errors (e.g. when the user is attempting
to re-configure with or without certain types).
BUG=368834
Review URL: https://codereview.chromium.org/523043005
Cr-Commit-Position: refs/heads/master@{#292962}
mojo: Update python API
Update python API to use mixed case identifier for method to conform to
the chromium python style guide.
[email protected]
Review URL: https://codereview.chromium.org/522483006
Cr-Commit-Position: refs/heads/master@{#292961}
Properly initialize variables in RequestContentScript::ScriptData
POD members of RequestContentScript::ScriptData weren't being initialized,
which a) is really bad because who knows what they might have been, and b)
is bad because it makes Dr. Memory unhappy. Fix it (and pull ScriptData into
the .cc while we're at it).
BUG=409865
Review URL: https://codereview.chromium.org/531823002
Cr-Commit-Position: refs/heads/master@{#292960}
[Android] Stop all media on undoable close.
-Stop all media playback on an undoable tab close
BUG=388600
Review URL: https://codereview.chromium.org/493253002
Cr-Commit-Position: refs/heads/master@{#292959}
Make Demuxer::Stop() synchronous.
BUG=349211
TEST=All existing tests pass.
Review URL: https://codereview.chromium.org/416393003
Cr-Commit-Position: refs/heads/master@{#292958}
Add LocationBar PageAction tests
Page actions in the location bar have been somewhat loosely tested as a side-
effect of the page actions api testing, but (near as I can tell), we never
explicity test the ui for page actions.
This is a problem because the extensions tests shouldn't care about the UI, and
soon won't, since where the page actions are in the UI may change (i.e.,
location bar vs toolbar).
Fix this by adding a few basic UI tests for page actions in the location bar.
BUG=408261
Review URL: https://codereview.chromium.org/512693003
Cr-Commit-Position: refs/heads/master@{#292957}
Implement RenderWidgetHostViewAndroid::GetLastScrollOffset
Apparently this code was being hit on Android. This CL implements the scroll
offset the same way it's implemented on other platforms.
BUG=409792
NOTRY=true
[email protected]
Review URL: https://codereview.chromium.org/533483004
Cr-Commit-Position: refs/heads/master@{#292956}
Skia roll ed82c4e:871dca8
https://skia.googlesource.com/skia/+log/ed82c4e822dff3405b0a6ba9c9d054825cb03b13..871dca8ea99f49b8bbf118d0ccbd9da0c59467c3
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/530993004
Cr-Commit-Position: refs/heads/master@{#292955}
[Telemetry] Move maps GPU test recording to public.
Maps folks have confirmed that it is public data, the same you'd get by
visiting the site.
BUG=
Review URL: https://codereview.chromium.org/526833003
Cr-Commit-Position: refs/heads/master@{#292954}
[android_webview] Don't call super.onMeasure in AwTestContainerView
It shouldn't matter much but the onMeasure method should be overridden
without calling super.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/531583002
Cr-Commit-Position: refs/heads/master@{#292953}
Fix the Copresence permission.
The initializer for the Copresence permission is malformed. It specifies the
message id instead of the flag.
[email protected]
BUG=408843
Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8
Review URL: https://codereview.chromium.org/523433002
Cr-Commit-Position: refs/heads/master@{#292952}
Use the blink main thread isolate for v8 unit tests.
The TestWebKitPlatformSupport will initialize it for us anyway, so use
it.
BUG=none
[email protected],[email protected]
Review URL: https://codereview.chromium.org/526973003
Cr-Commit-Position: refs/heads/master@{#292951}
Revert of Revert of Add support for codepen to form_based_credentials_background (patchset #9 of https://codereview.chromium.org/485743002/)
Reason for revert:
I believe the flakiness may have been fixed by https://codereview.chromium.org/520683002
BUG=
Review URL: https://codereview.chromium.org/531733004
Cr-Commit-Position: refs/heads/master@{#292950}
Fix the issue that GetFrameWindow() may change between AddObserver and RemoveObserver in KeyboardController.
BUG=408995
TEST=Verified on linux_chromeos.
Review URL: https://codereview.chromium.org/527153002
Cr-Commit-Position: refs/heads/master@{#292949}
Blink roll 3337740:07cfde2
https://chromium.googlesource.com/chromium/blink/+log/3337740376fe24b813a4ce1dd9f3817edcd9bfa3..07cfde2700209d53893a4f7be2b52a3a25355740
[email protected],[email protected]
Review URL: https://codereview.chromium.org/531073002
Cr-Commit-Position: refs/heads/master@{#292948}
suppress uninit error at extensions::UserScript::Pickle
[email protected], [email protected], [email protected]
BUG=409865, 377978
NOTRY=true
Review URL: https://codereview.chromium.org/526373003
Cr-Commit-Position: refs/heads/master@{#292947}
Fix labels in import data overlay.
1. you can now click in the space between the text and checkbox
2. clicking on the text now works consistently (due to removing selectability)
BUG=408344
Review URL: https://codereview.chromium.org/517433002
Cr-Commit-Position: refs/heads/master@{#292946}
Add Keys() function to ServiceWorkerCache.
Other changes:
* Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf. This is used by Match() and Keys().
BUG=392621
Review URL: https://codereview.chromium.org/477973002
Cr-Commit-Position: refs/heads/master@{#292945}
Files.app Test: check the cast icon in drive volume
This patch introduces the mock cast API which provide a dummy cast list and the cast icon is shown on the window. So we can check if the icon is shown correctly.
BUG=405415
TEST=manually tested
Review URL: https://codereview.chromium.org/505043002
Cr-Commit-Position: refs/heads/master@{#292944}
Reduce flakes in the mini_installer test.
This change makes the test more resilient to unexpected state on the
machine.
- RegistryVerifier can now verify that registry values are not present
(and, as a result, optional registry keys). A key's "exists" property
can be one of "required", "forbidden", or "optional". The first two
behave identically to the true and false boolean values of the
previous implementation. For an "optional" key, values within it may
have an empty dict (i.e., with no "type" or "data" members) to
indicate that the value must not be present in the key if the key is
present.
- Each test now begins with the "no_pv" state rather than the "clean"
state. This is more permissive, and simply ensures that Chrome is not
registered with Google Update.
- After attempting to force-uninstall Chrome (either before executing a
test or after a test failure), the harness will unconditionally delete
the Google Update registration of that Chrome if it is present. This
will clean the machine sufficiently for a subsequent test run.
BUG=375739,401148,402081
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/520633005
Cr-Commit-Position: refs/heads/master@{#292943}
Clean up ManagePasswordsBubbleView and ManagePasswordItemView.
Removed unnecessary includes, reorder the methods, moved private classes to .cc.
Review URL: https://codereview.chromium.org/534543002
Cr-Commit-Position: refs/heads/master@{#292942}
Skia roll 1cbc68f:ed82c4e
https://skia.googlesource.com/skia/+log/1cbc68f9659f15206d920dacd434ddf4b658ad1f..ed82c4e822dff3405b0a6ba9c9d054825cb03b13
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/531793002
Cr-Commit-Position: refs/heads/master@{#292941}
Remove CanPredictNetworkActionsUI from prediction_options.cc.
BUG=406586
Review URL: https://codereview.chromium.org/518973002
Cr-Commit-Position: refs/heads/master@{#292940}
Add owner to DNS histograms
BUG=
Review URL: https://codereview.chromium.org/515953003
Cr-Commit-Position: refs/heads/master@{#292939}
[Telemetry] Move maps recording to public.
Maps folks have confirmed that it is public data, the same you'd get by
visiting the site.
BUG=
Review URL: https://codereview.chromium.org/526833002
Cr-Commit-Position: refs/heads/master@{#292938}
Remove images from google.html test file used by SSLUITest
The images in google.html seem to be triggering an occasional image
decoding bug. Since the SSLUITests don't rely on the images being
present, remove them.
BUG=368280
[email protected]
Review URL: https://codereview.chromium.org/522903004
Cr-Commit-Position: refs/heads/master@{#292937}
A couple fixes to find_unmapped_histograms.py.
- Treats ')' as a param delimeter for the macros.
This makes SCOPED_UMA_HISTOGRAM_TIMER("Foo") not trigger
the non-literal name warning.
- Removes check for FieldTrial::MakeName() which no longer exists.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/504943002
Cr-Commit-Position: refs/heads/master@{#292936}
Show search box on settings page in ChromeOS guest mode.
BUG=408030
[email protected]
TEST=In ChromeOS: Open a guest. Go to settings. Verify search box there.
On desktop: Open a guest. Go to settings. Verify search box not there.
Review URL: https://codereview.chromium.org/517633002
Cr-Commit-Position: refs/heads/master@{#292935}
Blink roll d61a485:3337740
https://chromium.googlesource.com/chromium/blink/+log/d61a485818c6e67e43934ccd3c6cd453994bebf9..3337740376fe24b813a4ce1dd9f3817edcd9bfa3
[email protected],[email protected]
Review URL: https://codereview.chromium.org/518803008
Cr-Commit-Position: refs/heads/master@{#292934}
Remove Default Touch Radii in EventGenerator
EventGenerator creates touch events in two different manners. Those that use TestTouchEvent set touch radii without exposing this to unit test classes. Chrome's gesture recognizer uses these radii when determining touch rects. This can lead to different views being targetting within unittests.
Remove the setting of these radii. Tests that wish to use larger can still create TouchEvents and call EventGenerator::Dispatch.
Review URL: https://codereview.chromium.org/522453002
Cr-Commit-Position: refs/heads/master@{#292933}
Credential Manager: Refactor password_manager::CredentialManagerClient.
password_manager::CredentialManagerClient was a RenderProcessObserver,
and sent messages via RenderThread. This couldn't possibly have ever
worked; the messages it sent were simply dropped on the floor.
After this patch, it's a RenderViewObserver and its messages
successfully land in the ChromePasswordManagerClient, just as they
ought to.
BUG=400674
Review URL: https://codereview.chromium.org/533493004
Cr-Commit-Position: refs/heads/master@{#292932}
Don't change the window disposition for new windows without a user gesture
The popup blocker will block them anyways, and if it's disabled, we
shouldn't change the disposition chosen by the web page
BUG=158274
Review URL: https://codereview.chromium.org/527913002
Cr-Commit-Position: refs/heads/master@{#292931}
Perfhost for ubuntu trusty
Review URL: https://codereview.chromium.org/474933005
Cr-Commit-Position: refs/heads/master@{#292930}
Fixes to get view_manager_lib_unittests not crash
. ICU may be initialized twice: once by the test suite, secondly by
the app.
. window_mamanger_app_.host_ may be deleted by the time we get to the
destructor to try and remove something. Add check for this.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/516523004
Cr-Commit-Position: refs/heads/master@{#292929}
adjust exclusion file to disable WebRtcAecDumpBrowserTest.TwoCallsWithAecDump
on Dr.Memory bot
[email protected]
BUG=389132
NOTRY=true
Review URL: https://codereview.chromium.org/534603003
Cr-Commit-Position: refs/heads/master@{#292928}
disable MacAudioInputTest.AUAudioInputStreamVerifyStereoRecording on memory bots
[email protected]
BUG=409485
NOTRY=true
Review URL: https://codereview.chromium.org/527983002
Cr-Commit-Position: refs/heads/master@{#292927}
Change the OWNER of c/b/cros/fileapi.
BUG=none
Review URL: https://codereview.chromium.org/527213002
Cr-Commit-Position: refs/heads/master@{#292926}
Update linux-release/sizes/chrome-data expectations.
Tiny 0.18% regression was introduced in a blink roll:
https://chromeperf.appspot.com/report?tests=sizes%2Fchrome-data&masters=Chromium&bots=chromium-rel-linux&checked=core&rev=292909
BUG=409852
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/530583003
Cr-Commit-Position: refs/heads/master@{#292925}
Add new Chrome OS key type: Salted SHA256
This CL adds a new key type for Chrome OS authentication and cryptohome
encryption, a base64-encoded salted SHA256 hash. This will be the first
key type supported by the credentials passing API.
BUG=367847
TEST=Extended unit test
Review URL: https://codereview.chromium.org/515153002
Cr-Commit-Position: refs/heads/master@{#292924}
Make touch orientation attributes visible in Blink.
Completed the path for touch orientation attributes (i.e. radiusX, radiusY and rotationAngle of a touch ellipse) from android to Blink.
BUG=381394
Review URL: https://codereview.chromium.org/494833003
Cr-Commit-Position: refs/heads/master@{#292923}
[android_webview] Roll AOSP bot manifest.
This updates the manifest to incorporate newest changes to
the AOSP frameworks/webview project.
BUG=None
TESTS=compile on aosp bot
[email protected]
Review URL: https://codereview.chromium.org/527183003
Cr-Commit-Position: refs/heads/master@{#292922}
Roll libc++/libc++abi.
Roll libc++ to r216548.
Roll libc++abi to r216482.
This rolls in ASan container annotations (among other things).
BUG=397963
[email protected]
NOTRY=true
TEST=ASan, TSan
Review URL: https://codereview.chromium.org/520733002
Cr-Commit-Position: refs/heads/master@{#292921}
Simplify ZoomController by removing DefaultZoomLevel prefs machinery.
In preparation for moving to multiple HostZoomMaps (one-per
StoragePartition), it is helpful to simplify ZoomController by removing
the prefs machinery for DefaultZoomLevel, and instead rely on getting
this value from the HostZoomMap.
The calls to ZoomController::UpdateState() that used to be triggered
directly by the prefs changes still occur, though by a roundtrip from
PrefsTabHelper via IPC to RenderViewImpl and then by IPC back to
the HostZoomMap, which in turn notifies its observers. This only happens
in cases where the change in DefaultZoomLevel actually causes the
RenderViewImpl to change its zoom, so it is a subtle change in behaviour
from before.
BUG=335317
Review URL: https://codereview.chromium.org/508263002
Cr-Commit-Position: refs/heads/master@{#292920}
Mac Video Capture: Connect AVFoundation for Dev Channel builds
BUG=408089
Review URL: https://codereview.chromium.org/530983002
Cr-Commit-Position: refs/heads/master@{#292919}
Enabling overscroll/GestureNav for Athena.
BUG=401604
Review URL: https://codereview.chromium.org/524623004
Cr-Commit-Position: refs/heads/master@{#292918}
Making suggestion popup scrollable in landscape mode
Setting height for Suggestion popup correctly for portrait
as well as landscape mode so that it is scrollable and does
not overlap with IME.
BUG=409619
Review URL: https://codereview.chromium.org/517403003
Cr-Commit-Position: refs/heads/master@{#292917}
Force-enable the software keyboard when running tests in iOS simulator.
Xcode 6 introduced behavior in the iOS Simulator where the software
keyboard does not appear if a hardware keyboard is connected.
This CL enables the software keyboard when a gtest app starts up.
BUG=392433
Review URL: https://codereview.chromium.org/514223002
Cr-Commit-Position: refs/heads/master@{#292916}
Updating trunk VERSION from 2144.0 to 2145.0
Cr-Commit-Position: refs/heads/master@{#292915}
Skia roll eb2662c:1cbc68f
https://skia.googlesource.com/skia/+log/eb2662c08f07764491a17e0a397cdbeb0e2c05c1..1cbc68f9659f15206d920dacd434ddf4b658ad1f
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/521823005
Cr-Commit-Position: refs/heads/master@{#292914}
Blink roll 2856bb1:d61a485
https://chromium.googlesource.com/chromium/blink/+log/2856bb101929ce5d4253129818f8f2d9e981bba7..d61a485818c6e67e43934ccd3c6cd453994bebf9
[email protected],[email protected]
Review URL: https://codereview.chromium.org/521903004
Cr-Commit-Position: refs/heads/master@{#292913}
DevTools: Fixed range of ports available for tethering
1024 is the first port that doesn't require priveleged access and 32767 is the last port that isn't used as ephemeral.
BUG=409658
Review URL: https://codereview.chromium.org/529913003
Cr-Commit-Position: refs/heads/master@{#292912}
InputImeEventRouter::RegisterImeExtension should register extensions
to correct profile.
BUG=409501,407373
TEST=manual
Review URL: https://codereview.chromium.org/531613002
Cr-Commit-Position: refs/heads/master@{#292911}
Audio Player: Cancel scheduled advance if the track has been changed
BUG=348487
TEST=manual
Review URL: https://codereview.chromium.org/534493002
Cr-Commit-Position: refs/heads/master@{#292910}
Blink roll 134c73f:2856bb1
https://chromium.googlesource.com/chromium/blink/+log/134c73f37a69c2a294d8263fc7e103e75854ffed..2856bb101929ce5d4253129818f8f2d9e981bba7
[email protected],[email protected]
Review URL: https://codereview.chromium.org/533613003
Cr-Commit-Position: refs/heads/master@{#292909}
Move IDS_LEARN_MORE to components_strings.grd
To componentize sad_tab related code, move IDS_LEARN_MORE to outside of chrome.
BUG=402485
[email protected] for include fix under chrome/browser
Review URL: https://codereview.chromium.org/530963002
Cr-Commit-Position: refs/heads/master@{#292908}
Blink roll 105703b:134c73f
https://chromium.googlesource.com/chromium/blink/+log/105703b3eee3e0aa988ebc778fba8911fafa1195..134c73f37a69c2a294d8263fc7e103e75854ffed
[email protected],[email protected]
Review URL: https://codereview.chromium.org/534483002
Cr-Commit-Position: refs/heads/master@{#292907}
Clean content_settings_pattern_parser.* from unnecessary dependencies on extensions/ and net/.
BUG=387079
Review URL: https://codereview.chromium.org/440423003
Cr-Commit-Position: refs/heads/master@{#292906}
Remove the apps grid page switcher from the experimental app list.
This CL removes the page switcher from the experimental app list's apps
grid view. The normal app list should be unaffected.
BUG=406222
Review URL: https://codereview.chromium.org/521823004
Cr-Commit-Position: refs/heads/master@{#292905}
Followup on "Improved logging for input streams"
BUG=405449
Review URL: https://codereview.chromium.org/524393002
Cr-Commit-Position: refs/heads/master@{#292904}
Explicitly #include <algorithm> in media/cast/logging/encoding_event_subscriber.cc
This is needed for std::sort.
I detected the issue when building against system protobuf-2.6.0.
Likely some header is no longer implicitly/indirectly #included.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/528743002
Cr-Commit-Position: refs/heads/master@{#292903}
use c++03 style enum scope
Followup to https://codereview.chromium.org/411973004
We haven't officially switched over to using c++11 everywhere
yet, so this patch replaces c++11 style enum scope with c++03 style scope.
BUG=392621
Review URL: https://codereview.chromium.org/526193002
Cr-Commit-Position: refs/heads/master@{#292902}
Automated Commit: Committing new LKGM version 6223.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292901}
Experimental app list: Move custom launcher pages to the end.
They now come after the fixed pages (start page and apps grid).
BUG=406222
Review URL: https://codereview.chromium.org/526983002
Cr-Commit-Position: refs/heads/master@{#292900}
Blink roll ad26197:105703b
https://chromium.googlesource.com/chromium/blink/+log/ad26197593255ddf08b445e3862c804b11738dd4..105703b3eee3e0aa988ebc778fba8911fafa1195
[email protected],[email protected]
Review URL: https://codereview.chromium.org/527133002
Cr-Commit-Position: refs/heads/master@{#292899}
Watch chromeos/dbus
BUG=None
Review URL: https://codereview.chromium.org/530873003
Cr-Commit-Position: refs/heads/master@{#292898}
pdf: Move the string/image resources for the pdf plugin.
Move the resources for the pdf plugin out of //content into //components. Also,
reuse the same code for getting the resource from PepperPDFHost and
PPB_PDF_Impl.
BUG=401242
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/506473003
Cr-Commit-Position: refs/heads/master@{#292897}
Blink roll 2504b5a:ad26197
https://chromium.googlesource.com/chromium/blink/+log/2504b5ab42fcfdb91c782eabef1b1118b61d8749..ad26197593255ddf08b445e3862c804b11738dd4
[email protected],[email protected]
Review URL: https://codereview.chromium.org/530863002
Cr-Commit-Position: refs/heads/master@{#292896}
[Athena] Add status icons and system time to the desktop background
BUG=404156
TEST=Manual, see bug
TBR=sadrul, oshima (TBRing because of DEPS file modifications)
Review URL: https://codereview.chromium.org/483363003
Cr-Commit-Position: refs/heads/master@{#292895}
Blink roll 31d45bf:2504b5a
https://chromium.googlesource.com/chromium/blink/+log/31d45bf6e4c602a8f3e231037bb4c7fe6865e614..2504b5ab42fcfdb91c782eabef1b1118b61d8749
[email protected],[email protected]
Review URL: https://codereview.chromium.org/528873002
Cr-Commit-Position: refs/heads/master@{#292894}
Do not release capture when starting a move loop on Desktop Linux.
ChromeOS does not release capture when starting a move loop either.
This CL fixes http://crbug.com/402301 as a side effect.
BUG=392480, 402301
TEST=None
Review URL: https://codereview.chromium.org/455553003
Cr-Commit-Position: refs/heads/master@{#292893}
Blink roll a437be8:31d45bf
https://chromium.googlesource.com/chromium/blink/+log/a437be840d7d26ff0cd4ee60d4cf048d78498de1..31d45bf6e4c602a8f3e231037bb4c7fe6865e614
[email protected],[email protected]
Review URL: https://codereview.chromium.org/533483002
Cr-Commit-Position: refs/heads/master@{#292892}
Make SetState be called later when screen is unlocking.
The bug's root cause is SetState is called too early when screen is
unlocking and IMF thinks the current UI session is still LOCK screen so
it won't persist the active input method.
BUG=409500
TEST=Verified on Pixel.
Review URL: https://codereview.chromium.org/521463005
Cr-Commit-Position: refs/heads/master@{#292891}
Remove unused GeolocationDispatcher::geolocationDestroyed().
As of Blink r180944, Blink is no longer notifying the embedder of its
GeolocationController reference going away (as there's no need.) Follow
up and retire the notification implementation on the embedder side.
[email protected], [email protected]
BUG=
Review URL: https://codereview.chromium.org/526123002
Cr-Commit-Position: refs/heads/master@{#292890}
Blink roll 1954c45:a437be8
https://chromium.googlesource.com/chromium/blink/+log/1954c458067aaa54cbfdbaa644903809cdfd7588..a437be840d7d26ff0cd4ee60d4cf048d78498de1
[email protected],[email protected]
Review URL: https://codereview.chromium.org/525423002
Cr-Commit-Position: refs/heads/master@{#292889}
MessageReceiver must handle Message and not MessageWithHeader.
MessageReceiver were given MessageWithHeader. This is incorrect as this
force validation code at the Connector level, while Connector should not
impose any format on the message it receives.
[email protected]
Review URL: https://codereview.chromium.org/525383002
Cr-Commit-Position: refs/heads/master@{#292888}
The password bubble should fade out on click on the web page.
The timeout is now obsolete. The bubble stays infinitely if there is no user input.
BUG=394287
Review URL: https://codereview.chromium.org/520743002
Cr-Commit-Position: refs/heads/master@{#292887}
Log error messages in windows video capture
BUG=405016
Review URL: https://codereview.chromium.org/489183003
Cr-Commit-Position: refs/heads/master@{#292886}
Revert of Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remo… (patchset #1 id:1 of https://codereview.chromium.org/517803004/)
Reason for revert:
Breaks *lots* of browser_tests on Mac ASan. See e.g.:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%281%29&number=2036
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%282%29&number=2600
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%283%29&number=2424
Original issue's description:
> Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.
>
> The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions.
> This CL deletes the .saves files and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383, 242503, 170739, 166857
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d5319a149964f953e7506c1ff2b33f90974d19ea
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=148383, 242503, 170739, 166857
Review URL: https://codereview.chromium.org/522743003
Cr-Commit-Position: refs/heads/master@{#292885}
[Password Manager] Restrict IsTheHotNewBubbleUIEnabled to Aura and Mac
ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled needs to return false on Android, because there is no bubble for Android.
Unintentionally, I (vabr) misinformed dconnelly in https://codereview.chromium.org/444603003/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode357 that IsTheHotNewBubbleUIEnabled is not compiled on Android at all, whereas the truth is, it is only not compiled for Androd WebView.
As a consequence, IsTheHotNewBubbleUIEnabled started to return possibly true on Android after https://codereview.chromium.org/505123002 landed, causing a crash on the bots.
BUG=328847,409622
Review URL: https://codereview.chromium.org/529743002
Cr-Commit-Position: refs/heads/master@{#292884}
Update V8 to version 3.29.35.1 (merged r23567).
[email protected]
Review URL: https://codereview.chromium.org/521303003
Cr-Commit-Position: refs/heads/master@{#292883}
Add policy indicator for protocol handlers
This CL adds policy indicators to show that a protocol handler is installed by policy.
BUG=384361
Review URL: https://codereview.chromium.org/518673003
Cr-Commit-Position: refs/heads/master@{#292882}
Mac Video Capture: correct float framerate wrongly casted to int
This migration int -> float was still missing.
BUG=380463, 394315
Review URL: https://codereview.chromium.org/485103006
Cr-Commit-Position: refs/heads/master@{#292881}
Blink roll 0f13ba4:1954c45
https://chromium.googlesource.com/chromium/blink/+log/0f13ba4c4b4529d1118c049259c2fbbcaee50e07..1954c458067aaa54cbfdbaa644903809cdfd7588
[email protected],[email protected]
Review URL: https://codereview.chromium.org/530763003
Cr-Commit-Position: refs/heads/master@{#292880}
New pages added to smoothness.key_mobile_sites.py
BUG=391005
Review URL: https://codereview.chromium.org/525493003
Cr-Commit-Position: refs/heads/master@{#292879}
Bring back lost gamepad_seqlock_unittest.
Currently gamepad_seqlock_unittest.cc is not included in content_tests.gypi.
Also GamepadSeqLock was renamed to OneWriterSeqlLock some time ago as it
is used not only by the gamepad.
To rectify this situation this patch does the following:
- replace references to GamepadSeqLock
- include the unittest in content_tests.gypi
Review URL: https://codereview.chromium.org/507643002
Cr-Commit-Position: refs/heads/master@{#292878}
[Password Manager] Fix to recognise failed login attempt for sites where content server pushes new login form.
With current implementation chromium browser does not recognize the failed login attempt for sites where content server pushes different login form (e.g. http://www.xda-developers.com), and apparently it assumes a login success and offers to save an incorrect password.
With this patch in addition to submitted form's action URL to that of visible form's action URL it ignores the schemes for HTTP or HTTPS URLs as well.
BUG=400769
Review URL: https://codereview.chromium.org/488083002
Cr-Commit-Position: refs/heads/master@{#292877}
Blink roll 1cf1b6f:0f13ba4
https://chromium.googlesource.com/chromium/blink/+log/1cf1b6f4079b8fa8b7319d081de8f3031a0eee62..0f13ba4c4b4529d1118c049259c2fbbcaee50e07
[email protected],[email protected]
Review URL: https://codereview.chromium.org/524413002
Cr-Commit-Position: refs/heads/master@{#292876}
Fix a memory leak in MidiManagerAlsa initialization.
Call snd_ctl_close() to free all the resources allocated with
the control handle.
BUG=409016
Review URL: https://codereview.chromium.org/517363002
Cr-Commit-Position: refs/heads/master@{#292875}
Fixed flakyness of PolicyTest.FileURLBlacklist.
The problem was introduced in https://codereview.chromium.org/110643005.
The URLBlacklistManager used to build the blacklist in the FILE thread
but it's now using the blocking pool; however, FlushBlacklistPolicy
wasn't updated to flush the blocking pool instead of the FILE thread.
This test (and the URL blacklist tests too) have been flaking now
and then on every bot but this race is extremely hard to trigger.
DrMemory on Windows was a consistent repro though.
BUG=339240
Review URL: https://codereview.chromium.org/520703002
Cr-Commit-Position: refs/heads/master@{#292874}
[fsp] Remove the exclusive field from the CreateDirectory operation.
Analogically to CreateFile, we should just return an EXISTS error code if the
entry already exists. The EXISTS error code is later converted to OK if the
operation was requested to be not 'exclusive'.
[email protected]
TEST=browser_tests, unit_tests: *FileSystemProvider*CreateDirectory*
BUG=393141
Review URL: https://codereview.chromium.org/528683002
Cr-Commit-Position: refs/heads/master@{#292873}
Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.
The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.
Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).
Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions.
This CL deletes the .saves files and turns mac_strip_release on for ASan
builds.
BUG=148383, 242503, 170739, 166857
[email protected]
Review URL: https://codereview.chromium.org/517803004
Cr-Commit-Position: refs/heads/master@{#292872}
CPU_ABI in Build has been deprecated using the Android L SDK.
[email protected]
BUG=398669
Review URL: https://codereview.chromium.org/527033003
Cr-Commit-Position: refs/heads/master@{#292871}
Updating trunk VERSION from 2143.0 to 2144.0
Cr-Commit-Position: refs/heads/master@{#292870}
Blink roll 46b3b60:1cf1b6f
https://chromium.googlesource.com/chromium/blink/+log/46b3b608360a078fb8ddae2c3c22042eacbc2e87..1cf1b6f4079b8fa8b7319d081de8f3031a0eee62
[email protected],[email protected]
Review URL: https://codereview.chromium.org/530553007
Cr-Commit-Position: refs/heads/master@{#292869}
Check all settings when checking mic and camera access.
We check if we have camera or mic access when devices are enumerated to determine if labels should be visible or not. We must ensure all settings are checked when doing this.
* Add interface to ContentBrowserClient for checking media access permission. Add implementation in //chrome.
* Refactor permission checking in MediaStreamDevicesController to be able to use them from elsewhere.
* Add checking policy and app permission to the existing content settings check.
* Remove old interfaces on ResourceContext and its implementations.
* Move the permission check from MediaStreamDispatcherHost to MediaStreamManager.
* Refactor MediaStreamManager to be able to mock the check function and update unit test to mock it.
[email protected] (for a few trivial changes)
BUG=406094
Review URL: https://codereview.chromium.org/483523006
Cr-Commit-Position: refs/heads/master@{#292868}
Video Player: Restyle Files.app Cast Selection Menu
See the issue (http://crbug.com/407392#5) for the image of restyled design.
BUG=407392
TEST=manually tested
Review URL: https://codereview.chromium.org/528733002
Cr-Commit-Position: refs/heads/master@{#292867}
ChromeOS: Allow partial (uptime only) Uptime.Logout UMA metrics.
BUG=407388
TEST=manual
Review URL: https://codereview.chromium.org/518843002
Cr-Commit-Position: refs/heads/master@{#292866}
Chromecast devtools delegate fixes.
This patch makes chromecast always bundle the frontend,
and exposes all content targets via remote debugging.
BUG=none
Review URL: https://codereview.chromium.org/517493003
Cr-Commit-Position: refs/heads/master@{#292865}
Revert of Update V8 to version 3.29.35 (based on bleeding_edge revision r23537). (patchset #1 id:1 of https://codereview.chromium.org/530683003/)
Reason for revert:
This makes DevTools in device mode crash silently (crbug.com/409604).
Original issue's description:
> Update V8 to version 3.29.35 (based on bleeding_edge revision r23537).
>
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5c3fee7d50d3f5984d4462fef9cfce694e1ae8a9
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/530763002
Cr-Commit-Position: refs/heads/master@{#292864}
Updates the IME component extension manifests.
1) Use hash in inputview url to support fast inputview switching.
2) Add 'm17n:' to m17n keyboard layout id to avoid conflicts (e.g. 'si' in XKB vs. 'si' in M17n)
3) Change layout IDs for Chinese IMEs to support future compact layouts.
BUG=254398,406979
TEST=Verified on linux_chromeos.
Review URL: https://codereview.chromium.org/473603003
Cr-Commit-Position: refs/heads/master@{#292863}
mojo: Validate fixed size array for the mojo java bindings.
[email protected]
Review URL: https://codereview.chromium.org/522653004
Cr-Commit-Position: refs/heads/master@{#292862}
Refactor/cleanup WebRTC-specific Andorid glue code.
Remove a bunch of code that is already longer used or
will become unused when https://review.webrtc.org/22149004/
and https://codereview.chromium.org/505153002/ are landed.
Remove hardcoded paths to the WebRTC isolate files to make
it easier for us to make changes to them, since we can pass
the path to the .isolate file on test execution instead
(keeping the configuration in the WebRTC buildbot recipe instead).
Previously we had to roll our Chromium revision in WebRTC DEPS
every time a change was made before it became used.
Add support for a CHECKOUT_SOURCE_ROOT environment variable
used to make it possible to override the hardcoded path traversal
that is done to find the src/ directory (since it's different for
WebRTC bots). I considered passing a flag into the test_runner.py
scripts instead of using an environment variable, but my opinion is
that it would pollute the code too much since
constants.DIR_SOURCE_ROOT is used in 70 different places.
BUG=webrtc:3741
TEST=local building and test execution using command lines like this:
cd /path/to/webrtc/src
export CHECKOUT_SOURCE_ROOT=`pwd`
build/android/test_runner.py gtest -s tools_unittests --isolate-file-path=webrtc/tools/tools_unittests.isolate
[email protected]
Review URL: https://codereview.chromium.org/500423004
Cr-Commit-Position: refs/heads/master@{#292861}
Remove "Move window to..." from gear menu.
This CL removes:
- "Move window to..." menu item from the gear menu.
- Remove APIs fileBrowserPrivate.onProfileAdded and fileBrowserPrivate.onDesktopChanged as they are used only for updating gear menu.
- Remove corresponding tests.
BUG=408965
TEST=run browser_test, unit_tests
[email protected]
# TBRing for just removing unused events from file_browser_private.idl
Review URL: https://codereview.chromium.org/530553006
Cr-Commit-Position: refs/heads/master@{#292860}
Set tabindex of search box -1 not to be focused by default.
BUG=408949
TEST=manually
Review URL: https://codereview.chromium.org/529693002
Cr-Commit-Position: refs/heads/master@{#292859}
Blink roll 78807df:46b3b60
https://chromium.googlesource.com/chromium/blink/+log/78807df2ce8a43f50941cee9ae05458df0cc05bf..46b3b608360a078fb8ddae2c3c22042eacbc2e87
TBR=
Review URL: https://codereview.chromium.org/526033002
Cr-Commit-Position: refs/heads/master@{#292858}
Moves the hotwording checkbox back to the 'Privacy' section.
The hotwording checkbox was moved from the 'Privacy' section
of the settings page in https://codereview.chromium.org/382123004/
This cl moves it back to the 'Privacy' section and shows and hides
the 'Voice' section according to the enable-experimental-hotwording flag.
BUG=407893
Review URL: https://codereview.chromium.org/523573004
Cr-Commit-Position: refs/heads/master@{#292857}
Move WebSocket masking benchmarks to net_perftests
Previously WebSocketFrameTestMaskBenchmark.* were included in
net_unittests (with a small number of iterations to avoid slowing down
testing). Move them to net_perftests.
Also remove the command-line option to control the number of iterations,
and use the standard base::PerfTimeLogger output instead of custom logging.
BUG=407445
TEST=net_unittests, net_perftests
Review URL: https://codereview.chromium.org/502353002
Cr-Commit-Position: refs/heads/master@{#292856}
Update V8 to version 3.29.35 (based on bleeding_edge revision r23537).
[email protected]
Review URL: https://codereview.chromium.org/530683003
Cr-Commit-Position: refs/heads/master@{#292855}
Add test data for mojo instrumentation tests.
[email protected]
Review URL: https://codereview.chromium.org/517983002
Cr-Commit-Position: refs/heads/master@{#292854}
Refactor MediaStreamTrack video onmute event.
This changes monitoring of video frames delivered to MediaStreamVideoSource to be started when the source is started and stopped when the source is stopped rather than depend on
that the source object is destroyed since destruction is dependent on when blink runs garbage collection.
It removes the unused MediaStreamVideoTrack::SetMuted and GetMuted.
It reduces the need for a thread hop between the io-thread and the render thread for each monitor intervall by only trigger the monitoring callback on if a change has occured.
It reduces the test time of media_stream_video_source_unittest.cc from more than 7s to around 200ms.
BUG= 404106
Review URL: https://codereview.chromium.org/509873002
Cr-Commit-Position: refs/heads/master@{#292853}
Credential Manager: Stub out the browser-side IPC handlers.
BUG=400674
[email protected]
Review URL: https://codereview.chromium.org/496703002
Cr-Commit-Position: refs/heads/master@{#292852}
[fsp] Generalize fileBrowserPrivate.getEntryProperties().
This patch makes the method providing additional metadata for entries available
for provided file systems too.
NOTRY=True
TEST=Tested manually. Files app works as before.
BUG=408017
Review URL: https://codereview.chromium.org/515033002
Cr-Commit-Position: refs/heads/master@{#292851}
[SyncFS] Deflake SyncFileSystemServiceTest.SimpleLocalSyncFlow
Fix mock expectation for the flaky test.
BUG=408443
TEST=unit_tests --gtest_filter=SyncFileSystemServiceTest.SimpleLocalSyncFlow
Review URL: https://codereview.chromium.org/524193004
Cr-Commit-Position: refs/heads/master@{#292850}
gpu: Enable relevant extentions on GLES3.
What’s New in OpenGL ES 3.0 among GL extentions
- Vertex array
- Element index uint
- npot texture
- float texture (1)(2)
- GLSL standard derivatives
- Blend min&max
(1) GLES3 supports float and half float texture but only half float texture is
filterable and doesn't allow them for color attachment.
(2) This CL doesn't enable half_float due to conflicting GL_OES_texture_float
BUG=405484
Review URL: https://codereview.chromium.org/489023002
Cr-Commit-Position: refs/heads/master@{#292849}
Aura: Don't activate menus and other non-activatable widgets on drop
BUG=none
Review URL: https://codereview.chromium.org/517103003
Cr-Commit-Position: refs/heads/master@{#292848}
ChromeVox should not speak live regions that aren't in the document.
The underlying issue is that by the time we get around to processing a live
region node from a mutation observer, the node may no longer be part of
the DOM, in which case we should treat it as invisible.
To fix it, fix cvox.DomUtil.hasInvisibleAncestor_ so that it returns
true (invisible) if passed an element that's not actually part of the
document.
BUG=408821
Review URL: https://codereview.chromium.org/517853002
Cr-Commit-Position: refs/heads/master@{#292847}
[fsp] Remove the unused streaming field.
The field is not used, so it should be removed.
NOTRY=True
TEST=Tested manually that Files app works correctly.
BUG=408017
Review URL: https://codereview.chromium.org/522533003
Cr-Commit-Position: refs/heads/master@{#292846}
Handle the case when the last selection is not set yet.
When a user starts to drag an item before they haven't selected any item yet,
FileTable.lastSelection_ can be undefined and this ends up an incorrect drag image.
The existence of lastSelection_ should be checked.
BUG=409514
TEST=manually
Review URL: https://codereview.chromium.org/532453002
Cr-Commit-Position: refs/heads/master@{#292845}
ChromeVox is using Array.every in three places where it should be forEach.
This is causing problems when a function that returns an array of
nav descriptions returns more than one item, they're not all processed
correctly.
BUG=408821
Review URL: https://codereview.chromium.org/517843002
Cr-Commit-Position: refs/heads/master@{#292844}
Refactor app list scrolling: introduce the PaginationController class.
PaginationController abstracts over mouse wheel, touch screen and
touchpad event handling for updating the PaginationModel. This allows
any client of PaginationModel (ie, ContentsView) to properly handle
scrolling events. It also removes the code duplication in OnMouseWheel
and OnScrollEvent.
BUG=406222
Review URL: https://codereview.chromium.org/524503003
Cr-Commit-Position: refs/heads/master@{#292843}
adjust suppression for memory leak from chromeos::SessionManagerOperation::EnsureOwnerKey
[email protected]
BUG=381584
NOTRY=true
Review URL: https://codereview.chromium.org/526013002
Cr-Commit-Position: refs/heads/master@{#292842}
Automated Commit: Committing new LKGM version 6221.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292841}
[fsp] Add support for providing thumbnails.
Previously, thumbnails were generated from full size images, which in case of
cloud providers would invoke downloading the entire file.
This CL adds an ability to provide a thumbnail as a data URI, so:
(1) We can have thumbnails for other file types than images.
(2) Thumbnails are shown fast.
(3) Resource consumption is significantly reduced.
Note, that the thumbnails are not wired to Files app yet. That will be done in
a separate patch.
TEST=unit_tests: *FileSystemProvider*GetMetadata*
BUG=407954
Review URL: https://codereview.chromium.org/513683002
Cr-Commit-Position: refs/heads/master@{#292840}
AX: Remove WebLocalFrame dependency from BlinkAXTreeSource.
This is a preparation to support AXObject in PagePopup.
PagePopup doesn't have WebLocalFrame, and it's difficult to provide it. We can
remove WebLocalFrame dependency of BlinkAXTreeSource by using
WebDocument::scrollOffset, minimumScrollOffset, and maximumScrollOffset.
This CL has no functionality changes.
BUG=123896
Review URL: https://codereview.chromium.org/510123003
Cr-Commit-Position: refs/heads/master@{#292839}
ServiceWorker: Update the install sequence as per the latest spec
This change...
(a) updates the install sequence based on the latest spec. Before this
patch, the installing version is set after resolving the register promise.
After this patch, the installing version is set before resolving the promise.
(b) fills registration's version attributes before resolving the register
promise. This should fix the problem mentioned c#5 in the issue and should
absorb the change of the timing to set the installing version due to (a).
(c) adds a separate IPC for updatefound event to adjust the timing to fire
the event. Before this patch, the event shares SetVersionAttributes message.
[1] Blink: https://codereview.chromium.org/524193003/
[2] Chromium: THIS PATCH
[3] Blink: https://codereview.chromium.org/517223002/
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm
BUG=406240
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker/
Review URL: https://codereview.chromium.org/517493002
Cr-Commit-Position: refs/heads/master@{#292838}
Updating buffered duration of local resource in android
OnBufferingUpdate does not work for local resources. Because of this
the buffered range does not get updated. This patch updates the bufferd
range atleast untill the video has played so that media controls can be
painted properly.
[email protected]
BUG=405474
Review URL: https://codereview.chromium.org/496683002
Cr-Commit-Position: refs/heads/master@{#292837}
Skia roll 700a78d:eb2662c
https://skia.googlesource.com/skia/+log/700a78d72fdf4f09b28446818028b39f31e26b38..eb2662c08f07764491a17e0a397cdbeb0e2c05c1
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/529613002
Cr-Commit-Position: refs/heads/master@{#292836}
Remove attributes and methods which should not be part of the public API
BUG=309681
Review URL: https://codereview.chromium.org/514363002
Cr-Commit-Position: refs/heads/master@{#292835}
Blink roll 559a6d4:78807df
https://chromium.googlesource.com/chromium/blink/+log/559a6d4ab7a84c539a58fbc8d8dbc64c97994359..78807df2ce8a43f50941cee9ae05458df0cc05bf
TBR=
Review URL: https://codereview.chromium.org/529633002
Cr-Commit-Position: refs/heads/master@{#292834}
In the presubmit for auto-bisect, run pylint and unit tests.
Note: This only runs pylint and tests for the auto_bisect directory (this was much simpler than picking and choosing particular files from the parent tools directory).
I think the next step is to move bisect-perf-regression.py and related files into the auto_bisect directory.
BUG=
Review URL: https://codereview.chromium.org/529593002
Cr-Commit-Position: refs/heads/master@{#292833}
Video Player: Show the appropriate error message on casting unsupported video
Previously, the error message was 'An error occurred.' This patch changes it to "This file could not be displayed."
BUG=405860
TEST=manually tested
[email protected]
Review URL: https://codereview.chromium.org/523663002
Cr-Commit-Position: refs/heads/master@{#292832}
[SyncFS] Initialize SyncWorker when sync is enabled.
If a service is enabled after initialization failed,
SyncEngine didn't try initializing SyncWorker again, and that makes SyncFS stuck.
BUG=402356
Review URL: https://codereview.chromium.org/470403004
Cr-Commit-Position: refs/heads/master@{#292831}
update disabled test on Dr.Memory bots
- rename WebRtcBrowserTest.TwoCallsWithAecDump to WebRtcAecDumpBrowserTest.*CallWithAecDump*
[email protected]
BUG=389132
NOTRY=true
Review URL: https://codereview.chromium.org/523123003
Cr-Commit-Position: refs/heads/master@{#292830}
[fsp] Move thumbnail logic to Drive specific C++ code.
MetadataCache is soon going to be generalized from Drive to also FSP file
systems. So, in the Files app layer, we should not have Drive specific code.
TEST=Tested manually.
BUG=408017
Review URL: https://codereview.chromium.org/517213002
Cr-Commit-Position: refs/heads/master@{#292829}
Blink roll 332a56a:559a6d4
https://chromium.googlesource.com/chromium/blink/+log/332a56a9d8e5d800e3a1fb8aa69c241d0ce59912..559a6d4ab7a84c539a58fbc8d8dbc64c97994359
TBR=
Review URL: https://codereview.chromium.org/525693003
Cr-Commit-Position: refs/heads/master@{#292828}
Remove Files.app's own profile badge.
Now that the Files.app uses default system header, the own profile badge is redundant.
BUG=408816
TEST=confirmed manually, ran browser_tests
Review URL: https://codereview.chromium.org/520623002
Cr-Commit-Position: refs/heads/master@{#292827}
Make apps grid view scroll vertically in experimental app list.
Scrolling remains horizontal in the normal (and centered) app lists.
BUG=406222
TEST=Run with --enable-experimental-app-list --show-app-list. Apps grid
view should scroll vertically. Normal app list should still scroll
horizontally.
Review URL: https://codereview.chromium.org/491973004
Cr-Commit-Position: refs/heads/master@{#292826}
disable WebRtcAecDumpBrowserTest.*CallWithAecDump* on Dr.Memory bots
[email protected]
BUG=389132
NOTRY=true
Review URL: https://codereview.chromium.org/518173004
Cr-Commit-Position: refs/heads/master@{#292825}
exclude test AudioInputTest.Record
[email protected]
NOTRY=true
BUG=409485
Review URL: https://codereview.chromium.org/528653002
Cr-Commit-Position: refs/heads/master@{#292824}
Replace NPObject usage in ppapi with gin
This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
BUG=351636
Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa
Review URL: https://codereview.chromium.org/459553003
Cr-Commit-Position: refs/heads/master@{#292823}
Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.
Use registry virtualization so that stale data on the test machines
don't interfere with the tests.
BUG=375739
Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181
Review URL: https://codereview.chromium.org/521703002
Cr-Commit-Position: refs/heads/master@{#292822}
remoting: Suppress a clang warning that fires in atl headers.
Suppresses
In file included from ..\..\remoting/host/verify_config_window_win.h:10:
..\..\third_party\wtl\include\atlapp.h(1683,17) : warning(clang): using namespace directive in global context in header [-Wheader-hygiene]
using namespace WTL;
^
BUG=5027,82385
[email protected]
Review URL: https://codereview.chromium.org/526863002
Cr-Commit-Position: refs/heads/master@{#292821}
[Local NTP] Implement style updates for Material Design
Applying new styling, with some refactoring and bug fixes. Details:
- Sizing and positioning tweaks.
- Change of assets for "X" and for default favicon (if it's missing).
- Using image as mask, and setting color by CSS (since design uses
solid colors).
- The new PNG files have been minimized.
- Fixed bug: "Undo" and "Restore All" links continue to be selectable
via tab after they fades out.
- Alternative Google logo (white): using image as mask and setting
background color to #eee. Will delete old image for M39.
- Theme title color in title.html <iframe>: now injecting it from local
NTP in "c=RRGGBBAA" format. The old behavior of reading it from
<iframe> and using it to override "c=RRGGBB" are kept, for
compatibility with server-side NTP.
BUG=407943
NOTRY=1
[email protected], [email protected]
Review URL: https://codereview.chromium.org/512583002
Cr-Commit-Position: refs/heads/master@{#292820}
Skia roll 21e6135:700a78d
https://skia.googlesource.com/skia/+log/21e613505562368e7719215f824fa8b3b4be652d..700a78d72fdf4f09b28446818028b39f31e26b38
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/525973002
Cr-Commit-Position: refs/heads/master@{#292819}
Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/)
Reason for revert:
Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.)
Original issue's description:
> Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)
>
> Reason for revert:
> Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
>
> InstallerStateTest.InitializeTwice (run #1):
> [ RUN ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
> Actual: false
> Expected: true
> [ FAILED ] InstallerStateTest.InitializeTwice (219 ms)
>
> InstallerStateTest.InitializeTwice (run #2):
> [ RUN ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
> Actual: false
> Expected: true
> [ FAILED ] InstallerStateTest.InitializeTwice (109 ms)
>
>
> Original issue's description:
> > clang/win: Fix a few warnings in targets not in chromium_builder_tests.
> >
> > Also don't use "default" as a variable name, as it's a keyword.
> > Also fix a bug where a wstring was passed to %ls.
> >
> > No real behavior change.
> >
> > BUG=82385
> > [email protected]
> > TBR=cpu, vitalybuka
> >
> > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09
>
> [email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=82385
>
> Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23
[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=82385
Review URL: https://codereview.chromium.org/525013003
Cr-Commit-Position: refs/heads/master@{#292818}
Updating trunk VERSION from 2142.0 to 2143.0
Cr-Commit-Position: refs/heads/master@{#292817}
Revert of EasyUnlock: Work around the ghost overlay from CSS animation. (patchset #3 id:40001 of https://codereview.chromium.org/487373002/)
Reason for revert:
No longer needed since underlying blink issue http://crbug.com/405250 is fixed.
Original issue's description:
> EasyUnlock: Work around the ghost overlay from CSS animation.
>
> BUG=404779
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290743
[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=404779
Review URL: https://codereview.chromium.org/521343002
Cr-Commit-Position: refs/heads/master@{#292816}
Automated Commit: Committing new LKGM version 6219.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292815}
Blink roll a00905c:332a56a
https://chromium.googlesource.com/chromium/blink/+log/a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f..332a56a9d8e5d800e3a1fb8aa69c241d0ce59912
TBR=
Review URL: https://codereview.chromium.org/525163002
Cr-Commit-Position: refs/heads/master@{#292814}
Skia roll 9e19ce1:21e6135
https://skia.googlesource.com/skia/+log/9e19ce1641422857b850cdedaee40927643b2f42..21e613505562368e7719215f824fa8b3b4be652d
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/524263002
Cr-Commit-Position: refs/heads/master@{#292813}
Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. (patchset #4 id:80001 of https://codereview.chromium.org/521703002/)
Reason for revert:
Breaks InstallerStateTest.InitializeTwice on XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
Original issue's description:
> Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.
>
> Use registry virtualization so that stale data on the test machines
> don't interfere with the tests.
>
> BUG=375739
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=375739
Review URL: https://codereview.chromium.org/520863005
Cr-Commit-Position: refs/heads/master@{#292812}
Blink roll 244a450:a00905c
https://chromium.googlesource.com/chromium/blink/+log/244a450e5891380a808296994588063b762f2a63..a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f
TBR=
Review URL: https://codereview.chromium.org/520383005
Cr-Commit-Position: refs/heads/master@{#292811}
Fix build error with XCode6/OSX 10.9 SDK
OpenGL/gl.h is required to be included to make the build pass.
BUG=
TEST=
Review URL: https://codereview.chromium.org/522533002
Cr-Commit-Position: refs/heads/master@{#292810}
Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)
Reason for revert:
Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
InstallerStateTest.InitializeTwice (run #1):
[ RUN ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
Actual: false
Expected: true
[ FAILED ] InstallerStateTest.InitializeTwice (219 ms)
InstallerStateTest.InitializeTwice (run #2):
[ RUN ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
Actual: false
Expected: true
[ FAILED ] InstallerStateTest.InitializeTwice (109 ms)
Original issue's description:
> clang/win: Fix a few warnings in targets not in chromium_builder_tests.
>
> Also don't use "default" as a variable name, as it's a keyword.
> Also fix a bug where a wstring was passed to %ls.
>
> No real behavior change.
>
> BUG=82385
> [email protected]
> TBR=cpu, vitalybuka
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09
[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=82385
Review URL: https://codereview.chromium.org/519463003
Cr-Commit-Position: refs/heads/master@{#292809}
Skia roll 7843a24:9e19ce1
https://skia.googlesource.com/skia/+log/7843a24ab2c2dc4fe77e82b9689cde953d6abd7c..9e19ce1641422857b850cdedaee40927643b2f42
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/521283002
Cr-Commit-Position: refs/heads/master@{#292808}
Retry Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update.
There was a race condition in the added test check in the previous
attempt. That made the test Super Flaky. This is more noticeable in the
Release builds than the Debug build that I was working with.
(see https://codereview.chromium.org/471233003/)
With a Release build I was able to repro the flakiness (40% failure
over 200 runs). After the fix, I tested 500 runs and the success rate
is now 100%. I can't say it won't flake for other reasons, but
this fixes the main flake that was introduced. Historically,
the test does ocassionally need to be retried due to timeouts,
according to the bot log history. We may want to split the
CORS and the non-CORS test case to see if that will help w/ timeouts.
I didn't want to do that for this patch, since it would get
much more complicated and this is intended for merging to M38.
Retry with the race condition fixed. Also re-enable the test since
it got disabled by another CL for being flaky.
BUG=401755
BUG=315328
Review URL: https://codereview.chromium.org/524683002
Cr-Commit-Position: refs/heads/master@{#292807}
Do not show irrelevant registration promos to supervised and guest users
Hide registration promos for supervised and guest users. Also hide cloud print
connector section and irrelevant "cloud devices" section (since users cannot log
in).
BUG=288614,340893
Review URL: https://codereview.chromium.org/521953002
Cr-Commit-Position: refs/heads/master@{#292806}
Blink roll dafd1d0:244a450
https://chromium.googlesource.com/chromium/blink/+log/dafd1d0b92247b98a38dfa8bc29ceb80e77582f1..244a450e5891380a808296994588063b762f2a63
TBR=
Review URL: https://codereview.chromium.org/528453002
Cr-Commit-Position: refs/heads/master@{#292805}
Chromecast buildfix: forgot an include.
Was necessary for https://codereview.chromium.org/517213005/.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/526693002
Cr-Commit-Position: refs/heads/master@{#292804}
Switch to using WebSettings only for accessibilityEnabled and inlineTextBoxAccess
Depends on https://codereview.chromium.org/495763005/
BUG=406622
Review URL: https://codereview.chromium.org/497273002
Cr-Commit-Position: refs/heads/master@{#292803}
Blink roll 3bbc0b2:dafd1d0
https://chromium.googlesource.com/chromium/blink/+log/3bbc0b2b6d62c60bd38ce576e1af5a68e1e7cb6d..dafd1d0b92247b98a38dfa8bc29ceb80e77582f1
TBR=
Review URL: https://codereview.chromium.org/526703002
Cr-Commit-Position: refs/heads/master@{#292802}
Roll libjingle/source/talk to r7007.
TBR=niklase
NOTRY=true
Review URL: https://codereview.chromium.org/525083002
Cr-Commit-Position: refs/heads/master@{#292801}
Change VideoTrackAdapter to not drop frames if the source frame rate is known.
Also change remote video and pepper plugin MediaStreamVideoSource implementations to not set a guessed frame rate.
BUG= 394315
Review URL: https://codereview.chromium.org/517973002
Cr-Commit-Position: refs/heads/master@{#292800}
Roll WebRTC 6955:7011
[email protected]
NOTRY=True
Review URL: https://codereview.chromium.org/526683002
Cr-Commit-Position: refs/heads/master@{#292799}
Blink roll b28553b:3bbc0b2
https://chromium.googlesource.com/chromium/blink/+log/b28553bee158127ed49ff22547f909f49ed9e00a..3bbc0b2b6d62c60bd38ce576e1af5a68e1e7cb6d
TBR=
Review URL: https://codereview.chromium.org/521163002
Cr-Commit-Position: refs/heads/master@{#292798}
Docserver: Rename CompiledFileSystem's GetFileVersion/GetFileListingVersion to
_GetFileVersionFromCache/_GetFileListingVersionFromCache, because they're
protected not public methods. More importantly, make them return Futures.
Plus a little more cleanup.
These are small changes in preparation to the more interesting patch which
addresses bug 402903.
BUG=402903
[email protected]
Review URL: https://codereview.chromium.org/522183002
Cr-Commit-Position: refs/heads/master@{#292797}
Skia roll 6d13420:7843a24
https://skia.googlesource.com/skia/+log/6d134201a90692b0c7a1c0c4a97c894dae7b2158..7843a24ab2c2dc4fe77e82b9689cde953d6abd7c
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/521143003
Cr-Commit-Position: refs/heads/master@{#292796}
athena: Add an accelerator to abort loading on escape.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/527473002
Cr-Commit-Position: refs/heads/master@{#292795}
Blink roll abff685:b28553b
https://chromium.googlesource.com/chromium/blink/+log/abff6854093617bd6461c113d1b91f7498b399a0..b28553bee158127ed49ff22547f909f49ed9e00a
TBR=
Review URL: https://codereview.chromium.org/523403002
Cr-Commit-Position: refs/heads/master@{#292794}
athena: Show a progress-bar when loading a web-page.
BUG=none
[email protected]
[email protected] for DEPS addition on //ui/compositor
Review URL: https://codereview.chromium.org/521013004
Cr-Commit-Position: refs/heads/master@{#292793}
Update libjingle's GN build config to match a recent fix.
See here: https://codereview.chromium.org/516143002/
TBR=ajm
Review URL: https://codereview.chromium.org/523073003
Cr-Commit-Position: refs/heads/master@{#292792}
Chromecast: command-line switch to override the UMA metric upload URL.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/506083003
Cr-Commit-Position: refs/heads/master@{#292791}
Skia roll 5c49b70:6d13420
https://skia.googlesource.com/skia/+log/5c49b70ae3e19620bbecfe72eb68aa4513c4fd18..6d134201a90692b0c7a1c0c4a97c894dae7b2158
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/522163002
Cr-Commit-Position: refs/heads/master@{#292790}
Revert of Disable UI flags for non-desktop OSes (patchset #4 id:60001 of https://codereview.chromium.org/480453002/)
Reason for revert:
This will cause android to lose account consistency. I should not have removed the file!
Original issue's description:
> Disable UI flags for non-desktop OSes
>
> This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.
>
> BUG=404066
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8003a95bb88e1d25ad59251b5d7e8609d76e5669
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=404066
Review URL: https://codereview.chromium.org/524023002
Cr-Commit-Position: refs/heads/master@{#292789}
Added histogram names to the picture element use counter.
BUG=408797
Review URL: https://codereview.chromium.org/517343003
Cr-Commit-Position: refs/heads/master@{#292788}
Updating trunk VERSION from 2141.0 to 2142.0
Cr-Commit-Position: refs/heads/master@{#292787}
Blink roll dec670c:abff685
https://chromium.googlesource.com/chromium/blink/+log/dec670cdd2062a6598b108047c78c455207c9d6a..abff6854093617bd6461c113d1b91f7498b399a0
TBR=
Review URL: https://codereview.chromium.org/524083002
Cr-Commit-Position: refs/heads/master@{#292786}
Swarming configuration files for chromoting integration tests.
BUG=
Review URL: https://codereview.chromium.org/498373003
Cr-Commit-Position: refs/heads/master@{#292785}
Support both \ and / as path separators in regexes.
Also cleanup src/PRESUBMIT.py to use a common pattern for this.
BUG=409029
Review URL: https://codereview.chromium.org/518863002
Cr-Commit-Position: refs/heads/master@{#292784}
Blink roll 97a3b93:dec670c
https://chromium.googlesource.com/chromium/blink/+log/97a3b93bcfffa9d20d8c58a9c5418be6d1b783eb..dec670cdd2062a6598b108047c78c455207c9d6a
TBR=
Review URL: https://codereview.chromium.org/516113003
Cr-Commit-Position: refs/heads/master@{#292783}
Automated Commit: Committing new LKGM version 6213.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292782}
Skia roll 2fe2ce4:5c49b70
https://skia.googlesource.com/skia/+log/2fe2ce41e3e5647c7aead4d76d75f5500f573fde..5c49b70ae3e19620bbecfe72eb68aa4513c4fd18
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/523273004
Cr-Commit-Position: refs/heads/master@{#292781}
Blink roll e306342:97a3b93
https://chromium.googlesource.com/chromium/blink/+log/e306342ba6b7f74c1be3745e789d75ffe0e809b0..97a3b93bcfffa9d20d8c58a9c5418be6d1b783eb
[email protected],[email protected]
Review URL: https://codereview.chromium.org/525743002
Cr-Commit-Position: refs/heads/master@{#292780}
Adding proper GetUsedMemoryInPercent calculation
This should be the memory pressure calculation as it is performed by the kernel today.
As discussed this is done to experiment with a more detailed resource management algorithm. Once this we have a satisfying solution this can be moved back.
BUG=381212
TEST=none (for this equation)
Review URL: https://codereview.chromium.org/511383003
Cr-Commit-Position: refs/heads/master@{#292779}
Adding option for Stop/Reload in location bar.
Currently reload/stop button is not present in content shell. If user
has to do reload operation then only option to do that is select
the url bar and click go button.Similarly stop button is not present. To stop loading of page only option is to press back button.
Added code to support stop/reload option.
BUG=
Review URL: https://codereview.chromium.org/513183002
Cr-Commit-Position: refs/heads/master@{#292778}
Manual fixups in gpu/ for scoped_refptr operator T* removal.
BUG=110610
[email protected]
Review URL: https://codereview.chromium.org/515943002
Cr-Commit-Position: refs/heads/master@{#292777}
Take chrome/browser/extensions/OWNERS into the modern age.
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/519323002
Cr-Commit-Position: refs/heads/master@{#292776}
Fix bug in QuicHttpStream::SendRequest.
If the session is closed before SendRequest is called, a CHECK would fire in SendRequest().
BUG=409101
Review URL: https://codereview.chromium.org/523463007
Cr-Commit-Position: refs/heads/master@{#292775}
Blink roll cc9283b:e306342
https://chromium.googlesource.com/chromium/blink/+log/cc9283bc767fca02bdf6dec984311a32d8fe65ba..e306342ba6b7f74c1be3745e789d75ffe0e809b0
[email protected],[email protected]
Review URL: https://codereview.chromium.org/521523003
Cr-Commit-Position: refs/heads/master@{#292774}
Create build/linux/unbundle file for protobuf
BUG=none
Review URL: https://codereview.chromium.org/517313002
Cr-Commit-Position: refs/heads/master@{#292773}
Remove weak_ptr from CopresenceManager.
The WhispernetClient object provided by the CopresenceDelegate passed to the
CopresenceManager has a lifetime exceeding that of the CopresenceManager. We
explicitly want to decouple their lifetimes since we may have lifetime
restrictions imposed on WhispernetClient which may require it to outlive the
CopresenceManager. For this reason, when passing a callback to the
WhispernetClient from CopresenceManager, we were using a WeakPtr. This is
unnecessary since the same can be accomplished by passing a CancelableCallback
to the WhispernetClient and Canceling the callback in the CopresenceManager
destructor.
[email protected], [email protected]
BUG=None.
Review URL: https://codereview.chromium.org/517753002
Cr-Commit-Position: refs/heads/master@{#292772}
Skia roll 4ee3e52:2fe2ce4
https://skia.googlesource.com/skia/+log/4ee3e529e2756275a978ae5e4763955a703191f2..2fe2ce41e3e5647c7aead4d76d75f5500f573fde
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/523363002
Cr-Commit-Position: refs/heads/master@{#292771}
Fixed a11y tab handling on cookies settings
Hidden buttons are no longer accessible by pressing TAB.
Cookie buttons are no longer accessible by pressing TAB.
The cookie buttons are still accessible by pressing left/right.
The "Remove" button is still accessible by pressing TAB.
BUG=408470
Review URL: https://codereview.chromium.org/521643003
Cr-Commit-Position: refs/heads/master@{#292770}
Blink roll 54017a5:cc9283b
https://chromium.googlesource.com/chromium/blink/+log/54017a561ca598448bfc4ec9dd341f4b68fe9279..cc9283bc767fca02bdf6dec984311a32d8fe65ba
[email protected],[email protected]
Review URL: https://codereview.chromium.org/526623002
Cr-Commit-Position: refs/heads/master@{#292769}
We process the pending messages immediately if these messages matches
the pattern of SwapBuffers, for example, GLRenderer always issues
SwapBuffers calls with a specific IPC message patterns, it should always
be SetLatencyInfo->AsyncFlush->Echo sequence.
Instead of posting a task to message loop, it could avoid the possibility
of being blocked by other channels, and make SwapBuffers executed as soon
as possible.
BUG=407529
Review URL: https://codereview.chromium.org/495313003
Cr-Commit-Position: refs/heads/master@{#292768}
Refactor captive portal code from SSLBlockingPage to SSLErrorClassification
A function is also added to check the type of the network the user is
connected to.
CL originally written by radhikabhar@ as 400323002, but not landed before
her internship ended.
BUG=395295
[email protected], [email protected]
Review URL: https://codereview.chromium.org/516373003
Cr-Commit-Position: refs/heads/master@{#292767}
Increase per-test timeout in WebGL conformance suite to 180s from 120s.
A couple of the tests are close to the 120s limit on the Debug bots.
BUG=409118
Review URL: https://codereview.chromium.org/524033002
Cr-Commit-Position: refs/heads/master@{#292766}
Lower media::RendererImpl DVLOG level by 1.
Most of these events are infrequent yet very useful when debugging.
Review URL: https://codereview.chromium.org/520593006
Cr-Commit-Position: refs/heads/master@{#292765}
Add a buffering controller for Chromecast.
The buffering controller serves two purposes:
- for URL playback, this will smooth playback when network
condition is not good enough. This basically avoids continuous
stuttering in that case.
- for MSE playback, it stops playback when either audio or video
underruns (which is a special case of the low buffer level state).
BUG=408189
Review URL: https://codereview.chromium.org/509213002
Cr-Commit-Position: refs/heads/master@{#292764}
[Telemetry] Change IPPET sample rate to 10Hz.
NOTRY=True
[email protected]
BUG=
Review URL: https://codereview.chromium.org/526643002
Cr-Commit-Position: refs/heads/master@{#292763}
Adding histogram for measuing custom font collection loading latency and count.
BUG=406659
[email protected]
Review URL: https://codereview.chromium.org/505683004
Cr-Commit-Position: refs/heads/master@{#292762}
android: Use hw acceleration in android_webview_shell
This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).
Committed previously: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438
Review URL: https://codereview.chromium.org/414503004
Cr-Commit-Position: refs/heads/master@{#292761}
Fix order or evaluation bug in wifi services code
[email protected]
BUG=409318,82385
Review URL: https://codereview.chromium.org/525703002
Cr-Commit-Position: refs/heads/master@{#292760}
Make sure primary root window is deleted last.
BUG=403380
[email protected]
Review URL: https://codereview.chromium.org/520273002
Cr-Commit-Position: refs/heads/master@{#292759}
Update cached kiosk app crx from usb stick.
BUG=372857
Review URL: https://codereview.chromium.org/491403003
Cr-Commit-Position: refs/heads/master@{#292758}
Remove implicit conversion from scoped_refptr to T*
BUG=404334
Review URL: https://codereview.chromium.org/522053002
Cr-Commit-Position: refs/heads/master@{#292757}
Add UMA to study the video types for mobile
Before we work on transfering from MediaPlayer to MediaCodec, we want to get some statistics on the current mobile video types to see the impacts.
We want to know how many video are HLS(which will still use MediaPlayer) and how many videos are using MediaSource(which already uses MediaCodec)
BUG=401795
Review URL: https://codereview.chromium.org/505233002
Cr-Commit-Position: refs/heads/master@{#292756}
Don't try to use RFH from proxies for subframes.
BUG=399775
Review URL: https://codereview.chromium.org/519203002
Cr-Commit-Position: refs/heads/master@{#292755}
Remove CDM_5 Support
As we never shipped a CDM based on CDM_5, we can remove the code.
CDM_4 will be removed later, once all clients are upgraded to CDM_6.
BUG=401815
TEST=existing EME tests still pass
Review URL: https://codereview.chromium.org/518353002
Cr-Commit-Position: refs/heads/master@{#292754}
mark DevToolsSanityTest.TestConsoleOnNavigateBack disabled on win due to flake
[email protected]
BUG=409285
Review URL: https://codereview.chromium.org/524943003
Cr-Commit-Position: refs/heads/master@{#292753}
Chromecast: adds CastBrowserProcess to manage browser process entities.
These are not appropriate for CastBrowserMainParts to manage.
[email protected],[email protected]
BUG=336640
Review URL: https://codereview.chromium.org/521753002
Cr-Commit-Position: refs/heads/master@{#292752}
Http cache: Allow caching of byte ranges without strong validators.
In order to fetch a resource using multiple byte range requests, the cache
has to make sure that the resource has not changed, and strong validators
are needed for that.
However, if the cache only has to return data without talking to the server
again, strong validators are not required.
It used to be the case that the cache will not return content from sparse
entries without revalidating tnem with the server first. But that changed a
long time ago to allow regular reuse policies, even for sparse/range requests.
This CL allows caching of partial responses that don't have strong validators,
as they are useful as described above.
BUG=407923
Review URL: https://codereview.chromium.org/509783002
Cr-Commit-Position: refs/heads/master@{#292751}
[chrome://downloads] Pre-fetch foreground progress image to speed up changing the zoom level.
BUG=407021
Review URL: https://codereview.chromium.org/503093002
Cr-Commit-Position: refs/heads/master@{#292750}
Remove "Search Google for this image" context menu item for <webview>.
The functionality was always broken, so remove it until it gets fixed.
We already do not show Searh google for * keyword item anyway.
BUG=407897
Test=In a chrome app, open a <webview> that loads an image.
Right click on that image.
"Search Google for this image" context menu item shouldn't appear.
Review URL: https://codereview.chromium.org/523023003
Cr-Commit-Position: refs/heads/master@{#292749}
Use platform slop/timeout values for selection handle tap detection
Currently, selection handle taps are detected using a basic, hard-coded
timeout threshold. Update this logic to use the platform tap timeout and
scroll slop values, ensuring tap detection consistentcy with the
platform.
BUG=394093,407963
Review URL: https://codereview.chromium.org/516573003
Cr-Commit-Position: refs/heads/master@{#292748}
More System Dialog printing code disabled on Windows.
BUG=374321
Review URL: https://codereview.chromium.org/517193003
Cr-Commit-Position: refs/heads/master@{#292747}
Skia roll 9bd5bbf:4ee3e52
https://skia.googlesource.com/skia/+log/9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f..4ee3e529e2756275a978ae5e4763955a703191f2
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/522723003
Cr-Commit-Position: refs/heads/master@{#292746}
Fix small inaccuracies in the HID API documentation.
Fix typos related to which functions send or receive data. Some of these
were already resolved in 1816af67d3fb992ff49fb22b2b8fc8908d6ee6b1. Also
document where the opaque device ID and connection IDs should be used
and how errors are reported.
BUG=392036
Review URL: https://codereview.chromium.org/518133004
Cr-Commit-Position: refs/heads/master@{#292745}
Blink roll a70eaec:54017a5
https://chromium.googlesource.com/chromium/blink/+log/a70eaece73b718e58ad26a2271e8b99dd1727043..54017a561ca598448bfc4ec9dd341f4b68fe9279
[email protected],[email protected]
Review URL: https://codereview.chromium.org/523963002
Cr-Commit-Position: refs/heads/master@{#292744}
Split storage macros into storage and storage_common
BUG=338338
[email protected]
Review URL: https://codereview.chromium.org/520913003
Cr-Commit-Position: refs/heads/master@{#292743}
Add some unittests for EasyUnlockScreenlockStateHandler
TEST=none
BUG=none
Review URL: https://codereview.chromium.org/521713002
Cr-Commit-Position: refs/heads/master@{#292742}
Remove RenderThreadImpl dependencies from WebMediaPlayerImpl.
This change replaces RenderThreadImpl calls in WebMediaPlayerImpl with
calls on the WebMediaPlayerParams passed into the constructor. This
removes another content/ depencency so that this code can be moved to
media/blink.
The EncryptedMediaSupport creation was moved to RenderThreadImpl and
passed via WebMediaPlayerParams to avoid linking problems that would
occur if WebMediaPlayerImpl was in media/blink.
BUG=408338
Review URL: https://codereview.chromium.org/517003002
Cr-Commit-Position: refs/heads/master@{#292741}
Updated the comment explaining the behavior of --overscroll-history-navigation flag.
BUG=NONE
Review URL: https://codereview.chromium.org/519143002
Cr-Commit-Position: refs/heads/master@{#292740}
Add version info in Widevine CDM description.
BUG=409119
TEST=Tested on Linux and Windows.
Review URL: https://codereview.chromium.org/516103004
Cr-Commit-Position: refs/heads/master@{#292739}
Cleanup: Remove broken BrowserPlugin::FromNode() declaration.
BUG=None
Test=None, internal cleanup.
Review URL: https://codereview.chromium.org/522563005
Cr-Commit-Position: refs/heads/master@{#292738}
Chromecast: return the correct locale in ContentBrowserClient.
[email protected],[email protected]
BUG=336640
Review URL: https://codereview.chromium.org/517213005
Cr-Commit-Position: refs/heads/master@{#292737}
Chromecast: rm explicit constructor on CastMetricsServiceClient.
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/521943002
Cr-Commit-Position: refs/heads/master@{#292736}
Add a bunch of vlogs to RAF related calls in chrome.
This is to figure out which link in RAF is broken to cause flakiness.
My current guess is the compositor scheduler issue, and these logs can confirm.
BUG=393331
TEST=bots
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/516663004
Cr-Commit-Position: refs/heads/master@{#292735}
android: Add browser type for webview shell to telemetry
This adds a browser type 'android-webview-shell' for the test
shell activity (AndroidWebView.apk), which is different from the existing
'android-webview' target that uses the device's system WebView for
testing.
Review URL: https://codereview.chromium.org/517573004
Cr-Commit-Position: refs/heads/master@{#292734}
Add a flag to let render process wait for java debugger
A switch RENDERER_WAIT_FOR_JAVA_DEBUGGER is newly added to block
ChildProcessMain thread of ChildProcessService until a Java debugger is
attached.
BUG=378975
Review URL: https://codereview.chromium.org/511683003
Cr-Commit-Position: refs/heads/master@{#292733}
Cleanup home card shadow code.
- Always shown during the gesture
- not showning in minimized state
- HomeCardView::SetState is no longer used. Remove it.
BUG=408825
[email protected]
TEST=athena_unittests
Review URL: https://codereview.chromium.org/521493002
Cr-Commit-Position: refs/heads/master@{#292732}
Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.
Use registry virtualization so that stale data on the test machines
don't interfere with the tests.
BUG=375739
Review URL: https://codereview.chromium.org/521703002
Cr-Commit-Position: refs/heads/master@{#292731}
[Android checkstyle] Allow underscores in package names.
Review URL: https://codereview.chromium.org/517403002
Cr-Commit-Position: refs/heads/master@{#292730}
SetUploadData now throws an exception if contentType is null.
It used to crash in nativeSetUploadData instead.
BUG=409151
Review URL: https://codereview.chromium.org/526503002
Cr-Commit-Position: refs/heads/master@{#292729}
Revert of android: Use hw acceleration in android_webview_shell (patchset #9 id:160001 of https://codereview.chromium.org/414503004/)
Reason for revert:
clang
Original issue's description:
> android: Use hw acceleration in android_webview_shell
>
> This creates a (GL)SurfaceView overlay on top of the shell
> container view which runs its own thread for rendering.
> It calls into the native draw functor through a small
> dynamic library (drawgl.so).
>
> NOTRY=True
>
> Committed: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/524933002
Cr-Commit-Position: refs/heads/master@{#292728}
Revert of Keep a copy of page id in RenderViewHost. (patchset #2 id:20001 of https://codereview.chromium.org/517813002/)
Reason for revert:
Crash data is coming in from the 39.0.2140.0 canary. I'll revert this so that it doesn't continue reporting crashes over the long weekend.
(Sadly, the crashes so far appear to be in the browser process and not the renderer process, meaning we don't have a solid explanation yet.)
Original issue's description:
> Keep a copy of page id in RenderViewHost.
>
> This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.
>
> BUG=407376
> TEST=this may crash for a few people
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ab752e59a10a2a4c322ee7f6dbbb16a4fdb467e0
[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=407376
Review URL: https://codereview.chromium.org/526493004
Cr-Commit-Position: refs/heads/master@{#292727}
Make the number of raster threads appear in chrome://gpu.
This add methods to compositor_util.cc to compute the number of
raster threads to be used in the renderer process. Then this number
is passed to the renderer process explicitly instead of just forwarding
a command line flag blindly.
If the renderer will use more than one thread, chrome://gpu will report
that "Multiple Raster Threads" is enabled, otherwise it shows disabled.
If the --num-raster-threads command line argument is used to force more
than one thread, then it will show Force enabled.
There is no change in behaviour with this patch, it still uses one thread
unless forced otherwise on the command line.
BUG=237669
Review URL: https://codereview.chromium.org/519923002
Cr-Commit-Position: refs/heads/master@{#292726}
[NaCl SDK] nacl_io: fix bionic build
getnameinfo has a slightly different signature on bionic.
TEST=./build_tools/build_sdk.py --bionic
Review URL: https://codereview.chromium.org/523043004
Cr-Commit-Position: refs/heads/master@{#292725}
Remove dead code in Autofill.
This line can't be reached because it's already guarded by a check to IsAutofillable().
Also, change a method signature to take a const ref.
BUG=none
Review URL: https://codereview.chromium.org/512993002
Cr-Commit-Position: refs/heads/master@{#292724}
Remove resourceless_software_draw() and related unit tests.
WebView passes the correct viewport and transform for tile
priority in both hardware and resourceless software draws. As
a result, PictureLayerImpl does not need to treat
resourceless software draws differently.
BUG=398587
Review URL: https://codereview.chromium.org/517893002
Cr-Commit-Position: refs/heads/master@{#292723}
Revert of Landing Recent QUIC Changes. (patchset #1 id:1 of https://codereview.chromium.org/515303003/)
Reason for revert:
Reverting to see if it fixes the following issue. Crash rate has gone up by 10 times.
BUG=409191
Original issue's description:
> Landing Recent QUIC Changes.
>
> Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.
>
> Merge internal change: 74239145
> https://codereview.chromium.org/509203003/
>
>
> Remove PacketType from QUIC because the QUEUED type is not used and the
> other types can be reduced to a bool.
>
> Merge internal change: 74148481
> https://codereview.chromium.org/515003003/
>
>
> Don't send a QUIC SCUP message until after handshake confirmed.
>
> A server config update was occasionally being sent before the crypto
> handshake was complete, causing the client to close the connection.
>
> Merge internal change: 74132773
> https://codereview.chromium.org/516713002/
>
>
> Change TransmissionInfo's all_transmissions SequenceNumberSet* to
> default to NULL, and only be present if there are multiple transmissions.
>
> Estimated to save ~2% of CPU.
>
> Merge internal change: 74076012
> https://codereview.chromium.org/509073004/
>
>
> Log the quic version for internal server tracing.
> Not used in production.
>
> Merge internal change: 74069715
> https://codereview.chromium.org/514043002/
>
>
> Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
> deque.
>
> Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
> on tools/quic/end_to_end_test.cc.
>
> Merge internal change: 74054196
> https://codereview.chromium.org/514033002/
>
>
> Unit test for empty packet closes QUIC connection bug.
>
> Merge internal change: 74041239
> https://codereview.chromium.org/495423011/
>
>
> Log the QUIC transmission type in QUIC internal server trace visitor.
> Not used in production.
>
> Merge internal change: 73895739
> https://codereview.chromium.org/514023002/
>
>
> Not used in production. Log whether a QUIC packet sent was a crypto
> packet or not for internal server side tracing.
>
> Merge internal change: 73894063
> https://codereview.chromium.org/515003002/
>
>
> Fix a QUIC bug in which PING frames were not being ACK'd.
>
> Merge internal change: 73837644
> https://codereview.chromium.org/512933005/
>
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949
[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/523813003
Cr-Commit-Position: refs/heads/master@{#292722}
Remove two unnecessary params in ViewHostMsg_UpdateRect_Params
scale_factor was not used at all.
scroll_offset was not being used correctly. This CL now grabs the scroll offset from the CompositorFrameMetadata in RenderWidgetHostView.
BUG=none
[email protected] for code deletion in view_messages.h + browser_plugin_messages.h
Review URL: https://codereview.chromium.org/525523003
Cr-Commit-Position: refs/heads/master@{#292721}
sync: Refactor migration integration tests
Refactors the migration tests to no longer reuse the same
StatusChangeChecker.
Splits the previous MigrationChecker into two separate classes:
MigrationWaiter and MigrationWatcher. The waiter is long-lived
and observes migrations. The waiter exists only while we're
waiting for a migration to complete.
BUG=97780, 95742
Review URL: https://codereview.chromium.org/490643004
Cr-Commit-Position: refs/heads/master@{#292720}
Extensions: Move bluetooth APIs to extensions/.
BUG=395240
[email protected]
Review URL: https://codereview.chromium.org/420663003
Cr-Commit-Position: refs/heads/master@{#292719}
android: Use hw acceleration in android_webview_shell
This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).
NOTRY=True
Review URL: https://codereview.chromium.org/414503004
Cr-Commit-Position: refs/heads/master@{#292718}
Video capture frame size: separate coded size and visible size.
The coded size should always be rounded up to multiples of 16 pixels to accomodate
alignment requirements of HW encoders, while the visible size reflects the actual
content size.
Update video capture messages to pass visible rect from browser to renderer process.
BUG=402501
TEST=verify that non-multiple-of-16-pixel capture works and no black border is shown
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/500653003
Cr-Commit-Position: refs/heads/master@{#292717}
More unused grit header script improvements:
- Rename to tools/resources/list_unused_grit_header.py.
- Handle structures of type "FOO_{LEFT,RIGHT,TOP}".
- Add ability to scan files and folders.
NOTRY=true
Review URL: https://codereview.chromium.org/524743002
Cr-Commit-Position: refs/heads/master@{#292716}
[Win, Linux] Always display the avatar button text at the same size.
The problem is that some locales (Hindi) or platforms (Linux) have a
bigger base font size for the default font (crbug.com/405994). If this
is the case, we should decrease the font size to the one we expect,
so that the font fits in the button correctly.
Just adjusting the baseline is not always enough, as the new avatar
button has a fixed size, and the text might not fit correctly
regardless of the baseline adjustments.
Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMRHc5WTBxZWNrRm8&usp=sharing
BUG=403466
TEST=Start Chrome with --enable-new-avatar-menu on Linux, or with --enable-new-avatar-menu and --lang-hi on Windows. The avatar button text should fit nicely in the button.
Review URL: https://codereview.chromium.org/470053004
Cr-Commit-Position: refs/heads/master@{#292715}
[Telemetry] Enable the sandbox for page cyclers on Windows.
Everything seems to run fine locally.
BUG=270920
Review URL: https://codereview.chromium.org/513543007
Cr-Commit-Position: refs/heads/master@{#292714}
[NaCl SDK] genhttpfs.py: allow filenames with spaces in them.
Allow special characters such as spaces in filenames.
Also includes some general cleanup, and documentation.
Review URL: https://codereview.chromium.org/15854004
Cr-Commit-Position: refs/heads/master@{#292713}
ozone: gbm: Fix missing OVERRIDE
BUG=none
TEST=compile
TBR=dnicoara
NOTRY=true
Review URL: https://codereview.chromium.org/518303002
Cr-Commit-Position: refs/heads/master@{#292712}
Skia roll 60cc7d3:9bd5bbf
https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..9bd5bbf9102b164bb5fb0fb0fa0ce065179bbf3f
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/519933002
Cr-Commit-Position: refs/heads/master@{#292711}
[NaCl SDK] Allow ppapi_simple executables to run in both sel_ldr and in chrome.
Override the main() function from libppapi_stub, and rather than
simply failing when PPAPI is missing, assume that we are running
in sel_ldr and jump directly to the user's main function.
As a nice side effect this removes the needs to SEL_LDR=1 builds.
Review URL: https://codereview.chromium.org/412083002
Cr-Commit-Position: refs/heads/master@{#292710}
YCM works correctly when 'out' directory is a symlink.
BUG=NONE
TEST=manually
NOTRY=true
Review URL: https://codereview.chromium.org/519903002
Cr-Commit-Position: refs/heads/master@{#292709}
Docserver: Override Walk in CachingFileSystem
NOTRY=True
Review URL: https://codereview.chromium.org/521453003
Cr-Commit-Position: refs/heads/master@{#292708}
Revert of Disable BrowserTest.InterstitialCloseTab which is flaky. (patchset #1 id:1 of https://codereview.chromium.org/424143003/)
Reason for revert:
This should be fixed by r288895
Original issue's description:
> Disable BrowserTest.InterstitialCloseTab which is flaky.
>
> BUG=393218
> [email protected]
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286225
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=393218
Review URL: https://codereview.chromium.org/523733003
Cr-Commit-Position: refs/heads/master@{#292707}
Disable UI flags for non-desktop OSes
This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.
BUG=404066
Review URL: https://codereview.chromium.org/480453002
Cr-Commit-Position: refs/heads/master@{#292706}
Fix memory leaks related to PulseAudioInputStream.
pa_stream_flush() returns a pa_operation object on success, so we must unref it by calling pa_operation_unref() to avoid memory leaks.
BUG=238493
Review URL: https://codereview.chromium.org/520613003
Cr-Commit-Position: refs/heads/master@{#292705}
Introduce proximity_auth component.
This component handles the protocol between Chrome and an associated phone for
the Easy Unlock and Easy Sign-in features.
The system is currently implemented as a Chrome packaged app, and this is the
first step in migrating this functionality to native code. We will gradually
reimplement the system and switch from the app to this component once the
refactoring is complete.
BUG=385719
Review URL: https://codereview.chromium.org/505373004
Cr-Commit-Position: refs/heads/master@{#292704}
Add GN variables for controlling header checking.
BUG=
[email protected]
Committed: https://chromium.googlesource.com/chromium/src/+/2f985cb
Committed: https://chromium.googlesource.com/chromium/src/+/26bbbb9
Review URL: https://codereview.chromium.org/516683002
Cr-Commit-Position: refs/heads/master@{#292703}
Make HandleWatcher watch on the same thread if the thread is running a MessagePumpMojo.
This CL also makes ApplicationRunnerChromium use MessagePumpMojo by default
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/506353002
Cr-Commit-Position: refs/heads/master@{#292702}
Cleanup: Remove unneeded grit include in chrome.
Also fix up tools/unused-grit-header.py to deal with some more grit formatting and corner cases.
Review URL: https://codereview.chromium.org/514493002
Cr-Commit-Position: refs/heads/master@{#292701}
Pass credentials for WifiManager in Windows.
BUG=370071
Review URL: https://codereview.chromium.org/343053002
Cr-Commit-Position: refs/heads/master@{#292700}
clang/win: Fix a few warnings in targets not in chromium_builder_tests.
Also don't use "default" as a variable name, as it's a keyword.
Also fix a bug where a wstring was passed to %ls.
No real behavior change.
BUG=82385
[email protected]
TBR=cpu, vitalybuka
Review URL: https://codereview.chromium.org/526513002
Cr-Commit-Position: refs/heads/master@{#292699}
sandbox: style cleanup
Based on readability review by Dean Berris at Google.
[email protected]
Review URL: https://codereview.chromium.org/511993005
Cr-Commit-Position: refs/heads/master@{#292698}
Add myself to owners of ImeTest directory.
BUG=None
Review URL: https://codereview.chromium.org/518133002
Cr-Commit-Position: refs/heads/master@{#292697}
Open-source and claim the RendererSyncIPC.ElapsedTime UMA histogram.
BUG=223859
BUG=394757
Review URL: https://codereview.chromium.org/514373003
Cr-Commit-Position: refs/heads/master@{#292696}
Hook up RenderWidgetHost's
loading signal to ResourceScheduler
BUG=128035
Review URL: https://codereview.chromium.org/501703002
Cr-Commit-Position: refs/heads/master@{#292695}
Shrink the search box if the width is too small.
BUG=408600
[email protected]
TEST=manually
Review URL: https://codereview.chromium.org/511053003
Cr-Commit-Position: refs/heads/master@{#292694}
aw: Use comparison DCHECKs where appropriate
BUG=
Review URL: https://codereview.chromium.org/337473004
Cr-Commit-Position: refs/heads/master@{#292693}
Add unit tests for easyUnlockPrivate API - crypto methods
Also, adds some logic to FakeEasyUnlockClient.
BUG=407996
(note that these would have caught the crashes in bugs 404798 and 405976 :/)
Review URL: https://codereview.chromium.org/513013003
Cr-Commit-Position: refs/heads/master@{#292692}
Chromecast fix: MetricsStateManager segfaults if callbacks are empty.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/522853002
Cr-Commit-Position: refs/heads/master@{#292691}
cc: Resource list for headup display
Current HeadUpDisplayLayerImpl allocates one resource
and reuse it continuously. This patch is trying to
allocate two resources and swap one of them
which is available.
so HeadUpDisplayLayerImpl does not need free the resource
while the layer is alive.
Bug=None
Review URL: https://codereview.chromium.org/491783003
Cr-Commit-Position: refs/heads/master@{#292690}
Fix IPC fuzzer build.
Remove unused input_channels parameter from fuzzed media::AudioParameters generation.
Link against new components/pdf files.
Review URL: https://codereview.chromium.org/518923003
Cr-Commit-Position: refs/heads/master@{#292689}
Update nss_revision to 90c5f9a8b8980fe60165813f578bbeb4fe20b18d.
Include the following CLs:
Avoids MSVC warnings about possible value truncation.
https://codereview.chromium.org/515383002/
[email protected],[email protected]
BUG=
Review URL: https://codereview.chromium.org/521463002
Cr-Commit-Position: refs/heads/master@{#292688}
Blink roll 3c4c83c:a70eaec
https://chromium.googlesource.com/chromium/blink/+log/3c4c83c54cc17327ea22f7c628e790a8895dde0d..a70eaece73b718e58ad26a2271e8b99dd1727043
[email protected],[email protected]
Review URL: https://codereview.chromium.org/519853002
Cr-Commit-Position: refs/heads/master@{#292687}
Sort Java AIDL input filenames for makefile stability.
Sort the list of input java files for the aidl build step so that
the contents of generated makefiles in WebView have a stable ordering.
BUG=
Review URL: https://codereview.chromium.org/323803003
Cr-Commit-Position: refs/heads/master@{#292686}
Defer flushing the touch queue when all touch handlers removed
Currently, the touch event queue will flush itself when it's notified
that all touch handlers have been removed. However, this effectively
overrides the ack of any outstanding touch that is being handled. In
particular, the touch may have been the cause of handler removal *and*
been preventDefault'ed, in which case we should respect the
preventDeafult.
Defer flushing the queue when all handlers have been removed, instead
waiting for any outstanding touch ack. Any additional pending events
will be automatically flushed when the ack is received.
BUG=406916
Review URL: https://codereview.chromium.org/521453002
Cr-Commit-Position: refs/heads/master@{#292685}
athena: Add support for PDF.
Advertise support for PDF plugins, and use the implementations from the
pdf component (in //components/pdf) for adding the necessary support for
showing PDF files in athena.
BUG=401242
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/484873004
Cr-Commit-Position: refs/heads/master@{#292684}
Removed IDC_PRINT_TO_DESTINATION.
This code was used for Win8 non-aura builds. Now it's dead.
metro_driver should be cleared separately as it has a lot of stuff excluded from build.
BUG=142330
NOTRY=true
[email protected], [email protected]
Review URL: https://codereview.chromium.org/524543002
Cr-Commit-Position: refs/heads/master@{#292683}
athena: Hide the windows when exiting from overview mode.
Going into overview mode makes all the windows visible. At the end of the
overview mode, make sure the windows that aren't visible (i.e. windows
other than the active window, or the left/right windows in split-view mode)
are marked as hidden correctly.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/525443002
Cr-Commit-Position: refs/heads/master@{#292682}
Removed Ctrl+Shift+P shortcut for system dialog printing on Windows.
BUG=374321
Review URL: https://codereview.chromium.org/522493002
Cr-Commit-Position: refs/heads/master@{#292681}
Switch VP9 lossy encode to CPUUSED=7 and use it by default.
Lossy encoding is now reliable enough to be enabled by default when running with VP9.
BUG=260879
Review URL: https://codereview.chromium.org/421793003
Cr-Commit-Position: refs/heads/master@{#292680}
Rolling WebGL conformance tests db4d3ef9:ad7ab343
BUG=407976
Review URL: https://codereview.chromium.org/523663003
Cr-Commit-Position: refs/heads/master@{#292679}
Plug memory leaks in BluetoothGattChromeOSTest.*.
BUG=369379
[email protected]
Review URL: https://codereview.chromium.org/524693002
Cr-Commit-Position: refs/heads/master@{#292678}
Check if precaching is allowed for the current browser context before
measuring any precache-related metrics.
BUG=309216
Review URL: https://codereview.chromium.org/514353002
Cr-Commit-Position: refs/heads/master@{#292677}
Define WEBRTC_CHROMIUM_BUILD in libjingle.gyp.
Code under webrtc/ expects this to be defined when building against
Chromium. With talk/base having moved to webrtc/base, libjingle code
must adopt this expectation. This appears to be the most straightforward
way of adding this define.
In particular, this is now required to avoid redefinition errors after
the addition of CHECK macros to webrtc/base.
TESTED=local Linux build against the latest webrtc passes.
Review URL: https://codereview.chromium.org/516143002
Cr-Commit-Position: refs/heads/master@{#292676}
aw: Make force-gpu-mem-available-mb work
BUG=
Review URL: https://codereview.chromium.org/519593002
Cr-Commit-Position: refs/heads/master@{#292675}
Do not access an invalidated reference in media::WebMListParser::OnListEnd().
This was detected by ASan's new container-overflow feature.
BUG=409051
[email protected]
Review URL: https://codereview.chromium.org/516283004
Cr-Commit-Position: refs/heads/master@{#292674}
[Cast] In Audio/VideoSender, drop frames when too-long a duration is in-flight.
BUG=404813,405622
Review URL: https://codereview.chromium.org/502333002
Cr-Commit-Position: refs/heads/master@{#292673}
Roll libvpx 563c46b:982d147 //r291661:r291730
For the actual changes, check:
vp8 fix: deallocate denoiser->yv12_last_source
https://codereview.chromium.org/506203004
Disable LTO for one target.
https://codereview.chromium.org/471653004
BUG=408997
Review URL: https://codereview.chromium.org/522573003
Cr-Commit-Position: refs/heads/master@{#292672}
Sort jarjar resource list for makefile stability.
Sort the list of input resource files for the jarjar resource step so
that the contents of generated makefiles in WebView have a stable
ordering.
BUG=
Review URL: https://codereview.chromium.org/516293003
Cr-Commit-Position: refs/heads/master@{#292671}
Mojo: Remove the STATE_WAIT_LOCAL_DETACH_AND_REMOTE_REMOVE_ACK endpoint state.
And add a long explanatory comment about how things are shut down.
[email protected]
Review URL: https://codereview.chromium.org/517373002
Cr-Commit-Position: refs/heads/master@{#292670}
Various GN fixes.
- Fixes gcc_version issues on gTrusty.
- Fixes accidental duplicate in input_events build file.
- Fixes spammy warnings in libxml.
BUG=none
TEST=builds
Review URL: https://codereview.chromium.org/518543004
Cr-Commit-Position: refs/heads/master@{#292669}
Make DoDeferredClose a non-nestable task
This makes it behave the same as the Close function.
Destroying RenderWidgetCompositor during RenderWidget::DoDeferredClose
can cause problems for nested message loops. The bug is that
InputHandlerProxy creates a SwapPromiseMonitor which adds itself to the
LayerTreeHost. In that stack, a nested message loop is run which runs
the RenderWidget::DoDeferredClose function which previously destroyed
the LayerTreeHost. This explodes, because LayerTreeHost expects all
SwapPromiseMonitors to be removed before it is destroyed.
Making DoDeferredClose non-nestable avoids this problem, as the nested
message loop can't run the task, the SwapPromiseMonitor safely gets
removed, and then the LayerTreeHost can be cleanly deleted.
This patch depends on https://codereview.chromium.org/512533002
[email protected],[email protected]
BUG=403500
Review URL: https://codereview.chromium.org/513433002
Cr-Commit-Position: refs/heads/master@{#292668}
Add OWNERS for c/r/r/e/automation
BUG=309681
NOTRY=True
Review URL: https://codereview.chromium.org/523703002
Cr-Commit-Position: refs/heads/master@{#292667}
Roll ANGLE.
ef9d63ec to a502c749.
Contains refactors of shader objects, errors and validation.
Review URL: https://codereview.chromium.org/518873002
Cr-Commit-Position: refs/heads/master@{#292666}
Fix out-of-bounds read in RegistryOverrideManager.
This fixes a class of test flakes that impacts all Windows tests that
use registry_util::RegistryOverrideManager.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/519773002
Cr-Commit-Position: refs/heads/master@{#292665}
Media gallery fixups for scoped_refptr<T> operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/518743002
Cr-Commit-Position: refs/heads/master@{#292664}
Manual fixups in components/policy for scoped_refptr operator T* removal
BUG=110610
Review URL: https://codereview.chromium.org/514143002
Cr-Commit-Position: refs/heads/master@{#292663}
Blink roll 55f9f55:3c4c83c
https://chromium.googlesource.com/chromium/blink/+log/55f9f55cb598e92a166451f4848ce9b80aab3a8d..3c4c83c54cc17327ea22f7c628e790a8895dde0d
[email protected],[email protected]
Review URL: https://codereview.chromium.org/522693004
Cr-Commit-Position: refs/heads/master@{#292662}
Refactor SyncBuildAndRunRevision to remove deep nesting.
I also propose to rename this function to just RunTest, because its purpose is to do everything necessary to obtain a build and run a test to get results, and it's a relatively important and high-level function.
"Flat is better than nested."
-- The Zen of Python, PEP 20.
BUG=
Review URL: https://codereview.chromium.org/484583002
Cr-Commit-Position: refs/heads/master@{#292661}
Add getSelf method to management API to use without the "management" permission.
BUG=392215
Review URL: https://codereview.chromium.org/508263003
Cr-Commit-Position: refs/heads/master@{#292660}
Move sqlite_channel_id_store from chrome/browser/net to net/extras.
Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store.
TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest*
TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore*
BUG=397545
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289996
Review URL: https://codereview.chromium.org/381073002
Cr-Commit-Position: refs/heads/master@{#292659}
Enhance GN diagnostic tools
Unifies the existing desc, refs, and check commands to take an output directory rather than creating a build in out/Default. This matches the other commands.
Separates out the label pattern matching code from the visibility component into a separate object so it can be used in commands to match more than one label. Adds support for toolchains in these patterns (this wasn't so necessary for visibility, but is more useful for these other commands). The old pattern code is now used only for the sources filter. This patch moves the documentation for that directly on the sources assignment filter help.
Enhances "gn check" to take a label or label pattern of targets to check. This is especially necessary now with so many errors, one can focus on one small part of the codebase.
Enhances "gn refs" to work like "gn desc deps" but in reverse. It can print reverse dependency trees, or find all targets that depend on a given target or targets. For example, "find everything that depends on anything in //mojo". It lost the ability to find configs or unresolved dependencies. We could potentially add these back, but they're complicated to implement and less useful.
Adds a "gn ls" command to list targets.
BUG=343726
Review URL: https://codereview.chromium.org/500423003
Cr-Commit-Position: refs/heads/master@{#292658}
Revert of ui: Move ui_unittests.gyp into ui/base. (patchset #5 id:80001 of https://codereview.chromium.org/506483002/)
Reason for revert:
it breaks clobber build of ios_dbg_simulator.
Original issue's description:
> ui: Move ui_unittests.gyp into ui/base.
>
> ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
> ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
> ui_unittests.isolate -> ui_base_tests.isolate
>
> Add a TODO assigned to me to rename ui_unittests target to
> ui_base_unittests when buildbot is updated.
>
> BUG=331829,373148,299841,103304
> TEST=ui_unittests
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/60f6892f7223f9d6db92314edb5df9b63d25720f
[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=331829,373148,299841,103304
Review URL: https://codereview.chromium.org/522843002
Cr-Commit-Position: refs/heads/master@{#292657}
mojo: Fixing array serialization for java bindings.
The num_bytes header for an array must contain the real size of the
array, not the 8 bytes aligned one.
[email protected]
Review URL: https://codereview.chromium.org/519673002
Cr-Commit-Position: refs/heads/master@{#292656}
Add GYP dependencies for the ASan RTL in the component build mode
BUG=345874
NOTRY=true
Review URL: https://codereview.chromium.org/517383003
Cr-Commit-Position: refs/heads/master@{#292655}
Fix library link option generation on Linux.
On Linux the distutil returns only the name of the python library.
Passing only the library name is not good for a compiler (in this case
it was a simple 'python2.7'), the script should return the correct
compiler option (which should be the '-lpython2.7')
BUG=408979
TEST=ninja -C out/Release libmojo_python_system.so
Review URL: https://codereview.chromium.org/521653002
Cr-Commit-Position: refs/heads/master@{#292654}
Clang/Windows update script: copy the dynamic ASan RTL if present
BUG=345874
NOTRY=true
Review URL: https://codereview.chromium.org/519823002
Cr-Commit-Position: refs/heads/master@{#292653}
Mojo: validate nullability in Java bindings.
This is the message validation / receiver end side.
BUG=324170
Review URL: https://codereview.chromium.org/514293002
Cr-Commit-Position: refs/heads/master@{#292652}
[tools/vim/clang-format] Remove spurious echo
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/523673002
Cr-Commit-Position: refs/heads/master@{#292651}
Remove deferred fade shader workaround from RenderText
BUG=388084
Review URL: https://codereview.chromium.org/493363006
Cr-Commit-Position: refs/heads/master@{#292650}
Some ui/BUILD.gn fixes.
This fixes some TODOs in ui/BUILD.gn and add GN build file for
third_party/mozilla.
BUG=None
TEST=None
[email protected]
Review URL: https://codereview.chromium.org/521553002
Cr-Commit-Position: refs/heads/master@{#292649}
Stop showing page actions in the location bar with redesign enabled
No longer show page actions in the location bar iff the
extension action redesign switch is enabled. In addition,
make all extensions tests* pass with the switch on! Woot!
*This is based on running these tests locally. Once
https://codereview.chromium.org/489183005/ goes through,
I can push a run through the trybots with the switch on
by default for kicks and grins.
BUG=397259
BUG=408261
Review URL: https://codereview.chromium.org/516633002
Cr-Commit-Position: refs/heads/master@{#292648}
NaCl: Update revision in DEPS, r13666 -> r13675
This pulls in the following Native Client changes:
r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
r13668: (noelallen) Force rebuild on cmd change.
r13669: (dbrazdil) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13670: (mseaborn) Fix munmap() with length > 0xffff0000 to behave consistently on 32/64-bit
r13671: (mseaborn) Add comment about updating the trybot list in the Commit Queue's code
r13672: (dschuff) Expose LLC's -force-align-stack flag to pnacl-translate
r13673: (dschuff) PNaCl: Update libc++ revision in pnacl/COMPONENT_REVISIONS
r13674: (mseaborn) Use uint32_t for untrusted pointer args: sysconf() and other syscalls
r13675: (mseaborn) Revert r13667: "Re-enable use of Goma on Windows, except when using the PNaCl toolchain"
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/516123002
Cr-Commit-Position: refs/heads/master@{#292647}
Cleanup: Move check_grd_for_unused_strings.py out of chrome/
It isn't specific to chrome, it has a broader usage.
BUG=None
TEST=./tools/check_grd_for_unused_strings.py
[email protected]
Review URL: https://codereview.chromium.org/523523002
Cr-Commit-Position: refs/heads/master@{#292646}
Revert "Explicitly implement copy ctor/assignment operator for IndexedDBKey"
This reverts commit 662e95081cfe6aa20be3a367d7e12b71f9d790b3.
Original commit: https://codereview.chromium.org/136853003
BUG=333205
Review URL: https://codereview.chromium.org/473003003
Cr-Commit-Position: refs/heads/master@{#292645}
Blink roll b8b43dd:55f9f55
https://chromium.googlesource.com/chromium/blink/+log/b8b43dd815f11fafd074bea301aa25cc3957be7c..55f9f55cb598e92a166451f4848ce9b80aab3a8d
[email protected],[email protected]
Review URL: https://codereview.chromium.org/517203003
Cr-Commit-Position: refs/heads/master@{#292644}
app_shell: Do simple audio initialization.
Add a ShellAudioController class that activates audio
devices for input and output and requests max volume.
Also move chromeos::NetworkHandler initialization into
ShellBrowserMainParts so that ShellNetworkController can get
tests at some point.
BUG=405968
Review URL: https://codereview.chromium.org/515573003
Cr-Commit-Position: refs/heads/master@{#292643}
Check that user has supplied at least one URL argument to quic_client
BUG=
Review URL: https://codereview.chromium.org/466513002
Cr-Commit-Position: refs/heads/master@{#292642}
[NaCl SDK] Fix a bug in build_version.ChromeVersion()
And add tests.
BUG=408896
[email protected]
Review URL: https://codereview.chromium.org/524503002
Cr-Commit-Position: refs/heads/master@{#292641}
Move guest_view_internal_api to extensions.
BUG=352293
Review URL: https://codereview.chromium.org/494853004
Cr-Commit-Position: refs/heads/master@{#292640}
Re-reenable memory tests. Fixed sign-in issue. Added missing recording.
BUG=370977
Review URL: https://codereview.chromium.org/520683002
Cr-Commit-Position: refs/heads/master@{#292639}
Roll ASan/Win to r216722
[email protected]
NOTRY=true
BUG=345874
Review URL: https://codereview.chromium.org/519783002
Cr-Commit-Position: refs/heads/master@{#292638}
Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary).
BUG=408936
Review URL: https://codereview.chromium.org/522633002
Cr-Commit-Position: refs/heads/master@{#292637}
Used native deinterleaved and float point format for the input streams.
If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.
This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.
[email protected]
BUG=404884
TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html
Review URL: https://codereview.chromium.org/510073002
Cr-Commit-Position: refs/heads/master@{#292636}
Add account_id to signin manager notifications.
BUG=341408
[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/502343002
Cr-Commit-Position: refs/heads/master@{#292635}
Enable command line arguments for GLES2 CTS.
This will enable us to select the back-end renderer for ANGLE.
BUG=380355
Review URL: https://codereview.chromium.org/474523003
Cr-Commit-Position: refs/heads/master@{#292634}
Remove unused tools/safely-roll-blink.py
It will require an update of the gardening documentation to point to
safely-roll-deps.py instead of safely-roll-blink.py:
http://www.chromium.org/blink/gardening
BUG=None
[email protected] (current LGTM not accepted...)
Review URL: https://codereview.chromium.org/523573002
Cr-Commit-Position: refs/heads/master@{#292633}
Fixing json compiler preview.
BUG=
Review URL: https://codereview.chromium.org/515983003
Cr-Commit-Position: refs/heads/master@{#292632}
Cache pending JS bridge sync IPC replies, and send in case of RenderFrame deletion.
When the WebView app makes a call to java over the JavaScriptBridge,
we leave the renderer hanging on a synchronous IPC. Once control
is passed into Java, it's possible that the WebView may get destroyed
(and thus the IPC channel back to the renderer closed) which means we
can't unblock the renderer waiting on the IPC response.
Instead we cache the IPC reply message and while waiting on Java to come
back to us, if we detect that the RenderFrame has been deleted, send a
reponse back before the IPC channel is closed.
BUG=408188
Review URL: https://codereview.chromium.org/498633003
Cr-Commit-Position: refs/heads/master@{#292631}
android_webview: update deps_whitelist.
OpenSSL is no longer used by chromium and is not being merged any more.
libaddressinput and boringssl are being merged.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/518803002
Cr-Commit-Position: refs/heads/master@{#292630}
Fix ExtensionOptionsGuest style and minor bug
- Reorganize methods in cc file so they match up with the header
- In SetUpAutoSize, use the autosize flag parameter read in from
the embedder to enable/disable autosize instead of passing true
BUG=386838
Review URL: https://codereview.chromium.org/510183002
Cr-Commit-Position: refs/heads/master@{#292629}
Blink roll 8c8a7ba:b8b43dd
https://chromium.googlesource.com/chromium/blink/+log/8c8a7ba64b27fe8063e2211ecffcab1742d19a37..b8b43dd815f11fafd074bea301aa25cc3957be7c
[email protected],[email protected]
Review URL: https://codereview.chromium.org/524613002
Cr-Commit-Position: refs/heads/master@{#292628}
Win Video Capture: add support for enumerating DirectShow WDM devices
DirectShow supports a certain type of Video Capture Cards, in general
video digitizers (a.k.a. Analog video capture cards). These cards need
extra configuration of the "remote" ports in and out. For this purpose,
the Windows Driver Model is used [1], where special DS Filters are
added upstream of the capture source.
This CL adds support for enumerating these devices, which will show up
as another camera in the system list.
Other posterior CLs will figure out other parts needed, namely:
- which "normal" Filter is associated to the WDM Filter, for the
purpose of capabilities enumeration.
- if the VideoCaptureDevice::Name passed to VideoCaptureDeviceWin
is labelled as being WDM, a slightly different capture graph is
needed.
For the Hauppage USB-Live 2, this means another camera called
"Hauppauge Cx23100 Crossbar", in addition to the normal "Hauppauge
USB-Live2"
[1] http://msdn.microsoft.com/en-us/library/windows/desktop/dd373405(v=vs.85).aspx
BUG=402684
Review URL: https://codereview.chromium.org/510723003
Cr-Commit-Position: refs/heads/master@{#292627}
Run extensions_unittests under MemorySanitizer.
BUG=402257
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/520693002
Cr-Commit-Position: refs/heads/master@{#292626}
Fix safely-roll-deps.py to use single quotes.
The regexp were using single quotes but the DEPS files is
using single quotes. With this CL, the DEPS file is correctly
parsed and updated.
BUG=None
[email protected] (current LGTM not accepted)
Review URL: https://codereview.chromium.org/524583002
Cr-Commit-Position: refs/heads/master@{#292625}
Revert "Add armv7s to the iOS ARCH list"
This reverts commit f1dc118635a18587a35b3d6f5092878467c261dd.
Reverting due to inconsistent behavior across toolchains, and lack of
clarity on whether armv7s is actually necessary.
BUG=407295,408027
[email protected]
Review URL: https://codereview.chromium.org/507423005
Cr-Commit-Position: refs/heads/master@{#292624}
Remove duplicated code in for loop in VideoCapture on Windows
Review URL: https://codereview.chromium.org/511213002
Cr-Commit-Position: refs/heads/master@{#292623}
Improve logging related to start/stop and failure of audio input streams in Chrome.
BUG=405449
TEST=Manual testing using different WebRTC clients
Review URL: https://codereview.chromium.org/495983002
Cr-Commit-Position: refs/heads/master@{#292622}
Roll libjpeg_turbo to r291725 (git 2ed5319).
Pulls in Arm64 SIMD support https://codereview.chromium.org/434123003.
BUG=356100
[email protected]
Review URL: https://codereview.chromium.org/515923004
Cr-Commit-Position: refs/heads/master@{#292621}
Manual fixups in drive code for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/511323002
Cr-Commit-Position: refs/heads/master@{#292620}
Revert of Skia roll 60cc7d3:088f4b8 (patchset #1 of https://codereview.chromium.org/516973003/)
Reason for revert:
Make WebKit Linux (dbg) to crash while running:
virtual/gpu/fast/canvas/canvas-style-intact-after-text.html
Original issue's description:
> Skia roll 60cc7d3:088f4b8
>
> https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/06f45538f0dbff916938fc4a949875991c02c06a
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/523603002
Cr-Commit-Position: refs/heads/master@{#292619}
Revert "Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/)"
This reverts commit e8e38740e5ab846889016636024309473c04dedd and fixes
the flakiness of the tests.
The fix is in patch set #2: when the icon is deleted before the bubble, it
clears the icon pointer in the bubble.
Ran five times on the bots without causing failures.
BUG=328847
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/505123002
Cr-Commit-Position: refs/heads/master@{#292618}
Video Player: Fix the condition of 'ended' property
Once the user tries starting the video, the video should not be 'ended'.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/517963002
Cr-Commit-Position: refs/heads/master@{#292617}
OwnerKeyUtil is moved to components/ownership.
BUG=398856
TEST=existing browser_tests
Review URL: https://codereview.chromium.org/494093002
Cr-Commit-Position: refs/heads/master@{#292616}
Blink roll 4c64aba:8c8a7ba
https://chromium.googlesource.com/chromium/blink/+log/4c64aba5ca8a0edb090a6be235efad2ba65c9c89..8c8a7ba64b27fe8063e2211ecffcab1742d19a37
[email protected],[email protected]
Review URL: https://codereview.chromium.org/518013002
Cr-Commit-Position: refs/heads/master@{#292615}
Updating trunk VERSION from 2140.0 to 2141.0
Cr-Commit-Position: refs/heads/master@{#292614}
Remove NETWORK_PREDICTION_UNSET.
Since PrefService provides a consistent and convenient way to check if a user
value has ever been saved for a preference, there is no need for
NETWORK_PREDICTION_UNSET in enum chrome_browser_net::NetworkPredictionOptions.
The default value is NETWORK_PREDICTION_WIFI_ONLY, this is reported by
PrefService if there is no user setting, policy, etc.
Note that since MigrateNetworkPredictionUserPrefs was introduced in
https://codereview.chromium.org/421653006/diff/160002/chrome/browser/net/prediction_options.cc,
there is no need to check the old preference NetworkPredictionEnabled in
CanPrefetchAndPrerender* or CanPreresolveAndPreconnect*.
Also note that Chromium at no point did save NETWORK_PREDICTION_UNSET to disk,
it only used to be provided as a default option. This guarantees that this CL
does not introduce functional change.
TODO:
* Remove network_prediction_enabled from profile_io_data.
* Remove PrerenderCondition classes.
As this CL will also fix UI bug https://crbug.com/404794, I prefer to land it
first, and deal with the other two clean-up items on a separate CL.
BUG=406583
Review URL: https://codereview.chromium.org/516443002
Cr-Commit-Position: refs/heads/master@{#292613}
Add app_shell_browsertests to Linux ASan LSan Tests (2).
BUG=388893
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/518043002
Cr-Commit-Position: refs/heads/master@{#292612}
Disabling WebRTC call tests on Android ASAN.
We are getting renderer crashes, disable until someone can investigate.
BUG=392224,408496
Review URL: https://codereview.chromium.org/516883002
Cr-Commit-Position: refs/heads/master@{#292611}
mojo: Refactor method name generation for java bindings.
[email protected]
Review URL: https://codereview.chromium.org/518703003
Cr-Commit-Position: refs/heads/master@{#292610}
Files.app: Move VP/Galllery related files to dedicate folders
- Move file_manager/js/media/media_controls.{css,js}
-> video_player/js
- Move file_manager/js/media/mouse_inactivity_watcher.js
-> file_manager/js (parent directory)
- Move file_manager/images/media/*
-> video_player/images/media/
- Move file_manager/images/media/error.png
-> gallery/images/media/error.png
BUG=405838
TEST=compile pasees
[email protected]
Review URL: https://codereview.chromium.org/504073002
Cr-Commit-Position: refs/heads/master@{#292609}
Move GLIB_DISABLE_DEPRECATION_WARNINGS define to a more general place.
The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.
BUG=391250
TEST=ninja -C out/Release chrome
Review URL: https://codereview.chromium.org/367113004
Cr-Commit-Position: refs/heads/master@{#292608}
Add cast_unittests to Linux ASan LSan Tests (2).
BUG=400728
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/520543003
Cr-Commit-Position: refs/heads/master@{#292607}
Revert of Net-related fixups for scoped_refptr conversion operator cleanup. (patchset #2 of https://codereview.chromium.org/511163002/)
Reason for revert:
It seems to be breaking GPU Mac Builder (Blink):
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19306/steps/compile/logs/stdio
Original issue's description:
> Net-related fixups for scoped_refptr conversion operator cleanup.
>
> BUG=110610
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/aa3dd9e5a2d3215f9c756ddcbb11268569cbe473
[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=110610
Review URL: https://codereview.chromium.org/517873003
Cr-Commit-Position: refs/heads/master@{#292606}
Fix for a crash in NativeViewAccessibilityWin.
Review URL: https://codereview.chromium.org/521573003
Cr-Commit-Position: refs/heads/master@{#292605}
Filter blacklisted forms out from the crash reports.
BUG=408804
Review URL: https://codereview.chromium.org/522463003
Cr-Commit-Position: refs/heads/master@{#292604}
Blink roll ee13016:4c64aba
https://chromium.googlesource.com/chromium/blink/+log/ee13016d417011b60039bfe6f93cec2b081cf8d0..4c64aba5ca8a0edb090a6be235efad2ba65c9c89
[email protected],[email protected]
Review URL: https://codereview.chromium.org/519683002
Cr-Commit-Position: refs/heads/master@{#292603}
Wire up GetKeyDataEx() in Chrome
This CL wires up cryptohomed's GetKeyDataEx() as
HomedirMethods::GetKeyDataEx() in Chrome. The method will be used to
retrieve metadata such as the hashing algorithm and salt used for a
key.
BUG=367847
TEST=New homedir_methods_unittest.cc
Review URL: https://codereview.chromium.org/506943002
Cr-Commit-Position: refs/heads/master@{#292602}
Add kOsMac to the enable-save-password-bubble platforms.
BUG=328847
Review URL: https://codereview.chromium.org/513193002
Cr-Commit-Position: refs/heads/master@{#292601}
Net-related fixups for scoped_refptr conversion operator cleanup.
BUG=110610
[email protected]
Review URL: https://codereview.chromium.org/511163002
Cr-Commit-Position: refs/heads/master@{#292600}
Move AppWindow to extensions
Move AppWindow, AppWindowRegistry and AppsClient from apps/ to extensions/browser/app_window
Change the namespace from apps to extensions.
Fix GYP and DEPS.
BUG=403726
[email protected] for include and namespace changes
Review URL: https://codereview.chromium.org/494033002
Cr-Commit-Position: refs/heads/master@{#292599}
Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #2 of https://codereview.chromium.org/504823003/)
Reason for revert:
This is breaking the following Blink test:
inspector/layers/layer-canvas-log.html
Original issue's description:
> Try backing SkPicture with SkRecord in Chromium.
>
> This is our first attempt, mostly to feel this out. Performance and
> correctness problems are both possible. Please revert this if a benchmark even
> smells funny.
>
> That said, we've been working on this a while, are pretty confident it's good
> stuff, and have had Skia's internal testing entirely switched over for a week.
> Parts of Chromium that serialize and deserialize SkPictures are already
> switched over. This CL finishes things off by switching the default
> recorded-from-scratch SkPicture to use SkRecord too.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30
[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/522623002
Cr-Commit-Position: refs/heads/master@{#292598}
Move TemplateURLService related tests to components/search_engines
Put tests next to the code being tested.
Move tests to components/ without actually removing dependencies with temporary DEPS rules added.
This results in these tests still built as parts of unit_tests, not components_unittests.
Fix TemplateURLServiceTestUtil to simplify the code and reduce chrome dependencies:
- Create KeywordWebDataService instead of depending on WebDataServiceFactory.
- Remove TemplateURLService::SetKeywordSearchTermsForURL() and TestingTemplateURLService. Instead, TestingTemplateURLServiceClient is responsible to implement SetKeywordSearchTermsForURL().
- Remove content::TestBrowserThreadBundle from test util. Tests are responsible to set up one. This enables TemplateURLServiceTestSyncTest to use multiple test util instances.
BUG=387985
TEST=unit_tests
Review URL: https://codereview.chromium.org/513133002
Cr-Commit-Position: refs/heads/master@{#292597}
Bring up of ImageService.
ImageService is an abstract superclass that will have subclasses
for each mobile platform. This class stores a salient image for
a bookmark which is removed when the bookmark node is deleted.
BUG=None
Review URL: https://codereview.chromium.org/513793002
Cr-Commit-Position: refs/heads/master@{#292596}
Service worker fixups for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/513323002
Cr-Commit-Position: refs/heads/master@{#292595}
Blink roll 5662a64:ee13016
https://chromium.googlesource.com/chromium/blink/+log/5662a645ae76658b93bd944009407fb9d5911e3b..ee13016d417011b60039bfe6f93cec2b081cf8d0
[email protected],[email protected]
Review URL: https://codereview.chromium.org/523563002
Cr-Commit-Position: refs/heads/master@{#292594}
Correct cache-size calculation of MetadataCache.
- Make sure that the DirectoryContent.dispose() is called when necessary.
- Defer dispose() temporarily when we need to replace directory contents.
BUG=408893
TEST=watched the cache size manually, and ran browser_tests
Review URL: https://codereview.chromium.org/520553002
Cr-Commit-Position: refs/heads/master@{#292593}
gpu: Remove WebGraphicsContext3D::makeContextCurrent()
We don't need to call it before using GL context anymore.
BUG=404121
Review URL: https://codereview.chromium.org/470973002
Cr-Commit-Position: refs/heads/master@{#292592}
Refactor app list event handling and prerendering.
ContentsView should not be responsible for apps-grid-specific logic.
To this end, moved scroll and gesture event handling from ContentsView
to AppsGridView, removing the special cases for NAMED_PAGE_APPS. Also
moved some of the prerender logic from ContentsView to AppsGridView.
BUG=377381
Review URL: https://codereview.chromium.org/497413003
Cr-Commit-Position: refs/heads/master@{#292591}
Supervised user interstitial: Remove image URL resolving hack.
The URL now contains a protocol (b/17204752) so we don't need this anymore.
BUG=404671
Review URL: https://codereview.chromium.org/509173005
Cr-Commit-Position: refs/heads/master@{#292590}
Fix midnight determination
Midnight determination by scaling value of internal base::Time representation doesn't take in account time zones, it counts as UTC, but other time logic in local time.
There is failure of test ChromeNetworkDailyDataSavingMetricsTest.PartialDayTimeChange if system time zone will overcome test time to another day (like our +4 for example).
This fix make it work fine and in same way for win and others operating systems.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/479793002
Cr-Commit-Position: refs/heads/master@{#292589}
mojo: Utility class to parse .data file.
This add an utility class to parse .data file. It will be used to run
the validation tests in java.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/508033004
Cr-Commit-Position: refs/heads/master@{#292588}
Blink roll a0ba700:5662a64
https://chromium.googlesource.com/chromium/blink/+log/a0ba700b74d535334d0ba359bfc266cafba26104..5662a645ae76658b93bd944009407fb9d5911e3b
[email protected],[email protected]
Review URL: https://codereview.chromium.org/519633002
Cr-Commit-Position: refs/heads/master@{#292587}
Manual fixups in PPAPI for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/515283002
Cr-Commit-Position: refs/heads/master@{#292586}
Disable FeedbackApiTest.Basic on Win & Linux
The test fails on some Win and Linux bots, more info on the bug.
BUG=408917
NOTREECHECKS=true
NOTRY=true
[email protected]
Review URL: https://codereview.chromium.org/517953002
Cr-Commit-Position: refs/heads/master@{#292585}
Don't set lastError if chrome.dial.discoverNow() can't start; we always attempt discovery and success/failure is indicated through the callback.
Add browser test for chrome.dial.discoverNow() success.
BUG=376588
Review URL: https://codereview.chromium.org/511943004
Cr-Commit-Position: refs/heads/master@{#292584}
Automated Commit: Committing new LKGM version 6212.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292583}
Blink roll 0b1c835:a0ba700
https://chromium.googlesource.com/chromium/blink/+log/0b1c83564fc6d6e5518f711306b85553a01e19b9..a0ba700b74d535334d0ba359bfc266cafba26104
[email protected],[email protected]
Review URL: https://codereview.chromium.org/523553002
Cr-Commit-Position: refs/heads/master@{#292582}
Skia roll 088f4b8:d684422
https://skia.googlesource.com/skia/+log/088f4b8eb31b2af26e66dcbaae062f40b3955059..d684422f1711cbb4106a260d75ee09101065c092
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/519623002
Cr-Commit-Position: refs/heads/master@{#292581}
Video Player: Close the session when the other device is selected to play
BUG=408520
TEST=manually tested
Review URL: https://codereview.chromium.org/514163002
Cr-Commit-Position: refs/heads/master@{#292580}
Disable HiResTimerManagerTest.ToggleOnOff on DrMemory.
It fails there after a recent change.
NOTRY=true
[email protected]
BUG=408911
Review URL: https://codereview.chromium.org/518703002
Cr-Commit-Position: refs/heads/master@{#292579}
DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events
Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.
BUG=398787
Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf
Review URL: https://codereview.chromium.org/511873002
Cr-Commit-Position: refs/heads/master@{#292578}
Add more generic filters to the chrome.hid.getDevices API.
Instead of specifying each of the USB vendor and product ID pairs an
app has permission to open this API extension allows filtering of
devices by vendor and product IDs as well as HID usage pages and
usages. The 'vendorId' and 'productId' properties of GetDevicesOptions
are still supported for backwards compatibility.
BUG=
Review URL: https://codereview.chromium.org/514923002
Cr-Commit-Position: refs/heads/master@{#292577}
Roll BoringSSL.
Rolling for OCSP stapling and some ASN.1 changes. Brings in the following
commits:
6c7aed0 Client-side OCSP stapling support.
e098ec2 Test client auth under TLS 1.2 hash mismatch and SSL 3.
ed6eb66 Add CBS_ASN1_ENUMERATED to bytestring.h.
9b04d65 Export CBS_get_any_asn1_element.
041b58a Remove session_ctx macro.
457112e unifdef a bunch of OPENSSL_NO_* ifdefs.
BUG=408687
Review URL: https://codereview.chromium.org/522513002
Cr-Commit-Position: refs/heads/master@{#292576}
Blink roll 78d2b11:0b1c835
https://chromium.googlesource.com/chromium/blink/+log/78d2b11092668ed42fc97d9a81290a3e226bed43..0b1c83564fc6d6e5518f711306b85553a01e19b9
[email protected],[email protected]
Review URL: https://codereview.chromium.org/520523002
Cr-Commit-Position: refs/heads/master@{#292575}
Revert of Replace NPObject usage in ppapi with gin (patchset #27 of https://codereview.chromium.org/459553003/)
Reason for revert:
Failed memory tests:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6791
Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=351636
Review URL: https://codereview.chromium.org/522583002
Cr-Commit-Position: refs/heads/master@{#292574}
Added restricted font fallback to custom font collection loader.
After few experiments/crashes it seems that some users have enormous number of fonts in the registry. On suspect that we have for failing to load collection is that direct write cache is unable to load/handle those many fonts. In this CL we are trying to see if we can put arbitrary limit on number of fonts that could be loaded. We also added a fallback mechanism where in if loading from registry fails, we will try to load only default fonts. Definition of 'default' is taken from file prefs_tab_helper.cc ~ kDefaultFonts.
R=ananta,scottmg,cpu
BUG=399233
Review URL: https://codereview.chromium.org/521483002
Cr-Commit-Position: refs/heads/master@{#292573}
Keep a copy of page id in RenderViewHost.
This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.
BUG=407376
TEST=this may crash for a few people
Review URL: https://codereview.chromium.org/517813002
Cr-Commit-Position: refs/heads/master@{#292572}
win: Add /Zc:inline to Pro Release builds
http://msdn.microsoft.com/en-us/library/dn642448.aspx
This makes Release .objs smaller and so links faster. It was added in
Update 2, but caused the compiler to crash on Chrome building LTCG. It
seems to be OK after Update 3.
As the depot_tools Express toolchain is not yet Update 3, we don't add
the flag there.
[email protected]
BUG=350018,402270
Review URL: https://codereview.chromium.org/474463002
Cr-Commit-Position: refs/heads/master@{#292571}
Move gestureCreated, touchMaxDistance and touchDuration UMA logs into gesture provider, so that they can also record data from other platforms, such as Android, Windows, not only from ChromeOS.
BUG=352654
Review URL: https://codereview.chromium.org/501553004
Cr-Commit-Position: refs/heads/master@{#292570}
Remove the search icon from the search box in the experimental app list.
This CL removes the magnifying glass icon from the experimental app
list. The normal app list should be unaffected
BUG=406222
Review URL: https://codereview.chromium.org/503693002
Cr-Commit-Position: refs/heads/master@{#292569}
Disable PnaclHeaderTest.TestHasPnaclHeader as it is flaky.
[email protected]
NOTRY=true
BUG=315328
Review URL: https://codereview.chromium.org/517813003
Cr-Commit-Position: refs/heads/master@{#292568}
- Add support for references in different paths in apis.
- Move ImageDetails from chrome to extensions.
BUG=352290
Review URL: https://codereview.chromium.org/487533005
Cr-Commit-Position: refs/heads/master@{#292567}
[ServiceWorker] Set blob_size of ServiceWorkerFetchRequest as kuint64max when it is unknown.
This patch and https://codereview.chromium.org/514113003 will fix the wrong size of blob which can be get by calling FetchEvent.request.body.asBody() of the fetch event which body includes a file item.
BUG=402387
Review URL: https://codereview.chromium.org/517543002
Cr-Commit-Position: refs/heads/master@{#292566}
Audio Player: Don't update the track list when the list is not changed
Previously, when user clicked the audio file on Files.app, the track list was updated unexpectedly and the current track index was set to the default (the first file) for a very short time just before the index was updated to the selected file. This unexpected change in short period made the playback time reset and caused the issue (crbug.com/395868). This patch fixes this issue.
BUG=395868
TEST=none
Review URL: https://codereview.chromium.org/515443002
Cr-Commit-Position: refs/heads/master@{#292565}
Manual fixups in chrome/ for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/523463003
Cr-Commit-Position: refs/heads/master@{#292564}
[Mac] Make app shims load the same framework version as the running Chrome process.
When a new version of Chrome has been downloaded but the old version is
still running, any app shims that start will load the new framework version.
This is problematic as the IPC codes (See ipc_message_start.h) may not match.
With this CL, app shims will check a version file written by the Chrome
process and load the corresponding framework version.
This also increments kCurrentAppShortcutsVersion, which causes all app
shims to be rebuilt.
This also moves AppModeChromeLocatorTest to browser_tests. It's not really
necessary for them to have their own target (app_mode_app_tests), and this
way they actually get run.
BUG=405347
Review URL: https://codereview.chromium.org/501303002
Cr-Commit-Position: refs/heads/master@{#292563}
Revert SetShape to dev channel or whitelist.
BUG=324071,374440,408737
Review URL: https://codereview.chromium.org/522463002
Cr-Commit-Position: refs/heads/master@{#292562}
Removed NativeMetafile and PreviewMetafile typedef as it's always PdfMetafileSkia.
BUG=170859
TBR=sgurun, yzshen
Review URL: https://codereview.chromium.org/516833002
Cr-Commit-Position: refs/heads/master@{#292561}
Remove time getters from AudioBufferQueue and AudioRendererAlgorithm.
With the switch to pure frame-based calculation of time in 5b6ce11,
these methods are no longer used.
BUG=370634
Review URL: https://codereview.chromium.org/516113002
Cr-Commit-Position: refs/heads/master@{#292560}
Move StringComparator<string16>::operator() to header
Enabling /Zc:inline on static release build results in
FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True chrome.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:chrome.dll.lib /DLL /OUT:chrome.dll @chrome.dll.rsp" 2 mt.exe rc.exe "obj\chrome\chrome_main_dll.chrome.dll.intermediate.manifest" obj\chrome\chrome_main_dll.chrome.dll.generated.manifest ..\..\chrome\app\chrome.dll.manifest
browser_2.lib(browser_2.character_encoding.obj) : error LNK2019: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z) referenced in function "void __cdecl std::_Adjust_heap<struct CharacterEncoding::EncodingInfo *,__int64,struct CharacterEncoding::EncodingInfo,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo> >(struct CharacterEncoding::EncodingInfo *,__int64,__int64,struct CharacterEncoding::EncodingInfo &&,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo>)" (??$_Adjust_heap@PEAUEncodingInfo@CharacterEncoding@@_JU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@std@@YAXPEAUEncodingInfo@CharacterEncoding@@_J1$$QEAU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@Z)
browser_1.lib(browser_1.background_application_list_model.obj) : error LNK2001: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z)
So, move StringComparator<base::string16>::operator() into header and
mark it inline, so that it's available in all translation units where it's
used. The previous code was correct, but this makes all compilers happy.
/Zc:inline ref: http://msdn.microsoft.com/en-us/library/dn642448.aspx
[email protected]
[email protected]
BUG=350018
Review URL: https://codereview.chromium.org/518533002
Cr-Commit-Position: refs/heads/master@{#292559}
Renderer changes for wiring up shared memory with declarative injection
BUG=377978
Review URL: https://codereview.chromium.org/492133002
Cr-Commit-Position: refs/heads/master@{#292558}
Replace NPObject usage in ppapi with gin
This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
BUG=351636
Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
Review URL: https://codereview.chromium.org/459553003
Cr-Commit-Position: refs/heads/master@{#292557}
SkImageInfo will soon have a constructor, so can't init it with {} anymore
needed for this CL
https://codereview.chromium.org/517123002/
TBR=
Review URL: https://codereview.chromium.org/517803002
Cr-Commit-Position: refs/heads/master@{#292556}
Rollback Print and Cancel button positions change, it breaks the tab order.
BUG=407974
Review URL: https://codereview.chromium.org/510353003
Cr-Commit-Position: refs/heads/master@{#292555}
Never clobber all of build in landmines
We don't support msvs any more anyway, and clobbering all of build/ is
always a bad idea. (I'm not sure this'll fix anything, but maybe we'll
get a better error.)
[email protected],[email protected]
BUG=408839
Review URL: https://codereview.chromium.org/519503002
Cr-Commit-Position: refs/heads/master@{#292554}
[MIDI] Make android MIDI port id unique
MIDI port id must be unique, as specified in the spec.
BUG=341423
Review URL: https://codereview.chromium.org/516893002
Cr-Commit-Position: refs/heads/master@{#292553}
Improve full-screen icon.
The new icon is a better fit in terms of size compared to the previous one.
Review URL: https://codereview.chromium.org/518493002
Cr-Commit-Position: refs/heads/master@{#292552}
[Android] Mark posted UI thread tasks as asynchronous
Chromium shares a message loop with Android on the browser UI thread.
This can cause problems when the associated Looper has a sync barrier,
preventing posted Chromium tasks from being dispatched until the
barrier is removed. Make this sharing more fair by marking all Chromium
Message tasks as asynchronous, avoiding stalls when there is a sync
barrier.
Note: This change is for gathering data about the perf impact and we'll
revert it before cutting a release branch.
BUG=407149,380781,407133
Review URL: https://codereview.chromium.org/512333002
Cr-Commit-Position: refs/heads/master@{#292551}
Try backing SkPicture with SkRecord in Chromium.
This is our first attempt, mostly to feel this out. Performance and
correctness problems are both possible. Please revert this if a benchmark even
smells funny.
That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over. This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.
BUG=
Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
Review URL: https://codereview.chromium.org/504823003
Cr-Commit-Position: refs/heads/master@{#292550}
Remove cevans@ from OWNERS files.
NOTRY=true
Review URL: https://codereview.chromium.org/524433003
Cr-Commit-Position: refs/heads/master@{#292549}
Teach the native viewport service to draw a Surface into itself
This teaches the native viewport service to accept a surface id from its
client and draw it into the native viewport. This won't work if the
client also tries to bind an onscreen context to the native viewport's
view id, so the surface initialization is lazy and only happens when
the client specifies a surface id. If a client does both it'll blow up.
[email protected]
Review URL: https://codereview.chromium.org/510553002
Cr-Commit-Position: refs/heads/master@{#292548}
Fix and re-enable the Feedback API Test.
This test should now be working after the fixes to the screenshotting code
that initialy had made it fail.
Also adding an OWNERS file for the Feedback API directory.
[email protected]
BUG=369886
Review URL: https://codereview.chromium.org/516083002
Cr-Commit-Position: refs/heads/master@{#292547}
Remove BrowserThread dependency from usb_service.
Instead of explicitly depending on specific browser threads the USB
service can assume that it is instantiated on BrowserThread::FILE (or
equivalent) and save a TaskRunner reference from this instantiation for
later use when called from other threads.
To reach BrowserThread::UI (required for DBus on Chrome OS) a reference
to the appropriate TaskRunner must be provided when calling
UsbService::GetInstance().
BUG=
Review URL: https://codereview.chromium.org/507503002
Cr-Commit-Position: refs/heads/master@{#292546}
Add a separate warning message for topSites permission.
The current warning is the generic "Read your browsing history"
warning. The new warning for topSites will be suppressed by
read only and read/write history warnings, and all hosts warning.
BUG=404334
Review URL: https://codereview.chromium.org/482953003
Cr-Commit-Position: refs/heads/master@{#292545}
Add tests to verify playback ends when audio/video durations differ.
In preparation for changing how we compute media time, add some tests to
verify the current behaviour.
BUG=370634
Review URL: https://codereview.chromium.org/517843003
Cr-Commit-Position: refs/heads/master@{#292544}
[Telemetry] Implement CanLaunchApplication and InstallApplication for Android.
This is in preparation for implementing the Trepn profiler.
BUG=
Review URL: https://codereview.chromium.org/510943002
Cr-Commit-Position: refs/heads/master@{#292543}
media: Remove FilterCollection.
Now we pass Demuxer and Renderer directly into Pipeline, and create TextRenderer
directly in Pipeline. As a result, we don't need FilterCollection anymore.
BUG=408602
TEST=All existing tests pass.
Review URL: https://codereview.chromium.org/511323003
Cr-Commit-Position: refs/heads/master@{#292542}
Readability review.
These CLs implement a simple frame recording and fetch "extension" for the Chromoting protocol, to allow sample sessions to be captured for performance testing.
The three main classes introduced are:
- HostExtensionSessionManager
This pulls logic for handling Chromoting extensions out of
ClientSession instances into a dedicated manager class.
It also introduces hooks through which extensions can
wrap or replace the Chromoting video encoder or capturer.
- VideoFrameRecorder
This allows a VideoEncoder to be wrapped to return a new
encoder that will optionally copy & deliver frames to the
VideoFrameRecorder before supplying them to the real
encoder.
- VideoFrameRecorderHostExtension
This extension uses a VideoFrameRecorder to allow a
connected client to start/stop recording, and to retrieve
the resulting frame data.
Original CLs:
crrev.com/402233003
crrev.com/339073002
crrev.com/372943002
crrev.com/462503002
BUG=260879
Review URL: https://codereview.chromium.org/468613002
Cr-Commit-Position: refs/heads/master@{#292541}
Re-enalbe "testSetGetBackgroundColor"
Background color issue should already be fixed by
crbug.com/391462
BUG=384559
Review URL: https://codereview.chromium.org/517153002
Cr-Commit-Position: refs/heads/master@{#292540}
Deflakify CastStreamingApiTest.EndToEnd, enabling it for Release builds.
An analysis was performed for sources of flakiness in this test. A
number of implementation problems have been resolved in recent changes,
with this change focusing on addressing problems with the test code
itself:
1. Do not require the color to match the tone at the same time. A/V
sync belongs in a perf test.
2. Do not require a color or tone to be held for a full half-second.
Instead, any momentary observation that matches expectations is
sufficient.
3. Only examine the content part of each video frame (i.e., exclude the
surrounding black borders caused by letterboxing).
4. Generate the source content using a canvas and
requestAnimationFrame(). The source content has a little "ball"
animating within it to ensure changing video frames are being sent
through end-to-end.
Also added AES keys to test end-to-end with encryption enabled.
This change re-enables the test for Release builds only. Once the test
has proven to be stable again, it will be re-enabled for Debug builds as
well. Baby steps...
BUG=396413
Review URL: https://codereview.chromium.org/515473004
Cr-Commit-Position: refs/heads/master@{#292539}
mac: Fix 2 bugs where "Access Address Book" prompt is incorrectly shown.
Don't show "Access Address Book" prompt if Autofill is disabled, the form has
the attribute autocomplete="off", or if Chrome doesn't think the form is
Autofillable.
BUG=398476
Review URL: https://codereview.chromium.org/512933004
Cr-Commit-Position: refs/heads/master@{#292538}
linux: Make RenderTextPango avoid clipping underlines.
Adjust underline positions so the lines won't get clipped. I
think that the inaccuracy may be occurring due to our
conversion from PangoFontDescriptions (usually containing a
point-based size) to a rounded pixel-based size and then
back to a PangoFontDescription. Luckily, RenderTextPango
will be replaced by RenderTextHarfBuzz soon.
Also delete some dead code in PlatformFontPango for
computing underline metrics.
BUG=393117
TEST=manual: checked that the "Import bookmarks now..."
underline is visible after setting my UI font to
"Ubuntu 11"
Review URL: https://codereview.chromium.org/509093004
Cr-Commit-Position: refs/heads/master@{#292537}
Suppress a few more failures on the Win GPU Debug FYI bots.
BUG=408251
[email protected]
Review URL: https://codereview.chromium.org/519523002
Cr-Commit-Position: refs/heads/master@{#292536}
ServiceWorker: Queue tasks until the registration proxy becomes ready
In [[Install]] algo. of the latest spec, register() resolves a promise
with a registration object after the worker enters the installation
process. This means the registration needs to set its .installing field
before the register promise is resolved.
But, before this patch, the registration cannot do so before resolving
the register promise because its proxy is set when the registration is
passed to the blink.
This change makes the registration queue notifications of worker version
and 'updatefound'. Once the proxy becomes ready, the registration handles
them.
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm
BUG=399533,406240
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker
Review URL: https://codereview.chromium.org/516873002
Cr-Commit-Position: refs/heads/master@{#292535}
Rename post_perf_builder_job.py -> request_build.py
Any thoughts?
BUG=
Review URL: https://codereview.chromium.org/510203002
Cr-Commit-Position: refs/heads/master@{#292534}
Manual fixups in content/child for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/511183002
Cr-Commit-Position: refs/heads/master@{#292533}
Revert of Fix the Copresence permission. (patchset #1 of https://codereview.chromium.org/523433002/)
Reason for revert:
This change causes a test failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/48008/steps/unit_tests/logs/stdio
Error:
[ RUN ] PermissionsTest.PermissionMessages
../../chrome/common/extensions/permissions/permission_set_unittest.cc:781: Failure
Value of: permission_info->message_id()
Actual: 65
Expected: PermissionMessage::kNone
Which is: 1
unexpected message_id for copresence
Looks like this change is the cause.
Original issue's description:
> Fix the Copresence permission.
>
> The initializer for the Copresence permission is malformed. It specifies the
> message id instead of the flag.
>
> [email protected]
> BUG=408843
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=408843
Review URL: https://codereview.chromium.org/520493002
Cr-Commit-Position: refs/heads/master@{#292532}
Add BlacklistLoad to IncidentType enum.
This value was added to the code in commit position 292033.
[email protected]
[email protected]
BUG=394352
NOTRY=true
Review URL: https://codereview.chromium.org/515313004
Cr-Commit-Position: refs/heads/master@{#292531}
Various Feedback fixes.
This CL fixes two issues.
. It brings up a scroll bar if the text in the feedback window doesn't fit in
the space available on screen (this happens when the user sets the page zoom
too 120% or above)
. Sets the focus to the description field when the feedback app starts.
[email protected]
BUG=295999,330139
Review URL: https://codereview.chromium.org/511393002
Cr-Commit-Position: refs/heads/master@{#292530}
Check for channel and flag before allowing demo mode.
If we're running a test image or have the --disable-demo-mode flag specified
we should not be launching demo mode. The channel check doesn't exist for the
HID screen. This CL moves the check into the main demo mode detector so if it
is called from anywhere, the check is always performed.
[email protected]
BUG=398271
Review URL: https://codereview.chromium.org/514273003
Cr-Commit-Position: refs/heads/master@{#292529}
Disable OAuth2Test.MergeSession
Test is flaky. See bug for details.
NOTRY=true
[email protected]
BUG=408867
Review URL: https://codereview.chromium.org/522453004
Cr-Commit-Position: refs/heads/master@{#292528}
Landing Recent QUIC Changes.
Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.
Merge internal change: 74239145
https://codereview.chromium.org/509203003/
Remove PacketType from QUIC because the QUEUED type is not used and the
other types can be reduced to a bool.
Merge internal change: 74148481
https://codereview.chromium.org/515003003/
Don't send a QUIC SCUP message until after handshake confirmed.
A server config update was occasionally being sent before the crypto
handshake was complete, causing the client to close the connection.
Merge internal change: 74132773
https://codereview.chromium.org/516713002/
Change TransmissionInfo's all_transmissions SequenceNumberSet* to
default to NULL, and only be present if there are multiple transmissions.
Estimated to save ~2% of CPU.
Merge internal change: 74076012
https://codereview.chromium.org/509073004/
Log the quic version for internal server tracing.
Not used in production.
Merge internal change: 74069715
https://codereview.chromium.org/514043002/
Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
deque.
Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
on tools/quic/end_to_end_test.cc.
Merge internal change: 74054196
https://codereview.chromium.org/514033002/
Unit test for empty packet closes QUIC connection bug.
Merge internal change: 74041239
https://codereview.chromium.org/495423011/
Log the QUIC transmission type in QUIC internal server trace visitor.
Not used in production.
Merge internal change: 73895739
https://codereview.chromium.org/514023002/
Not used in production. Log whether a QUIC packet sent was a crypto
packet or not for internal server side tracing.
Merge internal change: 73894063
https://codereview.chromium.org/515003002/
Fix a QUIC bug in which PING frames were not being ACK'd.
Merge internal change: 73837644
https://codereview.chromium.org/512933005/
[email protected]
Review URL: https://codereview.chromium.org/515303003
Cr-Commit-Position: refs/heads/master@{#292527}
Skia roll 60cc7d3:088f4b8
https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/516973003
Cr-Commit-Position: refs/heads/master@{#292526}
Fix bug with Android pop-up cancelation.
BUG=407994
TEST=as in bug
Review URL: https://codereview.chromium.org/518443003
Cr-Commit-Position: refs/heads/master@{#292525}
[telemetry] Retry unit tests after failures in setUpClass and setUpModule.
unittest produces a suite._ErrorHolder object in these cases. We can parse its description to figure out what class/module it is and what tests we have in that class/module.
BUG=405766
TEST=Make a TestCase fail setUpClass, run it with --retry-limit=3 and check for retries.
R=dpranke, tonyg
Review URL: https://codereview.chromium.org/515263003
Cr-Commit-Position: refs/heads/master@{#292524}
Add the actual location coordinates to the touch cancel event
BUG=366603
Review URL: https://codereview.chromium.org/469523003
Cr-Commit-Position: refs/heads/master@{#292523}
Revert of Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. (patchset #5 of https://codereview.chromium.org/471233003/)
Reason for revert:
Test is failing on a Blink bot on ChromeOS
Original issue's description:
> Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update.
>
> Add more checks to test to detect that the resource type of
> the URL request is indeed OBJECT.
> Would like to get this merged to the M38 branch.
>
> BUG=401755
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bfc3e122d6721ccc93f0f8b19dac4a3c2a0c947d
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=401755
Review URL: https://codereview.chromium.org/524483002
Cr-Commit-Position: refs/heads/master@{#292522}
ozone: Whitelist some libs for the embedded build
Also switch harfbuzz to internal by default to minimize deps.
BUG=178543
TEST=run the tool
TBR=bashi1
Review URL: https://codereview.chromium.org/509323004
Cr-Commit-Position: refs/heads/master@{#292521}
Fixed a crash while opening the file open/save dialogs on Windows 7 ASH.
The operations would get routed to the viewer process under the assumption that it was Windows 8
which would eventually crash while trying to open the metro dialogs which don't work on Windows 7.
Fix is to return false from the ShellDialogsDelegateWin::IsWindowInMetro function for anything below
Windows 8.
BUG=356475
Review URL: https://codereview.chromium.org/510223002
Cr-Commit-Position: refs/heads/master@{#292520}
Add jorgelo@ to all the chrome/common OWNERS files with IPC messages owners.
NOTRY=true
Review URL: https://codereview.chromium.org/522483002
Cr-Commit-Position: refs/heads/master@{#292519}
Add ChannelProxy benchmark to ipc_perftests.
This CL add a ChannelProxy equivalent of the Channel benchmark
to ipc_perftests.
To use it in the benchmark, TestIOThread is extracted from
mojo/system/ to base/test
TEST=IPChannelPerfTest.ChannelProxyPingPong
[email protected],[email protected],[email protected]
BUG=none
Review URL: https://codereview.chromium.org/488003003
Cr-Commit-Position: refs/heads/master@{#292518}
Remove obsolete fieldtrial related code.
BUG=308692
Review URL: https://codereview.chromium.org/513803005
Cr-Commit-Position: refs/heads/master@{#292517}
Fixed problem with incorrect use of $HOME (breaking multi user ChromeOS)
BUG=355227
TEST=visual
Review URL: https://codereview.chromium.org/515973003
Cr-Commit-Position: refs/heads/master@{#292516}
[NaCl SDK] nacl_io: add getnameinfo scaffolding
This initial version still returns ENOSYS.
Review URL: https://codereview.chromium.org/512603008
Cr-Commit-Position: refs/heads/master@{#292515}
Manual fixups for scoped_refptr operator T* removal in sync/
BUG=110610
Review URL: https://codereview.chromium.org/511173002
Cr-Commit-Position: refs/heads/master@{#292514}
Fix for ~ContentCaptureSubscription() after BrowserThreads are torn down.
While debugging flaky browser_tests, it was revealed that a
WebContentsVideoCaptureMachine could actually outlive the tear-down of
the BrowserThreadImpl for the UI thread. Not having been explicitly
stopped first, destructors in the object graph would execute clean up
code that would attempt operations that are invalid after the
BrowserThreadImpl for the UI thread has been torn down.
This change also includes a bunch of minor clean-ups.
BUG=396413
Review URL: https://codereview.chromium.org/514073002
Cr-Commit-Position: refs/heads/master@{#292513}
Blink roll 5d3187f:78d2b11
https://chromium.googlesource.com/chromium/blink/+log/5d3187faa8b0dc282ac6f16311c8ba96bfb91bd8..78d2b11092668ed42fc97d9a81290a3e226bed43
[email protected],[email protected]
Review URL: https://codereview.chromium.org/518573002
Cr-Commit-Position: refs/heads/master@{#292512}
aw: Ensure fallback tick unsets |block_invalidates_|
Currently, if |compositor_needs_continuous_invalidate_| is unset before
PostFallbackTick or FallbackTickFired, then the fallback ticks are
cancelled, but we never unset |block_invalidates_|, which will block
invalidates indefinitely.
Fix is simply always unset |block_invalidates_| even if we skip
the fallback tick.
BUG=408779
Review URL: https://codereview.chromium.org/512403002
Cr-Commit-Position: refs/heads/master@{#292511}
Fix athena_unittests dependency
BUG=None
TEST=athena_unittests run again
Review URL: https://codereview.chromium.org/517053002
Cr-Commit-Position: refs/heads/master@{#292510}
Remove implicit conversions from scoped_refptr to T* in chrome/renderer/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/506773002
Cr-Commit-Position: refs/heads/master@{#292509}
Change security warning links to point to localized help center article
BUG=402934
Review URL: https://codereview.chromium.org/515803002
Cr-Commit-Position: refs/heads/master@{#292508}
Print information on connected displays to VLOG(1)
Finding the root cause of display configuration bugs is harder without
knowing which displays were reported as connected.
BUG=none
Review URL: https://codereview.chromium.org/518553002
Cr-Commit-Position: refs/heads/master@{#292507}
Don't add surface callback to ack frame if compositor doesn't exist
In this case the code below will ack the frame immediately anyway.
TEST=BrowserTest.ShouldShowLocationBar
Review URL: https://codereview.chromium.org/515373003
Cr-Commit-Position: refs/heads/master@{#292506}
GuestView: Cleanup on Embedder process swap
BUG=408688
Test=Launch chrome://extensions with --enable-embedded-extension-options, open SPDY options, navigate to www.google.com, the "Options: SPDY Proxy Extension Options" entry should disappear from the Task Manager.
Review URL: https://codereview.chromium.org/514653003
Cr-Commit-Position: refs/heads/master@{#292505}
Browser changes for wiring up RequestContentScript API to shared memory
BUG=377978
Review URL: https://codereview.chromium.org/493633003
Cr-Commit-Position: refs/heads/master@{#292504}
Move Preload enum to BufferedDataSource.
Moving the Preload out of the content namespace and into BufferedDataSource
since that class is the primary reason this enum exists.
BUG=408338
Review URL: https://codereview.chromium.org/512413002
Cr-Commit-Position: refs/heads/master@{#292503}
Roll pdfium.
This brings in:
f105b19 No need to release resources in destructor of CPDF_ShadingObject
fdcc874 Restrict index not be greater than row_size in TIFF_PredictLine
405478d Use valid bpc value in LoadPalette() and ContinueToLoadMask()
a67da71 Fix a bug when looping through m_pCompData
96f8786 Bounds check before fixed-size memcmp() in CJPX_Decoder::Init().
[email protected]
Review URL: https://codereview.chromium.org/515983005
Cr-Commit-Position: refs/heads/master@{#292502}
Removed print_web_view_helper_win.cc
Removed win_pdf_metafile_for_printing gyp option.
Removed WIN_PDF_METAFILE_FOR_PRINTING define.
BUG=170859
TBR=yzshen
Review URL: https://codereview.chromium.org/516823002
Cr-Commit-Position: refs/heads/master@{#292501}
Remove built-in component and test targets from GN.
Previously "component" was a built-in function that forwarded to source_set, static_library, or shared_library depending on the value of component_mode. And test was a built-in function that forwarded to executable.
These can be expressed as templates instead. This patch removes the built-in versions and implements the templates in the master build config file.
Forwarding all of the variables for these is somewhat tedious, but I still prefer not to add a new concept for this, since it will be rarely used and less clear what is happening.
With the updated BUILDCONFIG.gn file, the build will work with both the old and new GN version (the built-in version of component and test take precedence). When the new GN binary is pushed, we can remove the references to component_mode.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/516703005
Cr-Commit-Position: refs/heads/master@{#292500}
Switch to Bluetooth pairing API
BUG=381007
Review URL: https://codereview.chromium.org/517023002
Cr-Commit-Position: refs/heads/master@{#292499}
Allow requesting a copy of a surface.
Instead of requesting a layer, a copy of the entire surface is requested. Actually handling the request isn't implemented yet.
BUG=397730
Review URL: https://codereview.chromium.org/509193002
Cr-Commit-Position: refs/heads/master@{#292498}
Handle incorrect promise resolving
Due to an issue in the CDM, when a session to be loaded is not
found, the CDM calls PromiseResolve() instead of the expected
PromiseResolveWithSession(""). This change detects this situation
and handles it properly.
BUG=408337
TEST=existing EME tests pass
Review URL: https://codereview.chromium.org/518523002
Cr-Commit-Position: refs/heads/master@{#292497}
Move common code and variables from audio/video sender to frame sender.
More cleanup to come.
BUG=406622
Review URL: https://codereview.chromium.org/514263002
Cr-Commit-Position: refs/heads/master@{#292496}
Fix the Copresence permission.
The initializer for the Copresence permission is malformed. It specifies the
message id instead of the flag.
[email protected]
BUG=None.
Review URL: https://codereview.chromium.org/523433002
Cr-Commit-Position: refs/heads/master@{#292495}
Force scales 125% and lower down to 100%
125 comes from:
150% == 144 logpixels
125% == 120 logpixels
100% == 96 logpixels
[email protected], [email protected], [email protected]
BUG=395425
Review URL: https://codereview.chromium.org/516743002
Cr-Commit-Position: refs/heads/master@{#292494}
High resolution timer fix reland
On Windows the message pump code tried to manage the systemwide timer
resolution to fire delayed tasks with better than 15ms resolution but
it is buggy.
This is https://codereview.chromium.org/395913006
please see that review for rationale.
BUG=153139
TBR=jamesr,darin
TEST=included, also see bug for manual verification.
Review URL: https://codereview.chromium.org/509223002
Cr-Commit-Position: refs/heads/master@{#292493}
Move 'Extensions' to the main menu for settings-in-a-window
BUG=407162
Review URL: https://codereview.chromium.org/511923002
Cr-Commit-Position: refs/heads/master@{#292492}
Delete Privet filesystem code
The Privet filesystem code is unmaintained, and it isn't aligned with
PrivetV3. Remove it for now.
BUG=
Review URL: https://codereview.chromium.org/492693004
Cr-Commit-Position: refs/heads/master@{#292491}
Use both APIs for enabling accessibility
https://codereview.chromium.org/491483006
BUG=406622
Review URL: https://codereview.chromium.org/497263002
Cr-Commit-Position: refs/heads/master@{#292490}
Cronet license now includes boringssl instead of openssl.
BUG=390267
Review URL: https://codereview.chromium.org/513413002
Cr-Commit-Position: refs/heads/master@{#292489}
Try to use URL and title of the printed frame for header and footer.
Removed header_footer_info_ member.
BUG=263710
Review URL: https://codereview.chromium.org/510253002
Cr-Commit-Position: refs/heads/master@{#292488}
Manual fixups in media code for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/515093003
Cr-Commit-Position: refs/heads/master@{#292487}
Move ViewMsg_Stop from RenderViewHost to RenderFrameHost.
This CL is a reland of https://codereview.chromium.org/479403004/ without the part enabling the test. The test is failing due to several bugs, some of which are fixed in this CL and some others lingering. The goal is to reland these fixes without enabling the test and fixing the rest of the issues in followup changes.
BUG=304341
[email protected], [email protected]
Review URL: https://codereview.chromium.org/509063004
Cr-Commit-Position: refs/heads/master@{#292486}
Indexed DB: Restore content-type to deserialized Blobs
The Blob type was serialized/restored correctly on the Blink side, but
not on the Chromium side, so when reading a Blob as a stream the
type would be unset.
BUG=408120
[email protected]
TEST=https://codereview.chromium.org/509213005
Review URL: https://codereview.chromium.org/511373002
Cr-Commit-Position: refs/heads/master@{#292485}
Update the test OCSP server to use SHA-256 for the generated test server certificate
BUG=401365
Review URL: https://codereview.chromium.org/514083002
Cr-Commit-Position: refs/heads/master@{#292484}
Clears focus on gesture event.
This will cancel the virtual keyboard.
BUG=404110, 403813
[email protected]
TEST=manually && athena_unittests
Review URL: https://codereview.chromium.org/512963002
Cr-Commit-Position: refs/heads/master@{#292483}
Simplify IOSurface CoreAnimation code: Part 1
This is now only used in the context of the browser compositor, so
move the code there.
Move the software layer code over to compositor as well.
Rename structures to de-empahsize 'compositing' (everything is running
through the compositor now).
BUG=314190
[email protected]
Review URL: https://codereview.chromium.org/511923004
Cr-Commit-Position: refs/heads/master@{#292482}
Revert of Revert of Fix assorted issues with remote CoreAnimation (patchset #1 of https://codereview.chromium.org/517733002/)
Reason for revert:
Patch was reverted in error
Original issue's description:
> Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/)
>
> Reason for revert:
> Speculatively reverting to see if this helps the mac perf bots:
> https://code.google.com/p/chromium/issues/detail?id=408673
>
> Original issue's description:
> > Fix assorted issues with remote CoreAnimation
> >
> > These issues came up while running for a few days with the
> > flag --enable-remote-core-animation.
> >
> > Fix flashes of old frames by hooking up the DiscardBackbuffer (which
> > happens when being made non-visible) to re-set the CAContext and
> > CALayer (so the browser gets a new one with new content for the next
> > frame).
> >
> > Add support for disabling vsync by using setNeedsDisplay to draw.
> >
> > Change the backpressure mechanism to rely on the browser to apply
> > backpressure in its compositor via the cc:: output surface.
> >
> > Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
> > to the real GL API while in the CoreAnimation callback.
> >
> > BUG=312462
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8
>
> [email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=312462
>
> Committed: https://chromium.googlesource.com/chromium/src/+/07539c445c9fa7161b3da9031cf440a2b657dd18
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=312462
Review URL: https://codereview.chromium.org/517143002
Cr-Commit-Position: refs/heads/master@{#292481}
[NaCl SDK] Update build_sdk.py to display Cr-Commit-Position in README.
BUG=none
[email protected], [email protected]
Review URL: https://codereview.chromium.org/495423010
Cr-Commit-Position: refs/heads/master@{#292480}
Blink roll fd759a5:5d3187f
https://chromium.googlesource.com/chromium/blink/+log/fd759a525b9eb5c4889947a317439bd510b2a969..5d3187faa8b0dc282ac6f16311c8ba96bfb91bd8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/517783002
Cr-Commit-Position: refs/heads/master@{#292479}
[NaCl SDK] Add pepper_38 to naclsdk_manifest2.json
[email protected]
Review URL: https://codereview.chromium.org/514333002
Cr-Commit-Position: refs/heads/master@{#292478}
AppView internal API doesn't need to go through ExtensionsAPIClient anymore, since AppView is now in extensions.
BUG=352290
Review URL: https://codereview.chromium.org/498303002
Cr-Commit-Position: refs/heads/master@{#292477}
Remove codes related deleting Blink or WebKit repository while processing revisions.
If the script is switching between Blink and WebKit during bisect, over a year it's been only blink
for chromium and we don't need these codes.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/513253003
Cr-Commit-Position: refs/heads/master@{#292476}
Roll tools/swarming_client/ to e7d8b988423ff1966d64db3ef7ca766296f9b0c1.
$ git log b8aeeaef0..e7d8b9884 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-08-26 vadimsh Fix cacert.pem extraction from zip.
2014-08-26 kmg Add output location on isolateserver to JSON
2014-08-25 vadimsh Make net.url_open reuse connections again.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/514173002
Cr-Commit-Position: refs/heads/master@{#292475}
Documentation updates for chrome.tabCapture.
BUG=338449
Review URL: https://codereview.chromium.org/503503003
Cr-Commit-Position: refs/heads/master@{#292474}
Remove .apk from dangerous file extension list
BUG=404472
Review URL: https://codereview.chromium.org/512983003
Cr-Commit-Position: refs/heads/master@{#292473}
[telemetry] Disable extraneous IPPET features.
-state is disabled by default.
BUG=336558
TEST=None.
R=tonyg
NOTRY=True
Review URL: https://codereview.chromium.org/512383002
Cr-Commit-Position: refs/heads/master@{#292472}
Update ES2 CTS Windows expectations.
These tests were not previously triggered, but were previously
failing.
BUG=408251
[email protected]
Review URL: https://codereview.chromium.org/512353003
Cr-Commit-Position: refs/heads/master@{#292471}
Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update.
Add more checks to test to detect that the resource type of
the URL request is indeed OBJECT.
Would like to get this merged to the M38 branch.
BUG=401755
Review URL: https://codereview.chromium.org/471233003
Cr-Commit-Position: refs/heads/master@{#292470}
resources: Optimize the resources in component/resources.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/509093003
Cr-Commit-Position: refs/heads/master@{#292469}
athena: Fix overview mode for split-view mode.
The changes in this patch:
. If in split-view mode, the left and right windows remain fixed in the overview
state.
. Selecting either of the left/right windows returns to the split-view mode with
the same windows.
. Selecting one of the other windows in the stack gets out of split-view mode,
and switches to the selected window.
In subsequent patches:
. Allow dragging a window from the stack on top of the left/right windows to
switch that window and remain in split-view mode.
. Allow dragging one of the left/right windows to get out of split-view mode and
switch to that window.
BUG=404119
[email protected]
Review URL: https://codereview.chromium.org/495193003
Cr-Commit-Position: refs/heads/master@{#292468}
Manual fixups in remoting/ for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/511313002
Cr-Commit-Position: refs/heads/master@{#292467}
Ensure syncer::internal::GetComputerName returns a UTF-8 string.
Prior to this change, on Windows, GetComputerName resulted in a call to
GetComputerNameA, which returns an ANSI string (not ASCII, not UTF-8).
Call GetComputerNameW instead and convert the returned wide string to
UTF-8.
Tested by adding U+00AB to the computer name. Saw in about:sync the
name contained a U+FFFD instead (symbol for unrepresentable character).
Performed sync dashboard clear, applied patch, saw that the name
correctly contained U+00AB.
This CL does not address corrupted device info that's already in the
field. Depending on impact that may be addressed in a future CL.
BUG=406470
Review URL: https://codereview.chromium.org/479703004
Cr-Commit-Position: refs/heads/master@{#292466}
Fix dialog screen position.
https://codereview.chromium.org/478033004/ broke the dialog screen, causing it
to cover the title-bar in apps v2. This fixes it be adding an explicit <div>
representing the window client area (the logical <body> for apps v2).
Review URL: https://codereview.chromium.org/507013002
Cr-Commit-Position: refs/heads/master@{#292465}
Add relaunch into ASH and desktop support for Chrome on Windows 7.
This is on similar lines as Windows 8. The difference being launching into ASH on Windows 8 launches
ASH into Windows 8 metro environment.
Reused the existing tunneling we have via delegate_execute to ensure that the calling process is terminated
before launching the browser into the other environment.
Removed the erstshile Open Ash Desktop and Close Ash Desktop menu options as they are no longer needed and they
don't work correctly anyways.
BUG=356475
Review URL: https://codereview.chromium.org/498573003
Cr-Commit-Position: refs/heads/master@{#292464}
Revert of Revert of Remove the last piece of deprecated synchronous IO code. (patchset #1 of https://codereview.chromium.org/509893002/)
Reason for revert:
https://codereview.chromium.org/510893003/ fixed the ledger bot, so I am going to revert this revert CL.
Original issue's description:
> Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/)
>
> Reason for revert:
> Build failure on Google Chrome ChromeOS:
>
> http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164
>
> Original issue's description:
> > Remove the last piece of deprecated synchronous IO code.
> >
> > BUG=337096
> > TEST=bots
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193
>
> [email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> BUG=337096
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3e8c19c89c16fe8a7c2dfe0cae2990cd4a004339
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
BUG=337096
Review URL: https://codereview.chromium.org/518433002
Cr-Commit-Position: refs/heads/master@{#292463}
Make a ShowExtensionActionPopup function
More-or-less consolidate calls to show an ExtensionAction's
popup into ExtensionActionAPI. This has the happy effect of
reducing the amount of piping we have to do in the UI code
(cutting a few steps out of the Browser -> BrowserWindow ->
Toolbar -> BrowserActionsContainer -> BrowserActionView chain),
and, more importantly, lets page action command executions
happen in the BrowserActionsContainer when the redesign is
enabled.
Hopefully, this means that we can stop showing page actions
in the location bar with the switch enabled - but that's
another patch.
BUG=397259
[email protected] (minor changes to test_browser_window)
Review URL: https://codereview.chromium.org/489183005
Cr-Commit-Position: refs/heads/master@{#292462}
Skia roll dc53701:60cc7d3
https://skia.googlesource.com/skia/+log/dc53701216c0e9f98eacf6c0cda769ebbd200b59..60cc7d353b2adc8fcc1712e1f7a965e70121ebcc
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/510393002
Cr-Commit-Position: refs/heads/master@{#292461}
Mojo: Fix two bugs in content handling
1. URLLoaders can't be reused, so we need to construct one
per-load. This became too gnarly to handle with callbacks
so I put it back to having a loader object that owns the
URLLoader.
2. The relevant URLLoader needs to be passed to
ContentHandler::OnConnect() so that it stays alive long
enough to read the entire response.
BUG=
Review URL: https://codereview.chromium.org/513573002
Cr-Commit-Position: refs/heads/master@{#292460}
Re-Enable Most OmniboxViewTests
They were disabled because they flakily time out. Now with the switch
to Aura, I don't see timeouts anymore. All the tests I enable in this
changelist pass 10/10 on my machine.
Trybots seem okay with it.
BUG=131179,165765
Review URL: https://codereview.chromium.org/517683002
Cr-Commit-Position: refs/heads/master@{#292459}
Always enable optimize_jni_generation on non-WebView builds.
It seems that the cons are fairly weak and the benefits might be worth it.
This flag breaks WebView builds.
BUG=None
Review URL: https://codereview.chromium.org/502743002
Cr-Commit-Position: refs/heads/master@{#292458}
Don't use libvpx if it is disabled in GN build
This change excludes libvpx from linking if it is disabled. This is
needed to enable linking Chrome with GN, since libvpx is not building
with GN yet.
Review URL: https://codereview.chromium.org/501153003
Cr-Commit-Position: refs/heads/master@{#292457}
Move base64-urlsafe helpers to jwk.{cc,h}
BUG=407858
Review URL: https://codereview.chromium.org/504413004
Cr-Commit-Position: refs/heads/master@{#292456}
[Mac] Add tab and keyboard navigation to the new avatar bubble
Tabbing should navigate through all the visible controls.
I've changed the EditablePhotoButton to actually be a button and
not just an image, so that tabbing and pressing enter actually
works.
BUG=405056
Review URL: https://codereview.chromium.org/489143002
Cr-Commit-Position: refs/heads/master@{#292455}
Blink roll 180973:181040
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180973%3A181040&mode=html
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/512283002
Cr-Commit-Position: refs/heads/master@{#292454}
[Sync] Rename FailedDataTypesHandler -> DataTypeStatusTable
Simple rename patch, in preparation for making the DataTypeStatusTable
copy-able and having it track more than just errors.
BUG=368834
Review URL: https://codereview.chromium.org/513543004
Cr-Commit-Position: refs/heads/master@{#292453}
HistoryService fixups for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/514233002
Cr-Commit-Position: refs/heads/master@{#292452}
Use name() instead of toString() and fix comparison order in ModelType.
BUG=none
Review URL: https://codereview.chromium.org/511253002
Cr-Commit-Position: refs/heads/master@{#292451}
Add IE PirateMark to tough_filters_cases page set.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/514143003
Cr-Commit-Position: refs/heads/master@{#292450}
Add UMA for droppedframes count
Adding droppedframecount UMA to monitor videoplayback quality. Metric gets logged only if the pipeline has video & has decoded atleast one video frame.
BUG=
R=dalecurtis
Review URL: https://codereview.chromium.org/497913002
Cr-Commit-Position: refs/heads/master@{#292449}
Cleanup: Remove misc unneeded grit includes.
Review URL: https://codereview.chromium.org/512663002
Cr-Commit-Position: refs/heads/master@{#292448}
Fix compiled action dependencies in GN.
The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script.
This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit.
[email protected]
Review URL: https://codereview.chromium.org/505403002
Cr-Commit-Position: refs/heads/master@{#292447}
Remove image color profiles from all clank assets.
Our designers generated assets that do not use sRGB color profile
and this makes libpng unhappy. According to jreck@ Android does not use
these profiles. This CL removes all these color profiles using this command:
find . -type f -name "*.png" -exec convert {} -strip {} \;
BUG=394138
[email protected], [email protected]
[email protected]
Review URL: https://codereview.chromium.org/510423002
Cr-Commit-Position: refs/heads/master@{#292446}
Fix most of the "gn check" errors in ui/*
Some errors remain but these are circular includes that can't be fixed in the build files only.
Enable views_unittests and wm_unittests now that they compile
BUG=
[email protected], [email protected]
Review URL: https://codereview.chromium.org/513313002
Cr-Commit-Position: refs/heads/master@{#292445}
Removed unnecessary apps from logPrivate API whitelist.
BUG=408429
TEST=none
TBR=miket
Review URL: https://codereview.chromium.org/515313002
Cr-Commit-Position: refs/heads/master@{#292444}
MacViews: Get ImageTest to pass
Mac does not use Skia image natively even if TOOLKIT_VIEWS=1.
BUG=378134
Review URL: https://codereview.chromium.org/517723002
Cr-Commit-Position: refs/heads/master@{#292443}
Fixups in TemplateURLService for scoped_refptr operator T* removal
BUG=110610
Review URL: https://codereview.chromium.org/515303002
Cr-Commit-Position: refs/heads/master@{#292442}
Cast: Fix memory leak in cast_unittests
Testing clock needs an owner. Put a scoped_ptr<> to where it was first
created.
BUG=400728
Review URL: https://codereview.chromium.org/488133005
Cr-Commit-Position: refs/heads/master@{#292441}
Verify promise type before casting.
If a CDM calls the wrong Resolved() method to resolve a promise, the
promise is cast to the wrong type and causes a crash. This fixes the
problem by verifying that the promise is the correct type before
casting it.
BUG=408319
TEST=existing EME tests pass
Review URL: https://codereview.chromium.org/515753002
Cr-Commit-Position: refs/heads/master@{#292440}
Revert "ozone: evdev: Use tracking id for TouchEvent finger id"
This broke fling.
This reverts commit f1e78836b0c4c44b5a30031761c79d13e4e9e8f7.
TBR=sadrul,alexst
NOTRY=true
Review URL: https://codereview.chromium.org/514303002
Cr-Commit-Position: refs/heads/master@{#292439}
Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/)
Reason for revert:
Speculatively reverting to see if this helps the mac perf bots:
https://code.google.com/p/chromium/issues/detail?id=408673
Original issue's description:
> Fix assorted issues with remote CoreAnimation
>
> These issues came up while running for a few days with the
> flag --enable-remote-core-animation.
>
> Fix flashes of old frames by hooking up the DiscardBackbuffer (which
> happens when being made non-visible) to re-set the CAContext and
> CALayer (so the browser gets a new one with new content for the next
> frame).
>
> Add support for disabling vsync by using setNeedsDisplay to draw.
>
> Change the backpressure mechanism to rely on the browser to apply
> backpressure in its compositor via the cc:: output surface.
>
> Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
> to the real GL API while in the CoreAnimation callback.
>
> BUG=312462
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=312462
Review URL: https://codereview.chromium.org/517733002
Cr-Commit-Position: refs/heads/master@{#292438}
[Telemetry] Raise timeout on maps smoothness test.
It's timing out on some android bots and from a local run, it seems
to just be legitimately slower than the default 60s timeout.
BUG=405381
Review URL: https://codereview.chromium.org/510413002
Cr-Commit-Position: refs/heads/master@{#292437}
Local discovery fixups for scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/513283002
Cr-Commit-Position: refs/heads/master@{#292436}
Combine storage_browser_export.h and storage_common_export.h
BUG=338338
[email protected]
Review URL: https://codereview.chromium.org/512253002
Cr-Commit-Position: refs/heads/master@{#292435}
Rename run-bisect-perf-regression.cfg -> auto_bisect/bisect.cfg
If this is submitted, then cl/74264031 should also be submitted so that the perf dashboard correctly makes patches.
Any thoughts?
BUG=
Review URL: https://codereview.chromium.org/511043002
Cr-Commit-Position: refs/heads/master@{#292434}
Don’t reset the page id when the browser takes the navigation.
When the browser takes the navigation, the current page doesn’t change, so it makes no sense to change the page id.
This reverts a58db8b018960641d07dc72d9ff68b0f86f4b07b.
BUG=407376
TEST=stuff is green
Review URL: https://codereview.chromium.org/511263002
Cr-Commit-Position: refs/heads/master@{#292433}
Manual fixups in compositor code scoped_refptr operator T* removal.
BUG=110610
Review URL: https://codereview.chromium.org/514123002
Cr-Commit-Position: refs/heads/master@{#292432}
Better error message in cc PRESUBMIT
PRESUBMIT checks for usage of FIXME, so added that to error message.
Review URL: https://codereview.chromium.org/515063004
Cr-Commit-Position: refs/heads/master@{#292431}
Adds the test expectations of home card bounds.
BUG=403813
[email protected]
TEST=athena_unittests
Review URL: https://codereview.chromium.org/516643005
Cr-Commit-Position: refs/heads/master@{#292430}
Manual fixups for scoped_refptr operator T* removal in base/
BUG=110610
Review URL: https://codereview.chromium.org/511153002
Cr-Commit-Position: refs/heads/master@{#292429}
Handles proxy authentication request in ProxyResolvingClientSocket.
This will make the WebRTC connection work under NTLM/Kerberos using the default credential without prompting the user.
BUG=395614
Review URL: https://codereview.chromium.org/414523005
Cr-Commit-Position: refs/heads/master@{#292428}
Force software rasterization on ThreadTimesCompositorCases benchmark.
compositor-perf team is using these benchmarks for tracking compositor
performance primarily in software raster path, so forcing software raster.
BUG=407927
Review URL: https://codereview.chromium.org/516623002
Cr-Commit-Position: refs/heads/master@{#292427}
Fixing GestureNav on HDPI displays.
The GestireNav screenshot dimensions are density-independent, because when we capture the screenshot we scale it to RVH's bounds: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/navigation_entry_screenshot_manager.cc&q=navigation_entry_sc&sq=package:chromium&type=cs&l=136
Thus we don't need to scale it again when we paint during the overscroll gesture.
BUG=402280
Review URL: https://codereview.chromium.org/507083002
Cr-Commit-Position: refs/heads/master@{#292426}
Roll grit to 175.
This fixes an issue with invalid JSON being generated as example values
for policies on Windows, and points to the documentation for complex
policies on Windows.
BUG=381627
Review URL: https://codereview.chromium.org/511993003
Cr-Commit-Position: refs/heads/master@{#292425}
cc: Remove OutputSurface::SetThrottleFrameProduction()
And it doesn't have its body :)
[email protected]
BUG=NONE
TEST=NONE(non functional change)
Review URL: https://codereview.chromium.org/515573005
Cr-Commit-Position: refs/heads/master@{#292424}
Added missing test cases related to long pressing on input field.
IME Visibility status check test case is missing when we do long
press on different kind of empty and non-empty input fields. This patch
takes care of adding missing test cases for the same.
BUG=
Review URL: https://codereview.chromium.org/516843005
Cr-Commit-Position: refs/heads/master@{#292423}
[Telemetry] Fix idle wakeup reporting in the face of dead processes
Telemetry does not account for process death when computing deltas of various process statistics over a browser run.
CPU stats are currently stored in a dictionary of POD types aggregated by process type which gives no room for separating dead processes over a run.
Ultimately the goal is to report CPU stats in the timeline on a per-process basis.
Towards this goal and to fix counting of dead processes, this CL adds an IdleStatsData object which inherits from TimelineData. IdleStatsData keeps
track of idle wake ups by PID and is able to omit processes which have died during a run from the final reported result.
BUG=343373
Review URL: https://codereview.chromium.org/501813002
Cr-Commit-Position: refs/heads/master@{#292422}
Mac: Update sheet position when bookmark bar is shown or hidden.
In r272421, I changed sheet repositioning on window resize to be based on
NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification
because it tracks window resizing much more smoothly.
That caused this problem where if the browser window is vertically maximized
(or is in fullscreen), the window size does not change when the bookmark bar
is shown or hidden.
The old code has a different bug however. If the browser window is not
vertically maximized, showing or hiding the bookmark bar does not change the
browser content view's frame. It moves up or down to follow the window resize
but its frame relative to its superview remains the same.
I settled for adding code to explicitly update the sheet's position when the
bookmark bar is shown or hidden.
BUG=407509
Review URL: https://codereview.chromium.org/502413004
Cr-Commit-Position: refs/heads/master@{#292421}
Extensions-related fixups for scoped_refptr conversion operator removal.
BUG=110610
[email protected]
Review URL: https://codereview.chromium.org/510313002
Cr-Commit-Position: refs/heads/master@{#292420}
Omnibox.mojom: make input_string non-nullable.
The bug in JavaScript encoder that prevented us from doing so has been fixed.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/509173003
Cr-Commit-Position: refs/heads/master@{#292419}
Update host compiler version info for android webview.
The android webview build now uses clang when building for host; update
the gyp variables appropriately to make sure we use reasonable compiler
flags.
BUG=377684
Review URL: https://codereview.chromium.org/516723004
Cr-Commit-Position: refs/heads/master@{#292418}
cc: Remove and Create the correct tiles when resizing live tiles rect
When removing tiles, we need to remove everything outside the live
tiles rect even if it has borders inside the live tiles rect. The
DifferenceIterator includes borders when deciding if a tile is in the
included rect, so tiles that are only in the included rect with a border
were not being removed from the tiling. This lead to us having tiles
outside the rect, and to creating a tile that already existed.
When adding tiles, the same problem existed. The DifferenceIterator
includes borders when deciding which tiles are to be excluded, so a
tile that was inside the old live tiles rect with borders only would
not have existed, but it would be excluded by the DifferenceIterator.
This prevented us from making tiles that were inside the live tiles
rect.
Depends on: https://codereview.chromium.org/513903002/
[email protected], [email protected], enne, vmpstr
BUG=405427
Review URL: https://codereview.chromium.org/505913003
Cr-Commit-Position: refs/heads/master@{#292417}
pdf: Move PepperPDFHost into the pdf component.
Move PepperPDFHost out of //chrome into the pdf component at //components/pdf.
With this change, the IPC messages in the component is used only by the
component itself, and nothing outside of the component uses these IPC messages
anymore.
BUG=401242
[email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/505243003
Cr-Commit-Position: refs/heads/master@{#292416}
DevTools: Restore embedded devtools manager unit test checks after switching service worker inspection on the main thread.
TBR=yurys, horo
BUG=404355
Review URL: https://codereview.chromium.org/515593004
Cr-Commit-Position: refs/heads/master@{#292415}
Update V8 to version 3.29.27 (based on bleeding_edge revision r23491).
[email protected]
Review URL: https://codereview.chromium.org/512933008
Cr-Commit-Position: refs/heads/master@{#292414}
Fix broken path in GLES2 CTS.
AppendSwitch was casting all directories to lower case, causing the tests
to early-out and return as always passed even before they create the test
window.
BUG=408251
Review URL: https://codereview.chromium.org/500133005
Cr-Commit-Position: refs/heads/master@{#292413}
Use ApiUnitTest for storage API tests (storage_api_unittest and storage_frontend_unittest).
Make these tests and settings_quota_unittest run in extensions_unittests.
Move a test that depends on sync (not available in the extensions module) to settings_sync_unittest.
Depends on previous CL: https://chromiumcodereview.appspot.com/461273003/
BUG=397164
Review URL: https://codereview.chromium.org/472343003
Cr-Commit-Position: refs/heads/master@{#292412}
Revert of NaCl: Update revision in DEPS, r13666 -> r13668 (patchset #1 of https://codereview.chromium.org/513933003/)
Reason for revert:
attempting to fix compile failures.
Original issue's description:
> NaCl: Update revision in DEPS, r13666 -> r13668
>
> This pulls in the following Native Client changes:
>
> r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
> r13668: (noelallen) Force rebuild on cmd change.
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ba2092ce9ac0792098dcca59f9a224e13825dcd5
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/509413002
Cr-Commit-Position: refs/heads/master@{#292411}
Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 of https://codereview.chromium.org/512693004/)
Reason for revert:
I'm reverting this.
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...
should have triggered a compile.
Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> [email protected]
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b
[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=109173
Review URL: https://codereview.chromium.org/512303002
Cr-Commit-Position: refs/heads/master@{#292410}
Fix resources grit paths.
BUG=None
[email protected]
[email protected]
TEST=compile succeeds
Review URL: https://codereview.chromium.org/508283003
Cr-Commit-Position: refs/heads/master@{#292409}
[Android] Test IME and select action bar behavior after cut
Ime should not be dismissed and Select action bar should be dismissed in
case a cut operation is performed on any input field. Add test case
to check this.
Review URL: https://codereview.chromium.org/508993002
Cr-Commit-Position: refs/heads/master@{#292408}
Renaming CreateShillConfiguration argument for clarification.
Renaming from 'settings' to the more informative 'user_settings'.
BUG=NONE
Review URL: https://codereview.chromium.org/513143004
Cr-Commit-Position: refs/heads/master@{#292407}
Add/improve tracing in navigation.
This CL adds tracing statement for the navigation functionality within Chrome and modifies some of the existing tracing already in place.
Review URL: https://codereview.chromium.org/498883002
Cr-Commit-Position: refs/heads/master@{#292406}
Make single shell call in _SetScalingGovernorInternal
Changed implementation to make a single shell call, rather than
pushing files and executing several shell calls.
When running telemetry unittests on android, reduces total execution
time about 12%.
BUG=379378
Review URL: https://codereview.chromium.org/514123005
Cr-Commit-Position: refs/heads/master@{#292405}
Manual fixups for scoped_refptr operator T* removal in ipc/
BUG=110610
Review URL: https://codereview.chromium.org/512153002
Cr-Commit-Position: refs/heads/master@{#292404}
Manual fixups for scoped_refptr conversion operator cleanup in mojo/
BUG=110610
Review URL: https://codereview.chromium.org/512063003
Cr-Commit-Position: refs/heads/master@{#292403}
Re-focus node with Android accessibility focus when it moves
This is a workaround for an Android accessibility bug - when the object with accessibility focus moves, Android doesn't update the bounds of accessibility focus on the screen, even if we send a WINDOW_CONTENT_CHANGED event.
With this change, we keep track of the bounding rect of the node with accessibility focus, and if it changes, we move focus to the document and then back to this node, which works around the issue.
No visual flicker was observed when testing on multiple devices. Refreshable braille displays flicker briefly.
BUG=407871
Review URL: https://codereview.chromium.org/505423002
Cr-Commit-Position: refs/heads/master@{#292402}
Skia roll b2f7fce:dc53701
https://skia.googlesource.com/skia/+log/b2f7fce9e034c3b6749e75a129e7836df3529706..dc53701216c0e9f98eacf6c0cda769ebbd200b59
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/517643002
Cr-Commit-Position: refs/heads/master@{#292401}
FileAPI/sync file system cleanups for scoped_refptr operator T* cleanup.
BUG=110610
Review URL: https://codereview.chromium.org/515093002
Cr-Commit-Position: refs/heads/master@{#292400}
New SimpleCache Entry test for duplicate dooms.
Adds a regression test for bug 317138. This test is interesting
because it generates exactly the same stacks that we're seeing in
crash reports on that bug. This is a good regression test, so I
suggest we land it, as well as look at it for more confidence that
our fix to bug 317138 is the right fix.
[email protected],[email protected]
BUG=317138
Review URL: https://codereview.chromium.org/509973002
Cr-Commit-Position: refs/heads/master@{#292399}
Battery Status API: add UMA logging for Linux.
Adds UMA logging to track how many batteries are reported
by the system at the start of Battery Status API.
BUG=
Review URL: https://codereview.chromium.org/480113003
Cr-Commit-Position: refs/heads/master@{#292398}
Updating trunk VERSION from 2139.0 to 2140.0
Cr-Commit-Position: refs/heads/master@{#292397}
[GCM] Extracting GCMConnectionObserver from GCMAppHandler
Extracting GCMConnectionObserver from GCMAppHandler
* Updating consuming code: GCMInvalidationBridge
* Updating GCMAppHandler overrides
* Updating tests for GCMDriverDesktop
BUG=407841
[email protected]
Review URL: https://codereview.chromium.org/515763002
Cr-Commit-Position: refs/heads/master@{#292396}
Mark android supports H264 main/high profile
Most hardware OEMs provides codecs to support H264 main/high profile.
The current way of declaring them as unsupported is too restrictive.
BUG=407741
Review URL: https://codereview.chromium.org/506283002
Cr-Commit-Position: refs/heads/master@{#292395}
Introduce @CalledByReflection annotation.
BUG=163393
Review URL: https://codereview.chromium.org/509753002
Cr-Commit-Position: refs/heads/master@{#292394}
ExtensionOptionsGuest: Fixed spacing
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/517593002
Cr-Commit-Position: refs/heads/master@{#292393}
Changes exception for gyp files to only gyp files in build/
I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.
BUG=109173
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/512693004
Cr-Commit-Position: refs/heads/master@{#292392}
Align the checkbox with the first line of the text.
BUG=293702
Review URL: https://codereview.chromium.org/469653002
Cr-Commit-Position: refs/heads/master@{#292391}
Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (patchset #3 of https://codereview.chromium.org/511873002/)
Reason for revert:
Creates timeout failures on a lot of inspector/ tests in Blink:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/33453/steps/webkit_tests/logs/stdio
Original issue's description:
> DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events
>
> Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.
>
> BUG=398787
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf
[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=398787
Review URL: https://codereview.chromium.org/516963003
Cr-Commit-Position: refs/heads/master@{#292390}
Change media MessageLoopProxy usage to SingleThreadTaskRunners.
Changing WebMediaPlayerImpl and related media code to use task runners
instead of MessageLoopProxy to avoid presubmit errors when moving this
code to media/blink. There is no functional change here. Just making the
tools happy. :)
BUG=408338
Review URL: https://codereview.chromium.org/508293003
Cr-Commit-Position: refs/heads/master@{#292389}
roll icu
brings in https://codereview.chromium.org/515263002
[email protected]
Review URL: https://codereview.chromium.org/513973004
Cr-Commit-Position: refs/heads/master@{#292388}
DevTools: Use workerReadyForInspection event as a signal for DevTools attaching
BUG=404355
R=yurys, pfeldman-OOO, horo
Review URL: https://codereview.chromium.org/479673004
Cr-Commit-Position: refs/heads/master@{#292387}
Clean up setting accessibility focus.
Consolidate the code to set accessibility focus to one place.
Fix it so we never set accessibility focus to the same id twice in a row,
as that puts things in a weird state (because we then get a "clear"
accessibility focus action on the current focused view).
In a couple of places where we want to explicitly update the focus,
set focus away and then back again so Android can't ignore it.
BUG=407871
Review URL: https://codereview.chromium.org/513483002
Cr-Commit-Position: refs/heads/master@{#292386}
Improve a poor implementation of "find duplicates".
BUG=407718
Review URL: https://codereview.chromium.org/510583002
Cr-Commit-Position: refs/heads/master@{#292385}
Restore outline on focus for security warnings
When tab focus is placed on the security warning primary button, Chrome
should outline the button. However, the outline is not shown during
button activation to prevent it from making the button border an odd
white-gray-blue.
BUG=387163
[email protected]
Review URL: https://codereview.chromium.org/511073002
Cr-Commit-Position: refs/heads/master@{#292384}
NaCl: Update revision in DEPS, r13666 -> r13668
This pulls in the following Native Client changes:
r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
r13668: (noelallen) Force rebuild on cmd change.
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build
[email protected]
Review URL: https://codereview.chromium.org/513933003
Cr-Commit-Position: refs/heads/master@{#292383}
Minor history tweaks that I came across while looking at crashes.
. Make HistoryService::Cleanup() private. Making this public can leave
HistoryService in a bad state.
. HistoryServiceFactory would leak a HistoryService if
HistoryService::Init() failed.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/510033004
Cr-Commit-Position: refs/heads/master@{#292382}
Password bubble should close if user clicks on the web page.
BUG=394287
Review URL: https://codereview.chromium.org/512683003
Cr-Commit-Position: refs/heads/master@{#292381}
Fix strict mode violations in Android.
BUG=408525
Review URL: https://codereview.chromium.org/513173002
Cr-Commit-Position: refs/heads/master@{#292380}
DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events
Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.
BUG=398787
Review URL: https://codereview.chromium.org/511873002
Cr-Commit-Position: refs/heads/master@{#292379}
Move ExtensionWarningService and ExtensionsWarningSet, which are used by webrequest api, to extensions.
This cl resolve the dependencies of ExtensionsWarningSet of chrome strings:
- move the declarations of IDS_EXTENSION_WARNINGS_XXX to extensions_strings.grd;
- replace the usage of "IDS_PRODUCT_NAME" by creating GetProductName() function in ExtensionsClient and its subclasses.
BUG=352293
Review URL: https://codereview.chromium.org/503033002
Cr-Commit-Position: refs/heads/master@{#292378}
Documented how to add bookmark folders with the ManagedBookmarks policy.
BUG=None
Review URL: https://codereview.chromium.org/512223002
Cr-Commit-Position: refs/heads/master@{#292377}
Update some paths from components/breakpad/ to components/crash/
It was moved in https://crrev.com/55b8563
Found by git grep 'components.*breakpad'
BUG=406410
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/511223002
Cr-Commit-Position: refs/heads/master@{#292376}
Do not compile 'all' on memory trybots, some targets fail otherwise
BUG=408285
[email protected]
Review URL: https://codereview.chromium.org/510913004
Cr-Commit-Position: refs/heads/master@{#292375}
[DevTools] Implement Page.canEmulate capability.
BUG=none
Review URL: https://codereview.chromium.org/501153006
Cr-Commit-Position: refs/heads/master@{#292374}
This removes an ash dependency from the system.display API in order to move it to extensions/. As a side effect, we got rid of #ifdefs on system_info_api.cc
BUG=392842
Review URL: https://codereview.chromium.org/507783003
Cr-Commit-Position: refs/heads/master@{#292373}
Remove python bindings unittests from the build.
Instead add a run_mojo_python_bindings_tests.py that will be run from
the bots. This also refactor run_mojo_python_tests.py to factorize the
common code.
BUG=407818
Review URL: https://codereview.chromium.org/509863002
Cr-Commit-Position: refs/heads/master@{#292372}
Disable two failing WebRtcBrowserTest tests under MSan.
BUG=405951
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/515193002
Cr-Commit-Position: refs/heads/master@{#292371}
Adding tracing and gtest pretty printing support to TestPendingTask.
These functions where invaluable when trying to debug and fix the
cc::OrderedTestRunner as they let me easily inspect the tasks without having to
fire up GDB. They should also be useful in development / testing of other task
runners.
Added a very simple test for ShouldRunBefore which shows this stuff working. If
that test fails, the output looks like the following;
-------------------------------------------------------------------------------
../../base/test/test_pending_task_unittest.cc:49: Failure
Value of: task_after.ShouldRunBefore(task_first)
Actual: false
Expected: true
TestPendingTask(
{"delay":2000,"nestability":"NESTABLE","post_time":0,
"posting_function":"Unknown@Unknown:-1","run_at":2000}
).ShouldRunBefore(TestPendingTask(
{"delay":1000,"nestability":"NESTABLE","post_time":0,
"posting_function":"Unknown@Unknown:-1","run_at":1000})
)
-------------------------------------------------------------------------------
BUG=380889
Review URL: https://codereview.chromium.org/491743002
Cr-Commit-Position: refs/heads/master@{#292370}
Don't let PRR kick in if there is less than a packets worth of bytes in
flight.
Merge internal change: 74165077
Renabled flaky LargePostZeroRTTFailure to see if this CL fixes issue
407756 on chromeos valgrind.
[email protected], [email protected]
BUG=407756
Review URL: https://codereview.chromium.org/511003002
Cr-Commit-Position: refs/heads/master@{#292369}
Disable WebRtcBrowserTest::CanSetupVideoCallWith16To9AspectRation on Arm64.
BUG=408179
NOTRY=true
Review URL: https://codereview.chromium.org/509333002
Cr-Commit-Position: refs/heads/master@{#292368}
Revert of Modify test case to support streaming operation in sandbox file system. (patchset #6 of https://codereview.chromium.org/491813002/)
Reason for revert:
This is breaking fast/filesystem/op-copy.html in Blink:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/filesystem/op-copy.html
Original issue's description:
> Modify test case to support streaming operation in sandbox file system.
>
> BUG=360088
> TEST=content_unittests passed
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2332db94ec6c42aaa3d66f5226a4c17b85c1553e
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=360088
Review URL: https://codereview.chromium.org/510323003
Cr-Commit-Position: refs/heads/master@{#292367}
Roll cros_system_api
This pulls in the following changes:
* dbus: Add method for cryptohomed GetKeyDataEx
* Remove deprecated shill::kPaymentURLProperty
* Add a constant for the 'org.freedesktop.DBus' interface.
* dbus/service_constants.h: Remove
"Cellular.ActivateOverNonCellularNetwork"
* Add portal detection failed phase and status to service property
BUG=367847
TEST=Everything still compiles
Review URL: https://codereview.chromium.org/507973003
Cr-Commit-Position: refs/heads/master@{#292366}
Skia roll 6b0d6b4:b2f7fce
https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/512183002
Cr-Commit-Position: refs/heads/master@{#292365}
Use .equals() for string comparisons in ModelType.
This fixes a FindBugs warning.
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/517453003
Cr-Commit-Position: refs/heads/master@{#292364}
Manual devtools fixups for scoped_refptr operator T* removal.
BUG=110610
[email protected]
Review URL: https://codereview.chromium.org/513673004
Cr-Commit-Position: refs/heads/master@{#292363}
Update V8 to version 3.29.25 (based on bleeding_edge revision r23481).
[email protected]
Review URL: https://codereview.chromium.org/510303003
Cr-Commit-Position: refs/heads/master@{#292362}
Drop back to back frames in VideoFrameResolutionAdapter::MaybeDropFrame.
We have observed on some Mac that video frames are delivered back to back from the build in video capture device. This can potentially happen on all platforms. If that happen, the simple filter used for frame rate calculation get scewed. This cl fix that by dropping all frames received within 5ms of the previous frame.
BUG=394315
Review URL: https://codereview.chromium.org/516783002
Cr-Commit-Position: refs/heads/master@{#292361}
OOP PDF - Add OpenPDFParamsParser class
This patch introduces OpenPDFParamsParser class which is responsible
to parse open pdf parameters and set them in a dictionary. This
dictionary will be used to set initial viewport settings when opening
pdf document.
BUG=303491
Review URL: https://codereview.chromium.org/477933003
Cr-Commit-Position: refs/heads/master@{#292360}
Fix a crash reported by monkey tests.
BUG=405504
Review URL: https://codereview.chromium.org/501473002
Cr-Commit-Position: refs/heads/master@{#292359}
Modify test case to support streaming operation in sandbox file system.
BUG=360088
TEST=content_unittests passed
Review URL: https://codereview.chromium.org/491813002
Cr-Commit-Position: refs/heads/master@{#292358}
Make the password manager python tests a module.
Add __init__.py file to the password manager python tests to
make it a module so that it could be imported from python
files in the parent folder.
BUG= 408198
Review URL: https://codereview.chromium.org/511943002
Cr-Commit-Position: refs/heads/master@{#292357}
Revert of Skia roll 6b0d6b4:b2f7fce (patchset #1 of https://codereview.chromium.org/516563003/)
Reason for revert:
It broke some antialiasing tests on Win7, see:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/19724/steps/webkit_tests/logs/stdio
The output has some odd comma added after each character. It doesn't seem to be a rebase problem.
Original issue's description:
> Skia roll 6b0d6b4:b2f7fce
>
> https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/98c591a509f0c760d514fe079cf507ef1f7e76a4
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/515753004
Cr-Commit-Position: refs/heads/master@{#292356}
Show a desktop notification when the enrollment is completed or failed.
BUG=chromium:353050
TEST=unit_tests
Review URL: https://codereview.chromium.org/468873002
Cr-Commit-Position: refs/heads/master@{#292355}
Remove Profile dependency from browsing_data_channel_id_helper.cc
The only use of Profile in that file is to get net::URLRequestContextGetter. This CL pulls that out, so that instead of getting a Profile, and asking for URLRequestContextGetter, the affected class gets URLRequestContextGetter directly.
This reduces a //chrome dependency to a //net one, and is part of preparations for content settings componentisation.
BUG=384873
Review URL: https://codereview.chromium.org/508223002
Cr-Commit-Position: refs/heads/master@{#292354}
Enable invalidations for supervised user settings on Android.
BUG=none
Review URL: https://codereview.chromium.org/493293002
Cr-Commit-Position: refs/heads/master@{#292353}
Video Player: Close the video when the session is disconnected
BUG=403846
TEST=manually tested
Review URL: https://codereview.chromium.org/514103002
Cr-Commit-Position: refs/heads/master@{#292352}
Cleanup of SafeBrowsingBlockingPageBrowserTest tests
* Make MalwareIframeReportDetails work with V3 and reenable it
* Make ReportingDisabled work with V3 and reenable it
* Remove TODO from PhishingProceed, since it's been enabled for a while
* Remove TODO from PhishingLearnMore, since it's been enabled for a while
* Remove logging statements scattered around
BUG=273302,247763
[email protected]
Review URL: https://codereview.chromium.org/512073002
Cr-Commit-Position: refs/heads/master@{#292351}
Use SearchProvider for Athena
With SearchProvider, we can suggest URLs as well as queries and show icons at the left of each suggested item.
Also, parts of the suggested query which is not typed by the user are shown bold.
Basically do the same thing as Chrome's AutocompleteController+OmniboxProvider.
Add required resources to athena_resources.
BUG=408050
Review URL: https://codereview.chromium.org/514583002
Cr-Commit-Position: refs/heads/master@{#292350}
MacViews: Guard Objective-C bits in content::WebContentsViewDelegate with __OBJC__
Currently WebContentsViewDelegate has a mix of ObjectiveC and C++ code
guarded by #ifdef OS_MACOSX. This means, on Mac, it can only be included
in .mm files.
For views on Mac, we want to reuse the toolkit-views WCVD (and tests)
when hosting a WebContents in a views::Widget. So we can't convert
everything to .mm.
This CL changes the guards to use __OBJC__ and ensures the vtable is a
consistent size with the compile flags used on MacViews.
To reduce churn, the WCVD methods are given default implementations.
MacViews needs the other methods, currently guarded by USE_AURA, so
things get really complex without this.
BUG=399191
Review URL: https://codereview.chromium.org/507363002
Cr-Commit-Position: refs/heads/master@{#292349}
Expand minimum size of the window to avoid cut off context menu
BUG=259656
TEST=manually
Review URL: https://codereview.chromium.org/510713002
Cr-Commit-Position: refs/heads/master@{#292348}
Files.app: Remove MountedDiskMonitor.
The role of MountedDiskMonitor is replaced with DeviceEventRouter.
BUG=360946,396258
TEST=manually
Review URL: https://codereview.chromium.org/479563007
Cr-Commit-Position: refs/heads/master@{#292347}
Skia roll 6b0d6b4:b2f7fce
https://skia.googlesource.com/skia/+log/6b0d6b43cf662735dc804d8142383452c7f246f9..b2f7fce9e034c3b6749e75a129e7836df3529706
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/516563003
Cr-Commit-Position: refs/heads/master@{#292346}
Fixed install-build-deps.sh for Goobuntu Precise laptops.
Review URL: https://codereview.chromium.org/508953003
Cr-Commit-Position: refs/heads/master@{#292345}
Declaring the weak_ptr_factory in proper order.
Cleaning up weak_ptr_factory destruction order in "src/net" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.
BUG=303818
Review URL: https://codereview.chromium.org/506523002
Cr-Commit-Position: refs/heads/master@{#292344}
Cleanup: removing files that I forgot to remove in
https://codereview.chromium.org/501093003/
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/517483002
Cr-Commit-Position: refs/heads/master@{#292343}
Fix leak of MultiThreadedCertVerifier in ProfileIOData.
Heap allocated MultiThreadedCertVerifier was passed to URLRequestContext::set_cert_verifier, which doesn't take ownership.
Leak was introduced in r249928.
BUG=NONE
Review URL: https://codereview.chromium.org/516453002
Cr-Commit-Position: refs/heads/master@{#292342}
Stop devtools if socket for http server cannot be instantiated.
Currently, it crashes entire chrome. This CL is to stop devtools gracefully
when socket for http server cannot be instantiated because of any reasons
including address-already-in-use error.
BUG=407999
Review URL: https://codereview.chromium.org/516483002
Cr-Commit-Position: refs/heads/master@{#292341}
Use precisely sized integer types in histograms code.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/511903003
Cr-Commit-Position: refs/heads/master@{#292340}
[telemetry] Disable IPPET on Windows 7.
It's flaky on Windows 7, but appears to be okay on Windows 8.
BUG=336558
TEST=None.
TBR=tonyg
Review URL: https://codereview.chromium.org/510263002
Cr-Commit-Position: refs/heads/master@{#292339}
Adds a skeleton component app for Always-On Hotwording opt-in flow.
BUG=390086
Review URL: https://codereview.chromium.org/467113004
Cr-Commit-Position: refs/heads/master@{#292338}
Automated Commit: Committing new LKGM version 6209.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292337}
Revert of Re-enable SitePerProcessBrowserTest.CrossSiteIframe (patchset #10 of https://codereview.chromium.org/479403004/)
Reason for revert:
This is causing unaddressable memory errors on the DrMemory full bot. Build where the error was introduced:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/945
(error hash: 25DFC5E3C30FC6B7)
Sample log output:
UNADDRESSABLE ACCESS of freed memory: reading 0x034348e0-0x034348e4 4 byte(s)
# 0 blink_web.dll!blink::toCoreFrame [third_party\webkit\source\web\webframe.cpp:24]
# 1 blink_web.dll!blink::RemoteFrameClient::firstChild [third_party\webkit\source\web\remoteframeclient.cpp:49]
# 2 blink_web.dll!blink::WebRemoteFrameImpl::~WebRemoteFrameImpl [third_party\webkit\source\web\webremoteframeimpl.cpp:106]
# 3 blink_web.dll!blink::WebRemoteFrameImpl::close [third_party\webkit\source\web\webremoteframeimpl.cpp:131]
# 4 content.dll!content::RenderFrameProxy::~RenderFrameProxy [content\renderer\render_frame_proxy.cc:120]
# 5 content.dll!content::RenderFrameProxy::`vector deleting destructor'
# 6 content.dll!content::RenderFrameProxy::OnDeleteProxy [content\renderer\render_frame_proxy.cc:180]
# 7 content.dll!content::MessageRouter::RouteMessage [content\common\message_router.cc:54]
# 8 content.dll!content::MessageRouter::OnMessageReceived [content\common\message_router.cc:46]
# 9 content.dll!content::ChildThread::OnMessageReceived [content\child\child_thread.cc:494]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage [ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run [base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask [base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask [base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask [base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork [base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run [base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler [base\message_loop\message_loop.cc:408]
#18 content.dll!content::RendererMain [content\renderer\renderer_main.cc:227]
#19 content.dll!content::RunNamedProcessTypeMain [content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run [content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain [content\app\content_main.cc:19]
#22 content::LaunchTests [content\public\test\test_launcher.cc:475]
#23 main [content\test\content_test_launcher.cc:123]
BTW IMHO the CL summary for this change could be better, this change did way more than re-enalbe a test. Ideally the summary would capture the entirety of the change.
Original issue's description:
> Re-enable SitePerProcessBrowserTest.CrossSiteIframe
>
> This CL fixes a few issues in the cross-process subframe navigation and re-enables the CrossSiteIframe test on most platforms. There are still some issues on ChromeOS and Android, which will be investigated and fixed in follow-up CL.
>
> BUG=399775, 357747
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291437
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=399775, 357747
Review URL: https://codereview.chromium.org/515073002
Cr-Commit-Position: refs/heads/master@{#292336}
Shows the static logo image in athena home card.
This CL depends on https://codereview.chromium.org/512943003/
BUG=408373
[email protected]
[email protected]
TEST=manually
Review URL: https://codereview.chromium.org/515723003
Cr-Commit-Position: refs/heads/master@{#292335}
Declaring the weak_ptr_factory in proper order.
Cleaning up weak_ptr_factory destruction order in "src/ipc" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.
BUG=303818
Review URL: https://codereview.chromium.org/508903002
Cr-Commit-Position: refs/heads/master@{#292334}
Rename AutocompleteProviderDelegate to AutocompleteProviderClient
Per request by [email protected] (https://codereview.chromium.org/500023002/)
BUG=388515
[email protected]
Review URL: https://codereview.chromium.org/510783002
Cr-Commit-Position: refs/heads/master@{#292333}
Avoid deadlock between Pipeline and RendererImpl.
Both Pipeline and RendererImpl use it's own lock. We could end up with a dead
lock in the following scenario:
- On main thread, Pipeline holds it's lock (lock A) and calls into RendererImpl,
which also requires the RendererImpl's lock (lock B).
- On media thread, RendererImpl holds it's lock B and calls callback provided by
the Pipeline, which requires lock A.
This CL makes sure Pipeline never calls into RendererImpl while holding lock A
and RendererImpl nevers calls (back) into Pipeline while holding lock B. So
deadlock should not happen.
This CL also reverts 3 CLs that disabled various tests due to the bug:
- Revert "Exclude tests that deadlock under DrMemory (and Tsan)"
This reverts commit 0e014b9ad964236d67db60488168dbc0811655e9.
- Revert "Disable deadlock-y tests in TSan instead of just suppressing the error."
This reverts commit f712d106692d782f2a590a8e752f720ad76ee608.
- Revert "Suppress a deadlock report through media::Pipeline::GetMediaTime."
This reverts commit 5c72e0f67ce7e42804d809183bdae190024056ef.
BUG=407452
TEST=Ran PipelineIntegrationTest.ChunkDemuxerAbortRead_VideoOnly in a TSAN build for 10 mins and didn't see any issue.
Review URL: https://codereview.chromium.org/512973002
Cr-Commit-Position: refs/heads/master@{#292332}
Roll WebGL conformance tests to ToT khronos.
BUG=
TEST=gpu bots
[email protected],[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/516563004
Cr-Commit-Position: refs/heads/master@{#292331}
Expand height of file list and default action list.
BUG=407932
TEST=manually
Review URL: https://codereview.chromium.org/507983002
Cr-Commit-Position: refs/heads/master@{#292330}
Disable SyncFileSystemServiceTest.SimpleLocalSyncFlow under valgrind.
The test is failing there.
NOTRY=true
TBR=zhaoqin
BUG=408443
Review URL: https://codereview.chromium.org/511903004
Cr-Commit-Position: refs/heads/master@{#292329}
Disable ProxyConfigServiceImplTest.* under valgrind.
NOTRY=true
TBR=zhaoqin
BUG=408013
Review URL: https://codereview.chromium.org/517453002
Cr-Commit-Position: refs/heads/master@{#292328}
[ew] Add basic classes.
This patch adds a EntryWatcherService, which is a bridge between extensions and
fileapi. Also, WatcherManager interface has been created to let backends
implement their own watching logic.
Note, that EntryWatcherService is not wired up to File System API yet. Also,
a lot of features are missing.
TBR=noamsml, jcivelli
TEST=unit_tests: *EntryWatcherService*
BUG=261491
Review URL: https://codereview.chromium.org/452043003
Cr-Commit-Position: refs/heads/master@{#292327}
Clearing Tabs and Observer list when TabModelBase is destroyed.
When TabModelBase is destroyed, Tabs and Observers List should
be cleared to free any holding tabs and observers respectively.
BUG=None.
Review URL: https://codereview.chromium.org/511903002
Cr-Commit-Position: refs/heads/master@{#292326}
Temporary allocation of 20Mb before and after call to ServiceProcessControl::GetHistograms.
BUG=406227
Review URL: https://codereview.chromium.org/510563004
Cr-Commit-Position: refs/heads/master@{#292325}
Move bookmark_pref_names.* into bookmarks namespace.
BUG=370433
TEST=None
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/490123003
Cr-Commit-Position: refs/heads/master@{#292324}
ozone: evdev: Fix TouchEvent radius
We get the touch ellipse geometry from the major/minor/orientation axis
of the MT protocol. Use those intead of attempting to derive it from
pressure.
BUG=381898
TEST=chrome on pixel with --ash-touch-hud
NOTRY=true
Review URL: https://codereview.chromium.org/509713002
Cr-Commit-Position: refs/heads/master@{#292323}
Revert of Replace NPObject usage in ppapi with gin (patchset #26 of https://codereview.chromium.org/459553003/)
Reason for revert:
Crash in telemetry tests http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/6615
Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=351636
Review URL: https://codereview.chromium.org/512983004
Cr-Commit-Position: refs/heads/master@{#292322}
Support targeting for gestures in ViewTargeter
Move the gesture event targeting logic from
RootView::DispatchGestureEvent() into ViewTargeter's
overrides of FindTargetForEvent() and
FindNextBestTarget().
BUG=404224
TEST=ViewTargeterTest.ViewTargeterForGestureEvents
Review URL: https://codereview.chromium.org/481433006
Cr-Commit-Position: refs/heads/master@{#292321}
Remove custom layout from app list SearchBoxView
This CL removes the custom layout from SearchBoxView and uses a BoxLayout
instead. This slightly changes the layout of the app list search box.
BUG=406983
Review URL: https://codereview.chromium.org/463403003
Cr-Commit-Position: refs/heads/master@{#292320}
[Findit] Fix blame for GIT and uptake bug fix.
NOTRY=true
Review URL: https://codereview.chromium.org/510163002
Cr-Commit-Position: refs/heads/master@{#292319}
Cleanup BrowserPluginGuestManager
Remove some unnecessary includes, typedefs, and forward declarations.
BUG=none
Review URL: https://codereview.chromium.org/490923006
Cr-Commit-Position: refs/heads/master@{#292318}
Fix the info bar doesn't get redrawn when its frame is changed. Also fix the
height of top infobar arrow doesn't changed through animation when the status
of bookmark bar changes from show to hide/detach.
Set the view of info bar to be auto resizable and change the height of top infobar
arrow when the its frame is changed.
BUG=382141
TEST= ./browser_tests --
gtest_filter="BrowserWindowControllerTest.InfoBarTipStrechedWhenBookmarkBar
StatusChanged", manually tested.
Review URL: https://codereview.chromium.org/435863002
Cr-Commit-Position: refs/heads/master@{#292317}
Let omnibox Depend on variations_http_provider instead of variations
Depend on the correct target
BUG=388515
Review URL: https://codereview.chromium.org/514603002
Cr-Commit-Position: refs/heads/master@{#292316}
Put thunk targets directly into loadable modules in static build
gles2_thunks.cc, gles2_impl_thunks.cc, etc define symbols that should be
exported from loadable modules. If these files are linked into a static
library and that static library is then linked into a loadable module,
the linker may or may not pull in the object files for the thunks
depending on if any symbols from that object file are referenced by
some other object file in the component.
This puts the thunks into a gypi that can be included directly into a
loadable module so the object files containing the thunks are on the
link line directly and make it into the final library.
[email protected]
Review URL: https://codereview.chromium.org/509123003
Cr-Commit-Position: refs/heads/master@{#292315}
Fix the context menu positioning for ExtensionOptionsGuest
Implement HandleContextMenu in ExtensionOptionsGuest so that the right
click context menu within guest views are properly positioned next to
the pointer.
BUG=406885
Review URL: https://codereview.chromium.org/510993002
Cr-Commit-Position: refs/heads/master@{#292314}
pdf: Create a separate component for using the pdf pepper plugin.
Create a component necessary for showing PDF in a content-based client. Much of
the relevant code currently lives in //chrome/, and is usable by chrome. Moving
this code into a separate component in //components/pdf/ allows it to be easily
used by other content-clients (e.g. app-shell, athena, etc.). This patch moves
PPB_PDF_Impl (implementation for the PPB_PDF interface in ppapi) and the
relevant IPC messages in the pdf component.
A short summary of the changes in this patch:
. Move ppb_pdf_impl.cc|h into //components/pdf from //chrome/renderer/pepper
. Put this code in the 'pdf' namespace. This code lives in 'pdf_renderer'
target. 'chrome_renderer' depends on this target.
. Move the following IPC messages from render_messages.h to pdf_messages.h:
- PDFUpdateContentRestrictions
- PDFHasUnsupportedFeature
- PDFSaveURLAs
- PDFModalPromptForPassword
Change the prefix of these messages from ChromeViewHostMsg_ to PDFHostMsg_
. Move PDFTabHelper into //components/pdf from //chrome/browser/ui/pdf.
Put this code in the 'pdf' namespace. This code lives in 'pdf_browser'
target. 'chrome_browser' depends on this target.
BUG=401242
[email protected], [email protected], [email protected], [email protected]
[email protected] for DEPS
Review URL: https://codereview.chromium.org/477263003
Cr-Commit-Position: refs/heads/master@{#292313}
GuestViews should be able to specify task manager entries
BUG=406575
[email protected] for changes to *.grd
Review URL: https://codereview.chromium.org/497843002
Cr-Commit-Position: refs/heads/master@{#292312}
More viewmanager renaming:
. RootNodeManager->ConnectionManager. A better name might be
ViewManagerServiceImplsManager, but I can't come to type that in.
. Node->ServerView. I really want to use View, but having a class
named View in the server and lib has confused everyone I've talked
to and makes talking about View extremely abiguous.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/513923004
Cr-Commit-Position: refs/heads/master@{#292311}
[Telemetry] Clean up log output a bit.
BUG=
Review URL: https://codereview.chromium.org/512943002
Cr-Commit-Position: refs/heads/master@{#292310}
Update the pairing API to include configuration and enrollment.
BUG=405744
Review URL: https://codereview.chromium.org/491943004
Cr-Commit-Position: refs/heads/master@{#292309}
[Telemetry] Clean up host platform hack in AndroidPlatformBackend.
BUG=
Review URL: https://codereview.chromium.org/515603002
Cr-Commit-Position: refs/heads/master@{#292308}
Chromecast devtools API fixes.
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/505393002
Cr-Commit-Position: refs/heads/master@{#292307}
ozone: evdev: Use tracking id for TouchEvent finger id
We're supposed to use a unique id that increments for each
distinct touch. That's tracking id, not slot.
BUG=none
TEST=chrome on pixel with --ash-touch-hud
NOTRY=true
Review URL: https://codereview.chromium.org/512553002
Cr-Commit-Position: refs/heads/master@{#292306}
Make table text the same size as body text. Add styles to support table reformatting.
BUG=none
R= [email protected], [email protected], [email protected], [email protected], [email protected]
TEST=none
NOTRY=true
(documentation only change)
Review URL: https://codereview.chromium.org/483163002
Cr-Commit-Position: refs/heads/master@{#292305}
Set the Insertion handle correctly while showing the paste popup menu
The selection handle was wrongly set to left handle instead of center.
Corrected it. Also added test case to verify that the paste popup is
shown when long pressed on empty input with some text in clipboard
BUG=407185
Review URL: https://codereview.chromium.org/499393002
Cr-Commit-Position: refs/heads/master@{#292304}
Remove the lies WebMediaPlayerImpl is telling V8.
Removing hacky code that sends made up data to V8 to trick it into running
GC more often. This was added a long time ago and it is unlikely it is
actually helping things anymore. Removing this code also eliminates
WebMediaPlayerImpl's dependency on V8 which helps with moving this code
to media/blink.
BUG=408338
Review URL: https://codereview.chromium.org/512033002
Cr-Commit-Position: refs/heads/master@{#292303}
ServiceWorker: Clean up WebServiceWorkerRegistrationImpl
BUG=n/a
TEST=should pass all existing tests (no behavioral change)
Review URL: https://codereview.chromium.org/515493002
Cr-Commit-Position: refs/heads/master@{#292302}
Remove include of ui/events/event.h from device_data_manager
device_data_manager shouldn't include event.h as they are in different
targets and we don't want event_base depending upon event.
BUG=none
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/512553003
Cr-Commit-Position: refs/heads/master@{#292301}
Disable failing tests on chromeos.
BUG=404868
TEST=perf fyi bot
Review URL: https://codereview.chromium.org/508363002
Cr-Commit-Position: refs/heads/master@{#292300}
Add a minimum cross axis size to BoxLayout.
This CL allows clients to specify a minimum cross axis size when using
a BoxLayout.
BUG=406983
Review URL: https://codereview.chromium.org/494273003
Cr-Commit-Position: refs/heads/master@{#292299}
Remove implicit conversions from scoped_refptr to T* in device/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/507053002
Cr-Commit-Position: refs/heads/master@{#292298}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/prefs/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/506153002
Cr-Commit-Position: refs/heads/master@{#292297}
Rework ExtensionApiUnittest to run in extensions_unittests, removing its Chrome dependencies.
Move SocketsTcpUnitTest as the first test to use it.
BUG=397164
Review URL: https://codereview.chromium.org/461273003
Cr-Commit-Position: refs/heads/master@{#292296}
Replace NPObject usage in ppapi with gin
This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
BUG=351636
Review URL: https://codereview.chromium.org/459553003
Cr-Commit-Position: refs/heads/master@{#292295}
Cleanup: Remove unneeded media/ SSE2 checks and unused code. (try 2)
This is the media/ portion of a reverted CL: https://codereview.chromium.org/459603003/
BUG=349320
Review URL: https://codereview.chromium.org/516543004
Cr-Commit-Position: refs/heads/master@{#292294}
Fix assorted issues with remote CoreAnimation
These issues came up while running for a few days with the
flag --enable-remote-core-animation.
Fix flashes of old frames by hooking up the DiscardBackbuffer (which
happens when being made non-visible) to re-set the CAContext and
CALayer (so the browser gets a new one with new content for the next
frame).
Add support for disabling vsync by using setNeedsDisplay to draw.
Change the backpressure mechanism to rely on the browser to apply
backpressure in its compositor via the cc:: output surface.
Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
to the real GL API while in the CoreAnimation callback.
BUG=312462
Review URL: https://codereview.chromium.org/516643002
Cr-Commit-Position: refs/heads/master@{#292293}
Adding more checking and some debugging information in Custom Font Collection.
+rsesek for crash key/value OWNERS.
R=scottmg,ananta,cpu
[email protected]
BUG=399233
Review URL: https://codereview.chromium.org/508393002
Cr-Commit-Position: refs/heads/master@{#292292}
Respect --profile-directory flag when used with --show-app-list flag.
This CL allows specification of the profile to show the app list for when
launching the app list via the command line.
Currently --show-app-list always uses the last used app list profile, but we
want to allow testers to more easily load the app list for a particular
profile.
On Windows, this can be used for making shorcuts to a particular profile's
app list but this will always bind to the main shortcut due to the app id.
BUG=400874
Review URL: https://codereview.chromium.org/500333002
Cr-Commit-Position: refs/heads/master@{#292291}
Moves ntp logo images to ui/resources.
These files will be used in Athena.
BUG=408373
[email protected], [email protected]
TEST=no functional change
Review URL: https://codereview.chromium.org/512943003
Cr-Commit-Position: refs/heads/master@{#292290}
ozone: evdev: gestures: Disable click when the cursor is hidden
This is hacky, and a stopgap while we wait on property plumbing.
BUG=none
TEST=manual on link_freon
NOTRY=true
Review URL: https://codereview.chromium.org/514943003
Cr-Commit-Position: refs/heads/master@{#292289}
Revert of Initialize the now_funciton to the HighResNowWrapper in case High Res is supported (patchset #7 of https://codereview.chromium.org/446203002/)
Reason for revert:
It causes a Canary crash
https://code.google.com/p/chromium/issues/detail?id=408354
The added static initializer causes a crash in libpeerconnetion used by WebRTC
Fix to reland: remove static initializer.
Original issue's description:
> We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots
> https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
>
> It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
> This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
>
> By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
>
> BUG=158234
>
> Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=158234
Review URL: https://codereview.chromium.org/516693002
Cr-Commit-Position: refs/heads/master@{#292288}
Non-SFI NaCl: Allow openat system call to gracefully fail on BareMetal seccomp-bpf.
sysconf via get_nprocs_conf glibc function calls opendir() which calls
openat() syscall, make them gracefully fail with EPERM instead of killing with SIGSYS.
This fixes crash trying to start chrome tracing when running
application with BareMetal with recent glibc.
BUG=407516
TESTED=launched BareMetal NaCl app and started chrome tracing and doesn't crash.
Review URL: https://codereview.chromium.org/509783003
Cr-Commit-Position: refs/heads/master@{#292287}
Adding Baseframework of the ResourceManager (all hooks and observers)
are being put in place with a very basic management scheme
The current ash implementation of the LowMemoryObserver polls
"/dev/chromeos-low-mem" to find if we are running out of memory.
After discussion with semenzato@ we decided that that is not precise
enough and we should rather poll the system memory information. Going
forward this has multiple benefits:
1. it does not require special kernel handling.
2. it also gives us information about GPU memory on chromeOS which
will come handy once we are adding more sophisticated management.
Beside that, this CL adds the ResourceManager which hooks itself into
several components to detect changes in Activity's and their ordering
as well as memory pressure.
Note: The current management implementation itself is really primitive
and needs to be improved.
TBR for the DEPS file
BUG=381212, 403782
TEST=MemoryPressureTest.*, ResourceManagerTest.*
[email protected]
Review URL: https://codereview.chromium.org/513523002
Cr-Commit-Position: refs/heads/master@{#292286}
Fix git log command to while processing Commit position in SVNFindRev method
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/511033002
Cr-Commit-Position: refs/heads/master@{#292285}
Fixes the fling and closest state logic in HomeCardGestureManager.
The weak fling should be handled and end the gesture session for
issue 406197. Also, fling handling turns out to check closest
state instead of last_state_. Otherwise there could be a chance
to enter an inconsistent state from the visual.
Also, the area of "closest to minimized" is too small, so I put
50px static height for this.
BUG=406197, 407890
[email protected]
TEST=athena_unittests, manually
Review URL: https://codereview.chromium.org/507653005
Cr-Commit-Position: refs/heads/master@{#292284}
Don't set goma_dir in config if path_to_goma is None.
BUG=394531
NOTRY=true
Review URL: https://codereview.chromium.org/512703005
Cr-Commit-Position: refs/heads/master@{#292283}
Record histograms for timing information in DomDistiller.
https://codereview.chromium.org/499623002/ adds timing diagnostics to
DomDistiller. Report histograms for these to help measure real-world
perf.
Also includes a boolean histogram for distillability based on code from internal repo.
Review URL: https://codereview.chromium.org/501553002
Cr-Commit-Position: refs/heads/master@{#292282}
Update ipfw (dummynet) to run on linux kernel 3.13
BUG=
Review URL: https://codereview.chromium.org/514453003
Cr-Commit-Position: refs/heads/master@{#292281}
[Android] Clear backing SkBitmap before rendering the overscroll effect
Skia makes no guarantees about the contents of a newly allocated
SkBitmap. Consequently, it's possible that the bitmap allocated for the
overscroll effect isn't zeroed before the effect itself is painted.
Prevent related issues by always clearing the allocated SkBitmap's
contents (to fully transparent) before painting the effect.
BUG=408225
Review URL: https://codereview.chromium.org/484373004
Cr-Commit-Position: refs/heads/master@{#292280}
metrics: Update UpdateEngineErrorCode with new error code.
We just added a new error code to ChromeOS's update_engine so also
update histograms.xml.
BUG=chromium:406546
TEST=Validated the xml, pretty print succeeded.
Review URL: https://codereview.chromium.org/514003002
Cr-Commit-Position: refs/heads/master@{#292279}
Disable all web_components unit tests.
BUG=408294
TBR=dpranke
Review URL: https://codereview.chromium.org/510153003
Cr-Commit-Position: refs/heads/master@{#292278}
Roll icu.
Picks up https://codereview.chromium.org/508343002
BUG=82385
[email protected]
Review URL: https://codereview.chromium.org/515773002
Cr-Commit-Position: refs/heads/master@{#292277}
Revert of Adding Select Action Bar Unit test case for input (patchset #3 of https://codereview.chromium.org/506423003/)
Reason for revert:
Failed compile on Android builders.
Original issue's description:
> [Android] Add unit tests for SelectActionBar appearance
>
> The SelectActionBar currently lacks test coverage. Add several test
> cases covering the appearance of the bar when interacting with an input
> field.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0bc56569817a24acea46748c599d77b59157d84d
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/514493004
Cr-Commit-Position: refs/heads/master@{#292276}
Mojo: Don't call Channel::HandleRemoteError() under lock.
(This removes the one place where we did. Sadly, there's no way to
assert that a lock isn't held by the current thread.)
[email protected]
Review URL: https://codereview.chromium.org/488003006
Cr-Commit-Position: refs/heads/master@{#292275}
QUIC - use HostPortPair instead of scoped_ptr<HostPortPair>.
[email protected]
Review URL: https://codereview.chromium.org/511543006
Cr-Commit-Position: refs/heads/master@{#292274}
Fix HidService lifetime issues.
This reverts HidService to a singleton instance, adding two gross
and presently hard-to-avoid properties:
1. Its instance getter takes a UI message loop proxy
2. Its lifetime is bound by the message loop of its origin thread
The purpose of this is to preserve the necessary threading discipline
required by both the chrome.hid API implementation and the
permission_broker DBus client while ensuring that the HidService is
created and destroyed on the same thread.
BUG=401234
Review URL: https://codereview.chromium.org/464753002
Cr-Commit-Position: refs/heads/master@{#292273}
Hook up autofill popup control elements
BUG=403597
Review URL: https://codereview.chromium.org/490193003
Cr-Commit-Position: refs/heads/master@{#292272}
Expose gallery watching functionality to the public mediaGalleries API.
BUG=144491
Review URL: https://codereview.chromium.org/440813002
Cr-Commit-Position: refs/heads/master@{#292271}
Integrate Mojo JS validation bindings with the Router
Instad of generating exported validateFooRequest(),
validateFooResponse() methods, a pointer to a validation
functions is added to the generated Stub and Proxy class
prototypes. For example, given an interface Foo, with
client interface FooClient:
FooStub.prototype.validators = [validateFooRequest];
FooProxy.prototype.validators = [validateFooResponse];
Note that if interface Foo has no callbacks, then
FooProxy.prototype.validators is an empty array.
The router validates incoming messages using these functions
and validateMessageHeader().
BUG=407181
Review URL: https://codereview.chromium.org/488173006
Cr-Commit-Position: refs/heads/master@{#292270}
[Telemetry] Combine SysfsPlatformBackend into LinuxBasedPlatformBackend.
Sysfs related functionality should have never been a separate Platform. There
should just be one Platform at a time.
BUG=
Review URL: https://codereview.chromium.org/509043002
Cr-Commit-Position: refs/heads/master@{#292269}
Don't try to decode more than one EOS at a time.
BUG=405642
Review URL: https://codereview.chromium.org/490033002
Cr-Commit-Position: refs/heads/master@{#292268}
Remove some duplicated code, and make rsa_key_nss.cc more closely match rsa_key_openssl.cc.
BUG=407874,407861
Review URL: https://codereview.chromium.org/507873002
Cr-Commit-Position: refs/heads/master@{#292267}
Revert of Re-enable memory tests. Fixed sign-in issue. (patchset #3 of https://codereview.chromium.org/491863003/)
Reason for revert:
Failing on bots. Looks like we forgot to commit the archive.
Traceback (most recent call last):
File "/b/build/slave/Android_Nexus5_Perf/build/src/tools/perf/../telemetry/telemetry/value/failure.py", line 39, in _GetExcInfoFromMessage
raise Exception(message)
Exception: Page set archive doesn't exist.
http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1480/steps/memory.mobile_memory/logs/stdio
Original issue's description:
> Re-enable memory tests. Fixed sign-in issue.
>
> Re-recording other tests may be required.
>
> BUG=370977
>
> Committed: https://chromium.googlesource.com/chromium/src/+/383ffaab6b5fac34b950d9faaab637cc75907aca
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=370977
Review URL: https://codereview.chromium.org/511023002
Cr-Commit-Position: refs/heads/master@{#292266}
cc: Always remove tiles from the recycle tree also.
Currently only one site that deletes a tile removes it from the
recycle twin. Change the others to also, or DCHECK showing they don't
need to.
R=enne, vmpstr
Review URL: https://codereview.chromium.org/513903002
Cr-Commit-Position: refs/heads/master@{#292265}
Consolidate AppControllDelegate to ExtensionsDelegate.
* Prep for athena on chrome.
Another notable change:
* pass app_id to AppActivity. it's known at creation time.
Note: this depends on https://codereview.chromium.org/505273002/
BUG=397167
Review URL: https://codereview.chromium.org/501093003
Cr-Commit-Position: refs/heads/master@{#292264}
ozone: evdev: Fix ghost touches aligned with first touch
The ABS_X and ABS_Y axes are not part of the MT protocol and should
therefore not be used to update MT slot positions.
The symptom of this was secondary touches warping to the position of the
first touch in the X and/or Y axis, since ABS_X/Y always corresponds to
the first touch.
BUG=407386
TEST=chrome on pixel with --ash-touch-hud
NOTRY=true
Review URL: https://codereview.chromium.org/506303002
Cr-Commit-Position: refs/heads/master@{#292263}
Add jbauman as OWNER of GPU process and command buffer related infrastructure.
John understands the infrastructure at a deep level and will provide
good code reviews and nominate others appropriately.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/510173002
Cr-Commit-Position: refs/heads/master@{#292262}
Hook up link pools in GN.
Adds a toolchain variable "concurrent_links". The value of this variable in the default toolchain is used as the depth of the link pool for the build.
Remove the "pool" stuff from the tool definitions that was never hooked up. The link pool is hardcoded in GN and is controlled by the above variable.
[email protected]
Review URL: https://codereview.chromium.org/508763002
Cr-Commit-Position: refs/heads/master@{#292261}
Set the internal listen socket only when it opens to socket successfully.
Android devtools tries open socket twice on same UnixDomainServerSocket
instance. Instead of destroying UnixDomainServerSocket instance, not assigning
internal listen socket on socket open error is cheaper and makes more sense.
BUG=408224
Review URL: https://codereview.chromium.org/515653003
Cr-Commit-Position: refs/heads/master@{#292260}
Roll DEPS on GTM to remove references to deprecated iOS methods.
sizeWithFont: and drawInRect:withFont:lineBreakMode:alignment: were
deprecated in iOS 7. This CL roll GTM to a revision where those methods
are no longer used (when building against iOS 7 or later).
BUG=405578
Review URL: https://codereview.chromium.org/507333003
Cr-Commit-Position: refs/heads/master@{#292259}
AudioMirroringManager becomes a global LazyInstance.
While attempting to resolve a flaky browser_test, it became clear that
AudioMirroringManager was not outliving its use. In the original change
that introduced this class, it was instantiated and owned by
BrowserMainLoop as a matter of convenience. However, with some
debugging, it's clear that it must outlive objects that can outlive
BrowserMainLoop (e.g., WebContentsAudioInputStream).
Side notes: I've checked the feasibility of other solutions, confirming
that the shutdown of AudioManager does NOT guarantee complete teardown
of an AudioInputStream, so it's not sufficient to simply change the
destruction order of the objects in BrowserMainLoop to resolve this
problem. As AudioMirroringManager provides a browser-wide service and
owns no objects, it seems reasonable for it to exist as a global
LazyInstance.
BUG=396413
Review URL: https://codereview.chromium.org/499483003
Cr-Commit-Position: refs/heads/master@{#292258}
Use content URI to upload photos taken by camera
Currently chrome creates a file path when uploading a photo taken through camera
However, this doesn't always work.
Instead, we should use content URI. See more details in the crbug.
BUG=405593
Review URL: https://codereview.chromium.org/489053003
Cr-Commit-Position: refs/heads/master@{#292257}
gn: Fix definition of |enable_plugins|.
Plugins are not enabled on android or ios.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/508823004
Cr-Commit-Position: refs/heads/master@{#292256}
Remove unused resources.
BUG=398951
Review URL: https://codereview.chromium.org/507133002
Cr-Commit-Position: refs/heads/master@{#292255}
Added app hashes for API access.
BUG=408276
Review URL: https://codereview.chromium.org/513973002
Cr-Commit-Position: refs/heads/master@{#292254}
[telemetry] Tenatively re-enable IPPET.
We want to see if it continues to cause flake and noise on the bots. If so, feel free to revert.
BUG=336558
TEST=None.
R=tonyg
Review URL: https://codereview.chromium.org/510143003
Cr-Commit-Position: refs/heads/master@{#292253}
Revert of Adding Select Action Bar Unit test case for input (patchset #3 of https://codereview.chromium.org/506423003/)
Reason for revert:
See previous review message.
Original issue's description:
> [Android] Add unit tests for SelectActionBar appearance
>
> The SelectActionBar currently lacks test coverage. Add several test
> cases covering the appearance of the bar when interacting with an input
> field.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0bc56569817a24acea46748c599d77b59157d84d
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/510953003
Cr-Commit-Position: refs/heads/master@{#292252}
ozone: evdev: Add DOM3 code string to Ozone evdev key events.
Have ui::KeycodeConverter::NativeKeycode use evdev codes when
compiled appropriately.
TEST=Manually tested on link_freon.
BUG=362698
Review URL: https://codereview.chromium.org/488123004
Cr-Commit-Position: refs/heads/master@{#292251}
Changed how we log uncaught exceptions by the WebGL tests
This allows us to output the exception message even if no test has explicitly failed.
BUG=407976
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/515513003
Cr-Commit-Position: refs/heads/master@{#292250}
Mpeg2 TS parser: Es parsing using an ES byte queue.
Before this refactoring, the ES management was left
to the ES parser implementation.
It is now moved to the EsParser class and ES management
now relies explicitly on an ES byte queue.
BUG=None
Review URL: https://codereview.chromium.org/497203004
Cr-Commit-Position: refs/heads/master@{#292249}
[Android] Add unit tests for SelectActionBar appearance
The SelectActionBar currently lacks test coverage. Add several test
cases covering the appearance of the bar when interacting with an input
field.
Review URL: https://codereview.chromium.org/506423003
Cr-Commit-Position: refs/heads/master@{#292248}
[Android] Add unit tests for SelectActionBar appearance
The SelectActionBar currently lacks test coverage. Add several test
cases covering the appearance of the bar when interacting with an input
field.
Review URL: https://codereview.chromium.org/506423003
Cr-Commit-Position: refs/heads/master@{#292247}
Always close the server in finally block.
BUG=
Review URL: https://codereview.chromium.org/508233002
Cr-Commit-Position: refs/heads/master@{#292246}
Use ONC for Cellular APN and SimLock in Settings
BUG=279351
For chrome/browser/ui/webui/chromeos/network_config_message_handler.cc:
[email protected]
Review URL: https://codereview.chromium.org/492383002
Cr-Commit-Position: refs/heads/master@{#292245}
[Cast] Fix shutdown race between CastReceiverImpl/FrameReceiver and frame emit callback run.
As described in bug 396413, it was possible for a posted task to be run
after CastReceiverImpl/FrameReceiver were destroyed. This change fixes
the bug by having FrameReceiver post a cancelable task (i.e., using its
WeakPtr) instead.
BUG=396413
Review URL: https://codereview.chromium.org/491953003
Cr-Commit-Position: refs/heads/master@{#292244}
Omnibox: Make URLs of Bookmarks Searchable - Try 2
This is a reland of
https://codereview.chromium.org/489373005/
which was reverted because it caused failures in interactive_ui_tests on mac
on OmniboxViewTest.AcceptKeywordBySpace:
https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20(dbg)(1)/builds/52199
See [1].
It turns out these failures were because the test uses a bookmark with no
title and BookmarkProvider doesn't set classifications for these correctly.
(It set the title as having a classification where, without any text, it
doesn't make sense to have any classification.)
This change fixes this issue and adds a test in BookmarkProvider for it.
I will annotate the *second* patchset I upload with the differences
between the previously-reviewed changelist and this changelist.
(The first patchset has debug lines; ignore it.)
Otherwise, the changelist description remains the same, which I will paste
below [2].
I am marking this change as
TBR=sky
(because he previously reviewed this change and the new parts are
not under his purview.)
---
[1]
OmniboxViewTest.AcceptKeywordBySpace (run #1):
[ RUN ] OmniboxViewTest.AcceptKeywordBySpace
[12075:263:0822/122851:ERROR:location_bar_view_mac.mm(592)] Not implemented reached in virtual void LocationBarViewMac::EndOriginChipAnimations(bool)
[12075:263:0822/122852:FATAL:autocomplete_match.cc(516)] Check failed: classifications.empty().
0 libbase.dylib 0x1ca75c5f base::debug::StackTrace::StackTrace() + 63
1 libbase.dylib 0x1ca75cbb base::debug::StackTrace::StackTrace() + 43
2 libbase.dylib 0x1cb21862 logging::LogMessage::~LogMessage() + 82
3 libbase.dylib 0x1cb2058b logging::LogMessage::~LogMessage() + 43
4 interactive_ui_tests 0x11fb469d AutocompleteMatch::ValidateClassifications(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::vector\u003CAutocompleteMatch::ACMatchClassification, std::allocator\u003CAutocompleteMatch::ACMatchClassification> > const&) const + 317
5 interactive_ui_tests 0x11fb453b AutocompleteMatch::Validate() const + 107
6 interactive_ui_tests 0x11fbbb51 AutocompleteResult::Validate() const + 113
7 interactive_ui_tests 0x0d6f5a3f AutocompleteController::UpdateResult(bool, bool) + 815
8 interactive_ui_tests 0x0d6f55b7 AutocompleteController::Start(AutocompleteInput const&) + 1799
...
[2]
This used to be controlled by a field trial created in
https://codereview.chromium.org/184663002
After evaluating this change, we've decided to launch it.
This change turns the flag on by default and removes the field trial code.
It also removes the index_urls_ parameters everywhere because those will
always be true forevermore.
I tested this interactively.
Also, all the unit tests still apparently pass. And yes some of these do
exercise this feature.
BUG=157204,378854
Review URL: https://codereview.chromium.org/510533002
Cr-Commit-Position: refs/heads/master@{#292243}
Remove an unncessary check on signature length being 0.
BUG=407863
Review URL: https://codereview.chromium.org/512493003
Cr-Commit-Position: refs/heads/master@{#292242}
Add directory for Chromecast media related components.
BUG=408189
Review URL: https://codereview.chromium.org/509103002
Cr-Commit-Position: refs/heads/master@{#292241}
Roll BoringSSL.
Brings in the following commits:
1f3591d Export CBS_asn1_ber_to_der.
25c93ff Fix BN_sub documentation.
854dd65 Refactor server-side CertificateVerify handling.
5b8f104 Revise hash management for reading the Finished message.
880b14e Compute the Channel ID hash after ssl_get_message.
590cbe9 Introduce a hash_message parameter to ssl_get_message.
912806b Fix build (broken by MD4_CTX redefine).
bbac844 Add missing <errno.h> include.
3cb50e0 Move a variable declaration to function start.
98ad22e Fix "integer constant is too large for 'long' type" errors.
58f9095 Remove hack in parsing PKCS#12.
0eb1aae Readd EC_GROUP_get_curve_GFp.
539112f Readd EVP_CIPHER_CTX_set_key_length.
c9eb7ea Readd MD4.
8da9906 Rename some message functions for consistency.
e58c4f5 Add a test to ensure False Start occurs.
ef86550 Remove logic for non-signing client certificates.
a08e49d Add basic TLS Channel ID tests.
4e99c52 Fix FalseStart-SessionTicketsDisabled tests.
2561dc3 Introduce a mechanism for base64 options.
d698f32 Introduce EVP_DecodeBase64.
3a66e28 Update ssl3_get_channel_id for the simpler ECDSA_do_verify.
d30a990 Implement TLS Channel ID in runner.go
f9b96fa Fix flipped DTLS checks.
2a0c496 Fix duplicate test name.
8e16b6e Add PKCS#12 parser.
9c01e00 Rework support for ASN.1 BER.
cc8fcf4 Add 40-bit RC2 support.
9169c96 Implement client side of TLS signed certificate stamps extension.
c44d2f4 Convert all zero-argument functions to '(void)'
BUG=none
Review URL: https://codereview.chromium.org/511703002
Cr-Commit-Position: refs/heads/master@{#292240}
Revert "Disable the CheckPolicyIndicators test in debug config on Windows."
The patch that caused the failure has been fixed. (r288954)
BUG=402233
[email protected]
Review URL: https://codereview.chromium.org/507913005
Cr-Commit-Position: refs/heads/master@{#292239}
Made ChromeSyncShellTest.apk run on the fyi-tests bot.
BUG=406538
Review URL: https://codereview.chromium.org/511453003
Cr-Commit-Position: refs/heads/master@{#292238}
Fix foreign tabs with > 6 navigations not showing up on Android, take 2.
The original CL (http://crrev.com/433633002) caused crashes and was
reverted; this CL only forces out-of-bounds indexes in-bounds, and
leaves in the other checks.
BUG=378992,399763
Review URL: https://codereview.chromium.org/510043002
Cr-Commit-Position: refs/heads/master@{#292237}
Update old syntax for action default_icon to populate 19 and 38px icons
BUG=404572
Review URL: https://codereview.chromium.org/508783002
Cr-Commit-Position: refs/heads/master@{#292236}
Add IsAuthenticated() method to SigninManager to check for connected profile.
Make sure callers are using GetAuthenticatedUsername and GetAuthenticatedAccountId correctly.
BUG=341408
[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/479353003
Cr-Commit-Position: refs/heads/master@{#292235}
Clean up documentation
BUG=406053
Review URL: https://codereview.chromium.org/514883002
Cr-Commit-Position: refs/heads/master@{#292234}
Remove implicit conversions from scoped_refptr to T* in net/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/509563003
Cr-Commit-Position: refs/heads/master@{#292233}
Remove implicit conversions from scoped_refptr to T* in components/search_provider_logos/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/497723004
Cr-Commit-Position: refs/heads/master@{#292232}
Remove ledger code from Chrome.
Since the code from the ledger* internal repos has now been open-sourced, we should get rid of this code from Chrome.
[email protected], [email protected], [email protected]
BUG=None.
Review URL: https://codereview.chromium.org/510893003
Cr-Commit-Position: refs/heads/master@{#292231}
Make gn deps for extensions API registration consistent with gyp dependencies.
BUG=405226
Review URL: https://codereview.chromium.org/509143002
Cr-Commit-Position: refs/heads/master@{#292230}
Revert of Revert "Typecheck JS files for chrome://extensions" (patchset #1 of https://codereview.chromium.org/508283002/)
Reason for revert:
fixed check_licenses issues
Original issue's description:
> Revert "Typecheck JS files for chrome://extensions"
>
> This reverts commit 405253b7ee22ecb318d3c1ca9187e1e7259e704f.
>
> Caused a liscene failure on android bot:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/87b3206
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/512003002
Cr-Commit-Position: refs/heads/master@{#292229}
Clear restore bounds for user resize/drag actions.
When the window is not snapped, user resizes should always clear restore
bounds. This allows user initiated resizes to not be unexpectedly
ignored.
BUG=405563
TEST=WorkspaceWindowResizerTest.RestoreClearedOnResize
Review URL: https://codereview.chromium.org/477823003
Cr-Commit-Position: refs/heads/master@{#292228}
Aggregate damage rects in surface aggregator
The surface aggregator should keep track of the last frame from each surface that was aggregated, and use that to determine what the appropriate damage rect is for the next aggregation.
BUG=
TEST=chrome --use-surfaces --disable-gpu
Review URL: https://codereview.chromium.org/506273002
Cr-Commit-Position: refs/heads/master@{#292227}
Cleanup: Remove unneeded ui/ grit header includes.
Command used: for f in `find ui -name *.grd`; do echo GRD: $f; ./tools/unused-grit-header.py $f android_webview apps ash cc chromecast chromeos content chrome extensions gpu media pdf printing remoting webkit; done
Review URL: https://codereview.chromium.org/515433002
Cr-Commit-Position: refs/heads/master@{#292226}
Remove Extension Loaded/Unloaded notifications from LocationBarView(Mac)
Having the views observe these notifications is strange -- they don't know when
page actions are updated in any other ways, so they shouldn't need to know for
this. Move the notifications to LocationBarController.
Bonuses:
- Less code! By 50 lines!
- Remove four deprecated notification uses!
This has a very loose dependency on https://codereview.chromium.org/508563003/.
BUG=407672
Review URL: https://codereview.chromium.org/505373002
Cr-Commit-Position: refs/heads/master@{#292225}
Model <webview> and <appview> script injection after <extensionoptions>
BUG=407833
Review URL: https://codereview.chromium.org/512543002
Cr-Commit-Position: refs/heads/master@{#292224}
Docserver: Generate a table of extension/app API owners
BUG=400760
NOTRY=True
Review URL: https://codereview.chromium.org/453713002
Cr-Commit-Position: refs/heads/master@{#292223}
mojo: Fix double character inserts on Windows by removing a Linux hack.
If we're going to make mojo a write-once-run-anywhere platform, we'll
have to smooth over platform differences in event handling. Currently,
we have code that tries to emulate this behaviour at different levels
of the chrome stack on Linux. This emulation code lead to the double
character insertion bug on Windows: things looked fine on Linux
because we had another hack to cover up the lack of character events,
which just caused double character insertion on Windows.
In this patch, we declare the Windows style of events (a keydown,
a translated character event, a keyup) as canonical and what
should be targeted going forward.
BUG=403514
Review URL: https://codereview.chromium.org/476283006
Cr-Commit-Position: refs/heads/master@{#292222}
Mojo javascript encoder: Empty string encoded as NULL.
Instead, encode null as NULL (and not just any falsy value) via
a == comparison with null (and use ==, not === to treat undefined
the same way as null).
BUG=407258
Review URL: https://codereview.chromium.org/511443002
Cr-Commit-Position: refs/heads/master@{#292221}
Address flaky test by waiting for focus change.
This change attempts to fix a flaky test by changing the KeyPress function to
use SendKeyPressAndWait which will wait for an event. The event that this test
will wait for is the focus change event that should get called when an element
in the web form changes focus.
BUG=405711
Review URL: https://codereview.chromium.org/503863002
Cr-Commit-Position: refs/heads/master@{#292220}
Fix check_licenses for comment with "copyright" in it.
[email protected]
BUG=none
TEST=green tree
Review URL: https://codereview.chromium.org/492623005
Cr-Commit-Position: refs/heads/master@{#292219}
Revert of Revert "TestWebServer needs to use a free port." (patchset #1 of https://codereview.chromium.org/514443002/)
Reason for revert:
I will land the following CL to fix the findbugs warning
https://codereview.chromium.org/513583002/
Then I will revert the revert.
Original issue's description:
> Revert "TestWebServer needs to use a free port."
>
> Causing Android Build (dbg) findbugs to fail.
>
> This reverts commit c4a3f88c4434e86057a8c7ae4e109b8be4138d8f.
>
> BUG=none
> TBR=hush
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/b055d91
[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/512573002
Cr-Commit-Position: refs/heads/master@{#292218}
Roll libvpx 563c46:4e6bc0 //r291625:r291661
For the actual changes, see:
https://codereview.chromium.org/506203004/
[email protected]
[email protected]
BUG=https://code.google.com/p/webrtc/issues/detail?id=3747
Review URL: https://codereview.chromium.org/513593002
Cr-Commit-Position: refs/heads/master@{#292217}
Send Android accessibility event when object location changes.
Note that the LOCATION_CHANGED event isn't explicitly handled, it just gets mapped to a WINDOW_CONTENT_CHANGED event on Android.
BUG=407871
Review URL: https://codereview.chromium.org/510513003
Cr-Commit-Position: refs/heads/master@{#292216}
Implement <extensionoptions> deferred attach logic
Due to how the browser plugin is created, it is possible for the
<extensionoptions> element to attempt to attach to the embedder before
the browser plugin has bindings. This occurs when an ExtensionOptions object
gets an extension id and creates a guest, but has not yet been added
to the DOM. Use the deferred attach logic from <webview> so that if this
case occurs, wait until the browser plugin gets its bindings before
trying to attach the guest view.
BUG=386838
Review URL: https://codereview.chromium.org/457653003
Cr-Commit-Position: refs/heads/master@{#292215}
NaCl docs: fix community index
The ReST URL was bad, and somehow it started parsing differently, maybe because I have a newer version of the ReST parser.
TBR= [email protected], [email protected]
TEST=none
BUG=none
NOTRY=true
(documentation only change)
Review URL: https://codereview.chromium.org/504343006
Cr-Commit-Position: refs/heads/master@{#292214}
NaCl documentation: update release notes for Chrome 38
Please let me know if I'm missing anything on the release notes.
Some other files updated, they seem to have been forgotten by previous commits.
[email protected], [email protected], [email protected]
BUG= none
TEST= none
NOTRY=true
(documentation only change)
Review URL: https://codereview.chromium.org/477203002
Cr-Commit-Position: refs/heads/master@{#292213}
Docserver: Add more skip_not_found support and cache "not found"s
BUG=305280
NOTRY=True
Review URL: https://codereview.chromium.org/512453002
Cr-Commit-Position: refs/heads/master@{#292212}
[NaCl SDK] Update build_version.ChromeVersion to return "trunk.###"
This will make the SDK archive step upload to the correct URL for trunk builds.
No tries because this does not affect the Chrome build.
BUG=none
[email protected], [email protected]
TEST=ran locally
Review URL: https://codereview.chromium.org/510133002
Cr-Commit-Position: refs/heads/master@{#292211}
Fix overzealous CHECK in custom EC_KEYs.
If any EC_KEY with EX_DATA is duplicated, whether or not it is one of ours,
ExDataDup may get called. This is unlikely to ever happen (I don't think
we ever dup any EC_KEY on the client, and dup_ex_data has a fast-path if
the EX_DATA has never been touched anyway), but the CHECK is a little
overzealous.
BUG=none
Review URL: https://codereview.chromium.org/506813002
Cr-Commit-Position: refs/heads/master@{#292210}
Remove implicit conversions from scoped_refptr to T* in tools/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/499903004
Cr-Commit-Position: refs/heads/master@{#292209}
Revert "Typecheck JS files for chrome://extensions"
This reverts commit 405253b7ee22ecb318d3c1ca9187e1e7259e704f.
Caused a liscene failure on android bot:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio
Review URL: https://codereview.chromium.org/508283002
Cr-Commit-Position: refs/heads/master@{#292208}
Revert of Disable slow BootstrapSandboxTest.DistributedNotifications_SandboxDeny (patchset #1 of https://codereview.chromium.org/498193002/)
Reason for revert:
Unclear reason for disable.
Original issue's description:
> Disable slow BootstrapSandboxTest.DistributedNotifications_SandboxDeny
>
> TBR=rsesek
>
> BUG=407066
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/f1bd7f7
[email protected]
BUG=407066
Review URL: https://codereview.chromium.org/508873003
Cr-Commit-Position: refs/heads/master@{#292207}
Remove a TODO which is no longer applicable.
Review URL: https://codereview.chromium.org/503293003
Cr-Commit-Position: refs/heads/master@{#292206}
Use OAuth2AccessTokenFetcher implementation on Android. This cleans up the way that AO2TS overrides functionality from the base class to differentiate the way that access tokens are minted, and makes the overriding mechanism for android the same as for iOS. Its possible to reimplement OAuth2AccessTokenFetcher now that Mihai extended for use in bling.
BUG=390353
Review URL: https://codereview.chromium.org/345703003
Cr-Commit-Position: refs/heads/master@{#292205}
closure: make tracking script cwd-independent.
[email protected],[email protected]
BUG=393873
TEST=cd third_party/closure_compiler && ./tools/compile_coverage.py
NOTRY=true
Review URL: https://codereview.chromium.org/507953002
Cr-Commit-Position: refs/heads/master@{#292204}
Check for integer overflow when HMAC key length as bits cannot fit in an unsigned int.
Review URL: https://codereview.chromium.org/508793002
Cr-Commit-Position: refs/heads/master@{#292203}
Componentize component_updater: Break content/ dependency for rest of component_updater tests.
BUG=371463
Review URL: https://codereview.chromium.org/514473002
Cr-Commit-Position: refs/heads/master@{#292202}
NotEnoughFramesError no longer raises an exception.
Instead, it causes smoothness metrics to have None values. Additionaly,
the smoothness metric in smoothness.py has been refactored to more
easily support (the newly added) unit tests.
BUG=
Review URL: https://codereview.chromium.org/476363002
Cr-Commit-Position: refs/heads/master@{#292201}
Check Firewall state only initializing mDns from PrintPreview.
BUG=366408
Review URL: https://codereview.chromium.org/504223005
Cr-Commit-Position: refs/heads/master@{#292200}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/prerender/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/509573002
Cr-Commit-Position: refs/heads/master@{#292199}
Remove implicit conversions from scoped_refptr to T* in components/component_updater/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/505203003
Cr-Commit-Position: refs/heads/master@{#292198}
net: enable SSL_MODE_CBC_RECORD_SPLITTING with OpenSSL.
This enables 1/n-1 record splitting, which we have done with NSS for a
long time. No compat issues are expected with this.
(This does not appear to be a regression from the OpenSSL -> BoringSSL
switch as I don't see that a record splitting patch was previously
included.)
BUG=none
Review URL: https://codereview.chromium.org/508803003
Cr-Commit-Position: refs/heads/master@{#292197}
Mark some member variables as "const".
Review URL: https://codereview.chromium.org/506143003
Cr-Commit-Position: refs/heads/master@{#292196}
Typecheck JS files for chrome://extensions
BUG=393873
[email protected]
TEST=gyp --depth . chrome/browser/resources/extensions/compiled_resources.gyp && ninja -C out/Default
Review URL: https://codereview.chromium.org/475633006
Cr-Commit-Position: refs/heads/master@{#292195}
Roll dom_distiller_js
Picked up changes:
078e633 Add support for outputting debug info in result.
0cc1705 Instrument DomDistiller with timing information.
73e3327 rejiggle 1 table classification heuristic
BUG=368941
Review URL: https://codereview.chromium.org/505183003
Cr-Commit-Position: refs/heads/master@{#292194}
Removed outdated documentation from bisect output, redirected it to chromium.org documentation
BUG=
Review URL: https://codereview.chromium.org/507723002
Cr-Commit-Position: refs/heads/master@{#292193}
Skia roll 4473be8:6b0d6b4
https://skia.googlesource.com/skia/+log/4473be874f70d4a8833180a7aebcc9d8a0b1de9e..6b0d6b43cf662735dc804d8142383452c7f246f9
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/509053002
Cr-Commit-Position: refs/heads/master@{#292192}
Remove implicit conversions from scoped_refptr to T* in components/invalidation/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/503353002
Cr-Commit-Position: refs/heads/master@{#292191}
Surface battery auditing information on the website settings option page.
BUG=372607
Review URL: https://codereview.chromium.org/501063002
Cr-Commit-Position: refs/heads/master@{#292190}
Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #2 of https://codereview.chromium.org/504823003/)
Reason for revert:
Appears to leak bitmaps.
Original issue's description:
> Try backing SkPicture with SkRecord in Chromium.
>
> This is our first attempt, mostly to feel this out. Performance and
> correctness problems are both possible. Please revert this if a benchmark even
> smells funny.
>
> That said, we've been working on this a while, are pretty confident it's good
> stuff, and have had Skia's internal testing entirely switched over for a week.
> Parts of Chromium that serialize and deserialize SkPictures are already
> switched over. This CL finishes things off by switching the default
> recorded-from-scratch SkPicture to use SkRecord too.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/513793003
Cr-Commit-Position: refs/heads/master@{#292189}
Use Git hash to post try job http request to bisect builders.
Always use Git hash to post build request since Commit positions are
not supported by builders to build.
BUG=407898
NOTRY=true
Review URL: https://codereview.chromium.org/508723004
Cr-Commit-Position: refs/heads/master@{#292188}
Remove service worker concepts from apps/extensions manifest parsing.
BUG=396340
Review URL: https://codereview.chromium.org/447783003
Cr-Commit-Position: refs/heads/master@{#292187}
Componentize component_updater: Delete old test data files.
This is step 3 of this:
1) Copy the binary files into components/test/data.
2) Move the tests.
3) Delete the (now unused) old binary files in chrome/test/data.
BUG=371463
Review URL: https://codereview.chromium.org/497163002
Cr-Commit-Position: refs/heads/master@{#292186}
Whitelist the internal hotrod apps.
BUG=407693
Review URL: https://codereview.chromium.org/508743002
Cr-Commit-Position: refs/heads/master@{#292185}
Add API to get the UIResourceProvider from ContentViewRenderView
To be able to use thumbnail store related code, we need to be able to
use UIResourceProviders in ContentViewRenderView. This add the necessary
API and pipes it to java.
BUG=404500
CQ_TRYBOTS=tryserver.chromium.linux:android_aosp,android_clang_dbg,android_dbg.
Review URL: https://codereview.chromium.org/493853005
Cr-Commit-Position: refs/heads/master@{#292184}
cc: Report only on active tiles in tracing.
This patch changes which tiles we report on. Previously, we logged
all of the available tiles. Now, we only log tiles that are active.
That is, only tiles that are on either active or pending trees are
logged.
The way this is done is as follows:
- Walk the tree, layers, tilings
- Insert all tiles from a tiling into a set
- Stuff those into a trace.
BUG=403094
Review URL: https://codereview.chromium.org/493543002
Cr-Commit-Position: refs/heads/master@{#292183}
Adding histogram to count number of RTTs for handshake when confirmation is required.
BUG=
Review URL: https://codereview.chromium.org/502243002
Cr-Commit-Position: refs/heads/master@{#292182}
net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#292181}
Change the ServiceWorkerCacheStorage's loader from a ref ptr to scoped and guarantee that callbacks passed to the loader are called by making functions static and passing WeakPtrs.
Part of the following CL chain to guarantee callbacks are called throughout ServiceWorkerCacheStorage:
* 1. Guarantee CacheLoader callbacks: https://codereview.chromium.org/504233003/
2. Guarantee LazyInit callbacks: https://codereview.chromium.org/512743002/
3. Guarantee Create/Delete callbacks: https://codereview.chromium.org/511893002/
4. Reorganize the methods: https://codereview.chromium.org/510813002/
BUG=392621
Review URL: https://codereview.chromium.org/504233003
Cr-Commit-Position: refs/heads/master@{#292180}
[NaCl SDK] Fix the SDK builders to use Cr-Commit-Position.
We are relying on lastchange.FetchVersionInfo in build_sdk.py. The revision
changed from being an SVN revision to a git sha, but we want to be able to
compare the values numerically.
This change modifies build_version.py to get "Cr-Commit-Position", which for
our purposes is functionally equivalent to the SVN revision.
BUG=none
[email protected], [email protected]
Review URL: https://codereview.chromium.org/507883003
Cr-Commit-Position: refs/heads/master@{#292179}
Make sure avatar menu does not use account_id for display purposes.
BUG=341408
Review URL: https://codereview.chromium.org/471333003
Cr-Commit-Position: refs/heads/master@{#292178}
Remove PageActionsController
Since we've consolidated most of the extension action execution code, this
object is rather unneeded. Remove it.
BUG=407665
Review URL: https://codereview.chromium.org/508563003
Cr-Commit-Position: refs/heads/master@{#292177}
Revert of Used native deinterleaved and float point format for the input streams. (patchset #5 of https://codereview.chromium.org/501823002/)
Reason for revert:
It broke the mac asan bot, http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/1976
Original issue's description:
> Used native deinterleaved and float point format for the input streams.
>
> If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.
>
> This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.
>
>
> BUG=404884
> TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1a9ce977642c7f2cc2e30d83757c42264f052f0b
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=404884
Review URL: https://codereview.chromium.org/514773002
Cr-Commit-Position: refs/heads/master@{#292176}
gpu: support immutable texture on Linux Mesa driver and GLES3.
Mesa GL driver supports GL_ARB_texture_storage extensions, not
GL_EXT_texture_storage. GLES3 supports glTexStroage2D by default.
GLES3 doesn't support BGRA format for immutable texture without
GL_APPLE_texture_format_bgra8888 extension. We prefer BGRA support
to immutable texture support, so GLES3 enables immutable texture
only if it supports GL_APPLE_texture_format_bgra8888.
In addition, currently the compositor blindly uses BGRA on glTexStorage2D.
It can cause a potential bug so this CL checks BGRA format support
to use BGRA on glTexStorage2D.
This CL makes Intel GPU (e.g. Intel Chromebook) and GLES3 devices with
GL_APPLE_texture_format_bgra8888 extension take advantage of immutable
texture.
BUG=407034
Review URL: https://codereview.chromium.org/499283002
Cr-Commit-Position: refs/heads/master@{#292175}
Move SetUserData of BlobDataHandles from UploadDataStreamBuilder to ResourceDispatcherHostImpl.
BUG=402387
Review URL: https://codereview.chromium.org/492603002
Cr-Commit-Position: refs/heads/master@{#292174}
Include better OpenSSL error information in NetLog.
The 'ssl_lib_error' value reported is rather uninteresting. OpenSSL is has two
levels of errors. The one we were logging is almost always 1. Make the error
callback SSL-implementation-specific and include the library code, reason code,
file name, and line number, all of which OpenSSL already tracks.
BUG=286480
Review URL: https://codereview.chromium.org/494913002
Cr-Commit-Position: refs/heads/master@{#292173}
Update trace-viewer to r1534
R=nduca
Review URL: https://codereview.chromium.org/507103002
Cr-Commit-Position: refs/heads/master@{#292172}
Blink roll 180956:180973
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180956%3A180973&mode=html
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/508153002
Cr-Commit-Position: refs/heads/master@{#292171}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/printing/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/506163002
Cr-Commit-Position: refs/heads/master@{#292170}
Remove implicit conversions from scoped_refptr to T* in chrome/*/extensions/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/506883003
Cr-Commit-Position: refs/heads/master@{#292169}
Re-enable memory tests. Fixed sign-in issue.
Re-recording other tests may be required.
BUG=370977
Review URL: https://codereview.chromium.org/491863003
Cr-Commit-Position: refs/heads/master@{#292168}
PepperWebSocketHost should not call blink::WebSocket APIs after closed.
blink::WebSocket assumes that any APIs won't be called once disconnect is
called, but PepperWebSocketHost didn't keep the contract. Note that
PepperWebSocketHost can receive SEND* / CLOSE messages even if it sends
a CLOSED message to the ppapi process, because these IPCs are asynchronous.
BUG=407885
[email protected]
Review URL: https://codereview.chromium.org/510663002
Cr-Commit-Position: refs/heads/master@{#292167}
Update V8 to version 3.29.20.2 (merged r23463).
[email protected]
Review URL: https://codereview.chromium.org/510653003
Cr-Commit-Position: refs/heads/master@{#292166}
[aw] Fix crash when "misbehave" app exits fullscreen.
exitFullScreen() might be call without a prior call to
enterFullScreen() if a "misbehave" app overrides onShowCustomView
but does not add the custom view to the window. This fixes a
crash by returning early from exitFullScreen in that case.
BUG=408133
Review URL: https://codereview.chromium.org/501093007
Cr-Commit-Position: refs/heads/master@{#292165}
Update OWNERS in c/b/ui/webui/chromeos
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/506313003
Cr-Commit-Position: refs/heads/master@{#292164}
Add gcapi to windows archives
BUG=407860
NOTRY=True
Review URL: https://codereview.chromium.org/480563003
Cr-Commit-Position: refs/heads/master@{#292163}
Rename components/breakpad to components/crash.
In the near future, Crashpad (the new Mac crash reporter) will be integrated,
and it should be integrated/exposed transparently to the users of this
component.
BUG=406410
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/485893007
Cr-Commit-Position: refs/heads/master@{#292162}
Mac Video Capture: Connect AVFoundation for Canary and Developer builds. Other channels unaffected.
BUG=408089
Review URL: https://codereview.chromium.org/511863002
Cr-Commit-Position: refs/heads/master@{#292161}
Fix AndroidRndisForwarder.
It's trying to use a member variable which doesn't exist, and thus throwing an
exception every time it's used.
The brokenness was introduced by r290923 (
https://codereview.chromium.org/404803003/ ).
BUG=
Review URL: https://codereview.chromium.org/508923002
Cr-Commit-Position: refs/heads/master@{#292160}
Fix content build with OS X 10.9 SDK
Missing GL_TEXTURE_RECTANGLE_ARB definition if gl.h or glext.h is
not included.
Review URL: https://codereview.chromium.org/511793002
Cr-Commit-Position: refs/heads/master@{#292159}
Fix regression where mouse hover effect is absent on the browser action chevron
It looks like a SetBorder(NULL) crept into
https://codereview.chromium.org/324393002, and the result is that the chevron
hover effect (i.e., draw a border) is overridden. Remove the call to
SetBorder().
BUG=407518
Review URL: https://codereview.chromium.org/492373004
Cr-Commit-Position: refs/heads/master@{#292158}
Try backing SkPicture with SkRecord in Chromium.
This is our first attempt, mostly to feel this out. Performance and
correctness problems are both possible. Please revert this if a benchmark even
smells funny.
That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over. This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.
BUG=
Review URL: https://codereview.chromium.org/504823003
Cr-Commit-Position: refs/heads/master@{#292157}
Add support for tracing in browser tests.
This CL adds support for collecting tracing data during the execution of browser tests. It is currently not possible to do so, yet it is very useful to be able to collect this data and analyze it without having to step through with debugger.
BUG=
Review URL: https://codereview.chromium.org/506113002
Cr-Commit-Position: refs/heads/master@{#292156}
Skia roll 5e8dbd3:4473be8
https://skia.googlesource.com/skia/+log/5e8dbd31de0dff44aff83295bdfe518477a5a088..4473be874f70d4a8833180a7aebcc9d8a0b1de9e
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
[email protected]
Review URL: https://codereview.chromium.org/508113002
Cr-Commit-Position: refs/heads/master@{#292155}
mojo: generate Proxies and Stubs for java bindings.
This CL allows to generate Stub and Proxy of mojo service in java. This
allows to call interfaces method through message pipes.
Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57
Review URL: https://codereview.chromium.org/411913002
Cr-Commit-Position: refs/heads/master@{#292154}
Fix tracking area initialization for the mac password bubble.
It turns out specifying a "when" option is required, or it throws an
exception :(
BUG=
Review URL: https://codereview.chromium.org/512683002
Cr-Commit-Position: refs/heads/master@{#292153}
Revert of Remove unused PPB_View_Dev (patchset #3 of https://codereview.chromium.org/498123002/)
Reason for revert:
I should've checked sooner; this is apparently still used by Flash. (See go/UMA, histograms, Pepper.InterfaceUsed)
Original issue's description:
> Remove unused PPB_View_Dev
>
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2210d5fb49cd4b75972f2e304b29637c050de4f1
[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/512703003
Cr-Commit-Position: refs/heads/master@{#292152}
Used native deinterleaved and float point format for the input streams.
If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.
This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.
BUG=404884
TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html
Review URL: https://codereview.chromium.org/501823002
Cr-Commit-Position: refs/heads/master@{#292151}
Fixing the enhanced bookmark namespace.
BUG=None
Review URL: https://codereview.chromium.org/456793002
Cr-Commit-Position: refs/heads/master@{#292150}
android_webview: roll AOSP bot manifest.
Update to a recent version of AOSP master. The primary effect on
Chromium is that the android_aosp bot will now use a recent version of
clang when building chromium targets for host and thus we no longer need
to support using gcc 4.2 or 4.6 to compile host code here.
BUG=377684
NOTRY=true
Review URL: https://codereview.chromium.org/514653002
Cr-Commit-Position: refs/heads/master@{#292149}
[MIPS] Add support in common.gypi for building MIPS64
Add missing variables (android_ndk_*) for building Chromium for MIPS64.
In addition to this, set default mips_arch_variant-s for different MIPS
platforms.
BUG=400684
Review URL: https://codereview.chromium.org/494713002
Cr-Commit-Position: refs/heads/master@{#292148}
Rename HostZoomMap::GetForBrowserContext() to GetDefaultForBrowserContext().
HostZoomMap will be moving from BrowserContext to StoragePartition soon
as part of fixing this bug. Many sites will still want to access the
default HostZoomMap for a BrowserContext, so we will rename this
function in order to be clear about that.
BUG=335317
Review URL: https://codereview.chromium.org/506073002
Cr-Commit-Position: refs/heads/master@{#292147}
ui: Move ui_unittests.gyp into ui/base.
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate
Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.
BUG=331829,373148,299841,103304
TEST=ui_unittests
[email protected]
Review URL: https://codereview.chromium.org/506483002
Cr-Commit-Position: refs/heads/master@{#292146}
Fixed BubbleBorder sizing problems & added unit tests.
BUG=395622
TEST=automated
Review URL: https://codereview.chromium.org/454173002
Cr-Commit-Position: refs/heads/master@{#292145}
VideoCaptureDeviceWin: correct some typos and docs.
BUG=
Review URL: https://codereview.chromium.org/512713002
Cr-Commit-Position: refs/heads/master@{#292144}
Blink roll 180903:180956
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180903:180956&mode=html
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/513753002
Cr-Commit-Position: refs/heads/master@{#292143}
Reland WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo originally landed in https://codereview.chromium.org/442313002/
The only difference is that the test has been disabled on
DrMemory since it times out. Notice that many WebRtcBrowsertests are disabled due to the same reason.
BUG= 403070, 398844
Review URL: https://codereview.chromium.org/478543004
Cr-Commit-Position: refs/heads/master@{#292142}
Update AnalysisCanvas drawRect early-exit logic to match SkCanvas.cpp again.
We're getting away without checking bounds today because we're building
and checking a bounding-box hierarchy at record time; draws outside the
picture bounds happen to never be recorded.
This isn't a guarantee of the recording API, and indeed doesn't happen if you
record without a bounding-box hierarchy. We want to lean on this lack of
guarantee a bit more. To cut down on time spent recording, we may move around
when we build a bounding box hierarchy. The upshot is that the SkPicture may
contain commands that won't draw anything, and AnalysisCanvas might receive them.
In short, the safe thing to do is quickReject just like SkCanvas does.
tested: cc_unittests, unit_tests
(Background: found this when debugging PicturePileImplTest.AnalyzeIsSolid* failures from http://crrev.com/504823003)
BUG=
Review URL: https://codereview.chromium.org/505263002
Cr-Commit-Position: refs/heads/master@{#292141}
Use MotionEvent::MAX_TOUCH_POINT_COUNT
BUG=None
Review URL: https://codereview.chromium.org/504183005
Cr-Commit-Position: refs/heads/master@{#292140}
Updating trunk VERSION from 2138.0 to 2139.0
Cr-Commit-Position: refs/heads/master@{#292139}
Switch CryptohomeAuthenticator from MountAsync() to MountEx()
This CL switches CryptohomeAuthenticator's mount code from the old
MountAsync() method that takes a password to a MountEx() that takes a
Key for authentication.
BUG=367847
TEST=Updated unit tests
Review URL: https://codereview.chromium.org/488633003
Cr-Commit-Position: refs/heads/master@{#292138}
Revert of mojo: generate Proxies and Stubs for java bindings. (patchset #16 of https://codereview.chromium.org/411913002/)
Reason for revert:
Fails license check on android bot:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64641
Original issue's description:
> mojo: generate Proxies and Stubs for java bindings.
>
> This CL allows to generate Stub and Proxy of mojo service in java. This
> allows to call interfaces method through message pipes.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57
[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/511543005
Cr-Commit-Position: refs/heads/master@{#292137}
mojo: generate Proxies and Stubs for java bindings.
This CL allows to generate Stub and Proxy of mojo service in java. This
allows to call interfaces method through message pipes.
Review URL: https://codereview.chromium.org/411913002
Cr-Commit-Position: refs/heads/master@{#292136}
Track empty username and password in PasswordStore.
Having both username and password empty is incorrect. We should find out where they come from.
BUG=404012
Review URL: https://codereview.chromium.org/514573002
Cr-Commit-Position: refs/heads/master@{#292135}
Revert "Track empty username and password in PasswordStore."
This reverts https://codereview.chromium.org/493123002. There were too many generated crashes.
BUG=407767
Review URL: https://codereview.chromium.org/512673002
Cr-Commit-Position: refs/heads/master@{#292134}
Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/)
Reason for revert:
Build failure on Google Chrome ChromeOS:
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164
Original issue's description:
> Remove the last piece of deprecated synchronous IO code.
>
> BUG=337096
> TEST=bots
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=337096
Review URL: https://codereview.chromium.org/509893002
Cr-Commit-Position: refs/heads/master@{#292133}
Remove the last piece of deprecated synchronous IO code.
BUG=337096
TEST=bots
Review URL: https://codereview.chromium.org/460373002
Cr-Commit-Position: refs/heads/master@{#292132}
Do not set autofill property when choose option from datalist.
BUG=404818
Review URL: https://codereview.chromium.org/498653003
Cr-Commit-Position: refs/heads/master@{#292131}
Remove implicit conversions from scoped_refptr to T* in ipc/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/507773002
Cr-Commit-Position: refs/heads/master@{#292130}
ServiceWorker: Add prepare_callback in DispatchFetchEvent to notify the end of SW preparation.
This callback is needed to measure the performance of booting ServiceWorker.
BUG=401389
TEST=N/A
Review URL: https://codereview.chromium.org/493373002
Cr-Commit-Position: refs/heads/master@{#292129}
Add additional histogram events for prefetches to the prerender local
predictor.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/498223002
Cr-Commit-Position: refs/heads/master@{#292128}
Componentize google_util_unittest
The file can be moved into the component as-is.
BUG=373245
Review URL: https://codereview.chromium.org/506863003
Cr-Commit-Position: refs/heads/master@{#292127}
Disable the new avatar menu in a test.
This will make the test not fail once the new avatar menu is enabled by default.
BUG=400667
Review URL: https://codereview.chromium.org/489823003
Cr-Commit-Position: refs/heads/master@{#292126}
Cleanup: Combine some identical conditionals in chrome gyp targets.
Review URL: https://codereview.chromium.org/513623002
Cr-Commit-Position: refs/heads/master@{#292125}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/background/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/510453002
Cr-Commit-Position: refs/heads/master@{#292124}
Disable tab syncing when history saving is disabled.
The history page shows the current tabs of synced devices. This works by
having the client upload its open tabs to the server, which feeds this
data into the history backend.
If history saving is disabled by policy then the opens tabs should not
be uploaded to the server. This also prevents them from showing up in
the history page.
BUG=292976,372108,393051
Review URL: https://codereview.chromium.org/394223002
Cr-Commit-Position: refs/heads/master@{#292123}
Store local auth credentials after successful login or re-auth.
BUG=405550
Review URL: https://codereview.chromium.org/508433004
Cr-Commit-Position: refs/heads/master@{#292122}
Cleanup: Remove some unneeded SSE2 checks and unused code. (try 2)
This is a resubmit of https://codereview.chromium.org/459603003 without
the media/ changes.
BUG=349320
[email protected],[email protected]
Review URL: https://codereview.chromium.org/511773002
Cr-Commit-Position: refs/heads/master@{#292121}
