Roll commits from side projects in M128

Roll src/v8 in M128 from 9cc7737c63da to 56d087b15214
Commits rolled:
https://chromium.googlesource.com/v8/v8.git/+log/9cc7737c63da..56d087b15214

Generated by: http://go/bbid/8738520271852584257

Change-Id: I731be1a7fbfb5c909783f8b086f5ab87b6395908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5813802
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1402}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• v8[diff]

Roll commits from side projects in M128

Roll src/v8 in M128 from 8a8a71df0524 to 9cc7737c63da
Commits rolled:
https://chromium.googlesource.com/v8/v8.git/+log/8a8a71df0524..9cc7737c63da

Generated by: http://go/bbid/8738521604429374801

Change-Id: Iec5c1d4000a47d63c1f8b3945a83532a7299bc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5813682
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1401}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• v8[diff]

Roll commits from side projects in M128

Roll src/ios_internal in M128 from 0471ec25dee7 to f54ce57e8a3d
Commits rolled:
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/0471ec25dee7..f54ce57e8a3d

Generated by: http://go/bbid/8738523493170889937

Change-Id: Icb946ff7cdb48aa7dbdae275ae3b7d74f07e2cb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5813542
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1400}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• ios_internal[diff]

Automatic update from google3

Automatic update for 2024-08-26 UTC

Change-Id: I93851451860cf17dcada30ca1fb2bb9236de7064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5811837
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1399}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/certificate_transparency/data/log_list.json[diff]

[m128][omnibox][history-embeddings] Fixes search loupe icon in @history scope

Search loupe with spark was added in crrev.com/c/5685572
Search loupe with spark icon should appear only after opt-in

opted-in: http://screenshot/FAVo29fafagy3Ai
opted-out: http://screenshot/3uuKo7vUAu2GD8f

(cherry picked from commit 351171b75a6dceea95bcd49ce6c65b1698d38faa)

Bug: 361663359, 361834643
Change-Id: I023d43ba758587e2466f5a894fd24effa61cd279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809758
Commit-Queue: Moe Ahmadi <[email protected]>
Auto-Submit: Moe Ahmadi <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1346243}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810078
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1398}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/browser/ui/views/location_bar/location_bar_view.cc[diff]
• chrome/browser/ui/views/location_bar/selected_keyword_view.cc[diff]
• chrome/browser/ui/views/location_bar/selected_keyword_view.h[diff]

Disable RunPerformanceManagerOnMainThreadSync

RunPerformanceManagerOnMainThreadSync feature caused performance
regression on ChromeOS (b/359429603). This is to trigger kill switch for
the feature.

Also since the feature is not released to stable 100% yet, this should
not be enabled by default in the first place.

(cherry picked from commit 606e2b93156e7037714f1fe64ce985299f9480b0)

Bug: 359429603
Change-Id: I6a1500b3f2d468e5493aa234c9acc059df5ff49a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5796022
Commit-Queue: Shin Kawamura <[email protected]>
Auto-Submit: Shin Kawamura <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Reviewed-by: Francois Pierre Doray <[email protected]>
Commit-Queue: Francois Pierre Doray <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1343533}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806084
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1397}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/performance_manager/features.cc[diff]

Remove CHECK in GetMetadata()

ResolvedFrameData::GetMetadata() was checking that resolved frame was
valid after https://crrev.com/c/5673312 landed. This assertion doesn't
hold in some cases so remove it to restore previous behaviour.

(cherry picked from commit 4b4b183065437727e9254f8635595fea38e3d9ae)

Fixed: 354664676, 353971252
Change-Id: Ic56ce3e2442955e803fc64ecc8676a83c96e3cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5746064
Commit-Queue: Kyle Charbonneau <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1334284}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807088
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1396}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/viz/service/display/resolved_frame_data.cc[diff]

Incrementing VERSION to 128.0.6613.98

Change-Id: Ic222e2d42ae9f9f85ff0b1b7a5537486315dfdeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805843
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1395}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/VERSION[diff]

Automatic update from google3

Automatic update for 2024-08-25 UTC

Change-Id: I72c27e02311bdc5eb0a3ffdecf80896919bd9ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808540
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1394}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• net/http/transport_security_state_static.pins[diff]
• net/http/transport_security_state_static_pins.json[diff]

Automatic update from google3

Automatic update for 2024-08-25 UTC

Change-Id: I5c18ead95165b6b342bd63b5e925c876ee4f15fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810401
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1393}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/certificate_transparency/data/log_list.json[diff]

Automated Commit: LKGM 15964.36.0 for chromeos.

Uploaded by https://ci.chromium.org/b/8738677337864880129

Change-Id: I399f2bdce97b6d194115df72bb34e4bd1ce470bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810802
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1392}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chromeos/CHROMEOS_LKGM[diff]

Automatic update from google3

Automatic update for 2024-08-25 UTC

Change-Id: I2f098a51564deb8b0cfe6629c0672bce2edcd323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810555
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1391}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• net/http/transport_security_state_static.pins[diff]
• net/http/transport_security_state_static_pins.json[diff]

Automatic update from google3

Automatic update for 2024-08-25 UTC

Change-Id: I873c7a601413a54f851b729374bd3493168928fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809201
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1390}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/certificate_transparency/data/log_list.json[diff]

Incrementing VERSION to 128.0.6613.97

Change-Id: I4135732e7b4bfa20d2603e4ddaab849f010282e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810662
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1389}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/VERSION[diff]

Automated Commit: LKGM 15964.35.0 for chromeos.

Uploaded by https://ci.chromium.org/b/8738767989686983937

Change-Id: I3c44caa8bfef6b3ae84737e1533b0f33251e6ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810360
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1388}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chromeos/CHROMEOS_LKGM[diff]

Roll commits from side projects in M128

Roll src/third_party/skia in M128 from e0b8a057ab17 to 8bd493b850f1
Commits rolled:
https://skia.googlesource.com/skia.git/+log/e0b8a057ab17..8bd493b850f1

Generated by: http://go/bbid/8738761310304680433

Change-Id: I44626a9d915e1177b6ec3052f33baf131b87682f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805738
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1387}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• third_party/skia[diff]

Send v2 answer data through HistoryEmbeddingsService::SendQualityLog

This CL adds v2 logging support and ensures v2 logging only happens when
the kSendQualityLogV2 feature parameter is enabled. AnswererResult and
SearchResult are made into move-only types, but explicit Clone is
provided to support publishing multiple related search results to front
ends.

This CL also populates the v1 logging execution_id.

(cherry picked from commit d0307aa16c5849f46d3513b185bb149373670624)

Bug: 348690312, 361608276
Change-Id: I03be0e8bada52082adcb7b2bf1a3efb0a7e0cb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809843
Commit-Queue: Orin Jaworski <[email protected]>
Reviewed-by: John Lee <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1386}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/browser/ui/webui/cr_components/history_embeddings/history_embeddings_handler.cc[diff]
• chrome/browser/ui/webui/cr_components/history_embeddings/history_embeddings_handler_unittest.cc[diff]
• components/history_embeddings/answerer.cc[diff]
• components/history_embeddings/answerer.h[diff]
• components/history_embeddings/history_embeddings_features.cc[diff]
• components/history_embeddings/history_embeddings_features.h[diff]
• components/history_embeddings/history_embeddings_service.cc[diff]
• components/history_embeddings/history_embeddings_service.h[diff]
• components/history_embeddings/ml_answerer.cc[diff]
• components/omnibox/browser/history_embeddings_provider_unittest.cc[diff]

[Merge to M128] [Libsecret] Workaround deadlock on initialization

gnome-keyring-daemon has a bug where the first launch will result
in incomplete keyring initialization.  The issue can be seen when
running a newer system like Debian Sid, and using XFCE and lightdm.
The first time a new user logs into the desktop, gnome-keyring-daemon
will launch and try to initialize a default keyring.  It reports an
object path for the default keyring, but the object path doesn't
actually exist.  libsecret detects this and tries to fallback to
initializing the default keyring.  This requires the user to enter a
new password for the keyring, which the gcr-prompter binary handles.
However, the prompt never actually shows up, though the binary is
running.  This causes libsecret to wait indefinitely for the prompt
to finish.  This CL adds a check for this deadlock case and prevents
using libsecret.  If gnome-keyring-daemon is restarted (or the system
rebooted), the issue goes away.  When this occurs, any stored keys
will be migrated from the plaintext backend to the libsecret backend.

Upstream bug reports:
https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/151
https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/149
https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/116

R=thestig

(cherry picked from commit 4ab7e74c7d45464804686f792479f2584b3b9966)

Change-Id: I0a250ddfe6a4f5e8d7ac2b697e99a46fcbea7450
Fixed: 343125281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5787619
Auto-Submit: Thomas Anderson <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1342442}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808010
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1385}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/os_crypt/sync/BUILD.gn[diff]
• components/os_crypt/sync/libsecret_util_linux.cc[diff]

Incrementing VERSION to 128.0.6613.96

Change-Id: I0150eb6f0a7290cbaa89d02d0be116abd498c395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807686
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1384}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/VERSION[diff]

[M128][DIP] Move CHECK back to early-return

crbug.com/352690275 revealed that there are still circumstances in which the
DIP or COEP headers aren't available at cache storage binding time.

This CL just replaces a failing CHECK with an early-return. That was the
original design of the CL introducing the CHECK (and thus it's safe to just
early-abort), but it was believed that a CHECK should have been safe.

(cherry picked from commit 8549cb582b512fb176bae2d98de05c8e1147ffc4)

Change-Id: Ifa3c36dab92fb9478569e64629bac86b214960f7
Bug: 352690275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807281
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Reviewed-by: Harry Souders <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1345694}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809839
Auto-Submit: Joe DeBlasio <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1383}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• content/browser/service_worker/embedded_worker_instance.cc[diff]

[Merge to M128] Reintroduce support for Ubuntu 18.04

This is a selective revert of [1] and [2].  In particular, support
for 18.04 is reintroduced, however development support is not.  So
files like install-build-deps.sh and xvfb.py are not reverted.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5598748
[2] https://chromium-review.googlesource.com/c/chromium/src/+/5671581

R=thestig

(cherry picked from commit df14ef63b2bc818472205e50ad32a3511db4edb2)

Change-Id: I61180662f5b3d7c5677fa56a56e9a60a57f4c786
Bug: 361375791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807209
Commit-Queue: Lei Zhang <[email protected]>
Auto-Submit: Thomas Anderson <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1345636}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808590
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1382}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/installer/linux/debian/calculate_package_deps.py[diff]
• chrome/installer/linux/debian/dist_package_versions.json[diff]
• chrome/installer/linux/debian/update_dist_package_versions.py[diff]

Guard dimensions in Embedding::ScoreWith; don't load missized embeddings

(cherry picked from commit dd1b47866d35bb4f704990363ffe3088dfb636f7)

Fixed: 361074724
Change-Id: I7a32ae5f3211de3bf74803be737401cc186b579a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801452
Reviewed-by: Orin Jaworski <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: manuk hovanesian <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1344515}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808583
Auto-Submit: Orin Jaworski <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1381}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/history_embeddings/sql_database.cc[diff]
• components/history_embeddings/vector_database.cc[diff]
• tools/metrics/histograms/metadata/history/histograms.xml[diff]

[iOS] Limit NAUs only to experiment enabled groups.

This CL fixes an issue where metrics were unusually high in the
registered group.

(cherry picked from commit b07cae6ce3758a6d30dea4dd0b2701b45c769866)

Bug: 359264913
Change-Id: I371c59ac6d58bad1d15f465e00a69ffc02a5e8e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5784355
Auto-Submit: Guillem Perez <[email protected]>
Commit-Queue: Guillem Perez <[email protected]>
Reviewed-by: Tina Wang <[email protected]>
Commit-Queue: Tina Wang <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1340616}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808001
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1380}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• ios/chrome/browser/push_notification/model/push_notification_delegate.mm[diff]

[M128] Speculative fix for a hang in `GetEmojiFont`

crrev.com/c/5622559 changed one-time initialization by
`static bool` to `std::once()`, and this looks like causing a
hang when called from `DEFINE_THREAD_SAFE_STATIC_LOCAL`. This
patch reverts to using `static bool`.

It may run the initialization code multiple times on race
conditions, but doing so should have no harm other than wasted
CPU cycles.

This is a speculative fix.

(cherry picked from commit cee04d1eccff4e65a76ffb93d0888cdeea8aaf24)

Bug: 349456407
Change-Id: I794cec88f6899bf99f41d719d8b2013843ebbd45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776142
Reviewed-by: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1339516}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803368
Reviewed-by: David Baron <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1379}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• third_party/blink/renderer/platform/fonts/win/font_fallback_win.cc[diff]

Cherry pick "Skip database iteration rows with invalid/mismatched data; report counts"

Original change's description:
> Skip database iteration rows with invalid/mismatched data; report counts
> 
> This CL changes history_embeddings::SqlDatabase statement iteration to
> skip some rows and continue iteration, instead of ending iteration or
> possibly yielding data where the number of passages doesn't match the
> number of embeddings. These histograms are reported at the end of
> each full iteration, when the iterator destructs:
> - History.Embeddings.DatabaseIterationSkippedPassages
> - History.Embeddings.DatabaseIterationSkippedEmbeddings
> - History.Embeddings.DatabaseIterationSkippedMismatches
> - History.Embeddings.DatabaseIterationYielded
> 
> Bug: 360947442
> Change-Id: I8167d97365a3a28cfe028e4d674159587c816a64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799066
> Reviewed-by: manuk hovanesian <[email protected]>
> Reviewed-by: Orin Jaworski <[email protected]>
> Commit-Queue: Orin Jaworski <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1344253}

Change-Id: If91653d1730b0c4a586a0c1c0973694a80652130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809305
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1378}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/history_embeddings/sql_database.cc[diff]
• components/history_embeddings/sql_database_unittest.cc[diff]
• tools/metrics/histograms/metadata/history/histograms.xml[diff]

[omnibox] Update "Remove Suggestion" tooltip text to "Close" for IPH.

a11y label was already updated in crrev.com/c/5567073.

(cherry picked from commit ee7d5bd56642780a3a5c95b7dc709c69f3f62bf7)

Fixed: 359936802
Change-Id: Icf2b09229dadf7165d232df2e6e620d315d6eeae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798516
Auto-Submit: Angela Yoeurng <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1344557}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807679
Commit-Queue: Moe Ahmadi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1377}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/app/generated_resources.grd[diff]
• chrome/browser/ui/views/omnibox/omnibox_result_view.cc[diff]
• components/omnibox_strings.grdp[diff]
• components/omnibox_strings_grdp/IDS_ACC_DISMISS_CHROME_TIP_BUTTON.png.sha1[Added - diff]

[M128] Another speculative fix for a hang in `GetEmojiFont`

The crash logs indicate that the hangs still happen after
the speculative fix at crrev.com/c/5776142.

This patch tries another speculative fix, by calling
`FirstAvailableEmojiFont()` outside of the
`DEFINE_THREAD_SAFE_STATIC_LOCAL`, so that the code flow is
closer to before crrev.com/c/5622559.

(cherry picked from commit cde75b618acd32c3ea28238b9a3890da0f971067)

Bug: 349456407
Change-Id: I0db3237d636e32bdeb705ebe196eca2448181481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782507
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1342146}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803028
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1376}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• third_party/blink/renderer/platform/fonts/win/font_fallback_win.cc[diff]

[m128][omnibox][history-embeddings] Fix IPH shown limits

Fixes which IPH is shown and how many times. Applies to all types of
IPHs: featured search, gemini, and history embedding IPHs

This does 3 things:

1)

Before, the shown limit of 3 was shared by all IPHs. After the user sees
3 featured search IPHs, they wouldn't see the other IPHs. Unless the
user manually dismissed the featured search IPH, the user would never
see the 2nd IPH. And likewise, unless the user manually dismissed the
2nd IPH, they'd never see the 3rd IPH; etc.

This CL uses a separate limit per IPH type.

2)

Before, how many times IPHs had been shown was stored as a provider
field member. When a new provider was created (e.g. new browser window),
the shown count would reset to 0, and IPHs would keep showing.

This CL persists the counts to prefs so the user is actually shown the
IPH at most 3 times per IPH type.

3)

This CL adds a cooldown period so users aren't bombarded by multiple
types of IPHs shown after the previous one reaches its limit. To keep it
simple, we limit 3 IPHs shown per provider lifetime. So Opening a new
browser window or restarting chrome will reset the cooldown.

Also replaces the show-prefs with dismissed-prefs. Since none of the IPH
features have launched, discarding any user's existing prefs is probably
fine. Will do a pref cleanup followup CL to remove the old prefs from
users' pref file: crrev.com/c/5798464.

(cherry picked from commit 73e1c2d2ab9318ec8d029750df05e5512dc4f15e)

Bug: 345536978, 345536438, 345536430, 333762301, b/309459121, 358440019
Change-Id: Ifa1aee7c19c8ab1474b531bade3455a4c15ee6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778425
Reviewed-by: Fabio Tirelo <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1344324}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801413
Reviewed-by: Orin Jaworski <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1375}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/omnibox/browser/autocomplete_controller.cc[diff]
• components/omnibox/browser/autocomplete_controller.h[diff]
• components/omnibox/browser/featured_search_provider.cc[diff]
• components/omnibox/browser/featured_search_provider.h[diff]
• components/omnibox/browser/featured_search_provider_unittest.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]
• components/omnibox/browser/omnibox_prefs.cc[diff]
• components/omnibox/browser/omnibox_prefs.h[diff]

Implement safe query filtering using FarmHash and FilterHashes

This CL adds hash-based query filtering driven by a new FilterHashes
parameter for the HistoryEmbeddings feature. It works in addition to
the existing FilterTerms logic so any combination of hashes, terms,
and phrases can be used to filter queries.

(cherry picked from commit 06eae1e5c214154dbb10537cfe778e409dd90085)

Bug: 359936684
Change-Id: Iee2b816244073a3e738843ab8e1678f49929ea78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789003
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1344198}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807724
Auto-Submit: Orin Jaworski <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1374}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/history_embeddings/BUILD.gn[diff]
• components/history_embeddings/DEPS[diff]
• components/history_embeddings/history_embeddings_features.cc[diff]
• components/history_embeddings/history_embeddings_features.h[diff]
• components/history_embeddings/history_embeddings_service.cc[diff]
• components/history_embeddings/history_embeddings_service.h[diff]
• components/history_embeddings/history_embeddings_service_unittest.cc[diff]
• tools/metrics/histograms/metadata/history/enums.xml[diff]

Updating XTBs based on .GRDs from branch 6613

Change-Id: If2b84f903ccfa2d840c725eb9f973c5e0dd1a82c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807668
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1373}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/app/resources/generated_resources_el.xtb[diff]
• chrome/app/resources/generated_resources_fr-CA.xtb[diff]
• chrome/app/resources/generated_resources_gu.xtb[diff]
• chrome/app/resources/generated_resources_pt-BR.xtb[diff]
• chrome/app/resources/generated_resources_sw.xtb[diff]
• chrome/app/resources/generated_resources_te.xtb[diff]
• chrome/app/resources/generated_resources_uk.xtb[diff]
• chrome/app/resources/generated_resources_zh-CN.xtb[diff]
• chrome/browser/ui/android/fast_checkout/internal/java/strings/translations/android_fast_checkout_strings_zh-CN.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ky.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_pt-BR.xtb[diff]
• components/strings/components_strings_ja.xtb[diff]
• components/strings/components_strings_zh-CN.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_kk.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_zh-CN.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_kk.xtb[diff]

[m128][omnibox][history-embeddings] Make matches deletable

m128 respin merge

https://screenshot.googleplex.com/4nFMGxEx7HisiWN

Updates `FakeAutocompleteProviderClient` to mock
HistoryEmbeddingsService on non-iOS builds. iOS builds don't build a lot
of the embeddings files; e.g. `HistoryEmbeddingsService` is undeclared.

(cherry picked from commit 9236b1892427cf05fb05a834206fe5f28a4e2587)

Bug: 332360110, 358440019
Change-Id: I949425db6326a352475c684d457eda020f6934e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786118
Reviewed-by: Moe Ahmadi <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1343765}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801373
Commit-Queue: Moe Ahmadi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1372}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/omnibox/browser/BUILD.gn[diff]
• components/omnibox/browser/fake_autocomplete_provider_client.cc[diff]
• components/omnibox/browser/fake_autocomplete_provider_client.h[diff]
• components/omnibox/browser/history_embeddings_provider.cc[diff]
• components/omnibox/browser/history_embeddings_provider.h[diff]
• components/omnibox/browser/history_embeddings_provider_unittest.cc[diff]

Roll commits from side projects in M128

Roll src/third_party/skia in M128 from fb67954b7e76 to e0b8a057ab17
Commits rolled:
https://skia.googlesource.com/skia.git/+log/fb67954b7e76..e0b8a057ab17

Generated by: http://go/bbid/8738804720609877281

Change-Id: Ib845bfdb034875321ad2a63dcd7097045beee180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803544
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1371}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• third_party/skia[diff]

[m128][omnibox][history-embeddings] Fix indents of IPH matches.

m128 respin merge

https://screenshot.googleplex.com/A4EohjH3tvAoY5T

Fixes the left and right indents for the IPH icons, texts, and texts
without icons.

(cherry picked from commit c11cbce2b4162fba1e9dc40e480f260940b46c51)

Bug: 359597661, 358440019
Change-Id: I74e31fc12754acaf651fa131631d4980c0d917e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5792327
Commit-Queue: manuk hovanesian <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: Angela Yoeurng <[email protected]>
Reviewed-by: Angela Yoeurng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1343711}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801531
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1370}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc[diff]
• chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h[diff]
• chrome/browser/ui/views/omnibox/omnibox_row_view.cc[diff]

[m128][omnibox][history-embeddings] Prioritize IPH link for narrow browsers

m128 respin merge

https://screenshot.googleplex.com/9B9zwB69dqVG2Tc
Currently, we prioritize contents & description.
With this CL, we prioritize the IPH link.

(cherry picked from commit 5865d0899fe2335ca432a0daa06b918958ddbeeb)

Bug: 358667730, 358440019
Change-Id: I4da7d34ee1aa9951c58761a36ebbe868c739aa53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5788963
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1342076}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801304
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1369}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc[diff]
• chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h[diff]
• chrome/browser/ui/views/omnibox/omnibox_match_cell_view_unittest.cc[diff]

[m128][history-embeddings][ominbox] Update IPH links

m128 respin merge

Previously links to chrome://settings/ai

Now links to chrome://settings/historySearch

(cherry picked from commit 7f1bde32296c571dc1cacc2e7bdf1aafac33aed5)

Bug: 359658042, 358440019
Change-Id: Ia78f352e5492b1e4122ba6a0ec70ae14ee07cfcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786888
Commit-Queue: Moe Ahmadi <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1341898}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801228
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1368}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/omnibox/browser/featured_search_provider.cc[diff]
• components/omnibox/browser/featured_search_provider_unittest.cc[diff]

[m128][history-embeddings][ominbox] Make disclaimer non-deletable

m128 respin merge

The other IPH's are still deletable.

(cherry picked from commit 1b9ab5398bbee02c01494c311fc08523ace8f4f9)

Bug: 359611182, 358440019
Change-Id: I1bda639700a7380d67a014f575cff8f06c32e532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5787034
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1341311}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801401
Commit-Queue: Moe Ahmadi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1367}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/omnibox/browser/featured_search_provider.cc[diff]
• components/omnibox/browser/featured_search_provider.h[diff]

[128][iOS] InactiveTabs refactoring should be based on availability

The refactoring of the inactive tabs button should be enabled when the
inactive tabs feature is available but disabled by the user.
If not, then the creation of the inactive tabs button could be skipped
at startup, leading to a crash afterward.

(cherry picked from commit 615f630e5801f25bbbcbc8d5b5c511266ef3cabb)

Fixed: 359697949
Change-Id: Ic1d9f57ee777d88e3e1b66915ebda8730547e524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789986
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Louis Romero <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1343419}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808674
Auto-Submit: Louis Romero <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Commit-Queue: Louis Romero <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1366}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• ios/chrome/browser/tabs/model/inactive_tabs/features.mm[diff]

Roll commits from side projects in M128

Roll src/v8 in M128 from e6286d70c55d to 8a8a71df0524
Commits rolled:
https://chromium.googlesource.com/v8/v8.git/+log/e6286d70c55d..8a8a71df0524

Generated by: http://go/bbid/8738816043593793825

Change-Id: Ia270a350d91ddd6a3b186383531b7d18c4c63d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808116
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1365}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• v8[diff]

Automated Commit: LKGM 15964.34.0 for chromeos.

Uploaded by https://ci.chromium.org/b/8738858482018005281

Change-Id: I3d56d3bef831e4f7aea7c85af61a5032988e9cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804180
Bot-Commit: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1364}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chromeos/CHROMEOS_LKGM[diff]

[M128] Add trace events for passage embeddings.

(cherry picked from commit d9c76accb8b5a027c5489b02266d04e6edff070c)

Bug: b/359685266
Change-Id: I1fb67635ff41bfdaed8d0d9b34715225cffbce37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5791786
Reviewed-by: Joe Mason <[email protected]>
Commit-Queue: Zekun Jiang <[email protected]>
Reviewed-by: Zekun Jiang <[email protected]>
Reviewed-by: Raj T <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1343735}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807824
Commit-Queue: Sophie Chang <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Sophie Chang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1363}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• services/passage_embeddings/passage_embedder.cc[diff]

[m128] Revert "Replace Layout() override with DelegatingLayoutManager."

This reverts commit e25a08c5d0b75f1a90c73b92489d21a83bba0b52.

Reason for revert: caused visual regression in the payment dialog 
(crbug.com/360152229) and crash in the password bubble 
(crbug.com/360159400).

Original change's description:
> Replace Layout() override with DelegatingLayoutManager.
>
> Replace overridden Layout methods in BubbleFrameView with
> DelegatingLayoutManager.
>
> Bug: 327499432
> Change-Id: I1a735e20d22590bc6fc58d150b92e14ebb7732f1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642958
> Commit-Queue: Weidong Liu <[email protected]>
> Reviewed-by: Weidong Liu <[email protected]>
> Reviewed-by: Allen Bauer <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1317390}

(cherry picked from commit ae674fb9d5bb727b089b3579ec51b3a4f09c8e90)

Bug: 327499432, 360152229, 360159400
Change-Id: Ibb9a9aa5e74c7972b5c39018f80e9707c019dc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5793578
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Vinny Persky <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1342923}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5808274
Reviewed-by: Weidong Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1362}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• ui/views/bubble/bubble_frame_view.cc[diff]
• ui/views/bubble/bubble_frame_view.h[diff]

[M128] [EditContext] Null-check DomWindow() in SetSelection

It's apparently possible for DomWindow() to be null during an
EditContext.updateSelection call, so check for this condition
to avoid a crash.

See also https://chromium-review.googlesource.com/5778495

(cherry picked from commit 019abccb33fb4d0976d546a78cff67df7dffac38)

Bug: 356211970
Change-Id: I91723194fd52d9f6ae6e4c03e1b96e8a36445727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799260
Commit-Queue: Dan Clark <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1344384}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807203
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1361}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• third_party/blink/renderer/core/editing/ime/edit_context.cc[diff]

[DC] No interstitial for age requests for the Preview protocol

This cl is a follow up for https://crrev.com/c/5679066 implementing
the same functionality for but for the preview protocol.

It stops the digital credential API from showing the Chrome
interstitial for all Preview protocol age requests.

(cherry picked from commit 3cf00fb97ee829688100e64cb6b24388ac2b1e6e)

Bug: 347033835
Change-Id: Ibe5f94568e04a9f33006124b230bb9f04af83030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5791519
Auto-Submit: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Sam Goto <[email protected]>
Reviewed-by: Sam Goto <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1342393}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803999
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1360}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/test/data/android/fedcm_mdocs.html[diff]
• chrome/test/data/digital_credentials.html[diff]
• content/browser/webid/digital_credentials/digital_identity_request_impl.cc[diff]
• content/browser/webid/digital_credentials/digital_identity_request_impl.h[diff]
• content/browser/webid/digital_credentials/digital_identity_request_impl_unittest.cc[diff]

Incrementing VERSION to 128.0.6613.95

Change-Id: If2f16b7678824109538485b105343ee082e083ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807336
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1359}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/VERSION[diff]

Roll commits from side projects in M128

Roll src/third_party/dawn in M128 from 9f1487f627fa to 5f86f5a316f4
Commits rolled:
https://dawn.googlesource.com/dawn.git/+log/9f1487f627fa..5f86f5a316f4

Generated by: http://go/bbid/8738883992924087409

Change-Id: Id2d018250428b0babbde4b5a38910f569e395e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804114
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1358}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• third_party/dawn[diff]

Updating XTBs based on .GRDs from branch 6613

Change-Id: If820b837123eaa3015b068d18c6ee560e06c2617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804173
Commit-Queue: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1357}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• ash/strings/ash_strings_ar.xtb[diff]
• chrome/app/resources/chromium_strings_be.xtb[diff]
• chrome/app/resources/chromium_strings_ta.xtb[diff]
• chrome/app/resources/generated_resources_ar.xtb[diff]
• chrome/app/resources/generated_resources_be.xtb[diff]
• chrome/app/resources/generated_resources_et.xtb[diff]
• chrome/app/resources/generated_resources_kn.xtb[diff]
• chrome/app/resources/google_chrome_strings_ta.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_be.xtb[diff]
• chromeos/strings/chromeos_strings_ar.xtb[diff]
• chromeos/strings/chromeos_strings_be.xtb[diff]
• components/strings/components_strings_be.xtb[diff]
• components/strings/components_strings_el.xtb[diff]
• ui/strings/translations/auto_image_annotation_strings_ar.xtb[diff]
• ui/strings/translations/ui_strings_ar.xtb[diff]

Automatic update from google3

Automatic update for 2024-08-22 UTC

Change-Id: Ibddd68443a94e41020cee373a13d540b639cac98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805531
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1356}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• components/certificate_transparency/data/log_list.json[diff]

Roll commits from side projects in M128

Roll src/third_party/webrtc in M128 from e7686023a186 to f237dc146deb
Commits rolled:
https://webrtc.googlesource.com/src.git/+log/e7686023a186..f237dc146deb

Generated by: http://go/bbid/8738895317828602545

Change-Id: If2268f4bce076686a47749b774e6820224840da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804595
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1355}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• third_party/webrtc[diff]

Automated Commit: LKGM 15964.33.0 for chromeos.

Uploaded by https://ci.chromium.org/b/8738948936370050817

Change-Id: I798e69ca7e785944ab49779d3d50bdafe3ab0122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806668
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1354}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chromeos/CHROMEOS_LKGM[diff]

[lacros] Update lacros QA qualified version

This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.

If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].

[email protected]

Change-Id: If9f3828b35caf10b0b3d046eca0c1a5533be36f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806421
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1353}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/LACROS_QA_QUALIFIED_VERSION[diff]

m128: Add a --build-dir arg to all local script tests

All of these scripts currently assume the val of the '--build-config-fs'
arg maps to the name of the build dir. So they only support building
in out/Release or out/Debug. That's obviously not great. So this adds
a '--build-dir' arg to all scripts, and uses it when determining the
path to the build dir.

This makes "--build-config-fs" unused, with one exception:
check_static_initializers.py uses it to ensure the build is a
"release" build before proceeding. However, "--build-config-fs" can
sometimes not even be accurate for a given builder, eg:
http://screen/9MKoBQCdu9cwVuw

So this also changes check_static_initializers.py to read the args.gn
file in the build dir to determine if it's a release build or not.
This should be much closer to the source of truth, so it improves its
accuracy as well.

(cherry picked from commit 96749172daae0c2a9e75bc1cc88958b7931096f6)

Bug: 355218109
Change-Id: I2c76db27e532e31280c1151acd1d0b73edf18b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5794171
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1345118}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805453
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6613@{#1352}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• testing/scripts/check_gn_headers.py[diff]
• testing/scripts/check_network_annotations.py[diff]
• testing/scripts/check_static_initializers.py[diff]
• testing/scripts/checkbins.py[diff]
• testing/scripts/common.py[diff]
• testing/scripts/count_filtered_tests.py[diff]
• testing/scripts/metrics_python_tests.py[diff]
• testing/scripts/test_traffic_annotation_auditor.py[diff]

Incrementing VERSION to 128.0.6613.94

Change-Id: I60c1e4ff21736a51f481881d51303a28cda6072a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805822
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1351}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/VERSION[diff]

Roll commits from side projects in M128

Roll src/internal in M128 from d4953235852d to 1c4b2bc8f28f
Commits rolled:
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4953235852d..1c4b2bc8f28f

Generated by: http://go/bbid/8738951940732073553

Change-Id: I7b6e3614fb1fc1d45e7daf03f924c17d723d32be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805821
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1350}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• DEPS[diff]
• internal[diff]

Incrementing VERSION to 128.0.6613.93

Change-Id: I754768db5429e0062403a0b6a955743e0f839be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804504
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6613@{#1349}
Cr-Branched-From: 03c1799e6f9c7239802827eab5e935b9e14fceae-refs/heads/main@{#1331488}

• chrome/VERSION[diff]