[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Change-Id: Ia8871c1e9254e7b828af58f467c3cc4a9983fd67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646288
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1619}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[Merge to M126] [X11] Fix decoration insets scaling
This fixes another regression after [1] which added
PlatformWindowDelegate::ConvertInsetsToPixels() but didn't add an
implementation for it.
The interface should really also use InsetsF instead of Insets, so the
caller can decide how to round, but for now this CL is written to be
minimal to merge to M126 and M127, so the previous behavior of rounding
up is used.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5416939
R=sky
CC=elkurin
Bug: 347038254
(cherry picked from commit 852f9270b26ffe5f11c3d4dc98aa3c242825f8fb)
Change-Id: Iab93a03b13cdc4ae8b48edec48e7389349fd2db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637050
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Auto-Submit: Thomas Anderson <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316021}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648262
Reviewed-by: Elly FJ <[email protected]>
Commit-Queue: Elly FJ <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1618}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-24 UTC
Change-Id: I451d3548efa9b05857a377863041dae7459f0f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648201
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1617}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[ios] Ensure "last used" ChromeBrowserState is always loaded
Ensure that the last used ChromeBrowserState as identified by the
kBrowserStateLastUsed preference is always loaded, even if the
kBrowserStatesLastActive preference does not explicitly list it.
This fixes a startup crash if the preferences are inconsistent.
Add unit tests that failed with the existing code, but pass with
the fix.
(cherry picked from commit 763a588cd148923c8299548a7b01189814b6a1e3)
Fixed: 345478758
Change-Id: I3c6dc47ed1f7c35e098d37e0a114051c2c6ad444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5607955
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1312664}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5651040
Commit-Queue: Ali Juma <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1616}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/clank in M126 from 63ff733d3e8f to 231f5bf7e89d
Commits rolled:
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/63ff733d3e8f..231f5bf7e89d
Generated by: http://go/bbid/8744231101059206353
Change-Id: I62c32e1d222b3fe62963a9629a365c27b1e2255f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646768
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1615}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-24 UTC
Change-Id: I426b7e275faf05ed54baf663476fffaa24e3b268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648037
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1614}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Updating XTBs based on .GRDs from branch 6478
Change-Id: I3a7306f85adf969a04bcfec87e7d6f7ee1f6d6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648639
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1613}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.44.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744294349817531553
Change-Id: Id2caff39c487e35b0ee1e8af94b0085df3ec3b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5650546
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1612}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Setting version to 126.0.6478.153
Change-Id: I05a59231908df2ddd65be9dfc5e1377e40e233ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5650701
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1611}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128
This CL updates the ash version ['128.0.6554.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I2b978a212f1435f79a92b675352fa06c7270900e
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647766
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1610}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.133
Change-Id: I9872cfda32ea3211de75553ed161c950d5e4d760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648636
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1609}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-23 UTC
Change-Id: Ida90cd88f9f02cb352080ddd54f8851ee5b55300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648054
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1608}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-23 UTC
Change-Id: I7d0106dbac5778a54863fe1cbc92a94a2c32c1e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645894
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1607}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Updating XTBs based on .GRDs from branch 6478
Change-Id: Id238a59193b9841ae2ef704518945096d6949bc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645054
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1606}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.43.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744384741427929041
Change-Id: I1b306844ca7cdd0717702f911b50385e1380caf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649917
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1605}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128
This CL updates the ash version ['128.0.6552.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I6466daec2d57f3cb45f36dc1b48d6ba78da72d07
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649574
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1604}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.132
Change-Id: I58d88f0eb3077958869d5251e22400599bde349b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648836
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1603}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-22 UTC
Change-Id: I4343aedf9a1fb545481f7af34f975f9fa7df7897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646190
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1602}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-22 UTC
Change-Id: I9da980509e16e9c9edaa2618638e2e1db95c8ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5644951
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1601}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Updating XTBs based on .GRDs from branch 6478
Change-Id: I62ce9e25bfdb6617d89b1c491dfb269078a2f255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648835
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1600}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.42.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744475432444133985
Change-Id: I54f7208ce3b551c8f3f235ce134eff0724b484d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649527
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1599}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.131
Change-Id: I3d5320167cbc49ff59898cebcab2658ed6445e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648832
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1598}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[M126] Remove CHECK_IS_TEST in ReadWriteCardsUiController
Remove the CHECK_IS_TEST since this can happen in production (the
context menu might be close immediately after opening, which cause the
menu pointer to be invalid when this code is run).
(cherry picked from commit b177aa8ef03c8fd7a2986c54dafaa69c76bb5697)
Bug: b:345829533
Change-Id: I8cc6f0929c98e928fbe035654004012a0c39ec83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639618
Commit-Queue: Andre Le <[email protected]>
Reviewed-by: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316740}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649057
Cr-Commit-Position: refs/branch-heads/6478@{#1597}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128 M126
This CL updates the ash version ['128.0.6550.0', '126.0.6478.120'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: If456dc593938150c68b730a7dca0a4b17122f3ae
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646598
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1596}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.130
Change-Id: I131887e750707b927266b34c92c9c3ee2b82141f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647087
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1595}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.129
Change-Id: I3caad0954df6eea488d3dbf75f816f74ad21b363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646248
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1594}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.128
Change-Id: Ib280118510ceb7bc8db4ecaefa151053508748a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647086
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1593}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.127
Change-Id: Id3cd302291e193e7f71a2fc405f056ac3f7a0a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647085
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1592}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[X11] Ensure decoration insets is initialized
This fixes another regression after [1]. UpdateDecorationInsets() was
never called after initialization. This caused an issue where browser
windows were restored larger than they should have been.
UpdateDecorationInsets() should be called in Initialize(), but it
depends on window views being initialized, so the call is added later
in Map() instead.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5416939
R=sky
CC=elkurin
(cherry picked from commit 7e7d3ad898e66d7a07cc8d7c0c2b6ebcf9b7a335)
Fixed: 347373252
Change-Id: I684ffb1d0e6679c9c526a8746634833ede3e1315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640510
Auto-Submit: Thomas Anderson <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Nick Yamane <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1317730}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647678
Commit-Queue: Srinivas Sista <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1591}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Revert "Bubble: remove all SizeToContents() in /chrome/browser/ui/views/global_media_controls"
Merge to M126: Addresses the cast issue described by the reason for revert below. The regression landed in M126 but the revert occurred for M127.
This reverts commit 9b8f7bcf706ab4fd1780f3d5fc1b11c9e619a7c4.
Reason for revert:
This change is breaking MediaDialogView. Steps to reproduce:
- Play any media in web and open the media dialog using the toolbar icon.
- Cast the media to a device and it crashes with the error FATAL:view.cc(2583) Check failed: parent_layer == layer()->parent() when MediaItemUIDeviceSelectorView::RemoveDevicesOfType(DeviceEntryUIType) is called.
- If it's not crashing, stop casting and try cast the media again can trigger the crash.
Reverting this change fixes the crash.
Original change's description:
> Bubble: remove all SizeToContents() in /chrome/browser/ui/views/global_media_controls
>
> Remove all SizeToContents() and add InvalidateLayout() when necessary.
> This changes is used to make the bubbles using autosize mode via
> autosize parameter.(autosize mode: When the preferred size of bubble
> changes,its widget automatically resizes itself to meet the content's
> size)
>
> The ultimate goal of this bug is to remove all SizeToContents() to
> reduce developer confusion about when SizeToContents() needs to be
> called.
>
> This CL was uploaded by git cl split.
>
> Bug: 41493925
> Change-Id: I298c07532dbab24a8a2e7021ffa53e79a33736e2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514338
> Commit-Queue: Allen Bauer <[email protected]>
> Reviewed-by: Weidong Liu <[email protected]>
> Reviewed-by: Allen Bauer <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1299496}
(cherry picked from commit 7ed00126dede590b3d026310437d12037d303ff5)
Bug: 41493925,341782533
Change-Id: I913c5688534b7e7717db32ff508cf5b48a7f7801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540913
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Yiren Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1301034}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648808
Reviewed-by: Prudhvikumar Bommana <[email protected]>
Owners-Override: Prudhvikumar Bommana <[email protected]>
Commit-Queue: Robert Liao <[email protected]>
Auto-Submit: Robert Liao <[email protected]>
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1590}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/clank in M126 from 6c0a3a90552d to 63ff733d3e8f
Commits rolled:
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/6c0a3a90552d..63ff733d3e8f
Generated by: http://go/bbid/8744487792749116001
Change-Id: I1e2b1c29f918bd2c7ab04e10ee8ca6cbcf37d9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649090
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1589}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[merge to 126] overview: Use view tracker to avoid dangling pointer
This code is going away soon, but there seems to be an uptick in
crashes lately.
(cherry picked from commit f6fff2d891d775620ca798f66a1252e743a62d29)
Test: Remove LeakedDanglingUtriaged from OverviewFocusCyclerOld::focused_view_ and run trybots
Bug: b/336289329
Change-Id: I90087017c14907f367beb884ecd92cf739baed21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643921
Reviewed-by: Sophie Wen <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1317695}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648229
Cr-Commit-Position: refs/branch-heads/6478@{#1588}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[m126] Make TabUsageScenarioTracker resilient to delayed OnDisplayAdded/OnDisplaysRemoved.
TabUsageScenarioTracker may observe a new value returned from
display::Screen::GetNumDisplays() without having received an
OnDisplayAdded/OnDisplaysRemoved notification, because these
notifications may be dispatched by a posted task (i.e. async):
https://source.chromium.org/chromium/chromium/src/+/main:ui/base/x/x11_display_manager.cc;l=130-135;drc=90cac1911508d3d682a67c97aa62483eb712f69a
With this CL, TabUsageScenarioTracker tracks the number of displays
in a member variable. This member variable is updated only upon
receiving an OnDisplayAdded/OnDisplaysRemoved notification. It is used
for all decisions (instead of display::Screen::GetNumDisplays()
directly) to ensure consistent state.
Proof that the regression test catches the crash:
crrev.com/c/5640313
(cherry picked from commit f71da4ead3810be7ab69a3afcda7e179f2268374)
Bug: 341488142
Change-Id: I5e54c666820bfea36bf3695649f1cf1dee238e8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639196
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Auto-Submit: Francois Pierre Doray <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316679}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648930
Commit-Queue: Francois Pierre Doray <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1587}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Treat '!' as EOF in in ConsumeGridTemplateRowsAndAreasAndColumns
Our property parser should generally stop at first unknown token
to allow the caller to handle any trailing !important.
CL:5509594 (and/or related CLs) did however introduce a few exceptions
to this for practical purposes. These exceptions need to handle
the sudden appearance of '!' following an otherwise valid value,
but we forgot do that in one of the branches in ConsumeGridTemplate-
RowsAndAreasAndColumns.
(cherry picked from commit 61dcd207a74293f41b70ffe9c8a6d5332b439cda)
Fixed: 347193631
Change-Id: Ia49740296139b4e1be1f1ee1f22c2fb9616433af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5630448
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Steinar H Gunderson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316918}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647670
Commit-Queue: Srinivas Sista <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1586}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.126
Change-Id: Ie77778f6a46d5050b2812d40343ab2f781e27a8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647349
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1585}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.125
Change-Id: Ic8381e3080416636118374cc9c1f9d530210e322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645989
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1584}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.124
Change-Id: Icb19fcab506c70999665d593cbd16755ab0a0e51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646595
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1583}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.123
Change-Id: I964d5b678c28a4467b466283c3260f1aa5360a66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647603
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1582}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Revert "[ContextMenu] Enable Mute Site for audible"
This reverts commit acc324ae95e74a6488c0ed3f9a44ba6fae55e8f5.
Reason for revert: Some websites seem like they do not contain a known media source. These might have been muted before but cannot be unmuted now.
Bug: 346820356
Original change's description:
> [ContextMenu] Enable Mute Site for audible
>
> At present the Mute Site item is shown in context menu for
> all sites like new tab, even though there is no necessity.
> This CL allows the Mute Site item to be enabled only for
> for tabs that contain audible web pages.
>
> TEST=Ran all unit tests
>
> Bug: 40836356
>
> Fixed: 40836356
> Change-Id: I0d5ce5f5c7972718d5ca8f9de6d4a94995f47f11
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468683
> Reviewed-by: Shibalik Mohapatra <[email protected]>
> Commit-Queue: Darryl James <[email protected]>
> Reviewed-by: Darryl James <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1294423}
(cherry picked from commit 93173d173e2a185ed45652179cb18e773745f9c3)
Bug: 40836356
Change-Id: I813b8660e091425f8eb15e3ab8966e686eb733a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646862
Reviewed-by: Darryl James <[email protected]>
Reviewed-by: Eshwar Stalin <[email protected]>
Commit-Queue: Shibalik Mohapatra <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1317671}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648532
Reviewed-by: David Pennington <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1581}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-21 UTC
Change-Id: Iec4df729e7b1c13664c616d4d26229dd9c26c6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5647656
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1580}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Reland "[A11y] Process update only when options bounds are ready"
This reverts commit 070aabe90ad9f480c82a674dfc1902ff2244e62e.
Reason for revert: This is causing a crash in stable. See: https://g-issues.chromium.org/issues/347657130
This will cause Tast failures, see b/341802417 for details. The crash is a worse issue, so we are reverting this revert. A patch to address the Tast failures is in progress.
Original change's description:
> Revert "[A11y] Process update only when options bounds are ready"
>
> This reverts commit 7b5a09f8d44399bdf4573f5194752ff0c7caa71f.
>
> Reason for revert: Tast tests with drop-downs failing. See b/341802417.
>
> Original change's description:
> > [A11y] Process update only when options bounds are ready
> >
> > When there are more than 1000 options in a select, the first 1000 are
> > included in the first layout and the rest are included later. However,
> > only the bounds of the options from the first layout are sent to the
> > accessibility tree, causing an index out of bounds error when trying to
> > access the bounds of the 1001st option element.
> >
> > This change sends updated bounds to the tree and also prevents the
> > processing of the bounds before all of them are ready.
> >
> > Fixed: 338646632
> > Change-Id: I2e6e8eaf473e3030aef9e6425201fba3672f733f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532661
> > Commit-Queue: Jocelyn Tran <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Reviewed-by: Aaron Leventhal <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1302226}
>
> Change-Id: I973e4571a186a02f70b098e5cb05b742fc80fb38
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5595050
> Commit-Queue: Jocelyn Tran <[email protected]>
> Reviewed-by: Vladimir Levin <[email protected]>
> Reviewed-by: Aaron Leventhal <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1309988}
(cherry picked from commit fc70f861504ac88bb913a3a202a75163165c936b)
Change-Id: If68237cb6de7284f76cdfc8a56d23a4adbf46697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637715
Reviewed-by: Aaron Leventhal <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Tzarial Kuznia <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316584}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646617
Commit-Queue: Srinivas Sista <[email protected]>
Auto-Submit: Tzarial Kuznia <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Reviewed-by: Jocelyn Tran <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1579}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
remove erroneous preloading per public suffix request
Change-Id: Ide8a0bc2a977114c83cc0914ee43c18a65a9a2be
(cherry picked from commit ca762eecee0722e58444dc43aac1c618eb389aeb)
Bug: 346931325
Change-Id: Ide8a0bc2a977114c83cc0914ee43c18a65a9a2be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5630758
Commit-Queue: Nick Harper <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Auto-Submit: Joe DeBlasio <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1314909}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648530
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1578}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Fix crash in ScriptPromiseResolver::ResolveOverridingToCurrentContext()
It should override first, then check the validity of the ScriptState.
Otherwise, we never check the vaility of the ScriptState we've
overriden to.
(cherry picked from commit 33bd81807b4fb3457c7d6fd4b8cd64cc2ae1e05a)
Fixed: 345275138
Change-Id: I308eaff7c782b62161345cbbf6a48b4392b1a115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5618491
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Auto-Submit: Nate Chapin <[email protected]>
Commit-Queue: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1313108}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648305
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1577}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Adjust for scroll offset when printing.
The cull rectangle (from PrintContext::PageRect()) was already adjusted
(so that we find what we should find on a given page), but we also need
to add translation to cancel out this scroll offset, so that the output
ends up at the right place, and not outside the page. This includes any
content outside the page area, such as @page margin boxes or @page
borders, so the translation needs to be applied early, so that it's not
just applied to the paginated content.
(cherry picked from commit 9be4e5fa962b9fd00d1f82a09f3b715706b9eaad)
Bug: 346597044
Change-Id: I86964e98b9bf54526115f397e31c8eadcf2dbe64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5636754
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316895}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641945
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1576}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Match task runner lifetime with the cache for SVGDocumentResources
The task runner was taken from the passed ResourceFetcher, but since the
the SVGResourceDocumentContent loaded from the SVGDocumentResource can
outlive the ResourceFetcher, tasks posted to the task runner would not
be delivered if the latter was destroyed. Use the default task runner
from the AgentGroupScheduler instead since that should match the
lifetime of the SVGResourceDocumentCache (i.e the Page).
(cherry picked from commit c358f4de6e9bd5029710ea6ef5ef6e241882216c)
Fixed: 347724924
Change-Id: I6e04c5a665a992620451d8e0a324250f70cdef7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639940
Reviewed-by: Philip Rogers <[email protected]>
Auto-Submit: Fredrik Söderquist <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1317059}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648261
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1575}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/v8 in M126 from 9f0e9900a42d to 1a2f876b6137
Commits rolled:
https://chromium.googlesource.com/v8/v8.git/+log/9f0e9900a42d..1a2f876b6137
Generated by: http://go/bbid/8744502891888380353
Change-Id: I2023e7b27d891c26dfc49825fae3decbfed05c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648670
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1574}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Updating XTBs based on .GRDs from branch 6478
Change-Id: I7166a84b055ae11c1416d0671529c891c8cf46cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646524
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1573}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-21 UTC
Change-Id: I5810900f24d9bcc27327e24db27d4a236a014a4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648224
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1572}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.41.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744566217794522161
Change-Id: I1ada69431001b3a2b41c8b219036e21cfd4b46b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648219
Bot-Commit: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1571}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128
This CL updates the ash version ['128.0.6548.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I550383ab6ed1ab8d642cba14e9ac260a50c3e063
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645727
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1570}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.122
Change-Id: I68b189f637deee7108df78bc4aeddb4ea44880db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646226
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1569}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Add flag to indicate if a board overlay include CBX functions
To include artifacts only on board that support CBX (Gentoo USE flag
feature_management), add a flag that can be used at compile time.
Flag is set in chromeos-chrome ebuild by crrev.com/c/5628954.
It replaces the flag is_time_of_day_supported, which is now a duplicate,
remove from chromeos-chrome ebuild with crrev.com/c/5628955.
Partial revert of commit c01529e110b0e ("Add GN flag to include time of day thumbnails.")
Bug: b:275379819, b:345243496
(cherry picked from commit 690f749977ca2b809be43db1abddd6b8e38e2da3)
Change-Id: I241aff91d51f7e71b7b91ed7453302cdaa6740ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5628960
Reviewed-by: Jason Thai <[email protected]>
Reviewed-by: Vovo Yang <[email protected]>
Commit-Queue: Gwendal Grignou <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316131}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637179
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1568}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/third_party/dawn in M126 from b208b3aab58d to 13586d84cb60
Commits rolled:
https://dawn.googlesource.com/dawn.git/+log/b208b3aab58d..13586d84cb60
Generated by: http://go/bbid/8744578388985345873
Change-Id: I298367554e74a36adea4058639eec0de2b3c78cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645567
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1567}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/clank in M126 from 88b85102214e to 6c0a3a90552d
Commits rolled:
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/88b85102214e..6c0a3a90552d
Generated by: http://go/bbid/8744582165548364065
Change-Id: I7dbb694dbfe65deece6377cf9c9037e297cec68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646763
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1566}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/third_party/dawn in M126 from 46813578fd64 to b208b3aab58d
Commits rolled:
https://dawn.googlesource.com/dawn.git/+log/46813578fd64..b208b3aab58d
Generated by: http://go/bbid/8744584052533658305
Change-Id: I3e9a2e7bf3896b52c24454eb000f8ceed87efba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5644334
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1565}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/third_party/dawn in M126 from 640532e4acfe to 46813578fd64
Commits rolled:
https://dawn.googlesource.com/dawn.git/+log/640532e4acfe..46813578fd64
Generated by: http://go/bbid/8744587826140693169
Change-Id: Ib65434f1927d5c9167bda73981474d9bc1f9b62a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646223
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1564}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[merge to 126] overview: Speculative fix for OverviewController::ResetPauser
The theory is that something is being triggered and exiting overview
when the occlusion tracker or raster scale pausers are reset. This
patch adds check for the session, and also dumps without crashing so we
can try to catch the root cause.
(cherry picked from commit 2293bc6478ad765547d36522addd94501ae5e734)
Test: none
Bug: b:334908991
Change-Id: Idf43d6f123c93b5dc22edc7abc9a1abd608a25c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5570173
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1308352}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641208
Cr-Commit-Position: refs/branch-heads/6478@{#1563}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-20 UTC
Change-Id: I6866d208741706015a93960dd5262e61356ae18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645688
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1562}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-20 UTC
Change-Id: I6f6931f21e0b75677b81d97dbf52ae090a19eade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645685
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1561}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[M126][Tab Group Sync] Disable the mechanism of cross device synced pref
This CL removes the synced pref kTabGroupSyncAndroid that was
designed to enable sync on a device even if the feature flag was
off and the user has at least one device that has the feature ON.
However it leads to risk of unintended enabling of the feature if
we are not careful enough. This CL disables this pref and removes
support for this pref syncing mechanism. After this CL, any user
devices with older clients will receive the boolean false which
will disable the sync feature.
(cherry picked from commit 0dd4b62722a6e42175d2f9cbf22aa4dced10388b)
Bug: 347131250
Change-Id: I9dde41c2c4d795b671b5aadaef013bb8a31734e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632896
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1315313}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640496
Cr-Commit-Position: refs/branch-heads/6478@{#1560}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[Merge M126] Fix crash when checking if RPH is unused in WebView
The rph pointer may be null, so check for this.
(cherry picked from commit 8ef9e2efbcd33e9ff347082e890d544b1c25c80d)
Bug: 347770814
Change-Id: Id57d113168f5ea176862641a4625b224c3352afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5634753
Reviewed-by: Richard (Torne) Coles <[email protected]>
Commit-Queue: Richard (Torne) Coles <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316477}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643916
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1559}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[M126][declutter] Skip native integration for archived tab model
(cherry picked from commit be2ed769e94fe9a10d64e4c474bffe41dbaa4182)
Bug: 325679965
Change-Id: I931bdc9e6c028569915b7dbe7f66032dfb453656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635149
Reviewed-by: Calder Kitagawa <[email protected]>
Commit-Queue: Brandon Wylie <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1316151}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645622
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1558}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/ios_internal in M126 from d7dd51b2b631 to 9c864aec6d5f
Commits rolled:
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/d7dd51b2b631..9c864aec6d5f
Generated by: http://go/bbid/8744606701432023169
Change-Id: Ifdc8b075521c75a9bcc177ff1d6b2dcae8bd9d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645562
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1557}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.40.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744656683306161473
Change-Id: Id3071525cdd74f2aafdccec4522703a3feef27fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5644259
Bot-Commit: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1556}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128
This CL updates the ash version ['128.0.6546.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I44b333471139fc05119a25c0ee9ee8f712f05805
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643530
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1555}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.121
Change-Id: I73737450284205d16f83c8f894ea4efe9b224033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643155
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1554}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-19 UTC
Change-Id: Ife47f66c194d65cd5aef58eb351007439144239a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642638
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1553}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[M126][Incognito][NTP] Fix cookie controls layout
As part of cleaning up the revamped incognito NTP, a call to adjust the
cookie controls layout was removed by mistake. This issue affected
tablet layouts as they can span wider than the max expected width.
This CL reintroduces the call back in the text formatting method so that
upon inflation is complete the layout width is set appropriately.
The call to adjust the view in `onFinishedInflate()` is not sufficient
as the card is returned to be null and the additional call to format the
text fixes this issue.
Will merge back to M126 once tested in canary.
(cherry picked from commit cdb578bbe5845339407609fdfa53f62f1708df4e)
Bug: 346472682
Change-Id: Ibf18c61d7992b99e9ed25de24cacf3553ffc423a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633480
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Side YILMAZ <[email protected]>
Commit-Queue: Side YILMAZ <[email protected]>
Auto-Submit: Mariam Ali <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1315709}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633983
Cr-Commit-Position: refs/branch-heads/6478@{#1552}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Updating XTBs based on .GRDs from branch 6478
Change-Id: Iad21e0aa832ffce974e16c2ab9930e4ba89fdade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641095
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1551}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-19 UTC
Change-Id: I34e2484a1d6446f509ead0458b20483cdeeb7a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643110
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1550}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.39.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744747143163824769
Change-Id: I4e72841e9582d28a60a45baaa14dfd3eb87c3831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642350
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1549}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
editor: disable OrcaDraggingSupport
(cherry picked from commit 301dd98f14cd48eb46c8449b3195d50cc4b73594)
Change-Id: Iafe7ad7f0bf5eca6d0d1f80a9f1548482e101686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5624450
Auto-Submit: Chuong Ho <[email protected]>
Commit-Queue: Grey Wang <[email protected]>
Reviewed-by: Grey Wang <[email protected]>
Commit-Queue: Chuong Ho <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1313800}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641794
Cr-Commit-Position: refs/branch-heads/6478@{#1548}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/third_party/dawn in M126 from 9c6534f82db3 to 640532e4acfe
Commits rolled:
https://dawn.googlesource.com/dawn.git/+log/9c6534f82db3..640532e4acfe
Generated by: http://go/bbid/8744740709810376785
Change-Id: I2081d32c959aef89f4ad12c9008c1661d4b065b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641174
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1547}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128 M127
This CL updates the ash version ['128.0.6544.0', '127.0.6533.11'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I9fdcf9fcb35fe52f081e0eee78dc79ae16a3e43d
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639799
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1546}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.120
Change-Id: I0261990531a3bc1734b59bfcc47bb5429fc394c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5641553
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1545}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Change-Id: Id188c592821f8ce482f966518547c13107f7444e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640577
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1544}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
privacy-hub: Fix crash on NotifyGeolocationPermissionChanged() in Perso app
Personalization app would crash on system geolocation access level
changes. I could only reproduce this for users from a domain other than
Google. Apparently the Ambient mode is not yet allowed for the
enterprise domains. Thus the `PersonalizationAppAmbientProviderImpl`
would not bind the `ambient_observer_remote_` endpoint, which was
asserted in the `NotifyGeolocationPermissionChanged()`.
Modify this assertion with returning preemptively if the
`ambient_observer_remote_` endpoint is not bound.
(cherry picked from commit d0ece45775c3d5a1438b4afe098d1c50a3e6a975)
Bug: b:344653836
Change-Id: I808581d60059b9e4303a36a32e194846dbf1b940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5610699
Commit-Queue: Zauri Meshveliani <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1312734}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639934
Auto-Submit: Zauri Meshveliani <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1543}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[Custom Message] Re-add learn more link for policy-based custom messages
Re-added the learn more link to be displayed. Additional checks so that the learn more link is not displayed when both a custom rule message and policy-based message are received as rule takes precedence.
Tested locally:
upload: https://screenshot.googleplex.com/7axM4qsMSUop3sX
download: https://screenshot.googleplex.com/LPjXvr7ow7nKLc5
Also verified that if both policy and rule-based message are sent, the rule-based message takes precedence and no Learn more link is displayed: https://screenshot.googleplex.com/95Xcm7tRt4czDxm
(cherry picked from commit 9c5baa2481d810f8b793086c9638dc47b2980adb)
Bug: b/343515899
Change-Id: Ic2a54eb1d6f1b988bed66785fdd22e962960fa70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5585423
Reviewed-by: Dominique Fauteux-Chapleau <[email protected]>
Commit-Queue: Haihan Chen <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1308155}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640113
Cr-Commit-Position: refs/branch-heads/6478@{#1542}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-18 UTC
Change-Id: Iac7d8cc2eaab5512a1eb2fed106c855b62d6533c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639673
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1541}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automatic update from google3
Automatic update for 2024-06-18 UTC
Change-Id: I39d1c20ec463b4a9b25516d2b274daa539b19935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5638535
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1540}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/third_party/angle in M126 from 117bd54a45ec to 5d4df51d1d7d
Commits rolled:
https://chromium.googlesource.com/angle/angle.git/+log/117bd54a45ec..5d4df51d1d7d
Generated by: http://go/bbid/8744780345692873809
Change-Id: I8a355e5b72902c6ba7903e1a0485fe0840ed9148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631303
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1539}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Updating XTBs based on .GRDs from branch 6478
Change-Id: Ib1d0751809cc7aeeb46fcb4aceea3bb53f65b552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637418
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1538}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Automated Commit: LKGM 15886.38.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8744837966659749137
Change-Id: Ia28e3c40d626346c71aad1c064b7e1092bffbd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5638401
Bot-Commit: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1537}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/clank in M126 from e51aac00c254 to 88b85102214e
Commits rolled:
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/e51aac00c254..88b85102214e
Generated by: http://go/bbid/8744791670433684689
Change-Id: I5b63a77e0e8f1fbcca2af9181410bdb7831e0b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637433
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1536}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/clank in M126 from 44526f472484 to e51aac00c254
Commits rolled:
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/44526f472484..e51aac00c254
Generated by: http://go/bbid/8744793554665319585
Change-Id: I29f7bc833fabafa9808ec27456803f47ffaf0c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635773
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1535}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/v8 in M126 from fa981ae5db3e to 9f0e9900a42d
Commits rolled:
https://chromium.googlesource.com/v8/v8.git/+log/fa981ae5db3e..9f0e9900a42d
Generated by: http://go/bbid/8744797331823098801
Change-Id: I868618f5f4641d499ac9451aef86e89ad3871a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635771
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1534}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Roll commits from side projects in M126
Roll src/internal in M126 from 9f3aed93741f to 11afbb2a84b6
Commits rolled:
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f3aed93741f..11afbb2a84b6
Generated by: http://go/bbid/8744818094745428961
Change-Id: I46db45b6d074f5ca2689d4833b1a927c775f7001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637532
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1533}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.119
Change-Id: I8675a20d709ae3d9c3e88db57fa6b13efcf35367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635646
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1532}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Defer AuthHub login screen initialization until cryptohome is available
(cherry picked from commit 48ce02f6ccfa848dac7a717a5822f1186df04405)
Fixed: b:339269706
Change-Id: I1583c67f3836fd37d5461efed7cc9a70d2cfa801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5550990
Reviewed-by: John Admanski <[email protected]>
Commit-Queue: Elie Maamari <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1305119}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637069
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: John Admanski <[email protected]>
Auto-Submit: Ted Brandston <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1531}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[lacros skew tests] Refresh skew tests for M128 M125
This CL updates the ash version ['128.0.6542.0', '125.0.6422.197'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I907a2f3e76cb3f9c9e4a191c01f8cc2432e8f910
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632204
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1530}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[M126] arc/gio: Fix crash with focus change when closing window
This CL
- fix crash related to focus change when closing window.
- improve the logic when window focus is changed.
(cherry picked from commit 7df0fb6c23e3e2a2845c45f951fa60b69fd4da4d)
Bug: 344665489
Test: unit_tests --gtest_filter="*ArcInputOverlayManagerTest*"
Change-Id: If53248ee076d9f918a4cbf65d49343b14719d1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631314
Reviewed-by: Joseph Pang <[email protected]>
Commit-Queue: Cici Ruan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1315502}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5636852
Reviewed-by: David Jacobo <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1529}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.118
Change-Id: I31e38c85f04d9e658769f09e6d1929c42e3337cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637529
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1528}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.117
Change-Id: Id5d569cc0a903ac7e0a2f032163400bf79e68a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635643
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1527}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.116
Change-Id: Ifbd434ce914674bc966d9ef02f9695b0a3f0b49d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5634350
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1526}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.115
Change-Id: I79c24561057282ac13192f59bcd990052630bd71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5636093
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1525}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.114
Change-Id: I57034706f3594fb4ace65621be1f37f5b77bc351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637234
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1524}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.113
Change-Id: Ia51f6db48391c3ab562ab4a0efd9c70b90ac0140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637233
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1523}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.112
Change-Id: I05dca2e8eb4e57a377de99513e7ccefc8bd55481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637449
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1522}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.111
Change-Id: I3b0c5ea39e667a8733afa4e0a76a750e78f8f287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637232
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1521}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Check report limit on the service class before sending a CSPP ping
While number of users sending over the phishing cap is reduced
drastically through crrev.com/c/5532662, we still see an extremely
small number of users still sending a ping while over the ping cap.
Since the CSD host class is on the tab level, we suspect that the
profile service class may be processing a request while the host
preclassification check has an outdated ping times count.
(cherry picked from commit 33b05b087d51c3631c32051a76476ea29d94276b)
Bug: 339811213
Change-Id: I9b9a6fdd145f1d6550a995b6b679dc33e8e3ebc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5626795
Reviewed-by: thefrog <[email protected]>
Commit-Queue: Seung Jae Lim <[email protected]>
Reviewed-by: Nwokedi Idika <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1315362}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635007
Reviewed-by: Seung Jae Lim <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1520}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
[M126] Ensure IdlenessDetector is unregistered as TaskTimeObserver before finalization
This uses a prefinalizer to unregister IdlenessDetector as a
TaskTimeObserver in case Shutdown wasn't called, similar to what we do
in PerformanceMonitor.
Note: this is a temporary workaround to prevent crashes caused by not
unregistering the observer prior to IdlenessDetector being destroyed.
The root cause of why some frames are not being detached is under
investigation.
(cherry picked from commit f5627002f482be83d72879ee8d15e0e823c2abba)
Bug: 345076820
Change-Id: I7356c5ca1677922bb8526a1c104ee78b1f39123c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5630759
Commit-Queue: Scott Haseley <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1314773}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635705
Reviewed-by: Erhu Akpobaro <[email protected]>
Owners-Override: Erhu Akpobaro <[email protected]>
Cr-Commit-Position: refs/branch-heads/6478@{#1519}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.110
Change-Id: I4cc1b07c0cb28f29e3dcc5222d9238e44a09ee28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635538
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1518}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Incrementing VERSION to 126.0.6478.109
Change-Id: I66328df6bb15a3fe03cc06af2fc7c45df24d32b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5634548
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#1517}
Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}