Publish DEPS for 116.0.5842.3
Change-Id: Idfc001e377dac5d4c0b90144cf97a8dae4730f58
Incrementing VERSION to 116.0.5842.3
Change-Id: I12bfe6f702e3c280d3c10915e6ec0e42b5c29069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4631838
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5842@{#7}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
[aw] Disable WebViewReportFrameMetrics by default
Unfortunately, the fix in https://crrev.com/c/4621849 doesn't seem to
address all crashes, so this CL disables WebViewReportFrameMetrics
by default.
(cherry picked from commit d5f3aa68fb0f5d092666038ff6abd1fde054730e)
Bug: 1454809, b:278118627
Change-Id: If8ca18063f797c537e175c39e6161668f523df94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4629171
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Oksana Zhuravlova <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1160654}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4633218
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Erhu Akpobaro <[email protected]>
Reviewed-by: Erhu Akpobaro <[email protected]>
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/5842@{#6}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
Revert R8 roll to fix major crasher
Reverting this CL is expected to fix the big crasher. The R8 roller is
already paused for an unrelated issue.
(cherry picked from commit 31392963a20fab91cfa52fe21acf295c7c6216db)
Bug: 1455744
Change-Id: I033b986613b7f17134206b02bd8a85edac3005d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632477
Auto-Submit: Sam Maier <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Commit-Queue: Sam Maier <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1160629}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4633159
Reviewed-by: Erhu Akpobaro <[email protected]>
Reviewed-by: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5842@{#5}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
Incrementing VERSION to 116.0.5842.2
Change-Id: Ica8f2255fd4b18cac3aac54797cfcc4153308d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4629168
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5842@{#4}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
Disable sequence manager crash keys on Android
(cherry picked from commit 05649596db453d528074e847bc2e947ede5ecf49)
Bug: 1147768
Change-Id: I86aedc6c0156ef3a5a16b1ef54375710b8cabd7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620230
Reviewed-by: Francois Pierre Doray <[email protected]>
Commit-Queue: Olivier Li Shing Tat-Dupuis <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1160037}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4628989
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5842@{#3}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
Incrementing VERSION to 116.0.5842.1
Change-Id: Ib224c1b70b913d4c18f344637f3ef03bb421046b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621903
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5842@{#2}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
Update DEPS for 5842 branching
Change-Id: Icf7ce18607b9737901e7693d41a63b129b28185a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625737
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5842@{#1}
Cr-Branched-From: cef6cba43e418d5bfce3b621ec9774a726b78eeb-refs/heads/main@{#1159539}
[ios] Remove FakeWebStateListObservingDelegate
This CL removes ios/chrome/test/fakes/fake_web_state_list_observing_delegate.h and ios/chrome/test/fakes/fake_web_state_list_observing_delegate.mm because
no one uses it.
Bug: 1442546
Change-Id: I9d83969e05d02b0a22780b83e4fe4edfe7d61d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614977
Auto-Submit: Asami Doi <[email protected]>
Reviewed-by: Éric Noyau <[email protected]>
Commit-Queue: Asami Doi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159539}
Remove RuntimeEnabledFeature flags related to font-tech() / tech()
Remove the two flags that controlled parsing of tech() in the @font-face
and the @font-tech supports function.
Shipping since M108.
Bug: 1255685, 1216460
Change-Id: Ic253f0454ab85a66c8f9e95a6a95a122afbd8054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623549
Reviewed-by: Munira Tursunova <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159538}
Roll Perfetto from ed02827cea30 to 9569ddf0f678 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/ed02827cea30..9569ddf0f678
2023-06-19 [email protected] Merge changes Iaf5a8954,I8d879833
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I3fef8114a2c1f35a6dc3fe416bb33f53c2d01f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626475
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159537}
[GPU][Mac] Support creation of empty multiplanar SharedImages
Currently the CreateSharedImage() entrypoint that takes in a
SurfaceHandle only accepts single-planar formats. This is legacy and
needs to be fixed, as we'll have use cases for creating SharedImages
that aren't backed by GMBs.
This CL fixes this issue. Note that creation of SharedImages with
non-empty pixel data is still restricted to single-plane format. At this
time, we don't have any production use cases for using that flow with
multiplanar formats.
Bug: 1455075
Change-Id: I200c1781f90b77c295112a7f6a9c7edf5cf16776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615075
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159536}
WebIDL: Allow required args after optional args
WebIDL spec now allows required after optional; you can trigger the
optionality (and get the default value) by explicitly passing undefined.
Spec PR: https://github.com/plinss/widlparser/pull/81
Bug: 1454735
Change-Id: I7d4d0321ef9f4d04f65b6aebcf721ed1dfeead14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613108
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159535}
Roll Skia from 24f2336d87f2 to 455d7306b951 (4 revisions)
https://skia.googlesource.com/skia.git/+log/24f2336d87f2..455d7306b951
2023-06-19 [email protected] Roll vulkan-deps from 4aa38765aadb to 9ed904489a9a (1 revision)
2023-06-19 [email protected] Roll ANGLE from edf58105d695 to 24f4007b93e0 (9 revisions)
2023-06-19 [email protected] Roll SK Tool from b32ce543bca1 to 15fb7caa7aea
2023-06-19 [email protected] Roll Skia Infra from d044984a01de to b32ce543bca1 (29 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I534c7308925d02a23e269dd7dd1e1baa774a72db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626574
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159534}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687143525-7859c6f0e6dc599e894dafd185a1530e7d9219dc.profdata to chrome-win64-main-1687154185-eeea6d5d7278c9fbcc7639455a83e990f62d6cf6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I852b552b381be4eb652a0f92dac037542f7b1a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625707
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159533}
Refactor AppendLinkItems
This commit refactors `AppendLinkItems` without making any behavioral
changes.
Previously, there were two locations that appended the "Open link in new
tab" item. This CL clarifies this by using the `show_open_in_new_tab`
variable, so that we can easily control whether or not the item is
displayed.
Bug: 1453971
Change-Id: I0b2ab0c5cb1684d633bbb28246902aa5d28f745b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623953
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Jun Ishiguro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159532}
Revert "[Android] Re-enable NavigationHandlerTest#testLeft...Link_with..Transition"
This reverts commit cfe883721e113645517ceeeca82882623029454e.
Reason for revert: https://crbug.com/1455901
Original change's description:
> [Android] Re-enable NavigationHandlerTest#testLeft...Link_with..Transition
>
> The disabled test has passed lately. Internally the flow takes exactly
> the same path as the other variation. We may safely re-enable this
> test.
>
> Bug: 1426201
> Change-Id: I8eeea98b5d9f4f67fd5a89fdd245703c1f3a3c68
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608652
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Jinsuk Kim <[email protected]>
> Reviewed-by: Lijin Shen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158181}
Bug: 1426201,1455901
Change-Id: I5d2fa16af241a9cb16200b633a6df8f4df5daf2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624569
Owners-Override: Samar Chehade-Lepleux <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Samar Chehade-Lepleux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159531}
Roll Projector App from zfE9bxid94ovhGhtS... to 84U1NuzFNcdLNTiNj...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306190100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/84U1NuzFNcdLNTiNjzixqz3GdV1Xt3VhI39vWtyBoKwC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I1acfd8a62151c06483f4c87f24db571d41faf234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624683
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159530}
[Gardener] Disable ContentAnalysisPrintBrowserTest.PrintNow
Bug: 1454426
Change-Id: I7369d5ddacf75caebf954c7d09ae489335ad6227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626219
Commit-Queue: Christoph Schwering <[email protected]>
Owners-Override: Christoph Schwering <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Auto-Submit: Christoph Schwering <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159529}
iOS ReplaceSyncPromosWithSignInPromos flag: Add History feature
i.e. "SyncEnableHistoryDataType".
This should be enabled by default soon, and in developer builds it's
anyway enabled via the fieldtrial testing config. But in the meantime,
let's also list it here.
Similarly, this also adds "SyncEnableContactInfoDataType".
Bug: 1447010
Change-Id: Ia11baac6c7ada17468ef662460bae52b22bfc81d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620827
Auto-Submit: Marc Treib <[email protected]>
Reviewed-by: Victor Vianna <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159528}
[Metrics] Add histogram and enum definition for DevTools.BadgeActivated
Bug: 1455339
Change-Id: I7d096c33414d5f1d09be517caf369d9226e5a68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614554
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159527}
webrtc-internals: add transceiver kind transceiver events
improving visibility by showing them as
transceiverAdded [0], video
BUG=chromium:1375217
Change-Id: I7e9090050c48524a3fb77be7f5f2740d5f9383d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614962
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Philipp Hancke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159526}
Displaying space instead of line and paragraph separators
Chrome renders line separator (0x2028) and paragraph separator (0x2029)
as either a missing glyph or l-sep/p-sep symbol on various platforms.
On Android this happens due to the lack of the glyphs in Android system
fonts, so it is displayed as a missing glyph. Windows system fonts have
l-sep and p-sep symbols for the 0x2028 and 0x2029 codepoints
respectively. On Mac OS these glyphs are being synthesized, see [0].
According to unicode specification line separator and paragraph
separator should be displayed as space, compare [1].
[0] https://crrev.com/c/4180727
[1] https://www.unicode.org/faq/unsup_char.html#2.
Bug: 550275
Change-Id: Ifd472f591daddfa9e6543c37d0a8220c67108592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4581187
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159525}
[signin] DiceTabHelper defaults to ACCESS_POINT_WEB_SIGNIN
The DiceTabHelper may be reused for regular web signin. If there is no
signin flow initiated by chrome in that tab, we should assume that the
user initiated the signin themselves from the web.
Bug: 1417232
Change-Id: I9a44ada1500bd39fd34e2d17010b51e037a76064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618251
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Nicolas Dossou-gbete <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159524}
Add warning message to using JavaCronetEngine
* Creation of javaCronetEngine was done silently which sometimes caused confusion(eg: The user expects caching to work but JavaCronetEngine does not support that). This CL adds a warning message to the logcat which should in some sense indicate that this CronetEngine is not optimal.
Change-Id: Ib74525047137081de85df8b38d90aa121ebf35a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620234
Commit-Queue: Stefano Duo <[email protected]>
Auto-Submit: Mohannad Farrag <[email protected]>
Reviewed-by: Stefano Duo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159523}
Privacy Guide: Post MVP flag
Bug: 1238896
Change-Id: Id5c047558fc0d589e3eb4803d25eff0573314b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620532
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Rubin Deliallisi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159522}
OOBE: Enable OobeDisplaySize for DebugOverlay tests
Bug: b:287546383
Change-Id: I20c8fdde7e54bf10afa15a8e8880538179454282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620670
Reviewed-by: Brahim Chikhaoui <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159521}
[Android][CredMan] Wire password credential to PasswordCredentialFiller
This is the final CL that makes the password filling / passkey login
possible using CredMan.
Demo: https://drive.google.com/file/d/1oqouoKnTFAMYy22mydj8byMZH38IpkNO/view?usp=sharing&resourcekey=0-UpobrzpKmN7CiDIFZnzaRQ
Low-Coverage-Reason: Bridge code.
Bug: 1434278
Change-Id: I25cf684dab7977337fad15ebe50e81a199f15f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598147
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Adem Derinel <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159520}
webrtc-internals: update stats graph label on every report
for consistency with the stats table label
BUG=chromium:1375217
Change-Id: I8526d1cd7eda30cb54d39aa9a9ab0ea59433556f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614758
Commit-Queue: Philipp Hancke <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159519}
SyncPrefs: Fix user migration for kReplaceSyncPromosWithSignInPromos
Before this CL, this migration logic was called a bit too early, before
the account state was actually known. As a consequence, the migration
didn't actually do anything.
This CL fixes the call site, and adds an integration test that covers
this.
Bug: 1447020
Change-Id: I94f2e3a100b95f718625c80e33a88b3430ef5015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620276
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159518}
Revert "Reland "[Fixit] TabGridAccessibilityHelperTest""
This reverts commit e042779725480d2fade0bf2fac51da9d0b7f3c3e.
Reason for revert: https://crbug.com/1454747#c5
Original change's description:
> Reland "[Fixit] TabGridAccessibilityHelperTest"
>
> This reverts commit cb6674cf1404c8d68b5227cd2b165a71122828b0.
>
> Reason for revert: Another attempt to fix and wait for layout.
>
> The issue only seems to be arm64 "real" devices so if this also
> fails I might just DisableIf to abi is not arm.
>
> Original change's description:
> > Revert "[Fixit] TabGridAccessibilityHelperTest"
> >
> > This reverts commit 4c9139859ea621efe9764d8d3ed86ea41b3e2016.
> >
> > Reason for revert: failing tests on a couple bots, see crbug.com/1454747
> >
> > Original change's description:
> > > [Fixit] TabGridAccessibilityHelperTest
> > >
> > > Fix failing tests which seem to stem from the following:
> > > 1) Start surface vs Start Surface Refactor have different onView
> > > parents. (Set one consistent flag set).
> > > 2) If scrolled out of view getting the RecyclerView ViewHolder is
> > > flaky.
> > > 3) Small phones don't get span count = 3. Skip those sections.
> > >
> > > Additionally:
> > > * Batch tests
> > > * Throw ViewMatchExceptions to aid in debugging in future
> > >
> > > Fixed: 1368279, 1332995, 1318394, 1371231, 1332934, 1318376, 1306823, 1146575
> > > Change-Id: Ica6d65fd4a53a7270aa5e066f0307ccb7772fe4d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604877
> > > Auto-Submit: Calder Kitagawa <[email protected]>
> > > Reviewed-by: Fred Mello <[email protected]>
> > > Commit-Queue: Fred Mello <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1156890}
> >
> > Change-Id: I7535c81be60389627d64dde372380a18c24d2da0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615045
> > Commit-Queue: Theresa Sullivan <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Reviewed-by: Calder Kitagawa <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1157608}
>
> Cq-Include-Trybots: luci.chromium.try:android-arm64-rel,android-pie-arm64-dbg
> Change-Id: I86ae894c2e227f6dbc3886a81b8258996b4fd1be
> Bug: 1454747
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617508
> Reviewed-by: Fred Mello <[email protected]>
> Commit-Queue: Fred Mello <[email protected]>
> Auto-Submit: Calder Kitagawa <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158179}
Bug: 1454747
Change-Id: If6d68754da811d19c2d23690f6a7593c0db98cd2
Cq-Include-Trybots: luci.chromium.try:android-arm64-rel,android-pie-arm64-dbg
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626513
Commit-Queue: Samar Chehade-Lepleux <[email protected]>
Owners-Override: Samar Chehade-Lepleux <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159517}
Roll ios_internal from d59c0342d15e to 70ff666ddab7
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/d59c0342d15e..70ff666ddab7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I8489a11df2f0cddff70d179877074031d736b002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625557
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159516}
Manually revert to working V8 version
Bug: chromium:1455389
Change-Id: I0953a0be3e6ea2523a3c2236777e1af2f1c4989e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626493
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Manos Koukoutos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159515}
Inherit COOP: restrict-properties and un-suppress opener
To make the `Cross-Origin-Opener-Policy: restrict-properties` (COOP:RP)
more useful, we'd like to let cross-origin iframes inherit this policy
from their parent and keep the opener connection between windows that
the iframes open. See
https://github.com/hemeryar/coi-with-popups/blob/main/docs/cross_origin_iframe_popup.MD
for more explanations.
In https://crrev.com/c/4404116, we've bundled the origin that sets the
COOP with the policy. This CL is to use the stored origin in COOP
algorithms:
1. In `RenderFrameHostImpl::DidCommitNewDocument`, we let embedded
documents inherit the COOP:RP bundle when the policy is COOP:RP.
2. To keep the opener connection, we return false in
`COOPSuppressOpener` when COOP value is RP.
3. Since we allow the popup's initial empty document and its subframes
to stay in the process, we had to restrict its crossOriginIsolated
capability. Otherwise, a cross-origin iframe can get around permission
policy that restricts it from using crossOriginIsolated APIs.
- For the initial empty document, we pass a boolean to the renderer
via CreateNewWindow.
- For the subframes of the initial empty document, we pass a boolean
via CommitNavigation.
This CL also adds new test cases for
1. Cross-origin iframe opener v.s. same-origin iframe opener.
2. Checking the popup's subframe's `crossOriginIsolated`.
3. Checking popup's `crossOriginIsolated` after it navigates away from
the initial empty document. (This is to make sure that we don't
restrict the `crossOriginIsolated` when we shouldn't)
Bug: 1385827
Change-Id: I39cd140f70b628114205640af2220ec2de45ac06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4479858
Auto-Submit: Jonathan Hao <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Jonathan Hao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159514}
[iOS] Fix flakiness after testSyncSpinnerDismissedInRecentlyClosedTabs
During ChromeTestCase tearDown, a signOutAndClearIdentities is done.
A browsing data cleaning is done during this step, and shows a full
screen spinner blocking UI actions.
Therefore, some following tests which run without waiting for the
cleaning completion fail on the first run due to this long-lasting
spinner.
This CL fixes the test's flakiness by:
- Introducing [ChromeEarlGrey
signOutAndClearIdentitiesAndWaitForCompletion] which wait for the
cleaning completion;
- Reducing the clean browsing data step delay by [ChromeEarlGrey
killWebKitNetworkProcess] in TabGridTestCase teardown (solution being
used in crbug.com/1419875);
- Cleaning browsing history in
testSyncSpinnerDismissedInRecentlyClosedTabs to reduce sign-in
delay to avoid flakiness.
Bug: 1448618, 1419875
Change-Id: I572f5aecf8f5a0c5c1c32484c6ebb102162c2f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570665
Commit-Queue: Menghan Yang <[email protected]>
Reviewed-by: Joemer Ramos <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159513}
Enable Sessions and UserEvents in transport mode
...if kReplaceSyncPromosWithSignInPromos is enabled.
Bug: 1448887
Change-Id: I14c8ef48a8013fca9fe5c8b70f11a53bb1d2371e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614601
Auto-Submit: Marc Treib <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159512}
Delfake inspector-protocol/network/multiple-headers.js
It looks like loadingFinished might be sent by the browser after
it sends reponseReceivedExtraInfo but before reponseReceived get
delievered from the renderer and the test misses it.
Bug: 1415385
Change-Id: Ide53d276a2a09cc6d1fb411423eea239de6b7373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626218
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Commit-Queue: Jaroslav Sevcik <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159511}
[apple] Fork iOS and macOS path providers
The implementations are quite different already, with quite a few
BUILDFLAG(IS_XXX) checks making the code difficult to read. As it
will soon become necessary to change iOS implementation to support
"transparent" framework, it is probably better to have distinct
implementation files.
This will also allow to eventually remove the definition of enums
that are not supported on iOS such as DIR_USER_DESKTOP or soon
DIR_MODULE and FILE_MODULE.
Bug: 1452229, 1434760, 1257402
Change-Id: I93f4b95aaa8b98a2a72a5579f2283e98fcc308e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614926
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159510}
[devtools] Split web test into two
The test only times out on debug builds and doesn't reproduce locally.
So as a first step we split the test into two files and run 3 test
cases each. Locally this reduces running time from ~44 seconds
to ~29 seconds.
[email protected]
Bug: 1455530
Change-Id: Ifac540915c4f25ff1963e05b85a6f8f8aa2309a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625451
Commit-Queue: Simon Zünd <[email protected]>
Auto-Submit: Simon Zünd <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Commit-Queue: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159509}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687154185-fecb8cfc46bef2bb7879c017e94c9510593294ff.profdata to chrome-mac-arm-main-1687161332-afda551e58e8a4a49bff81adc0f52e31c94763a2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib8caf228e33ca5713ae0eaf8541fba9019500445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625728
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159508}
Add track based trace events to network::ResourceScheduler
These events are useful to understand how ResourceScheduler handles
resource requests. Add a dedicated category since there could be many
events when tabs load many resources.
Bug: N/A
Change-Id: If1bee7bdcdfb2321f93c73136aad783baa4fa047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622850
Reviewed-by: Adam Rice <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159507}
Make main resource load forced fallback if the rule matches
This bring main resource load to forced fallback if
ServiceWorkerRouterEvaluator think the request should be handled by
network source as subresources are already handled in [1].
[1] crrev.com/c/4596442
Bug: 1371756
Change-Id: I32dbf44c19e904cb48460dc6bcfbe39747403f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616116
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Commit-Queue: Shunya Shishido <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159506}
[Gardener][Android] Revert "Add CreateNewTabInitializeRenderer to field_trial_config"
This reverts commit e958a1e45802559d5e721073ace84e6ee95a6673.
Reason for revert: https://crbug.com/1455878
Original change's description:
> Add CreateNewTabInitializeRenderer to field_trial_config
>
> Also fixes tests which don't expect renderer creation during
> new tab creation.
>
> This CL also sets a new baseline for skia gold images as for
> render tests didn't expect new renderer creation.
>
> Bug: 1440527
> Change-Id: Icf25aa5ab2b6427f25a36cbabe8ce0f117aed0f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582104
> Reviewed-by: David Trainor <[email protected]>
> Commit-Queue: Sreeja Kamishetty <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1159128}
Bug: 1440527
Change-Id: Id9c89ebedfb633c7ff8249a2950d2ab9f902e444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626314
Owners-Override: Samar Chehade-Lepleux <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Samar Chehade-Lepleux <[email protected]>
Reviewed-by: Samar Chehade-Lepleux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159505}
Roll ANGLE from 24f4007b93e0 to 46f444ddd05e (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/24f4007b93e0..46f444ddd05e
2023-06-19 [email protected] Roll Chromium from 7df45c601f1c to cc7a0bd198ec (1481 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I35729c95c6da545b7486b824ca0f0efdceff7ab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624525
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159504}
autocorrect: bump field trial config of en840 and FST experiment
We no longer need the "only_en840" experiment group, so it should be removed in the updated field trial testing json.
Bug: b/268289489
Change-Id: I258483762514a8475224e6275539668a9d510659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583568
Commit-Queue: Chuong Ho <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159503}
Roll ios_internal from ee66b46587cd to d59c0342d15e
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/ee66b46587cd..d59c0342d15e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1454395
Change-Id: I5f946dc529576a2ea1cef6bb2b641deb176becad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624682
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159502}
Add ability to trigger suggestions from the browser process.
This CL adds a new function TriggerSuggestions(field, trigger_source) to
AutofillAgent's interface. It enables the driver to trigger suggestions
for a given field, as if triggered from the given trigger_source.
This is unused by this CL, but will be used in a follow-up CL to trigger
suggestions for the fallback mechanism (context menu). It is necessary
since the context menu manager lives in the browser process. It cannot
directly trigger suggestions via the manager, since the field's position
can be outdated (the position is necessary to render the suggestions at
the right location).
Bug: 1446318
Change-Id: I554cc6e13694012cb752ce90942ec7a58eb569f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545092
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159501}
WebNN: Define XNNPACK Node for tanh
This CL implements DefineXnnNodeForTanh() method that defines XNNPACK
Node for tanh MLOperator by xnn_define_tanh().
This CL also implements TanhTest of MLGraphXnnpackTest that checks
the compute results of a MLGraph containing a tanh MLOperator against
the results of calling XNNPACK tanh operator API for the same input.
Bug: 1273291
Change-Id: If01680e359f412b3cd35b879cbf546a26428e0b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607612
Commit-Queue: Lisha Guo <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Jiewei Qian <[email protected]>
Quick-Run: Alan Kelly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159500}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1687132334-cee0a7f66e5955067075eb72b656e2d07e47e249.profdata to chrome-mac-main-1687154185-eb59b1352931b5a4a42258355e52bbd0f3eeb360.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib52186066e67fd086002e42716c1c28740958cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625706
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159499}
[Autofill] Fix string representation of BIRTHDATE_YEAR_4_DIGITS
Before this CL, the string representation of BIRTHDATE_YEAR_4_DIGITS
was "BIRTHDATE_YEAR_4_DIGITS" instead of "BIRTHDATE_YEAR_4_DIGITS".
Bug: 1007974
Change-Id: I78aa8674d08964af6e3c27999523219a7e69b9a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624749
Auto-Submit: Christoph Schwering <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159498}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687146531-cd21ee491d1ca5906d4fd9ed6ec0f4288c996eef.profdata to chrome-mac-arm-main-1687154185-fecb8cfc46bef2bb7879c017e94c9510593294ff.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If4bb2b102c2a7da7e6cee8a8002ed27cde4c254d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625722
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159497}
Introduce CreateBrotliSourceStreamWithDictionary() method
This CL introduces CreateBrotliSourceStreamWithDictionary() method which
calls BrotliDecoderAttachDictionary() method to use the dictionary.
This method will be used for compression dictionary transport with
Shared Brotli feature (crbug.com/1413922).
Bug: 1413922
Change-Id: Id2b0e690cd6f2a2c6fceaa61a9ec24566cdf017b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624008
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159496}
Roll androidx from Gb7vLkZsOy6VLPsYk... to RczfVQI4RfdpgVeMO...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: I6de97e2fab4c73e8e17894256ceeb833a149381d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625575
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159495}
Roll devtools-internal from 3eb347724903 to 141e738c13f3 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/3eb347724903..141e738c13f3
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2dd8398b55dbcfe97ea154c82154ccb1c844f509..3b437858b09458fc57bfebf914293d19459469df
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I2250efb5de06d4887245a6c284dce2238a639e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4626335
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159494}
Make sure filling is disabled when password store is unavailable
Bug: 1454584
Change-Id: I47e3856f68c3d67c290d47664b439473e1e1daa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620393
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Auto-Submit: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159493}
gardener: Disable flaky OSSettingsApnSubpageTest.All
Bug: 1455866
Change-Id: If83e5ebe38e49f85c3572a201886f8395e97d7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621173
Reviewed-by: Kentaro Hara <[email protected]>
Auto-Submit: Yuki Shiino <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159492}
Roll Depot Tools from 3ffad8166e1c to 4992184cd155 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ffad8166e1c..4992184cd155
2023-06-19 [email protected] [autosiso] add SISO_PATH env var
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: Ifc4128ede1bebdf8a03adfdda8a1ba95426f2505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624681
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159491}
Revert "Add V8 GC finch experiments to field trial config"
This reverts commit ddf05156f8546d17d72fd405bdaa4b9a55962378.
Reason for revert: Experiments caused some regressions on bots.
Original change's description:
> Add V8 GC finch experiments to field trial config
>
> This CL enables features for code flushing and sechduling a single
> memory reducer GC in field trial configs.
>
> Bug: v8:13842
> Change-Id: I92122b5ca2c026ca4c9bf76dd29a071642b44c1e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615072
> Auto-Submit: Dominik Inführ <[email protected]>
> Reviewed-by: Michael Lippautz <[email protected]>
> Commit-Queue: Dominik Inführ <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158679}
Bug: v8:13842
Change-Id: I25a167549a97405a9a9907d8e0034c591bdb5523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623828
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Dominik Inführ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159490}
[capture_mode] Add support for multiplanar SI to CameraVideoFrameHandler
This CL adds support for non-legacy multiplanar SharedImages to
CameraVideoFrameHandler. This means that there are now three codepaths
in CameraVideoFrameHandler that deal with multiplanar SharedImages:
* Creating a single SharedImage with format MultiPlaneFormat::kNV12
(new codepath that is used when kMultiPlaneVideoCaptureSharedImages
is enabled and IsMultiPlaneFormatForHardwareVideoEnabled() is true)
* Creating one SharedImage for each of the two NV12 planes (existing
codepath that is used when kMultiPlaneVideoCaptureSharedImages is
enabled and IsMultiPlaneFormatForHardwareVideoEnabled() is false)
* Creating one SharedImage for which external sampling is performed (
existing codepath that is used when
kMultiPlaneVideoCaptureSharedImages is false)
kMultiPlaneVideoCaptureSharedImages is not enabled on ChromeOS but is
enabled by default on Windows and Mac, where this code will shortly be
used.
Bug: 1454406
Change-Id: I9d6eb27d4eeb08ac4ac48c2c8d6fa07d61d6d3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614558
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159489}
[Frameworks roll] Roll to 541533173 piper revision
Change-Id: I5ebda1b11f03c0efe7860ac6cd87dc1579f16888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624809
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159488}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1687108515-7aa2c446abe243db889dccd19e23bc2e36c98192.profdata to chrome-linux-main-1687154185-ffe355a1027d118b720145bb98983f738a268c6c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I34719deb7a52e80caf9d16129abe5219512d0de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625573
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159487}
[FilesBulkPinning] Update the remaining time using Speedometer
The Speedometer class is used in the IOTask framework to show the
appropriate remaining time for ongoing tasks. This reuses that and
plumbs through the remaining seconds to the UI.
Bug: b:279847004
Change-Id: I5f4653fffe1555788b9c8233c313f4751f4b555c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617788
Reviewed-by: François Degros <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159486}
Unexpire WebRTC.PeerConnection.CandidatePairType_UDP, WebRTC.PeerConnection.IPMetrics
Unexpire histograms and add new owners.
Fixed: chromium:1448118
Change-Id: I83e5bbc95fc147a1c0cac9a870a77b7c5482897a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620530
Reviewed-by: Harald Alvestrand <[email protected]>
Reviewed-by: Philipp Hancke <[email protected]>
Commit-Queue: Johannes Kron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159485}
[skylab_tests] Update skylab tests cros img version
This cl only affect Lacros or Skylab on-device config builders like
lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab
(kevin)". This cl will certainly NOT affect linux-lacros builders
(linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Cq-Include-Trybots: luci.chrome.try:lacros-amd64-generic-chrome-skylab
Cq-Include-Trybots: luci.chrome.try:lacros-arm-generic-chrome-skylab
Cq-Include-Trybots: luci.chrome.try:lacros-arm64-generic-chrome-skylab
Requires-Testing: True
Change-Id: I59fd22b34cb3e24b17f96bf09c2ab8176e760804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625233
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159484}
Investigate CHECK_EQ(WriterState::kNotStarted, body_writer_state_) failure
This CL intends to investigate https://crbug.com/1450185. This CL dumps
stack traces along with the status values.
Bug: 1450185
Change-Id: I78f7dffd03526bcdab78b506869b907d28a1217a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621170
Reviewed-by: Shunya Shishido <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159483}
autocorrect: prevent PK activation of autocorrect enabled by default if using lacros
Bug: b/287434736
Change-Id: I14a04bd870d29cf960adcfec187fa643e406bf69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623966
Reviewed-by: Curtis McMullan <[email protected]>
Commit-Queue: Chuong Ho <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159482}
[ios] Move OverscrollActionsControllerDelegate out of BVC
This CL moves the implementation of OverscrollActionsControllerDelegate
out of BVC. In particular, the logic has been moved inside
BrowserCoordinator.
Change-Id: I6c98c5c19cc238bb192b27d6696d54bac4414b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614431
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Federica Germinario <[email protected]>
Reviewed-by: Asami Doi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159481}
Disallow process-per-site-with-main-frame-threshold for non http(s)
Schemes other than http(s) often assume that processes are not shared.
Disallow process sharing on schemes other than http(s).
Bug: 1455017
Change-Id: Ic9345475a3b6f95569d289e85676cb2dc8da9114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615402
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159480}
Roll devtools-internal from 3d1cad08ca73 to 3eb347724903 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/3d1cad08ca73..3eb347724903
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I842b95ee1eb4fc4ae007a21f9d6ef0dc34330920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625703
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159479}
Fix encoding when communicating with ninja
Ninja escapes UTF-8 symbols in some cases, and it causes errors when
parsing ninja commands, for example:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/rust/strsim/v0_10/BUILD.gn;l=24;drc=42a40ac8eb5420b0b7ff7142102ed4bed479e6c4
Tested locally.
Bug: None
Change-Id: If2dae9b15b5ee664d90f92e3669598f7ba229a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623929
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Rushan Suleymanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159478}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5841.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I2097c7069b7c8c9d02c7cafbef044b426127480c
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621326
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159477}
Add UKM metrics for the second chunk of the blocklisted features
This CL adds the UKM entry for:
- HistoryNavigation.MainFrameFeatures2
- HistoryNavigation.CrossOriginSubframesFeatures2
- HistoryNavigation.SameOriginSubframesFeatures2
- HistoryNavigation.BackForwardCache.BlocklistedFeatures2
They are all used to store the 64th-127th bits of the tracked feature
bit mask.
Bug: 1447441
Change-Id: I548eefde2fae4df33861cae0ccf61fe1e75015ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617488
Reviewed-by: Sun Yueru <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Mingyu Lei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159476}
[PA][BRP] Run GetUsableSizeWithMac11MallocSizeHack test only on Mac11
Proposed by tasak@ in crrev.com/c/4604257, thank you!
Bug: 1349955
Change-Id: Ibfe473d9e905bbf7dd2e119bf52a0f0143ea4907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622848
Commit-Queue: Takashi Sakamoto <[email protected]>
Auto-Submit: Bartek Nowierski <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159475}
Roll src/net/third_party/quiche/src/ 731acaf58..1b0f3d9d7 (6 commits)
https://quiche.googlesource.com/quiche.git/+log/731acaf58ca1..1b0f3d9d792d
$ git log 731acaf58..1b0f3d9d7 --date=short --no-merges --format='%ad %ae %s'
2023-06-16 vasilvv Implement fetching dependencies in QUICHE depstool
2023-06-16 vasilvv Fix QUICHE standalone build
2023-06-16 wub Automated g4 rollback of changelist 540881082.
2023-06-16 haoyuewang Check if CID is missing in QuicConnection::WriteIfNotBlocked.
2023-06-16 mkruskal IWYS fixes for //base headers
2023-06-16 danzh Internal change
Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
Change-Id: Iec6c3ec510e1d069b323414c47d4b4d29c97a344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622854
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159474}
gardener: Disable flaky tests in chrome_all_tast_tests
Disable:
- arc.CheckAndroidVersion
- arc.ContainerMount
- arc.Downloads
- network.ConfigBaseline.login
Bug: 1455848
Change-Id: Id7406a14e6199aa3b4369413d9ac4ba1371e6c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624013
Commit-Queue: Yuki Shiino <[email protected]>
Auto-Submit: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159473}
ac: enable updated model by default
Now that we have found this change doesn't degrade the autocorrect
experience or the VK experience, or cause any crashes, we should be safe
to enable it by default.
BUG=b:287892893
Change-Id: Ie24ad49bd7adf221e221d99c0f3d0819f086d8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624216
Commit-Queue: Curtis McMullan <[email protected]>
Reviewed-by: Mehrab N <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159472}
CCNS BFCache: set different BFCache TTL for CCNS page
This CL adds another constant for the BFCache TTL of a CCNS page,
currently it's set to 3min which is shorter than the default 10min.
See https://github.com/fergald/explainer-bfcache-ccns#timeout
Bug: 1453517
Change-Id: I5fb8261cd9ab2c00cb0508942e7e225310f60f93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604248
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Mingyu Lei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159471}
[Chrome Refresh] Update bookmarks folder icons.
Bug: 1399955
Change-Id: Ie6441f647e7b7c7344a75a5e73dddc370df05a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619129
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Shibalik Mohapatra <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159470}
Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision)
https://skia.googlesource.com/skia.git/+log/f489be63a30a..24f2336d87f2
2023-06-19 [email protected] Roll Dawn from 4588fe12df3d to fc6011e89acd (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I9117bf83958f71056af907f901ea0078a6174eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625376
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159469}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687132334-8a06ed7ae39075e7e736ca88bf46717b2b22a0fe.profdata to chrome-win32-main-1687143525-e712a2e0a22d0b2a76c5c2621d436b1fe5441fd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I03cd9d537b3f2787cb85f23eecc26535700c06d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625716
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159468}
CCNS BFCache: do not cache CCNS page if WebRTC/Transport/Socket used
In the current implementation, if the WebRTC/WebTransport/Websocket
connections are closed, the non-sticky feature will be removed and the
page will be eligible for BFCache.
However, the page may contain some sensitive data that are retrieved
over these channels before the connection closure, so we should not
store the CCNS page into BFCache.
This CL also create `kAllowedForNonCacheControlNoStoreFeatures` for
those features that are allowed for non-CCNS page BFCache, and moved
`kAuthorizationHeader` over.
Bug: 1446619
Change-Id: Ic2e1e49d50fe522b1a66c6e011cb6fa83670d05d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4549039
Commit-Queue: Mingyu Lei <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159467}
Adjust cros.typography.display0
Adjusting size from 57 to 52px
Adjusting line height from 64 to 60px
Change-Id: I588fe05dc62553e6fac6e5e3a4c4b83ee10659c2
Bug: b:287503645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621415
Reviewed-by: Zain Afzal <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Zain Afzal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159466}
Revert "showoff: change the LLS backend to linear map."
This reverts commit 4bf586e23723781727f0a4e045e8513dc2a61956.
Reason for revert: As a culprit of the MSan failure at:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/36547/overview
The following part of code might be related:
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:chromeos/ash/components/local_search_service/shared_structs.h;drc=8d3b19d9432fa06963a1efbd8b85d5d310c3a05a;l=96-99
Original change's description:
> showoff: change the LLS backend to linear map.
>
> Showoff in launcher search was using inverted index, but the small
> corpus of the articles causes over-triggering. We change the backend to
> linear map to better support articles with small corpus.
>
> More details at:
> https://docs.google.com/document/d/1Vc0fvMLCQYpbCRk6-zOksi2uZg2ddLEBQaxE7ExNy2A/edit
>
> Bug: b/281564559
> Test: manually tested on DUT.
> Test: ash_webui_unittests --gtest_filter='*HelpAppSearchHandlerTest*'
> Test: ash_webui_unittests --gtest_filter='*HelpAppSearchTagRegistryTest*'
> Change-Id: I0c9f0bf08d5e353a2c01ec0273813e58389f949d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620049
> Reviewed-by: Dmitry Grebenyuk <[email protected]>
> Reviewed-by: Zufeng Wang <[email protected]>
> Commit-Queue: CJ Huang <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1159428}
Bug: b/281564559
Change-Id: I9c8ed5d912f1112df496f3a6f38515cac6fc0a45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624214
Auto-Submit: Yuki Shiino <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159465}
Prerender: Use |IsDisallowedHttpResponseCode| in
|MakeDidCommitProvisionalLoadParamsForActivation|.
This CL uses |prerender_navigation_utils::IsDisallowedHttpResponseCode|
in |MakeDidCommitProvisionalLoadParamsForActivation| to make the
expectation of allowed http status code consistent.
Bug: 1441842
Change-Id: If690bf5d10936c3fc920c31bdaf27b7cbacad8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609824
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Huanpo Lin <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159464}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687138381-d02de997940cbed8e74b150a9552780008560661.profdata to chrome-mac-arm-main-1687146531-cd21ee491d1ca5906d4fd9ed6ec0f4288c996eef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If94222649134672e43229539b4f49c5a757588c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625378
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159463}
Fix typos in comments
BUG=None
Change-Id: Ia2d6ad5ac8b6edec010c3e23bde33d3d98061216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624235
Auto-Submit: François Degros <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Commit-Queue: François Degros <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159462}
Apps: Extend expiry of UMA apps metrics
Extend the expiry of several apps metrics which recently expired. Since
the expiry was less than a month ago, we _should_ be in the grace
period, and can revive the metrics with no data loss.
I've also changed the metrics to use <component> as a hopefully more
reliable way to get them on the team's radar while individual owners are
away.
Bug: 1433753, 1433754, 1433787, 1433791, 1433792, 1433793
Change-Id: I551954a7ad00ca96a0e100f32795f876b4456226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623957
Auto-Submit: Tim Sergeant <[email protected]>
Commit-Queue: Melissa Zhang <[email protected]>
Commit-Queue: Tim Sergeant <[email protected]>
Reviewed-by: Melissa Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159461}
BulkPinning: Add histogram FileBrowser.GoogleDrive.BulkPinning.ToDownloadMB
BUG=b:285434660
Change-Id: Ib326f58f1d82d6b8ff339803aab1834561c00690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617607
Auto-Submit: François Degros <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159460}
BugFix: CHECK_EQ(WriterState::kNotStarted, body_writer_state_) failure
This CL intends to fix the following check failure in
ServiceWorkerNewScriptLoader::MaybeStartNetworkConsumerHandleWatcher().
CHECK_EQ(WriterState::kNotStarted, body_writer_state_);
This fix's assumption is that the call WriteHeaders() from
OnReceiveResponse() ends up with calling CommitCompleted(), hence
body_writer_state_ becomes kCompleted state when
MaybeStartNetworkConsumerHandleWatcher() is called even though
MaybeStartNetworkConsumerHandleWatcher() expects that body_writer_state_
== kNotStarted.
```
void OnReceiveResponse(...) {
...
WriteHeaders(response_head.Clone());
// => body_writer_state_ becomes kCompleted.
...
MaybeStartNetworkConsumerHandleWatcher();
// => body_writer_state_ is not kNotStarted anymore.
}
```
To fix this scenario, this CL checks if WriteHeaders() calls
CommitCompleted() or not, and if it's already called, it returns early.
[CommitCompleted() function]
At the end of CommitCompleted() function, all states become kCompleted.
- network_loader_state_ = LoaderState::kCompleted;
- header_writer_state_ = WriterState::kCompleted;
- body_writer_state_ = WriterState::kCompleted;
[When this bug happens]
From the crash report, this almost always happens when
ExtensionURLLoader::OnFilePathAndLastModifiedTimeRead() is called. So
the Chrome extension triggers this bug. But still I'm not sure the
reproducible concrete scenario.
Bug: 1450185
Change-Id: I8ad742d5afe21ed6674b1002d1ec64b44b34f086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617796
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Reviewed-by: Shunya Shishido <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159459}
Replace HostPortPair with SchemeHostPort in ResourceScheduler
SchemeHostPort is a superset of HostPortPair. We can remove some
one-off SchemeHostPort creations by creating SchemeHostPort in the
constructor of ScheduledResourceRequestImpl.
There is no behavior change.
Bug: N/A
Change-Id: Ie4e75531dea0ab54d392b706bbd9c86144338a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622856
Reviewed-by: Nidhi Jaju <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159458}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687132334-80b1757e5c68b3ec26c7220e56669cb0fc454bd2.profdata to chrome-win64-main-1687143525-7859c6f0e6dc599e894dafd185a1530e7d9219dc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I6f50a6b9700a735eb429f9b8fd0a4eaa329ab9c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623505
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159457}
Roll clank/internal/apps from 8ace47dda627 to c94bc5f9b2b6 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/8ace47dda627..c94bc5f9b2b6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Iede90d4a3ee70c745575891aa07a963706926db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625718
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159456}
Revert "[BRP] Enable check_raw_ptr_fields for LaCrOS"
This reverts commit 6205122df1ba995fa14dc79a2a7e59f8a24df2aa.
Reason for revert: Suspicious about the compile failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8777890105415583745/+/u/compile/stdout
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-dbg/23299/overview
Original change's description:
> [BRP] Enable check_raw_ptr_fields for LaCrOS
>
> Bug: 1273182
> Change-Id: I45138cf7858c718bae7d6a24e57167195882c176
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617708
> Reviewed-by: Keishi Hattori <[email protected]>
> Reviewed-by: Takuto Ikuta <[email protected]>
> Commit-Queue: Mikihito Matsuura <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1159451}
Bug: 1273182
Change-Id: I96299e7e649c45e35fef4ff57e6ec8b43f6d2696
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624192
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Owners-Override: Yuki Shiino <[email protected]>
Auto-Submit: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159455}
[Office a11y] Add play/pause button for animation
A new play/pause button is added to the lottie animation, the
button will be displayed when the lottie animation is hovered or
the button itself is being focused via keyboard.
Demo: http://go/scrcast/NTc0MDUyMzgzMTY4OTIxNnw5OTBmMDkwYy03OQ
Bug: b:286940750
Change-Id: I591adcac88df6ba5b355d33c97a9a7379cd4d412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622862
Commit-Queue: Wenbo Jie <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159454}
CrOS Settings: Focus page after menu item select
When infinite scroll is removed, clicking a menu item should shift
focus to the page contents.
Screen recording: http://shortn/_dngeqXdTXx
Bug: b/285968876
Test: browser_tests --gtest_filter="OSSettingsMainPageContainer*"
Test: browser_tests --gtest_filter="OSSettingsOsSettingsUi*"
Change-Id: Iff143d5cbe1e6b414df73ff7fa03090bab1f264d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614412
Commit-Queue: Wes Okuhara <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159453}
Speculative fix of editing/selection/inactive-selection.html, take 2
crrev.com/1158673 didn't improve the flakiness. It seems 'focus' event
isn't dispatched.
This CL updates the test so that it doesn't rely on 'focus' event.
Bug: 1455247
Change-Id: Ieb3a66d82ec9563d7b1ee32e143bba9ac52a1a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622857
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159452}
[BRP] Enable check_raw_ptr_fields for LaCrOS
Bug: 1273182
Change-Id: I45138cf7858c718bae7d6a24e57167195882c176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617708
Reviewed-by: Keishi Hattori <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Commit-Queue: Mikihito Matsuura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159451}
Files Office: Record UMA for upload to cloud latency
Change the OneDrive and Google Drive upload handlers to report back
the total upload size to be able to record the UMA.
Bug: b:264309906
Change-Id: I6ffc8207e6473e3629cf7f26298919a9c859e9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612728
Auto-Submit: Luciano Pacheco <[email protected]>
Reviewed-by: Alexander Bolodurin <[email protected]>
Commit-Queue: Alexander Bolodurin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159450}
[WebUI] Enable trusted types CSP in crostini UIs
As part of moving to Trusted Types CSP, we are sanitizing strings before assigning to inner-h-t-m-l. Util method for sanitizing inner htmls disallows target attributes set to anything other than _blank so we are changing the relevant chromeos string.
Disabling presubmit as the chromeos string change does not affect UI and needn't require a new screenshot for translation.
No-Presubmit: true
Bug: 1400799
Change-Id: Idecc3ccc99aebf8121033c43bca05a68d7f5f66b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573487
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Clement Yan <[email protected]>
Reviewed-by: Fergus Dall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159449}
Import wpt@0a343c267faa12ad680a809c9afa87807c92c852
Using wpt-import in Chromium b9dba2bc3243ffd7c6de220e51a1f68972259cd5.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I3a4fc73a053316a2d233992ea3e8961562f85ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625491
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159448}
ChromeRefresh2023: fix internal content padding for CR23 tabs
Bug: 1399942,1454274, 1454315
Change-Id: Id2afd413fc1fef3443ffdb8dbbb2bf623f35223c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618699
Commit-Queue: David Pennington <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Shibalik Mohapatra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159447}
system-web-app: update link capture test expectations for LacrosOnly
This CL updates SWA link capture test expectations to prepare for
WebAppsCrosapi flag removal.
Fixed: b/287167145
Change-Id: Ia3786ff2b7f50d0cbcef6e9d55df15b687f5c11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617697
Reviewed-by: Georg Neis <[email protected]>
Commit-Queue: Jiewei Qian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159446}
Roll Fuchsia SDK from 13.20230618.2.1 to 13.20230618.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: Ief15daf3ffa06c3aac31852cc8c648355285262e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623501
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159445}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687132334-11c353d88b561130c3fad10699ce1ec47d9a5203.profdata to chrome-mac-arm-main-1687138381-d02de997940cbed8e74b150a9552780008560661.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I62637536da9e784a073a43ec4bee8d63f4a5fd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625755
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159444}
Reland "Implement OnKeyboardLayoutInstall in zcr_keyboard_configuration"
This is a reland of commit 73b4a4b5b73772a21e14211cdf6f2e907d75c3a7
Original change's description:
> Implement OnKeyboardLayoutInstall in zcr_keyboard_configuration
>
> Also scans for installed layout in constructor
>
> Bug: b/194629768
> Test: manual test
> Change-Id: I601c211c741fdd594a3deccd7e2b02800ea7e2ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4542581
> Reviewed-by: Hiroki Sato <[email protected]>
> Commit-Queue: Nergi Rahardi <[email protected]>
> Reviewed-by: Yuichiro Hanada <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1151100}
Bug: b/194629768
Change-Id: Iec8188b7f5e599c0c608ffdb8d33cf6884d3dff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583310
Auto-Submit: Nergi Rahardi <[email protected]>
Commit-Queue: Nergi Rahardi <[email protected]>
Reviewed-by: Hiroki Sato <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159443}
Rename a feature: kAllowDevToolsInSystemUI
This commit changes the feature name by removing an unnecessary prefix
"k". The new name is "AllowDevToolsInSystemUI".
Change-Id: I2a2e6935d071ba358f3930b6b5e5d78625374097
Bug: 1421637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619988
Reviewed-by: Georg Neis <[email protected]>
Commit-Queue: Jun Ishiguro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159442}
Updating trunk VERSION from 5841.0 to 5842.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I3b41923be5489f9116c3b8f9494c54be512bf7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625850
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159441}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1687090014-c6d109eb6a26ab3cbc2fb145f369d4437ff98614.profdata to chrome-chromeos-amd64-generic-main-1687132334-bbfd67110af21be5b83640dec8be8965b4cace8d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I33da8c0e19f68ce9a7794d2a343a529d502d64d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625752
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159440}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687124583-c40178b841b5c8283545aca07b74c86a60cdbec9.profdata to chrome-mac-arm-main-1687132334-11c353d88b561130c3fad10699ce1ec47d9a5203.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I173a81b9b3c23e341f99a85a9e7d074ac7d7fae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625519
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159439}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1687108515-36d630c193d3cd31981356367cb16eddebdf8b0c.profdata to chrome-mac-main-1687132334-cee0a7f66e5955067075eb72b656e2d07e47e249.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I9e14f368c9642d2b2c33ec9c19e361224b73a6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625516
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159438}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687121153-a9b73a5a6b3667dd855d8bc7d43db2fcc1a6d3cc.profdata to chrome-win32-main-1687132334-8a06ed7ae39075e7e736ca88bf46717b2b22a0fe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I51df6e0bf83db3df696a96056f9c413a2b560439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625554
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159437}
Make info logs user builds
It is impossible to know if the storage works on user builds
without the vmodule, which makes it challenging to debug dlc
integrations.
TEST: "Works on my DUT."
Bug: b:287564085
Change-Id: I0967bf21570e48897c2148256df31a6e93b4f120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615810
Reviewed-by: CJ Huang <[email protected]>
Commit-Queue: Dmitry Grebenyuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159436}
[FilesF2] Add missing attributes for the tree item
Add attribute "has-children" and "aria-description" for the tree
items.
Bug: b:279092120
Change-Id: Ia01a702f5eb512fa6fa0f62eae32123ce02e837d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613806
Commit-Queue: Wenbo Jie <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159435}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687121153-317cb18dc7816cbb5343f52eef253fdd8c5cd7a2.profdata to chrome-win64-main-1687132334-80b1757e5c68b3ec26c7220e56669cb0fc454bd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Iab15e3eb96ccc2c8ace2870f418f917460d5febe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625553
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159434}
WebNN: Implement the build method of tanh operation
This CL implements the tanh() method of MLGraphBuilder. The tanh can be
built and connected with input and output operands. Or it can be built
as an MLActivation. This CL also implements the unit tests for both
scenarios.
Bug: 1273291
Change-Id: I368cde15a6c4e386176d4ead0fff1214022a48b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600527
Reviewed-by: Jiewei Qian <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Lisha Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159433}
Lacros: Add chrome://os-credits back to Ash WebUI allow-list
This one got lost in the recent refactoring
(https://chromium-review.googlesource.com/c/chromium/src/+/4482283).
Change-Id: I4d6801ae8ccc6cc9395bfdf0c80ba374d2801c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617694
Reviewed-by: Denis Kuznetsov <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159432}
Reland "Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json"
This is a reland of commit e1b6c1f4bc9dfda8693d05697130c15114c08716
Now https://crrev.com/c/4614764 is landed. Let's reland this.
Original change's description:
> Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json
>
> The previous CL (https://crrev.com/c/4604704) caused regressions. This
> CL tries to enable SpeculativeServiceWorkerWarmUp without
> IntersectionObserver.
>
> Bug: 1431792
> Change-Id: I7877c3ec652636d9c4dead9e6329f3642bf687b2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614823
> Reviewed-by: Yoshisato Yanagisawa <[email protected]>
> Commit-Queue: Minoru Chikamune <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157880}
Bug: 1431792
Change-Id: I7146ee7412837e1ea1061601fc285752e3474098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618055
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159431}
gardener: Disable a deterministic build error
Bug: 1453509
Change-Id: I7889d230de1381112da0cefa5156f1c3b2e1b40f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622861
Auto-Submit: Yuki Shiino <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Owners-Override: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159430}
[blinkpy] Replace `threading.Timer` for timing out subprocesses
`Timer` is a non-daemonic thread [0] that `Executive.run_command(...)`
uses to kill a timed out subprocess. When `run_wpt_tests.py` is
interrupted during the manifest update, the timer thread is leaked and
blocks the program from exiting.
This change replaces the timer with the `timeout` argument of
`communicate(...)`, which was added in python3.3. Also, conditionally
reenable tests for the timeout behavior of `Executive`.
[0]: https://github.com/python/cpython/blob/3.11/Lib/threading.py#L1370-L1395
Bug: 1382175
Change-Id: I6c982b62a76a3036f341b6fcc711ab29fe33e78e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624520
Commit-Queue: Jonathan Lee <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159429}
showoff: change the LLS backend to linear map.
Showoff in launcher search was using inverted index, but the small
corpus of the articles causes over-triggering. We change the backend to
linear map to better support articles with small corpus.
More details at:
https://docs.google.com/document/d/1Vc0fvMLCQYpbCRk6-zOksi2uZg2ddLEBQaxE7ExNy2A/edit
Bug: b/281564559
Test: manually tested on DUT.
Test: ash_webui_unittests --gtest_filter='*HelpAppSearchHandlerTest*'
Test: ash_webui_unittests --gtest_filter='*HelpAppSearchTagRegistryTest*'
Change-Id: I0c9f0bf08d5e353a2c01ec0273813e58389f949d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620049
Reviewed-by: Dmitry Grebenyuk <[email protected]>
Reviewed-by: Zufeng Wang <[email protected]>
Commit-Queue: CJ Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159428}
Roll clank/internal/apps from a4c1a8408929 to 8ace47dda627 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/a4c1a8408929..8ace47dda627
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ib77d6c5c912404d14f94a562b63dffec95a93d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625517
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159427}
Make alancutter@ and glenrob@ primary owners of //c/b/web_applications
Change-Id: I8b95e25026ba8e0300ae631ce7ac6792c0435c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620048
Auto-Submit: Glen Robertson <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Glen Robertson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159426}
Updating XTBs based on .GRDs from branch main
Change-Id: Id616ceabff581293af13c9b0245cfdc5f1fe069a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625470
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159425}
Remove feed video autoplay code
Bug: b/286993848
Change-Id: I6cd0ce187245ca883e71437eebf6b04cee9421da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610309
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Dan H <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159424}
Add dgrebenyuk to search owner.
Change-Id: I47bcc1899cb8d7b79392b3891ef71a66ea8a1f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622853
Reviewed-by: Dmitry Grebenyuk <[email protected]>
Auto-Submit: CJ Huang <[email protected]>
Commit-Queue: Dmitry Grebenyuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159423}
Roll clank/internal/apps from eb33b66f979f to a4c1a8408929 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/eb33b66f979f..a4c1a8408929
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ieb16b07738f09789781585c0ccc7a589527e8847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625511
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159422}
lacros: Fix guest support for profile loading in WebAppProviderBridge
This addresses a crash when calling WebAppProviderBridge methods from a
guest session with Lacros enabled (that is, an OS-level guest session,
not a browser-level guest profile). The crash was happening because a
profile was not being loaded correctly, so methods would fail on
CHECK(profile).
This CL unifies the profile loading approach between
BrowserServiceLacros and WebAppProviderBridgeLacros to ensure that the
same correct profile is used by both cases.
Bug: 1448748, b/285178006, b/285049791
Change-Id: I78fb11f19157b6eddb41a951b17d14779d5e30f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583325
Commit-Queue: Tim Sergeant <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159421}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687108515-be838275e5e954787cd6390d6a648cc7a3bff567.profdata to chrome-win64-main-1687121153-317cb18dc7816cbb5343f52eef253fdd8c5cd7a2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I2211fed3caa39eb7214a2c6a9096c81abd2c743e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625374
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159420}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687108515-bcefc4ab2ff1565576ebc7c1cc9962e2fc0e8198.profdata to chrome-win32-main-1687121153-a9b73a5a6b3667dd855d8bc7d43db2fcc1a6d3cc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I1ec9ced1e65661e609f8ddf845dc824dec7f2e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624675
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159419}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687117650-a991eb797cdb9572b667405745fc05f3e4045455.profdata to chrome-mac-arm-main-1687124583-c40178b841b5c8283545aca07b74c86a60cdbec9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I679c72809b58db99c63585d371385129bb75ebca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624406
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159418}
Revert "Reland "[fuchsia] Remove use of ambient VMEX capabilities""
This reverts commit c11a4d74972989b81042adafbda2c44f68991279.
Reason for revert: Breaks web-based tests on core.x64-release-chromium_latest (e.g. text-input-test), due to tests not offering
VmexResource in the service-directory of the test web contexts.
Original change's description:
> Reland "[fuchsia] Remove use of ambient VMEX capabilities"
>
> This is a reland of commit 32d1466c6def9112df62366e9d9872b282ba1f25,
> after addressing security policy & routing issues up-stream.
>
> - Remove job_policy_ambient_mark_vmo_exec from all component
> manifests.
> - Remove most usage of the ambient-VMEX-capable ELF test runner.
>
> Some use of the ambient-VMEX ELF runner remains, to support tests
> which run SwiftShader in-process, which requires ambient-VMEX for its
> shader JIT.
>
> The test CML fragment for the VMEX-capable ELF test runner is also
> still required by out-of-tree dependencies, notably ANGLE.
>
> Bug: 1290907, 1185811, 1022542
> Cq-Include-Trybots: luci.chrome.try:fuchsia-smoke-astro,fuchsia-smoke-sherlock
> Change-Id: I3c8265ed3ed4bd3b2bdca154c7bd81f0a5ef31c7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4589192
> Commit-Queue: Wez <[email protected]>
> Owners-Override: Wez <[email protected]>
> Reviewed-by: David Dorwin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1159323}
Bug: 1290907, 1185811, 1022542
Change-Id: I0a8d2bac20430de8f18243559a552221c1c8814e
Cq-Include-Trybots: luci.chrome.try:fuchsia-smoke-astro,fuchsia-smoke-sherlock
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622610
Quick-Run: Wez <[email protected]>
Owners-Override: Wez <[email protected]>
Auto-Submit: Wez <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159417}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687108515-219208ad265746edef3ce9742e8877ace747f6dc.profdata to chrome-mac-arm-main-1687117650-a991eb797cdb9572b667405745fc05f3e4045455.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I556ccc57b2d1d328995983249a0a03f89d0daeb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625345
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159416}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687099315-4cb49c22adc6f8232a22519b342e56b9c9fb0bfc.profdata to chrome-win32-main-1687108515-bcefc4ab2ff1565576ebc7c1cc9962e2fc0e8198.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Iaa1be363e4367370807f12e4c2473d8c3cdf121e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625336
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159415}
Roll ios_internal from 069b4f73b22d to ee66b46587cd
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/069b4f73b22d..ee66b46587cd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Id31242ff68d66406fab9829270019c4b14e79f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625272
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159414}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687102442-336ada8d63c50b4e53eb425299dfdb30497e1a50.profdata to chrome-mac-arm-main-1687108515-219208ad265746edef3ce9742e8877ace747f6dc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I721309d3bacab4c14d8277215a5f3d9bea44781b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625412
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159413}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1687088455-41c4eaaf5ffb037a1f4753a5b85e01f8da2ff62c.profdata to chrome-mac-main-1687108515-36d630c193d3cd31981356367cb16eddebdf8b0c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Id01509d91aab0bbe00e45347f87e78e3f090d002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625332
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159412}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687099315-0e86ec9ebe20b135ae59c610359dc0147b07676e.profdata to chrome-win64-main-1687108515-be838275e5e954787cd6390d6a648cc7a3bff567.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Id27c4fd5b0f38db6f72cd5cf281591489cefe5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625333
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159411}
[Frameworks roll] Roll to 541427507 piper revision
Change-Id: I3e55f029baf54a59ceda4c11a254ad704b69710e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624772
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159410}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1687088455-1aadd2ac5540616b3e8274bebdb2392467381efd.profdata to chrome-linux-main-1687108515-7aa2c446abe243db889dccd19e23bc2e36c98192.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ic238c0272fde05baca533e5a1fc0616d346115c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625271
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159409}
Roll Fuchsia SDK from 13.20230618.1.1 to 13.20230618.2.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I1e43a7dc84100d241d2929963a6b861ea8e4efd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625411
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159408}
[wptrunner] Add smoke tests for adapter
The wptrunner adapter is now complex enough that there should be
automated tests checking the `run_wpt_tests.py` to `wpt run` translation
layer at a basic level. This CL should prevent regressions like
crrev.com/c/4615725.
Fixed: 1356318
Bug: 1426296
Change-Id: I4359e3975220c022ed668a825d85d7884a2fa71e
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622653
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159407}
[wptrunner] Dedup `wpt_internal/` manifest generation
`blinkpy.w3c.wpt_manifest` generated the manifest with the default URL
base of `/` [0], which was mismatched with the URL base specified in
`web_tests/wptrunner.blink.ini` [1]. This change passes the correct URL
base so that [2] does not force a duplicate update that bypasses
`--no-manifest-update`.
Also, log when the update occurs for `run_wpt_tests.py`.
[0]: https://github.com/web-platform-tests/wpt/blob/289e601/tools/manifest/update.py#L71
[1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/wptrunner.blink.ini;l=5;drc=16567822f77c2a38d71b5df9d993011bb66ac448;bpv=0;bpt=0
[2]: https://github.com/web-platform-tests/wpt/blob/289e601/tools/manifest/manifest.py#L384
Fixed: 1454898
Cq-Include-Trybots: luci.chromium.try:linux-wpt-content-shell-fyi-rel
Change-Id: Ibeb25759aefe494c824206d6c7e8fad627800691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623792
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159406}
Add metric Media.Audio.MakeAudioInputStreamSuccess
Add a new metric to get the details on failing to create streams.
BUG=b:287419810
Change-Id: I6d7d37d08bef5da9fbdf1be46295041d14154373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614630
Reviewed-by: Luc Nguyen <[email protected]>
Auto-Submit: Yu-Hsuan Hsu <[email protected]>
Commit-Queue: Luc Nguyen <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159405}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687078120-68eebcd70e77e4d9366743df368c7dbe1b998026.profdata to chrome-win32-main-1687099315-4cb49c22adc6f8232a22519b342e56b9c9fb0bfc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Id2bde3c84d7fcfba0cb95407b0080a83b0ccde79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624789
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159404}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5840.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I53d0bbfd2179fb9595595548c6ccb574a57663c4
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625390
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159403}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687088455-9b587e8d1ca0b16b54ed24fde9877128a5187802.profdata to chrome-win64-main-1687099315-0e86ec9ebe20b135ae59c610359dc0147b07676e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I1da496cb6bab15a0de85a6ce6b59257e994b4d92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625290
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159402}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687095268-afd48d1f0ea0b0e86cf2904f509604a6030521e5.profdata to chrome-mac-arm-main-1687102442-336ada8d63c50b4e53eb425299dfdb30497e1a50.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8f330535287e8f3438085f29b24344f5fa3ff612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625370
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159401}
Roll Media App from yFibtt0-XhS1PnnMv... to WzMjhonPf_iSV4_oe...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202306180800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/WzMjhonPf_iSV4_oev23oxx03NI-G7qq4w5oz_lZjmgC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I85cfe4179b360d55a8f9e3276a4a633f36f3155b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624898
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159400}
Roll clank/internal/apps from bb32804a964f to eb33b66f979f (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/bb32804a964f..eb33b66f979f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Id412cefc28c15323487db6b484eba87b8c42db7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625291
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159399}
Roll Help App from yKFOHqw1zekWZTyc5... to LVDSBPDGiygRViVFE...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202306180800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/LVDSBPDGiygRViVFE-K8u1X7ZpjTCf7ABchLMx3jELAC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ia91b1ff5e0cef7114b3f1fdd340d7f6f648e5865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624899
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159398}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687078120-b9dc601d698f3bc0cca14b0e5df88a1388c92532.profdata to chrome-win64-main-1687088455-9b587e8d1ca0b16b54ed24fde9877128a5187802.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I87e49eef17c4e053864d236d1191d2e2f6ba51d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622166
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159397}
Roll devtools-internal from f32eedda53b7 to 3d1cad08ca73 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/f32eedda53b7..3d1cad08ca73
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d1c0c93522090f01d33f50531f61273878fbe5e..2dd8398b55dbcfe97ea154c82154ccb1c844f509
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I4b09afc34d86d8b409a1bcc5fae6314b25a029e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624382
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159396}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687088455-02fc2905f04edef0eda3788cbc5102f49c336f4b.profdata to chrome-mac-arm-main-1687095268-afd48d1f0ea0b0e86cf2904f509604a6030521e5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ieea3edb3cb79a75c8a15dc9733a17859e8c0d687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623420
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159395}
Updating trunk VERSION from 5840.0 to 5841.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I80376334416cc5a047bc6d00d4a5e06016616f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625230
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159394}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1687065625-244eb050f7578c3723b237c595af7b635def4894.profdata to chrome-mac-main-1687088455-41c4eaaf5ffb037a1f4753a5b85e01f8da2ff62c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I7339fd6248b67822225106ab67c2a4b10080d4fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624379
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159393}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687081993-0e59de0ddb4beb9ccdc9b22c7fde599b837d48a2.profdata to chrome-mac-arm-main-1687088455-02fc2905f04edef0eda3788cbc5102f49c336f4b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I58f2d5712f0d7fb06bf4b434c09f83f43048e158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624380
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159392}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1687046028-214e8252e188ac02af89e26cab08b57853fbc1e1.profdata to chrome-chromeos-amd64-generic-main-1687090014-c6d109eb6a26ab3cbc2fb145f369d4437ff98614.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I0cbf22b4bc9ba5314cfddf5ae9ada2dfa270181e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624518
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159391}
Automatic update from google3
Automatic update for 2023-06-18 UTC
Change-Id: Ic5e7371adbca02e92149f0063924687e7e6ebbc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623912
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159390}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1687046028-5e19f6b54e530cf561006510c247e4dc40bb7143.profdata to chrome-linux-main-1687088455-1aadd2ac5540616b3e8274bebdb2392467381efd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I2df61f4e3e9f151c10f347769f3a5da1b975ecc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624890
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159389}
Automatic update from google3
Automatic update for 2023-06-18 UTC
Change-Id: Ie7de5dde0dbb1ba8f1144ce3de8635b0d569f95f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623910
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159388}
Roll Skia from dc2e0ebbd045 to f489be63a30a (1 revision)
https://skia.googlesource.com/skia.git/+log/dc2e0ebbd045..f489be63a30a
2023-06-18 [email protected] Roll vulkan-deps from 3b886d2fc60b to 4aa38765aadb (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I18536c06da3ee101c30280a3ea21ac153190bfb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624888
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159387}
Roll clank/internal/apps from b3f3770b9353 to bb32804a964f (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/b3f3770b9353..bb32804a964f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ia46301ed09e86310245e6c317d6889ab2d298d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624889
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159386}
Roll Fuchsia SDK from 13.20230617.3.1 to 13.20230618.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I545dea7e434cf6028b8460c199548eea2a4c95d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624176
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159385}
Remove stale Blink expectations
Autogenerated CL from running:
//third_party/blink/tools/remove_stale_expectations.py --project chrome-unexpected-pass-data --no-include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --large-query-mode --num-samples 200 --jobs 2
Affected bugs for CL description:
[email protected]
Bug: 1446037, 1452003
Change-Id: Ie0333e09308f35917793585569dc36b802247085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623803
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159384}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5839.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I52d58b94f9734c218b259cae0c1a48ac66b362c7
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624849
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159383}
Roll Skia from 85b4788bc3f1 to dc2e0ebbd045 (1 revision)
https://skia.googlesource.com/skia.git/+log/85b4788bc3f1..dc2e0ebbd045
2023-06-18 [email protected] Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Id6002d00c2880c51056aa938f5f63e1fa1d75f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624974
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159382}
Remove field trial testing config for fuzzy match experiment
Bug: b/260764125
Change-Id: Iebc706992a5a3d2aabe63d6e1825184b0d5389a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617491
Reviewed-by: CJ Huang <[email protected]>
Commit-Queue: Lauren Commeignes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159381}
Import wpt@cc843db409973ba2ce2ce005d45aa3f24c9fde84
Using wpt-import in Chromium 6baefd34bdf77675a648cc84d749b9c27ebdacac.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/motion
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I318616f5d272d55f76368ef5a571402e3f18671c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621230
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159380}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687065625-6af2be353deb21ce73fa8d51786b9b4be039109c.profdata to chrome-win32-main-1687078120-68eebcd70e77e4d9366743df368c7dbe1b998026.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ida3f26aa486250de9b0850be282fbdcc3209ce96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624178
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159379}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687065625-90bd0e9518a381a26da83094c4aa683b3d02e159.profdata to chrome-win64-main-1687078120-b9dc601d698f3bc0cca14b0e5df88a1388c92532.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I5d997ad0c293fba89adf6c676684e2e47f229019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622662
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159378}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687075088-f759a1e727f5bb6905b55bd0a0fd3ee3547f57a6.profdata to chrome-mac-arm-main-1687081993-0e59de0ddb4beb9ccdc9b22c7fde599b837d48a2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I1d770a9b3da0d3549e64bda1eba063bdd08252aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624376
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159377}
Roll Projector App from GFOG2a2o6L8QKopeE... to zfE9bxid94ovhGhtS...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306180100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/zfE9bxid94ovhGhtS9pi4HNHCKTogU9lCq9WZNuAkSEC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ie65a8d6d87d73f2de4ee818e9234775af25e67bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624971
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159376}
Roll clank/internal/apps from 9daf7741a459 to b3f3770b9353 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/9daf7741a459..b3f3770b9353
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I29cea8f387f574b4397ed63f4cad491272623161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624973
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159375}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687065625-1f3e56a6174b59b66197e62cf0c68b228e30d55a.profdata to chrome-mac-arm-main-1687075088-f759a1e727f5bb6905b55bd0a0fd3ee3547f57a6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ibcad3d6a5165960d8ec6ddd2648446dccabd8dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624491
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159374}
[DevTools] Add count histograms for workspace files/folders.
Bug: chromium:1447968
Change-Id: I4c79d581fc4b9272842d59d70ea85798084ea1a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618253
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159373}
Roll ios_internal from 2b2e3e188f2c to 069b4f73b22d
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/2b2e3e188f2c..069b4f73b22d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I3e8694c860cee1c7fd82504c59b74e76eb2b9f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624665
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159372}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687056621-83fb926d7d5a103c7888e0deb40bdc416049ba8c.profdata to chrome-win32-main-1687065625-6af2be353deb21ce73fa8d51786b9b4be039109c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ic2fb3ce906f1ee597308917676bc363a66f72060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624663
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159371}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687056621-a4ad42721f260fd45654cf8e69b0a4495ce78202.profdata to chrome-win64-main-1687065625-90bd0e9518a381a26da83094c4aa683b3d02e159.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8c772bc49594156e8537ae928af0b5af80542aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624550
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159370}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687058838-62aee3d24f80319fb4232c1a6693ad81ef893ad2.profdata to chrome-mac-arm-main-1687065625-1f3e56a6174b59b66197e62cf0c68b228e30d55a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I4dc836caf85aaca4ab5894f7fca12e401c34eb7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624264
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159369}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1687046028-747c8a110b5d235445e2d9877dbd520b91ac9d13.profdata to chrome-mac-main-1687065625-244eb050f7578c3723b237c595af7b635def4894.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I86e6e1c420c3d05d68d251f11b566ce1e987a537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624549
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159368}
Roll devtools-internal from 63914c926d88 to f32eedda53b7 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/63914c926d88..f32eedda53b7
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30bb0dd02f7f7aec5e45ceafd054417b7db032a2..9d1c0c93522090f01d33f50531f61273878fbe5e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I34248134672617f1bed6a2344b0b940156f4733e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624662
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159367}
[Frameworks roll] Roll to 541327438 piper revision
Change-Id: Id8078be90227b6dd537ea574d87f4edb23c9b68a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4625007
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159366}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687046028-ee711bb2ab08434124ed0286c0f322d129497dff.profdata to chrome-win32-main-1687056621-83fb926d7d5a103c7888e0deb40bdc416049ba8c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I13e8380ceada5eda981b1597573c22ce793e71de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624403
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159365}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687046028-c77c84aa6088248ef5adb3d23bc1e20248be854e.profdata to chrome-win64-main-1687056621-a4ad42721f260fd45654cf8e69b0a4495ce78202.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I3c27c27c59bb7aef7eb3feea4cf36c21cd15927b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624947
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159364}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687051720-e5e26ff56bf39ab261d79f2e77adcfec7651d8a4.profdata to chrome-mac-arm-main-1687058838-62aee3d24f80319fb4232c1a6693ad81ef893ad2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I583354bf9c4ebd59b19ff64a92bf27ca7b4106ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624968
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159363}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687046028-63794f34aee874757c4e4c242654fada360b128f.profdata to chrome-mac-arm-main-1687051720-e5e26ff56bf39ab261d79f2e77adcfec7651d8a4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If4639ceb68bcd8909c96dc548fdcd65d8f631d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624402
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159362}
Roll clank/internal/apps from 21537322d94f to 9daf7741a459 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/21537322d94f..9daf7741a459
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I8c3c91468793dc4d451cd1bbb09ea12db573261a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624175
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159361}
Roll abseil_revision dc37a887fd..049aa40e7e
Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/dc37a887fd..049aa40e7e
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/dc37a887fd..049aa40e7e
Bug: 1123627
Change-Id: Ic52f42b8c0f622e0da4bff724fba9698c371ec06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621320
Reviewed-by: Danil Chapovalov <[email protected]>
Commit-Queue: Luc Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159360}
Updating trunk VERSION from 5839.0 to 5840.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I6a5f9729c713848ca0d53fd9a599eda7c9577012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624848
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159359}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687034333-ea344de9893148511c91ed82bf08d0e161f91fcb.profdata to chrome-win32-main-1687046028-ee711bb2ab08434124ed0286c0f322d129497dff.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Iac5f280d4dd9c11d5373b28510ce1e646acacd04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624701
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159358}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687038017-456959d145e14accb84c475be62672cadbf2c5b6.profdata to chrome-mac-arm-main-1687046028-63794f34aee874757c4e4c242654fada360b128f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Icdaf8315dddb6e1885550767cd1b30f7711bd8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623495
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159357}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1687024443-e71d0ed51862ad6106305522f4e28cc5d2cadbb4.profdata to chrome-mac-main-1687046028-747c8a110b5d235445e2d9877dbd520b91ac9d13.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ied6dafb61d93cf556ca7b60011011df0a48ef790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624887
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159356}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687034333-6dc5c319affeb9093718037a2464fa5689ed5954.profdata to chrome-win64-main-1687046028-c77c84aa6088248ef5adb3d23bc1e20248be854e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I3d261b7407983b6915c4d03e6721b402d783d840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623798
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159355}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1687001437-aecaef516fc28c6507632117f3319f1a40b1e0b3.profdata to chrome-chromeos-amd64-generic-main-1687046028-214e8252e188ac02af89e26cab08b57853fbc1e1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I6bb333ee51205ea51021fabc4ec5b409619d9659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624173
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159354}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1687024443-7fefae689702690717e72c52196fbed37f873754.profdata to chrome-linux-main-1687046028-5e19f6b54e530cf561006510c247e4dc40bb7143.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ib515a19711ffca93448084ca7157a89825f662b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624399
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159353}
Apply font-size-adjust to fallback fonts
Fallback fonts ignore font-size-adjust. That is because the primary
font's description is used to create fallback fonts. As a fallback font
can have different font metrics, we should adjust its size.
The subpixel rendering might affect the result on Windows. To make it
happy, we tweak the font size in font-size-adjust-012.html. With this
change, Windows gets a regression on font-size-adjust-010.html due to
unknown reasons. We will handle it in a separate ticket [1].
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1454612
Test: external/wpt/css/css-fonts/font-size-adjust-012.html
external/wpt/css/css-fonts/font-size-adjust-metrics-override.html
Bug: 451346
Change-Id: Iab8f14c21fdf501931e62e77e9059737722a050f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4305200
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: ChangSeok Oh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159352}
Roll Fuchsia SDK from 13.20230617.1.1 to 13.20230617.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I6ab17324e88974bd9de2470b23418c67c1a1172f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624515
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159351}
fix typo
Bug: N/A
Change-Id: I0edb7573c23797f6840763e083710b7b015a899b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622968
Commit-Queue: David Pennington <[email protected]>
Reviewed-by: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159350}
Use SiteInfo for RelatedActiveContents metrics
In crrev.com/c/4445209 we added some metrics detailing related active
contents to investigate the conditions of a page that is not bfcached
because of related active contents existence, but since it uses the
count of documents in each SiteInstance, it can't differentiate when
the documents are actually cross-site and can never be same origin
even after document.domain modification (i.e. they can never access
each other synchronously) but share the same SiteInstance (the default SiteInstance), which is possible on Android.
This CL make us use per-url-derived-SiteInfo document counts instead,
which will handle the default SiteInstance case, because it uses the
navigation's real UrlInfo instead of the SiteInstance's SiteInfo
which would be set to unisolated.invalid. This means documents that
can never be same origin (because their 'real' site URLs are
completely different from each other) won't be counted.
Bug: 1444759
Change-Id: I6bc460083256bbcede6d6177c08edee5fad2cb0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603703
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159349}
Roll Skia from f2a2171cdde4 to 85b4788bc3f1 (1 revision)
https://skia.googlesource.com/skia.git/+log/f2a2171cdde4..85b4788bc3f1
2023-06-17 [email protected] Roll SK Tool from 067b742c990a to b32ce543bca1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I00b3a6dfaf13cf4da3e10c07060a6e8e83a90adf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624170
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159348}
Only record RelatedActiveContents metrics when page was not bfcached
because of RelatedActiveContents
In crrev.com/c/4445209 we added some metrics detailing related active
contents to investigate the conditions of a page that is not bfcached
because of related active contents existence, but the metrics are
logged whenever a page is not restored from BFCache, even when there
are no related active contents. This makes it difficult to
differentiate cases where a page has no sync accessors because its
related active contents are all cross-site vs because there are no
related active contents at all.
This CL addresses the problem by only logging the metrics when one
of the reasons the page didn't get BFCached was due to the
existence of the related active contents. Note that there might be
other causes the page didn't get BFCached (e.g. usage of blocking
features on a page with openers).
This CL and also removes the AllSites version of the metrics as
it's not needed.
Bug: 1444759
Change-Id: I579f351fc1ec71d655110b077cd2406b65fd2db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604329
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Fergal Daly <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159347}
Roll Skia from c56f38d79fe0 to f2a2171cdde4 (1 revision)
https://skia.googlesource.com/skia.git/+log/c56f38d79fe0..f2a2171cdde4
2023-06-17 [email protected] Roll vulkan-deps from 1f524f69ec88 to 3b886d2fc60b (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I05608f202815fe069123f67af0bfaaf8022c7934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624396
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159346}
Roll src/third_party/libwebp/src/ fd7b5d484..6a319d4da (1 commit)
https://chromium.googlesource.com/webm/libwebp.git/+log/fd7b5d484644..6a319d4da395
$ git log fd7b5d484..6a319d4da --date=short --no-merges --format='%ad %ae %s'
2023-06-15 jzern vp8l_enc,WriteImage: add missing error check
Created with:
roll-dep src/third_party/libwebp/src
Bug: 1455619
Change-Id: Ic24b9496be532afeeeee2d0405434eb404938cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623807
Reviewed-by: Wan-Teh Chang <[email protected]>
Commit-Queue: James Zern <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159345}
Import wpt@b31eaacb964b5e159b841d9eb18aa12e1d37867a
Using wpt-import in Chromium bfdb235673d7c6cfd3899ff46ff26a70e70f91d5.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected]:
external/wpt/css/css-cascade
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I00de0709d430c5a4805a71267b75025f8fea36ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621713
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159344}
Roll androidx from XZJU4VJXbYB4soj_i... to Gb7vLkZsOy6VLPsYk...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: I88ce431487fc086c5d66259145f28b613e484a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623754
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159343}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687024443-b99bc9989062167ba479ec066203b8b4124e7fb3.profdata to chrome-win64-main-1687034333-6dc5c319affeb9093718037a2464fa5689ed5954.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I35b242316c382a96db052b348439f654e934efa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623752
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159342}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687013950-3281efcfe9a766a80054244313d603c3f3c854af.profdata to chrome-win32-main-1687034333-ea344de9893148511c91ed82bf08d0e161f91fcb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I3435364a970d76ae10943835792f060fdfbd1f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623493
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159341}
Updating XTBs based on .GRDs from branch main
Change-Id: I284d3c3e5959fcc663e8b07f2c4f4ff02524ce0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623868
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159340}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687031595-0c1ab83b4f596c3b5de44c7724915608ee08a88e.profdata to chrome-mac-arm-main-1687038017-456959d145e14accb84c475be62672cadbf2c5b6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ia59ea7c39423c62e8c8f634b4e76d549ca0ead8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624698
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159339}
Clarify fsmonitor instructions
This change removes references to git versions since Chromium developers
should be using git from depot_tools, and since it isn't completely
clear whether 2.39 is greater or lower than 2.8.
This change also makes it clear that fsmonitor should be enabled on a
per-repo basis rather than globally, for the best cost/benefit ratio.
This change was inspired by the realization that enabling fsmonitor
globally on Windows caused 179 fsmonitor process to be spawned when
"gclient sync" was run. These processes commit an average of 86 MB
on Windows leading to 15 GB of commit (only a few hundred MB of
physical memory is used, but the commit usage is large enough to
matter).
Change-Id: I21c042462022088e11883bbf827276ee585fdaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622567
Commit-Queue: Bruce Dawson <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159338}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686981563-e4b457c627e08b5877f8667a8b69e65bbd51e13d.profdata to chrome-mac-main-1687024443-e71d0ed51862ad6106305522f4e28cc5d2cadbb4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I108f14fa9905e9a038c0f887b666cea745bb5919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624509
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159337}
Roll ios_internal from d03485397eba to 2b2e3e188f2c
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/d03485397eba..2b2e3e188f2c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I8ef9de28ad1d36da1cd403a4d6fb867a16415f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624648
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159336}
Roll clank/internal/apps from ce6803b57f1d to 21537322d94f (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/ce6803b57f1d..21537322d94f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I7a27d57b0da3919853e63b66d11843927ad52a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624395
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159335}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687024443-01d4b4be81c081a085797280f83b12a22095005c.profdata to chrome-mac-arm-main-1687031595-0c1ab83b4f596c3b5de44c7724915608ee08a88e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie4585872bbdfc1916f2a78609a5abcddaba86dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624148
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159334}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687017216-343f6190ab37315a6f38139da0f7fde4a7f15d79.profdata to chrome-mac-arm-main-1687024443-01d4b4be81c081a085797280f83b12a22095005c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I7c0aba1ee54df37e512533d4656bb735ff174203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624356
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159333}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687013950-bbbcbd0fceac4a66410a2d7d0c9c16d669000d06.profdata to chrome-win64-main-1687024443-b99bc9989062167ba479ec066203b8b4124e7fb3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Ie54f2fafe8910ef1820af42252fd5b64587f8c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624355
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159332}
Add browser_tests, components_browsertests, interactive_ui_tests and sync_integration_tests to Win10 Tests x64.
This CL adds another integration test suites without field_trial_config. This will test the code path with the default behaviors.
Bug: 971387
Change-Id: Iec6ca1e22d1807069b40423056e1c937d9d3b9ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616016
Reviewed-by: Erik Staab <[email protected]>
Commit-Queue: Hao Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159331}
personalization: move time of day logic
Create a new function selectTimeOfDayWallpaper to coordinate
setting wallpaper and theme.
Bug: b:284023808
Test: browser_tests --gtest_filter=*WallpaperImages*
Change-Id: I6a7b9f3b8ed1c27b98e522640b9d98cac8192ae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616047
Reviewed-by: Erica Lee <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Reviewed-by: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159330}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1687001437-89ed9fff316592bfd18a2bd13e3f383a281c0263.profdata to chrome-linux-main-1687024443-7fefae689702690717e72c52196fbed37f873754.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I4df00650b7b2d4c8530065ef4c00a2f1f0be5a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624357
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159329}
[Frameworks roll] Roll to 541228236 piper revision
Change-Id: I9310bc2e2556f38608b7969b23a7ecd6695857e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624528
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159328}
Import wpt@6f296e42b3bd9dbd89d3472a175e448c97609215
Using wpt-import in Chromium 1e7ff79866e0a960652d7d656360f202b55217fd.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/motion
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: Ieb640e53f756e7a404c23145b433e72661411bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621974
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159327}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5838.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: If90d9f6b19dd0ceacf1a5f61d5012b3f9ba211ec
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622233
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159326}
Automated Commit: LKGM 15506.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778080388920392081
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: Ia5770da6b235d411783b008dfe20ba9ca70095fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621132
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159325}
Roll WebRTC from 11affddbbc7e to c929ab49b92a (2 revisions)
https://webrtc.googlesource.com/src.git/+log/11affddbbc7e..c929ab49b92a
2023-06-17 [email protected] Reland "[Stats] Remove enum-like structs in favor of strings."
2023-06-17 [email protected] Update WebRTC code version (2023-06-17T04:02:25).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: If3d84ef54bf842e1d82e3d4dfee518f034ab5fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624354
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159324}
Reland "[fuchsia] Remove use of ambient VMEX capabilities"
This is a reland of commit 32d1466c6def9112df62366e9d9872b282ba1f25,
after addressing security policy & routing issues up-stream.
- Remove job_policy_ambient_mark_vmo_exec from all component
manifests.
- Remove most usage of the ambient-VMEX-capable ELF test runner.
Some use of the ambient-VMEX ELF runner remains, to support tests
which run SwiftShader in-process, which requires ambient-VMEX for its
shader JIT.
The test CML fragment for the VMEX-capable ELF test runner is also
still required by out-of-tree dependencies, notably ANGLE.
Bug: 1290907, 1185811, 1022542
Cq-Include-Trybots: luci.chrome.try:fuchsia-smoke-astro,fuchsia-smoke-sherlock
Change-Id: I3c8265ed3ed4bd3b2bdca154c7bd81f0a5ef31c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4589192
Commit-Queue: Wez <[email protected]>
Owners-Override: Wez <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159323}
Fix join wifi dialog background color when jelly enabled
Currently, when open Join Wifi dialog from Quick Settings, the dialog
shows light jelly background. This CL changes to use the dark background
same as other WebUI dialog (e.g.:Bluetooth pairing dialog).
Screenshots:
previous: https://screenshot.googleplex.com/99M8BAytwMj98fa
now: https://screenshot.googleplex.com/APnfqR33P7ogByd
Bug: b/284338647
Change-Id: I79cb8e27f3d772be123ed7a1246d2914acb52c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622258
Reviewed-by: Wes Okuhara <[email protected]>
Commit-Queue: Jason Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159322}
Roll clank/internal/apps from 4b3a14144e9a to ce6803b57f1d (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/4b3a14144e9a..ce6803b57f1d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ieb05d405ffb29ed8d5a204b02a1ab719f7efd1f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623181
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159321}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1687001437-ea0d924716ce73e1d5bf599190ff635667da0163.profdata to chrome-win64-main-1687013950-bbbcbd0fceac4a66410a2d7d0c9c16d669000d06.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I21eca641367a2d5a5fdca56e84cb680f5cfe2335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624372
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159320}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1687001437-23c7fe2779e6bbd62b7dd8978154bbebd33563c6.profdata to chrome-win32-main-1687013950-3281efcfe9a766a80054244313d603c3f3c854af.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I053cc1f2e72a45b01d4a70bc5c76cbc80e5c0c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624488
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159319}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687010371-9e9f9aa2331820bece86bf24ba2f199235fa3a8e.profdata to chrome-mac-arm-main-1687017216-343f6190ab37315a6f38139da0f7fde4a7f15d79.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie2f512a4c3adf37911439a268d99b12c3f7989c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621383
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159318}
Roll Media App from rLMvnsUP0a_0FDf2r... to yFibtt0-XhS1PnnMv...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202306170800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/yFibtt0-XhS1PnnMvAcAzLW3QaXDexBkvWRDtolgHLcC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Iff40d94a921e171d782cf6a48feac08c71109ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624370
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159317}
Roll Help App from qiizk_233WcWsb4eZ... to yKFOHqw1zekWZTyc5...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202306170800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/yKFOHqw1zekWZTyc5sFguUhAvv9JN5za6Xcbm4maMxIC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I3048596c512c2f0329ab9830bfdeea64b9d2eea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621626
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159316}
Roll androidx from jGnMpftiaic_OF6i2... to XZJU4VJXbYB4soj_i...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: Ibaf58d9d73cdc9ff5647fcf12199028a5718e06f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624352
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159315}
Roll devtools-internal from e217857721d9 to 63914c926d88 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/e217857721d9..63914c926d88
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f97eacbc70bcf9aa2fb52ac28d02cd802232df8b..30bb0dd02f7f7aec5e45ceafd054417b7db032a2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I7bff1995a94ead9f6d3311154f5a93099c2bb415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622657
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159314}
Finish organizing Blink feature decls/defns.
Sort feature definitions by their identifier name, and group them with
their related constants (feature params, param names, et cetera).
Also finish regrouping some of the scattered constants in the features
header, to match the guidelines established in the .cc file.
Bug: 1455020
Change-Id: I3881027aaca884ff608ceb2c82214fb42ce94af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621962
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159313}
ChromeRefresh2023: Show separators in less cases.
only show separator in specific circumstances
Bug: 1399942
Change-Id: Iab729578af79778ec213cc621299ef19aef548f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602518
Commit-Queue: David Pennington <[email protected]>
Reviewed-by: Shibalik Mohapatra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159312}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1687001437-7581c6982db001be7445a9f402090e426f4b4bb6.profdata to chrome-mac-arm-main-1687010371-9e9f9aa2331820bece86bf24ba2f199235fa3a8e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I5d46bc3269e7d62e7f4b89caa54de48868b8ca60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624369
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159311}
Updating trunk VERSION from 5838.0 to 5839.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I3ee01a24a10cb9c98ccb291767c1f965821eb024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622509
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159310}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686981563-68983b63f31d6fd31624aefced5d1e075c2381ea.profdata to chrome-linux-main-1687001437-89ed9fff316592bfd18a2bd13e3f383a281c0263.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I82b25ffc871e2e4e89b3d0d42e23681d86a51352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624261
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159309}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686992111-72e9b22856275a8a85b31305687c0379f126ce91.profdata to chrome-win32-main-1687001437-23c7fe2779e6bbd62b7dd8978154bbebd33563c6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ia9bce18bdc15d38a893e23d74879822fc056849a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624259
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159308}
Automatic update from google3
Automatic update for 2023-06-17 UTC
Change-Id: I36f5bcb4f1721f420a0c1c4cd64ad02a3835fe55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621446
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159307}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686992111-7ecbc41b1dc91d2c046734cb6587458505c13ce5.profdata to chrome-win64-main-1687001437-ea0d924716ce73e1d5bf599190ff635667da0163.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8eefac3d1b39921f81ab4a3977cd9c60b9c4065a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621963
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159306}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686960218-e031efafcba89484e201e313940c1f663a0b77ec.profdata to chrome-chromeos-amd64-generic-main-1687001437-aecaef516fc28c6507632117f3319f1a40b1e0b3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: If0e2ecdbd5a6c3fe7a0651d74fb01bbb7cee025c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622098
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159305}
Automatic update from google3
Automatic update for 2023-06-17 UTC
Change-Id: I4fe25ed4f91fc7bcea36091dcd8246a4822dcb9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624387
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159304}
Roll clank/internal/apps from bd48630a5bad to 4b3a14144e9a (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/bd48630a5bad..4b3a14144e9a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I5429e75f20226894b1be8696de21939725cac639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624367
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159303}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686993893-6ccce40f5f61f7446e0999c41e6323e909726b3a.profdata to chrome-mac-arm-main-1687001437-7581c6982db001be7445a9f402090e426f4b4bb6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I88e61e887ce2cb2ce930e5abfd8795a7eaf0073c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624260
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159302}
Roll R8 from T4trA4OwFaP5g_IWG... to rByCj9NgDDYIIW97q...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: [email protected]
Change-Id: I4624f99c2bb8874eccc5ea5fd1be56a9b8e76177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621624
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159301}
Remove stale Blink expectations
Autogenerated CL from running:
//third_party/blink/tools/remove_stale_expectations.py --project chrome-unexpected-pass-data --no-include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --large-query-mode --num-samples 200 --jobs 2
Affected bugs for CL description:
[email protected]
Bug: 1088475, 1249176, 626703
Change-Id: I49798ee6f39604be7b5c3af2d135d230ad828008
Fixed: 1427282, 1444368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622656
Auto-Submit: chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159300}
Roll Skia from 2a9e11fd9d37 to c56f38d79fe0 (1 revision)
https://skia.googlesource.com/skia.git/+log/2a9e11fd9d37..c56f38d79fe0
2023-06-17 [email protected] Roll vulkan-deps from 8ca65cb391f4 to 1f524f69ec88 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I7f190399b5659284ce7094e128c9ed15d0258a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624167
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159299}
Roll Fuchsia SDK from 13.20230616.3.1 to 13.20230617.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I34532cbac7311f9d0d260a0119fe1d73047fade0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621622
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159298}
graphite: Add kGraphiteDawnGpuDiskCacheHandle for store shader cache
This new kGraphiteDawnGpuDiskCacheHandle is added for storing
compiled shaders from dawn used by grapghite for SkiaRenderer and
RasterDecoder. This CL only adds the cache handle and setup the
storage path, but it doesn't hook up to the graphite dawn instance
right now. It will be done in follow-up CLs.
Bug: 1454867
Change-Id: I626af5745078de8c22d216930e60d62ffd592320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618907
Commit-Queue: Peng Huang <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159297}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686981563-121b2744922829520df820a1bfa497873e2e1711.profdata to chrome-win32-main-1686992111-72e9b22856275a8a85b31305687c0379f126ce91.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I067a1c430847c558780587b0ef76844a04d6df0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623770
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159296}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686981563-aa5f1ad01b6c0f2ee70647d19d9289a603141797.profdata to chrome-win64-main-1686992111-7ecbc41b1dc91d2c046734cb6587458505c13ce5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I07295db2d040e530e11aadd5ca2b7c320147b891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621621
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159295}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686988756-6d2153006f9cb7eb0d7bf5cbca3c75dcafcd6ca5.profdata to chrome-mac-arm-main-1686993893-6ccce40f5f61f7446e0999c41e6323e909726b3a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8e6b8a7a1f8f933d39e36fdfcd9da827d8964840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623795
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159294}
Roll Projector App from S4PFqJJIa0tcPH4y4... to GFOG2a2o6L8QKopeE...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306170100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/GFOG2a2o6L8QKopeE8G3Md-GwAupGh7N59XoxNWyspgC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/287571506
Tbr: [email protected]
Change-Id: I58d30aec124a43d215313c616f3de6acb4d075da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621619
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159293}
Roll ios_internal from 9511541dce12 to d03485397eba
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/9511541dce12..d03485397eba
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I2834b1d1a577a4fc2bf2ad0e1faa36364e888c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4624147
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159292}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686970598-7c4c4ac3f7e188e8a3987598f0cd00f15a736a0a.profdata to chrome-win64-main-1686981563-aa5f1ad01b6c0f2ee70647d19d9289a603141797.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I71869ad05dcb18070107e3a440fad83760de8ea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623749
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159291}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686981563-765dd38dc7ba2611e5d8db790761aa9d97e282ee.profdata to chrome-mac-arm-main-1686988756-6d2153006f9cb7eb0d7bf5cbca3c75dcafcd6ca5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I1023d6022fe3dd2e20f59648976fdc051ad68067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621620
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159290}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686970598-2a2bf8f31162cda3a40a5b3166b0bc59c00ade37.profdata to chrome-win32-main-1686981563-121b2744922829520df820a1bfa497873e2e1711.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Id074685a424c01c57f271b1b41c4e71075de05d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621380
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159289}
Roll androidx from zJLxZx9tZxONNreiJ... to jGnMpftiaic_OF6i2...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: I4ef27a7b5a1becf533e338fe85e1d477f52921ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623117
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159288}
Roll devtools-internal from c90a0240ebb2 to e217857721d9 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/c90a0240ebb2..e217857721d9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ib0d6925ee8c497bc514b3d8fbd08e267482a448d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622065
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159287}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686973872-91abc679947626e336b419e2729e126fd405b66c.profdata to chrome-mac-arm-main-1686981563-765dd38dc7ba2611e5d8db790761aa9d97e282ee.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Iec357a5a29c948ff7b2e28f3222861c8c59f9eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623174
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159286}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686959921-c83405f75f1ec90b607efca2f9d11bbad77a6711.profdata to chrome-mac-main-1686981563-e4b457c627e08b5877f8667a8b69e65bbd51e13d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I0a8ba8ff4f7df016dcc467c8e95651054d292645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623116
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159285}
Automated Commit: LKGM 15505.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778127002620921665
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: I8063f6d3eb450be969c809910ccbf0f5bbaaf442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622328
Bot-Commit: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159284}
Bluetooth: Floss: Wire ARC's OnServiceChanged
The OnServiceChanged isn't called when we're done updating a service,
but rather when we need to do a rediscovery because the peer updates
something.
Bug: b:284429795
Test: Pass ARC-T CTSV Bluetooth LE Insecure Client Test
Change-Id: Ide4c77a86fcb40d24ccbe41889c2839bc62e2a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617795
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Archie Pusaka <[email protected]>
Reviewed-by: Gordon Seto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159283}
[Frameworks roll] Roll to 541122161 piper revision
Change-Id: Ic3fb1d5a45b3ee3939bc99f33e7bfa919b914867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623090
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159282}
Roll clank/internal/apps from 0e065e77ae12 to bd48630a5bad (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/0e065e77ae12..bd48630a5bad
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Icfcd1175d26e794ea77a5728a8ec3a5bf75bf92b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623790
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159281}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686959921-831a922dead982a6edb575dbe4d1ff45b55fec1d.profdata to chrome-linux-main-1686981563-68983b63f31d6fd31624aefced5d1e075c2381ea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I1f85a559cb423e201c23fbc382af57608cb58756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622063
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159280}
Roll devtools-internal from 28a4e9848422 to c90a0240ebb2 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/28a4e9848422..c90a0240ebb2
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/13847ed879863874653ce1c1f9d0109bef3d3a42..f97eacbc70bcf9aa2fb52ac28d02cd802232df8b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I9e888823b3a4cd0c5194979fe94e8977eea77db9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621379
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159279}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5837.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I1a8789522b0e565827dee693993e3d7723bea82c
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621131
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159278}
[CR2023] Update some download bubble colors
Also update primary and secondary label colors per spec.
Bug: 1422125
Change-Id: I0c10bffe7e7106d69f7a0e32e8218aa2f0b17cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610271
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159277}
Roll ChromeOS Arm Experimental AFDO profile from 115-5735.31-1684754263-benchmark-115.0.5788.0-r1 to 116-5804.0-1686565729-benchmark-116.0.5833.0-r2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I767c46d6f3d09b0c524b2695a2c032b473bd59fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621741
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159276}
Roll Skia from dc11c7ddb33f to 2a9e11fd9d37 (1 revision)
https://skia.googlesource.com/skia.git/+log/dc11c7ddb33f..2a9e11fd9d37
2023-06-17 [email protected] Roll SK Tool from d044984a01de to 067b742c990a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: If14d7f3a477008fa1920fd2691885513325e6c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621344
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159275}
Roll ChromeOS Arm AFDO profile from 115-5735.31-1684756456-benchmark-115.0.5788.0-r1 to 116-5790.18-1686571085-benchmark-116.0.5833.0-r2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id6397ebac91540b7ce24fc05819395dcb670970c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623489
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159274}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686959921-563d015ebf1985a7d3a68511b176e435e66d14a3.profdata to chrome-win32-main-1686970598-2a2bf8f31162cda3a40a5b3166b0bc59c00ade37.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I8c1c71ff2e680aa716b70913901f87643d577359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622419
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159273}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686959921-7080825c5e1cd045682e2c867a1ec0a258e27a52.profdata to chrome-win64-main-1686970598-7c4c4ac3f7e188e8a3987598f0cd00f15a736a0a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I3838ddbd2dfc49ffc192a574a11697d444d9fe49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621444
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159272}
Roll PDFium from 7b044178db44 to f608b5d3a9a9 (12 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/7b044178db44..f608b5d3a9a9
2023-06-17 [email protected] Don't implement CPDF_DIB::GetBuffer()
2023-06-16 [email protected] Remove redundant MSVC 4267 warning
2023-06-15 [email protected] Add a pixel test for a trailer with the wrong /Size
2023-06-15 [email protected] Tolerate bad /Size in V5 xrefs
2023-06-15 [email protected] Give CPDF_CrossRefTable::ShrinkObjectMap() a better name
2023-06-15 [email protected] [Skia] Handle text scaling inside CFX_SkiaDeviceDriver
2023-06-15 [email protected] Update the constant used to limit xref size
2023-06-15 [email protected] Add a ParserXRefTest test for wrong /Size relative to /Index
2023-06-15 [email protected] Add more ParserXRefTest test cases for /Index
2023-06-15 [email protected] Add more ParserXRefTest test cases
2023-06-15 [email protected] Change ParserXRefTest to use Gmock matchers
2023-06-15 [email protected] Change some ParserTest to use a test fixture
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1288804
Tbr: [email protected]
Change-Id: I8ccf34fb0ce92179703682748ae94660bf653978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623767
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159271}
Roll androidx from MqkmMx1Ct4Fk2Vb_F... to zJLxZx9tZxONNreiJ...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: Ic22801f41f8f6f3a8f17c110c5364b74ad89c94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623167
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159270}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686967171-f97fff372f53dd58302154911ec8721d6a445b28.profdata to chrome-mac-arm-main-1686973872-91abc679947626e336b419e2729e126fd405b66c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I524e22bee35d72d61206a4541e0458f37bc42266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622004
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159269}
[CR2023] Fix MdTextButtonTest.BackgroundColorChangesWithWidgetActivation
Bug: 1455122
Change-Id: I8e88184fba648e47f48e9764b4280edba4d7332f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619851
Code-Coverage: Findit <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159268}
Roll ANGLE from e394cb46c18c to 24f4007b93e0 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/e394cb46c18c..24f4007b93e0
2023-06-17 [email protected] Vulkan: Use SPIR-V ids instead of names in the transformer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I67d69c8e21df52ddb035a2feba237a5c6ff31d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622418
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159267}
Web Share Target: ChromeOS: Pass StringPiece by value
StringPiece doesn't have any internal storage and is designed to be
passed by-value.
Reference: crrev.com/c/4611094/comment/6d137cf7_fa3b6312/
Bug: None
Change-Id: I06f0f95af371f8bf1ade795ddb92bf6476d15b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623031
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Alan Cutter <[email protected]>
Auto-Submit: Solomon Kinard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159266}
Roll R8 from k5TJLb8-vIKBO1aZT... to T4trA4OwFaP5g_IWG...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: [email protected]
Change-Id: Icd5a3786037cd860118ef0eaf4509cdf78a7f14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621918
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159265}
Roll clank/internal/apps from 40e600c2e3b2 to 0e065e77ae12 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/40e600c2e3b2..0e065e77ae12
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1453664
Tbr:
No-Try: true
Change-Id: Ie4bbf8e71acf63ea316bb7678284567111be7458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621498
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159264}
Import wpt@4203f37b7415c420aa495d315339e8e5b51b8288
Using wpt-import in Chromium b0087338f414f928e330b9b24906c1a2a820d722.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I2fefa5752013f3c0c395a96147a1fe5985dc89f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623307
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159263}
Reenabled ExoLinuxDmaBufModifiers but with an blocklist
Gen12 devices like Redrix will now default to I915_FORMAT_MOD_Y_TILED
Smoke test here should ensure that we catch leaks like this before
they happen:
https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/4550900
Original issue: 1445252
Bug: 1450939, 1450103
Change-Id: I806daa6b5a0a557c5c580a378d3dcc79ad7aca81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585170
Commit-Queue: Peter McNeeley <[email protected]>
Reviewed-by: Kramer Ge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159262}
Allow button to have writing mode vertical
This CL allows <button> and <input> types "button", "submit", "reset",
"file" to have writing-mode vertical for both the default native
appearance and when appearance is set to none.
We also put the change behind the feature flag
FormControlsVerticalWritingModeSupport so it can be turned on safely.
Change-Id: I1f6cc53a1eaef640e3d968d0e7ec5fc248879b50
Bug: 681917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617874
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159261}
Remove remainings of offline_pages/prefetch code.
Bug: 1424920
Change-Id: I328b5fc12fff7d166a552e3cf9de2bbe630f1c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617809
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Dan H <[email protected]>
Commit-Queue: Shubham Gupta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159260}
Roll src/chromeos/assistant/internal/ ecafc1ad7..d25ca4d82 (1 commit)
https://chrome-internal.googlesource.com/chrome/assistant.git/+log/ecafc1ad7b48..d25ca4d82ba1
$ git log ecafc1ad7..d25ca4d82 --date=short --no-merges --format='%ad %ae %s'
2023-06-17 wutao libassistant-v2: Uprev libassistant.so
Created with:
roll-dep src/chromeos/assistant/internal
Bug: b:287533139
Test: DUT and gLinux
Change-Id: Ic4d1b704ce3274bdb0a6df33c16aac2288af5028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621891
Reviewed-by: Yuki Awano <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159259}
CCA: Remove redundant jsdoc annotations
This CL removes redundant @param or @return jsdoc annotations under
ash/webui/camera_app_ui/resources/js/device/. They can be inferred from
their value types or function names.
Bug: b:273315158
Test: $ cca.py lint
Change-Id: Ibf2e2e8303ff03a12abc6238d02f8a394825d517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619769
Commit-Queue: Dorah Kim <[email protected]>
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159258}
Add starvation test for StatisticsRecorder
Bug: 1123627
Change-Id: I01c4dd78eff7fdabbcfc474f7ba8ec975686cdbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591173
Commit-Queue: Luc Nguyen <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159257}
[exo] Fix 'mask filter info' comparison @AppendOrCreateSharedQuadState()
BUG=None
[email protected]
Change-Id: I8f84e6e5159c7e310c46259e6c64291566c0e429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621595
Auto-Submit: Antonio Gomes <[email protected]>
Reviewed-by: Peter McNeeley <[email protected]>
Commit-Queue: Peter McNeeley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159256}
Roll clank/internal/apps from f04b386306a5 to 40e600c2e3b2 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/f04b386306a5..40e600c2e3b2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1130617,chromium:1141179
Tbr:
No-Try: true
Change-Id: Ib23adc26234c3c7e0070354e46d6c5a9ded1eea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621346
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159255}
Roll Catapult from 32db29fcb8ad to cef5cf05b241 (3 revisions)
https://chromium.googlesource.com/catapult.git/+log/32db29fcb8ad..cef5cf05b241
2023-06-16 [email protected] Change build retention.
2023-06-16 [email protected] Remove suffixes support from run_py_tests
2023-06-16 [email protected] [Sandwich] define regression detected criterion
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1419903
Tbr: [email protected]
Change-Id: I4a72e6c7bad76c2a5c8b1336e7a0c3a6286467b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622002
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159254}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686959921-3ab8abaebe7b22de2c709b48fbc7f8d6d6975b1b.profdata to chrome-mac-arm-main-1686967171-f97fff372f53dd58302154911ec8721d6a445b28.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If5aeb267279ebb6bfd66a7fb15b33e0942474488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621486
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159253}
Make histogram descriptions for ARC app install metrics more readable
Bug: b:266456348
Change-Id: I0e1c656e45796e77e4f98965a5707665e25689f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621737
Reviewed-by: Muhammad Hasan Khan <[email protected]>
Auto-Submit: Luzanne Batoon <[email protected]>
Commit-Queue: Muhammad Hasan Khan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159252}
Android: Ignore android.* in tracereferences checks
THe allows prebuilts to reference Android U SDK APIs while we still
target Android T.
Bug: 1455158
Change-Id: Ic1ba96db3096ada778a27609acf085f39ed710e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623016
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Auto-Submit: Andrew Grieve <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159251}
Updating trunk VERSION from 5837.0 to 5838.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I0faae310b0dc6dafca57f9b64e0fdd01a83dc6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621130
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159250}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686949174-e602e0dc9b36bd5b98cd21e44b5c81386f373c31.profdata to chrome-win64-main-1686959921-7080825c5e1cd045682e2c867a1ec0a258e27a52.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Ibca3c0045af20da260fdd585693ecebfd3df8fce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621105
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159249}
updating ToT to enable FastPathPaintPropertyUpdates by default
Bug: 1347264
Change-Id: I708193fa46d309bb247e9843ed41ec3221d0e6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616682
Commit-Queue: Yotam Hacohen <[email protected]>
Reviewed-by: Yotam Hacohen <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159248}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686949174-7f8f4a03608d6b79ff05518581e511b3ffdb24cc.profdata to chrome-win32-main-1686959921-563d015ebf1985a7d3a68511b176e435e66d14a3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I633a5c8aaf6e8917293bb116fa05c7bdcdb71563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621915
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159247}
Roll Skia from 3e3cdb378f5d to dc11c7ddb33f (16 revisions)
https://skia.googlesource.com/skia.git/+log/3e3cdb378f5d..dc11c7ddb33f
2023-06-16 [email protected] Fix some outdated comments.
2023-06-16 [email protected] Stop suppressing divide-by-zero errors in SkScalarInvert
2023-06-16 [email protected] Move SkPoint to base
2023-06-16 [email protected] Roll vulkan-deps from 58c6e1ea988a to 8ca65cb391f4 (6 revisions)
2023-06-16 [email protected] Factor apart Program::dump into a helper class.
2023-06-16 [email protected] Use float for SkPoint's coordinates
2023-06-16 [email protected] Convert rest of affected GMs and tests over to new tiled image API
2023-06-16 [email protected] Move tiling utility methods to shareable location
2023-06-16 [email protected] Fix return type of Benchmark::getSize
2023-06-16 [email protected] [graphite] Add onCopyTextureToTexture for the Vulkan backend.
2023-06-16 [email protected] Fix incorrect filename for WGSL ClampUInt
2023-06-16 [email protected] Add Type::slotType(n).
2023-06-16 [email protected] Add WGSL support for common-function intrinsics.
2023-06-16 [email protected] track Color and Opacity slots through new SlotManager
2023-06-16 [email protected] [gm] Make GPU backend dependency conditional on SK_GANESH constant.
2023-06-16 [email protected] [graphite] Set Vulkan viewport and scissor
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I62ecde52a1339759bb44f32270a87a3bf66972e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621164
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159246}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686938378-6b221e60f898021c43a0a477ad2447583e4ef0a7.profdata to chrome-linux-main-1686959921-831a922dead982a6edb575dbe4d1ff45b55fec1d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I4b82f8593552b2ed3e6d67db802195d43281fa49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621342
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159245}
Roll ANGLE from 498c744bc7a1 to e394cb46c18c (7 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/498c744bc7a1..e394cb46c18c
2023-06-16 [email protected] Vulkan: Refactor framebuffer fetch shader emulation
2023-06-16 [email protected] Android: Add Pixel 7 entries to End2End expectations
2023-06-16 [email protected] Remove _shardN suffix from tests when it's not necessary.
2023-06-16 [email protected] Turn CreateMTLRenderPipelineDescriptor into a method
2023-06-16 [email protected] Metal: Remove copy constructors in various util classes
2023-06-16 [email protected] Record duration of syncFromNativeContext()
2023-06-16 [email protected] Roll VK-GL-CTS from f7646f53ba61 to 7fcb3c6e0082 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1168587,chromium:1329376
Tbr: [email protected]
Change-Id: Ibd18c2ec35e572d7050617f4a566237a3a1e9003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621731
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159244}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686938378-08d5d8fbfa14e9b8ba150bee665479a731e84e6b.profdata to chrome-mac-main-1686959921-c83405f75f1ec90b607efca2f9d11bbad77a6711.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib14b7d0af53e7e832d64158dffaaeda57ddbef4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622060
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159243}
ChromeRefresh2023: Add Separator Margins for correct positions of tabs
Separators need to be able to position their bounds differently between
the 2 tab styles. This CL adds an Inset value that can be overridden to
properly set the position of the bounds. The TabOverlap also needed to
be updated in order to give the correct spacing between tabs to include
the new margins.
Bug: 1399942
Change-Id: I7b79bb0a1de339c8b276ead7f215f9f54c30c0a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602153
Code-Coverage: Findit <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Commit-Queue: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159242}
WebNN: Implement CommandRecorder::ExecuteOperator() for DML backend
This CL implements `CommandRecorder::ExecuteOperator()` that executes a
compiled DirectML operator on the GPU with input and output resources
bindings. The caller should call `InitializeOperator()` for this
operator before its execution. If the operator execution requires any
persistent resources, they should also be initialized before and
supplied when calling this method.
This CL extends the operator initialization unit tests so that they can
also test execution of Relu and Convolution operators and verify the
computation result.
This CL adds another ExecuteReluOperatorForMultipleBindings test case
that ensures the operator execution can be dispatched multiple times
with different bindings before waiting for the GPU work to complete.
This test case emulates the scenario that JavaScript code may call
MLGraph compute method without waiting for the promise of the previous
compute to be resolved.
Bug: 1273291
Change-Id: Id57e63d5e9eff888d6929b905c661f0594f39909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607584
Reviewed-by: Rafael Cintron <[email protected]>
Commit-Queue: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159241}
Adding mojom IPC for visual search.
Adding mojom integration for visual search. The classifier host will communicate with a classifier agent in the renderer to perform visual classification. For more context, see the two CLs below:
https://chromium-review.googlesource.com/c/chromium/src/+/4609970
https://chromium-review.googlesource.com/c/chromium/src/+/4615458
Bug: b/284648407
Change-Id: Ic9dd8d5fb4499aad34bcf253bb40e0f560793c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617709
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Pierre St Juste <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159240}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686916746-c5ce1cf7a3b233e2225a4be30a7d5105e3097803.profdata to chrome-chromeos-amd64-generic-main-1686960218-e031efafcba89484e201e313940c1f663a0b77ec.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I97764ee6100e7e3e61e8dda628f5bd6f7a2a05b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621959
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159239}
[iOS] Disable Password Bottom Sheet if there's no username
If the currently selected row has no username, the bottom sheet
will disable itself on exit to allow the user to open the keyboard
to fill in the username field.
Bug: 1450889
Change-Id: I67cebd32a9487312ba53039ff07ef0e8145c61f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616133
Commit-Queue: Alexis Hétu <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159238}
Close other <details> elements linked by name attribute in tree order.
When <details> elements are linked by their common name attribute values
into an exclusive accordion, and one member of the group is closed, this
closes the linked <details> elements in tree order rather than insertion
order. This reverts much of 34b2758acd53c3ab7ff32bf418334792ad13e523.
The code is simpler but slower, and it matches typical web platform
patterns more closely (even if those patterns may not be ideal in this
case).
This change is based on discussion in
https://github.com/whatwg/html/pull/9400/files#r1221692104
This change also stops treating the empty string as a valid name, and
adds a test to match. This matches the above HTML PR.
Bug: 1444057
Change-Id: I5eed9e25ff7698e23738e53445c64c0fc3a1b035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617028
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159237}
Tweak BrowserNonClientFrameViewChromeOS test
Set UseSystemTheme() to false in the test so it actually tests behavior
that uses the manifest when Jelly is enabled.
Bug: b:287683467
Change-Id: I92d5983873bdadf51e3a407504e726c9feb84f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622911
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159236}
Migrate mac-launcher to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I587327443275927b4ff979cd093f90c0662a1969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623015
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159235}
Roll Fuchsia SDK from 13.20230615.3.1 to 13.20230616.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I9b2458f6072545cbe8b688121c15e22038fc8405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621101
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159234}
Make kFileReading queue not a subject to virtual time pausing
Bug: 1455267
Change-Id: Icbd3de052685185a6de727885b380eb3ed096a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619367
Commit-Queue: Andrey Kosyakov <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159233}
Migrate android-device-launcher to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I34904e4e985504804812096461be187ff47c0cf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623014
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159232}
Migrate Simple Chrome Builder reclient staging untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I0ebd1d6db3dd1d7343198f449f06c7c6f88f5405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623013
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159231}
Migrate Linux Builder reclient test (unified uploads) untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I11c6b2fddb77968b5a0bda3b5fd6934a3e4e35f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621893
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159230}
[Telemetry] Add Touchpad Event Implementation in extension
This adds an implementation for detecting touchpad events using
Telemetry Extension on the extension side.
This is part of a bigger effort to add an event interface
to the Telemetry Extension. For more context visit
go/design-sketch-event-api.
Bug: b/279127802, b/268125453
Test: 1. unit_tests --gtest_filter="*Telemetry*Event*"
2. extensions_unittests --gtest_filter="*TelemetryExtension*"
3. browser_tests --gtest_filter="*TelemetryExtensionEventsApi*"
Change-Id: Ia7820b5ec3ddfde34d9dddcd2c9bf29d2bd91586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4551485
Commit-Queue: Ethan Cheng <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Reviewed-by: Bastian Kersting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159229}
CrOS Settings: Decouple page visibility from os-settings-section
Create a new element page-displayer which is solely responsible for
displaying/hiding a specific page. This removes the coupling of page
visibility logic from os-settings-section, effectively simplifying page
display logic in subsequent refactors.
When the OsSettingsRevampWayfinding feature flag enabled:
page-displayer will only show the active page.
When the OsSettingsRevampWayfinding feature flag is disabled:
page-displayer element is scrolled to and all page-displayers are shown.
Bug: b/286429941
Test: browser_tests --gtest_filter="OSSettingsMainPageContainer*"
Test: browser_tests --gtest_filter="OSSettingsOsSettingsUi*"
Change-Id: I3564aeb403ef391ffb95f6c4ada17a69c2d7b374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612367
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159228}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686952636-b42209146957355f2fe8215d621c165c4277e71a.profdata to chrome-mac-arm-main-1686959921-3ab8abaebe7b22de2c709b48fbc7f8d6d6975b1b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I58a616ab248e8b3bfc669706e6ec4cb3a5dcdce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623168
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159227}
Roll Arm AFDO from 115.0.5790.0_rc-r1-merged to 116.0.5833.0_rc-r2-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Iac8d83f8f61ed758823c522deae92024e7e8cbc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623113
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159226}
Migrate Simple Chrome Builder reclient test untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I60ade603c94478219a6150f058160782299f313e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623029
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159225}
Migrate Simple Chrome Builder reclient test to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I6b23bd6d4870b45d7d3c23b01f9c5f1ad935af80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621892
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159224}
Migrate Linux Builder reclient staging to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I83eeef696dc34111f58ff1b08602c96f8b0e5ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623028
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159223}
[omnibox] Nest feature declarations inside feature configs.
Follow up to crrev.com/c/4568562
No behavior change, just helps readability.
Before, we encapsulated all the feature params and helpers inside config
struct, EXCEPT for `base::Feature` declarations. Those were defined
above and outside the struct. This made it harder to see at a glance
where 1 feature ended and the next began.
This CL moves the feature declarations inside the structs as well.
Change-Id: Id1f74a8de7595a3d90949688ffebfebc289545f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621857
Auto-Submit: manuk hovanesian <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159222}
Migrate Linux Builder Goma RBE Canary to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I5c08a76f0b678ad0ec6870eb3d4d5b32b8b133e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621890
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159221}
Migrate android-archive-dbg-goma-rbe-canary to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I2919b451b2a0941dbde10618f12ea3f67fd27207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623011
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159220}
Migrate Android ASAN (dbg) (reclient) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Id2e733eceb59a8e246d284c39b97f9ff479447d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623010
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159219}
Import wpt@4de902c54fdcf32c10faec3dc6280eb72f45e613
Using wpt-import in Chromium fa707c850bf30a1f11022b5ad530819eb7f3c3aa.
With Chromium commits locally applied on WPT:
8e5f19c5be "Add the ability to disconnect DOM Parts"
b256cdaa6e "[scroll-start] Apply scroll-start after layout"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/editing
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: Ie38198f6faee9c63147d215936a462d656bd93dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622290
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159218}
Media Controls: Fix tab order in overflow menu
This CL fixes the overflow menu on media elements to start with focus
on the topmost element instead of the bottommost element. This also
refactors the associated methods (SelectFirstItem, SelectNextItem, and
SelectPreviousItem) to make sense when considering the topmost element
as the "first" element.
Bug: 1448886
Change-Id: I105a5b5da8788c2e552c29152bf912affe19b83c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621159
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159217}
Migrate android-cronet-arm-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ic0543d2beed0e669349cb72e5c3dd75491cb2c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623009
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159216}
[lacros skew tests] Refresh skew tests for M115
This CL updates the ash version ['115.0.5790.33'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I0f09eb4434db958a9fc5c2c7d5d54c6e97d330cd
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622508
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159215}
Migrate android-pie-arm64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I94fac6dd89364ec1e3f75d48b06adfa810b5e516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623027
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159214}
Migrate Win11 Tests x64 to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ibd22d8f88474f9d0452c171765cbca11ae4a835b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4623007
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159213}
CrOS Settings: Clearing pref when UMA consent is revoked.
Clearing the kTotalUniqueOsSettingsChanged pref when the user has
revoked consent for UMA. We will not store the unique Settings, and we
will not record data to the histograms.
If the user grants consent for UMA, we will keep the state that the user
has revoked consent before and we will not record their data in the
histogram
ChromeOS.Settings.NumUniqueSettingsChanged.DeviceLifetime.{time}.
We will not record the data again once the user has granted consent
to increase the accuracy of the data that we are recording.
dd: go/cros-settings-revamp-metrics-design-doc
NOTE: This CL will have a follow-up that will convert the
unittests per_session_settings_user_action_tracker_unittest.cc and
settings_user_action_tracker_unittest.cc to browser tests. They need
to get converted as we are now using g_browser_process in
PerSessionSettingsUserActionTracker which can only be tested using
browser tests.
Bug= b/285021579
TEST=
Manual:
All tests must be taken with a user that has run OOBE.
Histograms:
ChromeOS.Settings.NumUniqueSettingsChanged.DeviceLifetime.{time}
{time} = one of {FirstWeek, SubsequentWeeks, Total}
{time} is based on the time passed since the user has taken
OOBE, .FirstWeek and .SubsequentWeeks. The total of first and
subsequent weeks will be recorded in .Total histogram.
A) Open Settings, grant UMA consent. Histogram will record
the data if any.
B) Open Settings, revoke UMA consent. Histogram will no
longer record the data, until the user grants UMA consent again.
C) Open Settings, grant UMA consent again. Case B will repeat again
since we will not record data if the user has revoked their consent at
least once in the lifetime of the device.
Automated: Unittest: DISPLAY=:20 out/Default/unit_tests
--gtest_filter="*SettingsUserActionTrackerTest*"
Change-Id: Ie973044ab375082d2e5272da4ce26b6f858ae08d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574214
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Nikki Moteva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159212}
Migrate android-x86-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I9d9b50b257d11a194087527adc0241c83f65b13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622910
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159211}
Fix jelly login screen for OOBE
Apparently there's an OOBE state when the session is LOGIN_PRIMARY.
OnWallpaperChanged should send the default seed in that state.
https://screenshot.googleplex.com/BjbRMnb56RLBZDi
https://screenshot.googleplex.com/65wagLGHiZcUH5J
BUG=b:276475812
TEST=ash_unittests *ColorPaletteController*
Change-Id: I9601b2a613635106eb5062db33ab29801a993ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622594
Commit-Queue: Erica Lee <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159210}
Migrate mac13-x64-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I4d282b03de43eac93018cceb7f8b55ce7d59f29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622698
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159209}
Bookmarks++: Fix drag flakiness
Addresses an issue where attempting to drag a bookmark by clicking
anywhere but the row of the title didn't work on the first attempt.
Bug: 1453825
Change-Id: Icf9970abf7851949ac9324ce08d150f2e0b5640b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621639
Auto-Submit: Emily Shack <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159208}
[color] Add prefs for user_color and is_grayscale to ThemeService
These prefs will be used to allow users to configure the user_color
and is_grayscale theme settings for ChromeRefresh2023.
Bug: 1448246, 1444957
Change-Id: I8fd8956397d2dc0297ef811a792827bf436aa1ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621970
Reviewed-by: Peter Kotwicz <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159207}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686895138-21cc5c15c8ced578a0a7662848c34ed22f64914c.profdata to chrome-mac-main-1686938378-08d5d8fbfa14e9b8ba150bee665479a731e84e6b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ic5f7c98969cae50d5a48102297dfc8d7b03f210d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621993
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159206}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686938378-2b031e88c379891d9f63e2b6d5ecb3a07744bbcf.profdata to chrome-win64-main-1686949174-e602e0dc9b36bd5b98cd21e44b5c81386f373c31.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8570df4bbef7bd1acb4cba8ff0004dba5c564a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621656
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159205}
Increase mac-official timeout
The builder started to timeout at compiling recently
Bug: 1454752
Change-Id: Idca228a22c1469824d0d47a6b076387942e9844e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618029
Commit-Queue: Lindsay Pasricha <[email protected]>
Reviewed-by: Lindsay Pasricha <[email protected]>
Reviewed-by: Sven Zheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159204}
[PasswordManager] Disabling flaky test ShowAddShortcutDialog
Bug: 1455574
Change-Id: I6e0005ef97fe60e469e530362169d678c0a19c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622690
Commit-Queue: Reilly Grant <[email protected]>
Owners-Override: Reilly Grant <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159203}
Migrate linux-rust-x64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ied0fb9bbc80eea92fbb5c8b1fb3b7bf10fb42991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622695
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159202}
[keyboard-alt]: Group keys under Modifier/Other sections
Screenshot: http://screen/6rhpREWBMiNWozi
Bug: b/279503977
Change-Id: I24c0960632733a36e59ac1b0d5ee6100d9735505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583639
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Michael Checo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159201}
Roll Open Screen from bfbfda8fd7e3 to 2a4dbe656f38 (2 revisions)
https://chromium.googlesource.com/openscreen.git/+log/bfbfda8fd7e3..2a4dbe656f38
2023-06-16 [email protected] [Infra] Fix local compilation by fixing variable order issue
2023-06-16 [email protected] [OpenScreen] Replace TaskRunner* with TaskRunner& in platform/ directory
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I8abc3b4f9d7ef89cea54ac07c82820c7fab28390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621533
Reviewed-by: Jordan Bayles <[email protected]>
Commit-Queue: Mark Foltz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159200}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686938378-677e23f517741a29bfb2efd7409c0dbe4942cccf.profdata to chrome-win32-main-1686949174-7f8f4a03608d6b79ff05518581e511b3ffdb24cc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I4d9a6ce75f108ade4bc9f52bb6940bd27ebbbc19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621400
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159199}
Migrate linux-exp-tsan-fyi-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia989426b4b0b00425561d541faa5c5a1dae11198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622907
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159198}
[Tailored security] Store ref to window when sending scoped message
The TailoredSecurityConsentedModalAndroid class enqueues a window scoped
message, but was keeping a reference to a WebContents in a callback.
There were cases where the WebContents can be destroyed before the
message is cleared from the message queue. When this would happen,
Chrome would crash if the user was later shown the message and the user
would click settings (which would run the callback).
This change addresses the problem by keeping a reference to the window
that the message is scoped to and adding APIs that support being passed
a window. The lifetime of the window will exceed the lifetime of the
message, so the callback should now be able to run without crashing.
Change-Id: I81f1174edd08c537054fbd29134d4c0d7a108613
Bug: 1445443
Low-Coverage-Reason: consented_message_android.cc is covered, but android native tests aren't reported by the low-coverage-check tool.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617345
Reviewed-by: Mustafa Emre Acer <[email protected]>
Commit-Queue: Javier Castro <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159197}
Migrate win10-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I47474050db888fec33dfe119ee07c278fc1631ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621113
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159196}
[omnibox] Remove explicit int values from `LineState`.
No behavior change, just a refactor in preparation for a larger future
CL.
Removes the explicit values in the `OmniboxPopupSelection::LineState`
enum since their values don't matter (i.e. aren't persisted). Though
their relative ranking does matter as it determines tab order.
Also updates outdated comments.
Also moves a `static_assert` for clarity.
Bug: 1394443, 1062446
Change-Id: I436189f8140875c435074b88b7f91ce22436b5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622629
Auto-Submit: manuk hovanesian <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159195}
[CVV Storage] Add StoredCvc tables in AutofillTable
This cl adds the LocalStoredCvc and ServerStoredCvc table to Chrome's
Autofill table. This is part of the implementation to support CVV
storage in Chrome.
Bug: 1450749
Change-Id: Ibe708ea5fc4f8473f1566636db7ffeeb0eafb35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600429
Code-Coverage: Findit <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Jiali Huang <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159194}
Revert "Migrate all tests on linux-ubsan-vptr to jammy"
This reverts commit 0fcf7bb5416e3c880944e4fcec9acf7705046aad.
Reason for revert: I suspect this is the cause of the failures in https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/23778/overview.
Original change's description:
> Migrate all tests on linux-ubsan-vptr to jammy
>
> Note: this CL was automatically generated.
> If this is suspected to have caused test regressions on the affected
> builder, please feel free to revert.
>
> [email protected]
>
> Bug: 1412588
> Change-Id: I9aac1d6adde8b10163b93a355764950df52d58ed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621852
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Ben Pastene <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1159082}
Bug: 1412588
Change-Id: I5c9a4e7b57160f7cddd346b47be48e034acda105
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621477
Commit-Queue: Reilly Grant <[email protected]>
Auto-Submit: Reilly Grant <[email protected]>
Owners-Override: Reilly Grant <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159193}
Migrate android-11-x86-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Id5f31a9cc84ab6ed38123745b2f07f8956656741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622692
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159192}
[System Dialog Delegate] Use the window closing callback
The callback registered with `RegisterWindowWillCloseCallback` is
not called when a widget is destroyed directly without calling
`views::Widget::CloseWithReason()`.
This CL uses the window closing callback instead.
Bug: None
Change-Id: I1977f392c3073ca1e31c2099b99372728a46d375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605155
Reviewed-by: Xiaodan Zhu <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159191}
Update the PDF used for PdfToPwgRasterBrowserTest
pdf_to_pwg_raster_test.pdf is used for PdfToPwgRasterBrowserTest and
it currently contains texts which causes its rastering result to vary
based on the platform, the processor and the renderer type. This can
often trigger breakage when PDFium text rendering is changed and it's
hard to manage all the expectations.
To reduce the discrepancies between different configurations, updates
pdf_to_pwg_raster_test.pdf to contain a red and a blue rectangle so
that only 1 pwg expectation is needed for each test.
This CL also makes the following improvement:
- The new PDF contains colors which are not black or white.
- Change the PDF test area to match the actual PDF page size.
- The new PDF contains 2 pages which is a better test case for
TestSuccessLongDuplex.
Bug: 1454485
Change-Id: I4436f6e633115ae09ace11dca022caec17e3ed85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622627
Code-Coverage: Findit <[email protected]>
Commit-Queue: Nigi <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159190}
Migrate Mac11 Tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I133ad0e270934b88171a6a6e47770c40de53e4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622728
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159189}
Disable PrivateNetworkAccessBrowserTestRespectPreflightResults.PreflightConnectionReusedHttp1
This test was previously disabled on some platforms. Disabling it on all
platforms until the flake issue is resolved conclusively.
No-Try: true
Bug: 1315068
Change-Id: I3ca4ec09cd5b2254568a8f8a4d3151e9b2548985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621405
Auto-Submit: Reilly Grant <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Owners-Override: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159188}
[Fixit] Fix context menu download tests
Bug: 1225709
Change-Id: I709671d60327163e7f538f40b5e272e0c0caaaed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621605
Reviewed-by: David Maunder <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159187}
Mark all platforms as slow for focus-controller-recursion-crash.html
Also reduce 50000 to 5000. The history on this test is quite old,
so I'm not sure what the crash is caused by. But it would seem
that 5000 vs 50000 is still ok. 5000 options inside a select
element is quite a few.
Fixed: 1455255
Change-Id: I61fd60c445b8569369578f5c817a30666e4f5239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622568
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159186}
Roll wpt tooling
This rolls wpt to latest commit at
https://github.com/web-platform-tests/wpt.
REMOTE-WPT-HEAD: 4de902c54fdcf32c10faec3dc6280eb72f45e613
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I7819032fe5bcc2140bd7814f936141ecf72e7b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622283
Reviewed-by: Jonathan Lee <[email protected]>
Auto-Submit: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159185}
Add TestExpectations entry for form-double-submit-requestsubmit.html
The above mentioned test occasionally times out in CI. See:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fhtml%2Fsemantics%2Fforms%2Fform-submission-0%2Fform-double-submit-requestsubmit.html
As such, this CL adds a TestExpectations entry to indicate that the test
may time out.
Bug: 1455325
Change-Id: If2953b067e8c2906f185714533a020c86cbca281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618332
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Sanket Joshi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159184}
[User Education] Migrate Tutorials to new API, remove old code
This is a prerequisite to branching and conditional tutorials. We need
to consolidate on the API that will get these new enhancements.
There were several layers of entry points that could be used to build
tutorials previously; now there is only one that can be accessed by
teams building tutorials. Also, by consolidating on the new API, we
avoid examples of deprecated usage in the code.
Change-Id: I0032510bc901a6502149599a760f9b6502868d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618067
Reviewed-by: Mickey Burks <[email protected]>
Reviewed-by: David Black <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159183}
Migrate Libfuzzer Upload Linux32 V8-ARM ASan to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3dd9911002192ff8de506ba2fcec48efb694f83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622691
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159182}
Try turning browser_tests back on as experimental for Mac10.15 Tests.
It's been off for a while so checking to see if possible to turn back on.
Bug: 1042757
Change-Id: I5ddf962c6c2bb62e48b75d7466328ceb407df2db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622507
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Lindsay Pasricha <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159181}
[WhatsNew] Add new content to What's New
This CL:
- Creates a new plist for the new content. Since What's New M116 will be launched via finch, we created a new plist to support versions. In the future, we will be able to simply update one plist.
- Adds the new strings for the new content.
- Adds the screenshots lottie files for the new content.
- Updates WhatsNewDataSource to be able to process the screenshot file name and the texts in the screenshot that will be localized.
- Updates grit_header_parsing.cc to be able to support ios_google_chrome_strings.h and ios_chormium_strings.h.
- Adds temporary learn URLs for each new feature
UI Mocks:
- https://screenshot.googleplex.com/4DANWU2AnGVgip8.png
- https://screenshot.googleplex.com/3UPpMecxvcGkTXd.png
- https://screenshot.googleplex.com/7vUkvLQNPS9fNMp.png
- https://screenshot.googleplex.com/4RkUNBo7jGMZkYi.png
Change-Id: I47bd78b2c6d088e020d81671b59211a2d0877ed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608835
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Cheick Cisse <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159180}
Migrate fuchsia-x64-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Idec07f8f9b996281d003259987c14cf04217b4e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622259
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159179}
Disable PasswordManagerGroupingDisabledTestCase/testDuplicatedCredentialWithNoUsername
This test is flaky.
No-Try: true
Bug: 1351802
Change-Id: I4f6c249e459d4df07fec1b823f5fc1f25c17d7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621340
Reviewed-by: Alvin Ji <[email protected]>
Owners-Override: Reilly Grant <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159178}
Re-order local destruction in NetworkContextTest
Avoid spurious dangling ptr warnings by ensuring that:
TestingPrefServiceSimple outlives the NetworkContext that has
an unowned reference back to it via the NetworkQualitiesPrefDeledage.
SimpleTestClock outlives the the NetworkContext that has an unowned
reference back to it via the cache via the backend.
Bug: 1401495
Change-Id: Ib31d783bda0cea3bf2152ba7b6e9c29b373d0a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619307
Reviewed-by: Kenichi Ishibashi <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159177}
Enable *building* of Rusty QR Code Generation on Android and Linux.
This CL enables *building* of Rusty QR Code Generation on the same
platforms and configs where `enable_rust_crash` is built. It changes
both `enable_rust_qr` and `enable_rust_base_conversions`, because
QR-related FFI requires conversions from `base::span<T>` into
`rust::Slice<T>`.
This CL does *not* yet *use* Rusty QR Code Generation at runtime,
because the "RustyQrCodeGenerator" feature remains disabled by default.
Since this CL starts to include the `third_party/rust/qr_code` library,
it expectedly leads to a ~22kB binary size increase. This increase has
been reviewed and approved when the ATLs have reviewed landing of the
third-party library (see https://crrev.com/c/4497329 and the approvals
listed from that other CL's description). Also note that evaluating the
binary size impact of shipping Rust code is tricky, because the cost of
the base C++ libraries is amortized across multiple components, while
the cost of the base Rust libraries will initially only support the QR
crate.
This CL modifies `testing/scripts/check_static_initializers.py` so that
allowlist patterns span not only a filename, but also the symbol which
brings in a static initializer. This should be more robust in general,
but this also helps to work around a symbolization problem where Rust
symbols are not associated with a filename in the `nacl_helper` binary
(the `chrome` binary seems ok). For more details see
https://crbug.com/1455186.
Bug: 1431991
Binary-Size: Size increase is unavoidable (see above).
Change-Id: Id9224c349400d2421614a698b823e8469c15ac67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4509543
Auto-Submit: Łukasz Anforowicz <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159176}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686943333-54f7cfb82f91d2c856f6c0f5dcd665394ca25f6a.profdata to chrome-mac-arm-main-1686952636-b42209146957355f2fe8215d621c165c4277e71a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I0776c3965c467759f176e86511c4cd28a4c8cabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621439
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159175}
[color] Add the grayscale palette
This CL introduces the grayscale palette per UX spec and adds the
corresponding boolean to apply the grayscale overrides to the
ColorProviderKey. See go/chrome-desktop-tokens for details.
Bug: 1448246
Change-Id: I556e2a0bc73ae8724c9a1550a58efdb92daf939a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621548
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159174}
multipaste: Update string conversion for file names
This CL fixes code to avoid hitting a DCHECK when a clipboard history
item is created for a file whose name contains non-ASCII characters.
When creating the file path, we now convert the string from UTF16 to
UTF8 rather than to ASCII.
Bug: b/267690087
Change-Id: I86fca7ca882387cbea1f08e657040260cd705503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621088
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159173}
Revert "[remoting] Support external notarization tool in do_signing.sh."
This reverts commit 6f41472fd47dd661d2fa6c4ff56c5797388bbd7e.
Reason for revert: Broke mac signing, http://shortn/_g5oMMpOvz1
```
/var/folders/1d/z50_0t6s6fsb1yj3_svwklk80000gn/T/chrome_sign_input.aelv42jm/remoting-me2me-host-mac/do_signing.sh: line 229: NOTARIZATION_TOOL: unbound variable
```
Original change's description:
> [remoting] Support external notarization tool in do_signing.sh.
>
> This updates the Mac signing script to support passing in a
> notarizing tool, instead of using notarize_thing.py.
>
> Once the Google-internal script is switched over, a followup CL can
> remove the usage of notarize_thing.py.
>
> Bug: 1449970
> Change-Id: I264a8a61a988e72ec2f32c23da54dba1abdfd228
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616689
> Reviewed-by: Robert Sesek <[email protected]>
> Auto-Submit: Lambros Lambrou <[email protected]>
> Commit-Queue: Robert Sesek <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158486}
Bug: 1449970
Change-Id: Ib481fb4c136fe2ceaedc9e11763afb001db7f9c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621729
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Owners-Override: Keybo Qian <[email protected]>
Commit-Queue: Xinan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159172}
Remove "Modifier" from RestoreDefaultKeyboardModifierRemappings
- Remove "Modifier" from the method name since it'll also be
responsible for resetting the six pack key remappings.
Context: https://crrev.com/c/4585862/comment/15629039_1d45f79a/
Change-Id: I03ecd63a09a19e8f0e3168c2206eaa618bfc3039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619527
Reviewed-by: David Padlipsky <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Michael Checo <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159171}
Reland "Wayland protocol to allow exo to rotate view focus in lacros - Client"
The defect was in the server CL which this change depended on.
This is a reland of commit 60992525073a86d11ebf2bb1321e370bc611bc73
Original change's description:
> Wayland protocol to allow exo to rotate view focus in lacros - Client
>
> When focus rotation is requested for lacros widget, a rotate focus event
> is emitted from exo to lacros. These requests are fenced with a serial,
> which will prevent delay in processing from triggering multiple
> subsequent rotations in ash.
>
> When the client has reached the end of it focusable views, it will
> notify the the exo with the aforementioned serial.
>
> For this change, much of the rotate pane focus code had to be moved to
> the widget delegate. This is because the behaviour is now platform
> dependent.
>
> Change-Id: Ifbe31230578444cc35db8143fc5cfd0c14448b95
> Bug: 1361120
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4554431
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Hidehiko Abe <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157882}
Bug: 1361120
Change-Id: I064d935f07866b11dddb315ed4302bacfe21a678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619044
Code-Coverage: Findit <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Fred Shih <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159170}
[Panorama] Allow for a color to not be passed into color element
Added a check for existence of color parameter before passing it into
skColorToRgba function, otherwise, the element errors out and no color
circle is shown if the value is null. This was only really happening
with base color since it can be null to help support GM2 and GM3
coexistence in the code, but added checks for the others as well.
Bug: 1455338
Change-Id: Ib3a414e7a57634bd980740b2433bf9fd49f4c417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621067
Commit-Queue: Riley Tatum <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159169}
Migrate TSAN Release to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I1f3e950b11dc3dafb89a24ea523ab9dbf0875a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621073
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159168}
[ios] Update ios.content_browsertests.filter
Recent changes have fixed a number of other tests. This CL removes a
number of tests from the filter and updates the list of flaky tests.
Bug: 1413706
Change-Id: I979064763208e4a2413ff79b300577c7d31272e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621640
Commit-Queue: Ian Vollick <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159167}
[Toolbar] Disable clip to padding during NTP transition
This was not previously needed because this clipping behavior is only
active when padding is non-zero. In some arms of the omnibox revamp
padding is now non-zero, causing the omnibox to disappear during the
transition.
Bug: 1454630
Change-Id: Id0541f6f7f315f05b5915001730bf340803fa629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616624
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159166}
Migrate Linux TSan Builder to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I75f413125a116bb5b30f9af98c0590c3b8344255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622689
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159165}
customization: Add fake observer for stylus and tablet
Bug: b/241965717
Change-Id: I88638dc2ac8d7702e24255e56d42a94dc2bdd55b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617674
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Yuhan Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159164}
Roll WebRTC from 4d2a21943684 to 11affddbbc7e (1 revision)
https://webrtc.googlesource.com/src.git/+log/4d2a21943684..11affddbbc7e
2023-06-16 [email protected] Fix PeerConnectionDependencies leak on PC init.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ie4b5f85f7a9930c4061541ef30bc7957405a7fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621095
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159163}
Migrate Mac10.14 Tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ife969d1eadaaab7157f0138cbaf1316404f2270a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622379
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159162}
Remove kNullNativeWindow and kNullNativeView
They are constexpr, which makes them interfere with plans to turn
gfx::NativeWindow and gfx::NativeView into object types, and in
many cases, because `nullptr` worked, they weren’t even used.
Replace them with value-initialization. For class types, that’s
default construction, and for pointer types, that’s a null
pointer.
Bug: 1280317
Change-Id: I20e0a38d4fdb366c0d8d78aec06d7c391c6bb062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604045
Code-Coverage: Findit <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Owners-Override: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159161}
Rename GetExistingWindowsForMoveMenu function to something more generic.
Change the name of the function (GetExistingWindows), the description of what it does and delete the TODO.
Change-Id: Ifbb37149b07272a332cbf1b65b53e3c43e60c26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618953
Reviewed-by: Darryl James <[email protected]>
Reviewed-by: David Pennington <[email protected]>
Commit-Queue: Emiliano Hurtado <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159160}
focus-mode: Add quick settings button
Add the focus mode button to quick settings behind the flag.
Currently use placeholder text and icon, will be updated later with the
specs.
BUG=b:286931299
Change-Id: Ic7975afc782e39c30e8d7d08ba7f86cc33352a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617591
Reviewed-by: Jiaming Cheng <[email protected]>
Commit-Queue: Richard Chui <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159159}
Migrate fuchsia-x64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie7c14f60b74c3aabbbd45d06af9b5081d93a0b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621865
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159158}
[keyboard-alt]: Add simulate right click setting to touchpad page
Screenshot: http://screen/5rmafKMAeoyksYv
Bug: b/279503977
Change-Id: Ide45db6f89b49f9f4f424b370d5d7d2d78d9b556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569745
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Michael Checo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159157}
Increase from 10 to 25 shards for browser_tests on Mac10.14 Tests
Bug: 1455542
Change-Id: Ib848b670e06029298c984ec1c2d675e532cdc684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622289
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Lindsay Pasricha <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159156}
chromeos: Fix clipping of system tray Ethernet VPN icon
When the Ethernet icon has a VPN badge it is larger than the default
18x18 tray icon. Ensure that TrayItemView::CalculatePreferredSize()
returns a large enough size when its image_view_ has a large icon.
Update the icon to a 20x20 asset to be consistent with other tray
icon assets. This is not sufficient to fix the problem because the
VPN badge extends to the leftmost pixel of the final image.
Fix some other issues this reveals:
- The battery icon is too tall in side-shelf (this is not visible
because it was being clipped)
- Notification icons have an unnecessary border (also not visible
because they were being clipped)
Bottom shelf: https://screenshot.googleplex.com/79ELtFrYZXndXxc
Side shelf: https://screenshot.googleplex.com/4vHT4nfacakL6Zx
For unclear reasons this causes a pixel test failure in the
NetworkDetailedView. That view is unchanged and difference cannot
be seen by human eyes. andrewxu@ says this is likely an issue with
background colors as a side effect of shelf rendering and not due
to this CL, see b/287535714
Bug: b:284983806
Test: added to ash_unittests
Change-Id: Ia22e435f51344635020a2b32cc5ed7510b8f2349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617053
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159155}
Roll src-internal from 63351072c0b9 to 3a20458b83dd (2 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63351072c0b9..3a20458b83dd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I0eabcc56c2a24eb8346ce3241e8634cdc7717f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621376
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159154}
Re-enable health.ProbeBlockDevices"
This reverts commit dd60dd2db22dedc144deefcde03f7e99fd7ada56.
Bug: b:286590113
Change-Id: I7c3e2593562f69dafb8b72a1f72ffff95ff30607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621163
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159153}
[Media Router] Enable Media Router OTR by default.
This enables by default the creation of a separate Media Router
instance for OTR profiles to enable testing for M116.
Various tests are updated to pass with the feature enabled/disabled.
See http://crrev.com/c/4336996 for more details/background.
Bug: 1291723
Change-Id: Ic1623fb424c3f4f23c57613a6e75db3be17ab4da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571347
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: Mark Foltz <[email protected]>
Reviewed-by: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159152}
Revert "Derive enable_ppapi from enable_nacl"
This reverts commit 902a4b58184bfd8e34b6e7f40b859f1bd85a3dc3.
This is a partial revert that leaves the testing/buildbot changes alone.
Bug: 702990
Change-Id: I36ca6830a0a97ae7554d17724455670b099fce25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621912
Reviewed-by: Kevin McNee <[email protected]>
Owners-Override: Kevin McNee <[email protected]>
Auto-Submit: K. Moon <[email protected]>
Reviewed-by: Derek Schuff <[email protected]>
Commit-Queue: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159151}
Migrate UBSan vptr Release to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia03a0f5a49b15091b3507802546b79af1c0edb3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622375
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159150}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686938378-7e91744812aa59b3fe089a6e7b598972400424c2.profdata to chrome-mac-arm-main-1686943333-54f7cfb82f91d2c856f6c0f5dcd665394ca25f6a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I65d853f2677ada2c216687b0aca3670dcf77ad64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621292
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159149}
Revert "Roll Dawn from f1ed14a74552 to 66805b0c0e45 (5 revisions)"
This reverts commit b517d505c1fc398f3f6eeed32c117803db12fc6b.
Reason for revert: Very likely cause of failure of deterministic build on Windows
Original change's description:
> Roll Dawn from f1ed14a74552 to 66805b0c0e45 (5 revisions)
>
> https://dawn.googlesource.com/dawn.git/+log/f1ed14a74552..66805b0c0e45
>
> 2023-06-14 [email protected] [tint] Migrate to 'fluent types'
> 2023-06-14 [email protected] [DawnLPM] Enable dawn lpm for use_libfuzzer builds
> 2023-06-14 [email protected] [DawnLPM] Add optional fields to the lpm grammar
> 2023-06-14 [email protected] [ir] Add Return::Value() to get the return value
> 2023-06-14 [email protected] Unset bindgroup: validations and unittests
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/dawn-chromium-autoroll
> Please CC [email protected],[email protected] on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
> Bug: chromium:1374747
> Tbr: [email protected]
> Change-Id: I8cf52cf48c5a6f69c53a754c547ce50e4ba4cfca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616717
> Commit-Queue: chromium-autoroll <[email protected]>
> Bot-Commit: chromium-autoroll <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157914}
No-Try: true
Bug: chromium:1374747, chromium:1455317
Change-Id: Ie512c7a0c85ce4bdab772420f2ba956fd9186d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618968
Commit-Queue: Reilly Grant <[email protected]>
Owners-Override: Antonio Sartori <[email protected]>
Reviewed-by: Nicola Tommasi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159148}
Allow fields to be hidden in BubbleDialogModelHost
This patch introduces the ability to show and hide fields in the
BubbleDialogModelHost. Visibility can be set in the builder via
params (which now share a base class) or through the model itself
using `SetVisible` with the desired field's ID. A test has been
added for the new behavior.
Bug: b:287238131
Change-Id: Ie9729ed0a9faea1d3496a4ff426af478a5b3c896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590240
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159147}
[Code Health] Remove Download.NetworkConnectionType.Complete histogram
Removes Download.NetworkConnectionType.Complete as it has expired on
2022-09-11 and cleans up code that uses it.
Bug: 1447209
Change-Id: I0d47683475611257d248671094ed0df43211fa86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621597
Commit-Queue: Nigi <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159146}
Migrate mac-fieldtrial-tester to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I0f0cd37359150d100ba9f8c8853e45554b3247d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622373
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159145}
Mark estimate-usage-details-filesystem as flaky.
The worker version was already disabled. This disables the document
version.
Bug: 1413770
Change-Id: I12f1d0cc1b9b365118b782e127d44eea4e17c12b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621516
Auto-Submit: Reilly Grant <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159144}
Migrate mac10.15-updater-tester-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I98c6bbeccd5358ee23946d1db002ab826b092d29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621863
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159143}
Allow display capture from companion origins in iframe.
Bug: b:281852066
Change-Id: I941a96e90578d0fa1c9ee459a28171a3bff699ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621328
Commit-Queue: Juan Mojica <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159142}
print-management: add delegate
- Add `print_management_delegate` to enable calling chrome functions
from ash.
- Create delegate when `print_management_ui` created and pass it to
`print_management_handler`.
- Update dependencies to ensure `gn check` passes.
- Test handler uses delegate when `LaunchPrinterSettings` invoked
- Test `LaunchPrinterSettings` opens settings app to expected URL.
Bug: b:283119650
Test: browser_test --gtest_filter=*PrintManagement*
Change-Id: I3d266b0f38415e523dca6ce0f601f9c2e6542bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610908
Reviewed-by: Gavin Williams <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159141}
[omnibox] Add minimal components/omnibox/README.md
Bug: 1452687
Change-Id: Ic3b07f7c41be09c2d55e5e28877d31d51ba73bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621860
Commit-Queue: Orin Jaworski <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159140}
[css-flex] Revert row intrinsic sizing fixes
This version is not web compatible.
Will try again with a more conservative version next week after the 116
branch.
Bug: 240765
Fixed: 1454306,1444968
Change-Id: Ia7d3a243df1cabff44a9707f2aeb0a8551e91003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616735
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159139}
Adding classifier agent in the renderer.
The classifier agent serves as the entry point to the visual search feature in the renderer process. It will also ultimately implement the IPC interface to allow communication with the browser process.
Bug: b/284642988
Change-Id: I58797a0dbd81a87a80398a1fe1707fb473c1dc7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609970
Reviewed-by: Michael Crouse <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Pierre St Juste <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159138}
Refactor EnablePrintScanAfterPreview feature
This CL splits kEnablePrintScanAfterPreview into two distinct features:
- kEnableCloudScanAfterPreview, to control migrating the
released cloud scanning UX to become post-preview. This is
meant to be a regular Finch experiment since the cloud scan feature
is already released.
- kEnableLocalScanAfterPreview, to facilitate testing the
workflow of post-preview scanning in the local agent case.
This is meant as a temporary flag that will just be removed
once the feature is finalized, and as such it keeps the old
"EnablePrintScanAfterPreview" for simplicity.
Bug: b/281087582, b/216105729
Change-Id: Idc30ee4d82f70b967585b42d79743dafc7c86f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619733
Code-Coverage: Findit <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159137}
Disable ProxyAuthLockscreenWebUiTest.ProxyAuthCanBeCancelled on linux-chromeos-rel
This test is flaky. Note that rel asan configs are excluded from being
disabled as there do not appear to be flakiness issues there.
Bug: 1455506
Change-Id: Ic4936e767b75514abc8d41eb440f11ef87650a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622274
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Commit-Queue: Kevin McNee <[email protected]>
Owners-Override: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159136}
[color] Simplify getting the ColorProviderManager::Key
Currently the construction of a ColorProviderKey by sources is a
set of virtual methods overridden by the ColorProviderSource
subclasses, or optional params set directly on the source (widget).
This CL simplifies the current state and makes it such that
ColorProviderSources are only required to override the
GetColorProviderKey() method to configure the theme properties for
their hosted UI.
The specific changes required here are for Widget and BrowserFrame.
Widget will always attempt to fetch the ColorProviderKey of its
parent if it exists, otherwise falling back to the key constructed
from the global NativeTheme instance.
Color mode and elevation overrides can be set on the Widget itself
so after it has fetched the key as described above these specific
overrides are applied (if necessary).
The BrowserFrame Widget subclass works similarly, first getting key
as described above and applying the BrowserFrame-specific overrides.
Follow up work will eliminate eliminate virtual from
ColorProviderSource::GetColorProvider and have the method always take
the key and get the ColorProvider from the manager.
Bug: 1431202, 1455535
Change-Id: I703a954423d760195374447ae47d92a9e700e5c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614129
Code-Coverage: Findit <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159135}
Migrate Linux Chromium OS ASan LSan Tests (1) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I5fbc3f693bf5e5f63b1903fb11b4145412945923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622256
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159134}
[Omnibox] Make clipboard suppress-after-use default off
Bug: 1455286
Change-Id: I715c198c31172dedfb093e90f6897ea59ecc386a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620927
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159133}
Migrate android-avd-packager to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I5967c8f00ebd088e7017fccfc0621b29c6743e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621861
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159132}
[PDF OCR] Add more UMA metrics for PDF OCR usage
Add UMA metrics to track PDF OCR usage and update one existing UMA
metric ("Accessibility.PdfOcr.ActiveWhenInaccessiblePdfOpened") to help
measure metrics described in go/pdf_ocr_mvp_metrics.
This CL includes new metrics that record:
- the number of pages in inaccessible PDF opened for PDF OCR
- the number of PDF OCR requests sent to OCR and received from OCR
- the time PDF accessibility was active
AX-Relnotes: n/a.
Bug: 1443341
Change-Id: I93314cd3d08a6c0dc077fc0c47e3905b282486e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616749
Commit-Queue: Kyungjun Lee <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Evan Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159131}
Fix enable_plugins in //content//common/BUILD.gn
Fixes an enable_plugins in //content/common/BUILD.gn that should be
enable_ppapi instead. This started triggering a GN assertion after
r1159004 when is_debug=true, is_component_build=false, and
enable_nacl=false.
Bug: 702990
Change-Id: I453d7a294989a3782c9913ce003a35f670807c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621913
Auto-Submit: K. Moon <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159130}
[Code Health] Remove Download.Later.Events histogram
Removes Download.Later.Events as it has expired on 2022-12-25 and
cleans up code that uses it.
Bug: 1447209
Change-Id: I64497de4d2973b382af322c2afd27ba1c887b6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617733
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Nigi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159129}
Add CreateNewTabInitializeRenderer to field_trial_config
Also fixes tests which don't expect renderer creation during
new tab creation.
This CL also sets a new baseline for skia gold images as for
render tests didn't expect new renderer creation.
Bug: 1440527
Change-Id: Icf25aa5ab2b6427f25a36cbabe8ce0f117aed0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582104
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Sreeja Kamishetty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159128}
Migrate win11-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I4926135eecf207356f5376c9885f8994ac9fdcc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622469
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159127}
Add fallback and 2 more input context to install prompit on Android
1) fallback to the legacy logic if ML result is not available yet
2) add origin to the input context, to filter UKM by origin
3) add app_type to input context, we might need different strategy
for web app and native app.
Bug: 1435437
Change-Id: I42b1a05717469c6476ce368979abb052d598ef8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615695
Commit-Queue: Ella Ge <[email protected]>
Reviewed-by: Hailey Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159126}
Migrate all tests on linux-rel-cft to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I032dc4c2f36651a2ae6ce7652134c01e1f19bc03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621851
Commit-Queue: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159125}
Roll src/third_party/libaom/source/libaom/ 233000f66..6154a1ed4 (18 commits)
https://aomedia.googlesource.com/aom.git/+log/233000f66e9f..6154a1ed4dd9
$ git log 233000f66..6154a1ed4 --date=short --no-merges --format='%ad %ae %s'
2023-06-14 marpan rtc: Fix to last_source when frame_dropper is enabled.
2023-06-14 jzern aom_configure: increase -Wstack-usage w/asan
2023-06-14 jzern Make high bitdepth SADxXD declarations consistent (2)
2023-06-07 deepa.kg Skip error calculation of start MV in subpel search
2023-05-25 mudassir.galaganath Propagate error from worker to main thread during tile-MT
2023-06-12 gerdazsejke.more Specialize Neon high bitdepth subpel variance by filter value
2023-06-12 gerdazsejke.more Add Neon high bitdepth subpel variance functions
2023-06-14 jonathan.wright Make high bitdepth SADxXD declarations consistent
2023-06-13 yunqingwang Skip_mode improvement
2023-06-13 marpan rtc-svc: Fix condition to reset buffer on change_config
2023-06-08 jianj Allow svc_encoder_rc to use RTC RC library
2023-06-13 jianj Remove non realtime only condition for rtc rc lib
2023-06-12 jonathan.wright Simplify aom_highbd_<bd>_sub_pixel_avg_variance* entries
2023-06-12 jonathan.wright Simplify aom_highbd_<bd>_sub_pixel_variance* function entries
2023-06-12 jonathan.wright Remove duplicate aom_highbd_<bd>_mse* entries
2023-06-12 jonathan.wright Simplify aom_highbd_<bd>_variance* function entries
2023-06-12 jonathan.wright Remove aom[_highbd_*]_variance 2x* and *x2 entries
2023-06-12 jonathan.wright Remove duplicate aom_sub_pixel_avg_variance* entries
Created with:
roll-dep src/third_party/libaom/source/libaom
[email protected]
Change-Id: I9a549fb7aba741037cf1bbe8c2a0dc1a3bf30e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621848
Commit-Queue: James Zern <[email protected]>
Reviewed-by: James Zern <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159124}
Revert "Reland "personalization: extend two-tone background""
This reverts commit c22757dc6c6b3bc125ef67d5dae4200e0ae3c29d.
Reason for revert: Scroll container is too big.
Original change's description:
> Reland "personalization: extend two-tone background"
>
> This reverts commit 2f53e24973171e35b5df0dfd20b638f6db24fedc.
>
> Reason for revert: Fixed bug with breadcrumb
>
> I scrolled all the way down and there's no gap in the wallpaper:
> https://screenshot.googleplex.com/6fKrRYPgLEuSShq.
>
> Original change's description:
> > Revert "personalization: extend two-tone background"
> >
> > This reverts commit 88acc15dd8376fb72e4f0a159eb64b747d9411b1.
> >
> > Reason for revert: http://shortn/_6z555qKxyU
> >
> > Original change's description:
> > > personalization: extend two-tone background
> > >
> > > The content background color should extend to the bottom of the page.
> > >
> > > before: https://screenshot.googleplex.com/97MhQyhysNcf8iK.png
> > > after: https://screenshot.googleplex.com/9jfRRmAySoZLwPB.png
> > > mock: https://docs.google.com/presentation/d/1sCxNbUVFwRf-4YYOhcUcmcc0mHpwysmHrO9qNoglDwQ/edit#slide=id.g13d12115f9e_0_250
> > >
> > > BUG=b:286519658
> > > TEST=manual
> > >
> > > Change-Id: I71a0a1e8c4b343d101c3a7eecd3bfdaea6eeae3c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605994
> > > Commit-Queue: Erica Lee <[email protected]>
> > > Reviewed-by: Jerry Liu <[email protected]>
> > > Reviewed-by: Jason Thai <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1155755}
> >
> > BUG=b:286519658
> >
> > Change-Id: I691749a1d3971f982c06d8a08e77e828294d55da
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609245
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Commit-Queue: Jason Thai <[email protected]>
> > Auto-Submit: Jason Thai <[email protected]>
> > Commit-Queue: Jerry Liu <[email protected]>
> > Reviewed-by: Jerry Liu <[email protected]>
> > Quick-Run: Jason Thai <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1156612}
>
> BUG=b:286519658
>
> Change-Id: Id5a65689feb24c69fe51d0b935fa7eb8dc0921a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609098
> Commit-Queue: Erica Lee <[email protected]>
> Reviewed-by: Jerry Liu <[email protected]>
> Reviewed-by: Jason Thai <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158392}
BUG=b:286519658
Change-Id: I105318a98f1c87dcf99bb67e306a2f484479c00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621600
Reviewed-by: Jason Thai <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Erica Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159123}
Add a new ARC feature for updating LMK min state
To enable the feature in Android by setting the corresponding system
property.
BUG=b:281008920
BUG=b:279498529
BUG=b:280498904
TEST=autoninja -C out/Default ash_components_unittests &&
out/Default/ash_components_unittests
TEST=Manually verify the feature works w/ Android changes
Change-Id: I64153ccf94fdcb191a87ec00420b9c6f3dc53637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616655
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Hung Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159122}
AudioTrackRecorder: get rid of callbacks.
Prepares for a nicer implementation of crrev.com/c/4582364 by
switching the callback interface from callbacks to a callback interface.
Bug: b:275663480
Change-Id: Ib9da64b3967167cad8f31f3c7aec4fbd7745c16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614756
Commit-Queue: Markus Handell <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159121}
Migrate android-webview-pie-x86-wpt-fyi-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I562e74569f722dd4cf8230cfd52cbdfdd658e55d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622468
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159120}
Revert "Integrate text fragments with Document lifecycle"
This reverts commit a2cf45098ab9ae95f038bba2b12996df74ffe1a1.
Reason for revert: Failing consistently on the WebKit Linux Leak builder: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/52308/overview
Original change's description:
> Integrate text fragments with Document lifecycle
>
> This CL is a refactoring to improve how text fragments are integrated
> with the document lifecycle. There are several high-level changes here:
>
> - Annotations (the thing that performs text search and applies the
> highlights) no longer allow attaching at arbitrary points. Instead,
> clients can set an annotation as "needing attachment" and schedule a
> BeginFrame. In the next BeginFrame, all annotations needing attachment
> perform their search after layout is updated.
> - Text fragments have a special case for when a page has never been
> visible; the text search is deferred until the page becomes visible.
> The above change required moving this behavior into
> AnnotationAgentContainerImpl.
> - TextFragmentAnchor is no longer responsible for controlling when
> annotation attachment occurs. Instead, it's invoked right after
> annotations are attached and checks the status of its annotations to
> update its internal state and perform scroll into view and related
> actions.
> - Simplify TextFragmentAnchor's state machine by removing the
> ScriptableActions state. Instead, the script-running actions are
> scheduled for an animation frame and then move the anchor into the
> kDone state.
>
> See also the related followup which this CL enables:
> https://crrev.com/c/4586061
>
> Change-Id: I1f6fd7c28b86274beae2cdc934b529c9f7bfb472
> Bug: 1327734,1303887,963045
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577583
> Commit-Queue: David Bokan <[email protected]>
> Reviewed-by: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158968}
Bug: 1327734,1303887,963045
Change-Id: I20efaf38ec3c0d9d26cae45478283080c3ffb43a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622279
Owners-Override: Reilly Grant <[email protected]>
Auto-Submit: Reilly Grant <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159119}
Migrate Mac13 Tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I8534a8222b20d104947709d5f80a89fbe546a4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622467
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159118}
float: Prevent floated windows going offscreen when changing displays
Floated windows are in the float container which does not have a
workspace layout manager. Therefore, when they are added to a new root
the ensure visibility logic is not triggered. If the destination
display was narrower than the source, there is a large change the
floated window is completely offscreen due to its default float bounds.
This patch adds the same logic workspace layout manager does, which
is notify the window state. If we have more similar issues popping
up in the future, we may need to consider extracting workspace layout
manager logic to be shared.
Test: ash_unittests WindowFloatTest.MoveFloatedWindowToOtherDisplay
Change-Id: I33c7b83fe85ccd2810b1e2b51b13c25871f31cb6
Fixed: b/286864430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609188
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159117}
geolocation: Use mock WifiDataProvider in GeolocationServiceUnitTest
Bug: 1455221
Change-Id: I69d004036c357f0f84db42511023864b1c9fecaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619369
Reviewed-by: Alvin Ji <[email protected]>
Commit-Queue: Matt Reynolds <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159116}
Migrate linux-blink-web-tests-force-accessibility-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie1c7ac5e48c4bce98ae4ed68b2c28a4e15691b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621859
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159115}
Add getNetworkRequestReliabilityLogger2
This will replace getNetworkRequestReliabilityLogger,
so that we can remove the old FeedNetworkRequestReliabilityLogger
class.
Bug: b:278746541
Change-Id: I0edee46ee52193d583fc10ee74faa89df26a03e5
Low-Coverage-Reason: just renaming
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622270
Commit-Queue: Dan H <[email protected]>
Reviewed-by: Jian Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159114}
[WebCodecs] Ensure we release pending request upon reset.
When calling reset() after configure(), the request was not being
properly aborted, which lead to hangs. Merge all paths into a
common helper method to avoid such issues in the future.
Fixed: 1447467
Change-Id: I3deb9f7f5c7dd6c915d2effa1791a7817e205e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619112
Reviewed-by: Eugene Zemtsov <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Auto-Submit: Dale Curtis <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159113}
[keyboard-alt]: Implement GetShortcutModifierForSixPackKey
- When the kAltClickAndSixPackCustomization flag is enabled,
the device's six_pack_key_remappings setting will be used
to determine if a key event should be remapped to a 6-pack
key action.
Bug: b/279503977
Change-Id: Ieb87a2f5981930a7e627c1ec1237c45cbaff1f3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4563047
Commit-Queue: Michael Checo <[email protected]>
Reviewed-by: David Padlipsky <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159112}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686931180-847c2e91b512c0a16e40d755b5c90ceca91a17a8.profdata to chrome-mac-arm-main-1686938378-7e91744812aa59b3fe089a6e7b598972400424c2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ic7ed0ae4d01ee2e602c26cc03367625e1c293c49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621253
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159111}
Remove loading.desktop and loading.mobile benchmarks
[email protected] has confirmed with the owner that these two benchmarks are not needed any more.
Change-Id: I04d06f4f779c2588510bc133f9b2e4119c408251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621157
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Max Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159110}
Migrate fuchsia-fyi-arm64-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Icd28a8627eebb03ba9f8c2cd65985014074e5e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622369
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159109}
[HSTS] Add .gov domains
Change-Id: I1bd3e2c8bb17a7125eafae8126f9719abccc2381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621468
Commit-Queue: Nick Harper <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Auto-Submit: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159108}
Make PrintNodeUnderContextMenu operation go through PrintViewManager
Currently, RenderViewContextMenu uses Mojo to directly talk to the
PrintRenderFrame interface when printing the node under the context
menu. This is inconsistent with other printing operations that go
through PrintViewManager.
Fix this by adding StartPrintNodeUnderContextMenu() and changing
RenderViewContextMenu to call it. StartPrintNodeUnderContextMenu() then
invokes the appropriate version of PrintViewManager. PrintViewManager
will performs checks, like it does when starting other print operations,
before triggering printing via the PrintRenderFrame interface.
Bug: 1286556
Change-Id: I385d167ab93340722ec7e12e44ae73379075f7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602776
Code-Coverage: Findit <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159107}
[scroll-start] Apply scroll-start after layout
scroll-start[1] should set the initial/default scroll position of a
scroller. Many different things may cause a scroller's size/layout
to change as a page loads which can affect how scroll-start should
be applied. So, this patch applies scroll-start on each frame until
the scroller has been explicitly scrolled, i.e. by the user or via a
programmatic scroll. After an explicit scroll, scroll-start is no
longer applied.
We propagate scroll-start from the document element to the viewport
so that scroll-start can be applied to the page. We save an
explicitly_scrolled_ bit on the element so that scroll-start
does not prevent saved (explicit) scrolls from surviving changes
to display and overflow.
[1] https://drafts.csswg.org/css-scroll-snap-2/#scroll-start
Bug: 1439807
Change-Id: I5655f8e74b85fe45038f700091065fa11eeac0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546420
Commit-Queue: David Awogbemila <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159106}
Increase shards by 1 for android browsertests w/o field trial config.
Bug: 971387
Change-Id: I1c4e8e92aebf3b551a014f5014bb141a7d7521fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621070
Reviewed-by: Jeff Yoon <[email protected]>
Commit-Queue: Hao Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159105}
Migrate android-12l-x64-dbg-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I448418f3ac2a713dd0bba0e4b22a77d83b9a20ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621858
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159104}
customization: Add fake stylus and tablet data
Add fake stylus and tablet data, get and set method in
fake provider.
Bug: b/241965717
Test: browser_tests
Change-Id: I5e310dcc0fa367ed24b1a77a5bd3991d552b7df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616389
Reviewed-by: Michael Checo <[email protected]>
Commit-Queue: Yuhan Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159103}
Handle kAlreadyListening and uprev from aee56f072963 to 44fb9b4fa24e
This manual uprev also handles the kAlreadyListening enum introduced
into Nearby Connections in cl/540707703.
5 Revisions:
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/aee56f072963..44fb9b4fa24e
2023-06-15 [email protected] implement stoplisteningforincomingconnections
> PiperOrigin-RevId: 540724954
>
2023-06-15 [email protected] [Presence] Pass DeviceIdentityMetadata materials to PresenceDevice during advertisement decryption
> PiperOrigin-RevId: 540715111
>
2023-06-15 [email protected] implement startlisteningforincomingconnections
> PiperOrigin-RevId: 540707703
>
2023-06-15 [email protected] Fixed crash when initializing Bluetooth watcher
> PiperOrigin-RevId: 540650297
>
2023-06-15 [email protected] Adding components for binding the C++ libraries with flutter app
> - Branch class Listener from google3/location/nearby/cpp/sharing/clients/dart/platform/lib/listener.dart for further use of listening the change from notification controller.
> - Create Device Metadata to store the device information relating to UI showing.
> - Create binding class to bind C++ libraries to dart language.
>
> PiperOrigin-RevId: 540644654
>
Test: manually verified that Nearby, Phone Hub, EXO still WAI.
Change-Id: Id7a7d315a4d341f9dc9f665cc04d59ad1cb40add
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621596
Reviewed-by: Pu Shi <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Crisrael Lucero <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159102}
Migrate TSAN Debug to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I51d709dfc0fe1d6cb47c0fb244cb3809ea607de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622254
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159101}
Replace DisableIf w/ Min/Max Android SDK annotations.
DisableIf is intended for temporarily disabling tests
during investigations, but for tests that are knowningly
never going to pass on particular SDK versions, then
we should use the appropriate MinAndroidSdkLevel and
MaxAndroidSdkLevel annotations.
BUG=
Change-Id: Ia384f3a2c998d6ecb154241c3691589bc575c475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621638
Reviewed-by: Lijin Shen <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159100}
Migrate Linux ASan Tests (sandboxed) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia5371e47b56c2fad2e03fad2e20241e09ba9a23e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621855
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159099}
[aw] Add a check for HW acceleration when adding/removing frame metrics listener
This change fixes the crash that happens when detaching a listener
that was never added. Since addOnFrameMetricsAvailableListener() doesn't
return a status, it might be possible to AwFrameMetricsListener
to set mAttached to true even when addOnFrameMetricsAvailableListener()
fails, which is possible if hardware rendering is disabled. By adding
a check for hardware acceleration before adding and removing
the listener, we make it less likely for
addOnFrameMetricsAvailableListener() to fail.
Bug: 1454809
Change-Id: I9661a87f829f62561b58fd13f833a0dd6b7bf73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621849
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: Oksana Zhuravlova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159098}
breadcrumbs: replace feature checks with IsEnabled
This change makes the base::Feature for breadcrumbs private, and
replaces any checks against it with calls to IsEnabled().
This is in preparation for a subsequent CL to move breadcrumbs off
Finch, at which point IsEnabled() will determine whether to enable
breadcrumbs by a dice roll whose outcome is saved to user prefs for
some period of time (per go/graduating-from-finch).
As part of making the base::Feature private, this CL also removes
the iOS chrome://flags entries for breadcrumbs.
Bug: 1163762
Change-Id: I0b0e5f52a75a7758f98354cde4067ab50ed04aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585722
Code-Coverage: Findit <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Jesse McKenna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159097}
[CrOS Bluetooth] Fix pairing dialog background color when opened in QS
Fix Bluetooth pairing dialog background color being incorrect when
opened in Quick Settings. This was because the UI element was not
using a <cr-dialog> element, and because the UI container was not
importing and using the same stylesheets that were being used by
Settings.
Screenshot: https://screenshot.googleplex.com/7AEEb5TLGh2BXnz.png
Fixed: b:285025759
Change-Id: I5995b3039cd50953b3fc8ab9a2dc5b8c545e1758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622087
Auto-Submit: Gordon Seto <[email protected]>
Commit-Queue: Theo Johnson-kanu <[email protected]>
Reviewed-by: Theo Johnson-kanu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159096}
[Omnibox] Fix ZeroPrefixFocusType histogram name
The code uses ZeroPrefixFocusType but the xml does not match. Rename the
xml to match.
Bug: None
Change-Id: I758310388a72ff1761762335bcabcc512c5a3fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622249
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159095}
Add the ability to disconnect DOM Parts
This turns out to be important, at least in the case of writing
tests. `disconnect()` is a one-way operation; there's no way to
re-connect a part to its part root.
This CL also adds the constraint that NodePart can't have child parts.
It therefore adds exceptions to the constructors for NodePart and
ChildNodePart in the case that a NodePart is supplied.
Bug: 1453291
Change-Id: Ied398c417b1e105c77a95c3836ee2d09902df7c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617275
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159094}
[Chrome Refresh] update the colors and iconography of profile menu chip -
1. Add new colors and background colors for profile menu chip.
2. Refactor the color blending logic from the the toolbar_button to the color mixer to make the toolbar code more readable.
3. Update the iconography for incognito and guest mode.
Bug: 1399947
Change-Id: I125955e32f1b0fd709ccc219f5944006ad5b8360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599020
Commit-Queue: Shibalik Mohapatra <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159093}
Only query unclustered visits when updating triggerability if it is likely that there are actually unclustered visits
Right now, this should only be for users who have typed url visits being synced or new bling visits since context clustering is rolled out for non-iOS.
Bug: 1358237,b:276488340
Change-Id: I91019228e60420681d081173ce0cd36ebb8968e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621091
Reviewed-by: manuk hovanesian <[email protected]>
Commit-Queue: Sophie Chang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159092}
Measure CompositorLatency for IPC and Threading
Add new metrics that measure the IPC and threading delays that affect
frame production.
- From viz::BeginFrameArgs::frame_time to dispatch
- IPC of dispatch to arrival in the Renderer
- Posting of BeginMainFrame to running it on Main
- Total latencies of these
Bug: 1444050
Change-Id: I802a1488a1a267759ae86fecf29b6d4a20d06ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605931
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159091}
CrOS Settings: Convert date time page browser test to TS
Additionally, moved the test under the `date_time_page/` folder to
mirror the app folder structure.
Bug: b/270728282
Test: browser_tests --gtest_filter="*DateTimePage*"
Change-Id: I45c8578e46ade697a5cd80d94fbd980ed9ee7c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619098
Reviewed-by: Wes Okuhara <[email protected]>
Commit-Queue: Ruma Kesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159090}
Add SwitchAccessTestUtils and use in a Dictation test
This change factors out Switch Access logic from
SwitchAccessBrowserTest into SwitchAccessTestUtils, then uses the new
class to write a Switch Access with Dictation test.
Bug: b:259353214
Change-Id: I395e992c2ecfa1dfa863393a4404889552c65fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616815
Commit-Queue: Akihiro Ota <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159089}
[serial] Allow granting persistent permission to Bluetooth devices
Bug: b/276945831
Change-Id: I1b4eaead8b02b30d9583c91bde7347bfab6346c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609200
Reviewed-by: Matt Reynolds <[email protected]>
Commit-Queue: Jesse Melhuish <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159088}
[Glanceables] Create classroom list selector and item views
For the classroom glanceable, create the list selector which shows a
dropdown to be used for selecting the list of assignments to show.
Also create a WIP barebones GlanceablesClassroomItemView which displays
the assignment information on a single label.
Low-Coverage-Reason: The added ToString() function is for debugging.
Bug: b/283371050
Change-Id: Ifddfe2ee675b78519c67f452450a6a0b5316ec47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611891
Commit-Queue: Matthew Mourgos <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159087}
Migrate all tests on Linux Chromium OS ASan LSan Tests (1) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I4c4f668f721db0ac9ff747741b1dd6b93ed184dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622250
Commit-Queue: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159086}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686927570-514fd42c65b09a7fa52b4f6277c42f85abef41a8.profdata to chrome-win32-main-1686938378-677e23f517741a29bfb2efd7409c0dbe4942cccf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I154a27b68c480c67d684f9341c0f12abe2901d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621437
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159085}
Migrate android-pie-arm64-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I2e080834b8ea7d85969838e73063bcfaf8184a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621646
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159084}
Migrate all tests on linux-blink-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I003c1337492d5569e9754db1458453c5452fe303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621598
Commit-Queue: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159083}
Migrate all tests on linux-ubsan-vptr to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I9aac1d6adde8b10163b93a355764950df52d58ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621852
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159082}
[FedCM] Also accept non-IDP specific header
This gets us more in line with the login status API.
It also lets us accept additional tokens after the status=signin prefix.
Specifically this will make this header work:
Signin-Status: action=signin; type=idp
Signin-Status: action=signout-all; type=idp
[email protected], [email protected]
Fixed: 1410314
Change-Id: Ia310e57f604423dba51eef159895732e6b1eaa65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621592
Commit-Queue: Nicolás Peña <[email protected]>
Auto-Submit: Christian Biesinger <[email protected]>
Reviewed-by: Nicolás Peña <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159081}
[Color correction] Adds settings test for changing filter type
For better test coverage, adds test for changing the filter type
and of the default filter type.
Test: New
AX-Relnotes: N/A
Bug: b/259372272
Change-Id: Ic08d3b9d90c1978f0e52321dd260b0f85343d712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616541
Reviewed-by: Josiah Krutz <[email protected]>
Commit-Queue: Josiah Krutz <[email protected]>
Auto-Submit: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159080}
Send color information to Lacros
On an update to NativeTheme, sends the color seed to lacros over mojo.
Only sends seed color and scheme variant if Jelly is enabled.
Bug: b:285907359
Change-Id: Iea76369703bccb236c6b3177cdb835997e363a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605754
Reviewed-by: Stefan Kuhne <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Connie Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159079}
Add enterprise content analysis flags to chrome/test/BUILD.gn
This CL replaces relevant conditions in chrome/test/BUILD.gn with the
new flags added in crrev.com/c/4609067, and should be a no-op with
regards to existing Chrome behavior.
Bug: b/283093731
Change-Id: I8eb40c15e028ea5596023754679d287f24e5f9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619732
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159078}
Move most/all junit tests on swarming to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
Bug: 1412588
Change-Id: I05f7f09a7be0fa7885f49953e4dc332dc68f1438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621641
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159077}
Roll ios_internal from a6f6e8e0bbba to 9511541dce12
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/a6f6e8e0bbba..9511541dce12
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I2b81ceaadb8247a5b243555ba17536692edf06ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621375
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159076}
Update caption settings page UX
This CL updates the caption settings page with the following changes to
reflect the latest UX proposal:
- Update the Live Translate subtitle string.
- Update the style of the "Translate to" label.
UX Deck: http://go/live-translate-directional-review
Bug: 1426899
Change-Id: I8f017c178d722780e76d492726d9c87d1fd9edf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619107
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Evan Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159075}
Roll Catapult from c8efd30d90fc to 32db29fcb8ad (2 revisions)
https://chromium.googlesource.com/catapult.git/+log/c8efd30d90fc..32db29fcb8ad
2023-06-16 [email protected] Remove handler callback function and allow to pass job_id for testing purposes.
2023-06-16 [email protected] Replace network_isolation_key key usage in NetLog viewer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1419903,chromium:1435397
Tbr: [email protected]
Change-Id: I545b6e5aba395681fd3cfe260fe559e83ecaaa9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621371
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159074}
Reland "[task] Add UseUtilityThreadGroup to testing config"
This is a reland of commit 80a6172a093834840dc618e74fc00e3fee74ac2c
Now along with
V8ConcurrentMarkingHighPriorityThreads + V8ConcurrentSparkplugHighPriorityThreads
Original change's description:
> [task] Add UseUtilityThreadGroup to testing config
>
> Bug: 1366240
> Change-Id: I27687151a33768dfae700969e0ad347ed6d82de4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300418
> Reviewed-by: Gabriel Charette <[email protected]>
> Commit-Queue: Etienne Pierre-Doray <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1114724}
Bug: 1366240
Change-Id: I37bacb1e4b05590ddd395177bf819e84abe5d380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4342013
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159073}
Run junit tests with a thread executor pool.
Right now this shouldn't change anything performance wise as the max_workers is equal to
num_shards, but in the future, num_shards could be more than
max_workers.
Bug: 1383650
Change-Id: Iccd91c40e54990d794894189543d848806e8f98f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604684
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Benjamin Joyce (Ben) <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159072}
Update V8 to version 11.6.186.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8476ea9e..8e4265b3
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ib5450248619661dee0cf30f1f46ae8a74063608e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615701
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159071}
[ios] Don't use N32 for copy output requests
Since N32 will ultimately result in using BGRA (which isn't always
supported), we force RGBA on iOS.
credit: thanks to vasilyt@ for pointing out our use of N32 in
skia_render_copy_results.cc as the source of some unwanted
swizzling.
Bug: 1411704,1413706,skia:14389
Change-Id: I21e424c23d59f26707c9668eef8b858484eb4be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618712
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159070}
[Android] Fix callback count in PermissionTestRule
We're counting callbacks that were received before the window in which
a callback are expected.
Disabling two tests revealed to be broken as a result of this change.
Bug: 1454610
Change-Id: Ie9b5b7b640c8108c359873facf56eda19319c3fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607548
Reviewed-by: Elias Klim <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Reviewed-by: Ella Ge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159069}
[PPAPI] Remove assertions on plugin behavior.
The browser is not in control of plugin behavior so should not be
asserting based on it.
This converts the assertions in ppapi/host that are dependent on plugin
behavior to DLOG(WARNING).
Bug: 1454928
Change-Id: I93be0e668579acff8a66145fb4047c0021717039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615554
Reviewed-by: Derek Schuff <[email protected]>
Commit-Queue: Brett Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159068}
Manual raw_ptr rewrite: cc/raster/scoped_grcontext_access.h
This is a partial / single-file reland of https://crrev.com/c/4548763.
More granular CLs will hopefully help pinpoint which of the changes in
the original CL is responsible for the performance regression.
Bug: 1448053, 1446392
Change-Id: I77d0ae63b433544bafda548ec65d86cc3c58d9ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582609
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159067}
Migrate fuchsia-fyi-x64-asan to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ic219816a65b52e2d97f38d995b978a9d95da4c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621636
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159066}
Refactor PrintViewManagerBase::PrintNow()
Split many checks PrintNow() does into a separate StartPrintCommon()
helper method. The helper method will be used in an upcoming CL to avoid
duplicating code.
Change-Id: Ib7f8acde8bc0f0b7f271af806aeaaffc360b603f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616791
Reviewed-by: Alan Screen <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159065}
[CSC] Make CSC Icon monochrome
This also automatically adjusts the icon based on theme.
Bug: b:285354398
Change-Id: I3db533f330a527c1c1f98d510436110b41483ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618845
Auto-Submit: Duncan Mercer <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Commit-Queue: Duncan Mercer <[email protected]>
Commit-Queue: Ali Stanfield <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159064}
Convert the first run dialog to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: I58fba70833c78079ec946bf06cbe65f35b42ccdc
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621547
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Code-Coverage: Findit <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159063}
Add ignore_native_libraries=true to androidx_benchmark_benchmark_common
Will hopefully fix autoroller.
Bug: 1455158
Change-Id: I89b8ba3ac0a1094f3972cd9d898f36178fc76246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621594
Reviewed-by: James Shen <[email protected]>
Commit-Queue: James Shen <[email protected]>
Auto-Submit: Andrew Grieve <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159062}
Add google-sharing tag to SafeBrowsingProtectionLevel policy
As noted in the policy description, the policy setting does impact
sharing with Google, so it should have the google-sharing tag.
Change-Id: I78f2e2a0b71da2b60e1b92f295fdc680582a84ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615696
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: thefrog <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159061}
[infra] Set ACTIVE_MILESTONES to an empty dict on branches.
Currently on branches, the value of ACTIVE_MILESTONES reflects whatever
milestones were active at the time the branch was created since
milestones.json is not kept up-to-date on branches. This requires using
branch logic when working with ACTIVE_MILESTONES where its value is of
dubious utility. This changes it so that ACTIVE_MILESTONES is defined to
an empty dict on non-main projects. There aren't any actual issues to
address in the chromium project, but this keeps it consistent with the
chrome project.
Change-Id: I7587f2183f820613b748586d01317d3e2abb5afd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618023
Commit-Queue: Struan Shrimpton <[email protected]>
Auto-Submit: Garrett Beaty <[email protected]>
Reviewed-by: Struan Shrimpton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159060}
Roll src-internal from dc11bdee17e9 to 63351072c0b9 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc11bdee17e9..63351072c0b9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I601602eeda07ffb8ea79ae01f8eaca7eb16cb9c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621152
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159059}
webview: Remove BadRequest histogram
This was being used because we noticed a bunch of metric service status codes
were reporting HTTP 400s.
Details of the results are noted in the crbug.com/1430682
The over whelming results were due to unknown platform results.
This means we need to find out what undocumented status codes could still be reported.
We don't try to reupload metrics in this case
so the main issue is it is swaying our results.
We should either separately find out if there is more
status code documentation or follow up with a
metric to log the unknown status codes.
We should follow up on this if we end up launching the status codes.
OBSOLETE_HISTOGRAM[Android.WebView.Metrics.BadRequest]=No longer needed; Was used for a temporary investigation to see where HTTP 400 status codes were coming from.
Bug: 1430682
Fixed: 1447641
Change-Id: I6ad6944bf97bd752c8a2a57bfca0f4941697b7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614555
Auto-Submit: Rupert Wiser <[email protected]>
Reviewed-by: Luc Nguyen <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: Luc Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159058}
[Extensions] Clean up test classes in FileSystemChooseEntryFunction.
This function had a series of classes to manage setting and resetting
testing options that relied on global variables and obscured what was
actually happening.
This CL changes this to use an explicit test struct with options
that can be initialized in the test. It then uses base::AutoReset
to set and reset the static pointer to the test struct. This is
much cleaner and clearer than the current code.
Bug: n/a
Change-Id: I6311aec3fa5bb43de82549a66700a00129dbc5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609708
Commit-Queue: David Bertoni <[email protected]>
Reviewed-by: Tim <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Auto-Submit: David Bertoni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159057}
Add part caching and ordering to DOM Parts
Previously, parts were added to the list, and returned, in the order
they were constructed for a given root. Now, that list is stored as
an unsorted list, and when `getParts()` is called, a cached, sorted
list is returned.
NOTE: This CL does not add cache invalidation code where needed, so
moving nodes around in the DOM tree will not invalidate the cache.
Cache invalidation will be added and tested in a subsequent CL.
Bug: 1453291
Change-Id: I542b07520002202bfdc31d4341dca6cbffdc8b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616676
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159056}
Add metrics for new System (Anchored) Nudges
- Reuse the existing Nudge Catalog instead of creating a new one.
System Nudges created through the new AnchoredNudgeManager will replace
the existing `SystemNudge` class, but will keep its name and metrics.
More context in: go/system-nudge-v2
- Record `ShownCount` and `TimeToAction` metrics for new nudges.
go/notifier-framework-metrics
- Call `MaybeRecordNudgeAction` for VC applicable nudges.
This function records the time range it took to execute the suggested
nudge action. (e.g. unmuting after speak-on-mute nudge was shown).
Bug: b:280309972
Change-Id: I1cce0906a3cba32d03024331afa17c8a8096df94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609474
Reviewed-by: Pu Shi <[email protected]>
Commit-Queue: Kevin Radtke <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159055}
Roll Skia from a4ad5b369313 to 3e3cdb378f5d (2 revisions)
https://skia.googlesource.com/skia.git/+log/a4ad5b369313..3e3cdb378f5d
2023-06-16 [email protected] Reject first-class arrays on initializers in strict-ES2 mode.
2023-06-16 [email protected] Use IRHelpers class to assemble matrix-multiply workaround.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Ic7fdba023da752192c90aa06bd04d8ead8a049b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620261
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159054}
[Chrome Refresh] Add remaining page action icons -
1. Reader Mode
2. Price Tracking
3. QR Generator
Bug: 1399991
Change-Id: I603ff0637fc145a923f0d8a449da1d0815d3b6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619372
Commit-Queue: Shibalik Mohapatra <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Khalid Peer <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159053}
Add a bit more crash logging to MmapHashPrefixMap::FileInfo::Matches
Bug: 1409674
Change-Id: I4a84cad081b7ad54f886f2c76b86110fd3ebc550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621108
Commit-Queue: Daniel Rubery <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159052}
IndexedDB: fix WPT that inverted array/element in expectation
assert_in_array had the parameters inverted.
Bug: 1412571
Change-Id: Ib35ea2a9dce773f4d1fd578f90e14d7c43be8230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621867
Reviewed-by: Nathan Memmott <[email protected]>
Auto-Submit: Evan Stade <[email protected]>
Commit-Queue: Nathan Memmott <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159051}
[iOS] Allow some focus events to trigger on empty fields only
For the Payments Bottom Sheet feature, the bottom sheet is only
allowed to appear if the triggering field is empty, so this CL
adds the required logic to allow listeners to choose whether
focus events on non empty fields should be ignored or not.
Bug: 1450214
Change-Id: I2d582cbe74ce5ac1279c55749f7e8092a9aab608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615168
Commit-Queue: Alexis Hétu <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159050}
Only include ppapi examples when ppapi is enabled
As of crrev.com/c/3835046 builds that do not enable nacl will fail
because ppapi will not be enabled. This CL fixes the problem by
checking for ppapi being enabled before adding data deps from ppapi.
Bug: 702990
Change-Id: Ibb8fa343a7cb30252058ca16c7b0b109b9f77ce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621092
Reviewed-by: Bruce Dawson <[email protected]>
Reviewed-by: K. Moon <[email protected]>
Commit-Queue: Colin Kincaid <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159049}
[Android] testDenyRuntimeDownload uses @MaxAndroidSdkLevel
Since the test is not expected to run above Android Q, change
@DisableIf (which is for temporary failures, flakiness, intended to be
fixed) to @MaxAndroidSdkLevel.
Bug: 1195097
Change-Id: I6a0bad9bf864f1168d36bdbd85d350f60c98568c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606727
Commit-Queue: Henrique Nakashima <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159048}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686927570-b6b8ae5a461ffed14500469d89ef545e83cac495.profdata to chrome-win64-main-1686938378-2b031e88c379891d9f63e2b6d5ecb3a07744bbcf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Ia4469601f92ccb6847b73c5ecc00fb9c06bb1464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621511
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159047}
Multiplanar: Add UMAs for hardware/software GMBs OutputFormat
Previous Media.GPU.OutputFormat UMA logged the OutputFormat but was
then possibly unused/modified later in
GMBVideoFramePool::CreateHardwareFrame. This change adds new UMAs
closer to the point of GpuMemoryBuffer and SharedImage creation logic
thus making it clearer which format is used for creating a shared
image with shared memory backed GMBs or hardware GMBs. Also will
delete the previous UMA it once we have fresh data from new UMAs.
Bug: 1429001
Change-Id: Ic1fa47bf41b8b04878076da20d6d650fc492e0eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615936
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Saifuddin Hitawala <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159046}
[DownloadBubble] Update when downloads with ephemeral warnings disappear
Downloads with "ephemeral warnings" should disappear from the bubble
after 5 minutes. Before this CL, this behavior only kind of works:
if the bubble is opened after the 5 mintues have passed, the item is
correctly omitted from the bubble. However, the toolbar button state is
not properly updated, so if the only downloads in your history are
expired ephemeral warning downloads, the toolbar button may still be
visible but clicking on it does nothing.
This fixes that by scheduling a task to update the info in the
DownloadBubbleUpdateService and notify all relevant windows that the
toolbar button state should be updated.
Bug: 1452189
Change-Id: Iaaed19410d2ce048ccfc7fa3a3723e8cd49d50be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614454
Commit-Queue: Lily Chen <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159045}
Roll Chromite from 8885dfd037a9 to 21f3bce301bf (27 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8885dfd037a9..21f3bce301bf
2023-06-16 [email protected] cros-ide: metrics: migrate metrics.send callsites in coverage
2023-06-16 [email protected] cros-ide: Update cros-ide in our README
2023-06-16 [email protected] cros-ide: Update cros-ide's in error message
2023-06-16 [email protected] cros-ide: Update cros-ide in ids that don't appear in package.json
2023-06-16 [email protected] cros-ide: Update cros-ide in bg_task_status
2023-06-16 [email protected] cros-ide: Rename cros-ide.chromium.src-uris
2023-06-16 [email protected] cros-ide: Rename cros-ide-gerrit
2023-06-16 [email protected] cros-ide: Rename cros-ide.chromium.outputDirectories
2023-06-16 [email protected] cros-ide: Rename cros-ide-status
2023-06-16 [email protected] cros-ide: Rename cros-ide.chrootPath
2023-06-16 [email protected] cros-ide: Update command names for related files
2023-06-16 [email protected] cros-ide: Update command names for chromium
2023-06-16 [email protected] cros-ide: Update command names for show help
2023-06-16 [email protected] cros-ide: Update command names for gerrit
2023-06-16 [email protected] cros-ide: Update command names for coverage
2023-06-16 [email protected] cros-ide: Update command names for feedback and metrics
2023-06-16 [email protected] cros-ide: Update command names for codesearch
2023-06-16 [email protected] cros-ide: Update command names for boards and packages
2023-06-16 [email protected] cros-ide: Update command names for device management
2023-06-16 [email protected] cros-ide: Update command names for chrome
2023-06-16 [email protected] cros-ide: Fix a config name for related files
2023-06-16 [email protected] cros_vm: Add cros vm.
2023-06-16 [email protected] api: Fix type hints in sdk controller.
2023-06-15 [email protected] lib: Catch overlooked exception
2023-06-15 [email protected] utils: set service name to chromite for telemetry
2023-06-15 [email protected] lib: cros_sdk_lib: partial revert of --skip_chroot_upgrade cleanup
2023-06-15 [email protected] utils: add enable param to telemetry initialize
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome
Tbr: [email protected]
Change-Id: I7c3e871fb800effcd6da36fb8a308fad73fd7da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618746
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159044}
storage: remove no-op file_stream_{read,writ}er_test.cc
Its names are declared "static constexpr" in their .h files.
BUG=None
TEST=CQ
Change-Id: I7b794f37ddd74cb1d7d219452027d6aae2df9f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618311
Auto-Submit: Nigel Tao <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159043}
[omnibox][cr23] Enable 2 chromeOS tests that were temporarily disabled.
- AccessibilityHighlightsBrowserTest.CaretHighlightOmnibox
- PDFExtensionJSTest.AnnotationsFeatureEnabled
Launching SS height broke these 2 tests on chromeOS. crrev.com/c/4603697
disabled them. Later CLs partially fixed them. This CL hopefully fully
fixes CaretHighlightOmnibox and reenables the tests.
Bug: 1453993, 1453711, 1454196
Change-Id: I636acc5d7e3f6a31b12e913e24c9b76ea5d6e65b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617033
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159042}
Remove preconnect on hover events.
Preconnecting on hover events should not be done if the link is not safe
to prefetch or prerender.
Bug: 1374023, 1454995
Change-Id: I68230dae010e8d781aad52a5830eb37e3c50f7bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617037
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Iman Saboori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159041}
Enforce a short minimum time in android fullscreen pip
Android can be left in a bad state if on enters pip via fullscreen
and exits immediately afterwards, such as if the site calls
`document.exitFullscreen()` when it gets a pip event. By waiting
a few dozen milliseconds before dismissing pip, it seems to avoid
the framework bug.
Separately, there will probably be an AOSP fix, but chrome needs
a workaround since the bug exists in at least T.
This CL only attempts to fix fullscreen-pip, rather than API-pip,
since I don't have any instances of that being broken.
Bug: 1421703
Change-Id: I57a75431c817e3331786388104065a075671cf44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606006
Reviewed-by: Ted Choc <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159040}
[PDF OCR] Add an ARIA landmark around the status node
The status node notifies the user of the PDF OCR status, and it's
important to ensure that the user can navigate to this message easily,
and so cannot accidentally miss them.
According to the ARIA specification, a "banner" landmark can be used to
define a global site header and possibly the global navigation, which
helps to achieve the objective of this CL.
AX-Relnotes: n/a.
Bug: 1393069
Change-Id: I806a4d849a17bd0aff32bc1d7acee4f098b1cb66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618834
Reviewed-by: Ramin Halavati <[email protected]>
Commit-Queue: Kyungjun Lee <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159039}
base/time: Fix typos in comments
Change-Id: I97f858ff026c43e52c803e1bd3620ab59111fbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619768
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159038}
Roll WebRTC from 18aba6627174 to 4d2a21943684 (1 revision)
https://webrtc.googlesource.com/src.git/+log/18aba6627174..4d2a21943684
2023-06-16 [email protected] Change RTCPReceiver::GetAndResetXrRrRtt to return TimeDelta
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I580adb0cf523aa69befe8728a39618ab923abf5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621250
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159037}
Reduce std::unordered_map churn in V4Store
This makes a couple of reserve() calls and adds an at() interface to
HashPrefixMap to avoid copying a map from which only a single value is
extracted.
Bug: None
Change-Id: I1797bb9f4c6c3c319af79de44b3c1b4da1eb5b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621489
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159036}
Catch playback startup failures in GPU tests.
R=bsheedy
Bug: 1455455
Change-Id: I275d0654abe80ac8f2355e635894d6488733b93c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621329
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Auto-Submit: Dale Curtis <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159035}
Roll devtools-internal from 4087b95783a4 to 28a4e9848422 (2 revisions)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/4087b95783a4..28a4e9848422
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3f5c003793e7a6a13b2c3a7e3fb7fa778e5c8443..13847ed879863874653ce1c1f9d0109bef3d3a42
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I8f0f3efad2d77bf1b9bf073416b0a697b7adc91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621990
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159034}
Fix mistake in autofill branding field trial config
Change-Id: I9becba57d7e08bd5fe9b316ca09e0285e9448694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619694
Auto-Submit: Ginny Huang <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Commit-Queue: Ginny Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159033}
Skip local fonts with invalid attributes during font enumeration on Mac.
It seems Mac OS allows installing fonts with invalid attributes although
the font verification during install detects it. Updated the local font
access code on Mac to skip such fonts during enumeration when Chrome
receives null for the attributes from Mac OS.
Bug: 1422669
Change-Id: Idbf164ccfb2306de2705b5f8eca4a68efb312d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596377
Commit-Queue: Hakan Isbiliroglu <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159032}
[Code Health] Remove some expired histograms
Remove the following expired histograms and the code that uses them:
- ChromeOS.Apps.ExternalProtocolDialog (expired as of 2022-05-21)
- ChromeOS.Apps.ExternalProtocolDialog.Accepted (expired as of
2022-05-21)
- ChromeOS.Apps.OpenBrowser (expired as of 2022-05-21)
Bug: 1447172
Change-Id: I3d853f2e3e9e36c43ac59eacae668ceec7d23232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619110
Reviewed-by: Tim Sergeant <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Nigi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159031}
Roll R8 from vw5kLlW3-suSlCKSO... to k5TJLb8-vIKBO1aZT...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Change-Id: If6cbcd85d568fb7f42aaaabae3bd679e29214ddb
Bug: 1455475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618740
Reviewed-by: James Shen <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159030}
[Frameworks roll] Roll to 540955154 piper revision
Change-Id: I39f37f0648222efaa099233b4ae3bfd3b81e2f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622207
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159029}
Lacros SDK: Update version 15502.0.0
This CL updates the lacros_sdk_version. This cl only affect
Lacros on-device config builders like lacros-amd64-general-rel,
or ash-chrome builders.
This cl will certainly NOT affect linux-lacros builders
(linux-lacros-tester-rel, linux-lacros-rel, etc) or any
other platforms.
In case the generated cl has issues, please file a bug
to OS>LaCrOS>Partner, and CC [email protected].
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-arm-generic-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-arm64-generic-chrome-skylab
[email protected], [email protected]
Bug: None
Change-Id: Idc3b85402bfcee78f45ca2cc5f3fe1f3cc1d82f7
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615937
Commit-Queue: Sven Zheng <[email protected]>
Reviewed-by: Sven Zheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159028}
[CR2023] Download bubble typography
Update labels typography per spec.
Bug: 1422125
Change-Id: I9606715cbf55386905993967e9f3c31fb592b057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618056
Auto-Submit: Keren Zhu <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159027}
Enable Rust on Windows bots
This enables some Rust smoke tests, but no Rust into the chrome
build.
This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/4594595
We don't enable on Win ARM64 when code coverage is enabled due to
missing the clang_rt.profile library (https://crbug.com/1453618).
But we also have no bot that covers that config anyway at the
moment.
[email protected]
Bug: 1271215
Change-Id: I387a5b7ef2c90741748ff1468846e7d569f2d37e
Cq-Include-Trybots: luci.chrome.try:win-chrome,win-branded-compile-rel
Cq-Include-Trybots: luci.chromium.try:win-updater-try-builder-rel,win-updater-try-builder-dbg,win-swangle-try-x86,win-swangle-try-x64,win-swangle-try-tot-swiftshader-x86,win-swangle-try-tot-swiftshader-x64,win-swangle-chromium-try-x86,win-rust-x64-rel,win-rust-x64-dbg,win-rel-cft,win-rel,win-presubmit,win-fieldtrial-rel,win-libfuzzer-asan-rel,win-dawn-rel,dawn-try-win-x86-intel-exp,dawn-try-win-x64-intel-exp
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605770
Reviewed-by: Adrian Taylor <[email protected]>
Commit-Queue: danakj <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159026}
WebUI: CrOS Settings: Update cellular to omit pending profiles
This CL disables all logic for the pending profiles for eSim
when the isSmdsSupportEnabled feature flag is enabled.
Bug: b/278134215, b/278134136, b/278134134
Test: browser_tests --gtest_filter="*CellularNetworksList*"
Manual UI verification from Linux build
Screenshot without flags: https://screenshot.googleplex.com/4wuAHaz6QLRoTrk
Screenshot with flags: https://screenshot.googleplex.com/8DGJAfCzEeMCfYa
Change-Id: Ic1bec8e5490aba1d5d7210aeba671307579a6ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609220
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Chad Duffin <[email protected]>
Commit-Queue: Michael Rygiel <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159025}
[Android] Cleanup obsolete filtered tests
Remove no-op filters. These tests have either been deleted or have
changed names. The ones that changed names are not flaky anymore.
Bug: 1193814,1059046,1060724,1231219
Change-Id: I19f2e7a22636825cf375453bb2590420be619429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619097
Reviewed-by: David Maunder <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159024}
Zero out counts_ref when allocating a histogram on persistent memory
Bug: 1432981
Change-Id: I677745e8ed0fa7aa1c5347ed3b1910346bd326b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622028
Commit-Queue: Alexei Svitkine <[email protected]>
Auto-Submit: Luc Nguyen <[email protected]>
Commit-Queue: Luc Nguyen <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159023}
[CCT] Re-enable CustomTabActivityTest#testNoMayLaunchUrlWithInvalidScheme
No longer flaky as per: https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fchrome%2Fandroid%3Achrome_public_test_apk%2Forg.chromium.chrome.browser.customtabs.CustomTabsConnectionTest%23testNoMayLaunchUrlWithInvalidScheme
Bug: 1333218
Change-Id: I556bac4d36356acacb7f8a1a939e687f35203348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621868
Reviewed-by: Zach Katz <[email protected]>
Commit-Queue: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159022}
[Gardener] Disable flaky TabSwitcherAndStartSurfaceLayoutTest
Bug: 1455473
Change-Id: I8deb2c8140c5acc9c09aeeb7e2b0dbf5c8e5c978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621591
Auto-Submit: Wenyu Fu <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159021}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686916746-09b7af15a61678b00a2a57b4a73a05cecbae171a.profdata to chrome-linux-main-1686938378-6b221e60f898021c43a0a477ad2447583e4ef0a7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ib60efd45d7db9f2e2b7d24e348193380f403ba91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621436
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159020}
Roll Media App from 0YfAUIU49CI1VJogg... to rLMvnsUP0a_0FDf2r...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202306160800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rLMvnsUP0a_0FDf2rmkKjcfO-JNNX-nYvOXoWJ9ev3MC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/280003104,b/285227963,b/287571506
Tbr: [email protected]
Change-Id: I2569e6bae0854fb13c65119d505e65e39bfc5178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620847
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1159019}
Bookmarks++: Don't scroll iron-list on tab change
Bug: 1455490
Change-Id: I02a71ae52022fa9326ac93f040d1a2c083fcfbe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621153
Commit-Queue: Emily Shack <[email protected]>
Auto-Submit: Emily Shack <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159018}
Increase HangWatcher shutdown coverage
This CL is increasing the coverage of the Shutdown HangWatcher.
A leaky HangWatcher scope is created. It will cover hang detection
up to the end of the process.
Bug: 1454338
Change-Id: I23e8972c1b31d7998e83dbb821e12b1f19159a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606995
Commit-Queue: Etienne Bergeron <[email protected]>
Reviewed-by: Olivier Li <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159017}
[wptrunner] Fix `run_wpt_tests.py --child-processes`
The parameter was not transferred to wptrunner, so the parallelism for
desktop was always the core count.
Bug: 1426296
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel
Test: ./run_web_tests.py -t Default external/wpt/badging -j 1
Test: ./run_wpt_tests.py -t Default external/wpt/css/CSS2 -j 2
Change-Id: Icf3beb292000462be19f57f40bba45bf5032de0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615725
Commit-Queue: Jonathan Lee <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159016}
gamepad: Fix incorrect use of sizeof()
When receiving a report, RawInputGamepadDeviceWin::UpdateGamepad checks
which buttons were expected to be received in the report and first
clears the state of those buttons. The loop to clear the buttons
incorrectly uses `sizeof()` to find the size of the vector, which
(apparently) returns 12 for a vector, so the loop will only potentially
clear the first 12 gamepad buttons. On devices with more than 12
buttons, additional buttons are not cleared unless the device is
disconnected and reconnected to the system.
To fix this, use std::vector::size to return the number of elements.
Bug: 1455510
Change-Id: I7b79a756ddbd38e6d16a44c07a29b89d54c3f1b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621416
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Matt Reynolds <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159015}
Fix (hopefully) JDK 3pp install.sh bad escaping
Bug: 1441023, 1455484
Change-Id: Iaa608268bb393faa06bd627c643b9f623999cb2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621847
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Reviewed-by: James Shen <[email protected]>
Commit-Queue: Mohamed Heikal <[email protected]>
Auto-Submit: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159014}
Mark fixed-z-index-blend.html flaky
Example failure: https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/779/test-results?q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fcss%2Fcss-position%2Ffixed-z-index-blend.html+VHash%3Ad66f84fc0745c58a
No-Try: true
Bug: 1429309
Change-Id: If10ac573e5e67adedd065d16ea0787086c81e902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621510
Auto-Submit: Reilly Grant <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Commit-Queue: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159013}
CSC: Class that performs classification + eligibility.
Bug: 284645622
Change-Id: Idda268bac9835212e1e634fb5183d02e29cae4b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615458
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Lily Mihalkova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159012}
IWYU in ipc_fuzzer
This is an attempt to fix a broken build with no clear culprit.
https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-on-arm64-rel/74603/overview
No-Tree-Checks: true
Change-Id: I8d7614c977803572e669a11a5039339fd50e2054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621093
Commit-Queue: Kevin McNee <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Auto-Submit: Kevin McNee <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Owners-Override: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159011}
infra: Delete the '1mbu' experimental CQ builder
It's been running for 2 years, seemingly without much value.
So this shuts it down. Can be restored if the effort is picked back up.
Bug: 1199853
Change-Id: I960606d21a14c14fb4d632e48057d0dba5ab8a6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616090
Commit-Queue: Ben Pastene <[email protected]>
Reviewed-by: Erik Staab <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159010}
[Omnibox] Put ScrollToTLD prefix checking behind flag
Putting behind ScrollToTLDOptimization flag to cherrypick to stable.
Bug: 1432727
Change-Id: Iaa640218dcb5745eabf810311803a82682beb05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618330
Reviewed-by: Ted Choc <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Peilin Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159009}
[Omnibox][ML] Add elapsed time in days signals for scoring.
Bug: b/287323548
Change-Id: I91a3df1e321df98bc1ebc9feb5eb57ee55c1c86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616948
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Jun Zou <[email protected]>
Reviewed-by: Michael Crouse <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159008}
docs: webui_build_configuration: add missing option
Other sections in here refer to this one for the meaning of
resource_path_prefix, but never actually documents it.
Bug: b/284974354
Change-Id: I4b880f3ac698e38953b62b28c432e22cdee02c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605236
Reviewed-by: Cole Horvitz <[email protected]>
Commit-Queue: Mike Frysinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159007}
Revert "JNI annotation processor -> srcjars (batch 1)"
This reverts commit 541a7aa80e5220780d1f0f67abe63d4628c8036b.
Reason for revert: Suspecting for build failures. See https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-rel/33216/overview
Original change's description:
> JNI annotation processor -> srcjars (batch 1)
>
> * android_webview/BUILD.gn
> * android_webview/glue/BUILD.gn
> * android_webview/test/BUILD.gn
> * mojo/public/java/system/BUILD.gn
> * net/android/BUILD.gn
> * services/device/public/java/BUILD.gn
> * testing/android/native_test/BUILD.gn
> * ui/android/BUILD.gn
> * url/BUILD.gn
> * weblayer/browser/java/BUILD.gn
>
> Bug: 1410871
> Change-Id: Ib87fcdc30208552d65f6adbfee16ca6c5f1bd2e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616415
> Commit-Queue: Andrew Grieve <[email protected]>
> Reviewed-by: Sam Maier <[email protected]>
> Owners-Override: Andrew Grieve <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158973}
Bug: 1410871
Change-Id: Ia18dde59b64920b10aefdca1aafd72a60e84c8c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621593
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Kevin McNee <[email protected]>
Owners-Override: Kevin McNee <[email protected]>
Auto-Submit: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159006}
WebUI: CrOS Settings: Remove generic icon and profile provider name
New UI: https://screenshot.googleplex.com/3JwNXzrKT2ALsAa
Bug : b/282058720 (b/287265694, b/287265246)
Change-Id: Ic405fcc613fcfefc36542a78bd38fe2abf425863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609190
Commit-Queue: Saphia Petard <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Chad Duffin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159005}
Derive enable_ppapi from enable_nacl
Enables PPAPI by default only if NaCl is enabled, as NaCl is the only
PPAPI user left.
This requires removing the ppapi_unittests step on bots configured with
enable_nacl=false; removes ppapi_unittests from the same configurations
that remove nacl_loader_unittests.
Bug: 702990
Change-Id: I7c2c13a8dbb282329cdce7aa85b33bba9bf4a12a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835046
Reviewed-by: Derek Schuff <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Reviewed-by: Wanda Mora <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159004}
[iOS] Updated tile ablation field trial version to disable it.
Updated the tile ablation field trial version to disable the experiment
for current users enrolled in a trial.
Bug: 1451582
Change-Id: I901732a1026e39e6087a5144712d8295b9120227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618335
Reviewed-by: Sergio Collazos <[email protected]>
Auto-Submit: Guillem Perez <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Commit-Queue: Guillem Perez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159003}
Disable AV1, HEVC tests on unsupported devices.
Fixed: 1455458, 1455455
Change-Id: Idfc83afe3e4aeee348c01cd8ca56938a5c62851a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621487
Auto-Submit: Dale Curtis <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159002}
Do not generate unnecessary swarming details for non-swarmed tests.
An absent swarming key in a test is equivalent to a swarming dict where
can_use_on_swarming_builders is absent or false. This avoids generating
them since they unnecessarily increase the verbosity of the targets spec
files. Similarly, merge scripts are only used when collecting a swarmed
test, so it's useless for the merge key to be set if the test won't be
swarmed.
Once all specs are regenerated, the recipe will be updated to treat the
presence of a swarming dict as the signal to swarm the test and the
can_use_on_swarming_builders key can be removed entirely.
Bug: 1268499
Change-Id: I01e44794718149f0c1204721859f0a54dda09ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619348
Commit-Queue: Garrett Beaty <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159001}
Android CCV/CRS: add a histogram to measure how long TrustStoreAndroid takes to run initialization
Bug: 1365571
Change-Id: Ide7acbfdde92b1c84b52874dd4b1e061a8d03bb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614359
Reviewed-by: Luc Nguyen <[email protected]>
Commit-Queue: Hubert Chao <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159000}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5836.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I40ddb44ce992ef62914ab3b38e08535a7ec0474c
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621129
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158999}
Migrate WebKit Linux ASAN to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ibaa2a783aca0190c2cc6a399cb761f98d8b7c085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621413
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158998}
Delete Clipboard Image tests from Search Activity test suite.
These tests don't really do anything useful, validating that:
- ClipboardSuggestion exists
- ClipboardSuggestion has non-null fields
- A Trusted Intent can open Chrome Tabbed Activity (which would
probably have some value, except none of the populated fields are
ever verified)
- Invoking search takes user to the default search engine page url,
"when possible" (listing examples where this is expected not to
work, and falling back to a general suggestion destination url).
Elements covered by these tests don't appear to be adding any value:
Clipboard content could be garbled / invalid, issuing intent could
completely ignore the supplied extras, and these tests, as they are,
are still flaky.
Change-Id: I5ac2b6e7532c77c71536d6a2d3a40a3eea0e1c25
Fixed: 1144676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621068
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158997}
[Android] Disable two flaky WebXrGvr tests on android-10-x86-rel
Bug: 1455242,1455244
Change-Id: I446fbf679582ad1570aa1b1c0320c6bf5db198d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617736
Reviewed-by: Alexander Cooper <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158996}
Mark no-clipping-overflow-hidden-hardware-acceleration.html flaky
No-Try: true
Bug: 1455487
Change-Id: I79b3387a849424db072f6664e9ae426b3a3715b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621488
Auto-Submit: Reilly Grant <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158995}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686923930-7d94735510ff5c2c3eb16a7c60818532d1c1c525.profdata to chrome-mac-arm-main-1686931180-847c2e91b512c0a16e40d755b5c90ceca91a17a8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I99f37f81cdbad761cf1ed2edd46b0075ef74ec36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619762
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158994}
[Browsing Data Model] Private Aggregation Data Model Implementation
This implements the Browsing Data Model DataKey structure as well as
the Get and Remove methods in a new public interface for Private
Aggregation API. This handles data relating to both budgeting and
requested reports. Integration with the BDM will be in a followup.
Bug: 1430775
Change-Id: I58faff2342dc08508c1b366a5fcd8481061e497c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4455777
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Thomas Quintanilla <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158993}
Status Area: Close calendar bubble when other tray bubble is open
Fixed: b:265383724
Change-Id: Ib60c2b24d9b20e5d089d23b7e572736f60d82f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615757
Reviewed-by: Kevin Radtke <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158992}
Migrate ASan Release (32-bit x86 with V8-ARM) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia37ba761691dfdf722de6cbfe94e256836fe2109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621411
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158991}
[Settings] Remove enabledDetailedLanguageSettings_ from basic_page.html
enabledDetailedLanguageSettings references have been removed from
basic_page.html/ts. Translate_page_test.ts and translate_page_metrics_
test_browser.ts no longer sets enableDesktopDetailedLanguageSettings to
true since it is defaulted to true and will be removed.
Bug: 1454930
Change-Id: I01d924d114824738458e1a7c375e857148174142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616794
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Andrea Gomez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158990}
[Gardener] Disable flaky DistillabilityServiceTest
Bug: 1455454
Change-Id: Iee409b70ee38844519181ab57075e64becf8f944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621747
Reviewed-by: Kevin Grosu <[email protected]>
Owners-Override: Wenyu Fu <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158989}
[reviver] Move coverage-runner to a 32-core bot
This is required to meet this job's resource requirements.
See linked bug for resource request.
This commit also sets ssd, free_space, and os dimensions
to match the targeted bots and reduces timeout to account
for a more powerful machine.
Bug: b/287241274
Change-Id: I6143300e208d9ec11478a9057d2e7ed0e6182fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614970
Reviewed-by: Ben Pastene <[email protected]>
Auto-Submit: Mateusz Zbikowski <[email protected]>
Commit-Queue: Mateusz Zbikowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158988}
Migrate mac12-arm64-rel-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie33a81f0f5ba875357d83b0a23998dc50bd08c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621888
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158987}
Clean up chrome://projector.
This cl cleans up chrome://projector and hosts
chrome-untrusted://projector directly in the main frame.
The tast tests associated with projector are being updated
to work with both app versions here: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/4549473
Bug: b/237337607, b/271126215
NO_IFFT: Updated the tast test file already.
Change-Id: Ib416900e2e97ddaf8730194c4e57134d11518a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4535095
Commit-Queue: Yilkal Abe <[email protected]>
Reviewed-by: Xiqi Ruan <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158986}
Refactor KeyboardEventManager
Bug: none
Change-Id: I5185bef6ed26855f183ee8d4ff9761a99387881b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614474
Commit-Queue: Randolf Jung <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158985}
Roll libcxxabi from c2a35d1b2cf4 to 8d21803b9076 (2 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c2a35d1b2cf4..8d21803b9076
2023-06-16 [email protected] [libc++][NFC] Consistently qualify malloc and free calls with std::
2023-06-16 [email protected] [libc++] Make libc++ and libc++abi's definitions of operator new be exact copies
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxxabi-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Ic2e442f1131bffd8b2644ac10a5c3bd66c421845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620260
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158984}
Adds an ARIA landmark around disclaimer messages surrounding OCRed text in PDFs
When OCR is perform on a PDF, there is a message before any OCR results
and one after, telling the user that the text is a product of OCR and
not part of the original PDF.
This patch adds ARIA landmarks around these messages in order for the
user to be able to easily jump to those messages and so not accidentally
miss them. Also, it updates the role of disclaimer nodes to be static
text, instead of status, to prevent users from getting unnecessary
updates coming from live region (i.e. "status" role).
Per the ARIA Specification:
A "banner" landmark means that the message appears a the top of the page, similar to a header.
A "contentinfo" landmark is used to mark text that appears
at the bottom of every page, i.e. a footer.
[email protected]
AX-Relnotes: n/a.
Tested: manually.
Change-Id: I496c7b88711bba01e42b459dfba1457ab2d20a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615756
Auto-Submit: Nektarios Paisios <[email protected]>
Reviewed-by: Kyungjun Lee <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Commit-Queue: Kyungjun Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158983}
Migrate mac11-arm64-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3e2220f22a38e11fc6afac13286943977d0323a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621632
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158982}
[Multipaste Growth] Check interface version when registering client
This CL checks `ClipboardHistoryAsh` version when registering a
clipboard history client.
This CL should not bring any noticeable changes.
Bug: None
Change-Id: I3be2fb0c23f6b0b51a9ca311e1aed282fd8564c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567828
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158981}
[iOS] Create base::ios::IsRunningOnIOS17OrLater
Fixed: 1455468
Change-Id: Ic7af56d505475c141f6a30d7b80e986292bd0173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621347
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Joemer Ramos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158980}
ChromeRefresh2023: Add kDetached shape for tabs.
Bug: 1454274, 1399942
Change-Id: I8e47c7d94eabaa7fecb8ef42755bf2ba426e0978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598588
Reviewed-by: Taylor Bergquist <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158979}
Migrate Mac12 Tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Idb293bb4a4497b5814a599d43fd0aca93e730066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621630
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158978}
[iOS] Adjust attaching listeners for Payments Bottom Sheet
This CL adjust a few things:
1) The logic to attach the listeners was moved from
ChromeAutofillClientIOS to AutofillBottomSheetTabHelper
so that the code which loops through the forms can be
skipped if the feature check is disabled. Also, it makes
it easier to make future changes to the logic, as
everything is in a single file.
2) Added a check to see if GetCreditCardsToSuggest() returns
a non empty vector before trying to attach the listeners.
Bug: 1450214
Change-Id: I2fd3ff131137262a5bf4a76a371978a5065de8ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614451
Commit-Queue: Alexis Hétu <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158977}
[NP] Add DeviceLost/Changed impl in NPService
Currently only Device Found functionality is implemented in nearby
presence service, add lost and changed as well.
Test: Added unittests for NearbyPresenceServiceImpl
Change-Id: Id975f95d6011d3b61acb3a3e8cb1d6fb70411c32
Bug: b/276642472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608889
Commit-Queue: Alex Kingsborough <[email protected]>
Reviewed-by: Juliet Lévesque <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158976}
Roll D8 PwglNZFRNPkBBXdnY9NfrZFk2ULWDTRxhV9rl2kvkpUC -> vw5kLlW3-suSlCKSO9OQpFWpR8oDnvQ8k1RgKNUapQYC
In hopes it fixes an internal dexing crash
Bug: 1455158
Change-Id: I96b5dd68c9e69ea1321b13048b29b9768588d709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619373
Reviewed-by: Samuel Huang <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158975}
Migrate android-cronet-x86-dbg-pie-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I9c1c76deb40d0fea53827c219204c01b53880ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621628
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158974}
JNI annotation processor -> srcjars (batch 1)
* android_webview/BUILD.gn
* android_webview/glue/BUILD.gn
* android_webview/test/BUILD.gn
* mojo/public/java/system/BUILD.gn
* net/android/BUILD.gn
* services/device/public/java/BUILD.gn
* testing/android/native_test/BUILD.gn
* ui/android/BUILD.gn
* url/BUILD.gn
* weblayer/browser/java/BUILD.gn
Bug: 1410871
Change-Id: Ib87fcdc30208552d65f6adbfee16ca6c5f1bd2e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616415
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Sam Maier <[email protected]>
Owners-Override: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158973}
[Code Health] Remove histogrm Apps.Launcher.InstallAppFromLinkResult
Removes histogram Apps.Launcher.InstallAppFromLinkResult since it
expired as of 2022-09-25.
Bug: 1448129
Change-Id: I7416e3ae58d9bd6f492c90890200d805dbc6a89e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619111
Reviewed-by: Moe Ahmadi <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Nigi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158972}
Support multiple Ad-Auction-Result and change encoding to base64url
Sites using the Ad-Auction-Result header to provide the result from
ad auctions may want to provide the results from multiple auctions
in a single response. This CL adds support for that and also changes
the encoding from base16 to base64url to reduce the header overhead.
This implements the changes described in the explainer pull request: https://github.com/WICG/turtledove/pull/631
Bug: 1442274
Change-Id: I046d36aac46b40119a3129adffae26e623e2c6b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614132
Reviewed-by: Yao Xiao <[email protected]>
Commit-Queue: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158971}
[iOS] Support bridge between identity and account services in EarlGrey.
FakeSystemIdentityManager and storage does not sync its information with native account management in EarlGrey. This creates a discrepancy between the data in native AccountInfo and iOS-specific SystemIdentityManager, specifically for account capabilities.
This patch enables support in EarlGrey for fake identity management that notifies and updates account tracking services. Following this change developers should be able to test features that use AccountInfo details such as capabilities in EarlGrey.
Bug: b:266547307
Change-Id: I6df2444e2e1010bf66dcf8e972af2df1da9476ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609128
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Nohemi Fernandez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158970}
[PriceTracking] Remove IPH handling for non-unified side panel
Since UnifiedSidePanel has launched, remove the special handling
needed to support side panel IPH for non-unified side panel.
Bug: b:274140825
Change-Id: I5a78c67493c9b1386316b4b4bb443b06110db6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616152
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Emily Shack <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158969}
Integrate text fragments with Document lifecycle
This CL is a refactoring to improve how text fragments are integrated
with the document lifecycle. There are several high-level changes here:
- Annotations (the thing that performs text search and applies the
highlights) no longer allow attaching at arbitrary points. Instead,
clients can set an annotation as "needing attachment" and schedule a
BeginFrame. In the next BeginFrame, all annotations needing attachment
perform their search after layout is updated.
- Text fragments have a special case for when a page has never been
visible; the text search is deferred until the page becomes visible.
The above change required moving this behavior into
AnnotationAgentContainerImpl.
- TextFragmentAnchor is no longer responsible for controlling when
annotation attachment occurs. Instead, it's invoked right after
annotations are attached and checks the status of its annotations to
update its internal state and perform scroll into view and related
actions.
- Simplify TextFragmentAnchor's state machine by removing the
ScriptableActions state. Instead, the script-running actions are
scheduled for an animation frame and then move the anchor into the
kDone state.
See also the related followup which this CL enables:
https://crrev.com/c/4586061
Change-Id: I1f6fd7c28b86274beae2cdc934b529c9f7bfb472
Bug: 1327734,1303887,963045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577583
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158968}
Migrate linux-arm64-rel-cft to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: If21e4869ad4a89f86ca57cf66c0a1c438da55b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621409
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158967}
Remove NoVarySearchHelper::prefetches_with_no_vary_search_
To centralize the source of truth and align No-Vary-Search
and No-Vary-Search hint, this CL removes
`NoVarySearchHelper::prefetches_with_no_vary_search_`
and instead iterate over
`PrefetchDocumentManager::all_prefetches_`
in `IterateCandidates()` to resolve No-Vary-Search.
This is preparation for eventually moving the source of
truth for No-Vary-Search further into PrefetchService
(i.e. more like No-Vary-Search hint).
The `net::HttpNoVarySearchData` stored in
`prefetches_with_no_vary_search_` is moved to
`PrefetchContainer::no_vary_search_data_` and is checked
during iteration.
Bug: 1448731, 1449360, 1430331
Change-Id: Ifb239ab6efe6911eaea8d4637f10f19651ade254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571842
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Max Curran <[email protected]>
Reviewed-by: Liviu Tinta <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158966}
Create new proto fetcher to submit Permission Requests
A new proto fetcher is created to submit Permissions Requests
during remote url approvals. It is used by a new implementation
of PermissionRequestCreator that lives in components. This will
be used initially for iOS remote approval requests.
Bug: b/276901846
Change-Id: Id3c725bcdc6facc1e8cd28cef3103310b8bbf885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598236
Commit-Queue: Anthi Orfanou <[email protected]>
Reviewed-by: James Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158965}
Roll RTS model from lFzgq5jjwZ6ucRo7N... to lz3TbI34N4iM4TWL8...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I564d616042680af64d32197f909db752d8604d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620850
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158964}
Automated Commit: LKGM 15504.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778177853368948641
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: I8ef42c8bbad18d7c7e05b47be45155bc2b75e4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620374
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158963}
Revert "View timeline: Handle offscreen stickiness."
This reverts commit 8164954aefce51cc59f95da80c0acce888a1bc0b.
Reason for revert: Causing flaky failures, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/20525/overview.
Original change's description:
> View timeline: Handle offscreen stickiness.
>
> A view timeline subject inside a position:sticky box can get "stuck"
> from any of the four CSS offset properties (left, top, right, bottom)
> during any of the named view-timeline ranges (entry, contain, exit) or
> even while it is entirely outside the viewport.
>
> ViewTimeline::CalculateOffsets previously assumed that stickiness occurred only when the subject was fully contained by the viewport.
> This change implements the more general solution.
>
> Bug: 1448294
> Change-Id: I842552b3a30078587eff6287e4ee11396d13ed95
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616159
> Reviewed-by: Kevin Ellis <[email protected]>
> Commit-Queue: Steve Kobes <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158852}
Bug: 1448294
Change-Id: I6d0bcfae16ee2265a2a1a442a646452ea89341e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621249
Reviewed-by: Steve Kobes <[email protected]>
Auto-Submit: Reilly Grant <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158962}
[Code Health] Remove expired and unused histograms
This CL removes the following expired histograms which are also
unused:
- ExploreSites.CatalogUpdateRequestSource (expired as of 2020-03-22)
- ExploreSites.NTPLoadingCatalogFromNetwork (expired as of 2020-02-16)
Bug: 1447214
Change-Id: Ia3f249676c2da3910886eca430a97c33e6a1973e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616733
Reviewed-by: Alan Screen <[email protected]>
Commit-Queue: Nigi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158961}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686916746-51e5f564e2e7c1a3d8d22d73b6c790cce1590e4f.profdata to chrome-win32-main-1686927570-514fd42c65b09a7fa52b4f6277c42f85abef41a8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ibafabf9bc593a46619afeb88fa25d0dc75e5fc38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617759
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158960}
Migrate android-12-x64-dbg-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I803d9cd87ad962647823eb3998f4651bf4b22f28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621587
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158959}
[Fixit] TabGroupUiTest
Batch and attempt to fix tests.
Note to sheriffs: please just re-disable if
testIphBottomSheetSuppression starts flaking and file a bug against me
local repro of the bug on CI bots was not possible, but I reworked the
test to hopefully fix the issue.
Fixed: 1208386, 1368273, 1335532, 1340636
Change-Id: Ic30a8c82e94bcfd3999844bf165cc9118cba0663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616821
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158958}
Roll RTS model from ymt4Jpnr37nBMRkhx... to HFEV4KNtAHPOwK3gg...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I10c11ca89eadf70b4626bf1d3aedfc7a8de9b508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618425
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158957}
Fix CustomTabActivityAppMenuTest on automotive
"Add to homescreen" isn't supported on automotive devices so several
tests that assume this item is supported were failing. Mock whether "add to homescreen" is supported for testing so that the tests are more deterministic.
Bug: 1454952
Change-Id: I3989ba8dcfe29916cd557b9ade353f7aadf9158b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616796
Reviewed-by: Kevin Grosu <[email protected]>
Reviewed-by: Glenn Hartmann <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Glenn Hartmann <[email protected]>
Auto-Submit: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158956}
[Tab Switcher] Fix List mode colors
List mode color appear to have broken. Previously these changed
automagically with theme, this appears to have changed. Set the colors
based on the TabGridViewBinder#updateColors using material colors.
Demo with fixed UI: https://drive.google.com/drive/folders/17YPNfZyaUlxn1-OpTZR32s-GpfKjEP-D?usp=sharing
See https://crbug.com/1455310 for images of the wrong behavior.
Bug: 1455310, 1455397
Change-Id: I04d764a3c3809d1a8ab963ad925ca75e897e3876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619052
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Brandon Fong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158955}
Roll RTS model from hN-Lld1UDn_0bGEgF... to 0USWz44EuKadWBkBg...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I96ec0742c4860367b61a3f400acc6f3dff0214c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620639
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158954}
Disabling dynamic refresh for getAllScreensMedia on Lacros
This CL adds the lacros implementation for the dynamic refresh
prevention developed here [1]. It does so by registering a listener
(lacros side) on the ash side changes of the
kGetAllScreensMediaAfterLoginAllowedForUrls pref (primary profile)
and copies the value to the primary profile pref service.
Only the primary profile preferences need to be set because
getAllScreensMedia is only available for primary profiles (to ensure
users are warned about the potential usage on login).
Bug: 1447824
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4533937
Change-Id: Ifbce8c8d9256b1e602f4a7108e8832a29b43f1e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562278
Reviewed-by: Roland Bock <[email protected]>
Commit-Queue: Simon Hangl <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158953}
Print preview: Update pin printing disable print button logic
In Print preview, the print button needs to be disabled when pin
printing is enabled but the pin is invalid. To do this, the "pin value"
was treated like another print preview dropdown setting. The print
button is disabled when a print setting is invalid which is good but it
also prevents the preview PDF from generating which is bad for pin
printing. Even with an invalid pin value, the preview should still show.
So this CL stops treating the pin value as a print preview setting and
adds a separate check for enabling/disabling the print button for pin
printing.
`isPinValid` is set by `pin_settings.ts` then that value is used by
`button_strip.ts` to enable/disable the print button.
Fixed: b:270000456
Tests: browser_tests --gtest_filter=PrintPreviewButtonStripTest*
Change-Id: Ided148de4a032154874761ec3b30e2829738a4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602110
Reviewed-by: Xiangdong Kong <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158952}
gpu: win: Add support for DComp visual properties needed for delegated compositing
This CL adds the properties for `opacity`, `rounded_corner_bounds`, and
`background_color` to DCLayerOverlayParams. It also enables anti-
aliasing for overlays, when needed.
Bug: 1132392
Change-Id: I37d19ab67710fe0d3ea3616abb3160b71cf0f21a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599273
Reviewed-by: Rafael Cintron <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Michael Tang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158951}
Add note in OBSOLETE_HISTOGRAM docs about using a single line
When an obsoletion message is manually broken up into multiple lines,
only the contents of the first line are used in the obsoletion message.
Change-Id: I1ea798741798c5c37c91c427955a634d03c6bca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619695
Reviewed-by: Alexei Svitkine <[email protected]>
Auto-Submit: thefrog <[email protected]>
Commit-Queue: thefrog <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158950}
Password still displayed in bottom sheet on deletion (1 password)
On the bottom sheet, when the user long press and delete the last
password of a page and open the bottom sheet again, the password is
still there. This CL is to fix this issue by clearing out the
credentials cache of the fill data.
- Detach bottom sheet listener so the keyboard can be shown when there
are no more passwords on the page.
- Fix unit tests.
Bug: 1446310
Change-Id: Ib88781832d049ca0847b85629d8d55b347559968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615981
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Veronique Nguyen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158949}
Roll src/google_apis/internal/ 916102665..1f0b7eaee (9 commits)
https://chrome-internal.googlesource.com/chrome/google_apis/internal.git/+log/9161026654df..1f0b7eaee8e7
$ git log 916102665..1f0b7eaee --date=short --no-merges --format='%ad %ae %s'
2022-12-12 michamazur Add API keys for PSM and SimLock provisioning servers
2022-11-02 ddorwin Delete obsolete GOOGLE_CLIENT_ID_REMOTING_IDENTITY_API
2022-10-31 ddorwin [google_apis] Only define Ash-specific keys in Ash builds
2022-10-26 ddorwin Make GOOGLE_API_KEY_ANDROID_NON_STABLE Android only
2022-10-26 ddorwin [CrOS Nearby] Removed unused API keys
2022-10-26 ddorwin Remove the SPDY proxy key
2022-10-27 ddorwin Use BUILDFLAGs for platforms instead of OS_* defines
2022-10-26 ddorwin Delete obsolete GOOGLE_API_KEY_REMOTING_FTL[_MOBILE]
2022-10-26 ddorwin Suppress git-secrets error for *_api_keys.h
Created with:
roll-dep src/google_apis/internal
Bug: b:262288980
Change-Id: Ife6198de539315aa97a9ca6c8920a7c912dc4f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607215
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Michał Mazur <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158948}
infra: Migrate mac13-arm64-rel's orch builds to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I398c64cf740629800b521d247c0e35166f16ee23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621408
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158947}
fido: fix typo in flag name
Change-Id: I023ca7517aa9d182f269d18c54fb1e2a1c03065c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619413
Commit-Queue: Adam Langley <[email protected]>
Auto-Submit: Martin Kreichgauer <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158946}
Roll clank/internal/apps from afe125efb45f to f04b386306a5 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/afe125efb45f..f04b386306a5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1406790
Tbr: [email protected]
No-Try: true
Change-Id: I84adfe42520ab8fb21e1103f45b7e25eb3d75a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621327
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158945}
[iOS] HistorySyncMediator dealloc checks stop was called
Bug: None
Change-Id: I696f6c68c26b70543fe6d8a3113defa95f92a26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608128
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158944}
[Fixit] Fix flaky ShareImageFileUtilsTest
Test requires creating temp image and generate Uri, then attach them to
clipboard. Using some mock instance of ClipboardManager so all the code
that's origianlly tested in these test cases are still covered under
test, while make test behavior independent from OS ClipboardManager.
This will help reduce the flakiness caused by the OS Clipboard service.
Bug: 1455269
Change-Id: I3bbcbbcd080ff11bd161583505da5e4c4bfed521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619121
Reviewed-by: Sophey Dong <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Charles Hager <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158943}
Import wpt@be566d5b4da50c41dd6dde27a05487305997baa2
Using wpt-import in Chromium f14233fa35f1b376931dcdce180449bb31e26ac3.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/editing
[email protected]:
external/wpt/css/css-contain
external/wpt/css/selectors
NOAUTOREVERT=true
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I50ff2b5fdefa784c5a8352f96a74123d735595a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619832
Auto-Submit: WPT Autoroller <[email protected]>
Reviewed-by: Nihar Damarasingu <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Reviewed-by: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158942}
Adds OWNERS file and subfolder for sharing.
Bug: 1455407
Change-Id: I4e08e2a20e0bd6044870877652e6a6659690828a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620588
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Markus Heintz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158941}
Roll ios_internal from 019270877d4f to a6f6e8e0bbba
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/019270877d4f..a6f6e8e0bbba
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1454395
Change-Id: I87ec8c7acfd01760eceecba63f66b763718b12d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617760
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158940}
Remove SK_USE_LEGACY_MORPHOLOGY_IMAGEFILTER flag
The subregion layout tests have significant changes. The reason is
the morphology image filter is now taking into account "offscreen"
pixels of the input image (in this case, red in the top-left corner).
This changes the dilate filter to produce white instead of cyan, since
red is now included with the green and blue cells within the subset.
Discussing with @pdr and @fs, these changes are arguably more correct,
since the test is subsetting using the primitive subregion (meant to
only impact the output region), and the filter region (that crops the
input content) is unrestricted. The test results now also match Firefox.
The filters-morph-01-f test also show improvements, where boundary
content is not being clamped and extruded unexpectedly for an erode.
The updated morphology implementation reports tighter bounds for
the erode filter, so the effect-reference-repaint-morphology ref
tests are updated to match. The expected invalidation bounds now
exactly match the non-transparent content that results post-erode.
Bug: skia:9282
Bug: b/263137049
Change-Id: Ie315e9b2c811fb0b7afb47e323cef310431ba14e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615558
Reviewed-by: Robert Phillips <[email protected]>
Commit-Queue: Michael Ludwig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158939}
Fix the status area pods background under in app mode
Screenshot:
https://screenshot.googleplex.com/63XT3vBK3BPyqWD
Bug: b/286122509
Change-Id: I1a5e7ed449d6cc625233d24474219f9a4abce423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619087
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Jiaming Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158938}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686916746-0f312f5c9a4cfa50483527eda11a7af1434e7d70.profdata to chrome-win64-main-1686927570-b6b8ae5a461ffed14500469d89ef545e83cac495.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I50a2d3d4332ddd87c7c18ecda239297bd9e6d2d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619759
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158937}
Support AppLaunchAutomation policy on ChromeOS starting from M116
Change-Id: Ibb152c2e847ba13d4bf98ef6ba7467271944a81a
Bug: b:268538092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573873
Commit-Queue: Yanzhu Du <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158936}
[sync] Enable preferences in transport mode
This CL causes PREFERENCES and PRIORITY_PREFERENCES to start in
transport mode if ReplaceSyncPromosWithSignInPromos finch flag is
enabled along with EnablePreferencesAccountStorage.
Bug: 1447018
Change-Id: I6fc7cc1f52d28c91660caefdac706d9f0fe512d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615896
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Ankush Singh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158935}
Refactor kombucha fuzzer to use libprotomutator
protobuf file now contains element identifiers to target
Bug: 1451928
Change-Id: I4887dc61c3470bbcfd20388d0e192ec4f81c3e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615749
Reviewed-by: Brendon Tiszka <[email protected]>
Commit-Queue: Xavier Rosado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158934}
shortcuts: Add window layout shortcut description
This adds the `Search + Z` shortcut description to the new shortcut app.
The string is copied from the old shortcut viewer description,
https://source.chromium.org/chromium/chromium/src/+/main:ash/shortcut_viewer/shortcut_viewer_strings.grd;l=834.
Bug: b/282760166
Change-Id: I5cef00d84d43e4e444f00e0108cdf10253726720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617870
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Sophie Wen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158933}
Roll Perfetto from 2d8c8695425d to ed02827cea30 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/2d8c8695425d..ed02827cea30
2023-06-16 [email protected] Merge "Add --stdlib-sources argument to check_sql_modules"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Icd50d66ee3d55857ccc2b2d560094ca93106b7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620635
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158932}
Clarify comment on how ScopedFeatureList handles the existing state
The existing class-level comment for base::ScopedFeatureList claims this
scoper resets the FeatureList to a new empty instance. This is not
always the case, depending on how ScopedFeatureList is initialized.
Update the comment to better explain how it works.
Change-Id: I7e3ca1e656e5120b38534fe16e48ddba59e9039b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615637
Commit-Queue: Alexei Svitkine <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158931}
[AppLaunchAutomation] Load Admin Template Service Earlier
Ensure that the admin template service is loaded in tiime to
populate the launcher.
Bug: b/281857868
Change-Id: I738117d8770b554ef2cb1a36e3abd0f4185e4f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618017
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Avynn Donaghe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158930}
[iOS] dealloc checks RecentTabsTableViewController is dismissed.
This is required, as dismissing it disconnect the mediator.
Bug: None
Change-Id: I3f746527d7aca3935dcf4b8363add76ed91560a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620267
Commit-Queue: Arthur Milchior <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158929}
[WebView] Remove content relationship verification code
Bug: 1454473
Change-Id: Ib25c2114f9b92e6160db86498f520f9276f46ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608053
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: Susanne Westphal <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158928}
[Fixit] Batch TabGridDialogTest
Batch the TabGridDialogTest. I originally thought this was impossible;
however, on another attempt I think this is mostly working.
This should make iterating on fixing the disabled tests easier.
Bug: 1380489
Change-Id: Id9dc22dafd83961f314cb167ab2dc50da448c8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616233
Code-Coverage: Findit <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158927}
Use AuxiliarySearchHooks to create AuxiliarySearchController
This CL is the final step for the split auxiliary search out of
chrome.
In this CL, Factory will create AuxiliarySearchController by
AuxiliarySearchHooks, not directly create it.
Bug: 1445112
Change-Id: I3ce936f7706336365cb4787fc70eb1b53bdc20d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611088
Commit-Queue: Gang Wu <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158926}
[AppLaunchAutomation] Fix templates not populating.
This Cl adds in a fix that prevented app launch automation
templates from populating correctly. This is done by having
the admin template service observe the preference store rather
than depend on being called by the policy handler.
Design: go/admin-templates-storage-design
Bug: b/281857868
Change-Id: I67ce46a75979f3424af6c882dfe9fa78918ba59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598416
Reviewed-by: Dominic Battre <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Avynn Donaghe <[email protected]>
Reviewed-by: Yanzhu Du <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158925}
Ensure the new link flags variables are initialized when !use_lld
Other users of //build do not use lld.
[email protected]
Bug: 1271215, 1455412
Change-Id: I0e0f1c6829e1e5065e4d6bdb7f30c1abafea7b37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617011
Commit-Queue: Bruce Dawson <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Auto-Submit: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158924}
Roll Better Together Core from d905e113aa8d to 45756ea770c4 (1 revision)
https://beto-core.googlesource.com/beto-core.git/+log/d905e113aa8d..45756ea770c4
2023-06-16 [email protected] Project import generated by Copybara.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/beto-core-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Icce3a9da223b841ea81b0238bf079af7968884ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619684
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158923}
Add scoped feature list to AmbientBadgeManagerSecondVisitTest
The test was passing because of the field trial config
Enabling the flag explicitly in case the field trial config is disabled.
Bug: 971387
Change-Id: I4df70a3e87feab27a8137d19af6749b10be95af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619834
Reviewed-by: Glenn Hartmann <[email protected]>
Auto-Submit: Ella Ge <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158922}
Add Utility Cluster Row to Menu
Creates the utility cluster row, which contains a feedback, settings,
and help button. The functionality for these buttons will be implemented
in a future CL.
Bug: b:275424971
Test: Ran GameDashboard* ash_unittests
Change-Id: I0f0ed997e04b57e42d84b378920b42e49e871236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569652
Commit-Queue: Gina Domergue <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158921}
[EditContext] Add origin trial and use counter
Prepare for an Origin Trial by:
- Adding origin_trial_feature_name in RuntimeEnabledFeatures entry
- Adding use counter that fires when EditContext is constructed
Bug: 999184
Change-Id: Ic3a877d92d6e754fa8a5a79cb72591a132929c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619265
Reviewed-by: Alex Keng <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Dan Clark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158920}
[FedCM] Add metrics for closing IDP sign-in pop-up window
These metrics will be used in the IDP sign-in status API origin trial:
1. Blink.FedCm.IdpSigninStatus.ClosePopupWindowReason
2. Blink.FedCm.IdpSigninStatus.IdpCloseToDialogShownDuration
Bug: 1451536
Change-Id: I67447fb2e94ca1b9b12e7e8fcaef3c084c6ec62d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608823
Reviewed-by: Yi Gu <[email protected]>
Commit-Queue: Zachary Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158919}
[CSC] Fix issue with back arrow skipping CSC links
Links opened from CSC were being skipped when pressing the back button
because they were being treated as "render initiated", aka navigations
that happened without user action. To prevent this, when opening the
CSC link in the main tab, we have to pretend to be a user click in the
main tab.
Bug: b:285038653
Change-Id: I62e7cb526c5a1e0d26dd377ee0077b860e6cbba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591536
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Duncan Mercer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158918}
[Lacros a11y] Fixes lacros content script for manifest v3
On a DUT, chrome.runtime existed but chrome.runtime.id
was undefined.
AX-Relnotes: N/A
Bug: b:272150598
Test: Manual on DUT lacros
Change-Id: I4ab8aa01db120cccb5a3cf0c2a642d08afb8c0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617962
Auto-Submit: Katie Dektar <[email protected]>
Commit-Queue: Akihiro Ota <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158917}
Fix dangling temporaries in StartupBrowserCreatorImplTest
The StartupBrowserCreatorImpl constructor takes a reference to a
base::CommandLine and stores it away for the life of the object.
However, this test is passing temporaries which only live until
the semicolon terminating the call to the constructor.
Bug: 1401495
Change-Id: I49b73b6c3691bb70c300185903eef7da9739a1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611076
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158916}
Roll WebRTC from 213090bf4bab to 18aba6627174 (1 revision)
https://webrtc.googlesource.com/src.git/+log/213090bf4bab..18aba6627174
2023-06-16 [email protected] Add test to ensure task deleted on TQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I39b563e9b7f6da57ea6b21a9736beed1e7057311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618842
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158915}
Use IdType for identifying Requests in BinaryUploadService
This CL replaces the use of pointers with numerical Ids. This has a few
advantages:
- It prevents us from accidentally using the pointer without checking it
is safe.
- It avoids a class of bugs related to the allocator creating a new
Request with the same pointer after the old one is freed.
- It avoids triggering dangling pointer detection
Fixed: 1453191
Change-Id: Ie33526afb3e62e030334e68d07924009bbfe4030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605787
Code-Coverage: Findit <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Dominique Fauteux-Chapleau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158914}
media/gpu/v4l2: Extract V4L2FormatToVideoFrameLayout() out of V4L2Device
Since that static method does not use V4L2Device resources, it
doesn't need to be part of the class, which is already very large.
This was the other follow-up to https://crrev.com/c/4568232, which
in turn allows to remove the include v4l2_device.h from v4l2_queue.h
(struct V4L2ExtCtrl is moved there too; V4L2_PIX_FMT_QC08C is moved
to v4l2_utils.h).
No new functionality, only moving code around.
Bug: b:279980150
Change-Id: I578164e2d0a558fad2f0d60cf1e1cb6a55be06c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611096
Reviewed-by: Fritz Koenig <[email protected]>
Commit-Queue: Miguel Casas-Sanchez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158913}
infra: Move a few trybots to jammy
This migrates:
- 3pp-linux-amd64-packager
- android-pie-arm64-dbg
- linux-1mbu-compile-fyi-rel
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builders, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I2cd5bb1a07ded5b281a673509f7ac928fbcb4fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620929
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158912}
[Policy] Header title enhancements
Currently the header title area of the chrome://policy looks out of place.
This CL makes it look similar to the one found in Chromium settings.
It includes font adjustments along with brand logo (for desktop builds).
Screenshot: https://drive.google.com/file/d/133NN_DRvePN60R-izUfF_WoSGlQTIXce/view?usp=sharing
[email protected], [email protected]
Change-Id: I15129dbd8a54494db03c8fc7f491110901745c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615846
Reviewed-by: Fabio Tirelo <[email protected]>
Commit-Queue: Aryan Kaushik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158911}
viz: Fix dangling ptr DisplayClient in viz::Display
This CL fixes dangling ptr in viz::Display.
DisplayClient instance is marked as DanglingUntriaged due to
SkiaDelegatedInRenderTest and DirectLayerTreeFrameSink.
SkiaDelegatedInRenderTest:
`display_` instance depends on `client_` while `client_` is destructed
before `display_` in this class since `display_` is declared in its
base class `DisplayTest`.
DirectLayerTreeFrameSink:
Display and DirectLayerTreeFrameSink which inherits DisplayClient
depends on each other.
Another way is to make `display_` inside DirectLayerTreeFrameSink
std::unique_ptr and pass the ownership from InProcessContextFactory,
but this causes another dangling ptr due to the dependency chain.
(dependency overview: https://drive.google.com/file/d/140PRvdYK-CDwxZN-exCq8N_t_TOrYNaR/view?usp=sharing&resourcekey=0-8y0QNCy7oTmT8lO4ZIcjxA)
We rather keep InProcessContextFactory logic as is.
DisplayClient outlives in all other usages.
Bug: 1454709
Change-Id: Ia3e1f11ba26b3042ed433490cdf912557afdeeef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612328
Reviewed-by: Kyle Charbonneau <[email protected]>
Auto-Submit: Eriko Kurimoto <[email protected]>
Commit-Queue: Eriko Kurimoto <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158910}
Extend Media.RtcLowLatencyVideoRenderer.MaxQueueLength
Fixed: chromium:1433957
Change-Id: I8ba7ac5ac9d4f227c9c7afd8328e57db7696820b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620728
Reviewed-by: Henrik Andreasson <[email protected]>
Commit-Queue: Henrik Andreasson <[email protected]>
Auto-Submit: Johannes Kron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158909}
[EditContext] Limit to valid element types
In https://github.com/w3c/edit-context/issues/19 the Editing WG
resolved that EditContext would support the same element types as
shadow root, plus `<canvas>`.
Update the implementation accordingly. See also the updated
spec at [2].
[1] https://github.com/w3c/edit-context/issues/19
[2] https://w3c.github.io/edit-context/#extensions-to-the-htmlelement-interface
Bug: 999184
Change-Id: I2a8a040a279e14e9b98ece3370acdbdd8c3597ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617146
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Alex Keng <[email protected]>
Commit-Queue: Dan Clark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158908}
Roll Skia from 9ab04a53b7be to a4ad5b369313 (8 revisions)
https://skia.googlesource.com/skia.git/+log/9ab04a53b7be..a4ad5b369313
2023-06-16 [email protected] Skip imagemakewithfilter GMs on Xe gltestthreading config
2023-06-16 [email protected] Manual Roll Dawn from a0e679b77011 to 4588fe12df3d (19 revisions)
2023-06-16 [email protected] [Fontations] Roll Fontations libraries
2023-06-16 [email protected] Disable SwitchWithFallthrough test on iOS + GLSL.
2023-06-16 [email protected] Remove Android GPU methods from SkCanvas
2023-06-16 [email protected] Introduce delegate for Atlas regeneration
2023-06-16 [email protected] Extract VertexFiller and add AtlasDrawDelegate as GPU abstraction
2023-06-16 [email protected] Extract SlugImpl.h and remove #ifdefs of slugs from Canvas
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I54b99638e4bc452301d727629923e5a09cbf539c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618841
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158907}
Add experimental SwANGLE builders
For testing Ubuntu 22.04
CI:
linux-swangle-x64-exp
linux-swangle-chromium-x64-exp
Try:
linux-swangle-try-x64-exp
linux-swangle-chromium-try-x64-exp
Bug: 1380082
Change-Id: I11b8fee54b51b16eb2ceeae1257c7e7175745f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615579
Commit-Queue: Yuly Novikov <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158906}
Disabling dynamic refresh for the multi screen capture policy
This CL removes the dynamic refresh from the multi screen capture
policy as requested by trust and safety. The policy value must only
come into effect on a fresh login. This is to prevent an app to start
screen capture dynamically without having the chance to close private
tabs.
This is done by disconnecting the chain: policy --> preference -->
content setting. Instead, two preferences are introdcued: one that is
linked to the policy and a second that is linked to the content
setting. The value of the first preference is copied over to the
second preference on user login. This results in the chain:
policy --> pref 1 --> manual copy on user login --> pref 2 --> content
setting.
The manual step will only work on ash. Propagating pref 1 on ash to
pref 2 on lacros will be done in a separate CL.
Bug: 1300883
Change-Id: I42fca00eef19bffb7e6c298c695ca1e6d09ac95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4533937
Reviewed-by: Alexander Hendrich <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Commit-Queue: Simon Hangl <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158905}
Re-reland [omnibox] Split WebUI impl out from OmniboxPopupViewViews
This CL relands the WebUI refactor change while fixing a bug that was
carried over from the original implementation. A raw_ptr member was
never initialized while it should have always started as nullptr.
In other words, the robot was right and the system works.
Previously Reverted CL: [Reland [omnibox] Split WebUI impl out from OmniboxPopupViewViews (4619093) · Gerrit Code Review](https://crrev.com/c/4619093)
Bug: 1445142
Change-Id: I2f089c9109f47cabb8453a335f0b0c885482044d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620649
Commit-Queue: Orin Jaworski <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158904}
Update license of the pspdfkit benchmark
The license issue on https://pspdfkit.com/webassembly-benchmark
has been fixed. This CL updates the wprgo files for the benchmark.
For some reason the first navigation to the URL fails. Therefore the
benchmark now navigates to the URL twice.
[email protected]
Bug: 1455191
Change-Id: I5a406d730118d32e978f187e004fdc1124728be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616070
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158903}
[Android] Remove PageController Tests
This CL removes all PageController tests, however, subsequent
work to refactor tests to further remove/refactor dependencies
on rules and/or utils is left out of scope.
Bug: 1141179, 1130617
Change-Id: Ib858e22c53cf04743ab2c38de2b84742057bb9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611811
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: James Lee <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158902}
Update V8 to version 11.6.184.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3cbcb789..8476ea9e
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I699ae1f5375f726f0149b894c231cd4674425543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619734
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158901}
Enable companion when exps is enabled
This CL dynamically enables Chrome companion if Chrome detects that user
is enabled in exps. This happens if the
CompanionEnabledByObservingExpsNavigations feature is enabled.
The CL achieves this by changing some of the existing checks to be
enabled by either of the 2 field trial experiments: (i) CSC itself is
enabled as a feature (ii) Detection of exps enrollment is enabled
If detection of exps enrollment is enabled and exps enrollment is
detected, then companion is dynamically enabled and an entry is pinned
to the toolbar.
Design discussion: http://shortn/_nrSG5apNyX
Bug: b:286111571
Change-Id: Ida569ecd57018b693e1e22223f1080cd4f4a467c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607701
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Michael Crouse <[email protected]>
Reviewed-by: Juan Mojica <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158900}
Make ui::SelectFileDialog::SetFactory() take a std::unique_ptr<> arg
ui::SelectFileDialog::SetFactory() is taking ownership of its argument,
either globally leaking or deleting it, so this makes that more obvious.
It also uncovers a spot in PPAPI where fairly egregious ownership issues
exist. Update a comment here but otherwise leave unchanged.
-- Removes a large number of bare `new`.
-- std::make_unique<> needs more specific type information in a few
places that just a bare brace-initialized list.
Change-Id: I3111e009a3afc99ff87bd99ca35f3613255ea6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616626
Commit-Queue: Tom Sepez <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Joe Downing <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158899}
Reland "Add wayland api for rotating window internal focus"
Fixed memory leak in wayland aura shell server test. I didn't realize
that wayland get* calls create and return objects which the caller
owns, causing the test to leak zaura_toplevel objects.
This change changes toplevels to be assigned to unique_ptr's so that
they will be properly cleaned up after test.
This is a reland of commit b658374825cf4e6545f6d18646a6a963949f1c99
Original change's description:
> Add wayland api for rotating window internal focus
>
> ChromeOS allows rotating focus between OS views and browser panes.
> Browser panes are no longer accessible from the OS since the ash/lacros
> split. This change adds a wayland API to allow ash to request lacros
> to rotate its pane focus and another API for lacros to notify ash that
> it has reached the end of its pane rotation.
>
> Bug: 1361120
> Change-Id: Ic82b7c5c57bb34e97c21f7b177f2f4a68a1b477a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548442
> Code-Coverage: Findit <[email protected]>
> Commit-Queue: Fred Shih <[email protected]>
> Reviewed-by: Mitsuru Oshima <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157874}
Bug: 1361120
Change-Id: Ie82e172c20f58fa01cbd8ce6b2d5e31ec23d88db
Test: rebuilt with asan and lsan flags and reran the tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618414
Commit-Queue: Fred Shih <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158898}
[KeyedServiceRegistration] Add rsult as owner of the main registration file
Adding myself as the OWNER of the main files for the keyed service factory registration to be part of the review keyed service factories creation.
Files affected in this CL:
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.*
chrome/browser/ash/browser_context_keyed_service_factories.*
chrome/browser/extensions/browser_context_keyed_service_factories.*
chrome/browser/extensions/api/api_browser_context_keyed_service_factories.*
chrome/browser/extensions/chrome_browser_context_keyed_service_factories.*
chrome/browser/extensions/api/chromeos_api_browser_context_keyed_service_factories.*
extensions/browser/browser_context_keyed_service_factories.*
extensions/browser/core_browser_context_keyed_service_factories.*
extensions/browser/api/api_browser_context_keyed_service_factories.*
Bug: 1412439
Change-Id: Ie7090ed1e06e0ac79c58ac0d46bf8dc692893f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614583
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158897}
about_ui: switch OS credits to common credits.js
The OS credits pages are written in the same style as the main
chrome://credits page, so switch to using the same credits.js.
Bug: b/284974354
Change-Id: If1648534aa4e6fd0273076359fed96f27e57bc4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618221
Reviewed-by: Denis Kuznetsov <[email protected]>
Commit-Queue: Mike Frysinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158896}
Store/read the setting lifetime explicitly in
SubresourceFilterContentSettingsManager
Bug: 1450356
Change-Id: Ic2572206de2c5cd6a0e7286e2ef75496abfdeb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614292
Auto-Submit: Chris Fredrickson <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158895}
[BRP] Manual rewrite exclusion to raw_ptr on LaCrOS (June 15th)
- Add RAW_PTR_EXCLUSION to some files in LaCrOS target
Bug: 1273182
Change-Id: I7b718a11060fa9878bcbf3de63ff750c50af8181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616729
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Mikihito Matsuura <[email protected]>
Owners-Override: danakj <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158894}
[iOS] Replace move_folder image by symbol
Bug: 1444063
Change-Id: I00f87cbe2344e5e8ba532ad471c3a3d29eac2bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618254
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158893}
Re-enable several SearchActivity tests
A lot of these tests were flaky due to a lengthy initialization that
frequently failed to deliver suggestions in the supplied time window.
Rather than relying on Autocomplete pipeline (that has its own
latency and runs asynchronously), we simply verify that interactions
with the Autocomplete pipeline happen when we expect them and
inject suggestions to ensure proper content is shown.
Bug: 1166647, 1311737, 1177417, 1446044
Change-Id: Ica45b6b56cce9bce6ff7373c1872447b4bb92648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617344
Code-Coverage: Findit <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158892}
Roll Help App from 7NxZbReGqsCEa11RA... to qiizk_233WcWsb4eZ...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202306160800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/qiizk_233WcWsb4eZwzaci3MxI6LGbW1q5fKbdxnmgcC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/286992696,b/287571506
Tbr: [email protected]
Change-Id: I88ccd68dcdb2bcba8cf1fc580605cfff01c5a25f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617758
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158891}
[Extensions c2s] Update strings in extensions menu and toolbar
Add tooltip for the extensions button depending on state. Update
strings in the menu to match mocks.
Bug: 1390952
Change-Id: Ibe2e01b14fb19acd8a1b02dcf304ec25ade3c9e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611887
Reviewed-by: Kelvin Jiang <[email protected]>
Commit-Queue: Emilia Paz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158890}
Add additional end-to-end success Private Aggregation WPTs
Renames some files as a drive-by and fixes .ini files to simply disable
the tests that have exclusive virtual tests instead of having errors
as expected.
Bug: 1452248
Change-Id: I7e30e4ce4bf2fa8d2d3f5fb8e56ea21563851e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617351
Reviewed-by: Yao Xiao <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158889}
Roll src/net/third_party/quiche/src/ d9aaee403..731acaf58 (14 commits)
https://quiche.googlesource.com/quiche.git/+log/d9aaee403dc4..731acaf58ca1
$ git log d9aaee403..731acaf58 --date=short --no-merges --format='%ad %ae %s'
2023-06-16 bnc Automated g4 rollback of changelist 539970480.
2023-06-16 birenroy Fixes the log/early return condition in CallbackVisitor::OnMetadataEndForStream.
2023-06-15 quiche-dev Removing unnecessary validation
2023-06-15 vasilvv Implement sending and receiving DRAIN_WEBTRANSPORT_SESSION
2023-06-15 diannahu Add BalsaHeadersSequence::IsEmpty().
2023-06-15 diannahu Update BalsaHeadersSequence and BalsaVisitorInterface to use std::unique_ptr for interim headers.
2023-06-15 diannahu Update the BalsaHeadersSequence internal data structure from std::list to absl::InlinedVector.
2023-06-15 birenroy Replaces a fatal log message with an early return in CallbackVisitor.
2023-06-15 quiche-dev Internal change
2023-06-14 martinduke Deprecate gfe2_restart_flags_quic_receive_ecn, replace with quic_receive_ecn2 as canary-only. Also remove flag count that is not actually protected by the flag.
2023-06-14 wub Remove non-initial burst from QUIC PacingSender.
2023-06-13 bnc Add HttpValidationPolicy::require_content_length_if_body_required.
2023-06-13 martinduke Deprecate gfe2_restart_flag_quic_quiche_ecn_sockets.
2023-06-13 wub Remove MockClock from PacketSavingConnection, and use the MockClock in MockQuicConnectionHelper instead.
Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
Change-Id: Iaa25bbd5701f21159be3723e071bd6f3b91e8193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619515
Commit-Queue: Bin Wu <[email protected]>
Auto-Submit: Bence Béky <[email protected]>
Commit-Queue: Bence Béky <[email protected]>
Reviewed-by: Bin Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158888}
Scaled up thumbnail image bitmap density on automotive
Fix (Google/NTP): https://screenshot.googleplex.com/9tgB3yrpdNMwmXt.png
Fix (Incognito): https://screenshot.googleplex.com/BM4yXRGsH6Mouca.png
Fix (Websites): https://screenshot.googleplex.com/8By3MujqkJUConh.png
Bug: b/287128842
Change-Id: Idde1a00b457c38c47d4c25072acd6fed45df7f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617680
Code-Coverage: Findit <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Charles Hager <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158887}
[Android] Workaround for TabContentManagerTest#testJpegRefetch() on Pie
There are GPU crashes causing TabContentManagerTest#testJpegRefetch() to
fail. Disabling a GPU feature flag works around the problem while it
exists.
Bug: 1454653,1454914
Change-Id: Ic9a7730f55a3ba35a1276e7515b8863bb096e605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617873
Reviewed-by: Calder Kitagawa <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158886}
Fix a couple tests in TabListMediatorUnitTest that rely on state from other tests
Bug: None
Change-Id: I0bfe629e79b8d8b6a178d778338cf065e483b7a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619101
Reviewed-by: Henrique Nakashima <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Auto-Submit: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158885}
Roll Perfetto from cbeafe489fbd to 2d8c8695425d (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/cbeafe489fbd..2d8c8695425d
2023-06-16 [email protected] tp: DBv2 - Table/Storage range constructors
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:283763282
Tbr: [email protected]
Change-Id: Id25264b330693e22e3f5e29115a436deb2d922e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620382
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158884}
[ChromeVox] Enable ChromeVox Settings Page Migration
Enable ChromeVox Settings Page Migration for all users! 🎉
go/chromevox-prefs-and-page-migration
AX-Relnotes: Make ChromeVox Settings easier to access by moving into main ChromeOS settings application, instead of through the old ChromeVox extension options page.
Bug: b/268196299
Change-Id: Idef028f63ca0b68c40f4f01894df93eb6765916d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619389
Auto-Submit: Josiah Krutz <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158883}
[FedCM] Mark multi IDP WPTs as flaky on Mac
Since there is already a line marking all as passing and we want to keep
it, we disable each test individually to avoid an error.
Bug: 1455245
Change-Id: I801c6a059c99e5a6a696ea9677ab5992c3dd33d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619833
Auto-Submit: Nicolás Peña <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158882}
cros: Investigate gaia id mismatch
This CL adds debug alias to gaia id related vars to investigate the
crash caused by mismatching gaia ids.
Bug: 1454286
Change-Id: I2557378b4a6db6660d0f4e335369404440ea1cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616022
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Reviewed-by: Kush Sinha <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158881}
Roll ios_internal from 7d14012e57d6 to 019270877d4f
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/7d14012e57d6..019270877d4f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I455c018eefff7ab1a755dace33cc8883fcb49047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619757
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158880}
Add feature to restore client ID from PMA files
Bug: b/278758667
Change-Id: Ib56f92f1a1e330df8e017131174893c6b4de3db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605913
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Luc Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158879}
Nit-fix automated merge in BUILD for supervised user tests.
Bug: b:276874936
Change-Id: Ic4ef578af3ae7a71fb1e47baf6569255a97e16ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618257
Reviewed-by: Nohemi Fernandez <[email protected]>
Auto-Submit: Tomek Jurkiewicz <[email protected]>
Commit-Queue: Tomek Jurkiewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158878}
Check for null WidgetBase in WIHM::FindScrollTargetOnMainThread.
Speculative fix for crash report.
Bug: 1453804
Change-Id: I8a0071c6eea2d0a9bc9b9f3a31f5f965424a1718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615553
Reviewed-by: David Awogbemila <[email protected]>
Commit-Queue: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158877}
[SFL] Update 'delete on untrack' behavior
This patch prevents bookmarks from being deleted if created through
the explicit price tracking entry point if the "track by default"
experiment is enabled. The state is still recorded so the behavior on
other devices is unchanged and we have the option to roll back if
needed.
Bug: b:281048639
Change-Id: I7ca929383bee13b346f9fd1ab180996df3aac5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605781
Reviewed-by: Mei Liang <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158876}
Roll devtools-internal from 9735ecefbc6b to 4087b95783a4 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/9735ecefbc6b..4087b95783a4
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/58b07f2c68b92a013d060093d3a1477633b87ce0..3f5c003793e7a6a13b2c3a7e3fb7fa778e5c8443
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I13d0c6690f4cdbd4af6da17f77d84489abc1557c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620709
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158875}
[iOS] Move paths to shared folder
Bug: 1319852
Change-Id: I73d380a9ff5692062303faa25e6c7b41443ef413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618031
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158874}
[Fixit] Use @MinAndroidSdkLevel in GoogleServicesSettingsTest
The Digital Wellbeing feature is supported only on Android Q+, so use
@MinAndroidSdkLevel instead of @DisableIf which is intended for
temporary failures/flakiness.
Bug: 1378703
Change-Id: I4aa4fe5ea87a77fa4e702aa403c84104c5ef3c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618305
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Auto-Submit: Aishwarya Rajesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158873}
Update the link to the internal Blink.UseCounter doc
Bug: b/276918116
Change-Id: Ib5230133a1384e7e572bb0164ec98d2f23e81de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618191
Commit-Queue: Sun Yueru <[email protected]>
Reviewed-by: Annie Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158872}
Add skia/README.md
Bug: chromium:1452958
Change-Id: I044a8f470e4c75303783fab439604adbabdd6db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616237
Commit-Queue: Brian Osman <[email protected]>
Reviewed-by: Herb Derby <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158871}
[DBSC]: Handle cookie refresh errors
This CL implements the initial error handling mechanism.
If the server replies with an error code of `4xx`, Chrome considers it a
persistent error that can't be fixed. Therefore the
`BoundSessionCookieController`resumes blocked requests and notifies
`BoundSessionCookieRefreshService` that is expected to terminate the
session and update all renderers.
For transient errors, blocked requests will be resumed. There will be no
impact on future requests that requires the SIDTS cookie.
The `SimpleURLLoader` will internally retry 3 times on network
connection change.
On a follow-up, we will implement a timeout to ensure blocked requests
gets released.
Bug: b/273920907
Change-Id: Ib4ed6ed95ac4dc9805b747ee2c80780d92fcff21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4589154
Commit-Queue: Monica Basta <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158870}
Add OS glitch duration histograms.
Change-Id: I90af8ea526e2781c179c7aed33b0918446e6539f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615071
Reviewed-by: Johannes Kron <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158869}
Implement calculation dependency for css math nodes
By design doc:
https://docs.google.com/document/d/1rikPXstHFK3b8N95QzfDar6dDDrEsuVgw1YF-JgvKQM
introduce runtime flag and implement calculation dependency to split up
the calculation result and the calculation dependency, as some functions
(e.g. sign()) can have different input and output types.
Change-Id: I96b65d62fa17aeef8524d39a8d37c4804625efa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607454
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158868}
Document ClusterFuzz gesture language.
Bug: 1361342
Change-Id: Ib8a2c489767ca3354478d550f14f8cc0b1470e68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597282
Commit-Queue: Adrian Taylor <[email protected]>
Auto-Submit: Adrian Taylor <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158867}
Extend expiration for SiteIsolation.ProxyCountPerBrowsingInstance.
This metric is still useful for current and future site isolation and
process model experiments.
Bug: 1449718
Change-Id: I8408ace10e9cf40ccfd5526eb3141123d92319e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619069
Auto-Submit: Alex Moshchuk <[email protected]>
Reviewed-by: Chris Thompson <[email protected]>
Commit-Queue: Chris Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158866}
[sync] DualLayerUserPrefStore: notify on disable if eff. value changes
Right now, upon disabling of a pref type, account pref values are
removed from account store and notification is sent out even if the
effective value of the pref does not change.
This CL changes the behaviour to notify the observers only when the
effective value changes.
Bug: 1455102
Change-Id: Ib3db5970e41c413dbcaf3467981e6a25d7d1da2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615894
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Ankush Singh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158865}
[ios/b4p] Enable passwords account storage features by default
Approved in http://launch/4224855.
Disable-Rts: True
Bug: 1374242
Change-Id: I951fb8db6086697f85c2a75c60b73da2d0f6ef06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329138
Auto-Submit: Victor Vianna <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158864}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686916746-66523039a329f08d3cf7331e58947a76e14bf8ef.profdata to chrome-mac-arm-main-1686923930-7d94735510ff5c2c3eb16a7c60818532d1c1c525.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I6649bc2955e5a9038c32ed8b3c97f1d3ef071eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619758
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158863}
[iOS] Add strings for Restore Defaulty promo
This CL adds the strings that will be used in the post restore default
browser promo. The promo's implementation will be in a following CL.
Bug: 1453786
Change-Id: I4561266b8356c36ad226a85587c2254770fd13dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618530
Reviewed-by: Huiting Yu <[email protected]>
Commit-Queue: Hira Mahmood <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158862}
[iOS] Change encryption error image to symbol
Bug: 1444063
Change-Id: I59cb210d19d69591e5eac30e9814ae50322102fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618256
Reviewed-by: Ewann Pellé <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158861}
[Android][Autofill] Use test-only getter to capture model in autofill editor tests.
Bug: 1435314
Change-Id: I9009df7b3d9347962f81f0898b974bc886fa21a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614874
Reviewed-by: Friedrich Horschig <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Timofey Chudakov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158860}
[ios] Disable SelectDoesntExpandCullRect
This test does not apply on iOS for the same reason it does not apply
on Android.
Bug: 1414885
Change-Id: Ia45af8994e57806aba42657601648a02cf36f8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620648
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158859}
Mark longtask-in-childiframe-crossorigin.html flaky
See:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Flongtask-timing%2Flongtask-in-childiframe-crossorigin.html
The above-mentioned test fails intermittently with the following
text-diff:
This is a testharness.js-based test.
FAIL Performance longtask entries in cross-origin child iframe are observable in parent. assert_equals: Exactly one entry is expected. expected 1 but got 2
Harness: the test ran to completion.
This CL adds a TestExpectation entry to indicate that the test may
fail.
Bug: 1455314
Change-Id: I903f533e33803f8dfe9b42de1c4c8c006d11e885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619531
Reviewed-by: Nicolás Peña <[email protected]>
Commit-Queue: Sanket Joshi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158858}
[WebView] Add selectmenu autofill toggle for webview.
BUG=1420414
Change-Id: If495955e0e512a34ee6ed2a09bf21ad80d1ff7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618331
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: Peter Kotwicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158857}
[iOS] Adding gambard as ios/chrome owner
I have landed a large amount of CL in the directory.
Bug: None
Change-Id: I8271e5b935b4f83351dedde297c124bcf1dc3de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614557
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158856}
[Private Network Access] Moving PNA permission feature flag to network.
Moving kPrivateNetworkAccessPermissionPrompt flag from content to
service/network.
Bug: 1338439
Change-Id: I76607a1a1de9c5e9955685311798e6a4d02964eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618108
Reviewed-by: Maks Orlovich <[email protected]>
Auto-Submit: Yifan Luo <[email protected]>
Commit-Queue: Yifan Luo <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Titouan Rigoudy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158855}
[BRP] Automatic rewrite to raw_ptr on LaCrOS (June 13th)
This reapplies the rewrite_raw_ptr_fields rewriter on LaCrOS platform.
This change is a merge of the following changes:
PS3 raw_ptr rewrite generated by
rewrite-multiple-platforms.sh chromeos-lacros
PS4 Fixed implicit cast not working around AutoReset
in ash/wm/desks/desks_controller.cc
Bug: 1273182
Change-Id: Iaafc8071d0f41e5a268866abd1b8748bfbc6d0bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607774
Reviewed-by: danakj <[email protected]>
Owners-Override: danakj <[email protected]>
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Mikihito Matsuura <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158854}
pip2: Enable Document picture-in-picture by default
This CL enables the Document Picture-in-Picture API by default.
Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/JTPl7fM64Lc
https://chromestatus.com/feature/5755179560337408
Bug: 1315351
Change-Id: I55b8a5e8e0f1d591cb9de3d0685b7a66997a5046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615052
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158853}
View timeline: Handle offscreen stickiness.
A view timeline subject inside a position:sticky box can get "stuck"
from any of the four CSS offset properties (left, top, right, bottom)
during any of the named view-timeline ranges (entry, contain, exit) or
even while it is entirely outside the viewport.
ViewTimeline::CalculateOffsets previously assumed that stickiness occurred only when the subject was fully contained by the viewport.
This change implements the more general solution.
Bug: 1448294
Change-Id: I842552b3a30078587eff6287e4ee11396d13ed95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616159
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158852}
Add PostQuantumEnabled admin policy to allow for control of rollout of Kyber for key agreement in TLS handshake.
This finishes replacement of the CECPQ2 policy that was deprecateded in M113 (see crrev.com/c/4387832)
Bug: 1442377
Change-Id: I839d693d4127b547be45c4629226c070c383a001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4589869
Reviewed-by: danakj <[email protected]>
Commit-Queue: Hubert Chao <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158851}
[Dialog][Android] Update positive button style for CVC dialog
The positive button on the card unmask prompt should have a FILLED
style.
Mock: https://screenshot.googleplex.com/5dBjL9skq8j32qQ
Before (CVC not filled): https://screenshot.googleplex.com/8eLnLDMqPMTUcfG
After (CVC not filled): https://screenshot.googleplex.com/5rXWeQVgZDnufsV
Before (CVC filled): https://screenshot.googleplex.com/4jEYjV5XxHtXXTn
After (CVC filled): https://screenshot.googleplex.com/9Bns6CFCbkp54kg
Bug: 1356735
Change-Id: I2d8a63c58c812500accc5aa929358fbb5c29b45b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619288
Commit-Queue: Vishwas Uppoor <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158850}
os-credits: improve stub to match current template versions
Use chromite's license code to generate the stub page rather than
maintaining it entirely locally. This better represents the final
page in case there are problems with resources/rendering.
Generated with:
$ ./third_party/chromite/licensing/licenses --placeholder \
--output chrome/browser/resources/chromeos/about_os_credits.html
Bug: b/284974354
Change-Id: I700a812593c9e3e9440f19b35265d160bc6f8356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574573
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Mike Frysinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158849}
[RSS]: Fix truncation in preview page.
Bug: 1455421
Change-Id: I704b5de78b8197d332995423fc33b6ecf1c30ba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620531
Commit-Queue: Finnur Thorarinsson <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158848}
[KeyedServiceRegistration] Late registration DCHECK+DWC instead of DWC
Following multiple iterations of fixes from the reports from the dump
without crashing, changing the DWC to a DWC + DCHECK() so that developers could catch early missing registrations while making sure that safe checks (with safe crash reports) are kept in production.
Bug: 1412439
Change-Id: I4275eb5a37627f9c0f6330ea4f8a07e6da4992bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614306
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158847}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686905867-6fd1d364c971559eaf80bfb10ec70cfe33d1e0ac.profdata to chrome-win64-main-1686916746-0f312f5c9a4cfa50483527eda11a7af1434e7d70.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I91c6d0bdebd294c86d052f8d238a91f49334af29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619754
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158846}
Switch webgl idls from CallWith=ExecutionContext to CallWith=ScriptState
CallWith=ExecutionContext is deprecated, this updates several callers
to the preferred method of taking a ScriptState*.
It also removes it completely when ExecutionContext is not used.
Change-Id: I8d3b754f554a9906efeab3cc94f0fc6cb4007b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608583
Reviewed-by: Brandon Jones <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158845}
Hide account storage notice if kReplaceSyncPromosWithSignInPromos on
Behavior changes are behind kReplaceSyncPromosWithSignInPromos.
Fixed: 1454411
Change-Id: I60cd0992bba9bd6f358f4855cf12b7b5f1a370ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604062
Auto-Submit: Victor Vianna <[email protected]>
Quick-Run: Victor Vianna <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158844}
Log debug_label on shared image failure
Change-Id: I45ab27e90cf344e511c9c4d91e7971f6d1bf4e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618193
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Peter McNeeley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158843}
[Telemetry] Remove feature flags for SD Card & Power Event
Bug: b/286781492
Test: browser_tests --gtest_filter="*TelemetryExtension*"
Change-Id: I53030843c76a3c82eaa0a8aedbb995a9a4ab7eab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606798
Reviewed-by: Bastian Kersting <[email protected]>
Commit-Queue: Denny Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158842}
[iOS] Improve BookmarksCoordinator stop.
This CL:
* rename shutdown to stop as this is the expected name of this method in Coordinators.
* ensure stop is called before dealloc
* call this method in tests were it should have been called
Bug: None
Change-Id: Ie5c6c939f623aa52ace7c920c0065bc5e7e8d1fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604102
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158841}
Add a FeatureParam to control the top-level user interaction requirement
Bug: 1454093
Change-Id: I7383523f2dd95b895ac718b72b14cd77cae7d3d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615919
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Shuran Huang <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158840}
[iOS] dealloc checks SceneController is tearDown
Scene controllers indirectly tear down part of Sign-In promo that
is currently not properly stopped. This allows to indirectly check where
the issue is
Bug: None
Change-Id: I5f1e160d8128dd2e9e155085b95ad2420c6dca6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620193
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158839}
decouple DecoderClient and DawnCachingInterface
DawnCachingInterface will be used for caching shaders from
graphite dawn. It doesn't have DecoderClient.
Bug: 1454867
Change-Id: Ifa7293dd09ada8cea17fa6a129aa680cfc251b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618908
Commit-Queue: Peng Huang <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158838}
Updating the PrivacyHub experiment
Changing the experiment config to be in line with finch.
BUG=b:286994940
Change-Id: I5671101cd06e55140b6b5be08ed41813cb9c831f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614479
Auto-Submit: Jan Láník <[email protected]>
Reviewed-by: Md Shahadat Hossain Shahin <[email protected]>
Commit-Queue: Jan Láník <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158837}
Updating trunk VERSION from 5836.0 to 5837.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I4f878f4c19a12337534390f1e52368c3f47daa6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620459
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158836}
[CR2023] Fix PermissionRequestChipGestureSensitiveBrowserTest.ChipFinalizedWhenInteractingWithOmnibox
This test expects a specific position of LocationIconView. As there're
are a few experimental positioning it does not make too much sense to
test them in CR2023, therefore this CL skips the test.
Bug: 1443577
Change-Id: I142acbbf7e68cd7ff200bf037e14e82e667573b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619433
Commit-Queue: Allen Bauer <[email protected]>
Auto-Submit: Keren Zhu <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158835}
add spvw to scheduler metrics OWNERS
I have indeed passed the metric review quiz.
Change-Id: I3fd0d49c26e34fed2e93dbf5acbb6d3841171dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618220
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Sean Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158834}
Roll Perfetto from e198160115ec to cbeafe489fbd (2 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/e198160115ec..cbeafe489fbd
2023-06-16 [email protected] Merge "Slice table viewer"
2023-06-16 [email protected] Merge "tp: DBv2 - Replace Overlay with SelectorOverlay"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I7a92fc5d617cf410d34a68ce6ed7b5615d816802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620376
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158833}
Add unbranded naming to Password Manager tutorial
Fixed: 1448557
Change-Id: If48326e2d708fd7aeb7f48be71f14c71b70bf3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620231
Reviewed-by: Mickey Burks <[email protected]>
Commit-Queue: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158832}
[ChromeRefresh2023] Update Translate menu item to be correctly enabled/disabled depending on webpage.
Bug: 1427667
Change-Id: Ie2dde735494897192abf372be654edec1b4e6566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611162
Reviewed-by: manuk hovanesian <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Allen Bauer <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158831}
Prevent WebApp from storing shortcuts menu vectors of different lengths
This combines `SetShortcutsMenuItemInfos` and
`SetDownloadedShortcutsMenuIconsSizes` into a single method:
`SetShortcutsMenu`, that takes two vector arguments and CHECKs they are
the same length.
Bug: 1427444
Change-Id: Id06a89996230b6e6739459963843de080b87e039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613046
Commit-Queue: Dibyajyoti Pal <[email protected]>
Reviewed-by: Dibyajyoti Pal <[email protected]>
Auto-Submit: Glen Robertson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158830}
Move DawnContextProvider to //gpu/command_buffer/service
DawnContextProvider is not necessary to be in components/viz/common,
however to support storing dawn shader cache, it needs to use some
classes in //gpu/coimmand_buffer/service. So move it to
//gpu/command_buffer/service
Bug: 1454867
Change-Id: Icffccd0b05b2683f47f21b5e03871dd826697f2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619148
Reviewed-by: Bo Liu <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Auto-Submit: Peng Huang <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Reviewed-by: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158829}
[iOS] dealloc checks TabGridCoordinator was stopped
Bug: None
Change-Id: I8b6e9db8de0048e312c0f229a3dbf434c1236d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614762
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158828}
[SFL] Track products by default if flag is enabled
This patch implements the "track by default" behavior when
bookmarking a product. The automatic tracking is implemented in a
cross-platform observer where we can easily determine if the bookmark
is new. Consequently, the price tracking view now observes the
subscriptions system to make sure the toggle shows the correct state.
Triggering the bookmark dialog a second time will not attempt to
update the tracking state unless the user explicitly changes it.
Bug: b:281061660
Change-Id: I69659c3e04885bba851d3676a99243a2c275076b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606313
Reviewed-by: Mei Liang <[email protected]>
Reviewed-by: Emily Shack <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158827}
[iOS] Move system flag file to shared folder
Bug: 1319852
Change-Id: Id92b9441225ea715490f3860318bc3ca248d3cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618030
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158826}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686905867-ddc26d8742b62c913ee01301f9a4afa8d16a21d6.profdata to chrome-win32-main-1686916746-51e5f564e2e7c1a3d8d22d73b6c790cce1590e4f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I9735e0a83720be631388d0663a17b3e441910155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618745
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158825}
Add basic end-to-end Private Aggregation Web Platform Tests
These tests ensure that a report makes it to the expected endpoint.
Only tests in Shared Storage worklets for now
Bug: 1452248
Change-Id: I70ad2180c7cde93beb5ffe08fe3c1a091bf298d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598993
Reviewed-by: Yao Xiao <[email protected]>
Auto-Submit: Alex Turner <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158824}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686830699-ce1fbbdedb7ffca2c4ba20e3bcdc16ae7aa5aea8.profdata to chrome-chromeos-amd64-generic-main-1686916746-c5ce1cf7a3b233e2225a4be30a7d5105e3097803.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I577a75f22d30dc265fef594eb49858632cd55249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620750
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158823}
[iOS] Update info image to symbol
This image was shown in Safety Check.
Bug: 1444063
Change-Id: I92f524b1c04d061a4c15cdfdd33a4745b32091e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614820
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158822}
Revert "[tracing] Adapt perfetto config for Chrome"
This reverts commit c646c4a3379d17a9081a3fbaf9753e10d5cbb907.
Reason for revert: Suspect for multiple tracing related test failures across many bots. Example failures: https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/20521/overview
Original change's description:
> [tracing] Adapt perfetto config for Chrome
>
> This CL implements tracing::AdaptPerfettoConfigForChrome()
> that modifies a simplified perfetto::TraceConfig to make it
> suitable for tracing, by adding e.g. buffer config and chrome config to every data source.
>
> AX-Relnotes: n/a.
> Bug: 1418116
> Change-Id: I4c1d8fea15fae469da8b82a89ca63991ecbc72c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585409
> Reviewed-by: Alexander Timin <[email protected]>
> Reviewed-by: Eric Seckler <[email protected]>
> Reviewed-by: Ramin Halavati <[email protected]>
> Commit-Queue: Etienne Pierre-Doray <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158778}
Bug: 1418116
Change-Id: I5e81d80a9fc474f59e9eb727be304579a2747490
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617038
Commit-Queue: Kevin McNee <[email protected]>
Auto-Submit: Kevin McNee <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158821}
Automatic update from google3
Automatic update for 2023-06-16 UTC
Change-Id: Iff7b1758574e7b7d57513b9b6d37799f815ffb52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614819
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158820}
Use WeakPtr to track lifetime of reporting_client
Bug: 1453209
Change-Id: I3ed10356f842b399d8cfbcedd0999cad19370dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615195
Commit-Queue: Nasser Al-shawwa <[email protected]>
Reviewed-by: Dominique Fauteux-Chapleau <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158819}
Update V8 to version 11.6.181.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dbc49b76..3cbcb789
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I5371ee250fde7d69aae8fb7817b7b60b97182ca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619731
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158818}
Roll ANGLE from edf58105d695 to 498c744bc7a1 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/edf58105d695..498c744bc7a1
2023-06-16 [email protected] Roll vulkan-deps from cebf5626ca50 to 58c6e1ea988a (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ia6478eabd12a3c27a6e5526be563bd4aba86888f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619583
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158817}
[ios] Use base::apple::FrameworkBundle()
Instead of using `[NSBundle mainBundle]` use the helper from
//base/apple/bundle_locations.h which should be preferred.
Usage of FrameworkBundle() and MainBundle() always return the
same value for Chrome, but for code that is built in a framewok
such as iOS WebView, it allow to locate the resource in the
correct location, thus FrameworkBundle() has been preferred.
Bug: none
Change-Id: I3794165b40ce989f70248a2d711ffc91315ad3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614597
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158816}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686895138-563f8b073abc7300eb45545d285cd1b7b40e1e23.profdata to chrome-linux-main-1686916746-09b7af15a61678b00a2a57b4a73a05cecbae171a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I52b2f2341ecadd17f9ca482c6f68e7e45dd5558d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620372
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158815}
Automatic update from google3
Automatic update for 2023-06-16 UTC
Change-Id: Ieb8f8d0f37c203e35700ed6ac1a277988adc50f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620528
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158814}
Fix threading PermissionAuditingService.
In PermissionAuditingService, the after start-up task should be
posted to the UI thread as opposed to the background thread pool.
Bug: 1342896
Change-Id: I44d344884f18e37ae4058179d760f7d828b49afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620687
Commit-Queue: Kamila Hasanbega <[email protected]>
Auto-Submit: Kamila Hasanbega <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158813}
[Choice][iOS] Add command to dismiss the choice screen.
Bug: b/280753739
Change-Id: Iaee886b9da1917afe0bbcf4823ae49b122c7ba3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615417
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Auto-Submit: Samar Chehade-Lepleux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158812}
[Gardener] Disable flaky crostini.RestartApp test
Bug: 1455410
Change-Id: Ib9463a71baa0655a3dc2beac4a31673c02b97785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618040
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158811}
VideoTrackRecorder: get rid of callbacks.
Prepares for a nicer implementation of crrev.com/c/4582364 by
switching the callback interface from callbacks to a callback interface.
Bug: b:275663480
Change-Id: I26b72ef913612bff31bfa9d52b7536a8d1272d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615037
Commit-Queue: Markus Handell <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158810}
Updating XTBs based on .GRDs from branch main
Change-Id: Ie8e8abe22e4c3b36aed7da09caa44940d9306e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617010
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158809}
[iOS] BookmarksEditorCoordinator dealloc checks stop was called
Bug: None
Change-Id: Iaa32021dde9bbb8aebb2cb35be67632000889672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604496
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158808}
Move kReplaceSyncPromosWithSignInPromos-related tests
These were previously in SingleClientHistorySyncTest, and are now moved
to SingleClientStandaloneTransportSyncTest instead.
Various non-history-related types are going to be added to these, so it
makes more sense to have them in a common place.
Bug: 1448887
Change-Id: I3a30747be8d5012e58db0a76327ff9c2240bbba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614478
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158807}
Sort tasks as they appear in the companion web app
For this purpose Task's `position` [1] field is used.
[1] https://developers.google.com/tasks/reference/rest/v1/tasks
Bug: b/287323797
Change-Id: Ie3ed0d9526c2acc644730ddc3128bffaafa7f329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615204
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Artsiom Mitrokhin <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158806}
[OOBE][CHOOBE] Handle CHOOBE flow in existing browser tests
Bug: b:287546383
Change-Id: I52c8042b1ca1e73a3bd0b0cde4c3eb639090d56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614882
Commit-Queue: Osama Fathy <[email protected]>
Reviewed-by: Brahim Chikhaoui <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158805}
Support input protection in new permissions UI
Bug: 1449007,1451308,1451322,1453929
Change-Id: I9266184f5d8de3d030fdc280a12222111eb4b0f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604326
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Thomas Nguyen <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Florian Jacky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158804}
[Fontations-backend] Roll Fontations libraries
Includes fixes for variable font metrics when font has no HVAR table.
Bug: 1446251
Change-Id: I678114c8d922140766a5f28f93ae263964f2e2f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620529
Reviewed-by: Kevin Lubick <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158803}
Add dependency to libavifinfo.
Will be used for avif gain map support.
Bug: 1451889
Change-Id: Ia4d1587d358edd291cc45936c2ca906d2a6c65d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593550
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: Maryla Ustarroz-Calonge <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158802}
Roll WebRTC from 6c453b7d5914 to 213090bf4bab (1 revision)
https://webrtc.googlesource.com/src.git/+log/6c453b7d5914..213090bf4bab
2023-06-16 [email protected] Add AbsoluteCaptureTime RTP extension to supported list in engines.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ic4e0c9bd975d8bd5061439f3f14d3e9ad95a8eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619586
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158801}
Enable permission request creator mock for all test.
Bug: b:276874936
Change-Id: I6917e05386daff46d3b4cee654f97cadc6c727e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614524
Reviewed-by: James Lee <[email protected]>
Commit-Queue: Tomek Jurkiewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158800}
Privacy Guide: Fix button double click crash
Due to a known issue on Android, buttons don't detect double/multiple
clicks by default and instead queue multiple callbacks. If the user
manages to press certain buttons multiple times before their visibility
is updated, this can lead to unpredictable behavior/crashes.
To fix the issue, we don't only rely on Android updating the visibility
in a timely manner, but restrict the conditions under which the button
callbacks can be executed.
Bug: 1455401
Change-Id: I61f984167c9f9d65128a4a0df8be5acbbd26ad82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620333
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Rubin Deliallisi <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158799}
Refactor cryptbase warmup for sandboxed processes
base::RandBytes & other locations in Chrome & boringssl call
RtlGenRandom/SystemFunction036 to obtain random bytes. This
function is delayloaded via advapi32 (forwarded to cryptbase).
In processes which need to call these functions after sandbox
lockdown (LowerToken) we ensure these modules are preloaded through
a variety of mechanisms.
This CL refactors these calls to rand_s or base::RandBytes to
use a single helper that does the exact warmup required by
calling RtlGenRandom.
This refactoring will help us migrate to ProcessPrng rather
than RtlGenRandom.
Note: as partition_alloc currently calls RtlGenRandom very
early in chrome_elf this warmup is not strictly necessary - but
it will be required when we change those calls in followup
CLs.
Note2: We cannot call CRYPTO_pre_sandbox_init() as it does not
load the libraries required.
Bug: 74242
Change-Id: I273a7bb7594468c10bd667ee88e6c70520e5a95f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611509
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158798}
[DIPS] Crash fix and mitigation measures
This CL enhances some inlined function returned values by initially
making sure the render frame host exists before using it.
This approach is chosen because it is suspected that the crash was due
to a UAF of a render frame host associated to a (termicated)
prerendering page.
Bug: 1454412, 1455024
Change-Id: I4bc9e0fe2d84c5383681b74ce4fe420890d49d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615751
Auto-Submit: Jonathan Njeunje <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Quick-Run: Anton Maliev <[email protected]>
Commit-Queue: Jonathan Njeunje <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158797}
[UPMLocalPwd] Move the warning bridge to chrome_java
This will be used as glue code capable of injecting chrome_java
implementations into the modularized warning component. These include
the launcher for the sync flow as well as the password export flow.
Low-Coverage-Reason: The bridge only contains plumbing code.
Bug: 1454770
Change-Id: I1f2432c8b28223707a31d0b81ed7ba58d7f76874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614953
Reviewed-by: Ivana Žužić <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158796}
[password manager] Add "Passkey deleted" toast
Add a "Passkey deleted" toast that shows up after a user deletes a
passkey.
UXW review:
http://go/passkeys-in-chrome-pwm-uxw
Screnshot:
https://storage.cloud.google.com/chromium-translation-screenshots/047dd4e48a7b3db0092b563b76f9087c4190990d
Design doc:
https://docs.google.com/document/d/1Ox_VBGNO-Ff9bcP97FUMcN15Xtfn_sz0_WuDe3ujbwA
Bug: 1432717
Change-Id: I8a35c818820f45c532087233563fc47e4d0ecb58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609159
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Auto-Submit: Nina Satragno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158795}
Roll devtools-internal from 53ddeb979c08 to 9735ecefbc6b (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/53ddeb979c08..9735ecefbc6b
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c50bd0522843fe1a11d4851dfa3393fa94cde1bd..58b07f2c68b92a013d060093d3a1477633b87ce0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I380a5e16e4a5097687c315a3401d166ec87ae088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618083
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158794}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686909435-d67db318458af41c3aa3b4f58a2148c9a473c934.profdata to chrome-mac-arm-main-1686916746-66523039a329f08d3cf7331e58947a76e14bf8ef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I139c2cffe3f11c77b0055fda63054a164f9d3bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619582
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158793}
[Gardener] Disable flaky EncryptedMedia browser test
Disabling EncryptedMediaSupportedTypesExternalClearKeyTest.Video_MP4
because of flakiness.
Bug: 1451037
Change-Id: Id6c57f7fb15e7d688ba340eebe2a13d9cadf3f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618112
Commit-Queue: Antonio Sartori <[email protected]>
Owners-Override: Antonio Sartori <[email protected]>
Auto-Submit: Antonio Sartori <[email protected]>
Reviewed-by: Thomas Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158792}
[iOS] Show snackbar confirming sign out from account settings.
Show a snackbar after signing out from the account settings page.
Bug: 1447017
Change-Id: I8305cc7d8cda7b7af4c818be1a30e307d243e9d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618034
Commit-Queue: Jood Hajeer <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158791}
Bump BiDi Mapper
Bug: chromedriver:4226
Change-Id: Ib499870ad2915ce0041eabe8bcb03190ebca5317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615087
Reviewed-by: Thiago Perrotta <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Auto-Submit: Maksim Sadym <[email protected]>
Commit-Queue: Mathias Bynens <[email protected]>
Commit-Queue: Thiago Perrotta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158790}
Allow resetting sync consent on all platforms.
This CL removes the code that clears the primary account instead of
revoking the sync consent on iOS. This logic was never used on iOS
and the team is working to add support for Unicorn accounts which
may actually need it.
This CL removes the special handling for AccountConsistency::kDisabled
due to the following considerations:
1) ChromeOS: regular profiles have AccountConsistency:kMirror, other profiles do not have a primary account.
2) iOS and Android: regular profiles have AccountConsistency:kMirror, incognito profiles do not have a primary account.
3) Desktop: regular profiles have AccountConsistency:kDice or AccountConsistency:kDisabled. But when it is disabled, the user is signed out of Chrome and cannot sign in to Chrome. So user cannot
revoke the sync consent in this case.
Bug: 1165785
Change-Id: Ib0a8cbbaac846cd1b262919b750ba49cf58aa0e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607390
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: James Lee <[email protected]>
Commit-Queue: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158789}
[iOS] Update sign out section in the account settings UI.
The unified settings page shows the sign out section below the advanced
settings section.
And it has multiple items to manage accounts and sign out.
This CL updates the position of the section in the account settings and
introduces the first item in it; Sign Out.
Screenshots in crbug.com/1447017#c12
Bug: 1447017
Change-Id: I85cab9a59a6aeedb46eef1e8c6c3d0f1c84c4107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608011
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Jood Hajeer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158788}
OOBE: Add osamafathy@ to LOGIN_LOCK_OWNERS
Bug: none
Change-Id: I3e0c470a700d2012876f35822731fa4eb8b8b891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620548
Reviewed-by: Renato Silva <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158787}
[What's New] Update refresh page logic to replace 117/118 milestones
The final url to use for the refresh page will be the M117 url in order
to reuse the server-side redirect logic. In order to use this, both the
117 and 118 milestones must be reserved for the refresh page. The
redirect will make sure chrome://whats-new will show the refresh page
until a new WNP is released.
Bug: 1447231
Change-Id: I5a191368aaa984c0166ae0cef55ac8dc3a0aeb6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602533
Commit-Queue: Mickey Burks <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158786}
Choose the correct file extensions when cross-compiling for Windows
When building a shared lib for the host tools toolchain, use .so on
Linux, .dylib on Mac and .dll on Windows. Don't use the target's
file extension.
When building a batch file to run the rust unit tests on Windows, use
the .exe extension even if building that batch file on a Linux
machine.
[email protected], [email protected]
Bug: 1271215
Change-Id: If90ea0013655a6c89e96688c9f9610b6539eb149
Cq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-dbg,android-rust-arm64-rel,mac-rust-x64-dbg,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-dbg,win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619088
Commit-Queue: danakj <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158785}
Roll WebRTC from 45666d4b0124 to 6c453b7d5914 (1 revision)
https://webrtc.googlesource.com/src.git/+log/45666d4b0124..6c453b7d5914
2023-06-16 [email protected] Light-weight detection of static content when using WGC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1421242
Tbr: [email protected]
Change-Id: I1d42fe95eb11e13a4d62be6be6ccf1106e046cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619237
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158784}
[iOS] Fix weakSelf in FirstRunCoordinator
Change-Id: Idc2946d36cbbac4b713e819fb2cdba9a08e58b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615581
Commit-Queue: Arthur Milchior <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Auto-Submit: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158783}
ambient: Add image download result managed screensaver metric
This CL adds a metric to record the result from downloading an image
to display in the managed screensaver.
Bug: b:278036775
Test: ./ash_unittests --gtest_filter=ScreensaverImageDownloaderTest.*
Change-Id: Iddec48c6db06d6014a596b41b4edca5526a32755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604011
Commit-Queue: Emmanuel Arias Soto <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Reviewed-by: Maria Petrisor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158782}
Allowlist the test_control_flow_guard.exe for non-determinism
This is done with a TODO while we work upstream to fix Rust-link-driven
Windows exe non-determinism issues. Upstream does intend to have
Rust able to produce deterministic results and there were already
tests for this that were disabled on Windows due to the reasons
being unclear which have now become clear thanks to our determinism
bots!
Upstream issues:
https://github.com/rust-lang/rust/issues/112586
https://github.com/rust-lang/rust/issues/112587
Bug: 1453509
Change-Id: I582e46792934d44866a45d9b57b2c7b64b52a2e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618949
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158781}
Remove stale Blink expectations
Autogenerated CL from running:
//third_party/blink/tools/remove_stale_expectations.py --project chrome-unexpected-pass-data --no-include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --large-query-mode --num-samples 200 --jobs 2
Affected bugs for CL description:
[email protected]
Bug: 1044742, 1081534, 1088475, 1196620, 1276290
Bug: 1452222, 24182, 626703
Change-Id: I359394f744a007735aac8b5f365367bfb7e87d0d
Fixed: 1279220, 1441416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618775
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158780}
[relaunch_notification] Remove dead code
RelaunchNotificationController::SetDeadline was dead code.
Bug: none
Change-Id: I99987aa46f872325c3f0add002e00bd162ed6117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620587
Auto-Submit: Greg Thompson <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Commit-Queue: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158779}
[tracing] Adapt perfetto config for Chrome
This CL implements tracing::AdaptPerfettoConfigForChrome()
that modifies a simplified perfetto::TraceConfig to make it
suitable for tracing, by adding e.g. buffer config and chrome config to every data source.
AX-Relnotes: n/a.
Bug: 1418116
Change-Id: I4c1d8fea15fae469da8b82a89ca63991ecbc72c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585409
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158778}
chromedriver: open/write to all files with UTF-8 encoding
Bug: None
Change-Id: I074c501559e991650b1f932b42887de728d6b834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614522
Auto-Submit: Thiago Perrotta <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Commit-Queue: Thiago Perrotta <[email protected]>
Reviewed-by: Vladimir Nechaev <[email protected]>
Commit-Queue: Mathias Bynens <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158777}
Remove SetPrinterConfigurerForTesting() from printer_configurer.{h,cc}
Unused after crrev.com/c/4568367
Bug: None
Change-Id: I846cdaeb7b646530db3ee3ceb3f9e7e50443c15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620330
Reviewed-by: Piotr Pawliczek <[email protected]>
Commit-Queue: Andrew Rayskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158776}
[StartTablet] Clean up favicon of single tab card after hidden.
Bug: 1455250
Change-Id: I7b8c2f36c32a1f03531ab499d64a84dd4887b48b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617729
Code-Coverage: Findit <[email protected]>
Reviewed-by: Xinyi Ji <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158775}
[OOBE][CHOOBE] Fix positioning of the preview title in touchpad screen
Bug: b:287231716
Change-Id: I6f19366a55a61a6ab8906127688afc8d086d8d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619807
Auto-Submit: Osama Fathy <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Reviewed-by: Brahim Chikhaoui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158774}
Reland "Move test files to Connectors test folder"
This is a reland of commit d6f0aaec102ba6596a440a7c55185e86f378bc19
Original change's description:
> Move test files to Connectors test folder
>
> The utils/classes in these files are mostly used by enterprise
> code, so moving them to chrome/browser/enterprise/connectors/test/
> makes them closer to where they are used, and a new target to build
> them will make future dependencies easier to manage.
>
> Bug: b/284950910
> Change-Id: I5fea8f405b795d24e8998bf9b7d3ba4180ee8db1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575362
> Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
> Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Reviewed-by: Min Qin <[email protected]>
> Reviewed-by: Sébastien Lalancette <[email protected]>
> Reviewed-by: Daniel Rubery <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Reviewed-by: Alan Screen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157562}
Bug: b/284950910
Change-Id: Iddd0db7040a0f1f56dc58c0bdeb85d68541c70b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614452
Code-Coverage: Findit <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Reviewed-by: Sébastien Lalancette <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158773}
PrefRegistrySyncable: Point to components/sync_preferences/README.md
PrefRegistrySyncable defines the PrefRegistrationFlags for syncable
preferences, which must also be added to a SyncablePrefsDatabase.
This CL adds a pointer to the relevant README.md file.
Bug: 1448000
Change-Id: Ide6f381b9d2f0ec285e06d490ff89dfbe0d2771d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615006
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: Dominic Battre <[email protected]>
Auto-Submit: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158772}
Update banner for dark mode
* This change adds css for the banner to look similar to cr-dialog in dark mode.
* Add the kite icon in dark theme for banner.
* Disable kite icon being read by screen reader.
Screenshots after CL:
Light mode: https://screenshot.googleplex.com/APmBCe2aq5YUfYX
Dark mode: https://screenshot.googleplex.com/92s2f9RFbc9bbh8
Bug: b/285297474, b/285556982
Change-Id: Id53e6fad0be832b4de19a32d7e9c42d63d6d712b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583148
Commit-Queue: Liza Bipin <[email protected]>
Reviewed-by: James Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158771}
Update V8 to version 11.6.179.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e42fcf13..dbc49b76
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I7e5ba66d45f2e69446870d61a392fe6a573e0640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620407
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158770}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686895138-918a247a987b0cc310c232535178fd89bf08b29a.profdata to chrome-win32-main-1686905867-ddc26d8742b62c913ee01301f9a4afa8d16a21d6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Iad092b0ea9f329e2403078e566eca430e86767dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620296
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158769}
[iOS][Bkmrks] Cleanup bookmark promo controller
Removes the property `_isIncognito` because it is always `NO`. That's
because it uses the original browser state which is never off the
record.
No behavior change in this cl
Fixed: 1426262
Change-Id: I1fd4275fdf31276c58172eaf30eb3343d12017a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614570
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158768}
[DBSC] BoundSessionCookieRefreshService delays updating renderers
OnBoundSessionUpdated() should change the `cookie_controller_` state
first and only then notify renderers about an update.
The unit test didn't catch this bug because the tests were only checking
that a renderer update closure is called but didn't verify the
bound session state within this closure. This CL also hardens unit tests
to verify that.
Bug: b/263264391, 1392135
Change-Id: I9f75e6360418f392d1c5472d21a647fb0187779d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615895
Commit-Queue: Monica Basta <[email protected]>
Reviewed-by: Monica Basta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158767}
Remove hover card alternate layout
Remove the hover card altnate layout code and flag since it is not
being used.
The hover card discard status was being shown whether the
DiscardedTabTreatment or MemoryUsageInHovercards are enabled. This CL
also properly gates the hover card discard status so that it will only
be shown when the DiscardedTabTreatment flag is enabled.
Bug: 1451558
Change-Id: I25871b9526b97bd47c6a8c27b37ff3247beac727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604638
Reviewed-by: Eshwar Stalin <[email protected]>
Reviewed-by: Shibalik Mohapatra <[email protected]>
Commit-Queue: Steven Luong <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158766}
Roll devtools-internal from 127e63f85d6f to 53ddeb979c08 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/127e63f85d6f..53ddeb979c08
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/07a5677c02d447d10b5a7a4a42375397c8d55d69..c50bd0522843fe1a11d4851dfa3393fa94cde1bd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ic802b06c54003aa0e8e10c121d5ca1f292044f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619579
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158765}
[iOS] dealloc checks BookmarkPromoController was shutdown.
Bug: None
Change-Id: Ib3afda9099193b553d28c381b80b8d526eabe5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616068
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158764}
BiDi mapper: pull.sh: use latest revision from 'main' by default
Bug: chromedriver:4226
Change-Id: If970824c92c9c4ebbef838fa3ae533665765e333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615791
Commit-Queue: Mathias Bynens <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Auto-Submit: Thiago Perrotta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158763}
[WhatsNew] Update metrics
This CL
- Dismiss What's new on |SceneActivationLevelBackground| if it was open.
- Record |WhatsNew.Promo.Displayed| only if we actually show the promo.
- Record and dismiss What's New on swipe down.
Change-Id: I2e35a27f7b3420014e7e632d75c31bbe9412d0ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591151
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Cheick Cisse <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158762}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686895138-39a675bf66a650699dfadbaf5c196e0db08825c0.profdata to chrome-win64-main-1686905867-6fd1d364c971559eaf80bfb10ec70cfe33d1e0ac.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I38510340f6f39e3623145f02bc86684655afca1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618742
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158761}
ambient: Add downloaded image count managed screensaver metric
This CL adds a metric to record the amount of images that are
successfully downloaded to the managed device.
Bug: b:278064968
Test: ./ash_unittests --gtest_filter=AmbientManagedPhotoControllerTest.*
Change-Id: I32f92c3dc86ba200dd80441b74b82ab6624a6b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603792
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Maria Petrisor <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Commit-Queue: Emmanuel Arias Soto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158760}
[UPMLocalPwd] Save in the prefs that user has acknowledged the warning
The CL saves in the profile prefs that the user has acknowledged the warning. This is needed to not show the warning repeatedly.
Bug: 1455349
Change-Id: I36e9d566df4156d9e0664ab27b4e686bfbc38d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614427
Code-Coverage: Findit <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Anna Tsvirchkova <[email protected]>
Reviewed-by: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158759}
Fix new wpt failures
1) Don't save border-box when it's default value.
2) Fix wpt test to accept both normalized and unnormalized path.
Fixed: 1455148
Change-Id: I99b62261f0e567af947274d939ef90c4e0bc904e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614757
Commit-Queue: Daniil Sakhapov <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158758}
Reland "Add initial version of PKCS12 certificates import to chaps."
This is a reland of commit 35a50dd76abe4a5e7b5978fceee4ebe95dd55f78
Original change's description:
> Add initial version of PKCS12 certificates import to chaps.
>
> Initial version has changes to chaps utils and unit test.
> "Import user certificate" button's action is still not changed
> and user's certificates will be still imported to NSS slots.
> More unit tests will be added later to cover all corner cases.
>
> Bug: b/264385929
> Change-Id: I6ee7637b575854b224f834ecf2d69c72f6ed94cd
> Testing: added basic unit test.
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4286781
> Reviewed-by: Pavol Marko <[email protected]>
> Commit-Queue: Oleksandr Sarapulov <[email protected]>
> Reviewed-by: Michael Ershov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157541}
Bug: b/264385929
Change-Id: Ifde3323624f3d7867354b88e4fa9cc3c61efe3b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614959
Reviewed-by: Pavol Marko <[email protected]>
Reviewed-by: Michael Ershov <[email protected]>
Commit-Queue: Oleksandr Sarapulov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158757}
Roll Perfetto from b844c46c85e7 to e198160115ec (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/b844c46c85e7..e198160115ec
2023-06-16 [email protected] tools/install-build-deps support .tbz2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ibf8d3f2dec385f06269fe57bd5c6133278a1f63d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619145
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158756}
[ios] Make PasswordManagerViewController independent from Browser
This CL makes PasswordManagerViewController independent from Browser
and BrowserState by injecting the specific dependencies instead of
the entire object.
Bug: 1454018
Change-Id: I63d9f576e66c7b4a346c737695a1fab4eee86c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601268
Commit-Queue: Federica Germinario <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158755}
iwa: Remove superfluous TODO and add parameter hints to test
[email protected]
Bug: none
Change-Id: I65a7d69795f89ec5614421563629c26a1c407d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620329
Reviewed-by: Sonja Laurila <[email protected]>
Commit-Queue: Sonja Laurila <[email protected]>
Auto-Submit: Christian Flach <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158754}
[Privacy Hub] Increase scope to stop pinging GLS
Increase the scope of PH Geolocation toggle to also include the IP-based
geolocation. So when users disable the PH location toggle, device will
stop making any geolocation-related requests. All Geolocation clients
should seamlessly pause/resume scheduling on
'kUserGeolocationPermission` user preference updates.
Bug: b:281657093
TEST=out/Default/chromeos_unittests --gtest_filter=*SimpleGeolocation*
TEST=testing/xvfb.py out/Default/unit_tests \
--gtest_filter=*NightLightClientImplTest*
TEST=testing/xvfb.py out/Default/browser_tests \
--gtest_filter=*WizardController*
TEST=testing/xvfb.py out/Default/ash_unittests \
--gtest_filter=*GeolocationControllerTest*
TEST=testing/xvfb.py out/Default/browser_tests \
--gtest_filter=*TimeZoneResolverManager*
Change-Id: I606fcd20d2c7d7f6bb8930391963e33761501122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4537319
Commit-Queue: Zauri Meshveliani <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Auto-Submit: Zauri Meshveliani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158753}
[Gardener] Disable flaky FedCM WPT web test
virtual/fedcm-multi-idp/external/wpt/credential-management/fedcm-multi-idp/abort-multiple-gets-through-first-idp.https.html seems to be very flaky on Mac.
Bug: 1455245
Change-Id: I7d3f68252b002c78470ec135cf695486fd70a70e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620310
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158752}
[Files]: Adds UMA that records the time used in recents by FSP.
Here FSP is file system provider. This CL adds a UMA to be used in
recents when recents view gains the ability to show recent files from
file system provider volumes.
Bug: b:244395002
Change-Id: I2d86259855ae36845b447d1f8c5f924496c63ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619770
Reviewed-by: Nigel Tao <[email protected]>
Commit-Queue: Bo Majewski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158751}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686901619-f7dbd33d86d5f324306743fb3cc94e2f42245acd.profdata to chrome-mac-arm-main-1686909435-d67db318458af41c3aa3b4f58a2148c9a473c934.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I89678a70d030f21cd5d098ba601856e268c623e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619146
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158750}
[Telemetry] Remove feature flag for Keyboard event
This change removes the feature flag for the Keyboard Diagnostic event.
Bug: b/278670637
Test: browser_tests --gtest_filter="*TelemetryExtensionEventsApiBrowserTest*"
Change-Id: I16a21855c98befc3d4556b20a764821434ff822d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620268
Commit-Queue: Bastian Kersting <[email protected]>
Reviewed-by: Oleh Lamzin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158749}
[ios] Use helper to access the framework bundle
Use base::apple::FrameworkBundle() helper to access the framework
bundle. In iOS WebView this is set in WebViewWebMainDelegate) and
for Chrome on iOS it is identical to base::apple::MainBundle()
which is correct even when building all of Chrome code in a
framework for PartitionAlloc.
Bug: 1257402, 1452229, 1434760
Change-Id: I8e16c9c88ac7feef76b9ee5c91fa1ec567911a06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614515
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158748}
Update field trial for secagentd coalesce terminate
Bug: b:287180930
Change-Id: Ie21e26443815618f125c6c8392976cc1d1881e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615451
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Commit-Queue: Ryan Borzello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158747}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686851973-3a78e5ad1727a0891f09496acf5b321f06ff842f.profdata to chrome-mac-main-1686895138-21cc5c15c8ced578a0a7662848c34ed22f64914c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Iab10f5659cb64517fa84f09f294575bd90ff4faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618686
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158746}
Add option to opt out of global cap for HaTS surveys
This allows individual surveys to not be capped by the (current) cap of one survey of any type per 60 days. Surveys can set their own cap of surveys per n days instead.
BUG=b/286169172
Change-Id: I594916a363d4b4ca05450e7130ef5cba7f83ff4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574250
Reviewed-by: Ian Barkley-Yeung <[email protected]>
Commit-Queue: Lucy Qu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158745}
Revert "Reland [omnibox] Split WebUI impl out from OmniboxPopupViewViews"
This reverts commit b5f110c5ce5d064d061e4bf55387234e225c55fb.
Reason for revert: OmniboxPopupViewWebUITest failing on MSan, see https://crbug.com/1455368
Original change's description:
> Reland [omnibox] Split WebUI impl out from OmniboxPopupViewViews
>
> This CL relands the refactoring code changes while addressing the
> test failures that caused this revert:
>
> [Revert "[omnibox] Split WebUI implementation out from OmniboxPopupViewViews" (4618013) · Gerrit Code Review](https://crrev.com/c/4618013)
>
> Bug: 1445142
> Change-Id: I86f37190d8c8a14e3cf683f18884debff09468c1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619093
> Reviewed-by: Moe Ahmadi <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Commit-Queue: Orin Jaworski <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158624}
Bug: 1445142, 1455368
Change-Id: Iec98f89474c6bdbb30d440188ce180841cb19e36
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615421
Commit-Queue: Antonio Sartori <[email protected]>
Owners-Override: Antonio Sartori <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158744}
[WebAuthFlow] Cleanup profile cannot open window error code
Follow up on https://crrev.com/c/4542942.
Bug: 1445824
Change-Id: Ibe710e43d646f75a285480fd953718a1f9535b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4555600
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158743}
Roll Projector App from hchZm_hzNx6tC8nyx... to S4PFqJJIa0tcPH4y4...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306160100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/S4PFqJJIa0tcPH4y4xLaAEijddayevF1uPmPoqXFgpEC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/265204738,b/269626503
Tbr: [email protected]
Change-Id: I0ee9bb6bbd5253c91adacb9bcd1babbcfd81ba6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617582
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158742}
Roll Perfetto from 0ba4c2cd1226 to b844c46c85e7 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/0ba4c2cd1226..b844c46c85e7
2023-06-16 [email protected] Merge changes I983be26f,I2603ede2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I138a83dd7a98cb72bbba4d9b894c80b0be42548a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619752
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158741}
Roll devtools-internal from 262d7a9f5103 to 127e63f85d6f (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/262d7a9f5103..127e63f85d6f
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/738f63172f4e669e9d16a70edbdf5feb1b3c9e01..07a5677c02d447d10b5a7a4a42375397c8d55d69
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I6cc1a48cb407aba3a9765fa48de509fbdced6d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619143
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158740}
Add histogram to record fallback result of WebSocket
There are some histograms that record WebSocket handshake results.
However none of them record whether a WebSocket handshake got involved
with HTTP/1.1 fallback. Add a histogram that records whether
WebSocket handshakes get involved with fallback.
Bug: 1455328
Change-Id: I7d352f5c11948398cd6d1e8081cc39017c8b4234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618051
Reviewed-by: Adam Rice <[email protected]>
Reviewed-by: Nidhi Jaju <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158739}
Refactor form fields to use raw_ptr.
The CL removes all the RAW_PTR_EXCLUSIONs from
components/autofill/core/browser/form_parsing/ and updates functions
signatures as necessary.
During this process a dangling pointer was detected and fixed in
phone_field_unittest.cc
Bug: 1454452
Change-Id: I806e20467077dce8c3f52a91db38fcb2588e955a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609162
Commit-Queue: Norge Vizcay <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158738}
Roll src/chrome/browser/internal/ 9aa1b003c..e7e78db02 (1 commit)
https://chrome-internal.googlesource.com/chrome/browser_internal.git/+log/9aa1b003c117..e7e78db02b50
$ git log 9aa1b003c..e7e78db02 --date=short --no-merges --format='%ad %ae %s'
2023-06-14 fernandex Update password for [email protected].
Created with:
roll-dep src/chrome/browser/internal
Bug: 1454818
Change-Id: I1f96d0ecb10753ff53de5fdea83dd92c6dd12f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620327
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Nohemi Fernandez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158737}
[ios] Remove an unused method from UserActivityHandlerTest
This CL removes GetTabIdForWebState() from UserActivityHandlerTest
because there is no caller of this method.
Bug: 1450598
Change-Id: Ic93848279bfe454cb03484256b7ea7cf9cdc80d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614694
Reviewed-by: Éric Noyau <[email protected]>
Auto-Submit: Asami Doi <[email protected]>
Commit-Queue: Éric Noyau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158736}
Update V8 to version 11.6.177.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/114cd478..e42fcf13
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I03ac8657c7e5de3cb088666beb9809c80c4c4d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619150
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158735}
[UPMLocalPwd] Show password migration warning after TTF
The CL triggers the password migration warning after the password
filling in the TouchToFillControllerAutofillDelegate.
The autosubmission is disabled if the warning is displayed, because it
interrupts the normal workflow.
Bug: 1439761
Change-Id: I0d5a6a747a005f62946c151dbb5edbca5dfe12a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594562
Reviewed-by: Ioana Pandele <[email protected]>
Commit-Queue: Anna Tsvirchkova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158734}
[ios] Disable testOmniboxLeadingImage for iPad simulator
Bug: 1455347
Change-Id: I166ef919cefbe0a680e772c88a781a4a81284db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614961
Commit-Queue: David Jean <[email protected]>
Owners-Override: Quentin Pubert <[email protected]>
Owners-Override: David Jean <[email protected]>
Reviewed-by: Quentin Pubert <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158733}
[ios] Use DIR_ASSETS instead of DIR_MODULE to load assets
The assets should be located using DIR_ASSETS which points to the
correct directory for assets. DIR_MODULE is incorrect in catalyst
environment (as the bundle has a different structure).
Bug: 1257402
Change-Id: I6069dc6ef930903e1c644b331e93dc8a780a089e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614470
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158732}
Cleanup: Remove unused SyncService dependency from Ash PeopleSection
This bubbles up through several layers, which all don't need the
SyncService anymore.
Fixed: 1274802
Change-Id: Ie7e6bb0c5012ebca8649f85e0e5ffc3adb85762f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614569
Auto-Submit: Marc Treib <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158731}
Revert "[PA] Add partition_alloc_optimized_debug to partition_alloc.gni."
This reverts commit 4ef79b5f8468216bf85da0588c78850bf8688fd8.
Reason for revert: Seems to have increased duration of browser tests by about 20%, see chromium:1455341
Original change's description:
> [PA] Add partition_alloc_optimized_debug to partition_alloc.gni.
>
> Add partition_alloc_optimized_debug to PartitionAlloc to enable
> PartitionAlloc-Everywhere on Linux debug build. This is the same way
> as v8 does, i.e. v8_optimized_debug.
>
> Bug: 1151236, 1449923, 1429450
>
> Change-Id: I6abfbdb3d0ef11104ec7ccf9edcaef4e21ddb1f4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599609
> Reviewed-by: Bartek Nowierski <[email protected]>
> Commit-Queue: Takashi Sakamoto <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158006}
Bug: 1151236, 1449923, 1429450, 1455341
Change-Id: Ida8e829f92f538412c3455a6cc4b6026d6360790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620228
Owners-Override: Antonio Sartori <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Antonio Sartori <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158730}
[DBSC] Session registration in BoundSessionCookieRefreshService
This CL adds a new RegisterNewBoundSession() method to
BoundSessionCookieRefreshService which allows registering a new bound
session after fininsing the explicit registration flow.
For now, BoundSessionCookieRefreshServiceImpl supports two modes:
1. Bound session state is tied to the Chrome sign-in state.
2. Bound session can be started explicitly and is independent from the
Chrome sign-in state.
Mode 2 is put behind a feature flag and should replace mode 1 once the
registration flow is implemented.
Session parameters are stored on disk to remember the bound session
state across browser restarts. The parameters are stored in .proto
format in profile prefs.
Proto format has the following advantages:
+ Supports structured and typed messages.
+ No need to write custom serialization code to store a message on disk.
+ New optional fields can be added without breaking backwards
compatibility.
Bug: b/286222327
Change-Id: I74140d9b650e5a0b3896256a9fbcb9af4b664a9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604501
Reviewed-by: Kristian Monsen <[email protected]>
Reviewed-by: Monica Basta <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158729}
Roll WebRTC from 0b86253c1511 to 45666d4b0124 (1 revision)
https://webrtc.googlesource.com/src.git/+log/0b86253c1511..45666d4b0124
2023-06-16 [email protected] Revert "[Stats] Remove enum-like structs in favor of strings."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ie5b2bea7c629692d72c942c26b23ce827db22e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619142
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158728}
ambient: Add startup time metrics for the managed screesaver
Started recording the amount of time it takes for the managed
screensaver to start.
Bug: b/278067527
Test: ash_unittests --gtest_filter=*Screensaver*
Change-Id: I7b2d0b0f6dfe047f185e2d7c80cfd456eef15517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615067
Reviewed-by: Eric Sum <[email protected]>
Reviewed-by: Maria Petrisor <[email protected]>
Commit-Queue: Antoni Dikov <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158727}
Stop highlighting the password form on TouchToFill.
Apparently that "feature" existed from day 1 but it's just a bug. The
form should not be in the preview state until it is filled.
Fixed: 1455084
Change-Id: I8067d865dc00a939858be981435f2c999469373b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618567
Code-Coverage: Findit <[email protected]>
Reviewed-by: Anna Tsvirchkova <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158726}
Roll ios_internal from 55863f051bc1 to 7d14012e57d6
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/55863f051bc1..7d14012e57d6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I575a9d4863228dda5e249753a59f0d216d28afd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620247
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158725}
[Frameworks roll] Roll to 540795552 piper revision
Change-Id: Ibbe0b3f96bd6af584ea037ebfd8d309efc33c9a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618334
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158724}
PreloadingDevTools: Disable prerendering for clients other than DevTools frontend
Prerendering introduced switching of FrameTreeNodes in the browser side
and frame targets in the CDP client side. If a CDP client unaware of
this logic and a prerendered page activated, it will cause unexpected
behaviors. For example, Puppeteer loses control. To mitigate this, this
CL disables prerendering if a target without tab target support is
attached. For more details, see [1].
[1] https://docs.google.com/document/d/12HVmFxYj5Jc-eJr5OmWsa2bqTJsbgGLKI6ZIyx0_wpA
Bug: 1440085
Change-Id: I80bf9234b60722112baf21c4fa2ee1f0d0cb3221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495911
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158723}
Preloading: Remove unnecessary `explicit` keywords
Remove unnecessary `explicit` keywords from constructors
that take multiple arguments.
Change-Id: I7c795ee826da017bd2195342c6c95c8f3c6dd08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617633
Auto-Submit: Takashi Toyoshima <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158722}
Revert "system-web-app: fix web app shortcut missing icons in sample SWA and tests"
This reverts commit dbe20fd9f3fe6a877807118471f2559f7199c5e6.
Reason for revert: Seems to have broken All/SettingsAppIntegrationTest.OmniboxNavigateToSettings/Regular_Crosapi on Linux Chromium OS ASan LSan Tests (1), see https://crbug.com/1455351
Original change's description:
> system-web-app: fix web app shortcut missing icons in sample SWA and tests
>
> Sample SWA and test SWA didn't provide web app shortcuts menu item
> icons.
>
> This CL fixes relevant code and adds icons to WebAppInstallInfo, updates
> SystemWebAppManagerInstallAllAppsBrowserTest.BasicConsistencyCheck to
> verify shortcut menu item icon is provided for each shortcut entry.
>
> Bug: 1427444,1417955
> Change-Id: Ib08880900ea0f23e238602756af263a3749f99f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613592
> Reviewed-by: Dibyajyoti Pal <[email protected]>
> Commit-Queue: Dibyajyoti Pal <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158130}
Bug: 1427444,1417955, 1455351
Change-Id: If1342e4565c0caf5c9a6ef944f3696422eacbad6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614520
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Antonio Sartori <[email protected]>
Owners-Override: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158721}
Roll devtools-internal from d9caa21acca2 to 262d7a9f5103 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/d9caa21acca2..262d7a9f5103
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/31b61655657cd499c74d6f099bb67c98cfb11cf4..738f63172f4e669e9d16a70edbdf5feb1b3c9e01
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: If687d580defc0ea6dd9465381e57c21d5b77e060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619141
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158720}
[dPWA] Update MS365 title bar experiment to ignore manifest colors
This CL updates the MS365 web app experiment to ignore the manifest
colors instead of supplanting them with specific colors based on the
page URL.
Bug: 1422071, b/287357327
Change-Id: I0a3d63438daa8568b3141dbc74b81ca4c0415933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614769
Auto-Submit: Alan Cutter <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Glen Robertson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158719}
ambient: Add engagement metrics for the managed screensaver
Started recording a simple engagement metric for the managed
screensaver.
Bug: b/278067412
Test: ash_unittest --gtest_filter=*Screensaver*
Change-Id: I50367f083c8e413cc638e23e4b683aeb50b48763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610752
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Reviewed-by: Eric Sum <[email protected]>
Commit-Queue: Fahad Mansoor <[email protected]>
Reviewed-by: Maria Petrisor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158718}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686895138-5b1e1b17d7afcab4594fc08f91fd13a83504d607.profdata to chrome-mac-arm-main-1686901619-f7dbd33d86d5f324306743fb3cc94e2f42245acd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I2b1d573d65d137c610c4621103a19a49a1f2a99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620289
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158717}
Various cleanups of screenshot remote command
These no-op cleanups should make the code a bit easier to read,
and make it easier to spot mistakes like a missing return statement.
Bug: b/283890347
Change-Id: I6abfe501f9c4aa109ba81aa2f209cd2445be6a4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604942
Commit-Queue: Jeroen Dhollander <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158716}
Roll Skia from 504a26e85fc6 to 9ab04a53b7be (2 revisions)
https://skia.googlesource.com/skia.git/+log/504a26e85fc6..9ab04a53b7be
2023-06-16 [email protected] Roll vulkan-deps from 6f8e5c2f4684 to 58c6e1ea988a (4 revisions)
2023-06-16 [email protected] Roll ANGLE from 5a5f21f4a2e2 to edf58105d695 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Ib727f007607e7c753b844c4ac27a7e33845493bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620071
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158715}
Support large size surrounding text in components/exo.
We hit an issue that large surrounding text size is truncated
because of wayland wire protocol field size.
This CL introduces a new API using memfd to pass the large data
so we should not hit the limit.
This is Ash side change.
BUG=1402906, 1451324
TEST=Ran manually, locally.
Change-Id: I562ceed44d20de3ca5fecb964a9549b272d4d59b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612829
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158714}
[Telemetry] Add Touchpad Event Implementation in crospai
This adds an implementation for detecting touchpad events using
Telemetry Extension on the crosapi side.
This is part of a bigger effort to add an event interface
to the Telemetry Extension. For more context visit
go/design-sketch-event-api.
Bug: b/279127802, b/268125453
Test: 1. unit_tests --gtest_filter="*Telemetry*Event*"
2. extensions_unittests --gtest_filter="*TelemetryExtension*"
3. browser_tests --gtest_filter="*TelemetryExtensionEventsApi*"
Change-Id: Ie5283418954b91a80beecbb72dfcadb4cf6f731d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4458351
Commit-Queue: Ethan Cheng <[email protected]>
Reviewed-by: Bastian Kersting <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158713}
[dpwa] Creates 2 new actions for migrating incognito mode P1 manual tests.
Bug: b/280606638
Change-Id: I55ad0cbb7ca192ee4ff7ebb66973c5c77d3265b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617273
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Clifford Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158712}
[Nigori] Rename Sharing-key related constructs with the prefix CrossUserSharing.
Follow up cls will perform the rename in the Proto fields.
Bug: 1445056
Change-Id: Ib9b61d66edb9db6a02e64ec7bd096c6d9dacc34a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614973
Commit-Queue: Elias Khsheibun <[email protected]>
Reviewed-by: Maksim Moskvitin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158711}
Revert "[wasm] Remove redundant call to {AbortCompilation}"
This reverts commit 97a8845cb194b50194b10fb3131fd056434fb285.
Reason for revert: https://crbug.com/1455264
Original change's description:
> [wasm] Remove redundant call to {AbortCompilation}
>
> Cancelling the `BytesConsumer` will trigger a state change, which will
> call `AbortCompilation`. Hence the second (explicit) `AbortCompilation`
> call can be skipped. It would return immediately anyway, because the
> `streaming_` field is reset at this point.
>
> [email protected]
>
> Bug: chromium:1448858, chromium:1449546
> Change-Id: I969b380615551017614110c81cb815e6793dfe68
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608054
> Reviewed-by: Andreas Haas <[email protected]>
> Commit-Queue: Clemens Backes <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158038}
Bug: chromium:1448858, chromium:1449546, chromium:1455264
Change-Id: I46a46b09337568474893cb28e8dbfec7e1282bb5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614552
Commit-Queue: Clemens Backes <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Andreas Haas <[email protected]>
Auto-Submit: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158710}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686884165-f915bdf471b4c08dffb094571f9c8dbfbcfd167e.profdata to chrome-win64-main-1686895138-39a675bf66a650699dfadbaf5c196e0db08825c0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8dfaa1c7d6721511cf918889abaadc1044170980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619750
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158709}
[WebUI] Enable trusted types CSP for ShimlessRMA
Bug: 1400799
Change-Id: I178251f2168a7d9aad1cbbb8df26c269f7ba7a8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604691
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158708}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686884165-c945ce575cd58732376d15a851f9806dac28b2cd.profdata to chrome-win32-main-1686895138-918a247a987b0cc310c232535178fd89bf08b29a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I551918c4f8629c9c45bc966d92b484826e513a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618685
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158707}
UMA: add metrics for vmm-swap
The ArcVm will add new UMA metrics at:
https://crrev.com/c/4600750
https://crrev.com/c/4617309
Bug: b/265386742
Test: compile succeeds
Change-Id: Ia42887078f934e4b83980ddbecc6089f9f9ff25b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619927
Commit-Queue: Shin Kawamura <[email protected]>
Reviewed-by: Weilun Shi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158706}
[CR2023] Fix LocationIconViewBrowserTest.InkDropMode
This test was crashing because LocationIconView is not in a views tree
and as a result does not have access to a Color Provider.
Bug: 1443572
Change-Id: If2782abd0455ae6730dc2e46c9c19140be080100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617848
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Auto-Submit: Keren Zhu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158705}
[odfs] add a metrics for get entry request
This request is sent from ODFS MetadataProvider.
Bug: b:280003103
Change-Id: If45824f0d9337a6521aa20c2fe573e245753eb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619950
Reviewed-by: Nigel Tao <[email protected]>
Commit-Queue: Alexander Bolodurin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158704}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686887847-40bca04050520a04989a89436ff5908f6f163c33.profdata to chrome-mac-arm-main-1686895138-5b1e1b17d7afcab4594fc08f91fd13a83504d607.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ia9fc872806fcdb70ea31e214eadd8d793721cf84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619975
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158703}
Update IOTask Progress with blocked files
Updated IOTask Progress upon completion to State::kError and set the PolicyError if there's any file blocked by DLP or Enterprise Connectors so that FileOperationHandler and file_manager::SystemNotificationManager can show the block panel item or the block desktop notification for both DLP & Enterprise Connectors.
Bug: b/279029167
Change-Id: Ia478dd146b865715e42a29fc75aced04c23cff14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615026
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158702}
[iOS] EnterprisePromptCoordinator dealloc checks stop was called
Bug: None
Change-Id: I1aed3f789939b0cb7cac77065c39b0a3f3ffa27e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608404
Reviewed-by: Arthur Milchior <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158701}
[Fontations-backend] Build rules for fontations backend in Chromium
Define a build flag for conditional compilation of the Fontations
SkTypeface backend in Chromium. When the flag is on, on Linux route all
web font creation through Fontations for testing.
Bug: 1446251
Change-Id: Ica4e2abdbe8b4a8f9a9c0fdbdbf1f1f8d1918bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608308
Reviewed-by: Ben Wagner <[email protected]>
Auto-Submit: Dominik Röttsches <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158700}
Move kSetClientEncryptionKeysJsApi feature flag to //components/trusted_vault
Bug: 1223853
Change-Id: I01a359eabf5786ffb2d1e216c1cb4607a3e94e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616397
Reviewed-by: Marc Treib <[email protected]>
Auto-Submit: Martin Kreichgauer <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158699}
[BestEffortServiceWorker] Dedupe main resource
This CL is a part of efforts that achieve the dedupe function to
BestEffortServiceWorker.
At a high-level, the dedupe is achieved by reusing the
RaceNetworkRequest response as a response of the corresponding request
in the fetch handler, and do not send a new fetch request.
We can split into some smaller steps to implement this.
1. Generates a token of RaceNetworkRequest, and pass it to the
blink side to make the corresponding request in the fetch handler
discoverable.
2. Adds a map of the token and URLLoaderFactory in
ServiceWorkerGlobalScope, and replaces the default URLLoader when the
fetch request is same as the one called in RaceNetworkRequest which is
outside of the fetch handler.
3. (This CL) Fuses two message pipes into one in a custom
URLLoaderClient so that we can reuse the RaceNetworkRequest result and
don't dispatch duplicated requests in the fetch handler.
This CL introduces one new class.
`ServiceWorkerForwardedRaceNetworkRequestURLLoaderFactory` is the
URLLoaderFactory that fuses the RaceNetworkRequest URLLoaderClient mojo
message pipe and the other URLLoaderClient pipe for the corresponding
fetch request in the ServiceWorker fetch handler in blink side. By
fusing them into one message pipe, the request in the fetch handler
never creates a new URLLoader and thus no duplicated request, and reuses
the response of RaceNetworkRequest.
`ServiceWorkerRaceNetworkRequestDataPipeManager` is the class managing
the dedicated data pipe and buffering data from RaceNetworkRequset. We
use this class to create new data pipes and pass the response of
original RaceNetworkRequset to the RaceNetworkRequest itself and the
fetch handler, respectively.
`ServiceWorkerRaceNetworkRequestURLLoaderClient` is changed to send the
response data to newly created two mojo data pipes, one is for the
RaceNetworkRequest itself, and the other one is for the fetch handler.
This CL adds the dedupe feature to the main resource only. For
subresoureces, we don't support it at least for now due to the
complexity of redirect case, but the ActiveEntry in net layer would
dedupe requests in most cases in reality.
Here is a design doc including diagram how mojo pipes work.
https://docs.google.com/document/d/1eotFetBW9RUE2sYjCnVl7P8rbvIsWBJcy3NOswC5kek/edit#bookmark=id.umdo7cpwavad
Change-Id: Ia524f69a81335528a66db5df2488a1f8190f2024
Bug: 1420517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4560732
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Shunya Shishido <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Tsuyoshi Horo <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158698}
Disable multipart-formdata.window.html on all platforms
The above mentioned test is marked as timing out on Linux and Mac11
platforms. However, the test also fails due to a "NotImplemented" being
hit in "WriteResourceRequestBody" and this failure occurs on all
platforms, not just Linux and Mac11. See:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fhtml%2Fsemantics%2Fforms%2Fform-submission-0%2Fmultipart-formdata.window.html
This CL expands the expectations entry for this test to all platforms
and also adds a failure expectation.
Please let me know if this additional failure type should have a
separate bug, instead of reusing crbug.com/626703. I don't have access
to crbug.com/626703, therefore I cannot see what all it covers.
Bug: 626703
Change-Id: I1c90b75c832ca061cc37ef813be1cd80b0638244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617579
Commit-Queue: Sanket Joshi <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158697}
Roll WebRTC from 816dc3b6081d to 0b86253c1511 (1 revision)
https://webrtc.googlesource.com/src.git/+log/816dc3b6081d..0b86253c1511
2023-06-16 [email protected] Update WebRTC code version (2023-06-16T04:04:20).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I0e5f8c45835f1866a113d970f50848f244590044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619340
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158696}
Web Apps: Remove redundant observe_media_requests PublisherHelper option
This parameter is always true in production and can be removed.
Bug: b/270212284
Change-Id: Id5a7f9985d695b4b6ba43de4c090a00f335beb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619947
Reviewed-by: Glen Robertson <[email protected]>
Commit-Queue: Glen Robertson <[email protected]>
Auto-Submit: Tim Sergeant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158695}
Add horizontal deletion metrics for site settings
This CL adds a horizontal metric to various browsing data deletion
surfaces on desktop:
- Site settings - clear all data
Histogram: "Privacy.ClearBrowsingData.Action"
Platform: Desktop
Bug: b/274063408
Change-Id: I41a2abc712b8a85bad1c1fc7b7b396e8654ad101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584558
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Mohamad Arab <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158694}
[Viz] Allow MultiplanarSI in RenderableGMBVideoFramePool beyond Mac
This CL removes the IS_MAC restriction from using MultiplanarSI in
RenderableGMBVideoFramePool, instead just using the guard of whether
MultiplanarSI is enabled. From discussion, there shouldn't be any
logic needed here for other platforms beyond that which was added to
get the flow working on Mac.
Bug: 1429004
Change-Id: I1159689f4b27ec43513dd93758f46bf1bd315847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607381
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Saifuddin Hitawala <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158693}
[iOS] Fix bubble frame LeadingDistance computation
This CL fixes the computation of the LeadingDistance() method.
In some cases `leadingDistance` could be a bit lower than 0.
Using round() instead of floor() returns 0 instead of -1.
Fixed: 1454071
Change-Id: I2e4e7b08e6994926cdcce416874f77a258d650e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618107
Commit-Queue: Ewann Pellé <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158692}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686851973-6e9f8a281a96374b2bdf985258af96ca60ab3947.profdata to chrome-linux-main-1686895138-563f8b073abc7300eb45545d285cd1b7b40e1e23.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I8a610c8989d9cc0626b4b103cb3527a3ec30ba26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618739
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158691}
Roll devtools-internal from 250b420bb8f5 to d9caa21acca2 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/250b420bb8f5..d9caa21acca2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I513eec36c83f4544b76d9b7c5f81800c6064bb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619971
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158690}
Roll ANGLE from 46ff02f8a2b1 to edf58105d695 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/46ff02f8a2b1..edf58105d695
2023-06-16 [email protected] Validate GL backend after dispatch table initialization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ie28c9bdcf2f99756cc4119596cdc22dff753e5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619707
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158689}
Revert "Reland "[PolicyLogs] Adding chrome://policy/logs on Desktop""
This reverts commit d650fb99b98799805b8011aea96a0aa2fc1b3cc4.
Reason for revert: Causes iphone and ipad devices failures.
Like https://luci-milo.appspot.com/ui/inv/task-chrome-swarming.appspot.com-62d99c2b8da1e511/test-results?sortby=&groupby=
Original change's description:
> Reland "[PolicyLogs] Adding chrome://policy/logs on Desktop"
>
> chrome://policy/logs is already available on Android and enabled by default. This CL brings chrome://policy/logs to desktop behind a feature flag that is enabled by default.
>
> The CL also adds a reference to the sequence that created the logger to always post `AddLog()` to it if a different sequence adds a log. Some code paths previously tried to add a log from a different sequence, causing the DCHECKs to fail. This solution fixes the issue.
>
> A POLICY_EXPORT is added for the LogHelper class to avoid dll linkage errors on Windows.
>
> The ASAN Crash that caused the revert in crrev.com/c/4559846
> was due to the last_dm_status_ being logged in "cloud_policy_client.cc" which has already been freed from the `NotifyClientError()` call.
>
> Bug: b/282733597
> Change-Id: Icb75e4cbb069eefea86958b65b3f957db295cdf3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567744
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Reviewed-by: Fabio Tirelo <[email protected]>
> Commit-Queue: Salma Elmahallawy <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158355}
Bug: b/282733597
Change-Id: I3e991148214869ad635455b4e3d7f6786252efb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616067
Commit-Queue: David Jean <[email protected]>
Reviewed-by: Quentin Pubert <[email protected]>
Reviewed-by: David Jean <[email protected]>
Owners-Override: David Jean <[email protected]>
Owners-Override: Quentin Pubert <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158688}
DestroyRegularProfileBeforeOTRs waits for profiles to be destroyed.
The test expects that the off-the-record profiles would be destroyed
immediately after calling `DestroyOriginalProfileWhenAppropriate` which
is wrong as the OTR profiles are sometimes given a bit of time to
close all their dependencies.
Bug: 1454090
Change-Id: Ia50c269fbec88cc08844f4cb290078961764ac05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614511
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Ramin Halavati <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158687}
[lacros skew tests] Refresh skew tests for M116 M116
This CL updates the ash version ['116.0.5835.0', '116.0.5830.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I889a2bd19a3c240bfa252fba961990b2fd5c4cc9
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618135
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158686}
Update V8 to version 11.6.176.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e7c25ca2..114cd478
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I9ee742f085d8df71435cbd089cc524e7dc98833c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620007
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158685}
Shorten the name of SharedDictionaryStorageIsolationKey
This CL just renames SharedDictionaryStorageIsolationKey to
SharedDictionaryIsolationKey.
Bug: 1413922
Change-Id: I94d6dc1718085a7d338217fc2039448a7641610b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619791
Commit-Queue: Tsuyoshi Horo <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158684}
Automated Commit: LKGM 15502.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778261585564755601
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: Ifc782f642c1f564ef44648c7e3ddef0c975e991c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616271
Commit-Queue: Andre Le <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158683}
[Office upload] Only show Connect To OneDrive dialog if ODFS not mounted
Only show Connect To OneDrive dialog if there is not already a ODFS
mounted. Previously this would be shown if the "Sign in" button
is clicked in the "You've been logged out" screen of an unauthenticated
ODFS mount. This is confusing as the user would expect to see the
authentication pop up instead.
Before:
- Dialog shown:
https://screencast.googleplex.com/cast/NDYyNTk4ODgxMDk2NDk5Mnw1NzE0Y2IyNi0zNQ
After:
- Authentication pop up shown:
https://screencast.googleplex.com/cast/NTU3NjMzODE3MDcwNzk2OHw0YTg3YzdkMy0xNA
Bug: b/287539168
Change-Id: Ie1607f9fcbc79403ca4e2936fc5a6ab02764663e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615471
Commit-Queue: Cassy Chun-Crogan <[email protected]>
Auto-Submit: Cassy Chun-Crogan <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158682}
ambient: Add enabled metric for managed screensaver
This CL adds a new class to record metrics related to the managed
screensaver feature. More metrics will be added to support trusted
testers.
Bug: b:278066909
Test: ./ash_unittests --gtest_filter=AmbientControllerForManaged*
Change-Id: I45d6497378f1852fe3176c4f4580d50728702891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597570
Reviewed-by: Igor Ruvinov <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Emmanuel Arias Soto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158681}
Roll Catapult from 10aab97228d8 to c8efd30d90fc (1 revision)
https://chromium.googlesource.com/catapult.git/+log/10aab97228d8..c8efd30d90fc
2023-06-16 [email protected] Initial code to generate skia perf links for bugs filed in chromeperf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: [email protected]
Change-Id: I54db28d7e2a53610d677e4d70e74e83d770fc6d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618704
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158680}
Add V8 GC finch experiments to field trial config
This CL enables features for code flushing and sechduling a single
memory reducer GC in field trial configs.
Bug: v8:13842
Change-Id: I92122b5ca2c026ca4c9bf76dd29a071642b44c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615072
Auto-Submit: Dominik Inführ <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Dominik Inführ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158679}
CSSStartingStyleRule inherits grouping rule
There is no conditionText, which means we can inherit directly from
CSSGroupingRule instead of CSSConditionRule.
Result of spec PR review:
https://github.com/w3c/csswg-drafts/pull/8876#discussion_r1207246849
Bug: 1412851
Change-Id: Idbd174813b8894154a283885c3cfbdb35c6c9fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571598
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158678}
arc: Allow vmm swap ghost window for PlayStore
Previously exclude PlayStore since ARC-on-demond use PlayStore as
the launch signal.
Now vmm manager already use PlayStore ready as one of the allow
condition, which means when IsArcVmAndSwappedOut is true, the
PlayStore app state must be "ready". It's fine for enable swap out
ghost window on PlayStore.
Bug: b:283356494
TEST=manually test
Change-Id: Id837e4ad063f61d56e252ff18acef5bdb51658c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615845
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Shengsong Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158677}
viz: merge render pass if rounded corners are contained by dest pass'
... rounded corners.
Do not create a render pass if rounded corners of pass
pass are within rounded corners of the dest pass.
Based on petermcneeley@'s draft patch - https://crrev.com/c/3987982
One of the issues that this CL fixes is creation of aggregated render
pass in Meet that results in LaCros compositing that pass.
Bug: 1382038
Change-Id: I2ddd78d0c43ad3b5054bcb0973c1722ac7c2f02f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4588849
Reviewed-by: Peter McNeeley <[email protected]>
Commit-Queue: Maksim Sisov <[email protected]>
Reviewed-by: Kyle Charbonneau <[email protected]>
Auto-Submit: Maksim Sisov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158676}
Migrate autosharder to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I61906baa08b220ebc0460686de149cadf6cc66ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617035
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158675}
[//viz] Get GL texture storage for format from ContextProvider
This CL eliminates direct usage of TextureStorageFormat(ResourceFormat),
replacing it with a wrapper function on ContextProvider that takes in
SharedImageFormat. A followup CL will change the utility function to
operate directly on SharedImageFormat and hide it so that it is not
directly used by clients.
Change-Id: I5e737c80244f119acbd41a4c3645a471d1a41851
Bug: 1378708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614964
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158674}
Speculative fix of flaky editing/selection/inactive-selection.html
The test sometimes finishes without printing neither PASS nor FAIL.
Probably we should make sure the test finishes after printing it.
This CL converts the test to a testharness async test.
Bug: 1455247
Change-Id: I477fd167ec8db7f0548bdb59a18274b3124f4b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617473
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158673}
Support large size surrounding text in Lacros.
We hit an issue that large surrounding text size is truncated
because of wayland wire protocol field size.
This CL introduces a new API using memfd to pass the large data
so we should not hit the limit.
This is lacros side change, which will be in effect once
ash side change is landed/deployed.
BUG=1402906, 1451324
TEST=Ran manually, locally.
Change-Id: Iae672d84603a1420f7493a678b1486c517c1ffda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612411
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158672}
Fix flaky editing\selection\4402375.html test
The above mentioned test is flaky on Mac platforms. The flakiness
occurs because sometimes the test window is inactive, leading to an
inactive selection color (gray) versus the expected active selection
color (blue). Since there is no deterministic way to set the window as
active from JS, the test is being fixed by setting the color and
background-color for active and inactive selection to be the same. This
will ensure that the selection colors will always align with the
baseline, regardless of whether the window is active or not.
Bug: 1425544
Change-Id: Ib99c7a52aaa42f2abfe060732c5a8afef99c9008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616620
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Sanket Joshi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158671}
Migrate flakiness-data-packager to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I938559f6132066f9f95a6f0a5e2e530d89d009a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617034
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158670}
mojo-js: Finish implementing the WebUIJsBridge generator
This CL finishes implementing the WebUIJsBridge generator. It's based
off a test implementation[1]
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4568468/8/content/browser/webui/test_web_ui_js_bridge_impl.h
Bug: 1407936
Change-Id: I879f0351a3834ebd6af7878416c90c74ac055ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568468
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158669}
[DevTools] Rebaseline and reenable test after https://crrev.com/c/4577779
Bug: chromium:1318590
Change-Id: I1031df28667d3cbcdb57e00ec8b8187bbbcd73be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615893
Commit-Queue: Benedikt Meurer <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Commit-Queue: Jaroslav Sevcik <[email protected]>
Quick-Run: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158668}
Choose to append .exe based on host_os not on the target.
When building on Linux for Windows, host tools will be built for linux
and thus will not have a .exe on the end.
[email protected]
Bug: 1271215
Change-Id: I508086ef681dfb0cf7fdf91250f134b9d4802052
Cq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-rel,android-rust-arm64-dbg,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-dbg,mac-rust-x64-dbg,win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615732
Commit-Queue: Adrian Taylor <[email protected]>
Auto-Submit: danakj <[email protected]>
Reviewed-by: Adrian Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158667}
Revert "DeskButton: Make button responsive to shelf overflow"
This reverts commit 9d5499f1cbca9a4adaee957ef2b83ff6b1eb82a2.
Reason for revert: The new test is flake in multiple bots:
https://ci.chromium.org/ui/test/chrome/ninja%3A%2F%2Fash%3Aash_unittests%2FScrollableShelfViewDeskButtonTest.ButtonRespondsToOverflowStateChange?q=V%3Atest_suite%3Dash_unittests+
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fash%3Aash_unittests%2FScrollableShelfViewDeskButtonTest.ButtonRespondsToOverflowStateChange?q=+V%3Atest_suite%3Dash_unittests+
Original change's description:
> DeskButton: Make button responsive to shelf overflow
>
> This CL makes the desk button responsive to shelf overflow. Previously,
> when the shelf was horizontal we would just force it to stay in expanded
> state no matter what. This CL changes this behavior by adding a
> condition where if the shelf will overflow in horizontal alignment with
> the button in the expanded state, then we shrink the button, and vice
> versa. It also adds and updates some tests to account for the changes.
>
> Bug: b/272383056
> Change-Id: I4ef107aa5b702a542ae7ec7818e945f568c8b92d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606119
> Reviewed-by: Yongshun Liu <[email protected]>
> Reviewed-by: Daniel Andersson <[email protected]>
> Commit-Queue: Ben Becker <[email protected]>
> Reviewed-by: Toni Barzic <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158439}
Bug: b/272383056
Change-Id: Id6398589a222ae327659e35e1724fb0813c60eb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619948
Commit-Queue: Luciano Pacheco <[email protected]>
Owners-Override: Luciano Pacheco <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158666}
media/V4l2VideoDecoder: add V4L2 UMA for V4l2VideoDecoder
This CL adds "Media.V4l2VideoDecoder.Error" UMA. It records which
one of the following V4l2VideoDecoder class member function failed.
Note that these functions are shared between v4l2 stateless/stateful
apis.
- InitializeBackend()
- SetupInputFormat()
- SetupOutputFormat()
- StartStreamV4L2Queue()
- StopStreamV4L2Queue()
A new V4l2VideoDecoderFunctions enumeration (with a matching UMA enum)
is added to v4l2_video_decoder.cc to identify which V4l2VideoDecoder
class member function failed, and is logged to UMA.
Bug: b:273973858
Change-Id: I732ac8d2aba21448ec91f7b328958ec48219df93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4553205
Auto-Submit: Steve Cho <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Miguel Casas-Sanchez <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158665}
Fix dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
The above mentioned test is flaky on Mac platforms. The flakiness
occurs because sometimes the test window is inactive, leading to an
inactive selection color (gray) versus the expected active selection
color (blue). Since there is no deterministic way to set the window as
active from JS, the test is being fixed by setting the color and
background-color for active and inactive selection to be the same. This
will ensure that the selection colors will always align with the
baseline, regardless of whether the window is active or not.
There are few other similar tests that may encounter the same issue.
Those are also being updated herewith.
Bug: 1421120
Change-Id: I226e4d479eb38f29bb32ee07c77ea0831174da1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619310
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Sanket Joshi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158664}
Migrate Linux Builder reclient test untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia6602941faba684d6514ee2e9457aa8121121328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620027
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158663}
Shared Storage: Update tests to support settings v4 & attestation
We update the chrome/ layer browser tests for shared storage to
support `privacy_sandbox::kPrivacySandboxSettings4` and
`privacy_sandbox::kEnforcePrivacySandboxAttestations`.
Bug: 1455135,1218540,1396748,1378703
Change-Id: I7de8a430412eaefc42258bddac06cf507462d1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616965
Reviewed-by: Yao Xiao <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Shivani Sharma <[email protected]>
Commit-Queue: Cammie Smith Barnes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158662}
Migrate Linux Builder reclient test to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I7dde8f850abb816334f51d44bb494f8cbf1c83cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616421
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158661}
Migrate Linux Builder reclient staging untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Iaf2df39dc6fe89dd66f15e35009ab11810b79ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619529
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158660}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686862750-64c913bb16dbf84d78f82669bcff96f2ae29c7f7.profdata to chrome-win32-main-1686884165-c945ce575cd58732376d15a851f9806dac28b2cd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I78f24b1125a16c44501e7bee780d415209b47d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619208
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158659}
Revert "welcome tour: Disable welcome tour during tablet mode"
This reverts commit 883bbae2322f4e6e607debfa3798389787d472f7.
Reason for revert: The new tests are failing on chromium/ci/Linux Chromium OS ASan LSan
Original change's description:
> welcome tour: Disable welcome tour during tablet mode
>
> Welcome Tour will not be supported in tablet mode. This CL makes it not
> start if in tablet mode, and abort if tablet mode is entered while it is
> in progress.
>
> Bug: b:285628471
> Change-Id: Ic596a57ca79c541511435cd681e3d1c5f4cc13db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608634
> Commit-Queue: Angus McLean <[email protected]>
> Reviewed-by: David Black <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158517}
Bug: b:285628471, chromium:1455300
Change-Id: I427271b94354134899462fe9699781a1ff711018
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614695
Commit-Queue: Antonio Sartori <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158658}
[text-wrap-pretty] Fix incorrect rounding in `NGLineWidths`
This patch fixes `NGLineWidths` to `ceil` more accurately by
using the float division than `LayoutUnit::operator/`. For
example, "Ceil(46.25 / 23)" should be 3 but `LayoutUnit`
computes it to 2 due to its 1/64 precision.
This patch has no behavior changes because changes are under
a runtime flag.
Bug: 1432798, 1451205
Change-Id: I6f135d7caa074e76b3ab049e5256d763f23f7c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615145
Commit-Queue: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158657}
Migrate Comparison Linux (reclient vs reclient remote links) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie51fa44800c64981b7fd49bb6679c2a693916428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616419
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158656}
Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision)
https://skia.googlesource.com/skia.git/+log/f0410a265d2b..504a26e85fc6
2023-06-16 [email protected] Roll Skia Infra from 894306cf4c91 to d044984a01de (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Ibb4d93752dcfb565f1f819ef2acdb9c01d25c490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619232
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158655}
Migrate Linux Builder reclient test (unified uploads) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Id3e0c690448b219213fad328d103ff6ea9dd7f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617032
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158654}
Migrate chromeos-amd64-generic-rel-goma-rbe-canary to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Idb17220f74d31447872501acd9f80cca2bc4d14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616418
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158653}
Reduce memory consumption caused by kSpeculativeServiceWorkerWarmUp
kSpeculativeServiceWorkerWarmUp caused a high memory consumption
problem. This CL tries to reduce memory usage.
- Browser process side
Before this CL, AnchorElementObserverForServiceWorker sends all URL
candidates at once from renderer to browser. This means all URLs are
copied into the browser process. Most URLs will be quickly filtered out
because service worker controlled pages are rare. But copying many URLs
will affect memory consumption. This CL introduces
kSpeculativeServiceWorkerWarmUpBatchSize feature param to restrict URL
count when renderer sends URLs to browser.
For example (If kSpeculativeServiceWorkerWarmUpBatchSize == 10):
1. Navigation starts.
2. Accumulate 25 URL candidates before onload.
3. onload event is triggered.
4. Send the first 10 URL candidates from renderer to browser.
5. Wait for 300ms.
6. Send the next 10 URL candidates from renderer to browser.
7. Wait for 300ms.
8. Send the next 5 URL candidates from renderer to browser.
The duration between each batch can be configurable with
kSpeculativeServiceWorkerWarmUpBatchTimer.
The reason why AnchorElementObserverForServiceWorker doesn't filter URLs
in the renderer side is security and privacy reasons. We shouldn't send
service worker registered origins to renderer process because service
worker registered origins might be a sensitive information (similar to
the bookmark).
- Renderer process side
Before this CL, `warm_up_request_cache_` and `pending_warm_up_requests_`
stored copies of URLs. Creating copies is not good for memory
consumption. This CL stores HTMLAnchorElement pointers instead because
pointers are much smaller than copied URLs.
- Other updates
This CL also adds the following feature params for configurability.
- kSpeculativeServiceWorkerWarmUpWaitForLoad
- kSpeculativeServiceWorkerWarmUpFirstBatchTimer
Bug: 1431792
Bug: 1454685
Change-Id: I9f14aa64347c599947db3bf3911d388512840cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614764
Commit-Queue: Minoru Chikamune <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158652}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686862750-d3a3f859e747dd876f5a30b396461bc9e1c5c6a4.profdata to chrome-win64-main-1686884165-f915bdf471b4c08dffb094571f9c8dbfbcfd167e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Id150c1754f063986747d9e3c73aa57ce395b1967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619140
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158651}
Migrate linux-archive-rel-goma-rbe-canary to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I8a89a6ba9cf9701d4ae00569025337bee7c1cc9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617031
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158650}
[text-wrap-pretty] Support simple floats
This patch supports "simple" floats for `text-wrap: pretty`,
and for `text-wrap: balance` when `NGScoreLineBreaker` is
enabled.
The "simple" is when all following conditions are met:
* It has only one floating object, or multiple floating
objects that create a rectangular exclusion.
* All floating objects must be at the beginning of the block.
* All lines must be known to have the same line height without
being laid out.
The expectation for the test for `text-wrap: balance` is still
disabled because `NGScoreLineBreaker` is not enabled. The plan
is to enable it after the branch so that web_tests can catch
regressions to the shipping version of `text-wrap: balance`.
Bug: 1432798, 1451205
Change-Id: Ic884d099f48469d5d7f08b268c29c7198c462cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604260
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158649}
Migrate android-coverage-launcher to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I1b54ab296a048d7bbc036557cbce2568ef3c41eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619041
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158648}
[odfs] add more metric variants
Bug: b:280003103
Change-Id: I4c544bd07fb9001912e029f3fb22466f82ee023c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612606
Reviewed-by: Nigel Tao <[email protected]>
Commit-Queue: Alexander Bolodurin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158647}
autocorrect: expose ReplaceSurroundingText in input_method_host.mojom
We want to use the new API called "ReplaceSurroundingText" in our chromeos input shared library so this CL adds this API to the mojom call.
Change-Id: Ib040bfa4ee02d12448e49b719356c82b187ac35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614628
Reviewed-by: Curtis McMullan <[email protected]>
Commit-Queue: Chuong Ho <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158646}
Migrate runner to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: If1103972de91d3be7a0b9500ad1cc5d98022126d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617030
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158645}
Migrate android-x64-launcher to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Idb2e107a80953895b19d79f45e41a7b0a270e241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619355
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158644}
Migrate linux-launcher to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie157a915cd1152c6d1469a101634fcba9b03956d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616417
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158643}
Revise OWNERS of chrome/browser/ash/input_method/ui.
- Remove folks who no longer actively work on it.
- Drop "primary - secondary" concept.
- drive-by: Alpha-sort the list.
Bug: None
Change-Id: I249a2d89fa07d7558e25371b9a5466f814c4cb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616167
Reviewed-by: Yuichiro Hanada <[email protected]>
Reviewed-by: Shu Chen <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Commit-Queue: Bao-Duy Tran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158642}
Revise OWNERS of CrOS IME Service Container.
- Remove folks who no longer work on CrOS.
- Add dvallet (TLM) and curtismcmullan (TL).
Bug: None
Change-Id: Iaa4c60ca5f5c9011ec603709c4b58d41870d582e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612725
Reviewed-by: Shu Chen <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Reviewed-by: David Vallet <[email protected]>
Commit-Queue: Bao-Duy Tran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158641}
Make ::backdrop stay in top layer while animating out
This patch adds a new internal pseudo class which matches popovers while
they are still in the top layer after they have been closed in order to
also make the corresponding ::backdrop stay in the top layer.
This is based on futhark's patch:
https://chromium-review.googlesource.com/c/chromium/src/+/4554016
HTML spec PR: https://github.com/whatwg/html/pull/9387
Fixed: 1449145
Change-Id: I8e4831e960c5d18fb077f023c119fd0e678541df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585724
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158640}
[FilesBulkPinning] Extract Speedometer to common place
The Speedometer is currently being used by the IOTask framework to work
out remaining time for a file transfer. For bulk pinning this
calculation should be reused to identify total time to pin all the
files, however, chromeos/components can't depend on chrome/* so move the
speedometer files to a location that can be used.
Bug: b:279847004
Test: chromeos_unittests --gtest_filter=*Speedometer*
Change-Id: I4303b8d65c1ca6fa477530125c789919f2c80f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617787
Reviewed-by: Ryo Hashimoto <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158639}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686880769-0776d9b12adef404b3332810a0ae660ea9ba6d89.profdata to chrome-mac-arm-main-1686887847-40bca04050520a04989a89436ff5908f6f163c33.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I3e63eb80ce11bd7784571c6b2242231db5aee9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618701
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158638}
Jellify AMAC-e Confirmation Dialog
This CL updates the AMAC-e Confirmation Dialog according to the updated
spec.
Bug: b:284239147
Test: flag off - https://screenshot.googleplex.com/BXvRYQkyaVoRq4X
Test: flag on - https://screenshot.googleplex.com/3po4exFhdFPiU4g
Change-Id: I843b1a0516c0bb2b518d5def933dc785509be8e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614905
Reviewed-by: Toshiki Kikuchi <[email protected]>
Commit-Queue: Qijing Yao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158637}
Fix slider color mapping
See spec: https://www.figma.com/proto/1XsFoZH868xLcLPfPZRxLh/branch/cnzaI8CuH6ojEJ4HpwdSRW/CrOS-Next---Component-Library-%26-Spec?type=design&page-id=2807%3A24237&node-id=2978-19626&viewport=-361%2C151%2C0.5&scaling=scale-down-width&starting-point-node-id=2978%3A19626
Bug: 285234067
Change-Id: Icd08c9c0b4fb13c7e244ca8c1ce667a4ebb1f306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614768
Reviewed-by: Zain Afzal <[email protected]>
Commit-Queue: Heidi Chan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158636}
Migrate Libfuzzer Upload Chrome OS ASan to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ica43d4a77f0dc008cbdfd535ccf9cad44830e7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616416
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158635}
Migrate Libfuzzer Upload Linux V8-ARM64 ASan Debug to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ifddbb350c54629e71df57cf513b5eea6fc50fd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619076
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158634}
Migrate android-cronet-asan-arm-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I886aaaa700b0dedfcb1fd8176a5fa3226f45939c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619075
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158633}
[Fixit] Fix flaky JavascriptAppModalDialogTest
Wait for view in testBeforeUnloadDialog.
Bug: 1295498
Change-Id: Ifc42af20639b9e5cafe13ed40e0947f15ca09205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619090
Commit-Queue: Hailey Wang <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158632}
Migrate android-cronet-arm64-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I4619de2074aac6d4c7da42e363a666085173aa48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619176
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158631}
[Fixit] Re-enable passing test in SearchActivityTest
Test is no longuer broken according to reviver
Bug: 1371234
Change-Id: I2d32e148fb7215cd7185dd1536404f967795a25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619092
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Hailey Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158630}
CCA: Only stop capture stream for multi-stream in Video.clear()
After crrev/c/4573176, we stop the capture stream in Video.clear().
As a result, we don't need to stop in Reconfigurer.stopStreams().
Bug: b:287377831
Test: tast run {DUT} camera.CCAUIRecordVideoPerf.real
Change-Id: Ieeba32abca4c3ab251e714615fa4b8b8884e39de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617660
Reviewed-by: Pi-Hsun Shih <[email protected]>
Auto-Submit: Wei Lee <[email protected]>
Commit-Queue: Pi-Hsun Shih <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158629}
Migrate mac10.13-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ida634b21e27d06075c861283ad6957eb070243b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618078
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158628}
Files Office: Add UMA for duration of opening on Cloud Provider
Bug: b:264309906
Change-Id: I9502325b97b5092b08286d16dc5ee6383b64b42a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610266
Commit-Queue: Luciano Pacheco <[email protected]>
Reviewed-by: Nigel Tao <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: Alexander Bolodurin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158627}
Migrate android-webview-12-x64-dbg-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I77519784f2c9bcfdf5c4193c094ce5ccd9a2ce7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618076
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158626}
Migrate mac11-x64-updater-tester-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia6657aa91927d50f7f47b72bea4fe9000277331f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619002
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158625}
Reland [omnibox] Split WebUI impl out from OmniboxPopupViewViews
This CL relands the refactoring code changes while addressing the
test failures that caused this revert:
[Revert "[omnibox] Split WebUI implementation out from OmniboxPopupViewViews" (4618013) · Gerrit Code Review](https://crrev.com/c/4618013)
Bug: 1445142
Change-Id: I86f37190d8c8a14e3cf683f18884debff09468c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619093
Reviewed-by: Moe Ahmadi <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158624}
Migrate android-13-x64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I5dd4d0910ca5c9aa8b43c282aace030f3f2bc885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619001
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158623}
storage: add backticks to file_system_url.h comments
BUG=None
TEST=None
Change-Id: Ibd8ba912aebddea964f301cc0b539e78016920f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618228
Commit-Queue: Nigel Tao <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158622}
Migrate ASAN Debug to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ifffe17289d3a3ee74f05590ec669f216e823f646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619710
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158621}
Migrate Mac13 Tests (dbg) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I7f88aaf7e1747b9ecbf65cfbd60b661d399c06c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618075
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158620}
Fix resolving a string variable in groovy
Bug: 1455261
Change-Id: Ifa23231366410e09a5b583ee7e6ec0a75101cada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619174
Auto-Submit: Basia Zimirska <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158619}
[WinCameraZeroCopy] Manage the lifetime of IMFBuffer
This CL is a follow-up patch of CL:4323337. It aims to manage the
lifetime of IMFBuffer.
1) Extend CapturedExternalVideoBuffer to hold a ComPtr<IMFBuffer>.
2) Change VideoCaptureBufferPool::ReserveIdForExternalBuffer to take
in a CapturedExternalVideoBuffer instead of just a
GpuMemoryBufferHandle (the external buffer also contains the GMB handle
inside it).
3) Add a Windows-only
VideoCaptureBufferTracker::SetIMFBuffer(ComPtr<IMFBuffer>) method
that's called by ReserveIdForExternalBuffer when calling
SetHeldByProducer(true) i.e. when creating a new tracker or reusing an
existing tracker. The implementation in the Windows
GpuMemoryBufferTracker will just store the ComPtr as a field - this
ensures the IMFBuffer cannot be recycled by MediaFoundation.
4) Override OnHeldByConsumersChanged() in the Windows
GpuMemoryBufferTracker so that it drops the ComPtr<IMFBuffer> when held
by consumers becomes false - that way the IMFBuffer is free to be
recycled by MediaFoundation.
5) CL keeps storing member variables `GpuMemoryBufferHandle` for
GpuMemoryBufferTracker(win) since GpuMemoryBufferTrackerMac must need
store member variable `handle.io_surface`, so the common
interface(CreateTracker) needs to pass gmb handle and keep storing
variable.
Bug: 1120900
Change-Id: Icf809978786b3d3c5b18ca9fd1adb0a161d561f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571114
Commit-Queue: Shuhai Peng <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158618}
Update V8 to version 11.6.175.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d201463e..e7c25ca2
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I80746411d9066e00d1e8ecf97e16b631b3cbfd87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616816
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158617}
Migrate mac10.14-updater-tester-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3aa72c983d726bc34a54b68318ae6ceaa94d9000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618074
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158616}
BulkPinning: Add histograms for pinned files
BUG=b:285434629
Change-Id: I51f4eaa74764c1cf82dca357f0a6508d9e5911a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612810
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Nigel Tao <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158615}
[display lock] Use Oilpan-aware collections for pointers to Oilpan objects.
Technically, this could be safe as long as nothing triggers garbage
collection. However, something as innocuous as allocating a new oject in
the Oilpan heap can trigger collection, so it is more robust to use the
Oilpan-aware container types.
Bug: 1454949
Change-Id: I9373764d300883b4babcd97d43392c77f1e1a8bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617004
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158614}
Roll vulkan-deps from 91926f6dfb63 to 58c6e1ea988a (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/91926f6dfb63..58c6e1ea988a
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b4f352e54f..d33bea5847
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/88d70047fb..bcfb502054
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2c83dd6cb2..17edcc1455
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5cde5d21a3..4d4fc0e5a2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I2c6f6f6bfbf796ebb144a00d8671a9cb7e287250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617686
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158613}
Roll Skia from abfa3505db23 to f0410a265d2b (1 revision)
https://skia.googlesource.com/skia.git/+log/abfa3505db23..f0410a265d2b
2023-06-16 [email protected] Roll SK Tool from 894306cf4c91 to d044984a01de
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I300120c1e1e1a4f24271c5fb3d94612b66cb4622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618423
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158612}
Migrate android-10-arm64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I53847dda4d6c2f337ddddc81623d34fed9f76151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619138
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158611}
autocorrect: expose the value of AutocorrectUseReplaceSurroundingText flag to IME service
This CL makes the AutocorrectUseReplaceSurroundingText flag visible to the IME service.
Bug: b/287425426
Change-Id: I82766c8cd2c2982fa1e0984d772df91796963239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617690
Commit-Queue: Chuong Ho <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158610}
Migrate Libfuzzer Upload Linux32 ASan to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I9a2947cf02b16338b6faf43eb162fed232d45929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619175
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158609}
Make static router rules visible in chrome://serviceworker-internals.
To allow web developers to confirm the current ServiceWorker static
routing rules, this CL allows it visible in
chrome://serviceworker-internals with JSON format.
Bug: 1371756
Change-Id: I85e94d950bb26295e7fe61f833c604e78d2577f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618049
Reviewed-by: Shunya Shishido <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158608}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686866392-8024717ffe8ae9d18bf77dc3dea43e7c8cdd32fd.profdata to chrome-mac-arm-main-1686880769-0776d9b12adef404b3332810a0ae660ea9ba6d89.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie63d9bc84b7822cc6a0f51e0638a5c189672deaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619681
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158607}
Disable a flaky test case in ScrollBehaviorBrowserTest.
Bug: 1451608
Change-Id: Iebac251655c4625dd29a6684b7a511cbe9126493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617392
Auto-Submit: Steve Kobes <[email protected]>
Commit-Queue: Robert Flack <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158606}
print-management: add handler skeleton
- Add skeleton page handler to print management.
- Add BUILD.gn to compile backend library.
Bug: b:283119650
Test: Compiles and deployed to DUT without error.
Change-Id: I5f6d71e290d3c10d75e4ebb53749d9bff7091d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607552
Reviewed-by: Gavin Williams <[email protected]>
Auto-Submit: Ashley Prasad <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158605}
about_ui: rename "name" to "host"
Make sure the definition matches the prototype in the header
and the caller and other standard WebUI usage.
Bug: b/284974354
Change-Id: Iab82f9abe8214af608a32881896a54f098572482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619647
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Auto-Submit: Mike Frysinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158604}
Migrate android-webview-10-x86-rel-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Id8b35c55779e1abc06bdf775b27d5fba38b4f912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616621
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158603}
Migrate Nougat Phone Tester to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ifd714b4d4b110d36658f80a21c4a9eaad6c20c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619528
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158602}
Updating trunk VERSION from 5835.0 to 5836.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I7745b2955640247c3c63715690e8e1acb6a08201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615198
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158601}
Migrate ASan Debug (32-bit x86 with V8-ARM) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3b78f44f3cb0ddf29da81979cadef704be42ac67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619351
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158600}
Reland "drm: Only use modifiers that support Vulkan import"
Currently when Vulkan is enabled, we do not take into account whether
a particular DRM format modifier is supported for Vulkan import via
vkCreateImage. Thus, we can allocate a presentation buffer with a
modifier that then cannot be imported into Vulkan, and later we fail
display composition. For example, the Intel Vulkan drivers do not
support import of Gen 12 CCS buffers, and Chrome crashes on startup
if we enable Vulkan on a sufficiently modern Intel GPU.
This CL fixes the issue by querying for supported modifiers when
populating the available modifiers list and only returning those that
can be imported.
This is a reland of 1c1f725a with a fix for the LSan compilation
issue.
Change-Id: I03137781dd72eb52cf50dd8b3ebf4dd3e5b8f413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618710
Commit-Queue: Brian Ho <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Michael Spang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158599}
swap: Remove D-bus client
Swap utils in debugd is retired and migrated to swap_management. The
corresponding D-bus client should be removed as well.
BUG=b:218519699
TEST=Build for betty VM
Change-Id: I5a6585b623da313b4ebf1632e5819d04dab45521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617211
Auto-Submit: Chun-Tse Shao <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Commit-Queue: Ryo Hashimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158598}
Migrate android-cronet-arm64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I50cff3d2c8a3bc1f29cdfc03e0c8c7452d87ce9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618698
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158597}
Migrate fuchsia-fyi-x64-dbg-persistent-emulator to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I61147a842b3c7e7a92e2ec6c422b39cc973b6c15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618697
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158596}
Migrate android-arm64-proguard-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Idcd15a5da37367d85de3a024c28e7417ce1bea29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619350
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158595}
Make crosapi web app browser tests use LacrosOnly
This is in preparation for removing the kWebAppsCrosapi flag as well as
for removing the LacrosSideBySide and LacrosPrimary modes.
Since ChromeOS in LacrosOnly mode does not open an Ash browser window
but tests still rely on browser(), make tests create an Ash browser
window. This is meant to be a temporary workaround.
It turns out that a few tests that were running with kWebAppsCrosapi
are actually failing with LacrosOnly enabled for deeper reasons. These
tests are being disabled in this CL and bugs were filed to kick off
further investigation.
Bug: chromium:1440448, chromium:1450158
Bug: b:287165243, b:287166490, b:287165206
Bug: b:287166176, b:287166775, b:287167145
Change-Id: Ie113994a1dd8cf93921740c4f9dc8ba3b5ffd551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592930
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Maggie Cai <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158594}
display: Do not mark external displays as being able to auto-rotate
This was causing external displays while in tablet mode to be unable to
change orientation in settings. When the external display's orientation
was changed in settings, it instead changed the orientation of the
internal display.
Fixed: b/245054455
Change-Id: I4e2d53253273338475278372a0ed47e30a5489e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590215
Commit-Queue: David Padlipsky <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158593}
Add CrOS system log collection methods for input devices
Collect DeviceDataManager state to ui_device_data_manager and
ui_device_data_manager_device_counts.
All instantiated ozone event converters are logged to
ozone_evdev_input_event_converters.
Bug: b:265986652
Test: events_unittests, unit_tests, on-device Primus, reven/QEMU
Test: Enabled #enable-touchscreen-calibration, changed touch calibration on external screen
Low-Coverage-Reason: b/284500917: no unit test framework for wayland_input_controller.cc
Low-Coverage-Reason: haptics_tracking_test_input_controller.cc is test-only
Low-Coverage-Reason: b/265986652: limited unit tests on display mapping until full logging is implemented
Cq-Include-Trybots: luci.chromium.try:lacros-arm-generic-rel,lacros-arm64-generic-rel,linux-lacros-asan-lsan-rel,linux-lacros-dbg,linux-lacros-rel;luci.chrome.try:chromeos-reven-chrome
Change-Id: Ie3c6b499b3ecffb39a05adbc6c3bac854ef3ef28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428836
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Kenneth Albanowski <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158592}
float: Clamshell multitask menu only activatable if parent was active
This prevents users from losing focus from accidental hovers, but also
keeps tab traversal if the parent was active before. The menu still
shows on hover for inactive windows, but does not take activation.
The feedback from users was that unintentional activation of the
window was highly disruptive. This change means the bubble may be
occluded in some cases, but works well for side by side snap for
example.
Test: manual
Bug: b/283281637
Change-Id: Ic110d6361e359f20e8133211fd8f0dff08596748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611730
Reviewed-by: Sophie Wen <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158591}
Migrate android-12l-x64-fyi-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I8dd4766e78dfc043915e186eba475e1e6852f441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619173
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158590}
[Android] Deflake FullscreenManagerTest#test...WhenInputIsFocused
Lets TabStateBrowserControlsVisibilityDelegate obtain the focus node
editability not from SelectionPopupController but directly from
|ImeEventObserver#onNodeAttributeUpdated| to avoid a race condition.
Bug: 698413, 1331539
Change-Id: I92f308192ee6861115e1fadf0171e0d0a8068726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615401
Code-Coverage: Findit <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158589}
Extension review panel tracks the width of extension cards grid
This CL fixes the width of the extensions review panel such that it automatically tracks the width of the item cards grid. The review panel container is now the first child of the item cards grid and occupies the entire first row of the grid.
Bug: 1432194
Change-Id: I0a165226b778965e4d8ae8d67fcbbfc4d6984c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4534201
Commit-Queue: Zack Han <[email protected]>
Reviewed-by: Zack Han <[email protected]>
Reviewed-by: Kelvin Jiang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158588}
borealis: Band-aid fix for steam client identification
The steam client started putting STEAM_GAME cardinals in its window
properties, which tricked sommelier.
We "fix" this by hard-coding the particular game ID as the client
itself.
Bug: b:287506770
Change-Id: I96946e767e3784d2412c11a4c601068d03eed27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619587
Commit-Queue: Nic Hollingum <[email protected]>
Commit-Queue: Chloe Pelling <[email protected]>
Auto-Submit: Nic Hollingum <[email protected]>
Reviewed-by: Chloe Pelling <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158587}
cros_healthd: Trigger DLC installation as soon as OOBE
Install the required DLC for cros_healthd by ASAO pattern.
Bug=b:270003192
Tes=CQ
TEST=autoninja -C out/Default chrome
Change-Id: Ife344fa9ab08cefd0c8d003b25ee3bf0d0f5d60e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4541046
Reviewed-by: Osama Fathy <[email protected]>
Reviewed-by: Chung-sheng Wu <[email protected]>
Commit-Queue: Byron Lee <[email protected]>
Auto-Submit: Byron Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158586}
Migrate mac11-x64-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I450e240870b85b3431bf3bc10a6761a9bfe22845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619294
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158585}
Create //chrome/android/modules/readaloud in preparation for isolated split
The external library interfaces (in o.c.c.m.readaloud.external) will eventually be needed inside the split only.
Bug: b/287128327
Change-Id: I845604824d9e2e74e793508fbee2714069add062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611985
Commit-Queue: Ian Wells <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158584}
Migrate android-12-x64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I6e82c99f40d2b3e4f1116ed93577af72616a2208
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619137
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158583}
[Multipaste Growth] Record the nested menu source when expanding
This CL records the menu show source when the clipboard history
nested menu shows.
Bug: b/267694408
Change-Id: I1c9535226265c4c71b77ed1cb001624ed0dadb58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4561627
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Colin Kincaid <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158582}
Migrate fuchsia-arm64-cast-receiver-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: If948fb886ba01377167ff5cf9abfec0c5b5e5b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619349
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158581}
Make Demo Mode WebUIConfig inherit from ChromeOSWebUIConfig
DemoModeAppUntrustedUIConfig already pretty much follows the
CreateWebUIControllerFunc pattern, by using a component_path_producer
lambda to provide the component path at controller creation time.
This CL just replaces the component_path_producer with a
CreateWebUIControllerFunc, utilizing one of the constructor definitions
in ChromeOsWebUIConfig that we're now inheriting from.
This is in preparation for more behavior that needs to be added in the CreateWebUIControllerFunc, namely passing in a //chrome/browser delegate.
Bug: b/286881001
Test: browsertests; manually verify demo mode app still autolaunches in
demo mode
Change-Id: I815832abc145b3055eb339b57d5e709b1e67e067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611725
Commit-Queue: Jackson Tadie <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158580}
language_packs: Add metric to record calls to UpdatePacksForOobe
In this change we add a histogram and we use it to record how many
times UpdatePacksForOobe is called as well as whether the input
locale is valid.
Bug: b:237351368
Change-Id: Ie2fac42684161ad941b06bb9045ad99597c5cc97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614625
Commit-Queue: Claudio M <[email protected]>
Reviewed-by: Juliet Lévesque <[email protected]>
Reviewed-by: Michael Cui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158579}
mojo-webui: Move WebUIManagedInterfaceBase to content/public
Move WebUIManagedInterfaceBase to content/public since it's needed in
//ash for FaceMLPageHandler.
Bug: 1407936
Change-Id: I8b067586d65e81c56a24568feabbea5985311e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592788
Commit-Queue: Giovanni Ortuno Urquidi <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158578}
Allow customizing the style and color of labels
This CL adds two new methods to option_button_base, allowing clients to
modify the style and color of the label.
Bug: b:284239147
Change-Id: I1b10a12183289525ffd5c326bdf9f6fb7189f0a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614904
Reviewed-by: Toshiki Kikuchi <[email protected]>
Commit-Queue: Qijing Yao <[email protected]>
Reviewed-by: Connie Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158577}
[Android] Use FeatureMap to generalize BaseFeatureList
Replace the code in BaseFeatureList with boilerplate BaseFeatureMap.
This reduces code duplication, add support for field trial parameters,
and in the future adds support for CachedFlag.
Bug: 1445758
Change-Id: I448a44c02b3b4643ca509e840bf14ecf20707060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599578
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158576}
Migrate android-cronet-x86-dbg-lollipop-tests to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ia876d52c7db2da97609a44c57aa4de1178aa7ad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619172
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158575}
about_ui: stop flattening about_os_credits.html stub
We don't need to flatten this, and the option is discouraged now,
so drop the attribute. This will allow us to use relative paths
to access resources like credits.css.
Bug: b/284974354
Change-Id: I2ed4588a745565b6a17ecb2b4597eeacd48fb6d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606194
Commit-Queue: Mike Frysinger <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158574}
Convert the quit confirm bubble to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: Ieb01c91c63b8c283ac761959d9770b20a7056bb7
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615224
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158573}
Create wrapper HTTPFetcher to make requests to Phosphor
Responses will be handled by the quiche::BlindSignAuth library. This
is only a wrapper around SimpleURLLoader to make network requests to a
Google owned Auth server (Phosphor). The response is a known format from
an internal Google owned server.
This is not currently in use.
Bug: 1444621
Change-Id: I852c9dd166fa3b20313e35a6f64964ed8b4573f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548697
Auto-Submit: Brianna Goldstein <[email protected]>
Reviewed-by: Andrew Williams <[email protected]>
Commit-Queue: Brianna Goldstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158572}
cr23: Use ripple effect on content setting icons in omnibox.
The ripple effect logic was already implemented in the base class
IconLabelBubbleView. This CL adds a call to UpdateBackground() to the
constructor of ContentSettingImageView to make sure that the ripple
effect logic is hooked up properly.
Bug: 1447073
Change-Id: I841ff5c9b585d483e2de0b90594f1aeaf0939973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604151
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158571}
updater: refactor if statement in AppServer::ModeCheck.
Bug: 1369264
Change-Id: Iafb21714028b455a7db49838ab0968dacbf5d540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618021
Commit-Queue: Sorin Jianu <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158570}
feedback: Add workaround for guest mode profile
This fixes a regression (introduced in [1]) where launching the
feedback app in guest mode results in a crash.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4560814
Bug: b:286291927
Test: manually and tast.settings.SearchSections.guest_mode
Change-Id: I4cdb06541d67b28b39dfb29b5f7922e6ca6cd0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619428
Auto-Submit: Georg Neis <[email protected]>
Reviewed-by: Xiangdong Kong <[email protected]>
Commit-Queue: Xiangdong Kong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158569}
Roll Fuchsia SDK from 13.20230615.1.1 to 13.20230615.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: Icd741685e2ac07af45cb8aeb0a004faf66fdc644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617921
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158568}
Migrate mac13-arm64-updater-tester-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie75a59432f4352c923a78c1609600d5fedc6fe2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619292
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158567}
shortcuts: Add key icons for keys during add/edit
Handle special cases:
1. 'space' -> the 'space' key which is displayed as ' ' in the dialog,
is updated to display as 'space' text.
2. 'overview' -> the 'overview' key is displayed as 'F4' during
add/edit. We have updated the keyDisplay to be 'LaunchApplication1'
then it maps to the 'overview' icon based on keyToIconNameMap.
3. 'search' -> the 'search' key now displays as a launcher/search icon
by updating key='search' to key='meta'.
* Note: Previously, in the getIconIdForKey() method, we set keyState
to MODIFIER_SELECTED if the key was a META key. This was done in
order to display the LWIN key as a modifier key and has the same css
style as a modifier key. However, to avoid setting the keyState for
the meta key from the view-dialog, we need to separate the LWIN key
and the META key.
Video:
http://go/scrcast/NDk5MTEwMjczOTI4Mzk2OHxiNGZhMTE0OC1kMQ
Bug: b/216049298
Test: browser_tests --gtest_filter=ShortcutCustomizationApp*
Change-Id: Ia4915ddcad3e1519be2877abc2db76c3d2ee9dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608892
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Longbo Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158566}
Android: De-flake CallbackHelper.waitForNext()
The issue is that CallbackHelper.waitForNext() was being called,
but sometimes the callback had already been called.
I've confirmed this fixes flakiness in:
* AutofillTest
* BookmarksTest
* OpenTabsTest
* TypedUrlsTest
Other files using this API:
* TabGridDialogViewTest.java
* StartSurfaceTestUtils.java
* WebApkIntegrationTest.java
* FencedFrameTest.java
* AwAutofillTest.java
* AwContentsClientOnFormResubmissionTest.java
* ViewTransitionPixelTest.java
Bug: 1455181
Change-Id: Id1cb8ee33c38f0750578c15c735f99ce1f5a6598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616732
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158565}
Migrate linux-updater-tester-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3ac8e89da92de35db2d9cf6befb4e975b6484e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619315
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158564}
CR2023: Update colors for menus in side panel
Bug: 1399971
Change-Id: I2e022554c984d0c9f6f0467fe620493f3db150de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617052
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Emily Shack <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158563}
Migrate android-device-flasher to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I4b108d40cad1d2d569ba8f73518b1a043c672fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618602
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158562}
Include DemoModeDimensions in status reports for devices in Demo Mode
Bug: b/281748020
Test: browser tests
Change-Id: I1a7bbb16232bf3ee69ecbf278b34ab6c95165912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599823
Reviewed-by: Yves Arrouye <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Jackson Tadie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158561}
Update V8 to version 11.6.174.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/817a9a40..d201463e
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I6f3524df017d1c3da000affbc2cac7b7c2ad8bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615001
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158560}
Migrate ASAN Release to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I2eb4fc29d01b64c99dd57bda31aca5b29fe70f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619290
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158559}
Fix dynamic color for OOBE
https://chromium-review.googlesource.com/c/chromium/src/+/4475678
removed the default color palette in BestEffortSeed, but OOBE uses
that flow to show dynamic colors for the OOBE wallpaper.
https://screenshot.googleplex.com/BGEn9to9FbSAhTh
BUG=b:276475812
TEST=ash_unittests *ColorPaletteController*
Change-Id: I79d4513dad0d003fe2a95c84532362fd9e9add3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618994
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Erica Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158558}
[omnibox][shortcut] Fix crash caused by lower cased 'İ' being 2 chars.
Some characters have different lengths in lower v upper case.
Specifically, the upper case dotted I 'İ' has length 1, while its lower
case 'i̇' (i + ̇) has length 2.
That's problematic for 2 reasons:
1) When the user has a shortcut 'Joe/Bob meeting notes', types 'Jo', and
selects the shortcut, the shortcut provider tries to truncate the
shortcut to 'Joe/Bob' instead of 'Jo' for future shortcut
suggestions. This computation from 'Jo' to 'Joe/Bob' requires
case-insensitive string comparisons between the input and shortcut
text, and case-sensitive string cutting/concatenating. These
computations are wrong if the string lengths are different in the
case-insensitive v case-sensitive operations. E.g., we might end up
autocompleting 'JoBob' or 'Jooe/Bob'. Or we may end up crashing due
to out-of-bound string manipulations.
We can't simply use string-sensitive string comparisons, because then
'JO' wouldn't expand to 'Joe/Bob'. Nor can we use string-insensitive
concatenating, because then 'Jo' would expand to 'Joe/bob'.
This CL fixes this issue by using string-insensitive concatenating
only when the shortcut contains a problematic character (i.e., 'İ').
2) When scoring shortcuts, we compare the input length with the shortcut
length. The more % the user typed, the higher the score. This breaks
when the lower cased input is longer than the original-cased shortcut
text causing a DCHECK crash for DCHECK enabled builds, or a >1 typed
fraction and higher score than intended for DCHECK disabled builds.
This CL fixes this issue by comparing the lower cased input length
with the lower cased shortcut text length.
This CL also renames `term` to `input` or `lower_input` in
shortcut_provider.cc for clarity, since `term` could refer to either the
user input or the shortcut text.
I didn't find any problematic characters other than 'İ'.
- Wikipedia mentioned some African letters may likewise contain serifs
(the accent) with similar issues. But they were all represented as 1
char in both lower and upper case in c++.
- Java source code for lower casing strings seemed to map some
Lithuanian upper case characters to multiple lower case characters,
similar to how it handles 'İ'. But they too were represented as 1 char
in both lower and upper case in c++.
- Armenian lower case 'և' has length 1, while its upper case 'Եւ' has
length 2. But these issues are mute here since our lowercasing logic
lowercases the chars in 'Եւ' individually to 'եւ' instead of combining
them into 'և'. That breaks case insensitive autocompletion, but
doesn't have a clean fix since both lower case variants 'եւ' and 'և'
are correct depending on where they occur in a word.
I wonder if the other providers have similar issues... Another reason to
dumbify and share provider logic.
Bug: 1394594, 1381891
Change-Id: I54b492b7d6835d51129103c75bf68cd4d69a134e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619116
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158557}
Migrate android-11-x86-fyi-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I7538af14786ab40098c3ec1466b747b91aef36b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619313
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158556}
Extend /base/apple/owned_objc to have weak types as well
These will be useful for gfx::NativeView/NativeWidget work.
Bug: 1280317
Change-Id: Id9dda131844b61194209690c56b99921d70b3b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610554
Commit-Queue: Avi Drissman <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158555}
Roll clank/internal/apps from 31c5c5a39bf9 to afe125efb45f (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/31c5c5a39bf9..afe125efb45f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1445112
Tbr: [email protected]
No-Try: true
Change-Id: I3730369123ddde7156071f785eb22496b55f3024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619312
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158554}
Migrate linux-ubsan-fyi-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ib2b5f0cfaab0970fc2992ab5de3563aff6940af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619311
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158553}
Remove redirect from chrome://history to chrome-native://history.
This redirect is fairly obsolete. Removing it addresses a TODO that
said so from M57.
Bug: 654071
Change-Id: I6f050759c613a33f48072dff6908e54ea1e5c210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615731
Reviewed-by: Jinsuk Kim <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158552}
Cleanup: Remove a couple unused constants in webui_url_constants.h/cc.
Bug: None
Change-Id: I120cf647c9be5068e20c35c5a378d0121cce86a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617336
Reviewed-by: Cole Horvitz <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158551}
Replace cr-toggle with cros-switch
This CL
* Introduces the XfJellybean component, which controls which version of the UI should render. It fails fast by deleting the unused UI elements.
* Implements the alternative UI using cros-switch
* Creates `enable_jellybean` browsertest option, and introduces test variants that enable the option.
https://screenshot.googleplex.com/9fZeFhtyzMwcP4M
https://screenshot.googleplex.com/9qwyUtNsxuNhMqo
Bug: 284080716
Change-Id: I43ad64ad032d4b1c400f65c66ad152d0df3deb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4559609
Commit-Queue: Christos Froussios <[email protected]>
Reviewed-by: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158550}
Migrate win10-updater-tester-rel-uac to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Id3d7b8675a36d9b007ba0a15114806165c33c8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617986
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158549}
Enable Fuzzy match for Omnibox in Launcher
Bug: b/260764125
Change-Id: I10355e6421b8892b59e1b925c4a933fd3c4ecbef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613254
Reviewed-by: CJ Huang <[email protected]>
Commit-Queue: Lauren Commeignes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158548}
Roll libyuv from 552571e8b24b to 04821d1e7d60 (1 revision)
https://chromium.googlesource.com/libyuv/libyuv.git/+log/552571e8b24b..04821d1e7d60
2023-06-15 [email protected] [RVV] Enable ARGBExtractAlphaRow/ARGBCopyYToAlphaRow
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libyuv-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I73d03335922b4daba007b7904bf643668435b0d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619270
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158547}
Migrate linux-updater-tester-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I8efe07af8bb575ae6cf69562fc77ce8cec8e3cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618599
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158546}
storage: add FileSystemURL::CreateSibling method
BUG=None
TEST=CQ
Change-Id: I3e3585d2784b614cb8cd56ce034aa2b8bfb75bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574813
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Nigel Tao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158545}
Roll src-internal from c93d596d616b to dc11bdee17e9 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c93d596d616b..dc11bdee17e9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected],[email protected]
Change-Id: Ib9dacfdbaaed743b28edf1abb01e98da2906a2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619271
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158544}
[CompositeScrollAfterPaint] Don't expand cull rect when not preferring compositing
This is to avoid possible regression for web pages containing
a lot of scrollable selects/inputs.
Bug: 1414885
Change-Id: I1a92a015e28c3881e054a9ea808b79d57c6e4bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600731
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Auto-Submit: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158543}
[gardener] Disable flaky test WebApkUpdateManagerTest#testImageDiffDifferentDimensions
Bug: 1455260
Change-Id: I4ee07afdea4c2d6fab1432b109ba923e2a0c67c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619258
Reviewed-by: Neil Coronado <[email protected]>
Owners-Override: Kevin Grosu <[email protected]>
Commit-Queue: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158542}
Roll Website from f79bff1e5976 to 65988c49579e (1 revision)
https://chromium.googlesource.com/website.git/+log/f79bff1e5976..65988c49579e
2023-06-15 [email protected] update the release notes on the website for all last 4 releases
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I21f7824a7540d511460bca1476326a7968f2e016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618102
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158541}
Migrate android-13-x64-fyi-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ie43f04dd3afc8958d9f0714ce51f3ee392794383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619134
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158540}
Migrate android-androidx-packager to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I6fb91ed53169859f78206b40205c2f5bbc21fd5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619257
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158539}
[Nearby Share] Revert breaking changes to NearbyProcess creation.
Effectively revert crrev.com/c/4496546 (key word "effectively"). This CL
reverts the changes that crrev.com/c/4496546 made to NearbyProcessManagerFactory
and NearbyDependenciesProviderFactory.
crrev.com/c/4496546 changed how the Nearby utility process and the Nearby Share
+ Phone Hub features are instantiated. Before the breaking CL, just 1 utility
process and 1 keyed service per feature was instantiated. After the breaking Cl,
more than 1 of each is created -- causing bugs like b/287061553.
We are unable to actually revert crrev.com/c/4496546 because doing so causes
regression in OOBE, and we're unable to understand why. Because this fix needs
to be land ASAP and be merged back to 115, we chose to revert just the files
that we know to be causing b/287061553.
b/287061553 is a breaking regression in the Nearby Share feature.
Test:
- Reproduced b/287061553 before applying this CL.
- Did not reproduce b/287061553 after applying this CL.
- All unit tests passed; adjusted Quick Start tests to be behind the QS feature flag.
Bug: b/287061553
Change-Id: If5e11a3c8870b21703fef49b2175e32a22686db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618867
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Commit-Queue: Joe Antonetti <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158538}
Bookmarks++: Hide empty state until load
Bug: 1455169
Change-Id: Ia9b30c814cd141719492fd421d37bf3491651e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618476
Reviewed-by: John Lee <[email protected]>
Auto-Submit: Emily Shack <[email protected]>
Commit-Queue: Emily Shack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158537}
media/gpu/VEAtests: Merge BitrateCheck tests
This CL merges BitrateCheck, BitrateCheck_DynamicBitrate and
BitrateCheck_DynamicFrameRate. They encodes 300 frames, 600 frames and
600 frames, respectively. But the former part of
BitrateCheck_DynamicBitrate and BitrateCheck_DynamicFrameRate does the
same thing as BitrateCheck. By merging the test cases, the number of
encoded frames becomes 900 frames and thus the test time is saved.
Bug: b:181193266, b:239732784
Test: video.EncodeAccel.*
Change-Id: I835f0f0e82fb4e8ee885b9709a34c9a9f7c6f460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616111
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Justin Green <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158536}
updater: whitespace clearing after reviewing TODOs one more time.
Bug: 1254481,1286574,1367437,1399177
Change-Id: I0c799b20fe68181d97e116d662aa34582e0ecbc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617685
Auto-Submit: Sorin Jianu <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158535}
shortcuts: Update tab index in row and edit-button
* Introduce 'isFirst' to only show edit-button in first-row. Earlier,
we used to set opacity=0 to hide it in other rows. Although it
wasn't visible, it was still present in the DOM which was incorrect.
* Update the tab-index, correct order: searchBar -> sideNav ->
acceleratorRow -> editButton(if present) -> next Row
video: http://go/scrcast/NTY1MTE4NjkwMTMxOTY4MHxiZjM1MjJiMy1kZg
Bug: b/216049298
Test: browser_tests --gtest_filter=ShortcutCustomizationApp*
Change-Id: Idea58b89cdb8cc615cf916a512b2358b98f254c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606730
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Longbo Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158534}
Revert "Move ColorProviderManager::Key into its own header"
This reverts commit fedf27f399cf7cfc7148be925a7fb1e9b6998b40.
Reason for revert: Cannot compile chrome/browser/ui/webui/side_panel/customize_chrome/customize_chrome_page_handler.cc because ColorProviderManager::Key no longer exists.
This CL raced crrev.com/c/4606058
Original change's description:
> Move ColorProviderManager::Key into its own header
>
> Many includes of color_provider_manager.h just need one of the types and
> not the manager itself. Separate the Key types and declaration into its
> own compilation units.
>
> This allows targets to set ColorProviderKey values without depending
> on the entirety of ui/color.
>
> Bug: b:286952053
> Change-Id: I8416bc3bd40b1352cc0b3d9cbab42648256c9c42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609702
> Reviewed-by: Ricky Liang <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Commit-Queue: Sean Kau <[email protected]>
> Reviewed-by: Alexander Timin <[email protected]>
> Reviewed-by: Thomas Lukaszewicz <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158531}
Bug: b:286952053
Change-Id: I7b10fdeee17142ae39fa38c87a4516cc11256b9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618073
Reviewed-by: Luciano Pacheco <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Luciano Pacheco <[email protected]>
Owners-Override: Luciano Pacheco <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158533}
Migrate ASAN Release Media to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Id00e2d6367d66707117d6d8012f4c1be216b7e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619255
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158532}
Move ColorProviderManager::Key into its own header
Many includes of color_provider_manager.h just need one of the types and
not the manager itself. Separate the Key types and declaration into its
own compilation units.
This allows targets to set ColorProviderKey values without depending
on the entirety of ui/color.
Bug: b:286952053
Change-Id: I8416bc3bd40b1352cc0b3d9cbab42648256c9c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609702
Reviewed-by: Ricky Liang <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158531}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686851973-f2c09176a18265d230448c21150e0d939c536b92.profdata to chrome-win32-main-1686862750-64c913bb16dbf84d78f82669bcff96f2ae29c7f7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I43c5cc8f59325b7e1fc3225b6504becce087aea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617120
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158530}
Extend Android.MultiWindowMode.TotalDuration
Fixed: 1448126
Change-Id: I7a3ede51cb30522d3727eb8db327fa4936689d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609701
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158529}
Tab Search: Chrome Refresh 2023 update part 2
Update item height, margin, scrollbar color and add a divider.
Screenshot with GM3 disabled:https://screenshot.googleplex.com/6LK3rwpNKUfRB8y
Screenshot with GM3 enabled:https://screenshot.googleplex.com/5Ftv5vRB2cSYVXo
enabled dark theme:https://screenshot.googleplex.com/4yUtPVv4LYRqt82
Specs: https://www.figma.com/file/5xWeeSmVQTd4yW3s6aFJ1f/CDDS-UX%2FEng-Spec?type=design&node-id=4592-189100&t=rEtsw5CaZOun3et7-0
Change-Id: Icd4f6cdeb573fe90f2e055ba7bb7fe71352fb9c2
Bug: 1422116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609475
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: John Lee <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Yuheng Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158528}
[VC] getting permission from every render frame host.
Some tabs can have permissions at their iframe, but not itself; in
case the tab still be able to access camera and microphone, but we
will not show the vc tray.
The fix is to go through each render frame host and aggregate the
permission of them all.
BUG=b:287150755
TEST="autoninja -C out/Test chrome/test:browser_tests && out/Test/browser_tests --gtest_filter=*VideoConference*"
Change-Id: I5c81d1fd520bb58dee0b9a6c95ffb10596eaeff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612926
Commit-Queue: Charles Zhao <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158527}
Update target language combobox height
This CL updates the height of the target language combobox in the
Global Media Control according to the latest UX mock:
go/live-translate-directional-review
Bug: 1426899
Change-Id: Ic347e00a3e7e13543bb11c8ad5fd41a347e7ccfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619113
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Evan Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158526}
Migrate linux-lacros-archive-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3dfad7994c6815bdccd85312da1b0a486db5bc1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619347
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158525}
Create raw json in result processor
Process test results at one place, so that we have one
unified rules to determine regressions and unexpected pass, etc.
Bug: 1426296
Change-Id: I524d2099aa16379b6589561ef27f3cd291978ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4456249
Reviewed-by: Jonathan Lee <[email protected]>
Reviewed-by: Nihar Damarasingu <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158524}
Make DocumentPartRoot on Document lazy initialized
This just avoids always having a DocumentPartRoot on Document even
if the Document doesn't ever use DOM Parts.
Bug: 1453291
Change-Id: Idd384bfa06d32958de10bfe93de0e5955240b663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617123
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158523}
Revert "Lacros: Enable WebAppIntegration* test for version skew test."
This reverts commit 169263e3191ae1a1b489085c183fa9d6a2bad208.
Reason for revert: WebAppIntegration* test crashed ash on CI bot(linux-lacros-tester-rel)
Original change's description:
> Lacros: Enable WebAppIntegration* test for version skew test.
>
> Bug: 1451234
> Change-Id: I491e557822605a25cc79293c5f02c29ea4d2240f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609460
> Reviewed-by: Sven Zheng <[email protected]>
> Commit-Queue: Jenny Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157946}
Bug: 1451234
Change-Id: Ie1c7ae788c5e2a3e42ae645ff971cd096302a8ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619309
Auto-Submit: Jenny Zhang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158522}
Convert the rest of /media to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: Iacf43d132b1d9a70252a246c1984ca24477d6059
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604836
Reviewed-by: Dale Curtis <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158521}
Roll src-internal from fe8274c0ba6d to c93d596d616b (2 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe8274c0ba6d..c93d596d616b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1431232
Tbr: [email protected]
Change-Id: Ide6c260c4510f7a2cac2c0777eb1e5a482109a4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618691
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158520}
[A11y] Recreate the activity on tablets if a11y state changes
Recreate the activity on tablets if a11y state changes.
-Done to prevent crash where if the legacy a11y list switcher was
opened, a11y was disabled, then the user tried to interact with tab
groups on the GTS, the app would crash.
Bug: 1454842
Change-Id: I25f9f37a4426a5bb58dc033cffe1b43ce0470f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619095
Code-Coverage: Findit <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158519}
Migrate linux-rel-cft to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Idc22192f1eafb3eb1ef30511ca05c1259c965c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618026
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158518}
welcome tour: Disable welcome tour during tablet mode
Welcome Tour will not be supported in tablet mode. This CL makes it not
start if in tablet mode, and abort if tablet mode is entered while it is
in progress.
Bug: b:285628471
Change-Id: Ic596a57ca79c541511435cd681e3d1c5f4cc13db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608634
Commit-Queue: Angus McLean <[email protected]>
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158517}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686851973-8c3b38099cb6a4ee5f0d36790f3e9955b088f3ba.profdata to chrome-win64-main-1686862750-d3a3f859e747dd876f5a30b396461bc9e1c5c6a4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: If132ec7281e9f8a17c77c676e736cae8af6ef617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618773
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158516}
Add UMA histogram for multi-port's active migration config status
Called at https://source.chromium.org/chromium/chromium/src/+/main:net/third_party/quiche/src/quiche/quic/core/quic_connection.cc;l=3973;drc=90315e8698e0d2290a8a0fdfe96318ebb1a210a7
BUG: b/240616957
Change-Id: I4727ea97a0fd149203be522eef3f0e2b81934a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617391
Reviewed-by: Nidhi Jaju <[email protected]>
Auto-Submit: Renjie Tang <[email protected]>
Commit-Queue: Renjie Tang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158515}
Add SystemNudgeV2 DCHECK on nudge manager getter
Add DCHECK to enforce that we only use AnchoredNudgeManager::Get() when
the feature is enabled.
Bug: None
Change-Id: Id60ae655763a28ecb010564ec9067514dd619fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617060
Commit-Queue: Kevin Radtke <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158514}
[gin] Add flag for iterator helpers
This CL adds a kill switch for iterator helper flag
in v8.
Bug: v8:13558
Change-Id: I846a8f30151e20d84657fb6fd2f4b30097d8b3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562888
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158513}
Disable some arc.* test through tast_control.gni
Disable these tests to unblock LKGM.
Bug: b:287525851
Change-Id: I5b5a14833871340183a44b4f4b25d3f1f5dcc515
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615931
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158512}
Fix HoldingSpace*BrowserTest.PrimarySecondaryAndAccessibleText.
Test currently fails when Jelly is enabled. We don't need to go so far
as to parameterize our test for Jelly, but we need to pass when Jelly
is enabled by default so as to unblock Jelly launch.
Bug: b:287367193
Change-Id: Iaea566096f591fe955311cd8c1ec9e20209bd417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616734
Reviewed-by: Colin Kincaid <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158511}
dlp: Move FilesPolicyDialog from CrOS to ASH
Moves the dialogs used for Files restrictions to be under ash/, as this
simplifies using some of the constants and helpers, instead of using
hardcoded values for fonts, colors, sizes, etc. We can do this for files
since all the UI is shown from FPNM, which lives in ash, and furthermore
the dialogs are only created after the user clicks on a notification,
which are also only in ash.
[email protected]
Fixed: b:287450334
Change-Id: I59e6897f295e9e0660a7923756438d434964839f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618150
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Luciano Pacheco <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Auto-Submit: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158510}
Enable SuppressToolbarCaptures by default.
Bug: 1406304
Change-Id: I701ffcc1126e97e30470e06ec27675d1c086cba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618071
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158509}
Strip focus type restrictions when serving ZPS on Shortcuts Widget.
Originally Android ever supported only the INTERACTION_FOCUS for
most page contexts.
Late last year we introduced INTERACTION_CLOBBER, which, beside
INTERACTION_DEFAULT and INTERACTION_FOCUS, defined a separate focus
variant, indicating that the user is visitng a webpage.
Shortcuts widget, while presenting itself as an NTP, is in fact
acting as a webpage, so its focus type has changed, and suggestions
started being suppressed.
Unsurprisingly, this is where the Cached Zero Suggestions chimed in,
serving the content where ZeroSuggestProvider was silent.
This change fixes this issue by stripping the unnecessary check:
the Omnibox on Search Activity can only be focused once.
Note: this incorrect condition led to lack of proper attribution of
ZPS suggestions being offered to our users about 0.2% of the time.
http://uma/p/chrome/timeline_v2?sid=279b50736361e197fa6fc31a02e4bc62
Change-Id: I62540627f6b735c2742c7e5ef33b6aeb057369d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619115
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158508}
[CR2023] Add typography emphasis tokens
screenshot: https://screenshot.googleplex.com/AyadvxEp7SsKNP7
Bug: 1399939
Change-Id: I7f06dcf33ad7e7a7e1aa74edc05735de30874360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617928
Code-Coverage: Findit <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Keren Zhu <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158507}
personalization: enable multi-zone-rgb-keyboard by default
Feature is expected to be launched in 116, thus this CL enables the
needed flag to be on by default.
BUG=b/287522578
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I9194f0bf9e07f41023350265e98e762731c4224e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617872
Reviewed-by: Jeffrey Young <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158506}
[User Education] Do not mirror when anchored to non-accelerated widgets
Turn off mirroring so help bubbles can extend outside bubble dialogs.
Bug: 1450062
Change-Id: Iea40bb2a7b60feea3ffa12db75e02c1b62b209da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603481
Reviewed-by: Dana Fried <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158505}
Roll ANGLE from 3545ae0ca0b3 to 46ff02f8a2b1 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/3545ae0ca0b3..46ff02f8a2b1
2023-06-15 [email protected] Capture/Replay: Initial setup for angle_capture_tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Id5b9f57e3c12a9bf033e827471febecaa70ce88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618593
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158504}
[PWA] Small AppBannerManager cleanup required to store ML state
Bug: b/286066235
Change-Id: Iaa7bb0ec4185c9f4b1c664c3371aa61d2415b1db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595409
Reviewed-by: Dibyajyoti Pal <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158503}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686859151-c996e9c519c1b50f44d1ebfc3e27b1baccbac1e6.profdata to chrome-mac-arm-main-1686866392-8024717ffe8ae9d18bf77dc3dea43e7c8cdd32fd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I76c054b8ac5fe6c9703f1515c7e18fd272a49be7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618806
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158502}
Roll ios_internal from 4172711d5992 to 55863f051bc1
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/4172711d5992..55863f051bc1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1353430
Change-Id: I9d1eff0dd77c745ef4c4b93b8b6517d1c503ba6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618774
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158501}
siso: update Siso to new stable version v0.0.2
Bug: b/286792212
Change-Id: I5213591a0f46eb695fc643e0ddb50fd10eb01870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615587
Commit-Queue: Fumitoshi Ukai <[email protected]>
Auto-Submit: Philipp Wollermann <[email protected]>
Reviewed-by: Fumitoshi Ukai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158500}
Clean up page size calculation in PrintContext.
When calculating the page rectangles, we were calculating the page size
on our own in a slightly convoluted way. It's easier and less bug prone
to just read out the page size stored in the LayoutView.
The page size is set in LocalFrameView::ForceLayoutForPagination().
Initially the specified page size is used. If we decide to scale down
the contents to fit more in the inline direction, we'll do that, and set
the page size again. This is the page size used during layout, so just
use it directly.
This is just a cleanup of PrintContext::ComputePageRects() (more work is
needed in order to support mixed page sizes). No behavior changes
intended in this CL.
Change-Id: Iecbeab0a22d2581c7ec84e0d95447b85e8141a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616064
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158499}
arc/gio: Add key label to key description
Match the key description (under "Selected key") to the label(s) used
for the selected action, and display them.
Bug: b/270969760
Test: Manual test on input overlay application
Change-Id: I4db45d4601aeb8def2983bc8a3a8f47ac83618d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4559152
Reviewed-by: Cici Ruan <[email protected]>
Reviewed-by: David Jacobo <[email protected]>
Commit-Queue: Joseph Pang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158498}
Add requestId to the list of top level allowed fields in ERP job config.
Change-Id: I41035ce482059a90e65dc0f844e4c6c88b79f0d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619094
Commit-Queue: Ahmed Nasr <[email protected]>
Reviewed-by: Leonid Baraz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158497}
Fix retry in LOG_UPLOAD events
Before this change retry only worked on Initiation, and was not
triggered by NextStep or Finalize failure. Now it is, and unit tests
have been added to ensure that.
Besides, a bug was found: retry_count was decremented during Initiation,
and so the NextStep and Finalize events could not find the registered
job (registration used retry_count before decrement), since they only
got decremented retry_count. This has been fixed too, and unit tests
were modified to ensure that. Also, FileJob unittest have been refactored to take out common initializers and matchers, following RecordHandlerUpload unittests.
Removed unused helper in record_handler_impl.
Bug: b:278744577
Change-Id: I8f038208056ee56f64becd948eaae060d7cfc7fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616008
Reviewed-by: Josh Hilke <[email protected]>
Commit-Queue: Leonid Baraz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158496}
media/gpu/VEAtests: Remove skip functions for kepler
Kepler devices are not supported today. This CL removes the function
to skip the test cases on the devices.
Bug: None
Test: Build
Change-Id: I902ff8ea9bab0784ef7090fd554060029f3e9fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616110
Reviewed-by: Justin Green <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158495}
Roll Catapult from e1af66321ce2 to 10aab97228d8 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/e1af66321ce2..10aab97228d8
2023-06-15 [email protected] Send request to skia bridge to upload data to skia perf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: [email protected]
Change-Id: Ie2c5ab55f2528264b74682ba58985f96a636a507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618420
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158494}
customization: Add routes for graphics tablet subpage
- Add a blank subpage for the graphics tablet.
- Add the route for the subpage.
Screenshot: https://screenshot.googleplex.com/AyVz2ruMZf4gfoQ
Bug: b/241965717
Test: browser_tests --gtest_filter=*OSSettingsDevicePageTest*
Change-Id: I8dcbd7a66ba1c83f4d13740159099e1ddfc5a2ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611687
Commit-Queue: Yuhan Yang <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158493}
Support linking Rust in cross-compile-for-Windows
When linking for Windows, we need to drop the `-Bdynamic` from the
command line. This was done in rustc_wrapper before but can now be
done properly in the GN toolchain thanks to the commit at
https://gn.googlesource.com/gn/+/e3978de3e8dafb50a2b11efa784e08699a43faf8.
When linking for Windows, we also have to convert `.lib.lib` into
`.lib` which is another GN bug being fixed upstream. We do this in
the rustc_wrapper still, but it was only looking at the host OS
(from python that is all it sees). So we add a flag to tell it we're
building for Windows.
[email protected]
Bug: 1271215
Change-Id: I21f27eb5137832402783217d82886fe518ac35e3
Cq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-rel,android-rust-arm64-dbg,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-dbg,mac-rust-x64-dbg,win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617337
Commit-Queue: danakj <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158492}
[DoH] Remove Net.DNS.SecureDns* histograms
This CL removes the following histograms:
- Net.DNS.SecureDnsMode.Off.ResolveTime
- Net.DNS.SecureDnsMode.Automatic.ResolveTime
- Net.DNS.SecureDnsMode.Secure.ResolveTime
- Net.DNS.SecureDnsTask.DnsModeAutomatic.FailureTime
- Net.DNS.SecureDnsTask.DnsModeSecure.FailureTime
The secure DNS resolution times and failure times are better
tracked by the per-provider
Net.DNS.DnsTransaction.<Insecure|SecureValidated>.<FailureTime|SuccessTime>
metrics (with metrics from unknown providers being grouped
under the 'Other' histogram provider name).
OBSOLETE_HISTOGRAM[Net.DNS.SecureDnsMode.Off.ResolveTime]=No longer needed; can use per-provider Net.DNS.DnsTransaction.Insecure.SuccessTime histograms instead
OBSOLETE_HISTOGRAM[Net.DNS.SecureDnsMode.Automatic.ResolveTime]=No longer needed; can use per-provider Net.DNS.DnsTransaction.SecureValidated.SuccessTime histograms instead
OBSOLETE_HISTOGRAM[Net.DNS.SecureDnsMode.Secure.ResolveTime]=No longer needed; can use per-provider Net.DNS.DnsTransaction.SecureValidated.SuccessTime histograms instead
OBSOLETE_HISTOGRAM[Net.DNS.SecureDnsTask.DnsModeAutomatic.FailureTime]=No longer needed; can use per-provider Net.DNS.DnsTransaction.SecureValidated.FailureTime histograms instead
OBSOLETE_HISTOGRAM[Net.DNS.SecureDnsTask.DnsModeSecure.FailureTime]=No longer needed; can use per-provider Net.DNS.DnsTransaction.SecureValidated.FailureTime histograms instead
Bug: 1363186
Change-Id: Ie778a31f1acd4af99ae27a5fdfda83cb9d3928c1
Fixed: 1441475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606176
Reviewed-by: Eric Orth <[email protected]>
Reviewed-by: Tsuyoshi Horo <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Andrew Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158491}
[Fixit] DownloadForegroundServiceManagerTest
DownloadForegroundServiceManagerTest was failing on multiple
builders. I reproduced on AVD generic_android31.textpb config and found
that if (VERSION.SDK_INT < VERSION_CODES.S) started evaluating to false
instead of true. The tests seem to assume that canStartForeground
will always return true and don't test that logic specifically
(which I would expect to be a unit test anyway). I've added in
an override to MockDownloadForegroundServiceManager to always
return true for the purposes of these tests. The tests are passing
on generic_android31.textpb AVD config and I expect this will fix the
issue on the emulators the test is running on.
Bug: 1297682
Change-Id: I883036718e82c3784374dbce464bfad79692bbf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617059
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: David Maunder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158490}
Roll WebRTC from ccc87ea3c625 to 816dc3b6081d (1 revision)
https://webrtc.googlesource.com/src.git/+log/ccc87ea3c625..816dc3b6081d
2023-06-15 [email protected] Roll chromium_revision 570bae752f..8603a0cee2 (1158090:1158377)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I563ced6d715d0e812647ace49773abe93f5a634d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619167
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158489}
[ExtensionSafetyCheck] Potentially unsafe extension row element implementation
Implements the inner elements and integrate the extension apis.
Bug: 1432194
Change-Id: I521e2aa4b44a798b34b7d56384014312e0305665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4490823
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Zack Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158488}
Put --rsp-quoting behind -Clinker-arg for Rust toolchain commands
The `--rsp-quoting` flag is added when cross-compiling to Windows
and is added to the `$link` command, which is incorrect. It should
be treated more like LDFLAGS. For C++ link targets, it can go directly
in the command line but for Rust targets it needs to be quoted with
-Clinker-arg to be passed through to the linker.
[email protected]
Bug: 1271215
Change-Id: Iaf7a65727368f0612b71759491a30e313ca3075a
Cq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-rel,android-rust-arm64-dbg,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-dbg,mac-rust-x64-dbg,win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615559
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158487}
[remoting] Support external notarization tool in do_signing.sh.
This updates the Mac signing script to support passing in a
notarizing tool, instead of using notarize_thing.py.
Once the Google-internal script is switched over, a followup CL can
remove the usage of notarize_thing.py.
Bug: 1449970
Change-Id: I264a8a61a988e72ec2f32c23da54dba1abdfd228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616689
Reviewed-by: Robert Sesek <[email protected]>
Auto-Submit: Lambros Lambrou <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158486}
[PhoneHub][Nudge] Migrate from SystemNudge to AnchoredNudge
This CL uses AnchoredNudge for PHone Hub nudge so the nudge is anchored to the Phone Hub icon.
Screenshot: https://screenshot.googleplex.com/3Ezjj33HURdZk83.png
Bug: b/282054003
Change-Id: Id2ae526d0f62060e9aaf82c9b70de75b06e8411e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4518251
Reviewed-by: Kevin Radtke <[email protected]>
Commit-Queue: Pu Shi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158485}
Remove TabStyleViews::Create()
The tab-less factory function for a TabStyleViews was only being used to get the minimum active and inactive width pseudo-statically. Moving those to TabStyle - where standard and pinned width already are - lets us delete this, so now all TabStyleViews are constructed in reference to a specific Tab.
I had to move TabCloseButton::GetGlyphSize to a layout constant as well, because it's part of the minimum active tab width calculation, and tab style is in c/b/ui/ which doesn't allow c/b/ui/views includes.
Bug: 1399942
Change-Id: I97be55a0d5873d1dcae28bb556df1724a55ae7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618727
Code-Coverage: Findit <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Taylor Bergquist <[email protected]>
Reviewed-by: Shibalik Mohapatra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158484}
Fix pathos pool usage
Fixes the unexpected pass finder code not properly closing/joining
pathos' process pools. This seems to fix the flaky SIGTERM stack traces
we started getting in the GPU unexpected pass finder and speculatively
fixes the flaky hangs we have been getting.
Bug: 1451029
Change-Id: Ic6c1467d866be81b2ff22fbedb3911cc7a129c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615734
Commit-Queue: Ben Pastene <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158483}
Update V8 to version 11.6.172.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b1af31e..817a9a40
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I1480474e2052200f626bfa5ecc299be063c7a8ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616514
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158482}
geolocation: Add LocationProvider::FillDiagnostics
Introduce mojom::GeolocationDiagnostics and add a method to
LocationProvider to populate it with details about the provider's
internal state.
At first, mojom::GeolocationDiagnostics will contain an enum
value indicating whether the provider is stopped, started in high
resolution mode, started in low resolution mode, or blocked by a
system permission.
Bug: 1110995
Change-Id: I07b6446b5e3fa78f738c4f75c3a35ed50fdf2d06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4506614
Commit-Queue: Matt Reynolds <[email protected]>
Reviewed-by: Alvin Ji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158481}
ui/display/manager: Add directory name pattern for file enumeration
When DisplayPortObserver enumerates connectors, filter by directory name
pattern to only enumerate DP connectors to prevent unnecessary file
enumeration.
Bug: b/286953986
Test: Pass unit tests
Change-Id: I75407c0ff9326e1a87386a90724a02c2a3b60a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618749
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Won Chung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158480}
Lacros: Remove CWS payment app from ash extension keeplist.
Since we are deprecating Lacros SxS/LP mode, and only support
Lacros Only mode (go/lacros-sxs-primary-removal), we should remove
CWS payment app from ash extension keeplist for two reasons:
1. This app is deprecated already.
2. In Lacros Only mode, ash-chrome browser is not accessible to
users, therefore, there is no need to keep this app running in
ash.
Bug: 1454874
Change-Id: I84118b519c312093d09708eadf075d1f162c590a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616684
Quick-Run: Po Hu <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Jenny Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158479}
Fix screenshots not working on Lens unified side panel feedback.
Bug: b:281852066
Change-Id: I94be114dc851e40f9e5b4b0a086f0316876ef754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618993
Commit-Queue: Juan Mojica <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158478}
[Topics] Send the taxonomy_version via PageTopicsModelMetadata
This makes it possible for the Annotator to only use a model compatible
with the Finch configured taxonomy (or return error if it cannot find
one), rather than potentially being inconsistent.
Bug: 1310951
Change-Id: I52c8bb17f3d2968ee8b4006264009192de02c588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615000
Commit-Queue: Yao Xiao <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158477}
Quota: log more specific metrics for db errors.
When there's an error, log to a histogram variant for the operation that
had the error.
Bug: 1453648
Change-Id: I37b1fa08e7fec303456cd0dd541bc208af05a4b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599891
Auto-Submit: Evan Stade <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158476}
Revert "Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json"
This reverts commit e1b6c1f4bc9dfda8693d05697130c15114c08716.
Reason for revert: This reland caused unexpected regression again (https://crbug.com/1455034)
Original change's description:
> Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json
>
> The previous CL (https://crrev.com/c/4604704) caused regressions. This
> CL tries to enable SpeculativeServiceWorkerWarmUp without
> IntersectionObserver.
>
> Bug: 1431792
> Change-Id: I7877c3ec652636d9c4dead9e6329f3642bf687b2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614823
> Reviewed-by: Yoshisato Yanagisawa <[email protected]>
> Commit-Queue: Minoru Chikamune <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157880}
Bug: 1431792
Change-Id: Ic381832b10f280f331cb6c975bf6024cefae9e19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614910
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158475}
Allow hiding popups for currently hidden notifications
This is necessary to prevent the user from being bombarded with popups
after the Welcome Tour.
Currently, all callers of `MarkSinglePopupAsShown()` either check for
visibility or can only be called on visible notifications, e.g., the
drag action for notifications. Therefore this is not a logical change
for current callers.
Also, this seems to have been a restriction that accidentally crept in
from a refactor nearly a decade ago, not a purposeful limitation.
Bug: b:277091643
Change-Id: I3e1ba50ffffc81aee7efbc61eb7abb604c094df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616020
Quick-Run: Angus McLean <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Angus McLean <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158474}
Add motionmark and jetstream2 tests to pgo.md
Bug: 1455237
Change-Id: I7fe3f043f36f5fc023773329fbcc47ef1a00a500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615349
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158473}
WebUI: Remove startColorChangeListener helper, part 4 (last).
Actually delete startColorChangeListener, all usages have been removed
in preucrsor CLs.
Fixed: 1450109
Change-Id: I8cff628856e3b908c8f8e9af0d1357b659b58ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616407
Reviewed-by: John Lee <[email protected]>
Commit-Queue: John Lee <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158472}
[Fuchsia] Apply force-protected-video-buffers flag in cast_streaming
protected video buffers were not enabled in cast_streaming, which was
causing buffer allocation error in some cases. Respect this flag in
all cases, even when DRM is disabled. The flag is ignored on x64 to
avoid breaking tests running in QEMU.
The flag is still ignored on x64, which is necessary to work around
https://fxbug.dev/126639.
Bug: 1454619, 1013412
Bug: b/283830866,
Bug: fuchsia:126639
Change-Id: Ibdb05b4e1461a49b63ed0708d160be61e7acf73b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616675
Reviewed-by: David Dorwin <[email protected]>
Auto-Submit: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158471}
Standardize EventTargetData creation and usages
Most EventTargets inherit from EventTargetWithInlineData, which
allocates and initializes the EventTargetData during construction.
Node is the sole exception: it inherits directly from EventTarget.
It lazily creates EventTargetData and stores it in a static map.
Move this lazy initialization pattern into EventTarget, and have all
EventTargets use it. This requires making the static map
ThreadSpecific.
Change-Id: I8f8684dc6b707b470035f188f0392ce7dd16e8e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590464
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158470}
snap-group: Let `SnapGroupController` decide to show or skip overview
This CL enables `SnapGroupController` to show or skip showing
overview on window snapped.
When showing overview is allowed, user is able to select a window
from the other side of the screen to complete a desired window
layout.
Whereas when showing overview is not allowed, overview will not
be allowed to show on window snapped. This will be useful when
restoring the window state for snap group.
Fixed: b/287092923
Test: Added unit test
Change-Id: I3718ca03928393c43b6d813032a36bdc808aca52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606132
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Michele Fan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158469}
IndexedDB: rename variable for clarity
A file system access (transfer) token is used to refer to a handle
across IPCs, whereas the serialized version of a file system access
handle is used to store a reference in the IndexedDB database (currently
leveldb).
Make sure not to confuse these two concepts by reusing the term token.
Bug: none
Change-Id: I5518d35e7f4000a34de9c810360fbdddc0111e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615352
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158468}
Revert "Modify and migrate SUS unit test to components"
This reverts commit ad775a0956ca935d073478b2f1a0519a27cc0d11.
Reason for revert:
This is consistently failing on a ubsan builder ever since this test was added: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/23752/overview
I was able to reproduce locally on my linux machine with the same GN args as the builder.
Original change's description:
> Modify and migrate SUS unit test to components
>
> Bug: b/283048019
> Change-Id: Ifb3b10f93ea390c2a98cbb159dc4651e85304115
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593233
> Reviewed-by: Tomek Jurkiewicz <[email protected]>
> Commit-Queue: Anthi Orfanou <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158269}
Bug: b/283048019
Change-Id: I028fbf6fa867d4e78e14786ac66220bb1ce0b87c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617984
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Owners-Override: Joey Arhar <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158467}
Roll WebGPU CTS from f7988e7e72f5 to 7a75cdbc1aee (8 revisions)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/f7988e7e72f5..7a75cdbc1aee
2023-06-15 [email protected] Fix throws/rejections of non-Error types, and add lint (#2769)
2023-06-15 [email protected] Skip test if compat mode
2023-06-15 [email protected] Add compat test suite
2023-06-15 [email protected] validation for bad bitcast cases (#2754)
2023-06-15 [email protected] fix comments and typo
2023-06-15 [email protected] Allow calling `setDefaultRequestAdapter` with the same parameters.
2023-06-15 [email protected] Don't set powerPreference if it's ''
2023-06-15 [email protected] Add compatibility option
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Iaf879e3d784e458d30dd5de2d58cfadbff0e0dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618992
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158466}
Fix caption bubble persistent hover behavior
This CL fixes an issue where clicking the caption settings button or
back to tab button causes the buttons to hide, but the hover ring still
appears around the button. The buttons should still be visible if the
mouse is still hovering over them.
Bug: 1426899
Change-Id: Ib42e62bcc5ae962f9b2524cbc596aa6aa561e154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619109
Reviewed-by: Yiren Wang <[email protected]>
Commit-Queue: Evan Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158465}
[gardener] Disable flaky test DecoderServiceHostTest#testCancelation
Bug: 1306924
Change-Id: Ia90f2a231b327519864f7dc929d8161aa88d941f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619128
Owners-Override: Kevin Grosu <[email protected]>
Reviewed-by: Lijin Shen <[email protected]>
Commit-Queue: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158464}
Add kEnablePermissiveUsbPassthrough flag
As part of go/cros-usb-passthrough, we would like to control when more
permissive USB passthrough will be enabled for devices.
Bug: b/286577995
Test: CQ
Test: 'AboutFlagsHistogramTest.*'
Change-Id: Iddfa3ddd47dbcd82d185955f65d1a4fa437e4a98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615350
Reviewed-by: Fergus Dall <[email protected]>
Commit-Queue: maciek swiech <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158463}
Add kSystemNudgeV2 flag to chrome://flags
Tested: verified that the flag shows up in chrome://flags page
Change-Id: I1634b9d354d70a22ce8fa37b6ad857d35ca1c561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617682
Reviewed-by: Kevin Radtke <[email protected]>
Commit-Queue: Pu Shi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158462}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686851973-ec932974f0436d4f473c18445a71b4520b91538f.profdata to chrome-mac-arm-main-1686859151-c996e9c519c1b50f44d1ebfc3e27b1baccbac1e6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I509cc7de8a3bfba87f64f3ebc04bd7ae4c9b6789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618483
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158461}
Add content client API for legacy tech report.
When the legacy reporting is enabled by enterprise policy, pass the flag
into the renderer process to allow reporting being triggered.
Once the report is triggered, the report data will be passed back to the
browser process so that it can be uploaded to the enterprise management
service.
Bug: 1441215
Change-Id: Icb3935215a26fd34ff5e0fef28f7cf26fffa50d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607147
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158460}
Add check/uncheck icon to tasks glanceables.
Bug: b:277268122
Change-Id: Id9f9ffe657bba58589aa9ff457042933f7d6b5ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617868
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158459}
[AuxiliarySearch] Add UMA recorder for donation and deletion
Low-Coverage-Reason: Only xml files.
Bug: 1453664
Change-Id: Ice46174fcc4a8cd6d301a3f056c6f5adaf4213b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600348
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158458}
Add metrics to track the user's interaction with the mandatory reauth
opt-in bubble.
This CL modifies the MandatoryReauthBubbleControllerImpl such that it
tracks when the user is shown the opt-in bubble and the type of
interaction the user ultimately has with the opt-in bubble. These
metrics, along with the metrics that will be added for the confirmation
view can be utilized to determine the effectiveness of the feature.
Bug: 1427216
Change-Id: Id8d9e24d4cca4fae240f0449450d942efe7c799b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575044
Reviewed-by: Olivia Saul <[email protected]>
Commit-Queue: Justin Wells <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Vinny Persky <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158457}
[Nearby Connections] Upprev from ebe02e117470 to aee56f072963
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/ebe02e117470..aee56f072963
2 revisions:
- [Nearby Connections] Add CancellationFlag::Uncancel
PiperOrigin-RevId: 540633470
- Add NewSendDesktopNotification to analytics recorder
PiperOrigin-RevId: 540626567
Tested: Verified on DUT
Change-Id: I3c1fd98600712c98cb032af5370f489f7bf48945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618869
Reviewed-by: Crisrael Lucero <[email protected]>
Commit-Queue: Juliet Lévesque <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158456}
Speak on Mute Opt In Nudge tweaks
Add nudge title, and make nudge have infinite duration.
screenshot: https://screenshot.googleplex.com/92B5k6yosPg6EYy
Bug: b:286468502
Change-Id: Ie2460ebf5d80aba894bf1d38f819454d52f2cb8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609527
Commit-Queue: Kevin Radtke <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158455}
[fuzzing,coverage] Update mb configuration to use reclient on the bots.
goma doesn't work on the bots, so use reclient instead.
Change-Id: I0d86c8ac00edd444721b743be909153560f1363f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617285
Commit-Queue: Julia Hansbrough <[email protected]>
Reviewed-by: Adrian Taylor <[email protected]>
Reviewed-by: Erik Staab <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158454}
Update Terminal settings for UMA
Change-Id: Ifee55d0b8e3d8638941a57f141295a2c621d98a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617468
Commit-Queue: Joel Hockey <[email protected]>
Auto-Submit: Joel Hockey <[email protected]>
Reviewed-by: Jason Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158453}
Clean up unnecessary logging.
An unfortunate leftover submitted with http://crrev/c/4616670, that
i used to understand the issues with most visited sites provider test.
Change-Id: Idf1f5e94205539fc32a55ec345a6ed194de9711c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617871
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158452}
[iOS] Change default Follow header to match launched
Disables sticky header and sets height to 30 to match launched behavior.
Change-Id: I9898b05be124077cb113171415797be2a2fbe411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614902
Commit-Queue: Sergio Collazos <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Auto-Submit: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158451}
Add Accessibility.LiveTranslate.EnabledFrom* metrics
This CL adds metrics to track how often and from where the Live Translate feature is enabled.
Bug: 1426899
Change-Id: I6dee5701f26041750d8b54001a3182dd849bdc8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617049
Commit-Queue: Evan Liu <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158450}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686844703-cf1682aa66cc43bcf70090915a935dc9fbb31e6d.profdata to chrome-mac-arm-main-1686851973-ec932974f0436d4f473c18445a71b4520b91538f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I5c43d15b4d3885ab2e095f0da5f0c6cec317fe56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618796
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158449}
Roll Catapult from 48e6e7d96bf4 to e1af66321ce2 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/48e6e7d96bf4..e1af66321ce2
2023-06-15 [email protected] [Sandwich] Implement _CheckSandwichAllowlist
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1454620
Tbr: [email protected]
Change-Id: Ie11a459e19ab5866b67d53709f9e0f61b01cbdfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618803
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158448}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686808727-d8829d8c15c1f090186f4e32e424b1aa737a0cad.profdata to chrome-mac-main-1686851973-3a78e5ad1727a0891f09496acf5b321f06ff842f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I4e5e505eab5da74f2aa9d2817fa9947fe1e10b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617080
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158447}
arc/gio: Wrap duplicated code into one function
This CL wraps duplicated code into function
OnLoadingFinished() which is called when GIO finishes loading data or
mojom call.
Bug: b/280136035
Test: unit_test passed
Change-Id: Id44b918d4eda8a3ad7b52de948151c067bc5ef2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611592
Reviewed-by: David Jacobo <[email protected]>
Auto-Submit: Cici Ruan <[email protected]>
Commit-Queue: Cici Ruan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158446}
[Omnibox] Null check underlying pointers for factory and action
These can be "created" while still having a null underlying value.
Bug: 1454029
Change-Id: Ib4b0252cdf76d32386c4358c35e57cdb11f6c5ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618731
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158445}
[omnibox][ml] Create test harness for ML scoring in AC Controller.
This CL creates an autocomplete_controller_unittest.cc file and sets
up the necessary test classes to test the ML scoring changes in
AutocompleteController.*. This does not yet include any actual tests
or functional changes.
Bug: 1405555
Change-Id: I325368049a0a59a1a83a60da0d15b4216aebd8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4453966
Code-Coverage: Findit <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Angela Yoeurng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158444}
Emit per frame missed vsync counts histogram
Currently the missed vsyncs histogram is emitted every 64 frames.
Emit the histogram for each frame as well, since it helps
differentiating the cases where 5 missed vsyncs mean one frame which
was delayed by 5 vsyncs or 5 different frames which were delayed by
1 vsync each.
Bug: b/286360387
Change-Id: Idee7193b1a10c0dd60c74646d273f32afdf19fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607285
Commit-Queue: Kartar Singh <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158443}
Bookmarks++: Select input text on rename
Bug: 1454026
Change-Id: Idf1550170e46047d5689c570205517b5a12aae48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616654
Commit-Queue: John Lee <[email protected]>
Reviewed-by: John Lee <[email protected]>
Auto-Submit: Emily Shack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158442}
Mark fenced-frame.tentative as failing
Bug: 1451954
Change-Id: I35b8509e15570dd63630cc7d7ecc3226f5dfb812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619067
Commit-Queue: Joey Arhar <[email protected]>
Owners-Override: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158441}
Integrate ScalableIph
- Start a ScalableIph service for a profile at a login time to start a
timer for time tick event.
- ScalableIph service is behind an ash feature flag.
Bug: b:284053005,b:286918522
Test: browser_tests --gtest_filter=*ScalableIph*
Change-Id: I90e142ef49f652785c1de2d2df1870f4e51d9720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610721
Quick-Run: Yuki Awano <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158440}
DeskButton: Make button responsive to shelf overflow
This CL makes the desk button responsive to shelf overflow. Previously,
when the shelf was horizontal we would just force it to stay in expanded
state no matter what. This CL changes this behavior by adding a
condition where if the shelf will overflow in horizontal alignment with
the button in the expanded state, then we shrink the button, and vice
versa. It also adds and updates some tests to account for the changes.
Bug: b/272383056
Change-Id: I4ef107aa5b702a542ae7ec7818e945f568c8b92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606119
Reviewed-by: Yongshun Liu <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Ben Becker <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158439}
Roll Skia from 794b6f9240a8 to abfa3505db23 (7 revisions)
https://skia.googlesource.com/skia.git/+log/794b6f9240a8..abfa3505db23
2023-06-15 [email protected] Harden quadratic solver
2023-06-15 [email protected] [graphite] New tiled image draw API
2023-06-15 [email protected] Add extra specification for some enums
2023-06-15 [email protected] [graphite] Temporarily disable draw pass commands in Vulkan to get dm running
2023-06-15 [email protected] [graphite] Fix dawn typo
2023-06-15 [email protected] Roll vulkan-deps from 4f33c22decdf to 6f8e5c2f4684 (3 revisions)
2023-06-15 [email protected] Minor refactoring of the Device drawImage code path
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I59fa02aa5837289c9790655958f1dfcbe0ceac17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618771
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158438}
Revert "Create a skylab fyi tester"
This reverts commit 6441be28ab468adc925d461bdae1f31b2bb2e900.
Reason for revert: This tester was only created to verify the builder
tester split and is no longer needed
Original change's description:
> Create a skylab fyi tester
>
> To test the builder/tester split change made here:
> https://crrev.com/c/4583642
> This will be rolled back after verifying the change
>
> Bug: 1453448
> Change-Id: If39b723534ab79fd0b162a865088503a8601e87c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595757
> Reviewed-by: Garrett Beaty <[email protected]>
> Commit-Queue: Struan Shrimpton <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157099}
Bug: 1453448
Change-Id: I3ac45a8f4ac6bce51e5bf675e2d202d4fd3c97c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617980
Commit-Queue: Struan Shrimpton <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158437}
DnD: Add support for tab tearing to a new window using drag and drop
The feature is behind a TAB_DRAG_DROP_ANDROID feature flag which is set to false by default.
Pipe the multi instance manager and toolbar_container view from the ChromeTabbedActivity to the TabDragSource.
Add method to MultiInstanceManagerApi31 to launch a new Chrome window and reparent the selected tab to it when it is dropped outside the strip layout area within the toolbar container view.
Low-Coverage-Reason: The code is only executed in environments not in the CQ. Integration test over MultiInstanceManager31 aren't counted.
Bug: 276804039
Change-Id: I53a9c9490c176cc340eaf7383cf0bb581dff0fce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596528
Reviewed-by: Yusuke Sato <[email protected]>
Commit-Queue: Gurmeet Kalra <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158436}
Add SafeBrowsingProxiedRealTimeChecksAllowed enterprise policy
Changes in this CL:
- There is a new enterprise policy that can disable hash-prefix real-
time lookups.
- There is a new pref kHashPrefixRealTimeChecksAllowedByPolicy which is
solely controlled by the new policy.
- The OhttpKeyService listens to changes in the pref to determine
whether to disable the service. There is a small associated refactor
for this to have HashRealTimeUtils maintain the list of prefs that
affect whether the lookups are enabled rather than OhttpKeyService.
The goal is to make it less likely for the prefs to get out of sync.
- Actual lookups do not listen to changes in the pref. They re-pull the
pref value on every navigation.
- Network annotations for the lookup and for key fetching are updated
to reflect the new policy.
Bug: 1441654
Change-Id: I6587238fcc0f05fd10e16689ec58c4de16b29922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606992
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: thefrog <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158435}
Scalable Notifiers: add Help App experiment feature flag
This flag will be used in addition to the global 'scalable-iph' feature
flag to gate the 'Welcome Tips' page experiment in the Help App.
Bug: b/287354989
Change-Id: I69da78a95db26a832fc13613c11b14e3f4e3a22c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615357
Reviewed-by: Yuki Awano <[email protected]>
Commit-Queue: Angela Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158434}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686840704-88174d0c936a2fb98cfb0651a76ecec235f7c8e7.profdata to chrome-win64-main-1686851973-8c3b38099cb6a4ee5f0d36790f3e9955b088f3ba.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8c5ed14f79c45c40be24e0709418f50ed385e677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614224
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158433}
win: Cleanup desktop icon in UpdateProfileIconOnAvatarLoaded
ProfileShortcutManagerBrowserTest.UpdateProfileIconOnAvatarLoaded leaves
a new shortcut on Windows desktop every time it runs. This CL uses
ScopedPathOverride(base::DIR_USER_DESKTOP) to create the shortcut
in a temp dir instead.
Bug: 1454297
Change-Id: I585baaa3ad540908dcef8727f06666bc32aa3d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611265
Commit-Queue: David Bienvenu <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158432}
Retrying ignore open tabs for DIPS deletion.
Previous attempt was reverted because the passed BrowserContext* is unsafe since the data might not outlive the call. (Also using Profile/UserData off of the UI thread is generally not allowed.)
Instead, we can use our existing integration with WebContentsObserver to manage a list of globally open tabs. (DIPSStorage is already tied to the profile so checking for same profile is unnecessary.)
Bug: 1429363
Fixed: 1429363
Change-Id: Ifb2ece35e39f57be45d75f3d88caef4045b54ae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606613
Commit-Queue: Anton Maliev <[email protected]>
Reviewed-by: Joshua Hood <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158431}
Roll ios_internal from f889903ef17f to 4172711d5992
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/f889903ef17f..4172711d5992
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ic4448aa7fe066b9557bb52ccc985c008b846c0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618096
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158430}
[CR2023] Fix BrowserNonClientFrameViewBrowserTest.IncognitoIsCorrectColor
The frame color changes in CR2023 and causes this test to fail because
it was expecting an hardcoded color. Fix it by expecting a black-ish
frame color instead.
Bug: 1455104
Change-Id: I3cf2a5f2a2f31b7ee71de20bc21c4bee8da2507f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617539
Code-Coverage: Findit <[email protected]>
Auto-Submit: Keren Zhu <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Commit-Queue: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158429}
[23Q2Fixit] Deflake TabSwitcherTabletTest#testEnterAndExitTabSwitcher
Deflake TabSwitcherTabletTest#testEnterAndExitTabSwitcher.
-Suspect either the delegate doesn't get set in the first place (e.g.
the layout#onStartedShowing event doesn't trigger the setup) OR the
delegate field gets set back to null. Either way, prospective fix is to
regrab, and hopefully this fixes OR gives a more informative failure.
Bug: 1454934
Change-Id: I50b7e37ae30cd0aaf7c05118fc3b8bb2d631ddd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616019
Reviewed-by: Zhe Li <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158428}
Include Demo Mode dimensions in registration requests
As detailed in go/upload-dm-dimensions, we want to include this data in
both initial registration requests and subsequent status reports for
Demo Mode devices. Including the info in status reports will be
implemented in a follow up CL.
Bug: b/281748020
Test: unit tests, verify via logging that request proto contains demo
dimensions
Change-Id: Ieffb0fbcea80745f72ea3c461a262be17eb877e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562482
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Jackson Tadie <[email protected]>
Reviewed-by: Yves Arrouye <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158427}
Added pixeltest for the qs slider
Bug: b/260737180
Change-Id: I160a76e43083cdf0e1297ea240bc1aee857bcfc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616953
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Sylvie Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158426}
print-management: add localize string for button
- Add localize string for manage printer button in header.
- Add TODOs for finalizing strings.
- Test to ensure button text matches translation.
Screenshot: http://screen/37AvE8a4RfYkteY.png
Bug: b:283119650
Test: browser_tests --gtest_filter=*PrintManagement*
Change-Id: I15e455e56b6bf8357853079632968bea4096ee01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615636
Reviewed-by: Gavin Williams <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158425}
[Tab Strip Redesign] fix NTB icon not aligned correctly
- fix NTB icon not aligned correctly in TSR disabled, introduced by CL[1].
[1]:https://chromium-review.googlesource.com/c/chromium/src/+/4614456
after screenshot: https://drive.google.com/file/d/15DITH3HpPhzB9j1dn4PNqPZNbbLAbQuO/view?usp=sharing
Bug: 1455009
Change-Id: I24292b7542eb9d55ac391b4f53161c56b3cd043a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618190
Commit-Queue: Zhe Li <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Neil Coronado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158424}
[CR2023] Fix ManagedUiTest.GetManagedUiIconEnterprise
Bug: 1455112
Change-Id: Id76e48a8c3839bb3cc2e9b2e261951b9488a1179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617791
Code-Coverage: Findit <[email protected]>
Auto-Submit: Keren Zhu <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158423}
[webengine] Remove use of old IPC used to check for key system support
As webengine is deprecated, simply removing the reference to the old
IPC so that the old IPC can be removed. If this code is revived,
changes will need to be made to use the KeySystemSupport mojo
interface that replaces this function.
Bug: 853336
Change-Id: Ia4f2927e9ad7a6ab3c154534ede0db83ae899270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616404
Reviewed-by: Rayan Kanso <[email protected]>
Commit-Queue: John Rummell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158422}
File creation refactoring
Avoid storing file backed blobs into BlobData just to be later extracted. With this change we directly work with DataElementFiles since
soon file backed blobs will be registered through FileBackedBlobFactory::Register (see https://crrev.com/c/4249117).
Change-Id: I537b85100aba24eb9a28c6be82fad1d893374365
Bug: b/286186684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582951
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: Daniel Brinkers <[email protected]>
Commit-Queue: Luca Accorsi <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158421}
Roll src/third_party/cros_system_api/ 78b08f5da..ea8d35b6f (2 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/78b08f5dae6a..ea8d35b6f676
$ git log 78b08f5da..ea8d35b6f --date=short --no-merges --format='%ad %ae %s'
2023-06-09 chenghan system_api: Add feature level to rmad proto
2023-05-12 michamazur system_api: add 3gpp interface and SetCarrierLock API
Created with:
roll-dep src/third_party/cros_system_api
Change-Id: I2f78b053556e2d519c45f57aece7464266fc832c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615736
Commit-Queue: Camden Bickel <[email protected]>
Reviewed-by: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158420}
Roll clank/internal/apps from 2809a9db872f to 31c5c5a39bf9 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/2809a9db872f..31c5c5a39bf9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1431581,chromium:1454680
Tbr: [email protected]
No-Try: true
Change-Id: I48352720a584c83f32104e2bec2b00b2aa83c71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618480
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158419}
Add top paint web test flake failure expectation for mac13-arm64
Bug: 1451329
Change-Id: I4d315c08e8b28a103c0ed8cb5a392776d3e47bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618416
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Vivian Zhi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158418}
[PWA] Fix PWA mobile model metadata processing issues
Add a check for input_context to prevent crash when input_context is null after reaching custom input processor.
Enforce input context based custom input features to be float only.
Bug: b/278782487
Change-Id: Ia75a9a562a8fb3c3821156c076df373f0d260a4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611100
Reviewed-by: Ella Ge <[email protected]>
Commit-Queue: Hailey Wang <[email protected]>
Reviewed-by: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158417}
[Auto-disable Accessibility] Add AccessibilityManager instance to AccessibilityState
This CL continues the work to consolidate all accessibility logic in
Clank to a single source of truth.
With this CL we update the AccessibilityState to include a static member
variable for the AccessibilityManager. With each update to the services
we update the instance in case the Context has changed. The manager is
needed for clients to send AccessibilityEvents without needed to keep a
hard dependency on the AccessibilityManager, or having a reference to a
View.
AX-Relnotes: N/A
Low-Coverage-Reason: Added a pass-through method to a system service. This would not realistically catch bugs.
Bug: 1430202, b/265493191
Change-Id: Ib1ba25b545e3ea1688005b761c2fcd8357fccc30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614407
Reviewed-by: Amanda Lin Dietz <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Mark Schillaci <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158416}
Fixed `GetAppStates` Windows, enabled the corresponding integration test
* Fixed incorrect refcounting during creation and release of the
safearray.
* Release safearray right after acquiring the `LockScope`, so that
the ownership is released in all cases.
* Fixed Typelib not loading for `IUpdaterAppState` because the
corresponding interface was not indexed.
Fixed: 1454979,1453109
Change-Id: Id2107ff3d758b7c785e446eba24429b1a5d8a5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617677
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Auto-Submit: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158415}
[ios] Get correct last Magic Stack module index in currentlyShownModule
The count of an array is one greater than the last index of the array.
Fixed: 1455130
Change-Id: I817f4b607df4a30a5e2ba429e3bd9d5b85bd910f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616842
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Scott Yoder <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158414}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686840704-779696f48b43141d8e12fa7352500e38d63a4665.profdata to chrome-win32-main-1686851973-f2c09176a18265d230448c21150e0d939c536b92.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I899e35e63da43dfcbdd25d43d32ea13f4c5cf5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614222
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158413}
Update celab binary
Bug: b:280445041
Change-Id: I9d62c73c6fc2dd628b9eb235d7ac34ec3b7ef2fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615726
Commit-Queue: Arthur Wang <[email protected]>
Reviewed-by: Xiang Ji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158412}
shortcuts: Add kRestoreSuccessWithConflict
This error state occurs when restoring an action cannot
be fully complete dude to existing conflicts regarding the
default accelerators.
Bug: b/216049298
Test: ash_unittests
Change-Id: Id7dda70971d15b09490fae9f56248f11c3875c3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582739
Reviewed-by: David Padlipsky <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158411}
Do not remove wpt report on windows
Remove is causing problem on windows side. Do not do
that now.
Bug: 1455010
Change-Id: I0e24cf26deedc4884e1d25dbb7af7c2e0d6d22a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615729
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158410}
Set cc::RasterCapabilities in a single place
Set all of the raster capabilities in one function. This will make it
easier to update in the future for jellymander.
Bug: 1442970
Change-Id: Ia75e3b106632a5d85210baac34528eb675debfa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615631
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158409}
Roll clank/internal/apps from 28809e9de9e0 to 2809a9db872f (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/28809e9de9e0..2809a9db872f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
No-Try: true
Change-Id: I4f4b30aacfe264bc184a8158e3e20ffe0a4c01be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618097
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158408}
[DTC-BYOD] Mark new policies as supported
Bug: b/279840937
Change-Id: I415b23f01f8155a86014ed26e3182b61f3f10e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617715
Reviewed-by: Sébastien Lalancette <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Commit-Queue: Hamda Mare <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158407}
arc: Add ArcSdkVersionUpgradeType enum
Added P_TO_T enum value to ArcSdkVersionUpgradeType to correspond
with platform2/arc/setup in crrev.com/c/4575507.
Bug: None
Change-Id: Iea1be3d17f5c53ff9dbeb258971a77f60cf9c8ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574616
Reviewed-by: Satoshi Niwa <[email protected]>
Commit-Queue: Josh Horwich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158406}
Tidy-up color buffer handling for default offscreen framebuffer
The only reachable code was just creating texture and attaching it to
fbo. This CL cleanup the rest.
Follow-up will stop creating fbo completely, but that requires feature
flag for safety.
Bug: 1445523
Change-Id: Ic8adaee90d6e904ea8f0ee945be5a2080b02e518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616405
Reviewed-by: Geoff Lang <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158405}
[Fixit] Disable portrait orientation tests for automotive
Automotive devices currently do not handle Activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT) properly: https://hsv.googleplex.com/5435081880502272
Bug: b/287350212
Change-Id: Id5914b8bc5b20e7ec315b23ae5f6ca020ea069d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617333
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Geoff Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158404}
[Fixit] Check status bar color as black on automotive
Toolbar color is constantly black on automotive. Changing the test's
expected color fix the issue.
Bug: 1454885, b/285208454
Change-Id: I86be44a993e8f1517750907f17d88e409c6552ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617330
Reviewed-by: Kevin Grosu <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158403}
Make the rollover test deterministic
This adds newrolloverroot in a separate trust store, so we
ensure that the path builder will always return the paths
in the order the trust stores were added.
Bug: 1322914
Change-Id: Ibb1c8158e07cf8d6b45656d8bdbc2e3e6e295830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610474
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Auto-Submit: Bob Beck <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158402}
VirtualDesk: Add quick animation type.
Add new quick animation for desk switch animation triggered by non
touchpad/shortcut sources.
New quick animation only move the desk 25% of the root width when switching desks with a shorter duration, and fade effect is applied
to ending desk.
This will be triggered by any non touch pad/keyboard shortcut desk
switches.
Test: Manual and Ash unit texts.
Change-Id: I1313ae03e99c1f3ff4e6a50b67b8e84ea89a83a5
Fixed: b/286134697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610658
Reviewed-by: Sammie Quon <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Judy Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158401}
Improve logging for AImageReader
Recently we see some devices have unexpected behaviour regarding
getting buffers out of the AImageReader. This CL covers all error paths
with logs, so we can be sure what code paths are taken.
Change-Id: Idd9f336f85db7172f4ff7d5195ed7bd4d18b38ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615543
Reviewed-by: vikas soni <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158400}
cellular: Conditionally log the activation code value
This change updates the log statements when installing eSIM profiles via
policy to only log the activation code value when we failed to install
the eSIM profile. However, even when logging the value, we use a regular
expression so strip the optional matching ID.
Bug: N/A
Test: Manually verified on device.
Change-Id: If71c0ca1492f0a86193f7de3fa84aa5f1fe930a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602537
Commit-Queue: Chad Duffin <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158399}
Update V8 to version 11.6.170.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/876556b9..8b1af31e
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I57f565e647d88e9aabdb16c8c8930a3382df90cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616232
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158398}
[omnibox][search_engines] Remove more aggressive custom search engines
suggestions experimental code.
An experiment was ran in 2016 to make the Omnibox provide more
aggressive custom search engines suggestions (e.g. `amazon` would be
accepted as the keyword for a custom search engine with keyword
`amazon.com`).
This code has been untouched for several years and it's unlikely at
this point that it'll be launched. This CL removes the experimental
code associated with these changes.
Original CL here: https://codereview.chromium.org/1411543011
Bug: 652847
Change-Id: I56a97c55c900eaa9e94c3f84c2eeabb00074c943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585742
Reviewed-by: Mark Pearson <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Angela Yoeurng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158397}
Add cross-origin iframe autoplay test
This CL adds a cross-origin iframe autoplay browser test.
Bug: 1444429
Change-Id: I73093270b326c87593bff811afce6972ca671afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615562
Commit-Queue: Evan Liu <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158396}
[iOS] Added a capability to inject CWVUserScript into all frames.
This CL is making CWVUserScript API consistent with WKUserScript API by adding an extra parameter which allows the injection of user scripts into all frames.
Bug: 1450737
Change-Id: Iad51cd1f3b800785ee947d164989b1b99f079147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582892
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Anton Ostrovskii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158395}
Add more androidx/media3 libs for readaloud.
The new libraries:
media3-datasource, media3-exoplayer, media3-extractor, media3-session
were added based on the dependency error (see the crbug linked);
media3-database and media3-decoder seem to be transitive dependencies
also needed (got errors complaining about them missing when running
third_party/androidx/fetch_all_androidx.py but they are also listed
as new deps when checking for new deps:
https://paste.googleplex.com/5358962525339648)
Bug: 1454594
Bug: b/284354021
Change-Id: I231bfb60247124053a817d11ee95355bd6a7716d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616793
Commit-Queue: Basia Zimirska <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158394}
Update scroll jank related histograms
This CL does following:
- Rename 'Jank' to 'ScrollJank' in scroll jank related histograms
to make them more understandable. The older histogram is not removed as
we would like to see the data coming from stable for the histogram.
- Make them 'patterened' histograms, since we would like to emit
histograms at different triggers as well other than fixed window sizes
as we were doing earlier.
All different histograms added:
Event.ScrollJank.DelayedFramesPercentage.FixedWindow - Percentage of
delayed frames in a window of size 64.
Event.ScrollJank.DelayedFramesPercentage.PerScroll - Percentage of
delayed frames in a scroll.
Event.ScrollJank.MissedVsyncsMax.FixedWindow - Maximum no. of missed
vsyncs in a window of size 64.
Event.ScrollJank.MissedVsyncsMax.PerScroll - Maximum no. of missed
vsyncs in a scroll.
Event.ScrollJank.MissedVsyncsSum.FixedWindow - Sum of missed vsyncs in a
window of size 64.
Event.ScrollJank.MissedVsyncsSum.PerScroll - Sum of missed vsyncs in a
scroll.
As of now we just emit
Event.ScrollJank.DelayedFramesPercentage.FixedWindow and
Event.ScrollJank.MissedVsyncsSum.FixedWindow, support to emit rest of
histograms will be added in followup changes.
Change-Id: Id0be5503f6b28608794d5a252c535a17157e17ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604504
Commit-Queue: Kartar Singh <[email protected]>
Reviewed-by: Mikhail Khokhlov <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158393}
Reland "personalization: extend two-tone background"
This reverts commit 2f53e24973171e35b5df0dfd20b638f6db24fedc.
Reason for revert: Fixed bug with breadcrumb
I scrolled all the way down and there's no gap in the wallpaper:
https://screenshot.googleplex.com/6fKrRYPgLEuSShq.
Original change's description:
> Revert "personalization: extend two-tone background"
>
> This reverts commit 88acc15dd8376fb72e4f0a159eb64b747d9411b1.
>
> Reason for revert: http://shortn/_6z555qKxyU
>
> Original change's description:
> > personalization: extend two-tone background
> >
> > The content background color should extend to the bottom of the page.
> >
> > before: https://screenshot.googleplex.com/97MhQyhysNcf8iK.png
> > after: https://screenshot.googleplex.com/9jfRRmAySoZLwPB.png
> > mock: https://docs.google.com/presentation/d/1sCxNbUVFwRf-4YYOhcUcmcc0mHpwysmHrO9qNoglDwQ/edit#slide=id.g13d12115f9e_0_250
> >
> > BUG=b:286519658
> > TEST=manual
> >
> > Change-Id: I71a0a1e8c4b343d101c3a7eecd3bfdaea6eeae3c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605994
> > Commit-Queue: Erica Lee <[email protected]>
> > Reviewed-by: Jerry Liu <[email protected]>
> > Reviewed-by: Jason Thai <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1155755}
>
> BUG=b:286519658
>
> Change-Id: I691749a1d3971f982c06d8a08e77e828294d55da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609245
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Jason Thai <[email protected]>
> Auto-Submit: Jason Thai <[email protected]>
> Commit-Queue: Jerry Liu <[email protected]>
> Reviewed-by: Jerry Liu <[email protected]>
> Quick-Run: Jason Thai <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156612}
BUG=b:286519658
Change-Id: Id5a65689feb24c69fe51d0b935fa7eb8dc0921a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609098
Commit-Queue: Erica Lee <[email protected]>
Reviewed-by: Jerry Liu <[email protected]>
Reviewed-by: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158392}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686830367-c711b23dff9239e0dc8c703545cf0c43e7be62cc.profdata to chrome-linux-main-1686851973-6e9f8a281a96374b2bdf985258af96ca60ab3947.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I39b8e96a326ce9f9b521d93039e477a9fbf3cbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617245
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158391}
Roll Catapult from 89fad9023d62 to 48e6e7d96bf4 (5 revisions)
https://chromium.googlesource.com/catapult.git/+log/89fad9023d62..48e6e7d96bf4
2023-06-15 [email protected] Roll perf dashboard default 7f835d2..c684fe0
2023-06-15 [email protected] Roll perf dashboard upload 7b96e7a..c684fe0
2023-06-15 [email protected] Roll perf dashboard api 7b96e7a..c684fe0
2023-06-15 [email protected] Roll perf dashboard pinpoint d1087f3..c684fe0
2023-06-15 [email protected] Roll perf dashboard upload-processing 7f835d2..c684fe0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: [email protected]
Change-Id: I968db01647c977081e002fa02815a9113a4c6886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617244
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158390}
[NP] Add changed/lost functionality in handler
Add functionality for nearby presence devices being changed and lost in
the nearby presence handler and the UI.
implementations so I tested this by manually calling the functions
with fake devices and observing the behavior on my DUT.
Test: ble_v2_medium currently does not have changed/lost
Change-Id: Ic0c52a51ee58788301f137d1eb165cf776e4feca
Bug: b/277820435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598594
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: Juliet Lévesque <[email protected]>
Commit-Queue: Alex Kingsborough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158389}
[CSC] Fix issue with IPH showing on NTP
The issue was caused because on a new tab open, there was no URL yet, so
SchemeIs would return false for empty URL.
This also fixes a minor issue with Super G sometimes flickering between
disabled and enabled state.
See: https://screencast.googleplex.com/cast/NTc0Mzk4MTI4MDM2MjQ5NnwxMmJjZGNiYy0yNg
Bug: b:286149244
Change-Id: I82aab0abbb22df020634b79d95a7aa09c526cd42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616949
Reviewed-by: Michael Crouse <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Commit-Queue: Duncan Mercer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158388}
Roll clank/internal/apps from bfef71460d47 to 28809e9de9e0 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/bfef71460d47..28809e9de9e0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1454911
Tbr: [email protected]
No-Try: true
Change-Id: I2518497eebeef790a9b20d3aa28ccf43ef298863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617246
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158387}
Add pixel tests for calendar view
Bus: b/285521476
Change-Id: I25a09c30c8c6368d94bcffb29b0a478cddc2fa81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617331
Commit-Queue: Jiaming Cheng <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158386}
Enable SharedBuffer mode rendering for Android OpenXR
Adds support for Creating and sending SharedImages on OpenXr on Android,
which then plugs into the existing infrastructure to properly send up
and later consume the needed mailbox holders, etc. to render to the
screen. Final rendering is done using the (former) ArRenderer, which
worked as-is to blit from the SharedImage texture to the texture
provided by OpenXR, so that class was renamed and moved to be easily
accessible by the OpenXrGraphicsBindingOpenGLES. This also required
specifying the appropriate required Swapchain format that matches with
the shared buffer type that we are creating. (Note that a lot of this
logic is basically the same as the logic done in XrImageTransportBase
and the corresponding subclasses, but cannot be used at present since
we use a SwapChainInfo struct and not the WebXrPresentationState and
WebXrSharedBuffer classes that that class uses. Future work will
investigate migrating onto those types).
A number of refactors were done to make the code cleaner and
hopefully easier to understand including:
* Moving some shared logic out of
`CompositorBase::SubmitFrameWithTextureHandle` so that the Android
path can use that for rendering as well.
* Moved a bunch of platform-specific logic into the respective graphics
bindings.
* Moved xr(Acquire/Release)SwapchainImages into the graphics bindings
to ease usage-patterns when setting up or consuming shared images.
* Moved logic from a couple of methods to live on the corresponding
class rather than being computed on top/outside of that class.
* A few minor renames (mainly SwapChainImages->SwapChainInfo in methods).
Most future intended cleanups have been tagged with bugs in the
appropriate places, but it's worth calling out that the code currently
uses SwapChain and Swapchain (and thus swap_chain and swapchain) fairly
interchangably. A future change will attempt to do a mass rename to
consolidate on Swapchain/swapchain (with no underscore), to align with
the OpenXr, `XrSwapchain` type/nomenclature.
Fixed: 1441073
Change-Id: Ie03e4a7cff900ca4a33161af79184d505cbbdfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605785
Commit-Queue: Alexander Cooper <[email protected]>
Reviewed-by: Kyle Charbonneau <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158385}
Add new threat source NATIVE_PVER5_REAL_TIME
This involves changes to the following:
- CSBRRs have a new url_api_type PVER5_NATIVE_REAL_TIME
- Hit reports have a new threat source URL parameter "n5rt"
- New SafeBrowsingMetricsCollector EventType
HASH_PREFIX_REAL_TIME_INTERSTITIAL_BYPASS. This affects existing
histograms SafeBrowsing.EsbDisabled.LastBypassEventType and
SafeBrowsing.Daily.BypassCountLast28Days.{UserState}.AllEvents.
- Add new histogram suffix to interstitial histograms such as
interstitial.phishing.decision.from_hash_prefix_real_time_check_v5.
Server-side CL for proto changes: cl/540359677.
Bug: 1441654
Change-Id: I5e59e78ef4f3ba08cb478ffb98a8a4a787a1f7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615748
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: thefrog <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158384}
Roll clank/internal/apps from efb94d9a2801 to bfef71460d47 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/efb94d9a2801..bfef71460d47
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1392478
Tbr: [email protected]
No-Try: true
Change-Id: I2ce758fe1b2e0badc4b5542b85199c6998960089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618479
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158383}
[ SavedTabGroups ] Merge save flags together
- Merges kTabGroupsSaveSyncIntegration into the kTabGroupsSave flag
- Renames kTabGroupsSaveSyncIntegration -> kTabGroupsSaveNudgeDelay
Change-Id: I0bf853c6667b24f46abf4db57bb6e6063c0a3c91
Bug: 1453689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605761
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Darryl James <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158382}
[REFACTOR] Rename get_desktop_directory to directory_helpers
Need this change for adding another directory helper method
"GetDownloadDirectory()".
Bug: b/284943640
Change-Id: I1bcecb060af1e8c499f8cbff30c2fbfa6648a80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614880
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Ashutosh Singhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158381}
Roll devtools-internal from 3ce4b25c0ad1 to 250b420bb8f5 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/3ce4b25c0ad1..250b420bb8f5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ic30984acc488191153c946b08b764e2c96c55e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614221
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158380}
Roll WebRTC from 45afbc1e8144 to ccc87ea3c625 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/45afbc1e8144..ccc87ea3c625
2023-06-15 [email protected] [Stats] Remove enum-like structs in favor of strings.
2023-06-15 [email protected] Reland "Merge the codec types"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Id5e7244e3186c11b50453d967fcb170742277527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617243
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158379}
[CrOS Hotspot] Remove the processing queue
This change removes the processing queue for hotspot enable/disable
requests and executes them as they come in. This is the first step in
supporting the abort enable operation.
Bug: b/284210829
Test: Ran hotspot unit tests, pending manual test
Change-Id: I25dc7b063e9f1a6bff94f30a1da304d7f77b67d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616051
Reviewed-by: Jason Zhang <[email protected]>
Commit-Queue: Nikhil Nayunigari <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158378}
Properly handling disabled structured metrics in service
In the situation where metrics collection is consented and structured metrics is disabled but structured metrics service is enabled that wasn't handled properly. After fixing a crash in https://chromium-review.googlesource.com/c/chromium/src/+/4585001 this wouldn't cause an issue. It would still use unnecessary recourses.
Bug: crbug.com/1434483
Change-Id: I45dc261df9c94264b780a96bc4013c3470e831d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610800
Reviewed-by: Tony Yeoman <[email protected]>
Commit-Queue: Andrew Bregger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158377}
[ios] Limit SetUpList item description text to 4 lines
Bug: 1427439
Change-Id: Ia4d4a6212f1749a4f7a9ee544b4b0d596405c94c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614901
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158376}
[Frameworks roll] Roll to 540643800 piper revision
Change-Id: Ia6057e3729eff8b53a1ceb7ccae82b10532860fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614999
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158375}
Sync dogfood status from OS priority preferences on ChromeOS ash
I have confirmed via manual testing that this works on all ChromeOS
combinations:
* On a non-Lacros system
* On a Lacros system, in ash-browser
* On a Lacros system, in lacros-browser
I have also added a clarifying comment explaining why we don't pass
low-anonymity field trials over the crosapi Mojo interface.
Bug: b/285846032
Change-Id: I62575771a7983b6d1e283e741646316d6682b5cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594476
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Auto-Submit: James Lee <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158374}
Roll Skia from b5c75b1f63d6 to 794b6f9240a8 (2 revisions)
https://skia.googlesource.com/skia.git/+log/b5c75b1f63d6..794b6f9240a8
2023-06-15 [email protected] [graphite] Remove SkImageGenerator::makeTextureImage
2023-06-15 [email protected] [skif] Fix morphology sksl to avoid switch fallthroughs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I83fef41b76042c54d0c663de5e05f351e8007f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617078
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158373}
[Android] Re-enable permissions tests
- GeolocationTest#testGeolocationPlumbingAllowedDialog
- GeolocationTest#testGeolocationPlumbingAllowedDialogNoGesture
- GeolocationTest#testGeolocationWatchDialog
- MediaTest#testCameraPermissionsPlumbingDialog
- MediaTest#testCombinedPermissionsPlumbingDialog
- MediaTest#testMicrophoneMediaPermissionsPlumbingDialog
- NotificationTest#testNotificationDialog
- RuntimePermissionTest#testAllowRuntimeCameraIncognito
- RuntimePermissionTest#testAllowRuntimeMicrophoneIncognito
Flakiness fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/4605840
and fixes confirmed on Reviver bots.
Bug: 1444083,1441822,1435426,1444217,1444241,1444222,1449975
Change-Id: I71bf5ad3e3e6d0a5441270e51c8b94155cdd939f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618809
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158372}
Add remaining planned staging flags for image filter refactor
Bug: skia:9282
Bug: b/263131619
Bug: b/263137789
Bug: b/263138786
Bug: b/263134496
Change-Id: I49498ecd42d4a3e336113c28310dc1d518e87782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615735
Auto-Submit: Michael Ludwig <[email protected]>
Commit-Queue: Robert Phillips <[email protected]>
Reviewed-by: Robert Phillips <[email protected]>
Commit-Queue: Michael Ludwig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158371}
Roll Dawn from 138d5b7b9f6f to 00c80004d043 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/138d5b7b9f6f..00c80004d043
2023-06-15 [email protected] Roll ANGLE from 5a5f21f4a2e2 to 3545ae0ca0b3 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I3c2a3556d5169addfc582528bb789af924511096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618768
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158370}
Don't depend on clang_rt.profile on Windows ARM64 yet
The clang package does not have it.
[email protected]
Bug: 1453618
Change-Id: I83b5dcf24176934d518e3e172541261c6d31ddaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618708
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158369}
Add wrapper to JDK 3pp script to set -XX:+PerfDisableSharedMem
This seems to be the only way to inject a default argument.
Bug: 1441023
Change-Id: Id059db16086ade423d4feb8bc215bb7094c18e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615626
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158368}
Enable Omnibox Inspire Me feature by default for 10 query trends.
This change dark-launches this Inspire Me study arm:
http://shortn/_7aMbBShyHN
The parameter definitions are migrated to the header file to enable
re-use in about_flags.cc (and warrant eventual cleanup).
The change updates some affected tests *partially*
- AutocompleteResult tests disable the Grouping framework in ZPS:
our grouping rules explicitly disallow URLs in 0-prefix context,
but tests seem to verify that the old rules permitted that
- inspire me is to be fully integrated with the Android flow, so the
test verifying feature disabled behavior is stripped
- MostVisitedSites test both individual match -- and tile carousel,
but no platform actually relies on individual matches any more.
this should have been cleaned up, will handle this in a follow up
change.
- To avoid differentiating or disabling most visited sites provider
unittests for desktop, the controlling feature is marked as enabled
by default (because it literally applies only to IOS and Android).
- The MostVisitedSitesProvider test that specifically tested yielding
of individual matches is removed.
Bug: 1423135
Change-Id: If9793df11dc197b4c6f7615812bd57c7fda1c69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616670
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158367}
[Share] Remove unused methods and test for ShareImageFileUtils
#generateTemporaryUriFromStream is not used at all.
#saveBitmapToExternalStorage is only used in tests.
Bug: 1056059
Fixed: 1056059
Change-Id: If922c407d31814b6a1b7a1b7dfac22937da7a684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618750
Auto-Submit: Wenyu Fu <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Reviewed-by: Sophey Dong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158366}
[Read Anything] Add iph to field trial testing config
Bug: 1266555
Change-Id: Ibd748d7ee8ad301e3c4cbdd2a4523f0ad81793fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617784
Reviewed-by: Mark Schillaci <[email protected]>
Commit-Queue: Jocelyn Tran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158365}
Update benchmark owners/components.
Bug: 1455171
Change-Id: Ic385e3c9f943728f471064b977280c868263b8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617959
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Max Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158364}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686830367-797b9f9e508a178f2be37648ce76af1ca2ea905e.profdata to chrome-win64-main-1686840704-88174d0c936a2fb98cfb0651a76ecec235f7c8e7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8c0e450e053d394368a869c401d03ab2950cb9c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618494
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158363}
Add background blur to Welcome Tour scrim.
When help bubbles are shown, the Welcome Tour scrim applies a
background blur to provide additional emphasis to anchor views.
Demo: http://shortn/_xryM6S8F4o
Bug: b:277091650
Change-Id: Ia1cb38f5864aefa3929c1e90973ff40ceb2b53e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616448
Reviewed-by: Angus McLean <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158362}
[Journeys] Pass takeover_action to Java if it's the only action present
The Android Journeys row relies on an action to trigger, and the
takeover_action was not previously passed to Java. For now it's simple
and effective to pass the takeover_action as a regular action; in the
future we may want to make this its own field.
Bug: 1455172
Change-Id: I01b9c55d67351752ea0b530bae9f9ae4e5836b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618728
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158361}
Use operator bool in base/apple/owned_objc
It's more idiomatic than IsValid() and allows for cleanup by letting
all locations just do a bool test.
Bug: 1280317
Change-Id: Ied6af953d3d2609862063a8524812145a30162ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614447
Commit-Queue: Mark Mentovai <[email protected]>
Code-Coverage: Findit <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158360}
shimless: Add flag to enable compliance check functionality
Bug: b/287317464
Change-Id: I9367e71850594fd8c4de362ffa8573f15670f198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616888
Reviewed-by: Gavin Williams <[email protected]>
Commit-Queue: Camden Bickel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158359}
[ios] remove NOTREACHED that can be reached a lot on production.
The code path is probably not unexpected based on the crash rate of
thousands per day, which no window found a common cause. Likely related
to backgrounding and showing the repost alert view around the same time
but it's hard to reproduce locally.
Bug: 1428839
Change-Id: If9acc07ea906431ffc021aad692b4d5031f5bd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590729
Commit-Queue: Huiting Yu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158358}
capture_audio_mixing: Perform audio mixing of the worker sequence
Before this CL, all audio buses are received and mixed on the main
thread of the recording service. At the current sample rate, 100
audio buses are received per second per device being recorded.
This means when recording 2 devices (mic and system audio), we're
receiving 200 buses per second on the main thread. The main thread
is where the video frames are received, and also where the mojo
interactions between the service and ash happen.
This CL moves all the audio mixing operations to the already
existing worker thread pool sequence `encoding_task_runner_`,
and now the mixer can call the encoder directly without going
through the main thread anymore.
Fixed: b/286325436
Test: Manually, existing tests.
Change-Id: I012dce172aa8ce110add2b7b34848f068ff184a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606118
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158357}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5834.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I044a174afff964b9d69c9fb5cbf9decdbc8fac8d
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616231
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158356}
Reland "[PolicyLogs] Adding chrome://policy/logs on Desktop"
chrome://policy/logs is already available on Android and enabled by default. This CL brings chrome://policy/logs to desktop behind a feature flag that is enabled by default.
The CL also adds a reference to the sequence that created the logger to always post `AddLog()` to it if a different sequence adds a log. Some code paths previously tried to add a log from a different sequence, causing the DCHECKs to fail. This solution fixes the issue.
A POLICY_EXPORT is added for the LogHelper class to avoid dll linkage errors on Windows.
The ASAN Crash that caused the revert in crrev.com/c/4559846
was due to the last_dm_status_ being logged in "cloud_policy_client.cc" which has already been freed from the `NotifyClientError()` call.
Bug: b/282733597
Change-Id: Icb75e4cbb069eefea86958b65b3f957db295cdf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567744
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Commit-Queue: Salma Elmahallawy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158355}
Roll src-internal from a44a139a9575 to fe8274c0ba6d (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a44a139a9575..fe8274c0ba6d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I2d9f6f9289ca0a326f5a021491cfa07755f12012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617241
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158354}
[Lens]Add more entry points for Bling LVF for logging
Bug: 1353430
Change-Id: I6ed742d4077f5eb27ede4f1cbd3272cfe799f005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611590
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Juan Mojica <[email protected]>
Commit-Queue: Jason Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158353}
Updater: Adjust modecheck & overinstall logic.
This should help prevent cases where updaters that are too broken to
answer GetVersion but still working enough to run ModeCheck race against
a new install and take over as active.
Bug: 1369264
Change-Id: I39dcc1c6ce2266a6d22075faad7eac0377ddf48e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615181
Commit-Queue: Sorin Jianu <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Auto-Submit: Joshua Pawlicki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158352}
Add Screen Size Row to Menu
Creates a row for the screen size button whose functionality will be
implemented in a future CL.
Bug: b:275424971
Test: Ran GameDashboard* ash_unittests
Change-Id: I01470e1866d3fb0eef788aa831ba8d5394884131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571140
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Gina Domergue <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158351}
mojo: Clarify examples of interface versioning
Split the example of adding a new argument to a function from the
example of adding a new function to an interface. This makes the two
sub-sections of the docs more independent and IMHO more readable.
Bug: none
Change-Id: I462dd3c0defbd1b31b1ffa6097b2838ce299bf69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615737
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Oksana Zhuravlova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158350}
Fix test 2d.text.draw.baseline.ideographic.html
The ideographic baseline is defined as follows:
https://drafts.csswg.org/css-writing-modes-4/#line-under: the
line-relative “bottom” or descender side. (The side underlines are
typically drawn on.)
I attached result here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1066953#c14
(It's with font 50 and draw at height 50)
I think this test case is wrong: The test case draws text at ideographic
under baseline at height 31.25, so that text is draw above 31.25 and
leaves 31.25 to 50 to be at its original color (red for test). The test
tests if the resulting rect, rect(0, 0, 50, 100), to be all green.
I think the test needs to know the location of the green rectangle and
move it down. The test is updated.
Bug: 1066953
Change-Id: I2b9c029a439fd8a19343dc826b70b1bc1c95b60e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615191
Commit-Queue: Yi Xu <[email protected]>
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158349}
[CT] Pass Bundle#EMPTY to EngagementSignalsCallback methods instead of null
Bug: 1455157, b/287312027
Change-Id: I7dbf2d63c2c4b571461e334fdba2ebb13e179543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618707
Reviewed-by: Kevin Grosu <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158348}
[X-Device Restore] Add triggering logic and visibility for bottom sheet
This CL aims to add the triggering logic for the restore tabs on FRE promo bottom sheet. Also included in this CL is the feature engagement configuration for this feature's IPH criteria, as well as this feature's flag and respective param for testing purposes.
Bug: 1426921
Binary-Size: Adding entire new feature to binary at once.
Change-Id: Icc7cdcc7915cee2a98449336a0d0b01174b45542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569332
Reviewed-by: Tommy Nyquist <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Brandon Fong <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158347}
[parkable_image] Enable by default
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/4608920, enabling the last feature we need.
Change-Id: I6324cc3f15981f4f2e4200938bbf931c02e77e4d
Bug: 1142834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614290
Commit-Queue: Thiabaud Engelbrecht <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158346}
Roll earl_grey2 from caea08a21d6a to 4ba12ca32f11 (1 revision)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/caea08a21d6a..4ba12ca32f11
2023-06-15 [email protected] Test App Cleanup for black bar and launch screen
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8a99d71b10917f392a38e59bcc36afac5596134b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617237
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158345}
Add AV1, HEVC hardware decoding tests to GPU integration bots.
We have software tests for AV1, but no hardware ones and we don't
seem to have either hardware or software HEVC tests -- despite
support being added last year.
The AV1 tests should be able to run on all platforms, while the
HEVC ones can run everywhere except Linux and macOS < 11.
Bug: 1348104
Change-Id: I0431b30a20ea03aefeae0c16c392a31321f52916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605755
Reviewed-by: Dan Sanders <[email protected]>
Auto-Submit: Dale Curtis <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158344}
Roll ijar 5d173f18d -> fed23d5a0
Hoping this will fix ijar failure in bug
Bug: 1455158
Change-Id: I96cc55457ef4dc9bcc86dc36d75c395d5c662aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618747
Commit-Queue: Mohamed Heikal <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158343}
[gardener] Disable flaky ContextualSearchTriggerTest#testTapGesturesNearbyKeepSelecting
Bug: 1455161
Change-Id: I345b376875e81e71d1f254293c041516c9c171c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617676
Reviewed-by: Lijin Shen <[email protected]>
Commit-Queue: Kevin Grosu <[email protected]>
Owners-Override: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158342}
Roll Open Screen from 085a08030e24 to bfbfda8fd7e3 (1 revision)
https://chromium.googlesource.com/openscreen.git/+log/085a08030e24..bfbfda8fd7e3
2023-06-15 [email protected] [Open Screen] Move //discovery/mdns implementation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I06cbe3566ba0bb58fe264ba357a4f507e64e30fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617604
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158341}
[aw] Record memory metrics when clearing the WebView functor
In order to assess the impact of clearing the WebView functor on memory
usage, we need to have *some* metrics. Unfortunately, regular
memory-infra memory metrics are not collected for WebView.
This CL adds memory metrics for this use case. We use a flawed graphics
memory metric, that has nevertheless proven to show when an experiment
is moving metrics in the past, for Chromium browsers.
The metric is recorded in both arms of the experiment, to allow
comparisons.
Bug: 1424346
Change-Id: I8c911f5fdbdb35b6290240f5467673fbfaa37415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594801
Code-Coverage: Findit <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Auto-Submit: Benoit Lize <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158340}
Convert /ui/display:display_interactive_ui_tests to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
This ended up only adding the ARC boilerplate as a marker to indicate
that these files were audited.
Bug: 1280317
Change-Id: Ie24e0df4f1ee0bbc814e5873577197ad7d1ec243
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609326
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158339}
[Tailored Security] Always add a TabModel observer on init of retry
The tab observer based retry mechanism for Tailored Security previously
worked by adding a TabModelList observer and waiting for a TabModel to
be added. In practice, there is frequently already a TabModel added,
which means that this implementation was adding the TabModelList
observer but often never successfully adding a TabModel observer because
another TabModel would not always be added.
This change addresses the problem by changing the retry initialization
logic to try adding a TabModel observer on the initial pass.
We also improve removing of TabModel observers by always adding the
ChromeTailoredSecurityService as a TabModelList observer. This is an
improvement because when a TabModel is removed, the TabModelList will
iterate over all of the TabModelList observers and call
OnTabModelRemoved().
* Add a RegisterObserver method which tries to add a TabModel
observer before adding a TabModelListObserver.
* Update the ChromeTailoredSecurityService destructor to remove itself
from the TabModelList observers after removing itself from the
observers of the TabModel that it is observing.
* Change OnTabModelAdded() so that it:
* does nothing if the ChromeTailoredSecurityService is already
observing a TabModel
* no longer removes itself from being a TabModelList observer (since
if it is not a TabModelList observer, then it will miss running
OnTabModelRemoved for any tabs that are removed.
* Start removing ChromeTailoredSecurityService from the TabModel
observers of `observed_tab_model_`.
* Add RemoveTabModelListObserver and RemoveTabModelObserver methods so
that the remove logic is encapsulated in a single method.
* Update the ChromeTailoredSecurityService's unit test suite to
initialize some raw_ptr member variables to nullptr so that they are
explicitly not initialized.
Change-Id: I642437b6178dd75a1332a0d74c3c2b6f9a9e53cd
Bug: 1452180,1448897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609457
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Javier Castro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158338}
Remove an existing GPU channel before creating a new GPU channel
1. Establishing GPU channel with exsisting client_id is requested
from client. (it's a very unusual case.)
2. New GpuChannel is created.
3. New SharedStubImage is created.
4. New SyncPointClientState is created and trying to insert the state
into client_state_maps_[namespace_id] in SyncPointManager
and the key is command_buffer_id. However, fail to insert
because same key already exists on the map.
5. Existing GPU channel with same client id is deleted.
when gpu_channels_[client_id] = std::move(gpu_channel) is called.
6. SharedStubImage is deleted
7. SyncPointClientState::Destroy() and
SyncPointManager::DestroySyncPointClientState are called.
8. Existing SyncPointClientState in client_state_maps_ is deleted
because command_buffer_id which comes from client_id is
same with existing one.
SyncPointClientState is deleted when establishing GPU channel
and it will cause unexpected SyncPoint issues.
To fix this issue, we will remove an existing GPU channel
before creating a new GPU channel if client id of the existing
channel is same with that of new one.
Bug: 1454023
Change-Id: If62661aef62945e843c939e25b22e413021491fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607741
Reviewed-by: vikas soni <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158337}
[Android/AppIdentity]: Add metrics for the update process.
Adds a metric for how much the before and after images change
in the upgrade process.
Bug: TBD
Change-Id: Icafca9662cfa329a288fdd3d5ff06765dc9f98f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608828
Commit-Queue: Finnur Thorarinsson <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158336}
Increase QuerySet size metric
We are regularly seeing counts exceeding 1000 so we are increasing
the metric limit to 10000 to better capture the range.
Change-Id: I58f7092b09582eb160b75a036f7783257b319e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615870
Commit-Queue: Russ Hamilton <[email protected]>
Reviewed-by: Qingxin Wu <[email protected]>
Auto-Submit: Russ Hamilton <[email protected]>
Commit-Queue: Qingxin Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158335}
[sessions] Do not purge session data for foreign history deletions
This CL adds the Reason enum to history::DeletionInfo. Currently the
enum only supports kDeleteAllForeignVisits and kOther.
Foreign visits are visits that occurred on another device but were
synced to this device. More specifically they are visits with a
non-empty `originator_cache_guid`.
Foreign visits may be deleted from history in cases where history
sync was previously enabled but is now disabled. This cleanup can
occur at startup.
Ideally SessionService would remove only the entries that correspond
to these deleted foreign visit URLs. However currently there is no
easy way to remove specific URLs, instead all session service
persisted data is deleted.
This has the effect of Chrome deleting the user's previous session
data at startup, a cause of significant disruption. In this
specific case we should preserve the last session data to avoid user
data loss.
A follow up can wrap DeletionInfo::is_from_expiration_ into the
DeletionInfo::Reason enum.
Bug: 1424800, 1423163, 1454345
Change-Id: I9186583e909fbb414ed62f520b1e20f16e45f6fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610021
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158334}
Roll nearby-connections from 6f69e974216a to ebe02e117470 (20 revisions)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/6f69e974216a..ebe02e117470
2023-06-15 [email protected] Allow auto-resume the payload transfer when disconnection
> PiperOrigin-RevId: 540438831
>
2023-06-15 [email protected] Applied flags to Wi-Fi Hotspot parameters
> PiperOrigin-RevId: 540432082
>
2023-06-15 [email protected] Isolate ble_v2/wifi_lan on incoming connection logic
> PiperOrigin-RevId: 540420565
>
2023-06-14 [email protected] Remove redundant design of fast pair wrapper.
> PiperOrigin-RevId: 540410011
>
2023-06-14 [email protected] Isolate Ble accept handler logic
> PiperOrigin-RevId: 540401997
>
2023-06-14 [email protected] convert bluetooth connection handler to a front binder
> PiperOrigin-RevId: 540355517
>
2023-06-14 [email protected] Update Tachyon protos to allow Messaging APIs to be callable.
> PiperOrigin-RevId: 540336655
>
2023-06-14 [email protected] Fixed transfer sync issue in payload callback
> PiperOrigin-RevId: 540333269
>
2023-06-14 [email protected] Use alphanumeric characters for PresenceDevice endpoint id generation
> PiperOrigin-RevId: 540321021
>
2023-06-14 [email protected] Fixed crash when flag update in peripheral tracker
> PiperOrigin-RevId: 540294615
>
2023-06-14 [email protected] Fixed the deadlock issue in hotspot
> PiperOrigin-RevId: 540283852
>
2023-06-13 [email protected] Use RobustGattClient
> PiperOrigin-RevId: 540060033
>
2023-06-13 [email protected] Add screen locked listener for fast pair windows
> PiperOrigin-RevId: 540038338
>
2023-06-13 [email protected] Load the AccountManager in the WebRTC code.
> PiperOrigin-RevId: 540036925
>
2023-06-13 [email protected] Implement signing/verification of PresenceAuthenticationFrames
> PiperOrigin-RevId: 540029386
>
2023-06-13 [email protected] Connect UI related key services in mediator to flutter app. The whole fast pair libraries are in C++ language while flutter app is in dart language. That is, the purpose of adapter is connecting dart (flutter app) and c++ (Fast Pair libraries).
> PiperOrigin-RevId: 540013256
>
2023-06-13 [email protected] Add test case to verify Connection can fall back to BT if WIFI_LAN fails
> PiperOrigin-RevId: 539877670
>
2023-06-13 [email protected] Add robust gatt client
> PiperOrigin-RevId: 539817203
>
2023-06-13 [email protected] Update path to LDT dependency
> PiperOrigin-RevId: 539811031
>
2023-06-12 [email protected] Improve device lost handling
> Handle the error case when the platform calls device_lost_cb without calling device_discovered_cb first.
>
> PiperOrigin-RevId: 539791976
>
Test: manually verified Nearby, Phone Hub, and EXO are still WAI.
Change-Id: I53f84ac3508d51b6d789a5e26d38048c24d97fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617000
Reviewed-by: Pu Shi <[email protected]>
Commit-Queue: Crisrael Lucero <[email protected]>
Commit-Queue: Pu Shi <[email protected]>
Auto-Submit: Crisrael Lucero <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158333}
Roll WebRTC from 2fec64484f0c to 45afbc1e8144 (6 revisions)
https://webrtc.googlesource.com/src.git/+log/2fec64484f0c..45afbc1e8144
2023-06-15 [email protected] Allow setting a custom randomness source.
2023-06-15 [email protected] sdp: reject duplicate ssrcs in ssrc-groups
2023-06-15 [email protected] Flexfec: add logging of received length.
2023-06-15 [email protected] In VideoCaptureV4L2 use requested/configured capability
2023-06-15 [email protected] Add missing method definition for StatsReport::Value::id_val()
2023-06-15 [email protected] Roll chromium_revision 47e7a37749..570bae752f (1157983:1158090)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1454860
Tbr: [email protected]
Change-Id: I13dd479be18ea49ebcb22219e880a08bd7f22ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615280
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158332}
Update VS Code Java formatter instructions
Turns out that `git cl format` uses clang-format to format Java code,
and the current instructions using JDT would produce formatting that can
be quite different. Fix the instructions to make VS Code format Java
files in the exact same way `git cl format` does.
Change-Id: I7d0476bf9c2d84d2c9dfe3ca13be4811079d45b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614846
Reviewed-by: Chase Phillips <[email protected]>
Commit-Queue: Chase Phillips <[email protected]>
Auto-Submit: Etienne Dechamps <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158331}
Register SearchCompanion entry if it's not there
After tab is discarded and then restored (using Chrome's memory
optimizations), the companion entry is not present in the side panel
registry. This CL adds the companion entry to the registry so that
user can enable CSC on restored tabs.
Bug: b:287329056
Change-Id: Icc81f0d985a7b2b2ee9f50454cd7f0ec75f75997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618011
Reviewed-by: Caroline Rising <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158330}
[DIPS] Adds UKM metric for web authn assertions
This CL includes changes on the DIPS.Redirect event to also collect an
extra boolean metric on whether the user triggered a web authn
assertion.
This CL is set ahead from approval for review but will not be submitted until proper approval.
UKM change approval: https://docs.google.com/document/d/1ozTKwpqTt1a5jyF7uemjNDYkJpulXTov3tcPpN6-t7w/edit?resourcekey=0-IeXPRVgjzRbTIZG2RQEQrA#bookmark=id.t7299feo9h4s
Bug: 1446678
Change-Id: Id1846b93555cff311d91253e6f7fbd498645ac7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599228
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Commit-Queue: Jonathan Njeunje <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158329}
Fix flaky test TabbedAppMenuTest#testRequestDesktopSiteMenuItem
testRequestDesktopSiteMenuItem & testRequestDesktopSiteMenuItem_checkbox
uses NavigationController#setUseDesktopUserAgent to change the tab's RDS
state. But the RDS setting (global or domain-level or tab-level) does
not change. Thus the tab is in an intermediate state where its tab state
does not match the RDS setting.
And the test may result in ChromeActivity.onWindowFocusChanged, which
will (re)load the tab based on the RDS settings. To avoid this
unexpected tab state change, update RDS settings instead of modifying
tab state directly.
Bug: 1435223
Change-Id: I8e250e172fef9bbc21c0081ecc3da06da1f387b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616634
Commit-Queue: Shu Yang <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158328}
Use CHECK instead of DCHECK for insertion failure.
New SyncPointClientState is cretead before destroying the previous one.
Insertion of |client_state| into |client_state_maps_| fails,
because equivalent key (command_buffer_id) already exists in map.
In case of insertion failure, CHECK will break synchronization in subtle
manner.
Bug: 1334982
Change-Id: I86c685782b9937bf80fbdec36d955fd458696d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617810
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Shubham Gupta <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158327}
Fix missing new method type
Change-Id: Id7f1c22562f5ec3875bdad4119be828a0746688b
Bug: b/284648407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616947
Commit-Queue: Serena Pascual <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Michael Crouse <[email protected]>
Quick-Run: Anudeep Palanki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158326}
Stop some WebApp tests from pinning to the taskbar
Use OsIntegrationTestOverrideImpl to stop WebAppOfflineTests from
pinning icons to the taskbar and leaving shortcuts on the Windows
desktop.
Bug: 1454110
Change-Id: Ied9ea638b2eb6f8b3d8528b9d958b585d068e662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618387
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158325}
[Chrome Refresh] Add Page Action Icons and reference them in code
Bug: 1399991
Change-Id: I2bb3b782a1a0e634ec0f9b5091e02d74aa862f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617829
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Shibalik Mohapatra <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158324}
Refactor TestCupsPrintersManager
Extend the mock class TestCupsPrintersManager. Replace other mock
classes for CupsPrintersManager with TestCupsPrintersManager.
BUG=none
TEST=unit_tests --gtest_filter=*Print*
Change-Id: I090b8cb3d58f919d07da5a99910654eaf08931f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610685
Auto-Submit: Piotr Pawliczek <[email protected]>
Reviewed-by: Roland Bock <[email protected]>
Reviewed-by: Gavin Williams <[email protected]>
Reviewed-by: Benjamin Gordon <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158323}
[CR2023] Fix PromotionalTabsEnabledPolicyWhatsNewInvalidTest
What's New page for CR2023 is not based on milestones, meaning that when
a user is updated to the launch milestones, they might not yet see the
refreshed UI. Fix PromotionalTabsEnabledPolicyWhatsNewInvalidTest that
expects the What's New page be displayed based on milestones.
Bug: 1455105
Change-Id: I64002d63b0802e72bd936410d5842983a4f0cb6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617692
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158322}
[ios] Enable unittests from /media/gpu/mac
This CL enables VTConfigUtil, VideoToolboxDecompressionInterfaceTest and
VP9SuperFrameBitstreamFilterTest for ios-blink platform.
Bug: 1439606
Change-Id: I82635236279777ba0a79afee0eed665cae5da5c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604336
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Abhijeet Kandalkar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158321}
desk-api: Add back desk removal events which was removed by mistake.
TEST=Tested in emulator. Unit test will be added in following CL.
BUG=b:287382267
Change-Id: Id78bdad8a8ab0a536073cb6f5700a542ec4d60af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616400
Commit-Queue: April Zhou <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158320}
[Sharesheet] Enable share sheet migration by default
Bug: 1410201
Change-Id: Ie713060e1a9de9521712a62471a15a657dd295f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617062
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Auto-Submit: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158319}
[ios] Update SetUpList and Feed headers
This change does the following:
* changes the two headers to use a medium weight font, but still use
the dynamic type font sizing
* fixes the SetUpList title so that it doesn't overlap the menu button
when very large font sizes are used
* sets the SetUpList icon tintAdjustmentMode so that the icons don't
change color when the menu is displayed
Previously, the Feed Header used a fixed-size medium weight font. When
it was switched to use a dynamic type font to match the Set Up List
header, the font-weight was lighter than medium. This change allows
both dynamic type sizing and medium-weight.
Fixed: 1453372, 1454214
Change-Id: I5750d9aedb1d1f1b92c7e6fc5bf7400f172bd411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614899
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158318}
[ios] Extend Messages Histograms
Fixed: 1454138, 1454140, 1454139
Change-Id: If291c97900a5529822fb6411c64d0487091fa525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617047
Reviewed-by: Luc Nguyen <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158317}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686837510-ddeaeaaabd0e3bbecb293a97837a64bc1cb76663.profdata to chrome-mac-arm-main-1686844703-cf1682aa66cc43bcf70090915a935dc9fbb31e6d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If4942d945dd9be720601cf5282c477ad3f5d4c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618588
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158316}
[ios] Magic Stack Module Title Resists Vertical Expansion
This change ensures that the title row (and the separator if shown)
resists expanding vertically to fill any extra module space. Instead,
the content view will be the one expanding. This requires any StackView
within the contents to have vertical constraint flexibility. For
MultiRowContainerView, this means having that flexibility from the
bottom for best visual effects.
Screenshot: https://drive.google.com/file/d/1Y3-ILcfAjK5Vl6eUu3d1VqxMQ6wI8nn7/view?usp=sharing
Bug: 1432252
Change-Id: I6179236e6933ff335c8511d34c597fabbcf793ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617007
Reviewed-by: Scott Yoder <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158315}
Roll Skia from cc7c05a3bfcc to b5c75b1f63d6 (2 revisions)
https://skia.googlesource.com/skia.git/+log/cc7c05a3bfcc..b5c75b1f63d6
2023-06-15 [email protected] [graphite] Fix multisample state in Vulkan graphics pipeline
2023-06-15 [email protected] [graphite] Fix extra semicolons for runtime effect constants/structs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I9576fc1198d9801ec17ecd57bc9597debd699e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618648
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158314}
Lacros: Remove the identity API ui app from ash keeplist.
Since we are deprecating Lacros SxS/LP mode, and only support
Lacros Only mode (go/lacros-sxs-primary-removal), ash-chrome
browser is not accessible to users when Lacros is enabled. We
should remove the identity API ui app (used by identity auth
flow) from ash extension keeplist since auth flow is not going
to be invoked from ash in Lacros Only mode.
Bug: 1454874
Change-Id: If5c698ffa71ad4e5f76ddcd15e78b5bb67f55376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617003
Commit-Queue: Jenny Zhang <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158313}
Notification Cleanup: Refactor AshMessagePopupCollectionTest
Rather than create a new AshMessagePopupCollection for the test, we will
use the same AshMessagePopupCollectionTest instance that is created by
AshTestBase within the UnifiedSystemTray. This will allow the test
AshMessagePopupCollection to receive signal from clicking the widget,
interacting with the UI, etc.
This refactor is needed for writing unit tests for the bug below.
Bug: b:4594540
Change-Id: I4f3082aed37022b77e8b3c3297e3d4ac417b0d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616967
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158312}
Roll ANGLE from e8a29d6cd7d7 to 3545ae0ca0b3 (5 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/e8a29d6cd7d7..3545ae0ca0b3
2023-06-15 [email protected] Add isContextMutexStateConsistent() ASSERT
2023-06-15 [email protected] Make Test spec JSON generator hashless.
2023-06-15 [email protected] Metal: Set alphaToCoverageEnabled in checkIfPipelineChanged
2023-06-15 [email protected] Mali: Make the placeholder FBO complete for timer queries
2023-06-15 [email protected] Add ANGLE experimental SwiftShader builders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1329376,chromium:1336126,chromium:1356053,chromium:1380082
Tbr: [email protected]
Change-Id: Ibfbabb5168e88c8b24d10b07cb339d59b07e267d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618375
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158311}
[fixit] Disable AddToHomescreenTest on auto
WebappsUtils.isAddToHomeIntentSupported returns false and users are not
able to add shortcut on the screen.
Bug: 1454579
Change-Id: Ifc8782c3aaebfdc56817e140c7ece6c4141db082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611279
Reviewed-by: Ella Ge <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158310}
Roll Perfetto from 46592c5c8ca6 to 0ba4c2cd1226 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/46592c5c8ca6..0ba4c2cd1226
2023-06-15 [email protected] Merge "Shared library: C protobuf definitions for track event"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ic6e5396891537ec8d7deb2b5755dfef535183b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614217
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158309}
Avoid passing NULL to memcmp
Some C++ libs legitimately use (nullptr, 0) as the empty slice for
the zeros vector. This can then end up passing NULL in the case of
memcmp(NULL, whatever, 0) which C frowns upon and may be annotated
as not allowing the NULL.
We can just ensure this doesn't happen by allocating an extra byte
in the vector.
Bug: 1322914
Change-Id: I9c38a6f0c91e54ba34e3a796a0ed6ffac2b293fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607067
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Bob Beck <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158308}
Update V8 to version 11.6.168.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6a435063..876556b9
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I4e88edbf37822eb87ca4609625aa94c412c76922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614343
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158307}
[FedCM] Fix NullPointerException in focusForAccessibility
Bug: 1454865
Change-Id: If7213924a401e3b5f2114668bd7d035669b1aa6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615526
Reviewed-by: Nicolás Peña <[email protected]>
Auto-Submit: Zachary Tan <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Nicolás Peña <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158306}
Print settings: Fix counting logic for showing saved printers
- This code for determining when new saved printers are added has a race
condition depending on which section of Printer settings loads first
- The updated code specifically checks for only 1 saved printer being
added which makes it more resilient
Bug: b:278621575
Tests: browser tests --gtest_filter=*OsPrintingPageCupsPrintersEntry*
Change-Id: Ia7bf30138dafe295c460574b328effa67cc68ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609451
Reviewed-by: Xiangdong Kong <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158305}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686830367-1a943bf4cfd0b4cc44d096b24cc9531d65716a91.profdata to chrome-win32-main-1686840704-779696f48b43141d8e12fa7352500e38d63a4665.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: If17a396a57fe343e24300f38a3c0870022a52cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618497
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158304}
Add API to commit pending writes for browser state prefs
Change-Id: Iee94d04e91a33e764b81f8a46cccd0ed5805666b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611272
Reviewed-by: Hiroshi Ichikawa <[email protected]>
Commit-Queue: John Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158303}
[ios] Replace webStateList:didMoveWebState:fromIndex:toIndex with didChangeWebStateList:change:selection:
This CL replaces webStateList:didMoveWebState:fromIndex:toIndex with didChangeWebStateList:change:selection:.
This CL is a part of refactoring WebStateListObserver API:
Step 1 [Done]: Introduce WebStateListChanged() and replace WebStateReplacedAt() with it
Step 2 [Done]: Replace WebStateInsertedAt() with WebStateListChanged()
Step 3: Replace WebStateMoved() with WebStateListChanged()
Step 3-1 [Done]: C++ side (https://chromium-review.googlesource.com/c/chromium/src/+/4556706)
Step 3-2 [This CL]: Objective-C side
Step 4: Replace WebStateDetachedAt() with WebStateListChanged()
Step 5: Introduce WillWebStateListChanged() and Replace Will*() with it
Step 6: Migrate WebStateActivatedAt() to WebStateListChanged()
No behavior changes.
See https://docs.google.com/document/d/1I1QUZAexM1eMI2l2oriZl5GARrtofNI0SxHUPB4h-YE/edit?usp=sharing for more details (internal document).
Bug: 1442546
Change-Id: Ibdb46255c6a1a5092dd2b4b7c7ed4da9765702a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615406
Commit-Queue: Asami Doi <[email protected]>
Reviewed-by: Federica Germinario <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158302}
Roll devtools-internal from ab7c234c7fbf to 3ce4b25c0ad1 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/ab7c234c7fbf..3ce4b25c0ad1
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d0621c7ea63e6eee1eb576b1ff6e4db3a205d88e..31b61655657cd499c74d6f099bb67c98cfb11cf4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I34281ee97cbacc7de525315d445d685ea420f46f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618471
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158301}
[ios] Implement HTTPS-Upgrades
This CL implements the initial version of HTTPS-Upgrades on iOS. This
feature is essentially HTTPS-First Mode (formerly known as HTTPS-Only
Mode) without the HTTP interstitial, so it uses the same upgrade and
fallback logic as HTTPS-First Mode on iOS.
A brief summary of the HTTPS-Upgrades logic is as follows:
1. A class called HttpsOnlyModeUpgradeTabHelper which is both a
WebStatePolicyDecideder and WebStateObserver keeps track of navigations.
2. When a navigation starts, an instance of this class checks whether
it should allow the current navigation response. If the scheme of the
URL is https, or if the user allowed the HTTP navigation before by
clicking through the interstitial, or if the navigation isn't eligible
for an upgrade (e.g. it's localhost, an IP address etc), the navigation
is allowed and no upgrade is done.
3. Otherwise, the current response is canceled. A new navigation with
an HTTPS scheme is initiated and a timer is started.
4. The tab helper checks the upgraded navigation's response. If the
response is for a good HTTPS URL, the navigation is allowed and the
upgrade is successful.
5. Otherwise, the response is a broken or slow HTTPS or an HTTP URL.
The upgraded navigation is canceled. A fallback navigation is
started to the fallback HTTP URL. (In HTTPS-First Mode, this step
would show the HTTP interstitial instead).
Bug: 1449050
Change-Id: Ic45f7f1cf6862f0e090deecb6a211688dc8e4d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575901
Commit-Queue: Mustafa Emre Acer <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158300}
[CrOS settings] add messages to Passpoint removal dialog.
Internet details page shows a dialog to inform the user about the
removal of a Passpoint subscription. The messages and the behavior are
different depending on the release phase of the feature. This CL creates
a dialog element that handles the different messages and allow to
implement the two behaviors.
Screenshots:
- https://screenshot.googleplex.com/49bEWcb6d3U6jyk.png
- https://screenshot.googleplex.com/6AhvEguAAiHJkeU.png
--gtest_filter="OSSettingsInternetPagePasspointRemoveDialogTest.*"
browser_test \
--gtest_filter="OSSettingsInternetPageInternetDetailSubpageTest.*"
Bug: b:280784916
Test: browser_test \
Change-Id: I76930b217b1f2bc4da4304a880ad5b2ce5548e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603938
Reviewed-by: Jason Zhang <[email protected]>
Commit-Queue: Damien Dejean <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158299}
user-note: iframe check happens in context menu
Rather than performing the "is in iframe" check when trying to create
the user note selector, prevent enabling the option in the context
menu when opened in an iframe.
This will allow us to remove uses of AnnotationType in renderer
Change-Id: I8d3600b81b45d2a81f41b1b49f25b50c2c903ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571381
Reviewed-by: Yuheng Huang <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158298}
[Nearby Presence] Persist registration completed boolean
The LocalDeviceDataProvider now considers `IsRegistrationComplete` to be
true when the user name and profile url are persisted to prefs, as well
as checking a newly added pref boolean "registration_complete" to be true.
The new pref boolean is persisted when the entire first time registration
flow has been completed. This is a change from only when the server part
is completed. This will prevent "half-registered" states where consumers
think registraton is complete, when only the server portion is complete.
This will be used in a follow up CL that adds a CredentialManagerFactory
and will check that the factory is correctly registered before
executing the async callback.
Test: Unit tests only
Bug: b/276307539
Change-Id: I9dd4cf9228e8f7f443c6502d12643288ade1f39f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4558184
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Juliet Lévesque <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158297}
Bump mozlog version to 8.0.0
This version supports the subsuite feature which is required by
wptrunner.
Bug: 1452168
Change-Id: I21b1b6df57d1ef025d513f15faa86aa2e8a630af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605367
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158296}
Add michaeldo@ to ios/web/OWNERS
Change-Id: I03e502afd33502ba1fdf8116ced43cde067828b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615182
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ali Juma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158295}
Change "libaom_unittests" to "libaom tests"
The target "libaom_unittests" has been renamed "test_libaom". Use a
general description instead of a specific target name.
Change-Id: I7e6f0fc667dd18231688d5f9384cd814c0d0d517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617009
Auto-Submit: Wan-Teh Chang <[email protected]>
Commit-Queue: James Zern <[email protected]>
Reviewed-by: James Zern <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158294}
Roll RTS model from BRg1F6qOO4fhwj34n... to ymt4Jpnr37nBMRkhx...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I0c74c873b7f2032d1a59b5f34caf1c24a07a0555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616961
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158293}
[Lens]Send side panel width and height for companion requests
Bug: 1440854
Change-Id: I3422397c1a96eacac57b0001edc30f910813770c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610243
Commit-Queue: Jason Hu <[email protected]>
Reviewed-by: Duncan Mercer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158292}
Make mac-code-coverage builder use 12 core machines
24 core machines are not available for use in the CI pool.
Bug: 1454945
Change-Id: Idaacfa3483881c4766612fbe707e35e42d7b8cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618028
Reviewed-by: Prakhar Asthana <[email protected]>
Commit-Queue: Prakhar Asthana <[email protected]>
Auto-Submit: Zhaoyang Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158291}
Bookmark special folders draw more correctly.
* ImprovedBookmarkFolderView now defaults to a valid 0 image state.
* All top level folders are treated as special, using accent tints.
* Special folders no longer fetch images from children.
Bug: 1449817
Change-Id: I1508fd14b6503d81ff63394e1b074302922afb5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616727
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158290}
Fix spacing and styling for tasks glanceable view button.
Screenshot in bug.
Bug: b:277268122
Change-Id: I3b60ff142ddb3d46eae9e8314fd1ec8a7844123d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617126
Commit-Queue: Yulun Wu <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158289}
Propagate Color information from Ash to Lacros
Read color information from Ash to seed the Lacros theme. Color
information will only be sent if Jelly is enabled and its only used
when ChromeRefresh2023 is enabled.
Color information is received via mojo. Update to the NativeThemeInfo struct included here.
Bug: b:285907362, b:285907359
Change-Id: Ib4500f203bac3879a4822c0f7865af849721d2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595806
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Reviewed-by: Brian Osman <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Florin Malita <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158288}
Add a Part collection to PartRoot and connect it up
This CL just adds a `parts_` collection to `PartRoot`, and updates
it in the naive way any time a new Part is constructed. No Node
tracking is done or anything, so it's completely possible that if
a Node is moved to another document, the parts list will be out of
date.
Bug: 1453291
Change-Id: I1fa01e0543dfe52974ac6175728f5fe79c7c3b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609624
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158287}
webauthn: require up-to-date JSON serialisation on Android.
This this change, passkey providers on Android can no longer send `null`
for optional values, and must return the easy-attestation values. I've
tweaked the code a little so that a public key need only be provided for
P-256 and Ed25519. Previously a public key had to be provided for all
algorithms that Chromium supported, but that seems a bit sharp if we add
more algorithms in the future.
Remote desktop uses are not yet ready for these policies to be applied,
so this change doesn't touch the CRD case at all (although we can likely
get away with the easy-accessor stuff). But since we need to
differentiate Android vs CRD cases in the code anyway, touching CRD
would add risk to a change that we mainly want to get established on
Android.
Bug: 1427843
Change-Id: I6488b952fe751f6e42f3bb12c53e92f5e1268934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609977
Reviewed-by: Martin Kreichgauer <[email protected]>
Auto-Submit: Adam Langley <[email protected]>
Commit-Queue: Adam Langley <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158286}
Refactor SafeBrowsingLookupMechanism to return threat source
This CL should not have any functional changes. Previously, each
SafeBrowsingLookupMechanism was returning a is_from_url_real_time_check
bool. This was used in SafeBrowsingUrlCheckerImpl's MakeUnsafeResource
to set the resource's threat_source either to URL_REAL_TIME_CHECK or to
the relevant database manager's threat source.
The is_from_url_real_time_check property is now replaced with an
optional ThreatSource enum, which is used directly in the same function
MakeUnsafeResource.
This refactor enables the HashRealTimeMechanism to return a new threat
source relevant to it specifically, instead of returning an additional
bool (e.g. is_from_hash_real_time_check). A followup CL will return the
new threat source.
Bug: 1441654
Change-Id: I16ee267adc3e945194cc07efc2f0522bd99e97b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614888
Commit-Queue: thefrog <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158285}
[code health] Finish cleaning up Compositing.CopyFromSurfaceTime
Bug: 1385086
Change-Id: I8dcdecb737997c1ca7be45f6e6fc265b73232439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617058
Code-Coverage: Findit <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158284}
Refactor #getThumbnailPlaceholderIconColor.
Multiple minor stylistic changes to the method. no functional changes.
* Moved default_icon_color_on_accent_1 into SemanticColorUtils.
* Replaced custom applyAlpha with a ColorUtils call.
* Adjusted variables names to self document and removed all comments.
* Added final to local variables to inline annotation.
Change-Id: If4ddacdcbc15c49726016eebb881e86efd6cf2dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616018
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158283}
Roll Depot Tools from dedeb8899173 to 3ffad8166e1c (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dedeb8899173..3ffad8166e1c
2023-06-15 [email protected] Don't set blamelist_pins on the json output.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I066a4b15738feeebec79431bd26393bad5881fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618410
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158282}
Restore cellular connect result histogram
Restore the original Network.Shill.Cellular.ConnectResult value so we
can still see the old metrics in UMA.
The histogram was removed in crrev.com/c/4596038
BUG=b:270020431
TEST=python3 validate_format.py
Change-Id: I28182661635dd6cd6a102548547aca2c6c38357d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616015
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Andrew Lassalle <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158281}
Move HashPrefixMatches crash fix into Initialize
I saw another crash after the previous fix in
http://crrev.com/c/4611728. This change moves the file size check into
Initialize(), which also catches the case where we mmap right after
writing the db. I also added a crash key to help debug if we see more
crashes.
Bug: 1409674
Change-Id: Ia047d154a867b7e83e66e50821d337b8574c6724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615728
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158280}
Roll src-internal from 9fe891904b03 to a44a139a9575 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9fe891904b03..a44a139a9575
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1451867
Tbr: [email protected]
Change-Id: Iea65f4fd1874a838218be1ec5570f21e1c54f1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616960
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158279}
Roll clank/internal/apps from cb3287753146 to efb94d9a2801 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/cb3287753146..efb94d9a2801
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
No-Try: true
Change-Id: I9887fbff4d9849785c114e6af3b1dc2abfc49bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617238
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158278}
Remove incorrect and obsolete VoiceRecognitionHandler test case.
I came across this test case when i was working on migrating VRH
Integration tests to Unit test suite.
The test was formerly passing for wrong reasons, as it was suppressed
by permission setting. The test was never verifying whether any tabs
are available - and it never needed to, as Tabs are not critical for
Voice Recognition Handler to be available.
Change-Id: I74dafc1f15956bd1409017b1313e98ceb03361d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617055
Reviewed-by: Patrick Noland <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158277}
Remove the obsolete UrlBarIntegrationTest filter from emulator filters
Change-Id: Idf06309659bf00fd81a83af332d25592ee9ae5ff
Fixed: 1274918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617056
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158276}
Revert "[omnibox] Split WebUI implementation out from OmniboxPopupViewViews"
This reverts commit e3cd8b9ff33f6c670d4a91f54c81ab0c3a486ab7.
Reason for revert:
The newly added tests have been failing on several different lsan/msan/asan bots, and I was able to reproduce it locally. Here is an example: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-asan-lsan-rel/5245/overview
Original change's description:
> [omnibox] Split WebUI implementation out from OmniboxPopupViewViews
>
> This CL refactors OmniboxPopupViewViews to make OmniboxPopupViewWebUI
> a fully separate subclass, eliminating all reference to "webui" except
> for some safety checks which can be eliminated after the new class
> is fully settled.
>
> In addition, this CL takes a few opportunities for code cleanup and
> simplification. For example, method `GetSelectedResultView` was removed
> because it had only one call site so inlining was cleaner than creating
> a separate implementation to return nullptr in OmniboxPopupViewWebUI.
>
> Bug: 1445142
> Change-Id: I6d37efc8b21ea36e6df3f897a1f732bcbea2d476
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602452
> Reviewed-by: Moe Ahmadi <[email protected]>
> Commit-Queue: Orin Jaworski <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Commit-Queue: Moe Ahmadi <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157941}
Bug: 1445142
Change-Id: I54e8cbad1821c5b7994c858223fed7c4b2149ecd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618013
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Owners-Override: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158275}
Record cryptohome mount in auth-events crash key
Indicate in the "auth-events" crash key whether the user's cryptohome
was mounted.
This is a useful hint when narrowing down some crashes during user
login. In addition, it allows us to monitor and tackle separately
crashes that happen after the cryptohome is mounted but before the
user session is fully started.
Bug: b:267769916
Change-Id: Ifdf83879d01e6ab6ed63ffed16c957a946aa9114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614975
Reviewed-by: Anastasiia N <[email protected]>
Commit-Queue: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158274}
Roll Chromite from 9c40958316d5 to 8885dfd037a9 (32 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c40958316d5..8885dfd037a9
2023-06-15 [email protected] cros-ide: metrics: migrate metrics.send callsites in target board
2023-06-15 [email protected] cros-ide: metrics: migrate metrics.send callsites in cros format
2023-06-15 [email protected] cros-ide: Post config migration refactoring
2023-06-15 [email protected] cros-ide: Remove the default parameter from ConfigValue
2023-06-15 [email protected] cros-ide: Migrate configs for paths
2023-06-15 [email protected] cros-ide: Migrate configs for metrics
2023-06-15 [email protected] cros-ide: metrics: migrate metrics.send callsites in chromiumos
2023-06-15 [email protected] cros-ide: metrics: migrate metrics.send callsites in boards packages
2023-06-15 [email protected] cros-ide: Remove a needless await
2023-06-15 [email protected] cros-ide: Migrate configs for device management
2023-06-15 [email protected] cros-ide: Migrate configs for under development features
2023-06-15 [email protected] cros-ide: Migrate configs for test coverage
2023-06-15 [email protected] cros-ide: Migrate configs for spell checker
2023-06-15 [email protected] cros-ide: Migrate configs for platform EC
2023-06-15 [email protected] cros-ide: Migrate configs for owners files
2023-06-15 [email protected] cros-ide: Migrate configs for gerrit
2023-06-15 [email protected] cros-ide: Remove a no longer used config
2023-06-15 [email protected] cros-ide: Migrate configs for code search
2023-06-15 [email protected] cros-ide: Migrate configs for chrome
2023-06-15 [email protected] cros-ide: Migrate configs for boilerplate
2023-06-15 [email protected] cros-ide: Migrate configs for boards and packages
2023-06-15 [email protected] Automated Commit: Updated config generated by config-updater builder.
2023-06-15 [email protected] cros-ide: metrics: migrate metrics.send for extension suggestion
2023-06-15 [email protected] cros-ide: Migrate cros-ide.board to chromiumide.board
2023-06-15 [email protected] cros-ide: metrics: migrate metrics.send for chromium features
2023-06-15 [email protected] lib: Skip compressed metadata when creating a single DLC for deploying
2023-06-15 [email protected] Automated Commit: Updated config generated by config-updater builder.
2023-06-14 [email protected] scripts: upload_prebuilts: Use path_util/chroot_lib for path translation
2023-06-14 [email protected] lib: keep CROS_CLEAN_OUTDATED_PKGS entering sdk
2023-06-14 [email protected] lib: has_prebuilt: pass down --debug when active
2023-06-14 [email protected] lib: depgraph: stop excluding chrome rebuilds
2023-06-14 [email protected] setup_board: clean up use of --skip_chroot_upgrade/--skip_toolchain_update
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome
Tbr: [email protected]
Change-Id: I5600dfb138c40c54608e918314e174b20d6c9328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618089
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158273}
Roll Media App from eKau9XPOtXGhEKd42... to 0YfAUIU49CI1VJogg...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202306150800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/0YfAUIU49CI1VJoggZ-nRGDPoJRJpQb5VrVzXbrVjcQC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/285226158
Tbr: [email protected]
Change-Id: I8edc21a720feef377b3dd2fce8ceb74545aee352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617839
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158272}
Create AuxiliarySearchHooks
This CL is the first step to split auxiliary search out of chrome.
After internal repro finished, AuxiliarySearchControllerFactory will
hook with AuxiliarySearchHooks, and delete
AuxiliarySearchControllerImpl.
Change-Id: I827b8fc73e7544fa0be3a27fe1ee9acf9071450a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617373
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158271}
Remove dead code from URLLoader::Context
Change-Id: I3e0e0faf4548d1171970cd1acab0fc2659583c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616690
Commit-Queue: Andrey Kosyakov <[email protected]>
Auto-Submit: Andrey Kosyakov <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158270}
Modify and migrate SUS unit test to components
Bug: b/283048019
Change-Id: Ifb3b10f93ea390c2a98cbb159dc4651e85304115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593233
Reviewed-by: Tomek Jurkiewicz <[email protected]>
Commit-Queue: Anthi Orfanou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158269}
Roll RTS model from 6NdT2C0XTtRJKYySV... to hN-Lld1UDn_0bGEgF...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I719f18b5ca23b8ffa6413c7c58c13ed3768aaf91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617601
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158268}
Convert verifyOrderedViewTypes to use varargs.
Change-Id: I299185b0c2b83bdb056dfc66ddfa3a54e7216525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616871
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158267}
Gpu testing: Add macOS 14 Sonoma support
Vibing off of https://chromium-review.googlesource.com/c/chromium/src/+/3944932
Bug: 1452206
Change-Id: I9073acd024c13415803e49e9283b89488b44954d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610696
Reviewed-by: Kenneth Russell <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: Jayson Adams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158266}
Tabs directly check for widget activeness instead of plumbing through TabStrip.
It makes no sense for tabs (or the NTB, or, especially, the BrowserRootView) to ask the tabstrip if they should paint as if the widget is active - that is something between them and the widget, and the tabstrip doesn't enter into it.
This is a smol first step towards fixing tab colors in GM3.
Change-Id: I56e7bb3b186059eb9382f15e14c88aaece440bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616946
Commit-Queue: Taylor Bergquist <[email protected]>
Reviewed-by: Shibalik Mohapatra <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158265}
Remove androidx.credentials to //third_party/androidx
credentials-1.2.0-SNAPSHOT.aar is available, while
credentials-1.0.0-SNAPSHOT.aar does not exist any more.
Bug: 1454822
Change-Id: Ic08c5e451a1254debc5aa3a0e0d409ace37cc960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616393
Reviewed-by: Mohamed Heikal <[email protected]>
Commit-Queue: James Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158264}
[SecureDLs] Update tests to use secure downloads
Upcoming changes to Chrome will show a warning on insecurely-delivered
downloads. This CL updates two sets of tests to use secure downloads so
that the warnings do not cause test failures.
Bug: 1352598
Change-Id: I1c7bd9f314d2adc6e2f36d7aec26445a6a83c338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616788
Reviewed-by: Jian Li <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158263}
[UPMLocalPwd] Trigger the password migration warning from the KA bar
The pwd migration warning will be shown when the user taps a password
suggestion in the keyboard accessory bar.
Bug: 1439761
Change-Id: Ie28febb8b459146d9942dd51d8c05648826029b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610324
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158262}
Move proto_test_support to base
It's needed in services/tracing/ in follow-up
AX-Relnotes: n/a.
Bug: 1418116
Change-Id: I222a2790f092e909ec73284da84e7d57d06643bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607155
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Owners-Override: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158261}
[CSC] Add Companion to Field Trials
Change-Id: I713b6f07106059a44c5b9ec7300f62c6541f7a31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616646
Reviewed-by: Tarun Bansal <[email protected]>
Auto-Submit: Michael Crouse <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158260}
CrOS Settings: Update CrOS Settings OWNERS file references
Update references of the CrOS Settings OWNERS to the new OWNERS file
under chrome/browser/resources/ash/settings. This is done in preparation
for moving the CrOS Settings SWA frontend code to the aforementioned
directory.
Bug: b/283986054
Change-Id: I957e4325462416dcbc93612803ebea703bae1944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616997
Commit-Queue: Wes Okuhara <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158259}
Roll RTS model from egCFe24NDoUekIFph... to lFzgq5jjwZ6ucRo7N...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia9f1cad194ea8307ef3e8ca4062cf75c0a6de475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614214
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158258}
[ios] Use same background color in Overscroll as NTP for Magic Stack
Fixed: 1454903
Change-Id: Ib2780bdff953c8489174d3f9458d0781ce6129e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617124
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Scott Yoder <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158257}
Roll WebGPU CTS from 9a981a010fde to f7988e7e72f5 (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/9a981a010fde..f7988e7e72f5
2023-06-15 [email protected] Adding 0x80000000/0x8000 cases to `ceil`, `fract`, `floor` & `round` (#2767)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I53cce9b6764905d7b03e7a2575a392cb96e5f61c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617225
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158256}
[Sync] Add more details for waiting for updates timeout histogram
This CL replaces waiting for updates timeout histogram with a new one
broken down by a reason why the data type is waiting for updates.
Bug: 1425026
Change-Id: I771b6b6407612cbca9dc5b405d09d24daaceaa98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615796
Commit-Queue: Rushan Suleymanov <[email protected]>
Quick-Run: Rushan Suleymanov <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158255}
[//media] Guard BindClientManagedImage() by IS_OZONE
This code is built for Linux on ARM64 (which isn't a build config that
we keep green on any bots, but there are some folks who are interested
in it internally). Change BindClientManagedImage() to be guarded by
IS_OZONE rather than IS_CHROMEOS. This code should go away shortly in
any case.
Bug: 1324249
Change-Id: Ica38aae0b98ff9b66f05a47f91d926985bdfad9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615084
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158254}
[autofill in devtools] SetTestAddresses implementation.
Bug: 1451267
Change-Id: Idcfaa59cee088bfa5661e9d946217fc4e133edb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4586961
Code-Coverage: Findit <[email protected]>
Commit-Queue: Bruno Braga <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158253}
[Fixit] Fix PCCT test failures on automotive bots
* Add a screen size check to skip test in landscape. #testLaunchPartialCustomTabActivityWithInitHeight_BottomSheet is trying to verify PCCT is showing using bottom sheet, while when side sheet is disable the PCCT is shown as full-size CCT in landscape.
* Disable #testLaunchPartialCustomTabActivity_Transition on automotive where screen rotation is not relevant.
Bug: 1454885
Change-Id: If419942f99a8b8b513c0ff4271d603f947f34ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616162
Reviewed-by: Zach Katz <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158252}
WebUI: Leverage build_webui() in components/version_ui/
build_webui() is the canonical way of building WebUI pages, and
leveraging it brings many advantages, like JS minification.
As part of these changes, an auto-generated dedicated grd file is used.
Bug: 1431253,1132403
Change-Id: Iffda0ebc6afc629900808c363f99c1e9cec05740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616013
Reviewed-by: Cole Horvitz <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158251}
saved_desks: Clean up TODO for admin template provider
This CL will clean up two TODOs I added in previous CL when adding icon
color for admin templates.
Bug: b/278271038
Change-Id: I5c9143611ad1a1799bfe166931ee448637bee1d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616604
Reviewed-by: Daniel Andersson <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Hongyu Long <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158250}
[//media][Mac VDA] Correctly check for null `config_.hdr_metadata`
[1] inadvertently flipped a check of `config_.hdr_metadata` being empty
to it being *non-empty*, resulting in it not being populated before
being accessed. This CL fixes the issue.
To test: Download the video in the linked bug and drag it into the
browser. The video should play and there should be no GPU process crash.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4596056
Bug: 1454723
Change-Id: Ibe82de48a837c38fadf812290776424ff7e9eddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614464
Reviewed-by: Frank Liberato <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158249}
[FedCM] Actually run the multi-IDP tests
Due to an incorrect merge conflict resolution in
https://chromium-review.googlesource.com/c/chromium/src/+/3924487/56..58
these tests never actually ran.
The problem is that they are skipped in the base test suite (as
expected), but the virtual test suite inherits the Skip expectation
and the line that changes it to Pass has been removed by accident.
Bug: 1348262
Change-Id: I2711c3607f727fa5f92e32833c7b645e31ba2f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617005
Reviewed-by: Zachary Tan <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158248}
Add integration test `IntegrationTest.GetAppStates` for Mac/Linux
This CL adds integration test `IntegrationTest.GetAppStates` for
Mac/Linux.
The test is not working correctly on Windows at the moment, and will
be fixed in a subsequent CL.
Bug: 1454979
Change-Id: I02f151c1b5f97c8e37d7a918665ebf9dc7978d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617587
Auto-Submit: S Ganesh <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158247}
[iOS] Change the top of feed sync promo colors for Magic Stack
This change updates the top of feed sync promo colors to match the NTP
color changes due to the Magic Stack feature.
Bug: 1454908
Change-Id: I36564f3b6cdfa0fabfcc3993817642fb47a5ba85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616887
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Guillem Perez <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158246}
Import wpt@96082535f8644a916524a4036ec88ae52c447006
Using wpt-import in Chromium 725e372f98f945db2f905a168a1cb9c48a9af2aa.
With Chromium commits locally applied on WPT:
c4b9eceb1b "Remove XRSessionDeviceConfig.uses_input_eventing and related code"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/motion
[email protected], [email protected]:
external/wpt/css/CSS2
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I47531d5b11d4461baf7ee1706fc4f666c8bd411c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615178
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158245}
[ios] Add See More Set Up List half sheet
When the "see more" button in the Set Up List multi-row Magic Stack
module is tapped, a half sheet showing all Set Up List items will be
shown. SetUpListShowMoreItemView is create to represent the layout
of each item in that view, which requires a unique "Try" button and
slightly different layout needs to SetUpListItemView.
Bug: 1432252
Change-Id: I5ea8454798f21d2f157af8e0b8e4ba27c41c5a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616005
Reviewed-by: Scott Yoder <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158244}
Revert "Restore NavigationRequestPreconnect Feature."
This reverts commit 45119933452ae90df3911549a9d4397aa1adc3be.
Reason for revert: done running experiment.
Original change's description:
> Restore NavigationRequestPreconnect Feature.
>
> This Feature was removed in crrev.com/c/4021617 but it is still used in
> an ongoing experiment. We'll keep it for a bit longer.
>
> Bug: 1400743
> Change-Id: Idca3bfbf0e8703f85662113966b91c81b84e26ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4103005
> Reviewed-by: Clark DuVall <[email protected]>
> Commit-Queue: Simon Pelchat <[email protected]>
> Reviewed-by: Arthur Sonzogni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1083151}
Bug: 1400743
Change-Id: Ibf4835ff54e438006dbd08951ffe4314dda4d1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615950
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Simon Pelchat <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158243}
Roll Skia from 0b66c6928dcf to cc7c05a3bfcc (2 revisions)
https://skia.googlesource.com/skia.git/+log/0b66c6928dcf..cc7c05a3bfcc
2023-06-15 [email protected] Add color mode to Viewer::Mesh slide
2023-06-15 [email protected] Many-stop gradients: Convert texture to destination space
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1449408
Tbr: [email protected]
Change-Id: I1c05c59e9172f6449bbe4240f5cf415e39ad2752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618469
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158242}
[Viz] Eliminate viz::GLInternalFormat(ResourceFormat)
The only remaining caller is the SharedImageFormat equivalent. This CL
inlines the former into the latter.
Bug: 1378708
Change-Id: Ie36578a757cdbaf50d2d2775568119ccc2ccff07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615789
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158241}
[CrOS Bluetooth] Fix disconnection toast not showing for some devices
Fix disconnection toast not being shown for some devices (i.e. Logitech
K480) when they were forgotten. This was occurring because for those
devices, the device would be removed from the paired devices list before
notifying observers that the device's connection status had changed.
This was different from the behavior of correctly handled devices, which
would notify the device's connection status had changed before being
removed from the paired devices list. This difference in behavior would
cause these ill-behaving devices to not be handled by
BluetoothDeviceStatusNotifier. Update BluetoothDeviceStatusNotifier to
handle this by checking if there are any devices that used to be in the
paired devices list that are no longer there, and for each device that
is missing, if it was last seen as connected, notifying observers that
it is now disconnected.
Fixed: b:282640314
Test: DUT and *BluetoothDeviceStatusNotifier*
Change-Id: I6964362a77bc401af905901c257d6243f8463116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616409
Reviewed-by: Theo Johnson-kanu <[email protected]>
Reviewed-by: Chad Duffin <[email protected]>
Commit-Queue: Gordon Seto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158240}
Roll Perfetto from 8df69bbd2346 to 46592c5c8ca6 (2 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/8df69bbd2346..46592c5c8ca6
2023-06-15 [email protected] Merge "Only Offset Overview Cursor Selection When Sidebar"
2023-06-15 [email protected] Merge "ui: Add TracksV2 version of TrackState"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I50a52280c71f7624819122705ec65171f0b398fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618408
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158239}
Update progress indicator colors for Jelly.
When Jelly is enabled, shelf trays have an accent-color background
when active. The accent-color background causes progress indicators
to be illegible since they are also accent-colored.
This CL updates colors when Jelly is enabled per spec linked in the
bug. When shelf trays are active, progress indicator colors are updated
to ensure contrast.
Before: http://shortn/_TSETDLInV1
After: http://shortn/_RdQLP5h2js
Bug: b:287151663
Change-Id: I24c3d79e11562d82fffb992877eb4ba3f7622843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617387
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158238}
Roll libcxxabi from 899caea3814e to c2a35d1b2cf4 (1 revision)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/899caea3814e..c2a35d1b2cf4
2023-06-15 [email protected] [libc++abi] Avoid including source files into unittest_demangle
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxxabi-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Iae05656744ad60a815c46a1416350c259c105a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618470
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158237}
[Color correction] Adds color filter prefs to incognito allowlist
Like other a11y settings, color filter settings can be on the
incognito allowlist.
Bug: b/259372272
Test: Manually ran in guest mode
AX-Relnotes: N/A (behind flag)
Change-Id: Ic25ea03be72cc797cf1bf9aeb27f933fcb962290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616743
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158236}
[DIPS] Treat Successful Web Authn assertions as user interaction
This CL pipes into DIPS successful web Authn assertions signals to be
considered as user interaction by DIPS for the top level frames.
This is a first to a set of two, the following CL will pipe this same
signal for the Android Platform.
Bug: 1446678
Change-Id: I272d7a97fce5db1a1eea2b00cfeeb7f3e6843fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590609
Reviewed-by: Ben Kelly <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Jonathan Njeunje <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158235}
Roll Help App from HTQXGmqOjSBe-mEIk... to 7NxZbReGqsCEa11RA...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202306150800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/7NxZbReGqsCEa11RAqe072sRWVcuKS6W72Fl6rGsG-cC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/285181120,b/285216732,b/287138792
Tbr: [email protected]
Change-Id: I416fec7aca121474ba1126c6f6967959af7d2221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614209
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158234}
[DTC] Close dialog widget instead of hiding on preference update
Hiding dialog widget will results in hanging browser windows on Windows, fix by closing dialog widget instead.
Bug: b/286079631
Change-Id: I1c214323a04d77322c5abe9f8e819878920b697c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594039
Commit-Queue: Zonghan Xu <[email protected]>
Reviewed-by: Sébastien Lalancette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158233}
[DTC] Set kDeviceSignalsConsentDialog to be enabled by default
Set consent dialog feature to be enabled by default.
bug: b/277902896
Change-Id: I38eebf000f434850cd7402b110eea401b3f5c193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616328
Reviewed-by: Sébastien Lalancette <[email protected]>
Commit-Queue: Zonghan Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158232}
[GM3][Panorama] Show GM3 palette colors on swatches
* Updated to use GeneratePalette to get GM3 palette for seed color for
chrome colors when ChromeRefreshWebUI2023 flag is on.
Screenshots:
Light mode: http://screenshot/BkcKxdiCYv5fKUs
Dark mode: http://screenshot/Au5m7Ms9SXJ8pEG
Bug: 1430277
Change-Id: I1262e95411084f462f67743d80af8701e7a82e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606058
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Riley Tatum <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158231}
Clean up ExtensionEventsEnabled Finch flag
Feature has been launched and on by default since M-110.
Change-Id: I10564e46bd92abdc87e10f27b7723afb79a865d7
Bug: b/253250633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616411
Code-Coverage: Findit <[email protected]>
Commit-Queue: Shanthanu Bhardwaj <[email protected]>
Reviewed-by: Nasser Al-shawwa <[email protected]>
Reviewed-by: Shanthanu Bhardwaj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158230}
[FeedBottomSyncPromo] Remove fieldtrial and enable the flag by default
Remove fieldtrial and enable the flag by default since this feature
is 100% launch.
Change-Id: I17c96d47131c1075e64a1f182e7327b3e951861c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617051
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Tina Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158229}
[Shopping Service] Add ineligibility reason histogram for shopping list
This patch adds a histogram showing the breakdown of reasons why a
user is ineligible for the shopping list feature. This histogram
records all reasons, not just the first that caused ineligibility.
Bug: b:284349621
Change-Id: I8dcabcac0380f26bc705c10e5b3bbc3d6daa6ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569086
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Zhiyuan Cai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158228}
Make SelectFileDialogParams a member of FileSystemChooserTest
Avoid a spurious dangling ptr warning about out-of-scope locals
by moving this from the stack into the test class itself where
it will persist until TearDown() clears the unowned reference.
In turn, this created a lifetime issue between the reference to
the GURL in SelectFileDialogParams and the object which owns it.
Storing this by value decouples the params, and copying a GURL
is relatively cheap since it doesn't reparse.
-- Add a comment about lifetime to ui::SelectFileDialog::SetFactory()
while at it.
Bug: 1401495
Change-Id: I3361347a1b3f78c94c053254131a47feb1be5610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616045
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158227}
[Screen Capture] Remove Android screen capture.
There is no way to activate this feature now, or in the near future,
so it is unused code.
Bug: 487935,1454640
Change-Id: I86a8efd6364a74ef56a3a7e01d887eda43d0c8fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616386
Commit-Queue: Mark Foltz <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158226}
[Passwords] Add check icon to cross-device generation experiment
Screenshot: http://screen/6kFVc9ARkJLgpDv
Mock: http://docs/presentation/d/1X2WK0h3p3F9pTYyIZM7B7WnSjDsPjmUs8Qmnn7N-WS0?resourcekey=0-lEqytWiaaau0BR8ZJtQt7A#slide=id.g21623eb465b_0_32
Bug: 1444070
Change-Id: I5d6028c811059c26d9d19758144fbac60be107bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614814
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Rafał Godlewski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158225}
print-management: add button to header
- Add a button to header for launching printer settings when flag is
enabled and there is at least one print job.
- Test button only shows in correct state.
Screenshot: http://screen/73mWtSiUiXVLChk.png
Bug: b:283119650
Test: browser_tests --gtest_filter=*PrintManagement*
Change-Id: I3167ce19296dd839443ee26e994a71f53806ded4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613005
Reviewed-by: Gavin Williams <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158224}
Remove base_feature: none for DelegatedInkTrails
Have blink runtime features generate a base::Feature for Delegated Ink
Trails so that a killswitch exists.
Bug: 1454891
Change-Id: Ie3bf821b5da8ae55c66e32abe24a494dce526fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616552
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Sahir Vellani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158223}
Further DOM Parts hierarchy reorg, and connect Document to Parts
In implementing the connection between DocumentPart and Document,
it became apparent that there were other issues with the previous
hierarchy. Notably, Document owned DocumentPart, which was a Part,
which therefore had a |root| reference back to DocumentPart. That
made it impossible to require Part to always have a |root|.
This CL revamps the hierarchy once more, to this:
PartRoot (getParts, clone)
/ \
DocumentPartRoot Part (root, metadata)
/ \
NodePart (node) ChildNodePart (prev/next/etc)
With that, a Part always has a reference to its |root|, and the
DocumentPartRoot can be owned by Document and always non-nullptr.
This CL also connects DocumentFragment to DocumentPartRoot.
Bug: 1453291
Change-Id: Ic0f34d3572321cf12fb960d75243e05462c9fe84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604678
Commit-Queue: David Baron <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158222}
wallpaper: refactor loading online wallpapers
Move file operations for online wallpapers from wallpaper controller
into a new class called OnlineWallpaperManager which handles:
* Loading an existing online wallpaper from disk by looking up the file
path based on its url.
* Download and save online wallpapers to disk.
* Load the preview image of an existing online wallpaper.
BUG=b/259730933
TEST=ash_unittests --gtest_filter="WallpaperControllerTest.*"
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I7601bef17b5b8483c0970d3aae8a8c5304569e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4515015
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Jeffrey Young <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158221}
[reviver] Fix android replica broken by jammy migration
Select jammy dimension for the android-x64 replica runs,
in line with the available bots.
Bug: 1412588
Change-Id: Iae1f171d2a1a0beba82cf7354a2673296566f641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615090
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Auto-Submit: Mateusz Zbikowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158220}
Automatic update from google3
Automatic update for 2023-06-15 UTC
Change-Id: I80164bd54c786156dd60368866b30c67ea0ff445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617974
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158219}
[SSM] Choose one process to profile on Android
Previously we were profiling all processes, when profiling is enabled
using VariationGroup, which results a performance hit big enough to
show DAU drop on finch dashboard.
This CL adds a mechanism to pick one particular process to profile
if profiling is enabled, so that the impact on performance is reduced
for users which has profiling enabled.
Bug: 1430519
Change-Id: I115a1c0ff82350fcfe28d0a84e1a5d225a2d9d67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594839
Reviewed-by: Deep Roy <[email protected]>
Commit-Queue: Charlie Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158218}
[ICU] Migrating ICU from 72.1 to 73.1
ICU73 release note https://icu.unicode.org/download/73
CLDR43 release note https://cldr.unicode.org/index/downloads/cldr-43
ICU 73 migration diary
https://docs.google.com/document/d/1_c9mnV7rkUcBCvy7jJGSWm0-48H8fy74zObtzjZ3fFk
Bug: 1434138
Change-Id: Ib4126860a6db79bcfb12d7c9e5f872b75236dac4
Binary-Size: Size increase is unavoidable (see above)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615449
Reviewed-by: Frank Tang <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: David Yeung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158217}
Enable WebRTC tests on Lacros.
These tests pass for me locally after 30 runs of each variant.
The addition of the filter for these tests came from the original
landing of the Lacros tests filter file that claimed to only disable
consistently failing tests:
https://chromium-review.googlesource.com/c/chromium/src/+/2340264
As a result, I don't think these are disabled because they're flaky.
Change-Id: I4ccea5a314ec38620bd82851e05f091cccfbb080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616685
Reviewed-by: Sven Zheng <[email protected]>
Commit-Queue: Brett Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158216}
cros: Add auth events for reporting
Add auth events for entering password change flow and online GAIA
sign-in to `AuthEventsRecorder`.
Bug: b:278694020
Change-Id: Ie5250a2c0d322656496134d6222f3ae6068e94bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614687
Commit-Queue: Anastasiia N <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158215}
[CSC] Show appropriate sign-in promo on auth errors
Before we were triggering sign-in promo in all cases. This cl changes it to trigger fix-your-auth promo when the auth is failing.
The CL also makes companion page handler listen for events to auth issues to refresh csc.
Bug: b/286401449
Change-Id: I884fa3e0069a3aa620cb67ede8d8121c1a6499e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618010
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158214}
IncognitoModeAvailability: Add iOS to supported_on platforms for Forced
The 'Forced' option is supported on iOS but it's missing from the
supported_on list for the option. According to discussion in
b/286979646, it works on iOS.
Bug: None
Change-Id: I21374a9d21d542e4bfebd4d2d72260c8cd7bfb98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614586
Reviewed-by: Tina Wang <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Commit-Queue: Sparik Hayrapetyan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158213}
Suppress "Open Incognito Tab" pedal test in Incognito mode.
This scenario does not work because the user is already browsing
incognito.
Bug: 1434836
Change-Id: I127caa00c05765bfaada42a713b5bedb14db7d0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617054
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158212}
infra: Move a number of builders to jammy
This moves:
- linux-rel-ml
- tricium-clang-tidy
- linux-clang-tidy-rel
- linux-chromeos-clang-tidy-rel
- Afl Upload Linux ASan
Bug: 1412588
Change-Id: I441565492c7512697b722df05773576c8de751f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616394
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158211}
[wptrunner] Remove `-v` flag for Android targets
[0] consolidated run_wpt_tests.py's lower two verbosity levels, so the
existing `-v` in the wptrunner Android targets became more verbose than
desired. This CL corrects that oversight, following up on [1].
[0]: https://chromium-review.googlesource.com/c/chromium/src/+/4198725/8/third_party/blink/tools/run_wpt_tests.py#253
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/4598972/comment/34dc31ec_3133bd0e/
Bug: 1344704
Change-Id: I1687b9b8e69ceab2a3adcd4a86f7e1de83fb8513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617127
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158210}
Remove User-Agent reduction disable override on WebView
User-Agent Reduction phase feature flags were used to control user-agent reduction phases in Chrome components/embedder_support, WebView has its own GetUserAgent API on AwContentBrowserClient.
This CL removes the unnecessary disabled overrides for user-agent reduction phase feature flags.
Change-Id: I20392b28d46e9c84803a4cd7684d3380318244d8
Bug: 1258063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614330
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Victor Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158209}
Added screenshot companion story.
This allows for the taking and logging of screenshots of companion with different websites.
Change-Id: I4f7cfd9e361402282a6ecec71c330e80e98125aa
Bug: b:273308580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612169
Reviewed-by: Wenbin Zhang <[email protected]>
Commit-Queue: Marco Georgaklis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158208}
[discardable_memory] Clean up old unused features
This CL removes old unused features that were never launched, and
removes the associated code paths and tests.
In the case of |kReleaseDiscardableFreeListPages|, there were
performance regressions on Windows.
In the case of |kShorterPeriodicPurge|, the shorter period didn't make a
noticeable difference in memory usage.
In both cases, the expected savings were relatively small overall and
not worth pursuing further.
Change-Id: I83d607c56d26fb4736e082b5bebe7b4711888aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615167
Reviewed-by: Benoit Lize <[email protected]>
Commit-Queue: Thiabaud Engelbrecht <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158207}
Roll devtools-internal from 6f2e537ad99f to ab7c234c7fbf (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/6f2e537ad99f..ab7c234c7fbf
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e24c5c4f91de127f6278041cddc77b7cf549ffdc..d0621c7ea63e6eee1eb576b1ff6e4db3a205d88e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ie7d4c2bace6bb770bb04921cfb4b51a4c04de936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616652
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158206}
Dictation: Improve autoclick interop test
This change improves the Dictation with Autoclick test so that we also
verify that Autoclick works when Dictation is on.
Bug: b:259353214
Change-Id: Id9dcf40e2850f9f8c8993749dd20c76359a63a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607158
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158205}
[password manager] Polish passkey card UI
Polish the passkey card UI so that it matches the mocks.
* Add passkey card missing strings.
* Remove `note` as we are dropping it for passkeys.
* Add passkey icon.
UXW review:
http://go/passkeys-in-chrome-pwm-uxw
Screnshot:
https://storage.cloud.google.com/chromium-translation-screenshots/6ecd65cd81c74c71571ffd5537140dbfd329382a
Design doc:
https://docs.google.com/document/d/1Ox_VBGNO-Ff9bcP97FUMcN15Xtfn_sz0_WuDe3ujbwA
Bug: 1432717
Change-Id: Ie2d239d831ab0e8636f15a1985d839a942fc080e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606325
Reviewed-by: Vasilii Sukhanov <[email protected]>
Auto-Submit: Nina Satragno <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Commit-Queue: Nina Satragno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158204}
Change DIR_GEN_TEST_DATA_ROOT to point to generated files
A common pattern in test is to access build-intermediate files directly in <outdir>/gen/. This is often generated js files and proto descriptors. On platforms that "package" tests (fuchsia), these files end up at the same place as <outdir>/.
This results in callsites doing:
#if fuchsia
DIR_GEN_TEST_DATA_ROOT
#else
DIR_GEN_TEST_DATA_ROOT + "gen"
This CL:
- Migrates DIR_GEN_TEST_DATA_ROOT to DIR_ASSERTS, which
is roughly $root_out_dir (<outdir> on most platforms), to find (test) binaries.
- Repurposes DIR_GEN_TEST_DATA_ROOT to roughly $root_gen_dir (<outdir>/gen on most platforms). This is used to find files generated during build (e.g. js files and proto descriptors)
AX-Relnotes: n/a.
Change-Id: I5c224f052e177628397c4231e0a4ee9cbea46427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610082
Reviewed-by: Wez <[email protected]>
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Owners-Override: Wez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158203}
Add UMA to track SubresourceResponseStarted IPCs sent.
Captures the number of times RenderFrameHostImpl is notified due to
starting a subresource response by RendererFrameImpl to compare it with
the number of times it was deemed unnecessary due to the
kReduceSubresourceResponseStartedIPC feature.
Bug: b/257281761
Change-Id: Ib01648e038e581e6441bc3f01684b3b5e5d02a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614543
Commit-Queue: Aman Verma <[email protected]>
Reviewed-by: Luc Nguyen <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158202}
cros-next: remove box shadow on hover and active
For CrOS dynamic colors, cr-button should not have a hover shadow.
Screenshot: http://screen/9r2GogvGxhJxqHB (static)
Screenshot: http://screen/37TAMcKov9SZyts (gif)
Bug: b:284337641
Test: Manual verify UI.
Change-Id: I9af77b36dbc71bc551684d32223370eb30713574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616787
Reviewed-by: Wes Okuhara <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158201}
Exo: Fix dangling ptr in WaylandDisplayHandler
This CL removes DanglingUntriaged mark from wl_resource held in
WaylandDisplayHandler by resetting handler before wl_resource in
WaylandDisplayObserverTest.
Bug: 1455022
Change-Id: Ia3c91a5beebce2c4c6332b7dd5760633cb172078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617992
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Eriko Kurimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158200}
Rename SkPromiseImageTexture to GrPromiseImageTexture
In http://review.skia.org/710679 Skia moved and renamed this type.
It additionally moved SkImages::PromiseTextureFrom* to
include/private/chromium/SkImageChromium.h, so the one file that
used those APIs has been moved.
Some of the existing #includes seemed unnecessary, so I removed
those.
Bug: skia:14317
Change-Id: I34fac7bbfa85d3c668b6e8ed6f70e6685aae05b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616508
Auto-Submit: Kevin Lubick <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158199}
[iOS] Clean up Price Tracking Button UIButtonConfiguration Work
Code within the feature flag guard was a little messy due to
experimentation. Setting the paragraph style isn't the proper way of
setting lineBreakMode within a UIButtonConfiguration. The right way
is by setting the property which is done already. Also removing the
available guards since we bumped the min iOS deployment target.
Bug: 1418068
Change-Id: I5e85059ce16980cefe2fc8062f009f4eb73bf6e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614989
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Joemer Ramos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158198}
[ios] Fix form controls tests
Previously, we'd used a hard-coded default width and height of 800x600
and this caused scaling issues. The problem was that the tests do not
supply a viewport meta and since the default width was smaller than
the legacy fallback width, it would expand out to 980 and then get
scaled back to 800 to fit on the screen, shrinking the controls.
It's curious that this works on Android, but it seems that on that
platform, we return the native size of the display rather than DIP
(eg, 1440x2170 when emulating a nexus 6), so we wouldn't hit this
issue. Rather than do the same thing and potentially confuse future
readers of the code, we'll supply a larger, test-only size.
Another approach would be to supply the viewport meta for these tests,
but changing the size potentially addresses this issue for a wider
swath of tests and prevents confusing errors in the future.
credit: thanks to bokan@ for pointing me at sources of viewport
scaling and suggesting debugging approaches, msisov@ who suggested
looking at screen ios (which did turn out to be a source of DSF
issues and was useful in the preceding patch -- crrev.com/c/4600124),
and dtapuska@ for info on DIPs and coordinate spaces.
Bug: 1411704,1413706
Change-Id: If74540500278847353d6bb834ce62c4216258312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615623
Commit-Queue: Ian Vollick <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158197}
Clean up child history deletion code
This is no longer needed, now that supervised users are not prevented
from deleting their history directly within Chrome.
Bug: b/251192695
Change-Id: I18c615b2130e4cc07c56fa6a90e96c129f14d5fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604310
Reviewed-by: Aga Wronska <[email protected]>
Auto-Submit: James Lee <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: James Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158196}
[ios] Remove kDestroy type and add kSelectionOnly type to WebStateListChange
This CL removes kDestroy from WebStateListChange and adds kSelectionOnly to WebStateListChange. This CL also adds a comment/a TODO comment to the kSelectionOnly arm.
We decided not to replace WebStateListDestroyed() with WebStateListChanged() because WebStateListDestroyed() is not compatible with other operations like an insertion. WebStateListDestroyed() is called when the entire WebStateList is destroyed, although other operations are called when one WebState is updated.
Instead, we add kSelectionOnly in this CL to replace WebStateActivatedAt() with WebStateListChanged() in another CL.
See "WebStateListChange class" section for more details (internal document):
https://docs.google.com/document/d/1I1QUZAexM1eMI2l2oriZl5GARrtofNI0SxHUPB4h-YE/edit?usp=sharing
Bug: 1442546
Change-Id: Ie1629a91efeaa8ac9220181a70536dd260d4031b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607449
Reviewed-by: Federica Germinario <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Asami Doi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158195}
Roll Skia from c0c74b433117 to 0b66c6928dcf (1 revision)
https://skia.googlesource.com/skia.git/+log/c0c74b433117..0b66c6928dcf
2023-06-15 [email protected] Add DirectWrite COLRv1 support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I9b172dab4e4845b8ebe777f0732d84443cff2df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616649
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158194}
Roll ios_internal from a8a4c64dc3d7 to f889903ef17f
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/a8a4c64dc3d7..f889903ef17f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1319852
Change-Id: Ib90a5fc1c260f739a275416e448ef66b9e1a554a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616442
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158193}
Convert RuleMetaData from a struct to a class
Converting to a class and hiding data members by default gives better
encapsulation, and allows the introduction of invariants on or
between members.
Providing a setter that accepts a ContentSettingConstraints
guides callers toward doing the "right thing" by default. For callers
that don't have a ContentSettingConstraints instance, individual setters
are provided.
Bug: 1450356
Change-Id: I65868a08b7a6f21f911b754abd8ab82d423ee07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608922
Reviewed-by: Joe Mason <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158192}
[Extensions] add chrome.offscreen.Reason.GEOLOCATION
Change-Id: Ie5241eb3f7fe184952953dfcb5c6afc56115e8e6
Bug: 1442046
Change-Id: Ie5241eb3f7fe184952953dfcb5c6afc56115e8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605111
Commit-Queue: Patrick Kettner <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158191}
[CSE] Make the feature flag accessible in chrome://flags
The new functionality of showing the Google Drive CSE files is hidden
under the “DriveFsShowCSEFiles” feature flags. After this change this
flag is available for the users in chrome://flags.
Note that changing the flag is not the only requirement for the feature
to work, it should also be enabled from the DriveFs side, which is
going to be done later.
Bug: b:277890245
Change-Id: If8b3b27465add2c3e89c5d59d7c3a158f2803959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615073
Reviewed-by: Steffen Seckler <[email protected]>
Commit-Queue: Oleg Davydov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158190}
[kiosk] Move AppSession to a field of AppSessionAsh instead of inheriting
This is the first step to later remove the browser specific AppSession
from the system/OS level AppSessionAsh.
Bug: b:273184211
Test: testing/xvfb.py tools/autotest.py -C out/Default --run_all chrome/browser/ash/app_mode/ chrome/browser/chromeos/app_mode/
Change-Id: If67366e6569a0a53102ab190bf707313b884b94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614676
Reviewed-by: Jeroen Dhollander <[email protected]>
Commit-Queue: Edman Anjos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158189}
SyncPrefs: Fix migration tests if kReplaceSyncPromosWithSignInPromos on
Before this CL, some of the tests only set the state of the feature flag
halfway through the test. This made the first half susceptible to
breaking when the flag got enabled by default.
Uncovered in crrev.com/c/4614643.
Bug: 1447020
Change-Id: I2f66db895f8f3202325d313020857dead1621ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615092
Commit-Queue: Marc Treib <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Quick-Run: Victor Vianna <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158188}
[IOS][Omnibox] Test Omnibox leading image
Cover Omnibox leading image with an Egtest.
The leading image changes based on the hilighted suggestion.
Bug: None
Change-Id: I73bfe01dd2b495aeb8470e8b8b7fe308f88a4ef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580147
Commit-Queue: Ameur Hosni <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158187}
[AutofillDataModel] Improve parsing expressions for landmark and admin2.
Bug: 1441904
Change-Id: I5b15460779ae521db6396ae0d1c966e497f67d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614594
Commit-Queue: Norge Vizcay <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158186}
Sort Blink features header, part 1/x.
This partially sorts the base::Features/base::FeatureParams. Part 2 will
sort the remainder of the header, and part 3 and onwards will sort the
.cc file.
This allows new base::Features to follow the sorting convention without
blocking on sorting the rest of this (very disorganized) file.
Bug: 1455020
Change-Id: I87949837757cdad1aec9546302dfbc851dd9fb63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616728
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158185}
Update V8 to version 11.6.164.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b08034e6..6a435063
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: If22aef0eb649e2cc1e0ca7cc495b6f95b1fb99b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615193
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158184}
iwa: Added a reader for .swbn of unknown ID
Added a new UnsecureSignedWebBundleReader. This class should be
used to read data from unverifiable signed web bundle. The unverifiable
signed web bundle is a bundle which ID we don't know. Because of that
verification of the file against the public key stored in the file
doesn't make sense as attacker can just resign the modified file
with their own key.
UnsecureSignedWebBundleReader should be used to get info about the
file, and NOT for general usage (e.g. reading responses).
Bug: b:277233728
Test: Added a unit test and executed already existing tests.
Change-Id: I68069fde95cf73b204c4a4fe27b0b0924afc3383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604542
Auto-Submit: Oleksandr Peletskyi <[email protected]>
Commit-Queue: Oleksandr Peletskyi <[email protected]>
Reviewed-by: Christian Flach <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158183}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686787311-be1f450c0532856968dd558fb5e6d49b587858a9.profdata to chrome-chromeos-amd64-generic-main-1686830699-ce1fbbdedb7ffca2c4ba20e3bcdc16ae7aa5aea8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I58cf6551c73e0d886f27176a292776345291db08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617913
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158182}
[Android] Re-enable NavigationHandlerTest#testLeft...Link_with..Transition
The disabled test has passed lately. Internally the flow takes exactly
the same path as the other variation. We may safely re-enable this
test.
Bug: 1426201
Change-Id: I8eeea98b5d9f4f67fd5a89fdd245703c1f3a3c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608652
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Lijin Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158181}
Roll WebRTC from bd14a73f81cd to 2fec64484f0c (1 revision)
https://webrtc.googlesource.com/src.git/+log/bd14a73f81cd..2fec64484f0c
2023-06-15 [email protected] Fix L1Tx target bitrate bug when the standard API is used.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1455039
Tbr: [email protected]
Change-Id: I3fed1976dec6f20b21fa5f55c162b9f622a207e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617235
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158180}
Reland "[Fixit] TabGridAccessibilityHelperTest"
This reverts commit cb6674cf1404c8d68b5227cd2b165a71122828b0.
Reason for revert: Another attempt to fix and wait for layout.
The issue only seems to be arm64 "real" devices so if this also
fails I might just DisableIf to abi is not arm.
Original change's description:
> Revert "[Fixit] TabGridAccessibilityHelperTest"
>
> This reverts commit 4c9139859ea621efe9764d8d3ed86ea41b3e2016.
>
> Reason for revert: failing tests on a couple bots, see crbug.com/1454747
>
> Original change's description:
> > [Fixit] TabGridAccessibilityHelperTest
> >
> > Fix failing tests which seem to stem from the following:
> > 1) Start surface vs Start Surface Refactor have different onView
> > parents. (Set one consistent flag set).
> > 2) If scrolled out of view getting the RecyclerView ViewHolder is
> > flaky.
> > 3) Small phones don't get span count = 3. Skip those sections.
> >
> > Additionally:
> > * Batch tests
> > * Throw ViewMatchExceptions to aid in debugging in future
> >
> > Fixed: 1368279, 1332995, 1318394, 1371231, 1332934, 1318376, 1306823, 1146575
> > Change-Id: Ica6d65fd4a53a7270aa5e066f0307ccb7772fe4d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604877
> > Auto-Submit: Calder Kitagawa <[email protected]>
> > Reviewed-by: Fred Mello <[email protected]>
> > Commit-Queue: Fred Mello <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1156890}
>
> Change-Id: I7535c81be60389627d64dde372380a18c24d2da0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615045
> Commit-Queue: Theresa Sullivan <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Calder Kitagawa <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157608}
Cq-Include-Trybots: luci.chromium.try:android-arm64-rel,android-pie-arm64-dbg
Change-Id: I86ae894c2e227f6dbc3886a81b8258996b4fd1be
Bug: 1454747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617508
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158179}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686819583-6d0c32f13046f97b4756e04300130d307330593b.profdata to chrome-win32-main-1686830367-1a943bf4cfd0b4cc44d096b24cc9531d65716a91.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Iadaf2eb10e39a9dfb02cffb7fde2e6890d587e88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618088
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158178}
[WebView] Rename metrics related to saving HWUI state
We will be tracking the duration of state saving more precisely for
ANGLE within ANGLE. This CL renames the existing metric for non-ANGLE
to make it specific that it is recorded only for non-ANGLE and changes
the metric for ANGLE to correctly capture the fact that it is measuring
the latency of making the ANGLE context current, which is a superset of
the latency of saving HWUI state.
OBSOLETE_HISTOGRAMS=Renamed to better capture semantics
Bug: 1378708
Change-Id: Idefba36c065e4134a775f2374aeddd8c0332d3f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614678
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158177}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686819583-3202f951d0204266ebded004de3a9427d0e06abf.profdata to chrome-win64-main-1686830367-797b9f9e508a178f2be37648ce76af1ca2ea905e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Iea0689ed4bb55b144ffa23c63de8b53fc6066969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617101
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158176}
Make offscreen_framebuffer_size test only
It's used only by a test harness, which don't really need it, but it's
not trivial change to remove it completely. This CL makes it only
available for tests and follow-up will update command decoder codes to
ignore it, so we can delete it later.
Bug: 1445523
Change-Id: I445edf2eed4fb003c480fd9baa495a0c42863fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615544
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Saifuddin Hitawala <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158175}
Remove empty OWNERS file
This file previously had Noel as an owner. However, an automated bot checks for
OWNERS who are no longer part of their group / affiliation.
The bot suggested Noel be removed.
This happened in
https://chromium-review.googlesource.com/c/chromium/src/+/4584922
I hesitated to remove Noel, since he may want to continue to contribute.
But I saw several others had already approved the bots changes, removing
him elsewere. I decided to go ahead with the removal and be willing to
reinstate him as OWNER the moment he decides to contribute again.
Anyway, now the OWNERS file is empty, which is silly. This CL removes
the empty OWNERS file.
Change-Id: I339bd68eaf18567be861b33cbec1fde4f3ddaf60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602254
Reviewed-by: Hans Wennborg <[email protected]>
Commit-Queue: Chris Blume <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158174}
CrxCreator: Open zip with SHARE_DELETE in the other case, too.
Bug: 1448891
Change-Id: Ia0fca859577da0d060d3e943dbe272d544e68a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614994
Auto-Submit: Joshua Pawlicki <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Joshua Pawlicki <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158173}
Topics API: Add new taxonomy
Bug: 1310951
Change-Id: I51fed5add811b5b1fb257d11d21f4d76dd2a0ffa
Binary-Size: Size increase is unavoidable
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608962
Reviewed-by: Yao Xiao <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Abigail Katcoff <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158172}
[WhatsNew] Fix What's New IPH
The IPH FET for What's New was mistakenly overwritten here https://chromium-review.googlesource.com/c/chromium/src/+/4021439
Change-Id: I5f4934fb38b0b7effabdf620a0008e4cc90344fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604047
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Cheick Cisse <[email protected]>
Reviewed-by: Daniel White <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158171}
[iOS][Toolbar] Add toolbar height delegate
ToolbarMediator is listening to changes that affects the omnibox
position, the omnibox can move between the primary and secondary toolbar
affecting their expanded/collapsed height. The BVC needs to react to
these changes.
This CL adds ToolbarHeightDelegate to communicate these changes to the
BVC. Later CL will add the logic handling the update.
Bug: 1454589
Change-Id: Idc42259a88fb05879011b22d4ef6b74a3afe6897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604066
Reviewed-by: Aliona Dangla <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Auto-Submit: Christian Xu <[email protected]>
Commit-Queue: Christian Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158170}
[Fixit] Fix nougat TabSwitcherMultiWindowTest
Issue logged in bug seems to only occur on Android api level 24 (Nougat)
The root cause of this is unclear, but Nougat was the first API level
to support multi window and it was significantly improved in O+ and
reworked in S. From the test-reviver bots the issue only appears to
occur on N.
Based on local testing. O also seems "safe".
What seems to be happening is that on N the activities are automatically
finishing. On other API levels the activities remain alive.
Bug: 1454902
Change-Id: Ief211e377fb7ad59722d1096b88f61260e788cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614995
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158169}
WebSocket: add wpt for sending 50 65K messages
http://crrev/c/3311025 introduced a bug when sending messages a multiple
of 65536 bytes in size over a connection with backpressure. This was
fixed in http://crrev/c/3404081 in January 2022, however no repro test
was added at that time.
Add a wpt to repro the issue and stop it happening again.
BUG=1454078
Change-Id: Icdc1dab66e58bab6eaabec84c0f53d5f17ca28e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612732
Reviewed-by: Kenichi Ishibashi <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158168}
Roll Fuchsia SDK from 13.20230614.3.1 to 13.20230615.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I754262c9ba3d001afa9885323c7a27fed0cce010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616539
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158167}
cros: Add CrOSMglruNoKVMOpt to field trial config
Update experiment name in CrOSMglruNoKVMOpt
Match the experiment name to the name in cl/539957641.
BUG=b:278886973
Change-Id: Ieca2b6e666adc4cf94bd2a4a033b3b9ab1825bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615723
Commit-Queue: T.J. Alumbaugh <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Quick-Run: Yu Zhao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158166}
Changed palette-mix() syntax to match color-mix()
Changed serialization of palette-mix() function to match color-mix().
Added alpha_multiplier parameter for interpolation.
Bug: 1400620
Change-Id: Id607a925e0d7a83dbd337f6cfe74ae867fe97c27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614844
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158165}
Automatic update from google3
Automatic update for 2023-06-15 UTC
Change-Id: Iae11a94e81b73b5f30fe129c4129520fe30bd2cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617956
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158164}
Android: Fix --concurrent-adb when set-app-links is required.
Some ADB commands need to run after install has finished, so this breaks
the steps into pre-install and post-install.
Bug: 1454876
Change-Id: Ia7adef81f80662c5d80091c9ee7e0f58ac840116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616663
Reviewed-by: Benjamin Joyce (Ben) <[email protected]>
Auto-Submit: Andrew Grieve <[email protected]>
Commit-Queue: Benjamin Joyce (Ben) <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158163}
Fix typo in Memory Saver flags
Bug: 1424220
Change-Id: I6e0980642b40832b45f5fc1fed5ee816206203a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615967
Auto-Submit: Gabriel Charette <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: Alison Gale <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158162}
[headless] Don't show <select> popup on Macs in headless mode
HTML <select> popup menus on Macs are implemented natively, so
they show up when running in headless mode. This CL checks if
the browser window is headless and prevents showing popup
menus if so.
Bug: 1446277
Change-Id: I3084a306f3f0377c8c9a58ce530414b5bac989fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617044
Commit-Queue: Peter Kvitek <[email protected]>
Reviewed-by: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158161}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686830367-79c577b9a90ba2b57b2179e94450336f5bf5bfa5.profdata to chrome-mac-arm-main-1686837510-ddeaeaaabd0e3bbecb293a97837a64bc1cb76663.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I7dd78ca980e6545c31dff0c4977a5b20e1d4e498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617837
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158160}
[iOS] Updated expiration of ContentSuggestions.Feed.Network Histogram
Updated the expiration date of the ContentSuggestions.Feed.Network.{}
histogram.
Bug: 1454145
Change-Id: I951f4b5881cb76276e89f9d70c9eb4326b955873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609189
Commit-Queue: Justin DeWitt <[email protected]>
Auto-Submit: Guillem Perez <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158159}
Remove unused getSaveFlowStartIconForBookmark.
Change-Id: Ibf257f278d0254dae19a2223031a910191cd1223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616049
Commit-Queue: Matthew Jones <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158158}
Updating trunk VERSION from 5834.0 to 5835.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: Ic07dd67da185dfe5cafa472845897ce7fc892cf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614342
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158157}
net/third_party/mozilla_win: add README.md
Bug: 1452938
Change-Id: I760c8c80eea4458c00dc6e15e9d43be63ad7e9d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614455
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Hubert Chao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158156}
ChromeRefresh2023: Render NTB above TabStrip with correct Padding.
Bug: 1399942
Change-Id: I61550786d7e73d8140f379f835414d7fa3c6adec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575791
Reviewed-by: Shibalik Mohapatra <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158155}
Roll Perfetto from 5d6f9249d1c7 to 8df69bbd2346 (3 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/5d6f9249d1c7..8df69bbd2346
2023-06-15 [email protected] Merge "[stdlib]: Add a table with flattened slices"
2023-06-15 [email protected] Merge "Migrate Scroll Jank plugin to V3 version of metrics."
2023-06-15 [email protected] Merge "Fix selection for debug and custom sql object tracks."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I573d44b2afaf8b2dde2822321770f8f490d1591d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617233
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158154}
Raise DOM exceptions if layer API is incorrectly used.
It's invalid to call `endLayer()` without a matching `beginLayer()`.
Likewise, calling `restore()` after `beginLayer()` isn't allowed.
Calling `save()` without a matching `restore()` outside of layers
however is allows to preserve existing functionality. We want to be
stricter with usage of the new layer API, at least at first, because
as soon as we start allowing degenerate API uses, Hyrum's law will
make sure we'll have to support these forever.
Bug: 1396372
Fixed: 1237275, 1403977
Change-Id: I76e83217fafe60248f8e4ae81ceafb1215dda9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4572867
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158153}
Skip Web test using WebGL on arm-based Macs
WebGL/Swiftshader does not run in VMs due to dependency on LLVM which
has bugs on Arm64, which we do not intend to fix.
New test added to the skip list:
fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html
Bug: 1451963, 1295317, 705125
Change-Id: I15b3b3b6d25f8d13fcdb5f2ccd877292e26438ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611307
Reviewed-by: Jean-Philippe Gravel <[email protected]>
Commit-Queue: Justin Novosad <[email protected]>
Auto-Submit: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158152}
[IOS][Omnibox] test append arrow button
Cover append arrow button with an egtest.
Bug: None
Change-Id: Ib214ec6a8f8a43015ee31fa8e139f3660c1eb288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573639
Reviewed-by: Stepan Khapugin <[email protected]>
Commit-Queue: Ameur Hosni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158151}
Revert "Add wayland api for rotating window internal focus"
This reverts commit b658374825cf4e6545f6d18646a6a963949f1c99.
Reason for revert: Revert again because revert of revert was submitted (https://chromium-review.googlesource.com/c/chromium/src/+/4616441)
Original change's description:
> Add wayland api for rotating window internal focus
>
> ChromeOS allows rotating focus between OS views and browser panes.
> Browser panes are no longer accessible from the OS since the ash/lacros
> split. This change adds a wayland API to allow ash to request lacros
> to rotate its pane focus and another API for lacros to notify ash that
> it has reached the end of its pane rotation.
>
> Bug: 1361120
> Change-Id: Ic82b7c5c57bb34e97c21f7b177f2f4a68a1b477a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548442
> Code-Coverage: Findit <[email protected]>
> Commit-Queue: Fred Shih <[email protected]>
> Reviewed-by: Mitsuru Oshima <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157874}
Bug: 1361120
Change-Id: I72318af4ad551c53bcc16ae4ecc334d2337d43d9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615888
Commit-Queue: Rubber Stamper <[email protected]>
Owners-Override: Roman Sorokin <[email protected]>
Auto-Submit: Roman Sorokin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158150}
Revert "Revert "Add wayland api for rotating window internal focus""
This reverts commit 2907748a4d1090b2c17178a78d6ad9fd9b17439f.
Reason for revert:
LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8778215141828330625
Sample failed build: https://ci.chromium.org/b/8778215141828330625
If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2F2.gy-118.workers.dev/%3A443%2Fhttps%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8778215141828330625&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2F2.gy-118.workers.dev/%3A443%2Fhttps%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4615887
Original change's description:
> Revert "Add wayland api for rotating window internal focus"
>
> This reverts commit b658374825cf4e6545f6d18646a6a963949f1c99.
>
> Reason for revert: WaylandAuraShellServerTest.AckRotateFocus
> WaylandAuraShellServerTest.RotateFocus are failing at Linux Chromium OS ASan LSan Tests (1) (see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/51767/overview)
>
> Original change's description:
> > Add wayland api for rotating window internal focus
> >
> > ChromeOS allows rotating focus between OS views and browser panes.
> > Browser panes are no longer accessible from the OS since the ash/lacros
> > split. This change adds a wayland API to allow ash to request lacros
> > to rotate its pane focus and another API for lacros to notify ash that
> > it has reached the end of its pane rotation.
> >
> > Bug: 1361120
> > Change-Id: Ic82b7c5c57bb34e97c21f7b177f2f4a68a1b477a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548442
> > Code-Coverage: Findit <[email protected]>
> > Commit-Queue: Fred Shih <[email protected]>
> > Reviewed-by: Mitsuru Oshima <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1157874}
>
> Bug: 1361120
> Change-Id: I2f9d52c01f2bfc3010ab5124759b68d19b9d5100
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615887
> Auto-Submit: Roman Sorokin <[email protected]>
> Owners-Override: Roman Sorokin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Roman Sorokin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158140}
>
Bug: 1361120
Change-Id: Ib9283e931d0b986ed7e4a783ffe37b281c91c43b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616441
Commit-Queue: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Owners-Override: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158149}
Revert "Use Force(In|Out)ProcessNetworkServiceinstead instead of feature flag"
This reverts commit 72fdd2a331942e394c3a0412ac312574e03e5fa6.
Reason for revert: crbug.com/1455052
Original change's description:
> Use Force(In|Out)ProcessNetworkServiceinstead instead of feature flag
>
> Since IsInProcessNetworkService() depends on various conditions in
> addition to features::kNetworkServiceInProcess, it is good to use
> the Force(In|Out) functions, which directly applies Is(In|Out)PNS, where
> code requires Is(In|Out)ProcessNetworkService.
>
> Change-Id: I9ee57e453c0a50ab4f24bc7033b9d75a6bc1af0b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593029
> Commit-Queue: Alex Moshchuk <[email protected]>
> Reviewed-by: Takashi Toyoshima <[email protected]>
> Reviewed-by: Alex Moshchuk <[email protected]>
> Commit-Queue: Yoichi Osato <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157955}
Change-Id: I092bfa3c151a51fd92ec2e1398f5abfbaedf5da3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615573
Owners-Override: Nicola Tommasi <[email protected]>
Commit-Queue: Nicola Tommasi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Nicola Tommasi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158148}
Revert "arc: Add ArcVmmManager browser test"
This reverts commit c1672f77f423e467faed3b56cffacbcfe6d8d642.
Reason for revert: ArcVmmManagerBrowserTest.Ctor fails on Linux Chromium OS ASan LSan Tests (see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/51771/overview)
Original change's description:
> arc: Add ArcVmmManager browser test
>
> This CL add a simple browser test of ArcVmmManager which only contains a
> Ctor test.
>
> The Ctor test verify no crash happenes during the long dependence chain
> (mostly because there are many system status observers).
>
> The follow up tests will be add soon.
>
> Bug: b:265383671
> TEST=ArcVmmManagerBrowserTest
>
> Change-Id: I8d81f991cf8500f1e8c82623dab153c024aa01f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614629
> Reviewed-by: Yuichiro Hanada <[email protected]>
> Commit-Queue: Shengsong Tan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1158025}
Bug: b:265383671
Change-Id: I0a2d4a9fb4a34eba088a2277fa5985e93b11a434
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615574
Auto-Submit: Roman Sorokin <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158147}
Revert "Wayland protocol to allow exo to rotate view focus in lacros - Client"
This reverts commit 60992525073a86d11ebf2bb1321e370bc611bc73.
Reason for revert: Revert because of the revert of the commit which this one is depend on (https://chromium-review.googlesource.com/c/chromium/src/+/4615887)
Original change's description:
> Wayland protocol to allow exo to rotate view focus in lacros - Client
>
> When focus rotation is requested for lacros widget, a rotate focus event
> is emitted from exo to lacros. These requests are fenced with a serial,
> which will prevent delay in processing from triggering multiple
> subsequent rotations in ash.
>
> When the client has reached the end of it focusable views, it will
> notify the the exo with the aforementioned serial.
>
> For this change, much of the rotate pane focus code had to be moved to
> the widget delegate. This is because the behaviour is now platform
> dependent.
>
> Change-Id: Ifbe31230578444cc35db8143fc5cfd0c14448b95
> Bug: 1361120
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4554431
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Hidehiko Abe <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157882}
Bug: 1361120
Change-Id: I1dd3fb241a6d5ea911fe1e64455275fe3f9f20a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614599
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Roman Sorokin <[email protected]>
Auto-Submit: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158146}
[Sync] Extend Sync.Crypto.CustomPassphraseKeyDerivationMethod...
Fixed: 1449722
Change-Id: I39fafd079cfe7f73ab5eab057ac08d571e2ad403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614566
Commit-Queue: Rushan Suleymanov <[email protected]>
Auto-Submit: Maksim Moskvitin <[email protected]>
Reviewed-by: Rushan Suleymanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158145}
[iOS] BookmarksHomeViewController is shutdown deterministically
BookmarksHomeViewController was disconnected on dealloc mainly (but not exclusively) through dealloc.
This is a leak risk, as it means the mediator may still be observing
other services while the app is closing.
Now, shutdown is also called:
* after a search, when creating a new stack of view
* when a view is popped
To ensure we do not forget any shutdown, `dealloc` now checks that
`shutdown` was called.
Bug: None
Change-Id: Idfc7b254881dd2babbc7f51b8ca65f7b50df5d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607280
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158144}
Updating XTBs based on .GRDs from branch main
Change-Id: Id54c6ea9df2d045f571f719a2556a2af33731f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615690
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158143}
[iOS] Prepare system flag to be moved
For downstream compatibility.
Bug: 1319852
Change-Id: Ib224c7a4f35f38adadd7761980792e3b94107470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614494
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158142}
[Sync] Add proto messages for PasswordSharingRecipients request/response
Bug: 1454712
Change-Id: I6ec5ee18d39282459d1b6f7d5f81cdac3a71ac3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613685
Commit-Queue: Rushan Suleymanov <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Rafał Godlewski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158141}
Revert "Add wayland api for rotating window internal focus"
This reverts commit b658374825cf4e6545f6d18646a6a963949f1c99.
Reason for revert: WaylandAuraShellServerTest.AckRotateFocus
WaylandAuraShellServerTest.RotateFocus are failing at Linux Chromium OS ASan LSan Tests (1) (see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/51767/overview)
Original change's description:
> Add wayland api for rotating window internal focus
>
> ChromeOS allows rotating focus between OS views and browser panes.
> Browser panes are no longer accessible from the OS since the ash/lacros
> split. This change adds a wayland API to allow ash to request lacros
> to rotate its pane focus and another API for lacros to notify ash that
> it has reached the end of its pane rotation.
>
> Bug: 1361120
> Change-Id: Ic82b7c5c57bb34e97c21f7b177f2f4a68a1b477a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548442
> Code-Coverage: Findit <[email protected]>
> Commit-Queue: Fred Shih <[email protected]>
> Reviewed-by: Mitsuru Oshima <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157874}
Bug: 1361120
Change-Id: I2f9d52c01f2bfc3010ab5124759b68d19b9d5100
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615887
Auto-Submit: Roman Sorokin <[email protected]>
Owners-Override: Roman Sorokin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158140}
Roll src/components/autofill/core/browser/form_parsing/internal_resources/ a1aed2b47..6bf4874af (1 commit)
https://chrome-internal.googlesource.com/chrome/components/autofill_regex_patterns.git/+log/a1aed2b477e3..6bf4874af337
$ git log a1aed2b47..6bf4874af --date=short --no-merges --format='%ad %ae %s'
Created with:
roll-dep src/components/autofill/core/browser/form_parsing/internal_resources --key autofill_regex_patterns.git
Bug: 1312026
Change-Id: I029ec37af8cdf2d32f1d85570ee2b682ac911f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615416
Reviewed-by: Bruno Braga <[email protected]>
Commit-Queue: Norge Vizcay <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158139}
[CloudAP SSO] Clean up feature.
The feature has been enabled by default since M113: crrev.com/c/4308012.
Bug: 1423062
Change-Id: I8a29eccbcbd5a2e7ff5ed8cdb9b8da361893f483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615226
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Igor Ruvinov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158138}
Roll ios_internal from 61afe575a930 to a8a4c64dc3d7
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/61afe575a930..a8a4c64dc3d7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I9b0151e19cbc6ecc0764adf6ba99f3ab22f4ddbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617595
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158137}
iOS about:flags: Overall flag for ReplaceSyncPromosWithSignInPromos
This adds a multi-value flag to enable either
ReplaceSyncPromosWithSignInPromos by itself, or enable this feature
along with all related "sub-features" (EnableBookmarksAccountStorage
and similar ones for other data types).
Bug: 1447010
Change-Id: I42589a863f62e7bb239a42e68e3a2065c4f97809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614590
Reviewed-by: Victor Vianna <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158136}
Update the feature flag expiration for RunOnOsLogin.
Bug: b/279737385
Change-Id: I9f0e298953d863f0cff8d93d2fbd7edf02848cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607441
Reviewed-by: Simon Hangl <[email protected]>
Commit-Queue: Sebastian Fiß <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158135}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686786983-569b5e54417c3f81b28dd8ea56f4ee1ab5382777.profdata to chrome-linux-main-1686830367-c711b23dff9239e0dc8c703545cf0c43e7be62cc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I031731a96ff4780c5d5459db7e5bc4ac71002d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617074
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158134}
Roll Skia from 12375fb6f3c8 to c0c74b433117 (1 revision)
https://skia.googlesource.com/skia.git/+log/12375fb6f3c8..c0c74b433117
2023-06-15 [email protected] [Fontations] Implement onGetVariationDesignPosition
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I63531ab2d3770215c3aa95a500fa6c1f6ff377e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616598
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158133}
[iOS][Toolbar] Revert toolbar update call in BVC
Revert `toolbarUpdate` call from the BVC. Changed in:
https://chromium-review.googlesource.com/c/chromium/src/+/4608592
as webState->WasShown is not called every time displayTabView is.
Bug: 1454964
Change-Id: I0987c8117743cd8788e2b0816af91bc7ca7c1f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618250
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Federica Germinario <[email protected]>
Auto-Submit: Christian Xu <[email protected]>
Commit-Queue: Christian Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158132}
VT: Update view-transition virtual test suites expiry dates.
[email protected]
Change-Id: I3c93c391074af515c1f9a629911a2d47a147b423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610695
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158131}
system-web-app: fix web app shortcut missing icons in sample SWA and tests
Sample SWA and test SWA didn't provide web app shortcuts menu item
icons.
This CL fixes relevant code and adds icons to WebAppInstallInfo, updates
SystemWebAppManagerInstallAllAppsBrowserTest.BasicConsistencyCheck to
verify shortcut menu item icon is provided for each shortcut entry.
Bug: 1427444,1417955
Change-Id: Ib08880900ea0f23e238602756af263a3749f99f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613592
Reviewed-by: Dibyajyoti Pal <[email protected]>
Commit-Queue: Dibyajyoti Pal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158130}
Roll WebRTC from 6bb12e573209 to bd14a73f81cd (1 revision)
https://webrtc.googlesource.com/src.git/+log/6bb12e573209..bd14a73f81cd
2023-06-15 [email protected] In VideoCaptureModulePipeWire lock around started_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I1a72c14c662726c7a6dd1437ac3bbf27e7a1758a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617835
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158129}
[Tech Debt][Android] Consolidate credit card icon dimensions across all surfaces
We have 2 standard sizes for credit card icons (40x24 and 32x20). Each
surface that shows the icon has a dedicated constant to store these
dimensions.
Consolidate all credit card icon dimension constants and add a utility
method `getCardIconSpecs` that the clients can use to get icon
dimensions.
This helps future work where we will fetch and cache credit card arts of
required sizes when Chrome launches.
This is a no-op.
Low-Coverage-Reason: This is a no-op.
Bug: 1384128
Change-Id: I615900be52d1f0083f9e1362b262b778e9470214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4521399
Reviewed-by: Friedrich Horschig <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158128}
[iOS][DefaultBrowser] Improvements to Tailored DB Promo metrics
In this CL:
- Split "Dismiss" into "Cancel" (by pressing "no thanks" button) and "Dismiss" by swipe down
- Record "MoreInfo" action
- Increment promo displayed count only when promo is shown
- Deprecate IOS.DefaultBrowserPromo.TailoredFullscreen.* histograms in favor of IOS.DefaultBrowserFullscreenTailoredPromo* histograms
OBSOLETE_HISTOGRAM[IOS.DefaultBrowserPromo.TailoredFullscreen.Accepted] = "Removed in favor of DefaultBrowserFullscreenTailoredPromo* histograms"
OBSOLETE_HISTOGRAM[IOS.DefaultBrowserPromo.TailoredFullscreen.Appear] = "Removed in favor of IOS.DefaultBrowserPromo.Shown histogram"
OBSOLETE_HISTOGRAM[IOS.DefaultBrowserPromo.TailoredFullscreen.Dismiss] = "Removed in favor of DefaultBrowserFullscreenTailoredPromo* histograms"
Change-Id: I37df1da022c9d786b316836a1a6e0f8f646c3103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594381
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Gayane Petrosyan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158127}
[base][test] Allow reusing TestFuture
With this CL we allow a TestFuture to be used multiple times,
as long as the previous value has been explicitly moved out/consumed,
which prevents the test from not realizing a value has been clobbered.
This eliminates the need for `RepeatingTestFuture` almost completely,
and we plan to solve the remaining use-case by introducing a new
`CallCounter` class.
Change-Id: I8f391c4ccfdba86c5deccf3bd84ea91e9c5a97c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4525896
Reviewed-by: Wez <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Jeroen Dhollander <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158126}
Exposed Reuse Check Utility from ChromeWebView
Exposed an API to allow reuse checks of CWVPasswords from the CWVWebViewConfiguration.
Bug: 1453748
Change-Id: Ia07ecbc3861bf3935204feeadd88a286c5d5c101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603683
Commit-Queue: Carlos Acosta <[email protected]>
Reviewed-by: John Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158125}
Add unit test for ChannelToEnum
ChannelToEnum is used to determine the channel of Chrome on ChromeOS.
Make sure that it is tested.
Bug: None
Change-Id: Iad7430e83a684cf6f843b92589f1df82e8debf09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614810
Reviewed-by: Roland Bock <[email protected]>
Commit-Queue: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158124}
Add extra logging to investigate inspector-protocol/network/multiple-headers.js timeouts
Bug: 1415385
Change-Id: I75447c750d5939717a773947d0b14914b912a331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615793
Commit-Queue: Jaroslav Sevcik <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158123}
Sync tests: various small cleanups
* Add [[nodiscard]] to many helpers that return a "bool success", which
really shouldn't be ignored.
* Add ASSERT_TRUE() to many tests calling those helpers.
* Add some TODOs around "sync" vs "signin".
Bug: 1455032
Change-Id: I0b9db5735fcc4743d3ba7e08ae169847f635a129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614931
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Rushan Suleymanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158122}
Don't use regexs to match string literals
CreateBoundaryPatternFromLiteral was using regexes to construct a regex
that matched a string literal. Moreover, there were seemingly no tests
for the complex quoting machinery that function was doing.
RE2 provides RE2::QuoteMeta, which should have been used here, but as
this is just matching a string literal, we can just use starts_with for
this. Similarly replace the other places where we were using regexes to
match constant prefixes.
Bug: none
Change-Id: I5c689ad7d5da99e048f557a32fa51e39f5ef881e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609325
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158121}
[WebAuthFlow] Propagate user gesture from extension information
Follow up on https://crrev.com/c/4542942.
Bug: 1445824
Change-Id: I166f68024efebf88bfbaa42da6f67d4ee8d397bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613787
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158120}
[UPMLocalPwd] Show the account name in the warning sheet
The Profile is passed to the PasswordMigrationWarningBridge. It's used
for retrieving the account name. The name will be shown in the
description of the option to start syncing on the second screen of the
migration warning sheet.
The account name will be the full name (in case of the accounts without
a displayable email) or an email (for other accounts).
If the user is not signed in, the default string will be displayed in
the option that offers to sign in and start syncing.
Bug: 1451827
Change-Id: Idf9e96f3a33d8b95c6e2f05306856048a123edcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4537564
Reviewed-by: Ioana Pandele <[email protected]>
Commit-Queue: Ivana Žužić <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158119}
Roll devtools-internal from c67c59d8a329 to 6f2e537ad99f (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/c67c59d8a329..6f2e537ad99f
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aba9462565f6cb6385d20e8007a614ff343ebce1..e24c5c4f91de127f6278041cddc77b7cf549ffdc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ice1da52e57f3fac28e5c46879f311636bdba5640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617100
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158118}
[iOS] Ensure ClearBrowsingDataManager shutdowns
Adding a CHECK in dealloc showed that the manager was not properly
shutdown.
This is due to the fact that the CLearBrowsingDataManager is used from
the viewController which was itself not explicitly stopped. As a
ViewController it should not have to be, but in practice it plays the
role of a coordinator. Thus adding to the view controller, and
ensuring this method is called.
R=jlebel
Fixed: 1429513
Change-Id: I8efd9769442fe048151b4f54cdad028858944ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614468
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158117}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686823086-2d7fb1447cb9ce07e04d1576b40246bc6756335b.profdata to chrome-mac-arm-main-1686830367-79c577b9a90ba2b57b2179e94450336f5bf5bfa5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I3354000020c86c59abeb2a705b317d830af5e8b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617232
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158116}
Enable History (incl. delete directives) in transport mode
This CL allows HISTORY and HISTORY_DELETE_DIRECTIVES to run in
transport mode, *if*
* HISTORY is enabled (kSyncEnableHistoryDataType), and
* kSyncEnableHistoryDataType is enabled.
Bug: 1448887
Change-Id: I331ed8f3ac1e9c423d802d43b7586c299804221d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604365
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158115}
[iOS] FirstRunCoordinator dealloc checks stop was called
Bug: None
Change-Id: I5ef0d6df5a957309d398b1e440c41bfad33ab241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609120
Commit-Queue: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158114}
Add basic test for EventLatency
This will add a simple test using the TestTraceProcessor for EventLatency. There will be follow ups with tests that include introducing janks.
Change-Id: I085b4b1663c0de96db12c81a9fa53c6a070df9c9
Bug: b/281674677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546461
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Stephen Nusko <[email protected]>
Commit-Queue: Rasika Navarange <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158113}
[compile hints] Memory leak (detection) fixes
1) Use v8::TracedReference instead of v8::Global, so that we don't
create unnecessary roots
2) Give V8CrowdsourcedCompileHintsProvider a chance to clean up before
leak detection
Bug: chromium:1406506
Change-Id: Ib6df8d6a002d0a9e2d39f52656712a9073493548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608421
Reviewed-by: Michael Lippautz <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158112}
[Fixit] Remove BakedBezierInterpolator
Interpolators.java fully replaces BakedBezierInterpolator which is
deprecated. This should save a small amount of memory/binary size
by removing the pre-defined arrays. All Interpolators are now shared
:D
This did require moving Interpolator.java for deps reasons, but that
should be fine.
Low-Coverage-Reason: Large scale change
Bug: 1454611
Change-Id: I9f05c10b61bcef49dcd74a076a52b4eaee370180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610025
Reviewed-by: Patrick Noland <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Basia Zimirska <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158111}
Support non-primary displays in Ash pixel tests
Expand Ash pixel tests to support comparing screenshots of displays that
aren't the primary display. This CL also includes the first use-case of
this new capability, which is a pixel test of the notification center
tray on a secondary display.
Bug: b:284313750
Change-Id: Ia8ddf6c59783527ba7e8566f611004acb316b014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597946
Reviewed-by: Andre Le <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: Elliot Tuck <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158110}
Roll Projector App from hYEUQKnrR609ieEmg... to hchZm_hzNx6tC8nyx...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306150100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/hchZm_hzNx6tC8nyxRGQikkZQDOinfHOwPFpo3jGi6UC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/222152900,b/239879326
Tbr: [email protected]
Change-Id: I91bedbaa4d04c7ebe56ecdfe73c990b20e24beaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617572
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158109}
[Nigori] Record metrics for key-pair bootstrap logic.
Bug: 1445056
Change-Id: I4a0fdee23c285a56c389594570c259783587bc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610753
Commit-Queue: Elias Khsheibun <[email protected]>
Reviewed-by: Maksim Moskvitin <[email protected]>
Reviewed-by: Rushan Suleymanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158108}
Roll src/third_party/cros_system_api/ 83f6fe429..78b08f5da (6 commits)
The CL alo removes the usage of reply.authenticated() as it is no longer used.
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/83f6fe429e00..78b08f5dae6a
$ git log 83f6fe429..78b08f5da --date=short --no-merges --format='%ad %ae %s'
2023-05-10 kendraketsui featured: Record active trials
2023-06-05 cassiewang shill: Add BSSIDRequested to WiFiService
2023-06-13 hardikgoyal cryptohome: Remove last of the deprecated authenticated bool
2023-05-31 eddyhsu system_api: add StreamIgnoreUiGains related call and signal.
2023-06-09 uekawa system_api: Add a directory for non-standard IPCs.
2023-06-09 rbock system_api: Remove dbus interface to authpolicyd from Rust
Created with:
roll-dep src/third_party/cros_system_api
Bug: b:262560281
Change-Id: I355ec29226b659c4d402755a28bc6e29cfa1f90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614516
Commit-Queue: Maksim Ivanov <[email protected]>
Auto-Submit: Hardik Goyal <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158107}
[iOS] HistorySyncCoordinator dealloc checks stop was called
Bug: None
Change-Id: I10b3c20b123391c1d6f094a143a2db99423b9a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608129
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158106}
[iOS] TangibleSyncMediator dealloc checks stop was called
Bug: None
Change-Id: I1a3c0a0df3cde0b59923817d4ede5979dcecc29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604103
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158105}
Update V8 to version 11.6.163.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1446fe82..b08034e6
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I96db63a976a5b4d7e454e3cc021f4385116a45d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614993
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158104}
Process manual HSTS preload removal for locksmithunit.[es, cat, and com].
Note: the domain owner was unable to set the HSTS Headers or use the /.well-known/ method of proving domain ownership. Proof of domain ownership was conveyed and verified via TXT records on June 14, 2023 at approximately 3:25 PM ET.
Change-Id: I44fbe6ff5b38a96ee4e2f7ab8d12db99fd04b2aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614889
Reviewed-by: Chris Thompson <[email protected]>
Commit-Queue: Ryan Dickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158103}
[SurfacePolish] Remove dependency of SingleTabSwitcher.
In this CL, we make Start surface can handle show and hide without
creating any controller: single|carousel Tab switcher module. This
works when both the Start surface refactor and surface polish are
enabled. These changes are behind a parameter "use magic space" of
feature flag "Surface polish".
Demo:
https://drive.google.com/file/d/1cqps1SDTZ2eP9lBKwJKUQUvtG_Tv32VQ/view?usp=drive_link
Change-Id: I0337ed03c1e4e72db1f645ca9ca539de0d2dbf87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602376
Code-Coverage: Findit <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158102}
Remove V8MapSpaceCompaction from fieldtrial_testing_config.json
Bug: v8:12578
Change-Id: If64efaf527b64ec44c533e92fa812cafa9b23fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614679
Auto-Submit: Dominik Inführ <[email protected]>
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158101}
Add field trial param for max attributions per event source
Change-Id: Iba778f57b4106ffb53c646a7b65381fc3714b136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614356
Auto-Submit: Andrew Paseltiner <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158100}
Change future_on to supported_on for Kerberos prefill policies
Launch is in M-116.
Bug: b:260522054
Change-Id: I92c507856687d885853ca7f673815c844d5b5bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614927
Auto-Submit: Michael Slutskii <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Reviewed-by: Felipe Andrade <[email protected]>
Commit-Queue: Alexander Hendrich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158099}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686808727-62ed679da10e037028653d7b3a586b4d194f8c6c.profdata to chrome-win32-main-1686819583-6d0c32f13046f97b4756e04300130d307330593b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I91e738509bf6cba5bfc64f04fc2c9415501514b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617070
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158098}
[Gardener] Disable CustomTabActivityTest#testMultipleActionButtons
Bug: 1455040
Change-Id: Ib291084bbedb81a5dae6af61a14a4d1edf13dbdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614472
Owners-Override: Nicola Tommasi <[email protected]>
Reviewed-by: Nicola Tommasi <[email protected]>
Auto-Submit: Nicola Tommasi <[email protected]>
Commit-Queue: Nicola Tommasi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158097}
Remove unnecessary RemoteDataHost struct in unit tests
Change-Id: I92b71661ad63d03c76a3afe72f42f38a7c1d159f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615258
Commit-Queue: Nan Lin <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158096}
Revert "Add checks for weird glitch and delay values to AUHALStream"
This reverts commit 4d4198bd98ccd939aa2725a38db911582eba8139.
Reason for revert: was only intended for dev
Original change's description:
> Add checks for weird glitch and delay values to AUHALStream
>
> This is not intended to reach beta, we will roll back in a few days.
>
> Bug: 1449671
> Change-Id: Iba2412b162a3a78e64e6c059d55a1066483c638c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604093
> Reviewed-by: Olga Sharonova <[email protected]>
> Commit-Queue: Fredrik Hernqvist <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1155535}
Bug: 1449671
Change-Id: I6232d96abd2762fcc34fbfef8dd3eb7749d512ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615410
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158095}
[iOS] Add EnableBookmarksAccountStorage to fieldtrial_testing_config
Explicitly disables EnableBookmarksAccountStorage for some tests and
adds it to fieldtrial_testing_config.json.
Bug: 1455018
Change-Id: I9f565310da9bd28061bfdd0958e4d06cbd161b84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607398
Commit-Queue: Boris Sazonov <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Auto-Submit: Boris Sazonov <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158094}
lts: Return stable channel for ltc and lts build
ltc and lts builds have previously always been stable builds, but
starting with M120 that will no longer be the case. Images will then
contain ltc-channel and lts-channel int /etc/lsb-release. Keep
reporting the channel as stable in Chrome.
In almost all components we want to continue to treat ltc and lts
equivalent to stable. This CL maintains the continuity with the previous
implementation and avoids potential pitfalls.
Later CLs will make it possible to identify if we are actually on the
ltc or lts channel similarly to extended stable. This will be used for
example for UMA metrics.
Bug: b:284256808, b:285578735
Change-Id: I905a6aa4764ab2d3adf0d45fd6bab6ac003f72c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614969
Reviewed-by: Roland Bock <[email protected]>
Commit-Queue: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158093}
Roll devtools-internal from 866d578a23ce to c67c59d8a329 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/866d578a23ce..c67c59d8a329
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85d5950706e67782dbfb61f08d388706be28e591..aba9462565f6cb6385d20e8007a614ff343ebce1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ie437536515c8ea5542c42948c068ada0cda50ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617095
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158092}
WinMFVideoCapture: Hold onto single IMFSampleBuffer when posting from CaptureEngine callback thread to main capture thread
If texture processing for some reason takes too much time, there will be a
growing queue of posted OnIncomingCapturedDataInternal() tasks, each holding to
an IMFSampleBuffer.
Eventually, that may lead to E_MF_SAMPLEALLOCATOR error, because too many samples
are on the fly.
This CL makes sure that only one task will be queued and its arguments are
updated with the latest IMFSampleBuffer, if a new one arrives before the task
executes.
Note: the discarded samples are not reported as dropped frames.
Bug: 1120900, 1430048
Change-Id: I1cc4239c9125d0e3b07e7a3587112219d254396e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614424
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Rafael Cintron <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158091}
Fix initialization of HidPolicyAllowedDevicesFactory
Add initialization of the keyed service factory
HidPolicyAllowedDevicesFactory to ChromeBrowserMainExtraPartsProfiles.
This fixes a dump without crash on Lacros.
Bug: 1455015
Change-Id: Ia2f6bd60db85f745536af8a5ee4ec4b580802424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615790
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Matej Aleksandrov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158090}
iwa: Move some tests from the install command to the install helper
This CL moves tests that are testing the install command helper's
internals into a new unittest file for the helper, while leaving tests
that test the install command itself as is. It also adds some new tests
for the command helper.
In a follow-up CL, we could look into refactoring the install command's
tests to take advantage of possibly mocking the install command helper
instead of the DataRetriever.
Bug: 1444407
Change-Id: Iaf23e6f89509b050524fe6dae9a7b6a1cdbd36cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593352
Commit-Queue: Christian Flach <[email protected]>
Reviewed-by: Sonja Laurila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158089}
Enable supervised user filter tests for desktop platforms
Bug: b:276874936
Change-Id: Ibf1193d57a623bcd499a6bf7b7efc912e638fc20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4572674
Reviewed-by: Nohemi Fernandez <[email protected]>
Commit-Queue: Tomek Jurkiewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158088}
Add tperrotta@ to bidimapper OWNERS
[email protected]
Bug: chromedriver:4226
Change-Id: I12491b73595728e72e409fbc8caf44eb1c8d0315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614518
Auto-Submit: Thiago Perrotta <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Commit-Queue: Mathias Bynens <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158087}
dlp: Add FPNM non IO browser tests
Adds some browser tests for crrev.com/c/4577203, for non IO tasks.
[email protected]
Bug: b:282663983
Change-Id: I119b59530354d0371cc10f9d2348fc7a51e9b854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614672
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158086}
[ios] Fix SetUpList signin crash when signin disabled
This change does three things:
* fix a DCHECK crash in TwoScreensSigninCoordinator when signin is
disabled by policy
* change SetUpList to not include the signin item at all when signin is
disabled when SetUpList loads
* observe changes to auth service status: if signin is disabled while
the SetUpList is loaded, it will be marked complete so that the user
cannot attempt to sign in
The crash was because SceneController was calling stop on the signin
coordinator before it was started, and TwoScreensCoordinator has a
DCHECK to ensure that the screenProvider gets cleared. The fix for this
is to only init/alloc the screenProvider on start.
Fixed: 1454526
Change-Id: I6cf913baa69a5ced8ec319aef908c843e3362667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610445
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158085}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686808727-8e6dc2e5c1a460920be6675afb1cf89d4f9aa229.profdata to chrome-win64-main-1686819583-3202f951d0204266ebded004de3a9427d0e06abf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I0f1af04362f0eed12855f67dc99f1aea879f6d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617093
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158084}
Use LacrosOnly for WebKioskAppLauncher tests.
Currently the tests use LacrosPrimary, which is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: I97b765c67e9113d68c6fc461ac767942cd5b6f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615105
Commit-Queue: Irina Fedorova <[email protected]>
Reviewed-by: Irina Fedorova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158083}
Use LacrosOnly for StartupAppLauncher tests.
The tests are using LacrosPrimary, which is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: Ieb831af54977559e93ed34d808618486376716cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610185
Auto-Submit: Hidehiko Abe <[email protected]>
Commit-Queue: Irina Fedorova <[email protected]>
Reviewed-by: Irina Fedorova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158082}
Use LacrosOnly for KioskLaunchController tests.
Currently the test is using LacrosPrimary, which is going to be removed.
Replace it with LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: I15cd9a29ecbc1ffdbf744b8b4ece4c8534999930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607690
Reviewed-by: Irina Fedorova <[email protected]>
Auto-Submit: Hidehiko Abe <[email protected]>
Commit-Queue: Irina Fedorova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158081}
Roll WebRTC from e109fb5b5d43 to 6bb12e573209 (1 revision)
https://webrtc.googlesource.com/src.git/+log/e109fb5b5d43..6bb12e573209
2023-06-15 [email protected] In VideoCaptureModulePipeWire split frameInfo_ usage
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I7d16c532641b1304a4b196aa79b74d74e5f9ee02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615678
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158080}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686815925-15c216ae8340545102bea248194c16d276faa8b1.profdata to chrome-mac-arm-main-1686823086-2d7fb1447cb9ce07e04d1576b40246bc6756335b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I2a8eac969f1e8337346261bf7e56b213b38c07a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617071
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158079}
[Permissions Policy] Enable CSP Wildcards
Followup to:
https://chromium-review.googlesource.com/c/chromium/src/+/4555927
Waiting for approval here:
https://groups.google.com/a/chromium.org/g/blink-dev/c/kSknKkiYlZU/
Bug: 1418009
Change-Id: I673280619df653db9c77c3bc5fcd512027e38152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574761
Commit-Queue: Ari Chivukula <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158078}
[Cronet] Write a custom responseInfoSubject
This makes the error messages even better. For example:
[FAILURE] org.chromium.net.UrlResponseInfoTest#testPublicAPI:
value of : urlResponseInfo.getAllHeaders().entrySet()
Main expected not to contain: Date=[Fri, 30 Oct 2015 14:26:41 GMT]
Main but was : [Date=[Fri, 30 Oct 2015 14:26:41 GMT]]
Will send follow-up cls to fix others.
Bug: b/280423217
Change-Id: If31ddcdea8fc6e73ce34ac7c1051aa4515aa1ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594477
Commit-Queue: Chidera Olibie <[email protected]>
Reviewed-by: Stefano Duo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158077}
dlp: Add FPNM unit tests
Adds unit tests for crrev.com/c/4577203.
[email protected]
dlp: Update Files desktop notifications
Bug: b:282663983
Change-Id: I8cf1deb98c4ceffa7b68f83e47708cfef76ffb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614944
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158076}
dlp: don't treat path as url
With requests having a myFiles path we do not get a component and than
use the path to check for rules. The path is created to an GURL, which
is ""/invalid for a path. This matched against a `*` rule.
Change-Id: I2669c28bdd8db12358ac31b7337a4500a6cbff6f
Bug: b/259179627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607305
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Daniel Brinkers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158075}
[Password Manager] Record whether details page opened during search
Change-Id: I043c6eac9ce5033672acd8d2d245169cb653fc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614585
Commit-Queue: Viktor Semeniuk <[email protected]>
Reviewed-by: Andrii Natiahlyi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158074}
Update V8 to version 11.6.160.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/777df509..1446fe82
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I54a6c741ab57a8b78cb9ba24e99a8711c082cd38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616332
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158073}
[Android][Autofill] Create EditorDialogViewBinder.
This CL creates EditorDialogViewBinder. The only state it manages is
the list of editor fields, which can change when user selects a
different country from country dropdown.
Change-Id: Ie5a4dcc0c8c119ee7bc0342c4c82d469504c7dce
Bug: 1435314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613987
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Timofey Chudakov <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158072}
Roll devtools-internal from 91157ea4ce7d to 866d578a23ce (2 revisions)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/91157ea4ce7d..866d578a23ce
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/98adf902f10fbf7c8a8c8d1025e2b821313b7427..85d5950706e67782dbfb61f08d388706be28e591
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1454926
Tbr: [email protected]
Change-Id: I783fcf798a9adfec2d2fa22d5acb7231b4e81eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615677
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158071}
Ship DocumentOpenSandboxInheritanceRemoval.
See [Intent-To-Remove]. It got LGTM3.
(This was made as part of the web platform security fixit week #10)
Doc: https://docs.google.com/document/d/1_89X4cNUab-PZE0iBDTKIftaQZsFbk7SbFmHbqY54os/edit
Intent-To-Remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/U1zHqauBLkE/m/h3siGSCKAQAJ
Fixed: chromium:1186311
Bug: chromium:1186311,chromium:1360795,chromium:1225195
Change-Id: I86e193a8a92a17dc2b712be49677f9873992e60b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598149
Auto-Submit: Arthur Sonzogni <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158070}
[iOS] Update manage accounts UI when viewed from account settings.
The manage accounts UI will be viewed from the new account settings
page for signed in non syncing users with:
- Updated title to be “Accounts on This Device”
- Blue text color of “Sign out” item
Changes are controlled by kReplaceSyncPromosWithSignInPromos.
Screenshots in crbug.com/1447017#c11
Bug: 1447017
Change-Id: I5a1242ca18d7358cdc831d91db968e81dc40a61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604363
Commit-Queue: Jood Hajeer <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158069}
Fixed EG tests for builders running iOS 16.5
Fixed: 1454030
Change-Id: Id684abec46d02a347ec82ec247c8dac7c8096ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610561
Commit-Queue: Petro Akzhygitov <[email protected]>
Reviewed-by: Christian Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158068}
dlp: Update Files desktop notifications
Updates DLP Files block notifications to the new UI, and adds warning
level notifications. For multiple files, the user can choose "Review"
which then opens a Files app and creates a FilesPolicyDialog over it.
For single files, the user can "Action anyway" directly from the
warning notification, or "Learn more" from a block notification.
All warning notifications also have a "Cancel" button which acts the
same as the warning dialog's "Cancel", i.e. aborts the action, while
the block notifications have a "Dismiss" button.
FPNM unit tests and browser tests added in follow up CLs.
Tested manually on a DUT.
[email protected]
Change-Id: I9fd5fa7add18ced7b4d707be02ad011e47b201f0
Bug: b:282663983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577203
Reviewed-by: Aya Elsayed <[email protected]>
Auto-Submit: Aida Zolic <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158067}
Ship BYOB Fetch
This CL changes the status of the ByobFetch runtime enabled feature
from "experimental" to "stable", so that it is turned on by default.
See the Intent To Ship thread at:
https://groups.google.com/a/chromium.org/g/blink-dev/c/I0X6IturxWA
Bug: 1243329, 1189621
Change-Id: I4d093a1d1e79674ceae8daa5ce2452431ccf4a9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600407
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Nidhi Jaju <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158066}
Roll Dawn from 66805b0c0e45 to 138d5b7b9f6f (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/66805b0c0e45..138d5b7b9f6f
2023-06-15 [email protected] [tint] Move 'using namespace' into anonymous namespace
2023-06-15 [email protected] Roll vulkan-deps from a3ea6d67d5de to 4f33c22decdf (6 revisions)
2023-06-15 [email protected] Roll ANGLE from 341dabf8e58e to 5a5f21f4a2e2 (11 revisions)
2023-06-15 [email protected] [ir] Make function an operand of return
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I722244fb2c2771b8f21f04cbdd3f6ead3dc327a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615674
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158065}
Roll Perfetto from c03807155ece to 5d6f9249d1c7 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/c03807155ece..5d6f9249d1c7
2023-06-15 [email protected] Print DOM durations with absolute precision
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Id4da3a3160d4d15de38601a3f020d5b0bee393e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615676
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158064}
Win audio rendering: exploratiry CHECK to see if device frequency is const
Bug: 1449671
Change-Id: I2bf2277acfd7d481b1050e873cfa65688afac115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615567
Commit-Queue: Olga Sharonova <[email protected]>
Reviewed-by: Fredrik Hernqvist <[email protected]>
Auto-Submit: Olga Sharonova <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158063}
Rename CanStopParentalSupervision capability
The CanStopParentalSupervision capability name does not reflect its
internal definition. For more info, see crbug.com/1425098.
Bug: 1425098
Change-Id: Ie6563ff66221c7aca713bcf300587c5b0a3d6293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614525
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Duong Dac <[email protected]>
Reviewed-by: Nohemi Fernandez <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158062}
Mark flaky dangling raw_ptr occurring on the CQ
his flakes were detected in CQ runs and reported in:
https://docs.google.com/spreadsheets/d/1k12PQOG4y1-UEV9xDfP1F8FSk4cVFywafEYHmzFubJ8/edit?pli=1#gid=1973430600
Change-Id: I3b89fdb2e7e5fe75d04db8726bca030dc34ce32e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613845
Commit-Queue: Pâris Meuleman <[email protected]>
Auto-Submit: Pâris Meuleman <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Owners-Override: Arthur Sonzogni <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158061}
Audio playback on Win: remove exploratory CHECK for glitch duration
Change-Id: I4cce1cfb1bf0392c374a46ae68551897604f307f
Bug: 1449671,1454693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614688
Auto-Submit: Olga Sharonova <[email protected]>
Commit-Queue: Olga Sharonova <[email protected]>
Reviewed-by: Fredrik Hernqvist <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158060}
[Affiliations] Simplify obtaining affiliated and grouped realms
This change replaces GetAffiliatedAndroidAndWebRealms and GetGroup with
GetAffiliatedAndGroupedRealms inside AffiliatedMatchHelper.
AffiliatedMatchHelper tests are fully rewritten to follow testing best
practises.
Bug: 1428539
Fixed: 1432264
Change-Id: I098318129302a828df252d354781242f8860e543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607387
Commit-Queue: Viktor Semeniuk <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158059}
[ios] Cleanup inside stub_browser_provider.h
Change-Id: I6b8b6858e358046694e9ad2bc8a950b54ae89f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614429
Auto-Submit: Federica Germinario <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158058}
🧪 Refactor some profiles pixel tests to reduce boilerplate
Moves the code related to initializing the `base::FeatureList` and
the command line into the ProfilesPixelTestBaseT base class
Change-Id: I394d3ef81bca5da0cb125478d39207b849e34f5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4579928
Auto-Submit: Nicolas Dossou-gbete <[email protected]>
Commit-Queue: Nicolas Dossou-gbete <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Reviewed-by: Jack Yammine <[email protected]>
Commit-Queue: Jack Yammine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158057}
Add WebGPU API to UKM metrics
The usage is less than 1% according to ChromeStatus:
https://chromestatus.com/metrics/feature/timeline/popularity/3888
UKM review: https://docs.google.com/document/d/1jj-T3dgPUqbunzzoGGHTlDzlN-qec8392Tl0ehWszTI/edit
Change-Id: I9b6044f9665d8de91c5c6aa2699841e4f6bdc912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614508
Commit-Queue: Fr <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158056}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686787311-c74832ada7c5d098e8dd346a15879f36f7763940.profdata to chrome-win64-main-1686808727-8e6dc2e5c1a460920be6675afb1cf89d4f9aa229.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I6a9d807a328cfe99749e569e549e59cefec5b917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617949
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158055}
[rust] Fix supersize for latest Rust layout.
Rust/gn integration nowadays specifies .rlib files as input to the final
linking process, but not as explicit dependencies for the solink rule -
instead as implicit dependencies, and then a separate rlibs = variable.
Extend binary size tools to understand this layout.
Prior to this change, Rust symbols were correctly listed in the
supersize output but listed against (No path). After this change, they
are correctly accounted to the correct .rs source code file.
Testing:
Steps performed as in https://crrev.com/2b6ee85aa1c7d521688fa38062afee187a217705
except the diffing command is nowadays
tools/binary_size/supersize save_diff out.size out2.size report-diff.sizediff
Bug: 1454085
Change-Id: Ib053335e5a3b35bece5e82d26800139fac50ea90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614644
Commit-Queue: Adrian Taylor <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158054}
graphite: Use ARGB readback fallback path for canvas capture
Ensure that the ARGB readback fallback path is used for canvas capture
with Graphite:
1) Set supports_yuv_rgb_conversion to false for Graphite and check that
in media::CopyRGBATextureToVideoFrame before issuing any calls that
will fail silently on the service side.
2) Add a new supports_yuv_readback context capability which is false for
Graphite. Make the client skip YUV readback when not supported.
Bug: 1450879
Change-Id: I9201221e18cac3f57f9e61dbc84af6488befc9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612331
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158053}
Differentiate task traces by comparing task addresses
Compare the addresses in the task trace instead of comparing the
output of |TaskTrace::toString| output. This significantly reduces
the time it takes to make the comparison and avoids timeouts when
running tests.
Change-Id: I6fb8352b52473aa0d3f532179039a918c08779d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603856
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Pâris Meuleman <[email protected]>
Auto-Submit: Pâris Meuleman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158052}
CCNS BFCache: add method to tell if the RFH main frame has CCNS header
There are quite a number of places we need to determine if the CCNS
header presents in the main frame resource, and there are more to
come.
Instead of calling `GetBackForwardCacheDisablingFeatures().Has(...)`
every time, it's cleaner to make a function for that.
Bug: 1228611
Change-Id: I63d97447792cc757406c090e8b83585ce0a47fd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603608
Commit-Queue: Mingyu Lei <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158051}
Roll devtools-internal from ec473e18fa6b to 91157ea4ce7d (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/ec473e18fa6b..91157ea4ce7d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Idb1f1c2dcbe4c5b3b4148aa8082929db43508ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617950
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158050}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686787311-692d06fe8d14272ac0cef43a916d8cb16470062e.profdata to chrome-win32-main-1686808727-62ed679da10e037028653d7b3a586b4d194f8c6c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I65d25f7240d5b9643c4a3b2933bf7a7f3db721e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617948
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158049}
arc: Add info log for vmm swap keyboard shortcut
This CL add log for easiler debugging in dogfood.
BUG=None
TEST=build
Change-Id: I9514be4c1898edc15e4e4ce30d3b24b6544481ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600588
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Shengsong Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158048}
Fix dangling signature extraction
Since RawPtrBackupRefImpl template arguments changed, the dangling
signature extraction is not working anymore on mac and windows.
Change-Id: I96211ad153f16c32e71e8321f06822889277b5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614588
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Pâris Meuleman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158047}
iwa: Add `expected_version` to debug info of install command
[email protected]
Bug: none
Change-Id: I2c05d22b53184a409fe764d48aaa6934ee681577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616065
Reviewed-by: Sonja Laurila <[email protected]>
Auto-Submit: Christian Flach <[email protected]>
Commit-Queue: Sonja Laurila <[email protected]>
Commit-Queue: Christian Flach <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158046}
camera: Deny the later comer access to the device.
Currently, if lacros and ash access the same device at the same time,
the access of first comer will be revoked. It makes users confused.
This CL changes this situation, and instead denies access to the later
comer.
Bug: b:231673571
Test: Manually test by opening camera multi times.
Change-Id: I059c2b6ffc63b9e2beffd85b7b90a8bc6c439438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598032
Reviewed-by: Wei Lee <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Sean Li <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158045}
arc: Add ArcVm swapping in/out observer on ArcVmmManager
This CL add observer on ArcVmmManager, notify observers based on
vm swapping dbus signal from the concierge.
TEST=ArcVmmManagerTest
Bug: b:285502224
Change-Id: I10804d2b16c370dd2012b7d5fbaee9204fee0f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616109
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Shengsong Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158044}
Roll WebRTC from 31b00983750c to e109fb5b5d43 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/31b00983750c..e109fb5b5d43
2023-06-15 [email protected] Roll chromium_revision 8af8fba80c..47e7a37749 (1157822:1157983)
2023-06-15 [email protected] Update WebRTC code version (2023-06-15T04:11:59).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Iab9ded4931259b82cf4ee6681461ba269f6dbeab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617089
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158043}
Roll ANGLE from 5a5f21f4a2e2 to e8a29d6cd7d7 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/5a5f21f4a2e2..e8a29d6cd7d7
2023-06-15 [email protected] Roll Chromium from bfc7c889fd6c to 7df45c601f1c (609 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I43cded4dc5190cabed09f63c18c565652d91ea8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617952
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158042}
[iOS] Show a centered account details item in Account Settings.
The new item consists of large centered account avatar followed by the
account name and email.
This CL:
- creates the new section and item.
- passes ChromeAccountManagerService and authenticationService from
coordinator to get the signed-in identity.
- introduces an update method for the new item and which listens to
changes from IdentityManager and ChromeAccountManager.
Screenshot in https://crbug.com/1447017#c7.
Bug: 1447017
Change-Id: Iea8476be4bf9c4db10bcf6c9d1004870aa1d9bcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604411
Commit-Queue: Jood Hajeer <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158041}
Cancel Lacros backward migration from OOBE
Add the Cancel button to the failure OOBE screen for Lacros backward
migration. When the user clicks this button call CancelMigration, which
deletes the Lacros directory and gives the user a fresh start without
browser data.
Bug: b/272017148
Test: testing/xvfb.py out/Default/browser_tests --gtest_filter=LacrosDataBackwardMigrationScreenTest.OnCancel
Change-Id: I10a125d26132f86009cd409fb733cc4f71343f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4365662
Commit-Queue: Jana Grill <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158040}
siso: reproxy handling for non-mojom_parser calls to action_remote
Bug: b/273407069
Change-Id: If8a2eb1f9da3df62afac87ca3527e1d2876816d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614793
Reviewed-by: Junji Watanabe <[email protected]>
Commit-Queue: Richard Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158039}
[wasm] Remove redundant call to {AbortCompilation}
Cancelling the `BytesConsumer` will trigger a state change, which will
call `AbortCompilation`. Hence the second (explicit) `AbortCompilation`
call can be skipped. It would return immediately anyway, because the
`streaming_` field is reset at this point.
[email protected]
Bug: chromium:1448858, chromium:1449546
Change-Id: I969b380615551017614110c81cb815e6793dfe68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608054
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158038}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686808727-43b51df9d212d96c922af4ce7dee8cdc7ce63aea.profdata to chrome-mac-arm-main-1686815925-15c216ae8340545102bea248194c16d276faa8b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I1e26c801a81b004f6c20ff5f5f48d5c82e08aca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615275
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158037}
Add feature to control the D3D11 video capture blocklist for testing
Bug: 1120900, 1430048
Change-Id: I557d84fb3cbf0731ea346ac707e1ec4a66e501dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615004
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158036}
Remove redundant checks in IsUserCryptohomeDataEphemeral
There is no need to check whether user is owner, guest or public account
in IsUserCryptohomeDataEphemeral because IsEphemeralAccountId already
does it.
Bug: b:284931456
Change-Id: I821a48110b80c5f1fb8a154bfee6fe51c46f7fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4572218
Commit-Queue: Oleh Lamzin <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158035}
Roll ios_internal from 41e1b97eb3ac to 61afe575a930
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/41e1b97eb3ac..61afe575a930
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Id40136c14db97c4727ddcd2295c12f2f1a4b5315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618087
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158034}
Use LacrosOnly for AppService metrics related tests.
Currently LacrosPrimary is used, but the mode is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: Iaf8c13c3ef7185104f9575b0e7dbe4f99113f2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615104
Reviewed-by: Maggie Cai <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158033}
[dPWA] Add WebAppDedupeInstallUrls feature flag
This CL adds a WebAppDedupeInstallUrls feature flag in preparation to
add install URL deduping for web apps, see follow up CL:
https://chromium-review.googlesource.com/c/chromium/src/+/4487437
Bug: 1434692
Change-Id: I3b633a1c451818544ef2cd0584975e1bc6866489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617531
Reviewed-by: Louise Brett <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158032}
AboutThisSite: Enable additional languages for Desktop
PFINGS languages are only enabled for Android currently.
Bug: 1433644
Change-Id: I51761aa8db36244c996319c1b86ab5f72bdb5e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615023
Reviewed-by: Filipa Senra <[email protected]>
Commit-Queue: Filipa Senra <[email protected]>
Auto-Submit: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158031}
Move IsEphemeralAccountId to UserManagerBase
to avoid code duplication in FakeUserManager and FakeChromeUserManager
inside IsEphemeralAccountId.
Also introduce new function IsEphemeralAccountIdByPolicy which takes
care about policy settings while IsEphemeralAccountId first handles
special cases such as owner, guest, stub, public account and only than
uses IsEphemeralAccountByPolicy.
The downside of this approach is that public accounts must be inside
users list to be ephemeral because there is no way in UserManagerBase to
give answer whether account_id is a public session account id.
policy::GetDeviceLocalAccountType function located in components/policy
which already depends on components/user_manager, so we cannot have
circular dependencies.
Bug: b:284931456
Change-Id: If07c4ff3ea6ccdd44d662e45e07369ef76d854a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4572467
Reviewed-by: Denis Kuznetsov <[email protected]>
Quick-Run: Oleh Lamzin <[email protected]>
Commit-Queue: Oleh Lamzin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158030}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686798095-650f0e67612e0c6a74a6dba84abe4549b0810acd.profdata to chrome-mac-arm-main-1686808727-43b51df9d212d96c922af4ce7dee8cdc7ce63aea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib76263383db83a1e778a185ff64c025a9a69158f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618007
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158029}
WebGPU: Add VideoFrame to GPUImageCopyExternalImage source
This CL adds support for VideoFrame in GPUImageCopyExternalImage source
following existing pattern for HTMLVideoElement.
Spec PR: https://github.com/gpuweb/gpuweb/pull/4178
Bug: 1453626
Change-Id: I7b049949a16ed00d4b2e51c6f9e3e551b7d6be0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604931
Commit-Queue: Fr <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158028}
[WebUI] Enable trusted types CSP for ShortcutCustomizationUI
TEST= Naviated to chrome://shortcut-customization and verified it
worked.
Bug: 1400799
Change-Id: Id133c5cc0a6514b6ea9238534a8ca450b6db8df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609287
Reviewed-by: Jimmy Gong <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158027}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686786983-0cf9fa63f2fe8797d637913232d5981e813f93d9.profdata to chrome-mac-main-1686808727-d8829d8c15c1f090186f4e32e424b1aa737a0cad.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8ad50f17ce2285f0cd8a1bdb121440cb1fbf4e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617967
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158026}
arc: Add ArcVmmManager browser test
This CL add a simple browser test of ArcVmmManager which only contains a
Ctor test.
The Ctor test verify no crash happenes during the long dependence chain
(mostly because there are many system status observers).
The follow up tests will be add soon.
Bug: b:265383671
TEST=ArcVmmManagerBrowserTest
Change-Id: I8d81f991cf8500f1e8c82623dab153c024aa01f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614629
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Shengsong Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158025}
[WebUI] Enable trusted types CSP for ConnectivityDiagnosticsUI
TEST= Naviated to chrome://connectivity-diagnostics and verified it
worked.
Bug: 1400799
Change-Id: Ic33db19c5ac70f331d4da48142966add6484d923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584076
Commit-Queue: Junguo (Jun) W. <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158024}
[KeyedServiceRegistration] Ensure Ash keyed service factory registered
Bug: 1412439
Change-Id: If68677858162d3cad33d32accc2d005aab88a112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615064
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158023}
Roll Skia from e2e0256d4c6a to 12375fb6f3c8 (2 revisions)
https://skia.googlesource.com/skia.git/+log/e2e0256d4c6a..12375fb6f3c8
2023-06-15 [email protected] Roll vulkan-deps from a3ea6d67d5de to 4f33c22decdf (6 revisions)
2023-06-15 [email protected] Roll ANGLE from 3a3a3c655a96 to 5a5f21f4a2e2 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I66f69881cc81391bc5891dafbfcb87ab44764a6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617216
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158022}
[DevTools] Temporarily disable test to unblock https://crrev.com/c/4577779
Bug: chromium:1318590
Change-Id: I3452f0b23afae7a98e14cc7c862e4b9661564e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614513
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Quick-Run: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158021}
[WebUI] Enable trusted types CSP for OSFeedbackUI and OSFeedbackUntrustedUI
TEST= Naviated to chrome://os-feedback and verified it worked.
Bug: 1400799
Change-Id: I352998ad1a1d05e958c19afa4956b13b89a279ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592890
Commit-Queue: Junguo (Jun) W. <[email protected]>
Reviewed-by: Xiangdong Kong <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158020}
Add ash-chrome back even if LacrosOnly for debugging purpose only
With this CL, even if LacrosOnly mode is enabled,
if --enable-ash-debug-browser is specified, ash-chrome app is added
back to launcher.
BUG=1448575
TEST=Tryjob
Change-Id: I5814671149f8e3ffa31669fc09653246c24b7a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614765
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158019}
[WebUI] Enable trusted types CSP for PersonalizationAppUI
TEST= Naviated to chrome://personalization and verified it worked.
Bug: 1400799
Change-Id: Iabf288d4f03f4550adb26fdb15b1372d965a9418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600732
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158018}
Update V8 to version 11.6.158.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/40c1e04f..777df509
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I1faf0e6e40e30e7fc9c5ea9684869273c4c50326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615509
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158017}
[WebAuthFlow] Allow navigation in popup window mode.
Navigation is still not allowed on New tab mode, which will fail the
authentication flow.
Bug: b/283036200
Change-Id: Ifb32ac027a190e219f9dea8bd70b9047a89e8a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604532
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158016}
Add Net.WebSocket.ErrorCodes.Http2
SETTINGS_ENABLE_CONNECT_PROTOCOL was initially introduced for
bootstrapping WebSockets with HTTP/2. When the settings parameter
is set to 1, it has been a good signal that a server supports
WebSocket over HTTP/2.
However, the parameter is now widely adopted to support other
protocols such as WebTransport and connect-udp. The existence of
SETTINGS_ENABLE_CONNECT_PROTOCOL=1 may not always mean the server
supports WebSocket over HTTP/2. To understand how likely WebSocket over
HTTP/2 could fail, this CL adds a histograms that records
net_errors dedicated for HTTP/2.
Bug: N/A
Change-Id: I25aaf1b26346b76b63e2b0055497c7edac2f4c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617549
Reviewed-by: Nidhi Jaju <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158015}
[a11y] Add a Feature for the UIA provider on Windows
Replace the `enable-experimental-ui-automation` switch with a
disabled-by-default `UiaProvider` feature. Users must now start the
browser with `--enable-features=UiaProvider` rather than
`--enable-experimental-ui-automation` if they wish to manually enable
the provider.
As a consequence, tests that added the old switch to the process command
line to enable the provider now use a ScopedFeatureList.
Bug: 845471,1453247
Change-Id: I92cd8248486b29aad8c887a0dd141da8b546d6b8
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604052
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158014}
[Frameworks roll] Roll to 540485909 piper revision
Change-Id: I82dd850c66f10c698318ae93c94155be629bdbf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614293
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158013}
Roll devtools-internal from bbd649c6a546 to ec473e18fa6b (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/bbd649c6a546..ec473e18fa6b
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cd66c0ca786bfff71d9ebcfc258a02edce71cb25..98adf902f10fbf7c8a8c8d1025e2b821313b7427
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I2b49ee005d340420ab6f16839ee32d542d7a1e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617201
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158012}
Fix DeltaFromCreationTime to handle null expirations correctly
If the expiration is null (zero), then the lifetime should also be
null (zero).
Bug: 1450356
Change-Id: I7db972ebc5e6a40bb1f472bf15eb7c75f4c88746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615525
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158011}
Remove stale WebGL 2 expectations
Autogenerated CL from running:
//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl2_conformance --jobs 4
Affected bugs for CL description:
[email protected]
Bug: 1240443, 1450355
Change-Id: I7b914f7b2ff47c8c799b5f0cb94c66a0e87889f1
Fixed: 1449922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617200
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158010}
Add Net.SpdySession.RstStreamReceived histogram
This is similar to Net.SpdySession.GoAwayReceived but for RST_STREAM
frames. In the httpbis working group mailing list, there is a question
whether HTTP_1_1_REQUIRED is sent in RST_STREAM or GOAWAY. The new
histogram will answer this question.
[1] https://lists.w3.org/Archives/Public/ietf-http-wg/2023AprJun/0158.html
Bug: N/A
Change-Id: I7246798e7bd62bd347fed184ddfb8c123691610a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615584
Reviewed-by: Nidhi Jaju <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158009}
Clamp audio glitches and delay reported by OS.
We want to clamp the values so that if the OS calculates them
incorrectly, they do not add significant noise to the glitch and delay
stats.
It is important that the stats do not overflow when they are
accumulated in WebRtcAudioDeviceImpl. Given the bounds in this CL, we
can calculate how long it would take to reach overflow in the absolute
worst case.
Delay: 2^63 / (24*3600*192000*10*(10^6)) = 55 days
Glitch duration: 2^63 / (24*3600*100*1*(10^6)) = 1067519 days
Bug: 1449671
Change-Id: I35cfaec78bbedb2b70882f63aab50593752a540c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607216
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158008}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5833.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: Ibdc7cbfd4b07fbb7199573523c82b6a267ca3800
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614893
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158007}
[PA] Add partition_alloc_optimized_debug to partition_alloc.gni.
Add partition_alloc_optimized_debug to PartitionAlloc to enable
PartitionAlloc-Everywhere on Linux debug build. This is the same way
as v8 does, i.e. v8_optimized_debug.
Bug: 1151236, 1449923, 1429450
Change-Id: I6abfbdb3d0ef11104ec7ccf9edcaef4e21ddb1f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599609
Reviewed-by: Bartek Nowierski <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158006}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686776368-7cda00e5876430834304032192950a4f1907f065.profdata to chrome-win32-main-1686787311-692d06fe8d14272ac0cef43a916d8cb16470062e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I15e42375221b4915a8979d4d4649573fd00bce72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615362
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158005}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686786983-5fabed47ff62b111146b33b9ba3fc21142dc59ae.profdata to chrome-win64-main-1686787311-c74832ada7c5d098e8dd346a15879f36f7763940.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Idddfff5202f467ff526751ec230b9cb1a065cef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616260
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158004}
Remove buffer-usage layout test
Replaced by a unit test in crrev.com/c/4607393
Bug: 1450174
Change-Id: I0da6e9fe8b7d647f0b502b68a50cb25bb60fc977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615027
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158003}
Adding a syncable profile pref for CVC storage and filling.
This value will be used to keep track of user preference on storing and autofilling of CVCs.
The default value of the pref is set to true/enabled.
Design doc- go/pay-autofill-cvv-storage-chrome
Documentation used for reference to add prefs- go/chrome-prefs-doc
Bug: 1450363
Change-Id: I7ed9542821403b3edd5a135580ec552c35f64785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569476
Reviewed-by: Dominic Battre <[email protected]>
Reviewed-by: Sujie Zhu <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Vipul Koul <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158002}
[js-code-coverage] Remove isDevToolsCoverage switch in files app tests
A previous incantation of JS code coverage "solved" the i18n replacement
issue by just not doing it, this no longer works the same since moving
to a System Web App. Abandon it for now until a more robust solution is
identified.
Bug: b:286131230
Change-Id: I7bc439955fc442c22cde5bacf8fd366c05a20eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616304
Commit-Queue: Ben Reich <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158001}
Wire up features::kPostQuantumKyber to QUIC
Change-Id: I0bd2d94780ac08f709f30a4aa2806ab62e98a96b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609488
Commit-Queue: Nick Harper <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1158000}
Make subresource load forced fallback if the rule matches.
This bring subresource load to forced fallback if
ServiceWorkerRouterEvaluator think the request should be handled by
network source.
Bug: 1371756
Change-Id: Ice8b199e46145b246929e89509b54094bd25d189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596442
Reviewed-by: Shunya Shishido <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157999}
Add a use counter for `execCommand`
Change-Id: I45b01307721293121f76ba4683ef2dc75ca510cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617536
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157998}
WebNN: Define XNNPACK Node for split MLOperator
This CL implements the DefineXnnNodeForSplit() method for WebNN split
MLOperator that defines XNNPACK split Node according to MLSplitOptions.
Besides, XNNPACK doesn't support "split into sizes" variant and we
decomposed the split into multiple XNNPACK Slice Nodes.
For unit tests, this CL implements SplitTest of MLGraphTest that checks
the compute results of Split operator.
Bug: 1273291
Change-Id: Ib85197468766263390a952449ae87bd8319d7859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582543
Reviewed-by: Jiewei Qian <[email protected]>
Quick-Run: Alan Kelly <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Bin Miao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157997}
[KeyedServiceRegistration] Latest fix based on DWC for android
Based on this query: https://crash.corp.google.com/browse?q=product_name+in+%28%27Chrome_Android%27%29+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+ComparableVersion%28product.version%29+%3E%3D+ComparableVersion%28%27116.0.5803.0%27%29+AND+EXISTS+%28SELECT+1+FROM+UNNEST%28productdata%29+WHERE+key%3D%27KeyedServiceFactories-factory_name%27%29&stbtiq=&reportid=&index=0
Bug: 1412439
Change-Id: I2ed375e26441900a1801bb6cb57cd3d9644b0b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614483
Commit-Queue: Ryan Sultanem <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157996}
Deflake database-refresh-view.js
Similar to delete-entry.js ocasionnally we update the same view multiple
times in a row. As the test didn't distinguish the views, it sometimes
didn't wait for all the views to be updated but was happy with 3 updates
to some views.
Bug: 1449648
Change-Id: Ia7acfb82ae1aa9a91a3f2d936664db9a0390a688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615883
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157995}
[autofill] Close autofill popup if context menu is open.
before: https://screencast.googleplex.com/cast/NDY5MzU4NTk1OTA1OTQ1Nnw2NWQ2ZjRjNi05MQ
after: https://screencast.googleplex.com/cast/NDY5NzUyMTc1OTcxNTMyOHwzMTliYTkxZS1kZQ
Bug: 1447387
Change-Id: I038d0b7711b4851847b695c402202a6ec4210417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584594
Reviewed-by: Scott Violet <[email protected]>
Auto-Submit: Bruno Braga <[email protected]>
Reviewed-by: Vidhan Jain <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Bruno Braga <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157994}
Revert "[A11y] Reland targeted cached property invalidation"
This reverts commit 3438f2a59daa31ad1d86777d73e1cff836cef570.
Reason for revert: Suspect causing blink_wpt_tests and blink_web_tests failure on Linux Tests (dbg)(1) bot.
Failed tests:
blink_wpt_tests failed because of:
external/wpt/css/css-contain/content-visibility/detach-locked-slot-children-crash.html
external/wpt/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html
external/wpt/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html
external/wpt/html/semantics/forms/the-input-element/focus-dynamic-type-change-on-blur.html
...7 more failure(s) (11 total)...
blink_web_tests failed because of:
accessibility/details-summary-crash.html
fast/events/drag-on-removed-slider-does-not-crash.html
fast/forms/range/range-type-change-onchange-2.html
html/details_summary/details-add-summary.html
...5 more failure(s) (9 total)...
First build failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/114032/overview
Sample log:
---
STDERR: #6 0x7fc01bd0361d logging::CheckError::~CheckError()
STDERR: #7 0x7fbffd21d08a blink::FlatTreeTraversal::AssertPrecondition()
STDERR: #8 0x7fbffd21cfd5 blink::FlatTreeTraversal::Parent()
STDERR: #9 0x7fbffd3c2a45 blink::FlatTreeTraversal::AncestorsOf()
STDERR: #10 0x7fbffd3d410e blink::(anonymous namespace)::NearestLockedExclusiveAncestor()
STDERR: #11 0x7fbffd3d3d17 blink::DisplayLockUtilities::IsInUnlockedOrActivatableSubtree()
STDERR: #12 0x7fbfedfabc4b blink::DisplayLockUtilities::ShouldIgnoreNodeDueToDisplayLock()
STDERR: #13 0x7fbfedf8b61c blink::AXObject::ToString()
STDERR: #14 0x7fbfedf8eccc blink::AXObject::Detach()
STDERR: #15 0x7fbfedf512df blink::AXNodeObject::Detach()
STDERR: #16 0x7fbfedf2d6a5 blink::AXLayoutObject::Detach()
STDERR: #17 0x7fbfedfce51a blink::AXObjectCacheImpl::Remove()
STDERR: #18 0x7fbfedfcd998 blink::AXObjectCacheImpl::Remove()
STDERR: #19 0x7fbfedfcdd74 blink::AXObjectCacheImpl::Remove()
STDERR: #20 0x7fbfedfce992 blink::AXObjectCacheImpl::Remove()
STDERR: #21 0x7fbffe6d16be blink::LayoutObject::WillBeDestroyed()
---
Original change's description:
> [A11y] Reland targeted cached property invalidation
>
> Relands the following CLS:
> * Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591.
> * Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc.
> * Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358.
> * Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559.
> * Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799.
> * Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8.
> * Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771.
>
> Fixed: 1446864, 1446550, 1434555, 1362758
> Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342
> Cq-Do-Not-Cancel-Tryjobs: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510
> Commit-Queue: Aaron Leventhal <[email protected]>
> Reviewed-by: Jacques Newman <[email protected]>
> Reviewed-by: Chris Harrelson <[email protected]>
> Reviewed-by: Philip Rogers <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157878}
Change-Id: Iefe59fe1933747346eda8827fd683f310d6cddb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615927
Reviewed-by: Takuto Ikuta <[email protected]>
Owners-Override: Takuto Ikuta <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Auto-Submit: Takashi Sakamoto <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157993}
Remove stale pixel expectations
Autogenerated CL from running:
//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite pixel --jobs 4
Affected bugs for CL description:
[email protected]
Bug: 1382332, 974380
Change-Id: Idf030306418e1b83d5ce831125832f4af88e5570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617199
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157992}
Fix colors for switch component
See discussion in b/280883304 for correct spec (also in go/cros-tokens).
Bug: 285217476
Change-Id: Ic50e8e0402796676f14155ffecaab43efa3e8e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613332
Reviewed-by: Zain Afzal <[email protected]>
Commit-Queue: Heidi Chan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157991}
camera: Make Lacros's behavior same as Ash when open camera.
1. If Ash fails to open the camera, the instance of VideoSourceImpl will
be released immediately. However, if Lacros failed to open it, the
instance of VideoSourceImpl will not be released until the webpage
refresh.
It causes one issue when we try to restart it again:
The life time of DeviceProxyLacros is controlled by VideoSourceImpl,
if VideoSourceImpl is not freed, DeviceProxyLacros is not freed,
either. It will conflict when we try to create a new instance.
2. VideoCaptureDeviceAsh does not do underlying cleanup. We should do
it when VideoCaptureDeviceAsh is freed.
This CL refactors CreateDevice callback and now a DeviceProxyLacros
instance should be created only when there is no error during creating
the device. Besides, StopDevice() is also called in Ash to update the active device map when Lacros stop a camera.
Bug: b:231673571
Test: Manually test by opening camera multi times.
Change-Id: Ied4ba2fb00076cf0f0bfd7ba6b7b7f7464ad0b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598130
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Sean Li <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157990}
Roll Catapult from 8b35870248c0 to 89fad9023d62 (2 revisions)
https://chromium.googlesource.com/catapult.git/+log/8b35870248c0..89fad9023d62
2023-06-15 [email protected] Create Sandwich Workflow Execution Client.
2023-06-15 [email protected] Tune mac m1 mini press benchmark attempt counts.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1416374,chromium:1419903
Tbr: [email protected]
Change-Id: I8f9d6f9bbc0235bfedffc64f0ecfa2483299da3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616530
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157989}
Add new fieldtrial experiments for ArcVmmSwap
The group change requires new config with new group name.
Bug: b:286791345
Change-Id: I88590bc709baaada55c2698fb309b1dfef6ba3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617533
Commit-Queue: Shengsong Tan <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157988}
Roll Skia from 2718866006d2 to e2e0256d4c6a (2 revisions)
https://skia.googlesource.com/skia.git/+log/2718866006d2..e2e0256d4c6a
2023-06-15 [email protected] Roll Skia Infra from ae32157135ff to 894306cf4c91 (3 revisions)
2023-06-15 [email protected] Roll SK Tool from ae32157135ff to 894306cf4c91
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Ic354b142a74b9ef17fcd0f12a5e19ed3a8061fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617068
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157987}
Remove BackForwardCacheDedicatedWorker flag.
It's been default enabled for over a year.
Fixed: 1146955
Change-Id: I7084cb094c03e55f74a67ef0b7a6e10708250795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607736
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Fergal Daly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157986}
Adding the feature flag for CVC storage and filling.
This flag will enable the storage and filling of CVC during autofill.
Design doc- go/pay-autofill-cvv-storage-chrome
Bug: 1450363
Change-Id: I38ac6fe6034f50f859eba73d89512005945c6cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569295
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Sujie Zhu <[email protected]>
Commit-Queue: Vipul Koul <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157985}
Fix problem with unmatched instantianated gtest type-parametrized tests.
Example output before change:
```
Additional test environment:
CHROME_HEADLESS=1
LANG=en_US.UTF-8
Command: out/Desktop/components_unittests --test-launcher-bot-mode --gtest_filter=ProtoFetcherTest.*:*/ProtoFetcherTest.*/*:ProtoFetcherTest.*/*:ProtoFetcherTest/*.* --fast-local-dev
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 96 parallel jobs.
Filter "*ProtoFetcherTest/*.*" would have matched: AllFetchers/ProtoFetcherTest/0.ConfiguresEndpoint
Filter "*ProtoFetcherTest/*.*" would have matched: AllFetchers/ProtoFetcherTest/0.AddsPayload
```
(note that second filter has mismatched slash).
Change-Id: Ie9a5df2746000468a96e8bf4a13194eff8bc4a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614966
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Tomek Jurkiewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157984}
siso: add mojo handling for rewrapper_to_reproxy
Bug: b/273407069
Change-Id: Idf21e2b20c296ed63b41169f30a0350558ad239b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617489
Reviewed-by: Fumitoshi Ukai <[email protected]>
Commit-Queue: Richard Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157983}
Implement ServiceWorkerRouterEvaluator::ToValue
For ease of showing the registered `ServiceWorkerRouterRules`, this CL
adds `ToValue` method to `ServiceWorkerRouterEvaluator`. It dumps the
stored rules with `base::Value`, which can be used for dumping as JSON.
Bug: 1371756
Change-Id: I81f74c5665cc882079af2164edea0169f24b4aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612951
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Reviewed-by: Shunya Shishido <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157982}
Add Lacros version of .variation-list.txt to upload exp IDs to feedback report
The current .variation-list.txt only contains ash experiment IDs, adding
a .variation-list-lacros.txt that contains Lacros experiment IDs.
Attaching the list to the feedback report will be done in another CL.
Bug: b:276679745
Test: Manual testing on DUT
Change-Id: I58f34b0ea513d4ed6ee935cd41691115f2881682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616303
Reviewed-by: Weilun Shi <[email protected]>
Commit-Queue: Bryan Yu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157981}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686786983-738d20a4da1d4edaf913b98d6dd5dafda9915f1f.profdata to chrome-mac-arm-main-1686798095-650f0e67612e0c6a74a6dba84abe4549b0810acd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Iec336410adfe9e1768c60374f6b9315f4cb61461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616434
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157980}
Fix ServiceWorkerRouterRules mojom traits.
Since the conversion forgot to emplace ServiceWorkerRouterNetworkSource,
it did not exist after the mojom conversion.
This CL fixes it.
Bug: 1371756
Change-Id: Ie9cf3229c9f659d30427c7d172d5f3d32693cd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612410
Reviewed-by: Sam McNally <[email protected]>
Reviewed-by: Shunya Shishido <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157979}
Roll earl_grey2 from 2e1fee1e765e to caea08a21d6a (1 revision)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/2e1fee1e765e..caea08a21d6a
2023-06-14 [email protected] Xcode 15 update
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I2244413cb701c41fda866b9774d3199172d51c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616432
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157978}
Roll Website from 3a2072ce6c0d to f79bff1e5976 (1 revision)
https://chromium.googlesource.com/website.git/+log/3a2072ce6c0d..f79bff1e5976
2023-06-14 [email protected] Update How-to-Chrome-Security-reviews header for better moma SEO
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ic39461974642493d387cb249fbd7d873f1014ca2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617748
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157977}
[OOBE] Fix TouchpadScrollScreen reverse scrolling
change the way we apply touchpad settings if IsInputDeviceSettingsSplitEnabled
Bug: b:287134999
Change-Id: I72539c267a9bed74d605c9daa68691c66a0bf67f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615785
Reviewed-by: Osama Fathy <[email protected]>
Auto-Submit: Brahim Chikhaoui <[email protected]>
Commit-Queue: Brahim Chikhaoui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157976}
Turn MirroringMediaControllerHost into an interface and add tests
Make MirroringMediaControllerHost pure virtual and move the implementation to MirroringMediaControllerHostImpl so that it can be mocked.
Add test cases to CastNotificationControllerLacrosTest.
Bug: 1453967
Change-Id: Id309ce57dac1127e5f970c66f182366aa27cbf04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603617
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: Benjamin Zielinski <[email protected]>
Reviewed-by: Ahmed Moussa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157975}
[MirrorSync] Enable FilesInlineSyncStatusProgressEvents by default
Fixed: b:272585066
Change-Id: I072124b66e1943e451100ffe91634562ea69bf67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612329
Commit-Queue: Ben Reich <[email protected]>
Reviewed-by: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157974}
Update sysroots
The previous roll didn't include https://crrev.com/1154041.
This is addressed in this CL.
Change-Id: I3fe6dc2d1a10f7175a87b1974f809663c71cd690
Bug: 1430962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617332
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157973}
Reenable empty network service
This CL reenables empty network service with
- introducing strict conditions to avoid the found crashes ([1]).
- add kRegisterEmptyNetworkService command line switch to launch the
service in the utility process correctly.
[1] https://crbug.com/1446571: Chrome_Android: Crash Report
ChromeContentBrowserClient::GetApplicationLocale
Bug: 1448414
Change-Id: If1b340de582c189cad11192d827e1923692e7001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569853
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Yoichi Osato <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157972}
Remove gnome-keyring
R=thestig
Bug: 355223
Change-Id: I6e78924b1f3a6c6731f1bfdad1509e3c703d894d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609704
Reviewed-by: Andrey Kosyakov <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157971}
Add libaom test data hook
This CL adds a configurable hook to download the full set of test data
for libaom. It is disabled by default.
Change-Id: I488e4169481b1f3c4d55d4cccc0b85f000cf081d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4498400
Reviewed-by: Wan-Teh Chang <[email protected]>
Commit-Queue: Wan-Teh Chang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157970}
Reland "Prerender: Add fieldtrial testing config for SpeculationRulesPrerenerMemoryLimit"
This reverts commit 204d2d73afffb1f1d9def04f664217c861a1eabc.
Reason for revert:
The compile failure seems unrelated to the original CL. It was fixed
before the revert:
https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20arm64%20Builder%20All%20Targets%20(dbg)/14573/overview
Original change's description:
> Revert "Prerender: Add fieldtrial testing config for SpeculationRulesPrerenerMemoryLimit"
>
> This reverts commit 1532d1db26fa9d21eb68d2b4943e377a7bbf03a6.
>
> Reason for revert: speculating that this change it the culprit for the tree closure https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20arm64%20Builder%20All%20Targets%20(dbg)/14572/overview
>
> Original change's description:
> > Prerender: Add fieldtrial testing config for SpeculationRulesPrerenerMemoryLimit
> >
> > This CL adds the fieldtrial testing config for
> > SpeculationRulesPrerenderMemoryLimit with a new acceptable percentage
> > (100%).
> >
> > Bug: 1382697
> > Change-Id: I04bc1a774c3cf95392cd7f1bca5f55bdf383c520
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613326
> > Commit-Queue: Hiroki Nakagawa <[email protected]>
> > Reviewed-by: Huanpo Lin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1157477}
>
> Bug: 1382697
> Change-Id: Ic5bbfe07bd308dab8a213f678cf1052f54c12f64
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614446
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Hamda Mare <[email protected]>
> Owners-Override: Hamda Mare <[email protected]>
> Commit-Queue: Hamda Mare <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157548}
Bug: 1382697
Change-Id: I0c0f60f9199b7ceb604ffe2fd264f063531689ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617467
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157969}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686776368-6ca2fc66232cc3994e1af56515074c7c4b2190aa.profdata to chrome-win64-main-1686786983-5fabed47ff62b111146b33b9ba3fc21142dc59ae.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Id0402d21bad659e92c4ca85fdb62bf2fdbdb3be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617196
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157968}
media: Media Foundation Clear Key CDM encrypted audio browser tests
Added new browser tests for audio testing:
- Encrypted audio only content
- Encrypted audio/video content
Handling no audio device scenario:
- Long-term solution: Implementing a null sink for no audio device
- Workaround:
a) Bypass creating any audio stream when any video stream is available
but no audio device in the `media_foundation_source_wrapper.cc`. Tested
video/audio content with no audio device first and verified the
playback ends at the end of the stream. If we refresh the page and try
to play again after enabling the audio device, the audio stream is
created and played normally.
b) For the audio only browser test, the test is expected to receive
kOnPlaybackError if no audio device. However, the audio/video browser
test will still run on the test machine since we just don't create an
instance of the audio stream in this case.
Build command:
```
autoninja -C out\Default browser_tests
.\out\Default\browser_tests --gtest_filter=MediaFoundationEncryptedMediaTest.Playback_EncryptedCencVideoAudio_Success --use-gpu-in-tests
.\out\Default\browser_tests --gtest_filter=MediaFoundationEncryptedMediaTest.Playback_EncryptedCencAudio_Success --use-gpu-in-tests
```
Bug: 1235887, 1442373, 1452165, 1453682
Change-Id: I16603a64713665577914cbbbcd481c41747835b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529006
Reviewed-by: Xiaohan Wang <[email protected]>
Commit-Queue: Sangbaek Park <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157967}
[Extensions] Address some code review comments from a previous CL.
This CL addresses two code review comments from crrev.com/c/4606253
that I forgot to fix before committing it.
Bug: 1449680
Change-Id: I6e90a1539035d0822737bc76e199c94c458bc15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617207
Auto-Submit: David Bertoni <[email protected]>
Commit-Queue: Devlin Cronin <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157966}
Reland "Avoid error-prone repetitive code in ImeService::IsFeatureEnabled()."
This is a reland of commit 7af8352750d498ba487c32e25cca5551b0f911fe
https://crrev.com/c/4542134 was reverted @ https://crrev.com/c/4569905 just as a pre-requisite to revert https://crrev.com/c/4541900 @ https://crrev.com/c/4567764. The latter has now been relanded verbatim @ https://crrev.com/c/4570044 so this can now be relanded verbatim, too.
Original change's description:
> Avoid error-prone repetitive code in ImeService::IsFeatureEnabled().
>
> Bug: b:218815885
> Change-Id: Id94edb001344926c632b3b20fe0dd5c59862b4d1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4542134
> Reviewed-by: Darren Shen <[email protected]>
> Reviewed-by: John Palmer <[email protected]>
> Commit-Queue: Bao-Duy Tran <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1148970}
Bug: b:218815885
Change-Id: I5697956000816e5eb2325e60862b213cdddedb2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596636
Commit-Queue: Bao-Duy Tran <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: John Palmer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157965}
Roll PDFium from e392794c0ec0 to 7b044178db44 (3 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/e392794c0ec0..7b044178db44
2023-06-14 [email protected] Clean up ShrinkObjectMap() methods
2023-06-14 [email protected] Document default type value in CPDF_Parser::ProcessCrossRefV5Entry()
2023-06-14 [email protected] Memoize RealizeSkImage() in CPDF_PageImageCache
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ifb1c932a4bccfaaeae578315caea56ed96eae564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616250
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157964}
Enable ExtensionControlHandler in the settings app
This CL fixes an issue where user-installed proxy extensions cannot be
disabled by the disable button in the ChromeOS settings app.
Please note that users can install browser extensions that controll the
internet proxy settings, and such an extension is displayed in the
internet settings page along with a disable button. Before this CL, the
disable button was not taking effect because the message handler that
disables the extension was not registered on that page.
Change-Id: I3b91fe9f9d5302a538def532d640700b21e7212c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610362
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Jun Ishiguro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157963}
Starting running cr23_*tests on the main bots.
This CL adds 'cr23_browser_tests', 'cr23_interactive_ui_tests',
and 'cr23_views_unittests' to all the main bots as a 1%
experiment. The three suites will still run non-experimentally
on the cr23-{linux,mac,win}-rel.
Bug: 1444855
Change-Id: Ia990c2d13fb787fc7faf3a1d057d859bf8717d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610907
Commit-Queue: Dirk Pranke <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157962}
arc: Prevent inconsistent of vmm swap request by racing condition
This CL add the check before sending real request to concierge in vmm
manager. This is needed because the preprocess of sending "enable"
request is much more longer than "disable", and the callback chain in
chromium is not easy to be cancelled.
TEST=ArcVmmManagerTest
Bug: b:285987652
Change-Id: I62be445aa35c45976033736771a498523930822b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603662
Commit-Queue: Shengsong Tan <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157961}
customization: Add table row item to device settings
Screenshot:
https://screenshot.googleplex.com/7e9KXJQEmipFMLf
spec: go/input-customization-ux on page 27
Bug: b/241965717
Test: browser_tests --gtest_filter=*OSSettingsDevicePageTest*
Change-Id: Ia6526445b8c4ec9c0366aaf9a6c05b4e8c16c33e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585291
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Yuhan Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157960}
Re-enable apps.Sharesheet tast test
PWA installs have changed since this test initially started failing, which may have addressed the issue.
Cq-Include-Trybots: luci.chromium.try:chromeos-amd64-generic-rel;luci.chrome.try:chromeos-kevin-chrome
Bug: 1346149
Change-Id: I4920bdb0c99346549ae4de04bfce0e7213a96b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617487
Reviewed-by: Tim Sergeant <[email protected]>
Commit-Queue: Melissa Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157959}
shortcuts: Update shortcut descriptions
Bug: b/216049298
Change-Id: I7f188e9463d895cc63cca0e4ae939a24eabc5e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611868
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157958}
[Office upload] Encrypted files should not fail in Move/Copy flow
Encrypted files should not require a password in the Move/Copy flow.
Use a `NOTREACHED` statement in the kNeedPassword [1] case.
[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/file_manager/io_task.h;l=43?q=kNeedPassword
Bug: b/275911611
Change-Id: I1aab81be0042c1153d83a5546d46e18722405271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615147
Reviewed-by: Jeremie Boulic <[email protected]>
Commit-Queue: Cassy Chun-Crogan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157957}
Fix transition between Paused states for offline and battery saver
Bug: b/287147118
Change-Id: Id663c6bcb7932d84cf412b9086652f69cdbad043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612827
Reviewed-by: François Degros <[email protected]>
Commit-Queue: François Degros <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157956}
Use Force(In|Out)ProcessNetworkServiceinstead instead of feature flag
Since IsInProcessNetworkService() depends on various conditions in
addition to features::kNetworkServiceInProcess, it is good to use
the Force(In|Out) functions, which directly applies Is(In|Out)PNS, where
code requires Is(In|Out)ProcessNetworkService.
Change-Id: I9ee57e453c0a50ab4f24bc7033b9d75a6bc1af0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593029
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157955}
Update V8 to version 11.6.155.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/75794115..40c1e04f
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ied9faa4cde1638783d456e583169cc063b2efb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616132
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157954}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686744225-488fad4d4f07cd55172be57fcb8002f7d018c761.profdata to chrome-chromeos-amd64-generic-main-1686787311-be1f450c0532856968dd558fb5e6d49b587858a9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id42dad256ba83aee6706ccb428406ed6dae2852c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616641
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157953}
Fix nullptr issue with in session optin
After user accept ARC TOS in in-session optin dialog, we update the UI
asynchronously to loading page. But when system is busy it is possible
that the UI update happens late and user clicks the accept button again.
Ignore the late click to avoid calling on nullptr.
Bug: b/284000632
Test: Trybot
Change-Id: I11fb03da3139075a3c6f3854b88c0bd6213bd509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616396
Commit-Queue: Long Cheng <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157952}
Rely on much simpler re2::StringPiece <-> base::StringPiece conversions
base::StringPiece implicitly converts to/from std::string_view and
re2::StringPiece is now the same as absl::string_view which, in
Chromium, is the same as std::string_view. All the code which converted
by hand can mostly not worry about it.
Ideally we'd also remove references to re2::StringPiece in favor of
std::string_view, but that'll bump into the current std::string_view
presubmit, so I'm leaving this alone for now. I'm also leaving alone for
now other issues in the surrounding code, such as pointer arithmetic
that would be better done with the bounds-checked substr() method, etc.
But all those should also be fixed up.
Bug: 1447090
Change-Id: If9de189f4cd85c1391894d9ab027e37da7144e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604580
Code-Coverage: Findit <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Auto-Submit: David Benjamin <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157951}
CrOS Settings: Define networks subpage base path string constant
Define a Mojo string constant in routes.mojom for the networks subpage
base path. This avoids using a plain string literal.
Addresses https://crrev.com/c/4606536/comment/fabf1bed_1ec8bac5/
Bug: b/286429941
Change-Id: I19bd39eb0d5da3b21ffe45040d86e5231a02808d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615338
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Wes Okuhara <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157950}
[cr2023][omnibox] Adds the new "Close all Incognito windows" Pedal icon.
Displays the new icon when either #omnibox-cr23-action-chips-icons is
enabled or ChromeRefresh2023Level is 2.
Also makes a couple other changes:
- Introduces a new Feature ("Cr2023ActionChipsIcons") and associated chrome://flags entry to independently control the icon changes here and in https://crrev.com/c/4523291 from the action button shape changes that the "Cr2023ActionChips" feature originally controlled.
- Removes [email protected] from the ownership of Cr2023 flags in chrome/browser/flag-metadata.json.
Bug: 1431337
Change-Id: If7c3d39bef4b9a7c23ee924ea3d8f21ed9a94607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615044
Reviewed-by: manuk hovanesian <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157949}
Integrate backend components for mandatory re-auth opt-in (4/4)
This CL integrates the backend components for the mandatory re-auth
opt-in flow, so that every time there is a green path autofill on a
form, we prompt re-auth upon form submission if the user should be
prompted for re-auth. It is the last CL in the chain for the re-auth
opt-in flow.
Bug: 1427216
Change-Id: I4b1f2063beb3cd2dd2a8b70191905fff72482028
Low-Coverage-Reason: The low coverage warning is for test_autofill_client.h, which is strictly a class used for testing. I've also filed crbug.com/1448697 as I believe there might be a bug in the low coverage check for inlined functions in the .h file.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582515
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157948}
[LCPP] Plumb LCPPHint from LoadingPredictorTabHelper to LocalFrame
This CL plumbs the LCPP hint data from browser process' `chrome/browser/predictors` to `blink::LocalFrame` in renderer process.
The LCPP hint data (`LCPCriticalPathPredictorNavigationTimeHint`
mojom struct) is piggy-backed to `CommitNavigationParams` to make
it available to the renderer process as soon as it commit navigation.
Please refer to https://docs.google.com/document/d/1waakt6bSvedWdaUQ2mC255NF4k8j7LybK2dQ7WptxiE/edit#heading=h.vknxgkp431xn for the illustration
Change-Id: Ib31a0872b405212e71cfc6f63637538932992ec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597060
Reviewed-by: Rakina Zata Amni <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157947}
Lacros: Enable WebAppIntegration* test for version skew test.
Bug: 1451234
Change-Id: I491e557822605a25cc79293c5f02c29ea4d2240f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609460
Reviewed-by: Sven Zheng <[email protected]>
Commit-Queue: Jenny Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157946}
Roll Catapult from c87640687ea0 to 8b35870248c0 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/c87640687ea0..8b35870248c0
2023-06-15 [email protected] [sandwich] create skeleton for alert_group_workflow.Process to start
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1454620
Tbr: [email protected]
Change-Id: I62c02941ee15833e1b900ecb5c834cb58c5a801a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616636
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157945}
[Android Bulk Tab Edit] Clean up remaining TabSelectionEditorV2 usages
Clean up remaining TabSelectionEditorV2 usages and flag info.
Bug: 1422295
Change-Id: Ie2af502655e2045f1eb0da44768c07b0b4a3decf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616923
Commit-Queue: Brandon Fong <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157944}
Roll Cros Components from c8df6d3cf168 to 2306858271c5
2023-06-14 [email protected] Internal change
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-components-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Change-Id: Ib8c0c21cf9d938cf419bb80e4ca5f598ab5ac965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617228
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157943}
Import wpt@1369e4a23a9c2e4fc2212f8c66ad0cd7e4b9d6bc
Using wpt-import in Chromium 6a872ef7d7123f7fdd632d992b54278d99196dd3.
With Chromium commits locally applied on WPT:
c4b9eceb1b "Remove XRSessionDeviceConfig.uses_input_eventing and related code"
96191f36eb "Migrate shadows.yaml to new test generator."
034f7b0a11 "Typo fix: tryLegalOpeerationsOnClosedContext to tryLegalOperationsOnClosedContext"
221db5924f "[FedCM] Update default_request_options function name in multi IDP tests"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/editing
[email protected]:
external/wpt/css/css-contain
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I20923b08ec5a3661a6dfd92713451623fd976dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614890
Auto-Submit: WPT Autoroller <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157942}
[omnibox] Split WebUI implementation out from OmniboxPopupViewViews
This CL refactors OmniboxPopupViewViews to make OmniboxPopupViewWebUI
a fully separate subclass, eliminating all reference to "webui" except
for some safety checks which can be eliminated after the new class
is fully settled.
In addition, this CL takes a few opportunities for code cleanup and
simplification. For example, method `GetSelectedResultView` was removed
because it had only one call site so inlining was cleaner than creating
a separate implementation to return nullptr in OmniboxPopupViewWebUI.
Bug: 1445142
Change-Id: I6d37efc8b21ea36e6df3f897a1f732bcbea2d476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602452
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157941}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686779970-95100686aa836c6a0766dec8ce062ef10e4f6e47.profdata to chrome-mac-arm-main-1686786983-738d20a4da1d4edaf913b98d6dd5dafda9915f1f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8f7d3ec2fc305179ea46ad155b2691e617e055da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616752
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157940}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686765533-f0cef0ec260ee1cb9f2018748777938267bb1364.profdata to chrome-mac-main-1686786983-0cf9fa63f2fe8797d637913232d5981e813f93d9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I57aa4735608b0304ea599d9fa05697a539941b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616430
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157939}
Mac: Don't fire focus accessibility event for non-key window
We don't trigger`NSAccessibilityFocusedUIElementChangedNotification`
for non-key window. Previously, when VoiceOver was enabled and multiple windows were opened for a PWA Mac App, the VoiceOver cursor would sometimes appear randomly between these windows. While the VoiceOver cursor worked fine in the Chromium browser, our observations using the Accessibility Inspector tool revealed that the browser was constantly triggering focus element change notifications even when browser was not active. This can fix the bug of PWA Mac and reduce unnecessary notifications for Chromium, thereby improving performance.
In addition, this CL also change a bug from test. Previously, the anonymous namespace variable `g_focus_change_callback_for_testing` existed in two files, which caused two copies of the variable to exist when running the test (one of which was always null), violating the global meaning. This change puts it in one file and uses the function-local static syntax recommended by Chromium to replace the deprecated LazyInstance.
Bug: 1452022
Change-Id: Ia5e379e98baad538c414b05595dda0c137d19b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604154
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Leon Han <[email protected]>
Reviewed-by: Benjamin Beaudry <[email protected]>
Commit-Queue: Leon Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157938}
Use LacrosOnly for publisher tests.
Currently the tests use LacrosPrimary, which is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: I48410a1e4eee479b2cfa63c50bd2508cbcff6a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615603
Reviewed-by: Maggie Cai <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157937}
CR2023: Remove hover state when focused, extra border in search field
Bug: 1408549
Change-Id: I6e982736cccb4256dc0bb60b7eb77ce861471df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617048
Commit-Queue: John Lee <[email protected]>
Reviewed-by: Cole Horvitz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157936}
Lacros SDK: Update version 15499.0.0
This CL updates the lacros_sdk_version. This cl only affect
Lacros on-device config builders like lacros-amd64-general-rel,
or ash-chrome builders.
This cl will certainly NOT affect linux-lacros builders
(linux-lacros-tester-rel, linux-lacros-rel, etc) or any
other platforms.
In case the generated cl has issues, please file a bug
to OS>LaCrOS>Partner, and CC [email protected].
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-arm-generic-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-arm64-generic-chrome-skylab
[email protected], [email protected]
Bug: None
Change-Id: I99f9b558d08a610b10e358dda65492d1c7af0ace
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615624
Reviewed-by: Sven Zheng <[email protected]>
Commit-Queue: Sven Zheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157935}
Roll wpt tooling
This rolls wpt to latest commit at
https://github.com/web-platform-tests/wpt.
REMOTE-WPT-HEAD: fbb062b7f03971f981afb03c35e38c34a4c289be
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: Ifeb1aa3b93d4f2dd356b46f8f69279a35a94dec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616799
Commit-Queue: Jonathan Lee <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Auto-Submit: Jonathan Lee <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157934}
Update anchor bounds for ShelfView.
The ShelfView bounds fill available space in the shelf, but the user
perceived bounds (where help bubbles should be anchored to) are
aligned with the center of the display and visible items in the shelf.
This CL updates anchor bounds to align with user perceived bounds.
Before: http://shortn/_PcKDXyZUsg
After: http://shortn/_uDNTfpUpIs
Bug: b:277091650
Change-Id: Id3f820f1a74e4cc60d921926170e29eae7a6a5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611732
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157933}
[cleanup] Cleanup offset logic in NGLayoutResult.
The top level union in NGLayoutResult was previously shared with
RareData. However once RareData was move into its own field this wasn't
cleaned up completely.
There should be no behaviour change.
Change-Id: I09e2f81e742a30d4ee9d574a2cd23c97065a9401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616795
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157932}
[FilesBulkPinning] Use OnItemProgress instead of OnSyncingStatusUpdate
DriveFS has uprevved, so prefer to use OnItemProgress now instead of
OnSyncingStatusUpdate.
Bug: b:272585066
Change-Id: I7b7e43d4e19e83961286d4386f15eabf443db98a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612433
Reviewed-by: François Degros <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157931}
Roll Fuchsia Internal Images from 13.20230614.2.1 to 13.20230614.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I9dca6b39f486c3ede310878968fcc7d1a0053669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616640
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157930}
Add libfuse2 to install-build-deps.py
R=thestig
CC=bpastene
Change-Id: I748eb26912694eb6d73053996af3feaf913a972f
Bug: 1454622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617057
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Auto-Submit: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157929}
Remove ChromeOS.Apps.NumberOfAppsForNotification histogram.
Bug: 1448156
Change-Id: I4a3fe69262b23667ab8a90b90f78092f9a391e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617447
Commit-Queue: Melissa Zhang <[email protected]>
Reviewed-by: Tim Sergeant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157928}
[build] Add loongarch64 config file.
Add build configuration to control loongarch64 SIMD build.
Bug: 1454442
Change-Id: I4e1bc2109e5d7602252ea94f3861c86209a6e06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609830
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Dirk Pranke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157927}
DeskButton: Overview desk switch visibility
Ensure desk button is visible immediately after desk switch from
overview.
Bug: b/287125188
Change-Id: Ibd123a880827c8d3798ab9087f978be1c788f6b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611806
Reviewed-by: Ben Becker <[email protected]>
Commit-Queue: Andrew Pantera <[email protected]>
Reviewed-by: Yongshun Liu <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157926}
[Homepage] Add Partner Customization histograms
Adds core histograms to track usage of partner Homepage customization,
and the timing of partner customization in general.
Adds histograms for:
* LoadDuration.{CustomizationDelegate} - how long it took each delegate to load,
* TaskCompletion - which logs the different ways that the Async Task completes (new tab creation is independent).
* DurationNeededForAsyncCompletion - how much extra time would be needed before creating a new Tab for the delegate to finish.
OBSOLETE_HISTOGRAM[Android.PartnerCustomization.DelegateConflict]=never used and no longer needed.
BUG=1433079, 1451510
Change-Id: Idf8f797e0b7eb864b5391eb494e5a0487d461f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4510723
Commit-Queue: Donn Denman <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Quick-Run: Donn Denman <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157925}
[lacros skew tests] Refresh skew tests for M115
This CL updates the ash version ['115.0.5790.30'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I374a24b275b418aa76b3106a4ca0c2659d8849f4
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615527
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157924}
guest_os: Shut down wayland servers if concierge crashes
We normally clean-up servers on a signal from concierge, but if
concierge crashed it won't send that signal.
A concierge crash brings down all the associated VMs, so we can safely
remove their wayland sockets.
Bug: b:271510899
Change-Id: I6ae0d5ad0a948daee97f14273e7cb65df6abcdcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612727
Reviewed-by: Fergus Dall <[email protected]>
Commit-Queue: Nic Hollingum <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157923}
Switch ChromeOS BatterySaverProvider feature
To make testing easier, replace
performance_manager::features::kUseDeviceBatterySaverChromeOS with
ash::features::kBatterySaver, so we don't need to manage two features
when testing/experimenting.
BUG=b:278963800
TEST=unit_tests
Change-Id: I1f2f0c434d19ebfc7312aa4d0dc75cf421980c81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603700
Reviewed-by: Anthony Vallée-Dubois <[email protected]>
Reviewed-by: Francois Pierre Doray <[email protected]>
Commit-Queue: Charles William Dick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157922}
Roll Skia from f26e786d4944 to 2718866006d2 (6 revisions)
https://skia.googlesource.com/skia.git/+log/f26e786d4944..2718866006d2
2023-06-14 [email protected] Disable SwitchWithFallthrough test on Adreno GPUs.
2023-06-14 [email protected] Reland "[skottie] add functionality for get, set, and tracking image slots to SlotManager"
2023-06-14 [email protected] Swap the order of the final two gradient FPs
2023-06-14 [email protected] Extract RP code for converting interpolated to destination color space
2023-06-14 [email protected] [skif] Update morphology filters to use FilterResult
2023-06-14 [email protected] [canvaskit] Allow OffscreenCanvas to make a CPU Surface
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1449408,chromium:400653
Tbr: [email protected]
Change-Id: I9d054c9d28752d10b417229868daf6e3dafe9263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617194
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157921}
Add Screenshot Support to Menu
Adds support when clicking on the "Take screenshot" tile within the main
menu view.
Bug: b:273641464
Test: Created unittest
Change-Id: I22a5426ced49f46ad2a69a01cc54805c314ac1c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602539
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Gina Domergue <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157920}
PA: Move use_allocator_shim GN flag into PA library
Bug: 1337681, 1245317
Change-Id: Icf55d59cf95049c96cc7a404718a09d6fd04fedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607971
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157919}
WebUI: Remove startColorChangeListener helper, part 3.
This helper was kept around as a temporary step. It no longer adds much
value after introducing the ColorChangeUpdater class and is removed to
keep the API as lean as possible.
In this part removing calls from ui/file_manager/, replaced by
ColorChangeUpdater.forDocument().start()
Unfortunately ui/file_manager/ calling code still using the Closure
compiler instead of TS, and requires "@suppress {checkTypes}"
annotations to consume ColorChangeUpdater.
The startColorChangeListener helper will be fully removed in a
follow-up CL.
Bug: 1450109
Change-Id: Ic4e12e9750acfac0d0b6d775487e201e95b86ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616007
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157918}
shortcuts: Add improved logging for mutation functions
Bug: b/216049298
Change-Id: Ie5e23a1cae6c22bebde2d169df0a4d52d2e421bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610975
Commit-Queue: Jimmy Gong <[email protected]>
Reviewed-by: David Padlipsky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157917}
Roll Fuchsia SDK from 13.20230614.1.1 to 13.20230614.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: Ief9a4af982943c9a010d1d362b8787c2f1eee36c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617287
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157916}
Roll Depot Tools from f50128a4431f to dedeb8899173 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f50128a4431f..dedeb8899173
2023-06-15 [email protected] reclient: show warning if $RBE_instance is set
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: If31a530657b73e8e4cee8d867efb7d63336fb4dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615360
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157915}
Roll Dawn from f1ed14a74552 to 66805b0c0e45 (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/f1ed14a74552..66805b0c0e45
2023-06-14 [email protected] [tint] Migrate to 'fluent types'
2023-06-14 [email protected] [DawnLPM] Enable dawn lpm for use_libfuzzer builds
2023-06-14 [email protected] [DawnLPM] Add optional fields to the lpm grammar
2023-06-14 [email protected] [ir] Add Return::Value() to get the return value
2023-06-14 [email protected] Unset bindgroup: validations and unittests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1374747
Tbr: [email protected]
Change-Id: I8cf52cf48c5a6f69c53a754c547ce50e4ba4cfca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616717
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157914}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686765533-0419320b99716471702201fbc44a94a5e7181fa3.profdata to chrome-win32-main-1686776368-7cda00e5876430834304032192950a4f1907f065.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I9c64516533dc369126bbb47de30a53abb9db091c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616246
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157913}
[FilesF2] Fix the infinite switch issue of the directory tree
If the tree item to be selected is already the current directory
in the store, do not re-activate it.
Demo: http://go/scrcast/NTE2NzU4NjgwNDIzNjI4OHw2NTFhODhjMy05Nw
Bug: b:286488664
Change-Id: I3c8bfabce8b1a92319ff9394e217c00f5e6125eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613597
Commit-Queue: Wenbo Jie <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157912}
Roll ANGLE from 5ff9d9318bc7 to 5a5f21f4a2e2 (5 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/5ff9d9318bc7..5a5f21f4a2e2
2023-06-14 [email protected] Disable supportsExtendedDynamicState on ARM
2023-06-14 [email protected] Clean up skipped deqp khr gles32 tests on Pixel 6
2023-06-14 [email protected] Clean up skipped deqp khr gles31 tests on Pixel 6
2023-06-14 [email protected] Clean up skipped deqp khr gles3 tests on Pixel 6
2023-06-14 [email protected] Clean up skipped deqp gles31 tests on Pixel 6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: If3cfd18f45a5a4ec59c5da4c9c149aedb38cd533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616637
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157911}
WebNN: Define XNNPACK Node for slice
This CL implements DefineXnnNodeForSlice() method that defines XNNPACK
slice Node by xnn_define_static_slice().
For unit tests, this CL implements SliceTest of MLGraphTest that
checks the compute results of slice operators.
Bug: 1273291
Change-Id: I2cb72acb7554da769b692be2ac7e59c46782565f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4464022
Reviewed-by: Jiewei Qian <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Quick-Run: Alan Kelly <[email protected]>
Commit-Queue: Lisha Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157910}
[FilesBulkPinning] Enable DriveShortcuts by default
Bug: None
Change-Id: Ic5920acc405a0800e30d6e20e6fb7c2ac1593263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583316
Commit-Queue: François Degros <[email protected]>
Reviewed-by: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157909}
[CR2023] Added section 4 & 5 to Profile submenu
This CL adds the Other chrome profile section and the managing profile section to the profile submenu.
This does the following:
- Adds strings to the profiles submenu view.
- Adds the 2 aforementioned sections to the profile submenu.
- One of the sections will increase the number of possible dynamic menu items in the app menu. This is because the "Other Chrome Profiles" can change depending on the number of profiles available in the browser.
- Cleaned up some UI code in app_menu to be shared across profile menu items. This is bespoke to the profile section for now and will potentially be removed in the future due to UI changes.
- Tests for coverage.
Figma mocks:
https://www.figma.com/file/NLMJNd5s2g9DEDZCbIngJV/ChroMenu---Desktop-Scalability?type=design&node-id=2560-291355&t=PlIopfjOa2CcJCBY-0
Screenshot:
https://screenshot.googleplex.com/BB9ccDaHEwaXPgZ
Bug: 1427667
Change-Id: Ib162e2259969d1e91f7427d9756e16685b6507e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609880
Reviewed-by: Avi Drissman <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: David Yeung <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157908}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686765533-ed123a6eb86767f0a48c9442c06a0c2133906043.profdata to chrome-linux-main-1686786983-569b5e54417c3f81b28dd8ea56f4ee1ab5382777.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Id62dbf8e86430be5a8575cbc8fe8290d5aef301b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616298
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157907}
WebNN: Implement CommandRecorder::InitializeOperator() for DML backend
This CL implements `CommandRecorder::InitializeOperator()` that
initializes a compiled DirectML operator on the GPU. The caller should
call `InitializeOperator()` only once before the execution.
This CL adds unit tests that test operator initialization for both
simple operators, such as Relu, and complex operators, such as
Convolution. The Convolution operator initialization test case tests
binding the filter resource flagged with `DML_TENSOR_FLAG_OWNED_BY_DML`
as input and persistent resource as output for the operator initializer.
Because the operator initialization may need to create temporary
resources, this CL moves the Direct3D 12 resources creation helpers to
`Adapter` class for both `CommandRecorder` implementation and the unit
tests.
Bug: 1273291
Change-Id: I22e76919168543f9c9d9be482ed32277c4699cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592016
Reviewed-by: Rafael Cintron <[email protected]>
Commit-Queue: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157906}
[Fixit] Use @MinAndroidSdkLevel in ContextMenuDragTest
The feature is supported only on Android O+, so use @MinAndroidSdkLevel
instead of @DisableIf which is intended for temporary
failures/flakiness.
Bug: 1380577
Change-Id: I2751ebe8889e8f1ca8994baf50e2532cca65bd03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615528
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157905}
Roll WebRTC from 8f1903e3cff7 to 31b00983750c (3 revisions)
https://webrtc.googlesource.com/src.git/+log/8f1903e3cff7..31b00983750c
2023-06-14 [email protected] Roll chromium_revision e931919cac..8af8fba80c (1157676:1157822)
2023-06-14 [email protected] Roll chromium_revision 6e77598937..e931919cac (1157573:1157676)
2023-06-14 [email protected] Roll chromium_revision bb8855a075..6e77598937 (1157397:1157573)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I629a1b07f52f38fb07bd0ff6ee0934953822488f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616200
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157904}
Enable CSS Spelling and Grammar markers
This was reverted to experimental due to invalidation issues.
Those have been fixed, so turn it on again.
Bug: 1257553
Change-Id: I32fb76d5d1dcf110d88ea67d739f1922ec3d9b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616724
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157903}
[FilesBulkPinning] Fix up failing test before enabling Progress events
The OnSyncingStatusUpdate_SyncStatusTracksStatus test fails when we
enable the kFilesInlineSyncStatusProgressEvents as it expects that flag
to be false, explicitly override the flags in the test to ensure
assertion of the correct flow. This test can be removed when we remove
the flags.
Bug: b:272585066
Test: chromeos_unittest --gtest_filter=*SyncStatusTracksStatus*
Change-Id: Ib47cb6a7a1a7dd0bd84fe93bc3057ebfffd5c423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615465
Reviewed-by: François Degros <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Commit-Queue: François Degros <[email protected]>
Auto-Submit: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157902}
Revert "drm: Only use modifiers that support Vulkan import"
This reverts commit 1c1f725aca0732d5acbeb6fe518bba3132571e96.
Reason for revert:
Suspected to be the culprit of a compilation failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/75033/overview
Original change's description:
> drm: Only use modifiers that support Vulkan import
>
> Currently when Vulkan is enabled, we do not take into account whether
> a particular DRM format modifier is supported for Vulkan import via
> vkCreateImage. Thus, we can allocate a presentation buffer with a
> modifier that then cannot be imported into Vulkan, and later we fail
> display composition. For example, the Intel Vulkan drivers do not
> support import of Gen 12 CCS buffers, and Chrome crashes on startup
> if we enable Vulkan on a sufficiently modern Intel GPU.
>
> This CL fixes the issue by querying for supported modifiers when
> populating the available modifiers list and only returning those that
> can be imported.
>
> Change-Id: Iaa9ca90f97caddf0968489400aea745780a45257
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262572
> Reviewed-by: Michael Spang <[email protected]>
> Commit-Queue: Brian Ho <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Reviewed-by: Vasiliy Telezhnikov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157885}
Change-Id: Id15121c5e635b7da6d5ad752285dee6d1e813da2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617528
Auto-Submit: Takumi Fujimoto <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Owners-Override: Takuto Ikuta <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157901}
Updating trunk VERSION from 5833.0 to 5834.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I1d8691f6fb1ff4c05a277b1617cce0db04182498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617707
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157900}
Fix small UI issues with sink view
For sink views at the end of the list, their action button focus rings
were overflowing the scroll_view, and were thus cut off. This change
adds margin at the end of the sink_list_view so that focus rings are
not cut off.
The active icon color used by cast_dialog_sink_view used kColorAccent,
which does not comply with the new jelly colors (and does not match the
color of the cast toolbar button active icon). So, this change updates
the color to match.
Before: https://screenshot.googleplex.com/3DGDjc2YfLYWH8Z.png
After: https://screenshot.googleplex.com/CaMHmRYDGWCpNPR.png
Bug: b:287101844, b:287100717
Change-Id: Iec8853aafcd0c7e6b5b5adb7f8cd1ab5fee5dac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615548
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: Benjamin Zielinski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157899}
autocorrect: enable AutocorrectUseReplaceSurroundingText by default
Bug: b/254385864
Change-Id: Iafbb9a59f81bc8b3e54010b999f261bea32d8b49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613167
Commit-Queue: Chuong Ho <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157898}
Improve run_wpt_tests.py logging
Log similar information as in RWT side. Such information should be
useful for the users to understand critical information when running
the tests.
Bug: 1426296
Change-Id: I89da412e9cd0cbf86409be9b3b0e7844f091f429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607775
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157897}
Lacros: Remove Google Keep ChromeApp from ash keeplist.
Google Keep Chrome App has been deprecated (launching it on
ChromeOS will pop up a dialog with "The Keep Chrome App is
no longer supported."), therefore, removing it from ash
extension keeplist.
Bug: 1454874
Change-Id: I667b3dc71dce606393c78932acbe7042083cdfec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616017
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Jenny Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157896}
autocorrect: enable ReplaceSurroundingText for undo autocorrect on Ash only
This CL adds another condition to disable ReplaceSurroundingText on Lacros
Bug: b/254385864
Change-Id: I5f4238119064f93add86b9553b9e3045f079d763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612868
Reviewed-by: Curtis McMullan <[email protected]>
Commit-Queue: Chuong Ho <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157895}
Extend SSL.Experimental.SubresourceResponse histogram.
Bug:1403714
Change-Id: Ib801ab1ae42b086011ce4e09e52295071db02743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615065
Reviewed-by: Jesse Doherty <[email protected]>
Commit-Queue: Aman Verma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157894}
[Desktop][UX Enhancement] Fix the width of the challenge selection
dialog
This CL fixes the width of the Card Unmask OTP Input Dialog to be the
dialog preferred width instead of the large modal dialog preferred
width.
Before: https://screenshot.googleplex.com/3XxD37kPaMjh4XL
After: https://screenshot.googleplex.com/365Urb3diJHLxEp
Bug: 1453325
Change-Id: Ic688254421f839d81315d46a2767e3b853080dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616726
Commit-Queue: Vinny Persky <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157893}
[Printing] Change non-square DPI to non-square pixels
It is not the DPI that is non-square. It is the pixels that are
non-square. Change all references to non-square DPI to non-square
pixels.
Change-Id: I6898de9ded7a21bce5835834f5f8ba5bc6093716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616147
Reviewed-by: Alan Screen <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Nigi <[email protected]>
Commit-Queue: Andy Phan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157892}
[Fixit] Fix MainSettings test failed on Android auto bots
* Remove notification settings if not supported on the running device
* Scroll to sync settings before click. This fix the issue of sync preferences is out from the screen due to smaller vertical screen size on automotive bots.
Bug: 1454333
Change-Id: I9ac91c168e5dad6471c960ccaf970e8480b668a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616145
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157891}
[Desktop][UX Enhancements] Fix the width of the Card Unmask OTP Input
Dialog
This CL fixes the width of the Card Unmask OTP Input Dialog to be the
dialog preferred width instead of the large modal dialog preferred
width.
Before: https://screenshot.googleplex.com/BK2CkpcSEVHtbBM
After: https://screenshot.googleplex.com/5gKS9C3jJfEAPev
Bug: 1453325
Change-Id: I1d2ecf11bb495c9c064fdc335999ebea0611f4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616885
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157890}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686765533-1894346b5888f16faf9050fe055ea8d49e370447.profdata to chrome-win64-main-1686776368-6ca2fc66232cc3994e1af56515074c7c4b2190aa.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I33150de90868d3222301440b5d775de5314ef331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615302
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157889}
[ SavedTabGroups ] Add test; verifies button updated in bookmarks bar
Add an interactive ui test that verifies a SavedTabGroupButton's title
and color is updated when the respective TabGroup's title and color is
changed.
Change-Id: I12c595566d1a8e64853a35680dfd5f5cbae15f43
Bug: 1453389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616556
Code-Coverage: Findit <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Darryl James <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157888}
Roll WebGPU CTS from e957d8fd868b to 9a981a010fde (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/e957d8fd868b..9a981a010fde
2023-06-14 [email protected] Add VideoFrame tests for copyExternalImageToTexture (#2760)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I9895ed4ef2b26a4aabeb98998738c82f99883130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616630
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157887}
cros_next: Adjust drop target widget's bounds with Jellyroll enabled
When Jellyroll is enabled, the header of the overview item is visible
for the item being dragged. Since drop target widget is an indicator of
where the window being dragged is dropped to, it's better to make its
size include the header's size as well.
Bug: b/284210464
Change-Id: I61af71d6ee310a9b8a4143892f0c42eaeffc1982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612125
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Connie Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157886}
drm: Only use modifiers that support Vulkan import
Currently when Vulkan is enabled, we do not take into account whether
a particular DRM format modifier is supported for Vulkan import via
vkCreateImage. Thus, we can allocate a presentation buffer with a
modifier that then cannot be imported into Vulkan, and later we fail
display composition. For example, the Intel Vulkan drivers do not
support import of Gen 12 CCS buffers, and Chrome crashes on startup
if we enable Vulkan on a sufficiently modern Intel GPU.
This CL fixes the issue by querying for supported modifiers when
populating the available modifiers list and only returning those that
can be imported.
Change-Id: Iaa9ca90f97caddf0968489400aea745780a45257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262572
Reviewed-by: Michael Spang <[email protected]>
Commit-Queue: Brian Ho <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157885}
Split page load metrics for Protected Audiences features
This is to help understand whether possible regression is related to
one of these two features.
Change-Id: I79b5d373d69d50d06509ea99df65b070c8e7c599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615864
Commit-Queue: Nan Lin <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157884}
Roll earl_grey2 from 90fa652f6ba7 to 2e1fee1e765e (1 revision)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/90fa652f6ba7..2e1fee1e765e
2023-06-14 [email protected] Internal
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ifa2b7b8bc2c8fe59c33226f2f07f3d55f7dbce39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616712
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157883}
Wayland protocol to allow exo to rotate view focus in lacros - Client
When focus rotation is requested for lacros widget, a rotate focus event
is emitted from exo to lacros. These requests are fenced with a serial,
which will prevent delay in processing from triggering multiple
subsequent rotations in ash.
When the client has reached the end of it focusable views, it will
notify the the exo with the aforementioned serial.
For this change, much of the rotate pane focus code had to be moved to
the widget delegate. This is because the behaviour is now platform
dependent.
Change-Id: Ifbe31230578444cc35db8143fc5cfd0c14448b95
Bug: 1361120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4554431
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157882}
Add fieldtrial testing config for CSSDisplayAnimation
Change-Id: I2ad9cf2f5cbb7b75de248e55c277eda7125edffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609239
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157881}
Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json
The previous CL (https://crrev.com/c/4604704) caused regressions. This
CL tries to enable SpeculativeServiceWorkerWarmUp without
IntersectionObserver.
Bug: 1431792
Change-Id: I7877c3ec652636d9c4dead9e6329f3642bf687b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614823
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157880}
Reorder annotations/keywords to inline in ^chrome.
This approach is better because it keeps the type annotation closer
to variable type itself, improving readability. Also in general more
compact and visually pleasing.
Created with script https://paste.googleplex.com/6606399034359808
Change-Id: I128f81c0385d508605bda6392ca1ce8e296d6d77
Bug: 1454827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609852
Auto-Submit: Sky Malice <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157879}
[A11y] Reland targeted cached property invalidation
Relands the following CLS:
* Enhance performance by targeting value updates to specific nodes, commit 704633e6846e44b20c488a3eb98fa43c2c8e4591.
* Don't queue anything for irrelevant attribute changes, commit 2c66a62ed62e601b7a81271e4be4f9e173ce9afc.
* Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed3b48bc8ce70de657672755f44a89e7358.
* Ensure cached values not invalidated during the computation of them, commit 4d167a62cd13d5209ecefb664e3690ac955bc559.
* Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd829b24acf677e02f8f118085eaad7f799.
* Simplify code to update cached focusable state, commit 79cb184e5dab5f6084ec78d485bd9496eaa0aaf8.
* Simplify code that invalidates cached values on an AXObject, commit 6df79a50a55fe5cf99d2c50f7308e1236361b771.
Fixed: 1446864, 1446550, 1434555, 1362758
Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Jacques Newman <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157878}
[FedCM] Ship loginHint, UserInfo, and Context
Intent to ship thread:
https://groups.google.com/a/chromium.org/g/blink-dev/c/nKGUbzcVXt8
Fixed: 1412893
Change-Id: Ie43ce651c0d40533cade03b562b11649436ac28a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605337
Commit-Queue: Nate Fischer <[email protected]>
Auto-Submit: Nicolás Peña <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157877}
updater: upload crash keys for each command line argument.
With this change, data similar to the following is uploaded to crash:
Crash keys:
"switch-3" = "--vmodule=*/chrome/updater/*=2,*/components/winhttp/*=2."
"switch-2" = "--enable-logging"
"switch-1" = "--crash-me"
"num-switches" = "3"
"process_type" = "updater"
Fixed: 1454858
Change-Id: I9a548f81a8ba4f19f92b42e7f57671f41971a32c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615997
Commit-Queue: Sorin Jianu <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Auto-Submit: Sorin Jianu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157876}
Provide correct information of dispatching thread for IMFAsynCallback.
The flags should be provided with [out] flags instead of the return
value.
Bug: 1348361
Change-Id: Ib4451b7d3a1563a3ebbaa9d9af278dba7f0d6249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609626
Commit-Queue: Jianlin Qiu <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157875}
Add wayland api for rotating window internal focus
ChromeOS allows rotating focus between OS views and browser panes.
Browser panes are no longer accessible from the OS since the ash/lacros
split. This change adds a wayland API to allow ash to request lacros
to rotate its pane focus and another API for lacros to notify ash that
it has reached the end of its pane rotation.
Bug: 1361120
Change-Id: Ic82b7c5c57bb34e97c21f7b177f2f4a68a1b477a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548442
Code-Coverage: Findit <[email protected]>
Commit-Queue: Fred Shih <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157874}
Suppress the non-virtual version of web test also cause mac 13-arm build
failure
Bug: 1450287
Change-Id: If33ebde4db19e42c595a5c7ea4d8991d5d6d7270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615355
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Vivian Zhi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157873}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686772765-be12f3aaf3ae7d1fe7a25fc88aa529ccadd6f71b.profdata to chrome-mac-arm-main-1686779970-95100686aa836c6a0766dec8ce062ef10e4f6e47.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib6734dffd0daf2deb910036790396dd787e81768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616199
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157872}
Roll Depot Tools from 7d9b24f004be to f50128a4431f (2 revisions)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d9b24f004be..f50128a4431f
2023-06-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2023-06-14 [email protected] Upload git traces from bot_update
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1351547
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: Id10f71c32897b3302deac015b4a3313888b82781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616911
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157871}
Roll ANGLE from 97e3851d1219 to 5ff9d9318bc7 (2 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/97e3851d1219..5ff9d9318bc7
2023-06-14 [email protected] Clean up skipped deqp gles3 tests on Pixel 6
2023-06-14 [email protected] Clean up skipped deqp gles2 tests on Pixel 6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I640178a593977836fb69f28d54b724df51da3e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616708
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157870}
Avoid unsafe param eval in PopulateAndSortAllPaperNames()
The use of a std::move() in PopulateAndSortAllPaperNames() is
potentially unsafe, because C++ does not guarantee any particular order
of evaluation. [1] Copy a field to avoid issue.
[1] https://en.cppreference.com/w/cpp/language/eval_order
Change-Id: I262186a99f14a01dff602e84a26ac67f835b1078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602857
Reviewed-by: Alan Screen <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157869}
Migrate the-canvas-state.yaml to new test generator.
Bug: 1275750
Change-Id: Ib83c29ab16d75890272b311f9ff22268679d8e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4561623
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Reviewed-by: Yi Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157868}
Refactor BluetoothBlueZTest to fix flaky discovery test - part 1
This is a follow-up CL to CL4568899. The original test was flaky due to
a race condition that would occasionally cause the run loop to break
before the expected task of updating the fake adapter client properties
could be executed. This CL refactors the code to ensure that we are validating internal states at the right moment.
Bug: 1446496
Change-Id: I7338cf9e763e66d720e9800b1a0b90e2408e20c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595414
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Alvin Ji <[email protected]>
Commit-Queue: Alvin Ji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157867}
Roll ios_internal from e0aa1738397a to 41e1b97eb3ac
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/e0aa1738397a..41e1b97eb3ac
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1454808
Change-Id: I6e6db4e69c3e8cd96a76367d172dea94c34f201f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615301
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157866}
CR2023: Fix cr-toggle focus state.
Fixed: 1400862
Change-Id: I882001752ea342d900cd4b344370dc82a2a8af51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616866
Commit-Queue: Cole Horvitz <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157865}
Add more metrics to understand why ClientSafeBrowsingReport is not sent
Sometimes ClientSafeBrowsingReport can be skipped because there is
already a threat details job in progress. This can happen if other
callers have started the job (PasswordProtection or suspicious
reports) or another subresource URL has already been flagged. We'd
like to know how often this happens and see if it fills the gap of
low report QPS.
Histograms added:
SafeBrowsing.ClientSafeBrowsingReport.HasThreatDetailsAtFinish.{ResourceType}
SafeBrowsing.ClientSafeBrowsingReport.HasThreatDetailsAtStart.{ResourceType}
Bug: 1315455
Change-Id: I5a695ef0c17db782236acf8f07099fd9279f3f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611266
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157864}
Roll Skia from 8f0ef5e2d300 to f26e786d4944 (6 revisions)
https://skia.googlesource.com/skia.git/+log/8f0ef5e2d300..f26e786d4944
2023-06-14 [email protected] Add WGSL support for switches that have fallthrough cases.
2023-06-14 [email protected] Add WGSL support for switches that do not have fallthrough cases.
2023-06-14 [email protected] Migrate switch top-level variables into a block.
2023-06-14 [email protected] Refine the EmbindObject type so that TypeScript can differentiate between opaque types such as Shader, ColorFilter, and so on.
2023-06-14 [email protected] [graphite] Remove deprecated YUVA constructor
2023-06-14 [email protected] Simplify parameters to drawEdgeAAImage and DrawTiledBitmap
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I815bb74c53b0144f7ee36f1a13ac00f24dcd25ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616705
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157863}
Roll vulkan-deps from cebf5626ca50 to 91926f6dfb63 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/cebf5626ca50..91926f6dfb63
Changed dependencies:
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/8e2ad27488..6e09e44cd8
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/40dde04ca2..b4f352e54f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1794ad423b741d908b8879ad1ffd9c153cf474fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616385
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157862}
[text-wrap-pretty] Remove a condition that never hits
This patch removes a condition that never hits.
`NGInlineLayoutAlgorithm` checks `BlockEndOffset` of the
`NGLayoutOpportunity` to see if block fragmentation is
enabled, but it turned out that no call sites use it, and it's
always `LayoutUnit::Max()`.
Further tests for block fragmentation will be in following
patches.
This patch should have no behavior changes.
Bug: 1432798
Change-Id: I934eeba1961475ab6c7758b6e3cc51d423c5a302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613287
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157861}
Disable flaky MenuItemViewTestRemove01.RemoveItem01 on ozone.
This started being super flaky a couple of weeks ago on
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28Wayland%29, and started consistently failing as of
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(Wayland)/38308/overview
Bug: 523255
Change-Id: Id86c28400b4b412d137cc435ae31cad2a710bc46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616688
Commit-Queue: Mike Wasserman <[email protected]>
Owners-Override: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Mike Wasserman <[email protected]>
Auto-Submit: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157860}
chrome-flags/lacros: Remove LacrosColorManagement from Ash
The LacrosColorManagement flag shows up in os://flags (Ash) and
chrome://flags (lacros), but only has an effect in chrome://flags.
Remove the Ash version of the flag.
BUG=b:286897099
Change-Id: I180dd8e5bd78f43961a1845473956968737c54eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608732
Commit-Queue: Femi Adegunloye <[email protected]>
Reviewed-by: Brian Ho <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157859}
Update in-session tablet mode wallpaper shield
Updates the wallpaper shield color to kCrosScrim2 for Jelly for
in-session tablet mode. The shield is used as a background for home
screen / launcher.
BUG=b/277270352
Change-Id: I8eb395f381e07d87bc89866771bbb275f70bc839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611282
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157858}
[iOS] Fix the Activity Metrics provider filter.
Moved the Activity Bucket provider filter to a different directory, as well as registering the metrics provider.
Bug: 1446085
Change-Id: Ic742f81c71dd367df2ce3c84cc37fc6fd8ce66cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601889
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: Guillem Perez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157857}
[OOBE] - Add typography tokens to OS install screen WebView
Add logic to supply OS install logs WebView with the modal dialog
typography tokens if OobeJelly enabled.
Some random lines were changed by the git cl format --js command.
Bug: b:270913356
Change-Id: I4f9b82acd01123bbd7732b9aeba0c4844dd80691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608057
Commit-Queue: Bohdan Tyshchenko <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157856}
Remove more GLES2 deps from cc
A few more cc_unittests can have dependencies on GLES2 removed. Remove
the gles2_interface.h include from all non-test files and update DEPS to
disallow adding it back.
Also, switch paint_op_buffer_fuzzer back to use test GL context which
was modified in https://crrev.com/c/4605838 incorrectly.
Bug: 1453349
Change-Id: I79754a4ad3d02599973faa46d112a28a884780c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615551
Reviewed-by: Saifuddin Hitawala <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157855}
[Desktop][UX Enhancements] Challenge Selection Dialog
This CL contains various UX enhancements for the Challenge Selection
Dialog on Desktop:
1) Moving the GPay logo from the left to the right in the title
2) Various string updates
Mock: https://screenshot.googleplex.com/6j3CHjNPDs8PFLZ
Before: https://screenshot.googleplex.com/AdMKbefBnUFUHuW
After: go/strpic/9e4e4a6afe90be750a08960fddff829f9b42f76a
Bug: 1453325
Change-Id: I9219b85d0bd3d18f562b88959e5136de1d76a48b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611965
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157854}
Fix AccountPickerBottomSheetTest on automotive
Many tests click the 'continue' button to proceed with sign-in then wait on a specific UI element. On automotive, the device lock flow is hit instead, causing the tests to fail.
Update #clickContinueButtonAndCheckSignInInProgressSheet to continue
past the device lock screen on automotive.
Bug: 1443547
Change-Id: If23359c8928544b55d243cf6fa51d4f08506ee54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616011
Commit-Queue: Theresa Sullivan <[email protected]>
Reviewed-by: Charles Hager <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157853}
Automated Commit: LKGM 15501.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778352183098386625
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: If6678d0511e2ecfc7923197a4e86df44a753069f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615744
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157852}
Continue run expired virtual test suites
With this change, we will not automatically stop running expired virtual
test suites. The expired field is now only used by an external process
to decide if the expiration date should be extended or if the VTS should
be deleted.
Virtual test suites now also accepts an owners field. New or modified
VTSs should have this field set up properly.
Bug: 1380165
Change-Id: I8cd87ab3ccff80376f771698c2f98680ca634fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611810
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157851}
[Chrome Refresh] Update weight of page action icons from 400 to 500.
This change only page action icons that were already updated to use the refresh versions.
Bug: 1399991
Change-Id: I88ad04a65fe419d774c66ae86a65b24eecf18022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616158
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Shibalik Mohapatra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157850}
[Tab Strip Redesign] fix NTB icon x-position when removing button style
Before: https://drive.google.com/file/d/14kjrEoFMlrodHef4gsp7I1IlIv7hEXy-/view?usp=sharing
After: https://drive.google.com/file/d/14sW7T4C2nfaHUhunwdV5ojtIegJp9dJy/view?usp=sharing
Bug: 1452249
Change-Id: I91c43c721a5544ba78d8a5ccc43568a2143f97e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614456
Code-Coverage: Findit <[email protected]>
Reviewed-by: Neil Coronado <[email protected]>
Commit-Queue: Zhe Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157849}
Add Omnibox ml url scoring experiment groups to fieldtrial_testing_config.json
Bug: b/285356742
Change-Id: Id40b86305464a62c479c08980422a42e1e1f3053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612467
Commit-Queue: Jun Zou <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157848}
[Omnibox] Add two features limiting clipboard suggestions
1. Restore ClipboardMaximumAge so we can try values < 10 min
2. Add a new feature that suppresses the clipboard suggestion after it's
been selected (clicked) the first time, identifying it via the last
modified timestamp from the ui::Clipboard instance.
Bug: 1450999
Change-Id: I8c722e0fbe601f6024a6495c45dd2f403dc8eda3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582703
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157847}
personalization: dynamic color for login screen
Added local prefs for dynamic color, so that users will see their color
preferences on the login screen.
With jelly: https://screencast.googleplex.com/cast/NDg3MDI0OTEzNzU2OTc5MnwxZjljOGE5OS04Yg
Without jelly: https://screencast.googleplex.com/cast/NjAyMTM5NjY0MDU2MzIwMHxiZTYwZGQxZC0zNg
BUG=b:276475812,b:286519064
TEST=ash_unittests *ColorPalette*
Change-Id: Ibb41635685f2b7e7bb348a1dbea1399f7ac970ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4475678
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Erica Lee <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157846}
[FedCM] Update default_request_options function name in multi IDP tests
This was missed in https://crrev.com/c/4595879
[email protected]
Change-Id: Ia3718f9dde42bf44e338c9a266c7aa7db796fc5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616886
Auto-Submit: Christian Biesinger <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Commit-Queue: Nicolás Peña <[email protected]>
Reviewed-by: Nicolás Peña <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157845}
[Android] Obvious error when clicking a view that hasn't been sized
This is a common source of flakiness, but the error message is usually
non-descriptive because a click on pixel (0, 0) is legal. We never want
to click a view that hasn't been sized yet and this surfaces the error
earlier and with a better message.
Bug: 1444083,1441822,1435426,1444217,1444241,1444222
Change-Id: If1dff0ebb2f52218e25dd15be1c20ddff538daa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608982
Commit-Queue: Henrique Nakashima <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157844}
[Fixit] PersistedTabData testCacheCallbacks fix
It is believed this test is flaky because there is no
synchronization in the callbacks. The callbacks can return
after the test has finished which can cause other tests to crash.
This CL adds in that synchronization.
Bug: 1292239, 1287572
Change-Id: I82bdddaa8bf65e154ad224a22e089fd99c185182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606317
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: David Maunder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157843}
Typo fix: tryLegalOpeerationsOnClosedContext to tryLegalOperationsOnClosedContext
Change-Id: I2011a9ec7f870220ddc04f5cad16960b4759b2d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616687
Reviewed-by: Michael Wilson <[email protected]>
Commit-Queue: Sina Firoozabadi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157842}
[omnibox] Fix units of 6 metrics from 'ms' to 'microseconds'.
Omnibox.AutocompleteClassifierClassifyTime
Omnibox.AutocompletionTime.UpdateResult
Omnibox.AutocompletionTime.UpdateResult.SortAndCull
Omnibox.AutocompletionTime.UpdateResult.DeduplicateMatches
Omnibox.OmniboxEditModelOpenMatchTime
Omnibox.OmniboxViewRevertAll
Also adds the Omnibox.AutocompletionTime.UpdateResult.DeduplicateMatches
entry to the xml file. Originally implemented in crrev.com/c/4599582.
Also, couldn't figure out how the `SCOPED_UMA_HISTOGRAM_TIMER_MICROS`
function those histograms use handles devices without high-resolution
clocks. A tricium warning asks the xml description to mention if the
non-high-resolution devices are dropped or measured coarsely. But there
were comments in the UMA macro code and other xml descriptions that
contradict each other, so I'm unsure which it is. Might reach out to UMA
folk and update the description in a followup CL.
Change-Id: Idfc11954b8353804e26770c1acae8c2f3d0aa5fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615642
Reviewed-by: Angela Yoeurng <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157841}
arc/gio: Implement function of removing action
This CL implements the function when the trash button is pressed on the
ButtonOptionsMenu.
- EditingList and InputMappingView update the views when the action is
removed.
Bug: b/270973665
Test: Add ButtonOptionsMenuTest
Change-Id: I5a6095dd2e5779f4eb0b57f745bc2f91c7ac2666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599633
Auto-Submit: Cici Ruan <[email protected]>
Commit-Queue: Cici Ruan <[email protected]>
Reviewed-by: David Jacobo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157840}
CR2023: Fix Chrome Web Store icon color
Bug: 1430281
Change-Id: I2495b6f553172febd17de0b2eb8cb2c354f8e192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616012
Commit-Queue: John Lee <[email protected]>
Reviewed-by: Riley Tatum <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157839}
Add field trial config for autofill branding fast follows
... and rename some about_flags variations for clarity.
Bug: 1447909
Change-Id: Ib16faa0b52fddbfb0bb9e64231bcc11cb0093aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615750
Reviewed-by: Huiting Yu <[email protected]>
Auto-Submit: Ginny Huang <[email protected]>
Commit-Queue: Ginny Huang <[email protected]>
Commit-Queue: Huiting Yu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157838}
Deflake PDFExtensionPrintingTest.BasicPrintCommand yet again
Try one more time to deflake this test based on the most recent flaky
test results. In addition to using TestPrintingContext, also use
TestPrintBackend to further avoid triggering modal print dialogs.
Bug: 1258561
Change-Id: I34271ef9708aa4e40582c87ad782cea3db1c0192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616014
Code-Coverage: Findit <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157837}
Generalize the Model Execution Watchdog
Instead of relying on a specific method on a specific class, use a
OnceClosure instead to be more generic and in order to support different
task libraries.
Also has the benefit of no longer being templated so moves the impl to
its own cc file.
Bug: b/283522287
Change-Id: I6b3faa470b06330ac985a57d256a4dbd277e81ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615354
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157836}
Roll devtools-internal from 0f0a49bcd25c to bbd649c6a546 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/0f0a49bcd25c..bbd649c6a546
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4d2c9fc82e14d16e286d2633d3a753dd68d7483a..cd66c0ca786bfff71d9ebcfc258a02edce71cb25
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I695acdb0ecd6fdb6790afadb76c30ccdda2a8674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616903
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157835}
[PM] Fix visibility for non current frames
Bug: 1454879
Change-Id: I7db3d38ccf28c47298324ead96377682db0f7e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616505
Reviewed-by: Joe Mason <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157834}
Migrate shadows.yaml to new test generator.
Bug: 1275750
Change-Id: Ie18d6f6be578b8711c11a7fad987b7b29e832783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562936
Reviewed-by: Yi Xu <[email protected]>
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157833}
Revert "Add histogram to test possible crash cause"
This reverts commit 1d45ee97c9d502492e0fae0909d5b3d4753d6bc2.
Reason for revert: Histogram has shown that we very, very rarely
(less than 1 in 100,000,000) get samples out of order. That's not
the cause of https://crbug.com/1414744;
https://chromium-review.googlesource.com/c/chromium/src/+/4564594
fixed the root cause.
We don't need the histogram, so revert.
Original change's description:
> Add histogram to test possible crash cause
>
> One possible cause for https://crbug.com/1414744 is that samples are
> being received out of order, which would cause the std::lower_bound and
> std::upper_bound (binary searches) to return invalid iterators, or
> iterators where begin > end.
>
> Test if we are, in fact, getting out-of-order samples.
>
> BUG=chromium:1414744
>
> Change-Id: I992ad0e093e4a5dc48b4414c96a8e9a9d60954d5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4519599
> Commit-Queue: Ian Barkley-Yeung <[email protected]>
> Reviewed-by: Mike Wittman <[email protected]>
> Reviewed-by: Mark Pearson <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1142510}
OBSOLETE_HISTOGRAMS=UMA.StackProfiler.SampleInOrder was a temporary to investigate a now-fixed crash.
BUG=chromium:1414744
Change-Id: I4ad7759585bed3ef43b09982641ebb9ff94e3b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616390
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Ian Barkley-Yeung <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157832}
Roll Perfetto from 54280e702d09 to c03807155ece (2 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/54280e702d09..c03807155ece
2023-06-14 [email protected] Merge changes Iffe835e3,I11b92eba
2023-06-14 [email protected] Merge "Deprecate controller in ChromeSliceDetailsPanel."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ib9b63a9ea40e14d529b02d378da5807c8ccf5431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616627
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157831}
Make some small improvements to TestPrintingContext
- Add a comment to explain the relationship between TestPrintingContext
and PrintBackend.
- Fix a nit in another comment.
- Avoid a potentially useless PrintBackend instantiation.
Change-Id: I236acaba7ec6cd65e262e8f88c230f910061a085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616668
Code-Coverage: Findit <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157830}
[User Education] Fix arrows on Mac help bubbles
Turns out an overridden shadow parameter we changed back to the default
for 2023 Refresh was necessary, but not for the reason that was
originally stated. So now, it's back on Mac with the correct
documentation.
Bug: 1454565
Change-Id: I51c07234c6d5a0d3c0a1bab6e5fea20aeaa2c047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616157
Reviewed-by: Darryl James <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Auto-Submit: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157829}
Roll Depot Tools from defdda0c6241 to 7d9b24f004be (2 revisions)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/defdda0c6241..7d9b24f004be
2023-06-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2023-06-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: Iccc072e6838850bea0ffb896162fd92465eb0e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616196
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157828}
Clean fake_buffer.h comments
Previously the fake buffer class was created to handle VABuffer
operations. Artifacts were left in the class header comment block
which need to be cleaned.
Removes unnecessary "//" characters from inside the header comment
block.
BUG: b:261660716
Test: LD_LIBRARY_PATH=./
LIBVA_DRIVERS_PATH=./
LIBVA_DRIVER_NAME="libfake"
./video_decode_accelerator_tests crowd_run_256X144_fr15_bd8_sub8X8_l1.ivf
--v=4
Change-Id: Id720222e29721a5b244c724ffba93e76e4c207eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615651
Commit-Queue: Bijan Choobineh <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157827}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686765533-a135384ef988ebc52685b72137ea203f044f4c75.profdata to chrome-mac-arm-main-1686772765-be12f3aaf3ae7d1fe7a25fc88aa529ccadd6f71b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Iedfed97ca477d85888a6d7482ca3d2057f2d415f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615960
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157826}
Import wpt@1557027c3ffa7d4fda77dfa4389a468932c1f152
Using wpt-import in Chromium 1ae34209d490dd4d9f03e2503c52b410a2e1ab2a.
With Chromium commits locally applied on WPT:
c4b9eceb1b "Remove XRSessionDeviceConfig.uses_input_eventing and related code"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I58dbc50e8c83e043688373dac3d44d0204f62dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614453
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157825}
Restore pixel_moving_filter for NeedsFullDamage in SurfaceAggregator
When kAllowUndamagedNonrootRenderPassToSkip is on, it's possible to
modify the in_pixel_moving_filter_pass condition to improve
NeedsFullDamage.
This CL restores the original requirement for
in_pixel_moving_filter_pass. This optimization can be added later
with a new feature flag.
Bug: 1346502
Change-Id: Ic1e71a23d5132ed9f5b092ddc14516e1f2fa7736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616725
Auto-Submit: Maggie Chen <[email protected]>
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157824}
Remove unused DeletingNavigationThrottle from NavigationRequest tests.
Change-Id: I43639235b1a324631ff37fb5d26365ea3487a103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608924
Reviewed-by: Nasko Oskov <[email protected]>
Auto-Submit: Igor Ruvinov <[email protected]>
Commit-Queue: Nasko Oskov <[email protected]>
Commit-Queue: Igor Ruvinov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157823}
[text-wrap-pretty] Support other types in `NGLineWidths`
This patch changes `NGLineWidths` to support all other types
of `NGInlineItem`, making it a feature complete.
The test condition in `NGLineWidthsTest` is updated so that it
can print better messages on failures.
This patch has no behavior changes as all changes are under a
runtime flag. Future patches for `text-wrap: pretty` will use
this class to support simple floats.
Bug: 1432798
Change-Id: I4ec5f15162b1b4bfc212ffea35255c8a9e7c365b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613370
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157822}
diagnostics: adjust legend bar styling
- Increase height and border radius for legend bar to improve contrast.
Screenshot: http://screen/5f3AEwY2tRBkood
Spec: http://screen/84qqvtmu4YWAEBm
Bug: b:284207112
Test: Manually verified UI.
Change-Id: Ibe81d3247f6fd53dde90ce08c8d9fa7ad1e06121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616673
Reviewed-by: Michael Checo <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157821}
Disable TabSwitcherMultiWindowTest#testMoveTabsAcrossWindow*
Bug: 1454902
Change-Id: I381e8a2ece326994abdfaf2e1aa10bb2f0ece1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616677
Auto-Submit: Theresa Sullivan <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157820}
[FedCM] Fix a mismatch UI reshown issue
If a user has gone through the "Sign in to IDP" flow, the IDP will send
a "sign-in" header to the browser. However, it's possible that the next
account fetch ends up with no valid response in which case there will be
another mismatch.
This patch fixes an issue of reshowing the UI. More discussions on the
expected behavior in such case can be found in crbug.com/1454783.
Change-Id: Ifdc6b3d7359c5de50ae3c2132ce138ad35db93c9
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616161
Reviewed-by: Zachary Tan <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157819}
Disable benchmark stories that fails move than 30%
The list of benchmarks to be disabled is from failing benchmark monitor dashboard:
http://go/chrome-perf-benchmark-fail-dashboard
Stories to be disabled:
media.desktop/video.html?src=boat_1080p60fps_vp9.webm for win-laptop
system_health.memory_desktop/browse:news:cnn:2021 for win10
rendering.mobile/gpu_bound_shader.html for pixel-6-pro
Bug: 1452148
Change-Id: I2e99781e2069c30f84bc68c7b64fc616bd9a35d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616048
Commit-Queue: Max Li <[email protected]>
Reviewed-by: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157818}
updater: Fix crash in the offline installer when OS is not supported.
The root cause is an uninitialized member `install_progress_observer_ipc_`.
Fixed: 1454497
Change-Id: I27e925a7e81f15de95da9dc756f20a620ad8e8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616388
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157817}
Suppress top paint test flake are flaky on all Mac13
Bug: 1451329
Change-Id: I413c01b846d872c1a653e82b3ab4ec97b60a8b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616392
Commit-Queue: Vivian Zhi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157816}
Add histogram for ChromeOS installer op retries
This histogram tracks the retries around a specific mounting operation
in the CrOS installer. The bug was a race condition that only existed on
base images, making it very hard to troubleshoot. This histogram is part
of a set of follow up items.
platformer2/installer CL: crrev/c/4611084
Bug: b/284522064
Change-Id: I4be6b4ead638b05c476178e5f09366b420020b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609454
Auto-Submit: Khionu Sybiern <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Commit-Queue: Jesse Doherty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157815}
Roll ios_internal from 44eb5bd19dfe to e0aa1738397a
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/44eb5bd19dfe..e0aa1738397a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Icc2d1794f30684de4d1d9cf11af0f94170df36d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616628
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157814}
Bookmarks++: Fix app menu crash (hopefully, take 3)
Adds logic to consider IDC_SHOW_BOOKMARK_SIDE_PANEL part of the
bookmarks menu. This gives BookmarkMenuDelegate control over
interactions with that menu item. BookmarkMenuDelegate already had logic
for handling this menu item introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/4591041 so
this CL just standardizes that behavior across both instances of the
menu item.
Bug: 1452202
Change-Id: I621c82c35218ce6e46163eaa09ac7a438d33af71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616671
Commit-Queue: Emily Shack <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157813}
Run interative_ui_tests instead of content_browsertests on mac13-arm64-rel
Switching to this test suite since it requires less shards, which will ease
demand on Mac13 machines.
Bug: 1449989
Change-Id: Ida4958c8b32780cc4fbd29d87472cf8d1a70e09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614363
Reviewed-by: Lindsay Pasricha <[email protected]>
Commit-Queue: Lindsay Pasricha <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157812}
[23Q2Fixit] Deflake TabSwitcherTabletTest#testToggleIncognitoSwitcher
Deflake TabSwitcherTabletTest#testToggleIncognitoSwitcher.
-Suspect that bitmap fetch count is not properly being reset between
runs.
Bug: 1454895
Change-Id: Ic47b764374a7ff3e8a49454cc48aaccc110a9363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616884
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157811}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I10d57ab7ed8d5cd023e82d559f801e53d49cbecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611805
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157810}
Read Later: Remove unused CSS
Bug: 1399976
Change-Id: Ibf2e8b43dbb31d2337e0cd65e1c996212dbf947e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616412
Reviewed-by: Emily Shack <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157809}
IWYU ui/color/color_provider_manager.h, ui/gfx/color_utils.h
Add an explicit include for classes which were included via a
transitive dependency in color_provider_manager.h (they may have
been included via multiple hops).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I7f389b7b150a617ce3a35fec8ffcca54a8789d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611785
Auto-Submit: Sean Kau <[email protected]>
Reviewed-by: Keren Zhu <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157808}
flag/lacros-color-management: update metadata
Update the metadata and descriptions for lacros-color-management flag.
BUG=b:286897099
Change-Id: I397777aace5c104f4676c5dea9fa36b0460edaff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608731
Reviewed-by: Brian Ho <[email protected]>
Commit-Queue: Femi Adegunloye <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157807}
[Pulsing ink drop] Apply pulsing action highlight to all Buttons
Today pulsing highlight is only used by ToolbarButtons when they are anchored an IPH bubble. To apply this effect to all the Buttons and also make this feature serve a general purpose of "draw users attention" rather than a feature specific to IPH, this CL does the following:
1, Factor out PulsingInkDropMask from ToolbarButton;
2, Implement a default pulsing effect in InkDropHost using PulsingInkDropMask and expose ToggleAttentionState(bool) to users that want to toggle a Button's attention on/off;
3, IPH uses ToggleAttentionState to toggle its anchored button effect on/off.
This CL also refactors ink_drop_host_unittest to better accommodate attention tests.
Change-Id: I471d870dbaed0fab3208ce43d783a9ee0bfc0010
Bug: 1419653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571354
Commit-Queue: pengchao Cai <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157806}
[dPWA] Add more safety checks for manifest id
[email protected]
Bug: 1453796
Change-Id: Ie5bf528447e0bbd7ce5e8880484da5a2482c808c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606433
Reviewed-by: Dibyajyoti Pal <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157805}
[SparseObjectPaintProperties #2] Implement pure virtual ObjectPaintProperties
This patch is the second in a series for the SparseObjectPaintProperties
experiment. In this patch, the ObjectPaintProperties is changed from an
empty class to a pure virtual base class for ObjectPaintPropertiesImpl.
NOTE: after the conclusion of the SparseObjectPaintProperties
experiment, this class will be deleted--so to keep it similar to how
the ObjectPaintPropertiesImpl class is implemented, it uses the same
style of preprocessor macros, even though they are something of an
anti-pattern.
The Project:
SparseObjectPaintProperties is a cleanup project with the goal of
lowering the total memory cost of the ObjectPaintProperties class,
through the use of a new SparseVector class that allows for zero
memory overhead for null pointers. If successful, this project should
significantly the total memory usage of this class and hopefully
impact Chrome's memory usage in general.
Bug: 1454638
Change-Id: I643c0aa6b5a3e593379f8d738ae7aa450164221f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611813
Commit-Queue: Jordan Bayles <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157804}
Add discard and memory usage accessible strings
Adds tab discard and memory usage accessible strings so when the user
tabs over a discarded tab, or a tab that has memory usage information,
the screen reader will announce that the tab is discarded with the
amount of memory saved through discarding or the tab's current memory
usage.
Note that accessible labels for tab alerts are usually more succinct
than what is written on the hover cards. So the string that a screen
reader will read aloud differs slightly from what is written on the
hover card.
Bug: 1424226
Change-Id: I8fbf15dbdc70eedcd8b2580dfb1b1dec0f87c03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601817
Reviewed-by: Eshwar Stalin <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Commit-Queue: Steven Luong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157803}
Fix downloads section header chevron bounds.
Before: http://shortn/_7ojHM0n6z1
After: http://shortn/_dmEqxSQ8hp
Bug: b:287284032
Change-Id: Ia21b0588d575b9a5b802eb2a23c66bd498d589fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615634
Commit-Queue: David Black <[email protected]>
Reviewed-by: Colin Kincaid <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157802}
[Bisection] Set up new builder for test failure bisection
In this CL, I set up the builder to run a test for the purpose of test bisection.
The test recipe file was added in https://chromium-review.googlesource.com/c/chromium/tools/build/+/4609862 (just skeleton, content will be added later).
Bug: b/286986518
Change-Id: I41c66514a620175ec6eaabc211dc2b19c892f90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612746
Commit-Queue: Tuan Nguyen <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157801}
Disable sqlite dbfuzz2 when code coverage enabled.
This fuzzer does not link successfully when code coverage is enabled,
for unknown reasons. This appears to be due to the lack of a symbol in
the underlying sqlite3 component .so, even though it is being linked
with -Wl,--whole-archive.
Temporarily disable this fuzzer in code coverage builds to unblock work
on the code coverage dashboard, while we investigate.
Bug: 1454880
Change-Id: If5722c76fdb2fb95b7600f0128ea6abdb54ca925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615085
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Adrian Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157800}
[Printing] Add PrintSettings metrics for non-square pixel printers
In https://crbug.com/1442457, Print Preview rendered incorrectly when
selecting a non-square DPI printer. There are no metrics to measure how
many users were affected by that issue.
Add a new metric that measures how many printers have non-square pixels.
Bug: 1446113
Change-Id: Ia9d2eb1e91554506fc695dd82171ff0a61ba93de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611506
Code-Coverage: Findit <[email protected]>
Commit-Queue: Andy Phan <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157799}
Add WebAPK retry flags to chrome://flags
Bug: 1409642
Change-Id: Ib344356fde1ffb7bdf11750187bb429dddb87f2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615225
Commit-Queue: Ella Ge <[email protected]>
Reviewed-by: Glenn Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157798}
Support updating updateURL
Fixed: 1444431
Change-Id: I993712b02834458cf48e2d77f76aa349bb794e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616009
Reviewed-by: Caleb Raitto <[email protected]>
Commit-Queue: Youssef Bourouphael <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157797}
Re-enable AutofillProgressDialogViewsBrowserTest ClickCancelButton
In chromium-
review.googlesource.com/c/chromium/src/+/4405587/comment/f63383ed_bf6147
48/, Dominic asked to re-enable ClickCancelButton test by
adding destroyed_waiter similar to CloseDialogWithConfirmation.
Added destroyed_waiter to re-enable this test so that it gives unit test
coverage for the AutofillProgressDialogViews::OnDialogCanceled() case.
Change-Id: I0004e2cfc8ff6d9a10956181b9adb996f29caf5f
Bug: 1443019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609240
Commit-Queue: Jiali Huang <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Vinny Persky <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157796}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
Bug: b:286952053
Change-Id: I3a96a92799ad825378d6c14cc0f3b4bbda4df410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616683
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157795}
Prefetch: Implement eviction on candidate removal
This CL updates PrefetchDocumentManager to now evict prefetches when
a candidate is removed. Note: In the case of multiple candidates for
the same URL, we only evict when all candidates with the URL are
removed.
Bug: 1445086
Change-Id: Ib707008103c3868c2c8e2de5e3052ebe3c460601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569056
Reviewed-by: Iman Saboori <[email protected]>
Commit-Queue: Adithya Srinivasan <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157794}
[color] Update color_id and sys_color_mixer to latest UX spec P2
This CL updates the themed palette to the latest values.
Bug: 1408545
Change-Id: I9224138cc56c9a90a475aec8bf818f7b99d451ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613405
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Code-Coverage: Findit <[email protected]>
Auto-Submit: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157793}
Do not activate Anchored Nudge widgets when shown
Use `ShowInactive` instead of `Show` when showing Anchored Nudges so the
focus is not brought to the widget.
Bug: b:287112608
Change-Id: I307f824a6bd3c23baa8f30624f1e4393a8665491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616153
Commit-Queue: Kevin Radtke <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157792}
[ntp][lms] Hide images with broken links when a collection is opened
*Video demo in bug comments*
Change-Id: If85a07a1ad6567b8615bb07611ade66f0829ddc0
Bug: 1433301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584415
Reviewed-by: Rohit Agarwal <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Paul Adedeji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157791}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686754776-9a91169b44d8b51e65c5785e46057357ced3f59c.profdata to chrome-win32-main-1686765533-0419320b99716471702201fbc44a94a5e7181fa3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ib9ecbcb28cc93421e0b0f3b2e3fb8435d7a77f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615661
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157790}
Roll wpt tooling
This rolls wpt to latest commit at
https://github.com/web-platform-tests/wpt.
REMOTE-WPT-HEAD: 112626065f296e24461beee136008f5ec40b90ca
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I403df30c7bbe48bba17943ff31338c65bdf0242d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615747
Commit-Queue: Alex Turner <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Auto-Submit: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157789}
[Desktop][UX Enhancements] Card Unmask OTP Input Dialog
This CL contains several UX enhancements to the Card Unmask OTP Input
Dialog:
1) It moves the GPay Logo to the right of the title
2) String enhancements in the title, placeholder text, and footer
Mocks: https://screenshot.googleplex.com/6hvKMEyW7FZxuax
Before: https://screenshot.googleplex.com/9z5RFx4VPT9dDtr
After: go/strpic/06fc7c2b8b0f8dcd890f0c298766119abe20e150
Bug: 1453325
Change-Id: I86300d7ec7280488dc49adb61b4c88976cf96f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613605
Quick-Run: Junhui He <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157788}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686754776-64fec57127d4e24f1e31fe0b507d059b06d1ce09.profdata to chrome-win64-main-1686765533-1894346b5888f16faf9050fe055ea8d49e370447.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I1b817a6f8f70b7e4ea7efb2db40e6b3c3d679919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616625
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157787}
Show notifications for Cast sessions started in Lacros
Add a new KeyedService called CastNotificationControllerLacros that manages Cast notifications on Lacros. The class has similar responsibilities to ash::CastNotificationController on Ash.
Bug: 1453967
Change-Id: I4ddd0237cf374076cc5ccb657d9e41804d0a7ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592290
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Muyao Xu <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157786}
Fix focus dependency on dialog title test.
The test BrowserViewTest.GetAccessibleTabModalDialogTitle validates that
the window gets the title from the focused dialog. But this dependency
on focus made the test fail on Lacros and Fuchsia where the popped up
dialog is not focused by default.
This moves the test to interactive_ui_tests where focus handling can
work correctly.
Bug: 1326648
Change-Id: I50c19cfbb45f6cf2824636484a42fe9abd9e3bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616151
Commit-Queue: Brett Wilson <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157785}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: Ie3a08a9465f9e74fea2216b7cfc94dc7e34c6616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611276
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157784}
Update V8 to version 11.6.149.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/316e1601..75794115
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ic471b16750e2e8325e34beda031b4bfa5736baac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614360
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157783}
Migrate fill-and-stroke-styles.yaml to new test generator.
Change-Id: Ibc2dda19e37095a191fcb8054a9c4ae20fd62a3c
Bug: 1275750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562294
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Reviewed-by: Yi Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157782}
[A11y] Speculative fix for RemoveSubtreeWhenSafe()
RestoreParentOrPrune() could potentially call RemoveSubtreeWhenSafe() with a null node, or a node that has been detached.
Fixed: 1454690
Change-Id: I746bfae4fe3307e820292107585735931673dd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614327
Commit-Queue: Chris Harrelson <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157781}
[FedCM] Add metrics for mismatch dialog
This metric will be used in the IDP sign-in status API origin trial:
1. Blink.FedCm.IdpSigninStatus.MismatchDialogResult
Bug: 1451536
Change-Id: Iafdf0834027f48178fd76033f068d983fa92f8c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594927
Reviewed-by: Yi Gu <[email protected]>
Commit-Queue: Zachary Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157780}
[PDF Viewer] Validate params page value input is in bounds
When parsing the URL param `page`, the page number provided by the user
may be out of bounds of the number of pages. The page number should be
clipped when out of bounds.
To check the upper bound, OpenPdfParamsParser must store the page count.
Fixed: 1453872
Change-Id: I097c821f537526621c83274b4d49250aed643151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608385
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Andy Phan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157779}
Revamp chrome://location-internals to use non-polymer web component
This CL revamp chrome://location-internals from legacy plain DOM into
using non-polymer web component. It introduce DiagnoseInfoTableElement
which essentially a table element with encapsulated methods for creating
table data or update caption name.
Bug: 1110995
Change-Id: I478da1b29f7ed0736c3128ff06f96381712c088c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582855
Reviewed-by: Matt Reynolds <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Alvin Ji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157778}
Roll src-internal from 6ad6808934aa to 9fe891904b03 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ad6808934aa..9fe891904b03
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1453753
Tbr: [email protected],[email protected]
Change-Id: Iaf2325b78b3e230fd41ea6c2a70efbb9983637dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615662
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Hamda Mare <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157777}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I73853eb50a236a0192239359262bee07c6c8833e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611733
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157776}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686758346-f228fc14950ae53b74df10aa18d8075891994471.profdata to chrome-mac-arm-main-1686765533-a135384ef988ebc52685b72137ea203f044f4c75.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I93569ddb14613e76fe84e9ef7722d39d49ac2f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615777
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157775}
Remove expired Graphics.Smoothness.PerSession.MaxPercentDroppedFrames_1sWindow
This metric expired and is no longer interesting. So removing it.
OBSOLETE_HISTOGRAM [Graphics.Smoothness.PerSession.MaxPercentDroppedFrames_1sWindow]=expired and no longer needed
Bug: 1441556
Change-Id: I68dd4eeb879d9622f413142609daed97e65e7a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607148
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157774}
Reland "Handle session state changes for anchored nudges"
This is a reland of commit dc7339d548121d5729ebef97963e9c5c1b816a4c
Compile error was caused by a test that was not updated after rebasing.
Original change's description:
> Handle session state changes for anchored nudges
>
> Close all shown nudges whenever the session state changes.
>
> Bug: b:281730880
> Change-Id: I118a4ad19ca6b729ffc46dd15bf5b4e849baad83
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575097
> Reviewed-by: Andre Le <[email protected]>
> Commit-Queue: Kevin Radtke <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157630}
Bug: b:281730880
Change-Id: I1e1778490ab59512743fe4010828965559a6ef37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616026
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Kevin Radtke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157773}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686743662-c8267b8ceb10f216f1d5ab5d1b61897c36fe8886.profdata to chrome-mac-main-1686765533-f0cef0ec260ee1cb9f2018748777938267bb1364.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I4f8add0e4e5b2b616df774d3b246593f5a2082e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615459
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157772}
[omnibox][cr23] Update row height from 36px to 40px.
crrev.com/c/4594836 (m116) & crrev.com/c/4609244 (m115 merge) launched
uniform row height at 36px. That was an accident, they were supposed to
launch at 40px.
This CL updates the default value to 40px.
This won't be merged to m115. There's a finch experiment that overrides
the param to 40px that's launching at 100% for m113+. So users will
still get the correct 40px experience once that lands.
Bug: 1368852
Change-Id: I03c384fbe2548321fff286c5d9444b7c435b59b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613066
Auto-Submit: manuk hovanesian <[email protected]>
Reviewed-by: Khalid Peer <[email protected]>
Commit-Queue: Khalid Peer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157771}
[PriceInsights] Open side panel
This CL implements the PriceInsightsIconView#OnExecuting method to open
the price insights side panel.
Bug: b/285996573
Change-Id: Ie3f1a05f358553c769d99b0bd2b544d81146b318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601998
Reviewed-by: Zhiyuan Cai <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Emily Shack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157770}
[Nearby Presence] First time registration: download credentials
Adds logic to the CredentialManager to download remote devices'
credentials from the NP library during the first time registration flow.
Next, the CredentialManager will save these credentials to the NP
library over the mojo pipe to complete the first time
registration. This logic reuses the existing scheduler for the
request in order to ensure exponential retries and network
connectivity. The conversion from SharedCredential to
PublicCertificate protos is a skeleton due to an open question
about missing fields, which will be added as a follow up.
Tested: Unit tests only
Bug: b/276307539
Change-Id: If7b116980daf185d6ca9e5507142237612d4c19c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4549918
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Juliet Lévesque <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157769}
Roll Catapult from c684fe031218 to c87640687ea0 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/c684fe031218..c87640687ea0
2023-06-14 [email protected] [chromeperf] Add skeleton for buganizer client get calls
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1447930
Tbr: [email protected]
Change-Id: Ic9f4ba68ce20a113736ae88e76d337189bbd9770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615953
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157768}
updater: clean up after REGDB_E_CLASSNOTREG errors have been resolved.
The code that dumps CLSID entries is kept in case it needs to be used
for diagnostic in the future.
Fixed: 1425609
Change-Id: Iaca7707db6357d7e34a2d9ec99eca38d1b4dfb6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616551
Commit-Queue: S Ganesh <[email protected]>
Auto-Submit: Sorin Jianu <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157767}
[SmartLock] Restore SmartLock.AuthMethodChoice.Unlock metric
This metric was recently deprecated but requested by PM to be restored.
TEST=existing unittests pass
Change-Id: I3511148252f35541032466e7169f7477df763773
Bug: b/208932781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609455
Commit-Queue: Brittany Hartmire <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157766}
[Frameworks roll] Roll to 540334676 piper revision
Change-Id: I4919f63b24e2374139485f43aac9236c150750da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616723
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157765}
Add missing OAuth 2.0 scope for editing tasks (marking them as done)
`tasks.patch` [1] request fails with an "insufficient authentication
scopes" error since it requires additional non-read-only scope [2].
[1] https://developers.google.com/tasks/reference/rest/v1/tasks/patch
[2] https://developers.google.com/identity/protocols/oauth2/scopes#tasks
Bug: b/269750741
Change-Id: I6306e174c42e5ad0505a3d49a964a7e808826550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614289
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Artsiom Mitrokhin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157764}
Minor clean up for ImprovedBookmarkFolderView.
* Temp variables to reduce resources calls.
* Adjust comments.
Change-Id: Ida986d35604a8e75b6ab2c923f3a45a8a32ba14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615061
Code-Coverage: Findit <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157763}
Roll Infra from b352055430ac to 39f255d58752
https://chromium.googlesource.com/infra/infra.git/+log/b352055430ac..39f255d58752
2023-06-14 [email protected] WIP: add generic container template logic
2023-06-14 [email protected] Roll luci-py from 9aae13b2addf to 78636fd7c842 (1 revision)
2023-06-14 [email protected] Manually Roll luci-go from cf3a2ecd672d to 0e97ef942d67 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I151c7b6cbafeeeb426b9498d0a7d0dffd8d94615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615060
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157762}
[SuperSize] Viewer: Add "#focus=..." to link to a symbol node.
This CL adds the following UI feature:
1. Clicking on a symbol node adds hash "#focus=<target symbol node ID>"
to the URL.
2. Loading the Viewer with "#focus=<target symbol node ID>" in the URL
causes the Symbol Tree to expand to the target, and sets focus to it.
(2) performs "expansion cascade" of the Symbol Tree. How it works:
* Pass symbol node ID to QueryAncestryById() in Caspian to get the path
if ID's from root to the target, e.g., [A=root, B, C, D=target].
* Store adjacent pairs in the ID path as key-value pairs for a Map,
e.g., {A: B, B: C, C: D}.
* Existing logic already successively expand single-child groups (using
simulated clicks). Adapt the logic and use the Map above to
propagate expansion, e.g., if A expands, get A -> B, search A's
children for node whose ID is B, and expand it.
* On expanding D, ensure it gains focus when added to DOM.
Details:
* Add |state.stFocus|:
* Add STATE_KEY.FOCUS = "focus"; add MainState field |stFocus|,
instantiated with |isHash| = true.
* Explicitly call updateUrlParams() on state change, since it's not
tied to a form.
* The state is set when a Symbol Tree node receives focus (by
mousedown or keyboard navigation).
* The state is cleared when:
* Invalid symbol node ID is given.
* The Symbol Tree loses tree focus (SymbolTreeUi.onTreeBlur()).
* buildTree(), i.e., on subsequent tree rebuild, since these would
change the Symbol Tree's structure, invalidating the IDs.
* SymbolTreeUi:
* Add |expansionIdMap| as Map for expansion cascade.
* Add planPathExpansion() to populate |expansionIdMap|.
* Overload autoExpandAttentionWorthyChild() to expansion cascade
expansion, falling back to the base function if applicable. Note
that dom.onNodeAdded() is needed to set focus to the target.
* ui-main.js: Add planSymbolTreeFocusPathExpansionIfRequired(), and call
it in performInitialLoad() to detect "#focus=..." and to trigger
expansion cascade by calling SymbolTreeUi.planPathExpansion().
* Handle "hashchange" event in |window| and reload page in response:
This overrides the jarring default behavior, where changing only URL
hash does not cause reload (unlike query parameters).
Bug: 1001769
Change-Id: I2d4610495a20fae18b48732365299a9139b8da3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599100
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157761}
Fix re-entrance of permission request finalization
Bug: 1453992
Change-Id: I1ce1198f7d6d3ee24e4253b92814de65d5351be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609125
Reviewed-by: Florian Jacky <[email protected]>
Commit-Queue: Elias Klim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157760}
Roll Skia from b06e934cb637 to 8f0ef5e2d300 (6 revisions)
https://skia.googlesource.com/skia.git/+log/b06e934cb637..8f0ef5e2d300
2023-06-14 [email protected] Add WGSL support for exponential intrinsics.
2023-06-14 [email protected] Fix G3 roll
2023-06-14 [email protected] Reorganize parameters to new drawEdgeAAImage method
2023-06-14 [email protected] Move tiled image draws to operate at the Device level (take 2)
2023-06-14 [email protected] Roll vulkan-deps from 5b7ee750e5e8 to a3ea6d67d5de (3 revisions)
2023-06-14 [email protected] Refactor SkJpegXmp into SkXmp which is more generic.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Ia85cacec053bca7b3b7b23c6507a0b96c4e404f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615954
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157759}
[signin] Remove signin_metrics::AccessPoint::ACCESS_POINT_CONTENT_AREA
1. Delete the code related to `ACCESS_POINT_CONTENT_AREA` in the C++
code;
2. Delete the code related to `ACCESS_POINT_CONTENT_AREA` in the
Objective-C code;
3. Delete related metrics
Bug: 1453555
Change-Id: I0818af1c5ee9e2e89c40cea2269539710b84be8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613107
Reviewed-by: David Roger <[email protected]>
Auto-Submit: Ho Cheung <[email protected]>
Reviewed-by: Michael Wilson <[email protected]>
Commit-Queue: Michael Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157758}
Roll Depot Tools from f407ae35d322 to defdda0c6241 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f407ae35d322..defdda0c6241
2023-06-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: Ibe15314e351c9ced34074ca71f55e6b467d7ada7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615296
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157757}
[DTC] Adjust consent dialog string
Adjust the main body text on consent dialog to match the proposed string on UI Review.
Change-Id: Ib0f32bd69868d0c05fbae4f04a9eef683dec92f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616224
Reviewed-by: Sébastien Lalancette <[email protected]>
Commit-Queue: Zonghan Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157756}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686743662-938f5d72d478557f00ae04a0b4bf2070f779100d.profdata to chrome-linux-main-1686765533-ed123a6eb86767f0a48c9442c06a0c2133906043.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I0bd4374402d0e2cb215e5d58a49a5e5e75a3a5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615660
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157755}
Extend histogram expiry: ContentSuggestion.${FeedType}.LoadMoreTrigger.*
This CL also updates histogram ownership.
Bug: 1454166, 1454167, 1454168
Change-Id: Id4a6073ad7104b182307be830e1d5de55cbfa258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609516
Commit-Queue: Justin DeWitt <[email protected]>
Auto-Submit: Roger McFarlane <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157754}
[lacros desk restore] Add logging for lacros windows desk restore
A user experienced missing lacros windows when opening saved desk.
This is the only datapoint we have so far. This CL plants loggings
in prod to debug save-restore flow if same issue ever reported again.
This CL adds loggings at three locations where:
1, restore data is written into file
2, Ash tries to launch lacros windows from read data
3, lacros tries to create windows with data from Ash.
Change-Id: Ib45945278598a437666c4992d19c6b278734a483
Bug: 1442076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604976
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: pengchao Cai <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157753}
Base floating workspace restoration on sync update ready api
Bug: b:194507810
Change-Id: I4ecb719ad3719dce15e66582aa5da7b225e1bed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4559789
Reviewed-by: Kevin Radtke <[email protected]>
Commit-Queue: Geng Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157752}
Update cores target for Libfuzzer Upload Mac from 24 to 12
Bug: 1442071
Change-Id: I03fd4dfe16fb195fad0fd3f37d7a36f083e983dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616228
Commit-Queue: Lindsay Pasricha <[email protected]>
Owners-Override: Kuan Huang <[email protected]>
Reviewed-by: Kuan Huang <[email protected]>
Reviewed-by: Kuan Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157751}
wallpaper: fix DCHECK when fetching very old wallpapers
This DCHECK unfortunately comes up when the user uses a very old
wallpapers (which pre-dates the personalization hub), and that result
in the urls not saved in `WallpaperInfo`. Instead of blocking with the
DCHECK, this CL relaxes the condition and calls the callback to exit
gracefully.
BUG=1454616
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I6ed0d1af11ced1c24618c1dba93d64a0dd966016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616148
Reviewed-by: Jeffrey Young <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157750}
Roll devtools-internal from 78fc3badfe46 to 0f0a49bcd25c (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/78fc3badfe46..0f0a49bcd25c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ibf67ad0f7d990ea1228904efb32592548de1690c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615834
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157749}
Roll goldctl (win) from yDoSOjnzDYE9APn8a... to yW7os_HVMoE-wq04o...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (win): https://bugs.chromium.org/p/skia/issues/[email protected]
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: If80f4293e6800a51e0066772922e4cbe8738feee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616189
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157748}
Roll Perfetto from e314b79bfe9e to 54280e702d09 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/e314b79bfe9e..54280e702d09
2023-06-14 [email protected] Merge changes I7dd67d71,I0cf8075d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Iad1fc6ecbad8fda0a47e7ec46260eb77446d1b58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615292
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157747}
float: Add MultitaskMenuViewTestApi
Bug: none
Test: existing tests
Change-Id: I7ee519b0b543ecba547c12ffd0152e6efa989e64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608626
Reviewed-by: Sophie Wen <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157746}
[Tab Switcher] Disable Composed Favicon for Grid Mode
UX requested that we don't show the composed favicon in grid mode. Only
show in list mode.
Bug: 1454850
Change-Id: Ibf813bca96c2868d364a2ca739a2278b856a2948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598511
Commit-Queue: Calder Kitagawa <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Brandon Fong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157745}
Bugfix: Return early for GLTexturePassthroughRep creation failure
Return early if fail to produce GLTexturePassthroughImageRepresentation.
This doesn't fully fix the issue as there would be a crash elsewhere
and would be nice to know the root cause of issue.
Bug: 1410516
Change-Id: I883b5eca0002077452f000e721535a05d18b1c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616225
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Saifuddin Hitawala <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157744}
Report URL sources for focused frames even when non-editable
To support Windows' text services framework integration, the browser
should report URLs even for frames which do not contain traditional
editable controls (as such controls could be reimplemented/emulated in
JavaScript, for example).
This change adds a text store of text input type: TEXT_INPUT_TYPE_NONE
to enable communication with TSF for frames without editable controls.
This change notifies TSF via OnAttrsChange whenever a frame is in focus
and has an associated URL.
BUG=1447061
Change-Id: I74e34c2e963b43d1b3b139972e0cf24de94a7120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4549348
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Eric Lawrence <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157743}
Record specific render pass types in SurfaceAggregator
Record whether a frame contains copy requests, pixel-moving filters, pixel-moving backdrop filters, and unembedded render passes per frame.
Bug: 1346502
Change-Id: I9aa8c5e26fcb12a8deb6388103fdb7721f383e18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605364
Reviewed-by: Jonathan Ross <[email protected]>
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157742}
Roll Fuchsia Internal Images from 13.20230614.1.1 to 13.20230614.2.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I8a141a2f7e0cbf2c94fe5fd0734cbfee67e24fa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615457
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157741}
[SparseObjectPaintProperties #1] Rename ObjectPaintProperties->ObjectPaintPropertiesImpl
This patch is the first in a series for the SparseObjectPaintProperties
experiment. In this initial patch, the ObjectPaintProperties class is
just renamed to ObjectPaintPropertiesImpl, to allow for the addition of
a pure virtual base class called ObjectPaintProperties.
The Project:
SparseObjectPaintProperties is a cleanup project with the goal of
lowering the total memory cost of the ObjectPaintProperties class,
through the use of a new SparseVector class that allows for zero
memory overhead for null pointers. If successful, this project should
significantly the total memory usage of this class and hopefully
impact Chrome's memory usage in general.
Bug: 1454638
Change-Id: I5b1b0412c8666f4c667b0e1269d7179e5da0097d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612247
Commit-Queue: Jordan Bayles <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157740}
Roll Open Screen from a3689b39e7d0 to 085a08030e24 (1 revision)
https://chromium.googlesource.com/openscreen.git/+log/a3689b39e7d0..085a08030e24
2023-06-14 [email protected] [OpenScreen] Remove TaskRunner* from constructor of FakeUdpSocket
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I870c2cab67e98a5ae210cbcda27be22ce18b51ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615654
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157739}
Roll Dawn from 19f92f9cdeab to f1ed14a74552 (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/19f92f9cdeab..f1ed14a74552
2023-06-14 [email protected] Roll vulkan-deps from 5b7ee750e5e8 to a3ea6d67d5de (3 revisions)
2023-06-14 [email protected] Add an option to toggle compilation of the GLFW utils
2023-06-14 [email protected] Roll ANGLE from 14339812a9db to 341dabf8e58e (4 revisions)
2023-06-14 [email protected] [cmake] Disable MSVC warning C4459
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I5bfedaa6a59f40c3322d7567577bd69a6e12bc2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615295
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157738}
[DevTools] Fix Page.printToPDF printing into tiny pages
Printing into tiny pages (like 0.001x0.001") was failing with "invalid print parameters" due to the target page having zero size in points which is unexpected and also broke some WPT tests. This CL replaces floating value rounding with ceiling which ensures that calculated target page size in points specifies outer dimensions. For tiny pages this results in at least 1x1 pt page dimensions.
Drive by: made Page.printToPDF error messages related to page size, printable area and content size a bit more specific.
Bug: 1454035
Change-Id: I2e9cdb88aba6241f31ccb8d81286dfdaed6d37ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611587
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Peter Kvitek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157737}
IWYU ui/gfx/color_utils.h
Dependency was transitively included through
ui/color/color_provider_manager.h which is being refactored
(to no longer provide this include).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: Ia04cd84b5229427b9cded9502a907dfe3c333a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611278
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157736}
Reduce flakiness in SigninSignoutIntegrationTest#testSignout
Add timeout to Mockito.verify calls to reduce flakiness.
Bug: 1451683
Change-Id: If4602b0a5be911cbb0c8738297ce149814caf8e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616150
Reviewed-by: Theresa Sullivan <[email protected]>
Auto-Submit: Mohamed Heikal <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157735}
[iOS] Move update Start call to navigation
Start updates don't need to be called on every visibility change, since
this includes scene state changes. Instead, they only need to be called
when navigating to/from NTPs.
Fixed: 1454019
Change-Id: I52dc348a0912b9862f3f9955661b039dd4415d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616324
Auto-Submit: Adam Arcaro <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157734}
[iOS] TangibleSyncScreenCoordinator dealloc checks stop was called
Bug: None
Change-Id: I3d525fe94c2b9c2b055791de209e39f829d07c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607389
Reviewed-by: Jérôme Lebel <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157733}
[Fixit] Fix non-browser package can't be found on Automotive
Fix UrlOverridingTest#testWindowOpenRedirect. Instead of use hard coded package name, read one of the installed
package.
Bug: 1416433
Change-Id: I8f8647310968767aacc333e4113b0d22c701ab44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609622
Auto-Submit: Wenyu Fu <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157732}
Roll goldctl (mac) from Btg2SHJpGjd1aivMS... to ov_DuOSHCneWQSTW6...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (mac): https://bugs.chromium.org/p/skia/issues/[email protected]
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I74a669ff014f07d5c0ef672e06446dc6ef80f044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614242
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157731}
CR2023: Update dialogs in Bookmarks++ and other side panels
Bug: 1399971
Change-Id: Ie45713a38b4b0103981d8a76676bdd931ec3ced0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611275
Reviewed-by: Emily Shack <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: John Lee <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157730}
Roll Chromite from 2b8358b431c6 to 9c40958316d5 (12 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b8358b431c6..9c40958316d5
2023-06-14 [email protected] cros-ide: metrics: migrate metrics.send in lint
2023-06-14 [email protected] cros-ide: metrics: migirate metrics.send callsites in gerrit
2023-06-14 [email protected] cros-ide: metrics: reinforce new GA4 Event types
2023-06-14 [email protected] Automated Commit: Updated config generated by config-updater builder.
2023-06-14 [email protected] Automated Commit: Updated config generated by config-updater builder.
2023-06-14 [email protected] cros-ide: metrics: migrate metrics.send callsites in device management
2023-06-14 [email protected] service: Fix import ordering
2023-06-13 [email protected] lib: Added type hints to portage_util.py
2023-06-13 [email protected] usergroup_baseline: Add spaced to crosvm grp
2023-06-13 [email protected] licensing: switch credits & print inline styles to common css
2023-06-13 [email protected] lib: Add type hints to lib/repo_util.py
2023-06-13 [email protected] dependencies: Affected reverse dependencies.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome
Tbr: [email protected]
Change-Id: I1a3081abfac9e156ddb4dd1fec41eea68cc2d1ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615665
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157729}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5832.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I291224ca40a758623e6c0d5a4d0e3a7fdd8f279a
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615745
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157728}
Add brcm_chrm_cas as a supported provider in relevant Connector policies
Bug: b/261848795
Change-Id: I5d1e375b901fca2399831f26530d53f70494e14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614326
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Nancy Xiao <[email protected]>
Auto-Submit: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157727}
Add mandatory re-auth manager backend component (3/4)
This CL adds the mandatory re-auth manager backend component for the re-
auth opt-in flow. It is CL 3/4, and in the final CL we will link
everything together to trigger the re-auth opt-in flow.
The authentication flow will later be refactored into the
MandatoryReauthManager as well.
test_autofill_client.h, which is just test code. It is also possible
the coverage delta is not accurately reported in the case of inlined
code in .h files, as this code is being used in tests. I have filed
crbug.com/1448697 to double check this.
Bug: 4555994
Change-Id: I9433518bd7e1d8662764d4e9b912756cde60eb61
Low-Coverage-Reason: The low coverage warning is for
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4556577
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157726}
Add ImprovedBookmarkFolderRowRenderTest to build.
Bug: 1449817
Change-Id: Ifa3eef0823fc5df0c03ba81fb43411b0a936342a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611512
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157725}
Roll ANGLE from af1768a48756 to 97e3851d1219 (3 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/af1768a48756..97e3851d1219
2023-06-14 [email protected] Clean up skipped deqp egl tests on Pixel 6
2023-06-14 [email protected] Implement "Shared Context Mutex" functionality.
2023-06-14 [email protected] Android: Pixel 7 and Oppo Flip N2 device support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1336126
Tbr: [email protected]
Change-Id: Ia614fb9b50e12255d54db47c6a0f4b98442628f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615267
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157724}
Roll goldctl (mac arm64) from SW3HcHhCf69xzWwap... to 3wDkZAVD4vV1dNhXf...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-arm64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (mac arm64): https://bugs.chromium.org/p/skia/issues/[email protected]
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I31af731943f6d90b4a400ca89a2e08e6a38d3ff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615453
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157723}
ChromeRefresh2023: Update TabSearchButton position and padding
For CR23, the TabSearchButton will be rendered on the opposite side of the frame buttons if it is also not a frame button.
In order to render the TabSearchButton above the TabStrip, the
GetChildrenInZOrder method is overriden, and then the TabSearchButton
is optionally rendered to its own layer and is ignored by the of the
FlexLayout.
Bug: 1399942
Change-Id: I524777125bf655e6f448365eea9fc76c8da8c564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4550000
Code-Coverage: Findit <[email protected]>
Commit-Queue: David Pennington <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157722}
float: Rename TabletModeMultitaskCue...
...to TabletModeMultitaskCueController.
Fixed: b/279220838
Change-Id: I392c5d170099a584bf8985aa0a962398bb73afd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606731
Commit-Queue: Sophie Wen <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157721}
Roll goldctl (linux) from TCcuUOFbPU3igS_xl... to tVDltUu_xw7_tk4k-...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl (linux): https://bugs.chromium.org/p/skia/issues/[email protected]
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I9ebb38818775c1ae2a233209e4fae79866a52858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615499
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157720}
Fix Tail Suggest ellipsis.
The change adds ellipsis dropped in crrev.com/c/4048680, and adds a
few extra unit tests to improve coverage.
The change addresses an issue with vertical placement of the Tail
suggest which was not properly reflected earlier: TextView does not
vertically align content until its measure specs are explicitly
defined.
The change expands TailSuggest to include Phone targets, where the
same ellipsis is missing. Same logic now encompasses both device form
factors.
The existing solution is not ideal, dealing with Views directly -
but due to lack of critical information needed to lay out text
correctly (target TextView width) this is the only reasonable solution
right now:
- TailSuggestionView should (and could) be just a TextView.
- AlignmentManager should be managed directly by the
TailSuggestionViewProcessor.
- Padding should be controlled via the means of a PropertyModel, and
applied as a start padding, not layout left/right edge.
- The challenge is that AlignmentManager requires the size of the view
receiving the padding.
Change-Id: Ifd047bed4afa7047ac8d92f433717b087c613585
Fixed: 1440526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610244
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157719}
Switch GPU websocket usage to threaded impl
Switches the GPU websocket server implementation to use the websocket
module's threading-based implementation instead of the asyncio-based
implementation.
This does not appear to have any significant performance impact, but
simplifies the code slightly and fixes some benign server shutdown
issues we had before.
Bug: 1453360
Change-Id: I022ab30b3819e9daa84ea8c692e7883e91064edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605768
Reviewed-by: Yuly Novikov <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157718}
Exposed Reuse Check Utility from ChromeWebView
Added the factories and boilerplate setup required to expose an API to allow reuse checks of CWVPasswords from the CWVWebViewConfiguration.
Bug: 1453748
Change-Id: I655e1213222c3e2532dd8d5692f9a38b667ab481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568867
Reviewed-by: John Wu <[email protected]>
Commit-Queue: Carlos Acosta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157717}
Add Chrome flags for testing Extensions Module in Safety Check
Bug: 1432194
Change-Id: If3137fa5fced66a24bd936abbe67a0bfb99a77b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610087
Reviewed-by: Javier Castro <[email protected]>
Commit-Queue: Anunoy Ghosh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157716}
Set VS Code tab size to 4 for Java code
As far as I can tell, most (all?) Chromium Java code uses 4 spaces for
indentation, not 2. The Chromium style guide defers to the Android style
guide on this, which explicitly states "We use four (4) space indents".
Change-Id: I1985dcd863c78d0dd389e268ba0484067018f049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614943
Commit-Queue: Chase Phillips <[email protected]>
Auto-Submit: Etienne Dechamps <[email protected]>
Reviewed-by: Chase Phillips <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157715}
Remove autotestPrivate test extension from ash keeplist.
The test extension is only used by browser test, therefore,
remove it from the ash extension keeplist.
Bug: 1448575
Change-Id: I00b7c29ff78b5bc8b4a8f68a33142fb541691526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611091
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Jenny Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157714}
[Privacy Sandbox] Add protobuf representation for attestations list
Add protobuf schema for the Privacy Sandbox enrollment/attestations
list, and a function to convert an istream for the serialized proto to
a C++ PrivacySandboxAttestationsMap.
This code is not yet used by the PrivacySandboxAttestations component,
but is covered by unit tests.
Change-Id: I4c8500ad4415d57f93ebd2bcfcb91a4f3123deb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605460
Reviewed-by: Xiaochen Zhou <[email protected]>
Reviewed-by: Shivani Sharma <[email protected]>
Commit-Queue: Garrett Tanzer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157713}
Roll src-internal from 69c27e547002 to 6ad6808934aa (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69c27e547002..6ad6808934aa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1431232
Tbr: [email protected],[email protected]
Change-Id: Ifeebbc316166d7dcc3b494364b745655589b06be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615266
Reviewed-by: Hamda Mare <[email protected]>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157712}
Roll Media App from rCTSNpbeNxtJLvVp9... to eKau9XPOtXGhEKd42...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202306140800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/eKau9XPOtXGhEKd42DI1UN95PS9S_xRtv0yhT8knGJYC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/281782550,b/281786158,b/281792020,b/285216732
Tbr: [email protected]
Change-Id: I11d339b0a45a104cfd0e6305a8632446b617dcb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615944
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157711}
immersive_mode: Set background to the top container view
This CL sets the background with the dynamic color to the top container
view when it's revealed in the immersive mode. It also avoid calling
BrowserNonClientFrameViewChromeOS::Paint to paint the frame header,
since it will be triggered by BrowserRootView::PaintChildren(). We can
avoid calling it twice.
Before fix:
1. Light Mode: https://screenshot.googleplex.com/9WLYoKjRuX4wuhv
2. Dark Mode: https://screenshot.googleplex.com/gS8pYWi5AeVshTo
After fix:
1. Light Mode: https://screenshot.googleplex.com/6bX6cpjunrFrcMy
2. Dark Mode: https://screenshot.googleplex.com/7Toa9xMJkH6Hzf3
Bug: b/277943803
Change-Id: Ia7fd7c3249fcef65e6f585fb58231bd55b9e270b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591042
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Connie Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157710}
Allow sandbox extensions to Metal's cache directories
Metal on macOS Sonoma performs shader compilation in a helper process
that is heavily sandboxed. Metal issues sandbox extensions to permit the
helper to access application-specific paths such as the cache directory.
If the sandbox does not permit these extensions to be issued, shader
compilation fails. This results in windows being rendered as mostly
blank.
Bug: 1453813
Change-Id: I8322a0affeb949df3d5e00d161bdec507c7399ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615625
Commit-Queue: Robert Sesek <[email protected]>
Auto-Submit: Mark Rowe <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157709}
Remove SK_USE_LEGACY_DISPLACMENT_MAP_IMAGEFILTER
Bug: skia:9282
Bug: b/263138152
Change-Id: Id16eb85eaa116c6769f9586a5feec44d45a75b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608561
Reviewed-by: Robert Phillips <[email protected]>
Commit-Queue: Michael Ludwig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157708}
Refactor AttributionDataHostManager registration context
Registration context fields are currently duplicated between the
ReceiverContext and SourceRegistrations. This CL extracts a new
RegistrationContext class that can be shared by both use cases. It also
extracts a navigation context class to ease its use.
This is ground work for being able to process additional registrations
in the browser process (i.e. parse the headers using the DataDecoder).
Today, only foreground navigation registrations and beacon source
registrations are processed in the browser.
Bug: 1374121
Change-Id: I9007abe0f0cbf11d6b27a61fa7ecbc8a03e43794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611290
Reviewed-by: Nan Lin <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Anthony Garant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157707}
[Topics] Let config_version be derived from params directly / not configurable via Finch.
Why: This is safer, as we won't have inconsistent
(config --> version) state from Finch misconfiguration.
Right now, we'd only stick to the default configuration. So the
CurrentConfigVersion() returns a constant.
Also, keep the internals page params up-to-date, as this patch
already touches the mojom/internals page files.
Bug: 1454266
Change-Id: I71b309e6b860b52daa5275522e128db9fd5d2ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608744
Reviewed-by: Joe Mason <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157706}
Revert "interest_group_storage.cc Migrate database code to base::Time serialization in sql//"
This reverts commit bf5185f73ab3b8178c97eb91b2a0ecbc064baf2e.
Reason for revert: The CL changed functionality by storing the full precision of the time instead of truncating it to a 24h period. Note that we were truncating the time to reduce database size by consolidating records.
Original change's description:
> interest_group_storage.cc Migrate database code to base::Time serialization in sql//
>
> This CL migrates code in interest_group_storage.cc to the BindTime() method provided by sql::Transaction.
>
> This CL does not introduce any behavior changes.
>
> Bug: 1195962
> Change-Id: I1822d9821e9a4d89f9aa7e6578977b061e614baf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900200
> Reviewed-by: Qingxin Wu <[email protected]>
> Commit-Queue: Christine Smith <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1048046}
Bug: 1195962
Change-Id: I36fa1976480b498f5c22c20549ac7238a2d72115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615905
Commit-Queue: Russ Hamilton <[email protected]>
Reviewed-by: Qingxin Wu <[email protected]>
Reviewed-by: Christine Smith <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157705}
Add FactorAuthViewFactory
Add a factory class for the creation of `FactorAuthView` objects,
centralizing creation logic and facilitating testing by allowing for
dependency injection.
Bug: b:271248452
Change-Id: I32317d8dc1c0c9a5d5bbf75996dbf207fc4a6946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4490104
Reviewed-by: Anastasiia N <[email protected]>
Reviewed-by: Istvan Nagy <[email protected]>
Commit-Queue: Elie Maamari <[email protected]>
Reviewed-by: Kyle Charbonneau <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Reviewed-by: Martin Bidlingmaier <[email protected]>
Reviewed-by: Mirko Bonadei <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157704}
[FedCM] Add metrics for showing IDP sign-in pop-up window
This metric will be used in the IDP sign-in status API origin trial:
1. Blink.FedCm.IdpSigninStatus.ShowPopupWindowResult
Bug: 1451536
Change-Id: Ic9196c6f0d09266aeb51e5bf254773be46ba299d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594359
Reviewed-by: Yi Gu <[email protected]>
Commit-Queue: Zachary Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157703}
Update HoldingSpaceTray foreground colors on activation changes.
When Jelly is enabled, HoldingSpaceTray needs to update foreground
colors on activation changes to ensure contrast with the background
which now respects accent color.
Bug: b:287098833
Change-Id: I99ce21021c86f0a729fe126177d2e338a10ecce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612251
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157702}
Do not use FakeDisplayDelegate in production code
GetNativeDisplayDelegate is used only by CrOS in production, or
ozone's demo, which can just be nullptr.
For CrOS, this CL introduces the native_display_delegate parameter
in shell's InitParam so that test can pass FakeDisplayDelegate, which
is used in some tests.
Bug: None
Change-Id: I1b2cd19ab625df476682d71e9b014b7fd9061fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611586
Reviewed-by: Gil Dekel <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157701}
CrxCreator: Open file with SHARE_DELETE and log open errors.
Bug: 1448891
Change-Id: If2041eb7812bffaa616386e615cfacdc3e79b7da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616127
Auto-Submit: Joshua Pawlicki <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157700}
[omnibox][CR23] Update suggestion hover fill shape per CR23 spec.
This CL updates the suggestion hover fill shape based on the latest
ChromeRefresh2023 guidance. More specifically, the shape of the
background rendered for suggestions in the omnibox popup is now rounded
on the right-hand side and shifted in by 16px.
One point to note is that the newly-introduced 16px space on the
right-hand side is a "dead zone" which does not react to user input
(click/hover) at this time. The exact bounds of this "dead zone" are
indicated by the second row of
https://screenshot.googleplex.com/63bJEFmco78Qsb8. In particular, the
area noted in blue reacts to user input, while the area noted in red
does not.
In order to support experimentation with this feature, a new
OmniboxSuggestionHoverFillShape feature flag is also being introduced by
the changes in this CL.
Low-Coverage-Reason: ChromeRefresh2023 UI update needs to be experimented with prior to investing in test coverage.
Bug: 1431337
Change-Id: I76fdde3b0d83e05cd97c0816a1eeb65f08412f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611098
Code-Coverage: Findit <[email protected]>
Commit-Queue: Khalid Peer <[email protected]>
Reviewed-by: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157699}
[A11y] Test pathological case: appending image using illegal map
This is the testcase for the Clusterfuzz issue in the referenced
bug, which no longer fails.
Bug: 1430764
Change-Id: Iee09a7b0d89c98ca5733bc86e60ba4c06e8cddb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4406637
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157698}
Extend expiration date and update owners of hibernate power metrics
Bug: 1441472
Change-Id: I26116a768192f0a290a7b7d97139d0906deb3a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602429
Reviewed-by: Miriam Zimmerman <[email protected]>
Reviewed-by: Olivier Li <[email protected]>
Commit-Queue: Matthias Kaehlcke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157697}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686743662-490e2ee9552b695d673012a14d92724384535b9b.profdata to chrome-win32-main-1686754776-9a91169b44d8b51e65c5785e46057357ced3f59c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I498ef2b65e366dd4d056dfd37833c6b86e2e819f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615265
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157696}
[ChromeRefresh2023] Profile submenu sync sections (sections 1 and 2)
This CL also adds back the AccessPoint::ACCESS_POINT_MENU enum which
was removed in crrev.com/c/4605293
Figma mocks:
https://www.figma.com/file/NLMJNd5s2g9DEDZCbIngJV/ChroMenu---Desktop-Scalability?type=design&node-id=2560-291355&t=PlIopfjOa2CcJCBY-0
Bug: 1427667
Change-Id: I8477122b3a2187e059d02e14d50b04855c3cd846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601837
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Elaine Chien <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Reviewed-by: Nohemi Fernandez <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157695}
Make Destination Throttler limits configurable, adds interop
The storage delegate is not running in the main thread, therefore moving the throttler to the storage layer so that it can access the storage delegate and retrieve the policy more easily.
Bug: 1453751
Change-Id: Ia706a9b20750ab4340d2624e6f87c54dee5fa6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604908
Reviewed-by: Andrew Paseltiner <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Thomas Quintanilla <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157694}
Convert unit_tests to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Note that this change ropes in ARCing of the main menu builder as
it was easiest to just include it all here.
Bug: 1280317
Change-Id: Ib7b28988f197826f9f092a059c6fe3632219f57d
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606036
Auto-Submit: Avi Drissman <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157693}
Roll eche_app from AGaYoE5HgGxUdavPZ... to waK-UatTYqwoGrm08...
Release_Notes: http://go/eche-x20/relnotes/Main/eche_20230614_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/eche_app/app/+/waK-UatTYqwoGrm083pgKXCnqgZtyr3MhO1cMe_QARUC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/eche-app-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/287113579
Tbr: [email protected]
Change-Id: I495a7046800d03d1a7b8d6f190182b320cf5d428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615050
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157692}
lacros/server: Propagate top inset from lacros to ash
Top inset property is used in ash to clip away header in overview and
mirror views and others. This is the server side implementation for
lacros windows to set their associated exo window's top inset.
ClientControlledShellSurface provides the logic for setting the top
inset on an exo window, so move it to ShellSurfaceBase where it can be
used by other exo windows in the future.
Bug: b/286417311
Test: exo_unittests *SetTopInset*
Change-Id: I4610125942756db54ee13eac033c56ed5457a275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609224
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157691}
[X-Device Restore] Add thumbnail placeholder icon
For tabs that do not have a thumbnail show a placeholder icon.
This is behind a flag ThumbnailPlaceholder and will be rolled out along
with the Cross Device Tab Restore flag. Which is being developed
as a separate component. Given the tabs for that feature will be
restored without thumbnails it is important to convey this is
intentional whereas the current placeholder color is possibly indicative
of loading or some other error has occurred.
This CL also adds
* Render tests for the new and old behaviors.
* Cleans up some layout defaults which is possible after changing phones
to use GRID_CARD_SIZE in an earlier CL.
Mock images:
https://drive.google.com/file/d/1KGpea8jzrhRaqnuk751C2oHGyWcGrznu/view?usp=sharing
Bug: 1441433
Change-Id: I709a002e207462c0b12893230ff55d158c4c3304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4456147
Reviewed-by: Mei Liang <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157690}
[installer] Flush the extracted setup.exe before closing it
We have a spray of setup.exe crashes on Windows 10 devices that appear
to be cases of the image containing either zeros or garbage where there
should be code. As an experiment, let's try flushing the file after it's
extracted and see if anything changes.
Bug: 1443320
Change-Id: I5c57a382cadda7088ee92fb55284c674eb93533e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613947
Auto-Submit: Greg Thompson <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157689}
Add Scaffolding to webui_examples to Support Mac
This allows the webui_examples build target to start building on Mac.
The UI changes necessary for this app to actually run will be in a
followup CL.
Change-Id: Id55cd7c5ffc75bb09223f5bfef8b8619ab434b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611158
Auto-Submit: Robert Liao <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157688}
[iOS] Updating the text shown when no shortcuts are available for the current user in the Shortcuts Widget
Bug: 1450219
Change-Id: Ie6e88838fad00d59c97f7eade5902935875e3ad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613109
Reviewed-by: Quentin Pubert <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Aliaa Alborhamy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157687}
Sync use of -Dunsafe_op_in_unsafe_fn flag with forbid_unsafe
Only apply the rust flag -Dunsafe_op_in_unsafe_fn to targets that
have a chromium_code config. This fixes building third_party crates
which require use of unsafe code for foreign-function interface
definitions.
Follows danakj@'s suggestion on how to address this.
Fixed: 1448457
Change-Id: Id4e915c2626b77c57a1c58b7656815e6beb853fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613986
Auto-Submit: Dominik Röttsches <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Reviewed-by: Zequan Wu <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157686}
Expanding live browsertests for companion.
This includes tests for PromoEvent and CQ.Shown histograms
for different log in states as well as side search and region
search functionality.
Bug: b:273308580
Change-Id: If76f304aff06b3f4ec1c4a8fd56efe81411f84b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599572
Reviewed-by: Michael Crouse <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Marco Georgaklis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157685}
Removed unused fields from ^components java code.
Generated with https://paste.googleplex.com/5494854149734400
Change-Id: Ic45c063923ee41fca43b51a86fc7bea060ecfd07
Bug: 1454830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611347
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157684}
Remove devtools test on Lacros.
The test KeepAliveDevToolsTest.KeepsAliveUntilBrowserClose was disabled
for CHROMEOS_ASH and was failing in Lacros. The tested condition in
chrome/browser/devtools/chrome_devtools_manager_delegate.cc uses the
define IS_CHROMEOS to disable keepalive which was changed in
https://chromium-review.googlesource.com/c/chromium/src/+/3849034
This change makes the test define match the logic, so this test is no
longer compiled for Lacros.
Change-Id: Idbcd1e787f4f2a6496c8f3cc980c932ac2b7350c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615630
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Brett Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157683}
[wpt-importer] Group and simplify new TestExpectations
This change switches the importer to the new high-level structured
`SystemConfigurationEditor` API, which can group and simplify related
lines. Formatting is now entirely handled by the low-level expectations
parser.
For the tests, check behavior with equivalent structured comparisons
after `write_to_test_expectations(...)`.
Bug: 1149035
Change-Id: Idd44e121139655aa76af00c775a063ce0a3f87e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595412
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157682}
media/gpu/v4l2: Extract GetNumPlanesOfV4L2PixFmt() out of V4L2Device
Since that static method does not use V4L2Device resources, it
doesn't need to be part of the class, which is already very large.
This was one of the follow-ups to https://crrev.com/c/4568232.
No new functionality, only moving code around.
Bug: b:279980150
Change-Id: Idb68f3fb7f7872545b2ac725fbcf013f6909f9cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611268
Reviewed-by: Fritz Koenig <[email protected]>
Commit-Queue: Miguel Casas-Sanchez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157681}
Remove RevampedContextMenuTest from emulator_11 filters
These tests don't exist anymore.
Change-Id: Iae30a4bafaa8a3cd4dc56d23c21c35cf47826cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616086
Auto-Submit: Sinan Sahin <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157680}
Remove duplicated call to RunJSTest() in test
The call was duplicated, apparently accidentally, in this change:
https://chromium-review.googlesource.com/c/chromium/src/+/4400271
"Remove ExecuteScriptAndExtractInt"
It looks like it was accidentally copy-and-pasted along with the call
to "content::EvalJs(tab, get_fault_count).ExtractInt()", which is now
"GetRecoveredTrapCount()".
Bug: 1157718
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng
Change-Id: I1a0d8ba618d0e5dcf72e6509edf2475dd0b6fab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610172
Reviewed-by: Chris Fredrickson <[email protected]>
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Mark Seaborn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157679}
Revert "Add initial version of PKCS12 certificates import to chaps."
This reverts commit 35a50dd76abe4a5e7b5978fceee4ebe95dd55f78.
Reason for revert: Unit tests are causing LSAN failures in https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/51759/overview
Original change's description:
> Add initial version of PKCS12 certificates import to chaps.
>
> Initial version has changes to chaps utils and unit test.
> "Import user certificate" button's action is still not changed
> and user's certificates will be still imported to NSS slots.
> More unit tests will be added later to cover all corner cases.
>
> Bug: b/264385929
> Change-Id: I6ee7637b575854b224f834ecf2d69c72f6ed94cd
> Testing: added basic unit test.
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4286781
> Reviewed-by: Pavol Marko <[email protected]>
> Commit-Queue: Oleksandr Sarapulov <[email protected]>
> Reviewed-by: Michael Ershov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157541}
Bug: b/264385929
Change-Id: I093951a34b8cf9bee14f5401f0660ac1e176ac50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615633
Auto-Submit: Marijn Kruisselbrink <[email protected]>
Owners-Override: Marijn Kruisselbrink <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157678}
[Fixit] Unbatch TrustedWebActivityTest
Bug: 1454648
Change-Id: Ie496636ed4648594d59bc2e0b972e8e68d12800f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612246
Reviewed-by: Ella Ge <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157677}
PreloadingDevTools: Use tab target in web tests
Before this CL, almost all web tests of prerendering used frame targets.
This is an obstruction to disable prerendering for clients other than
DevTools frontend.
This CL introduces a thin healpers to TestRunner and makes all those
tests use tab targets.
Bug: 1440085
Change-Id: I33b71e3826d5146ddb053d3ff824e53a7d559d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576764
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157676}
media: Add Media.InitializeRendererTimeout UMA
This UMA can be used to detect playback hang due to Renderer
initialization timeouts.
Manually tested by hacking the code to simulate a timeout and observed
the following in about://histograms:
```
- Histogram: Media.InitializeRendererTimeout recorded 2 samples, mean = 0.5 (flags = 0x41) [#]
0 -O (1 = 50.0%)
1 -O (1 = 50.0%) {50.0%}
2 ...
```
Bug: 1374532
Test: No functionality change
Change-Id: I104f8cf5ea786dbad7e5bce2b543b1f5bdf399f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613725
Reviewed-by: Evan Liu <[email protected]>
Commit-Queue: Xiaohan Wang <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157675}
Avoid raw_ref to dangling temporaries in PaymentResponseHelper
The PaymentResponseHelper takes a std::string argument by reference
and stores it in a member by reference as well. This is fine so long
as the string is guaranteed to outlive the PaymentResponseHelper, but
this is not the case in tests where literals like "en-US" are passed.
In such cases, a temporary string is created, a reference to it is
passed and stored, and then the temporary is destroyed when we hit the
semicolon following the constructor call. This is now made visible from
tests using the GN arg use_asan_unowned_ptr=true.
These are short strings, so pass by value and pay the cost for a copy
in one place rather than writing a big comment for the constructor
laying out the lifetime requirements. This may make it easier to ensure
we get this right going forward.
Bug: 1401495
Change-Id: Iebcfa13d2078ea6500314254e8c3895a563e8c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615347
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157674}
[iOS] Pass IdentityManager to manage sync mediator.
The mediator implements IdentityManagerObserverBridgeDelegate but did
not have an IdentityManagerObserverBridge.
This CL adds it to the mediator to correctly listen to changes in the
signed in identity.
And it fixed the _syncObserver initialization to use make_unique.
Bug: 1447017
Change-Id: Ia4a30c2ccc9b43e09addfd0e9d24e3a43945d77f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614503
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Jood Hajeer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157673}
[color] Update color_id and sys_color_mixer to latest UX spec P1
This CL aligns the baseline palette to match the latest UX spec for
desktop.
This involves deprecating some existing ids and updating the
baseline definition for others. Id declarations were also reordered
to match the ordering in the spec and the recipe definitions in the
sys color mixer.
Bug: 1408545
Change-Id: I2dacf0a83da7e46551036767d12e783003b8a8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612526
Auto-Submit: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157672}
Roll Perfetto from 179b5cecd2c8 to e314b79bfe9e (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/179b5cecd2c8..e314b79bfe9e
2023-06-14 [email protected] Merge "Implement new CustomSqlTableSliceTrack track."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I1984bb86a7888b8ad1f18eb58d58f941b53775dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615371
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157671}
WebUI: Remove startColorChangeListener helper, part 2.
This helper was kept around as a temporary step. It no longer adds much
value after introducing the ColorChangeUpdater class and is removed to
keep the API as lean as possible.
In this part removing calls from ash/webui/, replaced by
ColorChangeUpdater.forDocument().start()
Unfortunately lot of Ash WebUI code still using JS instead of TS, and
requires "@suppress {checkTypes}" annotations to consume
ColorChangeUpdater.
The startColorChangeListener helper will be fully removed in a
follow-up CL.
Bug: 1450109
Change-Id: Ib7bf2c67a0f895c64c65cc10bc3111876bc8695a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606723
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157670}
[user bypass] Add observer method on breakage confidence level update
Add a method to the observer interface to observe changes in the
breakage confidence level. Add enum to represent breakage confidence
level (low, medium, high).
Bug: 1446230, b:280782678
Change-Id: I58507c544f64e231365d81c21989739f9bcbfb0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608593
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157669}
Revert "Update V8 to version 11.6.145."
This reverts commit 764200c436cb05696239c52c96e9931f03071950.
Reason for revert: crbug.com/1454701
Original change's description:
> Update V8 to version 11.6.145.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/10f7ee23..316e1601
>
> Please follow these instructions for assigning/CC'ing issues:
> https://v8.dev/docs/triage-issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
>
> [email protected],[email protected],[email protected]
>
> Change-Id: Ic85fda1e31036d759aeb1d47855b48dee3f6545d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614706
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1157579}
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
Bug: 1454701
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: If181ed69c9550a7ef732cf1747e3047016bf1884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616406
Auto-Submit: Marijn Kruisselbrink <[email protected]>
Owners-Override: Marijn Kruisselbrink <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157668}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686743662-1cdc8d15119eba6f66cff7bf15709d8d1f07439a.profdata to chrome-win64-main-1686754776-64fec57127d4e24f1e31fe0b507d059b06d1ce09.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: If66027b8731c6bd534239142c02479f3bbe15cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615368
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157667}
[CSC] Crash fix for browser
Bug: 1453864
Change-Id: I89f057e49f1a8837c9f61f03862fa089e0f74874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609387
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157666}
[Clank sharing hub][QR code] Fixes top shadow on QR code dialog
If the QR code sharing or scanning dialog is scrollable, the header shadow will now appear when scrolled.
Before: https://screenshot.googleplex.com/4Qw9nkeVrmpvT8z
After: https://photos.app.goo.gl/c4JAvuygWAEDTvJ89
Bug: 1143314
Change-Id: Id766e9ebe1345213f193f65b1e400532514657a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605837
Commit-Queue: Joel Tan-Aristy <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Shu Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157665}
Roll RTS model from HFsh1P6Q9AZxEBnZb... to 6NdT2C0XTtRJKYySV...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib444af901c3f48c7b21aa835729f9cde830e2f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615770
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157664}
Roll RTS model from 8lKx6IDFtNPp1wUoE... to BRg1F6qOO4fhwj34n...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ica9aa3c5c0c2c7ff4cd113afc7b7283b9087547b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615330
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157663}
[Android] Fix clicking outside dialog flakiness in permissions tests
Getting a View does not guarantee it is sized and positioned correctly
In this case, we're getting a View with position and size 0x0 and
trying to click it, but that causes a click to go outside the dialog
and deny the permission instead of grant it, causing flakiness.
Bug: 1444083,1441822,1435426,1444217,1444241,1444222
Change-Id: I006d477e8de7a9d8377ad5932d4521bb2e6e0179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605840
Commit-Queue: Henrique Nakashima <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157662}
Roll RTS model from 9rAXeZlEUT08AdM7P... to egCFe24NDoUekIFph...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I128d3c8a5c148fd5d6c22fe789b6964c8d8bef21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615771
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157661}
Roll devtools-internal from 7a7573005bba to 78fc3badfe46 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/7a7573005bba..78fc3badfe46
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce4ba169ed6f00e60a797a829d15b5cc8675e392..4d2c9fc82e14d16e286d2633d3a753dd68d7483a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I3614de3ae87adb8eaab485d01a23bc90cda723a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615288
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157660}
[OOBE][CHOOBE] Introduce `skip_choobe_for_tests` to `WizardContext`
In optional screens tests, when logging in as a new user, there's
a possibility (based on some build arguments) of hitting CHOOBE screen
as the first non-skipped screen in the onboarding flow. In this case,
ChoobeFlowController will be created and will exit any optional screen
we try to advance to unless it was selected from CHOOBE screen.
Introducing the flag `skip_choobe_for_tests` will allow tests to
advance directly to any optional screen.
Bug: b:287023038
Change-Id: Ieb2a779db46949c1ede24fcf1ef1664af82a0dff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604935
Reviewed-by: Brahim Chikhaoui <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157659}
WebUI: Remove startColorChangeListener helper, part 1.
This helper was kept around as a temporary step. It no longer adds much
value after introducing the ColorChangeUpdater class and is removed to
keep the API as lean as possible.
In this part removing calls from chrome/browser/resources/, replaced by
ColorChangeUpdater.forDocument().start()
Unfortunately some Ash WebUI code still using JS instead of TS, and
requires "@suppress {checkTypes}" annotations to consume
ColorChangeUpdater.
Bug: 1450109
Change-Id: Icc4001af660a6cf861a19accbb4f315c7d8686a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611588
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157658}
Add cbor parser to data decoder with unit tests.
BUG: 1442274
Change-Id: I19c7cf15ebe4e320c37015521ddd1a9a7dffb802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602168
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157657}
Add server_hint and forced_field_type to DetermineExpirationDateFormat
CreditCardField::DetermineExpirationDateFormat gets two new parameters
"server_hint" and "forced_field_type".
It now tries to assign expiration dates in the following order of
precedence:
1. If forced_field_type is set, it tries to use this (this would be
set via server overrides and during filling time, when the field
type should not be changed anymore).
2. Next it tries to detect a format pattern on the website (e.g.
MM/YY, MM / YY, MM/YYYY, ...)
3. If it does not detect a format pattern, it tries to follow the
server hints.
4. If there are no server hints, it tries to guess a format based
on the max-length.
This change is motivated by a couple of reasons:
1. The old rationalization logic only considered the format patterns
and max-length attribute but no server hints. While the format
patterns are a strong indicator, the max-length attribute is not.
This means that valuable information was lost and not considered
for field classification.
2. At filling time, we want to give strong preference to the field
type determined so far and only diverge if we cannot fill the data
due to exceeding the max-length of the <input> field.
With this new logic, the GetExpirationDateForInput function can be
simplified because because it's logic is now covered by
DetermineExpirationDateFormat.
Bug: 1441057
Change-Id: Ic769d89f9e6eedcd366c7eaf79c6f2b0722ab265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604752
Commit-Queue: Christoph Schwering <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157656}
Roll Catapult from ca32af6260e4 to c684fe031218 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/ca32af6260e4..c684fe031218
2023-06-14 [email protected] [sandwich] use compute_engine.Credentials() to get grpc request creds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1454202
Tbr: [email protected]
Change-Id: I2d95666a90225bac18049546f0e4631943bd7dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614240
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157655}
Fix User-Agent Client hints UI flag on Android WebView
UserAgentClientHint is a base feature instead of command line override.
Change-Id: I24294158ffcf2f571f95cf9e4c7cc457ce48f2af
Bug: 1453402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616323
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Victor Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157654}
[WhatsNew] Clean up previous user default and add the new one.
This will allow the entry points that were previously triggered to trigger What's New again.
Change-Id: Ic8a2d009f68e716593613f26824d2307c93a2bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608930
Reviewed-by: Robbie Gibson <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Commit-Queue: Cheick Cisse <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157653}
CrOS Settings: Use Section Mojo enum for section property
Instead of using plain strings, derive top-level page/section values
from the Section Mojo enum defined in routes.mojom. This is done in
preparation for the upcoming category updates in the Settings Revamp.
Bug: b/286429941
Test: browser_tests --gtest_filter="OSSettingsMainPageContainer*"
Test: browser_tests --gtest_filter="OSSettingsOsPageAvailbility*"
Test: browser_tests --gtest_filter="OSSettingsOsSettingsMenu*"
Test: browser_tests --gtest_filter="OSSettingsOsSettingsUi*"
Change-Id: I52f1a1c2dcef36e4ab00ae13584686743d875c90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606536
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Wes Okuhara <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157652}
Fix GPU crash when tracing delegated ink trails
The crash was caused by referencing uninitialized member variable
metadata_. Use function argument metadata instead that always should
be initialized.
Bug: 1453436
Change-Id: I559b8c7c46a66e57e416dbeddf7d7ac2a504eda8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602621
Reviewed-by: Rafael Cintron <[email protected]>
Commit-Queue: Olga Gerchikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157651}
Roll Skia from 85f295e3a9c9 to b06e934cb637 (2 revisions)
https://skia.googlesource.com/skia.git/+log/85f295e3a9c9..b06e934cb637
2023-06-14 [email protected] Support kBGR_101010x_XR_SkColorType gather
2023-06-14 [email protected] [skif] Delete SkImageFilters::AlphaThreshold
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I43388f7b4f435781e9fec716c0dc9d957537ab64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615447
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157650}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686751181-b090ec8fcf0029d366528dd7a1aca48ad0cc3ce7.profdata to chrome-mac-arm-main-1686758346-f228fc14950ae53b74df10aa18d8075891994471.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Icd22e25fd23fc4264e3dd359c70863df921ddf33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615450
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157649}
Simplify cc RasterCapabities update
The decision to use GPU rasterization is made solely based on the
context capabilities which are fixed after LayerTreeFrameSink is
initialized. LayerTreeHostImpl no longer needs to update GPU raster
after it's set in LayerTreeHostImpl::InitializeFrameSink() so remove the
code related to that.
Bug: 1442970
Change-Id: I98d2b7e0ad18eab8283da63c36386d002b3857b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609972
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157648}
[fuzzy diff analyzer] 9/N: Fix on the analyzer script.
Rename the image num to image diff num.
We use the all image diff data to analyze the result.
Bug: 1396136
Change-Id: I94e687d565bfe5760721778925f9fc9e641decbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611228
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jie Sheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157647}
[Jelly] Add jelly colors to cellular setup dialog
Screenshots:
darkmode
Jelly disabled: https://screenshot.googleplex.com/7rrLt4GrmDou5eF.png
Jelly enabled: https://screenshot.googleplex.com/9t7XpQtRzr8tWAa.png
lightmode
Jelly disabled: https://screenshot.googleplex.com/5AKLX5kvBkcZmaR.png
Jelly enabled: https://screenshot.googleplex.com/AaeDXpormqSt4HY.png
Fixed: b/285026713
Change-Id: I23ebb389bb644c9836026dbd2ec1d7b8750a244c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611885
Reviewed-by: Wes Okuhara <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Theo Johnson-kanu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157646}
Roll earl_grey2 from 3b368a241858 to 90fa652f6ba7 (1 revision)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/3b368a241858..90fa652f6ba7
2023-06-14 [email protected] replace text textfield check
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I59d6b850dd7463fa1e5db1ff2367478aa2abf90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615287
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157645}
Remove double-declaration of NSCursor in gfx::NativeCursor
Bug: 1433041
Change-Id: I15914bd5c2b2832a1bd0579b34511b89df9581bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604401
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157644}
Add a missing call to ComputeEntirelyCoveredByBucketing().
RuleSets that were inserted into non-keyed buckets did not get a
proper call to ComputeEntirelyCoveredByBucketing(). This also meant
that they would never be marked as easy, which meant that selectors
like “a:-webkit-any-link” would not be processed as easy.
Style recalc is only 0.4% faster, which shows that this was not a
big issue, but it's good for completeness.
Change-Id: I83d157448533cb86429aaa70a22c99b824b7cfb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604628
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Auto-Submit: Steinar H Gunderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157643}
[Cronet] Make JSON assertion message clearer
Also switch to assertTrue. Was missed during migration.
Bug: b/280423217
Change-Id: Ied2271aeec9e07d288f7aeb54535977a0056d0b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610224
Reviewed-by: Stefano Duo <[email protected]>
Commit-Queue: Chidera Olibie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157642}
Add a field trial entry for Tail Suggest
Bug: none
Change-Id: I1b01be2db66a60c6893309193f7b1db423db78f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614924
Auto-Submit: Stepan Khapugin <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157641}
k-anonymity client checks CanRunChromePrivacySandboxTrials capability
Bug: 1454043
Change-Id: I5d6aa8b63ee7df5cf5329cd344a4c8ef029d026d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610832
Auto-Submit: Russ Hamilton <[email protected]>
Reviewed-by: Qingxin Wu <[email protected]>
Commit-Queue: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157640}
Revert "Handle session state changes for anchored nudges"
This reverts commit dc7339d548121d5729ebef97963e9c5c1b816a4c.
Reason for revert: Compile errors on https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/54405
Original change's description:
> Handle session state changes for anchored nudges
>
> Close all shown nudges whenever the session state changes.
>
> Bug: b:281730880
> Change-Id: I118a4ad19ca6b729ffc46dd15bf5b4e849baad83
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575097
> Reviewed-by: Andre Le <[email protected]>
> Commit-Queue: Kevin Radtke <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157630}
Bug: b:281730880
Change-Id: I0194e5b5f6d454e9553a64571a1b19bcbd349539
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616403
Owners-Override: Marijn Kruisselbrink <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157639}
coverage: Add a try presubmit builder for chromeos js coverage.
We have a cq builder for chromeos js coverage. Add a try builder as well
so that we can get the metrics at CL-level as well.
Bug: b:285632817
Change-Id: I11b553ec97b9f53125e575796cad67e4085e95ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602379
Reviewed-by: Prakhar Asthana <[email protected]>
Reviewed-by: Erik Staab <[email protected]>
Commit-Queue: Srinivas Hegde <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157638}
Remove references to Gnome Keyring in //docs
R=thestig
Change-Id: I4bda56ba4328a590e06e43fadbc3c461eec1407f
Bug: 355223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607551
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157637}
[Read Anything] Add UKM for select-to-distill
Record the total number of times the user "selects-to-distill". This
number will only be recorded after the user sees the empty state page
in reading mode, which is shown when (automatic) distillation fails.
This will help us see how often select-to-distill is being used.
UKM Review Doc:
https://docs.google.com/document/d/1K0IfhTW7qzcqp4HCF3lny3ETT2gY7CPKeiYPept39So/edit#heading=h.bahq24lmowo2
Related select-to-distill CL for UMA:
crrev.com/c/4558404
Bug: 1266555
Change-Id: I272010bdac0eb334dce8ab882cf937e95a2d70b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598037
Commit-Queue: Jocelyn Tran <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157636}
Revert "Move test files to Connectors test folder"
This reverts commit d6f0aaec102ba6596a440a7c55185e86f378bc19.
Reason for revert: compile errors on https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-dbg/23149/blamelist
Original change's description:
> Move test files to Connectors test folder
>
> The utils/classes in these files are mostly used by enterprise
> code, so moving them to chrome/browser/enterprise/connectors/test/
> makes them closer to where they are used, and a new target to build
> them will make future dependencies easier to manage.
>
> Bug: b/284950910
> Change-Id: I5fea8f405b795d24e8998bf9b7d3ba4180ee8db1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575362
> Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
> Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Reviewed-by: Min Qin <[email protected]>
> Reviewed-by: Sébastien Lalancette <[email protected]>
> Reviewed-by: Daniel Rubery <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Reviewed-by: Alan Screen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157562}
Bug: b/284950910
Change-Id: I3f77b8491f8f37df2f0a36977f9dd6d4ecd93610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616384
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Auto-Submit: Marijn Kruisselbrink <[email protected]>
Owners-Override: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157635}
Applied Jelly style to status area trays
This CL updated the color of label or image of the following trays:
· kOverview
· kImeMenu
· kProjectorAnnotation
· kDictationStatusArea
· kSelectToSpeakStatusArea
· kEche
· kMediaPlayer
· kPalette
· kPhoneHub
· kVirtualKeyboardStatusArea
· kWmMode
When the tray is active, the color is kCrosSysSystemOnPrimaryContainer,
and when it's inactive, the color is kCrosSysOnSurface.
kHoldingSpace will be handled in a separate bug: b/287098833.
Screenshots:
https://screenshot.googleplex.com/576zkRfgeRqR9V2
Toggle active/inactive state:
https://screenshot.googleplex.com/8iRgHiriQGz3JUf
https://screenshot.googleplex.com/534TthUHwoxeCfG
Bug: b:285040301
Change-Id: Ia81034aea605bbe2d7c259256e60bc314587add5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599848
Commit-Queue: Sylvie Liu <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157634}
[QuickStart] Default to using QR code authentication
Use QR code authentication to prepare for an upcoming bug bash. This
will be made obsolete soon once crrev.com/c/4455495 lands.
Bug: None
Test: N/A
Change-Id: I258741ce1862b3a21b787bd62d3dc892c4bfa125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596656
Auto-Submit: Curt Clemens <[email protected]>
Reviewed-by: Joe Antonetti <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Commit-Queue: Curt Clemens <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157633}
MD Managed guest session color updates.
- Modernize ArrowButtonView, now it's using dynamic colors.
- LoginExpandedPublicView added border and shadow for jelly.
- Introduce EnterpriseBadgeLayout to the UserImage can use
dynamic colors
- Add override_color_id to StyledLabel
Bug: b:260684596
Change-Id: I253c2cf6e19b3adb0456a06969c865172e8dfb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603934
Reviewed-by: Denis Kuznetsov <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Istvan Nagy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157632}
Roll Depot Tools from 2b19afb82030 to f407ae35d322 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b19afb82030..f407ae35d322
2023-06-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I85105a3a60c9e668f6a5282136a90a5894105453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615328
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157631}
Handle session state changes for anchored nudges
Close all shown nudges whenever the session state changes.
Bug: b:281730880
Change-Id: I118a4ad19ca6b729ffc46dd15bf5b4e849baad83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575097
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Kevin Radtke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157630}
Roll src/third_party/libaom/source/libaom/ b6ead6c27..233000f66 (57 commits)
https://aomedia.googlesource.com/aom.git/+log/b6ead6c27634..233000f66e9f
$ git log b6ead6c27..233000f66 --date=short --no-merges --format='%ad %ae %s'
2023-06-12 marpan rtc: Fix to rtc reference structure for dropped frames
2023-06-02 mudassir.galaganath Fix sync_enc_workers to read error status of master thread
2023-06-09 gerdazsejke.more Add Neon implementations of aom_highbd_sad_skip_<w>x<h>x4d
2023-06-06 gerdazsejke.more Add Neon implementation of high bitdepth SAD4D functions
2023-06-09 jonathan.wright Add Armv8.6 USDOT Neon implementation of aom_convolve8_vert
2023-06-09 jonathan.wright Add Armv8.6 USDOT Neon implementation of aom_convolve8_horiz
2023-06-09 jonathan.wright Add Armv8.4 SDOT Neon implementation of aom_convolve8_vert
2023-06-07 sanampudi.venkatarao Introduce an early breakout in skip_mode_rd()
2023-06-06 marpan rtc: Add control to set target bitrate
2023-06-08 jianj Convert svc_encoder_rtc from C to C++
(...)
2023-06-02 wtc av1_fwd_txfm2d_test.cc: Fix -Wshadow warnings
2023-06-01 salome.thirot Remove arch-specific implementation for comp_mask_upsampled_pred
2023-06-01 salome.thirot Repurpose AV1HighbdCompMaskUpVarianceTest test suite
2023-05-31 salome.thirot Repurpose AV1CompMaskUpVarianceTest test suite
2023-05-24 george.steed Add highbd_dc_top_predictor Neon implementation and tests
2023-05-24 george.steed Add highbd_dc_left_predictor Neon implementation and tests
2023-05-31 marpan rtc-svc: Adjust QP down on base TL0
2023-05-31 wtc Fix comment in derive_skip_apply_postproc_filters
2023-06-01 wtc Fix -Wshadow by relying on outer declarations
2023-06-01 wtc Fix -Wshadow warnings on loop index variables
Created with:
roll-dep src/third_party/libaom/source/libaom
[email protected]
Change-Id: Iea834e8f80bb07c7655ed3704f2db303e3cbb507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604046
Reviewed-by: James Zern <[email protected]>
Commit-Queue: Jerome Jiang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157629}
d3d: support R8 and R8G8
Bug: none
Change-Id: Ie6ce7a79aaefbab7dae20ee3737ab7f68097dfb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616006
Auto-Submit: Peng Huang <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Commit-Queue: Saifuddin Hitawala <[email protected]>
Reviewed-by: Saifuddin Hitawala <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157628}
Update ChromeOS rules for TypeScript.
ChromeOS is moving more toward TypeScript. Although there is no plan to
do a bulk change of existing code, we want any new things to be written
in TypeScript.
Change-Id: I568b97cad77f6515fef3bc102246126a55ffa442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615545
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Brett Wilson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157627}
[Shopping service] Only allow javascript on http[s] pages
This is a speculative fix for a crash that's happening on ChromeOS
settings pages. Rather than running the on-page extraction for all
navigations, we'll only run on http and https URLs.
Bug: 1449880
Change-Id: I62f7bd43f47c71dd7ba700fb291d97a84f903d8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611605
Reviewed-by: Mei Liang <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157626}
Convert /ui/display:test_support to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: I5287149f75fe98d8332f6de204627fad3baaab80
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608207
Auto-Submit: Avi Drissman <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157625}
cc::LayerTreeHost: Only re-raster HDR content when HDR headroom changes
When macOS transitions to enabling HDR, it will send very rapid (60fps)
updates to the HDR headroom. This results in the display::Screen's
gfx::DisplayColorSpaces's HDR headroom parameter changing.
The new gfx::DisplayColorSpaces is then passed to cc::LayerTreeHost,
which calls cc::Layer::SetNeedsDisplay on every layer, causing it to
re-raster. This is lots of unnecessary work, because most layers only
have SDR content and do not need to re-raster when the HDR headroom
changes. In addition to being extra work, this can result in an
explosion in memory usage, causing the renderer to hit its memory
limit and start flickering.
Whether or not a cc::Layer contains HDR content (and therefore may
need to re-raster due to an HDR headroom change) is knowable, via
its DiscardableImageMap's gfx::ContentColorUsage.
In cc::LayerTreeHost::SetDisplayColorSpaces, use the new function
gfx::DisplayColorSpaces::EqualExceptForHdrParameters to determine if
the only change to was to the HDR headroom. If so, instead of calling
cc::Layer::SetNeedsDisplay, call cc::Layer::OnHdrHeadroomChanged, which
is ignored by all layer types except for cc::PictureLayer, which will
call SetNeedsDisplay only if the cc::PictureLayer has HDR content.
Update tests to exercise this path.
Bug: 1450807
Change-Id: I547bcebfd01ae3d836eb6f1b31e54b44fb4a7d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603257
Reviewed-by: Vladimir Levin <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157624}
gfx::HDRMetadata: Include extended range in IPC
Rename gfx::ExtendedRangeBrightness to gfx::HdrMetadataExtendedRange
to be more consistent with the rest of the HDR metadata.
Include it in mojo.
Add tests for mojo round-tripping.
Bug: 1446302
Change-Id: I3cc5aacf077986a5102fb8e260d660a0a0277603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599490
Reviewed-by: danakj <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157623}
Add signal support in DTC e2e test
Bug: b:281821525
Change-Id: I126db96047cbbb769604d8c0c1ce821fcc6f4edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606725
Reviewed-by: Leon Masopust <[email protected]>
Commit-Queue: Arthur Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157622}
Remove the OR MacOS12 from the mac_default targets for mac builders and testers
Bug: 1448262,1448671
Change-Id: Idfd16e71f16c128c6894d7e24a49db219c9bbb43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610555
Commit-Queue: Lindsay Pasricha <[email protected]>
Reviewed-by: Erik Staab <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157621}
[media] Log to MediaLog from VideoToolboxVideoDecoder
Bug: 1331597
Change-Id: I9badf15bbc9891b1eed56a2a93feccd936c4beaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609094
Commit-Queue: Dan Sanders <[email protected]>
Reviewed-by: Ted (Chromium) Meyer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157620}
Remove XRSessionDeviceConfig.uses_input_eventing and related code
This commit removes the uses_input_eventing_ variable from the
XRSessionDeviceConfig interface and all the code that relied on it.
The XRSessionDeviceConfig.uses_input_eventing feature was originally
added to support WMR but is no longer needed since no runtimes support
it now.
Bug: 1429644
Change-Id: I6d691f67e20d5f430169556b215e038c6b1c3173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604546
Quick-Run: Alexander Cooper <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Commit-Queue: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157619}
[Fixit] Fix TabSwitcherMultiWindowTest
Fixes
1) Wait for cta2 to have tab state initialized
2) Finish cta2 to fix a lifecycle assert
Also batch test by leaving cta1 in a reasonable state.
If these start flaking please re-disable rather than reverting. This CL
puts the test in a much better state than before which was consistently
all failing.
Fixed: 1442319, 1363248, 1428352, 1393407
Change-Id: Ic23cdf40b80d25be69bc6369765c2811d40f5282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614357
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157618}
[Fixit] Remove unused DownloadTest tests from filters
testDangerousDownload and testDuplicateHttpPostDownload were
removed in crrev.com/c/3537051 so we no longer need filters
for them.
Bug: 1128665, 1273038, 1193814, 1193745
Change-Id: I27a3a8570a31ebb199f9f87d61e528cf6737d7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611171
Commit-Queue: David Maunder <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157617}
Re-enable CustomTabActivityTest#testActionButton
Bug: 1430243
Change-Id: I677dcd5fcf8052051835ee6bed3b1da515855657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611235
Reviewed-by: Kevin Grosu <[email protected]>
Commit-Queue: Zach Katz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157616}
Cache ViewportSize in StyleEngine.
This never changes during a style recalc, and recently got much more
expensive to compute due to cast hardening. We can cache it once
per style recalc and be done with it (the layout sizes cannot change
during one).
Style perfest (Zen 2, LTO but no PGO):
Initial style (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 6445 6070 +6.2% [ +5.3%, +7.0%]
Encyclopedia 55658 51903 +7.2% [ +6.3%, +8.1%]
Extension 89764 83818 +7.1% [ +6.4%, +7.9%]
News 28886 27524 +5.0% [ +4.2%, +5.8%]
Search 8145 7788 +4.6% [ +3.8%, +5.5%]
Social1 17327 16372 +5.8% [ +4.9%, +6.7%]
Social2 11410 10823 +5.4% [ +4.6%, +6.3%]
Sports 30362 29195 +4.0% [ +3.2%, +5.2%]
Video 23890 22926 +4.2% [ +3.5%, +5.0%]
Geometric mean +5.5% [ +5.1%, +5.9%]
Recalc style (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 7910 7203 +9.8% [ +9.0%, +10.6%]
Encyclopedia 43488 39617 +9.8% [ +8.7%, +10.7%]
Extension 86038 79327 +8.5% [ +7.7%, +9.2%]
News 22384 20939 +6.9% [ +6.0%, +7.7%]
Search 4339 3963 +9.5% [ +8.8%, +10.4%]
Social1 12917 11924 +8.3% [ +7.4%, +9.2%]
Social2 9409 8687 +8.3% [ +7.4%, +9.2%]
Sports 16631 15683 +6.0% [ +5.3%, +6.9%]
Video 16538 15453 +7.0% [ +6.3%, +7.8%]
Geometric mean +8.2% [ +7.7%, +8.8%]
MotionMark is more cautious, with only a single tiny improvement on M1
and somewhat modest improvements on x86.
Pinpoint mac-m1_mini_2020-perf, no PGO, 95% CI:
Canvas Arcs [ -0.1%, +0.2%]
Canvas Lines [ -0.2%, +0.1%]
Design [ -1.8%, +4.0%]
Images [ -2.5%, +1.7%]
Leaves [ +0.5%, +0.9%]
Multiply [ -1.8%, +0.8%]
Paths [ -0.2%, +0.3%]
Suits [ -0.1%, +0.5%]
motionmark_ramp_composite [ -0.3%, +0.6%]
Pinpoint win-10-perf, no PGO, 95% CI:
Canvas Arcs [ -0.5%, +0.8%]
Canvas Lines [ -0.6%, +0.1%]
Design [ +1.1%, +3.1%]
Images [ -0.5%, +0.4%]
Leaves [ +0.6%, +1.4%]
Multiply [ +1.0%, +1.9%]
Paths [ -0.4%, +0.4%]
Suits [ -1.0%, -0.0%]
motionmark_ramp_composite [ +0.3%, +0.7%]
Change-Id: Ia8d062edd5b68c20121b6ff1929ddc7bc7051598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604629
Commit-Queue: Steinar H Gunderson <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157615}
Use existing GetLatest*Commit helpers fetching commit hash from github
When looking for a ToT commit, we fetch the commit hash from github. We then try to checkout that commit from our GoB mirror, which may lag behind.
Instead use the existing helpers which already do the right thing.
Change-Id: Ibbd3f68ef31a4f630a3000155479600496e4e06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611886
Reviewed-by: Hans Wennborg <[email protected]>
Commit-Queue: Arthur Eubanks <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157614}
[fuchsia] Add missing includes
Starting with https://fxrev.dev/869997 sdk/lib/vfs/cpp will no longer be
a public dependency of sdk/lib/sys/cpp, so must be depended upon
explicitly.
Bug: fuchsia:103032
Change-Id: I0893b2fbad128cf544771bbe6b3f01d01247632d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615964
Auto-Submit: Tamir Duberstein <[email protected]>
Reviewed-by: Wez <[email protected]>
Commit-Queue: Tamir Duberstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157613}
Roll Website from 8baa1dd892d5 to 3a2072ce6c0d (1 revision)
https://chromium.googlesource.com/website.git/+log/8baa1dd892d5..3a2072ce6c0d
2023-06-14 [email protected] Update password autofill guide for developer since it's unformated markdown with incomplete example codes.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ia7d1d33d1624e57310b066fc3a62277a4d7dd6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615769
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157612}
Roll ANGLE from 341dabf8e58e to af1768a48756 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/341dabf8e58e..af1768a48756
2023-06-14 [email protected] Android: Add Galaxy A34, A54 and Oppo Find X6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I802c1160bd07e49715b09da870ad721352f3622a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615649
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157611}
[blinkpy] Track expectation line changes
This change returns an `ExpectationsChange` container for
`SystemConfigurationEditor` operations tracking net lines
added/removed. The importer will use the results for bug filing.
Other changes to align with existing importer behavior:
* Allow editing other expectation files.
* Allow customization of the macros map to change system tag
simplification conditions.
* `update_versions(...)` creates the marker if it doesn't exist.
* Handle tags case-insensitively everywhere.
Bug: 1149035
Change-Id: I27a3c1a4c172f8c94ff74cfc7776420149c6c145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595773
Commit-Queue: Jonathan Lee <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157610}
[ios] Add Square Container behind Set Up List Magic Stack Module Icon
This change adds a container behind the SetUpListItemView icon when it is in a per-item "hero" module in the Magic Stack.
Bug: 1432252
Change-Id: Ia381b42b90e5c377be6ab590fd557fee377c593a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608638
Reviewed-by: Scott Yoder <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157609}
Revert "[Fixit] TabGridAccessibilityHelperTest"
This reverts commit 4c9139859ea621efe9764d8d3ed86ea41b3e2016.
Reason for revert: failing tests on a couple bots, see crbug.com/1454747
Original change's description:
> [Fixit] TabGridAccessibilityHelperTest
>
> Fix failing tests which seem to stem from the following:
> 1) Start surface vs Start Surface Refactor have different onView
> parents. (Set one consistent flag set).
> 2) If scrolled out of view getting the RecyclerView ViewHolder is
> flaky.
> 3) Small phones don't get span count = 3. Skip those sections.
>
> Additionally:
> * Batch tests
> * Throw ViewMatchExceptions to aid in debugging in future
>
> Fixed: 1368279, 1332995, 1318394, 1371231, 1332934, 1318376, 1306823, 1146575
> Change-Id: Ica6d65fd4a53a7270aa5e066f0307ccb7772fe4d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604877
> Auto-Submit: Calder Kitagawa <[email protected]>
> Reviewed-by: Fred Mello <[email protected]>
> Commit-Queue: Fred Mello <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156890}
Change-Id: I7535c81be60389627d64dde372380a18c24d2da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615045
Commit-Queue: Theresa Sullivan <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157608}
[iOS] Updating the UI for the shortcuts widget's body.
- Added the widget compatibility to match
the dark/light mode.
- Centered the shortcuts icons.
- Added more corner radius for the shortcuts icons.
- Added space between the shortcuts placeholders in the shortcuts widget gallery view.
Bug: 1450219
Change-Id: I1d8ad416ad104fcb2042b1ccf48659873a8af4fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577221
Commit-Queue: Aliaa Alborhamy <[email protected]>
Reviewed-by: Quentin Pubert <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157607}
Roll vulkan-deps from 16ff5c9d2ecb to cebf5626ca50 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/16ff5c9d2ecb..cebf5626ca50
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/72ec0a39e1..5cde5d21a3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ib6781b38df5042587d76c5c5185799cf6343154a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615043
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157606}
Add browsertest for Topics + Enrollment integration.
This test verifies that attested sites can fetch topics as expected, and
that unattested sites will not receive topics. For now, it tests the direct JS invocation only. Request header generation tests will be added in a follow-up CL once the main mechanism of the test is agreed upon here.
Change-Id: I0f8767a021e38c2a476f76a7d43e168418f56ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610971
Reviewed-by: Garrett Tanzer <[email protected]>
Reviewed-by: Yao Xiao <[email protected]>
Commit-Queue: Andrew Verge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157605}
[PAA] Add basic API surface / error condition tests from shared storage
Bug: 1452248
Change-Id: Ie014ea71d7c0d31b3592ab15697bf27bd88ca41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609684
Reviewed-by: Alex Turner <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157604}
[ios] Implement omnibox resizing
Implement the UIView returned by the content layer as a
UIScrollView. This allows the omnibox to decide when to change
the insets on the view.
Move the UIView that represents the RenderWidgetHostView
around in the UIScrollView that WebContentsView presents.
Fix the view offset while a finger is on the glass for
touch events, this matches what Android does.
Disable resetting insets on scroll end, it was causing
the omnibox to reappear full height at the end of scroll.
Bug: 1411704
Change-Id: If16ffadaa095ac9b5078f3c5a160606c992ae844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608880
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157603}
[CR2023] Add Typography Tokens
Add CR2023 typography tokens to views::style::TextStyle. Example
tokens include Body1, Headline1 and Caption. Each token specifies a font
size and weight but not color.
Paragraph spacing is not yet implemented as it will require significant
change in RenderText on multiline text layout.
screenshot: https://screenshot.googleplex.com/46DwJJdwjd44JRK
Bug: 1399939
Change-Id: I17571fcec31cdfcc9615d6f4358412733c03d613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608221
Commit-Queue: Keren Zhu <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157602}
Roll Perfetto from 49f628ceb9c9 to 179b5cecd2c8 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/49f628ceb9c9..179b5cecd2c8
2023-06-14 [email protected] Merge "tp: DBv2 - Upload files for benchmarking"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I4ad983a39d094c4fcae02084a5981d9889bd2d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615327
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157601}
OOBE: Adjust `preview` title in optional screens
Bug: b:287231716
Change-Id: I45553645a77cf1900760ad123110a82d884fe470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615028
Reviewed-by: Brahim Chikhaoui <[email protected]>
Commit-Queue: Brahim Chikhaoui <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Auto-Submit: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157600}
Enable filling hidden selectmenus for the sake of simplicity
BUG=1420414
Change-Id: I1df8e3dc9b049af6fe162e3f831cea5b4dea0411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605780
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157599}
[autofill] Move autofill popup creation methods to an utils file.
This will be used in a follow up CL where we introduce a new design for the autocomplete option, where users will be able to delete it.
Bug: 1417187
Change-Id: I2fcde7c0ec50edab88bc617921faae0ca8085e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610120
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Bruno Braga <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157598}
[ios] Increase spacing between SetUpList items
This increases the spacing between Set Up List items from 15px to 18px.
Screenshot with changes:
https://screenshot.googleplex.com/3RkPTywUkfGBrLY.png
Fixed: 1453262
Change-Id: I11eaf12d89613715055d52f7f20fa79d52d7fe6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601649
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157597}
Attempt to fix crash in HashPrefixMatches with mmap prefix map
Looking at some of the crash reports, it seems these are all happening
very early in startup. My suspicioun is the file has been truncated
somehow, and checking the file size matches what we expect should fix
any issues.
Bug: 1409674
Change-Id: I5ed7777d2b8873d74e119b652682d807c29c4ee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611728
Reviewed-by: Daniel Rubery <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157596}
[Performance Controls] Add flag option to show recommended badge
Adds an option to turn on the feature param default_heuristic_mode to
chrome://flags. Currently, it doesn't set the default pref value, and
only controls whether the recommended flag is shown next to the option
in the UI. This will allow us to test the recommended badge without
having to use the command line.
Bug: 1424220
Change-Id: Ifab82b7474fb60241f7e666b854e1f80021bdd65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616043
Commit-Queue: Charles Meng <[email protected]>
Reviewed-by: Alison Gale <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157595}
Convert /chrome/browser/ui:test_support to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: I35a9d031b7e4df905847d71a9a96f93fc35d9aa3
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610088
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Code-Coverage: Findit <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157594}
CrOS Settings: Add c/b/r/ash/settings folder and OWNERS
In preparation for moving the CrOS Settings SWA frontend code, this
CL creates the destination directory and supplies OWNERS.
go/chromeos-settings-code-organization
Bug: b/283986054
Change-Id: Idc8cd406d53d9776b83404d8ca1c3d7b5ea856c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611471
Commit-Queue: Wes Okuhara <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157593}
[ios] Simplify code that handles height-above-feed changes
This changes the method that gets called when the Doodle finishes
loading asynchronously. Now instead of updating the height-above-
feed and scrolling to the top, it will update the height-above-
feed and keep the current scroll position, just like we do for
MVT and other content suggestion updates.
Change-Id: If185c556891bdfb9d5ca4bb5e47c72f553a333b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605126
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157592}
[QuickStart] Remove url encoding from the base64 shared secret
Android started parsing the secret in the QR code using standard base64
instead of the url-encoded version that replaces '+' and '/' with '-'
and '_', so we need to update the way we encode the secret to match.
Note that in order to ensure that '+' is parsed correctly, we need to
use percent encoding. This could give us trouble later if, for example,
a particular secret happens to have lots of '+' and '/', which would
expand the size of the secret and make the QR code larger. For this
reason, this is likely an interim solution until we can get Android to
use url-encoded base64.
Bug: None
Test: Manual testing of QR code flow, existing unit tests pass.
Change-Id: I07671a9e7a3bcd89157687c7b28f36fea21f1986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595746
Reviewed-by: Renato Silva <[email protected]>
Commit-Queue: Renato Silva <[email protected]>
Auto-Submit: Curt Clemens <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157591}
Roll WebRTC from b7af6b963bed to 8f1903e3cff7 (1 revision)
https://webrtc.googlesource.com/src.git/+log/b7af6b963bed..8f1903e3cff7
2023-06-14 [email protected] In VideoCaptureImpl lock api_lock_ when accessing apply_rotation_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I42a47c62f75cbe764dcd7e8c0f5039f33f3f4721
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615943
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157590}
Ensure AwActivityTestRule runs teardown
Failing tests will cause an exception, meaning the tearDown method call
was being skipped.
This led to warnings about leaked awContents.
Change-Id: I06c458ae7c6a319a3a5d5d5bebfd64578c7f559c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614587
Auto-Submit: Peter Pakkenberg <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157589}
Roll Skia from 13266cc111b9 to 85f295e3a9c9 (1 revision)
https://skia.googlesource.com/skia.git/+log/13266cc111b9..85f295e3a9c9
2023-06-14 [email protected] Reland "Add unit test for nested runtime blending"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I37bc21411549e2a94070385cda2d93194101ce35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615767
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157588}
sharing: remove some unido histograms (2/n)
This change removes:
* Sharing.DeviceRegistrationResult
* Sharing.DeviceUnregistrationResult
* Sharing.MessageHandlerTime.*
Which are all expired as of M97.
Bug: 1447189
Change-Id: I6e2832ab33d7b85bf03393f3c75342e07bf06acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611281
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157587}
[iOS] Make WebView inspectable by default on debug builds
Using the same condition as the one to show the "View Source" option in
settings.
Bug: None
Change-Id: I0d4e3a0e4e53cbaf574413f07a41a0ca20cfe053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615884
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157586}
[ios] Set Up List menu item "Turn Off" should be red
The "Turn Off" item from the Set Up List menu should be marked as
destructive which will make the item red.
Bug: 1454209
Change-Id: I580f8bd7092e936abae5a1f7dea9de823b64ca79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609063
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157585}
Rename --block-third-party-cookies to --test-third-party-cookie-phaseout
This switch forces third-party cookie blocking on by enabling the
ForceThirdPartyCookieBlocking feature.
When this switch is used, this CL also enables 3P storage partitioning
and allow it to be used so that developers can test for 3PC phaseout.
This switch is not meant to be enabled in production, and this
CL does not impact default/Incognito behavior.
Bug: 1441039
Change-Id: Ifa489e130fb630e6666ec4ac6ef3b80e6e2ab1cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574540
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157584}
Use `GetCharacter` instead of `GetText`
Bug: none
Change-Id: I368e2a9b5d24f82e89f257c3146f3525a3e00a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614485
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Randolf Jung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157583}
[ios] Explicitly list frameworks as target dependencies
Instead of adding frameworks in default_libs or in ios_app_bundle
template, let each target explicitly list their frameworks. This
will allow to link application that e.g. do not link with UIKit.
Fix //base:base_arc target to list explicit dependencies on the
framework that are used (that were previously coming from the
default_libs config).
Add missing frameworks and imports that were previously implicitly
added to the targets.
Bug: none
Change-Id: I675cd7c499e3c79021a8da3cdb0aa20f2b7d0ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609126
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157582}
Add skym@ back to the OWNERS for survey
Change-Id: Ie18bad603fcd6d574c30f20534a0b3c74e9932a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611487
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157581}
Remove page actions from accessibility toString
This CL fixes a source of flakiness in some accessibility tests. The
actions that are included on any given node may be dependent on screen
size, e.g. scrolls. We exclude those actions from test expectations to
prevent screen size dependent failures. We were previously excluding
all scroll actions, and with this CL we also exclude page actions.
AX-Relnotes: N/A
Bug: 1454509
Change-Id: I166920f75fcd62a4357ed19fbf102f735416fc6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609213
Commit-Queue: Mark Schillaci <[email protected]>
Reviewed-by: Amanda Lin Dietz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157580}
Update V8 to version 11.6.145.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/10f7ee23..316e1601
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ic85fda1e31036d759aeb1d47855b48dee3f6545d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614706
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157579}
image_processor_perf_test: Implement Capped ImageProcessor Tests
Adds a Capped version of the GLImageProcessor and LibYUV Performance test.
The test feeds random frames through the Processors at a capped
framerate of 60fps and checks that the processor can process within the
time restriction. Additionally records test performance metrics for
analyzing capped performance test metrics.
BUG: b:278107121
Test: Tested on Asurada board and was able to see processor running at a capped framerate of 60fps.
Change-Id: I84f364d36a60c6e25d8e3ced6e2734e502182c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597916
Reviewed-by: Fritz Koenig <[email protected]>
Reviewed-by: Justin Green <[email protected]>
Commit-Queue: Bijan Choobineh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157578}
[UPMLocalPwd] Pass the selected option to the Next button callback
And dismiss the sheet when "Next" is clicked.
Bug: 1454770
Change-Id: Iff132f982d1a0caa255bcfe23f136797093c9679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615003
Code-Coverage: Findit <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Ivana Žužić <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157577}
[PDP] Fix a typo in local PDP detection
Bug: b:278291710
Change-Id: I45fba7491b64285998194ccdc571091aa4f63b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606729
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Auto-Submit: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157576}
[iOS] Slide-from-leading-edge animation for autofill branding
This is a follow up of crrev/c/4605159; the "slide from leading edge"
animation for iPhone in variations 3 and 4 is now coded and tested.
Note that the test case for variation 3 is removed because
1) On iPhone, the branding only stays idle for 400ms and could not be
caught by EG testing. This will have to be manually tested.
2) On iPad the behavior is the same as variation 4 and is fully covered
by test case.
Fixed: 1447909
Change-Id: I7fc6d8b8daa5e4a14d7e14ba716b839faaccb9ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605165
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ginny Huang <[email protected]>
Reviewed-by: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157575}
[iOS] SigninScreenCoordinator dealloc checks stop was called
Bug: None
Change-Id: I4fca449a1c79dddc9bff52dba026e4fac3b00615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609160
Commit-Queue: Arthur Milchior <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157574}
Use LacrosOnly for AppContextMenu test.
Currently the test uses LacrosPrimary, which is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: I525aa7985f43b05f97fb117df4fd91516d59b5f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615583
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157573}
Remove LacrosPrimaryPinnedApp test case.
LacrosPrimary is going to be removed, so there is no longer needed
to test it.
BUG=1448575
TEST=Tryjob
Change-Id: I3654898f3c426062a3dff36cc7b795cc05758399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615464
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157572}
[DTC-BYOD] Enable profile inline flow feature by default
Bug: b/282143849
Change-Id: I9ee8aa658f9bc371107747f9fcb30665309f3b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616003
Code-Coverage: Findit <[email protected]>
Reviewed-by: Sébastien Lalancette <[email protected]>
Commit-Queue: Hamda Mare <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157571}
Graphite: Add YUV promise image support in SkiaOutputSurfaceImpl
Add the necessary YUV promise image support in SkiaOutputSurfaceImpl
for Graphite. Also, update YUVABackendTextures callsites as it is
now with SkSpan.
Bug: 1434131, 1447546
Change-Id: I36b2a4775ec233778e78267bf4db55b942ea01bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598990
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Saifuddin Hitawala <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157570}
Cleanup FakeVideoCapturer of unneeded includes
Bug: 1438554
Change-Id: I773c4928bd6c3617e73224084395f42d6327a468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614532
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157569}
dlp: Get ScopedFileAccess while unzipping
Currently it's not possible to unzip restricted archives since we are
not acquiring a scoped file access object.
This CL makes it possible to unzip restricted archives by acquiring
a scoped file access object before the archive is opened.
A subsequent CL will take care of copying the source of the archive to
unzipped files.
High level overview: http://docs/document/d/1B_wJgck9woBCHW1e3I4z9CdwtYWcu1UtaL0d_fcFI18?resourcekey=0-qn4RV7da3HaU7uE827VlQg
Bug: b/285532035
Change-Id: Ib0da20e4f9e06b90265296469142433b4cbd6546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584029
Reviewed-by: Aya Elsayed <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: Daniel Brinkers <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Luca Accorsi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157568}
[v8][wasm] Reduce tiering budget to speed up test
The wasm/caching/code-cache.html test is an E2E test for WebAssembly
code caching. As WebAssembly caches only optimized code, the test first
executes code so that it gets optimized, and then checks that the
optimized code got cached.
Depending on the tiering budget defined in V8 it can take some time to
trigger tier-up. This CL reduces the tiering budget and thereby speeds
up the test, hopefully enough to avoid flaky timeouts.
Bug: chromium:1453726
Change-Id: Iac66cc3198422b59c2f248a84d46959785c4260d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614747
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Andreas Haas <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157567}
[iOS] Autofill branding: implement behaviors for variations
This CL implements variations defined in ios/c/b/flags/about_flags.mm
plus the default enabled (two impressions) and the disabled arms.
Variation 1: Show two impressions on both iPhone and iPad
Variation 2: Show the branding until the user has interacted with a
form input accessory on both iPhone and iPad
Variation 3: Always show the branding on iPad; on iPhone, always show
the branding and make it slide away from the leading edge
Variation 4: Always show the branding on iPad; on iPhone, show the
branding until the user has interacted with a form input accessory, and
when the user does so, the branding should slide away from the leading
edge
Test case for each variation is also implemented.
As of now, the code and test for the "slide away from leading edge"
animation has not been implemented yet. This will be done in a follow up
CL.
Bug: 1447909
Change-Id: I3bf626c3cfcc94b716af559391856188e5e8a8cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605159
Commit-Queue: Ginny Huang <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157566}
Remove depth/stecil from default framebuffer in passthrough decoder
Code is not reachable.
Bug: 1445523
Change-Id: Id637d7f6a6e29607bdf67783f0347600378afacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611104
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157565}
Syncable preferences documentation: Mention priority prefs
Bug: 1448000
Change-Id: I21986bebd0c49050dc2d79c6a835dc4228a016cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614510
Commit-Queue: Rainhard Findling <[email protected]>
Auto-Submit: Marc Treib <[email protected]>
Reviewed-by: Rainhard Findling <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157564}
Reland "[WebAuthn] Use consistent namespaces in components/webauthn"
This is a reland of commit f89b7794da86852bd0a68e13eb1828f078857f7f
There was a conflict with another CL that recently landed, which
has now been resolved.
Original change's description:
> [WebAuthn] Use consistent namespaces in components/webauthn
>
> The WebAuthn component code currently uses a mix of namespaces, which
> are spread between `webauthn`, `components`, and no namespace at all.
>
> The first of those is the correct one for most cases. This change
> normalizes that.
>
> Change-Id: I364ddf066144e3910a294c949f77018cbd0a89cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604895
> Commit-Queue: Ken Buchanan <[email protected]>
> Reviewed-by: Rouslan Solomakhin <[email protected]>
> Reviewed-by: Martin Kreichgauer <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Reviewed-by: Vasilii Sukhanov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156876}
Change-Id: I28de884338b8788cc9ba76dd47faf56d0afe3608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606125
Reviewed-by: Martin Kreichgauer <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Auto-Submit: Ken Buchanan <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157563}
Move test files to Connectors test folder
The utils/classes in these files are mostly used by enterprise
code, so moving them to chrome/browser/enterprise/connectors/test/
makes them closer to where they are used, and a new target to build
them will make future dependencies easier to manage.
Bug: b/284950910
Change-Id: I5fea8f405b795d24e8998bf9b7d3ba4180ee8db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575362
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Sébastien Lalancette <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157562}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686733162-c653addd0619e2d9fa1f4b3ec3e0c257d4855166.profdata to chrome-win32-main-1686743662-490e2ee9552b695d673012a14d92724384535b9b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Id2948500bea1273d90718eb54139a35e2ee14158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615365
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157561}
[iOS] Remove -[SceneController dismissModalDialogs]
`-[SceneController dismissModalDialogsWithCompletion:]` should be
prefered. Callers of `dismissModalDialogs` need to understand clearly
that this method is asynchronous.
Change-Id: I7adf4ede3633318b2830a701c46c3e091dc53ec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615025
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Jérôme Lebel <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157560}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686743662-fba25cab877502207b64c66cd0d48c46b0646b52.profdata to chrome-mac-arm-main-1686751181-b090ec8fcf0029d366528dd7a1aca48ad0cc3ce7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I571e7ff8944731b63792c38ba1dc7512b161f2e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615647
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157559}
[UPMLocalPwd] Add height dimensions for both screens
Both screens on the sheet have a fix height so it's easier to use them
as constants then to remeasure the sheet.
The sheet is made scrollable.
Bug: 1451846
Change-Id: I8bab314e9bdabe0c5c9c1b62fdef8e828ef5d79e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595068
Reviewed-by: Ioana Pandele <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Ivana Žužić <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157558}
[WebAPKs] Refactor the PWA install bottom sheet
Refactor the PWA install bottom sheet to make it more dynamic and
scalable with size changes.
Merged the divider in the content as it wasn't aware of the toolbar and
that caused overlapping issue with font scaling at 200%.
Content layout should be refactored to use ConstraintLayout after we
remove the WebLayer from WebView.
Bug: 1422063
Change-Id: If2b57f1bd3fef3239ac78715da5aaaadb582b405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580219
Reviewed-by: Glenn Hartmann <[email protected]>
Commit-Queue: Sayed Elabady <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157557}
[iOS] ConsistencyDefaultAccountCoordinator dealloc checks stop was called
Bug: None
Change-Id: I03c093b06be287c1162be061a5bf44c840687df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604239
Reviewed-by: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157556}
Roll devtools-internal from 99df666936d6 to 7a7573005bba (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/99df666936d6..7a7573005bba
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/123c3ef5b631495a8501f79900689bc972acc2b9..ce4ba169ed6f00e60a797a829d15b5cc8675e392
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I749d5de52abd948df457b1442a408aced8205992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614608
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157555}
Trim Skia codecs when use_blink == false
Following
https://chromium-review.googlesource.com/c/chromium/src/+/4606124,
we're now running into missing codec symbols when building SkCodec.cpp
for iOS emulator:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8778389908743485649/+/u/compile__with_patch_/stdout
Specific codecs are only included in the build when use_blink == true,
but SkCodec.cpp is always present -- so it needs to build in the absence
of all codec impls.
1) guard codec defines in the same manner as their impl (use_blink)
2) for the !use_blink case, define SK_DISABLE_LEGACY_INIT_DECODERS to
prevent SkCodec.cpp from referencing any codec impls.
Change-Id: Idf0e5374af7873dc9f17d05735d20ec3d801968b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611156
Commit-Queue: Florin Malita <[email protected]>
Reviewed-by: Kevin Lubick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157554}
[DTC] Lazy-load the UserCloudPolicyStore When Collecting Signals
When not lazy-loaded, then the userEnrollmentDomain signal will be empty
for newly created managed profiles. Wrapping the Profile pointer in
another class to increase testability.
Also extracted a MockCloudPolicyManager definition to reuse.
Fixed: b:286082113
Change-Id: I447156cace2eb75c2ed02dd3284ff631fd9d9da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604605
Reviewed-by: Hamda Mare <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Commit-Queue: Sébastien Lalancette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157553}
[color] Guard BrowserColorScheme pref behind ChromeRefresh2023
This guards the return value of the BrowserColorScheme pref
returned by ThemeService behind the ChromeRefresh2023 flag.
UI should only track this preference when ChromeRefresh2023 is
enabled and the Panorama side panel is present (which has the
affordance to toggle this on and off).
Bug: 1454303
Change-Id: I47484e056ae82d69f4329c94f75cb04ce34b5fb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611925
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157552}
diagnostics: avoid race condition in AsyncLog
- Change AppendImpl and CreateFile to free functions in anonymous namespace, which prevent accessing member variables from the thread pool.
- Test that log append task does not crash after log destroyed.
Bug: 1451164, b/286210532
Test: Ran ash_unittests.
Change-Id: I2bc798a9a8b7de25dc6c2c4f7dd4b609be6b75ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583920
Commit-Queue: Gavin Williams <[email protected]>
Reviewed-by: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157551}
[iOS] UnifiedConsentCoordinator dealloc checks stop was called
Bug: None
Change-Id: I247f4970fea631fbe5473884e9de240aea5189a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609161
Commit-Queue: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157550}
[ios] Fix flaky Set Up List EG test
This fixes a flaky Set Up List test by scrolling to search for the
expand button.
Fixed: 1453585
Change-Id: I2d82096c1d0b6e1d6b9fdad7d9843204109e672c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604391
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157549}
Revert "Prerender: Add fieldtrial testing config for SpeculationRulesPrerenerMemoryLimit"
This reverts commit 1532d1db26fa9d21eb68d2b4943e377a7bbf03a6.
Reason for revert: speculating that this change it the culprit for the tree closure https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20arm64%20Builder%20All%20Targets%20(dbg)/14572/overview
Original change's description:
> Prerender: Add fieldtrial testing config for SpeculationRulesPrerenerMemoryLimit
>
> This CL adds the fieldtrial testing config for
> SpeculationRulesPrerenderMemoryLimit with a new acceptable percentage
> (100%).
>
> Bug: 1382697
> Change-Id: I04bc1a774c3cf95392cd7f1bca5f55bdf383c520
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613326
> Commit-Queue: Hiroki Nakagawa <[email protected]>
> Reviewed-by: Huanpo Lin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157477}
Bug: 1382697
Change-Id: Ic5bbfe07bd308dab8a213f678cf1052f54c12f64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614446
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Hamda Mare <[email protected]>
Owners-Override: Hamda Mare <[email protected]>
Commit-Queue: Hamda Mare <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157548}
[ios] Fix disable SetUpList in multi-window
This fixes the issue where when the Set Up List is disabled, it doesn't
immediately hide it in all open windows. Instead of hiding the list when
the user touches "Turn Off", it will instead write to prefs to disable,
and then we will monitor changes to the pref to hide the list.
Fixed: 1451973
Change-Id: Ib35f45c26004171d4cadc862a2949d1f1046ebae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608926
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157547}
[Android][CredMan] Use finalized string for reentry button
The blue button now shows "Choose a sign-in" as requested in mocks.
Screenshot: go/strpic/bc91c20caa4e96e023a7fbce2ee258ff9dd4c5ea
This completes the work on the reentry button and the entire flow looks
now like this: go/scrcast/NTk3NjcyMzU0NDg2NjgxNnxkNmVjZGMyMi1jMA
Fixed: 1444418
Change-Id: Ic8c034c69d159c370a7a6c4e8d39f9f2fa85cfac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614589
Commit-Queue: Friedrich Horschig <[email protected]>
Reviewed-by: Adem Derinel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157546}
Accessibility: Add AutoclickTestUtils
This change pulls out core Autoclick test logic into its own class so
that it can be used in other test suites. This change does the pure
refactor - the follow-up change will use AutoclickTestUtils from a
dictation test.
Bug: b:259353214
Change-Id: I45277a89f3e09893c5175684bc1f0288f51affc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608497
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157545}
[iOS] DefaultBrowserScreenCoordinator dealloc checks stop was called
Bug: None
Change-Id: I31c809134d8aaa8bc769ca821c3d64f62e816d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604944
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157544}
[iOS] ConsistencyAccountChooserMediator dealloc checks stop was called
Bug: None
Change-Id: I82f2d6058b23e31c6e5684d7a9933afdc7899aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604321
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157543}
[DB] Add metrics and add the video promo to the default browser promo manager.
This CL:
- Adds metrics to the default browser video promo.
- Create the Video promo in the default browser promo manager.
- check if video promo triggering criteria are met before registering the promo with the promo manager.
- Handles half screen default browser video promo.
Change-Id: I6c50e0180f6125311c5901a76612dc8a0dfa7081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4543882
Reviewed-by: Robbie Gibson <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Commit-Queue: Cheick Cisse <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157542}
Add initial version of PKCS12 certificates import to chaps.
Initial version has changes to chaps utils and unit test.
"Import user certificate" button's action is still not changed
and user's certificates will be still imported to NSS slots.
More unit tests will be added later to cover all corner cases.
Bug: b/264385929
Change-Id: I6ee7637b575854b224f834ecf2d69c72f6ed94cd
Testing: added basic unit test.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4286781
Reviewed-by: Pavol Marko <[email protected]>
Commit-Queue: Oleksandr Sarapulov <[email protected]>
Reviewed-by: Michael Ershov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157541}
[iOS] clearBrowsingDataCoordinator dealloc checks stop was called
Bug: None
Change-Id: I1a0fcf895d1886ccba89c12314da879ff8622481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608403
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157540}
Explicitly include <stdlib.h> and <cstdint>.
dwarf_line_no.cc uses abort, which is declared in <stdlib.h>.
heap_profiler_allocation_context_tracker.h uses int32_t, which is
declared in <cstdint>.
They are currently included transitively in libc++. When building with
modularized libc++, the transitive include will not work any more.
Bug: 1430956
Change-Id: I126119f8633398fafe84cc6ab2732fb57861ead8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609071
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Zequan Wu <[email protected]>
Reviewed-by: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157539}
[AutofillDataModel] Remove unnecessary optimizations.
The CL removes a check for when "exactly one field type is missing" given that it has rare chances to be met. It also cleans up all the remaining code.
Bug: 1454452
Change-Id: Ia140513d3cfa7fbff9df378349614a4143e28b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607385
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Commit-Queue: Norge Vizcay <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157538}
Extend histogram expiry: UMA.MetricsService.Initialize.Time
Bug: 1443513
Change-Id: Id22dfce0de017d14dfbdd69d741bd35f9ac89b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610089
Auto-Submit: Roger McFarlane <[email protected]>
Reviewed-by: Luc Nguyen <[email protected]>
Commit-Queue: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157537}
[Android] Delete NavigationHandlerTest#testSwipe..._with...Transition
The test cannot pass since the corresponding feature has not been
completed yet. Left a TODO and deleted the test.
Bug: 1434787, 1426201
Change-Id: I4df6dcf36cf86056493f18b52dd399592501f47e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608111
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Lijin Shen <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157536}
[ChromeVox + Select to Speak]: Don't interrupt continuous reading
When ChromeVox speaks, it interrupts all other TTS by design. However,
this causes Select to Speak to stop reading. In the case of the STS
panel, the play/pause button gets chromevox focus and changes its
tooltip when STS speech starts, which causes ChromeVox to read out
the new tooltip, which interrupts STS's speech. To fix this loop, we
can have ChromeVox not see the changing tooltip text but instead
always see the play/pause button as "toggle playback".
This change adds an a11y-only string for ChromeVox to read instead of
the tooltip, which makes STS reading work better with ChromeVox.
It's still not perfect as ChromeVox still interrupts STS for other
things, but read back is much more usable and not completely broken.
AX-Relnotes: ChromeVox doesn't interrupt STS's reading as much
Bug: b/286932070
Change-Id: Id7acd3460b1d31bdfded519e8571ab633cc28ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610719
Reviewed-by: Akihiro Ota <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157535}
Re-enable SigninFirstRunFragmentTest#testDismissButtonWhenUserIsSignedIn
Add a timeout to the verify call to reduce flakiness. Tested locally and
test is no longer flakey (for low values of infinity XD).
Bug: 1447085
Change-Id: I1cad54433d6f4f76be2d0b8a17bfca04e746c6c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610247
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Auto-Submit: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157534}
Updating trunk VERSION from 5832.0 to 5833.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I2a5b2d807e8a79ff2f890f49eb1a619d4e19c14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615923
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157533}
Update PDF OCR ChromeOS field trial name.
The name of field trial for PDF OCR ChromeOS rollout is updated to match
finch config in cl/537803327.
This CL does not have any effect on testing or production and is only
for matching with Google3 finch heuristics.
Bug: 1278249
Change-Id: Ie4c76bdc66577494e5fa76ee1eca6083dc8075ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613545
Auto-Submit: Ramin Halavati <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Commit-Queue: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157532}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686700798-cb29b14c7ed9966349373b19f56cb9cdb2793fcd.profdata to chrome-chromeos-amd64-generic-main-1686744225-488fad4d4f07cd55172be57fcb8002f7d018c761.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I3a3aa734b641535d288a66225a97f1e1cefe7981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615367
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157531}
[iOS] ReadingListMediator dealloc checks disconnect was executed.
Bug: None
Change-Id: Ib198c51650c9f180cdfe5d1cf7b2eef5c94c46a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604658
Reviewed-by: Menghan Yang <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157530}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686733162-d2d34d343cd92309198b527eb25b99aa340b8ba3.profdata to chrome-win64-main-1686743662-1cdc8d15119eba6f66cff7bf15709d8d1f07439a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I2cb2fc878c2c31f7f6beb82f4b617f85dbb19514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614606
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157529}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686721732-a92d860560486a5a1e6bb5a70947dacef509b22d.profdata to chrome-mac-main-1686743662-c8267b8ceb10f216f1d5ab5d1b61897c36fe8886.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ifcda92b86c2ee33f98122b8a1e2456acd866f8c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615283
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157528}
[iOS] HistorySyncScreendCoordinator dealloc checks stop was called
Bug: None
Change-Id: Ic9a5bea6175827b3162bb28ec523533e8268cba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609121
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157527}
dlp: Use new Files UX flag in FPNM
Prepares FPNM to show the new Files UX for desktop notifications and
warnings. Currently, as the flag is false, we will show the "old"
notifications and a system modal for the warning. In the next CL, I will
add the implementation for the branch when the flag is set to true, i.e.
with the new notifications that can also open the dialog.
[email protected]
Bug: b:286196824
Change-Id: Ica51ea4b375ddd5505866185c051d9ac08f8d3c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615063
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157526}
Add test for @starting-style inside container query
@starting-style up-to-date with the size container width that resulted
from the layout in the same style/layout update.
Bug: 1412851
Change-Id: I8245d02bee823ce19e74b9180615132aa1856154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614923
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157525}
[Topics] Use a separate base::Feature to control parameters
Why: This allows us to decouple the server side Finch configurations.
The `kBrowsingTopics` main feature is part of the config for
`kPrivacySandboxAdsAPIs` and it's becoming harder to make changes to
the big file.
Bug: 1453422
Change-Id: I57fd541a15aba13254de8381f2047076800e8724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602500
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157524}
[ios/b4p] Remove mention to passwords in Set Up list string
Behavior changes are behind flags (both kEnablePasswordsAccountStorage
and the Set Up list one). See details in the linked bug.
Fixed: 1454776
Change-Id: I06f9a30e36f016239857ec8b9edbba4f3f7d4545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614925
Reviewed-by: Scott Yoder <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Quick-Run: Victor Vianna <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157523}
Roll Perfetto from ec01d49359e6 to 49f628ceb9c9 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/ec01d49359e6..49f628ceb9c9
2023-06-14 [email protected] Merge "Fix a bug where the lesser timestamp is favoured in case of ties for previous input."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I62532f1ad8070d570e7620887d6f0d7240ff7b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615264
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157522}
SAA: Always call RequestPermission
In order to always let the browser process know that StorageAccess was
granted to a frame, we will remove the shortcut to resolve the
StorageAccess request immediately when a permission was previously
granted.
Bug: 1433644
Change-Id: I17773a845c4e37a358fb8fc164fd6be1f01a594f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4588535
Commit-Queue: Christian Dullweber <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157521}
Add metrics for Auto-verify content setting
Add UMA to record the default Auto-verify content setting to see the
tendency of users to allow/disallow the auto-verify features (currently
just Private State Tokens).
Bug: 1454578
Change-Id: Id3f46aba95391f72447dc9fbf8f17ca28d8144a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609072
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Ryan Kalla <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157520}
Migrate to use Gaia reauth endpoint for potential recovery cases
The GaiaScreen code is only used in OOBE and login screen. This will
have an impact for in-session Gaia screens.
Bug: b:285258760
Change-Id: Id98356f3c6fc791c6a25fe5e6846bc3f906c2e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4578939
Reviewed-by: Alex Ilin <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Commit-Queue: Yunke Zhou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157519}
[IWYU]: Add import to BUILD rule
Bug: None
AX-Relnotes: N/A
Test: Build works
Change-Id: I6b9ff66b6fe81ece691530d9abfd098ebfb2a30f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615345
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Auto-Submit: Katie Dektar <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157518}
Clean up the WebStateList observation in `webStateListDestroyed` method.
Bug: 1453401
Change-Id: I9a3c14156a79bc7f59b4d69238d731a3ec2062c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613788
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Petro Akzhygitov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157517}
[Sheriff] Disable DIPSBounceDetectorBrowserTest.DiscardPrerenderedPageCookieClientAccess
The test is flaky on Mac.
Bug: 1454793
Change-Id: I2cff9f06d2a9558cec300a1734ed03f75b253118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614746
Commit-Queue: Christoph Schwering <[email protected]>
Auto-Submit: Christoph Schwering <[email protected]>
Commit-Queue: Norge Vizcay <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Owners-Override: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157516}
Re-enable tests passing on Test Reviver
InstalledAppProviderTest#testAssetStatementSiteMissingParts
AddToHomescreenTest#testAddWebappShortcutWithEmptyPage
AddToHomescreenCurrentPageVerifierTest#testInScope
Bug: 1341840, 1052429, 1333198, 1269022, 1333196, 1283235
Change-Id: Ia6ee7c7d290fc1436711c43db433e6e7384c9343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599227
Commit-Queue: Peter Conn <[email protected]>
Auto-Submit: Ella Ge <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157515}
[iOS] Disable testOmniboxDefocusesOnTabSwitch entirely
The test was originally disabled for iPad only, but it also fails
on iPhone devices on shards which timeout. For example:
https://chrome-swarming.appspot.com/task?id=62d1f5c558508910
So it is now disabled completely.
Bug: 1453240
Change-Id: I4cfbaeaa0e555af9e0a87d3d8ba3feddec30bba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615743
Reviewed-by: Adam Arcaro <[email protected]>
Reviewed-by: Federica Germinario <[email protected]>
Owners-Override: Alexis Hétu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157514}
Revert "[Android] Enable NavigationHandlerTest#testSwipe...Ntp_EnterTabSwitcher"
This reverts commit 16423f22ef7103574305177de59bc0a89b432596.
Reason for revert: Still flaky
Original change's description:
> [Android] Enable NavigationHandlerTest#testSwipe...Ntp_EnterTabSwitcher
>
> This is a speculative fix. Waiting for the layout to finish doesn't
> seem enough to assert the NavigationHandler becomes inactive. This CL
> adds a polling to allow more time, as the signal to wait on is not
> clear.
>
> Bug: 1435090
> Change-Id: Idb421055672b944f94cbaa1cf568463d52f3bbd8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603705
> Commit-Queue: Jinsuk Kim <[email protected]>
> Reviewed-by: Michael Thiessen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156939}
Bug: 1435090
Change-Id: Ia2bc938970d15ce1a749223e070c91439c27dc89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611234
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157513}
dlp: Use same notification prefix
As per comments on crrev.com/c/4577203, we no longer need to have
different notification id prefixes for different file actions, since
they will anyway be unique. This CL removes the old action specific
prefixes, like `dlp_upload_blocked` and uses the same prefix for all
notification types. We will also use the same id prefix for warnings.
[email protected]
Bug: b:287199399
Change-Id: I7fe651d972c0bc60f2aaba82980959a2237b217d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614465
Commit-Queue: Aida Zolic <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157512}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686736799-59d2c413cafc56af9c1af0325510aee39dc2c53c.profdata to chrome-mac-arm-main-1686743662-fba25cab877502207b64c66cd0d48c46b0646b52.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie6eb68db13365ebe4675ae97742fd45bcbd888fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615284
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157511}
[iOS] Refactor UIKeyModifierFlags To Use Method
There is an issue with modified flag being set properly. It was a
test-only private API that moved from a property to a method.
Change-Id: I302014691b052bca3d3ffee58e5fd35401fd38e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607156
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157510}
[MediaDevices] Make GetMediaDeviceSaltAndOrigin() asynchronous
This is in preparation to a better mechanism for persistent storage of
salts for device IDs, which will be asynchronous.
Bug: 1410462
Change-Id: I3c9e0a892a23d0846508c35aee873a362aabaefb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598768
Reviewed-by: Jonathan Metzman <[email protected]>
Reviewed-by: Mark Foltz <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157509}
Roll WebRTC from 1cb54bee7ac2 to b7af6b963bed (1 revision)
https://webrtc.googlesource.com/src.git/+log/1cb54bee7ac2..b7af6b963bed
2023-06-14 [email protected] Revert "Merge the codec types"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I0aa484a2eb5bfbcdd788b4264c977d0fc7c3c7af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615366
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157508}
dlp: Add FilePolicyDialog create methods and factory
Adds a static method to create FilePolicyDialog-s, as well as a factory
that can be injected in tests. The static method takes care of creating
the correct dialog, rather than the caller creating the widget, showing
it etc. The factory can be mocked in tests so that we can easily check
that the parameters passed when creating the dialog are correct, and
also avoid additional setup required to actually show a real dialog.
This is preparation of upcoming changes to show the new Files UX.
[email protected]
Bug: b:287198463
Change-Id: I27f996e02215f5d6a9b7541dea40b8d4b69f960d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614564
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157507}
[gin] Add feature for Turboshaft
Prepare finch trial for V8's new compiler IR Turboshaft
Bug: chromium:1454443
Change-Id: I2b21cd647ffc5caf7265a3e333549454aa66c31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610748
Auto-Submit: Nico Hartmann <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157506}
Add DeviceLoginScreenWebHidAllowDevicesForUrls policy
Implement a device policy DeviceLoginScreenWebHidAllowDevicesForUrls
which is a login screen version of WebHidAllowDevicesForUrls policy.
Pass the new policy to a new preference
kManagedWebHidAllowDevicesForUrlsOnLoginScreen. Make
HidPolicyAllowedDevices a keyed service and add its factory
HidPolicyAllowedDevicesFactory.
Bug: b:282676145
Change-Id: I3d133d80fca2f6c67d71c03e50a93f777d6f4870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4530656
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Matt Reynolds <[email protected]>
Commit-Queue: Matej Aleksandrov <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157505}
Remove redundant reference to window object
Bug: 1450120
Change-Id: I13d522c547598735e9d5d47090dd4bb6080b28b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615163
Reviewed-by: Fr <[email protected]>
Commit-Queue: Benjamin Keen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157504}
[DoH] Extend Net.DNS.DnsTransaction.<Insecure|Secure*> metrics
For the `Insecure` and `SecureValidated` histograms, let's keep
these indefinitely (setting them to expire a year from now) since
we use these when analyzing the performance of each DoH provider.
For `SecureNotValidated`, let's extend it for now in case we
want to use it when evaluating the new DoH auto-upgrade success
metric (see:
https://chromium-review.googlesource.com/c/chromium/src/+/4577618),
but I think long-term we may only want to keep
`SecureNotValidated.FailureError` of these.
Also, let's change the alternate owner from `[email protected]`to
`src/net/dns/OWNERS`. This will improve tracking of the metric
expirations, since this will cause the `Internals>Network>DNS`
component to be added to the 'Check expiry of your histogram`
crbugs, and since `[email protected]` is an internal-only
email list and doesn't receive any of the expiration reminder
emails from crbug.com.
Fixed: 1441543 1441542 1441541 1441540 1441539
Fixed: 1441538 1441537 1441536 1441535 1441534
Fixed: 1441533 1441532 1441531 1441530 1441529
Fixed: 1441528 1441527 1441526 1441525 1441524
Fixed: 1441523 1441522 1441521 1441520 1441519
Fixed: 1441518 1441517 1441516 1441515 1441514
Fixed: 1441513 1441512 1441511 1441510 1441509
Fixed: 1441508 1441506 1441505 1441504 1441503
Fixed: 1441502 1441501 1441500 1441499 1441498
Fixed: 1441497 1441496 1441495 1441494 1441493
Fixed: 1441492 1441491 1441490 1441489 1441488
Fixed: 1441487 1441486 1441485 1441484 1441483
Fixed: 1441482 1441481 1441480 1441479 1441478
Fixed: 1441477
Change-Id: I8209443465ce48e33ec79b17e046b9b964f2ad78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605125
Commit-Queue: Andrew Williams <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157503}
Roll Dawn from a0e679b77011 to 19f92f9cdeab (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/a0e679b77011..19f92f9cdeab
2023-06-14 [email protected] [ir] Convert tests to block builder.
2023-06-14 [email protected] [ir] Allow builder to auto-append instructions.
2023-06-14 [email protected] d3d11: Fix texture format view reinterpretation
2023-06-14 [email protected] d3d11: Enable MultisampledSamplingTest
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Ia54ee81b76ab36375c781b9c0860cceb6d16573b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615285
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157502}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686721732-9194d37899dfb02f3a7676fd67b2195141cddd34.profdata to chrome-linux-main-1686743662-938f5d72d478557f00ae04a0b4bf2070f779100d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I6410040eb8b02d6d48b639574f0239c84c6f5545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614238
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157501}
Reland "Refactor report_scheduler"
This reverts commit 7ccb1f0ad6b713760f6ad19ef72da316781ea462.
Reason for revert: Fixup raw pointer initialization issue.
Original change's description:
> Revert "Refactor report_scheduler"
>
> This reverts commit 1e66cc8913f07551151bf22bc22cc4060aa9b11f.
>
> Reason for revert: Suspect this is breaking several bots failing on
> RealTimeReportControllerTest.ExtensionRequest
>
> See first build on Mac below
> https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20(1)
>
> Original change's description:
> > Refactor report_scheduler
> >
> > Move real time reporting related logic into own classes.
> >
> > Additionally, make real time reporting no longer depends on the regular
> > status report. Note that extension request still depends on status
> > report which is controlled by its PolicyHandler.
> >
> > Change-Id: Ib7c094efac1485667657bb4ae352b4b70e8f7cf5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584953
> > Reviewed-by: Anqing Zhao <[email protected]>
> > Commit-Queue: Owen Min <[email protected]>
> > Reviewed-by: Igor Ruvinov <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1156886}
>
> Change-Id: Iaf25385e116a8ae45ec8d89836a7cf47ad27b4ec
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610073
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: Tom Lukaszewicz <[email protected]>
> Owners-Override: Tom Lukaszewicz <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157078}
Change-Id: I3232c24aabf31cf1c373b7bfabbad1e07aa1fb35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607157
Reviewed-by: Igor Ruvinov <[email protected]>
Reviewed-by: Anqing Zhao <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157500}
Updating XTBs based on .GRDs from branch main
Change-Id: I05aff9130b965631c89a994de6207a7822043630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614705
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157499}
Move more state inside CronetTestFramework
This paves the way for future improvements that will make it possible to
customize the returned Context by calling methods on the CronetTestRule
object. Also this makes the code more correct by ensuring we go through
the full setup and teardown procedure for every "subtest".
Change-Id: I070e3a36bac6d5c574b2984367f78cd2f3bf7bc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610229
Reviewed-by: Stefano Duo <[email protected]>
Auto-Submit: Etienne Dechamps <[email protected]>
Commit-Queue: Stefano Duo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157498}
Remove unnecessary variable in 'scene_state.h'
There is no caller of this variable in codebase, so remove it. And
also remove the unused comments in 'start_surface_scene_agent.mm'.
I want to clean up the unused variable and functions about NTP
in codebase to keep the codebase clean and easy to read.
Change-Id: I7fc1440435145cdd3ab8147f344687f0228460b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584077
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Stone Dong <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157497}
Disable flaky TabContentManagerTest#testJpegRefetch
BUG=1454653
Change-Id: Iba515cb78136c421fab563cb68464580fa520d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611812
Owners-Override: Peter Kotwicz <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Auto-Submit: Peter Kotwicz <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157496}
Roll Skia from b80cbfaf81f3 to 13266cc111b9 (23 revisions)
https://skia.googlesource.com/skia.git/+log/b80cbfaf81f3..13266cc111b9
2023-06-14 [email protected] Add my chromium.org email to owners
2023-06-14 [email protected] Revert "Quad intersections for glyph underlines"
2023-06-14 [email protected] Remove duplicate paint_scale gms
2023-06-14 [email protected] Roll ANGLE from 1572f609c18e to 3a3a3c655a96 (11 revisions)
2023-06-14 [email protected] Roll Skia Infra from ecc1c77185cb to ae32157135ff (6 revisions)
2023-06-14 [email protected] Roll Dawn from bfe346b8723e to a0e679b77011 (10 revisions)
2023-06-14 [email protected] Roll vulkan-deps from f4703823888a to 5b7ee750e5e8 (5 revisions)
2023-06-14 [email protected] Roll SK Tool from 3ab2beba4131 to ae32157135ff
2023-06-14 [email protected] [skif] Remove legacy Magnifier implementation
2023-06-14 [email protected] Add WGSL support for additional intrinsics.
2023-06-13 [email protected] [pdf] Remove SK_IGNORE_PDF_DW_FIX
2023-06-13 [email protected] [sksl] Fix alphabetic ordering of compute shader texture intrinsics
2023-06-13 [email protected] Revert "Move tiled image draws to operate at the Device level"
2023-06-13 [email protected] [graphite] Add generation from SkImages to wacky_yuv GM
2023-06-13 [email protected] Revert "Add unit test for nested runtime blending"
2023-06-13 [email protected] Add unit test for nested runtime blending
2023-06-13 [email protected] [sksl] Rename compute shader texture intrinsics
2023-06-13 [email protected] Move tiled image draws to operate at the Device level
2023-06-13 [email protected] Rename SkPromiseImageTexture -> GrPromiseImageTexture
2023-06-13 [email protected] [graphite] Add Vulkan draw support.
2023-06-13 [email protected] Fix GLSL codegen when sk_Clockwise appears in more than one function.
2023-06-13 [email protected] Quad intersections for glyph underlines
2023-06-13 [email protected] Roll vulkan-deps from 13e40cf948ed to f4703823888a (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Test: Test: Test: Verify per-application override is no longer cleared
Change-Id: I751627530c8d8f134fb4d2e3bc08bddbc73af654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614235
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157495}
Clean up launched experiment FlushGpuAtDraw.
Bug: 1369739,1378021,1421227
Change-Id: I14f356eb5911ed82aa46dd31c025626d9c12017a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604630
Reviewed-by: Vladimir Levin <[email protected]>
Commit-Queue: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157494}
Automatic update from google3
Automatic update for 2023-06-14 UTC
Change-Id: I61d43fba5963b22181a4b12a7f261e8e3cb01778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615323
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157493}
[Canvas] Draw nothing when filling a line segment
Filling a path that is just a line should draw nothing. A recent
optimization that uses SkCanvas::drawLine instead of SkCanvas::drawPath
to draw line segments caused a regression because drawLine() always
strokes paths. This CL fixes the bug by exiting early when attempting to
fill a path that is just a line.
Bug: 1450607
Change-Id: I3532b85f6c6123d3a4ec189d5336c03f579684b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611285
Commit-Queue: Justin Novosad <[email protected]>
Reviewed-by: Jean-Philippe Gravel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157492}
[Sherriff] Disable DumpAccessibilityTreeTest.HiddenTable
The test is flaky on ChromeOS, Linux, Mac, Windows.
Bug: 1454778
Change-Id: Ic9c5ba71c6f3da6a31eb29309b140dd49244a37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615124
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Norge Vizcay <[email protected]>
Auto-Submit: Christoph Schwering <[email protected]>
Owners-Override: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157491}
Create components/enterprise/buildflags
This new directory initially includes flags to capture the platforms of
cloud and local content analysis. To keep this CL simple, refactors in
other parts of the codebase are left for future CLs to use these new
buildflags so that it can be done incrementally.
Bug: b/283093731
Change-Id: I94498181e6d3c801d7eb9aa7b3ec35d9f6328766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609067
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Reviewed-by: Nancy Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157490}
Roll devtools-internal from 3fdc8c60baff to 99df666936d6 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/3fdc8c60baff..99df666936d6
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7d38c095bf3e53356cbda99cb1b10bc4a096759d..123c3ef5b631495a8501f79900689bc972acc2b9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I5520d827dfb300c2fc153521bf514fb95dffb5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614736
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157489}
Add GPU shard machine time script
Adds a script to get estimates about the machine time used for testing
shards on GPU builders. The numbers it produces are not necessarily
highly accurate due to availability of data on non-passing shards, but
should give a good enough estimate when trying to track down areas that
consume large amounts of machine time or are candidates for sharding
changes.
Change-Id: Ib9b596b8a69b586d390246616ef72a4f71afd5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4563881
Auto-Submit: Brian Sheedy <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Commit-Queue: Yuly Novikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157488}
Automatic update from google3
Automatic update for 2023-06-14 UTC
Change-Id: I1f116f18e83290ec34661081fea218aebe341ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615363
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157487}
Roll Perfetto from 57cd2bc9b473 to ec01d49359e6 (3 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/57cd2bc9b473..ec01d49359e6
2023-06-14 [email protected] Fix SockAddrAny -> SockaddrAny
2023-06-14 [email protected] Merge "Normalize timestamp formatting throughout UI"
2023-06-14 [email protected] Merge "UnixSocket: support the vsock address family"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I8c06ebbb3d6d46e5775d0a2f610c30bcaf0c91d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614234
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157486}
Roll WebRTC from 49ace8b6548c to 1cb54bee7ac2 (1 revision)
https://webrtc.googlesource.com/src.git/+log/49ace8b6548c..1cb54bee7ac2
2023-06-14 [email protected] Delete unused killswitch flag related to scalability mode.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I219ba4ba56fcdb0964203411c0824df0bc19f520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614734
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157485}
Add checks for soft nav metrics
This CL adds checks that soft nav count and start time should be not be smaller/earlier that the existing ones when a soft nav metrics is to be
updated. This change also speculatively addresses previous CHECK failures seen in crbug.com/1451911.
Bug: 1370937
Change-Id: I49b47b78af5d82c7260af61e7be69d566ff026c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604461
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Hao Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157484}
[Sheriff] Disable flaky ChromeOS tests
Disables some tests that have recently been flaky on linux-chromeos-dbg
and some other ChromeOS bots (but no other platforms):
- EnterpriseEnrollmentTest.TestAttributePromptPageGetsLoaded
- InitialEnrollmentTest.EnrollmentForced
- AssistantOptInFlowTest.SkipShowingValueProp
- PendingApprovalTelemetryExtensionEventsApiBrowserTest.KeyboardDiagnosticEventOpensDiagnosticApp
Bug: 1454755
Change-Id: I99ec6d9aa68faf4b2cb74822a2e83eaa9f211c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615024
Auto-Submit: Christoph Schwering <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Owners-Override: Christoph Schwering <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157483}
[CR2023][Profiles] Remove sync badge for avatar on Profile Menu
Preview: https://crbug.com/1422119#c25
Bug: 1422119
Change-Id: I7b51c06a018ecc2660cf527ae8b40aee0abea987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614843
Commit-Queue: Gabriel Oliveira <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157482}
[OOBE] Fix dynamic illustration support D/L mode
add new colorchange listener for D/L mode and refresh css to oobe
for the dynamic illustrations.
Bug: b:287162396
Change-Id: If2d747732226c6cb14fd2354715a1234d0c87dc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613465
Reviewed-by: Osama Fathy <[email protected]>
Commit-Queue: Brahim Chikhaoui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157481}
[OOBE][CHOOBE] set light mode default for CHOOBE and optional screens
set kDarkModeScheduleType to None.
Bug: b:287162490
Change-Id: Ic96c2eb4e2420d0f9cf9269283c48356d24daf53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613485
Commit-Queue: Brahim Chikhaoui <[email protected]>
Reviewed-by: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157480}
gpu: Enable direct texture upload path for Graphite
Direct texture upload path was disabled due to RGBA/BGRA mismatch issue,
but that was fixed and this works fine now with local browsing.
Bug: 1423576
Change-Id: I46e86ec22e7018b61cdd57a93ccf254801dac282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612230
Commit-Queue: Saifuddin Hitawala <[email protected]>
Auto-Submit: Sunny Sachanandani <[email protected]>
Reviewed-by: Saifuddin Hitawala <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157479}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686711525-32dc40b17b5db2bab91c6ecbc661a4e664f9cf8c.profdata to chrome-win32-main-1686733162-c653addd0619e2d9fa1f4b3ec3e0c257d4855166.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Iebbe91bba1268d43bb22f884f340725b95ea06ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613667
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157478}
Prerender: Add fieldtrial testing config for SpeculationRulesPrerenerMemoryLimit
This CL adds the fieldtrial testing config for
SpeculationRulesPrerenderMemoryLimit with a new acceptable percentage
(100%).
Bug: 1382697
Change-Id: I04bc1a774c3cf95392cd7f1bca5f55bdf383c520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613326
Commit-Queue: Hiroki Nakagawa <[email protected]>
Reviewed-by: Huanpo Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157477}
Implement new password protection minimum length behind flag
In an effort to have Phishguard protect all passwords from being
phished, we plan to lower the minimum password length required for
checking reuse from 8 to 4.
Bug: 1406307
Change-Id: Iaea437d1ad1dfeb36a675e1f9182c19429c18069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605553
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Sarah Krakowiak <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157476}
[Android] Extend historgram expiration
Bug: 1445597
Change-Id: Ie5a8895722a5aafe37373009389521f3fdf6b568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614145
Reviewed-by: Calder Kitagawa <[email protected]>
Auto-Submit: Rohit Agarwal <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157475}
Update V8 to version 11.6.144.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/89367f3a..10f7ee23
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I3724eba347373728f070ef0e027ae943d2932ecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614443
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157474}
Roll R8 from AostPkk2hQv2Pz7k7... to vw5kLlW3-suSlCKSO...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: [email protected]
Change-Id: I72a83c3492930ccd3cc1a788f63738d5c3f71830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614603
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157473}
Removed palette-add() and palette-scale()
We propose font-palette to not be additive since it was recently
resolved that “The <color> type is not additive.”, compare [0].
Functions palette-add() and palette-scale() are used to represent
font-palette property during the additive animations.
[0] https://github.com/w3c/csswg-drafts/commit/327110f01b36c79c4d04f55d8fa30898e8d2cae0
Bug: 1400620
Change-Id: Icecb14b0196ebf60e2f816c61edef97b60f74557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604943
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157472}
[iOS][Toolbar] Add toolbar switching logic in ToolbarMediator
Listen for events that impacts the omnibox position in ToolbarMediator.
The omnibox is in the bottom toolbar when:
- the location bar is not focused
- the web state is not a non-incognito NTP
- user preference is to have it on the bottom
- device is a iPhone in portrait mode (split toolbar)
Also:
- Remove CHECK(_started) setLocationBarViewController as this can now
happen during the start.
- Moves the `updateToolbar` call from BVC to ToolbarMediator.
Bug: 1453279
Change-Id: I808cc422255ceb48452694f967b8d158e49d40e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608592
Auto-Submit: Christian Xu <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157471}
Roll Projector App from 4XKZfAUsV0HxB3ygo... to hYEUQKnrR609ieEmg...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306140100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/hYEUQKnrR609ieEmgDH86NnZOjD9j-ef370irGLk8X8C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/275114476
Tbr: [email protected]
Change-Id: I94a4825b8939af7f496ac2b10e7997c96d3ba265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613712
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157470}
Remove stale Blink expectations
Autogenerated CL from running:
//third_party/blink/tools/remove_stale_expectations.py --project chrome-unexpected-pass-data --no-include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --large-query-mode --num-samples 200 --jobs 2
Affected bugs for CL description:
[email protected]
Bug: 1044742, 1088475, 1196620, 626703, 664858
Bug: 866850
Change-Id: Ide950d124d845c005d2e47e8ab98b9db661d52aa
Fixed: 1356449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613307
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157469}
Replace SkColor with blink::Color in FontPalette
Using blink::Color instead of SkColor for blink's font-palette
representation. It is needed for the future modifications in the
palette-mix function, to be able to interpolate in different color
spaces, compare section "Mixing Palettes: the ‘palette-mix()’ Function"
of Explainer:
https://docs.google.com/document/d/1XMTrKH003KBOes6hxzI-3E7LTwp5YwFC-rnzoFpFrfw/edit?usp=sharing
Bug: 1400620
Change-Id: I08e33f6dbe4d1cad1506b1e0dea299c20f6ea380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597888
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157468}
Roll Fuchsia Internal Images from 13.20230614.0.1 to 13.20230614.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I4eb718a7c68f8f53527b72d80f30414df59a5e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614230
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157467}
Quick Delete: Add a method to get unique domains visited within a range
Add a function to query local history database for synced and local
unique domains visited within a time range and the last visited domain.
Bug: 1412087, b/276290677
Change-Id: I424f0718886654ff5f04f02c25bae9eeab1e455b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573633
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Zaina Al-Mashni <[email protected]>
Reviewed-by: Rohit Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157466}
SAA: Record default setting state
Record the default settings state of the Storage Access setting.
Bug: 1454578
Change-Id: Ic19292dfe75b359665870498a74bf14d21232c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613985
Reviewed-by: Filipa Senra <[email protected]>
Commit-Queue: Filipa Senra <[email protected]>
Auto-Submit: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157465}
dlp: Remove unused storage dependency
Bug: b/287181034
Change-Id: I3b237adf6afc209c038f41edf24cef13c96e9f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614544
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Luca Accorsi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157464}
Roll ANGLE from 7daa3442caac to 341dabf8e58e (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/7daa3442caac..341dabf8e58e
2023-06-14 [email protected] Roll vulkan-deps from 701c5daafb72 to cebf5626ca50 (30 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I10a23770d1e85faa0dafe77494cd04acc1422b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614231
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157463}
[//gpu] Replace GLImage stubs with usage of GLImageNativePixmap
Several tests create stubs of GLImage. This usage can all be replaced
with creation of GLImageNativePixmap instances instead. This paves the
way for a followup CL that replaces all references to GLImage in the
codebase with references to GLImageNativePixmap.
Bug: 1324249
Change-Id: I086e5c67d5975694bb75033d8b9be68a9e161238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603855
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157462}
[iOS] Add Metric For Browser Lockdown Mode Per Navigation
We record OS Lockdown Mode per navigation. We should also capture if
a user has lockdown mode enabled through browser lockdown mode.
Bug: 1412437
Change-Id: I31ec8a577663e871417549fd55c74c5e110987cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609309
Reviewed-by: Ali Juma <[email protected]>
Commit-Queue: Joemer Ramos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157461}
Add GetD3D11Device in SharedContextState
With Graphite, Chrome will use Dawn D3D11 instead of ANGLE for
compositing. And Dawn and ANGLE are using different D3D11 devices
For presenting video frames with DecodeSwapChain, media should
use the D3D11 device from Dawn instead of ANGLE.
Bug: 1434131,1454194
Change-Id: Idc96ce8a9b0c55593ad95d80c45b4f7c8bf0d343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604896
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157460}
Roll devtools-internal from ff8f0b2d9dd6 to 3fdc8c60baff (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/ff8f0b2d9dd6..3fdc8c60baff
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/564689f7b454c35e4dd8ed23b75123cd55522f54..7d38c095bf3e53356cbda99cb1b10bc4a096759d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I139df89d3f1f81d8d958db1412e913eb5cc2cef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614251
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157459}
Roll abseil_revision 1285ca4b4f..dc37a887fd
Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/1285ca4b4f..dc37a887fd
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/1285ca4b4f..dc37a887fd
Bug: None
Change-Id: I18c63b7afbf721ce9d3e36e5b797786a1d40b84b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613486
Reviewed-by: Danil Chapovalov <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157458}
[OOBE] - Add Jelly font style to the oobe buttons
Mocks: go/oobe-jelly-mocks
Bug: b:270913356,b:287020335
Change-Id: I7ab19d8bea72355d1c871e8cac3b9417230724a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604534
Reviewed-by: Renato Silva <[email protected]>
Commit-Queue: Bohdan Tyshchenko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157457}
WebRTC-Audio-GainController2: Update fieldtrial testing config
Bug: webrtc:7494
Change-Id: Ic37fbc4eb197ce862a4e7bbdcd06a6df64cc784b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613766
Reviewed-by: Ale Bzk <[email protected]>
Commit-Queue: Hanna Silen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157456}
Roll Fuchsia SDK from 13.20230613.4.1 to 13.20230614.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I49cf2cfd5ac63cdc98f06353d6863a8b58e80e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614248
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157455}
[password manager] Add passkey delete dialog
Add a confirmation dialog when deleting a passkey.
UXW review:
http://go/passkeys-in-chrome-pwm-uxw
Screenshot:
https://storage.cloud.google.com/chromium-translation-screenshots/a5de9746332c70d1893b771bb244a4ac93911642
Design doc:
https://docs.google.com/document/d/1Ox_VBGNO-Ff9bcP97FUMcN15Xtfn_sz0_WuDe3ujbwA
Bug: 1432717
Change-Id: I9dae66ef65b0d4b4fb9c3e0e8d66b3a5a0b249d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601909
Commit-Queue: Viktor Semeniuk <[email protected]>
Auto-Submit: Nina Satragno <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157454}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686721732-3842ab4df45e821a4ff943608322f109cf884f6f.profdata to chrome-win64-main-1686733162-d2d34d343cd92309198b527eb25b99aa340b8ba3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Ifec101952bd73488119f2764bdf94f994814af48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612468
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157453}
Roll WebRTC from 3cf60bed1d3c to 49ace8b6548c (2 revisions)
https://webrtc.googlesource.com/src.git/+log/3cf60bed1d3c..49ace8b6548c
2023-06-14 [email protected] Merge the codec types
2023-06-14 [email protected] Roll chromium_revision 13b44452d4..bb8855a075 (1157265:1157397)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I56ef5833b0efc25ace2c270b18f56c19194a0344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614227
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157452}
SAA: Add StorageAccess exception histograms
Add storage-access metrics to record statistics on the number of
exceptions stored by users. Besides the default histograms, this adds
a histogram to record the maximum number of exceptions for per embedder
and requester.
Bug: 1433644
Change-Id: I77c423073320e7be633473437c0c958e82d74f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603255
Commit-Queue: Christian Dullweber <[email protected]>
Reviewed-by: Filipa Senra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157451}
Roll vulkan-deps from 883f368cdad6 to 16ff5c9d2ecb (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/883f368cdad6..16ff5c9d2ecb
Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/949cc246b4..72ec0a39e1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8c41e070c5e6caaf97a20487d6c965b7fb0d6a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611880
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157450}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686729470-820e08da085fa909a81b980f81e69b2421aa3b26.profdata to chrome-mac-arm-main-1686736799-59d2c413cafc56af9c1af0325510aee39dc2c53c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8a2aac5a0f54fb8b87986749adfceb713b4d6bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614254
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157449}
[ios][web] Add proto serialisation of SessionCertificatePolicyCacheImpl
Add new constructor to SessionCertificatePolicyCacheImpl to build it
from a protobuf object (web::proto::CertificatesCacheStorage) and a
method to serialize an instance in a protobuf object.
Update SessionCertificatePolicyCacheImpl unit tests to use the new
API for serialization/deserialization (used to inspect the internal
state or to inject data when testing UpdateCertificatePolicyCache).
Bug: 1383087
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Change-Id: I0824caad2ab769903f8403ff5ccd6d90faa7db4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4543181
Reviewed-by: Federica Germinario <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157448}
Revert "Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json"
This reverts commit 9e8cc1c30b0f61f5c083c1673016fc77f558ca9a.
Reason for revert: Got many regressions https://crbug.com/1454685, https://crbug.com/1454686, https://crbug.com/1454730.
Original change's description:
> Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json
>
> Bug: 1431792
> Change-Id: I0195390420af26e7df1faae4d4aef7ab248cd627
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604704
> Reviewed-by: Shunya Shishido <[email protected]>
> Reviewed-by: Yoshisato Yanagisawa <[email protected]>
> Commit-Queue: Minoru Chikamune <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157278}
Bug: 1431792
Bug: 1454685
Bug: 1454686
Bug: 1454730
Change-Id: I98e33fbf9f0f352cb809cc2c6093b18711ae726e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613451
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Minoru Chikamune <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157447}
Roll ios_internal from 982f063c939b to 44eb5bd19dfe
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/982f063c939b..44eb5bd19dfe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Iaed095b5eec54de0f62ae1adf72792d09b322af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613711
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157446}
[Sheriff] Disable NavigationPredictorBrowserTest.ViewportOnlyAndUrlIncrementByOne
The test is flaky on Linux and on linux-chromeos-dbg due to a
timeout, for example:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/33195/overview
Bug: 1415981
Change-Id: I0532b560ca4e221a199ffb297f3d1884948dd7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613946
Auto-Submit: Christoph Schwering <[email protected]>
Owners-Override: Christoph Schwering <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Norge Vizcay <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157445}
Add "preserve_most" calling convention to Chrome
The calling convention is beneficial for the hot-cold splitting
optimization. Having no volatile registers in the hot path allows the
compiler to generate more optimized code (e.g. avoid register spilling).
"preserve_most" has been successfully used in V8 (Oilpan and Wasm).
See detailed description here:
https://clang.llvm.org/docs/AttributeReference.html#preserve-most
Bug: 1451766
Change-Id: I354cd7f6d72f435857ebd4da5444a215a5663d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4593936
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Anton Bikineev <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157444}
[Autofill] Minimize DenseSet
This CL essentially replaces std::array<raw_int, 1> with raw_int.
The Android bot reports a marginal binary size saving of 180 bytes
but the APK breakdown suggests it's 630 bytes. That's not much but
would grow if and when this is moved to //base and merged with
EnumSet.
Bug: 1007974
Change-Id: Ic525927204e5a5c7a2869a3a1d9f3c24c24c6b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400950
Reviewed-by: Dominic Battre <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157443}
Import wpt@1356fec80b6019eadb42e28c8cff7c20013c8a09
Using wpt-import in Chromium 1a9c191dc9d60201d1a873df5b9dd0043666ee13.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: Ifa217ac4e7708d457dd09237fec3f4610c4b1690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613645
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157442}
Roll ANGLE from 3a3a3c655a96 to 7daa3442caac (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/3a3a3c655a96..7daa3442caac
2023-06-14 [email protected] Roll Chromium from 28f11e95962d to bfc7c889fd6c (628 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ia50596a33753abf15b308ed6259e1b4ed5a87fef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613710
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157441}
SyncPrefs: User migration for kReplaceSyncPromosWithSignInPromos
This CL adds the logic to migrate pre-existing signed-in users into
the correct state after kReplaceSyncPromosWithSignInPromos is enabled.
In particular:
* Preferences gets turned off.
* Bookmarks and ReadingList remain on only if
kBookmarksAndReadingListAccountStorageOptIn is true.
* Autofill remains on only if Passwords is on.
* NOT handled yet in this CL: Autofill state for custom passphrase
users.
Note that signed-out users and syncing users are not affected.
Note^2 that the migration should run exactly once whenever the feature
kReplaceSyncPromosWithSignInPromos gets enabled. In other words, it
should run again in the same profile iff the feature got turned off
and back on.
Bug: 1447020
Change-Id: I5ce10e7f0f5e6d3e0e9d0e2f4f572c8ed1136a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604190
Reviewed-by: Victor Vianna <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Jood Hajeer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157440}
Introduce dictionary size and count limit per top frame site
crrev.com/c/4576244 and crrev.com/c/4592590 introduced dictionary size
and count limitation. They are global limits per Network Context. So it
is technically possible to detect a new dictionary registration on a
different site by checking the existence of dictionary. To mitigate
such privacy concern, this CL introduces the size and count limit per
top frame site.
The size and count limits per site is set to the half of the global
size and count limits. The global count limit is 1000. And the global
size limit is calculated from the available disk space by
CalculateAndSetSharedDictionaryCacheMaxSize().
This CL also doubles the max value of the limitation in
CalculateAndSetSharedDictionaryCacheMaxSize() as we are expecting 100 MB
dictionary.
This CL introduces following histograms:
- Net.SharedDictionaryStore.DictionaryCountPerSiteWhenAdded.
- Net.SharedDictionaryStore.DictionarySizeKBPerSiteWhenAdded
And renames following histograms:
OBSOLETE_HISTOGRAM[Net.SharedDictionaryManagerOnDisk.DictionarySize]=Replaced with Net.SharedDictionaryManagerOnDisk.DictionarySizeKB
OBSOLETE_HISTOGRAM[Net.SharedDictionaryManagerOnDisk.TotalDictionarySizeWhenAdded]=Replaced with Net.SharedDictionaryManagerOnDisk.TotalDictionarySizeKBWhenAdded
Bug: 1413922
Change-Id: I7b11af17f67f9574abc322ae41183028e0b5ae24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597056
Reviewed-by: Patrick Meenan <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157439}
Plumb Renderer Main thread id into ADPF session
This change gives +10-15% increase to the speedometer score. Repro steps:
- Build with Android high end arm64 build flags, with and without this patch
- Run speedometer, easier manually or using crossbench on a device with APDF support
While most animations/scrolls should not be blocked on Render Main, we don't have any evidence/data showing that this change causes any regressions. So the plan is to run this change as a field experiment:
- If it doesn't cause any regressions, we get a speedometer score increase without measurable downsides
- If it causes some regressions, we'll have concrete data showing why adding Render Main to the ADPF session is harmful
Bug: b/286189281
Change-Id: I53eeb47b6bd5eaba2fd20284461572f1dba528a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595058
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Igor Kraskevich <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157438}
Copy chrome metrics files to Chromium
The source of truth of these files will now be in Chromium. These will be autorolled to Perfetto.
Change-Id: I5c2430ca87c5179a3dc246bddf0179a3c5c0116c
Bug: b/283962174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604611
Commit-Queue: Rasika Navarange <[email protected]>
Reviewed-by: Stephen Nusko <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157437}
[Multi Apps] Show to-be-uninstalled sub apps in parent app uninstall
prompt
When an app with sub apps is uninstalled, all sub apps automatically get
uninstalled. To inform the user about this, extra information is added
to the uninstall confirmation dialog: a description that explains the
additional uninstalls followed by a list of all sub apps that this will
affect. This change is for ChromeOS only.
Bug: 1354567
Change-Id: I6da51cdc190a49faaa76f0304cf3f26962f4f710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288778
Commit-Queue: Sam Thiesen <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157436}
[Policy] Header Search enhancements
The searchbar of the chrome://policy page looks out of place.
This CL makes it look similar to the one found in Chromium settings.
Screenshot: https://drive.google.com/file/d/1z7nS0K9JLDgA3m_5peRBO97_yBpE69CQ/view?usp=sharing
[email protected], [email protected]
Change-Id: I27cdd7a589d6b6cf5b089c16fc840bb0c6926e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603699
Reviewed-by: Fabio Tirelo <[email protected]>
Commit-Queue: Aryan Kaushik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157435}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: Iffe07dfce31dbedac4d3d56e1c1ef61d678d5c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611161
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157434}
Roll src/third_party/harfbuzz-ng/src/ 8df5cdbcd..db700b567 (436 commits)
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/8df5cdbcda49..db700b5670d9
$ git log 8df5cdbcd..db700b567 --date=short --no-merges --format='%ad %ae %s'
2023-06-12 grieger [subset] fix fuzzer timeout.
2023-06-12 49699333+dependabot[bot] Bump ilammy/msvc-dev-cmd from 1.12.0 to 1.12.1
2023-06-12 49699333+dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3
2023-06-10 behdad [subset/cff1] Remove always-true check
2023-06-10 behdad [subset/cff] Simplify a few serialize calls
2023-06-10 behdad [subset/cff2] Error handling
2023-06-07 pnacht Hash-pin Actions
2023-06-08 behdad [vector] Speed up shrink_vector for trivial destructors
2023-06-08 behdad [subset/cff] Speed up offset writing
2023-06-08 behdad [buffer-verify] Simplify a couple ifs
2023-06-08 behdad [buffer-verify] Don't consider shaping failure as error
2023-06-08 behdad [buffer-verify] Error handling
2023-06-08 qxliu fix bot
2023-06-08 qxliu [instancer] add testing code for change_tuple_variation_axis_limits()
2023-06-08 qxliu [instancer] use axis tag as hashmap key instead of axis index
2023-06-08 qxliu [instancer] add merge_tuple_variations ()
2023-06-08 behdad [vector] Fix vector error handling when allocation used to be 0
2023-06-08 behdad [graph] Remove manual destruction
2023-06-08 behdad Add fuzzing test
2023-06-08 behdad [vector] Keep allocated size when in error
2023-06-08 behdad [gsubgpos] Prevent a leak in closure
2023-06-08 behdad [map] Fix use-after-move issue
2023-06-07 behdad [cff] Tweak CFFIndex accessors again
2023-06-07 behdad [subset/cff] Fix comment
2023-06-07 behdad [subset/cff] Comment
2023-06-07 behdad [subset/cff] Comment
2023-06-07 behdad [subset/cff1] Speed up remap_sids
2023-06-07 behdad [set] Simplify a few set iterations as range loop
2023-06-07 behdad [iter] Comment
2023-06-07 behdad [iter] Add has_fast_len
2023-06-07 behdad [subset/hdmx] Remove an unintended vector copy
2023-06-07 behdad [set] Micro-optimize iteration
2023-06-07 behdad Revert "[iter] Another try at writing some for loops as range loops"
2023-06-07 behdad [subset/cff1] Fix wrong comma location!
2023-06-07 behdad [iter] Another try at writing some for loops as range loops
2023-06-07 behdad [susbet/cff] Minor remove one indirection
2023-06-07 behdad Revert "[subset/cff1] Optimize writing of consecutive names"
2023-06-07 behdad [subset/cff1] Optimize writing of consecutive names
2023-06-07 behdad Revert "[iter] Rewrite some loops as range loops"
2023-06-07 behdad [iter] Rewrite some loops as range loops
2023-06-07 behdad [map] Micro-optimize
2023-06-07 behdad [subset/cff1] Micro-optimize String writing
2023-06-07 behdad [subset/cff] Micro-optimize CFFIndex writing
2023-06-06 behdad [cff] Remove unused types
2023-06-06 behdad [cff] Remove unused method
2023-06-06 behdad [cff] Micro-optimize CFFIndex::operator[]
2023-06-06 behdad [subset/cff] Inline type only used once
2023-06-06 behdad [subset/cff1] Micro-optimize string writing
2023-06-06 behdad [subset/cff] Micro-optimize CFFIndex for empty strings
2023-06-06 behdad [subset/cff1] Speed up sid mapping
(...)
2023-02-24 behdad [wasm-api] Add buffer_contents_realloc
2023-02-24 behdad [wasm-graphite] Initial code
2023-02-23 behdad [graphite] Remove script handling
2023-02-23 behdad [wasm-sample] Make addTable take args
2023-02-23 behdad [wasm-sample] Remove unused prototype
2023-02-23 behdad [wasm-sample] Actually shape text!
2023-02-23 behdad [wasm-api] Bind buffer_set_contents
2023-02-23 simon [wasm-api] Wrap some of hb-font
2023-02-23 behdad [wasm-api] Clear structs in _free()
2023-02-23 behdad [wasm] Add HB_STRUCT_TYPE
2023-02-23 behdad [wasm-api] Add buffer-contents-free
2023-02-23 behdad [wasm-api] Make ref types actual pointers on the wasm side
2023-02-23 behdad [wasm-api] Add blob_free
2023-02-23 behdad [wasm-sample] Free blob data for now
2023-02-23 behdad [wasm] Add wasm-sample/
2023-02-23 behdad [wasm-api] Bind buffer_copy_contents
2023-02-23 behdad Revert "Fix function signature"
2023-02-23 simon Fix function signature
2023-02-23 behdad [wasm-api] Make ptr_t a pointer on the wasm side
2023-02-23 behdad [wasm-api] Add debugprint1/2/3/4
2023-02-23 behdad [wasm-api] Finish face_reference_table
2023-02-23 behdad [wasm] Return empty object when ref2obj fails
2023-02-23 behdad [wasm-api] Try to add face_reference_table
2023-02-23 behdad [wasm] Ignore API in the docs
2023-02-23 behdad [wasm] Strong typing for object references
2023-02-23 behdad [wasm-api] Rename file
2023-02-23 behdad [wasm] Add hb-wasm-api.cc
2023-02-23 behdad [wasm] Add hb-wasm-api-list.hh
2023-02-23 behdad [wasm] Make debugprint use debug API
2023-02-23 behdad [wasm] Remove the print(returnval) and use it to fail shaper
2023-02-23 simon [Docs] Pass a C string from Rust to HB
2023-02-23 simon Just printf, don't take length
2023-02-23 behdad [wasm-api] Add ref_t
2023-02-23 behdad [wasm-api] Add macros for ref handling
2023-02-23 behdad [wasm-api] Clean up debugprint
2023-02-23 behdad [wasm-api] Use i32 instead of externref in API spec
2023-02-23 behdad [wasm-api] Add HB_WASM_INTERFACE
2023-02-23 simon Only export debugprint when HB_DEBUG_WASM
2023-02-23 simon Fix debugprint format string
2023-02-23 simon Initial WASM docs and Rust example
2023-02-23 behdad [wasm-api] Implement font_get_face
2023-02-23 behdad [wasm] Bind native API
2023-02-23 behdad [wasm] Start adding wasm-api
2023-02-23 behdad [wasm] Add hb-wasm-api.h
2023-02-23 behdad [wasm] Pass font & buff to shape() function
2023-02-23 simon Add a simple callback native function
2023-02-22 behdad [wasm] Port from c_api to wasm-micro-runtime wasm_runtime API
2023-02-22 behdad [wasm] More boilerplate
2023-02-22 behdad [wasm] Add meson build option
2023-02-22 behdad [wasm] Add wasm shaper skeleton
Created with:
roll-dep src/third_party/harfbuzz-ng/src
[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ibd7d6caabfbdc1203d0b1853ad803e8b45a398e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608591
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157433}
Roll devtools-internal from 0eb0fb29630c to ff8f0b2d9dd6 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/0eb0fb29630c..ff8f0b2d9dd6
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6e8ad1b59f68bf4764a0afefcaa6eec082b6cc71..564689f7b454c35e4dd8ed23b75123cd55522f54
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ia5bff6c6b3e00860b0c175a82cf738ca48fa48b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613715
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157432}
[iOS] Fix user action when a bookmark is added
When adding user actions, there was a mistake between
* MobileBookmarkManagerAddedBookmarkUndone
* MobileBookmarkManagerBookmarkAddedUndone
This patch replaces `MobileBookmarkManagerBookmarkAddedUndone` by
`MobileBookmarkManagerAddedBookmarkUndone` in the code.
`MobileBookmarkManagerAddedBookmarkUndone` was added in actions.xml
by crrev.com/c/4275266.
related to:
https://chromium-review.googlesource.com/c/chromium/src/+/4275266/17/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
Fixed: 1454731
Change-Id: Iceaf0ec8fdffb99b20af1e7e3dac60b9da08ef23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613767
Auto-Submit: Jérôme Lebel <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157431}
COOP Inheritance: Compare origin in COOP::operator==
COOP's operator== should compare the COOP origin.
Bug: 1385827
Change-Id: Icbe44e1428850353c8273b4bbc2f336dd4e36978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604937
Auto-Submit: Jonathan Hao <[email protected]>
Commit-Queue: Jonathan Hao <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157430}
Add comment before setting COOP origin in navigation_request.cc
As pointed out in [1], setting the COOP origin with a mutable reference
was not very obvious and worth a comment.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4404116/comment/36d1e927_7d23fae3/
Bug: 1385827
Change-Id: Iebb4cf5e00ac56c548ebf41cd688f4bf2df0e0a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608426
Commit-Queue: Jonathan Hao <[email protected]>
Quick-Run: Jonathan Hao <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Auto-Submit: Jonathan Hao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157429}
[Sync] Introduce password sending specifics
Bug: 1445868
Change-Id: Ic93239e81b62aab04acfe7374dbd59c0079cc163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567646
Reviewed-by: Elias Khsheibun <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Rushan Suleymanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157428}
Split Bookmarks.Opened action by account vs local storage
Very similar to what was already done for Bookmarks.Added and
Bookmarks.FolderAdded (crrev.com/c/4536037 and crrev.com/c/4555360).
Bug: 1444386, 1447542
Change-Id: Id924b5c6edcf248a6e4cbf7be6f9cb11eeb16096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603942
Reviewed-by: Luc Nguyen <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157427}
[scroll-animations] Resolve auto to 0s for time-based animations
CL:4497757 made the initial value of animation-duration auto,
but unfortunately reporting this auto value through getComputedStyle
broke existing web content (Issue 1452130).
Hence, hence the CSSWG opted to define a resolved value for
animation-duration, which converts auto to 0s unless we have some
non-default value for animation-timeline. This CL implements that
change.
This CL also contains a second change: reset-only sub-properties
of the 'animation' shorthand are now correctly set to their
initial value, or not some repeated amount of their initial value.
This change was necessary to prevent e.g. "animation: a1, a2"
from expanding to "animation-timeline: auto, auto", which would
disable the auto-to-0s conversion behavior.
Finally, note that the computedStyleMap (Typed OM) does not return
resolved values, but computed values. Hence it must not be affected
by the auto-to-0s conversion. To ensure this, an "override"
was added for kAnimationDuration in ComputedStyleUtils::
ComputedPropertyValue.
Bug: 1452130
Change-Id: I021ac68b61b83cd96962c56dab24043a19e99c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607459
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157426}
❄ Fix flakiness of SyncConfirmationUIDialogPixelTest
This test that was centered on the sync opt-in UIs was failing
when the primary account was removed. This was caused by a race
condition with the code that enforces consistency between the
available accounts and the Gaia cookies.
This CL fixes it by using `signin::IdentityTestEnvironment`, which
is intended to be the way we manipulate the identity state for
browser tests.
Bug: 1444389
Fixed: 1446952
Change-Id: I2c5fc0eefe43d16d4683e807a97920207dad4d2f
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568064
Auto-Submit: Nicolas Dossou-gbete <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Nicolas Dossou-gbete <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157425}
dlp: Remove unnecessary storage dependency
Bug: b/287181034
Change-Id: I7983f825254fb75f25bde6e70af009118c7e1c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613866
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Luca Accorsi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157424}
Add RenderDocument flag to about:flags
Bug: 936696
Change-Id: Iab187eafacbdb864bb2f26a6ff0a58b2f3589f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607738
Reviewed-by: Fergal Daly <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Auto-Submit: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157423}
WebNN: Define XNNPACK Node for element-wise unary MLOperators
This CL implements DefineXnnNodeForElementWiseUnary() for the
element-wise unary MLOperators.
For unit tests, this CL implements ElementWiseUnaryTest of MLGraphTest
that checks the compute results of element-wise unary MLOperators.
Bug: 1273291
Change-Id: I04f0cdb7f421f5de9df90705ae7c8475ab799cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4411758
Reviewed-by: Jiewei Qian <[email protected]>
Quick-Run: Alan Kelly <[email protected]>
Commit-Queue: Bin Miao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157422}
Disable flaky cpu profiling trace events test
Bug: 1454689
Change-Id: I0e5844e37c277521e3262def4883ea62be809abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613905
Commit-Queue: Andres Olivares <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157421}
[ios] Condition hiding settings sync promo to one more flag
Behavior changes are behind flag. Hide the promo if either
of kHideSettingsSyncPromo/kReplaceSyncPromosWithSignInPromos is
enabled. Rationale: kHideSettingsSyncPromo will roll out separately
first, but folks testing kReplaceSyncPromosWithSignInPromos shouldn't
see the promo either. OR-ing the flags is more convenient than exposing
one more entry in chrome://flags for something minor.
Bug: 1450472
Change-Id: I853be8b11541a2576b5c0a3079dddeb2e096dd9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608307
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157420}
AW UMA: extend LoadUrl.UrlScheme
No change to logic. This extends teh Android.WebView.LoadUrl.UrlScheme
histogram. This histogram is still being used as a tracing trigger.
Adding oksamyt@ as an owner for the tracing use case.
Fixed: 1421865
Test: N/A
Change-Id: Id7af3daefaca31af46e5612939dc1d991e367493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606129
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Auto-Submit: Nate Fischer <[email protected]>
Commit-Queue: Michael van Ouwerkerk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157419}
SAA: Hide irrelevant exceptions in PageInfo
Exceptions related to first-party sets and regular first-party storage
shouldn't be displayed in PageInfo.
Bug: 1433644
Change-Id: Iec22c62bf5588661b1800c4e4651618ee8caedcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608074
Reviewed-by: Filipa Senra <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157418}
[Sheriff] Disable ContentAnalysisPrintBrowserTest.SystemPrintFromPrintPreview
The test is failing on 10% of the UBSan runs.
Bug: 1454426
Change-Id: I3b558942d6ab8dc260081e6dde8cf5de6af7b79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613865
Auto-Submit: Christoph Schwering <[email protected]>
Owners-Override: Christoph Schwering <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157417}
Roll Dawn from b4d3f6811828 to a0e679b77011 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/b4d3f6811828..a0e679b77011
2023-06-14 [email protected] Roll vulkan-deps from ca4471bb3db3 to 5b7ee750e5e8 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I2cc9e34926ff775e8715788132afb42b80232af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613707
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157416}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686711525-a02dbfcd450a654bc397a1e40a04ce5a4c65346e.profdata to chrome-win64-main-1686721732-3842ab4df45e821a4ff943608322f109cf884f6f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I35aa52bc57f187965f3305028cbe4ebe86655422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612181
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157415}
Avoid dangling ref to temporary in PrivateNetworkDeviceChooserController
The PrivateNetworkDeviceChooserController constructor takes an
ChromePrivateNetworkDeviceChooser::EventHandler argument which is a
base::RepeatingCallback. Unfortunately, this is being taken by
reference but callers are supplying std::moved() temporaries,
which do not live beyond the constructor call. Instead, pass
by value and move all the way down.
This can be detected under unit_test when running with the GN
arg use_asan_unowned_ptr=true.
Bug: 1401495
Change-Id: I89aac8dcb25ee29c67d30e66e3724098f0fe23a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611472
Reviewed-by: Yifan Luo <[email protected]>
Commit-Queue: Yifan Luo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157414}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686721732-a5e984bcd4556ef21a3bc5be5f3976f118810b76.profdata to chrome-mac-arm-main-1686729470-820e08da085fa909a81b980f81e69b2421aa3b26.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ibe5e75c8b110fcaa9b9645ce8c8d93626e8d65d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611831
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157413}
[installer] Improve sanitation when determining the install path
We sometimes see crashes where the installer is operating on an empty or
bad target directory. This CL adds more sanitation to install path
determination and more test coverage.
Bug: 1406460
Change-Id: I0f9e7cd7812a5a860632a15357074af46ec20b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604104
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157412}
Simplify 'offset-anchor' computation/application
Expanding the two cases for 'offset-anchor' yields:
(os = origin_shift_{x,y}; ap = anchor_point; p = computed position)
anchor auto: ap = origin, os = (0, 0)
translation = p - ap + os = p - origin + (0, 0) = p - origin
anchor <position>: ap = <resolved pos>, os = ap - origin
translation = p - ap + os = p - ap + (ap - origin) = p - origin
which means that the translation is independent of the anchor point,
and thus the application of 'offset-anchor' can be simplified to a
simple shift of the origin after the main offset transform has been
computed.
Change-Id: I817ff7add65ae5221a5bba9d26a504361691325c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604076
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Daniil Sakhapov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157411}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686679195-ac74d94d2c6336a23baa367010b37789b8e53e48.profdata to chrome-mac-main-1686721732-a92d860560486a5a1e6bb5a70947dacef509b22d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8e28c550cdadceb48a474af9321084595faac88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611884
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157410}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686714401-49d2bcd87064a5d7429546cca1936d99ff78da98.profdata to chrome-mac-arm-main-1686721732-a5e984bcd4556ef21a3bc5be5f3976f118810b76.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I83f171689684427ce1ef283f7b35500c22786a25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613665
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157409}
Roll devtools-internal from 5f55a210fa42 to 0eb0fb29630c (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/5f55a210fa42..0eb0fb29630c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I1ff653a3ee38233b13f9a93f1a21641a861b8525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612600
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157408}
Cleanup: Delete os_sync_util::MigrateOsSyncPreferences()
This migration has been running for about a year, so it can be cleaned
up now.
OBSOLETE_HISTOGRAM[ChromeOS.Sync.PreferencesMigrated]=Migration completed as of 2023-06.
Bug: 1249845
Change-Id: If083895da7f63f6266e824bea2f0bccf357e509e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604314
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157407}
[text-wrap-pretty] Add `NGLeadingFloats`
This patch adds the `NGLeadingFloats` struct, which represents
already handled leading floats.
In order to support floats in `NGScoreLineBreaker`, these two
data need to be passed through multilple functions. This
struct helps simplifying it and reducing the number of
arguments.
This patch has no behavior changes.
Bug: 1432798
Change-Id: Id19a306948e8555d23923552aaf00927efca26a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610270
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157406}
[UPMLocalPwd] Trigger migration sheet from the select pwd sheet
The migration warning sheet is triggered to be shown when the user
taps on a suggestion to fill (username or password) and after the
suggestion has been sent for filling. This is done to ensure that the warning doesn't interrupt the filling flow in any way.
Bug: 1439761
Change-Id: Ia0b577a25de764f499e8f626f10a80290d7883cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604410
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157405}
Add GMB based fake capturer on windows
Bug: 1438554
Change-Id: I96af83e10ae023beccdb00f1de2ff60e3222ae1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567551
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Rafael Cintron <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157404}
Add histogram for OS-specific audio output delay
Since delay is logged many times per second and on a performance-
critical path, we use the macros instead of the helper functions. See
https://chromium.googlesource.com/chromium/src/+/master/tools/metrics/histograms/README.md#coding-emitting-to-histograms
Change-Id: I477c7b9eafee51f1f10ea3eff852f05334365d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608126
Reviewed-by: Olga Sharonova <[email protected]>
Reviewed-by: Johannes Kron <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157403}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686700798-35913de13d5970f166252b3cd6a37d6724a6e7a1.profdata to chrome-linux-main-1686721732-9194d37899dfb02f3a7676fd67b2195141cddd34.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ifba3ac09a05fc8dd1f13005c193a4db6afe4a81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612184
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157402}
dlp: Simplify ScopedFileAccessDelegate client code
In the simplest scenarios users of ScopedFileAccessDelegate perform the
same action when a ScopedFileAccessDelegate instance exists or not.
This CL replaces ScopedFileAccessDelegate::RequestFilesAccessForSystem
with an helper function file_access::RequestFilesAccessForSystem
that internally checks the existence of a ScopedFileAccessDelegate
instance.
If the instance exists,
ScopedFileAccessDelegate::RequestFilesAccessForSystem is called.
Otherwise, a ScopedFileAccess::Allowed object is forwarded to the
callback in input.
Bug: b/286505315
Change-Id: I2d51061aabc32494e4d38ed4a6ad7f39c24eaa91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604355
Reviewed-by: Daniel Brinkers <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Luca Accorsi <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157401}
[signin] Use const and raw_ref in ProcessDiceHeaderDelegateImpl
This is a code cleanup with no functional change.
Change-Id: I31d664ce24a6bc30fe20dc36a7e063132fcd519e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608427
Reviewed-by: Nicolas Dossou-gbete <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157400}
Re-enable PasswordCheckViewTest and fix flakiness
Add a timeout to verifies since it may take some time for chrome to
actually fire the callbacks. This should hopefully make the test less
flakey.
Bug: 1450538
Change-Id: I4f4cc155fe6a2fdecfb313061b2eae24a1346d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611505
Auto-Submit: Mohamed Heikal <[email protected]>
Commit-Queue: Friedrich Horschig <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157399}
Revert "Update V8 to version 11.6.142."
This reverts commit 303e0e9d54eb5a0b1891c5dd31c0bb31db8035e9.
Reason for revert: Maybe cause https://crbug.com/1454701
Original change's description:
> Update V8 to version 11.6.142.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/89367f3a..a6a1f711
>
> Please follow these instructions for assigning/CC'ing issues:
> https://v8.dev/docs/triage-issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
>
> [email protected],[email protected],[email protected]
>
> Change-Id: Ifadb81165f9248845121eea0244789ccd1993f0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612506
> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1157340}
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
No-Presubmit: true
Change-Id: Ic60bb5c9a9132112f084fa19499b35ea04207132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613566
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157398}
[WebUI] Enable trusted types CSP for GuestOSInstallerUI
TEST= Naviated to chrome://guest-os-installer and verified it worked.
Bug: 1400799
Change-Id: Iec85e2fbbb611e9c3ba0ad1e2c23d218bf005bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600473
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157397}
[FilesF2] Add one integration test for the new directory tree
Bug: b:272125628
Change-Id: I90b55f3ba84a7c93f1c9daf2beb440c485c8c332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600791
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157396}
[Frameworks roll] Roll to 540182398 piper revision
Change-Id: I7b18b8d2e4d91f76bc4a215d810594355e554b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613726
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157395}
CCA: Improve documents in jsdoc annotations
This CL improves documents such as correcting typos in jsdoc annotations
related to CCA under ash/webui/camera_app_ui/resources/js/models/.
Bug: b:273315158
Test: $ cca.py lint
Change-Id: I5d955935c0a45b2a9056606c16cda716eb317a3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612226
Reviewed-by: Pi-Hsun Shih <[email protected]>
Commit-Queue: Dorah Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157394}
DTC-BYOD: Add `PROFILE_DEVICE_TRUST_USER_CERTIFICATE` cert type
Add a new remote attestation certificate type
`PROFILE_DEVICE_TRUST_USER_CERTIFICATE` which is intended for using
the Device Trust Connector on unmanaged devices. For more context,
see go/remote-attestation-unmanaged-devices-dd
Bug: b:277706927
Change-Id: I516b7b4affb420dfb868b04db738b8af57f98a4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608301
Reviewed-by: Denis Kuznetsov <[email protected]>
Reviewed-by: Yves Arrouye <[email protected]>
Commit-Queue: Leon Masopust <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157393}
Roll gn from 1cd35c1b7224 to 4bd1a77e6795
https://gn.googlesource.com/gn.git/+log/1cd35c1b7224..4bd1a77e6795
2023-06-09 [email protected] Escape `+` characters in rule names
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I6cb518f89991453931d69bcfeb4f4933172dc3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611881
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157392}
CCA: Improve documents in jsdoc annotations
This CL improves documents such as correcting typos in jsdoc annotation
related to CCA under ash/webui/camera_app_ui/resources/js/mojo/.
Bug: b:273315158
Test: $ cca.py lint
Change-Id: I84ac2d88b8e43fcb9d694f1c131a70cc71a55650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604703
Commit-Queue: Dorah Kim <[email protected]>
Reviewed-by: Pi-Hsun Shih <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157391}
Gardening: disable Search/FilesAppBrowserTest.Test/searchTrashedFiles_SearchV2
BUG: b/287169303
Change-Id: I605e8bc83c96904c540a6d2bdb6092959e09f42d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612431
Auto-Submit: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Quick-Run: Lingqi Chi <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157390}
Prolong expiry of Media.WebmMuxer.DidAdjustTimestamp
Fixed: 1445630, 1445631, 1445629
Change-Id: I07d1f131b07a80d927be40e5ba03d9482f808267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604364
Reviewed-by: Johannes Kron <[email protected]>
Commit-Queue: Markus Handell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157389}
Roll WebRTC from 7d77e247f2f4 to 3cf60bed1d3c (1 revision)
https://webrtc.googlesource.com/src.git/+log/7d77e247f2f4..3cf60bed1d3c
2023-06-14 [email protected] Update WebRTC code version (2023-06-14T04:02:08).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I653f3142da3bb3541074124a2f694cbc2ecd4a46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612179
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157388}
CCA: Add type definition for ffmpeg.js
Since we are removing allowJs from tsconfig.json, we have to declare
ffmpeg.js to prevent tsc error. So, this CL adds ffmpeg.d.ts to define
the module exported from ffmpeg.js to be of type
EmscriptenModuleFactory, which is defined from @types/emscripten.
Bug: b:269971867
Test: cca tsc $board, tast run $DUT camera.CCAUIRecordVideo
Change-Id: Ib84e081c51ba68a00024ddfb86eb173c9344d86f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600557
Reviewed-by: Pi-Hsun Shih <[email protected]>
Commit-Queue: Kam Kwankajornkiet <[email protected]>
Reviewed-by: Chu-Hsuan Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157387}
[infra] Add linux-chromeos-build-perf/linux-chromeos-build-perf-siso builders
These builders simulate builds on linux-chromeos-rel, which is often the slowest builder at compile step. The build metrics will be tracked on http://dashboards/chrome_browser_build_team_metrics.
Change-Id: I1c2cd84f3d19f287d79889118ea6cb005c0ec554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612865
Commit-Queue: Takuto Ikuta <[email protected]>
Auto-Submit: Junji Watanabe <[email protected]>
Reviewed-by: Fumitoshi Ukai <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157386}
Roll ANGLE from ce7b9602aa0f to 3a3a3c655a96 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/ce7b9602aa0f..3a3a3c655a96
2023-06-14 [email protected] Remove override test31Context.cpp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ifc7b3bc53a8a585f72f6c6fd6d75e92b3525e6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612049
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157385}
[//gpu] Restrict decoders' and textures' GLImage usage to Ozone
After many refactorings, the remaining code/APIs in the GLES2 command
decoders and validating/passthrough textures that operate on GLImage are
exercised only on Ozone. This CL restricts these classes to defining
these APIs only on Ozone.
Bug: 1324249
Change-Id: Idfbd6516476c6f10fb32c4b15662a567435d78ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607447
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157384}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5831.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: I4de29a7effe4af832d40190649a2be9f304f895c
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613525
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157383}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I69aa550d44028f5ff41376500ec5c5196b0d2da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611159
Auto-Submit: Sean Kau <[email protected]>
Reviewed-by: Xiaodan Zhu <[email protected]>
Commit-Queue: Xiaodan Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157382}
dlp: Timeout when opening Files App for dialogs
Adds a few seconds timeout after which we stop waiting for the Files
App to open, and just open a FilesPolicyDialog as a system modal (i.e.
without the parent).
[email protected]
Fixed: b:282663949
Change-Id: Iaa24f67bc334e22d12d7fa58a60e5b0a7bcd1437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597280
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157381}
[WebUI] Enable trusted types CSP for PrintManagementUI
TEST= Naviated to chrome://print-management and verified it worked.
Bug: 1400799
Change-Id: I62b40e1759db93fa02bf08e2a8432b1474e6fce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583924
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157380}
Gardening: disable WelcomeTourDialogPixelTest.Appearance
This test is flaky.
Bug: 1454700
Change-Id: I155a54a247e0a10efb5474210bca570c4d02bcab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613586
Commit-Queue: Takashi Sakamoto <[email protected]>
Auto-Submit: Lingqi Chi <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Quick-Run: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157379}
media: Pardon PIPELINE_ERROR_HARDWARE_CONTEXT_RESET in PipelineImpl
Currently when PIPELINE_ERROR_HARDWARE_CONTEXT_RESET happens during a
media playback, the media pipeline will be restarted, so the downstream
components (e.g. MediaFoundationRenderer) can recover from the issue by
restarting from a clean state.
However, PipelineImpl treats PIPELINE_ERROR_HARDWARE_CONTEXT_RESET as a
error, so that if PIPELINE_ERROR_HARDWARE_CONTEXT_RESET happens multiple
times, the media pipeline will assume that it's in an error state, and
refuse to propagate the new PIPELINE_ERROR_HARDWARE_CONTEXT_RESET error
to WebMediaPlayerImpl, causing the media pipeline to hang.
This CL fixes the bug by treating PIPELINE_ERROR_HARDWARE_CONTEXT_RESET
and DEMUXER_ERROR_DETECTED_HLS differently. They are not fatal errors
but instead just signals for to be sent to WebMediaPlayerImpl.
Bug: 1454226
Test: Added new unit tests to cover the bug.
Change-Id: I8f5450a489c66f659e51f12335cb2674a07c4c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608451
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Xiaohan Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157378}
[WebUI] Enable trusted types CSP for FirmwareUpdateAppUI
TEST= Naviated to chrome://accessory-update and verified it worked.
Bug: 1400799
Change-Id: I36ef9bfb2b88cfc53bd30789b75e7b53b81e4a4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4564815
Commit-Queue: Junguo (Jun) W. <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157377}
[wpt-exporter] Do not export `PRESUBMIT.py` files
This change stops the exporter from exporting `PRESUBMIT.py` files,
which are Chromium-only. web-platform-tests/wpt#40539 retroactively
deletes one such accidentally exported file.
Bug: None
Change-Id: Ifbea39d61abadacf4d2e7bfba4db3731bc57f970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613305
Auto-Submit: Jonathan Lee <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157376}
Revert "Enable the Release notes notification for M116."
This reverts commit 3f05a64db5230828dd1350271130e4896c3b91e8.
Reason for revert: Next content update will be in M117, as per b/286137911.
Original change's description:
> Enable the Release notes notification for M116.
>
> Bug: b/275585925
> Change-Id: I0b0c94e9c92f7fe203d15d519dd7141e8d7ffc79
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4561107
> Reviewed-by: Trent Apted <[email protected]>
> Commit-Queue: Callistus Tan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1148436}
Bug: b/275585925
Change-Id: Id2818e03ccf820bd2affaca08424f3cf263efc24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613086
Commit-Queue: Callistus Tan <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157375}
Import wpt@dde4c3a9c98583b7b6ab260ffaf8f8a00debbac3
Using wpt-import in Chromium 690ddbb76e86f04aab1fd8d3b336fb75997cdaf7.
With Chromium commits locally applied on WPT:
4f5b9a5ffd "Prerendering: add document rules smoke tests"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I4df59b769e29ac0c6ccef28698e9f898c056f1b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613125
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157374}
Fix null pointer dereference in some CrOS unit tests
crrev.com/c/4602520 introduced a bug that is causing null pointer
dereference in some CrOS unit tests, an example failing build:
https://ci.chromium.org/ui/p/chromeos/builders/cherry/cherry-cq/b8778501190973227009
Bug: b:286986971
Test: unit_tests
Change-Id: Iad08c22aa84d48b0b2e262a51143b56da36c2f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609826
Auto-Submit: Yi Xie <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Yi Xie <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157373}
WebUI: Add Typescript @types package for Emscripten
Specifically, this adds @types/emscripten as dependency.
This increases the uncompressed node_modules size by about 16.54k.
These definitions will be used by Camera app to define FFmpeg module
compiled by Emscripten. The module is used for video processing.
Bug: b:269971867
Test: CQ
Change-Id: I5ec783be3feed82629f0d2f0b475cfc588e72025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600729
Commit-Queue: Kam Kwankajornkiet <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157372}
[text-wrap-pretty] Support multiple fonts in `NGLineWidths`
This patch extends `NGLineWidths` to support multiple fonts,
as long as their metrics don't make the line heights taller.
The `NGLineWidths` was added in crrev.comc/c/4603613.
This patch has no behavior changes as all changes are under a
runtime flag.
Bug: 1432798
Change-Id: Ibd98de7ee44cf30ddfa7212e41bc56f2fc86edbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604341
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157371}
Update V8 to version 11.6.143.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a6a1f711..060d33cd
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ia3d7c0d88e2235887d0c46e6fd650bad74c7f231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612186
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157370}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686700798-046d0773a4d6a39960a41e2c32b5b77a2c5ffd9b.profdata to chrome-win32-main-1686711525-32dc40b17b5db2bab91c6ecbc661a4e664f9cf8c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I27b5f434ad053064262733ebd7991de19143b874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613205
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157369}
Update BrowserManager tests for Lacros SxS/Primary removal.
Use LacrosOnly mode for testing.
Along with that, for KeepAlive testing, explicitly disable
default KeepAlive set and lacros auto-starting on initialization.
BUG=1448575
TEST=Tryjob
Change-Id: Idd09f5ac5511a1f0a830210a88522a0f528bc1e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610184
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Georg Neis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157368}
Roll Fuchsia Internal Images from 13.20230613.3.1 to 13.20230614.0.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I24537b8eaf422de44efb3fd78c6e5ba85d929441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612173
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157367}
Revert "feedback: re-enable OSFeedbackBrowserTest"
This reverts commit b333b06657154358bfafa9a9034226471119b972.
Reason for revert: The enabled test is flaky
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2Fchrome%2Ftest%3Abrowser_tests%2FOSFeedbackBrowserTest.All?q=VHASH%3A1c8ecdb364452a5d
Original change's description:
> feedback: re-enable OSFeedbackBrowserTest
>
> The OSFeedbackBrowserTest was flaky. I could not reproduce it.
>
> One test was fixed in https://crrev.com/c/4540801.
>
> Reenable the OSFeedbackBrowserTest to see whether it is still flaky
> and go from there. In case the tests fail, please add instructions of how to reproduce it in the bug.
>
> Bug: 1401615
> Change-Id: I30eff753ad5646db2c69303487b3a7727d79a47b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591486
> Commit-Queue: Xiangdong Kong <[email protected]>
> Reviewed-by: Jimmy Gong <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1154038}
Bug: 1401615
Change-Id: I029e9b1ab99687e120d63458af7813e9653343ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612407
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157366}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686700798-0ee8c84c50aab2a5adac35e9428536d60587107b.profdata to chrome-win64-main-1686711525-a02dbfcd450a654bc397a1e40a04ce5a4c65346e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I55c05a461ed25044bafc9b9d919fb79f25d9195d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611861
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157365}
BulkPinning: Add histogram FileBrowser.GoogleDrive.BulkPinning.Error
BUG=b:286981785
Change-Id: Ib9b5082a2dfd0c8c3ec121793e46f7647018cdd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607968
Auto-Submit: François Degros <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157364}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686707838-bedbc2e0cab0bdc0cc727faab1241b30ebef43c9.profdata to chrome-mac-arm-main-1686714401-49d2bcd87064a5d7429546cca1936d99ff78da98.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I0626d26f43583ce2c2e7aa5404729fc4dd849a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612176
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157363}
Roll vulkan-deps from eb20b5bd5634 to 883f368cdad6 (24 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/eb20b5bd5634..883f368cdad6
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a6662c53ce..72713baf74
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/030d0be28c..2d3a152081
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9c66587d14..40dde04ca2
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/605dc6d3e7..cb71b646f1
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c97930ba36..88d70047fb
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/19b76e79f7..949cc246b4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I5af21d7a600dbd667eb88e9b84215580ce277694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610171
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157362}
Deflake indexeddb/delete-entry.js test.
This is an alternative to using render coordinator, which would have make other
layout tests more cumbersone. As the flakiness is caused by extra
updates of the same view, we sniff on specific views instead of
prototype to make that both view were updated, no one view updated
twice.
Bug: 1453272
Change-Id: Iab55c3d30ab129975fe6bb5efe024befdc05778e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610285
Reviewed-by: Jaroslav Sevcik <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157361}
[test] Windows Apache config - add more workers threads
In the logs of flaky inspector protocol web tests we see the following
message:
"Server ran out of threads to serve requests. Consider raising the ThreadsPerChild setting"
This patch doubles the number of worker threads on Windows.
On try jobs, this seems to decrease the number of flaky tests
by 30-50% (326 to 164 for the win10.20h2-blink-rel job,
465 to 309 for the win11-blink-rel job).
Bug: chromium:1453386
Change-Id: I8aa34c8554e2d366c9daff43c32394ffbe2c526b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609129
Commit-Queue: Jaroslav Sevcik <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157360}
[Files]: Use XfBreadcrumb in place of XfPathDisplayElement.
Switches search container to use XfBreadcrumb element rather than
XfPathDisplayElement. This reduces the complecity of the files code and
allows users to click on the path of selected elements to switch the
files app to a directory on the path of the selected file.
Bug: b:281806574
Change-Id: Ic4111a33de4b2610d3e354d145bc014e94d28439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607987
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Bo Majewski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157359}
Remove LacrosPrimaryAshSyncTest.
LacrosPrimary mode is going to be removed.
This is the preparation.
BUG=1448575
TEST=Tryjob
Change-Id: I6db7d9a8b345f86abd843b57a08f8482f35cd2cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610182
Reviewed-by: Maksim Moskvitin <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157358}
[SuperSize] Caspian: Add symbol node ID and ancestry query.
The "#focus=..." feature specifies a node in the Symbol Tree. Some means
for this are:
1. Unique full path to the node.
2. Abridged path to optimize (1).
3. A unique ID.
We're going with (3) to keep the URL short, and to prevent complications
from requiring a unique node path. The choice will lead to modest memory
increase and Viewer-Caspian overhead, and some opacity. More choices on
implementing the ID:
3a. Enumerate nodes with whole numbers, in arbitrary order.
3b. Shorten (3a) with encoded string.
3c. Use a hash computed from node data.
We're going with (3a) for simplicity: A 32-bit int is short enough;
hashing is overkill for the UI feature, and maybe untenable.
Note that the ID is for UI only, and does not affect .size / .sizediff
formats. Changes in ID scheme won't affect regular usage, but invalidate
archived URLs pointing to specific symbol nodes.
This CL updates Caspian to compute symbol node IDs. Assignment scheme
prioritizes simplicity: Use a static |next_id| counter in TreeBuilder,
then assign and increment in the CTOR. This allows us to elide tree
building complexities, but requires deterministic symbol node creation
order.
Symbol node IDs are sent from Caspian to the Viewer, and stored as a
field in node data so "#focus=..." can be written.
A challenge in the Viewer is that it dynamically fetches symbol node
data from Caspian on expansion. To guide node expansion to a symbol
node, we also add QueryAncestryById() to the Caspian API.
Caspian Details:
* TreeNode: Add member const |id| to be injected at CTOR (made private);
export |id| to JSON.
* Add TreeNodeFactory: Friend to TreeNode; stores counter |next_id|;
has Make() to instantiate TreeNode while passing (post-incremented)
|next_id|.
* TreeBuilder:
* Change |root_| from TreeNode to std::unique_ptr<TreeNode>.
* Add TreeNodeFactory |tree_node_factory_|; replace direct TreeNode
instantiation with |tree_node_factory_.Make()| usage.
* Note: TreeBuilder is instantiated on tree rebuild. This allows
node ID (tracked by TreeNodeFactory) gets properly reset.
* Add helper FindNodeById(), which performs stack-based DFS tree walk
to find a symbol node, given the ID. The trade off of worth time
(O(n) scan) for memory (not storing ID-to-node map) is justified
since this is only called once on initialization (see below).
* Add GetAncestryById(), which calls FindNodeById() to find a queried
node by ID, then computes and returns the ID path from symbol tree
root to the node (inclusive) as Json::Value array of IDs.
* Export QueryAncestryById(), returning the result as a JSON given by
{ancestorIds: [...]}.
Viewer Details:
* Update type TreeNode to include |id|.
* Add type QueryAncestryResults.
* Add WASM interface for QueryAncestryById(), called via worker
interface queryAncestryById().
Bug: 1001769
Change-Id: I3e9b2700fd61a0bac815f9fb92dd4330e0944d8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611287
Commit-Queue: Samuel Huang <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157357}
BrowserManager: Declare EnvironmentProvider before dependent class
This CL moves EnvironmentProvider declaration inside BrowserManager
above TestMojoConnectionManager to guarantee `environment_provider_` to
be deleted after `test_mojo_connection_manager_` is deleted which takes
`environment_provider_` as a reference.
This aims to fix Dangling Ptr in TestMojoConnectionManager.
TestMojoConnectionManager is also constructed in unittest called
test_mojo_connection_manager_unittest.cc but it looks correctly
destructing raw_ptr in order.
Bug: 1454360
Change-Id: I073935efc29d54da1bedf18d49ccf47429b5ec9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607737
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Eriko Kurimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157356}
language_packs: Remove deprecated histogram
Bug: b:231288152
Change-Id: I97c905752517ee3b78c69793557dc7acaa70ba20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612947
Reviewed-by: Tim Sergeant <[email protected]>
Commit-Queue: Claudio M <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157355}
Revert "Prerendering: add document rules smoke tests"
This reverts commit 4f5b9a5ffd4104059438fb24d72e87d186d11c35.
Reason for revert: The newly added tests are flaky on many bots.
(timeout)
Original change's description:
> Prerendering: add document rules smoke tests
>
> As the inline comment notes, parameterizing the more-comprehensive
> prefetch tests would be ideal. But for now, let's get some basic
> coverage in place.
>
> Bug: 1371522
> Change-Id: I603ce286a2fb9e0ea3ce465ac223c8cc61bce010
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607733
> Commit-Queue: Domenic Denicola <[email protected]>
> Reviewed-by: Adithya Srinivasan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157315}
Bug: 1371522
Change-Id: I15c692b84dbfa4332659e0097a6e5470eab49603
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612886
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157354}
[FilesF2] Swap the directory tree to the new implementation
Bug: b:272125579
Change-Id: I18529d29e12909da197582ab0036663d8a5c6720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583191
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157353}
[Battery Saver] Power Setting UI
This change is the initial (incomplete) implementation of the settings
UI for ChromeOS's battery saver feature.
Everything is behind a feature+flag, so regular users won't see the
incomplete (and not internationalized) UI. But this makes it available
for teamfood and fishfood.
Battery saver is a mode that trades reduced performance for increased
battery life.
The toggle should appear in settings when the feature is enabled and the
device has a battery.
Battery saver can not be enabled when on AC power, so the toggle should
be ghosted when charging.
Screenshot: https://screenshot.googleplex.com/hdAxcqGHLETwiLC
UI design: go/cros-bsm-mocks
BUG=b:278957245
TEST=Locally, reenable OSSettingsDevicePageTest and run it.
Change-Id: Icae4bd1aac80e6cf135aec2c9e842cb32859ef5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4318204
Reviewed-by: Wes Okuhara <[email protected]>
Commit-Queue: Charles William Dick <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157352}
gardening: disable NoCancelSearchPreloadUnifiedFallbackBrowserTest.
OpenPrefetchedResponseInBackgroundedTab on Chromeos asan
Bug: 1454675
Change-Id: Ieff48b97a12a3fefb04e24ed0773437bb8e8ad99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612747
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Auto-Submit: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157351}
Roll clank/internal/apps from 12d53263b4ee to cb3287753146 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/12d53263b4ee..cb3287753146
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1433407
Tbr:
No-Try: true
Change-Id: I5beb91f9bc3ef45fe28fa2785a4a9f6292ed76c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612210
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157350}
App Service: Revert default link capturing in browser for managed users
The new default link capturing behavior for ARC, which was enabled by
default in M106, causes issues for certain enterprise apps which utilize
link capturing in their authentication flows.
This CL disables the feature for all managed users, until we can either
add a policy or a workaround to support this case.
Bug: 1454381, b/280056133
Change-Id: Ica4d6faa04d47da40eb8ec72907e92ac6f2031ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612726
Reviewed-by: Maggie Cai <[email protected]>
Commit-Queue: Tim Sergeant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157349}
[keyboard-alt]: Add kNone to SixPackShortcutModifier enum
Bug: b/279503977
Change-Id: I407c3149ab1b52cac6eef11cc0f93a99fc993312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606558
Reviewed-by: David Padlipsky <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Michael Checo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157348}
Disable benchmark stories that keep failing
Stories to be disabled:
Speedometer2 for lacros-eve
v8.browsing_mobile-future/browse:media:tiktok_infinite_scroll:2021 for
android-go
Bug: 1452148
Change-Id: Ide91a18eacaea0a375c591727271aa1ed5a208a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610657
Commit-Queue: Max Li <[email protected]>
Reviewed-by: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157347}
Roll Website from 577051d39146 to 8baa1dd892d5 (1 revision)
https://chromium.googlesource.com/website.git/+log/577051d39146..8baa1dd892d5
2023-06-13 [email protected] Mention Chrome for Testing as a way to get versioned binaries
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ic65a211f3909ac7081efda5c7741e6f49deb60ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612208
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157346}
Tab Search: GM3 update part 1
Update color font size and font weight for GM3 specs.
Also add an icon container around the favicon.
Screenshot with GM3 disabled:https://screenshot.googleplex.com/7mnDRZJpQrZeZd6
Screenshot with GM3 enabled:https://screenshot.googleplex.com/mwDcxBsN2KFyykb
enabled dark theme:https://screenshot.googleplex.com/9TDi3DewbqvphyF
Specs: https://www.figma.com/file/5xWeeSmVQTd4yW3s6aFJ1f/CDDS-UX%2FEng-Spec?type=design&node-id=4592-189100&t=rEtsw5CaZOun3et7-0
Change-Id: I6174d52d8febaf8d171a184675bebf316aff8ee9
Bug: 1422116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606054
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Yuheng Huang <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157345}
Import wpt@33e834fef9ca208681d78e7c827e16ff027c6e5a
Using wpt-import in Chromium 0fbd0c8684325bdb7f760bf090023b230313c024.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/motion
NOAUTOREVERT=true
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I4dbe8acdca4de8725edeeb9cd99b88ae0d5e5f44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611309
Commit-Queue: Nihar Damarasingu <[email protected]>
Reviewed-by: Jonathan Lee <[email protected]>
Reviewed-by: Nihar Damarasingu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157344}
Roll Dawn from 48a39ff9615d to b4d3f6811828 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/48a39ff9615d..b4d3f6811828
2023-06-14 [email protected] Roll ANGLE from 057b8b61b2f2 to 14339812a9db (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Idd338c458c181ef45c9309e5c043c9bde3d661c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611990
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157343}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686689697-1d819550ace18908a2a18930f2933c285cef2359.profdata to chrome-win32-main-1686700798-046d0773a4d6a39960a41e2c32b5b77a2c5ffd9b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I8fa917e594ff90fbfc6f71c31c6ce0f44a08f51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612546
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157342}
gardening: disable ServiceWorkerLifetimeStrongKeepaliveBrowsertest.
ServiceWorkersDoNotTimeOutWithPolicy on chromeos instead
the target os of linux-chromeos-rel seems to be chromeos instead of
linux according to gn.args
Bug: 1454339
Change-Id: Ifbdc24b0eb21bd3a99be11203468db012932ce01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612406
Reviewed-by: Takashi Sakamoto <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157341}
Update V8 to version 11.6.142.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/89367f3a..a6a1f711
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ifadb81165f9248845121eea0244789ccd1993f0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612506
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157340}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686700798-3839fafefa39d2ede8b01728d8bd5f115e4cc627.profdata to chrome-mac-arm-main-1686707838-bedbc2e0cab0bdc0cc727faab1241b30ebef43c9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I527504d558afa2a1d0359c857c2ea160373c7f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611992
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157339}
Updating trunk VERSION from 5831.0 to 5832.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: Ib2b31746d5c8ea436b6ec05da5e98e9076ca6b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612786
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157338}
Remove deprecated calls to ash::ProfileHelper in BrowserManager
This change removes deprecated calls to
- ash::ProfileHelper::Get()->GetUserIdHashFromProfile
- ash::ProfileHelper::Get()->GetProfileByUser
and substitutes them with the respective functions in
ash::BrowserContextHelper.
BUG=1325210
TEST=Try job.
Change-Id: I54bfb7e13b41cbd0f0b77139f41a0a6ce9a33208
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603689
Commit-Queue: Andrea Orru <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157337}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686689697-848785595114f81b32bcdb3ecd329b0719fd8d85.profdata to chrome-win64-main-1686700798-0ee8c84c50aab2a5adac35e9428536d60587107b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I5ff3ead547947d352a0d3ac6ebf38c9b4f5e83a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611869
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157336}
Fix crash when try to start a presentation request (1-UA) while tab mirroring from the same tab
Bug: 1448645
Change-Id: I92284649431e11d33ac6f8fd58cf8e42bb4766df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599811
Reviewed-by: Tommy Steimel <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Auto-Submit: Ahmed Moussa <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157335}
[FilesF2] Add menu/rename support for directory tree container
Demo: http://go/scrcast/NTY1MTQ2Njg0NTk0NTg1NnwyNTU0YTM5MS01Nw
Bug: b:272125579
Change-Id: Ib834ed88b9410f76f76b489f7b0dd7a49054d27c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600709
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157334}
Update fieldtrial_testing_config for ArcVmmSwap
This CL update the testing config to the latest setting. Mainly for add
ghost window feature flag.
Bug: b:286791345
Change-Id: I78cf0016d27b52e2584c4262c2c7b985595dad2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610340
Commit-Queue: Shengsong Tan <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157333}
[dPWA] Fix ShortcutMenuSubManager crashes
This CL contains logic that should fix the crashes in the sub manager
for Shortcut menu handling and also contains tests that should fail
should the crash is ever hit.
Investigation and context is in go/shortcut_menu_crash_investigation
Bug: 1417955
Change-Id: I4d88c7a9a1b1958ae31c92eced733f3f401deed0
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609760
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Dibyajyoti Pal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157332}
Add time tick event
Bug: b:285157981
Test: browser_tests --gtest_filter=*ScalableIph*
Change-Id: Ic72dab090a9e3427bb91e6b7f00f3798e04a4195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611345
Quick-Run: Yuki Awano <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157331}
Revert "Disable fixed point for Opus on Apple silicon Mac"
This reverts commit e99bef12be35b6f62dcc41944dd2d575d2fff075.
Reason for revert: causing test failure
https://bugs.chromium.org/p/chromium/issues/detail?id=1454671
Original change's description:
> Disable fixed point for Opus on Apple silicon Mac
>
> Bug: 1451254
> Change-Id: I20987deb32c95b01fa12c2ad7cad0a7912c709a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583202
> Reviewed-by: Felicia Lim <[email protected]>
> Commit-Queue: Felicia Lim <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157298}
Bug: 1451254
Change-Id: I3467baf0eab48ae88ffce591d8bfcc9b6160fee3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612925
Commit-Queue: Lingqi Chi <[email protected]>
Auto-Submit: Lingqi Chi <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157330}
Remove unnecessary TestGLES2Interface from tests
This CL removes TestGLES2Interface from some cc_unittests where it looks
totally unnecessary. It's either not used or used to set
Capabilities::egl_image_external=true which is always true anyways.
Bug: 1453349
Change-Id: Id6cf422f74c8668c27b67f944b5000e06d8c82ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606126
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157329}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686657822-1c05e03f71a0211c7f890878b432651fb5f996fe.profdata to chrome-chromeos-amd64-generic-main-1686700798-cb29b14c7ed9966349373b19f56cb9cdb2793fcd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id357e8a7f06b1b5c1a836ed456d6f62474f50752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612549
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157328}
Roll ANGLE from 14339812a9db to ce7b9602aa0f (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/14339812a9db..ce7b9602aa0f
2023-06-14 [email protected] Avoid clearing global settings when register receiver.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Test: Test: Verify per-application override is no longer cleared
Change-Id: I3d810ebbab87004cce8b3452f38483d0896c8fdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612108
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157327}
Roll WebRTC from 1f235d6efe85 to 7d77e247f2f4 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/1f235d6efe85..7d77e247f2f4
2023-06-14 [email protected] Roll chromium_revision 8d5bd97af2..13b44452d4 (1157142:1157265)
2023-06-13 [email protected] Roll chromium_revision 6f33bc2255..8d5bd97af2 (1156959:1157142)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I07fda83d1c3d1abcaa44f1256e407b0936ddbd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612547
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157326}
[OOBE] Recalculate colors for enterprise enrollment & add person flows
Wallpapers can change for those flows (e.g. device->devicepolicy->userpolicy/online)
Bug: b:268468482
Change-Id: I226a755dc69899abc4f99fe0c26d60ccac407b63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573572
Reviewed-by: Jason Thai <[email protected]>
Commit-Queue: Simon Ziegltrum <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157325}
[WebUI] Add trusted_types_test_util to the Ash WebUI common directory
This CL adds a trusted_types_test_util library to the
`//ash/webui/common` directory that provides Trusted-Types testing
related utility functions. It adds a `AddTestStaticUrlPolicy` function
that enables tests to create trusted script URLs.
Bug: 1400799
Change-Id: I4efb317ee5de5e7e7459897e160d925e2cf31456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576596
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157324}
[keyboard-alt]: Implement GetRemapRightClickModifier
- When the kAltClickAndSixPackCustomization flag is enabled,
the device's simulate_right_click setting will be used to
determine if an event should be remapped to a right click
Bug: b/279503977
Change-Id: I40e1e36145639127cf163cc39269ddc90fc3ceca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546040
Reviewed-by: David Padlipsky <[email protected]>
Commit-Queue: Michael Checo <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157323}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686679195-33c434849e7a07bda6014953a718b27a46cc63a8.profdata to chrome-linux-main-1686700798-35913de13d5970f166252b3cd6a37d6724a6e7a1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I30635dea2cc0dc84bb4df457683a1564fbe21115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612349
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157322}
Refactors SearchResultIconInfo to use ImageModel
To better work with the new jelly color migration, using ImageModel is
preferred to define the color theme with model in the icon info.
Bug: b:278271038
Change-Id: Ia25858675c3f3e8f51773bc87eec15fbf10acc93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562850
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Tony Yeoman <[email protected]>
Commit-Queue: Wen-Chien Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157321}
Update BrowserDataMigrator test for Lacros SxS/Primary removal.
Some combination will soon unneeded.
BUG=1448575
TEST=Tryjob
Change-Id: I88e79d3bd8341d70e1545b0346342b179ecf60e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610183
Reviewed-by: Yuta Hijikata <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157320}
Garden: disable some webdriver tests
Bug: 1430078
Change-Id: I66c9ec3c4140f728d7986ca9088a3b825d828510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612705
Quick-Run: Lingqi Chi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157319}
On ClientCertStoreChanged notifications only evict connections that used client certs
Bug: 915463
Change-Id: I783b3bf04b5ca7c65eb5478620cd7d20677284c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596420
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157318}
Reduce contrast in the generated title bar color for tabbed apps.
If an app has not defined a theme_color, the title bar for tabbed
web apps will be generated from the background_color (which is used
as the tab color).
This change reduces the contrast between the tab color and generated
title bar color because UX wants a lighter grey for the title bar
when the tabs are white.
Before and after screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=1454361#c1
Bug: 1454361
Change-Id: I7fb4f3569db4899532938310cccb49a2a855f1cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600768
Reviewed-by: Alan Cutter <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Louise Brett <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157317}
PreloadingAttempt: move most DCHECKs to CHECKs
This follows the recent updates to
https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/checks.md,
and could be helpful for diagnosing some of the "impossible" metrics
we're seeing in the field.
The DCHECKTriggeringOutcomeTransitions function is left untouched, since
the DCHECK_STATE_TRANSITION framework has not been updated, and it looks
potentially more costly.
Bug: 1449095
Change-Id: Id775cd9c864cb75207f30999b86baefe53a101d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607684
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157316}
Prerendering: add document rules smoke tests
As the inline comment notes, parameterizing the more-comprehensive
prefetch tests would be ideal. But for now, let's get some basic
coverage in place.
Bug: 1371522
Change-Id: I603ce286a2fb9e0ea3ce465ac223c8cc61bce010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607733
Commit-Queue: Domenic Denicola <[email protected]>
Reviewed-by: Adithya Srinivasan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157315}
Roll libyuv from 2a5d7e2fbc67 to 552571e8b24b (1 revision)
https://chromium.googlesource.com/libyuv/libyuv.git/+log/2a5d7e2fbc67..552571e8b24b
2023-06-14 [email protected] [RVV] Enable ScaleRowDown34_RVV & ScaleRowDown34_{0,1}_Box_RVV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libyuv-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ica58943401ea3440b86f2eb808f52125d772c93b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612029
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157314}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686689697-b0bd01cd7fcaee3c0a7a27239be0acf8ddd6d886.profdata to chrome-mac-arm-main-1686700798-3839fafefa39d2ede8b01728d8bd5f115e4cc627.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ief036fa42b199e46d4b12ec0a6edd9eee588b546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612109
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157313}
Automated Commit: LKGM 15499.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778533377121309249
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: Ibc22ceff7d4f17ce9fc2c09f115977004f6a4a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604447
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Owners-Override: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157312}
Roll Manifest Merger from nGzWwB6kx8dBDTH7L... to UNXioFXYvz7k7UmE2...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/manifest-merger-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: Ia3d73451def5f5c8727e70197981ad130d98f86d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610984
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157311}
Roll WebGPU CTS from cf7f6bbb1131 to e957d8fd868b (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/cf7f6bbb1131..e957d8fd868b
2023-06-14 [email protected] Add F16 Builtin tests step 1: abs, ceil, floor, round (#2762)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Ia84b0a63466923713180ec346c51cc9babaeb3a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612585
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157310}
[WebUI] Add trusted_types_util to the Ash WebUI common directory
This CL adds a trusted_types_util library to the `//ash/webui/common`
directory that provides Trusted-Types related utility functions. It
also adds a `ash::EnableTrustedTypesCSP` function that mirrors the
behaviors of `webui::EnableTrustedTypesCSP` living under chrome.
Bug: 1449822
Change-Id: I3a46166891714f32b54ac54484a7610266da0475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573172
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Junguo (Jun) W. <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157309}
BulkPinning: Add histogram declarations
BUG=b:286491101, b:286969026, b:286969497
Change-Id: I45d03bca2d4f3020e1b837f86d6a49e6df0bd0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607734
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Nigel Tao <[email protected]>
Reviewed-by: François Degros <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157308}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I2febfd4b3f82eac85ee0becfac2e8b7c8de86bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611731
Commit-Queue: Sean Kau <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157307}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I71c5f9e58bfaffc1b76a8ebb73b9cb1931eb81ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604686
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Cici Ruan <[email protected]>
Reviewed-by: Cici Ruan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157306}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: Ia4e3da1c80a0db39c64bfc5f738927183783caca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604687
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157305}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: Ied20fede9eac1d0bf11c2582600f385330226e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610246
Commit-Queue: Sean Kau <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Reviewed-by: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157304}
Update side panel background for chrome desktop refresh 2023
Updates the background to surround the side panel content so the header
is now over the background and owned by the SidePanel. Update the
combobox background and foreground color.
Bug: 1399966
Change-Id: I70a04285075908d1c950265ea05813d719c09d40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609442
Commit-Queue: Caroline Rising <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157303}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I5bebcb8fee36adaf11606c2fc6990fbfaf7f7d77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610245
Reviewed-by: Jimmy Gong <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Quick-Run: Sean Kau <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157302}
[VC] enable CrOSLateBootAPNoiseCancellation for VC.
Bug=b:271338811
TEST="N/A"
Change-Id: I838cac309d58d2a5e47fa14e28b75af7fbe8eaff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596438
Reviewed-by: CJ Huang <[email protected]>
Commit-Queue: CJ Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157301}
[dPWA] Add debug info to WebAppPolicyManagerBrowserTest.AppIdWhenNoManifestId
This CL attempts to debug Mac flakiness in:
WebAppPolicyManagerBrowserTest.AppIdWhenNoManifestId
Context: https://chromium-review.googlesource.com/c/chromium/src/+/4604153/comments/49364186_e43e42ff
Change-Id: I5381cd73cfb9ebc4d404b6445d3654a78096bacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612325
Reviewed-by: Louise Brett <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157300}
Move and rename window-management wpts, enable automation
Rename dir and update meta url for `window-management` spec name.
Rename files for clarity, brevity, consistency.
Remove '-manual' from filenames, to trigger automated runs and support:
./wpt run chrome window-management/*
(results should surface on https://wpt.fyi/results/window-management)
Bug: 1022988, 1338645, 1453772
Change-Id: I16887de7c245561afff73c2dfb17e3ad32f5f74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611945
Auto-Submit: Mike Wasserman <[email protected]>
Reviewed-by: Brad Triebwasser <[email protected]>
Quick-Run: Mike Wasserman <[email protected]>
Commit-Queue: Brad Triebwasser <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157299}
Disable fixed point for Opus on Apple silicon Mac
Bug: 1451254
Change-Id: I20987deb32c95b01fa12c2ad7cad0a7912c709a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583202
Reviewed-by: Felicia Lim <[email protected]>
Commit-Queue: Felicia Lim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157298}
Roll earl_grey2 from d2717abfb03a to 3b368a241858 (2 revisions)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/d2717abfb03a..3b368a241858
2023-06-13 [email protected] iOS 17 replaceText (1)
2023-06-13 [email protected] iOS17 Screenshot window levels (2)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I35df3e52b6773b45208170b4a3ea2e25008931ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611905
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157297}
[ssci] Update tools/licenses/licenses.py to prefer using Shipped field
Bug: b:285042243
Change-Id: Ibb541aab71baa79ce349bee2c7d217316a5f498f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596479
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Anne Redulla <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157296}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686679195-96705c2194956572f5a48a9ee26ddce3b2ee8709.profdata to chrome-win32-main-1686689697-1d819550ace18908a2a18930f2933c285cef2359.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I02b3914062a234a1effc1bf1945936cb160dab02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611685
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157295}
[FilesRefresh] Update quick view test to check iframe color
The integration test openQuickViewBackgroundColorHtml checks the
background color of <files-safe-media> previously, but this bg
color has been removed in GM3 because body color in iframe is the
color what we care about. This CL updates the test to check the
body background color instead, similar to what other QuickView
tests do.
Bug: b:286456485
Test: browser_tests --gtest_filter="*openQuickViewBackgroundColorHtml*" --enable-features=Jelly
Change-Id: I39acdff44e607fb578e73fa8bbe7181df0b547c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600477
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157294}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686686369-72ee85ad09686eb29e4d96da3cd5a3169f77815c.profdata to chrome-mac-arm-main-1686689697-b0bd01cd7fcaee3c0a7a27239be0acf8ddd6d886.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ic70aad12a8f901a626ebfaa2a28098f1e84f545b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612586
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157293}
Fix test coverage for battery saver Start()
Change-Id: Ib902ccf5296176c6d68cbdd7a041195a9394b412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612405
Reviewed-by: François Degros <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157292}
gpu: win: Upgrade global DComp device from IDCompositionDevice2 to IDCompositionDevice3
We will need IDCompositionDevice3 to support delegated compositing in
the future, so this CL makes the upgrade in isolation.
The minimum supported OS for IDCompositionDevice3 is Windows 8.1 [1] and
the minimum supported Windows version Chromium supports is currently
Window 10 [2].
[1]: https://learn.microsoft.com/en-us/windows/win32/api/dcomp/nn-dcomp-idcompositiondevice3
[2]: https://support.google.com/chrome/a/answer/7100626
Bug: 1132392
Change-Id: Id738190bdda6ad690fa6aefaf118245a76215077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610982
Commit-Queue: Michael Tang <[email protected]>
Reviewed-by: Rafael Cintron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157291}
[Fixit] Fixing and re-enabling testStartUpPage for HomepagePolicyIntegrationTest
Updating the deprecated URL fixes the test. The test is not flaky now
and passing in test reviver.
Change-Id: I4b141ef5736f4ff2e0869f2ded9ac973b8736b01
Bug: 1331047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611251
Reviewed-by: Wenyu Fu <[email protected]>
Commit-Queue: Ritika Gupta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157290}
Fix SSLUITestReduceSubresourceNotifications deleted copy/assignment prototypes
Change-Id: Ib90f2ee283cd7340d60696561cc2f07810ba9ab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612165
Auto-Submit: Matt Mueller <[email protected]>
Commit-Queue: Chris Thompson <[email protected]>
Reviewed-by: Chris Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157289}
CrOS GMC V2: Fix bugs for adding cast media items to updated CrOS media
view
- Make CastMediaNotificationProducerKeyedService consume
MediaItemManager from both MediaNotificationProvider and
QuickSettingsMediaViewController and create
CastMediaNotificationProducer for both so that the quick settings view
will display cast media items too
- Fix the logic for hiding the media item that has presentation of
another casting media item; only need to hide it in
MediaSessionNotificationItem which will always be called; do not hide
the media dialog since there can be other media items displaying
- Add the "Stop casting" button in MediaNotificationViewAshImpl for
easier testing though the UI needs further work
- Fix the crash of ~MediaNotificationViewAshImpl()
Bug: 1442056
Change-Id: I9b821fb1357173c578d43bec4d353b25c64e6e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606305
Commit-Queue: Yiren Wang <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157288}
[Tab Strip Redesign] replace button icons
- For NTB icon, we use 20dp optical size and 20x20dp for width x height.
- For incognito icon, also use 20dp optical size but 24x24dp for width x height
Folio screenshot: https://screenshot.googleplex.com/AzHTjjuy5JgdcNd
Detached screenshot: https://screenshot.googleplex.com/6rcidpXPsueq9sw
Bug: 1453105
Change-Id: Ia5ca836fb6127cf14c52170f3ed94a659b6c8ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599093
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Neil Coronado <[email protected]>
Commit-Queue: Zhe Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157287}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686679195-d48d2451e080e197d155bf47e1f9e6dda617e83c.profdata to chrome-mac-arm-main-1686686369-72ee85ad09686eb29e4d96da3cd5a3169f77815c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I72bc20b9cbc3c814a14affa28d6745570e0df1ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609417
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157286}
[Emoji Picker] Add missing a11y labels for left / right chevron buttons
This a11y change is protected under GIF flag.
Bug: b:286955384
Change-Id: Ifdff93bc649cf5dbb1536257c2b479361022bc80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609741
Reviewed-by: John Palmer <[email protected]>
Reviewed-by: John Palmer <[email protected]>
Commit-Queue: Grey Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157285}
Roll Catapult from 45275b64c5ea to ca32af6260e4 (2 revisions)
https://chromium.googlesource.com/catapult.git/+log/45275b64c5ea..ca32af6260e4
2023-06-13 [email protected] Create benchmark and device allowlist for sandwiching method
2023-06-13 [email protected] [typ] Fix expected results edge case
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1419903,chromium:1454250
Tbr: [email protected]
Change-Id: Ide05a04476101816e1bc09c147ca69faea631891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611686
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157284}
Roll Android Lint from 3AJFzcPQ9EDTP7XlH... to nGuHS3ccbDvKba1WE...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/lint-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I02b961dd6b40024d72ce77a7a5597a8af37c8ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611037
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157283}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitive dependency (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I77bb10053a5c61c02835956f5d2ba1dbce2a94ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611101
Auto-Submit: Sean Kau <[email protected]>
Reviewed-by: Peter Kotwicz <[email protected]>
Commit-Queue: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157282}
Use LacrosOnly for StartupBrowserCreator.
Currently, the test is using LacrosPrimary, which is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: I899af64705bcf00a2cfa9e4b5df4aac15eac473b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607999
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Georg Neis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157281}
[Code Health] Remove expired histograms Net.Prefetch.HitBytes,
Net.Prefetch.PrefilterBytesReadFromNetwork
This CL removes expired histograms Net.Prefetch.HitBytes,
Net.Prefetch.PrefilterBytesReadFromNetwork
OBSOLETE_HISTOGRAM[Net.Prefetch.HitBytes]=obsoletion
OBSOLETE_HISTOGRAM[Net.Prefetch.PrefilterBytesReadFromNetwork]=obsoletion
Bug: 1384729
Change-Id: Ie831e44c261631d8c183cbab4178fb49a5a42e0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583907
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Huanpo Lin <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157280}
media/gpu/chromeos: Adds PlatformVideoFramePoolTest test for Compressed
GMB
This CL adds the test |CompressedGpuMemoryBufferModifierIsPassed| to
verify if the platform video frame pool allocates the VideoFrame objects
backed by compressed GPU memory buffers correctly.
BUG=b:281699102
TEST=./media_unittests --gtest_filter="All/PlatformVideoFramePoolTest.CompressedGpuMemoryBufferIsPassed/PIXEL_FORMAT_NV12"
Change-Id: Iae7178e61295f034048a23af3d2872e8aa260cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590675
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Hang Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157279}
Add SpeculativeServiceWorkerWarmUp to fieldtrial_testing_config.json
Bug: 1431792
Change-Id: I0195390420af26e7df1faae4d4aef7ab248cd627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604704
Reviewed-by: Shunya Shishido <[email protected]>
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157278}
Split CertDatabase notifications between trust changes and client cert changes
Bug: 915463
Change-Id: Ieda96f9e17ac69238c8c19f6737e5930c3acb312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596317
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Chris Thompson <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Reviewed-by: Chad Duffin <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157277}
Add mark as complete behavior for tasks glanceable.
Bug: b:277268122
Change-Id: I2222ee3837804d094b09961c7b2b238ee326be69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606724
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157276}
Reset raw pointers in AudioDetailedView when scroll view is updated
The crash is caused by not resetting the raw pointers after the scroll
view is updated. Then if the user clicks the noise cancellation view,
the crash happens.
Bug: b:286962478
Change-Id: I46728f7704872f7af63b65972f1f9095616c64e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609095
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Sylvie Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157275}
Use LacrosOnly for PersistentForcedExtensionKeepAlive tests.
Currently Lacros SxS is used, which is going to be removed.
This CL replaces the mode by LacrosOnly.
Move scoped unsetting KeepAlive to the end of SetUp,
so in the test bodies, KeepAlive instantiated during the
SetUp is hidden.
BUG=1448575
TEST=Tryjob
Change-Id: Ie194f46508e146a00f68f310a56c1b7344ec0d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608084
Auto-Submit: Hidehiko Abe <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Reviewed-by: Georg Neis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157274}
[Nearby Presence] First time registration: upload credentials to server
Uploads the generated credentials to the NP server for first time
registration flow. This logic reuses the existing scheduler for the
request in order to ensure exponential retries and network
connectivity. The conversion from SharedCredential to
PublicCertificate protos is a skeleton due to an open question
about missing fields, which will be added as a follow up.
Tested: Unit tests only
Bug: b/276307539
Change-Id: I764a7e0ac68517ea24f6ee0fa96af19e209a3e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4543881
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Juliet Lévesque <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157273}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686679195-ae4cf23745fe2676f2bda242ad2b7d7e2f515af2.profdata to chrome-win64-main-1686689697-848785595114f81b32bcdb3ecd329b0719fd8d85.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I7fe7d20a7976aba7df28e6b4a1f200184f4b9c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610176
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157272}
[NP] Reenable NPService unittests.
msan threw an unitinialized memory error for some of the tests in
nearby_presence_service_impl_unittests.cc. This cl fixes those errors.
failed before this change and passed after this change.
Test: Ran tests with same gn args as the failing build. Those tests
Change-Id: I63bd7e22de9e04e0453336dd4ea99d50692406be
Bug: crbug.com/1451251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605026
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Alex Kingsborough <[email protected]>
Reviewed-by: Juliet Lévesque <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157271}
[DownloadBubble] Refactor views pt. 4: Track adding and removing rows
This moves construction of the ScrollView and DownloadBubbleRowListView
into DownloadBubblePrimaryView, so that the primary view has access to
the offsets of each row in the list. This will allow us to scroll the
view to a particular download.
Bug: 1450660
Change-Id: If338637e7e80e6b6b41abc602ce149a17faba8d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582304
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Caroline Rising <[email protected]>
Commit-Queue: Lily Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157270}
[Chrome Refresh] Add Iconography for profile chip guest icon
Bug: 1399947
Change-Id: I81682b7286fdf71eb84b4406d8fee01cee3edc49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609185
Commit-Queue: Shibalik Mohapatra <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157269}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I8076e6a7ed77c6782cfa3d97f0ce7c221b71001a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611277
Reviewed-by: Chad Duffin <[email protected]>
Commit-Queue: Chad Duffin <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157268}
[ntp][realbox] Add tall realbox feature
Allows making the realbox taller behind a feature flag.
Different variants using NtpRealboxWidthBehavior and NtpRealboxIsTall:
Narrow & short: http://screenshot/9WbKdgRs3RLvqE4
Narrow & tall: http://screenshot/7jJS4t9CRNJ2buz
Wide & short: http://screenshot/9sgttv7VfRTdmAz
Wide & tall: http://screenshot/3hJeMowPu4kZtUU
Bug: 1451993
Change-Id: I5b575aec5176b1e4f85b2c6033dd14fcb9f23360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606128
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157267}
lacros/color-management: support more formats
Add support for more gfx::ColorSpace specific Primary, Transfer, and
Matrix IDs.
DO NOT REVERT - This commit contains xml, client and server side
changes.
BUG=b:192562912
TEST=build and deploy to DUT
Change-Id: I2dfe7d5baa860a18f444130ce88e8c44b62560e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4446401
Commit-Queue: Femi Adegunloye <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Peter McNeeley <[email protected]>
Reviewed-by: Kramer Ge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157266}
Removed import to fix presubmit warning
Changes crrev.com/c/4608563 and crrev.com/c/4609706 landed almost
simultaneously and both modified DownloadTest.java and it appears that
this allowed them to both pass presubmits while their combination caused
a presubmit error. This error showed up on the presubmit --all bot:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/5971/overview
The error is:
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java:30:8: Unused import: org.chromium.base.test.util.DisabledTest.
This change removes the import that is no longer needed after both
changes landed.
Change-Id: I60ee5e8396dc3df39fcbf9f1fc5e00080a2785ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611231
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Auto-Submit: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157265}
Remove unreachable code. MSVC does not like this.
Bug: 1322914
Change-Id: I700410beee851d8c78a12c9431b12c40d8775c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611173
Auto-Submit: Bob Beck <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157264}
[Fixit] Re-enabling testPopupWindowsAppearWhenAllowed for PopupTest.
Re-enabling the tests as it is now not flaky and passing in test
reviver.
Change-Id: I27c26507935d1214953c9dbdac69dd14b21e59e1
Bug: 1331023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609096
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Ritika Gupta <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157263}
bubble_frame_view: Ensure minimize is before close when tabbing
When both buttons are visible, minimize should precede close when
tabbing between elements. This is an a11y requirement due to the visual
display order of the elements. The tab-order derives from the order in
which view.AddChild() is called, so we enforce that minize is added
before close.
Bug: b:279600059
Change-Id: I536e6523523dadc4af7140d92dd038022699c70a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603622
Commit-Queue: Nic Hollingum <[email protected]>
Reviewed-by: Connie Xu <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157262}
Add fieldtrial test config for HTTPS-First Mode for Engaged Sites
This CL enables HTTPS-First Mode for Engaged Sites alongside
HTTPS-Upgrades in tests.
Bug: 1442679
Change-Id: I63761a8353be81c6908c0ab96e3029ebdaede6e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611253
Reviewed-by: Chris Thompson <[email protected]>
Commit-Queue: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157261}
Remove SubframeShutdownDelay feature flag
This feature is launched and enabled by default on Windows and Mac.
This CL removes the base::Feature and replaces it with
ShouldDelayProcessShutdown(), which returns true on those platforms.
Bug: 894253
Change-Id: I4373c33c4bb44f5e419b0094c21f567e3a35f4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4581183
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Jesse McKenna <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157260}
Use LacrosOnly for DriveIntegrationService test.
Currently, it is using LacrosPrimary, but the mode is going to be removed.
Use LacrosOnly instead.
BUG=1448575
TEST=Tryjob
Change-Id: I6a108395eaa2d4ba68c2083b1193862b0e57f736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607689
Commit-Queue: Austin Tankiang <[email protected]>
Reviewed-by: Austin Tankiang <[email protected]>
Auto-Submit: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157259}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: Ic243af29cdc0de29ddd488deeac9b2f600b166f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611102
Reviewed-by: Daniel Murphy <[email protected]>
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157258}
Roll PDFium from 1b2a3b54907b to e392794c0ec0 (3 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/1b2a3b54907b..e392794c0ec0
2023-06-13 [email protected] Remove force_alpha parameter
2023-06-13 [email protected] Remove last reference to SkBitmap
2023-06-13 [email protected] Remove no longed needed .cookie from PartitionOptions initialization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Icf56ae9d7c2b8c74d3761ec26ba12edba376ec4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610175
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157257}
updater: fix version check in RunOfflineInstall test.
If the version can't be read, the subsequence EXPECT_EQ is going to
try to compare an invalid version with kTestPV. This checks and
terminates the test process, giving a misleading stack and not doing
the relevant clean up after the test.
Bug: 1454497
Change-Id: Ic73cba1fc38fee4fd5d7051c40f6ff945fa8d05f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611727
Code-Coverage: Findit <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Auto-Submit: Sorin Jianu <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157256}
Refactor `ShowNudge` in NudgeManager unit test
Refactor unit test function to better mirror production-like behavior:
create a `NudgeData` object first and then show it through the manager.
Bug: None
Change-Id: I635995230161e9b91f8be2101b4909988b9effef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609477
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Kevin Radtke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157255}
Roll Fuchsia SDK from 12.20230612.1.1 to 13.20230613.4.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: Ifd07a4596c0e306ebf027003fa891a5cbf2a6fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610717
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157254}
[ChromeRefresh2023] Fix ChroMenu translate string on Mac
Translate string was missing ellipsis
Bug: 1449977
Change-Id: Iab085fb55367d8a3745461e4ea1bd980c65f9e39
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606722
Reviewed-by: Elaine Chien <[email protected]>
Commit-Queue: Joseph Park <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157253}
Roll Depot Tools from 3141269ed1e6 to 2b19afb82030 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3141269ed1e6..2b19afb82030
2023-06-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I3aafffc96abe776a07801aa72e99c3379d3b1010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610077
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157252}
WebUI: Leverage build_webui() in c/b/r/internals/.
build_webui() is the canonical way of building WebUI pages, and
leveraging it brings many advantages, like JS minification.
Bug: 1431253,1132403
Change-Id: I4df9c9cef6ddcd49c33405de90d48dcc3727a20b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611092
Reviewed-by: Cole Horvitz <[email protected]>
Code-Coverage: Findit <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Cole Horvitz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157251}
ipcz: Clean up transport terminology
ipcz.h confusingly overloads the term "transport" to refer to both a
driver-side object and a separate but related ipcz-side object.
This change establishes more consistent terminology: "transport" is now
always a driver-side object, and the ipcz-side analog is its "listener."
This is a superficial change to the public-facing API.
Also cleans up miscellaneous bits of related documentation in ipcz.h.
Bug: None
Change-Id: Iada0a84da30c1e5c1d651033335d1b9754aad5f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611591
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157250}
RetryOnFailure all WebGL conformance tests on Win/AMD/D3D9.
It looks like GPU process hangs are causing random tests to fail.
Hence forcing RetryOnFailure on all tests for now.
Bug: 1446091
Change-Id: I92700232d4915123f5962583f928738115013936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611405
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Quyen Le <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157249}
[TabStrip] Round strip tab container height
Round strip tab container height.
-When creating the associated bounds for this object, the height float
would be truncated. This could result in a gap between the tab
container and the toolbar (appearing as a hairline the color of the tab
strip bg).
Bug: 1454488
Change-Id: I46feec00ce893a181506fcecf9b467f73402ebb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611595
Commit-Queue: Neil Coronado <[email protected]>
Quick-Run: Neil Coronado <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157248}
[Fixit] Re-enable ChromeSurveyControllerIntegrationTest tests
This is a speculative fix that adds a CriteriaHelper#pollUiThread check
on enqueued messages before attempting to access the survey message in the setup.
Bug: 1447519
Change-Id: I78f45b790152997a7ca67810ab04757e65b6b623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608931
Commit-Queue: Aishwarya Rajesh <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157247}
Adding beforeunload post task (and CH frame) to high priority experiment
NavigationNetworkResponseQueue is an experiment that increases the
priority of tasks that block network request from starting or from
committing. Because before unload blocks navigation when a before
unload handler is not registered, running that task at higher priority
will improve navigation latency. Making the PostTask async has proven to
be challenging.
The Accept CH frame happens on about 5% of navigations on Android and restarts the request. Since the CH frame is on the connection, it can happen early, but otherwise acts similarly to the redirect part of the navigation network response experiment.
Bug: b/281094330
Change-Id: I29612cb97fe0def629dc399d68d57161f9263137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590455
Commit-Queue: Ryan Sturm <[email protected]>
Auto-Submit: Ryan Sturm <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157246}
Fix Updater uninstall may not uninstall other versions
This CL fixes the bug and adds unit tests for the existing related code
in the `AppUninstall` class.
Fixed: 1454334
Change-Id: Ie38ef5fdd5acabc5635aeb8df3d9fbc6d05305c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611227
Auto-Submit: S Ganesh <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157245}
App Service: Remove InstanceRegistry::Observer::Observe methods
Clients can use a ScopedObservation to manage their observation of the
cache, which is a more common pattern across the codebase.
Bug: 1453127
Change-Id: I072fd5649be6a030ac625f76a4d5b36d563282bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607569
Reviewed-by: Maggie Cai <[email protected]>
Commit-Queue: Tim Sergeant <[email protected]>
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Courtney Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157244}
Revert "Invalidate the AX subtree when recomputing NGOffsetMapping."
This reverts commit b6a9046efd20a08c03430cacd5ad888289e53089.
Reason for revert: Suspecting this is breaking several bots
Some bots (mac specifically) fail mostly consistently, other linux
bots fail but less consistently.
First visible mac bot failures
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/35034/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/20360/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/10298/overview
Linux bot failures
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/33189/overview
Original change's description:
> Invalidate the AX subtree when recomputing NGOffsetMapping.
>
> NGOffsetMapping determines the start and end character of text runs
> corresponding to nodes in the tree. The text can depend on all of the
> nodes (text and non-text) contributing to a LayoutBlockFlow. Therefore
> we need to invalidate all of the descendants of the LayoutBlockFlow
> when that offset is recomputed; otherwise, we might end up with
> the wrong TextAlternative for an AXObject.
>
> This is the root cause of two flaky tests for CL 4553316:
>
> * DumpAccessibilityTreeTest.AccessibilityCSSVisibility/blink
> * DumpAccessibilityTreeTestWithIgnoredNodes.InertAttribute/blink
>
> The failures can be reproduced reliably when using this flag:
>
> --enable-blink-features=HTMLParserYieldAndDelayOftenForTesting
>
> Because it causes the HTML parser to yield sometimes after a text
> node that has a trailing whitespace, followed by another node that
> affects whether that whitespace is reflected in
> LayoutText::PlainText.
>
> Change-Id: Ifb11d7227ea311a614889eb446abbb525ce51e3b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602526
> Commit-Queue: Chris Harrelson <[email protected]>
> Reviewed-by: Aaron Leventhal <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156958}
Change-Id: Idefd4cdabe7fe80e56b4ff4a2a8a82e4585dd941
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611688
Commit-Queue: Tom Lukaszewicz <[email protected]>
Auto-Submit: Tom Lukaszewicz <[email protected]>
Owners-Override: Tom Lukaszewicz <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157243}
Scrolling on clamshell overview mode.
Prevents overview mode in clamshell from being cluttered by adding a
scroll layout when all the windows cannot fit on the screen.
Adds a cros-labs feature flag and basic functionality.
Adds basic tests. Will add more tests in future CLs and as edge cases
are found.
Test: Manual, ash_unittests
Change-Id: Ifa5aef315f5a97a5d2b0c0a54c6a4957a84bee72
Bug: b/284165330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574788
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Phillip Vanderlaat <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157242}
[fuchsia] Add missing includes
See https://fxrev.dev/869997.
Bug: fuchsia:103032
Change-Id: I955e1693869d670dc030fdbee646187fd6b2eef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610527
Reviewed-by: David Dorwin <[email protected]>
Commit-Queue: Tamir Duberstein <[email protected]>
Auto-Submit: Tamir Duberstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157241}
[Omnibox] Optimize ScrollToTLD
ScrollToTLD uses Layout.getOffsetForHorizontal() to calculate the index
of the last visible character, but this can take tens of ms. This cl
optimizes away some calls, and replaces getOffsetForHorizontal() with
Paint.getOffsetForAdvance(), which is ~12 times faster.
Bug: 1432727
Change-Id: I004e7f803ed7d8d26d50f8f8256d7e74a1b5d045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608621
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Peilin Wang <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157240}
CrOS Settings: Convert network proxy section browser test to TS
Additionally, moved the test under the `internet_page` folder to
mirror the app folder structure.
Bug: b/270728282
Test: browser_tests --gtest_filter="*InternetPageNetworkProxySection*"
Change-Id: Icf68e3caa6f709c179ae06b809931be92db68d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606441
Commit-Queue: Ruma Kesh <[email protected]>
Reviewed-by: Chad Duffin <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157239}
[Nearby Presence] Add comment to check for settings device name
Adds a comment to the LocalDeviceDataProvider to check for device
name changes set by the user when the NP settings page is
added.
Tested: N/A trivial change
Bug: b/276307539
Change-Id: I3891ef5505487939bf05d2526675c54229fd264b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4555719
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Juliet Lévesque <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157238}
Ensure CrostiniSharedDevicesFactory is built during initialization
Similar to other CLs on crbug.com/1412439, these factories are supposed
to be built at initialization time.
Bug: 1412439, 1449568
Change-Id: I3b19c7d6a0161b590d172154399c9a5c832c2b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604340
Reviewed-by: Ryan Sultanem <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157237}
Disable ranking experiment in Android frecency tests.
Fixes flakiness from crrev.com/c/4606234
Bug: 1453908, 1453944
Change-Id: If382bedbb506899366b174a2e7a1d0eb2d60e32b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611086
Commit-Queue: Alexander Tekle <[email protected]>
Reviewed-by: Olivia Saul <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Vinny Persky <[email protected]>
Reviewed-by: Alexander Tekle <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157236}
[FIXIT] Use HistogramWatcher for AndroidFontLookupImplTest
The test was flaky due to fdsan introduced in API Level 30, which result
in more time required to finish Android calls for Mojo.
Switch to using HistogramWatcher so we can pull thread to make sure
histograms are recorded. Once that's done, for callbacks run in another
thread, run MojoTestRule make the test a lot less flaky.
Bug: 1233312
Change-Id: I7dc06b4bf7b80416533efc5512b5395ea1a48526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609467
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157235}
Remove RP blend staging flag
Bug: chromium:1450832
Change-Id: I0fc926dfc1ba0f19d238bd92303cdd0eeeb38597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605493
Commit-Queue: Michael Ludwig <[email protected]>
Reviewed-by: Brian Osman <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157234}
Roll src/net/third_party/quiche/src/ 90315e869..d9aaee403 (1 commit)
https://quiche.googlesource.com/quiche.git/+log/90315e8698e0..d9aaee403dc4
$ git log 90315e869..d9aaee403 --date=short --no-merges --format='%ad %ae %s'
2023-06-12 quiche-dev Moving functions that use protocol buffers to "testing/proto_utils" from testing/utils. This CL does not add any new code and only touches test and build files.
Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
Change-Id: Icbb005ce5955097bc7d85e514533b729cc988de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603364
Auto-Submit: Yoichi Osato <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157233}
[CVV Storage] Set and validate cvc in credit card class
Update SetRawInfoWithVerificationStatus() function to set and validate cvc if it's CREDIT_CARD_VERIFICATION_CODE type.
Update GetRawInfo() function to get cvc if it's CREDIT_CARD_VERIFICATION_CODE type.
Bug: 1450749
Change-Id: Iac7f8e9424c8072da11fa2d97a66cedd9402d96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590949
Commit-Queue: Jiali Huang <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157232}
Post Visual Search result uris to iframe
Change-Id: I6e7c6bf9688a5a888980718a386d7f4d1a77199a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608897
Reviewed-by: Michael Crouse <[email protected]>
Reviewed-by: Chris Bookholt <[email protected]>
Commit-Queue: Serena Pascual <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157231}
Migrate all tests on fuchsia-fyi-x64-dbg to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Icf02e889ff72f8d293bae037db60b4f8a6b465d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611348
Commit-Queue: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157230}
rebaseline win-arm64
Add new baselines, seems from previous rebaseline, there
are some new failures.
Change-Id: Idec948bdeeb27cd82d7ae9d1883dbf9cc0c6cc56
Bug: 1383647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604875
Reviewed-by: Jonathan Lee <[email protected]>
Commit-Queue: Nihar Damarasingu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157229}
[GridNG] Fix subgrid-baseline-002.html
Previously when synthesizing baselines we'd potentially use two
different FontBaseline (which determine whether to synthesize off the
block-end edge, or the middle).
This patch passes in the parent_grid_style such that we consistently
use the parent's FontBaseline when synthesizing.
Bug: 618969
Change-Id: Ib923e9c489039af2811c13563002801b5e2f686d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583538
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Reviewed-by: Ethan Jimenez <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157228}
media/gpu: Add MT21 Utilities
Add mt21_util.h, which contains optimized routines for decompressing
MT21 frames, and a number of unittests. Follow-up CLs will integrate
this code into the rest of Chrome via the ImageProcessor interface.
Bug: b:284994884
Test: Ran unit tests on a Hana
Change-Id: Idb941cc7663c5b0d508ef1440d15d185d046bd03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571651
Commit-Queue: Justin Green <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157227}
[DeskApi] Add Error Logging to desk_model
Adds in Warning level LOG statements into the desk model functions.
[email protected]
Bug: 282058923
Change-Id: I5d384a1ea523e40b0eb56d1e80ea55d15d637962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601826
Reviewed-by: Avynn Donaghe <[email protected]>
Commit-Queue: Antonio Alphonse <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157226}
Move TearDown to ifdef for clarity
follow up from 4606591
Change-Id: I58ad1cc58336f45cc897bd8d258c9a93672b5959
Bug: 1453887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611170
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Brendon Tiszka <[email protected]>
Commit-Queue: Grace Park <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157225}
overview_mode: Resume activation frame state of end of exiting overview
At the end of exiting overview mode, reset the paint as active lock to
resume the activation frame state. The bug is introduced by the CL:
CL:3775632
Bug: b/286572507
Change-Id: Iefea7d50285daa6934c62285c4049850115f6e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610314
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Connie Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157224}
[SFL] Add experiment flag for tracking by default
This patch adds the feature flag and about:flags entry for the "track
by default" experiment. The flag has been introduced for all platforms
but will primarily work on desktop to start with.
Bug: b:286410726
Change-Id: If4a6627ede899f61b1eaa96cf12dd71a8709b0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605356
Reviewed-by: Mei Liang <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157223}
Add Indonesian and Russian to the list of supported languages
This cl adds russian and indonesian to the list of supported
langauges.
Bug: b/287114380
Change-Id: I2c6745c4e51ad93cd63ea53351a2f4c87e84ee69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611585
Reviewed-by: Evan Liu <[email protected]>
Commit-Queue: Yilkal Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157222}
User Education: Add fallback values for colors
This is a temporary fix to fix non-CR2023 pages that do not yet have
the color pipeline but do show the IPH bubble (eg. chrome://settings).
Screenshots with all colors.css references removed:
- http://screen/69CpGfxqC6dKkLT
- http://screen/8aUCpzv77rMgYvt
Fixed: 1454258
Change-Id: Ib223248cd69b42ec5693dd2b6520b11ae206c050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608636
Commit-Queue: John Lee <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157221}
[Extensions] Remove WebstoreInstaller::Delegate.
This is a further cleanup CL. After removing two member functions
from WebstoreInstaller::Delegate that were never overriddne, it
became clear that it would be cleaner to simply pass two callbacks
into WebstoreInstaller, rather than keep the delegate.
However, there are API tests that use the delegate in a way that's
not compatible with using callback, so this CL moves the simplified
implementation of the delegate to the webstorePrivate API function
that makes use of it. It also removes the implementation that was
introduced in the previous CL that fixed the bug.
Bug: 1449680
Change-Id: I3bc9b7b933090d26475c8480c85ca2383244fb83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606253
Commit-Queue: David Bertoni <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Auto-Submit: David Bertoni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157220}
[CustomTabActivityTest] Re-enable testHiddenTabAndChangingFragmentDontIgnoreFragments
Re-enabling the tests as it is now not flaky and passing in test reviver.
Change-Id: Ib05f8c40946ec87e6d5d0ac0c156ec38b602459f
Bug: 1333223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610653
Commit-Queue: Ritika Gupta <[email protected]>
Reviewed-by: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157219}
[Fixit] Re-enabling testObserveActiveTab test in TabObserverRegistrar.
Re-enabling the tests as it is now not flaky and passing in test
reviver.
Change-Id: I865e1d94357292897219e6163b350954a3fc74c7
Bug: 1269017, 1333214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611390
Commit-Queue: Ritika Gupta <[email protected]>
Reviewed-by: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157218}
[Android] Use FeatureMap to generalize MessageFeatureList
Replace the code in MessageFeatureList with boilerplate
MessageFeatureMap.
This reduces code duplication, add support for field trial parameters,
and in the future adds support for CachedFlag.
Bug: 1445758
Change-Id: I72663c01130a6a22c4d21c661ff1b3bf7b376ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605782
Code-Coverage: Findit <[email protected]>
Reviewed-by: Lijin Shen <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157217}
Remove depth/stencil from default framebuffer
Code is not reachable.
Bug: 1445523
Change-Id: I25faa9cbe929299f9b39b532348a3335acfb5c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602116
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157216}
Revert "[Extensions c2s] Display confirmation message on request access button"
This reverts commit bc1fceb7571569d6db7a8c57738657ea8a94177f.
Reason for revert: Mac bots failing
Example of first failing build
https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/612/overview
Original change's description:
> [Extensions c2s] Display confirmation message on request access button
>
> Display a confirmation message for kConfirmationDisplayDuration on the
> request access button after it has been clicked.
>
> This CL doesn't fix the animation issues with the extension toolbar
> button (puzzle piece)
>
> Screencasts:
> - No reload:
> https://drive.google.com/file/d/1O3nVNG-Oq8aqGjyhgf9LSxSR_yYyLNy9/view?usp=sharing
> - Reload accepted:
> https://drive.google.com/file/d/1LAKk8VUjWVoaX40QGxRa26u3AiqJuC8O/view?usp=sharing
> - Reload dismissed:
> https://drive.google.com/file/d/1KUSPYOyX9gICU9Hf6mhAgSnZXwXnHKLi/view?usp=sharing
>
> Edge cases:
> Click on request access button and before button is collapsed:
> - Navigate to page that requests access
> https://drive.google.com/file/d/11YNJJFnFCMj3kDfXo5s7nkXArhoH7_cd/view?usp=sharing
> - Navigate to page that doesn't request access
> https://drive.google.com/file/d/1zsr8WkzFhmfb1i_LANPBnvo2kRtjvWtp/view?usp=sharing
> - Open a new tab
> https://drive.google.com/file/d/1gRv1vIJuDBoyfi7xY6psMTnAGCsCAI4g/view?usp=sharing
> - Change to an existent tab
> https://drive.google.com/file/d/1RWbxJdyTPgwYcb-76Uoq2-rhWC5lG8J6/view?usp=sharing
>
> Bug: 1390952
> Change-Id: I42adc2bd4aa125ed4330f964486de89f2a1dcc67
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582732
> Reviewed-by: Devlin Cronin <[email protected]>
> Commit-Queue: Emilia Paz <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157017}
Bug: 1390952
Change-Id: I5e0134ee2b36d1bb73cd2e363883afebe9bb2058
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611083
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Tom Lukaszewicz <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Tom Lukaszewicz <[email protected]>
Owners-Override: Tom Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157215}
Remove NavigateTest#testRequestDesktopSiteSettingPers
testRequestDesktopSiteSettingPers tests renderer initiated navigation
honoring tab-level desktop site setting.
The urls in use are
https://127.0.0.1:36627/chrome/test/data/android/google.html and
https://127.0.0.1:36627/chrome/test/data/android/about.html.
The test only runs with
ContentFeatureList.REQUEST_DESKTOP_SITE_EXCEPTIONS disabled, which is
the domain-level desktop site setting.
The domain-level desktop site setting has replaced the tab-level
setting; and it has been launched 100%.
Bug: 1454603
Change-Id: I6fffb0cd2e3fdaeaa13aeaa68d70ab7c881b6a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611392
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Shu Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157214}
[Chrome Refresh] Update Page Info Icons to have weight of 500
Bug: 1399991
Change-Id: Ie5952f1d5a3524f35458ba8b82ed9b0110bb60d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605366
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Shibalik Mohapatra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157213}
Roll src/chrome/browser/internal/ 86edf3656..9aa1b003c (1 commit)
https://chrome-internal.googlesource.com/chrome/browser_internal.git/+log/86edf3656689..9aa1b003c117
$ git log 86edf3656..9aa1b003c --date=short --no-merges --format='%ad %ae %s'
2023-06-12 mgeorgaklis Added second Intelligence OTA to test_accounts.json
Created with:
roll-dep src/chrome/browser/internal
Bug: 273308580
Change-Id: Ie8ee846816d8688786184fae50ef73b02a9031ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611169
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Marco Georgaklis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157212}
Settings Split: Fix shortcut viewer string
Change-Id: I13828763f9844a7c50c7fc3e9963913221b959c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611508
Reviewed-by: Michael Checo <[email protected]>
Auto-Submit: David Padlipsky <[email protected]>
Commit-Queue: David Padlipsky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157211}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686671915-f57d526d51a94ee5a559d6811ac713b0a4ae0f8e.profdata to chrome-mac-arm-main-1686679195-d48d2451e080e197d155bf47e1f9e6dda617e83c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I62c978ee9ed3eead605df117b405fda9374c0894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610972
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157210}
Roll ANGLE from 18010f58be60 to 14339812a9db (5 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/18010f58be60..14339812a9db
2023-06-13 [email protected] Merge Galaxy A23 and S23 e2d expectations where can
2023-06-13 [email protected] common: linux: add support for DRM_FORMAT_NV12
2023-06-13 [email protected] Only import xvfb on Linux.
2023-06-13 [email protected] Vulkan: Refactor angle::Format depth/stencil checks
2023-06-13 [email protected] Vulkan: Suppress vertex attribute divisor VUID
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I6d1487e27486bfc0901bdb8fd7d8e48091648596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610979
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157209}
Add SystemNudgeV2 DCHECK when initting nudge data
Add DCHECK to cause test failures when the feature is not enabled and
prevent test crashes by the manager not having been initted.
Bug: None
Change-Id: I6c4b742a7512dee40de9cb7f70de3ae3ade9a946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611095
Commit-Queue: Kevin Radtke <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157208}
Roll devtools-internal from 531d074c5146 to 5f55a210fa42 (2 revisions)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/531d074c5146..5f55a210fa42
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/81e8f798e7b0638ea521ce8d3b8fa2c6b5af5061..6e8ad1b59f68bf4764a0afefcaa6eec082b6cc71
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I6e16c6eeb71c1803497e7590cc3a6d538ffaf292
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609217
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157207}
Fix //chrome/android/j/s/c/o/c/c/b/survey/OWNERS
OWNERS were accidentally removed in crrev.com/c/4143820.
Change-Id: If47b8065b675d0175ca1943b80888c9914dfbae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607069
Commit-Queue: Theresa Sullivan <[email protected]>
Auto-Submit: Wenyu Fu <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157206}
Roll src-internal from 3f4cf65e4cca to 69c27e547002 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f4cf65e4cca..69c27e547002
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1423117
Tbr: [email protected],[email protected]
Change-Id: I2fa5e8414ac3af61a5f00c941e4c23571edb6a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611466
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157205}
Roll Catapult from 793b83da0634 to 45275b64c5ea (1 revision)
https://chromium.googlesource.com/catapult.git/+log/793b83da0634..45275b64c5ea
2023-06-13 [email protected] Update README.md Sandwich commands.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: [email protected]
Change-Id: Ib4f6329a0127765882ddbebec66ed246a704d066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610801
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157204}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1686635928-3621cd5bcdbf9d17753b5f865b3c1ec900dc1d05.profdata to chrome-mac-main-1686679195-ac74d94d2c6336a23baa367010b37789b8e53e48.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I288e492a4604381e6bccde5ca8e0bd5b6ca45b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611069
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157203}
Make histogram trigger check enum id
Bug: b/280493929
Change-Id: Ida3095053865959c761732afee8e12446d57103f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599024
Reviewed-by: Siddhartha S <[email protected]>
Commit-Queue: Hailey Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157202}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686668293-636d121caa311b2a70ca16e74db8bab74bc34891.profdata to chrome-win32-main-1686679195-96705c2194956572f5a48a9ee26ddce3b2ee8709.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ia49fd5f1fa9087df75c3cc8c1d2e22b08fa9ca4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609272
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157201}
Remove unnecessary improved bookmarks check.
This method is only called when the improved feature is enabled, and
so it does not make sense to continue to check the feature again.
Bug: 1449817
Change-Id: I0ab3b21a6c82d5ad9ced0177a3174b204a28c4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611510
Commit-Queue: Matthew Jones <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157200}
Remove RasterCapabilities::supports_disable_msaa
RasterCapabilities::supports_disable_msaa is set based on
gpu::Capabilities::multisample_capabilities from RasterDecoder.
RasterDecoderImpl never sets that capability so it's always false and cc
never supports disabling MSAA.
There is no point fixing the old code path since
GL_EXT_multisample_compatibility isn't supported on modern devices and
DMSAA will make it irrelevant anyways.
OBSOLETE_HISTOGRAMS=Related code was deleted
Bug: 1442970
Change-Id: I926f4d3656306bc5388569118de730dfae3f3299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609976
Reviewed-by: Jonathan Ross <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157199}
[floss] Add suffix to adapter client callback path
Use a different object path to export callbacks on each time the
adapter client is initialized so that we don't export callbacks
twice to the same object and get duplicate callbacks.
This fixes fast pair crashing.
BUG=b:284823123
TEST=manually test fast pair with Pixel Buds A and JBL 230NC
Change-Id: I037241ac3c646e813c9677d7da5f6eabd130d2e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611153
Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
Commit-Queue: Katherine Lai <[email protected]>
Auto-Submit: Katherine Lai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157198}
webauthn: update new hybrid UI to match UXW request.
Bug: 1444776
Change-Id: I91a7dbe30f8987b8843b71ba1acfc2705cc835e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611087
Reviewed-by: Martin Kreichgauer <[email protected]>
Auto-Submit: Adam Langley <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157197}
Roll Depot Tools from 7b5e3d7868de to 3141269ed1e6 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b5e3d7868de..3141269ed1e6
2023-06-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I989008b5fa4792bd72081a281beba16c79942bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610804
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157196}
IWYU ui/color/color_provider_manager.h
Add an explicit include for ColorProviderManager where it was
being retrieved through a transitively (which will be broken
in a future CL).
This CL was uploaded by git cl split.
[email protected]
Bug: b:286952053
Change-Id: I8d5878936d690b0ae099ae17fac7c4a22bfbd060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611160
Auto-Submit: Sean Kau <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157195}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686668293-c4b3e9dce845e20304e086624abe74f854c3cf2d.profdata to chrome-win64-main-1686679195-ae4cf23745fe2676f2bda242ad2b7d7e2f515af2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I8613bcbd638cef9e1c850f2297b437245232874d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606571
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157194}
infra: Migrate builds on Deterministic Fuchsia (dbg) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builders, please feel free to revert.
Bug: 1412588
Change-Id: I3a5491cd0a1a0294f9a00dc1fbfdf3488aee05c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609097
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157193}
Add new histograms to report errors initializing SQLite database.
This CL adds two new histograms that report more details on failed
SQLitePersistentStore DB initialization. These new metrics are
reported for both instantiations, ReportingAndNEL and Cookie.
The first, ErrorInitializeDB is the SQLite error code upon
initialization failure and is reported on all platforms.
The second, WinGetLastErrorInitializeDB is the ::GetLastError returned
on the DB thread after attempting to load the database, and is only
reported on Windows.
A test is added to verify this behavior, along with verifying that
the new histograms are only emitted in the failure case.
UmaHistogramSqliteResult is updated to take a const std::string ref
to match the underlying UMA functions being called.
BUG=1429117
Change-Id: I1bc2c898b005232305cebfde80a0dd8d4cfafd68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608890
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Will Harris <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157192}
Mark FeatureSwitch::command_line_ as dangling
Detected during unit_tests when built under the GN argument
use_asan_unowned_ptr=true. The test suite is destroying the
command line while FeatureSwitches still exist.
Bug: 1449286
Change-Id: Iad264696b271b478d18ca273a938972086de4bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611230
Commit-Queue: Tom Sepez <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157191}
WebUI: Leverage build_webui() in c/b/r/sandbox_internals/.
build_webui() is the canonical way of building WebUI pages, and
leveraging it brings many advantages, like JS minification.
Bug: 1431253,1132403
Change-Id: I9358c16ac855a98d857a6b73b455557fa0ed96fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606005
Code-Coverage: Findit <[email protected]>
Commit-Queue: Cole Horvitz <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Cole Horvitz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157190}
Roll ios_internal from cdcc9a378a9b to 982f063c939b
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/cdcc9a378a9b..982f063c939b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ib218ce800aa8a960d9f453b53846b94f9756cdf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610310
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157189}
[CustomTabActivityTest] Re-enable closeButton_closesActivityIfNoLandingPage
Re-enabling the tests as it is now not flaky and passing in test reviver.
Change-Id: Id8dfe3d0ac4d4036809954c9d4c94fd28a914ef6
Bug: 1148544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611327
Commit-Queue: Ritika Gupta <[email protected]>
Reviewed-by: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157188}
cr23: Update omnibox content settings icons.
The CL hooks up the cr23 icons for content settings. This CL adds new
icons where necessary (using the 20px size). This CL leaves the blocked
redirect icon unchanged since there is no clear cr23 icon at the moment.
Test: Navigate to permission.site. Click on all the permissions.
Bug: 1447073
Change-Id: I83bcacebf266a85b976bb5eb89cf63101c69fa42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607221
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157187}
Roll src/third_party/pdfium/ ba7701bc2..1b2a3b549 (4 commits; 1 trivial rolls)
https://pdfium.googlesource.com/pdfium.git/+log/ba7701bc2fdc..1b2a3b54907b
$ git log ba7701bc2..1b2a3b549 --date=short --no-merges --format='%ad %ae %s'
2023-06-13 kmoon Move alpha type conversion into RealizeSkImage()
2023-06-12 tsepez Cleanup at pdf fuzzer termination.
2023-06-12 pdfium-autoroll Roll Code Coverage from de759c9da836 to 8ec74a909da4 (6 revisions)
Created with:
roll-dep src/third_party/pdfium
Updated golden files for PdfToPwgRasterBrowserTest to reflect minor
rendering changes due to rounding differences in alpha calculations.
Bug: 1454485
Change-Id: I38bb9d69cb9f2fdf675abc013f8498fa4787780d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610648
Commit-Queue: Lei Zhang <[email protected]>
Auto-Submit: K. Moon <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157186}
[SuperSize] Viewer: Add utils for upcoming "#focus=..." feature.
This CL adds SuperSize Viewer utils to support an upcoming feature:
Write "#focus=..." in the URL to specify the active node in the Symbol
Tree, and read it on initialization to select the node. Details:
* Add dom.onNodeAdded(): This uses a temporary MutationObserver() to
detect when a Node is added to the DOM. When that happens, the given
|task| is called via requestAnimationFrame(). This will be used to
focus on an active Symbol Tree node during expansion and rendering.
* Add capability for states to use #hash, to be used for "#focus=...".
* QueryParamUiState: Add |isHash| member const to specify whether the
variable "key=value" should appear in "#hash" instead of "?query".
* MainState: Update toString() to write "#hash" for states with
|isHash|; update init() to read from "#hash" for these states.
* Add the idea of "active tree": Stipulate that one of {Symbol, Metrics,
Metadata} Trees is active, and that is only wrestled away from one
another, but NOT by other UI means (e.g., focusing on settings or
address bar). This will be used to hide "#focus=" if the Symbol Tree
loses active status (on "tree blur"). Changes are in TreeUi:
* Add |TreeUi.activeTreeUi| to track which tree is active.
* Add (for overriding) handlers onTreeFocus() and onTreeBlur().
* Add focus() to perform tree focus(), and as main workhorse to
manage "active tree" dynamics.
* Store |rootElt| as member const; in init(), bind click event to
|rootElt| to call focus().
* TreeUi refactoring:
* Extract getTreeItemFromLink() and getGroupFromLink() from
toggleGroupElement() for reuse and better abstraction.
* Extract autoExpandAttentionWorthyChild() from expandGroupElement():
It's the logic of "clicking on groups with only one child". In
upcoming work it will be overridden by SymbolTreeUi to do tree
expansion for "#focus=..." Symbol Tree node.
Bug: 1001769
Change-Id: Ifaee81535cd1138c897b78d887a077fd1ee8b14f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608206
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157185}
Roll Fuchsia Internal Images from 13.20230613.2.1 to 13.20230613.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I386a343ddaf2773ff795ea36c31f982f8acbddb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610976
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157184}
Extend histogram expiry: ContentSuggestions.Feed.ActivityLoggingEnabled*
Also update histogram ownership.
Bug: 1454143
Change-Id: Ie9e19494cbc416eaebb9a7e3c481f2f65fc11abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608208
Commit-Queue: Justin DeWitt <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Auto-Submit: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157183}
Migrate all tests on fuchsia-fyi-x64-asan to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I32a56eb643a866001148147083f2744233816064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611250
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157182}
Make survey controller reset public for tests
Required for testing in downstream: crrev.com/i/6037398
Bug: 1319600
Change-Id: I10a87ce63f749beda04bd6f066d512a4e3244188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609180
Commit-Queue: Theresa Sullivan <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Auto-Submit: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157181}
[Fixit] UndoBarController replace DisableIf with Restriction
Should be a restriction rather than a DisableIf.
Fixed: 1199023
Change-Id: Ic9448ba2bb4a6e6f44c77550b7a77f7d0573d347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610779
Commit-Queue: Theresa Sullivan <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157180}
Increase N5X trace_test sharding
Increases the amount of sharding for trace_test on Nexus 5X devices due
to increased overhead compared to other Android devices.
Bug: 1432275
Change-Id: Id39e12e5772d5a73841639d662ad7eccf411d4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609216
Auto-Submit: Brian Sheedy <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157179}
Migrate all tests on fuchsia-x64-rel to jammy
Note: this CL was automatically generated.
If this is suspected to have caused test regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: Ic6bf1c00fe575500c2c7d740e571ce7c2551c690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610803
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157178}
[PriceInsights] Add strings for omnibox icon
This CL adds strings for omnibox icons and price tracking descriptions,
as well as fixing an error of previously added string.
Bug: b:285026111, b:286097739
Change-Id: I40f079539d7a0e09763c2b0109825688a212c373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608945
Commit-Queue: Zhiyuan Cai <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157177}
[text-wrap-pretty] Fix `NGLineBreakStrategy`
This patch fixes the logic of `NGLineBreakStrategy` when:
* `CSSTextWrapBalanceByScore` is enabled (and therefore
`context->ScoreLineBreakContext()` is not null.)
* The block has `text-wrap: balance`.
* The block has too many lines and that the headline balancing
is disabled.
In this condition, when it is laying out the next line after
it gave up balancing, `initiate_balancing_` is `false` but
`use_score_line_break_` became `true`. This patch fixes
`use_score_line_break_` to be `false`.
This patch has no behavior changes because changes are under a
runtime flag.
Bug: 1451205
Change-Id: I235280454c7270500d9ecc8d6c8a3f9000a3df39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609829
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157176}
Add generationId to B&A AuctionData blob and collect group names
Add generationId to the B&A AuctionData blob. This UUID will be used
by the B&A server to rate limit requests.
This CL also changes BiddingAndAuctionSerializer::Build to also return
the names of the interest group added for parsing the response.
Bug: 1442274
Change-Id: I76692686b257af3d8b780ffc4a47c21cc30c4877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591169
Reviewed-by: Maks Orlovich <[email protected]>
Commit-Queue: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157175}
Fix reg value name for enrollment token.
Bug: 1454574
Change-Id: I332274468f23c2edf2938cf4a0e8f2613ce3380f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611103
Commit-Queue: S Ganesh <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Auto-Submit: Xiaoling Bao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157174}
[floss] Fix handling of Socket Accept errors
DoConnectionStateChange was not accounting for failures in the Accept
connection flow. Now, we first confirm both state and status are good,
and if not invoke an error callback.
Bug: b/286684158
Change-Id: Ic7ed2e8e5579779c50cf083c485b8298c140454c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609854
Commit-Queue: Jesse Melhuish <[email protected]>
Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157173}
Rewrite multi-screen window placement WPTs
Rewrite to support automated execution with chrome:
./wpt run chrome window-placement/*
Results should surface on https://wpt.fyi/results/window-placement
(need to remove '-manual' from existing filenames in a followup)
Split fullscreen tests for entering and moving fullscreen.
Harden window bounds and currentScreen checking, with polling :(
Lots of refinements and cleanup.
Bug: 1022988, 1338645, 1453772
Change-Id: I97b690407fdf8f292efff179fdda6cd680a65931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585644
Commit-Queue: Mike Wasserman <[email protected]>
Auto-Submit: Mike Wasserman <[email protected]>
Reviewed-by: Brad Triebwasser <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157172}
CR2023: Fix cr-toggle focus state.
Fixed: 1400862
Change-Id: I83acd36eefec7056bfafad89033e0be0e6b8254b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611326
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Cole Horvitz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157171}
added safe-search flag for Android integration
[email protected]
Change-Id: I07abbc93920f5e01cb7902d8da76dd531939e506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604672
Reviewed-by: Robert Ogden <[email protected]>
Commit-Queue: Thao Nguyen <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157170}
Modify caret horizontal boundary behaviour for ChromeOS web content.
The caret behaviour on ChromeOS is currently quite jumpy, especially at
the top and bottom of a textfield. The caret behaviour on Android seems
less jumpy, so tentatively change the ChromeOS blink::EditingBehavior
ShouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom to match the
Android behavior (if the TouchTextEditingRedesign flag is enabled).
This is mainly to allow UX to test for now. May end up keeping or
reverting this depending on what UX thinks of the change.
Bug: b:244116654, b:286322336
Change-Id: Ida499641d4e0f9f1bd644021b8dd9a34486ed9bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607990
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Michelle Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157169}
[heap] Cleanup blink gc plugin
The blink implementation of Oilpan no longer exists so we can remove
support for it from the clang plugin.
Drive-by: align stubs.h with actual implementation.
Bug: chromium:1056170
Change-Id: Ie1e2a0268874a39c1a9cc92a962c870a5a677348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604350
Commit-Queue: Omer Katz <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157168}
webauthn: skip single-account selector in the macOS+allowlist case.
Change-Id: I822a8689c3f92e1c0d5cead219f46418028f724e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4596417
Commit-Queue: Adam Langley <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157167}
Enable UI controls in kombucha_in_process_fuzzer
+ Drive by: have the server serve the fuzz testcase in an html content
Change-Id: I0fc7e9c04499067530a548a75f57f9a838680378
Bug: 1453887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606591
Reviewed-by: Brendon Tiszka <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Grace Park <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157166}
Roll Dawn from 8ab22d45da51 to 48a39ff9615d (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/8ab22d45da51..48a39ff9615d
2023-06-13 [email protected] [DawnLPM] Fuzz CreateShaderModule wgsl code
2023-06-13 [email protected] [tint] Rename pointer builders to 'ptr', match WGSL order
2023-06-13 [email protected] [tint][resolver] Fix short-circuiting of const identifiers
2023-06-13 [email protected] [tint][transform][hlsl] Fix bad materialization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I9619706d478fdce0ada7941be03ba732dc73644f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609214
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157165}
Roll earl_grey2 from 2e7e40ae19aa to d2717abfb03a (1 revision)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/2e7e40ae19aa..d2717abfb03a
2023-06-13 [email protected] Update eDO connection error in EarlGrey.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I2476616566516706ef10aafab03374967d12a49a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611127
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157164}
Android: Convert jni_generator annotation processor -> srcjar (part 2)
GN edits made via script. It refactors all files where:
* There is only one generate_jni and one android_library in a file
* Sources are assigned using a global variable
Bug: 1410871
Change-Id: I1b7b48d40d2a46803975e2a83d4926acc80b4f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609145
Auto-Submit: Andrew Grieve <[email protected]>
Reviewed-by: Sam Maier <[email protected]>
Owners-Override: Andrew Grieve <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157163}
Use a TestFuture instead of RunLoop & BindLambdaForTesting
This makes the code slightly simpler, though it is semantically
equivalent (and TestFuture relies on RunLoop under the hood).
Change-Id: Ida673ade01fe5a3f78b2b377d1a3a67a55ef5286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611306
Auto-Submit: Chris Fredrickson <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Commit-Queue: Shuran Huang <[email protected]>
Reviewed-by: Shuran Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157162}
Roll src-internal from 1159092e81ca to 3f4cf65e4cca (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1159092e81ca..3f4cf65e4cca
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1433407
Tbr: [email protected],[email protected]
Change-Id: I790c0c77dc7cbbd02174ac5a1442842249840e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606570
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157161}
[fuchsia] Add missing includes
See https://fxrev.dev/869997.
Bug: fuchsia:103032
Change-Id: I0c113d593f36c6e19688e4cb1b78f63ca3815f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610086
Commit-Queue: Tom Sepez <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Auto-Submit: Tamir Duberstein <[email protected]>
Commit-Queue: Tamir Duberstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157160}
Consolidate touch-action-with-swipe-dir-change.html expectations
This is a touch-only test, and is not expected to pass on Mac.
Fixed: 1453982
Bug: 613672
Change-Id: I1b0649210da64fd02ae21fe5073b42d9c8eaac3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611155
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157159}
Roll devtools-internal from c7069f35b34c to 531d074c5146 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/c7069f35b34c..531d074c5146
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ie00ea87c8cf3e00a7c59f6b458b691d13c746205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611128
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157158}
Revert "Roll src/buildtools/third_party/libc++/trunk/ 055b2e17a..38a8ad0f7 (89 commits)"
This reverts commit 70397380cad2bb8708c75d6d1911b77fe15728c8.
Reason for revert:
LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8778377406486383953
Sample failed build: https://ci.chromium.org/b/8778377406486383953
If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2F2.gy-118.workers.dev/%3A443%2Fhttps%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8778377406486383953&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2F2.gy-118.workers.dev/%3A443%2Fhttps%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4604488
Original change's description:
> Roll src/buildtools/third_party/libc++/trunk/ 055b2e17a..38a8ad0f7 (89 commits)
>
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/055b2e17ae4f..38a8ad0f7ea6
>
> $ git log 055b2e17a..38a8ad0f7 --date=short --no-merges --format='%ad %ae %s'
> 2023-05-23 koraq [libc++] Fixes clang-tidy plugin for clang-tidy 17.
> 2023-05-24 nikolasklauser Revert "[libc++] Apply _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION only in classes that we have instantiated externally"
> 2023-05-17 koraq [libc++][format] Removes the experimental status.
> 2023-04-20 koraq [libc++] Untangles invoke.
> 2023-05-20 koraq [libc++] Adds C++26 support.
> 2023-05-23 ldionne.2 [libc++][NFC] Refactor helper method into the Lit test format
> 2023-05-11 ldionne.2 [libc++] Complete refactor of tests for operator new
> 2023-05-23 n_klauser [libc++] Apply _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION only in classes that we have instantiated externally
> 2023-05-23 a3at.mail [libcxx][tests] Introduce 32-bit feature and use it for stringstream gcount test
> 2023-05-07 koraq [libc++][doc] Updates the tasks to do for a release.
> 2023-05-17 koraq [NFC][libc++][format] Uses stringstream::view.
> 2023-02-28 koraq [libc++][modules] Adds std module cppm files.
> 2023-05-17 koraq [libc++] Updates C++2b to C++23.
> 2023-05-23 nikolasklauser [libc++] Remove tests from ranges.pass.cpp which violate semantic requirements
> 2023-05-23 n_klauser [libc++][NFC] Move basic_ios extern instantiations into <ios>
> 2023-05-23 nikolasklauser [libc++][NFC] Fix whitespace problems in the files added to ignore_format.txt in D151115
> 2023-05-22 kazu [libc] Fix typos in documentation
> 2023-05-22 nikolasklauser [libc++] Fix ignore_format.txt list
> 2023-05-20 a3at.mail Do not run gcount test on any *armv7l* (fixes test on llvm-clang-win-x-armv7l)
> 2023-05-18 ldionne.2 [libc++] Fix issue with std::map::find in Objective-C++ with modules
> 2023-05-16 n_klauser [libc++] Install GCC 13 in the docker containers
> 2023-02-09 koraq [libc++][format] Improves fill character.
> 2023-05-18 zingam [libc++][ranges][NFC] Added P2711R1 to release notes
> 2023-05-17 n_klauser [libc++][NFC] Rename iterator category checks to make it obvious that they check //only// the iterator category
> 2023-05-17 ldionne.2 [libc++] Avoid dereferencing a const iterator in std::sort
> 2023-05-18 yronglin777 [libc++] Implement P2505R5(Monadic operations for std::expected).
> 2023-05-18 yronglin777 Revert "[libc++] Implement P2505R5(Monadic operations for std::expected)."
> 2023-05-16 ldionne.2 [libc++][NFC] Rename the 'noexceptions' CI config to 'no-exceptions' for consistency
> 2023-05-17 a3at.mail [libcxx] Fix crash in std::stringstream with payload >= INT_MAX
> 2023-05-16 zijunzhao [libc++] Improve ranges::starts_with
> 2023-05-17 yronglin777 [libc++] Implement P2505R5(Monadic operations for std::expected).
> 2023-05-17 thakis Revert "Reland "[CMake] Bumps minimum version to 3.20.0.""
> 2023-05-17 varconsteq [libc++][ranges] Implement the changes to `deque` from P1206 (`ranges::to`):
> 2023-05-09 hui.xie0621 [libc++] Utilities for implementing stop_token
> 2023-05-16 crtrott [libcxx] Add mdspan/extents
> 2023-05-16 fox [libc++] Add C++20 stringstream::view()
> 2023-05-07 koraq [libc++][format] Removes format sources.
> 2023-05-12 martin [libcxx] [test] Improve error reporting around invoked commands
> 2023-05-15 nikolasklauser [libc++][PSTL] Implement std::copy{,_n}
> 2023-05-15 ldionne.2 [libc++] Revert moving the pre-release checklist
> 2023-05-15 ldionne.2 [libc++][NFC] Reformat test
> 2023-05-15 ldionne.2 [libc++][NFC] Use angle brackets to include ranges_mismatch.h
> 2023-05-07 koraq [libc++] Removes _LIBCPP_ABI_OLD_LOGNORMAL_DISTRIBUTION
> 2023-05-08 zijunzhao [libc++] Implement ranges::starts_with
> 2023-05-15 nikolasklauser Revert "[libc++][PSTL] Implement std::copy{,_n}"
> 2023-05-15 ldionne.2 [libc++][docs] Move the pre-release check-list
> 2023-05-05 n_klauser [libc++][PSTL] Implement std::copy{,_n}
> 2023-05-15 nikolasklauser [libc++][PSTL] Implement std::transform
> 2023-05-15 nikolasklauser Revert "[libc++][PSTL] Implement std::transform"
> 2023-05-05 n_klauser [libc++][PSTL] Implement std::transform
> 2023-04-20 koraq [libc++] Moves unwrap_reference to type_traits.
> 2023-05-12 iana [libc++][PSTL] Make the PSTL submodules only have one header
> 2023-05-11 n_klauser [libc++][NFC] Use _LIBCPP_STD_VER instead of __cpp_lib_atomic_is_always_lock_free
> 2023-05-13 koraq Reland "[CMake] Bumps minimum version to 3.20.0."
> 2023-05-06 koraq [NFC][libc++][format] Tests formatter requirements.
> 2023-05-09 n_klauser [libc++][PSTL] Move the already implemented functions to the new dispatching scheme
> 2023-05-09 hui.xie0621 [libc++][ranges] Fix `iota_view`'s constructor's incorrect constraint
> 2023-05-06 koraq [NFC][libc++][format] Uses uniform member signatures.
> 2023-05-07 koraq [clang][ci] Improves buildkite artifacts.
> 2023-05-09 ldionne.2 [libc++][PSTL] Add more specialized backend customization points
> 2023-03-13 john.brawn [libc++] Adjust tests using ext/* headers that undefine __DEPRECATED
> 2023-05-07 iana [libc++][PSTL] Add missing includes to PSTL headers
> 2023-05-10 rupprecht [libc++] Consistently enable __CORRECT_ISO_CPP_WCHAR_H_PROTO in mbstate.
> 2023-05-10 ldionne.2 [libc++][NFC] Remove duplicate declaration of __iter_value_type
> 2023-05-10 ldionne.2 [libc++][NFC] Fix slightly incorrect instructions for testing with Ninja
> 2023-05-10 aaron [libcxx] Fix pstl __init_ identifier after 9c4717a
> 2023-05-09 n_klauser [libc++][PSTL] Move the remaining configuration into __config
> 2023-03-28 ldionne.2 [libc++] Add assertions for potential OOB reads in std::sort
> 2023-05-08 ldionne.2 [libc++] Provide an assignment operator from pair<U, V> in C++03
> 2023-05-08 varconsteq [libc++][ranges] Implement the changes to vector from P1206 (`ranges::to`):
> 2023-05-08 5326451+jakeegan [AIX] Adjust support of format function tests
> 2023-05-08 5326451+jakeegan [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test
> 2023-05-06 zingam [libc++][spaceship] Implement `operator<=>` for `array`
> 2023-05-08 ldionne.2 [libc++] Fix mistake in documentation of libcxx-lit script
> 2023-05-07 nikolasklauser [libc++] Use the __is_trivially_equality_comparable builtin
> 2023-05-06 iana [libc++][Modules] Add missing includes and exports
> 2023-05-06 iana [libc++] test/libcxx/transitive_includes.sh.cpp dumps loads of unhelpful preprocessor output when it fails
> 2023-05-07 koraq Revert "[libc++] Soft-fail the two sanitizer jobs that have been failing in CI for a while"
> 2023-05-06 koraq [libc++] Modernizes the forwarded ios headers.
> 2023-01-21 koraq [libc++][ranges] Addresses LWG3759
> 2023-05-06 koraq Revert "Reland "[CMake] Bumps minimum version to 3.20.0.""
> 2023-04-20 koraq [libc++][format] Fixes vector<bool> requirements.
> 2023-05-06 koraq Reland "[CMake] Bumps minimum version to 3.20.0."
> 2023-05-06 vitalybuka Revert "[2a/3][ASan][libcxx] std::deque annotations"
> 2023-05-05 n_klauser [libc++][PSTL] Make the PSTL available by default under -fexperimental-library
> 2023-05-05 ldionne.2 [clang][ci] Upload artifacts in a tarball to reduce size and avoid symlink issues
> 2023-05-05 advenam.tacet [2a/3][ASan][libcxx] std::deque annotations
> 2022-11-24 ldionne.2 [libc++] Remove Solaris related code
> 2023-04-28 zingam [libc++][spaceship] Implement `operator<=>` for `optional`
>
> Created with:
> roll-dep src/buildtools/third_party/libc++/trunk
>
> Binary-Size: New OOB assert in std::sort (crbug.com/1453569#c6).
> Fuchsia-Binary-Size: Same.
> Bug: 1453569
> Change-Id: I52e762bbdb5734ad19f4482efc00a28102c487a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604488
> Commit-Queue: Tao Wu <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1157098}
>
Bug: 1453569
Change-Id: I9214063858338dba0e4c4a065b04e3eddec48873
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610311
Commit-Queue: [email protected] <[email protected]>
Owners-Override: [email protected] <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157157}
Revert "Disable test to land crrev.com/c/4607248"
This reverts commit b51dc9cf35192bc276535f907f46a37aaf8d8af0.
Reason for revert: Not needed
Original change's description:
> Disable test to land crrev.com/c/4607248
>
> Bug: 4607248
> Change-Id: I536f1885e23328c9ea7971960be2b05606f94e5e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607251
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: Danil Somsikov <[email protected]>
> Commit-Queue: Danil Somsikov <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156860}
Bug: 4607248
Change-Id: Iffadae3321ed379039ae2e6e286d321076e148e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608059
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157156}
Roll Perfetto from d019594d65a2 to 57cd2bc9b473 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/d019594d65a2..57cd2bc9b473
2023-06-13 [email protected] Merge "ipc: infer socket family from address"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ib0759adad0c11309a2404db5afae7e75bf9e8e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608719
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157155}
Add logic to get student assignments based on different filters
Added methods:
- IsStudentRoleActive,
- GetCompletedStudentAssignments,
- GetStudentAssignmentsWithApproachingDueDate,
- GetStudentAssignmentsWithMissedDueDate,
- GetStudentAssignmentsWithoutDueDate.
Bug: b/283369115
Change-Id: I92f4b3de59d6d9abceba695bb05bc6a5f38d3e60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604029
Commit-Queue: Artsiom Mitrokhin <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157154}
Remove GpuRasterizationStatus enum
The GpuRasterizationStatus enum used by cc only has two states, on or
off, so it exactly matches the `use_gpu_rasterization` bool.
Bug: 1442970
Change-Id: I1c6f50e06b673dc23e0a20965437a427fd5fe315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610687
Commit-Queue: Kyle Charbonneau <[email protected]>
Reviewed-by: Sohan Jyoti Ghosh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157153}
Manual raw_ptr rewrite: cc/paint/decode_stashing_image_provider.h
This is a partial / single-file reland of https://crrev.com/c/4548763.
More granular CLs will hopefully help pinpoint which of the changes in
the original CL is responsible for the performance regression.
Bug: 1448053, 1446392
Change-Id: I243a9e6f645b2878c59caddac7b4441c084e45c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583350
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157152}
[Frameworks roll] Roll to 540026547 piper revision
Change-Id: I9d69959ffb46c3060a0d3e95e5368dd6f85566cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611271
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157151}
[FedCM] Align mismatch dialog with latest redlines
Screenshot is available on
https://bugs.chromium.org/p/chromium/issues/detail?id=1430830#c29
Redlines are available on slide 12
https://docs.google.com/presentation/d/1g3I2uuV_9NS0QBKHKODArlJVWRVtHX5SlrG43EB_ZVc/edit?usp=sharing&resourcekey=0-oHaT6u-l3_fTEEgS3QRQlA
Bug: 1430830
Change-Id: I6b028d856a0d4cf30fe2574e17ec8ded43ea7524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611107
Reviewed-by: Nicolás Peña <[email protected]>
Commit-Queue: Zachary Tan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157150}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686635928-bc283fb9a126d45ee82f6c2ab113bcbaff2108f1.profdata to chrome-linux-main-1686679195-33c434849e7a07bda6014953a718b27a46cc63a8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I5a07655610a5aac4250628e9b3308fb0e33d613c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610877
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157149}
Avoid reference to deleted temporary in MockIsolatedWebAppTrustChecker()
The current constructor creates a temporary TestingPrefServiceSimple(),
passes it by reference to IsolatedWebAppTrustChecker(), which stores
it by reference in a member variable. Upon return from the constructor,
the temporary is destroyed and we have a invalid reference from the
moment construction finishes.
Due to order of initialization and destruction, we can't simply make
the TestingPrefServiceSimple a member of MockIsolatedWebAppTrustChecker
so instead use the trick of making it the first base class so that it
will outlive the second base class using it.
Bug: 1401495
Change-Id: Ic2554c7b98ffd70db93a2efac1f4b2a13b827315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601512
Reviewed-by: Christian Flach <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157148}
media: Stop using VF::GetWritableVisibleData() where writes are not expected
OpenH264, VPX and AV1 encoders don't write into frame data, that's why
visible_data() should be used instead of GetWritableVisibleData().
It fixes the check crash for shared memory frames.
Bug: 1453870
Change-Id: Id42a31974e75022f41196d79598e6000c8d8c3a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609186
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157147}
WebUI: Remove {add,remove}ColorChangeListener helpers.
These helpers were kept around as a temporary step. They no longer add
much value after introducing the ColorChangeUpdater class and after
exposing an EventTarget to listen for events, and are removed to keep
the API as lean as possible.
Bug: 1450109
Change-Id: I08f319a2e32f580baae2ac74c1d29e537f1a501d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609466
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157146}
scanning: Add models to flip exclusion list
Two additional models requested by Epson.
Bug: b:283886213
Change-Id: If2a6daec416f851626794b653bf9a76cbd74ff67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610074
Commit-Queue: Benjamin Gordon <[email protected]>
Reviewed-by: Paul Moy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157145}
webcodecs: Avoid integer overflow in libaom
AV1 encoder internally uses int32 for some bitrate variables.
Bug: 1451998
Change-Id: Ifaf59c67a8405f4852350eb66364b6fbc42d9257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607033
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157144}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686657517-dfc3ec36cfe59c606c3820dc0b1500d86a337274.profdata to chrome-win64-main-1686668293-c4b3e9dce845e20304e086624abe74f854c3cf2d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I9b44335e98a1243562e6a886b8aa52bf037d3b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610741
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157143}
[FedCM] Fix a console error message
Noticed while writing the devtools patches to show the issues.
Bug: 1451001
Change-Id: I8ca7a4644e59b413217ab10161569eac5876adbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603327
Auto-Submit: Nicolás Peña <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157142}
Various fixes for riscv64 compilation rules
* Adds 'riscv64' to clang and sanitizer arch variables.
* Use sysroot when building for 'riscv64'.
* Use ldd (not gold) when building for 'riscv64'.
Test: Verified against local toolchain build of Cronet for riscv64.
Change-Id: I0a3e2583c9804a40ef1dd65e7541bdbd2d88df6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605786
Auto-Submit: Prashanth Swaminathan <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157141}
infra: Move builds on linux_optional_gpu_tests_rel to jammy
Jammy pool is up:
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=builder%3Alinux_optional_gpu_tests_rel&f=cores%3A8&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.try&f=os%3AUbuntu-22.04&k=os&s=id
Tested on led:
https://ci.chromium.org/swarming/task/62ce7e5fcf417510?server=chromium-swarm.appspot.com
Bug: 1412588
Change-Id: Icc2296bdc048021a94a2c38e72f960b2af9cc75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609851
Commit-Queue: Ben Pastene <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157140}
Fix webview OOP software draw
It was always being throttled because invalidate after draw count wasn't
being reset.
Change-Id: Ic691309838776430e08df7cba9a1531f33a73d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605167
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Bo Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157139}
Convert /ui/base:unittests to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Note that this change ropes in ARCing of ViewTreeValidator and
its caller, as that passes around a struct containing Objective-C
pointers, and it was easiest to just include it all here.
Bug: 1280317
Change-Id: Ibba83b88720502f007c1b3907bfc7f5c6f44f585
Include-Ci-Only-Tests: true
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544540
Auto-Submit: Avi Drissman <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157138}
Printer settings: Correct printer status crash
Fetching printer statuses from printers is an async process whose
duration depends on a printer's response time. If a printer status is
requested, then Printer settings is manually refreshed, the printer
status response can come before Printer settings is ready and causes a
crash.
Bug: b:278621575
Tests: Local testing
Change-Id: Id998f2922aa7476c5fa0388034ba4842b75070d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609969
Commit-Queue: Gavin Williams <[email protected]>
Reviewed-by: Xiangdong Kong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157137}
Fix gtest filter to support finding tests without sdk
Bug: 1383650
Change-Id: I1a92ebd83ebd982856ec6c598af6ec363558448d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609971
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Benjamin Joyce (Ben) <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157136}
Reland: Fix failed test offscreencanvas_transferrable.html
Currently, when transfer offscreencanvas to worker and offscreencanvas
already has a rendering context or the same offscreencanvas is
transferred twice, the data clone error is thrown. According to the
spec, the invalid state error should be thrown instead.
This change was reverted because the test failed on mac arm64
machines. This is expected because the webgl context is not available
in the arm64 virtual machine. So the exceptions are not thrown. Add the
webgl as its own test and mark it expected to fail on arm64.
revert:
https://chromium-review.googlesource.com/c/chromium/src/+/4583648
Bug: 1448662
Change-Id: I661a23817f372753f715dcc281a77bbcc076ca4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4590730
Commit-Queue: Yi Xu <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Reviewed-by: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157135}
Tracking previously installed apps across sessions
This change configures the app events observer to also track app
installs in the user pref store as it is notified of them. This enables
us to filter out apps that were previously installed and only report the
ones that are new.
This will be subsequently succeeded by the unified app storage that will
track all app metadata in the app service which will filter out
previously installed apps from being reported.
Bug: b:286295722
Change-Id: I896c19a2d7c61118263150429b4336e6fba98c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599129
Reviewed-by: Leonid Baraz <[email protected]>
Reviewed-by: Ahmed Nasr <[email protected]>
Commit-Queue: Vignesh Shenvi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157134}
Update baseline.hanging test case
The font canvasTest looks like this (first block):
https://bugs.chromium.org/p/chromium/issues/detail?id=1066953#c11
(size 50, render text at 0, 50, horizontal line at y=50)
The letter C, has a top part above the green square. So, If we render
ABCDE with baseline=hanging, it doesn't start the green square (what the
test case expected). This is shown in the second block of text.
Update the test case to reflect it.
Bug: 1066953
Change-Id: I65fccabf47f847c9faa4e52b7eb894cf187638cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608187
Reviewed-by: Justin Novosad <[email protected]>
Commit-Queue: Yi Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157133}
[tracing] Implement background tracing RepeatingIntervalRule
Bug: 1418116
Change-Id: I32eefff1100f3509087d852ca0ac31ce7770e1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4467450
Reviewed-by: Eric Seckler <[email protected]>
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157132}
Enable Lens in NTP by default.
Bug: 1448973
Change-Id: I757d843025a891e72772d09b02e5674d9782efb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569083
Reviewed-by: Roman Arora <[email protected]>
Commit-Queue: Yo Wakita <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157131}
Convert browser_tests and /chrome/test:test_support_ui to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: Id97e1df559b86b8ed22ecde3ea7b59f8a6354b26
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599000
Reviewed-by: Leonard Grey <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Code-Coverage: Findit <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157130}
Implement VA_Buffer Functions
Previously the functions for the creation and mapping of va_buffers in
the fake driver were left unimplemented. As the fake driver is being
updated to do software decoding, logic is needed for buffer management.
Creates a |FakeBuffer| class to implement va_buffer management. Updates the fake driver to manage the life cycle of va_buffers using ObjectTracker<FakeBuffer>. Finally, this updates the fake_drv_video to implement creation/destruction of VABuffer as well as to implement MapVABuffer based on the FakeBuffer class implementation.
This update will not result in successful decoding however the decoding
processes will be able to allocate and use va_buffers now.
./video_decode_accelerator_tests crowd_run_256X144_fr15_bd8_sub8X8_l1.ivf
--v=4
BUG: b:261660716
Test: LD_LIBRARY_PATH=./ LIBVA_DRIVERS_PATH=./ LIBVA_DRIVER_NAME="libfake"
Change-Id: I38f59dc91ebf090d0d3f4519cbe9a72efa4e671a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4589411
Reviewed-by: Pilar Molina Lopez <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Bijan Choobineh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157129}
Roll src-internal from 5add04205f38 to 1159092e81ca (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5add04205f38..1159092e81ca
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1431232
Tbr: [email protected],[email protected]
Change-Id: Id4f7f29463530642dfe91df12fd3b88aae213af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609212
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157128}
CSC: Add the Eligibility library + unit tests.
Design doc: go/csc-eligibility-ranking
Change-Id: Ia57a998064d4f43da627c87c599bda8840489abb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601988
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Lily Mihalkova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157127}
Convert /device/bluetooth to use ARC
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
for information about this conversion.
Bug: 1280317
Change-Id: Iab28dde06fa8e9792d435aaa1b5ca06f1fce66d1
Include-Ci-Only-Tests: true
Cq-Include-Trybots: luci.chromium.try:ios-blink-dbg-fyi
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Validate-Test-Flakiness: skip
Low-Coverage-Reason: Doing core refactoring across all of Chromium; I do not own this code
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606137
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157126}
Addressing a Linux crash in WebrtcDataStreamAdapter::InvokeOpenEvent
The top crash report for the Linux host appears to be a race condition
between WebrtcDataStreamAdapter::Start() being called (where the
event_handler_ member is set) and the InvokeOpenEvent() callback being
run which is posted from OnStateChange() which is handling an event from
|channel_|.
The stack trace doesn't have any info to indicate which data channel was
being opened so but the crash to user ratio is pretty close to 1:1 so I
think it's truly a race condition and not a specific code path.
Bug: 1454494
Change-Id: Id097c167c55f91c3a25a2b61c9805b83e671a5c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609093
Reviewed-by: Lambros Lambrou <[email protected]>
Commit-Queue: Joe Downing <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157125}
PrivacyIndicators: Fix launching settings for web app
Launching web apps (PWA, system web app, etc.) need to use a different
code path for launching settings from the privacy indicators
notification.
Fixed: b:257554006
Change-Id: Ibc4f93a3a07546643d4f4f99d6fb1a4d9bdbdbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598997
Commit-Queue: Andre Le <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157124}
Adding DSE to fulfillment info.
Bug: b/283102841
Change-Id: I6eff006295bc2baf2134f020acf8bd01314c1986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599675
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Dan H <[email protected]>
Commit-Queue: Jonathan Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157123}
Require top-level user interaction for new Storage Access permissions
Bug: 1454093
Change-Id: I436dfc8284a6583b993d2b97d5a523821f57cc71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605123
Commit-Queue: Chris Fredrickson <[email protected]>
Reviewed-by: Shuran Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157122}
Create the CBOR data decoder implementation.
This will be used when we complete auction in browser.
Related resources:
https://github.com/WICG/turtledove/blob/main/FLEDGE_browser_bidding_and_auction_API.md#step-4-complete-auction-in-browser
https://github.com/WICG/turtledove/pull/602
Bug: 1442274
Change-Id: If35959def123d3cc30ed7ef0366fc9a186cbbfa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595558
Reviewed-by: Russ Hamilton <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Youssef Bourouphael <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157121}
[StartTablet] Fix "continue browsing" is still shown when tab is closed.
This bug was caused when a Tab to track is set to the SingleTabCoordinator after it has been created, while the lastActiveTab
isn't updated. Demo:
https://drive.google.com/file/d/1cdPdqda9tpDUmsrk9gV_ERfE-ocEIbwQ/view?usp=drive_link
Bug: 1454357
Low-Coverage-Reason: The changes of SingleTabSwitcherCoordinator are tested in StartSurfaceOnTabletTest.
Change-Id: Ib47cdb6a8394932c44a093c79e5c44c834be61da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607064
Reviewed-by: Xinyi Ji <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157120}
Reduce SubresourceResponseStarted IPC by sending subresource
notifications only if the user has allowed HTTPS-related exceptions.
WebContents sends the updated renderer_preferences to the renderers:
1. At the startup of a renderer to inform whether any HTTPS related
warning exceptions has been allowed by the user in the past
2. When the user allows a new certificate or HTTP exception - all
renderers are updated by the browser process.
In case of an certificate exception, the renderers start sending
SubresourceResponseStarted IPC. When all exceptions are revoked, the
renderers are not explicitly signalled to stop sending
SubresourceResponseStarted IPC.
Mini-Design doc:
(https://docs.google.com/document/d/11kzl0_tIzmvOCR7dv28BatxoPO0tk83e-HAPM0HdHZ4/edit?usp=sharing)
Bug: b/257281761
Change-Id: I0bcef03d07f3ddde7174d272b90eafa39fbdcc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4075955
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Aman Verma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157119}
Remove filter for testParseVideoH264
The filter is ineffectual - the test file is ThumbnailMediaParserTest,
not DownloadMediaParserTest. I have verified this test is running
and passing on android-pie-arm64-rel.
Bug: 963898
Change-Id: Idf61a2ad678e6af2d42935f6d598d0e30c1ab268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610168
Reviewed-by: Henrique Nakashima <[email protected]>
Commit-Queue: David Maunder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157118}
Enable Favicon cache to reduce image flicker.
This change allows LargeIconBridge to use up to 512KB of RAM to cache
favicons for websites matching User's input.
The change ensures that we also don't create or initialize Image
fetcher (or favicon fetcher) on low end devices, where image fetching
is already suppressed, and favicon caching would make chrome less
stable.
Change-Id: Ia2a5cd9cb61b6284235134ef8c1e753654e0a153
Fixed: 1454024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609533
Reviewed-by: Patrick Noland <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157117}
Disable benchmark_smoke_unittest.BenchmarkSmokeTest.memory.desktop
This test is currently blocking LKGM
Bug: b/286898261
Change-Id: I461cbae250f7050b07b6ae73d6f2ee2c1f1f6aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603681
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Owners-Override: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157116}
Add GCP option for aggregation coordinators
The default origin used for GCP is just a placeholder and will be
updated when available.
Bug: 1450241
Change-Id: Id0d6668b7152f845137c9ac201b67446fa3b937d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602272
Reviewed-by: Alex Turner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157115}
usb: Combine USBDevice::controlTransferOut implementations
Rather than having two different implementations of this method we can
make the `data` parameter optional in one and share the rest of the
logic.
This makes it easier to get full test coverage. Similarly, an
unreachable buffer size check has been removed.
Change-Id: I03edc410049dfef2d0293d82d4fe096267fc0cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609979
Commit-Queue: Reilly Grant <[email protected]>
Commit-Queue: Sina Firoozabadi <[email protected]>
Reviewed-by: Sina Firoozabadi <[email protected]>
Auto-Submit: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157114}
[Color correction] Adds color correction to a11y quick settings
Adds color correction toggle to accessibility quick settings
menu unless there is no logged in user. The first time
color correction is enabled, the os://settings page for
color correction will be opened.
Screenshot: screenshot/5zyWR6KHFKTgCNN
Design: go/cros-color-filtering
Bug:b/259372272
AX-Relnotes:N/A
Test:New
[Color correction] Updates color correction settings per mocks
This change removes unused color correction settings that will
not be part of the final feature, and updates the color
correction part of os://settings to match the mocks.
Color correction is behind a flag while it is being developed,
so removing these prefs shouldn't cause any issues as they were
only available with the flag.
Screenshots:
Light mode: screenshot/9gbAZJ92WzvEYEy, screenshot/7Vm6BfFVQioifqz,
Dark mode: screenshot/5QDuRnQ834wSQ38
AX-Relnotes: N/A
Bug: b/259372272
Change-Id: Ia5b34b14717efb5c792d692505ac85a7c3efc53b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606062
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157113}
Front buffer rendering detection in ozone
Canvas2d does not currently map to |SCANOUT_FRONT_RENDERING| even
when the |desynchronized| parameter is specified [1]. This will
result in visual artifacts as a compressed backing (gbm) does not
allow for a clean asynchronous scanout.
[1]
https://developer.chrome.com/blog/desynchronized/
Example of desynchronized canvas2d:
https://mitoshima.github.io/mytest/d-canvas/main.html
Bug: 1442222
Change-Id: I3f834b6ee806518694f015c35be219e8e980b3ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603762
Commit-Queue: Peter McNeeley <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157112}
infra: Sort lib/linux-default.json
Got the sorting wrong in crrev.com/c/4610167. Whoops.
Bug: None
Change-Id: I3667c057c01e5506ca6a33e57f3f633462792ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611226
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157111}
Android: Fix android_aar_prebuilt ignore resource deps
When finding the transitive set of all resource targets, some dependency
edges are not followed by write_build_config.py. Specifically:
* I resource target that depends on a library target.
For android_aar_prebuilt, the android_resources sub-target was not
adding invoker.deps, which means that if an android_resources target
depends on an android_aar_prebuilt target, it would not inherit
transitive resource deps.
Bug: None
Change-Id: Ifa9d272c5c80d6d89b0b6a17135a3711a399b028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611090
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157110}
Add //build/gn_ast: A tool to refactor BUILD.gn files
Bug: 1410871
Change-Id: I03b0d4961f17db614c3fd3a6da3f698dabd17185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580788
Reviewed-by: Sam Maier <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157109}
Use transform node's scroll offset to place sticky layers.
In crrev.com/1122033 we made TransformTree::StickyPositionOffset get the
scroll offset from the scroll tree instead of the transform tree.
That's wrong for a main-repainted scroll, which updates the scroll tree
eagerly. Using the transform tree to compute the sticky offset ensures
that the composited sticky element stays in sync with the scrolling
contents, which are repainted with the next main frame + commit.
Bug: 1451203
Change-Id: Id3d313d11b7200b066933bd44ebf618b327af7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605365
Commit-Queue: Steve Kobes <[email protected]>
Reviewed-by: David Awogbemila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157108}
Roll Perfetto from bc462e6d73d2 to d019594d65a2 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/bc462e6d73d2..d019594d65a2
2023-06-13 [email protected] Merge "trace_processor: parse mdss events"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I6e56f848525a0f4baac2209493f2d54cfa026bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606567
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157107}
Roll WebRTC from 61deed569671 to 1f235d6efe85 (1 revision)
https://webrtc.googlesource.com/src.git/+log/61deed569671..1f235d6efe85
2023-06-13 [email protected] Roll chromium_revision 2710d66105..6f33bc2255 (1156780:1156959)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I13cb147e58cf5cb5fa880d96e0b7830939601d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610870
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157106}
[iOS] Convert suggestion_controller.js to TypeScript
Bug: 1380545
Change-Id: I8cbd0cb275d2b34dbe7634d9a9dc41cff22b41c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585027
Reviewed-by: Mike Dougherty <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Daniel White <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157105}
[iOS][DefaultBrowser] Improvements to General DB Promo metrics
In this CL:
- Record in IOS.DefaultBrowserFullscreenPromo histogram when user dismisses promo by swipe down
- Split "Dismiss" user action into "Cancel" (by pressing "no thanks" button) and "Dismiss" by swipe down
- Record in UMA histograms every time promo is shown
- Notify FET, that promo is shown only once on start
- Increment promo displayed count only when promo is shown
Change-Id: I1a4d80744829d336d4f02b9a496aa08ed67f2d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582873
Commit-Queue: Gayane Petrosyan <[email protected]>
Reviewed-by: Cheick Cisse <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157104}
Roll Open Screen from b4e1977e3623 to a3689b39e7d0 (1 revision)
https://chromium.googlesource.com/openscreen.git/+log/b4e1977e3623..a3689b39e7d0
2023-06-13 [email protected] [OpenScreen] Replace TaskRunner* with TaskRunner& in util/ directory
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I3b051b0cf601bfc8cdcd0a29a20daecf4068062f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611030
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157103}
Roll RTS model from zeYqXvuMMPbAg-KKh... to 8lKx6IDFtNPp1wUoE...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: If9b88f82ac19dca08f23cf8ea2b8d0ae56236d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609268
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157102}
CHECK initial pixel size in client
Add a CHECK that verifies initial pixel span is at least the minimum
required size.
Bug: 1447106
Change-Id: I843ab2eb82d28c5055baee2d5c6c3e1aff7a0226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4549722
Reviewed-by: Saifuddin Hitawala <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157101}
[Policy templates] Fix typo in back/forward cache policy.
Change-Id: Ia786f69fce63328409dc179d16cbd0d22fb22a66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607159
Auto-Submit: Igor Ruvinov <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Commit-Queue: Igor Ruvinov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157100}
Create a skylab fyi tester
To test the builder/tester split change made here:
https://crrev.com/c/4583642
This will be rolled back after verifying the change
Bug: 1453448
Change-Id: If39b723534ab79fd0b162a865088503a8601e87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595757
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Struan Shrimpton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157099}
Roll src/buildtools/third_party/libc++/trunk/ 055b2e17a..38a8ad0f7 (89 commits)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/055b2e17ae4f..38a8ad0f7ea6
$ git log 055b2e17a..38a8ad0f7 --date=short --no-merges --format='%ad %ae %s'
2023-05-23 koraq [libc++] Fixes clang-tidy plugin for clang-tidy 17.
2023-05-24 nikolasklauser Revert "[libc++] Apply _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION only in classes that we have instantiated externally"
2023-05-17 koraq [libc++][format] Removes the experimental status.
2023-04-20 koraq [libc++] Untangles invoke.
2023-05-20 koraq [libc++] Adds C++26 support.
2023-05-23 ldionne.2 [libc++][NFC] Refactor helper method into the Lit test format
2023-05-11 ldionne.2 [libc++] Complete refactor of tests for operator new
2023-05-23 n_klauser [libc++] Apply _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION only in classes that we have instantiated externally
2023-05-23 a3at.mail [libcxx][tests] Introduce 32-bit feature and use it for stringstream gcount test
2023-05-07 koraq [libc++][doc] Updates the tasks to do for a release.
2023-05-17 koraq [NFC][libc++][format] Uses stringstream::view.
2023-02-28 koraq [libc++][modules] Adds std module cppm files.
2023-05-17 koraq [libc++] Updates C++2b to C++23.
2023-05-23 nikolasklauser [libc++] Remove tests from ranges.pass.cpp which violate semantic requirements
2023-05-23 n_klauser [libc++][NFC] Move basic_ios extern instantiations into <ios>
2023-05-23 nikolasklauser [libc++][NFC] Fix whitespace problems in the files added to ignore_format.txt in D151115
2023-05-22 kazu [libc] Fix typos in documentation
2023-05-22 nikolasklauser [libc++] Fix ignore_format.txt list
2023-05-20 a3at.mail Do not run gcount test on any *armv7l* (fixes test on llvm-clang-win-x-armv7l)
2023-05-18 ldionne.2 [libc++] Fix issue with std::map::find in Objective-C++ with modules
2023-05-16 n_klauser [libc++] Install GCC 13 in the docker containers
2023-02-09 koraq [libc++][format] Improves fill character.
2023-05-18 zingam [libc++][ranges][NFC] Added P2711R1 to release notes
2023-05-17 n_klauser [libc++][NFC] Rename iterator category checks to make it obvious that they check //only// the iterator category
2023-05-17 ldionne.2 [libc++] Avoid dereferencing a const iterator in std::sort
2023-05-18 yronglin777 [libc++] Implement P2505R5(Monadic operations for std::expected).
2023-05-18 yronglin777 Revert "[libc++] Implement P2505R5(Monadic operations for std::expected)."
2023-05-16 ldionne.2 [libc++][NFC] Rename the 'noexceptions' CI config to 'no-exceptions' for consistency
2023-05-17 a3at.mail [libcxx] Fix crash in std::stringstream with payload >= INT_MAX
2023-05-16 zijunzhao [libc++] Improve ranges::starts_with
2023-05-17 yronglin777 [libc++] Implement P2505R5(Monadic operations for std::expected).
2023-05-17 thakis Revert "Reland "[CMake] Bumps minimum version to 3.20.0.""
2023-05-17 varconsteq [libc++][ranges] Implement the changes to `deque` from P1206 (`ranges::to`):
2023-05-09 hui.xie0621 [libc++] Utilities for implementing stop_token
2023-05-16 crtrott [libcxx] Add mdspan/extents
2023-05-16 fox [libc++] Add C++20 stringstream::view()
2023-05-07 koraq [libc++][format] Removes format sources.
2023-05-12 martin [libcxx] [test] Improve error reporting around invoked commands
2023-05-15 nikolasklauser [libc++][PSTL] Implement std::copy{,_n}
2023-05-15 ldionne.2 [libc++] Revert moving the pre-release checklist
2023-05-15 ldionne.2 [libc++][NFC] Reformat test
2023-05-15 ldionne.2 [libc++][NFC] Use angle brackets to include ranges_mismatch.h
2023-05-07 koraq [libc++] Removes _LIBCPP_ABI_OLD_LOGNORMAL_DISTRIBUTION
2023-05-08 zijunzhao [libc++] Implement ranges::starts_with
2023-05-15 nikolasklauser Revert "[libc++][PSTL] Implement std::copy{,_n}"
2023-05-15 ldionne.2 [libc++][docs] Move the pre-release check-list
2023-05-05 n_klauser [libc++][PSTL] Implement std::copy{,_n}
2023-05-15 nikolasklauser [libc++][PSTL] Implement std::transform
2023-05-15 nikolasklauser Revert "[libc++][PSTL] Implement std::transform"
2023-05-05 n_klauser [libc++][PSTL] Implement std::transform
2023-04-20 koraq [libc++] Moves unwrap_reference to type_traits.
2023-05-12 iana [libc++][PSTL] Make the PSTL submodules only have one header
2023-05-11 n_klauser [libc++][NFC] Use _LIBCPP_STD_VER instead of __cpp_lib_atomic_is_always_lock_free
2023-05-13 koraq Reland "[CMake] Bumps minimum version to 3.20.0."
2023-05-06 koraq [NFC][libc++][format] Tests formatter requirements.
2023-05-09 n_klauser [libc++][PSTL] Move the already implemented functions to the new dispatching scheme
2023-05-09 hui.xie0621 [libc++][ranges] Fix `iota_view`'s constructor's incorrect constraint
2023-05-06 koraq [NFC][libc++][format] Uses uniform member signatures.
2023-05-07 koraq [clang][ci] Improves buildkite artifacts.
2023-05-09 ldionne.2 [libc++][PSTL] Add more specialized backend customization points
2023-03-13 john.brawn [libc++] Adjust tests using ext/* headers that undefine __DEPRECATED
2023-05-07 iana [libc++][PSTL] Add missing includes to PSTL headers
2023-05-10 rupprecht [libc++] Consistently enable __CORRECT_ISO_CPP_WCHAR_H_PROTO in mbstate.
2023-05-10 ldionne.2 [libc++][NFC] Remove duplicate declaration of __iter_value_type
2023-05-10 ldionne.2 [libc++][NFC] Fix slightly incorrect instructions for testing with Ninja
2023-05-10 aaron [libcxx] Fix pstl __init_ identifier after 9c4717a
2023-05-09 n_klauser [libc++][PSTL] Move the remaining configuration into __config
2023-03-28 ldionne.2 [libc++] Add assertions for potential OOB reads in std::sort
2023-05-08 ldionne.2 [libc++] Provide an assignment operator from pair<U, V> in C++03
2023-05-08 varconsteq [libc++][ranges] Implement the changes to vector from P1206 (`ranges::to`):
2023-05-08 5326451+jakeegan [AIX] Adjust support of format function tests
2023-05-08 5326451+jakeegan [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test
2023-05-06 zingam [libc++][spaceship] Implement `operator<=>` for `array`
2023-05-08 ldionne.2 [libc++] Fix mistake in documentation of libcxx-lit script
2023-05-07 nikolasklauser [libc++] Use the __is_trivially_equality_comparable builtin
2023-05-06 iana [libc++][Modules] Add missing includes and exports
2023-05-06 iana [libc++] test/libcxx/transitive_includes.sh.cpp dumps loads of unhelpful preprocessor output when it fails
2023-05-07 koraq Revert "[libc++] Soft-fail the two sanitizer jobs that have been failing in CI for a while"
2023-05-06 koraq [libc++] Modernizes the forwarded ios headers.
2023-01-21 koraq [libc++][ranges] Addresses LWG3759
2023-05-06 koraq Revert "Reland "[CMake] Bumps minimum version to 3.20.0.""
2023-04-20 koraq [libc++][format] Fixes vector<bool> requirements.
2023-05-06 koraq Reland "[CMake] Bumps minimum version to 3.20.0."
2023-05-06 vitalybuka Revert "[2a/3][ASan][libcxx] std::deque annotations"
2023-05-05 n_klauser [libc++][PSTL] Make the PSTL available by default under -fexperimental-library
2023-05-05 ldionne.2 [clang][ci] Upload artifacts in a tarball to reduce size and avoid symlink issues
2023-05-05 advenam.tacet [2a/3][ASan][libcxx] std::deque annotations
2022-11-24 ldionne.2 [libc++] Remove Solaris related code
2023-04-28 zingam [libc++][spaceship] Implement `operator<=>` for `optional`
Created with:
roll-dep src/buildtools/third_party/libc++/trunk
Binary-Size: New OOB assert in std::sort (crbug.com/1453569#c6).
Fuchsia-Binary-Size: Same.
Bug: 1453569
Change-Id: I52e762bbdb5734ad19f4482efc00a28102c487a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604488
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157098}
[Jelly] Fix Bluetooth pairing dialog progress jelly colors
Update Bluetooth pairing dialog progress bar to use jelly colors when
flag is enabled.
Jelly disabled:
Light mode: https://screenshot.googleplex.com/8q8JrksoZoU7Y3L.png
Dark mode: https://screenshot.googleplex.com/76gMVFVeWmyttXA.png
Jelly enabled:
Light mode: https://screenshot.googleplex.com/4X42wvu9w57rdP2.png
Dark mode: https://screenshot.googleplex.com/3KXZ83jigg79eqz.png
Fixed: b:285026380
Test: DUT
Change-Id: Ic5b537176c84d6f866d6c7f9246aa627132bf04f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610697
Commit-Queue: Gordon Seto <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Auto-Submit: Gordon Seto <[email protected]>
Commit-Queue: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157097}
Remove PrefetchProxy.Prefetch.Mainframe.TotalRedirects.
OBSOLETE_HISTOGRAM[PrefetchProxy.Prefetch.Mainframe.TotalRedirects]=Removed in M116
Bug: 1445619
Change-Id: I7b5bdbc521bd9324dcd1d8faa80e11adec6c8017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609973
Commit-Queue: Max Curran <[email protected]>
Reviewed-by: Simon Pelchat <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157096}
[lacros skew tests] Refresh skew tests for M116
This CL updates the ash version ['116.0.5830.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Bug: None
Change-Id: Ie386f25a6b0516a62422c079d189e34798d73414
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610387
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157095}
Try to make fast/frames/frame-limit.html less flaky
The test is slow by its nature, as it's testing against a bug with
hundreds of iframes.
This patch attempts to make it less flaky by reducing the number of
iframes by a little (still >200 as in the original commit message [1]),
and marking it slow on all platforms.
[1] https://chromium.googlesource.com/chromium/src/+/64a5761df8ae0a6898ab588cdcbc79f19013032c%5E%21/
Bug: 1453341
Change-Id: If4ba329e4cccea8e6c863c2c4e807f8f6df343b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604673
Auto-Submit: Xiaocheng Hu <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157094}
[ios] Set Discover Feed header font and color to match Set Up List
Example screenshot with large font settings:
https://screenshot.googleplex.com/5p2Cp3tEgjKgFQ2.png
Example screenshot with segmented control in header:
https://screenshot.googleplex.com/6YJbbaiDBe5eM2j.png
Fixed: 1454214, 1454217
Change-Id: I44573c557773273c214bb1cca7cf957c93434355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609683
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157093}
[win] Fix NOTREACHED in auto_launch_util::DisableBackgroundStartAtLogin
When uninstalling a system-level install, it can happen that setup.exe
is unable to determine the user's User Data directory. In this case,
DisableBackgroundStartAtLogin should skip doing its work rather than
NOTREACHED and continue.
Bug: 1453546
Change-Id: I6272ddfac2244ab36a33883116383fb6dffd539b
Fixed: 1454431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610222
Reviewed-by: Yann Dago <[email protected]>
Auto-Submit: Greg Thompson <[email protected]>
Commit-Queue: Yann Dago <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157092}
FLEDGE: Add mode to AuctionDownloader that discards the body
...but otherwise tries to match the behavior, and test this mode.
Bug: 1451570
Change-Id: I55de1ca84b666c51fd7571ca6701169f386d3980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605164
Reviewed-by: Caleb Raitto <[email protected]>
Commit-Queue: Maks Orlovich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157091}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686657517-05553064cc9a41ef296e221b265c2362c4254216.profdata to chrome-win32-main-1686668293-636d121caa311b2a70ca16e74db8bab74bc34891.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Icbb61f6c2548c6737a1cce6d28734e72b190c5a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610793
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157090}
[OOBE] - Add Jelly fonts to Sync Consent screen
Mocks: go/oobe-jelly-mocks
Bug: b:270913356
Change-Id: I720701b54136941d8def3adbe880b99d557f8415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610284
Commit-Queue: Bohdan Tyshchenko <[email protected]>
Reviewed-by: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157089}
Roll RTS model from X6L8kjxxpyVVOWapU... to HFsh1P6Q9AZxEBnZb...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I6087584e565e0bca344974a9716f641b033b1ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609269
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157088}
Change cc test context type
Change the compositor context in some cc_unittests to hold a
TestRasterInterface rather than TestGLES2Interface. All GLES2Interface
usage has been removed from real cc code so there is no reason for tests
to have a dependency on TestGLES2Interface. Note this only updates some
tests, leaving the more complex updates to happen independently.
Bug: 1453349
Change-Id: I1618cf607f5da9f95111bfe284867cdb33e34fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605838
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157087}
Add `supports_mask_filter` option to OverlayCandidateFactory
Change-Id: I3335ce55b2977ec1f06a422e172705a3b9498f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548588
Commit-Queue: Zoraiz Naeem <[email protected]>
Reviewed-by: Peter McNeeley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157086}
Disable PDFExtensionTest.BasicPrintCommand yet again
The test is still flaky.
Bug: 1258561
Change-Id: I1f4a267c950c31f65775d44c06fb1af87d4a3b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610700
Code-Coverage: Findit <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Auto-Submit: Lei Zhang <[email protected]>
Commit-Queue: Alan Screen <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157085}
Add GPU.TransferCache.MaxHistoricalTimeSinceLastUse
Hope is this histogram will allow know exactly the reduction in hit rate
if entries older than a certain last use time delta are dropped.
Bug: 1442988
Change-Id: I4ef837bbe9d7878d22fb98209322bd64fc6f699d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605162
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Bo Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157084}
media/gpu/v4l2: Decouple V4L2Queue from V4L2Device
This CL decouples V4L2Device from V4L2Queue by teaching V4L2Queue to
use ioctl callbacks injected upon construction. This clarifies
that V4L2Device uses (owns and constructs) V4L2Queues, but V4L2Queue
should not know about V4L2Device (*).
This decoupling allows V4L2StatefulVideoDecoder to use V4L2Queue
without needing to go via V4L2Device (in a follow up CL).
No new functionality, only moving code around.
(*) Actually there's still two dangling calls to V4L2Device static
methods from v4l2_queue, namely GetNumPlanesOfV4L2PixFmt and
V4L2FormatToVideoFrameLayout, will have to remove in a follow up
CL). v4l2_queue::V4L2Buffer turned out to be the only caller of
V4L2Device::GetDmabufsForV4L2Buffer() so moved to file-static.
Bug: b:279980150
Change-Id: I5aa9d5ff438da542522d0b45def0b5871151c3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568232
Commit-Queue: Miguel Casas-Sanchez <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157083}
Roll RTS model from cMJMbmLkWCKPUlsjo... to 9rAXeZlEUT08AdM7P...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibbbb963fcb570cc130fbc78ebe8eb6485c4a8a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609853
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157082}
Ensure return from non void functions.
(Some compilers don't pick this up properly)
Bug: 1322914
Change-Id: Icb6744c98d1d349af328d2fc319d6533f5fdd6a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604902
Commit-Queue: Bob Beck <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157081}
[wasm] Fix handling of streaming cancellation
When the stream gets cancelled, we receive a
`BytesConsumer::Result::kError` value in `OnStateChange`. In this case,
there is no network error though, so `consume_->GetError()` will return
an empty string or run into a DCHECK in debug builds.
This CL handles this better by checking the state of the consumer before
calling `GetError()`, and producing two different error messages
depending on whether the consumer is closed or errored (which are the
two defined final states).
[email protected]
Bug: chromium:1448858, chromium:1449546
Change-Id: I2efae5454944c94dd4baa109a55b132b974295c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608425
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157080}
[anchor-position] Implement auto anchor fallbacks
This patch implements auto anchor fallbacks by introducing an
`OOFCandidateStyleIterator` class that encapsulates the iteration of
all candidate styles for an OOF, including the base style, `@try`
fallback styles and automatic fallback styles. This class also
replaces the existing position fallback style enumeration.
The existing selectmenu UA stylesheet is also simplified using
auto anchor fallbacks.
Spec: https://drafts.csswg.org/css-anchor-position-1/#fallback-automatic
Fixed: 1412864
Change-Id: I2931001ed255afd611343a7f40e7334cf823cd10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600528
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157079}
Revert "Refactor report_scheduler"
This reverts commit 1e66cc8913f07551151bf22bc22cc4060aa9b11f.
Reason for revert: Suspect this is breaking several bots failing on
RealTimeReportControllerTest.ExtensionRequest
See first build on Mac below
https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20(1)
Original change's description:
> Refactor report_scheduler
>
> Move real time reporting related logic into own classes.
>
> Additionally, make real time reporting no longer depends on the regular
> status report. Note that extension request still depends on status
> report which is controlled by its PolicyHandler.
>
> Change-Id: Ib7c094efac1485667657bb4ae352b4b70e8f7cf5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584953
> Reviewed-by: Anqing Zhao <[email protected]>
> Commit-Queue: Owen Min <[email protected]>
> Reviewed-by: Igor Ruvinov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156886}
Change-Id: Iaf25385e116a8ae45ec8d89836a7cf47ad27b4ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610073
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Tom Lukaszewicz <[email protected]>
Owners-Override: Tom Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157078}
[Lens] Add Lens option to Spotlight actions
Bug: 1353430
Change-Id: Ied04fc2fbbfe76011da8a959084c8b8acfd89d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4581149
Reviewed-by: Juan Mojica <[email protected]>
Commit-Queue: Jason Hu <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157077}
Roll devtools-internal from 3b3b3efd5bf2 to c7069f35b34c (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/3b3b3efd5bf2..c7069f35b34c
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7bc64b80aad58846a712b8925777ddb31d02d154..81e8f798e7b0638ea521ce8d3b8fa2c6b5af5061
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I12a5740b3bcbe03054000b053631c2ba809b7da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610742
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157076}
WebUI: Leverage EventTarget in cr_components/color_change_listener/.
ColorChangeUpdater was previously exposing a custom
addListener/removeListener API and was manually keeping track of
registered listeners, instead of leveraging the existing EventTarget
functionality.
Bug: 1450109
Change-Id: I670a117b14016a077ec5d7f117e548145111f90d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609485
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: John Lee <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157075}
Roll ANGLE from 7e075469ff02 to 18010f58be60 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/7e075469ff02..18010f58be60
2023-06-13 [email protected] Metal: Limit the debug spew for blocked cache reads/writes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ie8d805383b907613e6e0ef8264b1eb432618135c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611025
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157074}
Disable flaky test radio-accent-color-hover-dark-appearance.html
Bug: 1454498
Change-Id: I3f79cf81b4b7f0d45ee7c812ee124f48ee9079e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610693
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157073}
Re-enable CustomTabActivityTest#testMultipleActionButtons
Bug: 1424436
Change-Id: I9e8d9981835f3d0b7c55725bc8f6eb711ed141ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610821
Commit-Queue: Zach Katz <[email protected]>
Reviewed-by: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157072}
Fix extra slash in comment that was accidentally added.
Bug: 1322914
Change-Id: I4c2a3ee7ce862b8b495e46a2c700e62373e04bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609974
Auto-Submit: Bob Beck <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157071}
[color] Set PreferredColorScheme to track the Browser for WebUI
Current UX guidance is to have WebUI follow the color scheme of the
browser, and to have web content continue to follow the color scheme
of the global NativeTheme instance.
This CL updates Chrome WebUI's preferred-color-scheme to track the
ColorMode of its associated ColorProvider.
This addresses the current gap between Views and WebUI where Views
UI tracks the ColorMode of its associated ColorProvider (which can
be unique per UI tree), while WebUI tracks the ColorMode of the
global NativeTheme provider instance.
Bug: 1431202
Change-Id: I0fa336222a7cc711aa7c50bf5ba78e827ee06383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605338
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157070}
CrOS Settings: Convert internet config browser test to TS
Additionally, moved the test under the `internet_page` folder to
mirror the app folder structure.
Bug: b/270728282
Test: browser_tests --gtest_filter="*InternetPageInternetConfig*"
Change-Id: Ife55b58f56a4855804c975de2788c1e2d3c9e3e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607764
Commit-Queue: Ruma Kesh <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157069}
Ignore --load-extension for Enhanced Safe Browsing users
Bug: 1453252
Change-Id: Iabcba1680033d92474110e5a7c03efeb8afd3393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607491
Commit-Queue: Anunoy Ghosh <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157068}
[camera_preview] Add camera preview to chrome://flags page
Change-Id: I8123165b0d15ff2d438434400b8f4a6bb8657415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607930
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Bryant Chandler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157067}
personalization: update test for jelly
Modified the 'displays content' test so it will still pass after jelly
is enabled.
BUG=b:286605376
TEST= browser_test PersonalizationApp*Theme* with and without `--enable-features=Jelly`
Change-Id: I5c0ad54bd62785b85f7ec583a805af54109e106f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607938
Commit-Queue: Erica Lee <[email protected]>
Reviewed-by: Jeffrey Young <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157066}
Un-deprecate progress in ARC notification mojo
[Chrome rendered ARC notification] Un-deprecated progress current and progress max in ARC notification mojo to render ARC notifications directly in chrome.
ARC side change: ag/23664866
Bug: b:276353887
Test: manual
Change-Id: Ib69846ac03b2c2efa908c89a4d7b0a9887727e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605784
Reviewed-by: Toshiki Kikuchi <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Shuming Hao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157065}
[DoH] Extend Net.DNS.UpgradeConfig.* histograms
Let's extend the Net.DNS.UpgradeConfig.* histograms since these
can provide interesting visibility into whether a system's DNS
configuration can support DoH auto-upgrade.
Also, changes the alternate owner from `[email protected]`to
`src/net/dns/OWNERS`. This will improve tracking of the metric
expirations, since this will cause the `Internals>Network>DNS`
component to be added to the 'Check expiry of your histogram`
crbugs, and since `[email protected]` is an internal-only
email list and doesn't receive any of the expiration reminder
emails from crbug.com.
Fixed: 1441476, 1423984
Change-Id: Ia125505c8f31885951bd6b942cd302c22a2245a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609061
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Andrew Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157064}
Roll Open Screen from 03ab64e47e14 to b4e1977e3623 (1 revision)
https://chromium.googlesource.com/openscreen.git/+log/03ab64e47e14..b4e1977e3623
2023-06-13 [email protected] [OpenScreen] Replace TaskRunner* with TaskRunner& in discovery/ directory
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I7009c73840c615e2394f811ab0426c6c5fa12770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610744
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157063}
Remove PrefetchStreamingURLLoader::redirect_info_/redirect_head_
To clarify the data dependencies and lifetime, this CL removes
`redirect_info_` and `redirect_head_` that are used only between
`OnReceiveRedirect()` and `HandleRedirect()`, and instead
passes them as arguments.
Bug: 1449360
Change-Id: I350d8d1dc689eb5bd5b22bd2839664289fbb46ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608817
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Reviewed-by: Max Curran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157062}
snap-group: Cache value of CanResize() in window_state.cc
This CL does a nit optimization for window_state.cc by caching the
value of CanResize().
Bug: None
Test: Existing tests
Change-Id: I0c7112e4980bd524f17d5dfd378de11cd0defad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609478
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Michele Fan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157061}
Roll Perfetto Trace Processor Linux from a4e9e26e3958 to bc462e6d73d2
https://android.googlesource.com/platform/external/perfetto.git/+log/a4e9e26e3958..bc462e6d73d2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib9e0a1dab1d15e9a6cb5e7f4307785d1c903b4c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610476
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157060}
Add once metrics for credit card FILLED and WILL_SUBMIT event
Add metrics based on whether filled suggestion has metadata for
card filled and will submit once events
Bug: 1439570
Change-Id: I545ab02d1d9da5b7ccdd235ac78262637dfb964b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4468070
Code-Coverage: Findit <[email protected]>
Reviewed-by: Vishwas Uppoor <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Commit-Queue: Yishui Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157059}
Sync: Add documentation about adding syncable preferences
This CL populates components/sync_preferences/README.md with information
about adding new syncable prefs.
It also adds comments in the various syncable-prefs allowlists linking
to this file, and that loudly point out to the reviewer that it's their
responsibility to ensure any new syncable prefs follow the privacy
guidelines.
Bug: 1448000
Change-Id: I2a3b2ff7a2deb03e2782f256a192aa0ae125529a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608058
Reviewed-by: Rainhard Findling <[email protected]>
Reviewed-by: Ankush Singh <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157058}
TrialComparisonCertVerifier: add AIA fetch success/failure data to Trial Cert Verifier comparison reports.
Context:
TrialComparisonCertVerifier: Run TLS certificate verification with two different verifiers (OS verifier (old way) and Chrome Cert Verifier (new way)), and report on any verification differences. Possibly also reporting with using the Chrome Root Store as well.
AIA: Authority Information Access extension for certificates, basically URL field in a certificate that says "here's where you can go to find more certificates to use in TLS certificate verification".
We're looking to add some information about AIA successes/failures in the Trial Cert Verifier comparison reports to help investigate some differences we've been seeing launching the Chrome Cert Verifier (and Chrome Root Store) on Android/Linux/ChromeOS
Change-Id: I3354924b5f017784ed980c11b1e66601af1fd806
Bug: 1365571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507916
Reviewed-by: Brendon Tiszka <[email protected]>
Commit-Queue: Hubert Chao <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157057}
Wayland min for viewport size without logging
It not completely unexpected to stretch a texture more than the smallest
fixed point can represent. The two cases here are solid color buffers
(1x1 or 4x4) and something like 9-patch shadows (5x5) stretched to the
entire window width/height.
Bug: 1324657
Change-Id: Ib37dd29f6aaed9a27e164f2de68ee98b3c0b76cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609505
Commit-Queue: Peter McNeeley <[email protected]>
Reviewed-by: Kramer Ge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157056}
Autoshard chromium/src test suites
This is an automated CL generated by the autosharder.
Optimal shard counts for test suites are calculated by querying recent
runtimes.
The build that created this CL was https://ci.chromium.org/b/8778423904728693793
[email protected]
Change-Id: Id937a06575cf067721e4931787c41c89bf474e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610140
Commit-Queue: Struan Shrimpton <[email protected]>
Reviewed-by: Struan Shrimpton <[email protected]>
Auto-Submit: chromium-autosharder@chops-service-accounts.iam.gserviceaccount.com <chromium-autosharder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157055}
Fix AnnotationAgentImpl crash
The crash in the linked bug is the CHECK in
AnnotationAgentImpl::ProcessAttachmentFinished:
CHECK(!attached_range_);
It was introduced recently by https://crrev.com/c/3930653.
This CHECK is saying that if the incoming range isn't valid (i.e. we
aren't setting it to attached_range_), then attached_range_ should be
null. A clearer way to check this would be to null-check attached_range_
at the top of the method unconditionally which this CL does.
We CHECKed this because once an attachment succeeds we don't expect to
perform further attachments on the agent (indeed, we CHECK(!IsAttached)
in Attach(). However, if DOM is changed and the matched range becomes
invalid (collapsed) and IsAttached noew returns false. This is what
leads to the CHECK.
This CL fixes the issue by clearing attached_range_ in Attach. We still
keep the !IsAttached CHECK there to make sure this can only be done if
the annotation isn't attached to valid DOM.
There's a similar issue with pending attachment where we might perform a
second attachment while waiting on the rAF task of the first. This is
also fixed here by making IsAttachmentPending return true regardless of
the matched range's status and preventing a new attachment while in this
state.
Bug: 1453658
Change-Id: Ia74dd20e5e7fe7dd3607e644e4ef972193aa6b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608624
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157054}
infra: Move builds on Android x64 Builder All Targets (dbg) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I35f237c5ebffcd64e641edcb797a495b8476dd88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610167
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157053}
[iOS] Reset zoom scale after rotating
When a user zoom in portrait mode and then rotate to landscape mode for
example, the web view keeps the zoom, so it results to display something
random in the web page. This CL reset the zoom state to the minimum
value (aka completely zoomed out) when the device been rotated.
Before video:
https://drive.google.com/file/d/1Y_vkkZOv_bVpOA7BNKR7UI0eVkclsz_3/view?usp=drive_link
After video:
https://drive.google.com/file/d/11fftuhIGtWJOJRrP62LWLbRfSl6Cpx6d/view?usp=drive_link
Change-Id: Iadecc1d3853f67af6f17ed2ddafb5175bba77737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601369
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Aliona Dangla <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157052}
include string_view when used
Bug: 1322914
Change-Id: Idb4e663f2499e905d36e0a20e9fdbe0edd62da26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608814
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Bob Beck <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157051}
Add LocalTestPolicyProvider
Added files for LocalTestPolicyProvider.
First CL out of a series of CLs to add a LocalTestPolicyProvider for the chrome://policy/test page.
Bug: b:284460528
Change-Id: Ia073ee19297eef2c0d612fa601bbc66b9d4c3f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594100
Commit-Queue: Jayee Zheng <[email protected]>
Reviewed-by: Yann Dago <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157050}
Roll WebRTC from cfa0f817b730 to 61deed569671 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/cfa0f817b730..61deed569671
2023-06-13 [email protected] Change flexfec header writer to finalize header according to updated RFC
2023-06-13 [email protected] Change FinalizeFecHeader to receive list of streams
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I5ba942fb3e0efdaf52a8e19c6e23c7e3b254577b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610866
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157049}
build: Add image_processor_perf_test binary
image_processor_perftest is a unit test binary that is not currently part of
any build process. This CL adds image_processor_perftest to the
chromiumos_preflight group target in preparation for using it in a Tast
test.
Bug: b/278107121
Test: autoninja -C out_asurada/Release chromiumos_preflight
Cq-Depend: chromium:4605778
Change-Id: I5ea71228893d324cea6c269717613e63f6a3df35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602552
Reviewed-by: Fritz Koenig <[email protected]>
Reviewed-by: Sam Maier <[email protected]>
Reviewed-by: Justin Green <[email protected]>
Commit-Queue: Bijan Choobineh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157048}
Roll Chromite from 547201a5e52d to 2b8358b431c6 (12 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/547201a5e52d..2b8358b431c6
2023-06-13 [email protected] cros-ide: Add buttons for creating and navigating to related files
2023-06-13 [email protected] cros-ide: Add `git cl format` support for Chromium
2023-06-13 [email protected] android: plumb Android branch via LKGB
2023-06-13 [email protected] lib: Drop portage_util.FindSysrootOverlays.
2023-06-13 [email protected] sysroot: Add a new option to use Bazel to build packages
2023-06-12 [email protected] lib: portage_util: Drop GetOverlayRoot.
2023-06-12 [email protected] scripts: add metadata to build_packages spans
2023-06-12 [email protected] lib: remove ap_flash_select for hades
2023-06-12 [email protected] lib: portage_util: Cache GetOverlayName
2023-06-12 [email protected] lib: Only replace unmarked CROS_WORKON_* vars
2023-06-12 [email protected] chromite: Delete reference to authpolicy
2023-06-12 [email protected] cli: cros cop: reinstall qmerge on slot conflict
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome
Tbr: [email protected]
Change-Id: Ic2d3538c8ce22b144ec09209f9baf4ff741827ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610472
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157047}
[omnibox][cr23] Fix pdf test for SS height.
crrev.com/c/4581107 launched omnibox SS height, increasing the omnibox
height from 28px to 34px.
This decreased the height available for page contents.
`PDFExtensionJSTest.AnnotationsFeatureEnabled` is sensitive to the
height, so it began failing.
This CL adjusts its expectations to pass with the SS height launch. I
think the test is rendering a PDF dialog then measuring the location of
some items. It seems reasonable that the location of things moves when
the available height decreases. I simply updated the expectations to
match the new positions. But I didn't actually verify the correctness of
the new values.
Bug: 1454196, 1416351
Change-Id: I2faeedf1e93b0204cd461b5b26df30be6d3bb355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608577
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157046}
Revert cookie_util.cc crash dumping
This was too loud and we already know what the failure root cause is.
Making this a DCHECK again for now, even though arguably it should be a
LOG(ERROR) until we're ready to fix the underlying bug.
Bug: 1453871
Change-Id: I2e651a7930508f25b43ad03130880547054b14dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610690
Commit-Queue: Steven Bingler <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Steven Bingler <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157045}
[Autofill] Ignore main-origin number, CVC if they're also in sub-frames
Suppose there are two CREDIT_CARD_NUMBER, one of which has the main
frame's origin and one is in a cross-origin sub-frame. Then the former
is likely misclassified and should not be filled. This CL overrides the
former CREDIT_CARD_NUMBER with UNKNOWN_TYPE.
Analogously for CREDIT_CARD_VERIFICATION_CODE.
The effects of the rationalization has been validated manually:
go/autofill-multi-origin-numbers
Bug: 1450502
Change-Id: Ia811014c699e2ef240ce8debcb58cf44c970717b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597895
Commit-Queue: Christoph Schwering <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Dominic Battre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157044}
CrosNext: Add shadow to Desk Library Label.
Apply shadow to the text label to increase the visibility to users.
Test: Manual
Change-Id: I7cc516ec37b487b18be9266bf96735555eaf2d32
Fixed: b/284210964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608885
Reviewed-by: Xiaodan Zhu <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Judy Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157043}
Allow uninstantiated gtest for CertIssuerSource
The versions of gtest used in boringssl require this.
Bug: 1322914
Change-Id: Ic30584bce8de21ec4a2e7a4847d32b78661f787b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609968
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Bob Beck <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157042}
Roll Perfetto Trace Processor Win from 7aa646548880 to a4e9e26e3958
https://android.googlesource.com/platform/external/perfetto.git/+log/7aa646548880..a4e9e26e3958
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I05f929c7f20b7bd8f50ba50c5d979f7acdeadc2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609966
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157041}
Wire up bookmark row search mode to propagate to the toolbar.
The mediators (manager and toolbar) need to understand when we're in
search and when we are not. But this is problematic because the
toolbar views (BookmarkToolbar and SelectableListToolbar) make
assumptions that we actively want to avoid, like what it means to
search.
This CL attempts to start getting this interaction closer to
functional by sending the state to the toolbar mediator but not fully
setting the view code. This means that in the future the mediators
will need to pick up more of the work that SelectableListToolbar used
to do, such as negotiating state when transitioning between search and
selection modes.
Bug: 1439583
Change-Id: Idbfe00e2e7da0dc1d1275d3930dc9add0a0b4cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609464
Code-Coverage: Findit <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157040}
Roll src-internal from ace708b60dd7 to 5add04205f38 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ace708b60dd7..5add04205f38
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1451867
Tbr: [email protected],[email protected]
Change-Id: Icda13a31015476d40ff87b9ea24aa6ef214a8899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610679
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157039}
Revert "DanglingPtr: mark unretained dangling ptr in JobInterceptor"
This reverts commit 0a96710e4414eee7425197f166caea33a89d9064.
Reason for revert: can we agree that binding an unowned pointer to a callback passed to an owned mojo interface is safe? :-)
Original change's description:
> DanglingPtr: mark unretained dangling ptr in JobInterceptor
>
> Doc:
> https://docs.google.com/document/d/1YQCh_mezoSF1fWS9TaMEh0Whumb8eNe0KWV8MBs7sFs
>
> We detected those callbacks are invoked using dangling pointers.
> This is something we would like to detect and potentially ban.
>
> In the meantime, we need to annotate them using:
> base::UnsafeDanglingUntriaged
>
> Outside of the experiment, it is a no-op.
> Within the experiment, it skips DumpWithoutCrashing.
>
> Bug: 1442713
> Change-Id: I5f83c6518c8495da34e34ebf3246d2a9a5fd1ef9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4565334
> Commit-Queue: Paul Semel <[email protected]>
> Reviewed-by: Arthur Sonzogni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1149174}
Bug: 1442713
Change-Id: Ia38e0b47fdb86ac76f6b1866cb41330169e3157c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605025
Commit-Queue: Andrey Kosyakov <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157038}
[Fixit] TabGridDialogViewTest *ZoomIn*
Tests didn't correctly attach the source view to the hierarchy
this resulted in NaN or Inf values for animations which are asserted
on in Android O+.
Fixed: 1036552, 1345763, 1377458, 1371230, 1345764
Change-Id: I0bafc2c04070e74727f577b4637950221ffa4d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609679
Code-Coverage: Findit <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157037}
[Extensions c2s] Use ColorSysNeutralContainer for menu's message section
According to the mocks, MessageSection in the extensions menu should
use cdds.sys.color.neutral-container. Using this color variable will
properly update the colors based on the OS mode and chrome theme.
Screenshots:
- Light mode, default theme:
https://drive.google.com/file/d/1HheBX9Yfdo8rDDivkYmPixjtX3coB6AN/view?usp=sharing
- Light mode, green theme:
https://drive.google.com/file/d/1yOEd6I9wUHqU1N3f5oAo4sUBRNP9R3O1/view?usp=sharing
- Dark mode, default theme:
https://drive.google.com/file/d/1UT7q_e3HuSx4sA7YUVPou8-xtjjtL6cL/view?usp=sharing
- Dark mode, green theme:
https://drive.google.com/file/d/1msED-KmuB7Y8_25gSebatvDzkwWtjcH6/view?usp=sharing
Bug: 1390952
Change-Id: I547e08d687ff0a09cbfbf74374f3e0a0c7dd5789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608573
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Emilia Paz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157036}
personalization: rename managed icons
Avoid confusion and remind developers to remove old icon by renaming the
following iron-icons:
managed => managed-old
managed2 => managed
BUG=b:286908871
TEST=All browser tests pass
Change-Id: I24d111adc72b2d6737d39308c4127903fbe92a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609184
Reviewed-by: Jeffrey Young <[email protected]>
Commit-Queue: Jerry Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157035}
Roll Media App from nk7uqhf0SSRPUO6Eo... to rCTSNpbeNxtJLvVp9...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202306130800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rCTSNpbeNxtJLvVp9XGiUP90cuioMBYiLSAPN_q3R-EC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/281792020
Tbr: [email protected]
Change-Id: I6ed9d1e940302b6881ef9dc6f1c71b4db2acd805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610812
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1157034}
[Status Indicator] Re-enable testShowAndHide.
This test is consistenly passing in TestReviver now.
Change-Id: I5027da3d366a01a24f441adae9198854112fbd90
Bug: 1188377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609447
Commit-Queue: Ritika Gupta <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157033}
[DoH] Extend Net.DNS.ProbeSequence.* histograms
Extend these histograms for a few more months so that we
can use them when evaluating a replacement metric for them (see:
https://chromium-review.googlesource.com/c/chromium/src/+/4577618)
Also, let's change the alternate owner from `[email protected]`to
`src/net/dns/OWNERS`. This will improve tracking of the metric
expirations, since this will cause the `Internals>Network>DNS`
component to be added to the 'Check expiry of your histogram`
crbugs, and since `[email protected]` is an internal-only
email list and doesn't receive any of the expiration reminder
emails from crbug.com.
Fixed: 1441565, 1441564
Change-Id: I45336fb5a7a19fc194354b2699edc2b2beb10e00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606099
Commit-Queue: Andrew Williams <[email protected]>
Reviewed-by: Nidhi Jaju <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157032}
[omnibox][realbox] Track focus to fix FocusToOpenTimeAnyPopupState3
This CL plumbs focus state from the realbox web UI into the native
page handler and its edit model. Doing so gets the
Omnibox.FocusToOpenTimeAnyPopupState3 histogram working again.
Fixed: 1453382
Change-Id: I4ad1686eba5216cb8eedae5c0e20bfb35e1e4f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605900
Reviewed-by: Moe Ahmadi <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157031}
[Performance Settings] Fix add exception dialog current sites list a11y
Introduce a component outside of cr-checkbox, that doesn't pass along
focus. This makes the whole list entry focused when using keyboard
navigation, so that a proper parent-child relationship with the
iron-list can be inferred by screen readers. Additionally, changes to
use listbox role for the iron-list and option role for the list entry
component, which is more in line with the intended use case than the
grid role.
Using grid role:
https://screenshot.googleplex.com/48Km8UTCPYNFEgv.png
Using listbox role:
https://screenshot.googleplex.com/7oAYtxjQyguP2ZH.png
The additional "selected" read by Voiceover is a bug that happens
for all multi-selectable listboxes.
Bug: 1424223
Change-Id: Ie8be6797bfc9bcf952e51e82600668033ab0415c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602528
Reviewed-by: Eshwar Stalin <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Charles Meng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157030}
Roll Perfetto Trace Processor Linux from 7aa646548880 to a4e9e26e3958
https://android.googlesource.com/platform/external/perfetto.git/+log/7aa646548880..a4e9e26e3958
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic351413da86a28ab97842c00c6a851e663331506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610307
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157029}
[dPWA] Add test case for app id computation during policy install
This CL adds a test case to check a policy installed web app has the
correct app id when the manifest has a start_url but no manifest id.
Bug: 1453796
Change-Id: I2185e68627e2284f1e0d4550e7b361f929141d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604153
Auto-Submit: Alan Cutter <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157028}
Fix ExecutionContextPriorityDecorator and enable it by default
Use Add/RemoveInitializingFrameNodeObserver to fix issues around
initializing the priority during frame node creation.
Change-Id: Ib99bac652a72bf47c0232c5ca55e031fe2492af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599232
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Joe Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157027}
AW UMA: remove onReceivedHttpError.StatusCode histogram
No change to logic. This removes logging for
Android.WebView.onReceivedHttpError.StatusCode as we no longer need this
data.
Fixed: 1421866
Test: N/A
Change-Id: I6a066fc5bc34ff8afc3a43ae84f8a37a81682f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608579
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157026}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686664165-f131b4e75e5858a4c032a9e3e36ec414341756e3.profdata to chrome-mac-arm-main-1686671915-f57d526d51a94ee5a559d6811ac713b0a4ae0f8e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I3ba7fd2d2324c235b9e2a7b34a2eb679ffda2e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4611065
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157025}
Add scrollview to contain the glanceable bubbles
Bug: b/283370562
Change-Id: I9306937f23c9f92fee209688a07a9098eb9edb4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605001
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157024}
[password manager] Add passkey edit dialog
Add a passkey edit dialog.
UXW review:
http://go/passkeys-in-chrome-pwm-uxw
Implementation screenshot:
https://storage.cloud.google.com/chromium-translation-screenshots/9c95e8df069b318d072541756a620e05e4dbd6b4
Design doc:
https://docs.google.com/document/d/1Ox_VBGNO-Ff9bcP97FUMcN15Xtfn_sz0_WuDe3ujbwA
Bug: 1432717
Change-Id: I9711a0f54757b043b10ac0a34f3b84102db425e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601842
Commit-Queue: Nina Satragno <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157023}
Re-enable BottomSheetStrategy#fixedHeightReactsToSoftKeyboardBelowR
- Set config to a lower device version instead
Bug: 1454278
Change-Id: Ia680d52a160cbf99d71875e113851feb7342aa19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609489
Commit-Queue: Zach Katz <[email protected]>
Reviewed-by: Kevin Grosu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157022}
Fix some instances of &vec[0] in chromeos/ash
&vec[0] is invalid if vec is empty. Instead, one should write vec.data()
to avoid needing to think about this.
Bug: none
Change-Id: I550c1b53baa55b2b96ba9e820f0a117cb00822e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603673
Auto-Submit: David Benjamin <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157021}
[CR2023] Update download bubble row hover color
Use state-hover-on-subtle as the download bubble row hover color.
Bug: 1422125
Change-Id: Ib8366fb22aa3bd3d1b3aad5deb4acef07d09f028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603626
Code-Coverage: Findit <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157020}
Only warn for fieldtrial_testing_config presubmit
There are a fair number of features being defined outside the checked-in
sources, most commonly by code generation.
Since it is infeasible to search all output directories, the presubmit check is
changed to only warn submitters if the feature name cannot be found.
Bug: 1336663
Change-Id: Ifac8c00e668c249ec6daa37f41b5c7076626dd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607214
Reviewed-by: Alexei Svitkine <[email protected]>
Auto-Submit: Peter Pakkenberg <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157019}
browser_context.h: Nested namespaces can be concatenated
Bug: None
Change-Id: I9e4a91c9c346aba60fc48bae1f06c17b63f38da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609620
Commit-Queue: Nasko Oskov <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Auto-Submit: Solomon Kinard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157018}
[Extensions c2s] Display confirmation message on request access button
Display a confirmation message for kConfirmationDisplayDuration on the
request access button after it has been clicked.
This CL doesn't fix the animation issues with the extension toolbar
button (puzzle piece)
Screencasts:
- No reload:
https://drive.google.com/file/d/1O3nVNG-Oq8aqGjyhgf9LSxSR_yYyLNy9/view?usp=sharing
- Reload accepted:
https://drive.google.com/file/d/1LAKk8VUjWVoaX40QGxRa26u3AiqJuC8O/view?usp=sharing
- Reload dismissed:
https://drive.google.com/file/d/1KUSPYOyX9gICU9Hf6mhAgSnZXwXnHKLi/view?usp=sharing
Edge cases:
Click on request access button and before button is collapsed:
- Navigate to page that requests access
https://drive.google.com/file/d/11YNJJFnFCMj3kDfXo5s7nkXArhoH7_cd/view?usp=sharing
- Navigate to page that doesn't request access
https://drive.google.com/file/d/1zsr8WkzFhmfb1i_LANPBnvo2kRtjvWtp/view?usp=sharing
- Open a new tab
https://drive.google.com/file/d/1gRv1vIJuDBoyfi7xY6psMTnAGCsCAI4g/view?usp=sharing
- Change to an existent tab
https://drive.google.com/file/d/1RWbxJdyTPgwYcb-76Uoq2-rhWC5lG8J6/view?usp=sharing
Bug: 1390952
Change-Id: I42adc2bd4aa125ed4330f964486de89f2a1dcc67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582732
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Emilia Paz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157017}
Add field trial config for UseClientGmbInterface.
Bug: 1445706
Change-Id: I9dccd37b57afc096a364cfd968571903e0d0f63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608898
Auto-Submit: vikas soni <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157016}
Partially fix GPU tests with restarts
Fixes the GPU test harness erroneously treating expected failures as
unexpected in cases where a test restarts the browser with different
arguments. This only affects the harness' post-failure logic, not
whether a failure is reported as expected or not. Fixing that is
handled in crrev.com/c/4606117.
Bug: 1454250
Change-Id: I73385f4c20cbc4a7d1c1c9dce07ee46f8ce015f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609490
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157015}
[Welcome Tour] Create the welcome tour dialog - Part 2
This CL integrates the Welcome Tour dialog with the tutorial. When a
primary user logs in, the Welcome Tour dialog "should" show. If the
dialog's accept button is clicked, the tutorial starts.
Bug: b/285027636
Change-Id: Ice43cf4bcc8491c67a7cdd99a0960ac9301b1048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598989
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: David Black <[email protected]>
Reviewed-by: Xiaodan Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157014}
Rename FPNM::IOTaskInfo
Renamed IOTaskInfo to FileTaskInfo since it's used for non-io tasks in crrev.com/c/4577203
Change-Id: I54992f239d62b77cf1fbb12782a49725d5d34f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599067
Reviewed-by: Aida Zolic <[email protected]>
Auto-Submit: Aya Elsayed <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157013}
Throw on cross-origin access to a detached window's non-cross-origin-properties.
Updated tests:
external/wpt/html/cross-origin-opener-policy/coop-csp-sandbox-navigate.https.html
An additional test case is passing now, which is often considered good.
external/wpt/html/cross-origin-opener-policy/resources/resource-popup.html
The test, as written, appears broken: Window.name is not a cross-origin
property. It is unclear how or why this test passes in Firefox;
nonetheless, the test as written appears to be broken. The fix is to
guard attempts to access Window.name and return `null` when the access
violates the same-origin policy and throws an exception.
fast/dom/constructor-in-removed-frame.html:
It is unclear if the test as written originally worked, due to some
quirk of file:// URLs having surprisingly broad origin grants (read:
univesral access) in layout tests. Nonetheless, the test as written
currently does not work, because it is trying to access a
non-cross-origin property on a cross-origin Window, since a document
with a data: URL always has a unique opaque origin. Switch this test to
use a srcdoc to avoid violating the same-origin policy.
http/tests/security/detached-window-cross-origin-access.html
The test is considered fully passing now, which is probably a good sign.
Bug: 1453572
Change-Id: Ia0eadfd665dee777cde0c5faf90f23396de8cf06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610141
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157012}
[FedCM] Add WPT for context parameter
The tests do not yet work because some automation needs to be
implemented to obtain the title.
Bug: 1440192
Change-Id: I4f0957e8da02eeeb501a43ed8a06e96883950944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605035
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: Nicolás Peña <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157011}
Automatic update from google3
Automatic update for 2023-06-13 UTC
Change-Id: I3fac70de95cc8fbe9b6c96ae13c1d56c125a7478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610815
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157010}
image_processor_perf_test: Rename image_processor_perf_test files
Previously the executable and source filenames for the
image_processor_perf_test were named |image_processor_perftest|.
This update renames the source file and build's executable name to
|image_processor_perf_test|.
BUG: b:278107121
Test: Built and ran successfully on an Asurada board.
Change-Id: I595828657dda16ef01458d03df8464edb0f91155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605778
Reviewed-by: Justin Green <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Commit-Queue: Bijan Choobineh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157009}
[Fixit] Re-enable optional toolbar button test
This failure was solved by crrev.com/c/4467213
Bug: 1449783,1440715
Change-Id: Iffeb53502c946399a5ca86dd35581e6445041f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609965
Commit-Queue: Salvador Guerrero Ramos <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157008}
[ios] Replace WebStateMoved() with WebStateListChanged()
This CL replaces WebStateMoved() API with WebStateListChanged().
This CL is a part of refactoring WebStateListObserver API:
Step 1 [Done]: Introduce WebStateListChanged() w/ kReplace type in WebStateListChange and replace WebStateReplacedAt() with it
Step 2 [Done]: Introduce kInsert type and replace WebStateInsertedAt()
Step 3 [This CL]: Replace WebStateMoved() with WebStateListChanged()
Step 4: Replace WebStateDetachedAt() and WebStateListDestroyed() with WebStateListChanged()
Step 5: Replace Will*() with WillWebStateListChanged()
Step 6: Migrate WebStateActivatedAt() to WebStateListChanged()
No behavior changes.
See https://docs.google.com/document/d/1I1QUZAexM1eMI2l2oriZl5GARrtofNI0SxHUPB4h-YE/edit?usp=sharing for more details (internal document).
Bug: 1442546
Change-Id: I11879cb90b0606916dc369bd89dce70ac674f56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4556706
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Asami Doi <[email protected]>
Reviewed-by: Federica Germinario <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157007}
Use 12 core machines for some TOTMac* builders
To fix the seemingly random build failures caused by different core
numbers.
Bug: 1451520
Change-Id: I5c891e756858f9d583df65b0ab8a7f8056e81316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610322
Reviewed-by: Arthur Eubanks <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Zhaoyang Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157006}
saved_desks: Remove inactive admin template launch trackers
When an admin template is launched, we now make sure to get rid of any
inactive old trackers that may be lying around.
Change-Id: Ib99a783726750c190f70ab0cd356445f6b1dd31c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605682
Reviewed-by: Yongshun Liu <[email protected]>
Commit-Queue: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157005}
camera: Register CameraHalDispatcher to Mojo Service Manager
Currently CameraHalDispatcher is shared between Chrome browser process
and Cros Camera Service by mojo. However, the connection is established
by socket. Now there is Mojo Service Manager, this CL registers
CameraHalDispatcher to Mojo Service Manager and still left the legacy
socket. Once Cros Camera Service is migrated to Mojo Service Manager,
there should be a CL to cleanup the socket related function.
BUG=b:258095854
Test: Manually by tast -verbose run camera.HAL3*.
Change-Id: I79d01530e2653ebd5f6d49aaabc7034192323c45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4462778
Commit-Queue: Sean Li <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Wei Lee <[email protected]>
Reviewed-by: Mike Frysinger <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157004}
Move builds on android-fieldtrial-rel to jammy
And stop pinning its builds directly to bionic, and instead use
the default OS val for linux.
Bug: 1412588
Change-Id: I78417fcec1c64b7dd4817bbbd31125ce318a7194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610308
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157003}
focus-mode: Add feature flag
Add command line feature flag 'FocusMode'.
BUG=b:286931175
Change-Id: I9f06742e6fa9392f019e0571068762e8670b13a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609700
Reviewed-by: Daniel Andersson <[email protected]>
Auto-Submit: Richard Chui <[email protected]>
Commit-Queue: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157002}
Updater: Only override the hang timer timeout in the idle test.
Also, eliminate a CHECK that is no longer correct.
Bug: 1451862
Change-Id: I7f02001d48c1365f2bbf1f4aaab07d7c0c560369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608204
Commit-Queue: Joshua Pawlicki <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Auto-Submit: Joshua Pawlicki <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157001}
[iOS] Fix testPasswordProtectionNotShownForAllowListedURL egtest
Test is failing due to the keyboard still being uppercase.
This CL waits for the keyboard key matcher to appear before pressing on
it.
Bug: 1454079
Change-Id: Ib66f4438cb0e2e64b5427ea98c91b95941b06481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604540
Reviewed-by: Joemer Ramos <[email protected]>
Commit-Queue: Joemer Ramos <[email protected]>
Auto-Submit: Christian Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157000}
Roll Perfetto from a4e9e26e3958 to bc462e6d73d2 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/a4e9e26e3958..bc462e6d73d2
2023-06-13 [email protected] Merge "ui: thread_state aggregation for threads without a process association"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I4d290f55d7cab6f80179016a59dc225faccdb036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610675
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156999}
Re-enable oes-texture-*-with-video
Offending DCHECK was removed, so we can re-enable tests now.
Bug: 1445548
Change-Id: I884f81c770a685bc514f77713b992345531a37bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608802
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156998}
Enable LessChattyNetworkService by default.
Bug: 1425174
Change-Id: Ie43ba2880b2d30f458ac75493aba7279683e8686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609452
Commit-Queue: Clark DuVall <[email protected]>
Auto-Submit: John Abd-El-Malek <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156997}
Add note about headers for crash repro
Change-Id: I015c70aa49b98b76038af628f8c8d8c67f41f81c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608824
Commit-Queue: Russ Hamilton <[email protected]>
Auto-Submit: Caleb Raitto <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156996}
FLEDGE: move AuctionDownloader to c/s/aw/public/cpp
We want it usable from the browser as well, not just the worklet
process.
This required updating the traffic annotation w/some new required
fields.
Bug: 1451570, 1257361
Change-Id: I37e92a76160e49396e20366a08be8565569770fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608481
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Reviewed-by: Caleb Raitto <[email protected]>
Commit-Queue: Maks Orlovich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156995}
Allow AtomicString implicit conversions in specific targets
instead of disallowing them in specific targets.
This CL adds `-DALLOW_IMPLICIT_ATOMIC_STRING_CONVERSIONS` to
command-line for build targets which currently contain AtomicString
implicit conversions, and we don't add `explicit` if it's defined.
This CL should have no behavior changes.
Bug: 1444094
Change-Id: Ia1774c5891208cffb87fb424b97da0b88c222e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607164
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156994}
[parkable_images] Enable by default
Per our stable analysis, this improvement should be enabled by default. See doc here for more details: https://docs.google.com/document/d/1bfcW3OWj54L53XAVJriCwK8yZfJzsaRMNfIQ2issxJk/edit?resourcekey=0-Ea5Ibq2LF0HDIVIWsvgW4Q#heading=h.ihqjzlmfr0kl
Change-Id: Ic9626d23914bc17d5507d59fa4d7c253e931c8b5
Bug: 1142834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608920
Reviewed-by: Benoit Lize <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Thiabaud Engelbrecht <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156993}
Roll Skia from c8d3a52bbd70 to b80cbfaf81f3 (2 revisions)
https://skia.googlesource.com/skia.git/+log/c8d3a52bbd70..b80cbfaf81f3
2023-06-13 [email protected] Port a handful of intrinsics to WGSL.
2023-06-13 [email protected] Remove SkYUVAPixmapInfo::SupportedDataTypes(const GrImageContext&)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I66748180fad5256ed6d825a1a8cca0d9f15a0ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609848
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156992}
shortcuts: Add feature flag enable-search-customizable-shortcuts-in-launcher
This flag will be used to gate the change to launcher shortcut search.
Currently, the searchable shortcuts are static. Change will be made to
search for customizable shortcuts so if a user changes a shortcut, it
will be reflected in launcher search results.
Bug: b/216049298
Change-Id: Ifc54af6994cfc195a2939a2f9d844f6242d5795b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608984
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Xiangdong Kong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156991}
Disable WebAppIntegration flaky tests
Bug: 1454377
Change-Id: I1b91cd183fe68ae86533fcedd435cef664bf4cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607066
Owners-Override: Liviu Tinta <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156990}
Roll ios_internal from 8043fd2f7f7b to cdcc9a378a9b
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/8043fd2f7f7b..cdcc9a378a9b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ifb6c2df07f22b45f32677e35b3cef95ae004052a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610790
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156989}
Roll Help App from wlLXergE09RdlhIbK... to HTQXGmqOjSBe-mEIk...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202306130800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/HTQXGmqOjSBe-mEIko8ytu8V_mp8UDjM1Rk8AE6XWJwC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/285181120
Tbr: [email protected]
Change-Id: Ic97adb2d96960ebdd90ecd288f9ac2a721628db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610865
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156988}
Move builds on Libfuzzer Upload Linux UBSan to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
[email protected]
Bug: 1412588
Change-Id: I3ef15f6ad420a5176facca92cd30656f9ca50c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610795
Auto-Submit: Ben Pastene <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156987}
Enable hash-prefix real-time components_unittests on iOS
Bug: 1441654
Change-Id: I7dad469254c5e294d848596cd5837d862b70a658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606104
Commit-Queue: thefrog <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156986}
Add missing dependency for ChromeEnterpriseRealTimeUrlLookupService
This class implicitly depends on the IdentityManager because it has the
regular RealTimeUrlLookupServiceBase as a subclass. Therefore we also
need it to be shut down before the IdentityManager.
Bug: 1453705
Change-Id: I2c4a405a8ea7d198fd405c9bbae9546a2608d3d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609499
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156985}
Update V8 to version 11.6.136.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bffc2731..89367f3a
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I68db39d3b81e9a26c21c9ba39e48f7d2fdf6416e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605464
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156984}
[Android] Add back Signin.UserRequestedWipeDataOnSignout
This cl adds back the histogram that was unintentionally deleted in
crrev.com/c/3647682. Also tests are added for this histogram.
Bug: 1451737
Change-Id: I48a4c55f351858d72d267be8aa7b70cad611ade0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608465
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156983}
[Fixit] Deflake DownloadTest tests
This CL deflakes testHttpGetDownload, testHttpPostDownload and testUrlEscaping which were found to all be failing on
android-12l-x64-dbg-tests. This maps to generic_android32_foldable and
I was able to get a repro using that AVD config. I found the while
(!cursor.isAfterLast())) was being completely skipped over for
generic_android32_foldable. I suspect the reason for this is
because the backend is now OfflineContentProvider so DownloadService
cannot be relied on. But that said the tests wait for a download
to complete and then verifies it. So I don't believe it is necessary
to verify the mechanism by which the download was acquired, just
that the end result is correct. So I've added in a utility
hasDownloaded(...) which checks if the download has occurred and
the file contents are as expected. The tests pass on both
generic_android24.textpb and generic_android32_foldable.
Bug: 1287296
Change-Id: I5639974a97ac2fb43a953e9d48ae828c5d771d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608563
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: David Maunder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156982}
Refactor ambient mode theme/video metrics.
After discussing with PM, the default ambient ui settings should count
as +1 to our usage metrics when ambient mode is enabled. This
affects the same histograms we currently have, but changes their
semantics. Hence, they're being replaced with a second version.
OBSOLETE_HISTOGRAM[Ash.Personalization.AmbientMode.AnimationTheme]=Replaced by Ash.Personalization.AmbientMode.AnimationTheme2
OBSOLETE_HISTOGRAM[Ash.Personalization.AmbientMode.Video]=Replaced by Ash.Personalization.AmbientMode.Video2
Bug: b:286440275
Change-Id: I7d3cb58a918ddbbc99361828fcda4fb4666ec3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608807
Reviewed-by: Jason Thai <[email protected]>
Commit-Queue: Eric Sum <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156981}
[Fixit] Fix testOMADownloadInterception
The condition waiting for the URL to load compares a String with
a GURL object which will always return false. This CL uses getSpec()
so the String is being compared with a String.
Bug: 1261941, 1261941
Change-Id: Ia3fe1584b05bfac5cb8ed67b096d80de79b48d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609706
Commit-Queue: David Maunder <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156980}
Revert "Flags UI: Introduce flags-experiment web component."
This reverts commit af821dc00f3bdd4e082d3cee4fe83b461359e57a.
Reason for revert: Broke UI on iOS.
Original change's description:
> Flags UI: Introduce flags-experiment web component.
>
> This CL
> - Adds a new <flags-experiment> web component (not using Polymer)
> to encapsulate the UI for each entry in chrome://flags.
> - Implements the `set data() {...}` method to correctly render the
> contents of the element.
> - Hooks up the new <flags-experiment> to the existing jstemplate
> system (jsselect=...", jsvalues="...") as an incremental step for
> eventually fully removing jstemplate usage.
> - Rewrites flags logic to account for the flags-experiment shadow DOM.
> - Removes CSS and HTML that was rendered obsolete by the above changes.
>
> Performance improvements to this UI will be made in subsequent CL.
>
> Based on https://crrev.com/c/4569468.
>
> Bug: 1376313
> Change-Id: Ia8cc0ac0c261ce535fdc6d4c59f822fc2f06da87
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582413
> Commit-Queue: Cole Horvitz <[email protected]>
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156328}
Bug: 1376313, 1454455
Change-Id: Icc30cf6b80818cabe2b142f75104846fb5d3ea18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610068
Commit-Queue: Cole Horvitz <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156979}
[dPWA] Fix Site URL opaque CHECK failure
This CL fixes the Site URL opaque check failure inside the SiteQuality
task by ensuring that the site_url_ being used is the same as the one
the task was originally triggered for, without relying on the last
committed URL from web_contents, which might change when service worker
registration happens. The site_url_ is guaranteed to be consistent since
the MLInstallabilityPromoter does not update this variable if the CHECK
condition currently failing is not passed.
Bug: 1454355
Change-Id: Iecf2ad13525ad8e03a61125cc6482472c7d2f211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610805
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Dibyajyoti Pal <[email protected]>
Auto-Submit: Dibyajyoti Pal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156978}
Revert "Flags UI: Fix highlight referenced flag feature."
This reverts commit 51c3d739bae0050a0bbef500660b6544f4a4597d.
Reason for revert: Part of changes which broke chrome://flags on iOS.
Original change's description:
> Flags UI: Fix highlight referenced flag feature.
>
> This feature was accidentally omitted in the migration of
> chrome://flags to web components. This CL corrects this by ensuring
> that the feature still works as it did before the migration.
>
> Bug: 1376313
> Change-Id: I3fc11d50126773fb346c928e3dff9e6aaf277976
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608803
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Commit-Queue: Cole Horvitz <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156575}
Bug: 1376313, 1454455
Change-Id: I628137316b7a81c53e5fb4879a28638b80d1b8bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610965
Commit-Queue: Cole Horvitz <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156977}
libassistant: Stop syncing LibAssistant V1
We have enabled LibAssistant V2 on M115 so that we can stop syncing V1
code.
Bug: b:286255033
Test: local build
Change-Id: Ic71919128c44a22a12c323a27d2bff13fe58ebfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602250
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156976}
[iOS] Lockdown Mode UI in Privacy Settings Page
Adds Lockdown Mode to the privacy settings page and related test
coverage. It also implements an info button if OS Lockdown Mode is
enabled.
This CL was not sharded because it seemed easier to implement
a simple settings page with one item. Additionally, splitting up the CL
would mean adding a pieces of code that would be nonfunctional until
other parts are added. For example, the mediator couldn't be used
properly until the view controller was added. And we can't add the
delegate protocols until they're both implemented.
Also, there is no complicated or external logic besides handling preference values and ensuring that the settings page is displayed so
we believe this should be safe to land without reverting a large CL.
UI Screenshots:
https://drive.google.com/drive/folders/12hAF9R-oKmvu_Ts1W9wc4PD751Ok0I7h?resourcekey=0-gqig-3obilZ4o1mtHuyPFA&usp=share_link
Change-Id: Ic9bb48cae8eefe2231f6a4e664edbfd8e226b77d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583112
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Joemer Ramos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156975}
WebGPU: Introduce GPUFlagsConstant
This CL has no functional changes. It makes sure GPUFlagsConstant is
used as specified in [1].
[1] https://gpuweb.github.io/gpuweb/#typedefdef-gpuflagsconstant
Change-Id: I719209fc74eb78d0f0aea7f1b4f6e6d5d5413631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608580
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156974}
[test] Compute single threaded virtual test arguments independently
Without this patch, the single-threaded test flag calculation
for virtual test suites keeps updating a shared list of arguments.
If one test in a (virtual) shard enables threaded compositing, the
entire shard runs with threaded compositing.
This patch makes sure we create independent instances
of argument lists for each test.
Bug: chromium:1454386
Change-Id: Ia0e84d550b09a9d7fcd2bed0ddfc77778c18fc7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604544
Commit-Queue: Jaroslav Sevcik <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156973}
Increase audio glitch duration threshold for exploratory on Win
Follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/4607442
Bug: 1449671
Change-Id: I0cf9462a243ebb2320c4bb2d8e44edf3830f8a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604065
Commit-Queue: Olga Sharonova <[email protected]>
Reviewed-by: Fredrik Hernqvist <[email protected]>
Commit-Queue: Fredrik Hernqvist <[email protected]>
Auto-Submit: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156972}
[aw] Add back some of JankTracker and use it in WebView
This change brings back some code that was removed
in https://crrev.com/c/4390908:
- JankMetrics.java;
- FrameMetricsListener;
- FrameMetricsStore;
- JankMetricUMARecorder.java and jank_metric_uma_recorder.h/.cc;
- Android.Jank.FrameDuration histogram with the same meaning as before.
FrameMetricsStore is simplified to only store frame durations
and jankiness. Since the listener is only used in one place currently,
the code asserts that FrameMetricsListener (and FrameMetricsStore)
methods are called on the same thread they were created.
It also adds a new Android.Jank.FrameJankStatus histogram that records
the jankiness of the frames.
Also adds a new flag WebViewReportFrameMetrics, enabled by default.
If the flag is enabled, FrameMetricsListener is registered when
an AwContents gets attached to a window, the metrics accumulation starts
when a window becomes visible. When a window becomes invisible,
all stored metrics are reported to UMA and the temporary storage
is cleared.
Also adds an empty perfetto::Track constructor to trace_event_stub.h
so that the 'JankMetricsReportingInterval' event is not recorded if
base tracing is disabled.
Bug: b/278118627
Change-Id: I015338dc17853c2d6354a06ad972004b1fd3390f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481062
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Oksana Zhuravlova <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156971}
Roll libyuv from 873eaa3bbf52 to 2a5d7e2fbc67 (1 revision)
https://chromium.googlesource.com/libyuv/libyuv.git/+log/873eaa3bbf52..2a5d7e2fbc67
2023-06-13 [email protected] FilterRows_NEON - remove unused function - same as InterpolateRow_NEON
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libyuv-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I0c962a4a6cb76b0bf1712adf43a4a3f318164db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609059
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156970}
Extend Clipboard.TimeIntervalBetweenCommitAndRead histogram expiration.
Extend Clipboard.TimeIntervalBetweenCommitAndRead histogram expiration
by six months. The histogram continues to inform the evolution of the
clipboard history feature.
Bug: 1443482
Change-Id: I46dfc1bea691cdd8436e4d524a2a8516f8cf04d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608981
Commit-Queue: David Black <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156969}
CfT: Add test for exposing internals in heap snapshots
The test ensures that on regular builds a snapshot will see
InternalNode objects but no Blink C++ objects. For CfT we ensure the
exact opposite.
Depends on: https://crrev.com/c/4547806
Cq-Include-Trybots: luci.chromium.try:win-rel-cft,mac-rel-cft,linux-rel-cft
Change-Id: Idd52cd34c4c3a4af126270a5e2cd13b91da8f459
Bug: 1446931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4538742
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156968}
[ATP] Implement tts speak options in ATP JS
Adds functionality for ATP JS to pass TTS options to tts
speak using the same interface as the chrome.tts extension
API.
For more, see the go/chromeos-atp-v8-design subsection on "C++ to
Javascript bindings, and go/chromeos-atp-api-tts, specific to the
TTS API.
Bug: b:277221897
Test: New
Change-Id: I8279e3ebe53670c3c320b7a9f43cc72876f2e5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599197
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156967}
Roll src-internal from caa0380f0b26 to ace708b60dd7 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/caa0380f0b26..ace708b60dd7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1451617
Tbr: [email protected],[email protected]
Change-Id: Ie4686994d8cafbe563e2d1f88cd0b8c8ebeb087b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609054
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156966}
Remove unused method and simplify asserts in BookmarkToolbarTest.
Change-Id: I56739bee3fece83b6870066963735d97c2178f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609529
Auto-Submit: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156965}
Add Device Authenticator functionality to check whether biometrics or
screen lock is available on Mac
This CL adds the OS-level API integration to check whether biometrics or
screen lock is available on MacOS. This will be used later in the re-
auth project to offer the opt-in prompt and the settings page toggle
even if the user only has screen lock, as currently we only have
visibility on the user having biometrics available and thus only offer
it in the biometrics case.
Bug: 4555994
Change-Id: I681e8527d273a94ecb448b518d1ad35e342aa787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595763
Reviewed-by: Viktor Semeniuk <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Reviewed-by: Sujie Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156964}
[ios] Bundle perfetto test data for content_unittests
We need to use bundle_data rather than data for this platform.
The new test data was added in crrev.com/c/4429527
Bug: 1411704
Change-Id: Ic6a51e23ce37906622a0282c2ebd65e68a1cadb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609141
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156963}
Revert "[iOS][Bookmarks] Add EnableBookmarksAccountStorage to fieldtrial_testing_config"
This reverts commit 4f0e88132fcbd125c496f337364f1c0699367f81.
Reason for revert: Speculative revert because this seems to break bookmarks related tests on ios. More details on the bug: https://crbug.com/1454483
Original change's description:
> [iOS][Bookmarks] Add EnableBookmarksAccountStorage to fieldtrial_testing_config
>
> Bug: None
> Change-Id: Iab3eedf1874f63d90b6e3e43eaaf3c80c9286e74
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608008
> Reviewed-by: Jérôme Lebel <[email protected]>
> Commit-Queue: Jérôme Lebel <[email protected]>
> Auto-Submit: Boris Sazonov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156884}
Bug: None
Change-Id: I24d49955353a5d40f2c4824ee43a5da53a492adf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608310
Commit-Queue: Ivana Žužić <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156962}
[ios] Use a single string for the close button in the sign-in sheet
Use "Close" for all entry points. Rolled out by default, discussed here.
https://docs.google.com/presentation/d/17dN2QDCkF-u_pmHhTKvIjA2OfCrRTC9Av6ThoAtMEUY/edit?disco=AAAAyuQaqCE
Bug: 1447012
Change-Id: I97f3f6b6b1aa99264d7519196d7005077cf9b1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608589
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156961}
Removed unused things from BookmarkManagerMediator.
Change-Id: I76895b4789798528c104a779ee7150373a519854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608670
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156960}
Graphite: Add unittests for IOSurfaceImageBackingFactory
This change adds unittests parameterized on formats and GraphiteDawn
GrContextType for IOSurfaceImageBackingFactory along with TODOs for
when multiplanar support will be added.
Bug: 1442381
Change-Id: Icf8177bcc65f3a20b4c3d5481038fb254df92ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599867
Commit-Queue: Saifuddin Hitawala <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156959}
Invalidate the AX subtree when recomputing NGOffsetMapping.
NGOffsetMapping determines the start and end character of text runs
corresponding to nodes in the tree. The text can depend on all of the
nodes (text and non-text) contributing to a LayoutBlockFlow. Therefore
we need to invalidate all of the descendants of the LayoutBlockFlow
when that offset is recomputed; otherwise, we might end up with
the wrong TextAlternative for an AXObject.
This is the root cause of two flaky tests for CL 4553316:
* DumpAccessibilityTreeTest.AccessibilityCSSVisibility/blink
* DumpAccessibilityTreeTestWithIgnoredNodes.InertAttribute/blink
The failures can be reproduced reliably when using this flag:
--enable-blink-features=HTMLParserYieldAndDelayOftenForTesting
Because it causes the HTML parser to yield sometimes after a text
node that has a trailing whitespace, followed by another node that
affects whether that whitespace is reflected in
LayoutText::PlainText.
Change-Id: Ifb11d7227ea311a614889eb446abbb525ce51e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602526
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156958}
[ios] Enable browser controls in cc
Allow cc to provide the feedback of the scroll offset
and viewport size to iOS. We will not listen to the
offsets of the top/bottom controls but will use the
sizing information so the iOS code can control them.
Bug: 1411704
Change-Id: I3e1170606a748339e852a12c455c6287867be5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608562
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156957}
Roll devtools-internal from 406631c4e5a0 to 3b3b3efd5bf2 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/406631c4e5a0..3b3b3efd5bf2
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a856ba8728425cdadfafa17803820beb3b092270..7bc64b80aad58846a712b8925777ddb31d02d154
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I2e3eb7efca4fc6252f58b18e99ec1000daaee593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609056
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156956}
Fixes Jaws / NVDA announcement in an empty omnibox
Currently, we expose the label of each View in its accessibility text
contents, so that it can be navigated by character
and word.
For example, the Bookmarks menu item has the label "Bookmarks"
and that is exposed in the item's text contents for accessibility,
so that the user can navigate through the item by character and by word.
However, we also mistakenly expose the label of the omnibox,
i.e. "Address and Search Bar", in its text contents.
We should only expose its value instead.
This should hold for all text fields in Views.
This behavior is the same as for the Web content,
however by mistake there has been a difference until now.
address bar is empty.
[email protected]
AX-RelNotes: NVDA and Jaws no longer announces "a" when the
Tested: Manually
Change-Id: I874230d02353dfe8d76befb296c630ed4adc3f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606994
Commit-Queue: Nektarios Paisios <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156955}
CrOS Settings: Add the toggle button for low battery sound
This CL adds the toggle button for low battery sound under Settings >
Device > Audio subpage. When the user turns on/off the button, the low
battery sound feature will be enabled/disabled.
https://screenshot.googleplex.com/7Cpa5E8TMkin5F6
https://screenshot.googleplex.com/33JHtckaEscwsvy
Bug: b/281720689
Test: browser_tests --gtest_filter=*OSSettingsDevicePageAudioPage*
Change-Id: Ibde0fae8bdd4485885b35c37057b8d95987a19af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601813
Reviewed-by: Emily Stark <[email protected]>
Commit-Queue: Hongyu Long <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156954}
[camera_preview] Add a feature flag for camera preview ui
Change-Id: I89d5d8ed3caecb79f0a9e689d9f76ecb62916d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602029
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Bryant Chandler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156953}
Roll Perfetto from 7aa646548880 to a4e9e26e3958 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/7aa646548880..a4e9e26e3958
2023-06-13 [email protected] Merge "traced: allow cross-session cloning for bugreports"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: If9d02be334a9cba0e60be0d1e93e8d85a13e20b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609055
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156952}
[camera_capture] Make camera_video_frame_handler platform independent
This code was recently moved out of Ash but there are still a few
places that were specific to ChromeOS/Ozone. This CL adjusts those.
There was also a bug with frame buffers created during teardown not
being released because the weak pointer had died. This changes how the
frame destruction handler is created so that is uses a shared
remote instead of depending on a WeakPtr to the frame handler class.
Bug: b:280299491
Change-Id: I7b08d29a818a074697b7152ca0b644a9e6bf5cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584873
Commit-Queue: Bryant Chandler <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156951}
[webui] Remove the kWebUIDarkMode flag
Currently kWebUIDarkMode is enabled for all platforms where this flag
is used (and has been for quite some time).
This CL removes this flag (cleaning up dependent tests where
necessary).
Bug: 1431202
Change-Id: I724bf5ba32da9d11f4c28f65544c26588c0992bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608921
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156950}
[password manager] Use `changeCredential` instead
Replace usage of `changeSavedPassword` by `changeCredential` on the new
password manager. This is a first step in removing
`changeSavedPassword`. Other uses of the function live in the old
password manager which is expected to be removed eventually anyway.
Bug: 1432717, 1420597
Change-Id: If85735fb515cba648ebc84697fdd16b1ac8c76bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597907
Reviewed-by: Viktor Semeniuk <[email protected]>
Commit-Queue: Nina Satragno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156949}
dlp: Simplify retrieval of DlpFilesControllerAsh
Bug: b/287011252
Change-Id: I2f6004f0f5b31c298eded82ccc2bca626f1b100f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607306
Commit-Queue: Luca Accorsi <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156948}
[Fixit] TabSelectionEditorTest GroupActionAndUndo
The way tabs with thumbnails were being created was broken. Fix it and
update the test expectations to match.
Fixed: 1420233, 1424510
Change-Id: If584e2be3903eb02667402ba7e7e5ed1cca2424f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610116
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156947}
[Fixit] TabGridDialog re-enable render tests
These tests appear to just be missing goldens. Try updating the goldens
and see if they just pass.
Fixed: 1139475, 1110099, 1065153, 1331799
Change-Id: I283291276780d843333ac72a5cd1f3cee893c19f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608493
Commit-Queue: Fred Mello <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156946}
[Info Bar] Re-enable testInfoBarForPopUp
The test is now not showing flakiness and passing on TestReviver.
Change-Id: I374077c945bff9685d99a4fa7e16712b8dad74a2
Bug: 1269025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609449
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Ritika Gupta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156945}
[Color correction] Updates color correction settings per mocks
This change updates the color correction settings in
os://settings to match the mocks.
Color correction is behind a flag while it is being developed,
you can preview these changes with
--enable-features=ExperimentalAccessibilityColorEnhancementSettings
For more, see go/cros-color-filtering
Screenshots:
https://screenshot/9YyYmpgTTenPY8M
https://screenshot/AJXFfdiaJ5LoPYy
https://screenshot/BmnqQJy8jkQZWhB (dark mode)
Test: Existing, manual
AX-Relnotes: N/A
Bug: b/259372272
Change-Id: I861abade6d84bf8a82eb0404ea62cffdbeedc2e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4602420
Reviewed-by: Josiah Krutz <[email protected]>
Reviewed-by: Meredith Lane <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Wes Okuhara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156944}
Created a unit-tests for the methods affected by the race condition
This unit-test is a postmortem action item for crbug.com/1420594
Bug: 1420594
Fixed: b/277184849
Change-Id: I5225c2090bb571eaba020f3362be133e3f8f2785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603940
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Petro Akzhygitov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156943}
[OOBE][Jelly] Fix all the error Illustration in OOBE
fix missing closing tag for the error illustration
Bug: b:268488211
Change-Id: If1ce20251148b46bf1d0921796e2c1f83c3150eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604063
Commit-Queue: Renato Silva <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156942}
Add gwsq alias to cookies OWNERS
Change-Id: I3ef572f6bd31bca7382ac174571a3d644496dc7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603679
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Steven Bingler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156941}
Roll Perfetto Trace Processor Mac from 3991a59acc7a to 7aa646548880
https://android.googlesource.com/platform/external/perfetto.git/+log/3991a59acc7a..7aa646548880
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Icfbd4888e4e05ba974edc47aa2b0fe672ed0f4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610806
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156940}
[Android] Enable NavigationHandlerTest#testSwipe...Ntp_EnterTabSwitcher
This is a speculative fix. Waiting for the layout to finish doesn't
seem enough to assert the NavigationHandler becomes inactive. This CL
adds a polling to allow more time, as the signal to wait on is not
clear.
Bug: 1435090
Change-Id: Idb421055672b944f94cbaa1cf568463d52f3bbd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603705
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156939}
viz: Re-Enable HDR promotion to overlay
Add P010 to list of buffer formats preventing overlay promotion.
Re-order colorimetry capabilities in accordance with CTA-861-F Table 56.
This allows HDR10 functionality to correctly identify available formats.
Set max luminance according to provided HDR static metadata.
BUG=1286074,b:249215983
Change-Id: I509079315fc289c6f15a5486f47fd12558686b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582604
Commit-Queue: Sasha McIntosh <[email protected]>
Reviewed-by: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156938}
Roll clank/internal/apps from 1093ec003a9c to 12d53263b4ee (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/1093ec003a9c..12d53263b4ee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1445802
Tbr: [email protected],[email protected]
No-Try: true
Change-Id: I420eaff0235adddfb2376ec5bbb849824dc550a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610788
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156937}
Change parse_values_unittest to use explicit uint8_t values.
Bug: 1322914
Change-Id: I6da6b785930ae4c21e96c4720b6e76b2f8c0cc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609194
Commit-Queue: Bob Beck <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156936}
[Gardener] Disable virtual/scalefactor200/external/wpt/largest-
contentful-paint/multiple-redirects-TAO.html for Mac13-arm64
The test vas flaky with an average flaky rate of 20.39%.
Bug: 1450287
Change-Id: I465e0dfccd2855671a640634eb0b292fd3e6ba78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608590
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ivana Žužić <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156935}
Graphite: Add YUV support to ImageTransferCacheEntry
Add necessary YUV image support to ImageTransferCacheEntry using
TextureFromYUVAImages api. Also fix a mode set issue where we should
set write mode after all SkSurfaces are created on BeginWriteAccess.
Bug: 1447546, 1443065
Change-Id: I76e1b7a9d8a1881a9b01c1a40e9c7ad1da855f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606101
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Saifuddin Hitawala <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156934}
Add shutdown to AuthHub lifecycle
Introduce Chrome-dependent elements for
AuthHub/AuthParts objects, and implement
proper shutdown logic that is triggered early
upon browser shutdown.
Bug: b:271248265
Change-Id: I5f259d8363bff4f6b316a8ad523241de766cf0dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604110
Auto-Submit: Denis Kuznetsov <[email protected]>
Commit-Queue: Denis Kuznetsov <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Reviewed-by: Anastasiia N <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156933}
Roll clank/internal/apps from ac3452043811 to 1093ec003a9c (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/ac3452043811..1093ec003a9c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
No-Try: true
Change-Id: I9a7c2be4683afcd3db1f3159d737497960c2bb78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610787
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156932}
Roll Skia from d6fa785a00aa to c8d3a52bbd70 (1 revision)
https://skia.googlesource.com/skia.git/+log/d6fa785a00aa..c8d3a52bbd70
2023-06-13 [email protected] Emit const-variables in WGSL where possible.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I7654501b612be0fc00a0bd12264e0a064765e665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610470
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156931}
Add V8 shared space memory metrics to UMA/UKM
Bug: v8:13267
Change-Id: Ib1082c7425300f252ed94e952758eec3a50308a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900372
Reviewed-by: Michael Lippautz <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Dominik Inführ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156930}
[Reauth][Settings page][Android] Fix user preference switch does not toggle
Reauth setting can be updated from the Settings page via a switch. When
toggled, this switch does not show the latest setting state. Instead, it
only updates when the page is refreshed manually.
This happens only in newer versions of Android where the Settings page is not refreshed when preferences are updated.
Fix: If the setting gets updated in the backend, toggle the switch in
the callback.
Before: https://screencast.googleplex.com/cast/NjM0NTAxMzkzNzA0NTUwNHxkYjBlZWEyZi00ZA
After: https://screencast.googleplex.com/cast/NjU0MDk0OTQwNTU2NDkyOHxiMDFjYjNkZC03Nw
Bug: 1451645
Change-Id: Ie00e2b047283202806bdd66f52265c64ca0691fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4592249
Reviewed-by: Sujie Zhu <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156929}
[CR2023] update primary background color
This CL updates the background color of bubbles, dialogs, menu,
tooltips and some other UIs to kColorSysSurface.
Bug: 1422125
Change-Id: Ied72b9ee4807319aa1c5672d34fd43cfc69e694a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603356
Code-Coverage: Findit <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156928}
Roll WebRTC from febf55853bfb to cfa0f817b730 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/febf55853bfb..cfa0f817b730
2023-06-13 [email protected] Fix DEPS path for clang-format scripts
2023-06-13 [email protected] [rct_tools/video_encoder] Add video encoder tool
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I4269c1882b9fd97261191af3f141aaf4068933f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610469
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156927}
Roll Dawn from 1300592018b4 to 8ab22d45da51 (3 revisions)
https://dawn.googlesource.com/dawn.git/+log/1300592018b4..8ab22d45da51
2023-06-13 [email protected] Roll vulkan-deps from 03253db61b9a to ca4471bb3db3 (3 revisions)
2023-06-13 [email protected] Roll ANGLE from f1e198726121 to 057b8b61b2f2 (3 revisions)
2023-06-13 [email protected] d3d11: Implement occlusion query
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I89cf436a2852dc7026f06afccc7fe78dc3e815fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610667
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156926}
[user bypass] Rename CookieControlsBubbleView
This CL just renames the CookieControlsBubbleView prefixing it with
"Old" to help cleaning up the old bubble.
Bug: 1446230, b/280779743
Change-Id: Iaeb55715ecbf5da13e10de32a9fe2ea575ed8814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608584
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Auto-Submit: Nicola Tommasi <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156925}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686657517-a2f6f8a5cce32493a9207243248901f097dce98d.profdata to chrome-mac-arm-main-1686664165-f131b4e75e5858a4c032a9e3e36ec414341756e3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If83dcab49d5dc31bd1d1b160cd94408b73f05e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609846
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156924}
[user bypass] Return the actual site counts
The controller returns the number of allowed and blocked sites using PSCS.
Bug: 1446230, b:280782400
Change-Id: I08a338bb24d5d814614cf26b71bc04b1165da5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610560
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156923}
Updater: uprev Google-branded old updater builds.
Fixed: 1454267
Change-Id: I4610e6ad57077007569d559acb5a7fae1f47611d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609324
Auto-Submit: Joshua Pawlicki <[email protected]>
Reviewed-by: Noah Rose Ledesma <[email protected]>
Commit-Queue: Noah Rose Ledesma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156922}
[Fontations-backend] Refactor font factory to use create methods
Instead of passing around FontMgr interface, use factory
methods. Preparation for adding a factory method for the
Fontations-backed SkTypeface.
No functional change.
Bug: 1454448
Change-Id: I3b4ea57ee706c6b2790be46ab0a59b905ac8604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609127
Commit-Queue: Dominik Röttsches <[email protected]>
Reviewed-by: Ben Wagner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156921}
Automatic update from google3
Automatic update for 2023-06-13 UTC
Change-Id: Iad332b626dd1eaba43de7e61ae95e2d5a05d7f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610786
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156920}
Updating trunk VERSION from 5830.0 to 5831.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: Iabcba19a4cca676af82b46008848478db88ee061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606103
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156919}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1686614843-fb023098bd54d5f9232a1aab9a5addc0eb0e66f9.profdata to chrome-chromeos-amd64-generic-main-1686657822-1c05e03f71a0211c7f890878b432651fb5f996fe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I9929b7b20a804435505257ca0c8d6ff06c95947f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610808
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156918}
Add missing Skia->SkCodec dep
An unrelated Skia change ([1]) seems to trigger chromium iOS build
failures due to missing SkCodec symbols ([2]):
ld64.lld: error: undefined symbol: SkCodec::getFrameInfo()
>>> referenced by SkAnimCodecPlayer.cpp:34 (../../third_party/skia/src/utils/SkAnimCodecPlayer.cpp:34)
>>> obj/skia/libskia.a(SkAnimCodecPlayer.o):(symbol SkAnimCodecPlayer::SkAnimCodecPlayer(std::__Cr::unique_ptr<SkCodec, std::__Cr::default_delete<SkCodec>>)+0xb5)
...
The issue appears to be that SkAnimCodec is part of skia_utils_private,
always included in the core skia component, while it depends on SkCodec,
which is only included conditionally for use_blink builds.
We need to also enable skia_codec_core whenever skia_utils_private is
used.
[1] https://skia-review.googlesource.com/c/skia/+/705232
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4609089
Change-Id: Icb80e9d7e29797ef14c139514c38e6e46a91532a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606124
Commit-Queue: Florin Malita <[email protected]>
Reviewed-by: Kevin Lubick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156917}
[A11y] Simpler more reliable method for determining slot relevance
Previously, we guessed whether a slot's subtree should be pruned based on whether it had layout, but this seems hacky and potentially unreliable.
The new code is more direct and uses flat tree traversal to see if thereis an assignment.
This is a speculative fix for some of our problems with nested slots.
Does not regress performance for key testcase in https://crbug.com/1447357.
Platform tests do not change other than Fuchsia (because Fuchsia is incorrectly including ignored nodes in its platform tree). Filed https://crbug.com/1454069 on Fuchsia for this.
Bug: none
Change-Id: Ic33c6e7a9f677f91feb907055124706f4186a882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577617
Auto-Submit: Aaron Leventhal <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156916}
Revert "ChromeRefresh2023: Update more internal paddings for tabs."
This reverts commit e43b91dfc320216182d500153619614bcb5cde60.
Reason for revert: This caused regressions for GM2TabStyle. I will approach the ContentInsets changes differently.
Original change's description:
> ChromeRefresh2023: Update more internal paddings for tabs.
>
> for favicon/close/title/alert icon...
> - Update vertical paddings
> - Update horizontal paddings between components
>
> Bug: 1399942
> Change-Id: I2592bace41d4566a3fb3e783e02159ae7754864f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569048
> Reviewed-by: Shibalik Mohapatra <[email protected]>
> Auto-Submit: David Pennington <[email protected]>
> Reviewed-by: Peter Boström <[email protected]>
> Commit-Queue: David Pennington <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1155187}
Bug: 1399942
Change-Id: I98b11545764ca32aabb5f3e91c745dbaae5be419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609551
Reviewed-by: Peter Boström <[email protected]>
Auto-Submit: David Pennington <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156915}
Validate origins_per_site_window cannot be non-positive
Bug: 1448836
Change-Id: Ia42db817b8578fbf162d4db84b851607c4481fbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610541
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156914}
[A11y] Ensure cursor, caret highlights show in docked magnifier
Moves caret and cursor highlight into the window
kShellWindowId_AccessibilityBubbleContainer, which is
drawn by DockedMagnifier, rather than just as layer in
the root window.
Test: Manual, existing
Bug: b:260206764
Change-Id: Icfaa38f4e4c5dcfc91e6b206162658e797e68f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608882
Reviewed-by: Akihiro Ota <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156913}
Store aggregation coordinator origin for aggregatable reports
This CL keeps the aggregation coordinator entity concept within the
aggregation service layer, and plumbs the origin through the browser
which is stored in the database for later retrieval. The origin is
stored instead of the enum to ensure that if the origin is updated via
finch the new origin is not used for existing reports.
In the case that the origin changes via finch, the existing aggregatable
reports stored with the previous origin will be lost.
Note that it has been manually verified that the proto schema change
doesn't cause data loss.
Bug: 1450241
Change-Id: Iaab9872063dd27607abc47a887442d2a24f86038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4588251
Reviewed-by: Andrew Paseltiner <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Alex Turner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156912}
Use LacrosOnly mode for UnpinnedBrowserShortcut test.
Currently, the test depends on LacrosPrimary, which is going to be removed.
This CL replaces it by LacrosOnly.
BUG=1448575
TEST=Tryjob
Change-Id: Ia8aa5914e767cfa49f7adb1efc99c88eaa65a764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609752
Commit-Queue: Hidehiko Abe <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Auto-Submit: Hidehiko Abe <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156911}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686646533-810643a588bcd868a7f5f0d2d1515bdb57034675.profdata to chrome-win32-main-1686657517-05553064cc9a41ef296e221b265c2362c4254216.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I0393c5cb859fefe89806fdd994ac78e28f22ea9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610503
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156910}
[iOS] Open credit card details outside settings context
Bug: 1454219
Change-Id: Ibd5e2249dca6571d7f25ef4315e883bf7fcd4d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603761
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Veronique Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156909}
Extend expiry of SafeBrowsing.FileTypeUpdate.DynamicUpdateVersion
This histogram is monitored by alerts to help detect problems in the
server-side configuration for the file type policy. While we aren't
pushing new versions very frequently lately, I think we still want to
know about misconfigurations.
Fixed: 1454180
Change-Id: I6c40baf3b43b61e80ba63b1b8638bfd89c4b0ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609707
Commit-Queue: Lily Chen <[email protected]>
Auto-Submit: Daniel Rubery <[email protected]>
Reviewed-by: Lily Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156908}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686646533-e2775d1023b9e23bad18f39e678bb78355608502.profdata to chrome-win64-main-1686657517-dfc3ec36cfe59c606c3820dc0b1500d86a337274.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Ia58e9c5fbe6c89faa9fc5e30cb76e956281c3cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610705
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156907}
Update V8 to version 11.6.132.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/11fbb5de..bffc2731
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Id99416add4f3101d46bb19641236eb8c899fb046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610600
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156906}
[DTC] Add Histogram to Measure Signature Latency
The new histograms will measure the latency in ms for signing payloads.
Different histograms will be logged based on the key trust level.
This CL also updates some existing metrics code and expiration date.
Fixed: b:257967153
Change-Id: Ib94e7958523e29fd007cea1d9329960a4e8a164c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605532
Code-Coverage: Findit <[email protected]>
Commit-Queue: Sébastien Lalancette <[email protected]>
Reviewed-by: Hamda Mare <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156905}
DanglingPtr: mark unretained dangling ptr in ChipController
Doc:
https://docs.google.com/document/d/1YQCh_mezoSF1fWS9TaMEh0Whumb8eNe0KWV8MBs7sFs
We detected those callbacks are invoked using dangling pointers.
This is something we would like to detect and potentially ban.
In the meantime, we need to annotate them using:
base::UnsafeDanglingUntriaged
Outside of the experiment, it is a no-op.
Within the experiment, it skips DumpWithoutCrashing.
Bug: 1451525
Change-Id: I4800f620e6b13b1da3067a900ef2a34d0ee07323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598110
Reviewed-by: Florian Jacky <[email protected]>
Commit-Queue: Paul Semel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156904}
Add migrate storage to BDM feature
Bug: 1271155
Change-Id: I0de65a1ee17ec46d1d61bb9df4b0dec57d61475d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607452
Commit-Queue: Mariam Ali <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156903}
Replace forward declarations of SkPromiseImageTexture with #include
In http://review.skia.org/710679 we are moving and renaming this type.
The shim typedef we have conflicts with the existing forward declares
in chromium, so I am replacing them with an #include until we can
do the migration.
Bug: skia:14317
Change-Id: I95edc189bb3f75c1d1b69d9250bdbc3d2982952b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608923
Commit-Queue: Kevin Lubick <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Auto-Submit: Kevin Lubick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156902}
[aw][tracing] Add an empty event after the 'WebView Instance' end
Bug: 1452205, b/280436352
Change-Id: I88536e3ed4c4fb3a963f221e3e94d3025467e959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605681
Commit-Queue: Oksana Zhuravlova <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156901}
Roll Website from 49154ec4365f to 577051d39146 (1 revision)
https://chromium.googlesource.com/website.git/+log/49154ec4365f..577051d39146
2023-06-13 [email protected] Update HowToRequestChromeSecurityReviews doc with informal reviews and ISE/OWP review info
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I06a021b3a8df8d50cd027572f565af5e1e5d9feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610465
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156900}
Disable ExternallyManagedAppManagerBrowserTes::CannotFetchManifest
Test flaky, example failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/10291/overview
Bug: 1452018
Change-Id: I7363032c85b17dcc946067ef1ecc9bc71853e0cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610686
Reviewed-by: Ivana Žužić <[email protected]>
Commit-Queue: Liviu Tinta <[email protected]>
Auto-Submit: Liviu Tinta <[email protected]>
Owners-Override: Liviu Tinta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156899}
Roll ANGLE from 057b8b61b2f2 to 7e075469ff02 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/057b8b61b2f2..7e075469ff02
2023-06-13 [email protected] A23: Improve end2end SKIP lines and add FAIL lines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ie64ffa8f73d9c84d35448be57e1014f9563bca16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610419
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156898}
Make GetFunctionPointerFromNativeLibrary take a const char*
Disappointing as it is to get a bare pointer in there, every
implementation of this function calls an underlying function (usually
dlsym) that needs a NUL-terminated string. base::StringPiece is not
suitable here because a base::StringPiece is not guaranteed to be
NUL-terminated.
We could convert to a std::string first, or take a const std::string&,
which would guarantee NUL-termination, but every caller of this function
passes a string literal, so just use const char*, as that's the closest
thing we have to a type that means "borrowed NUL-terminated string".
Bug: none
Change-Id: I29c1860ef82ded2b19aad62ed6f8212f76bbd71a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603320
Reviewed-by: danakj <[email protected]>
Auto-Submit: David Benjamin <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156897}
Speed up fast-path CSS parsing of double decimals using SIMD.
Since we only support seven decimals anyway, we can do all of them
pretty much in parallel. We support SSE2 (for 64-bit x86) and NEON
(for 64-bit Arm, in particular M1), with slightly different strategies.
Perf test (MotionMarkMultiply, Alder Lake) goes from 67.315 to
58.942 ns/iteration (+14.2%). M1 is +~7%. (The “before” performance
number is different from the last patch, since there was a rebase
in between.)
Change-Id: I16a1f125653aa8c2d313c81e2274c2ea7f3b623f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601370
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156896}
Roll devtools-internal from d1386e22dbb5 to 406631c4e5a0 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/d1386e22dbb5..406631c4e5a0
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ebe2109e5a89b2e00c530ea8baf4bcf95a28b943..a856ba8728425cdadfafa17803820beb3b092270
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I20c350fc07dc035ab9166666c37d5733e5176e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610707
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156895}
Roll Perfetto Trace Processor Win from ffbddef8f351 to 7aa646548880
https://android.googlesource.com/platform/external/perfetto.git/+log/ffbddef8f351..7aa646548880
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic57811d5c3b1f927688748258782f834331d3a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609959
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156894}
[Gardener] Disable flaky external/wpt/pointerevents/touch-action-with-
swipe-dir-change.html?touch on Mac 11 and 12 arm 64
The test
external/wpt/pointerevents/touch-action-with-swipe-dir-change.html?touch
is very flaky (61.86% average flaky rate).
For the reasons described in https://crrev.com/c/4606993, the best way
to resolve the flakiness is to add new test expectations according to
the possible outcomes of the test.
Bug: 1453982
Change-Id: Icaee1eec915731d76820ea1124a6ec7755597d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608049
Reviewed-by: Ioana Pandele <[email protected]>
Commit-Queue: Ivana Žužić <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156893}
Linear buffer modifier for front buffer rendering
Bug: 1442222
Change-Id: Iaa2dffe572cffde50a4c5adc295d7af448770494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608821
Commit-Queue: Peter McNeeley <[email protected]>
Reviewed-by: Kramer Ge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156892}
[attribution-reporting] Add insecure taint tracking metrics
This CL adds a NavigationHandle-scoped UserData class that tracks
a navigation's "insecure taint" i.e. whether it ever received a response
from an insecure origin.
Bug: 1454091
Change-Id: I58d48ed7cee1184a7b4462f60bc415f255e6572c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600300
Commit-Queue: Charlie Harrison <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156891}
[Fixit] TabGridAccessibilityHelperTest
Fix failing tests which seem to stem from the following:
1) Start surface vs Start Surface Refactor have different onView
parents. (Set one consistent flag set).
2) If scrolled out of view getting the RecyclerView ViewHolder is
flaky.
3) Small phones don't get span count = 3. Skip those sections.
Additionally:
* Batch tests
* Throw ViewMatchExceptions to aid in debugging in future
Fixed: 1368279, 1332995, 1318394, 1371231, 1332934, 1318376, 1306823, 1146575
Change-Id: Ica6d65fd4a53a7270aa5e066f0307ccb7772fe4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604877
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156890}
[Fixit] Re-enable TabListContainerViewBinder show/hide tests
testHidesWithAnimation appear to be already passing reliably. Possibly
due to recent improvements to the animation timing/logic.
The disable-if only apply to Nexus5x (bullhead) CFI bots which we can
re-disable if needed. I cannot find any references to it or find it
on the waterfall/test runner list.
Fixed: 1182554, 954145, 1063987, 1338258
Change-Id: Ia948ab8e1c48eff70a138a18f054eb4aed3371b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605463
Commit-Queue: Calder Kitagawa <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Commit-Queue: Fred Mello <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156889}
Roll R8 from 35Zwd7tLHQKr_VieK... to AostPkk2hQv2Pz7k7...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: [email protected]
Change-Id: I7c2a5f9959dc075ee48a1258d8221ef5a830d920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610501
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156888}
[UPMLocalPwd] Allow the migration warning to wait in the queue while
another bottom sheet is displayed
The changes in PasswordMigrationWarningView ensure that the fragment
will only be set when the bottom sheet is actually visible.
The logic to trigger the bottom sheet dismissal if it was not shown
immediately is removed from the PasswordMigrationWarningViewBinder to
allow waiting for the bottom sheet to be shown.
Bug: 1451827
Change-Id: Id60a26ab2cd23b12c652322711eb793c241592af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595064
Commit-Queue: Anna Tsvirchkova <[email protected]>
Reviewed-by: Ioana Pandele <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156887}
Refactor report_scheduler
Move real time reporting related logic into own classes.
Additionally, make real time reporting no longer depends on the regular
status report. Note that extension request still depends on status
report which is controlled by its PolicyHandler.
Change-Id: Ib7c094efac1485667657bb4ae352b4b70e8f7cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584953
Reviewed-by: Anqing Zhao <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Igor Ruvinov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156886}
Roll WebRTC from e370f2f627e3 to febf55853bfb (4 revisions)
https://webrtc.googlesource.com/src.git/+log/e370f2f627e3..febf55853bfb
2023-06-13 [email protected] Revert "Adopt EglThread in EglRenderer"
2023-06-13 [email protected] Roll chromium_revision 0e945e28ee..2710d66105 (1156642:1156780)
2023-06-13 [email protected] Update WebRTC code version (2023-06-13T04:07:18).
2023-06-13 [email protected] Roll chromium_revision a3f4dda807..0e945e28ee (1156488:1156642)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I13d250364b5eb5d2e4be055fa1832942e87eaa1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610416
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156885}
[iOS][Bookmarks] Add EnableBookmarksAccountStorage to fieldtrial_testing_config
Bug: None
Change-Id: Iab3eedf1874f63d90b6e3e43eaaf3c80c9286e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608008
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Auto-Submit: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156884}
Roll Fuchsia Internal Images from 13.20230613.0.1 to 13.20230613.2.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-internal-images-roller
Tbr: [email protected]
Disable-Retries: true
Change-Id: I1bfecc9cd44734e642da8bf2ef38d7f30b745248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608398
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156883}
Roll Skia from 42e852f1c246 to d6fa785a00aa (10 revisions)
https://skia.googlesource.com/skia.git/+log/42e852f1c246..d6fa785a00aa
2023-06-13 [email protected] Revert "[skottie] add functionality for get, set, and tracking image slots to SlotManager"
2023-06-13 [email protected] [Fontations] Implement onGetTableTags()
2023-06-13 [email protected] Roll SK Tool from ecc1c77185cb to 94c481e189bc
2023-06-13 [email protected] Roll Skia Infra from c5beac3c360b to ecc1c77185cb (2 revisions)
2023-06-13 [email protected] Roll ANGLE from 10380f4ba473 to 1572f609c18e (9 revisions)
2023-06-13 [email protected] Roll Dawn from 3a77c42f230d to bfe346b8723e (11 revisions)
2023-06-13 [email protected] Fix missing include in SkJpegXmp.cpp
2023-06-13 [email protected] Roll vulkan-deps from 2219aacad808 to 13e40cf948ed (13 revisions)
2023-06-12 [email protected] [skottie] add functionality for get, set, and tracking image slots to SlotManager
2023-06-12 [email protected] Remove ddl from SkSurface
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1430956,chromium:543704
Tbr: [email protected]
Test: Test: Test: Build and run traces on armv9 devices
Test: Test: Test: atest CtsSkQPTestCases
Change-Id: I9fa4bfc591f58f0e664340305b4536ab61ac7c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610464
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156882}
COOP: restrict-properties 9/*: Block named targeting across browsing context groups.
This patch disables named targeting between frames not belonging to the
same browsing context group in the same CoopRelatedGroup. This is done
in LocalFrame::CanNavigate by checking the two Frame's Page's browsing
context group tokens and CoopRelatedGroup tokens. This path is used for
all target resolution based on name, be it window.open(), anchor target,
form targets, etc.
The state of named targeting and name availability after this patch:
- Frame targeting is blocked in the renderer.
- Frame navigations, more specifically, were already checked in the
browser process in RenderFrameProxyHost::OpenURL.
- Name updates are still carried out to all existing proxies. Proxies
between browsing context groups are limited to the direct group boundary
(the opener or the openee). Therefore we leak name updates of these
boundaries to a compromised renderer.
Further leak reduction is planned, tracked here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1370357
This patch also corrects tests that were outdated after we decided to
clear names when swapping browsing context groups in the same
CoopRelatedGroup.
Bug: 1221127, 1370350
Change-Id: Ieb7b55d02dc266613b45b54299e8e9798462f4eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583211
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Arthur Hemery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156881}
Updating XTBs based on .GRDs from branch main
Change-Id: I9e713b84c7fa5080d145698b6e523a58bb734a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608205
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156880}
Revert "[WebAuthn] Use consistent namespaces in components/webauthn"
This reverts commit f89b7794da86852bd0a68e13eb1828f078857f7f.
Reason for revert: Introduces compilation errors on mac, see: https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-on-arm64-rel/74213/overview
Original change's description:
> [WebAuthn] Use consistent namespaces in components/webauthn
>
> The WebAuthn component code currently uses a mix of namespaces, which
> are spread between `webauthn`, `components`, and no namespace at all.
>
> The first of those is the correct one for most cases. This change
> normalizes that.
>
> Change-Id: I364ddf066144e3910a294c949f77018cbd0a89cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604895
> Commit-Queue: Ken Buchanan <[email protected]>
> Reviewed-by: Rouslan Solomakhin <[email protected]>
> Reviewed-by: Martin Kreichgauer <[email protected]>
> Code-Coverage: Findit <[email protected]>
> Reviewed-by: Vasilii Sukhanov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156876}
Change-Id: I5d686ff38e35e4dbb46f2cef9c6a3d8d3f9b96ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609881
Auto-Submit: Liviu Tinta <[email protected]>
Reviewed-by: Liviu Tinta <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Liviu Tinta <[email protected]>
Owners-Override: Liviu Tinta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156879}
[Screenshot remote command]: Only take screenshot when it's allowed
Previously we would request screenshots, even when it was not allowed.
These screenshots would then simply be dropped after being taken.
This was detected while investigating http://b/283890347,
but at this point I do not think this was the actual cause of that
issue.
Bug: b/283890347
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: Ib5dcf3299927e62e517e3bf0938de67b9cc5c9c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607292
Reviewed-by: Jana Grill <[email protected]>
Commit-Queue: Alexander Hendrich <[email protected]>
Auto-Submit: Jeroen Dhollander <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156878}
Roll Perfetto Trace Processor Linux from f8916bc6637d to 7aa646548880
https://android.googlesource.com/platform/external/perfetto.git/+log/f8916bc6637d..7aa646548880
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I3fca3b52caadcd7212ae8d971c5d027c04880b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610646
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156877}
[WebAuthn] Use consistent namespaces in components/webauthn
The WebAuthn component code currently uses a mix of namespaces, which
are spread between `webauthn`, `components`, and no namespace at all.
The first of those is the correct one for most cases. This change
normalizes that.
Change-Id: I364ddf066144e3910a294c949f77018cbd0a89cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604895
Commit-Queue: Ken Buchanan <[email protected]>
Reviewed-by: Rouslan Solomakhin <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156876}
Roll devtools-internal from e8acd1ef704e to d1386e22dbb5 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/e8acd1ef704e..d1386e22dbb5
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c3b83d98fe8371db601fbd9a4a9f3a4d9924362b..ebe2109e5a89b2e00c530ea8baf4bcf95a28b943
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Iec6d6aa65c29c3b05b5faadb9371a3697c4bd2df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609559
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156875}
Remove tracing-model-storage layout test
It was replaced with a DevTools unit test in crrev.com/c/4608328.
Bug: 1450174
Change-Id: Iebcca515a8fc19c5f66955b639089db75d4a2e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607455
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Mathias Bynens <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156874}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686649808-9a861ea31b8632a25c4d36bef0e3ec8cb8e5e632.profdata to chrome-mac-arm-main-1686657517-a2f6f8a5cce32493a9207243248901f097dce98d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8919d67ae97b3194ae6e85f7953dd929a9bfe750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610417
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156873}
[iOS][Toolbar] Add pref observer in ToolbarMediator
Add preference observer in ToolbarMediator to observe changes in omnibox
position preference.
This will be later used to switch between top and bottom omnibox.
Bug: 1453279
Change-Id: I8e928ebbffdc251cf959f1aec8d7baf885220d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598157
Commit-Queue: Christian Xu <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156872}
[maglev] Rename Maglev experiment in field trial config file
Bug: v8:7700, chromium:1400281
Change-Id: Iea4db0cba3269f6fedae9ec967dfcf8bab2423e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610203
Auto-Submit: Victor Gomes <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Commit-Queue: Leszek Swirski <[email protected]>
Commit-Queue: Victor Gomes <[email protected]>
Quick-Run: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156871}
Cronet: Use assertThrows for FakeTests
Bug: b/280423217
Change-Id: I9076b7d63de4f9d4ddf9f430f5ade6b5415ead5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604770
Commit-Queue: Chidera Olibie <[email protected]>
Reviewed-by: Stefano Duo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156870}
Roll clank/internal/apps from 37fa3ad981bc to ac3452043811 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/37fa3ad981bc..ac3452043811
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
No-Try: true
Change-Id: Iba5fdf4cfb91e552c739fc33aa2d64f571d5ee38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608399
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156869}
Remove stale Blink expectations
Autogenerated CL from running:
//third_party/blink/tools/remove_stale_expectations.py --project chrome-unexpected-pass-data --no-include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --large-query-mode --num-samples 200 --jobs 2
Affected bugs for CL description:
[email protected]
Bug: 1196620, 1249176, 1290077
Change-Id: Ic7367383bcdce8948fffc7ac416e574c438673ec
Fixed: 1180479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609407
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chromium-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156868}
[Autofill][Android] Make the unit tests for autofill popup controller run on Android
This CL ensures that the existing tests are able to run on Android.
Bug: 1454400
Change-Id: I560661e458853315395eb4bd58544355950a7989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608006
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156867}
Fix auth dialog crash when GetColorProvider return a nullptr.
Bug: b:286093936, b:286925723
Change-Id: Id98f3a484338e649042ef678d662957d0533affc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607303
Commit-Queue: Istvan Nagy <[email protected]>
Reviewed-by: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156866}
base: enable unretained pointer check by default
A finch experiment was run until stable 50% to make sure we catch most
of the occurrences of those dangling pointers. Meanwhile, most of them
were fixed in a code health rotation, which reduces the amount of
currently marked dangling pointers.
Although the Finch experiment was configured to use the
"dump_without_crashing" option, our end goal was to make the process
crash when using such dangling pointers, and the amount of crashes we'll
get will be limited by the fact we caught most of them during the Finch
experiment.
Change-Id: Iacc62813e20160849971b19d2d77a2faef66f2b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598428
Commit-Queue: Paul Semel <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156865}
[iOS] Remove DCHECK for existing ViewController in showReadingList
The Reading List ViewController can be opened again when an old one is
dismissing, for instance when tapping on the NTP icon quickly at the end
of the swipe down animation.
Since this case is now allowed and handled in crrev.com/c/4596057, the
DCHECK ensuring that the previous coordinator is closed before opening
a new one is not needed anymore.
Fixed: 1434711
Change-Id: Iea154a348db154c6ec16f37d5a7085f58b45cb84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598872
Commit-Queue: Menghan Yang <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156864}
Roll Perfetto Trace Processor Linux from 3991a59acc7a to f8916bc6637d
https://android.googlesource.com/platform/external/perfetto.git/+log/3991a59acc7a..f8916bc6637d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I11cd61bd1134ebca7808023fc5ced4b6bbd06722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610409
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156863}
Delete testHideBrowserControlsAfterFlingBoosting
The test has been disabled since 2018.
When attempting to re-eanble, the following break:
1.) Adding an observer for the GestureListenerManager requires
being on the UI thread
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java;drc=17b782a721f7f657ff7f81fc36732cda16c5d5c4;l=416
2.) Fling end is getting called before the second fling starts
(seemingly part of the initial fling event causes the fling end
to be broadcast). Resulting in this to fail 100% of the time:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java;drc=17b782a721f7f657ff7f81fc36732cda16c5d5c4;l=439
3.) The viewport callback logic was removed and is no longer called
ever:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java;drc=17b782a721f7f657ff7f81fc36732cda16c5d5c4;l=418
Rationale for deleting the test is that this is really aiming
to test ordering of scroll events, and doesn't need to be so
tightly coupled with the fullscreen manager concept at all. If
we need to revive this test, we should write it as an integration
test of Flings and drop the omnibox scrolling testing out of it.
But since we haven't had any issues in 5 years since this test
was disabled, simply deleting it seems justified.
BUG=901280,1331535
Change-Id: I2e5c446e9b05a0905e0f9bbdc17a16162bf617d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608574
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Auto-Submit: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156862}
dlp: Persistent Files desktop notifications
The desktop notifications for warnings or blocked files should stay
open until the user dismisses the notification.
[email protected]
Fixed: b:285568350
Change-Id: Ifcf9e4f8660d1c7eec8a67a148969c7b83b6c40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595117
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156861}
Disable test to land crrev.com/c/4607248
Bug: 4607248
Change-Id: I536f1885e23328c9ea7971960be2b05606f94e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607251
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156860}
dlp: Create notifications in FPNM
Moves creation of Files Policy notifications from SystemNotificationMgr
to FilesPolicyNotificationMgr, which should be in charge of all UI for
data protection files policies.
Change-Id: I9f3a8f28a892a8cc3809e4c4490880f555b84c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604090
Reviewed-by: Aya Elsayed <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Aida Zolic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156859}
Roll Perfetto from f8916bc6637d to 7aa646548880 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/f8916bc6637d..7aa646548880
2023-06-13 [email protected] Merge "traced: preserve UUID LSB when cloning a session"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Id43b337548eedc1aae77c922d765db58b5e59243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610502
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156858}
Roll Perfetto Trace Processor Mac from 67cf047d357b to 3991a59acc7a
https://android.googlesource.com/platform/external/perfetto.git/+log/67cf047d357b..3991a59acc7a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I9fe510410193cb2a7870c6eeada4e0247f38925c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608517
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156857}
COOP: restrict-properties 8/*: restrict properties based on tokens.
Introduce DOMWindow cross origin properties restriction, based on the
previously plumbed BrowsingContextGroup and CoopRelatedGroup tokens.
When the verification function is called, we check that the blink::Page
held tokens match or throw a DOMSecurityError.
This added to the properties getter and setter that are flagged as
accessible cross origin. This is done via a modification of the V8
bindings.
Also add tests to cover most BrowsingContextGroupInfo propagation code
and the DomWindow restriction that go with it.
Bug: 1221127, 1370351
Change-Id: Idb760d387557d1ee65bdea9a09d577f6b7bcdb44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546181
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Arthur Hemery <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156856}
Update V8 to version 11.6.129.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f17f0ba5..11fbb5de
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I81a07a134aa0373ac89c865189412c4264595862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609305
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156855}
Add strings for Lacros back migration cancellation
Add the strings and the corresponding screenshots ahead of the actual
implementation so that the strings can already go to translators.
Bug: b/272017148
Test: None
Change-Id: I6937b3f1fca5be23630e085a9840fb71f36ca701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609123
Commit-Queue: Jana Grill <[email protected]>
Reviewed-by: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156854}
WebNN: Implement the fuzzing test of
WebNNGraphImpl::ValidateAndBuildGraph interface
This CL implements the fuzzing test of
WebNNGraphImpl::ValidateAndBuildGraph() to validate GraphInfo mojo
struct.
Bug: 1273291
Change-Id: I1f22efd54b930572847ad167eeae9e37fcc1b5f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546121
Reviewed-by: Jonathan Metzman <[email protected]>
Reviewed-by: Rafael Cintron <[email protected]>
Commit-Queue: Lisha Guo <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156853}
WebGPU: Make create{Render,Compute}PipelineAsync IDL spec-compliant
This CL removes the optional bit of the returned promise result for
both GPUDevice createRenderPipelineAsync and createComputePipelineAsync
methods. It has no functional changes.
[1] https://gpuweb.github.io/gpuweb/#ref-for-dom-gpudevice-createrenderpipelineasync%E2%91%A0
[2] https://gpuweb.github.io/gpuweb/#ref-for-dom-gpudevice-createcomputepipelineasync%E2%91%A1
Change-Id: I8ca3aa5fc31a3cf5aa20c9330a2f6b699c66155d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608420
Commit-Queue: Fr <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156852}
Roll Cros Components from 34d764ac696f to c8df6d3cf168
2023-06-13 [email protected] Internal change
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-components-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Change-Id: I18a230c67792300b4d58098c1377b4f5d284bb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609618
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156851}
[iOS][Toolbar] Move setLocationBarViewController to AdaptiveToolbar
Secondary toolbar would also need so set locationBarViewController to
move the omnibox at the bottom.
This CL moves setLocationBarViewController from primary to adaptive
toolbars.
Also, updates self.started to _started in adaptive to avoid collision
with the same property from subclasses.
Bug: 1453202
Change-Id: Ic895f206eaf9566b252cc682d812021f5b082d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598111
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Christian Xu <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156850}
[//ui] Move gl_image_test_template.* to sit next to its one consumer
This file will relatively shortly be going away. In the meantime, this
CL moves it to sit next to its one consumer (and in the same GN target)
to facilitate moving the codebase to talking in terms of
GLImageNativePixmap rather than GLImage in a followup CL.
Bug: 1324249
Change-Id: Ia931309442091a13bb14a2a275e84418623a4a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607291
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156849}
Close drawer when side menu item is selected
Fixed: 1454391
Change-Id: Iab1c0df55c8e2be37a5afcbc768d4b7dcd934c38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610202
Reviewed-by: Andrii Natiahlyi <[email protected]>
Commit-Queue: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156848}
[Sync] Delete outdated comment in fake_sever helper.
Change-Id: I74541f5259df5b25451e0584b8cb2ae1854f210b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607212
Reviewed-by: Maksim Moskvitin <[email protected]>
Auto-Submit: Elias Khsheibun <[email protected]>
Commit-Queue: Maksim Moskvitin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156847}
[Android][Autofill] Make shouldTriggerDoneCallbackBeforeCloseAnimation part of model.
Bug: 1435314
Change-Id: I7c099fe9633698a72e3a3746e518a8b00c394ff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607445
Commit-Queue: Timofey Chudakov <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156846}
Roll Projector App from c7Gj4-HfeoJLNJkVk... to 4XKZfAUsV0HxB3ygo...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202306130100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/4XKZfAUsV0HxB3ygoh4sV9xIAwd79AKpqZCRYmVyV4wC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/269519869
Tbr: [email protected]
Change-Id: Ie21bf0429133b83bbe6d126bf2ddef36ed660452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610161
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156845}
dlp: ScopedFileAccessDelegate helper functions
Add some ScopedFileAccessDelegate helper functions that will simply
forward a ScopedFileAccess::Allowed object in case
ScopedFileAccessDelegate::HasInstance returns false. This is done to
simplify client code in simple scenarios where the same code when a ScopedFileAccessDelegate instance exists or not has to be
executed.
Change-Id: I9eac67500e65deb52dd538f691a5e1c01b1c0288
Bug: b/286505315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599152
Reviewed-by: Aya Elsayed <[email protected]>
Commit-Queue: Luca Accorsi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156844}
[Sync] Fix typo.
Change-Id: I36afe4486110b2817d0b3f5f37dd0bdc7176e0a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608071
Reviewed-by: Maksim Moskvitin <[email protected]>
Commit-Queue: Maksim Moskvitin <[email protected]>
Auto-Submit: Elias Khsheibun <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156843}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1686635928-0a4a84f588b160d0bcee43cdb2ff5df8b1d91b38.profdata to chrome-win64-main-1686646533-e2775d1023b9e23bad18f39e678bb78355608502.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I1f4ffcbaec70b2d6ce2f7e7aa157b9bdd8bf30c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609557
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156842}
[iOS][Toolbar] Fix side swipe from NTP to non-NTP
An error was introduced during the last refactor. The primary toolbar is
not made visible during side swipe.
https://chromium-review.googlesource.com/c/chromium/src/+/4594557
This CL makes the the primary toolbar visible during a snapshot.
Bug: 1454119
Change-Id: Idb72a7b192a2b7960f2beb703ba2c700941bd3b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603943
Auto-Submit: Christian Xu <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156841}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686635928-776da45e30ac4c3b47d01413579f09a954ecb019.profdata to chrome-win32-main-1686646533-810643a588bcd868a7f5f0d2d1515bdb57034675.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I372ab60779a2223cb55fe6f60edbe1fa0b2e4323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609558
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156840}
Roll Perfetto from 3991a59acc7a to f8916bc6637d (2 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/3991a59acc7a..f8916bc6637d
2023-06-13 [email protected] Merge "Remove obsolete BlinkGC metrics"
2023-06-13 [email protected] Merge "Add a thread_executing_span stdlib"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ice7b9e15b1976139ce8777b9e4b6d4a8b965ad96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608396
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156839}
Skip pixel-snapping in SetLocationAndUpdateOverflowControlsIfNeeded()
Bug: 1450757
Change-Id: I767f53a453d642bfa64374942949ab6b4973e548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603366
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156838}
Remove user-timing and console-timeline web tests
Both of these tests are covered in DevTools Frontend. We use the new
trace engine to parse user timings (including console.time APIs) and
have unit tests covering this behaviour in DevTools.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/test/unittests/front_end/models/trace/handlers/UserTimingsHandler_test.ts;l=1?q=timingshandler_test&sq=&ss=chromium%2Fchromium%2Fsrc
Bug: 1450174
Change-Id: I3e53cdf9e08bbcf72d2ccbb99a58ce5def704378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608306
Auto-Submit: Jack Franklin <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156837}
Enable screenshots for Incognito tabs
Before this CL, all screenshots in incognito were disabled whether they were initiated in recents screen or when Chrome is in foreground. The only way for users to enable screenshots is to manually enable the kIncognitoScreenshot flag, which enables all screenshots without privacy considerations.
This CL uses the new API introduced in Android T setRecentsScreenshotEnabled to disable screenshots in recents screen while enabling them in other contexts on Incognito.
Demo: https://drive.google.com/file/d/1BA2pVgxxyXPqa6hSXqPsRKt56QgZbuER/
Bug: 985245
Change-Id: I44d6a8f3da34cee99550925b25634fe6bae238e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4135877
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Rohit Agarwal <[email protected]>
Commit-Queue: Zaina Al-Mashni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156836}
[android] Remove some calls to deprecated SyncServiceFactory.get()
Hopefully no behavior changes. These calls were underlying calls to
getLastUsedRegularProfile(). Instead, call
SyncServiceFactory.getForProfile() and pass an explicit profile
reference. The references are chosen from one of the 4 options below.
The focus is not to accidentally replace the regular profile with the
incognito one.
1. A nearby field/variable which is still getLastUsedRegularProfile()
if you follow the stack trace.
2. Use of TabModelSelectorProfileSupplier + getOriginalProfile().
3. The profile in SigninManagerAndroid, since that service is not
instantiated in incognito.
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:chrome/browser/signin/signin_manager_android_factory.cc;l=16;drc=b35d0400e78c4216ea3e6941d91373147572953c
4. The profile obtained from the WebContents. This only happens in
AddressEditor.java, where the reference can come from
SaveUpdateAddressProfilePromptViewAndroid. In this particular case there's no need for getOriginalProfile(), because the save prompt is
not shown in incognito.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/android/autofill/save_update_address_profile_prompt_view_android.cc;l=57;drc=74077ae07468070edcaac721aef246dd5fcf8092
This CL introduces new SyncService fields/arguments in some layers.
We add @Nullable according to whether the existing code handles a
null object, not whether the object can really be null.
Fixing null support is off the scope of this CL. The null SyncService
story is also not ideal IMO (rant, https://crbug.com/1434356#c8)
Disable-Rts: True
Bug: 1380925
Change-Id: I325bc532222005c6d651ec7fe6e6e6a688789154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601371
Auto-Submit: Victor Vianna <[email protected]>
Quick-Run: Victor Vianna <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156835}
Roll Perfetto Trace Processor Linux from 95f8ef66efe9 to 3991a59acc7a
https://android.googlesource.com/platform/external/perfetto.git/+log/95f8ef66efe9..3991a59acc7a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I17eaaa25dda936cb48f465fc78cfc5d9f1b37228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609844
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156834}
SmartCard: Implement Status in SmartCardProviderAPI
The mojom method will be called by the renderer in
third_party/blink/renderer/modules/smart_card/smart_card_connection.h
(done in a separate CL)
content::SmartCardService provides the mojom SmartCardConnection to
the renderer.
Explainer: https://github.com/WICG/web-smart-card/blob/main/README.md
High level design: http://go/web-smart-card-hld
The Web Smart Card API is only available to Isolated Web Apps (in short,
installed js code instead of js code coming from a web server).
Bug: 1386175
Change-Id: I2b216a05208a1e153ccf57082fb5e73870cc911f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580430
Commit-Queue: Daniel d'Andrada <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Reviewed-by: Jeroen Dhollander <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156833}
Remove PrinterConfigurer from internal API
Move the method PrinterConfigurer::SetUpPrinter() to the interface
PrinterInstallationManager and to the class CupsPrinterManager. This
refactoring removes PrinterConfigurer from the internal printing API in Ash and moves it inside the CupsPrinterManager. These changes eliminate the possibility of starting a new printer setup procedure when another setup procedure for the same printer is running.
The method SetUpPrinter() is called from a couple of locations in
chrome-ash. The call is preceded by a call to a method IsPrinterInstalled(). In some cases, there may be several seconds
between a successful call to SetUpPrinter() and the moment in time when IsPrinterInstalled() starts to return true. During that period the setup procedure for the same printer may be started again. This patch solves this issue by introducing to the CupsPrinterManagerImpl the map printers_during_setup_ that tracks all printers for which the setup procedure was started and has not been completed yet.
This patch also converts `enum PrinterSetupResult` to
`enum class PrinterSetupResult` to avoid name conflicts.
This patch also add a method UninstallPrinter to CupsPrintersManager and calls it when a USB printer is disconnected. It was required to keep passing tast tests that connect or disconnect USB virtual printer several times (e.g: scanner.ADFJustification, scanner.EnumerateIPPUSB).
BUG=b:281853568, b:267226704
TEST=unittests and tested manually on atlas
Change-Id: If2fade1ae82499bf90536ecdaa51e808a58852ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568367
Commit-Queue: Piotr Pawliczek <[email protected]>
Reviewed-by: Paul Moy <[email protected]>
Reviewed-by: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156832}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686643168-359300e0c5ae40479f2a4f3ecf4cdc6380496a44.profdata to chrome-mac-arm-main-1686649808-9a861ea31b8632a25c4d36bef0e3ec8cb8e5e632.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I45512a804dbd87cb694538991cd25eee0f49c81d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610500
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156831}
language_packs: Extend expiry date of the histograms we still use
Bug: b:231288152
Change-Id: I3d97b61c8fdd4cc6b9512146c76dd88ded8b99ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607988
Reviewed-by: Tim Sergeant <[email protected]>
Commit-Queue: Claudio M <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156830}
[iOS] BookmarksFolderEditorViewController dealloc checks disconnect
It checks that `disconnect` was called before dealloc.
Bug: None
Change-Id: Ief83829482040e90c0795330a66b4ff49ce09bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604493
Reviewed-by: Tanmoy Mollik <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156829}
[iOS] Clean-up MailtoHandlerService::HandleMailtoURL()
This CL finishes removing MailtoHandlerService::HandleMailtoURL(url) now
that it has been replaced everywhere with its asynchronous alternative.
Fixed: 1443722
Change-Id: I3f3a1fb77b59e9db844a3bbf547d5f181968b33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601459
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Quentin Pubert <[email protected]>
Auto-Submit: Quentin Pubert <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156828}
Roll Perfetto Trace Processor Win from a124832ae9ce to ffbddef8f351
https://android.googlesource.com/platform/external/perfetto.git/+log/a124832ae9ce..ffbddef8f351
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I54361029fffce4ea6b2011b245977b420ab19a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609577
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156827}
Roll ios_internal from 22fc975add7b to 8043fd2f7f7b
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/22fc975add7b..8043fd2f7f7b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1454395
Change-Id: I05de94a0a30cb6081d75d77e629d522d104a28f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610016
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156826}
[v8] Reenable tests with error messages
After landing https://chromium-review.googlesource.com/c/v8/v8/+/4594631
Change-Id: Ic68df18549ce0d33fa4c7573bd5b2b73d50e06fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595842
Commit-Queue: Leszek Swirski <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156825}
ui: fix leaked raw_ptr in GLibWaylandSource
Those raw_ptr's are part of a structure inheriting from GSource, which
is memory managed by GLib. Thus, this struct's destructor is never
called, and those raw_ptr's never released.
This needs to be fixed because this can eventually put pressure on the
BRP quarantine.
Bug: 1445066
Change-Id: I307b5971a91d42719187412eac45fa85f0a06d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601289
Reviewed-by: Nick Yamane <[email protected]>
Commit-Queue: Paul Semel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156824}
Roll Perfetto from ffbddef8f351 to 3991a59acc7a (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/ffbddef8f351..3991a59acc7a
2023-06-13 [email protected] Merge "Remove TODO"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ica081bb11a53a424e59e13e5f275cd127fd47c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608515
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156823}
Roll ANGLE from 1e06b31e3863 to 057b8b61b2f2 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/1e06b31e3863..057b8b61b2f2
2023-06-13 [email protected] Roll Chromium from 5ec32d118efd to 28f11e95962d (682 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ia72cfad225e9ed065f1f90f6a55bff93c72ab198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608395
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156822}
Record histogram signin.SignIn.Started on Dice platforms
This CL records the histogram when opening a Dice signin tab and there
is no current primary account.
In the case where the Dice signin tab is reused, the metric is not
recorded again.
This CL also fixes a problem with an existing user action:
`Signin_SigninPage_Shown`.
This was recorded even when the user is not opting in to sync, wherheas
the other related metrics like `Signin_SigninPage_Loading` were only
recorded for sync-related signin.
This CL makes `Signin_SigninPage_Shown` consistent with others.
Bug: 1418000
Change-Id: I0f2e859d56665db04b7a0f6918b36c334a930555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601476
Reviewed-by: Nicolas Dossou-gbete <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156821}
[WebRTC] Add flag so that forcing SW includes 360p.
We already force SW when resolution is <360p (excluding 360p). This flag
makes us force SW for <=360p resolutions (including 360p).
Bug: chromium:1454398
Change-Id: I262214c7e6e88ce879543a7ee0d6cb93acf55cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608072
Auto-Submit: Henrik Boström <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156820}
Make WebSchedulerTrackedFeature support more than 64 values
Since BFCache is no longer reporting the bit mask from
`WebSchedulerTrackedFeature`, we can remove the restriction and allow
it to contain > 64 values.
This CL
- uses `EnumSet::FromEnumValues()` to constructs
`WebSchedulerTrackedFeatures`.
- removes the logic and test that handles features in bit mask format
(as part of crbug.com/1366675).
- creates a `WebSchedulerTrackedFeatures::ToEnumBitMasks` method to
generate bit masks list for the `WebSchedulerTrackedFeatures`.
Currently only the first chunk of 64 (least-significant) bits are
reported to UKM. After we create a new field in the metrics and obtain
the necessary approval, we will report the other masks as well.
Bug: 1366675, 1447441
Change-Id: Ie22f8b30c9737fa7b5d5b97bb43669d42178300f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584658
Commit-Queue: Mingyu Lei <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156819}
Remove "=false" from BookmarkModel::UpdateLastUsedTime's just_opened
BookmarkModel::UpdateLastUsedTime() has a `just_opened` param, which
indicates whether this was triggered by a user action, and thus should
be recorded in metrics.
Before this CL, this param defaulted to `false`. As a consequence,
the relevant iOS call site wasn't updated to specify the correct
value, and metrics were missing on iOS (see crrev.com/c/4607208).
This CL removes the default value, so that call sites have to specify
it, and it's harder to mess up.
Bug: 1405089
Change-Id: I66b76bb3a8633fc811d429dc1866243a8a49db9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608003
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156818}
Run IOTask DLP warning callback
Changed FPNM to run IOTask DLP warning callback
when the warning is proceeded or the task is resumed (user proceeded for single file).
Bug: b/281047180
Change-Id: Ie2a73b796ef380eaa8a26f4c487a37ae741fb58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598289
Commit-Queue: Aya Elsayed <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156817}
[Android][Autofill] Make delete runnable part of model.
Bug: 1435314
Change-Id: I1ecb163a56da52b795727dc715356c4f969867ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607283
Commit-Queue: Timofey Chudakov <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156816}
Roll devtools-internal from 389c067f94b2 to e8acd1ef704e (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/389c067f94b2..e8acd1ef704e
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cf6706a3cb404a78a7bdec9900bb106ef7faf731..c3b83d98fe8371db601fbd9a4a9f3a4d9924362b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: If57253b0e032ce3052e84b2bd6877a8e616dd57d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609619
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1156815}
Revert "[dPWA] Maybe fix flaky draggable regions tests"
This reverts commit 2a2cf0cdeec82142bd628d20505a7ed687f4b88d.
Reason for revert: Looks like it's still flaky.
Original change's description:
> [dPWA] Maybe fix flaky draggable regions tests
>
> These tests have been disabled as flaky for a long time and as this
> similar fix has worked for other flaky tests so it might as well work
> for testing draggable regions.
>
> Bug: 1277860, 1269894
> Change-Id: I47595594ec7bd016ea77dc14913e72e9eff5a36b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594780
> Reviewed-by: Christian Flach <[email protected]>
> Reviewed-by: Daniel Murphy <[email protected]>
> Commit-Queue: Sonja Laurila <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1156746}
Bug: 1277860, 1269894
Change-Id: Ib92dae9777f797054db02f244f22d51cd7ec130e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607211
Commit-Queue: Sonja Laurila <[email protected]>
Reviewed-by: Christian Flach <[email protected]>
Owners-Override: Ivana Žužić <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Sonja Laurila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156814}
Roll Dawn from bfe346b8723e to 1300592018b4 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/bfe346b8723e..1300592018b4
2023-06-13 [email protected] Change lodMaxClamp default to 32
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Iee14dfad50e8201882652e18860912944753435b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609398
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1156813}