Publish DEPS for 113.0.5672.51
Incrementing VERSION to 113.0.5672.51
Change-Id: I8138844772712c4fa849a3529f2d9235ee002973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4436138
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#679}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Metadata][Android] Do not crop card art images
Options to fetch card art icons in the required dimension:
1. Server resizing: Server returns card art of exact size. The aspect
ratio is maintained while resizing, so the exact size is achieved by
cropping.
Result: The image gets cropped (bottom of the Gold Amex card). Image
quality is good.
https://screenshot.googleplex.com/C5zayKWkbbrFgGi
2. Client side resizing: Server returns card art of stock size, client
resizes to the exact size.
Result: Image is not cropped. Image is of lower quality.
https://screenshot.googleplex.com/6dKENvwcTikehPJ
3. Staggered resizing: Server returns image that is close to the
required dimension while maintaining the aspect ratio. The client
resizes to the exact size.
Result: Image is not cropped. Image quality is good.
https://screenshot.googleplex.com/5fyF4umXgMPDR9T
The card art should not be cropped, it can be resized as long as there
is no noticeable loss in image quality.
Current implementation: Option 1
New implementation: Option 3
Low-Coverage-Reason: AutofillUiUtils helper method tests are covered in
PersonalDataManagerTest
(cherry picked from commit 79ec841ad22e6576c17373da3318083f37519939)
Bug: 1433062
Change-Id: Ib3ff57066f6fb76d956262ed85934fab06ae0844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4419930
Reviewed-by: Florian Leimgruber <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130431}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427608
Cr-Commit-Position: refs/branch-heads/5672@{#678}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Bookmark View Controller can sync before being loaded
This change ensure that, if the model is not yet loaded, sync message
is just ignored, and does not lead to a crash.
The test crashes without this code change.
(cherry picked from commit 426c1a645dc8929d36fb0bf9bd9a537c7240b120)
Fixed: 1429435
Change-Id: Ia199a7b80cd4541972c68a9c1ca14b7fb3821fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4396354
Reviewed-by: Petro Akzhygitov <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1125973}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437192
Auto-Submit: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#677}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.50
Change-Id: Ie3017a949a62b9cea7fa75cc43fac7908ff1c22d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4439769
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#676}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681765427-c6301c6d93a661869eb42456b2225137af380854.profdata to chrome-win64-5672-1681795015-c0b12440d5769d2fce24327011930f6222c11b74.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Id3475bd4636edebc121b8d70b7a21e4b9c81cba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4439252
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#675}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681765427-ad9278b44efee8b18c24a2b11760b70ce91b5bb5.profdata to chrome-linux-5672-1681795015-6ef9c8cd911aca769604ffe5f0a36c8dfefeaab2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Ieaf347599d5de9d89a9da00533474e41942d7c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4438993
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#674}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[BRP] Unrewrite fields based on Mac sampling profiler data
This CL unrewrites the top three call sites for RawPtrBackupRefImpl::
AcquireInternal based on Mac sampling profiler data
go/brp-mac-prof-diff-20230403
(cherry picked from commit 8e7c8fc3a0de0b7a2f20241bef9e509c1178cbfb)
Bug: 1431045
Change-Id: Ib0d1c6c5671456bc4cea0538cdf9ee8a03b82f7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4393619
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127015}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422254
Cr-Commit-Position: refs/branch-heads/5672@{#673}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[BRP] Unrewrite fields based on ChromeOS sampling profiler data
This CL unrewrites the top three call sites for RawPtrBackupRefImpl::
AcquireInternal based on ChromeOS sampling profiler data
go/brp-cros-prof-diff-20230403
(cherry picked from commit 02cd570ecab93e9e80ecbf865bf3930ce338e89a)
Bug: 1431045
Change-Id: Ia743978dffa9e14012de8947205b14131d192837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4393653
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127014}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422119
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#672}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681754250-91c4fb285322878d8101a51f4d333cbeb269c8bc.profdata to chrome-win32-5672-1681765427-83eb7c0d370f8bd1bf2bf8a10ca08d384286aca4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Ifd604975a9cc1d2ef952e4837b4e29050a3a0c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437397
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#671}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681754250-0bd0906e2851e2a429cd35cc264ea62e37e30852.profdata to chrome-win64-5672-1681765427-c6301c6d93a661869eb42456b2225137af380854.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Iec0a6eb60a811829b55b850e4f714bd513e3277f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4438034
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#670}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681754250-79286f08bdc6cf042e61cde0ee094912b00a0085.profdata to chrome-mac-5672-1681765427-55aa842f3385f21ff074ecfb47e01e45473b3345.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: Idf8bce88c5a4554b08751f0690f2ea39edd185d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437396
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#669}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681754250-0db954b77fc8ab27df4875ad63bf096449a03fc9.profdata to chrome-linux-5672-1681765427-ad9278b44efee8b18c24a2b11760b70ce91b5bb5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Ib9e6328cb693fc813bb65b466938248393630983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4438037
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#668}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.49
Change-Id: I8b4637b655d6d1fbf7f3047ae4e9e0f90424fa41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4438110
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#667}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681730750-6d36ea010e3c9f6ffd0dbbd17674852fc94d5c67.profdata to chrome-win64-5672-1681754250-0bd0906e2851e2a429cd35cc264ea62e37e30852.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Ied2c4d59550607902cc7f7756faee23d4bdc3ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4435730
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#666}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681730750-d1c199c9c41ba22258135cb59935637f9ea36b4a.profdata to chrome-win32-5672-1681754250-91c4fb285322878d8101a51f4d333cbeb269c8bc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Ic198767c3d5062f877dd7494c76e22adaaf977e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434092
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#665}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681730750-2639ed997d57f0cd84518f01abb1336ef31bdfaa.profdata to chrome-mac-5672-1681754250-79286f08bdc6cf042e61cde0ee094912b00a0085.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I5127e890a4791f45211fcd7a02db5993f23f2406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4435649
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#664}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Set default printable area for virtual printers in UpdatePrintSettings
Merge to M113 branch.
PrintViewManagerBase::UpdatePrintSettings() fails if a virtual printer
has an empty printable area. Set a default printable area for virtual
printers if the printable area is empty.
To do so, make
PrintingContext::SetDefaultPrintableAreaForVirtualPrinters() a public
method instead of protected. Create an API in PrinterQuery to set the
default printable area, and use it in PrintViewManagerBase.
(cherry picked from commit 83a2c257d2a568881191d6203f45d184ddf9949b)
Bug: 1432309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418637
Code-Coverage: Findit <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Commit-Queue: Andy Phan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130152}
Change-Id: Iacf3f13f9e3bd69271ba10d71fafa7241edb4c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434771
Cr-Commit-Position: refs/branch-heads/5672@{#663}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113 merge] avatar: Only encode once for webp
If the avatar animation has been saved to file, it will be read from
file and decoded for displaying. However, the animation is also encoded
again.
This cl skips the encoding if the animation is read from file.
(cherry picked from commit 17f22d595810ec8b6897c622ccb4ecf63c0af36b)
Bug: 1431252
Test: added new test
Change-Id: Id049927456ea25007ca5e3c4f322c30af410c319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412274
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128952}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434629
Cr-Commit-Position: refs/branch-heads/5672@{#662}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Sync final visual properties state without asking.
Fullscreen Rotation Handling can throttle intermediate states,
but there is no guarantee that the final state will be
synchronized.
Because the RWHI can throttle the synchronization too.
When final sync procced with
|RWHI.visual_properties_ack_pending_ == true| it will be skipped.
In this case renderer stucks with blank black screen.
(cherry picked from commit 52217e6ba8172a9875639c9e2ddc582d542fe32b)
Bug: 1423929
Change-Id: I883d286bf9c1c88786f8a78734c3df263f02af14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4394784
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127129}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4435710
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Jonathan Ross <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#661}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681730750-5a6f00df4312e90c394d11980eed6ab3cd289a3f.profdata to chrome-linux-5672-1681754250-0db954b77fc8ab27df4875ad63bf096449a03fc9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Iaeaf9cd7fc2e41297298f32d6c289202a2bc3a9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4435829
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#660}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[m113] Reject IPH before the browser window is initialized.
We should not be attempting to launch IPH before the browser window is
initialized because we will not have access to accelerators for screen
reader text. This prevents these IPH from showing and logs an error, so
that IPH developers can see why their IPH aren't running.
(cherry picked from commit 19c9ab6639e7a0e02beecc4c4609b8198fafb310)
Bug: 1432803
Change-Id: I58b1242f637c6e314ebea043470c7903a8a6b82c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424869
Commit-Queue: Dana Fried <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: David Pennington <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130178}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434250
Reviewed-by: Dana Fried <[email protected]>
Auto-Submit: Paul Adedeji <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#659}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Merge to M-113]cros_next: Do not use cros color token when jellyroll is not enabled
If the feature flag Jellyroll is not enabled, the color will be resolved
as dark blue when using the cros color tokens. Hence in Alt-tab, do not
use the cros color tokens if the feature flag Jellyroll is not enabled.
(cherry picked from commit e792b775c0a470a23726144dc996bbd755c22670)
Bug: b/277922181
Change-Id: Ic56643948a1d3a0277997f908631c985746eb9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420119
Commit-Queue: Connie Xu <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129974}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428228
Cr-Commit-Position: refs/branch-heads/5672@{#658}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[m113] Avoid CHECK during IPH launch.
For some reason, we are failing to retrieve the F6 accelerator from the
browser on Windows when launching an IPH from the NTP.
This appears to be due to changing a NOTREACHED to a CHECK. This change
reverts the previous change, making it a NOTREACHED again.
We can look into this in more depth later when it is not holding up a
release.
(cherry picked from commit 40142ee5d5f4640b43fada9038816f7356b68feb)
Bug: 1432803
Change-Id: Ia0d63dffd6b33a4360bbda2adc72d209660d2437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420220
Code-Coverage: Findit <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Paul Adedeji <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130027}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434669
Auto-Submit: Paul Adedeji <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#657}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Reland "[Cormorant] add entry point metrics"
This is a reland of commit 61361a0691283aeef61e26dd816e04bd6638466f
Original change's description:
> [Cormorant] add entry point metrics
>
> Bug: b/275574193
> Change-Id: I9fdffa476e831cef0803c7d1a860132568b5e261
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4406675
> Reviewed-by: Dan H <[email protected]>
> Commit-Queue: Jeffrey Cohen <[email protected]>
> Reviewed-by: Justin DeWitt <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1128744}
(cherry picked from commit 15601d53f82996112c49e770fbb431fb1f1b2b99)
Bug: b/275574193
Change-Id: I39018749c7552e0f62277e526a409c30c6b2c25e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418748
Reviewed-by: Justin DeWitt <[email protected]>
Reviewed-by: Dan H <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129509}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434770
Cr-Commit-Position: refs/branch-heads/5672@{#656}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Fix tight space between shortcuts and feed header.
Fix for the tight space between the shortcuts stack view and the feed
header.
(cherry picked from commit 15f6c9259bf47b8843e6bcf36efea95f7af59a62)
Bug: 1424455
Change-Id: Ic489bceec6c5575a76f279e96ae6b21ea364cf50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421635
Code-Coverage: Findit <[email protected]>
Commit-Queue: Guillem Perez <[email protected]>
Reviewed-by: Adam Arcaro <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130130}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434031
Auto-Submit: Guillem Perez <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#655}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Update RLZ brand codes map for M113+
R=[email protected]
(cherry picked from commit 3b91afb4d7fcfa0422cc50c1f3a0650f5566acea)
Bug: 1433285
Change-Id: I9da147d3d7ce16eaee4c74cda835e49510bdf6be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426306
Reviewed-by: Peter Kasting <[email protected]>
Auto-Submit: Stephen Lin <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130684}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434429
Cr-Commit-Position: refs/branch-heads/5672@{#654}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Don't include group-targeted field trials in metrics reports
This adds an is_low_anonymity property of FieldTrials, and by default
does not return these to callers (in GetActiveFieldTrialGroups() and
via Observers). Callers which specifically want to read the low
anonymity trials must do so via FieldTrialListIncludingLowAnonymity.
This also includes a change to move away from the deprecated
`base::LazyInstance`, required to avoid a build failure as a
side-effect of this CL (see crbug.com/990948).
(cherry picked from commit 01bb2e9d4cd99c932f789f8d0d1095bec975c4c4)
Bug: b/274900786, 1433583
Change-Id: Ic5f275856bc57b2e4b660f219cd9c43b99e832cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4386467
Commit-Queue: James Lee <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130880}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433390
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Auto-Submit: James Lee <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Egor Pasko <[email protected]>
Commit-Queue: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#653}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
M113 Merge - [ios] Disconnect CVC prompt from c++ dependencies.
This patch adds logic to disconnect the CardUnmaskPromptViewController
from its c++ dependencies when these are freed, in order to prevent
a UAF crash.
(cherry picked from commit 4eb025d002113cddbd343e3dee46a077f8fb7f68)
Fixed: 1428838
Change-Id: I4adc4f5a0a8c46c3a2471342fdc2301a82ba67a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415245
Code-Coverage: Findit <[email protected]>
Commit-Queue: Ernesto Izquierdo Clua <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130459}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428452
Cr-Commit-Position: refs/branch-heads/5672@{#652}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] [HTTPS-Upgrades] Fix crash or hang during certain redirects
When HTTPS-Upgrades are applied multiple times across redirects to
different sites within the same navigation, old remote/receiver
instances were being held onto and either triggering a DCHECK or
causing the navigation to hang (in non-DCHECK builds) by failing to continue the next redirect step. This CL removes these DCHECKs and
instead explicitly reset()'s the Remote and Receiver in
HttpsUpgradesInterceptor::RedirectHandler() before re-binding them to
trigger the upgrade redirect.
This also adds a regression test that triggered these DCHECKS (or
navigation hang) before the fix was applied.
(cherry picked from commit d121a41c5f0e02860cd2480155b951b588d3235f)
Bug: 1431026
Change-Id: If487631e217ad06aefabe72e84c6c138902a5b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418407
Commit-Queue: Chris Thompson <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129533}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434029
Auto-Submit: Chris Thompson <[email protected]>
Commit-Queue: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#651}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] CCA: Fix UAF issue in StorageMonitor, FileMonitor
It is possible to have use-after-free issue when doing storage
monitoring and file deletion monitoring, especially when the object is
created and destroyed within a short time. So, we use weak pointers to
avoid this issue.
(cherry picked from commit 7ea86c7a2091ddf8a4220ed44caa4a6590bcd9d3)
Bug: b:277208566
Test: Repro following steps in the bug, crashes do not happen after the fix, tast run $DUT camera.camera.CCAUIRecordVideoEdgeCase
Change-Id: I91e6ff68cacfef8515009b1eb45ed3aba2e08817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414537
Auto-Submit: Kam Kwankajornkiet <[email protected]>
Code-Coverage: Findit <[email protected]>
Reviewed-by: Wei Lee <[email protected]>
Commit-Queue: Wei Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130337}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428172
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#650}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681703029-63650af60d6884f11cb71d1ef95be6792391dc8e.profdata to chrome-win32-5672-1681730750-d1c199c9c41ba22258135cb59935637f9ea36b4a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Ic5dfcb3046712fc6fca7ccc65a99195b69e488ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433031
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#649}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-17 UTC
Change-Id: I2f15ad71e3bb03af10718dc091eb9120d07477c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4432875
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#648}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Fix DCHECK in partial translate mediator
The DCHECK reference the wrong feature and test a feature that is
already launched.
(cherry picked from commit f3f7de3a7dfdbd3771667c19eedf51675e323b8b)
Bug: 1433224
Change-Id: Iae86eab46a2506a3dad19077664d05f15e847eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424752
Auto-Submit: Olivier Robin <[email protected]>
Reviewed-by: Quentin Pubert <[email protected]>
Code-Coverage: Findit <[email protected]>
Commit-Queue: Quentin Pubert <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130390}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4432437
Commit-Queue: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#647}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automated Commit: LKGM 15393.29.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8783611469642032769
Change-Id: Iaf19eee0e07c82a1ed64b0c5d0c315125d781ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433189
Bot-Commit: ChromeOS bot <[email protected]>
Commit-Queue: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#646}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Updating XTBs based on .GRDs from branch 5672
Change-Id: I83c476cfacc26ce1c82a6722a56a7f0c6cf23688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430452
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#645}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
M113: Start timer on MediaStreamVideoTrack::NotifyConstraints...() if min fps set
The timer in MediaStreamVideoTrack that is used to maintain the min
frame rate was only started on Add/Remove sink.
This CL starts the timer when NotifyConstraintsConfigurationComplete() is
called if a min frame rate has been set. This may happen when
applyConstraints() is called on a video track with a constraint on the
min frame rate.
(cherry picked from commit 7bbd2efcc148b01b3aef685312f99ea8e8e47a44)
Bug: chromium:1429272
Change-Id: I0cfcfbe9387a658be811d3fdee009f2b5e325b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414891
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Markus Handell <[email protected]>
Commit-Queue: Johannes Kron <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129788}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427978
Cr-Commit-Position: refs/branch-heads/5672@{#644}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681703029-2b08f1d9e984ce99ae8893b096b03bb9c083a70a.profdata to chrome-win64-5672-1681730750-6d36ea010e3c9f6ffd0dbbd17674852fc94d5c67.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I18885590e69348ddb7824ab7ea726af31474b08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433152
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#643}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681703029-debd722a397e1178fd8e453ae58b2a42bfd18a91.profdata to chrome-mac-5672-1681730750-2639ed997d57f0cd84518f01abb1336ef31bdfaa.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I444537574ad37bef2927882f052dc95e6d30ef10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433249
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#642}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Reland "Fix crash when PasswordDetails is opened and all open tabs are incognito"
This is a reland of commit 49166a432e41ff46a63add3f5cf6ff2851a0e21a.
Original change's description:
> Fix crash when PasswordDetails is opened and all open tabs are incognito
>
> This fixes a crash introduced in M113 (crrev.com/c/4290479). Before that
> CL, the problematic code was only hit if EnablePasswordsAccountStorage
> was enabled and the user tried to move a local password to the account.
> Now it's hit regardless of any flags, as long as one follows the
> repro instructions in the title of this CL.
>
> The root cause is settings coordinators receive a non-incognito Browser
> even when they are started from incognito. Looking for a tab in the
> non-incognito browser will fail if only incognito tabs are open.
>
> The adopted fix is to look for tabs also in other browsers, using
> BrowserList. A better fix would be to refactor some of the code
> //components/password_manager/ to avoid unnecessarily depending on
> tabs. But that's a much larger effort and riskier to merge back.
>
> Fixed: 1431975
> Change-Id: I8126352f7a9a0ef5b7fd38ed9e8be8a5e7ba6ddb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418726
> Commit-Queue: Victor Vianna <[email protected]>
> Reviewed-by: Tommy Martino <[email protected]>
> Auto-Submit: Victor Vianna <[email protected]>
> Quick-Run: Victor Vianna <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1130583}
Bug: 1431975
Change-Id: I189bf49bffe2ebd48a266ac676336a51d6e8dd25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427782
Commit-Queue: Victor Vianna <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#641}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681703029-97c113ed743519ad882894fb614bf9bd7095a9ec.profdata to chrome-linux-5672-1681730750-5a6f00df4312e90c394d11980eed6ab3cd289a3f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I9d99e8d13d14b67d4dd13dcff65603306bf04dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4433154
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#640}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Android] Save Capital One icon URL as a constant
Capital One's icon for virtual cards is fetched via a static URL. This
URL is unique (as in it's not similar to either the network icons which
are stored in the client code, or to the card arts which are fetched via
FIFE URLs). Save it as a constant.
(cherry picked from commit bc5f4e07f87f949c1e42a702a5c3ffd35010d637)
Bug: 1433534
Change-Id: I7dbf55156da1dafe4bcc0aa3c65d4e77e61e8bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4409534
Commit-Queue: Vishwas Uppoor <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128727}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428293
Cr-Commit-Position: refs/branch-heads/5672@{#639}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Passwords] Copy passwords as confidential in the management bubble
The password management bubble has a copy button to copy both the
username and the password.
The password should be marked as confidential to ensure the privacy
of the password.
This CL is setting passwords as confidential when placed in the
clipboard.
(cherry picked from commit 333131c456134335f9743d3c230505702d99a902)
Bug: 1429350,1382017
Change-Id: I678b069de872e6a2302981c40e331c4f50c15e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4386714
Auto-Submit: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Rafał Godlewski <[email protected]>
Commit-Queue: Rafał Godlewski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1124412}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4432870
Cr-Commit-Position: refs/branch-heads/5672@{#638}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Ensure data is destructed with chrome in CBD
My best guess regarding 1429513 is that the BrowsingDataCounterWrapper
are destructed after the preferences themselves are deleted. This is
due to the fact that Objective-C does not have any guarantee regarding
destruction of its object. To avoid this issue, we destruct each
BrowsingDataCounterWrapper when the manager is disconnected, instead
of waiting until the manager is destructed.
While doing it, I realised that all other values had the same
potential issue. For the sake of the safety, I delete all values in
this disconnect function too.
Finally, I rename `_observer` to `_browsingDataRemoverObserver`,
because the name was ambiguous given the number of observers.
(cherry picked from commit 911df11b1254ab46eaf7f76ee1e452032075bc45)
Fixed: 1429513
Change-Id: I875811453b83d87e8bd810013e154823681383bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4406048
Commit-Queue: Arthur Milchior <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127225}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404149
Commit-Queue: Jérôme Lebel <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#637}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[BRP] Adjust MemoryReclaimer experiment
Adjust MemoryReclaimer experiment so that the default group with
brp-mode/enabled keeps the old behavior of not registering with
MemoryReclaimer. Setting brp-mode/enabled-with-memory-reclaimer will
register the main partition with brp to MemoryReclaimer. Setting
brp-mode/disabled-but-2-way-split-with-memory-reclaimer will just split
the partition and registers it to MemoryReclaimer.
(cherry picked from commit 7381718ae6b2c3324073aca09985caebefc2437f)
Bug: 1431379
Change-Id: I75a77732598d37d05aae7d631092e4dfe280c840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416787
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129706}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431684
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#636}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681661039-9631b268137b2e3eea24fc0005ec956e6fd6839e.profdata to chrome-win32-5672-1681703029-63650af60d6884f11cb71d1ef95be6792391dc8e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I59006008fade927fe2b92a56d5b7fbafcd3f5230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4432390
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#635}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Disconnect observers for ClearBrowsingDataTableViewController
ClearBrowsingDataCoordinator needs to be stopped from
SettingsNavigationController.
Need to call -[ClearBrowsingDataTableViewController
prepareForDismissal], from ClearBrowsingDataCoordinator.
(cherry picked from commit bb4b00e6c1da696f907ab4deed937d80e66c1191)
Fixed: 1429513
Change-Id: I68c6334f2736344ede1f4f969c9cf980ab826ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4410800
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Tanmoy Mollik <[email protected]>
Auto-Submit: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128571}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427808
Commit-Queue: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#634}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681679246-a56759d5cfe5b1ceea7aca99be5db0b1af1611d4.profdata to chrome-win64-5672-1681703029-2b08f1d9e984ce99ae8893b096b03bb9c083a70a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I6da28c53dcc2b96483a6bb5333d522cab71ed6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4432076
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#633}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681679246-5b0e884fac143d4779cbf3c376eb1a1445dbb6d1.profdata to chrome-mac-5672-1681703029-debd722a397e1178fd8e453ae58b2a42bfd18a91.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I7cdf205d6e7e25bf89f1c5b7447ea692f3e2e719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430977
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#632}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Fix brp partition not registered to MemoryReclaimer and add experiment
BRP partition was not registered to MemoryReclaimer by mistake.
This CL fixes that.
Also adds an Finch experiment mode enabled-without-memory-reclaimer to measure the impact of having memory reclaimer disabled.
(cherry picked from commit dbf92406db865ea1aecf3163c4c2b39d8cfdd79b)
Bug: 1431379
Change-Id: I027fb87e9e160cf8759c9ff954d06593e2975291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402288
Reviewed-by: Bartek Nowierski <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Benoit Lize <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127592}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431742
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#631}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681679246-f7dc3a54084f7a8582a2b1a6d5d538ce46e21c6a.profdata to chrome-linux-5672-1681703029-97c113ed743519ad882894fb614bf9bd7095a9ec.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I626172e88c53b092c44e8757465984a7a91f2929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426228
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#630}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
crash:Alternates maybe doesn't exist?
See https://crash.corp.google.com/browse?q=stable_signature%3D%27Uncaught+%28in+promise%29+TypeError%3A+Cannot+read+properties+of+undefined+%28reading+%5C%27map%5C%27%29%27
Might need to cherrypick this one
(cherry picked from commit 8573d3eee968698fb906cb284d68390cba9eecec)
Bug: b:275756928
Change-Id: I2c8e5aebb3672f2142a783a304b4cb54be1b4f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4363758
Commit-Queue: John Palmer <[email protected]>
Reviewed-by: Zac Partridge <[email protected]>
Reviewed-by: John Palmer <[email protected]>
Reviewed-by: Michael Cui <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1122832}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421947
Auto-Submit: Grey Wang <[email protected]>
Commit-Queue: Grey Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#629}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll ChromeOS Orderfiles from 113-5672.6-1680516284-benchmark-113.0.5672.27-r1 to 113-5672.6-1680516284-benchmark-113.0.5672.30-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I76c7aab764223d7614f4cfcf707fd7dbc0cd5970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431106
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#628}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681661039-704aafa12c0ce6fc64a7131214ad8b98a28e25b8.profdata to chrome-win64-5672-1681679246-a56759d5cfe5b1ceea7aca99be5db0b1af1611d4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I0f03f52e1d73a733e2e57531efd3238c947f443a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431232
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#627}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681661039-3030b2e3db4781279924c347829858d376f63c36.profdata to chrome-mac-5672-1681679246-5b0e884fac143d4779cbf3c376eb1a1445dbb6d1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie721100213dce09c8a6ff3b28213d865a7f608d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430077
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#626}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681661039-bdf77c172bb6bbd032bd2f1a62915f064884ad42.profdata to chrome-linux-5672-1681679246-f7dc3a54084f7a8582a2b1a6d5d538ce46e21c6a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I2e9c507958575c0e0ad0ff78461f9bff081a80cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431235
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#625}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.48
Change-Id: Ia5183d58831006de949e8ef059b0dfc91d8b3cae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431352
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#624}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681614644-9dc3a380ef310d5bbb72ba8359fcf18e9ab81daa.profdata to chrome-win32-5672-1681661039-9631b268137b2e3eea24fc0005ec956e6fd6839e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I40c3289d94abdfd9d51c5b675b0a9967dc50631f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431080
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#623}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681643801-056587aca74f0029ad9e726d5152d791f19df053.profdata to chrome-win64-5672-1681661039-704aafa12c0ce6fc64a7131214ad8b98a28e25b8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I90d5c94e1ce3aba66d6f72d2b4f9db1ce56c2f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431078
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#622}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681643801-09c9e87aa06fa78850c8510fb282387101006133.profdata to chrome-mac-5672-1681661039-3030b2e3db4781279924c347829858d376f63c36.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I536842826b66a054d67f46c4cdbb879b724cdc14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431079
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#621}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681643801-a6ca76e13e1dcb99ff5160bb264c065192744bf3.profdata to chrome-linux-5672-1681661039-bdf77c172bb6bbd032bd2f1a62915f064884ad42.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Ib4da78c6b2acdb92c4e14e8f27d70a2500db3826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431114
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#620}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113 Merge] [Metadata] Add rounded grey border to Card Art.
This CL creates a grey border around rich card art to match the border currently on network images.
Before: https://screenshot.googleplex.com/3KWeSwP9V7gEbWr.png
After: https://screenshot.googleplex.com/67JmpiwCkScTzt8.png
Bug: 1313616, 1430069
Change-Id: I18011ff72bc17feb56d67b66ae438dc2240f694d
(cherry picked from commit 7c5981bfca7b2f5f101991c79760753ad8f038d1)
Low-Coverage-Reason: Not useful. Will add follow up tests if needed.
Change-Id: I18011ff72bc17feb56d67b66ae438dc2240f694d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421630
Commit-Queue: Alexander Tekle <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Alexander Tekle <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1130065}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428832
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#619}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll ChromeOS Bigcore AFDO profile from 113-5672.21-1681120765-benchmark-113.0.5672.30-r1 to 113-5672.21-1681120765-benchmark-113.0.5672.47-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic5d2c13007a8a4340cf5f77d5968003a4be38e92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4431050
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#618}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-16 UTC
Change-Id: I6be5254f709858b7eb859ba3a7ca0deade0b3608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430971
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#617}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-16 UTC
Change-Id: I0395a7d9883de80fd8f9bd1212f5d569f301d6f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430970
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#616}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll ChromeOS Atom AFDO profile from 113-5672.6-1680516284-benchmark-113.0.5672.30-r1 to 113-5672.21-1681128448-benchmark-113.0.5672.47-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ice0a2f5954c3308838d68cae6b4c859c5ba46a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426223
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#615}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Updating XTBs based on .GRDs from branch 5672
Change-Id: I4958f5eef9ff8e4c09ccd4214a0e58d93a62657e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427605
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#614}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681614644-33d6519dc0902194da9e97d0ea5b6bd05fe95d50.profdata to chrome-win64-5672-1681643801-056587aca74f0029ad9e726d5152d791f19df053.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I63e99217d6cc31d4597d16426332e443cc22564b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430862
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#613}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681614644-781d1dfd74c14bbcbf0425c81fbb13e2fc2f66d7.profdata to chrome-mac-5672-1681643801-09c9e87aa06fa78850c8510fb282387101006133.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I76920e71ffcbe827fa9e566f9eee9da438a883fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430864
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#612}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681614644-23b751dc4d22a3765fe764f861f1ccfef25c8dbb.profdata to chrome-linux-5672-1681643801-a6ca76e13e1dcb99ff5160bb264c065192744bf3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I242b0fc82c7f42e518e9bbec27a84a9209f74c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430358
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#611}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automated Commit: LKGM 15393.28.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8783702096855715105
Change-Id: Ic9316de8dd08049a102231d65c77373ba4363290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430860
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#610}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Amd64 AFDO from 113.0.5672.30_rc-r1-merged to 113.0.5672.47_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id216b2a599168a91f98af8d4dfcbed2e990b7659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427175
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#609}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681573717-932d2364ff84fed373349fe075cafd5619d08470.profdata to chrome-win32-5672-1681614644-9dc3a380ef310d5bbb72ba8359fcf18e9ab81daa.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Ica43c5f6220313c6eaf6a417f964ca3841226345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429569
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#608}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681592765-d21e3c8f01c9ab26f9a2c0df6334d2338e0bdd23.profdata to chrome-win64-5672-1681614644-33d6519dc0902194da9e97d0ea5b6bd05fe95d50.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I3b5f9ebd1c4e574c1daa0dd23d74fc342b8775c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430642
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#607}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681592765-88f0f60e9ad0a44412e6e0c3c73579efec8a0be7.profdata to chrome-mac-5672-1681614644-781d1dfd74c14bbcbf0425c81fbb13e2fc2f66d7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I816f59c3dde54e09e49d0d60b320351ec1b7cf90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429568
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#606}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681592765-055091271f0653f883d9e6a7b1655b23ce2ad13b.profdata to chrome-linux-5672-1681614644-23b751dc4d22a3765fe764f861f1ccfef25c8dbb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I652c8e28ce6d63e52e4e9ed854c3cf59cf836bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430644
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#605}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681573717-7d9c1fc89ca21f4579852829ea7a07446d032bc8.profdata to chrome-win64-5672-1681592765-d21e3c8f01c9ab26f9a2c0df6334d2338e0bdd23.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I2794649ed98406e83bc3cb4409806f2f65880d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430673
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#604}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681552681-e90761c7d5e1037a29c7c0ef0e49f43342d02715.profdata to chrome-mac-5672-1681592765-88f0f60e9ad0a44412e6e0c3c73579efec8a0be7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I7a7c5ab29aa077f9a3f79aa2ac00c9c95a578571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430336
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#603}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681573717-a9d691f9f690ae00ea47ed74346f8a6d821a2c0f.profdata to chrome-linux-5672-1681592765-055091271f0653f883d9e6a7b1655b23ce2ad13b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Ibeb0d7bf24e8e4a1f830dc9f2989b08aa144b359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430632
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#602}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.47
Change-Id: If80f853772aa4bfc55edf3ef57f24613578156de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427604
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#601}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681552681-f2745924baa10d58a4e0ae342124ac8f7f24e4b8.profdata to chrome-win32-5672-1681573717-932d2364ff84fed373349fe075cafd5619d08470.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I0c102406fda3dfc7d68d55ed85b38a098325c1d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430531
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#600}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681552681-01793bf4b9d1799489a1f20cd6d08fdb6ec14de9.profdata to chrome-win64-5672-1681573717-7d9c1fc89ca21f4579852829ea7a07446d032bc8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I2d4635ac12cb1965dfdc1cd5f4d62633af7765fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429554
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#599}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681552681-65d416d5121b568f91e0579746727da9bf1cf918.profdata to chrome-linux-5672-1681573717-a9d691f9f690ae00ea47ed74346f8a6d821a2c0f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Id29df136febea30bff2b4e015c345058f9276261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424923
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#598}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681494011-bc176e6e3ceef12904b7e19ec2902eb3cedf05a9.profdata to chrome-win32-5672-1681552681-f2745924baa10d58a4e0ae342124ac8f7f24e4b8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I04a6104d155c11cd7a52fc64fe090bb593cb4796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428969
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#597}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-15 UTC
Change-Id: Id601baf0a60e8624e14af921b09cf20194c486c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427781
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#596}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-15 UTC
Change-Id: I0e0281168574cb831fbf4934854b0aee5659712a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427981
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#595}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Updating XTBs based on .GRDs from branch 5672
Change-Id: I0701a982f00eaa61be3ed085ad99bc76d2766f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428376
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#594}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681534334-24aecd4f81a60eaf034f4debb6fa101d518b23d8.profdata to chrome-win64-5672-1681552681-01793bf4b9d1799489a1f20cd6d08fdb6ec14de9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I71521927e8c90f04a01a419e7668d60b3967b26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428967
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#593}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681511918-712be7764fd906d453a2ccc0b3f23634991884f2.profdata to chrome-mac-5672-1681552681-e90761c7d5e1037a29c7c0ef0e49f43342d02715.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I8599fccda22f26e9e46021f0db83f2619a8e5e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430293
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#592}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681534334-c7266d337dafe68d78f96ae8a24523e946978978.profdata to chrome-linux-5672-1681552681-65d416d5121b568f91e0579746727da9bf1cf918.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: If1d2986530a6b676f8c185ef8756aa84d698846d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4430294
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#591}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681511918-0851d2f5497f290c664a95ecfea65e9d95a5fd3c.profdata to chrome-win64-5672-1681534334-24aecd4f81a60eaf034f4debb6fa101d518b23d8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I0ee6d0a282a673a6094d1a2f4602bcb1afcb91ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429639
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#590}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681511918-e62ad4ffc5ddbeb3f606cab8bfa36e71e880aa70.profdata to chrome-linux-5672-1681534334-c7266d337dafe68d78f96ae8a24523e946978978.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I9172c9356f479500aea0c5aa1bd1ffe9f586b7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429640
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#589}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automated Commit: LKGM 15393.27.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8783823494700882161
Change-Id: Ie825341c5916e1bce96f26b32cb9eebb5806b4ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424915
Commit-Queue: ChromeOS bot <[email protected]>
Bot-Commit: ChromeOS bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#588}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681494011-190783d2510418c0f353432e9c2b2093904fc0cd.profdata to chrome-win64-5672-1681511918-0851d2f5497f290c664a95ecfea65e9d95a5fd3c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Ic96a06d84c23b4756d826d7ac97c6cd58b212390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428066
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#587}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681494011-116c788c09cfa89fc04ea62762a79d6414f41142.profdata to chrome-linux-5672-1681511918-e62ad4ffc5ddbeb3f606cab8bfa36e71e880aa70.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I4d047e1afd343c6b36093391f6dd88a1a40b7f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4429417
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#586}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681494011-ab5da3a68edd723edd2d25918b0b99e876d694b8.profdata to chrome-mac-5672-1681511918-712be7764fd906d453a2ccc0b3f23634991884f2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I610158c675cb66924efab12b039ee56bcea4e5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428067
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#585}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
M113: media/gpu/windows: Disable vp9 temporal layer encoding on Intel
Temporal layers are not working for the Media Foundation Intel
VP9 encoder and are therefore disabled. This can be overridden
by enabling the feature:
MediaFoundationIntelVP9TemporalLayerSupport
(cherry picked from commit 46aff4c240a562d62c9c4f18656b083f9361830f)
Bug: chromium:1425117
Change-Id: I48a5214c14742f48608d84a571dbd894491d916c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4394524
Commit-Queue: Johannes Kron <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126799}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428676
Cr-Commit-Position: refs/branch-heads/5672@{#584}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681469318-0dca94c76a82d91768d028d318bd9cc18ead90ea.profdata to chrome-mac-5672-1681494011-ab5da3a68edd723edd2d25918b0b99e876d694b8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I25aea89539c714c0fd45695c971966f137eaf563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428795
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#583}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681448351-99d55b0eef3993ddb5b7eeef9e567a8713185b87.profdata to chrome-win32-5672-1681494011-bc176e6e3ceef12904b7e19ec2902eb3cedf05a9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I3db38a976bcdcafba2ade96db345e652268f7142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428793
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#582}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681469318-a1ae358d3d79958c81a3a78f73185f4cd98f5678.profdata to chrome-win64-5672-1681494011-190783d2510418c0f353432e9c2b2093904fc0cd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I03e1f814795bbd789b7e73ed900a63cdb899e41a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4428056
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#581}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Fix webContent observer not attached when tab's content is changed.
Before this CL, the back press handler might not be able to observe
some tabs because it is only registered at the beginning of when
tab is selected. WebContents, however, might be changed, such as from
null -> a valid object if a preview is displayed.
This CL makes selector able to observe webContents even when webContents
is changed.
(cherry picked from commit 8c1d72de245a85d936c9c58eb5f0edc5dc02e927)
Bug: 1424890
Change-Id: I4ef03cd8ecf46ef2b926d9e898a1284689816b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375056
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126220}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427688
Cr-Commit-Position: refs/branch-heads/5672@{#580}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681469318-b389aa229a7b293c67935c972a480252171a0c39.profdata to chrome-linux-5672-1681494011-116c788c09cfa89fc04ea62762a79d6414f41142.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I1801f4f26a881f6fe23d343dafe4e6cbc6095d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427685
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#579}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] sqlite: Upgrade to 3.41.2
Roll src/third_party/sqlite/src/ 7dd277f31..f6752b7ed (37 commits)
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/7dd277f31ccd..f6752b7ed1fe
$ git log 7dd277f31..f6752b7ed --date=short --no-merges --format='%ad %ae %s'
2023-04-06 asully sqlite: Cherry-pick fix to allow shell to build recovery... again
2023-03-24 asully Amalgamations for release 3.41.2
2023-03-22 Version 3.41.2
2023-03-22 Increment the version number in the TEA configure script to 3.41.2.
2023-03-21 Fix a valgrind error and potential buffer overread when handling a corrupt database.
2023-03-20 Fix a problem causing a cursor to retain an out-of-date cell-info cache when processing a DISTINCT query on values that are identical according to their collation sequence, but different on disk.
2023-03-20 Fix problems with the sqlite3_error_offset() function and its use in the CLI.
2023-03-19 Increase the size of ref-count values in the pager layer to 64-bits, to avoid any reasonable possiblity of overflowing the counters.
2023-03-19 Avoid a buffer overread in fts3 that could occur when processing a corrupt record.
2023-03-17 Dan Kennedy Fix a potential buffer overread in the recovery extension.
2023-03-17 Ensure that an error does not delete the Table object out from under the xConstruct method of a virtual table. dbsqlfuzz 7cc8804a1c6d4e3d554d79096e6ea75a7c1c7d2d
2023-03-17 Increase the version number to 3.41.2
2023-03-17 Fix assert() statements that would (incorrectly) fire if an IF NOT EXISTS trigger that already exists contained two or more RETURNING clauses.
2023-03-16 Correctly handle SELECT DISTINCT ... ORDER BY when all of the result set terms are constant and there are more result set terms than ORDER BY terms.
2023-03-16 Do not use the one-pass optimization on an UPDATE if there is a subquery in the WHERE clause, since if the subquery is hidden behind a short-circuit operator, the subquery might not be evaluated until after one or more rows have been updated.
2023-03-16 Remove a NEVER() from btreeNext().
2023-03-16 Fix a broken assert() in the recovery extension.
2023-03-15 Disallow the one-pass optimization for DELETE if the WHERE clause contains a subquery.
2023-03-14 Fix Bloom filters on an expression index.
2023-03-11 The cherry-pick merge at [371838562a675c1b] caused a performance regression for some queries, which is here fixed.
2023-03-10 Version 3.41.1
2023-03-09 In the Bloom filter optimization, hash all strings and blobs into the same value, because we do not know if two different strings might compare equal even if they have different byte sequences, due to collating functions. Formerly, the hash of a string or blob was just its length. This could all be improved.
2023-03-09 Dan Kennedy Fix countofview.test so that it works with SQLITE_OMIT_PROGRESS_CALLBACK builds.
2023-03-09 Update the version number to 3.41.1
2023-03-09 Merge count-of-view optimization fixes from trunk. But count-of-view is still off by default for this branch.
2023-03-09 Fix a possible NULL pointer dereference due to the sqlite3_interrupt() enhancement in the 3.41.0 release.
2023-03-08 Keep the historical datatype ("INT", not "NUM") for a table created as follows: "CREATE TABLE t1 AS SELECT CAST(123 AS INT) AS value;". The use of FLEXNUM only occurs on compound queries.
2023-03-08 Fix an assertion fault added by [65ffee234787213c].
2023-03-04 Cherry-pick the agg-with-indexed-expr optimization fix from trunk.
2023-03-03 Do not use an expression index on a generated column if generated column has the wrong affinity.
2023-03-03 Enhance PRAGMA integrity_check so that it can detect when there are extra bytes at the end of an index record, which might cause OP_IdxRowid to malfunction.
2023-03-03 When it is known when preparing a statement that X cannot be NULL, transform the expression (X IS NULL) to integer value 1 instead of 'true'. This is because under some circumstances, "Y IS TRUE" may not be equivalent to "Y IS 1".
2023-03-02 When flattening the right operand of a LEFT JOIN, ensure that the OP_IfNullRow opcode does not NULL-out a subquery result that was computed within OP_Once.
2023-03-01 When flattening a view that is the right operand of a LEFT JOIN always insert the TK_IF_NULL_ROW expression nodes, even for TK_COLUMN expressions, as the TK_COLUMN might be a column from an outer query and hence still need to be NULLed out.
2023-03-01 Make sure subtypes do not cross a subquery boundary even if the function that returned the value with a subtype is buried down inside a larger expression.
2023-02-26 When a table-valued function appears as the right table of a RIGHT JOIN, the argument constraints on the table-valued function should be considered part of the ON clause of the RIGHT JOIN.
2023-02-23 Provide -DHAVE_LOG2=0 and -DHAVE_LOG10=0 compile-time options for use on systems that lack the log2() and log10() standard math library routines, to cause SQLite to substitute its own alternatives.
Created with:
roll-dep src/third_party/sqlite/src
(cherry picked from commit 4c1b1f8039c53009cfb9abef8ac003d616fa1a09)
Bug: 1426903, 1430644
Change-Id: Idc39b0c87be7152582c78f7eb6e53dd2d04b2b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404861
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Auto-Submit: Austin Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127286}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4409783
Cr-Commit-Position: refs/branch-heads/5672@{#578}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Null out drag_handle_nudge_ after closing the widget
If shelf drag handle nudge is hidden with no animation, the widget was
getting closed, but the drag_handle_nudge_ was never nulled out.
That left dangling pointer to drag_handle_nudge_, and caused UAF in
ShelfLayoutManager::IsShelfWindow().
BUG=b:276797787
(cherry picked from commit 974e48939282ca4bb3b5720f2137bed6c8dc3de6)
Change-Id: I78dc456ccc23cfd917ecc06f9a483fdc7b87192a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4406975
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127438}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422927
Cr-Commit-Position: refs/branch-heads/5672@{#577}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected].
[email protected]
Change-Id: Ib06a92fe6c3cd086799e8dec8097a82f4cdba9a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427912
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#576}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][iOS/B4P/PasswordGrouping] Fix the anchor of the actionSheets in
PasswordDetails view.
This CL contains one behaviour change behind the kPasswordsGrouping
flag and another behind the kEnablePasswordsAccountStorage flag,
both disabled by default.
Using bounds which describes the view’s location and size in its own
coordinate system seems to fix the misplaced actionSheets.
Instead of the frame which describes the view’s location and size in its
superview’s coordinate system.
Also in similar uses in the Settings UI the bounds is used to set the
sourceRect not the frame.
Screenshots in https://crbug.com/1430742#c3.
(cherry picked from commit 6e33e42c0e7412004356e923053d3f187813096d)
Fixed: 1430742
Change-Id: If83fc4c4f308dc29076653619e70c4f76d8a2ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404802
Commit-Queue: Jood Hajeer <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Victor Vianna <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129238}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421286
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#575}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Android] Do not call an API allowing cross-UID activity switching
CustomTabActivity does not call the API allowing cross-UID activity
switching.
(cherry picked from commit 3ccdc828dbb305dbf43f93fa091c777679b7c7fb)
Bug: 1431361
Change-Id: I9e09088d3c57c5997395c6c90f22aa66ed9c3c92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4405619
Reviewed-by: Kevin Grosu <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128867}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423670
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#574}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-14 UTC
Change-Id: I9f8781c31bfaa4e987475c8aa634ccb0147a9e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426633
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#573}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Updating XTBs based on .GRDs from branch 5672
Change-Id: Ia2d60a87ce3cf1a4eecf0ed1aad6d14fb809b40a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427910
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#572}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-14 UTC
Change-Id: I2ceca3caf10d31db143d934c59fd29c1e71ae155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427811
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#571}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681448351-219112adb1dd4899471de9329978b74cafaf835c.profdata to chrome-win64-5672-1681469318-a1ae358d3d79958c81a3a78f73185f4cd98f5678.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Iec312a4d6db64e75371fc6c1dba0d3399e3545e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425506
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#570}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Changed Price Tracking Half Sheet to Popover
In this CL, the Price Tracking UI's presentation style was changed from
a half sheet to a popover when the user device's form factor is a
tablet.
(cherry picked from commit f6764d692b13bdc38d2fa5076f03f6500cdd2499)
Bug: 1428451
Change-Id: I5c4c4c2bf9b3c21157515048d67c6df466b6a902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375800
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Daniel White <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1123141}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423570
Cr-Commit-Position: refs/branch-heads/5672@{#569}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Setting Price Tracking Thumbnail Background to White
In this CL, the background color for the product's image in the price
tracking UI was changed to white from gray.
(cherry picked from commit d692f6f625b5d6a21341fc9bf710061a9fd8b75a)
Bug: 1428449
Change-Id: I1d4193b370da5cab7a7e8056a1035c3dc9aa4298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4381924
Commit-Queue: Daniel White <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1124209}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423369
Cr-Commit-Position: refs/branch-heads/5672@{#568}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681448351-353fbfcc82a8567fbd190cc1c31243411aa21aea.profdata to chrome-mac-5672-1681469318-0dca94c76a82d91768d028d318bd9cc18ead90ea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: Ife127793fdaf2c59a0c64b45570ba0dce256f372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425967
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#567}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Price Tracking Track button should have a black label
In dark mode, the Price Tracking "track" button text's was changed to
black to ensure proper contrast.
(cherry picked from commit 8c3f1b8657e7cc820ffca700e3e37d68815c658d)
Bug: 1428450
Change-Id: I1ca57aa8f3bf42b49fd2f8831da7782765e048dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375139
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Daniel White <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1123026}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423330
Cr-Commit-Position: refs/branch-heads/5672@{#566}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681448351-1f4e56eaa2d7004be73395c9510fd9749c474ce2.profdata to chrome-linux-5672-1681469318-b389aa229a7b293c67935c972a480252171a0c39.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Ia81ccbf8843e0b0feed5889adfa2ecd258d67bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4427872
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#565}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll src/third_party/freetype/src/ 4d8db130e..e78e2d29a (12 commits)
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4d8db130ea43..e78e2d29a95b
$ git log 4d8db130e..e78e2d29a --date=short --no-merges --format='%ad %ae %s'
2023-04-06 bungeman [sfnt, truetype] Add `size_reset` to `MetricsVariations`.
2023-04-10 apodtele * src/cff/cffcmap.c (cff_cmap_encoding_char_next): Abbreviate.
2023-04-10 apodtele Align `char_next` return types.
2023-04-08 apodtele [sfnt] Clean up CMAP{4,12,13} handling.
2023-04-02 apodtele * src/sfnt/ttpost.c (load_format_25): Do not abort frame reading.
2023-04-02 apodtele * src/sfnt/ttpost.c (load_format_*): Streamline frame reading.
2023-04-02 apodtele * src/sfnt/ttpost.c: Formatting and comments.
2023-04-01 apodtele [sfnt] Consolidate POST version 2.0 and 2.5 (pt 2).
2023-04-01 apodtele [sfnt] Consolidate POST version 2.0 and 2.5 (pt 1).
2023-03-31 apodtele [sfnt] Miscellaneous POST clean-ups.
2023-03-30 apodtele * src/sfnt/ttpost.c (load_format_20): Simplify comutations.
2023-03-29 apodtele [sfnt] Streamline POST format 2.0 handing (cont'd).
Created with:
roll-dep src/third_party/freetype/src
[email protected],[email protected]
Change-Id: I5fb72655d48eeb17848f451cddd8f198b305b017
Bug: chromium:1429372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425689
Auto-Submit: Ben Wagner <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#564}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681427935-7cf794b24d7ea4d91aa8ec5629b29ac803f4a8a2.profdata to chrome-win32-5672-1681448351-99d55b0eef3993ddb5b7eeef9e567a8713185b87.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I79478cd004db0f0a7e33519afaddc86f4cb7e128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426446
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#563}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681427935-1637d07c5c91d90b74988318b1e6bf3394a2646f.profdata to chrome-win64-5672-1681448351-219112adb1dd4899471de9329978b74cafaf835c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Iee4e083ee9adc1522115d2fce86300e6a4d50ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425499
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#562}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681427935-5a17107422fdaa1fa7528fbd66feeef2a72365d5.profdata to chrome-mac-5672-1681448351-353fbfcc82a8567fbd190cc1c31243411aa21aea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I5b19f250060019c214ea82cbb9c23455cf65c825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426445
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#561}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681427935-98651e9c5b4cb09c5df3787f0c7cad0bf1d435ac.profdata to chrome-linux-5672-1681448351-1f4e56eaa2d7004be73395c9510fd9749c474ce2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I656f3ef8c8333914b7037d26edb53dce28982caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4426240
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#560}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681408573-7f23c6ccfa8e7a00b7c7d1b7b581a5afa2094a7b.profdata to chrome-win32-5672-1681427935-7cf794b24d7ea4d91aa8ec5629b29ac803f4a8a2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I7446fbec131e4d0116d22ce6d867d815fd5c5f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425835
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#559}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681408573-67bec96bbf838b9e1e08611eea98dbf7f1c0b649.profdata to chrome-win64-5672-1681427935-1637d07c5c91d90b74988318b1e6bf3394a2646f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: If6fd236939303c3928fe2633288149ec9a49439f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425494
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#558}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681378933-b20a7246ed9d9b6cd5e81f6adfed8389beb348ff.profdata to chrome-mac-5672-1681427935-5a17107422fdaa1fa7528fbd66feeef2a72365d5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I5a4bec384dbdeb46f6cb85ae73a6dfb94cbd2174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425834
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#557}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681408573-f4183f2885ff80a6915634432248dbb3dcde1201.profdata to chrome-linux-5672-1681427935-98651e9c5b4cb09c5df3787f0c7cad0bf1d435ac.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I6f56f91723ff9e273d30f4732d9757d27f4565ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425642
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#556}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.46
Change-Id: I4257c915cfd9cc6601973fda40929a3adfa51d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425111
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#555}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113 Merge] [Metadata] Improve Card Art Quality via Resizing on Client
Rather than use the FIFE url params for resizing, we use Chrome cropping tools as they produce higher-res images.
Before:
- Settings: https://screenshot.googleplex.com/BZVTwSXEnxbaZYi.png
- Dropdown: https://screenshot.googleplex.com/ATDTuNTwjkqWGyi.png
After:
- Settings: https://screenshot.googleplex.com/6UthHNHAwB23VqB.png
- Dropdown: https://screenshot.googleplex.com/BJ84R534WnNuG6e.png
(cherry picked from commit 2dbb834faa9c0fb8651d38102f4721c07b8c8489)
Bug: 1313616, 1432836
Change-Id: I857e82e6cb0a0ab9252f22f6f54e70d94cb8d341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4411067
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Alexander Tekle <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421975
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#554}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681339392-448858a29f32d2548b430ca39c7d52ee52011b32.profdata to chrome-win32-5672-1681408573-7f23c6ccfa8e7a00b7c7d1b7b581a5afa2094a7b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I07ad4d9ab7c4f89ef3b77ea324ebf33d3330546c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424830
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#553}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681378933-cc83cdc692d2beb84214d7acb1c1fc2605507d0c.profdata to chrome-win64-5672-1681408573-67bec96bbf838b9e1e08611eea98dbf7f1c0b649.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I1234032d223c5a8298b0a598b662f228e28d384d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424332
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#552}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Setting version to 113.0.5672.45
Change-Id: Ida0c805b07a3d06b25ad6f70332dd76d8f2a4e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4425150
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#551}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Merge M113][Tab Strip Redesign] Add experiment param for anchoring new tab button
We have seen some regressions in tab opens, which may related to NTB movement in TSR(messes with people's muscle memory), so adding this Disable NTB anchor params in case we need to revert or analyze NTB movement separately in stable. No effect on the original folio and detached arm.
- Adding two new variations for testing NTB anchor in Chrome:
1. Enabled Detached NTB Fixed position
2. Enabled Folio NTB Fixed position
Detached Disable NTB anchor: https://drive.google.com/file/d/1ByuMYKBo4wjyVwVRIiFztTZuw0IGEVl6/view?usp=sharing
Detached Disable NTB anchor RTL:
https://drive.google.com/file/d/1BycO9CyeF5Lkgyddif_ko5DZT6s5yLBL/view?usp=sharing
Folio Disable NTB anchor:
https://drive.google.com/file/d/1BvTZEdq5LA0s9AzQayD1nUhFEQCO21qZ/view?usp=sharing
Folio Disable NTB anchor RTL:
https://drive.google.com/file/d/1ByuMYKBo4wjyVwVRIiFztTZuw0IGEVl6/view?usp=sharing
(cherry picked from commit 2595b2d5d2ab154774b13100d1dda7fcb64e013f)
Bug: 1430211
Change-Id: I8ce9d25f9b05ac131b62b0726925e300c245db8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400495
Commit-Queue: Zhe Li <[email protected]>
Reviewed-by: Neil Coronado <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128869}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4424289
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Sirisha Kavuluru <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#550}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681357181-d76e614aafa1cc038da586dcc3580af031e82e9d.profdata to chrome-linux-5672-1681408573-f4183f2885ff80a6915634432248dbb3dcde1201.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Id53505a78a1a524e81652b7680c7215928b8d00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421578
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#549}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
TaskSignal: Fix incorrect DCHECK
HasPendingActivity() is checking the signal type is either kController
or kComposite, but it can be kInternal when composition is disabled
(kill switch path).
(cherry picked from commit 6603be492a5366132525237cc3fe6601646a5506)
Bug: 1431940
Change-Id: I600c192e8fdaabcbe60874e9c92c8d8e304fd7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4408758
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Scott Haseley <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128381}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423965
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#548}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][infra] Generate gn_isolate_map.pyl from starlark definitions.
This CL adds a library that allows for creating the gn_isolate_map.pyl
via target definitions in starlark. A targets library is added that
includes functions for defining targets. Currently, these functions map
directly to the types present in gn_isolate_map.pyl. As support for
specifying a builder's targets in starlark is added, functions will be
added that define the targets in terms of the types present in
waterfalls.pyl.
Because pinpoint builds at revisions that are not the tip-of-tree, we
cannot change the interface between the recipe and the checkout until
all of the revisions that pinpoint would build support are compatible
with the new interface. Since the recipe contains configuration pointing
at //testing/buildbot/gn_isolate_map.pyl, we can't remove it. In order
to have the version generated by starlark be the effective version,
//testing/buildbot/gn_isolate_map.pyl will be retained, but it must be
kept in sync with the copy added at
//infra/config/generated/testing/gn_isolate_map.pyl. Presubmit checks
and a script are included to help guarantee that.
(cherry picked from commit ec1e33917204d9e2ff2d87fac75be1c50dc792e8)
Bug: 1426635
Change-Id: Ia63ff6ac7028661fc76452be502e053978e2c569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412694
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129404}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420180
Auto-Submit: Garrett Beaty <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#547}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
AbortSignal: Delay LazyActiveScriptWrappable registration
Composite AbortSignals were being registered in the constructor, which
could lead to HasPendingActivity() being called while constructing the
composition manager, which is accessed there. This CL defers the
LazyActiveScriptWrappable registration until after the object is fully
constructed by implementing ActiveScriptWrappableBaseConstructed() to
enable PostConstructionCallbackTrait.
(cherry picked from commit f94b8707a1b215e8edee3403d9677a9e2ae84ca4)
Bug: 1431233
Change-Id: I561ea7a860deec195c867f90a66c633e0080c967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412415
Commit-Queue: Scott Haseley <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420959
Cr-Commit-Position: refs/branch-heads/5672@{#546}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Move geo-manager init to pre-profile on Lacros
Initializing Geolocation Manager on Lacros In PreProfileInit().
(cherry picked from commit 32be6641ce4341113bc18b9e388b1da18bda3b4f)
Bug: chromium:1425800
Change-Id: Ib409402cf96c6e7bcc77cc4ed272ba5be1a4a31c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400094
Commit-Queue: Jan Láník <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127283}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414490
Commit-Queue: Ahmed Fakhry <[email protected]>
Auto-Submit: Jan Láník <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#545}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Fixed optional button getting drawn when its width is zero
The toolbar on Android is temporarily replaced with a screenshot when
scrolling or transitioning between states. These screenshots are taken
by directly calling draw() on all toolbar views. Some screenshots
included the optional button on a wrong location, which was shown for
a frame or two when switching to the NTP.
The optional button was being drawn on the screenshot despite having
zero width because we only checked the button's visibility.
This CL adds a width check to the screenshot capture method on
ToolbarPhone to avoid drawing it when it's not supposed to be
visible.
(cherry picked from commit 833a545f2e453e5d09b2e2bbdc88dbe542378d18)
Bug: 1422176
Change-Id: I8967b422e2e0b81e4e474f435bd8afec726926e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4403605
Reviewed-by: Sky Malice <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Salvador Guerrero Ramos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127644}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423673
Commit-Queue: Patrick Noland <[email protected]>
Auto-Submit: Salvador Guerrero Ramos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#544}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Omnibox] Restrict "narrow window on tablet" fix to actual tablets
We don't want to turn on tablet behavior for phones rotated to have a
wide-enough-to-be-a-tablet screen because the layouts aren't set up to
align correctly. We should limit the behavior to just "screen is always
large enough to be a tablet" devices.
(cherry picked from commit cf5e56320e5b3d3a2f47c58921ef2abf3ca733fe)
Bug: 1430377
Change-Id: I830169b1f36c22b8fc3d9dc1af847b7aae02246b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401719
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128909}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423674
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#543}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Deny permission requests if they are made on prerender
In crrev/c/3543586, the preload is cancelled when the web view attempts
to present the media permissions request dialog by calling the method
`WillDisplayMediaCapturePermissionPrompt`. This method resets the web
state's unique_ptr, causing the previously retrieved webStateImpl raw
pointer to stop pointing to a valid web state object.
Also, in the previous fix, the permission decision handler still handles
WKPermissionDecisionPrompt which isn't the intended logic (although it
seems like the WKWebView somehow doesn't execute the prompt when that
happens.) Chrome should deny the permission whenever the web state is
not valid. Both issues are fixed in this CL.
(cherry picked from commit 35228c286cf4fe493e7f3c72ad48bae0ad5ec434)
Fixed: 1431208
Change-Id: I8e04cc97c9cda7e19ae8f2d9742c57615f9489d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4409744
Auto-Submit: Ginny Huang <[email protected]>
Commit-Queue: Ginny Huang <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128785}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423310
Commit-Queue: Ali Juma <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#542}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Revert "Unselectable content should not be copied to clipboard"
This reverts commit 97ba01b40f88c678c8bedfc795e1cd14aee97d2b.
Reason for revert: Root cause of crbug.com/1423719
Bug: 1423719
Original change's description:
> Unselectable content should not be copied to clipboard
>
> If unselectable (user-select:none property) content is copied, the
> unselectable content should be excluded from the clipboard for any
> future HTML format pasting.
>
> Due to shadow DOM selection being a work in progress, this CL does not
> exclude unselectable shadow elements. An unselectable shadow host
> and/or shadow element(s) will have its markup serialized as normal.
>
> If we encounter an unselectable node, its subtree will be checked for
> any selectable descendants. If a selectable descendant or shadow DOM is
> found, all of its unselectable ancestors' start (and end) tags will be
> applied to it, thus preserving any inherited styling from ancestors.
>
> Bug: 1083125, 850685, 1399317
> Change-Id: Ic938892454059fc20d507590c692d38fdc4a9f1c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4102840
> Reviewed-by: Xiaocheng Hu <[email protected]>
> Reviewed-by: Anupam Snigdha <[email protected]>
> Commit-Queue: Stephanie Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1115185}
(cherry picked from commit 12193fc1d4eccea4d60540756f903c2c6213b4c0)
Bug: 1083125, 850685, 1399317
Change-Id: Ifaa3e68cc7b6ba67b551536e9dbbe356f0e529dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4395837
Reviewed-by: Anupam Snigdha <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Stephanie Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1125685}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418771
Auto-Submit: Stephanie Zhang <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#541}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-13 UTC
Change-Id: Id6c32a5a6fed90c16ba2ea6fa9bfb53b22af9804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421296
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#540}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-13 UTC
Change-Id: Ie8951a5310417ff6dfb3fc34f43cbba751e83528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422623
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#539}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Metadata][Android] Add grey border to credit card art
Add grey (#E3E3E3) border of 1dp to custom credit card arts.
Specs: https://docs.google.com/presentation/d/1gg-AqNi6Qs3Yh9zPUfAu3Igt6mGm3JHWqSUJTpxlAB8/edit?resourcekey=0-ldBHWaffSyW0zeIe8-sy5g#slide=id.g2059f577e5e_0_99
Current UI: https://screenshot.googleplex.com/5WCk8Jd6yaoDEqV
Implementation UI: https://screenshot.googleplex.com/ypVdyjXJNvL52nr
Note: The network icon assets like Visa, Mastercard, etc. already have
the grey border. It is only added to the custom card arts (American
Express icon in the screenshot).
(cherry picked from commit 0dde387c5c13a7c412cdbcaedadeefe04fad1f38)
Bug: 1428441
Change-Id: I4690639c4d296c6129b546236ea386f076f8d6a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375792
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Reviewed-by: Siddharth Shah <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128723}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423289
Cr-Commit-Position: refs/branch-heads/5672@{#538}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681357181-348bd319034ba1f7380207b3c5f0c5a6ff345d07.profdata to chrome-win64-5672-1681378933-cc83cdc692d2beb84214d7acb1c1fc2605507d0c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Ie9acd42bd0b6f0fce27c06fa6efdff947c4309a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420700
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#537}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681357181-f170941024f1d7b2b22514fdf93325a6f5085faa.profdata to chrome-mac-5672-1681378933-b20a7246ed9d9b6cd5e81f6adfed8389beb348ff.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I21318808b4beb5f450e55064324c7a485e93cb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422971
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#536}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][ios/b4p] Record metric when account storage opt-in switch is flipped
Behavior changes are behind a flag disabled by default.
Record the new state of the toggle.
(cherry picked from commit 5897c8bda07088d215d0dbfce871f0d9c666ea14)
Bug: 1392747
Change-Id: If2ae9403c7ad1975600d7a4ea550d543a214a47c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4403588
Reviewed-by: Viktor Semeniuk <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129476}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420807
Auto-Submit: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#535}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Updating XTBs based on .GRDs from branch 5672
Change-Id: If4e0493ea960f4243b089b7bbad8d26672d61b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4423129
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#534}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][ios/b4p] Record metric when move-local-pwd-to-account button is shown
Behavior changes are behind a flag disabled by default.
(cherry picked from commit ade6f59bfca5b16698aaf99d8892528e4dc866b1)
Bug: 1392747
Change-Id: Iafe2dda8dc4a128e0d7694baf82ebeef55249da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4406216
Commit-Queue: Tommy Martino <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129469}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420348
Commit-Queue: Victor Vianna <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#533}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681339392-883d44cbb8c412ac52248e73447a5e596fc54bbb.profdata to chrome-win64-5672-1681357181-348bd319034ba1f7380207b3c5f0c5a6ff345d07.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I15f2ad3baa897966ccc09d997c71f34b3681aa42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421461
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#532}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681339392-d13b8c5484ecd7b247e734f5a6975902bdd35b71.profdata to chrome-mac-5672-1681357181-f170941024f1d7b2b22514fdf93325a6f5085faa.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: Ibf9152924f8f473b4d0c5d442825f4abea0ab4d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422291
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#531}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681339392-174b53af81ac9da6a9c8ba268aab19e1a7276869.profdata to chrome-linux-5672-1681357181-d76e614aafa1cc038da586dcc3580af031e82e9d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I3d323a38c0be8f9ebd853de3c306eb1e206ac506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422448
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#530}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681321884-74ba123befc42c4ab37ae0090c7093ee48b47be1.profdata to chrome-win32-5672-1681339392-448858a29f32d2548b430ca39c7d52ee52011b32.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I94a83d48fbba39d3e8a30dec143d5ed288e78468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421452
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#529}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681321884-cebed9073fb766b7e7013e483c1e52ba6cbf1dea.profdata to chrome-win64-5672-1681339392-883d44cbb8c412ac52248e73447a5e596fc54bbb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I659853916e40bab1cd1d577d8a00ed475751e52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420438
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#528}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681321884-e817271bb178a0ca0e61199239cf1a3c1841b020.profdata to chrome-mac-5672-1681339392-d13b8c5484ecd7b247e734f5a6975902bdd35b71.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I55a467b96edb37921bdab4c6dc0cbaf68124b295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420687
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#527}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681321884-62bd3ff7cc15fc3d37a665c07e6058a0e7facefe.profdata to chrome-linux-5672-1681339392-174b53af81ac9da6a9c8ba268aab19e1a7276869.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I2d5292829eade1f64f06e5a044572fbb1f731973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420377
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#526}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.35
Change-Id: Ief62135fdffce2f0daded035e208a4d6dc7d7f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4421547
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#525}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][infra] Rewrite gn_isolate_map.pyl to use consistent conventions.
In order to make it easier to see the actual content changes that will
result from generating the file, this applies consistent formatting and
ordering to the entries in gn_isolate_map.pyl:
* Consistent use of spacing
* All strings use " instead of '
* All entries have a trailing comma
* The keys in each element appear in a consistent order:
* label
* label_type
* type
* script
* executable
* executable_suffix
* skip_usage_check
* args
(cherry picked from commit 7de5986d1f6fd91e17ae4dbf1ae8af9f6967bac2)
Bug: 1426635
Change-Id: I4490e433722bfabf2c90ea71414c16f75ce69fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412423
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1129332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420159
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Garrett Beaty <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#524}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll v8 11.3 from dc97ada0077e to 0e75d85d8e34 (2 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/dc97ada0077e..0e75d85d8e34
2023-04-12 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.3.244.8
2023-04-12 [email protected] [runtime] Make Error.captureStackTrace() a no-op for global object
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-release-0
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in v8 11.3: https://bugs.chromium.org/p/v8/issues/entry
To file a bug in Chromium m113: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1432210
Tbr: [email protected]
Change-Id: Ieecd3014a6b1f9f678162be1888b0fc83d971dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420128
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#523}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681293563-2a8182931487f0e474df6cd372953eb262aa49c4.profdata to chrome-win32-5672-1681321884-74ba123befc42c4ab37ae0090c7093ee48b47be1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I5d1a6e2d06400dcf48a852b9d8da2e8ed3513da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418638
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#522}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681293563-087266a8f9cd70b1fb339c944c90e546ff2c3711.profdata to chrome-win64-5672-1681321884-cebed9073fb766b7e7013e483c1e52ba6cbf1dea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Ieeaf20363f1edcd9099e309004aec675791f1735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418951
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#521}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.34
Change-Id: I508c5d70abec290a6a9135e48f7ffc3b658544fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4420906
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#520}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Reland "Add a dedicated target type for the extension popups"
This reverts commit 685ed1920b619b0814e4f61c8f90b69773e64c2f.
Reason for revert: Fixed tests by limiting the change only to extensions popups.
Original change's description:
> Revert "Add a dedicated target type for the extension popups"
>
> This reverts commit 990039b4c37515eb9918d7e21691b4768a9f4e60.
>
> Reason for revert: broke VK
>
> Test via tast -verbose run -checktestdeps=false 127.0.0.1:6666 inputs.VirtualKeyboardChangeInput.a11y inputs.VirtualKeyboardDeadKeys.french
>
> Original change's description:
> > Add a dedicated target type for the extension popups
> >
> > Bug: 1414330
> > Change-Id: I04fcae59c07ebebc40c8f8cb2ed53d40272d531c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4245598
> > Auto-Submit: Danil Somsikov <[email protected]>
> > Reviewed-by: Devlin Cronin <[email protected]>
> > Commit-Queue: Danil Somsikov <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1117976}
>
> Bug: 1414330
> Change-Id: Iae18b23dcd522f0020576564cd5d77643274fede
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349613
> Owners-Override: Jeffrey Young <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: John Palmer <[email protected]>
> Reviewed-by: Jeffrey Young <[email protected]>
> Commit-Queue: Jeffrey Young <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1118518}
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
(cherry picked from commit 12ae89b6d5c917dde5d37b368164c0d04e832a62)
Bug: 1414330
Change-Id: I83dd223bff56458f39bcbc97682d6712bf34f829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347754
Reviewed-by: John Palmer <[email protected]>
Reviewed-by: Jeffrey Young <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1124671}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418428
Owners-Override: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#519}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681293563-dea68b12ab0e6ecd51eb890c55785aa217e23b22.profdata to chrome-mac-5672-1681321884-e817271bb178a0ca0e61199239cf1a3c1841b020.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I32f6c50884e263712351442ef592869341511b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418892
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#518}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681293563-d85c590ebb619cc006d892070e3c332b70aab93c.profdata to chrome-linux-5672-1681321884-62bd3ff7cc15fc3d37a665c07e6058a0e7facefe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I13239772ddcb7473ff61f351bc588defefe032ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4419274
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#517}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Record PasswordManager.AccountStorageUserStateDuration.* metrics on iOS
This metric was already recorded on desktop, record it on iOS too now.
Bug: 1392747
Change-Id: Ic3fa35e1c46f24516cdea26636a6bb1707f39535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414706
Commit-Queue: Victor Vianna <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#516}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Migrate some write failure NOTREACHED calls to DLOG(WARNING).
A number of disk write failures result in calls to NOTREACHED. These
should be DLOG instead, since it's possible for these calls to fail.
(cherry picked from commit f8e0cd4b2d9e8de169e07ef5e2d7bc7e7eedcda1)
Bug: 952304, 1430717
Change-Id: Ibbb29c11c26eba707e8fa1e35becbb455832bf16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412195
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128712}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418636
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#515}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Disable recording ETM for kernel
(cherry picked from commit 062d2d17388b9520f92d4e3871f7742b31989dcf)
Bug: b:275560674,b:276372121
Change-Id: Ic7223d92202ddf4c28fcb63d3704b6f27d42cb74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4396942
Reviewed-by: Gabriel Marin <[email protected]>
Commit-Queue: Gabriel Marin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126089}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402392
Commit-Queue: Denis Nikitin <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#514}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Protect against malformed Windows printable area values
Some printer drivers provide bad printable areas, with respect to the
corresponding paper sizes. Disregard the bad values in such cases and
default to using the paper size.
(cherry picked from commit 3cb6047e70178b8ac479488c1945d217af67e2ec)
Bug: 1424368
Change-Id: I31249ee28523c2ec222951a88bee882d70c7aa60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412367
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Alan Screen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128423}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415636
Reviewed-by: Andy Phan <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#513}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Update paper printable area in UpdatePrintSettings
When getting the default printer capabilities and settings, updates in
https://crrev.com/1099645 filled in the printable area for all paper
sizes supported by a Windows driver. For some printer drivers this can
be a relatively expensive call. Since this is in an inner loop of
supported papers sizes, the performance cost is further compounded when
a printer supports many different paper sizes. This can result in
large delays in generating the Print Preview, and can make the UI
unresponsive for many seconds.
To avoid this performance impact, modify the Windows behavior for paper
printable area handling. Change getting printer capabilities to only
retrieve the printable area for the default paper size. Introduce a
new Windows-only call to PrintBackend to retrieve just the printable
area for a particular paper. Modify PrinterQuery to use this query to
update an existing PrintSettings object.
This initial version only is functional when printer calls are made
in-browser. Out-of-process printing for Windows still performs the
expensive query of retrieving the printable area for all papers. While
the UI will be responsive for OOP, it will still experience a large
delay before the preview is ready.
(cherry picked from commit 0bc5a4ec76d7eed33e15599313baa575aa3f7a06)
Bug: 879284, 1424368
Change-Id: I0b22abfb88e922a3f50fc26fd6502cdb9a01299e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4409898
Commit-Queue: Alan Screen <[email protected]>
Reviewed-by: Andy Phan <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128325}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412875
Cr-Commit-Position: refs/branch-heads/5672@{#512}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Metadata][KA][Android] Round card art image corners
Credit card icons on the Keyboard Accessory have a different corner
radius (2dp) than other surfaces (3dp).
Mocks: https://docs.google.com/presentation/d/1gg-AqNi6Qs3Yh9zPUfAu3Igt6mGm3JHWqSUJTpxlAB8/edit?resourcekey=0-ldBHWaffSyW0zeIe8-sy5g#slide=id.g2059f577e5e_0_99
Implementation: https://screenshot.googleplex.com/3BDJCmjhmwCm234
All changes are behind AutofillEnableNewCardArtAndNetworkImages flag.
(cherry picked from commit f2c16773bc3d51843b09853d323d6780a782038b)
Bug: 1431157
Change-Id: I6b77fb99a3c2efb0560fc8a632ba40cfee73188c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4397879
Reviewed-by: Siddharth Shah <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127146}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414783
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#511}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Revert "Make NavigateReaction private to NavigateEvent"
This reverts commit 33e597e42fd994c64015b674f102fccc48d9537f.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1427406
Original change's description:
> Make NavigateReaction private to NavigateEvent
>
> Most of the logic now lives on NaviagateEvent itself (in React()
> and ReactDone()), which the new NavigateEvent::Reaction is a minimal
> callback function wrapper.
>
> Change-Id: I052cd7c3a1c43cf4da2ad8c67970cc1668b2b51b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351008
> Reviewed-by: Domenic Denicola <[email protected]>
> Commit-Queue: Nate Chapin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1120892}
(cherry picked from commit 34c3e0a78ce70ed8c7fedee9bf209a85d335670a)
Fixed: 1427406
Change-Id: I25a854752284a8556ddeb786eb26daad098668fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370470
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1121842}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418867
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#510}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Strip comment tokens when parsing pending substitutions.
CSSPropertyParser::ParseValue() isn't ready for comment tokens,
which we now preserve since we need them for the original text.
Strip them out right before parsing; as the comment says,
this probably isn't optimal, but it shouldn't be too bad either.
(cherry picked from commit 2bb5c929a7766e5385a3c538a024060af55e1886)
Fixed: 1430953
Fixed: 1431444
Change-Id: I3f1039ddd4424b1d0a72e42cc2ba4fa1a243ca0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414717
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128618}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418368
Auto-Submit: Steinar H Gunderson <[email protected]>
Reviewed-by: Prudhvikumar Bommana <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#509}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][RPM] Add check for 2023 signing key
Per the same CL(crrev.com/c/3671495) in 2021, without this check, the 2023 signing key won't get installed if previous keys are already installed.
R=thestig
(cherry picked from commit 2daa39e9c6ddc8d479a2fe156735ed2ddf4fe2cf)
Fixed: 1419885
Change-Id: Idb214208d47d8f87407da8bd3b16a03c9e929d68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404987
Commit-Queue: Xinan Lin <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127532}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416720
Cr-Commit-Position: refs/branch-heads/5672@{#508}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Add 2023 Linux Package/Repository Signing Key
R=thestig
CC=mmoss
BUG=1419885
(cherry picked from commit a09e77359c939913f6a84ae43ed81bea32f9b46e)
Change-Id: Iac4670005264d68b2df30c669bf5d5709526efc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404892
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Xinan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127371}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416678
Cr-Commit-Position: refs/branch-heads/5672@{#507}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[iOS] Store text field values in new password view of CPE
This CL adds storing values of username, password and note text fields
as with a very long note some cells might be dequeued and their text
field values would not be accessible even though they might be needed
(e.g. to check if the save button should be enabled).
The new fields are used only with notes feature enabled.
Before fix: https://drive.google.com/file/d/1RktkAWLARkxw4rUVn9s39NpJwd8n3sbE
After fix: https://drive.google.com/file/d/11CEWTW1XAyZvPO9QKrdkj8zqoKw1J8fb
(cherry picked from commit 679bcc10c0b56ebe370a4937b282dce66848d3ef)
Bug: 1429208
Change-Id: I77a74e707c02d1aa19f737149eb0906e7715a82c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4384453
Commit-Queue: Rafał Godlewski <[email protected]>
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1124365}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4418646
Cr-Commit-Position: refs/branch-heads/5672@{#506}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681278763-0525e5368c60132f0d5991035db97bd1fb0be6ab.profdata to chrome-win64-5672-1681293563-087266a8f9cd70b1fb339c944c90e546ff2c3711.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Ib0a64c16e39cf7b0bf13206c485f4d51ab1499b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417870
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#505}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-12 UTC
Change-Id: I6be71f89b24dea2fd527783f4ae0184b701ff58d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414592
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#504}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681278763-32eec6422361962434cc2567d6513db48ff5f727.profdata to chrome-win32-5672-1681293563-2a8182931487f0e474df6cd372953eb262aa49c4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Iaf5964e0c501b5652b4280801942d414ad20a59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417892
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#503}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Automatic update from google3
Automatic update for 2023-04-12 UTC
Change-Id: I4668c0a180b2f3c12295e8d5f78e2215af6b13ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417929
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#502}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Updating XTBs based on .GRDs from branch 5672
Change-Id: Ia6c3fa9a6f4421037fcf1ccf8d77b5f834892265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415177
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#501}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681278763-3b05dcf61db7de601c51ca1703d89d29cbba19bc.profdata to chrome-mac-5672-1681293563-dea68b12ab0e6ecd51eb890c55785aa217e23b22.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I02604ef609a58a7b0a0ac65a4120c30641eb8588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417893
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#500}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681278763-3e04d6b27c528145c6e3aceed237624b3b290cef.profdata to chrome-linux-5672-1681293563-d85c590ebb619cc006d892070e3c332b70aab93c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I14ad57e298ad335b56521294702bbeeeb3350970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417895
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#499}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Metadata][Android][Tech Debt] Merge the 2 getCardIcon methods
All Chrome-on-Android surfaces to use the same getCardIcon method from
AutofillUiUtils.
(cherry picked from commit cb9c8164a4a99c58e27f52847bd3b8a6b49cdb56)
Bug: 1430818
Change-Id: If607df28d21998cb9584d27f25b447a36c64a48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4396202
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126619}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4413436
Cr-Commit-Position: refs/branch-heads/5672@{#498}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Check CustomEditMenu flag when adding partial translate entry.
The flag was not checked, and the entry was always added in the lookup
menu instead of being added at the end when the flag is disabled.
This is due to 2 concurrent bugs:
- flag not being checked
- entry being added too early in the menu.
(cherry picked from commit 9c82d2060c1509187b86537dee5d2a580e10b82b)
Bug: 1430803
Change-Id: I5844b605c2522bc1695e09370bf5290c4af3fb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401360
Reviewed-by: Sylvain Defresne <[email protected]>
Auto-Submit: Olivier Robin <[email protected]>
Reviewed-by: Quentin Pubert <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127147}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414700
Cr-Commit-Position: refs/branch-heads/5672@{#497}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681249923-bac12cd818c73c6824ad43ef30c4789381d1ee7f.profdata to chrome-win64-5672-1681278763-0525e5368c60132f0d5991035db97bd1fb0be6ab.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I0ed3ace2c970586f898038212183770745b5d8cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417209
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#496}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681249923-26f53642f282e8d169d8e3fc69be88ca78c88418.profdata to chrome-win32-5672-1681278763-32eec6422361962434cc2567d6513db48ff5f727.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Ibdedcfbdfca23ebbd488943c8ba36f8839443163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417005
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#495}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681249923-dd6f342751b6f6ff4dd96e95575f5a61cf4b1bc3.profdata to chrome-mac-5672-1681278763-3b05dcf61db7de601c51ca1703d89d29cbba19bc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: Ia4ac1ac48ce0882cdc5556e29e09b7ca67e36e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417143
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#494}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681249923-306abe7a6f365a27848dc867cb93fc4ea5195e7f.profdata to chrome-linux-5672-1681278763-3e04d6b27c528145c6e3aceed237624b3b290cef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: I64a2526abed3b0517795df2a8da24b6274e0f501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417145
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#493}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[merge-m113] [CrOS] Update media_app to jBqCvHK_nRzSlQ39oGemZF_hSmtPKGRom2wqsPvdJpMC
Cherry-pick of change to fix an issue where unused elements in PDFs are
not cleaned up on save.
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/jBqCvHK_nRzSlQ39oGemZF_hSmtPKGRom2wqsPvdJpMC
Release Notes: http://go/media_app-x20/relnotes/Branch/media_app_chrome-apps-backlight_202303230700_RC02.html
PDFium roll only, so release notes are empty.
Bug: b/277655411
Change-Id: Ifbc1cffaa68993a9456a0d750f9322ea50e63e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4413764
Commit-Queue: Patti Lor <[email protected]>
Reviewed-by: Meredith Lane <[email protected]>
Commit-Queue: Meredith Lane <[email protected]>
Auto-Submit: Patti Lor <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#492}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681235660-44abb96e4fb05ad8f7259efaec827f423cd1ffe8.profdata to chrome-win64-5672-1681249923-bac12cd818c73c6824ad43ef30c4789381d1ee7f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: I04caf3aeaffcc53553af9f28db8998cb7e432211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414104
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#491}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-5672-1681213916-e1a445bff78ba5aa67a82393752cc82dea469aea.profdata to chrome-mac-5672-1681249923-dd6f342751b6f6ff4dd96e95575f5a61cf4b1bc3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:mac-chrome
Tbr: [email protected]
Change-Id: I15fd6cc0c7235f26f2cdffb1b9efe2858eeb0b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416996
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#490}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681235660-e0976b9c3f3e1696271225517166bb721950d197.profdata to chrome-win32-5672-1681249923-26f53642f282e8d169d8e3fc69be88ca78c88418.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: I239cd7d97904c2fb318e023680b749753675ff78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416819
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#489}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681235660-60937ffb11390a40400c95d20e56011b84a8318a.profdata to chrome-linux-5672-1681249923-306abe7a6f365a27848dc867cb93fc4ea5195e7f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: If391dc26d93dd8f37b566cf33d35fee936b94ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416389
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#488}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Incrementing VERSION to 113.0.5672.33
Change-Id: I7514b9aca506c6ccfd7f34374108507dcbf3fc9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415062
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#487}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-5672-1681169498-38f8a0236de58920008c73f5d6449d2f7f9d1bb3.profdata to chrome-win32-5672-1681235660-e0976b9c3f3e1696271225517166bb721950d197.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win-chrome
Tbr: [email protected]
Change-Id: Id9156b1528489d926605c5cd74ea4e461a954c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415592
Bot-Commit: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#486}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113]Extend enable-commerce-developer flag
(cherry picked from commit 4cf6f8910fd8a9f83cf8967b0e658c4990a52e86)
Change-Id: Ib773136b89f6072abf23c2455bd265374f1f094e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374667
Reviewed-by: Yue Zhang <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Auto-Submit: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1122659}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414935
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#485}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][ChromeCart] Introduce pending deletion tracking and restoring
This CL adds capability to restore pending deletions using old proto
when needed. This will fix discount information being wrongly deleted
due to ephemeral cart deletions. This CL also makes the deletion pending time shorter as long pending time leaves more room of error for
consecutive deletions.
(cherry picked from commit 58edb746c573a0110a382e016a05dec80d131dd2)
Bug: 1429339, b/275753158
Change-Id: Id27116a472990fe90299b84aab5044c37b251ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402336
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127612}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415806
Cr-Commit-Position: refs/branch-heads/5672@{#484}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113][ios] Log PasswordManager.SaveUIDismissalReason.{AccountStorageSuffix}
The suffixes of this metric splitting by PasswordAccountStorageUserState
were not being logged on iOS because the state parameter wasn't passed.
Behavior changes are for all clients, with the main goal being to have
access to the metrics during the EnablePasswordsAccountStorage
experiment.
https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:components/password_manager/core/browser/password_manager_metrics_util.cc;l=106-112;drc=924687d1434ce6b38796d97be60c93e1e5622ebe
https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm;l=108;drc=22f8f0a11f2dabfeb56784e2c1341b8040497a36
Next CLs will make the parameter stop being optional to avoid this
issue in the future.
(cherry picked from commit 9c3107ca9bab2565f4285e4c344aeaa040c17cc4)
Bug: 1392747
Change-Id: Id1187da064ee82cf8543cbca25c1808e25a8dda3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400963
Auto-Submit: Victor Vianna <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127227}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4414876
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#483}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-5672-1681213916-b49f987d071bd6a8460d65966591385aec9f63eb.profdata to chrome-win64-5672-1681235660-44abb96e4fb05ad8f7259efaec827f423cd1ffe8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:win64-chrome
Tbr: [email protected]
Change-Id: Ia1eb08a6890f12f74bbc65553facd56cef910322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415902
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#482}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Allow chromium try.shadow builders to create resultdb invocations in their own builds
(cherry picked from commit b6615ec11f7b9fb3dd92cc5dbcc6acc6e23f7e59)
Bug: 1422395
Change-Id: I9179a7ff2fb9008f52a5ee3ecc2fa66154013b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415003
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Chan Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416358
Auto-Submit: Garrett Beaty <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#481}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
CCT capture token includes width.
(cherry picked from commit 5e8209d1521bac3a27b1c25938b4f28bdf6e48fb)
Bug: 1428978
Change-Id: I46d6e39f6fa54d8b7a1e154e8b70b3445617fbbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400925
Reviewed-by: Kevin Grosu <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126606}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415196
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Ella Ge <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#480}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-5672-1681213916-a144dce8cf4ecb11c34456177b5f9db602a16fc5.profdata to chrome-linux-5672-1681235660-60937ffb11390a40400c95d20e56011b84a8318a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m113.try:linux-chrome
Tbr: [email protected]
Change-Id: Ibbc02ab16026b781e4a6ebe3924711e7d5bf807d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415997
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#479}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] preload: Follow-up to take metrics even for the second and later focus
This is a follow-up for crrev/com/c/4393867. With the CL, we record
EnterToPressDuration metrics only for the first mouse press event.
But the button instance keeps alive through the tab active cycle.
So, we should reset it when the next mouse action start affecting
to the button to take another metric.
(cherry picked from commit edfb75a683a478416debe45c8fcde6103715ab9d)
Bug: 1422819, 1430667
Change-Id: Ie1606e07171145b891135125d7b10180b15df996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402058
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Huanpo Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127512}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4405613
Cr-Commit-Position: refs/branch-heads/5672@{#478}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] cr-checkbox: Fix checkmark in high-contrast mode.
(cherry picked from commit 199f428cf275068f4768f5185af9ea63ffa2d8ed)
Bug: 1430980
Change-Id: Id15e37846e18e6bbb4f8c4d6110ecc98040d7033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4403186
Commit-Queue: Cole Horvitz <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126981}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415641
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Cole Horvitz <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#477}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Fix back press not dismissing tab group dialog
See https://crbug.com/1431009#c1
The back press manager calls getHandleBackPressChangedSupplier and
observes it from the startup. But it returns an empty observer
and has no opportunity to observe the new supplier after
mTabGridDialogCoordinator is initialized
(cherry picked from commit d300686862c5a57006a7d49377247bed6f39c1e8)
Bug: 1431009
Change-Id: Icf64ffee537e21e50491b2f10c7f882da280f05f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4403614
Commit-Queue: Lijin Shen <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1127368}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415798
Cr-Commit-Position: refs/branch-heads/5672@{#476}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113 Merge] Quick Answers: use WeakPtr for SearchResponseParser
(cherry picked from commit 5588f23ac4c6740bf502107335d80cd497a12da5)
Test: run existing tests
Bug: b/269168941
Change-Id: I5fde1aa519ab257dff4e50a14477d1e50e248a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4409595
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Angela Xiao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415799
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Angela Xiao <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#475}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Add a flag to enable ActivityTabProvider when handling back press
There are some slight differences between ActivityTabProvider and
ChromeTabbedActivity.getActivityTab, such as the former returns null
while the latter returns a valid when tab switcher layout is visible.
This causes some assertion errors and different behaviors between
control and enable groups.
This CL adds a flag. When enabled, ChromeTabbedActivity will use
ActivityTabProvider when handling back press. This allows us to
further investigate the potential impact when switching to
ActivityTabProvider.
(cherry picked from commit 88a1b4235a8b7086eaac333d1f8548da4a664ec7)
Bug: 1429359
Change-Id: I1ab5ff6116fdacddc18e50274a8371f7a3073538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4385154
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1124927}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415797
Cr-Commit-Position: refs/branch-heads/5672@{#474}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Update Crashpad to ada8dfa4a7eab70755cc5210026f23e394358d13
ada8dfa4a7ea ios: Always reset IOSIntermediateDumpWriter file descriptor
on close
(cherry picked from commit bcc296e26d3ccc6ee175b7d35f64aa92d2cd369a)
Bug: 1431760
Change-Id: I9f72a7a151a1ec3e3d0b8d6af7fd62a3e93105c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4410306
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1128352}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415540
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#473}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113]Fix back press callback not disabled after destroy
The crash says the callback is still enabled after destroy. This
indicates the mEnabledCount is eventually greater or less than 0.
One possibility is a handler passed in a null. Because
BackPressManager does nothing if it is a null.
This CL also refactors the way we count active handlers. This approach
is more straightforward and less error-prone, although it may
be slightly less efficient. Given the amount of handler
is fixed and only a few are enabled at a time in practice, this change
should not harm performance.
(cherry picked from commit 0b6120702e8f69ce43b34b02903a1d32a0be07d3)
Bug: 1426561
Change-Id: I4fddda3e46892c35a5eda148cd2c4399488bdd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4395574
Reviewed-by: Donn Denman <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126382}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415640
Cr-Commit-Position: refs/branch-heads/5672@{#472}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] Fix minimizeApp back press handler is initialized later than others
It seems minimizeApp is initialized slightly later than text bubble.
That means there is a small chance that a back press will be performed
to dismiss a text bubble while minimizeApp handler is not ready yet.
This CL makes initializing back press handler earlier.
Another possibility is some handlers cause app to be closed, which
removes minimizeApp handler. This CL adds an internal variable to
check that and stop triggering asserts if it has been destroyed.
This CL also polishes to cache finch param (no need to query every
time) and correctly check the max value of histogram.
(cherry picked from commit e7153f370fb3188bcfaf6789a784005120bbbb5a)
Bug: 1426561
Change-Id: I8613b4adba2d762f254de8a0f3478cae8f9eb502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4363256
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1123327}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415681
Cr-Commit-Position: refs/branch-heads/5672@{#471}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[M113] preload: Add more metrics to understand mouse actions around bookmarks
This change adds another duration time metrics to understand the delay
for pressing mouse button.
(cherry picked from commit 297abdfffd834da3e557ee1ac88440238b76514a)
Bug: 1422819, 1430667
Change-Id: I5c5264f0e258d3c106ef17cb5f13b230a0b9502c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4393867
Reviewed-by: Huanpo Lin <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126448}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412218
Auto-Submit: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#470}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
[Cherrypick][Lens] Add enterprise policy for Bling LVF
(cherry picked from commit d160a34e8f3cfd303dbe5b4e1946509fb4ead728)
Bug: 1428303
Change-Id: Ic606ba0d7b0f911777612fe98ceb2e600612999c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374762
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Commit-Queue: Jason Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1124587}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4395364
Reviewed-by: Igor <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#469}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}
Fix expiry for origin-agent-cluster-default flag.
The feature was originally intended to launch at M106; later M109;
and has now been delayed to M113+. This CL makes sure the flag remains
available in the chrome://flags UI.
(cherry picked from commit 68c2c47f57ebffd8125ba1fc0bcaca0b7313ec08)
Bug: 1429587, 1259920
Change-Id: Ice5227b78f9174ea2d214b35472274d076a1bb31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400103
Reviewed-by: Ravjit Uppal <[email protected]>
Commit-Queue: Daniel Vogelheim <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1126671}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415037
Commit-Queue: James Maclean <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Reviewed-by: Ian Vollick <[email protected]>
Auto-Submit: James Maclean <[email protected]>
Cr-Commit-Position: refs/branch-heads/5672@{#468}
Cr-Branched-From: 5f2a72468eda1eb945b3b5a2298b5d1cd678521e-refs/heads/main@{#1121455}