Publish DEPS for 107.0.5304.18
Incrementing VERSION to 107.0.5304.18
Change-Id: Ic7e378f6e33bb81131c3ae740d16a1b1da3f71aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3924216
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#214}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Add null checks and remove ChromeOS build flags for Lens Region Search.
The code that was introduced behind the kEnableRegionSearchOnPdfViewer
flag dereferences `browser`, which is sometimes null. Previously this
did not result in a crash because the null case was handled silently in
LensRegionSearchController. However, since the feature will not work
without `browser`, IsRegionSearchEnabled() should check it for null so
that a non-working context menu item will not be added.
LOW_COVERAGE_REASON=Code being changed has coverage.
(cherry picked from commit cd41555a7e98fcd91e37f532ed64ddbdc1839f9e)
Bug: 1354637, b/243534573
Change-Id: I58fa1bddb881a09260488e3cd1b58942a8678bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895482
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Bryan Nguyen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922769
Cr-Commit-Position: refs/branch-heads/5304@{#213}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] [RDSD] Consolidate ways to get domain wildcard patterns
Merge to M107.
WebsitePreferenceBridge.toDomainWildcardPattern is already used to get
domain wildcard patterns when manually adding Request Desktop Site
domain settings via Add site dialog in Site settings.
This CL updated Request Desktop Site toggle in the app menu to use the
same method to get domain wildcard patterns.
(cherry picked from commit 285bedbb1f1208599e4a00bf331f3fa9792ac73a)
Bug: 1367911
Change-Id: Ic7e306a9ea9cd6856a824891224c49ae2aa92f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916237
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Aishwarya Rajesh <[email protected]>
Commit-Queue: Shu Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1051401}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922752
Auto-Submit: Shu Yang <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#212}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Make password fields spellcheck-disabled by default
This patch partially implements the default spellcheck behavior [1] for
password fields so that an <input> is false-by-default as long as it is
or has been a password field. This fixes some cases where we
incidentally trigger spellchecking on passwords.
[1] https://html.spec.whatwg.org/#concept-spellcheck-default
(cherry picked from commit c5dff8f3bde817a269cc5f89b2b4183f31b5c673)
Fixed: 1363276, 1363865
Bug: 1365686
Change-Id: Icfeec56085a40e7d72849667410010f4a3a55f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906135
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049127}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921586
Owners-Override: Prudhvikumar Bommana <[email protected]>
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Reviewed-by: Prudhvikumar Bommana <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#211}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107 Merge] Welcome WebUI: Prevent background from overlapping text
(cherry picked from commit 52330277e88250a9893a16a2fd526d3f39beb0a7)
Fixed: 1366307
Change-Id: I20c79c4db051754f90937ebb99300d8d82ba8af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911343
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049927}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915921
Auto-Submit: John Lee <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#210}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Update feed signin promo icon
(cherry picked from commit cff50d1dc21b5dbfbe63dd0026b98f8d4a1f14e8)
Change-Id: I2ec12dcbf151719b6088a11d2f6ea34dd4c1e97a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913368
Auto-Submit: Adam Arcaro <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050746}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922056
Cr-Commit-Position: refs/branch-heads/5304@{#209}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Adding server-side language detection to Partial Translate.
Also fixes a few smaller bugs in PT:
- Show a retry UI if the Contextual Search request fails.
- Update the language tabs whenever the viewstate changes (e.g. coming
back from the advanced settings).
- Don't send fluent languages, which the server never translates.
(cherry picked from commit dc24b9e504a084ecf345a61c1463d0501d253b84)
Bug: 1314825
Change-Id: I41954b27c5ad5c65e66d559e2a945b154eef38f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906473
Reviewed-by: Josh Simmons <[email protected]>
Reviewed-by: Anthony Cui <[email protected]>
Reviewed-by: Basia Zimirska <[email protected]>
Commit-Queue: Josh Simmons <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049508}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922737
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Trevor Perrier <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#208}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] mediarecorder: Fix recording of canvas capture streams
Currently canvas capture produces memory backed RGB frames, but
MediaRecorder expected RGB frames to always be backed by GPU textures,
this CL handles RGB frames in CPU memory.
This CL also adds a test that actually validated encoding results.
(cherry picked from commit 6b1abde266c0d26d87199921dcc5dfadc8110d85)
Bug: 1367395
Change-Id: Ic7522ec5238512278b3420383249ebaf36f26c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3919914
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1051645}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922427
Commit-Queue: Eugene Zemtsov <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#207}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.17
Change-Id: Id4de07c72168cc75d66eb56b152309679ccd40b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923535
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#206}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
ax_ui: JAWS and NVDA reads the characters as BLANK when traverse through the characters using arrow keys
This is a partial revert of crrev.com/c/3876499 with a difference of
a new AXDummyTreeManager which is a blunt copy of TestAXTreeManager
used as a hot fix. Later, TestAXTreeManager can be inherited from
AXDummyTreeManager and even probably merged with AXTreeManagerBase
or AXPlatformTreeManager.
(cherry picked from commit 88f3833a0df2236e887dfdc1291093ce9586d0b0)
Change-Id: I65e04a3875b1bdab53f839933e42d6423d292ab6
Bug: 1366311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910168
Reviewed-by: Nektarios Paisios <[email protected]>
Commit-Queue: Nektarios Paisios <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1051816}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922219
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Reviewed-by: Prudhvikumar Bommana <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Owners-Override: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#205}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Shopping List] Tab helper for native UI
NOTE: The network annotation has been updated to reflect the fact
we did not merge the policy into M107.
This patch adds a tab helper for the shopping list's desktop UI. On
navigation, if the page is a product page, we'll fetch and cache the
product image so it is ready for display when the UI is triggered.
If navigation occurs prior to the image fetch completing, the
callbacks will be dropped.
(cherry picked from commit 8d58ea2349b09b2146d9c653b60a4693d6afc950)
Bug: 1358579
Change-Id: I1b3955ab9c05b6244d6ae9a855cd4ce9ead43277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852348
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049625}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917388
Cr-Commit-Position: refs/branch-heads/5304@{#204}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Ensure iterator validity in CustomElementRegistry::DefineInternal()
Currently, this function first resolves a promise, and then erases an
iterator from a hash map, but the promise resolving may run synchronous
JavaScript that invalidates the iterator.
This patch switches the ordering so that we always use the iterator when
it's valid.
(cherry picked from commit ed87ab54b29898a96a87e8fd497425db32539350)
Fixed: 1366813
Change-Id: Iaa6631db5f3ad47049f46ddf909f18a49e5880c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915346
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050816}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3922738
Commit-Queue: Joey Arhar <[email protected]>
Auto-Submit: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#203}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Fix username suggestion for autocomplete attribute
autocomplete='username' HTML attribute value was ignored previously in UFF.
After this fix saved usernames will be suggested when an input field has an explicit autocomplete="username"
(cherry picked from commit a743d8fe08465bf7f796a41e243d3caabb317865)
Bug: 1357489
Change-Id: I253c6e11950bc649ae6dd55c2df8401f21e5b108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892777
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Christos Froussios <[email protected]>
Commit-Queue: Din Nezametdinov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049585}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921458
Auto-Submit: Din Nezametdinov <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#202}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] media: Blocklist AV1 encoding on machines with multiple GPUs
This should allow us to experiment with AV1 encoding on machines
with a single NVidia GPU.
This also picks up a fix for GPU count crrev.com/1051576
(cherry picked from commit 0d131ef19b4a2556900098a0b4cedc3432ca1fb7)
Bug: 1367038
Change-Id: I46498ad112adea7716c27f84b561446b953aa4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914341
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050484}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3919740
Cr-Commit-Position: refs/branch-heads/5304@{#201}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Updating XTBs based on .GRDs from branch 5304
Change-Id: I154a4ba8481bb0c310ff844fcc0c858a5d7766ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921935
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#200}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Fix putImageData content disappearing with OOPR-Canvas
When a putImageData call overwrites the entire canvas, it triggers the
overdraw optimization. Because writing pixels is done out of band with
recorder draw ops, the recording were under the impression that the
canvas buffer was uninitialized after a putImageData call, which was
causing the canvas to be cleared when it should not be.
(cherry picked from commit ea26ea641d8abe9f5272d08eef8b112fb2b82501)
Bug: 1361165
Change-Id: I020f38e8b60da49941a52292f4f3a600d155e053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901091
Commit-Queue: Justin Novosad <[email protected]>
Reviewed-by: Juanmi Huertas <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048132}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907841
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#199}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[CVC] Cherry Pick - Fix Autofill CVC Prompt Confirm Button Style
This patch corrects the style of the Confirm button in the new CVC
prompt.
(cherry picked from commit 42ef8ae50f423a1177301961b7d919311b388b20)
Fixed: 1366818
Change-Id: I189dd303796dc7855eec442e78d45cdcadcd67cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913445
Reviewed-by: Gauthier Ambard <[email protected]>
Auto-Submit: Ernesto Izquierdo Clua <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918319
Cr-Commit-Position: refs/branch-heads/5304@{#198}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Android][MFill][Tests] Reenable integration tests
For unclear reasons, the android-arm-tests build does not pick up the
correct Features from the fieldtrial_testing_config.json. This breaks
the test relying on \#recover-from-never-safe-android fail since the
accessory has no reason to be shown without passwords in that case.
Using an explicit EnableFeature annotation works perfectly fine.
The second test failure was reproducible with a constrained display
dimensions. The simple fix here is to render a shorter sheet with only
the save toggle.
Any alternative implementation would rely on scrolling which increases
flakiness in integration tests.
(cherry picked from commit ce30c806c61fc42c51a8f34f5868e2ee7767a847)
Bug: 1365613
Change-Id: I42800021cb4ac0087ebb12d3feb0d9ee0821b54f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910011
Reviewed-by: Elizabeth Popova <[email protected]>
Commit-Queue: Friedrich Horschig <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050113}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921795
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: James Lee <[email protected]>
Owners-Override: James Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#197}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[UPM] Reenroll users into UPM automatically if sync & migration work.
This CL allows to enroll previously evicted UPM users back into the
experiment if:
1) SyncService has successfully completed a sync cycle
2) There are no auth errors
3) Password sync is active
4) The migration to the android backend has completed successfully
The maximum number of automatic reenrollments can be limited via Finch
by setting kMaxUPMReenrollmentAttempts parameter. If no value is set on the server, the number is unlimited.
(cherry picked from commit f692161eb5a4cf296c5bde530235888c579166e6)
Bug: 1365976
Change-Id: Iea6aa07a42928791cdc921c5203fd9bb21ada13f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913186
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Maria Kazinova <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050952}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918354
Cr-Commit-Position: refs/branch-heads/5304@{#196}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Android][Flaky] Disable integration tests
There is no clear path to fixing these tests and local reproduction
fails. Speculations so far:
* the test verifying the "Manage Passwords" section may run on a smaller
screen/keyboard on the bot which has the view outside the visible area
* the test verifying the empty state doesn't get the correct flag from
the field-trial (i.e. recover is not active and therefore the KA
remains hidden... plausible because other tests are not affected.)
(cherry picked from commit 5d9f2c9e7495c023629c3b359a3c15592ed6ce8c)
Bug: 1365613
Change-Id: Ic780e233a71aad1e3ec4e240e893ecc994f8550d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908008
Reviewed-by: Rohit Agarwal <[email protected]>
Owners-Override: Rohit Agarwal <[email protected]>
Commit-Queue: Friedrich Horschig <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049144}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921775
Owners-Override: James Lee <[email protected]>
Auto-Submit: James Lee <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#195}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
CCA: Fix touch AE/AF, prevent right click on preview video (Merge to M107)
There are 2 possible pointer events on preview video element.
1. (Left) click/touch - do AE/AF if possible
2. Right click - prevent default behavior to prevent user from seeing video control
(cherry picked from commit ee5162944768ee1f2d5b6948be9a9c80ef18cdbc)
Bug: b:246489424
Test: Manually
Change-Id: I4d61c8471ff55336fd54bb27a1fe9d974b890a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912537
Commit-Queue: Kam Kwankajornkiet <[email protected]>
Reviewed-by: Pi-Hsun Shih <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050182}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3919276
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#194}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][PriceTracking] Fix UI issues in price tracking list
* Add grey background to make the product images look nicer in dark
mode.
* Adjust product image width to make the wide images fit into the
image container.
* Register |SanitizedImageSource| in C++ which is missed in earlier
patches.
Before: https://screenshot.googleplex.com/9T9F2EctPN9WXzp
After: https://screenshot.googleplex.com/5gMx3xFHzd7kbfm
(cherry picked from commit 987552ec854d57231b18e427f113873e54669a5c)
Bug: 1367044, 1367016, 1346624
Change-Id: Ie7e2766a99d23dcd644d97f7f153054f8a75827f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914108
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050803}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917404
Cr-Commit-Position: refs/branch-heads/5304@{#193}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
M107 Merge: Fix the PWA window opened in the background issue when launch with url.
With the non mojom app launch interfaces, the app is launched
synchronously. However, that might be some other tasks which are
expected to be run before app launching, and the synchronous app launching might cause the schedule issue.
When launch the Meet PWA by clicking the button in calender window(W0),
if the link capture is enabled, LaunchAppWithUrl is called
synchronously, and the Meet window(W1) is opened and activated synchronously. And then the follow up task activated the calender
window(W0). This cause the Meet PWA window opened in background, not
activated and focus status:
LaunchAppWithUrl
--> Create W1
--> Activated W1 (Meet window)
Activated W0 (Calender window)
Modify CommonAppsNavigationThrottle to call LaunchAppWithUrl async to
let other follow up tasks (e.g. Activated W0) to run first, and then
launch the PWA apps to activate the PWA window, and keep the consistent
behavior as the mojom launch interface.
BUG=1365790, b:244472502
(cherry picked from commit 88b0c16d98953d19c22cc40c2254ea28c9095ccf)
Change-Id: I9deda09a68cd8cf264163dac25aabd6f59ff26ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906686
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050534}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3920691
Cr-Commit-Position: refs/branch-heads/5304@{#192}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107 Merge] Add merchant opt out error dialog handling for post OTP response
It is also possible to realize that the merchant has opted-out of
virtual cards at the end of an OTP authentication in the case of a
first-time Visa VCN use on a client. This is because the server will
automatically challenge the user in this case to bind the device to VCN,
without sending a request to Visa.
This CL updates the logic to display a merchant opt out error dialog as
well in this case.
Diff for OtpAuthServerVcnError unit test:
https://diff.googleplex.com/#key=5mtXzGQzkgC7
(cherry picked from commit c63b394554a2c47522ce55aa95f01e8a51d3bb12)
Bug: 1366164
Change-Id: I04de4f993c15169fb639145d14bfe4ea3fb27b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906166
Reviewed-by: Siyu An <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049342}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917389
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#191}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.16
Change-Id: Ia7bcfd0f04b52564a430bee3368c428a62120763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918531
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#190}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][PriceTracking] Show price tracking list when it's no longer empty
This CL adds logics in bookmark list to listen to product tracking, so
that the price tracking list will show after it's detected to be
no longer empty.
(cherry picked from commit e120330982b120bca1b0bfca5cfedf0fe7b45115)
Bug: 1366035, 1346624
Change-Id: I5526f18ecff6167283be7998bbc2fab9ec8c648b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907185
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050012}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915532
Cr-Commit-Position: refs/branch-heads/5304@{#189}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] [HSTS] Individually remove asus.com from the preload list.
(cherry picked from commit 808aa94f75f065a6ec2aee48d240c006258fc5df)
Bug: 1366547
Change-Id: Ia5e16bf9c480480297b2f568cdb26c8be7473ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910704
Reviewed-by: Chris Thompson <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050282}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916246
Commit-Queue: Chris Thompson <[email protected]>
Auto-Submit: Chris Thompson <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#188}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Change keyboard backlight default to Rainbow for demo mode.
Tested manually for demo session.
(cherry picked from commit 76f33372b5535a9ac293cec6f6ca739709385f59)
Bug: 243716427
Change-Id: If5b3d4828bbe3e7d8428fdf97d9054379cc7e629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901356
Commit-Queue: Bowen Li <[email protected]>
Reviewed-by: Yves Arrouye <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047835}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918935
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#187}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Add a disabled-by-default flag for fast-path paint property updates
Fast-path paint property updates caused a regression
(https://crbug.com/1365255) and we need to disable this code. Rather
than reverting the code entirely, this patch puts it behind a
disabled-by-default flag.
(cherry picked from commit de51064283f410a24f6753a52cc81f967e88a7d0)
Bug: 1347264, 1365255
Change-Id: I6220e96862f1f90106d25b60fa19792873752bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913767
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050873}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917914
Auto-Submit: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#186}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][Android][UPM] Add configurable ignored/retriable error lists
This is a reland of crrev.com/c/3899297 with fixed DCHECK. Removing
the DCHECK (in release builds) will have no side effects now.
This CL adds support for configuring GMS Core 1P API error codes to be
retried or ignored when occur on PasswordStore backend operations.
Error lists are comma-separated integer error codes. All errors which
are neither retriable nor ignored will result in evicting the user from
the UPM experiment.
Ignored errors will be passed to the consumer and are expected to
include
- AUTH_ERROR_RESOLVABLE
- AUTH_ERROR_UNRESOLVABLE
as these errors do not evict the user and are handled in a specific way.
Retriable errors will result in operation to be repeated on the GMS Core
backend when possible. This list will be ignored when retrying may user
visible or could result in data loss. This list is expected to include
- NETWORK_ERROR
- CONNECTION_SUSPENDED_DURING_CALL
- API_NOT_CONNECTED
- RECONNECTION_TIMED_OUT
(cherry picked from commit faf3330ef76b79797dd184c74ec9032fbc234077)
Bug: 1362464,1368125
Change-Id: I39fde63c76083434ac2bca0d6586a22eee30f383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899297
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Maxim Anufriev <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/main@{#1050195}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915174
Cr-Original-Commit-Position: refs/heads/main@{#1050653}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918337
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#185}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ntp][hpp][m107] Track promo ID that was blocked by user in TS
Track two promo IDs. The one that is currently being shown to the user and the one that was last blocklisted. So when 'undo' is pressed it takes in the last promo ID that was blocklisted.
Also resets the shown promo ID when there is no longer one. Adds a test to make sure the promo ID button doesn't show when it isn't supposed to. And removes obsolete TODOs as the bug was marked 'WontFix.'
This way when 'undo' is pressed it takes in the last promo ID that was blocklisted.
Fixes `Uncaught Error: PageHandler_UndoBlocklistPromo_Params missing value for non-nullable field \"promoId\"`
Screenshot of Promo w/o ID*: screenshot/4ryqPkaUEARpaED.png
Video of Promo w/ ID*: recall/-/eYglBuHngpsBcUOHBYSH2s/hKQxNE2EU2PKR5xrvIf3zC
*use fake data
(cherry picked from commit 400943574abf6612f34114022e1bd586990dc810)
Change-Id: Ic3a51b67d2b19a29b86ae20ef8880a6cf5dd7720
Bug: 1364533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908272
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Paul Adedeji <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050383}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918731
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#184}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][PriceTracking] Add user action metrics for side panel price tracking
(cherry picked from commit 0c72cb99bfbb9ebd7ff8e83f4b60f4f43a3f964a)
Bug: 1346624, 1364726
Change-Id: I8d26fd31d2ca4af2d7ff5c70929cbec9aa755a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901432
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049286}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911766
Cr-Commit-Position: refs/branch-heads/5304@{#183}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] #Lens Unified Side Panel: Use checked-in icon for lens and search favicon for 3P DSE.
Design Doc: go/unified-side-panel-non-google-dse (Fetching the favicon section).
- For lens, use the checked in icon to avoid latency in displaying the favicon.
- For 3P DSE, use their search icon in the side panel.
- Remove unused image search favicon url since its no longer required, we are instead fetching the favicon from the page favicon URL's instead.
Screen captures of the current implementation:
For Lens:
https://drive.google.com/file/d/1OG75ztmEGYK2xv6jLtJDZuzj-knvamfN/view
For Bing (enabled side panel experience for testing): https://drive.google.com/file/d/1SgjegTLsHOT4yM-S7enUVYfMqE0Oe8hU/view
When Search Engine changes: https://drive.google.com/file/d/11vUCIqABDzCDCu9Rq7lraaZLdFENkL9_/view
(cherry picked from commit d160c34352d91fe5522ef13478be04fee0cfcb79)
Bug: 1367316, b/243957486
Change-Id: Id294de832e581291f288cf6eeee49f8477ab1559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895533
Commit-Queue: Anudeep Palanki <[email protected]>
Reviewed-by: Orin Jaworski <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050709}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917387
Reviewed-by: Marlon Facey <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#182}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Set reporting origin properly for service worker responses
What:
Fix attribution registrations returned from a Service Worker with fetch() response.
How:
Use ResponseUrl() instead of CurrentRequestUrl().
(cherry picked from commit 4878688b1baffa3b8fdb9493a55bebbe9c78d247)
Bug: 1364447
Change-Id: I946fd671ae61405635ccd520c025960c99fcf430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900667
Commit-Queue: John Delaney <[email protected]>
Auto-Submit: John Delaney <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049944}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918911
Reviewed-by: John Delaney <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#181}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[merge to 107] wm: Fix crash when dragging transient child from shelf.
This can happen when the transient window can be dragged from the shelf
(i.e. save dialog). The transient window needs to be an activatable app
window as well (cannot drag bubbles from the shelf), and will be the
stored `window_` in WindowScaleAnimation. The transient can get
destroyed mid animation, but the parent keeps animating, resulting in
`window_` being invalid since the transient child was destroyed well
before animation end.
(cherry picked from commit 3e960e74ff73b2a84077bdb0e36666db40a2f4df)
Test: ash_unittests DragWindowFromShelfControllerTest.DestroyTransientWhileAnimating
Bug: 1200596
Change-Id: I673a33dc48f2ffe56c9591f433435384fc09e561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900133
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049895}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916249
Cr-Commit-Position: refs/branch-heads/5304@{#180}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Toolbar] Fix crash on post-destroy search engine change
(cherry picked from commit 56dcf7688e5f4c4aee1480afecef02884bb1da68)
Bug: 1366664
Change-Id: I8e2e4742a2f48a82f123ad89804758dd11b00494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915145
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050482}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917271
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#179}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Use PAGE_TRANSITION_LINK transition type for Trending Queries
This will prevent the search results page for the query from being
saved as a Most Visited Site option.
(cherry picked from commit be4210f360fe553c6cb6fec2a14c3565bf54d85e)
Fixed: 1367343
Change-Id: Ic3e95a3455333969163f90ff68d899084ec1ee1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913705
Commit-Queue: Chris Lu <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050791}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916848
Cr-Commit-Position: refs/branch-heads/5304@{#178}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Fix ShouldShowStartSurface Lifecycle
crrev.com/c/3766063 intended to properly log an omnibox tap
for IOS.ContentSuggestions.ActionOn* by setting NTPTabHelper's
-ShowStartSurface at the end of the Start Surface's lifecycle
in response to -viewDidDisappear. However,
ContentSuggestionsCoordinator's WebState is updated before that call,
so this solution is not viable. Instead, isStartShowing is added
to ContentSuggestionsHeaderViewController so the metric can be
logged in that class in response to a tap.
(cherry picked from commit a2410f8143899c3b46174eb53810d79058c3dc9a)
Bug: 1366629, 1323001
Change-Id: Ie76f61aecf997afbe00feea2b84da1e4367d4d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911420
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050497}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915374
Auto-Submit: Chris Lu <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#177}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios, ntp] Create new Feature names for client-side studies
This change creates new base::Features for
kContentSuggestionsUIModuleRefresh and kTrendingQueriesModule
for the client-side config capturing new users. If the client
is bucketed into the client-side study, these Features will be used
to check feature enabled states. This will ensure that only the
client-side config covers new users and also eliminate study clashing.
Unique field trial names are used for the about_flags feature overrides,
and they are checked first before registering the client-side trial and
when checking IsContentSuggestionsUIModuleRefreshEnabled() and
IsTrendingQueriesModuleEnabled(). This will allow for development
feature overrides of both client-side and server-side studies.
Unused feature params are removed to declutter the files.
(cherry picked from commit 85e8cc64bc3fd67c5d5e279598b1e6306ec4ee55)
Bug: 1359488, 1364210
Change-Id: Ibb7a7dedc8bd0d802d30e0ef5b10021c136621a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905789
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050761}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917403
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#176}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][Crow] Prevent IPH getting cutoff when it is too close to the edge.
This moves the padding into crow_chip_view from footer_second_chip_row, but doing this requires adding padding to the follow/following chip views, which is done programmatically after being moved to the second row.
(cherry picked from commit 34581584b5f4d97ed021d150a65906c2e6a31d30)
Bug: 1364387
Change-Id: Ie4ef5199e56303c80b6a30f189dc21563120d34e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911321
Reviewed-by: Travis Skare <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050250}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916248
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Sophey Dong <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#175}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.15
Change-Id: Iae8dcd19770c6955387bf00a3a61b18f257171f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3919390
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#174}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "[M107] Remove android-pie-arm64-rel from the CQ temporarily"
This reverts commit 0410ca414b516c4e1eeffe8a1ecb1d63537f7c2e.
Reason for revert: Bots appear back online and not dying
Original change's description:
> [M107] Remove android-pie-arm64-rel from the CQ temporarily
>
> android-pie-arm64-rel has many failed builds due to IAD BOT_DIEDS for its test capacity
>
> Bug: 1367475
> Change-Id: I860816ef51dc4e1d91efebd1570b57b26d244a71
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916685
> Auto-Submit: Stephanie Kim <[email protected]>
> Reviewed-by: Erik Staab <[email protected]>
> Commit-Queue: Erik Staab <[email protected]>
> Cr-Commit-Position: refs/branch-heads/5304@{#130}
> Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Bug: 1367475
Change-Id: I5a44ade844910c43590a6db3a4fa27d2e478d534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917105
Reviewed-by: Erik Staab <[email protected]>
Commit-Queue: Stephanie Kim <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#173}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Fixed issue causing Lens unified side panel to sometimes close.
Lens side panel coordinator listens to changes to TemplateURLService to
dergister the Lens side panel view when the default search engine
changes. Since the TemplateURLService changes more than just when the
default search engine changes, sometimes the Lens side panel would be
deregister unintentionally. This change ensures that the default search
provider actually changed before deregistering the side panel view.
(cherry picked from commit 629ef0cd7423c9237b3f7fa818508f41661e4c2c)
Bug: 1366869, b:246830697
Change-Id: I5130b8f714dfe4f0d852d06b8e4467f6ba3b1d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911284
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Anudeep Palanki <[email protected]>
Commit-Queue: Duncan Mercer <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050247}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916592
Cr-Commit-Position: refs/branch-heads/5304@{#172}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[107 cherrypick] [CodecImage] Verify CopyTexImage() is a no-op
We are looking to eliminate StreamTextureSharedImageInterface
subclassing GLImage as part of eliminating GLImage as a public
interface. The blocker to doing so is that
SharedImageVideoSurfaceTexture passes a
StreamTextureSharedImageInterface instance to
AbstractTexture::BindStreamTextureImage(), which operates on the
passed-in object as a GLImage. That invocation will in turn result in
the StreamTextureSharedImageInterface instance's BindTexImage() or its
CopyTexImage() method being invoked.
StreamTextureSharedImageInterface has two implementations, and their
implementations of these methods are as follows:
- StreamTexture::BindTexImage(): no-op
- StreamTexture::CopyTexImage(): no-op
- CodecImage::BindTexImage(): no-op
- CodecImage::CopyTexImage(): renders to front buffer
Hence, we need to focus only on CodecImage::CopyTexImage(). Our
suspicion is that it is currently always the case that
CodecOutputBufferRenderer::RenderToTextureOwnerFrontBuffer() has already
been invoked at this point and has either (a) rendered to the front
buffer or (b) failed because it's in a non-renderable state, making
CodecImage::CopyTexImage() itself a no-op.
To verify this hypothesis, this CL adds a DumpWithoutCrashing() call
if CodecOutputBufferRenderer::RenderToTextureOwnerFrontBuffer() will
not be a no-op when invoked via CodecImage::CopyTexImage().
(cherry picked from commit 0f61771750c4a95e03991766869ee30177221b99)
Bug: 1310020
Change-Id: I5b3b4f90e018183edab75e9b92c192f8be6d7962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908011
Reviewed-by: vikas soni <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049248}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916478
Cr-Commit-Position: refs/branch-heads/5304@{#171}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][WebProtectAllowlist] Separate out allowlist check from db check param
Separate out check_db and can_check_high_confidence_allowlist params.
This allows to skip only the high confidence allowlist check, and
allows v4 checks in case of timeouts or cached safe verdicts.
LOW_COVERAGE_REASON=Stub method for test class in unittest.
(cherry picked from commit b678647af87a2d80e1a8c44d96db7919c1d6be76)
Bug: 1366497
Change-Id: I9d65264528f6d9423b6dab4ab970c4bde5a95729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906375
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Rohit Bhatia <[email protected]>
Commit-Queue: Rohit Bhatia <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049772}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916133
Cr-Commit-Position: refs/branch-heads/5304@{#170}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Checks if DownloadMessageUiController is null in DownloadUtils.
This prevents calling isDownloadInterstitialItem on a null object.
(cherry picked from commit c18bd39016b977aead3d7ccc04984a05a6986d67)
Bug: 1367283
Change-Id: I89166b70541fb32e0d7a01ce9f3fc5d981614b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916010
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Alex Mitra <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050691}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913936
Commit-Queue: Shakti Sahu <[email protected]>
Auto-Submit: Alex Mitra <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#169}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "[site data] Display partitioned site state"
This reverts commit 20109ef19955dfa7b0eb1f0bc025c33874a8b0e7.
Reason for revert: Modified tests causing failures crbug.com/1364372
Original change's description:
> [site data] Display partitioned site state
>
> If the site has accessed only partitioned cookies, mark it as "Only accessing partitioned storage" (strings will be updated separately).
>
> To get the effective setting for partitioned access, get the content
> setting from the HostContentSettingMap instead of CookieSettings because
> partitioned access isn't affected by 3PC blocking.
>
> If there both partitioned and unpartitioned cookies:
> * if both are allowed, the state is "Allowed"
> * if both are blocked, the state is "Blocked"
> * if partitioned cookies are allowed (or session only) and regular cookies are blocked (because of 3PC blocking), display as "Only accessing partitioned storage". Only one entry is shown per host.
>
> Bug: 1344787
> Change-Id: I06ad711a3437e6dae7b91c7a4a1f085d8f159141
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891290
> Commit-Queue: Olesia Marukhno <[email protected]>
> Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047489}
(cherry picked from commit 1c509096fb477c181d610dd9096f1b907ae05939)
Bug: 1344787
Change-Id: Ia03ba6e54c339ca60685071cebecef5d5a6120fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901551
Owners-Override: Darren Shen <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Darren Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047757}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3918451
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Auto-Submit: Olesia Marukhno <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#168}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[UPM] Migrate password settings when UPM prefs change on reenrollment.
PasswordManagerSettingsService handles the migration of password
settings into GMS Core for users enrolled into UPM on startup.
If the user is reenrolled into UPM, settings might need to be migrated
in the middle of the browsing session.
(cherry picked from commit ab645fc03030ff8030e4e8b62f8d44c6eb3dde4a)
Bug: 1366436
Change-Id: I90a627ed1d4847256f4e945f34bf9e6e282eab8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913144
Reviewed-by: Ioana Pandele <[email protected]>
Commit-Queue: Maria Kazinova <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050363}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913215
Cr-Commit-Position: refs/branch-heads/5304@{#167}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Update LKGR ref to actual hash
Needed for the branch autoroller to find anything.
LKGR should match hash: https://chromium.googlesource.com/v8/v8/+/refs/heads/10.7-lkgr
Bug: 1341211
Change-Id: Ia0abdfb94ed8957e8aa80d978c717403d9b06328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905154
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#166}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Replace origin check with secure-context check in AttributionHost
The existing browser-side check does not match the renderer's check, so,
for example, a secure attribution-registration from a sandboxed iframe
would have been propagated from the renderer to the browser-side
AttributionHost, but there the sandbox would have caused its origin to
be opaque, which would trigger a bad Mojo message due to the failed
network::IsOriginPotentiallyTrustworthy call.
Instead, we change the AttributionHost to explicitly check that the
window has a secure context, preventing crashes in this case.
(cherry picked from commit ee8f4b7ccdfa40fcbcf0ee45866ead84eacc5d2b)
Bug: 1366513
Change-Id: I43f3409ff44397ed462ec2f1215aad7bfcda77af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913725
Commit-Queue: Andrew Paseltiner <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050597}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915497
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Andrew Paseltiner <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#165}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][Android][UPM] Reenroll evicted UPM users based on finch param
This CL allows evicted UPM users to be re-enrolled to the experiment
based on `api_error_list_version` parameter of the
UnifiedPasswordManagerAndroid Finch feature.
Users will save the current value on eviction and will be re-enrolled to
the experiment once the parameter is updated and is greater than the
currently saved value.
This will also result in re-enrolling of all currently evicted users
once the parameter is set to any positive value.
(cherry picked from commit fa3b54b3df31ec48dda7ae64b49e514cdc53f6f1)
Bug: 1362464,1367285
Change-Id: Ibbab40de6cc20494a4d27e42380567779ecdb2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3898955
Commit-Queue: Maxim Anufriev <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050090}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913339
Auto-Submit: Maxim Anufriev <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#164}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Updating XTBs based on .GRDs from branch 5304
Change-Id: Ide0264c7f32ce2ef3139e24f6a9bc67c997bce05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915080
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#163}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[CP-M107] Disable WebRtcMetronome feature by default
(cherry picked from commit 7923824cd419d96859b143f61d5799f21a5efd35)
Bug: 1365817
Change-Id: I19db7d5978c37b840de6cc78a267fbddc0d7c580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904546
Auto-Submit: Evan Shrubsole <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Commit-Queue: Evan Shrubsole <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049088}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914691
Cr-Commit-Position: refs/branch-heads/5304@{#162}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][Signin] Change padding for message container in sync confirmation
This CL reduces the padding size for the message container in the Signin
Intercept version of the Sync Confirmation dialog to avoid displaying
an extra line for the English version on MacOS.
(cherry picked from commit 879588ce3c0ec4e1728141288e8ea50c6f0f45f0)
Bug: 1366784
Change-Id: I9fe8f11d0e4436ddbc9c27631df9856d485cbf4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907596
Commit-Queue: Gabriel Oliveira <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050244}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913212
Auto-Submit: Gabriel Oliveira <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#161}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[UPM][UPMErrorUI] Trigger showing the error message UI
In FormFetcherImpl, the implementation is moved from
OnGetPasswordStoreResultsFrom to OnGetPasswordStoreResultsOrErrorFrom
to allow storing the error from the backend if it happens.
FormFetcherImpl stores the last backend error that happened and resets
it when it's addressed by a consumer.
PasswordFormManager checks in OnFetchCompleted if there was a backend
error stored in the FormFetcher and checks the error type. If the error was AuthErrorResolvable it can be resolved by signing in again so the
error message is shown by the ChromePasswordManagerClient. The message offers signing in again.
ChromePasswordManagerClient has a new method that shows the error
message via PasswordManagerErrorMessageDelegate that it owns.
(cherry picked from commit 758ec36e96540e90add1433a3ea9f4f7750a16a1)
Bug: 1352415, 1364161
Change-Id: I5b373e194e4f59912678ad5a12dcc062fdae252b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891058
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Ivana Žužić <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050075}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913589
Cr-Commit-Position: refs/branch-heads/5304@{#160}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][Android][UPM] Extract utils related to the UPM users eviction
This CL extracts the logic of UPM user evictions before introducing
ignorable/retriable error lists and evictions versioning.
(cherry picked from commit db1d20faf6b5fc44ad91f63d5e14c1d734c14e44)
Bug: 1362464,1367203
Change-Id: Iede1a112d708d5288678244f1eda3ed62d988a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3890926
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Maxim Anufriev <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049560}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914699
Commit-Queue: Vasilii Sukhanov <[email protected]>
Auto-Submit: Maxim Anufriev <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#159}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Match button styles and progress bar with dynamic colors
This is a cherry pick of https://crrev.com/c/3896816 for Chrome M107.
Bug: b/243731658
Bug: 1367218
(cherry picked from commit 9bed0437a9b6a2e0828857ac499469cba423f13a)
Change-Id: I64e8a75862c2553cc36b13bab47e74e868d01869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3896816
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Sergio Vila Prado <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050054}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913332
Reviewed-by: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#158}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107 Merge] Integrate decline details parsing with autofill error dialog
This CL integrates the parsing of the merchant opt out error dialog
fields in an unmask card response with the virtual card error dialog
functionality. It also adds testing for this integrated functionality.
This CL also adds metrics logging for the merchant opt out error dialog scenario.
(cherry picked from commit 37600a30bac0532b78a93fdf7419dfef98e68d28)
Bug: 1366040
Change-Id: I1d3f9776c4bf0d6bcd133b53fd8669042316e479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3844570
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048930}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914113
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#157}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Merge "FrameSet NG: Fix a crash on re-showing a sub FRAMESET" to M107 branch
We clear NeedsLayout flags of FRAMESET children which are not fit in
the FRAMESET's grid. We should clear their NGPhysicalFragments too in
order not to re-use stale fragment trees when a child fits in the grid
again.
(cherry picked from commit dd9689e6529ac35eef0f7dd9a942eff2b99e01b6)
Bug: 1365048
Change-Id: I638f68eba61d557b1aede9d4f686998f0c774d60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904719
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049471}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917531
Commit-Queue: Kent Tamura <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#156}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.14
Change-Id: I354149c91359fbfea319c55b6a1bd9427593b4ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917225
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#155}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Observe AppState in StartSurfaceSceneAgent
Since the AppState initStage's and SceneState activationLevel's launch
progress are independent of each other, there can be situations where
the activationLevel has reached the desired state before initStage.
This is now the case for most cold starts. StartSurfaceSceneAgent
identifies this situations through
waitingForAppStateAfterSceneStateReady and waits for the initStage
to transition to a >= InitStageFirstRun state before checking again
if the Start Surface should be shown.
(cherry picked from commit a95e63289522b4168cfb8c3a2291a6da6301fd06)
Bug: 1366573, 1323001
Change-Id: I262bdc4df1d6c261072549abecee7a5d4186529b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911882
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050206}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915621
Commit-Queue: Mark Cogan <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#154}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107 merge] Passwords: Focus view page fields with an outline for inputs / textarea
Before: http://screen/75H5jqRNZRBc5NY
After: http://screen/5xUj3f3iA4r52zJ
(cherry picked from commit f30b8eae7e8ac1c69801e70ee98d7542498183e4)
Bug: 1363507
Change-Id: I581adf1caf23b242bab5405f645f764bf9410b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895591
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Adem Derinel <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049993}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916444
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#153}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Journeys] Fix crash when initing with null activity
This seems to happen if we create the coordinator post-destroy.
(cherry picked from commit 80d1a6af8f978746466823d9cb275c848972cab1)
Bug: 1366905
Change-Id: Icfdeb9219c59b6620ee3f8ec29727983c4f4b043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915271
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050651}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917011
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#152}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[skylab_tests] Update skylab tests cros img version
This cl only affect Lacros on-device config builders like
lacros-amd64-generic-chrome-skylab. This cl will certainly NOT affect
linux-lacros builders(linux-lacros-tester-rel, linux-lacros-rel, etc)
or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Requires-Testing: True
Change-Id: I880445624bf13f9417d3932805be085253a17371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914748
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#151}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.13
Change-Id: Idb14b5b0232f47b9358b97ec6c0ec70bf8fb390f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915132
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#150}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
M107: Fix PDFiumRange's handling of FPDFText_GetText() results.
Use FPDFText_GetText()'s returned count as the source of truth for how
many characters are in the output string, instead of trusting this count
is consistent with the FPDFText_CountChars() return value. In some
cases, they are not the same.
(cherry picked from commit 161d189731d251f4e40c2fb32e13ceb05d897bc3)
Bug: 1357385
Change-Id: I355a573c036e15f96972901cd562e3bcee1be74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908491
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050686}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916801
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#149}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Add page action metric for % of pages with actions
(cherry picked from commit 793f93b31b50e24c349c06ceda6ded68f4968571)
Bug: 1351945
Change-Id: Ic1c85d2b5fcaa1f9b20f6e6fb03e43bcfe8ae287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907956
Reviewed-by: Peter Boström <[email protected]>
Auto-Submit: Emily Shack <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Commit-Queue: Emily Shack <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049769}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915915
Cr-Commit-Position: refs/branch-heads/5304@{#148}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Updating XTBs based on .GRDs from branch 5304
Change-Id: I2932b16c19abb4a35ceefea54ef9c7970fbbd4e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915250
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#147}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] wayland: fix RunMoveLoop return when ext-drag is unavailable
When extended-drag extension is unavailable, the only reliable way to
detect the "drop" event regardless where it has happened (ie: even when
it happens outside shell surfaces) is the wl_data_source.cancelled
event. In that case, WaylandWindowDragController.Drag must return true
always, otherwise Chrome's TabDragController will try to "revert" the
drag operation, which moves detached tabs back to their source window,
etc. Revert was (indirectly) causing crashes on Gnome Shell, more
specifically when xdg-activation request is done.
That is a regression introduced in https://crrev.com/c/3384536 and this
CL fixes it as well as adds unit tests to prevent future similar
regressions.
R=[email protected]
(cherry picked from commit 9239118d6688e7f24baeabcc2b3713aa00ecdb31)
Bug: 1366504
Test: Covered by ozone_unittests and tested manually.
Change-Id: Ie86da41d1e329275943a572a87697f8ab0ea4318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913256
Auto-Submit: Nick Yamane <[email protected]>
Reviewed-by: Alexander Dunaev <[email protected]>
Commit-Queue: Nick Yamane <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050548}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916136
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#146}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] wayland: bypass xdg-activation calls during dnd sessions
Gnome Shell xdg-activation implementation seems still buggy/unstable and
crashes were observed in Chrome's tab dragging. More specifically when
dragging a tab out and dropping it outside of any toplevel surface (eg:
on the desktop area), which is addressed in https://crrev.com/c/3913256
Besides that, more crashes were observed when, for example, on
repeatedly drags a tab in and out of its source window. Such crashes
usually bring the whole desktop session down. In order to overcome these
issues, this patches WaylandWindow::Activate to no-op while in
drag-and-drop sessions.
R=[email protected]
(cherry picked from commit c2f09f95f148c0ac72bd87d55ac43fb2edc78eaf)
Bug: 1366504
Test: Tested manually by repeatedly dragging Chrome tabs in and out.
Change-Id: I66fa0570c86ad666ee6ea35bd4146115bc45511c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914262
Commit-Queue: Alexander Dunaev <[email protected]>
Commit-Queue: Nick Yamane <[email protected]>
Auto-Submit: Nick Yamane <[email protected]>
Reviewed-by: Alexander Dunaev <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050544}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917151
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#145}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
OzoneBacking::ProduceSkia - Create GLTexturePassthroughRepresentation
When using OzoneBacking on ChromeOS with Angle passthrough command
decoder is used. In such cases, when creating a Skia representation,
we should check for passthrough usage and create a
GLTexturePassthroughRepresentation accordingly. This is useful when
the textures are cached on Arm Mali driver devices which use a special
workaround due to driver issues.
(cherry picked from commit 45b2fba7104cdf089fd56aa3656b130221cf741e)
Bug: 1364168, 1360661
Change-Id: If2fed9d5524749569df6a04627a20f763a40afea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899179
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Saifuddin Hitawala <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048000}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914080
Cr-Commit-Position: refs/branch-heads/5304@{#144}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] [RDSD] Record UserActions for RDS domain and subdomain settings
Merge to M107.
- DesktopSiteContentSetting.SettingsPage.Entered
User entered the SingleCategoryPreferences page for Desktop site. It is
emitted whenever this page is shown regardless how it is triggered.
- DesktopSiteContentSetting.SettingsPage.SiteException.Opened
User opened the site exception edit dialog by clicking on a site in the
SingleCategoryPreferences page for Desktop site.
(cherry picked from commit 6c83fb217fe3194e6ef6eb6e10cf27f4c1a88169)
Bug: 1365771
Change-Id: I347ebf7d366bf4c4d06a2965422a6c434227adff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910373
Commit-Queue: Shu Yang <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050220}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913962
Auto-Submit: Shu Yang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#143}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[skylab_tests] Update skylab tests cros img version
This cl only affect Lacros on-device config builders like
lacros-amd64-generic-chrome-skylab. This cl will certainly NOT affect
linux-lacros builders(linux-lacros-tester-rel, linux-lacros-rel, etc)
or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Requires-Testing: True
Change-Id: Ia1a081cb83a54f8e6cd0001c38ae14dc16a474c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914496
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#142}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.12
Change-Id: I1e1d6483298470636f845a4ad4aa69c7e8d3ec56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914648
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#141}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Follow] Update the follow menu option
Previously the follow overflow menu option only updated when the page
has been loaded, but some website never finish loading, which causes
the follow option is disabled all the time.
Now updating the follow menu option whenever the menu model is being
updated, so the menu option can be enabled much earlier.
Updated the old popup menu too.
No behaviour changes besides the menu option update timing.
Video after change:
http://shortn/_xlB19VKQ4j
http://shortn/_BHtyeTo0jC
(cherry picked from commit 2de4ed5fe5988086e255d125d5f7055735b54f8c)
Bug: 1365672
Change-Id: If9a5deb635db349bc8fa8015f6fce45bb79c740f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3897925
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Tina Wang <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049203}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915989
Cr-Commit-Position: refs/branch-heads/5304@{#140}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[remoting host][linux] Use XVFB when dependencies are not satisfied
The CRD debian package now has the following dependencies:
xserver-xorg-video-dummy (>= 1:0.4.0), xserver-xorg-input-void
These are not satisfiable in Debian stable (Debian 11 "bullseye"), as
only xserver-xorg-video-dummy 1:0.3.8-1 is available, and
xserver-xorg-input-void has bee removed.
This CL works around this issue by making these two dependencies
"Recommended", and updating the host daemon script so that it falls back
to XVFB if the dependencies are not satisfied.
(cherry picked from commit c7ec1c0b1022e53f92ea30a9cba719939ef12200)
Bug: 1366595
Change-Id: I0a8d6361e05bf7587ef713c0c780d346194694c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912622
Reviewed-by: Lambros Lambrou <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050413}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916837
Auto-Submit: Yuwei Huang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#139}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
TrustStoreMac::TrustImplDomainCacheFullCerts keychain notification fixes
1. Ensure that KeychainChangedNotifier::KeychainCallback doesn't get
code-folded. SecKeychainAddCallback is keyed on the function pointer
only, so if the code gets folded together by the optimizer, only one
of the notifications would actually be honored by MacOS, even if
each one had a different context pointer.
2. Fix issue with the 2nd part of MaybeInitializeCache checking
trust_iteration_ after it had already been updated, meaning that
condition would only update on the certs_iteration_ changing (which
can be never due to problem number 1.)
(cherry picked from commit 92821e8d15077fe681c70a5b38a807cbdef3aaa4)
Fixed: 1365702
Change-Id: Ic59a3709e73dfeecc598086d5429f795a8698e28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911781
Commit-Queue: Matt Mueller <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050231}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913982
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#138}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[remoting] Make capabilities explicit for Linux and Me2Me.
This makes the multi-stream and client-controlled-layout capabilities
enabled only for Linux and for Me2Me. Previously, they were set for
It2Me, and multi-stream was also enabled for MacOS, which is
not well tested.
Change-Id: I1ef3390f22aa5f31cf8e54c1e3db87ee79ab2bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907701
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1049761}
(cherry picked from commit fc279d8996a71d4ff5aefaf6c44ef401f0b6d49b)
Bug: 1366595
Change-Id: I1ef3390f22aa5f31cf8e54c1e3db87ee79ab2bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914101
Auto-Submit: Yuwei Huang <[email protected]>
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Commit-Queue: Joe Downing <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#137}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[107][PriceTracking] Set up bubble button handlers
This CL adds two button handlers: Track price and untrack, both action
should update the PriceTrackingIconView immediately to reflect the
state. Because of the underlying updating mechanism, a server round
trip is needed to update the state correctly. To maintain a
synchronized UI, a |force_mode| is added to force update the PriceTrackingIconView immediately. If an error comes back from the
server, then we can update PriceTrackingIconView to reflect the error,
otherwise the UI is already in the correct state.
This CL also adds a PriceTrackingIconView clicking behavior. After
FUE, clicking the PriceTrackingIconView will auto enable the price
track for that page.
Demo for updating icon view by clicking the buttons: https://screencast.googleplex.com/cast/NDkwOTkzMjI5NDk2MzIwMHwzYTI2MDExYy01Yg
(cherry picked from commit dd2d3275238b1cda2eb4c988ed6fad8ef78624fa)
Bug: 1346612
Change-Id: I01e58063f31a38a7eecf608a2c416e068a950c8c
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3896777
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Emily Shack <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049408}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912175
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#136}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Merge to 107][RDSG] Add client-side logic for experiment setup - opt-in arm
This is a follow-up to crrev.com/c/3894207, to support additional GWS tracking for the REQUEST_DESKTOP_SITE_DEFAULTS experiment, specifically for the opt-in experiment arm. Design included in referenced bug.
(cherry picked from commit 669cf4fc27b9e3530f29969339339b2a4b83b46a)
Bug: 1362914
Change-Id: I14be30880910aa092823eac1ac3b85b33444ca89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894904
Reviewed-by: Shu Yang <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049334}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915945
Cr-Commit-Position: refs/branch-heads/5304@{#135}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Merge to M107: TrustStoreMac::TrustImplDomainCacheFullCerts: cache intermediates too
(cherry picked from commit 394c6504fce121e0af8645848232b3dfcb37885f)
Fixed: 1365702
Change-Id: I2ec57978ea72541dcf733f504072a242ca2e6983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902120
Commit-Queue: Matt Mueller <[email protected]>
Reviewed-by: David Schinazi <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049501}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915919
Auto-Submit: Matt Mueller <[email protected]>
Commit-Queue: David Schinazi <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#134}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Merge M107] Add feature to use mmap for language detection models on posix
While looking at some heap dumps, I saw the tflite model for language
detection was taking ~400kb per renderer on Android. This CL switches
from reading the file into a std::string to using mmap for the model
file, and will hopefully save memory. This change is behind a
base::Feature so we can measure using Finch.
This rolls the third_party/tflite_support lib and removes one of the
chromium specific patches that removed the mmap code now that the
upstream version builds on windows.
(cherry picked from commit 8fc06d052176e160f2a3a7a1cb1c78c69f435bd4)
Bug: 1366096
Change-Id: I07ef0edd6974133bef905dbf83d52f170fe292c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907043
Reviewed-by: Josh Simmons <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049926}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916681
Auto-Submit: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#133}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Cherry-Pick] Add UseCounter for Data URL in SVG use element
Measure usage of Data URL in SVG use element for potential deprecation.
(cherry picked from commit 711bf0c7fda3e7e925bfa9b15d7af9a6a04fb211)
Bug: 1300195
Change-Id: I5d7639f986e9f5b40c74d6bbc6470d61e72e4f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908236
Reviewed-by: Fredrik Söderquist <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Jun Kokatsu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049668}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914351
Cr-Commit-Position: refs/branch-heads/5304@{#132}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Fix Aura Aliasing on Linux Wayland
Both the PipeWire capturer and the Ozone/Wayland window manager assign
IDs with monotonically increasing ints. This causes collisions where
we think an item from the PipeWire capturer corresponds to a Chrome
window when it does not. The documentation for DesktopCapturer states
that we shouldn't really trust this ID anyway, so for now don't assume
that the SourceID of an item from a delegated source list (currently
this is only PipeWire) can be looked up reliably.
This is now the second bug of this type, and the ifdef is fairly
complicated. A proper fix would probably require some significant design
work and potentially be a fairly large change. This also adds a TODO
calling out that this should be re-worked in a more broad fashion, but
in the meantime this fix is still needed in the short term.
(cherry picked from commit 512cfa719ae55a242ab31e45398d2da8b454649c)
Fixed: 1366575
Change-Id: Ic890cfdeeaab4f0ee7be6d9143f4d6dc6bc2faef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911719
Reviewed-by: Elad Alon <[email protected]>
Commit-Queue: Alexander Cooper <[email protected]>
Auto-Submit: Alexander Cooper <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050261}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916597
Commit-Queue: Elad Alon <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#131}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Remove android-pie-arm64-rel from the CQ temporarily
android-pie-arm64-rel has many failed builds due to IAD BOT_DIEDS for its test capacity
Bug: 1367475
Change-Id: I860816ef51dc4e1d91efebd1570b57b26d244a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916685
Auto-Submit: Stephanie Kim <[email protected]>
Reviewed-by: Erik Staab <[email protected]>
Commit-Queue: Erik Staab <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#130}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Fix truncated Trending Queries title
Trending Queries will always have a title in its module, so the title
height must always be accounted for.
(cherry picked from commit 5c0a63ea5a61552d9282d75c89d8026efa0bc5cf)
Fixed: 1366458
Change-Id: I2a5ac8be1db9ccfb909b5191ab8120e982def3f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911196
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049819}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915370
Cr-Commit-Position: refs/branch-heads/5304@{#129}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Reland "Separate NOTREACHEDs from DCHECKs"
This reverts commit 09933c90667116663a60a9f21211dac933ba55b8.
The original change got reverted because some builders saw
DCheckDumpOnceWithoutCrashing as dead code. This moves that function to
the #if block where it's called from.
Original change's description:
> Revert "Separate NOTREACHEDs from DCHECKs"
>
> This reverts commit 33f259736a6fef9a3bfd80a597a7a5d64a397832.
>
> Reason for revert: Causing tree closure on Linux ChromiumOS ASAN. See https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/39945/overview for more info.
>
> Original change's description:
> > Separate NOTREACHEDs from DCHECKs
> >
> > This logs Logging-NOTREACHED_MESSAGE for NOTREACHED()s so that they can
> > be distinguished from DCHECKs (as [NOTREACHED]) in error reporting.
> >
> > This is especially important on ChromeOS where NOTREACHED()s are not
> > optimized out but rather currently generating [DCHECK] report signatures
> > even outside of DCHECK builds, which makes it seem like there exists a
> > DCHECK-enabled stable build.
> >
> > Bug: 1363300
> > Change-Id: I6fad386e2cf6c68496530009b07b86b3b148816e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894490
> > Reviewed-by: Daniel Cheng <[email protected]>
> > Commit-Queue: Peter Boström <[email protected]>
> > Auto-Submit: Peter Boström <[email protected]>
> > Commit-Queue: Daniel Cheng <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1047150}
>
> Bug: 1363300
> Change-Id: I2bd39b0ad4432f562c32533504337239e74dd556
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3896578
> Auto-Submit: Dibyajyoti Pal <[email protected]>
> Commit-Queue: Dibyajyoti Pal <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Owners-Override: Dibyajyoti Pal <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047158}
(cherry picked from commit 431512de16ff0d084fb13cd45728ed4aa2ac6950)
Bug: 1363300
No-Try: true
Change-Id: I2d847ac259e53dd0632deebcb91e1a53ea3a3f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900359
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047755}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913858
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#128}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "Add DumpWithoutCrashing if OzoneImageBacking::BeginAccess fails"
This reverts commit a51037b34d6e42752afe25a1830912a479ed0dd2.
Reason for revert: Enough dump information received to debug crbug.com/1364756
Original change's description:
> Add DumpWithoutCrashing if OzoneImageBacking::BeginAccess fails
>
> Recent change to OzoneImageBacking [1] may have triggered context
> lost issue due to an early return. This change adds a
> DumpWithoutCrashing instead to see if there are clients causing
> context losses and fix them.
>
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/3876745
>
> Bug: 1363435, b/243039477
> Change-Id: I375e233a0fe605634c1133ee9e7c3058b9d9f26e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3893345
> Reviewed-by: Vasiliy Telezhnikov <[email protected]>
> Commit-Queue: Saifuddin Hitawala <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047555}
(cherry picked from commit 3665893627e35f7e66742f81c06733a5254c2a25)
Bug: 1363435, b/243039477, 1364756
Change-Id: Ifd6cb3fad4321037572102dedb2ed1670702b88f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914926
Commit-Queue: Saifuddin Hitawala <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050377}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914587
Cr-Commit-Position: refs/branch-heads/5304@{#127}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Fix scroll position when dismissing feed promo
(cherry picked from commit 5cb73271c65b22e66588556fcd6ee3a3a7660561)
Fixed: 1363603
Change-Id: I07daea9b15f5dbeb4ac2279f56bad12c6d23095b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908434
Commit-Queue: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049696}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914674
Auto-Submit: Adam Arcaro <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#126}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "media: Update WidevineKeySystemInfo to support experiment key system"
This reverts commit 3dcdea9f425c993742de3de0ddc3ffc7b6a5c402.
Reason for revert: Causing test failure in Linux
Original change's description:
> media: Update WidevineKeySystemInfo to support experiment key system
>
> This CL adds to the WidevineKeySystemInfo an experimental boolean
> and the codecs that support clear lead. This is to instantiate a new
> experimental key system alongside the normal key system in chrome.
> Through this, we are now able to store and return different sets of
> codecs when querying for hardware secure codecs, as the experimental
> key system will return all hardware secure codecs and the normal key
> system will return all clear lead supported hardware secure codecs.
>
> Bug: b/241047837
> Change-Id: I2021f2995eb3a04c6acf44b04a623f5a3f834b5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820526
> Commit-Queue: Vikram Pasupathy <[email protected]>
> Reviewed-by: Xiaohan Wang <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1046533}
(cherry picked from commit b56fe5cd142043c3cbbeadbe0047f74383f986d4)
Bug: b/241047837, 1363573
Change-Id: Ib3ac7042656e04a432b2b2034efc0a5b3987d15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909772
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Commit-Queue: Vikram Pasupathy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914906
Cr-Commit-Position: refs/branch-heads/5304@{#125}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Add basic page actions metrics
Includes metrics for number of actions shown at once, type of action
shown, and CTR for each action type as well as overall.
(cherry picked from commit ef27735d7896167a7152b6de5ac34dc263415020)
Bug: 1351945
Change-Id: I76b5c1591a47af67c015ea6d7939221f7cd6d555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892460
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Emily Shack <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049394}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915272
Auto-Submit: Emily Shack <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#124}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
M107: Avoid passing negative indices to PDFiumEngine::ExtendSelection().
Passing negative indices to PDFiumEngine::ExtendSelection() results in
miscalculated selection ranges. Add DCHECKs to ExtendSelection() as
pre-conditions. Change OnMouseMove(), the caller, to not pass in
negative indices. Also add a test case to trigger this code path.
(cherry picked from commit bda58f210f45445367eb4b089062fc2d647a5075)
Bug: 1362279
Change-Id: Ib5813464b3b448d40dbf44eb93257b966506eb2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905511
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049325}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913994
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#123}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Check NTPHelper before accessing in NTPCoordinator
(cherry picked from commit e7d54276e926cfe5c81d6c8668b1947d06747e72)
Bug: 1328015
Change-Id: If9d075b3d8417520b15238422ac852e355c45ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909831
Commit-Queue: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049780}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914614
Auto-Submit: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#122}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[107][PriceTracking] Add price tracking bubble
This CL adds the price tracking bubble. Clicking the price tracking
action chip shows one version of this bubble depending on the first user
experimence status.
Follow up CLs will add button handlers to this bubble as well as the
side image.
LOW_COVERAGE_REASON= Uncovered lines are covered by new tests added in
crrev.com/c/3896777
(cherry picked from commit 96bbcc2f879bfc106162b625901a5d6286a4297b)
Bug: 1346612
Change-Id: I159f8f9fbf904a1ae43d12e5c612dca83532d630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895581
Reviewed-by: Elaine Chien <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Emily Shack <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049314}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914112
Auto-Submit: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#121}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Merge to M107: Ensure that an error code is added if VerifySignatureAlgorithmsMatch fails.
(cherry picked from commit 7686a60b556e11820248427ed9216b4a02327011)
Bug: 1366521
Change-Id: I4e24f1528045d3f2c53e22a72f81254a3cf77ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911348
Reviewed-by: Nick Harper <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050033}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915280
Commit-Queue: Nick Harper <[email protected]>
Auto-Submit: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#120}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
AboutThisSite: Ensure compatibility of different feature states
There are multiple AboutThisSite features that have dependencies on
each other and on the UnifiedSidePanel feature. Add helper methods
that check for each feature if all dependencies are enabled as well to
avoid bringing Chrome in an unstable state through unsupported feature
configurations.
(cherry picked from commit a0b16c187e6cbd40208a313bbd6eeced59eb60c4)
Bug: 1365847
Change-Id: I1c13f784e5b53b09013aa64325dcb7de972fb2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909588
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050107}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913509
Cr-Commit-Position: refs/branch-heads/5304@{#119}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Add SupportsDisableMsaa metric
To switch tile raster to DMSAA we need to make sure that we use
analytical AA when we want no AA at all. This should always be the case
when GL_EXT_multisample_compatibility is supported, which should affect
only linux.
To make sure it's the case this CL adds a metric.
(cherry picked from commit dfc22a4069598219bdb5321296e1856b4195843a)
Bug: 1366394
Change-Id: I7a66bceea01894dc108ef8411cb3f927e75ca71e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907882
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050003}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913259
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#118}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Safety check: Fix use-after-free in UnusedPermissionService
Ensure that GetUnusedPermissionsMap does not access any shared state
when it is running on a background thread by passing in dependencies
directly and turning it into a simple function.
(cherry picked from commit d69947e4db8d214b02eb5541a52594830288e854)
Bug: 1364492
Change-Id: I186ab7372c85b3c0291aef4dc650be80c66860b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904906
Reviewed-by: Side YILMAZ <[email protected]>
Reviewed-by: Illia Klimov <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Reviewed-by: Illia Klimov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049706}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909400
Cr-Commit-Position: refs/branch-heads/5304@{#117}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Shopping list] Add policy for enterprise
NOTE: This patch doesn't include the actual policy pieces for 107 --
we'll experiment without one and a new policy using enums will be
introduced in 108. This patch only keeps the changes required to
unblock other merges for the shopping list experiment.
The policy is not yet used, but will be in followup patches. This also
includes a move of the preference registration out of ShoppingService.
The default state of the setting is |true|, allowing the feature
to be enabled.
(cherry picked from commit 704e1a667a320d15760eaf75f04390b0bb917750)
Bug: 1363214
Change-Id: I083675e255abda2b693a79ca3377f7427f5fdf7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892144
Reviewed-by: Igor <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049148}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907935
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#116}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Adds null checks to DownloadMessageUiControllerImpl.
This is to prevent reading from a null hash set.
(cherry picked from commit 136366fab985d08b92c53921e55b76072b2f7b40)
Bug: 1363341
Change-Id: I43a960971fbbfe92a93c652b37cbb0262dedd770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907724
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Alex Mitra <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1050128}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913029
Cr-Commit-Position: refs/branch-heads/5304@{#115}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Skip Incognito interstitial when using Voice/QR Code/Normal search
This CL explicitly sets the default application mode to `NORMAL` for:
- Siri Shortcut "Search in Chrome"
- Siri Shortcut "Open in Chrome"
- Shortcut "New Search"
- Shortcut "Voice Search"
- Shortcut "QR Scanner"
- Spotlight action "Voice Search"
- Spotlight action "QR Scanner"
- Spotlight action "New Tab"
- WidgetKit action "Game"
- WidgetKit action "Search"
- WidgetKit action "Voice Search"
- WidgetKit action "QR Scanner"
Also now the application mode in a set of startup parameters always
needs to be set directly (no more `launchInIncognito` property)
and explicitly (no default value).
Context:
The default application mode for external intents used to be
`ApplicationModeForTabOpening::NORMAL`, and `launchInIncognito` was set
to `YES` explicitly when needed e.g. for the Incognito Search Shortcut.
Since introduction of the Incognito interstitial, the new default
application mode has been `ApplicationModeForTabOpening::UNDETERMINED`.
Code which instantiated `AppStartupParameters` objects can no longer
assume that the application mode is already set to `NORMAL`, so it needs
to be set explicitly.
(cherry picked from commit 4b9437b0dfc2b02e0ca464666c85de404f90b27a)
Bug: 1364057
Change-Id: I4307449e6b3c04efe1b39aa2a432f0c9e55fca1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3898957
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Quentin Pubert <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049681}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915173
Auto-Submit: Quentin Pubert <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#114}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] [RDSD] Add metrics for RDS domain and subdomain settings
Merge to M107.
Records when a user manually adds a domain/subdomain level Request
Desktop Setting from the Add site dialog in Site settings:
- Android.RequestDesktopSite.UserSwitchToDesktop.DomainSettingAdded
- Android.RequestDesktopSite.UserSwitchToDesktop.SubDomainSettingAdded
Records when a user manually edits a domain/subdomain level Request
Desktop Setting from the site settings exception list:
- Android.RequestDesktopSite.DomainSettingChanged
- Android.RequestDesktopSite.SubDomainSettingChanged
(cherry picked from commit 3df4c66d445eef587fc2cb347e2b5eb3118aa69a)
Bug: 1365768
Change-Id: I6653c0382577c1058a027200dce9ce776a51f307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905297
Commit-Queue: Shu Yang <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049748}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915144
Auto-Submit: Shu Yang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#113}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Revert "Implementation and tests for SevenZipReader"
This reverts commit bbe4eae196e5536f40d946f5eeae0a4179275f57.
Reason for revert: Tests are failing https://crbug.com/1364541
Original change's description:
> Implementation and tests for SevenZipReader
>
> This CL adds implementation and tests for the SevenZipReader. Adding a
> new test target adds significant linking costs on all the builders, so
> tests are located in //third_party/lzma_sdk, but run as part of //chrome/test:unit_tests
>
> Implementation is heavily based on
> //chrome/installer/util/lzma_util.cc, but this code should run behind
> a feature flag, so we need both copies in the short term.
>
> Bug: 1355567
> Change-Id: Id1a66bc2ad122d8b475fad0c616df6d1ffdee532
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3888221
> Reviewed-by: thefrog <[email protected]>
> Reviewed-by: John Chen <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Commit-Queue: Daniel Rubery <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047629}
(cherry picked from commit fe4f3f2b4de037b8691d1771cdca7262dc4edbb2)
Bug: 1355567, 1364541
Change-Id: Ic6462548144eb17426c5fc69ca21ca21d16e76b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899799
Reviewed-by: John Chen <[email protected]>
Auto-Submit: Hazem Ashmawy <[email protected]>
Commit-Queue: Hazem Ashmawy <[email protected]>
Reviewed-by: thefrog <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Owners-Override: Hazem Ashmawy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048037}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914866
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#112}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Disable SupervisedUserServiceTest.DeprecatedFilterPolicy
Failing consistently since
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/30117/overview
(but unable to reproduce locally, and no obvious culprit)
(cherry picked from commit 3e5134ede47392e2ed4efc1fa9dd4188274dc3d2)
Bug: 1364589
Change-Id: Ia18d1f46f52ce31f69a595491a9ad6db145524a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902185
Auto-Submit: Morten Stenshorne <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Owners-Override: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047979}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914708
Owners-Override: Joe Downing <[email protected]>
Auto-Submit: Joe Downing <[email protected]>
Reviewed-by: James Lee <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: James Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#111}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Add three metrics for side search menu entrypoint
Metric 1: SidePanelOpenTrigger.ContextMenuSearchOption, records how many clients open side panel from menu option.
Metric 2: SideSearch.NavigationCommittedWithinSideSearchCountPerJourneyFromMenuOption
Metric 3: SideSearch.RedirectionToTabCountPerJourneyFromMenuOption
Bug: 1357849
Change-Id: I9023c6e311d9788e60df7c9de11d1ccd4d21943c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906721
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Auto-Submit: pengchao Cai <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: pengchao Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#110}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Return Early if Start is already configured
This new check will ensure multiple calls to
-configureStartSurfaceIfNeeded aren't executed, creating
multiple Return To Recent Tab tiles.
(cherry picked from commit 698931073b4bcb2a96cdbd218cd194fdfd34c822)
Bug: 1366560
Change-Id: I25fb9f0c1d6b1b8e15afd0b85f5d539e3772ba89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911758
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049952}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915445
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#109}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[skylab_tests] Update skylab tests cros img version
This cl only affect Lacros on-device config builders like
lacros-amd64-generic-chrome-skylab. This cl will certainly NOT affect
linux-lacros builders(linux-lacros-tester-rel, linux-lacros-rel, etc)
or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Requires-Testing: True
Change-Id: Ic1e4cb01bea35a89f6479e1fe787b7b0cfa80b1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914590
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#108}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.11
Change-Id: Ifd063ff14d06c5ce547be41b9c54622a39b411cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915484
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#107}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[remoting host][linux] Workaround GNOME display resizing bug
Currently if we add a new mode to a "disconnected" randr output on
GNOME, it somehow resizes all existing displays to 1024x768. This CL
provides a workaround for this bug by connecting 3 dummy outputs (the
client currently supports up to 4) using xrandr then disconnecting them
when GNOME is launched. It won't work for session chooser but it's good
enough for general usage.
(cherry picked from commit c4abadd8c74c5237404db6ba11f6c5c4d8d75f26)
Bug: 1366057
Change-Id: I1f5494ea0c62fe354a1186619112a290f131102d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908246
Commit-Queue: Yuwei Huang <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049924}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914114
Auto-Submit: Yuwei Huang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#106}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
(merge) gpu: win: Fix bug where Media Foundation videos would mostly show as black
This fixes a bug introduced in the following change:
https://chromium-review.googlesource.com/c/chromium/src/+/3823501
The change caused `content_.Reset()` to be called unconditionally in
`PresentDCOMPSurface`. This CL now moves the call of `content_.Reset()`
to only where it's needed.
(cherry picked from commit e94d7d56efc4faf2e455d81718c56018dbb3030b)
Bug: 1366597
Change-Id: I7f26ca9618dca16a230e000e7e49be8783cf37b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902514
Commit-Queue: Michael Tang <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048284}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914628
Commit-Queue: Xiaohan Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#105}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Subscriptions] Fix serialization error
To make the subscription (de)serialization succeeds, we need to pass
strings instead of enum int for all types.
This CL also corrects the bookmark observer we use. We should verify
whether a local subscription exists when bookmark meta info changes
instead of when bookmark node changes.
(cherry picked from commit a95840076e6b7da1cd433d87b546a06265e438b0)
Bug: 1365759, 1362935
Change-Id: I2087f426cf07a46ae5a9f87848f38f34f1ef4c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907101
Reviewed-by: Ayman Almadhoun <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Zhiyuan Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049829}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914334
Auto-Submit: Zhiyuan Cai <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#104}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "[Start] Hide the current tab when overview page is showing."
This reverts commit a8c9cfc644837fdc9ea351e17512f410aadee359.
Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/3905705/comment/d3abd328_85b850d9/
Original change's description:
> [Start] Hide the current tab when overview page is showing.
>
> In this CL, when the Start surface or Tab switcher start showing, the current active Tab is hidden. This allows native side gets the correct visibility of WebContent.
>
> Videos:
> https://drive.google.com/drive/folders/1k2cr5paggE2T-EmlrgFRuEfIVaTZvd5r?resourcekey=0-WGlWwk4vb2P4_eqKH7r3UQ&usp=sharing
>
>
> Bug: 1346353
> Change-Id: Iea96397ae5cd8ba4cc38fa27afd613451f769f0c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836417
> Reviewed-by: Xi Han <[email protected]>
> Reviewed-by: Lijin Shen <[email protected]>
> Reviewed-by: Theresa Sullivan <[email protected]>
> Commit-Queue: Hao Dong <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1038332}
(cherry picked from commit 314904fc7b512e62232c74c35a066313efea2325)
Bug: 1346353
Change-Id: I456e0e6611c63224fbc7d10507fa6990452c3662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910876
Commit-Queue: Hao Dong <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049894}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913784
Reviewed-by: Lijin Shen <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#103}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert ChromeMessageQueueMediator to hide messages on Start surface
Revert crrev.com/c/3781417 and crrev.com/c/3892635
(cherry picked from commit af0e77a27f9cd489ba03b0d94074f5a22bdaf375)
Bug: 1346777
Change-Id: I33aed64b0b93f06cf9f7c95323547b6176913bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910671
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049889}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914290
Cr-Commit-Position: refs/branch-heads/5304@{#102}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Removes the dev suffix from GET_COOKIE_INFO flag.
This will expose the feature to non debug builds.
(cherry picked from commit 9cf1420476fd508f54562f884493d003f02bf321)
Bug: 1345878
Change-Id: Ib2e726096ab8bb34f532196bb3e279d6306aa9c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910131
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Alex Mitra <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049726}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909421
Cr-Commit-Position: refs/branch-heads/5304@{#101}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Autofill Assistant][M107 merge] QR Code resource id not found bug fix
- Prompt QR Code action was not working because of resource not found
exception.
- We were generating resource id from the package name and drawable file
name. It seems that due to resource minification, it was not able to
get correct resource id from the given package name.
- We are now simply passing resource id from the permission enum and
then setting image drawable.
(cherry picked from commit 7d967cac4d9160a60cb52de2697b705f6119700d)
Bug: 1366389
Bug: b/247725256
Change-Id: I784632a2969ddec5c23b2d4d52450b54095ea861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907159
Commit-Queue: Vinit Solanki <[email protected]>
Reviewed-by: Shashank Jain <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049580}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910209
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#100}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Journeys] Make enterprise policy work on Android
Two notable changes:
* Compile the policy for Android and add it to test cases/templates
* Disable opt out when policy controlled
(cherry picked from commit 01e95120442df8a87eed55b769792d5ca2369c05)
Bug: 1364755
Change-Id: I735389aa13df8e3753012e3f39f54a69fb80b551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902633
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049830}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914352
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#99}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Rename tabGridActive to reflect external getter
isTabGridVisible is the name of the external getter, so the impl
getter must be of the same name.
(cherry picked from commit c699ec666a70d35a5af9e406456561839f006d18)
Bug: 1299152
Change-Id: I17f10ab8a099a3e1c08b73d4bed00cbbc7c42d47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905935
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049482}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914174
Commit-Queue: Rohit Rao <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#98}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Fix logo visibility when changing DSE.
With the shortcut in updateVisibility(), logo view's visibility isn't updated when the logo shouldn't be shown, since the initial value of mShouldShowLogo is false. This CL removes the shortcut.
(cherry picked from commit 16b89b6486ae1a58d2717856a2454730d5010ea5)
Bug: 1366335
Change-Id: I136e3c2b7f47b4dd2b67b13f131679dd27c54c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910349
Reviewed-by: Xi Han <[email protected]>
Auto-Submit: Hao Dong <[email protected]>
Commit-Queue: Filip Gorski <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049846}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913764
Commit-Queue: Hao Dong <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#97}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Rate limit AddToHomescreen feature using feature engagement
(cherry picked from commit d8566c611a75a662dd76dca66af77b57f31ca346)
Bug: 1359451
Change-Id: I5700cace3e95cd45c9768db60e193b2b9f883342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3876805
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048729}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913905
Cr-Commit-Position: refs/branch-heads/5304@{#96}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Fix a DCHECK hit caused by spellchecker invocation en-entry
Previous patch (crrev.com/c/3835143) adds some flags to record the
reasons why spellchecker is triggered. The flags are cleared when the
spellchecker invocation is finished.
This creates a regression if:
- Spellchecker updates style and layout during invocation
- The layout update resets focus
- The focus reset triggers spellchecker
Then we set the trigger reason during an invocation, and then the reason
is cleared when the invocation finishes. Next time when spellchecker is
invoked, it hits a DCHECK as it can't find the trigger reason.
This patch fixes it by not triggering spellchecker if we are in the
middle of an invocation.
(cherry picked from commit f704fa58aa6a15872ba27383b2ac46dd53e8e02f)
Fixed: 1366033
Change-Id: I06ddb1abf4fc09a6bf4b42af8b8c03e2df00e2b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908468
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049498}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914170
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#95}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107 Merge][ntp] Add customize_chrome::IsSidePanelEnabled()
This CL gates customize chrome side panel code behind both the
kUnifiedSidePanel and kCustomizeChromeSidePanel flags.
This is necessary as the customize chrome side panel is only
supported with the new unified side panel API.
(cherry picked from commit 1b7f815f2776c97abd2bbd839a16c886012c8c90)
Bug: 1364918, 1356955
Change-Id: I2842ec5a83d4e86e956ef537c732d8f91c726114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904563
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048774}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910757
Commit-Queue: Tom Sepez <[email protected]>
Auto-Submit: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#94}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Subscriptions] Delete the whole storage before every sync
We should delete the whole storage before every sync to ensure the local
cache is up to date after the sync. Otherwise, we may have async issues
since we only compare each subscription's type, id type and id, while
their timestamp, user seen offer, etc. could also be different.
(cherry picked from commit cf0596b83b556dc0a9543c2c7ec8f212e99a8105)
Bug: 1366041
Change-Id: I89ab3af0126aa6dd2b450ba9a3ff7052682345ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906267
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Zhiyuan Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049743}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914506
Commit-Queue: Matthew Jones <[email protected]>
Auto-Submit: Zhiyuan Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#93}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M-107] Guard against double unlock in ScreenLocker
It is possible for ScreenLocker::OnAuthSuccess to be invoked twice
within one unlock attempt. This can cause issues for lower level code
that holds assumptions on the number of times it's going to be called,
potentially leading to crashes due to use-after-free bugs.
(cherry picked from commit 713f5246e3b96e6e9d3c19ffd845c80c5711c14e)
Bug: 1353103
Change-Id: I9d0922c05f1f57c552e4707c53d336453fb0b072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902343
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Elie Maamari <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048143}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914204
Reviewed-by: Denis Kuznetsov <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#92}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Polish backpress related metrics recording.
1. Some histograms are not recorded in CCT. TOOLBAR_TAB_CONTROLLER is
not recorded in CCT when back press refactored is enabled.
2. Removed logics of handling bottom sheet and full screen mode in CCT,
because they have been handled in ChromeActivity#handleOnBackPressed.
3. MINIMIZE_APP_AND_CLOSE_TAB is not recorded in CTA when back press
refactor is disabled and no valid tab is available.
(cherry picked from commit 4bcb9c826f98dcf2c1ad145c96dcffc267e92bf5)
Bug: 1365625
Change-Id: I2e5a75cc34ecf34b5e11702f3ab3974c5e12df8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905466
Reviewed-by: Ella Ge <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049307}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914387
Cr-Commit-Position: refs/branch-heads/5304@{#91}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Start] Fix profile icon doesn't show on Start after sign in.
The bug was only happens the first time when a user launches chrome and doesn't repro after relaunching Chrome. The StartSurfaceToolbarMediator registers to a ObservableSupplier<Boolean> identityDiscStateSupplier which fails to be triggered when identityDiscController notifies its observer with the same value of canShowHint = true. To fix the issue, StartSurfaceToolbarMediator needs to register to identityDiscController directly, and thus will always get notified with the latest canShowHint.
(cherry picked from commit 0f00fccf3245cdd93908e2bd305912e86241eec9)
Bug: 1365270
Change-Id: I6935193655b8be40618de0cfc52e6568ec083b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906087
Reviewed-by: Filip Gorski <[email protected]>
Reviewed-by: Hao Dong <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049703}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913704
Cr-Commit-Position: refs/branch-heads/5304@{#90}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107]Fix the title of the lock screen online reauth dialog
Typos in html code resulted in showing
"[[i18n('samlNotice', authDomain]]" as a title.
(cherry picked from commit 6d06d54935c6ac63ba40a970a84befc8ed788e73)
Bug: 1366334
Change-Id: I7e4089d13340755fc3c3308d67f4ca6fb49827da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909648
Commit-Queue: Andrey Davydov <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049643}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910129
Cr-Commit-Position: refs/branch-heads/5304@{#89}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[CVC] Accessibility Fixes for CVC Prompt V2
This patch addresses some Accessibility issues discovered in the
Accessibility Review of
https://bugs.chromium.org/p/chromium/issues/detail?id=1351481
Fixes:
- Make Voice Over announce the Prompt title and instructions when
presented.
- Make Voice Over announce the content of Expiration Date Cell.
- Prevent Voice Over from announcing the icon in the CVC Cell.
- Make Voice Over announce instructions after CVC or Expiration Date
forms are displayed. This helps users understand what they are
supposed to do next.
- Prevent Voice Over from announcing autocorrection when the
Expiration Date field is activated because a custom Date Picker is
used as Input View.
(cherry picked from commit b2eefdcc8856ba9c4b77a7e52ea58069384b14ae)
Bug: 1364776
Change-Id: If237adb51f3437d1de42807a0898462d14dc8c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902981
Reviewed-by: Gauthier Ambard <[email protected]>
Quick-Run: Ernesto Izquierdo Clua <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Ernesto Izquierdo Clua <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909638
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Ernesto Izquierdo Clua <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#88}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][beacon-api] Fix renderer crashes caused by accessing unbound remote
CP approved at https://crbug.com/1364348#c10
- Stacktrace: https://crbug.com/1364348#c5
- Details Explained: https://crbug.com/1364348#c7
When a document is unloaded, it's possible that a `PendingBeacon`'s `timeout_timer_` stays alive even after the ExecutionContext is gone (detached). In such case, `PendingBeacon::TimeoutTimerFired()` will lead to a crash due to accessing `remote_` which is unbound.
The crash can be reliably reproduced by setting a short timeout in PendingGetBeacon ctor and unloads the document quickly.
(But still not sure why a PendingGetBeacon() with default (negative) timeout can trigger `TimeoutTimerFired()`.)
This CL makes `PendingBeacon` implements
`ExecutionContextLifecycleObserver` and handles such case in
`ContextDestroyed()` method.
Also updates the sendondiscard web tests:
- Before: PendingPostBeacon was not covered. Beacons with different timeout/backgroundTimeout were not covered.
- After: better cover the behaviors of sending beacons on page discard with different timeout/backgroundTimeout values (which should not be used at all though)
(cherry picked from commit 247bafd09cd08fbd53f9e678a23c829cd5b7e2df)
Bug: 1364348,1293679
Change-Id: I44edc6ddde20c75f8bbcca0d2b452504517530b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901567
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Ming-Ying Chung <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048952}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910211
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#87}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][PriceTracking] Add color overlay to product images
This CL adds a color overlay over the product images in price tracking
list, so that if the product image background color is white, users
would still be able to find the border of the image.
Before: https://screenshot.googleplex.com/AZ4xbyQ4PeiWMNh
After: https://screenshot.googleplex.com/5DA5XhWmsYXWSv9
(cherry picked from commit a8c89ebfd614dd1f69c6146a1ec6fc74400dfe9b)
Bug: 1346624, 1364727
Change-Id: Ieb376aea0e6522aee8b166c1a5d2cb6b524aa85e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900430
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049271}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912117
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: John Lee <[email protected]>
Auto-Submit: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#86}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Extensions] Stop Webstore from modifying policy installed extensions
Normally only component or policy installed extensions are allowed to
modify policy force installed extensions. This CL adjusts that to
disallow this for the webstore hosted app, even though it is considered
to be a component extension. This is a quick fix to stop bookmarklets
from being able to use the management API exposed on the Webstore to
modify policy installed extensions.
In the future it would be good to add a more robust way in Blink to just
fully block bookmarklets on specified Origins.
(cherry picked from commit 13ea20bc824a13c94fc496167142b73fe77400aa)
Bug: 1363793
Change-Id: I097dec2605f864322ca970d03497a89e9427a106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906107
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Tim <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048959}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911721
Reviewed-by: David Bertoni <[email protected]>
Commit-Queue: David Bertoni <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Tim <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#85}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[cherry-pick][memories][persist-clusters] Fix continuation times.
Fix persisted cluster continuation times. Previously, persisted clusters
used the visit time of their oldest visit as the continuation time for
the next request. This CL fixes them to use the visit time of their
newest visit. This does not effect non-persisted clusters, which use the
visit time of the oldest visit sent for clustering. Without this fix,
some persisted clusters are skipped.
(cherry picked from commit e359c3b665244115fa41111e5d2e03abf62caf47)
Bug: 1184879, 1184875, 1171352
Change-Id: I341547a5fc2466173acdff80f33498689ed01b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905048
Reviewed-by: Tommy Li <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049398}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911288
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#84}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Add origin trial PermissionsPolicyUnload.
This includes a feature-flag to be used as a kill switch.
(cherry picked from commit 2dc337fca54caa1e72d8fc79b318ca017b17a0f6)
Bug: 1324111
Change-Id: I91321abd44aeca7573f2e8d5342a671bcfcfa376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3875068
Reviewed-by: Ian Clelland <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Fergal Daly <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047766}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907160
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#83}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[PCCT] Fix PCCT closed when multiple swipes up
If the user does multiple quick drags up, it happens at times that the velocity of some drags is less than the minimum we allow for a drag operation and thus the fling distance when calling #onDragEnd is 0. At times, this results in the finalY and initialY to be equal. In such cases, no movement nor animation is required for the PCCT, so the existing implementation just returns false. This has the side behavior that the PCCT is being closed because #onDragEnd returns false. However, in the case finalY and initialY are equal, we don’t want to close the tab, but we still need to run the rest of the #onDragEnd method and #onAnimationEnd, to make sure that all the values that we hold in relation to the window position are correctly updated. Removing the check in this change allows the rest of the logic to be executed and values updated correctly. The animation logic is still called, however, given that the initial and final position are the same, this has no perceived user impact.
(cherry picked from commit 3fe9f01f853ef09e70977851d652d4ac40c71d80)
Bug: 1360444
Change-Id: Ia6d2736b9fafcaaccf8b23ef7aa2a782ebe67c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901022
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Kevin Grosu <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049379}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911724
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#82}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.10
Change-Id: Ibe82cbceeba3e86f39ceae5ab9533a2fabe2fd01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912195
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#81}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Continue to try to dns-prefetch and preconnect in Blink even if PreconnectInNetworkService is enabled.
The network service will only do it if prefs::kNetworkPredictionOptions is enabled and there are no extensions with WebRequest permission, since it's not known yet if the request will be blocked. So it could be that the browser/network processes don't allow this but the resource isn't blocked. As a result we should still process it in the renderer. If the browser didn't block it, then this should be a no-op.
(cherry picked from commit 324b850363b41090ba491245ba359f62d419cc5b)
Bug: 1357161
Change-Id: I93a9f30bde09c2265569aa00bb5553981f7a4d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901265
Commit-Queue: Nate Chapin <[email protected]>
Auto-Submit: John Abd-El-Malek <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049205}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910707
Cr-Commit-Position: refs/branch-heads/5304@{#80}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][DownloadBubble] New Download UX in PWAs
Show the Download Toolbar Button in the PWA WebAppFrame. Gate this
behind the DownloadBubble flag as a kill switch.
Screencast: http://go/scrcast/NDcyNDE5NzEwNTMzNjMyMHxmMjZjZDcyNy1jYg
(cherry picked from commit 970b42048529872cd799057244a5d148e64eb780)
Bug: 1333459
Change-Id: I8ca8a514c8ed977023cb746f86fa1fe1677d6077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892596
Commit-Queue: Rohit Bhatia <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Mike Wasserman <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048074}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911038
Cr-Commit-Position: refs/branch-heads/5304@{#79}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Omnibox] Update the corners in Search Widget
Before: https://screenshot.googleplex.com/4z4jZbZxkreXojp
After : https://screenshot.googleplex.com/AR6HKMM3x3PtNNa
(cherry picked from commit 90ada6c2b7edc9b9e674ec0b6d4c5597026eecf7)
Bug: 1365997
Change-Id: Idc7eefb2863e0345d8c6a902a1f5c9229bc02d6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907337
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049331}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911051
Cr-Commit-Position: refs/branch-heads/5304@{#78}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Limited price tracking CPA to non-tracked pages
This CL updates the price tracking input delegate to check if a URL is
already price tracked. If it is then we won't display a contextual
page action button on it.
(cherry picked from commit d13dd084f1a4729b4956102fd4bd33cece872fcc)
Bug: 1362112
Change-Id: Id141d94109fabfeb21e84d7a440266bc763d7d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900234
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Salvador Guerrero Ramos <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910758
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Auto-Submit: Salvador Guerrero Ramos <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#77}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[cherry-pick][omnibox][post-ac][grouping] Set `suggestion_groups_map_` for swap/copy.
Currently, `AutocompleteResult::Reset()` correctly sets both `matches_`
and `suggestion_groups_map_`.
But, `Swap()` and `CopyFrom()` only set `matches_` and forget to set
`suggestion_groups_map_`.
With this CL, all 3 methods update both fields.
This will likely be merged to m107.
(cherry picked from commit 7e0cbe42799a63a0c75f59f155946507ed1bfaba)
Bug: 1365614, 1340291
Change-Id: Ia72b935648e37408c503028bde3adafc8fc9c02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906109
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048859}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908739
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#76}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Update back press state as soon as tab goes back.
It seems after tab#goBack is triggered,
WebContents#navigationEntryCommitted is not fired immediately. During
this short period, user might perform back press which causes an
assertionError since back press state is not up-to-date yet.
This CL also polishes BackPressManager to ensure histogram is recorded
before crash occurs.
(cherry picked from commit 6ad91970a75ffe86952a574ca5b740cfce5e889f)
Bug: 1360983
Change-Id: I64ea461479384c9f802268dd91ae810240be4a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900597
Reviewed-by: Jinsuk Kim <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048062}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910850
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#75}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[CrOS SLP] Disable SIM Lock Policy by default.
SIM Lock Policy will now target 108 instead of 107.
(cherry picked from commit 95ed0e9c6eeae34eae94bd4bcefe89760910c5d8)
Bug: b/247884361
Change-Id: I8e39c7c8b782c66fae6e9469693007d1fc17fbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911035
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Regan Hsu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049764}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910701
Cr-Commit-Position: refs/branch-heads/5304@{#74}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107][UPM][UPMErrorUI] Show UPM error UI only 1x/24h
... and 30 mins after a sync error prompt.
Conversely sync error prompts should only be shown 30 mins after a UPM
error prompt
LOW_COVERAGE_REASON=The new code in the sync util is fully covered by unit tests. It's unclear why this is not detected.
(cherry picked from commit c59ec9204b49fe90eadd74bde4c40866b846867c)
Bug: 1352415, 1364572
Change-Id: I5d5bfa44a17ffbf73babe0d21d792b142f7685c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899791
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Maksim Moskvitin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049115}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910130
Cr-Commit-Position: refs/branch-heads/5304@{#73}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.9
Change-Id: I919c7e314746cf2916e403031e3c1f9078df2c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911156
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#72}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Prevent resetting NonModalPromo reason when changing tabs
The bug was that cancelling the timer had unwanted side effects when
there was no timer to cancel. It should only clear the promo reason
when there is an inprogress timer.
(cherry picked from commit e97c93a24a0a8294c34e51aa547b26f4f3129d2f)
Bug: 1364614
Change-Id: Ic52b63b342d8f71b67f9c9fc86668675848c3af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906264
Auto-Submit: Robbie Gibson <[email protected]>
Reviewed-by: David Jean <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049175}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910957
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#71}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Handle null policy container in WriteRegistrationDataInBatch registration
In https://crrev.com/c/3870852, we made policy container policies
optional in service worker registration data, but we still DCHECK it
in WriteRegistrationDataInBatch which most likely cause the crash in
https://crbug.com/1360970.
Since the policy container policies aren't mandatory now, this CL
removes some unnecessary initializations from some unit tests so that we
also test parsing null policy container policies. Then, the test would
crash on the above-mentioned DCHECK.
Now that we can reproduce the crash in unittests, in order to fix it,
this CL just skips the part of setting policy container data on the
proto when the policy container policies are null.
(cherry picked from commit 6ac5d9d86755143947fcdbc2840345d9a3ff2f51)
Bug: 1360970
Change-Id: I46d84555be616a5db2e2cb29f034b4e4555e1e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905149
Reviewed-by: Ben Kelly <[email protected]>
Commit-Queue: Jonathan Hao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910132
Commit-Queue: Ben Kelly <[email protected]>
Auto-Submit: Jonathan Hao <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#70}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
To M107 (of Trunk (M108) Revert "MSE-in-Workers: Launch by switching features to stable")
This reverts commit d32d977b567e153ae9a41379ab87000c51e60568.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1358542
Original change's description:
> MSE-in-Workers: Launch by switching features to stable
>
> Switches the two RuntimeEnabled features that enable MSE-in-Workers
> from experimental to stable status:
> MediaSourceInWorkers: Basic support, still using legacy object
> URLs for attachment
> MediaSourceInWorkersUsingHandle: Upgraded to match updated MSE spec, final PR linked below.
>
> Updates the stable webexposed expectations for both the Main/Window
> context and the DedicatedWorker context.
>
> MSE spec PR with handle usage refinements:
> https://github.com/w3c/media-source/pull/306
>
> Intent-to-ship=https://groups.google.com/a/chromium.org/g/blink-dev/c/FRY3F1v6Two
> Though this is landing in trunk, expectation is to request merge of
> this to M105 branch ASAP once landed and baked, to meet the intent of
> shipping in M105.
>
> BUG=878133
>
> Change-Id: If8c429b3615a6539699c4fb0e744e9f848ab1226
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781750
> Commit-Queue: Matthew Wolenetz <[email protected]>
> Commit-Queue: Mike Taylor <[email protected]>
> Auto-Submit: Matthew Wolenetz <[email protected]>
> Reviewed-by: Mike Taylor <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1030243}
(cherry picked from commit 887a8c4e3d5203b0528e7c911b24be3aa67d2b4e)
Bug: 878133, 1358542
Change-Id: I5b15b0f244962c727099132a7d1e70d67e1d247e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905489
Reviewed-by: Mike Taylor <[email protected]>
Commit-Queue: Matthew Wolenetz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048799}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908161
Cr-Commit-Position: refs/branch-heads/5304@{#69}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Journeys] Use rounded rect bg for cluster start icon
(cherry picked from commit d6a67cfd8e2f3cdd456dcab2c17c69c0016c736f)
Bug: 1361154
Change-Id: Ib2a75687136144d51d52a86506720fea618ff9a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892195
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049128}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910720
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#68}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Record the reason for IPH dismissal
This CL adds an enum histogram to record how the IPH was dismissed.
(cherry picked from commit 0584a8b11aab8523183e4137299ce08abbcaac3b)
Context: http://docs/document/d/1hoO_zOLeKzEDfuETrsZ9Dh0thW93Z6_aOmLeoSw6rjU?resourcekey=0-fdd-2WXmBiXJgYS43xdkLg
Bug: 1361978
Change-Id: Ib90d7175bf11b81ee7a2697f62497cb5e5ce3ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3887538
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Louis Romero <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047935}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907757
Reviewed-by: Tommy Nyquist <[email protected]>
Auto-Submit: Louis Romero <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#67}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M-107]Revert "WebUI: Move cr and i18n_template_no_process to last user, fork util"
This reverts commit 4d00273604676a17359956d64f79e9f39973be18.
Reason for revert: b/246956397
Original change's description:
> WebUI: Move cr and i18n_template_no_process to last user, fork util
>
> Forking util to continue providing a minimal util.js for remaining
> pre-JS modules users (security interstitials, ios inspect). Checking
> in module util.m.js.
>
> Moving cr and i18_template_no_process to the last runtime user,
> arc_support.
>
> Bug: 1173575
> Change-Id: I970c0f47a08bd957a201b12011d99628ecd9aab4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3889260
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Commit-Queue: Rebekah Potter <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047101}
(cherry picked from commit 10b0b405c1fa99228325e4490d69f1439441faf2)
Bug: 1173575
Change-Id: Iea4c3f30e5a6d9204ab9d53099784948ebbb44a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900626
Commit-Queue: Andrew Xu <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Owners-Override: Fergus Dall <[email protected]>
Owners-Override: Andrew Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047968}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910836
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#66}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Fix RecentTabs sessions removal
The Recent Tabs -removeSessionSections was removing the sections from
the model while iterating through the tableView sections, leading to
a discrepancy.
Delete the sections after iterating through all the ones to be deleted.
(cherry picked from commit 84b8e7f20ccb7fd38b305b7e9b74cc8b2ce83e85)
Fixed: 1356603, 1050786
Change-Id: If214c58f5d50d422cb6ab5f6e69c0c79d9b2a9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899082
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Louis Romero <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048596}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904271
Reviewed-by: Louis Romero <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#65}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Fix ref-counting race condition on ElementAnimations
During commit the impl thread calls the const version of
GetElementAnimationsForElementId() on the main thread animation host.
Before this patch, that method returned a scoped_refptr<>, which would
increment the ref count on ElementAnimations. If the main thread is
blocked during commit, then that's not a problem; but with
NonBlockingCommit enabled it's racy.
Because the access is const, and because the main thread is prevented
from modifying animation data while commit it happening, it's safe
to return a raw pointer. Nevertheless, this patch also makes the
method private as a small safety measure.
Cherry-picked from:
https://chromium-review.googlesource.com/c/chromium/src/+/3871507
Change-Id: Ie34b21d9dfb70b08f1bae5d8b67a02db2d3f73ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907941
Auto-Submit: Stefan Zager <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#64}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Incrementing VERSION to 107.0.5304.8
Change-Id: Ic5798636fb2ce7d70851fb6cbc27d0e1fbd71c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911195
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{#63}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Omnibox] Calling setTint instead of setColorFilter in ToolbarPhone
We use #setColorFilter when create the background[1]. For our new
experiment, we also update background color by #setTint[2]. But Using
#setColorFilter will disable tint[3], ex, Omnibox in
https://screenshot.googleplex.com/9dyYPGbwfw2sLYy.
Since http://g/chromium-dev-internal/HIJYVwLVdOQ/4xFXaCVZAQAJ?hl=en,
we can remove setColorFilter now, so using #setTint all the place will
make the color of the Omnibox as our expected.
Before: https://screenshot.googleplex.com/9dyYPGbwfw2sLYy
After : https://screenshot.googleplex.com/8ypyx5pDSVxP6eU
[1]:
https://crsrc.org/c/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;l=357?q=createModernLocationBarBackground&sq=&ss=chromium%2Fchromium%2Fsrc
[2]:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java;l=50;drc=4c33ea7ce9a4064087f939723c0e9713193cf54f;bpv=1;bpt=1
[3]:
https://developer.android.com/reference/android/graphics/drawable/Drawable#setColorFilter(int,%20android.graphics.PorterDuff.Mode)
(cherry picked from commit 33eba97d186d1059a065d0319afda7780d25529a)
Bug: 1365658, 1239289
Change-Id: I64a4effeff4ec6904d599316d2bed4cfb2e9f3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905754
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048900}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908992
Cr-Commit-Position: refs/branch-heads/5304@{#62}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Android][UPM] Suspend saving for persistent GMS errors
With this change, any authentication error (resolvable and unresolvable)
will set the kSavePasswordsSuspendedByError pref which prevents
users from saving passwords.
To ensure consistent application, the override is applied when querying
the PasswordManagerSettingsService for the value of
PasswordManagerSetting::kOfferToSavePasswords.
The override is reset as soon as the backend completes the first call
to GMS successfully again — e.g. on start or on a pageload.
If the pref is set, the settings service returns that offer to save
passwords is turned off.
If the user is unenrolled or leaves the experiment, the pref becomes
inactive.
The pref is not synced. It's false by default and is always set by the
latest PasswordStoreAndroidBackend to retrieve logins.
(cherry picked from commit 00c380f2c121adcaa00ea4985ca5c947ba962cf5)
Bug: 1352415, 1364084
Change-Id: Ic1ed611693b982fa01d1ab2dc233d3e12f8f0a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899116
Commit-Queue: Friedrich Horschig <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049030}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907760
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Auto-Submit: Friedrich Horschig <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#61}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Updating XTBs based on .GRDs from branch 5304
Change-Id: I4d6f3ba9505cf8a770ab59722ada0eb4d0583478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3909708
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#60}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Fix Memory.TotalPMF VisibleOrHigherPriority names
A typo was made inverting the word order in the histograms.xml file. Update it to match the name of the emitted histogram.
The correct terms are:
* Memory.Total.PrivateMemoryFootprintVisibleOrHigherPriorityRenderers
* Memory.Total.RendererPrivateMemoryFootprintVisibleOrHigherPriority
The error was
* Memory.Total.PrivateMemoryFootprintVisiblePriorityOrHigherRenderers
* Memory.Total.RendererPrivateMemoryFootprintVisiblePriorityOrHigher
Emission source:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/metrics/process_memory_metrics_emitter.cc;drc=91feed662c315a8fee1f716af09005fd29879bcb;l=1360
(cherry picked from commit 27d75673659974918a6d6d258f3fdac53c826fbe)
Bug: 1361024
Change-Id: I0f12d6bb27fca12c215d0ef405806a4709cafce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900515
Reviewed-by: Benoit Lize <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048663}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906388
Owners-Override: Yaron Friedman <[email protected]>
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#59}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "Partially restore cr.js to ash/webui/common" [M107]
This reverts commit bb89f22df050de2f7c833710311b393b845d04d1.
Reason for revert: Required to revert CL:3889260
Original change's description:
> Partially restore cr.js to ash/webui/common
>
> A few additional ChromeOS usages were discovered while investigating
> other non-module files.
>
> Removing some usages, where the file is not actually used, as well as
> some even older usages of the removed ui.js, which was not used either
> and removed over a week ago.
>
> Also restoring the "addSingletonGetter" method, since it is used by
> mobile_setup_portal.
>
> Bug: 1173575
> Change-Id: I7116f6fb54302b40f383db6701df59fd10b00dee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3896953
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Auto-Submit: Rebekah Potter <[email protected]>
> Commit-Queue: Demetrios Papadopoulos <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047341}
(cherry picked from commit e6f272e2192641cf497ddc0e2c4dd19767c9c809)
Bug: 1364065,b:246956397
Change-Id: Icd431d7886d109d9c565ce8cf8d542d09d434abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899701
Owners-Override: Fergus Dall <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047911}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908827
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#58}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] Move LOCATION_BAR before TAB_MODAL_HANDLER
When location bar expands and tab modal displays, back press should
collapse location bar first.
See screen record: https://crbug.com/1364340#c1
(cherry picked from commit a6c5afcfaeee6bf2ca21f4c41cbc3169d38a11da)
Bug: 1364340
Change-Id: Ia9f133cd659d605405b661af3d9bcd14325be829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900503
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048170}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907717
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#57}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[iOS] Remove max width for Incognito interstitial disclaimer text
This CL allows further visual customization of Revamped and non-Revamped
incognito views, specifically the value for the maximum width of the
main stack view. This is particularly useful to allow the disclaimer
text in the Incognito interstitial to take as much space as possible.
(cherry picked from commit af23fdccdabf7ba9c5f48e435b7594aa9bf7c582)
Change-Id: I2306eb71395676bab707f990e3ba7bc81a3577a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3902039
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Quentin Pubert <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048589}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904266
Auto-Submit: Quentin Pubert <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#56}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[PCCT][TTS] Fix TTS views not responding to touch
Fixes a problem with the view hierarchy with Contextual Search live
views that appear in the Overlay, such as the promo and the Related
Searches chips carousel. We now use Chrome's "coordinator" view to
add TTS live views instead of it's parent the "content" view. This
somehow fixes some event dispatching issues that caused those views
to not be interactive on a PCCT even though they worked fine on a
regular CCT. Probably the offsetting of the PCCT window causes some
event coordinates to be shifted.
BUG=1360420,1353583,1331834,1258902
(cherry picked from commit 9d49746f0f10f4c0d83e16a2417412d07b1849be)
Change-Id: I59b1fd534c84c6336c3673c8f74a4d5bd3f033dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900054
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Auto-Submit: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047792}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908872
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#55}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
ios: Correct Stability.MobileSessionShutdownType with Crashpad.
MobileSessionShutdownType is incorrect with Crashpad, as it checks
for crash reports before Crashpad can process intermediate dumps.
Manually count pending Crashpad files as a short term solution, and
set a second metric later. If the new metric matches the old metric,
remove the manual count logic.
(cherry picked from commit e5ba1586125a94719bae140757e73713e23d15dd)
Fixed: 1365765
Change-Id: Ib4cc13fd237be358c6ebd459fc654121396e5cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906145
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049352}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906390
Owners-Override: Harry Souders <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Reviewed-by: Harry Souders <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#54}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
Revert "WebUI: Check in module post_message_api/ to ash/webui/common" [M107]
This reverts commit bf8972c0e20d897fa091446e837c947df1cf46cf.
Reason for revert: Required to revert CL:3889260
Original change's description:
> WebUI: Check in module post_message_api/ to ash/webui/common
>
> The non-module versions are no longer used anywhere. Since these files
> are only used in ash chrome, also move them to ash/webui/common/, as
> ChromeOS specific shared code should general be located there.
>
> Also removing unnecessary use of extraLibraries from the corresponding
> test, and moving it to the chromeos/ash_common/ test subdirectory.
>
> Bug: 1173575, 1347740, 1158471
> Change-Id: I1c96cb61766f269d7341d5c41ae3249a57c504b2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895351
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Commit-Queue: Rebekah Potter <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1047159}
(cherry picked from commit 85189a4fdfacae50877f421e57c83c1c74b8cdf9)
Bug: b:246956397, 1364035
Change-Id: Id50a0330da733a8ceaa1d21a790a32a580435aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3901564
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Owners-Override: Fergus Dall <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047940}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908241
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#53}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[ios] Return early if most_recent_tab is null
Patch fix for instances where the most recent tab is no longer valid
but the Start Surface is being show in a tab.
(cherry picked from commit 282147081dd8201e4f49393f457829b9901ccfe4)
Bug: 1299152
Change-Id: I2b624c55f7bb1467a3ca98d36d356d5733a20682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906371
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1049158}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908482
Owners-Override: Harry Souders <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Reviewed-by: Harry Souders <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#52}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
cc: Add finch flag to control when deferred commits resume
r1044123 enabled the compositor to process commits without synchronizing
scroll offsets which were sent in the BeginMainFrame message. This
allowed the main frame which unblocks FCP to commit in the same main
frame event.
The above is good for FCP since the content is drawn sooner. But bad for
the FCP metric which now measures latency of the complete pipeline as
opposed just the time spent on the main thread (before UpdateLayers).
This adds a finch flag to revert to the old behaviour by default and
roll the change out via finch.
R=[email protected]
(cherry picked from commit 1f3d1b1ca418e0df4584cf72b60e342e098ec8d8)
Bug: 1364393
Change-Id: I1ac113809739b5d7efe72ae24dd17b60a107c64a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899855
Commit-Queue: Khushal Sagar <[email protected]>
Reviewed-by: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908200
Commit-Queue: Ian Vollick <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#51}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
blink: Remove 'overflow:clip' UA CSS for root svg elements.
SVG elements use 'overflow:hidden' via UA CSS to clip to the content-box
by default. This should be 'overflow:clip' but hidden ensures backwards
compat with flex layout. The used value for painting is still clip.
See https://github.com/w3c/csswg-drafts/issues/7714 for details.
R=[email protected]
(cherry picked from commit 3dd11166ae3a97a41cc319eaaf47cc8ae040b89d)
Bug: 1358820
Change-Id: I79fb2e334ca72807ca6e3b12d85c1f8a33a9f086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3884796
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048721}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907698
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#50}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Fast Pair] Put forget dialog behind FP flag
The bluetooth device forget dialog was added as part of Fast Pair and
therefore should be behind the Fast Pair flag.
original dialog cl: crrev/c/3756863
(cherry picked from commit 15c2904192c0cdbaf88285d6db0a54b7d35d9e7b)
Test: Tested on DUT with flag on and off
Change-Id: Ib4b653fb40c0418be4f3c3c15bace1f240c5e8cb
Bug: b/247033179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900805
Reviewed-by: Juliet Lévesque <[email protected]>
Reviewed-by: Gordon Seto <[email protected]>
Commit-Queue: Alex Kingsborough <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048244}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905883
Cr-Commit-Position: refs/branch-heads/5304@{#49}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[M107] wayland, gtk3: fix compose key regression
This restores the InputMethodContext creation behavior before
https://crrev.com/c/3759236, by swapping ozone <=> toolkit factory calls
in LinuxInputMethodContextFactory, so that the ozone/wayland's context
impl is used only iff the LinuxUi's one returns null (eg: gtk version <
4). In that code path Chromium's ui::CharacterComposer (originally
written for ChromeOS) is used and only text-input-manager-v1 Wayland
protocol extension is supported atm.
R=[email protected], thomasanderson
(cherry picked from commit 1e5593158f6eeaadeb27dac744b08bc0e3adb3f1)
Bug: 1359676
Change-Id: I999acf013e03b10cfdd86fa5df5a59fd3296a9c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3904503
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Nick Yamane <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048823}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908442
Auto-Submit: Nick Yamane <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#48}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
[Omnibox] Invoke mLocationBarDataProvider after it initialized
Invoke mLocationBarDataProvider in initialize instead of in ctor.
(cherry picked from commit 288fe8787ff92d3f568ac21198e97d9cd004ba83)
Bug: 1365649
Change-Id: Iac8c84f7d70a1200ea7281b4a9610f68c32f5d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905671
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1048858}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3908793
Cr-Commit-Position: refs/branch-heads/5304@{#47}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
update logging parameter requirements to account for all lens cases
(cherry picked from commit 471e37e78cbd0e137f116074f8d786792aa3cd73)
Bug: 1364278
Change-Id: I69675aa154d585fc9088a48b51b3f5f6aa8ef83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895876
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Shivani Patel <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1047831}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3906231
Auto-Submit: Jack Nudelman <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/5304@{#46}
Cr-Branched-From: 5d7b1fc9cb7103d9c82eed647cf4be38cf09738b-refs/heads/main@{#1047731}
![ios/chrome/browser/ui/ntp/feed_top_section/resources/ntp_feed_signin_promo_icon.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/787cd028b698e919443968159af028156632e106/ios/chrome/browser/ui/ntp/feed_top_section/resources/ntp_feed_signin_promo_icon.imageset/ntp_feed_signin_promo_icon%402x.png){kind=link}
![ios/chrome/browser/ui/ntp/feed_top_section/resources/ntp_feed_signin_promo_icon.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/787cd028b698e919443968159af028156632e106/ios/chrome/browser/ui/ntp/feed_top_section/resources/ntp_feed_signin_promo_icon.imageset/ntp_feed_signin_promo_icon%403x.png){kind=link}